repo
stringlengths
5
53
pr_number
int32
1
321k
task_type
stringclasses
2 values
issue_text
stringlengths
0
81.2k
pr_title
stringlengths
1
319
pr_body
stringlengths
0
105k
base_sha
stringlengths
40
40
head_sha
stringlengths
40
40
gold_diff
stringlengths
0
202M
changed_files
listlengths
0
100
review_threads
listlengths
0
100
test_patch
stringlengths
0
23.4M
merged
bool
1 class
ueberdosis/tiptap
7,887
comment_to_fix
fix(core): add clearable mark option for unsetAllMarks
consider returning early to break the iteration in `nodesBetween`
aff939d846e49ede2fd5fffe5ffa80ee9259428a
5d0cea34cd0d0c2cd882889af7a912824fa72ebf
diff --git a/packages/core/src/commands/unsetAllMarks.ts b/packages/core/src/commands/unsetAllMarks.ts index 91a28962ed..4e3ce9a16c 100644 --- a/packages/core/src/commands/unsetAllMarks.ts +++ b/packages/core/src/commands/unsetAllMarks.ts @@ -4,17 +4,21 @@ declare module '@tiptap/core' { interface Commands<ReturnTyp...
[ "packages/core/src/commands/unsetAllMarks.ts" ]
[ { "comment": "consider returning early to break the iteration in `nodesBetween`", "path": "packages/core/src/commands/unsetAllMarks.ts", "hunk": "@@ -1,30 +1,64 @@\n+import type { Node as ProseMirrorNode } from '@tiptap/pm/model'\n+import type { SelectionRange } from '@tiptap/pm/state'\n+\n import type ...
true
ueberdosis/tiptap
7,887
comment_to_fix
fix(core): add clearable mark option for unsetAllMarks
Consider for..of loop which is faster than forEach method
aff939d846e49ede2fd5fffe5ffa80ee9259428a
5d0cea34cd0d0c2cd882889af7a912824fa72ebf
diff --git a/packages/core/src/commands/unsetAllMarks.ts b/packages/core/src/commands/unsetAllMarks.ts index 91a28962ed..4e3ce9a16c 100644 --- a/packages/core/src/commands/unsetAllMarks.ts +++ b/packages/core/src/commands/unsetAllMarks.ts @@ -4,17 +4,21 @@ declare module '@tiptap/core' { interface Commands<ReturnTyp...
[ "packages/core/src/commands/unsetAllMarks.ts" ]
[ { "comment": "Consider for..of loop which is faster than forEach method", "path": "packages/core/src/commands/unsetAllMarks.ts", "hunk": "@@ -1,30 +1,64 @@\n+import type { Node as ProseMirrorNode } from '@tiptap/pm/model'\n+import type { SelectionRange } from '@tiptap/pm/state'\n+\n import type { RawCom...
true
ueberdosis/tiptap
7,889
issue_to_patch
[Bug]: @tiptap/extension-file-handler dragging inline Image inserts duplicate instead of moving ### Affected Packages @tiptap/extension-file-handler ### Version(s) 3.6.1 ### Bug Description When `FileHandler` is enabled and `Image` is configured with `inline: true`, dragging an image within the editor does not mo...
fix: prevent inline image drag creating a duplicate (file-handler + image + ResizableNodeView)
## Changes Overview When the `Image` extension is configured with `inline: true` or `resize` enabled, dragging an image within the editor inserts a duplicate at the drop position instead of moving it. The bug only affects the `inline`/`resize` configuration — default block images work correctly. ## Implementation...
aff939d846e49ede2fd5fffe5ffa80ee9259428a
7e404975baedeb47abd428fb7eac27c719466a20
diff --git a/.changeset/2026-05-29-file-handler-inline-image-drag-duplicate.md b/.changeset/2026-05-29-file-handler-inline-image-drag-duplicate.md new file mode 100644 index 0000000000..e370b4258c --- /dev/null +++ b/.changeset/2026-05-29-file-handler-inline-image-drag-duplicate.md @@ -0,0 +1,9 @@ +--- +'@tiptap/core':...
[ ".changeset/2026-05-29-file-handler-inline-image-drag-duplicate.md", "packages/core/src/lib/ResizableNodeView.ts", "packages/extension-file-handler/src/FileHandlePlugin.ts", "packages/extension-image/src/image.ts" ]
[]
true
ueberdosis/tiptap
7,894
issue_to_patch
Blockquote does not add new line at the end when rendering to markdown ### Affected Packages @tiptap/static-renderer ### Version(s) 3.10.1 ### Bug Description When rendering to markdown block quotes do not add a trailing new line causing content below to render incorrectly. ### Browser Used Chrome ### Code E...
fix(static-renderer): ensure blockquote markdown includes trailing newline
## Changes Overview Fixes blockquote markdown rendering in the static renderer — blockquotes now emit a trailing newline so that any content following them is correctly parsed as separate elements rather than as a continuation of the blockquote. Closes #7223 ## Implementation Approach Added a trailing `\n` to the `...
aff939d846e49ede2fd5fffe5ffa80ee9259428a
ce3dd91c538907db56177aaba78cd20f420899db
diff --git a/.changeset/2026-05-30-blockquote-markdown-trailing-newline.md b/.changeset/2026-05-30-blockquote-markdown-trailing-newline.md new file mode 100644 index 0000000000..354baa0678 --- /dev/null +++ b/.changeset/2026-05-30-blockquote-markdown-trailing-newline.md @@ -0,0 +1,5 @@ +--- +'@tiptap/static-renderer': ...
[ ".changeset/2026-05-30-blockquote-markdown-trailing-newline.md", "packages/static-renderer/__tests__/md-string.spec.ts", "packages/static-renderer/src/pm/markdown/markdown.ts" ]
[]
diff --git a/packages/static-renderer/__tests__/md-string.spec.ts b/packages/static-renderer/__tests__/md-string.spec.ts index a0caba6732..50356cb1a1 100644 --- a/packages/static-renderer/__tests__/md-string.spec.ts +++ b/packages/static-renderer/__tests__/md-string.spec.ts @@ -259,6 +259,106 @@ describe('static render...
true
ueberdosis/tiptap
7,895
issue_to_patch
Html attributes not added to image when resize enabled ### Affected Packages extension-image ### Version(s) 3.10.7 ### Bug Description Hi all, I am trying to add html attributes to an image I want to enable resize for. The package versions are the following: react: 19.2.0 @tiptap/extension-image: 3.10.7 @tiptap/...
fix(extension-image): ensure HTMLAttributes are applied in editor DOM when resize is enabled
## Changes Overview Fixes a bug where `HTMLAttributes` configured on the Image extension (e.g., `class: "my-classname"`) were silently dropped from the editor DOM when `resize.enabled` is `true`. ## Implementation Approach The Image extension has two rendering paths: - **`renderHTML`** — used by `editor.getHTML()` ...
aff939d846e49ede2fd5fffe5ffa80ee9259428a
be2548d6bfb268cfb735bd7f6443526d001addf6
diff --git a/.changeset/2026-05-30-image-htmlattributes-resize.md b/.changeset/2026-05-30-image-htmlattributes-resize.md new file mode 100644 index 0000000000..dca32246bd --- /dev/null +++ b/.changeset/2026-05-30-image-htmlattributes-resize.md @@ -0,0 +1,5 @@ +--- +'@tiptap/extension-image': patch +--- + +Fix `HTMLAttr...
[ ".changeset/2026-05-30-image-htmlattributes-resize.md", "packages/extension-image/__tests__/image.spec.ts", "packages/extension-image/src/image.ts" ]
[ { "comment": "`mergedAttributes.src` can be `null`/`undefined` (the schema default for `src` is `null`), and assigning that directly to `HTMLImageElement.src` coerces it to a string (e.g. `\"null\"`), potentially triggering an unintended network request and producing incorrect DOM. Guard the assignment so `src`...
diff --git a/packages/extension-image/__tests__/image.spec.ts b/packages/extension-image/__tests__/image.spec.ts new file mode 100644 index 0000000000..4db9da71fc --- /dev/null +++ b/packages/extension-image/__tests__/image.spec.ts @@ -0,0 +1,221 @@ +import { Editor } from '@tiptap/core' +import Document from '@tiptap/...
true
ueberdosis/tiptap
7,895
comment_to_fix
fix(extension-image): ensure HTMLAttributes are applied in editor DOM when resize is enabled
`mergedAttributes.src` can be `null`/`undefined` (the schema default for `src` is `null`), and assigning that directly to `HTMLImageElement.src` coerces it to a string (e.g. `"null"`), potentially triggering an unintended network request and producing incorrect DOM. Guard the assignment so `src` is only set when it’s a...
aff939d846e49ede2fd5fffe5ffa80ee9259428a
be2548d6bfb268cfb735bd7f6443526d001addf6
diff --git a/packages/extension-image/src/image.ts b/packages/extension-image/src/image.ts index 29414b7a80..3f42c52e54 100644 --- a/packages/extension-image/src/image.ts +++ b/packages/extension-image/src/image.ts @@ -153,7 +153,9 @@ export const Image = Node.create<ImageOptions>({ return ({ node, getPos, HTMLAtt...
[ "packages/extension-image/src/image.ts" ]
[ { "comment": "`mergedAttributes.src` can be `null`/`undefined` (the schema default for `src` is `null`), and assigning that directly to `HTMLImageElement.src` coerces it to a string (e.g. `\"null\"`), potentially triggering an unintended network request and producing incorrect DOM. Guard the assignment so `src`...
true
ueberdosis/tiptap
7,896
issue_to_patch
[Bug]: extension-table 3.23 TableView NodeView ignores HTMLAttributes (regression from 3.22.4) ### Affected Packages @tiptap/extension-table ### Version(s) 3.23.1 (also 3.23.2, 3.23.4) ### Bug Description ## Summary In `@tiptap/extension-table` 3.23.x, configuring the Table extension with `HTMLAttributes` no lon...
fix(extension-table): apply HTMLAttributes in TableView node view
## Changes Overview Fix a regression introduced in 3.23 where `Table.configure({ HTMLAttributes: { class: 'my-custom-table' } })` silently drops those attributes from the rendered `<table>` element when `resizable: false` (the default). The `TableView` node view built the DOM manually but never applied `this.options.H...
aff939d846e49ede2fd5fffe5ffa80ee9259428a
5ef1218e104bc4b3851783fa8f8c0aacb81e366e
diff --git a/.changeset/2026-05-30-table-html-attributes-nodeview.md b/.changeset/2026-05-30-table-html-attributes-nodeview.md new file mode 100644 index 0000000000..886eaa9263 --- /dev/null +++ b/.changeset/2026-05-30-table-html-attributes-nodeview.md @@ -0,0 +1,5 @@ +--- +'@tiptap/extension-table': patch +--- + +Fix ...
[ ".changeset/2026-05-30-table-html-attributes-nodeview.md", "packages/extension-table/__tests__/tableHTMLAttributes.spec.ts", "packages/extension-table/src/table/TableView.ts", "packages/extension-table/src/table/table.ts" ]
[]
diff --git a/packages/extension-table/__tests__/tableHTMLAttributes.spec.ts b/packages/extension-table/__tests__/tableHTMLAttributes.spec.ts new file mode 100644 index 0000000000..5f68894193 --- /dev/null +++ b/packages/extension-table/__tests__/tableHTMLAttributes.spec.ts @@ -0,0 +1,72 @@ +// @vitest-environment happy...
true
ueberdosis/tiptap
7,897
issue_to_patch
E2E: CustomDocument test — typing into paragraph after Enter produces empty text ## Description The E2E test `demos/src/Examples/CustomDocument/index.spec.ts:62` (both React and Vue variants) consistently fails. After clearing content, inserting a heading, pressing Enter to create a new paragraph, and typing text, th...
fix(tests): replace page.keyboard.type with locator.type to prevent focus-loss flakiness
## Changes Overview Fix a flaky E2E test pattern where `page.keyboard.type(...)` after `press('Enter')` dispatches keyboard events to a defocused element, causing text to go nowhere. The root cause is that Tiptap's `focus()` command uses `requestAnimationFrame` to call `view.focus()`. After a ProseMirror block-sp...
3d4f94c4bfd68580a49af155523b898c1eb3efd5
6e015f0d27091b628303a4c4f03aae9c81aece27
[ "demos/src/Examples/CustomDocument/index.spec.ts", "demos/src/Nodes/BulletList/index.spec.ts", "demos/src/Nodes/ListItem/index.spec.ts", "demos/src/Nodes/OrderedList/index.spec.ts", "demos/src/Nodes/Paragraph/index.spec.ts", "demos/src/Nodes/TaskList/index.spec.ts" ]
[]
diff --git a/demos/src/Examples/CustomDocument/index.spec.ts b/demos/src/Examples/CustomDocument/index.spec.ts index c85c707e7e..4fd33e212b 100644 --- a/demos/src/Examples/CustomDocument/index.spec.ts +++ b/demos/src/Examples/CustomDocument/index.spec.ts @@ -77,7 +77,7 @@ test.describe(`${demoPath}/${demoName}`, () => ...
true
ueberdosis/tiptap
7,742
issue_to_patch
fix(collaboration): onContentError not called when enableContentCheck is true
## Changes Overview Fix `onContentError` not being called even when `enableContentCheck` is set to `true`. ## Implementation Approach Changed `return false` to `return true` in the `filterTransaction` catch block. Since Yjs transactions cannot be cancelled, returning `false` caused a state mismatch between Pro...
a4b939127821aac3a2139a467c5b257dd897da4e
854276b7fd841594e54fe2eac71652aa4ae167d9
diff --git a/.changeset/fix-collaboration-content-error-handler.md b/.changeset/fix-collaboration-content-error-handler.md new file mode 100644 index 0000000000..7f72d28955 --- /dev/null +++ b/.changeset/fix-collaboration-content-error-handler.md @@ -0,0 +1,5 @@ +--- +'@tiptap/extension-collaboration': patch +--- + +Fi...
[ ".changeset/fix-collaboration-content-error-handler.md", "packages/extension-collaboration/__tests__/filterInvalidContent.spec.ts", "packages/extension-collaboration/src/collaboration.ts" ]
[ { "comment": "The test case name says it “rejects Yjs transactions…”, but the updated assertion expects `filterTransaction` to return `true` (i.e., allow the transaction). Please rename the test to reflect the new behavior (e.g., that invalid Yjs content triggers `contentError` and disables collaboration while ...
diff --git a/packages/extension-collaboration/__tests__/filterInvalidContent.spec.ts b/packages/extension-collaboration/__tests__/filterInvalidContent.spec.ts index a2eb752d58..1139f18c85 100644 --- a/packages/extension-collaboration/__tests__/filterInvalidContent.spec.ts +++ b/packages/extension-collaboration/__tests_...
true
ueberdosis/tiptap
7,742
comment_to_fix
fix(collaboration): onContentError not called when enableContentCheck is true
The test case name says it “rejects Yjs transactions…”, but the updated assertion expects `filterTransaction` to return `true` (i.e., allow the transaction). Please rename the test to reflect the new behavior (e.g., that invalid Yjs content triggers `contentError` and disables collaboration while still allowing the tra...
a4b939127821aac3a2139a467c5b257dd897da4e
854276b7fd841594e54fe2eac71652aa4ae167d9
diff --git a/packages/extension-collaboration/__tests__/filterInvalidContent.spec.ts b/packages/extension-collaboration/__tests__/filterInvalidContent.spec.ts index a2eb752d58..1139f18c85 100644 --- a/packages/extension-collaboration/__tests__/filterInvalidContent.spec.ts +++ b/packages/extension-collaboration/__tests_...
[ "packages/extension-collaboration/__tests__/filterInvalidContent.spec.ts" ]
[ { "comment": "The test case name says it “rejects Yjs transactions…”, but the updated assertion expects `filterTransaction` to return `true` (i.e., allow the transaction). Please rename the test to reflect the new behavior (e.g., that invalid Yjs content triggers `contentError` and disables collaboration while ...
true
ueberdosis/tiptap
7,742
comment_to_fix
fix(collaboration): onContentError not called when enableContentCheck is true
The changeset frontmatter uses double quotes around the package name. Other changesets in this repo consistently use single quotes (e.g. `.changeset/fix-toc-onupdate-react-render.md:2`). For consistency (and to avoid formatting churn), please switch to single quotes here as well. ```suggestion '@tiptap/extension-collab...
a4b939127821aac3a2139a467c5b257dd897da4e
854276b7fd841594e54fe2eac71652aa4ae167d9
diff --git a/.changeset/fix-collaboration-content-error-handler.md b/.changeset/fix-collaboration-content-error-handler.md new file mode 100644 index 0000000000..7f72d28955 --- /dev/null +++ b/.changeset/fix-collaboration-content-error-handler.md @@ -0,0 +1,5 @@ +--- +'@tiptap/extension-collaboration': patch +--- + +Fi...
[ ".changeset/fix-collaboration-content-error-handler.md" ]
[ { "comment": "The changeset frontmatter uses double quotes around the package name. Other changesets in this repo consistently use single quotes (e.g. `.changeset/fix-toc-onupdate-react-render.md:2`). For consistency (and to avoid formatting churn), please switch to single quotes here as well.\n```suggestion\n'...
true
ueberdosis/tiptap
7,892
issue_to_patch
feat(extension-list-keymap): lift list item before merging on backspace
## Changes Overview Make `ListKeymap`'s Backspace at the start of a non-first list item _lift_ the item out of its wrapping list, splitting the list around it, instead of immediately joining its content into the previous item. A second Backspace then hits the existing "paragraph after a list" branch and merges the l...
aff939d846e49ede2fd5fffe5ffa80ee9259428a
21cf8556f78efe160c1356da804081be26707932
diff --git a/.changeset/2026-05-29-list-keymap-backspace-lift-first.md b/.changeset/2026-05-29-list-keymap-backspace-lift-first.md new file mode 100644 index 0000000000..073466da96 --- /dev/null +++ b/.changeset/2026-05-29-list-keymap-backspace-lift-first.md @@ -0,0 +1,5 @@ +--- +'@tiptap/extension-list': minor +--- + ...
[ ".changeset/2026-05-29-list-keymap-backspace-lift-first.md", "demos/src/Extensions/ListKeymap/index.spec.ts", "packages/extension-list/src/keymap/listHelpers/handleBackspace.ts" ]
[]
diff --git a/demos/src/Extensions/ListKeymap/index.spec.ts b/demos/src/Extensions/ListKeymap/index.spec.ts new file mode 100644 index 0000000000..cb08897ed5 --- /dev/null +++ b/demos/src/Extensions/ListKeymap/index.spec.ts @@ -0,0 +1,75 @@ +import { expect, test } from '@playwright/test' + +import { getEditor } from '....
true
ueberdosis/tiptap
7,875
issue_to_patch
[Bug]: Copying table cells includes text from other cells when pasting as plain text ### Affected Packages extension-table, extension-table ### Version(s) 2.11.2 This issue is reproducing also in the Tiptap [documentation example](https://tiptap.dev/docs/editor/extensions/nodes/table-cell) with version 3.3.0. ###...
fix(core): exclude unselected cells from plain-text copy of cell selections
## Changes Overview Fixes #6867: copying a table `CellSelection` and pasting as plain text included text from cells between the selected ones. ## Implementation Approach `clipboardTextSerializer` no longer flattens `selection.ranges` to a single `min/max` window — it serializes each range independently and joi...
a42a8d6dfd6e2d9050c9a477d38b25209f1e672c
84a80af92b0dd7625ac6a254b6f393c520ad0d6c
diff --git a/.changeset/angry-donuts-study.md b/.changeset/angry-donuts-study.md new file mode 100644 index 0000000000..184504dee9 --- /dev/null +++ b/.changeset/angry-donuts-study.md @@ -0,0 +1,5 @@ +--- +'@tiptap/core': patch +--- + +Fix plain-text copy of table cell selections including content from unselected cells...
[ ".changeset/angry-donuts-study.md", ".gitignore", "packages/core/__tests__/clipboardTextSerializer.spec.ts", "packages/core/src/extensions/clipboardTextSerializer.ts", "packages/extension-table/__tests__/tableClipboard.spec.ts" ]
[ { "comment": "Remove explicit issue mention", "path": "packages/core/src/extensions/clipboardTextSerializer.ts", "hunk": "@@ -26,16 +26,23 @@ export const ClipboardTextSerializer = Extension.create<ClipboardTextSerializerO\n const { editor } = this\n const { state, schema } = edi...
diff --git a/packages/core/__tests__/clipboardTextSerializer.spec.ts b/packages/core/__tests__/clipboardTextSerializer.spec.ts new file mode 100644 index 0000000000..14202f2c18 --- /dev/null +++ b/packages/core/__tests__/clipboardTextSerializer.spec.ts @@ -0,0 +1,67 @@ +import { Editor } from '@tiptap/core' +import Doc...
true
ueberdosis/tiptap
7,875
comment_to_fix
fix(core): exclude unselected cells from plain-text copy of cell selections
Remove explicit issue mention
a42a8d6dfd6e2d9050c9a477d38b25209f1e672c
84a80af92b0dd7625ac6a254b6f393c520ad0d6c
diff --git a/packages/core/src/extensions/clipboardTextSerializer.ts b/packages/core/src/extensions/clipboardTextSerializer.ts index 7479fc9e9d..ac2123a6b9 100644 --- a/packages/core/src/extensions/clipboardTextSerializer.ts +++ b/packages/core/src/extensions/clipboardTextSerializer.ts @@ -26,18 +26,25 @@ export const ...
[ "packages/core/src/extensions/clipboardTextSerializer.ts" ]
[ { "comment": "Remove explicit issue mention", "path": "packages/core/src/extensions/clipboardTextSerializer.ts", "hunk": "@@ -26,16 +26,23 @@ export const ClipboardTextSerializer = Extension.create<ClipboardTextSerializerO\n const { editor } = this\n const { state, schema } = edi...
true
ueberdosis/tiptap
7,140
issue_to_patch
fix(extensions/placeholder): Allow emptyNodeClass take a function
Allow setting a different classname per node type in case of complex documents with multiple placeholders, by using a function as `emptyNodeClass` option for placeholder extension. ## Changes Overview Added option to pass a function to `emptyNodeClass` ## Implementation Approach Added option to pass a function...
ec1afc35ee12d24d30e0f1a31f2fd423312bd38f
95867b5ea21367f73b274be8b6a65ef6ba4fd996
diff --git a/packages/extensions/src/placeholder/placeholder.ts b/packages/extensions/src/placeholder/placeholder.ts index 3c8c483e88..7378cce187 100644 --- a/packages/extensions/src/placeholder/placeholder.ts +++ b/packages/extensions/src/placeholder/placeholder.ts @@ -40,9 +40,13 @@ export interface PlaceholderOption...
[ "packages/extensions/src/placeholder/placeholder.ts" ]
[]
true
ueberdosis/tiptap
7,885
issue_to_patch
fix(extensions/placeholder): Allow emptyNodeClass to accept a function
<!-- CURSOR_AGENT_PR_BODY_BEGIN --> Follow-up to #7140 addressing the remaining review feedback from @arnaugomez. ## Changes Overview Allow `emptyNodeClass` in the Placeholder extension to accept either a string or a function that returns a dynamic CSS class name per node. This enables different placeholder styling p...
e6554a925e901871550c654a44d1783d38f08416
39976f68ccc82d504c8ffc91c7e2eaa6979735fd
diff --git a/.changeset/2026-05-29-placeholder-empty-node-class-function.md b/.changeset/2026-05-29-placeholder-empty-node-class-function.md new file mode 100644 index 0000000000..748195665d --- /dev/null +++ b/.changeset/2026-05-29-placeholder-empty-node-class-function.md @@ -0,0 +1,5 @@ +--- +'@tiptap/extensions': mi...
[ ".changeset/2026-05-29-placeholder-empty-node-class-function.md", "packages/extensions/__tests__/placeholder.spec.ts", "packages/extensions/src/placeholder/types.ts", "packages/extensions/src/placeholder/utils/buildPlaceholderDecorations.ts", "packages/extensions/src/placeholder/utils/createPlaceholderDecor...
[]
diff --git a/packages/extensions/__tests__/placeholder.spec.ts b/packages/extensions/__tests__/placeholder.spec.ts index 734e759ea1..48a19d2573 100644 --- a/packages/extensions/__tests__/placeholder.spec.ts +++ b/packages/extensions/__tests__/placeholder.spec.ts @@ -438,6 +438,26 @@ describe('extension-placeholder — em...
true
ueberdosis/tiptap
7,868
issue_to_patch
Publish a new stable version
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will ...
7bd09b7ef89ed0734694ad3480b6c7eb8327a429
6817d14116f627d574545ab01eaa0402d7d286d6
diff --git a/.changeset/2026-05-26-fix-collaboration-caret-leak.md b/.changeset/2026-05-26-fix-collaboration-caret-leak.md deleted file mode 100644 index 7b6ea0d84c..0000000000 --- a/.changeset/2026-05-26-fix-collaboration-caret-leak.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -"@tiptap/extension-collaboration-caret": patch ...
[ ".changeset/2026-05-26-fix-collaboration-caret-leak.md", ".changeset/2026-05-27-fix-collaboration-undomanager-leak.md", ".changeset/2026-05-27-serialize-schema-omit-totext.md", ".changeset/dull-feet-tickle.md", ".changeset/fix-details-summary-focus.md", ".changeset/fix-markdown-unknown-html-tags.md", "....
[]
true
ueberdosis/tiptap
7,876
issue_to_patch
fix(extension-collaboration,extension-collaboration-caret): prevent memory leaks on destroy
The extension subscribed to provider.awareness 'update' inside addProseMirrorPlugins but never unsubscribed. With multiple editors sharing a single provider, destroying an editor left the listener attached to the long-lived awareness emitter; the closure pinned the editor and prevented garbage collection. Move the s...
400b4bb605e3e250f9f4eff80f4b4ce4cc35cbf3
b8594b2b597a0fe659cadf117047d6a2925490e9
diff --git a/.changeset/2026-05-26-fix-collaboration-caret-leak.md b/.changeset/2026-05-26-fix-collaboration-caret-leak.md new file mode 100644 index 0000000000..7b6ea0d84c --- /dev/null +++ b/.changeset/2026-05-26-fix-collaboration-caret-leak.md @@ -0,0 +1,5 @@ +--- +"@tiptap/extension-collaboration-caret": patch +---...
[ ".changeset/2026-05-26-fix-collaboration-caret-leak.md", ".changeset/2026-05-27-fix-collaboration-undomanager-leak.md", "packages/extension-collaboration-caret/__tests__/collaboration-caret.spec.ts", "packages/extension-collaboration-caret/src/collaboration-caret.ts", "packages/extension-collaboration/__tes...
[ { "comment": "`destroy()` clears the shared `provider.awareness` local `user` field (`setLocalStateField('user', null)`). If multiple editors share the same provider/awareness (the scenario described in the PR), destroying one editor will remove the local user state for *all* remaining editors on that provider,...
diff --git a/packages/extension-collaboration-caret/__tests__/collaboration-caret.spec.ts b/packages/extension-collaboration-caret/__tests__/collaboration-caret.spec.ts index fe6109281e..e6f0fd9aa1 100644 --- a/packages/extension-collaboration-caret/__tests__/collaboration-caret.spec.ts +++ b/packages/extension-collabo...
true
ueberdosis/tiptap
7,876
comment_to_fix
fix(extension-collaboration,extension-collaboration-caret): prevent memory leaks on destroy
`destroy()` clears the shared `provider.awareness` local `user` field (`setLocalStateField('user', null)`). If multiple editors share the same provider/awareness (the scenario described in the PR), destroying one editor will remove the local user state for *all* remaining editors on that provider, potentially breaking ...
400b4bb605e3e250f9f4eff80f4b4ce4cc35cbf3
b8594b2b597a0fe659cadf117047d6a2925490e9
diff --git a/packages/extension-collaboration-caret/src/collaboration-caret.ts b/packages/extension-collaboration-caret/src/collaboration-caret.ts index c4e47e8ee3..c614dd1398 100644 --- a/packages/extension-collaboration-caret/src/collaboration-caret.ts +++ b/packages/extension-collaboration-caret/src/collaboration-ca...
[ "packages/extension-collaboration-caret/src/collaboration-caret.ts" ]
[ { "comment": "`destroy()` clears the shared `provider.awareness` local `user` field (`setLocalStateField('user', null)`). If multiple editors share the same provider/awareness (the scenario described in the PR), destroying one editor will remove the local user state for *all* remaining editors on that provider,...
true
ueberdosis/tiptap
7,876
comment_to_fix
fix(extension-collaboration,extension-collaboration-caret): prevent memory leaks on destroy
This regression test asserts there is exactly 1 awareness `update` listener after editor init and 0 after destroy. But the extension also installs `yCursorPlugin(provider.awareness, …)`, which may itself register an `update` listener (now or in future versions), making the test brittle and potentially failing for reaso...
400b4bb605e3e250f9f4eff80f4b4ce4cc35cbf3
b8594b2b597a0fe659cadf117047d6a2925490e9
diff --git a/packages/extension-collaboration-caret/__tests__/collaboration-caret.spec.ts b/packages/extension-collaboration-caret/__tests__/collaboration-caret.spec.ts index fe6109281e..e6f0fd9aa1 100644 --- a/packages/extension-collaboration-caret/__tests__/collaboration-caret.spec.ts +++ b/packages/extension-collabo...
[ "packages/extension-collaboration-caret/__tests__/collaboration-caret.spec.ts" ]
[ { "comment": "This regression test asserts there is exactly 1 awareness `update` listener after editor init and 0 after destroy. But the extension also installs `yCursorPlugin(provider.awareness, …)`, which may itself register an `update` listener (now or in future versions), making the test brittle and potenti...
true
ueberdosis/tiptap
7,876
comment_to_fix
fix(extension-collaboration,extension-collaboration-caret): prevent memory leaks on destroy
The changeset says awareness state is cleared > The extension's awareness `update` listener is now removed on destroy, and the local awareness `user` state is cleared, so the editor can be garbage collected. If the PR intends to actually clear the provider’s local awareness user, the destroy hook needs to clear awar...
400b4bb605e3e250f9f4eff80f4b4ce4cc35cbf3
b8594b2b597a0fe659cadf117047d6a2925490e9
diff --git a/packages/extension-collaboration-caret/src/collaboration-caret.ts b/packages/extension-collaboration-caret/src/collaboration-caret.ts index c4e47e8ee3..c614dd1398 100644 --- a/packages/extension-collaboration-caret/src/collaboration-caret.ts +++ b/packages/extension-collaboration-caret/src/collaboration-ca...
[ "packages/extension-collaboration-caret/src/collaboration-caret.ts" ]
[ { "comment": "The changeset says awareness state is cleared \n\n> The extension's awareness `update` listener is now removed on destroy, and the local awareness `user` state is cleared, so the editor can be garbage collected.\n\nIf the PR intends to actually clear the provider’s local awareness user, the destro...
true
ueberdosis/tiptap
7,879
issue_to_patch
Omit toText property from serialized schema
<!-- CURSOR_AGENT_PR_BODY_BEGIN --> ## Changes Overview Exclude `toText` when serializing `NodeSpec` values in `@tiptap/server-ai-toolkit` schema awareness. `toText` is a function callback (like `toDOM` and `leafText`) and must not appear in JSON-serialized schema output sent to the Server AI Toolkit. ## Implementati...
2d056144ccc729a4dc69605b1fdd0baf0908e95d
798a0f931cb3af2ffeb13b65139c5fe0eb7e8a67
diff --git a/.changeset/2026-05-27-serialize-schema-omit-totext.md b/.changeset/2026-05-27-serialize-schema-omit-totext.md new file mode 100644 index 0000000000..3adf479c4a --- /dev/null +++ b/.changeset/2026-05-27-serialize-schema-omit-totext.md @@ -0,0 +1,5 @@ +--- +'@tiptap/server-ai-toolkit': patch +--- + +Exclude ...
[ ".changeset/2026-05-27-serialize-schema-omit-totext.md", "packages/server-ai-toolkit/src/schema-awareness/utils/serialize-schema.ts" ]
[ { "comment": "```suggestion\nExclude `toText` property when serializing the schema into a JSON object, because it is a function and functions are not serializable.\n```", "path": ".changeset/2026-05-27-serialize-schema-omit-totext.md", "hunk": "@@ -0,0 +1,5 @@\n+---\n+'@tiptap/server-ai-toolkit': patch\...
true
ueberdosis/tiptap
7,879
comment_to_fix
Omit toText property from serialized schema
```suggestion Exclude `toText` property when serializing the schema into a JSON object, because it is a function and functions are not serializable. ```
2d056144ccc729a4dc69605b1fdd0baf0908e95d
798a0f931cb3af2ffeb13b65139c5fe0eb7e8a67
diff --git a/.changeset/2026-05-27-serialize-schema-omit-totext.md b/.changeset/2026-05-27-serialize-schema-omit-totext.md new file mode 100644 index 0000000000..3adf479c4a --- /dev/null +++ b/.changeset/2026-05-27-serialize-schema-omit-totext.md @@ -0,0 +1,5 @@ +--- +'@tiptap/server-ai-toolkit': patch +--- + +Exclude ...
[ ".changeset/2026-05-27-serialize-schema-omit-totext.md" ]
[ { "comment": "```suggestion\nExclude `toText` property when serializing the schema into a JSON object, because it is a function and functions are not serializable.\n```", "path": ".changeset/2026-05-27-serialize-schema-omit-totext.md", "hunk": "@@ -0,0 +1,5 @@\n+---\n+'@tiptap/server-ai-toolkit': patch\...
true
ueberdosis/tiptap
7,878
issue_to_patch
fix(placeholder): defer viewport recompute to rAF, add overscan, throttle scroll updates
## Changes Overview Fix placeholder flickering during collaborative editing and reduce scroll-time CPU usage. ## Implementation Approach - **viewportTracking.ts** — Deferred viewport recompute from the synchronous `update()` callback to `requestAnimationFrame` to fix the stale-DOM bug that caused collab flicke...
a1e854a04f15dea8aeb121d237c4229a4b3ea732
8f194633a4a884e851b2e1644b099cc451357685
diff --git a/.changeset/placeholder-scroll-perf.md b/.changeset/placeholder-scroll-perf.md new file mode 100644 index 0000000000..e349dbecf2 --- /dev/null +++ b/.changeset/placeholder-scroll-perf.md @@ -0,0 +1,5 @@ +--- +'@tiptap/extensions': patch +--- + +Fix placeholder flickering during collaborative editing and red...
[ ".changeset/placeholder-scroll-perf.md", "packages/extensions/__tests__/placeholder.spec.ts", "packages/extensions/src/placeholder/constants.ts", "packages/extensions/src/placeholder/index.ts", "packages/extensions/src/placeholder/placeholder.ts", "packages/extensions/src/placeholder/plugins/PlaceholderPl...
[ { "comment": "`PLUGIN_KEY` was previously exported from the placeholder entrypoint (via `export * from './placeholder.js'`). After moving it into `constants.ts`, it is no longer re-exported from `packages/extensions/src/placeholder/index.ts`, which is a breaking change for consumers importing `PLUGIN_KEY` from ...
diff --git a/packages/extensions/__tests__/placeholder.spec.ts b/packages/extensions/__tests__/placeholder.spec.ts index e70ad962a3..734e759ea1 100644 --- a/packages/extensions/__tests__/placeholder.spec.ts +++ b/packages/extensions/__tests__/placeholder.spec.ts @@ -16,6 +16,8 @@ import { afterEach, beforeEach, describ...
true
ueberdosis/tiptap
7,878
comment_to_fix
fix(placeholder): defer viewport recompute to rAF, add overscan, throttle scroll updates
`PLUGIN_KEY` was previously exported from the placeholder entrypoint (via `export * from './placeholder.js'`). After moving it into `constants.ts`, it is no longer re-exported from `packages/extensions/src/placeholder/index.ts`, which is a breaking change for consumers importing `PLUGIN_KEY` from `@tiptap/extensions/pl...
a1e854a04f15dea8aeb121d237c4229a4b3ea732
8f194633a4a884e851b2e1644b099cc451357685
diff --git a/packages/extensions/src/placeholder/index.ts b/packages/extensions/src/placeholder/index.ts index 70f8306c46..e6ecc59a6f 100644 --- a/packages/extensions/src/placeholder/index.ts +++ b/packages/extensions/src/placeholder/index.ts @@ -1,2 +1,4 @@ +export { DEFAULT_DATA_ATTRIBUTE, PLUGIN_KEY } from './consta...
[ "packages/extensions/src/placeholder/index.ts" ]
[ { "comment": "`PLUGIN_KEY` was previously exported from the placeholder entrypoint (via `export * from './placeholder.js'`). After moving it into `constants.ts`, it is no longer re-exported from `packages/extensions/src/placeholder/index.ts`, which is a breaking change for consumers importing `PLUGIN_KEY` from ...
true
ueberdosis/tiptap
7,847
issue_to_patch
Static renderer doesn't respect the editor options or extensions ### Affected Packages @tiptap/static-renderer ### Version(s) 3.20.4" ### Bug Description When I load my JSON content to the tiptap editor, it renders a paragraph like this ``` <h1 data-id="d3557443-bf1d-4363-9818-8864c43d2a8e" dir="auto" id="d35574...
fix(static-renderer): close parity gaps with editor.getHTML() (#7637)
## Changes Overview Closes #7637 by adding `textDirection` support to all three static renderers, filtering `null`/`undefined` attribute values (matches ProseMirror's `DOMSerializer`), and introducing a `generateTocIds` server-side helper in `@tiptap/extension-table-of-contents`. ## Implementation Approach A new `ap...
195b13f719efc1bd3d95a79ffeb2105ee3118295
10bb3b19d0060244ff479de5a04b468099c20455
diff --git a/.changeset/pink-pears-switch.md b/.changeset/pink-pears-switch.md new file mode 100644 index 0000000000..8e6a081bd4 --- /dev/null +++ b/.changeset/pink-pears-switch.md @@ -0,0 +1,5 @@ +--- +'@tiptap/static-renderer': patch +--- + +Honor the `textDirection` editor option in `renderToHTMLString`, `renderToMa...
[ ".changeset/pink-pears-switch.md", ".changeset/three-dingos-notice.md", "packages/extension-table-of-contents/__tests__/generate-toc-ids.spec.ts", "packages/extension-table-of-contents/src/generate-toc-ids.ts", "packages/extension-table-of-contents/src/index.ts", "packages/static-renderer/README.md", "p...
[ { "comment": "maybe add the extension name as an optional argument - the name could theoretically be overwritten by extending the base extension. Unlikely but possible.", "path": "packages/extension-table-of-contents/src/generate-toc-ids.ts", "hunk": "@@ -0,0 +1,80 @@\n+import type { Extensions, JSONCon...
diff --git a/packages/extension-table-of-contents/__tests__/generate-toc-ids.spec.ts b/packages/extension-table-of-contents/__tests__/generate-toc-ids.spec.ts new file mode 100644 index 0000000000..23936722f8 --- /dev/null +++ b/packages/extension-table-of-contents/__tests__/generate-toc-ids.spec.ts @@ -0,0 +1,141 @@ +...
true
ueberdosis/tiptap
7,847
comment_to_fix
fix(static-renderer): close parity gaps with editor.getHTML() (#7637)
maybe add the extension name as an optional argument - the name could theoretically be overwritten by extending the base extension. Unlikely but possible.
195b13f719efc1bd3d95a79ffeb2105ee3118295
10bb3b19d0060244ff479de5a04b468099c20455
diff --git a/packages/extension-table-of-contents/src/generate-toc-ids.ts b/packages/extension-table-of-contents/src/generate-toc-ids.ts new file mode 100644 index 0000000000..f1eb465ac2 --- /dev/null +++ b/packages/extension-table-of-contents/src/generate-toc-ids.ts @@ -0,0 +1,85 @@ +import type { Extensions, JSONCont...
[ "packages/extension-table-of-contents/src/generate-toc-ids.ts" ]
[ { "comment": "maybe add the extension name as an optional argument - the name could theoretically be overwritten by extending the base extension. Unlikely but possible.", "path": "packages/extension-table-of-contents/src/generate-toc-ids.ts", "hunk": "@@ -0,0 +1,80 @@\n+import type { Extensions, JSONCon...
true
ueberdosis/tiptap
7,847
comment_to_fix
fix(static-renderer): close parity gaps with editor.getHTML() (#7637)
remove issue references
195b13f719efc1bd3d95a79ffeb2105ee3118295
10bb3b19d0060244ff479de5a04b468099c20455
diff --git a/packages/static-renderer/__tests__/json-string.spec.ts b/packages/static-renderer/__tests__/json-string.spec.ts index 10c9d656cb..c6ba3a6c25 100644 --- a/packages/static-renderer/__tests__/json-string.spec.ts +++ b/packages/static-renderer/__tests__/json-string.spec.ts @@ -1,9 +1,14 @@ import type { TextT...
[ "packages/static-renderer/__tests__/json-string.spec.ts" ]
[ { "comment": "remove issue references", "path": "packages/static-renderer/__tests__/json-string.spec.ts", "hunk": "@@ -403,4 +408,116 @@ describe('static render json to string (with prosemirror)', () => {\n expect(html).to.include('data-youtube-video')\n expect(html).to.include('<p>text after yo...
true
ueberdosis/tiptap
7,847
comment_to_fix
fix(static-renderer): close parity gaps with editor.getHTML() (#7637)
remove issue reference
195b13f719efc1bd3d95a79ffeb2105ee3118295
10bb3b19d0060244ff479de5a04b468099c20455
diff --git a/packages/static-renderer/__tests__/md-string.spec.ts b/packages/static-renderer/__tests__/md-string.spec.ts index 19ee26f0a2..a0caba6732 100644 --- a/packages/static-renderer/__tests__/md-string.spec.ts +++ b/packages/static-renderer/__tests__/md-string.spec.ts @@ -258,4 +258,19 @@ describe('static render ...
[ "packages/static-renderer/__tests__/md-string.spec.ts" ]
[ { "comment": "remove issue reference", "path": "packages/static-renderer/__tests__/md-string.spec.ts", "hunk": "@@ -258,4 +258,20 @@ describe('static render json to string (no prosemirror)', () => {\n '\\n| Col 1 | Col 2 | Col 3 |\\n| --- | --- | --- |\\n| Row 1 1 | 112 | 1334 |\\n| Row 2 1 | 115 ...
true
ueberdosis/tiptap
7,847
comment_to_fix
fix(static-renderer): close parity gaps with editor.getHTML() (#7637)
same
195b13f719efc1bd3d95a79ffeb2105ee3118295
10bb3b19d0060244ff479de5a04b468099c20455
diff --git a/packages/static-renderer/__tests__/react-string.spec.ts b/packages/static-renderer/__tests__/react-string.spec.ts index 58a580949b..85d51a93c8 100644 --- a/packages/static-renderer/__tests__/react-string.spec.ts +++ b/packages/static-renderer/__tests__/react-string.spec.ts @@ -1,6 +1,7 @@ import { prettyD...
[ "packages/static-renderer/__tests__/react-string.spec.ts" ]
[ { "comment": "same", "path": "packages/static-renderer/__tests__/react-string.spec.ts", "hunk": "@@ -179,4 +180,29 @@ describe('static render json to react elements (with prosemirror)', () => {\n </doc>\n </div>`)\n })\n+\n+ // ── issue #7637 ────────────────────────────────────────────────────────...
true
ueberdosis/tiptap
7,847
comment_to_fix
fix(static-renderer): close parity gaps with editor.getHTML() (#7637)
should we maybe instead of just the text direction pass the object in here that will be used on line 174? that way we could extend this later. call it `staticEditorOptions` or something.
195b13f719efc1bd3d95a79ffeb2105ee3118295
10bb3b19d0060244ff479de5a04b468099c20455
diff --git a/packages/static-renderer/src/pm/react/react.ts b/packages/static-renderer/src/pm/react/react.ts index 7d59ba5cfa..d16ef15303 100644 --- a/packages/static-renderer/src/pm/react/react.ts +++ b/packages/static-renderer/src/pm/react/react.ts @@ -5,7 +5,8 @@ import React from 'react' import { renderJSONConte...
[ "packages/static-renderer/src/pm/react/react.ts" ]
[ { "comment": "should we maybe instead of just the text direction pass the object in here that will be used on line 174? that way we could extend this later. call it `staticEditorOptions` or something.", "path": "packages/static-renderer/src/pm/react/react.ts", "hunk": "@@ -138,19 +139,26 @@ export funct...
true
ueberdosis/tiptap
7,864
issue_to_patch
bug(markdown): Text inside angle brackets silently swallowed during markdown parsing ### Affected Packages @tiptap/markdown ### Version(s) 3.23.6 ### Bug Description When markdown content contains text inside angle brackets (e.g. `<enter existing CID here if available>`), the `@tiptap/markdown` extension passes i...
fix(markdown): fix markdown parsing for unknown angle-bracket tags and improve docs
## Changes Overview Fixes #7861. Text inside unknown angle-bracket tags (e.g. `<enter existing CID here if available>`) is no longer silently swallowed during markdown parsing. The original characters are now preserved as literal text, which also prevents the downstream `Called contentMatchAt on a node with invalid ...
ab086a80045b20d94a329f1b65b196b12b6808b8
a3fe1aadccfab3fd782c866a454aa8f441474649
diff --git a/.changeset/fix-markdown-unknown-html-tags.md b/.changeset/fix-markdown-unknown-html-tags.md new file mode 100644 index 0000000000..689b8e0fbd --- /dev/null +++ b/.changeset/fix-markdown-unknown-html-tags.md @@ -0,0 +1,5 @@ +--- +'@tiptap/markdown': patch +--- + +Fix text inside unknown angle-bracket tags b...
[ ".changeset/fix-markdown-unknown-html-tags.md", "packages/markdown/__tests__/unknown-html-tags.spec.ts", "packages/markdown/src/MarkdownManager.ts" ]
[ { "comment": "`isUnrecognizedHtml` returns `true` for valid/recognized HTML that happens to have no text content (e.g. `<em></em>`, `<em> </em>`, `<span></span>`). That will route those tokens through `htmlAsLiteralText` and render the raw markup in the document, which is a behavior change and also contradicts ...
diff --git a/packages/markdown/__tests__/unknown-html-tags.spec.ts b/packages/markdown/__tests__/unknown-html-tags.spec.ts new file mode 100644 index 0000000000..1285ec73df --- /dev/null +++ b/packages/markdown/__tests__/unknown-html-tags.spec.ts @@ -0,0 +1,154 @@ +/** + * @vitest-environment happy-dom + */ + +import {...
true
ueberdosis/tiptap
7,864
comment_to_fix
fix(markdown): fix markdown parsing for unknown angle-bracket tags and improve docs
`isUnrecognizedHtml` returns `true` for valid/recognized HTML that happens to have no text content (e.g. `<em></em>`, `<em> </em>`, `<span></span>`). That will route those tokens through `htmlAsLiteralText` and render the raw markup in the document, which is a behavior change and also contradicts the doc/PR description...
ab086a80045b20d94a329f1b65b196b12b6808b8
a3fe1aadccfab3fd782c866a454aa8f441474649
diff --git a/packages/markdown/src/MarkdownManager.ts b/packages/markdown/src/MarkdownManager.ts index 0dc4c47acd..21ec442a9e 100644 --- a/packages/markdown/src/MarkdownManager.ts +++ b/packages/markdown/src/MarkdownManager.ts @@ -16,6 +16,7 @@ import { flattenExtensions, generateJSON, getExtensionField, + ge...
[ "packages/markdown/src/MarkdownManager.ts" ]
[ { "comment": "`isUnrecognizedHtml` returns `true` for valid/recognized HTML that happens to have no text content (e.g. `<em></em>`, `<em> </em>`, `<span></span>`). That will route those tokens through `htmlAsLiteralText` and render the raw markup in the document, which is a behavior change and also contradicts ...
true
ueberdosis/tiptap
7,863
issue_to_patch
chore: add licensing information around ProseMirror to pm package
## Changes Overview Add licensing information to the `@tiptap/pm` package, including a `LICENSE` file, a `THIRD_PARTY_LICENSES.md` document acknowledging the ProseMirror project, and export the missing `prosemirror-inputrules` package. ## Implementation Approach - Added `packages/pm/LICENSE` (MIT) under Tiptap...
c17ac9a2b3013997a17a8abab8b6ccd844000ca6
a682b12763c2a2b1dc84a31727b379cae8687dc4
diff --git a/.changeset/dull-feet-tickle.md b/.changeset/dull-feet-tickle.md new file mode 100644 index 0000000000..42d948b25b --- /dev/null +++ b/.changeset/dull-feet-tickle.md @@ -0,0 +1,5 @@ +--- +'@tiptap/pm': patch +--- + +Add missing `@tiptap/pm/inputrules` export diff --git a/packages/pm/LICENSE b/packages/pm/LI...
[ ".changeset/dull-feet-tickle.md", "packages/pm/LICENSE", "packages/pm/README.md", "packages/pm/THIRD_PARTY_LICENSES.md", "packages/pm/inputrules/index.ts", "packages/pm/package.json", "pnpm-lock.yaml" ]
[ { "comment": "The changeset summary mixes user-facing behavior (new `@tiptap/pm/inputrules` re-export) with internal/packaging details (license files). Since this text becomes the changelog entry, consider focusing it on the new export/import path and omitting the licensing-documentation part.\n", "path": "...
true
ueberdosis/tiptap
7,863
comment_to_fix
chore: add licensing information around ProseMirror to pm package
The changeset summary mixes user-facing behavior (new `@tiptap/pm/inputrules` re-export) with internal/packaging details (license files). Since this text becomes the changelog entry, consider focusing it on the new export/import path and omitting the licensing-documentation part.
c17ac9a2b3013997a17a8abab8b6ccd844000ca6
a682b12763c2a2b1dc84a31727b379cae8687dc4
diff --git a/.changeset/dull-feet-tickle.md b/.changeset/dull-feet-tickle.md new file mode 100644 index 0000000000..42d948b25b --- /dev/null +++ b/.changeset/dull-feet-tickle.md @@ -0,0 +1,5 @@ +--- +'@tiptap/pm': patch +--- + +Add missing `@tiptap/pm/inputrules` export
[ ".changeset/dull-feet-tickle.md" ]
[ { "comment": "The changeset summary mixes user-facing behavior (new `@tiptap/pm/inputrules` re-export) with internal/packaging details (license files). Since this text becomes the changelog entry, consider focusing it on the new export/import path and omitting the licensing-documentation part.\n", "path": "...
true
ueberdosis/tiptap
7,860
issue_to_patch
Migrate PNPM to 11.x & move config to pnpm-workspace.yaml
## Changes Overview Migrate PNPM from 10.x to 11.x and relocate workspace config from `package.json` to `pnpm-workspace.yaml`. ## Implementation Approach - Removed workspace config (`pnpm.overrides`, `pnpm.packageExtensions`, etc.) from `package.json` - Created `pnpm-workspace.yaml` with the extracted workspace defi...
195b13f719efc1bd3d95a79ffeb2105ee3118295
fe4126802d4f170edf6d77ade1270fa952d9f4b1
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 03ffd4ecda..4c42e5d170 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -2,7 +2,7 @@ name: Verify env: NODE_VERSION: 24 - PNPM_VERSION: 9.15.4 + PNPM_VERSION: 11.2.2 PNPM_STORE_DIR: .pnpm-store concur...
[ ".github/workflows/build.yml", ".github/workflows/publish.yml", "package.json", "pnpm-lock.yaml", "pnpm-workspace.yaml" ]
[ { "comment": "The lockfile’s root importer now lists ESLint-related devDependencies with specifiers/versions that don’t match the current root package.json (e.g. lockfile has eslint ^10.4.0 and eslint-config-prettier 10.1.8, while package.json still declares eslint ^8.57.1 and eslint-config-prettier 9.1.0, and ...
true
ueberdosis/tiptap
7,860
comment_to_fix
Migrate PNPM to 11.x & move config to pnpm-workspace.yaml
The lockfile’s root importer now lists ESLint-related devDependencies with specifiers/versions that don’t match the current root package.json (e.g. lockfile has eslint ^10.4.0 and eslint-config-prettier 10.1.8, while package.json still declares eslint ^8.57.1 and eslint-config-prettier 9.1.0, and lockfile no longer lis...
195b13f719efc1bd3d95a79ffeb2105ee3118295
fe4126802d4f170edf6d77ade1270fa952d9f4b1
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index ad1e3b6793..bcc298264b 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -21,12 +21,8 @@ overrides: vitest>picomatch: 4.0.4 patchedDependencies: - '@changesets/assemble-release-plan@6.0.5': - hash: k7lv6yvbsp2zaevp6zj5au6glm - path: patches/@changesets__...
[ "pnpm-lock.yaml" ]
[ { "comment": "The lockfile’s root importer now lists ESLint-related devDependencies with specifiers/versions that don’t match the current root package.json (e.g. lockfile has eslint ^10.4.0 and eslint-config-prettier 10.1.8, while package.json still declares eslint ^8.57.1 and eslint-config-prettier 9.1.0, and ...
true
ueberdosis/tiptap
7,860
comment_to_fix
Migrate PNPM to 11.x & move config to pnpm-workspace.yaml
packageManager is bumped to pnpm@11.2.2, but the GitHub Actions workflows still pin PNPM_VERSION=9.15.4 and run installs with --frozen-lockfile. With the lockfile now at version 9.0 (pnpm 11), CI installs are likely to fail unless the workflows’ PNPM_VERSION is updated to a compatible pnpm 11.x version (or the lockfile...
195b13f719efc1bd3d95a79ffeb2105ee3118295
fe4126802d4f170edf6d77ade1270fa952d9f4b1
diff --git a/package.json b/package.json index e63962caff..aec88dd6ac 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "tiptap", "private": true, - "packageManager": "pnpm@9.15.4", + "packageManager": "pnpm@11.2.2", "engines": { "node": ">=24" }, @@ -81,9 +81,9 @@ "pkg-pr-...
[ "package.json" ]
[ { "comment": "packageManager is bumped to pnpm@11.2.2, but the GitHub Actions workflows still pin PNPM_VERSION=9.15.4 and run installs with --frozen-lockfile. With the lockfile now at version 9.0 (pnpm 11), CI installs are likely to fail unless the workflows’ PNPM_VERSION is updated to a compatible pnpm 11.x ve...
true
ueberdosis/tiptap
7,867
issue_to_patch
There is a bug in Tiptap's details extension: when inserting a details node at the very beginning of the editor, the cursor jumps out of the node when editing the summary. ### Affected Packages "@antv/g6": "^5.1.1", "@floating-ui/vue": "^1.1.11", "@iconify/vue": "^5.0.0", "@leafer-in/animate": "^2.1.0",...
Fix details toggle at document start
## Changes Overview Fixes persisted details toggle handling when a details node is located at document position 0. Adds a regression test for toggling a persisted details node at the start of the document and includes a patch changeset for `@tiptap/extension-details`. ## Implementation Approach The details node view...
ab086a80045b20d94a329f1b65b196b12b6808b8
7bafb7e42db15caa055b21d0f7a43da2bf443790
diff --git a/.changeset/fix-details-summary-focus.md b/.changeset/fix-details-summary-focus.md new file mode 100644 index 0000000000..9afa053bfa --- /dev/null +++ b/.changeset/fix-details-summary-focus.md @@ -0,0 +1,5 @@ +--- +"@tiptap/extension-details": patch +--- + +Fix persisted details toggles when the details nod...
[ ".changeset/fix-details-summary-focus.md", "packages/extension-details/__tests__/details.spec.ts", "packages/extension-details/src/details.ts" ]
[]
diff --git a/packages/extension-details/__tests__/details.spec.ts b/packages/extension-details/__tests__/details.spec.ts index 635bb5e485..1eef709b0e 100644 --- a/packages/extension-details/__tests__/details.spec.ts +++ b/packages/extension-details/__tests__/details.spec.ts @@ -101,6 +101,47 @@ describe('Details', () =...
true
ueberdosis/tiptap
7,763
issue_to_patch
Node view `selected` prop doesn't get updated when node is selected ### What’s the bug you are facing? I'm trying to use the node view `selected` prop (https://tiptap.dev/guide/node-views/vue#selected) but it doesn't get updated when the node is selected. ### Which browser was this experienced in? Are any special ex...
feat(core): add selectedOnTextSelection option to node views
## Changes Overview Adds a new `selectedOnTextSelection` option to `NodeViewRendererOptions`. When enabled, a node view's `selected` prop becomes `true` while a `TextSelection` is fully contained within the node's range — not only when a `NodeSelection` wraps the node. Default behavior is unchanged (opt-in). ## I...
9ba5696c222f429c69f639949e60cb8a062fa7b6
0794f554167f24a9835289ad805612dbaa71508e
diff --git a/.changeset/chilly-games-matter.md b/.changeset/chilly-games-matter.md new file mode 100644 index 0000000000..11f348d2eb --- /dev/null +++ b/.changeset/chilly-games-matter.md @@ -0,0 +1,8 @@ +--- +'@tiptap/react': patch +'@tiptap/vue-2': patch +'@tiptap/vue-3': patch +'@tiptap/core': patch +--- + +Add `sele...
[ ".changeset/chilly-games-matter.md", "packages/core/__tests__/isNodeViewSelected.spec.ts", "packages/core/src/helpers/index.ts", "packages/core/src/helpers/isNodeViewSelected.ts", "packages/core/src/types.ts", "packages/react/src/ReactNodeViewRenderer.tsx", "packages/vue-2/src/VueNodeViewRenderer.ts", ...
[ { "comment": "The unit tests don’t cover boundary positions when `selectedOnTextSelection` is enabled. Adding assertions that a cursor at `pos` (before the node) and at `pos + nodeSize` (after the node) returns `false` would prevent regressions where the helper treats node boundaries as “inside”.", "path": ...
diff --git a/packages/core/__tests__/isNodeViewSelected.spec.ts b/packages/core/__tests__/isNodeViewSelected.spec.ts new file mode 100644 index 0000000000..b16ce582a8 --- /dev/null +++ b/packages/core/__tests__/isNodeViewSelected.spec.ts @@ -0,0 +1,207 @@ +import { Editor, isNodeViewSelected, Node } from '@tiptap/core'...
true
ueberdosis/tiptap
7,763
comment_to_fix
feat(core): add selectedOnTextSelection option to node views
The unit tests don’t cover boundary positions when `selectedOnTextSelection` is enabled. Adding assertions that a cursor at `pos` (before the node) and at `pos + nodeSize` (after the node) returns `false` would prevent regressions where the helper treats node boundaries as “inside”.
9ba5696c222f429c69f639949e60cb8a062fa7b6
0794f554167f24a9835289ad805612dbaa71508e
diff --git a/packages/core/__tests__/isNodeViewSelected.spec.ts b/packages/core/__tests__/isNodeViewSelected.spec.ts new file mode 100644 index 0000000000..b16ce582a8 --- /dev/null +++ b/packages/core/__tests__/isNodeViewSelected.spec.ts @@ -0,0 +1,207 @@ +import { Editor, isNodeViewSelected, Node } from '@tiptap/core'...
[ "packages/core/__tests__/isNodeViewSelected.spec.ts" ]
[ { "comment": "The unit tests don’t cover boundary positions when `selectedOnTextSelection` is enabled. Adding assertions that a cursor at `pos` (before the node) and at `pos + nodeSize` (after the node) returns `false` would prevent regressions where the helper treats node boundaries as “inside”.", "path": ...
true
ueberdosis/tiptap
7,763
comment_to_fix
feat(core): add selectedOnTextSelection option to node views
`selectedOnTextSelection` currently treats selections at the node boundaries as “inside” (`from >= pos && to <= pos + nodeSize`). Since `getPos()` is the position *before* the node, a cursor at `pos` (before the node) or at `pos + nodeSize` (after the node) would incorrectly mark the node view as selected when this opt...
9ba5696c222f429c69f639949e60cb8a062fa7b6
0794f554167f24a9835289ad805612dbaa71508e
diff --git a/packages/core/src/helpers/isNodeViewSelected.ts b/packages/core/src/helpers/isNodeViewSelected.ts new file mode 100644 index 0000000000..6b37838ad6 --- /dev/null +++ b/packages/core/src/helpers/isNodeViewSelected.ts @@ -0,0 +1,42 @@ +import type { Selection } from '@tiptap/pm/state' + +import { isTextSelec...
[ "packages/core/src/helpers/isNodeViewSelected.ts" ]
[ { "comment": "`selectedOnTextSelection` currently treats selections at the node boundaries as “inside” (`from >= pos && to <= pos + nodeSize`). Since `getPos()` is the position *before* the node, a cursor at `pos` (before the node) or at `pos + nodeSize` (after the node) would incorrectly mark the node view as ...
true
ueberdosis/tiptap
7,854
issue_to_patch
Publish a new stable version
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will ...
937ff2e406146bd83081b08f9620b55ed5274ec3
29e57942679c7a05b3cb544b0060559f2eaf083a
diff --git a/.changeset/curly-scissors-lick.md b/.changeset/curly-scissors-lick.md deleted file mode 100644 index 9cc94b509b..0000000000 --- a/.changeset/curly-scissors-lick.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -'@tiptap/extension-drag-handle': patch ---- - -**DragHandle**: Added `dragImageProperties` option to limit ...
[ ".changeset/curly-scissors-lick.md", ".changeset/fix-delete-selection-inline-nodes.md", ".changeset/tricky-fans-change.md", "CHANGELOG.md", "packages-deprecated/extension-character-count/CHANGELOG.md", "packages-deprecated/extension-character-count/package.json", "packages-deprecated/extension-dropcurso...
[]
true
ueberdosis/tiptap
7,851
issue_to_patch
perf: Optimize Placeholder scan and add dragImageProperties to DragHandle
## Changes Overview Two performance optimizations: ### 1. Placeholder — no more full-document traversal The placeholder decorations callback used `doc.descendants()` on every state change, walking the entire document tree. For large documents with big code blocks this caused noticeable lag on keystrokes. **...
5ccf351c82dfc69f3bc0ca5a2c500071a23bf70b
b5cb9dd5604b7fb55d48101ca7b99c44e135a167
diff --git a/.changeset/curly-scissors-lick.md b/.changeset/curly-scissors-lick.md new file mode 100644 index 0000000000..9cc94b509b --- /dev/null +++ b/.changeset/curly-scissors-lick.md @@ -0,0 +1,5 @@ +--- +'@tiptap/extension-drag-handle': patch +--- + +**DragHandle**: Added `dragImageProperties` option to limit whic...
[ ".changeset/curly-scissors-lick.md", ".changeset/tricky-fans-change.md", "packages/extension-drag-handle/__tests__/cloneElement.spec.ts", "packages/extension-drag-handle/src/drag-handle-plugin.ts", "packages/extension-drag-handle/src/drag-handle.ts", "packages/extension-drag-handle/src/helpers/cloneElemen...
[ { "comment": "The viewport range stored in plugin state is never updated when transactions remap document positions (apply() returns prev unless meta.positions is set). This can leave topPos/bottomPos pointing at stale coordinates after inserts/deletes, which can cause incorrect viewport scanning or even invali...
diff --git a/packages/extension-drag-handle/__tests__/cloneElement.spec.ts b/packages/extension-drag-handle/__tests__/cloneElement.spec.ts index 53f0b7619d..6431cd50d7 100644 --- a/packages/extension-drag-handle/__tests__/cloneElement.spec.ts +++ b/packages/extension-drag-handle/__tests__/cloneElement.spec.ts @@ -7,41 ...
true
ueberdosis/tiptap
7,851
comment_to_fix
perf: Optimize Placeholder scan and add dragImageProperties to DragHandle
The viewport range stored in plugin state is never updated when transactions remap document positions (apply() returns prev unless meta.positions is set). This can leave topPos/bottomPos pointing at stale coordinates after inserts/deletes, which can cause incorrect viewport scanning or even invalid ranges. Consider map...
5ccf351c82dfc69f3bc0ca5a2c500071a23bf70b
b5cb9dd5604b7fb55d48101ca7b99c44e135a167
diff --git a/packages/extensions/src/placeholder/placeholder.ts b/packages/extensions/src/placeholder/placeholder.ts index 3c8c483e88..232a6bd604 100644 --- a/packages/extensions/src/placeholder/placeholder.ts +++ b/packages/extensions/src/placeholder/placeholder.ts @@ -1,8 +1,13 @@ -import type { Editor } from '@tipta...
[ "packages/extensions/src/placeholder/placeholder.ts" ]
[ { "comment": "The viewport range stored in plugin state is never updated when transactions remap document positions (apply() returns prev unless meta.positions is set). This can leave topPos/bottomPos pointing at stale coordinates after inserts/deletes, which can cause incorrect viewport scanning or even invali...
true
ueberdosis/tiptap
7,851
comment_to_fix
perf: Optimize Placeholder scan and add dragImageProperties to DragHandle
In the fast path (showOnlyCurrent=true, includeChildren=false), hasAnchor is always passed as false. For the current top-level textblock at the selection anchor, hasAnchor should be true so placeholder callback functions can behave consistently with the slow path.
5ccf351c82dfc69f3bc0ca5a2c500071a23bf70b
b5cb9dd5604b7fb55d48101ca7b99c44e135a167
diff --git a/packages/extensions/src/placeholder/placeholder.ts b/packages/extensions/src/placeholder/placeholder.ts index 3c8c483e88..232a6bd604 100644 --- a/packages/extensions/src/placeholder/placeholder.ts +++ b/packages/extensions/src/placeholder/placeholder.ts @@ -1,8 +1,13 @@ -import type { Editor } from '@tipta...
[ "packages/extensions/src/placeholder/placeholder.ts" ]
[ { "comment": "In the fast path (showOnlyCurrent=true, includeChildren=false), hasAnchor is always passed as false. For the current top-level textblock at the selection anchor, hasAnchor should be true so placeholder callback functions can behave consistently with the slow path.\n", "path": "packages/extensi...
true
ueberdosis/tiptap
7,851
comment_to_fix
perf: Optimize Placeholder scan and add dragImageProperties to DragHandle
The throttle helper drops the original function parameter types by using unknown[] and casting back to T. You can keep full type safety by typing the wrapper as (...args: Parameters<T>) => void (and avoid the cast).
5ccf351c82dfc69f3bc0ca5a2c500071a23bf70b
b5cb9dd5604b7fb55d48101ca7b99c44e135a167
diff --git a/packages/extensions/src/placeholder/utils/throttle.ts b/packages/extensions/src/placeholder/utils/throttle.ts new file mode 100644 index 0000000000..fab2e19cd7 --- /dev/null +++ b/packages/extensions/src/placeholder/utils/throttle.ts @@ -0,0 +1,25 @@ +export function throttle<T extends (...args: any[]) => ...
[ "packages/extensions/src/placeholder/utils/throttle.ts" ]
[ { "comment": "The throttle helper drops the original function parameter types by using unknown[] and casting back to T. You can keep full type safety by typing the wrapper as (...args: Parameters<T>) => void (and avoid the cast).", "path": "packages/extensions/src/placeholder/utils/throttle.ts", "hunk":...
true
ueberdosis/tiptap
7,851
comment_to_fix
perf: Optimize Placeholder scan and add dragImageProperties to DragHandle
Typo in the JSDoc: “descendents” should be “descendants”.
5ccf351c82dfc69f3bc0ca5a2c500071a23bf70b
b5cb9dd5604b7fb55d48101ca7b99c44e135a167
diff --git a/packages/extensions/src/placeholder/types.ts b/packages/extensions/src/placeholder/types.ts new file mode 100644 index 0000000000..5e9f631f13 --- /dev/null +++ b/packages/extensions/src/placeholder/types.ts @@ -0,0 +1,60 @@ +import type { Editor } from '@tiptap/core' +import type { Node as ProsemirrorNode ...
[ "packages/extensions/src/placeholder/types.ts" ]
[ { "comment": "Typo in the JSDoc: “descendents” should be “descendants”.\n", "path": "packages/extensions/src/placeholder/types.ts", "hunk": "@@ -0,0 +1,60 @@\n+import type { Editor } from '@tiptap/core'\n+import type { Node as ProsemirrorNode } from '@tiptap/pm/model'\n+\n+export interface PlaceholderOp...
true
ueberdosis/tiptap
7,851
comment_to_fix
perf: Optimize Placeholder scan and add dragImageProperties to DragHandle
Typo in the JSDoc: “Prosemirror” should be “ProseMirror”.
5ccf351c82dfc69f3bc0ca5a2c500071a23bf70b
b5cb9dd5604b7fb55d48101ca7b99c44e135a167
diff --git a/packages/extensions/src/placeholder/utils/createPlaceholderDecoration.ts b/packages/extensions/src/placeholder/utils/createPlaceholderDecoration.ts new file mode 100644 index 0000000000..b2ee275c83 --- /dev/null +++ b/packages/extensions/src/placeholder/utils/createPlaceholderDecoration.ts @@ -0,0 +1,61 @@...
[ "packages/extensions/src/placeholder/utils/createPlaceholderDecoration.ts" ]
[ { "comment": "Typo in the JSDoc: “Prosemirror” should be “ProseMirror”.\n", "path": "packages/extensions/src/placeholder/utils/createPlaceholderDecoration.ts", "hunk": "@@ -0,0 +1,61 @@\n+import type { Editor } from '@tiptap/core'\n+import type { Node } from '@tiptap/pm/model'\n+import { Decoration } fr...
true
ueberdosis/tiptap
7,851
comment_to_fix
perf: Optimize Placeholder scan and add dragImageProperties to DragHandle
New behavior (properties subset path) isn’t covered by tests. Please add/extend a test to assert that when a properties list is provided, only those computed style properties are copied onto the clone (and non-listed ones are omitted).
5ccf351c82dfc69f3bc0ca5a2c500071a23bf70b
b5cb9dd5604b7fb55d48101ca7b99c44e135a167
diff --git a/packages/extension-drag-handle/src/helpers/cloneElement.ts b/packages/extension-drag-handle/src/helpers/cloneElement.ts index d01a61a768..0892649e82 100644 --- a/packages/extension-drag-handle/src/helpers/cloneElement.ts +++ b/packages/extension-drag-handle/src/helpers/cloneElement.ts @@ -1,7 +1,15 @@ -fun...
[ "packages/extension-drag-handle/src/helpers/cloneElement.ts" ]
[ { "comment": "New behavior (properties subset path) isn’t covered by tests. Please add/extend a test to assert that when a properties list is provided, only those computed style properties are copied onto the clone (and non-listed ones are omitted).", "path": "packages/extension-drag-handle/src/helpers/clon...
true
ueberdosis/tiptap
7,848
issue_to_patch
Deletion functionality not working as expected on inline nodes ### What’s the bug you are facing? I've created a custom inline extension which simply renders NodeViewContent and one other component and when I try to delete the node, I am not able to. As demonstrated in the sandbox, if you select all text in the NodeV...
Fix deleteSelection to properly handle inline nodes with text* content
## Changes Overview Fix deleteSelection to properly handle inline nodes with text* content. The selection is now expanded to include the entire inline node boundaries when deleting, preventing incorrect collapse of inline text nodes. ## Implementation Approach Added utility functions (hasTextContent, expandSelection...
d9daae031a4f72ae81af039a721df66f5c0c2696
875b85b464d0a0a375de50f89e35d1cbe96d1bf3
diff --git a/.changeset/fix-delete-selection-inline-nodes.md b/.changeset/fix-delete-selection-inline-nodes.md new file mode 100644 index 0000000000..4d57d70859 --- /dev/null +++ b/.changeset/fix-delete-selection-inline-nodes.md @@ -0,0 +1,5 @@ +--- +"@tiptap/core": patch +--- + +Fix deleteSelection to properly handle ...
[ ".changeset/fix-delete-selection-inline-nodes.md", "packages/core/__tests__/delete.spec.ts", "packages/core/src/commands/deleteSelection.ts" ]
[ { "comment": "`deleteSelection` mutates `tr` unconditionally. In Tiptap, `dispatch` is `undefined` in `editor.can()` / `can().chain()` calls, and commands are expected to avoid mutating the transaction in that mode (see e.g. `deleteRange`, `clearNodes`). Please accept `dispatch` in the props and only run `tr.de...
diff --git a/packages/core/__tests__/delete.spec.ts b/packages/core/__tests__/delete.spec.ts index 10c8d528a3..23a7688bc9 100644 --- a/packages/core/__tests__/delete.spec.ts +++ b/packages/core/__tests__/delete.spec.ts @@ -1,6 +1,7 @@ -import { Editor } from '@tiptap/core' +import { Editor, Node } from '@tiptap/core' ...
true
ueberdosis/tiptap
7,848
comment_to_fix
Fix deleteSelection to properly handle inline nodes with text* content
`deleteSelection` mutates `tr` unconditionally. In Tiptap, `dispatch` is `undefined` in `editor.can()` / `can().chain()` calls, and commands are expected to avoid mutating the transaction in that mode (see e.g. `deleteRange`, `clearNodes`). Please accept `dispatch` in the props and only run `tr.deleteRange(...).scrollI...
d9daae031a4f72ae81af039a721df66f5c0c2696
875b85b464d0a0a375de50f89e35d1cbe96d1bf3
diff --git a/packages/core/src/commands/deleteSelection.ts b/packages/core/src/commands/deleteSelection.ts index 0c111df95f..81bd77d2f3 100644 --- a/packages/core/src/commands/deleteSelection.ts +++ b/packages/core/src/commands/deleteSelection.ts @@ -1,7 +1,62 @@ -import { deleteSelection as originalDeleteSelection } f...
[ "packages/core/src/commands/deleteSelection.ts" ]
[ { "comment": "`deleteSelection` mutates `tr` unconditionally. In Tiptap, `dispatch` is `undefined` in `editor.can()` / `can().chain()` calls, and commands are expected to avoid mutating the transaction in that mode (see e.g. `deleteRange`, `clearNodes`). Please accept `dispatch` in the props and only run `tr.de...
true
ueberdosis/tiptap
7,845
issue_to_patch
test: migrate Cypress e2e suite to Playwright + port core specs to Vitest
## Changes Overview Migrates the entire Cypress e2e test suite to Playwright and ports the two core integration specs to Vitest. Cypress is fully removed from the project (dependencies, configs, scripts, and `tests/` artifacts). - **852 Playwright e2e tests** across `demos/src/**/index.spec.ts`, covering Commands, De...
d9daae031a4f72ae81af039a721df66f5c0c2696
457404e1bf9e6007b44541f027d7b8e2490373ca
diff --git a/.eslintrc.js b/.eslintrc.js index 997ff95870..6bc5544c25 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -14,10 +14,7 @@ module.exports = { }, { files: ['./**/*.ts', './**/*.tsx', './**/*.js', './**/*.jsx', './**/*.vue'], - plugins: ['html', 'cypress', '@typescript-eslint', 'simple-im...
[ ".eslintrc.js", ".github/instructions/tiptap.instructions.md", ".github/workflows/build.yml", ".gitignore", ".lintstagedrc.cjs", "AGENTS.md", "demos/package.json", "demos/src/Commands/Cut/React/index.spec.js", "demos/src/Commands/InsertContent/React/index.spec.js", "demos/src/Commands/InsertConten...
[ { "comment": "Why is this change necessary?", "path": "demos/package.json", "hunk": "@@ -5,6 +5,7 @@\n \"type\": \"module\",\n \"scripts\": {\n \"start\": \"vite --host\",\n+ \"start:demos\": \"vite --host --port 4080\",", "resolving_sha": "457404e1bf9e6007b44541f027d7b8e2490373ca", "...
diff --git a/demos/src/Commands/Cut/React/index.spec.js b/demos/src/Commands/Cut/React/index.spec.js deleted file mode 100644 index 0921e44f8a..0000000000 --- a/demos/src/Commands/Cut/React/index.spec.js +++ /dev/null @@ -1,18 +0,0 @@ -context('/src/Commands/Cut/React/', () => { - beforeEach(() => { - cy.visit('/sr...
true
ueberdosis/tiptap
7,845
comment_to_fix
test: migrate Cypress e2e suite to Playwright + port core specs to Vitest
Why is this change necessary?
d9daae031a4f72ae81af039a721df66f5c0c2696
457404e1bf9e6007b44541f027d7b8e2490373ca
diff --git a/demos/package.json b/demos/package.json index 21d8f6a121..e7a548ac27 100644 --- a/demos/package.json +++ b/demos/package.json @@ -5,6 +5,7 @@ "type": "module", "scripts": { "start": "vite --host", + "start:e2e": "vite --host --port 4080", "build:demos": "vite build", "preview": "vit...
[ "demos/package.json" ]
[ { "comment": "Why is this change necessary?", "path": "demos/package.json", "hunk": "@@ -5,6 +5,7 @@\n \"type\": \"module\",\n \"scripts\": {\n \"start\": \"vite --host\",\n+ \"start:demos\": \"vite --host --port 4080\",", "resolving_sha": "457404e1bf9e6007b44541f027d7b8e2490373ca", "...
true
ueberdosis/tiptap
7,835
issue_to_patch
Publish a new stable version
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will ...
7bf0e731f71ac794ced318a90bccdb1b105cf475
b2c84c2bc5496bf7d29765b3f2c854b1c4d7e796
diff --git a/.changeset/chilly-lamps-applaud.md b/.changeset/chilly-lamps-applaud.md deleted file mode 100644 index aacfcdcc33..0000000000 --- a/.changeset/chilly-lamps-applaud.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -"@tiptap/markdown": patch ---- - -Fix extra mark tokens after inline atom nodes during Markdown serializ...
[ ".changeset/chilly-lamps-applaud.md", ".changeset/fix-pos-non-text-nodes.md", ".changeset/fix-react-respect-immediately-render-on-next.md", ".changeset/hip-penguins-juggle.md", ".changeset/silent-baboons-explain.md", ".changeset/wet-poets-knock.md", "CHANGELOG.md", "packages-deprecated/extension-chara...
[]
true
ueberdosis/tiptap
7,844
issue_to_patch
Adjacent marks of same type with different attributes are merged in output of getMarkdown ### Affected Packages markdown ### Version(s) 3.20.4 ### Bug Description If 2 or more marks of the same type but with different attributes are adjacent to each other, they are merged into one. Example: The following HTML `...
fix(markdown): serialize adjacent marks with different attributes separately
## Changes Overview Fix adjacent marks of the same type (e.g., links) with different attributes being merged into one when serializing to markdown. Three consecutive links with different URLs no longer produce `[examplegithubtiptap](https://tiptap.dev)` — instead they correctly render as `[example](https://example.c...
01664c7e6c1a9175b04a3cf06d3d630f5b9dfc4e
d21ef33148b7e098ee6ff8f6011719954c663952
diff --git a/.changeset/silent-baboons-explain.md b/.changeset/silent-baboons-explain.md new file mode 100644 index 0000000000..f097dddc2c --- /dev/null +++ b/.changeset/silent-baboons-explain.md @@ -0,0 +1,5 @@ +--- +"@tiptap/markdown": patch +--- + +Fix adjacent marks of the same type with different attributes being ...
[ ".changeset/silent-baboons-explain.md", "packages/markdown/__tests__/overlapping-marks.spec.ts", "packages/markdown/src/MarkdownManager.ts", "packages/markdown/src/utils.ts" ]
[ { "comment": "`attrsEqual` can return true for different key sets when the values are `undefined` (e.g. `{ foo: undefined }` vs `{ bar: undefined }`), because it only compares `Object.keys(a)` values against `b[key]` without verifying `b` actually has that key. This can incorrectly treat different mark attribut...
diff --git a/packages/markdown/__tests__/overlapping-marks.spec.ts b/packages/markdown/__tests__/overlapping-marks.spec.ts index a6eb17df0e..57cfb7b199 100644 --- a/packages/markdown/__tests__/overlapping-marks.spec.ts +++ b/packages/markdown/__tests__/overlapping-marks.spec.ts @@ -12,24 +12,30 @@ import { describe, ex...
true
ueberdosis/tiptap
7,844
comment_to_fix
fix(markdown): serialize adjacent marks with different attributes separately
`attrsEqual` can return true for different key sets when the values are `undefined` (e.g. `{ foo: undefined }` vs `{ bar: undefined }`), because it only compares `Object.keys(a)` values against `b[key]` without verifying `b` actually has that key. This can incorrectly treat different mark attributes as equal and reintr...
01664c7e6c1a9175b04a3cf06d3d630f5b9dfc4e
d21ef33148b7e098ee6ff8f6011719954c663952
diff --git a/packages/markdown/src/utils.ts b/packages/markdown/src/utils.ts index 1f3bf7a13f..0524586dd6 100644 --- a/packages/markdown/src/utils.ts +++ b/packages/markdown/src/utils.ts @@ -24,14 +24,52 @@ export function wrapInMarkdownBlock(prefix: string, content: string) { return output.slice(0, output.length - ...
[ "packages/markdown/src/utils.ts" ]
[ { "comment": "`attrsEqual` can return true for different key sets when the values are `undefined` (e.g. `{ foo: undefined }` vs `{ bar: undefined }`), because it only compares `Object.keys(a)` values against `b[key]` without verifying `b` actually has that key. This can incorrectly treat different mark attribut...
true
ueberdosis/tiptap
7,844
comment_to_fix
fix(markdown): serialize adjacent marks with different attributes separately
There are two consecutive JSDoc blocks above `markSetsEqual` (one saying “Check if two mark sets are equal.” and another with the updated description). Remove the duplicate so the generated docs/comments don’t contain conflicting/duplicated text.
01664c7e6c1a9175b04a3cf06d3d630f5b9dfc4e
d21ef33148b7e098ee6ff8f6011719954c663952
diff --git a/packages/markdown/src/MarkdownManager.ts b/packages/markdown/src/MarkdownManager.ts index 17edc5d14c..0dc4c47acd 100644 --- a/packages/markdown/src/MarkdownManager.ts +++ b/packages/markdown/src/MarkdownManager.ts @@ -21,6 +21,7 @@ import { import { type Lexer, type Token, type TokenizerExtension, type To...
[ "packages/markdown/src/MarkdownManager.ts" ]
[ { "comment": "There are two consecutive JSDoc blocks above `markSetsEqual` (one saying “Check if two mark sets are equal.” and another with the updated description). Remove the duplicate so the generated docs/comments don’t contain conflicting/duplicated text.\n", "path": "packages/markdown/src/MarkdownMana...
true
ueberdosis/tiptap
7,844
comment_to_fix
fix(markdown): serialize adjacent marks with different attributes separately
`markSetsEqual` is now attribute-aware, but some other boundary/order decisions in this serializer still only look at mark *type* (e.g. `getMarksToOpenForSerialization` uses `nextMarkTypes` by type to decide “continuing” vs “ending”). With attribute-aware marks, a mark can have the same type in the next node but be log...
01664c7e6c1a9175b04a3cf06d3d630f5b9dfc4e
d21ef33148b7e098ee6ff8f6011719954c663952
diff --git a/packages/markdown/src/MarkdownManager.ts b/packages/markdown/src/MarkdownManager.ts index 17edc5d14c..0dc4c47acd 100644 --- a/packages/markdown/src/MarkdownManager.ts +++ b/packages/markdown/src/MarkdownManager.ts @@ -21,6 +21,7 @@ import { import { type Lexer, type Token, type TokenizerExtension, type To...
[ "packages/markdown/src/MarkdownManager.ts" ]
[ { "comment": "`markSetsEqual` is now attribute-aware, but some other boundary/order decisions in this serializer still only look at mark *type* (e.g. `getMarksToOpenForSerialization` uses `nextMarkTypes` by type to decide “continuing” vs “ending”). With attribute-aware marks, a mark can have the same type in th...
true
ueberdosis/tiptap
7,844
comment_to_fix
fix(markdown): serialize adjacent marks with different attributes separately
The `normalizeMarks` helper is duplicated in this file (once in the existing “Overlapping marks serialization” suite and again in this new suite). Consider hoisting it to a shared top-level helper to avoid divergence if it needs to change in the future.
01664c7e6c1a9175b04a3cf06d3d630f5b9dfc4e
d21ef33148b7e098ee6ff8f6011719954c663952
diff --git a/packages/markdown/__tests__/overlapping-marks.spec.ts b/packages/markdown/__tests__/overlapping-marks.spec.ts index a6eb17df0e..57cfb7b199 100644 --- a/packages/markdown/__tests__/overlapping-marks.spec.ts +++ b/packages/markdown/__tests__/overlapping-marks.spec.ts @@ -12,24 +12,30 @@ import { describe, ex...
[ "packages/markdown/__tests__/overlapping-marks.spec.ts" ]
[ { "comment": "The `normalizeMarks` helper is duplicated in this file (once in the existing “Overlapping marks serialization” suite and again in this new suite). Consider hoisting it to a shared top-level helper to avoid divergence if it needs to change in the future.", "path": "packages/markdown/__tests__/o...
true
ueberdosis/tiptap
7,843
issue_to_patch
Add test for inserting plain text content
## Changes Overview Added a test to verify the functionality of inserting plain text content into the editor. ## Implementation Approach Implemented a test case that initializes the editor, sets the cursor position, and checks the result of inserting plain text. ## Testing Done Tested the insertion of plain text b...
95e138c18807f2d31c7ef83b3762ae654c8c8243
a5b6ab52796390d47e48a14cb2c83756b57a8635
[ "packages/core/__tests__/insertContent.spec.ts" ]
[ { "comment": "The test name includes a literal `{ type: \"text\", text: \"whatever\" }`, but the assertion actually inserts `text: 'world'`. Please align the test name or the fixture value so the test description matches the behavior it covers.\n", "path": "packages/core/__tests__/insertContent.spec.ts", ...
diff --git a/packages/core/__tests__/insertContent.spec.ts b/packages/core/__tests__/insertContent.spec.ts new file mode 100644 index 0000000000..2511bd6d08 --- /dev/null +++ b/packages/core/__tests__/insertContent.spec.ts @@ -0,0 +1,28 @@ +import { Editor } from '@tiptap/core' +import Document from '@tiptap/extension-...
true
ueberdosis/tiptap
7,843
comment_to_fix
Add test for inserting plain text content
The test name includes a literal `{ type: "text", text: "whatever" }`, but the assertion actually inserts `text: 'world'`. Please align the test name or the fixture value so the test description matches the behavior it covers.
95e138c18807f2d31c7ef83b3762ae654c8c8243
a5b6ab52796390d47e48a14cb2c83756b57a8635
diff --git a/packages/core/__tests__/insertContent.spec.ts b/packages/core/__tests__/insertContent.spec.ts new file mode 100644 index 0000000000..2511bd6d08 --- /dev/null +++ b/packages/core/__tests__/insertContent.spec.ts @@ -0,0 +1,28 @@ +import { Editor } from '@tiptap/core' +import Document from '@tiptap/extension-...
[ "packages/core/__tests__/insertContent.spec.ts" ]
[ { "comment": "The test name includes a literal `{ type: \"text\", text: \"whatever\" }`, but the assertion actually inserts `text: 'world'`. Please align the test name or the fixture value so the test description matches the behavior it covers.\n", "path": "packages/core/__tests__/insertContent.spec.ts", ...
true
ueberdosis/tiptap
7,828
issue_to_patch
[Bug]: Performance regression in ReactNodeView ### Affected Packages react ### Version(s) 3.23.1 ### Bug Description Since 3.22.1, we've noticed performance regression in our ReactNodeView. Indeed, the fix for "Fix NodeView not re-rendering when a node's position changes without content or decoration changes (e.g...
fix(nodeview): eliminate unnecessary re-renders, add opt-in position tracking
## Changes Overview NodeViews no longer re-render when decorations or position change without content changes. Added `trackNodeViewPosition: boolean` option to `NodeViewRendererOptions` for opting into position-tracking so calls to `getPos()` stay current in render output. ## Implementation Approach - Removed the `n...
82d194a7b13c27ec2e9c78201ba533741efa3175
f5bf81691bd965380e9ec0cb262e1af63e65e187
diff --git a/.changeset/hip-penguins-juggle.md b/.changeset/hip-penguins-juggle.md new file mode 100644 index 0000000000..d0e63bf6d0 --- /dev/null +++ b/.changeset/hip-penguins-juggle.md @@ -0,0 +1,14 @@ +--- +"@tiptap/core": patch +"@tiptap/react": patch +"@tiptap/vue-2": patch +"@tiptap/vue-3": patch +--- + +fix(node...
[ ".changeset/hip-penguins-juggle.md", "demos/src/Extensions/DragHandleWithNodeViews/React/extensions/recommendation/Recommendation.jsx", "demos/src/Extensions/DragHandleWithNodeViews/Vue/extensions/recommendation/Recommendation.js", "demos/src/GuideNodeViews/Decorations/React/Component.tsx", "demos/src/Guide...
[ { "comment": "In React's `update()`, when the node reference is unchanged but the position changed (e.g., a transaction that simultaneously changes decorations and shifts position), `this.currentPos = newPos` is assigned here without notifying the renderer. The subsequent `editor.on('update')` -> `handlePositio...
true
ueberdosis/tiptap
7,828
comment_to_fix
fix(nodeview): eliminate unnecessary re-renders, add opt-in position tracking
In React's `update()`, when the node reference is unchanged but the position changed (e.g., a transaction that simultaneously changes decorations and shifts position), `this.currentPos = newPos` is assigned here without notifying the renderer. The subsequent `editor.on('update')` -> `handlePositionUpdate` callback will...
82d194a7b13c27ec2e9c78201ba533741efa3175
f5bf81691bd965380e9ec0cb262e1af63e65e187
diff --git a/packages/react/src/ReactNodeViewRenderer.tsx b/packages/react/src/ReactNodeViewRenderer.tsx index a796d82cca..23ab773675 100644 --- a/packages/react/src/ReactNodeViewRenderer.tsx +++ b/packages/react/src/ReactNodeViewRenderer.tsx @@ -5,13 +5,7 @@ import type { NodeViewRendererOptions, NodeViewRendere...
[ "packages/react/src/ReactNodeViewRenderer.tsx" ]
[ { "comment": "In React's `update()`, when the node reference is unchanged but the position changed (e.g., a transaction that simultaneously changes decorations and shifts position), `this.currentPos = newPos` is assigned here without notifying the renderer. The subsequent `editor.on('update')` -> `handlePositio...
true
ueberdosis/tiptap
7,828
comment_to_fix
fix(nodeview): eliminate unnecessary re-renders, add opt-in position tracking
The doc comment claims `trackNodeViewPosition` makes the node view receive a reactive `position` prop, but no `position` prop is added to `NodeViewProps` here or to `nodeViewProps` in the Vue packages. The implementation instead passes a fresh `getPos` closure to trigger re-renders. The PR description also mentions add...
82d194a7b13c27ec2e9c78201ba533741efa3175
f5bf81691bd965380e9ec0cb262e1af63e65e187
diff --git a/packages/core/src/types.ts b/packages/core/src/types.ts index de1bd45b99..94d94f31d9 100644 --- a/packages/core/src/types.ts +++ b/packages/core/src/types.ts @@ -735,6 +735,15 @@ export interface NodeViewRendererOptions { * Defaults to `false` to preserve existing behavior. */ selectedOnTextSele...
[ "packages/core/src/types.ts" ]
[ { "comment": "The doc comment claims `trackNodeViewPosition` makes the node view receive a reactive `position` prop, but no `position` prop is added to `NodeViewProps` here or to `nodeViewProps` in the Vue packages. The implementation instead passes a fresh `getPos` closure to trigger re-renders. The PR descrip...
true
ueberdosis/tiptap
7,828
comment_to_fix
fix(nodeview): eliminate unnecessary re-renders, add opt-in position tracking
Behavior regression for users that set `attrs` as a function. The previous `positionCheckCallback` called `this.updateElementAttributes()` after a position shift so that function-based `attrs` could refresh with the new position. The new `handlePositionUpdate` only calls `renderer.updateProps`; element attributes deriv...
82d194a7b13c27ec2e9c78201ba533741efa3175
f5bf81691bd965380e9ec0cb262e1af63e65e187
diff --git a/packages/react/src/ReactNodeViewRenderer.tsx b/packages/react/src/ReactNodeViewRenderer.tsx index a796d82cca..23ab773675 100644 --- a/packages/react/src/ReactNodeViewRenderer.tsx +++ b/packages/react/src/ReactNodeViewRenderer.tsx @@ -5,13 +5,7 @@ import type { NodeViewRendererOptions, NodeViewRendere...
[ "packages/react/src/ReactNodeViewRenderer.tsx" ]
[ { "comment": "Behavior regression for users that set `attrs` as a function. The previous `positionCheckCallback` called `this.updateElementAttributes()` after a position shift so that function-based `attrs` could refresh with the new position. The new `handlePositionUpdate` only calls `renderer.updateProps`; el...
true
ueberdosis/tiptap
7,828
comment_to_fix
fix(nodeview): eliminate unnecessary re-renders, add opt-in position tracking
`newPos` is computed unconditionally on every `update()` call, but is only consumed in the `nodeChanged` branch (line 353). For node views that have no `options.update` and where decorations or position change without a content change (the common typing-above scenario), this `getPos()` call is unused work performed for...
82d194a7b13c27ec2e9c78201ba533741efa3175
f5bf81691bd965380e9ec0cb262e1af63e65e187
diff --git a/packages/react/src/ReactNodeViewRenderer.tsx b/packages/react/src/ReactNodeViewRenderer.tsx index a796d82cca..23ab773675 100644 --- a/packages/react/src/ReactNodeViewRenderer.tsx +++ b/packages/react/src/ReactNodeViewRenderer.tsx @@ -5,13 +5,7 @@ import type { NodeViewRendererOptions, NodeViewRendere...
[ "packages/react/src/ReactNodeViewRenderer.tsx" ]
[ { "comment": "`newPos` is computed unconditionally on every `update()` call, but is only consumed in the `nodeChanged` branch (line 353). For node views that have no `options.update` and where decorations or position change without a content change (the common typing-above scenario), this `getPos()` call is unu...
true
ueberdosis/tiptap
7,828
comment_to_fix
fix(nodeview): eliminate unnecessary re-renders, add opt-in position tracking
When the node reference is unchanged but `decorations` change (the common case for inline/node decorations toggled by a plugin), the early-return path here skips calling `rerenderComponent`. As a side effect, `this.decorationClasses.value` (a reactive ref provided to the NodeViewWrapper and consumed via `provide('decor...
82d194a7b13c27ec2e9c78201ba533741efa3175
f5bf81691bd965380e9ec0cb262e1af63e65e187
diff --git a/packages/vue-3/src/VueNodeViewRenderer.ts b/packages/vue-3/src/VueNodeViewRenderer.ts index 09bb10ef26..8d813e1ced 100644 --- a/packages/vue-3/src/VueNodeViewRenderer.ts +++ b/packages/vue-3/src/VueNodeViewRenderer.ts @@ -1,6 +1,12 @@ /* eslint-disable no-underscore-dangle */ -import type { DecorationWith...
[ "packages/vue-3/src/VueNodeViewRenderer.ts" ]
[ { "comment": "When the node reference is unchanged but `decorations` change (the common case for inline/node decorations toggled by a plugin), the early-return path here skips calling `rerenderComponent`. As a side effect, `this.decorationClasses.value` (a reactive ref provided to the NodeViewWrapper and consum...
true
ueberdosis/tiptap
7,828
comment_to_fix
fix(nodeview): eliminate unnecessary re-renders, add opt-in position tracking
Same issue as in the Vue 3 renderer: the `!nodeChanged` early return no longer recomputes `this.decorationClasses.value` via `getDecorationClasses()`. `decorationClasses` is an observable ref exposed to descendants (line 104), so changes to `decorations` that previously updated the wrapper's class list will now be igno...
82d194a7b13c27ec2e9c78201ba533741efa3175
f5bf81691bd965380e9ec0cb262e1af63e65e187
diff --git a/packages/vue-2/src/VueNodeViewRenderer.ts b/packages/vue-2/src/VueNodeViewRenderer.ts index 1e9461b4f4..6754a67bb6 100644 --- a/packages/vue-2/src/VueNodeViewRenderer.ts +++ b/packages/vue-2/src/VueNodeViewRenderer.ts @@ -1,5 +1,11 @@ -import type { DecorationWithType, NodeViewProps, NodeViewRenderer, Node...
[ "packages/vue-2/src/VueNodeViewRenderer.ts" ]
[ { "comment": "Same issue as in the Vue 3 renderer: the `!nodeChanged` early return no longer recomputes `this.decorationClasses.value` via `getDecorationClasses()`. `decorationClasses` is an observable ref exposed to descendants (line 104), so changes to `decorations` that previously updated the wrapper's class...
true
ueberdosis/tiptap
7,828
comment_to_fix
fix(nodeview): eliminate unnecessary re-renders, add opt-in position tracking
The PR description states that this change adds a `position?: number` field to `NodeViewProps` and to Vue's `nodeViewProps` so consumers receive a reactive position value. However, neither `NodeViewProps` (in `packages/core/src/types.ts`) nor the `nodeViewProps` object exported by the Vue renderers is updated to includ...
82d194a7b13c27ec2e9c78201ba533741efa3175
f5bf81691bd965380e9ec0cb262e1af63e65e187
diff --git a/packages/core/src/types.ts b/packages/core/src/types.ts index de1bd45b99..94d94f31d9 100644 --- a/packages/core/src/types.ts +++ b/packages/core/src/types.ts @@ -735,6 +735,15 @@ export interface NodeViewRendererOptions { * Defaults to `false` to preserve existing behavior. */ selectedOnTextSele...
[ "packages/core/src/types.ts" ]
[ { "comment": "The PR description states that this change adds a `position?: number` field to `NodeViewProps` and to Vue's `nodeViewProps` so consumers receive a reactive position value. However, neither `NodeViewProps` (in `packages/core/src/types.ts`) nor the `nodeViewProps` object exported by the Vue renderer...
true
ueberdosis/tiptap
7,828
comment_to_fix
fix(nodeview): eliminate unnecessary re-renders, add opt-in position tracking
When `trackNodeViewPosition` is enabled and `update()` runs through the node-changed branch, `this.currentPos` is not refreshed here (unlike the React renderer, which updates `currentPos` to the new position before returning). After `rerenderComponent(extraProps)` re-renders the component with a fresh `getPos` closure,...
82d194a7b13c27ec2e9c78201ba533741efa3175
f5bf81691bd965380e9ec0cb262e1af63e65e187
diff --git a/packages/vue-3/src/VueNodeViewRenderer.ts b/packages/vue-3/src/VueNodeViewRenderer.ts index 09bb10ef26..8d813e1ced 100644 --- a/packages/vue-3/src/VueNodeViewRenderer.ts +++ b/packages/vue-3/src/VueNodeViewRenderer.ts @@ -1,6 +1,12 @@ /* eslint-disable no-underscore-dangle */ -import type { DecorationWith...
[ "packages/vue-3/src/VueNodeViewRenderer.ts" ]
[ { "comment": "When `trackNodeViewPosition` is enabled and `update()` runs through the node-changed branch, `this.currentPos` is not refreshed here (unlike the React renderer, which updates `currentPos` to the new position before returning). After `rerenderComponent(extraProps)` re-renders the component with a f...
true
ueberdosis/tiptap
7,828
comment_to_fix
fix(nodeview): eliminate unnecessary re-renders, add opt-in position tracking
Same issue as in `vue-3`: when `trackNodeViewPosition` is enabled and a node-changed update occurs, `this.currentPos` is not refreshed here, so the subsequent `handlePositionUpdate` listener will see a position mismatch and trigger a second `renderer.updateProps({ getPos: ... })` re-render on the same transaction. The ...
82d194a7b13c27ec2e9c78201ba533741efa3175
f5bf81691bd965380e9ec0cb262e1af63e65e187
diff --git a/packages/vue-2/src/VueNodeViewRenderer.ts b/packages/vue-2/src/VueNodeViewRenderer.ts index 1e9461b4f4..6754a67bb6 100644 --- a/packages/vue-2/src/VueNodeViewRenderer.ts +++ b/packages/vue-2/src/VueNodeViewRenderer.ts @@ -1,5 +1,11 @@ -import type { DecorationWithType, NodeViewProps, NodeViewRenderer, Node...
[ "packages/vue-2/src/VueNodeViewRenderer.ts" ]
[ { "comment": "Same issue as in `vue-3`: when `trackNodeViewPosition` is enabled and a node-changed update occurs, `this.currentPos` is not refreshed here, so the subsequent `handlePositionUpdate` listener will see a position mismatch and trigger a second `renderer.updateProps({ getPos: ... })` re-render on the ...
true
ultraworkers/claw-code
3,237
issue_to_patch
fix: validate attached redirection paths
## Summary - strip attached shell redirection operators before extracting path candidates - validate redirection targets like <../file and 2>../file against workspace scope - add regression coverage for attached redirection targets ## Validation - python3 -m unittest tests.test_security_scope -q - python3 -m compileal...
9b3548ca4337f54b001262474a35c209c17432b0
eb21179ddebdfc33b2a8615286746816d17a1181
diff --git a/src/path_scope.py b/src/path_scope.py index 52e7020c34..31828a6a9f 100644 --- a/src/path_scope.py +++ b/src/path_scope.py @@ -11,6 +11,7 @@ _WINDOWS_DRIVE_RE = re.compile(r'^[A-Za-z]:[\\/]') _WINDOWS_UNC_RE = re.compile(r'^(?:\\\\|//)[^\\/]+[\\/][^\\/]+') _ENV_ASSIGNMENT_RE = re.compile(r'^[A-Za-z_][A-Z...
[ "src/path_scope.py", "tests/test_security_scope.py" ]
[]
diff --git a/tests/test_security_scope.py b/tests/test_security_scope.py index 55cba20a96..59275dda78 100644 --- a/tests/test_security_scope.py +++ b/tests/test_security_scope.py @@ -72,6 +72,28 @@ def test_shell_environment_expansion_is_validated(self) -> None: self.assertFalse(decision.allowed) ...
true
ultraworkers/claw-code
3,040
issue_to_patch
fix: recognize OPENAI_API_KEY as valid auth for OpenAI-compatible endpoints
Previously, claw doctor would warn 'no supported auth env vars were found' even when OPENAI_API_KEY was set, because only ANTHROPIC_API_KEY and ANTHROPIC_AUTH_TOKEN were checked. This caused auth failures when using local models via Ollama or other OpenAI-compatible endpoints. Tested on Apple M1 MacBook Pro 16GB wit...
879962b826f318a4237c7cc95e4e7af65fad2235
9ad6c7c02a7802948b6d6b0eb40d95e70697de75
diff --git a/rust/crates/rusty-claude-cli/src/main.rs b/rust/crates/rusty-claude-cli/src/main.rs index 853b97a904..dafde1ac84 100644 --- a/rust/crates/rusty-claude-cli/src/main.rs +++ b/rust/crates/rusty-claude-cli/src/main.rs @@ -2111,25 +2111,26 @@ fn check_auth_health() -> DiagnosticCheck { let auth_token_prese...
[ "rust/crates/rusty-claude-cli/src/main.rs" ]
[]
true
ultraworkers/claw-code
3,230
issue_to_patch
docs: add interactive session example to quick start
## Summary - TBD ## Anti-slop triage - Classification: <!-- actionable-fix | docs-only | duplicate | generated-slop | unsafe | out-of-scope | needs-maintainer-decision --> - Evidence: <!-- issue link, repro command, failing test, docs source, or duplicate PR --> - Non-destructive review result: <!-- merge candid...
3acb677d7026922c2edf5abb7ece65488225a1e3
db9ff4925656131e6f625c9b81d1d8236fb01256
diff --git a/README.md b/README.md index ef9a2a65a0..8f41d4ffaf 100644 --- a/README.md +++ b/README.md @@ -134,6 +134,9 @@ export ANTHROPIC_API_KEY="sk-ant-..." # 4. Run a prompt ./target/debug/claw prompt "say hello" + +# 5. Start an interactive session +./target/debug/claw ``` > [!NOTE]
[ "README.md" ]
[ { "comment": "The new interactive-session step doesn’t indicate how to exit (e.g., Ctrl+D / `exit`) or what users should expect (REPL prompt, supported commands). Adding a brief note (even one line) will prevent users from getting stuck or unsure whether the command is working.", "path": "README.md", "h...
true
ultraworkers/claw-code
3,227
issue_to_patch
feat: wizard entry points — /setup command, claw setup subcommand (rebased)
## Problem The setup wizard was merged in PR #3017 but is completely orphaned — it's not declared as a module in `main.rs`, so users cannot reach it via any entry point. Additionally, `setup_wizard.rs` imports `RuntimeProviderConfig` which did not exist on `upstream/main`, so the module cannot even compile without the...
503d515f38004b0395f47ec63d0586cfb1601950
05f0201ec717a2120ca643ce4390ea5994dddc34
diff --git a/rust/crates/commands/src/lib.rs b/rust/crates/commands/src/lib.rs index 7cc7fa3fd6..7908691374 100644 --- a/rust/crates/commands/src/lib.rs +++ b/rust/crates/commands/src/lib.rs @@ -720,6 +720,13 @@ const SLASH_COMMAND_SPECS: &[SlashCommandSpec] = &[ argument_hint: None, resume_supported:...
[ "rust/crates/commands/src/lib.rs", "rust/crates/runtime/src/config.rs", "rust/crates/runtime/src/config_validate.rs", "rust/crates/runtime/src/lib.rs", "rust/crates/rusty-claude-cli/src/main.rs", "rust/crates/rusty-claude-cli/src/setup_wizard.rs" ]
[]
true
ultraworkers/claw-code
3,232
issue_to_patch
DeepSeek native API appears incompatible with provider/model model routing **Description** When using DeepSeek's official OpenAI-compatible endpoint: export OPENAI_API_KEY=... export OPENAI_BASE_URL=https://api.deepseek.com/v1 Claw requires model identifiers in provider/model format: claw --model openai/deepseek-v...
fix(providers): strip provider prefix from model names for openai_com…
…pat endpoints ## Summary Fixes an issue where OpenAI-compatible clients (like DeepSeek) fail due to strict provider/model naming conventions by dynamically stripping the provider prefix before sending the payload downstream. ## Anti-slop triage - Classification: <!-- actionable-fix | docs-only | duplicate | ge...
3acb677d7026922c2edf5abb7ece65488225a1e3
0755ddff3ca649866bdd954396e43b4e286d2495
diff --git a/rust/crates/api/src/providers/mod.rs b/rust/crates/api/src/providers/mod.rs index 57dce27ee8..054c335c30 100644 --- a/rust/crates/api/src/providers/mod.rs +++ b/rust/crates/api/src/providers/mod.rs @@ -296,6 +296,20 @@ pub fn metadata_for_model(model: &str) -> Option<ProviderMetadata> { None } + + ...
[ "rust/crates/api/src/providers/mod.rs", "rust/crates/api/src/providers/openai_compat.rs" ]
[]
true
ultraworkers/claw-code
3,234
issue_to_patch
fix(providers): preserve OpenAI-compatible reasoning history
## Summary - repair OpenAI-compatible send/stream model handling so provider-prefixed routes send the stripped downstream model while internal events keep the original model - persist non-streaming `Thinking` output blocks into CLI assistant events so reasoning history survives the next turn - isolate two runtime tests...
ae2f203eb5462fbb75f7e719da465c32fcd8b979
a1da1ca8e6602fbf46fc6e804fb84f7ed475cccb
diff --git a/rust/crates/api/src/providers/mod.rs b/rust/crates/api/src/providers/mod.rs index 054c335c30..2524e5520a 100644 --- a/rust/crates/api/src/providers/mod.rs +++ b/rust/crates/api/src/providers/mod.rs @@ -296,9 +296,6 @@ pub fn metadata_for_model(model: &str) -> Option<ProviderMetadata> { None } - - -...
[ "rust/crates/api/src/providers/mod.rs", "rust/crates/api/src/providers/openai_compat.rs", "rust/crates/api/tests/openai_compat_integration.rs", "rust/crates/runtime/src/session_control.rs", "rust/crates/runtime/src/worker_boot.rs", "rust/crates/rusty-claude-cli/src/main.rs" ]
[]
diff --git a/rust/crates/api/tests/openai_compat_integration.rs b/rust/crates/api/tests/openai_compat_integration.rs index 4521ebed9d..e6edb79150 100644 --- a/rust/crates/api/tests/openai_compat_integration.rs +++ b/rust/crates/api/tests/openai_compat_integration.rs @@ -548,12 +548,13 @@ async fn openai_compatible_clie...
true
ultraworkers/claw-code
3,236
issue_to_patch
fix: parse Ollama reasoning fields
## Summary - parse Ollama/Qwen `reasoning` fields in OpenAI-compatible non-streaming and streaming responses - add focused integration coverage for reasoning-before-text ordering - hint local Ollama `OPENAI_BASE_URL` for tagged Qwen model names and document local setup ## Validation - `cargo fmt --all --check` - `carg...
6001156a6ca4e87ec42a9f757d700385a0be142b
01f4dd48a38f280ad1dc230b4e170f67822e0478
diff --git a/rust/README.md b/rust/README.md index edcd4fefc1..53ebfc744e 100644 --- a/rust/README.md +++ b/rust/README.md @@ -40,6 +40,11 @@ Or provide an OAuth bearer token directly: export ANTHROPIC_AUTH_TOKEN="anthropic-oauth-or-proxy-bearer-token" ``` +For local OpenAI-compatible servers such as Ollama, includ...
[ "rust/README.md", "rust/crates/api/src/providers/openai_compat.rs", "rust/crates/api/tests/openai_compat_integration.rs", "rust/crates/rusty-claude-cli/src/main.rs" ]
[]
diff --git a/rust/crates/api/tests/openai_compat_integration.rs b/rust/crates/api/tests/openai_compat_integration.rs index e6edb79150..832d170e01 100644 --- a/rust/crates/api/tests/openai_compat_integration.rs +++ b/rust/crates/api/tests/openai_compat_integration.rs @@ -166,6 +166,55 @@ async fn send_message_preserves_...
true
ultraworkers/claw-code
3,009
issue_to_patch
fix: resolve clippy pedantic warnings across workspace
## Summary - Apply `clippy::pedantic` fixes across 10 files in the workspace - Patterns fixed: `map().unwrap_or()` → `map_or()`/`is_ok_and()`, `match_same_arms`, `collapsible_match`, `unnested_or_patterns`, `doc_markdown`, `useless_format`, `unnecessary_lazy_evaluations`, `redundant_closure` - All changes are mechanica...
4d3dc5b873680504aeeffe43f454278588368982
296d46291e1683f0e815eb67ab6e37407cbe1a1d
diff --git a/rust/crates/runtime/src/hooks.rs b/rust/crates/runtime/src/hooks.rs index 6abd69fbbd..a79c2d5d35 100644 --- a/rust/crates/runtime/src/hooks.rs +++ b/rust/crates/runtime/src/hooks.rs @@ -737,7 +737,7 @@ fn format_hook_failure(command: &str, code: i32, stdout: Option<&str>, stderr: & fn shell_command(comm...
[ "rust/crates/runtime/src/hooks.rs", "rust/crates/rusty-claude-cli/src/main.rs" ]
[]
true
ultraworkers/claw-code
3,216
issue_to_patch
fix: session resume — scan all workspaces, skip current empty session
## Problem When a user runs `/resume latest` from an active REPL session, it returns the most recently created session — which is always the empty session just created on startup. The user expects to resume the *previous* session with actual conversation history, but gets a blank session instead. Additionally, the se...
f1a16398fe03911db24f643d8a53696432deb145
346772a8b309fb5cd0c030049211571288eaeca8
diff --git a/rust/crates/runtime/src/session_control.rs b/rust/crates/runtime/src/session_control.rs index ebb252e115..90120effad 100644 --- a/rust/crates/runtime/src/session_control.rs +++ b/rust/crates/runtime/src/session_control.rs @@ -93,8 +93,19 @@ impl SessionStore { } pub fn resolve_reference(&self, ...
[ "rust/crates/runtime/src/session_control.rs", "rust/crates/rusty-claude-cli/src/main.rs" ]
[]
true
ultraworkers/claw-code
3,214
issue_to_patch
feat: API timeout config, Retry-After header, configurable retry, and 400 transient retry
## Problem PR #2816 has been open but stale since May 25 with merge conflicts and `CHANGES_REQUESTED` status. The 6 commits are self-contained and valuable, but could not be rebased because the branch predated critical upstream commits. ## Solution Fresh branch from current `upstream/main`, cherry-picking only the c...
f1a16398fe03911db24f643d8a53696432deb145
9e50cb6e200b2579e2c51f402bf8a39a82cc1c5c
diff --git a/rust/crates/api/src/error.rs b/rust/crates/api/src/error.rs index 1dc4fb295f..6c93ee9b59 100644 --- a/rust/crates/api/src/error.rs +++ b/rust/crates/api/src/error.rs @@ -20,6 +20,7 @@ const CONTEXT_WINDOW_ERROR_MARKERS: &[&str] = &[ "completion tokens", "prompt tokens", "request is too large...
[ "rust/crates/api/src/error.rs", "rust/crates/api/src/http_client.rs", "rust/crates/api/src/lib.rs", "rust/crates/api/src/providers/anthropic.rs", "rust/crates/api/src/providers/openai_compat.rs", "rust/crates/runtime/src/config.rs", "rust/crates/runtime/src/lib.rs", "rust/crates/rusty-claude-cli/src/m...
[]
true
ultraworkers/claw-code
3,209
issue_to_patch
Harden permission enforcement against sandbox bypasses
Close two ways the permission system could be bypassed: - Workspace path traversal: normalize `.`/`..` lexically before the boundary prefix comparison so paths like `/workspace/../../etc` can no longer escape the sandbox. Fixed in both the runtime enforcer and the duplicate check in the tools PowerShell path cla...
f1a16398fe03911db24f643d8a53696432deb145
e8c8ef1142039561036c0f9ce5d02fa4b65f8e4a
diff --git a/rust/crates/runtime/src/permission_enforcer.rs b/rust/crates/runtime/src/permission_enforcer.rs index 6ff872bcc8..e826c277ee 100644 --- a/rust/crates/runtime/src/permission_enforcer.rs +++ b/rust/crates/runtime/src/permission_enforcer.rs @@ -173,33 +173,119 @@ impl PermissionEnforcer { } } -/// Sim...
[ "rust/crates/runtime/src/permission_enforcer.rs", "rust/crates/tools/src/lib.rs" ]
[]
true
ultraworkers/claw-code
3,164
issue_to_patch
fix: recover from llama.cpp context overflow and reqwest SSE decode failures
## Summary Extend auto-compaction error detection to handle additional error patterns from llama.cpp backends: 'Context size has been exceeded', 'exceed_context_size_error', 'exceeds the available context size'. Also recover from reqwest 'error decoding response body' errors — some llama.cpp instances return a non-S...
f1a16398fe03911db24f643d8a53696432deb145
1d516be77909fd49d918537d2eb20c22912835e0
diff --git a/rust/crates/runtime/src/conversation.rs b/rust/crates/runtime/src/conversation.rs index ea50e3bd25..9c36329a16 100644 --- a/rust/crates/runtime/src/conversation.rs +++ b/rust/crates/runtime/src/conversation.rs @@ -204,6 +204,13 @@ where self } + /// Update the auto-compaction threshold a...
[ "rust/crates/runtime/src/conversation.rs", "rust/crates/rusty-claude-cli/src/main.rs" ]
[]
true
ultraworkers/claw-code
3,094
issue_to_patch
docs(roadmap): add #692 — dump-manifests help json lacks source schema
## ROADMAP pinpoint #692 — `dump-manifests --help --output-format json` lacks source/error schema Dogfooded for the 2026-05-25 01:30 Clawhip nudge (message 1508280974243266740). Reproduced on freshly rebuilt current `origin/main` binary (`git_sha f8e1bb726`). Active claw-code sessions: none. ### The pinpoint `dump-m...
f8e1bb7262b261da1ee6bfcd461bfc5b676f6a6d
5c46d6996186afe5f3187d8c98f599f77fd8e60a
diff --git a/ROADMAP.md b/ROADMAP.md index 5b85eb54fc..052b4f4b4c 100644 --- a/ROADMAP.md +++ b/ROADMAP.md @@ -6428,3 +6428,40 @@ Original filing (2026-04-18): the session emitted `SessionStart hook (completed) 450. **`prompt` emits `kind:"missing_credentials"` JSON on STDERR (not stdout), leaving stdout at 0 byte...
[ "ROADMAP.md" ]
[]
true
ultraworkers/claw-code
3,021
issue_to_patch
Document TweetClaw skill install example
## Summary - Documents the existing `claw skills install <path>` flow with a concrete external-skill example. - Uses TweetClaw's `skills/tweetclaw` directory to show how a local `SKILL.md` source can be installed and inspected. - Adds a short credential-safety note for Xquik configuration. ## Validation - `git diff ...
8f55870dad9a49216561d7d6312f96769d42adc4
19c7d7ff6856c56b7c7fa8f931d46eb4945a059d
diff --git a/USAGE.md b/USAGE.md index c8e7b09692..bd21dac861 100644 --- a/USAGE.md +++ b/USAGE.md @@ -413,6 +413,27 @@ cd rust ./target/debug/claw system-prompt --cwd .. --date 2026-04-04 ``` +## Install an external skill + +`claw skills install <path>` accepts a local skill directory that contains +`SKILL.md` or ...
[ "USAGE.md" ]
[]
true
ultraworkers/claw-code
2,815
issue_to_patch
fix: resolve EACCES error from incorrect bundled plugins directory
**Cam's Explanation:** Hello, I found an issue with the resulting binary when following the quick start guide and doing: ``` # Inspect available commands cd rust/ cargo run -p rusty-claude-cli -- --help # Build the workspace (build a release binary instead) cargo build -r --workspace ``` when using the resu...
6db68a2baa85dc7853d7220a75e778eecfd14b2b
961ba68687531318030c3c95ec61dfb1956c540e
diff --git a/rust/crates/plugins/src/lib.rs b/rust/crates/plugins/src/lib.rs index 765c0ac242..b74bbfd433 100644 --- a/rust/crates/plugins/src/lib.rs +++ b/rust/crates/plugins/src/lib.rs @@ -1037,8 +1037,59 @@ impl PluginManager { Self { config } } + /// Returns the default bundled plugins root direc...
[ "rust/crates/plugins/src/lib.rs" ]
[]
true
ultraworkers/claw-code
3,063
issue_to_patch
fix: return conservative token limits for unspecified models
to avoid crashes ## Summary - When working with a model not specially handled and coded in rust/crates/api/src/providers/mod.rs, the claw doesn't have an idea about the context window size. It will keep on growing without automatic compact, eventually lead of crash of the claw process when an error is thrown in the...
f8e1bb7262b261da1ee6bfcd461bfc5b676f6a6d
435d32963c65a6a644391c46c71cf45a47678cdc
diff --git a/rust/crates/api/src/providers/mod.rs b/rust/crates/api/src/providers/mod.rs index af1776fefb..ce3f8f0b83 100644 --- a/rust/crates/api/src/providers/mod.rs +++ b/rust/crates/api/src/providers/mod.rs @@ -640,7 +640,14 @@ pub fn model_token_limit(model: &str) -> Option<ModelTokenLimit> { max_outp...
[ "rust/crates/api/src/providers/mod.rs" ]
[]
true
ultraworkers/claw-code
3,010
issue_to_patch
feat: truncate oversized git diff in system prompt
## Summary - Cap git diff output in the system prompt at 50,000 characters to prevent context window bloat - Truncation respects UTF-8 character boundaries to avoid producing invalid strings - Appends a clear `... [diff truncated — too large for system prompt]` marker when truncation occurs ## Motivation Large reposit...
357629dbd9b300cbea7f484b6df263a862e20a84
cec026b0db516f53165e574bf8865126d655b2ec
diff --git a/rust/crates/runtime/src/prompt.rs b/rust/crates/runtime/src/prompt.rs index 1e6c4eda85..a41078d49f 100644 --- a/rust/crates/runtime/src/prompt.rs +++ b/rust/crates/runtime/src/prompt.rs @@ -42,6 +42,7 @@ pub const SYSTEM_PROMPT_DYNAMIC_BOUNDARY: &str = "__SYSTEM_PROMPT_DYNAMIC_BOUNDA pub const FRONTIER_MO...
[ "rust/crates/runtime/src/prompt.rs" ]
[]
true
ultraworkers/claw-code
3,041
issue_to_patch
fix: resolve model aliases before syntax validation
Currently, `validate_model_syntax` is called on the raw CLI argument before `resolve_model_alias_with_config` has a chance to expand user-defined aliases from `.claw.json`. This causes perfectly valid aliases to be rejected as invalid syntax (e.g. `last` is rejected for not matching the `provider/model` shape). This pa...
f8e1bb7262b261da1ee6bfcd461bfc5b676f6a6d
9dfb8239a74432248e188930784c31d1873e1d42
diff --git a/rust/Cargo.lock b/rust/Cargo.lock index 740147e78e..df6e4a1633 100644 --- a/rust/Cargo.lock +++ b/rust/Cargo.lock @@ -1453,6 +1453,7 @@ dependencies = [ "commands", "compat-harness", "crossterm", + "log", "mock-anthropic-service", "plugins", "pulldown-cmark", diff --git a/rust/crates/rusty-clau...
[ "rust/Cargo.lock", "rust/crates/rusty-claude-cli/Cargo.toml", "rust/crates/rusty-claude-cli/src/main.rs", "rust/crates/rusty-claude-cli/tests/cli_flags_and_config_defaults.rs", "rust/crates/rusty-claude-cli/tests/compact_output.rs", "rust/crates/rusty-claude-cli/tests/mock_parity_harness.rs", "rust/crat...
[]
diff --git a/rust/crates/rusty-claude-cli/tests/cli_flags_and_config_defaults.rs b/rust/crates/rusty-claude-cli/tests/cli_flags_and_config_defaults.rs index 071d53a834..95fd133da5 100644 --- a/rust/crates/rusty-claude-cli/tests/cli_flags_and_config_defaults.rs +++ b/rust/crates/rusty-claude-cli/tests/cli_flags_and_conf...
true
ultraworkers/claw-code
3,058
issue_to_patch
Fix: echo reasoning_content back for DeepSeek V4 multi-turn tool calls (fixed the Deepseek V4 thinking problem)
Fix: echo reasoning_content back for DeepSeek V4 multi-turn tool calls Two layers in the CLI silently dropped assistant thinking blocks before they could reach build_chat_completion_request, breaking multi-turn tool-using conversations with DeepSeek V4 (which mandates that prior reasoning_content be echoed back per...
f8e1bb7262b261da1ee6bfcd461bfc5b676f6a6d
6ddcd953d725212b8e9573f9b39f98a5f3ae8488
diff --git a/rust/crates/rusty-claude-cli/src/main.rs b/rust/crates/rusty-claude-cli/src/main.rs index ce94c8a6d0..9066718041 100644 --- a/rust/crates/rusty-claude-cli/src/main.rs +++ b/rust/crates/rusty-claude-cli/src/main.rs @@ -8767,6 +8767,8 @@ impl AnthropicRuntimeClient { let mut markdown_stream = Markdo...
[ "rust/crates/rusty-claude-cli/src/main.rs" ]
[]
true
ultraworkers/claw-code
3,053
issue_to_patch
推广推广我的Komic应用 合影合影!
Flatten prior compaction highlights directly into the top-level list (prefixed with `-`), while keeping the current round’s highlights under `- Newly compacted context:`
if !previous_highlights.is_empty() { lines.extend(previous_highlights.into_iter().map(|line| format!("- {line}"))); } This makes compaction summary size O(depth) rather than O(depth²) and nesting depth stays at 1 regardless of how many compactions run.Testing • Compaction runs cleanly in a live session • S...
f8e1bb7262b261da1ee6bfcd461bfc5b676f6a6d
5b1375b8408da52457ebcebb0458cc07285e87d0
diff --git a/rust/crates/runtime/src/compact.rs b/rust/crates/runtime/src/compact.rs index 7b0f5f95ed..48726b2dae 100644 --- a/rust/crates/runtime/src/compact.rs +++ b/rust/crates/runtime/src/compact.rs @@ -291,13 +291,11 @@ fn merge_compact_summaries(existing_summary: Option<&str>, new_summary: &str) -> let mut...
[ "rust/crates/runtime/src/compact.rs" ]
[]
true
ultraworkers/claw-code
3,015
issue_to_patch
fix: streaming robustness — OpenAI parsing, error detection, reasoning content
## Summary Shared streaming and response parsing robustness fixes that are prerequisites for several feature PRs. ## Changes | Commit | Change | |--------|--------| | `612e9ef` | Bounds check in compact boundary loop | | `5bb3b56` | Make `delta` field optional in `ChunkChoice` | | `4a63485` | Support `reasoning_cont...
b98b9a712e9aaa1a4f23bbec99a2182f14d89fd4
54015b876714b81a0d8320601a16d6bf404cb567
diff --git a/rust/crates/api/src/providers/openai_compat.rs b/rust/crates/api/src/providers/openai_compat.rs index b3800d6acf..759a0b4b2c 100644 --- a/rust/crates/api/src/providers/openai_compat.rs +++ b/rust/crates/api/src/providers/openai_compat.rs @@ -497,10 +497,12 @@ impl StreamState { } for ch...
[ "rust/crates/api/src/providers/openai_compat.rs", "rust/crates/commands/src/lib.rs", "rust/crates/runtime/src/compact.rs", "rust/scripts/install.sh" ]
[]
true
ultraworkers/claw-code
3,049
issue_to_patch
feat: add native Gemini support to openai_compat provider
## Description This PR enables native integration with Google Gemini by updating the `wire_model_for_base_url` logic in the `openai_compat` provider. Previously, when using a custom `OPENAI_BASE_URL` (such as the Google Generative Language API endpoint), `claw-code` would preserve the `openai/` prefix in the outg...
f8e1bb7262b261da1ee6bfcd461bfc5b676f6a6d
be36d5ef413a4c2f4d192cc8573d971cc51de8b9
diff --git a/rust/crates/api/src/providers/openai_compat.rs b/rust/crates/api/src/providers/openai_compat.rs index 1d53f120b4..4f199a3e94 100644 --- a/rust/crates/api/src/providers/openai_compat.rs +++ b/rust/crates/api/src/providers/openai_compat.rs @@ -928,13 +928,14 @@ fn wire_model_for_base_url<'a>( if lowered...
[ "rust/crates/api/src/providers/openai_compat.rs" ]
[]
true
ultraworkers/claw-code
3,042
issue_to_patch
feat(tools): add LoggingAspect to unified tool dispatch entry point
## Summary Annotates `execute_tool_with_enforcer` — the single match dispatch every tool invocation flows through — with `aspect_std::LoggingAspect`, creating a structured audit trail for tool execution where none currently exists. Adds three small deps (`aspect-core`, `aspect-macros`, `aspect-std`, all pinned to a g...
63ce483c2788a96f470acd4625d8540292bdd16e
f4e029935a0dbcadd61b749a953f75246174df00
diff --git a/rust/Cargo.lock b/rust/Cargo.lock index 740147e78e..a7c95c8329 100644 --- a/rust/Cargo.lock +++ b/rust/Cargo.lock @@ -42,6 +42,35 @@ dependencies = [ "tokio", ] +[[package]] +name = "aspect-core" +version = "0.1.0" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "70188b9b...
[ "rust/Cargo.lock", "rust/crates/tools/Cargo.toml", "rust/crates/tools/src/lib.rs" ]
[]
true
ultraworkers/claw-code
3,017
issue_to_patch
feat: interactive provider wizard with fast model selection
b98b9a712e9aaa1a4f23bbec99a2182f14d89fd4
a9d04adbc2efcf92fce6096b03d7ca40806331c3
diff --git a/rust/crates/api/src/providers/openai_compat.rs b/rust/crates/api/src/providers/openai_compat.rs index b3800d6acf..759a0b4b2c 100644 --- a/rust/crates/api/src/providers/openai_compat.rs +++ b/rust/crates/api/src/providers/openai_compat.rs @@ -497,10 +497,12 @@ impl StreamState { } for ch...
[ "rust/crates/api/src/providers/openai_compat.rs", "rust/crates/commands/src/lib.rs", "rust/crates/runtime/src/compact.rs", "rust/crates/runtime/src/config.rs", "rust/crates/rusty-claude-cli/src/setup_wizard.rs", "rust/scripts/install.sh" ]
[]
true
ultraworkers/claw-code
2,832
issue_to_patch
feat: git-aware context tools
## Summary This PR adds **five native, read-only git tools** that replace ad-hoc `bash` invocations for common git operations: `GitStatus`, `GitDiff`, `GitLog`, `GitShow`, and `GitBlame`. ## Problem Before this change, the model had to use the generic `bash` tool for every git operation. This created several frictio...
b98b9a712e9aaa1a4f23bbec99a2182f14d89fd4
7aedde7bf5b6a6849aa4f0c12d3e882795fa5fbb
diff --git a/rust/crates/api/src/providers/openai_compat.rs b/rust/crates/api/src/providers/openai_compat.rs index b3800d6acf..9da1e22d1a 100644 --- a/rust/crates/api/src/providers/openai_compat.rs +++ b/rust/crates/api/src/providers/openai_compat.rs @@ -497,10 +497,12 @@ impl StreamState { } for ch...
[ "rust/crates/api/src/providers/openai_compat.rs", "rust/crates/commands/src/lib.rs", "rust/crates/runtime/src/compact.rs", "rust/crates/tools/GIT_TOOLS_README.md", "rust/crates/tools/src/lib.rs", "rust/scripts/install.sh" ]
[]
true
ultraworkers/claw-code
2,811
issue_to_patch
fix: /resume latest searches all workspaces
## Summary Fixes `/resume latest` not finding sessions. Two separate bugs that together made session resume nearly unusable when switching directories. ## Problem this solves ### Bug 1: `/resume latest` only searches current workspace Before: sessions were only searched in the current workspace's fingerprinted direc...
b98b9a712e9aaa1a4f23bbec99a2182f14d89fd4
79a41e15694d3a4f87e06f9264c49d6627a813ba
diff --git a/rust/crates/api/src/providers/openai_compat.rs b/rust/crates/api/src/providers/openai_compat.rs index b3800d6acf..9da1e22d1a 100644 --- a/rust/crates/api/src/providers/openai_compat.rs +++ b/rust/crates/api/src/providers/openai_compat.rs @@ -497,10 +497,12 @@ impl StreamState { } for ch...
[ "rust/crates/api/src/providers/openai_compat.rs", "rust/crates/commands/src/lib.rs", "rust/crates/runtime/src/compact.rs", "rust/crates/runtime/src/config_validate.rs", "rust/crates/runtime/src/session_control.rs", "rust/crates/rusty-claude-cli/src/main.rs", "rust/scripts/install.sh" ]
[]
true
ultraworkers/claw-code
3,110
issue_to_patch
Fix claw-analog bootstrap phase drift errors
## Summary - Replace arbitrary/non-empty phase acceptance in `claw-analog` RAG/bootstrap formatting with a known phase allowlist. - Preserve/centralize the typed `unknown_bootstrap_phase` error shape with `field`, `received_value`, and `allowed_values` context. - Add regression coverage for unrecognized phase drift in ...
590b5b614c2d92a10eba21d360defeac78853aef
789ea9aac8a41210a1ca19711f3414ab349d65c8
diff --git a/rust/crates/claw-analog/src/lib.rs b/rust/crates/claw-analog/src/lib.rs index 0ffc33bc14..33e4863f0c 100644 --- a/rust/crates/claw-analog/src/lib.rs +++ b/rust/crates/claw-analog/src/lib.rs @@ -1109,25 +1109,33 @@ enum BlockKind { }, } +const KNOWN_RAG_BOOTSTRAP_PHASES: &[&str] = + &["1-sqlite-n...
[ "rust/crates/claw-analog/src/lib.rs" ]
[]
true
ultraworkers/claw-code
3,111
issue_to_patch
Fix ROADMAP #694: add local pre-push build gate
## Summary - add/tighten `.github/hooks/pre-push` as a repository-local pre-push safety gate - run `cargo build --manifest-path rust/Cargo.toml --workspace --locked` from repo root - document install, existing `core.hooksPath` handling, and explicit `SKIP_CLAW_PRE_PUSH_BUILD=1` bypass ## Verification - `bash -n .githu...
98f8926998e4447f7b388326dd7ce3e3b3453d7d
920d5c6c3a8cc73cc9b659b7c5e903c52d3afa14
diff --git a/.github/hooks/pre-push b/.github/hooks/pre-push index 2f3967449f..c3644a31cc 100755 --- a/.github/hooks/pre-push +++ b/.github/hooks/pre-push @@ -8,6 +8,11 @@ # caught before pushing to main or PR branches. set -euo pipefail +if [[ "${SKIP_CLAW_PRE_PUSH_BUILD:-}" == "1" ]]; then + echo "pre-push: SKIP...
[ ".github/hooks/pre-push", "CONTRIBUTING.md", "docs/g013-roadmap-pinpoints-693-695-verification-map.md" ]
[]
true