repo
stringlengths
5
53
pr_number
int32
1
321k
task_type
stringclasses
2 values
issue_text
stringlengths
0
81.2k
pr_title
stringlengths
1
319
pr_body
stringlengths
0
105k
base_sha
stringlengths
40
40
head_sha
stringlengths
40
40
gold_diff
stringlengths
0
202M
changed_files
listlengths
0
100
review_threads
listlengths
0
100
test_patch
stringlengths
0
23.4M
merged
bool
1 class
zenorocha/clipboard.js
720
issue_to_patch
Remove unnecessary code and add node version control
This PR remove `import listen from 'good-listener'` dependency from `test/clipboard.js` and add `.nvmrc` to the project to control which Node version we will be using while running the project.
221efae529a9d2eef34aade78879240c6ba00da6
ddb5adc6f88ecd237462cab60fa48b5f868a35ac
diff --git a/.nvmrc b/.nvmrc new file mode 100644 index 00000000..8351c193 --- /dev/null +++ b/.nvmrc @@ -0,0 +1,1 @@ +14 diff --git a/dist/clipboard.js b/dist/clipboard.js index d3c4a942..23e2bfc8 100644 --- a/dist/clipboard.js +++ b/dist/clipboard.js @@ -71,7 +71,7 @@ var ClipboardAction = /*#__PURE__*/function () { ...
[ ".nvmrc", "dist/clipboard.js", "test/clipboard.js" ]
[]
diff --git a/test/clipboard.js b/test/clipboard.js index 9ed1a90d..0a59e20d 100644 --- a/test/clipboard.js +++ b/test/clipboard.js @@ -1,6 +1,5 @@ import Clipboard from '../src/clipboard'; import ClipboardAction from '../src/clipboard-action'; -import listen from 'good-listener'; describe('Clipboard', () => { b...
true
zenorocha/clipboard.js
747
issue_to_patch
update release version for package.js
<!-- Please make sure to read the Pull Request Guidelines: https://github.com/zenorocha/clipboard.js/blob/master/contributing.md#proposing-pull-requests --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> **What kind of change does this PR introduce?** (check at least one) - ...
ac3ed3407136fa6e2852d86c64c467235d8d32bc
cda958cd5f818572250bc19b303de2462d3c2a33
diff --git a/package.js b/package.js index 4547ca4f..9ee0f12e 100644 --- a/package.js +++ b/package.js @@ -3,7 +3,7 @@ Package.describe({ name: 'zenorocha:clipboard', summary: 'Modern copy to clipboard. No Flash. Just 3kb.', - version: '2.0.6', + version: '2.0.8', git: 'https://github.com/zenorocha/clipboar...
[ "package.js" ]
[]
true
zenorocha/clipboard.js
746
issue_to_patch
After updating to the `2.0.7+` version, an error was reported: `Couldn't find preset "@babel/env"` My project is normal with the `2.0.6` version, but an error occurs when upgrading to the `2.0.8` version: ```js **17:15:32** ERROR in ./node_modules/clipboard/dist/clipboard.js **17:15:32** Module build failed (fr...
update to a project wide babel config
<!-- Please make sure to read the Pull Request Guidelines: https://github.com/zenorocha/clipboard.js/blob/master/contributing.md#proposing-pull-requests --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> **What kind of change does this PR introduce?** (check at least one) - ...
ac3ed3407136fa6e2852d86c64c467235d8d32bc
55fc546855e83252b39106a52d0c669609491895
diff --git a/.babelrc b/.babelrc.json similarity index 100% rename from .babelrc rename to .babelrc.json
[ ".babelrc.json" ]
[]
true
zenorocha/clipboard.js
744
issue_to_patch
updating bower version
<!-- Please make sure to read the Pull Request Guidelines: https://github.com/zenorocha/clipboard.js/blob/master/contributing.md#proposing-pull-requests --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> **What kind of change does this PR introduce?** (check at least one) - ...
ac3ed3407136fa6e2852d86c64c467235d8d32bc
983a8c0b4120c3c5f5b1346b832323a9a216866a
diff --git a/bower.json b/bower.json index 280af67d..0d19f317 100644 --- a/bower.json +++ b/bower.json @@ -1,6 +1,6 @@ { "name": "clipboard", - "version": "2.0.6", + "version": "2.0.8", "description": "Modern copy to clipboard. No Flash. Just 3kb", "license": "MIT", "main": "dist/clipboard.js",
[ "bower.json" ]
[]
true
zenorocha/clipboard.js
743
issue_to_patch
SyntaxError: Unexpected token ')' clipboard.js:17 in 2.0.7 <!-- PhantomJS 2.1.1 (Linux 0.0.0) ERROR SyntaxError: Unexpected token ')' at bower_components/clipboard/dist/clipboard.js:17 --> ## 🐛 Bug Report In dist/clipboard.js in v2.0.7, there's this bizarre number `134:` on line 20 The referen...
updating production version for bower
<!-- Please make sure to read the Pull Request Guidelines: https://github.com/zenorocha/clipboard.js/blob/master/contributing.md#proposing-pull-requests --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> **What kind of change does this PR introduce?** (check at least one) - ...
7dea403fbb5257809623cd1d635bd4a3878ea982
5c27fe02b84f05f0abafa4c5ccbfbe11310b242b
diff --git a/dist/clipboard.js b/dist/clipboard.js index 23e2bfc8..d54de7e1 100644 --- a/dist/clipboard.js +++ b/dist/clipboard.js @@ -1,5 +1,5 @@ /*! - * clipboard.js v2.0.6 + * clipboard.js v2.0.8 * https://clipboardjs.com/ * * Licensed MIT © Zeno Rocha @@ -14,19 +14,25 @@ else root["ClipboardJS"] = facto...
[ "dist/clipboard.js", "dist/clipboard.min.js" ]
[]
true
zenorocha/clipboard.js
741
issue_to_patch
ES6 in distribution ## 🐛 Bug Report ### Expected Behaviour Successful webpack build of our project ### Actual Behaviour `SyntaxError: Unexpected token: punc ())` ### To Reproduce 1. Use clipboard.js in a build process that expects ES5 modules 2. Let your project's package.json select version 2.0.7...
feat adding es5 as target for webpack compilation
<!-- Please make sure to read the Pull Request Guidelines: https://github.com/zenorocha/clipboard.js/blob/master/contributing.md#proposing-pull-requests --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> **What kind of change does this PR introduce?** (check at least one) - ...
c38b4ee76f1e9bacbf2f019e9e84f8f2e2407e91
6f10cf7e120e558379e433682c860ba3b574d3b4
diff --git a/webpack.config.js b/webpack.config.js index 1babb94c..14dc705d 100644 --- a/webpack.config.js +++ b/webpack.config.js @@ -13,6 +13,7 @@ Licensed MIT © Zeno Rocha`; module.exports = { entry: './src/clipboard.js', mode: 'production', + target: ['web', 'es5'], output: { filename: production ? ...
[ "webpack.config.js" ]
[ { "comment": "Nice! Did you try with ES5 build to validate the issue opened about it?", "path": "webpack.config.js", "hunk": "@@ -13,6 +13,7 @@ Licensed MIT © Zeno Rocha`;\n module.exports = {\n entry: './src/clipboard.js',\n mode: 'production',\n+ target: ['web', 'es5'],", "resolving_sha": "6f...
true
zenorocha/clipboard.js
736
issue_to_patch
TS errors or breaking changes in 2.0.7 <!-- ! PLEASE HELP US HELP YOU ! Bugs are fixed faster if you include: - a repro repository to inspect the code - an url to see the problem live --> ## 🐛 Bug Report After upgrading from 2.0.6 to 2.0.7 I started getting TS errors, see the codesandbox repr...
updating type definitions
<!-- Please make sure to read the Pull Request Guidelines: https://github.com/zenorocha/clipboard.js/blob/master/contributing.md#proposing-pull-requests --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> **What kind of change does this PR introduce?** (check at least one) - ...
c38b4ee76f1e9bacbf2f019e9e84f8f2e2407e91
2d5e3d231732e3bdf731c4a9071ae9cc2feecb25
diff --git a/src/clipboard.d.ts b/src/clipboard.d.ts index bad95ff0..b45dcc6b 100644 --- a/src/clipboard.d.ts +++ b/src/clipboard.d.ts @@ -1,136 +1,84 @@ /// <reference lib="dom"/> -import { TinyEmitter } from 'tiny-emitter'; - type Action = 'cut' | 'copy'; - -type Target = string | HTMLElement; - -type Trigger = s...
[ "src/clipboard.d.ts" ]
[]
true
zenorocha/clipboard.js
733
issue_to_patch
removing element after selection
<!-- Please make sure to read the Pull Request Guidelines: https://github.com/zenorocha/clipboard.js/blob/master/contributing.md#proposing-pull-requests --> Closes Issue #732 <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> **What kind of change does this PR introduce?** (che...
17be1af63e685963991571ef5adbf988c087b3a3
c23b30d052c451998858b4202a2cc0df2a07e17e
diff --git a/src/clipboard-action.js b/src/clipboard-action.js index c7d3cf42..ab6a5f65 100644 --- a/src/clipboard-action.js +++ b/src/clipboard-action.js @@ -42,18 +42,10 @@ class ClipboardAction { /** * Creates a fake textarea element, sets its value from `text` property, - * and makes a selection on it. ...
[ "src/clipboard-action.js", "test/clipboard-action.js" ]
[ { "comment": "Nice! I don't know about the `xit` to skip tests in Mocha.", "path": "test/clipboard-action.js", "hunk": "@@ -37,7 +37,7 @@ describe('ClipboardAction', () => {\n });\n \n describe('#initSelection', () => {\n- it('should set the position right style property', (done) => {\n+ xit('...
diff --git a/test/clipboard-action.js b/test/clipboard-action.js index 8d5cc624..b589b4c5 100644 --- a/test/clipboard-action.js +++ b/test/clipboard-action.js @@ -47,7 +47,9 @@ describe('ClipboardAction', () => { text: 'foo', }); - assert.equal(clip.fakeElem.style.right, '-9999px'); + const ...
true
zenorocha/clipboard.js
733
comment_to_fix
removing element after selection
Nice! I don't know about the `xit` to skip tests in Mocha.
17be1af63e685963991571ef5adbf988c087b3a3
c23b30d052c451998858b4202a2cc0df2a07e17e
diff --git a/test/clipboard-action.js b/test/clipboard-action.js index 8d5cc624..b589b4c5 100644 --- a/test/clipboard-action.js +++ b/test/clipboard-action.js @@ -47,7 +47,9 @@ describe('ClipboardAction', () => { text: 'foo', }); - assert.equal(clip.fakeElem.style.right, '-9999px'); + const ...
[ "test/clipboard-action.js" ]
[ { "comment": "Nice! I don't know about the `xit` to skip tests in Mocha.", "path": "test/clipboard-action.js", "hunk": "@@ -37,7 +37,7 @@ describe('ClipboardAction', () => {\n });\n \n describe('#initSelection', () => {\n- it('should set the position right style property', (done) => {\n+ xit('...
true
zenorocha/clipboard.js
727
issue_to_patch
adding deploy action
<!-- Please make sure to read the Pull Request Guidelines: https://github.com/zenorocha/clipboard.js/blob/master/contributing.md#proposing-pull-requests --> As part of our migration, we can use this action to automate the deployments on NPM for new releases <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to...
2b48909ff1fb6da1378a3a6bc81a61a67f629dc2
9e34b45841daf9c0b2dd0538610829b38722b325
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml new file mode 100644 index 00000000..e0dadfc1 --- /dev/null +++ b/.github/workflows/publish.yml @@ -0,0 +1,47 @@ +# This workflow will run tests using node and then publish a package to GitHub Packages when a release is created +# For more infor...
[ ".github/workflows/publish.yml" ]
[]
true
zenorocha/clipboard.js
731
issue_to_patch
feat: add linter and linter action
**What kind of change does this PR introduce?** (check at least one) - [ ] Bugfix - [x] Feature - [x] Code style update - [x] Refactor - [ ] Build-related changes - [ ] Other, please describe: **Does this PR introduce a breaking change?** (check one) - [ ] Yes - [x] No If yes, please describe the impa...
982d5ef906e93e14ffb2064a8834e378a5893dd3
20b70bdbca56ce7801698930284639535c732cc1
diff --git a/.eslintignore b/.eslintignore new file mode 100644 index 00000000..87305477 --- /dev/null +++ b/.eslintignore @@ -0,0 +1,12 @@ +# Ignore artifacts: +dist + +lib +npm-debug.log +bower_components +node_modules +yarn-error.log +yarn.lock + +src/*.ts +/*.js diff --git a/.eslintrc.json b/.eslintrc.json new file...
[ ".eslintignore", ".eslintrc.json", ".github/workflows/test.js.yml", "package-lock.json", "package.json", "src/clipboard-action.js", "src/clipboard.js", "test/clipboard-action.js" ]
[ { "comment": "Hi 👋, @r3nanp we have one build where we run the tests and build the application, how about instead of creating a new workflow integrate the linter in the existing one? I guess this would be more simple,", "path": ".github/workflows/lint.yml", "hunk": "@@ -0,0 +1,22 @@\n+name: Lint", ...
diff --git a/test/clipboard-action.js b/test/clipboard-action.js index 7a33f383..8d5cc624 100644 --- a/test/clipboard-action.js +++ b/test/clipboard-action.js @@ -1,5 +1,5 @@ -import ClipboardAction from '../src/clipboard-action'; import Emitter from 'tiny-emitter'; +import ClipboardAction from '../src/clipboard-actio...
true
zenorocha/clipboard.js
730
issue_to_patch
Fix readme.md badge
<!-- Please make sure to read the Pull Request Guidelines: https://github.com/zenorocha/clipboard.js/blob/master/contributing.md#proposing-pull-requests --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> **What kind of change does this PR introduce?** (check at least one) - ...
28e9d15d13a65f1229dcfd8110f7042070f666dc
4553dfee2ab6120d45c8996fb138fb0a5fd0880e
diff --git a/readme.md b/readme.md index c552448f..6506470a 100644 --- a/readme.md +++ b/readme.md @@ -1,6 +1,6 @@ # clipboard.js -[![Build Status](https://github.com/zenorocha/clipboard.js/workflows/build/badge.svg) +![Build Status](https://github.com/zenorocha/clipboard.js/workflows/build/badge.svg) ![Killing Fla...
[ "readme.md" ]
[]
true
zenorocha/clipboard.js
729
issue_to_patch
Chore upgrade husky
**What kind of change does this PR introduce?** (check at least one) - [ ] Bugfix - [ ] Feature - [ ] Code style update - [ ] Refactor - [ ] Build-related changes - [x] Other, please describe: This PR adds Husky v.5.x.x to improve the triggers of Git hooks. **Does this PR introduce a breaking change?** (chec...
119edb067d7436c8bd9b8d9ee7f0d9838a96ae80
8718bdd2a287c2dc3b2e6410017b1addef30c564
diff --git a/.husky/.gitignore b/.husky/.gitignore new file mode 100644 index 00000000..c9cdc63b --- /dev/null +++ b/.husky/.gitignore @@ -0,0 +1,1 @@ +_ \ No newline at end of file diff --git a/.husky/pre-commit b/.husky/pre-commit new file mode 100755 index 00000000..d37daa07 --- /dev/null +++ b/.husky/pre-commit @@ ...
[ ".husky/.gitignore", ".husky/pre-commit", "package-lock.json", "package.json" ]
[]
true
zenorocha/clipboard.js
726
issue_to_patch
removing travis config
<!-- Please make sure to read the Pull Request Guidelines: https://github.com/zenorocha/clipboard.js/blob/master/contributing.md#proposing-pull-requests --> This PR removes Travis config file from, this is part of our migration to Github actions <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to che...
2b48909ff1fb6da1378a3a6bc81a61a67f629dc2
94a9d8d3ea8323b91e28cf81105060552b0d3448
diff --git a/.travis.yml b/.travis.yml deleted file mode 100644 index a4bb7b94..00000000 --- a/.travis.yml +++ /dev/null @@ -1,4 +0,0 @@ -sudo: false -language: node_js -node_js: - - stable diff --git a/readme.md b/readme.md index 91467688..c552448f 100644 --- a/readme.md +++ b/readme.md @@ -1,6 +1,6 @@ # clipboard.j...
[ ".travis.yml", "readme.md" ]
[]
true
zenorocha/clipboard.js
723
issue_to_patch
Add GH templates
## Description It will enable templates for new issues and PR's.
41c73cb7ebff5d71becf2ba2a8038d884227a534
40bf3736c405be24e810f3ace102e23b39c4fe87
diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md new file mode 100644 index 00000000..99fe3e69 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -0,0 +1,57 @@ +--- +name: 🐛 Bug Report +about: Submit a bug report to help us improve +labels: 'bug, needs triage' +--- + +<...
[ ".github/ISSUE_TEMPLATE/bug_report.md", ".github/ISSUE_TEMPLATE/documentation.md", ".github/ISSUE_TEMPLATE/proposal.md", ".github/PULL_REQUEST_TEMPLATE.md", ".github/issue_template.md" ]
[ { "comment": "What about creating an approach that makes issue and test declaration optional or less opinionated? I mean, for non-code PRs like documentation PRs, improvement or integrations suggestions, etc.", "path": ".github/PULL_REQUEST_TEMPLATE.md", "hunk": "@@ -0,0 +1,10 @@\n+Issue:", "resolvi...
true
zenorocha/clipboard.js
723
comment_to_fix
Add GH templates
What about creating an approach that makes issue and test declaration optional or less opinionated? I mean, for non-code PRs like documentation PRs, improvement or integrations suggestions, etc.
41c73cb7ebff5d71becf2ba2a8038d884227a534
40bf3736c405be24e810f3ace102e23b39c4fe87
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 00000000..b2f50c8d --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,35 @@ +<!-- +Please make sure to read the Pull Request Guidelines: +https://github.com/zenorocha/clipboard.js/blob/master/contrib...
[ ".github/PULL_REQUEST_TEMPLATE.md" ]
[ { "comment": "What about creating an approach that makes issue and test declaration optional or less opinionated? I mean, for non-code PRs like documentation PRs, improvement or integrations suggestions, etc.", "path": ".github/PULL_REQUEST_TEMPLATE.md", "hunk": "@@ -0,0 +1,10 @@\n+Issue:", "resolvi...
true
zenorocha/clipboard.js
723
comment_to_fix
Add GH templates
I would ask for the Operational System too. WDYT?
41c73cb7ebff5d71becf2ba2a8038d884227a534
40bf3736c405be24e810f3ace102e23b39c4fe87
diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md new file mode 100644 index 00000000..99fe3e69 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -0,0 +1,57 @@ +--- +name: 🐛 Bug Report +about: Submit a bug report to help us improve +labels: 'bug, needs triage' +--- + +<...
[ ".github/ISSUE_TEMPLATE/bug_report.md" ]
[ { "comment": "I would ask for the Operational System too. WDYT?", "path": ".github/ISSUE_TEMPLATE/bug_report.md", "hunk": "@@ -0,0 +1,53 @@\n+---\n+name: 🐛 Bug Report\n+about: Submit a bug report to help us improve\n+labels: 'bug, needs triage'\n+---\n+\n+<!--\n+\n+ ! PLEASE HELP US HELP YOU !\n+\n+ ...
true
zenorocha/clipboard.js
722
issue_to_patch
Adding basic Type definitions
## Description This PR adds initial support for Types Definitions, now we can offer some basic type checks =) <!--- Describe your changes in detail --> ## Motivation and Context the idea here is to give some better support for typescript without having to touch the source code, with the type definitions we can...
62eef3e5b0d6f09a15338ba9ffb7b6c12168e80c
b460d6864cf3e333dc3b1ba6ed6b348607590a6e
diff --git a/package-lock.json b/package-lock.json index f9b34bd7..cde2cdf5 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,61 +1,30 @@ { "name": "clipboard", "version": "2.0.6", - "lockfileVersion": 2, + "lockfileVersion": 1, "requires": true, - "packages": { - "": { - "name": "clipbo...
[ "package-lock.json", "package.json", "src/clipboard.d.ts", "src/clipboard.test-d.ts" ]
[ { "comment": "Just remember to add EOF.", "path": "src/clipboard.test-d.ts", "hunk": "@@ -0,0 +1,4 @@\n+import { expectType } from 'tsd';\n+import Clipboard from './clipboard';\n+\n+expectType<Clipboard>(new Clipboard('.btn'));", "resolving_sha": "b460d6864cf3e333dc3b1ba6ed6b348607590a6e", "reso...
true
zenorocha/clipboard.js
722
comment_to_fix
Adding basic Type definitions
Just remember to add EOF.
62eef3e5b0d6f09a15338ba9ffb7b6c12168e80c
b460d6864cf3e333dc3b1ba6ed6b348607590a6e
diff --git a/src/clipboard.test-d.ts b/src/clipboard.test-d.ts new file mode 100644 index 00000000..d09b4ebb --- /dev/null +++ b/src/clipboard.test-d.ts @@ -0,0 +1,4 @@ +import { expectType } from 'tsd'; +import Clipboard from './clipboard'; + +expectType<Clipboard>(new Clipboard('.btn'));
[ "src/clipboard.test-d.ts" ]
[ { "comment": "Just remember to add EOF.", "path": "src/clipboard.test-d.ts", "hunk": "@@ -0,0 +1,4 @@\n+import { expectType } from 'tsd';\n+import Clipboard from './clipboard';\n+\n+expectType<Clipboard>(new Clipboard('.btn'));", "resolving_sha": "b460d6864cf3e333dc3b1ba6ed6b348607590a6e", "reso...
true
zenorocha/clipboard.js
721
issue_to_patch
Feature Prettier
## Description This PR adds Prettier to be our code style formatting tool <!--- Describe your changes in detail --> ## Motivation and Context with more collaborators now, we want to improve the development experience while maintaining a unique code style consistent with the project. <!--- What types of c...
64797395643b6bab7221842150f63d5916dbb9be
971834388cb13d01bbe915f54ccb440490c7f4b4
diff --git a/.editorconfig b/.editorconfig index 0f1d01bd..202ee218 100644 --- a/.editorconfig +++ b/.editorconfig @@ -7,7 +7,7 @@ root = true [*] # Change these settings to your own preference indent_style = space -indent_size = 4 +indent_size = 2 # We recommend you to keep these unchanged end_of_line = lf diff...
[ ".editorconfig", ".prettierignore", ".prettierrc.json", "bower.json", "contributing.md", "demo/constructor-node.html", "demo/constructor-nodelist.html", "demo/constructor-selector.html", "demo/function-target.html", "demo/function-text.html", "demo/target-div.html", "demo/target-input.html", ...
[]
diff --git a/test/clipboard-action.js b/test/clipboard-action.js index 8a3133c9..7a33f383 100644 --- a/test/clipboard-action.js +++ b/test/clipboard-action.js @@ -2,242 +2,243 @@ import ClipboardAction from '../src/clipboard-action'; import Emitter from 'tiny-emitter'; describe('ClipboardAction', () => { - befor...
true
zenorocha/clipboard.js
703
issue_to_patch
Upgrade babel to version 7
Resurrecting an old PR, #602, from @pedroabreu. This is a straight upgrade maintaining the old behaviour.
26a8d6392456eebc7dfa3410e232f7319180d120
4456d61877446f9990f85fb1c5f7c2f10ea1e6ff
diff --git a/.babelrc b/.babelrc index 2e7d3f4f..b4421995 100644 --- a/.babelrc +++ b/.babelrc @@ -1,11 +1,9 @@ { "presets": [ [ - "env", + "@babel/env", { - "targets": { - "uglify": true - }, + "forceAllTransforms": true, "modules": false } ]...
[ ".babelrc", "dist/clipboard.js", "dist/clipboard.min.js", "package-lock.json", "package.json" ]
[]
true
zenorocha/clipboard.js
706
issue_to_patch
Fix broken link
Fixes #705
9b497dd03379b277a12c6ee4e75a764180ff8ca8
8b638a51e8c40660154ebc41912ddc97be957ce2
diff --git a/index.html b/index.html index f4e924de..abaea806 100644 --- a/index.html +++ b/index.html @@ -153,7 +153,7 @@ <h1 id="tooltips">Tooltips</h1> <p>Each application has different design needs, that's why clipboard.js does not include any CSS or built-in tooltip solution.</p> - <p>The toolt...
[ "index.html" ]
[]
true
zenorocha/clipboard.js
717
issue_to_patch
Add homepage to package.json
26a8d6392456eebc7dfa3410e232f7319180d120
946bc9f0a5161682c2acf53ba13843a2674ea972
diff --git a/package.json b/package.json index d35b6eb0..c98d1c12 100644 --- a/package.json +++ b/package.json @@ -2,6 +2,7 @@ "name": "clipboard", "version": "2.0.6", "description": "Modern copy to clipboard. No Flash. Just 2kb", + "homepage": "https://clipboardjs.com", "repository": "zenorocha/clipboard....
[ "package.json" ]
[]
true
zenorocha/clipboard.js
713
issue_to_patch
Bump ini from 1.3.5 to 1.3.8
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/npm/ini/commit/a2c5da86604bc2238fe393c5ff083bf23a9910eb"><code>a2c5da8</code></a> 1.3.8</li> <li><a href="https://github.com/npm/ini/commit/af5c6bb5dca6f0248c153aa87e25bddfc515ff6e">...
26a8d6392456eebc7dfa3410e232f7319180d120
2e4cf72d0b8eae5447f5e1fdd767dbfe7bcf3c55
diff --git a/package-lock.json b/package-lock.json index c4f2b804..de7abcff 100644 --- a/package-lock.json +++ b/package-lock.json @@ -2932,12 +2932,6 @@ "dev": true, "optional": true }, - "ini": { - "version": "1.3.5", - "bundled": true, - "dev": true, -...
[ "package-lock.json" ]
[]
true
zephyrproject-rtos/zephyr
108,984
issue_to_patch
disk: nvme: enable by default and select PCIE
enable the nvme disk by default, if enabled in the devicetree, also select all PCIE dependencies.
a7464a0211222bb087fd30b40cab8628cbc39720
94002c9c1dc02741be0b042e72b93a829e70abfa
diff --git a/drivers/disk/nvme/Kconfig b/drivers/disk/nvme/Kconfig index 4ab51992c1be4..9262b761da878 100644 --- a/drivers/disk/nvme/Kconfig +++ b/drivers/disk/nvme/Kconfig @@ -3,9 +3,12 @@ menuconfig NVME bool "NVMe disk" - depends on PCIE + select PCIE + select PCIE_MSI select PCIE_MSI_X select PCIE_MSI_MULT...
[ "drivers/disk/nvme/Kconfig", "tests/drivers/disk/disk_access/boards/intel_btl_s_crb.conf", "tests/drivers/disk/disk_access/boards/intel_ptl_h_crb.conf", "tests/drivers/disk/disk_access/boards/intel_wcl_crb.conf", "tests/drivers/disk/disk_access/boards/qemu_x86_64.conf", "tests/drivers/disk/disk_access/tes...
[]
diff --git a/tests/drivers/disk/disk_access/boards/intel_btl_s_crb.conf b/tests/drivers/disk/disk_access/boards/intel_btl_s_crb.conf deleted file mode 100644 index 109b049bcb4c7..0000000000000 --- a/tests/drivers/disk/disk_access/boards/intel_btl_s_crb.conf +++ /dev/null @@ -1,4 +0,0 @@ -CONFIG_NVME=y -CONFIG_PCIE_MSI=...
true
zephyrproject-rtos/zephyr
108,980
issue_to_patch
Bluetooth: trx_busy_iteration assert ### Describe the bug An assert is getting called somewhere in the Bluetooth stack. I've narrowed it down to the exact location: https://github.com/zephyrproject-rtos/zephyr/blob/v4.4.0-rc1/subsys/bluetooth/controller/ll_sw/nordic/lll/lll_conn.c#L192 This happens when the applicat...
Bluetooth: Controller: Fix timer start without LLL prepare at margin
This workaround addresses an assert that appears when nRF52 hardware running as central connects to a peripheral with certain connection parameters. Fixes #106450
7469b2241ed1e222ea4c03613febbc7951a59cb7
94d33035ef9534adb9b15681f16925dcc927044e
diff --git a/subsys/bluetooth/controller/ll_sw/nordic/hal/nrf5/radio/radio.c b/subsys/bluetooth/controller/ll_sw/nordic/hal/nrf5/radio/radio.c index 4705953edadae..cb60a0ed6c1be 100644 --- a/subsys/bluetooth/controller/ll_sw/nordic/hal/nrf5/radio/radio.c +++ b/subsys/bluetooth/controller/ll_sw/nordic/hal/nrf5/radio/rad...
[ "subsys/bluetooth/controller/ll_sw/nordic/hal/nrf5/radio/radio.c" ]
[]
true
zephyrproject-rtos/zephyr
83,470
issue_to_patch
drivers: led: lp50xx: add pm action for on/off
drivers: led: lp50xx: add pm action for on/off add functionality to turn off/on led driver lp50xx, reducing current consumption Signed-off-by: Shahin Haque <ShahinHaque97@outlook.com>
b54e0ba58fde513965d077f99c9f22125fe19d68
b893585907700389a40e955c1813e82cbee7c4a0
diff --git a/drivers/led/lp50xx.c b/drivers/led/lp50xx.c index 4f01788e9d27e..883f76885ae98 100644 --- a/drivers/led/lp50xx.c +++ b/drivers/led/lp50xx.c @@ -325,6 +325,10 @@ static int lp50xx_pm_action(const struct device *dev, return lp50xx_enable(dev, false); case PM_DEVICE_ACTION_RESUME: return lp50xx_enable...
[ "drivers/led/lp50xx.c" ]
[]
true
zephyrproject-rtos/zephyr
105,596
issue_to_patch
kernel/sched: fix IPI race in z_get_next_switch_handle
Move signal_pending_ipi() inside the K_SPINLOCK block in z_get_next_switch_handle(). Calling it after the lock release creates a window where a CPU can consume its own pending IPI bit via atomic_clear in signal_pending_ipi(), then silently drop it in arch_sched_directed_ipi() which skips the calling CPU (i == id). ...
3638fc57328a7a0e6988b79b0bdedd2b9e27e0e1
8bbe78422fdabb80fea4cc3c6bfa043613814b76
diff --git a/kernel/ipi.c b/kernel/ipi.c index 13377ee26c52f..f723f588db8f6 100644 --- a/kernel/ipi.c +++ b/kernel/ipi.c @@ -71,12 +71,15 @@ atomic_val_t ipi_mask_create(struct k_thread *thread) void signal_pending_ipi(void) { - /* Synchronization note: you might think we need to lock these - * two steps, but an I...
[ "kernel/ipi.c", "kernel/sched.c" ]
[ { "comment": "The fix is sound: `z_ready_thread()` holds `_sched_spinlock` when calling `flag_ipi()`, so moving `signal_pending_ipi()` inside the same lock makes `next_up()` + IPI dispatch atomic w.r.t. thread readying.\n\nHowever, `reschedule()` and `z_reschedule_irqlock()` have the same pattern — they call `s...
true
zephyrproject-rtos/zephyr
100,097
issue_to_patch
soc: ambiq: apollo4x: Add cache initialization for proper timing
Apollo4P requires cache to be configured and enabled early in the boot process for proper interrupt timing and 96 MHz operation. Without cache initialization, interrupts can be delayed by hundreds of microseconds, causing timing anomalies in time-critical applications. This aligns Apollo4P initialization with: - Ap...
acc53653b4707aa40c22aec8c33f1d733e5e670f
0321d20b3a84c8b6f79cb651bbdb8602d869272b
diff --git a/soc/ambiq/apollo4x/soc.c b/soc/ambiq/apollo4x/soc.c index 54daff08fc1ea..a644c677a8b80 100644 --- a/soc/ambiq/apollo4x/soc.c +++ b/soc/ambiq/apollo4x/soc.c @@ -13,6 +13,9 @@ LOG_MODULE_REGISTER(soc, CONFIG_SOC_LOG_LEVEL); extern void ambiq_power_init(void); void soc_early_init_hook(void) { + /* Configur...
[ "soc/ambiq/apollo4x/soc.c" ]
[]
true
zephyrproject-rtos/zephyr
109,875
issue_to_patch
llext: misc fixes and error checking
A variety of fixes and error checking from me and @nashif: * Cap variable length array in call_fn_table * Add bounds checking assert to llext_string * Validate st_shndx in llext_symbol_name for STT_SECTION symbols * Bound-check r_offset in Xtensa PLT relocatable branch * Validate st_shndx before indexing sect_hd...
91db82a245b731166c547a598029884cb32debe4
d24a3065218dadf017e6d95b89054385cef8ada2
diff --git a/include/zephyr/llext/llext_internal.h b/include/zephyr/llext/llext_internal.h index 8bd6fa4dd7096..29199031d84c7 100644 --- a/include/zephyr/llext/llext_internal.h +++ b/include/zephyr/llext/llext_internal.h @@ -32,6 +32,10 @@ const void *llext_loaded_sect_ptr(struct llext_loader *ldr, struct llext *ext, u...
[ "include/zephyr/llext/llext_internal.h", "include/zephyr/llext/loader.h", "subsys/llext/Kconfig", "subsys/llext/buf_loader.c", "subsys/llext/llext.c", "subsys/llext/llext_link.c", "subsys/llext/llext_load.c", "subsys/llext/llext_mem.c" ]
[ { "comment": "why not a runtime check? Asserts are not enabled in production builds.", "path": "include/zephyr/llext/llext_internal.h", "hunk": "@@ -32,6 +32,12 @@ const void *llext_loaded_sect_ptr(struct llext_loader *ldr, struct llext *ext, u\n static inline const char *llext_string(const struct llext...
true
zephyrproject-rtos/zephyr
108,359
issue_to_patch
Port drivers to use sys/ring_buffer There are some drivers that are implementing their own ring_buffer, there are cases where even functions names are colliding with sys/ring_buffer. Drivers doing it: `drivers/ethernet/eth_sam_gmac.c` `drivers/i2s/i2s_sam_ssc.c` `drivers/i2s/i2s_ll_stm32.h`
drivers: ethernet: sam_gmac: replace private ring_buffer with sys_ringq
Remove the driver-local struct ring_buffer in favour of sys_ringq. Pointers are stored directly in the ring queues, which removes the need for the POINTER_TO_UINT casts and fixes a potential platform-specific pointer truncation issue on 64-bit architectures. gmac_desc_list rings are unchanged as they require in-plac...
bcf31c20f01f11609dbff940483d5172d7897691
e96fb7d5ef0d133e77f98d37de53b8ce715ce0cd
diff --git a/drivers/ethernet/Kconfig.sam_gmac b/drivers/ethernet/Kconfig.sam_gmac index 78ea1c5ae62e4..8f3ad8c7491db 100644 --- a/drivers/ethernet/Kconfig.sam_gmac +++ b/drivers/ethernet/Kconfig.sam_gmac @@ -11,6 +11,7 @@ menuconfig ETH_SAM_GMAC DT_HAS_ATMEL_SAM0_GMAC_ENABLED select NOCACHE_MEMORY if ARCH_HAS_...
[ "drivers/ethernet/Kconfig.sam_gmac", "drivers/ethernet/eth_sam_gmac.c", "drivers/ethernet/eth_sam_gmac_priv.h" ]
[]
true
zephyrproject-rtos/zephyr
108,197
issue_to_patch
doc: kernel: update iterable sections to use cmake-side declaration
The usage section previously documented only the linker script-based declaration of iterable sections, which is toolchain-specific and not the recommended approach. The rewrite presents the CMake declaration as the recommended approach, which is toolchain-agnostic and more straightforward to use, while still acknowl...
f648774b71649528602b614360971e79f710530a
7f5a3da770d5231ad225239aa93aae0310037a31
diff --git a/doc/kernel/iterable_sections/index.rst b/doc/kernel/iterable_sections/index.rst index 17b7c76fab0a9..870364fab858a 100644 --- a/doc/kernel/iterable_sections/index.rst +++ b/doc/kernel/iterable_sections/index.rst @@ -7,12 +7,46 @@ This page contains the reference documentation for the iterable sections APIs...
[ "doc/kernel/iterable_sections/index.rst" ]
[]
true
zephyrproject-rtos/zephyr
98,255
issue_to_patch
Add fixed-size FIFO implementation
This PR aims to introduce a fixed-size FIFO implementation in Zephyr's utils library. It is built on top of the existing ring buffer and abstracts item management away from both the ring buffer and the user. The goal is to improve readability and reduce boilerplate in code that previously used ring buffers to im...
59a42a765d6d2cf6c7ff0b1e7a469d8d5ffe0139
d38b7efbcb938a447fc7bd1b7e2e5282d72c4efb
diff --git a/doc/kernel/data_structures/index.rst b/doc/kernel/data_structures/index.rst index b67cff1be1980..735edea8bddc3 100644 --- a/doc/kernel/data_structures/index.rst +++ b/doc/kernel/data_structures/index.rst @@ -39,3 +39,4 @@ structures are thread safe in specific usage scenarios (see mpsc_lockfree.rst s...
[ "doc/kernel/data_structures/index.rst", "doc/kernel/data_structures/ring_buffers.rst", "doc/kernel/data_structures/ringq.rst", "doc/releases/migration-guide-4.5.rst", "doc/releases/release-notes-4.5.rst", "drivers/console/ipm_console_receiver.c", "drivers/i2s/i2s_litex.c", "drivers/i2s/i2s_litex.h", ...
[ { "comment": "namespace with `sys_`", "path": "include/zephyr/sys/fifo.h", "hunk": "@@ -0,0 +1,163 @@\n+/*\n+ * Copyright (c) 2025 Måns Ansgariusson <mansgariusson@gmail.com>\n+ *\n+ * SPDX-License-Identifier: Apache-2.0\n+ */\n+\n+#ifndef ZEPHYR_INCLUDE_SYS_FIFO_H_\n+#define ZEPHYR_INCLUDE_SYS_FIFO_H_\...
diff --git a/tests/lib/ringbuffer/prj.conf b/tests/lib/ringbuffer/prj.conf index f66202abb2331..f3ee58bae3a0c 100644 --- a/tests/lib/ringbuffer/prj.conf +++ b/tests/lib/ringbuffer/prj.conf @@ -7,3 +7,6 @@ CONFIG_TEST_RANDOM_GENERATOR=y CONFIG_ENTROPY_GENERATOR=y CONFIG_XOSHIRO_RANDOM_GENERATOR=y CONFIG_MP_MAX_NUM_CP...
true
zephyrproject-rtos/zephyr
107,526
issue_to_patch
testsuite: ztest: benchmark: Fix namespace collisions & remove no-hook macro variants
- Namespace the linker-visible symbols emitted by `ZTEST_BENCHMARK*()` via new `Z_ZTEST_BENCHMARK_*` identifier builders, so identically-named benchmarks in different suites no longer collide. - Drop `ZTEST_BENCHMARK_SETUP_TEARDOWN` / `ZTEST_BENCHMARK_TIMED_SETUP_TEARDOWN` and require `setup_fn` / `teard...
6d04936b1540001089ea7c60e328399f014bc087
a355aea0cb3b656168c311e4919a94506cb13388
diff --git a/doc/releases/migration-guide-4.5.rst b/doc/releases/migration-guide-4.5.rst index 8d8c87a5bd898..7a3ada276ed87 100644 --- a/doc/releases/migration-guide-4.5.rst +++ b/doc/releases/migration-guide-4.5.rst @@ -179,7 +179,6 @@ Other subsystems into ``subsys/mem_mgmt/demand_paging``. Custom backing store an...
[ "doc/develop/test/benchmark.rst", "doc/releases/migration-guide-4.5.rst", "samples/subsys/testsuite/benchmark/src/main.c", "subsys/testsuite/ztest/include/zephyr/benchmark.h" ]
[ { "comment": "Not sure about `Z_ZTEST` feel a bit like double prefixing.", "path": "subsys/testsuite/ztest/include/zephyr/benchmark.h", "hunk": "@@ -15,6 +15,15 @@\n #include <stddef.h>\n \n /** @cond INTERNAL_HIDDEN */\n+/*\n+ * Identifier builders for the linker-visible symbols that the ZTEST_BENCHMAR...
diff --git a/doc/develop/test/benchmark.rst b/doc/develop/test/benchmark.rst index 1508ecca72436..1c550db19fb75 100644 --- a/doc/develop/test/benchmark.rst +++ b/doc/develop/test/benchmark.rst @@ -60,7 +60,7 @@ influenced by external factors such as I/O operations or context switches. ZTEST_BENCHMARK_SUITE(<suite...
true
zephyrproject-rtos/zephyr
107,526
comment_to_fix
testsuite: ztest: benchmark: Fix namespace collisions & remove no-hook macro variants
Not sure about `Z_ZTEST` feel a bit like double prefixing.
6d04936b1540001089ea7c60e328399f014bc087
a355aea0cb3b656168c311e4919a94506cb13388
diff --git a/subsys/testsuite/ztest/include/zephyr/benchmark.h b/subsys/testsuite/ztest/include/zephyr/benchmark.h index 128e1bd66b7d2..5541e69c29255 100644 --- a/subsys/testsuite/ztest/include/zephyr/benchmark.h +++ b/subsys/testsuite/ztest/include/zephyr/benchmark.h @@ -15,6 +15,15 @@ #include <stddef.h> /** @con...
[ "subsys/testsuite/ztest/include/zephyr/benchmark.h" ]
[ { "comment": "Not sure about `Z_ZTEST` feel a bit like double prefixing.", "path": "subsys/testsuite/ztest/include/zephyr/benchmark.h", "hunk": "@@ -15,6 +15,15 @@\n #include <stddef.h>\n \n /** @cond INTERNAL_HIDDEN */\n+/*\n+ * Identifier builders for the linker-visible symbols that the ZTEST_BENCHMAR...
true
zephyrproject-rtos/zephyr
108,847
issue_to_patch
osDelayUntil Implementation Violates CMSIS-RTOS v2 Specification ### Describe the bug The osDelayUntil implementation in subsys/portability/cmsis_rtos_v2/kernel.c does not properly handle wraparound cases and violates the CMSIS-RTOS v2 specification, causing infinite delays when the target tick has already passed. T...
portability: cmsis_rtos_v2: fix osDelayUntil wrap-around
osDelayUntil() previously calculated the sleep duration as k_sleep(K_TICKS(ticks - ticks_elapsed)). When ticks was already in the past(nice find from @joakim-ext-marshall), the unsigned subtraction wrapped around to essentially UINT32_MAX which causes the thread to sleep for effectively K_FOREVER. The agreed solut...
a7464a0211222bb087fd30b40cab8628cbc39720
d68b4424dc794a6f9520dba51de43bc5804d8032
diff --git a/subsys/portability/cmsis_rtos_v2/kernel.c b/subsys/portability/cmsis_rtos_v2/kernel.c index 9f19e89e69fc9..592931d50a42a 100644 --- a/subsys/portability/cmsis_rtos_v2/kernel.c +++ b/subsys/portability/cmsis_rtos_v2/kernel.c @@ -134,14 +134,16 @@ osStatus_t osDelay(uint32_t ticks) */ osStatus_t osDelayUn...
[ "subsys/portability/cmsis_rtos_v2/kernel.c", "tests/subsys/portability/cmsis_rtos_v2/src/kernel.c" ]
[ { "comment": "The within 5 tick is just to give some wiggle room for the tests and different platforms. It is an arbitrary number and not part of any specc as far as I know. ", "path": "tests/subsys/portability/cmsis_rtos_v2/src/kernel.c", "hunk": "@@ -99,5 +99,42 @@ ZTEST(cmsis_kernel, test_delay)\n \n...
diff --git a/tests/subsys/portability/cmsis_rtos_v2/src/kernel.c b/tests/subsys/portability/cmsis_rtos_v2/src/kernel.c index a8cf5a8af6336..fe8f806ef5868 100644 --- a/tests/subsys/portability/cmsis_rtos_v2/src/kernel.c +++ b/tests/subsys/portability/cmsis_rtos_v2/src/kernel.c @@ -99,5 +99,42 @@ ZTEST(cmsis_kernel, test...
true
zephyrproject-rtos/zephyr
109,415
issue_to_patch
sensor: pac194x: fetch optimization and devicetree refresh-mode support
Key Changes - I2C Bus Optimization: Modified the `pac194x_sample_fetch` routine to respect the specific sensor channel. - Devicetree Configuration: Added the microchip,refresh-mode property to the devicetree bindings. This allows board to configure the sensor's refresh behavior directly via the DTS.
f9fcc1bb12bde594aba63828d0cf174c9d8b885f
a718bb02720986179bb80af6655894ad6d7c8b12
diff --git a/drivers/sensor/microchip/pac194x/pac194x.c b/drivers/sensor/microchip/pac194x/pac194x.c index a002c9410b436..18a5bc8fa87af 100644 --- a/drivers/sensor/microchip/pac194x/pac194x.c +++ b/drivers/sensor/microchip/pac194x/pac194x.c @@ -76,6 +76,7 @@ static const struct pac194x_chip_info pac194x_chip_info_table...
[ "drivers/sensor/microchip/pac194x/pac194x.c", "dts/bindings/sensor/microchip,pac194x.yaml", "include/zephyr/dt-bindings/sensor/pac194x.h", "tests/drivers/build_all/sensor/i2c.dtsi" ]
[ { "comment": "I think this starts too look a bit weird, normally I think it's good to keep a `buf, sizeof(buf)` pattern but at this point it may be worth just keep a single buffer (the 8 bytes one) and use it for all transfer, you don't need multiple of these at the same time right?", "path": "drivers/senso...
diff --git a/tests/drivers/build_all/sensor/i2c.dtsi b/tests/drivers/build_all/sensor/i2c.dtsi index 39a89e077aa2e..ec125e11cc186 100644 --- a/tests/drivers/build_all/sensor/i2c.dtsi +++ b/tests/drivers/build_all/sensor/i2c.dtsi @@ -1575,6 +1575,7 @@ test_i2c_pac194x: pac194x@d0 { status = "okay"; #address-cells = ...
true
zephyrproject-rtos/zephyr
109,415
comment_to_fix
sensor: pac194x: fetch optimization and devicetree refresh-mode support
56?!
f9fcc1bb12bde594aba63828d0cf174c9d8b885f
a718bb02720986179bb80af6655894ad6d7c8b12
diff --git a/drivers/sensor/microchip/pac194x/pac194x.c b/drivers/sensor/microchip/pac194x/pac194x.c index a002c9410b436..18a5bc8fa87af 100644 --- a/drivers/sensor/microchip/pac194x/pac194x.c +++ b/drivers/sensor/microchip/pac194x/pac194x.c @@ -76,6 +76,7 @@ static const struct pac194x_chip_info pac194x_chip_info_table...
[ "drivers/sensor/microchip/pac194x/pac194x.c" ]
[ { "comment": "56?!", "path": "drivers/sensor/microchip/pac194x/pac194x.c", "hunk": "@@ -152,11 +188,58 @@ static int pac194x_cmd_refresh_all(const struct device *dev)\n \treturn 0;\n }\n \n-static int pac194x_sample_fetch(const struct device *dev, enum sensor_channel chan)\n+static int pac194x_read_16(c...
true
zephyrproject-rtos/zephyr
109,415
comment_to_fix
sensor: pac194x: fetch optimization and devicetree refresh-mode support
Need to explain in the description why the default value was selected https://docs.zephyrproject.org/latest/build/dts/bindings-upstream.html#dt-bindings-default-rules
f9fcc1bb12bde594aba63828d0cf174c9d8b885f
a718bb02720986179bb80af6655894ad6d7c8b12
diff --git a/dts/bindings/sensor/microchip,pac194x.yaml b/dts/bindings/sensor/microchip,pac194x.yaml index 23a0fe4f14d4a..ef811a5c782a6 100644 --- a/dts/bindings/sensor/microchip,pac194x.yaml +++ b/dts/bindings/sensor/microchip,pac194x.yaml @@ -11,6 +11,18 @@ compatible: "microchip,pac194x" include: [sensor-device.y...
[ "dts/bindings/sensor/microchip,pac194x.yaml" ]
[ { "comment": "Need to explain in the description why the default value was selected\nhttps://docs.zephyrproject.org/latest/build/dts/bindings-upstream.html#dt-bindings-default-rules", "path": "dts/bindings/sensor/microchip,pac194x.yaml", "hunk": "@@ -11,6 +11,16 @@ compatible: \"microchip,pac194x\"\n \n...
true
zephyrproject-rtos/zephyr
111,185
issue_to_patch
drivers: ethernet: Add missing iface arg Cyclone V Ethernet
Adds the missing network interface arg for stop/start functions. Fixes issue in weekly CI run: https://github.com/zephyrproject-rtos/zephyr/actions/runs/27081113681/job/79927021115#step:14:4930
8e33acdc8107a02e6e8f844c839cc5e4b54c7037
31ef634f1c3067fd87fa49e5684cf62333ab8702
diff --git a/drivers/ethernet/eth_cyclonev.c b/drivers/ethernet/eth_cyclonev.c index af8a31683a267..33e5779ae1399 100644 --- a/drivers/ethernet/eth_cyclonev.c +++ b/drivers/ethernet/eth_cyclonev.c @@ -617,7 +617,7 @@ void eth_cyclonev_isr(const struct device *dev) cfg_reg_set = sys_read32(GMACGRP_MAC_CONFIG_ADDR(...
[ "drivers/ethernet/eth_cyclonev.c" ]
[]
true
zephyrproject-rtos/zephyr
110,965
issue_to_patch
doc: audio: dmic: document the DMIC shell commands
Document the `dmic` shell commands (`read`, `vu`, `dump`) as well as CONFIG_AUDIO_DMIC_SHELL Kconfig option. https://builds.zephyrproject.io/zephyr/pr/110965/docs/hardware/peripherals/audio/dmic.html#shell-commands @rgallaispouSTM @mariopaja
8cb75f4fbdde883e8020929c0c9a5b1db1a4bd4c
f0a6863db2f1f67a0af3a6d468eaf05dbdc18bdc
diff --git a/doc/hardware/peripherals/audio/dmic.rst b/doc/hardware/peripherals/audio/dmic.rst index 20b799d31e74f..7395e9f2fd996 100644 --- a/doc/hardware/peripherals/audio/dmic.rst +++ b/doc/hardware/peripherals/audio/dmic.rst @@ -80,12 +80,39 @@ A common pattern is to declare this slab statically: In this example, ...
[ "doc/hardware/peripherals/audio/dmic.rst" ]
[ { "comment": "Could you document the default values for `seconds` and `count` ? So that users know what to expect.", "path": "doc/hardware/peripherals/audio/dmic.rst", "hunk": "@@ -80,12 +80,38 @@ A common pattern is to declare this slab statically:\n In this example, each slab block stores one PCM buf...
true
zephyrproject-rtos/zephyr
110,489
issue_to_patch
include: drivers: sensor: enhance Doxygen documentation for LSM6DSVXXX
Document self-test result enum and cross-reference it from the extended sensor attribute.
ad056d5454d57002c2b330b301d1e9906dd5fd0f
9c14f921a27dc76a7e4fafc6b161ecfc4ce8bba7
diff --git a/include/zephyr/drivers/sensor/lsm6dsvxxx.h b/include/zephyr/drivers/sensor/lsm6dsvxxx.h index effbe2bc64eed..be67ed62629de 100644 --- a/include/zephyr/drivers/sensor/lsm6dsvxxx.h +++ b/include/zephyr/drivers/sensor/lsm6dsvxxx.h @@ -27,14 +27,17 @@ */ enum sensor_attribute_lsm6dsvxxx { /** - * Gets th...
[ "include/zephyr/drivers/sensor/lsm6dsvxxx.h" ]
[]
true
zephyrproject-rtos/zephyr
109,310
issue_to_patch
tests: drivers/comparator/gpio_loopback: Add FRDM-iMXRT1186
Add FRDM-iMXRT1186 (CM33 and CM7) support to the comparator `gpio_loopback` test, exercising ACMP3 through the Zephyr comparator driver model (`CONFIG_COMPARATOR_MCUX_ACMP`). ACMP3 IN2 is on `GPIO_AD_29` (Arduino header **J2-5**, via jumper `J29` in the 2-3 position); the loopback is driven by `GPIO_AD_17` (gpio4 IO17...
b02731645bdf63e897e34219bf8883ad320b2d08
6ca99eecd4ecd96ddba0c939b91a4160e2512749
[ "tests/drivers/comparator/gpio_loopback/boards/frdm_imxrt1186_mimxrt1186_cm33.overlay", "tests/drivers/comparator/gpio_loopback/boards/frdm_imxrt1186_mimxrt1186_cm7.overlay", "tests/drivers/comparator/gpio_loopback/testcase.yaml" ]
[]
diff --git a/tests/drivers/comparator/gpio_loopback/boards/frdm_imxrt1186_mimxrt1186_cm33.overlay b/tests/drivers/comparator/gpio_loopback/boards/frdm_imxrt1186_mimxrt1186_cm33.overlay new file mode 100644 index 0000000000000..da96d7d51e26b --- /dev/null +++ b/tests/drivers/comparator/gpio_loopback/boards/frdm_imxrt118...
true
zephyrproject-rtos/zephyr
108,547
issue_to_patch
boards: shields: st87mxx update
Updated documentation to give more information regarding the EVKITST87M01 board for the ST87M01. https://builds.zephyrproject.io/zephyr/pr/108547/docs/boards/shields/st87mxx/doc/index.html Signed-off-by: Isabelle OGER isabelle.oger@st.com
d2f8e308bdc427c15ffbc3f442d231f6ea8ab6b4
5c2ae7c4da9ef66271eb88d14917392bcb86bbd1
diff --git a/boards/shields/st87mxx/doc/EVKITST87M01-1.webp b/boards/shields/st87mxx/doc/EVKITST87M01-1.webp deleted file mode 100644 index 2bd710cdfb579..0000000000000 Binary files a/boards/shields/st87mxx/doc/EVKITST87M01-1.webp and /dev/null differ diff --git a/boards/shields/st87mxx/doc/EVKITST87M01-2.webp b/boards...
[ "boards/shields/st87mxx/doc/EVKITST87M01-1.webp", "boards/shields/st87mxx/doc/EVKITST87M01-2.webp", "boards/shields/st87mxx/doc/index.rst", "boards/shields/st87mxx/st87mxx.conf" ]
[ { "comment": "Please add copyright + license", "path": "boards/shields/st87mxx/st87mxx.conf", "hunk": "@@ -0,0 +1,3 @@\n+# Modem subsystem\n+CONFIG_MODEM=y\n+CONFIG_MODEM_ST87MXX=y", "resolving_sha": "5c2ae7c4da9ef66271eb88d14917392bcb86bbd1", "resolving_diff": "diff --git a/boards/shields/st87m...
true
zephyrproject-rtos/zephyr
108,547
comment_to_fix
boards: shields: st87mxx update
Please add copyright + license
d2f8e308bdc427c15ffbc3f442d231f6ea8ab6b4
5c2ae7c4da9ef66271eb88d14917392bcb86bbd1
diff --git a/boards/shields/st87mxx/st87mxx.conf b/boards/shields/st87mxx/st87mxx.conf new file mode 100644 index 0000000000000..5083fda2bb4f7 --- /dev/null +++ b/boards/shields/st87mxx/st87mxx.conf @@ -0,0 +1,6 @@ +# Copyright (c) 2026 STMicroelectronics +# SPDX-License-Identifier: Apache-2.0 + +# Modem subsystem +CON...
[ "boards/shields/st87mxx/st87mxx.conf" ]
[ { "comment": "Please add copyright + license", "path": "boards/shields/st87mxx/st87mxx.conf", "hunk": "@@ -0,0 +1,3 @@\n+# Modem subsystem\n+CONFIG_MODEM=y\n+CONFIG_MODEM_ST87MXX=y", "resolving_sha": "5c2ae7c4da9ef66271eb88d14917392bcb86bbd1", "resolving_diff": "diff --git a/boards/shields/st87m...
true
zephyrproject-rtos/zephyr
108,547
comment_to_fix
boards: shields: st87mxx update
Redirect to another product supporting as well GNSS/Wifi. From what I understand, both modules are compatible with provided MODEM_ST87MXX implementation. But in the end these are two different shields. GNSS/WIFI part of this module will probably end up being supported (as recently added TESEO Support: https://github.co...
d2f8e308bdc427c15ffbc3f442d231f6ea8ab6b4
5c2ae7c4da9ef66271eb88d14917392bcb86bbd1
diff --git a/boards/shields/st87mxx/doc/index.rst b/boards/shields/st87mxx/doc/index.rst index 4654869c0744d..4525bea3ea7fa 100644 --- a/boards/shields/st87mxx/doc/index.rst +++ b/boards/shields/st87mxx/doc/index.rst @@ -6,17 +6,47 @@ ST87MXX shield Overview ******** +The EVKITST87M01 is an evaluation board for the...
[ "boards/shields/st87mxx/doc/index.rst" ]
[ { "comment": "Redirect to another product supporting as well GNSS/Wifi.\nFrom what I understand, both modules are compatible with provided MODEM_ST87MXX implementation. But in the end these are two different shields.\nGNSS/WIFI part of this module will probably end up being supported (as recently added TESEO Su...
true
zephyrproject-rtos/zephyr
106,672
issue_to_patch
drivers: watchdog: add Realtek Ameba series support
This PR adds the watchdog driver support for Realtek Ameba series SoCs.
f9fcc1bb12bde594aba63828d0cf174c9d8b885f
31ce4cc8333b7a8abe4ba77c77a10dec4b3f995e
diff --git a/drivers/watchdog/CMakeLists.txt b/drivers/watchdog/CMakeLists.txt index 8a6719e1cacf3..a613d9aa82f5a 100644 --- a/drivers/watchdog/CMakeLists.txt +++ b/drivers/watchdog/CMakeLists.txt @@ -12,6 +12,7 @@ zephyr_library_sources_ifdef(CONFIG_USERSPACE wdt_handlers.c) zephyr_library_sources_ifdef(CONFIG_WDOG_C...
[ "drivers/watchdog/CMakeLists.txt", "drivers/watchdog/Kconfig", "drivers/watchdog/Kconfig.ameba", "drivers/watchdog/wdt_ameba.c", "dts/arm/realtek/amebad/amebad.dtsi", "dts/arm/realtek/amebadplus/amebadplus.dtsi", "dts/arm/realtek/amebag2/amebag2.dtsi", "dts/bindings/watchdog/realtek,ameba-watchdog.yam...
[ { "comment": "Add a trailing comma so formatting looks nicer\r\n\r\n```suggestion\r\nstatic DEVICE_API(wdt, wdt_api) = {\r\n\t.setup = wdt_ameba_setup,\r\n\t.disable = wdt_ameba_disable,\r\n\t.install_timeout = wdt_ameba_install_timeout,\r\n\t.feed = wdt_ameba_feed,\r\n};\r\n```", "path": "drivers/watchdog/...
true
zephyrproject-rtos/zephyr
106,672
comment_to_fix
drivers: watchdog: add Realtek Ameba series support
Add a trailing comma so formatting looks nicer ```suggestion static DEVICE_API(wdt, wdt_api) = { .setup = wdt_ameba_setup, .disable = wdt_ameba_disable, .install_timeout = wdt_ameba_install_timeout, .feed = wdt_ameba_feed, }; ```
f9fcc1bb12bde594aba63828d0cf174c9d8b885f
31ce4cc8333b7a8abe4ba77c77a10dec4b3f995e
diff --git a/drivers/watchdog/wdt_ameba.c b/drivers/watchdog/wdt_ameba.c new file mode 100644 index 0000000000000..562b8ebb47706 --- /dev/null +++ b/drivers/watchdog/wdt_ameba.c @@ -0,0 +1,185 @@ +/* + * Copyright (c) 2026 Realtek Semiconductor Corp. + * + * SPDX-License-Identifier: Apache-2.0 + */ + +#define DT_DRV_CO...
[ "drivers/watchdog/wdt_ameba.c" ]
[ { "comment": "Add a trailing comma so formatting looks nicer\r\n\r\n```suggestion\r\nstatic DEVICE_API(wdt, wdt_api) = {\r\n\t.setup = wdt_ameba_setup,\r\n\t.disable = wdt_ameba_disable,\r\n\t.install_timeout = wdt_ameba_install_timeout,\r\n\t.feed = wdt_ameba_feed,\r\n};\r\n```", "path": "drivers/watchdog/...
true
zephyrproject-rtos/zephyr
106,672
comment_to_fix
drivers: watchdog: add Realtek Ameba series support
Prefer explicit NULL checks. ```suggestion if (cb != NULL) { ```
f9fcc1bb12bde594aba63828d0cf174c9d8b885f
31ce4cc8333b7a8abe4ba77c77a10dec4b3f995e
diff --git a/drivers/watchdog/wdt_ameba.c b/drivers/watchdog/wdt_ameba.c new file mode 100644 index 0000000000000..562b8ebb47706 --- /dev/null +++ b/drivers/watchdog/wdt_ameba.c @@ -0,0 +1,185 @@ +/* + * Copyright (c) 2026 Realtek Semiconductor Corp. + * + * SPDX-License-Identifier: Apache-2.0 + */ + +#define DT_DRV_CO...
[ "drivers/watchdog/wdt_ameba.c" ]
[ { "comment": "Prefer explicit NULL checks.\r\n\r\n```suggestion\r\n\tif (cb != NULL) {\r\n```", "path": "drivers/watchdog/wdt_ameba.c", "hunk": "@@ -0,0 +1,139 @@\n+/*\n+ * Copyright (c) 2026 Realtek Semiconductor Corp.\n+ *\n+ * SPDX-License-Identifier: Apache-2.0\n+ */\n+\n+#define DT_DRV_COMPAT realt...
true
zephyrproject-rtos/zephyr
106,672
comment_to_fix
drivers: watchdog: add Realtek Ameba series support
ARG_UNUSED(options);
f9fcc1bb12bde594aba63828d0cf174c9d8b885f
31ce4cc8333b7a8abe4ba77c77a10dec4b3f995e
diff --git a/drivers/watchdog/wdt_ameba.c b/drivers/watchdog/wdt_ameba.c new file mode 100644 index 0000000000000..562b8ebb47706 --- /dev/null +++ b/drivers/watchdog/wdt_ameba.c @@ -0,0 +1,185 @@ +/* + * Copyright (c) 2026 Realtek Semiconductor Corp. + * + * SPDX-License-Identifier: Apache-2.0 + */ + +#define DT_DRV_CO...
[ "drivers/watchdog/wdt_ameba.c" ]
[ { "comment": "ARG_UNUSED(options);", "path": "drivers/watchdog/wdt_ameba.c", "hunk": "@@ -0,0 +1,141 @@\n+/*\n+ * Copyright (c) 2026 Realtek Semiconductor Corp.\n+ *\n+ * SPDX-License-Identifier: Apache-2.0\n+ */\n+\n+#define DT_DRV_COMPAT realtek_ameba_watchdog\n+\n+/* Include <soc.h> before <ameba_soc...
true
zephyrproject-rtos/zephyr
106,672
comment_to_fix
drivers: watchdog: add Realtek Ameba series support
Seems not used.
f9fcc1bb12bde594aba63828d0cf174c9d8b885f
31ce4cc8333b7a8abe4ba77c77a10dec4b3f995e
diff --git a/drivers/watchdog/wdt_ameba.c b/drivers/watchdog/wdt_ameba.c new file mode 100644 index 0000000000000..562b8ebb47706 --- /dev/null +++ b/drivers/watchdog/wdt_ameba.c @@ -0,0 +1,185 @@ +/* + * Copyright (c) 2026 Realtek Semiconductor Corp. + * + * SPDX-License-Identifier: Apache-2.0 + */ + +#define DT_DRV_CO...
[ "drivers/watchdog/wdt_ameba.c" ]
[ { "comment": "Seems not used.", "path": "drivers/watchdog/wdt_ameba.c", "hunk": "@@ -0,0 +1,141 @@\n+/*\n+ * Copyright (c) 2026 Realtek Semiconductor Corp.\n+ *\n+ * SPDX-License-Identifier: Apache-2.0\n+ */\n+\n+#define DT_DRV_COMPAT realtek_ameba_watchdog\n+\n+/* Include <soc.h> before <ameba_soc.h> t...
true
zephyrproject-rtos/zephyr
106,672
comment_to_fix
drivers: watchdog: add Realtek Ameba series support
Where the variable used?
f9fcc1bb12bde594aba63828d0cf174c9d8b885f
31ce4cc8333b7a8abe4ba77c77a10dec4b3f995e
diff --git a/drivers/watchdog/wdt_ameba.c b/drivers/watchdog/wdt_ameba.c new file mode 100644 index 0000000000000..562b8ebb47706 --- /dev/null +++ b/drivers/watchdog/wdt_ameba.c @@ -0,0 +1,185 @@ +/* + * Copyright (c) 2026 Realtek Semiconductor Corp. + * + * SPDX-License-Identifier: Apache-2.0 + */ + +#define DT_DRV_CO...
[ "drivers/watchdog/wdt_ameba.c" ]
[ { "comment": "Where the variable used?", "path": "drivers/watchdog/wdt_ameba.c", "hunk": "@@ -0,0 +1,141 @@\n+/*\n+ * Copyright (c) 2026 Realtek Semiconductor Corp.\n+ *\n+ * SPDX-License-Identifier: Apache-2.0\n+ */\n+\n+#define DT_DRV_COMPAT realtek_ameba_watchdog\n+\n+/* Include <soc.h> before <ameba...
true
zephyrproject-rtos/zephyr
106,672
comment_to_fix
drivers: watchdog: add Realtek Ameba series support
Redundant "\n". And `EINVAL` is more appropriate here.
f9fcc1bb12bde594aba63828d0cf174c9d8b885f
31ce4cc8333b7a8abe4ba77c77a10dec4b3f995e
diff --git a/drivers/watchdog/wdt_ameba.c b/drivers/watchdog/wdt_ameba.c new file mode 100644 index 0000000000000..562b8ebb47706 --- /dev/null +++ b/drivers/watchdog/wdt_ameba.c @@ -0,0 +1,185 @@ +/* + * Copyright (c) 2026 Realtek Semiconductor Corp. + * + * SPDX-License-Identifier: Apache-2.0 + */ + +#define DT_DRV_CO...
[ "drivers/watchdog/wdt_ameba.c" ]
[ { "comment": "Redundant \"\\n\". And `EINVAL` is more appropriate here.", "path": "drivers/watchdog/wdt_ameba.c", "hunk": "@@ -0,0 +1,141 @@\n+/*\n+ * Copyright (c) 2026 Realtek Semiconductor Corp.\n+ *\n+ * SPDX-License-Identifier: Apache-2.0\n+ */\n+\n+#define DT_DRV_COMPAT realtek_ameba_watchdog\n+\n...
true
zephyrproject-rtos/zephyr
106,672
comment_to_fix
drivers: watchdog: add Realtek Ameba series support
Is it a typo? the size is 0x20 in other dts.
f9fcc1bb12bde594aba63828d0cf174c9d8b885f
31ce4cc8333b7a8abe4ba77c77a10dec4b3f995e
diff --git a/dts/arm/realtek/amebad/amebad.dtsi b/dts/arm/realtek/amebad/amebad.dtsi index 0ebed2da67fba..fbc58a570a7dc 100644 --- a/dts/arm/realtek/amebad/amebad.dtsi +++ b/dts/arm/realtek/amebad/amebad.dtsi @@ -61,6 +61,14 @@ status = "disabled"; }; + wdg: watchdog@40002800 { + compatible = "realtek,ameba...
[ "dts/arm/realtek/amebad/amebad.dtsi" ]
[ { "comment": "Is it a typo? the size is 0x20 in other dts.", "path": "dts/arm/realtek/amebad/amebad.dtsi", "hunk": "@@ -53,6 +53,14 @@\n \t\t\tzephyr,memory-region = \"KM4_IMG2_ENTRY\";\n \t\t};\n \n+\t\twdg: watchdog@40002800 {\n+\t\t\tcompatible = \"realtek,ameba-watchdog\";\n+\t\t\treg = <0x40002800 ...
true
zephyrproject-rtos/zephyr
106,672
comment_to_fix
drivers: watchdog: add Realtek Ameba series support
```suggestion interrupts: required: true ```
f9fcc1bb12bde594aba63828d0cf174c9d8b885f
31ce4cc8333b7a8abe4ba77c77a10dec4b3f995e
diff --git a/dts/bindings/watchdog/realtek,ameba-watchdog.yaml b/dts/bindings/watchdog/realtek,ameba-watchdog.yaml new file mode 100644 index 0000000000000..9af1c9089004f --- /dev/null +++ b/dts/bindings/watchdog/realtek,ameba-watchdog.yaml @@ -0,0 +1,33 @@ +# Copyright (c) 2026 Realtek Semiconductor Corp. +# SPDX-Lice...
[ "dts/bindings/watchdog/realtek,ameba-watchdog.yaml" ]
[ { "comment": "\n```suggestion\n\n interrupts:\n required: true\n\n```", "path": "dts/bindings/watchdog/realtek,ameba-watchdog.yaml", "hunk": "@@ -0,0 +1,19 @@\n+# Copyright (c) 2026 Realtek Semiconductor Corp.\n+# SPDX-License-Identifier: Apache-2.0\n+\n+description: Ameba watchdog\n+\n+compatible: ...
true
zephyrproject-rtos/zephyr
106,672
comment_to_fix
drivers: watchdog: add Realtek Ameba series support
As it will return EINVAL when min window equals 0, data->window is always same with data->timeout.
f9fcc1bb12bde594aba63828d0cf174c9d8b885f
31ce4cc8333b7a8abe4ba77c77a10dec4b3f995e
diff --git a/drivers/watchdog/wdt_ameba.c b/drivers/watchdog/wdt_ameba.c new file mode 100644 index 0000000000000..562b8ebb47706 --- /dev/null +++ b/drivers/watchdog/wdt_ameba.c @@ -0,0 +1,185 @@ +/* + * Copyright (c) 2026 Realtek Semiconductor Corp. + * + * SPDX-License-Identifier: Apache-2.0 + */ + +#define DT_DRV_CO...
[ "drivers/watchdog/wdt_ameba.c" ]
[ { "comment": "As it will return EINVAL when min window equals 0, data->window is always same with data->timeout.", "path": "drivers/watchdog/wdt_ameba.c", "hunk": "@@ -0,0 +1,172 @@\n+/*\n+ * Copyright (c) 2026 Realtek Semiconductor Corp.\n+ *\n+ * SPDX-License-Identifier: Apache-2.0\n+ */\n+\n+#define ...
true
zephyrproject-rtos/zephyr
106,672
comment_to_fix
drivers: watchdog: add Realtek Ameba series support
It's a little tricky here. You can check whether it's IWDT and set data->started in wdt_ameba_init
f9fcc1bb12bde594aba63828d0cf174c9d8b885f
31ce4cc8333b7a8abe4ba77c77a10dec4b3f995e
diff --git a/drivers/watchdog/wdt_ameba.c b/drivers/watchdog/wdt_ameba.c new file mode 100644 index 0000000000000..562b8ebb47706 --- /dev/null +++ b/drivers/watchdog/wdt_ameba.c @@ -0,0 +1,185 @@ +/* + * Copyright (c) 2026 Realtek Semiconductor Corp. + * + * SPDX-License-Identifier: Apache-2.0 + */ + +#define DT_DRV_CO...
[ "drivers/watchdog/wdt_ameba.c" ]
[ { "comment": "It's a little tricky here. You can check whether it's IWDT and set data->started in wdt_ameba_init", "path": "drivers/watchdog/wdt_ameba.c", "hunk": "@@ -0,0 +1,172 @@\n+/*\n+ * Copyright (c) 2026 Realtek Semiconductor Corp.\n+ *\n+ * SPDX-License-Identifier: Apache-2.0\n+ */\n+\n+#define ...
true
zephyrproject-rtos/zephyr
106,672
comment_to_fix
drivers: watchdog: add Realtek Ameba series support
See [wdt_setup()](https://docs.zephyrproject.org/latest/doxygen/html/group__watchdog__interface.html#ga822239f3d73585e2d01312657dbbb782) It shall return `-ENOTSUP` If any of the set options is not supported.
f9fcc1bb12bde594aba63828d0cf174c9d8b885f
31ce4cc8333b7a8abe4ba77c77a10dec4b3f995e
diff --git a/drivers/watchdog/wdt_ameba.c b/drivers/watchdog/wdt_ameba.c new file mode 100644 index 0000000000000..562b8ebb47706 --- /dev/null +++ b/drivers/watchdog/wdt_ameba.c @@ -0,0 +1,185 @@ +/* + * Copyright (c) 2026 Realtek Semiconductor Corp. + * + * SPDX-License-Identifier: Apache-2.0 + */ + +#define DT_DRV_CO...
[ "drivers/watchdog/wdt_ameba.c" ]
[ { "comment": "See [wdt_setup()](https://docs.zephyrproject.org/latest/doxygen/html/group__watchdog__interface.html#ga822239f3d73585e2d01312657dbbb782)\nIt shall return `-ENOTSUP` If any of the set options is not supported.\n", "path": "drivers/watchdog/wdt_ameba.c", "hunk": "@@ -0,0 +1,172 @@\n+/*\n+ *...
true
zephyrproject-rtos/zephyr
106,672
comment_to_fix
drivers: watchdog: add Realtek Ameba series support
It looks a little confusing as you have `WDG_Init`, `WDG_Enable`, `WDG_Refresh`....
f9fcc1bb12bde594aba63828d0cf174c9d8b885f
31ce4cc8333b7a8abe4ba77c77a10dec4b3f995e
diff --git a/drivers/watchdog/wdt_ameba.c b/drivers/watchdog/wdt_ameba.c new file mode 100644 index 0000000000000..562b8ebb47706 --- /dev/null +++ b/drivers/watchdog/wdt_ameba.c @@ -0,0 +1,185 @@ +/* + * Copyright (c) 2026 Realtek Semiconductor Corp. + * + * SPDX-License-Identifier: Apache-2.0 + */ + +#define DT_DRV_CO...
[ "drivers/watchdog/wdt_ameba.c" ]
[ { "comment": "It looks a little confusing as you have `WDG_Init`, `WDG_Enable`, `WDG_Refresh`....", "path": "drivers/watchdog/wdt_ameba.c", "hunk": "@@ -0,0 +1,172 @@\n+/*\n+ * Copyright (c) 2026 Realtek Semiconductor Corp.\n+ *\n+ * SPDX-License-Identifier: Apache-2.0\n+ */\n+\n+#define DT_DRV_COMPAT r...
true
zephyrproject-rtos/zephyr
106,672
comment_to_fix
drivers: watchdog: add Realtek Ameba series support
```suggestion early-int-cnt-ms: ```
f9fcc1bb12bde594aba63828d0cf174c9d8b885f
31ce4cc8333b7a8abe4ba77c77a10dec4b3f995e
diff --git a/dts/bindings/watchdog/realtek,ameba-watchdog.yaml b/dts/bindings/watchdog/realtek,ameba-watchdog.yaml new file mode 100644 index 0000000000000..9af1c9089004f --- /dev/null +++ b/dts/bindings/watchdog/realtek,ameba-watchdog.yaml @@ -0,0 +1,33 @@ +# Copyright (c) 2026 Realtek Semiconductor Corp. +# SPDX-Lice...
[ "dts/bindings/watchdog/realtek,ameba-watchdog.yaml" ]
[ { "comment": "```suggestion\n early-int-cnt-ms:\n```", "path": "dts/bindings/watchdog/realtek,ameba-watchdog.yaml", "hunk": "@@ -0,0 +1,25 @@\n+# Copyright (c) 2026 Realtek Semiconductor Corp.\n+# SPDX-License-Identifier: Apache-2.0\n+\n+description: Ameba watchdog\n+\n+compatible: \"realtek,ameba-watc...
true
zephyrproject-rtos/zephyr
106,672
comment_to_fix
drivers: watchdog: add Realtek Ameba series support
```suggestion return -ENOTSUP; ```
f9fcc1bb12bde594aba63828d0cf174c9d8b885f
31ce4cc8333b7a8abe4ba77c77a10dec4b3f995e
diff --git a/drivers/watchdog/wdt_ameba.c b/drivers/watchdog/wdt_ameba.c new file mode 100644 index 0000000000000..562b8ebb47706 --- /dev/null +++ b/drivers/watchdog/wdt_ameba.c @@ -0,0 +1,185 @@ +/* + * Copyright (c) 2026 Realtek Semiconductor Corp. + * + * SPDX-License-Identifier: Apache-2.0 + */ + +#define DT_DRV_CO...
[ "drivers/watchdog/wdt_ameba.c" ]
[ { "comment": "```suggestion\n\treturn -ENOTSUP;\n```", "path": "drivers/watchdog/wdt_ameba.c", "hunk": "@@ -0,0 +1,185 @@\n+/*\n+ * Copyright (c) 2026 Realtek Semiconductor Corp.\n+ *\n+ * SPDX-License-Identifier: Apache-2.0\n+ */\n+\n+#define DT_DRV_COMPAT realtek_ameba_watchdog\n+\n+/* Include <soc.h>...
true
zephyrproject-rtos/zephyr
106,672
comment_to_fix
drivers: watchdog: add Realtek Ameba series support
As mentioned in document url above: > There is no need to document the default value itself; this is already present in the [Bindings index](https://docs.zephyrproject.org/latest/build/dts/api/bindings.html#devicetree-binding-index) output.
f9fcc1bb12bde594aba63828d0cf174c9d8b885f
31ce4cc8333b7a8abe4ba77c77a10dec4b3f995e
diff --git a/dts/bindings/watchdog/realtek,ameba-watchdog.yaml b/dts/bindings/watchdog/realtek,ameba-watchdog.yaml new file mode 100644 index 0000000000000..9af1c9089004f --- /dev/null +++ b/dts/bindings/watchdog/realtek,ameba-watchdog.yaml @@ -0,0 +1,33 @@ +# Copyright (c) 2026 Realtek Semiconductor Corp. +# SPDX-Lice...
[ "dts/bindings/watchdog/realtek,ameba-watchdog.yaml" ]
[ { "comment": "As mentioned in document url above:\n> There is no need to document the default value itself; this is already present in the [Bindings index](https://docs.zephyrproject.org/latest/build/dts/api/bindings.html#devicetree-binding-index) output.", "path": "dts/bindings/watchdog/realtek,ameba-watch...
true
zephyrproject-rtos/zephyr
106,672
comment_to_fix
drivers: watchdog: add Realtek Ameba series support
We now have `min`/`max` in the spec. ```suggestion default: 500 min: 1 max: 65535 description: | Watchdog early interrupt trigger threshold in milliseconds. The early interrupt fires this many milliseconds before the watchdog reset, giving firmware time to perform recovery or...
f9fcc1bb12bde594aba63828d0cf174c9d8b885f
31ce4cc8333b7a8abe4ba77c77a10dec4b3f995e
diff --git a/dts/bindings/watchdog/realtek,ameba-watchdog.yaml b/dts/bindings/watchdog/realtek,ameba-watchdog.yaml new file mode 100644 index 0000000000000..9af1c9089004f --- /dev/null +++ b/dts/bindings/watchdog/realtek,ameba-watchdog.yaml @@ -0,0 +1,33 @@ +# Copyright (c) 2026 Realtek Semiconductor Corp. +# SPDX-Lice...
[ "dts/bindings/watchdog/realtek,ameba-watchdog.yaml" ]
[ { "comment": "We now have `min`/`max` in the spec.\r\n\r\n```suggestion\r\n default: 500\r\n min: 1\r\n max: 65535\r\n description: |\r\n Watchdog early interrupt trigger threshold in milliseconds.\r\n The early interrupt fires this many milliseconds before the watchdog\r\n reset, giv...
true
zephyrproject-rtos/zephyr
111,198
issue_to_patch
release: Zephyr 4.3.1-rc1
Update the version to 4.3.1-rc1. Fixes #111199
c95a3b1533d9f9377abbf6cd78fa3929c761eaee
246282adfe36de9274fa448f5c638767c769b2c0
diff --git a/VERSION b/VERSION index 069dda3e4fbc2..c8e7badb424ee 100644 --- a/VERSION +++ b/VERSION @@ -1,5 +1,5 @@ VERSION_MAJOR = 4 VERSION_MINOR = 3 -PATCHLEVEL = 0 +PATCHLEVEL = 1 VERSION_TWEAK = 0 -EXTRAVERSION = +EXTRAVERSION = rc1
[ "VERSION" ]
[]
true
zephyrproject-rtos/zephyr
110,924
issue_to_patch
Bluetooth: BAP: SD: Fix log of wrong err value
The `err` variable was overwritten by the k_mutex functions before being logged, so it did not log the actual error.
f18c5499b717fce02399ae5102781ac013200598
0ac8a8c7f9d29ab4bef062a5793614c488f51f1d
diff --git a/subsys/bluetooth/audio/bap_scan_delegator.c b/subsys/bluetooth/audio/bap_scan_delegator.c index 076e3f3670001..5c698d06fd9aa 100644 --- a/subsys/bluetooth/audio/bap_scan_delegator.c +++ b/subsys/bluetooth/audio/bap_scan_delegator.c @@ -1005,6 +1005,9 @@ static int scan_delegator_mod_src(struct bt_conn *con...
[ "subsys/bluetooth/audio/bap_scan_delegator.c" ]
[]
true
zephyrproject-rtos/zephyr
110,925
issue_to_patch
Bluetooth: BAP: Fix bad releasing state checks
The relasing state can go to IDLE or CODEC_CONFIGURED but was defined to only allow IDLE or QOS_CONFIGURED.
f18c5499b717fce02399ae5102781ac013200598
04bf446bc801952f549f3bf8fc1f61c7fc6573f8
diff --git a/subsys/bluetooth/audio/bap_stream.c b/subsys/bluetooth/audio/bap_stream.c index 9af98ef4c943a..03dc7bb7daf0b 100644 --- a/subsys/bluetooth/audio/bap_stream.c +++ b/subsys/bluetooth/audio/bap_stream.c @@ -932,7 +932,7 @@ static bool valid_snk_state_transition(enum bt_bap_ep_state old_state, case BT_BAP_EP...
[ "subsys/bluetooth/audio/bap_stream.c" ]
[]
true
zephyrproject-rtos/zephyr
110,980
issue_to_patch
soc: adi: max32: Fix resume from standby when using RTC
When resuming from standby using the MAX32 RTC peripheral, we still need a small delay to ensure the RTC is ready for interaction, so restore that delay, but now conditionally.
53c0280c6a3792b99f8cb6dbaa6ce96431225591
4496e9c97f59d6166cf5a6fa00925ed583f962a6
diff --git a/soc/adi/max32/power.c b/soc/adi/max32/power.c index b5ed4cac5032a..1c0c8945773c6 100644 --- a/soc/adi/max32/power.c +++ b/soc/adi/max32/power.c @@ -115,6 +115,12 @@ void pm_state_exit_post_ops(enum pm_state state, uint8_t substate_id) #endif /* CONFIG_PM_S2RAM */ break; case PM_STATE_STANDBY: +#if DT...
[ "soc/adi/max32/power.c" ]
[]
true
zephyrproject-rtos/zephyr
110,964
issue_to_patch
west: runners: openocd: Use POSIX-style paths for log files
OpenOCD cannot handle Windows-style backslash paths, so switch to POSIX-style paths for log file handling., ``` runners.openocd: INFO: OpenOCD log file: C:\Proj\Zephyr\zephyrproject\zephyr\build\openocd.log runners.openocd: INFO: Flashing file: C:/Proj/Zephyr/zephyrproject/zephyr/build/zephyr/zephyr.hex Open On-C...
ef5cfd369f4a0ab3601db9a23c1da8c406cc1a72
854f4ee3852ea9269eedefb23c1efc66649f9d7f
diff --git a/scripts/west_commands/runners/openocd.py b/scripts/west_commands/runners/openocd.py index 0f5612adf0704..c405dbc428f0f 100644 --- a/scripts/west_commands/runners/openocd.py +++ b/scripts/west_commands/runners/openocd.py @@ -131,7 +131,7 @@ def __init__(self, cfg, pre_init=None, pre_init_flash=None, ...
[ "scripts/west_commands/runners/openocd.py" ]
[ { "comment": "`str` sounds redundant in here, please check.", "path": "scripts/west_commands/runners/openocd.py", "hunk": "@@ -131,7 +131,8 @@ def __init__(self, cfg, pre_init=None, pre_init_flash=None,\n self.gdb_init = gdb_init\n self.load_arg = ['-ex', 'load'] if load else []\n ...
true
zephyrproject-rtos/zephyr
110,951
issue_to_patch
tests: with_mcumgr: Rework to use prebuilt signed images
Fixes tests, as support for imgtool in west sign was deprecated https://github.com/zephyrproject-rtos/zephyr/pull/109588 The pytest scenarios relied on the `west sign` command to re-sign images at runtime, which broke after that command changed. Rework the tests to use Twister's `required_applications` feature inst...
0e62b7d7f363702abe206cf38672dd6722b6def1
f73aefdf9fd4353f59d8cadd3983835c07e008d4
[ "tests/boot/with_mcumgr/README.rst", "tests/boot/with_mcumgr/bt.conf", "tests/boot/with_mcumgr/pytest/test_downgrade_prevention.py", "tests/boot/with_mcumgr/pytest/test_upgrade.py", "tests/boot/with_mcumgr/pytest/test_upgrade_ble.py", "tests/boot/with_mcumgr/pytest/utils.py", "tests/boot/with_mcumgr/pyt...
[ { "comment": "nit. this should be renamed to remove overlay from the name, but can be done in a future PR", "path": "tests/boot/with_mcumgr/testcase.yaml", "hunk": "@@ -56,35 +98,18 @@ tests:\n - stm32l562e_dk\n - stm32u083c_dk\n - stm32wba65i_dk1\n- integration_platforms:\n- -...
diff --git a/tests/boot/with_mcumgr/README.rst b/tests/boot/with_mcumgr/README.rst index 5c82efa137a10..bd1d2d0de411b 100644 --- a/tests/boot/with_mcumgr/README.rst +++ b/tests/boot/with_mcumgr/README.rst @@ -15,12 +15,9 @@ use following command: .. code-block:: console - ./zephyr/scripts/twister -vv --west-fla...
true
zephyrproject-rtos/zephyr
110,951
comment_to_fix
tests: with_mcumgr: Rework to use prebuilt signed images
nit. this should be renamed to remove overlay from the name, but can be done in a future PR
0e62b7d7f363702abe206cf38672dd6722b6def1
f73aefdf9fd4353f59d8cadd3983835c07e008d4
diff --git a/tests/boot/with_mcumgr/testcase.yaml b/tests/boot/with_mcumgr/testcase.yaml index 4bfb319b234a8..5c135ad9a64ae 100644 --- a/tests/boot/with_mcumgr/testcase.yaml +++ b/tests/boot/with_mcumgr/testcase.yaml @@ -1,9 +1,10 @@ common: sysbuild: true + integration_platforms: + - nrf52840dk/nrf52840 pla...
[ "tests/boot/with_mcumgr/testcase.yaml" ]
[ { "comment": "nit. this should be renamed to remove overlay from the name, but can be done in a future PR", "path": "tests/boot/with_mcumgr/testcase.yaml", "hunk": "@@ -56,35 +98,18 @@ tests:\n - stm32l562e_dk\n - stm32u083c_dk\n - stm32wba65i_dk1\n- integration_platforms:\n- -...
true
zephyrproject-rtos/zephyr
110,937
issue_to_patch
drivers: dai: intel: ssp: improvements to get_properties implementation
The current implementation in ssp driver forces the client to use additional lockign for concurrent TX/RX use. See discussion in https://github.com/thesofproject/sof/pull/6930#issuecomment-1382089429 This really should be handled in the dai driver implementation instead and other dai drivers already handle TX/RX se...
ef5cfd369f4a0ab3601db9a23c1da8c406cc1a72
439d1e43993cdeb402336ae3287f536d643d3244
diff --git a/drivers/dai/intel/ssp/ssp.c b/drivers/dai/intel/ssp/ssp.c index 880ab74841c26..86cce192def10 100644 --- a/drivers/dai/intel/ssp/ssp.c +++ b/drivers/dai/intel/ssp/ssp.c @@ -2519,15 +2519,28 @@ static int dai_ssp_config_set(const struct device *dev, const struct dai_config return ret; } -static const st...
[ "drivers/dai/intel/ssp/ssp.c", "drivers/dai/intel/ssp/ssp.h" ]
[ { "comment": "`dai_ssp_get_properties_copy()` only assigns `fifo_address`, `dma_hs_id`, and `reg_init_delay`. Callers of `dai_get_properties_copy()` may pass an uninitialized `struct dai_properties`, so `fifo_depth` and `stream_id` can remain garbage/incorrect. The driver should populate all fields it exposes (...
true
zephyrproject-rtos/zephyr
110,797
issue_to_patch
boards: st: stm32h573i_dk/b_u585i_iot02a: Use EC-P256 as default signature type
The default signature type for TF-M was changed for v3.7, but `stm32h573i_dk` and `b_u585i_iot02a` were still using RSA-3072 as default due to not supporting EC-P256 at the time. With the recent addition of EC-P256 support for this board, switch the default signature type for this board as well and update the migration...
0e62b7d7f363702abe206cf38672dd6722b6def1
e6281b53ac6d3509e96a355b4ae1e267369fc27d
diff --git a/boards/st/b_u585i_iot02a/b_u585i_iot02a_stm32u585xx_ns_defconfig b/boards/st/b_u585i_iot02a/b_u585i_iot02a_stm32u585xx_ns_defconfig index b52669bee6fb5..2e5185bc4e37a 100644 --- a/boards/st/b_u585i_iot02a/b_u585i_iot02a_stm32u585xx_ns_defconfig +++ b/boards/st/b_u585i_iot02a/b_u585i_iot02a_stm32u585xx_ns_d...
[ "boards/st/b_u585i_iot02a/b_u585i_iot02a_stm32u585xx_ns_defconfig", "boards/st/stm32h573i_dk/stm32h573i_dk_stm32h573xx_ns_defconfig", "doc/releases/migration-guide-4.5.rst" ]
[]
true
zephyrproject-rtos/zephyr
110,778
issue_to_patch
boards: nxp: frdm_mcxn947: enable power management
Enable Zephyr power management on FRDM-MCXN947 (cpu0): - Select HAS_PM and PM_STATE_SET_IRQ_LOCKED for SOC_MCXN947_CPU0, matching the already-enabled MCXN547 and MCXN236. - Add zephyr,system-timer-companion = &lptmr0 so the kernel has a low-power wake source when the system clock is gated in the deep PM st...
8e33acdc8107a02e6e8f844c839cc5e4b54c7037
7a585a790134e9afc2b558a8b02dabc988a3efee
diff --git a/boards/nxp/frdm_mcxn947/frdm_mcxn947.dtsi b/boards/nxp/frdm_mcxn947/frdm_mcxn947.dtsi index 7aa056b7985e2..1da20b537e253 100644 --- a/boards/nxp/frdm_mcxn947/frdm_mcxn947.dtsi +++ b/boards/nxp/frdm_mcxn947/frdm_mcxn947.dtsi @@ -23,6 +23,7 @@ chosen { zephyr,edac = &erm0; + zephyr,system-timer-compa...
[ "boards/nxp/frdm_mcxn947/frdm_mcxn947.dtsi", "soc/nxp/mcx/mcxn/Kconfig", "tests/subsys/pm/power_mgmt_soc/boards/frdm_mcxn947_mcxn947_cpu0.conf", "tests/subsys/pm/power_mgmt_soc/boards/frdm_mcxn947_mcxn947_cpu0.overlay", "tests/subsys/pm/power_mgmt_soc/testcase.yaml" ]
[]
diff --git a/tests/subsys/pm/power_mgmt_soc/boards/frdm_mcxn947_mcxn947_cpu0.conf b/tests/subsys/pm/power_mgmt_soc/boards/frdm_mcxn947_mcxn947_cpu0.conf new file mode 100644 index 0000000000000..ec3ef6ca0e118 --- /dev/null +++ b/tests/subsys/pm/power_mgmt_soc/boards/frdm_mcxn947_mcxn947_cpu0.conf @@ -0,0 +1,7 @@ +# Cop...
true
zephyrproject-rtos/zephyr
110,396
issue_to_patch
boards: kit_pse84_ai: add tfm non-secure variant
Add TF-M non-secure variant for the PSE84 AI Kit board, enabling secure/non-secure partitioning. The NS variant is configured with TF-M medium profile, clock control, GPIO and UART console. Assisted-by: GitHub Copilot:claude-sonnet-4.5
b02731645bdf63e897e34219bf8883ad320b2d08
99db95f40b5fcc3669c86032cae61c065fae2d87
diff --git a/boards/infineon/kit_pse84_ai/Kconfig.defconfig b/boards/infineon/kit_pse84_ai/Kconfig.defconfig index 19d6964af44a8..15999d86c2de2 100644 --- a/boards/infineon/kit_pse84_ai/Kconfig.defconfig +++ b/boards/infineon/kit_pse84_ai/Kconfig.defconfig @@ -5,6 +5,9 @@ if BOARD_KIT_PSE84_AI_PSE846GPS2DBZC4A_M55 ...
[ "boards/infineon/kit_pse84_ai/Kconfig.defconfig", "boards/infineon/kit_pse84_ai/Kconfig.kit_pse84_ai", "boards/infineon/kit_pse84_ai/board.cmake", "boards/infineon/kit_pse84_ai/board.yml", "boards/infineon/kit_pse84_ai/doc/index.rst", "boards/infineon/kit_pse84_ai/kit_pse84_ai_m33_ns.dts", "boards/infin...
[ { "comment": "I think the same comment that I wrote [in this other PR](https://github.com/zephyrproject-rtos/zephyr/pull/110287#discussion_r3347022193) applies also here: can we move this Infineon specific block somewhere in `modules/hal_infineon/...` or `soc/infineon/...`?", "path": "modules/trusted-firmwa...
true
zephyrproject-rtos/zephyr
110,289
issue_to_patch
Infineon Autanalog PSE84 FIR and FIFO additions
- Autanalog SAR FIR postprocessing support - Autanalog SAR FIFO support - Added vendor-specific samples for autanalog FIR and FIFO
8e33acdc8107a02e6e8f844c839cc5e4b54c7037
a439c7c6aa457560fb04be2ffcf4d191bdd5e26b
diff --git a/boards/infineon/kit_pse84_eval/kit_pse84_eval_m55.yaml b/boards/infineon/kit_pse84_eval/kit_pse84_eval_m55.yaml index 7bb05c948893b..0fb20ed207294 100644 --- a/boards/infineon/kit_pse84_eval/kit_pse84_eval_m55.yaml +++ b/boards/infineon/kit_pse84_eval/kit_pse84_eval_m55.yaml @@ -1,5 +1,5 @@ -# Copyright (c...
[ "boards/infineon/kit_pse84_eval/kit_pse84_eval_m55.yaml", "drivers/adc/adc_infineon_autanalog_sar.c", "drivers/mfd/mfd_infineon_autanalog.c", "dts/arm/infineon/edge/pse84/pse84.cm55.dtsi", "dts/arm/infineon/edge/pse84/pse84.dtsi", "dts/arm/infineon/edge/pse84/pse84_s.dtsi", "dts/bindings/adc/infineon,au...
[ { "comment": "Are we getting code coverage from this sample? That's a bit surprising from the context of a sample application, if its a test we can do board specific tests as well.", "path": "samples/boards/infineon/autanalog/fifo/src/main.c", "hunk": "@@ -0,0 +1,165 @@\n+/*\n+ * SPDX-FileCopyrightText:...
true
zephyrproject-rtos/zephyr
110,289
comment_to_fix
Infineon Autanalog PSE84 FIR and FIFO additions
The comment states that the interrupt performs a mask before invoking the callback and restoring the mask after returning from the callback. I don't see that happening in the code, so either the comment should be corrected or the code updated to perform the mask/unmask.
8e33acdc8107a02e6e8f844c839cc5e4b54c7037
a439c7c6aa457560fb04be2ffcf4d191bdd5e26b
diff --git a/drivers/adc/adc_infineon_autanalog_sar.c b/drivers/adc/adc_infineon_autanalog_sar.c index 80c1b3837dc3d..3de089f39efc2 100644 --- a/drivers/adc/adc_infineon_autanalog_sar.c +++ b/drivers/adc/adc_infineon_autanalog_sar.c @@ -14,6 +14,7 @@ #include <zephyr/dt-bindings/clock/ifx_clock_source_common.h> #incl...
[ "drivers/adc/adc_infineon_autanalog_sar.c" ]
[ { "comment": "The comment states that the interrupt performs a mask before invoking the callback and restoring the mask after returning from the callback. I don't see that happening in the code, so either the comment should be corrected or the code updated to perform the mask/unmask. ", "path": "drivers/a...
true
zephyrproject-rtos/zephyr
110,289
comment_to_fix
Infineon Autanalog PSE84 FIR and FIFO additions
Consider adding validation on fir_idx as done in fir_read_result and fir_load_coefficients.
8e33acdc8107a02e6e8f844c839cc5e4b54c7037
a439c7c6aa457560fb04be2ffcf4d191bdd5e26b
diff --git a/drivers/adc/adc_infineon_autanalog_sar.c b/drivers/adc/adc_infineon_autanalog_sar.c index 80c1b3837dc3d..3de089f39efc2 100644 --- a/drivers/adc/adc_infineon_autanalog_sar.c +++ b/drivers/adc/adc_infineon_autanalog_sar.c @@ -14,6 +14,7 @@ #include <zephyr/dt-bindings/clock/ifx_clock_source_common.h> #incl...
[ "drivers/adc/adc_infineon_autanalog_sar.c" ]
[ { "comment": "Consider adding validation on fir_idx as done in fir_read_result and fir_load_coefficients.", "path": "drivers/adc/adc_infineon_autanalog_sar.c", "hunk": "@@ -839,11 +937,167 @@ static int ifx_autanalog_sar_adc_init(const struct device *dev)\n \tcfg->irq_func();\n #endif /* CONFIG_ADC_ASYN...
true
zephyrproject-rtos/zephyr
110,289
comment_to_fix
Infineon Autanalog PSE84 FIR and FIFO additions
Consider adding validation on fir_idx as done in fir_read_result and fir_load_coefficients.
8e33acdc8107a02e6e8f844c839cc5e4b54c7037
a439c7c6aa457560fb04be2ffcf4d191bdd5e26b
diff --git a/drivers/adc/adc_infineon_autanalog_sar.c b/drivers/adc/adc_infineon_autanalog_sar.c index 80c1b3837dc3d..3de089f39efc2 100644 --- a/drivers/adc/adc_infineon_autanalog_sar.c +++ b/drivers/adc/adc_infineon_autanalog_sar.c @@ -14,6 +14,7 @@ #include <zephyr/dt-bindings/clock/ifx_clock_source_common.h> #incl...
[ "drivers/adc/adc_infineon_autanalog_sar.c" ]
[ { "comment": "Consider adding validation on fir_idx as done in fir_read_result and fir_load_coefficients.", "path": "drivers/adc/adc_infineon_autanalog_sar.c", "hunk": "@@ -839,11 +937,167 @@ static int ifx_autanalog_sar_adc_init(const struct device *dev)\n \tcfg->irq_func();\n #endif /* CONFIG_ADC_ASYN...
true
zephyrproject-rtos/zephyr
110,289
comment_to_fix
Infineon Autanalog PSE84 FIR and FIFO additions
missing API versioning https://docs.zephyrproject.org/latest/contribute/style/doxygen.html#api-versioning
8e33acdc8107a02e6e8f844c839cc5e4b54c7037
a439c7c6aa457560fb04be2ffcf4d191bdd5e26b
diff --git a/include/zephyr/drivers/adc/infineon_autanalog_sar.h b/include/zephyr/drivers/adc/infineon_autanalog_sar.h new file mode 100644 index 0000000000000..17c163bfaa211 --- /dev/null +++ b/include/zephyr/drivers/adc/infineon_autanalog_sar.h @@ -0,0 +1,210 @@ +/* + * SPDX-FileCopyrightText: <text>Copyright (c) 202...
[ "include/zephyr/drivers/adc/infineon_autanalog_sar.h" ]
[ { "comment": "missing API versioning\r\nhttps://docs.zephyrproject.org/latest/contribute/style/doxygen.html#api-versioning", "path": "include/zephyr/drivers/adc/infineon_autanalog_sar.h", "hunk": "@@ -0,0 +1,194 @@\n+/*\n+ * SPDX-FileCopyrightText: <text>Copyright (c) 2026 Infineon Technologies AG,\n+ *...
true
zephyrproject-rtos/zephyr
110,289
comment_to_fix
Infineon Autanalog PSE84 FIR and FIFO additions
```suggestion ```
8e33acdc8107a02e6e8f844c839cc5e4b54c7037
a439c7c6aa457560fb04be2ffcf4d191bdd5e26b
diff --git a/samples/boards/infineon/autanalog/fir_fifo/sample.yaml b/samples/boards/infineon/autanalog/fir_fifo/sample.yaml new file mode 100644 index 0000000000000..c6984dc740937 --- /dev/null +++ b/samples/boards/infineon/autanalog/fir_fifo/sample.yaml @@ -0,0 +1,30 @@ +# SPDX-FileCopyrightText: <text>Copyright (c) ...
[ "samples/boards/infineon/autanalog/fir_fifo/sample.yaml" ]
[ { "comment": "```suggestion\r\n```", "path": "samples/boards/infineon/autanalog/fir_fifo/sample.yaml", "hunk": "@@ -0,0 +1,32 @@\n+# SPDX-FileCopyrightText: <text>Copyright (c) 2026 Infineon Technologies AG,\n+# or an affiliate of Infineon Technologies AG. All rights reserved.</text>\n+#\n+# SPDX-Licens...
true
zephyrproject-rtos/zephyr
110,289
comment_to_fix
Infineon Autanalog PSE84 FIR and FIFO additions
```suggestion These samples showcase Infineon-specific features in Zephyr. ```
8e33acdc8107a02e6e8f844c839cc5e4b54c7037
a439c7c6aa457560fb04be2ffcf4d191bdd5e26b
diff --git a/samples/boards/infineon/index.rst b/samples/boards/infineon/index.rst new file mode 100644 index 0000000000000..957efc1a8054a --- /dev/null +++ b/samples/boards/infineon/index.rst @@ -0,0 +1,9 @@ +.. SPDX-FileCopyrightText: Copyright The Zephyr Project Contributors +.. SPDX-License-Identifier: Apache-2.0 +...
[ "samples/boards/infineon/index.rst" ]
[ { "comment": "```suggestion\r\n These samples showcase Infineon-specific features in Zephyr.\r\n```", "path": "samples/boards/infineon/index.rst", "hunk": "@@ -0,0 +1,9 @@\n+.. SPDX-FileCopyrightText: Copyright The Zephyr Project Contributors\n+.. SPDX-License-Identifier: Apache-2.0\n+\n+.. zephyr:cod...
true
zephyrproject-rtos/zephyr
104,146
issue_to_patch
drivers: flash: stm32u5/stm32l5 option bytes
Expose option bytes reading / writing via flash_ex_op interface
ef5cfd369f4a0ab3601db9a23c1da8c406cc1a72
e5f4f3cc0d2854453bc4ab811c6f4391229da7ed
diff --git a/drivers/flash/flash_stm32_ex_op.c b/drivers/flash/flash_stm32_ex_op.c index 7478529c74dae..3d7d4b1ce22e6 100644 --- a/drivers/flash/flash_stm32_ex_op.c +++ b/drivers/flash/flash_stm32_ex_op.c @@ -336,7 +336,10 @@ int flash_stm32_ex_op(const struct device *dev, uint16_t code, defined(CONFIG_DT_HAS_ST_STM...
[ "drivers/flash/flash_stm32_ex_op.c", "drivers/flash/flash_stm32l5x.c" ]
[ { "comment": "I think you could swap this 2 cases:\n```c\n\tif ((regs->OPTR & mask) == value) {\n\t\treturn 0;\n\t}\n\n\tif (regs->NSCR & FLASH_NSCR_OPTLOCK) {\n\t\treturn -EIO;\n\t}", "path": "drivers/flash/flash_stm32l5x.c", "hunk": "@@ -382,3 +358,40 @@ void flash_stm32_page_layout(const struct devic...
true
zephyrproject-rtos/zephyr
104,146
comment_to_fix
drivers: flash: stm32u5/stm32l5 option bytes
I think you could swap this 2 cases: ```c if ((regs->OPTR & mask) == value) { return 0; } if (regs->NSCR & FLASH_NSCR_OPTLOCK) { return -EIO; }
ef5cfd369f4a0ab3601db9a23c1da8c406cc1a72
e5f4f3cc0d2854453bc4ab811c6f4391229da7ed
diff --git a/drivers/flash/flash_stm32l5x.c b/drivers/flash/flash_stm32l5x.c index 1c55e7adfa782..7e98a41249536 100644 --- a/drivers/flash/flash_stm32l5x.c +++ b/drivers/flash/flash_stm32l5x.c @@ -277,30 +277,6 @@ int flash_stm32_write_range(const struct device *dev, unsigned int offset, } #if defined(CONFIG_FLASH_...
[ "drivers/flash/flash_stm32l5x.c" ]
[ { "comment": "I think you could swap this 2 cases:\n```c\n\tif ((regs->OPTR & mask) == value) {\n\t\treturn 0;\n\t}\n\n\tif (regs->NSCR & FLASH_NSCR_OPTLOCK) {\n\t\treturn -EIO;\n\t}", "path": "drivers/flash/flash_stm32l5x.c", "hunk": "@@ -382,3 +358,40 @@ void flash_stm32_page_layout(const struct devic...
true
zephyrproject-rtos/zephyr
104,146
comment_to_fix
drivers: flash: stm32u5/stm32l5 option bytes
Could you add an empty line below. Alternatively: ```patch - FLASH_TypeDef *regs = FLASH_STM32_REGS(dev); - return regs->OPTR; + return FLASH_STM32_REGS(dev)->OPTR;
ef5cfd369f4a0ab3601db9a23c1da8c406cc1a72
e5f4f3cc0d2854453bc4ab811c6f4391229da7ed
diff --git a/drivers/flash/flash_stm32l5x.c b/drivers/flash/flash_stm32l5x.c index 1c55e7adfa782..7e98a41249536 100644 --- a/drivers/flash/flash_stm32l5x.c +++ b/drivers/flash/flash_stm32l5x.c @@ -277,30 +277,6 @@ int flash_stm32_write_range(const struct device *dev, unsigned int offset, } #if defined(CONFIG_FLASH_...
[ "drivers/flash/flash_stm32l5x.c" ]
[ { "comment": "Could you add an empty line below.\n\nAlternatively:\n```patch\n-\tFLASH_TypeDef *regs = FLASH_STM32_REGS(dev);\n-\treturn regs->OPTR;\n+\treturn FLASH_STM32_REGS(dev)->OPTR;\n", "path": "drivers/flash/flash_stm32l5x.c", "hunk": "@@ -382,3 +358,40 @@ void flash_stm32_page_layout(const stru...
true
zephyrproject-rtos/zephyr
104,146
comment_to_fix
drivers: flash: stm32u5/stm32l5 option bytes
stm32h5xx also relies on `"st,stm32l5-flash"` but has a different Option Bytes access sequence. ```suggestion (defined(CONFIG_DT_HAS_ST_STM32L5_FLASH_CONTROLLER_ENABLED) && \ (defined(CONFIG_SOC_SERIES_STM32L5X) || \ defined(CONFIG_SOC_SERIES_STM32U5X)))) ``` and also add in **drivers/flash/flash_stm32l5x.c**...
ef5cfd369f4a0ab3601db9a23c1da8c406cc1a72
e5f4f3cc0d2854453bc4ab811c6f4391229da7ed
diff --git a/drivers/flash/flash_stm32_ex_op.c b/drivers/flash/flash_stm32_ex_op.c index 7478529c74dae..3d7d4b1ce22e6 100644 --- a/drivers/flash/flash_stm32_ex_op.c +++ b/drivers/flash/flash_stm32_ex_op.c @@ -336,7 +336,10 @@ int flash_stm32_ex_op(const struct device *dev, uint16_t code, defined(CONFIG_DT_HAS_ST_STM...
[ "drivers/flash/flash_stm32_ex_op.c" ]
[ { "comment": "stm32h5xx also relies on `\"st,stm32l5-flash\"` but has a different Option Bytes access sequence.\n\n```suggestion\n\t\t(defined(CONFIG_DT_HAS_ST_STM32L5_FLASH_CONTROLLER_ENABLED) && \\\n\t\t (defined(CONFIG_SOC_SERIES_STM32L5X) || \\\n\t\t defined(CONFIG_SOC_SERIES_STM32U5X))))\n```\nand also ad...
true
zephyrproject-rtos/zephyr
104,146
comment_to_fix
drivers: flash: stm32u5/stm32l5 option bytes
Could you mention in the commit message that you now also check Option Bytes locking prior attempting a write?
ef5cfd369f4a0ab3601db9a23c1da8c406cc1a72
e5f4f3cc0d2854453bc4ab811c6f4391229da7ed
diff --git a/drivers/flash/flash_stm32l5x.c b/drivers/flash/flash_stm32l5x.c index 1c55e7adfa782..7e98a41249536 100644 --- a/drivers/flash/flash_stm32l5x.c +++ b/drivers/flash/flash_stm32l5x.c @@ -277,30 +277,6 @@ int flash_stm32_write_range(const struct device *dev, unsigned int offset, } #if defined(CONFIG_FLASH_...
[ "drivers/flash/flash_stm32l5x.c" ]
[ { "comment": "Could you mention in the commit message that you now also check Option Bytes locking prior attempting a write?", "path": "drivers/flash/flash_stm32l5x.c", "hunk": "@@ -382,3 +358,40 @@ void flash_stm32_page_layout(const struct device *dev,\n \n \t*layout_size = stm32_flash_layout_size;\n }...
true
zephyrproject-rtos/zephyr
104,146
comment_to_fix
drivers: flash: stm32u5/stm32l5 option bytes
Could you add either ```c return flash_stm32_wait_flash_idle(dev); ``` or ```c barrier_dsync_fence_full(); ``` to ensure the target reset before we're back in to the caller?
ef5cfd369f4a0ab3601db9a23c1da8c406cc1a72
e5f4f3cc0d2854453bc4ab811c6f4391229da7ed
diff --git a/drivers/flash/flash_stm32l5x.c b/drivers/flash/flash_stm32l5x.c index 1c55e7adfa782..7e98a41249536 100644 --- a/drivers/flash/flash_stm32l5x.c +++ b/drivers/flash/flash_stm32l5x.c @@ -277,30 +277,6 @@ int flash_stm32_write_range(const struct device *dev, unsigned int offset, } #if defined(CONFIG_FLASH_...
[ "drivers/flash/flash_stm32l5x.c" ]
[ { "comment": "Could you add either\n```c\n\treturn flash_stm32_wait_flash_idle(dev);\n```\nor\n```c\n\tbarrier_dsync_fence_full();\n```\nto ensure the target reset before we're back in to the caller?", "path": "drivers/flash/flash_stm32l5x.c", "hunk": "@@ -382,3 +358,43 @@ void flash_stm32_page_layout(c...
true
zephyrproject-rtos/zephyr
104,146
comment_to_fix
drivers: flash: stm32u5/stm32l5 option bytes
Could you add a space char for indentation. ```suggestion (defined(CONFIG_SOC_SERIES_STM32L5X) || \ defined(CONFIG_SOC_SERIES_STM32U5X)))) ``` or: ```suggestion (defined(CONFIG_SOC_SERIES_STM32L5X) || defined(CONFIG_SOC_SERIES_STM32U5X))))
ef5cfd369f4a0ab3601db9a23c1da8c406cc1a72
e5f4f3cc0d2854453bc4ab811c6f4391229da7ed
diff --git a/drivers/flash/flash_stm32_ex_op.c b/drivers/flash/flash_stm32_ex_op.c index 7478529c74dae..3d7d4b1ce22e6 100644 --- a/drivers/flash/flash_stm32_ex_op.c +++ b/drivers/flash/flash_stm32_ex_op.c @@ -336,7 +336,10 @@ int flash_stm32_ex_op(const struct device *dev, uint16_t code, defined(CONFIG_DT_HAS_ST_STM...
[ "drivers/flash/flash_stm32_ex_op.c" ]
[ { "comment": "Could you add a space char for indentation.\n```suggestion\n\t\t (defined(CONFIG_SOC_SERIES_STM32L5X) || \\\n\t\t defined(CONFIG_SOC_SERIES_STM32U5X))))\n```\nor:\n```suggestion\n\t\t (defined(CONFIG_SOC_SERIES_STM32L5X) || defined(CONFIG_SOC_SERIES_STM32U5X))))\n", "path": "drivers/flash/fla...
true
zephyrproject-rtos/zephyr
104,146
comment_to_fix
drivers: flash: stm32u5/stm32l5 option bytes
Oops: stricly conforming to Zephyr coding recommendation (test on essentially boolean values), prefer `if ((regs->NSCR & FLASH_NSCR_OPTLOCK) != 0)`. Could you fix that while you are at squashing commits?
ef5cfd369f4a0ab3601db9a23c1da8c406cc1a72
e5f4f3cc0d2854453bc4ab811c6f4391229da7ed
diff --git a/drivers/flash/flash_stm32l5x.c b/drivers/flash/flash_stm32l5x.c index 1c55e7adfa782..7e98a41249536 100644 --- a/drivers/flash/flash_stm32l5x.c +++ b/drivers/flash/flash_stm32l5x.c @@ -277,30 +277,6 @@ int flash_stm32_write_range(const struct device *dev, unsigned int offset, } #if defined(CONFIG_FLASH_...
[ "drivers/flash/flash_stm32l5x.c" ]
[ { "comment": "Oops: stricly conforming to Zephyr coding recommendation (test on essentially boolean values), prefer `if ((regs->NSCR & FLASH_NSCR_OPTLOCK) != 0)`. Could you fix that while you are at squashing commits?", "path": "drivers/flash/flash_stm32l5x.c", "hunk": "@@ -382,3 +358,43 @@ void flash_s...
true
zephyrproject-rtos/zephyr
110,298
issue_to_patch
[Backport v4.3-branch] bbram: mcp7940c: emulator: Fix off by 1 stack overflow bug
Backport ae58840f96153d2ed8233d306d442a8a4719c76c from #108038. _Original PR description:_ --- Fix an out of bounds array read, which causes the test to read beyond the stack and fail (probably at random). The issue can be pinpointed building with ASAN. ``` mkdir build && cd build cmake -GNinja -DBOARD=native_...
9d4ff6f8d0cc66ae9106266d7641ebad86b815a6
ea2eb75a16247db177139239aa96d6944790ec32
diff --git a/drivers/bbram/bbram_microchip_mcp7940n_emul.c b/drivers/bbram/bbram_microchip_mcp7940n_emul.c index d1206c42a1684..5c4bc5462efe7 100644 --- a/drivers/bbram/bbram_microchip_mcp7940n_emul.c +++ b/drivers/bbram/bbram_microchip_mcp7940n_emul.c @@ -90,7 +90,7 @@ static int mcp7940n_emul_transfer_i2c(const struc...
[ "drivers/bbram/bbram_microchip_mcp7940n_emul.c" ]
[]
true
zephyrproject-rtos/zephyr
111,019
issue_to_patch
[Backport v4.3-branch] kernel: userspace: fix SMP use-after-free
Backport fdc42fa256b8c2a7b27790f032d5385f8058c4a9 from #108721. _Original PR description:_ --- obj_list traversal held lists_lock, but removals held objfree_lock (k_object_free) or obj_lock (unref_check). On SMP a concurrent thread could free the node an iterator had saved as next. Drop objfree_lock and require l...
727fe24d81006d4f0b4e3d9c9e1af5fbace8e818
66211a03364801b4155dfb75d851ca03a0a9ff67
diff --git a/kernel/userspace.c b/kernel/userspace.c index 61e00afcbc4c7..9b1128b66f7f0 100644 --- a/kernel/userspace.c +++ b/kernel/userspace.c @@ -49,7 +49,6 @@ LOG_MODULE_DECLARE(os, CONFIG_KERNEL_LOG_LEVEL); */ #ifdef CONFIG_DYNAMIC_OBJECTS static struct k_spinlock lists_lock; /* kobj dlist */ -static str...
[ "kernel/userspace.c" ]
[]
true
zephyrproject-rtos/zephyr
111,065
issue_to_patch
[Backport v4.3-branch] Bluetooth: BAP: BA: Move att_buf to inst
Backport of the fix from #107563 to `v4.3-branch`. Fixes #110967
727fe24d81006d4f0b4e3d9c9e1af5fbace8e818
302685885eb0129c448489de99ade920465a93f2
diff --git a/subsys/bluetooth/audio/bap_broadcast_assistant.c b/subsys/bluetooth/audio/bap_broadcast_assistant.c index fca4bf39d7013..e8c9694c19298 100644 --- a/subsys/bluetooth/audio/bap_broadcast_assistant.c +++ b/subsys/bluetooth/audio/bap_broadcast_assistant.c @@ -97,6 +97,11 @@ struct bap_broadcast_assistant_insta...
[ "subsys/bluetooth/audio/bap_broadcast_assistant.c" ]
[ { "comment": "`notify_handler()` appends notification data with `net_buf_simple_add_mem()` without checking tailroom. `net_buf_simple_add_mem()` relies on `__ASSERT(net_buf_simple_tailroom() >= len)`, so in non-assert builds a malformed/oversized notification can overrun the buffer; in assert-enabled builds it ...
true
zephyrproject-rtos/zephyr
109,547
issue_to_patch
Backport CVE 2026-5590 fix for 4.3
Vulnerability https://github.com/zephyrproject-rtos/zephyr/security/advisories/GHSA-4vqm-pw24-g9jp states that it affects 4.3 but the linked fix is not included in v4.3 branch. Perhaps because there is no bug issue about it so it went without backporting? Anyways, cherry-pick the proposed fix to v4.3 branch. Fixes h...
33dc0970da25fb1544cadbc01c59d9d4e963d3f3
3ccf023c2c8f6e6265738c4de27cdfc39837dd05
diff --git a/subsys/net/ip/tcp.c b/subsys/net/ip/tcp.c index f8d1fd03ea1af..03a4cc2f360fe 100644 --- a/subsys/net/ip/tcp.c +++ b/subsys/net/ip/tcp.c @@ -2313,7 +2313,7 @@ static enum net_verdict tcp_recv(struct net_conn *net_conn, if (th_flags(th) & SYN && !(th_flags(th) & ACK)) { struct tcp *conn_old = ((struct n...
[ "subsys/net/ip/tcp.c" ]
[]
true
zephyrproject-rtos/zephyr
110,909
issue_to_patch
pb-adv bearer resets the protocol timer unconditionally ### Describe the bug In prov_msg_recv(), the protocol timer was reset unconditionally at the top of the function, before the FCS check and before the ADV_LINK_INVALID check. When the link has been marked invalid (e.g. after a provisioning failure), any incoming ...
[Backport v4.3-branch] bluetooth: mesh: defer prov protocol timer reset past validity checks
Backport 3f3c37edf80262b838ef5402fec9880c07892e4e from #109324. _Original PR description:_ --- In prov_msg_recv(), the protocol timer was reset unconditionally at the top of the function, before the FCS check and before the ADV_LINK_INVALID check. When the link has been marked invalid (e.g. after a provisionin...
727fe24d81006d4f0b4e3d9c9e1af5fbace8e818
2e0740bbb5fb8e507dd3bb70b6ee7f770e57f90c
diff --git a/subsys/bluetooth/mesh/pb_adv.c b/subsys/bluetooth/mesh/pb_adv.c index 1f77f782c8500..3315cb67d2731 100644 --- a/subsys/bluetooth/mesh/pb_adv.c +++ b/subsys/bluetooth/mesh/pb_adv.c @@ -412,8 +412,6 @@ static void prov_failed(uint8_t err) static void prov_msg_recv(void) { - k_work_reschedule(&link.prot_t...
[ "subsys/bluetooth/mesh/pb_adv.c" ]
[]
true
zephyrproject-rtos/zephyr
110,959
issue_to_patch
[Backport v4.3-branch] Bluetooth: ISO: Add missing buf->len checks in bt_iso_recv
Backport 756b16b64317defefad36fc994316cf96e418708 from #108603. _Original PR description:_ --- bt_iso_recv pulls the SDU header (with or without) timestamp, but did not check the length of `buf` before doing so. Fixes: #110956
f342279a54a37171c87cf8bbe5ff7370102781bc
b9a370338debb9cd8525105e3471f271dd4cf281
diff --git a/subsys/bluetooth/host/iso.c b/subsys/bluetooth/host/iso.c index c036779a42c9d..d02b5962e2bc6 100644 --- a/subsys/bluetooth/host/iso.c +++ b/subsys/bluetooth/host/iso.c @@ -672,12 +672,26 @@ void bt_iso_recv(struct bt_conn *iso, struct net_buf *buf, uint8_t flags) if (ts) { struct bt_hci_iso_sdu_ts_h...
[ "subsys/bluetooth/host/iso.c" ]
[]
true
zephyrproject-rtos/zephyr
108,244
issue_to_patch
drivers: gpio: aesc: driver does not use struct gpio_driver_config and struct gpio_driver_data ### Describe the bug All gpio drivers need to have struct gpio_driver_config and struct gpio_driver_data at the first position of the data and config struct. The drivers/gpio/gpio_aesc.c does not do that. Also the config s...
drivers: gpio+serial: aesc: Properly relocate register base
Don't relocate the register base address by writting into `DEVICE_MMIO_GET(dev)`, because this variable could be located in read-only memory. Instead, store the register base address in the data struct as `reg_base`. Also fix copyright holder for both drivers. Closes https://github.com/zephyrproject-rtos/zephyr/...
8cb75f4fbdde883e8020929c0c9a5b1db1a4bd4c
eb888f2ab30bc12c526baff121a634f0bef7f7d7
diff --git a/drivers/gpio/Kconfig.aesc b/drivers/gpio/Kconfig.aesc index aa7fa29ce3f26..5ced4da5a1edf 100644 --- a/drivers/gpio/Kconfig.aesc +++ b/drivers/gpio/Kconfig.aesc @@ -1,4 +1,4 @@ -# Copyright (c) 2025 Aesc Silicon +# SPDX-FileCopyrightText: 2025 Aesc Silicon # SPDX-License-Identifier: Apache-2.0 config GP...
[ "drivers/gpio/Kconfig.aesc", "drivers/gpio/gpio_aesc.c", "drivers/serial/Kconfig.aesc", "drivers/serial/uart_aesc.c", "dts/bindings/gpio/aesc,gpio.yaml", "dts/bindings/serial/aesc,uart.yaml" ]
[ { "comment": "use GPIO_COMMON_CONFIG_FROM_DT_INST", "path": "drivers/gpio/gpio_aesc.c", "hunk": "@@ -271,7 +277,11 @@ static DEVICE_API(gpio, gpio_aesc_driver_api) = {\n \t\tirq_enable(DT_INST_IRQN(no));\t\t\t\t \\\n \t}\t\t\t\t\t\t\t\t \\\n \tstatic struct gpio_aesc_config gpio_aesc_dev_cfg_#...
true
zephyrproject-rtos/zephyr
109,618
issue_to_patch
[backport] Bluetooth: Controller: Fix OOB read in ISOAL ### Describe the bug OOB fixed in https://github.com/zephyrproject-rtos/zephyr/pull/109369 must be back ported to all supported versions (if applicable) v4.4.* v4.3.* v3.7.* --- When sc=0, a framed ISO PDU segment header includes a 3-byte time_offset field, s...
[Backport v3.7-branch] Bluetooth: Controller: Fix OOB read in ISOAL
Backport 28080d80fc8aca30af1dfd1338bd4481b13c7395 from #109369. _Original PR description:_ --- When sc=0, a framed ISO PDU segment header includes a 3-byte time_offset field, so seg_hdr->len must be at least PDU_ISO_SEG_TIMEOFFSET_SIZE. isoal_check_seg_header() accepted segments with sc=0 and len<3 as valid, a...
03ef1d8fc6927ca009bceae6c05b2d379a224e37
2f8c5a7eb3f1a566aadd3d20540ba3a7201b3795
diff --git a/subsys/bluetooth/controller/ll_sw/isoal.c b/subsys/bluetooth/controller/ll_sw/isoal.c index e58599596977e..ffef42cb69ff9 100644 --- a/subsys/bluetooth/controller/ll_sw/isoal.c +++ b/subsys/bluetooth/controller/ll_sw/isoal.c @@ -979,6 +979,11 @@ static isoal_sdu_status_t isoal_check_seg_header(struct pdu_is...
[ "subsys/bluetooth/controller/ll_sw/isoal.c" ]
[]
true
zephyrproject-rtos/zephyr
111,104
issue_to_patch
[Backport v3.7-branch] frdm_mcxc242 lpuart support async api
Backport of the fix from #107186 to `v3.7-branch`. Fixes: #103831
5ec4ee261c188f84678c49f306441cb06e7d3a7f
23f6876ef91715336f46ecd0b6c48bef5f9351a7
diff --git a/drivers/serial/uart_mcux_lpuart.c b/drivers/serial/uart_mcux_lpuart.c index 7b8d96252b3e4..8147c15a00ceb 100644 --- a/drivers/serial/uart_mcux_lpuart.c +++ b/drivers/serial/uart_mcux_lpuart.c @@ -1150,11 +1150,8 @@ static int mcux_lpuart_configure(const struct device *dev, { const struct mcux_lpuart_con...
[ "drivers/serial/uart_mcux_lpuart.c" ]
[]
true
zephyrproject-rtos/zephyr
110,911
issue_to_patch
pb-adv bearer resets the protocol timer unconditionally ### Describe the bug In prov_msg_recv(), the protocol timer was reset unconditionally at the top of the function, before the FCS check and before the ADV_LINK_INVALID check. When the link has been marked invalid (e.g. after a provisioning failure), any incoming ...
[Backport v3.7-branch] bluetooth: mesh: defer prov protocol timer reset past validity checks
Backport 3f3c37edf80262b838ef5402fec9880c07892e4e from #109324. _Original PR description:_ --- In prov_msg_recv(), the protocol timer was reset unconditionally at the top of the function, before the FCS check and before the ADV_LINK_INVALID check. When the link has been marked invalid (e.g. after a provisionin...
ef293d8b5e5d0de336bc4addbfdef63302df150b
881d1117ddfe1388d623d80d06135173f181552c
diff --git a/subsys/bluetooth/mesh/pb_adv.c b/subsys/bluetooth/mesh/pb_adv.c index e5946e739d696..51f0fb693b419 100644 --- a/subsys/bluetooth/mesh/pb_adv.c +++ b/subsys/bluetooth/mesh/pb_adv.c @@ -412,8 +412,6 @@ static void prov_failed(uint8_t err) static void prov_msg_recv(void) { - k_work_reschedule(&link.prot_t...
[ "subsys/bluetooth/mesh/pb_adv.c" ]
[]
true
zephyrproject-rtos/zephyr
110,958
issue_to_patch
[Backport v3.7-branch] Bluetooth: ISO: Add missing buf->len checks in bt_iso_recv
Backport 756b16b64317defefad36fc994316cf96e418708 from #108603. _Original PR description:_ --- bt_iso_recv pulls the SDU header (with or without) timestamp, but did not check the length of `buf` before doing so. Fixes: #110956
ef293d8b5e5d0de336bc4addbfdef63302df150b
fcc4de52284034f946da9949e42f71b102a0b2a4
diff --git a/subsys/bluetooth/host/iso.c b/subsys/bluetooth/host/iso.c index f1a2630f2ae4b..eaf4651943ff1 100644 --- a/subsys/bluetooth/host/iso.c +++ b/subsys/bluetooth/host/iso.c @@ -626,12 +626,26 @@ void bt_iso_recv(struct bt_conn *iso, struct net_buf *buf, uint8_t flags) if (ts) { struct bt_hci_iso_sdu_ts_h...
[ "subsys/bluetooth/host/iso.c" ]
[]
true