url stringlengths 50 53 | repository_url stringclasses 1 value | labels_url stringlengths 64 67 | comments_url stringlengths 59 62 | events_url stringlengths 57 60 | html_url stringlengths 38 43 | id int64 597k 2.65B | node_id stringlengths 18 32 | number int64 1 6.83k | title stringlengths 1 296 | user dict | labels listlengths 0 5 | state stringclasses 2 values | locked bool 2 classes | assignee dict | assignees listlengths 0 4 | milestone dict | comments int64 0 211 | created_at stringlengths 20 20 | updated_at stringlengths 20 20 | closed_at stringlengths 20 20 ⌀ | author_association stringclasses 3 values | active_lock_reason stringclasses 4 values | body stringlengths 0 65.6k ⌀ | closed_by dict | reactions dict | timeline_url stringlengths 59 62 | performed_via_github_app null | state_reason stringclasses 3 values | draft bool 2 classes | pull_request dict | is_pull_request bool 2 classes | issue_comments listlengths 0 30 |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/psf/requests/issues/3392 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3392/labels{/name} | https://api.github.com/repos/psf/requests/issues/3392/comments | https://api.github.com/repos/psf/requests/issues/3392/events | https://github.com/psf/requests/issues/3392 | 164,704,240 | MDU6SXNzdWUxNjQ3MDQyNDA= | 3,392 | Automatically executes script in working folder if its name "cgi" | {
"avatar_url": "https://avatars.githubusercontent.com/u/9381116?v=4",
"events_url": "https://api.github.com/users/dan-win/events{/privacy}",
"followers_url": "https://api.github.com/users/dan-win/followers",
"following_url": "https://api.github.com/users/dan-win/following{/other_user}",
"gists_url": "https://api.github.com/users/dan-win/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dan-win",
"id": 9381116,
"login": "dan-win",
"node_id": "MDQ6VXNlcjkzODExMTY=",
"organizations_url": "https://api.github.com/users/dan-win/orgs",
"received_events_url": "https://api.github.com/users/dan-win/received_events",
"repos_url": "https://api.github.com/users/dan-win/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dan-win/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dan-win/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dan-win",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2016-07-10T07:41:50Z | 2021-09-08T17:05:32Z | 2016-07-10T08:00:52Z | NONE | resolved | Requests version - 2.10.0
As soon as the working folder folder contains script with name "cgi.py" (it was part of my application), your package automatically executes it. In my case - I fixed that myself by renaming my script. For another users - probability of such case is not zero. (In my case it was about 1 hour of fighting with strange behavior of my application). To reproduce it, it is possible to create 2 simple scripts, e.g.:
**test.py**:
_import requests
print "Hello from test"_
**cgi.py**:
_print "Hello from CGI!"_
Possible solutions: to reflect such behavior in documentation or to fix it.
P.S. Very nice package, it saved me much more time this lost hour!
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3392/reactions"
} | https://api.github.com/repos/psf/requests/issues/3392/timeline | null | completed | null | null | false | [
"This is not a bug: this is unfortunately the way Python works. Python puts the current working directory at the top of the import namespace, which means that when we try to import standard library modules, if you have a script in the working directory with the same name, we will accidentally get that instead. \n\n... |
https://api.github.com/repos/psf/requests/issues/3391 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3391/labels{/name} | https://api.github.com/repos/psf/requests/issues/3391/comments | https://api.github.com/repos/psf/requests/issues/3391/events | https://github.com/psf/requests/issues/3391 | 164,685,870 | MDU6SXNzdWUxNjQ2ODU4NzA= | 3,391 | SSLError: EOF occurred in violation of protocol (_ssl.c:590) | {
"avatar_url": "https://avatars.githubusercontent.com/u/13929583?v=4",
"events_url": "https://api.github.com/users/vandernath/events{/privacy}",
"followers_url": "https://api.github.com/users/vandernath/followers",
"following_url": "https://api.github.com/users/vandernath/following{/other_user}",
"gists_url": "https://api.github.com/users/vandernath/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/vandernath",
"id": 13929583,
"login": "vandernath",
"node_id": "MDQ6VXNlcjEzOTI5NTgz",
"organizations_url": "https://api.github.com/users/vandernath/orgs",
"received_events_url": "https://api.github.com/users/vandernath/received_events",
"repos_url": "https://api.github.com/users/vandernath/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/vandernath/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vandernath/subscriptions",
"type": "User",
"url": "https://api.github.com/users/vandernath",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 6 | 2016-07-09T21:10:37Z | 2021-09-08T01:21:14Z | 2016-07-14T13:01:51Z | NONE | resolved | Please bear with me as I'm quite new with Python and github in general.
I have been using requests to scrape data from the Play Store. I need to make a large amount of requests (about 20k). It works great for about 3000-4000 requests but gets stuck after that (SSL Error). I am not familiar with SSL and requests, so I don't know what causes this.
Error:
```
(SSLError Traceback (most recent call last)
<ipython-input-23-1da544640d89> in <module>()
53 time.sleep(0.1)
54
---> 55 r = requests.get('https://play.google.com' + link + '&hl=en')
56 link_tree = html.fromstring(r.content)
57 description = link_tree.xpath('//div[@jsname="C4s9Ed"]/text()') + link_tree.xpath('//div[@jsname="C4s9Ed"]/p/text()')
C:\Users\Nathan\AppData\Local\Enthought\Canopy\User\lib\site-packages\requests\api.pyc in get(url, params, **kwargs)
65
66 kwargs.setdefault('allow_redirects', True)
---> 67 return request('get', url, params=params, **kwargs)
68
69
C:\Users\Nathan\AppData\Local\Enthought\Canopy\User\lib\site-packages\requests\api.pyc in request(method, url, **kwargs)
51 # cases, and look like a memory leak in others.
52 with sessions.Session() as session:
---> 53 return session.request(method=method, url=url, **kwargs)
54
55
C:\Users\Nathan\AppData\Local\Enthought\Canopy\User\lib\site-packages\requests\sessions.pyc in request(self, method, url, params, data, headers, cookies, files, auth, timeout, allow_redirects, proxies, hooks, stream, verify, cert, json)
466 }
467 send_kwargs.update(settings)
--> 468 resp = self.send(prep, **send_kwargs)
469
470 return resp
C:\Users\Nathan\AppData\Local\Enthought\Canopy\User\lib\site-packages\requests\sessions.pyc in send(self, request, **kwargs)
574
575 # Send the request
--> 576 r = adapter.send(request, **kwargs)
577
578 # Total elapsed time of the request (approximately)
C:\Users\Nathan\AppData\Local\Enthought\Canopy\User\lib\site-packages\requests\adapters.pyc in send(self, request, stream, timeout, verify, cert, proxies)
445 except (_SSLError, _HTTPError) as e:
446 if isinstance(e, _SSLError):
--> 447 raise SSLError(e, request=request)
448 elif isinstance(e, ReadTimeoutError):
449 raise ReadTimeout(e, request=request)
SSLError: EOF occurred in violation of protocol (_ssl.c:590) )
```
The-efi, on this github, seemed to have the same problem on this thread: https://github.com/kennethreitz/requests/issues/3006 (see below, he was not the OP) but I was not able to find the thread he opened for further assistance. I use Python 2.7. as well.
I have been stuck on this for quite a while now and I can't find any answer here nor StackOverflow (the answer was probably right under my nose but I've had trouble understanding them because of my lack of knowledge in SSL & requests).
Thank you in advance for your help, and sorry if something is unclear -- please let me know.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3391/reactions"
} | https://api.github.com/repos/psf/requests/issues/3391/timeline | null | completed | null | null | false | [
"When you say you get stuck, is it just that the exception fires? Or do follow-up requests not work? I ask because transient network errors _do_ occur, and if you're making large numbers of web requests you should consider implementing some kind of retry logic in the face of them. \n",
"The exception fires. Follo... |
https://api.github.com/repos/psf/requests/issues/3390 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3390/labels{/name} | https://api.github.com/repos/psf/requests/issues/3390/comments | https://api.github.com/repos/psf/requests/issues/3390/events | https://github.com/psf/requests/pull/3390 | 164,333,769 | MDExOlB1bGxSZXF1ZXN0NzY2MTI4OTU= | 3,390 | Defining header value type requirements and tests | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2016-07-07T15:13:22Z | 2021-09-08T02:10:18Z | 2016-07-07T16:20:03Z | MEMBER | resolved | Currently a non-string/bytes value will cause `pat.match(value)` to raise a TypeError from `re`. I'm proposing catching this exception and raising it as a more descriptive `InvalidHeader` instead, so that it's clear we're intending this to happen.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3390/reactions"
} | https://api.github.com/repos/psf/requests/issues/3390/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3390.diff",
"html_url": "https://github.com/psf/requests/pull/3390",
"merged_at": "2016-07-07T16:20:03Z",
"patch_url": "https://github.com/psf/requests/pull/3390.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3390"
} | true | [
"👍 from me. @Lukasa ?\n",
"LGTM, let's do it! :sparkles:\n"
] |
https://api.github.com/repos/psf/requests/issues/3389 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3389/labels{/name} | https://api.github.com/repos/psf/requests/issues/3389/comments | https://api.github.com/repos/psf/requests/issues/3389/events | https://github.com/psf/requests/issues/3389 | 164,275,047 | MDU6SXNzdWUxNjQyNzUwNDc= | 3,389 | I question the distribution of LGPL code with Requests | {
"avatar_url": "https://avatars.githubusercontent.com/u/619444?v=4",
"events_url": "https://api.github.com/users/gozdal/events{/privacy}",
"followers_url": "https://api.github.com/users/gozdal/followers",
"following_url": "https://api.github.com/users/gozdal/following{/other_user}",
"gists_url": "https://api.github.com/users/gozdal/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/gozdal",
"id": 619444,
"login": "gozdal",
"node_id": "MDQ6VXNlcjYxOTQ0NA==",
"organizations_url": "https://api.github.com/users/gozdal/orgs",
"received_events_url": "https://api.github.com/users/gozdal/received_events",
"repos_url": "https://api.github.com/users/gozdal/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/gozdal/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/gozdal/subscriptions",
"type": "User",
"url": "https://api.github.com/users/gozdal",
"user_view_type": "public"
} | [
{
"color": "f7c6c7",
"default": false,
"description": null,
"id": 167537670,
"name": "Propose Close",
"node_id": "MDU6TGFiZWwxNjc1Mzc2NzA=",
"url": "https://api.github.com/repos/psf/requests/labels/Propose%20Close"
}
] | closed | true | null | [] | null | 14 | 2016-07-07T10:11:12Z | 2018-06-12T16:16:52Z | 2016-07-07T23:13:05Z | NONE | resolved | I'm not sure if this is the right place to discuss licensing issues. If not please point me to the right place.
Requests itself is under an Apache license, while bundled chardet library is under LGPL. I believe those two are incompatible and people that include requests are expecting it to be 100% Apache, while they get a portion of it under LGPL.
Any thoughts on how this could be resolved?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3389/reactions"
} | https://api.github.com/repos/psf/requests/issues/3389/timeline | null | completed | null | null | false | [
"Yeah, this makes me somewhat uncomfortable. My _suspicion_ is that the LGPL doesn't allow what we're doing here, but IANAL. Fundamentally the decision here is with @kennethreitz. If it were me, though, I'd chat with Van Lindberg and see what he says, and then potentially take action to make chardet an optional dep... |
https://api.github.com/repos/psf/requests/issues/3388 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3388/labels{/name} | https://api.github.com/repos/psf/requests/issues/3388/comments | https://api.github.com/repos/psf/requests/issues/3388/events | https://github.com/psf/requests/pull/3388 | 164,176,058 | MDExOlB1bGxSZXF1ZXN0NzY1MDMyMzM= | 3,388 | updating documentation to reflect decision of #3386 | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2016-07-06T21:15:46Z | 2021-09-08T02:10:15Z | 2016-07-07T14:56:08Z | MEMBER | resolved | These are a couple of minor doc tweaks to document the decision to enforce strings in header values. Since requests previously operated with non-string header values, I figured it was best to make note that an exception will now be thrown in the event of a non-string value.
There may be some formatting and wording changes needed, this iteration is mainly to get the conversation going.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3388/reactions"
} | https://api.github.com/repos/psf/requests/issues/3388/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3388.diff",
"html_url": "https://github.com/psf/requests/pull/3388",
"merged_at": "2016-07-07T14:56:08Z",
"patch_url": "https://github.com/psf/requests/pull/3388.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3388"
} | true | [
"Cool, LGTM! :sparkles: @sigmavirus24?\n",
"While you're here @sigmavirus24 and @Lukasa, I threw together [another commit](https://github.com/nateprewitt/requests/commit/be31a90906deb5553c2e703fb05cf6964ee23ed5) related to this to encapsulate the type error thrown by `re` when non-strings are passed to `check_hea... |
https://api.github.com/repos/psf/requests/issues/3387 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3387/labels{/name} | https://api.github.com/repos/psf/requests/issues/3387/comments | https://api.github.com/repos/psf/requests/issues/3387/events | https://github.com/psf/requests/pull/3387 | 163,887,442 | MDExOlB1bGxSZXF1ZXN0NzYzMDAzOTg= | 3,387 | fixing #3366 for non-str header values | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2016-07-05T16:06:41Z | 2021-09-08T03:00:59Z | 2016-07-05T16:41:43Z | MEMBER | resolved | This will fix issue #3386 with non-string/buffer header values, but there may be some more discussion to be had here. This is a passthrough for non-string/buffers which means all other datatypes will skip the regex check. I wasn't able to create the header split issue with most of the other standard datatypes I checked (lists, sets, dicts), so this _should_ be safe with the passthrough.
I think an alternative, and possibly better solution is to cast everything that isn't a byte string as a `str`, whether that be standard, or `encode('latin-1')`. This will ensure the check still runs and doesn't modify the value in the actual `Requests.headers` value. This is probably closer to what @sigmavirus24 already did [here](https://github.com/kennethreitz/requests/pull/866/files#diff-5956087d5835a57d9ef6fff974f6fd9bR273).
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3387/reactions"
} | https://api.github.com/repos/psf/requests/issues/3387/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3387.diff",
"html_url": "https://github.com/psf/requests/pull/3387",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/3387.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3387"
} | true | [
"@nateprewitt that pull request was _rejected_ precisely because integers are not defined behaviour within requests and haven't been for _years_.\n",
"Sorry, @sigmavirus24, I was suggesting something along this line for the check since it wouldn't be transforming the value in this case. I was trying to use this a... |
https://api.github.com/repos/psf/requests/issues/3386 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3386/labels{/name} | https://api.github.com/repos/psf/requests/issues/3386/comments | https://api.github.com/repos/psf/requests/issues/3386/events | https://github.com/psf/requests/issues/3386 | 163,870,374 | MDU6SXNzdWUxNjM4NzAzNzQ= | 3,386 | The keywords headers must be string or buffer in new version 2.10.0? | {
"avatar_url": "https://avatars.githubusercontent.com/u/12270732?v=4",
"events_url": "https://api.github.com/users/wut0n9/events{/privacy}",
"followers_url": "https://api.github.com/users/wut0n9/followers",
"following_url": "https://api.github.com/users/wut0n9/following{/other_user}",
"gists_url": "https://api.github.com/users/wut0n9/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/wut0n9",
"id": 12270732,
"login": "wut0n9",
"node_id": "MDQ6VXNlcjEyMjcwNzMy",
"organizations_url": "https://api.github.com/users/wut0n9/orgs",
"received_events_url": "https://api.github.com/users/wut0n9/received_events",
"repos_url": "https://api.github.com/users/wut0n9/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/wut0n9/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/wut0n9/subscriptions",
"type": "User",
"url": "https://api.github.com/users/wut0n9",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 7 | 2016-07-05T14:53:08Z | 2021-09-08T17:05:33Z | 2016-07-05T16:42:22Z | NONE | resolved | The keywords `headers` value must be string or buffer?
If the keywords `dnt` and `upgrade-insecure-requests` value is **string** or **buffer**, it's right,but the value is int,it's wrong.Why is that?
Right:
```
'dnt': '1',
'upgrade-insecure-requests': '1',
```
Wrong:
```
'dnt': 1,
'upgrade-insecure-requests': 1,
```
Why?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3386/reactions"
} | https://api.github.com/repos/psf/requests/issues/3386/timeline | null | completed | null | null | false | [
"@wut0n9 This behavioural change is not in v2.10.0, it's in the current master branch.\n\nHowever, that's a real bug: #3366 has regressed this. @nateprewitt, are you interested in trying to update with a fix for this?\n",
"Headers should always have been string. I don't think this is a significant regression if a... |
https://api.github.com/repos/psf/requests/issues/3385 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3385/labels{/name} | https://api.github.com/repos/psf/requests/issues/3385/comments | https://api.github.com/repos/psf/requests/issues/3385/events | https://github.com/psf/requests/pull/3385 | 163,801,538 | MDExOlB1bGxSZXF1ZXN0NzYyMzgzNTY= | 3,385 | Support responses like `HTTP/1.1 404 öööööööö` | {
"avatar_url": "https://avatars.githubusercontent.com/u/75169?v=4",
"events_url": "https://api.github.com/users/gugu/events{/privacy}",
"followers_url": "https://api.github.com/users/gugu/followers",
"following_url": "https://api.github.com/users/gugu/following{/other_user}",
"gists_url": "https://api.github.com/users/gugu/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/gugu",
"id": 75169,
"login": "gugu",
"node_id": "MDQ6VXNlcjc1MTY5",
"organizations_url": "https://api.github.com/users/gugu/orgs",
"received_events_url": "https://api.github.com/users/gugu/received_events",
"repos_url": "https://api.github.com/users/gugu/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/gugu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/gugu/subscriptions",
"type": "User",
"url": "https://api.github.com/users/gugu",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 18 | 2016-07-05T08:54:17Z | 2021-09-08T03:00:51Z | 2016-07-05T14:01:19Z | CONTRIBUTOR | resolved | Currently this code raises UnicodeDecodeError:
`requests.get('http://www.voice.fi//lampaan-kiveksia-ja-coca-cola-hulluutta-5-asiaa-joita-et-tiennyt-islannista-122015?utm_source=feed&utm_medium=feed&utm_content=article_link&utm_campaign=feed').ok`
Here is their status:
`HTTP/1.1 404 Komponenttia ei löydy`
This pull request allow module to handle URLs like this correctly
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3385/reactions"
} | https://api.github.com/repos/psf/requests/issues/3385/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3385.diff",
"html_url": "https://github.com/psf/requests/pull/3385",
"merged_at": "2016-07-05T14:01:19Z",
"patch_url": "https://github.com/psf/requests/pull/3385.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3385"
} | true | [
"Generally speaking I'm not too interested in supporting this kind of logic: servers are really not supposed to be sending non-ASCII-bytes in the reason phrase, and choosing to assume that UTF-8 is being used is really fairly optimistic.\n\nHowever, in the case of `raise_for_status`, we're exploding in a situation ... |
https://api.github.com/repos/psf/requests/issues/3384 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3384/labels{/name} | https://api.github.com/repos/psf/requests/issues/3384/comments | https://api.github.com/repos/psf/requests/issues/3384/events | https://github.com/psf/requests/issues/3384 | 163,502,741 | MDU6SXNzdWUxNjM1MDI3NDE= | 3,384 | Will requests bundle with future version of python? | {
"avatar_url": "https://avatars.githubusercontent.com/u/7894040?v=4",
"events_url": "https://api.github.com/users/KiYugadgeter/events{/privacy}",
"followers_url": "https://api.github.com/users/KiYugadgeter/followers",
"following_url": "https://api.github.com/users/KiYugadgeter/following{/other_user}",
"gists_url": "https://api.github.com/users/KiYugadgeter/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/KiYugadgeter",
"id": 7894040,
"login": "KiYugadgeter",
"node_id": "MDQ6VXNlcjc4OTQwNDA=",
"organizations_url": "https://api.github.com/users/KiYugadgeter/orgs",
"received_events_url": "https://api.github.com/users/KiYugadgeter/received_events",
"repos_url": "https://api.github.com/users/KiYugadgeter/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/KiYugadgeter/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/KiYugadgeter/subscriptions",
"type": "User",
"url": "https://api.github.com/users/KiYugadgeter",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2016-07-02T05:22:48Z | 2021-09-08T17:05:33Z | 2016-07-02T07:00:18Z | NONE | resolved | Will requests bundle with future version of python like pathlib?
I think urllib is not intuitive.
I hope that requests replace urllib as a intuitive high level http request module.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3384/reactions"
} | https://api.github.com/repos/psf/requests/issues/3384/timeline | null | completed | null | null | false | [
"Thanks for this question! The answer I'm afraid is \"no\". Requests is security-critical for most users, which means we need to be able to react quickly to security vulnerabilities and ensure that they reach all users. That's not possible if we're in the standard library because of its requirements on backward com... |
https://api.github.com/repos/psf/requests/issues/3383 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3383/labels{/name} | https://api.github.com/repos/psf/requests/issues/3383/comments | https://api.github.com/repos/psf/requests/issues/3383/events | https://github.com/psf/requests/pull/3383 | 163,490,531 | MDExOlB1bGxSZXF1ZXN0NzYwNDg3NDI= | 3,383 | Change exception and variable names so that tests will run. | {
"avatar_url": "https://avatars.githubusercontent.com/u/3794108?v=4",
"events_url": "https://api.github.com/users/davidsoncasey/events{/privacy}",
"followers_url": "https://api.github.com/users/davidsoncasey/followers",
"following_url": "https://api.github.com/users/davidsoncasey/following{/other_user}",
"gists_url": "https://api.github.com/users/davidsoncasey/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/davidsoncasey",
"id": 3794108,
"login": "davidsoncasey",
"node_id": "MDQ6VXNlcjM3OTQxMDg=",
"organizations_url": "https://api.github.com/users/davidsoncasey/orgs",
"received_events_url": "https://api.github.com/users/davidsoncasey/received_events",
"repos_url": "https://api.github.com/users/davidsoncasey/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/davidsoncasey/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/davidsoncasey/subscriptions",
"type": "User",
"url": "https://api.github.com/users/davidsoncasey",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2016-07-01T23:42:41Z | 2021-09-08T03:01:00Z | 2016-07-02T07:33:31Z | NONE | resolved | @Lukasa @sigmavirus24
I tried running the tests on the proposed/3.0.0 branch, and found that they did not run. So I changed a couple of variable names to fix the obvious errors. If you prefer InvalidSchema and MissingSchema I can change those back, I changed the imports to match the names of the exceptions as they were defined.
After these changes, there is still one failing test. I'll try to take a look and see if I can debug it. But this was low hanging fruit.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3383/reactions"
} | https://api.github.com/repos/psf/requests/issues/3383/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3383.diff",
"html_url": "https://github.com/psf/requests/pull/3383",
"merged_at": "2016-07-02T07:33:31Z",
"patch_url": "https://github.com/psf/requests/pull/3383.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3383"
} | true | [
"Looks good to me, thanks!\n"
] |
https://api.github.com/repos/psf/requests/issues/3382 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3382/labels{/name} | https://api.github.com/repos/psf/requests/issues/3382/comments | https://api.github.com/repos/psf/requests/issues/3382/events | https://github.com/psf/requests/pull/3382 | 163,467,405 | MDExOlB1bGxSZXF1ZXN0NzYwMzE3MDA= | 3,382 | updating iter_content docstring to match functionality | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2016-07-01T20:18:53Z | 2021-09-08T03:00:51Z | 2016-07-02T18:10:20Z | MEMBER | resolved | Sorry to be bombarding you guys with PRs. This one is pretty minor but explains what I would say was non-obvious behaviour of the function before PR #3368 and PR #3365.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3382/reactions"
} | https://api.github.com/repos/psf/requests/issues/3382/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3382.diff",
"html_url": "https://github.com/psf/requests/pull/3382",
"merged_at": "2016-07-02T18:10:20Z",
"patch_url": "https://github.com/psf/requests/pull/3382.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3382"
} | true | [
"So this isn't quite right. In particular, `iter_content` with `stream=True` and a chunk encoded response will iterate in chunk size. So it would be better for this to say that it iterates in chunks of undefined size. \n",
"Looks like I failed to set stream=True in my test case. I was misinterpreting the call to ... |
https://api.github.com/repos/psf/requests/issues/3371 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3371/labels{/name} | https://api.github.com/repos/psf/requests/issues/3371/comments | https://api.github.com/repos/psf/requests/issues/3371/events | https://github.com/psf/requests/pull/3371 | 163,427,961 | MDExOlB1bGxSZXF1ZXN0NzYwMDMyMjA= | 3,371 | Fix minor typo in README | {
"avatar_url": "https://avatars.githubusercontent.com/u/1977525?v=4",
"events_url": "https://api.github.com/users/jeremycline/events{/privacy}",
"followers_url": "https://api.github.com/users/jeremycline/followers",
"following_url": "https://api.github.com/users/jeremycline/following{/other_user}",
"gists_url": "https://api.github.com/users/jeremycline/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jeremycline",
"id": 1977525,
"login": "jeremycline",
"node_id": "MDQ6VXNlcjE5Nzc1MjU=",
"organizations_url": "https://api.github.com/users/jeremycline/orgs",
"received_events_url": "https://api.github.com/users/jeremycline/received_events",
"repos_url": "https://api.github.com/users/jeremycline/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jeremycline/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jeremycline/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jeremycline",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2016-07-01T16:12:55Z | 2021-09-08T03:01:01Z | 2016-07-01T16:15:16Z | CONTRIBUTOR | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3371/reactions"
} | https://api.github.com/repos/psf/requests/issues/3371/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3371.diff",
"html_url": "https://github.com/psf/requests/pull/3371",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/3371.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3371"
} | true | [
"That's not a typo. =) The sentence is \"One of the most downloaded Python packages of all time\".\n",
"Oooops. :coffee: \n"
] | |
https://api.github.com/repos/psf/requests/issues/3370 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3370/labels{/name} | https://api.github.com/repos/psf/requests/issues/3370/comments | https://api.github.com/repos/psf/requests/issues/3370/events | https://github.com/psf/requests/pull/3370 | 163,314,827 | MDExOlB1bGxSZXF1ZXN0NzU5MjQyMTg= | 3,370 | adding in slice_length fix and test for chunk_size=None | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 5 | 2016-07-01T03:55:18Z | 2021-09-08T02:10:13Z | 2016-07-02T20:56:20Z | MEMBER | resolved | This fixes the issue discussed in #3369 but may not be the best way. It adds a certain amount of additional complexity to iter_slices that may be better solved by using a try/except. If we throw an exception requiring an int for slice_length, we could pass `chunk_size or len(self._content)` [here](https://github.com/kennethreitz/requests/blob/master/requests/models.py#L691) and solve the issue that way as well.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3370/reactions"
} | https://api.github.com/repos/psf/requests/issues/3370/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3370.diff",
"html_url": "https://github.com/psf/requests/pull/3370",
"merged_at": "2016-07-02T20:56:20Z",
"patch_url": "https://github.com/psf/requests/pull/3370.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3370"
} | true | [
"I'm happy with this, but would like @sigmavirus24 to take a look as well.\n",
"Actually one quick note on this, it looks like we actually should have an integer > 0 as a requirement. slice_length <= 0 produces an infinite generator. I can modify the check if that's something you think should be caught (I do).\n"... |
https://api.github.com/repos/psf/requests/issues/3369 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3369/labels{/name} | https://api.github.com/repos/psf/requests/issues/3369/comments | https://api.github.com/repos/psf/requests/issues/3369/events | https://github.com/psf/requests/issues/3369 | 163,314,564 | MDU6SXNzdWUxNjMzMTQ1NjQ= | 3,369 | TypeError in iter_slices() when slice_length=None | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2016-07-01T03:52:10Z | 2021-09-08T17:05:33Z | 2016-07-03T03:29:16Z | MEMBER | resolved | An unintended side effect of using `chunk_size=None` (as referenced in PR #3368) is a failure in `iter_slices()`. The two code snippets below will both trigger [`reused_chunks` being chosen](https://github.com/kennethreitz/requests/blob/master/requests/models.py#L695) as the return value of `iter_content`. The generator is produced by `iter_slices` which currently requires the chunk_size to be an integer, otherwise it raises a TypeError when [trying to add an int and NoneType](https://github.com/kennethreitz/requests/blob/master/requests/utils.py#L388).
Perhaps these are obscure enough edge cases, that it's not an issue. I just wanted to make a quick note of it.
#### Examples
```
def test_stream():
s = requests.Session()
req = requests.Request('GET', 'https://httpbin.org/get').prepare()
resp = s.send(req, stream=False)
next(resp.iter_content(None))
def test_decode():
r = requests.Response()
r.raw = io.BytesIO(b'the content')
all_content = r.content
decoded_chunk = next(r.iter_content(None, True))
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3369/reactions"
} | https://api.github.com/repos/psf/requests/issues/3369/timeline | null | completed | null | null | false | [
"Why does `iter_slices` with `slice_length = None` not trigger a `TypeError`?\n",
"Sorry, I'm not sure I understand the question. I'm currently seeing the following error returned with both python2.7 and python3.5.\n\n`TypeError: unsupported operand type(s) for +: 'int' and 'NoneType'`\n\nA more direct code snipp... |
https://api.github.com/repos/psf/requests/issues/3368 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3368/labels{/name} | https://api.github.com/repos/psf/requests/issues/3368/comments | https://api.github.com/repos/psf/requests/issues/3368/events | https://github.com/psf/requests/pull/3368 | 163,293,541 | MDExOlB1bGxSZXF1ZXN0NzU5MDk3ODI= | 3,368 | Allow None value for chunk_size again | {
"avatar_url": "https://avatars.githubusercontent.com/u/1304895?v=4",
"events_url": "https://api.github.com/users/joyzheng/events{/privacy}",
"followers_url": "https://api.github.com/users/joyzheng/followers",
"following_url": "https://api.github.com/users/joyzheng/following{/other_user}",
"gists_url": "https://api.github.com/users/joyzheng/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/joyzheng",
"id": 1304895,
"login": "joyzheng",
"node_id": "MDQ6VXNlcjEzMDQ4OTU=",
"organizations_url": "https://api.github.com/users/joyzheng/orgs",
"received_events_url": "https://api.github.com/users/joyzheng/received_events",
"repos_url": "https://api.github.com/users/joyzheng/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/joyzheng/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/joyzheng/subscriptions",
"type": "User",
"url": "https://api.github.com/users/joyzheng",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2016-07-01T00:06:42Z | 2021-09-08T03:01:00Z | 2016-07-01T00:11:01Z | CONTRIBUTOR | resolved | Passing in `chunk_size=None` used to be fine, but started raising a `TypeError` following the addition of the type check (#3365)
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3368/reactions"
} | https://api.github.com/repos/psf/requests/issues/3368/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3368.diff",
"html_url": "https://github.com/psf/requests/pull/3368",
"merged_at": "2016-07-01T00:11:01Z",
"patch_url": "https://github.com/psf/requests/pull/3368.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3368"
} | true | [
"Thanks @joyzheng! :cake: \n",
"It may also be worth updating the `iter_content` docstring to reflect the \"readall\" behaviour with `iter_content(None)`.\n",
"Yeah, good point. I'm not actually sure about all the behavior cases for `iter_content(None)`, since it doesn't always result in reading the entire inpu... |
https://api.github.com/repos/psf/requests/issues/3367 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3367/labels{/name} | https://api.github.com/repos/psf/requests/issues/3367/comments | https://api.github.com/repos/psf/requests/issues/3367/events | https://github.com/psf/requests/issues/3367 | 163,098,513 | MDU6SXNzdWUxNjMwOTg1MTM= | 3,367 | Special IP proxy service timeout problems | {
"avatar_url": "https://avatars.githubusercontent.com/u/1249205?v=4",
"events_url": "https://api.github.com/users/toadzhou/events{/privacy}",
"followers_url": "https://api.github.com/users/toadzhou/followers",
"following_url": "https://api.github.com/users/toadzhou/following{/other_user}",
"gists_url": "https://api.github.com/users/toadzhou/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/toadzhou",
"id": 1249205,
"login": "toadzhou",
"node_id": "MDQ6VXNlcjEyNDkyMDU=",
"organizations_url": "https://api.github.com/users/toadzhou/orgs",
"received_events_url": "https://api.github.com/users/toadzhou/received_events",
"repos_url": "https://api.github.com/users/toadzhou/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/toadzhou/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/toadzhou/subscriptions",
"type": "User",
"url": "https://api.github.com/users/toadzhou",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 19 | 2016-06-30T07:26:06Z | 2021-09-08T15:00:54Z | 2016-09-06T00:01:54Z | NONE | resolved | ```
#cat checkip.py #To streamline the code
def check(ip, port, timeout=30):
proxies = {
"http": "http://%s:%s" % (ip, str(port)),
"https": "http://%s:%s" % (ip, str(port)),
}
requests.get(check_url, proxies=proxies, timeout=timeout, verify=False)
` #python2.7
>>> import requests
>>> requests.__version__
'2.10.0'
>>> from checkip import check
>>> check("164.132.52.143",3128,timeout=1)
False
>>> check("164.132.52.143",3128,timeout=10)
Here is the infinite waiting for...`
#ss #The state is ESTAB
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3367/reactions"
} | https://api.github.com/repos/psf/requests/issues/3367/timeline | null | completed | null | null | false | [
"@toadzhou Does this actually have anything to do with the timeout? If you change the second timeout to `1`, does the error still occur?\n",
"Of time is very short is no problem, the problem may appear in he has established a connection!\n",
"To be clear, if you're calling `requests.get` then there is no state ... |
https://api.github.com/repos/psf/requests/issues/3366 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3366/labels{/name} | https://api.github.com/repos/psf/requests/issues/3366/comments | https://api.github.com/repos/psf/requests/issues/3366/events | https://github.com/psf/requests/pull/3366 | 162,988,175 | MDExOlB1bGxSZXF1ZXN0NzU2OTMwMTY= | 3,366 | check for headers containing return characters | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 30 | 2016-06-29T17:57:41Z | 2021-09-08T03:00:49Z | 2016-07-02T19:32:17Z | MEMBER | resolved | Addresses issue raised in #2947.
This likely needs some tweaking. I added the check in `adapters.py` because it was the lowest level I could find header modification being done before sending. I'm not sure it actually needs to be this low though since it doesn't seem easily reachable with a non-`PreparedRequest` object.
Alternatively, we could move the check to the [`prepare_headers`](https://github.com/kennethreitz/requests/blob/master/requests/models.py#L406) method in `PreparedRequest`.
I also ignored `Accept` headers in the check because I the requirements in [RFC7230](https://tools.ietf.org/html/rfc7230#page-24) seems a bit vague.
> This specification deprecates such line folding except within the message/http media type
> (Section 8.3.1). A sender MUST NOT generate a message that includes line folding (i.e., that has any field-value that contains a match to the obs-fold rule) unless the message is intended for packaging
> within the message/http media type.
This may be a poor interpretation on my part though.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3366/reactions"
} | https://api.github.com/repos/psf/requests/issues/3366/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3366.diff",
"html_url": "https://github.com/psf/requests/pull/3366",
"merged_at": "2016-07-02T19:32:17Z",
"patch_url": "https://github.com/psf/requests/pull/3366.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3366"
} | true | [
"We should forbid the newline in Accept headers too: that is a misreading of RFC 7230. =) Otherwise, this is basically the right approach. Some notes:\n- Can we move the logic into a underscore-prefixed method on the HTTPAdapter? That will let people override the method if they need to.\n- Can we also search for li... |
https://api.github.com/repos/psf/requests/issues/3365 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3365/labels{/name} | https://api.github.com/repos/psf/requests/issues/3365/comments | https://api.github.com/repos/psf/requests/issues/3365/events | https://github.com/psf/requests/pull/3365 | 162,566,828 | MDExOlB1bGxSZXF1ZXN0NzUzOTM1MTE= | 3,365 | added in type check for chunk_size | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2016-06-27T22:55:25Z | 2021-09-08T02:10:19Z | 2016-06-28T07:33:29Z | MEMBER | resolved | This should raise a type error if a non-integer chunk_size is passed. I'm assuming we're not concerned about a chunk_size of type long, but that may be wrong. Resolves issue #3364
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3365/reactions"
} | https://api.github.com/repos/psf/requests/issues/3365/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3365.diff",
"html_url": "https://github.com/psf/requests/pull/3365",
"merged_at": "2016-06-28T07:33:29Z",
"patch_url": "https://github.com/psf/requests/pull/3365.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3365"
} | true | [
"Very nice @nateprewitt! Thanks! :sparkles: :cake: :sparkles:\n"
] |
https://api.github.com/repos/psf/requests/issues/3364 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3364/labels{/name} | https://api.github.com/repos/psf/requests/issues/3364/comments | https://api.github.com/repos/psf/requests/issues/3364/events | https://github.com/psf/requests/issues/3364 | 162,499,663 | MDU6SXNzdWUxNjI0OTk2NjM= | 3,364 | iter_content not chunking? | {
"avatar_url": "https://avatars.githubusercontent.com/u/541830?v=4",
"events_url": "https://api.github.com/users/coyotlinden/events{/privacy}",
"followers_url": "https://api.github.com/users/coyotlinden/followers",
"following_url": "https://api.github.com/users/coyotlinden/following{/other_user}",
"gists_url": "https://api.github.com/users/coyotlinden/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/coyotlinden",
"id": 541830,
"login": "coyotlinden",
"node_id": "MDQ6VXNlcjU0MTgzMA==",
"organizations_url": "https://api.github.com/users/coyotlinden/orgs",
"received_events_url": "https://api.github.com/users/coyotlinden/received_events",
"repos_url": "https://api.github.com/users/coyotlinden/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/coyotlinden/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/coyotlinden/subscriptions",
"type": "User",
"url": "https://api.github.com/users/coyotlinden",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 21 | 2016-06-27T16:59:26Z | 2021-09-08T17:05:34Z | 2016-06-28T07:33:39Z | NONE | resolved | I have code which is practically identical to the quickstart code:
```
with open(self.filename, 'wb') as fd:
for chunk in self.req.iter_content(self.chunk_size):
fd.write(chunk)
if self.progressbar:
self.in_queue.put(len(chunk))
```
where the queue is read in another thread by the GUI object and updates the progress bar. The problem that I have noticed is that despite the chunk_size being 1024, this code seems to wait until until the code is done and then puts the entire file size in the queue, defeating the point of providing the user with continuous progress on feedback.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3364/reactions"
} | https://api.github.com/repos/psf/requests/issues/3364/timeline | null | completed | null | null | false | [
"@coyotlinden Do you make the original requests call with `stream=True`?\n",
"Yes.\n\n```\nreq = requests.get(url, stream=True)\n```\n",
"@coyotlinden And that `req` is the same as the one that is called `self.req` elsewhere? How big is the file? Is the URL publicly available?\n",
"- Same `req`? Yes. The `re... |
https://api.github.com/repos/psf/requests/issues/3363 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3363/labels{/name} | https://api.github.com/repos/psf/requests/issues/3363/comments | https://api.github.com/repos/psf/requests/issues/3363/events | https://github.com/psf/requests/issues/3363 | 162,237,796 | MDU6SXNzdWUxNjIyMzc3OTY= | 3,363 | Add let's encrypt ca certificates to trusted certs | {
"avatar_url": "https://avatars.githubusercontent.com/u/5488440?v=4",
"events_url": "https://api.github.com/users/maxnoe/events{/privacy}",
"followers_url": "https://api.github.com/users/maxnoe/followers",
"following_url": "https://api.github.com/users/maxnoe/following{/other_user}",
"gists_url": "https://api.github.com/users/maxnoe/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/maxnoe",
"id": 5488440,
"login": "maxnoe",
"node_id": "MDQ6VXNlcjU0ODg0NDA=",
"organizations_url": "https://api.github.com/users/maxnoe/orgs",
"received_events_url": "https://api.github.com/users/maxnoe/received_events",
"repos_url": "https://api.github.com/users/maxnoe/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/maxnoe/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/maxnoe/subscriptions",
"type": "User",
"url": "https://api.github.com/users/maxnoe",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 9 | 2016-06-24T21:53:37Z | 2021-09-08T17:05:35Z | 2016-06-25T06:27:04Z | NONE | resolved | IMO requests should trust let's encrypt issued certs: www.letsencrypt.org
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3363/reactions"
} | https://api.github.com/repos/psf/requests/issues/3363/timeline | null | completed | null | null | false | [
"Do you have evidence that we don't?\n\n## If so, can you share the URL and version of requests, Python, and openssl?\n\nSent from my Android device with K-9 Mail. Please excuse my brevity.\n",
"Requests does trust LE: LE uses a cross signed root that we have chained up to for years. \n",
"MMh, then why do I ge... |
https://api.github.com/repos/psf/requests/issues/3362 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3362/labels{/name} | https://api.github.com/repos/psf/requests/issues/3362/comments | https://api.github.com/repos/psf/requests/issues/3362/events | https://github.com/psf/requests/pull/3362 | 162,147,196 | MDExOlB1bGxSZXF1ZXN0NzUxMTQyNDc= | 3,362 | adding asserted_encoding check on None type encoding to match text() … | {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2016-06-24T13:31:31Z | 2021-09-08T02:10:20Z | 2016-06-28T19:22:00Z | MEMBER | resolved | …behavior. Resolves #3359
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3362/reactions"
} | https://api.github.com/repos/psf/requests/issues/3362/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3362.diff",
"html_url": "https://github.com/psf/requests/pull/3362",
"merged_at": "2016-06-28T19:22:00Z",
"patch_url": "https://github.com/psf/requests/pull/3362.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3362"
} | true | [
"@Lukasa this looks good to me. What are your thoughts?\n",
"I think this looks good to me. @sigmavirus24 are you happy to merge this directly? I think I'd call the old behaviour a bug so I'd be fine with merging this for the next release.\n",
"Me too. Merging!\n"
] |
https://api.github.com/repos/psf/requests/issues/3361 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3361/labels{/name} | https://api.github.com/repos/psf/requests/issues/3361/comments | https://api.github.com/repos/psf/requests/issues/3361/events | https://github.com/psf/requests/pull/3361 | 161,837,576 | MDExOlB1bGxSZXF1ZXN0NzQ4OTQzODg= | 3,361 | Allow sending an unprepared request via session. | {
"avatar_url": "https://avatars.githubusercontent.com/u/416057?v=4",
"events_url": "https://api.github.com/users/jamielennox/events{/privacy}",
"followers_url": "https://api.github.com/users/jamielennox/followers",
"following_url": "https://api.github.com/users/jamielennox/following{/other_user}",
"gists_url": "https://api.github.com/users/jamielennox/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jamielennox",
"id": 416057,
"login": "jamielennox",
"node_id": "MDQ6VXNlcjQxNjA1Nw==",
"organizations_url": "https://api.github.com/users/jamielennox/orgs",
"received_events_url": "https://api.github.com/users/jamielennox/received_events",
"repos_url": "https://api.github.com/users/jamielennox/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jamielennox/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jamielennox/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jamielennox",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2016-06-23T04:25:28Z | 2021-09-08T03:01:01Z | 2016-06-23T06:06:56Z | NONE | resolved | This can be considered a request in the form of a PR because it was easier to make the code change than explain it.
I have multiple places where i am passing around method, url, json etc before it makes it to the requests level. Now these can all be bundled up into a single request object which is much easier to pass around, but then i have to manually call
prep = session.prepare_request(req)
settings = session.merge_environment_settings(....)
settings['timeout'] = timeout
session.send(prep, **settings)
Now it's not super hard, but it's something that happens by default doing request() and it's certainly not intuitive. If we add a send_request() which does exactly the same as request() just on an existing request object it makes it much easier to correctly use Request objects.
Note: If you like the idea but not the implementation and have something equivalent - please just do it your way. I don't care if this particular PR gets accepted or not if the idea gets up. I proposed this against 3.0 thinking it was going to be a more breaking change, but it seems pretty easy if you'd prefer i propose against master.
Thanks
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3361/reactions"
} | https://api.github.com/repos/psf/requests/issues/3361/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3361.diff",
"html_url": "https://github.com/psf/requests/pull/3361",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/3361.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3361"
} | true | [
"PreparedRequests should be suitable for accomplishing what you're trying to accomplish.\n\nI see where you're coming from, and thank you for your contribution. However, in short, no. :)\n\n@sigmavirus24 & @Lukasa are welcome to add additional thoughts, if desired.\n",
"I once thought about this too. Then I reali... |
https://api.github.com/repos/psf/requests/issues/3360 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3360/labels{/name} | https://api.github.com/repos/psf/requests/issues/3360/comments | https://api.github.com/repos/psf/requests/issues/3360/events | https://github.com/psf/requests/issues/3360 | 161,817,854 | MDU6SXNzdWUxNjE4MTc4NTQ= | 3,360 | Custom ResponseClass | {
"avatar_url": "https://avatars.githubusercontent.com/u/416057?v=4",
"events_url": "https://api.github.com/users/jamielennox/events{/privacy}",
"followers_url": "https://api.github.com/users/jamielennox/followers",
"following_url": "https://api.github.com/users/jamielennox/following{/other_user}",
"gists_url": "https://api.github.com/users/jamielennox/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jamielennox",
"id": 416057,
"login": "jamielennox",
"node_id": "MDQ6VXNlcjQxNjA1Nw==",
"organizations_url": "https://api.github.com/users/jamielennox/orgs",
"received_events_url": "https://api.github.com/users/jamielennox/received_events",
"repos_url": "https://api.github.com/users/jamielennox/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jamielennox/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jamielennox/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jamielennox",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2016-06-23T00:48:43Z | 2021-09-08T17:05:36Z | 2016-06-23T06:09:16Z | NONE | resolved | A common pattern in webob is allowing applications to define there own request and response class. This makes it easier to work with and expose attributes and methods that you will commonly use in your application. For example you can add properties for headers that are commonly used in your application.
Theoretically you could do the request side of this today subclassing requests.Request, however the more useful side here would be being able to specify a response class (it can be asserted that custom response class is a subclass of requests.Response).
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 1,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/psf/requests/issues/3360/reactions"
} | https://api.github.com/repos/psf/requests/issues/3360/timeline | null | completed | null | null | false | [
"Thank you for the idea, but again, in short brevity: no. :)\n",
"> For example you can add properties for headers that are commonly used in your application.\n\nYou could also do this with a separate response class (that takes a requests.Response) as a parameter and uses descriptors for that. OpenStack already h... |
https://api.github.com/repos/psf/requests/issues/3359 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3359/labels{/name} | https://api.github.com/repos/psf/requests/issues/3359/comments | https://api.github.com/repos/psf/requests/issues/3359/events | https://github.com/psf/requests/issues/3359 | 161,568,785 | MDU6SXNzdWUxNjE1Njg3ODU= | 3,359 | Uncertain about content/text vs iter_content(decode_unicode=True/False) | {
"avatar_url": "https://avatars.githubusercontent.com/u/48527?v=4",
"events_url": "https://api.github.com/users/mikepelley/events{/privacy}",
"followers_url": "https://api.github.com/users/mikepelley/followers",
"following_url": "https://api.github.com/users/mikepelley/following{/other_user}",
"gists_url": "https://api.github.com/users/mikepelley/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mikepelley",
"id": 48527,
"login": "mikepelley",
"node_id": "MDQ6VXNlcjQ4NTI3",
"organizations_url": "https://api.github.com/users/mikepelley/orgs",
"received_events_url": "https://api.github.com/users/mikepelley/received_events",
"repos_url": "https://api.github.com/users/mikepelley/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mikepelley/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mikepelley/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mikepelley",
"user_view_type": "public"
} | [
{
"color": "e10c02",
"default": false,
"description": null,
"id": 117744,
"name": "Bug",
"node_id": "MDU6TGFiZWwxMTc3NDQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Bug"
}
] | closed | true | null | [] | null | 15 | 2016-06-22T00:19:56Z | 2021-09-08T14:00:38Z | 2016-09-24T17:01:11Z | NONE | resolved | When requesting an application/json document, I'm seeing `next(r.iter_content(16*1024, decode_unicode=True))` returning bytes, whereas `r.text` returns unicode. My understanding was that both should return a unicode object. In essence, I thought "iter_content" was equivalent to "iter_text" when decode_unicode was True. Have I misunderstood something? I can provide an example if needed.
For reference, I'm using python 3.5.1 and requests 2.10.0.
Thanks!
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3359/reactions"
} | https://api.github.com/repos/psf/requests/issues/3359/timeline | null | completed | null | null | false | [
"what does (your response object).encoding return?\n",
"There's at least one key difference: `decode_unicode=True` doesn't fall back to `apparent_encoding`, which means it'll never autodetect the encoding. This means if `response.encoding` is None it is a no-op: in fact, it's a no-op that yields bytes.\n\nThat be... |
https://api.github.com/repos/psf/requests/issues/3358 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3358/labels{/name} | https://api.github.com/repos/psf/requests/issues/3358/comments | https://api.github.com/repos/psf/requests/issues/3358/events | https://github.com/psf/requests/pull/3358 | 161,512,593 | MDExOlB1bGxSZXF1ZXN0NzQ2NjU2OTQ= | 3,358 | Update list of supported Python versions in todo.rst | {
"avatar_url": "https://avatars.githubusercontent.com/u/1192314?v=4",
"events_url": "https://api.github.com/users/petedmarsh/events{/privacy}",
"followers_url": "https://api.github.com/users/petedmarsh/followers",
"following_url": "https://api.github.com/users/petedmarsh/following{/other_user}",
"gists_url": "https://api.github.com/users/petedmarsh/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/petedmarsh",
"id": 1192314,
"login": "petedmarsh",
"node_id": "MDQ6VXNlcjExOTIzMTQ=",
"organizations_url": "https://api.github.com/users/petedmarsh/orgs",
"received_events_url": "https://api.github.com/users/petedmarsh/received_events",
"repos_url": "https://api.github.com/users/petedmarsh/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/petedmarsh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/petedmarsh/subscriptions",
"type": "User",
"url": "https://api.github.com/users/petedmarsh",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2016-06-21T18:52:24Z | 2021-09-08T03:01:02Z | 2016-06-21T18:53:19Z | CONTRIBUTOR | resolved | Extremely minor change; I happened to notice that the list of supported Python versions in todo.rst was out-of-sync with the Python version classifiers in setup.py, this just puts it back in sync.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3358/reactions"
} | https://api.github.com/repos/psf/requests/issues/3358/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3358.diff",
"html_url": "https://github.com/psf/requests/pull/3358",
"merged_at": "2016-06-21T18:53:19Z",
"patch_url": "https://github.com/psf/requests/pull/3358.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3358"
} | true | [
"Thanks @petedmarsh! :sparkles: :cake: :sparkles:\n"
] |
https://api.github.com/repos/psf/requests/issues/3357 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3357/labels{/name} | https://api.github.com/repos/psf/requests/issues/3357/comments | https://api.github.com/repos/psf/requests/issues/3357/events | https://github.com/psf/requests/issues/3357 | 161,480,241 | MDU6SXNzdWUxNjE0ODAyNDE= | 3,357 | Adding DRY-ness in auth.py | {
"avatar_url": "https://avatars.githubusercontent.com/u/3393794?v=4",
"events_url": "https://api.github.com/users/ueg1990/events{/privacy}",
"followers_url": "https://api.github.com/users/ueg1990/followers",
"following_url": "https://api.github.com/users/ueg1990/following{/other_user}",
"gists_url": "https://api.github.com/users/ueg1990/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ueg1990",
"id": 3393794,
"login": "ueg1990",
"node_id": "MDQ6VXNlcjMzOTM3OTQ=",
"organizations_url": "https://api.github.com/users/ueg1990/orgs",
"received_events_url": "https://api.github.com/users/ueg1990/received_events",
"repos_url": "https://api.github.com/users/ueg1990/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ueg1990/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ueg1990/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ueg1990",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2016-06-21T16:19:04Z | 2021-09-08T17:05:36Z | 2016-06-21T16:52:58Z | CONTRIBUTOR | resolved | @sigmavirus24 mentioned that in auth.py, the magic method **ne** is technically not needed since != is implied from definition of **eq**. Would this be considered a useful update?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/3393794?v=4",
"events_url": "https://api.github.com/users/ueg1990/events{/privacy}",
"followers_url": "https://api.github.com/users/ueg1990/followers",
"following_url": "https://api.github.com/users/ueg1990/following{/other_user}",
"gists_url": "https://api.github.com/users/ueg1990/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ueg1990",
"id": 3393794,
"login": "ueg1990",
"node_id": "MDQ6VXNlcjMzOTM3OTQ=",
"organizations_url": "https://api.github.com/users/ueg1990/orgs",
"received_events_url": "https://api.github.com/users/ueg1990/received_events",
"repos_url": "https://api.github.com/users/ueg1990/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ueg1990/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ueg1990/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ueg1990",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3357/reactions"
} | https://api.github.com/repos/psf/requests/issues/3357/timeline | null | completed | null | null | false | [
"Have you checked that it's not necessary on Python 2.6? It might be necessary there.\n",
"You are right. It is needed in Python 2.6. \n"
] |
https://api.github.com/repos/psf/requests/issues/3356 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3356/labels{/name} | https://api.github.com/repos/psf/requests/issues/3356/comments | https://api.github.com/repos/psf/requests/issues/3356/events | https://github.com/psf/requests/pull/3356 | 161,476,877 | MDExOlB1bGxSZXF1ZXN0NzQ2Mzk3MjU= | 3,356 | Do not attempt to decode to unicode twice | {
"avatar_url": "https://avatars.githubusercontent.com/u/555959?v=4",
"events_url": "https://api.github.com/users/zachmullen/events{/privacy}",
"followers_url": "https://api.github.com/users/zachmullen/followers",
"following_url": "https://api.github.com/users/zachmullen/following{/other_user}",
"gists_url": "https://api.github.com/users/zachmullen/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/zachmullen",
"id": 555959,
"login": "zachmullen",
"node_id": "MDQ6VXNlcjU1NTk1OQ==",
"organizations_url": "https://api.github.com/users/zachmullen/orgs",
"received_events_url": "https://api.github.com/users/zachmullen/received_events",
"repos_url": "https://api.github.com/users/zachmullen/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/zachmullen/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zachmullen/subscriptions",
"type": "User",
"url": "https://api.github.com/users/zachmullen",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2016-06-21T16:04:23Z | 2021-09-08T03:01:02Z | 2016-06-21T16:05:40Z | NONE | resolved | It's possible I'm missing something here, but it seems like we should not be trying to decode via the underlying urllib3 method since `iter_content` is responsible for the decision of whether or not to decode.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3356/reactions"
} | https://api.github.com/repos/psf/requests/issues/3356/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3356.diff",
"html_url": "https://github.com/psf/requests/pull/3356",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/3356.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3356"
} | true | [
"Thanks for this!\n\nThe urllib3 decoding is about decoding compressed content-encodings like gzip and deflate. We do always want that on. =) iter_content's decoding is about decoding to unicode, an unrelated concern.\n",
"Ah, thank you for the explanation :)\n"
] |
https://api.github.com/repos/psf/requests/issues/3355 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3355/labels{/name} | https://api.github.com/repos/psf/requests/issues/3355/comments | https://api.github.com/repos/psf/requests/issues/3355/events | https://github.com/psf/requests/issues/3355 | 161,128,559 | MDU6SXNzdWUxNjExMjg1NTk= | 3,355 | 'True' payload in get cause problem | {
"avatar_url": "https://avatars.githubusercontent.com/u/1731864?v=4",
"events_url": "https://api.github.com/users/lufeihaidao/events{/privacy}",
"followers_url": "https://api.github.com/users/lufeihaidao/followers",
"following_url": "https://api.github.com/users/lufeihaidao/following{/other_user}",
"gists_url": "https://api.github.com/users/lufeihaidao/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/lufeihaidao",
"id": 1731864,
"login": "lufeihaidao",
"node_id": "MDQ6VXNlcjE3MzE4NjQ=",
"organizations_url": "https://api.github.com/users/lufeihaidao/orgs",
"received_events_url": "https://api.github.com/users/lufeihaidao/received_events",
"repos_url": "https://api.github.com/users/lufeihaidao/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/lufeihaidao/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lufeihaidao/subscriptions",
"type": "User",
"url": "https://api.github.com/users/lufeihaidao",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 7 | 2016-06-20T06:58:42Z | 2021-09-08T17:05:37Z | 2016-06-20T07:48:33Z | NONE | resolved | ``` python
payload = {'key1': 'value1', 'key2': True}
r = requests.get('http://httpbin.org/get', params=payload)
print(r.url)
# 'http://httpbin.org/get?key1=value1&key2=True'
```
With `key2` I wanna get a boolean param, but requests gives me 'True'. 'True' will be considered as a string in many frameworks.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3355/reactions"
} | https://api.github.com/repos/psf/requests/issues/3355/timeline | null | completed | null | null | false | [
"Is it a bug, or designed to be so?\n",
"@lufeihaidao HTTP query parameters are not typed: they are _all_ strings. There is no such thing as a boolean parameter in a query string. What do you think a boolean parameter is, in this context?\n",
"@Lukasa Sorry, in my app, `key2` is supposed to be a boolean field. ... |
https://api.github.com/repos/psf/requests/issues/3354 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3354/labels{/name} | https://api.github.com/repos/psf/requests/issues/3354/comments | https://api.github.com/repos/psf/requests/issues/3354/events | https://github.com/psf/requests/issues/3354 | 161,112,202 | MDU6SXNzdWUxNjExMTIyMDI= | 3,354 | Failed to establish a new connection: [Errno 65] No route to host | {
"avatar_url": "https://avatars.githubusercontent.com/u/4336119?v=4",
"events_url": "https://api.github.com/users/ljdawn/events{/privacy}",
"followers_url": "https://api.github.com/users/ljdawn/followers",
"following_url": "https://api.github.com/users/ljdawn/following{/other_user}",
"gists_url": "https://api.github.com/users/ljdawn/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ljdawn",
"id": 4336119,
"login": "ljdawn",
"node_id": "MDQ6VXNlcjQzMzYxMTk=",
"organizations_url": "https://api.github.com/users/ljdawn/orgs",
"received_events_url": "https://api.github.com/users/ljdawn/received_events",
"repos_url": "https://api.github.com/users/ljdawn/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ljdawn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ljdawn/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ljdawn",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2016-06-20T03:46:43Z | 2021-09-08T17:05:22Z | 2016-06-28T18:40:47Z | NONE | resolved | hi, I'm trying to
``` python
import requests
req = requests.Session()
headers = {'Referer':'https://archive.org/','User-Agent': 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:47.0) Gecko/20100101 Firefox/47.0'}
req.headers.update(headers)
res = req.get('https://archive.org/', headers=headers, timeout=20, proxies={'http': '52.192.0.225:8080'}, verify=False)
```
Then got ---------------------------------------------------------------------------
ConnectionError Traceback (most recent call last)
<ipython-input-23-1ddf77e531ff> in <module>()
3 headers = {'Referer':'https://archive.org/','User-Agent': 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:47.0) Gecko/20100101 Firefox/47.0'}
4 req.headers.update(headers)
----> 5 res = req.get('https://archive.org/', headers=headers, timeout=20, proxies={'http': '52.192.0.225:8080'}, verify=False)
/Users/test/env/lib/python2.7/site-packages/requests/sessions.pyc in get(self, url, *_kwargs)
485
486 kwargs.setdefault('allow_redirects', True)
--> 487 return self.request('GET', url, *_kwargs)
488
489 def options(self, url, **kwargs):
/Users/test/env/lib/python2.7/site-packages/requests/sessions.pyc in request(self, method, url, params, data, headers, cookies, files, auth, timeout, allow_redirects, proxies, hooks, stream, verify, cert, json)
473 }
474 send_kwargs.update(settings)
--> 475 resp = self.send(prep, **send_kwargs)
476
477 return resp
/Users/test/env/lib/python2.7/site-packages/requests/sessions.pyc in send(self, request, *_kwargs)
583
584 # Send the request
--> 585 r = adapter.send(request, *_kwargs)
586
587 # Total elapsed time of the request (approximately)
/Users/test/env/lib/python2.7/site-packages/requests/adapters.pyc in send(self, request, stream, timeout, verify, cert, proxies)
465 raise ProxyError(e, request=request)
466
--> 467 raise ConnectionError(e, request=request)
468
469 except ClosedPoolError as e:
ConnectionError: HTTPSConnectionPool(host='archive.org', port=443): Max retries exceeded with url: / (Caused by NewConnectionError('<requests.packages.urllib3.connection.VerifiedHTTPSConnection object at 0x105ea5fd0>: Failed to establish a new connection: [Errno 65] No route to host',))
I've tried to use proxies, set down the verify, but that does not work. Thank you
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3354/reactions"
} | https://api.github.com/repos/psf/requests/issues/3354/timeline | null | completed | null | null | false | [
"Your proxy configuration appears to be wrong: you've set up a proxy for only HTTP schemed addresses. Do you want to try changing your `req.get` request to be:\n\n``` python\nres = req.get('https://archive.org/', headers=headers, timeout=20, proxies={'http': 'http://52.192.0.225:8080', 'https': 'http://52.192.0.225... |
https://api.github.com/repos/psf/requests/issues/3353 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3353/labels{/name} | https://api.github.com/repos/psf/requests/issues/3353/comments | https://api.github.com/repos/psf/requests/issues/3353/events | https://github.com/psf/requests/issues/3353 | 161,044,323 | MDU6SXNzdWUxNjEwNDQzMjM= | 3,353 | get request hangs "in readinto return self._sock.recv_into(b)" without raising exception | {
"avatar_url": "https://avatars.githubusercontent.com/u/8951994?v=4",
"events_url": "https://api.github.com/users/FlxVctr/events{/privacy}",
"followers_url": "https://api.github.com/users/FlxVctr/followers",
"following_url": "https://api.github.com/users/FlxVctr/following{/other_user}",
"gists_url": "https://api.github.com/users/FlxVctr/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/FlxVctr",
"id": 8951994,
"login": "FlxVctr",
"node_id": "MDQ6VXNlcjg5NTE5OTQ=",
"organizations_url": "https://api.github.com/users/FlxVctr/orgs",
"received_events_url": "https://api.github.com/users/FlxVctr/received_events",
"repos_url": "https://api.github.com/users/FlxVctr/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/FlxVctr/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/FlxVctr/subscriptions",
"type": "User",
"url": "https://api.github.com/users/FlxVctr",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 20 | 2016-06-18T21:30:49Z | 2021-08-29T00:06:38Z | 2016-06-19T11:00:05Z | NONE | resolved | Hi,
I'm pretty desperately trying to nail down the reason that an url unshortener script is freezing from time to time.
I'm using requests with several head and get-requests, such as
```
with requests.Session as s:
r = s.get(url, allow_redirects=True, timeout=self.timeout, headers=self.headers, verify=False)
```
where self.timeout are 10 seconds and the headers just include a user-agent.
The request is called by a worker in a multiprocessing Pool with 10 workers that get's constantly feeded via Pool.imap() with a list of urls.
When keyboard interrupting I get from some of the workers the following Traceback:
```
Traceback (most recent call last):
File "---/dataprocessor.py", line 98, in try_unshorten_expanded_urls
result = unshorten_expanded_urls(tweet_dataframe_tuple)
File "---/dataprocessor.py", line 84, in unshorten_expanded_urls
'unshortened_url': u.unshorten(expanded_urls[i]),
File "---/unshorten.py", line 162, in unshorten
verify=False)
File "/home/ubuntu/miniconda3/envs/TQ/lib/python3.5/site-packages/requests/sessions.py", line 480, in get
return self.request('GET', url, **kwargs)
File "/home/ubuntu/miniconda3/envs/TQ/lib/python3.5/site-packages/requests/sessions.py", line 468, in request
resp = self.send(prep, **send_kwargs)
File "/home/ubuntu/miniconda3/envs/TQ/lib/python3.5/site-packages/requests/sessions.py", line 608, in send
r.content
File "/home/ubuntu/miniconda3/envs/TQ/lib/python3.5/site-packages/requests/models.py", line 737, in content
self._content = bytes().join(self.iter_content(CONTENT_CHUNK_SIZE)) or bytes()
File "/home/ubuntu/miniconda3/envs/TQ/lib/python3.5/site-packages/requests/models.py", line 660, in generate
for chunk in self.raw.stream(chunk_size, decode_content=True):
File "/home/ubuntu/miniconda3/envs/TQ/lib/python3.5/site-packages/requests/packages/urllib3/response.py", line 344, in stream
data = self.read(amt=amt, decode_content=decode_content)
File "/home/ubuntu/miniconda3/envs/TQ/lib/python3.5/site-packages/requests/packages/urllib3/response.py", line 301, in read
data = self._fp.read(amt)
File "/home/ubuntu/miniconda3/envs/TQ/lib/python3.5/http/client.py", line 433, in read
n = self.readinto(b)
File "/home/ubuntu/miniconda3/envs/TQ/lib/python3.5/http/client.py", line 473, in readinto
n = self.fp.readinto(b)
File "/home/ubuntu/miniconda3/envs/TQ/lib/python3.5/socket.py", line 575, in readinto
return self._sock.recv_into(b)
KeyboardInterrupt
```
If the function would raise an exception, I've made sure that it would be catched within the function so that it would not block the pool. But as it seems, `readinto` is just hanging here (for hours). I don't know whether this is related to #3066, as I am not familiar enough with the protocols or requests itself, so please excuse a duplicate if this should be one or if the error is my bad.
The freeze happened several times with the same batch of urls now.
I tried to find the exact url causing this freeze but did not succeed as the batch contains several thousand, though I've already excluded everything that exceeds a certain content length or does not have text as content type via a head request before the get.
I am running requests 2.10.0 with Python 3.5.1 in a miniconda environment installed via pip on an Ubuntu 14.04.
However, great library, hope this helps to make it better.
Cheers!
UPDATE:
Here the relevant code for the traceback (line 162 in unshorten.py):
``` python
def check_size_and_type(request_object, max_content_length):
try:
length = int(request_object.headers['content-length'])
except:
length = None
try:
type = str(request_object.headers['content-type'])
except:
type = ''
if ((length is None or length < max_content_length) and
(type.startswith('text/html') or
type.startswith('application/xhtml') or
type.startswith('text/xml'))):
return True
else:
return False
with requests.Session() as s:
r = s.head(url, allow_redirects=True,
timeout=self.timeout,
headers=self.headers,
verify=False)
if check_size_and_type(r, self.max_content_length):
r = s.get(url, allow_redirects=True,
timeout=self.timeout,
headers=self.headers,
verify=False)
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/8951994?v=4",
"events_url": "https://api.github.com/users/FlxVctr/events{/privacy}",
"followers_url": "https://api.github.com/users/FlxVctr/followers",
"following_url": "https://api.github.com/users/FlxVctr/following{/other_user}",
"gists_url": "https://api.github.com/users/FlxVctr/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/FlxVctr",
"id": 8951994,
"login": "FlxVctr",
"node_id": "MDQ6VXNlcjg5NTE5OTQ=",
"organizations_url": "https://api.github.com/users/FlxVctr/orgs",
"received_events_url": "https://api.github.com/users/FlxVctr/received_events",
"repos_url": "https://api.github.com/users/FlxVctr/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/FlxVctr/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/FlxVctr/subscriptions",
"type": "User",
"url": "https://api.github.com/users/FlxVctr",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3353/reactions"
} | https://api.github.com/repos/psf/requests/issues/3353/timeline | null | completed | null | null | false | [
"Thanks for this report!\n\nWhat worries me is that we're getting stuck even with a timeout. The timeout should prevent any socket call lasting longer than that number of seconds. This suggests two possibilities to me that _aren't_ bugs, as well as the possibility of a bug (though it's unlikely).\n\nFirstly, can yo... |
https://api.github.com/repos/psf/requests/issues/3342 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3342/labels{/name} | https://api.github.com/repos/psf/requests/issues/3342/comments | https://api.github.com/repos/psf/requests/issues/3342/events | https://github.com/psf/requests/pull/3342 | 160,953,189 | MDExOlB1bGxSZXF1ZXN0NzQyODkxNjQ= | 3,342 | fix PUT of empty (0 byte) stream | {
"avatar_url": "https://avatars.githubusercontent.com/u/423176?v=4",
"events_url": "https://api.github.com/users/nlevitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nlevitt/followers",
"following_url": "https://api.github.com/users/nlevitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nlevitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nlevitt",
"id": 423176,
"login": "nlevitt",
"node_id": "MDQ6VXNlcjQyMzE3Ng==",
"organizations_url": "https://api.github.com/users/nlevitt/orgs",
"received_events_url": "https://api.github.com/users/nlevitt/received_events",
"repos_url": "https://api.github.com/users/nlevitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nlevitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nlevitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nlevitt",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 5 | 2016-06-17T18:56:16Z | 2021-09-08T03:01:03Z | 2016-06-17T19:41:30Z | NONE | resolved | I found #3051 but I'm offering this anyway. It's a simple fix for what appears to be a simple oversight in the code.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3342/reactions"
} | https://api.github.com/repos/psf/requests/issues/3342/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3342.diff",
"html_url": "https://github.com/psf/requests/pull/3342",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/3342.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3342"
} | true | [
"Thanks for this!\n\nThis is not an oversight, it's entirely deliberate. We do this to handle the case that we have a body with indeterminate length (e.g. stdin) which reports its length as zero or throws errors when we try to work out how long it is. In this case, defaulting to transfer encoding chunked is sensibl... |
https://api.github.com/repos/psf/requests/issues/3341 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3341/labels{/name} | https://api.github.com/repos/psf/requests/issues/3341/comments | https://api.github.com/repos/psf/requests/issues/3341/events | https://github.com/psf/requests/issues/3341 | 160,872,751 | MDU6SXNzdWUxNjA4NzI3NTE= | 3,341 | Setting session.timeout doesn't do anything | {
"avatar_url": "https://avatars.githubusercontent.com/u/921251?v=4",
"events_url": "https://api.github.com/users/ikus060/events{/privacy}",
"followers_url": "https://api.github.com/users/ikus060/followers",
"following_url": "https://api.github.com/users/ikus060/following{/other_user}",
"gists_url": "https://api.github.com/users/ikus060/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ikus060",
"id": 921251,
"login": "ikus060",
"node_id": "MDQ6VXNlcjkyMTI1MQ==",
"organizations_url": "https://api.github.com/users/ikus060/orgs",
"received_events_url": "https://api.github.com/users/ikus060/received_events",
"repos_url": "https://api.github.com/users/ikus060/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ikus060/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ikus060/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ikus060",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 10 | 2016-06-17T11:59:21Z | 2018-07-02T14:53:32Z | 2016-06-17T12:10:50Z | NONE | resolved | I was using an old version of requests (I don't know the exact version). When settings the `session.timeout` it was affecting the timeout value during a call to `session.get()`. With recent version of requests, this feature doesn't seams to work.
I'm currently using version 2.10.0
Basically, I'm expecting this:
```
session = requests.session()
session.timeout = 0.0001
session.get('http://localhost/')
```
To have the same behavior as:
```
requests.get('http://localhost/', timeout=0.0001)
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3341/reactions"
} | https://api.github.com/repos/psf/requests/issues/3341/timeline | null | completed | null | null | false | [
"This behaviour was deliberately changed: see #2856, and #2011 which have discussion on them.\n",
"And to be clear, that version must have been prior to 1.0 when this behaviour was removed.\n",
"After reading both issues, I still don't understand why it's not supported. What is the rational behind this decision... |
https://api.github.com/repos/psf/requests/issues/3340 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3340/labels{/name} | https://api.github.com/repos/psf/requests/issues/3340/comments | https://api.github.com/repos/psf/requests/issues/3340/events | https://github.com/psf/requests/issues/3340 | 160,807,249 | MDU6SXNzdWUxNjA4MDcyNDk= | 3,340 | use the paypal in mac os x has the problem about sslv3 | {
"avatar_url": "https://avatars.githubusercontent.com/u/13331694?v=4",
"events_url": "https://api.github.com/users/iLaus/events{/privacy}",
"followers_url": "https://api.github.com/users/iLaus/followers",
"following_url": "https://api.github.com/users/iLaus/following{/other_user}",
"gists_url": "https://api.github.com/users/iLaus/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/iLaus",
"id": 13331694,
"login": "iLaus",
"node_id": "MDQ6VXNlcjEzMzMxNjk0",
"organizations_url": "https://api.github.com/users/iLaus/orgs",
"received_events_url": "https://api.github.com/users/iLaus/received_events",
"repos_url": "https://api.github.com/users/iLaus/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/iLaus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/iLaus/subscriptions",
"type": "User",
"url": "https://api.github.com/users/iLaus",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2016-06-17T03:53:00Z | 2021-09-08T17:05:37Z | 2016-06-17T07:38:00Z | NONE | resolved | requests.exceptions.SSLError: [SSL: SSLV3_ALERT_HANDSHAKE_FAILURE] sslv3 alert handshake failure (_ssl.c:600)
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3340/reactions"
} | https://api.github.com/repos/psf/requests/issues/3340/timeline | null | completed | null | null | false | [
"I have change the terminal's openssl version,\n\nkingwangdeMini:icampuslist_web kingwang$ openssl version\nOpenSSL 1.0.2d 9 Jul 2015\n\nbut my python's openssl version is still old version：\n\nkingwangdeMini:icampuslist_web kingwang$ python -c \"import ssl; print(ssl.OPENSSL_VERSION)\"\nOpenSSL 0.9.8zg 14 July 201... |
https://api.github.com/repos/psf/requests/issues/3339 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3339/labels{/name} | https://api.github.com/repos/psf/requests/issues/3339/comments | https://api.github.com/repos/psf/requests/issues/3339/events | https://github.com/psf/requests/pull/3339 | 160,747,845 | MDExOlB1bGxSZXF1ZXN0NzQxNDI1NjQ= | 3,339 | Use seek from end rather than getvalue | {
"avatar_url": "https://avatars.githubusercontent.com/u/296164?v=4",
"events_url": "https://api.github.com/users/jseabold/events{/privacy}",
"followers_url": "https://api.github.com/users/jseabold/followers",
"following_url": "https://api.github.com/users/jseabold/following{/other_user}",
"gists_url": "https://api.github.com/users/jseabold/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jseabold",
"id": 296164,
"login": "jseabold",
"node_id": "MDQ6VXNlcjI5NjE2NA==",
"organizations_url": "https://api.github.com/users/jseabold/orgs",
"received_events_url": "https://api.github.com/users/jseabold/received_events",
"repos_url": "https://api.github.com/users/jseabold/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jseabold/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jseabold/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jseabold",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 11 | 2016-06-16T20:00:58Z | 2021-09-08T03:00:45Z | 2016-08-24T18:02:00Z | NONE | resolved | Avoids having the (potentially large) object in memory twice.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/296164?v=4",
"events_url": "https://api.github.com/users/jseabold/events{/privacy}",
"followers_url": "https://api.github.com/users/jseabold/followers",
"following_url": "https://api.github.com/users/jseabold/following{/other_user}",
"gists_url": "https://api.github.com/users/jseabold/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jseabold",
"id": 296164,
"login": "jseabold",
"node_id": "MDQ6VXNlcjI5NjE2NA==",
"organizations_url": "https://api.github.com/users/jseabold/orgs",
"received_events_url": "https://api.github.com/users/jseabold/received_events",
"repos_url": "https://api.github.com/users/jseabold/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jseabold/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jseabold/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jseabold",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3339/reactions"
} | https://api.github.com/repos/psf/requests/issues/3339/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3339.diff",
"html_url": "https://github.com/psf/requests/pull/3339",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/3339.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3339"
} | true | [
"Thanks for this patch!\n\nAs composed, however, this patch doesn't make sense. The code block tests for `getvalue()` but then uses two unrelated methods.\n\nIt might be better to have a separate block that tests for `seek()` and `tell()` and then use those in that block, considering that a higher priority than `ge... |
https://api.github.com/repos/psf/requests/issues/3338 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3338/labels{/name} | https://api.github.com/repos/psf/requests/issues/3338/comments | https://api.github.com/repos/psf/requests/issues/3338/events | https://github.com/psf/requests/pull/3338 | 160,706,362 | MDExOlB1bGxSZXF1ZXN0NzQxMTMwNTc= | 3,338 | Refactor prepare body | {
"avatar_url": "https://avatars.githubusercontent.com/u/3794108?v=4",
"events_url": "https://api.github.com/users/davidsoncasey/events{/privacy}",
"followers_url": "https://api.github.com/users/davidsoncasey/followers",
"following_url": "https://api.github.com/users/davidsoncasey/following{/other_user}",
"gists_url": "https://api.github.com/users/davidsoncasey/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/davidsoncasey",
"id": 3794108,
"login": "davidsoncasey",
"node_id": "MDQ6VXNlcjM3OTQxMDg=",
"organizations_url": "https://api.github.com/users/davidsoncasey/orgs",
"received_events_url": "https://api.github.com/users/davidsoncasey/received_events",
"repos_url": "https://api.github.com/users/davidsoncasey/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/davidsoncasey/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/davidsoncasey/subscriptions",
"type": "User",
"url": "https://api.github.com/users/davidsoncasey",
"user_view_type": "public"
} | [
{
"color": "d4c5f9",
"default": false,
"description": null,
"id": 536793543,
"name": "needs rebase",
"node_id": "MDU6TGFiZWw1MzY3OTM1NDM=",
"url": "https://api.github.com/repos/psf/requests/labels/needs%20rebase"
}
] | closed | true | null | [] | {
"closed_at": null,
"closed_issues": 29,
"created_at": "2013-11-17T11:29:34Z",
"creator": {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
},
"description": null,
"due_on": null,
"html_url": "https://github.com/psf/requests/milestone/20",
"id": 487518,
"labels_url": "https://api.github.com/repos/psf/requests/milestones/20/labels",
"node_id": "MDk6TWlsZXN0b25lNDg3NTE4",
"number": 20,
"open_issues": 12,
"state": "open",
"title": "3.0.0",
"updated_at": "2024-05-19T18:43:00Z",
"url": "https://api.github.com/repos/psf/requests/milestones/20"
} | 9 | 2016-06-16T16:38:33Z | 2021-09-07T00:06:30Z | 2017-03-01T17:25:30Z | NONE | resolved | PR for proposed/3.0 with refactoring of `prepare_body` method. For discussion see #3184.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/3794108?v=4",
"events_url": "https://api.github.com/users/davidsoncasey/events{/privacy}",
"followers_url": "https://api.github.com/users/davidsoncasey/followers",
"following_url": "https://api.github.com/users/davidsoncasey/following{/other_user}",
"gists_url": "https://api.github.com/users/davidsoncasey/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/davidsoncasey",
"id": 3794108,
"login": "davidsoncasey",
"node_id": "MDQ6VXNlcjM3OTQxMDg=",
"organizations_url": "https://api.github.com/users/davidsoncasey/orgs",
"received_events_url": "https://api.github.com/users/davidsoncasey/received_events",
"repos_url": "https://api.github.com/users/davidsoncasey/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/davidsoncasey/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/davidsoncasey/subscriptions",
"type": "User",
"url": "https://api.github.com/users/davidsoncasey",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3338/reactions"
} | https://api.github.com/repos/psf/requests/issues/3338/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3338.diff",
"html_url": "https://github.com/psf/requests/pull/3338",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/3338.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3338"
} | true | [
"I can take a look tonight and see if I can fix the conflict.\n",
"@Lukasa @nateprewitt I sort of forgot that this PR has been hanging out - is this still something we'd like to merge in? I can see about getting the conflicts fixed. Sorry I sort of lost momentum working on requests, I switched jobs and don't get ... |
https://api.github.com/repos/psf/requests/issues/3337 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3337/labels{/name} | https://api.github.com/repos/psf/requests/issues/3337/comments | https://api.github.com/repos/psf/requests/issues/3337/events | https://github.com/psf/requests/issues/3337 | 160,415,540 | MDU6SXNzdWUxNjA0MTU1NDA= | 3,337 | SSLError: [Errno bad handshake] (-1, 'Unexpected EOF') | {
"avatar_url": "https://avatars.githubusercontent.com/u/15658015?v=4",
"events_url": "https://api.github.com/users/PabloLefort/events{/privacy}",
"followers_url": "https://api.github.com/users/PabloLefort/followers",
"following_url": "https://api.github.com/users/PabloLefort/following{/other_user}",
"gists_url": "https://api.github.com/users/PabloLefort/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/PabloLefort",
"id": 15658015,
"login": "PabloLefort",
"node_id": "MDQ6VXNlcjE1NjU4MDE1",
"organizations_url": "https://api.github.com/users/PabloLefort/orgs",
"received_events_url": "https://api.github.com/users/PabloLefort/received_events",
"repos_url": "https://api.github.com/users/PabloLefort/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/PabloLefort/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/PabloLefort/subscriptions",
"type": "User",
"url": "https://api.github.com/users/PabloLefort",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 9 | 2016-06-15T12:58:03Z | 2021-09-08T08:00:40Z | 2016-06-27T14:42:02Z | NONE | resolved | Hi, i have a service for send email through SMTP with [Mandrill](https://mandrillapp.com).
``` python
# Service
from django.core.mail import EmailMessage
e = EmailMessage('test subject', 'test message', 'test@mail.com', ['me@me.com'])
e.send()
```
Throws this exception trace:
``` python
Traceback (most recent call last):
File "<input>", line 1, in <module>
File "/opt/apps/project/virtualenv/project/lib/python2.7/site-packages/django/core/mail/message.py", line 286, in send
return self.get_connection(fail_silently).send_messages([self])
File "/opt/apps/project/virtualenv/project/lib/python2.7/site-packages/djrill/mail/backends/djrill.py", line 68, in send_messages
sent = self._send(message)
File "/opt/apps/project/virtualenv/project/lib/python2.7/site-packages/djrill/mail/backends/djrill.py", line 107, in _send
response = requests.post(api_url, data=json.dumps(api_params, cls=JSONDateUTCEncoder))
File "/opt/apps/project/virtualenv/project/lib/python2.7/site-packages/requests/api.py", line 109, in post
return request('post', url, data=data, json=json, **kwargs)
File "/opt/apps/project/virtualenv/project/lib/python2.7/site-packages/requests/api.py", line 50, in request
response = session.request(method=method, url=url, **kwargs)
File "/opt/apps/project/virtualenv/project/lib/python2.7/site-packages/requests/sessions.py", line 465, in request
resp = self.send(prep, **send_kwargs)
File "/opt/apps/project/virtualenv/project/lib/python2.7/site-packages/requests/sessions.py", line 573, in send
r = adapter.send(request, **kwargs)
File "/opt/apps/project/virtualenv/project/lib/python2.7/site-packages/requests/adapters.py", line 431, in send
raise SSLError(e, request=request)
SSLError: [Errno bad handshake] (-1, 'Unexpected EOF')
```
Env: Red Hat 4.8.2-13, Python: 2.7.5
Libs:
```
Django==1.7.4
requests==2.7.0
djrill==1.3.0
pyOpenSSL==0.14
```
Any suggestions?
Going with [this](http://stackoverflow.com/questions/29504955/send-requests-to-twitter-with-requests-requests-exceptions-sslerror-errno) answer did not change anything.
Thanks in advance.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/15658015?v=4",
"events_url": "https://api.github.com/users/PabloLefort/events{/privacy}",
"followers_url": "https://api.github.com/users/PabloLefort/followers",
"following_url": "https://api.github.com/users/PabloLefort/following{/other_user}",
"gists_url": "https://api.github.com/users/PabloLefort/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/PabloLefort",
"id": 15658015,
"login": "PabloLefort",
"node_id": "MDQ6VXNlcjE1NjU4MDE1",
"organizations_url": "https://api.github.com/users/PabloLefort/orgs",
"received_events_url": "https://api.github.com/users/PabloLefort/received_events",
"repos_url": "https://api.github.com/users/PabloLefort/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/PabloLefort/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/PabloLefort/subscriptions",
"type": "User",
"url": "https://api.github.com/users/PabloLefort",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3337/reactions"
} | https://api.github.com/repos/psf/requests/issues/3337/timeline | null | completed | null | null | false | [
"Unexpected EOF in this instance almost certainly means that there is a problem with your TLS handshake, and the server just tore the connection down rather than establish the TLS connection.\n\nFirstly, you should install pyasn1 and ndg-httpsclient in addition to your current libraries: that will resolve your poss... |
https://api.github.com/repos/psf/requests/issues/3336 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3336/labels{/name} | https://api.github.com/repos/psf/requests/issues/3336/comments | https://api.github.com/repos/psf/requests/issues/3336/events | https://github.com/psf/requests/pull/3336 | 160,391,829 | MDExOlB1bGxSZXF1ZXN0NzM4ODkzMDY= | 3,336 | Merge remote-tracking branch 'refs/remotes/kennethreitz/master' | {
"avatar_url": "https://avatars.githubusercontent.com/u/1407528?v=4",
"events_url": "https://api.github.com/users/hyokosdeveloper/events{/privacy}",
"followers_url": "https://api.github.com/users/hyokosdeveloper/followers",
"following_url": "https://api.github.com/users/hyokosdeveloper/following{/other_user}",
"gists_url": "https://api.github.com/users/hyokosdeveloper/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/hyokosdeveloper",
"id": 1407528,
"login": "hyokosdeveloper",
"node_id": "MDQ6VXNlcjE0MDc1Mjg=",
"organizations_url": "https://api.github.com/users/hyokosdeveloper/orgs",
"received_events_url": "https://api.github.com/users/hyokosdeveloper/received_events",
"repos_url": "https://api.github.com/users/hyokosdeveloper/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/hyokosdeveloper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hyokosdeveloper/subscriptions",
"type": "User",
"url": "https://api.github.com/users/hyokosdeveloper",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 0 | 2016-06-15T10:44:03Z | 2021-09-08T03:01:04Z | 2016-06-15T10:44:25Z | NONE | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/1407528?v=4",
"events_url": "https://api.github.com/users/hyokosdeveloper/events{/privacy}",
"followers_url": "https://api.github.com/users/hyokosdeveloper/followers",
"following_url": "https://api.github.com/users/hyokosdeveloper/following{/other_user}",
"gists_url": "https://api.github.com/users/hyokosdeveloper/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/hyokosdeveloper",
"id": 1407528,
"login": "hyokosdeveloper",
"node_id": "MDQ6VXNlcjE0MDc1Mjg=",
"organizations_url": "https://api.github.com/users/hyokosdeveloper/orgs",
"received_events_url": "https://api.github.com/users/hyokosdeveloper/received_events",
"repos_url": "https://api.github.com/users/hyokosdeveloper/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/hyokosdeveloper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hyokosdeveloper/subscriptions",
"type": "User",
"url": "https://api.github.com/users/hyokosdeveloper",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3336/reactions"
} | https://api.github.com/repos/psf/requests/issues/3336/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3336.diff",
"html_url": "https://github.com/psf/requests/pull/3336",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/3336.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3336"
} | true | [] | |
https://api.github.com/repos/psf/requests/issues/3335 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3335/labels{/name} | https://api.github.com/repos/psf/requests/issues/3335/comments | https://api.github.com/repos/psf/requests/issues/3335/events | https://github.com/psf/requests/pull/3335 | 160,390,960 | MDExOlB1bGxSZXF1ZXN0NzM4ODg2NDg= | 3,335 | Merge remote-tracking branch 'refs/remotes/kennethreitz/master' | {
"avatar_url": "https://avatars.githubusercontent.com/u/1407528?v=4",
"events_url": "https://api.github.com/users/hyokosdeveloper/events{/privacy}",
"followers_url": "https://api.github.com/users/hyokosdeveloper/followers",
"following_url": "https://api.github.com/users/hyokosdeveloper/following{/other_user}",
"gists_url": "https://api.github.com/users/hyokosdeveloper/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/hyokosdeveloper",
"id": 1407528,
"login": "hyokosdeveloper",
"node_id": "MDQ6VXNlcjE0MDc1Mjg=",
"organizations_url": "https://api.github.com/users/hyokosdeveloper/orgs",
"received_events_url": "https://api.github.com/users/hyokosdeveloper/received_events",
"repos_url": "https://api.github.com/users/hyokosdeveloper/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/hyokosdeveloper/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hyokosdeveloper/subscriptions",
"type": "User",
"url": "https://api.github.com/users/hyokosdeveloper",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2016-06-15T10:39:04Z | 2016-06-15T10:43:55Z | 2016-06-15T10:41:03Z | NONE | null | null | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3335/reactions"
} | https://api.github.com/repos/psf/requests/issues/3335/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3335.diff",
"html_url": "https://github.com/psf/requests/pull/3335",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/3335.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3335"
} | true | [
"h\n"
] |
https://api.github.com/repos/psf/requests/issues/3334 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3334/labels{/name} | https://api.github.com/repos/psf/requests/issues/3334/comments | https://api.github.com/repos/psf/requests/issues/3334/events | https://github.com/psf/requests/issues/3334 | 160,260,450 | MDU6SXNzdWUxNjAyNjA0NTA= | 3,334 | 500 error when using request.get() | {
"avatar_url": "https://avatars.githubusercontent.com/u/1102722?v=4",
"events_url": "https://api.github.com/users/pramud/events{/privacy}",
"followers_url": "https://api.github.com/users/pramud/followers",
"following_url": "https://api.github.com/users/pramud/following{/other_user}",
"gists_url": "https://api.github.com/users/pramud/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/pramud",
"id": 1102722,
"login": "pramud",
"node_id": "MDQ6VXNlcjExMDI3MjI=",
"organizations_url": "https://api.github.com/users/pramud/orgs",
"received_events_url": "https://api.github.com/users/pramud/received_events",
"repos_url": "https://api.github.com/users/pramud/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/pramud/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pramud/subscriptions",
"type": "User",
"url": "https://api.github.com/users/pramud",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 0 | 2016-06-14T19:10:50Z | 2016-06-14T19:27:40Z | 2016-06-14T19:10:57Z | NONE | null | I am new to requests and python I'm trying to run the following code but getting 500 Server Error.
import requests
url = 'https://developers.zomato.com/api/v2.1/categories'
r = requests.get(url,headers={'user-key':'apikey'})
print(r)
print(r.content)
print(r.headers)
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1102722?v=4",
"events_url": "https://api.github.com/users/pramud/events{/privacy}",
"followers_url": "https://api.github.com/users/pramud/followers",
"following_url": "https://api.github.com/users/pramud/following{/other_user}",
"gists_url": "https://api.github.com/users/pramud/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/pramud",
"id": 1102722,
"login": "pramud",
"node_id": "MDQ6VXNlcjExMDI3MjI=",
"organizations_url": "https://api.github.com/users/pramud/orgs",
"received_events_url": "https://api.github.com/users/pramud/received_events",
"repos_url": "https://api.github.com/users/pramud/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/pramud/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pramud/subscriptions",
"type": "User",
"url": "https://api.github.com/users/pramud",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3334/reactions"
} | https://api.github.com/repos/psf/requests/issues/3334/timeline | null | completed | null | null | false | [] |
https://api.github.com/repos/psf/requests/issues/3333 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3333/labels{/name} | https://api.github.com/repos/psf/requests/issues/3333/comments | https://api.github.com/repos/psf/requests/issues/3333/events | https://github.com/psf/requests/issues/3333 | 160,257,771 | MDU6SXNzdWUxNjAyNTc3NzE= | 3,333 | 500 error when using requests.get() | {
"avatar_url": "https://avatars.githubusercontent.com/u/1102722?v=4",
"events_url": "https://api.github.com/users/pramud/events{/privacy}",
"followers_url": "https://api.github.com/users/pramud/followers",
"following_url": "https://api.github.com/users/pramud/following{/other_user}",
"gists_url": "https://api.github.com/users/pramud/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/pramud",
"id": 1102722,
"login": "pramud",
"node_id": "MDQ6VXNlcjExMDI3MjI=",
"organizations_url": "https://api.github.com/users/pramud/orgs",
"received_events_url": "https://api.github.com/users/pramud/received_events",
"repos_url": "https://api.github.com/users/pramud/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/pramud/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pramud/subscriptions",
"type": "User",
"url": "https://api.github.com/users/pramud",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2016-06-14T18:57:36Z | 2016-06-14T19:27:48Z | 2016-06-14T19:08:58Z | NONE | null | I am new to requests and python I'm trying to run the following code but getting 500 Server Error.
import requests
url = 'https://developers.zomato.com/api/v2.1/categories'
r = requests.get(url,headers={'user-key':'apikey'})
print(r)
print(r.content)
print(r.headers)
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1102722?v=4",
"events_url": "https://api.github.com/users/pramud/events{/privacy}",
"followers_url": "https://api.github.com/users/pramud/followers",
"following_url": "https://api.github.com/users/pramud/following{/other_user}",
"gists_url": "https://api.github.com/users/pramud/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/pramud",
"id": 1102722,
"login": "pramud",
"node_id": "MDQ6VXNlcjExMDI3MjI=",
"organizations_url": "https://api.github.com/users/pramud/orgs",
"received_events_url": "https://api.github.com/users/pramud/received_events",
"repos_url": "https://api.github.com/users/pramud/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/pramud/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pramud/subscriptions",
"type": "User",
"url": "https://api.github.com/users/pramud",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3333/reactions"
} | https://api.github.com/repos/psf/requests/issues/3333/timeline | null | completed | null | null | false | [
"The issue is with zomato api. Adding the user agent made it work.\n"
] |
https://api.github.com/repos/psf/requests/issues/3332 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3332/labels{/name} | https://api.github.com/repos/psf/requests/issues/3332/comments | https://api.github.com/repos/psf/requests/issues/3332/events | https://github.com/psf/requests/issues/3332 | 159,975,149 | MDU6SXNzdWUxNTk5NzUxNDk= | 3,332 | Downloading gzipped files causes ChunkEncodingErrors, ProtocolErrors, and ConnectionResetErrors on Windows 10 | {
"avatar_url": "https://avatars.githubusercontent.com/u/7537841?v=4",
"events_url": "https://api.github.com/users/siennathesane/events{/privacy}",
"followers_url": "https://api.github.com/users/siennathesane/followers",
"following_url": "https://api.github.com/users/siennathesane/following{/other_user}",
"gists_url": "https://api.github.com/users/siennathesane/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/siennathesane",
"id": 7537841,
"login": "siennathesane",
"node_id": "MDQ6VXNlcjc1Mzc4NDE=",
"organizations_url": "https://api.github.com/users/siennathesane/orgs",
"received_events_url": "https://api.github.com/users/siennathesane/received_events",
"repos_url": "https://api.github.com/users/siennathesane/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/siennathesane/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/siennathesane/subscriptions",
"type": "User",
"url": "https://api.github.com/users/siennathesane",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 6 | 2016-06-13T15:15:42Z | 2021-09-04T00:06:30Z | 2016-08-05T07:46:28Z | NONE | resolved | I was trying to download a remote gzipped JSON file from my Win10 box using Python 3.5.1 and 2.7.11, and it kept erroring out. The remote content-encoding header is gzip. I tried using requests 2.9.2 and 2.10.0 on both versions of Python, installed in a virtualenv with pip. I tried the same code on Linux, it doesn't error out at all. I'm not sure if it's requests or Python which causes the problem, so I wanted to start here, since the problem definitely exists specifically on Windows.
With this code (chunk_size does not matter):
``` python
data = requests.get(url, stream=True)
with open(url.rsplit("/")[-1], "wb") as fh:
for chunk in data.iter_content(chunk_size=1024):
fh.write(chunk)
```
I would inconsistently get this trace back:
``` python
Traceback (most recent call last):
File "H:\Programming\Python\virtualenvs\warehouse\lib\site-packages\requests\packages\urllib3\response.py", line 228, in _error_catcher
yield
File "H:\Programming\Python\virtualenvs\warehouse\lib\site-packages\requests\packages\urllib3\response.py", line 501, in read_chunked
chunk = self._handle_chunk(amt)
File "H:\Programming\Python\virtualenvs\warehouse\lib\site-packages\requests\packages\urllib3\response.py", line 461, in _handle_chunk
value = self._fp._safe_read(amt)
File "C:\Users\Mike\AppData\Local\Programs\Python\Python35\Lib\http\client.py", line 592, in _safe_read
chunk = self.fp.read(min(amt, MAXAMOUNT))
File "C:\Users\Mike\AppData\Local\Programs\Python\Python35\Lib\socket.py", line 575, in readinto
return self._sock.recv_into(b)
ConnectionResetError: [WinError 10054] An existing connection was forcibly closed by the remote host
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "H:\Programming\Python\virtualenvs\warehouse\lib\site-packages\requests\models.py", line 664, in generate
for chunk in self.raw.stream(chunk_size, decode_content=True):
File "H:\Programming\Python\virtualenvs\warehouse\lib\site-packages\requests\packages\urllib3\response.py", line 349, in stream
for line in self.read_chunked(amt, decode_content=decode_content):
File "H:\Programming\Python\virtualenvs\warehouse\lib\site-packages\requests\packages\urllib3\response.py", line 526, in read_chunked
self._original_response.close()
File "C:\Users\Mike\AppData\Local\Programs\Python\Python35\Lib\contextlib.py", line 77, in __exit__
self.gen.throw(type, value, traceback)
File "H:\Programming\Python\virtualenvs\warehouse\lib\site-packages\requests\packages\urllib3\response.py", line 246, in _error_catcher
raise ProtocolError('Connection broken: %r' % e, e)
requests.packages.urllib3.exceptions.ProtocolError: ("Connection broken: ConnectionResetError(10054, 'An existing connection was forcibly closed by the remote host', None, 10054, None)", ConnectionResetError(10054, 'An existing connection was forcibly closed by the remote host', None, 10054, None))
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "H:/Programming/Python/warehouse/main.py", line 55, in <module>
compile_auctions(slugs)
File "H:/Programming/Python/warehouse/main.py", line 44, in compile_auctions
for chunk in data.iter_content(chunk_size=1024):
File "H:\Programming\Python\virtualenvs\warehouse\lib\site-packages\requests\models.py", line 667, in generate
raise ChunkedEncodingError(e)
requests.exceptions.ChunkedEncodingError: ("Connection broken: ConnectionResetError(10054, 'An existing connection was forcibly closed by the remote host', None, 10054, None)", ConnectionResetError(10054, 'An existing connection was forcibly closed by the remote host', None, 10054, None))
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3332/reactions"
} | https://api.github.com/repos/psf/requests/issues/3332/timeline | null | completed | null | null | false | [
"That traceback just indicates that the remote peer decided to stop sending data for no reason that it could communicate to us: we were expecting more data, and we didn't get any. In this case, it's right in the middle of a content chunk.\n\nThat doesn't really give us much to go with. The server could really be do... |
https://api.github.com/repos/psf/requests/issues/3331 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3331/labels{/name} | https://api.github.com/repos/psf/requests/issues/3331/comments | https://api.github.com/repos/psf/requests/issues/3331/events | https://github.com/psf/requests/issues/3331 | 159,931,691 | MDU6SXNzdWUxNTk5MzE2OTE= | 3,331 | Scrape issue | {
"avatar_url": "https://avatars.githubusercontent.com/u/399798?v=4",
"events_url": "https://api.github.com/users/itranga/events{/privacy}",
"followers_url": "https://api.github.com/users/itranga/followers",
"following_url": "https://api.github.com/users/itranga/following{/other_user}",
"gists_url": "https://api.github.com/users/itranga/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/itranga",
"id": 399798,
"login": "itranga",
"node_id": "MDQ6VXNlcjM5OTc5OA==",
"organizations_url": "https://api.github.com/users/itranga/orgs",
"received_events_url": "https://api.github.com/users/itranga/received_events",
"repos_url": "https://api.github.com/users/itranga/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/itranga/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/itranga/subscriptions",
"type": "User",
"url": "https://api.github.com/users/itranga",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2016-06-13T11:46:52Z | 2021-09-08T17:05:38Z | 2016-06-13T11:53:25Z | NONE | resolved | I tried to scrape http://www.nbcnews.com/health/health-news/brain-study-helps-explain-some-veterans-agony-n589916 .Then i got the below issue.
404 Client Error: Not Found for url: http://www.nbcnews.com/health/health-news/brain-study-helps-explain-some-veterans-agony-n589916%20
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3331/reactions"
} | https://api.github.com/repos/psf/requests/issues/3331/timeline | null | completed | null | null | false | [
"You left a space at the end of your URL. You need to remove it: requests will not automatically do that for you.\n",
"Thanks for your reply. But i did't add any spaces to the url, i also saw that '%20' end of the url. how is it happened?\n",
"That %20 is the urlencoding for a space, which is how I determined w... |
https://api.github.com/repos/psf/requests/issues/3300 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3300/labels{/name} | https://api.github.com/repos/psf/requests/issues/3300/comments | https://api.github.com/repos/psf/requests/issues/3300/events | https://github.com/psf/requests/issues/3300 | 159,759,291 | MDU6SXNzdWUxNTk3NTkyOTE= | 3,300 | Upload stream | {
"avatar_url": "https://avatars.githubusercontent.com/u/9058818?v=4",
"events_url": "https://api.github.com/users/ggcatu/events{/privacy}",
"followers_url": "https://api.github.com/users/ggcatu/followers",
"following_url": "https://api.github.com/users/ggcatu/following{/other_user}",
"gists_url": "https://api.github.com/users/ggcatu/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ggcatu",
"id": 9058818,
"login": "ggcatu",
"node_id": "MDQ6VXNlcjkwNTg4MTg=",
"organizations_url": "https://api.github.com/users/ggcatu/orgs",
"received_events_url": "https://api.github.com/users/ggcatu/received_events",
"repos_url": "https://api.github.com/users/ggcatu/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ggcatu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ggcatu/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ggcatu",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 6 | 2016-06-11T06:40:53Z | 2021-09-08T17:05:38Z | 2016-06-14T07:19:53Z | NONE | resolved | Hello guys, I'm on python3 - requests 2.10.0.
Im trying to reproduce this:
http://docs.python-requests.org/en/master/user/advanced/#chunk-encoding
```
def gen():
yield 'hi'
yield 'there'
requests.post('http://some.url/chunked', data=gen())
```
But I get `File "C:\Users\Gabriel\AppData\Local\Programs\Python\Python35\lib\site-packages\requests\models.py", line 152, in _encode_files
fdata = fp.read()
AttributeError: 'generator' object has no attribute 'read'`
Basically I wanna to be able to upload a file, and be able to trace the upload speed.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3300/reactions"
} | https://api.github.com/repos/psf/requests/issues/3300/timeline | null | completed | null | null | false | [
"If I run the demo code in python3.5, I also get this Exception:\n\n```\nTypeError: a bytes-like object is required, not 'str'\n\nDuring handling of the above exception, another exception occurred:\n\nTraceback (most recent call last):\n File \"requests_test.py\", line 10, in <module>\n r = requests.post('http:... |
https://api.github.com/repos/psf/requests/issues/3299 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3299/labels{/name} | https://api.github.com/repos/psf/requests/issues/3299/comments | https://api.github.com/repos/psf/requests/issues/3299/events | https://github.com/psf/requests/issues/3299 | 159,450,843 | MDU6SXNzdWUxNTk0NTA4NDM= | 3,299 | 413 Client Error: Request Entity Too Large on SSL site where curl works | {
"avatar_url": "https://avatars.githubusercontent.com/u/212279?v=4",
"events_url": "https://api.github.com/users/eriol/events{/privacy}",
"followers_url": "https://api.github.com/users/eriol/followers",
"following_url": "https://api.github.com/users/eriol/following{/other_user}",
"gists_url": "https://api.github.com/users/eriol/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/eriol",
"id": 212279,
"login": "eriol",
"node_id": "MDQ6VXNlcjIxMjI3OQ==",
"organizations_url": "https://api.github.com/users/eriol/orgs",
"received_events_url": "https://api.github.com/users/eriol/received_events",
"repos_url": "https://api.github.com/users/eriol/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/eriol/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/eriol/subscriptions",
"type": "User",
"url": "https://api.github.com/users/eriol",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 6 | 2016-06-09T16:23:45Z | 2021-09-08T17:05:39Z | 2016-06-09T17:48:16Z | CONTRIBUTOR | resolved | Hello,
I would like to bring this issue to your attention: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=801506
The problem shows in requests 2.10.0.
This is my test script:
``` python
import requests
URL = 'https://contributors.debian.org/contributors/test_post'
FILE = 'test.json.xz'
# FILE = 'test-small.json.xz' # This works
if __name__ == '__main__':
payload = {'source': 'bugs.debian.org', 'data_compression': 'xz'}
with open(FILE, 'rb') as f:
r = requests.post(URL, files={'data': f}, data=payload)
print(r.text)
```
`test-small.json.xz` is the same of `test.json.xz` only smaller: in my test I used only 10 objs.
curl is able to post correctly:
```
curl https://contributors.debian.org/contributors/test_post -F source=bugs.debian.org -F data=@test.json.xz -F data_compression=xz
```
github doesn't allow to upload a `.xz` so please take it from Debian BTS: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=801506;filename=test.json.xz;att=1;msg=15
Any suggestions?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3299/reactions"
} | https://api.github.com/repos/psf/requests/issues/3299/timeline | null | completed | null | null | false | [
"So after digging around I have checked some things. Requests does seem to be in agreement with itself, at least: the length of the request body it sends does match the length of the body it _actually_ sends, at least according to Python. So that's a good start.\n\nHowever, an interesting problem occurs. If I use m... |
https://api.github.com/repos/psf/requests/issues/3298 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3298/labels{/name} | https://api.github.com/repos/psf/requests/issues/3298/comments | https://api.github.com/repos/psf/requests/issues/3298/events | https://github.com/psf/requests/pull/3298 | 159,316,861 | MDExOlB1bGxSZXF1ZXN0NzMxNDk4MTE= | 3,298 | Update a note on AppEngine | {
"avatar_url": "https://avatars.githubusercontent.com/u/185043?v=4",
"events_url": "https://api.github.com/users/davidfischer/events{/privacy}",
"followers_url": "https://api.github.com/users/davidfischer/followers",
"following_url": "https://api.github.com/users/davidfischer/following{/other_user}",
"gists_url": "https://api.github.com/users/davidfischer/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/davidfischer",
"id": 185043,
"login": "davidfischer",
"node_id": "MDQ6VXNlcjE4NTA0Mw==",
"organizations_url": "https://api.github.com/users/davidfischer/orgs",
"received_events_url": "https://api.github.com/users/davidfischer/received_events",
"repos_url": "https://api.github.com/users/davidfischer/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/davidfischer/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/davidfischer/subscriptions",
"type": "User",
"url": "https://api.github.com/users/davidfischer",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2016-06-09T02:32:39Z | 2021-09-08T03:01:05Z | 2016-06-09T02:49:06Z | CONTRIBUTOR | resolved | This is simply an update on AppEngine support to point people in the right direction.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3298/reactions"
} | https://api.github.com/repos/psf/requests/issues/3298/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3298.diff",
"html_url": "https://github.com/psf/requests/pull/3298",
"merged_at": "2016-06-09T02:49:06Z",
"patch_url": "https://github.com/psf/requests/pull/3298.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3298"
} | true | [
"thanks!\n"
] |
https://api.github.com/repos/psf/requests/issues/3297 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3297/labels{/name} | https://api.github.com/repos/psf/requests/issues/3297/comments | https://api.github.com/repos/psf/requests/issues/3297/events | https://github.com/psf/requests/pull/3297 | 159,310,872 | MDExOlB1bGxSZXF1ZXN0NzMxNDU3Mjg= | 3,297 | Note how HTTPErrors are raised | {
"avatar_url": "https://avatars.githubusercontent.com/u/185043?v=4",
"events_url": "https://api.github.com/users/davidfischer/events{/privacy}",
"followers_url": "https://api.github.com/users/davidfischer/followers",
"following_url": "https://api.github.com/users/davidfischer/following{/other_user}",
"gists_url": "https://api.github.com/users/davidfischer/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/davidfischer",
"id": 185043,
"login": "davidfischer",
"node_id": "MDQ6VXNlcjE4NTA0Mw==",
"organizations_url": "https://api.github.com/users/davidfischer/orgs",
"received_events_url": "https://api.github.com/users/davidfischer/received_events",
"repos_url": "https://api.github.com/users/davidfischer/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/davidfischer/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/davidfischer/subscriptions",
"type": "User",
"url": "https://api.github.com/users/davidfischer",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2016-06-09T01:21:28Z | 2021-09-08T03:01:05Z | 2016-06-09T06:57:44Z | CONTRIBUTOR | resolved | After looking through the code line, `requests.exceptions.HTTPError`s are only raised by `raise_for_status` but the docs made it seem like that error could happen through other means. This PR makes the docs explicit.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3297/reactions"
} | https://api.github.com/repos/psf/requests/issues/3297/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3297.diff",
"html_url": "https://github.com/psf/requests/pull/3297",
"merged_at": "2016-06-09T06:57:44Z",
"patch_url": "https://github.com/psf/requests/pull/3297.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3297"
} | true | [
"I believe the original text is indeed correct, that error can occur when an HTTPError (not related to status code) is raised. I'm not sure, off the top of my head, when that could be anymore. It's possible that's a remnant from when requests ran on urllib2. \n\nRegardless, the _additions_ to the text are most cert... |
https://api.github.com/repos/psf/requests/issues/3296 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3296/labels{/name} | https://api.github.com/repos/psf/requests/issues/3296/comments | https://api.github.com/repos/psf/requests/issues/3296/events | https://github.com/psf/requests/issues/3296 | 159,287,397 | MDU6SXNzdWUxNTkyODczOTc= | 3,296 | no_proxy env ignored on 302 redirect | {
"avatar_url": "https://avatars.githubusercontent.com/u/13124500?v=4",
"events_url": "https://api.github.com/users/Gaasmann/events{/privacy}",
"followers_url": "https://api.github.com/users/Gaasmann/followers",
"following_url": "https://api.github.com/users/Gaasmann/following{/other_user}",
"gists_url": "https://api.github.com/users/Gaasmann/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Gaasmann",
"id": 13124500,
"login": "Gaasmann",
"node_id": "MDQ6VXNlcjEzMTI0NTAw",
"organizations_url": "https://api.github.com/users/Gaasmann/orgs",
"received_events_url": "https://api.github.com/users/Gaasmann/received_events",
"repos_url": "https://api.github.com/users/Gaasmann/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Gaasmann/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Gaasmann/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Gaasmann",
"user_view_type": "public"
} | [
{
"color": "e10c02",
"default": false,
"description": null,
"id": 117744,
"name": "Bug",
"node_id": "MDU6TGFiZWwxMTc3NDQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Bug"
}
] | open | false | null | [] | null | 7 | 2016-06-08T22:17:20Z | 2016-09-06T00:00:34Z | null | NONE | null | Hello,
I have a weird problem using Requests and proxies.
I have https_proxy and no_proxy env variable for a domain and it seems the no_proxy is ignored on a HTTP 302 redirect target.
What I do is basically:
```
s = requests.Session()
r = s.get("https://use-the-proxy.com")
```
The response is 302 Found (Location: https://do-not-use-the-proxy.com) and Requests tries to follow.
Here the problem: even if do-not-use-the-proxy.com is present in no_proxy, Requests still use the proxy for the request following a 302(the 302 "target").
If I directly request https://do-not-use-the-proxy.com, the proxy is not used as expected.
Thanks,
##
Nico
| null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3296/reactions"
} | https://api.github.com/repos/psf/requests/issues/3296/timeline | null | null | null | null | false | [
"What version of requests are you using?\n",
"Hello,\nRequests version is 2.7.0.\nThanks\n",
"Cool, that's a good spot.\n\nYes, there is a minor bug in `resolve_redirects`. Specifically, while `resolve_redirects` attempts to remove proxy information, it cannot actually tell the difference between a proxy that w... |
https://api.github.com/repos/psf/requests/issues/3295 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3295/labels{/name} | https://api.github.com/repos/psf/requests/issues/3295/comments | https://api.github.com/repos/psf/requests/issues/3295/events | https://github.com/psf/requests/pull/3295 | 159,193,157 | MDExOlB1bGxSZXF1ZXN0NzMwNjc3ODM= | 3,295 | Document header ordering caveats. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [] | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}... | null | 2 | 2016-06-08T15:26:13Z | 2021-09-02T00:07:36Z | 2016-06-08T16:44:33Z | MEMBER | resolved | Resolves #3096.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3295/reactions"
} | https://api.github.com/repos/psf/requests/issues/3295/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3295.diff",
"html_url": "https://github.com/psf/requests/pull/3295",
"merged_at": "2016-06-08T16:44:33Z",
"patch_url": "https://github.com/psf/requests/pull/3295.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3295"
} | true | [
"This looks great. Thanks @Lukasa \n",
"@0x3c3e, please consult the documentation for Session. The code you’ve supplied is modifying the Session class, not an instance of Session which is likely your problem. Further questions about usage should directed towards StackOverflow as per our project policies. Thanks!"... |
https://api.github.com/repos/psf/requests/issues/3294 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3294/labels{/name} | https://api.github.com/repos/psf/requests/issues/3294/comments | https://api.github.com/repos/psf/requests/issues/3294/events | https://github.com/psf/requests/issues/3294 | 159,121,233 | MDU6SXNzdWUxNTkxMjEyMzM= | 3,294 | Performance issues while working behind a proxy where no proxy is needed. | {
"avatar_url": "https://avatars.githubusercontent.com/u/5635462?v=4",
"events_url": "https://api.github.com/users/Tset-Noitamotua/events{/privacy}",
"followers_url": "https://api.github.com/users/Tset-Noitamotua/followers",
"following_url": "https://api.github.com/users/Tset-Noitamotua/following{/other_user}",
"gists_url": "https://api.github.com/users/Tset-Noitamotua/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Tset-Noitamotua",
"id": 5635462,
"login": "Tset-Noitamotua",
"node_id": "MDQ6VXNlcjU2MzU0NjI=",
"organizations_url": "https://api.github.com/users/Tset-Noitamotua/orgs",
"received_events_url": "https://api.github.com/users/Tset-Noitamotua/received_events",
"repos_url": "https://api.github.com/users/Tset-Noitamotua/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Tset-Noitamotua/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Tset-Noitamotua/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Tset-Noitamotua",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2016-06-08T09:41:09Z | 2021-09-08T17:05:40Z | 2016-06-08T09:42:15Z | NONE | resolved | Hi, plz have a look at this [issue #116](https://github.com/bulkan/robotframework-requests/issues/116) with [robotframework-requests](https://github.com/bulkan/robotframework-requests) library, take particular notice of my [second comment](https://github.com/bulkan/robotframework-requests/issues/116#issuecomment-224537034), it might be related to 'requests'.
Cheers
Tset
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3294/reactions"
} | https://api.github.com/repos/psf/requests/issues/3294/timeline | null | completed | null | null | false | [
"This is a known issue: it's a duplicate of #2988.\n"
] |
https://api.github.com/repos/psf/requests/issues/3293 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3293/labels{/name} | https://api.github.com/repos/psf/requests/issues/3293/comments | https://api.github.com/repos/psf/requests/issues/3293/events | https://github.com/psf/requests/pull/3293 | 158,931,313 | MDExOlB1bGxSZXF1ZXN0NzI4ODA5MTY= | 3,293 | idea add the gitignore | {
"avatar_url": "https://avatars.githubusercontent.com/u/7835577?v=4",
"events_url": "https://api.github.com/users/GaussDing/events{/privacy}",
"followers_url": "https://api.github.com/users/GaussDing/followers",
"following_url": "https://api.github.com/users/GaussDing/following{/other_user}",
"gists_url": "https://api.github.com/users/GaussDing/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/GaussDing",
"id": 7835577,
"login": "GaussDing",
"node_id": "MDQ6VXNlcjc4MzU1Nzc=",
"organizations_url": "https://api.github.com/users/GaussDing/orgs",
"received_events_url": "https://api.github.com/users/GaussDing/received_events",
"repos_url": "https://api.github.com/users/GaussDing/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/GaussDing/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/GaussDing/subscriptions",
"type": "User",
"url": "https://api.github.com/users/GaussDing",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 0 | 2016-06-07T14:03:24Z | 2021-09-08T03:01:06Z | 2016-06-07T14:04:30Z | NONE | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/7835577?v=4",
"events_url": "https://api.github.com/users/GaussDing/events{/privacy}",
"followers_url": "https://api.github.com/users/GaussDing/followers",
"following_url": "https://api.github.com/users/GaussDing/following{/other_user}",
"gists_url": "https://api.github.com/users/GaussDing/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/GaussDing",
"id": 7835577,
"login": "GaussDing",
"node_id": "MDQ6VXNlcjc4MzU1Nzc=",
"organizations_url": "https://api.github.com/users/GaussDing/orgs",
"received_events_url": "https://api.github.com/users/GaussDing/received_events",
"repos_url": "https://api.github.com/users/GaussDing/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/GaussDing/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/GaussDing/subscriptions",
"type": "User",
"url": "https://api.github.com/users/GaussDing",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3293/reactions"
} | https://api.github.com/repos/psf/requests/issues/3293/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3293.diff",
"html_url": "https://github.com/psf/requests/pull/3293",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/3293.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3293"
} | true | [] | |
https://api.github.com/repos/psf/requests/issues/3292 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3292/labels{/name} | https://api.github.com/repos/psf/requests/issues/3292/comments | https://api.github.com/repos/psf/requests/issues/3292/events | https://github.com/psf/requests/issues/3292 | 158,894,079 | MDU6SXNzdWUxNTg4OTQwNzk= | 3,292 | I can not use Requests in Jupyter | {
"avatar_url": "https://avatars.githubusercontent.com/u/19483465?v=4",
"events_url": "https://api.github.com/users/hedgeliu/events{/privacy}",
"followers_url": "https://api.github.com/users/hedgeliu/followers",
"following_url": "https://api.github.com/users/hedgeliu/following{/other_user}",
"gists_url": "https://api.github.com/users/hedgeliu/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/hedgeliu",
"id": 19483465,
"login": "hedgeliu",
"node_id": "MDQ6VXNlcjE5NDgzNDY1",
"organizations_url": "https://api.github.com/users/hedgeliu/orgs",
"received_events_url": "https://api.github.com/users/hedgeliu/received_events",
"repos_url": "https://api.github.com/users/hedgeliu/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/hedgeliu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hedgeliu/subscriptions",
"type": "User",
"url": "https://api.github.com/users/hedgeliu",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 6 | 2016-06-07T10:53:21Z | 2019-01-03T14:19:39Z | 2016-06-07T14:19:12Z | NONE | resolved | Hi, the error massages appear all the time while I follow the instruction in Jupyter. But it is fine in other places. It is really strange. Because I saw lots of resource that show Jupyter can run "requests". Did I get something wrong before import requests or I need to write some more code like matplotlib in Jupyter?
```
import requests
r = requests.get('https://www.python.org')
r.status_code
```
> ---
>
> gaierror Traceback (most recent call last)
> /opt/conda/lib/python3.5/site-packages/requests/packages/urllib3/connection.py in _new_conn(self)
> 136 conn = connection.create_connection(
> --> 137 (self.host, self.port), self.timeout, **extra_kw)
> 138
>
> /opt/conda/lib/python3.5/site-packages/requests/packages/urllib3/util/connection.py in create_connection(address, timeout, source_address, socket_options)
> 66 err = None
> ---> 67 for res in socket.getaddrinfo(host, port, 0, socket.SOCK_STREAM):
> 68 af, socktype, proto, canonname, sa = res
>
> /opt/conda/lib/python3.5/socket.py in getaddrinfo(host, port, family, type, proto, flags)
> 731 addrlist = []
> --> 732 for res in _socket.getaddrinfo(host, port, family, type, proto, flags):
> 733 af, socktype, proto, canonname, sa = res
>
> gaierror: [Errno -2] Name or service not known
>
> During handling of the above exception, another exception occurred:
>
> NewConnectionError Traceback (most recent call last)
> /opt/conda/lib/python3.5/site-packages/requests/packages/urllib3/connectionpool.py in urlopen(self, method, url, body, headers, retries, redirect, assert_same_host, timeout, pool_timeout, release_conn, **response_kw)
> 558 timeout=timeout_obj,
> --> 559 body=body, headers=headers)
> 560
>
> /opt/conda/lib/python3.5/site-packages/requests/packages/urllib3/connectionpool.py in _make_request(self, conn, method, url, timeout, *_httplib_request_kw)
> 352 # urllib3.request. It also calls makefile (recv) on the socket.
> --> 353 conn.request(method, url, *_httplib_request_kw)
> 354
>
> /opt/conda/lib/python3.5/http/client.py in request(self, method, url, body, headers)
> 1082 """Send a complete request to the server."""
> -> 1083 self._send_request(method, url, body, headers)
> 1084
>
> /opt/conda/lib/python3.5/http/client.py in _send_request(self, method, url, body, headers)
> 1127 body = body.encode('iso-8859-1')
> -> 1128 self.endheaders(body)
> 1129
>
> /opt/conda/lib/python3.5/http/client.py in endheaders(self, message_body)
> 1078 raise CannotSendHeader()
> -> 1079 self._send_output(message_body)
> 1080
>
> /opt/conda/lib/python3.5/http/client.py in _send_output(self, message_body)
> 910
> --> 911 self.send(msg)
> 912 if message_body is not None:
>
> /opt/conda/lib/python3.5/http/client.py in send(self, data)
> 853 if self.auto_open:
> --> 854 self.connect()
> 855 else:
>
> /opt/conda/lib/python3.5/site-packages/requests/packages/urllib3/connection.py in connect(self)
> 161 def connect(self):
> --> 162 conn = self._new_conn()
> 163 self._prepare_conn(conn)
>
> /opt/conda/lib/python3.5/site-packages/requests/packages/urllib3/connection.py in _new_conn(self)
> 145 raise NewConnectionError(
> --> 146 self, "Failed to establish a new connection: %s" % e)
> 147
>
> NewConnectionError: <requests.packages.urllib3.connection.HTTPConnection object at 0x7fee369df7f0>: Failed to establish a new connection: [Errno -2] Name or service not known
>
> During handling of the above exception, another exception occurred:
>
> MaxRetryError Traceback (most recent call last)
> /opt/conda/lib/python3.5/site-packages/requests/adapters.py in send(self, request, stream, timeout, verify, cert, proxies)
> 375 retries=self.max_retries,
> --> 376 timeout=timeout
> 377 )
>
> /opt/conda/lib/python3.5/site-packages/requests/packages/urllib3/connectionpool.py in urlopen(self, method, url, body, headers, retries, redirect, assert_same_host, timeout, pool_timeout, release_conn, **response_kw)
> 608 retries = retries.increment(method, url, error=e, _pool=self,
> --> 609 _stacktrace=sys.exc_info()[2])
> 610 retries.sleep()
>
> /opt/conda/lib/python3.5/site-packages/requests/packages/urllib3/util/retry.py in increment(self, method, url, response, error, _pool, _stacktrace)
> 272 if new_retry.is_exhausted():
> --> 273 raise MaxRetryError(_pool, url, error or ResponseError(cause))
> 274
>
> MaxRetryError: HTTPConnectionPool(host='www.ichangtou.com', port=80): Max retries exceeded with url: / (Caused by NewConnectionError('<requests.packages.urllib3.connection.HTTPConnection object at 0x7fee369df7f0>: Failed to establish a new connection: [Errno -2] Name or service not known',))
>
> During handling of the above exception, another exception occurred:
>
> ConnectionError Traceback (most recent call last)
> <ipython-input-7-6f872ca7f8cc> in <module>()
> 4 headers = {'User-Agent': 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_10_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/39.0.2171.95 Safari/537.36'}
> 5
> ----> 6 response = requests.get(url, headers=headers)
> 7 print(response.content)
>
> /opt/conda/lib/python3.5/site-packages/requests/api.py in get(url, params, *_kwargs)
> 65
> 66 kwargs.setdefault('allow_redirects', True)
> ---> 67 return request('get', url, params=params, *_kwargs)
> 68
> 69
>
> /opt/conda/lib/python3.5/site-packages/requests/api.py in request(method, url, *_kwargs)
> 51 # cases, and look like a memory leak in others.
> 52 with sessions.Session() as session:
> ---> 53 return session.request(method=method, url=url, *_kwargs)
> 54
> 55
>
> /opt/conda/lib/python3.5/site-packages/requests/sessions.py in request(self, method, url, params, data, headers, cookies, files, auth, timeout, allow_redirects, proxies, hooks, stream, verify, cert, json)
> 466 }
> 467 send_kwargs.update(settings)
> --> 468 resp = self.send(prep, **send_kwargs)
> 469
> 470 return resp
>
> /opt/conda/lib/python3.5/site-packages/requests/sessions.py in send(self, request, *_kwargs)
> 574
> 575 # Send the request
> --> 576 r = adapter.send(request, *_kwargs)
> 577
> 578 # Total elapsed time of the request (approximately)
>
> /opt/conda/lib/python3.5/site-packages/requests/adapters.py in send(self, request, stream, timeout, verify, cert, proxies)
> 435 raise RetryError(e, request=request)
> 436
> --> 437 raise ConnectionError(e, request=request)
> 438
> 439 except ClosedPoolError as e:
>
> ConnectionError: HTTPConnectionPool(host='www.ichangtou.com', port=80): Max retries exceeded with url: / (Caused by NewConnectionError('<requests.packages.urllib3.connection.HTTPConnection object at 0x7fee369df7f0>: Failed to establish a new connection: [Errno -2] Name or service not known',))
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3292/reactions"
} | https://api.github.com/repos/psf/requests/issues/3292/timeline | null | completed | null | null | false | [
"The problem here is that the machine that is running the Jupyter Python kernel is not able to DNS resolve the hostname `www.ichangtou.com`. Do you have physical access to the machine running the kernel?\n",
"Hi Lukasa, I don't think I have the physical access. I just open the website and write the code. And any ... |
https://api.github.com/repos/psf/requests/issues/3291 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3291/labels{/name} | https://api.github.com/repos/psf/requests/issues/3291/comments | https://api.github.com/repos/psf/requests/issues/3291/events | https://github.com/psf/requests/issues/3291 | 158,764,582 | MDU6SXNzdWUxNTg3NjQ1ODI= | 3,291 | session ignores POST data when caching redirects | {
"avatar_url": "https://avatars.githubusercontent.com/u/10416599?v=4",
"events_url": "https://api.github.com/users/panda-34/events{/privacy}",
"followers_url": "https://api.github.com/users/panda-34/followers",
"following_url": "https://api.github.com/users/panda-34/following{/other_user}",
"gists_url": "https://api.github.com/users/panda-34/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/panda-34",
"id": 10416599,
"login": "panda-34",
"node_id": "MDQ6VXNlcjEwNDE2NTk5",
"organizations_url": "https://api.github.com/users/panda-34/orgs",
"received_events_url": "https://api.github.com/users/panda-34/received_events",
"repos_url": "https://api.github.com/users/panda-34/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/panda-34/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/panda-34/subscriptions",
"type": "User",
"url": "https://api.github.com/users/panda-34",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 6 | 2016-06-06T20:15:22Z | 2021-09-08T17:05:41Z | 2016-06-06T20:36:17Z | NONE | resolved | I was scraping a site where the search form makes a POST request which is redirected with 301 code. That code being permanent, the redirect is cached in session.redirect_cache by POST URL alone, so for all further searches the session gets the same page. I suggest that redirect_cache should use POST body as a key also, it's quite typical for sites to redirect POSTs to different URLs based on data.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3291/reactions"
} | https://api.github.com/repos/psf/requests/issues/3291/timeline | null | completed | null | null | false | [
"Hey @panda-34,\n\nThanks for pointing this out. This was something I hadn't seen before (or considered). Tthe redirect cache is meant to very simplistic. The default cache can be disabled like as described [here](https://github.com/kennethreitz/requests/pull/2095#issuecomment-45977320). You can then use a real cac... |
https://api.github.com/repos/psf/requests/issues/3290 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3290/labels{/name} | https://api.github.com/repos/psf/requests/issues/3290/comments | https://api.github.com/repos/psf/requests/issues/3290/events | https://github.com/psf/requests/issues/3290 | 158,745,955 | MDU6SXNzdWUxNTg3NDU5NTU= | 3,290 | Content-length not calculated correctly | {
"avatar_url": "https://avatars.githubusercontent.com/u/13381584?v=4",
"events_url": "https://api.github.com/users/therealjb86/events{/privacy}",
"followers_url": "https://api.github.com/users/therealjb86/followers",
"following_url": "https://api.github.com/users/therealjb86/following{/other_user}",
"gists_url": "https://api.github.com/users/therealjb86/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/therealjb86",
"id": 13381584,
"login": "therealjb86",
"node_id": "MDQ6VXNlcjEzMzgxNTg0",
"organizations_url": "https://api.github.com/users/therealjb86/orgs",
"received_events_url": "https://api.github.com/users/therealjb86/received_events",
"repos_url": "https://api.github.com/users/therealjb86/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/therealjb86/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/therealjb86/subscriptions",
"type": "User",
"url": "https://api.github.com/users/therealjb86",
"user_view_type": "public"
} | [
{
"color": "777777",
"default": false,
"description": null,
"id": 162780722,
"name": "Question/Not a bug",
"node_id": "MDU6TGFiZWwxNjI3ODA3MjI=",
"url": "https://api.github.com/repos/psf/requests/labels/Question/Not%20a%20bug"
},
{
"color": "f7c6c7",
"default": false,
"de... | closed | true | null | [] | null | 7 | 2016-06-06T18:42:51Z | 2021-09-08T17:05:41Z | 2016-06-07T08:54:40Z | NONE | resolved | PUT request using previous connection .content generates content-length of 1. Please can you help me determine why this is happening?
Code:
r = requests.get('http://192.168.55.5/api/?client=wget&file-name=dummy&type=vmware/vmware/2.0/si/serviceprofile/serviceprofile-1/containerset',
data={r1.content}, headers={'content-type':'application/xml'}, verify=False, auth=('admin', 'paloalto'))
Generated request:
PUT /api/?client=wget&file-name=dummy&type=vmware/vmware/2.0/si/serviceprofile/serviceprofile-1/containerset HTTP/1.1
Host: 192.168.55.5
Connection: keep-alive
User-Agent: python-requests/2.10.0
Accept-Encoding: gzip, deflate
Accept: _/_
Content-Length: 1
content-type: application/xml
Authorization: Basic YWRtaW46cGFsb2FsdG8=
<?xml version="1.0" encoding="UTF-8"?>
<containerSet><container><id>securitygroup-22</id><name>Ten1SubtA-sec-group</name><description></description><revision>3</revision><type>IP</type><address>192.168.111.89</address><address>192.168.111.88</address></container><container><id>securitygroup-27</id><name>test-sec</name><description></description><revision>7</revision><type>IP</type></container></containerSet>
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3290/reactions"
} | https://api.github.com/repos/psf/requests/issues/3290/timeline | null | completed | null | null | false | [
"You can see the body is clearly more than 1 byte so unless I'm missing something this looks like a bug. Let me know what additional information you would like and I will add it.\n",
"It's actually not quite complete. You haven't told us what operating system you're using or shown us how to get `r1` for the post ... |
https://api.github.com/repos/psf/requests/issues/3289 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3289/labels{/name} | https://api.github.com/repos/psf/requests/issues/3289/comments | https://api.github.com/repos/psf/requests/issues/3289/events | https://github.com/psf/requests/pull/3289 | 158,694,498 | MDExOlB1bGxSZXF1ZXN0NzI3MjA2MzY= | 3,289 | Test verify parameter | {
"avatar_url": "https://avatars.githubusercontent.com/u/15092?v=4",
"events_url": "https://api.github.com/users/jayvdb/events{/privacy}",
"followers_url": "https://api.github.com/users/jayvdb/followers",
"following_url": "https://api.github.com/users/jayvdb/following{/other_user}",
"gists_url": "https://api.github.com/users/jayvdb/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jayvdb",
"id": 15092,
"login": "jayvdb",
"node_id": "MDQ6VXNlcjE1MDky",
"organizations_url": "https://api.github.com/users/jayvdb/orgs",
"received_events_url": "https://api.github.com/users/jayvdb/received_events",
"repos_url": "https://api.github.com/users/jayvdb/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jayvdb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jayvdb/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jayvdb",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 10 | 2016-06-06T14:41:02Z | 2021-09-08T03:01:03Z | 2016-06-17T13:00:05Z | CONTRIBUTOR | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3289/reactions"
} | https://api.github.com/repos/psf/requests/issues/3289/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3289.diff",
"html_url": "https://github.com/psf/requests/pull/3289",
"merged_at": "2016-06-17T13:00:05Z",
"patch_url": "https://github.com/psf/requests/pull/3289.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3289"
} | true | [
"I've removed the `SSLError` tests, and session tests due to what you've explained in #3288, and focused on the `SubjectAltNameWarning` which should always occur with `pytest-httpbin`.\n\nThis is actually better at showing the problem in #3287 , as it needs to occur in all combinations of dependencies and Python ve... | |
https://api.github.com/repos/psf/requests/issues/3288 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3288/labels{/name} | https://api.github.com/repos/psf/requests/issues/3288/comments | https://api.github.com/repos/psf/requests/issues/3288/events | https://github.com/psf/requests/issues/3288 | 158,692,705 | MDU6SXNzdWUxNTg2OTI3MDU= | 3,288 | Minor session object documentation issues | {
"avatar_url": "https://avatars.githubusercontent.com/u/15092?v=4",
"events_url": "https://api.github.com/users/jayvdb/events{/privacy}",
"followers_url": "https://api.github.com/users/jayvdb/followers",
"following_url": "https://api.github.com/users/jayvdb/following{/other_user}",
"gists_url": "https://api.github.com/users/jayvdb/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jayvdb",
"id": 15092,
"login": "jayvdb",
"node_id": "MDQ6VXNlcjE1MDky",
"organizations_url": "https://api.github.com/users/jayvdb/orgs",
"received_events_url": "https://api.github.com/users/jayvdb/received_events",
"repos_url": "https://api.github.com/users/jayvdb/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jayvdb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jayvdb/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jayvdb",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2016-06-06T14:33:31Z | 2021-09-08T17:05:42Z | 2016-06-06T14:51:37Z | CONTRIBUTOR | resolved | I suspect this is a documentation issue, for expected and desired behaviour, rather than an unintended bug...
http://docs.python-requests.org/en/master/user/advanced/#session-objects states that
> The Session object ... will use urllib3's connection pooling. So if you're making several requests to the same host, the underlying TCP connection will be reused, which can result in a significant performance increase (see HTTP persistent connection).
> ...
> Note, however, that method-level parameters will not be persisted across requests, even if using a session. This example will only send the cookies with the first request, but not the second: ..."
There is a minor conflict between those, in that exceptions to the rule include the `verify` parameter and likely other connection related parameters (`cert`, `timeout`, ...?), which do in fact persist across the requests. This is strongly implied by the opening paragraph, which says that the connection is reused.
Also "several requests to the same host" is not quite correct, I believe, as different protocols will result in different connections, naturally.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3288/reactions"
} | https://api.github.com/repos/psf/requests/issues/3288/timeline | null | completed | null | null | false | [
"Note #3289 shows the `verify` parameter being persistent between requests in the same session.\n",
"What would be interesting to test is whether a connection reset of some sort causes the `verify` parameter in the session to the same protocol/host to be lost. Maybe there is a test in `urllib3` that already cove... |
https://api.github.com/repos/psf/requests/issues/3287 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3287/labels{/name} | https://api.github.com/repos/psf/requests/issues/3287/comments | https://api.github.com/repos/psf/requests/issues/3287/events | https://github.com/psf/requests/issues/3287 | 158,589,042 | MDU6SXNzdWUxNTg1ODkwNDI= | 3,287 | requests.packages monkey patching of unbundled urllib3 does not work | {
"avatar_url": "https://avatars.githubusercontent.com/u/15092?v=4",
"events_url": "https://api.github.com/users/jayvdb/events{/privacy}",
"followers_url": "https://api.github.com/users/jayvdb/followers",
"following_url": "https://api.github.com/users/jayvdb/following{/other_user}",
"gists_url": "https://api.github.com/users/jayvdb/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jayvdb",
"id": 15092,
"login": "jayvdb",
"node_id": "MDQ6VXNlcjE1MDky",
"organizations_url": "https://api.github.com/users/jayvdb/orgs",
"received_events_url": "https://api.github.com/users/jayvdb/received_events",
"repos_url": "https://api.github.com/users/jayvdb/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jayvdb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jayvdb/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jayvdb",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 25 | 2016-06-06T02:10:11Z | 2021-09-08T07:00:26Z | 2017-07-30T14:01:27Z | CONTRIBUTOR | resolved | In requests 2.5.2 `requests.packages.__init__` added code to allow `requests.packages.urllib3` to not exist, and it would fall back to using `urllib3`.
No doubt this works in some cases, as the people on #2375 were happy with it, but it doesnt work with pyopenssl, resulting in no SNI/etc.
`requests.packages.__init__` only injects `urllib3` as `requests.packages.urllib3`.
However all of the other modules within urlllib3 will have different copies in the namespace `requests.packages.urllib3`.
`requests.packages.urllib3.contrib.pyopenssl` then writes to a separate copy of `requests.packages.urllib3.util` and `requests.packages.urllib3.connection`, and these changes are never seen by `urllib3`.
I encountered this on debian stretch & sid's `python-requests` 2.10.0-1 with `python-urllib3` 1.15.1 when running on Python 2.7.6 (Ubuntu Trusty), and haven't retested yet on a later Python 2.7. @eriol
#3286 fixes the problem for me.
I note that Fedora's latest `python-requests` no longer unbundles urllib3.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 1,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/psf/requests/issues/3287/reactions"
} | https://api.github.com/repos/psf/requests/issues/3287/timeline | null | completed | null | null | false | [
"Here is a set of tests which demonstrate some of the problem: https://travis-ci.org/jayvdb/requests/builds/135716555\n\nMy apologies that it doesnt show a problem in `test_unbundling`, which is what I had hoped would show the problem more clearly.\n\nInstead, see the errors in `test_verify` have:\n\n```\n('HAS_MOD... |
https://api.github.com/repos/psf/requests/issues/3286 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3286/labels{/name} | https://api.github.com/repos/psf/requests/issues/3286/comments | https://api.github.com/repos/psf/requests/issues/3286/events | https://github.com/psf/requests/pull/3286 | 158,588,989 | MDExOlB1bGxSZXF1ZXN0NzI2NDg3MjY= | 3,286 | Load all unbundled urllib3 modules | {
"avatar_url": "https://avatars.githubusercontent.com/u/15092?v=4",
"events_url": "https://api.github.com/users/jayvdb/events{/privacy}",
"followers_url": "https://api.github.com/users/jayvdb/followers",
"following_url": "https://api.github.com/users/jayvdb/following{/other_user}",
"gists_url": "https://api.github.com/users/jayvdb/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jayvdb",
"id": 15092,
"login": "jayvdb",
"node_id": "MDQ6VXNlcjE1MDky",
"organizations_url": "https://api.github.com/users/jayvdb/orgs",
"received_events_url": "https://api.github.com/users/jayvdb/received_events",
"repos_url": "https://api.github.com/users/jayvdb/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jayvdb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jayvdb/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jayvdb",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 6 | 2016-06-06T02:09:25Z | 2021-09-08T03:00:54Z | 2016-08-08T12:04:22Z | CONTRIBUTOR | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3286/reactions"
} | https://api.github.com/repos/psf/requests/issues/3286/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3286.diff",
"html_url": "https://github.com/psf/requests/pull/3286",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/3286.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3286"
} | true | [
"I am _extremely_ nervous about applying further upstream patches to handle downstream unbundling behaviours. In particular, it's not clear to me what exact problem you're experiencing in #3287.\n\nFor the moment however I'm inclined to call this a Debian bug unless told otherwise. \n",
"The problem is that pyope... | |
https://api.github.com/repos/psf/requests/issues/3285 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3285/labels{/name} | https://api.github.com/repos/psf/requests/issues/3285/comments | https://api.github.com/repos/psf/requests/issues/3285/events | https://github.com/psf/requests/issues/3285 | 158,548,823 | MDU6SXNzdWUxNTg1NDg4MjM= | 3,285 | install | {
"avatar_url": "https://avatars.githubusercontent.com/u/9263473?v=4",
"events_url": "https://api.github.com/users/zdrjson/events{/privacy}",
"followers_url": "https://api.github.com/users/zdrjson/followers",
"following_url": "https://api.github.com/users/zdrjson/following{/other_user}",
"gists_url": "https://api.github.com/users/zdrjson/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/zdrjson",
"id": 9263473,
"login": "zdrjson",
"node_id": "MDQ6VXNlcjkyNjM0NzM=",
"organizations_url": "https://api.github.com/users/zdrjson/orgs",
"received_events_url": "https://api.github.com/users/zdrjson/received_events",
"repos_url": "https://api.github.com/users/zdrjson/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/zdrjson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zdrjson/subscriptions",
"type": "User",
"url": "https://api.github.com/users/zdrjson",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2016-06-05T10:50:55Z | 2021-09-08T18:00:38Z | 2016-06-05T14:59:40Z | NONE | resolved | homebrew support?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3285/reactions"
} | https://api.github.com/repos/psf/requests/issues/3285/timeline | null | completed | null | null | false | [
"Why? What value would that bring that pip does not?\n\nBasically, anyone is welcome to downstream repackage us if they'd like to, but pip is the deployment mechanism we support. \n",
"Homebrew is for Python itself, and perhaps some difficult to install modules, not general Python packages. \n"
] |
https://api.github.com/repos/psf/requests/issues/3274 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3274/labels{/name} | https://api.github.com/repos/psf/requests/issues/3274/comments | https://api.github.com/repos/psf/requests/issues/3274/events | https://github.com/psf/requests/pull/3274 | 158,540,971 | MDExOlB1bGxSZXF1ZXN0NzI2MjIyOTU= | 3,274 | Try to allow the socks patch to use http_no_tunnel | {
"avatar_url": "https://avatars.githubusercontent.com/u/4951803?v=4",
"events_url": "https://api.github.com/users/birm/events{/privacy}",
"followers_url": "https://api.github.com/users/birm/followers",
"following_url": "https://api.github.com/users/birm/following{/other_user}",
"gists_url": "https://api.github.com/users/birm/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/birm",
"id": 4951803,
"login": "birm",
"node_id": "MDQ6VXNlcjQ5NTE4MDM=",
"organizations_url": "https://api.github.com/users/birm/orgs",
"received_events_url": "https://api.github.com/users/birm/received_events",
"repos_url": "https://api.github.com/users/birm/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/birm/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/birm/subscriptions",
"type": "User",
"url": "https://api.github.com/users/birm",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2016-06-05T06:52:05Z | 2021-09-08T03:01:07Z | 2016-06-05T07:54:53Z | NONE | resolved | re #3238
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3274/reactions"
} | https://api.github.com/repos/psf/requests/issues/3274/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3274.diff",
"html_url": "https://github.com/psf/requests/pull/3274",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/3274.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3274"
} | true | [
"Thanks for this. Unfortunately, we can't merge this patch: it is entirely in urllib3 (a third-party library that we don't merge patches for). It's also not correct: it uses a constant that doesn't exist and handles a weirdly scoped URL rather than looking for environment variables. \n",
"Thank you. I'll see if I... |
https://api.github.com/repos/psf/requests/issues/3263 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3263/labels{/name} | https://api.github.com/repos/psf/requests/issues/3263/comments | https://api.github.com/repos/psf/requests/issues/3263/events | https://github.com/psf/requests/issues/3263 | 158,492,736 | MDU6SXNzdWUxNTg0OTI3MzY= | 3,263 | BadStatusLine | {
"avatar_url": "https://avatars.githubusercontent.com/u/12016537?v=4",
"events_url": "https://api.github.com/users/liampauling/events{/privacy}",
"followers_url": "https://api.github.com/users/liampauling/followers",
"following_url": "https://api.github.com/users/liampauling/following{/other_user}",
"gists_url": "https://api.github.com/users/liampauling/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/liampauling",
"id": 12016537,
"login": "liampauling",
"node_id": "MDQ6VXNlcjEyMDE2NTM3",
"organizations_url": "https://api.github.com/users/liampauling/orgs",
"received_events_url": "https://api.github.com/users/liampauling/received_events",
"repos_url": "https://api.github.com/users/liampauling/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/liampauling/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/liampauling/subscriptions",
"type": "User",
"url": "https://api.github.com/users/liampauling",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2016-06-04T07:33:40Z | 2021-09-08T18:00:39Z | 2016-06-04T14:53:31Z | NONE | resolved | Hi,
python version: 3.4.4
requests version: 2.10.0
I am trying to connect to what has been described as 'ssl socket (normal) with a CRLF json protocol', this means the raw response looks like this:
> reply: '{"op":"connection","connectionId":"002-040616070341-5494"}\r\n'
However requests is expecting it to look like this:
> reply: 'HTTP/1.1 200 OK\r\n'
Code used:
```
url = 'https://stream-api.betfair.com:443/api'
session = requests.session()
req = requests.Request('GET', url)
pre = req.prepare()
login_req = session.send(pre, stream=True)
```
I can see that the error is occurring in _read_status, does anyone know how I can bypass this? Or should I be connecting to this socket differently?
```
Traceback (most recent call last):
File "/Users/temp/anaconda/lib/python3.4/site-packages/requests/packages/urllib3/connectionpool.py", line 385, in _make_request
httplib_response = conn.getresponse(buffering=True)
TypeError: getresponse() got an unexpected keyword argument 'buffering'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/Users/temp/anaconda/lib/python3.4/site-packages/requests/packages/urllib3/connectionpool.py", line 578, in urlopen
chunked=chunked)
File "/Users/temp/anaconda/lib/python3.4/site-packages/requests/packages/urllib3/connectionpool.py", line 387, in _make_request
httplib_response = conn.getresponse()
File "/Users/temp/anaconda/lib/python3.4/http/client.py", line 1227, in getresponse
response.begin()
File "/Users/temp/anaconda/lib/python3.4/http/client.py", line 386, in begin
version, status, reason = self._read_status()
File "/Users/temp/anaconda/lib/python3.4/http/client.py", line 368, in _read_status
raise BadStatusLine(line)
http.client.BadStatusLine: {"op":"connection","connectionId":"002-040616071750-5507"}
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/Users/temp/anaconda/lib/python3.4/site-packages/requests/adapters.py", line 403, in send
timeout=timeout
File "/Users/temp/anaconda/lib/python3.4/site-packages/requests/packages/urllib3/connectionpool.py", line 623, in urlopen
_stacktrace=sys.exc_info()[2])
File "/Users/temp/anaconda/lib/python3.4/site-packages/requests/packages/urllib3/util/retry.py", line 255, in increment
raise six.reraise(type(error), error, _stacktrace)
File "/Users/temp/anaconda/lib/python3.4/site-packages/requests/packages/urllib3/packages/six.py", line 309, in reraise
raise value.with_traceback(tb)
File "/Users/temp/anaconda/lib/python3.4/site-packages/requests/packages/urllib3/connectionpool.py", line 578, in urlopen
chunked=chunked)
File "/Users/temp/anaconda/lib/python3.4/site-packages/requests/packages/urllib3/connectionpool.py", line 387, in _make_request
httplib_response = conn.getresponse()
File "/Users/temp/anaconda/lib/python3.4/http/client.py", line 1227, in getresponse
response.begin()
File "/Users/temp/anaconda/lib/python3.4/http/client.py", line 386, in begin
version, status, reason = self._read_status()
File "/Users/temp/anaconda/lib/python3.4/http/client.py", line 368, in _read_status
raise BadStatusLine(line)
requests.packages.urllib3.exceptions.ProtocolError: ('Connection aborted.', BadStatusLine('{"op":"connection","connectionId":"002-040616071750-5507"}\r\n',))
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "marketstreaming/test.py", line 52, in <module>
login_req = session.send(pre, stream=True)
File "/Users/temp/anaconda/lib/python3.4/site-packages/requests/sessions.py", line 585, in send
r = adapter.send(request, **kwargs)
File "/Users/temp/anaconda/lib/python3.4/site-packages/requests/adapters.py", line 453, in send
raise ConnectionError(err, request=request)
requests.exceptions.ConnectionError: ('Connection aborted.', BadStatusLine('{"op":"connection","connectionId":"002-040616071750-5507"}\r\n',))
```
Thanks for any help
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3263/reactions"
} | https://api.github.com/repos/psf/requests/issues/3263/timeline | null | completed | null | null | false | [
"This API does not speak HTTP. You would have to create a custom transport adapter. (Personally I think shoehorning this into requests will be quite painful, better create a custom library).\nThey should not reuse the well known port for HTTP.\n",
"Requests is a HTTP library: it is not expected to be able to hand... |
https://api.github.com/repos/psf/requests/issues/3252 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3252/labels{/name} | https://api.github.com/repos/psf/requests/issues/3252/comments | https://api.github.com/repos/psf/requests/issues/3252/events | https://github.com/psf/requests/issues/3252 | 158,042,697 | MDU6SXNzdWUxNTgwNDI2OTc= | 3,252 | Setting Proxy-Authorization Header Manually | {
"avatar_url": "https://avatars.githubusercontent.com/u/1574365?v=4",
"events_url": "https://api.github.com/users/mmedal/events{/privacy}",
"followers_url": "https://api.github.com/users/mmedal/followers",
"following_url": "https://api.github.com/users/mmedal/following{/other_user}",
"gists_url": "https://api.github.com/users/mmedal/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mmedal",
"id": 1574365,
"login": "mmedal",
"node_id": "MDQ6VXNlcjE1NzQzNjU=",
"organizations_url": "https://api.github.com/users/mmedal/orgs",
"received_events_url": "https://api.github.com/users/mmedal/received_events",
"repos_url": "https://api.github.com/users/mmedal/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mmedal/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mmedal/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mmedal",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2016-06-02T01:41:20Z | 2021-09-08T18:00:39Z | 2016-06-02T16:35:32Z | CONTRIBUTOR | resolved | I know you guys have addressed a variety of concerns relating to configuring proxies and that proxying is functionally complex, but I'd like to raise one issue I was having today. We have a new proxy in our environment that requires auth with a yubikey rather than a password. We can simply set an environment variable to a token returned from a yubikey auth endpoint that expires every 12 hours and pass it along with the Proxy-Authorization header in tools like curl, wget, etc... However, it gets a little trickier with requests, as the default api seems to only support including the proxy-user:proxy-pass in the proxy-url.
In our case, we can't do this, as a yubikey token is only good once. As a temporary workaround, I've subclassed HTTPAdapter and modified the proxy_headers method:
```
class CustomHTTPAdapter(HTTPAdapter):
def proxy_headers(self, proxy):
return {
'Proxy-Authorization': 'Basic ' + environ.get('proxy_token', str())
}
```
and then mount it on a Session:
```
import requests
from mypkgs.adapters import CustomHTTPAdapter
s = requests.Session()
s.mount('https://', CustomHTTPAdapter())
s.get('https://someurl')
```
It would be incredibly useful to simply be able to do something like `requests.get(uri, proxy_headers=proxy_headers)`. Am I barking up the wrong tree here or do you have any ideas or feedback?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3252/reactions"
} | https://api.github.com/repos/psf/requests/issues/3252/timeline | null | completed | null | null | false | [
"Generally speaking we're disinclined to add a separate `proxy_headers` kwarg. The vast majority of users don't need it, and those that do are relatively well-served by the `proxy_headers` override of the HTTPAdapter.\n\nRequests is extremely reluctant to add new kwargs to the top-level API if it can possibly be av... |
https://api.github.com/repos/psf/requests/issues/3251 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3251/labels{/name} | https://api.github.com/repos/psf/requests/issues/3251/comments | https://api.github.com/repos/psf/requests/issues/3251/events | https://github.com/psf/requests/pull/3251 | 157,944,941 | MDExOlB1bGxSZXF1ZXN0NzIyMDc1MTY= | 3,251 | Update documentation of Session.max_redirects | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [] | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url... | null | 0 | 2016-06-01T16:01:06Z | 2021-09-08T04:00:56Z | 2016-06-01T18:08:39Z | CONTRIBUTOR | resolved | Fixes #3250
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3251/reactions"
} | https://api.github.com/repos/psf/requests/issues/3251/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3251.diff",
"html_url": "https://github.com/psf/requests/pull/3251",
"merged_at": "2016-06-01T18:08:39Z",
"patch_url": "https://github.com/psf/requests/pull/3251.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3251"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/3250 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3250/labels{/name} | https://api.github.com/repos/psf/requests/issues/3250/comments | https://api.github.com/repos/psf/requests/issues/3250/events | https://github.com/psf/requests/issues/3250 | 157,771,177 | MDU6SXNzdWUxNTc3NzExNzc= | 3,250 | docs don't show correct max_redirects | {
"avatar_url": "https://avatars.githubusercontent.com/u/204779?v=4",
"events_url": "https://api.github.com/users/jvanasco/events{/privacy}",
"followers_url": "https://api.github.com/users/jvanasco/followers",
"following_url": "https://api.github.com/users/jvanasco/following{/other_user}",
"gists_url": "https://api.github.com/users/jvanasco/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jvanasco",
"id": 204779,
"login": "jvanasco",
"node_id": "MDQ6VXNlcjIwNDc3OQ==",
"organizations_url": "https://api.github.com/users/jvanasco/orgs",
"received_events_url": "https://api.github.com/users/jvanasco/received_events",
"repos_url": "https://api.github.com/users/jvanasco/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jvanasco/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jvanasco/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jvanasco",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 10 | 2016-05-31T21:08:46Z | 2021-09-08T17:05:39Z | 2016-06-01T18:08:39Z | CONTRIBUTOR | resolved | In the docs, `max_redirects = None` (http://docs.python-requests.org/en/master/api/?highlight=max_redirects#requests.Session.max_redirects)
however it actually is set to `DEFAULT_REDIRECT_LIMIT` from `.models`...
https://github.com/kennethreitz/requests/blob/cd4e6b9aef4b5d3224a1aae1b3a2cef1b09710a4/requests/sessions.py#L330-L332
... which is defined as `30`
https://github.com/kennethreitz/requests/blob/cd4e6b9aef4b5d3224a1aae1b3a2cef1b09710a4/requests/models.py#L47
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3250/reactions"
} | https://api.github.com/repos/psf/requests/issues/3250/timeline | null | completed | null | null | false | [
"Hrm, this seems to be a problem with the RTD docs build. @sigmavirus24, any ideas?\n",
"So, sphinx is the source of this bug and I suspect it might be fixable but with something that I'm not entirely certain we want to do.\n\nThe following triggers the \"bug\" (a.k.a., limitation in sphinx-doc):\n\n``` py\nclass... |
https://api.github.com/repos/psf/requests/issues/3239 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3239/labels{/name} | https://api.github.com/repos/psf/requests/issues/3239/comments | https://api.github.com/repos/psf/requests/issues/3239/events | https://github.com/psf/requests/issues/3239 | 157,648,668 | MDU6SXNzdWUxNTc2NDg2Njg= | 3,239 | Make RequestEncodingMixin._encode_params() public | {
"avatar_url": "https://avatars.githubusercontent.com/u/15640868?v=4",
"events_url": "https://api.github.com/users/arjennienhuis/events{/privacy}",
"followers_url": "https://api.github.com/users/arjennienhuis/followers",
"following_url": "https://api.github.com/users/arjennienhuis/following{/other_user}",
"gists_url": "https://api.github.com/users/arjennienhuis/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/arjennienhuis",
"id": 15640868,
"login": "arjennienhuis",
"node_id": "MDQ6VXNlcjE1NjQwODY4",
"organizations_url": "https://api.github.com/users/arjennienhuis/orgs",
"received_events_url": "https://api.github.com/users/arjennienhuis/received_events",
"repos_url": "https://api.github.com/users/arjennienhuis/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/arjennienhuis/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/arjennienhuis/subscriptions",
"type": "User",
"url": "https://api.github.com/users/arjennienhuis",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2016-05-31T11:24:56Z | 2021-09-08T17:05:35Z | 2016-06-27T19:52:35Z | NONE | resolved | I need something that does exactly what `RequestEncodingMixin._encode_params()` does. This works in both python2 and 3:
``` py
>>> RequestEncodingMixin._encode_params({u'a': b'b'})
'a=b'
```
Can it be made part of the public API? (Or is it already?)
I am aware that I can just use it as is. But that seems "wrong".
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3239/reactions"
} | https://api.github.com/repos/psf/requests/issues/3239/timeline | null | completed | null | null | false | [
"I don't have any strong feelings on it. I actually am uncertain why we're using a Mixin there when those are static methods and don't need to be declared on a class.\n\nIf we're going to make them public, I'd rather move them to a well documented submodule that does encoding of data and such for requests. That way... |
https://api.github.com/repos/psf/requests/issues/3238 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3238/labels{/name} | https://api.github.com/repos/psf/requests/issues/3238/comments | https://api.github.com/repos/psf/requests/issues/3238/events | https://github.com/psf/requests/issues/3238 | 157,638,068 | MDU6SXNzdWUxNTc2MzgwNjg= | 3,238 | Support proxy protocol http_no_tunnel | {
"avatar_url": "https://avatars.githubusercontent.com/u/3806117?v=4",
"events_url": "https://api.github.com/users/liketic/events{/privacy}",
"followers_url": "https://api.github.com/users/liketic/followers",
"following_url": "https://api.github.com/users/liketic/following{/other_user}",
"gists_url": "https://api.github.com/users/liketic/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/liketic",
"id": 3806117,
"login": "liketic",
"node_id": "MDQ6VXNlcjM4MDYxMTc=",
"organizations_url": "https://api.github.com/users/liketic/orgs",
"received_events_url": "https://api.github.com/users/liketic/received_events",
"repos_url": "https://api.github.com/users/liketic/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/liketic/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/liketic/subscriptions",
"type": "User",
"url": "https://api.github.com/users/liketic",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2016-05-31T10:21:31Z | 2021-09-08T16:00:37Z | 2016-08-05T07:47:01Z | NONE | resolved | Hi,
Is there any way to support 'http_no_tunnel' protocol in proxy? I want to move from httplib2 to requests, but I didn't find any way to archive it. Thanks.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3238/reactions"
} | https://api.github.com/repos/psf/requests/issues/3238/timeline | null | completed | null | null | false | [
"what happens when you preface your hostname with http:// and run? Any difference?\n"
] |
https://api.github.com/repos/psf/requests/issues/3237 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3237/labels{/name} | https://api.github.com/repos/psf/requests/issues/3237/comments | https://api.github.com/repos/psf/requests/issues/3237/events | https://github.com/psf/requests/issues/3237 | 157,529,412 | MDU6SXNzdWUxNTc1Mjk0MTI= | 3,237 | Session cookies handled incorrectly on redirect | {
"avatar_url": "https://avatars.githubusercontent.com/u/1091971?v=4",
"events_url": "https://api.github.com/users/Markus-Goetz/events{/privacy}",
"followers_url": "https://api.github.com/users/Markus-Goetz/followers",
"following_url": "https://api.github.com/users/Markus-Goetz/following{/other_user}",
"gists_url": "https://api.github.com/users/Markus-Goetz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Markus-Goetz",
"id": 1091971,
"login": "Markus-Goetz",
"node_id": "MDQ6VXNlcjEwOTE5NzE=",
"organizations_url": "https://api.github.com/users/Markus-Goetz/orgs",
"received_events_url": "https://api.github.com/users/Markus-Goetz/received_events",
"repos_url": "https://api.github.com/users/Markus-Goetz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Markus-Goetz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Markus-Goetz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Markus-Goetz",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2016-05-30T16:15:13Z | 2021-09-08T18:00:40Z | 2016-05-30T17:32:21Z | NONE | resolved | Hi everyone,
the session cookies are handled incorrectly when being redirected from an https URL to an http resource.The initial cookies have been acquired via an https request to <domain>. Therefore, the secure attribute of the respective cookie is set to True. In a later request to the same domain via https, I am 307 redirected to the very same URL except via http. When requests tries to resolve the redirect it will not copy the cookie over because the `return_ok_secure` check in the `cookielib.py` will obviously fail (mismatch between request.type == 'http' and checked type 'https'). Is that a wrong implementation by the service provider or python-requests? Below a pseudo example:
```
import request
print requests.__version__
>>> '2.10.0'
s = requests.Session()
s.post('https://domain.com/login', data={'login': login, 'pw': pw})
print s.cookies
>>> <RequestsCookieJar[<Cookie token=... for domain.com/>]>
res = s.get('https://domain/com/resource') # redirects internally with 307
```
Unfortunately, I can not provide a minimal working example since the script would include sensitive information.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3237/reactions"
} | https://api.github.com/repos/psf/requests/issues/3237/timeline | null | completed | null | null | false | [
"The `secure` attribute of a cookie should only be set to `True` if the service provider sets it manually. If they _do_ set it manually, that is an instruction that the cookie must not be sent over an insecure (e.g. `http`) channel. Requests is correctly refusing to send that cookie: it should only be sent when TLS... |
https://api.github.com/repos/psf/requests/issues/3236 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3236/labels{/name} | https://api.github.com/repos/psf/requests/issues/3236/comments | https://api.github.com/repos/psf/requests/issues/3236/events | https://github.com/psf/requests/pull/3236 | 157,400,129 | MDExOlB1bGxSZXF1ZXN0NzE4MzQ2NDQ= | 3,236 | Use xfail marker for a test expected to fail without Internet connection | {
"avatar_url": "https://avatars.githubusercontent.com/u/212279?v=4",
"events_url": "https://api.github.com/users/eriol/events{/privacy}",
"followers_url": "https://api.github.com/users/eriol/followers",
"following_url": "https://api.github.com/users/eriol/following{/other_user}",
"gists_url": "https://api.github.com/users/eriol/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/eriol",
"id": 212279,
"login": "eriol",
"node_id": "MDQ6VXNlcjIxMjI3OQ==",
"organizations_url": "https://api.github.com/users/eriol/orgs",
"received_events_url": "https://api.github.com/users/eriol/received_events",
"repos_url": "https://api.github.com/users/eriol/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/eriol/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/eriol/subscriptions",
"type": "User",
"url": "https://api.github.com/users/eriol",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2016-05-29T18:57:33Z | 2021-09-08T03:00:59Z | 2016-06-21T02:17:24Z | CONTRIBUTOR | resolved | This is only a minor improvement on the great work of https://github.com/kennethreitz/requests/pull/2859 that permits to run tests on hosts without Internet connection without failures.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3236/reactions"
} | https://api.github.com/repos/psf/requests/issues/3236/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3236.diff",
"html_url": "https://github.com/psf/requests/pull/3236",
"merged_at": "2016-06-21T02:17:24Z",
"patch_url": "https://github.com/psf/requests/pull/3236.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3236"
} | true | [
"Not sure why no-one's gotten back to you on this yet — my apologies. \n\nThis looks like a great improvement. Thank you. \n",
"@eriol I'm so sorry. I think I lost track of this while I was travelling to PyCon. I expect the same happened to @Lukasa \n",
"Sorry for my late reply... No need to apologize! I was aw... |
https://api.github.com/repos/psf/requests/issues/3225 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3225/labels{/name} | https://api.github.com/repos/psf/requests/issues/3225/comments | https://api.github.com/repos/psf/requests/issues/3225/events | https://github.com/psf/requests/pull/3225 | 157,382,518 | MDExOlB1bGxSZXF1ZXN0NzE4MjUyMzQ= | 3,225 | Convert readthedocs link for their .org -> .io migration for hosted projects | {
"avatar_url": "https://avatars.githubusercontent.com/u/857609?v=4",
"events_url": "https://api.github.com/users/adamchainz/events{/privacy}",
"followers_url": "https://api.github.com/users/adamchainz/followers",
"following_url": "https://api.github.com/users/adamchainz/following{/other_user}",
"gists_url": "https://api.github.com/users/adamchainz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/adamchainz",
"id": 857609,
"login": "adamchainz",
"node_id": "MDQ6VXNlcjg1NzYwOQ==",
"organizations_url": "https://api.github.com/users/adamchainz/orgs",
"received_events_url": "https://api.github.com/users/adamchainz/received_events",
"repos_url": "https://api.github.com/users/adamchainz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/adamchainz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/adamchainz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/adamchainz",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2016-05-29T11:48:56Z | 2021-09-08T04:00:57Z | 2016-05-29T13:09:48Z | NONE | resolved | As per their email ‘Changes to project subdomains’:
> Starting today, Read the Docs will start hosting projects from subdomains on the domain readthedocs.io, instead of on readthedocs.org. This change addresses some security concerns around site cookies while hosting user generated data on the same domain as our dashboard.
Test Plan: Manually visited all the links I’ve modified.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/857609?v=4",
"events_url": "https://api.github.com/users/adamchainz/events{/privacy}",
"followers_url": "https://api.github.com/users/adamchainz/followers",
"following_url": "https://api.github.com/users/adamchainz/following{/other_user}",
"gists_url": "https://api.github.com/users/adamchainz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/adamchainz",
"id": 857609,
"login": "adamchainz",
"node_id": "MDQ6VXNlcjg1NzYwOQ==",
"organizations_url": "https://api.github.com/users/adamchainz/orgs",
"received_events_url": "https://api.github.com/users/adamchainz/received_events",
"repos_url": "https://api.github.com/users/adamchainz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/adamchainz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/adamchainz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/adamchainz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3225/reactions"
} | https://api.github.com/repos/psf/requests/issues/3225/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3225.diff",
"html_url": "https://github.com/psf/requests/pull/3225",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/3225.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3225"
} | true | [
"Just realized these are all in `urllib3`, replaced with shazow/urllib3#882\n"
] |
https://api.github.com/repos/psf/requests/issues/3224 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3224/labels{/name} | https://api.github.com/repos/psf/requests/issues/3224/comments | https://api.github.com/repos/psf/requests/issues/3224/events | https://github.com/psf/requests/issues/3224 | 157,332,409 | MDU6SXNzdWUxNTczMzI0MDk= | 3,224 | Global verify options | {
"avatar_url": "https://avatars.githubusercontent.com/u/9717944?v=4",
"events_url": "https://api.github.com/users/abelmokadem/events{/privacy}",
"followers_url": "https://api.github.com/users/abelmokadem/followers",
"following_url": "https://api.github.com/users/abelmokadem/following{/other_user}",
"gists_url": "https://api.github.com/users/abelmokadem/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/abelmokadem",
"id": 9717944,
"login": "abelmokadem",
"node_id": "MDQ6VXNlcjk3MTc5NDQ=",
"organizations_url": "https://api.github.com/users/abelmokadem/orgs",
"received_events_url": "https://api.github.com/users/abelmokadem/received_events",
"repos_url": "https://api.github.com/users/abelmokadem/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/abelmokadem/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/abelmokadem/subscriptions",
"type": "User",
"url": "https://api.github.com/users/abelmokadem",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2016-05-28T10:35:52Z | 2021-09-08T18:00:40Z | 2016-05-28T14:42:03Z | NONE | resolved | I have noticed that it is possible to specify `verify=False` in order to avoid `CERTIFICATE_VERIFY_FAILED`. Is it possible to globally set this option?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3224/reactions"
} | https://api.github.com/repos/psf/requests/issues/3224/timeline | null | completed | null | null | false | [
"It is not, no.\n\nSetting `verify=False` is an extremely insecure thing to do, and should be avoided if at all possible. Having a hook that enables you to _globally_ disable TLS certificate verification is extremely insecure, and is also where we draw the line.\n",
"Further, we request that all questions be aske... |
https://api.github.com/repos/psf/requests/issues/3223 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3223/labels{/name} | https://api.github.com/repos/psf/requests/issues/3223/comments | https://api.github.com/repos/psf/requests/issues/3223/events | https://github.com/psf/requests/issues/3223 | 157,219,651 | MDU6SXNzdWUxNTcyMTk2NTE= | 3,223 | Handling no network at startup in Requests | {
"avatar_url": "https://avatars.githubusercontent.com/u/12682170?v=4",
"events_url": "https://api.github.com/users/shreepads/events{/privacy}",
"followers_url": "https://api.github.com/users/shreepads/followers",
"following_url": "https://api.github.com/users/shreepads/following{/other_user}",
"gists_url": "https://api.github.com/users/shreepads/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/shreepads",
"id": 12682170,
"login": "shreepads",
"node_id": "MDQ6VXNlcjEyNjgyMTcw",
"organizations_url": "https://api.github.com/users/shreepads/orgs",
"received_events_url": "https://api.github.com/users/shreepads/received_events",
"repos_url": "https://api.github.com/users/shreepads/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/shreepads/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/shreepads/subscriptions",
"type": "User",
"url": "https://api.github.com/users/shreepads",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 6 | 2016-05-27T14:31:17Z | 2021-09-08T16:00:37Z | 2016-08-05T07:47:29Z | NONE | resolved | To be honest I don't know if I'm doing something wrong, but I am unable to find a solution so here goes.
This is running on my laptop connected over wifi - no proxies.I'm on Fedora 23, running requests 2.10.0 in a Python 3.4.3 virtual env.
I have an infinite loop running requests.get's on a http url (say 'http://info.cern.ch/hypertext/WWW/TheProject.html') and sleeping.
If I start the program with wifi ON, it works well. The gets succeed. If I turn OFF wifi on my laptop (program still running), the gets start throwing exceptions which I catch and handle. Then when I turn wifi ON again (program still running), the gets start working again.
But if I turn wifi OFF and then start the program, it doesn't work. The gets throw exceptions which I catch and handle. But then if I turn ON the wifi (program still running) the gets continue to throw exceptions. At this point I can access the url from my browser but the requests.get()s continue to fail throwing
`RequestException: HTTPConnectionPool(host='info.cern.ch', port=80): Max retries exceeded with url: /hypertext/WWW/TheProject.html (Caused by NewConnectionError('<requests.packages.urllib3.connection.HTTPConnection object at 0x7fe105b12cf8>: Failed to establish a new connection: [Errno -5] No address associated with hostname',))`
Best I can make out is that the HTTPConnectionPool created at startup - with wifi OFF - somehow sticks around (probably tied to the eth interface?) and continues to fail even though wifi is now working.
I have tried creating a Session in the while loop and explicitly close() ing it at the end. I've tried creating a Session outside the while loop and close() and re-creating it inside the get() exception handling. I've even tried `import requests` inside the while loop (yes I know that's a bad idea) but even that fails.
I can reproduce this behaviour from the Python REPL environment as follows:
1. Turn OFF wifi
2. Start REPL, import requests and get()
```
$ python
Python 3.4.3 (default, Mar 31 2016, 20:42:37)
[GCC 5.3.1 20151207 (Red Hat 5.3.1-2)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import requests
>>>
>>>
>>> requests.get('http://google.com')
Traceback (most recent call last):
File "~/venv/lib64/python3.4/site-packages/requests/packages/urllib3/connection.py", line 142, in _new_conn
(self.host, self.port), self.timeout, **extra_kw)
File "~/venv/lib64/python3.4/site-packages/requests/packages/urllib3/util/connection.py", line 67, in create_connection
for res in socket.getaddrinfo(host, port, 0, socket.SOCK_STREAM):
File "/usr/lib64/python3.4/socket.py", line 533, in getaddrinfo
for res in _socket.getaddrinfo(host, port, family, type, proto, flags):
socket.gaierror: [Errno -5] No address associated with hostname
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "~/venv/lib64/python3.4/site-packages/requests/packages/urllib3/connectionpool.py", line 578, in urlopen
chunked=chunked)
File "~/venv/lib64/python3.4/site-packages/requests/packages/urllib3/connectionpool.py", line 362, in _make_request
conn.request(method, url, **httplib_request_kw)
File "/usr/lib64/python3.4/http/client.py", line 1088, in request
self._send_request(method, url, body, headers)
File "/usr/lib64/python3.4/http/client.py", line 1126, in _send_request
self.endheaders(body)
File "/usr/lib64/python3.4/http/client.py", line 1084, in endheaders
self._send_output(message_body)
File "/usr/lib64/python3.4/http/client.py", line 922, in _send_output
self.send(msg)
File "/usr/lib64/python3.4/http/client.py", line 857, in send
self.connect()
File "~/venv/lib64/python3.4/site-packages/requests/packages/urllib3/connection.py", line 167, in connect
conn = self._new_conn()
File "~/venv/lib64/python3.4/site-packages/requests/packages/urllib3/connection.py", line 151, in _new_conn
self, "Failed to establish a new connection: %s" % e)
requests.packages.urllib3.exceptions.NewConnectionError: <requests.packages.urllib3.connection.HTTPConnection object at 0x7fb41c6dcb00>: Failed to establish a new connection: [Errno -5] No address associated with hostname
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "~/venv/lib64/python3.4/site-packages/requests/adapters.py", line 403, in send
timeout=timeout
File "~/venv/lib64/python3.4/site-packages/requests/packages/urllib3/connectionpool.py", line 623, in urlopen
_stacktrace=sys.exc_info()[2])
File "~/venv/lib64/python3.4/site-packages/requests/packages/urllib3/util/retry.py", line 281, in increment
raise MaxRetryError(_pool, url, error or ResponseError(cause))
requests.packages.urllib3.exceptions.MaxRetryError: HTTPConnectionPool(host='google.com', port=80): Max retries exceeded with url: / (Caused by NewConnectionError('<requests.packages.urllib3.connection.HTTPConnection object at 0x7fb41c6dcb00>: Failed to establish a new connection: [Errno -5] No address associated with hostname',))
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "~/venv/lib64/python3.4/site-packages/requests/api.py", line 71, in get
return request('get', url, params=params, **kwargs)
File "~/venv/lib64/python3.4/site-packages/requests/api.py", line 57, in request
return session.request(method=method, url=url, **kwargs)
File "~/venv/lib64/python3.4/site-packages/requests/sessions.py", line 475, in request
resp = self.send(prep, **send_kwargs)
File "~/venv/lib64/python3.4/site-packages/requests/sessions.py", line 585, in send
r = adapter.send(request, **kwargs)
File "~/venv/lib64/python3.4/site-packages/requests/adapters.py", line 467, in send
raise ConnectionError(e, request=request)
requests.exceptions.ConnectionError: HTTPConnectionPool(host='google.com', port=80): Max retries exceeded with url: / (Caused by NewConnectionError('<requests.packages.urllib3.connection.HTTPConnection object at 0x7fb41c6dcb00>: Failed to establish a new connection: [Errno -5] No address associated with hostname',))
>>>
```
1. Turn ON wifi, google.com accessible from browser
2. Back to REPL get() errors
```
>>> requests.get('http://google.com')
Traceback (most recent call last):
File "~/venv/lib64/python3.4/site-packages/requests/packages/urllib3/connection.py", line 142, in _new_conn
(self.host, self.port), self.timeout, **extra_kw)
File "~/venv/lib64/python3.4/site-packages/requests/packages/urllib3/util/connection.py", line 67, in create_connection
for res in socket.getaddrinfo(host, port, 0, socket.SOCK_STREAM):
File "/usr/lib64/python3.4/socket.py", line 533, in getaddrinfo
for res in _socket.getaddrinfo(host, port, family, type, proto, flags):
socket.gaierror: [Errno -5] No address associated with hostname
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "~/venv/lib64/python3.4/site-packages/requests/packages/urllib3/connectionpool.py", line 578, in urlopen
chunked=chunked)
File "~/venv/lib64/python3.4/site-packages/requests/packages/urllib3/connectionpool.py", line 362, in _make_request
conn.request(method, url, **httplib_request_kw)
File "/usr/lib64/python3.4/http/client.py", line 1088, in request
self._send_request(method, url, body, headers)
File "/usr/lib64/python3.4/http/client.py", line 1126, in _send_request
self.endheaders(body)
File "/usr/lib64/python3.4/http/client.py", line 1084, in endheaders
self._send_output(message_body)
File "/usr/lib64/python3.4/http/client.py", line 922, in _send_output
self.send(msg)
File "/usr/lib64/python3.4/http/client.py", line 857, in send
self.connect()
File "~/venv/lib64/python3.4/site-packages/requests/packages/urllib3/connection.py", line 167, in connect
conn = self._new_conn()
File "~/venv/lib64/python3.4/site-packages/requests/packages/urllib3/connection.py", line 151, in _new_conn
self, "Failed to establish a new connection: %s" % e)
requests.packages.urllib3.exceptions.NewConnectionError: <requests.packages.urllib3.connection.HTTPConnection object at 0x7fb41c6f4470>: Failed to establish a new connection: [Errno -5] No address associated with hostname
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "~/venv/lib64/python3.4/site-packages/requests/adapters.py", line 403, in send
timeout=timeout
File "~/venv/lib64/python3.4/site-packages/requests/packages/urllib3/connectionpool.py", line 623, in urlopen
_stacktrace=sys.exc_info()[2])
File "~/venv/lib64/python3.4/site-packages/requests/packages/urllib3/util/retry.py", line 281, in increment
raise MaxRetryError(_pool, url, error or ResponseError(cause))
requests.packages.urllib3.exceptions.MaxRetryError: HTTPConnectionPool(host='google.com', port=80): Max retries exceeded with url: / (Caused by NewConnectionError('<requests.packages.urllib3.connection.HTTPConnection object at 0x7fb41c6f4470>: Failed to establish a new connection: [Errno -5] No address associated with hostname',))
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "~/venv/lib64/python3.4/site-packages/requests/api.py", line 71, in get
return request('get', url, params=params, **kwargs)
File "~/venv/lib64/python3.4/site-packages/requests/api.py", line 57, in request
return session.request(method=method, url=url, **kwargs)
File "~/venv/lib64/python3.4/site-packages/requests/sessions.py", line 475, in request
resp = self.send(prep, **send_kwargs)
File "~/venv/lib64/python3.4/site-packages/requests/sessions.py", line 585, in send
r = adapter.send(request, **kwargs)
File "~/venv/lib64/python3.4/site-packages/requests/adapters.py", line 467, in send
raise ConnectionError(e, request=request)
requests.exceptions.ConnectionError: HTTPConnectionPool(host='google.com', port=80): Max retries exceeded with url: / (Caused by NewConnectionError('<requests.packages.urllib3.connection.HTTPConnection object at 0x7fb41c6f4470>: Failed to establish a new connection: [Errno -5] No address associated with hostname',))
>>>
```
I expect the second get() to work. Particularly if I've used a Session explicitly.
Wifi OFF
```
$ python
Python 3.4.3 (default, Mar 31 2016, 20:42:37)
[GCC 5.3.1 20151207 (Red Hat 5.3.1-2)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import requests
>>> sess = requests.session()
>>> sess.get('http://www.google.com')
Traceback (most recent call last):
File "~/venv/lib64/python3.4/site-packages/requests/packages/urllib3/connection.py", line 142, in _new_conn
(self.host, self.port), self.timeout, **extra_kw)
File "~/venv/lib64/python3.4/site-packages/requests/packages/urllib3/util/connection.py", line 67, in create_connection
for res in socket.getaddrinfo(host, port, 0, socket.SOCK_STREAM):
File "/usr/lib64/python3.4/socket.py", line 533, in getaddrinfo
for res in _socket.getaddrinfo(host, port, family, type, proto, flags):
socket.gaierror: [Errno -5] No address associated with hostname
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "~/venv/lib64/python3.4/site-packages/requests/packages/urllib3/connectionpool.py", line 578, in urlopen
chunked=chunked)
File "~/venv/lib64/python3.4/site-packages/requests/packages/urllib3/connectionpool.py", line 362, in _make_request
conn.request(method, url, **httplib_request_kw)
File "/usr/lib64/python3.4/http/client.py", line 1088, in request
self._send_request(method, url, body, headers)
File "/usr/lib64/python3.4/http/client.py", line 1126, in _send_request
self.endheaders(body)
File "/usr/lib64/python3.4/http/client.py", line 1084, in endheaders
self._send_output(message_body)
File "/usr/lib64/python3.4/http/client.py", line 922, in _send_output
self.send(msg)
File "/usr/lib64/python3.4/http/client.py", line 857, in send
self.connect()
File "~/venv/lib64/python3.4/site-packages/requests/packages/urllib3/connection.py", line 167, in connect
conn = self._new_conn()
File "~/venv/lib64/python3.4/site-packages/requests/packages/urllib3/connection.py", line 151, in _new_conn
self, "Failed to establish a new connection: %s" % e)
requests.packages.urllib3.exceptions.NewConnectionError: <requests.packages.urllib3.connection.HTTPConnection object at 0x7f8e83e0ab00>: Failed to establish a new connection: [Errno -5] No address associated with hostname
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "~/venv/lib64/python3.4/site-packages/requests/adapters.py", line 403, in send
timeout=timeout
File "~/venv/lib64/python3.4/site-packages/requests/packages/urllib3/connectionpool.py", line 623, in urlopen
_stacktrace=sys.exc_info()[2])
File "~/venv/lib64/python3.4/site-packages/requests/packages/urllib3/util/retry.py", line 281, in increment
raise MaxRetryError(_pool, url, error or ResponseError(cause))
requests.packages.urllib3.exceptions.MaxRetryError: HTTPConnectionPool(host='www.google.com', port=80): Max retries exceeded with url: / (Caused by NewConnectionError('<requests.packages.urllib3.connection.HTTPConnection object at 0x7f8e83e0ab00>: Failed to establish a new connection: [Errno -5] No address associated with hostname',))
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "~/venv/lib64/python3.4/site-packages/requests/sessions.py", line 487, in get
return self.request('GET', url, **kwargs)
File "~/venv/lib64/python3.4/site-packages/requests/sessions.py", line 475, in request
resp = self.send(prep, **send_kwargs)
File "~/venv/lib64/python3.4/site-packages/requests/sessions.py", line 585, in send
r = adapter.send(request, **kwargs)
File "~/venv/lib64/python3.4/site-packages/requests/adapters.py", line 467, in send
raise ConnectionError(e, request=request)
requests.exceptions.ConnectionError: HTTPConnectionPool(host='www.google.com', port=80): Max retries exceeded with url: / (Caused by NewConnectionError('<requests.packages.urllib3.connection.HTTPConnection object at 0x7f8e83e0ab00>: Failed to establish a new connection: [Errno -5] No address associated with hostname',))
>>> sess.close()
>>> del sess
```
wifi ON, google.com reachable from browser
```
>>> sess = requests.session()
>>> sess.get('http://www.google.com')
Traceback (most recent call last):
File "~/venv/lib64/python3.4/site-packages/requests/packages/urllib3/connection.py", line 142, in _new_conn
(self.host, self.port), self.timeout, **extra_kw)
File "~/venv/lib64/python3.4/site-packages/requests/packages/urllib3/util/connection.py", line 67, in create_connection
for res in socket.getaddrinfo(host, port, 0, socket.SOCK_STREAM):
File "/usr/lib64/python3.4/socket.py", line 533, in getaddrinfo
for res in _socket.getaddrinfo(host, port, family, type, proto, flags):
socket.gaierror: [Errno -5] No address associated with hostname
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "~/venv/lib64/python3.4/site-packages/requests/packages/urllib3/connectionpool.py", line 578, in urlopen
chunked=chunked)
File "~/venv/lib64/python3.4/site-packages/requests/packages/urllib3/connectionpool.py", line 362, in _make_request
conn.request(method, url, **httplib_request_kw)
File "/usr/lib64/python3.4/http/client.py", line 1088, in request
self._send_request(method, url, body, headers)
File "/usr/lib64/python3.4/http/client.py", line 1126, in _send_request
self.endheaders(body)
File "/usr/lib64/python3.4/http/client.py", line 1084, in endheaders
self._send_output(message_body)
File "/usr/lib64/python3.4/http/client.py", line 922, in _send_output
self.send(msg)
File "/usr/lib64/python3.4/http/client.py", line 857, in send
self.connect()
File "~/venv/lib64/python3.4/site-packages/requests/packages/urllib3/connection.py", line 167, in connect
conn = self._new_conn()
File "~/venv/lib64/python3.4/site-packages/requests/packages/urllib3/connection.py", line 151, in _new_conn
self, "Failed to establish a new connection: %s" % e)
requests.packages.urllib3.exceptions.NewConnectionError: <requests.packages.urllib3.connection.HTTPConnection object at 0x7f8e83e234e0>: Failed to establish a new connection: [Errno -5] No address associated with hostname
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "~/venv/lib64/python3.4/site-packages/requests/adapters.py", line 403, in send
timeout=timeout
File "~/venv/lib64/python3.4/site-packages/requests/packages/urllib3/connectionpool.py", line 623, in urlopen
_stacktrace=sys.exc_info()[2])
File "~/venv/lib64/python3.4/site-packages/requests/packages/urllib3/util/retry.py", line 281, in increment
raise MaxRetryError(_pool, url, error or ResponseError(cause))
requests.packages.urllib3.exceptions.MaxRetryError: HTTPConnectionPool(host='www.google.com', port=80): Max retries exceeded with url: / (Caused by NewConnectionError('<requests.packages.urllib3.connection.HTTPConnection object at 0x7f8e83e234e0>: Failed to establish a new connection: [Errno -5] No address associated with hostname',))
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "~/venv/lib64/python3.4/site-packages/requests/sessions.py", line 487, in get
return self.request('GET', url, **kwargs)
File "~/venv/lib64/python3.4/site-packages/requests/sessions.py", line 475, in request
resp = self.send(prep, **send_kwargs)
File "~/venv/lib64/python3.4/site-packages/requests/sessions.py", line 585, in send
r = adapter.send(request, **kwargs)
File "~/venv/lib64/python3.4/site-packages/requests/adapters.py", line 467, in send
raise ConnectionError(e, request=request)
requests.exceptions.ConnectionError: HTTPConnectionPool(host='www.google.com', port=80): Max retries exceeded with url: / (Caused by NewConnectionError('<requests.packages.urllib3.connection.HTTPConnection object at 0x7f8e83e234e0>: Failed to establish a new connection: [Errno -5] No address associated with hostname',))
>>>
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3223/reactions"
} | https://api.github.com/repos/psf/requests/issues/3223/timeline | null | completed | null | null | false | [
"Hrm. This is what I'd call \"somewhat puzzling\". I'm travelling at the moment so I don't have time to dive into this right this second, but I'll aim to take a look in the next couple of days and see if I can repro this.\n",
"Ok, so here's the thing.\n\nRequests has no implicit global state. That means that two ... |
https://api.github.com/repos/psf/requests/issues/3222 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3222/labels{/name} | https://api.github.com/repos/psf/requests/issues/3222/comments | https://api.github.com/repos/psf/requests/issues/3222/events | https://github.com/psf/requests/issues/3222 | 157,042,171 | MDU6SXNzdWUxNTcwNDIxNzE= | 3,222 | Session.request() overrides socket.setdefaulttimeout() | {
"avatar_url": "https://avatars.githubusercontent.com/u/3270755?v=4",
"events_url": "https://api.github.com/users/adeverteuil/events{/privacy}",
"followers_url": "https://api.github.com/users/adeverteuil/followers",
"following_url": "https://api.github.com/users/adeverteuil/following{/other_user}",
"gists_url": "https://api.github.com/users/adeverteuil/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/adeverteuil",
"id": 3270755,
"login": "adeverteuil",
"node_id": "MDQ6VXNlcjMyNzA3NTU=",
"organizations_url": "https://api.github.com/users/adeverteuil/orgs",
"received_events_url": "https://api.github.com/users/adeverteuil/received_events",
"repos_url": "https://api.github.com/users/adeverteuil/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/adeverteuil/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/adeverteuil/subscriptions",
"type": "User",
"url": "https://api.github.com/users/adeverteuil",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2016-05-26T17:56:54Z | 2021-09-08T16:00:36Z | 2016-08-05T07:47:58Z | NONE | resolved | Hello,
I am using requests 2.10.0 and Python 2.7.11.
By setting `timeout=None` by default in the `session.Session().request()` method's default parameters, the value `None` is propagated all the way to the low level `socket` module, overriding whatever value was set using `socket.setdefaulttimeout(_timeout_)`.
If the user doesn't assign a timeout value, the expected result is that `socket.getdefaulttimeout()` is used. To get this behavior, the value of `packages.urllib3.util.timeout._default` should be used by default instead of None, since None has a special meaning. This can be done by importing `packages.urllib3.util.Timeout` as `TimeoutSauce` (as it is done in the `adapter` module) and assigning `timeout=TimeoutSauce.DEFAULT_TIMEOUT`.
Here is a unit test suite that shows that using `socket` directly respects `socket.getdefaulttimeout()` and another test using `requests` that blocks indefinitely unless the above modification is applied.
```
# usage: python -m unittest discover
import socket
import unittest
import requests
class SocketTimeoutTestCase(unittest.TestCase):
def setUp(self):
self.original_timeout = socket.getdefaulttimeout()
socket.setdefaulttimeout(0.1)
self.host = '127.0.0.1'
self.port = 50000
self.server = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
self.server.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)
self.server.bind((self.host, self.port))
self.server.listen(1)
def tearDown(self):
socket.setdefaulttimeout(self.original_timeout)
self.server.close()
def test_default_timeout_with_socket(self):
client = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
with self.assertRaises(socket.timeout):
client.connect((self.host, self.port))
conn, addr = self.server.accept()
client.recv(1024)
conn.close()
def test_default_timeout_with_requests(self):
with self.assertRaises(requests.Timeout):
r = requests.get('http://{}:{}/'.format(self.host, self.port))
```
May I submit a pull request? I need to read contributing guidelines to prepare it correctly as this would be my first pull request. As far as I know (and I am not familiar with the code base), only the `session` module requires modification, but you may know better.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3222/reactions"
} | https://api.github.com/repos/psf/requests/issues/3222/timeline | null | completed | null | null | false | [
"This is related to \n- https://github.com/shazow/urllib3/issues/655\n\nWhich has been fixed for 3.0.0 because it's otherwise not backwards compatible.\n"
] |
https://api.github.com/repos/psf/requests/issues/3221 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3221/labels{/name} | https://api.github.com/repos/psf/requests/issues/3221/comments | https://api.github.com/repos/psf/requests/issues/3221/events | https://github.com/psf/requests/issues/3221 | 156,979,920 | MDU6SXNzdWUxNTY5Nzk5MjA= | 3,221 | did it update doc? | {
"avatar_url": "https://avatars.githubusercontent.com/u/4942395?v=4",
"events_url": "https://api.github.com/users/yangbeom/events{/privacy}",
"followers_url": "https://api.github.com/users/yangbeom/followers",
"following_url": "https://api.github.com/users/yangbeom/following{/other_user}",
"gists_url": "https://api.github.com/users/yangbeom/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/yangbeom",
"id": 4942395,
"login": "yangbeom",
"node_id": "MDQ6VXNlcjQ5NDIzOTU=",
"organizations_url": "https://api.github.com/users/yangbeom/orgs",
"received_events_url": "https://api.github.com/users/yangbeom/received_events",
"repos_url": "https://api.github.com/users/yangbeom/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/yangbeom/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yangbeom/subscriptions",
"type": "User",
"url": "https://api.github.com/users/yangbeom",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2016-05-26T13:10:15Z | 2021-09-08T18:00:41Z | 2016-05-26T13:27:34Z | NONE | resolved | I translate Doc into Doc-KR.
in todo.rst
> As of v1.0.0, Requests has now entered a feature freeze.
did this translate or delete?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/4942395?v=4",
"events_url": "https://api.github.com/users/yangbeom/events{/privacy}",
"followers_url": "https://api.github.com/users/yangbeom/followers",
"following_url": "https://api.github.com/users/yangbeom/following{/other_user}",
"gists_url": "https://api.github.com/users/yangbeom/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/yangbeom",
"id": 4942395,
"login": "yangbeom",
"node_id": "MDQ6VXNlcjQ5NDIzOTU=",
"organizations_url": "https://api.github.com/users/yangbeom/orgs",
"received_events_url": "https://api.github.com/users/yangbeom/received_events",
"repos_url": "https://api.github.com/users/yangbeom/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/yangbeom/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/yangbeom/subscriptions",
"type": "User",
"url": "https://api.github.com/users/yangbeom",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3221/reactions"
} | https://api.github.com/repos/psf/requests/issues/3221/timeline | null | completed | null | null | false | [
"That sentence is true, but it's still fine to continue with translations. =)\n",
"@lukasa Thanks :) i think that sentence is unnecessary in v2.10.0, so seek your advice.\n",
"It's still necessary: we're still in a nominal feature freeze. =)\n",
"@Lukasa make sense!! thanks =)\n"
] |
https://api.github.com/repos/psf/requests/issues/3220 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3220/labels{/name} | https://api.github.com/repos/psf/requests/issues/3220/comments | https://api.github.com/repos/psf/requests/issues/3220/events | https://github.com/psf/requests/issues/3220 | 156,878,829 | MDU6SXNzdWUxNTY4Nzg4Mjk= | 3,220 | Location Value Error when trying to post through a session | {
"avatar_url": "https://avatars.githubusercontent.com/u/8885119?v=4",
"events_url": "https://api.github.com/users/hudcoley/events{/privacy}",
"followers_url": "https://api.github.com/users/hudcoley/followers",
"following_url": "https://api.github.com/users/hudcoley/following{/other_user}",
"gists_url": "https://api.github.com/users/hudcoley/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/hudcoley",
"id": 8885119,
"login": "hudcoley",
"node_id": "MDQ6VXNlcjg4ODUxMTk=",
"organizations_url": "https://api.github.com/users/hudcoley/orgs",
"received_events_url": "https://api.github.com/users/hudcoley/received_events",
"repos_url": "https://api.github.com/users/hudcoley/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/hudcoley/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hudcoley/subscriptions",
"type": "User",
"url": "https://api.github.com/users/hudcoley",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 11 | 2016-05-26T00:25:05Z | 2021-09-08T16:00:34Z | 2016-08-05T07:55:18Z | NONE | resolved | I am using a 3rd party library that uses requests, and when I try to post using a session I get this error:
File "", line 1, in
File "/usr/local/lib/python2.7/dist-packages/pacer_lib/scraper.py", line 42, in init
self.refresh_login()
File "/usr/local/lib/python2.7/dist-packages/pacer_lib/scraper.py", line 74, in refresh_login
response = self.br.post(login_url, data=payload)
File "/usr/lib/python2.7/dist-packages/requests/sessions.py", line 500, in post
return self.request('POST', url, data=data, json=json, _kwargs)
File "/usr/lib/python2.7/dist-packages/requests/sessions.py", line 457, in request
resp = self.send(prep, *send_kwargs)
File "/usr/lib/python2.7/dist-packages/requests/sessions.py", line 595, in send
history = [resp for resp in gen] if allow_redirects else []
File "/usr/lib/python2.7/dist-packages/requests/sessions.py", line 189, in resolve_redirects
allow_redirects=False,
File "/usr/lib/python2.7/dist-packages/requests/sessions.py", line 569, in send
r = adapter.send(request, *_kwargs)
File "/usr/lib/python2.7/dist-packages/requests/adapters.py", line 329, in send
conn = self.get_connection(request.url, proxies)
File "/usr/lib/python2.7/dist-packages/requests/adapters.py", line 243, in get_connection
conn = self.poolmanager.connection_from_url(url)
File "/usr/lib/python2.7/dist-packages/urllib3/poolmanager.py", line 131, in connection_from_url
return self.connection_from_host(u.host, port=u.port, scheme=u.scheme)
File "/usr/lib/python2.7/dist-packages/urllib3/poolmanager.py", line 102, in connection_from_host
raise LocationValueError("No host specified.")
urllib3.exceptions.LocationValueError: No host specified.
here is the relevant source from pacer_lib
def refresh_login(self):
"""
Logs in to the PACER system using the login and password provided at
the initialization of `search_agent()`. This will create a Requests
session that will allow you to query the PACER system. If
_auto_login_ =False, `refresh_login()` must be called before you can
query the case_locator. This function will raise an error if you
supply an invalid login or password.
```
Returns nothing.
"""
#SETTINGS (determined from the form from PACER's '/login.pl')
payload = {'loginid':self.username, 'passwd':self.password}
login_url = 'https://pacer.login.uscourts.gov/cgi-bin/check-pacer-passwd.pl'
self.br = requests.Session()
response = self.br.post(login_url, data=payload)
```
I have tried just posting without a session and it works (at least I get a 200), but every time I try to use a session I get that same error. Any help would be greatly appreciated
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3220/reactions"
} | https://api.github.com/repos/psf/requests/issues/3220/timeline | null | completed | null | null | false | [
"In this instance the problem seems to be related to a redirect occurring. Are you sure that nothing is being set on the session here, anywhere in the code?\n",
"It doesn't look like it is, as far as I can tell. This method that is creating the session is invoked in the constructor of a class, and the session 'br... |
https://api.github.com/repos/psf/requests/issues/3219 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3219/labels{/name} | https://api.github.com/repos/psf/requests/issues/3219/comments | https://api.github.com/repos/psf/requests/issues/3219/events | https://github.com/psf/requests/issues/3219 | 156,497,454 | MDU6SXNzdWUxNTY0OTc0NTQ= | 3,219 | requests does not provide a way to send full chain-of-trust when server makes a CertificateRequest | {
"avatar_url": "https://avatars.githubusercontent.com/u/6081083?v=4",
"events_url": "https://api.github.com/users/jaloren/events{/privacy}",
"followers_url": "https://api.github.com/users/jaloren/followers",
"following_url": "https://api.github.com/users/jaloren/following{/other_user}",
"gists_url": "https://api.github.com/users/jaloren/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jaloren",
"id": 6081083,
"login": "jaloren",
"node_id": "MDQ6VXNlcjYwODEwODM=",
"organizations_url": "https://api.github.com/users/jaloren/orgs",
"received_events_url": "https://api.github.com/users/jaloren/received_events",
"repos_url": "https://api.github.com/users/jaloren/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jaloren/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jaloren/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jaloren",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2016-05-24T12:43:04Z | 2021-09-08T18:00:42Z | 2016-05-24T12:46:55Z | NONE | resolved | I am on python2.7 installed on CentOS 6. I have OpenSSL 1.0.1e. I have requests version 2.9.1. The HTTP server is performing SSL client authentication. The client's chain has a verification depth of 2, which means there's a single intermediate CA certificate in the client chain. I am not sure if this is a bug or a feature request.
Based on the public api, I sent a request in like so. note i have explicitly chosen not to verify the server's chain of trust (i know that's not secure but this isn't being used in production). The cert.pem contains the client's PEM-encoded certificate, the intermediate CA cert, and the root cert. The final entity in the cert.pem is the client's private key (which is NOT encrypted).
resp = requests.get(url,verify=False,cert='cert.pem')
The following exception is thrown.
requests.exceptions.SSLError: [Errno bad handshake](-1,)
Looking at the server's ssl logs, I can see that the reason the server terminated the SSL connection was caused by the server's inability to construct the client's chain-of-trust. The server could not do this because the request's library only sent its client cert in it. I used openssl s_server to verify this as well.
I could not find anything in the official documentation that would allow me to specify a set of certs to be included in the client's chain-of-trust.
Looking at the pyopenssl wrapper used by requests, I can see the Context.use_certificate method, which sets the leaf cert. I am suspecting that only sets a single certificate. I suspect that for this to work, the requests external api would need to provide an interface for passing in a list of PEM-encoded certs, which is then set via the Context.add_extra_chain_cert method.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3219/reactions"
} | https://api.github.com/repos/psf/requests/issues/3219/timeline | null | completed | null | null | false | [
"Hi, thanks for this report!\n\nThe PyOpenSSL wrapper here is actually part of [urllib3](https://github.com/shazow/urllib3), and requests uses urllib3 exactly as provided in that project. Do you mind opening this issue over there instead? (It'll seem weird because it'll still be me responding to you there, but trus... |
https://api.github.com/repos/psf/requests/issues/3218 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3218/labels{/name} | https://api.github.com/repos/psf/requests/issues/3218/comments | https://api.github.com/repos/psf/requests/issues/3218/events | https://github.com/psf/requests/issues/3218 | 156,493,607 | MDU6SXNzdWUxNTY0OTM2MDc= | 3,218 | uncaught possible exception in urllib3/connectionpool.py | {
"avatar_url": "https://avatars.githubusercontent.com/u/772003?v=4",
"events_url": "https://api.github.com/users/sposs/events{/privacy}",
"followers_url": "https://api.github.com/users/sposs/followers",
"following_url": "https://api.github.com/users/sposs/following{/other_user}",
"gists_url": "https://api.github.com/users/sposs/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sposs",
"id": 772003,
"login": "sposs",
"node_id": "MDQ6VXNlcjc3MjAwMw==",
"organizations_url": "https://api.github.com/users/sposs/orgs",
"received_events_url": "https://api.github.com/users/sposs/received_events",
"repos_url": "https://api.github.com/users/sposs/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sposs/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sposs/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sposs",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2016-05-24T12:23:45Z | 2021-09-08T18:00:42Z | 2016-05-24T12:32:09Z | NONE | resolved | Hi,
I'm seeing the following exception
```
File "/opt/virtualenvs/myapp/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py", line 314, in _raise_timeout
if 'timed out' in str(err) or 'did not complete (read)' in str(err): # Python 2.6
TypeError: __str__ returned non-string (type SysCallError)
```
I'm using version 2.7.0 of requests. The url I try to access is a https one.
I don't really know how to debug this...
| {
"avatar_url": "https://avatars.githubusercontent.com/u/772003?v=4",
"events_url": "https://api.github.com/users/sposs/events{/privacy}",
"followers_url": "https://api.github.com/users/sposs/followers",
"following_url": "https://api.github.com/users/sposs/following{/other_user}",
"gists_url": "https://api.github.com/users/sposs/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sposs",
"id": 772003,
"login": "sposs",
"node_id": "MDQ6VXNlcjc3MjAwMw==",
"organizations_url": "https://api.github.com/users/sposs/orgs",
"received_events_url": "https://api.github.com/users/sposs/received_events",
"repos_url": "https://api.github.com/users/sposs/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sposs/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sposs/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sposs",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3218/reactions"
} | https://api.github.com/repos/psf/requests/issues/3218/timeline | null | completed | null | null | false | [
"Please update your version of requests. This was fixed several releases ago.\n",
"Thanks. Updated now. Will reopen if needed.\n"
] |
https://api.github.com/repos/psf/requests/issues/3217 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3217/labels{/name} | https://api.github.com/repos/psf/requests/issues/3217/comments | https://api.github.com/repos/psf/requests/issues/3217/events | https://github.com/psf/requests/issues/3217 | 156,365,023 | MDU6SXNzdWUxNTYzNjUwMjM= | 3,217 | unhandled exception on timeout | {
"avatar_url": "https://avatars.githubusercontent.com/u/522344?v=4",
"events_url": "https://api.github.com/users/alanhamlett/events{/privacy}",
"followers_url": "https://api.github.com/users/alanhamlett/followers",
"following_url": "https://api.github.com/users/alanhamlett/following{/other_user}",
"gists_url": "https://api.github.com/users/alanhamlett/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/alanhamlett",
"id": 522344,
"login": "alanhamlett",
"node_id": "MDQ6VXNlcjUyMjM0NA==",
"organizations_url": "https://api.github.com/users/alanhamlett/orgs",
"received_events_url": "https://api.github.com/users/alanhamlett/received_events",
"repos_url": "https://api.github.com/users/alanhamlett/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/alanhamlett/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/alanhamlett/subscriptions",
"type": "User",
"url": "https://api.github.com/users/alanhamlett",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2016-05-23T20:56:26Z | 2021-09-08T18:00:42Z | 2016-05-24T07:00:54Z | CONTRIBUTOR | resolved | ``` python
Traceback (most recent call last):
File "requests/packages/urllib3/connectionpool.py", line 623, in urlopen
_stacktrace=sys.exc_info()[2])
File "requests/packages/urllib3/util/retry.py", line 285, in increment
_observed_errors=_observed_errors)
File "requests/packages/urllib3/util/retry.py", line 151, in new
raise_on_status=self.raise_on_status,
AttributeError: 'Retry' object has no attribute 'raise_on_status'
```
You can reproduce this by changing line 140 of `requests/packages/urllib3/connection.py` to:
```
140 try:
141 raise SocketTimeout('')
142 conn = connection.create_connection(
143 (self.host, self.port), self.timeout, **extra_kw)
144
145 except SocketTimeout as e:
```
This forces a `SocketTimeout` and causes the unhandled exception when calling `Retry.new`.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3217/reactions"
} | https://api.github.com/repos/psf/requests/issues/3217/timeline | null | completed | null | null | false | [
"Hey @alanhamlett, thanks for reporting this!\n\nThis will be fixed when we release the next minor version of requests, which will bring in an updated version of urllib3.\n"
] |
https://api.github.com/repos/psf/requests/issues/3216 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3216/labels{/name} | https://api.github.com/repos/psf/requests/issues/3216/comments | https://api.github.com/repos/psf/requests/issues/3216/events | https://github.com/psf/requests/pull/3216 | 156,363,982 | MDExOlB1bGxSZXF1ZXN0NzExMTg2MDQ= | 3,216 | Make BaseAdapter describe the mandatory adapter interface | {
"avatar_url": "https://avatars.githubusercontent.com/u/348449?v=4",
"events_url": "https://api.github.com/users/nanonyme/events{/privacy}",
"followers_url": "https://api.github.com/users/nanonyme/followers",
"following_url": "https://api.github.com/users/nanonyme/following{/other_user}",
"gists_url": "https://api.github.com/users/nanonyme/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nanonyme",
"id": 348449,
"login": "nanonyme",
"node_id": "MDQ6VXNlcjM0ODQ0OQ==",
"organizations_url": "https://api.github.com/users/nanonyme/orgs",
"received_events_url": "https://api.github.com/users/nanonyme/received_events",
"repos_url": "https://api.github.com/users/nanonyme/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nanonyme/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nanonyme/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nanonyme",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2016-05-23T20:51:04Z | 2021-09-08T04:00:57Z | 2016-05-24T18:23:16Z | CONTRIBUTOR | resolved | BaseAdapter should document the mandatory interfaces for implementing your own adapter from scratch for a different HTTP library. Currently requests requires all the parameters from HTTPAdapter implementation of send to be defined so copying them and relevant documentation over to the base adapter. Also adding relevant parts of documentation on what close is to the base class
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3216/reactions"
} | https://api.github.com/repos/psf/requests/issues/3216/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3216.diff",
"html_url": "https://github.com/psf/requests/pull/3216",
"merged_at": "2016-05-24T18:23:16Z",
"patch_url": "https://github.com/psf/requests/pull/3216.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3216"
} | true | [
"There's one small note from @sigmavirus24 but I'd be happy to merge this when that's resolved.\n"
] |
https://api.github.com/repos/psf/requests/issues/3215 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3215/labels{/name} | https://api.github.com/repos/psf/requests/issues/3215/comments | https://api.github.com/repos/psf/requests/issues/3215/events | https://github.com/psf/requests/issues/3215 | 156,284,305 | MDU6SXNzdWUxNTYyODQzMDU= | 3,215 | requests and pylab SSL conflict | {
"avatar_url": "https://avatars.githubusercontent.com/u/649929?v=4",
"events_url": "https://api.github.com/users/CrimsonGlory/events{/privacy}",
"followers_url": "https://api.github.com/users/CrimsonGlory/followers",
"following_url": "https://api.github.com/users/CrimsonGlory/following{/other_user}",
"gists_url": "https://api.github.com/users/CrimsonGlory/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/CrimsonGlory",
"id": 649929,
"login": "CrimsonGlory",
"node_id": "MDQ6VXNlcjY0OTkyOQ==",
"organizations_url": "https://api.github.com/users/CrimsonGlory/orgs",
"received_events_url": "https://api.github.com/users/CrimsonGlory/received_events",
"repos_url": "https://api.github.com/users/CrimsonGlory/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/CrimsonGlory/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/CrimsonGlory/subscriptions",
"type": "User",
"url": "https://api.github.com/users/CrimsonGlory",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2016-05-23T13:45:11Z | 2021-09-08T18:00:41Z | 2016-05-24T22:34:45Z | NONE | resolved | Installing pylab after requests makes requests fail SSL certificate verification. Wasn't sure if I should report this here or in pylab repo. This was tested with Docker.
$ ls
`Dockerfile test.py
`
$ cat Dockerfile
```
FROM python:2.7
ADD test.py .
RUN apt-get install openssl libssl-dev
RUN pip install requests
CMD ["python","test.py"]
```
$ cat test.py
```
import requests
print requests.get("https://google.com")
```
$ sudo su
# docker build --tag bugtest1 . && docker run --rm bugtest1
```
Sending build context to Docker daemon 3.072 kB
Step 1 : FROM python:2.7
---> 8f7cafb9cc63
Step 2 : ADD test.py .
---> Using cache
---> c5e7e76e36c6
Step 3 : RUN apt-get install openssl libssl-dev
---> Using cache
---> cecc8e87d049
Step 4 : RUN pip install requests
---> Using cache
---> 6f309b214a07
Step 5 : CMD python test.py
---> Using cache
---> 161f61e62da3
Successfully built 161f61e62da3
<Response [200]>
```
# vim Dockerfile # add pylab line
# cat Dockerfile
```
FROM python:2.7
ADD test.py .
RUN apt-get install openssl libssl-dev
RUN pip install requests
RUN pip install pylab
CMD ["python","test.py"]
```
# docker build --tag bugtest1 . && docker run --rm bugtest1
```
Sending build context to Docker daemon 3.072 kB
Step 1 : FROM python:2.7
---> 8f7cafb9cc63
Step 2 : ADD test.py .
---> Using cache
---> c5e7e76e36c6
Step 3 : RUN apt-get install openssl libssl-dev
---> Using cache
---> cecc8e87d049
Step 4 : RUN pip install requests
---> Using cache
---> 6f309b214a07
Step 5 : RUN pip install pylab
---> Running in dc7af4eba40b
Collecting pylab
Downloading pylab-0.1.3-py2.py3-none-any.whl
Collecting networkx (from pylab)
Downloading networkx-1.11-py2.py3-none-any.whl (1.3MB)
Collecting pytz (from pylab)
Downloading pytz-2016.4-py2.py3-none-any.whl (480kB)
Collecting tornado (from pylab)
Downloading tornado-4.3.tar.gz (450kB)
Collecting pandas (from pylab)
Downloading pandas-0.18.1.tar.gz (7.3MB)
Collecting seaborn (from pylab)
Downloading seaborn-0.7.0.tar.gz (154kB)
Collecting numpy (from pylab)
Downloading numpy-1.11.0-cp27-cp27mu-manylinux1_x86_64.whl (15.3MB)
Collecting matplotlib (from pylab)
Downloading matplotlib-1.5.1.tar.gz (54.0MB)
Collecting jsonschema (from pylab)
Downloading jsonschema-2.5.1-py2.py3-none-any.whl
Collecting scipy (from pylab)
Downloading scipy-0.17.1-cp27-cp27mu-manylinux1_x86_64.whl (39.5MB)
Collecting jinja2 (from pylab)
Downloading Jinja2-2.8-py2.py3-none-any.whl (263kB)
Collecting sympy (from pylab)
Downloading sympy-1.0.tar.gz (4.3MB)
Collecting ipython (from pylab)
Downloading ipython-4.2.0-py2-none-any.whl (736kB)
Collecting scikit-image (from pylab)
Downloading scikit_image-0.12.3-cp27-cp27mu-manylinux1_x86_64.whl (28.0MB)
Collecting scikit-learn (from pylab)
Downloading scikit_learn-0.17.1-cp27-cp27mu-manylinux1_x86_64.whl (17.6MB)
Collecting pyzmq (from pylab)
Downloading pyzmq-15.2.0.zip (1.5MB)
Collecting decorator>=3.4.0 (from networkx->pylab)
Downloading decorator-4.0.9-py2.py3-none-any.whl
Collecting backports.ssl-match-hostname (from tornado->pylab)
Downloading backports.ssl_match_hostname-3.5.0.1.tar.gz
Collecting singledispatch (from tornado->pylab)
Downloading singledispatch-3.4.0.3-py2.py3-none-any.whl
Collecting certifi (from tornado->pylab)
Downloading certifi-2016.2.28-py2.py3-none-any.whl (366kB)
Collecting backports-abc>=0.4 (from tornado->pylab)
Downloading backports_abc-0.4-py2.py3-none-any.whl
Collecting python-dateutil (from pandas->pylab)
Downloading python_dateutil-2.5.3-py2.py3-none-any.whl (201kB)
Collecting cycler (from matplotlib->pylab)
Downloading cycler-0.10.0-py2.py3-none-any.whl
Collecting pyparsing!=2.0.0,!=2.0.4,>=1.5.6 (from matplotlib->pylab)
Downloading pyparsing-2.1.4-py2.py3-none-any.whl (40kB)
Collecting functools32 (from jsonschema->pylab)
Downloading functools32-3.2.3-2.zip
Collecting MarkupSafe (from jinja2->pylab)
Downloading MarkupSafe-0.23.tar.gz
Collecting mpmath>=0.19 (from sympy->pylab)
Downloading mpmath-0.19.tar.gz (498kB)
Collecting traitlets (from ipython->pylab)
Downloading traitlets-4.2.1-py2.py3-none-any.whl (67kB)
Collecting pickleshare (from ipython->pylab)
Downloading pickleshare-0.7.2-py2.py3-none-any.whl
Collecting simplegeneric>0.8 (from ipython->pylab)
Downloading simplegeneric-0.8.1.zip
Collecting backports.shutil-get-terminal-size (from ipython->pylab)
Downloading backports.shutil_get_terminal_size-1.0.0-py2.py3-none-any.whl
Requirement already satisfied (use --upgrade to upgrade): setuptools>=18.5 in /usr/local/lib/python2.7/site-packages (from ipython->pylab)
Collecting pexpect (from ipython->pylab)
Downloading pexpect-4.0.1.tar.gz (143kB)
Collecting dask[array]>=0.5.0 (from scikit-image->pylab)
Downloading dask-0.9.0-py2.py3-none-any.whl (203kB)
Collecting six>=1.7.3 (from scikit-image->pylab)
Downloading six-1.10.0-py2.py3-none-any.whl
Collecting pillow>=2.1.0 (from scikit-image->pylab)
Downloading Pillow-3.2.0.zip (10.5MB)
Collecting ipython-genutils (from traitlets->ipython->pylab)
Downloading ipython_genutils-0.1.0-py2.py3-none-any.whl
Collecting pathlib2 (from pickleshare->ipython->pylab)
Downloading pathlib2-2.1.0-py2.py3-none-any.whl
Collecting ptyprocess>=0.5 (from pexpect->ipython->pylab)
Downloading ptyprocess-0.5.1-py2.py3-none-any.whl
Collecting toolz>=0.7.2 (from dask[array]>=0.5.0->scikit-image->pylab)
Downloading toolz-0.7.4.tar.gz
Building wheels for collected packages: tornado, pandas, seaborn, matplotlib, sympy, pyzmq, backports.ssl-match-hostname, functools32, MarkupSafe, mpmath, simplegeneric, pexpect, pillow, toolz
Running setup.py bdist_wheel for tornado: started
Running setup.py bdist_wheel for tornado: finished with status 'done'
Stored in directory: /root/.cache/pip/wheels/df/20/c7/38911d3d7ac9ae3c6c1b73f01bc61d8fdb46c7fad1a720d394
Running setup.py bdist_wheel for pandas: started
Running setup.py bdist_wheel for pandas: still running...
Running setup.py bdist_wheel for pandas: still running...
Running setup.py bdist_wheel for pandas: still running...
Running setup.py bdist_wheel for pandas: still running...
Running setup.py bdist_wheel for pandas: still running...
Running setup.py bdist_wheel for pandas: still running...
Running setup.py bdist_wheel for pandas: finished with status 'done'
Stored in directory: /root/.cache/pip/wheels/9a/8c/95/ceb8f988caf19dd90c4c587eea0ee1665c3bb6af73b3ca8264
Running setup.py bdist_wheel for seaborn: started
Running setup.py bdist_wheel for seaborn: finished with status 'done'
Stored in directory: /root/.cache/pip/wheels/e0/94/01/731d82dc437e1c8b65130956028f3fe693943c3e499a676dc9
Running setup.py bdist_wheel for matplotlib: started
Running setup.py bdist_wheel for matplotlib: still running...
Running setup.py bdist_wheel for matplotlib: still running...
Running setup.py bdist_wheel for matplotlib: still running...
Running setup.py bdist_wheel for matplotlib: finished with status 'done'
Stored in directory: /root/.cache/pip/wheels/d8/38/3c/a388e11fd09f9b23f5e4cd74594197394d9fd65f91f64c4aa7
Running setup.py bdist_wheel for sympy: started
Running setup.py bdist_wheel for sympy: finished with status 'done'
Stored in directory: /root/.cache/pip/wheels/05/93/22/2d0f59d842347b1f38df0d3f7a3870586df60568d2a49d94c5
Running setup.py bdist_wheel for pyzmq: started
Running setup.py bdist_wheel for pyzmq: still running...
Running setup.py bdist_wheel for pyzmq: still running...
Running setup.py bdist_wheel for pyzmq: still running...
Running setup.py bdist_wheel for pyzmq: finished with status 'done'
Stored in directory: /root/.cache/pip/wheels/a1/2f/b7/8d30910d93816f084b3d29ec38e38ae7cc9f8431a0b44a5864
Running setup.py bdist_wheel for backports.ssl-match-hostname: started
Running setup.py bdist_wheel for backports.ssl-match-hostname: finished with status 'done'
Stored in directory: /root/.cache/pip/wheels/5d/72/36/b2a31507b613967b728edc33378a5ff2ada0f62855b93c5ae1
Running setup.py bdist_wheel for functools32: started
Running setup.py bdist_wheel for functools32: finished with status 'done'
Stored in directory: /root/.cache/pip/wheels/3c/d0/09/cd78d0ff4d6cfecfbd730782a7815a4571cd2cd4d2ed6e69d9
Running setup.py bdist_wheel for MarkupSafe: started
Running setup.py bdist_wheel for MarkupSafe: finished with status 'done'
Stored in directory: /root/.cache/pip/wheels/a3/fa/dc/0198eed9ad95489b8a4f45d14dd5d2aee3f8984e46862c5748
Running setup.py bdist_wheel for mpmath: started
Running setup.py bdist_wheel for mpmath: finished with status 'done'
Stored in directory: /root/.cache/pip/wheels/02/2b/99/cd867d5da48d951118a8020e86c0c12a65022702426582d4b8
Running setup.py bdist_wheel for simplegeneric: started
Running setup.py bdist_wheel for simplegeneric: finished with status 'done'
Stored in directory: /root/.cache/pip/wheels/7b/31/08/c85e74c84188cbec6a6827beec4d640f2bd78ae003dc1ec09d
Running setup.py bdist_wheel for pexpect: started
Running setup.py bdist_wheel for pexpect: finished with status 'done'
Stored in directory: /root/.cache/pip/wheels/f2/65/89/09578bcd0efeabc7e2b0079cd62d3955c1477f2e55aa5031a4
Running setup.py bdist_wheel for pillow: started
Running setup.py bdist_wheel for pillow: finished with status 'done'
Stored in directory: /root/.cache/pip/wheels/88/2d/ce/3ff4ae4e2b8600d1bde1cbde5dfcc6d8770222c38348fe9139
Running setup.py bdist_wheel for toolz: started
Running setup.py bdist_wheel for toolz: finished with status 'done'
Stored in directory: /root/.cache/pip/wheels/3e/e9/72/b9e24c6b4c0347670b9a20afeba6b2534655f5dc714b30cb4e
Successfully built tornado pandas seaborn matplotlib sympy pyzmq backports.ssl-match-hostname functools32 MarkupSafe mpmath simplegeneric pexpect pillow toolz
Installing collected packages: decorator, networkx, pytz, backports.ssl-match-hostname, six, singledispatch, certifi, backports-abc, tornado, python-dateutil, numpy, pandas, scipy, cycler, pyparsing, matplotlib, seaborn, functools32, jsonschema, MarkupSafe, jinja2, mpmath, sympy, ipython-genutils, traitlets, pathlib2, pickleshare, simplegeneric, backports.shutil-get-terminal-size, ptyprocess, pexpect, ipython, toolz, dask, pillow, scikit-image, scikit-learn, pyzmq, pylab
Successfully installed MarkupSafe-0.23 backports-abc-0.4 backports.shutil-get-terminal-size-1.0.0 backports.ssl-match-hostname-3.5.0.1 certifi-2016.2.28 cycler-0.10.0 dask-0.9.0 decorator-4.0.9 functools32-3.2.3.post2 ipython-4.2.0 ipython-genutils-0.1.0 jinja2-2.8 jsonschema-2.5.1 matplotlib-1.5.1 mpmath-0.19 networkx-1.11 numpy-1.11.0 pandas-0.18.1 pathlib2-2.1.0 pexpect-4.0.1 pickleshare-0.7.2 pillow-3.2.0 ptyprocess-0.5.1 pylab-0.1.3 pyparsing-2.1.4 python-dateutil-2.5.3 pytz-2016.4 pyzmq-15.2.0 scikit-image-0.12.3 scikit-learn-0.17.1 scipy-0.17.1 seaborn-0.7.0 simplegeneric-0.8.1 singledispatch-3.4.0.3 six-1.10.0 sympy-1.0 toolz-0.7.4 tornado-4.3 traitlets-4.2.1
You are using pip version 8.1.1, however version 8.1.2 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
---> 3b53dc9ef60f
Removing intermediate container dc7af4eba40b
Step 6 : CMD python test.py
---> Running in 243dd6bfbc15
---> c977d7831c40
Removing intermediate container 243dd6bfbc15
Successfully built c977d7831c40
Traceback (most recent call last):
File "test.py", line 2, in <module>
print requests.get("https://google.com")
File "/usr/local/lib/python2.7/site-packages/requests/api.py", line 71, in get
return request('get', url, params=params, **kwargs)
File "/usr/local/lib/python2.7/site-packages/requests/api.py", line 57, in request
return session.request(method=method, url=url, **kwargs)
File "/usr/local/lib/python2.7/site-packages/requests/sessions.py", line 475, in request
resp = self.send(prep, **send_kwargs)
File "/usr/local/lib/python2.7/site-packages/requests/sessions.py", line 585, in send
r = adapter.send(request, **kwargs)
File "/usr/local/lib/python2.7/site-packages/requests/adapters.py", line 477, in send
raise SSLError(e, request=request)
requests.exceptions.SSLError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:590)
```
# docker exec -ti containername bash
root(inside docker container):/# python --version
```
Python 2.7.11
```
root(inside docker container):/# pip show requests
```
---
Metadata-Version: 2.0
Name: requests
Version: 2.10.0
Summary: Python HTTP for Humans.
Home-page: http://python-requests.org
Author: Kenneth Reitz
Author-email: me@kennethreitz.com
Installer: pip
License: Apache 2.0
Location: /usr/local/lib/python2.7/site-packages
Requires:
Classifiers:
Development Status :: 5 - Production/Stable
Intended Audience :: Developers
Natural Language :: English
License :: OSI Approved :: Apache Software License
Programming Language :: Python
Programming Language :: Python :: 2.6
Programming Language :: Python :: 2.7
Programming Language :: Python :: 3
Programming Language :: Python :: 3.3
Programming Language :: Python :: 3.4
Programming Language :: Python :: 3.5
Programming Language :: Python :: Implementation :: CPython
Programming Language :: Python :: Implementation :: PyPy
You are using pip version 8.1.1, however version 8.1.2 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
```
root(inside docker container):/# pip show pylab
```
---
Metadata-Version: 2.0
Name: pylab
Version: 0.1.3
Summary: Data science meta-package
Home-page: https://github.com/javipalanca/pylab
Author: Javi Palanca
Author-email: jpalanca@gmail.com
Installer: pip
License: BSD
Location: /usr/local/lib/python2.7/site-packages
Requires: networkx, pytz, tornado, pandas, seaborn, numpy, matplotlib, jsonschema, scipy, jinja2, sympy, ipython, scikit-image, scikit-learn, pyzmq
Classifiers:
Development Status :: 2 - Pre-Alpha
Intended Audience :: Developers
License :: OSI Approved :: BSD License
Natural Language :: English
Programming Language :: Python :: 2
Programming Language :: Python :: 2.6
Programming Language :: Python :: 2.7
Programming Language :: Python :: 3
Programming Language :: Python :: 3.3
Programming Language :: Python :: 3.4
You are using pip version 8.1.1, however version 8.1.2 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/649929?v=4",
"events_url": "https://api.github.com/users/CrimsonGlory/events{/privacy}",
"followers_url": "https://api.github.com/users/CrimsonGlory/followers",
"following_url": "https://api.github.com/users/CrimsonGlory/following{/other_user}",
"gists_url": "https://api.github.com/users/CrimsonGlory/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/CrimsonGlory",
"id": 649929,
"login": "CrimsonGlory",
"node_id": "MDQ6VXNlcjY0OTkyOQ==",
"organizations_url": "https://api.github.com/users/CrimsonGlory/orgs",
"received_events_url": "https://api.github.com/users/CrimsonGlory/received_events",
"repos_url": "https://api.github.com/users/CrimsonGlory/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/CrimsonGlory/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/CrimsonGlory/subscriptions",
"type": "User",
"url": "https://api.github.com/users/CrimsonGlory",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3215/reactions"
} | https://api.github.com/repos/psf/requests/issues/3215/timeline | null | completed | null | null | false | [
"Can you please show us what version of openssl is linked against Python in your container? `python -c \"import ssl; print ssl.OPENSSL_VERSION\"` should do the trick.\n",
"both setups (installing pylab+requests or only requests), print the same openssl version:\nOpenSSL 1.0.1k 8 Jan 2015\n",
"Yup, so the proble... |
https://api.github.com/repos/psf/requests/issues/3214 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3214/labels{/name} | https://api.github.com/repos/psf/requests/issues/3214/comments | https://api.github.com/repos/psf/requests/issues/3214/events | https://github.com/psf/requests/issues/3214 | 156,135,767 | MDU6SXNzdWUxNTYxMzU3Njc= | 3,214 | Using specific SSL version TLSv1.2 | {
"avatar_url": "https://avatars.githubusercontent.com/u/15092?v=4",
"events_url": "https://api.github.com/users/jayvdb/events{/privacy}",
"followers_url": "https://api.github.com/users/jayvdb/followers",
"following_url": "https://api.github.com/users/jayvdb/following{/other_user}",
"gists_url": "https://api.github.com/users/jayvdb/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jayvdb",
"id": 15092,
"login": "jayvdb",
"node_id": "MDQ6VXNlcjE1MDky",
"organizations_url": "https://api.github.com/users/jayvdb/orgs",
"received_events_url": "https://api.github.com/users/jayvdb/received_events",
"repos_url": "https://api.github.com/users/jayvdb/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jayvdb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jayvdb/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jayvdb",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 7 | 2016-05-22T05:25:24Z | 2021-09-04T00:06:15Z | 2016-05-22T11:57:58Z | CONTRIBUTOR | resolved | I ran into a problem with a TLSv1.2 site using the Travis Ubuntu precise containers, which is documented at https://github.com/travis-ci/travis-ci/issues/4757
I was able to work around the problem using:
``` python
import ssl, urllib3
pm = urllib3.PoolManager(ssl_version=ssl.PROTOCOL_TLSv1_2)
r = pm.request('GET', 'http://proofwiki.org/wiki/Main_Page')
```
I'd like to workaround it using `requests` if possible, and it seems like it should be possible according to
http://docs.python-requests.org/en/master/user/advanced/#example-specific-ssl-version
However when I try to follow that recipe (below) on Python 2.7.9+ / 3.4+, `requests.exceptions.SSLError: ("bad handshake: SysCallError(104, 'ECONNRESET')",)` is raised.
``` python
import ssl
import sys
import requests
from requests.adapters import HTTPAdapter
from requests.packages.urllib3.poolmanager import PoolManager
class Tls12HttpAdapter(HTTPAdapter):
"""Transport adapter that forces use of TLSv1.2."""
def init_poolmanager(self, connections, maxsize, block=False):
"""Create and initialize the urllib3 PoolManager."""
self.poolmanager = PoolManager(
num_pools=connections, maxsize=maxsize,
block=block, ssl_version=ssl.PROTOCOL_TLSv1_2)
url = sys.argv[1]
s = requests.Session()
s.mount(url, Tls12HttpAdapter())
r = s.get(url)
print(r.status_code)
```
https://github.com/jayvdb/my-ci-test/blob/tls12/requests_explicit.py
Full backtrace at https://travis-ci.org/jayvdb/my-ci-test/jobs/132022039
| {
"avatar_url": "https://avatars.githubusercontent.com/u/15092?v=4",
"events_url": "https://api.github.com/users/jayvdb/events{/privacy}",
"followers_url": "https://api.github.com/users/jayvdb/followers",
"following_url": "https://api.github.com/users/jayvdb/following{/other_user}",
"gists_url": "https://api.github.com/users/jayvdb/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jayvdb",
"id": 15092,
"login": "jayvdb",
"node_id": "MDQ6VXNlcjE1MDky",
"organizations_url": "https://api.github.com/users/jayvdb/orgs",
"received_events_url": "https://api.github.com/users/jayvdb/received_events",
"repos_url": "https://api.github.com/users/jayvdb/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jayvdb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jayvdb/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jayvdb",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3214/reactions"
} | https://api.github.com/repos/psf/requests/issues/3214/timeline | null | completed | null | null | false | [
"So, adopters are selected based on a prefix match against a lowercased normalised form of the URL. That means it's rarely a good idea to add an adapter that is mounted against the _whole_ URL: scheme and host is better. \n\nTry mounting the adapter using a more restrictive URL. \n",
"Well it works if I mount the... |
https://api.github.com/repos/psf/requests/issues/3213 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3213/labels{/name} | https://api.github.com/repos/psf/requests/issues/3213/comments | https://api.github.com/repos/psf/requests/issues/3213/events | https://github.com/psf/requests/issues/3213 | 156,099,503 | MDU6SXNzdWUxNTYwOTk1MDM= | 3,213 | Importing requests is fairly slow | {
"avatar_url": "https://avatars.githubusercontent.com/u/25111?v=4",
"events_url": "https://api.github.com/users/cournape/events{/privacy}",
"followers_url": "https://api.github.com/users/cournape/followers",
"following_url": "https://api.github.com/users/cournape/following{/other_user}",
"gists_url": "https://api.github.com/users/cournape/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/cournape",
"id": 25111,
"login": "cournape",
"node_id": "MDQ6VXNlcjI1MTEx",
"organizations_url": "https://api.github.com/users/cournape/orgs",
"received_events_url": "https://api.github.com/users/cournape/received_events",
"repos_url": "https://api.github.com/users/cournape/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/cournape/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cournape/subscriptions",
"type": "User",
"url": "https://api.github.com/users/cournape",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 44 | 2016-05-21T12:23:08Z | 2021-09-08T07:00:40Z | 2017-07-30T13:57:49Z | NONE | resolved | We are using requests in our projects, and it is working great. Unfortunately, for our CLI tools, using requests is an issue because it is slow to import. E.g. on my 2014 macbook:
```
python -c "import requests"
```
Takes close to 90 ms.
Is optimizing import time worth of consideration for the project ?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3213/reactions"
} | https://api.github.com/repos/psf/requests/issues/3213/timeline | null | completed | null | null | false | [
"This is almost certainly the result of CFFI. Can you print what libraries you have installed in your environment (`pip freeze`)?\n",
"This is not linked to cffi (I don't have it installed). I did the test w/ a quasi empty virtualenv:\n\n```\n$ pip list\npip (8.1.2)\nrequests (2.10.0)\nsetuptools (21.1.0)\nwheel ... |
https://api.github.com/repos/psf/requests/issues/3212 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3212/labels{/name} | https://api.github.com/repos/psf/requests/issues/3212/comments | https://api.github.com/repos/psf/requests/issues/3212/events | https://github.com/psf/requests/issues/3212 | 156,011,291 | MDU6SXNzdWUxNTYwMTEyOTE= | 3,212 | SSL Error: bad handshake | {
"avatar_url": "https://avatars.githubusercontent.com/u/1202193?v=4",
"events_url": "https://api.github.com/users/pensnarik/events{/privacy}",
"followers_url": "https://api.github.com/users/pensnarik/followers",
"following_url": "https://api.github.com/users/pensnarik/following{/other_user}",
"gists_url": "https://api.github.com/users/pensnarik/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/pensnarik",
"id": 1202193,
"login": "pensnarik",
"node_id": "MDQ6VXNlcjEyMDIxOTM=",
"organizations_url": "https://api.github.com/users/pensnarik/orgs",
"received_events_url": "https://api.github.com/users/pensnarik/received_events",
"repos_url": "https://api.github.com/users/pensnarik/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/pensnarik/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pensnarik/subscriptions",
"type": "User",
"url": "https://api.github.com/users/pensnarik",
"user_view_type": "public"
} | [
{
"color": "fef2c0",
"default": false,
"description": null,
"id": 298537994,
"name": "Needs More Information",
"node_id": "MDU6TGFiZWwyOTg1Mzc5OTQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Needs%20More%20Information"
}
] | closed | true | null | [] | null | 33 | 2016-05-20T17:20:55Z | 2021-09-08T03:00:36Z | 2016-09-06T00:04:02Z | NONE | resolved | I could not use your lib in CeontOS 7 with Python 2.7.5. I got this error:
```
File "/usr/lib/python2.7/site-packages/requests/sessions.py", line 576, in send
r = adapter.send(request, **kwargs)
File "/usr/lib/python2.7/site-packages/requests/adapters.py", line 447, in send
raise SSLError(e, request=request)
requests.exceptions.SSLError: ("bad handshake: Error([('SSL routines', 'SSL3_GET_SERVER_CERTIFICATE', 'certificate verify failed')],)",)
```
Updating of Python or any SSL libs didn't help. I've got this error in CentOS and Ubuntu, in Arch Linux everything works well.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3212/reactions"
} | https://api.github.com/repos/psf/requests/issues/3212/timeline | null | completed | null | null | false | [
"Could you please tell us how you've installed requests and what version you've installed?\n",
"This is almost certainly an SNI problem, so depending on how the library was installed we may need to add some optional dependencies. \n",
"requests was installed as dependency for smartsheet-python-sdk via pip:\n\n`... |
https://api.github.com/repos/psf/requests/issues/3201 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3201/labels{/name} | https://api.github.com/repos/psf/requests/issues/3201/comments | https://api.github.com/repos/psf/requests/issues/3201/events | https://github.com/psf/requests/issues/3201 | 155,859,310 | MDU6SXNzdWUxNTU4NTkzMTA= | 3,201 | Request's documentation is self-contradictory about whether connections are pooled automatically | {
"avatar_url": "https://avatars.githubusercontent.com/u/90853?v=4",
"events_url": "https://api.github.com/users/thanatos/events{/privacy}",
"followers_url": "https://api.github.com/users/thanatos/followers",
"following_url": "https://api.github.com/users/thanatos/following{/other_user}",
"gists_url": "https://api.github.com/users/thanatos/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/thanatos",
"id": 90853,
"login": "thanatos",
"node_id": "MDQ6VXNlcjkwODUz",
"organizations_url": "https://api.github.com/users/thanatos/orgs",
"received_events_url": "https://api.github.com/users/thanatos/received_events",
"repos_url": "https://api.github.com/users/thanatos/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/thanatos/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/thanatos/subscriptions",
"type": "User",
"url": "https://api.github.com/users/thanatos",
"user_view_type": "public"
} | [
{
"color": "0b02e1",
"default": false,
"description": null,
"id": 191274,
"name": "Contributor Friendly",
"node_id": "MDU6TGFiZWwxOTEyNzQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Contributor%20Friendly"
},
{
"color": "fad8c7",
"default": false,
"descrip... | closed | true | null | [] | null | 2 | 2016-05-19T23:42:28Z | 2021-09-08T17:05:39Z | 2016-06-09T21:44:26Z | NONE | resolved | The introduction to requests claims,
> Keep-alive and HTTP connection pooling are 100% automatic
The page on sessions contradicts this, and heavily implies that I need to create a `Session` object to get pooling:
> if you're making several requests to the same host, the underlying TCP connection will be reused, which can result in a significant performance increase (see HTTP persistent connection).
If I need to create a Session in order to achieve connection pooling… that doesn't seem "100% automatic" if I must manually ask for it.
Use of the library seems to indicate that `Session` is the way to go, because I'm getting spammed by "Starting new HTTPS connection" logs.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3201/reactions"
} | https://api.github.com/repos/psf/requests/issues/3201/timeline | null | completed | null | null | false | [
"Thanks for this!\n\nI don't know that I'd call the documentation contradictory. At least when I see \"100% automatic\" I see a phrase that means \"no user intervention is required\", which is true. However, you do need an object to put state on to.\n\nRegardless, what wording change would you recommend to clear th... |
https://api.github.com/repos/psf/requests/issues/3200 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3200/labels{/name} | https://api.github.com/repos/psf/requests/issues/3200/comments | https://api.github.com/repos/psf/requests/issues/3200/events | https://github.com/psf/requests/pull/3200 | 155,837,127 | MDExOlB1bGxSZXF1ZXN0NzA3NjY2ODU= | 3,200 | Document the cert pooling bug | {
"avatar_url": "https://avatars.githubusercontent.com/u/236086?v=4",
"events_url": "https://api.github.com/users/zestyping/events{/privacy}",
"followers_url": "https://api.github.com/users/zestyping/followers",
"following_url": "https://api.github.com/users/zestyping/following{/other_user}",
"gists_url": "https://api.github.com/users/zestyping/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/zestyping",
"id": 236086,
"login": "zestyping",
"node_id": "MDQ6VXNlcjIzNjA4Ng==",
"organizations_url": "https://api.github.com/users/zestyping/orgs",
"received_events_url": "https://api.github.com/users/zestyping/received_events",
"repos_url": "https://api.github.com/users/zestyping/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/zestyping/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zestyping/subscriptions",
"type": "User",
"url": "https://api.github.com/users/zestyping",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2016-05-19T21:16:32Z | 2021-09-08T04:00:58Z | 2016-05-19T21:56:04Z | NONE | resolved | Hi there. I just ran into https://github.com/kennethreitz/requests/issues/2863 and spent a lot of time trying to figure out what was wrong. It would be really nice for future people who might encounter this bug to be informed up front, so here is a note to add to the User Guide and the API documentation.
I understand that people are working on fixing this bug, but it's not fixed yet and it's been open for about 6 months. I think it's valuable to make this quick change to the docs in the meantime, and then when the bug is fixed we can remove these warnings.
Thanks!
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3200/reactions"
} | https://api.github.com/repos/psf/requests/issues/3200/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3200.diff",
"html_url": "https://github.com/psf/requests/pull/3200",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/3200.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3200"
} | true | [
"Thanks for this suggestion! However, I don't think the proposed documentation change is good: in fact, I think it is dangerously misleading. The bug occurs regardless of how `cert` is set: so long as it has been set and a session is being used it is possible for it to be effectively incorrectly set. \n\nHowever, I... |
https://api.github.com/repos/psf/requests/issues/3199 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3199/labels{/name} | https://api.github.com/repos/psf/requests/issues/3199/comments | https://api.github.com/repos/psf/requests/issues/3199/events | https://github.com/psf/requests/issues/3199 | 155,795,525 | MDU6SXNzdWUxNTU3OTU1MjU= | 3,199 | Not possible to receive server response before all of request body is sent? | {
"avatar_url": "https://avatars.githubusercontent.com/u/555959?v=4",
"events_url": "https://api.github.com/users/zachmullen/events{/privacy}",
"followers_url": "https://api.github.com/users/zachmullen/followers",
"following_url": "https://api.github.com/users/zachmullen/following{/other_user}",
"gists_url": "https://api.github.com/users/zachmullen/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/zachmullen",
"id": 555959,
"login": "zachmullen",
"node_id": "MDQ6VXNlcjU1NTk1OQ==",
"organizations_url": "https://api.github.com/users/zachmullen/orgs",
"received_events_url": "https://api.github.com/users/zachmullen/received_events",
"repos_url": "https://api.github.com/users/zachmullen/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/zachmullen/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zachmullen/subscriptions",
"type": "User",
"url": "https://api.github.com/users/zachmullen",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2016-05-19T17:47:22Z | 2021-09-08T18:00:44Z | 2016-05-19T19:46:16Z | NONE | resolved | I'm not sure if this is actually the case, but from looking at the code it appears to be. To motivate my use case, I am using chunked transfer-encoding mode for the request since I want to support streaming from an underlying service, so the content length is unknown and could be very long. It appears that if the server sends a response prior to the request body being completely sent, we wouldn't know about it, which would be quite bad for something like a redirect or an error condition that was detected very early in the stream. In particular, in a redirect case we certainly don't want to re-send the entire stream.
Is there a good way around this?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3199/reactions"
} | https://api.github.com/repos/psf/requests/issues/3199/timeline | null | completed | null | null | false | [
"@zachmullen short of rewriting our HTTP stack to not use httplib, no. And none of us presently have the time to do that. :-(\n",
"Well, we could work around it if we adjusted `send` to always check whether the socket is readable first, but it's a dirty hack and I don't think it's worth it: it'll just be too brit... |
https://api.github.com/repos/psf/requests/issues/3198 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3198/labels{/name} | https://api.github.com/repos/psf/requests/issues/3198/comments | https://api.github.com/repos/psf/requests/issues/3198/events | https://github.com/psf/requests/pull/3198 | 155,128,791 | MDExOlB1bGxSZXF1ZXN0NzAyNjY0NjI= | 3,198 | Issue #2645 - Change behavior of Response.ok | {
"avatar_url": "https://avatars.githubusercontent.com/u/15115673?v=4",
"events_url": "https://api.github.com/users/AlexPHorta/events{/privacy}",
"followers_url": "https://api.github.com/users/AlexPHorta/followers",
"following_url": "https://api.github.com/users/AlexPHorta/following{/other_user}",
"gists_url": "https://api.github.com/users/AlexPHorta/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/AlexPHorta",
"id": 15115673,
"login": "AlexPHorta",
"node_id": "MDQ6VXNlcjE1MTE1Njcz",
"organizations_url": "https://api.github.com/users/AlexPHorta/orgs",
"received_events_url": "https://api.github.com/users/AlexPHorta/received_events",
"repos_url": "https://api.github.com/users/AlexPHorta/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/AlexPHorta/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/AlexPHorta/subscriptions",
"type": "User",
"url": "https://api.github.com/users/AlexPHorta",
"user_view_type": "public"
} | [
{
"color": "fbca04",
"default": false,
"description": null,
"id": 44501249,
"name": "Needs BDFL Input",
"node_id": "MDU6TGFiZWw0NDUwMTI0OQ==",
"url": "https://api.github.com/repos/psf/requests/labels/Needs%20BDFL%20Input"
},
{
"color": "eb6420",
"default": false,
"descrip... | closed | true | null | [] | {
"closed_at": null,
"closed_issues": 29,
"created_at": "2013-11-17T11:29:34Z",
"creator": {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
},
"description": null,
"due_on": null,
"html_url": "https://github.com/psf/requests/milestone/20",
"id": 487518,
"labels_url": "https://api.github.com/repos/psf/requests/milestones/20/labels",
"node_id": "MDk6TWlsZXN0b25lNDg3NTE4",
"number": 20,
"open_issues": 12,
"state": "open",
"title": "3.0.0",
"updated_at": "2024-05-19T18:43:00Z",
"url": "https://api.github.com/repos/psf/requests/milestones/20"
} | 5 | 2016-05-16T21:41:53Z | 2021-09-07T00:06:36Z | 2017-02-10T17:18:50Z | NONE | resolved | As discussed on issue #2645, I added a success attribute to
requests.codes. Now, Response.ok checks if the response's status code
is listed on requests.codes.success.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3198/reactions"
} | https://api.github.com/repos/psf/requests/issues/3198/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3198.diff",
"html_url": "https://github.com/psf/requests/pull/3198",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/3198.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3198"
} | true | [
"I get it, it's just that I thought the agreed solution was to add the success attribute to requests.codes. I'll update the commit right now.\n",
"This LGTM. We can't merge until we're ready to do 3.0.0, though.\n",
"An additional check should be added for entire 2xx range after the registered codes are checked... |
https://api.github.com/repos/psf/requests/issues/3197 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3197/labels{/name} | https://api.github.com/repos/psf/requests/issues/3197/comments | https://api.github.com/repos/psf/requests/issues/3197/events | https://github.com/psf/requests/issues/3197 | 155,076,971 | MDU6SXNzdWUxNTUwNzY5NzE= | 3,197 | session proxies not honored during request | {
"avatar_url": "https://avatars.githubusercontent.com/u/1371585?v=4",
"events_url": "https://api.github.com/users/mbondfusion/events{/privacy}",
"followers_url": "https://api.github.com/users/mbondfusion/followers",
"following_url": "https://api.github.com/users/mbondfusion/following{/other_user}",
"gists_url": "https://api.github.com/users/mbondfusion/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mbondfusion",
"id": 1371585,
"login": "mbondfusion",
"node_id": "MDQ6VXNlcjEzNzE1ODU=",
"organizations_url": "https://api.github.com/users/mbondfusion/orgs",
"received_events_url": "https://api.github.com/users/mbondfusion/received_events",
"repos_url": "https://api.github.com/users/mbondfusion/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mbondfusion/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mbondfusion/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mbondfusion",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2016-05-16T17:21:01Z | 2021-09-08T18:00:45Z | 2016-05-16T17:23:07Z | NONE | resolved | Using a session object and setting the proxies dictionary does not affect the proxies used during a request.
ex: Still tries to use system proxy.
```
s = requests.Session()
s.proxies = {'http': None, 'https': None}
s.post(url='http://10.0.1.1', json={'test': 'data'})
```
Using proxies during each request works, but it would be great to set them at the session level. Specifically if you potentially have dozens or ".post()" or ".get()" calls throughout your script.
Any thoughts?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3197/reactions"
} | https://api.github.com/repos/psf/requests/issues/3197/timeline | null | completed | null | null | false | [
"Thanks for this! This is a duplicate of #2018.\n"
] |
https://api.github.com/repos/psf/requests/issues/3196 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3196/labels{/name} | https://api.github.com/repos/psf/requests/issues/3196/comments | https://api.github.com/repos/psf/requests/issues/3196/events | https://github.com/psf/requests/issues/3196 | 155,073,824 | MDU6SXNzdWUxNTUwNzM4MjQ= | 3,196 | redirect with odd (but correct) Location url fails via proxy | {
"avatar_url": "https://avatars.githubusercontent.com/u/2027885?v=4",
"events_url": "https://api.github.com/users/mgdelmonte/events{/privacy}",
"followers_url": "https://api.github.com/users/mgdelmonte/followers",
"following_url": "https://api.github.com/users/mgdelmonte/following{/other_user}",
"gists_url": "https://api.github.com/users/mgdelmonte/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mgdelmonte",
"id": 2027885,
"login": "mgdelmonte",
"node_id": "MDQ6VXNlcjIwMjc4ODU=",
"organizations_url": "https://api.github.com/users/mgdelmonte/orgs",
"received_events_url": "https://api.github.com/users/mgdelmonte/received_events",
"repos_url": "https://api.github.com/users/mgdelmonte/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mgdelmonte/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mgdelmonte/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mgdelmonte",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2016-05-16T17:03:52Z | 2021-09-08T16:00:36Z | 2016-08-05T07:49:07Z | NONE | resolved | Using v2.10.0 (but tested and get same behavior with 2.9.1), if we get a 302 redirect with a header like this (note the missing trailing slash after the domain):
Location: http://captrust.netxinvestor.com?custId=....
AND we're using a proxy (proxy in question is tinyproxy, but tested with other proxies and get same behavior)
AND allow_redirects=True
the proxy will fail with "cannot connect" because the domain in the Location url is improperly parsed.
Firefox and Chrome both properly handle the redirect. To be honest I haven't checked whether the Location URL does or does not violate the spec, but if the browsers handle it and it appears to be unambiguous I'd vote for `requests` handling it also. Seems like an easy patch, though I must also confess that I've stepped through the code and can't find where to handle it.
Oddly, if that exact URL is passed to requests as a GET, even via a proxy, it works fine -- so my guess is that it happens somewhere in the SessionRedirectMixin object.
Workaround right now is to request with allow_redirects=False and handle the redirect manually.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3196/reactions"
} | https://api.github.com/repos/psf/requests/issues/3196/timeline | null | completed | null | null | false | [
"Are you sure this is a URL parsing issue? Are you getting an exception or an error from the proxy? If the former, can I see it?\n\nIf not, which is what I suspect, I think your proxy may be the one that's struggling. Essentially, the major difference in the two code paths is that requests won't add the `'/'` path ... |
https://api.github.com/repos/psf/requests/issues/3195 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3195/labels{/name} | https://api.github.com/repos/psf/requests/issues/3195/comments | https://api.github.com/repos/psf/requests/issues/3195/events | https://github.com/psf/requests/pull/3195 | 154,971,353 | MDExOlB1bGxSZXF1ZXN0NzAxNTY3ODc= | 3,195 | Fix to check for Plain ip notations in no_proxy settings if not CIDR | {
"avatar_url": "https://avatars.githubusercontent.com/u/3090124?v=4",
"events_url": "https://api.github.com/users/kumarvaradarajulu/events{/privacy}",
"followers_url": "https://api.github.com/users/kumarvaradarajulu/followers",
"following_url": "https://api.github.com/users/kumarvaradarajulu/following{/other_user}",
"gists_url": "https://api.github.com/users/kumarvaradarajulu/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kumarvaradarajulu",
"id": 3090124,
"login": "kumarvaradarajulu",
"node_id": "MDQ6VXNlcjMwOTAxMjQ=",
"organizations_url": "https://api.github.com/users/kumarvaradarajulu/orgs",
"received_events_url": "https://api.github.com/users/kumarvaradarajulu/received_events",
"repos_url": "https://api.github.com/users/kumarvaradarajulu/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kumarvaradarajulu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kumarvaradarajulu/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kumarvaradarajulu",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 5 | 2016-05-16T06:50:12Z | 2021-09-08T04:01:00Z | 2016-05-16T12:47:33Z | NONE | resolved | For ipv4 addresses no_proxy is not being honored.
[This line ](https://github.com/kennethreitz/requests/blob/master/requests/utils.py#L539) checks for `cidr notation` but `plain ip` notation is not considered, due to which the request is always routed to proxy server. This results in error ReadTimeoutError
Sample `proxy` configuration
```
no_proxy=192.168.1.1,192.168.1.3,*.example.com
http_proxy=http://192.168.1.100:8080
https_proxy=http://192.168.1.100:8080
```
> When request is made to `192.168.1.1`, the request should not be made to proxy server, without this fix it is being made to proxy server `192.168.1.100`
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3195/reactions"
} | https://api.github.com/repos/psf/requests/issues/3195/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3195.diff",
"html_url": "https://github.com/psf/requests/pull/3195",
"merged_at": "2016-05-16T12:47:33Z",
"patch_url": "https://github.com/psf/requests/pull/3195.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3195"
} | true | [
"This seems good to me. Can we have a test to validate that this function works as expected?\n",
"@Lukasa added tests, please check and merge.\n",
"@Lukasa addressed comments, pls check\n",
"Cool, I'm :+1: on this for now. I'd like another :+1: from @sigmavirus24 before we merge, but I think this is good.\n",... |
https://api.github.com/repos/psf/requests/issues/3194 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3194/labels{/name} | https://api.github.com/repos/psf/requests/issues/3194/comments | https://api.github.com/repos/psf/requests/issues/3194/events | https://github.com/psf/requests/issues/3194 | 154,915,473 | MDU6SXNzdWUxNTQ5MTU0NzM= | 3,194 | Add support for in-memory multipart upload | {
"avatar_url": "https://avatars.githubusercontent.com/u/2421362?v=4",
"events_url": "https://api.github.com/users/wujek-srujek/events{/privacy}",
"followers_url": "https://api.github.com/users/wujek-srujek/followers",
"following_url": "https://api.github.com/users/wujek-srujek/following{/other_user}",
"gists_url": "https://api.github.com/users/wujek-srujek/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/wujek-srujek",
"id": 2421362,
"login": "wujek-srujek",
"node_id": "MDQ6VXNlcjI0MjEzNjI=",
"organizations_url": "https://api.github.com/users/wujek-srujek/orgs",
"received_events_url": "https://api.github.com/users/wujek-srujek/received_events",
"repos_url": "https://api.github.com/users/wujek-srujek/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/wujek-srujek/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/wujek-srujek/subscriptions",
"type": "User",
"url": "https://api.github.com/users/wujek-srujek",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 6 | 2016-05-15T15:55:51Z | 2021-09-08T18:00:46Z | 2016-05-15T16:15:29Z | NONE | resolved | As far as I can understand from the docs, it is possible to upload files using the 'files' keyword param, but it requires a file object. I have a case where I have the data in memory, and it would require me to store to a temp file, which I would like to prevent if possible.
Would it be possible for requests to support in-memory data upload for multipart?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3194/reactions"
} | https://api.github.com/repos/psf/requests/issues/3194/timeline | null | completed | null | null | false | [
"It already does. =) Note the description for the files kwarg in [this bit of documentation](http://docs.python-requests.org/en/master/api/#requests.request).\n",
"Also [this section of the narrative documentation](http://docs.python-requests.org/en/master/user/quickstart/#post-a-multipart-encoded-file) mentions ... |
https://api.github.com/repos/psf/requests/issues/3193 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3193/labels{/name} | https://api.github.com/repos/psf/requests/issues/3193/comments | https://api.github.com/repos/psf/requests/issues/3193/events | https://github.com/psf/requests/pull/3193 | 154,880,265 | MDExOlB1bGxSZXF1ZXN0NzAxMDY2MjE= | 3,193 | Something went wrong with this. Ignore it, I will correct the PR. | {
"avatar_url": "https://avatars.githubusercontent.com/u/15115673?v=4",
"events_url": "https://api.github.com/users/AlexPHorta/events{/privacy}",
"followers_url": "https://api.github.com/users/AlexPHorta/followers",
"following_url": "https://api.github.com/users/AlexPHorta/following{/other_user}",
"gists_url": "https://api.github.com/users/AlexPHorta/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/AlexPHorta",
"id": 15115673,
"login": "AlexPHorta",
"node_id": "MDQ6VXNlcjE1MTE1Njcz",
"organizations_url": "https://api.github.com/users/AlexPHorta/orgs",
"received_events_url": "https://api.github.com/users/AlexPHorta/received_events",
"repos_url": "https://api.github.com/users/AlexPHorta/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/AlexPHorta/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/AlexPHorta/subscriptions",
"type": "User",
"url": "https://api.github.com/users/AlexPHorta",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 0 | 2016-05-14T23:07:41Z | 2021-09-08T04:01:00Z | 2016-05-14T23:12:54Z | NONE | resolved | I was scanning the issues and found this one, proposed for 3.0. I believe it's alright, at least the tests are all passing. Basically, I created a success attribute in requests.codes and changed the ok property at Response.
I hope everything is alright, thanks.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/15115673?v=4",
"events_url": "https://api.github.com/users/AlexPHorta/events{/privacy}",
"followers_url": "https://api.github.com/users/AlexPHorta/followers",
"following_url": "https://api.github.com/users/AlexPHorta/following{/other_user}",
"gists_url": "https://api.github.com/users/AlexPHorta/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/AlexPHorta",
"id": 15115673,
"login": "AlexPHorta",
"node_id": "MDQ6VXNlcjE1MTE1Njcz",
"organizations_url": "https://api.github.com/users/AlexPHorta/orgs",
"received_events_url": "https://api.github.com/users/AlexPHorta/received_events",
"repos_url": "https://api.github.com/users/AlexPHorta/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/AlexPHorta/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/AlexPHorta/subscriptions",
"type": "User",
"url": "https://api.github.com/users/AlexPHorta",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3193/reactions"
} | https://api.github.com/repos/psf/requests/issues/3193/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3193.diff",
"html_url": "https://github.com/psf/requests/pull/3193",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/3193.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3193"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/3192 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3192/labels{/name} | https://api.github.com/repos/psf/requests/issues/3192/comments | https://api.github.com/repos/psf/requests/issues/3192/events | https://github.com/psf/requests/pull/3192 | 154,824,720 | MDExOlB1bGxSZXF1ZXN0NzAwNzYyMzM= | 3,192 | Allow graceful interruption of testserver.Server | {
"avatar_url": "https://avatars.githubusercontent.com/u/91550?v=4",
"events_url": "https://api.github.com/users/brettdh/events{/privacy}",
"followers_url": "https://api.github.com/users/brettdh/followers",
"following_url": "https://api.github.com/users/brettdh/following{/other_user}",
"gists_url": "https://api.github.com/users/brettdh/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/brettdh",
"id": 91550,
"login": "brettdh",
"node_id": "MDQ6VXNlcjkxNTUw",
"organizations_url": "https://api.github.com/users/brettdh/orgs",
"received_events_url": "https://api.github.com/users/brettdh/received_events",
"repos_url": "https://api.github.com/users/brettdh/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/brettdh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/brettdh/subscriptions",
"type": "User",
"url": "https://api.github.com/users/brettdh",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2016-05-14T00:46:52Z | 2021-09-08T04:00:59Z | 2016-05-17T15:45:12Z | CONTRIBUTOR | resolved | So that failing tests don't cause the server thread to hang
indefinitely, waiting for connections that will never come.
Rationale for suppressing error/traceback from interrupted
_accept_connection in testserver.Server:
https://gist.github.com/brettdh/b6e741227b2297f19d2118077f14dfa5
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3192/reactions"
} | https://api.github.com/repos/psf/requests/issues/3192/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3192.diff",
"html_url": "https://github.com/psf/requests/pull/3192",
"merged_at": "2016-05-17T15:45:12Z",
"patch_url": "https://github.com/psf/requests/pull/3192.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3192"
} | true | [
"ping @Lukasa @sigmavirus24 \n\nI think I addressed the comments from #3185.\n\nOddly, I cannot make the test suite hang indefinitely when I run it locally, but that's what's happening in jenkins. :confused: Maybe you can spot something I'm missing?\n",
"Ok, cool, I'm happy with this. Assuming @sigmavirus24 is as... |
https://api.github.com/repos/psf/requests/issues/3191 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3191/labels{/name} | https://api.github.com/repos/psf/requests/issues/3191/comments | https://api.github.com/repos/psf/requests/issues/3191/events | https://github.com/psf/requests/issues/3191 | 154,682,307 | MDU6SXNzdWUxNTQ2ODIzMDc= | 3,191 | Why urllib3 is bundled dependency not external? | {
"avatar_url": "https://avatars.githubusercontent.com/u/1063219?v=4",
"events_url": "https://api.github.com/users/kuraga/events{/privacy}",
"followers_url": "https://api.github.com/users/kuraga/followers",
"following_url": "https://api.github.com/users/kuraga/following{/other_user}",
"gists_url": "https://api.github.com/users/kuraga/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kuraga",
"id": 1063219,
"login": "kuraga",
"node_id": "MDQ6VXNlcjEwNjMyMTk=",
"organizations_url": "https://api.github.com/users/kuraga/orgs",
"received_events_url": "https://api.github.com/users/kuraga/received_events",
"repos_url": "https://api.github.com/users/kuraga/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kuraga/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kuraga/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kuraga",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2016-05-13T10:32:52Z | 2021-09-08T18:00:46Z | 2016-05-13T10:35:23Z | NONE | resolved | Good day!
Why urllib3 is bundled dependency not external?
(Sorry I couldn't find something like mailing list for this question.)
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3191/reactions"
} | https://api.github.com/repos/psf/requests/issues/3191/timeline | null | completed | null | null | false | [
"Hi, thanks for the question! Please see the discussion on #1812 and #1811.\n"
] |
https://api.github.com/repos/psf/requests/issues/3190 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3190/labels{/name} | https://api.github.com/repos/psf/requests/issues/3190/comments | https://api.github.com/repos/psf/requests/issues/3190/events | https://github.com/psf/requests/issues/3190 | 154,575,595 | MDU6SXNzdWUxNTQ1NzU1OTU= | 3,190 | Requests Session doesn't use HTTP_PROXY settings when sending PreparedRequests? | {
"avatar_url": "https://avatars.githubusercontent.com/u/2421362?v=4",
"events_url": "https://api.github.com/users/wujek-srujek/events{/privacy}",
"followers_url": "https://api.github.com/users/wujek-srujek/followers",
"following_url": "https://api.github.com/users/wujek-srujek/following{/other_user}",
"gists_url": "https://api.github.com/users/wujek-srujek/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/wujek-srujek",
"id": 2421362,
"login": "wujek-srujek",
"node_id": "MDQ6VXNlcjI0MjEzNjI=",
"organizations_url": "https://api.github.com/users/wujek-srujek/orgs",
"received_events_url": "https://api.github.com/users/wujek-srujek/received_events",
"repos_url": "https://api.github.com/users/wujek-srujek/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/wujek-srujek/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/wujek-srujek/subscriptions",
"type": "User",
"url": "https://api.github.com/users/wujek-srujek",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 6 | 2016-05-12T20:37:10Z | 2021-09-08T17:05:35Z | 2016-05-12T20:41:50Z | NONE | resolved | I am using mitmproxy for development of a RESTful API client as I want to see what's sent. I noticed that sometimes I don't see all requests in my proxy logs. I narrowed down the code to a reproducible test case.
How to reproduce: start some proxy locally which allows you to see the requests, set the HTTP(S)_PROXY variables and execute the following code:
```
#!/usr/bin/env python3
import requests
session = requests.Session()
def retry_hook(res, *args, **kwargs):
req = res.request
print(req)
if 'X-Retried-Request' not in req.headers:
print('(Retrying)')
req.headers['X-Retried-Request'] = True
return session.send(req)
else:
print('(Not retrying retried request)')
session.get('https://www.google.de', hooks={'response': retry_hook}, verify=False)
```
- I'm using google.de as I am in Germany and google.com results in redirects, which I don't want to see in my log. Depending on where you test this, use a different domain.
What the code does: it sends a request, and using a hook, when the response is ready, it re-sends the original request. The first time the request is re-sent is sets a custom header, so that the next time the request is not re-sent as the header is discovered. The first time the request is immediately re-sent, the second time it is not. Every time the hook is invoked the request is printed out.
I see the following output (ignoring a warning about unverified HTTPS requests):
```
<PreparedRequest [GET]>
(Retrying)
<PreparedRequest [GET]>
(Not retrying retried request)
```
However, in my proxy window, I only see the first request, the second one is not seen (the custom header is missing from the request, that's how I know it is the second one that's missing.
Now, this is a contrived example, let me explain a real world scenario. We have a RESTful service which requires OAuth2 tokens for authorization. The tokens we have are valid for 3 minutes. I am writing a tool in Python which allows us to call the service, and it handles authentication transparently: it gets a token initially, and as long as it is valid, it uses it. At some point, a 401 response will be returned, that's when the hook comes in - it recognizes 401, fetches another token, sets it on the session and request again, and retries the request once. The result of this retried request is the result of the hook, meaning that a unauthorized first request is 'forgotten', and the retried one is returned. Any other result than 401, and retried requests resulting in 401 get standard treatment.
There is an issue that such retried requests always fail when a proxy is in place, but as they correctly fetched the token and set it on the Session, subsequent requests don't have this problem.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3190/reactions"
} | https://api.github.com/repos/psf/requests/issues/3190/timeline | null | completed | null | null | false | [
"Yup, sorry, this is an expected behaviour. See #2807 which also discusses the expected solution.\n",
"It seems I need code like this right before I re-send the request:\n\n```\nsettings = session.merge_environment_settings(req.url, {}, False, False, None)\nreturn session.send(req, **settings)\n```\n\nI have a fe... |
https://api.github.com/repos/psf/requests/issues/3189 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3189/labels{/name} | https://api.github.com/repos/psf/requests/issues/3189/comments | https://api.github.com/repos/psf/requests/issues/3189/events | https://github.com/psf/requests/issues/3189 | 154,557,093 | MDU6SXNzdWUxNTQ1NTcwOTM= | 3,189 | error 54, 'Connection reset by peer' | {
"avatar_url": "https://avatars.githubusercontent.com/u/156872?v=4",
"events_url": "https://api.github.com/users/degroat/events{/privacy}",
"followers_url": "https://api.github.com/users/degroat/followers",
"following_url": "https://api.github.com/users/degroat/following{/other_user}",
"gists_url": "https://api.github.com/users/degroat/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/degroat",
"id": 156872,
"login": "degroat",
"node_id": "MDQ6VXNlcjE1Njg3Mg==",
"organizations_url": "https://api.github.com/users/degroat/orgs",
"received_events_url": "https://api.github.com/users/degroat/received_events",
"repos_url": "https://api.github.com/users/degroat/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/degroat/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/degroat/subscriptions",
"type": "User",
"url": "https://api.github.com/users/degroat",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 16 | 2016-05-12T19:02:16Z | 2018-02-22T00:43:30Z | 2016-05-12T20:33:26Z | NONE | off-topic | I'm getting the dreaded Error 54, Connection reset by peer when trying to do a POST to a URL with a payment provider I'm using. Here is the basic code I'm running:
``` python
import requests, base64
url = "https://sandbox.api.mxmerchant.com/checkout/v3/auth/token/282059461"
headers = {
'Authorization': 'Basic ' + base64.b64encode('myusername:mypassword') ,
}
r = requests.post(url, headers=headers)
print r.text
```
If I run this exact code on an Ubuntu server it works fine (meaning it returns a json message stating that the username and password are incorrect).
If I run it on OSX 10.11.4, I get the connection reset error.
After reading a ton of issues on here and various postings on StackOverflow, everyone seems to think it's related to SNI. Unfortunately, none of the recommendations that I've come across have fixed the issue.
My Ubuntu server has Python 2.7.6, OpenSSL 1.0.1f and requests 2.8.1.
My OSX has Python 2.7.10, OpenSSL 1.0.2g and requests 2.10.0. I also have ndg-httpsclient and pyopenssl both installed per #1347
Any idea what it is that I'm missing?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 3,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 3,
"url": "https://api.github.com/repos/psf/requests/issues/3189/reactions"
} | https://api.github.com/repos/psf/requests/issues/3189/timeline | null | completed | null | null | false | [
"Can you confirm for me what the output of these two commands is on your OS X machine?\n\n```\npython -c \"import ssl; print ssl.OPENSSL_VERSION\"\npython -c \"from OpenSSL.SSL import SSLeay_version, SSLEAY_VERSION; print SSLeay_version(SSLEAY_VERSION)\"\n```\n",
"```\n>> python -c \"import ssl; print ssl.OPENSSL... |
https://api.github.com/repos/psf/requests/issues/3188 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3188/labels{/name} | https://api.github.com/repos/psf/requests/issues/3188/comments | https://api.github.com/repos/psf/requests/issues/3188/events | https://github.com/psf/requests/pull/3188 | 154,443,240 | MDExOlB1bGxSZXF1ZXN0Njk4MDkxNTQ= | 3,188 | Replace tab with appropriate spaces. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 0 | 2016-05-12T09:58:34Z | 2021-09-08T04:01:01Z | 2016-05-12T13:11:19Z | MEMBER | resolved | Looks like this crept in. It shouldn't break anything, it's in a multiline string, but still, let's get rid of it.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3188/reactions"
} | https://api.github.com/repos/psf/requests/issues/3188/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3188.diff",
"html_url": "https://github.com/psf/requests/pull/3188",
"merged_at": "2016-05-12T13:11:19Z",
"patch_url": "https://github.com/psf/requests/pull/3188.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3188"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/3187 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3187/labels{/name} | https://api.github.com/repos/psf/requests/issues/3187/comments | https://api.github.com/repos/psf/requests/issues/3187/events | https://github.com/psf/requests/issues/3187 | 154,426,728 | MDU6SXNzdWUxNTQ0MjY3Mjg= | 3,187 | GAE and ChunkedEncodingError, working patch. | {
"avatar_url": "https://avatars.githubusercontent.com/u/317142?v=4",
"events_url": "https://api.github.com/users/cnicodeme/events{/privacy}",
"followers_url": "https://api.github.com/users/cnicodeme/followers",
"following_url": "https://api.github.com/users/cnicodeme/following{/other_user}",
"gists_url": "https://api.github.com/users/cnicodeme/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/cnicodeme",
"id": 317142,
"login": "cnicodeme",
"node_id": "MDQ6VXNlcjMxNzE0Mg==",
"organizations_url": "https://api.github.com/users/cnicodeme/orgs",
"received_events_url": "https://api.github.com/users/cnicodeme/received_events",
"repos_url": "https://api.github.com/users/cnicodeme/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/cnicodeme/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cnicodeme/subscriptions",
"type": "User",
"url": "https://api.github.com/users/cnicodeme",
"user_view_type": "public"
} | [
{
"color": "fbca04",
"default": false,
"description": null,
"id": 615414998,
"name": "GAE Support",
"node_id": "MDU6TGFiZWw2MTU0MTQ5OTg=",
"url": "https://api.github.com/repos/psf/requests/labels/GAE%20Support"
}
] | closed | true | null | [] | null | 3 | 2016-05-12T08:36:47Z | 2021-09-08T09:00:45Z | 2016-05-12T08:38:59Z | NONE | resolved | Hey everyone,
sorry for my intervention here, "out of the blue". I tried to understand if this issue was already discussed (but could find them) so I come here with the situation and trying to understand the solution.
The problem is the following (from what I understood) : Google App Engine, replace the implementation of urlfetch by their own, which contains some changes that breaks urllib3 and subsequently Requests.
@agfor [made a fix](https://github.com/agfor/requests/commit/da863cc) that seems to work (I didn't had any ChunkedEncodingError since I place the patch on line) and, from my understanding, doesn't break the others users, those that don't use GAE.
I didn't saw his patch as submitted here (I'm wondering why) and I don't know why this hasn't been taken into consideration here. (Please note those are real question, not critics/remarks, my intentions are good :) ).
Hence my post :)
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3187/reactions"
} | https://api.github.com/repos/psf/requests/issues/3187/timeline | null | completed | null | null | false | [
"@cnicodeme The requests project does not consider GAE formally supported. Put another way, we don't have any special-case code _in requests_ to use GAE properly. The recommended method of using GoogleAppEngine with requests is to use the [requests-toolbelt `AppEngineAdapter`](http://toolbelt.readthedocs.io/en/late... |
https://api.github.com/repos/psf/requests/issues/3186 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3186/labels{/name} | https://api.github.com/repos/psf/requests/issues/3186/comments | https://api.github.com/repos/psf/requests/issues/3186/events | https://github.com/psf/requests/issues/3186 | 154,319,859 | MDU6SXNzdWUxNTQzMTk4NTk= | 3,186 | Response.content iterates in needlessly small chunks | {
"avatar_url": "https://avatars.githubusercontent.com/u/300211?v=4",
"events_url": "https://api.github.com/users/vfaronov/events{/privacy}",
"followers_url": "https://api.github.com/users/vfaronov/followers",
"following_url": "https://api.github.com/users/vfaronov/following{/other_user}",
"gists_url": "https://api.github.com/users/vfaronov/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/vfaronov",
"id": 300211,
"login": "vfaronov",
"node_id": "MDQ6VXNlcjMwMDIxMQ==",
"organizations_url": "https://api.github.com/users/vfaronov/orgs",
"received_events_url": "https://api.github.com/users/vfaronov/received_events",
"repos_url": "https://api.github.com/users/vfaronov/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/vfaronov/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vfaronov/subscriptions",
"type": "User",
"url": "https://api.github.com/users/vfaronov",
"user_view_type": "public"
} | [] | open | false | null | [] | null | 5 | 2016-05-11T19:12:34Z | 2024-07-08T10:55:05Z | null | NONE | null | `Response.content` [iterates over the response data in chunks of 10240 bytes](https://github.com/kennethreitz/requests/blob/87704105af65b382b86f168f6a54192eab91faf2/requests/models.py#L741). The number 10240 was set in commit [`62d2ea8`](https://github.com/kennethreitz/requests/commit/62d2ea8).
After tracing the source code of urllib3 and httplib, I can’t see a reason for this behavior. It all ultimately goes through httplib’s [`HTTPResponse.readinto`](https://hg.python.org/cpython/file/87130512ef34/Lib/http/client.py#l469), which automatically limits the read size according to `Content-Length` or the `chunked` framing.
Therefore, it seems that, if you simply set `CONTENT_CHUNK_SIZE` to a much larger number (like 10240000), nothing should change, except `Response.content` will become more efficient on large responses.
**Update:** it seems like httplib allocates a buffer of the requested size (to be read into), so simply setting `CONTENT_CHUNK_SIZE` to a large value will cause large chunks of memory to be allocated, which is probably a bad idea.
This is not a problem for me and I have not researched it thoroughly. I’m filing this issue after investigating [a Stack Overflow question](http://stackoverflow.com/questions/37135880/python-3-urllib-vs-requests-performance) where this caused an unexpected slowdown for the poster, and a subsequent [IRC exchange](https://botbot.me/freenode/python-requests/2016-05-11/?msg=65874287&page=1) with @Lukasa. Feel free to do (or not do) whatever you think is right here.
| null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3186/reactions"
} | https://api.github.com/repos/psf/requests/issues/3186/timeline | null | null | null | null | false | [
"It's good to know that httplib allocates a buffer of that size. I think we can probably stretch to double that buffer though: 20kb of buffer is unlikely to be the end of the world.\n\nAt the very least, though, we should understand how this works so that we can write documentation to explain this.\n",
"Originall... |
https://api.github.com/repos/psf/requests/issues/3185 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3185/labels{/name} | https://api.github.com/repos/psf/requests/issues/3185/comments | https://api.github.com/repos/psf/requests/issues/3185/events | https://github.com/psf/requests/pull/3185 | 154,239,373 | MDExOlB1bGxSZXF1ZXN0Njk2Njg3NzU= | 3,185 | Support ALL_PROXY environment variable | {
"avatar_url": "https://avatars.githubusercontent.com/u/91550?v=4",
"events_url": "https://api.github.com/users/brettdh/events{/privacy}",
"followers_url": "https://api.github.com/users/brettdh/followers",
"following_url": "https://api.github.com/users/brettdh/following{/other_user}",
"gists_url": "https://api.github.com/users/brettdh/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/brettdh",
"id": 91550,
"login": "brettdh",
"node_id": "MDQ6VXNlcjkxNTUw",
"organizations_url": "https://api.github.com/users/brettdh/orgs",
"received_events_url": "https://api.github.com/users/brettdh/received_events",
"repos_url": "https://api.github.com/users/brettdh/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/brettdh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/brettdh/subscriptions",
"type": "User",
"url": "https://api.github.com/users/brettdh",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 14 | 2016-05-11T13:09:02Z | 2021-09-08T04:00:59Z | 2016-05-17T15:42:32Z | CONTRIBUTOR | resolved | Closes #3183.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3185/reactions"
} | https://api.github.com/repos/psf/requests/issues/3185/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3185.diff",
"html_url": "https://github.com/psf/requests/pull/3185",
"merged_at": "2016-05-17T15:42:32Z",
"patch_url": "https://github.com/psf/requests/pull/3185.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3185"
} | true | [
"ping @Lukasa \n",
"Agh, Python3 (iteritems). Pushing fix with six shortly.\n\nOn a related note - has there ever been talk of moving to [tox](http://tox.readthedocs.io/en/latest/) for testing?\n",
"Found that this doesn't actually work yet, as evidenced by the new, failing functional test. Will investigate fur... |
https://api.github.com/repos/psf/requests/issues/3184 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3184/labels{/name} | https://api.github.com/repos/psf/requests/issues/3184/comments | https://api.github.com/repos/psf/requests/issues/3184/events | https://github.com/psf/requests/pull/3184 | 154,155,484 | MDExOlB1bGxSZXF1ZXN0Njk2MTIxMDc= | 3,184 | Refactor prepare_body | {
"avatar_url": "https://avatars.githubusercontent.com/u/3794108?v=4",
"events_url": "https://api.github.com/users/davidsoncasey/events{/privacy}",
"followers_url": "https://api.github.com/users/davidsoncasey/followers",
"following_url": "https://api.github.com/users/davidsoncasey/following{/other_user}",
"gists_url": "https://api.github.com/users/davidsoncasey/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/davidsoncasey",
"id": 3794108,
"login": "davidsoncasey",
"node_id": "MDQ6VXNlcjM3OTQxMDg=",
"organizations_url": "https://api.github.com/users/davidsoncasey/orgs",
"received_events_url": "https://api.github.com/users/davidsoncasey/received_events",
"repos_url": "https://api.github.com/users/davidsoncasey/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/davidsoncasey/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/davidsoncasey/subscriptions",
"type": "User",
"url": "https://api.github.com/users/davidsoncasey",
"user_view_type": "public"
} | [
{
"color": "e102d8",
"default": false,
"description": null,
"id": 117745,
"name": "Planned",
"node_id": "MDU6TGFiZWwxMTc3NDU=",
"url": "https://api.github.com/repos/psf/requests/labels/Planned"
},
{
"color": "eb6420",
"default": false,
"description": null,
"id": 44501... | closed | true | null | [] | null | 26 | 2016-05-11T04:01:14Z | 2021-09-07T00:06:37Z | 2017-02-10T17:18:18Z | NONE | resolved | @Lukasa Here's an alternative fix to #3066 (discussed in PR #3181), where I refactored `PreparedRequest.prepare_body` and `PreparedRequest.prepare_content_length` so that `prepare_content_length` is always called.
My only question is in the case when the body is a stream (which it is in the case that brought up this issue) that the current position will always be 0 when the length is calculated. Previously, in cases where `prepare_auth` was not called, the content length was being calculated with `super_len`, now it would be calculated using `self.headers['Content-Length'] = builtin_str(max(0, end_pos - curr_pos))`. As far as I can tell, this will give the same result (as long as the current position is 0), and this is how it's been computed in cases where authorization is being used. But I'm curious if you have thoughts about this.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3184/reactions"
} | https://api.github.com/repos/psf/requests/issues/3184/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/3184.diff",
"html_url": "https://github.com/psf/requests/pull/3184",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/3184.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/3184"
} | true | [
"So, I think in general I like this better. However, your point about `super_len` is a real one.\n\nI think the solution here is to rewrite `prepare_content_length` to have it always call `super_len`. `super_len` does use `tell` to do a little dance here, so I think it's probably going to be good enough: @sigmaviru... |
https://api.github.com/repos/psf/requests/issues/3183 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/3183/labels{/name} | https://api.github.com/repos/psf/requests/issues/3183/comments | https://api.github.com/repos/psf/requests/issues/3183/events | https://github.com/psf/requests/issues/3183 | 154,007,895 | MDU6SXNzdWUxNTQwMDc4OTU= | 3,183 | Feature request: support ALL_PROXY environment variable | {
"avatar_url": "https://avatars.githubusercontent.com/u/91550?v=4",
"events_url": "https://api.github.com/users/brettdh/events{/privacy}",
"followers_url": "https://api.github.com/users/brettdh/followers",
"following_url": "https://api.github.com/users/brettdh/following{/other_user}",
"gists_url": "https://api.github.com/users/brettdh/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/brettdh",
"id": 91550,
"login": "brettdh",
"node_id": "MDQ6VXNlcjkxNTUw",
"organizations_url": "https://api.github.com/users/brettdh/orgs",
"received_events_url": "https://api.github.com/users/brettdh/received_events",
"repos_url": "https://api.github.com/users/brettdh/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/brettdh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/brettdh/subscriptions",
"type": "User",
"url": "https://api.github.com/users/brettdh",
"user_view_type": "public"
} | [
{
"color": "0b02e1",
"default": false,
"description": null,
"id": 191274,
"name": "Contributor Friendly",
"node_id": "MDU6TGFiZWwxOTEyNzQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Contributor%20Friendly"
}
] | closed | true | null | [] | null | 2 | 2016-05-10T13:35:35Z | 2021-09-08T18:00:44Z | 2016-05-17T15:42:32Z | CONTRIBUTOR | resolved | As of 2.10.0, I can set `HTTP_PROXY=socks5://example.com:port`, and then requests will use that SOCKS proxy. However, other tools (e.g. Docker) currently require the use of `ALL_PROXY` instead, and get confused if you set `HTTP_PROXY` to a URL that begins with `socks5://`. I think Docker should support the use of `HTTP_PROXY`, but requests should also support the use of `ALL_PROXY`, especially with the recent (thank you thank you thank you) addition of SOCKS support.
I thought that this might need to go through urllib3, but it seems like it would be a relatively simple change to [sessions.py](https://github.com/kennethreitz/requests/blob/master/requests/sessions.py#L212), to look at the `'all'` key before checking the scheme. But, then I read your contributor's guide and thought it best to post an issue before just doing it. :smile:
Please let me know what you think.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/3183/reactions"
} | https://api.github.com/repos/psf/requests/issues/3183/timeline | null | completed | null | null | false | [
"Thanks for the suggestion!\n\nI don't think we need to go through urllib3: your analysis is right, sessions.py can DTRT here. I think this is a reasonable enhancment, so we'd welcome a pull request for this.\n",
"Great, thanks for the super-quick answer! I'm happy to pick this up and will start looking into it s... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.