url
stringlengths
50
53
repository_url
stringclasses
1 value
labels_url
stringlengths
64
67
comments_url
stringlengths
59
62
events_url
stringlengths
57
60
html_url
stringlengths
38
43
id
int64
597k
2.65B
node_id
stringlengths
18
32
number
int64
1
6.83k
title
stringlengths
1
296
user
dict
labels
listlengths
0
5
state
stringclasses
2 values
locked
bool
2 classes
assignee
dict
assignees
listlengths
0
4
milestone
dict
comments
int64
0
211
created_at
stringlengths
20
20
updated_at
stringlengths
20
20
closed_at
stringlengths
20
20
author_association
stringclasses
3 values
active_lock_reason
stringclasses
4 values
body
stringlengths
0
65.6k
closed_by
dict
reactions
dict
timeline_url
stringlengths
59
62
performed_via_github_app
null
state_reason
stringclasses
3 values
draft
bool
2 classes
pull_request
dict
is_pull_request
bool
2 classes
issue_comments
listlengths
0
30
https://api.github.com/repos/psf/requests/issues/2831
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2831/labels{/name}
https://api.github.com/repos/psf/requests/issues/2831/comments
https://api.github.com/repos/psf/requests/issues/2831/events
https://github.com/psf/requests/pull/2831
111,813,558
MDExOlB1bGxSZXF1ZXN0NDc4OTk2NTg=
2,831
added fix for #2826
{ "avatar_url": "https://avatars.githubusercontent.com/u/1321193?v=4", "events_url": "https://api.github.com/users/shagunsodhani/events{/privacy}", "followers_url": "https://api.github.com/users/shagunsodhani/followers", "following_url": "https://api.github.com/users/shagunsodhani/following{/other_user}", "gists_url": "https://api.github.com/users/shagunsodhani/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/shagunsodhani", "id": 1321193, "login": "shagunsodhani", "node_id": "MDQ6VXNlcjEzMjExOTM=", "organizations_url": "https://api.github.com/users/shagunsodhani/orgs", "received_events_url": "https://api.github.com/users/shagunsodhani/received_events", "repos_url": "https://api.github.com/users/shagunsodhani/repos", "site_admin": false, "starred_url": "https://api.github.com/users/shagunsodhani/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/shagunsodhani/subscriptions", "type": "User", "url": "https://api.github.com/users/shagunsodhani", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2015-10-16T11:35:26Z
2021-09-08T06:00:52Z
2015-10-16T12:21:45Z
CONTRIBUTOR
resolved
Added some data to 2 sample requests on quickstart as discussed [here](https://github.com/kennethreitz/requests/issues/2826).
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2831/reactions" }
https://api.github.com/repos/psf/requests/issues/2831/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2831.diff", "html_url": "https://github.com/psf/requests/pull/2831", "merged_at": "2015-10-16T12:21:45Z", "patch_url": "https://github.com/psf/requests/pull/2831.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2831" }
true
[ "Thanks for this @shagunsodhani! :sparkles: :cake: :sparkles:\n", ":smile: \n" ]
https://api.github.com/repos/psf/requests/issues/2830
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2830/labels{/name}
https://api.github.com/repos/psf/requests/issues/2830/comments
https://api.github.com/repos/psf/requests/issues/2830/events
https://github.com/psf/requests/issues/2830
111,741,354
MDU6SXNzdWUxMTE3NDEzNTQ=
2,830
custom retries doesn't work while using POST method
{ "avatar_url": "https://avatars.githubusercontent.com/u/3613180?v=4", "events_url": "https://api.github.com/users/tribals/events{/privacy}", "followers_url": "https://api.github.com/users/tribals/followers", "following_url": "https://api.github.com/users/tribals/following{/other_user}", "gists_url": "https://api.github.com/users/tribals/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/tribals", "id": 3613180, "login": "tribals", "node_id": "MDQ6VXNlcjM2MTMxODA=", "organizations_url": "https://api.github.com/users/tribals/orgs", "received_events_url": "https://api.github.com/users/tribals/received_events", "repos_url": "https://api.github.com/users/tribals/repos", "site_admin": false, "starred_url": "https://api.github.com/users/tribals/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tribals/subscriptions", "type": "User", "url": "https://api.github.com/users/tribals", "user_view_type": "public" }
[]
closed
true
null
[]
null
4
2015-10-16T01:43:52Z
2021-09-08T21:00:55Z
2015-10-16T02:14:42Z
NONE
resolved
I had very confused ``` #!/usr/bin/env python import logging import requests from requests.adapters import HTTPAdapter from requests.packages.urllib3 import Retry logging.basicConfig() logging.getLogger().setLevel(logging.DEBUG) requests_log = logging.getLogger('requests') requests_log.setLevel(logging.DEBUG) requests_log.propagate = True with requests.Session() as s: retry = Retry(status_forcelist=[503]) adapter = HTTPAdapter(max_retries=retry) s.mount('http://', adapter) try: # r = s.get('http://httpbin.org/status/503') r = s.post('http://httpbin.org/status/503') r.raise_for_status() except requests.HTTPError: print 'BANG!' print "where are my retries???" except requests.exceptions.RetryError: print 'computation does not rich this exception' ``` When `session.get()` all works fine.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2830/reactions" }
https://api.github.com/repos/psf/requests/issues/2830/timeline
null
completed
null
null
false
[ "You need to specify the methods via the `method_whitelist` parameter to the Retry class. \n", "thx, forgive my inattention\n", "No worries @tribals. If you read my blog post about retries with requests I probably failed to mention this. Cheers!\n", "if it's [this post](http://www.coglib.com/~icordasc/blog/20...
https://api.github.com/repos/psf/requests/issues/2829
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2829/labels{/name}
https://api.github.com/repos/psf/requests/issues/2829/comments
https://api.github.com/repos/psf/requests/issues/2829/events
https://github.com/psf/requests/pull/2829
111,623,043
MDExOlB1bGxSZXF1ZXN0NDc3ODk3ODk=
2,829
Use buffering for HTTP responses on chunked requests
{ "avatar_url": "https://avatars.githubusercontent.com/u/5539301?v=4", "events_url": "https://api.github.com/users/dblia/events{/privacy}", "followers_url": "https://api.github.com/users/dblia/followers", "following_url": "https://api.github.com/users/dblia/following{/other_user}", "gists_url": "https://api.github.com/users/dblia/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/dblia", "id": 5539301, "login": "dblia", "node_id": "MDQ6VXNlcjU1MzkzMDE=", "organizations_url": "https://api.github.com/users/dblia/orgs", "received_events_url": "https://api.github.com/users/dblia/received_events", "repos_url": "https://api.github.com/users/dblia/repos", "site_admin": false, "starred_url": "https://api.github.com/users/dblia/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dblia/subscriptions", "type": "User", "url": "https://api.github.com/users/dblia", "user_view_type": "public" }
[]
closed
true
null
[]
null
6
2015-10-15T14:00:08Z
2021-09-08T06:00:52Z
2015-10-15T14:37:06Z
CONTRIBUTOR
resolved
For non-chunked requests, the request is performed using the 'urlopen' method that underlying uses buffering for the HTTP responses (for Python 2.7+ versions). For chunked requests though, the request is made via a different code path and so the 'getresponse' method is called without using buffering. So, the response is consumed per single byte via a recv() call on the underlying socket. This patch, fixes that issue to mimic the non-chucked request behavior.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2829/reactions" }
https://api.github.com/repos/psf/requests/issues/2829/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2829.diff", "html_url": "https://github.com/psf/requests/pull/2829", "merged_at": "2015-10-15T14:37:06Z", "patch_url": "https://github.com/psf/requests/pull/2829.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2829" }
true
[ "This seems like a sensible change to me, I'm :+1:. @sigmavirus24?\n", "What's the benefit?\n", "Without `buffering`, `httplib` will issue a lot of 1-byte reads in order to satisfy the constraints of the `read` call. That's...not good.\n", "Sorry, I was reading the commit message/PR message backwards. LGTM :+...
https://api.github.com/repos/psf/requests/issues/2828
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2828/labels{/name}
https://api.github.com/repos/psf/requests/issues/2828/comments
https://api.github.com/repos/psf/requests/issues/2828/events
https://github.com/psf/requests/issues/2828
111,614,881
MDU6SXNzdWUxMTE2MTQ4ODE=
2,828
PUT send is doing Quotation on json payload
{ "avatar_url": "https://avatars.githubusercontent.com/u/5641381?v=4", "events_url": "https://api.github.com/users/czerwe/events{/privacy}", "followers_url": "https://api.github.com/users/czerwe/followers", "following_url": "https://api.github.com/users/czerwe/following{/other_user}", "gists_url": "https://api.github.com/users/czerwe/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/czerwe", "id": 5641381, "login": "czerwe", "node_id": "MDQ6VXNlcjU2NDEzODE=", "organizations_url": "https://api.github.com/users/czerwe/orgs", "received_events_url": "https://api.github.com/users/czerwe/received_events", "repos_url": "https://api.github.com/users/czerwe/repos", "site_admin": false, "starred_url": "https://api.github.com/users/czerwe/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/czerwe/subscriptions", "type": "User", "url": "https://api.github.com/users/czerwe", "user_view_type": "public" }
[]
closed
true
null
[]
null
6
2015-10-15T13:19:01Z
2021-09-08T21:00:59Z
2015-10-15T13:20:47Z
NONE
resolved
Hi, i need to send via PUT an octetstream/json element via put. requests is quoting the full string. Example: ``` testdata = '[{"cid": "1","uuid": "sdasd"}]' response = requests.put(requestUrl, auth=self.auth, json=testdata) ``` can be seen in Wireshare like this: "[{\"cid\": \"1\",\"uuid\": \"sdasd\"}]" if i use POST it is unquoted. My remote REST Interface is not able to handle the quoted strings. I wasn't able to find any option where i can turn of the quotation.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2828/reactions" }
https://api.github.com/repos/psf/requests/issues/2828/timeline
null
completed
null
null
false
[ "If you read the [documentation](http://docs.python-requests.org/en/latest/user/quickstart/?highlight=json#more-complicated-post-requests) closely, you'll see your code should look like:\n\n``` py\n testdata = [{\"cid\": \"1\",\"uuid\": \"sdasd\"}]\n response = requests.put(requestUrl, auth=self.auth, json=te...
https://api.github.com/repos/psf/requests/issues/2827
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2827/labels{/name}
https://api.github.com/repos/psf/requests/issues/2827/comments
https://api.github.com/repos/psf/requests/issues/2827/events
https://github.com/psf/requests/pull/2827
111,608,494
MDExOlB1bGxSZXF1ZXN0NDc3ODA5MTI=
2,827
Fixed usage example in sessions.py
{ "avatar_url": "https://avatars.githubusercontent.com/u/3153932?v=4", "events_url": "https://api.github.com/users/daniel-mueller/events{/privacy}", "followers_url": "https://api.github.com/users/daniel-mueller/followers", "following_url": "https://api.github.com/users/daniel-mueller/following{/other_user}", "gists_url": "https://api.github.com/users/daniel-mueller/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/daniel-mueller", "id": 3153932, "login": "daniel-mueller", "node_id": "MDQ6VXNlcjMxNTM5MzI=", "organizations_url": "https://api.github.com/users/daniel-mueller/orgs", "received_events_url": "https://api.github.com/users/daniel-mueller/received_events", "repos_url": "https://api.github.com/users/daniel-mueller/repos", "site_admin": false, "starred_url": "https://api.github.com/users/daniel-mueller/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/daniel-mueller/subscriptions", "type": "User", "url": "https://api.github.com/users/daniel-mueller", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2015-10-15T12:43:54Z
2021-09-08T06:00:52Z
2015-10-15T13:01:13Z
CONTRIBUTOR
resolved
The usage example for sessions.py's Session class is not correct in my opinion. The get method in fact returns a `Response <Response>` object, the notation "200" may be misleading the user into thinking only the http statuscode will be returned. Furthermore the output you get on console if typing the example in is different from the example and similar to my change. The two usage examples in models.py are also similar to my change. Thank you for considering.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2827/reactions" }
https://api.github.com/repos/psf/requests/issues/2827/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2827.diff", "html_url": "https://github.com/psf/requests/pull/2827", "merged_at": "2015-10-15T13:01:13Z", "patch_url": "https://github.com/psf/requests/pull/2827.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2827" }
true
[ "Thanks for this @daniel-mueller!\n" ]
https://api.github.com/repos/psf/requests/issues/2826
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2826/labels{/name}
https://api.github.com/repos/psf/requests/issues/2826/comments
https://api.github.com/repos/psf/requests/issues/2826/events
https://github.com/psf/requests/issues/2826
111,390,933
MDU6SXNzdWUxMTEzOTA5MzM=
2,826
Bad examples of PUSH and PUT in Quickstart
{ "avatar_url": "https://avatars.githubusercontent.com/u/227449?v=4", "events_url": "https://api.github.com/users/TorKlingberg/events{/privacy}", "followers_url": "https://api.github.com/users/TorKlingberg/followers", "following_url": "https://api.github.com/users/TorKlingberg/following{/other_user}", "gists_url": "https://api.github.com/users/TorKlingberg/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/TorKlingberg", "id": 227449, "login": "TorKlingberg", "node_id": "MDQ6VXNlcjIyNzQ0OQ==", "organizations_url": "https://api.github.com/users/TorKlingberg/orgs", "received_events_url": "https://api.github.com/users/TorKlingberg/received_events", "repos_url": "https://api.github.com/users/TorKlingberg/repos", "site_admin": false, "starred_url": "https://api.github.com/users/TorKlingberg/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/TorKlingberg/subscriptions", "type": "User", "url": "https://api.github.com/users/TorKlingberg", "user_view_type": "public" }
[]
closed
true
null
[]
null
3
2015-10-14T12:48:36Z
2021-09-08T21:00:58Z
2015-10-19T09:48:54Z
NONE
resolved
The quickstart guide had these examples: ``` >>> r = requests.post("http://httpbin.org/post") >>> r = requests.put("http://httpbin.org/put") ``` With PUSH and PUT you almost always want to include some data. Without it they become fairly meaningless.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2826/reactions" }
https://api.github.com/repos/psf/requests/issues/2826/timeline
null
completed
null
null
false
[ "That's certainly true, though with the quickstart guide we're generally trying to err on the side of not providing _too_ much extraneous information. Nevertheless, if you'd like to open a pull request giving both of those some data (a simple bytestring will do), I'd be happy to merge that. =)\n", "@Lukasa I have...
https://api.github.com/repos/psf/requests/issues/2825
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2825/labels{/name}
https://api.github.com/repos/psf/requests/issues/2825/comments
https://api.github.com/repos/psf/requests/issues/2825/events
https://github.com/psf/requests/pull/2825
111,386,635
MDExOlB1bGxSZXF1ZXN0NDc2NTE5OTk=
2,825
Add warnings about text/binary mode files.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
[]
closed
true
null
[]
null
7
2015-10-14T12:24:27Z
2021-09-08T06:00:50Z
2015-10-24T14:37:16Z
MEMBER
resolved
Resolves #2725. @sigmavirus24 I'm wondering if we should add a warning to `super_len` for whenever we decide on the length of the file using `os.fstat`, if the file has not been opened in binary mode. It should be easy enough to do. Thoughts?
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2825/reactions" }
https://api.github.com/repos/psf/requests/issues/2825/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2825.diff", "html_url": "https://github.com/psf/requests/pull/2825", "merged_at": "2015-10-24T14:37:16Z", "patch_url": "https://github.com/psf/requests/pull/2825.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2825" }
true
[ "@Lukasa do we want to add that warning in `super_len` and then make it a hard exception in 3.0.0?\n", "@sigmavirus24 Yeah, probably.\n", "&hearts; thanks brosephs @sigmavirus24 @Lukasa \n", "@Lukasa do you want me to send that separately or do you want to do that as part of this PR?\n", "Ah, I forgot about...
https://api.github.com/repos/psf/requests/issues/2824
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2824/labels{/name}
https://api.github.com/repos/psf/requests/issues/2824/comments
https://api.github.com/repos/psf/requests/issues/2824/events
https://github.com/psf/requests/issues/2824
111,162,613
MDU6SXNzdWUxMTExNjI2MTM=
2,824
Test failure for 2.8.0
{ "avatar_url": "https://avatars.githubusercontent.com/u/25111?v=4", "events_url": "https://api.github.com/users/cournape/events{/privacy}", "followers_url": "https://api.github.com/users/cournape/followers", "following_url": "https://api.github.com/users/cournape/following{/other_user}", "gists_url": "https://api.github.com/users/cournape/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/cournape", "id": 25111, "login": "cournape", "node_id": "MDQ6VXNlcjI1MTEx", "organizations_url": "https://api.github.com/users/cournape/orgs", "received_events_url": "https://api.github.com/users/cournape/received_events", "repos_url": "https://api.github.com/users/cournape/repos", "site_admin": false, "starred_url": "https://api.github.com/users/cournape/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cournape/subscriptions", "type": "User", "url": "https://api.github.com/users/cournape", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2015-10-13T11:41:16Z
2021-09-08T21:00:59Z
2015-10-13T12:07:20Z
NONE
resolved
I see this test failure: ``` y.test test_requests.py ============================================================================================================================= test session starts ============================================================================================================================== platform linux2 -- Python 2.7.10, pytest-2.8.2, py-1.4.30, pluggy-0.3.1 rootdir: /home/davidc/src/python/requests, inifile: collected 165 items test_requests.py ......................................................................................x...........................................................F.................. =================================================================================================================================== FAILURES =================================================================================================================================== _______________________________________________________________________________________________________________ TestMorselToCookieExpires.test_expires_valid_str _______________________________________________________________________________________________________________ self = <test_requests.TestMorselToCookieExpires testMethod=test_expires_valid_str> def test_expires_valid_str(self): """Test case where we convert expires from string time.""" morsel = Morsel() morsel['expires'] = 'Thu, 01-Jan-1970 00:00:01 GMT' cookie = morsel_to_cookie(morsel) > assert cookie.expires == 1 E AssertionError: assert -3599 == 1 E + where -3599 = Cookie(version=0, name=None, value=None, port=None, port_specified=False, domain='', domain_specified=False, domain_in...False, secure=False, expires=-3599, discard=False, comment='', comment_url=False, rest={'HttpOnly': ''}, rfc2109=False).expires test_requests.py:1455: AssertionError =============================================================================================================== 1 failed, 163 passed, 1 xfailed in 33.37 seconds =============================================================================================================== ``` Is this expected ?
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2824/reactions" }
https://api.github.com/repos/psf/requests/issues/2824/timeline
null
completed
null
null
false
[ "Sadly, this is a known problem. See #1859 for the initial report and #1860 for a proposed fix that never landed. Currently we don't have a good proposal for how to fix this permanently, but the test failure you have right there is benign.\n", "understood. Thanks for letting me know\n" ]
https://api.github.com/repos/psf/requests/issues/2823
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2823/labels{/name}
https://api.github.com/repos/psf/requests/issues/2823/comments
https://api.github.com/repos/psf/requests/issues/2823/events
https://github.com/psf/requests/issues/2823
111,011,545
MDU6SXNzdWUxMTEwMTE1NDU=
2,823
Please create v2.8.0 tag
{ "avatar_url": "https://avatars.githubusercontent.com/u/229453?v=4", "events_url": "https://api.github.com/users/Natim/events{/privacy}", "followers_url": "https://api.github.com/users/Natim/followers", "following_url": "https://api.github.com/users/Natim/following{/other_user}", "gists_url": "https://api.github.com/users/Natim/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Natim", "id": 229453, "login": "Natim", "node_id": "MDQ6VXNlcjIyOTQ1Mw==", "organizations_url": "https://api.github.com/users/Natim/orgs", "received_events_url": "https://api.github.com/users/Natim/received_events", "repos_url": "https://api.github.com/users/Natim/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Natim/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Natim/subscriptions", "type": "User", "url": "https://api.github.com/users/Natim", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2015-10-12T16:36:01Z
2021-09-08T22:00:41Z
2015-10-12T17:08:44Z
NONE
resolved
Tag v2.8.0 seems missing: e499b354c4215b158db6d4210136e0b9adbe8d14
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2823/reactions" }
https://api.github.com/repos/psf/requests/issues/2823/timeline
null
completed
null
null
false
[ "Sorry, pushed it up now. =)\n", "Thanks\nLe 12 oct. 2015 19:09, \"Cory Benfield\" notifications@github.com a écrit :\n\n> Sorry, pushed it up now. =)\n> \n> —\n> Reply to this email directly or view it on GitHub\n> https://github.com/kennethreitz/requests/issues/2823#issuecomment-147463056\n> .\n" ]
https://api.github.com/repos/psf/requests/issues/2822
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2822/labels{/name}
https://api.github.com/repos/psf/requests/issues/2822/comments
https://api.github.com/repos/psf/requests/issues/2822/events
https://github.com/psf/requests/issues/2822
110,997,302
MDU6SXNzdWUxMTA5OTczMDI=
2,822
requests doesn't prepare the request before passing it to the Auth backend.
{ "avatar_url": "https://avatars.githubusercontent.com/u/229453?v=4", "events_url": "https://api.github.com/users/Natim/events{/privacy}", "followers_url": "https://api.github.com/users/Natim/followers", "following_url": "https://api.github.com/users/Natim/following{/other_user}", "gists_url": "https://api.github.com/users/Natim/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Natim", "id": 229453, "login": "Natim", "node_id": "MDQ6VXNlcjIyOTQ1Mw==", "organizations_url": "https://api.github.com/users/Natim/orgs", "received_events_url": "https://api.github.com/users/Natim/received_events", "repos_url": "https://api.github.com/users/Natim/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Natim/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Natim/subscriptions", "type": "User", "url": "https://api.github.com/users/Natim", "user_view_type": "public" }
[]
closed
true
null
[]
null
9
2015-10-12T15:21:38Z
2021-09-08T22:00:42Z
2015-10-12T16:16:02Z
NONE
resolved
I know you will answer that this is a feature, but I am really stuck with https://github.com/mozilla-services/requests-hawk/pull/7/files My Auth backend create a signature for the body, and I cannot read the body from the `Request()` object. Also it doesn't work with the json parameter. I am not sure of the strategy I should adopt. Any thoughs? ``` python # Auth backend call method. def __call__(self, r): if self.host is not None: r.headers['Host'] = self.host content_type = r.headers.get('Content-Type', '') body = '' if r.data: body = r.data elif r.json: body = json.dumps(r.json) content_type = 'application/json' sender = mohawk.Sender( self.credentials, r.url, r.method, content=body, content_type=content_type, _timestamp=self._timestamp ) r.headers['Authorization'] = sender.request_header return r ```
{ "avatar_url": "https://avatars.githubusercontent.com/u/229453?v=4", "events_url": "https://api.github.com/users/Natim/events{/privacy}", "followers_url": "https://api.github.com/users/Natim/followers", "following_url": "https://api.github.com/users/Natim/following{/other_user}", "gists_url": "https://api.github.com/users/Natim/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Natim", "id": 229453, "login": "Natim", "node_id": "MDQ6VXNlcjIyOTQ1Mw==", "organizations_url": "https://api.github.com/users/Natim/orgs", "received_events_url": "https://api.github.com/users/Natim/received_events", "repos_url": "https://api.github.com/users/Natim/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Natim/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Natim/subscriptions", "type": "User", "url": "https://api.github.com/users/Natim", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2822/reactions" }
https://api.github.com/repos/psf/requests/issues/2822/timeline
null
completed
null
null
false
[ "I have no clue how you're using the auth plugin, but it only works with `PreparedRequests`. It has never worked with `Request` objects. It's called by [`PreparedRequest.prepare_auth`](https://github.com/kennethreitz/requests/blob/14a555ac716866678bf17e43e23230d81a8149f5/requests/models.py#L473).\n", "If it works...
https://api.github.com/repos/psf/requests/issues/2821
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2821/labels{/name}
https://api.github.com/repos/psf/requests/issues/2821/comments
https://api.github.com/repos/psf/requests/issues/2821/events
https://github.com/psf/requests/pull/2821
110,943,374
MDExOlB1bGxSZXF1ZXN0NDc0MDE0MjA=
2,821
Allow non-native-string method names.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
[]
closed
true
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
[ { "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}...
null
4
2015-10-12T09:49:35Z
2021-09-08T06:00:53Z
2015-10-12T14:50:53Z
MEMBER
resolved
Resolves #2818.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2821/reactions" }
https://api.github.com/repos/psf/requests/issues/2821/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2821.diff", "html_url": "https://github.com/psf/requests/pull/2821", "merged_at": "2015-10-12T14:50:53Z", "patch_url": "https://github.com/psf/requests/pull/2821.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2821" }
true
[ "I'm starting with just the failing test to confirm that our environment can actually reproduce it.\n", "@sigmavirus24 I'd like to slip this into 2.8.1, which I plan to release tomorrow. Mind doing a quick review before then?\n", "I feel certain that we've fixed this already, perhaps in 3.0.0?\n\nAnd a quick lo...
https://api.github.com/repos/psf/requests/issues/2820
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2820/labels{/name}
https://api.github.com/repos/psf/requests/issues/2820/comments
https://api.github.com/repos/psf/requests/issues/2820/events
https://github.com/psf/requests/issues/2820
110,910,683
MDU6SXNzdWUxMTA5MTA2ODM=
2,820
TypeError: unsupported operand type(s) for *: 'NoneType' and 'int'
{ "avatar_url": "https://avatars.githubusercontent.com/u/14935567?v=4", "events_url": "https://api.github.com/users/zajalo/events{/privacy}", "followers_url": "https://api.github.com/users/zajalo/followers", "following_url": "https://api.github.com/users/zajalo/following{/other_user}", "gists_url": "https://api.github.com/users/zajalo/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/zajalo", "id": 14935567, "login": "zajalo", "node_id": "MDQ6VXNlcjE0OTM1NTY3", "organizations_url": "https://api.github.com/users/zajalo/orgs", "received_events_url": "https://api.github.com/users/zajalo/received_events", "repos_url": "https://api.github.com/users/zajalo/repos", "site_admin": false, "starred_url": "https://api.github.com/users/zajalo/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zajalo/subscriptions", "type": "User", "url": "https://api.github.com/users/zajalo", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2015-10-12T05:25:25Z
2021-09-08T22:00:42Z
2015-10-12T08:05:45Z
NONE
resolved
I've been getting this error randomly while using [RoboBrowser](https://github.com/jmcarp/robobrowser). RoboBrowser installs with requests 2.7.0 but I checked line 166 of current version (2.8) of retry.py and it's the same. I should add that I made a small modification to a file in RoboBrowser as described here: https://github.com/jmcarp/robobrowser/issues/52#issuecomment-144929550 ``` Traceback (most recent call last): File "fetch.py", line 139, in <module> go() File "fetch.py", line 120, in go result = fetch(url) File "fetch.py", line 29, in fetch browser.open(url) File "C:\Users\Vidpe\Desktop\mpb\venv\lib\site-packages\robobrowser\browser.py", line 205, in open response = self.session.request(method, url, **self._build_send_args(**kwargs)) File "C:\Users\Vidpe\Desktop\mpb\venv\lib\site-packages\requests\sessions.py", line 465, in request resp = self.send(prep, **send_kwargs) File "C:\Users\Vidpe\Desktop\mpb\venv\lib\site-packages\requests\sessions.py", line 573, in send r = adapter.send(request, **kwargs) File "C:\Users\Vidpe\Desktop\mpb\venv\lib\site-packages\requests\adapters.py", line 370, in send timeout=timeout File "C:\Users\Vidpe\Desktop\mpb\venv\lib\site-packages\requests\packages\urllib3\connectionpool.py", line 617, in urlopen release_conn=release_conn, **response_kw) File "C:\Users\Vidpe\Desktop\mpb\venv\lib\site-packages\requests\packages\urllib3\connectionpool.py", line 598, in urlopen retries.sleep() File "C:\Users\Vidpe\Desktop\mpb\venv\lib\site-packages\requests\packages\urllib3\util\retry.py", line 175, in sleep backoff = self.get_backoff_time() File "C:\Users\Vidpe\Desktop\mpb\venv\lib\site-packages\requests\packages\urllib3\util\retry.py", line 166, in get_backoff_time backoff_value = self.backoff_factor * (2 ** (self._observed_errors - 1)) TypeError: unsupported operand type(s) for *: 'NoneType' and 'int' ```
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2820/reactions" }
https://api.github.com/repos/psf/requests/issues/2820/timeline
null
completed
null
null
false
[ "So a quick code read suggests that this is _impossible_ using standard requests. The `backoff_factor` attribute is defaulted to `0` and never assigned to `None` by any code in requests, as far as I can see.\n\nHowever, a quick search of RoboBrowser reveals that _it_ sets the `backoff_factor`, [here](https://github...
https://api.github.com/repos/psf/requests/issues/2819
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2819/labels{/name}
https://api.github.com/repos/psf/requests/issues/2819/comments
https://api.github.com/repos/psf/requests/issues/2819/events
https://github.com/psf/requests/issues/2819
110,859,702
MDU6SXNzdWUxMTA4NTk3MDI=
2,819
Problem with `json` parameter in POST for requests 2.8.0
{ "avatar_url": "https://avatars.githubusercontent.com/u/3287067?v=4", "events_url": "https://api.github.com/users/asieira/events{/privacy}", "followers_url": "https://api.github.com/users/asieira/followers", "following_url": "https://api.github.com/users/asieira/following{/other_user}", "gists_url": "https://api.github.com/users/asieira/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/asieira", "id": 3287067, "login": "asieira", "node_id": "MDQ6VXNlcjMyODcwNjc=", "organizations_url": "https://api.github.com/users/asieira/orgs", "received_events_url": "https://api.github.com/users/asieira/received_events", "repos_url": "https://api.github.com/users/asieira/repos", "site_admin": false, "starred_url": "https://api.github.com/users/asieira/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/asieira/subscriptions", "type": "User", "url": "https://api.github.com/users/asieira", "user_view_type": "public" }
[]
closed
true
null
[]
null
3
2015-10-11T14:31:02Z
2021-09-05T00:06:49Z
2015-10-11T14:32:28Z
CONTRIBUTOR
resolved
The following code works in requests 2.7.0 but raises an assertion error in 2.8.0: ``` import requests session = requests.session() session.headers.update({'x-api-key': 'blah', "Accept-Encoding": "gzip, deflate", "User-Agent": "magnet-sdk-python"}) session.verify = True req = requests.Request(method='POST', url='https://portal.niddel.com/api/v1-beta/alerts', params=None, json={'a': 1, 'b': 2}) req = session.prepare_request(req) assert req.body ``` Since I provided neither `files` nor `body`, I would have expected `json` to work. In case you need this info to reproduce the issue, all tests were performed on a Mac OS X with Python 2.7.10 (installed using homebrew).
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2819/reactions" }
https://api.github.com/repos/psf/requests/issues/2819/timeline
null
completed
null
null
false
[ "@asieira Thanks for this! This is a duplicate of #2813, and should be resolved in 2.8.1.\n", ":+1:\n", "Bom dia Pessoal, estou com o um projeto na empresa onde devo se comunicar com o serviço do governo e estou patinando para se autenticar no mesmo onde pede para enviar o certificado encapsulado em uma keystor...
https://api.github.com/repos/psf/requests/issues/2818
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2818/labels{/name}
https://api.github.com/repos/psf/requests/issues/2818/comments
https://api.github.com/repos/psf/requests/issues/2818/events
https://github.com/psf/requests/issues/2818
110,825,868
MDU6SXNzdWUxMTA4MjU4Njg=
2,818
TypeError after 2.7.0 -> 2.8.0 upgrade (cannot make memory view...)
{ "avatar_url": "https://avatars.githubusercontent.com/u/950506?v=4", "events_url": "https://api.github.com/users/simon-weber/events{/privacy}", "followers_url": "https://api.github.com/users/simon-weber/followers", "following_url": "https://api.github.com/users/simon-weber/following{/other_user}", "gists_url": "https://api.github.com/users/simon-weber/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/simon-weber", "id": 950506, "login": "simon-weber", "node_id": "MDQ6VXNlcjk1MDUwNg==", "organizations_url": "https://api.github.com/users/simon-weber/orgs", "received_events_url": "https://api.github.com/users/simon-weber/received_events", "repos_url": "https://api.github.com/users/simon-weber/repos", "site_admin": false, "starred_url": "https://api.github.com/users/simon-weber/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/simon-weber/subscriptions", "type": "User", "url": "https://api.github.com/users/simon-weber", "user_view_type": "public" }
[]
closed
true
null
[]
null
27
2015-10-11T00:33:59Z
2021-09-08T20:01:02Z
2015-10-12T14:50:53Z
NONE
resolved
I'm running into this traceback after upgrading to 2.8.0 from 2.7.0: ``` <snip> response = self.session.send(request) File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/requests/sessions.py", line 579, in send r = adapter.send(request, **kwargs) File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/requests/adapters.py", line 369, in send timeout=timeout File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py", line 559, in urlopen body=body, headers=headers) File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py", line 353, in _make_request conn.request(method, url, **httplib_request_kw) File "/opt/python/2.7.9/lib/python2.7/httplib.py", line 1001, in request self._send_request(method, url, body, headers) File "/opt/python/2.7.9/lib/python2.7/httplib.py", line 1035, in _send_request self.endheaders(body) File "/opt/python/2.7.9/lib/python2.7/httplib.py", line 997, in endheaders self._send_output(message_body) File "/opt/python/2.7.9/lib/python2.7/httplib.py", line 850, in _send_output self.send(msg) File "/opt/python/2.7.9/lib/python2.7/httplib.py", line 826, in send self.sock.sendall(data) File "/home/travis/virtualenv/python2.7.9/lib/python2.7/site-packages/requests/packages/urllib3/contrib/pyopenssl.py", line 216, in sendall data = memoryview(data) TypeError: cannot make memory view because object does not have the buffer interface ``` The problem goes away after downgrading to 2.7.0. A full traceback can be found [here](https://travis-ci.org/simon-weber/gmusicapi/jobs/82365307). Here are the versions of relevant packages: ``` httplib2-0.9.2 ndg-httpsclient-0.4.0 pyasn1-0.1.9 pyasn1-modules-0.0.8 pyopenssl-0.15.1 requests-2.8.0 ``` And a full list of packages: ``` MechanicalSoup-0.3.1 appdirs-1.4.0 beautifulsoup4-4.4.1 cffi-1.2.1 cryptography-1.0.2 decorator-4.0.4 enum34-1.0.4 gmusicapi-7.0.1.dev0 gpsoauth-0.0.4 httplib2-0.9.2 idna-2.0 ipaddress-1.0.14 mutagen-1.31 ndg-httpsclient-0.4.0 oauth2client-1.5.1 proboscis-1.2.6.0 protobuf-2.6.1 pyasn1-0.1.9 pyasn1-modules-0.0.8 pycparser-2.14 pycrypto-2.6.1 pyopenssl-0.15.1 python-dateutil-2.4.2 requests-2.8.0 rsa-3.2 six-1.10.0 validictory-1.0.1 ``` Any ideas?
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2818/reactions" }
https://api.github.com/repos/psf/requests/issues/2818/timeline
null
completed
null
null
false
[ "Can I see a bit of sample code? I suspect you're passing a Unicode string somewhere. \n", "Good call. To reproduce this, you need both a unicode method and an https url, eg\n\n```\npython -c 'import requests; s = requests.Session(); r = requests.Request(u\"POST\", \"https://httpbin.org/post\"); pr = s.prepare_re...
https://api.github.com/repos/psf/requests/issues/2817
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2817/labels{/name}
https://api.github.com/repos/psf/requests/issues/2817/comments
https://api.github.com/repos/psf/requests/issues/2817/events
https://github.com/psf/requests/issues/2817
110,692,438
MDU6SXNzdWUxMTA2OTI0Mzg=
2,817
RFE: Be able to pass 'no_proxy' in proxies dictionary argument
{ "avatar_url": "https://avatars.githubusercontent.com/u/578155?v=4", "events_url": "https://api.github.com/users/JohnVillalovos/events{/privacy}", "followers_url": "https://api.github.com/users/JohnVillalovos/followers", "following_url": "https://api.github.com/users/JohnVillalovos/following{/other_user}", "gists_url": "https://api.github.com/users/JohnVillalovos/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/JohnVillalovos", "id": 578155, "login": "JohnVillalovos", "node_id": "MDQ6VXNlcjU3ODE1NQ==", "organizations_url": "https://api.github.com/users/JohnVillalovos/orgs", "received_events_url": "https://api.github.com/users/JohnVillalovos/received_events", "repos_url": "https://api.github.com/users/JohnVillalovos/repos", "site_admin": false, "starred_url": "https://api.github.com/users/JohnVillalovos/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JohnVillalovos/subscriptions", "type": "User", "url": "https://api.github.com/users/JohnVillalovos", "user_view_type": "public" }
[ { "color": "02e10c", "default": false, "description": null, "id": 76800, "name": "Feature Request", "node_id": "MDU6TGFiZWw3NjgwMA==", "url": "https://api.github.com/repos/psf/requests/labels/Feature%20Request" }, { "color": "e102d8", "default": false, "description": null...
closed
true
null
[]
null
23
2015-10-09T16:23:16Z
2021-09-08T12:00:59Z
2017-02-10T21:50:11Z
CONTRIBUTOR
resolved
It would be good if were able to pass the 'no_proxy' value in the proxies dictionary argument. Currently it appears have to set the environment variable 'no_proxy'. For example: ``` proxies = {'https_proxy': 'http://proxy.example.com:3128', 'no_proxy': '10.0.0.0/16,example.com,.example.com'} requests.get('http://www.example.com', proxies=proxies) ```
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2817/reactions" }
https://api.github.com/repos/psf/requests/issues/2817/timeline
null
completed
null
null
false
[ "This is reasonable request, but the use-case seems small, especially as we now support per-host proxies. The only risk is that you might get redirected off-host, to a host that you don't want to reach via a proxy, but in most cases I'd expect that to be relatively unlikely and covered by the per-host proxies funct...
https://api.github.com/repos/psf/requests/issues/2816
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2816/labels{/name}
https://api.github.com/repos/psf/requests/issues/2816/comments
https://api.github.com/repos/psf/requests/issues/2816/events
https://github.com/psf/requests/issues/2816
110,673,988
MDU6SXNzdWUxMTA2NzM5ODg=
2,816
Downstream unbundlers should populate setup.py
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
[]
closed
true
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
[ { "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url...
null
21
2015-10-09T14:48:30Z
2021-09-08T21:00:48Z
2015-11-05T10:00:58Z
MEMBER
resolved
/cc @ralphbean @eriol OpenStack has encountered yet another breakage caused by people combining `pip` installed and system packages: specifically, updating urllib3 via `pip` when requests/urllib3 are already installed via the system packages. @dstufft tells me that, if the system packages correctly populate the `install_requires` part of `setup.py`, `pip` would respect those requirements. Previously this wasn't possible because requests would include mid-release versions of urllib3, but as of v2.6.2 our [new release rules](http://docs.python-requests.org/en/latest/community/release-process/) mean that we only use proper urllib3 releases. For this reason, I think it would be extremely good if downstream unbundlers (most notably Fedora and Debian), when they unbundle requests, would populate setup.py with the correct `install_requires`. For 2.8.0, that would be `urllib3==1.12`. For 2.7.0, that would be `urllib3==1.10.4`. This should ensure that `pip` won't casually install a version of urllib3 that will break the system requests package. Thoughts?
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2816/reactions" }
https://api.github.com/repos/psf/requests/issues/2816/timeline
null
completed
null
null
false
[ "I think we can do that. I'll have to think about the implications but this is a great improvement. Right now Debian has requests 2.7.0 and urllib3 1.11 so they should be updated.\n", "> Right now Debian has requests 2.7.0 and urllib3 1.11 so they should be updated.\n\nI've heard of issues with 2.7.0 and 1.11....
https://api.github.com/repos/psf/requests/issues/2815
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2815/labels{/name}
https://api.github.com/repos/psf/requests/issues/2815/comments
https://api.github.com/repos/psf/requests/issues/2815/events
https://github.com/psf/requests/issues/2815
110,671,499
MDU6SXNzdWUxMTA2NzE0OTk=
2,815
Python 3.5 install requests failed
{ "avatar_url": "https://avatars.githubusercontent.com/u/3759816?v=4", "events_url": "https://api.github.com/users/gengjiawen/events{/privacy}", "followers_url": "https://api.github.com/users/gengjiawen/followers", "following_url": "https://api.github.com/users/gengjiawen/following{/other_user}", "gists_url": "https://api.github.com/users/gengjiawen/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/gengjiawen", "id": 3759816, "login": "gengjiawen", "node_id": "MDQ6VXNlcjM3NTk4MTY=", "organizations_url": "https://api.github.com/users/gengjiawen/orgs", "received_events_url": "https://api.github.com/users/gengjiawen/received_events", "repos_url": "https://api.github.com/users/gengjiawen/repos", "site_admin": false, "starred_url": "https://api.github.com/users/gengjiawen/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gengjiawen/subscriptions", "type": "User", "url": "https://api.github.com/users/gengjiawen", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2015-10-09T14:34:25Z
2021-09-08T22:00:43Z
2015-10-09T14:41:38Z
NONE
resolved
``` C:\Users\gengjiawen>pip install --no-cache requests Collecting requests Downloading requests-2.8.0-py2.py3-none-any.whl (476kB) 100% |████████████████████████████████| 479kB 122kB/s Installing collected packages: requests Exception: Traceback (most recent call last): File "c:\program files\python\lib\site-packages\pip\basecommand.py", line 211, in main status = self.run(options, args) File "c:\program files\python\lib\site-packages\pip\commands\install.py", line 311, in run root=options.root_path, File "c:\program files\python\lib\site-packages\pip\req\req_set.py", line 646, in install **kwargs File "c:\program files\python\lib\site-packages\pip\req\req_install.py", line 803, in install self.move_wheel_files(self.source_dir, root=root) File "c:\program files\python\lib\site-packages\pip\req\req_install.py", line 998, in move_wheel_files isolated=self.isolated, File "c:\program files\python\lib\site-packages\pip\wheel.py", line 339, in move_wheel_files clobber(source, lib_dir, True) File "c:\program files\python\lib\site-packages\pip\wheel.py", line 310, in clobber ensure_dir(destdir) File "c:\program files\python\lib\site-packages\pip\utils\__init__.py", line 71, in ensure_dir os.makedirs(path) File "c:\program files\python\lib\os.py", line 241, in makedirs mkdir(name, mode) PermissionError: [WinError 5] Access is denied: 'c:\\program files\\python\\Lib\\site-packages\\requests' ``` I am on win10(64bit), python 3.5.0. Python 3.4 has not this problem. Run the terminal as Admin will fix this.
{ "avatar_url": "https://avatars.githubusercontent.com/u/3759816?v=4", "events_url": "https://api.github.com/users/gengjiawen/events{/privacy}", "followers_url": "https://api.github.com/users/gengjiawen/followers", "following_url": "https://api.github.com/users/gengjiawen/following{/other_user}", "gists_url": "https://api.github.com/users/gengjiawen/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/gengjiawen", "id": 3759816, "login": "gengjiawen", "node_id": "MDQ6VXNlcjM3NTk4MTY=", "organizations_url": "https://api.github.com/users/gengjiawen/orgs", "received_events_url": "https://api.github.com/users/gengjiawen/received_events", "repos_url": "https://api.github.com/users/gengjiawen/repos", "site_admin": false, "starred_url": "https://api.github.com/users/gengjiawen/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gengjiawen/subscriptions", "type": "User", "url": "https://api.github.com/users/gengjiawen", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2815/reactions" }
https://api.github.com/repos/psf/requests/issues/2815/timeline
null
completed
null
null
false
[ "I believe this is a problem with your installation, not with requests. Do you encounter this problem with other packages? E.g., try running `pip install --no-cache hyperframe`.\n", "@Lukasa yes, you are right,this is may be a issue of python 3.5,I will close this issue:)\n" ]
https://api.github.com/repos/psf/requests/issues/2814
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2814/labels{/name}
https://api.github.com/repos/psf/requests/issues/2814/comments
https://api.github.com/repos/psf/requests/issues/2814/events
https://github.com/psf/requests/pull/2814
110,456,412
MDExOlB1bGxSZXF1ZXN0NDcxNTUxNzU=
2,814
Use general null check for JSON
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
[]
closed
true
null
[]
null
4
2015-10-08T13:54:23Z
2021-09-08T06:00:54Z
2015-10-08T15:13:08Z
MEMBER
resolved
Resolves #2813.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2814/reactions" }
https://api.github.com/repos/psf/requests/issues/2814/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2814.diff", "html_url": "https://github.com/psf/requests/pull/2814", "merged_at": "2015-10-08T15:13:08Z", "patch_url": "https://github.com/psf/requests/pull/2814.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2814" }
true
[ "I think we're going to start needing some tests that our set of data-y parameters interact correctly together when using different parts of the API.\n", "Or we need to stop duplicating logic everywhere that will break logic in different places.\n", "Or both?\n", "Yes. I commented in the wrong place. I greatl...
https://api.github.com/repos/psf/requests/issues/2813
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2813/labels{/name}
https://api.github.com/repos/psf/requests/issues/2813/comments
https://api.github.com/repos/psf/requests/issues/2813/events
https://github.com/psf/requests/issues/2813
110,454,512
MDU6SXNzdWUxMTA0NTQ1MTI=
2,813
Requests json argument is ignored in 2.8.0
{ "avatar_url": "https://avatars.githubusercontent.com/u/422264?v=4", "events_url": "https://api.github.com/users/vasiliy-bout/events{/privacy}", "followers_url": "https://api.github.com/users/vasiliy-bout/followers", "following_url": "https://api.github.com/users/vasiliy-bout/following{/other_user}", "gists_url": "https://api.github.com/users/vasiliy-bout/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/vasiliy-bout", "id": 422264, "login": "vasiliy-bout", "node_id": "MDQ6VXNlcjQyMjI2NA==", "organizations_url": "https://api.github.com/users/vasiliy-bout/orgs", "received_events_url": "https://api.github.com/users/vasiliy-bout/received_events", "repos_url": "https://api.github.com/users/vasiliy-bout/repos", "site_admin": false, "starred_url": "https://api.github.com/users/vasiliy-bout/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/vasiliy-bout/subscriptions", "type": "User", "url": "https://api.github.com/users/vasiliy-bout", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2015-10-08T13:45:16Z
2021-09-08T22:00:44Z
2015-10-08T15:13:08Z
NONE
resolved
In version `2.7.0` I was using `Requests` constructor with `json` parameter specified, like: ``` json_data = [ ... ]; r = requests.Request('POST', url, json=json_data) ``` And in the `2.8.0` version this code does not work, because I do not specify `data` parameter. Inside constructor we get `self.data` assigned as `[] if data is None else data`, so we finally get `self.data` equal to `[]`. And because of this commit: 7a0cd16c1a5be16f3df395ee12ed11d0ddde7837 we get `json` parameter ignored, because now we have to explicitly specify `data={}` when calling constructor, like: ``` json_data = [ ... ]; r = requests.Request('POST', url, json=json_data, data={}) ``` I think that this issue definitely breaks documented API.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2813/reactions" }
https://api.github.com/repos/psf/requests/issues/2813/timeline
null
completed
null
null
false
[ "Ah, yeah, that definitely happened. Sorry. =(\n\nThis was introduced in #2763. Looks like we need a slightly more subtle check than the one we introduced.\n", "See #2814 for a proposed fix.\n" ]
https://api.github.com/repos/psf/requests/issues/2812
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2812/labels{/name}
https://api.github.com/repos/psf/requests/issues/2812/comments
https://api.github.com/repos/psf/requests/issues/2812/events
https://github.com/psf/requests/pull/2812
110,446,257
MDExOlB1bGxSZXF1ZXN0NDcxNDk4MTA=
2,812
Don't treat NewConnectionErrors as timeouts.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
[]
closed
true
null
[]
null
3
2015-10-08T13:06:53Z
2021-09-01T00:11:45Z
2015-10-08T13:10:01Z
MEMBER
resolved
Resolves #2811. Fundamentally I view this mostly as a compatibility change, to get us back into line with how we've processed this kind of error in the 2.X series. I think I'd like to back it out in 3.0.0, which is why I've left a note in the code to that effect.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2812/reactions" }
https://api.github.com/repos/psf/requests/issues/2812/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2812.diff", "html_url": "https://github.com/psf/requests/pull/2812", "merged_at": "2015-10-08T13:10:01Z", "patch_url": "https://github.com/psf/requests/pull/2812.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2812" }
true
[ "@sigmavirus24 How do you feel about removing this in 3.0.0?\n", "+0\n", "@Lukasa I've found a TODO made by you and associated with this issue https://github.com/requests/requests/blob/3.0/requests/adapters.py#L531" ]
https://api.github.com/repos/psf/requests/issues/2811
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2811/labels{/name}
https://api.github.com/repos/psf/requests/issues/2811/comments
https://api.github.com/repos/psf/requests/issues/2811/events
https://github.com/psf/requests/issues/2811
110,441,115
MDU6SXNzdWUxMTA0NDExMTU=
2,811
2.8.0 release raise ConnectTimeout on not known url
{ "avatar_url": "https://avatars.githubusercontent.com/u/9213840?v=4", "events_url": "https://api.github.com/users/aarefiev22/events{/privacy}", "followers_url": "https://api.github.com/users/aarefiev22/followers", "following_url": "https://api.github.com/users/aarefiev22/following{/other_user}", "gists_url": "https://api.github.com/users/aarefiev22/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/aarefiev22", "id": 9213840, "login": "aarefiev22", "node_id": "MDQ6VXNlcjkyMTM4NDA=", "organizations_url": "https://api.github.com/users/aarefiev22/orgs", "received_events_url": "https://api.github.com/users/aarefiev22/received_events", "repos_url": "https://api.github.com/users/aarefiev22/repos", "site_admin": false, "starred_url": "https://api.github.com/users/aarefiev22/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/aarefiev22/subscriptions", "type": "User", "url": "https://api.github.com/users/aarefiev22", "user_view_type": "public" }
[]
closed
true
null
[]
null
11
2015-10-08T12:47:34Z
2021-09-08T22:00:43Z
2015-10-08T13:10:01Z
NONE
resolved
2.7.0 and 2.8.0 raises diff exception on not known url: import requests requests.get('http://fake') 2.8.0: requests.exceptions.ConnectTimeout: HTTPConnectionPool(host='fake', port=80): Max retries exceeded with url: / (Caused by NewConnectionError('<requests.packages.urllib3.connection.HTTPConnection object at 0x7fac9c476110>: Failed to establish a new connection: [Errno -2] Name or service not known',)) 2.7.0 requests.exceptions.ConnectionError: ('Connection aborted.', gaierror(-2, 'Name or service not known'))
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2811/reactions" }
https://api.github.com/repos/psf/requests/issues/2811/timeline
null
completed
null
null
false
[ "Hmm, looks like urllib3 changed how it wrapped this exception. Let me see if I can find where this problem got introduced.\n", "I suspect shazow/urllib3#703 may have introduced a new exception type that urllib3 treats differently to `socket.error`.\n", "@Lukasa if the OpenStack gate is indicative of anything, ...
https://api.github.com/repos/psf/requests/issues/2810
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2810/labels{/name}
https://api.github.com/repos/psf/requests/issues/2810/comments
https://api.github.com/repos/psf/requests/issues/2810/events
https://github.com/psf/requests/pull/2810
110,386,904
MDExOlB1bGxSZXF1ZXN0NDcxMTg1MDU=
2,810
Update requests certificate bundle.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
[]
closed
true
null
[]
null
0
2015-10-08T07:12:37Z
2021-09-08T06:00:53Z
2015-10-08T16:12:09Z
MEMBER
resolved
This brings it up-to-date with the certifi 2015.9.6.2 release, specifically the `weak.pem` bundle that still contains the 1024-bit root certificates. This is really as aggressive as I'm happy to be with requests at this time. Resolves #2809.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2810/reactions" }
https://api.github.com/repos/psf/requests/issues/2810/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2810.diff", "html_url": "https://github.com/psf/requests/pull/2810", "merged_at": "2015-10-08T16:12:09Z", "patch_url": "https://github.com/psf/requests/pull/2810.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2810" }
true
[]
https://api.github.com/repos/psf/requests/issues/2809
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2809/labels{/name}
https://api.github.com/repos/psf/requests/issues/2809/comments
https://api.github.com/repos/psf/requests/issues/2809/events
https://github.com/psf/requests/issues/2809
110,323,983
MDU6SXNzdWUxMTAzMjM5ODM=
2,809
Cert present in certifi but not in requests
{ "avatar_url": "https://avatars.githubusercontent.com/u/2438391?v=4", "events_url": "https://api.github.com/users/hombremuchacho/events{/privacy}", "followers_url": "https://api.github.com/users/hombremuchacho/followers", "following_url": "https://api.github.com/users/hombremuchacho/following{/other_user}", "gists_url": "https://api.github.com/users/hombremuchacho/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/hombremuchacho", "id": 2438391, "login": "hombremuchacho", "node_id": "MDQ6VXNlcjI0MzgzOTE=", "organizations_url": "https://api.github.com/users/hombremuchacho/orgs", "received_events_url": "https://api.github.com/users/hombremuchacho/received_events", "repos_url": "https://api.github.com/users/hombremuchacho/repos", "site_admin": false, "starred_url": "https://api.github.com/users/hombremuchacho/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hombremuchacho/subscriptions", "type": "User", "url": "https://api.github.com/users/hombremuchacho", "user_view_type": "public" }
[]
closed
true
null
[]
null
3
2015-10-07T21:40:16Z
2021-09-08T22:00:43Z
2015-10-08T16:12:09Z
NONE
resolved
https://github.com/certifi/python-certifi/blob/master/certifi/cacert.pem#L5026 Can the Entrust G2 certificate be added to the requests certificate store?
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2809/reactions" }
https://api.github.com/repos/psf/requests/issues/2809/timeline
null
completed
null
null
false
[ "I think the core issue here is that requests' certificate store is somewhat out of date. I propose we ship a 2.8.1 containing a cert store update, specifically the `weak.pem` bundle that ships with certifi.\n\n@hombremuchacho Someone I presume was your colleague or another team member (@aehlke) suggested that cert...
https://api.github.com/repos/psf/requests/issues/2808
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2808/labels{/name}
https://api.github.com/repos/psf/requests/issues/2808/comments
https://api.github.com/repos/psf/requests/issues/2808/events
https://github.com/psf/requests/pull/2808
110,316,211
MDExOlB1bGxSZXF1ZXN0NDcwODE3OTM=
2,808
Adding Entrust G2 CA Cert
{ "avatar_url": "https://avatars.githubusercontent.com/u/2438391?v=4", "events_url": "https://api.github.com/users/hombremuchacho/events{/privacy}", "followers_url": "https://api.github.com/users/hombremuchacho/followers", "following_url": "https://api.github.com/users/hombremuchacho/following{/other_user}", "gists_url": "https://api.github.com/users/hombremuchacho/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/hombremuchacho", "id": 2438391, "login": "hombremuchacho", "node_id": "MDQ6VXNlcjI0MzgzOTE=", "organizations_url": "https://api.github.com/users/hombremuchacho/orgs", "received_events_url": "https://api.github.com/users/hombremuchacho/received_events", "repos_url": "https://api.github.com/users/hombremuchacho/repos", "site_admin": false, "starred_url": "https://api.github.com/users/hombremuchacho/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hombremuchacho/subscriptions", "type": "User", "url": "https://api.github.com/users/hombremuchacho", "user_view_type": "public" }
[]
closed
true
null
[]
null
4
2015-10-07T21:03:37Z
2021-09-08T06:00:54Z
2015-10-07T21:16:00Z
NONE
resolved
Adding Entrust G2 CA Cert to cacerts.pem
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2808/reactions" }
https://api.github.com/repos/psf/requests/issues/2808/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2808.diff", "html_url": "https://github.com/psf/requests/pull/2808", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/2808.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2808" }
true
[ "I could be mistaken but I'm rather certain that we don't accept additions to the certificate bundle directly. They have to go through [certifi](/certifi/python-certifi) first. @Lukasa am I right?\n", "We do not accept changes to the cert bundle in requests in this manner: certainly not one certificate at a time....
https://api.github.com/repos/psf/requests/issues/2807
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2807/labels{/name}
https://api.github.com/repos/psf/requests/issues/2807/comments
https://api.github.com/repos/psf/requests/issues/2807/events
https://github.com/psf/requests/issues/2807
110,258,668
MDU6SXNzdWUxMTAyNTg2Njg=
2,807
HTTP Proxy with prepared request (honouring env. var.)
{ "avatar_url": "https://avatars.githubusercontent.com/u/2509872?v=4", "events_url": "https://api.github.com/users/mxjeff/events{/privacy}", "followers_url": "https://api.github.com/users/mxjeff/followers", "following_url": "https://api.github.com/users/mxjeff/following{/other_user}", "gists_url": "https://api.github.com/users/mxjeff/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/mxjeff", "id": 2509872, "login": "mxjeff", "node_id": "MDQ6VXNlcjI1MDk4NzI=", "organizations_url": "https://api.github.com/users/mxjeff/orgs", "received_events_url": "https://api.github.com/users/mxjeff/received_events", "repos_url": "https://api.github.com/users/mxjeff/repos", "site_admin": false, "starred_url": "https://api.github.com/users/mxjeff/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mxjeff/subscriptions", "type": "User", "url": "https://api.github.com/users/mxjeff", "user_view_type": "public" }
[]
closed
true
null
[]
null
6
2015-10-07T15:58:44Z
2021-09-08T21:00:51Z
2015-11-05T10:01:18Z
NONE
resolved
Running the following it looks like the proxy env. var. is not honoured: ``` python >>> # requests version 2.2.1 / python 3.4.0 >>> import requests >>> import os >>> os.environ['HTTP_PROXY'] = 'http://some.wrong.dns.example.org' >>> req = requests.Request('GET', 'http://httpbin.org/get') >>> r = req.prepare() >>> s = requests.Session() >>> s.send(r) <Response [200]> ``` Is it the expected behaviour with the lower level interface ? I was actually expecting request to transparently use HTTP_PROXY as it does with the main interface requests.get() or requests.request('GET',...). Cheers
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2807/reactions" }
https://api.github.com/repos/psf/requests/issues/2807/timeline
null
completed
null
null
false
[ "It's certainly the _coded_ behaviour: if you don't use something that goes through `Session.request` then you never get the environment variables.\n\nHowever, I think this is unexpected. It doesn't seem like there's any reason we couldn't move the call to `Session.merge_environment` into `Session.send`, so I'm inc...
https://api.github.com/repos/psf/requests/issues/2806
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2806/labels{/name}
https://api.github.com/repos/psf/requests/issues/2806/comments
https://api.github.com/repos/psf/requests/issues/2806/events
https://github.com/psf/requests/issues/2806
110,161,530
MDU6SXNzdWUxMTAxNjE1MzA=
2,806
read timeouts and iter_lines
{ "avatar_url": "https://avatars.githubusercontent.com/u/521953?v=4", "events_url": "https://api.github.com/users/jkarneges/events{/privacy}", "followers_url": "https://api.github.com/users/jkarneges/followers", "following_url": "https://api.github.com/users/jkarneges/following{/other_user}", "gists_url": "https://api.github.com/users/jkarneges/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/jkarneges", "id": 521953, "login": "jkarneges", "node_id": "MDQ6VXNlcjUyMTk1Mw==", "organizations_url": "https://api.github.com/users/jkarneges/orgs", "received_events_url": "https://api.github.com/users/jkarneges/received_events", "repos_url": "https://api.github.com/users/jkarneges/repos", "site_admin": false, "starred_url": "https://api.github.com/users/jkarneges/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jkarneges/subscriptions", "type": "User", "url": "https://api.github.com/users/jkarneges", "user_view_type": "public" }
[]
closed
true
null
[]
null
5
2015-10-07T06:42:12Z
2021-09-08T21:00:50Z
2015-11-05T10:01:39Z
NONE
resolved
I want to be able to consume an HTTP stream of indefinite length, but I also want a way to cleanly exit the read loop that doesn't involve killing the thread. Here's what I've got: ``` python import threading import socket import requests resp = requests.get('http://some-url/', stream=True, timeout=5) quit = False quit_lock = threading.Lock() it = resp.iter_lines(chunk_size=1) while True: quit_lock.acquire() if quit: quit_lock.release() break quit_lock.release() try: line = next(it) except StopIteration: break except socket.timeout: print('read timed out') it = resp.iter_lines(chunk_size=1) continue print(line) ``` The idea here is that a separate thread can set `quit = True` and this read loop will exit within some seconds. The approach works fine on Python 2 but fails on Python 3. On Python 3, once a read has timed out, a subsequent read will fail with the exception: ``` OSError: cannot read from timed out object ``` Is this a bug in the requests library? Or is it simply a limitation of Python 3? Or is there some other workaround?
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2806/reactions" }
https://api.github.com/repos/psf/requests/issues/2806/timeline
null
completed
null
null
false
[ "This seems to be a limitation of Python 3, introduced in [Issue #7322](https://bugs.python.org/issue7322). The core problem here is that the `read` and `readline` methods of Python socket objects use internal buffers, in order to satisfy the read contract that says that reads should only return less than `amt` if ...
https://api.github.com/repos/psf/requests/issues/2805
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2805/labels{/name}
https://api.github.com/repos/psf/requests/issues/2805/comments
https://api.github.com/repos/psf/requests/issues/2805/events
https://github.com/psf/requests/pull/2805
109,834,518
MDExOlB1bGxSZXF1ZXN0NDY4MDE1NDU=
2,805
allows user paths for ca_cert verify path
{ "avatar_url": "https://avatars.githubusercontent.com/u/1832772?v=4", "events_url": "https://api.github.com/users/a-tal/events{/privacy}", "followers_url": "https://api.github.com/users/a-tal/followers", "following_url": "https://api.github.com/users/a-tal/following{/other_user}", "gists_url": "https://api.github.com/users/a-tal/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/a-tal", "id": 1832772, "login": "a-tal", "node_id": "MDQ6VXNlcjE4MzI3NzI=", "organizations_url": "https://api.github.com/users/a-tal/orgs", "received_events_url": "https://api.github.com/users/a-tal/received_events", "repos_url": "https://api.github.com/users/a-tal/repos", "site_admin": false, "starred_url": "https://api.github.com/users/a-tal/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/a-tal/subscriptions", "type": "User", "url": "https://api.github.com/users/a-tal", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2015-10-05T16:17:32Z
2021-09-08T06:00:55Z
2015-10-05T16:18:36Z
NONE
resolved
currently you get the following error: `SSLError("bad ca_certs: '~/example.crt'", Error([('system library', 'fopen', 'No such file or directory'), ('BIO routines', 'BIO_new_file', 'no such file'), ('x509 certificate routines', 'X509_load_cert_crl_file', 'system lib')],))`
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2805/reactions" }
https://api.github.com/repos/psf/requests/issues/2805/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2805.diff", "html_url": "https://github.com/psf/requests/pull/2805", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/2805.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2805" }
true
[ "Thanks for this! However, this is a change in the [urllib3](https://github.com/shazow/urllib3) library, which we vendor in. Can you please open this pull request over there? Thanks!\n" ]
https://api.github.com/repos/psf/requests/issues/2804
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2804/labels{/name}
https://api.github.com/repos/psf/requests/issues/2804/comments
https://api.github.com/repos/psf/requests/issues/2804/events
https://github.com/psf/requests/pull/2804
109,810,663
MDExOlB1bGxSZXF1ZXN0NDY3ODg3NDY=
2,804
Final 2.8.0
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2015-10-05T14:39:54Z
2021-09-08T06:00:55Z
2015-10-05T16:21:40Z
MEMBER
resolved
This contains the final remaining chunks of work for 2.8.0: updated changelog and updated urllib3. When we merge this we'll be in code-freeze until we release.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2804/reactions" }
https://api.github.com/repos/psf/requests/issues/2804/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2804.diff", "html_url": "https://github.com/psf/requests/pull/2804", "merged_at": "2015-10-05T16:21:40Z", "patch_url": "https://github.com/psf/requests/pull/2804.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2804" }
true
[ "@sigmavirus24 Happy for you to merge this when you think things look good.\n", "LGTM. :+1: :fireworks: \n" ]
https://api.github.com/repos/psf/requests/issues/2803
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2803/labels{/name}
https://api.github.com/repos/psf/requests/issues/2803/comments
https://api.github.com/repos/psf/requests/issues/2803/events
https://github.com/psf/requests/pull/2803
109,806,355
MDExOlB1bGxSZXF1ZXN0NDY3ODYxODc=
2,803
Update default user-agent (#2785)
{ "avatar_url": "https://avatars.githubusercontent.com/u/3287067?v=4", "events_url": "https://api.github.com/users/asieira/events{/privacy}", "followers_url": "https://api.github.com/users/asieira/followers", "following_url": "https://api.github.com/users/asieira/following{/other_user}", "gists_url": "https://api.github.com/users/asieira/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/asieira", "id": 3287067, "login": "asieira", "node_id": "MDQ6VXNlcjMyODcwNjc=", "organizations_url": "https://api.github.com/users/asieira/orgs", "received_events_url": "https://api.github.com/users/asieira/received_events", "repos_url": "https://api.github.com/users/asieira/repos", "site_admin": false, "starred_url": "https://api.github.com/users/asieira/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/asieira/subscriptions", "type": "User", "url": "https://api.github.com/users/asieira", "user_view_type": "public" }
[]
closed
true
null
[]
null
8
2015-10-05T14:19:17Z
2021-09-08T06:00:56Z
2015-10-05T14:54:17Z
CONTRIBUTOR
resolved
- Updated default user agent so that it includes only the requests version; - Added PyCharm / IDEA project directory to `.gitignore`.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2803/reactions" }
https://api.github.com/repos/psf/requests/issues/2803/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2803.diff", "html_url": "https://github.com/psf/requests/pull/2803", "merged_at": "2015-10-05T14:54:17Z", "patch_url": "https://github.com/psf/requests/pull/2803.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2803" }
true
[ "If we can clean this up relatively swiftly it'll make it into 2.8.0: otherwise, it'll fall out until 2.8.1.\n", "I wouldn't be comfortable including this in 2.8.1. 2.9.0 definitely, but not 2.8.1\n", "@asieira No, I think I recommend adding it to your local `.git/info/exclude` file. Text-editor specific config...
https://api.github.com/repos/psf/requests/issues/2802
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2802/labels{/name}
https://api.github.com/repos/psf/requests/issues/2802/comments
https://api.github.com/repos/psf/requests/issues/2802/events
https://github.com/psf/requests/issues/2802
109,652,530
MDU6SXNzdWUxMDk2NTI1MzA=
2,802
IP Address of target host in Response
{ "avatar_url": "https://avatars.githubusercontent.com/u/10950287?v=4", "events_url": "https://api.github.com/users/sezginriggs/events{/privacy}", "followers_url": "https://api.github.com/users/sezginriggs/followers", "following_url": "https://api.github.com/users/sezginriggs/following{/other_user}", "gists_url": "https://api.github.com/users/sezginriggs/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sezginriggs", "id": 10950287, "login": "sezginriggs", "node_id": "MDQ6VXNlcjEwOTUwMjg3", "organizations_url": "https://api.github.com/users/sezginriggs/orgs", "received_events_url": "https://api.github.com/users/sezginriggs/received_events", "repos_url": "https://api.github.com/users/sezginriggs/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sezginriggs/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sezginriggs/subscriptions", "type": "User", "url": "https://api.github.com/users/sezginriggs", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2015-10-04T00:03:53Z
2021-09-08T20:00:46Z
2015-10-04T00:14:59Z
NONE
resolved
Hello, Is there any way to get IP address of target host of a request? Looks like it's possible to get it from urllib3's HTTPResponse object with <Object>._fp.fp._sock.getpeername() but I couldn't find how to get it working with requests. Is there any easy way or work around for it? Or can you please add it to feature requests and to Response object as an attribute? It would be good to use it like r = requests.get("http://blabla.com") print r.ip_addr Best Regards, Sezgin
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2802/reactions" }
https://api.github.com/repos/psf/requests/issues/2802/timeline
null
completed
null
null
false
[ "Hi @sezginriggs thanks for taking the time to open this. We've discussed this previously on https://github.com/kennethreitz/requests/issues/2158 and decided against this. We're currently in a feature freeze (and will be for the rest of the project's life time in all likelihood) so we're not adding new features.\n\...
https://api.github.com/repos/psf/requests/issues/2801
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2801/labels{/name}
https://api.github.com/repos/psf/requests/issues/2801/comments
https://api.github.com/repos/psf/requests/issues/2801/events
https://github.com/psf/requests/issues/2801
109,603,572
MDU6SXNzdWUxMDk2MDM1NzI=
2,801
async and await
{ "avatar_url": "https://avatars.githubusercontent.com/u/149248?v=4", "events_url": "https://api.github.com/users/screendriver/events{/privacy}", "followers_url": "https://api.github.com/users/screendriver/followers", "following_url": "https://api.github.com/users/screendriver/following{/other_user}", "gists_url": "https://api.github.com/users/screendriver/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/screendriver", "id": 149248, "login": "screendriver", "node_id": "MDQ6VXNlcjE0OTI0OA==", "organizations_url": "https://api.github.com/users/screendriver/orgs", "received_events_url": "https://api.github.com/users/screendriver/received_events", "repos_url": "https://api.github.com/users/screendriver/repos", "site_admin": false, "starred_url": "https://api.github.com/users/screendriver/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/screendriver/subscriptions", "type": "User", "url": "https://api.github.com/users/screendriver", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2015-10-03T05:44:51Z
2021-09-08T22:00:46Z
2015-10-03T07:30:28Z
NONE
resolved
Python 3.5 [introduced](https://docs.python.org/3/whatsnew/3.5.html#new-features) coroutines with async and await syntax. Specification about that can be read in [PEP 492](https://www.python.org/dev/peps/pep-0492/). Are there any plans to support this? Because of network lags or slow connections it would make sense to make asynchronous http requests.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 29, "-1": 1, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 30, "url": "https://api.github.com/repos/psf/requests/issues/2801/reactions" }
https://api.github.com/repos/psf/requests/issues/2801/timeline
null
completed
null
null
false
[ "@screendriver At the current time there are no plans to support async and await. This is not because they aren't a good idea: they are. It's because to use them requires quite substantial code changes.\n\nRight now requests is a purely synchronous library that, at the bottom of its stack, uses `httplib` to send an...
https://api.github.com/repos/psf/requests/issues/2800
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2800/labels{/name}
https://api.github.com/repos/psf/requests/issues/2800/comments
https://api.github.com/repos/psf/requests/issues/2800/events
https://github.com/psf/requests/pull/2800
109,586,702
MDExOlB1bGxSZXF1ZXN0NDY2OTEyNzE=
2,800
Update Quickstart documentation of Response.json()
{ "avatar_url": "https://avatars.githubusercontent.com/u/330633?v=4", "events_url": "https://api.github.com/users/hosamaly/events{/privacy}", "followers_url": "https://api.github.com/users/hosamaly/followers", "following_url": "https://api.github.com/users/hosamaly/following{/other_user}", "gists_url": "https://api.github.com/users/hosamaly/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/hosamaly", "id": 330633, "login": "hosamaly", "node_id": "MDQ6VXNlcjMzMDYzMw==", "organizations_url": "https://api.github.com/users/hosamaly/orgs", "received_events_url": "https://api.github.com/users/hosamaly/received_events", "repos_url": "https://api.github.com/users/hosamaly/repos", "site_admin": false, "starred_url": "https://api.github.com/users/hosamaly/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hosamaly/subscriptions", "type": "User", "url": "https://api.github.com/users/hosamaly", "user_view_type": "public" }
[]
closed
true
null
[]
null
11
2015-10-02T23:02:42Z
2021-09-08T06:00:58Z
2015-10-03T17:33:57Z
CONTRIBUTOR
resolved
Fixes #2799
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2800/reactions" }
https://api.github.com/repos/psf/requests/issues/2800/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2800.diff", "html_url": "https://github.com/psf/requests/pull/2800", "merged_at": "2015-10-03T17:33:57Z", "patch_url": "https://github.com/psf/requests/pull/2800.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2800" }
true
[ "This is really good! One note: can we remove the reference to `response.ok`? It's at risk of deprecation, so I'd rather not add new references to it.\n", "Thanks. I beg to differ on `response.ok`. I find it useful and advise people to use it, although I'd prefer to change its implementation to avoid raising and ...
https://api.github.com/repos/psf/requests/issues/2799
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2799/labels{/name}
https://api.github.com/repos/psf/requests/issues/2799/comments
https://api.github.com/repos/psf/requests/issues/2799/events
https://github.com/psf/requests/issues/2799
109,570,280
MDU6SXNzdWUxMDk1NzAyODA=
2,799
Quickstart note about json rendering is misleading
{ "avatar_url": "https://avatars.githubusercontent.com/u/330633?v=4", "events_url": "https://api.github.com/users/hosamaly/events{/privacy}", "followers_url": "https://api.github.com/users/hosamaly/followers", "following_url": "https://api.github.com/users/hosamaly/following{/other_user}", "gists_url": "https://api.github.com/users/hosamaly/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/hosamaly", "id": 330633, "login": "hosamaly", "node_id": "MDQ6VXNlcjMzMDYzMw==", "organizations_url": "https://api.github.com/users/hosamaly/orgs", "received_events_url": "https://api.github.com/users/hosamaly/received_events", "repos_url": "https://api.github.com/users/hosamaly/repos", "site_admin": false, "starred_url": "https://api.github.com/users/hosamaly/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hosamaly/subscriptions", "type": "User", "url": "https://api.github.com/users/hosamaly", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2015-10-02T20:53:53Z
2021-09-08T22:00:45Z
2015-10-03T17:33:57Z
CONTRIBUTOR
resolved
In the Quickstart document, the [JSON Response Content](http://docs.python-requests.org/en/v2.0-0/user/quickstart/#json-response-content) section says: > In case the JSON decoding fails, `r.json` raises an exception. For example, if the response gets a 401 (Unauthorized), attempting `r.json` raises `ValueError: No JSON object could be decoded` This is a bit misleading, especially that the [`json()`](https://github.com/kennethreitz/requests/blob/v2.7.0/requests/models.py#L798) method makes no attempt to validate that. It is accurate to say that failure to decode JSON will result in an error being raised. However, receiving 401 does not necessarily mean that JSON decoding will fail. Some APIs might return a JSON object in the response body (e.g. `{ 'error': 'Unauthorized' }`), in which case `r.json()` will work fine.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2799/reactions" }
https://api.github.com/repos/psf/requests/issues/2799/timeline
null
completed
null
null
false
[ "That's a fair observation. Got a suggestion for clearer language?\n" ]
https://api.github.com/repos/psf/requests/issues/2798
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2798/labels{/name}
https://api.github.com/repos/psf/requests/issues/2798/comments
https://api.github.com/repos/psf/requests/issues/2798/events
https://github.com/psf/requests/pull/2798
109,484,678
MDExOlB1bGxSZXF1ZXN0NDY2MzE1NTI=
2,798
Clarified description for option "trust_env"
{ "avatar_url": "https://avatars.githubusercontent.com/u/2008673?v=4", "events_url": "https://api.github.com/users/Doctor-love/events{/privacy}", "followers_url": "https://api.github.com/users/Doctor-love/followers", "following_url": "https://api.github.com/users/Doctor-love/following{/other_user}", "gists_url": "https://api.github.com/users/Doctor-love/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Doctor-love", "id": 2008673, "login": "Doctor-love", "node_id": "MDQ6VXNlcjIwMDg2NzM=", "organizations_url": "https://api.github.com/users/Doctor-love/orgs", "received_events_url": "https://api.github.com/users/Doctor-love/received_events", "repos_url": "https://api.github.com/users/Doctor-love/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Doctor-love/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Doctor-love/subscriptions", "type": "User", "url": "https://api.github.com/users/Doctor-love", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2015-10-02T12:48:06Z
2021-09-08T06:00:58Z
2015-10-02T12:48:56Z
CONTRIBUTOR
resolved
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2798/reactions" }
https://api.github.com/repos/psf/requests/issues/2798/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2798.diff", "html_url": "https://github.com/psf/requests/pull/2798", "merged_at": "2015-10-02T12:48:56Z", "patch_url": "https://github.com/psf/requests/pull/2798.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2798" }
true
[ "Thanks! :sparkles: :cake: :sparkles:\n" ]
https://api.github.com/repos/psf/requests/issues/2797
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2797/labels{/name}
https://api.github.com/repos/psf/requests/issues/2797/comments
https://api.github.com/repos/psf/requests/issues/2797/events
https://github.com/psf/requests/pull/2797
109,450,764
MDExOlB1bGxSZXF1ZXN0NDY2MTI2NTY=
2,797
Updated Documentation for Issue #2756
{ "avatar_url": "https://avatars.githubusercontent.com/u/11199045?v=4", "events_url": "https://api.github.com/users/sumitbinnani/events{/privacy}", "followers_url": "https://api.github.com/users/sumitbinnani/followers", "following_url": "https://api.github.com/users/sumitbinnani/following{/other_user}", "gists_url": "https://api.github.com/users/sumitbinnani/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sumitbinnani", "id": 11199045, "login": "sumitbinnani", "node_id": "MDQ6VXNlcjExMTk5MDQ1", "organizations_url": "https://api.github.com/users/sumitbinnani/orgs", "received_events_url": "https://api.github.com/users/sumitbinnani/received_events", "repos_url": "https://api.github.com/users/sumitbinnani/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sumitbinnani/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sumitbinnani/subscriptions", "type": "User", "url": "https://api.github.com/users/sumitbinnani", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2015-10-02T08:29:38Z
2021-09-08T06:00:59Z
2015-10-02T09:08:23Z
CONTRIBUTOR
resolved
Updated Documentation as mentioned by @taion in #2756 : `data` as well as `files` supersedes json
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2797/reactions" }
https://api.github.com/repos/psf/requests/issues/2797/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2797.diff", "html_url": "https://github.com/psf/requests/pull/2797", "merged_at": "2015-10-02T09:08:23Z", "patch_url": "https://github.com/psf/requests/pull/2797.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2797" }
true
[ "Thanks @sumitbinnani! :sparkles: :cake: :sparkles:\n" ]
https://api.github.com/repos/psf/requests/issues/2796
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2796/labels{/name}
https://api.github.com/repos/psf/requests/issues/2796/comments
https://api.github.com/repos/psf/requests/issues/2796/events
https://github.com/psf/requests/pull/2796
109,449,942
MDExOlB1bGxSZXF1ZXN0NDY2MTIzNzM=
2,796
Updated Documentation (Ref: #2756)
{ "avatar_url": "https://avatars.githubusercontent.com/u/11199045?v=4", "events_url": "https://api.github.com/users/sumitbinnani/events{/privacy}", "followers_url": "https://api.github.com/users/sumitbinnani/followers", "following_url": "https://api.github.com/users/sumitbinnani/following{/other_user}", "gists_url": "https://api.github.com/users/sumitbinnani/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sumitbinnani", "id": 11199045, "login": "sumitbinnani", "node_id": "MDQ6VXNlcjExMTk5MDQ1", "organizations_url": "https://api.github.com/users/sumitbinnani/orgs", "received_events_url": "https://api.github.com/users/sumitbinnani/received_events", "repos_url": "https://api.github.com/users/sumitbinnani/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sumitbinnani/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sumitbinnani/subscriptions", "type": "User", "url": "https://api.github.com/users/sumitbinnani", "user_view_type": "public" }
[]
closed
true
null
[]
null
0
2015-10-02T08:25:24Z
2021-09-08T06:00:59Z
2015-10-02T08:27:51Z
CONTRIBUTOR
resolved
Updated Documentation: `data` as well as `files` supersedes json
{ "avatar_url": "https://avatars.githubusercontent.com/u/11199045?v=4", "events_url": "https://api.github.com/users/sumitbinnani/events{/privacy}", "followers_url": "https://api.github.com/users/sumitbinnani/followers", "following_url": "https://api.github.com/users/sumitbinnani/following{/other_user}", "gists_url": "https://api.github.com/users/sumitbinnani/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sumitbinnani", "id": 11199045, "login": "sumitbinnani", "node_id": "MDQ6VXNlcjExMTk5MDQ1", "organizations_url": "https://api.github.com/users/sumitbinnani/orgs", "received_events_url": "https://api.github.com/users/sumitbinnani/received_events", "repos_url": "https://api.github.com/users/sumitbinnani/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sumitbinnani/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sumitbinnani/subscriptions", "type": "User", "url": "https://api.github.com/users/sumitbinnani", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2796/reactions" }
https://api.github.com/repos/psf/requests/issues/2796/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2796.diff", "html_url": "https://github.com/psf/requests/pull/2796", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/2796.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2796" }
true
[]
https://api.github.com/repos/psf/requests/issues/2795
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2795/labels{/name}
https://api.github.com/repos/psf/requests/issues/2795/comments
https://api.github.com/repos/psf/requests/issues/2795/events
https://github.com/psf/requests/pull/2795
109,438,293
MDExOlB1bGxSZXF1ZXN0NDY2MDY4Mzk=
2,795
Fixed Bug #2756
{ "avatar_url": "https://avatars.githubusercontent.com/u/11199045?v=4", "events_url": "https://api.github.com/users/sumitbinnani/events{/privacy}", "followers_url": "https://api.github.com/users/sumitbinnani/followers", "following_url": "https://api.github.com/users/sumitbinnani/following{/other_user}", "gists_url": "https://api.github.com/users/sumitbinnani/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sumitbinnani", "id": 11199045, "login": "sumitbinnani", "node_id": "MDQ6VXNlcjExMTk5MDQ1", "organizations_url": "https://api.github.com/users/sumitbinnani/orgs", "received_events_url": "https://api.github.com/users/sumitbinnani/received_events", "repos_url": "https://api.github.com/users/sumitbinnani/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sumitbinnani/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sumitbinnani/subscriptions", "type": "User", "url": "https://api.github.com/users/sumitbinnani", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2015-10-02T06:42:20Z
2021-09-08T06:00:59Z
2015-10-02T07:13:59Z
CONTRIBUTOR
resolved
1. Updated code: `data` supersedes `json` 2. Updated doc: `files` also supersedes `json`
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2795/reactions" }
https://api.github.com/repos/psf/requests/issues/2795/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2795.diff", "html_url": "https://github.com/psf/requests/pull/2795", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/2795.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2795" }
true
[ "Sorry @sumitbinnani, but there's already an open fix for this in #2763 that I think we're likely to merge. Thanks so much for your contribution though! :sparkles: :cake: :sparkles:\n" ]
https://api.github.com/repos/psf/requests/issues/2794
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2794/labels{/name}
https://api.github.com/repos/psf/requests/issues/2794/comments
https://api.github.com/repos/psf/requests/issues/2794/events
https://github.com/psf/requests/pull/2794
109,437,597
MDExOlB1bGxSZXF1ZXN0NDY2MDYzOTA=
2,794
Fixed Bug #2756
{ "avatar_url": "https://avatars.githubusercontent.com/u/11199045?v=4", "events_url": "https://api.github.com/users/sumitbinnani/events{/privacy}", "followers_url": "https://api.github.com/users/sumitbinnani/followers", "following_url": "https://api.github.com/users/sumitbinnani/following{/other_user}", "gists_url": "https://api.github.com/users/sumitbinnani/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sumitbinnani", "id": 11199045, "login": "sumitbinnani", "node_id": "MDQ6VXNlcjExMTk5MDQ1", "organizations_url": "https://api.github.com/users/sumitbinnani/orgs", "received_events_url": "https://api.github.com/users/sumitbinnani/received_events", "repos_url": "https://api.github.com/users/sumitbinnani/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sumitbinnani/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sumitbinnani/subscriptions", "type": "User", "url": "https://api.github.com/users/sumitbinnani", "user_view_type": "public" }
[]
closed
true
null
[]
null
0
2015-10-02T06:31:50Z
2021-09-08T06:01:00Z
2015-10-02T06:34:49Z
CONTRIBUTOR
resolved
Updated Code to meet following specs: 1. Data supersedes JSON Updated Doc to meet following specs: 2. Files supersedes JSON
{ "avatar_url": "https://avatars.githubusercontent.com/u/11199045?v=4", "events_url": "https://api.github.com/users/sumitbinnani/events{/privacy}", "followers_url": "https://api.github.com/users/sumitbinnani/followers", "following_url": "https://api.github.com/users/sumitbinnani/following{/other_user}", "gists_url": "https://api.github.com/users/sumitbinnani/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sumitbinnani", "id": 11199045, "login": "sumitbinnani", "node_id": "MDQ6VXNlcjExMTk5MDQ1", "organizations_url": "https://api.github.com/users/sumitbinnani/orgs", "received_events_url": "https://api.github.com/users/sumitbinnani/received_events", "repos_url": "https://api.github.com/users/sumitbinnani/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sumitbinnani/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sumitbinnani/subscriptions", "type": "User", "url": "https://api.github.com/users/sumitbinnani", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2794/reactions" }
https://api.github.com/repos/psf/requests/issues/2794/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2794.diff", "html_url": "https://github.com/psf/requests/pull/2794", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/2794.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2794" }
true
[]
https://api.github.com/repos/psf/requests/issues/2793
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2793/labels{/name}
https://api.github.com/repos/psf/requests/issues/2793/comments
https://api.github.com/repos/psf/requests/issues/2793/events
https://github.com/psf/requests/issues/2793
109,349,430
MDU6SXNzdWUxMDkzNDk0MzA=
2,793
No module called utils
{ "avatar_url": "https://avatars.githubusercontent.com/u/325887?v=4", "events_url": "https://api.github.com/users/mango314/events{/privacy}", "followers_url": "https://api.github.com/users/mango314/followers", "following_url": "https://api.github.com/users/mango314/following{/other_user}", "gists_url": "https://api.github.com/users/mango314/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/mango314", "id": 325887, "login": "mango314", "node_id": "MDQ6VXNlcjMyNTg4Nw==", "organizations_url": "https://api.github.com/users/mango314/orgs", "received_events_url": "https://api.github.com/users/mango314/received_events", "repos_url": "https://api.github.com/users/mango314/repos", "site_admin": false, "starred_url": "https://api.github.com/users/mango314/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mango314/subscriptions", "type": "User", "url": "https://api.github.com/users/mango314", "user_view_type": "public" }
[]
closed
true
null
[]
null
4
2015-10-01T17:48:41Z
2021-09-08T22:00:45Z
2015-10-03T20:30:12Z
NONE
resolved
I recently installed requests 2.7 using `pip install requests` and received an error message. See my question to [StackOverflow](http://stackoverflow.com/questions/32874326/python-email-module-importerror-no-module-named-utils) but will copy-paste here: My installation of Python's [requests](http://www.python-requests.org/en/latest/) library has been working perfectly for months and it has decided to break today. ``` Python 2.7.6 (default, Jun 22 2015, 17:58:13) [GCC 4.8.2] on linux2 Type "help", "copyright", "credits" or "license" for more information. >>> import requests Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/usr/local/lib/python2.7/dist-packages/requests/__init__.py", line 58, in <module> from . import utils File "/usr/local/lib/python2.7/dist-packages/requests/utils.py", line 26, in <module> from .compat import parse_http_list as _parse_list_header File "/usr/local/lib/python2.7/dist-packages/requests/compat.py", line 7, in <module> from .packages import chardet File "/usr/local/lib/python2.7/dist-packages/requests/packages/__init__.py", line 3, in <module> from . import urllib3 File "/usr/local/lib/python2.7/dist-packages/requests/packages/urllib3/__init__.py", line 10, in <module> from .connectionpool import ( File "/usr/local/lib/python2.7/dist-packages/requests/packages/urllib3/connectionpool.py", line 37, in <module> from .request import RequestMethods File "/usr/local/lib/python2.7/dist-packages/requests/packages/urllib3/request.py", line 6, in <module> from .filepost import encode_multipart_formdata File "/usr/local/lib/python2.7/dist-packages/requests/packages/urllib3/filepost.py", line 8, in <module> from .fields import RequestField File "/usr/local/lib/python2.7/dist-packages/requests/packages/urllib3/fields.py", line 1, in <module> import email.utils ImportError: No module named utils ``` The trouble calling [`utils`](https://docs.python.org/2/library/email.util.html) is related to the [email](https://docs.python.org/2/library/email-examples.html) module in Python 2.7 ``` >>> import email >>> import email.utils Traceback (most recent call last): File "<stdin>", line 1, in <module> ImportError: No module named utils ``` `utils` is clearly a part of Python's `email` library, but it can't be accessed. If I uninstall and reinstall: ``` $ sudo pip install email Collecting email Downloading email-4.0.2.tar.gz (1.2MB) 100% |████████████████████████████████| 1.2MB 286kB/s Installing collected packages: email Running setup.py install for email Successfully installed email-4.0.2 ``` **Worst of all `utils.py` is actually present. What am I doing wrong?** ``` $ ls /usr/local/lib/python2.7/dist-packages/email/ base64mime.py errors.py header.py message.py parser.pyc base64mime.pyc errors.pyc header.pyc message.pyc quoprimime.py charset.py feedparser.py __init__.py mime quoprimime.pyc charset.pyc feedparser.pyc __init__.pyc _parseaddr.py test encoders.py generator.py iterators.py _parseaddr.pyc utils.py encoders.pyc generator.pyc iterators.pyc parser.py utils.pyc ```
{ "avatar_url": "https://avatars.githubusercontent.com/u/325887?v=4", "events_url": "https://api.github.com/users/mango314/events{/privacy}", "followers_url": "https://api.github.com/users/mango314/followers", "following_url": "https://api.github.com/users/mango314/following{/other_user}", "gists_url": "https://api.github.com/users/mango314/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/mango314", "id": 325887, "login": "mango314", "node_id": "MDQ6VXNlcjMyNTg4Nw==", "organizations_url": "https://api.github.com/users/mango314/orgs", "received_events_url": "https://api.github.com/users/mango314/received_events", "repos_url": "https://api.github.com/users/mango314/repos", "site_admin": false, "starred_url": "https://api.github.com/users/mango314/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mango314/subscriptions", "type": "User", "url": "https://api.github.com/users/mango314", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2793/reactions" }
https://api.github.com/repos/psf/requests/issues/2793/timeline
null
completed
null
null
false
[ "I observe this issue has been raised before. None of which really answer my question:\n- https://github.com/kennethreitz/requests/issues/2340\n- https://github.com/kennethreitz/requests/issues/2461\n- https://github.com/kennethreitz/requests/issues/2788\n- https://github.com/kennethreitz/requests/issues/2780\n", ...
https://api.github.com/repos/psf/requests/issues/2792
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2792/labels{/name}
https://api.github.com/repos/psf/requests/issues/2792/comments
https://api.github.com/repos/psf/requests/issues/2792/events
https://github.com/psf/requests/pull/2792
109,261,373
MDExOlB1bGxSZXF1ZXN0NDY1MDE1NzA=
2,792
Update test dependencies
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2015-10-01T09:26:32Z
2021-09-08T06:01:00Z
2015-10-01T09:27:25Z
MEMBER
resolved
Brings our test dependencies up to date.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2792/reactions" }
https://api.github.com/repos/psf/requests/issues/2792/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2792.diff", "html_url": "https://github.com/psf/requests/pull/2792", "merged_at": "2015-10-01T09:27:25Z", "patch_url": "https://github.com/psf/requests/pull/2792.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2792" }
true
[ "I think there's no good reason not to do this so I'm merging immediately.\n" ]
https://api.github.com/repos/psf/requests/issues/2791
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2791/labels{/name}
https://api.github.com/repos/psf/requests/issues/2791/comments
https://api.github.com/repos/psf/requests/issues/2791/events
https://github.com/psf/requests/issues/2791
108,692,878
MDU6SXNzdWUxMDg2OTI4Nzg=
2,791
Request doesnt work on Ubuntu to fetch a TLS1.2 https
{ "avatar_url": "https://avatars.githubusercontent.com/u/3865309?v=4", "events_url": "https://api.github.com/users/adrianzhang/events{/privacy}", "followers_url": "https://api.github.com/users/adrianzhang/followers", "following_url": "https://api.github.com/users/adrianzhang/following{/other_user}", "gists_url": "https://api.github.com/users/adrianzhang/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/adrianzhang", "id": 3865309, "login": "adrianzhang", "node_id": "MDQ6VXNlcjM4NjUzMDk=", "organizations_url": "https://api.github.com/users/adrianzhang/orgs", "received_events_url": "https://api.github.com/users/adrianzhang/received_events", "repos_url": "https://api.github.com/users/adrianzhang/repos", "site_admin": false, "starred_url": "https://api.github.com/users/adrianzhang/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/adrianzhang/subscriptions", "type": "User", "url": "https://api.github.com/users/adrianzhang", "user_view_type": "public" }
[]
closed
true
null
[]
null
15
2015-09-28T16:13:56Z
2021-09-08T20:01:04Z
2015-09-30T17:43:24Z
NONE
resolved
I did search long time try to figure out what is the root reason but still have no clue. There is a simple script used Request to put information to https://dictation.nuancemobility.net, however, the script works on CentOS box but doesn't on Ubuntu ( both on ElementaryOS Freya which is based on Ubuntu 14.04 TLS and ElementaryOS Luna which is based on Ubuntu 12.02). I have tried to use adapter, and got an error: <pre><code> Traceback (most recent call last): File "LanguageIdentify.py", line 11, in <module> from APIclasses import speech2text File "speech2text.py", line 11, in <module> s.mount('https://dictation.nuancemobility.net/', SSLAdapter(ssl.PROTOCOL_TLSv1_2)) AttributeError: 'module' object has no attribute 'PROTOCOL_TLSv1_2' </code></pre> I assumed the error caused by python ssl module on Ubuntu is without TLS 1.2 support, but when I ran test on CentOS box, it got: <pre><code> python \>>>import ssl >>>'PROTOCOL_TLSv1_2' in dir(ssl)` False </code></pre> So above test informed me at least python ssl in not the root reason. Some posts show the openssl on Debian/Ubuntu doesnt have default root CA certs configured. So I also tried to follow Certifi doc to import CA certs. But no clue how to operate the next step. I'v tried to follow Request doc that using REQUEST_CA_BUNDLE but also no help. `export REQUEST_CA_BUNDLE=/etc/ssl/certs/ca-certificates.crt` Well, all methods I tried and failed on Ubuntu. It is appreciate if anybody can help.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2791/reactions" }
https://api.github.com/repos/psf/requests/issues/2791/timeline
null
completed
null
null
false
[ "Can you provide a more detailed description of \"doesn't work\"? How does it not work? What exception(s) (if any) are you seeing? What version of python are you using? What version of requests?\n", "A quick test locally shows this:\n\n```\n$ openssl s_client -connect dictation.nuancemobility.net:443\n# ...\nSSL-...
https://api.github.com/repos/psf/requests/issues/2790
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2790/labels{/name}
https://api.github.com/repos/psf/requests/issues/2790/comments
https://api.github.com/repos/psf/requests/issues/2790/events
https://github.com/psf/requests/issues/2790
108,619,994
MDU6SXNzdWUxMDg2MTk5OTQ=
2,790
Update urllib3 for performance issue
{ "avatar_url": "https://avatars.githubusercontent.com/u/1401705?v=4", "events_url": "https://api.github.com/users/ClemPi/events{/privacy}", "followers_url": "https://api.github.com/users/ClemPi/followers", "following_url": "https://api.github.com/users/ClemPi/following{/other_user}", "gists_url": "https://api.github.com/users/ClemPi/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/ClemPi", "id": 1401705, "login": "ClemPi", "node_id": "MDQ6VXNlcjE0MDE3MDU=", "organizations_url": "https://api.github.com/users/ClemPi/orgs", "received_events_url": "https://api.github.com/users/ClemPi/received_events", "repos_url": "https://api.github.com/users/ClemPi/repos", "site_admin": false, "starred_url": "https://api.github.com/users/ClemPi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ClemPi/subscriptions", "type": "User", "url": "https://api.github.com/users/ClemPi", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2015-09-28T09:27:12Z
2021-09-08T22:00:46Z
2015-09-30T13:29:54Z
NONE
resolved
Hi, Can you update urllib3 to this commit https://github.com/shazow/urllib3/commit/4aebc69dbf1f2eecbff61c3902a9074be4722837 ? It's a serious performance issue to not have this patch for large file uploads. Regards,
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2790/reactions" }
https://api.github.com/repos/psf/requests/issues/2790/timeline
null
completed
null
null
false
[ "The next release should include an update to the most recent release of urllib3.\n" ]
https://api.github.com/repos/psf/requests/issues/2789
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2789/labels{/name}
https://api.github.com/repos/psf/requests/issues/2789/comments
https://api.github.com/repos/psf/requests/issues/2789/events
https://github.com/psf/requests/pull/2789
108,580,221
MDExOlB1bGxSZXF1ZXN0NDYxMTY1Nzk=
2,789
Remove offer to pair with others from README
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
[]
closed
true
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
[ { "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url...
null
0
2015-09-28T02:51:36Z
2021-09-08T06:01:01Z
2015-09-30T13:29:27Z
CONTRIBUTOR
resolved
I don't have the time to dedicate to this any longer unfortunately.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2789/reactions" }
https://api.github.com/repos/psf/requests/issues/2789/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2789.diff", "html_url": "https://github.com/psf/requests/pull/2789", "merged_at": "2015-09-30T13:29:27Z", "patch_url": "https://github.com/psf/requests/pull/2789.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2789" }
true
[]
https://api.github.com/repos/psf/requests/issues/2788
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2788/labels{/name}
https://api.github.com/repos/psf/requests/issues/2788/comments
https://api.github.com/repos/psf/requests/issues/2788/events
https://github.com/psf/requests/issues/2788
108,453,780
MDU6SXNzdWUxMDg0NTM3ODA=
2,788
ImportError: cannot import name certs
{ "avatar_url": "https://avatars.githubusercontent.com/u/1618719?v=4", "events_url": "https://api.github.com/users/Boshomi/events{/privacy}", "followers_url": "https://api.github.com/users/Boshomi/followers", "following_url": "https://api.github.com/users/Boshomi/following{/other_user}", "gists_url": "https://api.github.com/users/Boshomi/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Boshomi", "id": 1618719, "login": "Boshomi", "node_id": "MDQ6VXNlcjE2MTg3MTk=", "organizations_url": "https://api.github.com/users/Boshomi/orgs", "received_events_url": "https://api.github.com/users/Boshomi/received_events", "repos_url": "https://api.github.com/users/Boshomi/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Boshomi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Boshomi/subscriptions", "type": "User", "url": "https://api.github.com/users/Boshomi", "user_view_type": "public" }
[]
closed
true
null
[]
null
3
2015-09-26T10:15:46Z
2015-09-26T21:36:09Z
2015-09-26T21:36:04Z
NONE
null
opensuse 13.1 / python-requests = 2.7.0-63.1 / ## In [8]: import requests; ImportError Traceback (most recent call last) <ipython-input-8-eedc5c747136> in <module>() ----> 1 import requests; /usr/lib/python2.7/site-packages/requests/**init**.py in <module>() 56 pass 57 ---> 58 from . import utils 59 from .models import Request, Response, PreparedRequest 60 from .api import request, get, head, post, patch, put, delete, options /usr/lib/python2.7/site-packages/requests/utils.py in <module>() 23 24 from . import **version** ---> 25 from . import certs 26 from .compat import parse_http_list as _parse_list_header 27 from .compat import (quote, urlparse, bytes, str, OrderedDict, unquote, is_py2, ImportError: cannot import name certs
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2788/reactions" }
https://api.github.com/repos/psf/requests/issues/2788/timeline
null
completed
null
null
false
[ "this issue is fixed with version -requests = opensuse 13.1 / 2.7.0-66.1 /\n" ]
https://api.github.com/repos/psf/requests/issues/2787
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2787/labels{/name}
https://api.github.com/repos/psf/requests/issues/2787/comments
https://api.github.com/repos/psf/requests/issues/2787/events
https://github.com/psf/requests/issues/2787
108,398,187
MDU6SXNzdWUxMDgzOTgxODc=
2,787
Failure in tests on specfic host
{ "avatar_url": "https://avatars.githubusercontent.com/u/186766?v=4", "events_url": "https://api.github.com/users/rixvet/events{/privacy}", "followers_url": "https://api.github.com/users/rixvet/followers", "following_url": "https://api.github.com/users/rixvet/following{/other_user}", "gists_url": "https://api.github.com/users/rixvet/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/rixvet", "id": 186766, "login": "rixvet", "node_id": "MDQ6VXNlcjE4Njc2Ng==", "organizations_url": "https://api.github.com/users/rixvet/orgs", "received_events_url": "https://api.github.com/users/rixvet/received_events", "repos_url": "https://api.github.com/users/rixvet/repos", "site_admin": false, "starred_url": "https://api.github.com/users/rixvet/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rixvet/subscriptions", "type": "User", "url": "https://api.github.com/users/rixvet", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2015-09-25T20:02:25Z
2021-09-08T22:00:46Z
2015-09-25T20:18:05Z
NONE
resolved
Hi I am facing a weird issue both with python2 and python3 which seems to be limited to a specific host (my laptop). A few of the test cases are failing and I do not know why. ``` [rvdzwet@rvdzwet-asus tmp]$ git clone https://github.com/kennethreitz/requests.git Cloning into 'requests'... remote: Counting objects: 15705, done. remote: Compressing objects: 100% (4/4), done. remote: Total 15705 (delta 0), reused 0 (delta 0), pack-reused 15701 Receiving objects: 100% (15705/15705), 6.52 MiB | 147.00 KiB/s, done. Resolving deltas: 100% (8874/8874), done. Checking connectivity... done. [rvdzwet@rvdzwet-asus tmp]$ cd requests/ [rvdzwet@rvdzwet-asus requests]$ ls AUTHORS.rst docs ext HISTORY.rst LICENSE Makefile MANIFEST.in NOTICE README.rst requests requirements.txt setup.cfg setup.py test_requests.py [rvdzwet@rvdzwet-asus requests]$ ./test_requests.py ................FF................................................................................................................................. ====================================================================== FAIL: test_auth_is_retained_for_redirect_on_host (__main__.RequestsTestCase) ---------------------------------------------------------------------- Traceback (most recent call last): File "./test_requests.py", line 1002, in test_auth_is_retained_for_redirect_on_host assert h1 == h2 AssertionError ====================================================================== FAIL: test_auth_is_stripped_on_redirect_off_host (__main__.RequestsTestCase) ---------------------------------------------------------------------- Traceback (most recent call last): File "./test_requests.py", line 995, in test_auth_is_stripped_on_redirect_off_host assert not r.request.headers.get('Authorization', '') AssertionError ---------------------------------------------------------------------- Ran 147 tests in 33.126s FAILED (failures=2) ``` Some details of the host: ``` [rvdzwet@rvdzwet-asus requests]$ lsb_release -a LSB Version: :core-4.1-amd64:core-4.1-noarch:cxx-4.1-amd64:cxx-4.1-noarch:desktop-4.1-amd64:desktop-4.1-noarch:languages-4.1-amd64:languages-4.1-noarch:printing-4.1-amd64:printing-4.1-noarch Distributor ID: Fedora Description: Fedora release 21 (Twenty One) Release: 21 Codename: TwentyOne [rvdzwet@rvdzwet-asus requests]$ python -V Python 2.7.8 [rvdzwet@rvdzwet-asus requests]$ python3 -V Python 3.4.1 ```
{ "avatar_url": "https://avatars.githubusercontent.com/u/186766?v=4", "events_url": "https://api.github.com/users/rixvet/events{/privacy}", "followers_url": "https://api.github.com/users/rixvet/followers", "following_url": "https://api.github.com/users/rixvet/following{/other_user}", "gists_url": "https://api.github.com/users/rixvet/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/rixvet", "id": 186766, "login": "rixvet", "node_id": "MDQ6VXNlcjE4Njc2Ng==", "organizations_url": "https://api.github.com/users/rixvet/orgs", "received_events_url": "https://api.github.com/users/rixvet/received_events", "repos_url": "https://api.github.com/users/rixvet/repos", "site_admin": false, "starred_url": "https://api.github.com/users/rixvet/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rixvet/subscriptions", "type": "User", "url": "https://api.github.com/users/rixvet", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2787/reactions" }
https://api.github.com/repos/psf/requests/issues/2787/timeline
null
completed
null
null
false
[ "Found the culprit (after looking looking at the streams with wireshark). It was caused by a erroneous `~/.netrc` entry.\n\n```\n[rvdzwet@rvdzwet-asus requests]$ cat ~/.netrc \ndefault login anonymous password user@site\n```\n\nRemoving this entry fixed my issue. Thanks to you folks for providing the extended test ...
https://api.github.com/repos/psf/requests/issues/2786
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2786/labels{/name}
https://api.github.com/repos/psf/requests/issues/2786/comments
https://api.github.com/repos/psf/requests/issues/2786/events
https://github.com/psf/requests/pull/2786
107,960,351
MDExOlB1bGxSZXF1ZXN0NDU4MDI2ODM=
2,786
adapters: Fix bug causing ingored read_timeout for chunked requests
{ "avatar_url": "https://avatars.githubusercontent.com/u/1258054?v=4", "events_url": "https://api.github.com/users/swistakm/events{/privacy}", "followers_url": "https://api.github.com/users/swistakm/followers", "following_url": "https://api.github.com/users/swistakm/following{/other_user}", "gists_url": "https://api.github.com/users/swistakm/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/swistakm", "id": 1258054, "login": "swistakm", "node_id": "MDQ6VXNlcjEyNTgwNTQ=", "organizations_url": "https://api.github.com/users/swistakm/orgs", "received_events_url": "https://api.github.com/users/swistakm/received_events", "repos_url": "https://api.github.com/users/swistakm/repos", "site_admin": false, "starred_url": "https://api.github.com/users/swistakm/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/swistakm/subscriptions", "type": "User", "url": "https://api.github.com/users/swistakm", "user_view_type": "public" }
[]
closed
true
null
[]
null
5
2015-09-23T16:45:57Z
2021-09-08T05:00:56Z
2015-10-01T07:26:01Z
NONE
resolved
Whenever chunked request was made (using generators) read timeout value was ignored because socket timeout was not set. This can be a problem when system default timeout is very long because blocks process waiting for response for a period of time that cannot be controlled. Changes: - `HTTPAdapter.send()` now sets read timeout on `low_conn.sock` socket when request body is chunked. - socket.error, socket.timeout are explicitely translated to urllib3 exceptions using `conn._raise_timeout` as expected with non-chunked request bodies to be later translated to `requests` exceptions with existing code. - test added for timeouts on chunked-message body requests Additional notes: - due to convention to use httbin in requests tests and no posibility to tests POST timeouts with `delay/:n` endpoint (method not allowed) test for this bug uses GET with chunked message-body. This is OK because RFC-2616 does not explicitely say that message-body is forbidden in GET requests. And also it works
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2786/reactions" }
https://api.github.com/repos/psf/requests/issues/2786/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2786.diff", "html_url": "https://github.com/psf/requests/pull/2786", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/2786.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2786" }
true
[ "Paging @shazow to make sure we don't step on any toes here with urllib3 by accident.\n", "Looks painful but don't think urllib3 would break this.\n", "This went how I expected. It was closed but never fixed. If it won't be fixed this way but is planned to be done in urllib3 can we just reopen it as an issue so...
https://api.github.com/repos/psf/requests/issues/2785
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2785/labels{/name}
https://api.github.com/repos/psf/requests/issues/2785/comments
https://api.github.com/repos/psf/requests/issues/2785/events
https://github.com/psf/requests/issues/2785
107,941,992
MDU6SXNzdWUxMDc5NDE5OTI=
2,785
Information leakage in default user agent
{ "avatar_url": "https://avatars.githubusercontent.com/u/3287067?v=4", "events_url": "https://api.github.com/users/asieira/events{/privacy}", "followers_url": "https://api.github.com/users/asieira/followers", "following_url": "https://api.github.com/users/asieira/following{/other_user}", "gists_url": "https://api.github.com/users/asieira/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/asieira", "id": 3287067, "login": "asieira", "node_id": "MDQ6VXNlcjMyODcwNjc=", "organizations_url": "https://api.github.com/users/asieira/orgs", "received_events_url": "https://api.github.com/users/asieira/received_events", "repos_url": "https://api.github.com/users/asieira/repos", "site_admin": false, "starred_url": "https://api.github.com/users/asieira/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/asieira/subscriptions", "type": "User", "url": "https://api.github.com/users/asieira", "user_view_type": "public" }
[]
closed
true
null
[]
null
14
2015-09-23T15:09:52Z
2021-09-08T22:00:44Z
2015-10-05T14:56:31Z
CONTRIBUTOR
resolved
I've noticed that requests adds a user-agent header by default that looks like the following: `python-requests/2.7.0 CPython/2.7.9 Linux/3.14.44-32.39.amzn1.x86_64`. Including the CPython and OS kernel version are an unnecessary information leakage that could have security implications, as per the [OWASP documentation](https://www.owasp.org/index.php/Information_Leakage). I would like to suggest the default is changed to follow the 'bot' convention described [here](https://en.wikipedia.org/wiki/User_agent#Format_for_automated_agents_.28bots.29) with the requests version and a link to the requests documentation: `python-requests/<version> (http://http://www.python-requests.org/)`.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2785/reactions" }
https://api.github.com/repos/psf/requests/issues/2785/timeline
null
completed
null
null
false
[ "Eh, I'm 50/50 on this. I agree the default user-agent isn't ideal. I don't agree that this is a large problem. I'd like to hear @Lukasa's opinion on this but he's away on vacation (as I should be).\n", "Agreed that this is not a critical issue, but it is a security problem nonetheless.\n\nThank you very much for...
https://api.github.com/repos/psf/requests/issues/2784
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2784/labels{/name}
https://api.github.com/repos/psf/requests/issues/2784/comments
https://api.github.com/repos/psf/requests/issues/2784/events
https://github.com/psf/requests/issues/2784
107,878,540
MDU6SXNzdWUxMDc4Nzg1NDA=
2,784
pooled connections are not returned to the pool
{ "avatar_url": "https://avatars.githubusercontent.com/u/200878?v=4", "events_url": "https://api.github.com/users/sileht/events{/privacy}", "followers_url": "https://api.github.com/users/sileht/followers", "following_url": "https://api.github.com/users/sileht/following{/other_user}", "gists_url": "https://api.github.com/users/sileht/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sileht", "id": 200878, "login": "sileht", "node_id": "MDQ6VXNlcjIwMDg3OA==", "organizations_url": "https://api.github.com/users/sileht/orgs", "received_events_url": "https://api.github.com/users/sileht/received_events", "repos_url": "https://api.github.com/users/sileht/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sileht/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sileht/subscriptions", "type": "User", "url": "https://api.github.com/users/sileht", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2015-09-23T09:17:46Z
2021-09-08T22:00:47Z
2015-09-23T10:28:35Z
NONE
resolved
Hi When pool_block=True on an HTTPAdapter is used and the connection fails this one seems not return to the pool. To reproduce: ``` # python >>> import requests >>> a = requests.adapters.HTTPAdapter(pool_maxsize=1, pool_block=True) >>> s = requests.Session() >>> s.mount("http://", a) >>> s.get("http://localhost:12345") Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/usr/local/lib/python2.7/dist-packages/requests/sessions.py", line 477, in get return self.request('GET', url, **kwargs) File "/usr/local/lib/python2.7/dist-packages/requests/sessions.py", line 465, in request resp = self.send(prep, **send_kwargs) File "/usr/local/lib/python2.7/dist-packages/requests/sessions.py", line 573, in send r = adapter.send(request, **kwargs) File "/usr/local/lib/python2.7/dist-packages/requests/adapters.py", line 413, in send raise ConnectionError(err, request=request) requests.exceptions.ConnectionError: ('Connection aborted.', error(111, 'Connection refused')) >>> s.get("http://localhost:12345") # here the session objects is stuck. ``` Cheers,
{ "avatar_url": "https://avatars.githubusercontent.com/u/200878?v=4", "events_url": "https://api.github.com/users/sileht/events{/privacy}", "followers_url": "https://api.github.com/users/sileht/followers", "following_url": "https://api.github.com/users/sileht/following{/other_user}", "gists_url": "https://api.github.com/users/sileht/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sileht", "id": 200878, "login": "sileht", "node_id": "MDQ6VXNlcjIwMDg3OA==", "organizations_url": "https://api.github.com/users/sileht/orgs", "received_events_url": "https://api.github.com/users/sileht/received_events", "repos_url": "https://api.github.com/users/sileht/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sileht/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sileht/subscriptions", "type": "User", "url": "https://api.github.com/users/sileht", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2784/reactions" }
https://api.github.com/repos/psf/requests/issues/2784/timeline
null
completed
null
null
false
[ "After deeper investigation it seems to be that one: https://github.com/shazow/urllib3/issues/659\n", "Duplicate of kennethreitz/requests#2687\n" ]
https://api.github.com/repos/psf/requests/issues/2783
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2783/labels{/name}
https://api.github.com/repos/psf/requests/issues/2783/comments
https://api.github.com/repos/psf/requests/issues/2783/events
https://github.com/psf/requests/issues/2783
107,794,059
MDU6SXNzdWUxMDc3OTQwNTk=
2,783
SSL: CERTIFICATE_VERIFY_FAILED on valid(?) cert chain with verify="./bundle.crt"
{ "avatar_url": "https://avatars.githubusercontent.com/u/1677760?v=4", "events_url": "https://api.github.com/users/neutrinus/events{/privacy}", "followers_url": "https://api.github.com/users/neutrinus/followers", "following_url": "https://api.github.com/users/neutrinus/following{/other_user}", "gists_url": "https://api.github.com/users/neutrinus/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/neutrinus", "id": 1677760, "login": "neutrinus", "node_id": "MDQ6VXNlcjE2Nzc3NjA=", "organizations_url": "https://api.github.com/users/neutrinus/orgs", "received_events_url": "https://api.github.com/users/neutrinus/received_events", "repos_url": "https://api.github.com/users/neutrinus/repos", "site_admin": false, "starred_url": "https://api.github.com/users/neutrinus/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/neutrinus/subscriptions", "type": "User", "url": "https://api.github.com/users/neutrinus", "user_view_type": "public" }
[]
closed
true
null
[]
null
7
2015-09-22T20:23:58Z
2021-09-04T00:06:08Z
2015-09-30T20:15:58Z
NONE
resolved
## Story We are using requests in [MonitOwl](https://github.com/whitehats/monitowl-agent) agent to communicate with API servers, big "thank you" for great software. Few days ago we ordered new certificates for *.monitowl.com and deployed it to new instance, our issuer is `nazwa.pl`. Pointing a webbrowser to https://activeo.monitowl.com works flawlessly, requests seems to have some problems, when setting verify="./cabundle.crt". ## Technical notes In front of the tornado server handling ssl there is a haproxy checking SNI and redistributing the traffic, part of the config file: ``` acl app_activeo req_ssl_sni -i activeo.monitowl.com use_backend bk_activeo if app_activeo ``` We _need_ to provide own cabundle to have control what is accepted - because of security issues and deployment scripts. We are using debian jessie everywhere. ``` # from issuer https://panel.nazwa.pl/uploads/ssl/nazwaSSL_SHA-2.zip $ cat monitowlcom.crt nazwasslsha2.pem certumca-ctncasha2.pem gscasha2.pem > ./ca_bundle.crt # exported from firefox $ cat monitowl.com nazwaSSL CertumTrustedNetworkCA CertumGlobalServicesCASHA2 > ca_bundle_ff.crt $ openssl verify -untrusted ./ca.crt monitowlcom.crt monitowlcom.crt: OK $ c_rehash ./ $ openssl s_client -CApath ./ -connect activeo.monitowl.com:443 -servername activeo.monitowl.com CONNECTED(00000003) depth=4 C = PL, O = Unizeto Sp. z o.o., CN = Certum CA verify return:1 depth=3 C = PL, O = Unizeto Technologies S.A., OU = Certum Certification Authority, CN = Certum Trusted Network CA verify return:1 depth=2 C = PL, O = Unizeto Technologies S.A., OU = Certum Certification Authority, CN = Certum Global Services CA SHA2 verify return:1 depth=1 C = PL, O = nazwa.pl S.A., OU = http://nazwa.pl, CN = nazwaSSL verify return:1 depth=0 C = PL, CN = *.monitowl.com, emailAddress = admin@whitehats.pl verify return:1 [...] * Verify return code: 0 (ok)* $ curl -I --cacert ca_bundle.crt https://activeo.monitowl.com HTTP/1.1 200 OK $ curl -I --cacert ca_bundle_ff.crt https://activeo.monitowl.com HTTP/1.1 200 OK ``` As you can see, the `openssl s_client` verifies the connection, curl works without problems. ## Problem ``` In [1]: import requests In [3]: requests.get('https://activeo.monitowl.com', verify=True) Out[3]: <Response [200]> In [4]: requests.get('https://activeo.monitowl.com', verify="./ca_bundle.crt") --------------------------------------------------------------------------- SSLError Traceback (most recent call last) <ipython-input-3-c92a3091d6ce> in <module>() ----> 1 requests.get('https://activeo.monitowl.com', verify="./ca_bundle.crt") /home/vagrant/.virtualenvs/test/local/lib/python2.7/site-packages/requests/api.pyc in get(url, params, **kwargs) 67 68 kwargs.setdefault('allow_redirects', True) ---> 69 return request('get', url, params=params, **kwargs) 70 71 /home/vagrant/.virtualenvs/test/local/lib/python2.7/site-packages/requests/api.pyc in request(method, url, **kwargs) 48 49 session = sessions.Session() ---> 50 response = session.request(method=method, url=url, **kwargs) 51 # By explicitly closing the session, we avoid leaving sockets open which 52 # can trigger a ResourceWarning in some cases, and look like a memory leak /home/vagrant/.virtualenvs/test/local/lib/python2.7/site-packages/requests/sessions.pyc in request(self, method, url, params, data, headers, cookies, files, auth, timeout, allow_redirects, proxies, hooks, stream, verify, cert, json) 463 } 464 send_kwargs.update(settings) --> 465 resp = self.send(prep, **send_kwargs) 466 467 return resp /home/vagrant/.virtualenvs/test/local/lib/python2.7/site-packages/requests/sessions.pyc in send(self, request, **kwargs) 571 572 # Send the request --> 573 r = adapter.send(request, **kwargs) 574 575 # Total elapsed time of the request (approximately) /home/vagrant/.virtualenvs/test/local/lib/python2.7/site-packages/requests/adapters.pyc in send(self, request, stream, timeout, verify, cert, proxies) 429 except (_SSLError, _HTTPError) as e: 430 if isinstance(e, _SSLError): --> 431 raise SSLError(e, request=request) 432 elif isinstance(e, ReadTimeoutError): 433 raise ReadTimeout(e, request=request) SSLError: [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed (_ssl.c:581) In [5]: requests.get('https://activeo.monitowl.com', verify="./ca_bundle_ff.crt") [same error] In [7]: import ssl; ssl.OPENSSL_VERSION Out[7]: 'OpenSSL 1.0.1k 8 Jan 2015' In [8]: import sys; print (sys.version) 2.7.9 (default, Mar 1 2015, 12:57:24) [GCC 4.9.2] In [2]: requests.__version__ Out[2]: '2.7.0' ``` On server side (tornado): ``` SSLError: [SSL: TLSV1_ALERT_UNKNOWN_CA] tlsv1 alert unknown ca (_ssl.c:581) ``` I asked some friends to test it with the bundle exported from webbrowser and: Python==2.7.9 + OpenSSL==1.0.1k => FAILS Python==2.7.10 + OpenSSL==1.0.1k => FAILS Python==2.7.9 + OpenSSL==1.0.1l => FAILS Python==2.7.10 + OpenSSL==1.0.1p => WORKS Python==2.7.10 + OpenSSL==1.0.2d => WORKS Python==2.7.9 + OpenSSL 1.0.2d => WORKS I'm aware that python verifies the certs [differently](http://stackoverflow.com/questions/27804710/python-urllib2-ssl-error/27826829#27826829) than web browsers. Do you have any clues what is wrong with the bundle? What else can I check? It's a bug? In requests, openssl, python or urllib3?
{ "avatar_url": "https://avatars.githubusercontent.com/u/1677760?v=4", "events_url": "https://api.github.com/users/neutrinus/events{/privacy}", "followers_url": "https://api.github.com/users/neutrinus/followers", "following_url": "https://api.github.com/users/neutrinus/following{/other_user}", "gists_url": "https://api.github.com/users/neutrinus/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/neutrinus", "id": 1677760, "login": "neutrinus", "node_id": "MDQ6VXNlcjE2Nzc3NjA=", "organizations_url": "https://api.github.com/users/neutrinus/orgs", "received_events_url": "https://api.github.com/users/neutrinus/received_events", "repos_url": "https://api.github.com/users/neutrinus/repos", "site_admin": false, "starred_url": "https://api.github.com/users/neutrinus/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/neutrinus/subscriptions", "type": "User", "url": "https://api.github.com/users/neutrinus", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2783/reactions" }
https://api.github.com/repos/psf/requests/issues/2783/timeline
null
completed
null
null
false
[ "I've posted a [$30 bounty for this](https://www.bountysource.com/issues/26878061-ssl-certificate_verify_failed-on-valid-cert-chain-with-verify-bundle-crt).\n\nI've tested the server with [ssl checker](https://www.ssllabs.com/ssltest/analyze.html?d=activeo.monitowl.com&latest) and there was no issues, beside accept...
https://api.github.com/repos/psf/requests/issues/2782
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2782/labels{/name}
https://api.github.com/repos/psf/requests/issues/2782/comments
https://api.github.com/repos/psf/requests/issues/2782/events
https://github.com/psf/requests/pull/2782
107,567,620
MDExOlB1bGxSZXF1ZXN0NDU1ODAzODM=
2,782
Does't escaped ASCII characters when post json data by default
{ "avatar_url": "https://avatars.githubusercontent.com/u/3264292?v=4", "events_url": "https://api.github.com/users/tao12345666333/events{/privacy}", "followers_url": "https://api.github.com/users/tao12345666333/followers", "following_url": "https://api.github.com/users/tao12345666333/following{/other_user}", "gists_url": "https://api.github.com/users/tao12345666333/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/tao12345666333", "id": 3264292, "login": "tao12345666333", "node_id": "MDQ6VXNlcjMyNjQyOTI=", "organizations_url": "https://api.github.com/users/tao12345666333/orgs", "received_events_url": "https://api.github.com/users/tao12345666333/received_events", "repos_url": "https://api.github.com/users/tao12345666333/repos", "site_admin": false, "starred_url": "https://api.github.com/users/tao12345666333/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/tao12345666333/subscriptions", "type": "User", "url": "https://api.github.com/users/tao12345666333", "user_view_type": "public" }
[]
closed
true
null
[]
null
5
2015-09-21T18:09:10Z
2021-09-08T05:01:01Z
2016-01-30T03:29:55Z
NONE
resolved
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2782/reactions" }
https://api.github.com/repos/psf/requests/issues/2782/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2782.diff", "html_url": "https://github.com/psf/requests/pull/2782", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/2782.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2782" }
true
[ "@tao12345666333 could you explain this? Why is this necessary? Did you encounter a bug? We don't just accept code thrown over the wall without an explanation.\n", "@sigmavirus24 Thanks for your reply.\n\nWhen I use requests to post json data, the json data will be escaped by default. \nMy code is here:\n\n```\n#...
https://api.github.com/repos/psf/requests/issues/2781
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2781/labels{/name}
https://api.github.com/repos/psf/requests/issues/2781/comments
https://api.github.com/repos/psf/requests/issues/2781/events
https://github.com/psf/requests/issues/2781
107,494,799
MDU6SXNzdWUxMDc0OTQ3OTk=
2,781
requests.get(verify='path/to/self-signed-certificate') cannot verify SAN
{ "avatar_url": "https://avatars.githubusercontent.com/u/244203?v=4", "events_url": "https://api.github.com/users/kissgyorgy/events{/privacy}", "followers_url": "https://api.github.com/users/kissgyorgy/followers", "following_url": "https://api.github.com/users/kissgyorgy/following{/other_user}", "gists_url": "https://api.github.com/users/kissgyorgy/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kissgyorgy", "id": 244203, "login": "kissgyorgy", "node_id": "MDQ6VXNlcjI0NDIwMw==", "organizations_url": "https://api.github.com/users/kissgyorgy/orgs", "received_events_url": "https://api.github.com/users/kissgyorgy/received_events", "repos_url": "https://api.github.com/users/kissgyorgy/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kissgyorgy/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kissgyorgy/subscriptions", "type": "User", "url": "https://api.github.com/users/kissgyorgy", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2015-09-21T11:49:34Z
2021-09-08T22:00:47Z
2015-09-21T12:41:54Z
NONE
resolved
Verifying a certificate which have Subject Alternative Names with IP addresses (or DNS names), Common Name should not be checked and those addresses should be checked instead. [RFC6125 section 6.4.4 describes this.](http://tools.ietf.org/html/rfc6125#section-6.4.4)
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2781/reactions" }
https://api.github.com/repos/psf/requests/issues/2781/timeline
null
completed
null
null
false
[ "@kissgyorgy Thanks for this!\n\nWe already do this for DNS names, as you can see in [this code](https://github.com/kennethreitz/requests/blob/master/requests/packages/urllib3/packages/ssl_match_hostname/_implementation.py#L67-L105). The reason we don't do it for IP addresses in SANs is because we currently don't s...
https://api.github.com/repos/psf/requests/issues/2780
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2780/labels{/name}
https://api.github.com/repos/psf/requests/issues/2780/comments
https://api.github.com/repos/psf/requests/issues/2780/events
https://github.com/psf/requests/issues/2780
107,358,696
MDU6SXNzdWUxMDczNTg2OTY=
2,780
ImportError: cannot import name certs
{ "avatar_url": "https://avatars.githubusercontent.com/u/6767924?v=4", "events_url": "https://api.github.com/users/muhammad-ammar/events{/privacy}", "followers_url": "https://api.github.com/users/muhammad-ammar/followers", "following_url": "https://api.github.com/users/muhammad-ammar/following{/other_user}", "gists_url": "https://api.github.com/users/muhammad-ammar/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/muhammad-ammar", "id": 6767924, "login": "muhammad-ammar", "node_id": "MDQ6VXNlcjY3Njc5MjQ=", "organizations_url": "https://api.github.com/users/muhammad-ammar/orgs", "received_events_url": "https://api.github.com/users/muhammad-ammar/received_events", "repos_url": "https://api.github.com/users/muhammad-ammar/repos", "site_admin": false, "starred_url": "https://api.github.com/users/muhammad-ammar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/muhammad-ammar/subscriptions", "type": "User", "url": "https://api.github.com/users/muhammad-ammar", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2015-09-19T22:16:09Z
2021-09-08T22:00:47Z
2015-09-20T12:51:22Z
NONE
resolved
All the requests versions except `requests==0.14.2` giving me below exception. Any idea what might be wrong? ``` python Traceback (most recent call last): File "/usr/lib/python2.7/wsgiref/handlers.py", line 85, in run self.result = application(self.environ, self.start_response) File "/edx/app/xqueue/venvdj18/local/lib/python2.7/site-packages/django/core/handlers/wsgi.py", line 189, in __call__ response = self.get_response(request) File "/edx/app/xqueue/xqueue/xqueue/wsgi.py", line 50, in get_response return super(ForceReadPostHandler, self).get_response(request) File "/edx/app/xqueue/venvdj18/local/lib/python2.7/site-packages/django/core/handlers/base.py", line 218, in get_response response = self.handle_uncaught_exception(request, resolver, sys.exc_info()) File "/edx/app/xqueue/venvdj18/local/lib/python2.7/site-packages/django/core/handlers/base.py", line 264, in handle_uncaught_exception if resolver.urlconf_module is None: File "/edx/app/xqueue/venvdj18/local/lib/python2.7/site-packages/django/core/urlresolvers.py", line 396, in urlconf_module self._urlconf_module = import_module(self.urlconf_name) File "/usr/lib/python2.7/importlib/__init__.py", line 37, in import_module __import__(name) File "/edx/app/xqueue/xqueue/xqueue/urls.py", line 4, in <module> url(r'^xqueue/', include('queue.urls')), File "/edx/app/xqueue/venvdj18/local/lib/python2.7/site-packages/django/conf/urls/__init__.py", line 33, in include urlconf_module = import_module(urlconf_module) File "/usr/lib/python2.7/importlib/__init__.py", line 37, in import_module __import__(name) File "/edx/app/xqueue/xqueue/queue/urls.py", line 4, in <module> from . import ext_interface File "/edx/app/xqueue/xqueue/queue/ext_interface.py", line 7, in <module> import requests File "/edx/app/xqueue/venvdj18/local/lib/python2.7/site-packages/requests/__init__.py", line 58, in <module> from . import utils File "/edx/app/xqueue/venvdj18/local/lib/python2.7/site-packages/requests/utils.py", line 24, in <module> from . import certs ImportError: cannot import name certs ``` **_requests==0.14.2**_ gives this exception ``` python Traceback (most recent call last): File "/usr/lib/python2.7/wsgiref/handlers.py", line 85, in run self.result = application(self.environ, self.start_response) File "/edx/app/xqueue/venvdj18/local/lib/python2.7/site-packages/django/core/handlers/wsgi.py", line 189, in __call__ response = self.get_response(request) File "/edx/app/xqueue/venvdj18/local/lib/python2.7/site-packages/django/core/handlers/base.py", line 218, in get_response response = self.handle_uncaught_exception(request, resolver, sys.exc_info()) File "/edx/app/xqueue/venvdj18/local/lib/python2.7/site-packages/django/core/handlers/base.py", line 264, in handle_uncaught_exception if resolver.urlconf_module is None: File "/edx/app/xqueue/venvdj18/local/lib/python2.7/site-packages/django/core/urlresolvers.py", line 396, in urlconf_module self._urlconf_module = import_module(self.urlconf_name) File "/usr/lib/python2.7/importlib/__init__.py", line 37, in import_module __import__(name) File "/edx/app/xqueue/xqueue/xqueue/urls.py", line 4, in <module> url(r'^xqueue/', include('queue.urls')), File "/edx/app/xqueue/venvdj18/local/lib/python2.7/site-packages/django/conf/urls/__init__.py", line 33, in include urlconf_module = import_module(urlconf_module) File "/usr/lib/python2.7/importlib/__init__.py", line 37, in import_module __import__(name) File "/edx/app/xqueue/xqueue/queue/urls.py", line 4, in <module> from . import ext_interface File "/edx/app/xqueue/xqueue/queue/ext_interface.py", line 7, in <module> import requests File "/edx/app/xqueue/venvdj18/local/lib/python2.7/site-packages/requests/__init__.py", line 52, in <module> from . import utils File "/edx/app/xqueue/venvdj18/local/lib/python2.7/site-packages/requests/utils.py", line 22, in <module> from .compat import parse_http_list as _parse_list_header File "/edx/app/xqueue/venvdj18/local/lib/python2.7/site-packages/requests/compat.py", line 95, in <module> from .packages import chardet File "/edx/app/xqueue/venvdj18/local/lib/python2.7/site-packages/requests/packages/__init__.py", line 3, in <module> from . import urllib3 File "/edx/app/xqueue/venvdj18/local/lib/python2.7/site-packages/requests/packages/urllib3/__init__.py", line 16, in <module> from .connectionpool import ( File "/edx/app/xqueue/venvdj18/local/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py", line 22, in <module> from Queue import LifoQueue, Empty, Full ImportError: cannot import name LifoQueue ```
{ "avatar_url": "https://avatars.githubusercontent.com/u/6767924?v=4", "events_url": "https://api.github.com/users/muhammad-ammar/events{/privacy}", "followers_url": "https://api.github.com/users/muhammad-ammar/followers", "following_url": "https://api.github.com/users/muhammad-ammar/following{/other_user}", "gists_url": "https://api.github.com/users/muhammad-ammar/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/muhammad-ammar", "id": 6767924, "login": "muhammad-ammar", "node_id": "MDQ6VXNlcjY3Njc5MjQ=", "organizations_url": "https://api.github.com/users/muhammad-ammar/orgs", "received_events_url": "https://api.github.com/users/muhammad-ammar/received_events", "repos_url": "https://api.github.com/users/muhammad-ammar/repos", "site_admin": false, "starred_url": "https://api.github.com/users/muhammad-ammar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/muhammad-ammar/subscriptions", "type": "User", "url": "https://api.github.com/users/muhammad-ammar", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2780/reactions" }
https://api.github.com/repos/psf/requests/issues/2780/timeline
null
completed
null
null
false
[ "> All the requests versions except requests==0.14.2 giving me below exception. Any idea what might be wrong?\n\nCan you enumerate exactly which versions you've tried? The latest version would not match your first traceback. Further, how are you installing requests? You've given no information to help you out. I ca...
https://api.github.com/repos/psf/requests/issues/2779
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2779/labels{/name}
https://api.github.com/repos/psf/requests/issues/2779/comments
https://api.github.com/repos/psf/requests/issues/2779/events
https://github.com/psf/requests/issues/2779
107,285,006
MDU6SXNzdWUxMDcyODUwMDY=
2,779
switch to alabaster theme
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2015-09-18T21:55:08Z
2021-09-08T19:00:38Z
2016-01-25T23:05:45Z
CONTRIBUTOR
resolved
this may prove difficult, due to some ad tracking codes we have enabled
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2779/reactions" }
https://api.github.com/repos/psf/requests/issues/2779/timeline
null
completed
null
null
false
[ "@kennethreitz: Is this what you have in mind? https://github.com/kennethreitz/requests/pull/2915 How do I confirm that ad tracking codes are still enabled and nothing broke?\n", "The PR for this issue is merged, so the issue could be perhaps be closed. \n" ]
https://api.github.com/repos/psf/requests/issues/2778
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2778/labels{/name}
https://api.github.com/repos/psf/requests/issues/2778/comments
https://api.github.com/repos/psf/requests/issues/2778/events
https://github.com/psf/requests/issues/2778
107,188,451
MDU6SXNzdWUxMDcxODg0NTE=
2,778
Requests fails to fetch a TLS 1.2 site
{ "avatar_url": "https://avatars.githubusercontent.com/u/1014189?v=4", "events_url": "https://api.github.com/users/adamatan/events{/privacy}", "followers_url": "https://api.github.com/users/adamatan/followers", "following_url": "https://api.github.com/users/adamatan/following{/other_user}", "gists_url": "https://api.github.com/users/adamatan/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/adamatan", "id": 1014189, "login": "adamatan", "node_id": "MDQ6VXNlcjEwMTQxODk=", "organizations_url": "https://api.github.com/users/adamatan/orgs", "received_events_url": "https://api.github.com/users/adamatan/received_events", "repos_url": "https://api.github.com/users/adamatan/repos", "site_admin": false, "starred_url": "https://api.github.com/users/adamatan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/adamatan/subscriptions", "type": "User", "url": "https://api.github.com/users/adamatan", "user_view_type": "public" }
[]
closed
true
null
[]
null
4
2015-09-18T11:58:19Z
2015-09-18T23:55:02Z
2015-09-18T23:54:57Z
NONE
null
# The problem I have been trying to make a GET request to https://service.isracard.co.il/I_logon.jsp using requests. The site seems to have a valid SSL certificate (see screenshots below), and cURL can get the content without a problem. However, requests fails to fetch the site with a `sslv3 alert handshake failure` error. # Notes - I have asked [a stackoverflow question about this problem](https://stackoverflow.com/questions/32650984/why-does-python-requests-ignore-the-verify-parameter) - The original problem happened when I was using mechanize, which uses `requests` internally. - The problem happens both on OSX and Ubuntu 14.04. - The same call worked for me a few months ago. I assume that the server side was somehow changed. - SSL connections to other sites (e.g. github) work fine. # Stack Trace ``` >>> import requests >>> LOGIN_URL = 'https://service.isracard.co.il/I_logon.jsp' >>> requests.get(LOGIN_URL) /tmp/blahenv/local/lib/python2.7/site-packages/requests/packages/urllib3/util/ssl_.py:90: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. For more information, see https://urllib3.readthedocs.org/en/latest/security.html#insecureplatformwarning. InsecurePlatformWarning Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/tmp/blahenv/local/lib/python2.7/site-packages/requests/api.py", line 69, in get return request('get', url, params=params, **kwargs) File "/tmp/blahenv/local/lib/python2.7/site-packages/requests/api.py", line 50, in request response = session.request(method=method, url=url, **kwargs) File "/tmp/blahenv/local/lib/python2.7/site-packages/requests/sessions.py", line 465, in request resp = self.send(prep, **send_kwargs) File "/tmp/blahenv/local/lib/python2.7/site-packages/requests/sessions.py", line 573, in send r = adapter.send(request, **kwargs) File "/tmp/blahenv/local/lib/python2.7/site-packages/requests/adapters.py", line 431, in send raise SSLError(e, request=request) requests.exceptions.SSLError: [Errno 1] _ssl.c:510: error:14077410:SSL routines:SSL23_GET_SERVER_HELLO:sslv3 alert handshake failure ``` # Certificate ![screen shot 2015-09-18 at 14 56 51](https://cloud.githubusercontent.com/assets/1014189/9958737/98ac65be-5e15-11e5-9229-c035c328ec64.png) ![screen shot 2015-09-18 at 14 23 51](https://cloud.githubusercontent.com/assets/1014189/9958744/a04e6574-5e15-11e5-8966-43a52c518daa.png)
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2778/reactions" }
https://api.github.com/repos/psf/requests/issues/2778/timeline
null
completed
null
null
false
[ "Have you tried the approach suggested in [this blog post](https://lukasa.co.uk/2013/01/Choosing_SSL_Version_In_Requests/)?\n", "So I took a quick look\n\n```\n$ openssl version\nOpenSSL 1.0.2d 9 Jul 2015\n$ openssl s_client -connect service.isracard.co.il:443 -no_ssl2 -no_ssl3 -no_tls1 -no_tls1_1\n# Works\n$ ope...
https://api.github.com/repos/psf/requests/issues/2777
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2777/labels{/name}
https://api.github.com/repos/psf/requests/issues/2777/comments
https://api.github.com/repos/psf/requests/issues/2777/events
https://github.com/psf/requests/issues/2777
106,957,516
MDU6SXNzdWUxMDY5NTc1MTY=
2,777
Withholding a post body in AuthBase until a security context has been established
{ "avatar_url": "https://avatars.githubusercontent.com/u/1713677?v=4", "events_url": "https://api.github.com/users/ianclegg/events{/privacy}", "followers_url": "https://api.github.com/users/ianclegg/followers", "following_url": "https://api.github.com/users/ianclegg/following{/other_user}", "gists_url": "https://api.github.com/users/ianclegg/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/ianclegg", "id": 1713677, "login": "ianclegg", "node_id": "MDQ6VXNlcjE3MTM2Nzc=", "organizations_url": "https://api.github.com/users/ianclegg/orgs", "received_events_url": "https://api.github.com/users/ianclegg/received_events", "repos_url": "https://api.github.com/users/ianclegg/repos", "site_admin": false, "starred_url": "https://api.github.com/users/ianclegg/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ianclegg/subscriptions", "type": "User", "url": "https://api.github.com/users/ianclegg", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2015-09-17T10:42:09Z
2021-09-08T22:00:48Z
2015-09-17T10:46:15Z
NONE
resolved
**Background** I'm working with a server which uses SPNEGO/GSS authentication, to keep it simple lets say the GSS mechanism is NTLM. As usual, the client and server exchange tokens to establish the context. What's different here is that once the context is established I want wrap (encrypt) the request body using the negotiated GSS context (in this case it would use NTLMv2 Session Security) and send it. The authentication and encryption is not a problem. I'm using AuthBase and a response hook to exchange the tokens in the authenticate header. **Problem** My AuthBase derived class is sending the plaintext request body every time during the token exchange. I only want to send it in its encrypted form on the final exchange. Looking at the PizzaAuth example on the Requests page: ``` python from requests.auth import AuthBase class PizzaAuth(AuthBase): """Attaches HTTP Pizza Authentication to the given Request object.""" def __init__(self, username): # setup any auth-related data here self.username = username def __call__(self, r): # !! = !! = !! = !! = !! = !! = !! = !! = !! = !! = !! = !! = # I want to manipulate the request body here and ensure the request # that is returned is empty, or is otherwise encrypted # !! = !! = !! = !! = !! = !! = !! = !! = !! = !! = !! = !! = r.headers['X-Pizza'] = self.username return r ``` If I change the request body to an empty string `r.body = ""` I find that the remote server does not respond. This is because I have changed the body, but the Content-Length header is not re-calculated, and so my empty request is sent with a non-zero content-length - leaving the server waiting for more bytes. Now, I can also set the Body and the Content-Length header to zero - and that seems to work. **Question** Is is safe to manipulate the request body in AuthBase, will this cause a memory leak or any quality problems? Is it safe to simply set the body to an empty string and set the Content-Length to 0 until my final response, and then simply set the body and set the right content length?
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2777/reactions" }
https://api.github.com/repos/psf/requests/issues/2777/timeline
null
completed
null
null
false
[ "Yes, it is safe to set the request body. This will not cause memory leaks because we do not have any reference deletion anywhere in requests' codebase. Leaking the reference to the body will be absolutely fine. Yes, it should be safe to simply set the body to an empty string and set the content-length appropriatel...
https://api.github.com/repos/psf/requests/issues/2776
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2776/labels{/name}
https://api.github.com/repos/psf/requests/issues/2776/comments
https://api.github.com/repos/psf/requests/issues/2776/events
https://github.com/psf/requests/issues/2776
106,265,260
MDU6SXNzdWUxMDYyNjUyNjA=
2,776
SSLError when use Pyinstaller
{ "avatar_url": "https://avatars.githubusercontent.com/u/1305553?v=4", "events_url": "https://api.github.com/users/zotix/events{/privacy}", "followers_url": "https://api.github.com/users/zotix/followers", "following_url": "https://api.github.com/users/zotix/following{/other_user}", "gists_url": "https://api.github.com/users/zotix/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/zotix", "id": 1305553, "login": "zotix", "node_id": "MDQ6VXNlcjEzMDU1NTM=", "organizations_url": "https://api.github.com/users/zotix/orgs", "received_events_url": "https://api.github.com/users/zotix/received_events", "repos_url": "https://api.github.com/users/zotix/repos", "site_admin": false, "starred_url": "https://api.github.com/users/zotix/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zotix/subscriptions", "type": "User", "url": "https://api.github.com/users/zotix", "user_view_type": "public" }
[]
closed
true
null
[]
null
3
2015-09-14T03:34:49Z
2021-09-08T15:00:41Z
2015-09-14T03:37:28Z
NONE
resolved
I try to mix my python desktop app to exe file. When execute without compiler is OK but EXE it show error as below ``` Exception in Tkinter callback Traceback (most recent call last): File "C:\try\build\main\out00-PYZ.pyz\Tkinter", line 1536, in __call__ File "<string>", line 154, in on_btn_download File "C:\try\build\main\out00-PYZ.pyz\usgsDownloader", line 57, in search File "C:\try\build\main\out00-PYZ.pyz\usgs.api", line 302, in search File "C:\try\build\main\out00-PYZ.pyz\requests.api", line 109, in post File "C:\try\build\main\out00-PYZ.pyz\requests.api", line 50, in request File "C:\try\build\main\out00-PYZ.pyz\requests.sessions", line 465, in request File "C:\try\build\main\out00-PYZ.pyz\requests.sessions", line 573, in send File "C:\try\build\main\out00-PYZ.pyz\requests.adapters", line 431, in send SSLError: [Errno 2] No such file or directory ``` Compile command ``` C:\try>pyinstaller -F --hidden-import=requests main.py ``` What should I fix it? thank
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2776/reactions" }
https://api.github.com/repos/psf/requests/issues/2776/timeline
null
completed
null
null
false
[ "This is not a bug in requests. This is a bug in PyInstaller since it doesn't know how to detect static package data (e.g., the certificate bundle that requests is packaged with).\n", "Thanks sigmavirus24 for giving a hint.\n\nFix this by http://stackoverflow.com/questions/21201238/twilio-python-module-errors-aft...
https://api.github.com/repos/psf/requests/issues/2775
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2775/labels{/name}
https://api.github.com/repos/psf/requests/issues/2775/comments
https://api.github.com/repos/psf/requests/issues/2775/events
https://github.com/psf/requests/pull/2775
106,209,319
MDExOlB1bGxSZXF1ZXN0NDQ4NzA2ODI=
2,775
Removed unused module from hooks.py
{ "avatar_url": "https://avatars.githubusercontent.com/u/3393794?v=4", "events_url": "https://api.github.com/users/ueg1990/events{/privacy}", "followers_url": "https://api.github.com/users/ueg1990/followers", "following_url": "https://api.github.com/users/ueg1990/following{/other_user}", "gists_url": "https://api.github.com/users/ueg1990/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/ueg1990", "id": 3393794, "login": "ueg1990", "node_id": "MDQ6VXNlcjMzOTM3OTQ=", "organizations_url": "https://api.github.com/users/ueg1990/orgs", "received_events_url": "https://api.github.com/users/ueg1990/received_events", "repos_url": "https://api.github.com/users/ueg1990/repos", "site_admin": false, "starred_url": "https://api.github.com/users/ueg1990/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ueg1990/subscriptions", "type": "User", "url": "https://api.github.com/users/ueg1990", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2015-09-13T10:36:42Z
2021-09-08T06:01:02Z
2015-09-13T12:26:05Z
CONTRIBUTOR
resolved
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2775/reactions" }
https://api.github.com/repos/psf/requests/issues/2775/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2775.diff", "html_url": "https://github.com/psf/requests/pull/2775", "merged_at": "2015-09-13T12:26:05Z", "patch_url": "https://github.com/psf/requests/pull/2775.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2775" }
true
[ "Thanks @ueg1990! :cake:\n", "You know someone's going to complain that they were using `hooks.defaultdict` now, right? ;)\n" ]
https://api.github.com/repos/psf/requests/issues/2774
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2774/labels{/name}
https://api.github.com/repos/psf/requests/issues/2774/comments
https://api.github.com/repos/psf/requests/issues/2774/events
https://github.com/psf/requests/pull/2774
106,192,661
MDExOlB1bGxSZXF1ZXN0NDQ4NjQyOTU=
2,774
Some pythonic suggestions for requests/hooks.py
{ "avatar_url": "https://avatars.githubusercontent.com/u/3393794?v=4", "events_url": "https://api.github.com/users/ueg1990/events{/privacy}", "followers_url": "https://api.github.com/users/ueg1990/followers", "following_url": "https://api.github.com/users/ueg1990/following{/other_user}", "gists_url": "https://api.github.com/users/ueg1990/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/ueg1990", "id": 3393794, "login": "ueg1990", "node_id": "MDQ6VXNlcjMzOTM3OTQ=", "organizations_url": "https://api.github.com/users/ueg1990/orgs", "received_events_url": "https://api.github.com/users/ueg1990/received_events", "repos_url": "https://api.github.com/users/ueg1990/repos", "site_admin": false, "starred_url": "https://api.github.com/users/ueg1990/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ueg1990/subscriptions", "type": "User", "url": "https://api.github.com/users/ueg1990", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2015-09-13T00:42:11Z
2021-09-08T06:01:02Z
2015-09-13T05:05:34Z
CONTRIBUTOR
resolved
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2774/reactions" }
https://api.github.com/repos/psf/requests/issues/2774/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2774.diff", "html_url": "https://github.com/psf/requests/pull/2774", "merged_at": "2015-09-13T05:05:34Z", "patch_url": "https://github.com/psf/requests/pull/2774.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2774" }
true
[ "these look pretty good to me! :sparkles: :cake: :sparkles:\n" ]
https://api.github.com/repos/psf/requests/issues/2773
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2773/labels{/name}
https://api.github.com/repos/psf/requests/issues/2773/comments
https://api.github.com/repos/psf/requests/issues/2773/events
https://github.com/psf/requests/issues/2773
106,176,479
MDU6SXNzdWUxMDYxNzY0Nzk=
2,773
option to disable .netrc
{ "avatar_url": "https://avatars.githubusercontent.com/u/141546?v=4", "events_url": "https://api.github.com/users/jwilk/events{/privacy}", "followers_url": "https://api.github.com/users/jwilk/followers", "following_url": "https://api.github.com/users/jwilk/following{/other_user}", "gists_url": "https://api.github.com/users/jwilk/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/jwilk", "id": 141546, "login": "jwilk", "node_id": "MDQ6VXNlcjE0MTU0Ng==", "organizations_url": "https://api.github.com/users/jwilk/orgs", "received_events_url": "https://api.github.com/users/jwilk/received_events", "repos_url": "https://api.github.com/users/jwilk/repos", "site_admin": false, "starred_url": "https://api.github.com/users/jwilk/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jwilk/subscriptions", "type": "User", "url": "https://api.github.com/users/jwilk", "user_view_type": "public" }
[]
closed
true
null
[]
null
16
2015-09-12T18:12:09Z
2021-09-08T07:00:24Z
2017-09-01T09:54:41Z
CONTRIBUTOR
resolved
I don't want my applications to read `.netrc` files, because they are [inherently insecure](http://jwilk.net/blog/20131104-netrc-security). I know there's (undocumented) `trust_env=False`, but it also turns off support for `*_proxy` environment variables. Please add a separate option to disable `.netrc` support.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2773/reactions" }
https://api.github.com/repos/psf/requests/issues/2773/timeline
null
completed
null
null
false
[ "@jwilk This is certainly a thing we could do. However, it's a bizarrely application specific fix that will not actually help in a lot of cases because applications that use requests will need to opt-in to that functionality. This means they need to know enough to do that, which is not likely.\n\nReally from a secu...
https://api.github.com/repos/psf/requests/issues/2772
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2772/labels{/name}
https://api.github.com/repos/psf/requests/issues/2772/comments
https://api.github.com/repos/psf/requests/issues/2772/events
https://github.com/psf/requests/pull/2772
106,061,121
MDExOlB1bGxSZXF1ZXN0NDQ4MTA2NzU=
2,772
Move CA Certificates documentation next to SSL Cert Verification
{ "avatar_url": "https://avatars.githubusercontent.com/u/240575?v=4", "events_url": "https://api.github.com/users/jimbrowne/events{/privacy}", "followers_url": "https://api.github.com/users/jimbrowne/followers", "following_url": "https://api.github.com/users/jimbrowne/following{/other_user}", "gists_url": "https://api.github.com/users/jimbrowne/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/jimbrowne", "id": 240575, "login": "jimbrowne", "node_id": "MDQ6VXNlcjI0MDU3NQ==", "organizations_url": "https://api.github.com/users/jimbrowne/orgs", "received_events_url": "https://api.github.com/users/jimbrowne/received_events", "repos_url": "https://api.github.com/users/jimbrowne/repos", "site_admin": false, "starred_url": "https://api.github.com/users/jimbrowne/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jimbrowne/subscriptions", "type": "User", "url": "https://api.github.com/users/jimbrowne", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2015-09-11T17:56:06Z
2021-09-08T06:01:02Z
2015-09-11T19:22:13Z
CONTRIBUTOR
resolved
When reading the SSL Cert Verification documentation and working on directing requests to use a system's local CA store I never noticed the CA Certificates documentation as it is at the tail end of the Advanced page. I suggest it would be better to have the CA Certificates documentation immediately follow the documentation regarding SSL Cert Verification. No content change, just a relocation of existing verbiage.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2772/reactions" }
https://api.github.com/repos/psf/requests/issues/2772/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2772.diff", "html_url": "https://github.com/psf/requests/pull/2772", "merged_at": "2015-09-11T19:22:13Z", "patch_url": "https://github.com/psf/requests/pull/2772.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2772" }
true
[ "Thanks @jimbrowne! :cake: :sparkles: :cake:\n" ]
https://api.github.com/repos/psf/requests/issues/2771
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2771/labels{/name}
https://api.github.com/repos/psf/requests/issues/2771/comments
https://api.github.com/repos/psf/requests/issues/2771/events
https://github.com/psf/requests/issues/2771
106,038,732
MDU6SXNzdWUxMDYwMzg3MzI=
2,771
Please add absolute_import at the beginning of every file
{ "avatar_url": "https://avatars.githubusercontent.com/u/860977?v=4", "events_url": "https://api.github.com/users/co-dh/events{/privacy}", "followers_url": "https://api.github.com/users/co-dh/followers", "following_url": "https://api.github.com/users/co-dh/following{/other_user}", "gists_url": "https://api.github.com/users/co-dh/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/co-dh", "id": 860977, "login": "co-dh", "node_id": "MDQ6VXNlcjg2MDk3Nw==", "organizations_url": "https://api.github.com/users/co-dh/orgs", "received_events_url": "https://api.github.com/users/co-dh/received_events", "repos_url": "https://api.github.com/users/co-dh/repos", "site_admin": false, "starred_url": "https://api.github.com/users/co-dh/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/co-dh/subscriptions", "type": "User", "url": "https://api.github.com/users/co-dh", "user_view_type": "public" }
[]
closed
true
null
[]
null
13
2015-09-11T15:53:01Z
2021-09-08T19:00:37Z
2016-01-25T23:05:56Z
NONE
resolved
I have an import warning: ``` site-packages/requests/utils.py:17: ImportWarning: Not importing directory '/home/x/platform' missing __init__.py import platform ``` so my directory: platform hided system module platform.py This can only be fixed by adding `from __future__ import absolute_import` at the first line of utils.py Also it would be nice to have this for every module. This should do no harm to python 3.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2771/reactions" }
https://api.github.com/repos/psf/requests/issues/2771/timeline
null
completed
null
null
false
[ "This is not a totally unreasonable thing to do, though it's totally tragic that we need it: if we didn't support Python 2.6 this wouldn't be a problem. @sigmavirus24?\n", "So I have done this before to debug other problems. The major issue is that it doesn't protect urllib3 so if someone shadows another standard...
https://api.github.com/repos/psf/requests/issues/2770
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2770/labels{/name}
https://api.github.com/repos/psf/requests/issues/2770/comments
https://api.github.com/repos/psf/requests/issues/2770/events
https://github.com/psf/requests/pull/2770
105,944,115
MDExOlB1bGxSZXF1ZXN0NDQ3NDYxNzk=
2,770
Use context manager for Session
{ "avatar_url": "https://avatars.githubusercontent.com/u/3393794?v=4", "events_url": "https://api.github.com/users/ueg1990/events{/privacy}", "followers_url": "https://api.github.com/users/ueg1990/followers", "following_url": "https://api.github.com/users/ueg1990/following{/other_user}", "gists_url": "https://api.github.com/users/ueg1990/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/ueg1990", "id": 3393794, "login": "ueg1990", "node_id": "MDQ6VXNlcjMzOTM3OTQ=", "organizations_url": "https://api.github.com/users/ueg1990/orgs", "received_events_url": "https://api.github.com/users/ueg1990/received_events", "repos_url": "https://api.github.com/users/ueg1990/repos", "site_admin": false, "starred_url": "https://api.github.com/users/ueg1990/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ueg1990/subscriptions", "type": "User", "url": "https://api.github.com/users/ueg1990", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2015-09-11T04:42:27Z
2021-09-08T06:01:03Z
2015-09-11T06:15:28Z
CONTRIBUTOR
resolved
Since a context manager is defined for session, i thought it would be better (and more pythonic) to use it. All the tests passed. Let me know what you guys think
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2770/reactions" }
https://api.github.com/repos/psf/requests/issues/2770/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2770.diff", "html_url": "https://github.com/psf/requests/pull/2770", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/2770.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2770" }
true
[ "I'm afraid we actually don't want this.\n\nThe use-case is extremely uncommon, but it's possible that if an exception is hit during request processing that a user may want to keep hold of state from the connection pool or urllib3 layer. Using the context manager potentially prevents that by forcing the Session clo...
https://api.github.com/repos/psf/requests/issues/2769
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2769/labels{/name}
https://api.github.com/repos/psf/requests/issues/2769/comments
https://api.github.com/repos/psf/requests/issues/2769/events
https://github.com/psf/requests/pull/2769
105,894,643
MDExOlB1bGxSZXF1ZXN0NDQ3MTc0MTg=
2,769
docs: Fix typos
{ "avatar_url": "https://avatars.githubusercontent.com/u/141546?v=4", "events_url": "https://api.github.com/users/jwilk/events{/privacy}", "followers_url": "https://api.github.com/users/jwilk/followers", "following_url": "https://api.github.com/users/jwilk/following{/other_user}", "gists_url": "https://api.github.com/users/jwilk/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/jwilk", "id": 141546, "login": "jwilk", "node_id": "MDQ6VXNlcjE0MTU0Ng==", "organizations_url": "https://api.github.com/users/jwilk/orgs", "received_events_url": "https://api.github.com/users/jwilk/received_events", "repos_url": "https://api.github.com/users/jwilk/repos", "site_admin": false, "starred_url": "https://api.github.com/users/jwilk/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jwilk/subscriptions", "type": "User", "url": "https://api.github.com/users/jwilk", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2015-09-10T20:48:37Z
2021-09-08T06:00:51Z
2015-09-10T21:14:11Z
CONTRIBUTOR
resolved
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2769/reactions" }
https://api.github.com/repos/psf/requests/issues/2769/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2769.diff", "html_url": "https://github.com/psf/requests/pull/2769", "merged_at": "2015-09-10T21:14:11Z", "patch_url": "https://github.com/psf/requests/pull/2769.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2769" }
true
[ "Thanks @jwilk! :cake: :sparkles: :cake:\n" ]
https://api.github.com/repos/psf/requests/issues/2768
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2768/labels{/name}
https://api.github.com/repos/psf/requests/issues/2768/comments
https://api.github.com/repos/psf/requests/issues/2768/events
https://github.com/psf/requests/pull/2768
105,891,152
MDExOlB1bGxSZXF1ZXN0NDQ3MTQ5OTk=
2,768
Replace hardcoded class with dunder class attribute
{ "avatar_url": "https://avatars.githubusercontent.com/u/3393794?v=4", "events_url": "https://api.github.com/users/ueg1990/events{/privacy}", "followers_url": "https://api.github.com/users/ueg1990/followers", "following_url": "https://api.github.com/users/ueg1990/following{/other_user}", "gists_url": "https://api.github.com/users/ueg1990/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/ueg1990", "id": 3393794, "login": "ueg1990", "node_id": "MDQ6VXNlcjMzOTM3OTQ=", "organizations_url": "https://api.github.com/users/ueg1990/orgs", "received_events_url": "https://api.github.com/users/ueg1990/received_events", "repos_url": "https://api.github.com/users/ueg1990/repos", "site_admin": false, "starred_url": "https://api.github.com/users/ueg1990/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ueg1990/subscriptions", "type": "User", "url": "https://api.github.com/users/ueg1990", "user_view_type": "public" }
[]
closed
true
null
[]
null
6
2015-09-10T20:26:51Z
2021-09-08T06:01:03Z
2015-09-10T22:01:59Z
CONTRIBUTOR
resolved
Small suggestion as this was something I heard in Raymond Hettinger's talk at PyCon 2015
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2768/reactions" }
https://api.github.com/repos/psf/requests/issues/2768/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2768.diff", "html_url": "https://github.com/psf/requests/pull/2768", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/2768.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2768" }
true
[ "Btw if this is accepted, i can do it for the other modules/python files...in that way i can also read some of the requests code :stuck_out_tongue: \n", "I certainly want the change in `super` removed: as pointed out in the diff comment by @jmoldow, that isn't valid. Otherwise, I suspect it makes the class somewh...
https://api.github.com/repos/psf/requests/issues/2767
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2767/labels{/name}
https://api.github.com/repos/psf/requests/issues/2767/comments
https://api.github.com/repos/psf/requests/issues/2767/events
https://github.com/psf/requests/pull/2767
105,852,961
MDExOlB1bGxSZXF1ZXN0NDQ2OTMwMTk=
2,767
Remove redundant function call list when iterating over status codes
{ "avatar_url": "https://avatars.githubusercontent.com/u/3393794?v=4", "events_url": "https://api.github.com/users/ueg1990/events{/privacy}", "followers_url": "https://api.github.com/users/ueg1990/followers", "following_url": "https://api.github.com/users/ueg1990/following{/other_user}", "gists_url": "https://api.github.com/users/ueg1990/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/ueg1990", "id": 3393794, "login": "ueg1990", "node_id": "MDQ6VXNlcjMzOTM3OTQ=", "organizations_url": "https://api.github.com/users/ueg1990/orgs", "received_events_url": "https://api.github.com/users/ueg1990/received_events", "repos_url": "https://api.github.com/users/ueg1990/repos", "site_admin": false, "starred_url": "https://api.github.com/users/ueg1990/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ueg1990/subscriptions", "type": "User", "url": "https://api.github.com/users/ueg1990", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2015-09-10T17:01:47Z
2021-09-08T06:01:04Z
2015-09-10T17:38:25Z
CONTRIBUTOR
resolved
Refer to issue [2765](https://github.com/kennethreitz/requests/issues/2765)
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2767/reactions" }
https://api.github.com/repos/psf/requests/issues/2767/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2767.diff", "html_url": "https://github.com/psf/requests/pull/2767", "merged_at": "2015-09-10T17:38:25Z", "patch_url": "https://github.com/psf/requests/pull/2767.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2767" }
true
[ "yay!!! :D\n", "Thanks @ueg1990! :cake: :sparkles: :cake:\n" ]
https://api.github.com/repos/psf/requests/issues/2766
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2766/labels{/name}
https://api.github.com/repos/psf/requests/issues/2766/comments
https://api.github.com/repos/psf/requests/issues/2766/events
https://github.com/psf/requests/issues/2766
105,808,876
MDU6SXNzdWUxMDU4MDg4NzY=
2,766
Document threading contract for Session class
{ "avatar_url": "https://avatars.githubusercontent.com/u/51437?v=4", "events_url": "https://api.github.com/users/gward/events{/privacy}", "followers_url": "https://api.github.com/users/gward/followers", "following_url": "https://api.github.com/users/gward/following{/other_user}", "gists_url": "https://api.github.com/users/gward/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/gward", "id": 51437, "login": "gward", "node_id": "MDQ6VXNlcjUxNDM3", "organizations_url": "https://api.github.com/users/gward/orgs", "received_events_url": "https://api.github.com/users/gward/received_events", "repos_url": "https://api.github.com/users/gward/repos", "site_admin": false, "starred_url": "https://api.github.com/users/gward/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gward/subscriptions", "type": "User", "url": "https://api.github.com/users/gward", "user_view_type": "public" }
[ { "color": "fad8c7", "default": false, "description": null, "id": 136616769, "name": "Documentation", "node_id": "MDU6TGFiZWwxMzY2MTY3Njk=", "url": "https://api.github.com/repos/psf/requests/labels/Documentation" } ]
closed
false
null
[]
null
13
2015-09-10T13:44:25Z
2024-11-06T16:38:06Z
2024-05-19T18:38:20Z
NONE
null
Right now, it's quite difficult to figure out if the Session class is threadsafe or not. The docs don't say, apart from a "thread-safe" bullet on the home page. Google led me to http://stackoverflow.com/questions/18188044/is-the-session-object-from-pythons-requests-library-thread-safe, whose first answer boils down to "be very careful". Inspired by that SO author, I've been auditing the code myself, and have come to the conclusion that Session is probably not threadsafe. (The use of `self.redirect_cache` set off red flags for me.) Reading through other requests bug reports, I see maintainers recommending one Session per thread, which implies that it's not threadsafe. The documentation should clarify this and recommend how to use Session in multithreaded programs. Possible text: ``` Session is not threadsafe. If you are using requests with an explicit Session object in a multithreaded program, you should create one Session per thread. ``` If that's accurate, let me know and I'll submit a PR. Also, I think the "thread-safe" bullet should be removed from the home page, or maybe replaced by "thread-safe in certain circumstances".
{ "avatar_url": "https://avatars.githubusercontent.com/u/18519037?v=4", "events_url": "https://api.github.com/users/sethmlarson/events{/privacy}", "followers_url": "https://api.github.com/users/sethmlarson/followers", "following_url": "https://api.github.com/users/sethmlarson/following{/other_user}", "gists_url": "https://api.github.com/users/sethmlarson/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sethmlarson", "id": 18519037, "login": "sethmlarson", "node_id": "MDQ6VXNlcjE4NTE5MDM3", "organizations_url": "https://api.github.com/users/sethmlarson/orgs", "received_events_url": "https://api.github.com/users/sethmlarson/received_events", "repos_url": "https://api.github.com/users/sethmlarson/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sethmlarson/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sethmlarson/subscriptions", "type": "User", "url": "https://api.github.com/users/sethmlarson", "user_view_type": "public" }
{ "+1": 73, "-1": 0, "confused": 0, "eyes": 0, "heart": 8, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 81, "url": "https://api.github.com/repos/psf/requests/issues/2766/reactions" }
https://api.github.com/repos/psf/requests/issues/2766/timeline
null
completed
null
null
false
[ "Why do you think the redirect cache is not threadsafe?\n", "I'd go further: I think the redirect cache is a bad idea. I still think that.\n\nI think re-adding thread-safety would be a good idea. We can get away with it, I think, by locking around the CookieJar (which should be the only other thing that is a risk...
https://api.github.com/repos/psf/requests/issues/2765
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2765/labels{/name}
https://api.github.com/repos/psf/requests/issues/2765/comments
https://api.github.com/repos/psf/requests/issues/2765/events
https://github.com/psf/requests/issues/2765
105,736,737
MDU6SXNzdWUxMDU3MzY3Mzc=
2,765
Redundant creation of list?
{ "avatar_url": "https://avatars.githubusercontent.com/u/3393794?v=4", "events_url": "https://api.github.com/users/ueg1990/events{/privacy}", "followers_url": "https://api.github.com/users/ueg1990/followers", "following_url": "https://api.github.com/users/ueg1990/following{/other_user}", "gists_url": "https://api.github.com/users/ueg1990/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/ueg1990", "id": 3393794, "login": "ueg1990", "node_id": "MDQ6VXNlcjMzOTM3OTQ=", "organizations_url": "https://api.github.com/users/ueg1990/orgs", "received_events_url": "https://api.github.com/users/ueg1990/received_events", "repos_url": "https://api.github.com/users/ueg1990/repos", "site_admin": false, "starred_url": "https://api.github.com/users/ueg1990/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ueg1990/subscriptions", "type": "User", "url": "https://api.github.com/users/ueg1990", "user_view_type": "public" }
[]
closed
true
null
[]
null
5
2015-09-10T05:51:42Z
2021-09-08T22:00:49Z
2015-09-10T18:05:36Z
CONTRIBUTOR
resolved
Hello, I came across this code under status_codes.py: for (code, titles) in list(_codes.items()): for title in titles: setattr(codes, title, code) if not title.startswith('\'): setattr(codes, title.upper(), code) in the first line (the outermost loop), i think the list(_codes.items()) step is redundant. it should just be iterating over _codes.items(). what i am not sure is if the items method here returns a list (python 2) or an iterator/generator (python 3). if its the former, maybe its better to loop over _codes.iteritems(). In either case, you do not really need to convert it to a list. Though this is a very small issue, if its worth doing a PR, I can do it. (in that way, i can contribute my first PR to the requests library :) )
{ "avatar_url": "https://avatars.githubusercontent.com/u/3393794?v=4", "events_url": "https://api.github.com/users/ueg1990/events{/privacy}", "followers_url": "https://api.github.com/users/ueg1990/followers", "following_url": "https://api.github.com/users/ueg1990/following{/other_user}", "gists_url": "https://api.github.com/users/ueg1990/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/ueg1990", "id": 3393794, "login": "ueg1990", "node_id": "MDQ6VXNlcjMzOTM3OTQ=", "organizations_url": "https://api.github.com/users/ueg1990/orgs", "received_events_url": "https://api.github.com/users/ueg1990/received_events", "repos_url": "https://api.github.com/users/ueg1990/repos", "site_admin": false, "starred_url": "https://api.github.com/users/ueg1990/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ueg1990/subscriptions", "type": "User", "url": "https://api.github.com/users/ueg1990", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2765/reactions" }
https://api.github.com/repos/psf/requests/issues/2765/timeline
null
completed
null
null
false
[ "Thanks @ueg1990! I think you're right: feel free to provide a pull request. =)\n", "## To be clear: please do not use iteritems. Just remove the use of list()\n\nSent from my Android device with K-9 Mail. Please excuse my brevity.\n", "I will send the pull request today. But i am curious, why should we not use...
https://api.github.com/repos/psf/requests/issues/2764
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2764/labels{/name}
https://api.github.com/repos/psf/requests/issues/2764/comments
https://api.github.com/repos/psf/requests/issues/2764/events
https://github.com/psf/requests/pull/2764
105,497,251
MDExOlB1bGxSZXF1ZXN0NDQ1MDA2MjE=
2,764
minor refactoring to function
{ "avatar_url": "https://avatars.githubusercontent.com/u/6500837?v=4", "events_url": "https://api.github.com/users/suhussai/events{/privacy}", "followers_url": "https://api.github.com/users/suhussai/followers", "following_url": "https://api.github.com/users/suhussai/following{/other_user}", "gists_url": "https://api.github.com/users/suhussai/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/suhussai", "id": 6500837, "login": "suhussai", "node_id": "MDQ6VXNlcjY1MDA4Mzc=", "organizations_url": "https://api.github.com/users/suhussai/orgs", "received_events_url": "https://api.github.com/users/suhussai/received_events", "repos_url": "https://api.github.com/users/suhussai/repos", "site_admin": false, "starred_url": "https://api.github.com/users/suhussai/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/suhussai/subscriptions", "type": "User", "url": "https://api.github.com/users/suhussai", "user_view_type": "public" }
[]
closed
true
null
[]
null
4
2015-09-09T01:05:06Z
2021-09-08T06:01:06Z
2015-09-09T01:13:32Z
NONE
resolved
I was just looking through the code base and noticed this small "improvement" I could make. Is the focus more on readability or is this kind of refactoring acceptable as well? I understand that this format does decrease readability a little bit, so I didn't look into it too much, thought I'd get feedback first.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2764/reactions" }
https://api.github.com/repos/psf/requests/issues/2764/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2764.diff", "html_url": "https://github.com/psf/requests/pull/2764", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/2764.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2764" }
true
[ "Dictionary comprehensions were introduced in Python 2.7. Prior to that they are invalid syntax, e.g., for Python 2.5 and 2.6, both of which are supported versions for ~~pep8~~ requests. \n\nThanks for contributing though @suhussai!\n\nPerhaps you could look through the bugs and find one that doesn't have a linked ...
https://api.github.com/repos/psf/requests/issues/2763
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2763/labels{/name}
https://api.github.com/repos/psf/requests/issues/2763/comments
https://api.github.com/repos/psf/requests/issues/2763/events
https://github.com/psf/requests/pull/2763
105,337,897
MDExOlB1bGxSZXF1ZXN0NDQ0MDkzNzg=
2,763
Fixed issue #2756
{ "avatar_url": "https://avatars.githubusercontent.com/u/4507088?v=4", "events_url": "https://api.github.com/users/ravipra/events{/privacy}", "followers_url": "https://api.github.com/users/ravipra/followers", "following_url": "https://api.github.com/users/ravipra/following{/other_user}", "gists_url": "https://api.github.com/users/ravipra/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/ravipra", "id": 4507088, "login": "ravipra", "node_id": "MDQ6VXNlcjQ1MDcwODg=", "organizations_url": "https://api.github.com/users/ravipra/orgs", "received_events_url": "https://api.github.com/users/ravipra/received_events", "repos_url": "https://api.github.com/users/ravipra/repos", "site_admin": false, "starred_url": "https://api.github.com/users/ravipra/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ravipra/subscriptions", "type": "User", "url": "https://api.github.com/users/ravipra", "user_view_type": "public" }
[]
closed
true
null
[]
null
8
2015-09-08T09:19:51Z
2021-09-08T05:01:00Z
2015-10-05T14:27:53Z
NONE
resolved
Now 'json' parameter will be used to prepare body only if the 'data' parameter is not present
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2763/reactions" }
https://api.github.com/repos/psf/requests/issues/2763/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2763.diff", "html_url": "https://github.com/psf/requests/pull/2763", "merged_at": "2015-10-05T14:27:53Z", "patch_url": "https://github.com/psf/requests/pull/2763.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2763" }
true
[ "One minor comment, otherwise I'm fine. =)\n", "With `if data is None` I get the following test failure. Please advice.\n\n```\n|======================================================================\nERROR: test_json_param_post_content_type_works (__main__.RequestsTestCase)\n-------------------------------------...
https://api.github.com/repos/psf/requests/issues/2762
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2762/labels{/name}
https://api.github.com/repos/psf/requests/issues/2762/comments
https://api.github.com/repos/psf/requests/issues/2762/events
https://github.com/psf/requests/issues/2762
105,288,881
MDU6SXNzdWUxMDUyODg4ODE=
2,762
Post requests to more complex HTML elements
{ "avatar_url": "https://avatars.githubusercontent.com/u/11060902?v=4", "events_url": "https://api.github.com/users/aewhatley/events{/privacy}", "followers_url": "https://api.github.com/users/aewhatley/followers", "following_url": "https://api.github.com/users/aewhatley/following{/other_user}", "gists_url": "https://api.github.com/users/aewhatley/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/aewhatley", "id": 11060902, "login": "aewhatley", "node_id": "MDQ6VXNlcjExMDYwOTAy", "organizations_url": "https://api.github.com/users/aewhatley/orgs", "received_events_url": "https://api.github.com/users/aewhatley/received_events", "repos_url": "https://api.github.com/users/aewhatley/repos", "site_admin": false, "starred_url": "https://api.github.com/users/aewhatley/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/aewhatley/subscriptions", "type": "User", "url": "https://api.github.com/users/aewhatley", "user_view_type": "public" }
[]
closed
true
null
[]
null
5
2015-09-08T02:35:16Z
2021-09-08T22:00:49Z
2015-09-08T03:39:42Z
NONE
resolved
Does the requests module support post requests to more complex HTML elements where values cannot be accessed just by dictionary lookup? For example, say we have the following HTML code, which is present on most Wikipedia pages to support the text of the article: </div><textarea tabindex="1" accesskey="," id="wpTextbox1" cols="80" rows="25" style="" lang="en" dir="ltr" name="wpTextbox1"> (body of the article) </textarea><div class='editOptions'> Is there a way to access the part that says (body of the article) using the requests API, and post to it? I tried 'wpTextbox1' : '' in the dictionary, but this did not work.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2762/reactions" }
https://api.github.com/repos/psf/requests/issues/2762/timeline
null
completed
null
null
false
[ "Sorry, the HTML headers got messed up by the Github reply form, and I'm not sure how to post them to this page.\n", "Here's a link to my Stackoverflow post of the same question, which has gotten not substantial replies: http://stackoverflow.com/questions/32447809/use-python-requests-to-access-mediawiki-text\n", ...
https://api.github.com/repos/psf/requests/issues/2761
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2761/labels{/name}
https://api.github.com/repos/psf/requests/issues/2761/comments
https://api.github.com/repos/psf/requests/issues/2761/events
https://github.com/psf/requests/pull/2761
105,248,284
MDExOlB1bGxSZXF1ZXN0NDQzNzE5NDQ=
2,761
Fix for Json supersedes data in prepare_body #2756
{ "avatar_url": "https://avatars.githubusercontent.com/u/4507088?v=4", "events_url": "https://api.github.com/users/ravipra/events{/privacy}", "followers_url": "https://api.github.com/users/ravipra/followers", "following_url": "https://api.github.com/users/ravipra/following{/other_user}", "gists_url": "https://api.github.com/users/ravipra/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/ravipra", "id": 4507088, "login": "ravipra", "node_id": "MDQ6VXNlcjQ1MDcwODg=", "organizations_url": "https://api.github.com/users/ravipra/orgs", "received_events_url": "https://api.github.com/users/ravipra/received_events", "repos_url": "https://api.github.com/users/ravipra/repos", "site_admin": false, "starred_url": "https://api.github.com/users/ravipra/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ravipra/subscriptions", "type": "User", "url": "https://api.github.com/users/ravipra", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2015-09-07T17:12:31Z
2021-09-08T06:01:06Z
2015-09-07T17:16:38Z
NONE
resolved
Now json will be attached to the body only if data is not present. (I hope the fix is not more complicated than this.)
{ "avatar_url": "https://avatars.githubusercontent.com/u/4507088?v=4", "events_url": "https://api.github.com/users/ravipra/events{/privacy}", "followers_url": "https://api.github.com/users/ravipra/followers", "following_url": "https://api.github.com/users/ravipra/following{/other_user}", "gists_url": "https://api.github.com/users/ravipra/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/ravipra", "id": 4507088, "login": "ravipra", "node_id": "MDQ6VXNlcjQ1MDcwODg=", "organizations_url": "https://api.github.com/users/ravipra/orgs", "received_events_url": "https://api.github.com/users/ravipra/received_events", "repos_url": "https://api.github.com/users/ravipra/repos", "site_admin": false, "starred_url": "https://api.github.com/users/ravipra/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ravipra/subscriptions", "type": "User", "url": "https://api.github.com/users/ravipra", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2761/reactions" }
https://api.github.com/repos/psf/requests/issues/2761/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2761.diff", "html_url": "https://github.com/psf/requests/pull/2761", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/2761.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2761" }
true
[ "Tests are failing. Will figure out how to run the tests, fix it and will resubmit. Apologies for the trouble!\n" ]
https://api.github.com/repos/psf/requests/issues/2760
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2760/labels{/name}
https://api.github.com/repos/psf/requests/issues/2760/comments
https://api.github.com/repos/psf/requests/issues/2760/events
https://github.com/psf/requests/issues/2760
105,241,572
MDU6SXNzdWUxMDUyNDE1NzI=
2,760
Log in to Wikipedia not working
{ "avatar_url": "https://avatars.githubusercontent.com/u/11060902?v=4", "events_url": "https://api.github.com/users/aewhatley/events{/privacy}", "followers_url": "https://api.github.com/users/aewhatley/followers", "following_url": "https://api.github.com/users/aewhatley/following{/other_user}", "gists_url": "https://api.github.com/users/aewhatley/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/aewhatley", "id": 11060902, "login": "aewhatley", "node_id": "MDQ6VXNlcjExMDYwOTAy", "organizations_url": "https://api.github.com/users/aewhatley/orgs", "received_events_url": "https://api.github.com/users/aewhatley/received_events", "repos_url": "https://api.github.com/users/aewhatley/repos", "site_admin": false, "starred_url": "https://api.github.com/users/aewhatley/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/aewhatley/subscriptions", "type": "User", "url": "https://api.github.com/users/aewhatley", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2015-09-07T16:06:15Z
2021-09-08T22:00:50Z
2015-09-07T16:17:31Z
NONE
resolved
I'm trying to log into Wikipedia using the following code: import requests s = requests.Session() url = 'https://en.wikipedia.org/w/index.php?title=Special:UserLogin&returnto=Main+Page' values = {'wpName' : '.....', 'wpPassword' : '.....'} s.get(url) req = s.post(url, values) print(req.cookies) print(req.url) However, it does not work. The req.url is the same as the login page (https://en.wikipedia.org/w/index.php?title=Special:UserLogin&returnto=Main+Page), and the cookie jar is empty. Does the MediaWiki software block the requests module, or am I doing something wrong?
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2760/reactions" }
https://api.github.com/repos/psf/requests/issues/2760/timeline
null
completed
null
null
false
[ "Your URL is wrong.\n\nPlease open the page in your browser and enable your browser developer tools, and then try the login yourself. You'll note that the POST target is actually `https://en.wikipedia.org/w/index.php?title=Special:UserLogin&action=submitlogin&type=login&returnto=Main+Page`, not the URL you used (wh...
https://api.github.com/repos/psf/requests/issues/2759
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2759/labels{/name}
https://api.github.com/repos/psf/requests/issues/2759/comments
https://api.github.com/repos/psf/requests/issues/2759/events
https://github.com/psf/requests/issues/2759
105,102,996
MDU6SXNzdWUxMDUxMDI5OTY=
2,759
python3: does not un-gzip replies
{ "avatar_url": "https://avatars.githubusercontent.com/u/236571?v=4", "events_url": "https://api.github.com/users/smurfix/events{/privacy}", "followers_url": "https://api.github.com/users/smurfix/followers", "following_url": "https://api.github.com/users/smurfix/following{/other_user}", "gists_url": "https://api.github.com/users/smurfix/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/smurfix", "id": 236571, "login": "smurfix", "node_id": "MDQ6VXNlcjIzNjU3MQ==", "organizations_url": "https://api.github.com/users/smurfix/orgs", "received_events_url": "https://api.github.com/users/smurfix/received_events", "repos_url": "https://api.github.com/users/smurfix/repos", "site_admin": false, "starred_url": "https://api.github.com/users/smurfix/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/smurfix/subscriptions", "type": "User", "url": "https://api.github.com/users/smurfix", "user_view_type": "public" }
[]
closed
true
null
[]
null
4
2015-09-06T16:37:11Z
2021-09-08T22:00:50Z
2015-09-08T07:33:35Z
NONE
resolved
It seems that (at least) a 403 response with gzipped body is expanded when running Python2, but not so with Py3. ``` desk ~/src/librssreader$ python run.py AppId required! Contact app developer. See http://www.inoreader.com/developers [ traceback because of unrelated missing error check ] desk ~/src/librssreader$ python3 run.py [[[ binary gibberish ]]] [ same traceback ] desk ~/src/librssreader$ ``` run.py is simply: ``` #!/usr/bin/python3 from librssreader.inoreader import RssReader, ClientAuthMethod auth = ClientAuthMethod('USERNAME','CENSORED') reader = RssReader(auth) print(reader.getUserInfo()) ``` You need to register with inoreader.com (or find another web server) before testing this.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2759/reactions" }
https://api.github.com/repos/psf/requests/issues/2759/timeline
null
completed
null
null
false
[ "Requests has no logic relating to response code that should affect whether or not the body of the request is expanded. If you read the content, you should get the gzip expanded. My money is that the 403 response does not include a Content-Encoding header. Can you show me the request/response please (sanitising sec...
https://api.github.com/repos/psf/requests/issues/2758
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2758/labels{/name}
https://api.github.com/repos/psf/requests/issues/2758/comments
https://api.github.com/repos/psf/requests/issues/2758/events
https://github.com/psf/requests/pull/2758
105,018,377
MDExOlB1bGxSZXF1ZXN0NDQyODAyODQ=
2,758
Fix RFC Quotation
{ "avatar_url": "https://avatars.githubusercontent.com/u/1019198?v=4", "events_url": "https://api.github.com/users/mhils/events{/privacy}", "followers_url": "https://api.github.com/users/mhils/followers", "following_url": "https://api.github.com/users/mhils/following{/other_user}", "gists_url": "https://api.github.com/users/mhils/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/mhils", "id": 1019198, "login": "mhils", "node_id": "MDQ6VXNlcjEwMTkxOTg=", "organizations_url": "https://api.github.com/users/mhils/orgs", "received_events_url": "https://api.github.com/users/mhils/received_events", "repos_url": "https://api.github.com/users/mhils/repos", "site_admin": false, "starred_url": "https://api.github.com/users/mhils/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mhils/subscriptions", "type": "User", "url": "https://api.github.com/users/mhils", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2015-09-05T10:08:59Z
2021-09-08T06:01:07Z
2015-09-05T21:01:39Z
CONTRIBUTOR
resolved
Minor nitpick: The quote in http://www.python-requests.org/en/latest/user/quickstart/#response-headers is currently not formatted properly. This PR fixes this.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2758/reactions" }
https://api.github.com/repos/psf/requests/issues/2758/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2758.diff", "html_url": "https://github.com/psf/requests/pull/2758", "merged_at": "2015-09-05T21:01:39Z", "patch_url": "https://github.com/psf/requests/pull/2758.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2758" }
true
[ "Fantastic @mhils! Thanks! :cake: :sparkles: :cake:\n" ]
https://api.github.com/repos/psf/requests/issues/2757
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2757/labels{/name}
https://api.github.com/repos/psf/requests/issues/2757/comments
https://api.github.com/repos/psf/requests/issues/2757/events
https://github.com/psf/requests/pull/2757
105,008,959
MDExOlB1bGxSZXF1ZXN0NDQyNzc4MTE=
2,757
Add PreparedRequest pickling tests
{ "avatar_url": "https://avatars.githubusercontent.com/u/6401746?v=4", "events_url": "https://api.github.com/users/keyan/events{/privacy}", "followers_url": "https://api.github.com/users/keyan/followers", "following_url": "https://api.github.com/users/keyan/following{/other_user}", "gists_url": "https://api.github.com/users/keyan/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/keyan", "id": 6401746, "login": "keyan", "node_id": "MDQ6VXNlcjY0MDE3NDY=", "organizations_url": "https://api.github.com/users/keyan/orgs", "received_events_url": "https://api.github.com/users/keyan/received_events", "repos_url": "https://api.github.com/users/keyan/repos", "site_admin": false, "starred_url": "https://api.github.com/users/keyan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/keyan/subscriptions", "type": "User", "url": "https://api.github.com/users/keyan", "user_view_type": "public" }
[]
closed
true
null
[]
null
5
2015-09-05T06:33:55Z
2021-09-08T04:01:08Z
2016-04-06T19:15:38Z
CONTRIBUTOR
resolved
Trying to address #1558 by first creating a failing test, but I'm not sure when `PreparedRequest`s fail to be pickleable. Pulling early to see if anyone has suggestions on how to re-create the issue, also maybe these tests are useful on their own as well.
{ "avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4", "events_url": "https://api.github.com/users/kennethreitz/events{/privacy}", "followers_url": "https://api.github.com/users/kennethreitz/followers", "following_url": "https://api.github.com/users/kennethreitz/following{/other_user}", "gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/kennethreitz", "id": 119893, "login": "kennethreitz", "node_id": "MDQ6VXNlcjExOTg5Mw==", "organizations_url": "https://api.github.com/users/kennethreitz/orgs", "received_events_url": "https://api.github.com/users/kennethreitz/received_events", "repos_url": "https://api.github.com/users/kennethreitz/repos", "site_admin": false, "starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions", "type": "User", "url": "https://api.github.com/users/kennethreitz", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2757/reactions" }
https://api.github.com/repos/psf/requests/issues/2757/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2757.diff", "html_url": "https://github.com/psf/requests/pull/2757", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/2757.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2757" }
true
[ "Thanks @keyan! From the issue:\n\n> On a prepared request, the only thing I think can hurt us is the case when the body attribute is a file object. Is there a specific hook that we're concerned about not being pickleable?\n\nSo the concerns seem to be body file objects and hooks.\n", "@keyan do you have intentio...
https://api.github.com/repos/psf/requests/issues/2756
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2756/labels{/name}
https://api.github.com/repos/psf/requests/issues/2756/comments
https://api.github.com/repos/psf/requests/issues/2756/events
https://github.com/psf/requests/issues/2756
104,987,769
MDU6SXNzdWUxMDQ5ODc3Njk=
2,756
Json supersedes data in prepare_body
{ "avatar_url": "https://avatars.githubusercontent.com/u/3417501?v=4", "events_url": "https://api.github.com/users/xEtherealx/events{/privacy}", "followers_url": "https://api.github.com/users/xEtherealx/followers", "following_url": "https://api.github.com/users/xEtherealx/following{/other_user}", "gists_url": "https://api.github.com/users/xEtherealx/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/xEtherealx", "id": 3417501, "login": "xEtherealx", "node_id": "MDQ6VXNlcjM0MTc1MDE=", "organizations_url": "https://api.github.com/users/xEtherealx/orgs", "received_events_url": "https://api.github.com/users/xEtherealx/received_events", "repos_url": "https://api.github.com/users/xEtherealx/repos", "site_admin": false, "starred_url": "https://api.github.com/users/xEtherealx/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/xEtherealx/subscriptions", "type": "User", "url": "https://api.github.com/users/xEtherealx", "user_view_type": "public" }
[ { "color": "e10c02", "default": false, "description": null, "id": 117744, "name": "Bug", "node_id": "MDU6TGFiZWwxMTc3NDQ=", "url": "https://api.github.com/repos/psf/requests/labels/Bug" }, { "color": "0b02e1", "default": false, "description": null, "id": 191274, "...
closed
true
null
[]
null
4
2015-09-04T23:44:09Z
2021-09-08T22:00:44Z
2015-10-06T14:52:47Z
NONE
resolved
When not a stream, json supersedes data in prepare_body: https://github.com/kennethreitz/requests/blob/f5dacf84468ab7e0631cc61a3f1431a32e3e143c/requests/models.py#L446 This conflicts with the docstring, which indicates that json is only used when data is not specified: https://github.com/kennethreitz/requests/blob/f5dacf84468ab7e0631cc61a3f1431a32e3e143c/requests/models.py#L195
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2756/reactions" }
https://api.github.com/repos/psf/requests/issues/2756/timeline
null
completed
null
null
false
[ "Thanks for this! Yes, that's well spotted: we're definitely in conflict with the documented behaviour.\n", "I may try to find someone who wants to get started in requests to see if they want to fix this: it's a perfect fix for someone relatively new to OSS.\n", "BTW, `files` also supersedes `json` - the docs c...
https://api.github.com/repos/psf/requests/issues/2755
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2755/labels{/name}
https://api.github.com/repos/psf/requests/issues/2755/comments
https://api.github.com/repos/psf/requests/issues/2755/events
https://github.com/psf/requests/issues/2755
104,783,245
MDU6SXNzdWUxMDQ3ODMyNDU=
2,755
allow custom JSONEncoder for the request's json param
{ "avatar_url": "https://avatars.githubusercontent.com/u/165819?v=4", "events_url": "https://api.github.com/users/drmaples/events{/privacy}", "followers_url": "https://api.github.com/users/drmaples/followers", "following_url": "https://api.github.com/users/drmaples/following{/other_user}", "gists_url": "https://api.github.com/users/drmaples/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/drmaples", "id": 165819, "login": "drmaples", "node_id": "MDQ6VXNlcjE2NTgxOQ==", "organizations_url": "https://api.github.com/users/drmaples/orgs", "received_events_url": "https://api.github.com/users/drmaples/received_events", "repos_url": "https://api.github.com/users/drmaples/repos", "site_admin": false, "starred_url": "https://api.github.com/users/drmaples/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/drmaples/subscriptions", "type": "User", "url": "https://api.github.com/users/drmaples", "user_view_type": "public" }
[]
closed
true
null
[]
null
5
2015-09-03T21:14:09Z
2021-09-08T22:00:51Z
2015-09-03T21:20:34Z
NONE
resolved
Using the [json param](http://docs.python-requests.org/en/latest/api/?highlight=json#requests.request) when making a request is awesome: ``` python payload = {'blip': 'blaz'} r = requests.get('http://foo.bar', json=payload) ``` Using the [response property](http://docs.python-requests.org/en/latest/api/#requests.Response.json) is great as well, especially since you can use a custom json decoder: ``` python r.json(cls=MyCustomDecoder) ``` It would be nice to allow a param to be passed that could be applied to the `dumps` of the [json value](https://github.com/kennethreitz/requests/blob/master/requests/models.py#L417-L419). ``` python payload = {'blip': Decimal(69)} json_params = {'cls': MyCustomEncoder} r = requests.get('http://foo.bar', json=payload, json_params=json_params) ```
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2755/reactions" }
https://api.github.com/repos/psf/requests/issues/2755/timeline
null
completed
null
null
false
[ "I think this is interesting, but generally requests is very averse to adding new keyword arguments to `requests.*`. I don't think it's valuable enough to justify adding the new argument, I'm afraid. Sorry!\n", "Is there a better way to always use a custom json encoder? This way is brittle and gross and does not ...
https://api.github.com/repos/psf/requests/issues/2754
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2754/labels{/name}
https://api.github.com/repos/psf/requests/issues/2754/comments
https://api.github.com/repos/psf/requests/issues/2754/events
https://github.com/psf/requests/pull/2754
104,215,667
MDExOlB1bGxSZXF1ZXN0NDM4NTAwMjc=
2,754
Fix unicode redirects on Python 3.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
[]
closed
true
null
[]
{ "closed_at": null, "closed_issues": 29, "created_at": "2013-11-17T11:29:34Z", "creator": { "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }, "description": null, "due_on": null, "html_url": "https://github.com/psf/requests/milestone/20", "id": 487518, "labels_url": "https://api.github.com/repos/psf/requests/milestones/20/labels", "node_id": "MDk6TWlsZXN0b25lNDg3NTE4", "number": 20, "open_issues": 12, "state": "open", "title": "3.0.0", "updated_at": "2024-05-19T18:43:00Z", "url": "https://api.github.com/repos/psf/requests/milestones/20" }
13
2015-09-01T08:35:36Z
2021-09-08T04:01:06Z
2016-04-15T21:39:18Z
MEMBER
resolved
Resolves #2653. Follows on from #2655: please read the discussion there for more information.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2754/reactions" }
https://api.github.com/repos/psf/requests/issues/2754/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2754.diff", "html_url": "https://github.com/psf/requests/pull/2754", "merged_at": "2016-04-15T21:39:18Z", "patch_url": "https://github.com/psf/requests/pull/2754.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2754" }
true
[ ":+1:\n", "there's a lot of pending merges — trying hard not to merge them :)\n", "@kennethreitz You're doing an admirable job. ;)\n", "Soon™\n", "Oh right, this is for 3.0.0... did we have a test for this? If not I'm :+1: \n", "I don't think we do, though I can see if I can create one.\n", "Tests are n...
https://api.github.com/repos/psf/requests/issues/2753
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2753/labels{/name}
https://api.github.com/repos/psf/requests/issues/2753/comments
https://api.github.com/repos/psf/requests/issues/2753/events
https://github.com/psf/requests/pull/2753
104,017,682
MDExOlB1bGxSZXF1ZXN0NDM3NDY0MjU=
2,753
Document the string form of the verify parameter.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
[]
closed
true
null
[]
null
0
2015-08-31T09:26:44Z
2021-09-08T06:01:08Z
2015-09-01T01:34:11Z
MEMBER
resolved
Just a little bit of extra example documentation. Resolves #2652.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2753/reactions" }
https://api.github.com/repos/psf/requests/issues/2753/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2753.diff", "html_url": "https://github.com/psf/requests/pull/2753", "merged_at": "2015-09-01T01:34:11Z", "patch_url": "https://github.com/psf/requests/pull/2753.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2753" }
true
[]
https://api.github.com/repos/psf/requests/issues/2752
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2752/labels{/name}
https://api.github.com/repos/psf/requests/issues/2752/comments
https://api.github.com/repos/psf/requests/issues/2752/events
https://github.com/psf/requests/issues/2752
103,971,198
MDU6SXNzdWUxMDM5NzExOTg=
2,752
Upgrade urllib3 to 1.11
{ "avatar_url": "https://avatars.githubusercontent.com/u/90853?v=4", "events_url": "https://api.github.com/users/thanatos/events{/privacy}", "followers_url": "https://api.github.com/users/thanatos/followers", "following_url": "https://api.github.com/users/thanatos/following{/other_user}", "gists_url": "https://api.github.com/users/thanatos/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/thanatos", "id": 90853, "login": "thanatos", "node_id": "MDQ6VXNlcjkwODUz", "organizations_url": "https://api.github.com/users/thanatos/orgs", "received_events_url": "https://api.github.com/users/thanatos/received_events", "repos_url": "https://api.github.com/users/thanatos/repos", "site_admin": false, "starred_url": "https://api.github.com/users/thanatos/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/thanatos/subscriptions", "type": "User", "url": "https://api.github.com/users/thanatos", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2015-08-31T01:45:25Z
2021-09-08T22:00:55Z
2015-08-31T01:57:42Z
NONE
resolved
I'm running into [the following bug](https://github.com/pypa/pip/issues/2753) in `pip`: ``` File "/usr/lib/python2.7/httplib.py", line 780, in close self.sock.close() # close it manually... there may be other refs File "/…/pip/pip/_vendor/requests/packages/urllib3/contrib/pyopenssl.py", line 213, in close return self.connection.shutdown() File "/…/OpenSSL/SSL.py", line 1522, in shutdown File "/…/OpenSSL/SSL.py", line 1178, in _raise_ssl_error SysCallError: (32, 'EPIPE') ``` This is caused by [a bug in urllib3](https://github.com/shazow/urllib3/issues/612); urllib3 has since [patched](https://github.com/shazow/urllib3/commit/90946207d2aedd41fcfcf8e6d68b07fa5a834ada) the bug, but pip can't get the patch until requests upgrades their copy of urllib3.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2752/reactions" }
https://api.github.com/repos/psf/requests/issues/2752/timeline
null
completed
null
null
false
[ "We'll hopefully be creating a release soon. When that happens we'll upgrade our version of urllib3.\n" ]
https://api.github.com/repos/psf/requests/issues/2751
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2751/labels{/name}
https://api.github.com/repos/psf/requests/issues/2751/comments
https://api.github.com/repos/psf/requests/issues/2751/events
https://github.com/psf/requests/pull/2751
103,822,899
MDExOlB1bGxSZXF1ZXN0NDM2ODY3OTY=
2,751
Add link to ES translation.
{ "avatar_url": "https://avatars.githubusercontent.com/u/3130883?v=4", "events_url": "https://api.github.com/users/carlosvargas/events{/privacy}", "followers_url": "https://api.github.com/users/carlosvargas/followers", "following_url": "https://api.github.com/users/carlosvargas/following{/other_user}", "gists_url": "https://api.github.com/users/carlosvargas/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/carlosvargas", "id": 3130883, "login": "carlosvargas", "node_id": "MDQ6VXNlcjMxMzA4ODM=", "organizations_url": "https://api.github.com/users/carlosvargas/orgs", "received_events_url": "https://api.github.com/users/carlosvargas/received_events", "repos_url": "https://api.github.com/users/carlosvargas/repos", "site_admin": false, "starred_url": "https://api.github.com/users/carlosvargas/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/carlosvargas/subscriptions", "type": "User", "url": "https://api.github.com/users/carlosvargas", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2015-08-29T02:19:45Z
2021-09-08T06:01:08Z
2015-08-29T12:21:07Z
CONTRIBUTOR
resolved
Fixes #2750
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2751/reactions" }
https://api.github.com/repos/psf/requests/issues/2751/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2751.diff", "html_url": "https://github.com/psf/requests/pull/2751", "merged_at": "2015-08-29T12:21:07Z", "patch_url": "https://github.com/psf/requests/pull/2751.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2751" }
true
[ "Thanks @carlosvargas \n" ]
https://api.github.com/repos/psf/requests/issues/2750
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2750/labels{/name}
https://api.github.com/repos/psf/requests/issues/2750/comments
https://api.github.com/repos/psf/requests/issues/2750/events
https://github.com/psf/requests/issues/2750
103,822,877
MDU6SXNzdWUxMDM4MjI4Nzc=
2,750
Spanish translation is missing from documentation sidebar
{ "avatar_url": "https://avatars.githubusercontent.com/u/3130883?v=4", "events_url": "https://api.github.com/users/carlosvargas/events{/privacy}", "followers_url": "https://api.github.com/users/carlosvargas/followers", "following_url": "https://api.github.com/users/carlosvargas/following{/other_user}", "gists_url": "https://api.github.com/users/carlosvargas/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/carlosvargas", "id": 3130883, "login": "carlosvargas", "node_id": "MDQ6VXNlcjMxMzA4ODM=", "organizations_url": "https://api.github.com/users/carlosvargas/orgs", "received_events_url": "https://api.github.com/users/carlosvargas/received_events", "repos_url": "https://api.github.com/users/carlosvargas/repos", "site_admin": false, "starred_url": "https://api.github.com/users/carlosvargas/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/carlosvargas/subscriptions", "type": "User", "url": "https://api.github.com/users/carlosvargas", "user_view_type": "public" }
[]
closed
true
null
[]
null
0
2015-08-29T02:18:36Z
2021-09-08T22:00:55Z
2015-08-29T12:21:07Z
CONTRIBUTOR
resolved
Now that http://es.python-requests.org/ has been set up, a link to it needs to be added in the documentation sidebar, along the other languages.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2750/reactions" }
https://api.github.com/repos/psf/requests/issues/2750/timeline
null
completed
null
null
false
[]
https://api.github.com/repos/psf/requests/issues/2749
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2749/labels{/name}
https://api.github.com/repos/psf/requests/issues/2749/comments
https://api.github.com/repos/psf/requests/issues/2749/events
https://github.com/psf/requests/issues/2749
103,699,976
MDU6SXNzdWUxMDM2OTk5NzY=
2,749
form data encoding can't be modifid
{ "avatar_url": "https://avatars.githubusercontent.com/u/1189879?v=4", "events_url": "https://api.github.com/users/pynixwang/events{/privacy}", "followers_url": "https://api.github.com/users/pynixwang/followers", "following_url": "https://api.github.com/users/pynixwang/following{/other_user}", "gists_url": "https://api.github.com/users/pynixwang/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/pynixwang", "id": 1189879, "login": "pynixwang", "node_id": "MDQ6VXNlcjExODk4Nzk=", "organizations_url": "https://api.github.com/users/pynixwang/orgs", "received_events_url": "https://api.github.com/users/pynixwang/received_events", "repos_url": "https://api.github.com/users/pynixwang/repos", "site_admin": false, "starred_url": "https://api.github.com/users/pynixwang/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pynixwang/subscriptions", "type": "User", "url": "https://api.github.com/users/pynixwang", "user_view_type": "public" }
[]
closed
true
null
[]
null
3
2015-08-28T11:10:08Z
2021-09-08T22:00:52Z
2015-08-28T12:48:38Z
NONE
resolved
these days, I 'm doing a poster to an old system,it only accepts gbk encoding,but form data is utf8, python 3 can pass a encoding parameter to urlencode then pass to post method,but python 2 urlencode does'nt support this parameter. any opinion about this?
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2749/reactions" }
https://api.github.com/repos/psf/requests/issues/2749/timeline
null
completed
null
null
false
[ "This isn't something requests would do for you anyway, so what you should do is urlencode the data, and then pass it to the `data=` parameter, e.g., \n\n``` py\npostdata = urlencode(...)\npostdata = postdata.encode(...)\nrequests.post(url, data=postdata, headers={'Content-Type': 'application/x-www-form-urlencoded'...
https://api.github.com/repos/psf/requests/issues/2748
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2748/labels{/name}
https://api.github.com/repos/psf/requests/issues/2748/comments
https://api.github.com/repos/psf/requests/issues/2748/events
https://github.com/psf/requests/issues/2748
103,388,556
MDU6SXNzdWUxMDMzODg1NTY=
2,748
during redirecting the host adress in header did not update correctly
{ "avatar_url": "https://avatars.githubusercontent.com/u/8402502?v=4", "events_url": "https://api.github.com/users/hxzhao527/events{/privacy}", "followers_url": "https://api.github.com/users/hxzhao527/followers", "following_url": "https://api.github.com/users/hxzhao527/following{/other_user}", "gists_url": "https://api.github.com/users/hxzhao527/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/hxzhao527", "id": 8402502, "login": "hxzhao527", "node_id": "MDQ6VXNlcjg0MDI1MDI=", "organizations_url": "https://api.github.com/users/hxzhao527/orgs", "received_events_url": "https://api.github.com/users/hxzhao527/received_events", "repos_url": "https://api.github.com/users/hxzhao527/repos", "site_admin": false, "starred_url": "https://api.github.com/users/hxzhao527/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hxzhao527/subscriptions", "type": "User", "url": "https://api.github.com/users/hxzhao527", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2015-08-26T23:47:18Z
2021-09-08T22:00:56Z
2015-08-27T01:44:22Z
NONE
resolved
Situation:POST or GET a adress which will redirect an adress which the host adress in header is different with the last request. I write a small script to simulate login my school account.But the exception, > requests.exceptions.ConnectionError: ('Connection aborted.', error(10054, '')) > is always happening. I try to print the information of every request.So in [session.py](https://github.com/kennethreitz/requests/blob/master/requests/sessions.py) class SessionRedirectMixin function resolve_redirects ,I print the header information before a real request. I find during redirecting,the header information is just copied from its last request.So if a request is redirected to an adress which the host adress in header is different with the last request,it will failed. I try to solve this problem. I add these lines in function resolve_redirects at 172th line in [session.py](https://github.com/kennethreitz/requests/blob/master/requests/sessions.py) before send the request. ``` if headers.get("Host"): headers["Host"] = urlparse(url).hostname ``` And it worked for me. more information: ``` import requests print request.__version__ '2.7.0' ```
{ "avatar_url": "https://avatars.githubusercontent.com/u/8402502?v=4", "events_url": "https://api.github.com/users/hxzhao527/events{/privacy}", "followers_url": "https://api.github.com/users/hxzhao527/followers", "following_url": "https://api.github.com/users/hxzhao527/following{/other_user}", "gists_url": "https://api.github.com/users/hxzhao527/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/hxzhao527", "id": 8402502, "login": "hxzhao527", "node_id": "MDQ6VXNlcjg0MDI1MDI=", "organizations_url": "https://api.github.com/users/hxzhao527/orgs", "received_events_url": "https://api.github.com/users/hxzhao527/received_events", "repos_url": "https://api.github.com/users/hxzhao527/repos", "site_admin": false, "starred_url": "https://api.github.com/users/hxzhao527/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/hxzhao527/subscriptions", "type": "User", "url": "https://api.github.com/users/hxzhao527", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2748/reactions" }
https://api.github.com/repos/psf/requests/issues/2748/timeline
null
completed
null
null
false
[ "@HeartUnchange are you specifying your own `Host` header? If so, why?\n", "~(≧▽≦)/~I got it.I delete the Host ,and it works.I see browser send this field ,so I add this(I am a beginer).Thanks for your help.\n" ]
https://api.github.com/repos/psf/requests/issues/2747
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2747/labels{/name}
https://api.github.com/repos/psf/requests/issues/2747/comments
https://api.github.com/repos/psf/requests/issues/2747/events
https://github.com/psf/requests/issues/2747
103,210,039
MDU6SXNzdWUxMDMyMTAwMzk=
2,747
Session connection with stream=True unusable after response.close()
{ "avatar_url": "https://avatars.githubusercontent.com/u/1076393?v=4", "events_url": "https://api.github.com/users/mherrmann/events{/privacy}", "followers_url": "https://api.github.com/users/mherrmann/followers", "following_url": "https://api.github.com/users/mherrmann/following{/other_user}", "gists_url": "https://api.github.com/users/mherrmann/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/mherrmann", "id": 1076393, "login": "mherrmann", "node_id": "MDQ6VXNlcjEwNzYzOTM=", "organizations_url": "https://api.github.com/users/mherrmann/orgs", "received_events_url": "https://api.github.com/users/mherrmann/received_events", "repos_url": "https://api.github.com/users/mherrmann/repos", "site_admin": false, "starred_url": "https://api.github.com/users/mherrmann/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mherrmann/subscriptions", "type": "User", "url": "https://api.github.com/users/mherrmann", "user_view_type": "public" }
[]
closed
true
null
[]
null
4
2015-08-26T08:42:45Z
2021-09-08T22:00:56Z
2015-08-26T09:55:49Z
NONE
resolved
Please consider the following code: ``` import requests session = requests.Session() resp = session.get('http://www.w3schools.com/html/demo_sse.php', stream=True) resp.close() session.get('http://www.w3schools.com') ``` It results in the following exception: ``` Traceback (most recent call last): File "<console>", line 1, in <module> File ".../venv/lib/python3.4/site-packages/requests/sessions.py", line 477, in get return self.request('GET', url, **kwargs) File ".../venv/lib/python3.4/site-packages/requests/sessions.py", line 465, in request resp = self.send(prep, **send_kwargs) File ".../venv/lib/python3.4/site-packages/requests/sessions.py", line 573, in send r = adapter.send(request, **kwargs) File ".../venv/lib/python3.4/site-packages/requests/adapters.py", line 415, in send raise ConnectionError(err, request=request) requests.exceptions.ConnectionError: ('Connection aborted.', ResponseNotReady('Request-sent',)) ``` Unless I am doing something wrong, It appears to me that `resp.close()` returns the connection to the pool in an inconsistent state. What's interesting is that the exception does not occur when the last line in the example above connects to a different server (eg. `session.get('http://www.google.com')` instead of `http://www.w3schools.com`). What's also interesting is that the problem only occurs when working with a `requests.Session`. That is, the following code does not raise an exception: ``` import requests resp = requests.get('http://www.w3schools.com/html/demo_sse.php', stream=True) resp.close() requests.get('http://www.w3schools.com') ``` I am using requests version `2.7.0`. The problem occurs on both Windows 7 with Python 2.7.10 and on OS X with Python 3.4.3.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 1, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 1, "url": "https://api.github.com/repos/psf/requests/issues/2747/reactions" }
https://api.github.com/repos/psf/requests/issues/2747/timeline
null
completed
null
null
false
[ "This is a known issue (#2593), and was fixed in #2610. =) The next release of requests should contain the fix.\n", "Awesome, thanks :-) Is there an ETA for the next release?\n", "Nothing beyond \"soon\" I'm afraid. Hopefully our release process will get a bit more concrete over the next few weeks.\n", "Ok, t...
https://api.github.com/repos/psf/requests/issues/2746
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2746/labels{/name}
https://api.github.com/repos/psf/requests/issues/2746/comments
https://api.github.com/repos/psf/requests/issues/2746/events
https://github.com/psf/requests/pull/2746
103,105,851
MDExOlB1bGxSZXF1ZXN0NDMzMzA1ODY=
2,746
Add link to IT translation
{ "avatar_url": "https://avatars.githubusercontent.com/u/5172190?v=4", "events_url": "https://api.github.com/users/csparpa/events{/privacy}", "followers_url": "https://api.github.com/users/csparpa/followers", "following_url": "https://api.github.com/users/csparpa/following{/other_user}", "gists_url": "https://api.github.com/users/csparpa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/csparpa", "id": 5172190, "login": "csparpa", "node_id": "MDQ6VXNlcjUxNzIxOTA=", "organizations_url": "https://api.github.com/users/csparpa/orgs", "received_events_url": "https://api.github.com/users/csparpa/received_events", "repos_url": "https://api.github.com/users/csparpa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/csparpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/csparpa/subscriptions", "type": "User", "url": "https://api.github.com/users/csparpa", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2015-08-25T20:10:24Z
2021-09-08T06:01:08Z
2015-08-26T00:38:04Z
CONTRIBUTOR
resolved
Fixes #2744
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2746/reactions" }
https://api.github.com/repos/psf/requests/issues/2746/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2746.diff", "html_url": "https://github.com/psf/requests/pull/2746", "merged_at": "2015-08-26T00:38:04Z", "patch_url": "https://github.com/psf/requests/pull/2746.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2746" }
true
[ "LGTM.\n" ]
https://api.github.com/repos/psf/requests/issues/2745
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2745/labels{/name}
https://api.github.com/repos/psf/requests/issues/2745/comments
https://api.github.com/repos/psf/requests/issues/2745/events
https://github.com/psf/requests/issues/2745
102,989,781
MDU6SXNzdWUxMDI5ODk3ODE=
2,745
Very slow read of large files compared to many other modules/binaries (e.g. urllib/curl/wget)
{ "avatar_url": "https://avatars.githubusercontent.com/u/208316?v=4", "events_url": "https://api.github.com/users/davechallis/events{/privacy}", "followers_url": "https://api.github.com/users/davechallis/followers", "following_url": "https://api.github.com/users/davechallis/following{/other_user}", "gists_url": "https://api.github.com/users/davechallis/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/davechallis", "id": 208316, "login": "davechallis", "node_id": "MDQ6VXNlcjIwODMxNg==", "organizations_url": "https://api.github.com/users/davechallis/orgs", "received_events_url": "https://api.github.com/users/davechallis/received_events", "repos_url": "https://api.github.com/users/davechallis/repos", "site_admin": false, "starred_url": "https://api.github.com/users/davechallis/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/davechallis/subscriptions", "type": "User", "url": "https://api.github.com/users/davechallis", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2015-08-25T09:50:34Z
2021-09-08T22:00:56Z
2015-08-25T10:01:07Z
NONE
resolved
Using python 3.4 and requests 2.7.0 (on both Ubuntu 14.04 and Mac OS X), I've noticed that fetching raw content of large files is significantly slower (~5x) with requests than many other applications and python modules, performance as below is typical: ``` import requests import urllib.request import time # returns a 100Mb JSON file url = 'http://some.host.on.local.network/' def with_urllib(): with urllib.request.urlopen(url) as f: return f.read() def with_requests(): return requests.get(url).content s = time.time() a = with_urllib() print('urllib:', time.time() - s, 'seconds') s = time.time() b = with_requests() print('requests:', time.time() - s, 'seconds') assert a == b ``` This outputs: ``` urllib: 1.113746166229248 seconds requests: 5.458410978317261 seconds ``` curl, wget, pycurl and urllib all complete in similar times (~1.1s on average), requests consistently takes ~5.4s on average, even with various combinations of parameters I've tried (e.g. with streaming, with different streaming chunksizes, etc.).
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2745/reactions" }
https://api.github.com/repos/psf/requests/issues/2745/timeline
null
completed
null
null
false
[ "I believe this is the same bug report as #2371. We'd like to keep investigating this performance problem to see if we can work out where we're spending the time, so if you feel like trying to track it down yourself please do. Otherwise, it'll go on my backlog of work to be investigated.\n", "Thanks, looking at #...
https://api.github.com/repos/psf/requests/issues/2744
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2744/labels{/name}
https://api.github.com/repos/psf/requests/issues/2744/comments
https://api.github.com/repos/psf/requests/issues/2744/events
https://github.com/psf/requests/issues/2744
102,968,894
MDU6SXNzdWUxMDI5Njg4OTQ=
2,744
Missing link to Italian translation of documentation
{ "avatar_url": "https://avatars.githubusercontent.com/u/5172190?v=4", "events_url": "https://api.github.com/users/csparpa/events{/privacy}", "followers_url": "https://api.github.com/users/csparpa/followers", "following_url": "https://api.github.com/users/csparpa/following{/other_user}", "gists_url": "https://api.github.com/users/csparpa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/csparpa", "id": 5172190, "login": "csparpa", "node_id": "MDQ6VXNlcjUxNzIxOTA=", "organizations_url": "https://api.github.com/users/csparpa/orgs", "received_events_url": "https://api.github.com/users/csparpa/received_events", "repos_url": "https://api.github.com/users/csparpa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/csparpa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/csparpa/subscriptions", "type": "User", "url": "https://api.github.com/users/csparpa", "user_view_type": "public" }
[ { "color": "e102d8", "default": false, "description": null, "id": 117745, "name": "Planned", "node_id": "MDU6TGFiZWwxMTc3NDU=", "url": "https://api.github.com/repos/psf/requests/labels/Planned" }, { "color": "0b02e1", "default": false, "description": null, "id": 19127...
closed
true
null
[]
null
0
2015-08-25T07:42:43Z
2021-09-04T00:06:28Z
2015-08-26T00:38:04Z
CONTRIBUTOR
resolved
Link shall point to: http://it.python-requests.org and be inserted in sidebar, alongside the other links to translations
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2744/reactions" }
https://api.github.com/repos/psf/requests/issues/2744/timeline
null
completed
null
null
false
[]
https://api.github.com/repos/psf/requests/issues/2743
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2743/labels{/name}
https://api.github.com/repos/psf/requests/issues/2743/comments
https://api.github.com/repos/psf/requests/issues/2743/events
https://github.com/psf/requests/pull/2743
102,930,426
MDExOlB1bGxSZXF1ZXN0NDMyNDE3MTc=
2,743
Fix tests on python 2.6
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
[]
closed
true
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
[ { "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url...
{ "closed_at": "2015-10-12T10:32:06Z", "closed_issues": 7, "created_at": "2015-04-29T13:03:39Z", "creator": { "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }, "description": "", "due_on": null, "html_url": "https://github.com/psf/requests/milestone/25", "id": 1089203, "labels_url": "https://api.github.com/repos/psf/requests/milestones/25/labels", "node_id": "MDk6TWlsZXN0b25lMTA4OTIwMw==", "number": 25, "open_issues": 0, "state": "closed", "title": "2.8.0", "updated_at": "2015-10-12T10:32:06Z", "url": "https://api.github.com/repos/psf/requests/milestones/25" }
0
2015-08-25T01:47:46Z
2021-09-08T06:01:09Z
2015-08-25T07:27:20Z
CONTRIBUTOR
resolved
On Python 2.6, there's no `OrderedDict` in the `collections` module.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2743/reactions" }
https://api.github.com/repos/psf/requests/issues/2743/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2743.diff", "html_url": "https://github.com/psf/requests/pull/2743", "merged_at": "2015-08-25T07:27:20Z", "patch_url": "https://github.com/psf/requests/pull/2743.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2743" }
true
[]
https://api.github.com/repos/psf/requests/issues/2742
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2742/labels{/name}
https://api.github.com/repos/psf/requests/issues/2742/comments
https://api.github.com/repos/psf/requests/issues/2742/events
https://github.com/psf/requests/pull/2742
102,913,545
MDExOlB1bGxSZXF1ZXN0NDMyMzQyNDY=
2,742
Include file-like object in data arg description
{ "avatar_url": "https://avatars.githubusercontent.com/u/634901?v=4", "events_url": "https://api.github.com/users/etoews/events{/privacy}", "followers_url": "https://api.github.com/users/etoews/followers", "following_url": "https://api.github.com/users/etoews/following{/other_user}", "gists_url": "https://api.github.com/users/etoews/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/etoews", "id": 634901, "login": "etoews", "node_id": "MDQ6VXNlcjYzNDkwMQ==", "organizations_url": "https://api.github.com/users/etoews/orgs", "received_events_url": "https://api.github.com/users/etoews/received_events", "repos_url": "https://api.github.com/users/etoews/repos", "site_admin": false, "starred_url": "https://api.github.com/users/etoews/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/etoews/subscriptions", "type": "User", "url": "https://api.github.com/users/etoews", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2015-08-24T23:29:58Z
2021-09-08T07:00:42Z
2015-08-25T01:44:45Z
NONE
resolved
If `requests.api.request()` uses `requests.sessions.Session.request()` to get it's work done then the data arg description should match between the two.
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2742/reactions" }
https://api.github.com/repos/psf/requests/issues/2742/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2742.diff", "html_url": "https://github.com/psf/requests/pull/2742", "merged_at": "2015-08-25T01:44:45Z", "patch_url": "https://github.com/psf/requests/pull/2742.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2742" }
true
[ "Thanks @everett-toews ! :sparkles: :cake: :sparkles: \n" ]
https://api.github.com/repos/psf/requests/issues/2741
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2741/labels{/name}
https://api.github.com/repos/psf/requests/issues/2741/comments
https://api.github.com/repos/psf/requests/issues/2741/events
https://github.com/psf/requests/pull/2741
102,893,646
MDExOlB1bGxSZXF1ZXN0NDMyMjI5MzQ=
2,741
Implement per-host proxies
{ "avatar_url": "https://avatars.githubusercontent.com/u/192614?v=4", "events_url": "https://api.github.com/users/jasongrout/events{/privacy}", "followers_url": "https://api.github.com/users/jasongrout/followers", "following_url": "https://api.github.com/users/jasongrout/following{/other_user}", "gists_url": "https://api.github.com/users/jasongrout/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/jasongrout", "id": 192614, "login": "jasongrout", "node_id": "MDQ6VXNlcjE5MjYxNA==", "organizations_url": "https://api.github.com/users/jasongrout/orgs", "received_events_url": "https://api.github.com/users/jasongrout/received_events", "repos_url": "https://api.github.com/users/jasongrout/repos", "site_admin": false, "starred_url": "https://api.github.com/users/jasongrout/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jasongrout/subscriptions", "type": "User", "url": "https://api.github.com/users/jasongrout", "user_view_type": "public" }
[]
closed
true
null
[]
null
24
2015-08-24T21:17:16Z
2021-09-08T06:01:01Z
2015-09-06T03:02:41Z
CONTRIBUTOR
resolved
This change allows the proxy dict to be have entries of the form `{'<scheme>://<hostname>': '<proxy>'}`. Host-specific proxies will be used in preference to the scheme-specific proxies (i.e., proxy dict entries with keys like 'http' or 'https'). Fixes #2722
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2741/reactions" }
https://api.github.com/repos/psf/requests/issues/2741/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2741.diff", "html_url": "https://github.com/psf/requests/pull/2741", "merged_at": "2015-09-06T03:02:41Z", "patch_url": "https://github.com/psf/requests/pull/2741.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2741" }
true
[ "This looks reasonable enough to me.\n\nThoughts @sigmavirus24?\n", "Nope. This thoroughly breaks backwards compatibility. This changes the behaviour to **only** behave for per-host which means anyone passing `proxies={'http': ..., 'https': ...}` will see everything fail as soon as they upgrade.\n\nWe should supp...
https://api.github.com/repos/psf/requests/issues/2740
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2740/labels{/name}
https://api.github.com/repos/psf/requests/issues/2740/comments
https://api.github.com/repos/psf/requests/issues/2740/events
https://github.com/psf/requests/pull/2740
102,775,659
MDExOlB1bGxSZXF1ZXN0NDMxNjYyOTQ=
2,740
params of proxy_headers are inconsistent with its docstrings
{ "avatar_url": "https://avatars.githubusercontent.com/u/5804868?v=4", "events_url": "https://api.github.com/users/qingyunha/events{/privacy}", "followers_url": "https://api.github.com/users/qingyunha/followers", "following_url": "https://api.github.com/users/qingyunha/following{/other_user}", "gists_url": "https://api.github.com/users/qingyunha/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/qingyunha", "id": 5804868, "login": "qingyunha", "node_id": "MDQ6VXNlcjU4MDQ4Njg=", "organizations_url": "https://api.github.com/users/qingyunha/orgs", "received_events_url": "https://api.github.com/users/qingyunha/received_events", "repos_url": "https://api.github.com/users/qingyunha/repos", "site_admin": false, "starred_url": "https://api.github.com/users/qingyunha/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/qingyunha/subscriptions", "type": "User", "url": "https://api.github.com/users/qingyunha", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2015-08-24T11:51:35Z
2021-09-08T07:00:43Z
2015-08-24T12:43:01Z
CONTRIBUTOR
resolved
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2740/reactions" }
https://api.github.com/repos/psf/requests/issues/2740/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2740.diff", "html_url": "https://github.com/psf/requests/pull/2740", "merged_at": "2015-08-24T12:43:01Z", "patch_url": "https://github.com/psf/requests/pull/2740.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2740" }
true
[ "Thanks @qingyunha! :cake:\n" ]
https://api.github.com/repos/psf/requests/issues/2739
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2739/labels{/name}
https://api.github.com/repos/psf/requests/issues/2739/comments
https://api.github.com/repos/psf/requests/issues/2739/events
https://github.com/psf/requests/issues/2739
102,688,525
MDU6SXNzdWUxMDI2ODg1MjU=
2,739
params of proxy_headers are inconsistent with its docstrings
{ "avatar_url": "https://avatars.githubusercontent.com/u/5804868?v=4", "events_url": "https://api.github.com/users/qingyunha/events{/privacy}", "followers_url": "https://api.github.com/users/qingyunha/followers", "following_url": "https://api.github.com/users/qingyunha/following{/other_user}", "gists_url": "https://api.github.com/users/qingyunha/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/qingyunha", "id": 5804868, "login": "qingyunha", "node_id": "MDQ6VXNlcjU4MDQ4Njg=", "organizations_url": "https://api.github.com/users/qingyunha/orgs", "received_events_url": "https://api.github.com/users/qingyunha/received_events", "repos_url": "https://api.github.com/users/qingyunha/repos", "site_admin": false, "starred_url": "https://api.github.com/users/qingyunha/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/qingyunha/subscriptions", "type": "User", "url": "https://api.github.com/users/qingyunha", "user_view_type": "public" }
[ { "color": "0b02e1", "default": false, "description": null, "id": 191274, "name": "Contributor Friendly", "node_id": "MDU6TGFiZWwxOTEyNzQ=", "url": "https://api.github.com/repos/psf/requests/labels/Contributor%20Friendly" } ]
closed
true
null
[]
null
2
2015-08-24T02:28:54Z
2021-09-08T22:00:57Z
2015-08-24T12:43:12Z
CONTRIBUTOR
resolved
requests/adapters.py ``` def proxy_headers(self, proxy): """Returns a dictionary of the headers to add to any request sent through a proxy. This works with urllib3 magic to ensure that they are correctly sent to the proxy, rather than in a tunnelled request if CONNECT is being used. This should not be called from user code, and is only exposed for use when subclassing the :class:`HTTPAdapter <requests.adapters.HTTPAdapter>`. :param proxies: The url of the proxy being used for this request. :param kwargs: Optional additional keyword arguments. """ ```
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2739/reactions" }
https://api.github.com/repos/psf/requests/issues/2739/timeline
null
completed
null
null
false
[ "Yup, that does look wrong. Are you interested in providing a pull request to make this fix?\n", "Yes, I'm grad to.\n" ]
https://api.github.com/repos/psf/requests/issues/2738
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2738/labels{/name}
https://api.github.com/repos/psf/requests/issues/2738/comments
https://api.github.com/repos/psf/requests/issues/2738/events
https://github.com/psf/requests/issues/2738
102,325,351
MDU6SXNzdWUxMDIzMjUzNTE=
2,738
osrandom engine already registered
{ "avatar_url": "https://avatars.githubusercontent.com/u/863727?v=4", "events_url": "https://api.github.com/users/komakino/events{/privacy}", "followers_url": "https://api.github.com/users/komakino/followers", "following_url": "https://api.github.com/users/komakino/following{/other_user}", "gists_url": "https://api.github.com/users/komakino/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/komakino", "id": 863727, "login": "komakino", "node_id": "MDQ6VXNlcjg2MzcyNw==", "organizations_url": "https://api.github.com/users/komakino/orgs", "received_events_url": "https://api.github.com/users/komakino/received_events", "repos_url": "https://api.github.com/users/komakino/repos", "site_admin": false, "starred_url": "https://api.github.com/users/komakino/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/komakino/subscriptions", "type": "User", "url": "https://api.github.com/users/komakino", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2015-08-21T08:27:07Z
2021-09-08T22:00:57Z
2015-08-21T12:21:31Z
NONE
resolved
Getting "osrandom engine already registered" from cryptography module when including requests in kodi addon. http://xbmclogs.com/pq07deaup
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2738/reactions" }
https://api.github.com/repos/psf/requests/issues/2738/timeline
null
completed
null
null
false
[ "This is strictly a cryptography bug, I think: @reaperhulk?\n", "@komakino has already filed a bug there. Closing to centralize discussion where it belongs.\n" ]
https://api.github.com/repos/psf/requests/issues/2737
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2737/labels{/name}
https://api.github.com/repos/psf/requests/issues/2737/comments
https://api.github.com/repos/psf/requests/issues/2737/events
https://github.com/psf/requests/pull/2737
102,318,316
MDExOlB1bGxSZXF1ZXN0NDMwMTE4NzU=
2,737
Avoid altering dictionary size during iteration
{ "avatar_url": "https://avatars.githubusercontent.com/u/46775?v=4", "events_url": "https://api.github.com/users/mjpieters/events{/privacy}", "followers_url": "https://api.github.com/users/mjpieters/followers", "following_url": "https://api.github.com/users/mjpieters/following{/other_user}", "gists_url": "https://api.github.com/users/mjpieters/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/mjpieters", "id": 46775, "login": "mjpieters", "node_id": "MDQ6VXNlcjQ2Nzc1", "organizations_url": "https://api.github.com/users/mjpieters/orgs", "received_events_url": "https://api.github.com/users/mjpieters/received_events", "repos_url": "https://api.github.com/users/mjpieters/repos", "site_admin": false, "starred_url": "https://api.github.com/users/mjpieters/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mjpieters/subscriptions", "type": "User", "url": "https://api.github.com/users/mjpieters", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2015-08-21T07:45:10Z
2021-09-08T07:00:44Z
2015-08-21T08:08:19Z
CONTRIBUTOR
resolved
Fixes `RuntimeError` on Python 3 introduced in 53ea23128e375ef84511fd2b22b740eca15d0854
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2737/reactions" }
https://api.github.com/repos/psf/requests/issues/2737/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2737.diff", "html_url": "https://github.com/psf/requests/pull/2737", "merged_at": "2015-08-21T08:08:19Z", "patch_url": "https://github.com/psf/requests/pull/2737.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2737" }
true
[ "Yup, this looks right to me. Thanks @mjpieters!\n" ]
https://api.github.com/repos/psf/requests/issues/2736
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2736/labels{/name}
https://api.github.com/repos/psf/requests/issues/2736/comments
https://api.github.com/repos/psf/requests/issues/2736/events
https://github.com/psf/requests/pull/2736
102,172,749
MDExOlB1bGxSZXF1ZXN0NDI5NDY4ODM=
2,736
quick fix to make session cookies work with mocked HTTP responses
{ "avatar_url": "https://avatars.githubusercontent.com/u/5888989?v=4", "events_url": "https://api.github.com/users/FodT/events{/privacy}", "followers_url": "https://api.github.com/users/FodT/followers", "following_url": "https://api.github.com/users/FodT/following{/other_user}", "gists_url": "https://api.github.com/users/FodT/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/FodT", "id": 5888989, "login": "FodT", "node_id": "MDQ6VXNlcjU4ODg5ODk=", "organizations_url": "https://api.github.com/users/FodT/orgs", "received_events_url": "https://api.github.com/users/FodT/received_events", "repos_url": "https://api.github.com/users/FodT/repos", "site_admin": false, "starred_url": "https://api.github.com/users/FodT/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/FodT/subscriptions", "type": "User", "url": "https://api.github.com/users/FodT", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2015-08-20T16:01:32Z
2021-09-08T07:00:44Z
2015-08-20T16:07:41Z
NONE
resolved
I ran into an issue working with Responses/HTTMock where session cookies were not being set. Tracked it down to here, looked like a quick (possibly dirty?) fix. Doesn't break any tests! Throwing it up here for wider consideration. Comments welcome.
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2736/reactions" }
https://api.github.com/repos/psf/requests/issues/2736/timeline
null
null
false
{ "diff_url": "https://github.com/psf/requests/pull/2736.diff", "html_url": "https://github.com/psf/requests/pull/2736", "merged_at": null, "patch_url": "https://github.com/psf/requests/pull/2736.patch", "url": "https://api.github.com/repos/psf/requests/pulls/2736" }
true
[ "Generally speaking, we don't really believe it's the role of this library to fix abstraction errors in Responses or HTTMock. Our goal is to function with the standard library, which this code does. In rare cases we allow for really obvious differences (e.g. `StringIO`), but we are _extremely_ reluctant to add more...
https://api.github.com/repos/psf/requests/issues/2735
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2735/labels{/name}
https://api.github.com/repos/psf/requests/issues/2735/comments
https://api.github.com/repos/psf/requests/issues/2735/events
https://github.com/psf/requests/issues/2735
102,140,710
MDU6SXNzdWUxMDIxNDA3MTA=
2,735
AttributeError: '_socketobject' object has no attribute 'set_tlsext_host_name'
{ "avatar_url": "https://avatars.githubusercontent.com/u/38136?v=4", "events_url": "https://api.github.com/users/RuudBurger/events{/privacy}", "followers_url": "https://api.github.com/users/RuudBurger/followers", "following_url": "https://api.github.com/users/RuudBurger/following{/other_user}", "gists_url": "https://api.github.com/users/RuudBurger/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/RuudBurger", "id": 38136, "login": "RuudBurger", "node_id": "MDQ6VXNlcjM4MTM2", "organizations_url": "https://api.github.com/users/RuudBurger/orgs", "received_events_url": "https://api.github.com/users/RuudBurger/received_events", "repos_url": "https://api.github.com/users/RuudBurger/repos", "site_admin": false, "starred_url": "https://api.github.com/users/RuudBurger/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/RuudBurger/subscriptions", "type": "User", "url": "https://api.github.com/users/RuudBurger", "user_view_type": "public" }
[]
closed
true
null
[]
null
18
2015-08-20T13:37:51Z
2021-09-08T17:05:26Z
2015-08-20T20:19:59Z
NONE
resolved
Getting a few users who are having this issue when doing requests: https://github.com/RuudBurger/CouchPotatoServer/issues/5239 The call is being done on this line: https://github.com/RuudBurger/CouchPotatoServer/blob/master/couchpotato/core/plugins/base.py#L250 with verify disabled, so I don't understand why it tries to validate the connection in the first place. Is this because of an older pyopenssl installation or do I need to do something else?
{ "avatar_url": "https://avatars.githubusercontent.com/u/38136?v=4", "events_url": "https://api.github.com/users/RuudBurger/events{/privacy}", "followers_url": "https://api.github.com/users/RuudBurger/followers", "following_url": "https://api.github.com/users/RuudBurger/following{/other_user}", "gists_url": "https://api.github.com/users/RuudBurger/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/RuudBurger", "id": 38136, "login": "RuudBurger", "node_id": "MDQ6VXNlcjM4MTM2", "organizations_url": "https://api.github.com/users/RuudBurger/orgs", "received_events_url": "https://api.github.com/users/RuudBurger/received_events", "repos_url": "https://api.github.com/users/RuudBurger/repos", "site_admin": false, "starred_url": "https://api.github.com/users/RuudBurger/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/RuudBurger/subscriptions", "type": "User", "url": "https://api.github.com/users/RuudBurger", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2735/reactions" }
https://api.github.com/repos/psf/requests/issues/2735/timeline
null
completed
null
null
false
[ "Are there other bug reports with more information? There's no way for us to know what's happening based on the information there.\n", "Another one with version information: https://github.com/RuudBurger/CouchPotatoServer/issues/5219\nAnd https://github.com/RuudBurger/CouchPotatoServer/issues/5225\n\nSeems like a...
https://api.github.com/repos/psf/requests/issues/2734
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2734/labels{/name}
https://api.github.com/repos/psf/requests/issues/2734/comments
https://api.github.com/repos/psf/requests/issues/2734/events
https://github.com/psf/requests/issues/2734
101,969,104
MDU6SXNzdWUxMDE5NjkxMDQ=
2,734
PyOpenSSL support doesn't work with TLSv1.1 and TLSv1.2
{ "avatar_url": "https://avatars.githubusercontent.com/u/3266662?v=4", "events_url": "https://api.github.com/users/itamarst/events{/privacy}", "followers_url": "https://api.github.com/users/itamarst/followers", "following_url": "https://api.github.com/users/itamarst/following{/other_user}", "gists_url": "https://api.github.com/users/itamarst/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/itamarst", "id": 3266662, "login": "itamarst", "node_id": "MDQ6VXNlcjMyNjY2NjI=", "organizations_url": "https://api.github.com/users/itamarst/orgs", "received_events_url": "https://api.github.com/users/itamarst/received_events", "repos_url": "https://api.github.com/users/itamarst/repos", "site_admin": false, "starred_url": "https://api.github.com/users/itamarst/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/itamarst/subscriptions", "type": "User", "url": "https://api.github.com/users/itamarst", "user_view_type": "public" }
[]
closed
true
null
[]
null
1
2015-08-19T18:42:37Z
2021-09-08T22:00:58Z
2015-08-20T01:04:51Z
NONE
resolved
`docker-py` tries to use latest protocol version in the `ssl` module, so use `ssl.PROTOCOL_TLSv1_2`. Unfortunately the version of urllib3 included with requests (and likely upstream?) only has older versions: https://github.com/kennethreitz/requests/blob/master/requests/packages/urllib3/contrib/pyopenssl.py#L71
{ "avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4", "events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}", "followers_url": "https://api.github.com/users/sigmavirus24/followers", "following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}", "gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/sigmavirus24", "id": 240830, "login": "sigmavirus24", "node_id": "MDQ6VXNlcjI0MDgzMA==", "organizations_url": "https://api.github.com/users/sigmavirus24/orgs", "received_events_url": "https://api.github.com/users/sigmavirus24/received_events", "repos_url": "https://api.github.com/users/sigmavirus24/repos", "site_admin": false, "starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions", "type": "User", "url": "https://api.github.com/users/sigmavirus24", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2734/reactions" }
https://api.github.com/repos/psf/requests/issues/2734/timeline
null
completed
null
null
false
[ "So raise this issue against urllib3?\n" ]
https://api.github.com/repos/psf/requests/issues/2733
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2733/labels{/name}
https://api.github.com/repos/psf/requests/issues/2733/comments
https://api.github.com/repos/psf/requests/issues/2733/events
https://github.com/psf/requests/issues/2733
101,965,736
MDU6SXNzdWUxMDE5NjU3MzY=
2,733
"Interrupted System Call" in select.select
{ "avatar_url": "https://avatars.githubusercontent.com/u/41057?v=4", "events_url": "https://api.github.com/users/samv/events{/privacy}", "followers_url": "https://api.github.com/users/samv/followers", "following_url": "https://api.github.com/users/samv/following{/other_user}", "gists_url": "https://api.github.com/users/samv/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/samv", "id": 41057, "login": "samv", "node_id": "MDQ6VXNlcjQxMDU3", "organizations_url": "https://api.github.com/users/samv/orgs", "received_events_url": "https://api.github.com/users/samv/received_events", "repos_url": "https://api.github.com/users/samv/repos", "site_admin": false, "starred_url": "https://api.github.com/users/samv/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/samv/subscriptions", "type": "User", "url": "https://api.github.com/users/samv", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2015-08-19T18:26:42Z
2021-09-08T22:00:57Z
2015-08-20T04:56:39Z
NONE
resolved
Hi there, The `pyopenssl.py` under `requests/packages/urllib3/contrib/pyopenssl.py` is using `select.select` without trapping the exception raised when the underlying _select(2)_ system call returns EINTR. This results in an exception: ``` response = session.request(method, full_url, params=params, timeout=TIMEOUT, headers=HTTP_HEADERS) File ".../.virtualenv/local/lib/python2.7/site-packages/requests/sessions.py", line 465, in request resp = self.send(prep, **send_kwargs) File ".../.virtualenv/local/lib/python2.7/site-packages/requests/sessions.py", line 573, in send r = adapter.send(request, **kwargs) File ".../.virtualenv/local/lib/python2.7/site-packages/requests/adapters.py", line 370, in send timeout=timeout File ".../.virtualenv/local/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py", line 544, in urlopen body=body, headers=headers) File ".../.virtualenv/local/lib/python2.7/site-packages/requests/packages/urllib3/connectionpool.py", line 372, in _make_request httplib_response = conn.getresponse(buffering=True) File "/usr/lib/python2.7/httplib.py", line 1127, in getresponse response.begin() File "/usr/lib/python2.7/httplib.py", line 453, in begin version, status, reason = self._read_status() File "/usr/lib/python2.7/httplib.py", line 409, in _read_status line = self.fp.readline(_MAXLINE + 1) File "/usr/lib/python2.7/socket.py", line 480, in readline data = self._sock.recv(self._rbufsize) File ".../.virtualenv/local/lib/python2.7/site-packages/requests/packages/urllib3/contrib/pyopenssl.py", line 184, in recv [self.socket], [], [], self.socket.gettimeout()) select.error: Interrupted system call ``` Current versions of pyopenssl don't make these calls; perhaps this can be fixed by updating the internal dependency?
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 0, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 0, "url": "https://api.github.com/repos/psf/requests/issues/2733/reactions" }
https://api.github.com/repos/psf/requests/issues/2733/timeline
null
completed
null
null
false
[ "Thanks for reporting this! Unfortunately, this is a urllib3 problem: can you raise this issue over there?\n", "Thanks, logged as shazow/urllib3#700 - I'll follow up with a request to update the internal urllib3 dependency once they deal with it there.\n" ]
https://api.github.com/repos/psf/requests/issues/2732
https://api.github.com/repos/psf/requests
https://api.github.com/repos/psf/requests/issues/2732/labels{/name}
https://api.github.com/repos/psf/requests/issues/2732/comments
https://api.github.com/repos/psf/requests/issues/2732/events
https://github.com/psf/requests/issues/2732
101,857,235
MDU6SXNzdWUxMDE4NTcyMzU=
2,732
file:// protocol not available
{ "avatar_url": "https://avatars.githubusercontent.com/u/2722756?v=4", "events_url": "https://api.github.com/users/Moliholy/events{/privacy}", "followers_url": "https://api.github.com/users/Moliholy/followers", "following_url": "https://api.github.com/users/Moliholy/following{/other_user}", "gists_url": "https://api.github.com/users/Moliholy/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Moliholy", "id": 2722756, "login": "Moliholy", "node_id": "MDQ6VXNlcjI3MjI3NTY=", "organizations_url": "https://api.github.com/users/Moliholy/orgs", "received_events_url": "https://api.github.com/users/Moliholy/received_events", "repos_url": "https://api.github.com/users/Moliholy/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Moliholy/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Moliholy/subscriptions", "type": "User", "url": "https://api.github.com/users/Moliholy", "user_view_type": "public" }
[]
closed
true
null
[]
null
2
2015-08-19T10:23:00Z
2021-09-08T22:00:58Z
2015-08-19T11:40:59Z
NONE
resolved
Hello all, and first of all thanks for this awesome library. While working with requests I was surprised to find out that it doesn't handle the file:// protocol. Even though I understand it's maybe not a key feature of this library it would come in handy for compatibility reasons. Concretely I have sort of a 'Fetcher' class that servers files from a 'Repository', but this repository can be local or remote. In case of being local I tried (unsuccessfully, of course) to use the file:// protocol. Finally it forced me to considerably increase the number of lines of code I needed to handle the issue. For example, something like this would be fine: ``` response = requests.get('file:///Users/User/my_file.txt') ``` So far it raises this exception: ``` File "/usr/local/lib/python2.7/site-packages/requests/sessions.py", line 649, in get_adapter raise InvalidSchema("No connection adapters were found for '%s'" % url) requests.exceptions.InvalidSchema: No connection adapters were found for 'file:///Users/User/my_file.txt' ``` My questions are: 1) Would there be a reason to not to implement this feature? 2) In case there isn't, shall I submit a a pull request, or it is already planned to add this functionality soon?
{ "avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4", "events_url": "https://api.github.com/users/Lukasa/events{/privacy}", "followers_url": "https://api.github.com/users/Lukasa/followers", "following_url": "https://api.github.com/users/Lukasa/following{/other_user}", "gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}", "gravatar_id": "", "html_url": "https://github.com/Lukasa", "id": 1382556, "login": "Lukasa", "node_id": "MDQ6VXNlcjEzODI1NTY=", "organizations_url": "https://api.github.com/users/Lukasa/orgs", "received_events_url": "https://api.github.com/users/Lukasa/received_events", "repos_url": "https://api.github.com/users/Lukasa/repos", "site_admin": false, "starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions", "type": "User", "url": "https://api.github.com/users/Lukasa", "user_view_type": "public" }
{ "+1": 2, "-1": 0, "confused": 0, "eyes": 0, "heart": 0, "hooray": 0, "laugh": 0, "rocket": 0, "total_count": 2, "url": "https://api.github.com/repos/psf/requests/issues/2732/reactions" }
https://api.github.com/repos/psf/requests/issues/2732/timeline
null
completed
null
null
false
[ "Thanks for this issue!\n\nThe reason we don't support the `file://` protocol is because requests is a HTTP library. Our core purpose is to do HTTP: anything else is outside the scope of the core library.\n\nI believe there is a pluggable Transport Adapter for the file protocol floating around. You can also conside...