number
int64
2.59k
7.1k
title
stringlengths
1
290
body
stringlengths
0
36.2k
βŒ€
labels
listlengths
0
4
pull_request
dict
is_pull_request
bool
2 classes
comments
listlengths
0
30
5,650
load_dataset can't work correct with my image data
I have about 20000 images in my folder which divided into 4 folders with class names. When i use load_dataset("my_folder_name", split="train") this function create dataset in which there are only 4 images, the remaining 19000 images were not added there. What is the problem and did not understand. Tried converting imag...
[]
{ "url": null, "html_url": null, "diff_url": null, "patch_url": null, "merged_at": null }
false
[ "Can you post a reproducible code snippet of what you tried to do?\r\n\r\n", "> Can you post a reproducible code snippet of what you tried to do?\n> \n> \n\n```python\nfrom datasets import load_dataset\n\ndataset = load_dataset(\"my_folder_name\", split=\"train\")\n```", "hi @WiNE-iNEFF ! can you please also te...
5,649
The index column created with .to_sql() is dependent on the batch_size when writing
### Describe the bug It seems like the "index" column is designed to be unique? The values are only unique per batch. The SQL index is not a unique index. This can be a problem, for instance, when building a faiss index on a dataset and then trying to match up ids with a sql export. ### Steps to reproduce the ...
[]
{ "url": null, "html_url": null, "diff_url": null, "patch_url": null, "merged_at": null }
false
[ "Thanks for reporting, @lsb. \r\n\r\nWe are investigating it.\r\n\r\nOn the other hand, please note that in the next `datasets` release, the index will not be created by default (see #5583). If you would like to have it, you will need to explicitly pass `index=True`. ", "I think this is low enough priority for me...
5,648
flatten_indices doesn't work with pandas format
### Describe the bug Hi, I noticed that `flatten_indices` throws an error when the batch format is `pandas`. This is probably due to the fact that flatten_indices uses map internally which doesn't accept dataframes as the transformation function output ### Steps to reproduce the bug tabular_data = pd.DataFrame(np.r...
[ { "id": 1935892857, "node_id": "MDU6TGFiZWwxOTM1ODkyODU3", "url": "https://api.github.com/repos/huggingface/datasets/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" } ]
{ "url": null, "html_url": null, "diff_url": null, "patch_url": null, "merged_at": null }
false
[ "Thanks for reporting! This can be fixed by setting the format to `arrow` in `flatten_indices` and restoring the original format after the flattening. I'm working on a PR that reduces the number of the `flatten_indices` calls in our codebase and makes `flatten_indices` a no-op when a dataset does not have an indice...
5,647
Make all print statements optional
### Feature request Make all print statements optional to speed up the development ### Motivation Im loading multiple tiny datasets and all the print statements make the loading slower ### Your contribution I can help contribute
[ { "id": 1935892871, "node_id": "MDU6TGFiZWwxOTM1ODkyODcx", "url": "https://api.github.com/repos/huggingface/datasets/labels/enhancement", "name": "enhancement", "color": "a2eeef", "default": true, "description": "New feature or request" } ]
{ "url": null, "html_url": null, "diff_url": null, "patch_url": null, "merged_at": null }
false
[ "related to #5444 ", "We now log these messages instead of printing them (addressed in #6019), so I'm closing this issue." ]
5,646
Allow self as key in `Features`
Fix #5641
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5646", "html_url": "https://github.com/huggingface/datasets/pull/5646", "diff_url": "https://github.com/huggingface/datasets/pull/5646.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5646.patch", "merged_at": "2023-03-16T17:14...
true
[ "_The documentation is not available anymore as the PR was closed or merged._", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>Show updated benchmarks!</summary>\n\n### Benchmark: benchmark_array_xd.json\n\n| metric | read_batch_formatted_as_numpy after write_array2d | rea...
5,645
Datasets map and select(range()) is giving dill error
### Describe the bug I'm using Huggingface Datasets library to load the dataset in google colab When I do, > data = train_dataset.select(range(10)) or > train_datasets = train_dataset.map( > process_data_to_model_inputs, > batched=True, > batch_size=batch_size, > remove_columns...
[]
{ "url": null, "html_url": null, "diff_url": null, "patch_url": null, "merged_at": null }
false
[ "It looks like an error that we observed once in https://github.com/huggingface/datasets/pull/5166\r\n\r\nCan you try to update `datasets` ?\r\n\r\n```\r\npip install -U datasets\r\n```\r\n\r\nif it doesn't work, can you make sure you don't have packages installed that may modify `dill`'s behavior, such as `apache-...
5,644
Allow direct cast from binary to Audio/Image
To address https://github.com/huggingface/datasets/discussions/5593.
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5644", "html_url": "https://github.com/huggingface/datasets/pull/5644", "diff_url": "https://github.com/huggingface/datasets/pull/5644.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5644.patch", "merged_at": "2023-03-16T14:12...
true
[ "_The documentation is not available anymore as the PR was closed or merged._", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>Show updated benchmarks!</summary>\n\n### Benchmark: benchmark_array_xd.json\n\n| metric | read_batch_formatted_as_numpy after write_array2d | rea...
5,643
Support PyArrow arrays as column values in `from_dict`
For consistency with `pa.Table.from_pydict`, which supports both Python lists and PyArrow arrays as column values. "Fixes" https://discuss.huggingface.co/t/pyarrow-lib-floatarray-did-not-recognize-python-value-type-when-inferring-an-arrow-data-type/33417
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5643", "html_url": "https://github.com/huggingface/datasets/pull/5643", "diff_url": "https://github.com/huggingface/datasets/pull/5643.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5643.patch", "merged_at": "2023-03-16T17:15...
true
[ "_The documentation is not available anymore as the PR was closed or merged._", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>Show updated benchmarks!</summary>\n\n### Benchmark: benchmark_array_xd.json\n\n| metric | read_batch_formatted_as_numpy after write_array2d | rea...
5,642
Bump hfh to 0.11.0
to fix errors like ``` requests.exceptions.HTTPError: 400 Client Error: Bad Request for url: https://hub-ci.huggingface.co/api/datasets/__DUMMY_TRANSFORMERS_USER__/... ``` (e.g. from this [failing CI](https://github.com/huggingface/datasets/actions/runs/4428956210/jobs/7769160997)) 0.11.0 is the current mini...
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5642", "html_url": "https://github.com/huggingface/datasets/pull/5642", "diff_url": "https://github.com/huggingface/datasets/pull/5642.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5642.patch", "merged_at": "2023-03-20T12:26...
true
[ "_The documentation is not available anymore as the PR was closed or merged._", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>Show updated benchmarks!</summary>\n\n### Benchmark: benchmark_array_xd.json\n\n| metric | read_batch_formatted_as_numpy after write_array2d | rea...
5,641
Features cannot be named "self"
### Describe the bug Hi, I noticed that we cannot create a HuggingFace dataset from Pandas DataFrame with a column named `self`. The error seems to be coming from arguments validation in the `Features.from_dict` function. ### Steps to reproduce the bug ```python import datasets dummy_pandas = pd.DataFrame([0...
[]
{ "url": null, "html_url": null, "diff_url": null, "patch_url": null, "merged_at": null }
false
[]
5,640
Less zip false positives
`zipfile.is_zipfile` return false positives for some Parquet files. It causes errors when loading certain parquet datasets, where some files are considered ZIP files by `zipfile.is_zipfile` This is a known issue: https://github.com/python/cpython/issues/72680 At first I wanted to rely only on magic numbers, but t...
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5640", "html_url": "https://github.com/huggingface/datasets/pull/5640", "diff_url": "https://github.com/huggingface/datasets/pull/5640.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5640.patch", "merged_at": "2023-03-16T13:40...
true
[ "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>Show updated benchmarks!</summary>\n\n### Benchmark: benchmark_array_xd.json\n\n| metric | read_batch_formatted_as_numpy after write_array2d | read_batch_formatted_as_numpy after write_flattened_sequence | read_batch_formatted_a...
5,639
Parquet file wrongly recognized as zip prevents loading a dataset
### Describe the bug When trying to `load_dataset_builder` for `HuggingFaceGECLM/StackExchange_Mar2023`, extraction fails, because parquet file [devops-00000-of-00001-22fe902fd8702892.parquet](https://huggingface.co/datasets/HuggingFaceGECLM/StackExchange_Mar2023/resolve/1f8c9a2ab6f7d0f9ae904b8b922e4384592ae1a5/data...
[]
{ "url": null, "html_url": null, "diff_url": null, "patch_url": null, "merged_at": null }
false
[]
5,638
xPath to implement all operations for Path
### Feature request Current xPath implementation is a great extension of Path in order to work with remote objects. However some methods such as `mkdir` are not implemented correctly. It should instead rely on `fsspec` methods, instead of defaulting do `Path` methods which only work locally. ### Motivation I'm using...
[ { "id": 1935892871, "node_id": "MDU6TGFiZWwxOTM1ODkyODcx", "url": "https://api.github.com/repos/huggingface/datasets/labels/enhancement", "name": "enhancement", "color": "a2eeef", "default": true, "description": "New feature or request" } ]
{ "url": null, "html_url": null, "diff_url": null, "patch_url": null, "merged_at": null }
false
[ " I think https://github.com/fsspec/universal_pathlib is the project you are looking for.\r\n\r\n`xPath` has the methods often used in dataset scripts, and `mkdir` is not one of them (`dl_manager`'s role is to \"interact\" with the file system, so using `mkdir` is discouraged).", "Right is there a difference betw...
5,637
IterableDataset with_format does not support 'device' keyword for jax
### Describe the bug As seen here: https://huggingface.co/docs/datasets/use_with_jax dataset.with_format() supports the keyword 'device', to put data on a specific device when loaded as jax. However, when called on an IterableDataset, I got the error `TypeError: with_format() got an unexpected keyword argument 'devi...
[]
{ "url": null, "html_url": null, "diff_url": null, "patch_url": null, "merged_at": null }
false
[ "Hi! Yes, only `torch` is currently supported. Unlike `Dataset`, `IterableDataset` is not PyArrow-backed, so we cannot simply call `to_numpy` on the underlying subtables to format them numerically. Instead, we must manually convert examples to (numeric) arrays while preserving consistency with `Dataset`, which is n...
5,636
Fix CI: ignore C901 ("some_func" is to complex) in `ruff`
idk if I should have added this ignore to `ruff` too, but I added :)
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5636", "html_url": "https://github.com/huggingface/datasets/pull/5636", "diff_url": "https://github.com/huggingface/datasets/pull/5636.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5636.patch", "merged_at": "2023-03-14T16:29...
true
[ "_The documentation is not available anymore as the PR was closed or merged._", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>Show updated benchmarks!</summary>\n\n### Benchmark: benchmark_array_xd.json\n\n| metric | read_batch_formatted_as_numpy after write_array2d | rea...
5,635
Pass custom metadata filename to Image/Audio folders
This is a quick fix. Now it requires to pass data via `data_files` parameters and include a required metadata file there and pass its filename as `metadata_filename` parameter. For example, with the structure like: ``` data images_dir/ im1.jpg im2.jpg ... metadata_dir/ meta_file...
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5635", "html_url": "https://github.com/huggingface/datasets/pull/5635", "diff_url": "https://github.com/huggingface/datasets/pull/5635.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5635.patch", "merged_at": null }
true
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_5635). All of your documentation changes will be reflected on that endpoint.", "I'm not a big fan of this new param - I find assigning metadata files to splits via the `data_files` param cleaner. Also, assuming that the metadat...
5,634
Not all progress bars are showing up when they should for downloading dataset
### Describe the bug During downloading the rotten tomatoes dataset, not all progress bars are displayed properly. This might be related to [this ticket](https://github.com/huggingface/datasets/issues/5117) as it raised the same concern but its not clear if the fix solves this issue too. ipywidgets <img width=...
[]
{ "url": null, "html_url": null, "diff_url": null, "patch_url": null, "merged_at": null }
false
[ "Hi! \r\n\r\nBy default, tqdm has `leave=True` to \"keep all traces of the progress bar upon the termination of iteration\". However, we use `leave=False` in some places (as of recently), which removes the bar once the iteration is over.\r\n\r\nI feel like our TQDM bars are noisy, so I think we should always set `l...
5,633
Cannot import datasets
### Describe the bug Hi, I cannot even import the library :( I installed it by running: ``` $ conda install datasets ``` Then I realized I should maybe use the huggingface channel, because I encountered the error below, so I ran: ``` $ conda remove datasets $ conda install -c huggingface datasets ``` Pl...
[]
{ "url": null, "html_url": null, "diff_url": null, "patch_url": null, "merged_at": null }
false
[ "Okay, the issue was likely caused by mixing `conda` and `pip` usage - I forgot that I have already used `pip` in this environment previously and that it was 'spoiled' because of it. Creating another environment and installing `datasets` by pip with other packages from the `requirements.txt` file solved the problem...
5,632
Dataset cannot convert too large dictionnary
### Describe the bug Hello everyone! I tried to build a new dataset with the command "dict_valid = datasets.Dataset.from_dict({'input_values': values_array})". However, I have a very large dataset (~400Go) and it seems that dataset cannot handle this. Indeed, I can create the dataset until a certain size of m...
[]
{ "url": null, "html_url": null, "diff_url": null, "patch_url": null, "merged_at": null }
false
[ "Answered on the forum:\r\n\r\n> To fix the overflow error, we need to merge [support LargeListArray in pyarrow by xwwwwww Β· Pull Request #4800 Β· huggingface/datasets Β· GitHub](https://github.com/huggingface/datasets/pull/4800), which adds support for the large lists. However, before merging it, we need to come up ...
5,631
Custom split names
### Feature request Hi, I participated in multiple NLP tasks where there are more than just train, test, validation splits, there could be multiple validation sets or test sets. But it seems currently only those mentioned three splits supported. It would be nice to have the support for more splits on the hub. (curren...
[ { "id": 1935892871, "node_id": "MDU6TGFiZWwxOTM1ODkyODcx", "url": "https://api.github.com/repos/huggingface/datasets/labels/enhancement", "name": "enhancement", "color": "a2eeef", "default": true, "description": "New feature or request" } ]
{ "url": null, "html_url": null, "diff_url": null, "patch_url": null, "merged_at": null }
false
[ "Hi!\r\n\r\nYou can also use names other than \"train\", \"validation\" and \"test\". As an example, check the [script](https://huggingface.co/datasets/mozilla-foundation/common_voice_11_0/blob/e095840f23f3dffc1056c078c2f9320dad9ca74d/common_voice_11_0.py#L139) of the Common Voice 11 dataset. " ]
5,630
adds early exit if url is `PathLike`
Closes #4864 Should fix errors thrown when attempting to load `json` dataset using `pathlib.Path` in `data_files` argument.
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5630", "html_url": "https://github.com/huggingface/datasets/pull/5630", "diff_url": "https://github.com/huggingface/datasets/pull/5630.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5630.patch", "merged_at": null }
true
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_5630). All of your documentation changes will be reflected on that endpoint." ]
5,629
load_dataset gives "403" error when using Financial phrasebank
When I try to load this dataset, I receive the following error: ConnectionError: Couldn't reach https://www.researchgate.net/profile/Pekka_Malo/publication/251231364_FinancialPhraseBank-v10/data/0c96051eee4fb1d56e000000/FinancialPhraseBank-v10.zip (error 403) Has this been seen before? Thanks. The website loads ...
[]
{ "url": null, "html_url": null, "diff_url": null, "patch_url": null, "merged_at": null }
false
[ "Hi! You seem to be using an outdated version of `datasets` that downloads the older script version. To avoid the error, you can either pass `revision=\"main\"` to `load_dataset` (this can fail if a script uses newer features of the lib) or update your installation with `pip install -U datasets` (better solution)."...
5,628
add kwargs to index search
This PR proposes to add kwargs to index search methods. This is particularly useful for setting the timeout of a query on elasticsearch. A typical use case would be: ```python dset.add_elasticsearch_index("filename", es_client=es_client) scores, examples = dset.get_nearest_examples("filename", "my_name-train_2...
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5628", "html_url": "https://github.com/huggingface/datasets/pull/5628", "diff_url": "https://github.com/huggingface/datasets/pull/5628.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5628.patch", "merged_at": "2023-03-15T14:46...
true
[ "_The documentation is not available anymore as the PR was closed or merged._" ]
5,627
Unable to load AutoTrain-generated dataset from the hub
### Describe the bug DatasetGenerationError: An error occurred while generating the dataset -> ValueError: Couldn't cast ... because column names don't match ``` ValueError: Couldn't cast _data_files: list<item: struct<filename: string>> child 0, item: struct<filename: string> child 0, filename: string ...
[]
{ "url": null, "html_url": null, "diff_url": null, "patch_url": null, "merged_at": null }
false
[ "The AutoTrain format is not supported right now. I think it would require a dedicated dataset builder", "Okay, good to know. Thanks for the reply. For now I will just have to\nmanage the split manually before training, because I can’t find any way of\npulling out file indices or file names from the autogenerated...
5,626
Support streaming datasets with numpy.load
Support streaming datasets with `numpy.load`. See: https://huggingface.co/datasets/qgallouedec/gia_dataset/discussions/1
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5626", "html_url": "https://github.com/huggingface/datasets/pull/5626", "diff_url": "https://github.com/huggingface/datasets/pull/5626.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5626.patch", "merged_at": "2023-03-21T06:28...
true
[ "_The documentation is not available anymore as the PR was closed or merged._", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>Show updated benchmarks!</summary>\n\n### Benchmark: benchmark_array_xd.json\n\n| metric | read_batch_formatted_as_numpy after write_array2d | rea...
5,625
Allow "jsonl" data type signifier
### Feature request `load_dataset` currently does not accept `jsonl` as type but only `json`. ### Motivation I was working with one of the `run_translation` scripts and used my own datasets (`.jsonl`) as train_dataset. But the default code did not work because ``` FileNotFoundError: Couldn't find a dataset scri...
[ { "id": 1935892871, "node_id": "MDU6TGFiZWwxOTM1ODkyODcx", "url": "https://api.github.com/repos/huggingface/datasets/labels/enhancement", "name": "enhancement", "color": "a2eeef", "default": true, "description": "New feature or request" } ]
{ "url": null, "html_url": null, "diff_url": null, "patch_url": null, "merged_at": null }
false
[ "You can use \"json\" instead. It doesn't work by extension names, but rather by dataset builder names, e.g. \"text\", \"imagefolder\", etc. I don't think the example in `transformers` is correct because of that", "Yes, I understand the reasoning but this issue is to propose that the example in transformers (whil...
5,624
glue datasets returning -1 for test split
### Describe the bug Downloading any dataset from GLUE has -1 as class labels for test split. Train and validation have regular 0/1 class labels. This is also present in the dataset card online. ### Steps to reproduce the bug ``` dataset = load_dataset("glue", "sst2") for d in dataset: # prints out -1 ...
[]
{ "url": null, "html_url": null, "diff_url": null, "patch_url": null, "merged_at": null }
false
[ "Hi @lithafnium, thanks for reporting.\r\n\r\nPlease note that you can use the \"Community\" tab in the corresponding dataset page to start any discussion: https://huggingface.co/datasets/glue/discussions\r\n\r\nIndeed this issue was already raised there (https://huggingface.co/datasets/glue/discussions/5) and answ...
5,623
Remove set_access_token usage + fail tests if FutureWarning
`set_access_token` is deprecated and will be removed in `huggingface_hub>=0.14`. This PR removes it from the tests (it was not used in `datasets` source code itself). FYI, it was not needed since `set_access_token` was just setting git credentials and `datasets` doesn't seem to use git anywhere. In the future, us...
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5623", "html_url": "https://github.com/huggingface/datasets/pull/5623", "diff_url": "https://github.com/huggingface/datasets/pull/5623.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5623.patch", "merged_at": "2023-03-09T15:31...
true
[ "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==6.0.0\n\n<details>\n<summary>Show updated benchmarks!</summary>\n\n### Benchmark: benchmark_array_xd.json\n\n| metric | read_batch_formatted_as_numpy after write_array2d | read_batch_formatted_as_numpy after write_flattened_sequence | read_batch_formatted_a...
5,622
Update README template to better template
null
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5622", "html_url": "https://github.com/huggingface/datasets/pull/5622", "diff_url": "https://github.com/huggingface/datasets/pull/5622.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5622.patch", "merged_at": null }
true
[ "IMO this template should stay generic.\r\n\r\nAlso, we now use [the card template](https://github.com/huggingface/huggingface_hub/blob/main/src/huggingface_hub/templates/datasetcard_template.md) from `hugginface_hub` as the source of truth on the Hub (you now have the option to import it into the dataset card/READ...
5,621
Adding Oracle Cloud to docs
Adding Oracle Cloud's fsspec implementation to the list of supported cloud storage providers.
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5621", "html_url": "https://github.com/huggingface/datasets/pull/5621", "diff_url": "https://github.com/huggingface/datasets/pull/5621.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5621.patch", "merged_at": "2023-03-11T00:49...
true
[ "_The documentation is not available anymore as the PR was closed or merged._", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>Show updated benchmarks!</summary>\n\n### Benchmark: benchmark_array_xd.json\n\n| metric | read_batch_formatted_as_numpy after write_array2d | rea...
5,620
Bump pyarrow to 8.0.0
Fix those for Pandas 2.0 (tested [here](https://github.com/huggingface/datasets/actions/runs/4346221280/jobs/7592010397) with pandas==2.0.0.rc0): ```python =========================== short test summary info ============================ FAILED tests/test_arrow_dataset.py::BaseDatasetTest::test_to_parquet_in_memory...
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5620", "html_url": "https://github.com/huggingface/datasets/pull/5620", "diff_url": "https://github.com/huggingface/datasets/pull/5620.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5620.patch", "merged_at": "2023-03-08T13:54...
true
[ "_The documentation is not available anymore as the PR was closed or merged._", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==6.0.0\n\n<details>\n<summary>Show updated benchmarks!</summary>\n\n### Benchmark: benchmark_array_xd.json\n\n| metric | read_batch_formatted_as_numpy after write_array2d | rea...
5,619
unpin fsspec
close https://github.com/huggingface/datasets/issues/5618
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5619", "html_url": "https://github.com/huggingface/datasets/pull/5619", "diff_url": "https://github.com/huggingface/datasets/pull/5619.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5619.patch", "merged_at": "2023-03-07T13:39...
true
[ "_The documentation is not available anymore as the PR was closed or merged._", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==6.0.0\n\n<details>\n<summary>Show updated benchmarks!</summary>\n\n### Benchmark: benchmark_array_xd.json\n\n| metric | read_batch_formatted_as_numpy after write_array2d | rea...
5,618
Unpin fsspec < 2023.3.0 once issue fixed
Unpin `fsspec` upper version once root cause of our CI break is fixed. See: - #5614
[]
{ "url": null, "html_url": null, "diff_url": null, "patch_url": null, "merged_at": null }
false
[]
5,617
Fix CI by temporarily pinning fsspec < 2023.3.0
As a hotfix for our CI, temporarily pin `fsspec`: Fix #5616. Until root cause is fixed, see: - #5614
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5617", "html_url": "https://github.com/huggingface/datasets/pull/5617", "diff_url": "https://github.com/huggingface/datasets/pull/5617.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5617.patch", "merged_at": "2023-03-07T08:37...
true
[ "_The documentation is not available anymore as the PR was closed or merged._", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==6.0.0\n\n<details>\n<summary>Show updated benchmarks!</summary>\n\n### Benchmark: benchmark_array_xd.json\n\n| metric | read_batch_formatted_as_numpy after write_array2d | rea...
5,616
CI is broken after fsspec-2023.3.0 release
As reported by @lhoestq, our CI is broken after `fsspec` 2023.3.0 release: ``` FAILED tests/test_filesystem.py::test_compression_filesystems[Bz2FileSystem] - AssertionError: assert [{'created': ...: False, ...}] == ['file.txt'] At index 0 diff: {'name': 'file.txt', 'size': 70, 'type': 'file', 'created': 1678175677...
[ { "id": 1935892857, "node_id": "MDU6TGFiZWwxOTM1ODkyODU3", "url": "https://api.github.com/repos/huggingface/datasets/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" } ]
{ "url": null, "html_url": null, "diff_url": null, "patch_url": null, "merged_at": null }
false
[]
5,615
IterableDataset.add_column is unable to accept another IterableDataset as a parameter.
### Describe the bug `IterableDataset.add_column` occurs an exception when passing another `IterableDataset` as a parameter. The method seems to accept only eager evaluated values. https://github.com/huggingface/datasets/blob/35b789e8f6826b6b5a6b48fcc2416c890a1f326a/src/datasets/iterable_dataset.py#L1388-L1391 ...
[ { "id": 1935892913, "node_id": "MDU6TGFiZWwxOTM1ODkyOTEz", "url": "https://api.github.com/repos/huggingface/datasets/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": "This will not be worked on" } ]
{ "url": null, "html_url": null, "diff_url": null, "patch_url": null, "merged_at": null }
false
[ "Hi! You can use `concatenate_datasets([ids1, ids2], axis=1)` to do this." ]
5,614
Fix archive fs test
null
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5614", "html_url": "https://github.com/huggingface/datasets/pull/5614", "diff_url": "https://github.com/huggingface/datasets/pull/5614.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5614.patch", "merged_at": "2023-03-07T13:20...
true
[ "_The documentation is not available anymore as the PR was closed or merged._", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==6.0.0\n\n<details>\n<summary>Show updated benchmarks!</summary>\n\n### Benchmark: benchmark_array_xd.json\n\n| metric | read_batch_formatted_as_numpy after write_array2d | rea...
5,613
Version mismatch with multiprocess and dill on Python 3.10
### Describe the bug Grabbing the latest version of `datasets` and `apache-beam` with `poetry` using Python 3.10 gives a crash at runtime. The crash is ``` File "/Users/adpauls/sc/git/DSI-transformers/data/NQ/create_NQ_train_vali.py", line 1, in <module> import datasets File "/Users/adpauls/Library/Caches/...
[]
{ "url": null, "html_url": null, "diff_url": null, "patch_url": null, "merged_at": null }
false
[ "Sorry, I just found https://github.com/apache/beam/issues/24458. It seems this issue is being worked on. ", "Reopening, since I think the docs should inform the user of this problem. For example, [this page](https://huggingface.co/docs/datasets/installation) says \r\n> Datasets is tested on Python 3.7+.\r\n\r\nb...
5,612
Arrow map type in parquet files unsupported
### Describe the bug When I try to load parquet files that were processed with Spark, I get the following issue: `ValueError: Arrow type map<string, string ('warc_headers')> does not have a datasets dtype equivalent.` Strangely, loading the dataset with `streaming=True` solves the issue. ### Steps to reproduce ...
[]
{ "url": null, "html_url": null, "diff_url": null, "patch_url": null, "merged_at": null }
false
[ "I'm attaching a minimal reproducible example:\r\n```python\r\nfrom datasets import load_dataset\r\nimport pyarrow as pa\r\nimport pyarrow.parquet as pq\r\n\r\ntable_with_map = pa.Table.from_pydict(\r\n {\"a\": [1, 2], \"b\": [[(\"a\", 2)], [(\"b\", 4)]]},\r\n schema=pa.schema({\"a\": pa.int32(), \"b\": pa.ma...
5,611
add Dataset.to_list
close https://github.com/huggingface/datasets/issues/5606 This PR is for adding the `Dataset.to_list` method. Thank you in advance.
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5611", "html_url": "https://github.com/huggingface/datasets/pull/5611", "diff_url": "https://github.com/huggingface/datasets/pull/5611.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5611.patch", "merged_at": "2023-03-27T13:26...
true
[ "_The documentation is not available anymore as the PR was closed or merged._", "Hi, thanks for working on this! `Table.to_pylist` requires PyArrow 7.0+, and our minimal version requirement is 6.0, so we need to bump the version requirement to avoid CI failure. I'll do this in a separate PR.", "<details>\n<summ...
5,610
use datasets streaming mode in trainer ddp mode cause memory leak
### Describe the bug use datasets streaming mode in trainer ddp mode cause memory leak ### Steps to reproduce the bug import os import time import datetime import sys import numpy as np import random import torch from torch.utils.data import Dataset, DataLoader, random_split, RandomSampler, Sequenti...
[]
{ "url": null, "html_url": null, "diff_url": null, "patch_url": null, "merged_at": null }
false
[ "Same problem, \r\ntransformers 4.28.1\r\ndatasets 2.12.0\r\n\r\nleak around 100Mb per 10 seconds when use dataloader_num_werker > 0 in training argumennts for transformer train, possile bug in transformers repo, but still not found solution :(\r\n", "found an article described a problem, may be helpful for someb...
5,609
`load_from_disk` vs `load_dataset` performance.
### Describe the bug I have downloaded `openwebtext` (~12GB) and filtered out a small amount of junk (it's still huge). Now, I would like to use this filtered version for future work. It seems I have two choices: 1. Use `load_dataset` each time, relying on the cache mechanism, and re-run my filtering. 2. `save_to_di...
[]
{ "url": null, "html_url": null, "diff_url": null, "patch_url": null, "merged_at": null }
false
[ "Hi! We've recently made some improvements to `save_to_disk`/`list_to_disk` (100x faster in some scenarios), so it would help if you could install `datasets` directly from `main` (`pip install git+https://github.com/huggingface/datasets.git`) and re-run the \"benchmark\".", "Great to hear! I'll give it a try when...
5,608
audiofolder only creates dataset of 13 rows (files) when the data folder it's reading from has 20,000 mp3 files.
### Describe the bug x = load_dataset("audiofolder", data_dir="x") When running this, x is a dataset of 13 rows (files) when it should be 20,000 rows (files) as the data_dir "x" has 20,000 mp3 files. Does anyone know what could possibly cause this (naming convention of mp3 files, etc.) ### Steps to reproduce the b...
[]
{ "url": null, "html_url": null, "diff_url": null, "patch_url": null, "merged_at": null }
false
[ "Hi!\r\n\r\n> naming convention of mp3 files\r\n\r\nYes, this could be the problem. MP3 files should end with `.mp3`/`.MP3` to be recognized as audio files.\r\n\r\nIf the file names are not the culprit, can you paste the audio folder's directory structure to help us reproduce the error (e.g., by running the `tree ...
5,607
Fix outdated `verification_mode` values
~I think it makes sense not to save `dataset_info.json` file to a dataset cache directory when loading dataset with `verification_mode="no_checks"` because otherwise when next time the dataset is loaded **without** `verification_mode="no_checks"`, it will be loaded successfully, despite some values in info might not co...
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5607", "html_url": "https://github.com/huggingface/datasets/pull/5607", "diff_url": "https://github.com/huggingface/datasets/pull/5607.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5607.patch", "merged_at": "2023-03-09T17:27...
true
[ "_The documentation is not available anymore as the PR was closed or merged._", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>Show updated benchmarks!</summary>\n\n### Benchmark: benchmark_array_xd.json\n\n| metric | read_batch_formatted_as_numpy after write_array2d | rea...
5,606
Add `Dataset.to_list` to the API
Since there is `Dataset.from_list` in the API, we should also add `Dataset.to_list` to be consistent. Regarding the implementation, we can re-use `Dataset.to_dict`'s code and replace the `to_pydict` calls with `to_pylist`.
[ { "id": 1935892871, "node_id": "MDU6TGFiZWwxOTM1ODkyODcx", "url": "https://api.github.com/repos/huggingface/datasets/labels/enhancement", "name": "enhancement", "color": "a2eeef", "default": true, "description": "New feature or request" }, { "id": 1935892877, "node_id": "MDU6...
{ "url": null, "html_url": null, "diff_url": null, "patch_url": null, "merged_at": null }
false
[ "Hello, I have an interest in this issue.\r\nIs the `Dataset.to_dict` you are describing correct in the code here?\r\n\r\nhttps://github.com/huggingface/datasets/blob/35b789e8f6826b6b5a6b48fcc2416c890a1f326a/src/datasets/arrow_dataset.py#L4633-L4667", "Yes, this is where `Dataset.to_dict` is defined.", "#self-a...
5,605
Update README logo
null
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5605", "html_url": "https://github.com/huggingface/datasets/pull/5605", "diff_url": "https://github.com/huggingface/datasets/pull/5605.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5605.patch", "merged_at": "2023-03-03T21:50...
true
[ "_The documentation is not available anymore as the PR was closed or merged._", "Are you sure it's safe to remove? https://github.com/huggingface/datasets/pull/3866", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==6.0.0\n\n<details>\n<summary>Show updated benchmarks!</summary>\n\n### Benchmark: benc...
5,604
Problems with downloading The Pile
### Describe the bug The downloads in the screenshot seem to be interrupted after some time and the last download throws a "Read timed out" error. ![image](https://user-images.githubusercontent.com/11065386/222687870-ec5fcb65-84e8-467d-9593-4ad7bdac4d50.png) Here are the downloaded files: ![image](https://user-...
[]
{ "url": null, "html_url": null, "diff_url": null, "patch_url": null, "merged_at": null }
false
[ "Hi! \r\n\r\n\r\nYou can specify `download_config=DownloadConfig(resume_download=True))` in `load_dataset` to resume the download when re-running the code after the timeout error:\r\n```python\r\nfrom datasets import load_dataset, DownloadConfig\r\ndataset = load_dataset('the_pile', split='train', cache_dir='F:\\da...
5,603
Don't compute checksums if not necessary in `datasets-cli test`
we only need them if there exists a `dataset_infos.json`
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5603", "html_url": "https://github.com/huggingface/datasets/pull/5603", "diff_url": "https://github.com/huggingface/datasets/pull/5603.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5603.patch", "merged_at": "2023-03-03T15:38...
true
[ "_The documentation is not available anymore as the PR was closed or merged._", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==6.0.0\n\n<details>\n<summary>Show updated benchmarks!</summary>\n\n### Benchmark: benchmark_array_xd.json\n\n| metric | read_batch_formatted_as_numpy after write_array2d | rea...
5,602
Return dict structure if columns are lists - to_tf_dataset
This PR introduces new logic to `to_tf_dataset` affecting the returned data structure, enabling a dictionary structure to be returned, even if only one feature column is selected. If the passed in `columns` or `label_cols` to `to_tf_dataset` are a list, they are returned as a dictionary, respectively. If they are a...
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5602", "html_url": "https://github.com/huggingface/datasets/pull/5602", "diff_url": "https://github.com/huggingface/datasets/pull/5602.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5602.patch", "merged_at": null }
true
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_5602). All of your documentation changes will be reflected on that endpoint.", "This is a great PR! Thinking about the UX though, maybe we could do it without the extra argument? Before this PR, the logic in `to_tf_dataset` was...
5,601
Authorization error
### Describe the bug Get `Authorization error` when try to push data into hugginface datasets hub. ### Steps to reproduce the bug I did all steps in the [tutorial](https://huggingface.co/docs/datasets/share), 1. `huggingface-cli login` with WRITE token 2. `git lfs install` 3. `git clone https://huggingfa...
[]
{ "url": null, "html_url": null, "diff_url": null, "patch_url": null, "merged_at": null }
false
[ "Hi! \r\n\r\nIt's better to report this kind of issue in the `huggingface_hub` repo, so if you still haven't resolved it, I suggest you open an issue there.", "Yeah, I solved it. Problem was in osxkeychain. When I do `hugginface-cli login` it's add token with default account (username)`hg_user` but my repo cont...
5,600
Dataloader getitem not working for DreamboothDatasets
### Describe the bug Dataloader getitem is not working as before (see example of [DreamboothDatasets](https://github.com/huggingface/peft/blob/main/examples/lora_dreambooth/train_dreambooth.py#L451C14-L529)) moving Datasets to 2.8.0 solved the issue. ### Steps to reproduce the bug 1- using DreamBoothDataset ...
[]
{ "url": null, "html_url": null, "diff_url": null, "patch_url": null, "merged_at": null }
false
[ "Hi! \r\n\r\n> (see example of DreamboothDatasets)\r\n\r\n\r\nCould you please provide a link to it? If you are referring to the example in the `diffusers` repo, your issue is unrelated to `datasets` as that example uses `Dataset` from PyTorch to load data." ]
5,598
Fix push_to_hub with no dataset_infos
As reported in https://github.com/vijaydwivedi75/lrgb/issues/10, `push_to_hub` fails if the remote repository already exists and has a README.md without `dataset_info` in the YAML tags cc @clefourrier
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5598", "html_url": "https://github.com/huggingface/datasets/pull/5598", "diff_url": "https://github.com/huggingface/datasets/pull/5598.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5598.patch", "merged_at": "2023-03-02T13:40...
true
[ "_The documentation is not available anymore as the PR was closed or merged._", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==6.0.0\n\n<details>\n<summary>Show updated benchmarks!</summary>\n\n### Benchmark: benchmark_array_xd.json\n\n| metric | read_batch_formatted_as_numpy after write_array2d | rea...
5,597
in-place dataset update
### Motivation For the circumstance that I creat an empty `Dataset` and keep appending new rows into it, I found that it leads to creating a new dataset at each call. It looks quite memory-consuming. I just wonder if there is any more efficient way to do this. ```python from datasets import Dataset ds = Datas...
[ { "id": 1935892913, "node_id": "MDU6TGFiZWwxOTM1ODkyOTEz", "url": "https://api.github.com/repos/huggingface/datasets/labels/wontfix", "name": "wontfix", "color": "ffffff", "default": true, "description": "This will not be worked on" } ]
{ "url": null, "html_url": null, "diff_url": null, "patch_url": null, "merged_at": null }
false
[ "We won't support in-place modifications since `datasets` is based on the Apache Arrow format which doesn't support in-place modifications.\r\n\r\nIn your case the old dataset is garbage collected pretty quickly so you won't have memory issues.\r\n\r\nNote that datasets loaded from disk (memory mapped) are not load...
5,596
[TypeError: Couldn't cast array of type] Can only load a subset of the dataset
### Describe the bug I'm trying to load this [dataset](https://huggingface.co/datasets/bigcode-data/the-stack-gh-issues) which consists of jsonl files and I get the following error: ``` casted_values = _c(array.values, feature[0]) File "/opt/conda/lib/python3.7/site-packages/datasets/table.py", line 1839, in wr...
[]
{ "url": null, "html_url": null, "diff_url": null, "patch_url": null, "merged_at": null }
false
[ "Apparently some JSON objects have a `\"labels\"` field. Since this field is not present in every object, you must specify all the fields types in the README.md\r\n\r\nEDIT: actually specifying the feature types doesn’t solve the issue, it raises an error because β€œlabels” is missing in the data", "We've updated t...
5,595
Unpins sqlAlchemy
Closes #5477
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5595", "html_url": "https://github.com/huggingface/datasets/pull/5595", "diff_url": "https://github.com/huggingface/datasets/pull/5595.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5595.patch", "merged_at": null }
true
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_5595). All of your documentation changes will be reflected on that endpoint.", "It looks like this issue hasn't been fixed yet, so let's wait a bit more.", "@lazarust thanks for your work, but unfortunately we cannot merge it...
5,594
Error while downloading the xtreme udpos dataset
### Describe the bug Hi, I am facing an error while downloading the xtreme udpos dataset using load_dataset. I have datasets 2.10.1 installed ```Downloading and preparing dataset xtreme/udpos.Arabic to /compute/tir-1-18/skhanuja/multilingual_ft/cache/data/xtreme/udpos.Arabic/1.0.0/29f5d57a48779f37ccb75cb8708d1...
[]
{ "url": null, "html_url": null, "diff_url": null, "patch_url": null, "merged_at": null }
false
[ "Hi! I cannot reproduce this error on my machine.\r\n\r\nThe raised error could mean that one of the downloaded files is corrupted. To verify this is not the case, you can run `load_dataset` as follows:\r\n```python\r\ntrain_dataset = load_dataset('xtreme', 'udpos.English', split=\"train\", cache_dir=args.cache_dir...
5,592
Fix docstring example
Fixes #5581 to use the correct output for the `set_format` method.
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5592", "html_url": "https://github.com/huggingface/datasets/pull/5592", "diff_url": "https://github.com/huggingface/datasets/pull/5592.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5592.patch", "merged_at": "2023-02-28T19:19...
true
[ "_The documentation is not available anymore as the PR was closed or merged._", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==6.0.0\n\n<details>\n<summary>Show updated benchmarks!</summary>\n\n### Benchmark: benchmark_array_xd.json\n\n| metric | read_batch_formatted_as_numpy after write_array2d | rea...
5,591
set dev version
null
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5591", "html_url": "https://github.com/huggingface/datasets/pull/5591", "diff_url": "https://github.com/huggingface/datasets/pull/5591.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5591.patch", "merged_at": "2023-02-28T18:09...
true
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_5591). All of your documentation changes will be reflected on that endpoint.", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==6.0.0\n\n<details>\n<summary>Show updated benchmarks!</summary>\n\n### Benchmark: benchma...
5,590
Release: 2.10.1
null
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5590", "html_url": "https://github.com/huggingface/datasets/pull/5590", "diff_url": "https://github.com/huggingface/datasets/pull/5590.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5590.patch", "merged_at": "2023-02-28T18:06...
true
[ "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==6.0.0\n\n<details>\n<summary>Show updated benchmarks!</summary>\n\n### Benchmark: benchmark_array_xd.json\n\n| metric | read_batch_formatted_as_numpy after write_array2d | read_batch_formatted_as_numpy after write_flattened_sequence | read_batch_formatted_a...
5,589
Revert "pass the dataset features to the IterableDataset.from_generator"
This reverts commit b91070b9c09673e2e148eec458036ab6a62ac042 (temporarily) It hurts iterable dataset performance a lot (e.g. x4 slower because it encodes+decodes images unnecessarily). I think we need to fix this before re-adding it cc @mariosasko @Hubert-Bonisseur
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5589", "html_url": "https://github.com/huggingface/datasets/pull/5589", "diff_url": "https://github.com/huggingface/datasets/pull/5589.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5589.patch", "merged_at": null }
true
[ "_The documentation is not available anymore as the PR was closed or merged._", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==6.0.0\n\n<details>\n<summary>Show updated benchmarks!</summary>\n\n### Benchmark: benchmark_array_xd.json\n\n| metric | read_batch_formatted_as_numpy after write_array2d | rea...
5,588
Flatten dataset on the fly in `save_to_disk`
Flatten a dataset on the fly in `save_to_disk` instead of doing it with `flatten_indices` to avoid creating an additional cache file. (this is one of the sub-tasks in https://github.com/huggingface/datasets/issues/5507)
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5588", "html_url": "https://github.com/huggingface/datasets/pull/5588", "diff_url": "https://github.com/huggingface/datasets/pull/5588.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5588.patch", "merged_at": "2023-02-28T17:21...
true
[ "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==6.0.0\n\n<details>\n<summary>Show updated benchmarks!</summary>\n\n### Benchmark: benchmark_array_xd.json\n\n| metric | read_batch_formatted_as_numpy after write_array2d | read_batch_formatted_as_numpy after write_flattened_sequence | read_batch_formatted_a...
5,587
Fix `sort` with indices mapping
Fixes the `key` range in the `query_table` call in `sort` to account for an indices mapping Fix #5586
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5587", "html_url": "https://github.com/huggingface/datasets/pull/5587", "diff_url": "https://github.com/huggingface/datasets/pull/5587.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5587.patch", "merged_at": "2023-02-28T17:21...
true
[ "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==6.0.0\n\n<details>\n<summary>Show updated benchmarks!</summary>\n\n### Benchmark: benchmark_array_xd.json\n\n| metric | read_batch_formatted_as_numpy after write_array2d | read_batch_formatted_as_numpy after write_flattened_sequence | read_batch_formatted_a...
5,586
.sort() is broken when used after .filter(), only in 2.10.0
### Describe the bug Hi, thank you for your support! It seems like the addition of multiple key sort (#5502) in 2.10.0 broke the `.sort()` method. After filtering a dataset with `.filter()`, the `.sort()` seems to refer to the query_table index of the previous unfiltered dataset, resulting in an IndexError. ...
[ { "id": 1935892857, "node_id": "MDU6TGFiZWwxOTM1ODkyODU3", "url": "https://api.github.com/repos/huggingface/datasets/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" } ]
{ "url": null, "html_url": null, "diff_url": null, "patch_url": null, "merged_at": null }
false
[ "Thanks for reporting and thanks @mariosasko for fixing ! We just did a patch release `2.10.1` with the fix" ]
5,585
Cache is not transportable
### Describe the bug I would like to share cache between two machines (a Windows host machine and a WSL instance). I run most my code in WSL. I have just run out of space in the virtual drive. Rather than expand the drive size, I plan to move to cache to the host Windows machine, thereby sharing the downloads. I...
[]
{ "url": null, "html_url": null, "diff_url": null, "patch_url": null, "merged_at": null }
false
[ "Hi ! No the cache is not transportable in general. It will work on a shared filesystem if you use the same python environment, but not across machines/os/environments.\r\n\r\nIn particular, reloading cached datasets does work, but reloading cached processed datasets (e.g. from `map`) may not work. This is because ...
5,584
Unable to load coyo700M dataset
### Describe the bug Seeing this error when downloading https://huggingface.co/datasets/kakaobrain/coyo-700m: ```ArrowInvalid: Parquet magic bytes not found in footer. Either the file is corrupted or this is not a parquet file.``` Full stack trace ```Downloading and preparing dataset parquet/kakaobrain--coy...
[]
{ "url": null, "html_url": null, "diff_url": null, "patch_url": null, "merged_at": null }
false
[ "Hi @manuaero \r\n\r\nThank you for your interest in the COYO dataset.\r\n\r\nOur dataset provides the img-url and alt-text in the form of a parquet, so to utilize the coyo dataset you will need to download it directly.\r\n\r\nWe provide a [guide](https://github.com/kakaobrain/coyo-dataset/blob/main/download/README...
5,583
Do no write index by default when exporting a dataset
Ensures all the writers that use Pandas for conversion (JSON, CSV, SQL) do not export `index` by default (https://github.com/huggingface/datasets/pull/5490 only did this for CSV)
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5583", "html_url": "https://github.com/huggingface/datasets/pull/5583", "diff_url": "https://github.com/huggingface/datasets/pull/5583.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5583.patch", "merged_at": "2023-02-28T13:44...
true
[ "_The documentation is not available anymore as the PR was closed or merged._", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==6.0.0\n\n<details>\n<summary>Show updated benchmarks!</summary>\n\n### Benchmark: benchmark_array_xd.json\n\n| metric | read_batch_formatted_as_numpy after write_array2d | rea...
5,582
Add column_names to IterableDataset
This PR closes #5383 * Add column_names property to IterableDataset * Add multiple tests for this new property
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5582", "html_url": "https://github.com/huggingface/datasets/pull/5582", "diff_url": "https://github.com/huggingface/datasets/pull/5582.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5582.patch", "merged_at": "2023-03-13T19:03...
true
[ "_The documentation is not available anymore as the PR was closed or merged._", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==8.0.0\n\n<details>\n<summary>Show updated benchmarks!</summary>\n\n### Benchmark: benchmark_array_xd.json\n\n| metric | read_batch_formatted_as_numpy after write_array2d | rea...
5,581
[DOC] Mistaken docs on set_format
### Describe the bug https://huggingface.co/docs/datasets/v2.10.0/en/package_reference/main_classes#datasets.Dataset.set_format <img width="700" alt="image" src="https://user-images.githubusercontent.com/36224762/221506973-ae2e3991-60a7-4d4e-99f8-965c6eb61e59.png"> While actually running it will result in: <img w...
[ { "id": 1935892877, "node_id": "MDU6TGFiZWwxOTM1ODkyODc3", "url": "https://api.github.com/repos/huggingface/datasets/labels/good%20first%20issue", "name": "good first issue", "color": "7057ff", "default": true, "description": "Good for newcomers" } ]
{ "url": null, "html_url": null, "diff_url": null, "patch_url": null, "merged_at": null }
false
[ "Thanks for reporting!" ]
5,580
Support cloud storage in load_dataset via fsspec
Closes https://github.com/huggingface/datasets/issues/5281 This PR uses fsspec to support datasets on cloud storage (tested manually with GCS). ETags are currently unsupported for cloud storage. In general, a much larger refactor could be done to just use fsspec for all schemes (ftp, http/s, s3, gcs) to unify the in...
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5580", "html_url": "https://github.com/huggingface/datasets/pull/5580", "diff_url": "https://github.com/huggingface/datasets/pull/5580.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5580.patch", "merged_at": "2023-03-11T00:55...
true
[ "_The documentation is not available anymore as the PR was closed or merged._", "> Regarding the tests I think it should be possible to use the mockfs fixture, it allows to play with a dummy fsspec FileSystem with the \"mock://\" protocol.\r\n\r\n> However it requires some storage_options to be passed. Maybe it c...
5,579
Add instructions to create `DataLoader` from augmented dataset in object detection guide
The following adds instructions on how to create a `DataLoader` from the guide on how to use object detection with augmentations (#4710). I am open to hearing any suggestions for improvement !
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5579", "html_url": "https://github.com/huggingface/datasets/pull/5579", "diff_url": "https://github.com/huggingface/datasets/pull/5579.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5579.patch", "merged_at": null }
true
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_5579). All of your documentation changes will be reflected on that endpoint.", "I'm not sure we need this part as we provide a link to the notebook that shows how to train an object detection model, and this notebook instantiat...
5,578
Add `huggingface_hub` version to env cli command
Add the `huggingface_hub` version to the `env` command's output.
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5578", "html_url": "https://github.com/huggingface/datasets/pull/5578", "diff_url": "https://github.com/huggingface/datasets/pull/5578.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5578.patch", "merged_at": "2023-02-27T17:21...
true
[ "_The documentation is not available anymore as the PR was closed or merged._", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==6.0.0\n\n<details>\n<summary>Show updated benchmarks!</summary>\n\n### Benchmark: benchmark_array_xd.json\n\n| metric | read_batch_formatted_as_numpy after write_array2d | rea...
5,577
Cannot load `the_pile_openwebtext2`
### Describe the bug I met the same bug mentioned in #3053 which is never fixed. Because several `reddit_scores` are larger than `int8` even `int16`. https://huggingface.co/datasets/the_pile_openwebtext2/blob/main/the_pile_openwebtext2.py#L62 ### Steps to reproduce the bug ```python3 from datasets import load...
[]
{ "url": null, "html_url": null, "diff_url": null, "patch_url": null, "merged_at": null }
false
[ "Hi! I've merged a PR to use `int32` instead of `int8` for `reddit_scores`, so it should work now.\r\n\r\n" ]
5,576
I was getting a similar error `pyarrow.lib.ArrowInvalid: Integer value 528 not in range: -128 to 127` - AFAICT, this is because the type specified for `reddit_scores` is `datasets.Sequence(datasets.Value("int8"))`, but the actual values can be well outside the max range for 8-bit integers.
I was getting a similar error `pyarrow.lib.ArrowInvalid: Integer value 528 not in range: -128 to 127` - AFAICT, this is because the type specified for `reddit_scores` is `datasets.Sequence(datasets.Value("int8"))`, but the actual values can be well outside the max range for 8-bit integers. I worked aro...
[]
{ "url": null, "html_url": null, "diff_url": null, "patch_url": null, "merged_at": null }
false
[ "Duplicated issue." ]
5,575
Metadata for each column
### Feature request Being able to put some metadata for each column as a string or any other type. ### Motivation I will bring the motivation by an example, lets say we are experimenting with embedding produced by some image encoder network, and we want to iterate through a couple of preprocessing and see which on...
[ { "id": 1935892871, "node_id": "MDU6TGFiZWwxOTM1ODkyODcx", "url": "https://api.github.com/repos/huggingface/datasets/labels/enhancement", "name": "enhancement", "color": "a2eeef", "default": true, "description": "New feature or request" } ]
{ "url": null, "html_url": null, "diff_url": null, "patch_url": null, "merged_at": null }
false
[ "Hi! Indeed it would be useful to support this. PyArrow natively supports schema-level and column-level metadata, so implementing this should be straightforward. The API I have in mind would work as follows:\r\n```python\r\ncol_feature = Value(\"string\", metadata=\"Some column-level metadata\")\r\n\r\nfeatures = F...
5,574
c4 dataset streaming fails with `FileNotFoundError`
### Describe the bug Loading the `c4` dataset in streaming mode with `load_dataset("c4", "en", split="validation", streaming=True)` and then using it fails with a `FileNotFoundException`. ### Steps to reproduce the bug ```python from datasets import load_dataset dataset = load_dataset("c4", "en", split="train", ...
[]
{ "url": null, "html_url": null, "diff_url": null, "patch_url": null, "merged_at": null }
false
[ "Also encountering this issue for every dataset I try to stream! Installed datasets from main:\r\n```\r\n- `datasets` version: 2.10.1.dev0\r\n- Platform: macOS-13.1-arm64-arm-64bit\r\n- Python version: 3.9.13\r\n- PyArrow version: 10.0.1\r\n- Pandas version: 1.5.2\r\n```\r\n\r\nRepro:\r\n```python\r\nfrom datasets ...
5,573
Use soundfile for mp3 decoding instead of torchaudio
I've removed `torchaudio` completely and switched to use `soundfile` for everything. With the new version of `soundfile` package this should work smoothly because the `libsndfile` C library is bundled, in Linux wheels too. Let me know if you think it's too harsh and we should continue to support `torchaudio` decodi...
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5573", "html_url": "https://github.com/huggingface/datasets/pull/5573", "diff_url": "https://github.com/huggingface/datasets/pull/5573.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5573.patch", "merged_at": "2023-02-28T20:16...
true
[ "_The documentation is not available anymore as the PR was closed or merged._", "@mariosasko thank you for the review! do you have any idea why `test_hash_torch_tensor` fails on \"ubuntu-latest deps-minimum\"? I removed the `torchaudio<0.12.0` test dependency so it uses the latest `torch` now, might it be connect...
5,572
Datasets 2.10.0 does not reuse the dataset cache
### Describe the bug download_mode="reuse_dataset_if_exists" will always consider that a dataset doesn't exist. Specifically, upon losing an internet connection trying to load a dataset for a second time in ten seconds, a connection error results, showing a breakpoint of: ``` File ~/jupyterlab/.direnv/python-...
[]
{ "url": null, "html_url": null, "diff_url": null, "patch_url": null, "merged_at": null }
false
[]
5,571
load_dataset fails for JSON in windows
### Describe the bug Steps: 1. Created a dataset in a Linux VM and created a small sample using dataset.to_json() method. 2. Downloaded the JSON file to my local Windows machine for working and saved in say - r"C:\Users\name\file.json" 3. I am reading the file in my local PyCharm - the location of python file is di...
[]
{ "url": null, "html_url": null, "diff_url": null, "patch_url": null, "merged_at": null }
false
[ "Hi! \r\n\r\nYou need to pass an input json file explicitly as `data_files` to `load_dataset` to avoid this error:\r\n```python\r\n ds = load_dataset(\"json\", data_files=args.input_json)\r\n```\r\n\r\n", "Thanks it worked!" ]
5,570
load_dataset gives FileNotFoundError on imagenet-1k if license is not accepted on the hub
### Describe the bug When calling ```load_dataset('imagenet-1k')``` FileNotFoundError is raised, if not logged in and if logged in with huggingface-cli but not having accepted the licence on the hub. There is no error once accepting. ### Steps to reproduce the bug ``` from datasets import load_dataset imagenet =...
[]
{ "url": null, "html_url": null, "diff_url": null, "patch_url": null, "merged_at": null }
false
[ "Hi, thanks for the feedback! Would it help to add a tip or note saying the dataset is gated and you need to accept the license before downloading it?", "The error is now more informative:\r\n```\r\nFileNotFoundError: Couldn't find a dataset script at /content/imagenet-1k/imagenet-1k.py or any data file in the sa...
5,569
pass the dataset features to the IterableDataset.from_generator function
[5558](https://github.com/huggingface/datasets/issues/5568)
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5569", "html_url": "https://github.com/huggingface/datasets/pull/5569", "diff_url": "https://github.com/huggingface/datasets/pull/5569.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5569.patch", "merged_at": "2023-02-23T18:15...
true
[ "_The documentation is not available anymore as the PR was closed or merged._", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==6.0.0\n\n<details>\n<summary>Show updated benchmarks!</summary>\n\n### Benchmark: benchmark_array_xd.json\n\n| metric | read_batch_formatted_as_numpy after write_array2d | rea...
5,568
dataset.to_iterable_dataset() loses useful info like dataset features
### Describe the bug Hello, I like the new `to_iterable_dataset` feature but I noticed something that seems to be missing. When using `to_iterable_dataset` to transform your map style dataset into iterable dataset, you lose valuable metadata like the features. These metadata are useful if you want to interleav...
[ { "id": 1935892871, "node_id": "MDU6TGFiZWwxOTM1ODkyODcx", "url": "https://api.github.com/repos/huggingface/datasets/labels/enhancement", "name": "enhancement", "color": "a2eeef", "default": true, "description": "New feature or request" }, { "id": 1935892877, "node_id": "MDU6...
{ "url": null, "html_url": null, "diff_url": null, "patch_url": null, "merged_at": null }
false
[ "Hi ! Oh good catch. I think the features should be passed to `IterableDataset.from_generator()` in `to_iterable_dataset()` indeed.\r\n\r\nSetting this as a good first issue if someone would like to contribute, otherwise we can take care of it :)", "#self-assign", "seems like the feature parameter is missing fr...
5,566
Directly reading parquet files in a s3 bucket from the load_dataset method
### Feature request Right now, we have to read the get the parquet file to the local storage. So having ability to read given the bucket directly address would be benificial ### Motivation In a production set up, this feature can help us a lot. So we do not need move training datafiles in between storage. ### Yo...
[ { "id": 1935892865, "node_id": "MDU6TGFiZWwxOTM1ODkyODY1", "url": "https://api.github.com/repos/huggingface/datasets/labels/duplicate", "name": "duplicate", "color": "cfd3d7", "default": true, "description": "This issue or pull request already exists" }, { "id": 1935892871, "...
{ "url": null, "html_url": null, "diff_url": null, "patch_url": null, "merged_at": null }
false
[ "Hi ! I think is in the scope of this other issue: to https://github.com/huggingface/datasets/issues/5281 " ]
5,565
Add writer_batch_size for ArrowBasedBuilder
This way we can control the size of the record_batches/row_groups of arrow/parquet files. This can be useful for `datasets-server` to keep control of the row groups size which can affect random access performance for audio/image/video datasets Right now having 1,000 examples per row group cause some image dataset...
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5565", "html_url": "https://github.com/huggingface/datasets/pull/5565", "diff_url": "https://github.com/huggingface/datasets/pull/5565.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5565.patch", "merged_at": "2023-03-10T13:45...
true
[ "_The documentation is not available anymore as the PR was closed or merged._", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==6.0.0\n\n<details>\n<summary>Show updated benchmarks!</summary>\n\n### Benchmark: benchmark_array_xd.json\n\n| metric | read_batch_formatted_as_numpy after write_array2d | rea...
5,564
Set dev version
null
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5564", "html_url": "https://github.com/huggingface/datasets/pull/5564", "diff_url": "https://github.com/huggingface/datasets/pull/5564.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5564.patch", "merged_at": "2023-02-22T13:00...
true
[ "The docs for this PR live [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_5564). All of your documentation changes will be reflected on that endpoint.", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==6.0.0\n\n<details>\n<summary>Show updated benchmarks!</summary>\n\n### Benchmark: benchma...
5,563
Release: 2.10.0
null
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5563", "html_url": "https://github.com/huggingface/datasets/pull/5563", "diff_url": "https://github.com/huggingface/datasets/pull/5563.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5563.patch", "merged_at": "2023-02-22T12:56...
true
[ "_The documentation is not available anymore as the PR was closed or merged._", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==6.0.0\n\n<details>\n<summary>Show updated benchmarks!</summary>\n\n### Benchmark: benchmark_array_xd.json\n\n| metric | read_batch_formatted_as_numpy after write_array2d | rea...
5,562
Update csv.py
Removed mangle_dup_cols=True from BuilderConfig. It triggered following deprecation warning: /usr/local/lib/python3.8/dist-packages/datasets/download/streaming_download_manager.py:776: FutureWarning: the 'mangle_dupe_cols' keyword is deprecated and will be removed in a future version. Please take steps to stop the ...
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5562", "html_url": "https://github.com/huggingface/datasets/pull/5562", "diff_url": "https://github.com/huggingface/datasets/pull/5562.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5562.patch", "merged_at": "2023-02-23T11:00...
true
[ "_The documentation is not available anymore as the PR was closed or merged._", "Removed it :)", "Changed it :)", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==6.0.0\n\n<details>\n<summary>Show updated benchmarks!</summary>\n\n### Benchmark: benchmark_array_xd.json\n\n| metric | read_batch_format...
5,561
Add pre-commit config yaml file to enable automatic code formatting
@huggingface/datasets do you think it would be useful? Motivation - sometimes PRs are like 30% "fix: style" commits :) If so - I need to double check the config but for me locally it works as expected.
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5561", "html_url": "https://github.com/huggingface/datasets/pull/5561", "diff_url": "https://github.com/huggingface/datasets/pull/5561.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5561.patch", "merged_at": "2023-02-23T18:23...
true
[ "_The documentation is not available anymore as the PR was closed or merged._", "Better yet have someone enable pre-commit CI https://pre-commit.ci/ and it will apply the pre-commit fixes to the PR automatically as an additional commit.", "@Skylion007 hi! I agree with @nateraw here, I'd better not force to use ...
5,560
Ensure last tqdm update in `map`
This PR modifies `map` to: * ensure the TQDM bar gets the last progress update * when a map function fails, avoid throwing a chained exception in the single-proc mode
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5560", "html_url": "https://github.com/huggingface/datasets/pull/5560", "diff_url": "https://github.com/huggingface/datasets/pull/5560.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5560.patch", "merged_at": "2023-02-21T18:19...
true
[ "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==6.0.0\n\n<details>\n<summary>Show updated benchmarks!</summary>\n\n### Benchmark: benchmark_array_xd.json\n\n| metric | read_batch_formatted_as_numpy after write_array2d | read_batch_formatted_as_numpy after write_flattened_sequence | read_batch_formatted_a...
5,559
Fix map suffix_template
#5455 introduced a small bug that lead `map` to ignore the `suffix_template` argument and not put suffixes to cached files in multiprocessing. I fixed this and also improved a few things: - regarding logging: "Loading cached processed dataset" is now logged only once even in multiprocessing (it used to be logged ...
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5559", "html_url": "https://github.com/huggingface/datasets/pull/5559", "diff_url": "https://github.com/huggingface/datasets/pull/5559.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5559.patch", "merged_at": "2023-02-21T17:14...
true
[ "_The documentation is not available anymore as the PR was closed or merged._", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==6.0.0\n\n<details>\n<summary>Show updated benchmarks!</summary>\n\n### Benchmark: benchmark_array_xd.json\n\n| metric | read_batch_formatted_as_numpy after write_array2d | rea...
5,558
Remove instructions for `ffmpeg` system package installation on Colab
Colab now has Ubuntu 20.04 which already has `ffmpeg` of required (>4) version.
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5558", "html_url": "https://github.com/huggingface/datasets/pull/5558", "diff_url": "https://github.com/huggingface/datasets/pull/5558.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5558.patch", "merged_at": "2023-02-23T13:50...
true
[ "_The documentation is not available anymore as the PR was closed or merged._", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==6.0.0\n\n<details>\n<summary>Show updated benchmarks!</summary>\n\n### Benchmark: benchmark_array_xd.json\n\n| metric | read_batch_formatted_as_numpy after write_array2d | rea...
5,557
Add filter desc
Otherwise it would show a `Map` progress bar, since it uses `map` under the hood
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5557", "html_url": "https://github.com/huggingface/datasets/pull/5557", "diff_url": "https://github.com/huggingface/datasets/pull/5557.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5557.patch", "merged_at": "2023-02-21T14:12...
true
[ "_The documentation is not available anymore as the PR was closed or merged._", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==6.0.0\n\n<details>\n<summary>Show updated benchmarks!</summary>\n\n### Benchmark: benchmark_array_xd.json\n\n| metric | read_batch_formatted_as_numpy after write_array2d | rea...
5,556
Use default audio resampling type
...instead of relying on the optional librosa dependency `resampy`. It was only used for `_decode_non_mp3_file_like` anyway and not for the other ones - removing it fixes consistency between decoding methods (except torchaudio decoding) Therefore I think it is a better solution than adding `resampy` as a dependen...
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5556", "html_url": "https://github.com/huggingface/datasets/pull/5556", "diff_url": "https://github.com/huggingface/datasets/pull/5556.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5556.patch", "merged_at": "2023-02-21T12:42...
true
[ "_The documentation is not available anymore as the PR was closed or merged._", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==6.0.0\n\n<details>\n<summary>Show updated benchmarks!</summary>\n\n### Benchmark: benchmark_array_xd.json\n\n| metric | read_batch_formatted_as_numpy after write_array2d | rea...
5,555
`.shuffle` throwing error `ValueError: Protocol not known: parent`
### Describe the bug ``` --------------------------------------------------------------------------- ValueError Traceback (most recent call last) Cell In [16], line 1 ----> 1 train_dataset = train_dataset.shuffle() File /opt/conda/envs/pytorch/lib/python3.9/site-packages/dataset...
[]
{ "url": null, "html_url": null, "diff_url": null, "patch_url": null, "merged_at": null }
false
[ "Hi ! The indices mapping is written in the same cachedirectory as your dataset.\r\n\r\nCan you run this to show your current cache directory ?\r\n```python\r\nprint(train_dataset.cache_files)\r\n```", "```\r\n[{'filename': '.../train/dataset.arrow'}, {'filename': '.../train/dataset.arrow'}]\r\n```\r\n\r\nThese a...
5,554
Add resampy dep
In librosa 0.10 they removed the `resmpy` dependency and set it to optional. However it is necessary for resampling. I added it to the "audio" extra dependencies.
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5554", "html_url": "https://github.com/huggingface/datasets/pull/5554", "diff_url": "https://github.com/huggingface/datasets/pull/5554.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5554.patch", "merged_at": null }
true
[ "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==6.0.0\n\n<details>\n<summary>Show updated benchmarks!</summary>\n\n### Benchmark: benchmark_array_xd.json\n\n| metric | read_batch_formatted_as_numpy after write_array2d | read_batch_formatted_as_numpy after write_flattened_sequence | read_batch_formatted_a...
5,553
improved message error row formatting
Solves #5539
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5553", "html_url": "https://github.com/huggingface/datasets/pull/5553", "diff_url": "https://github.com/huggingface/datasets/pull/5553.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5553.patch", "merged_at": "2023-02-21T12:58...
true
[ "_The documentation is not available anymore as the PR was closed or merged._", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==6.0.0\n\n<details>\n<summary>Show updated benchmarks!</summary>\n\n### Benchmark: benchmark_array_xd.json\n\n| metric | read_batch_formatted_as_numpy after write_array2d | rea...
5,552
Make tiktoken tokenizers hashable
Fix for https://discord.com/channels/879548962464493619/1075729627546406912/1075729627546406912
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5552", "html_url": "https://github.com/huggingface/datasets/pull/5552", "diff_url": "https://github.com/huggingface/datasets/pull/5552.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5552.patch", "merged_at": "2023-02-21T13:13...
true
[ "_The documentation is not available anymore as the PR was closed or merged._", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==6.0.0\n\n<details>\n<summary>Show updated benchmarks!</summary>\n\n### Benchmark: benchmark_array_xd.json\n\n| metric | read_batch_formatted_as_numpy after write_array2d | rea...
5,551
Suggest scikit-learn instead of sklearn
This is kinda unimportant fix but, the suggested `pip install sklearn` does not work. The current error message if sklearn is not installed: ``` ImportError: To be able to use [dataset name], you need to install the following dependency: sklearn. Please install it using 'pip install sklearn' for instance. ``` ...
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5551", "html_url": "https://github.com/huggingface/datasets/pull/5551", "diff_url": "https://github.com/huggingface/datasets/pull/5551.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5551.patch", "merged_at": "2023-02-21T13:21...
true
[ "good catch!", "_The documentation is not available anymore as the PR was closed or merged._", "The test fail is unrelated to this PR and fixed on `main` - merging :)", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==6.0.0\n\n<details>\n<summary>Show updated benchmarks!</summary>\n\n### Benchmark: ...
5,550
Resolve four broken refs in the docs
Hello! ## Pull Request overview * Resolve 4 broken references in the docs ## The problems Two broken references [here](https://huggingface.co/docs/datasets/package_reference/main_classes#datasets.Dataset.class_encode_column): ![image](https://user-images.githubusercontent.com/37621491/220056232-366b64dc-33c9-...
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5550", "html_url": "https://github.com/huggingface/datasets/pull/5550", "diff_url": "https://github.com/huggingface/datasets/pull/5550.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5550.patch", "merged_at": "2023-02-20T15:09...
true
[ "_The documentation is not available anymore as the PR was closed or merged._", "See the resolved changes [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_5550/en/package_reference/main_classes#datasets.Dataset.class_encode_column), [here](https://moon-ci-docs.huggingface.co/docs/datasets/pr_5550/en/pa...
5,549
Apply ruff flake8-comprehension checks
Fix #5548 Apply ruff's flake8-comprehension checks for better performance, and more readable code.
[]
{ "url": "https://api.github.com/repos/huggingface/datasets/pulls/5549", "html_url": "https://github.com/huggingface/datasets/pull/5549", "diff_url": "https://github.com/huggingface/datasets/pull/5549.diff", "patch_url": "https://github.com/huggingface/datasets/pull/5549.patch", "merged_at": "2023-02-23T13:59...
true
[ "_The documentation is not available anymore as the PR was closed or merged._", "<details>\n<summary>Show benchmarks</summary>\n\nPyArrow==6.0.0\n\n<details>\n<summary>Show updated benchmarks!</summary>\n\n### Benchmark: benchmark_array_xd.json\n\n| metric | read_batch_formatted_as_numpy after write_array2d | rea...
5,548
Apply flake8-comprehensions to codebase
### Feature request Apply ruff flake8 comprehension checks to codebase. ### Motivation This should strictly improve the performance / readability of the codebase by removing unnecessary iteration, function calls, etc. This should generate better Python bytecode which should strictly improve performance. I alread...
[ { "id": 1935892871, "node_id": "MDU6TGFiZWwxOTM1ODkyODcx", "url": "https://api.github.com/repos/huggingface/datasets/labels/enhancement", "name": "enhancement", "color": "a2eeef", "default": true, "description": "New feature or request" } ]
{ "url": null, "html_url": null, "diff_url": null, "patch_url": null, "merged_at": null }
false
[]