repo
stringlengths
6
47
file_url
stringlengths
77
269
file_path
stringlengths
5
186
content
stringlengths
0
32.8k
language
stringclasses
1 value
license
stringclasses
7 values
commit_sha
stringlengths
40
40
retrieved_at
stringdate
2026-01-07 08:35:43
2026-01-07 08:55:24
truncated
bool
2 classes
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/pkg/helmpath/home.go
pkg/helmpath/home.go
// Copyright The Helm Authors. // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // http://www.apache.org/licenses/LICENSE-2.0 // Unless required by applicable law or agreed to in writing, software // distributed under the License is distributed on an "AS IS" BASIS, // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License. // Package helmpath calculates filesystem paths to Helm's configuration, cache and data. package helmpath // This helper builds paths to Helm's configuration, cache and data paths. const lp = lazypath("helm") // ConfigPath returns the path where Helm stores configuration. func ConfigPath(elem ...string) string { return lp.configPath(elem...) } // CachePath returns the path where Helm stores cached objects. func CachePath(elem ...string) string { return lp.cachePath(elem...) } // DataPath returns the path where Helm stores data. func DataPath(elem ...string) string { return lp.dataPath(elem...) } // CacheIndexFile returns the path to an index for the given named repository. func CacheIndexFile(name string) string { if name != "" { name += "-" } return name + "index.yaml" } // CacheChartsFile returns the path to a text file listing all the charts // within the given named repository. func CacheChartsFile(name string) string { if name != "" { name += "-" } return name + "charts.txt" }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/pkg/helmpath/lazypath_windows.go
pkg/helmpath/lazypath_windows.go
// Copyright The Helm Authors. // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // http://www.apache.org/licenses/LICENSE-2.0 // Unless required by applicable law or agreed to in writing, software // distributed under the License is distributed on an "AS IS" BASIS, // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License. //go:build windows package helmpath import "os" func dataHome() string { return configHome() } func configHome() string { return os.Getenv("APPDATA") } func cacheHome() string { return os.Getenv("TEMP") }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/pkg/helmpath/home_unix_test.go
pkg/helmpath/home_unix_test.go
// Copyright The Helm Authors. // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to in writing, software // distributed under the License is distributed on an "AS IS" BASIS, // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License. //go:build !windows package helmpath import ( "runtime" "testing" "helm.sh/helm/v4/pkg/helmpath/xdg" ) func TestHelmHome(t *testing.T) { t.Setenv(xdg.CacheHomeEnvVar, "/cache") t.Setenv(xdg.ConfigHomeEnvVar, "/config") t.Setenv(xdg.DataHomeEnvVar, "/data") isEq := func(t *testing.T, got, expected string) { t.Helper() if expected != got { t.Error(runtime.GOOS) t.Errorf("Expected %q, got %q", expected, got) } } isEq(t, CachePath(), "/cache/helm") isEq(t, ConfigPath(), "/config/helm") isEq(t, DataPath(), "/data/helm") // test to see if lazy-loading environment variables at runtime works t.Setenv(xdg.CacheHomeEnvVar, "/cache2") isEq(t, CachePath(), "/cache2/helm") }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/pkg/helmpath/lazypath_windows_test.go
pkg/helmpath/lazypath_windows_test.go
// Copyright The Helm Authors. // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // http://www.apache.org/licenses/LICENSE-2.0 // Unless required by applicable law or agreed to in writing, software // distributed under the License is distributed on an "AS IS" BASIS, // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License. //go:build windows package helmpath import ( "os" "path/filepath" "testing" "k8s.io/client-go/util/homedir" "helm.sh/helm/v4/pkg/helmpath/xdg" ) const ( appName = "helm" testFile = "test.txt" lazy = lazypath(appName) ) func TestDataPath(t *testing.T) { os.Unsetenv(xdg.DataHomeEnvVar) os.Setenv("APPDATA", filepath.Join(homedir.HomeDir(), "foo")) expected := filepath.Join(homedir.HomeDir(), "foo", appName, testFile) if lazy.dataPath(testFile) != expected { t.Errorf("expected '%s', got '%s'", expected, lazy.dataPath(testFile)) } os.Setenv(xdg.DataHomeEnvVar, filepath.Join(homedir.HomeDir(), "xdg")) expected = filepath.Join(homedir.HomeDir(), "xdg", appName, testFile) if lazy.dataPath(testFile) != expected { t.Errorf("expected '%s', got '%s'", expected, lazy.dataPath(testFile)) } } func TestConfigPath(t *testing.T) { os.Unsetenv(xdg.ConfigHomeEnvVar) os.Setenv("APPDATA", filepath.Join(homedir.HomeDir(), "foo")) expected := filepath.Join(homedir.HomeDir(), "foo", appName, testFile) if lazy.configPath(testFile) != expected { t.Errorf("expected '%s', got '%s'", expected, lazy.configPath(testFile)) } os.Setenv(xdg.ConfigHomeEnvVar, filepath.Join(homedir.HomeDir(), "xdg")) expected = filepath.Join(homedir.HomeDir(), "xdg", appName, testFile) if lazy.configPath(testFile) != expected { t.Errorf("expected '%s', got '%s'", expected, lazy.configPath(testFile)) } } func TestCachePath(t *testing.T) { os.Unsetenv(xdg.CacheHomeEnvVar) os.Setenv("TEMP", filepath.Join(homedir.HomeDir(), "foo")) expected := filepath.Join(homedir.HomeDir(), "foo", appName, testFile) if lazy.cachePath(testFile) != expected { t.Errorf("expected '%s', got '%s'", expected, lazy.cachePath(testFile)) } os.Setenv(xdg.CacheHomeEnvVar, filepath.Join(homedir.HomeDir(), "xdg")) expected = filepath.Join(homedir.HomeDir(), "xdg", appName, testFile) if lazy.cachePath(testFile) != expected { t.Errorf("expected '%s', got '%s'", expected, lazy.cachePath(testFile)) } }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/pkg/helmpath/home_windows_test.go
pkg/helmpath/home_windows_test.go
// Copyright The Helm Authors. // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // http://www.apache.org/licenses/LICENSE-2.0 // Unless required by applicable law or agreed to in writing, software // distributed under the License is distributed on an "AS IS" BASIS, // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License. //go:build windows package helmpath import ( "os" "testing" "helm.sh/helm/v4/pkg/helmpath/xdg" ) func TestHelmHome(t *testing.T) { os.Setenv(xdg.CacheHomeEnvVar, "c:\\") os.Setenv(xdg.ConfigHomeEnvVar, "d:\\") os.Setenv(xdg.DataHomeEnvVar, "e:\\") isEq := func(t *testing.T, a, b string) { if a != b { t.Errorf("Expected %q, got %q", b, a) } } isEq(t, CachePath(), "c:\\helm") isEq(t, ConfigPath(), "d:\\helm") isEq(t, DataPath(), "e:\\helm") // test to see if lazy-loading environment variables at runtime works os.Setenv(xdg.CacheHomeEnvVar, "f:\\") isEq(t, CachePath(), "f:\\helm") }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/pkg/helmpath/lazypath_darwin.go
pkg/helmpath/lazypath_darwin.go
// Copyright The Helm Authors. // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // http://www.apache.org/licenses/LICENSE-2.0 // Unless required by applicable law or agreed to in writing, software // distributed under the License is distributed on an "AS IS" BASIS, // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License. //go:build darwin package helmpath import ( "path/filepath" "k8s.io/client-go/util/homedir" ) func dataHome() string { return filepath.Join(homedir.HomeDir(), "Library") } func configHome() string { return filepath.Join(homedir.HomeDir(), "Library", "Preferences") } func cacheHome() string { return filepath.Join(homedir.HomeDir(), "Library", "Caches") }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/pkg/helmpath/xdg/xdg.go
pkg/helmpath/xdg/xdg.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ // Package xdg holds constants pertaining to XDG Base Directory Specification. // // The XDG Base Directory Specification https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html // specifies the environment variables that define user-specific base directories for various categories of files. package xdg const ( // CacheHomeEnvVar is the environment variable used by the // XDG base directory specification for the cache directory. CacheHomeEnvVar = "XDG_CACHE_HOME" // ConfigHomeEnvVar is the environment variable used by the // XDG base directory specification for the config directory. ConfigHomeEnvVar = "XDG_CONFIG_HOME" // DataHomeEnvVar is the environment variable used by the // XDG base directory specification for the data directory. DataHomeEnvVar = "XDG_DATA_HOME" )
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/cmd/helm/helm_test.go
cmd/helm/helm_test.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package main import ( "bytes" "os" "os/exec" "runtime" "testing" "github.com/stretchr/testify/assert" ) func TestCliPluginExitCode(t *testing.T) { if os.Getenv("RUN_MAIN_FOR_TESTING") == "1" { os.Args = []string{"helm", "exitwith", "43"} // We DO call helm's main() here. So this looks like a normal `helm` process. main() // As main calls os.Exit, we never reach this line. // But the test called this block of code catches and verifies the exit code. return } // Currently, plugins assume a Linux subsystem. Skip the execution // tests until this is fixed if runtime.GOOS != "windows" { // Do a second run of this specific test(TestPluginExitCode) with RUN_MAIN_FOR_TESTING=1 set, // So that the second run is able to run main() and this first run can verify the exit status returned by that. // // This technique originates from https://talks.golang.org/2014/testing.slide#23. cmd := exec.Command(os.Args[0], "-test.run=TestCliPluginExitCode") cmd.Env = append( os.Environ(), "RUN_MAIN_FOR_TESTING=1", // See pkg/cli/environment.go for which envvars can be used for configuring these passes // and also see plugin_test.go for how a plugin env can be set up. // This mimics the "exitwith" test case in TestLoadPlugins using envvars "HELM_PLUGINS=../../pkg/cmd/testdata/helmhome/helm/plugins", ) stdout := &bytes.Buffer{} stderr := &bytes.Buffer{} cmd.Stdout = stdout cmd.Stderr = stderr err := cmd.Run() exiterr, ok := err.(*exec.ExitError) if !ok { t.Fatalf("Unexpected error type returned by os.Exit: %T", err) } assert.Empty(t, stdout.String()) expectedStderr := "Error: plugin \"exitwith\" exited with error\n" if stderr.String() != expectedStderr { t.Errorf("Expected %q written to stderr: Got %q", expectedStderr, stderr.String()) } if exiterr.ExitCode() != 43 { t.Errorf("Expected exit code 43: Got %d", exiterr.ExitCode()) } } }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/cmd/helm/helm.go
cmd/helm/helm.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package main // import "helm.sh/helm/v4/cmd/helm" import ( "log/slog" "os" // Import to initialize client auth plugins. _ "k8s.io/client-go/plugin/pkg/client/auth" helmcmd "helm.sh/helm/v4/pkg/cmd" "helm.sh/helm/v4/pkg/kube" ) func main() { // Setting the name of the app for managedFields in the Kubernetes client. // It is set here to the full name of "helm" so that renaming of helm to // another name (e.g., helm2 or helm3) does not change the name of the // manager as picked up by the automated name detection. kube.ManagedFieldsManager = "helm" cmd, err := helmcmd.NewRootCmd(os.Stdout, os.Args[1:], helmcmd.SetupLogging) if err != nil { slog.Warn("command failed", slog.Any("error", err)) os.Exit(1) } if err := cmd.Execute(); err != nil { if cerr, ok := err.(helmcmd.CommandError); ok { os.Exit(cerr.ExitCode) } os.Exit(1) } }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/third_party/k8s.io/kubernetes/deployment/util/deploymentutil.go
internal/third_party/k8s.io/kubernetes/deployment/util/deploymentutil.go
/* Copyright 2016 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package util import ( "context" "sort" apps "k8s.io/api/apps/v1" v1 "k8s.io/api/core/v1" apiequality "k8s.io/apimachinery/pkg/api/equality" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" intstrutil "k8s.io/apimachinery/pkg/util/intstr" appsclient "k8s.io/client-go/kubernetes/typed/apps/v1" ) // deploymentutil contains a copy of a few functions from Kubernetes controller code to avoid a dependency on k8s.io/kubernetes. // This code is copied from https://github.com/kubernetes/kubernetes/blob/e856613dd5bb00bcfaca6974431151b5c06cbed5/pkg/controller/deployment/util/deployment_util.go // No changes to the code were made other than removing some unused functions // RsListFunc returns the ReplicaSet from the ReplicaSet namespace and the List metav1.ListOptions. type RsListFunc func(string, metav1.ListOptions) ([]*apps.ReplicaSet, error) // ListReplicaSets returns a slice of RSes the given deployment targets. // Note that this does NOT attempt to reconcile ControllerRef (adopt/orphan), // because only the controller itself should do that. // However, it does filter out anything whose ControllerRef doesn't match. func ListReplicaSets(deployment *apps.Deployment, getRSList RsListFunc) ([]*apps.ReplicaSet, error) { // TODO: Right now we list replica sets by their labels. We should list them by selector, i.e. the replica set's selector // should be a superset of the deployment's selector, see https://github.com/kubernetes/kubernetes/issues/19830. namespace := deployment.Namespace selector, err := metav1.LabelSelectorAsSelector(deployment.Spec.Selector) if err != nil { return nil, err } options := metav1.ListOptions{LabelSelector: selector.String()} all, err := getRSList(namespace, options) if err != nil { return nil, err } // Only include those whose ControllerRef matches the Deployment. owned := make([]*apps.ReplicaSet, 0, len(all)) for _, rs := range all { if metav1.IsControlledBy(rs, deployment) { owned = append(owned, rs) } } return owned, nil } // ReplicaSetsByCreationTimestamp sorts a list of ReplicaSet by creation timestamp, using their names as a tie breaker. type ReplicaSetsByCreationTimestamp []*apps.ReplicaSet func (o ReplicaSetsByCreationTimestamp) Len() int { return len(o) } func (o ReplicaSetsByCreationTimestamp) Swap(i, j int) { o[i], o[j] = o[j], o[i] } func (o ReplicaSetsByCreationTimestamp) Less(i, j int) bool { if o[i].CreationTimestamp.Equal(&o[j].CreationTimestamp) { return o[i].Name < o[j].Name } return o[i].CreationTimestamp.Before(&o[j].CreationTimestamp) } // FindNewReplicaSet returns the new RS this given deployment targets (the one with the same pod template). func FindNewReplicaSet(deployment *apps.Deployment, rsList []*apps.ReplicaSet) *apps.ReplicaSet { sort.Sort(ReplicaSetsByCreationTimestamp(rsList)) for i := range rsList { if EqualIgnoreHash(&rsList[i].Spec.Template, &deployment.Spec.Template) { // In rare cases, such as after cluster upgrades, Deployment may end up with // having more than one new ReplicaSets that have the same template as its template, // see https://github.com/kubernetes/kubernetes/issues/40415 // We deterministically choose the oldest new ReplicaSet. return rsList[i] } } // new ReplicaSet does not exist. return nil } // EqualIgnoreHash returns true if two given podTemplateSpec are equal, ignoring the diff in value of Labels[pod-template-hash] // We ignore pod-template-hash because: // 1. The hash result would be different upon podTemplateSpec API changes // (e.g. the addition of a new field will cause the hash code to change) // 2. The deployment template won't have hash labels func EqualIgnoreHash(template1, template2 *v1.PodTemplateSpec) bool { t1Copy := template1.DeepCopy() t2Copy := template2.DeepCopy() // Remove hash labels from template.Labels before comparing delete(t1Copy.Labels, apps.DefaultDeploymentUniqueLabelKey) delete(t2Copy.Labels, apps.DefaultDeploymentUniqueLabelKey) return apiequality.Semantic.DeepEqual(t1Copy, t2Copy) } // GetNewReplicaSet returns a replica set that matches the intent of the given deployment; get ReplicaSetList from client interface. // Returns nil if the new replica set doesn't exist yet. func GetNewReplicaSet(deployment *apps.Deployment, c appsclient.AppsV1Interface) (*apps.ReplicaSet, error) { rsList, err := ListReplicaSets(deployment, RsListFromClient(c)) if err != nil { return nil, err } return FindNewReplicaSet(deployment, rsList), nil } // RsListFromClient returns an rsListFunc that wraps the given client. func RsListFromClient(c appsclient.AppsV1Interface) RsListFunc { return func(namespace string, options metav1.ListOptions) ([]*apps.ReplicaSet, error) { rsList, err := c.ReplicaSets(namespace).List(context.Background(), options) if err != nil { return nil, err } var ret []*apps.ReplicaSet for i := range rsList.Items { ret = append(ret, &rsList.Items[i]) } return ret, err } } // IsRollingUpdate returns true if the strategy type is a rolling update. func IsRollingUpdate(deployment *apps.Deployment) bool { return deployment.Spec.Strategy.Type == apps.RollingUpdateDeploymentStrategyType } // MaxUnavailable returns the maximum unavailable pods a rolling deployment can take. func MaxUnavailable(deployment apps.Deployment) int32 { if !IsRollingUpdate(&deployment) || *(deployment.Spec.Replicas) == 0 { return int32(0) } // Error caught by validation _, maxUnavailable, _ := ResolveFenceposts(deployment.Spec.Strategy.RollingUpdate.MaxSurge, deployment.Spec.Strategy.RollingUpdate.MaxUnavailable, *(deployment.Spec.Replicas)) if maxUnavailable > *deployment.Spec.Replicas { return *deployment.Spec.Replicas } return maxUnavailable } // ResolveFenceposts resolves both maxSurge and maxUnavailable. This needs to happen in one // step. For example: // // 2 desired, max unavailable 1%, surge 0% - should scale old(-1), then new(+1), then old(-1), then new(+1) // 1 desired, max unavailable 1%, surge 0% - should scale old(-1), then new(+1) // 2 desired, max unavailable 25%, surge 1% - should scale new(+1), then old(-1), then new(+1), then old(-1) // 1 desired, max unavailable 25%, surge 1% - should scale new(+1), then old(-1) // 2 desired, max unavailable 0%, surge 1% - should scale new(+1), then old(-1), then new(+1), then old(-1) // 1 desired, max unavailable 0%, surge 1% - should scale new(+1), then old(-1) func ResolveFenceposts(maxSurge, maxUnavailable *intstrutil.IntOrString, desired int32) (int32, int32, error) { surge, err := intstrutil.GetValueFromIntOrPercent(intstrutil.ValueOrDefault(maxSurge, intstrutil.FromInt(0)), int(desired), true) if err != nil { return 0, 0, err } unavailable, err := intstrutil.GetValueFromIntOrPercent(intstrutil.ValueOrDefault(maxUnavailable, intstrutil.FromInt(0)), int(desired), false) if err != nil { return 0, 0, err } if surge == 0 && unavailable == 0 { // Validation should never allow the user to explicitly use zero values for both maxSurge // maxUnavailable. Due to rounding down maxUnavailable though, it may resolve to zero. // If both fenceposts resolve to zero, then we should set maxUnavailable to 1 on the // theory that surge might not work due to quota. unavailable = 1 } return int32(surge), int32(unavailable), nil }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/third_party/dep/fs/rename_windows.go
internal/third_party/dep/fs/rename_windows.go
//go:build windows /* Copyright (c) for portions of rename_windows.go are held by The Go Authors, 2016 and are provided under the BSD license. Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met: * Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer. * Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution. * Neither the name of Google Inc. nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission. THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ package fs import ( "fmt" "os" "syscall" ) // renameFallback attempts to determine the appropriate fallback to failed rename // operation depending on the resulting error. func renameFallback(err error, src, dst string) error { // Rename may fail if src and dst are on different devices; fall back to // copy if we detect that case. syscall.EXDEV is the common name for the // cross device link error which has varying output text across different // operating systems. terr, ok := err.(*os.LinkError) if !ok { return err } if terr.Err != syscall.EXDEV { // In windows it can drop down to an operating system call that // returns an operating system error with a different number and // message. Checking for that as a fall back. noerr, ok := terr.Err.(syscall.Errno) // 0x11 (ERROR_NOT_SAME_DEVICE) is the windows error. // See https://msdn.microsoft.com/en-us/library/cc231199.aspx if ok && noerr != 0x11 { return fmt.Errorf("link error: cannot rename %s to %s: %w", src, dst, terr) } } return renameByCopy(src, dst) }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/third_party/dep/fs/fs_test.go
internal/third_party/dep/fs/fs_test.go
/* Copyright (c) for portions of fs_test.go are held by The Go Authors, 2016 and are provided under the BSD license. Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met: * Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer. * Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution. * Neither the name of Google Inc. nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission. THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ package fs import ( "os" "path/filepath" "runtime" "testing" ) func TestRenameWithFallback(t *testing.T) { dir := t.TempDir() if err := RenameWithFallback(filepath.Join(dir, "does_not_exists"), filepath.Join(dir, "dst")); err == nil { t.Fatal("expected an error for non existing file, but got nil") } srcpath := filepath.Join(dir, "src") if srcf, err := os.Create(srcpath); err != nil { t.Fatal(err) } else { srcf.Close() } if err := RenameWithFallback(srcpath, filepath.Join(dir, "dst")); err != nil { t.Fatal(err) } srcpath = filepath.Join(dir, "a") if err := os.MkdirAll(srcpath, 0777); err != nil { t.Fatal(err) } dstpath := filepath.Join(dir, "b") if err := os.MkdirAll(dstpath, 0777); err != nil { t.Fatal(err) } if err := RenameWithFallback(srcpath, dstpath); err == nil { t.Fatal("expected an error if dst is an existing directory, but got nil") } } func TestCopyDir(t *testing.T) { dir := t.TempDir() srcdir := filepath.Join(dir, "src") if err := os.MkdirAll(srcdir, 0755); err != nil { t.Fatal(err) } files := []struct { path string contents string fi os.FileInfo }{ {path: "myfile", contents: "hello world"}, {path: filepath.Join("subdir", "file"), contents: "subdir file"}, } // Create structure indicated in 'files' for i, file := range files { fn := filepath.Join(srcdir, file.path) dn := filepath.Dir(fn) if err := os.MkdirAll(dn, 0755); err != nil { t.Fatal(err) } fh, err := os.Create(fn) if err != nil { t.Fatal(err) } if _, err = fh.Write([]byte(file.contents)); err != nil { t.Fatal(err) } fh.Close() files[i].fi, err = os.Stat(fn) if err != nil { t.Fatal(err) } } destdir := filepath.Join(dir, "dest") if err := CopyDir(srcdir, destdir); err != nil { t.Fatal(err) } // Compare copy against structure indicated in 'files' for _, file := range files { fn := filepath.Join(srcdir, file.path) dn := filepath.Dir(fn) dirOK, err := IsDir(dn) if err != nil { t.Fatal(err) } if !dirOK { t.Fatalf("expected %s to be a directory", dn) } got, err := os.ReadFile(fn) if err != nil { t.Fatal(err) } if file.contents != string(got) { t.Fatalf("expected: %s, got: %s", file.contents, string(got)) } gotinfo, err := os.Stat(fn) if err != nil { t.Fatal(err) } if file.fi.Mode() != gotinfo.Mode() { t.Fatalf("expected %s: %#v\n to be the same mode as %s: %#v", file.path, file.fi.Mode(), fn, gotinfo.Mode()) } } } func TestCopyDirFail_SrcInaccessible(t *testing.T) { if runtime.GOOS == "windows" { // XXX: setting permissions works differently in // Microsoft Windows. Skipping this until a // compatible implementation is provided. t.Skip("skipping on windows") } var currentUID = os.Getuid() if currentUID == 0 { // Skipping if root, because all files are accessible t.Skip("Skipping for root user") } var srcdir, dstdir string cleanup := setupInaccessibleDir(t, func(dir string) error { srcdir = filepath.Join(dir, "src") return os.MkdirAll(srcdir, 0755) }) defer cleanup() dir := t.TempDir() dstdir = filepath.Join(dir, "dst") if err := CopyDir(srcdir, dstdir); err == nil { t.Fatalf("expected error for CopyDir(%s, %s), got none", srcdir, dstdir) } } func TestCopyDirFail_DstInaccessible(t *testing.T) { if runtime.GOOS == "windows" { // XXX: setting permissions works differently in // Microsoft Windows. Skipping this until a // compatible implementation is provided. t.Skip("skipping on windows") } var currentUID = os.Getuid() if currentUID == 0 { // Skipping if root, because all files are accessible t.Skip("Skipping for root user") } var srcdir, dstdir string dir := t.TempDir() srcdir = filepath.Join(dir, "src") if err := os.MkdirAll(srcdir, 0755); err != nil { t.Fatal(err) } cleanup := setupInaccessibleDir(t, func(dir string) error { dstdir = filepath.Join(dir, "dst") return nil }) defer cleanup() if err := CopyDir(srcdir, dstdir); err == nil { t.Fatalf("expected error for CopyDir(%s, %s), got none", srcdir, dstdir) } } func TestCopyDirFail_SrcIsNotDir(t *testing.T) { var srcdir, dstdir string var err error dir := t.TempDir() srcdir = filepath.Join(dir, "src") if _, err = os.Create(srcdir); err != nil { t.Fatal(err) } dstdir = filepath.Join(dir, "dst") if err = CopyDir(srcdir, dstdir); err == nil { t.Fatalf("expected error for CopyDir(%s, %s), got none", srcdir, dstdir) } if err != errSrcNotDir { t.Fatalf("expected %v error for CopyDir(%s, %s), got %s", errSrcNotDir, srcdir, dstdir, err) } } func TestCopyDirFail_DstExists(t *testing.T) { var srcdir, dstdir string var err error dir := t.TempDir() srcdir = filepath.Join(dir, "src") if err = os.MkdirAll(srcdir, 0755); err != nil { t.Fatal(err) } dstdir = filepath.Join(dir, "dst") if err = os.MkdirAll(dstdir, 0755); err != nil { t.Fatal(err) } if err = CopyDir(srcdir, dstdir); err == nil { t.Fatalf("expected error for CopyDir(%s, %s), got none", srcdir, dstdir) } if err != errDstExist { t.Fatalf("expected %v error for CopyDir(%s, %s), got %s", errDstExist, srcdir, dstdir, err) } } func TestCopyDirFailOpen(t *testing.T) { if runtime.GOOS == "windows" { // XXX: setting permissions works differently in // Microsoft Windows. os.Chmod(..., 0222) below is not // enough for the file to be readonly, and os.Chmod(..., // 0000) returns an invalid argument error. Skipping // this until a compatible implementation is // provided. t.Skip("skipping on windows") } var currentUID = os.Getuid() if currentUID == 0 { // Skipping if root, because all files are accessible t.Skip("Skipping for root user") } var srcdir, dstdir string dir := t.TempDir() srcdir = filepath.Join(dir, "src") if err := os.MkdirAll(srcdir, 0755); err != nil { t.Fatal(err) } srcfn := filepath.Join(srcdir, "file") srcf, err := os.Create(srcfn) if err != nil { t.Fatal(err) } srcf.Close() // setup source file so that it cannot be read if err = os.Chmod(srcfn, 0222); err != nil { t.Fatal(err) } dstdir = filepath.Join(dir, "dst") if err = CopyDir(srcdir, dstdir); err == nil { t.Fatalf("expected error for CopyDir(%s, %s), got none", srcdir, dstdir) } } func TestCopyFile(t *testing.T) { dir := t.TempDir() srcf, err := os.Create(filepath.Join(dir, "srcfile")) if err != nil { t.Fatal(err) } want := "hello world" if _, err := srcf.Write([]byte(want)); err != nil { t.Fatal(err) } srcf.Close() destf := filepath.Join(dir, "destf") if err := CopyFile(srcf.Name(), destf); err != nil { t.Fatal(err) } got, err := os.ReadFile(destf) if err != nil { t.Fatal(err) } if want != string(got) { t.Fatalf("expected: %s, got: %s", want, string(got)) } wantinfo, err := os.Stat(srcf.Name()) if err != nil { t.Fatal(err) } gotinfo, err := os.Stat(destf) if err != nil { t.Fatal(err) } if wantinfo.Mode() != gotinfo.Mode() { t.Fatalf("expected %s: %#v\n to be the same mode as %s: %#v", srcf.Name(), wantinfo.Mode(), destf, gotinfo.Mode()) } } func TestCopyFileSymlink(t *testing.T) { tempdir := t.TempDir() testcases := map[string]string{ filepath.Join("./testdata/symlinks/file-symlink"): filepath.Join(tempdir, "dst-file"), filepath.Join("./testdata/symlinks/windows-file-symlink"): filepath.Join(tempdir, "windows-dst-file"), filepath.Join("./testdata/symlinks/invalid-symlink"): filepath.Join(tempdir, "invalid-symlink"), } for symlink, dst := range testcases { t.Run(symlink, func(t *testing.T) { var err error if err = CopyFile(symlink, dst); err != nil { t.Fatalf("failed to copy symlink: %s", err) } var want, got string if runtime.GOOS == "windows" { // Creating symlinks on Windows require an additional permission // regular users aren't granted usually. So we copy the file // content as a fall back instead of creating a real symlink. srcb, err := os.ReadFile(symlink) if err != nil { t.Fatalf("%+v", err) } dstb, err := os.ReadFile(dst) if err != nil { t.Fatalf("%+v", err) } want = string(srcb) got = string(dstb) } else { want, err = os.Readlink(symlink) if err != nil { t.Fatalf("%+v", err) } got, err = os.Readlink(dst) if err != nil { t.Fatalf("could not resolve symlink: %s", err) } } if want != got { t.Fatalf("resolved path is incorrect. expected %s, got %s", want, got) } }) } } func TestCopyFileFail(t *testing.T) { if runtime.GOOS == "windows" { // XXX: setting permissions works differently in // Microsoft Windows. Skipping this until a // compatible implementation is provided. t.Skip("skipping on windows") } var currentUID = os.Getuid() if currentUID == 0 { // Skipping if root, because all files are accessible t.Skip("Skipping for root user") } dir := t.TempDir() srcf, err := os.Create(filepath.Join(dir, "srcfile")) if err != nil { t.Fatal(err) } srcf.Close() var dstdir string cleanup := setupInaccessibleDir(t, func(dir string) error { dstdir = filepath.Join(dir, "dir") return os.Mkdir(dstdir, 0777) }) defer cleanup() fn := filepath.Join(dstdir, "file") if err := CopyFile(srcf.Name(), fn); err == nil { t.Fatalf("expected error for %s, got none", fn) } } // setupInaccessibleDir creates a temporary location with a single // directory in it, in such a way that directory is not accessible // after this function returns. // // op is called with the directory as argument, so that it can create // files or other test artifacts. // // If setupInaccessibleDir fails in its preparation, or op fails, t.Fatal // will be invoked. // // This function returns a cleanup function that removes all the temporary // files this function creates. It is the caller's responsibility to call // this function before the test is done running, whether there's an error or not. func setupInaccessibleDir(t *testing.T, op func(dir string) error) func() { t.Helper() dir := t.TempDir() subdir := filepath.Join(dir, "dir") cleanup := func() { if err := os.Chmod(subdir, 0777); err != nil { t.Error(err) } } if err := os.Mkdir(subdir, 0777); err != nil { cleanup() t.Fatal(err) return nil } if err := op(subdir); err != nil { cleanup() t.Fatal(err) return nil } if err := os.Chmod(subdir, 0666); err != nil { cleanup() t.Fatal(err) return nil } return cleanup } func TestIsDir(t *testing.T) { var currentUID = os.Getuid() if currentUID == 0 { // Skipping if root, because all files are accessible t.Skip("Skipping for root user") } wd, err := os.Getwd() if err != nil { t.Fatal(err) } var dn string cleanup := setupInaccessibleDir(t, func(dir string) error { dn = filepath.Join(dir, "dir") return os.Mkdir(dn, 0777) }) defer cleanup() tests := map[string]struct { exists bool err bool }{ wd: {true, false}, filepath.Join(wd, "testdata"): {true, false}, filepath.Join(wd, "main.go"): {false, true}, filepath.Join(wd, "this_file_does_not_exist.thing"): {false, true}, dn: {false, true}, } if runtime.GOOS == "windows" { // This test doesn't work on Microsoft Windows because // of the differences in how file permissions are // implemented. For this to work, the directory where // the directory exists should be inaccessible. delete(tests, dn) } for f, want := range tests { got, err := IsDir(f) if err != nil && !want.err { t.Fatalf("expected no error, got %v", err) } if got != want.exists { t.Fatalf("expected %t for %s, got %t", want.exists, f, got) } } } func TestIsSymlink(t *testing.T) { var currentUID = os.Getuid() if currentUID == 0 { // Skipping if root, because all files are accessible t.Skip("Skipping for root user") } dir := t.TempDir() dirPath := filepath.Join(dir, "directory") if err := os.MkdirAll(dirPath, 0777); err != nil { t.Fatal(err) } filePath := filepath.Join(dir, "file") f, err := os.Create(filePath) if err != nil { t.Fatal(err) } f.Close() dirSymlink := filepath.Join(dir, "dirSymlink") fileSymlink := filepath.Join(dir, "fileSymlink") if err = os.Symlink(dirPath, dirSymlink); err != nil { t.Fatal(err) } if err = os.Symlink(filePath, fileSymlink); err != nil { t.Fatal(err) } var ( inaccessibleFile string inaccessibleSymlink string ) cleanup := setupInaccessibleDir(t, func(dir string) error { inaccessibleFile = filepath.Join(dir, "file") if fh, err := os.Create(inaccessibleFile); err != nil { return err } else if err = fh.Close(); err != nil { return err } inaccessibleSymlink = filepath.Join(dir, "symlink") return os.Symlink(inaccessibleFile, inaccessibleSymlink) }) defer cleanup() tests := map[string]struct{ expected, err bool }{ dirPath: {false, false}, filePath: {false, false}, dirSymlink: {true, false}, fileSymlink: {true, false}, inaccessibleFile: {false, true}, inaccessibleSymlink: {false, true}, } if runtime.GOOS == "windows" { // XXX: setting permissions works differently in Windows. Skipping // these cases until a compatible implementation is provided. delete(tests, inaccessibleFile) delete(tests, inaccessibleSymlink) } for path, want := range tests { got, err := IsSymlink(path) if err != nil { if !want.err { t.Errorf("expected no error, got %v", err) } } if got != want.expected { t.Errorf("expected %t for %s, got %t", want.expected, path, got) } } }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/third_party/dep/fs/rename.go
internal/third_party/dep/fs/rename.go
//go:build !windows /* Copyright (c) for portions of rename.go are held by The Go Authors, 2016 and are provided under the BSD license. Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met: * Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer. * Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution. * Neither the name of Google Inc. nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission. THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ package fs import ( "fmt" "os" "syscall" ) // renameFallback attempts to determine the appropriate fallback to failed rename // operation depending on the resulting error. func renameFallback(err error, src, dst string) error { // Rename may fail if src and dst are on different devices; fall back to // copy if we detect that case. syscall.EXDEV is the common name for the // cross device link error which has varying output text across different // operating systems. terr, ok := err.(*os.LinkError) if !ok { return err } else if terr.Err != syscall.EXDEV { return fmt.Errorf("link error: cannot rename %s to %s: %w", src, dst, terr) } return renameByCopy(src, dst) }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/third_party/dep/fs/fs.go
internal/third_party/dep/fs/fs.go
/* Copyright (c) for portions of fs.go are held by The Go Authors, 2016 and are provided under the BSD license. Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met: * Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer. * Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution. * Neither the name of Google Inc. nor the names of its contributors may be used to endorse or promote products derived from this software without specific prior written permission. THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ package fs import ( "errors" "fmt" "io" "io/fs" "os" "path/filepath" "runtime" "syscall" ) // fs contains a copy of a few functions from dep tool code to avoid a dependency on golang/dep. // This code is copied from https://github.com/golang/dep/blob/37d6c560cdf407be7b6cd035b23dba89df9275cf/internal/fs/fs.go // No changes to the code were made other than removing some unused functions // RenameWithFallback attempts to rename a file or directory, but falls back to // copying in the event of a cross-device link error. If the fallback copy // succeeds, src is still removed, emulating normal rename behavior. func RenameWithFallback(src, dst string) error { _, err := os.Stat(src) if err != nil { return fmt.Errorf("cannot stat %s: %w", src, err) } err = os.Rename(src, dst) if err == nil { return nil } return renameFallback(err, src, dst) } // renameByCopy attempts to rename a file or directory by copying it to the // destination and then removing the src thus emulating the rename behavior. func renameByCopy(src, dst string) error { var cerr error if dir, _ := IsDir(src); dir { cerr = CopyDir(src, dst) if cerr != nil { cerr = fmt.Errorf("copying directory failed: %w", cerr) } } else { cerr = CopyFile(src, dst) if cerr != nil { cerr = fmt.Errorf("copying file failed: %w", cerr) } } if cerr != nil { return fmt.Errorf("rename fallback failed: cannot rename %s to %s: %w", src, dst, cerr) } if err := os.RemoveAll(src); err != nil { return fmt.Errorf("cannot delete %s: %w", src, err) } return nil } var ( errSrcNotDir = errors.New("source is not a directory") errDstExist = errors.New("destination already exists") ) // CopyDir recursively copies a directory tree, attempting to preserve permissions. // Source directory must exist, destination directory must *not* exist. func CopyDir(src, dst string) error { src = filepath.Clean(src) dst = filepath.Clean(dst) // We use os.Lstat() here to ensure we don't fall in a loop where a symlink // actually links to a one of its parent directories. fi, err := os.Lstat(src) if err != nil { return err } if !fi.IsDir() { return errSrcNotDir } _, err = os.Stat(dst) if err != nil && !errors.Is(err, fs.ErrNotExist) { return err } if err == nil { return errDstExist } if err = os.MkdirAll(dst, fi.Mode()); err != nil { return fmt.Errorf("cannot mkdir %s: %w", dst, err) } entries, err := os.ReadDir(src) if err != nil { return fmt.Errorf("cannot read directory %s: %w", dst, err) } for _, entry := range entries { srcPath := filepath.Join(src, entry.Name()) dstPath := filepath.Join(dst, entry.Name()) if entry.IsDir() { if err = CopyDir(srcPath, dstPath); err != nil { return fmt.Errorf("copying directory failed: %w", err) } } else { // This will include symlinks, which is what we want when // copying things. if err = CopyFile(srcPath, dstPath); err != nil { return fmt.Errorf("copying file failed: %w", err) } } } return nil } // CopyFile copies the contents of the file named src to the file named // by dst. The file will be created if it does not already exist. If the // destination file exists, all its contents will be replaced by the contents // of the source file. The file mode will be copied from the source. func CopyFile(src, dst string) (err error) { if sym, err := IsSymlink(src); err != nil { return fmt.Errorf("symlink check failed: %w", err) } else if sym { if err := cloneSymlink(src, dst); err != nil { if runtime.GOOS == "windows" { // If cloning the symlink fails on Windows because the user // does not have the required privileges, ignore the error and // fall back to copying the file contents. // // ERROR_PRIVILEGE_NOT_HELD is 1314 (0x522): // https://msdn.microsoft.com/en-us/library/windows/desktop/ms681385(v=vs.85).aspx if lerr, ok := err.(*os.LinkError); ok && lerr.Err != syscall.Errno(1314) { return err } } else { return err } } else { return nil } } in, err := os.Open(src) if err != nil { return err } defer in.Close() out, err := os.Create(dst) if err != nil { return err } if _, err = io.Copy(out, in); err != nil { out.Close() return err } // Check for write errors on Close if err = out.Close(); err != nil { return err } si, err := os.Stat(src) if err != nil { return err } // Temporary fix for Go < 1.9 // // See: https://github.com/golang/dep/issues/774 // and https://github.com/golang/go/issues/20829 if runtime.GOOS == "windows" { dst = fixLongPath(dst) } err = os.Chmod(dst, si.Mode()) return err } // cloneSymlink will create a new symlink that points to the resolved path of sl. // If sl is a relative symlink, dst will also be a relative symlink. func cloneSymlink(sl, dst string) error { resolved, err := os.Readlink(sl) if err != nil { return err } return os.Symlink(resolved, dst) } // IsDir determines is the path given is a directory or not. func IsDir(name string) (bool, error) { fi, err := os.Stat(name) if err != nil { return false, err } if !fi.IsDir() { return false, fmt.Errorf("%q is not a directory", name) } return true, nil } // IsSymlink determines if the given path is a symbolic link. func IsSymlink(path string) (bool, error) { l, err := os.Lstat(path) if err != nil { return false, err } return l.Mode()&os.ModeSymlink == os.ModeSymlink, nil } // fixLongPath returns the extended-length (\\?\-prefixed) form of // path when needed, in order to avoid the default 260 character file // path limit imposed by Windows. If path is not easily converted to // the extended-length form (for example, if path is a relative path // or contains .. elements), or is short enough, fixLongPath returns // path unmodified. // // See https://msdn.microsoft.com/en-us/library/windows/desktop/aa365247(v=vs.85).aspx#maxpath func fixLongPath(path string) string { // Do nothing (and don't allocate) if the path is "short". // Empirically (at least on the Windows Server 2013 builder), // the kernel is arbitrarily okay with < 248 bytes. That // matches what the docs above say: // "When using an API to create a directory, the specified // path cannot be so long that you cannot append an 8.3 file // name (that is, the directory name cannot exceed MAX_PATH // minus 12)." Since MAX_PATH is 260, 260 - 12 = 248. // // The MSDN docs appear to say that a normal path that is 248 bytes long // will work; empirically the path must be less than 248 bytes long. if len(path) < 248 { // Don't fix. (This is how Go 1.7 and earlier worked, // not automatically generating the \\?\ form) return path } // The extended form begins with \\?\, as in // \\?\c:\windows\foo.txt or \\?\UNC\server\share\foo.txt. // The extended form disables evaluation of . and .. path // elements and disables the interpretation of / as equivalent // to \. The conversion here rewrites / to \ and elides // . elements as well as trailing or duplicate separators. For // simplicity it avoids the conversion entirely for relative // paths or paths containing .. elements. For now, // \\server\share paths are not converted to // \\?\UNC\server\share paths because the rules for doing so // are less well-specified. if len(path) >= 2 && path[:2] == `\\` { // Don't canonicalize UNC paths. return path } if !isAbs(path) { // Relative path return path } const prefix = `\\?` pathbuf := make([]byte, len(prefix)+len(path)+len(`\`)) copy(pathbuf, prefix) n := len(path) r, w := 0, len(prefix) for r < n { switch { case os.IsPathSeparator(path[r]): // empty block r++ case path[r] == '.' && (r+1 == n || os.IsPathSeparator(path[r+1])): // /./ r++ case r+1 < n && path[r] == '.' && path[r+1] == '.' && (r+2 == n || os.IsPathSeparator(path[r+2])): // /../ is currently unhandled return path default: pathbuf[w] = '\\' w++ for ; r < n && !os.IsPathSeparator(path[r]); r++ { pathbuf[w] = path[r] w++ } } } // A drive's root directory needs a trailing \ if w == len(`\\?\c:`) { pathbuf[w] = '\\' w++ } return string(pathbuf[:w]) } func isAbs(path string) (b bool) { v := volumeName(path) if v == "" { return false } path = path[len(v):] if path == "" { return false } return os.IsPathSeparator(path[0]) } func volumeName(path string) (v string) { if len(path) < 2 { return "" } // with drive letter c := path[0] if path[1] == ':' && ('0' <= c && c <= '9' || 'a' <= c && c <= 'z' || 'A' <= c && c <= 'Z') { return path[:2] } // is it UNC if l := len(path); l >= 5 && os.IsPathSeparator(path[0]) && os.IsPathSeparator(path[1]) && !os.IsPathSeparator(path[2]) && path[2] != '.' { // first, leading `\\` and next shouldn't be `\`. its server name. for n := 3; n < l-1; n++ { // second, next '\' shouldn't be repeated. if os.IsPathSeparator(path[n]) { n++ // third, following something characters. its share name. if !os.IsPathSeparator(path[n]) { if path[n] == '.' { break } for ; n < l; n++ { if os.IsPathSeparator(path[n]) { break } } return path[:n] } break } } } return "" }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/sympath/walk.go
internal/sympath/walk.go
/* Copyright (c) for portions of walk.go are held by The Go Authors, 2009 and are provided under the BSD license. https://github.com/golang/go/blob/master/LICENSE Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package sympath import ( "fmt" "log/slog" "os" "path/filepath" "sort" ) // Walk walks the file tree rooted at root, calling walkFn for each file or directory // in the tree, including root. All errors that arise visiting files and directories // are filtered by walkFn. The files are walked in lexical order, which makes the // output deterministic but means that for very large directories Walk can be // inefficient. Walk follows symbolic links. func Walk(root string, walkFn filepath.WalkFunc) error { info, err := os.Lstat(root) if err != nil { err = walkFn(root, nil, err) } else { err = symwalk(root, info, walkFn) } if err == filepath.SkipDir { return nil } return err } // readDirNames reads the directory named by dirname and returns // a sorted list of directory entries. func readDirNames(dirname string) ([]string, error) { f, err := os.Open(dirname) if err != nil { return nil, err } names, err := f.Readdirnames(-1) f.Close() if err != nil { return nil, err } sort.Strings(names) return names, nil } // symwalk recursively descends path, calling walkFn. func symwalk(path string, info os.FileInfo, walkFn filepath.WalkFunc) error { // Recursively walk symlinked directories. if IsSymlink(info) { resolved, err := filepath.EvalSymlinks(path) if err != nil { return fmt.Errorf("error evaluating symlink %s: %w", path, err) } // This log message is to highlight a symlink that is being used within a chart, symlinks can be used for nefarious reasons. slog.Info("found symbolic link in path. Contents of linked file included and used", "path", path, "resolved", resolved) if info, err = os.Lstat(resolved); err != nil { return err } if err := symwalk(path, info, walkFn); err != nil && err != filepath.SkipDir { return err } return nil } if err := walkFn(path, info, nil); err != nil { return err } if !info.IsDir() { return nil } names, err := readDirNames(path) if err != nil { return walkFn(path, info, err) } for _, name := range names { filename := filepath.Join(path, name) fileInfo, err := os.Lstat(filename) if err != nil { if err := walkFn(filename, fileInfo, err); err != nil && err != filepath.SkipDir { return err } } else { err = symwalk(filename, fileInfo, walkFn) if err != nil { if (!fileInfo.IsDir() && !IsSymlink(fileInfo)) || err != filepath.SkipDir { return err } } } } return nil } // IsSymlink is used to determine if the fileinfo is a symbolic link. func IsSymlink(fi os.FileInfo) bool { return fi.Mode()&os.ModeSymlink != 0 }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/sympath/walk_test.go
internal/sympath/walk_test.go
/* Copyright (c) for portions of walk_test.go are held by The Go Authors, 2009 and are provided under the BSD license. https://github.com/golang/go/blob/master/LICENSE Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package sympath import ( "os" "path/filepath" "testing" ) type Node struct { name string entries []*Node // nil if the entry is a file marks int expectedMarks int symLinkedTo string } var tree = &Node{ "testdata", []*Node{ {"a", nil, 0, 1, ""}, {"b", []*Node{}, 0, 1, ""}, {"c", nil, 0, 2, ""}, {"d", nil, 0, 0, "c"}, { "e", []*Node{ {"x", nil, 0, 1, ""}, {"y", []*Node{}, 0, 1, ""}, { "z", []*Node{ {"u", nil, 0, 1, ""}, {"v", nil, 0, 1, ""}, {"w", nil, 0, 1, ""}, }, 0, 1, "", }, }, 0, 1, "", }, }, 0, 1, "", } func walkTree(n *Node, path string, f func(path string, n *Node)) { f(path, n) for _, e := range n.entries { walkTree(e, filepath.Join(path, e.name), f) } } func makeTree(t *testing.T) { t.Helper() walkTree(tree, tree.name, func(path string, n *Node) { if n.entries == nil { if n.symLinkedTo != "" { if err := os.Symlink(n.symLinkedTo, path); err != nil { t.Fatalf("makeTree: %v", err) } } else { fd, err := os.Create(path) if err != nil { t.Fatalf("makeTree: %v", err) return } fd.Close() } } else { if err := os.Mkdir(path, 0770); err != nil { t.Fatalf("makeTree: %v", err) } } }) } func checkMarks(t *testing.T, report bool) { t.Helper() walkTree(tree, tree.name, func(path string, n *Node) { if n.marks != n.expectedMarks && report { t.Errorf("node %s mark = %d; expected %d", path, n.marks, n.expectedMarks) } n.marks = 0 }) } // Assumes that each node name is unique. Good enough for a test. // If clearIncomingError is true, any incoming error is cleared before // return. The errors are always accumulated, though. func mark(info os.FileInfo, err error, errors *[]error, clearIncomingError bool) error { if err != nil { *errors = append(*errors, err) if clearIncomingError { return nil } return err } name := info.Name() walkTree(tree, tree.name, func(_ string, n *Node) { if n.name == name { n.marks++ } }) return nil } func TestWalk(t *testing.T) { makeTree(t) errors := make([]error, 0, 10) markFn := func(_ string, info os.FileInfo, err error) error { return mark(info, err, &errors, true) } // Expect no errors. err := Walk(tree.name, markFn) if err != nil { t.Fatalf("no error expected, found: %s", err) } if len(errors) != 0 { t.Fatalf("unexpected errors: %s", errors) } checkMarks(t, true) // cleanup if err := os.RemoveAll(tree.name); err != nil { t.Errorf("removeTree: %v", err) } }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/copystructure/copystructure.go
internal/copystructure/copystructure.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package copystructure import ( "fmt" "reflect" ) // Copy performs a deep copy of the given src. // This implementation handles the specific use cases needed by Helm. func Copy(src any) (any, error) { if src == nil { return make(map[string]any), nil } return copyValue(reflect.ValueOf(src)) } // copyValue handles copying using reflection for non-map types func copyValue(original reflect.Value) (any, error) { switch original.Kind() { case reflect.Bool, reflect.Int, reflect.Int8, reflect.Int16, reflect.Int32, reflect.Int64, reflect.Uint, reflect.Uint8, reflect.Uint16, reflect.Uint32, reflect.Uint64, reflect.Uintptr, reflect.Float32, reflect.Float64, reflect.Complex64, reflect.Complex128, reflect.String, reflect.Array: return original.Interface(), nil case reflect.Interface: if original.IsNil() { return original.Interface(), nil } return copyValue(original.Elem()) case reflect.Map: if original.IsNil() { return original.Interface(), nil } copied := reflect.MakeMap(original.Type()) var err error var child any iter := original.MapRange() for iter.Next() { key := iter.Key() value := iter.Value() if value.Kind() == reflect.Interface && value.IsNil() { copied.SetMapIndex(key, value) continue } child, err = copyValue(value) if err != nil { return nil, err } copied.SetMapIndex(key, reflect.ValueOf(child)) } return copied.Interface(), nil case reflect.Pointer: if original.IsNil() { return original.Interface(), nil } copied, err := copyValue(original.Elem()) if err != nil { return nil, err } ptr := reflect.New(original.Type().Elem()) ptr.Elem().Set(reflect.ValueOf(copied)) return ptr.Interface(), nil case reflect.Slice: if original.IsNil() { return original.Interface(), nil } copied := reflect.MakeSlice(original.Type(), original.Len(), original.Cap()) for i := 0; i < original.Len(); i++ { val, err := copyValue(original.Index(i)) if err != nil { return nil, err } copied.Index(i).Set(reflect.ValueOf(val)) } return copied.Interface(), nil case reflect.Struct: copied := reflect.New(original.Type()).Elem() for i := 0; i < original.NumField(); i++ { elem, err := copyValue(original.Field(i)) if err != nil { return nil, err } copied.Field(i).Set(reflect.ValueOf(elem)) } return copied.Interface(), nil case reflect.Func, reflect.Chan, reflect.UnsafePointer: if original.IsNil() { return original.Interface(), nil } return original.Interface(), nil default: return original.Interface(), fmt.Errorf("unsupported type %v", original) } }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/copystructure/copystructure_test.go
internal/copystructure/copystructure_test.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package copystructure import ( "testing" "github.com/stretchr/testify/assert" "github.com/stretchr/testify/require" ) func TestCopy_Nil(t *testing.T) { result, err := Copy(nil) require.NoError(t, err) assert.Equal(t, map[string]any{}, result) } func TestCopy_PrimitiveTypes(t *testing.T) { tests := []struct { name string input any }{ {"bool", true}, {"int", 42}, {"int8", int8(8)}, {"int16", int16(16)}, {"int32", int32(32)}, {"int64", int64(64)}, {"uint", uint(42)}, {"uint8", uint8(8)}, {"uint16", uint16(16)}, {"uint32", uint32(32)}, {"uint64", uint64(64)}, {"float32", float32(3.14)}, {"float64", 3.14159}, {"complex64", complex64(1 + 2i)}, {"complex128", 1 + 2i}, {"string", "hello world"}, } for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { result, err := Copy(tt.input) require.NoError(t, err) assert.Equal(t, tt.input, result) }) } } func TestCopy_Array(t *testing.T) { input := [3]int{1, 2, 3} result, err := Copy(input) require.NoError(t, err) assert.Equal(t, input, result) } func TestCopy_Slice(t *testing.T) { t.Run("slice of ints", func(t *testing.T) { input := []int{1, 2, 3, 4, 5} result, err := Copy(input) require.NoError(t, err) resultSlice, ok := result.([]int) require.True(t, ok) assert.Equal(t, input, resultSlice) // Verify it's a deep copy by modifying original input[0] = 999 assert.Equal(t, 1, resultSlice[0]) }) t.Run("slice of strings", func(t *testing.T) { input := []string{"a", "b", "c"} result, err := Copy(input) require.NoError(t, err) assert.Equal(t, input, result) }) t.Run("nil slice", func(t *testing.T) { var input []int result, err := Copy(input) require.NoError(t, err) assert.Nil(t, result) }) t.Run("slice of maps", func(t *testing.T) { input := []map[string]any{ {"key1": "value1"}, {"key2": "value2"}, } result, err := Copy(input) require.NoError(t, err) resultSlice, ok := result.([]map[string]any) require.True(t, ok) assert.Equal(t, input, resultSlice) // Verify deep copy input[0]["key1"] = "modified" assert.Equal(t, "value1", resultSlice[0]["key1"]) }) } func TestCopy_Map(t *testing.T) { t.Run("map[string]any", func(t *testing.T) { input := map[string]any{ "string": "value", "int": 42, "bool": true, "nested": map[string]any{ "inner": "value", }, } result, err := Copy(input) require.NoError(t, err) resultMap, ok := result.(map[string]any) require.True(t, ok) assert.Equal(t, input, resultMap) // Verify deep copy input["string"] = "modified" assert.Equal(t, "value", resultMap["string"]) nestedInput := input["nested"].(map[string]any) nestedResult := resultMap["nested"].(map[string]any) nestedInput["inner"] = "modified" assert.Equal(t, "value", nestedResult["inner"]) }) t.Run("map[string]string", func(t *testing.T) { input := map[string]string{ "key1": "value1", "key2": "value2", } result, err := Copy(input) require.NoError(t, err) assert.Equal(t, input, result) }) t.Run("nil map", func(t *testing.T) { var input map[string]any result, err := Copy(input) require.NoError(t, err) assert.Nil(t, result) }) t.Run("map with nil values", func(t *testing.T) { input := map[string]any{ "key1": "value1", "key2": nil, } result, err := Copy(input) require.NoError(t, err) resultMap, ok := result.(map[string]any) require.True(t, ok) assert.Equal(t, input, resultMap) assert.Nil(t, resultMap["key2"]) }) } func TestCopy_Struct(t *testing.T) { type TestStruct struct { Name string Age int Active bool Scores []int Metadata map[string]any } input := TestStruct{ Name: "John", Age: 30, Active: true, Scores: []int{95, 87, 92}, Metadata: map[string]any{ "level": "advanced", "tags": []string{"go", "programming"}, }, } result, err := Copy(input) require.NoError(t, err) resultStruct, ok := result.(TestStruct) require.True(t, ok) assert.Equal(t, input, resultStruct) // Verify deep copy input.Name = "Modified" input.Scores[0] = 999 assert.Equal(t, "John", resultStruct.Name) assert.Equal(t, 95, resultStruct.Scores[0]) } func TestCopy_Pointer(t *testing.T) { t.Run("pointer to int", func(t *testing.T) { value := 42 input := &value result, err := Copy(input) require.NoError(t, err) resultPtr, ok := result.(*int) require.True(t, ok) assert.Equal(t, *input, *resultPtr) // Verify they point to different memory locations assert.NotSame(t, input, resultPtr) // Verify deep copy *input = 999 assert.Equal(t, 42, *resultPtr) }) t.Run("pointer to struct", func(t *testing.T) { type Person struct { Name string Age int } input := &Person{Name: "Alice", Age: 25} result, err := Copy(input) require.NoError(t, err) resultPtr, ok := result.(*Person) require.True(t, ok) assert.Equal(t, *input, *resultPtr) assert.NotSame(t, input, resultPtr) }) t.Run("nil pointer", func(t *testing.T) { var input *int result, err := Copy(input) require.NoError(t, err) assert.Nil(t, result) }) } func TestCopy_Interface(t *testing.T) { t.Run("any with value", func(t *testing.T) { var input any = "hello" result, err := Copy(input) require.NoError(t, err) assert.Equal(t, input, result) }) t.Run("nil any", func(t *testing.T) { var input any result, err := Copy(input) require.NoError(t, err) // Copy(nil) returns an empty map according to the implementation assert.Equal(t, map[string]any{}, result) }) t.Run("any with complex value", func(t *testing.T) { var input any = map[string]any{ "key": "value", "nested": map[string]any{ "inner": 42, }, } result, err := Copy(input) require.NoError(t, err) assert.Equal(t, input, result) }) } func TestCopy_ComplexNested(t *testing.T) { input := map[string]any{ "users": []map[string]any{ { "name": "Alice", "age": 30, "addresses": []map[string]any{ {"type": "home", "city": "NYC"}, {"type": "work", "city": "SF"}, }, }, { "name": "Bob", "age": 25, "addresses": []map[string]any{ {"type": "home", "city": "LA"}, }, }, }, "metadata": map[string]any{ "version": "1.0", "flags": []bool{true, false, true}, }, } result, err := Copy(input) require.NoError(t, err) resultMap, ok := result.(map[string]any) require.True(t, ok) assert.Equal(t, input, resultMap) // Verify deep copy by modifying nested values users := input["users"].([]map[string]any) addresses := users[0]["addresses"].([]map[string]any) addresses[0]["city"] = "Modified" resultUsers := resultMap["users"].([]map[string]any) resultAddresses := resultUsers[0]["addresses"].([]map[string]any) assert.Equal(t, "NYC", resultAddresses[0]["city"]) } func TestCopy_Functions(t *testing.T) { t.Run("function", func(t *testing.T) { input := func() string { return "hello" } result, err := Copy(input) require.NoError(t, err) // Functions should be copied as-is (same reference) resultFunc, ok := result.(func() string) require.True(t, ok) assert.Equal(t, input(), resultFunc()) }) t.Run("nil function", func(t *testing.T) { var input func() result, err := Copy(input) require.NoError(t, err) assert.Nil(t, result) }) } func TestCopy_Channels(t *testing.T) { t.Run("channel", func(t *testing.T) { input := make(chan int, 1) input <- 42 result, err := Copy(input) require.NoError(t, err) // Channels should be copied as-is (same reference) resultChan, ok := result.(chan int) require.True(t, ok) // Since channels are copied as references, verify we can read from the result channel value := <-resultChan assert.Equal(t, 42, value) }) t.Run("nil channel", func(t *testing.T) { var input chan int result, err := Copy(input) require.NoError(t, err) assert.Nil(t, result) }) }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/monocular/client.go
internal/monocular/client.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package monocular import ( "errors" "net/url" ) // ErrHostnameNotProvided indicates the url is missing a hostname var ErrHostnameNotProvided = errors.New("no hostname provided") // Client represents a client capable of communicating with the Monocular API. type Client struct { // The base URL for requests BaseURL string } // New creates a new client func New(u string) (*Client, error) { // Validate we have a URL if err := validate(u); err != nil { return nil, err } return &Client{ BaseURL: u, }, nil } // Validate if the base URL for monocular is valid. func validate(u string) error { // Check if it is parsable p, err := url.Parse(u) if err != nil { return err } // Check that a host is attached if p.Hostname() == "" { return ErrHostnameNotProvided } return nil }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/monocular/client_test.go
internal/monocular/client_test.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package monocular import ( "testing" ) func TestNew(t *testing.T) { c, err := New("https://hub.helm.sh") if err != nil { t.Errorf("error creating client: %s", err) } if c.BaseURL != "https://hub.helm.sh" { t.Errorf("incorrect BaseURL. Expected \"https://hub.helm.sh\" but got %q", c.BaseURL) } }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/monocular/search.go
internal/monocular/search.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package monocular import ( "encoding/json" "fmt" "net/http" "net/url" "path" "time" "helm.sh/helm/v4/internal/version" chart "helm.sh/helm/v4/pkg/chart/v2" ) // SearchPath is the url path to the search API in monocular. const SearchPath = "api/chartsvc/v1/charts/search" // The structs below represent the structure of the response from the monocular // search API. The structs were not imported from monocular because monocular // imports from Helm v2 (avoiding circular version dependency) and the mappings // are slightly different (monocular search results do not directly reflect // the struct definitions). // SearchResult represents an individual chart result type SearchResult struct { ID string `json:"id"` ArtifactHub ArtifactHub `json:"artifactHub"` Type string `json:"type"` Attributes Chart `json:"attributes"` Links Links `json:"links"` Relationships Relationships `json:"relationships"` } // ArtifactHub represents data specific to Artifact Hub instances type ArtifactHub struct { PackageURL string `json:"packageUrl"` } // Chart is the attributes for the chart type Chart struct { Name string `json:"name"` Repo Repo `json:"repo"` Description string `json:"description"` Home string `json:"home"` Keywords []string `json:"keywords"` Maintainers []chart.Maintainer `json:"maintainers"` Sources []string `json:"sources"` Icon string `json:"icon"` } // Repo contains the name in monocular the url for the repository type Repo struct { Name string `json:"name"` URL string `json:"url"` } // Links provides a set of links relative to the chartsvc base type Links struct { Self string `json:"self"` } // Relationships provides information on the latest version of the chart type Relationships struct { LatestChartVersion LatestChartVersion `json:"latestChartVersion"` } // LatestChartVersion provides the details on the latest version of the chart type LatestChartVersion struct { Data ChartVersion `json:"data"` Links Links `json:"links"` } // ChartVersion provides the specific data on the chart version type ChartVersion struct { Version string `json:"version"` AppVersion string `json:"app_version"` Created time.Time `json:"created"` Digest string `json:"digest"` Urls []string `json:"urls"` Readme string `json:"readme"` Values string `json:"values"` } // Search performs a search against the monocular search API func (c *Client) Search(term string) ([]SearchResult, error) { // Create the URL to the search endpoint // Note, this is currently an internal API for the Hub. This should be // formatted without showing how monocular operates. p, err := url.Parse(c.BaseURL) if err != nil { return nil, err } // Set the path to the monocular API endpoint for search p.Path = path.Join(p.Path, SearchPath) p.RawQuery = "q=" + url.QueryEscape(term) // Create request req, err := http.NewRequest(http.MethodGet, p.String(), nil) if err != nil { return nil, err } // Set the user agent so that monocular can identify where the request // is coming from req.Header.Set("User-Agent", version.GetUserAgent()) res, err := http.DefaultClient.Do(req) if err != nil { return nil, err } defer res.Body.Close() if res.StatusCode != http.StatusOK { return nil, fmt.Errorf("failed to fetch %s : %s", p.String(), res.Status) } result := &searchResponse{} json.NewDecoder(res.Body).Decode(result) return result.Data, nil } type searchResponse struct { Data []SearchResult `json:"data"` }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/monocular/search_test.go
internal/monocular/search_test.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package monocular import ( "fmt" "net/http" "net/http/httptest" "testing" ) // A search response for phpmyadmin containing 2 results var searchResult = `{"data":[{"id":"stable/phpmyadmin","type":"chart","attributes":{"name":"phpmyadmin","repo":{"name":"stable","url":"https://charts.helm.sh/stable"},"description":"phpMyAdmin is an mysql administration frontend","home":"https://www.phpmyadmin.net/","keywords":["mariadb","mysql","phpmyadmin"],"maintainers":[{"name":"Bitnami","email":"containers@bitnami.com"}],"sources":["https://github.com/bitnami/bitnami-docker-phpmyadmin"],"icon":""},"links":{"self":"/v1/charts/stable/phpmyadmin"},"relationships":{"latestChartVersion":{"data":{"version":"3.0.0","app_version":"4.9.0-1","created":"2019-08-08T17:57:31.38Z","digest":"119c499251bffd4b06ff0cd5ac98c2ce32231f84899fb4825be6c2d90971c742","urls":["https://charts.helm.sh/stable/phpmyadmin-3.0.0.tgz"],"readme":"/v1/assets/stable/phpmyadmin/versions/3.0.0/README.md","values":"/v1/assets/stable/phpmyadmin/versions/3.0.0/values.yaml"},"links":{"self":"/v1/charts/stable/phpmyadmin/versions/3.0.0"}}}},{"id":"bitnami/phpmyadmin","type":"chart","attributes":{"name":"phpmyadmin","repo":{"name":"bitnami","url":"https://charts.bitnami.com"},"description":"phpMyAdmin is an mysql administration frontend","home":"https://www.phpmyadmin.net/","keywords":["mariadb","mysql","phpmyadmin"],"maintainers":[{"name":"Bitnami","email":"containers@bitnami.com"}],"sources":["https://github.com/bitnami/bitnami-docker-phpmyadmin"],"icon":""},"links":{"self":"/v1/charts/bitnami/phpmyadmin"},"relationships":{"latestChartVersion":{"data":{"version":"3.0.0","app_version":"4.9.0-1","created":"2019-08-08T18:34:13.341Z","digest":"66d77cf6d8c2b52c488d0a294cd4996bd5bad8dc41d3829c394498fb401c008a","urls":["https://charts.bitnami.com/bitnami/phpmyadmin-3.0.0.tgz"],"readme":"/v1/assets/bitnami/phpmyadmin/versions/3.0.0/README.md","values":"/v1/assets/bitnami/phpmyadmin/versions/3.0.0/values.yaml"},"links":{"self":"/v1/charts/bitnami/phpmyadmin/versions/3.0.0"}}}}]}` func TestSearch(t *testing.T) { ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) { fmt.Fprintln(w, searchResult) })) defer ts.Close() c, err := New(ts.URL) if err != nil { t.Errorf("unable to create monocular client: %s", err) } results, err := c.Search("phpmyadmin") if err != nil { t.Errorf("unable to search monocular: %s", err) } if len(results) != 2 { t.Error("Did not receive the expected number of results") } }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/monocular/doc.go
internal/monocular/doc.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ // Package monocular contains the logic for interacting with a Monocular // compatible search API endpoint. For example, as implemented by the Artifact // Hub. // // This is a library for interacting with a monocular compatible search API package monocular
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/runtime_subprocess.go
internal/plugin/runtime_subprocess.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package plugin import ( "bytes" "context" "fmt" "io" "log/slog" "maps" "os" "os/exec" "slices" "helm.sh/helm/v4/internal/plugin/schema" ) // SubprocessProtocolCommand maps a given protocol to the getter command used to retrieve artifacts for that protocol type SubprocessProtocolCommand struct { // Protocols are the list of schemes from the charts URL. Protocols []string `yaml:"protocols"` // PlatformCommand is the platform based command which the plugin performs // to download for the corresponding getter Protocols. PlatformCommand []PlatformCommand `yaml:"platformCommand"` } // RuntimeConfigSubprocess implements RuntimeConfig for RuntimeSubprocess type RuntimeConfigSubprocess struct { // PlatformCommand is a list containing a plugin command, with a platform selector and support for args. PlatformCommand []PlatformCommand `yaml:"platformCommand"` // PlatformHooks are commands that will run on plugin events, with a platform selector and support for args. PlatformHooks PlatformHooks `yaml:"platformHooks"` // ProtocolCommands allows the plugin to specify protocol specific commands // // Obsolete/deprecated: This is a compatibility hangover from the old plugin downloader mechanism, which was extended // to support multiple protocols in a given plugin. The command supplied in PlatformCommand should implement protocol // specific logic by inspecting the download URL ProtocolCommands []SubprocessProtocolCommand `yaml:"protocolCommands,omitempty"` expandHookArgs bool } var _ RuntimeConfig = (*RuntimeConfigSubprocess)(nil) func (r *RuntimeConfigSubprocess) GetType() string { return "subprocess" } func (r *RuntimeConfigSubprocess) Validate() error { return nil } type RuntimeSubprocess struct { EnvVars map[string]string } var _ Runtime = (*RuntimeSubprocess)(nil) // CreatePlugin implementation for Runtime func (r *RuntimeSubprocess) CreatePlugin(pluginDir string, metadata *Metadata) (Plugin, error) { return &SubprocessPluginRuntime{ metadata: *metadata, pluginDir: pluginDir, RuntimeConfig: *(metadata.RuntimeConfig.(*RuntimeConfigSubprocess)), EnvVars: maps.Clone(r.EnvVars), }, nil } // SubprocessPluginRuntime implements the Plugin interface for subprocess execution type SubprocessPluginRuntime struct { metadata Metadata pluginDir string RuntimeConfig RuntimeConfigSubprocess EnvVars map[string]string } var _ Plugin = (*SubprocessPluginRuntime)(nil) func (r *SubprocessPluginRuntime) Dir() string { return r.pluginDir } func (r *SubprocessPluginRuntime) Metadata() Metadata { return r.metadata } func (r *SubprocessPluginRuntime) Invoke(_ context.Context, input *Input) (*Output, error) { switch input.Message.(type) { case schema.InputMessageCLIV1: return r.runCLI(input) case schema.InputMessageGetterV1: return r.runGetter(input) case schema.InputMessagePostRendererV1: return r.runPostrenderer(input) default: return nil, fmt.Errorf("unsupported subprocess plugin type %q", r.metadata.Type) } } // InvokeWithEnv executes a plugin command with custom environment and I/O streams // This method allows execution with different command/args than the plugin's default func (r *SubprocessPluginRuntime) InvokeWithEnv(main string, argv []string, env []string, stdin io.Reader, stdout, stderr io.Writer) error { mainCmdExp := os.ExpandEnv(main) cmd := exec.Command(mainCmdExp, argv...) cmd.Env = slices.Clone(os.Environ()) cmd.Env = append( cmd.Env, fmt.Sprintf("HELM_PLUGIN_NAME=%s", r.metadata.Name), fmt.Sprintf("HELM_PLUGIN_DIR=%s", r.pluginDir)) cmd.Env = append(cmd.Env, env...) cmd.Stdin = stdin cmd.Stdout = stdout cmd.Stderr = stderr if err := executeCmd(cmd, r.metadata.Name); err != nil { return err } return nil } func (r *SubprocessPluginRuntime) InvokeHook(event string) error { cmds := r.RuntimeConfig.PlatformHooks[event] if len(cmds) == 0 { return nil } env := parseEnv(os.Environ()) maps.Insert(env, maps.All(r.EnvVars)) env["HELM_PLUGIN_NAME"] = r.metadata.Name env["HELM_PLUGIN_DIR"] = r.pluginDir main, argv, err := PrepareCommands(cmds, r.RuntimeConfig.expandHookArgs, []string{}, env) if err != nil { return err } cmd := exec.Command(main, argv...) cmd.Env = formatEnv(env) cmd.Stdout = os.Stdout cmd.Stderr = os.Stderr slog.Debug("executing plugin hook command", slog.String("pluginName", r.metadata.Name), slog.String("command", cmd.String())) if err := cmd.Run(); err != nil { if eerr, ok := err.(*exec.ExitError); ok { os.Stderr.Write(eerr.Stderr) return fmt.Errorf("plugin %s hook for %q exited with error", event, r.metadata.Name) } return err } return nil } // TODO decide the best way to handle this code // right now we implement status and error return in 3 slightly different ways in this file // then replace the other three with a call to this func func executeCmd(prog *exec.Cmd, pluginName string) error { if err := prog.Run(); err != nil { if eerr, ok := err.(*exec.ExitError); ok { slog.Debug( "plugin execution failed", slog.String("pluginName", pluginName), slog.String("error", err.Error()), slog.Int("exitCode", eerr.ExitCode()), slog.String("stderr", string(bytes.TrimSpace(eerr.Stderr)))) return &InvokeExecError{ Err: fmt.Errorf("plugin %q exited with error", pluginName), ExitCode: eerr.ExitCode(), } } return err } return nil } func (r *SubprocessPluginRuntime) runCLI(input *Input) (*Output, error) { if _, ok := input.Message.(schema.InputMessageCLIV1); !ok { return nil, fmt.Errorf("plugin %q input message does not implement InputMessageCLIV1", r.metadata.Name) } extraArgs := input.Message.(schema.InputMessageCLIV1).ExtraArgs cmds := r.RuntimeConfig.PlatformCommand env := parseEnv(os.Environ()) maps.Insert(env, maps.All(r.EnvVars)) maps.Insert(env, maps.All(parseEnv(input.Env))) env["HELM_PLUGIN_NAME"] = r.metadata.Name env["HELM_PLUGIN_DIR"] = r.pluginDir command, args, err := PrepareCommands(cmds, true, extraArgs, env) if err != nil { return nil, fmt.Errorf("failed to prepare plugin command: %w", err) } cmd := exec.Command(command, args...) cmd.Env = formatEnv(env) cmd.Stdin = input.Stdin cmd.Stdout = input.Stdout cmd.Stderr = input.Stderr slog.Debug("executing plugin command", slog.String("pluginName", r.metadata.Name), slog.String("command", cmd.String())) if err := executeCmd(cmd, r.metadata.Name); err != nil { return nil, err } return &Output{ Message: schema.OutputMessageCLIV1{}, }, nil } func (r *SubprocessPluginRuntime) runPostrenderer(input *Input) (*Output, error) { if _, ok := input.Message.(schema.InputMessagePostRendererV1); !ok { return nil, fmt.Errorf("plugin %q input message does not implement InputMessagePostRendererV1", r.metadata.Name) } env := parseEnv(os.Environ()) maps.Insert(env, maps.All(r.EnvVars)) maps.Insert(env, maps.All(parseEnv(input.Env))) env["HELM_PLUGIN_NAME"] = r.metadata.Name env["HELM_PLUGIN_DIR"] = r.pluginDir msg := input.Message.(schema.InputMessagePostRendererV1) cmds := r.RuntimeConfig.PlatformCommand command, args, err := PrepareCommands(cmds, true, msg.ExtraArgs, env) if err != nil { return nil, fmt.Errorf("failed to prepare plugin command: %w", err) } cmd := exec.Command( command, args...) stdin, err := cmd.StdinPipe() if err != nil { return nil, err } go func() { defer stdin.Close() io.Copy(stdin, msg.Manifests) }() postRendered := &bytes.Buffer{} stderr := &bytes.Buffer{} cmd.Env = formatEnv(env) cmd.Stdout = postRendered cmd.Stderr = stderr slog.Debug("executing plugin command", slog.String("pluginName", r.metadata.Name), slog.String("command", cmd.String())) if err := executeCmd(cmd, r.metadata.Name); err != nil { return nil, err } return &Output{ Message: schema.OutputMessagePostRendererV1{ Manifests: postRendered, }, }, nil }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/loader.go
internal/plugin/loader.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package plugin import ( "bytes" "fmt" "io" "os" "path/filepath" extism "github.com/extism/go-sdk" "github.com/tetratelabs/wazero" "go.yaml.in/yaml/v3" "helm.sh/helm/v4/pkg/helmpath" ) func peekAPIVersion(r io.Reader) (string, error) { type apiVersion struct { APIVersion string `yaml:"apiVersion"` } var v apiVersion d := yaml.NewDecoder(r) if err := d.Decode(&v); err != nil { return "", err } return v.APIVersion, nil } func loadMetadataLegacy(metadataData []byte) (*Metadata, error) { var ml MetadataLegacy d := yaml.NewDecoder(bytes.NewReader(metadataData)) // NOTE: No strict unmarshalling for legacy plugins - maintain backwards compatibility if err := d.Decode(&ml); err != nil { return nil, err } if err := ml.Validate(); err != nil { return nil, err } m := fromMetadataLegacy(ml) if err := m.Validate(); err != nil { return nil, err } return m, nil } func loadMetadataV1(metadataData []byte) (*Metadata, error) { var mv1 MetadataV1 d := yaml.NewDecoder(bytes.NewReader(metadataData)) d.KnownFields(true) if err := d.Decode(&mv1); err != nil { return nil, err } if err := mv1.Validate(); err != nil { return nil, err } m, err := fromMetadataV1(mv1) if err != nil { return nil, fmt.Errorf("failed to convert MetadataV1 to Metadata: %w", err) } if err := m.Validate(); err != nil { return nil, err } return m, nil } func loadMetadata(metadataData []byte) (*Metadata, error) { apiVersion, err := peekAPIVersion(bytes.NewReader(metadataData)) if err != nil { return nil, fmt.Errorf("failed to peek %s API version: %w", PluginFileName, err) } switch apiVersion { case "": // legacy return loadMetadataLegacy(metadataData) case "v1": return loadMetadataV1(metadataData) } return nil, fmt.Errorf("invalid plugin apiVersion: %q", apiVersion) } type prototypePluginManager struct { runtimes map[string]Runtime } func newPrototypePluginManager() (*prototypePluginManager, error) { cc, err := wazero.NewCompilationCacheWithDir(helmpath.CachePath("wazero-build")) if err != nil { return nil, fmt.Errorf("failed to create wazero compilation cache: %w", err) } return &prototypePluginManager{ runtimes: map[string]Runtime{ "subprocess": &RuntimeSubprocess{}, "extism/v1": &RuntimeExtismV1{ HostFunctions: map[string]extism.HostFunction{}, CompilationCache: cc, }, }, }, nil } func (pm *prototypePluginManager) RegisterRuntime(runtimeName string, runtime Runtime) { pm.runtimes[runtimeName] = runtime } func (pm *prototypePluginManager) CreatePlugin(pluginPath string, metadata *Metadata) (Plugin, error) { rt, ok := pm.runtimes[metadata.Runtime] if !ok { return nil, fmt.Errorf("unsupported plugin runtime type: %q", metadata.Runtime) } return rt.CreatePlugin(pluginPath, metadata) } // LoadDir loads a plugin from the given directory. func LoadDir(dirname string) (Plugin, error) { pluginfile := filepath.Join(dirname, PluginFileName) metadataData, err := os.ReadFile(pluginfile) if err != nil { return nil, fmt.Errorf("failed to read plugin at %q: %w", pluginfile, err) } m, err := loadMetadata(metadataData) if err != nil { return nil, fmt.Errorf("failed to load plugin %q: %w", dirname, err) } pm, err := newPrototypePluginManager() if err != nil { return nil, fmt.Errorf("failed to create plugin manager: %w", err) } return pm.CreatePlugin(dirname, m) } // LoadAll loads all plugins found beneath the base directory. // // This scans only one directory level. func LoadAll(basedir string) ([]Plugin, error) { var plugins []Plugin // We want basedir/*/plugin.yaml scanpath := filepath.Join(basedir, "*", PluginFileName) matches, err := filepath.Glob(scanpath) if err != nil { return nil, fmt.Errorf("failed to search for plugins in %q: %w", scanpath, err) } // empty dir should load if len(matches) == 0 { return plugins, nil } for _, yamlFile := range matches { dir := filepath.Dir(yamlFile) p, err := LoadDir(dir) if err != nil { return plugins, err } plugins = append(plugins, p) } return plugins, detectDuplicates(plugins) } // findFunc is a function that finds plugins in a directory type findFunc func(pluginsDir string) ([]Plugin, error) // filterFunc is a function that filters plugins type filterFunc func(Plugin) bool // FindPlugins returns a list of plugins that match the descriptor func FindPlugins(pluginsDirs []string, descriptor Descriptor) ([]Plugin, error) { return findPlugins(pluginsDirs, LoadAll, makeDescriptorFilter(descriptor)) } // findPlugins is the internal implementation that uses the find and filter functions func findPlugins(pluginsDirs []string, findFn findFunc, filterFn filterFunc) ([]Plugin, error) { var found []Plugin for _, pluginsDir := range pluginsDirs { ps, err := findFn(pluginsDir) if err != nil { return nil, err } for _, p := range ps { if filterFn(p) { found = append(found, p) } } } return found, nil } // makeDescriptorFilter creates a filter function from a descriptor // Additional plugin filter criteria we wish to support can be added here func makeDescriptorFilter(descriptor Descriptor) filterFunc { return func(p Plugin) bool { // If name is specified, it must match if descriptor.Name != "" && p.Metadata().Name != descriptor.Name { return false } // If type is specified, it must match if descriptor.Type != "" && p.Metadata().Type != descriptor.Type { return false } return true } } // FindPlugin returns a single plugin that matches the descriptor func FindPlugin(dirs []string, descriptor Descriptor) (Plugin, error) { plugins, err := FindPlugins(dirs, descriptor) if err != nil { return nil, err } if len(plugins) > 0 { return plugins[0], nil } return nil, fmt.Errorf("plugin: %+v not found", descriptor) } func detectDuplicates(plugs []Plugin) error { names := map[string]string{} for _, plug := range plugs { if oldpath, ok := names[plug.Metadata().Name]; ok { return fmt.Errorf( "two plugins claim the name %q at %q and %q", plug.Metadata().Name, oldpath, plug.Dir(), ) } names[plug.Metadata().Name] = plug.Dir() } return nil }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/descriptor.go
internal/plugin/descriptor.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package plugin // Descriptor describes a plugin to find type Descriptor struct { // Name is the name of the plugin Name string // Type is the type of the plugin (cli, getter, postrenderer) Type string }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/subprocess_commands_test.go
internal/plugin/subprocess_commands_test.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package plugin import ( "reflect" "runtime" "testing" "github.com/stretchr/testify/assert" ) func TestPrepareCommand(t *testing.T) { cmdMain := "sh" cmdArgs := []string{"-c", "echo \"test\""} platformCommand := []PlatformCommand{ {OperatingSystem: "no-os", Architecture: "no-arch", Command: "pwsh", Args: []string{"-c", "echo \"error\""}}, {OperatingSystem: runtime.GOOS, Architecture: "no-arch", Command: "pwsh", Args: []string{"-c", "echo \"error\""}}, {OperatingSystem: runtime.GOOS, Architecture: "", Command: "pwsh", Args: []string{"-c", "echo \"error\""}}, {OperatingSystem: runtime.GOOS, Architecture: runtime.GOARCH, Command: cmdMain, Args: cmdArgs}, } env := map[string]string{} cmd, args, err := PrepareCommands(platformCommand, true, []string{}, env) if err != nil { t.Fatal(err) } if cmd != cmdMain { t.Fatalf("Expected %q, got %q", cmdMain, cmd) } if !reflect.DeepEqual(args, cmdArgs) { t.Fatalf("Expected %v, got %v", cmdArgs, args) } } func TestPrepareCommandExtraArgs(t *testing.T) { cmdMain := "sh" cmdArgs := []string{"-c", "echo \"test\""} platformCommand := []PlatformCommand{ {OperatingSystem: "no-os", Architecture: "no-arch", Command: "pwsh", Args: []string{"-c", "echo \"error\""}}, {OperatingSystem: runtime.GOOS, Architecture: runtime.GOARCH, Command: cmdMain, Args: cmdArgs}, {OperatingSystem: runtime.GOOS, Architecture: "no-arch", Command: "pwsh", Args: []string{"-c", "echo \"error\""}}, {OperatingSystem: runtime.GOOS, Architecture: "", Command: "pwsh", Args: []string{"-c", "echo \"error\""}}, } extraArgs := []string{"--debug", "--foo", "bar"} type testCaseExpected struct { cmdMain string args []string } testCases := map[string]struct { ignoreFlags bool expected testCaseExpected }{ "ignoreFlags false": { ignoreFlags: false, expected: testCaseExpected{ cmdMain: cmdMain, args: []string{"-c", "echo \"test\"", "--debug", "--foo", "bar"}, }, }, "ignoreFlags true": { ignoreFlags: true, expected: testCaseExpected{ cmdMain: cmdMain, args: []string{"-c", "echo \"test\""}, }, }, } for name, tc := range testCases { t.Run(name, func(t *testing.T) { // extra args are expected when ignoreFlags is unset or false testExtraArgs := extraArgs if tc.ignoreFlags { testExtraArgs = []string{} } env := map[string]string{} cmd, args, err := PrepareCommands(platformCommand, true, testExtraArgs, env) if err != nil { t.Fatal(err) } assert.Equal(t, tc.expected.cmdMain, cmd, "Expected command to match") assert.Equal(t, tc.expected.args, args, "Expected args to match") }) } } func TestPrepareCommands(t *testing.T) { cmdMain := "sh" cmdArgs := []string{"-c", "echo \"test\""} cmds := []PlatformCommand{ {OperatingSystem: "no-os", Architecture: "no-arch", Command: "pwsh", Args: []string{"-c", "echo \"error\""}}, {OperatingSystem: runtime.GOOS, Architecture: runtime.GOARCH, Command: cmdMain, Args: cmdArgs}, {OperatingSystem: runtime.GOOS, Architecture: "no-arch", Command: "pwsh", Args: []string{"-c", "echo \"error\""}}, {OperatingSystem: runtime.GOOS, Architecture: "", Command: "pwsh", Args: []string{"-c", "echo \"error\""}}, } env := map[string]string{} cmd, args, err := PrepareCommands(cmds, true, []string{}, env) if err != nil { t.Fatal(err) } if cmd != cmdMain { t.Fatalf("Expected %q, got %q", cmdMain, cmd) } if !reflect.DeepEqual(args, cmdArgs) { t.Fatalf("Expected %v, got %v", cmdArgs, args) } } func TestPrepareCommandsExtraArgs(t *testing.T) { cmdMain := "sh" cmdArgs := []string{"-c", "echo \"test\""} extraArgs := []string{"--debug", "--foo", "bar"} cmds := []PlatformCommand{ {OperatingSystem: "no-os", Architecture: "no-arch", Command: "pwsh", Args: []string{"-c", "echo \"error\""}}, {OperatingSystem: runtime.GOOS, Architecture: runtime.GOARCH, Command: "sh", Args: []string{"-c", "echo \"test\""}}, {OperatingSystem: runtime.GOOS, Architecture: "no-arch", Command: "pwsh", Args: []string{"-c", "echo \"error\""}}, {OperatingSystem: runtime.GOOS, Architecture: "", Command: "pwsh", Args: []string{"-c", "echo \"error\""}}, } expectedArgs := append(cmdArgs, extraArgs...) env := map[string]string{} cmd, args, err := PrepareCommands(cmds, true, extraArgs, env) if err != nil { t.Fatal(err) } if cmd != cmdMain { t.Fatalf("Expected %q, got %q", cmdMain, cmd) } if !reflect.DeepEqual(args, expectedArgs) { t.Fatalf("Expected %v, got %v", expectedArgs, args) } } func TestPrepareCommandsNoArch(t *testing.T) { cmdMain := "sh" cmdArgs := []string{"-c", "echo \"test\""} cmds := []PlatformCommand{ {OperatingSystem: "no-os", Architecture: "no-arch", Command: "pwsh", Args: []string{"-c", "echo \"error\""}}, {OperatingSystem: runtime.GOOS, Architecture: "", Command: "sh", Args: []string{"-c", "echo \"test\""}}, {OperatingSystem: runtime.GOOS, Architecture: "no-arch", Command: "pwsh", Args: []string{"-c", "echo \"error\""}}, } env := map[string]string{} cmd, args, err := PrepareCommands(cmds, true, []string{}, env) if err != nil { t.Fatal(err) } if cmd != cmdMain { t.Fatalf("Expected %q, got %q", cmdMain, cmd) } if !reflect.DeepEqual(args, cmdArgs) { t.Fatalf("Expected %v, got %v", cmdArgs, args) } } func TestPrepareCommandsNoOsNoArch(t *testing.T) { cmdMain := "sh" cmdArgs := []string{"-c", "echo \"test\""} cmds := []PlatformCommand{ {OperatingSystem: "no-os", Architecture: "no-arch", Command: "pwsh", Args: []string{"-c", "echo \"error\""}}, {OperatingSystem: "", Architecture: "", Command: "sh", Args: []string{"-c", "echo \"test\""}}, {OperatingSystem: runtime.GOOS, Architecture: "no-arch", Command: "pwsh", Args: []string{"-c", "echo \"error\""}}, } env := map[string]string{} cmd, args, err := PrepareCommands(cmds, true, []string{}, env) if err != nil { t.Fatal(err) } if cmd != cmdMain { t.Fatalf("Expected %q, got %q", cmdMain, cmd) } if !reflect.DeepEqual(args, cmdArgs) { t.Fatalf("Expected %v, got %v", cmdArgs, args) } } func TestPrepareCommandsNoMatch(t *testing.T) { cmds := []PlatformCommand{ {OperatingSystem: "no-os", Architecture: "no-arch", Command: "sh", Args: []string{"-c", "echo \"test\""}}, {OperatingSystem: runtime.GOOS, Architecture: "no-arch", Command: "sh", Args: []string{"-c", "echo \"test\""}}, {OperatingSystem: "no-os", Architecture: runtime.GOARCH, Command: "sh", Args: []string{"-c", "echo \"test\""}}, } env := map[string]string{} if _, _, err := PrepareCommands(cmds, true, []string{}, env); err == nil { t.Fatalf("Expected error to be returned") } } func TestPrepareCommandsNoCommands(t *testing.T) { cmds := []PlatformCommand{} env := map[string]string{} if _, _, err := PrepareCommands(cmds, true, []string{}, env); err == nil { t.Fatalf("Expected error to be returned") } } func TestPrepareCommandsExpand(t *testing.T) { cmdMain := "sh" cmdArgs := []string{"-c", "echo \"${TESTX}${TESTY}\""} cmds := []PlatformCommand{ {OperatingSystem: "", Architecture: "", Command: cmdMain, Args: cmdArgs}, } expectedArgs := []string{"-c", "echo \"testxtesty\""} env := map[string]string{ "TESTX": "testx", "TESTY": "testy", } cmd, args, err := PrepareCommands(cmds, true, []string{}, env) if err != nil { t.Fatal(err) } if cmd != cmdMain { t.Fatalf("Expected %q, got %q", cmdMain, cmd) } if !reflect.DeepEqual(args, expectedArgs) { t.Fatalf("Expected %v, got %v", expectedArgs, args) } } func TestPrepareCommandsNoExpand(t *testing.T) { cmdMain := "sh" cmdArgs := []string{"-c", "echo \"${TEST}\""} cmds := []PlatformCommand{ {OperatingSystem: "", Architecture: "", Command: cmdMain, Args: cmdArgs}, } env := map[string]string{ "TEST": "test", } cmd, args, err := PrepareCommands(cmds, false, []string{}, env) if err != nil { t.Fatal(err) } if cmd != cmdMain { t.Fatalf("Expected %q, got %q", cmdMain, cmd) } if !reflect.DeepEqual(args, cmdArgs) { t.Fatalf("Expected %v, got %v", cmdArgs, args) } }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/runtime_subprocess_hooks.go
internal/plugin/runtime_subprocess_hooks.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package plugin // import "helm.sh/helm/v4/internal/plugin" // Types of hooks const ( // Install is executed after the plugin is added. Install = "install" // Delete is executed after the plugin is removed. Delete = "delete" // Update is executed after the plugin is updated. Update = "update" ) // PlatformHooks is a map of events to a command for a particular operating system and architecture. type PlatformHooks map[string][]PlatformCommand // Hooks is a map of events to commands. type Hooks map[string]string
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/verify.go
internal/plugin/verify.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package plugin import ( "path/filepath" "helm.sh/helm/v4/pkg/provenance" ) // VerifyPlugin verifies plugin data against a signature using data in memory. func VerifyPlugin(archiveData, provData []byte, filename, keyring string) (*provenance.Verification, error) { // Create signatory from keyring sig, err := provenance.NewFromKeyring(keyring, "") if err != nil { return nil, err } // Use the new VerifyData method directly return sig.Verify(archiveData, provData, filename) } // isTarball checks if a file has a tarball extension func IsTarball(filename string) bool { return filepath.Ext(filename) == ".gz" || filepath.Ext(filename) == ".tgz" }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/metadata_v1.go
internal/plugin/metadata_v1.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package plugin import ( "fmt" ) // MetadataV1 is the APIVersion V1 plugin.yaml format type MetadataV1 struct { // APIVersion specifies the plugin API version APIVersion string `yaml:"apiVersion"` // Name is the name of the plugin Name string `yaml:"name"` // Type of plugin (eg, cli/v1, getter/v1, postrenderer/v1) Type string `yaml:"type"` // Runtime specifies the runtime type (subprocess, wasm) Runtime string `yaml:"runtime"` // Version is a SemVer 2 version of the plugin. Version string `yaml:"version"` // SourceURL is the URL where this plugin can be found SourceURL string `yaml:"sourceURL,omitempty"` // Config contains the type-specific configuration for this plugin Config map[string]any `yaml:"config"` // RuntimeConfig contains the runtime-specific configuration RuntimeConfig map[string]any `yaml:"runtimeConfig"` } func (m *MetadataV1) Validate() error { if !validPluginName.MatchString(m.Name) { return fmt.Errorf("invalid plugin `name`") } if m.APIVersion != "v1" { return fmt.Errorf("invalid `apiVersion`: %q", m.APIVersion) } if m.Type == "" { return fmt.Errorf("`type` missing") } if m.Runtime == "" { return fmt.Errorf("`runtime` missing") } return nil }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/plugin_type_registry_test.go
internal/plugin/plugin_type_registry_test.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package plugin import ( "reflect" "testing" "github.com/stretchr/testify/assert" "helm.sh/helm/v4/internal/plugin/schema" ) func TestMakeOutputMessage(t *testing.T) { ptm := pluginTypesIndex["getter/v1"] outputType := reflect.Zero(ptm.outputType).Interface() assert.IsType(t, schema.OutputMessageGetterV1{}, outputType) } func TestMakeConfig(t *testing.T) { ptm := pluginTypesIndex["getter/v1"] config := reflect.New(ptm.configType).Interface().(Config) assert.IsType(t, &schema.ConfigGetterV1{}, config) }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/error.go
internal/plugin/error.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package plugin // InvokeExecError is returned when a plugin invocation returns a non-zero status/exit code // - subprocess plugin: child process exit code // - extism plugin: wasm function return code type InvokeExecError struct { ExitCode int // Exit code from plugin code execution Err error // Underlying error } // Error implements the error interface func (e *InvokeExecError) Error() string { return e.Err.Error() }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/metadata_legacy.go
internal/plugin/metadata_legacy.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package plugin import ( "fmt" "strings" "unicode" ) // Downloaders represents the plugins capability if it can retrieve // charts from special sources type Downloaders struct { // Protocols are the list of schemes from the charts URL. Protocols []string `yaml:"protocols"` // Command is the executable path with which the plugin performs // the actual download for the corresponding Protocols Command string `yaml:"command"` } // MetadataLegacy is the legacy plugin.yaml format type MetadataLegacy struct { // Name is the name of the plugin Name string `yaml:"name"` // Version is a SemVer 2 version of the plugin. Version string `yaml:"version"` // Usage is the single-line usage text shown in help Usage string `yaml:"usage"` // Description is a long description shown in places like `helm help` Description string `yaml:"description"` // PlatformCommand is the plugin command, with a platform selector and support for args. PlatformCommand []PlatformCommand `yaml:"platformCommand"` // Command is the plugin command, as a single string. // DEPRECATED: Use PlatformCommand instead. Removed in subprocess/v1 plugins. Command string `yaml:"command"` // IgnoreFlags ignores any flags passed in from Helm IgnoreFlags bool `yaml:"ignoreFlags"` // PlatformHooks are commands that will run on plugin events, with a platform selector and support for args. PlatformHooks PlatformHooks `yaml:"platformHooks"` // Hooks are commands that will run on plugin events, as a single string. // DEPRECATED: Use PlatformHooks instead. Removed in subprocess/v1 plugins. Hooks Hooks `yaml:"hooks"` // Downloaders field is used if the plugin supply downloader mechanism // for special protocols. Downloaders []Downloaders `yaml:"downloaders"` } func (m *MetadataLegacy) Validate() error { if !validPluginName.MatchString(m.Name) { return fmt.Errorf("invalid plugin name %q: must contain only a-z, A-Z, 0-9, _ and -", m.Name) } m.Usage = sanitizeString(m.Usage) if len(m.PlatformCommand) > 0 && len(m.Command) > 0 { return fmt.Errorf("both platformCommand and command are set") } if len(m.PlatformHooks) > 0 && len(m.Hooks) > 0 { return fmt.Errorf("both platformHooks and hooks are set") } // Validate downloader plugins for i, downloader := range m.Downloaders { if downloader.Command == "" { return fmt.Errorf("downloader %d has empty command", i) } if len(downloader.Protocols) == 0 { return fmt.Errorf("downloader %d has no protocols", i) } for j, protocol := range downloader.Protocols { if protocol == "" { return fmt.Errorf("downloader %d has empty protocol at index %d", i, j) } } } return nil } // sanitizeString normalize spaces and removes non-printable characters. func sanitizeString(str string) string { return strings.Map(func(r rune) rune { if unicode.IsSpace(r) { return ' ' } if unicode.IsPrint(r) { return r } return -1 }, str) }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/runtime_test.go
internal/plugin/runtime_test.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package plugin import ( "testing" "github.com/stretchr/testify/assert" ) func TestParseEnv(t *testing.T) { type testCase struct { env []string expected map[string]string } testCases := map[string]testCase{ "empty": { env: []string{}, expected: map[string]string{}, }, "single": { env: []string{"KEY=value"}, expected: map[string]string{"KEY": "value"}, }, "multiple": { env: []string{"KEY1=value1", "KEY2=value2"}, expected: map[string]string{"KEY1": "value1", "KEY2": "value2"}, }, "no_value": { env: []string{"KEY1=value1", "KEY2="}, expected: map[string]string{"KEY1": "value1", "KEY2": ""}, }, "duplicate_keys": { env: []string{"KEY=value1", "KEY=value2"}, expected: map[string]string{"KEY": "value2"}, // last value should overwrite }, "empty_strings": { env: []string{"", "KEY=value", ""}, expected: map[string]string{"KEY": "value"}, }, } for name, tc := range testCases { t.Run(name, func(t *testing.T) { result := parseEnv(tc.env) assert.Equal(t, tc.expected, result) }) } } func TestFormatEnv(t *testing.T) { type testCase struct { env map[string]string expected []string } testCases := map[string]testCase{ "empty": { env: map[string]string{}, expected: []string{}, }, "single": { env: map[string]string{"KEY": "value"}, expected: []string{"KEY=value"}, }, "multiple": { env: map[string]string{"KEY1": "value1", "KEY2": "value2"}, expected: []string{"KEY1=value1", "KEY2=value2"}, }, "empty_key": { env: map[string]string{"": "value1", "KEY2": "value2"}, expected: []string{"=value1", "KEY2=value2"}, }, "empty_value": { env: map[string]string{"KEY1": "value1", "KEY2": "", "KEY3": "value3"}, expected: []string{"KEY1=value1", "KEY2=", "KEY3=value3"}, }, } for name, tc := range testCases { t.Run(name, func(t *testing.T) { result := formatEnv(tc.env) assert.ElementsMatch(t, tc.expected, result) }) } }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/plugin_type_registry.go
internal/plugin/plugin_type_registry.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ /* This file contains a "registry" of supported plugin types. It enables "dyanmic" operations on the go type associated with a given plugin type (see: `helm.sh/helm/v4/internal/plugin/schema` package) Examples: ``` // Create a new instance of the output message type for a given plugin type: pluginType := "cli/v1" // for example ptm, ok := pluginTypesIndex[pluginType] if !ok { return fmt.Errorf("unknown plugin type %q", pluginType) } outputMessageType := reflect.Zero(ptm.outputType).Interface() ``` ``` // Create a new instance of the config type for a given plugin type pluginType := "cli/v1" // for example ptm, ok := pluginTypesIndex[pluginType] if !ok { return nil } config := reflect.New(ptm.configType).Interface().(Config) // `config` is variable of type `Config`, with // validate err := config.Validate() if err != nil { // handle error } // assert to concrete type if needed cliConfig := config.(*schema.ConfigCLIV1) ``` */ package plugin import ( "reflect" "helm.sh/helm/v4/internal/plugin/schema" ) type pluginTypeMeta struct { pluginType string inputType reflect.Type outputType reflect.Type configType reflect.Type } var pluginTypes = []pluginTypeMeta{ { pluginType: "test/v1", inputType: reflect.TypeFor[schema.InputMessageTestV1](), outputType: reflect.TypeFor[schema.OutputMessageTestV1](), configType: reflect.TypeFor[schema.ConfigTestV1](), }, { pluginType: "cli/v1", inputType: reflect.TypeFor[schema.InputMessageCLIV1](), outputType: reflect.TypeFor[schema.OutputMessageCLIV1](), configType: reflect.TypeFor[schema.ConfigCLIV1](), }, { pluginType: "getter/v1", inputType: reflect.TypeFor[schema.InputMessageGetterV1](), outputType: reflect.TypeFor[schema.OutputMessageGetterV1](), configType: reflect.TypeFor[schema.ConfigGetterV1](), }, { pluginType: "postrenderer/v1", inputType: reflect.TypeFor[schema.InputMessagePostRendererV1](), outputType: reflect.TypeFor[schema.OutputMessagePostRendererV1](), configType: reflect.TypeFor[schema.ConfigPostRendererV1](), }, } var pluginTypesIndex = func() map[string]*pluginTypeMeta { result := make(map[string]*pluginTypeMeta, len(pluginTypes)) for _, m := range pluginTypes { result[m.pluginType] = &m } return result }()
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/subprocess_commands.go
internal/plugin/subprocess_commands.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package plugin import ( "fmt" "os" "runtime" "strings" ) // PlatformCommand represents a command for a particular operating system and architecture type PlatformCommand struct { OperatingSystem string `yaml:"os"` Architecture string `yaml:"arch"` Command string `yaml:"command"` Args []string `yaml:"args"` } // Returns command and args strings based on the following rules in priority order: // - From the PlatformCommand where OS and Arch match the current platform // - From the PlatformCommand where OS matches the current platform and Arch is empty/unspecified // - From the PlatformCommand where OS is empty/unspecified and Arch matches the current platform // - From the PlatformCommand where OS and Arch are both empty/unspecified // - Return nil, nil func getPlatformCommand(cmds []PlatformCommand) ([]string, []string) { var command, args []string found := false foundOs := false eq := strings.EqualFold for _, c := range cmds { if eq(c.OperatingSystem, runtime.GOOS) && eq(c.Architecture, runtime.GOARCH) { // Return early for an exact match return strings.Split(c.Command, " "), c.Args } if (len(c.OperatingSystem) > 0 && !eq(c.OperatingSystem, runtime.GOOS)) || len(c.Architecture) > 0 { // Skip if OS is not empty and doesn't match or if arch is set as a set arch requires an OS match continue } if !foundOs && len(c.OperatingSystem) > 0 && eq(c.OperatingSystem, runtime.GOOS) { // First OS match with empty arch, can only be overridden by a direct match command = strings.Split(c.Command, " ") args = c.Args found = true foundOs = true } else if !found { // First empty match, can be overridden by a direct match or an OS match command = strings.Split(c.Command, " ") args = c.Args found = true } } return command, args } // PrepareCommands takes a []Plugin.PlatformCommand // and prepares the command and arguments for execution. // // It merges extraArgs into any arguments supplied in the plugin. It // returns the main command and an args array. // // The result is suitable to pass to exec.Command. func PrepareCommands(cmds []PlatformCommand, expandArgs bool, extraArgs []string, env map[string]string) (string, []string, error) { cmdParts, args := getPlatformCommand(cmds) if len(cmdParts) == 0 || cmdParts[0] == "" { return "", nil, fmt.Errorf("no plugin command is applicable") } envMappingFunc := func(key string) string { return env[key] } main := os.Expand(cmdParts[0], envMappingFunc) baseArgs := []string{} if len(cmdParts) > 1 { for _, cmdPart := range cmdParts[1:] { if expandArgs { baseArgs = append(baseArgs, os.Expand(cmdPart, envMappingFunc)) } else { baseArgs = append(baseArgs, cmdPart) } } } for _, arg := range args { if expandArgs { baseArgs = append(baseArgs, os.Expand(arg, envMappingFunc)) } else { baseArgs = append(baseArgs, arg) } } if len(extraArgs) > 0 { baseArgs = append(baseArgs, extraArgs...) } return main, baseArgs, nil }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/sign.go
internal/plugin/sign.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package plugin import ( "archive/tar" "bytes" "compress/gzip" "errors" "fmt" "io" "os" "path/filepath" "sigs.k8s.io/yaml" "helm.sh/helm/v4/pkg/provenance" ) // SignPlugin signs a plugin using the SHA256 hash of the tarball data. // // This is used when packaging and signing a plugin from tarball data. // It creates a signature that includes the tarball hash and plugin metadata, // allowing verification of the original tarball later. func SignPlugin(tarballData []byte, filename string, signer *provenance.Signatory) (string, error) { // Extract plugin metadata from tarball data pluginMeta, err := ExtractTgzPluginMetadata(bytes.NewReader(tarballData)) if err != nil { return "", fmt.Errorf("failed to extract plugin metadata: %w", err) } // Marshal plugin metadata to YAML bytes metadataBytes, err := yaml.Marshal(pluginMeta) if err != nil { return "", fmt.Errorf("failed to marshal plugin metadata: %w", err) } // Use the generic provenance signing function return signer.ClearSign(tarballData, filename, metadataBytes) } // ExtractTgzPluginMetadata extracts plugin metadata from a gzipped tarball reader func ExtractTgzPluginMetadata(r io.Reader) (*Metadata, error) { gzr, err := gzip.NewReader(r) if err != nil { return nil, err } defer gzr.Close() tr := tar.NewReader(gzr) for { header, err := tr.Next() if errors.Is(err, io.EOF) { break } if err != nil { return nil, err } // Look for plugin.yaml file if filepath.Base(header.Name) == "plugin.yaml" { data, err := io.ReadAll(tr) if err != nil { return nil, err } // Parse the plugin metadata metadata, err := loadMetadata(data) if err != nil { return nil, err } return metadata, nil } } return nil, errors.New("plugin.yaml not found in tarball") } // parsePluginMessageBlock parses a signed message block to extract plugin metadata and checksums func parsePluginMessageBlock(data []byte) (*Metadata, *provenance.SumCollection, error) { sc := &provenance.SumCollection{} // We only need the checksums for verification, not the full metadata if err := provenance.ParseMessageBlock(data, nil, sc); err != nil { return nil, sc, err } return nil, sc, nil } // CreatePluginTarball creates a gzipped tarball from a plugin directory func CreatePluginTarball(sourceDir, pluginName string, w io.Writer) error { gzw := gzip.NewWriter(w) defer gzw.Close() tw := tar.NewWriter(gzw) defer tw.Close() // Use the plugin name as the base directory in the tarball baseDir := pluginName // Walk the directory tree return filepath.Walk(sourceDir, func(path string, info os.FileInfo, err error) error { if err != nil { return err } // Create header header, err := tar.FileInfoHeader(info, "") if err != nil { return err } // Update the name to be relative to the source directory relPath, err := filepath.Rel(sourceDir, path) if err != nil { return err } // Include the base directory name in the tarball header.Name = filepath.Join(baseDir, relPath) // Write header if err := tw.WriteHeader(header); err != nil { return err } // If it's a regular file, write its content if info.Mode().IsRegular() { file, err := os.Open(path) if err != nil { return err } defer file.Close() if _, err := io.Copy(tw, file); err != nil { return err } } return nil }) }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/config.go
internal/plugin/config.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package plugin import ( "bytes" "fmt" "reflect" "go.yaml.in/yaml/v3" ) // Config represents a plugin type specific configuration // It is expected to type assert (cast) the Config to its expected underlying type (schema.ConfigCLIV1, schema.ConfigGetterV1, etc). type Config interface { Validate() error } func unmarshalConfig(pluginType string, configData map[string]any) (Config, error) { pluginTypeMeta, ok := pluginTypesIndex[pluginType] if !ok { return nil, fmt.Errorf("unknown plugin type %q", pluginType) } // TODO: Avoid (yaml) serialization/deserialization for type conversion here data, err := yaml.Marshal(configData) if err != nil { return nil, fmt.Errorf("failed to marshel config data (plugin type %s): %w", pluginType, err) } config := reflect.New(pluginTypeMeta.configType) d := yaml.NewDecoder(bytes.NewReader(data)) d.KnownFields(true) if err := d.Decode(config.Interface()); err != nil { return nil, err } return config.Interface().(Config), nil }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/metadata.go
internal/plugin/metadata.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package plugin import ( "errors" "fmt" "helm.sh/helm/v4/internal/plugin/schema" ) // Metadata of a plugin, converted from the "on-disk" legacy or v1 plugin.yaml // Specifically, Config and RuntimeConfig are converted to their respective types based on the plugin type and runtime type Metadata struct { // APIVersion specifies the plugin API version APIVersion string // Name is the name of the plugin Name string // Type of plugin (eg, cli/v1, getter/v1, postrenderer/v1) Type string // Runtime specifies the runtime type (subprocess, wasm) Runtime string // Version is the SemVer 2 version of the plugin. Version string // SourceURL is the URL where this plugin can be found SourceURL string // Config contains the type-specific configuration for this plugin Config Config // RuntimeConfig contains the runtime-specific configuration RuntimeConfig RuntimeConfig } func (m Metadata) Validate() error { var errs []error if !validPluginName.MatchString(m.Name) { errs = append(errs, fmt.Errorf("invalid plugin name %q: must contain only a-z, A-Z, 0-9, _ and -", m.Name)) } if m.APIVersion == "" { errs = append(errs, fmt.Errorf("empty APIVersion")) } if m.Type == "" { errs = append(errs, fmt.Errorf("empty type field")) } if m.Runtime == "" { errs = append(errs, fmt.Errorf("empty runtime field")) } if m.Config == nil { errs = append(errs, fmt.Errorf("missing config field")) } if m.RuntimeConfig == nil { errs = append(errs, fmt.Errorf("missing runtimeConfig field")) } // Validate the config itself if m.Config != nil { if err := m.Config.Validate(); err != nil { errs = append(errs, fmt.Errorf("config validation failed: %w", err)) } } // Validate the runtime config itself if m.RuntimeConfig != nil { if err := m.RuntimeConfig.Validate(); err != nil { errs = append(errs, fmt.Errorf("runtime config validation failed: %w", err)) } } if len(errs) > 0 { return errors.Join(errs...) } return nil } func fromMetadataLegacy(m MetadataLegacy) *Metadata { pluginType := "cli/v1" if len(m.Downloaders) > 0 { pluginType = "getter/v1" } return &Metadata{ APIVersion: "legacy", Name: m.Name, Version: m.Version, Type: pluginType, Runtime: "subprocess", Config: buildLegacyConfig(m, pluginType), RuntimeConfig: buildLegacyRuntimeConfig(m), } } func buildLegacyConfig(m MetadataLegacy, pluginType string) Config { switch pluginType { case "getter/v1": var protocols []string for _, d := range m.Downloaders { protocols = append(protocols, d.Protocols...) } return &schema.ConfigGetterV1{ Protocols: protocols, } case "cli/v1": return &schema.ConfigCLIV1{ Usage: "", // Legacy plugins don't have Usage field for command syntax ShortHelp: m.Usage, // Map legacy usage to shortHelp LongHelp: m.Description, // Map legacy description to longHelp IgnoreFlags: m.IgnoreFlags, } default: return nil } } func buildLegacyRuntimeConfig(m MetadataLegacy) RuntimeConfig { var protocolCommands []SubprocessProtocolCommand if len(m.Downloaders) > 0 { protocolCommands = make([]SubprocessProtocolCommand, 0, len(m.Downloaders)) for _, d := range m.Downloaders { protocolCommands = append(protocolCommands, SubprocessProtocolCommand{ Protocols: d.Protocols, PlatformCommand: []PlatformCommand{{Command: d.Command}}, }) } } platformCommand := m.PlatformCommand if len(platformCommand) == 0 && len(m.Command) > 0 { platformCommand = []PlatformCommand{{Command: m.Command}} } platformHooks := m.PlatformHooks expandHookArgs := true if len(platformHooks) == 0 && len(m.Hooks) > 0 { platformHooks = make(PlatformHooks, len(m.Hooks)) for hookName, hookCommand := range m.Hooks { platformHooks[hookName] = []PlatformCommand{{Command: "sh", Args: []string{"-c", hookCommand}}} expandHookArgs = false } } return &RuntimeConfigSubprocess{ PlatformCommand: platformCommand, PlatformHooks: platformHooks, ProtocolCommands: protocolCommands, expandHookArgs: expandHookArgs, } } func fromMetadataV1(mv1 MetadataV1) (*Metadata, error) { config, err := unmarshalConfig(mv1.Type, mv1.Config) if err != nil { return nil, err } runtimeConfig, err := convertMetadataRuntimeConfig(mv1.Runtime, mv1.RuntimeConfig) if err != nil { return nil, err } return &Metadata{ APIVersion: mv1.APIVersion, Name: mv1.Name, Type: mv1.Type, Runtime: mv1.Runtime, Version: mv1.Version, SourceURL: mv1.SourceURL, Config: config, RuntimeConfig: runtimeConfig, }, nil } func convertMetadataRuntimeConfig(runtimeType string, runtimeConfigRaw map[string]any) (RuntimeConfig, error) { var runtimeConfig RuntimeConfig var err error switch runtimeType { case "subprocess": runtimeConfig, err = remarshalRuntimeConfig[*RuntimeConfigSubprocess](runtimeConfigRaw) case "extism/v1": runtimeConfig, err = remarshalRuntimeConfig[*RuntimeConfigExtismV1](runtimeConfigRaw) default: return nil, fmt.Errorf("unsupported plugin runtime type: %q", runtimeType) } if err != nil { return nil, fmt.Errorf("failed to unmarshal runtimeConfig for %s runtime: %w", runtimeType, err) } return runtimeConfig, nil }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/plugin_test.go
internal/plugin/plugin_test.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package plugin import ( "testing" "helm.sh/helm/v4/internal/plugin/schema" ) func TestValidPluginName(t *testing.T) { validNames := map[string]string{ "lowercase": "myplugin", "uppercase": "MYPLUGIN", "mixed case": "MyPlugin", "with digits": "plugin123", "with hyphen": "my-plugin", "with underscore": "my_plugin", "mixed chars": "my-awesome_plugin_123", } for name, pluginName := range validNames { t.Run("valid/"+name, func(t *testing.T) { if !validPluginName.MatchString(pluginName) { t.Errorf("expected %q to match validPluginName regex", pluginName) } }) } invalidNames := map[string]string{ "empty": "", "space": "my plugin", "colon": "plugin:", "period": "my.plugin", "slash": "my/plugin", "dollar": "$plugin", "unicode": "plügîn", } for name, pluginName := range invalidNames { t.Run("invalid/"+name, func(t *testing.T) { if validPluginName.MatchString(pluginName) { t.Errorf("expected %q to not match validPluginName regex", pluginName) } }) } } func mockSubprocessCLIPlugin(t *testing.T, pluginName string) *SubprocessPluginRuntime { t.Helper() rc := RuntimeConfigSubprocess{ PlatformCommand: []PlatformCommand{ {OperatingSystem: "darwin", Architecture: "", Command: "sh", Args: []string{"-c", "echo \"mock plugin\""}}, {OperatingSystem: "linux", Architecture: "", Command: "sh", Args: []string{"-c", "echo \"mock plugin\""}}, {OperatingSystem: "windows", Architecture: "", Command: "pwsh", Args: []string{"-c", "echo \"mock plugin\""}}, }, PlatformHooks: map[string][]PlatformCommand{ Install: { {OperatingSystem: "darwin", Architecture: "", Command: "sh", Args: []string{"-c", "echo \"installing...\""}}, {OperatingSystem: "linux", Architecture: "", Command: "sh", Args: []string{"-c", "echo \"installing...\""}}, {OperatingSystem: "windows", Architecture: "", Command: "pwsh", Args: []string{"-c", "echo \"installing...\""}}, }, }, } pluginDir := t.TempDir() return &SubprocessPluginRuntime{ metadata: Metadata{ Name: pluginName, Version: "v0.1.2", Type: "cli/v1", APIVersion: "v1", Runtime: "subprocess", Config: &schema.ConfigCLIV1{ Usage: "Mock plugin", ShortHelp: "Mock plugin", LongHelp: "Mock plugin for testing", IgnoreFlags: false, }, RuntimeConfig: &rc, }, pluginDir: pluginDir, // NOTE: dir is empty (ie. plugin.yaml is not present) RuntimeConfig: rc, } }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/runtime_subprocess_test.go
internal/plugin/runtime_subprocess_test.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package plugin import ( "fmt" "os" "path/filepath" "testing" "github.com/stretchr/testify/assert" "github.com/stretchr/testify/require" "go.yaml.in/yaml/v3" "helm.sh/helm/v4/internal/plugin/schema" ) func mockSubprocessCLIPluginErrorExit(t *testing.T, pluginName string, exitCode uint8) *SubprocessPluginRuntime { t.Helper() rc := RuntimeConfigSubprocess{ PlatformCommand: []PlatformCommand{ {Command: "sh", Args: []string{"-c", fmt.Sprintf("echo \"mock plugin $@\"; exit %d", exitCode)}}, }, } pluginDir := t.TempDir() md := Metadata{ Name: pluginName, Version: "v0.1.2", Type: "cli/v1", APIVersion: "v1", Runtime: "subprocess", Config: &schema.ConfigCLIV1{ Usage: "Mock plugin", ShortHelp: "Mock plugin", LongHelp: "Mock plugin for testing", IgnoreFlags: false, }, RuntimeConfig: &rc, } data, err := yaml.Marshal(md) require.NoError(t, err) os.WriteFile(filepath.Join(pluginDir, "plugin.yaml"), data, 0o644) return &SubprocessPluginRuntime{ metadata: md, pluginDir: pluginDir, RuntimeConfig: rc, } } func TestSubprocessPluginRuntime(t *testing.T) { p := mockSubprocessCLIPluginErrorExit(t, "foo", 56) output, err := p.Invoke(t.Context(), &Input{ Message: schema.InputMessageCLIV1{ ExtraArgs: []string{"arg1", "arg2"}, // Env: []string{"FOO=bar"}, }, }) require.Error(t, err) ieerr, ok := err.(*InvokeExecError) require.True(t, ok, "expected InvokeExecError, got %T", err) assert.Equal(t, 56, ieerr.ExitCode) assert.Nil(t, output) }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/verify_test.go
internal/plugin/verify_test.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package plugin import ( "os" "path/filepath" "testing" "helm.sh/helm/v4/pkg/provenance" ) const testKeyFile = "../../pkg/cmd/testdata/helm-test-key.secret" const testPubFile = "../../pkg/cmd/testdata/helm-test-key.pub" const testPluginYAML = `apiVersion: v1 name: test-plugin type: cli/v1 runtime: subprocess version: 1.0.0 runtimeConfig: platformCommand: - command: echo` func TestVerifyPlugin(t *testing.T) { // Create a test plugin and sign it tempDir := t.TempDir() // Create plugin directory pluginDir := filepath.Join(tempDir, "verify-test-plugin") if err := os.MkdirAll(pluginDir, 0755); err != nil { t.Fatal(err) } if err := os.WriteFile(filepath.Join(pluginDir, "plugin.yaml"), []byte(testPluginYAML), 0644); err != nil { t.Fatal(err) } // Create tarball tarballPath := filepath.Join(tempDir, "verify-test-plugin.tar.gz") tarFile, err := os.Create(tarballPath) if err != nil { t.Fatal(err) } if err := CreatePluginTarball(pluginDir, "test-plugin", tarFile); err != nil { tarFile.Close() t.Fatal(err) } tarFile.Close() // Sign the plugin with source directory signer, err := provenance.NewFromKeyring(testKeyFile, "helm-test") if err != nil { t.Fatal(err) } if err := signer.DecryptKey(func(_ string) ([]byte, error) { return []byte(""), nil }); err != nil { t.Fatal(err) } // Read the tarball data tarballData, err := os.ReadFile(tarballPath) if err != nil { t.Fatal(err) } sig, err := SignPlugin(tarballData, filepath.Base(tarballPath), signer) if err != nil { t.Fatal(err) } // Write the signature to .prov file provFile := tarballPath + ".prov" if err := os.WriteFile(provFile, []byte(sig), 0644); err != nil { t.Fatal(err) } // Read the files for verification archiveData, err := os.ReadFile(tarballPath) if err != nil { t.Fatal(err) } provData, err := os.ReadFile(provFile) if err != nil { t.Fatal(err) } // Now verify the plugin verification, err := VerifyPlugin(archiveData, provData, filepath.Base(tarballPath), testPubFile) if err != nil { t.Fatalf("Failed to verify plugin: %v", err) } // Check verification results if verification.SignedBy == nil { t.Error("SignedBy is nil") } if verification.FileName != "verify-test-plugin.tar.gz" { t.Errorf("Expected filename 'verify-test-plugin.tar.gz', got %s", verification.FileName) } if verification.FileHash == "" { t.Error("FileHash is empty") } } func TestVerifyPluginBadSignature(t *testing.T) { tempDir := t.TempDir() // Create a plugin tarball pluginDir := filepath.Join(tempDir, "bad-plugin") if err := os.MkdirAll(pluginDir, 0755); err != nil { t.Fatal(err) } if err := os.WriteFile(filepath.Join(pluginDir, "plugin.yaml"), []byte(testPluginYAML), 0644); err != nil { t.Fatal(err) } tarballPath := filepath.Join(tempDir, "bad-plugin.tar.gz") tarFile, err := os.Create(tarballPath) if err != nil { t.Fatal(err) } if err := CreatePluginTarball(pluginDir, "test-plugin", tarFile); err != nil { tarFile.Close() t.Fatal(err) } tarFile.Close() // Create a bad signature (just some text) badSig := `-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 This is not a real signature -----BEGIN PGP SIGNATURE----- InvalidSignatureData -----END PGP SIGNATURE-----` provFile := tarballPath + ".prov" if err := os.WriteFile(provFile, []byte(badSig), 0644); err != nil { t.Fatal(err) } // Read the files archiveData, err := os.ReadFile(tarballPath) if err != nil { t.Fatal(err) } provData, err := os.ReadFile(provFile) if err != nil { t.Fatal(err) } // Try to verify - should fail _, err = VerifyPlugin(archiveData, provData, filepath.Base(tarballPath), testPubFile) if err == nil { t.Error("Expected verification to fail with bad signature") } } func TestVerifyPluginMissingProvenance(t *testing.T) { tempDir := t.TempDir() tarballPath := filepath.Join(tempDir, "no-prov.tar.gz") // Create a minimal tarball if err := os.WriteFile(tarballPath, []byte("dummy"), 0644); err != nil { t.Fatal(err) } // Read the tarball data archiveData, err := os.ReadFile(tarballPath) if err != nil { t.Fatal(err) } // Try to verify with empty provenance data _, err = VerifyPlugin(archiveData, nil, filepath.Base(tarballPath), testPubFile) if err == nil { t.Error("Expected verification to fail with empty provenance data") } } func TestVerifyPluginMalformedData(t *testing.T) { // Test with malformed tarball data - should fail malformedData := []byte("not a tarball") provData := []byte("fake provenance") _, err := VerifyPlugin(malformedData, provData, "malformed.tar.gz", testPubFile) if err == nil { t.Error("Expected malformed data verification to fail, but it succeeded") } }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/runtime_extismv1.go
internal/plugin/runtime_extismv1.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package plugin import ( "context" "encoding/json" "fmt" "log/slog" "os" "path/filepath" "reflect" extism "github.com/extism/go-sdk" "github.com/tetratelabs/wazero" ) const ExtismV1WasmBinaryFilename = "plugin.wasm" // RuntimeConfigExtismV1Memory exposes the Wasm/Extism memory options for the plugin type RuntimeConfigExtismV1Memory struct { // The max amount of pages the plugin can allocate // One page is 64Kib. e.g. 16 pages would require 1MiB. // Default is 4 pages (256KiB) MaxPages uint32 `yaml:"maxPages,omitempty"` // The max size of an Extism HTTP response in bytes // Default is 4096 bytes (4KiB) MaxHTTPResponseBytes int64 `yaml:"maxHttpResponseBytes,omitempty"` // The max size of all Extism vars in bytes // Default is 4096 bytes (4KiB) MaxVarBytes int64 `yaml:"maxVarBytes,omitempty"` } // RuntimeConfigExtismV1FileSystem exposes filesystem options for the configuration // TODO: should Helm expose AllowedPaths? type RuntimeConfigExtismV1FileSystem struct { // If specified, a temporary directory will be created and mapped to /tmp in the plugin's filesystem. // Data written to the directory will be visible on the host filesystem. // The directory will be removed when the plugin invocation completes. CreateTempDir bool `yaml:"createTempDir,omitempty"` } // RuntimeConfigExtismV1 defines the user-configurable options the plugin's Extism runtime // The format loosely follows the Extism Manifest format: https://extism.org/docs/concepts/manifest/ type RuntimeConfigExtismV1 struct { // Describes the limits on the memory the plugin may be allocated. Memory RuntimeConfigExtismV1Memory `yaml:"memory"` // The "config" key is a free-form map that can be passed to the plugin. // The plugin must interpret arbitrary data this map may contain Config map[string]string `yaml:"config,omitempty"` // An optional set of hosts this plugin can communicate with. // This only has an effect if the plugin makes HTTP requests. // If not specified, then no hosts are allowed. AllowedHosts []string `yaml:"allowedHosts,omitempty"` FileSystem RuntimeConfigExtismV1FileSystem `yaml:"fileSystem,omitempty"` // The timeout in milliseconds for the plugin to execute Timeout uint64 `yaml:"timeout,omitempty"` // HostFunction names exposed in Helm the plugin may access // see: https://extism.org/docs/concepts/host-functions/ HostFunctions []string `yaml:"hostFunctions,omitempty"` // The name of entry function name to call in the plugin // Defaults to "helm_plugin_main". EntryFuncName string `yaml:"entryFuncName,omitempty"` } var _ RuntimeConfig = (*RuntimeConfigExtismV1)(nil) func (r *RuntimeConfigExtismV1) Validate() error { // TODO return nil } type RuntimeExtismV1 struct { HostFunctions map[string]extism.HostFunction CompilationCache wazero.CompilationCache } var _ Runtime = (*RuntimeExtismV1)(nil) func (r *RuntimeExtismV1) CreatePlugin(pluginDir string, metadata *Metadata) (Plugin, error) { rc, ok := metadata.RuntimeConfig.(*RuntimeConfigExtismV1) if !ok { return nil, fmt.Errorf("invalid extism/v1 plugin runtime config type: %T", metadata.RuntimeConfig) } wasmFile := filepath.Join(pluginDir, ExtismV1WasmBinaryFilename) if _, err := os.Stat(wasmFile); err != nil { if os.IsNotExist(err) { return nil, fmt.Errorf("wasm binary missing for extism/v1 plugin: %q", wasmFile) } return nil, fmt.Errorf("failed to stat extism/v1 plugin wasm binary %q: %w", wasmFile, err) } return &ExtismV1PluginRuntime{ metadata: *metadata, dir: pluginDir, rc: rc, r: r, }, nil } type ExtismV1PluginRuntime struct { metadata Metadata dir string rc *RuntimeConfigExtismV1 r *RuntimeExtismV1 } var _ Plugin = (*ExtismV1PluginRuntime)(nil) func (p *ExtismV1PluginRuntime) Metadata() Metadata { return p.metadata } func (p *ExtismV1PluginRuntime) Dir() string { return p.dir } func (p *ExtismV1PluginRuntime) Invoke(ctx context.Context, input *Input) (*Output, error) { var tmpDir string if p.rc.FileSystem.CreateTempDir { tmpDirInner, err := os.MkdirTemp(os.TempDir(), "helm-plugin-*") slog.Debug("created plugin temp dir", slog.String("dir", tmpDirInner), slog.String("plugin", p.metadata.Name)) if err != nil { return nil, fmt.Errorf("failed to create temp dir for extism compilation cache: %w", err) } defer func() { if err := os.RemoveAll(tmpDir); err != nil { slog.Warn("failed to remove plugin temp dir", slog.String("dir", tmpDir), slog.String("plugin", p.metadata.Name), slog.String("error", err.Error())) } }() tmpDir = tmpDirInner } manifest, err := buildManifest(p.dir, tmpDir, p.rc) if err != nil { return nil, err } config := buildPluginConfig(input, p.r) hostFunctions, err := buildHostFunctions(p.r.HostFunctions, p.rc) if err != nil { return nil, err } pe, err := extism.NewPlugin(ctx, manifest, config, hostFunctions) if err != nil { return nil, fmt.Errorf("failed to create existing plugin: %w", err) } pe.SetLogger(func(logLevel extism.LogLevel, s string) { slog.Debug(s, slog.String("level", logLevel.String()), slog.String("plugin", p.metadata.Name)) }) inputData, err := json.Marshal(input.Message) if err != nil { return nil, fmt.Errorf("failed to json marshal plugin input message: %T: %w", input.Message, err) } slog.Debug("plugin input", slog.String("plugin", p.metadata.Name), slog.String("inputData", string(inputData))) entryFuncName := p.rc.EntryFuncName if entryFuncName == "" { entryFuncName = "helm_plugin_main" } exitCode, outputData, err := pe.Call(entryFuncName, inputData) if err != nil { return nil, fmt.Errorf("plugin error: %w", err) } if exitCode != 0 { return nil, &InvokeExecError{ ExitCode: int(exitCode), } } slog.Debug("plugin output", slog.String("plugin", p.metadata.Name), slog.Int("exitCode", int(exitCode)), slog.String("outputData", string(outputData))) outputMessage := reflect.New(pluginTypesIndex[p.metadata.Type].outputType) if err := json.Unmarshal(outputData, outputMessage.Interface()); err != nil { return nil, fmt.Errorf("failed to json marshal plugin output message: %T: %w", outputMessage, err) } output := &Output{ Message: outputMessage.Elem().Interface(), } return output, nil } func buildManifest(pluginDir string, tmpDir string, rc *RuntimeConfigExtismV1) (extism.Manifest, error) { wasmFile := filepath.Join(pluginDir, ExtismV1WasmBinaryFilename) allowedHosts := rc.AllowedHosts if allowedHosts == nil { allowedHosts = []string{} } allowedPaths := map[string]string{} if tmpDir != "" { allowedPaths[tmpDir] = "/tmp" } return extism.Manifest{ Wasm: []extism.Wasm{ extism.WasmFile{ Path: wasmFile, Name: wasmFile, }, }, Memory: &extism.ManifestMemory{ MaxPages: rc.Memory.MaxPages, MaxHttpResponseBytes: rc.Memory.MaxHTTPResponseBytes, MaxVarBytes: rc.Memory.MaxVarBytes, }, Config: rc.Config, AllowedHosts: allowedHosts, AllowedPaths: allowedPaths, Timeout: rc.Timeout, }, nil } func buildPluginConfig(input *Input, r *RuntimeExtismV1) extism.PluginConfig { mc := wazero.NewModuleConfig(). WithSysWalltime() if input.Stdin != nil { mc = mc.WithStdin(input.Stdin) } if input.Stdout != nil { mc = mc.WithStdout(input.Stdout) } if input.Stderr != nil { mc = mc.WithStderr(input.Stderr) } if len(input.Env) > 0 { env := parseEnv(input.Env) for k, v := range env { mc = mc.WithEnv(k, v) } } config := extism.PluginConfig{ ModuleConfig: mc, RuntimeConfig: wazero.NewRuntimeConfigCompiler(). WithCloseOnContextDone(true). WithCompilationCache(r.CompilationCache), EnableWasi: true, EnableHttpResponseHeaders: true, } return config } func buildHostFunctions(hostFunctions map[string]extism.HostFunction, rc *RuntimeConfigExtismV1) ([]extism.HostFunction, error) { result := make([]extism.HostFunction, len(rc.HostFunctions)) for _, fnName := range rc.HostFunctions { fn, ok := hostFunctions[fnName] if !ok { return nil, fmt.Errorf("plugin requested host function %q not found", fnName) } result = append(result, fn) } return result, nil }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/config_test.go
internal/plugin/config_test.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package plugin import ( "testing" "github.com/stretchr/testify/assert" "github.com/stretchr/testify/require" "helm.sh/helm/v4/internal/plugin/schema" ) func TestUnmarshaConfig(t *testing.T) { // Test unmarshalling a CLI plugin config { config, err := unmarshalConfig("cli/v1", map[string]any{ "usage": "usage string", "shortHelp": "short help string", "longHelp": "long help string", "ignoreFlags": true, }) require.NoError(t, err) require.IsType(t, &schema.ConfigCLIV1{}, config) assert.Equal(t, schema.ConfigCLIV1{ Usage: "usage string", ShortHelp: "short help string", LongHelp: "long help string", IgnoreFlags: true, }, *(config.(*schema.ConfigCLIV1))) } // Test unmarshalling invalid config data { config, err := unmarshalConfig("cli/v1", map[string]any{ "invalid field": "foo", }) require.Error(t, err) assert.Contains(t, err.Error(), "field not found") assert.Nil(t, config) } }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/metadata_test.go
internal/plugin/metadata_test.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package plugin import ( "strings" "testing" ) func TestValidatePluginData(t *testing.T) { // A mock plugin with no commands mockNoCommand := mockSubprocessCLIPlugin(t, "foo") mockNoCommand.metadata.RuntimeConfig = &RuntimeConfigSubprocess{ PlatformCommand: []PlatformCommand{}, PlatformHooks: map[string][]PlatformCommand{}, } // A mock plugin with legacy commands mockLegacyCommand := mockSubprocessCLIPlugin(t, "foo") mockLegacyCommand.metadata.RuntimeConfig = &RuntimeConfigSubprocess{ PlatformCommand: []PlatformCommand{ { Command: "echo \"mock plugin\"", }, }, PlatformHooks: map[string][]PlatformCommand{ Install: { PlatformCommand{ Command: "echo installing...", }, }, }, } for i, item := range []struct { pass bool plug Plugin errString string }{ {true, mockSubprocessCLIPlugin(t, "abcdefghijklmnopqrstuvwxyz0123456789_-ABC"), ""}, {true, mockSubprocessCLIPlugin(t, "foo-bar-FOO-BAR_1234"), ""}, {false, mockSubprocessCLIPlugin(t, "foo -bar"), "invalid plugin name"}, {false, mockSubprocessCLIPlugin(t, "$foo -bar"), "invalid plugin name"}, // Test leading chars {false, mockSubprocessCLIPlugin(t, "foo -bar "), "invalid plugin name"}, // Test trailing chars {false, mockSubprocessCLIPlugin(t, "foo\nbar"), "invalid plugin name"}, // Test newline {true, mockNoCommand, ""}, // Test no command metadata works {true, mockLegacyCommand, ""}, // Test legacy command metadata works } { err := item.plug.Metadata().Validate() if item.pass && err != nil { t.Errorf("failed to validate case %d: %s", i, err) } else if !item.pass && err == nil { t.Errorf("expected case %d to fail", i) } if !item.pass && !strings.Contains(err.Error(), item.errString) { t.Errorf("index [%d]: expected error to contain: %s, but got: %s", i, item.errString, err.Error()) } } } func TestMetadataValidateMultipleErrors(t *testing.T) { // Create metadata with multiple validation issues metadata := Metadata{ Name: "invalid name with spaces", // Invalid name APIVersion: "", // Empty API version Type: "", // Empty type Runtime: "", // Empty runtime Config: nil, // Missing config RuntimeConfig: nil, // Missing runtime config } err := metadata.Validate() if err == nil { t.Fatal("expected validation to fail with multiple errors") } errStr := err.Error() // Check that all expected errors are present in the joined error expectedErrors := []string{ "invalid plugin name", "empty APIVersion", "empty type field", "empty runtime field", "missing config field", "missing runtimeConfig field", } for _, expectedErr := range expectedErrors { if !strings.Contains(errStr, expectedErr) { t.Errorf("expected error to contain %q, but got: %v", expectedErr, errStr) } } // Verify that the error contains the correct number of error messages errorCount := 0 for _, expectedErr := range expectedErrors { if strings.Contains(errStr, expectedErr) { errorCount++ } } if errorCount < len(expectedErrors) { t.Errorf("expected %d errors, but only found %d in: %v", len(expectedErrors), errorCount, errStr) } }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/runtime_subprocess_getter.go
internal/plugin/runtime_subprocess_getter.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package plugin import ( "bytes" "fmt" "log/slog" "maps" "os" "os/exec" "path/filepath" "slices" "helm.sh/helm/v4/internal/plugin/schema" ) func getProtocolCommand(commands []SubprocessProtocolCommand, protocol string) *SubprocessProtocolCommand { for _, c := range commands { if slices.Contains(c.Protocols, protocol) { return &c } } return nil } // TODO can we replace a lot of this func with RuntimeSubprocess.invokeWithEnv? func (r *SubprocessPluginRuntime) runGetter(input *Input) (*Output, error) { msg, ok := (input.Message).(schema.InputMessageGetterV1) if !ok { return nil, fmt.Errorf("expected input type schema.InputMessageGetterV1, got %T", input) } tmpDir, err := os.MkdirTemp(os.TempDir(), fmt.Sprintf("helm-plugin-%s-", r.metadata.Name)) if err != nil { return nil, fmt.Errorf("failed to create temporary directory: %w", err) } defer os.RemoveAll(tmpDir) d := getProtocolCommand(r.RuntimeConfig.ProtocolCommands, msg.Protocol) if d == nil { return nil, fmt.Errorf("no downloader found for protocol %q", msg.Protocol) } env := parseEnv(os.Environ()) maps.Insert(env, maps.All(r.EnvVars)) maps.Insert(env, maps.All(parseEnv(input.Env))) env["HELM_PLUGIN_NAME"] = r.metadata.Name env["HELM_PLUGIN_DIR"] = r.pluginDir env["HELM_PLUGIN_USERNAME"] = msg.Options.Username env["HELM_PLUGIN_PASSWORD"] = msg.Options.Password env["HELM_PLUGIN_PASS_CREDENTIALS_ALL"] = fmt.Sprintf("%t", msg.Options.PassCredentialsAll) command, args, err := PrepareCommands(d.PlatformCommand, false, []string{}, env) if err != nil { return nil, fmt.Errorf("failed to prepare commands for protocol %q: %w", msg.Protocol, err) } args = append( args, msg.Options.CertFile, msg.Options.KeyFile, msg.Options.CAFile, msg.Href) buf := bytes.Buffer{} // subprocess getters are expected to write content to stdout pluginCommand := filepath.Join(r.pluginDir, command) cmd := exec.Command( pluginCommand, args...) cmd.Env = formatEnv(env) cmd.Stdout = &buf cmd.Stderr = os.Stderr slog.Debug("executing plugin command", slog.String("pluginName", r.metadata.Name), slog.String("command", cmd.String())) if err := executeCmd(cmd, r.metadata.Name); err != nil { return nil, err } return &Output{ Message: schema.OutputMessageGetterV1{ Data: buf.Bytes(), }, }, nil }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/metadata_legacy_test.go
internal/plugin/metadata_legacy_test.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package plugin import ( "testing" "github.com/stretchr/testify/assert" ) func TestMetadataLegacyValidate(t *testing.T) { testsValid := map[string]MetadataLegacy{ "valid metadata": { Name: "myplugin", }, "valid with command": { Name: "myplugin", Command: "echo hello", }, "valid with platformCommand": { Name: "myplugin", PlatformCommand: []PlatformCommand{ {OperatingSystem: "linux", Architecture: "amd64", Command: "echo hello"}, }, }, "valid with hooks": { Name: "myplugin", Hooks: Hooks{ "install": "echo install", }, }, "valid with platformHooks": { Name: "myplugin", PlatformHooks: PlatformHooks{ "install": []PlatformCommand{ {OperatingSystem: "linux", Architecture: "amd64", Command: "echo install"}, }, }, }, "valid with downloaders": { Name: "myplugin", Downloaders: []Downloaders{ { Protocols: []string{"myproto"}, Command: "echo download", }, }, }, } for testName, metadata := range testsValid { t.Run(testName, func(t *testing.T) { assert.NoError(t, metadata.Validate()) }) } testsInvalid := map[string]MetadataLegacy{ "invalid name": { Name: "my plugin", // further tested in TestValidPluginName }, "both command and platformCommand": { Name: "myplugin", Command: "echo hello", PlatformCommand: []PlatformCommand{ {OperatingSystem: "linux", Architecture: "amd64", Command: "echo hello"}, }, }, "both hooks and platformHooks": { Name: "myplugin", Hooks: Hooks{ "install": "echo install", }, PlatformHooks: PlatformHooks{ "install": []PlatformCommand{ {OperatingSystem: "linux", Architecture: "amd64", Command: "echo install"}, }, }, }, "downloader with empty command": { Name: "myplugin", Downloaders: []Downloaders{ { Protocols: []string{"myproto"}, Command: "", }, }, }, "downloader with no protocols": { Name: "myplugin", Downloaders: []Downloaders{ { Protocols: []string{}, Command: "echo download", }, }, }, "downloader with empty protocol": { Name: "myplugin", Downloaders: []Downloaders{ { Protocols: []string{""}, Command: "echo download", }, }, }, } for testName, metadata := range testsInvalid { t.Run(testName, func(t *testing.T) { assert.Error(t, metadata.Validate()) }) } }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/sign_test.go
internal/plugin/sign_test.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package plugin import ( "os" "path/filepath" "strings" "testing" "helm.sh/helm/v4/pkg/provenance" ) func TestSignPlugin(t *testing.T) { // Create a test plugin directory tempDir := t.TempDir() pluginDir := filepath.Join(tempDir, "test-plugin") if err := os.MkdirAll(pluginDir, 0755); err != nil { t.Fatal(err) } // Create a plugin.yaml file pluginYAML := `apiVersion: v1 name: test-plugin type: cli/v1 runtime: subprocess version: 1.0.0 runtimeConfig: platformCommand: - command: echo` if err := os.WriteFile(filepath.Join(pluginDir, "plugin.yaml"), []byte(pluginYAML), 0644); err != nil { t.Fatal(err) } // Create a tarball tarballPath := filepath.Join(tempDir, "test-plugin.tgz") tarFile, err := os.Create(tarballPath) if err != nil { t.Fatal(err) } if err := CreatePluginTarball(pluginDir, "test-plugin", tarFile); err != nil { tarFile.Close() t.Fatal(err) } tarFile.Close() // Create a test key for signing keyring := "../../pkg/cmd/testdata/helm-test-key.secret" signer, err := provenance.NewFromKeyring(keyring, "helm-test") if err != nil { t.Fatal(err) } if err := signer.DecryptKey(func(_ string) ([]byte, error) { return []byte(""), nil }); err != nil { t.Fatal(err) } // Read the tarball data tarballData, err := os.ReadFile(tarballPath) if err != nil { t.Fatalf("failed to read tarball: %v", err) } // Sign the plugin tarball sig, err := SignPlugin(tarballData, filepath.Base(tarballPath), signer) if err != nil { t.Fatalf("failed to sign plugin: %v", err) } // Verify the signature contains the expected content if !strings.Contains(sig, "-----BEGIN PGP SIGNED MESSAGE-----") { t.Error("signature does not contain PGP header") } // Verify the tarball hash is in the signature expectedHash, err := provenance.DigestFile(tarballPath) if err != nil { t.Fatal(err) } // The signature should contain the tarball hash if !strings.Contains(sig, "sha256:"+expectedHash) { t.Errorf("signature does not contain expected tarball hash: sha256:%s", expectedHash) } }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/runtime.go
internal/plugin/runtime.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package plugin import ( "fmt" "strings" "go.yaml.in/yaml/v3" ) // Runtime represents a plugin runtime (subprocess, extism, etc) ie. how a plugin should be executed // Runtime is responsible for instantiating plugins that implement the runtime // TODO: could call this something more like "PluginRuntimeCreator"? type Runtime interface { // CreatePlugin creates a plugin instance from the given metadata CreatePlugin(pluginDir string, metadata *Metadata) (Plugin, error) // TODO: move config unmarshalling to the runtime? // UnmarshalConfig(runtimeConfigRaw map[string]any) (RuntimeConfig, error) } // RuntimeConfig represents the assertable type for a plugin's runtime configuration. // It is expected to type assert (cast) the a RuntimeConfig to its expected type type RuntimeConfig interface { Validate() error } func remarshalRuntimeConfig[T RuntimeConfig](runtimeData map[string]any) (RuntimeConfig, error) { data, err := yaml.Marshal(runtimeData) if err != nil { return nil, err } var config T if err := yaml.Unmarshal(data, &config); err != nil { return nil, err } return config, nil } // parseEnv takes a list of "KEY=value" environment variable strings // and transforms the result into a map[KEY]=value // // - empty input strings are ignored // - input strings with no value are stored as empty strings // - duplicate keys overwrite earlier values func parseEnv(env []string) map[string]string { result := make(map[string]string, len(env)) for _, envVar := range env { parts := strings.SplitN(envVar, "=", 2) if len(parts) > 0 && parts[0] != "" { key := parts[0] var value string if len(parts) > 1 { value = parts[1] } result[key] = value } } return result } func formatEnv(env map[string]string) []string { result := make([]string, 0, len(env)) for key, value := range env { result = append(result, fmt.Sprintf("%s=%s", key, value)) } return result }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/signing_info.go
internal/plugin/signing_info.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package plugin import ( "crypto/sha256" "fmt" "io" "os" "path/filepath" "strings" "github.com/ProtonMail/go-crypto/openpgp/clearsign" //nolint "helm.sh/helm/v4/pkg/helmpath" ) // SigningInfo contains information about a plugin's signing status type SigningInfo struct { // Status can be: // - "local dev": Plugin is a symlink (development mode) // - "unsigned": No provenance file found // - "invalid provenance": Provenance file is malformed // - "mismatched provenance": Provenance file does not match the installed tarball // - "signed": Valid signature exists for the installed tarball Status string IsSigned bool // True if plugin has a valid signature (even if not verified against keyring) } // GetPluginSigningInfo returns signing information for an installed plugin func GetPluginSigningInfo(metadata Metadata) (*SigningInfo, error) { pluginName := metadata.Name pluginDir := helmpath.DataPath("plugins", pluginName) // Check if plugin directory exists fi, err := os.Lstat(pluginDir) if err != nil { return nil, fmt.Errorf("plugin %s not found: %w", pluginName, err) } // Check if it's a symlink (local development) if fi.Mode()&os.ModeSymlink != 0 { return &SigningInfo{ Status: "local dev", IsSigned: false, }, nil } // Find the exact tarball file for this plugin pluginsDir := helmpath.DataPath("plugins") tarballPath := filepath.Join(pluginsDir, fmt.Sprintf("%s-%s.tgz", metadata.Name, metadata.Version)) if _, err := os.Stat(tarballPath); err != nil { return &SigningInfo{ Status: "unsigned", IsSigned: false, }, nil } // Check for .prov file associated with the tarball provFile := tarballPath + ".prov" provData, err := os.ReadFile(provFile) if err != nil { if os.IsNotExist(err) { return &SigningInfo{ Status: "unsigned", IsSigned: false, }, nil } return nil, fmt.Errorf("failed to read provenance file: %w", err) } // Parse the provenance file to check validity block, _ := clearsign.Decode(provData) if block == nil { return &SigningInfo{ Status: "invalid provenance", IsSigned: false, }, nil } // Check if provenance matches the actual tarball blockContent := string(block.Plaintext) if !validateProvenanceHash(blockContent, tarballPath) { return &SigningInfo{ Status: "mismatched provenance", IsSigned: false, }, nil } // We have a provenance file that is valid for this plugin // Without a keyring, we can't verify the signature, but we know: // 1. A .prov file exists // 2. It's a valid clearsigned document (cryptographically signed) // 3. The provenance contains valid checksums return &SigningInfo{ Status: "signed", IsSigned: true, }, nil } func validateProvenanceHash(blockContent string, tarballPath string) bool { // Parse provenance to get the expected hash _, sums, err := parsePluginMessageBlock([]byte(blockContent)) if err != nil { return false } // Must have file checksums if len(sums.Files) == 0 { return false } // Calculate actual hash of the tarball actualHash, err := calculateFileHash(tarballPath) if err != nil { return false } // Check if the actual hash matches the expected hash in the provenance for filename, expectedHash := range sums.Files { if strings.Contains(filename, filepath.Base(tarballPath)) && expectedHash == actualHash { return true } } return false } // calculateFileHash calculates the SHA256 hash of a file func calculateFileHash(filePath string) (string, error) { file, err := os.Open(filePath) if err != nil { return "", err } defer file.Close() hasher := sha256.New() if _, err := io.Copy(hasher, file); err != nil { return "", err } return fmt.Sprintf("sha256:%x", hasher.Sum(nil)), nil } // GetSigningInfoForPlugins returns signing info for multiple plugins func GetSigningInfoForPlugins(plugins []Plugin) map[string]*SigningInfo { result := make(map[string]*SigningInfo) for _, p := range plugins { m := p.Metadata() info, err := GetPluginSigningInfo(m) if err != nil { // If there's an error, treat as unsigned result[m.Name] = &SigningInfo{ Status: "unknown", IsSigned: false, } } else { result[m.Name] = info } } return result }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/doc.go
internal/plugin/doc.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ /* --- TODO: move this section to public plugin package Package plugin provides the implementation of the Helm plugin system. Conceptually, "plugins" enable extending Helm's functionality external to Helm's core codebase. The plugin system allows code to fetch plugins by type, then invoke the plugin with an input as required by that plugin type. The plugin returning an output for the caller to consume. An example of a plugin invocation: ``` d := plugin.Descriptor{ Type: "example/v1", // } plgs, err := plugin.FindPlugins([]string{settings.PluginsDirectory}, d) for _, plg := range plgs { input := &plugin.Input{ Message: schema.InputMessageExampleV1{ // The type of the input message is defined by the plugin's "type" (example/v1 here) ... }, } output, err := plg.Invoke(context.Background(), input) if err != nil { ... } // consume the output, using type assertion to convert to the expected output type (as defined by the plugin's "type") outputMessage, ok := output.Message.(schema.OutputMessageExampleV1) } --- Package `plugin` provides the implementation of the Helm plugin system. Helm plugins are exposed to uses as the "Plugin" type, the basic interface that primarily support the "Invoke" method. # Plugin Runtimes Internally, plugins must be implemented by a "runtime" that is responsible for creating the plugin instance, and dispatching the plugin's invocation to the plugin's implementation. For example: - forming environment variables and command line args for subprocess execution - converting input to JSON and invoking a function in a Wasm runtime Internally, the code structure is: Runtime.CreatePlugin() | | (creates) | \---> PluginRuntime | | (implements) v Plugin.Invoke() # Plugin Types Each plugin implements a specific functionality, denoted by the plugin's "type" e.g. "getter/v1". The "type" includes a version, in order to allow a given types messaging schema and invocation options to evolve. Specifically, the plugin's "type" specifies the contract for the input and output messages that are expected to be passed to the plugin, and returned from the plugin. The plugin's "type" also defines the options that can be passed to the plugin when invoking it. # Metadata Each plugin must have a `plugin.yaml`, that defines the plugin's metadata. The metadata includes the plugin's name, version, and other information. For legacy plugins, the type is inferred by which fields are set on the plugin: a downloader plugin is inferred when metadata contains a "downloaders" yaml node, otherwise it is assumed to define a Helm CLI subcommand. For v1 plugins, the metadata includes explicit apiVersion and type fields. It will also contain type-specific Config, and RuntimeConfig fields. # Runtime and type cardinality From a cardinality perspective, this means there a "few" runtimes, and "many" plugins types. It is also expected that the subprocess runtime will not be extended to support extra plugin types, and deprecated in a future version of Helm. Future ideas that are intended to be implemented include extending the plugin system to support future Wasm standards. Or allowing Helm SDK user's to inject "plugins" that are actually implemented as native go modules. Or even moving Helm's internal functionality e.g. yaml rendering engine to be used as an "in-built" plugin, along side other plugins that may implement other (non-go template) rendering engines. */ package plugin
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/runtime_extismv1_test.go
internal/plugin/runtime_extismv1_test.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package plugin import ( "os" "os/exec" "path/filepath" "testing" extism "github.com/extism/go-sdk" "helm.sh/helm/v4/internal/plugin/schema" "github.com/stretchr/testify/assert" "github.com/stretchr/testify/require" ) type pluginRaw struct { Metadata Metadata Dir string } func buildLoadExtismPlugin(t *testing.T, dir string) pluginRaw { t.Helper() pluginFile := filepath.Join(dir, PluginFileName) metadataData, err := os.ReadFile(pluginFile) require.NoError(t, err) m, err := loadMetadata(metadataData) require.NoError(t, err) require.Equal(t, "extism/v1", m.Runtime, "expected plugin runtime to be extism/v1") cmd := exec.Command("make", "-C", dir) cmd.Stdout = os.Stdout cmd.Stderr = os.Stderr require.NoError(t, cmd.Run(), "failed to build plugin in %q", dir) return pluginRaw{ Metadata: *m, Dir: dir, } } func TestRuntimeConfigExtismV1Validate(t *testing.T) { rc := RuntimeConfigExtismV1{} err := rc.Validate() assert.NoError(t, err, "expected no error for empty RuntimeConfigExtismV1") } func TestRuntimeExtismV1InvokePlugin(t *testing.T) { r := RuntimeExtismV1{} pr := buildLoadExtismPlugin(t, "testdata/src/extismv1-test") require.Equal(t, "test/v1", pr.Metadata.Type) p, err := r.CreatePlugin(pr.Dir, &pr.Metadata) assert.NoError(t, err, "expected no error creating plugin") assert.NotNil(t, p, "expected plugin to be created") output, err := p.Invoke(t.Context(), &Input{ Message: schema.InputMessageTestV1{ Name: "Phippy", }, }) require.Nil(t, err) msg := output.Message.(schema.OutputMessageTestV1) assert.Equal(t, "Hello, Phippy! (6)", msg.Greeting) } func TestBuildManifest(t *testing.T) { rc := &RuntimeConfigExtismV1{ Memory: RuntimeConfigExtismV1Memory{ MaxPages: 8, MaxHTTPResponseBytes: 81920, MaxVarBytes: 8192, }, FileSystem: RuntimeConfigExtismV1FileSystem{ CreateTempDir: true, }, Config: map[string]string{"CONFIG_KEY": "config_value"}, AllowedHosts: []string{"example.com", "api.example.com"}, Timeout: 5000, } expected := extism.Manifest{ Wasm: []extism.Wasm{ extism.WasmFile{ Path: "/path/to/plugin/plugin.wasm", Name: "/path/to/plugin/plugin.wasm", }, }, Memory: &extism.ManifestMemory{ MaxPages: 8, MaxHttpResponseBytes: 81920, MaxVarBytes: 8192, }, Config: map[string]string{"CONFIG_KEY": "config_value"}, AllowedHosts: []string{"example.com", "api.example.com"}, AllowedPaths: map[string]string{"/tmp/foo": "/tmp"}, Timeout: 5000, } manifest, err := buildManifest("/path/to/plugin", "/tmp/foo", rc) require.NoError(t, err) assert.Equal(t, expected, manifest) }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/plugin.go
internal/plugin/plugin.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package plugin // import "helm.sh/helm/v4/internal/plugin" import ( "context" "io" "regexp" ) const PluginFileName = "plugin.yaml" // Plugin defines a plugin instance. The client (Helm codebase) facing type that can be used to introspect and invoke a plugin type Plugin interface { // Dir return the plugin directory (as an absolute path) on the filesystem Dir() string // Metadata describes the plugin's type, version, etc. // (This metadata type is the converted and plugin version independented in-memory representation of the plugin.yaml file) Metadata() Metadata // Invoke takes the given input, and dispatches the contents to plugin instance // The input is expected to be a JSON-serializable object, which the plugin will interpret according to its type // The plugin is expected to return a JSON-serializable object, which the invoker // will interpret according to the plugin's type // // Invoke can be thought of as a request/response mechanism. Similar to e.g. http.RoundTripper // // If plugin's execution fails with a non-zero "return code" (this is plugin runtime implementation specific) // an InvokeExecError is returned Invoke(ctx context.Context, input *Input) (*Output, error) } // PluginHook allows plugins to implement hooks that are invoked on plugin management events (install, upgrade, etc) type PluginHook interface { //nolint:revive InvokeHook(event string) error } // Input defines the input message and parameters to be passed to the plugin type Input struct { // Message represents the type-elided value to be passed to the plugin. // The plugin is expected to interpret the message according to its type // The message object must be JSON-serializable Message any // Optional: Reader to be consumed plugin's "stdin" Stdin io.Reader // Optional: Writers to consume the plugin's "stdout" and "stderr" Stdout, Stderr io.Writer // Optional: Env represents the environment as a list of "key=value" strings // see os.Environ Env []string } // Output defines the output message and parameters the passed from the plugin type Output struct { // Message represents the type-elided value returned from the plugin // The invoker is expected to interpret the message according to the plugin's type // The message object must be JSON-serializable Message any } // validPluginName is a regular expression that validates plugin names. // // Plugin names can only contain the ASCII characters a-z, A-Z, 0-9, ​_​ and ​-. var validPluginName = regexp.MustCompile("^[A-Za-z0-9_-]+$")
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/loader_test.go
internal/plugin/loader_test.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package plugin import ( "bytes" "fmt" "testing" "github.com/stretchr/testify/assert" "github.com/stretchr/testify/require" "helm.sh/helm/v4/internal/plugin/schema" ) func TestPeekAPIVersion(t *testing.T) { testCases := map[string]struct { data []byte expected string }{ "v1": { data: []byte(`--- apiVersion: v1 name: "test-plugin" `), expected: "v1", }, "legacy": { // No apiVersion field data: []byte(`--- name: "test-plugin" `), expected: "", }, } for name, tc := range testCases { t.Run(name, func(t *testing.T) { version, err := peekAPIVersion(bytes.NewReader(tc.data)) require.NoError(t, err) assert.Equal(t, tc.expected, version) }) } // invalid yaml { data := []byte(`bad yaml`) _, err := peekAPIVersion(bytes.NewReader(data)) assert.Error(t, err) } } func TestLoadDir(t *testing.T) { makeMetadata := func(apiVersion string) Metadata { usage := "hello [params]..." if apiVersion == "legacy" { usage = "" // Legacy plugins don't have Usage field for command syntax } return Metadata{ APIVersion: apiVersion, Name: fmt.Sprintf("hello-%s", apiVersion), Version: "0.1.0", Type: "cli/v1", Runtime: "subprocess", Config: &schema.ConfigCLIV1{ Usage: usage, ShortHelp: "echo hello message", LongHelp: "description", IgnoreFlags: true, }, RuntimeConfig: &RuntimeConfigSubprocess{ PlatformCommand: []PlatformCommand{ {OperatingSystem: "linux", Architecture: "", Command: "sh", Args: []string{"-c", "${HELM_PLUGIN_DIR}/hello.sh"}}, {OperatingSystem: "windows", Architecture: "", Command: "pwsh", Args: []string{"-c", "${HELM_PLUGIN_DIR}/hello.ps1"}}, }, PlatformHooks: map[string][]PlatformCommand{ Install: { {OperatingSystem: "linux", Architecture: "", Command: "sh", Args: []string{"-c", "echo \"installing...\""}}, {OperatingSystem: "windows", Architecture: "", Command: "pwsh", Args: []string{"-c", "echo \"installing...\""}}, }, }, expandHookArgs: apiVersion == "legacy", }, } } testCases := map[string]struct { dirname string apiVersion string expect Metadata }{ "legacy": { dirname: "testdata/plugdir/good/hello-legacy", apiVersion: "legacy", expect: makeMetadata("legacy"), }, "v1": { dirname: "testdata/plugdir/good/hello-v1", apiVersion: "v1", expect: makeMetadata("v1"), }, } for name, tc := range testCases { t.Run(name, func(t *testing.T) { plug, err := LoadDir(tc.dirname) require.NoError(t, err, "error loading plugin from %s", tc.dirname) assert.Equal(t, tc.dirname, plug.Dir()) assert.EqualValues(t, tc.expect, plug.Metadata()) }) } } func TestLoadDirDuplicateEntries(t *testing.T) { testCases := map[string]string{ "legacy": "testdata/plugdir/bad/duplicate-entries-legacy", "v1": "testdata/plugdir/bad/duplicate-entries-v1", } for name, dirname := range testCases { t.Run(name, func(t *testing.T) { _, err := LoadDir(dirname) assert.Error(t, err) }) } } func TestLoadDirGetter(t *testing.T) { dirname := "testdata/plugdir/good/getter" expect := Metadata{ Name: "getter", Version: "1.2.3", Type: "getter/v1", APIVersion: "v1", Runtime: "subprocess", Config: &schema.ConfigGetterV1{ Protocols: []string{"myprotocol", "myprotocols"}, }, RuntimeConfig: &RuntimeConfigSubprocess{ ProtocolCommands: []SubprocessProtocolCommand{ { Protocols: []string{"myprotocol", "myprotocols"}, PlatformCommand: []PlatformCommand{{Command: "echo getter"}}, }, }, }, } plug, err := LoadDir(dirname) require.NoError(t, err) assert.Equal(t, dirname, plug.Dir()) assert.Equal(t, expect, plug.Metadata()) } func TestPostRenderer(t *testing.T) { dirname := "testdata/plugdir/good/postrenderer-v1" expect := Metadata{ Name: "postrenderer-v1", Version: "1.2.3", Type: "postrenderer/v1", APIVersion: "v1", Runtime: "subprocess", Config: &schema.ConfigPostRendererV1{}, RuntimeConfig: &RuntimeConfigSubprocess{ PlatformCommand: []PlatformCommand{ { Command: "${HELM_PLUGIN_DIR}/sed-test.sh", }, }, }, } plug, err := LoadDir(dirname) require.NoError(t, err) assert.Equal(t, dirname, plug.Dir()) assert.Equal(t, expect, plug.Metadata()) } func TestDetectDuplicates(t *testing.T) { plugs := []Plugin{ mockSubprocessCLIPlugin(t, "foo"), mockSubprocessCLIPlugin(t, "bar"), } if err := detectDuplicates(plugs); err != nil { t.Error("no duplicates in the first set") } plugs = append(plugs, mockSubprocessCLIPlugin(t, "foo")) if err := detectDuplicates(plugs); err == nil { t.Error("duplicates in the second set") } } func TestLoadAll(t *testing.T) { // Verify that empty dir loads: { plugs, err := LoadAll("testdata") require.NoError(t, err) assert.Len(t, plugs, 0) } basedir := "testdata/plugdir/good" plugs, err := LoadAll(basedir) require.NoError(t, err) require.NotEmpty(t, plugs, "expected plugins to be loaded from %s", basedir) plugsMap := map[string]Plugin{} for _, p := range plugs { plugsMap[p.Metadata().Name] = p } assert.Len(t, plugsMap, 7) assert.Contains(t, plugsMap, "downloader") assert.Contains(t, plugsMap, "echo-legacy") assert.Contains(t, plugsMap, "echo-v1") assert.Contains(t, plugsMap, "getter") assert.Contains(t, plugsMap, "hello-legacy") assert.Contains(t, plugsMap, "hello-v1") assert.Contains(t, plugsMap, "postrenderer-v1") } func TestFindPlugins(t *testing.T) { cases := []struct { name string plugdirs string expected int }{ { name: "plugdirs is empty", plugdirs: "", expected: 0, }, { name: "plugdirs isn't dir", plugdirs: "./plugin_test.go", expected: 0, }, { name: "plugdirs doesn't have plugin", plugdirs: ".", expected: 0, }, { name: "normal", plugdirs: "./testdata/plugdir/good", expected: 7, }, } for _, c := range cases { t.Run(t.Name(), func(t *testing.T) { plugin, err := LoadAll(c.plugdirs) require.NoError(t, err) assert.Len(t, plugin, c.expected, "expected %d plugins, got %d", c.expected, len(plugin)) }) } } func TestLoadMetadataLegacy(t *testing.T) { testCases := map[string]struct { yaml string expectError bool errorContains string expectedName string logNote string }{ "capital name field": { yaml: `Name: my-plugin version: 1.0.0 usage: test plugin description: test description command: echo test`, expectError: true, errorContains: `invalid plugin name "": must contain only a-z, A-Z, 0-9, _ and -`, // Legacy plugins: No strict unmarshalling (backwards compatibility) // YAML decoder silently ignores "Name:", then validation catches empty name logNote: "NOTE: V1 plugins use strict unmarshalling and would get: yaml: field Name not found", }, "correct name field": { yaml: `name: my-plugin version: 1.0.0 usage: test plugin description: test description command: echo test`, expectError: false, expectedName: "my-plugin", }, } for name, tc := range testCases { t.Run(name, func(t *testing.T) { m, err := loadMetadataLegacy([]byte(tc.yaml)) if tc.expectError { require.Error(t, err) assert.Contains(t, err.Error(), tc.errorContains) t.Logf("Legacy error (validation catches empty name): %v", err) if tc.logNote != "" { t.Log(tc.logNote) } } else { require.NoError(t, err) assert.Equal(t, tc.expectedName, m.Name) } }) } } func TestLoadMetadataV1(t *testing.T) { testCases := map[string]struct { yaml string expectError bool errorContains string expectedName string }{ "capital name field": { yaml: `apiVersion: v1 Name: my-plugin type: cli/v1 runtime: subprocess `, expectError: true, errorContains: "field Name not found in type plugin.MetadataV1", }, "correct name field": { yaml: `apiVersion: v1 name: my-plugin type: cli/v1 runtime: subprocess `, expectError: false, expectedName: "my-plugin", }, } for name, tc := range testCases { t.Run(name, func(t *testing.T) { m, err := loadMetadataV1([]byte(tc.yaml)) if tc.expectError { require.Error(t, err) assert.Contains(t, err.Error(), tc.errorContains) t.Logf("V1 error (strict unmarshalling): %v", err) } else { require.NoError(t, err) assert.Equal(t, tc.expectedName, m.Name) } }) } }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/cache/cache.go
internal/plugin/cache/cache.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ // Package cache provides a key generator for vcs urls. package cache // import "helm.sh/helm/v4/internal/plugin/cache" import ( "net/url" "regexp" "strings" ) // Thanks glide! // scpSyntaxRe matches the SCP-like addresses used to access repos over SSH. var scpSyntaxRe = regexp.MustCompile(`^([a-zA-Z0-9_]+)@([a-zA-Z0-9._-]+):(.*)$`) // Key generates a cache key based on a url or scp string. The key is file // system safe. func Key(repo string) (string, error) { var ( u *url.URL err error ) if m := scpSyntaxRe.FindStringSubmatch(repo); m != nil { // Match SCP-like syntax and convert it to a URL. // Eg, "git@github.com:user/repo" becomes // "ssh://git@github.com/user/repo". u = &url.URL{ User: url.User(m[1]), Host: m[2], Path: "/" + m[3], } } else { u, err = url.Parse(repo) if err != nil { return "", err } } var key strings.Builder if u.Scheme != "" { key.WriteString(u.Scheme) key.WriteString("-") } if u.User != nil && u.User.Username() != "" { key.WriteString(u.User.Username()) key.WriteString("-") } key.WriteString(u.Host) if u.Path != "" { key.WriteString(strings.ReplaceAll(u.Path, "/", "-")) } return strings.ReplaceAll(key.String(), ":", "-"), nil }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/testdata/src/extismv1-test/main.go
internal/plugin/testdata/src/extismv1-test/main.go
package main import ( _ "embed" "fmt" "os" pdk "github.com/extism/go-pdk" ) type InputMessageTestV1 struct { Name string } type OutputMessageTestV1 struct { Greeting string } type ConfigTestV1 struct{} func runGetterPluginImpl(input InputMessageTestV1) (*OutputMessageTestV1, error) { name := input.Name greeting := fmt.Sprintf("Hello, %s! (%d)", name, len(name)) err := os.WriteFile("/tmp/greeting.txt", []byte(greeting), 0o600) if err != nil { return nil, fmt.Errorf("failed to write temp file: %w", err) } return &OutputMessageTestV1{ Greeting: greeting, }, nil } func RunGetterPlugin() error { var input InputMessageTestV1 if err := pdk.InputJSON(&input); err != nil { return fmt.Errorf("failed to parse input json: %w", err) } pdk.Log(pdk.LogDebug, fmt.Sprintf("Received input: %+v", input)) output, err := runGetterPluginImpl(input) if err != nil { pdk.Log(pdk.LogError, fmt.Sprintf("failed: %s", err.Error())) return err } pdk.Log(pdk.LogDebug, fmt.Sprintf("Sending output: %+v", output)) if err := pdk.OutputJSON(output); err != nil { return fmt.Errorf("failed to write output json: %w", err) } return nil } //go:wasmexport helm_plugin_main func HelmPlugin() uint32 { pdk.Log(pdk.LogDebug, "running example-extism-getter plugin") if err := RunGetterPlugin(); err != nil { pdk.Log(pdk.LogError, err.Error()) pdk.SetError(err) return 1 } return 0 } func main() {}
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/schema/getter.go
internal/plugin/schema/getter.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package schema import ( "fmt" "time" ) // TODO: can we generate these plugin input/output messages? type GetterOptionsV1 struct { URL string CertFile string KeyFile string CAFile string UNTar bool InsecureSkipVerifyTLS bool PlainHTTP bool AcceptHeader string Username string Password string PassCredentialsAll bool UserAgent string Version string Timeout time.Duration } type InputMessageGetterV1 struct { Href string `json:"href"` Protocol string `json:"protocol"` Options GetterOptionsV1 `json:"options"` } type OutputMessageGetterV1 struct { Data []byte `json:"data"` } // ConfigGetterV1 represents the configuration for download plugins type ConfigGetterV1 struct { // Protocols are the list of URL schemes supported by this downloader Protocols []string `yaml:"protocols"` } func (c *ConfigGetterV1) Validate() error { if len(c.Protocols) == 0 { return fmt.Errorf("getter has no protocols") } for i, protocol := range c.Protocols { if protocol == "" { return fmt.Errorf("getter has empty protocol at index %d", i) } } return nil }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/schema/cli.go
internal/plugin/schema/cli.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package schema import ( "bytes" ) type InputMessageCLIV1 struct { ExtraArgs []string `json:"extraArgs"` } type OutputMessageCLIV1 struct { Data *bytes.Buffer `json:"data"` } // ConfigCLIV1 represents the configuration for CLI plugins type ConfigCLIV1 struct { // Usage is the single-line usage text shown in help // For recommended syntax, see [spf13/cobra.command.Command] Use field comment: // https://pkg.go.dev/github.com/spf13/cobra#Command Usage string `yaml:"usage"` // ShortHelp is the short description shown in the 'helm help' output ShortHelp string `yaml:"shortHelp"` // LongHelp is the long message shown in the 'helm help <this-command>' output LongHelp string `yaml:"longHelp"` // IgnoreFlags ignores any flags passed in from Helm IgnoreFlags bool `yaml:"ignoreFlags"` } func (c *ConfigCLIV1) Validate() error { // Config validation for CLI plugins return nil }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/schema/test.go
internal/plugin/schema/test.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package schema type InputMessageTestV1 struct { Name string } type OutputMessageTestV1 struct { Greeting string } type ConfigTestV1 struct{} func (c *ConfigTestV1) Validate() error { return nil }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/schema/doc.go
internal/plugin/schema/doc.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ /* */ package schema
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/schema/postrenderer.go
internal/plugin/schema/postrenderer.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package schema import ( "bytes" ) // InputMessagePostRendererV1 implements Input.Message type InputMessagePostRendererV1 struct { Manifests *bytes.Buffer `json:"manifests"` // from CLI --post-renderer-args ExtraArgs []string `json:"extraArgs"` } type OutputMessagePostRendererV1 struct { Manifests *bytes.Buffer `json:"manifests"` } type ConfigPostRendererV1 struct{} func (c *ConfigPostRendererV1) Validate() error { return nil }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/installer/base.go
internal/plugin/installer/base.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package installer // import "helm.sh/helm/v4/internal/plugin/installer" import ( "path/filepath" "helm.sh/helm/v4/pkg/cli" ) type base struct { // Source is the reference to a plugin Source string // PluginsDirectory is the directory where plugins are installed PluginsDirectory string } func newBase(source string) base { settings := cli.New() return base{ Source: source, PluginsDirectory: settings.PluginsDirectory, } } // Path is where the plugin will be installed. func (b *base) Path() string { if b.Source == "" { return "" } return filepath.Join(b.PluginsDirectory, filepath.Base(b.Source)) }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/installer/verification_test.go
internal/plugin/installer/verification_test.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package installer import ( "bytes" "crypto/sha256" "fmt" "io" "os" "path/filepath" "strings" "testing" "helm.sh/helm/v4/internal/plugin" "helm.sh/helm/v4/internal/test/ensure" ) func TestInstallWithOptions_VerifyMissingProvenance(t *testing.T) { ensure.HelmHome(t) // Create a temporary plugin tarball without .prov file pluginDir := createTestPluginDir(t) pluginTgz := createTarballFromPluginDir(t, pluginDir) defer os.Remove(pluginTgz) // Create local installer installer, err := NewLocalInstaller(pluginTgz) if err != nil { t.Fatalf("Failed to create installer: %v", err) } defer os.RemoveAll(installer.Path()) // Capture stderr to check warning message oldStderr := os.Stderr r, w, _ := os.Pipe() os.Stderr = w // Install with verification enabled (should warn but succeed) result, err := InstallWithOptions(installer, Options{Verify: true, Keyring: "dummy"}) // Restore stderr and read captured output w.Close() os.Stderr = oldStderr var buf bytes.Buffer io.Copy(&buf, r) output := buf.String() // Should succeed with nil result (no verification performed) if err != nil { t.Fatalf("Expected installation to succeed despite missing .prov file, got error: %v", err) } if result != nil { t.Errorf("Expected nil verification result when .prov file is missing, got: %+v", result) } // Should contain warning message expectedWarning := "WARNING: No provenance file found for plugin" if !strings.Contains(output, expectedWarning) { t.Errorf("Expected warning message '%s' in output, got: %s", expectedWarning, output) } // Plugin should be installed if _, err := os.Stat(installer.Path()); os.IsNotExist(err) { t.Errorf("Plugin should be installed at %s", installer.Path()) } } func TestInstallWithOptions_VerifyWithValidProvenance(t *testing.T) { ensure.HelmHome(t) // Create a temporary plugin tarball with valid .prov file pluginDir := createTestPluginDir(t) pluginTgz := createTarballFromPluginDir(t, pluginDir) provFile := pluginTgz + ".prov" createProvFile(t, provFile, pluginTgz, "") defer os.Remove(provFile) // Create keyring with test key (empty for testing) keyring := createTestKeyring(t) defer os.Remove(keyring) // Create local installer installer, err := NewLocalInstaller(pluginTgz) if err != nil { t.Fatalf("Failed to create installer: %v", err) } defer os.RemoveAll(installer.Path()) // Install with verification enabled // This will fail signature verification but pass hash validation result, err := InstallWithOptions(installer, Options{Verify: true, Keyring: keyring}) // Should fail due to invalid signature (empty keyring) but we test that it gets past the hash check if err == nil { t.Fatalf("Expected installation to fail with empty keyring") } if !strings.Contains(err.Error(), "plugin verification failed") { t.Errorf("Expected plugin verification failed error, got: %v", err) } if result != nil { t.Errorf("Expected nil verification result when verification fails, got: %+v", result) } // Plugin should not be installed due to verification failure if _, err := os.Stat(installer.Path()); !os.IsNotExist(err) { t.Errorf("Plugin should not be installed when verification fails") } } func TestInstallWithOptions_VerifyWithInvalidProvenance(t *testing.T) { ensure.HelmHome(t) // Create a temporary plugin tarball with invalid .prov file pluginDir := createTestPluginDir(t) pluginTgz := createTarballFromPluginDir(t, pluginDir) defer os.Remove(pluginTgz) provFile := pluginTgz + ".prov" createProvFileInvalidFormat(t, provFile) defer os.Remove(provFile) // Create keyring with test key keyring := createTestKeyring(t) defer os.Remove(keyring) // Create local installer installer, err := NewLocalInstaller(pluginTgz) if err != nil { t.Fatalf("Failed to create installer: %v", err) } defer os.RemoveAll(installer.Path()) // Install with verification enabled (should fail) result, err := InstallWithOptions(installer, Options{Verify: true, Keyring: keyring}) // Should fail with verification error if err == nil { t.Fatalf("Expected installation with invalid .prov file to fail") } if result != nil { t.Errorf("Expected nil verification result when verification fails, got: %+v", result) } // Should contain verification failure message expectedError := "plugin verification failed" if !strings.Contains(err.Error(), expectedError) { t.Errorf("Expected error message '%s', got: %s", expectedError, err.Error()) } // Plugin should not be installed if _, err := os.Stat(installer.Path()); !os.IsNotExist(err) { t.Errorf("Plugin should not be installed when verification fails") } } func TestInstallWithOptions_NoVerifyRequested(t *testing.T) { ensure.HelmHome(t) // Create a temporary plugin tarball without .prov file pluginDir := createTestPluginDir(t) pluginTgz := createTarballFromPluginDir(t, pluginDir) defer os.Remove(pluginTgz) // Create local installer installer, err := NewLocalInstaller(pluginTgz) if err != nil { t.Fatalf("Failed to create installer: %v", err) } defer os.RemoveAll(installer.Path()) // Install without verification (should succeed without any verification) result, err := InstallWithOptions(installer, Options{Verify: false}) // Should succeed with no verification if err != nil { t.Fatalf("Expected installation without verification to succeed, got error: %v", err) } if result != nil { t.Errorf("Expected nil verification result when verification is disabled, got: %+v", result) } // Plugin should be installed if _, err := os.Stat(installer.Path()); os.IsNotExist(err) { t.Errorf("Plugin should be installed at %s", installer.Path()) } } func TestInstallWithOptions_VerifyDirectoryNotSupported(t *testing.T) { ensure.HelmHome(t) // Create a directory-based plugin (not an archive) pluginDir := createTestPluginDir(t) // Create local installer for directory installer, err := NewLocalInstaller(pluginDir) if err != nil { t.Fatalf("Failed to create installer: %v", err) } defer os.RemoveAll(installer.Path()) // Install with verification should fail (directories don't support verification) result, err := InstallWithOptions(installer, Options{Verify: true, Keyring: "dummy"}) // Should fail with verification not supported error if err == nil { t.Fatalf("Expected installation to fail with verification not supported error") } if !strings.Contains(err.Error(), "--verify is only supported for plugin tarballs") { t.Errorf("Expected verification not supported error, got: %v", err) } if result != nil { t.Errorf("Expected nil verification result when verification fails, got: %+v", result) } } func TestInstallWithOptions_VerifyMismatchedProvenance(t *testing.T) { ensure.HelmHome(t) // Create plugin tarball pluginDir := createTestPluginDir(t) pluginTgz := createTarballFromPluginDir(t, pluginDir) defer os.Remove(pluginTgz) provFile := pluginTgz + ".prov" // Create provenance file with wrong hash (for a different file) createProvFile(t, provFile, pluginTgz, "sha256:wronghash") defer os.Remove(provFile) // Create keyring with test key keyring := createTestKeyring(t) defer os.Remove(keyring) // Create local installer installer, err := NewLocalInstaller(pluginTgz) if err != nil { t.Fatalf("Failed to create installer: %v", err) } defer os.RemoveAll(installer.Path()) // Install with verification should fail due to hash mismatch result, err := InstallWithOptions(installer, Options{Verify: true, Keyring: keyring}) // Should fail with verification error if err == nil { t.Fatalf("Expected installation to fail with hash mismatch") } if !strings.Contains(err.Error(), "plugin verification failed") { t.Errorf("Expected plugin verification failed error, got: %v", err) } if result != nil { t.Errorf("Expected nil verification result when verification fails, got: %+v", result) } } func TestInstallWithOptions_VerifyProvenanceAccessError(t *testing.T) { ensure.HelmHome(t) // Create plugin tarball pluginDir := createTestPluginDir(t) pluginTgz := createTarballFromPluginDir(t, pluginDir) defer os.Remove(pluginTgz) // Create a .prov file but make it inaccessible (simulate permission error) provFile := pluginTgz + ".prov" if err := os.WriteFile(provFile, []byte("test"), 0000); err != nil { t.Fatalf("Failed to create inaccessible provenance file: %v", err) } defer os.Remove(provFile) // Create keyring keyring := createTestKeyring(t) defer os.Remove(keyring) // Create local installer installer, err := NewLocalInstaller(pluginTgz) if err != nil { t.Fatalf("Failed to create installer: %v", err) } defer os.RemoveAll(installer.Path()) // Install with verification should fail due to access error result, err := InstallWithOptions(installer, Options{Verify: true, Keyring: keyring}) // Should fail with access error (either at stat level or during verification) if err == nil { t.Fatalf("Expected installation to fail with provenance file access error") } // The error could be either "failed to access provenance file" or "plugin verification failed" // depending on when the permission error occurs if !strings.Contains(err.Error(), "failed to access provenance file") && !strings.Contains(err.Error(), "plugin verification failed") { t.Errorf("Expected provenance file access or verification error, got: %v", err) } if result != nil { t.Errorf("Expected nil verification result when verification fails, got: %+v", result) } } // Helper functions for test setup func createTestPluginDir(t *testing.T) string { t.Helper() // Create temporary directory with plugin structure tmpDir := t.TempDir() pluginDir := filepath.Join(tmpDir, "test-plugin") if err := os.MkdirAll(pluginDir, 0755); err != nil { t.Fatalf("Failed to create plugin directory: %v", err) } // Create plugin.yaml using the standardized v1 format pluginYaml := `apiVersion: v1 name: test-plugin type: cli/v1 runtime: subprocess version: 1.0.0 runtimeConfig: platformCommand: - command: echo` if err := os.WriteFile(filepath.Join(pluginDir, "plugin.yaml"), []byte(pluginYaml), 0644); err != nil { t.Fatalf("Failed to create plugin.yaml: %v", err) } return pluginDir } func createTarballFromPluginDir(t *testing.T, pluginDir string) string { t.Helper() // Create tarball using the plugin package helper tmpDir := filepath.Dir(pluginDir) tgzPath := filepath.Join(tmpDir, "test-plugin-1.0.0.tgz") tarFile, err := os.Create(tgzPath) if err != nil { t.Fatalf("Failed to create tarball file: %v", err) } defer tarFile.Close() if err := plugin.CreatePluginTarball(pluginDir, "test-plugin", tarFile); err != nil { t.Fatalf("Failed to create tarball: %v", err) } return tgzPath } func createProvFile(t *testing.T, provFile, pluginTgz, hash string) { t.Helper() var hashStr string if hash == "" { // Calculate actual hash of the tarball for realistic testing data, err := os.ReadFile(pluginTgz) if err != nil { t.Fatalf("Failed to read tarball for hashing: %v", err) } hashSum := sha256.Sum256(data) hashStr = fmt.Sprintf("sha256:%x", hashSum) } else { // Use provided hash (could be wrong for testing) hashStr = hash } // Create properly formatted provenance file with specified hash provContent := fmt.Sprintf(`-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 name: test-plugin version: 1.0.0 description: Test plugin for verification files: test-plugin-1.0.0.tgz: %s -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBCAAGBQJktest... -----END PGP SIGNATURE----- `, hashStr) if err := os.WriteFile(provFile, []byte(provContent), 0644); err != nil { t.Fatalf("Failed to create provenance file: %v", err) } } func createProvFileInvalidFormat(t *testing.T, provFile string) { t.Helper() // Create an invalid provenance file (not PGP signed format) invalidProv := "This is not a valid PGP signed message" if err := os.WriteFile(provFile, []byte(invalidProv), 0644); err != nil { t.Fatalf("Failed to create invalid provenance file: %v", err) } } func createTestKeyring(t *testing.T) string { t.Helper() // Create a temporary keyring file tmpDir := t.TempDir() keyringPath := filepath.Join(tmpDir, "pubring.gpg") // Create empty keyring for testing if err := os.WriteFile(keyringPath, []byte{}, 0644); err != nil { t.Fatalf("Failed to create test keyring: %v", err) } return keyringPath }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/installer/local_installer.go
internal/plugin/installer/local_installer.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package installer // import "helm.sh/helm/v4/internal/plugin/installer" import ( "bytes" "errors" "fmt" "log/slog" "os" "path/filepath" "strings" "helm.sh/helm/v4/internal/plugin" "helm.sh/helm/v4/internal/third_party/dep/fs" "helm.sh/helm/v4/pkg/helmpath" ) // ErrPluginNotADirectory indicates that the plugin path is not a directory. var ErrPluginNotADirectory = errors.New("expected plugin to be a directory (containing a file 'plugin.yaml')") // LocalInstaller installs plugins from the filesystem. type LocalInstaller struct { base isArchive bool extractor Extractor pluginData []byte // Cached plugin data provData []byte // Cached provenance data } // NewLocalInstaller creates a new LocalInstaller. func NewLocalInstaller(source string) (*LocalInstaller, error) { src, err := filepath.Abs(source) if err != nil { return nil, fmt.Errorf("unable to get absolute path to plugin: %w", err) } i := &LocalInstaller{ base: newBase(src), } // Check if source is an archive if isLocalArchive(src) { i.isArchive = true extractor, err := NewExtractor(src) if err != nil { return nil, fmt.Errorf("unsupported archive format: %w", err) } i.extractor = extractor } return i, nil } // isLocalArchive checks if the file is a supported archive format func isLocalArchive(path string) bool { for suffix := range Extractors { if strings.HasSuffix(path, suffix) { return true } } return false } // Install creates a symlink to the plugin directory. // // Implements Installer. func (i *LocalInstaller) Install() error { if i.isArchive { return i.installFromArchive() } return i.installFromDirectory() } // installFromDirectory creates a symlink to the plugin directory func (i *LocalInstaller) installFromDirectory() error { stat, err := os.Stat(i.Source) if err != nil { return err } if !stat.IsDir() { return ErrPluginNotADirectory } if !isPlugin(i.Source) { return ErrMissingMetadata } slog.Debug("symlinking", "source", i.Source, "path", i.Path()) return os.Symlink(i.Source, i.Path()) } // installFromArchive extracts and installs a plugin from a tarball func (i *LocalInstaller) installFromArchive() error { // Read the archive file data, err := os.ReadFile(i.Source) if err != nil { return fmt.Errorf("failed to read archive: %w", err) } // Copy the original tarball to plugins directory for verification // Extract metadata to get the actual plugin name and version metadata, err := plugin.ExtractTgzPluginMetadata(bytes.NewReader(data)) if err != nil { return fmt.Errorf("failed to extract plugin metadata from tarball: %w", err) } filename := fmt.Sprintf("%s-%s.tgz", metadata.Name, metadata.Version) tarballPath := helmpath.DataPath("plugins", filename) if err := os.MkdirAll(filepath.Dir(tarballPath), 0755); err != nil { return fmt.Errorf("failed to create plugins directory: %w", err) } if err := os.WriteFile(tarballPath, data, 0644); err != nil { return fmt.Errorf("failed to save tarball: %w", err) } // Check for and copy .prov file if it exists provSource := i.Source + ".prov" if provData, err := os.ReadFile(provSource); err == nil { provPath := tarballPath + ".prov" if err := os.WriteFile(provPath, provData, 0644); err != nil { slog.Debug("failed to save provenance file", "error", err) } } // Create a temporary directory for extraction tempDir, err := os.MkdirTemp("", "helm-plugin-extract-") if err != nil { return fmt.Errorf("failed to create temp directory: %w", err) } defer os.RemoveAll(tempDir) // Extract the archive buffer := bytes.NewBuffer(data) if err := i.extractor.Extract(buffer, tempDir); err != nil { return fmt.Errorf("failed to extract archive: %w", err) } // Plugin directory should be named after the plugin at the archive root pluginName := stripPluginName(filepath.Base(i.Source)) pluginDir := filepath.Join(tempDir, pluginName) if _, err = os.Stat(filepath.Join(pluginDir, "plugin.yaml")); err != nil { return fmt.Errorf("plugin.yaml not found in expected directory %s: %w", pluginDir, err) } // Copy to the final destination slog.Debug("copying", "source", pluginDir, "path", i.Path()) return fs.CopyDir(pluginDir, i.Path()) } // Update updates a local repository func (i *LocalInstaller) Update() error { slog.Debug("local repository is auto-updated") return nil } // Path is overridden to handle archive plugin names properly func (i *LocalInstaller) Path() string { if i.Source == "" { return "" } pluginName := filepath.Base(i.Source) if i.isArchive { // Strip archive extension to get plugin name pluginName = stripPluginName(pluginName) } return helmpath.DataPath("plugins", pluginName) } // SupportsVerification returns true if the local installer can verify plugins func (i *LocalInstaller) SupportsVerification() bool { // Only support verification for local tarball files return i.isArchive } // GetVerificationData loads plugin and provenance data from local files for verification func (i *LocalInstaller) GetVerificationData() (archiveData, provData []byte, filename string, err error) { if !i.SupportsVerification() { return nil, nil, "", fmt.Errorf("verification not supported for directories") } // Read and cache the plugin archive file if i.pluginData == nil { i.pluginData, err = os.ReadFile(i.Source) if err != nil { return nil, nil, "", fmt.Errorf("failed to read plugin file: %w", err) } } // Read and cache the provenance file if it exists if i.provData == nil { provFile := i.Source + ".prov" i.provData, err = os.ReadFile(provFile) if err != nil { if os.IsNotExist(err) { // If provenance file doesn't exist, set provData to nil // The verification logic will handle this gracefully i.provData = nil } else { // If file exists but can't be read (permissions, etc), return error return nil, nil, "", fmt.Errorf("failed to access provenance file %s: %w", provFile, err) } } } return i.pluginData, i.provData, filepath.Base(i.Source), nil }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/installer/oci_installer_test.go
internal/plugin/installer/oci_installer_test.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package installer // import "helm.sh/helm/v4/internal/plugin/installer" import ( "archive/tar" "bytes" "compress/gzip" "crypto/sha256" "encoding/json" "fmt" "net/http" "net/http/httptest" "net/url" "os" "path/filepath" "strings" "testing" "time" "github.com/opencontainers/go-digest" ocispec "github.com/opencontainers/image-spec/specs-go/v1" "helm.sh/helm/v4/internal/test/ensure" "helm.sh/helm/v4/pkg/cli" "helm.sh/helm/v4/pkg/getter" "helm.sh/helm/v4/pkg/helmpath" ) var _ Installer = new(OCIInstaller) // createTestPluginTarGz creates a test plugin tar.gz with plugin.yaml func createTestPluginTarGz(t *testing.T, pluginName string) []byte { t.Helper() var buf bytes.Buffer gzWriter := gzip.NewWriter(&buf) tarWriter := tar.NewWriter(gzWriter) // Add plugin.yaml pluginYAML := fmt.Sprintf(`name: %s version: "1.0.0" description: "Test plugin for OCI installer" command: "$HELM_PLUGIN_DIR/bin/%s" `, pluginName, pluginName) header := &tar.Header{ Name: "plugin.yaml", Mode: 0644, Size: int64(len(pluginYAML)), Typeflag: tar.TypeReg, } if err := tarWriter.WriteHeader(header); err != nil { t.Fatal(err) } if _, err := tarWriter.Write([]byte(pluginYAML)); err != nil { t.Fatal(err) } // Add bin directory dirHeader := &tar.Header{ Name: "bin/", Mode: 0755, Typeflag: tar.TypeDir, } if err := tarWriter.WriteHeader(dirHeader); err != nil { t.Fatal(err) } // Add executable execContent := fmt.Sprintf("#!/bin/sh\necho '%s test plugin'", pluginName) execHeader := &tar.Header{ Name: fmt.Sprintf("bin/%s", pluginName), Mode: 0755, Size: int64(len(execContent)), Typeflag: tar.TypeReg, } if err := tarWriter.WriteHeader(execHeader); err != nil { t.Fatal(err) } if _, err := tarWriter.Write([]byte(execContent)); err != nil { t.Fatal(err) } tarWriter.Close() gzWriter.Close() return buf.Bytes() } // mockOCIRegistryWithArtifactType creates a mock OCI registry server using the new artifact type approach func mockOCIRegistryWithArtifactType(t *testing.T, pluginName string) (*httptest.Server, string) { t.Helper() pluginData := createTestPluginTarGz(t, pluginName) layerDigest := fmt.Sprintf("sha256:%x", sha256Sum(pluginData)) // Create empty config data (as per OCI v1.1+ spec) configData := []byte("{}") configDigest := fmt.Sprintf("sha256:%x", sha256Sum(configData)) // Create manifest with artifact type manifest := ocispec.Manifest{ MediaType: ocispec.MediaTypeImageManifest, ArtifactType: "application/vnd.helm.plugin.v1+json", // Using artifact type Config: ocispec.Descriptor{ MediaType: "application/vnd.oci.empty.v1+json", // Empty config Digest: digest.Digest(configDigest), Size: int64(len(configData)), }, Layers: []ocispec.Descriptor{ { MediaType: "application/vnd.oci.image.layer.v1.tar", Digest: digest.Digest(layerDigest), Size: int64(len(pluginData)), Annotations: map[string]string{ ocispec.AnnotationTitle: pluginName + "-1.0.0.tgz", // Layer named with version }, }, }, } manifestData, err := json.Marshal(manifest) if err != nil { t.Fatal(err) } manifestDigest := fmt.Sprintf("sha256:%x", sha256Sum(manifestData)) server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { switch { case r.Method == http.MethodGet && strings.Contains(r.URL.Path, "/v2/") && !strings.Contains(r.URL.Path, "/manifests/") && !strings.Contains(r.URL.Path, "/blobs/"): // API version check w.Header().Set("Docker-Distribution-API-Version", "registry/2.0") w.Header().Set("Content-Type", "application/json") w.WriteHeader(http.StatusOK) w.Write([]byte("{}")) case r.Method == http.MethodGet && strings.Contains(r.URL.Path, "/manifests/") && strings.Contains(r.URL.Path, pluginName): // Return manifest w.Header().Set("Content-Type", ocispec.MediaTypeImageManifest) w.Header().Set("Docker-Content-Digest", manifestDigest) w.WriteHeader(http.StatusOK) w.Write(manifestData) case r.Method == http.MethodGet && strings.Contains(r.URL.Path, "/blobs/"+layerDigest): // Return layer data w.Header().Set("Content-Type", "application/vnd.oci.image.layer.v1.tar") w.WriteHeader(http.StatusOK) w.Write(pluginData) case r.Method == http.MethodGet && strings.Contains(r.URL.Path, "/blobs/"+configDigest): // Return config data w.Header().Set("Content-Type", "application/vnd.oci.empty.v1+json") w.WriteHeader(http.StatusOK) w.Write(configData) default: w.WriteHeader(http.StatusNotFound) } })) // Parse server URL to get host:port format for OCI reference serverURL, err := url.Parse(server.URL) if err != nil { t.Fatal(err) } registryHost := serverURL.Host return server, registryHost } // sha256Sum calculates SHA256 sum of data func sha256Sum(data []byte) []byte { h := sha256.New() h.Write(data) return h.Sum(nil) } func TestNewOCIInstaller(t *testing.T) { tests := []struct { name string source string expectName string expectError bool }{ { name: "valid OCI reference with tag", source: "oci://ghcr.io/user/plugin-name:v1.0.0", expectName: "plugin-name", expectError: false, }, { name: "valid OCI reference with digest", source: "oci://ghcr.io/user/plugin-name@sha256:1234567890abcdef", expectName: "plugin-name", expectError: false, }, { name: "valid OCI reference without tag", source: "oci://ghcr.io/user/plugin-name", expectName: "plugin-name", expectError: false, }, { name: "valid OCI reference with multiple path segments", source: "oci://registry.example.com/org/team/plugin-name:latest", expectName: "plugin-name", expectError: false, }, { name: "invalid OCI reference - no path", source: "oci://registry.example.com", expectName: "", expectError: true, }, { name: "valid OCI reference - single path segment", source: "oci://registry.example.com/plugin", expectName: "plugin", expectError: false, }, } for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { installer, err := NewOCIInstaller(tt.source) if tt.expectError { if err == nil { t.Errorf("expected error but got none") } return } if err != nil { t.Errorf("unexpected error: %v", err) return } // Check all fields thoroughly if installer.PluginName != tt.expectName { t.Errorf("expected plugin name %s, got %s", tt.expectName, installer.PluginName) } if installer.Source != tt.source { t.Errorf("expected source %s, got %s", tt.source, installer.Source) } if installer.CacheDir == "" { t.Error("expected non-empty cache directory") } if !strings.Contains(installer.CacheDir, "plugins") { t.Errorf("expected cache directory to contain 'plugins', got %s", installer.CacheDir) } if installer.settings == nil { t.Error("expected settings to be initialized") } // Check that Path() method works expectedPath := helmpath.DataPath("plugins", tt.expectName) if installer.Path() != expectedPath { t.Errorf("expected path %s, got %s", expectedPath, installer.Path()) } }) } } func TestOCIInstaller_Path(t *testing.T) { tests := []struct { name string source string pluginName string expectPath string }{ { name: "valid plugin name", source: "oci://ghcr.io/user/plugin-name:v1.0.0", pluginName: "plugin-name", expectPath: helmpath.DataPath("plugins", "plugin-name"), }, { name: "empty source", source: "", pluginName: "", expectPath: "", }, } for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { installer := &OCIInstaller{ PluginName: tt.pluginName, base: newBase(tt.source), settings: cli.New(), } path := installer.Path() if path != tt.expectPath { t.Errorf("expected path %s, got %s", tt.expectPath, path) } }) } } func TestOCIInstaller_Install(t *testing.T) { // Set up isolated test environment ensure.HelmHome(t) pluginName := "test-plugin-basic" server, registryHost := mockOCIRegistryWithArtifactType(t, pluginName) defer server.Close() // Test OCI reference source := fmt.Sprintf("oci://%s/%s:latest", registryHost, pluginName) // Test with plain HTTP (since test server uses HTTP) installer, err := NewOCIInstaller(source, getter.WithPlainHTTP(true)) if err != nil { t.Fatalf("Expected no error, got %v", err) } // The OCI installer uses helmpath.DataPath, which is isolated by ensure.HelmHome(t) actualPath := installer.Path() t.Logf("Installer will use path: %s", actualPath) // Install the plugin if err := Install(installer); err != nil { t.Fatalf("Expected installation to succeed, got error: %v", err) } // Verify plugin was installed to the correct location if !isPlugin(actualPath) { t.Errorf("Expected plugin directory %s to contain plugin.yaml", actualPath) } // Debug: list what was actually created if entries, err := os.ReadDir(actualPath); err != nil { t.Fatalf("Could not read plugin directory %s: %v", actualPath, err) } else { t.Logf("Plugin directory %s contains:", actualPath) for _, entry := range entries { t.Logf(" - %s", entry.Name()) } } // Verify the plugin.yaml file exists and is valid pluginFile := filepath.Join(actualPath, "plugin.yaml") if _, err := os.Stat(pluginFile); err != nil { t.Errorf("Expected plugin.yaml to exist, got error: %v", err) } } func TestOCIInstaller_Install_WithGetterOptions(t *testing.T) { testCases := []struct { name string pluginName string options []getter.Option wantErr bool }{ { name: "plain HTTP", pluginName: "example-cli-plain-http", options: []getter.Option{getter.WithPlainHTTP(true)}, wantErr: false, }, { name: "insecure skip TLS verify", pluginName: "example-cli-insecure", options: []getter.Option{getter.WithPlainHTTP(true), getter.WithInsecureSkipVerifyTLS(true)}, wantErr: false, }, { name: "with timeout", pluginName: "example-cli-timeout", options: []getter.Option{getter.WithPlainHTTP(true), getter.WithTimeout(30 * time.Second)}, wantErr: false, }, } for _, tc := range testCases { t.Run(tc.name, func(t *testing.T) { // Set up isolated test environment for each subtest ensure.HelmHome(t) server, registryHost := mockOCIRegistryWithArtifactType(t, tc.pluginName) defer server.Close() source := fmt.Sprintf("oci://%s/%s:latest", registryHost, tc.pluginName) installer, err := NewOCIInstaller(source, tc.options...) if err != nil { if !tc.wantErr { t.Fatalf("Expected no error creating installer, got %v", err) } return } // The installer now uses our isolated test directory actualPath := installer.Path() // Install the plugin err = Install(installer) if tc.wantErr { if err == nil { t.Errorf("Expected installation to fail, but it succeeded") } } else { if err != nil { t.Errorf("Expected installation to succeed, got error: %v", err) } else { // Verify plugin was installed to the actual path if !isPlugin(actualPath) { t.Errorf("Expected plugin directory %s to contain plugin.yaml", actualPath) } } } }) } } func TestOCIInstaller_Install_AlreadyExists(t *testing.T) { // Set up isolated test environment ensure.HelmHome(t) pluginName := "test-plugin-exists" server, registryHost := mockOCIRegistryWithArtifactType(t, pluginName) defer server.Close() source := fmt.Sprintf("oci://%s/%s:latest", registryHost, pluginName) installer, err := NewOCIInstaller(source, getter.WithPlainHTTP(true)) if err != nil { t.Fatalf("Expected no error, got %v", err) } // First install should succeed if err := Install(installer); err != nil { t.Fatalf("Expected first installation to succeed, got error: %v", err) } // Verify plugin was installed if !isPlugin(installer.Path()) { t.Errorf("Expected plugin directory %s to contain plugin.yaml", installer.Path()) } // Second install should fail with "plugin already exists" err = Install(installer) if err == nil { t.Error("Expected error when installing plugin that already exists") } else if !strings.Contains(err.Error(), "plugin already exists") { t.Errorf("Expected 'plugin already exists' error, got: %v", err) } } func TestOCIInstaller_Update(t *testing.T) { // Set up isolated test environment ensure.HelmHome(t) pluginName := "test-plugin-update" server, registryHost := mockOCIRegistryWithArtifactType(t, pluginName) defer server.Close() source := fmt.Sprintf("oci://%s/%s:latest", registryHost, pluginName) installer, err := NewOCIInstaller(source, getter.WithPlainHTTP(true)) if err != nil { t.Fatalf("Expected no error, got %v", err) } // Test update when plugin does not exist - should fail err = Update(installer) if err == nil { t.Error("Expected error when updating plugin that does not exist") } else if !strings.Contains(err.Error(), "plugin does not exist") { t.Errorf("Expected 'plugin does not exist' error, got: %v", err) } // Install plugin first if err := Install(installer); err != nil { t.Fatalf("Expected installation to succeed, got error: %v", err) } // Verify plugin was installed if !isPlugin(installer.Path()) { t.Errorf("Expected plugin directory %s to contain plugin.yaml", installer.Path()) } // Test update when plugin exists - should succeed // For OCI, Update() removes old version and reinstalls if err := Update(installer); err != nil { t.Errorf("Expected update to succeed, got error: %v", err) } // Verify plugin is still installed after update if !isPlugin(installer.Path()) { t.Errorf("Expected plugin directory %s to contain plugin.yaml after update", installer.Path()) } } func TestOCIInstaller_Install_ComponentExtraction(t *testing.T) { // Test that we can extract a plugin archive properly // This tests the extraction logic that Install() uses tempDir := t.TempDir() pluginName := "test-plugin-extract" pluginData := createTestPluginTarGz(t, pluginName) // Test extraction err := extractTarGz(bytes.NewReader(pluginData), tempDir) if err != nil { t.Fatalf("Failed to extract plugin: %v", err) } // Verify plugin.yaml exists pluginYAMLPath := filepath.Join(tempDir, "plugin.yaml") if _, err := os.Stat(pluginYAMLPath); os.IsNotExist(err) { t.Errorf("plugin.yaml not found after extraction") } // Verify bin directory exists binPath := filepath.Join(tempDir, "bin") if _, err := os.Stat(binPath); os.IsNotExist(err) { t.Errorf("bin directory not found after extraction") } // Verify executable exists and has correct permissions execPath := filepath.Join(tempDir, "bin", pluginName) if info, err := os.Stat(execPath); err != nil { t.Errorf("executable not found: %v", err) } else if info.Mode()&0111 == 0 { t.Errorf("file is not executable") } // Verify this would be recognized as a plugin if !isPlugin(tempDir) { t.Errorf("extracted directory is not a valid plugin") } } func TestExtractTarGz(t *testing.T) { tempDir := t.TempDir() // Create a test tar.gz file var buf bytes.Buffer gzWriter := gzip.NewWriter(&buf) tarWriter := tar.NewWriter(gzWriter) // Add a test file to the archive testContent := "test content" header := &tar.Header{ Name: "test-file.txt", Mode: 0644, Size: int64(len(testContent)), Typeflag: tar.TypeReg, } if err := tarWriter.WriteHeader(header); err != nil { t.Fatal(err) } if _, err := tarWriter.Write([]byte(testContent)); err != nil { t.Fatal(err) } // Add a test directory dirHeader := &tar.Header{ Name: "test-dir/", Mode: 0755, Typeflag: tar.TypeDir, } if err := tarWriter.WriteHeader(dirHeader); err != nil { t.Fatal(err) } tarWriter.Close() gzWriter.Close() // Test extraction err := extractTarGz(bytes.NewReader(buf.Bytes()), tempDir) if err != nil { t.Errorf("extractTarGz failed: %v", err) } // Verify extracted file extractedFile := filepath.Join(tempDir, "test-file.txt") content, err := os.ReadFile(extractedFile) if err != nil { t.Errorf("failed to read extracted file: %v", err) } if string(content) != testContent { t.Errorf("expected content %s, got %s", testContent, string(content)) } // Verify extracted directory extractedDir := filepath.Join(tempDir, "test-dir") if _, err := os.Stat(extractedDir); os.IsNotExist(err) { t.Errorf("extracted directory does not exist: %s", extractedDir) } } func TestExtractTarGz_InvalidGzip(t *testing.T) { tempDir := t.TempDir() // Test with invalid gzip data invalidGzipData := []byte("not gzip data") err := extractTarGz(bytes.NewReader(invalidGzipData), tempDir) if err == nil { t.Error("expected error for invalid gzip data") } } func TestExtractTar_UnknownFileType(t *testing.T) { tempDir := t.TempDir() // Create a test tar file var buf bytes.Buffer tarWriter := tar.NewWriter(&buf) // Add a test file testContent := "test content" header := &tar.Header{ Name: "test-file.txt", Mode: 0644, Size: int64(len(testContent)), Typeflag: tar.TypeReg, } if err := tarWriter.WriteHeader(header); err != nil { t.Fatal(err) } if _, err := tarWriter.Write([]byte(testContent)); err != nil { t.Fatal(err) } // Test unknown file type unknownHeader := &tar.Header{ Name: "unknown-type", Mode: 0644, Typeflag: tar.TypeSymlink, // Use a type that's not handled } if err := tarWriter.WriteHeader(unknownHeader); err != nil { t.Fatal(err) } tarWriter.Close() // Test extraction - should fail due to unknown type err := extractTar(bytes.NewReader(buf.Bytes()), tempDir) if err == nil { t.Error("expected error for unknown tar file type") } if !strings.Contains(err.Error(), "unknown type") { t.Errorf("expected 'unknown type' error, got: %v", err) } } func TestExtractTar_SuccessfulExtraction(t *testing.T) { tempDir := t.TempDir() // Since we can't easily create extended headers with Go's tar package, // we'll test the logic that skips them by creating a simple tar with regular files // and then testing that the extraction works correctly. // Create a test tar file var buf bytes.Buffer tarWriter := tar.NewWriter(&buf) // Add a regular file testContent := "test content" header := &tar.Header{ Name: "test-file.txt", Mode: 0644, Size: int64(len(testContent)), Typeflag: tar.TypeReg, } if err := tarWriter.WriteHeader(header); err != nil { t.Fatal(err) } if _, err := tarWriter.Write([]byte(testContent)); err != nil { t.Fatal(err) } tarWriter.Close() // Test extraction err := extractTar(bytes.NewReader(buf.Bytes()), tempDir) if err != nil { t.Errorf("extractTar failed: %v", err) } // Verify the regular file was extracted extractedFile := filepath.Join(tempDir, "test-file.txt") content, err := os.ReadFile(extractedFile) if err != nil { t.Errorf("failed to read extracted file: %v", err) } if string(content) != testContent { t.Errorf("expected content %s, got %s", testContent, string(content)) } } func TestOCIInstaller_Install_PlainHTTPOption(t *testing.T) { // Test that PlainHTTP option is properly passed to getter source := "oci://example.com/test-plugin:v1.0.0" // Test with PlainHTTP=false (default) installer1, err := NewOCIInstaller(source) if err != nil { t.Fatalf("failed to create installer: %v", err) } if installer1.getter == nil { t.Error("getter should be initialized") } // Test with PlainHTTP=true installer2, err := NewOCIInstaller(source, getter.WithPlainHTTP(true)) if err != nil { t.Fatalf("failed to create installer with PlainHTTP=true: %v", err) } if installer2.getter == nil { t.Error("getter should be initialized with PlainHTTP=true") } // Both installers should have the same basic properties if installer1.PluginName != installer2.PluginName { t.Error("plugin names should match") } if installer1.Source != installer2.Source { t.Error("sources should match") } // Test with multiple options installer3, err := NewOCIInstaller(source, getter.WithPlainHTTP(true), getter.WithBasicAuth("user", "pass"), ) if err != nil { t.Fatalf("failed to create installer with multiple options: %v", err) } if installer3.getter == nil { t.Error("getter should be initialized with multiple options") } } func TestOCIInstaller_Install_ValidationErrors(t *testing.T) { tests := []struct { name string layerData []byte expectError bool errorMsg string }{ { name: "non-gzip layer", layerData: []byte("not gzip data"), expectError: true, errorMsg: "is not a gzip compressed archive", }, { name: "empty layer", layerData: []byte{}, expectError: true, errorMsg: "is not a gzip compressed archive", }, { name: "single byte layer", layerData: []byte{0x1f}, expectError: true, errorMsg: "is not a gzip compressed archive", }, } for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { // Test the gzip validation logic that's used in the Install method if len(tt.layerData) < 2 || tt.layerData[0] != 0x1f || tt.layerData[1] != 0x8b { // This matches the validation in the Install method if !tt.expectError { t.Error("expected valid gzip data") } if !strings.Contains(tt.errorMsg, "is not a gzip compressed archive") { t.Errorf("expected error message to contain 'is not a gzip compressed archive'") } } }) } }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/installer/http_installer_test.go
internal/plugin/installer/http_installer_test.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package installer // import "helm.sh/helm/v4/internal/plugin/installer" import ( "archive/tar" "bytes" "compress/gzip" "encoding/base64" "errors" "fmt" "io/fs" "net/http" "net/http/httptest" "os" "path/filepath" "strings" "syscall" "testing" "helm.sh/helm/v4/internal/test/ensure" "helm.sh/helm/v4/pkg/getter" "helm.sh/helm/v4/pkg/helmpath" ) var _ Installer = new(HTTPInstaller) // Fake http client type TestHTTPGetter struct { MockResponse *bytes.Buffer MockError error } func (t *TestHTTPGetter) Get(_ string, _ ...getter.Option) (*bytes.Buffer, error) { return t.MockResponse, t.MockError } // Fake plugin tarball data var fakePluginB64 = "H4sIAAAAAAAAA+3SQUvDMBgG4Jz7K0LwapdvSxrwJig6mCKC5xHabBaXdDSt4L+3cQ56mV42ZPg+lw+SF5LwZmXf3OV206/rMGEnIgdG6zTJaDmee4y01FOlZpqGHJGZSsb1qS401sfOtpyz0FTup9xv+2dqNep/N/IP6zdHPSMVXCh1sH8yhtGMDBUFFTL1r4iIcXnUWxzwz/sP1rsrLkbfQGTvro11E4ZlmcucRNZHu04py1OO73OVi2Vbb7td9vp7nXevtvsKRpGVjfc2VMP2xf3t4mH5tHi5mz8ub+bPk9JXIvvr5wMAAAAAAAAAAAAAAAAAAAAAnLVPqwHcXQAoAAA=" func TestStripName(t *testing.T) { if stripPluginName("fake-plugin-0.0.1.tar.gz") != "fake-plugin" { t.Errorf("name does not match expected value") } if stripPluginName("fake-plugin-0.0.1.tgz") != "fake-plugin" { t.Errorf("name does not match expected value") } if stripPluginName("fake-plugin.tgz") != "fake-plugin" { t.Errorf("name does not match expected value") } if stripPluginName("fake-plugin.tar.gz") != "fake-plugin" { t.Errorf("name does not match expected value") } } func mockArchiveServer() *httptest.Server { return httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { if !strings.HasSuffix(r.URL.Path, ".tar.gz") { w.Header().Add("Content-Type", "text/html") fmt.Fprintln(w, "broken") return } w.Header().Add("Content-Type", "application/gzip") fmt.Fprintln(w, "test") })) } func TestHTTPInstaller(t *testing.T) { ensure.HelmHome(t) srv := mockArchiveServer() defer srv.Close() source := srv.URL + "/plugins/fake-plugin-0.0.1.tar.gz" if err := os.MkdirAll(helmpath.DataPath("plugins"), 0755); err != nil { t.Fatalf("Could not create %s: %s", helmpath.DataPath("plugins"), err) } i, err := NewForSource(source, "0.0.1") if err != nil { t.Fatalf("unexpected error: %s", err) } // ensure a HTTPInstaller was returned httpInstaller, ok := i.(*HTTPInstaller) if !ok { t.Fatal("expected a HTTPInstaller") } // inject fake http client responding with minimal plugin tarball mockTgz, err := base64.StdEncoding.DecodeString(fakePluginB64) if err != nil { t.Fatalf("Could not decode fake tgz plugin: %s", err) } httpInstaller.getter = &TestHTTPGetter{ MockResponse: bytes.NewBuffer(mockTgz), } // install the plugin if err := Install(i); err != nil { t.Fatal(err) } if i.Path() != helmpath.DataPath("plugins", "fake-plugin") { t.Fatalf("expected path '$XDG_CONFIG_HOME/helm/plugins/fake-plugin', got %q", i.Path()) } // Install again to test plugin exists error if err := Install(i); err == nil { t.Fatal("expected error for plugin exists, got none") } else if err.Error() != "plugin already exists" { t.Fatalf("expected error for plugin exists, got (%v)", err) } } func TestHTTPInstallerNonExistentVersion(t *testing.T) { ensure.HelmHome(t) srv := mockArchiveServer() defer srv.Close() source := srv.URL + "/plugins/fake-plugin-0.0.1.tar.gz" if err := os.MkdirAll(helmpath.DataPath("plugins"), 0755); err != nil { t.Fatalf("Could not create %s: %s", helmpath.DataPath("plugins"), err) } i, err := NewForSource(source, "0.0.2") if err != nil { t.Fatalf("unexpected error: %s", err) } // ensure a HTTPInstaller was returned httpInstaller, ok := i.(*HTTPInstaller) if !ok { t.Fatal("expected a HTTPInstaller") } // inject fake http client responding with error httpInstaller.getter = &TestHTTPGetter{ MockError: fmt.Errorf("failed to download plugin for some reason"), } // attempt to install the plugin if err := Install(i); err == nil { t.Fatal("expected error from http client") } } func TestHTTPInstallerUpdate(t *testing.T) { srv := mockArchiveServer() defer srv.Close() source := srv.URL + "/plugins/fake-plugin-0.0.1.tar.gz" ensure.HelmHome(t) if err := os.MkdirAll(helmpath.DataPath("plugins"), 0755); err != nil { t.Fatalf("Could not create %s: %s", helmpath.DataPath("plugins"), err) } i, err := NewForSource(source, "0.0.1") if err != nil { t.Fatalf("unexpected error: %s", err) } // ensure a HTTPInstaller was returned httpInstaller, ok := i.(*HTTPInstaller) if !ok { t.Fatal("expected a HTTPInstaller") } // inject fake http client responding with minimal plugin tarball mockTgz, err := base64.StdEncoding.DecodeString(fakePluginB64) if err != nil { t.Fatalf("Could not decode fake tgz plugin: %s", err) } httpInstaller.getter = &TestHTTPGetter{ MockResponse: bytes.NewBuffer(mockTgz), } // install the plugin before updating if err := Install(i); err != nil { t.Fatal(err) } if i.Path() != helmpath.DataPath("plugins", "fake-plugin") { t.Fatalf("expected path '$XDG_CONFIG_HOME/helm/plugins/fake-plugin', got %q", i.Path()) } // Update plugin, should fail because it is not implemented if err := Update(i); err == nil { t.Fatal("update method not implemented for http installer") } } func TestExtract(t *testing.T) { source := "https://repo.localdomain/plugins/fake-plugin-0.0.1.tar.gz" tempDir := t.TempDir() // Get current umask to predict expected permissions currentUmask := syscall.Umask(0) syscall.Umask(currentUmask) // Write a tarball to a buffer for us to extract var tarbuf bytes.Buffer tw := tar.NewWriter(&tarbuf) var files = []struct { Name, Body string Mode int64 }{ {"plugin.yaml", "plugin metadata", 0600}, {"README.md", "some text", 0777}, } for _, file := range files { hdr := &tar.Header{ Name: file.Name, Typeflag: tar.TypeReg, Mode: file.Mode, Size: int64(len(file.Body)), } if err := tw.WriteHeader(hdr); err != nil { t.Fatal(err) } if _, err := tw.Write([]byte(file.Body)); err != nil { t.Fatal(err) } } // Add pax global headers. This should be ignored. // Note the PAX header that isn't global cannot be written using WriteHeader. // Details are in the internal Go function for the tar packaged named // allowedFormats. For a TypeXHeader it will return a message stating // "cannot manually encode TypeXHeader, TypeGNULongName, or TypeGNULongLink headers" if err := tw.WriteHeader(&tar.Header{ Name: "pax_global_header", Typeflag: tar.TypeXGlobalHeader, }); err != nil { t.Fatal(err) } if err := tw.Close(); err != nil { t.Fatal(err) } var buf bytes.Buffer gz := gzip.NewWriter(&buf) if _, err := gz.Write(tarbuf.Bytes()); err != nil { t.Fatal(err) } gz.Close() // END tarball creation extractor, err := NewExtractor(source) if err != nil { t.Fatal(err) } if err = extractor.Extract(&buf, tempDir); err != nil { t.Fatalf("Did not expect error but got error: %v", err) } // Calculate expected permissions after umask is applied expectedPluginYAMLPerm := os.FileMode(0600 &^ currentUmask) expectedReadmePerm := os.FileMode(0777 &^ currentUmask) pluginYAMLFullPath := filepath.Join(tempDir, "plugin.yaml") if info, err := os.Stat(pluginYAMLFullPath); err != nil { if errors.Is(err, fs.ErrNotExist) { t.Fatalf("Expected %s to exist but doesn't", pluginYAMLFullPath) } t.Fatal(err) } else if info.Mode().Perm() != expectedPluginYAMLPerm { t.Fatalf("Expected %s to have %o mode but has %o (umask: %o)", pluginYAMLFullPath, expectedPluginYAMLPerm, info.Mode().Perm(), currentUmask) } readmeFullPath := filepath.Join(tempDir, "README.md") if info, err := os.Stat(readmeFullPath); err != nil { if errors.Is(err, fs.ErrNotExist) { t.Fatalf("Expected %s to exist but doesn't", readmeFullPath) } t.Fatal(err) } else if info.Mode().Perm() != expectedReadmePerm { t.Fatalf("Expected %s to have %o mode but has %o (umask: %o)", readmeFullPath, expectedReadmePerm, info.Mode().Perm(), currentUmask) } } func TestCleanJoin(t *testing.T) { for i, fixture := range []struct { path string expect string expectError bool }{ {"foo/bar.txt", "/tmp/foo/bar.txt", false}, {"/foo/bar.txt", "", true}, {"./foo/bar.txt", "/tmp/foo/bar.txt", false}, {"./././././foo/bar.txt", "/tmp/foo/bar.txt", false}, {"../../../../foo/bar.txt", "", true}, {"foo/../../../../bar.txt", "", true}, {"c:/foo/bar.txt", "/tmp/c:/foo/bar.txt", true}, {"foo\\bar.txt", "/tmp/foo/bar.txt", false}, {"c:\\foo\\bar.txt", "", true}, } { out, err := cleanJoin("/tmp", fixture.path) if err != nil { if !fixture.expectError { t.Errorf("Test %d: Path was not cleaned: %s", i, err) } continue } if fixture.expect != out { t.Errorf("Test %d: Expected %q but got %q", i, fixture.expect, out) } } } func TestMediaTypeToExtension(t *testing.T) { for mt, shouldPass := range map[string]bool{ "": false, "application/gzip": true, "application/x-gzip": true, "application/x-tgz": true, "application/x-gtar": true, "application/json": false, } { ext, ok := mediaTypeToExtension(mt) if ok != shouldPass { t.Errorf("Media type %q failed test", mt) } if shouldPass && ext == "" { t.Errorf("Expected an extension but got empty string") } if !shouldPass && len(ext) != 0 { t.Error("Expected extension to be empty for unrecognized type") } } } func TestExtractWithNestedDirectories(t *testing.T) { source := "https://repo.localdomain/plugins/nested-plugin-0.0.1.tar.gz" tempDir := t.TempDir() // Write a tarball with nested directory structure var tarbuf bytes.Buffer tw := tar.NewWriter(&tarbuf) var files = []struct { Name string Body string Mode int64 TypeFlag byte }{ {"plugin.yaml", "plugin metadata", 0600, tar.TypeReg}, {"bin/", "", 0755, tar.TypeDir}, {"bin/plugin", "#!/usr/bin/env sh\necho plugin", 0755, tar.TypeReg}, {"docs/", "", 0755, tar.TypeDir}, {"docs/README.md", "readme content", 0644, tar.TypeReg}, {"docs/examples/", "", 0755, tar.TypeDir}, {"docs/examples/example1.yaml", "example content", 0644, tar.TypeReg}, } for _, file := range files { hdr := &tar.Header{ Name: file.Name, Typeflag: file.TypeFlag, Mode: file.Mode, Size: int64(len(file.Body)), } if err := tw.WriteHeader(hdr); err != nil { t.Fatal(err) } if file.TypeFlag == tar.TypeReg { if _, err := tw.Write([]byte(file.Body)); err != nil { t.Fatal(err) } } } if err := tw.Close(); err != nil { t.Fatal(err) } var buf bytes.Buffer gz := gzip.NewWriter(&buf) if _, err := gz.Write(tarbuf.Bytes()); err != nil { t.Fatal(err) } gz.Close() extractor, err := NewExtractor(source) if err != nil { t.Fatal(err) } // First extraction if err = extractor.Extract(&buf, tempDir); err != nil { t.Fatalf("First extraction failed: %v", err) } // Verify nested structure was created nestedFile := filepath.Join(tempDir, "docs", "examples", "example1.yaml") if _, err := os.Stat(nestedFile); err != nil { t.Fatalf("Expected nested file %s to exist but got error: %v", nestedFile, err) } // Reset buffer for second extraction buf.Reset() gz = gzip.NewWriter(&buf) if _, err := gz.Write(tarbuf.Bytes()); err != nil { t.Fatal(err) } gz.Close() // Second extraction to same directory (should not fail) if err = extractor.Extract(&buf, tempDir); err != nil { t.Fatalf("Second extraction to existing directory failed: %v", err) } } func TestExtractWithExistingDirectory(t *testing.T) { source := "https://repo.localdomain/plugins/test-plugin-0.0.1.tar.gz" tempDir := t.TempDir() // Pre-create the cache directory structure cacheDir := filepath.Join(tempDir, "cache") if err := os.MkdirAll(filepath.Join(cacheDir, "existing", "dir"), 0755); err != nil { t.Fatal(err) } // Create a file in the existing directory existingFile := filepath.Join(cacheDir, "existing", "file.txt") if err := os.WriteFile(existingFile, []byte("existing content"), 0644); err != nil { t.Fatal(err) } // Write a tarball var tarbuf bytes.Buffer tw := tar.NewWriter(&tarbuf) files := []struct { Name string Body string Mode int64 TypeFlag byte }{ {"plugin.yaml", "plugin metadata", 0600, tar.TypeReg}, {"existing/", "", 0755, tar.TypeDir}, {"existing/dir/", "", 0755, tar.TypeDir}, {"existing/dir/newfile.txt", "new content", 0644, tar.TypeReg}, } for _, file := range files { hdr := &tar.Header{ Name: file.Name, Typeflag: file.TypeFlag, Mode: file.Mode, Size: int64(len(file.Body)), } if err := tw.WriteHeader(hdr); err != nil { t.Fatal(err) } if file.TypeFlag == tar.TypeReg { if _, err := tw.Write([]byte(file.Body)); err != nil { t.Fatal(err) } } } if err := tw.Close(); err != nil { t.Fatal(err) } var buf bytes.Buffer gz := gzip.NewWriter(&buf) if _, err := gz.Write(tarbuf.Bytes()); err != nil { t.Fatal(err) } gz.Close() extractor, err := NewExtractor(source) if err != nil { t.Fatal(err) } // Extract to directory with existing content if err = extractor.Extract(&buf, cacheDir); err != nil { t.Fatalf("Extraction to directory with existing content failed: %v", err) } // Verify new file was created newFile := filepath.Join(cacheDir, "existing", "dir", "newfile.txt") if _, err := os.Stat(newFile); err != nil { t.Fatalf("Expected new file %s to exist but got error: %v", newFile, err) } // Verify existing file is still there if _, err := os.Stat(existingFile); err != nil { t.Fatalf("Expected existing file %s to still exist but got error: %v", existingFile, err) } } func TestExtractPluginInSubdirectory(t *testing.T) { ensure.HelmHome(t) source := "https://repo.localdomain/plugins/subdir-plugin-1.0.0.tar.gz" tempDir := t.TempDir() // Create a tarball where plugin files are in a subdirectory var tarbuf bytes.Buffer tw := tar.NewWriter(&tarbuf) files := []struct { Name string Body string Mode int64 TypeFlag byte }{ {"my-plugin/", "", 0755, tar.TypeDir}, {"my-plugin/plugin.yaml", "name: my-plugin\nversion: 1.0.0\nusage: test\ndescription: test plugin\ncommand: $HELM_PLUGIN_DIR/bin/my-plugin", 0644, tar.TypeReg}, {"my-plugin/bin/", "", 0755, tar.TypeDir}, {"my-plugin/bin/my-plugin", "#!/usr/bin/env sh\necho test", 0755, tar.TypeReg}, } for _, file := range files { hdr := &tar.Header{ Name: file.Name, Typeflag: file.TypeFlag, Mode: file.Mode, Size: int64(len(file.Body)), } if err := tw.WriteHeader(hdr); err != nil { t.Fatal(err) } if file.TypeFlag == tar.TypeReg { if _, err := tw.Write([]byte(file.Body)); err != nil { t.Fatal(err) } } } if err := tw.Close(); err != nil { t.Fatal(err) } var buf bytes.Buffer gz := gzip.NewWriter(&buf) if _, err := gz.Write(tarbuf.Bytes()); err != nil { t.Fatal(err) } gz.Close() // Test the installer installer := &HTTPInstaller{ CacheDir: tempDir, PluginName: "subdir-plugin", base: newBase(source), extractor: &TarGzExtractor{}, } // Create a mock getter installer.getter = &TestHTTPGetter{ MockResponse: &buf, } // Ensure the destination directory doesn't exist // (In a real scenario, this is handled by installer.Install() wrapper) destPath := installer.Path() if err := os.RemoveAll(destPath); err != nil { t.Fatalf("Failed to clean destination path: %v", err) } // Install should handle the subdirectory correctly if err := installer.Install(); err != nil { t.Fatalf("Failed to install plugin with subdirectory: %v", err) } // The plugin should be installed from the subdirectory // Check that detectPluginRoot found the correct location pluginRoot, err := detectPluginRoot(tempDir) if err != nil { t.Fatalf("Failed to detect plugin root: %v", err) } expectedRoot := filepath.Join(tempDir, "my-plugin") if pluginRoot != expectedRoot { t.Errorf("Expected plugin root to be %s but got %s", expectedRoot, pluginRoot) } }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/installer/vcs_installer_test.go
internal/plugin/installer/vcs_installer_test.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package installer // import "helm.sh/helm/v4/internal/plugin/installer" import ( "fmt" "os" "path/filepath" "strings" "testing" "github.com/Masterminds/vcs" "helm.sh/helm/v4/internal/test/ensure" "helm.sh/helm/v4/pkg/helmpath" ) var _ Installer = new(VCSInstaller) type testRepo struct { local, remote, current string tags, branches []string err error vcs.Repo } func (r *testRepo) LocalPath() string { return r.local } func (r *testRepo) Remote() string { return r.remote } func (r *testRepo) Update() error { return r.err } func (r *testRepo) Get() error { return r.err } func (r *testRepo) IsReference(string) bool { return false } func (r *testRepo) Tags() ([]string, error) { return r.tags, r.err } func (r *testRepo) Branches() ([]string, error) { return r.branches, r.err } func (r *testRepo) UpdateVersion(version string) error { r.current = version return r.err } func TestVCSInstaller(t *testing.T) { ensure.HelmHome(t) if err := os.MkdirAll(helmpath.DataPath("plugins"), 0755); err != nil { t.Fatalf("Could not create %s: %s", helmpath.DataPath("plugins"), err) } source := "https://github.com/adamreese/helm-env" testRepoPath, _ := filepath.Abs("../testdata/plugdir/good/echo-v1") repo := &testRepo{ local: testRepoPath, tags: []string{"0.1.0", "0.1.1"}, } i, err := NewForSource(source, "~0.1.0") if err != nil { t.Fatalf("unexpected error: %s", err) } // ensure a VCSInstaller was returned vcsInstaller, ok := i.(*VCSInstaller) if !ok { t.Fatal("expected a VCSInstaller") } // set the testRepo in the VCSInstaller vcsInstaller.Repo = repo if err := Install(i); err != nil { t.Fatal(err) } if repo.current != "0.1.1" { t.Fatalf("expected version '0.1.1', got %q", repo.current) } expectedPath := helmpath.DataPath("plugins", "helm-env") if i.Path() != expectedPath { t.Fatalf("expected path %q, got %q", expectedPath, i.Path()) } // Install again to test plugin exists error if err := Install(i); err == nil { t.Fatalf("expected error for plugin exists, got none") } else if err.Error() != "plugin already exists" { t.Fatalf("expected error for plugin exists, got (%v)", err) } // Testing FindSource method, expect error because plugin code is not a cloned repository if _, err := FindSource(i.Path()); err == nil { t.Fatalf("expected error for inability to find plugin source, got none") } else if err.Error() != "cannot get information about plugin source" { t.Fatalf("expected error for inability to find plugin source, got (%v)", err) } } func TestVCSInstallerNonExistentVersion(t *testing.T) { ensure.HelmHome(t) source := "https://github.com/adamreese/helm-env" version := "0.2.0" i, err := NewForSource(source, version) if err != nil { t.Fatalf("unexpected error: %s", err) } // ensure a VCSInstaller was returned if _, ok := i.(*VCSInstaller); !ok { t.Fatal("expected a VCSInstaller") } if err := Install(i); err == nil { t.Fatalf("expected error for version does not exists, got none") } else if strings.Contains(err.Error(), "Could not resolve host: github.com") { t.Skip("Unable to run test without Internet access") } else if err.Error() != fmt.Sprintf("requested version %q does not exist for plugin %q", version, source) { t.Fatalf("expected error for version does not exists, got (%v)", err) } } func TestVCSInstallerUpdate(t *testing.T) { ensure.HelmHome(t) source := "https://github.com/adamreese/helm-env" i, err := NewForSource(source, "") if err != nil { t.Fatalf("unexpected error: %s", err) } // ensure a VCSInstaller was returned if _, ok := i.(*VCSInstaller); !ok { t.Fatal("expected a VCSInstaller") } if err := Update(i); err == nil { t.Fatal("expected error for plugin does not exist, got none") } else if err.Error() != "plugin does not exist" { t.Fatalf("expected error for plugin does not exist, got (%v)", err) } // Install plugin before update if err := Install(i); err != nil { if strings.Contains(err.Error(), "Could not resolve host: github.com") { t.Skip("Unable to run test without Internet access") } else { t.Fatal(err) } } // Test FindSource method for positive result pluginInfo, err := FindSource(i.Path()) if err != nil { t.Fatal(err) } vcsInstaller := pluginInfo.(*VCSInstaller) repoRemote := vcsInstaller.Repo.Remote() if repoRemote != source { t.Fatalf("invalid source found, expected %q got %q", source, repoRemote) } // Update plugin if err := Update(i); err != nil { t.Fatal(err) } // Test update failure if err := os.Remove(filepath.Join(vcsInstaller.Repo.LocalPath(), "plugin.yaml")); err != nil { t.Fatal(err) } // Testing update for error if err := Update(vcsInstaller); err == nil { t.Fatalf("expected error for plugin modified, got none") } else if err.Error() != "plugin repo was modified" { t.Fatalf("expected error for plugin modified, got (%v)", err) } }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/installer/oci_installer.go
internal/plugin/installer/oci_installer.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package installer import ( "archive/tar" "bytes" "compress/gzip" "errors" "fmt" "io" "log/slog" "os" "path/filepath" "helm.sh/helm/v4/internal/plugin" "helm.sh/helm/v4/internal/plugin/cache" "helm.sh/helm/v4/internal/third_party/dep/fs" "helm.sh/helm/v4/pkg/cli" "helm.sh/helm/v4/pkg/getter" "helm.sh/helm/v4/pkg/helmpath" "helm.sh/helm/v4/pkg/registry" ) // Ensure OCIInstaller implements Verifier var _ Verifier = (*OCIInstaller)(nil) // OCIInstaller installs plugins from OCI registries type OCIInstaller struct { CacheDir string PluginName string base settings *cli.EnvSettings getter getter.Getter // Cached data to avoid duplicate downloads pluginData []byte provData []byte } // NewOCIInstaller creates a new OCIInstaller with optional getter options func NewOCIInstaller(source string, options ...getter.Option) (*OCIInstaller, error) { // Extract plugin name from OCI reference using robust registry parsing pluginName, err := registry.GetPluginName(source) if err != nil { return nil, err } key, err := cache.Key(source) if err != nil { return nil, err } settings := cli.New() // Always add plugin artifact type and any provided options pluginOptions := append([]getter.Option{getter.WithArtifactType("plugin")}, options...) getterProvider, err := getter.NewOCIGetter(pluginOptions...) if err != nil { return nil, err } i := &OCIInstaller{ CacheDir: helmpath.CachePath("plugins", key), PluginName: pluginName, base: newBase(source), settings: settings, getter: getterProvider, } return i, nil } // Install downloads and installs a plugin from OCI registry // Implements Installer. func (i *OCIInstaller) Install() error { slog.Debug("pulling OCI plugin", "source", i.Source) // Ensure plugin data is cached if i.pluginData == nil { pluginData, err := i.getter.Get(i.Source) if err != nil { return fmt.Errorf("failed to pull plugin from %s: %w", i.Source, err) } i.pluginData = pluginData.Bytes() } // Extract metadata to get the actual plugin name and version metadata, err := plugin.ExtractTgzPluginMetadata(bytes.NewReader(i.pluginData)) if err != nil { return fmt.Errorf("failed to extract plugin metadata from tarball: %w", err) } filename := fmt.Sprintf("%s-%s.tgz", metadata.Name, metadata.Version) tarballPath := helmpath.DataPath("plugins", filename) if err := os.MkdirAll(filepath.Dir(tarballPath), 0755); err != nil { return fmt.Errorf("failed to create plugins directory: %w", err) } if err := os.WriteFile(tarballPath, i.pluginData, 0644); err != nil { return fmt.Errorf("failed to save tarball: %w", err) } // Ensure prov data is cached if available if i.provData == nil { // Try to download .prov file if it exists provSource := i.Source + ".prov" if provData, err := i.getter.Get(provSource); err == nil { i.provData = provData.Bytes() } } // Save prov file if we have the data if i.provData != nil { provPath := tarballPath + ".prov" if err := os.WriteFile(provPath, i.provData, 0644); err != nil { slog.Debug("failed to save provenance file", "error", err) } } // Check if this is a gzip compressed file if len(i.pluginData) < 2 || i.pluginData[0] != 0x1f || i.pluginData[1] != 0x8b { return fmt.Errorf("plugin data is not a gzip compressed archive") } // Create cache directory if err := os.MkdirAll(i.CacheDir, 0755); err != nil { return fmt.Errorf("failed to create cache directory: %w", err) } // Extract as gzipped tar if err := extractTarGz(bytes.NewReader(i.pluginData), i.CacheDir); err != nil { return fmt.Errorf("failed to extract plugin: %w", err) } // Verify plugin.yaml exists - check root and subdirectories pluginDir := i.CacheDir if !isPlugin(pluginDir) { // Check if plugin.yaml is in a subdirectory entries, err := os.ReadDir(i.CacheDir) if err != nil { return err } foundPluginDir := "" for _, entry := range entries { if entry.IsDir() { subDir := filepath.Join(i.CacheDir, entry.Name()) if isPlugin(subDir) { foundPluginDir = subDir break } } } if foundPluginDir == "" { return ErrMissingMetadata } // Use the subdirectory as the plugin directory pluginDir = foundPluginDir } // Copy from cache to final destination src, err := filepath.Abs(pluginDir) if err != nil { return err } slog.Debug("copying", "source", src, "path", i.Path()) return fs.CopyDir(src, i.Path()) } // Update updates a plugin by reinstalling it func (i *OCIInstaller) Update() error { // For OCI, update means removing the old version and installing the new one if err := os.RemoveAll(i.Path()); err != nil { return err } return i.Install() } // Path is where the plugin will be installed func (i OCIInstaller) Path() string { if i.Source == "" { return "" } return filepath.Join(i.settings.PluginsDirectory, i.PluginName) } // extractTarGz extracts a gzipped tar archive to a directory func extractTarGz(r io.Reader, targetDir string) error { gzr, err := gzip.NewReader(r) if err != nil { return err } defer gzr.Close() return extractTar(gzr, targetDir) } // extractTar extracts a tar archive to a directory func extractTar(r io.Reader, targetDir string) error { tarReader := tar.NewReader(r) for { header, err := tarReader.Next() if errors.Is(err, io.EOF) { break } if err != nil { return err } path, err := cleanJoin(targetDir, header.Name) if err != nil { return err } switch header.Typeflag { case tar.TypeDir: if err := os.MkdirAll(path, 0755); err != nil { return err } case tar.TypeReg: dir := filepath.Dir(path) if err := os.MkdirAll(dir, 0755); err != nil { return err } outFile, err := os.OpenFile(path, os.O_CREATE|os.O_RDWR, os.FileMode(header.Mode)) if err != nil { return err } defer outFile.Close() if _, err := io.Copy(outFile, tarReader); err != nil { return err } case tar.TypeXGlobalHeader, tar.TypeXHeader: // Skip these continue default: return fmt.Errorf("unknown type: %b in %s", header.Typeflag, header.Name) } } return nil } // SupportsVerification returns true since OCI plugins can be verified func (i *OCIInstaller) SupportsVerification() bool { return true } // GetVerificationData downloads and caches plugin and provenance data from OCI registry for verification func (i *OCIInstaller) GetVerificationData() (archiveData, provData []byte, filename string, err error) { slog.Debug("getting verification data for OCI plugin", "source", i.Source) // Download plugin data once and cache it if i.pluginData == nil { pluginDataBuffer, err := i.getter.Get(i.Source) if err != nil { return nil, nil, "", fmt.Errorf("failed to pull plugin from %s: %w", i.Source, err) } i.pluginData = pluginDataBuffer.Bytes() } // Download prov data once and cache it if available if i.provData == nil { provSource := i.Source + ".prov" // Calling getter.Get again is reasonable because: 1. The OCI registry client already optimizes the underlying network calls // 2. Both calls use the same underlying manifest and memory store 3. The second .prov call is very fast since the data is already pulled provDataBuffer, err := i.getter.Get(provSource) if err != nil { // If provenance file doesn't exist, set provData to nil // The verification logic will handle this gracefully i.provData = nil } else { i.provData = provDataBuffer.Bytes() } } // Extract metadata to get the filename metadata, err := plugin.ExtractTgzPluginMetadata(bytes.NewReader(i.pluginData)) if err != nil { return nil, nil, "", fmt.Errorf("failed to extract plugin metadata from tarball: %w", err) } filename = fmt.Sprintf("%s-%s.tgz", metadata.Name, metadata.Version) slog.Debug("got verification data for OCI plugin", "filename", filename) return i.pluginData, i.provData, filename, nil }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/installer/installer.go
internal/plugin/installer/installer.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package installer import ( "errors" "fmt" "log/slog" "net/http" "os" "path/filepath" "strings" "helm.sh/helm/v4/internal/plugin" "helm.sh/helm/v4/pkg/registry" ) // ErrMissingMetadata indicates that plugin.yaml is missing. var ErrMissingMetadata = errors.New("plugin metadata (plugin.yaml) missing") // Options contains options for plugin installation. type Options struct { // Verify enables signature verification before installation Verify bool // Keyring is the path to the keyring for verification Keyring string } // Installer provides an interface for installing helm client plugins. type Installer interface { // Install adds a plugin. Install() error // Path is the directory of the installed plugin. Path() string // Update updates a plugin. Update() error } // Verifier provides an interface for installers that support verification. type Verifier interface { // SupportsVerification returns true if this installer can verify plugins SupportsVerification() bool // GetVerificationData returns plugin and provenance data for verification GetVerificationData() (archiveData, provData []byte, filename string, err error) } // Install installs a plugin. func Install(i Installer) error { _, err := InstallWithOptions(i, Options{}) return err } // VerificationResult contains the result of plugin verification type VerificationResult struct { SignedBy []string Fingerprint string FileHash string } // InstallWithOptions installs a plugin with options. func InstallWithOptions(i Installer, opts Options) (*VerificationResult, error) { if err := os.MkdirAll(filepath.Dir(i.Path()), 0755); err != nil { return nil, err } if _, pathErr := os.Stat(i.Path()); !os.IsNotExist(pathErr) { slog.Warn("plugin already exists", slog.String("path", i.Path()), slog.Any("error", pathErr)) return nil, errors.New("plugin already exists") } var result *VerificationResult // If verification is requested, check if installer supports it if opts.Verify { verifier, ok := i.(Verifier) if !ok || !verifier.SupportsVerification() { return nil, fmt.Errorf("--verify is only supported for plugin tarballs (.tgz files)") } // Get verification data (works for both memory and file-based installers) archiveData, provData, filename, err := verifier.GetVerificationData() if err != nil { return nil, fmt.Errorf("failed to get verification data: %w", err) } // Check if provenance data exists if len(provData) == 0 { // No .prov file found - emit warning but continue installation fmt.Fprintf(os.Stderr, "WARNING: No provenance file found for plugin. Plugin is not signed and cannot be verified.\n") } else { // Provenance data exists - verify the plugin verification, err := plugin.VerifyPlugin(archiveData, provData, filename, opts.Keyring) if err != nil { return nil, fmt.Errorf("plugin verification failed: %w", err) } // Collect verification info result = &VerificationResult{ SignedBy: make([]string, 0), Fingerprint: fmt.Sprintf("%X", verification.SignedBy.PrimaryKey.Fingerprint), FileHash: verification.FileHash, } for name := range verification.SignedBy.Identities { result.SignedBy = append(result.SignedBy, name) } } } if err := i.Install(); err != nil { return nil, err } return result, nil } // Update updates a plugin. func Update(i Installer) error { if _, pathErr := os.Stat(i.Path()); os.IsNotExist(pathErr) { slog.Warn("plugin does not exist", slog.String("path", i.Path()), slog.Any("error", pathErr)) return errors.New("plugin does not exist") } return i.Update() } // NewForSource determines the correct Installer for the given source. func NewForSource(source, version string) (installer Installer, err error) { if strings.HasPrefix(source, fmt.Sprintf("%s://", registry.OCIScheme)) { // Source is an OCI registry reference installer, err = NewOCIInstaller(source) } else if isLocalReference(source) { // Source is a local directory installer, err = NewLocalInstaller(source) } else if isRemoteHTTPArchive(source) { installer, err = NewHTTPInstaller(source) } else { installer, err = NewVCSInstaller(source, version) } if err != nil { return installer, fmt.Errorf("cannot get information about plugin source %q (if it's a local directory, does it exist?), last error was: %w", source, err) } return } // FindSource determines the correct Installer for the given source. func FindSource(location string) (Installer, error) { installer, err := existingVCSRepo(location) if err != nil && err.Error() == "Cannot detect VCS" { slog.Warn( "cannot get information about plugin source", slog.String("location", location), slog.Any("error", err), ) return installer, errors.New("cannot get information about plugin source") } return installer, err } // isLocalReference checks if the source exists on the filesystem. func isLocalReference(source string) bool { _, err := os.Stat(source) return err == nil } // isRemoteHTTPArchive checks if the source is a http/https url and is an archive // // It works by checking whether the source looks like a URL and, if it does, running a // HEAD operation to see if the remote resource is a file that we understand. func isRemoteHTTPArchive(source string) bool { if strings.HasPrefix(source, "http://") || strings.HasPrefix(source, "https://") { // First, check if the URL ends with a known archive suffix // This is more reliable than content-type detection for suffix := range Extractors { if strings.HasSuffix(source, suffix) { return true } } // If no suffix match, try HEAD request to check content type res, err := http.Head(source) if err != nil { // If we get an error at the network layer, we can't install it. So // we return false. return false } // Next, we look for the content type or content disposition headers to see // if they have matching extractors. contentType := res.Header.Get("content-type") foundSuffix, ok := mediaTypeToExtension(contentType) if !ok { // Media type not recognized return false } for suffix := range Extractors { if strings.HasSuffix(foundSuffix, suffix) { return true } } } return false } // isPlugin checks if the directory contains a plugin.yaml file. func isPlugin(dirname string) bool { _, err := os.Stat(filepath.Join(dirname, plugin.PluginFileName)) return err == nil }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/installer/base_test.go
internal/plugin/installer/base_test.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package installer // import "helm.sh/helm/v4/internal/plugin/installer" import ( "testing" ) func TestPath(t *testing.T) { tests := []struct { source string helmPluginsDir string expectPath string }{ { source: "", helmPluginsDir: "/helm/data/plugins", expectPath: "", }, { source: "https://github.com/jkroepke/helm-secrets", helmPluginsDir: "/helm/data/plugins", expectPath: "/helm/data/plugins/helm-secrets", }, } for _, tt := range tests { t.Setenv("HELM_PLUGINS", tt.helmPluginsDir) baseIns := newBase(tt.source) baseInsPath := baseIns.Path() if baseInsPath != tt.expectPath { t.Errorf("expected name %s, got %s", tt.expectPath, baseInsPath) } } }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/installer/installer_test.go
internal/plugin/installer/installer_test.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package installer import "testing" func TestIsRemoteHTTPArchive(t *testing.T) { srv := mockArchiveServer() defer srv.Close() source := srv.URL + "/plugins/fake-plugin-0.0.1.tar.gz" if isRemoteHTTPArchive("/not/a/URL") { t.Errorf("Expected non-URL to return false") } // URLs with valid archive extensions are considered valid archives // even if the server is unreachable (optimization to avoid unnecessary HTTP requests) if !isRemoteHTTPArchive("https://127.0.0.1:123/fake/plugin-1.2.3.tgz") { t.Errorf("URL with .tgz extension should be considered a valid archive") } // Test with invalid extension and unreachable server if isRemoteHTTPArchive("https://127.0.0.1:123/fake/plugin-1.2.3.notanarchive") { t.Errorf("Bad URL without valid extension should not succeed") } if !isRemoteHTTPArchive(source) { t.Errorf("Expected %q to be a valid archive URL", source) } if isRemoteHTTPArchive(source + "-not-an-extension") { t.Error("Expected media type match to fail") } }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/installer/vcs_installer.go
internal/plugin/installer/vcs_installer.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package installer // import "helm.sh/helm/v4/internal/plugin/installer" import ( "errors" "fmt" stdfs "io/fs" "log/slog" "os" "sort" "github.com/Masterminds/semver/v3" "github.com/Masterminds/vcs" "helm.sh/helm/v4/internal/plugin/cache" "helm.sh/helm/v4/internal/third_party/dep/fs" "helm.sh/helm/v4/pkg/helmpath" ) // VCSInstaller installs plugins from remote a repository. type VCSInstaller struct { Repo vcs.Repo Version string base } func existingVCSRepo(location string) (Installer, error) { repo, err := vcs.NewRepo("", location) if err != nil { return nil, err } i := &VCSInstaller{ Repo: repo, base: newBase(repo.Remote()), } return i, nil } // NewVCSInstaller creates a new VCSInstaller. func NewVCSInstaller(source, version string) (*VCSInstaller, error) { key, err := cache.Key(source) if err != nil { return nil, err } cachedpath := helmpath.CachePath("plugins", key) repo, err := vcs.NewRepo(source, cachedpath) if err != nil { return nil, err } i := &VCSInstaller{ Repo: repo, Version: version, base: newBase(source), } return i, nil } // Install clones a remote repository and installs into the plugin directory. // // Implements Installer. func (i *VCSInstaller) Install() error { if err := i.sync(i.Repo); err != nil { return err } ref, err := i.solveVersion(i.Repo) if err != nil { return err } if ref != "" { if err := i.setVersion(i.Repo, ref); err != nil { return err } } if !isPlugin(i.Repo.LocalPath()) { return ErrMissingMetadata } slog.Debug("copying files", "source", i.Repo.LocalPath(), "destination", i.Path()) return fs.CopyDir(i.Repo.LocalPath(), i.Path()) } // Update updates a remote repository func (i *VCSInstaller) Update() error { slog.Debug("updating", "source", i.Repo.Remote()) if i.Repo.IsDirty() { return errors.New("plugin repo was modified") } if err := i.Repo.Update(); err != nil { return err } if !isPlugin(i.Repo.LocalPath()) { return ErrMissingMetadata } return nil } func (i *VCSInstaller) solveVersion(repo vcs.Repo) (string, error) { if i.Version == "" { return "", nil } if repo.IsReference(i.Version) { return i.Version, nil } // Create the constraint first to make sure it's valid before // working on the repo. constraint, err := semver.NewConstraint(i.Version) if err != nil { return "", err } // Get the tags refs, err := repo.Tags() if err != nil { return "", err } slog.Debug("found refs", "refs", refs) // Convert and filter the list to semver.Version instances semvers := getSemVers(refs) // Sort semver list sort.Sort(sort.Reverse(semver.Collection(semvers))) for _, v := range semvers { if constraint.Check(v) { // If the constraint passes get the original reference ver := v.Original() slog.Debug("setting to version", "version", ver) return ver, nil } } return "", fmt.Errorf("requested version %q does not exist for plugin %q", i.Version, i.Repo.Remote()) } // setVersion attempts to checkout the version func (i *VCSInstaller) setVersion(repo vcs.Repo, ref string) error { slog.Debug("setting version", "version", i.Version) return repo.UpdateVersion(ref) } // sync will clone or update a remote repo. func (i *VCSInstaller) sync(repo vcs.Repo) error { if _, err := os.Stat(repo.LocalPath()); errors.Is(err, stdfs.ErrNotExist) { slog.Debug("cloning", "source", repo.Remote(), "destination", repo.LocalPath()) return repo.Get() } slog.Debug("updating", "source", repo.Remote(), "destination", repo.LocalPath()) return repo.Update() } // Filter a list of versions to only included semantic versions. The response // is a mapping of the original version to the semantic version. func getSemVers(refs []string) []*semver.Version { var sv []*semver.Version for _, r := range refs { if v, err := semver.NewVersion(r); err == nil { sv = append(sv, v) } } return sv }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/installer/extractor.go
internal/plugin/installer/extractor.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package installer // import "helm.sh/helm/v4/internal/plugin/installer" import ( "archive/tar" "bytes" "compress/gzip" "errors" "fmt" "io" "os" "path" "path/filepath" "regexp" "slices" "strings" securejoin "github.com/cyphar/filepath-securejoin" ) // TarGzExtractor extracts gzip compressed tar archives type TarGzExtractor struct{} // Extractor provides an interface for extracting archives type Extractor interface { Extract(buffer *bytes.Buffer, targetDir string) error } // Extractors contains a map of suffixes and matching implementations of extractor to return var Extractors = map[string]Extractor{ ".tar.gz": &TarGzExtractor{}, ".tgz": &TarGzExtractor{}, } // Convert a media type to an extractor extension. // // This should be refactored in Helm 4, combined with the extension-based mechanism. func mediaTypeToExtension(mt string) (string, bool) { switch strings.ToLower(mt) { case "application/gzip", "application/x-gzip", "application/x-tgz", "application/x-gtar": return ".tgz", true case "application/octet-stream": // Generic binary type - we'll need to check the URL suffix return "", false default: return "", false } } // NewExtractor creates a new extractor matching the source file name func NewExtractor(source string) (Extractor, error) { for suffix, extractor := range Extractors { if strings.HasSuffix(source, suffix) { return extractor, nil } } return nil, fmt.Errorf("no extractor implemented yet for %s", source) } // cleanJoin resolves dest as a subpath of root. // // This function runs several security checks on the path, generating an error if // the supplied `dest` looks suspicious or would result in dubious behavior on the // filesystem. // // cleanJoin assumes that any attempt by `dest` to break out of the CWD is an attempt // to be malicious. (If you don't care about this, use the securejoin-filepath library.) // It will emit an error if it detects paths that _look_ malicious, operating on the // assumption that we don't actually want to do anything with files that already // appear to be nefarious. // // - The character `:` is considered illegal because it is a separator on UNIX and a // drive designator on Windows. // - The path component `..` is considered suspicious, and therefore illegal // - The character \ (backslash) is treated as a path separator and is converted to /. // - Beginning a path with a path separator is illegal // - Rudimentary symlink protections are offered by SecureJoin. func cleanJoin(root, dest string) (string, error) { // On Windows, this is a drive separator. On UNIX-like, this is the path list separator. // In neither case do we want to trust a TAR that contains these. if strings.Contains(dest, ":") { return "", errors.New("path contains ':', which is illegal") } // The Go tar library does not convert separators for us. // We assume here, as we do elsewhere, that `\\` means a Windows path. dest = strings.ReplaceAll(dest, "\\", "/") // We want to alert the user that something bad was attempted. Cleaning it // is not a good practice. if slices.Contains(strings.Split(dest, "/"), "..") { return "", errors.New("path contains '..', which is illegal") } // If a path is absolute, the creator of the TAR is doing something shady. if path.IsAbs(dest) { return "", errors.New("path is absolute, which is illegal") } // SecureJoin will do some cleaning, as well as some rudimentary checking of symlinks. // The directory needs to be cleaned prior to passing to SecureJoin or the location may end up // being wrong or returning an error. This was introduced in v0.4.0. root = filepath.Clean(root) newpath, err := securejoin.SecureJoin(root, dest) if err != nil { return "", err } return filepath.ToSlash(newpath), nil } // Extract extracts compressed archives // // Implements Extractor. func (g *TarGzExtractor) Extract(buffer *bytes.Buffer, targetDir string) error { uncompressedStream, err := gzip.NewReader(buffer) if err != nil { return err } if err := os.MkdirAll(targetDir, 0755); err != nil { return err } tarReader := tar.NewReader(uncompressedStream) for { header, err := tarReader.Next() if errors.Is(err, io.EOF) { break } if err != nil { return err } path, err := cleanJoin(targetDir, header.Name) if err != nil { return err } switch header.Typeflag { case tar.TypeDir: if err := os.MkdirAll(path, 0755); err != nil { return err } case tar.TypeReg: // Ensure parent directory exists if err := os.MkdirAll(filepath.Dir(path), 0755); err != nil { return err } outFile, err := os.OpenFile(path, os.O_CREATE|os.O_RDWR, os.FileMode(header.Mode)) if err != nil { return err } if _, err := io.Copy(outFile, tarReader); err != nil { outFile.Close() return err } outFile.Close() // We don't want to process these extension header files. case tar.TypeXGlobalHeader, tar.TypeXHeader: continue default: return fmt.Errorf("unknown type: %b in %s", header.Typeflag, header.Name) } } return nil } // stripPluginName is a helper that relies on some sort of convention for plugin name (plugin-name-<version>) func stripPluginName(name string) string { var strippedName string for suffix := range Extractors { if before, ok := strings.CutSuffix(name, suffix); ok { strippedName = before break } } re := regexp.MustCompile(`(.*)-[0-9]+\..*`) return re.ReplaceAllString(strippedName, `$1`) }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/installer/http_installer.go
internal/plugin/installer/http_installer.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package installer // import "helm.sh/helm/v4/internal/plugin/installer" import ( "bytes" "fmt" "log/slog" "os" "path/filepath" "strings" "helm.sh/helm/v4/internal/plugin" "helm.sh/helm/v4/internal/plugin/cache" "helm.sh/helm/v4/internal/third_party/dep/fs" "helm.sh/helm/v4/pkg/cli" "helm.sh/helm/v4/pkg/getter" "helm.sh/helm/v4/pkg/helmpath" ) // HTTPInstaller installs plugins from an archive served by a web server. type HTTPInstaller struct { CacheDir string PluginName string base extractor Extractor getter getter.Getter // Cached data to avoid duplicate downloads pluginData []byte provData []byte } // NewHTTPInstaller creates a new HttpInstaller. func NewHTTPInstaller(source string) (*HTTPInstaller, error) { key, err := cache.Key(source) if err != nil { return nil, err } extractor, err := NewExtractor(source) if err != nil { return nil, err } get, err := getter.All(new(cli.EnvSettings)).ByScheme("http") if err != nil { return nil, err } i := &HTTPInstaller{ CacheDir: helmpath.CachePath("plugins", key), PluginName: stripPluginName(filepath.Base(source)), base: newBase(source), extractor: extractor, getter: get, } return i, nil } // Install downloads and extracts the tarball into the cache directory // and installs into the plugin directory. // // Implements Installer. func (i *HTTPInstaller) Install() error { // Ensure plugin data is cached if i.pluginData == nil { pluginData, err := i.getter.Get(i.Source) if err != nil { return err } i.pluginData = pluginData.Bytes() } // Save the original tarball to plugins directory for verification // Extract metadata to get the actual plugin name and version metadata, err := plugin.ExtractTgzPluginMetadata(bytes.NewReader(i.pluginData)) if err != nil { return fmt.Errorf("failed to extract plugin metadata from tarball: %w", err) } filename := fmt.Sprintf("%s-%s.tgz", metadata.Name, metadata.Version) tarballPath := helmpath.DataPath("plugins", filename) if err := os.MkdirAll(filepath.Dir(tarballPath), 0755); err != nil { return fmt.Errorf("failed to create plugins directory: %w", err) } if err := os.WriteFile(tarballPath, i.pluginData, 0644); err != nil { return fmt.Errorf("failed to save tarball: %w", err) } // Ensure prov data is cached if available if i.provData == nil { // Try to download .prov file if it exists provURL := i.Source + ".prov" if provData, err := i.getter.Get(provURL); err == nil { i.provData = provData.Bytes() } } // Save prov file if we have the data if i.provData != nil { provPath := tarballPath + ".prov" if err := os.WriteFile(provPath, i.provData, 0644); err != nil { slog.Debug("failed to save provenance file", "error", err) } } if err := i.extractor.Extract(bytes.NewBuffer(i.pluginData), i.CacheDir); err != nil { return fmt.Errorf("extracting files from archive: %w", err) } // Detect where the plugin.yaml actually is pluginRoot, err := detectPluginRoot(i.CacheDir) if err != nil { return err } // Validate plugin structure if needed if err := validatePluginName(pluginRoot, i.PluginName); err != nil { return err } src, err := filepath.Abs(pluginRoot) if err != nil { return err } slog.Debug("copying", "source", src, "path", i.Path()) return fs.CopyDir(src, i.Path()) } // Update updates a local repository // Not implemented for now since tarball most likely will be packaged by version func (i *HTTPInstaller) Update() error { return fmt.Errorf("method Update() not implemented for HttpInstaller") } // Path is overridden because we want to join on the plugin name not the file name func (i HTTPInstaller) Path() string { if i.Source == "" { return "" } return helmpath.DataPath("plugins", i.PluginName) } // SupportsVerification returns true if the HTTP installer can verify plugins func (i *HTTPInstaller) SupportsVerification() bool { // Only support verification for tarball URLs return strings.HasSuffix(i.Source, ".tgz") || strings.HasSuffix(i.Source, ".tar.gz") } // GetVerificationData returns cached plugin and provenance data for verification func (i *HTTPInstaller) GetVerificationData() (archiveData, provData []byte, filename string, err error) { if !i.SupportsVerification() { return nil, nil, "", fmt.Errorf("verification not supported for this source") } // Download plugin data once and cache it if i.pluginData == nil { data, err := i.getter.Get(i.Source) if err != nil { return nil, nil, "", fmt.Errorf("failed to download plugin: %w", err) } i.pluginData = data.Bytes() } // Download prov data once and cache it if available if i.provData == nil { provData, err := i.getter.Get(i.Source + ".prov") if err != nil { // If provenance file doesn't exist, set provData to nil // The verification logic will handle this gracefully i.provData = nil } else { i.provData = provData.Bytes() } } return i.pluginData, i.provData, filepath.Base(i.Source), nil }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/installer/local_installer_test.go
internal/plugin/installer/local_installer_test.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package installer // import "helm.sh/helm/v4/internal/plugin/installer" import ( "archive/tar" "bytes" "compress/gzip" "os" "path/filepath" "testing" "helm.sh/helm/v4/internal/test/ensure" "helm.sh/helm/v4/pkg/helmpath" ) var _ Installer = new(LocalInstaller) func TestLocalInstaller(t *testing.T) { ensure.HelmHome(t) // Make a temp dir tdir := t.TempDir() if err := os.WriteFile(filepath.Join(tdir, "plugin.yaml"), []byte{}, 0644); err != nil { t.Fatal(err) } source := "../testdata/plugdir/good/echo-v1" i, err := NewForSource(source, "") if err != nil { t.Fatalf("unexpected error: %s", err) } if err := Install(i); err != nil { t.Fatal(err) } if i.Path() != helmpath.DataPath("plugins", "echo-v1") { t.Fatalf("expected path '$XDG_CONFIG_HOME/helm/plugins/helm-env', got %q", i.Path()) } defer os.RemoveAll(filepath.Dir(helmpath.DataPath())) // helmpath.DataPath is like /tmp/helm013130971/helm } func TestLocalInstallerNotAFolder(t *testing.T) { source := "../testdata/plugdir/good/echo-v1/plugin.yaml" i, err := NewForSource(source, "") if err != nil { t.Fatalf("unexpected error: %s", err) } err = Install(i) if err == nil { t.Fatal("expected error") } if err != ErrPluginNotADirectory { t.Fatalf("expected error to equal: %q", err) } } func TestLocalInstallerTarball(t *testing.T) { ensure.HelmHome(t) // Create a test tarball tempDir := t.TempDir() tarballPath := filepath.Join(tempDir, "test-plugin-1.0.0.tar.gz") // Create tarball content var buf bytes.Buffer gw := gzip.NewWriter(&buf) tw := tar.NewWriter(gw) files := []struct { Name string Body string Mode int64 }{ {"test-plugin/plugin.yaml", "name: test-plugin\napiVersion: v1\ntype: cli/v1\nruntime: subprocess\nversion: 1.0.0\nconfig:\n shortHelp: test\n longHelp: test\nruntimeConfig:\n platformCommand:\n - command: echo", 0644}, {"test-plugin/bin/test-plugin", "#!/usr/bin/env sh\necho test", 0755}, } for _, file := range files { hdr := &tar.Header{ Name: file.Name, Mode: file.Mode, Size: int64(len(file.Body)), } if err := tw.WriteHeader(hdr); err != nil { t.Fatal(err) } if _, err := tw.Write([]byte(file.Body)); err != nil { t.Fatal(err) } } if err := tw.Close(); err != nil { t.Fatal(err) } if err := gw.Close(); err != nil { t.Fatal(err) } // Write tarball to file if err := os.WriteFile(tarballPath, buf.Bytes(), 0644); err != nil { t.Fatal(err) } // Test installation i, err := NewForSource(tarballPath, "") if err != nil { t.Fatalf("unexpected error: %s", err) } // Verify it's detected as LocalInstaller localInstaller, ok := i.(*LocalInstaller) if !ok { t.Fatal("expected LocalInstaller") } if !localInstaller.isArchive { t.Fatal("expected isArchive to be true") } if err := Install(i); err != nil { t.Fatal(err) } expectedPath := helmpath.DataPath("plugins", "test-plugin") if i.Path() != expectedPath { t.Fatalf("expected path %q, got %q", expectedPath, i.Path()) } // Verify plugin was installed if _, err := os.Stat(i.Path()); err != nil { t.Fatalf("plugin not found at %s: %v", i.Path(), err) } }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/installer/plugin_structure.go
internal/plugin/installer/plugin_structure.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package installer import ( "fmt" "os" "path/filepath" "strings" "helm.sh/helm/v4/internal/plugin" ) // detectPluginRoot searches for plugin.yaml in the extracted directory // and returns the path to the directory containing it. // This handles cases where the tarball contains the plugin in a subdirectory. func detectPluginRoot(extractDir string) (string, error) { // First check if plugin.yaml is at the root if _, err := os.Stat(filepath.Join(extractDir, plugin.PluginFileName)); err == nil { return extractDir, nil } // Otherwise, look for plugin.yaml in subdirectories (only one level deep) entries, err := os.ReadDir(extractDir) if err != nil { return "", err } for _, entry := range entries { if entry.IsDir() { subdir := filepath.Join(extractDir, entry.Name()) if _, err := os.Stat(filepath.Join(subdir, plugin.PluginFileName)); err == nil { return subdir, nil } } } return "", fmt.Errorf("plugin.yaml not found in %s or its immediate subdirectories", extractDir) } // validatePluginName checks if the plugin directory name matches the plugin name // from plugin.yaml when the plugin is in a subdirectory. func validatePluginName(pluginRoot string, expectedName string) error { // Only validate if plugin is in a subdirectory dirName := filepath.Base(pluginRoot) if dirName == expectedName { return nil } // Load plugin.yaml to get the actual name p, err := plugin.LoadDir(pluginRoot) if err != nil { return fmt.Errorf("failed to load plugin from %s: %w", pluginRoot, err) } m := p.Metadata() actualName := m.Name // For now, just log a warning if names don't match // In the future, we might want to enforce this more strictly if actualName != dirName && actualName != strings.TrimSuffix(expectedName, filepath.Ext(expectedName)) { // This is just informational - not an error return nil } return nil }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/installer/doc.go
internal/plugin/installer/doc.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ // Package installer provides an interface for installing Helm plugins. package installer // import "helm.sh/helm/v4/internal/plugin/installer"
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/plugin/installer/plugin_structure_test.go
internal/plugin/installer/plugin_structure_test.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package installer import ( "os" "path/filepath" "testing" ) func TestDetectPluginRoot(t *testing.T) { tests := []struct { name string setup func(dir string) error expectRoot string expectError bool }{ { name: "plugin.yaml at root", setup: func(dir string) error { return os.WriteFile(filepath.Join(dir, "plugin.yaml"), []byte("name: test"), 0644) }, expectRoot: ".", expectError: false, }, { name: "plugin.yaml in subdirectory", setup: func(dir string) error { subdir := filepath.Join(dir, "my-plugin") if err := os.MkdirAll(subdir, 0755); err != nil { return err } return os.WriteFile(filepath.Join(subdir, "plugin.yaml"), []byte("name: test"), 0644) }, expectRoot: "my-plugin", expectError: false, }, { name: "no plugin.yaml", setup: func(dir string) error { return os.WriteFile(filepath.Join(dir, "README.md"), []byte("test"), 0644) }, expectRoot: "", expectError: true, }, { name: "plugin.yaml in nested subdirectory (should not find)", setup: func(dir string) error { subdir := filepath.Join(dir, "outer", "inner") if err := os.MkdirAll(subdir, 0755); err != nil { return err } return os.WriteFile(filepath.Join(subdir, "plugin.yaml"), []byte("name: test"), 0644) }, expectRoot: "", expectError: true, }, } for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { dir := t.TempDir() if err := tt.setup(dir); err != nil { t.Fatalf("Setup failed: %v", err) } root, err := detectPluginRoot(dir) if tt.expectError { if err == nil { t.Error("Expected error but got none") } } else { if err != nil { t.Errorf("Unexpected error: %v", err) } expectedPath := dir if tt.expectRoot != "." { expectedPath = filepath.Join(dir, tt.expectRoot) } if root != expectedPath { t.Errorf("Expected root %s but got %s", expectedPath, root) } } }) } } func TestValidatePluginName(t *testing.T) { tests := []struct { name string setup func(dir string) error pluginRoot string expectedName string expectError bool }{ { name: "matching directory and plugin name", setup: func(dir string) error { subdir := filepath.Join(dir, "my-plugin") if err := os.MkdirAll(subdir, 0755); err != nil { return err } yaml := `name: my-plugin version: 1.0.0 usage: test description: test` return os.WriteFile(filepath.Join(subdir, "plugin.yaml"), []byte(yaml), 0644) }, pluginRoot: "my-plugin", expectedName: "my-plugin", expectError: false, }, { name: "different directory and plugin name", setup: func(dir string) error { subdir := filepath.Join(dir, "wrong-name") if err := os.MkdirAll(subdir, 0755); err != nil { return err } yaml := `name: my-plugin version: 1.0.0 usage: test description: test` return os.WriteFile(filepath.Join(subdir, "plugin.yaml"), []byte(yaml), 0644) }, pluginRoot: "wrong-name", expectedName: "wrong-name", expectError: false, // Currently we don't error on mismatch }, } for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { dir := t.TempDir() if err := tt.setup(dir); err != nil { t.Fatalf("Setup failed: %v", err) } pluginRoot := filepath.Join(dir, tt.pluginRoot) err := validatePluginName(pluginRoot, tt.expectedName) if tt.expectError { if err == nil { t.Error("Expected error but got none") } } else { if err != nil { t.Errorf("Unexpected error: %v", err) } } }) } }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/version/version.go
internal/version/version.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package version import ( "flag" "fmt" "log/slog" "runtime" "strings" "testing" "github.com/Masterminds/semver/v3" ) var ( // version is the current version of Helm. // Update this whenever making a new release. // The version is of the format Major.Minor.Patch[-Prerelease][+BuildMetadata] // // Increment major number for new feature additions and behavioral changes. // Increment minor number for bug fixes and performance enhancements. version = "v4.1" // metadata is extra build time data metadata = "" // gitCommit is the git sha1 gitCommit = "" // gitTreeState is the state of the git tree gitTreeState = "" ) const ( kubeClientGoVersionTesting = "v1.20" ) // BuildInfo describes the compile time information. type BuildInfo struct { // Version is the current semver. Version string `json:"version,omitempty"` // GitCommit is the git sha1. GitCommit string `json:"git_commit,omitempty"` // GitTreeState is the state of the git tree. GitTreeState string `json:"git_tree_state,omitempty"` // GoVersion is the version of the Go compiler used. GoVersion string `json:"go_version,omitempty"` // KubeClientVersion is the version of client-go Helm was build with KubeClientVersion string `json:"kube_client_version"` } // GetVersion returns the semver string of the version func GetVersion() string { if metadata == "" { return version } return version + "+" + metadata } // GetUserAgent returns a user agent for user with an HTTP client func GetUserAgent() string { return "Helm/" + strings.TrimPrefix(GetVersion(), "v") } // Get returns build info func Get() BuildInfo { makeKubeClientVersionString := func() string { // Test builds don't include debug info / module info // (And even if they did, we probably want a stable version during tests anyway) // Return a default value for test builds if testing.Testing() { return kubeClientGoVersionTesting } vstr, err := K8sIOClientGoModVersion() if err != nil { slog.Error("failed to retrieve k8s.io/client-go version", slog.Any("error", err)) return "" } v, err := semver.NewVersion(vstr) if err != nil { slog.Error("unable to parse k8s.io/client-go version", slog.String("version", vstr), slog.Any("error", err)) return "" } kubeClientVersionMajor := v.Major() + 1 kubeClientVersionMinor := v.Minor() return fmt.Sprintf("v%d.%d", kubeClientVersionMajor, kubeClientVersionMinor) } v := BuildInfo{ Version: GetVersion(), GitCommit: gitCommit, GitTreeState: gitTreeState, GoVersion: runtime.Version(), KubeClientVersion: makeKubeClientVersionString(), } // HACK(bacongobbler): strip out GoVersion during a test run for consistent test output if flag.Lookup("test.v") != nil { v.GoVersion = "" } return v }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/version/clientgo.go
internal/version/clientgo.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package version import ( "fmt" "runtime/debug" "slices" _ "k8s.io/client-go/kubernetes" // Force k8s.io/client-go to be included in the build ) func K8sIOClientGoModVersion() (string, error) { info, ok := debug.ReadBuildInfo() if !ok { return "", fmt.Errorf("failed to read build info") } idx := slices.IndexFunc(info.Deps, func(m *debug.Module) bool { return m.Path == "k8s.io/client-go" }) if idx == -1 { return "", fmt.Errorf("k8s.io/client-go not found in build info") } m := info.Deps[idx] return m.Version, nil }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/version/clientgo_test.go
internal/version/clientgo_test.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package version import ( "testing" "github.com/stretchr/testify/require" ) func TestK8sClientGoModVersion(t *testing.T) { // Unfortunately, test builds don't include debug info / module info // So we expect "K8sIOClientGoModVersion" to return error _, err := K8sIOClientGoModVersion() require.ErrorContains(t, err, "k8s.io/client-go not found in build info") }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/logging/logging.go
internal/logging/logging.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package logging import ( "context" "log/slog" "os" "sync/atomic" ) // DebugEnabledFunc is a function type that determines if debug logging is enabled // We use a function because we want to check the setting at log time, not when the logger is created type DebugEnabledFunc func() bool // DebugCheckHandler checks settings.Debug at log time type DebugCheckHandler struct { handler slog.Handler debugEnabled DebugEnabledFunc } // Enabled implements slog.Handler.Enabled func (h *DebugCheckHandler) Enabled(_ context.Context, level slog.Level) bool { if level == slog.LevelDebug { if h.debugEnabled == nil { return false } return h.debugEnabled() } return true // Always log other levels } // Handle implements slog.Handler.Handle func (h *DebugCheckHandler) Handle(ctx context.Context, r slog.Record) error { return h.handler.Handle(ctx, r) } // WithAttrs implements slog.Handler.WithAttrs func (h *DebugCheckHandler) WithAttrs(attrs []slog.Attr) slog.Handler { return &DebugCheckHandler{ handler: h.handler.WithAttrs(attrs), debugEnabled: h.debugEnabled, } } // WithGroup implements slog.Handler.WithGroup func (h *DebugCheckHandler) WithGroup(name string) slog.Handler { return &DebugCheckHandler{ handler: h.handler.WithGroup(name), debugEnabled: h.debugEnabled, } } // NewLogger creates a new logger with dynamic debug checking func NewLogger(debugEnabled DebugEnabledFunc) *slog.Logger { // Create base handler that removes timestamps baseHandler := slog.NewTextHandler(os.Stderr, &slog.HandlerOptions{ // Always use LevelDebug here to allow all messages through // Our custom handler will do the filtering Level: slog.LevelDebug, ReplaceAttr: func(_ []string, a slog.Attr) slog.Attr { // Remove the time attribute if a.Key == slog.TimeKey { return slog.Attr{} } return a }, }) // Wrap with our dynamic debug-checking handler dynamicHandler := &DebugCheckHandler{ handler: baseHandler, debugEnabled: debugEnabled, } return slog.New(dynamicHandler) } // LoggerSetterGetter is an interface that can set and get a logger type LoggerSetterGetter interface { // SetLogger sets a new slog.Handler SetLogger(newHandler slog.Handler) // Logger returns the slog.Logger created from the slog.Handler Logger() *slog.Logger } type LogHolder struct { // logger is an atomic.Pointer[slog.Logger] to store the slog.Logger // We use atomic.Pointer for thread safety logger atomic.Pointer[slog.Logger] } // Logger returns the logger for the LogHolder. If nil, returns slog.Default(). func (l *LogHolder) Logger() *slog.Logger { if lg := l.logger.Load(); lg != nil { return lg } return slog.New(slog.DiscardHandler) // Should never be reached } // SetLogger sets the logger for the LogHolder. If nil, sets the default logger. func (l *LogHolder) SetLogger(newHandler slog.Handler) { if newHandler == nil { l.logger.Store(slog.New(slog.DiscardHandler)) // Assume nil as discarding logs return } l.logger.Store(slog.New(newHandler)) } // Ensure LogHolder implements LoggerSetterGetter var _ LoggerSetterGetter = &LogHolder{}
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/logging/logging_test.go
internal/logging/logging_test.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package logging import ( "bytes" "context" "log/slog" "testing" "time" "github.com/stretchr/testify/assert" ) func TestLogHolder_Logger(t *testing.T) { t.Run("should return new logger with a then set handler", func(t *testing.T) { holder := &LogHolder{} buf := &bytes.Buffer{} handler := slog.NewTextHandler(buf, &slog.HandlerOptions{Level: slog.LevelDebug}) holder.SetLogger(handler) logger := holder.Logger() assert.NotNil(t, logger) // Test that the logger works logger.Info("test message") assert.Contains(t, buf.String(), "test message") }) t.Run("should return discard - defaultlogger when no handler is set", func(t *testing.T) { holder := &LogHolder{} logger := holder.Logger() assert.Equal(t, slog.Handler(slog.DiscardHandler), logger.Handler()) }) } func TestLogHolder_SetLogger(t *testing.T) { t.Run("sets logger with valid handler", func(t *testing.T) { holder := &LogHolder{} buf := &bytes.Buffer{} handler := slog.NewTextHandler(buf, &slog.HandlerOptions{Level: slog.LevelDebug}) holder.SetLogger(handler) logger := holder.Logger() assert.NotNil(t, logger) // Compare the handler directly assert.Equal(t, handler, logger.Handler()) }) t.Run("sets discard logger with nil handler", func(t *testing.T) { holder := &LogHolder{} holder.SetLogger(nil) logger := holder.Logger() assert.NotNil(t, logger) assert.Equal(t, slog.Handler(slog.DiscardHandler), logger.Handler()) }) t.Run("can replace existing logger", func(t *testing.T) { holder := &LogHolder{} // Set first logger buf1 := &bytes.Buffer{} handler1 := slog.NewTextHandler(buf1, &slog.HandlerOptions{Level: slog.LevelDebug}) holder.SetLogger(handler1) logger1 := holder.Logger() assert.Equal(t, handler1, logger1.Handler()) // Replace with second logger buf2 := &bytes.Buffer{} handler2 := slog.NewTextHandler(buf2, &slog.HandlerOptions{Level: slog.LevelDebug}) holder.SetLogger(handler2) logger2 := holder.Logger() assert.Equal(t, handler2, logger2.Handler()) }) } func TestLogHolder_InterfaceCompliance(t *testing.T) { t.Run("implements LoggerSetterGetter interface", func(_ *testing.T) { var _ LoggerSetterGetter = &LogHolder{} }) t.Run("interface methods work correctly", func(t *testing.T) { var holder LoggerSetterGetter = &LogHolder{} buf := &bytes.Buffer{} handler := slog.NewTextHandler(buf, &slog.HandlerOptions{Level: slog.LevelDebug}) holder.SetLogger(handler) logger := holder.Logger() assert.NotNil(t, logger) assert.Equal(t, handler, logger.Handler()) }) } func TestDebugCheckHandler_Enabled(t *testing.T) { t.Run("returns debugEnabled function result for debug level", func(t *testing.T) { // Test with debug enabled debugEnabled := func() bool { return true } buf := &bytes.Buffer{} baseHandler := slog.NewTextHandler(buf, &slog.HandlerOptions{Level: slog.LevelDebug}) handler := &DebugCheckHandler{ handler: baseHandler, debugEnabled: debugEnabled, } assert.True(t, handler.Enabled(t.Context(), slog.LevelDebug)) }) t.Run("returns false for debug level when debug disabled", func(t *testing.T) { // Test with debug disabled debugEnabled := func() bool { return false } buf := &bytes.Buffer{} baseHandler := slog.NewTextHandler(buf, &slog.HandlerOptions{Level: slog.LevelDebug}) handler := &DebugCheckHandler{ handler: baseHandler, debugEnabled: debugEnabled, } assert.False(t, handler.Enabled(t.Context(), slog.LevelDebug)) }) t.Run("always returns true for non-debug levels", func(t *testing.T) { debugEnabled := func() bool { return false } // Debug disabled buf := &bytes.Buffer{} baseHandler := slog.NewTextHandler(buf, &slog.HandlerOptions{Level: slog.LevelDebug}) handler := &DebugCheckHandler{ handler: baseHandler, debugEnabled: debugEnabled, } // Even with debug disabled, other levels should always be enabled assert.True(t, handler.Enabled(t.Context(), slog.LevelInfo)) assert.True(t, handler.Enabled(t.Context(), slog.LevelWarn)) assert.True(t, handler.Enabled(t.Context(), slog.LevelError)) }) t.Run("calls debugEnabled function dynamically", func(t *testing.T) { callCount := 0 debugEnabled := func() bool { callCount++ return callCount%2 == 1 // Alternates between true and false } buf := &bytes.Buffer{} baseHandler := slog.NewTextHandler(buf, &slog.HandlerOptions{Level: slog.LevelDebug}) handler := &DebugCheckHandler{ handler: baseHandler, debugEnabled: debugEnabled, } // First call should return true assert.True(t, handler.Enabled(t.Context(), slog.LevelDebug)) assert.Equal(t, 1, callCount) // Second call should return false assert.False(t, handler.Enabled(t.Context(), slog.LevelDebug)) assert.Equal(t, 2, callCount) // Third call should return true again assert.True(t, handler.Enabled(t.Context(), slog.LevelDebug)) assert.Equal(t, 3, callCount) }) } func TestDebugCheckHandler_Handle(t *testing.T) { t.Run("delegates to underlying handler", func(t *testing.T) { buf := &bytes.Buffer{} baseHandler := slog.NewTextHandler(buf, &slog.HandlerOptions{Level: slog.LevelDebug}) handler := &DebugCheckHandler{ handler: baseHandler, debugEnabled: func() bool { return true }, } record := slog.NewRecord(time.Now(), slog.LevelInfo, "test message", 0) err := handler.Handle(t.Context(), record) assert.NoError(t, err) assert.Contains(t, buf.String(), "test message") }) t.Run("handles context correctly", func(t *testing.T) { buf := &bytes.Buffer{} baseHandler := slog.NewTextHandler(buf, &slog.HandlerOptions{Level: slog.LevelDebug}) handler := &DebugCheckHandler{ handler: baseHandler, debugEnabled: func() bool { return true }, } type testKey string ctx := context.WithValue(t.Context(), testKey("test"), "value") record := slog.NewRecord(time.Now(), slog.LevelInfo, "context test", 0) err := handler.Handle(ctx, record) assert.NoError(t, err) assert.Contains(t, buf.String(), "context test") }) } func TestDebugCheckHandler_WithAttrs(t *testing.T) { t.Run("returns new DebugCheckHandler with attributes", func(t *testing.T) { logger := NewLogger(func() bool { return true }) handler := logger.Handler() newHandler := handler.WithAttrs([]slog.Attr{ slog.String("key1", "value1"), slog.Int("key2", 42), }) // Should return a DebugCheckHandler debugHandler, ok := newHandler.(*DebugCheckHandler) assert.True(t, ok) assert.NotNil(t, debugHandler) // Should preserve the debugEnabled function assert.True(t, debugHandler.Enabled(t.Context(), slog.LevelDebug)) // Should have the attributes applied to the underlying handler assert.NotEqual(t, handler, debugHandler.handler) }) t.Run("preserves debugEnabled function", func(t *testing.T) { callCount := 0 debugEnabled := func() bool { callCount++ return callCount%2 == 1 } buf := &bytes.Buffer{} baseHandler := slog.NewTextHandler(buf, &slog.HandlerOptions{Level: slog.LevelDebug}) handler := &DebugCheckHandler{ handler: baseHandler, debugEnabled: debugEnabled, } attrs := []slog.Attr{slog.String("test", "value")} newHandler := handler.WithAttrs(attrs) // The new handler should use the same debugEnabled function assert.True(t, newHandler.Enabled(t.Context(), slog.LevelDebug)) assert.Equal(t, 1, callCount) assert.False(t, newHandler.Enabled(t.Context(), slog.LevelDebug)) assert.Equal(t, 2, callCount) }) } func TestDebugCheckHandler_WithGroup(t *testing.T) { t.Run("returns new DebugCheckHandler with group", func(t *testing.T) { buf := &bytes.Buffer{} baseHandler := slog.NewTextHandler(buf, &slog.HandlerOptions{Level: slog.LevelDebug}) handler := &DebugCheckHandler{ handler: baseHandler, debugEnabled: func() bool { return true }, } newHandler := handler.WithGroup("testgroup") // Should return a DebugCheckHandler debugHandler, ok := newHandler.(*DebugCheckHandler) assert.True(t, ok) assert.NotNil(t, debugHandler) // Should preserve the debugEnabled function assert.True(t, debugHandler.Enabled(t.Context(), slog.LevelDebug)) // Should have the group applied to the underlying handler assert.NotEqual(t, handler.handler, debugHandler.handler) }) t.Run("preserves debugEnabled function", func(t *testing.T) { callCount := 0 debugEnabled := func() bool { callCount++ return callCount%2 == 1 } buf := &bytes.Buffer{} baseHandler := slog.NewTextHandler(buf, &slog.HandlerOptions{Level: slog.LevelDebug}) handler := &DebugCheckHandler{ handler: baseHandler, debugEnabled: debugEnabled, } newHandler := handler.WithGroup("testgroup") // The new handler should use the same debugEnabled function assert.True(t, newHandler.Enabled(t.Context(), slog.LevelDebug)) assert.Equal(t, 1, callCount) assert.False(t, newHandler.Enabled(t.Context(), slog.LevelDebug)) assert.Equal(t, 2, callCount) }) } func TestDebugCheckHandler_Integration(t *testing.T) { t.Run("works with NewLogger function", func(t *testing.T) { debugEnabled := func() bool { return true } logger := NewLogger(debugEnabled) assert.NotNil(t, logger) // The logger should have a DebugCheckHandler handler := logger.Handler() debugHandler, ok := handler.(*DebugCheckHandler) assert.True(t, ok) // Should enable debug when debugEnabled returns true assert.True(t, debugHandler.Enabled(t.Context(), slog.LevelDebug)) // Should enable other levels regardless assert.True(t, debugHandler.Enabled(t.Context(), slog.LevelInfo)) }) t.Run("dynamic debug checking works in practice", func(t *testing.T) { debugState := false debugEnabled := func() bool { return debugState } logger := NewLogger(debugEnabled) // Initially debug should be disabled assert.False(t, logger.Handler().(*DebugCheckHandler).Enabled(t.Context(), slog.LevelDebug)) // Enable debug debugState = true assert.True(t, logger.Handler().(*DebugCheckHandler).Enabled(t.Context(), slog.LevelDebug)) // Disable debug again debugState = false assert.False(t, logger.Handler().(*DebugCheckHandler).Enabled(t.Context(), slog.LevelDebug)) }) t.Run("handles nil debugEnabled function", func(t *testing.T) { logger := NewLogger(nil) assert.NotNil(t, logger) // The logger should have a DebugCheckHandler handler := logger.Handler() debugHandler, ok := handler.(*DebugCheckHandler) assert.True(t, ok) // When debugEnabled is nil, debug level should be disabled (default behavior) assert.False(t, debugHandler.Enabled(t.Context(), slog.LevelDebug)) // Other levels should always be enabled assert.True(t, debugHandler.Enabled(t.Context(), slog.LevelInfo)) assert.True(t, debugHandler.Enabled(t.Context(), slog.LevelWarn)) assert.True(t, debugHandler.Enabled(t.Context(), slog.LevelError)) }) }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/test/test.go
internal/test/test.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package test import ( "bytes" "flag" "fmt" "os" "path/filepath" ) // UpdateGolden writes out the golden files with the latest values, rather than failing the test. var updateGolden = flag.Bool("update", false, "update golden files") // TestingT describes a testing object compatible with the critical functions from the testing.T type type TestingT interface { Fatal(...interface{}) Fatalf(string, ...interface{}) HelperT } // HelperT describes a test with a helper function type HelperT interface { Helper() } // AssertGoldenString asserts that the given string matches the contents of the given file. func AssertGoldenString(t TestingT, actual, filename string) { t.Helper() if err := compare([]byte(actual), path(filename)); err != nil { t.Fatalf("%v\n", err) } } // AssertGoldenFile asserts that the content of the actual file matches the contents of the expected file func AssertGoldenFile(t TestingT, actualFileName string, expectedFilename string) { t.Helper() actual, err := os.ReadFile(actualFileName) if err != nil { t.Fatalf("%v", err) } AssertGoldenString(t, string(actual), expectedFilename) } func path(filename string) string { if filepath.IsAbs(filename) { return filename } return filepath.Join("testdata", filename) } func compare(actual []byte, filename string) error { actual = normalize(actual) if err := update(filename, actual); err != nil { return err } expected, err := os.ReadFile(filename) if err != nil { return fmt.Errorf("unable to read testdata %s: %w", filename, err) } expected = normalize(expected) if !bytes.Equal(expected, actual) { return fmt.Errorf("does not match golden file %s\n\nWANT:\n'%s'\n\nGOT:\n'%s'", filename, expected, actual) } return nil } func update(filename string, in []byte) error { if !*updateGolden { return nil } return os.WriteFile(filename, normalize(in), 0666) } func normalize(in []byte) []byte { return bytes.ReplaceAll(in, []byte("\r\n"), []byte("\n")) }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/test/ensure/ensure.go
internal/test/ensure/ensure.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package ensure import ( "os" "path/filepath" "testing" "helm.sh/helm/v4/pkg/helmpath" "helm.sh/helm/v4/pkg/helmpath/xdg" ) // HelmHome sets up a Helm Home in a temp dir. func HelmHome(t *testing.T) { t.Helper() base := t.TempDir() t.Setenv(xdg.CacheHomeEnvVar, base) t.Setenv(xdg.ConfigHomeEnvVar, base) t.Setenv(xdg.DataHomeEnvVar, base) t.Setenv(helmpath.CacheHomeEnvVar, "") t.Setenv(helmpath.ConfigHomeEnvVar, "") t.Setenv(helmpath.DataHomeEnvVar, "") } // TempFile ensures a temp file for unit testing purposes. // // It returns the path to the directory (to which you will still need to join the filename) // // The returned directory is automatically removed when the test and all its subtests complete. // // tempdir := TempFile(t, "foo", []byte("bar")) // filename := filepath.Join(tempdir, "foo") func TempFile(t *testing.T, name string, data []byte) string { t.Helper() path := t.TempDir() filename := filepath.Join(path, name) if err := os.WriteFile(filename, data, 0o755); err != nil { t.Fatal(err) } return path }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/tlsutil/tls_test.go
internal/tlsutil/tls_test.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package tlsutil import ( "path/filepath" "testing" ) const tlsTestDir = "../../testdata" const ( testCaCertFile = "rootca.crt" testCertFile = "crt.pem" testKeyFile = "key.pem" ) func testfile(t *testing.T, file string) (path string) { t.Helper() path, err := filepath.Abs(filepath.Join(tlsTestDir, file)) if err != nil { t.Fatalf("error getting absolute path to test file %q: %v", file, err) } return path } func TestNewTLSConfig(t *testing.T) { certFile := testfile(t, testCertFile) keyFile := testfile(t, testKeyFile) caCertFile := testfile(t, testCaCertFile) insecureSkipTLSVerify := false { cfg, err := NewTLSConfig( WithInsecureSkipVerify(insecureSkipTLSVerify), WithCertKeyPairFiles(certFile, keyFile), WithCAFile(caCertFile), ) if err != nil { t.Error(err) } if got := len(cfg.Certificates); got != 1 { t.Fatalf("expecting 1 client certificates, got %d", got) } if cfg.InsecureSkipVerify { t.Fatalf("insecure skip verify mismatch, expecting false") } if cfg.RootCAs == nil { t.Fatalf("mismatch tls RootCAs, expecting non-nil") } } { cfg, err := NewTLSConfig( WithInsecureSkipVerify(insecureSkipTLSVerify), WithCAFile(caCertFile), ) if err != nil { t.Error(err) } if got := len(cfg.Certificates); got != 0 { t.Fatalf("expecting 0 client certificates, got %d", got) } if cfg.InsecureSkipVerify { t.Fatalf("insecure skip verify mismatch, expecting false") } if cfg.RootCAs == nil { t.Fatalf("mismatch tls RootCAs, expecting non-nil") } } { cfg, err := NewTLSConfig( WithInsecureSkipVerify(insecureSkipTLSVerify), WithCertKeyPairFiles(certFile, keyFile), ) if err != nil { t.Error(err) } if got := len(cfg.Certificates); got != 1 { t.Fatalf("expecting 1 client certificates, got %d", got) } if cfg.InsecureSkipVerify { t.Fatalf("insecure skip verify mismatch, expecting false") } if cfg.RootCAs != nil { t.Fatalf("mismatch tls RootCAs, expecting nil") } } }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/tlsutil/tls.go
internal/tlsutil/tls.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package tlsutil import ( "crypto/tls" "crypto/x509" "fmt" "os" "errors" ) type TLSConfigOptions struct { insecureSkipTLSVerify bool certPEMBlock, keyPEMBlock []byte caPEMBlock []byte } type TLSConfigOption func(options *TLSConfigOptions) error func WithInsecureSkipVerify(insecureSkipTLSVerify bool) TLSConfigOption { return func(options *TLSConfigOptions) error { options.insecureSkipTLSVerify = insecureSkipTLSVerify return nil } } func WithCertKeyPairFiles(certFile, keyFile string) TLSConfigOption { return func(options *TLSConfigOptions) error { if certFile == "" && keyFile == "" { return nil } certPEMBlock, err := os.ReadFile(certFile) if err != nil { return fmt.Errorf("unable to read cert file: %q: %w", certFile, err) } keyPEMBlock, err := os.ReadFile(keyFile) if err != nil { return fmt.Errorf("unable to read key file: %q: %w", keyFile, err) } options.certPEMBlock = certPEMBlock options.keyPEMBlock = keyPEMBlock return nil } } func WithCAFile(caFile string) TLSConfigOption { return func(options *TLSConfigOptions) error { if caFile == "" { return nil } caPEMBlock, err := os.ReadFile(caFile) if err != nil { return fmt.Errorf("can't read CA file: %q: %w", caFile, err) } options.caPEMBlock = caPEMBlock return nil } } func NewTLSConfig(options ...TLSConfigOption) (*tls.Config, error) { to := TLSConfigOptions{} errs := []error{} for _, option := range options { err := option(&to) if err != nil { errs = append(errs, err) } } if len(errs) > 0 { return nil, errors.Join(errs...) } config := tls.Config{ InsecureSkipVerify: to.insecureSkipTLSVerify, } if len(to.certPEMBlock) > 0 && len(to.keyPEMBlock) > 0 { cert, err := tls.X509KeyPair(to.certPEMBlock, to.keyPEMBlock) if err != nil { return nil, fmt.Errorf("unable to load cert from key pair: %w", err) } config.Certificates = []tls.Certificate{cert} } if len(to.caPEMBlock) > 0 { cp := x509.NewCertPool() if !cp.AppendCertsFromPEM(to.caPEMBlock) { return nil, fmt.Errorf("failed to append certificates from pem block") } config.RootCAs = cp } return &config, nil }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/resolver/resolver.go
internal/resolver/resolver.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package resolver import ( "bytes" "encoding/json" "errors" "fmt" "io/fs" "os" "path/filepath" "strings" "time" "github.com/Masterminds/semver/v3" chart "helm.sh/helm/v4/pkg/chart/v2" "helm.sh/helm/v4/pkg/chart/v2/loader" "helm.sh/helm/v4/pkg/helmpath" "helm.sh/helm/v4/pkg/provenance" "helm.sh/helm/v4/pkg/registry" "helm.sh/helm/v4/pkg/repo/v1" ) // Resolver resolves dependencies from semantic version ranges to a particular version. type Resolver struct { chartpath string cachepath string registryClient *registry.Client } // New creates a new resolver for a given chart, helm home and registry client. func New(chartpath, cachepath string, registryClient *registry.Client) *Resolver { return &Resolver{ chartpath: chartpath, cachepath: cachepath, registryClient: registryClient, } } // Resolve resolves dependencies and returns a lock file with the resolution. func (r *Resolver) Resolve(reqs []*chart.Dependency, repoNames map[string]string) (*chart.Lock, error) { // Now we clone the dependencies, locking as we go. locked := make([]*chart.Dependency, len(reqs)) missing := []string{} for i, d := range reqs { constraint, err := semver.NewConstraint(d.Version) if err != nil { return nil, fmt.Errorf("dependency %q has an invalid version/constraint format: %w", d.Name, err) } if d.Repository == "" { // Local chart subfolder if _, err := GetLocalPath(filepath.Join("charts", d.Name), r.chartpath); err != nil { return nil, err } locked[i] = &chart.Dependency{ Name: d.Name, Repository: "", Version: d.Version, } continue } if strings.HasPrefix(d.Repository, "file://") { chartpath, err := GetLocalPath(d.Repository, r.chartpath) if err != nil { return nil, err } ch, err := loader.LoadDir(chartpath) if err != nil { return nil, err } v, err := semver.NewVersion(ch.Metadata.Version) if err != nil { // Not a legit entry. continue } if !constraint.Check(v) { missing = append(missing, fmt.Sprintf("%q (repository %q, version %q)", d.Name, d.Repository, d.Version)) continue } locked[i] = &chart.Dependency{ Name: d.Name, Repository: d.Repository, Version: ch.Metadata.Version, } continue } repoName := repoNames[d.Name] // if the repository was not defined, but the dependency defines a repository url, bypass the cache if repoName == "" && d.Repository != "" { locked[i] = &chart.Dependency{ Name: d.Name, Repository: d.Repository, Version: d.Version, } continue } var vs repo.ChartVersions var version string var ok bool found := true if !registry.IsOCI(d.Repository) { repoIndex, err := repo.LoadIndexFile(filepath.Join(r.cachepath, helmpath.CacheIndexFile(repoName))) if err != nil { return nil, fmt.Errorf("no cached repository for %s found. (try 'helm repo update'): %w", repoName, err) } vs, ok = repoIndex.Entries[d.Name] if !ok { return nil, fmt.Errorf("%s chart not found in repo %s", d.Name, d.Repository) } found = false } else { version = d.Version // Check to see if an explicit version has been provided _, err := semver.NewVersion(version) // Use an explicit version, otherwise search for tags if err == nil { vs = []*repo.ChartVersion{{ Metadata: &chart.Metadata{ Version: version, }, }} } else { // Retrieve list of tags for repository ref := fmt.Sprintf("%s/%s", strings.TrimPrefix(d.Repository, fmt.Sprintf("%s://", registry.OCIScheme)), d.Name) tags, err := r.registryClient.Tags(ref) if err != nil { return nil, fmt.Errorf("could not retrieve list of tags for repository %s: %w", d.Repository, err) } vs = make(repo.ChartVersions, len(tags)) for ti, t := range tags { // Mock chart version objects version := &repo.ChartVersion{ Metadata: &chart.Metadata{ Version: t, }, } vs[ti] = version } } } locked[i] = &chart.Dependency{ Name: d.Name, Repository: d.Repository, Version: version, } // The versions are already sorted and hence the first one to satisfy the constraint is used for _, ver := range vs { v, err := semver.NewVersion(ver.Version) // OCI does not need URLs if err != nil || (!registry.IsOCI(d.Repository) && len(ver.URLs) == 0) { // Not a legit entry. continue } if constraint.Check(v) { found = true locked[i].Version = v.Original() break } } if !found { missing = append(missing, fmt.Sprintf("%q (repository %q, version %q)", d.Name, d.Repository, d.Version)) } } if len(missing) > 0 { return nil, fmt.Errorf("can't get a valid version for %d subchart(s): %s. Make sure a matching chart version exists in the repo, or change the version constraint in Chart.yaml", len(missing), strings.Join(missing, ", ")) } digest, err := HashReq(reqs, locked) if err != nil { return nil, err } return &chart.Lock{ Generated: time.Now(), Digest: digest, Dependencies: locked, }, nil } // HashReq generates a hash of the dependencies. // // This should be used only to compare against another hash generated by this // function. func HashReq(req, lock []*chart.Dependency) (string, error) { data, err := json.Marshal([2][]*chart.Dependency{req, lock}) if err != nil { return "", err } s, err := provenance.Digest(bytes.NewBuffer(data)) return "sha256:" + s, err } // HashV2Req generates a hash of requirements generated in Helm v2. // // This should be used only to compare against another hash generated by the // Helm v2 hash function. It is to handle issue: // https://github.com/helm/helm/issues/7233 func HashV2Req(req []*chart.Dependency) (string, error) { dep := make(map[string][]*chart.Dependency) dep["dependencies"] = req data, err := json.Marshal(dep) if err != nil { return "", err } s, err := provenance.Digest(bytes.NewBuffer(data)) return "sha256:" + s, err } // GetLocalPath generates absolute local path when use // "file://" in repository of dependencies func GetLocalPath(repo, chartpath string) (string, error) { var depPath string var err error p := strings.TrimPrefix(repo, "file://") // root path is absolute if strings.HasPrefix(p, "/") { if depPath, err = filepath.Abs(p); err != nil { return "", err } } else { depPath = filepath.Join(chartpath, p) } if _, err = os.Stat(depPath); errors.Is(err, fs.ErrNotExist) { return "", fmt.Errorf("directory %s not found", depPath) } else if err != nil { return "", err } return depPath, nil }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/resolver/resolver_test.go
internal/resolver/resolver_test.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package resolver import ( "runtime" "testing" chart "helm.sh/helm/v4/pkg/chart/v2" "helm.sh/helm/v4/pkg/registry" ) func TestResolve(t *testing.T) { tests := []struct { name string req []*chart.Dependency expect *chart.Lock err bool }{ { name: "repo from invalid version", req: []*chart.Dependency{ {Name: "base", Repository: "file://base", Version: "1.1.0"}, }, expect: &chart.Lock{ Dependencies: []*chart.Dependency{ {Name: "base", Repository: "file://base", Version: "0.1.0"}, }, }, err: true, }, { name: "version failure", req: []*chart.Dependency{ {Name: "oedipus-rex", Repository: "http://example.com", Version: ">a1"}, }, err: true, }, { name: "cache index failure", req: []*chart.Dependency{ {Name: "oedipus-rex", Repository: "http://example.com", Version: "1.0.0"}, }, expect: &chart.Lock{ Dependencies: []*chart.Dependency{ {Name: "oedipus-rex", Repository: "http://example.com", Version: "1.0.0"}, }, }, }, { name: "chart not found failure", req: []*chart.Dependency{ {Name: "redis", Repository: "http://example.com", Version: "1.0.0"}, }, err: true, }, { name: "constraint not satisfied failure", req: []*chart.Dependency{ {Name: "alpine", Repository: "http://example.com", Version: ">=1.0.0"}, }, err: true, }, { name: "valid lock", req: []*chart.Dependency{ {Name: "alpine", Repository: "http://example.com", Version: ">=0.1.0"}, }, expect: &chart.Lock{ Dependencies: []*chart.Dependency{ {Name: "alpine", Repository: "http://example.com", Version: "0.2.0"}, }, }, }, { name: "repo from valid local path", req: []*chart.Dependency{ {Name: "base", Repository: "file://base", Version: "0.1.0"}, }, expect: &chart.Lock{ Dependencies: []*chart.Dependency{ {Name: "base", Repository: "file://base", Version: "0.1.0"}, }, }, }, { name: "repo from valid local path with range resolution", req: []*chart.Dependency{ {Name: "base", Repository: "file://base", Version: "^0.1.0"}, }, expect: &chart.Lock{ Dependencies: []*chart.Dependency{ {Name: "base", Repository: "file://base", Version: "0.1.0"}, }, }, }, { name: "repo from invalid local path", req: []*chart.Dependency{ {Name: "nonexistent", Repository: "file://testdata/nonexistent", Version: "0.1.0"}, }, err: true, }, { name: "repo from valid path under charts path", req: []*chart.Dependency{ {Name: "localdependency", Repository: "", Version: "0.1.0"}, }, expect: &chart.Lock{ Dependencies: []*chart.Dependency{ {Name: "localdependency", Repository: "", Version: "0.1.0"}, }, }, }, { name: "repo from invalid path under charts path", req: []*chart.Dependency{ {Name: "nonexistentdependency", Repository: "", Version: "0.1.0"}, }, expect: &chart.Lock{ Dependencies: []*chart.Dependency{ {Name: "nonexistentlocaldependency", Repository: "", Version: "0.1.0"}, }, }, err: true, }, } repoNames := map[string]string{"alpine": "kubernetes-charts", "redis": "kubernetes-charts"} registryClient, _ := registry.NewClient() r := New("testdata/chartpath", "testdata/repository", registryClient) for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { l, err := r.Resolve(tt.req, repoNames) if err != nil { if tt.err { return } t.Fatal(err) } if tt.err { t.Fatalf("Expected error in test %q", tt.name) } if h, err := HashReq(tt.req, tt.expect.Dependencies); err != nil { t.Fatal(err) } else if h != l.Digest { t.Errorf("%q: hashes don't match.", tt.name) } // Check fields. if len(l.Dependencies) != len(tt.req) { t.Errorf("%s: wrong number of dependencies in lock", tt.name) } d0 := l.Dependencies[0] e0 := tt.expect.Dependencies[0] if d0.Name != e0.Name { t.Errorf("%s: expected name %s, got %s", tt.name, e0.Name, d0.Name) } if d0.Repository != e0.Repository { t.Errorf("%s: expected repo %s, got %s", tt.name, e0.Repository, d0.Repository) } if d0.Version != e0.Version { t.Errorf("%s: expected version %s, got %s", tt.name, e0.Version, d0.Version) } }) } } func TestHashReq(t *testing.T) { expect := "sha256:fb239e836325c5fa14b29d1540a13b7d3ba13151b67fe719f820e0ef6d66aaaf" tests := []struct { name string chartVersion string lockVersion string wantError bool }{ { name: "chart with the expected digest", chartVersion: "0.1.0", lockVersion: "0.1.0", wantError: false, }, { name: "ranged version but same resolved lock version", chartVersion: "^0.1.0", lockVersion: "0.1.0", wantError: true, }, { name: "ranged version resolved as higher version", chartVersion: "^0.1.0", lockVersion: "0.1.2", wantError: true, }, { name: "different version", chartVersion: "0.1.2", lockVersion: "0.1.2", wantError: true, }, { name: "different version with a range", chartVersion: "^0.1.2", lockVersion: "0.1.2", wantError: true, }, } for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { req := []*chart.Dependency{ {Name: "alpine", Version: tt.chartVersion, Repository: "http://localhost:8879/charts"}, } lock := []*chart.Dependency{ {Name: "alpine", Version: tt.lockVersion, Repository: "http://localhost:8879/charts"}, } h, err := HashReq(req, lock) if err != nil { t.Fatal(err) } if !tt.wantError && expect != h { t.Errorf("Expected %q, got %q", expect, h) } else if tt.wantError && expect == h { t.Errorf("Expected not %q, but same", expect) } }) } } func TestGetLocalPath(t *testing.T) { tests := []struct { name string repo string chartpath string expect string winExpect string err bool }{ { name: "absolute path", repo: "file:////", expect: "/", winExpect: "\\", }, { name: "relative path", repo: "file://../../testdata/chartpath/base", chartpath: "foo/bar", expect: "testdata/chartpath/base", winExpect: "testdata\\chartpath\\base", }, { name: "current directory path", repo: "../charts/localdependency", chartpath: "testdata/chartpath/charts", expect: "testdata/chartpath/charts/localdependency", winExpect: "testdata\\chartpath\\charts\\localdependency", }, { name: "invalid local path", repo: "file://testdata/nonexistent", chartpath: "testdata/chartpath", err: true, }, { name: "invalid path under current directory", repo: "charts/nonexistentdependency", chartpath: "testdata/chartpath/charts", err: true, }, } for _, tt := range tests { t.Run(tt.name, func(t *testing.T) { p, err := GetLocalPath(tt.repo, tt.chartpath) if err != nil { if tt.err { return } t.Fatal(err) } if tt.err { t.Fatalf("Expected error in test %q", tt.name) } expect := tt.expect if runtime.GOOS == "windows" { expect = tt.winExpect } if p != expect { t.Errorf("%q: expected %q, got %q", tt.name, expect, p) } }) } }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/fileutil/fileutil_test.go
internal/fileutil/fileutil_test.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package fileutil import ( "bytes" "os" "path/filepath" "strings" "testing" ) // TestAtomicWriteFile tests the happy path of AtomicWriteFile function. // It verifies that the function correctly writes content to a file with the specified mode. func TestAtomicWriteFile(t *testing.T) { dir := t.TempDir() testpath := filepath.Join(dir, "test") stringContent := "Test content" reader := bytes.NewReader([]byte(stringContent)) mode := os.FileMode(0644) err := AtomicWriteFile(testpath, reader, mode) if err != nil { t.Errorf("AtomicWriteFile error: %s", err) } got, err := os.ReadFile(testpath) if err != nil { t.Fatal(err) } if stringContent != string(got) { t.Fatalf("expected: %s, got: %s", stringContent, string(got)) } gotinfo, err := os.Stat(testpath) if err != nil { t.Fatal(err) } if mode != gotinfo.Mode() { t.Fatalf("expected %s: to be the same mode as %s", mode, gotinfo.Mode()) } } // TestAtomicWriteFile_CreateTempError tests the error path when os.CreateTemp fails func TestAtomicWriteFile_CreateTempError(t *testing.T) { invalidPath := "/invalid/path/that/does/not/exist/testfile" reader := bytes.NewReader([]byte("test content")) mode := os.FileMode(0644) err := AtomicWriteFile(invalidPath, reader, mode) if err == nil { t.Error("Expected error when CreateTemp fails, but got nil") } } // TestAtomicWriteFile_EmptyContent tests with empty content func TestAtomicWriteFile_EmptyContent(t *testing.T) { dir := t.TempDir() testpath := filepath.Join(dir, "empty_helm") reader := bytes.NewReader([]byte("")) mode := os.FileMode(0644) err := AtomicWriteFile(testpath, reader, mode) if err != nil { t.Errorf("AtomicWriteFile error with empty content: %s", err) } got, err := os.ReadFile(testpath) if err != nil { t.Fatal(err) } if len(got) != 0 { t.Fatalf("expected empty content, got: %s", string(got)) } } // TestAtomicWriteFile_LargeContent tests with large content func TestAtomicWriteFile_LargeContent(t *testing.T) { dir := t.TempDir() testpath := filepath.Join(dir, "large_test") // Create a large content string largeContent := strings.Repeat("HELM", 1024*1024) reader := bytes.NewReader([]byte(largeContent)) mode := os.FileMode(0644) err := AtomicWriteFile(testpath, reader, mode) if err != nil { t.Errorf("AtomicWriteFile error with large content: %s", err) } got, err := os.ReadFile(testpath) if err != nil { t.Fatal(err) } if largeContent != string(got) { t.Fatalf("expected large content to match, got different length: %d vs %d", len(largeContent), len(got)) } }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/fileutil/fileutil.go
internal/fileutil/fileutil.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package fileutil import ( "io" "os" "path/filepath" "helm.sh/helm/v4/internal/third_party/dep/fs" ) // AtomicWriteFile atomically (as atomic as os.Rename allows) writes a file to a // disk. func AtomicWriteFile(filename string, reader io.Reader, mode os.FileMode) error { tempFile, err := os.CreateTemp(filepath.Split(filename)) if err != nil { return err } tempName := tempFile.Name() if _, err := io.Copy(tempFile, reader); err != nil { tempFile.Close() // return value is ignored as we are already on error path return err } if err := tempFile.Close(); err != nil { return err } if err := os.Chmod(tempName, mode); err != nil { return err } return fs.RenameWithFallback(tempName, filename) }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/statusreaders/job_status_reader.go
internal/statusreaders/job_status_reader.go
/* Copyright The Helm Authors. This file was initially copied and modified from https://github.com/fluxcd/kustomize-controller/blob/main/internal/statusreaders/job.go Copyright 2022 The Flux authors Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package statusreaders import ( "context" "fmt" batchv1 "k8s.io/api/batch/v1" corev1 "k8s.io/api/core/v1" "k8s.io/apimachinery/pkg/api/meta" "k8s.io/apimachinery/pkg/apis/meta/v1/unstructured" "k8s.io/apimachinery/pkg/runtime/schema" "github.com/fluxcd/cli-utils/pkg/kstatus/polling/engine" "github.com/fluxcd/cli-utils/pkg/kstatus/polling/event" "github.com/fluxcd/cli-utils/pkg/kstatus/polling/statusreaders" "github.com/fluxcd/cli-utils/pkg/kstatus/status" "github.com/fluxcd/cli-utils/pkg/object" ) type customJobStatusReader struct { genericStatusReader engine.StatusReader } func NewCustomJobStatusReader(mapper meta.RESTMapper) engine.StatusReader { genericStatusReader := statusreaders.NewGenericStatusReader(mapper, jobConditions) return &customJobStatusReader{ genericStatusReader: genericStatusReader, } } func (j *customJobStatusReader) Supports(gk schema.GroupKind) bool { return gk == batchv1.SchemeGroupVersion.WithKind("Job").GroupKind() } func (j *customJobStatusReader) ReadStatus(ctx context.Context, reader engine.ClusterReader, resource object.ObjMetadata) (*event.ResourceStatus, error) { return j.genericStatusReader.ReadStatus(ctx, reader, resource) } func (j *customJobStatusReader) ReadStatusForObject(ctx context.Context, reader engine.ClusterReader, resource *unstructured.Unstructured) (*event.ResourceStatus, error) { return j.genericStatusReader.ReadStatusForObject(ctx, reader, resource) } // Ref: https://github.com/kubernetes-sigs/cli-utils/blob/v0.29.4/pkg/kstatus/status/core.go // Modified to return Current status only when the Job has completed as opposed to when it's in progress. func jobConditions(u *unstructured.Unstructured) (*status.Result, error) { obj := u.UnstructuredContent() parallelism := status.GetIntField(obj, ".spec.parallelism", 1) completions := status.GetIntField(obj, ".spec.completions", parallelism) succeeded := status.GetIntField(obj, ".status.succeeded", 0) failed := status.GetIntField(obj, ".status.failed", 0) // Conditions // https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/job/utils.go#L24 objc, err := status.GetObjectWithConditions(obj) if err != nil { return nil, err } for _, c := range objc.Status.Conditions { switch c.Type { case "Complete": if c.Status == corev1.ConditionTrue { message := fmt.Sprintf("Job Completed. succeeded: %d/%d", succeeded, completions) return &status.Result{ Status: status.CurrentStatus, Message: message, Conditions: []status.Condition{}, }, nil } case "Failed": message := fmt.Sprintf("Job Failed. failed: %d/%d", failed, completions) if c.Status == corev1.ConditionTrue { return &status.Result{ Status: status.FailedStatus, Message: message, Conditions: []status.Condition{ { Type: status.ConditionStalled, Status: corev1.ConditionTrue, Reason: "JobFailed", Message: message, }, }, }, nil } } } message := "Job in progress" return &status.Result{ Status: status.InProgressStatus, Message: message, Conditions: []status.Condition{ { Type: status.ConditionReconciling, Status: corev1.ConditionTrue, Reason: "JobInProgress", Message: message, }, }, }, nil }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/statusreaders/pod_status_reader.go
internal/statusreaders/pod_status_reader.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package statusreaders import ( "context" "fmt" corev1 "k8s.io/api/core/v1" "k8s.io/apimachinery/pkg/api/meta" "k8s.io/apimachinery/pkg/apis/meta/v1/unstructured" "k8s.io/apimachinery/pkg/runtime/schema" "github.com/fluxcd/cli-utils/pkg/kstatus/polling/engine" "github.com/fluxcd/cli-utils/pkg/kstatus/polling/event" "github.com/fluxcd/cli-utils/pkg/kstatus/polling/statusreaders" "github.com/fluxcd/cli-utils/pkg/kstatus/status" "github.com/fluxcd/cli-utils/pkg/object" ) type customPodStatusReader struct { genericStatusReader engine.StatusReader } func NewCustomPodStatusReader(mapper meta.RESTMapper) engine.StatusReader { genericStatusReader := statusreaders.NewGenericStatusReader(mapper, podConditions) return &customPodStatusReader{ genericStatusReader: genericStatusReader, } } func (j *customPodStatusReader) Supports(gk schema.GroupKind) bool { return gk == corev1.SchemeGroupVersion.WithKind("Pod").GroupKind() } func (j *customPodStatusReader) ReadStatus(ctx context.Context, reader engine.ClusterReader, resource object.ObjMetadata) (*event.ResourceStatus, error) { return j.genericStatusReader.ReadStatus(ctx, reader, resource) } func (j *customPodStatusReader) ReadStatusForObject(ctx context.Context, reader engine.ClusterReader, resource *unstructured.Unstructured) (*event.ResourceStatus, error) { return j.genericStatusReader.ReadStatusForObject(ctx, reader, resource) } func podConditions(u *unstructured.Unstructured) (*status.Result, error) { obj := u.UnstructuredContent() phase := status.GetStringField(obj, ".status.phase", "") switch corev1.PodPhase(phase) { case corev1.PodSucceeded: message := fmt.Sprintf("pod %s succeeded", u.GetName()) return &status.Result{ Status: status.CurrentStatus, Message: message, Conditions: []status.Condition{ { Type: status.ConditionStalled, Status: corev1.ConditionTrue, Message: message, }, }, }, nil case corev1.PodFailed: message := fmt.Sprintf("pod %s failed", u.GetName()) return &status.Result{ Status: status.FailedStatus, Message: message, Conditions: []status.Condition{ { Type: status.ConditionStalled, Status: corev1.ConditionTrue, Reason: "PodFailed", Message: message, }, }, }, nil default: message := "Pod in progress" return &status.Result{ Status: status.InProgressStatus, Message: message, Conditions: []status.Condition{ { Type: status.ConditionReconciling, Status: corev1.ConditionTrue, Reason: "PodInProgress", Message: message, }, }, }, nil } }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/statusreaders/job_status_reader_test.go
internal/statusreaders/job_status_reader_test.go
/* Copyright The Helm Authors. This file was initially copied and modified from https://github.com/fluxcd/kustomize-controller/blob/main/internal/statusreaders/job_test.go Copyright 2022 The Flux authors Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package statusreaders import ( "testing" "github.com/stretchr/testify/assert" batchv1 "k8s.io/api/batch/v1" corev1 "k8s.io/api/core/v1" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/apimachinery/pkg/apis/meta/v1/unstructured" "k8s.io/apimachinery/pkg/runtime" "github.com/fluxcd/cli-utils/pkg/kstatus/status" ) func toUnstructured(t *testing.T, obj runtime.Object) (*unstructured.Unstructured, error) { t.Helper() // If the incoming object is already unstructured, perform a deep copy first // otherwise DefaultUnstructuredConverter ends up returning the inner map without // making a copy. if _, ok := obj.(runtime.Unstructured); ok { obj = obj.DeepCopyObject() } rawMap, err := runtime.DefaultUnstructuredConverter.ToUnstructured(obj) if err != nil { return nil, err } return &unstructured.Unstructured{Object: rawMap}, nil } func TestJobConditions(t *testing.T) { t.Parallel() tests := []struct { name string job *batchv1.Job expectedStatus status.Status }{ { name: "job without Complete condition returns InProgress status", job: &batchv1.Job{ ObjectMeta: metav1.ObjectMeta{ Name: "job-no-condition", }, Spec: batchv1.JobSpec{}, Status: batchv1.JobStatus{}, }, expectedStatus: status.InProgressStatus, }, { name: "job with Complete condition as True returns Current status", job: &batchv1.Job{ ObjectMeta: metav1.ObjectMeta{ Name: "job-complete", }, Spec: batchv1.JobSpec{}, Status: batchv1.JobStatus{ Conditions: []batchv1.JobCondition{ { Type: batchv1.JobComplete, Status: corev1.ConditionTrue, }, }, }, }, expectedStatus: status.CurrentStatus, }, { name: "job with Failed condition as True returns Failed status", job: &batchv1.Job{ ObjectMeta: metav1.ObjectMeta{ Name: "job-failed", }, Spec: batchv1.JobSpec{}, Status: batchv1.JobStatus{ Conditions: []batchv1.JobCondition{ { Type: batchv1.JobFailed, Status: corev1.ConditionTrue, }, }, }, }, expectedStatus: status.FailedStatus, }, } for _, tc := range tests { t.Run(tc.name, func(t *testing.T) { t.Parallel() us, err := toUnstructured(t, tc.job) assert.NoError(t, err) result, err := jobConditions(us) assert.NoError(t, err) assert.Equal(t, tc.expectedStatus, result.Status) }) } }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/statusreaders/pod_status_reader_test.go
internal/statusreaders/pod_status_reader_test.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package statusreaders import ( "testing" "github.com/stretchr/testify/assert" v1 "k8s.io/api/core/v1" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" "github.com/fluxcd/cli-utils/pkg/kstatus/status" ) func TestPodConditions(t *testing.T) { tests := []struct { name string pod *v1.Pod expectedStatus status.Status }{ { name: "pod without status returns in progress", pod: &v1.Pod{ ObjectMeta: metav1.ObjectMeta{Name: "pod-no-status"}, Spec: v1.PodSpec{}, Status: v1.PodStatus{}, }, expectedStatus: status.InProgressStatus, }, { name: "pod succeeded returns current status", pod: &v1.Pod{ ObjectMeta: metav1.ObjectMeta{Name: "pod-succeeded"}, Spec: v1.PodSpec{}, Status: v1.PodStatus{ Phase: v1.PodSucceeded, }, }, expectedStatus: status.CurrentStatus, }, { name: "pod failed returns failed status", pod: &v1.Pod{ ObjectMeta: metav1.ObjectMeta{Name: "pod-failed"}, Spec: v1.PodSpec{}, Status: v1.PodStatus{ Phase: v1.PodFailed, }, }, expectedStatus: status.FailedStatus, }, { name: "pod pending returns in progress status", pod: &v1.Pod{ ObjectMeta: metav1.ObjectMeta{Name: "pod-pending"}, Spec: v1.PodSpec{}, Status: v1.PodStatus{ Phase: v1.PodPending, }, }, expectedStatus: status.InProgressStatus, }, { name: "pod running returns in progress status", pod: &v1.Pod{ ObjectMeta: metav1.ObjectMeta{Name: "pod-running"}, Spec: v1.PodSpec{}, Status: v1.PodStatus{ Phase: v1.PodRunning, }, }, expectedStatus: status.InProgressStatus, }, { name: "pod with unknown phase returns in progress status", pod: &v1.Pod{ ObjectMeta: metav1.ObjectMeta{Name: "pod-unknown"}, Spec: v1.PodSpec{}, Status: v1.PodStatus{ Phase: v1.PodUnknown, }, }, expectedStatus: status.InProgressStatus, }, } for _, tc := range tests { t.Run(tc.name, func(t *testing.T) { t.Parallel() us, err := toUnstructured(t, tc.pod) assert.NoError(t, err) result, err := podConditions(us) assert.NoError(t, err) assert.Equal(t, tc.expectedStatus, result.Status) }) } }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/chart/v3/chart.go
internal/chart/v3/chart.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package v3 import ( "path/filepath" "regexp" "strings" "time" "helm.sh/helm/v4/pkg/chart/common" ) // APIVersionV3 is the API version number for version 3. const APIVersionV3 = "v3" // aliasNameFormat defines the characters that are legal in an alias name. var aliasNameFormat = regexp.MustCompile("^[a-zA-Z0-9_-]+$") // Chart is a helm package that contains metadata, a default config, zero or more // optionally parameterizable templates, and zero or more charts (dependencies). type Chart struct { // Raw contains the raw contents of the files originally contained in the chart archive. // // This should not be used except in special cases like `helm show values`, // where we want to display the raw values, comments and all. Raw []*common.File `json:"-"` // Metadata is the contents of the Chartfile. Metadata *Metadata `json:"metadata"` // Lock is the contents of Chart.lock. Lock *Lock `json:"lock"` // Templates for this chart. Templates []*common.File `json:"templates"` // Values are default config for this chart. Values map[string]interface{} `json:"values"` // Schema is an optional JSON schema for imposing structure on Values Schema []byte `json:"schema"` // SchemaModTime the schema was last modified SchemaModTime time.Time `json:"schemamodtime,omitempty"` // Files are miscellaneous files in a chart archive, // e.g. README, LICENSE, etc. Files []*common.File `json:"files"` // ModTime the chart metadata was last modified ModTime time.Time `json:"modtime,omitzero"` parent *Chart dependencies []*Chart } type CRD struct { // Name is the File.Name for the crd file Name string // Filename is the File obj Name including (sub-)chart.ChartFullPath Filename string // File is the File obj for the crd File *common.File } // SetDependencies replaces the chart dependencies. func (ch *Chart) SetDependencies(charts ...*Chart) { ch.dependencies = nil ch.AddDependency(charts...) } // Name returns the name of the chart. func (ch *Chart) Name() string { if ch.Metadata == nil { return "" } return ch.Metadata.Name } // AddDependency determines if the chart is a subchart. func (ch *Chart) AddDependency(charts ...*Chart) { for i, x := range charts { charts[i].parent = ch ch.dependencies = append(ch.dependencies, x) } } // Root finds the root chart. func (ch *Chart) Root() *Chart { if ch.IsRoot() { return ch } return ch.Parent().Root() } // Dependencies are the charts that this chart depends on. func (ch *Chart) Dependencies() []*Chart { return ch.dependencies } // IsRoot determines if the chart is the root chart. func (ch *Chart) IsRoot() bool { return ch.parent == nil } // Parent returns a subchart's parent chart. func (ch *Chart) Parent() *Chart { return ch.parent } // ChartPath returns the full path to this chart in dot notation. func (ch *Chart) ChartPath() string { if !ch.IsRoot() { return ch.Parent().ChartPath() + "." + ch.Name() } return ch.Name() } // ChartFullPath returns the full path to this chart. // Note that the path may not correspond to the path where the file can be found on the file system if the path // points to an aliased subchart. func (ch *Chart) ChartFullPath() string { if !ch.IsRoot() { return ch.Parent().ChartFullPath() + "/charts/" + ch.Name() } return ch.Name() } // Validate validates the metadata. func (ch *Chart) Validate() error { return ch.Metadata.Validate() } // AppVersion returns the appversion of the chart. func (ch *Chart) AppVersion() string { if ch.Metadata == nil { return "" } return ch.Metadata.AppVersion } // CRDs returns a list of File objects in the 'crds/' directory of a Helm chart. // Deprecated: use CRDObjects() func (ch *Chart) CRDs() []*common.File { files := []*common.File{} // Find all resources in the crds/ directory for _, f := range ch.Files { if strings.HasPrefix(f.Name, "crds/") && hasManifestExtension(f.Name) { files = append(files, f) } } // Get CRDs from dependencies, too. for _, dep := range ch.Dependencies() { files = append(files, dep.CRDs()...) } return files } // CRDObjects returns a list of CRD objects in the 'crds/' directory of a Helm chart & subcharts func (ch *Chart) CRDObjects() []CRD { crds := []CRD{} // Find all resources in the crds/ directory for _, f := range ch.Files { if strings.HasPrefix(f.Name, "crds/") && hasManifestExtension(f.Name) { mycrd := CRD{Name: f.Name, Filename: filepath.Join(ch.ChartFullPath(), f.Name), File: f} crds = append(crds, mycrd) } } // Get CRDs from dependencies, too. for _, dep := range ch.Dependencies() { crds = append(crds, dep.CRDObjects()...) } return crds } func hasManifestExtension(fname string) bool { ext := filepath.Ext(fname) return strings.EqualFold(ext, ".yaml") || strings.EqualFold(ext, ".yml") || strings.EqualFold(ext, ".json") }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/chart/v3/fuzz_test.go
internal/chart/v3/fuzz_test.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package v3 import ( "testing" fuzz "github.com/AdaLogics/go-fuzz-headers" ) func FuzzMetadataValidate(f *testing.F) { f.Fuzz(func(t *testing.T, data []byte) { fdp := fuzz.NewConsumer(data) // Add random values to the metadata md := &Metadata{} err := fdp.GenerateStruct(md) if err != nil { t.Skip() } md.Validate() }) } func FuzzDependencyValidate(f *testing.F) { f.Fuzz(func(t *testing.T, data []byte) { f := fuzz.NewConsumer(data) // Add random values to the dependenci d := &Dependency{} err := f.GenerateStruct(d) if err != nil { t.Skip() } d.Validate() }) }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/chart/v3/dependency.go
internal/chart/v3/dependency.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package v3 import "time" // Dependency describes a chart upon which another chart depends. // // Dependencies can be used to express developer intent, or to capture the state // of a chart. type Dependency struct { // Name is the name of the dependency. // // This must mach the name in the dependency's Chart.yaml. Name string `json:"name" yaml:"name"` // Version is the version (range) of this chart. // // A lock file will always produce a single version, while a dependency // may contain a semantic version range. Version string `json:"version,omitempty" yaml:"version,omitempty"` // The URL to the repository. // // Appending `index.yaml` to this string should result in a URL that can be // used to fetch the repository index. Repository string `json:"repository" yaml:"repository"` // A yaml path that resolves to a boolean, used for enabling/disabling charts (e.g. subchart1.enabled ) Condition string `json:"condition,omitempty" yaml:"condition,omitempty"` // Tags can be used to group charts for enabling/disabling together Tags []string `json:"tags,omitempty" yaml:"tags,omitempty"` // Enabled bool determines if chart should be loaded Enabled bool `json:"enabled,omitempty" yaml:"enabled,omitempty"` // ImportValues holds the mapping of source values to parent key to be imported. Each item can be a // string or pair of child/parent sublist items. ImportValues []interface{} `json:"import-values,omitempty" yaml:"import-values,omitempty"` // Alias usable alias to be used for the chart Alias string `json:"alias,omitempty" yaml:"alias,omitempty"` } // Validate checks for common problems with the dependency datastructure in // the chart. This check must be done at load time before the dependency's charts are // loaded. func (d *Dependency) Validate() error { if d == nil { return ValidationError("dependencies must not contain empty or null nodes") } d.Name = sanitizeString(d.Name) d.Version = sanitizeString(d.Version) d.Repository = sanitizeString(d.Repository) d.Condition = sanitizeString(d.Condition) for i := range d.Tags { d.Tags[i] = sanitizeString(d.Tags[i]) } if d.Alias != "" && !aliasNameFormat.MatchString(d.Alias) { return ValidationErrorf("dependency %q has disallowed characters in the alias", d.Name) } return nil } // Lock is a lock file for dependencies. // // It represents the state that the dependencies should be in. type Lock struct { // Generated is the date the lock file was last generated. Generated time.Time `json:"generated"` // Digest is a hash of the dependencies in Chart.yaml. Digest string `json:"digest"` // Dependencies is the list of dependencies that this lock file has locked. Dependencies []*Dependency `json:"dependencies"` }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/chart/v3/errors.go
internal/chart/v3/errors.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package v3 import "fmt" // ValidationError represents a data validation error. type ValidationError string func (v ValidationError) Error() string { return "validation: " + string(v) } // ValidationErrorf takes a message and formatting options and creates a ValidationError func ValidationErrorf(msg string, args ...interface{}) ValidationError { return ValidationError(fmt.Sprintf(msg, args...)) }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false
helm/helm
https://github.com/helm/helm/blob/08f17fc9474ca51006427319bfa35e7630961a70/internal/chart/v3/metadata.go
internal/chart/v3/metadata.go
/* Copyright The Helm Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. */ package v3 import ( "path/filepath" "strings" "unicode" "github.com/Masterminds/semver/v3" ) // Maintainer describes a Chart maintainer. type Maintainer struct { // Name is a user name or organization name Name string `json:"name,omitempty"` // Email is an optional email address to contact the named maintainer Email string `json:"email,omitempty"` // URL is an optional URL to an address for the named maintainer URL string `json:"url,omitempty"` } // Validate checks valid data and sanitizes string characters. func (m *Maintainer) Validate() error { if m == nil { return ValidationError("maintainers must not contain empty or null nodes") } m.Name = sanitizeString(m.Name) m.Email = sanitizeString(m.Email) m.URL = sanitizeString(m.URL) return nil } // Metadata for a Chart file. This models the structure of a Chart.yaml file. type Metadata struct { // The name of the chart. Required. Name string `json:"name,omitempty"` // The URL to a relevant project page, git repo, or contact person Home string `json:"home,omitempty"` // Source is the URL to the source code of this chart Sources []string `json:"sources,omitempty"` // A SemVer 2 conformant version string of the chart. Required. Version string `json:"version,omitempty"` // A one-sentence description of the chart Description string `json:"description,omitempty"` // A list of string keywords Keywords []string `json:"keywords,omitempty"` // A list of name and URL/email address combinations for the maintainer(s) Maintainers []*Maintainer `json:"maintainers,omitempty"` // The URL to an icon file. Icon string `json:"icon,omitempty"` // The API Version of this chart. Required. APIVersion string `json:"apiVersion,omitempty"` // The condition to check to enable chart Condition string `json:"condition,omitempty"` // The tags to check to enable chart Tags string `json:"tags,omitempty"` // The version of the application enclosed inside of this chart. AppVersion string `json:"appVersion,omitempty"` // Whether or not this chart is deprecated Deprecated bool `json:"deprecated,omitempty"` // Annotations are additional mappings uninterpreted by Helm, // made available for inspection by other applications. Annotations map[string]string `json:"annotations,omitempty"` // KubeVersion is a SemVer constraint specifying the version of Kubernetes required. KubeVersion string `json:"kubeVersion,omitempty"` // Dependencies are a list of dependencies for a chart. Dependencies []*Dependency `json:"dependencies,omitempty"` // Specifies the chart type: application or library Type string `json:"type,omitempty"` } // Validate checks the metadata for known issues and sanitizes string // characters. func (md *Metadata) Validate() error { if md == nil { return ValidationError("chart.metadata is required") } md.Name = sanitizeString(md.Name) md.Description = sanitizeString(md.Description) md.Home = sanitizeString(md.Home) md.Icon = sanitizeString(md.Icon) md.Condition = sanitizeString(md.Condition) md.Tags = sanitizeString(md.Tags) md.AppVersion = sanitizeString(md.AppVersion) md.KubeVersion = sanitizeString(md.KubeVersion) for i := range md.Sources { md.Sources[i] = sanitizeString(md.Sources[i]) } for i := range md.Keywords { md.Keywords[i] = sanitizeString(md.Keywords[i]) } if md.APIVersion == "" { return ValidationError("chart.metadata.apiVersion is required") } if md.Name == "" { return ValidationError("chart.metadata.name is required") } if md.Name != filepath.Base(md.Name) { return ValidationErrorf("chart.metadata.name %q is invalid", md.Name) } if md.Version == "" { return ValidationError("chart.metadata.version is required") } if !isValidSemver(md.Version) { return ValidationErrorf("chart.metadata.version %q is invalid", md.Version) } if !isValidChartType(md.Type) { return ValidationError("chart.metadata.type must be application or library") } for _, m := range md.Maintainers { if err := m.Validate(); err != nil { return err } } // Aliases need to be validated here to make sure that the alias name does // not contain any illegal characters. dependencies := map[string]*Dependency{} for _, dependency := range md.Dependencies { if err := dependency.Validate(); err != nil { return err } key := dependency.Name if dependency.Alias != "" { key = dependency.Alias } if dependencies[key] != nil { return ValidationErrorf("more than one dependency with name or alias %q", key) } dependencies[key] = dependency } return nil } func isValidChartType(in string) bool { switch in { case "", "application", "library": return true } return false } func isValidSemver(v string) bool { _, err := semver.NewVersion(v) return err == nil } // sanitizeString normalize spaces and removes non-printable characters. func sanitizeString(str string) string { return strings.Map(func(r rune) rune { if unicode.IsSpace(r) { return ' ' } if unicode.IsPrint(r) { return r } return -1 }, str) }
go
Apache-2.0
08f17fc9474ca51006427319bfa35e7630961a70
2026-01-07T08:36:55.903988Z
false