repo stringclasses 1
value | instance_id stringlengths 22 24 | problem_statement stringlengths 30 24.1k | patch stringlengths 0 1.9M | test_patch stringclasses 1
value | created_at stringdate 2022-11-25 05:12:07 2025-06-13 10:24:29 | hints_text stringlengths 0 228k | base_commit stringlengths 40 40 | test_instructions stringlengths 0 232k | filenames listlengths 0 300 |
|---|---|---|---|---|---|---|---|---|---|
juspay/hyperswitch | juspay__hyperswitch-2312 | Bug: [FEATURE]: [Payeezy] Use `connector_request_reference_id` as reference to the connector
### :memo: Feature Description
- We transmit our reference id from Hyperswitch to the connector, enabling merchants to subsequently locate the payment within the connector dashboard.
- Presently, there is a lack of uniform... | diff --git a/crates/router/src/connector/payeezy/transformers.rs b/crates/router/src/connector/payeezy/transformers.rs
index d6c22ba67c3..98e8ea12c00 100644
--- a/crates/router/src/connector/payeezy/transformers.rs
+++ b/crates/router/src/connector/payeezy/transformers.rs
@@ -67,6 +67,7 @@ pub struct PayeezyPaymentsReq... | 2023-10-01T19:11:46Z |
## Description
<!-- Describe your changes in detail -->
Add `connector_response_reference_id` support for Payeezy
- Used `transaction_id` as the reference id, while implementing this!
Resolves #2343 and resolves #2312.
## Motivation and Context
<!--
Why is this change required? What problem does it solve... | 89cb63be3328010d26b5f6322449fc50e80593e4 | Need help testing!
| [
"crates/router/src/connector/payeezy/transformers.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-2340 | Bug: [FEATURE]: [Nuvei] Use `connector_response_reference_id` as reference to merchant
### :memo: Feature Description
- Reference id are used to map transactions in the connector’s dashboard.
- Hyperswitch manages several reference ids, such as `payment_id`, `attempt_id`, and `connector_transaction_id` for a single... | diff --git a/crates/router/src/connector/nuvei/transformers.rs b/crates/router/src/connector/nuvei/transformers.rs
index 21b72955414..cf7d480e0c1 100644
--- a/crates/router/src/connector/nuvei/transformers.rs
+++ b/crates/router/src/connector/nuvei/transformers.rs
@@ -1294,7 +1294,7 @@ where
Ok(types::... | 2023-10-01T18:46:13Z |
## Description
<!-- Describe your changes in detail -->
Nuvei is using just the [order id](https://developer.nuvei.com/chapter-4-payment-page) to track the transaction.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue ... | 89cb63be3328010d26b5f6322449fc50e80593e4 |
I wasn't able to test it on my machine due to ram restrictions.
| [
"crates/router/src/connector/nuvei/transformers.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-2273 | Bug: [REFACTOR]: [Klarna] Remove Default Case Handling
### :memo: Feature Description
- We utilize match statements to make pivotal decisions, such as generating requests based on the payment method type and managing responses received from the connector.
- These conditions generally go hand in hand with enum vari... | diff --git a/crates/router/src/connector/klarna.rs b/crates/router/src/connector/klarna.rs
index 220b8f4a416..1814f9de809 100644
--- a/crates/router/src/connector/klarna.rs
+++ b/crates/router/src/connector/klarna.rs
@@ -288,12 +288,115 @@ impl
self.base_url(connectors),
token
... | 2023-10-01T10:51:34Z |
## Description
Match arms using the wildcard patten (`_`) can be dangereous when extending enums since developers may miss locations where new variants should be handled. This patch expands all wildcard patterns in the Klarna connector to avoid this problem.
## Motivation and Context
Fixes #2273
# | c81d8e9a180da8f71d156d39c9f85847f6d7a572 | `cargo check`, `cargo clippy`, and `cargo test` all pass without errors in modified files.
| [
"crates/router/src/connector/klarna.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-2400 | Bug: [Docs] : Some links not working
## Some index links are not working
- Quick start guide
- Fast integration for stripe users
- Supported Features
- Faq
### Video
https://github.com/juspay/hyperswitch/assets/101205226/70f42b41-4c94-40fb-a538-85ef5ac4dd6c
| diff --git a/README.md b/README.md
index 3306de28704..cc19670a8fc 100644
--- a/README.md
+++ b/README.md
@@ -10,17 +10,17 @@
The single API to access payment ecosystems across 130+ countries</div>
<p align="center">
- <a href="#quick-start-guide">Quick Start Guide</a> •
- <a href="#fast-integration-for-stripe-use... | 2023-10-01T07:16:56Z |
## Description
<!-- Describe your changes in detail -->
## Motivation and Context
Readme hyperlinks not working
# | d8a1bdd3ae0156e0b1da551b50814f7599d6e813 | in my forked repo
| [
"README.md"
] | |
juspay/hyperswitch | juspay__hyperswitch-2154 | Bug: [BUG] merchant account delete does not delete the `merchant_key_store`
### Bug Description
When a merchant is created a `merchant_key_store` is created, which goes along with the `merchant_account`. But when the merchant account is deleted, the key store is not deleted.
### Expected Behavior
Both merchant a... | diff --git a/crates/diesel_models/src/query/merchant_key_store.rs b/crates/diesel_models/src/query/merchant_key_store.rs
index 02a31a1f397..27ec3be9fcd 100644
--- a/crates/diesel_models/src/query/merchant_key_store.rs
+++ b/crates/diesel_models/src/query/merchant_key_store.rs
@@ -27,4 +27,16 @@ impl MerchantKeyStore {
... | 2023-09-26T05:34:38Z |
## Description
<!-- Describe your changes in detail -->
Closes #2154 by calling `delete_merchant_key_store_by_merchant_id` at `merchant_account_delete`
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you do... | 54645cdbf422d59b8751fa9dbb9a61cd72770b0a | [
"crates/diesel_models/src/query/merchant_key_store.rs",
"crates/router/src/core/admin.rs",
"crates/router/src/db/merchant_key_store.rs"
] | ||
juspay/hyperswitch | juspay__hyperswitch-1573 | Bug: [FEATURE] Use OS specific profile path in selenium tests
### Feature Description
Currently the default profile path for browser in selenium.rs file is hardcoded with mac specific file path. it should be made OS specific instead of hardcoding.
### Possible Implementation
Add a feature for OS and handle the p... | diff --git a/.gitignore b/.gitignore
index 81ef10ad213..62804a712fa 100644
--- a/.gitignore
+++ b/.gitignore
@@ -261,3 +261,7 @@ result*
# node_modules
node_modules/
+
+**/connector_auth.toml
+**/sample_auth.toml
+**/auth.toml
diff --git a/crates/test_utils/tests/connectors/adyen_uk_ui.rs b/crates/test_utils/tests/... | 2023-09-17T06:30:00Z |
## Description
<!-- Describe your changes in detail -->
This PR aims at automating Googlepay tests in UI Tests for connectors: Adyen_UK, Bluesnap and Stripe.
Main problem with Google Pay UI automated testing is Captchas.
Google detects automated bots / scripts when you try to login and throws in a captcha the ... | 67a3e8f534aa98a7331cb20a3877579efed6a348 |
See Connector UI tests below in CI checks
| [
".gitignore",
"crates/test_utils/tests/connectors/adyen_uk_ui.rs",
"crates/test_utils/tests/connectors/bluesnap_ui.rs",
"crates/test_utils/tests/connectors/selenium.rs",
"crates/test_utils/tests/connectors/stripe_ui.rs",
"scripts/decrypt_browser_data.sh"
] | |
juspay/hyperswitch | juspay__hyperswitch-2153 | Bug: [FEATURE] log "MERCHANT_ID_NOT_IN_FLOW" if merchant_id is not found
### Feature Description
Here,
https://github.com/juspay/hyperswitch/blob/9b92d046de9fb794d67163582af4360d5e558037/crates/router/src/services/api.rs#L729
Instead of `unwrap_or("")`,
### Possible Implementation
Change it to some const `M... | diff --git a/crates/router/src/services/api.rs b/crates/router/src/services/api.rs
index 99400050df3..6c116e995ce 100644
--- a/crates/router/src/services/api.rs
+++ b/crates/router/src/services/api.rs
@@ -726,7 +726,10 @@ where
.authenticate_and_fetch(request.headers(), state)
.await
.switch(... | 2023-09-13T15:52:31Z |
## Description
<!-- Describe your changes in detail -->
In case the merchant_id is not found from the request, instead of using an empty string `("")` as merchant_id for traces and metrics, use `"MERCHANT_ID_NOT_FOUND"`
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If... | 2fc0efc57b28e987b734aba51892ab1b26e5c79b | [
"crates/router/src/services/api.rs"
] | ||
juspay/hyperswitch | juspay__hyperswitch-2144 | Bug: [REFACTOR] Move `Request` and `RequestBuilder` structs to common_utils crate
### Feature Description
Currently `Request` and `RequestBuilder` structs reside in router crate. Since these are common structs used while building requests for connectors, it's better to move these to `common_utils` crate. This als... | diff --git a/Cargo.lock b/Cargo.lock
index a30738c69da..082bb476dec 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -497,9 +497,9 @@ dependencies = [
[[package]]
name = "async-channel"
-version = "1.8.0"
+version = "1.9.0"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "cf46fee83e5ccffc22... | 2023-09-13T07:56:59Z |
## Description
<!-- Describe your changes in detail -->
Currently `Request` and `RequestBuilder` structs reside in router crate. Since these are common structs used while building requests for connectors, it's better to move these to common_utils crate. This also reduces dependency on router crate for such things
... | bed8326597febd89bb4c961c9085a78b09f99f49 | [
"Cargo.lock",
"crates/common_utils/Cargo.toml",
"crates/common_utils/src/lib.rs",
"crates/common_utils/src/request.rs",
"crates/router/src/services/api.rs",
"crates/router/src/services/api/request.rs",
"crates/router/src/types.rs"
] | ||
juspay/hyperswitch | juspay__hyperswitch-2134 | Bug: [REFACTOR] Move `maskable` to masking crate
### Feature Description
Currently `Maskable` enum and `Mask` trait resides in router crate. Since this is related to masking we can move this to `masking` crate
### Possible Implementation
Move Maskable implementations to masking crate
### Have you spent some ti... | diff --git a/crates/masking/src/lib.rs b/crates/masking/src/lib.rs
index 8c5b03bd4f1..a0c4d3226a2 100644
--- a/crates/masking/src/lib.rs
+++ b/crates/masking/src/lib.rs
@@ -54,3 +54,7 @@ pub mod prelude {
#[cfg(feature = "diesel")]
mod diesel;
+
+pub mod maskable;
+
+pub use maskable::*;
diff --git a/crates/masking... | 2023-09-12T11:40:13Z |
## Description
<!-- Describe your changes in detail -->
Currently `Maskable` enum and `Mask` trait resides in router crate. Since this is related to masking we can move this to `masking` crate
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, pl... | cc8847cce0022b375626b3c86e5b07048833be71 | [
"crates/masking/src/lib.rs",
"crates/masking/src/maskable.rs",
"crates/router/src/services/api/request.rs"
] | ||
juspay/hyperswitch | juspay__hyperswitch-1754 | Bug: [BUGFIX] Replacing the occurrences of `gen_range` with a safe alternative
## Description
Following up with the issue https://github.com/rust-random/rand/issues/1326 created by @lsampras. The function `gen_range` in itself can cause panics and error handling isn't done for some cases. This is a unpredictable ... | diff --git a/Cargo.lock b/Cargo.lock
index 50e5e015a9b..a30738c69da 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -297,6 +297,12 @@ version = "1.0.2"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "f26201604c87b1e01bd3d98f8d5d9a8fcbb815e8cedb41ffccbeb4bf593a35fe"
+[[package]]
+name = "adl... | 2023-09-11T20:15:56Z |
## Description
This is a bugfix for issue [1754](https://github.com/juspay/hyperswitch/issues/1754).
I have replaced the instances of `gen_range()` with `Uniform.sample`.
This should reduce the risk of `gen_range()` throwing a `panic!`.
## Motivation and Context
This is a bugfix for issue [1754](https://gi... | 177d8e5237241d7deea5fd911749ea0a934abcb0 | I did not write any new tests but I ran `cargo test -p router --lib` and all tests passed.
NOTE: I was not able to run all integration tests because my laptop is not setup for running integration tests.
| [
"Cargo.lock",
"crates/router/src/routes/dummy_connector/utils.rs",
"crates/scheduler/src/consumer.rs",
"crates/scheduler/src/producer.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-2132 | Bug: [FEATURE] Add additional parameters in AppState and refactor accordingly
### Feature Description
Some additional parameters : `request_id`, `merchant_id` and `flow_name` are needed in AppState.
### Have you spent some time checking if this feature request has been raised before?
- [X] I checked and did... | diff --git a/crates/router/src/compatibility/stripe/customers.rs b/crates/router/src/compatibility/stripe/customers.rs
index f3f55418d3b..5e9a1899364 100644
--- a/crates/router/src/compatibility/stripe/customers.rs
+++ b/crates/router/src/compatibility/stripe/customers.rs
@@ -42,11 +42,11 @@ pub async fn customer_creat... | 2023-09-11T14:20:44Z |
## Description
<!-- Describe your changes in detail -->
This PR adds additional parameters in `AppState` : `request_id` and `merchant_id` and a couple of functions in AppStateInfo : for adding `merchant_id` and for adding `flow_name` alongside refactoring `AppState` references.
## Motivation and Context
<!--
Wh... | b39369ced97de75d26ac99230d63d3c500123005 |
Manually using Postman.
| [
"crates/router/src/compatibility/stripe/customers.rs",
"crates/router/src/compatibility/stripe/payment_intents.rs",
"crates/router/src/compatibility/stripe/refunds.rs",
"crates/router/src/compatibility/stripe/setup_intents.rs",
"crates/router/src/compatibility/wrap.rs",
"crates/router/src/core/admin.rs",
... | |
juspay/hyperswitch | juspay__hyperswitch-1115 | Bug: [FEATURE] Implement `ReverseLookupInterface` for `MockDb`
Spin out from https://github.com/juspay/hyperswitch/issues/172. Please refer to that issue for more information. | diff --git a/Cargo.lock b/Cargo.lock
index 50e5e015a9b..a30738c69da 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -297,6 +297,12 @@ version = "1.0.2"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "f26201604c87b1e01bd3d98f8d5d9a8fcbb815e8cedb41ffccbeb4bf593a35fe"
+[[package]]
+name = "adl... | 2023-09-11T07:22:06Z | Implement the missing implementation of `MockDb` for `ReverseLookup`
Closes #1115
## Description
<!-- Describe your changes in detail -->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't hav... | a81bfe28edd7fc543af19b9546cbe30492716c97 | [
"Cargo.lock",
"crates/diesel_models/src/reverse_lookup.rs",
"crates/router/src/db/reverse_lookup.rs",
"crates/storage_impl/src/mock_db.rs"
] | ||
juspay/hyperswitch | juspay__hyperswitch-2331 | Bug: [FEATURE]: [GlobalPayments] Use `connector_response_reference_id` as reference to merchant
### :memo: Feature Description
- Reference id are used to map transactions in the connector’s dashboard.
- Hyperswitch manages several reference ids, such as `payment_id`, `attempt_id`, and `connector_transaction_id` for... | diff --git a/Cargo.lock b/Cargo.lock
index 082bb476dec..fff48158ded 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -422,45 +422,6 @@ version = "0.7.3"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "8868f09ff8cea88b079da74ae569d9b8c62a23c68c746240b704ee6f7525c89c"
-[[package]]
-name = "asn... | 2023-09-07T11:34:38Z |
## Description
<!-- Describe your changes in detail -->
This PR enables multiple partial capture for Adyen.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting... | 05696d326f87a08919f177e67bfa54e09fba5147 |
Manual
| [
"Cargo.lock",
"crates/router/src/connector/adyen.rs",
"crates/router/src/connector/adyen/transformers.rs",
"crates/router/src/connector/globalpay.rs",
"crates/router/src/connector/globalpay/requests.rs",
"crates/router/src/connector/globalpay/transformers.rs",
"crates/router/src/connector/utils.rs",
"... | |
juspay/hyperswitch | juspay__hyperswitch-2039 | Bug: Implement `BusinessProfileInterface` for `MockDb`
Spin off of #172
Implement the missing implementation of MockDb for business profiles.
https://github.com/juspay/hyperswitch/blob/b8501f6ae6c0af0804d7f1e7cf9f50ebd303bf94/crates/router/src/db/business_profile.rs#L114
| diff --git a/crates/diesel_models/src/business_profile.rs b/crates/diesel_models/src/business_profile.rs
index 74c75a2bf56..23fe0aed33f 100644
--- a/crates/diesel_models/src/business_profile.rs
+++ b/crates/diesel_models/src/business_profile.rs
@@ -70,3 +70,51 @@ pub struct BusinessProfileUpdateInternal {
pub payo... | 2023-09-07T10:11:38Z | Implement the missing implementation of MockDb for business profiles.
Closes #2039
## Description
<!-- Describe your changes in detail -->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't ha... | 517c5c41655f82ab773f6875447d7d88390d538e | [
"crates/diesel_models/src/business_profile.rs",
"crates/router/src/db/business_profile.rs",
"crates/storage_impl/src/lib.rs"
] | ||
juspay/hyperswitch | juspay__hyperswitch-2084 | Bug: [BUG] : [STAX] Incoming Amount is being processed as dollars instead of cents
### Bug Description
While creating a payment or a refund with connector Stax the incoming amount is being processed in it's higher decimal amount (e.g. Dollars) instead of processing it in it's lower units (e.g. Cents).
### Expe... | diff --git a/crates/router/src/connector/stax/transformers.rs b/crates/router/src/connector/stax/transformers.rs
index d4a9aebeceb..e36f66abb71 100644
--- a/crates/router/src/connector/stax/transformers.rs
+++ b/crates/router/src/connector/stax/transformers.rs
@@ -1,10 +1,12 @@
use common_utils::pii::Email;
-use error... | 2023-09-05T18:46:51Z |
## Description
<!-- Describe your changes in detail -->
While creating a payment or a refund with connector Stax the incoming amount is being processed in it's higher decimal amount (e.g. Dollars) instead of processing it in it's lower units (e.g. Cents).
## Motivation and Context
<!--
Why is this change requi... | 99f1780fd76c7761693df1b22db9104bfa12270b |
Unit testing was completed
<img width="1132" alt="Screenshot 2023-09-06 at 12 15 54 AM" src="https://github.com/juspay/hyperswitch/assets/41580413/df904983-a12a-488f-b6b1-1153276867c9">
| [
"crates/router/src/connector/stax/transformers.rs",
"crates/router/tests/connectors/stax.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-2079 | Bug: [BUG] Refunds - Retrieve is taking unexpectedly high response time
### Bug Description
This endpoint is taking quite a huge response time >~ 300 ms which shouldn't be the case.
### Expected Behavior
It should ideally take a few milliseconds. The endpoint might need to be refactored a bit to fix this.
... | diff --git a/crates/router/src/connector/bluesnap/transformers.rs b/crates/router/src/connector/bluesnap/transformers.rs
index 32455794e3f..e38a4c93420 100644
--- a/crates/router/src/connector/bluesnap/transformers.rs
+++ b/crates/router/src/connector/bluesnap/transformers.rs
@@ -939,7 +939,7 @@ impl From<ErrorDetails>... | 2023-09-04T14:08:38Z |
## Description
<!-- Describe your changes in detail -->
The connector call was being made even when `RefundStatus` was `Success` and hence the response time was going over 300ms. It will be reduced to expected now.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fi... | d4221f33689b2c26b2e5753f9a3b7943811b20a3 | [
"crates/router/src/connector/bluesnap/transformers.rs",
"crates/router/src/core/refunds.rs"
] | ||
juspay/hyperswitch | juspay__hyperswitch-2040 | Bug: [FEATURE] Store necessary Card details in Payment methods table
### Feature Description
Will add support to add Card details in payment method table.
Currently in Payment method customers API, locker call is made for every card payment method to fetch details. Will fetch it from Payment method table instead t... | diff --git a/crates/api_models/src/payment_methods.rs b/crates/api_models/src/payment_methods.rs
index f795513c6ef..4e67ed4d45f 100644
--- a/crates/api_models/src/payment_methods.rs
+++ b/crates/api_models/src/payment_methods.rs
@@ -144,6 +144,20 @@ pub struct PaymentMethodResponse {
pub created: Option<time::Prim... | 2023-09-01T07:55:06Z |
## Description
<!-- Describe your changes in detail -->
Currently, The Customer Payment method List API resorts to a locker call to fetch card details. The latency induced from this is reduced by storing encrypted card details in payment_methods table. This PR does that.
## Motivation and Context
<!--
Why is t... | 9cae5de5ffa27ce71110d703a221da65ac586d29 |
Payments Create - `curl --location --request POST 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_Ia7M1EapArhTiWcTqmQMCLJ4O8lXRbSz8vrxd2nTAZMgOIkBttrLRXFY6owwhlL7' \
--data-raw '{
"amount": 6540,
"currency": "USD",
... | [
"crates/api_models/src/payment_methods.rs",
"crates/diesel_models/src/encryption.rs",
"crates/diesel_models/src/payment_method.rs",
"crates/diesel_models/src/schema.rs",
"crates/router/src/core/payment_methods/cards.rs",
"crates/router/src/core/payments.rs",
"crates/router/src/core/payments/flows.rs",
... | |
juspay/hyperswitch | juspay__hyperswitch-3449 | Bug: [FEATURE] Integrate Stripe Connect for paying out
### Feature Description
Stripe Connect platform enables merchants to onboard and pay to their customers, partners, vendors etc. This is to be added as a Payout Connector.
### Possible Implementation
Integrate Stripe Connect under Stripe connector integration ... | diff --git a/config/config.example.toml b/config/config.example.toml
index 1076cbdc196..b2e1fe3c458 100644
--- a/config/config.example.toml
+++ b/config/config.example.toml
@@ -487,7 +487,7 @@ debit = { currency = "USD" }
[connector_customer]
connector_list = "gocardless,stax,stripe"
-payout_connector_list = "wise"... | 2023-08-29T10:12:01Z |
## Description
This includes integration of StripeConnect APIs in Stripe connector for payouts functionality. For doing the same, there is an addition of a new Payout connector action (PayoutRecipientAccountCreation). This helps in creation of external accounts (bank / card) for Stripe Connect users.
## Motivatio... | 2848e0a3e333ef292130abbeec362f092446270c | - Tested existing payout functionalities using postman test suite.
- Tested Stripe Connect integration using raw PMD + SPMs
- Postman suite - https://galactic-capsule-229427.postman.co/workspace/My-Workspace~2b563e0d-bad3-420f-8c0b-0fd5b278a4fe/collection/9906252-8f51a4d2-86d6-4f72-8198-3fff5a4e71af?action=share&crea... | [
"config/config.example.toml",
"config/development.toml",
"config/docker_compose.toml",
"crates/api_models/src/enums.rs",
"crates/api_models/src/payouts.rs",
"crates/common_enums/src/enums.rs",
"crates/common_utils/src/consts.rs",
"crates/connector_configs/src/connector.rs",
"crates/connector_configs... | |
juspay/hyperswitch | juspay__hyperswitch-1580 | Bug: [enhancement]:Add scoped error enum for customer error
tracked in #1579
We wanna use scoped errors + Errorswitch for customer API's
Currently customer API's returns the common errors enum...
It uses
```
CustomerRedacted
CustomerNotFound
MandateNotFound
& a lot of InternalServerError's
```
inst... | diff --git a/crates/router/src/compatibility/stripe/customers.rs b/crates/router/src/compatibility/stripe/customers.rs
index 0a2cc27f376..f3f55418d3b 100644
--- a/crates/router/src/compatibility/stripe/customers.rs
+++ b/crates/router/src/compatibility/stripe/customers.rs
@@ -39,6 +39,7 @@ pub async fn customer_create(... | 2023-08-22T20:29:32Z |
## Description
Have customers api endpoint specific error logging
## Motivation and Context
Fixes [1580](https://github.com/juspay/hyperswitch/issues/1580)
# | 576648b5a5d7775d295479df3438c913ae855827 | Postman
| [
"crates/router/src/compatibility/stripe/customers.rs",
"crates/router/src/compatibility/stripe/errors.rs",
"crates/router/src/compatibility/stripe/payment_intents.rs",
"crates/router/src/compatibility/stripe/refunds.rs",
"crates/router/src/compatibility/stripe/setup_intents.rs",
"crates/router/src/compati... | |
juspay/hyperswitch | juspay__hyperswitch-1967 | Bug: [FEATURE] add fields in payments list response
### Feature Description
The `payments_list` endpoint currently has the following fields
- payment_id
- merchant_id
- status
- amount
- amount_capturable
- client_secret
- created
- currency
- description
- metadata
- order_details
- customer_id
- conn... | diff --git a/crates/router/src/core/payments/transformers.rs b/crates/router/src/core/payments/transformers.rs
index 56ff409aaf7..0765801dda8 100644
--- a/crates/router/src/core/payments/transformers.rs
+++ b/crates/router/src/core/payments/transformers.rs
@@ -708,6 +708,13 @@ impl ForeignFrom<(storage::PaymentIntent, ... | 2023-08-22T19:52:40Z |
## Description
<!-- Describe your changes in detail -->
added fields
- business_label
- business_country
- business_sub_label
- setup_future_usage
- capture_method
- authentication_type
- connector_transaction_id
in payments list response
## Motivation and Context
<!--
Why is this change required? What... | 1b346fcf5649a24becff2751aa6f93d7a863ee61 |
tested API endpoint locally to check if the fields are added to the response
| [
"crates/router/src/core/payments/transformers.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-1762 | Bug: [BUG] Map zip to postal_code in BillingDetails when making a PaymentsCreate request through SCL
### Bug Description
Currently the `BillingDetails` struct uses `zip` and not `postal_code`. Implement the `AddressDetails` struct for it and do the corresponding mapping to fix `deserialization error` when making ... | diff --git a/Cargo.lock b/Cargo.lock
index bb513916148..6e5967aede2 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -6146,4 +6146,4 @@ dependencies = [
"cc",
"libc",
"pkg-config",
-]
+]
\ No newline at end of file
diff --git a/crates/router/src/compatibility/stripe/payment_intents/types.rs b/crates/router/src/compati... | 2023-08-11T09:23:24Z |
## Description
<!-- Describe your changes in detail -->
SCL accepts `postal_code` instead of `zip` in the `payment_method_data` field. So, this PR adds the corresponding struct changes and mappings for `BillingDetails` -> `AddressDetails`.
## Motivation and Context
<!--
Why is this change required? What problem... | 53de86f60d14981087626e1a2a5856089b6f3899 |
Manually using Postman :
<img width="1728" alt="Screen Shot 2023-08-11 at 2 40 51 PM" src="https://github.com/juspay/hyperswitch/assets/61862301/d228b9e4-183f-4626-a093-c55f5c0e53c8">
| [
"Cargo.lock",
"crates/router/src/compatibility/stripe/payment_intents/types.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-1869 | Bug: [Refactor] Suppress error while saving a card to locker after successful payment
Currently, when a payment succeeds, we save the card details to the locker. If an error occurs during this process, we return an error response, causing an inconsistency between the payment status and the card-saving status. To ens... | diff --git a/crates/router/src/core/payments/flows/authorize_flow.rs b/crates/router/src/core/payments/flows/authorize_flow.rs
index c556271a603..ddeb474548e 100644
--- a/crates/router/src/core/payments/flows/authorize_flow.rs
+++ b/crates/router/src/core/payments/flows/authorize_flow.rs
@@ -80,7 +80,7 @@ impl Feature<... | 2023-08-04T13:59:23Z |
## Description
<!-- Describe your changes in detail -->
Currently, when a payment succeeds, we save the card details to the locker. If an error occurs during this process, we return an error response, causing an inconsistency between the payment status and the card-saving status. To ensure a more accurate representa... | ae3d25e6899af0d78171d40c980146d58f8fc03f |
Made save_in_locker to return InternalServerError
<img width="970" alt="image" src="https://github.com/juspay/hyperswitch/assets/83439957/f1503023-c68b-4e06-b101-b7ce0c26aba6">
<img width="1230" alt="image" src="https://github.com/juspay/hyperswitch/assets/83439957/984deeb1-bff1-46d9-9033-06c18d145f77">
<img wid... | [
"crates/router/src/core/payments/flows/authorize_flow.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-1854 | Bug: [FEATURE] add requires_cvv field to customer payment method list api object
### Feature Description
We don't store the cvv in locker due to PCI compliance. Few connectors like adyen requires cvv to be collected while other connector doesn't .
### Possible Implementation
Add new field in the customer list pa... | diff --git a/crates/api_models/src/payment_methods.rs b/crates/api_models/src/payment_methods.rs
index 248525fcc40..f795513c6ef 100644
--- a/crates/api_models/src/payment_methods.rs
+++ b/crates/api_models/src/payment_methods.rs
@@ -577,6 +577,10 @@ pub struct CustomerPaymentMethod {
#[cfg(feature = "payouts")]
... | 2023-08-02T15:07:35Z |
## Description
<!-- Describe your changes in detail -->
Added new field in the customer list payment method object to include `requires_cvv` field which specifies whether for a given merchant, cvv is a required_field to be collected. If an entry is found in config table, then requires_cvv is set to `false` i.e., by ... | 0d996b8960c7445289e451744c4bdeeb87d7d567 |
ListPaymentMethodForCustomer object
| [
"crates/api_models/src/payment_methods.rs",
"crates/router/src/core/payment_methods/cards.rs",
"openapi/openapi_spec.json"
] | |
juspay/hyperswitch | juspay__hyperswitch-1768 | Bug: [FEATURE] Pre-fill Required fields values in Payment Method List API
### Feature Description
1. The required fields in Payment Method List API needs to be segregated according to mandate/non-mandate payment types and a unified response should be formed for the required fields.
2. The values passed in payments... | diff --git a/crates/api_models/src/payment_methods.rs b/crates/api_models/src/payment_methods.rs
index 749b12f77d2..0d1b3f8f9b6 100644
--- a/crates/api_models/src/payment_methods.rs
+++ b/crates/api_models/src/payment_methods.rs
@@ -1,4 +1,4 @@
-use std::collections::HashSet;
+use std::collections::HashMap;
use card... | 2023-07-31T10:46:37Z |
## Description
<!-- Describe your changes in detail -->
Refactored Required Fields for PM List API. It is now a HashMap instead of a vector.
Have added backend logic to segregate required fields into mandate/non-mandate fields and unify them later on.
Also, refactored the Required Fields to include the value field... | f492d0a943ed57aadc7abed721f90ed9e19e0c88 |
<img width="1512" alt="image" src="https://github.com/juspay/hyperswitch/assets/76486416/82d8c544-ea62-4461-9af7-123baa1cd1ef">
<img width="1512" alt="image" src="https://github.com/juspay/hyperswitch/assets/76486416/2bf8ad22-a37d-496d-a48f-0b7149502aba">
| [
"crates/api_models/src/payment_methods.rs",
"crates/router/src/configs/defaults.rs",
"crates/router/src/configs/settings.rs",
"crates/router/src/core/payment_methods/cards.rs",
"crates/router/src/types/transformers.rs",
"openapi/openapi_spec.json"
] | |
juspay/hyperswitch | juspay__hyperswitch-1809 | Bug: [BUG] Diesel migration to update local database schema
### Bug Description
Apparently, a couple of migrations were skipped due to some reasons and now the DB isn't fully updated. A new diesel migration should be written to update those incomplete tables or columns.
### Possible Solution
A new diesel mi... | diff --git a/crates/diesel_models/src/schema.rs b/crates/diesel_models/src/schema.rs
index c70ad59cfd7..76c0436a79c 100644
--- a/crates/diesel_models/src/schema.rs
+++ b/crates/diesel_models/src/schema.rs
@@ -183,7 +183,7 @@ diesel::table! {
currency -> Varchar,
dispute_stage -> DisputeStage,
... | 2023-07-28T12:00:05Z |
## Description
<!-- Describe your changes in detail -->
This is a part of the attempt to make database even across all environments. This PR contains the migrations for local database.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please lin... | bb6ec49a66bc9380ff0f5eca44cad381b7dc4368 |
Compiles
| [
"crates/diesel_models/src/schema.rs",
"migrations/2023-07-28-111829_update_columns_to_fix_db_diff/down.sql",
"migrations/2023-07-28-111829_update_columns_to_fix_db_diff/up.sql"
] | |
juspay/hyperswitch | juspay__hyperswitch-1800 | Bug: [BUG] Missing payment_method_data mappings in the helpers.rs
### Bug Description
Need to add the mappings for the latest payment methods. This would be a follow-up task for this PR : https://github.com/juspay/hyperswitch/pull/1236.
### Have you spent some time to check if this bug has been raised before?
... | diff --git a/crates/common_enums/src/enums.rs b/crates/common_enums/src/enums.rs
index ba69cedad9c..6e604c52204 100644
--- a/crates/common_enums/src/enums.rs
+++ b/crates/common_enums/src/enums.rs
@@ -954,6 +954,7 @@ pub enum PaymentMethod {
Reward,
Upi,
Voucher,
+ GiftCard,
}
#[derive(
diff --git... | 2023-07-27T09:50:46Z |
## Description
<!-- Describe your changes in detail -->
This is a follow-up change for https://github.com/juspay/hyperswitch/pull/1236. This adds a `foreign_from` implementation for `payment_method_data` for the payment methods correspondence check.
## Motivation and Context
<!--
Why is this change required? Wh... | 3da69f3ee160b022a3e2cf64c78833eb3fd95aea |
Manually using Postman.
| [
"crates/common_enums/src/enums.rs",
"crates/router/src/core/payments/helpers.rs",
"crates/router/src/types/transformers.rs",
"openapi/openapi_spec.json"
] | |
juspay/hyperswitch | juspay__hyperswitch-1750 | Bug: [REFACTOR]: Include Currency Conversion utility functions to `Currency` Trait implementation
### Feature Description
Implement `to_currency_base_unit` and `to_currency_base_unit_asf64` written in `router/src/utils.rs` in Currency trait implemented in `crates/common_enums/enums.rs`.
Also remove `to_currenc... | diff --git a/crates/common_enums/src/enums.rs b/crates/common_enums/src/enums.rs
index 79292641728..d3a15a83f79 100644
--- a/crates/common_enums/src/enums.rs
+++ b/crates/common_enums/src/enums.rs
@@ -1,3 +1,5 @@
+use std::num::TryFromIntError;
+
use router_derive;
use serde::{Deserialize, Serialize};
use utoipa::To... | 2023-07-25T13:40:52Z |
## Description
currency conversion utility functions are converted to Currency methods
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the... | 28a371b24a590787a569f08d84149515b46ebda6 |
Ran cargo test --all-features, cargo check --all-features and cargo clippy --all-features
| [
"crates/common_enums/src/enums.rs",
"crates/router/src/connector/utils.rs",
"crates/router/src/core/payments/flows/session_flow.rs",
"crates/router/src/core/payments/transformers.rs",
"crates/router/src/utils.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-1782 | Bug: [REFACTOR] The `Drop` implementation on `RedisConnectionPool` seems unnecessary
### Description
I'll keep this issue as a source of documentation and decisions taken regarding the graceful shutdown of Redis connections.
When I was working on #1743, I noticed that the `Drop` implementation on `RedisConnect... | diff --git a/crates/redis_interface/src/lib.rs b/crates/redis_interface/src/lib.rs
index b06cc6c274f..3df54d5dc8d 100644
--- a/crates/redis_interface/src/lib.rs
+++ b/crates/redis_interface/src/lib.rs
@@ -33,7 +33,6 @@ pub use self::{commands::*, types::*};
pub struct RedisConnectionPool {
pub pool: fred::pool::R... | 2023-07-25T07:48:22Z |
## Description
<!-- Describe your changes in detail -->
This PR drops the `Drop` implementation (pun intended) on `RedisConnectionPool`.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issu... | af9a4585b26b278ffb298d4e8de13479da447d5f |
Locally, with both a standalone Redis instance and a Redis cluster setup with Docker Compose.
| [
"crates/redis_interface/src/lib.rs",
"crates/router/src/connection.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-1625 | Bug: [BUG] update `api_key_expiry_workflow` to validate the expiry before scheduling the task
### Bug Description
We have a `process_tracker` which schedules the task to future date, and executes it whenever the time is up. We have a feature to schedule a reminder email to notify the merchants when their api_key ... | diff --git a/crates/router/src/core/api_keys.rs b/crates/router/src/core/api_keys.rs
index b26a67d9fe3..129b1f96e20 100644
--- a/crates/router/src/core/api_keys.rs
+++ b/crates/router/src/core/api_keys.rs
@@ -179,6 +179,7 @@ pub async fn create_api_key(
);
// Add process to process_tracker for email reminde... | 2023-07-24T12:02:29Z |
## Description
During the api_key expiry if the merchant sets the expiry to next day or any other day before 7 days, we need to perform a validation something like - calculate the schedule_time of 1st email during api_key creation. if it is before the current_time, don't create an entry in process_tracker.
## Mot... | b719725864c99b655956ab906e26dead71490b75 | I tested the changes manually.
1. First created an API Key with expiry date after more than 7 days from today. Verified `process_tracker` entry is added.
[
](url)
![added_db](https://github.com/juspay/hyperswit... | [
"crates/router/src/core/api_keys.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-1697 | Bug: [FEATURE] Implement `MerchantKeyStoreInterface` for `MockDb`
### Feature Description
Currently the MerchantKeyStoreInterface is not implemented for MockDb. It is required for merchant account functions. And without this implementation, we cannot write tests for them.
### Possible Implementation
Checkout #172... | diff --git a/crates/router/src/db.rs b/crates/router/src/db.rs
index 304e2a0fc74..caf6264db61 100644
--- a/crates/router/src/db.rs
+++ b/crates/router/src/db.rs
@@ -120,6 +120,7 @@ pub struct MockDb {
disputes: Arc<Mutex<Vec<storage::Dispute>>>,
lockers: Arc<Mutex<Vec<storage::LockerMockUp>>>,
mandates: ... | 2023-07-24T04:52:47Z |
## Description
<!-- Describe your changes in detail -->
This PR adds the `MockDb` implementation of `MerchantKeyStoreInterface`. In addition, this PR includes a fix for the `test_connector_label_cache` test in the `merchant_connector_account` module.
## Motivation and Context
<!--
Why is this change required? W... | 1afc54837d5988eaf41f434474c30ec511681bbe |
<img alt="cargo-nextest output" src="https://github.com/juspay/hyperswitch/assets/22217505/710b1e23-9bc2-4953-80a0-073f3ba8d606">
| [
"crates/router/src/db.rs",
"crates/router/src/db/merchant_connector_account.rs",
"crates/router/src/db/merchant_key_store.rs",
"crates/router/src/types/storage.rs",
"crates/router/src/types/storage/merchant_key_store.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-1747 | Bug: [BUG] Internal Server Error when calling the Connector Integration
### Bug Description
Issue is caused when in any Connector `auth_type ` we configure the `auth_type` which is not valid for that particular connector gets stored in the Db. Thus , whenever we call the Connector Integration we get a 500.
Reas... | diff --git a/connector-template/mod.rs b/connector-template/mod.rs
index 653c28962b9..67745e8b4ce 100644
--- a/connector-template/mod.rs
+++ b/connector-template/mod.rs
@@ -77,6 +77,14 @@ impl ConnectorCommon for {{project-name | downcase | pascal_case}} {
fn base_url<'a>(&self, connectors: &'a settings::Connector... | 2023-07-19T09:48:48Z |
## Description
Issue is caused when in any Connector 's `auth_type` we configure the invalid `auth_type` for that particular connector and gets stored in the Db. Thus , whenever we call the Connector Integration we get a 500.
# | 7f947169feac9d15616cc2b1a2aacdfa80f219bf | <img width="1728" alt="Screenshot 2023-07-25 at 5 33 44 PM" src="https://github.com/juspay/hyperswitch/assets/55580080/0f00aa25-071d-47d3-a826-da28d22cf400">
For the wrong `connector_auth_type`
<img width="1728" alt="Screenshot 2023-07-25 at 5 57 06 PM" src="https://github.com/juspay/hyperswitch/assets/55580080... | [
"connector-template/mod.rs",
"crates/router/src/connector/aci.rs",
"crates/router/src/connector/adyen.rs",
"crates/router/src/connector/airwallex.rs",
"crates/router/src/connector/airwallex/transformers.rs",
"crates/router/src/connector/authorizedotnet.rs",
"crates/router/src/connector/authorizedotnet/t... | |
juspay/hyperswitch | juspay__hyperswitch-1532 | Bug: [BUG] "mandate_data" returned as null in the PaymentsCreate response body while creating a new mandate payment
### Bug Description
While creating a new mandate payment, the `mandate_data` field is being returned as **null** in the response body. This occurs even after passing the right `mandate_data` content... | diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs
index a49a8f00fa8..58652009b27 100644
--- a/crates/api_models/src/payments.rs
+++ b/crates/api_models/src/payments.rs
@@ -1422,6 +1422,7 @@ pub struct PaymentsResponse {
pub mandate_id: Option<String>,
/// Provided mandate in... | 2023-07-14T11:23:44Z |
## Description
<!-- Describe your changes in detail -->
Earlier `mandate_data` was being returned as `null`. This PR fixes the same and populates `mandate_data` with the same content as sent in the request body.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes... | c9e20dcd30beb1de0b571dc61a0e843eda3f8ae0 |
Locally using Postman
| [
"crates/api_models/src/payments.rs",
"crates/router/src/core/payments/transformers.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-1314 | Bug: [FEATURE] Adding recon dashboard in hyperswitch dashboard
### Feature Description
*
### Possible Implementation
*
### Have you spent some time to check if this feature request has been raised before?
- [X] I checked and didn't find similar issue
### Have you read the Contributing Guidelines?
- [X] I have... | diff --git a/crates/api_models/src/admin.rs b/crates/api_models/src/admin.rs
index 9868d963fe6..7a6e984776e 100644
--- a/crates/api_models/src/admin.rs
+++ b/crates/api_models/src/admin.rs
@@ -227,6 +227,9 @@ pub struct MerchantAccountResponse {
/// The organization id merchant is associated with
pub organi... | 2023-07-14T10:36:46Z |
## Description
Added is_recon_enabled field in merchant_account table and sending it in retrive merchant_account api
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend st... | 432a8e02e98494bd20bcb8c2a1a425f9504b86c7 |
* check the merchant retrive api
| [
"crates/api_models/src/admin.rs",
"crates/diesel_models/src/merchant_account.rs",
"crates/diesel_models/src/schema.rs",
"crates/router/src/configs/defaults.rs",
"crates/router/src/configs/settings.rs",
"crates/router/src/core/admin.rs",
"crates/router/src/types/api/admin.rs",
"crates/router/src/types/... | |
juspay/hyperswitch | juspay__hyperswitch-6009 | Bug: [$100] Develop Email Template Design
### Please make sure to read this through the below Guidelines before attempting the problem statements
[Contribution Guidelines](https://github.com/juspay/hyperswitch/blob/main/docs/CONTRIBUTING.md)
[Bounty Program Guidelines](https://github.com/juspay/hyperswitch/wiki/... | 2023-07-13T14:33:28Z |
## Description
<!-- Describe your changes in detail -->
This PR fixes the command used to generate release notes in the release new version workflow.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't... | 9112417caee51117c170af6096825c5b1b2bd0e0 |
Locally. Trust me, it works.
| [] | ||
juspay/hyperswitch | juspay__hyperswitch-1741 | Bug: [BUG] Internal Server Error when deleting a payment method
### Bug Description
It bugs out when you try to delete a payment method that you created by throwing a 500.
Reason: We're not storing the payment_method_data in `configs` table but only in the database. The present code tries to delete it from the `... | diff --git a/Cargo.lock b/Cargo.lock
index e42e38db862..f93aa8d1dc8 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -1858,9 +1858,9 @@ dependencies = [
[[package]]
name = "equivalent"
-version = "1.0.0"
+version = "1.0.1"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "88bffebc5d80432c9b1... | 2023-07-12T16:14:18Z |
## Description
<!-- Describe your changes in detail -->
- When a payment is done through saved card flow, the details is stored in Vault. To delete this, we need to pass `payment_method_id`. Since the `payment_method_id` is **not** exposed, it is impossible to delete the payment data
- When a `PaymentMethod` is cre... | 53ccde80467c6b6037b3a0c372aa879d9867571b |
Manual through postman [13/07/2023]
<img width="532" alt="image" src="https://github.com/juspay/hyperswitch/assets/69745008/84684ffa-6a16-4807-a49a-7a1d41a9359b">
Stripe collection for used as reference for testing Payment Methods (Update and Delete)
<img width="1272" alt="image" src="https://github.com/juspay/h... | [
"Cargo.lock",
"crates/router/src/core/payment_methods/cards.rs",
"postman/aci.postman_collection.json",
"postman/bluesnap.postman_collection.json",
"postman/checkout.postman_collection.json",
"postman/hyperswitch.postman_collection.json",
"postman/nmi.postman_collection.json",
"postman/stripe.postman_... | |
juspay/hyperswitch | juspay__hyperswitch-6130 | Bug: [CYPRESS]: Verify Search in "Payment operations" page.
---
### **Title**: Verify Search in "Payment operations" page.
---
### **Description**:
This task is to write and execute automated test cases for various UI elements and functionalities on the "Payment Operations" page. The tests should validat... | diff --git a/crates/api_models/Cargo.toml b/crates/api_models/Cargo.toml
index 4e8710e031c..f1c7e8396da 100644
--- a/crates/api_models/Cargo.toml
+++ b/crates/api_models/Cargo.toml
@@ -10,7 +10,6 @@ license.workspace = true
[features]
default = ["payouts"]
errors = ["dep:actix-web", "dep:reqwest"]
-multiple_mca = []... | 2023-07-11T10:26:05Z |
## Description
<!-- Describe your changes in detail -->
This PR will remove the multiple mca feature. No fields will have default values in primary business details.
- When creating merchant connector account, `business_label` and `business_country` are mandatory. A validation is added to ensure that the business d... | bad9b9482398bb624cb34ae7021837f7af6e8e00 |
- Create a merchant account, without primary business details
- Create connector account without business details -> Error
<img width="829" alt="Screenshot 2023-07-11 at 3 48 23 PM" src="https://github.com/juspay/hyperswitch/assets/48803246/f5ac8294-b38b-48de-ab44-be5f7854aedc">
- Create connector ac... | [
"crates/api_models/Cargo.toml",
"crates/api_models/src/admin.rs",
"crates/router/Cargo.toml",
"crates/router/src/core/admin.rs",
"crates/router/src/core/payments/helpers.rs",
"crates/router/src/core/payments/operations/payment_create.rs",
"openapi/openapi_spec.json"
] | |
juspay/hyperswitch | juspay__hyperswitch-6131 | Bug: [CYPRESS]: Verify Columns in "Payment operations" page.
---
### **Title**: Verify Columns in "Payment operations" page.
---
### **Description**:
This task is to write and execute automated test cases for various UI elements and functionalities on the "Payment Operations" page. The tests should valid... | 2023-07-10T09:17:23Z |
## Description
<!-- Describe your changes in detail -->
- Also push to public docker repositories for all release tags
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend... | b428298030b3c04a249f175b51b7904ab96e2ce7 | [] | |||
juspay/hyperswitch | juspay__hyperswitch-1326 | Bug: [REFACTOR] Define the Mapping between `ConnectorError` and `ApiErrorResponse` using the `ErrorSwitch` trait
### Feature Description
Currently, we are mapping errors from `ConnectorError` to `ApiErrorResponse` using custom logic (can be found [here](https://github.com/juspay/hyperswitch/blob/cd0cf40fe29358700f9... | diff --git a/crates/router/src/core/errors.rs b/crates/router/src/core/errors.rs
index d79e120c5c0..2ab8aff3a0a 100644
--- a/crates/router/src/core/errors.rs
+++ b/crates/router/src/core/errors.rs
@@ -1,5 +1,6 @@
pub mod api_error_response;
pub mod error_handlers;
+pub mod transformers;
pub mod utils;
use std::fm... | 2023-07-08T17:49:30Z |
## Description
<!-- Describe your changes in detail -->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implement... | fb149cb0ff750fbaadf22d263be0f7bfe1574e37 | [
"crates/router/src/core/errors.rs",
"crates/router/src/core/errors/api_error_response.rs",
"crates/router/src/core/errors/transformers.rs",
"crates/router/src/core/webhooks.rs",
"crates/router/src/core/webhooks/utils.rs"
] | ||
juspay/hyperswitch | juspay__hyperswitch-6129 | Bug: [CYPRESS]: Verify Time Range Filters in "Payment operations" page.
---
### **Title**: Verify Time Range Filters in "Payment operations" page.
---
### **Description**:
This task is to write and execute automated test cases for various UI elements and functionalities on the "Payment Operations" page. ... | 2023-07-08T11:58:40Z |
## Description
<!-- Describe your changes in detail -->
This PR updates the schedule for the auto release workflow to run every Tuesday, Wednesday and Thursday.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
I... | f56f9d643451b9a7ff961b21fc6ec0eefac0ebdf |
N/A
| [] | ||
juspay/hyperswitch | juspay__hyperswitch-1649 | Bug: [BUG] Custom address struct not present in the /customers endpoints
### Bug Description
Currently the `/customers` endpoints use address as a `SecretSerdeValue` which may cause inconsistencies going on further. We need to change it to a custom struct type and populate the fields as per our API reference.
... | diff --git a/crates/api_models/src/customers.rs b/crates/api_models/src/customers.rs
index 1c28617d745..d8c864746a8 100644
--- a/crates/api_models/src/customers.rs
+++ b/crates/api_models/src/customers.rs
@@ -3,6 +3,8 @@ use masking::Secret;
use serde::{Deserialize, Serialize};
use utoipa::ToSchema;
+use crate::pay... | 2023-07-07T13:22:40Z |
## Description
<!-- Describe your changes in detail -->
Address of a new customer was being accepted as a `SecretSerdeValue` in the `CustomerCreate` and `CustomerUpdate` requests. This PR does the following :
- Add a new struct `AddressDetails` in the `customers` flow for the `address` field.
- Add the `address... | 5a0e8be8c4a6b112e0f0e5475c876e57802100ab |
Manually
| [
"crates/api_models/src/customers.rs",
"crates/router/src/compatibility/stripe/customers/types.rs",
"crates/router/src/core/customers.rs",
"openapi/openapi_spec.json"
] | |
juspay/hyperswitch | juspay__hyperswitch-1646 | Bug: [BUG] customers endpoints refactoring in the Stripe Compatibility Layer
### Bug Description
There are a couple of mismatches and missing fields in the `/customers` endpoints in the Stripe Compatibility Layer. The corresponding match logic and structs/enums should be added to prevent the flow from breaking.
... | diff --git a/crates/api_models/src/customers.rs b/crates/api_models/src/customers.rs
index 1c28617d745..d8c864746a8 100644
--- a/crates/api_models/src/customers.rs
+++ b/crates/api_models/src/customers.rs
@@ -3,6 +3,8 @@ use masking::Secret;
use serde::{Deserialize, Serialize};
use utoipa::ToSchema;
+use crate::pay... | 2023-07-07T13:22:40Z |
## Description
<!-- Describe your changes in detail -->
Address of a new customer was being accepted as a `SecretSerdeValue` in the `CustomerCreate` and `CustomerUpdate` requests. This PR does the following :
- Add a new struct `AddressDetails` in the `customers` flow for the `address` field.
- Add the `address... | 5a0e8be8c4a6b112e0f0e5475c876e57802100ab |
Manually
| [
"crates/api_models/src/customers.rs",
"crates/router/src/compatibility/stripe/customers/types.rs",
"crates/router/src/core/customers.rs",
"openapi/openapi_spec.json"
] | |
juspay/hyperswitch | juspay__hyperswitch-1541 | Bug: [BUG] `payment_method_id` is not being stored in `payment_methods` table
### Bug Description
`payment_mehod_id` that is created at the time of creating a PaymentMethod is not being stored in `payment_methods` table. This results in database error showing 404 during update and 500 when trying to delete `payment... | diff --git a/crates/router/src/core/payment_methods/cards.rs b/crates/router/src/core/payment_methods/cards.rs
index 5020c877bae..8d7c228df4a 100644
--- a/crates/router/src/core/payment_methods/cards.rs
+++ b/crates/router/src/core/payment_methods/cards.rs
@@ -86,20 +86,26 @@ pub async fn add_payment_method(
let m... | 2023-07-07T12:34:17Z |
## Description
<!-- Describe your changes in detail -->
Currently, payment method create API does not insert payment method record in the Db.
have added the db call to insert the record if not already present.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fi... | 55ff761e9eca313327f67c1d271ea1672d12c339 |
<img width="1512" alt="image" src="https://github.com/juspay/hyperswitch/assets/76486416/29b8d829-367f-4a6a-a84b-4a4e3b35fd6b">
<img width="1495" alt="image" src="https://github.com/juspay/hyperswitch/assets/76486416/ff9e8311-eef7-4beb-9813-60534b216b60">
<img width="1507" alt="image" src="https://github.com/ju... | [
"crates/router/src/core/payment_methods/cards.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-1578 | Bug: [FEATURE] Implement a masking strategy for UPI VPAs
### Feature Description
Unified Payments Interface (UPI) is a popular payment technique in India, used to transfer money among individuals, bill payments and merchant payments. In the case of money transfer among individuals, users are identified with a Vir... | diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs
index 6e489ac492a..a184382e654 100644
--- a/crates/api_models/src/payments.rs
+++ b/crates/api_models/src/payments.rs
@@ -922,7 +922,7 @@ pub struct CryptoData {
#[serde(rename_all = "snake_case")]
pub struct UpiData {
#[schema(va... | 2023-07-06T15:33:58Z |
## Description
<!-- Describe your changes in detail -->
Here, I have implemented masking::Strategy for UPI VPAs which is called UpiVpaMaskingStrategy which masks the identifier completely, and keeps the bank name part in clear text. I have included tests for the same.
## Motivation and Context
<!--
Why is thi... | 9c7ac6246d6cf434855bc61f7cd625101665de5c | [
"crates/api_models/src/payments.rs",
"crates/common_utils/src/pii.rs",
"crates/masking/src/abs.rs",
"crates/masking/src/lib.rs",
"crates/router/src/compatibility/stripe/payment_intents/types.rs",
"crates/router/src/connector/iatapay/transformers.rs"
] | ||
juspay/hyperswitch | juspay__hyperswitch-1632 | Bug: [FEATURE] Add optional fields in the PaymentsCapture Request in Stripe Compatibility Layer
### Feature Description
Currently, there's only one field present in the PaymentsCapture endpoint - `amount_to_capture`. We need to add other fields as well.
### Have you spent some time to check if this feature req... | diff --git a/crates/router/src/compatibility/stripe/payment_intents/types.rs b/crates/router/src/compatibility/stripe/payment_intents/types.rs
index de8af66214d..e06b264cef2 100644
--- a/crates/router/src/compatibility/stripe/payment_intents/types.rs
+++ b/crates/router/src/compatibility/stripe/payment_intents/types.rs... | 2023-07-06T14:25:15Z |
## Description
<!-- Describe your changes in detail -->
This PR adds new fields, enums and structs and does the corresponding mappings wherever required.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you d... | 5a0e8be8c4a6b112e0f0e5475c876e57802100ab |
Manually
| [
"crates/router/src/compatibility/stripe/payment_intents/types.rs",
"crates/router/src/compatibility/stripe/setup_intents/types.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-1616 | Bug: [BUG] Map zip field in address enum to match postal_code as per Stripe API Reference
### Bug Description
Currently the `zip` field in the `address` enum is being passed as `zip` itself. But, according to the Stripe API Reference it needs to be passed as `postal_code`. So, appropriate mapping should be done.
... | diff --git a/crates/router/src/compatibility/stripe/payment_intents/types.rs b/crates/router/src/compatibility/stripe/payment_intents/types.rs
index de8af66214d..e06b264cef2 100644
--- a/crates/router/src/compatibility/stripe/payment_intents/types.rs
+++ b/crates/router/src/compatibility/stripe/payment_intents/types.rs... | 2023-07-06T14:25:15Z |
## Description
<!-- Describe your changes in detail -->
This PR adds new fields, enums and structs and does the corresponding mappings wherever required.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you d... | 5a0e8be8c4a6b112e0f0e5475c876e57802100ab |
Manually
| [
"crates/router/src/compatibility/stripe/payment_intents/types.rs",
"crates/router/src/compatibility/stripe/setup_intents/types.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-1618 | Bug: [BUG] mandate_data is being passed in Response but not in Request while creating/updating/confirming payment intents
### Bug Description
The field `mandate_data` is being populated while processing the request but it's not a request body parameter itself. Add it as a request body parameter in `StripePaymentI... | diff --git a/crates/router/src/compatibility/stripe/payment_intents/types.rs b/crates/router/src/compatibility/stripe/payment_intents/types.rs
index de8af66214d..e06b264cef2 100644
--- a/crates/router/src/compatibility/stripe/payment_intents/types.rs
+++ b/crates/router/src/compatibility/stripe/payment_intents/types.rs... | 2023-07-06T14:25:15Z |
## Description
<!-- Describe your changes in detail -->
This PR adds new fields, enums and structs and does the corresponding mappings wherever required.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you d... | 5a0e8be8c4a6b112e0f0e5475c876e57802100ab |
Manually
| [
"crates/router/src/compatibility/stripe/payment_intents/types.rs",
"crates/router/src/compatibility/stripe/setup_intents/types.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-1615 | Bug: [BUG] Rename fields in Stripe Compatibility Layer as per Stripe API Reference
### Bug Description
The following fields are named incorrectly in the `Stripe Compatibility Layer` :
- Named as `payment_method_type` -> Should be `payment_method_types`
- Named as `mandate_id` -> Should be `mandate`
They n... | diff --git a/crates/router/src/compatibility/stripe/payment_intents/types.rs b/crates/router/src/compatibility/stripe/payment_intents/types.rs
index de8af66214d..e06b264cef2 100644
--- a/crates/router/src/compatibility/stripe/payment_intents/types.rs
+++ b/crates/router/src/compatibility/stripe/payment_intents/types.rs... | 2023-07-06T14:25:15Z |
## Description
<!-- Describe your changes in detail -->
This PR adds new fields, enums and structs and does the corresponding mappings wherever required.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you d... | 5a0e8be8c4a6b112e0f0e5475c876e57802100ab |
Manually
| [
"crates/router/src/compatibility/stripe/payment_intents/types.rs",
"crates/router/src/compatibility/stripe/setup_intents/types.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-1023 | Bug: [BUG] : `connector_name` in `MerchantConnectorCreate` accepts any value
### Bug Description
When creating a merchant connector account, the `connector_name` field is of string type. This would mean that any value can be passed to that field. There is no check done to validate whether the connector name given, ... | diff --git a/crates/api_models/src/admin.rs b/crates/api_models/src/admin.rs
index e7164a2493f..895b137679c 100644
--- a/crates/api_models/src/admin.rs
+++ b/crates/api_models/src/admin.rs
@@ -391,8 +391,8 @@ pub struct MerchantConnectorCreate {
#[schema(value_type = ConnectorType, example = "payment_processor")]
... | 2023-07-06T12:59:54Z |
## Description
When creating a merchant connector account, the connector_name field is of string type. This would mean that any value can be passed to that field. There is no check done to validate whether the connector name given, is actually supported. This creates an issue in the payments flow when the connector i... | d5891ecbd4a110e3885d6504194f7c7811a413d3 | Used Postman Call Payment Connector - Create to test the changes
Testing with a random connector and
<img width="1514" alt="Screenshot 2023-07-06 at 6 45 53 PM" src="https://github.com/juspay/hyperswitch/assets/41580413/16c4f694-0422-4c08-b7d9-08eec169b6ff">
a supported connector:
<img width="1514" alt="Screenshot... | [
"crates/api_models/src/admin.rs",
"crates/router/src/core/admin.rs",
"openapi/openapi_spec.json"
] | |
juspay/hyperswitch | juspay__hyperswitch-1613 | Bug: [FEATURE] add connector_metadata, metadata and feature_metadata fields in payments, remove udf field
### Feature Description
Add connector_metadata, metadata and feature_metadata fields in payments, remove udf field
### Possible Implementation
Add them
### Have you spent some time to check if this featur... | diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs
index e2410699e1c..1f7b3050430 100644
--- a/crates/api_models/src/payments.rs
+++ b/crates/api_models/src/payments.rs
@@ -3,6 +3,7 @@ use std::num::NonZeroI64;
use cards::CardNumber;
use common_utils::{
crypto,
+ ext_traits::En... | 2023-07-03T08:07:28Z |
## Description
<!-- Describe your changes in detail -->
In this PR ,
#### API CONTRACT CHANGES
In `PaymentsRequest` 3 fields are added :
- connector_metadata(typed),
- feature_metadata(typed),
- metadata(can take any json),
also previous backwards compatibility to accept order_details in metadata is remo... | 737aeb6b0a083bdbcde169d4cfeb40ebc6f4378e |
Tested order_category. It works. And made sure get_trackers payment_data.payment_intent is populated with the fields.
| [
"crates/api_models/src/payments.rs",
"crates/router/src/compatibility/stripe/payment_intents/types.rs",
"crates/router/src/compatibility/stripe/setup_intents/types.rs",
"crates/router/src/core/payment_methods/cards.rs",
"crates/router/src/core/payments.rs",
"crates/router/src/core/payments/helpers.rs",
... | |
juspay/hyperswitch | juspay__hyperswitch-997 | Bug: [FEATURE] Implement `ConfigInterface` for `MockDb`
Spin out from #172. Please refer to that issue for more information. | diff --git a/crates/router/src/db.rs b/crates/router/src/db.rs
index 0694b5a3020..0bc43e6d567 100644
--- a/crates/router/src/db.rs
+++ b/crates/router/src/db.rs
@@ -98,6 +98,7 @@ impl StorageInterface for Store {}
#[derive(Clone)]
pub struct MockDb {
addresses: Arc<Mutex<Vec<storage::Address>>>,
+ configs: Ar... | 2023-07-02T10:03:22Z |
## Description
<!-- Describe your changes in detail -->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implement... | 47cd08a0b07d457793d376b6cca3143011426f22 | [
"crates/router/src/db.rs",
"crates/router/src/db/configs.rs",
"crates/storage_models/src/configs.rs"
] | ||
juspay/hyperswitch | juspay__hyperswitch-1327 | Bug: [REFACTOR] remove redundant call to fetch payment method data
In case of `payments_start` operation, there is a call to fetch payment method data ( which makes a call to the locker to fetch payment method data ). This call is not necessary since we do not need payment method data in that flow. This would add ad... | diff --git a/crates/router/src/core/payments/operations/payment_start.rs b/crates/router/src/core/payments/operations/payment_start.rs
index 5cd2d11c081..2e2904d9746 100644
--- a/crates/router/src/core/payments/operations/payment_start.rs
+++ b/crates/router/src/core/payments/operations/payment_start.rs
@@ -241,14 +241... | 2023-06-30T13:59:55Z |
## Description
<!-- Describe your changes in detail -->
This pull request removes the unnecessary call to fetch payment method data in the payments_start operation of the PaymentStart implementation. The payment method data fetch adds additional latency to the payments flow without being required in this particular ... | 88860b9c0be0bc91bcdd6f89b60eb43a18b83b08 | [
"crates/router/src/core/payments/operations/payment_start.rs"
] | ||
juspay/hyperswitch | juspay__hyperswitch-1439 | Bug: [BUG] Payments list doesn't work with pagination parameters
### Context
- Currently the API accepts payment_id as pagination parameters for e.g starting_after = `pay_Ajabdhakjhah`
- However the underlying code relies on the auto-increment characteristic of databases
- While we do some sort of conversion here... | diff --git a/crates/router/src/core/payments.rs b/crates/router/src/core/payments.rs
index 384a2230389..c9bc3d0a649 100644
--- a/crates/router/src/core/payments.rs
+++ b/crates/router/src/core/payments.rs
@@ -1204,8 +1204,6 @@ pub async fn list_payments(
merchant: domain::MerchantAccount,
constraints: api::Pa... | 2023-06-28T02:17:37Z |
## Description
Sorted the payment list order in API response for descending based on `created_at` parameter. It allows the database fetches to be asycn and is collected in an hashmap and collected later in a descending order.
## Motivation and Context
Fixes #1439.
<!--
If you don't have an issue, we'd re... | 06f92c2c4c267e3d6ec914670684bb36b71ecd51 |
There were no new tests written (Although if needed we can write 1 test to check descending order in postman). But the endpoints behaviour was tested using postman.
| [
"crates/router/src/core/payments.rs",
"crates/router/src/types/storage/payment_intent.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-6124 | Bug: [CYPRESS]: Use the SDK to process a payment.
---
### **Title**: Verify Make and View a Test Payment
---
### **Description**:
This task involves testing the "Make a test payment" feature from the homepage. The user will go through the checkout process, entering payment details and viewing the payment... | diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs
index 2d4a539c1e9..453d1521226 100644
--- a/crates/api_models/src/payments.rs
+++ b/crates/api_models/src/payments.rs
@@ -9,6 +9,7 @@ use common_utils::{
use masking::{PeekInterface, Secret};
use router_derive::Setter;
use time::Primi... | 2023-06-27T14:05:27Z |
## Description
<!-- Describe your changes in detail -->
Add support for WeChat Pay, we chat pay in stripe doesn't follow redirection.Qr code url is given in the next action, this qr code has to be shown in sdk.
API contract for WeChat Pay:
```
"payment_method": "wallet",
"payment_method_type": "we_chat... | ca4e242d206dc69a10a1fbf51805a4cf4885a35e |
Manual
Qr code url in next action
<img width="1264" alt="Screen Shot 2023-06-27 at 6 16 14 PM" src="https://github.com/juspay/hyperswitch/assets/59434228/eef065bd-f0ef-47b4-899d-89c42545a52c">
Qr code
<img width="1545" alt="Screen Shot 2023-06-27 at 6 15 53 PM" src="https://github.com/juspay/hyperswitch/asset... | [
"crates/api_models/src/payments.rs",
"crates/router/src/compatibility/stripe/payment_intents/types.rs",
"crates/router/src/compatibility/stripe/setup_intents/types.rs",
"crates/router/src/connector/stripe/transformers.rs",
"crates/router/src/core/payments.rs",
"crates/router/src/core/payments/transformers... | |
juspay/hyperswitch | juspay__hyperswitch-1497 | Bug: [BUG] Make get_redis_conn return result in StorageInterface
### Bug Description
Currently `get_redis_conn` function in StorageInterface exposes `redis_conn` directly instead use `redis_conn()` function from `Store` and return Result in this function.
### Expected Behavior
It should return err in case of redi... | diff --git a/crates/router/src/core/payment_methods/cards.rs b/crates/router/src/core/payment_methods/cards.rs
index 67f498c1e99..00a647ed5c9 100644
--- a/crates/router/src/core/payment_methods/cards.rs
+++ b/crates/router/src/core/payment_methods/cards.rs
@@ -1713,7 +1713,12 @@ pub async fn list_customer_payment_metho... | 2023-06-27T11:38:55Z |
## Description
Fixes #1497
## Motivation and Context
Please find the details in the issue [1497](https://github.com/juspay/hyperswitch/issues/1497)
# | 8186c778bddb8932b37e5cf4c7b3e2d507f73e89 | unit tests and postman
| [
"crates/router/src/core/payment_methods/cards.rs",
"crates/router/src/core/payments.rs",
"crates/router/src/core/payments/helpers.rs",
"crates/router/src/core/payouts/helpers.rs",
"crates/router/src/db.rs",
"crates/router/src/db/api_keys.rs",
"crates/router/src/db/cache.rs",
"crates/router/src/db/merc... | |
juspay/hyperswitch | juspay__hyperswitch-1550 | Bug: [REFACTOR] add `payment_id` and `merchant_id` to logs
The `server_wrap_util()` function will have to record the `merchant_id` as the authentication will happen inside `server_wrap()` function, so that the `payment_id` and `merchant_id` fields are available in the logs. | diff --git a/crates/router/src/services/api.rs b/crates/router/src/services/api.rs
index c8d69d7d51c..353d508c285 100644
--- a/crates/router/src/services/api.rs
+++ b/crates/router/src/services/api.rs
@@ -581,7 +581,7 @@ pub enum AuthFlow {
Merchant,
}
-#[instrument(skip(request, payload, state, func, api_auth)... | 2023-06-27T07:54:32Z |
## Description
<!-- Describe your changes in detail -->
- This PR includes minor changes to support adding payment id in the `Payments` flow logs. These changes will be used in other crates.
- Record `merchant_id` field in `server_wrap_util` where authentication happens.
## Motivation and Context
<!--
Why is... | a899c9738941fd1a34841369c9a13b2ac49dda9c |
The change is not complete yet, will test once this will be integrated in other crate. The project compiles.
| [
"crates/router/src/services/api.rs",
"crates/router/src/types/api/payments.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-1523 | Bug: [BUG] "reason" field not being updated while hitting the Refunds - Update endpoint
### Bug Description
Upon hitting the `Refunds - Update` endpoint, we receive a 200 OK response but the `reason` field is not being updated.
### Expected Behavior
The `reason` field should be updated as per the specified ... | diff --git a/crates/diesel_models/src/refund.rs b/crates/diesel_models/src/refund.rs
index b0b1f03f200..595d54ea7f4 100644
--- a/crates/diesel_models/src/refund.rs
+++ b/crates/diesel_models/src/refund.rs
@@ -190,6 +190,7 @@ impl RefundUpdate {
refund_error_code: pa_update.refund_error_code.or(source.refun... | 2023-06-26T09:49:45Z |
## Description
<!-- Describe your changes in detail -->
The `reason` field is incorrectly mapped in the core logic so this PR modifies that. Also, the `refund_reason` field is missing in the db update function so this PR adds that.
## Motivation and Context
<!--
Why is this change required? What problem does it... | 16a2c46affbd4319ee1106e08922e7f3094adfbe |
Tested manually using Postman.
| [
"crates/diesel_models/src/refund.rs",
"crates/router/src/core/refunds.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-1491 | Bug: Implement `PaymentMethodInterface` for `MockDb`
Spin out from https://github.com/juspay/hyperswitch/issues/172. Please refer to that issue for more information. | diff --git a/crates/router/src/db.rs b/crates/router/src/db.rs
index 3cd510b33e5..378298727a8 100644
--- a/crates/router/src/db.rs
+++ b/crates/router/src/db.rs
@@ -102,6 +102,7 @@ pub struct MockDb {
merchant_connector_accounts: Arc<Mutex<Vec<storage::MerchantConnectorAccount>>>,
payment_attempts: Arc<Mutex<... | 2023-06-23T14:26:37Z |
## Description
<!-- Describe your changes in detail -->
## Motivation and Context
The main motivation is to have MockDb stubs, help to void mocking, and invocation of external database api's.
For more information check https://github.com/juspay/hyperswitch/issues/172
Fixes https://github.com/juspay/hypersw... | e296a49b623004784cece505ab08b172a5aa796c | [
"crates/router/src/db.rs",
"crates/router/src/db/payment_method.rs",
"crates/storage_models/src/payment_method.rs"
] | ||
juspay/hyperswitch | juspay__hyperswitch-1512 | Bug: [BUG] Validate and update 4xx in Files - Delete endpoint
### Bug Description
The following error is being thrown with a 400 error code when we're hitting the Files - Delete endpoint :
`"error": {
"type": "invalid_request",
"message": "Payment method type not supported",
"code":... | diff --git a/crates/router/src/compatibility/stripe/errors.rs b/crates/router/src/compatibility/stripe/errors.rs
index 7e341f071d2..c056b454a6c 100644
--- a/crates/router/src/compatibility/stripe/errors.rs
+++ b/crates/router/src/compatibility/stripe/errors.rs
@@ -202,6 +202,8 @@ pub enum StripeErrorCode {
FileNot... | 2023-06-23T12:55:57Z |
## Description
<!-- Describe your changes in detail -->
Introduced new error `FileProviderNotSupported` and fixed the error mapping for the `Files - Delete` endpoint thrown when the file storage is not `router`.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes... | 9a88a32d5092cdacacc41bc8ec12ff56d4f53adf |
Tested manually using Postman.
| [
"crates/router/src/compatibility/stripe/errors.rs",
"crates/router/src/core/errors/api_error_response.rs",
"crates/router/src/core/files/helpers.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-1513 | Bug: [BUG] API Handler missing for Disputes - Retrieve Evidence endpoint
### Bug Description
API Handler is missing (got removed somehow) for the `Disputes - Retrieve Evidence` endpoint. This results in a Content Not Found error (404).
### Expected Behavior
The endpoint is implemented and working fine. It s... | diff --git a/crates/router/src/routes/app.rs b/crates/router/src/routes/app.rs
index f153850ce87..35e366ac6f3 100644
--- a/crates/router/src/routes/app.rs
+++ b/crates/router/src/routes/app.rs
@@ -464,6 +464,10 @@ impl Disputes {
.route(web::post().to(submit_dispute_evidence))
... | 2023-06-22T13:23:28Z |
## Description
<!-- Describe your changes in detail -->
This PR adds the missing API Handler for the mentioned endpoint.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recomme... | ff17b62dc27092b6e04d19604e02e8f492c19efb |
Locally using Postman.
| [
"crates/router/src/routes/app.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-1522 | Bug: [BUG] Braintree throws payment status as succeeded while it is still processing the payment
### Bug Description
When you make a payment through Braintree, it directly gives the payment status as succeeded instead of Processing since `SubmittedForSettlement` has to be mapped to `Pending` instead of `Charged`. ... | diff --git a/crates/router/src/connector/braintree/transformers.rs b/crates/router/src/connector/braintree/transformers.rs
index b5e81097ca1..ce1fa2262ad 100644
--- a/crates/router/src/connector/braintree/transformers.rs
+++ b/crates/router/src/connector/braintree/transformers.rs
@@ -184,9 +184,7 @@ pub enum BraintreeP... | 2023-06-22T11:16:20Z |
## Description
<!-- Describe your changes in detail -->
`SubmittedForSettlement` in Braintree is set to `Pending` since it `SubmittedForSettlement` changes is a nightly process and takes time to finish the payment. Docs attached below:
- https://developer.paypal.com/braintree/docs/reference/general/statuses#submitt... | 69e9e518f40c4267c1d58b455b83088e431f767f |
Manually
| [
"crates/router/src/connector/braintree/transformers.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-1495 | Bug: [BUG] : Bank Transfer status mapping is wrong for stripe
### Bug Description
While making the payment for bank transfer its going to "processing" state instead of "requires_customer_action".
Even after payment sync also its in processing state.
### Expected Behavior
It should be in "requires_customer_action... | diff --git a/crates/router/src/connector/trustpay/transformers.rs b/crates/router/src/connector/trustpay/transformers.rs
index e93c0358b80..ffb84059f11 100644
--- a/crates/router/src/connector/trustpay/transformers.rs
+++ b/crates/router/src/connector/trustpay/transformers.rs
@@ -950,6 +950,7 @@ impl<F, T>
... | 2023-06-21T11:54:15Z |
## Description
<!-- Describe your changes in detail -->
The status of `router_data` was being updated after update trackers to `processing`. But in case of Bank transfers, the status of payment is updated in pre processing steps, so we need to persist the routerdata instead of overriding it.
## Motivation and C... | 6645c4d123399e2b6615c02932adf4571b8bcd91 |
- Test stripe card payment
- Test ach bank transfers.
- Test shift4 3ds
- Test applepay trustpay
| [
"crates/router/src/connector/trustpay/transformers.rs",
"crates/router/src/core/payments.rs",
"crates/router/src/core/payments/flows.rs",
"crates/router/src/core/payments/flows/authorize_flow.rs",
"crates/router/src/core/payments/flows/cancel_flow.rs",
"crates/router/src/core/payments/flows/capture_flow.r... | |
juspay/hyperswitch | juspay__hyperswitch-1293 | Bug: [PERF] Remove redundant heap allocation present in the logging framework
Use here, below, and in similar places, the`format_args!()` macro instead, to omit redundant allocations produced by the `format!()` macro (as it returns a new `String`).
## Code Snippets
- https://github.com/juspay/hyperswitch/blob/... | diff --git a/crates/router_env/src/logger/formatter.rs b/crates/router_env/src/logger/formatter.rs
index a015f0e48ef..ce2fd74e0e8 100644
--- a/crates/router_env/src/logger/formatter.rs
+++ b/crates/router_env/src/logger/formatter.rs
@@ -205,13 +205,14 @@ where
map_serializer.serialize_entry(VERSION, &self.vers... | 2023-06-20T13:28:36Z |
## Description
Updated macro invocation from the format! to format_args!
## Motivation and Context
[1293](https://github.com/juspay/hyperswitch/issues/1293)
# | c40617aea66eb3c14ad47efbce28374cd28626e0 | [
"crates/router_env/src/logger/formatter.rs"
] | ||
juspay/hyperswitch | juspay__hyperswitch-1475 | Bug: [BUG] PSync does not change the payment status for NMI connector
### Bug Description
It bugs out when you do a payment and make a PSync call. For context, NMI requires you to do a PSync to update the payment status every time you make a payment. Now that, with PSync flow not updating the payment status after d... | diff --git a/crates/router/src/connector/nmi/transformers.rs b/crates/router/src/connector/nmi/transformers.rs
index eb09497cede..a99c1c9f4ba 100644
--- a/crates/router/src/connector/nmi/transformers.rs
+++ b/crates/router/src/connector/nmi/transformers.rs
@@ -510,8 +510,7 @@ impl From<NmiStatus> for enums::AttemptStat... | 2023-06-19T05:05:31Z |
## Description
<!-- Describe your changes in detail -->
This PR aims at fixing the PSync flow for NMI connector that used to keep the payment status as Pending even after doing the PSync call. FYI, NMI requires you to do a PSync call everytime to get the payment status updated and hence this PR is the hotfix for NMI... | 17640858eabb5d5a56a17c9e0a52e5773a0c592f |
Manually.
Payment Create Flow
<img width="1292" alt="image" src="https://github.com/juspay/hyperswitch/assets/69745008/0221bfdb-009c-4978-8cf4-6069abae992d">
<img width="1292" alt="image" src="https://github.com/juspay/hyperswitch/assets/69745008/cb11cb64-8645-4699-8c6a-0c0380df821f">
Payment Refund Flow
<im... | [
"crates/router/src/connector/nmi/transformers.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-1471 | Bug: [BUG] payment status is processing if there is a validation error
### Bug Description
The payment flow is as follows
- Merchant server creates the Payments with amount and currency and other merchant specific fields.
- The SDK confirms the payment with `PaymentMethodData`.
During confirm, the connector ... | diff --git a/crates/router/src/connector/airwallex.rs b/crates/router/src/connector/airwallex.rs
index 2c4915c40c8..1a95f670426 100644
--- a/crates/router/src/connector/airwallex.rs
+++ b/crates/router/src/connector/airwallex.rs
@@ -308,6 +308,7 @@ impl ConnectorIntegration<api::Authorize, types::PaymentsAuthorizeData,... | 2023-06-18T05:17:48Z |
## Description
<!-- Describe your changes in detail -->
Update trackers has been moved before callling the connector. This is to make sure that if there is any validation error, then the payment status will not be updated.
For other flows where connector does not need to be called ( except `session_token` flow, th... | 8032e0290b0a0ee33a640740b3bd4567a939712c |
- Create a payment with zen, without email - Payment status is `requires_payment_method`.
- Confirm the payment - error is Missing required param: email
- Retrieve the payment - status will be `requires_payment_method`.
| [
"crates/router/src/connector/airwallex.rs",
"crates/router/src/connector/nuvei.rs",
"crates/router/src/connector/shift4.rs",
"crates/router/src/core/disputes.rs",
"crates/router/src/core/files/helpers.rs",
"crates/router/src/core/payments.rs",
"crates/router/src/core/payments/access_token.rs",
"crates... | |
juspay/hyperswitch | juspay__hyperswitch-1446 | Bug: [REFACTOR] accept customer details in customer object
Currently, for a payment, the `CustomerDetails` such as email, phone, name are accepted in the `PaymentsRequest` struct
https://github.com/juspay/hyperswitch/blob/795500797d1061630b5ca493187a4e19d98d26c0/crates/api_models/src/payments.rs#L59
It is not c... | diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs
index 173b795efa3..53ce196737a 100644
--- a/crates/api_models/src/payments.rs
+++ b/crates/api_models/src/payments.rs
@@ -45,6 +45,28 @@ pub struct BankCodeResponse {
pub eligible_connectors: Vec<String>,
}
+#[derive(Default, Deb... | 2023-06-15T09:12:56Z |
## Description
<!-- Describe your changes in detail -->
This PR will support sending the customer details in the `customers` object in `PaymentsRequest` in all three endpoints
- payments-create
- payments-update
- payments-confirm
The changes are added in a backwards compatible manner, the older fields will b... | a7ac4af5d916ff1e7965be35f347ce0e13407747 |
- Create a payment with customer details outside.
<img width="754" alt="Screenshot 2023-06-15 at 3 28 27 PM" src="https://github.com/juspay/hyperswitch/assets/48803246/e6495cd9-1bd6-4f1f-a800-73847ee6cb72">
- Create a payment with customer details in customers field.
<img width="738" alt="Screenshot 2023-06-15 a... | [
"crates/api_models/src/payments.rs",
"crates/router/src/core/payments/helpers.rs",
"crates/router/src/core/payments/operations/payment_cancel.rs",
"crates/router/src/core/payments/operations/payment_capture.rs",
"crates/router/src/core/payments/operations/payment_complete_authorize.rs",
"crates/router/src... | |
juspay/hyperswitch | juspay__hyperswitch-1348 | Bug: [REFACTOR] Use secrets for sensitive data handled in connector integration
Noticed that this file didn't include changes related to masking of API keys.
Should we take up marking this field (and wherever it's being passed) `Secret` as part of this PR, or a separate one?
https://github.com/ju... | diff --git a/connector-template/transformers.rs b/connector-template/transformers.rs
index d76b63a1f31..ac51bb5e38d 100644
--- a/connector-template/transformers.rs
+++ b/connector-template/transformers.rs
@@ -53,7 +53,7 @@ impl TryFrom<&types::ConnectorAuthType> for {{project-name | downcase | pascal_c
fn try_from... | 2023-06-14T14:47:56Z |
## Description
<!-- Describe your changes in detail -->
This PR addresses an issue related to handling sensitive data in the connector integration. Previously, the `api_key` field in `transformers.rs` was stored as a plain text string, which posed a security risk. This could potentially expose the API key to unautho... | 9e2868ccf86854135a6f0668985d92fae72e82ed |
<img width="1000" alt="Screenshot 2023-06-15 at 7 01 26 AM" src="https://github.com/juspay/hyperswitch/assets/83439957/ce44918d-c801-4204-8662-8334f770eef3">
<img width="1215" alt="Screenshot 2023-06-15 at 7 06 27 AM" src="https://github.com/juspay/hyperswitch/assets/83439957/a67f2dbe-b4b6-43e0-ab10-3da4acd0834e">
| [
"connector-template/transformers.rs",
"crates/router/src/connector/aci.rs",
"crates/router/src/connector/aci/transformers.rs",
"crates/router/src/connector/adyen.rs",
"crates/router/src/connector/adyen/transformers.rs",
"crates/router/src/connector/airwallex.rs",
"crates/router/src/connector/airwallex/t... | |
juspay/hyperswitch | juspay__hyperswitch-1425 | Bug: [BUG] Prevent unwarranted 404 responses for `CustomerPaymentMethodsList` endpoint
`CustomerPaymentMethodsList` currently lists all the saved payment methods for a customer,
However if the customer doesn't have any saved method we end up returning 404...
We should instead return an empty array when the cus... | diff --git a/crates/router/src/core/payment_methods/cards.rs b/crates/router/src/core/payment_methods/cards.rs
index 499056aa4e5..a5a5c0917fa 100644
--- a/crates/router/src/core/payment_methods/cards.rs
+++ b/crates/router/src/core/payment_methods/cards.rs
@@ -1562,6 +1562,10 @@ pub async fn list_customer_payment_metho... | 2023-06-13T14:58:56Z |
## Description
<!-- Describe your changes in detail -->
This pull request updates the `list_customer_payment_method` function to modify its behavior when a customer doesn't have any saved payment methods. Currently, it returns a 404 error, which is misleading because the error is actually due to the lack of payment ... | ec2bf2160d9139776672614dfdc5201f17cdef05 | [
"crates/router/src/core/payment_methods/cards.rs"
] | ||
juspay/hyperswitch | juspay__hyperswitch-1374 | Bug: [BUG] `payment_method_type` not set in the payment attempt when making a recurring mandate payment
### Bug Description
When doing a recurring mandate payment, the `payment_method` is set in the newly created payment attempt but the `payment_method_type` is not set.
### Expected Behavior
When fetching t... | diff --git a/crates/router/src/core/payments/helpers.rs b/crates/router/src/core/payments/helpers.rs
index 6d6017f6f81..cee33730706 100644
--- a/crates/router/src/core/payments/helpers.rs
+++ b/crates/router/src/core/payments/helpers.rs
@@ -272,6 +272,7 @@ pub async fn get_token_pm_type_mandate_details(
) -> RouterRes... | 2023-06-12T12:26:28Z |
## Description
<!-- Describe your changes in detail -->
When doing a recurring mandate payment, the `payment_method` is set in the newly created payment attempt but the `payment_method_type` is not set. This PR aims to fix that.
**[#1378](https://github.com/juspay/hyperswitch/pull/1378) HAS TO BE MERGED BEFORE TH... | 17640858eabb5d5a56a17c9e0a52e5773a0c592f |
Manually.
### IMAGES
<img width="1212" alt="image" src="https://github.com/juspay/hyperswitch/assets/69745008/3d3b6bf5-6843-426e-a4dc-5ed564c95a71">
<img width="1212" alt="image" src="https://github.com/juspay/hyperswitch/assets/69745008/41cb05db-4066-4a7e-b3a1-521580a2331c">
<img width="1212" alt="image" src="... | [
"crates/router/src/core/payments/helpers.rs",
"crates/router/src/core/payments/operations/payment_complete_authorize.rs",
"crates/router/src/core/payments/operations/payment_confirm.rs",
"crates/router/src/core/payments/operations/payment_create.rs",
"crates/router/src/core/payments/operations/payment_updat... | |
juspay/hyperswitch | juspay__hyperswitch-1325 | Bug: [BUG] Missing required field `email` during payments_confirm
### Bug Description
It bugs out when a payment is created with the `email` field and then not passing it when confirming the payment.
### Expected Behavior
The confirm payment should succeed, it should take the email which was supplied during the p... | diff --git a/crates/router/src/core/payments/helpers.rs b/crates/router/src/core/payments/helpers.rs
index 3147ef8026b..fb0454da425 100644
--- a/crates/router/src/core/payments/helpers.rs
+++ b/crates/router/src/core/payments/helpers.rs
@@ -35,7 +35,7 @@ use crate::{
self,
types::{self, AsyncL... | 2023-06-09T11:56:11Z |
## Description
<!-- Describe your changes in detail -->
This PR will update the customer details in payment, when sent in the payments request.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't hav... | 8497c55283d548c04b3a01560b06d9594e7d634c |
- Create a payment with no email and check the new customer created
- Create a payment with email id passed
- Email id should be updated
![Uploading Screenshot 2023-06-09 at 5.13.2... | [
"crates/router/src/core/payments/helpers.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-1256 | Bug: Implement `MandateInterface` for `MockDb`
Spin out from https://github.com/juspay/hyperswitch/issues/172. Please refer to that issue for more information. | diff --git a/crates/router/src/db.rs b/crates/router/src/db.rs
index 0bec1c7c081..3cd510b33e5 100644
--- a/crates/router/src/db.rs
+++ b/crates/router/src/db.rs
@@ -112,6 +112,7 @@ pub struct MockDb {
events: Arc<Mutex<Vec<storage::Event>>>,
disputes: Arc<Mutex<Vec<storage::Dispute>>>,
lockers: Arc<Mutex... | 2023-06-08T09:43:46Z |
## Description
<!-- Describe your changes in detail -->
- fixes #1256
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on... | 3a225b2118c52f7b28a40a87bbcd8b126b01eeef | [
"crates/router/src/db.rs",
"crates/router/src/db/mandate.rs"
] | ||
juspay/hyperswitch | juspay__hyperswitch-1373 | Bug: [BUG] Certificate decode failed when creating the session token for `applepay`
### Bug Description
It bugs out when creating session token for `applepay` if the certificate provided is in the wrong format.
### Expected Behavior
If the certificate provided is in the wrong format, then it should error out duri... | diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs
index 83be6c85c3f..96b5e3f29b4 100644
--- a/crates/api_models/src/payments.rs
+++ b/crates/api_models/src/payments.rs
@@ -1713,6 +1713,12 @@ pub struct ApplepaySessionRequest {
pub initiative_context: String,
}
+#[derive(Debug, C... | 2023-06-08T07:04:43Z |
## Description
<!-- Describe your changes in detail -->
We used to have a lot of errors when creating applepay session tokens because of invalid certificates being sent when creating the merchant connector account.
This PR will not allow the merchant connector account to be created if the format of certificates ... | d0d32544c23481a1acd91182055a7a0afb78d723 |
- Create mca with valid certificates -> session tokens are generated correctly
<img width="839" alt="Screenshot 2023-06-08 at 12 26 57 PM" src="https://github.com/juspay/hyperswitch/assets/48803246/4eab7519-4501-45fd-8475-7906216804aa">
- Create mca with invalid applepay certificates.
<img width="1257" alt="Sc... | [
"crates/api_models/src/payments.rs",
"crates/router/src/core/admin.rs",
"crates/router/src/core/payments/helpers.rs",
"crates/router/src/services/api/client.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-1365 | Bug: [BUG] `payment_method_type` not saved when creating a record in the `payment_method` table
### Bug Description
When saving the payment method record to the `payment_method` table after a payment, only the `PaymentMethod` is saved but not the `PaymentMethodType` even if it is present in the request.
### Expect... | diff --git a/crates/router/src/core/payments/flows/authorize_flow.rs b/crates/router/src/core/payments/flows/authorize_flow.rs
index 49d30f6e87e..36d40d7480e 100644
--- a/crates/router/src/core/payments/flows/authorize_flow.rs
+++ b/crates/router/src/core/payments/flows/authorize_flow.rs
@@ -84,6 +84,7 @@ impl Feature<... | 2023-06-07T10:27:25Z |
## Description
<!-- Describe your changes in detail -->
When saving the payment method record to the payment_method table after a payment, only the PaymentMethod is saved but not the PaymentMethodType even if it is present in the request.
This PR fixes that.
<!--
Provide links to the files with corresponding ch... | 5eb033336321b5deb197f4416c8409abf99a8421 |
Manually
<img width="1300" alt="Screenshot 2023-06-07 at 15 41 13" src="https://github.com/juspay/hyperswitch/assets/69745008/ef39a227-3db8-46dc-addd-0206ccc91b79">
<img width="1300" alt="Screenshot 2023-06-07 at 15 41 32" src="https://github.com/juspay/hyperswitch/assets/69745008/a32db4d9-be1f-45ce-add1-c427190971... | [
"crates/router/src/core/payments/flows/authorize_flow.rs",
"crates/router/src/core/payments/flows/verify_flow.rs",
"crates/router/src/core/payments/helpers.rs",
"crates/router/src/core/payments/tokenization.rs",
"crates/router/src/core/payments/transformers.rs",
"crates/router/src/types.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-1354 | Bug: [FEATURE] Inclusion of Customer_ip field for PaymentConfirm flows
### Feature Description
Need to derive Ip_addr of the customer from the headers(x-forwarded-for) to the request.
### Possible Implementation
Creation of customer_ip field in PaymentData and then lower the stuffs down to the PaymentConfirm.
##... | diff --git a/crates/router/src/connector/adyen/transformers.rs b/crates/router/src/connector/adyen/transformers.rs
index ffd4a57db57..e57e13167d8 100644
--- a/crates/router/src/connector/adyen/transformers.rs
+++ b/crates/router/src/connector/adyen/transformers.rs
@@ -1,5 +1,6 @@
use api_models::{enums, payments, webh... | 2023-06-06T15:42:58Z |
## Description
Addition of customer_ip field to be taken from either x-forwarded-for or from request itself.
## Motivation and Context
Will help Sdk team for minimizing latency as currently they are using 3rd party service for requesting the Ip addr.
# | 795500797d1061630b5ca493187a4e19d98d26c0 | Tested it manually
| [
"crates/router/src/connector/adyen/transformers.rs",
"crates/router/src/connector/bambora/transformers.rs",
"crates/router/src/connector/nuvei/transformers.rs",
"crates/router/src/connector/trustpay/transformers.rs",
"crates/router/src/connector/zen/transformers.rs",
"crates/router/src/core/payments.rs",
... | |
juspay/hyperswitch | juspay__hyperswitch-1353 | Bug: [REFACTOR] Unify the `sandbox` and `production` cargo features
### Description
After #1349, this is the next step towards using a single Docker image across all our environments (see #1346). The `sandbox` and `production` features would have to be unified into a single `release` feature instead. This change ... | diff --git a/Dockerfile b/Dockerfile
index 2805ee18325..fb92bd3acb5 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -1,6 +1,5 @@
FROM rust:slim as builder
-ARG RUN_ENV=sandbox
ARG EXTRA_FEATURES=""
RUN apt-get update \
@@ -33,7 +32,7 @@ ENV RUST_BACKTRACE="short"
ENV CARGO_REGISTRIES_CRATES_IO_PROTOCOL="sparse"
... | 2023-06-06T10:43:57Z |
## Description
<!-- Describe your changes in detail -->
This PR unifies the `sandbox` and `production` cargo features into a single feature named `release`.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If yo... | 1322aa757902662a1bd90cc3f09e887a7fdbf841 |
Built a Docker image successfully using the command `docker build --build-arg BINARY=router --build-arg RUN_ENV=sandbox .`.
| [
"Dockerfile",
"crates/router/Cargo.toml",
"crates/router/src/core/payment_methods/transformers.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-1349 | Bug: [REFACTOR] Remove the `pii-encryption-script` cargo feature
### Description
As of now, the `sandbox` and `production` cargo features differ only by the `pii-encryption-script` cargo feature:
https://github.com/juspay/hyperswitch/blob/fc6acd04cb28f02a4f52ec77d8ae003957183ff2/crates/router/Cargo.toml#L19-L2... | diff --git a/config/config.example.toml b/config/config.example.toml
index 28113bfb3cd..645908ee8d9 100644
--- a/config/config.example.toml
+++ b/config/config.example.toml
@@ -101,7 +101,6 @@ admin_api_key = "test_admin" # admin API key for admin authentication. Only
kms_encrypted_admin_api_key = "" # Base64-enco... | 2023-06-05T10:20:44Z |
## Description
<!-- Describe your changes in detail -->
This PR removes the `pii-encryption-script` cargo feature from the `router` crate, and the usage of timestamps to decide and decrypt data stored in the database.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If i... | ba8a17d66f12fce01fa3a2d50bd9a5591bf8ef2f |
Created merchant accounts, customers and payments via Postman locally.
| [
"config/config.example.toml",
"config/development.toml",
"crates/router/Cargo.toml",
"crates/router/src/bin/router.rs",
"crates/router/src/configs/defaults.rs",
"crates/router/src/configs/settings.rs",
"crates/router/src/core/customers.rs",
"crates/router/src/db.rs",
"crates/router/src/db/address.rs... | |
juspay/hyperswitch | juspay__hyperswitch-1257 | Bug: Implement `LockerMockInterface` for `MockDb`
Spin out from https://github.com/juspay/hyperswitch/issues/172. Please refer to that issue for more information. | diff --git a/crates/router/src/db.rs b/crates/router/src/db.rs
index d5f05bfb73a..0bec1c7c081 100644
--- a/crates/router/src/db.rs
+++ b/crates/router/src/db.rs
@@ -111,6 +111,7 @@ pub struct MockDb {
cards_info: Arc<Mutex<Vec<storage::CardInfo>>>,
events: Arc<Mutex<Vec<storage::Event>>>,
disputes: Arc<M... | 2023-06-04T17:55:08Z |
## Description
<!-- Describe your changes in detail -->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implement... | 65d4a95b59ee950ba67ce5b38688a650c5131149 |
I created a unit test for all implemented methods
| [
"crates/router/src/db.rs",
"crates/router/src/db/locker_mock_up.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-1190 | Bug: Implement `DisputeInterface` for `MockDb`
Spin out from https://github.com/juspay/hyperswitch/issues/172. Please refer to that issue for more information. | diff --git a/crates/router/src/db.rs b/crates/router/src/db.rs
index 9023cf71d07..317e8d34fac 100644
--- a/crates/router/src/db.rs
+++ b/crates/router/src/db.rs
@@ -118,6 +118,7 @@ pub struct MockDb {
api_keys: Arc<Mutex<Vec<storage::ApiKey>>>,
cards_info: Arc<Mutex<Vec<storage::CardInfo>>>,
events: Arc<... | 2023-06-03T20:53:21Z |
## Description
<!-- Describe your changes in detail -->
## Motivation and Context
The main motivation is to have MockDb stubs, help to void mocking, and invocation of external database api's.
For more information check https://github.com/juspay/hyperswitch/issues/172
Fixes https://github.com/juspay/hypersw... | 10691c5fce630d60aade862080d25c62a5cddb44 | I created a unit test for all implemented methods
| [
"crates/router/src/db.rs",
"crates/router/src/db/dispute.rs",
"crates/storage_models/src/dispute.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-1335 | Bug: [BUG] unnecessary assertions for `locker_id` on `BasiliskLocker` when saving cards
Currently we support 2 types of lockers for saving cards...
1. BasiliskLocker
2. LegacyLocker
We used to have locker_id as a namespacing identifier for merchants, however that concept is deprecated now with the BasiliskLock... | diff --git a/crates/router/src/core/payment_methods/cards.rs b/crates/router/src/core/payment_methods/cards.rs
index cba6aef7302..499056aa4e5 100644
--- a/crates/router/src/core/payment_methods/cards.rs
+++ b/crates/router/src/core/payment_methods/cards.rs
@@ -262,12 +262,6 @@ pub async fn add_card_hs(
let db = &*... | 2023-06-02T07:30:10Z |
## Description
<!-- Describe your changes in detail -->
We used to have locker_id as a namespacing identifier for merchants, however this is no more used for BasiliskLocker. This will remove asserting for locker_id in case of BasiliskLocker.
## Motivation and Context
<!--
Why is this change required? What pr... | b681f78d964d02f80249751cc6fd12e3c85bc4d7 | [
"crates/router/src/core/payment_methods/cards.rs"
] | ||
juspay/hyperswitch | juspay__hyperswitch-1296 | Bug: [FEATURE] Create a new workflow to validate the generated openAPI spec file (generated.json)
### Feature Description
There should be a check for validating the `generated.json` file whenever a change is pushed in the codebase.
### Possible Implementation
We can configure a new workflow via **GitHub Act... | diff --git a/Cargo.lock b/Cargo.lock
index 3690b937999..50173a250e5 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -11,7 +11,7 @@ dependencies = [
"actix-rt",
"actix_derive",
"bitflags 1.3.2",
- "bytes",
+ "bytes 1.4.0",
"crossbeam-channel",
"futures-core",
"futures-sink",
@@ -20,10 +20,10 @@ dependencies = [
... | 2023-05-31T10:26:11Z |
## Description
<!-- Describe your changes in detail -->
This PR adds a new workflow in the CI pipeline to validate the generated openAPI spec file(`openapi_spec.json`). It utilizes the [Swagger CLI](https://apitools.dev/swagger-cli/) to do so. Also, it changes the name of the openAPI spec file from `generated.json` ... | 1322aa757902662a1bd90cc3f09e887a7fdbf841 |
I tested it locally using [ACT](https://github.com/nektos/act).
| [
"Cargo.lock",
"crates/api_models/src/customers.rs",
"crates/api_models/src/payments.rs",
"crates/router/Cargo.toml",
"crates/router/src/bin/router.rs",
"crates/router/src/openapi.rs",
"openapi/generated.json",
"openapi/openapi_spec.json"
] | |
juspay/hyperswitch | juspay__hyperswitch-1209 | Bug: Change type name from `MandateTxnType` to `MandateTransactionType`
Would be preferable if we could avoid the `Txn` and use `Transaction` instead. I'm okay with taking this up on a separate PR.
_Originally posted by @SanchithHegde in https://github.com/juspay/hyperswitch/pull/1188#discussion_r11... | diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs
index bcdb75824c1..c5e0e6977ca 100644
--- a/crates/api_models/src/payments.rs
+++ b/crates/api_models/src/payments.rs
@@ -341,9 +341,9 @@ pub struct VerifyRequest {
#[derive(Debug, Clone, serde::Serialize, serde::Deserialize)]
#[serd... | 2023-05-31T07:24:23Z |
## Description
<!-- Describe your changes in detail -->
Change type name from MandateTxnType to MandateTransactionType, as we avoid abbreviations like `transaction -> txn` as much as possible in our code, and use verbose names instead.
## Motivation and Context
<!--
Why is this change required? What problem do... | e575fde6dc22675af18e80b005872dec2f6cc22c |
This does not affect any apis
<img width="869" alt="Screenshot 2023-06-05 at 11 32 52 AM" src="https://github.com/juspay/hyperswitch/assets/83439957/e4f080b1-6f36-4b5a-83b1-7ebf69ce96ff">
| [
"crates/api_models/src/payments.rs",
"crates/router/src/core/payments/helpers.rs",
"crates/router/src/core/payments/operations.rs",
"crates/router/src/core/payments/operations/payment_cancel.rs",
"crates/router/src/core/payments/operations/payment_capture.rs",
"crates/router/src/core/payments/operations/p... | |
juspay/hyperswitch | juspay__hyperswitch-1288 | Bug: [FEATURE] filter out payment_methods which doesn't support mandates during list api call
### Feature Description
When a mandate payment is created, sdk makes a payment_method_list api call which lists all the payment_methods. But not all of them support mandate payments.
Filter the payment_methods which do... | diff --git a/config/config.example.toml b/config/config.example.toml
index 4f54a4a6c28..06ff14b9818 100644
--- a/config/config.example.toml
+++ b/config/config.example.toml
@@ -290,6 +290,10 @@ refund_tolerance = 100 # Fake delay tolerance for dummy connector refu
refund_retrieve_duration = 500 # Fake dela... | 2023-05-30T10:23:30Z |
## Description
<!-- Describe your changes in detail -->
When a mandate payment is created, sdk makes a payment_method_list api call which lists all the payment_methods. But not all of them support mandate payments.
Added a filter for payment_methods which filters payment methods that doesn't support mandates and li... | 07120bf422048255f93d7073c4dcd2f853667ffd |
Postman
Configured payment methods -
Filtered pay... | [
"config/config.example.toml",
"config/development.toml",
"crates/router/src/configs/defaults.rs",
"crates/router/src/configs/settings.rs",
"crates/router/src/core/payment_methods/cards.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-1312 | Bug: [BUG] Adyen throws `500` when doing PSync call for non-redirection flow
### Bug Description
Adyen throws `500` when doing PSync call for non-redirection flow.
### Expected Behavior
Since Adyen doesn't PSync for normal non-redirection flow, it should tell user that PSync is not supported instead of throwing ... | diff --git a/crates/router/src/connector/adyen.rs b/crates/router/src/connector/adyen.rs
index 380a96c6b57..149beb97c65 100644
--- a/crates/router/src/connector/adyen.rs
+++ b/crates/router/src/connector/adyen.rs
@@ -310,12 +310,19 @@ impl
&self,
req: &types::RouterData<api::PSync, types::PaymentsSync... | 2023-05-29T17:43:22Z |
## Description
<!-- Describe your changes in detail -->
This PR address Internal Server Error that arised when calling PSync in non-redirection flow.
`contains_encoded_data` in the else part is needed if not, status about the payments for bank redirects never change.
## Motivation and Context
<!--
Why is this ... | 10691c5fce630d60aade862080d25c62a5cddb44 |
Couldn't test by running `adyen.rs` as API keys contain symbols such as `)` and `]` that result in internal `toml` error. Tested manually as of now.
Manually.
Normal Flow:
<img width="1307" alt="image" src="https://github.com/juspay/hyperswitch/assets/69745008/e4a9af29-6872-498d-9bc4-bc1d24cc0058">
<img width... | [
"crates/router/src/connector/adyen.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-1199 | Bug: [FEATURE] List payment_methods with the required fields in each method
### Feature Description
When /payments API call is made from merchant server, payment is created. Assume that customer hasn't sent the required field in this call. But when a `confirm` API call is made, since customer has missed to send t... | diff --git a/config/config.example.toml b/config/config.example.toml
index 2d43669ea1d..cbe1af472fd 100644
--- a/config/config.example.toml
+++ b/config/config.example.toml
@@ -286,3 +286,12 @@ refund_duration = 1000 # Fake delay duration for dummy connector refun
refund_tolerance = 100 # Fake dela... | 2023-05-29T17:22:30Z |
## Description
<!-- Describe your changes in detail -->
Currently when `/payments` API call is made with `confirm = false` from merchant server, payment is created. Assuming the customer hasn't sent the required field in this call, when a confirm API call is made, since customer has missed to send the required filed... | 9794079c797dcb30edcd88e93e8448948321287c |
Postman
| [
"config/config.example.toml",
"crates/api_models/src/enums.rs",
"crates/api_models/src/payment_methods.rs",
"crates/router/src/configs/defaults.rs",
"crates/router/src/configs/settings.rs",
"crates/router/src/core/payment_methods/cards.rs",
"crates/router/src/openapi.rs",
"openapi/openapi_spec.json"
] | |
juspay/hyperswitch | juspay__hyperswitch-1309 | Bug: feat(connector): [Shift4] Refund webhooks
Refund webhook support for connector shift4 | diff --git a/crates/router/src/connector/shift4.rs b/crates/router/src/connector/shift4.rs
index 8f8d6cee56b..d75a0896583 100644
--- a/crates/router/src/connector/shift4.rs
+++ b/crates/router/src/connector/shift4.rs
@@ -3,7 +3,7 @@ mod transformers;
use std::fmt::Debug;
use common_utils::ext_traits::ByteSliceExt;
... | 2023-05-29T14:52:30Z |
## Description
<!-- Describe your changes in detail -->
Refund webhook support for shift4 ([status mapping ref](https://dev.shift4.com/docs/api#event-types)) . We always update the status by psync as we don't have source verification for shift4 .
## Motivation and Context
<!--
Why is this change required? What... | 4a8de7741d43da07e655bc7382927c68e8ac1eb5 |
**payment webhook**
<img width="1181" alt="Screenshot 2023-05-29 at 6 51 42 PM" src="https://github.com/juspay/hyperswitch/assets/121822803/f077b49d-eb93-4612-a187-dfc7ea8e06e0">
**Refund webhook**
<img width="1184" alt="Screenshot 2023-05-29 at 6 51 05 PM" src="https://github.com/juspay/hyperswitch/assets/1218228... | [
"crates/router/src/connector/shift4.rs",
"crates/router/src/connector/shift4/transformers.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-1116 | Bug: [FEATURE] Implement `EventInterface` for `MockDb`
Spin out from https://github.com/juspay/hyperswitch/issues/172. Please refer to that issue for more information. | diff --git a/crates/router/src/db.rs b/crates/router/src/db.rs
index ee9cd03e692..a260f016dc8 100644
--- a/crates/router/src/db.rs
+++ b/crates/router/src/db.rs
@@ -85,6 +85,7 @@ pub struct MockDb {
redis: Arc<redis_interface::RedisConnectionPool>,
api_keys: Arc<Mutex<Vec<storage::ApiKey>>>,
cards_info: ... | 2023-05-28T17:49:36Z |
## Description
<!-- Describe your changes in detail -->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implement... | 597ec16907a83ce228228b8c00e329495ade117b | [
"crates/router/src/db.rs",
"crates/router/src/db/events.rs"
] | ||
juspay/hyperswitch | juspay__hyperswitch-851 | Bug: [FEATURE] Use the newtype pattern for phone numbers
### Feature Description
This issue covers one of the problems mentioned in #119, about using [the newtype pattern](https://rust-unofficial.github.io/patterns/patterns/behavioural/newtype.html) for phone numbers. The requirement is that phone numbers must be v... | diff --git a/Cargo.lock b/Cargo.lock
index ff777f8f625..05c45938fd4 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -264,7 +264,7 @@ dependencies = [
"serde_urlencoded",
"smallvec",
"socket2",
- "time 0.3.21",
+ "time 0.3.22",
"url",
]
@@ -388,7 +388,7 @@ dependencies = [
"serde",
"serde_json",
"strum",
- ... | 2023-05-28T10:08:23Z |
## Description
<!-- Describe your changes in detail -->
* Used the phonenumber crate to validate the phonenumber
* Implemented usual traits: FromStr, TryFrom, Deref, DerefMut, Queryable, FromSql, ToSql
* Used the testcase crate to write a few phone number validation unit tests
## Motivation and Context
<!--
... | 6c0d136cee106fc25fbcf63e4bbc01b28baa1519 | [
"Cargo.lock",
"crates/common_utils/Cargo.toml",
"crates/common_utils/src/errors.rs",
"crates/common_utils/src/pii.rs",
"crates/common_utils/src/validation.rs"
] | ||
juspay/hyperswitch | juspay__hyperswitch-1191 | Bug: Implement `EphemeralKeyInterface` for `MockDb`
Spin out from https://github.com/juspay/hyperswitch/issues/172. Please refer to that issue for more information. | diff --git a/crates/router/src/db.rs b/crates/router/src/db.rs
index 0bec1c7c081..c33d3f00225 100644
--- a/crates/router/src/db.rs
+++ b/crates/router/src/db.rs
@@ -108,6 +108,7 @@ pub struct MockDb {
connector_response: Arc<Mutex<Vec<storage::ConnectorResponse>>>,
redis: Arc<redis_interface::RedisConnectionP... | 2023-05-27T10:25:12Z |
## Description
Implemented Mock db for ephemeral key
## Motivation and Context
Fixes #1191
# | 638fc42217861924b5a43d33d691bad63338cac3 | [
"crates/router/src/db.rs",
"crates/router/src/db/ephemeral_key.rs",
"crates/router/src/types/storage.rs"
] | ||
juspay/hyperswitch | juspay__hyperswitch-1276 | Bug: [FEATURE] Implement `RefundInterface` for `MockDb`
Spin out from #172. Please refer to that issue for more information. | diff --git a/crates/router/src/db/refund.rs b/crates/router/src/db/refund.rs
index e3ff8b8dc6d..bb40bd76429 100644
--- a/crates/router/src/db/refund.rs
+++ b/crates/router/src/db/refund.rs
@@ -1,4 +1,4 @@
-use storage_models::errors::DatabaseError;
+use storage_models::{errors::DatabaseError, refund::RefundUpdateIntern... | 2023-05-25T20:32:19Z |
## Description
<!-- Describe your changes in detail -->
## Motivation and Context
The main motivation is to have MockDb stubs, help to void mocking, and invocation of external database api's.
For more information check https://github.com/juspay/hyperswitch/issues/172
Fixes #1276
# | 6f1a1a3bcb7466738b018a773a5fe4adc5cf2887 | [
"crates/router/src/db/refund.rs",
"crates/storage_models/src/refund.rs"
] | ||
juspay/hyperswitch | juspay__hyperswitch-1229 | Bug: [BUG] incorrect mapping of connector customer
### Bug Description
It bugs out when the merchant connector account credentials are changed, or when multiple connector accounts with the same name ( stripe, adyen ) are created in different countries or with different labels. When creating payment it will be us... | diff --git a/crates/router/src/core/payments.rs b/crates/router/src/core/payments.rs
index 196d6b4c484..978f89a9f8a 100644
--- a/crates/router/src/core/payments.rs
+++ b/crates/router/src/core/payments.rs
@@ -122,7 +122,6 @@ where
let updated_customer = call_create_connector_customer_if_required(
state,... | 2023-05-25T12:05:37Z |
## Description
<!-- Describe your changes in detail -->
This PR adds support for multiple country and business label support in the connector customer. Previously the mapping to connector customer was of the form `connector_name -> connector_customer_id`, This has been changed to `connector_label -> connector_custom... | fa392c40a86b2589a55c3adf1de5b862a544dbe9 |
Create a payment through stripe, and check whether connector customer is generated.
Create a mandate transaction in confirm, without passing the customer id.
<img width="679" alt... | [
"crates/router/src/core/payments.rs",
"crates/router/src/core/payments/customers.rs",
"crates/router/src/core/payments/flows.rs",
"crates/router/src/core/payments/flows/authorize_flow.rs",
"crates/router/src/core/payments/flows/verfiy_flow.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-1189 | Bug: Implement `CardsInfoInterface` for `MockDb`
Spin out from #172. Please refer to that issue for more information. | diff --git a/crates/router/src/db.rs b/crates/router/src/db.rs
index 6863ddf1eb6..ee9cd03e692 100644
--- a/crates/router/src/db.rs
+++ b/crates/router/src/db.rs
@@ -84,6 +84,7 @@ pub struct MockDb {
connector_response: Arc<Mutex<Vec<storage::ConnectorResponse>>>,
redis: Arc<redis_interface::RedisConnectionPoo... | 2023-05-24T22:27:18Z |
## Description
<!-- Describe your changes in detail -->
Very simply implement `CardsInfoInterface` for `MockDB`, allowing looking up of card info, the only trait method
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue... | 16cd32513bc6528e064058907a8c3c848fdba132 |
Code change is simple enough that I didn't find tests necessary, although I am happy to add a unit test if desired.
| [
"crates/router/src/db.rs",
"crates/router/src/db/cards_info.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-1123 | Bug: [FEATURE] Implement `MerchantConnectorAccountInterface` for `MockDb`
Spin off from #172. Refer to the parent issue for more information | diff --git a/crates/router/src/db/merchant_connector_account.rs b/crates/router/src/db/merchant_connector_account.rs
index 997cc130c7d..05507593808 100644
--- a/crates/router/src/db/merchant_connector_account.rs
+++ b/crates/router/src/db/merchant_connector_account.rs
@@ -1,5 +1,6 @@
use common_utils::ext_traits::{Asy... | 2023-05-23T22:38:06Z |
## Description
## Motivation and Context
The main motivation is to have MockDb stubs, help to void mocking, and invocation of external database api's.
For more information check https://github.com/juspay/hyperswitch/issues/172
Fixes [1123](https://github.com/juspay/hyperswitch/issues/1123)
# | 7ef011ad737257fc83f7a43d16f1bf4ac54336ae | [
"crates/router/src/db/merchant_connector_account.rs",
"crates/storage_models/src/merchant_connector_account.rs"
] | ||
juspay/hyperswitch | juspay__hyperswitch-1102 | Bug: [BUG] Validate payment method type in payments request against given payment method data for non-card flows
### Bug Description
The payments flow currently does not validate the payment method type given in the payments request against the given payment method data for non-card flows.
### Expected Behavior
T... | diff --git a/crates/router/src/core/payments/helpers.rs b/crates/router/src/core/payments/helpers.rs
index 25450aaf22c..74e1791b051 100644
--- a/crates/router/src/core/payments/helpers.rs
+++ b/crates/router/src/core/payments/helpers.rs
@@ -37,6 +37,7 @@ use crate::{
types::{self, AsyncLift},
},
... | 2023-05-23T08:58:21Z |
## Description
Added the following checks for non-card flows :
1. Check if `payment_method_type` is specified.
2. Check if the specified `payment_method_type` corresponds to the parent `payment_method`.
3. Check if the specified `payment_method_data` corresponds to the parent `payment_method`.
<!--
Provid... | 7f947169feac9d15616cc2b1a2aacdfa80f219bf | [
"crates/router/src/core/payments/helpers.rs"
] | ||
juspay/hyperswitch | juspay__hyperswitch-1095 | Bug: [FEATURE] Setting up process tracker to schedule email
### Feature description -
Since expiry of the api_key would start right from its creation, while creating an api_key, insert a db entry into process_tracker table with new process_tracker workflow `ApiKeyExpiryWorkflow` and write logic for sending email b... | diff --git a/crates/common_utils/src/ext_traits.rs b/crates/common_utils/src/ext_traits.rs
index 82553f41bc5..fec0446b161 100644
--- a/crates/common_utils/src/ext_traits.rs
+++ b/crates/common_utils/src/ext_traits.rs
@@ -8,7 +8,10 @@ use masking::{ExposeInterface, Secret, Strategy};
use quick_xml::de;
use serde::{Des... | 2023-05-22T18:00:04Z |
## Description
<!-- Describe your changes in detail -->
When an api_key is about to expire, we are currently not notifying the merchant regarding the same. This PR includes an implementation for process_tracker, which schedules an email to be sent to the merchant, reminding them about the expiry.
When a merchant ... | 6ec6272f2acae6d5cb5e3120b2dbcc87ae2875ec |
Manually.
For testing purpose, I scheduled an email 3, 2 and 1 minutes prior to api_key expiry.
Api-key creation with expiry set -
Email-1 scheduled 3 minutes prior to expiry -
![1](https://github.com/j... | [
"crates/common_utils/src/ext_traits.rs",
"crates/router/src/configs/defaults.rs",
"crates/router/src/configs/settings.rs",
"crates/router/src/core/api_keys.rs",
"crates/router/src/core/errors.rs",
"crates/router/src/routes/api_keys.rs",
"crates/router/src/scheduler/workflows.rs",
"crates/router/src/sc... | |
juspay/hyperswitch | juspay__hyperswitch-924 | Bug: [FEATURE] move env vars in selenium test to toml config file
### Feature Description
Currently all the dynamic variable in crates/router/tests/connectors/selenium.rs are taken as **ENV** vars which can be moved to sample_auth.toml file which will list all the variables.
### Possible Implementation
move all t... | diff --git a/crates/api_models/src/webhooks.rs b/crates/api_models/src/webhooks.rs
index 15df7da9ee9..a17fc86c311 100644
--- a/crates/api_models/src/webhooks.rs
+++ b/crates/api_models/src/webhooks.rs
@@ -15,7 +15,6 @@ pub enum IncomingWebhookEvent {
EventNotSupported,
SourceChargeable,
SourceTransaction... | 2023-05-22T05:10:38Z |
## Description
<!-- Describe your changes in detail -->
Closes #924
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on t... | 2ede8ade8cff56443d8712518c64de7d952f4a0c |
<img width="1147" alt="Screen Shot 2023-05-26 at 9 06 21 PM" src="https://github.com/juspay/hyperswitch/assets/20727598/2421e56c-0cc2-4eac-a886-33f3071e048c">
<img width="966" alt="Screen Shot 2023-05-22 at 10 18 54 AM" src="https://github.com/juspay/hyperswitch/assets/20727598/3ea3ac09-8e30-4e40-bedb-4a32a4f92e5f... | [
"crates/api_models/src/webhooks.rs",
"crates/router/src/connector/nuvei/transformers.rs",
"crates/router/src/connector/stripe.rs",
"crates/router/src/connector/stripe/transformers.rs",
"crates/router/tests/connectors/adyen_ui.rs",
"crates/router/tests/connectors/connector_auth.rs",
"crates/router/tests/... | |
juspay/hyperswitch | juspay__hyperswitch-1224 | Bug: feat(connector) : [Authorizedotnet] Add Wallet support
Wallet support(google pay, apple pay and paypal) for Authorizedotnet | diff --git a/Cargo.lock b/Cargo.lock
index bd81825ee30..f93aa8d1dc8 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -1639,7 +1639,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "907076dfda823b0b36d2a1bb5f90c96660a5bbcd7729e10727f07858f22c4edc"
dependencies = [
"cfg-if",
- "hashbrown",
... | 2023-05-21T18:20:28Z |
## Description
<!-- Describe your changes in detail -->
Wallet Support[Paypal, Googlepay and Applepay] for Authorizedotnet
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd rec... | 07aef53a5cd4cd70f75415e883d0e07d85244a1e |
**Note** : It takes one day for this connector to update status from Processing to Success.
Google pay
<img width="1298" alt="Screenshot 2023-05-21 at 11 10 00 PM" src="https://github.com/juspay/hyperswitch/assets/121822803/05ac83a3-4c06-4d8d-802d-6f40a06603fa">
Paypal Redirection
<img width="1290" alt="Scree... | [
"Cargo.lock",
"crates/router/src/connector/authorizedotnet.rs",
"crates/router/src/connector/authorizedotnet/transformers.rs",
"crates/router/src/connector/utils.rs",
"crates/router/src/core/payments.rs",
"crates/router/src/core/payments/flows.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-1218 | Bug: fix(connector) : [Globalpay] unit tests for globalpay
refactor and add unit tests for globalpay | diff --git a/crates/router/src/connector/globalpay.rs b/crates/router/src/connector/globalpay.rs
index 5bd472a2d04..ac0797cc89a 100644
--- a/crates/router/src/connector/globalpay.rs
+++ b/crates/router/src/connector/globalpay.rs
@@ -15,6 +15,7 @@ use self::{
GlobalpayRefreshTokenResponse,
},
};
+use supe... | 2023-05-19T19:54:24Z |
## Description
<!-- Describe your changes in detail -->
This PR contains following changes
1)unit tests for globalpay
2)expiry year fix
## Motivation and Context
unit tests for globalpay
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
... | 4a8de7741d43da07e655bc7382927c68e8ac1eb5 |
unit tests
Note : `should_fail_void_payment_for_auto_capture` is failing from connector end .
<img width="1044" alt="Screenshot 2023-05-29 at 11 56 41 AM" src="https://github.com/juspay/hyperswitch/assets/121822803/db7a86a9-522f-4e73-b1ea-f7f775ab6b05">
| [
"crates/router/src/connector/globalpay.rs",
"crates/router/src/connector/globalpay/transformers.rs",
"crates/router/tests/connectors/connector_auth.rs",
"crates/router/tests/connectors/globalpay.rs",
"crates/router/tests/connectors/sample_auth.toml"
] | |
juspay/hyperswitch | juspay__hyperswitch-1211 | Bug: feat: add cache for MCA and API key tables.
Add support for in memory and redis cache for Merchant Connector Account and API keys tables to the functions that are frequently called for less latency during payments. | diff --git a/crates/router/src/db/api_keys.rs b/crates/router/src/db/api_keys.rs
index 3d1c2d6bb34..70e2cb99f92 100644
--- a/crates/router/src/db/api_keys.rs
+++ b/crates/router/src/db/api_keys.rs
@@ -1,6 +1,8 @@
use error_stack::IntoReport;
use super::{MockDb, Store};
+#[cfg(feature = "accounts_cache")]
+use crate... | 2023-05-19T09:43:47Z |
## Description
<!-- Describe your changes in detail -->
This PR adds in memory and redis cache for Merchant Connector Account and API keys. To the fetch functions that are frequently called during a payment
This PR closes #1211.
## Motivation and Context
<!--
Why is this change required? What problem does it... | b967d232519b106d88d79da2d6baec550c9256df | [
"crates/router/src/db/api_keys.rs",
"crates/router/src/db/merchant_connector_account.rs",
"crates/storage_models/src/api_keys.rs"
] | ||
juspay/hyperswitch | juspay__hyperswitch-1185 | Bug: feat(Connector): [Noon] Add Cards payments, Refunds, Capture and Void
### Feature Description
AddSupport for payments with Non-3DS cards via Noon.
Includes:
- [Authorize](https://docs.noonpayments.com/payment-api/reference/initiate)
- [Capture](https://docs.noonpayments.com/payment-api/reference/capture)... | diff --git a/crates/api_models/src/enums.rs b/crates/api_models/src/enums.rs
index 0b1726daaa7..f91732cfa73 100644
--- a/crates/api_models/src/enums.rs
+++ b/crates/api_models/src/enums.rs
@@ -616,7 +616,7 @@ pub enum Connector {
Multisafepay,
Nexinets,
Nmi,
- // Noon, added as template code for futur... | 2023-05-18T13:44:42Z |
## Description
<!-- Describe your changes in detail -->
Added Card Payments (3DS and Non-3DS) along with all the listed flows:
- [Authorize](https://docs.noonpayments.com/payment-api/reference/initiate)
- [Capture](https://docs.noonpayments.com/payment-api/reference/capture)
- [Void](https://docs.noonpayments... | c1b631bd1e0025452f2cf37345996ea789810839 |
Unit Tests are not updated as all the tests trigger 3DS
| [
"crates/api_models/src/enums.rs",
"crates/router/src/connector/noon.rs",
"crates/router/src/connector/noon/transformers.rs",
"crates/router/src/core/payments/flows.rs",
"crates/router/src/types/api.rs",
"crates/router/tests/connectors/connector_auth.rs",
"crates/router/tests/connectors/noon.rs",
"crat... | |
juspay/hyperswitch | juspay__hyperswitch-1113 | Bug: [FEATURE] mandate type to be sent by the `merchant`
### Feature Description
In the current scenario, the `mandate type` object has to be sent in the `confirm` call. But this decision has to be taken by the `Merchant` during the `payments_create` call. So we should allow the merchant to pass mandate type and th... | diff --git a/Cargo.lock b/Cargo.lock
index fb22127838b..da0033c8336 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -3000,7 +3000,7 @@ dependencies = [
[[package]]
name = "opentelemetry"
version = "0.18.0"
-source = "git+https://github.com/open-telemetry/opentelemetry-rust/?rev=44b90202fd744598db8b0ace5b8f0bad7ec45658#4... | 2023-05-17T13:40:22Z |
## Description
**Current Implementation**
In order to create a mandate, the merchant has to provide both `mandate_type` and `customer_acceptance` together and is only allowed during the confirm call.
**Requirements**
As per the SDK requirements and the data availability. Both of these data fields won't be av... | 2d49ce56de5ed314aa099f3ce4aa569b3e22b561 | 
This is the initial payment with `confirm: false`
This ... | [
"Cargo.lock",
"crates/api_models/src/payment_methods.rs",
"crates/api_models/src/payments.rs",
"crates/router/src/compatibility/stripe/payment_intents/types.rs",
"crates/router/src/connector/nuvei/transformers.rs",
"crates/router/src/connector/stripe/transformers.rs",
"crates/router/src/core/mandate.rs"... | |
juspay/hyperswitch | juspay__hyperswitch-1118 | Bug: [BUG] docs: `amount` and `currency` are optional in OpenAPI docs
### Bug Description
The error
```json
{
"error": {
"type": "invalid_request",
"message": "Missing required param: currency",
"code": "IR_04"
}
}
```
Is thrown when creating a payment with no fields in t... | diff --git a/Cargo.lock b/Cargo.lock
index b504c3db426..6cb3e124104 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -2970,7 +2970,7 @@ dependencies = [
[[package]]
name = "opentelemetry"
version = "0.18.0"
-source = "git+https://github.com/open-telemetry/opentelemetry-rust/?rev=44b90202fd744598db8b0ace5b8f0bad7ec45658#4... | 2023-05-17T10:15:11Z |
## Description
<!-- Describe your changes in detail -->
This PR will allow us to specify which fields are mandatory in `PaymentsRequest` for a particular flow. A new macro is added called `PolymorphicSchema` ( Name is open for discussion ), which will generate different schemas as specified by
`#[generate_schemas(... | 07e0fcbe06107e8be532b4e9a1e1a1ef6efba68e |
Manually. Generate the openapi file and check if fields are marked as mandatory.
| [
"Cargo.lock",
"crates/api_models/src/admin.rs",
"crates/api_models/src/payments.rs",
"crates/api_models/src/refunds.rs",
"crates/router/src/configs/settings.rs",
"crates/router/src/core/payments.rs",
"crates/router/src/openapi.rs",
"crates/router/src/routes/admin.rs",
"crates/router/src/routes/dispu... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.