repo
stringclasses
1 value
instance_id
stringlengths
22
24
problem_statement
stringlengths
30
24.1k
patch
stringlengths
0
1.9M
test_patch
stringclasses
1 value
created_at
stringdate
2022-11-25 05:12:07
2025-06-13 10:24:29
hints_text
stringlengths
0
228k
base_commit
stringlengths
40
40
test_instructions
stringlengths
0
232k
filenames
listlengths
0
300
juspay/hyperswitch
juspay__hyperswitch-6642
Bug: refactor(tenant): use tenant id type Refactor: Use tenant_id type instead of string for better type safety
diff --git a/crates/common_utils/src/id_type.rs b/crates/common_utils/src/id_type.rs index 3d57a72376e..a8085564145 100644 --- a/crates/common_utils/src/id_type.rs +++ b/crates/common_utils/src/id_type.rs @@ -12,6 +12,7 @@ mod payment; mod profile; mod refunds; mod routing; +mod tenant; #[cfg(feature = "v2")] mo...
2024-11-22T12:01:12Z
## Description Use tenant_id type for better type safety ## Motivation and Context Closes [#6642](https://github.com/juspay/hyperswitch/issues/6642) #
8d0639ea6f22227253a44e6bd8272d9e55d17f92
It refactoring PR, its compiling and checks are passing Tested flows like signup/signin with tenancy featue flag enabled and disabled in local
[ "crates/common_utils/src/id_type.rs", "crates/common_utils/src/id_type/organization.rs", "crates/common_utils/src/id_type/tenant.rs", "crates/common_utils/src/types/theme.rs", "crates/diesel_models/src/user/theme.rs", "crates/diesel_models/src/user_role.rs", "crates/drainer/src/handler.rs", "crates/dr...
juspay/hyperswitch
juspay__hyperswitch-6638
Bug: feat(users): Send welcome to community email in magic link signup Send [this](https://www.figma.com/design/lhmTvW2vuc2p5B4ZvsEOTw/Email-Tempalte-Design?node-id=0-1&t=OKWmXqVOsidKUk7y-1) email when user signs up with magic link.
diff --git a/crates/router/src/consts/user.rs b/crates/router/src/consts/user.rs index aa427992082..32ca4ad31d7 100644 --- a/crates/router/src/consts/user.rs +++ b/crates/router/src/consts/user.rs @@ -41,3 +41,5 @@ pub const EMAIL_SUBJECT_INVITATION: &str = "You have been invited to join Hypers pub const EMAIL_SUBJECT...
2024-11-22T08:42:00Z
## Description <!-- Describe your changes in detail --> Magic link will send one more email along with magic link email if user is signing up. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have ...
83e8bc0775c20e9d055e65bd13a2e8b1148092e1
Local SES ![image](https://github.com/user-attachments/assets/f4e15419-31c7-452e-ba77-4a8815944ca0) ``` curl --location 'http://localhost:8080/user/connect_account' \ --header 'Content-Type: application/json' \ --data-raw '{ "email": "new user email" }' ``` The above email should be sent.
[ "crates/router/src/consts/user.rs", "crates/router/src/core/user.rs", "crates/router/src/services/email/assets/welcome_to_community.html", "crates/router/src/services/email/types.rs" ]
juspay/hyperswitch
juspay__hyperswitch-6633
Bug: [FEATURE] [AIRWALLEX] Update production endpoint ### Feature Description Update production endpoint for connector Airwallex (https://api.airwallex.com/) ### Possible Implementation Update production endpoint for connector Airwallex (https://api.airwallex.com/) ### Have you spent some time checking if this f...
diff --git a/config/deployments/production.toml b/config/deployments/production.toml index 76f42085f92..ebd9e49d86b 100644 --- a/config/deployments/production.toml +++ b/config/deployments/production.toml @@ -28,7 +28,7 @@ adyen.base_url = "https://{{merchant_endpoint_prefix}}-checkout-live.adyenpaymen adyen.payout_ba...
2024-11-21T12:24:28Z
## Description <!-- Describe your changes in detail --> Update production endpoint for connector Airwallex (https://api.airwallex.com/) ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issu...
f24578310f44adf75c993ba42225554377399961
Only config changes hence no testing required
[ "config/deployments/production.toml" ]
juspay/hyperswitch
juspay__hyperswitch-6629
Bug: fix: merchant order ref id filter and refund_id filter - Add merchant_order reference id filter for payments list - Fix refunds list filter, search by refund id. (It is construction a totally new filter ignoring the merchant id when searching)
diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs index 98bc7b754a4..a5fc687ef28 100644 --- a/crates/api_models/src/payments.rs +++ b/crates/api_models/src/payments.rs @@ -4923,6 +4923,8 @@ pub struct PaymentListFilterConstraints { pub order: Order, /// The List of all the car...
2024-11-21T10:51:13Z
## Description The PR - Add merchant order reference id filter for payments list - Fix bug for search by refund id (or payment_id), using `or` instead of `or_filter`. Earlier we were searching in whole list, ignoring the filter previously applied in the query. However this was the only case for when we were search...
f24578310f44adf75c993ba42225554377399961
Merchant Order filter is working as expected Request ``` curl --location 'http://localhost:8080/payments/list' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'Authorization: Bearer JWT' \ --data '{ "merchant_order_reference_id": "test" }' ``` Response: ``` ...
[ "crates/api_models/src/payments.rs", "crates/hyperswitch_domain_models/src/payments/payment_intent.rs", "crates/router/src/types/storage/dispute.rs", "crates/router/src/types/storage/refund.rs", "crates/storage_impl/src/payments/payment_intent.rs" ]
juspay/hyperswitch
juspay__hyperswitch-6626
Bug: fix(analytics): remove `first_attempt` group by in Payment Intent old metrics `first_attempt` as a group by is getting added internally in the queries as it is required by the new PaymentIntent based metrics for Analytics V2 Dashboard. The logic was added for the existing older metrics as well for PaymentInten...
diff --git a/crates/analytics/src/payment_intents/metrics/payment_processed_amount.rs b/crates/analytics/src/payment_intents/metrics/payment_processed_amount.rs index cf733b0c3da..696dd6a584b 100644 --- a/crates/analytics/src/payment_intents/metrics/payment_processed_amount.rs +++ b/crates/analytics/src/payment_intents...
2024-11-21T08:35:38Z
## Description <!-- Describe your changes in detail --> `first_attempt` as a group by is getting added internally in the queries as it is required by the new PaymentIntent based metrics for Analytics V2 Dashboard. The logic was added for the existing older metrics as well for PaymentIntents on the older dashboard...
f24578310f44adf75c993ba42225554377399961
Hit the curls to test the various metrics. Sessionized_metrics should be tested only on clickhouse. Older metricss can be tested on both sqlx and clickhouse. ```bash curl --location 'http://localhost:8080/analytics/v2/org/metrics/payments' \ --header 'Accept: */*' \ --header 'Accept-Language: en-US,en;q=0.9' \ ...
[ "crates/analytics/src/payment_intents/metrics/payment_processed_amount.rs", "crates/analytics/src/payment_intents/metrics/payments_success_rate.rs", "crates/analytics/src/payment_intents/metrics/sessionized_metrics/payment_processed_amount.rs", "crates/analytics/src/payment_intents/metrics/sessionized_metrics...
juspay/hyperswitch
juspay__hyperswitch-6623
Bug: Address `CVE-2024-21538` in Cypress https://vulert.com/vuln-db/CVE-2024-21538
diff --git a/cypress-tests-v2/package-lock.json b/cypress-tests-v2/package-lock.json index 36f801468a9..cac88cab055 100644 --- a/cypress-tests-v2/package-lock.json +++ b/cypress-tests-v2/package-lock.json @@ -10,7 +10,7 @@ "license": "ISC", "devDependencies": { "@types/fs-extra": "^11.0.4", - ...
2024-11-21T07:17:18Z
## Description <!-- Describe your changes in detail --> This PR update Cypress packages to address [CVE-2024-21538](https://vulert.com/vuln-db/CVE-2024-21538). Closes https://github.com/juspay/hyperswitch/issues/6623 ## Motivation and Context <!-- Why is this change required? What problem does it solve? If...
f24578310f44adf75c993ba42225554377399961
No tests needed as it is just a dependency update. CI passing should be enough.
[ "cypress-tests-v2/package-lock.json", "cypress-tests-v2/package.json" ]
juspay/hyperswitch
juspay__hyperswitch-6620
Bug: feat(themes): Support naming themes Currently themes don't have names, and it's better to have a way to attach a name to a theme. So that we can know about theme without having to look at the theme data.
diff --git a/crates/common_utils/src/types/theme.rs b/crates/common_utils/src/types/theme.rs index a2e6fe4b19c..03b4cf23a6c 100644 --- a/crates/common_utils/src/types/theme.rs +++ b/crates/common_utils/src/types/theme.rs @@ -4,11 +4,12 @@ use crate::id_type; /// Currently being used for theme related APIs and queries....
2024-11-20T12:13:51Z
## Description <!-- Describe your changes in detail --> This PR adds `theme_name` and `entity_type` in the themes table. This will help us in 1. Having a name for the theme. 2. EntityType identifier to help us identity the lineage type instead of guessing it. ## Motivation and Context <!-- Why is this chan...
43d87913ab3d177a6d193b3e475c96609cc09a28
This is an internal change and doesn't affect any APIs.
[ "crates/common_utils/src/types/theme.rs", "crates/diesel_models/src/query/user/theme.rs", "crates/diesel_models/src/schema.rs", "crates/diesel_models/src/schema_v2.rs", "crates/diesel_models/src/user/theme.rs", "crates/router/src/db/user/theme.rs", "migrations/2024-11-20-110014_add-entity-type-and-theme...
juspay/hyperswitch
juspay__hyperswitch-5156
Bug: [FEATURE] Add support for SMTP email server ### Feature Description Add support for sending emails with a custom SMTP server. (Currently only AWS SES is supported) ### Possible Implementation Could be implemented using `lettre` crate. Steps to implement: - Create the email building and sending logic - Imp...
diff --git a/Cargo.lock b/Cargo.lock index 27b4158ba61..a2ede8c08c1 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1888,9 +1888,9 @@ checksum = "37b2a672a2cb129a2e41c10b1224bb368f9f37a2b16b612598138befd7b37eb5" [[package]] name = "cc" -version = "1.1.18" +version = "1.2.1" source = "registry+https://github.com/rust-...
2024-11-19T19:55:34Z
## Description <!-- Describe your changes in detail --> Add SMTP support to allow mails through self-hosted/custom SMTP server #5156 ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an iss...
43d87913ab3d177a6d193b3e475c96609cc09a28
Setup mailhog to test emails locally ```docker run -p 1025:1025 -p 8025:8025 mailhog/mailhog``` 1. Check if is possible to disable email with the env config ``` [email] active_email_client = "NO_EMAIL_CLIENT" ``` Start the server with `cargo r` and there should be no error 2. Check the SMTP server without...
[ "Cargo.lock", "config/development.toml", "config/docker_compose.toml", "crates/external_services/Cargo.toml", "crates/external_services/src/email.rs", "crates/external_services/src/email/no_email.rs", "crates/external_services/src/email/ses.rs", "crates/external_services/src/email/smtp.rs", "crates/...
juspay/hyperswitch
juspay__hyperswitch-6615
Bug: feat(analytics): Add refund sessionized metrics for Analytics V2 dashboard Create the new refund sessionized metrics for Analytics V2 dashboard.
diff --git a/crates/analytics/src/clickhouse.rs b/crates/analytics/src/clickhouse.rs index f56e875f720..cd870c12b23 100644 --- a/crates/analytics/src/clickhouse.rs +++ b/crates/analytics/src/clickhouse.rs @@ -16,7 +16,9 @@ use super::{ distribution::PaymentDistributionRow, filters::PaymentFilterRow, metrics::P...
2024-11-19T17:04:47Z
## Description <!-- Describe your changes in detail --> Adding metrics, and support for Refund Page in Analytics V2 Dashboard through sessionizer. The metrics added are as follows: - **Static Metrics in overview section:** - Refund Success Rate - Total Refunds Processed (Amount) - Successful Refunds ...
64383915bda5693df1cecf6cc5683e8b9aaef99b
Refunds Success Rate: ```bash curl --location 'http://localhost:8080/analytics/v1/org/metrics/refunds' \ --header 'Accept: */*' \ --header 'Accept-Language: en-US,en;q=0.9' \ --header 'Connection: keep-alive' \ --header 'Content-Type: application/json' \ --header 'Origin: http://localhost:9000' \ --header 'Re...
[ "crates/analytics/src/clickhouse.rs", "crates/analytics/src/lib.rs", "crates/analytics/src/payments/distribution.rs", "crates/analytics/src/payments/distribution/payment_error_message.rs", "crates/analytics/src/query.rs", "crates/analytics/src/refunds.rs", "crates/analytics/src/refunds/accumulator.rs", ...
juspay/hyperswitch
juspay__hyperswitch-6609
Bug: [FEATURE] align the JSON deserialization errors into expected ErrorResponse format ### Feature Description HyperSwitch uses an error format for responding back with the errors in the API. This error structure is uniform across different stages of the flow. For any deserialization errors in the API, error res...
diff --git a/crates/router/src/utils.rs b/crates/router/src/utils.rs index 515c9a94ce8..ca61543ec57 100644 --- a/crates/router/src/utils.rs +++ b/crates/router/src/utils.rs @@ -81,7 +81,11 @@ pub mod error_parser { fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { f.write_str( ...
2024-11-19T11:05:09Z
## Description Described in #6609 ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend starting with one first so the PR can focus on the implementation (unless it is an o...
8e9c3ec8931851dae638037b91eb1611399be0bf
Locally.
[ "crates/router/src/utils.rs", "cypress-tests-v2/cypress/e2e/configs/Payment/Commons.js", "cypress-tests-v2/cypress/e2e/configs/Payment/Utils.js" ]
juspay/hyperswitch
juspay__hyperswitch-6605
Bug: feat(analytics): add first_attempt as a filter for PaymentFilters Need to add `first_attempt` as a filter in PaymentFilters. This is required for the new Analytics v2 `Smart Retries Metrics`, specifically S`mart Retries Successful Distribution `and `Smart Retries Failure Distribution`, for calculations only in...
diff --git a/crates/analytics/src/payments/filters.rs b/crates/analytics/src/payments/filters.rs index 51805acaae2..668bdaa6c8b 100644 --- a/crates/analytics/src/payments/filters.rs +++ b/crates/analytics/src/payments/filters.rs @@ -64,4 +64,5 @@ pub struct PaymentFilterRow { pub card_last_4: Option<String>, ...
2024-11-19T08:32:54Z
## Description <!-- Describe your changes in detail --> Added `first_attempt` as a filter in `PaymentFilters`. This is required for the new Analytics v2 `Smart Retries` Metrics, specifically `Smart Retries Successful Distribution` and `Smart Retries Failure Distribution`, for calculations only involving smart ret...
65bf75a75e1e7d705de3ee3e9080a7a86099ffc3
Hit the curl: ```bash curl --location 'http://localhost:8080/analytics/v1/org/metrics/payments' \ --header 'Accept: */*' \ --header 'Accept-Language: en-US,en;q=0.9' \ --header 'Connection: keep-alive' \ --header 'Content-Type: application/json' \ --header 'Origin: http://localhost:9000' \ --header 'Referer: ...
[ "crates/analytics/src/payments/filters.rs", "crates/analytics/src/payments/types.rs", "crates/analytics/src/query.rs", "crates/analytics/src/sqlx.rs", "crates/api_models/src/analytics/payments.rs" ]
juspay/hyperswitch
juspay__hyperswitch-5895
Bug: [CYPRESS] : Add Noon Connector **Description:** This task involves adding a connector for the Noon functionality in Cypress. For reference, similar connectors have already been implemented in the repository. You can refer to the existing connectors here: https://github.com/juspay/hyperswitch/tree/main/cyp...
2024-11-19T06:46:36Z
## Description Add Noon Connector for Cypress Automation Note : Noon supports only 3ds payments , so all the no_three_ds payments are skipped ## Motivation and Context Noon connector was not available in the cypress automation #
65bf75a75e1e7d705de3ee3e9080a7a86099ffc3
<img width="710" alt="image" src="https://github.com/user-attachments/assets/88aec323-824c-49e3-b51e-67d469c9826a">
[]
juspay/hyperswitch
juspay__hyperswitch-6600
Bug: fix(users): Only use lowercase letters in emails Currently uppercase letters in emails are being using at it is. Ideally we should convert them to lowercase before performing any DB operations with it.
diff --git a/crates/router/src/types/domain/user.rs b/crates/router/src/types/domain/user.rs index 5a881728b07..4cb69e68ed8 100644 --- a/crates/router/src/types/domain/user.rs +++ b/crates/router/src/types/domain/user.rs @@ -103,7 +103,7 @@ impl UserEmail { pub fn new(email: Secret<String, pii::EmailStrategy>) -> ...
2024-11-18T13:19:55Z
## Description <!-- Describe your changes in detail --> This PR changes will convert emails from request to lowercase before performing any DB operations. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you...
43d87913ab3d177a6d193b3e475c96609cc09a28
``` curl --location 'http://localhost:8080/user/connect_account' \ --header 'Content-Type: application/json' \ --data-raw '{ "email": "USER@Example.com" }' ``` This email in the about request will be inserted as `user@example.com` in DB.
[ "crates/router/src/types/domain/user.rs" ]
juspay/hyperswitch
juspay__hyperswitch-6598
Bug: feat(authn): Use cookies for authentication Currently we use auth headers and local storage in FE for transfer JWT from FE to BE. Cookies is a better way to do this, as it is handled by browser and JavaScript doesn't have access to. First we will test this in Integ and slowly move it to sandbox and production...
diff --git a/config/config.example.toml b/config/config.example.toml index 191f2ba7f8b..52b704e1adc 100644 --- a/config/config.example.toml +++ b/config/config.example.toml @@ -403,6 +403,7 @@ two_factor_auth_expiry_in_secs = 300 # Number of seconds after which 2FA should totp_issuer_name = "Hyperswitch" # Name of...
2024-11-18T11:34:51Z
## Description <!-- Describe your changes in detail --> This PR will add logging for cookies and also make signout API accessible by any SPT. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have a...
ea81432e3eb72d9a2e139e26741a42cdd8d31202
- This following behaviour applies only to integ and not for sandbox and prod. ``` curl --location 'http://localhost:8080/user' \ --header 'Authorization: Bearer eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1c2VyX2lkIjoiNzJkNDU0YTAtM2I3YS00MzZiLTllNjMtMmU5ZDQ5YzI3NmZjIiwibWVyY2hhbnRfaWQiOiJtZXJjaGFudF8xNzMxOTI4MDg1Iiwi...
[ "config/config.example.toml", "config/deployments/integration_test.toml", "config/deployments/production.toml", "config/deployments/sandbox.toml", "config/development.toml", "config/docker_compose.toml", "crates/router/src/configs/settings.rs", "crates/router/src/core/user.rs", "crates/router/src/ro...
juspay/hyperswitch
juspay__hyperswitch-6592
Bug: refactor(users): Force 2FA in prod env Currently 2FA is not forced on prod, users have ability to skip it. For the PCI compliance, we have to force users to setup and use 2FA.
diff --git a/config/deployments/production.toml b/config/deployments/production.toml index 73e5794f042..76f42085f92 100644 --- a/config/deployments/production.toml +++ b/config/deployments/production.toml @@ -149,7 +149,7 @@ password_validity_in_days = 90 two_factor_auth_expiry_in_secs = 300 totp_issuer_name = "Hyper...
2024-11-18T11:01:56Z
## Description <!-- Describe your changes in detail --> This PR forces users to use 2FA in production. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend starting with o...
d32397f060731f51a15634e221117a554b8b3721
This change will only affect production. 1. 2FA Status API - `is_skippable` field is added in the response. ``` curl --location 'http://localhost:8080/user/2fa/v2' \ --header 'Authorization: JWT' \ ``` ``` { "status": null, "is_skippable": true } ``` 2. T...
[ "config/deployments/production.toml" ]
juspay/hyperswitch
juspay__hyperswitch-6594
Bug: fix(analytics): fix `authentication_type` and `card_last_4` fields serialization for payment_intent_filters There is a serialization issue for `card_last_4` and `authentication_type` fields when filters are getting applied for `PaymentIntentFilters`. - `card_last_4` was being processed as `card_last4` . - `auth...
diff --git a/crates/api_models/src/analytics/payment_intents.rs b/crates/api_models/src/analytics/payment_intents.rs index dd51c97d935..365abd71edc 100644 --- a/crates/api_models/src/analytics/payment_intents.rs +++ b/crates/api_models/src/analytics/payment_intents.rs @@ -63,11 +63,15 @@ pub enum PaymentIntentDimension...
2024-11-18T10:46:29Z
## Description <!-- Describe your changes in detail --> There is a serialization issue for `card_last_4` and `authentication_type` fields when filters are getting applied for `PaymentIntentFilters`. `card_last_4` was being processed as `card_last4` . `auth_type` is being used to add the filters and not serialized ...
d32397f060731f51a15634e221117a554b8b3721
`authentication_type`: Hit the curl for any metric of payment_intents (sessionized metrics): ```bash curl --location 'http://localhost:8080/analytics/v2/org/metrics/payments' \ --header 'Accept: */*' \ --header 'Accept-Language: en-US,en;q=0.9' \ --header 'Connection: keep-alive' \ --header 'Content-Type: appl...
[ "crates/api_models/src/analytics/payment_intents.rs" ]
juspay/hyperswitch
juspay__hyperswitch-6597
Bug: [FEATURE] Xendit Template PR ### Feature Description Template code added for new connector Xendit https://developers.xendit.co/api-reference ### Possible Implementation Template code added for new connector Xendit https://developers.xendit.co/api-reference ### Have you spent some time checking if this fea...
diff --git a/api-reference-v2/openapi_spec.json b/api-reference-v2/openapi_spec.json index d2fa50d8629..96c6a037ad3 100644 --- a/api-reference-v2/openapi_spec.json +++ b/api-reference-v2/openapi_spec.json @@ -18092,6 +18092,7 @@ "wise", "worldline", "worldpay", + "xendit", ...
2024-11-18T10:24:16Z
## Description Template code added for new connector Xendit https://developers.xendit.co/api-reference ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend starting with o...
d32397f060731f51a15634e221117a554b8b3721
Since this is template PR, no testing is required.
[ "api-reference-v2/openapi_spec.json", "config/config.example.toml", "config/deployments/integration_test.toml", "config/deployments/production.toml", "config/deployments/sandbox.toml", "config/development.toml", "config/docker_compose.toml", "crates/api_models/src/connector_enums.rs", "crates/common...
juspay/hyperswitch
juspay__hyperswitch-6524
Bug: [FEATURE] add permissions for operations in recon module ### Feature Description Reconciliation module in HyperSwitch provides various operations. Every operation needs to permitted for the end user to use it. As of today, recon has a single permission - which gives access to the entire recon module, this...
diff --git a/crates/api_models/src/enums.rs b/crates/api_models/src/enums.rs index c00afac6462..4af3f855d77 100644 --- a/crates/api_models/src/enums.rs +++ b/crates/api_models/src/enums.rs @@ -446,3 +446,20 @@ pub enum StripeChargeType { pub fn convert_frm_connector(connector_name: &str) -> Option<FrmConnectors> { ...
2024-11-18T06:24:02Z
## Description Described in #6524 This PR includes below changes - Extending resources enum (for specifying the resource being consumed from the dashboard) - Extending granular permission groups for recon - Populating `acl` field in the recon token ## Motivation and Context Helps maintain and configure pe...
79a75ce65418f21da7250e1538d0990047ba52d9
- Verify the generated recon token has `acl` - `GET /verify_token` response to have `acl` <details> <summary>Check /verify_token response</summary> cURL curl --location --request GET 'http://localhost:8080/recon/verify_token' \ --header 'Authorization: Bearer eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1...
[ "crates/api_models/src/enums.rs", "crates/api_models/src/events/recon.rs", "crates/api_models/src/events/user.rs", "crates/api_models/src/recon.rs", "crates/api_models/src/user.rs", "crates/common_enums/src/enums.rs", "crates/router/src/core/recon.rs", "crates/router/src/core/user.rs", "crates/route...
juspay/hyperswitch
juspay__hyperswitch-6645
Bug: [FEAT] Multiple credential support for a connector in Cypress ## Requirement Execute cypress tests for a connector having **multiple credentials** which can be used for different scenarios (one api key for `cards`, another for `bank redirects` and etc.,). ## Implementation ### Introduce new format for ...
2024-11-17T07:12:09Z
## Description <!-- Describe your changes in detail --> This PR introduces 2 new features: - Multiple credentials for a connector - Configuration flags closes #6645 (check this issue for detailed documentation / flow / explanation) ## Motivation and Context <!-- Why is this change required? What probl...
797a0db7733c5b387564fb1bbc106d054c8dffa6
Only Cybersource with `multiple creds` (takes only from first `connector_1`): <img width="594" alt="image" src="https://github.com/user-attachments/assets/7c05742c-6331-417a-8699-731285463560"> Cybersource with `multiple creds` (along with `incremental auth`): <img width="554" alt="image" src="https://gith...
[]
juspay/hyperswitch
juspay__hyperswitch-6577
Bug: [BUG] FATAL: role "root" does not exist ### Bug Description Whenever hyperswitch-pg-1 sever running in docker-compose, it though an error " role "root" does not exist" ### Expected Behavior Error should not come. ### Actual Behavior ![Screenshot from 2024-11-14 19-27-00](https://github.com/user-attachment...
diff --git a/docker-compose-development.yml b/docker-compose-development.yml index 07a2131c6d4..d7a0e365c36 100644 --- a/docker-compose-development.yml +++ b/docker-compose-development.yml @@ -26,7 +26,7 @@ services: - POSTGRES_PASSWORD=db_pass - POSTGRES_DB=hyperswitch_db healthcheck: - test: [...
2024-11-15T08:47:23Z
## Description <!-- Describe your changes in detail --> ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend starting with one first so the PR can focus on the implement...
0805a937b1bc12ac1dfb23922036733ed971a87a
[ "docker-compose-development.yml", "docker-compose.yml" ]
juspay/hyperswitch
juspay__hyperswitch-6580
Bug: chore(infra): SDK Table schema sanity Editing SDK Tables schema in the codebase for end to end ( ingestion to querying on dashboard ) sanity
diff --git a/crates/analytics/docs/clickhouse/scripts/sdk_events.sql b/crates/analytics/docs/clickhouse/scripts/sdk_events.sql index bfe6401cacc..c5c70cc9e66 100644 --- a/crates/analytics/docs/clickhouse/scripts/sdk_events.sql +++ b/crates/analytics/docs/clickhouse/scripts/sdk_events.sql @@ -6,7 +6,7 @@ CREATE TABLE sd...
2024-11-14T16:36:06Z
## Description <!-- Describe your changes in detail --> Updating SDK table schema ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend starting with one first so the PR c...
15f873bd1296169149987041f4008b0afe2ac2aa
Schema structure changes for sdk table. Nothing to test.
[ "crates/analytics/docs/clickhouse/scripts/sdk_events.sql" ]
juspay/hyperswitch
juspay__hyperswitch-6574
Bug: feat(analytics): add `smart_retries` only metrics ## Proposed changes There should be fields in PaymentDistribution, for the case where we only want to extract metric for Subsequent smart retried attempts. For example, we have `success_rate` and `success_rate_without_retries` Now missing field is `success_ra...
diff --git a/crates/analytics/src/payments/accumulator.rs b/crates/analytics/src/payments/accumulator.rs index 651eeb0bcfe..c4e48300d07 100644 --- a/crates/analytics/src/payments/accumulator.rs +++ b/crates/analytics/src/payments/accumulator.rs @@ -76,8 +76,11 @@ pub struct PaymentsDistributionAccumulator { pub fa...
2024-11-14T13:37:40Z
## Description <!-- Describe your changes in detail --> Added support for calculating new metrics based on smart retries for Analytics v2 dashboard. The 2 metrics are: - Payment Processed Amount and Count for smart retries - Payments Success Rate and Failure Rate distribution for Smart Retries `Payment Process...
8cc5d3db9afb120b00115c6714be2e362951cc94
### Request - Hit the curl: ```bash curl --location 'http://localhost:8080/analytics/v1/org/metrics/payments' \ --header 'Accept: */*' \ --header 'Accept-Language: en-GB,en-US;q=0.9,en;q=0.8' \ --header 'Connection: keep-alive' \ --header 'Content-Type: application/json' \ --header 'Origin: http://localhost:9...
[ "crates/analytics/src/payments/accumulator.rs", "crates/api_models/src/analytics/payments.rs" ]
juspay/hyperswitch
juspay__hyperswitch-6572
Bug: feat(analytics): add `sessionized_metrics` for disputes (backwards compatibility) ## Current Behaviour - There is no `sessionized_metrics` module for disputes like there is for `payments` and `payment_intents` ## Proposed Changes - create `sessionized_metrics` module for disputes
diff --git a/crates/analytics/src/clickhouse.rs b/crates/analytics/src/clickhouse.rs index 546b57f99af..f56e875f720 100644 --- a/crates/analytics/src/clickhouse.rs +++ b/crates/analytics/src/clickhouse.rs @@ -139,6 +139,9 @@ impl AnalyticsDataSource for ClickhouseClient { | AnalyticsCollection::Dispute => ...
2024-11-14T12:49:06Z
## Description <!-- Describe your changes in detail --> - Add sessionized metrics module and implement backwards compatibility. - Add the `sessionizer_dispute` table support for Sessionized metrics. ### Fixes #6572 ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it ...
8cc5d3db9afb120b00115c6714be2e362951cc94
```bash curl --location 'http://localhost:8080/analytics/v1/org/metrics/disputes' \ --header 'Accept: */*' \ --header 'Accept-Language: en-GB,en-US;q=0.9,en;q=0.8' \ --header 'Connection: keep-alive' \ --header 'Content-Type: application/json' \ --header 'Origin: http://localhost:9000' \ --header 'QueryType: S...
[ "crates/analytics/src/clickhouse.rs", "crates/analytics/src/disputes/accumulators.rs", "crates/analytics/src/disputes/core.rs", "crates/analytics/src/disputes/metrics.rs", "crates/analytics/src/disputes/metrics/sessionized_metrics/dispute_status_metric.rs", "crates/analytics/src/disputes/metrics/sessioniz...
juspay/hyperswitch
juspay__hyperswitch-6561
Bug: Create toggle and update endpoints for ER
diff --git a/api-reference-v2/openapi_spec.json b/api-reference-v2/openapi_spec.json index 1494908c5fc..68631872aa7 100644 --- a/api-reference-v2/openapi_spec.json +++ b/api-reference-v2/openapi_spec.json @@ -1278,7 +1278,7 @@ ], "summary": "Routing - Create", "description": "Create a routing...
2024-11-14T08:21:23Z
## Description <!-- Describe your changes in detail --> This PR will add route to enable Elimination based dynamic routing for specific profiles. ``` curl --location --request POST 'http://localhost:8080/account/MERCHANT_ID/business_profile/PROFILE_ID/dynamic_routing/elimination/toggle?enable=none' \ --header 'ap...
d4b482c21cf57b022c7bbadc1a3a9c9d9e5d4f03
Testing Scenarios: 1. enable elimination routing and check Profile table for the following value: ``` dynamic_routing_algorithm | {"success_based_algorithm":{"algorithm_id_with_timestamp":{"algorithm_id":"routing_2hS6Dn3XRjICecmNZg5s","timestamp":1732569416},"enabled_feature":"metrics...
[ "api-reference-v2/openapi_spec.json", "crates/api_models/src/events/routing.rs", "crates/api_models/src/routing.rs", "crates/openapi/src/openapi.rs", "crates/openapi/src/routes/routing.rs", "crates/router/src/core/payments/routing.rs", "crates/router/src/core/routing.rs", "crates/router/src/core/routi...
juspay/hyperswitch
juspay__hyperswitch-6287
Bug: Add cypress test case for `network_transaction_id_and_card_details` recurring details MIT Test cases should be added to `network_transaction_id_and_card_details` based recurring MIT flow
2024-11-14T06:06:56Z
## Description <!-- Describe your changes in detail --> [Reference pr](https://github.com/juspay/hyperswitch/pull/6245) Add test cases MIT flow using the recurring_details of type `network_transaction_id_and_card_details`. ## Motivation and Context <!-- Why is this change required? What problem does it solv...
f24578310f44adf75c993ba42225554377399961
Cypress tests <img width="442" alt="image" src="https://github.com/user-attachments/assets/c871d675-1d44-49f9-9dd9-94cc3b58b9c0">
[]
juspay/hyperswitch
juspay__hyperswitch-5893
Bug: [CYPRESS] : Add Checkout Connector **Description:** This task involves adding a payment connector for the checkout functionality in Cypress. For reference, similar connectors have already been implemented in the repository. You can refer to the existing connectors here: https://github.com/juspay/hyperswitch...
2024-11-13T13:36:29Z
## Description Add Checkout Connector for Cypress Automation ## Motivation and Context Checkout connector was not available in the cypress automation #
600cf44684912192f0bf1b9566fd0a7daae9f54c
Cypress Tests - Checkout <img width="710" alt="image" src="https://github.com/user-attachments/assets/75bc70aa-8bc5-43f6-ad28-ac33c7bcf6de"> - NMI <img width="710" alt="image" src="https://github.com/user-attachments/assets/cb4b4b21-8a93-4a88-8e67-5172d0847ca4">
[]
juspay/hyperswitch
juspay__hyperswitch-6548
Bug: refactor(core): add profile_id for default_fallback api ## Description This will refactor the route routing/default/profile into /default/profile/{profile_id}, Previously the output for this route was the default fallback connectors from all the profiles, After this refactor it will have the fallback connec...
diff --git a/crates/router/src/core/routing.rs b/crates/router/src/core/routing.rs index 0bd38918ee7..94eb9bd741e 100644 --- a/crates/router/src/core/routing.rs +++ b/crates/router/src/core/routing.rs @@ -909,26 +909,30 @@ pub async fn retrieve_default_fallback_algorithm_for_profile( } #[cfg(feature = "v1")] - pub...
2024-11-12T13:46:03Z
## Description <!-- Describe your changes in detail --> This will refactor the route `routing/default/profile` Previously the output for this route was the default fallback connectors from all the profiles, After this refactor it will have the fallback connectors only for the mentioned profile. If the `profile_id...
6808272de305c685b7cf948060f006d39cbac60b
``` curl --location 'http://127.0.0.1:8080/routing/default/profile' \ --header 'Authorization: Bearer token ``` This should have the connectors from the mentioned profile only. ``` [ { "connector": "bankofamerica", "merchant_connector_id": "mca_ADICIF9zh09TjnpUgusU" } ] ```
[ "crates/router/src/core/routing.rs", "crates/router/src/routes/app.rs", "crates/router/src/routes/routing.rs" ]
juspay/hyperswitch
juspay__hyperswitch-6542
Bug: ci: run cybersource along with stripe ci: run cybersource along with stripe
2024-11-12T09:40:28Z
## Description <!-- Describe your changes in detail --> Run Cybersource in parallel along with Stripe. closes #6542 ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recomme...
20a3a1c2d6bb93fb4dae7f7eb669ebd85e631c96
Let the CI check pass: https://github.com/juspay/hyperswitch/actions/runs/11794582778/job/32975411512?pr=6541
[]
juspay/hyperswitch
juspay__hyperswitch-6534
Bug: refactor(users): Make `profile_id` in the JWT non-optional - We kept the `profile_id` in the JWT optional for backwards compatibility. - Now we have `profile_id` in all the JWT and this field no longer needs to be optional in JWT.
diff --git a/crates/diesel_models/src/query/user_role.rs b/crates/diesel_models/src/query/user_role.rs index 2496d22447e..ed018cc2381 100644 --- a/crates/diesel_models/src/query/user_role.rs +++ b/crates/diesel_models/src/query/user_role.rs @@ -87,7 +87,7 @@ impl UserRole { user_id: String, org_id: id...
2024-11-11T14:12:28Z
## Description <!-- Describe your changes in detail --> - Currently `profile_id` in the JWT is optional, this PR makes it non-optional. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issu...
98b141c6a00e6435385e1c513b1684d58567ecee
This is a internal change and it should not affect any APIs.
[ "crates/diesel_models/src/query/user_role.rs", "crates/router/src/core/user.rs", "crates/router/src/core/user_role.rs", "crates/router/src/db/kafka_store.rs", "crates/router/src/db/user_role.rs", "crates/router/src/services/authentication.rs", "crates/router/src/types/domain/user/decision_manager.rs", ...
juspay/hyperswitch
juspay__hyperswitch-6536
Bug: refactor(routing): remove payment_id from dynamic_routing metrics
diff --git a/crates/router/src/core/routing/helpers.rs b/crates/router/src/core/routing/helpers.rs index 0250d00d1bb..aef89ea8ed9 100644 --- a/crates/router/src/core/routing/helpers.rs +++ b/crates/router/src/core/routing/helpers.rs @@ -733,7 +733,7 @@ pub async fn push_metrics_with_update_window_for_success_based_rout...
2024-11-11T13:52:51Z
## Description <!-- Describe your changes in detail --> This will remove payment_id from being pushed to dynamic_routing metrics ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd...
0a506b1729a27e47543cf24f64fbad08479d8dec
This can be tested on SBX in the dynamic_routing Dashboard present on grafana dashboard, There shouldn't be payment_id and the merchant_id should be merged with profile_id
[ "crates/router/src/core/routing/helpers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-6532
Bug: feat(themes): Setup DB for themes There should a separate table for themes for storing the `theme_id`s for a particular lineage. This should be the schema: | org_id | merchant_id | profile_id | theme_id | | ------ | ----------- | ---------- | -------- | | o1 | m1 | p1 | t1 | | o...
diff --git a/crates/common_utils/src/types.rs b/crates/common_utils/src/types.rs index ef7a4b847c4..f7cdfd3617b 100644 --- a/crates/common_utils/src/types.rs +++ b/crates/common_utils/src/types.rs @@ -3,6 +3,8 @@ pub mod keymanager; /// Enum for Authentication Level pub mod authentication; +/// Enum for Theme Linea...
2024-11-11T12:08:51Z
## Description <!-- Describe your changes in detail --> This PR creates a new table named `themes` in the DB. This will be used to store the `theme_id` for any lineage of `tenant_id`, `org_id`, `merchant_id` and `profile_id`. ## Motivation and Context <!-- Why is this change required? What problem does it solv...
20a3a1c2d6bb93fb4dae7f7eb669ebd85e631c96
This is an internal change and there is no API to test this currently. I've tested the read query by creating a temporary API which uses the query created in this PR.
[ "crates/common_utils/src/types.rs", "crates/common_utils/src/types/theme.rs", "crates/diesel_models/src/query/user.rs", "crates/diesel_models/src/query/user/theme.rs", "crates/diesel_models/src/schema.rs", "crates/diesel_models/src/schema_v2.rs", "crates/diesel_models/src/user.rs", "crates/diesel_mode...
juspay/hyperswitch
juspay__hyperswitch-6528
Bug: fix: trustpay eps redirection in cypress fix: trustpay eps redirection in cypress they changed it again
2024-11-11T10:19:51Z
## Description <!-- Describe your changes in detail --> Fix EPS Bank Redirect redirection in Cypress. Closes #6528 ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommen...
0a506b1729a27e47543cf24f64fbad08479d8dec
<img width="453" alt="image" src="https://github.com/user-attachments/assets/a712b6c3-74fa-4a41-8eae-3045bc41e3ac">
[]
juspay/hyperswitch
juspay__hyperswitch-6526
Bug: [FIX] fix response for migration api Currently there is inconsistent response due to no validations for request body fields for the migration api. Implementation - validations such as empty string check for network transaction id and empty object for connector mandate details should be enforced while eval...
diff --git a/crates/router/src/core/payment_methods/cards.rs b/crates/router/src/core/payment_methods/cards.rs index ad612ed6f3b..f07634060df 100644 --- a/crates/router/src/core/payment_methods/cards.rs +++ b/crates/router/src/core/payment_methods/cards.rs @@ -28,7 +28,7 @@ use common_utils::{ consts, crypto:...
2024-11-11T10:06:16Z
## Description <!-- Describe your changes in detail --> #6300 has inconsistent response due to no validations for each field in migration api request body. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If yo...
086115f47379b06185a1753979fc6dd9dc945afd
test case - test migration api with empty fields. req - ``` curl --location 'http://localhost:8080/payment_methods/migrate' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: api-key' \ --data '{ "merchant_id": "merchant_id", "card": { "ca...
[ "crates/router/src/core/payment_methods/cards.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4677
Bug: Add audit events for PaymentStatus update Created from #4525 This covers adding events for PaymentStatus operation This event should include the payment data similar to [PaymentCancel](https://github.com/juspay/hyperswitch/pull/4166) It should also include any metadata for the event e.g reason for ...
diff --git a/crates/router/src/core/payments/operations/payment_status.rs b/crates/router/src/core/payments/operations/payment_status.rs index 69f2d85d6a9..9aa905345c8 100644 --- a/crates/router/src/core/payments/operations/payment_status.rs +++ b/crates/router/src/core/payments/operations/payment_status.rs @@ -16,6 +1...
2024-11-08T12:48:57Z
## Description This PR adds an Audit event for the PaymentStatus operation. ## Motivation and Context This PR fixes #4677 ## How did you test it - Hit the `Payments - Create` endpoint ```bash curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header...
ed276ecc0017f7f98b6f8fa3841e6b8971f609f1
[ "crates/router/src/core/payments/operations/payment_status.rs", "crates/router/src/events/audit_events.rs" ]
juspay/hyperswitch
juspay__hyperswitch-6513
Bug: docs(analytics): Instructions to set up `currency_conversion` (third party dependency API) ## Requirements After the changes by [this](#6418) PR, we need to update the documentation for `analytics` crate setup process. ## Reason Due to the third party dependency on `currency_conversion` crate, we need to ensur...
diff --git a/crates/analytics/docs/README.md b/crates/analytics/docs/README.md index 96218fc231c..eb5c26a6ba3 100644 --- a/crates/analytics/docs/README.md +++ b/crates/analytics/docs/README.md @@ -91,6 +91,44 @@ source = "kafka" After making this change, save the file and restart your application for the changes to ...
2024-11-08T08:27:21Z
## Description <!-- Describe your changes in detail --> Now that `analytics` depends on `currency_conversion` crate after this [PR](#6418), we need to include instructions in `analytics` documentation to set up this service. ## Fixes #6513 ## Motivation and Context <!-- Why is this change required? What proble...
a5ac69d1a77e772e430df8c4187942de44f23079
[ "crates/analytics/docs/README.md" ]
juspay/hyperswitch
juspay__hyperswitch-6518
Bug: get apple pay certificates only from metadata during the session call Currently we have apple pay certificates being stored in the `metadata` as well as `connector_wallet_details` when a merchant connector account is created. During the session call we try to get the certificates from the `connector_wallet_deta...
diff --git a/crates/router/src/core/payments/flows/session_flow.rs b/crates/router/src/core/payments/flows/session_flow.rs index ba8054696a1..545d05e776f 100644 --- a/crates/router/src/core/payments/flows/session_flow.rs +++ b/crates/router/src/core/payments/flows/session_flow.rs @@ -189,20 +189,11 @@ async fn create_a...
2024-11-08T07:44:48Z
## Description <!-- Describe your changes in detail --> Currently we have apple pay certificates being stored in the `metadata` as well as `connector_wallet_details` when a merchant connector account is created. During the session call we try to get the certificates from the `connector_wallet_details` if it fails we...
a5ac69d1a77e772e430df8c4187942de44f23079
-> Create merchant connector account with apple pay enabled (pass the certificates only in the metadata) -> Create a payment with confirm false ``` curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: dev_1mlXU5sn...
[ "crates/router/src/core/payments/flows/session_flow.rs", "crates/router/src/core/payments/helpers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-6509
Bug: [Enhancement] V2: Standardise endpoint naming scheme Use kebab case for all API endpoints consistently for V2. i.e. `/v2/like-this` instead of `/v2/not_like_this`
diff --git a/api-reference-v2/api-reference/api-key/api-key--create.mdx b/api-reference-v2/api-reference/api-key/api-key--create.mdx index a92a8ea77fd..abc1dcda10f 100644 --- a/api-reference-v2/api-reference/api-key/api-key--create.mdx +++ b/api-reference-v2/api-reference/api-key/api-key--create.mdx @@ -1,3 +1,3 @@ --...
2024-11-07T13:12:55Z
## Description <!-- Describe your changes in detail --> Use kebab-case for all API endpoints in V2 ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend starting with one f...
d4b482c21cf57b022c7bbadc1a3a9c9d9e5d4f03
This is mostly a documentation PR, doesn't require any additional test cases. Verified that existing cypress tests are passing
[ "api-reference-v2/api-reference/api-key/api-key--create.mdx", "api-reference-v2/api-reference/api-key/api-key--list.mdx", "api-reference-v2/api-reference/api-key/api-key--retrieve.mdx", "api-reference-v2/api-reference/api-key/api-key--revoke.mdx", "api-reference-v2/api-reference/api-key/api-key--update.mdx"...
juspay/hyperswitch
juspay__hyperswitch-6506
Bug: [BUG] API Reference documentation broken ### Bug Description API reference is broken for following endpoints: - `API Key - Create` - `API Key - Revoke` - `Routing - Retrieve` - `Routing - Activate Config` ### Expected Behavior <img width="1514" alt="image" src="https://github.com/user-attachments/a...
2024-11-07T11:04:51Z
## Description <!-- Describe your changes in detail --> Fixed broken API reference for the following endpoints: - `API Key - Create` - `API Key - Revoke` - `Routing - Retrieve` - `Routing - Activate Config` ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fix...
cf126b940812b8adce26d7a0f957ed92309130d6
[]
juspay/hyperswitch
juspay__hyperswitch-6505
Bug: add card expiry check in the `network_transaction_id_and_card_details` based `MIT` flow [Reference pr](https://github.com/juspay/hyperswitch/pull/6245). Add card expiry validation for the `recurring_details` = `network_transaction_id_and_card_details` based MIT flow
diff --git a/crates/router/src/core/payments.rs b/crates/router/src/core/payments.rs index 5d75001b118..a09510a4c4e 100644 --- a/crates/router/src/core/payments.rs +++ b/crates/router/src/core/payments.rs @@ -4464,6 +4464,11 @@ where let (mandate_reference_id, card_details_for_network_transaction_id)= hyperswitc...
2024-11-07T10:52:50Z
## Description <!-- Describe your changes in detail --> [Reference pr](https://github.com/juspay/hyperswitch/pull/6245). Add card expiry validation for the `recurring_details` = `network_transaction_id_and_card_details` based MIT flow ## Motivation and Context <!-- Why is this change required? What problem ...
cf126b940812b8adce26d7a0f957ed92309130d6
-> Create the cybersource connector -> Create payment with recurring details "type": "network_transaction_id_and_card_details" with expired card ``` curl --location 'http://localhost:8080/payments' \ --header 'Accept: application/json' \ --header 'api-key: ' \ --header 'Content-Type: application/json' \ --data...
[ "crates/router/src/core/payments.rs" ]
juspay/hyperswitch
juspay__hyperswitch-6501
Bug: feat: implement scylla cql traits for StrongSecret
diff --git a/Cargo.lock b/Cargo.lock index d232fcbf024..2d1f3cf4b06 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -3698,6 +3698,12 @@ version = "0.4.3" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "7f24254aa9a54b5c858eaee2f5bccdb46aaf0e486a595ed5fd8f86ba55232a70" +[[package]] +name = "h...
2024-11-07T06:34:24Z
## Description <!-- Describe your changes in detail --> This adds `SerializeValue` and `FromCQL` traits for masking StrongSecret ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd ...
90d9ffc1d2e13b83931762b05632056520eea07f
** THIS CANNOT BE TESTED ON ENVIRONEMTS ** Compiler guided
[ "Cargo.lock", "crates/masking/Cargo.toml", "crates/masking/src/cassandra.rs", "crates/masking/src/lib.rs" ]
juspay/hyperswitch
juspay__hyperswitch-6495
Bug: [DOCS] FIx API documentation for V2 - Merchant Account Update: Path Parameters in definition says it is {account_id} instead that should be {id} - Merchant Profile List Changes: Instead `Profile - list` make `Merchant Account - Profile List` , Path Parameters in definition says it is {account_id} instead ...
diff --git a/api-reference-v2/api-reference/api-key/api-key--retrieve.mdx b/api-reference-v2/api-reference/api-key/api-key--retrieve.mdx index 13b87953f1b..ee7970122d4 100644 --- a/api-reference-v2/api-reference/api-key/api-key--retrieve.mdx +++ b/api-reference-v2/api-reference/api-key/api-key--retrieve.mdx @@ -1,3 +1,...
2024-11-06T13:16:33Z
## Description <!-- Describe your changes in detail --> Improved OpenAPI documentation for V2 ## Issues Addressed <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend starting with one first so the...
01c5216fdd6f1d841082868cccea6054b64e9e07
[ "api-reference-v2/api-reference/api-key/api-key--retrieve.mdx", "api-reference-v2/api-reference/api-key/api-key--revoke.mdx", "api-reference-v2/api-reference/api-key/api-key--update.mdx", "api-reference-v2/api-reference/merchant-connector-account/merchant-connector--create.mdx", "api-reference-v2/api-refere...
juspay/hyperswitch
juspay__hyperswitch-6491
Bug: feat(analytics): revert remove additional filters from PaymentIntentFilters When global filters are applied on the dashboard, these filters are being sent to both Payment Attempt and Payment Intent related metrics. Initially backend support was not present for capturing these filters and adding to the queries, ...
diff --git a/crates/analytics/src/payment_intents/core.rs b/crates/analytics/src/payment_intents/core.rs index 3e8915c60a2..42b4895b6a2 100644 --- a/crates/analytics/src/payment_intents/core.rs +++ b/crates/analytics/src/payment_intents/core.rs @@ -372,6 +372,15 @@ pub async fn get_filters( PaymentIntentDi...
2024-11-06T11:07:03Z
## Description <!-- Describe your changes in detail --> Reverts [https://github.com/juspay/hyperswitch/pull/6403](https://github.com/juspay/hyperswitch/pull/6403) When global filters are applied on the dashboard, these filters are being sent to both Payment Attempt and Payment Intent related metrics. Initially...
01c5216fdd6f1d841082868cccea6054b64e9e07
Hit the curl: ```bash curl --location 'http://localhost:8080/analytics/v2/org/metrics/payments' \ --header 'Accept: */*' \ --header 'Accept-Language: en-US,en;q=0.9' \ --header 'Connection: keep-alive' \ --header 'Content-Type: application/json' \ --header 'Origin: http://localhost:9000' \ --header 'QueryType...
[ "crates/analytics/src/payment_intents/core.rs", "crates/analytics/src/payment_intents/filters.rs", "crates/analytics/src/payment_intents/metrics.rs", "crates/analytics/src/payment_intents/metrics/payment_intent_count.rs", "crates/analytics/src/payment_intents/metrics/payment_processed_amount.rs", "crates/...
juspay/hyperswitch
juspay__hyperswitch-6489
Bug: [FEATURE] Add payments update-intent API for v2 Add payments `update-intent` API for v2
diff --git a/api-reference-v2/api-reference/payments/payments--update-intent.mdx b/api-reference-v2/api-reference/payments/payments--update-intent.mdx new file mode 100644 index 00000000000..3ef58f4db72 --- /dev/null +++ b/api-reference-v2/api-reference/payments/payments--update-intent.mdx @@ -0,0 +1,3 @@ +--- +openapi...
2024-11-06T09:26:24Z
## Description <!-- Describe your changes in detail --> Added `update-intent` API for payments ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend starting with one fir...
15f873bd1296169149987041f4008b0afe2ac2aa
1. Intent Create Response: ```json { "id": "12345_pay_01930aca908b76b086927c61ad1fb724", "status": "requires_payment_method", "amount_details": { "order_amount": 100, "currency": "USD", "shipping_cost": null, "order_tax_amount": null, "skip_external_ta...
[ "api-reference-v2/api-reference/payments/payments--update-intent.mdx", "api-reference-v2/mint.json", "api-reference-v2/openapi_spec.json", "crates/api_models/src/payments.rs", "crates/common_enums/src/enums.rs", "crates/diesel_models/src/kv.rs", "crates/diesel_models/src/payment_intent.rs", "crates/hy...
juspay/hyperswitch
juspay__hyperswitch-6482
Bug: feat(users): Force users to reset password on first login for non-email flow Currently in non-email flow, users who are invited are not forced to change their password. This is being forced in email flow, this should also be present in non-email flow as well.
diff --git a/crates/router/src/types/domain/user.rs b/crates/router/src/types/domain/user.rs index 8331dff95c1..c48fe3320f3 100644 --- a/crates/router/src/types/domain/user.rs +++ b/crates/router/src/types/domain/user.rs @@ -1,4 +1,8 @@ -use std::{collections::HashSet, ops, str::FromStr}; +use std::{ + collections::...
2024-11-05T13:01:02Z
## Description <!-- Describe your changes in detail --> Currently in non-email flow, users who are invited are not forced to change their password. This PR will add that. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue...
01c5216fdd6f1d841082868cccea6054b64e9e07
1. Invite a new user in non-email flow ``` curl --location 'http://localhost:8080/user/user/invite_multiple?token_only=true' \ --header 'Content-Type: application/json' \ --header 'Authorization: Bearer eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1c2VyX2lkIjoiN2I2NTA1NGQtNjgzNC00NzU2LTgyNDYtN2RkOWM1Zm...
[ "crates/router/src/types/domain/user.rs" ]
juspay/hyperswitch
juspay__hyperswitch-6508
Bug: [FEATURE] Add support for payout connector integrations for connectors crate ### Feature Description To be able to support connector integrations in router and the new hyperswitch_connectors crate. ### Possible Implementation Move payout API traits to a common place - in hyperswitch_interfaces crate. ### Ha...
diff --git a/crates/hyperswitch_connectors/src/default_implementations.rs b/crates/hyperswitch_connectors/src/default_implementations.rs index 418d58eb54b..81c079d5d52 100644 --- a/crates/hyperswitch_connectors/src/default_implementations.rs +++ b/crates/hyperswitch_connectors/src/default_implementations.rs @@ -1049,6 ...
2024-11-05T11:21:51Z
## Description Described in #6508 ## Motivation and Context This helps us implement new payout connector integrations in `hyperswitch_connectors` crate #
20a3a1c2d6bb93fb4dae7f7eb669ebd85e631c96
Not needed as it's only a refactor. New connectors being added in `hyperswitch_connectors` crate can be tested
[ "crates/hyperswitch_connectors/src/default_implementations.rs", "crates/hyperswitch_interfaces/src/api.rs", "crates/hyperswitch_interfaces/src/api/payouts.rs", "crates/hyperswitch_interfaces/src/api/payouts_v2.rs", "crates/router/src/core/payments/flows.rs", "crates/router/src/types/api.rs", "crates/rou...
juspay/hyperswitch
juspay__hyperswitch-6475
Bug: feat(opensearch): refactor global search querybuilder and add case insensitivity opensearch filters - Currently the global search query builder logic is entirely present in a single function. - With more and more features getting added on, it is better to separate out the logic to build the query into separate ...
diff --git a/crates/analytics/src/opensearch.rs b/crates/analytics/src/opensearch.rs index a6e6c486ebe..84a2b9db3d4 100644 --- a/crates/analytics/src/opensearch.rs +++ b/crates/analytics/src/opensearch.rs @@ -1,3 +1,5 @@ +use std::collections::HashSet; + use api_models::{ analytics::search::SearchIndex, erro...
2024-11-04T11:59:47Z
## Description <!-- Describe your changes in detail --> - Currently the global search query builder logic is entirely present in a single function. - With more and more features getting added on, it is better to separate out the logic to build the query into separate modules. - Also, with the enhancement of global...
72ee434003eef744d516343a2f803264f226d92a
Can send the following filters in any case: - payment_method - payment_method_type - card_network - currency - connector - status Must send the following filters in the exact case: - customer_email - payment_id - card_last_4 - search_tags #### Hit the curl: ```bash curl --location 'http://localh...
[ "crates/analytics/src/opensearch.rs", "crates/analytics/src/search.rs" ]
juspay/hyperswitch
juspay__hyperswitch-6121
Bug: [REFACTOR]: [WISE] Add amount conversion framework to Wise ### :memo: Feature Description Currently, amounts are represented as `i64` values throughout the application. We want to introduce a `Unit` struct that explicitly states the denomination. A new type, `MinorUnit`, has been added to standardize the flo...
diff --git a/crates/router/src/connector/wise.rs b/crates/router/src/connector/wise.rs index 8123ae7ec79..9f41651b2f9 100644 --- a/crates/router/src/connector/wise.rs +++ b/crates/router/src/connector/wise.rs @@ -1,8 +1,8 @@ pub mod transformers; -use std::fmt::Debug; #[cfg(feature = "payouts")] use common_utils::...
2024-10-30T14:13:48Z
## Description <!-- Describe your changes in detail --> This pull request introduces significant changes to the Wise connector in the `crates/router` module, focusing on the integration of a new amount conversion utility and refactoring to utilize a new `WiseRouterData` struct. The changes enhance how amounts are ha...
72ee434003eef744d516343a2f803264f226d92a
[ "crates/router/src/connector/wise.rs", "crates/router/src/connector/wise/transformers.rs", "crates/router/src/types/api.rs", "crates/router/tests/connectors/wise.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4774
Bug: feat: Add config to force 2FA for users Currently 2FA is skippable in all the environments. We need to force 2FA in prod later at some point, so there should be config to which forces 2FA is enabled.
diff --git a/config/config.example.toml b/config/config.example.toml index b0d3c743673..5aa45af85ac 100644 --- a/config/config.example.toml +++ b/config/config.example.toml @@ -395,6 +395,7 @@ password_validity_in_days = 90 # Number of days after which password shoul two_factor_auth_expiry_in_secs = 300 # Number...
2024-10-30T08:44:07Z
## Description <!-- Describe your changes in detail --> This PR will add force 2fa environment variable. When enabled it will force users to complete 2FA to access the control center. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link...
19cf0f7437a8d16ee4da254d2a3e2659879be68c
1. 2FA Status API - `is_skippable` field is added in the response. ``` curl --location 'http://localhost:8080/user/2fa/v2' \ --header 'Authorization: JWT' \ ``` ``` { "status": null, "is_skippable": true } ``` 2. Terminate 2FA API - This API will now no...
[ "config/config.example.toml", "config/deployments/integration_test.toml", "config/deployments/production.toml", "config/deployments/sandbox.toml", "config/development.toml", "config/docker_compose.toml", "crates/api_models/src/user.rs", "crates/router/src/configs/settings.rs", "crates/router/src/cor...
juspay/hyperswitch
juspay__hyperswitch-4669
Bug: Adding events for Payment Reject Created from #4525 This covers adding events for Payment Reject operation This event should include the payment data similar to [PaymentCancel](https://github.com/juspay/hyperswitch/pull/4166) It should also include any metadata for the event e.g reason for payment ...
diff --git a/crates/router/src/core/payments/operations/payment_reject.rs b/crates/router/src/core/payments/operations/payment_reject.rs index 55b93501275..23531d2342d 100644 --- a/crates/router/src/core/payments/operations/payment_reject.rs +++ b/crates/router/src/core/payments/operations/payment_reject.rs @@ -12,6 +1...
2024-10-29T18:10:34Z
## Description <!-- Describe your changes in detail --> Pass along request_state to payment_core Modify the UpdateTracker trait to accept request state Modify the PaymentReject implementation of UpdateTracker to generate an event ## Motivation and Context <!-- Why is this change required? What problem does...
ce95b6538dca4515b04ac65c2b1063bdd0a9c3a7
This requires FRM related flows to be tested, and may not be tested locally.
[ "crates/router/src/core/payments/operations/payment_reject.rs", "crates/router/src/events/audit_events.rs" ]
juspay/hyperswitch
juspay__hyperswitch-6461
Bug: fix(analytics): add dynamic limit by clause in failure reasons metric query Currently, the `limit by` clause in query_builder of `failure_reasons` metric has only `connector` hardcoded. Should change this behaviour to enable dynamic addition of `group by` fields to the `limit by `clause as well.
diff --git a/crates/analytics/src/payments/metrics/sessionized_metrics/failure_reasons.rs b/crates/analytics/src/payments/metrics/sessionized_metrics/failure_reasons.rs index 70ae64e0115..bcbce0502d2 100644 --- a/crates/analytics/src/payments/metrics/sessionized_metrics/failure_reasons.rs +++ b/crates/analytics/src/pay...
2024-10-29T10:33:52Z
## Description <!-- Describe your changes in detail --> - Currently, the `limit by` clause in query_builder of `failure_reasons` metric has only `connector` hardcoded. - Changed this behaviour to enable dynamic addition of `group` by fields to the `limit by` clause as well. ## Motivation and Context <!-- Why ...
55a81eb4692979036d0bfd43e445d3e1db6601e7
Hit the curl: ```bash curl --location 'http://localhost:8080/analytics/v1/org/metrics/payments' \ --header 'Accept: */*' \ --header 'Accept-Language: en-US,en;q=0.9' \ --header 'Connection: keep-alive' \ --header 'Content-Type: application/json' \ --header 'Origin: http://localhost:9000' \ --header 'Referer: ...
[ "crates/analytics/src/payments/metrics/sessionized_metrics/failure_reasons.rs" ]
juspay/hyperswitch
juspay__hyperswitch-6457
Bug: feat(users): add tenant_id in user roles - Use global interface for user roles - Add column tenant_id in user_roles - Handle insertion of tenant_id - Hadle token validation, a token issued in one tenant should not work in other tenancy
diff --git a/crates/diesel_models/src/schema.rs b/crates/diesel_models/src/schema.rs index e2ab676b2d3..782d7f50eac 100644 --- a/crates/diesel_models/src/schema.rs +++ b/crates/diesel_models/src/schema.rs @@ -1343,6 +1343,8 @@ diesel::table! { #[max_length = 64] entity_type -> Nullable<Varchar>, ...
2024-10-28T21:08:20Z
## Description This PR includes - Use of global interface for user roles table - Add tenant_id column in user_roles table - Handle user_role insertions with correct value for tenant_id - Auth Changes: Token validation, token issued in one tenancy should not be valid in other ## Motivation and Context Closes ...
a5ac69d1a77e772e430df8c4187942de44f23079
With the multi -tenancy feature flag enabled, when trying to signup by sending different headers for different tenancies> ``` curl --location 'http://localhost:8080/user/signup?token_only=true' \ --header 'x-tenant-id: test' \ --header 'Content-Type: application/json' \ --data-raw '{ "email": "global_test@jus...
[ "crates/diesel_models/src/schema.rs", "crates/diesel_models/src/schema_v2.rs", "crates/diesel_models/src/user_role.rs", "crates/router/src/analytics.rs", "crates/router/src/core/errors/user.rs", "crates/router/src/core/recon.rs", "crates/router/src/core/user.rs", "crates/router/src/core/user_role.rs",...
juspay/hyperswitch
juspay__hyperswitch-6456
Bug: reduce cargo build jobs to 3 from 4 try reducing cargo build jobs to 3
2024-10-28T12:41:02Z
## Description <!-- Describe your changes in detail --> This PR reduces build jobs to 3 to see if it helps pass Cypress CI checks ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, w...
cd6265887adf7c17136e9fb608e97e6dd535e360
CI should work
[]
juspay/hyperswitch
juspay__hyperswitch-6484
Bug: Refactor: interpolate success based routing params with their specific values
diff --git a/crates/api_models/src/routing.rs b/crates/api_models/src/routing.rs index 47d75b2e835..389af3dab7b 100644 --- a/crates/api_models/src/routing.rs +++ b/crates/api_models/src/routing.rs @@ -615,8 +615,11 @@ impl Default for SuccessBasedRoutingConfig { pub enum SuccessBasedRoutingConfigParams { PaymentM...
2024-10-28T08:12:03Z
## Description <!-- Describe your changes in detail --> This will interpolate the success_based_routing config params with the specific payment's values: So for now the redis key was something like PaymentMethod:Currency After this change it will be something like Card:USD ## Motivation and Context <!-- Why ...
90d9ffc1d2e13b83931762b05632056520eea07f
This is tested locally can't be tested on sbx or integ as it requires access for redis. <img width="1292" alt="Screenshot 2024-11-07 at 5 14 06 PM" src="https://github.com/user-attachments/assets/b5a096ae-3ab7-4e94-9aa0-502b7ab94417">
[ "crates/api_models/src/routing.rs", "crates/external_services/src/grpc_client.rs", "crates/external_services/src/grpc_client/dynamic_routing.rs", "crates/router/src/core/errors.rs", "crates/router/src/core/payments.rs", "crates/router/src/core/payments/operations/payment_response.rs", "crates/router/src...
juspay/hyperswitch
juspay__hyperswitch-6449
Bug: Update broken readme icon Updating broken readme icon along with reposition of the hero image
diff --git a/README.md b/README.md index ccdd6e19b6d..10fdb6afc76 100644 --- a/README.md +++ b/README.md @@ -22,7 +22,7 @@ The single API to access payment ecosystems across 130+ countries</div> <p align="center"> <a href="https://github.com/juspay/hyperswitch/actions?query=workflow%3ACI+branch%3Amain"> - <img...
2024-10-28T05:20:16Z
TOC icon and reposition of the hero image in readme ## Description <!-- Describe your changes in detail --> Updated the icon of CI Push and repositioned the hero image closes #6449 ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please li...
cd6265887adf7c17136e9fb608e97e6dd535e360
[ "README.md" ]
juspay/hyperswitch
juspay__hyperswitch-6751
Bug: [BUG] Description for refunds - list is not apt ### Bug Description https://api-reference.hyperswitch.io/api-reference/refunds/refunds--list This should be - `Lists all the refunds associated with the merchant, or for a specific payment if payment_id is provided` Current one implies that it'll return ref...
diff --git a/crates/openapi/src/routes/refunds.rs b/crates/openapi/src/routes/refunds.rs index 4e096e243a8..0ff0891ee54 100644 --- a/crates/openapi/src/routes/refunds.rs +++ b/crates/openapi/src/routes/refunds.rs @@ -115,7 +115,7 @@ pub async fn refunds_update() {} /// Refunds - List /// -/// Lists all the refunds ...
2024-10-27T18:30:36Z
## Description The current description for refund - list is incorrect. Newer one looks more apt. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend starting with one fi...
086115f47379b06185a1753979fc6dd9dc945afd
[ "crates/openapi/src/routes/refunds.rs" ]
juspay/hyperswitch
juspay__hyperswitch-6354
Bug: Refactor: add deep health check for dynamic routing
diff --git a/config/config.example.toml b/config/config.example.toml index 191f2ba7f8b..12df81d82c9 100644 --- a/config/config.example.toml +++ b/config/config.example.toml @@ -789,3 +789,4 @@ connector_list = "cybersource" # Supported connectors for network tokenization [grpc_client.dynamic_routing_client] # Dynamic ...
2024-10-25T19:11:21Z
## Description <!-- Describe your changes in detail --> Implemented gRPC based health check ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend starting with one first so...
ea81432e3eb72d9a2e139e26741a42cdd8d31202
Tested locally ``` curl --location --request GET 'http://localhost:8080/health/ready' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: dev_Li5BLbzNIHjf2t0J6kYgS7sQurtmLubs1sGAxTE6MVo59aMBEMDSK6Qt8me7kJZQ' ``` Response ``` { "database": true, "re...
[ "config/config.example.toml", "config/deployments/env_specific.toml", "crates/api_models/Cargo.toml", "crates/api_models/src/health_check.rs", "crates/external_services/build.rs", "crates/external_services/src/grpc_client.rs", "crates/external_services/src/grpc_client/dynamic_routing.rs", "crates/exte...
juspay/hyperswitch
juspay__hyperswitch-6439
Bug: fix(authz): Proper descriptions for parents Currently descriptions for parent groups in invite page of control center are not entity specific. That means, customers in description will be visible for profile level users when it shouldn't.
diff --git a/crates/api_models/src/events/user_role.rs b/crates/api_models/src/events/user_role.rs index a2c76ecc394..e0df36a3349 100644 --- a/crates/api_models/src/events/user_role.rs +++ b/crates/api_models/src/events/user_role.rs @@ -2,8 +2,9 @@ use common_utils::events::{ApiEventMetric, ApiEventsType}; use crate...
2024-10-25T12:17:59Z
## Description <!-- Describe your changes in detail --> Make new APIs to replace - `/user/role/{{role_id}}` -> `/user/role/{{role_id}}/v2` - `/user/role` -> `/user/role/v2` - `/user/module/list` -> `/user/parent/list` The new APIs will have proper description and parent info which has entity level context unli...
98567569c1c61648eebf0ad7a1ab58bba967b427
1. Parent List ``` curl --location 'http://localhost:8080/user/parent/list' \ --header 'Authorization: JWT' \ ``` ```json [ { "name": "Operations", "description": "View and Manage Payments, Refunds, Mandates, Disputes, Customers, Payouts, Operation Reports, Organ...
[ "crates/api_models/src/events/user_role.rs", "crates/api_models/src/user_role/role.rs", "crates/common_enums/src/enums.rs", "crates/router/src/core/user_role.rs", "crates/router/src/core/user_role/role.rs", "crates/router/src/routes/app.rs", "crates/router/src/routes/lock_utils.rs", "crates/router/src...
juspay/hyperswitch
juspay__hyperswitch-6438
Bug: fix: lazy connection pools for dynamic routing service
diff --git a/Cargo.lock b/Cargo.lock index 9ccedba3c39..78ae2d63adb 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -3126,8 +3126,10 @@ dependencies = [ "dyn-clone", "error-stack", "hex", + "http-body-util", "hyper 0.14.30", "hyper-proxy", + "hyper-util", "hyperswitch_interfaces", "masking", "once_cell", @@...
2024-10-25T10:47:07Z
## Description <!-- Describe your changes in detail --> Previously hyperswitch server was panicking, if it wasn't able to establish a connection with dynamic_routing service. We have fixed this by establishing lazy connection pools and not established channel(which was previously). Which will insure hyperswitch serv...
aaac9aa97d1b00d50bec4e02efb0658956463398
Tested on my local. <img width="1728" alt="Screenshot 2024-10-25 at 4 15 03 PM" src="https://github.com/user-attachments/assets/a7a1d6c8-8c6c-4b35-ae3a-b05b6af9f9bc"> This can't be tested on Integ as we don't have this service on integ. Can't be tested on sbx as well, as it will require the pods to be killed. and ...
[ "Cargo.lock", "crates/external_services/Cargo.toml", "crates/external_services/src/grpc_client/dynamic_routing.rs" ]
juspay/hyperswitch
juspay__hyperswitch-6436
Bug: chore(users): change entity_type column of roles to non-optional Make entity-type in roles non-optional
diff --git a/crates/diesel_models/src/role.rs b/crates/diesel_models/src/role.rs index 3fb64e645d6..8199bd3979c 100644 --- a/crates/diesel_models/src/role.rs +++ b/crates/diesel_models/src/role.rs @@ -18,7 +18,7 @@ pub struct Role { pub created_by: String, pub last_modified_at: PrimitiveDateTime, pub las...
2024-10-25T09:20:18Z
## Description <!-- Describe your changes in detail --> Earlier entity-type column in roles table was optional , after this change the column will be non-optional with default value as Merchant ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, p...
8372389671c4aefeb625365d198390df5d8f35a5
- Request : ``` curl 'http://localhost:8080/user/role' \ -H 'authorization: Bearer JWT \ --data-raw '{"role_scope":"merchant","groups":["operations_manage","connectors_view","connectors_manage"],"role_name":"merch-scope-merch-role"}' ``` Response : ``` { "role_id": "role_qrQ05Q9pu7czBlDEWnGE", ...
[ "crates/diesel_models/src/role.rs", "crates/diesel_models/src/schema.rs", "crates/diesel_models/src/schema_v2.rs", "crates/router/src/core/user_role/role.rs", "crates/router/src/db/role.rs", "crates/router/src/services/authorization/roles.rs", "migrations/2024-10-24-123318_update-entity-type-column-in-r...
juspay/hyperswitch
juspay__hyperswitch-4680
Bug: Add audit events for PaymentApprove update Created from #4525 This covers adding events for PaymentApprove operation This event should include the payment data similar to [PaymentCancel](https://github.com/juspay/hyperswitch/pull/4166) It should also include any metadata for the event e.g reason fo...
diff --git a/crates/router/src/core/payments/operations/payment_approve.rs b/crates/router/src/core/payments/operations/payment_approve.rs index fe5e7a7e72f..2bc18122b22 100644 --- a/crates/router/src/core/payments/operations/payment_approve.rs +++ b/crates/router/src/core/payments/operations/payment_approve.rs @@ -12,...
2024-10-24T18:41:48Z
## Description This PR adds an Audit event for the PaymentApprove operation. ## Motivation and Context This PR fixes #4680 ## How did you test it This requires FRM related flows to be tested, and may not be tested locally.
063fe904c66c9af3d7ce0a82ad712eac69e41786
[ "crates/router/src/core/payments/operations/payment_approve.rs", "crates/router/src/events/audit_events.rs" ]
juspay/hyperswitch
juspay__hyperswitch-6430
Bug: fix(analytics): fix refund status filter on dashboard Whenever Refund Status filter is applied on the analytics section on dashboard, errors are being generated. The wrong RefundStatus enum has been imported for the RefundStatus filter in RefundFilters struct in this PR: https://github.com/juspay/hyperswitch/pu...
diff --git a/crates/api_models/src/analytics/refunds.rs b/crates/api_models/src/analytics/refunds.rs index 8acb51e764c..ef17387d1ea 100644 --- a/crates/api_models/src/analytics/refunds.rs +++ b/crates/api_models/src/analytics/refunds.rs @@ -5,7 +5,7 @@ use std::{ use common_utils::id_type; -use crate::{enums::Curr...
2024-10-24T13:21:38Z
## Description <!-- Describe your changes in detail --> - Whenever `Refund Status` filter is applied on the analytics section on dashboard, errors are being generated. - The wrong `RefundStatus` enum has been imported for the `RefundStatus` filter in `RefundFilters` struct in this PR: [https://github.com/juspay/hyp...
c3b0f7c1d6ad95034535048aa50ff6abe9ed6aa0
- Apply the refund status filter on the dashboard - Hit the curl: ```bash curl --location 'http://localhost:8080/analytics/v1/org/metrics/refunds' \ --header 'Accept: */*' \ --header 'Accept-Language: en-US,en;q=0.9' \ --header 'Connection: keep-alive' \ --header 'Content-Type: application/json' \ --header ...
[ "crates/api_models/src/analytics/refunds.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4672
Bug: Add audit events for PaymentCreate update Created from https://github.com/juspay/hyperswitch/issues/4525 This covers adding events for PaymentCreate operation This event should include the payment data similar to https://github.com/juspay/hyperswitch/pull/4166 It should also include any metadata for th...
diff --git a/crates/router/src/core/payments/operations/payment_create.rs b/crates/router/src/core/payments/operations/payment_create.rs index d4057c523bc..c65e58ea2d4 100644 --- a/crates/router/src/core/payments/operations/payment_create.rs +++ b/crates/router/src/core/payments/operations/payment_create.rs @@ -42,6 +4...
2024-10-24T11:52:21Z
## Description This PR adds an Audit event for the PaymentCreate operation. ## Motivation and Context This PR fixes #4672 ## How did you test it Hit the `Payments - Create` endpoint with `"confirm": false` - Curl: ```bash curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: a...
1ba3d84df1e93d2286db1a262c4a67b3861b90c0
[ "crates/router/src/core/payments/operations/payment_create.rs", "crates/router/src/events/audit_events.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4682
Bug: Add audit events for PaymentUpdate update Created from #4525 This covers adding events for PaymentUpdate operation This event should include the payment data similar to [PaymentCancel](https://github.com/juspay/hyperswitch/pull/4166) It should also include any metadata for the event e.g reason for ...
diff --git a/crates/router/src/core/payments/operations/payment_update.rs b/crates/router/src/core/payments/operations/payment_update.rs index 9005e94c962..2f1a0c333fa 100644 --- a/crates/router/src/core/payments/operations/payment_update.rs +++ b/crates/router/src/core/payments/operations/payment_update.rs @@ -25,6 +2...
2024-10-24T11:03:29Z
## Description This PR adds an Audit event for the PaymentUpdate operation. ## Motivation and Context This PR fixes #4682 ## How did you test it - Hit the `Payments - Create` endpoint. Make a payment with `"confirm": false` ```bash curl --location 'http://localhost:8080/payments' \ --header 'Content...
fe4931a37e6030ea03ca83540f9a21877c7b6b34
[ "crates/router/src/core/payments/operations/payment_update.rs", "crates/router/src/events/audit_events.rs" ]
juspay/hyperswitch
juspay__hyperswitch-6417
Bug: feat(analytics): add `sessionized_metrics` for refunds (backwards compatibility) and `currency_conversion` ## Current Behaviour - There is no `sessionized_metrics` module for refunds like there is for `payments` and `payment_intents` - Update the existing metrics with `currency_conversion` usage. ## Propos...
diff --git a/crates/analytics/src/payment_intents/core.rs b/crates/analytics/src/payment_intents/core.rs index 7ea8e9007f7..b242b3dae81 100644 --- a/crates/analytics/src/payment_intents/core.rs +++ b/crates/analytics/src/payment_intents/core.rs @@ -69,11 +69,21 @@ pub async fn get_sankey( i.refunds...
2024-10-23T19:59:24Z
## Description <!-- Describe your changes in detail --> - Add sessionized metrics module and implement backwards compatibility. - Implement currency conversion for refunds analytics ### Minor unrelated changes - refactor inconsistent naming of fields in some places => [commit](https://github.com/juspay/hyperswi...
1ba3d84df1e93d2286db1a262c4a67b3861b90c0
```bash curl --location 'http://localhost:8080/analytics/v1/org/metrics/refunds' \ --header 'Accept: */*' \ --header 'Accept-Language: en-GB,en-US;q=0.9,en;q=0.8' \ --header 'Connection: keep-alive' \ --header 'Content-Type: application/json' \ --header 'Origin: http://localhost:9000' \ --header 'QueryType: Si...
[ "crates/analytics/src/payment_intents/core.rs", "crates/analytics/src/payments/accumulator.rs", "crates/analytics/src/payments/core.rs", "crates/analytics/src/refunds/accumulator.rs", "crates/analytics/src/refunds/core.rs", "crates/analytics/src/refunds/metrics.rs", "crates/analytics/src/refunds/metrics...
juspay/hyperswitch
juspay__hyperswitch-6416
Bug: feat(analytics): implement currency conversion to power multi-currency aggregation ## Current Behaviour The total amount calculated for all payment analytics buckets related to amounts is incorrect because currency conversion is not being applied before summing the values. As a result, amounts in different cur...
diff --git a/Cargo.lock b/Cargo.lock index 26ad619ee0b..8c69154fcea 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -353,6 +353,7 @@ dependencies = [ "bigdecimal", "common_enums", "common_utils", + "currency_conversion", "diesel_models", "error-stack", "futures 0.3.30", @@ -363,6 +364,7 @@ dependencies = [ "o...
2024-10-23T19:46:05Z
## Description - implemented currency_conversion for calculating values of amount related metrics from their currency (i.e `INR`) to `USD` and store it in a separate field variant I created `<fieldname>_in_usd` - Implemented a total_amount_in_usd variant for all the total fields related to amounts in query Metadat...
aee11c560e427195a0d321dff19c0d33ec60ba64
### API request for metrics ```bash curl --location 'http://localhost:8080/analytics/v1/org/metrics/payments' \ --header 'Accept: */*' \ --header 'Accept-Language: en-GB,en-US;q=0.9,en;q=0.8' \ --header 'Connection: keep-alive' \ --header 'Content-Type: application/json' \ --header 'Origin: http://localhost:...
[ "Cargo.lock", "crates/analytics/Cargo.toml", "crates/analytics/src/errors.rs", "crates/analytics/src/payment_intents/accumulator.rs", "crates/analytics/src/payment_intents/core.rs", "crates/analytics/src/payment_intents/metrics/sessionized_metrics/payment_processed_amount.rs", "crates/analytics/src/paym...
juspay/hyperswitch
juspay__hyperswitch-6020
Bug: [REFACTOR]: [RAPYD] Add amount conversion framework to Rapyd ### :memo: Feature Description Currently, amounts are represented as `i64` values throughout the application. We want to introduce a `Unit` struct that explicitly states the denomination. A new type, `MinorUnit`, has been added to standardize the f...
diff --git a/crates/router/src/connector/rapyd.rs b/crates/router/src/connector/rapyd.rs index da10513b3d3..196eb4ce73d 100644 --- a/crates/router/src/connector/rapyd.rs +++ b/crates/router/src/connector/rapyd.rs @@ -1,11 +1,11 @@ pub mod transformers; -use std::fmt::Debug; use base64::Engine; use common_utils::{ ...
2024-10-23T13:43:06Z
## Description <!-- Describe your changes in detail --> This PR adds amount conversion framework to rapyd. rapyd accepts amount in MinorUnit ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have a...
cd6265887adf7c17136e9fb608e97e6dd535e360
[ "crates/router/src/connector/rapyd.rs", "crates/router/src/connector/rapyd/transformers.rs", "crates/router/src/types/api.rs", "crates/router/tests/connectors/rapyd.rs" ]
juspay/hyperswitch
juspay__hyperswitch-6410
Bug: [FEATURE] [PAZE] Add amount, currency and email to paze session response ### Feature Description Add amount, currency and email to paze session response ### Possible Implementation { "wallet_name": "paze", "client_id": "HIDDEN", "client_name": "HIDDEN", "cl...
diff --git a/api-reference-v2/openapi_spec.json b/api-reference-v2/openapi_spec.json index bd9de3a2962..c85bfad3326 100644 --- a/api-reference-v2/openapi_spec.json +++ b/api-reference-v2/openapi_spec.json @@ -16199,7 +16199,9 @@ "required": [ "client_id", "client_name", - "client...
2024-10-23T11:22:25Z
## Description <!-- Describe your changes in detail --> Add amount, currency and email to paze session response ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend starti...
e36ea184ae6d1363fb1af55c790162df9f8b451c
Session Request Paze: ``` curl --location 'http://localhost:8080/payments/session_tokens' \ --header 'Content-Type: application/json' \ --header 'api-key: API_KEY_HERE' \ --data '{ "payment_id": "pay_Omdaxo733MC34fLvCfYw", "wallets": [], "client_secret": "pay_Omdaxo733MC34fLvCfYw_secret_ak2iLU1A5E...
[ "api-reference-v2/openapi_spec.json", "crates/api_models/src/payments.rs", "crates/hyperswitch_domain_models/src/router_request_types.rs", "crates/router/src/core/payments/flows/session_flow.rs", "crates/router/src/core/payments/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-6425
Bug: fix(payment_methods): fix merchant payment method list to retain a mca based on connector_name and mca_id Earlier a connector was occurring twice while doing a session token call for wallets. This PR fixes merchant payment method list to retain a mca based on connector_name and mca_id. So that with every distin...
diff --git a/crates/api_models/src/payment_methods.rs b/crates/api_models/src/payment_methods.rs index 84106a87d9b..d5255b5e8c5 100644 --- a/crates/api_models/src/payment_methods.rs +++ b/crates/api_models/src/payment_methods.rs @@ -1217,12 +1217,14 @@ pub struct ResponsePaymentMethodIntermediate { pub card_networ...
2024-10-23T09:37:30Z
## Description Earlier a connector was occurring twice while doing a session token call for wallets. This PR fixes merchant payment method list to retain a mca based on connector_name and mca_id. So that with every distinct mca_id the connector is listed just once for wallets. ## Motivation and Context <!-- W...
4ef48c39b3ed7c1fcda9c850da766a0bdb701335
- Create a MA and an MCA(with wallets enabled) - Create an payment_intent ``` Intent Response { "payment_id": "pay_NHWegNguTfDH9hxuVj1m", "merchant_id": "merchant_1729514766", "status": "requires_payment_method", "amount": 8500, "net_amount": 8500, "shipping_cost": null, "amount_...
[ "crates/api_models/src/payment_methods.rs", "crates/router/src/core/payment_methods/cards.rs", "crates/router/src/core/payments.rs" ]
juspay/hyperswitch
juspay__hyperswitch-6406
Bug: feat(analytics): remove additional filters from PaymentIntentFilters hotfix -Additional filters are added to PaymentIntentFilters as new analytics APIs are expected to be calculated from `Sessionizer Payment Intents` table. - Existing metrics on current dashboard are breaking due to these new filters as the ...
diff --git a/crates/analytics/src/payment_intents/core.rs b/crates/analytics/src/payment_intents/core.rs index e04c3b7bd9e..af46baed23e 100644 --- a/crates/analytics/src/payment_intents/core.rs +++ b/crates/analytics/src/payment_intents/core.rs @@ -371,15 +371,6 @@ pub async fn get_filters( PaymentIntentDi...
2024-10-23T07:54:30Z
## Description <!-- Describe your changes in detail --> Hotfix PR for: [https://github.com/juspay/hyperswitch/pull/6403](https://github.com/juspay/hyperswitch/pull/6403) - Additional filters are added to `PaymentIntentFilters` as new analytics APIs are expected to be calculated from `Sessionizer Payment Intents` ta...
76dda56642ceef8cc56104a715b76c4c1663da28
Added filters of connector, payment_method, etc on the dashboard and the payments v2 APIs should not return 500 error. - Hit the curl: ```bash curl --location 'http://localhost:8080/analytics/v2/org/metrics/payments' \ --header 'Accept: */*' \ --header 'Accept-Language: en-US,en;q=0.9' \ --header 'Connection: k...
[ "crates/analytics/src/payment_intents/core.rs", "crates/analytics/src/payment_intents/filters.rs", "crates/analytics/src/payment_intents/metrics.rs", "crates/analytics/src/payment_intents/metrics/payment_intent_count.rs", "crates/analytics/src/payment_intents/metrics/payments_success_rate.rs", "crates/ana...
juspay/hyperswitch
juspay__hyperswitch-5990
Bug: [FIX] Remove ToSchema from RefundAggregateResponse and exclude it from OpenAPI documentation ### Feature Description The RefundAggregateResponse type used by the [/refunds/aggregate](https://github.com/juspay/hyperswitch/blob/37925626e6446900f1d16e0e5f184ee472d4be3e/crates/router/src/routes/app.rs#L1004) API...
diff --git a/api-reference-v2/openapi_spec.json b/api-reference-v2/openapi_spec.json index 72afa1dc3da..63c01329dfe 100644 --- a/api-reference-v2/openapi_spec.json +++ b/api-reference-v2/openapi_spec.json @@ -18158,22 +18158,6 @@ } } }, - "RefundAggregateResponse": { - "type": "ob...
2024-10-22T20:13:07Z
## Description <!-- Describe your changes in detail --> Removed all the openapi references to `RefundAggregateResponse`. 1. Removed `ToSchema` trait for `RefundAggregateResponse`. 2. Removed references from `openapi` and `openapi_v2` to `RefundAggregateResponse`. 3. Generated new `openapi_spec` file based on th...
aee11c560e427195a0d321dff19c0d33ec60ba64
Tested manually. The references of `RefundAggregateResponse` is removed in openapi generated json file after the modification. <img width="871" alt="image" src="https://github.com/user-attachments/assets/70f23a10-37e9-420e-8031-f41e6b5f11da"> <img width="1015" alt="image" src="https://github.com/user-attachment...
[ "api-reference-v2/openapi_spec.json", "crates/api_models/src/refunds.rs", "crates/openapi/src/openapi.rs", "crates/openapi/src/openapi_v2.rs" ]
juspay/hyperswitch
juspay__hyperswitch-6404
Bug: feat(analytics): remove additional filters from PaymentIntentFilters -Additional filters are added to PaymentIntentFilters as new analytics APIs are expected to be calculated from `Sessionizer Payment Intents` table. - Existing metrics on current dashboard are breaking due to these new filters as the fields ar...
diff --git a/crates/analytics/src/payment_intents/core.rs b/crates/analytics/src/payment_intents/core.rs index e04c3b7bd9e..af46baed23e 100644 --- a/crates/analytics/src/payment_intents/core.rs +++ b/crates/analytics/src/payment_intents/core.rs @@ -371,15 +371,6 @@ pub async fn get_filters( PaymentIntentDi...
2024-10-22T18:22:21Z
## Description <!-- Describe your changes in detail --> Fix for this PR: [https://github.com/juspay/hyperswitch/pull/5870](https://github.com/juspay/hyperswitch/pull/5870) - Additional filters are added to `PaymentIntentFilters` as new analytics APIs are expected to be calculated from `Sessionizer Payment Intents` ...
3d1a3cdc8f942a3dca2e6a200bf9200366bd62f1
Added filters of connector, payment_method, etc on the dashboard and the payments v2 APIs should not return 500 error. - Hit the curl: ```bash curl --location 'http://localhost:8080/analytics/v2/org/metrics/payments' \ --header 'Accept: */*' \ --header 'Accept-Language: en-US,en;q=0.9' \ --header 'Connection: k...
[ "crates/analytics/src/payment_intents/core.rs", "crates/analytics/src/payment_intents/filters.rs", "crates/analytics/src/payment_intents/metrics.rs", "crates/analytics/src/payment_intents/metrics/payment_intent_count.rs", "crates/analytics/src/payment_intents/metrics/payments_success_rate.rs", "crates/ana...
juspay/hyperswitch
juspay__hyperswitch-6399
Bug: chore: address Rust 1.82.0 clippy lints Address the clippy lints occurring due to new rust version 1.82.0 See https://github.com/juspay/hyperswitch/issues/3391 for more information.
diff --git a/add_connector.md b/add_connector.md index eda368db9c8..4d6e885b7ed 100644 --- a/add_connector.md +++ b/add_connector.md @@ -311,7 +311,7 @@ impl TryFrom<types::PaymentsResponseRouterData<PaymentsResponse>> let payments_response_data = types::PaymentsResponseData::TransactionResponse { ...
2024-10-22T13:48:39Z
## Description <!-- Describe your changes in detail --> This PR addresses the clippy lints occurring due to new rust version 1.82.0. Majorly addresses below warning - ![image](https://github.com/user-attachments/assets/f3f154e7-4062-4b48-a71b-ea5a2ea61e94) ## Motivation and Context <!-- Why is this ch...
673b8691e092e145ba211050db4f5c7e021a0ce2
This PR addresses clippy lint due to new rust version. So basic sanity testing should suffice.
[ "add_connector.md", "connector-template/transformers.rs", "crates/api_models/src/connector_onboarding.rs", "crates/api_models/src/payouts.rs", "crates/api_models/src/webhooks.rs", "crates/diesel_models/src/kv.rs", "crates/hyperswitch_connectors/src/connectors/bambora/transformers.rs", "crates/hyperswi...
juspay/hyperswitch
juspay__hyperswitch-6398
Bug: fix(payments): total count issue for card-network filter To close issue https://github.com/juspay/hyperswitch-cloud/issues/7206
diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs index fd1286a555e..4fb5aaf28f2 100644 --- a/crates/api_models/src/payments.rs +++ b/crates/api_models/src/payments.rs @@ -4585,6 +4585,7 @@ impl PaymentListFilterConstraints { && self.payment_method_type.is_none() ...
2024-10-22T12:47:21Z
## Description <!-- Describe your changes in detail --> The total count in the payments response was incorrect when the card-network filter was applied. With this PR, the count will now be accurately filtered as well. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If...
26e0c32f4da5689a1c01fbb456ac008a0b831710
Request : ``` curl 'http://localhost:8080/payments/list' \ -H 'authorization: Bearer JWT token' \ -H 'sec-ch-ua: "Google Chrome";v="129", "Not=A?Brand";v="8", "Chromium";v="129"' \ -H 'sec-ch-ua-mobile: ?0' \ -H 'sec-ch-ua-platform: "macOS"' \ --data-raw '{"offset":0,"limit":50,"start_time":"2024-09...
[ "crates/api_models/src/payments.rs", "crates/diesel_models/src/query/payment_attempt.rs", "crates/hyperswitch_domain_models/src/payments/payment_attempt.rs", "crates/router/src/core/payments.rs", "crates/router/src/db/kafka_store.rs", "crates/storage_impl/src/mock_db/payment_attempt.rs", "crates/storage...
juspay/hyperswitch
juspay__hyperswitch-6395
Bug: [FEATURE] add payments get-intent API for v2 # Feature Description Add payments `get-intent` API for v2
diff --git a/api-reference-v2/api-reference/payments/payments--get-intent.mdx b/api-reference-v2/api-reference/payments/payments--get-intent.mdx new file mode 100644 index 00000000000..cd1321be217 --- /dev/null +++ b/api-reference-v2/api-reference/payments/payments--get-intent.mdx @@ -0,0 +1,3 @@ +--- +openapi: get /v2...
2024-10-22T12:37:13Z
## Description Added `get-intent` API for payments ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend starting with one first so the PR can focus on the implementation (...
fbe395198aea7252e9c4e3fad97956a548d07002
1a. Request ``` curl --location 'http://localhost:8080/v2/payments/12345_pay_0192b3a0145173519abaa04d4b939558/get-intent' \ --header 'Content-Type: application/json' \ --header 'X-Profile-Id: pro_wcilqiS8axGFvpzfO9pw' \ --header 'api-key: dev_D3bTAROAIoP4nlqsaQXLzXoLdZznkpWQ3l4mzMRJEAP7V46pSnZucJM2zQiVwG0J' ```...
[ "api-reference-v2/api-reference/payments/payments--get-intent.mdx", "api-reference-v2/mint.json", "api-reference-v2/openapi_spec.json", "crates/api_models/src/events/payment.rs", "crates/api_models/src/payments.rs", "crates/hyperswitch_domain_models/src/router_flow_types/payments.rs", "crates/openapi/sr...
juspay/hyperswitch
juspay__hyperswitch-6391
Bug: feat(authz): Make permissions entity and scope aware Currently the permissions we use doesn't have any entity level context. But some of our APIs need that context. For example, 1. `payment/list` - This can only be accessible by merchant level users or higher. Profile level users should not be able to access it...
diff --git a/crates/api_models/src/user_role.rs b/crates/api_models/src/user_role.rs index e64639646d1..19027c3cbf8 100644 --- a/crates/api_models/src/user_role.rs +++ b/crates/api_models/src/user_role.rs @@ -1,23 +1,9 @@ -use common_enums::PermissionGroup; +use common_enums::{ParentGroup, PermissionGroup}; use common...
2024-10-22T12:12:38Z
## Description <!-- Describe your changes in detail --> ### Entity level context in Permissions Currently the permissions we use doesn't have any entity level context. But some of our APIs need that context. For example, 1. `payment/list` - This can only be accessible by merchant level users or higher. Profile ...
c7c1e1adabceeb0a03659bf8feb9aa06d85960ea
This is an internal change, no APIs should be affected and all the APIs should be working as usual.
[ "crates/api_models/src/user_role.rs", "crates/common_enums/src/enums.rs", "crates/router/src/analytics.rs", "crates/router/src/core/user_role.rs", "crates/router/src/routes/admin.rs", "crates/router/src/routes/api_keys.rs", "crates/router/src/routes/blocklist.rs", "crates/router/src/routes/connector_o...
juspay/hyperswitch
juspay__hyperswitch-6390
Bug: [FIX] fix tenant nomenclature in the code
diff --git a/config/config.example.toml b/config/config.example.toml index 8f04ba49831..b0d3c743673 100644 --- a/config/config.example.toml +++ b/config/config.example.toml @@ -741,7 +741,7 @@ enabled = false global_tenant = { schema = "public", redis_key_prefix = "", clickhouse_database = "default"} [multitenancy....
2024-10-22T09:27:55Z
## Description <!-- Describe your changes in detail --> This fixes the inconsistent nomenclature used for tenants in router and drainer code ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an...
04c969866816be286720377e73982e21a3302ba9
**This cannot be tested on sandbox without enabling Multi Tenancy** 1. Application runs with the changed config and so does drainer 2. Do a request with a valid `x-tenant-id` ```bash curl --location 'http://localhost:8080/accounts' \ --header 'Content-Type: application/json' \ --header 'Accept: applicatio...
[ "config/config.example.toml", "config/deployments/env_specific.toml", "config/development.toml", "config/docker_compose.toml", "crates/drainer/src/settings.rs", "crates/router/src/configs/settings.rs", "crates/router/src/core/payment_methods/cards.rs", "crates/router/src/core/routing/helpers.rs", "c...
juspay/hyperswitch
juspay__hyperswitch-6387
Bug: include the payment_processing_details_at Hyperswitch option only if apple pay token decryption flow is supported for the connector While configuring apple pay iOS flow `payment_processing_details_at` option is shown that can take two values ,`Connector` or `Hyperswitch`. But the `payment_processing_details_at`...
diff --git a/crates/connector_configs/toml/development.toml b/crates/connector_configs/toml/development.toml index 78f3c627fca..180aadffde3 100644 --- a/crates/connector_configs/toml/development.toml +++ b/crates/connector_configs/toml/development.toml @@ -281,7 +281,7 @@ label="Payment Processing Details At" placehol...
2024-10-22T06:55:26Z
## Description <!-- Describe your changes in detail --> While configuring apple pay iOS flow `payment_processing_details_at` option is shown that can take two values ,`Connector` or `Hyperswitch`. But the `payment_processing_details_at` can be `Hyperswitch` only if the apple pay token decryption flow is implemented ...
f3a869ea9a430f3b5177852fb74d0910dc8fbe17
This pr includes wasam changes to not show the `payment_processing_details_at` `Hyperswitch` when the web apple pay flow is not enabled. Things to test the below radio button with Hyperswitch option should not be shown if apple pay web flow is not enalbed. <img width="562" alt="image" src="https://github.com/user...
[ "crates/connector_configs/toml/development.toml", "crates/connector_configs/toml/production.toml", "crates/connector_configs/toml/sandbox.toml" ]
juspay/hyperswitch
juspay__hyperswitch-6488
Bug: feat(users): Add profile level custom role Currently only merchant level custom role is allowed with role scope as Merchant and organization The requirement is to add profile level custom role at Organization , Merchant and Profile scope
diff --git a/crates/api_models/src/user_role/role.rs b/crates/api_models/src/user_role/role.rs index 7c877cd7477..46e15aafc70 100644 --- a/crates/api_models/src/user_role/role.rs +++ b/crates/api_models/src/user_role/role.rs @@ -7,6 +7,7 @@ pub struct CreateRoleRequest { pub role_name: String, pub groups: Vec...
2024-10-21T12:06:08Z
## Description <!-- Describe your changes in detail --> Earlier we only had access to create Merchant level custom role at Org and Merchant scope . But after this user can be able to create custom role at Profile level at Organization , Merchant and Profile scope ## Motivation and Context <!-- Why is this c...
adc5262f130e25e9d711915ea9ad587bcbd0118f
**Create Custom role at profile level** ```sh curl --location 'http://localhost:8080/user/role' \ --header 'authorization: Bearer user JWT Token' \ --data '{ "role_scope": "organization", "groups": [ "operations_view", "operations_manage", "connectors_view" ], "role_name": "org-scope-pr...
[ "crates/api_models/src/user_role/role.rs", "crates/common_enums/src/enums.rs", "crates/diesel_models/src/query/role.rs", "crates/diesel_models/src/role.rs", "crates/diesel_models/src/schema.rs", "crates/diesel_models/src/schema_v2.rs", "crates/router/src/core/user_role/role.rs", "crates/router/src/db/...
juspay/hyperswitch
juspay__hyperswitch-6375
Bug: refactor(permissions): Deprecate permissions from permission info API response The permissions in the permission info API are not being used and should be removed.
diff --git a/crates/api_models/src/user_role.rs b/crates/api_models/src/user_role.rs index ab32651e729..e64639646d1 100644 --- a/crates/api_models/src/user_role.rs +++ b/crates/api_models/src/user_role.rs @@ -4,42 +4,6 @@ use masking::Secret; pub mod role; -#[derive(Debug, serde::Serialize)] -pub enum Permission {...
2024-10-21T06:56:03Z
## Description <!-- Describe your changes in detail --> The permissions in the permission info API are not being used and this PR will remove them. This will help the future PRs which will introduce new kind of Permissions. ## Motivation and Context <!-- Why is this change required? What problem does it sol...
0dba763c3a1c69fa282ffa644a12d37dc14d8f7b
``` curl --location 'https://sandbox.hyperswitch.io/user/permission_info' \ --header 'Authorization: Bearer JWT' ``` This API will no longer have permissions field in the response. ```json [ { "group": "operations_view", "description": "View Payments, Refunds, Payouts, Mandates, Disputes ...
[ "crates/api_models/src/user_role.rs", "crates/router/src/services/authorization/info.rs", "crates/router/src/services/authorization/permissions.rs", "crates/router/src/utils/user_role.rs" ]
juspay/hyperswitch
juspay__hyperswitch-6177
Bug: [FEATURE] integrate 3DS for Worldpay connector ### Feature Description WorldPay offers 3DS capabilities for a card txn. Same needs to be integrated in HyperSwitch. Flow - https://developer.worldpay.com/products/access/3ds/web ### Possible Implementation Implementing 3DS for WorldPay requires one additiona...
diff --git a/crates/diesel_models/src/query/payment_attempt.rs b/crates/diesel_models/src/query/payment_attempt.rs index 85c69824892..0627fa0048a 100644 --- a/crates/diesel_models/src/query/payment_attempt.rs +++ b/crates/diesel_models/src/query/payment_attempt.rs @@ -171,11 +171,23 @@ impl PaymentAttempt { me...
2024-10-20T09:44:04Z
## Description Described in #6177 ## Motivation and Context Integrates Worldpay's 3DS flow #
58296ffae6ff6f2f2c8f7b23dd28e92b374b9be3
Things to test 1. 3DS payments using automatic capture 2. No 3DS payment using manual capture (full amount captures) 3. Payments Sync <details> <summary>1. Create and capture</summary> cURL curl --location --request POST 'http://localhost:8080/payments' \ --header 'Content-Type: applicat...
[ "crates/diesel_models/src/query/payment_attempt.rs", "crates/hyperswitch_domain_models/src/router_response_types.rs", "crates/router/src/connector/worldpay.rs", "crates/router/src/connector/worldpay/requests.rs", "crates/router/src/connector/worldpay/response.rs", "crates/router/src/connector/worldpay/tra...
juspay/hyperswitch
juspay__hyperswitch-5175
Bug: Adding Contributors Guide to the Readme of the repository Being an open source project, we look forward to contributors from across the world. For that we have outlined few changes which will make it easier for contributors to navigate through the project with more ease, and quickly develop a better understandi...
diff --git a/README.md b/README.md index e8dd2f31674..ccdd6e19b6d 100644 --- a/README.md +++ b/README.md @@ -59,7 +59,6 @@ Here are the components of Hyperswitch that deliver the whole solution: Jump in and contribute to these repositories to help improve and expand Hyperswitch! <br> -<img src="./docs/imgs/hyperswi...
2024-10-18T11:42:24Z
## Description <!-- Describe your changes in detail --> Closes - #5175 ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend starting with one first so the PR can focus o...
451376e7993839f5c93624c12833af7d47aa4e34
[ "README.md" ]
juspay/hyperswitch
juspay__hyperswitch-6364
Bug: feat(config): update vector config # Current Behaviour - Sdk logs pushes `publishable_key` in the `merchant_id` field. - open search logs have some irrelevant fields. # Proposed Changes - transform sdk logs and update the correct corresponding `merchant_id` of the pre-existing `publishable_key` value - add som...
diff --git a/config/vector.yaml b/config/vector.yaml index 3f0709ae03c..4b801935ae5 100644 --- a/config/vector.yaml +++ b/config/vector.yaml @@ -1,5 +1,16 @@ acknowledgements: enabled: true +enrichment_tables: + sdk_map: + type: file + file: + path: /etc/vector/config/sdk_map.csv + encoding: + ...
2024-10-18T10:13:52Z
## Fixes #6364 ## Description <!-- Describe your changes in detail --> - adding a transform for `sdk` logs that fetches a value from an enrichment table `sdk_map` populated by file `sdk_map.csv` and updates the fields using this value. - adding some fields to ignore/except in `opensearch` logs sink **Importa...
35bf5a91d9a5b2d5e476c995e679b445242218e0
### Running it locally to check logs added in console (sdk) logs & opensearch #### sdk_logs I created a dummy_transform event that inserted a `publishable_key` in merchant_id field and passed it to the actual transform function and then captured the output on a [console sink](https://vector.dev/docs/ref...
[ "config/vector.yaml" ]
juspay/hyperswitch
juspay__hyperswitch-6363
Bug: make `x_merchant_domain` as required value only for session call done on web The merchant domain url is only required in case of samsung pay payments on web. While processing payments on app the merchant domain is not required. Hence mandate the merchant domain only if the `x-client-platform` is `web`
diff --git a/api-reference-v2/openapi_spec.json b/api-reference-v2/openapi_spec.json index 1db9c98806b..654161d1c09 100644 --- a/api-reference-v2/openapi_spec.json +++ b/api-reference-v2/openapi_spec.json @@ -19148,7 +19148,6 @@ "type": "object", "required": [ "name", - "url", ...
2024-10-18T08:22:24Z
## Description <!-- Describe your changes in detail --> The merchant domain url is only required in case of samsung pay payments on web. While processing payments on app the merchant domain is not required. Hence mandate the merchant domain only if the `x-client-platform` is `web` ## Motivation and Context <!--...
451376e7993839f5c93624c12833af7d47aa4e34
-> Create a connector with samsung pay enabled -> Create a payment ``` curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: dev_GhK0bBcXMIVjqoKmEip0XbSEvPXOuaEOLlMdBQWL4gdD51LsgHsjj2vzyuxMahw1' \ --data '{ "am...
[ "api-reference-v2/openapi_spec.json", "crates/api_models/src/payments.rs", "crates/router/src/core/payments/flows/session_flow.rs" ]
juspay/hyperswitch
juspay__hyperswitch-2313
Bug: [FEATURE]: [PayU] Use `connector_request_reference_id` as reference to the connector ### :memo: Feature Description - We transmit our reference id from Hyperswitch to the connector, enabling merchants to subsequently locate the payment within the connector dashboard. - Presently, there is a lack of uniformity...
diff --git a/crates/hyperswitch_connectors/src/connectors/payu/transformers.rs b/crates/hyperswitch_connectors/src/connectors/payu/transformers.rs index 7b3792c0e24..dc65d6e1d76 100644 --- a/crates/hyperswitch_connectors/src/connectors/payu/transformers.rs +++ b/crates/hyperswitch_connectors/src/connectors/payu/transfo...
2024-10-18T03:14:35Z
## Description Add connector_request_reference_id support for PayU - Used `extOrderId` as the reference id based on the [PayU documentation](https://developers.payu.com/europe/api/#tag/Order/operation/create-an-order) reference: ![image](https://github.com/user-attachments/assets/f730028d-1fa4-4222-b2ad-7e2b4ca...
c3b0f7c1d6ad95034535048aa50ff6abe9ed6aa0
[ "crates/hyperswitch_connectors/src/connectors/payu/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-6139
Bug: [REFACTOR]: [RISKIFIED] Add amount conversion framework to Riskified ### :memo: Feature Description Currently, amounts are represented as `i64` values throughout the application. We want to introduce a `Unit` struct that explicitly states the denomination. A new type, `MinorUnit`, has been added to standardi...
diff --git a/crates/router/src/connector/riskified.rs b/crates/router/src/connector/riskified.rs index 0f8ebb46134..7d9feec717a 100644 --- a/crates/router/src/connector/riskified.rs +++ b/crates/router/src/connector/riskified.rs @@ -1,8 +1,10 @@ pub mod transformers; -use std::fmt::Debug; #[cfg(feature = "frm")] u...
2024-10-17T18:02:20Z
## Description <!-- Describe your changes in detail --> This PR does amount conversion changes for Riskified Connector and it accepts the amount in MinorUnit ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. I...
cd6265887adf7c17136e9fb608e97e6dd535e360
[ "crates/router/src/connector/riskified.rs", "crates/router/src/connector/riskified/transformers/api.rs", "crates/router/src/types/api/fraud_check.rs" ]
juspay/hyperswitch
juspay__hyperswitch-6357
Bug: feat(opensearch): add additional filters and create sessionizer indexes for local Global search has two components: - Free flow search, wherein search takes place across all fields available to search upon - Search on a specific field based on the field filter Additional filters should be added for global sea...
diff --git a/config/config.example.toml b/config/config.example.toml index c0358d91a26..8f04ba49831 100644 --- a/config/config.example.toml +++ b/config/config.example.toml @@ -728,6 +728,10 @@ payment_attempts = "hyperswitch-payment-attempt-events" payment_intents = "hyperswitch-payment-intent-events" refunds = "hyp...
2024-10-17T12:27:42Z
## Description <!-- Describe your changes in detail --> Global search has two components: - Free flow search, wherein search takes place across all fields available to search upon - Search on a specific field based on the field filter In this PR, additional filters have been added for global search to search ...
962afbd084458e9afb11a0278a8210edd9226a3d
The following filters can be used to be searched upon: - connector - payment_method_type - card_network - card_last_4 - payment_id Hit the following curl for the `/search` API ```bash curl --location 'http://localhost:8080/analytics/v1/search' \ --header 'Accept: */*' \ --header 'Accept-Language: en-US,en...
[ "config/config.example.toml", "config/deployments/env_specific.toml", "config/development.toml", "config/docker_compose.toml", "config/vector.yaml", "crates/analytics/src/opensearch.rs", "crates/analytics/src/search.rs", "crates/api_models/src/analytics/search.rs", "crates/router/src/consts/opensear...
juspay/hyperswitch
juspay__hyperswitch-6348
Bug: set the eligible connector in payment attempt for network transaction id based mit flow [Reference pr](https://github.com/juspay/hyperswitch/pull/6245) In the MIT flow when the recurring details is of type `"type": "network_transaction_id_and_card_details"` the eligible connector needs to be set in the payme...
diff --git a/crates/router/src/core/payments.rs b/crates/router/src/core/payments.rs index 68f318958a2..a6ddc2e2180 100644 --- a/crates/router/src/core/payments.rs +++ b/crates/router/src/core/payments.rs @@ -4193,6 +4193,10 @@ where } }; + // Set the eligible connector in the attempt + pa...
2024-10-17T07:50:34Z
## Description <!-- Describe your changes in detail --> In the MIT flow when the recurring details is of type "type": "network_transaction_id_and_card_details" the eligible connector needs to be set in the payment attempt. ## Motivation and Context <!-- Why is this change required? What problem does it solve? ...
881f5fd0149cb5573eb31451fceb596092eab79a
Create merchant connector account for cybersource -> Make a MIT payment with `"type": "network_transaction_id_and_card_details"` ``` curl --location 'http://localhost:8080/payments' \ --header 'Accept: application/json' \ --header 'api-key: dev_OJYRaFClX8PIIwCNrPWUMttJWZrAXUNbBiyA1GvyYyaxRK5EsqODd2ON8KTOlTMa' \ ...
[ "crates/router/src/core/payments.rs" ]
juspay/hyperswitch
juspay__hyperswitch-6343
Bug: feat(analytics): add customer_id as filter for payment intents Add customer_id as a filter for payment intents
diff --git a/crates/analytics/src/payment_intents/core.rs b/crates/analytics/src/payment_intents/core.rs index af46baed23e..3e8915c60a2 100644 --- a/crates/analytics/src/payment_intents/core.rs +++ b/crates/analytics/src/payment_intents/core.rs @@ -205,7 +205,8 @@ pub async fn get_metrics( | Pa...
2024-10-17T06:31:48Z
## Description <!-- Describe your changes in detail --> - Added `customer_id` as a filter for payment intents - Added `payment_processed_amount` metric for `payment_intents` table ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to ...
829a20cc933267551e49565d06eb08e03e5f13bb
Hit the curl: Metric data would be obtained based on the customer_id filter applied. ```bash curl --location 'http://localhost:8080/analytics/v2/org/metrics/payments' \ --header 'Accept: */*' \ --header 'Accept-Language: en-US,en;q=0.9' \ --header 'Connection: keep-alive' \ --header 'Content-Type: application/...
[ "crates/analytics/src/payment_intents/core.rs", "crates/analytics/src/payment_intents/filters.rs", "crates/analytics/src/payment_intents/metrics.rs", "crates/analytics/src/payment_intents/metrics/payment_processed_amount.rs", "crates/analytics/src/payment_intents/types.rs", "crates/analytics/src/query.rs"...
juspay/hyperswitch
juspay__hyperswitch-6135
Bug: [REFACTOR]: [OPAYO] Add amount conversion framework to Opayo ### :memo: Feature Description Currently, amounts are represented as `i64` values throughout the application. We want to introduce a `Unit` struct that explicitly states the denomination. A new type, `MinorUnit`, has been added to standardize the f...
diff --git a/crates/router/src/connector/opayo.rs b/crates/router/src/connector/opayo.rs index cd1ef67f662..3e7edba2128 100644 --- a/crates/router/src/connector/opayo.rs +++ b/crates/router/src/connector/opayo.rs @@ -1,8 +1,9 @@ mod transformers; -use std::fmt::Debug; - -use common_utils::request::RequestContent; +u...
2024-10-16T22:13:47Z
## Description <!-- Describe your changes in detail --> This PR adds amount conversion framework to Opayo. Opayo accepts amount in MinorUnit ## Motivation and Context Amount conversion for Opayo Fixes #6135 <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please lin...
881f5fd0149cb5573eb31451fceb596092eab79a
[ "crates/router/src/connector/opayo.rs", "crates/router/src/connector/opayo/transformers.rs", "crates/router/tests/connectors/opayo.rs" ]
juspay/hyperswitch
juspay__hyperswitch-6117
Bug: [FEATURE] Generate Random Disputes for sample data ### Feature Description The issue is sub part of issue: #5991 (Please refer to this First) The current implementation of the generate_sample_data_for_user function generates sample data for payments and refunds. However, there is no functionality to generat...
diff --git a/crates/router/src/core/user/sample_data.rs b/crates/router/src/core/user/sample_data.rs index 453b3edf00f..d098d1f76d9 100644 --- a/crates/router/src/core/user/sample_data.rs +++ b/crates/router/src/core/user/sample_data.rs @@ -1,6 +1,6 @@ use api_models::user::sample_data::SampleDataRequest; use common_...
2024-10-16T19:47:45Z
## Description <!-- Describe your changes in detail --> I added dispute generation to function `generate_sample_data` in `utils/user/sample_data.rs`. The number of disputes generated is based on the number of payments created: 2 disputes if the number of payments is between 50 and 100. 1 dispute if the number of...
c3b0f7c1d6ad95034535048aa50ff6abe9ed6aa0
Tested manually. Initial state for both Case1 and Case2: Before sending POST request to `sample_data`, there are 18 non-generated `payment_attempt` records, and 0 `dispute` record. <img width="1384" alt="image" src="https://github.com/user-attachments/assets/a97abf7e-34d4-4bc2-b5e6-fd7ff2908c94"> <img width="11...
[ "crates/router/src/core/user/sample_data.rs", "crates/router/src/utils/user/sample_data.rs" ]
juspay/hyperswitch
juspay__hyperswitch-6271
Bug: [BUG] Do not use backticks in shell files ### Bug Description These scripts: - [`INSTALL_dependencies.sh`](https://github.com/juspay/hyperswitch/tree/535f2f12f825be384a17fba8628d8517027bb6c6/INSTALL_dependencies.sh), - [`hyperswitch_aws_setup.sh`](https://github.com/juspay/hyperswitch/tree/535f2f12f825be384a...
diff --git a/INSTALL_dependencies.sh b/INSTALL_dependencies.sh index 3ec36ccc66e..e1d666b97a3 100755 --- a/INSTALL_dependencies.sh +++ b/INSTALL_dependencies.sh @@ -37,7 +37,7 @@ set -o nounset # utilities # convert semver to comparable integer -if [[ `id -u` -ne 0 ]]; then +if [[ "$(id -u)" -ne 0 ]]; then pri...
2024-10-16T08:15:36Z
## Description <!-- Describe your changes in detail --> Use $(...) notation instead of legacy `...` in the shell files. Removes the use of deprecated backticks notation (cf. [SC2006](https://www.shellcheck.net/wiki/SC2006)). ## Motivation and Context <!-- Why is this change required? What problem does it so...
899ec23565f99daaad821c1ec1482b4c0cc408c5
[ "INSTALL_dependencies.sh", "aws/hyperswitch_aws_setup.sh", "aws/hyperswitch_cleanup_setup.sh", "scripts/add_connector.sh" ]
juspay/hyperswitch
juspay__hyperswitch-5942
Bug: [REFACTOR]: [CYBERSOURCE] Add amount conversion framework to Cybersource ### :memo: Feature Description Currently, amounts are represented as `i64` values throughout the application. We want to introduce a `Unit` struct that explicitly states the denomination. A new type, `MinorUnit`, has been added to stand...
diff --git a/crates/common_utils/src/types.rs b/crates/common_utils/src/types.rs index 2a271acb62b..433a3139d52 100644 --- a/crates/common_utils/src/types.rs +++ b/crates/common_utils/src/types.rs @@ -603,7 +603,6 @@ impl StringMajorUnit { pub fn zero() -> Self { Self("0".to_string()) } - /// Ge...
2024-10-16T07:06:40Z
## Description <!-- Describe your changes in detail --> added StringMajorUnit for amount conversion ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend starting with one ...
55fe82fdcd78df9608842190f1423088740d1087
Tested through postman: - Create a MCA for cybersource: - Create a Payment with Cybersource: ``` { "amount": 499, "currency": "USD", "confirm": true, "capture_method": "automatic", "customer_id": "test_rec7", "email": "guest@example.com", "request_external_three_ds_authenticat...
[ "crates/common_utils/src/types.rs", "crates/router/src/connector/cybersource.rs", "crates/router/src/connector/cybersource/transformers.rs", "crates/router/src/types/api.rs", "crates/router/tests/connectors/cybersource.rs" ]
juspay/hyperswitch
juspay__hyperswitch-6338
Bug: Integration of dynamic connector selection in core flows ## Description This will integrate the dynamic_connector_selection in core flows, enabling the success_based connector selection for payments (with the profiles, enabled with dynamic_connector_selection feature).
diff --git a/crates/api_models/src/routing.rs b/crates/api_models/src/routing.rs index fc65ab037c2..47d75b2e835 100644 --- a/crates/api_models/src/routing.rs +++ b/crates/api_models/src/routing.rs @@ -522,22 +522,51 @@ pub struct DynamicAlgorithmWithTimestamp<T> { #[derive(Debug, Default, Clone, serde::Serialize, se...
2024-10-16T04:25:05Z
## Description <!-- Describe your changes in detail --> This will add dynamic_routing in core flows. After which once the toggle route is hit with `feature = dynamic_connector_selection`, routable connectors will be evaluated on basis of success_based routing. ## Motivation and Context <!-- Why is this change...
39d89f23b6ae85c4f91a52bb0d970277b43237d8
### The testing flows are as follows: 1. Toggle the route with feature(`metrics`, `dynamic_conenctor_selection`, `none`) as `dynamic_connector_selection`. ``` curl --location --request POST 'http://localhost:8080/account/merchant_id/business_profile/profile_id/dynamic_routing/success_based/toggle?enable=dynamic_co...
[ "crates/api_models/src/routing.rs", "crates/openapi/src/openapi.rs", "crates/openapi/src/routes/routing.rs", "crates/router/src/core/errors.rs", "crates/router/src/core/payments.rs", "crates/router/src/core/payments/operations/payment_response.rs", "crates/router/src/core/payments/routing.rs", "crates...
juspay/hyperswitch
juspay__hyperswitch-6330
Bug: fix(list): improve querying time for payments list Quick Fix. Currently payment list is giving intermittent 5xx. After analyzing logs we got to knwo that it is happening for the count query That query need to be called always and we can skip this in most of the cases. Also add the logs around count. This can ...
diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs index 674a19f3ef8..039c99ef348 100644 --- a/crates/api_models/src/payments.rs +++ b/crates/api_models/src/payments.rs @@ -4449,6 +4449,17 @@ pub struct PaymentListFilterConstraints { /// The List of all the card networks to filter p...
2024-10-15T21:20:33Z
## Description - Skip count query if no filters are applied for attempts, in this we don't need to filter attempts as count of active attempt ids will be the total count. - Profile id filter is already getting applied in intents, so removing it from last active attempts. - Add logging around count query. ## Mot...
7e90031c68c7b93db996ee03e11c56b56a87402b
For Tests Lists working is same, same request and response: ``` curl --location 'http://localhost:8080/payments/list' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'x-api-key: dev_VWtyXkyK1Ath1vBNRMM4dqm18J0PVW8SiML4IsKtuzpsR5ojI0FCDBIY0ZRggpFf' \ --header 'Authoriza...
[ "crates/api_models/src/payments.rs", "crates/diesel_models/src/query/payment_attempt.rs", "crates/hyperswitch_domain_models/src/payments/payment_attempt.rs", "crates/router/src/core/payments.rs", "crates/router/src/db/kafka_store.rs", "crates/router/src/routes/metrics.rs", "crates/router/src/routes/paym...
juspay/hyperswitch
juspay__hyperswitch-6340
Bug: Fix(mandates): handle the connector_mandate creation once and only if the payment is charged Earlier we used to store the connector mandate id irrespective of the payments status being charged or not for 3DS flows, now we would handle the connector_mandate_id updation in payment_method once and only if the paym...
diff --git a/crates/common_enums/src/enums.rs b/crates/common_enums/src/enums.rs index 8306deeb258..e36a6d74994 100644 --- a/crates/common_enums/src/enums.rs +++ b/crates/common_enums/src/enums.rs @@ -3356,3 +3356,16 @@ pub enum SurchargeCalculationOverride { /// Calculate surcharge Calculate, } + +/// Conne...
2024-10-15T17:41:53Z
## Description Earlier we used to store the connector mandate id irrespective of the payments status being charged or not for 3DS flows, now we would handle the connector_mandate_id updation in payment_method once and only if the payment has a status as charged. ## Motivation and Context <!-- Why is this cha...
962afbd084458e9afb11a0278a8210edd9226a3d
- Configure a MA and a MCA - Make a 3ds mandate failed payment, it would be populated in the payment_attempt, but not in the payment_method table ``` Create curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'x-feature: ro...
[ "crates/common_enums/src/enums.rs", "crates/diesel_models/src/payment_attempt.rs", "crates/diesel_models/src/schema.rs", "crates/diesel_models/src/schema_v2.rs", "crates/diesel_models/src/user/sample_data.rs", "crates/hyperswitch_domain_models/src/payments/payment_attempt.rs", "crates/router/src/core/pa...
juspay/hyperswitch
juspay__hyperswitch-6336
Bug: Create an id type for API Key ID Currently `key_id` is a String. We need to create an `id_type` for it and migrate all occurrences accordingly
diff --git a/.typos.toml b/.typos.toml index 79c86a39c6b..d2ffb8a5b10 100644 --- a/.typos.toml +++ b/.typos.toml @@ -1,5 +1,8 @@ [default] check-filename = true +extend-ignore-identifiers-re = [ + "UE_[0-9]{3,4}", # Unified error codes +] [default.extend-identifiers] ABD = "ABD" # Aberdeenshire, UK ISO 3166-2...
2024-10-15T12:16:41Z
## Description <!-- Describe your changes in detail --> ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend starting with one first so the PR can focus on the implement...
899ec23565f99daaad821c1ec1482b4c0cc408c5
1a. Create API key ``` curl --location 'http://localhost:8080/api_keys/merchant_1729063721' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: test_admin' \ --data '{ "name": "API Key 1", "description": null, "expiration": "2038-01-19T03:14:08.000Z"...
[ ".typos.toml", "crates/api_models/src/api_keys.rs", "crates/common_utils/src/events.rs", "crates/common_utils/src/id_type.rs", "crates/common_utils/src/id_type/api_key.rs", "crates/diesel_models/src/api_keys.rs", "crates/diesel_models/src/query/api_keys.rs", "crates/router/src/core/api_keys.rs", "cr...
juspay/hyperswitch
juspay__hyperswitch-6321
Bug: [BUG] Various errors in `rust_locker_open_api_spec.yml` ### Bug Description The two identical files [`api-reference/rust_locker_open_api_spec.yml`](https://github.com/juspay/hyperswitch/blob/d06d19fc96e1a74d20e2fe3613f86d541947e0ae/api-reference/rust_locker_open_api_spec.yml) and [`api-reference-v2/rust_locker...
diff --git a/api-reference-v2/rust_locker_open_api_spec.yml b/api-reference-v2/rust_locker_open_api_spec.yml index 729886d9cd0..17a19fec44d 100644 --- a/api-reference-v2/rust_locker_open_api_spec.yml +++ b/api-reference-v2/rust_locker_open_api_spec.yml @@ -2,16 +2,16 @@ openapi: "3.0.2" info: title: Tartarus - Open...
2024-10-15T10:54:46Z
## Description <!-- Describe your changes in detail --> Improved wording in the edit files. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend starting with one first ...
e5710fa084ed5b0a4969a63b14a7f8e3433a3c64
Manually inspected the changed files.
[ "api-reference-v2/rust_locker_open_api_spec.yml" ]
juspay/hyperswitch
juspay__hyperswitch-6318
Bug: docs: Adding Unified error codes to the API - Ref Adding Unified error codes to the API - Ref
2024-10-15T10:13:17Z
## Description <!-- Describe your changes in detail --> Helps closing - #6318 ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend starting with one first so the PR can ...
d06d19fc96e1a74d20e2fe3613f86d541947e0ae
[]
juspay/hyperswitch
juspay__hyperswitch-6314
Bug: [FEAT] add a macro to derive ToEncryptable trait
diff --git a/crates/api_models/src/customers.rs b/crates/api_models/src/customers.rs index eb196a72074..4f6411a42cd 100644 --- a/crates/api_models/src/customers.rs +++ b/crates/api_models/src/customers.rs @@ -1,12 +1,5 @@ -use common_utils::{ - crypto, custom_serde, - encryption::Encryption, - id_type, - pi...
2024-10-14T17:27:37Z
## Description <!-- Describe your changes in detail --> This PR adds a macro to generate ToEncryptable trait on different types ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd r...
98567569c1c61648eebf0ad7a1ab58bba967b427
**THIS CANNOT BE TESTED ON SANDBOX** - Compiler guided. Since this does not change any core flow - Basic test of MerchantCreate and Payments for sanity
[ "crates/api_models/src/customers.rs", "crates/api_models/src/payments.rs", "crates/diesel_models/src/address.rs", "crates/diesel_models/src/events.rs", "crates/hyperswitch_domain_models/src/customer.rs", "crates/hyperswitch_domain_models/src/merchant_connector_account.rs", "crates/hyperswitch_domain_mod...
juspay/hyperswitch
juspay__hyperswitch-6312
Bug: replace underscore by hyphen in Samsung pay session call replace underscore by hyphen in Samsung pay session call as it is passed to samsung pay as `order_number`. And Samsung pay does not accept underscore
diff --git a/crates/router/src/core/payments/flows/session_flow.rs b/crates/router/src/core/payments/flows/session_flow.rs index 1785eee87c5..053c9b8fb0a 100644 --- a/crates/router/src/core/payments/flows/session_flow.rs +++ b/crates/router/src/core/payments/flows/session_flow.rs @@ -567,13 +567,15 @@ fn create_samsung...
2024-10-14T14:59:59Z
## Description <!-- Describe your changes in detail --> ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend starting with one first so the PR can focus on the implement...
df280f2574ac701a5e32b9bcae90c87cab7bc5aa
-> Create a connector with samsung pay enabled -> Create a payment ``` curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key:' \ --data '{ "amount": 100000, "currency": "USD", "capture_method": "automatic"...
[ "crates/router/src/core/payments/flows/session_flow.rs" ]