repo
stringclasses
1 value
instance_id
stringlengths
22
24
problem_statement
stringlengths
30
24.1k
patch
stringlengths
0
1.9M
test_patch
stringclasses
1 value
created_at
stringdate
2022-11-25 05:12:07
2025-06-13 10:24:29
hints_text
stringlengths
0
234k
base_commit
stringlengths
40
40
test_instructions
stringlengths
0
232k
filenames
listlengths
0
300
juspay/hyperswitch
juspay__hyperswitch-3433
Bug: [FEATURE] Update card_details for an existing mandate ### Feature Description There is an existing mandate, with current card details and the Customer for some reason wants to update his card details for that particular mandate. ### Possible Implementation The possible implementation for this would is,...
diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs index 57c66dc5a7b..8c27f498d7a 100644 --- a/crates/api_models/src/payments.rs +++ b/crates/api_models/src/payments.rs @@ -617,10 +617,18 @@ pub enum MandateReferenceId { NetworkMandateId(String), // network_txns_id send by Issuer to...
2024-01-24T18:22:44Z
## Description Update card_details for an existing mandate ### Additional Changes - [x] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application configuration/environment variables <!-- Provide links to the files with corresponding changes. Foll...
3fbffdc242dafe7983c542573b7c6362f99331e6
- Create an MA and MCA(for connectors that support mandate) - Create a mandate payment with payment_type as `setup_mandate` - Now update the new card details with `mandate_data` with `mandate_type` as ``` "mandate_data": { "customer_acceptance" :.. "update_mandate_id":"{{existin...
[ "crates/api_models/src/payments.rs", "crates/data_models/src/mandates.rs", "crates/data_models/src/payments/payment_attempt.rs", "crates/diesel_models/src/enums.rs", "crates/diesel_models/src/mandate.rs", "crates/diesel_models/src/payment_attempt.rs", "crates/diesel_models/src/user/sample_data.rs", "c...
juspay/hyperswitch
juspay__hyperswitch-3483
Bug: adding dispute_id to Kafka events
diff --git a/crates/analytics/docs/clickhouse/cluster_setup/scripts/api_event_logs.sql b/crates/analytics/docs/clickhouse/cluster_setup/scripts/api_event_logs.sql index 0fe194a0e67..ad0fe6d778f 100644 --- a/crates/analytics/docs/clickhouse/cluster_setup/scripts/api_event_logs.sql +++ b/crates/analytics/docs/clickhouse/...
2024-01-24T12:48:32Z
## Description adding dispute id to hyperswitch-api-log-events ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application configuration/environment variables <!-- Provide links to the files with corresponding changes. F...
c9d41e2169decf3e9a26999c37fe81b6a8c0362f
check for dispute_id in topic = ```hyperswitch-api-log-events``` via loki
[ "crates/analytics/docs/clickhouse/cluster_setup/scripts/api_event_logs.sql", "crates/analytics/docs/clickhouse/scripts/api_events.sql", "crates/api_models/src/events.rs", "crates/api_models/src/events/dispute.rs", "crates/common_utils/src/events.rs", "crates/router/src/events/api_logs.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3448
Bug: [FIX] empty list of payment attempt on payments retrieve When you do a `PaymentsRetrieve` with a KV enabled merchant the `PaymentAttempts` list will be empty which is not expected
diff --git a/crates/storage_impl/src/payments/payment_attempt.rs b/crates/storage_impl/src/payments/payment_attempt.rs index f8f752c6bc8..ce2c46bfe1d 100644 --- a/crates/storage_impl/src/payments/payment_attempt.rs +++ b/crates/storage_impl/src/payments/payment_attempt.rs @@ -931,12 +931,23 @@ impl<T: DatabaseStore> Pa...
2024-01-24T10:22:44Z
## Description <!-- Describe your changes in detail --> This fixes payments attempts being empty on `PaymentsRetrieve` ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend ...
3f343d36bff7ce8f73602a2391d205367d5581c7
- Make a payment. - Do `PaymentsRetrieve` with `expand_attempts=true` ```bash curl --location 'http://localhost:8080/payments/pay_QJ9r33h2IiJz15brygDm?expand_attempts=true' \ --header 'Accept: application/json' \ --header 'api-key: dev_6GYF6ws2zde4cDNPtKRKdLbYaY1Ekz3MtH2S9B8Zkb0aZIuXh4NlWICzdw5kTmHY'** ```
[ "crates/storage_impl/src/payments/payment_attempt.rs", "crates/storage_impl/src/redis/kv_store.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3274
Bug: Implement HashiCorp Vault support in the core application
diff --git a/crates/external_services/src/lib.rs b/crates/external_services/src/lib.rs index 9bf4916eec3..f5fc4854086 100644 --- a/crates/external_services/src/lib.rs +++ b/crates/external_services/src/lib.rs @@ -38,3 +38,12 @@ pub mod metrics { #[cfg(feature = "kms")] histogram_metric!(AWS_KMS_ENCRYPT_TIME, ...
2024-01-24T10:17:59Z
…d together ## Description Add compiler error when `kms` and `hashicorp-vault` feature flag are enabled together. <!-- Describe your changes in detail --> ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application conf...
3f343d36bff7ce8f73602a2391d205367d5581c7
[ "crates/external_services/src/lib.rs", "crates/router/src/connector/bankofamerica/transformers.rs", "crates/router/src/connector/cybersource/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3419
Bug: Logging framework - Add a endrequest log line which should be a common line for accumulating all parameters Currently we use the `EndRequest` filter by actix to rely on this, but we need a log line that represents a request uniquely & contains all the key metadata about the request the list of fields that we n...
diff --git a/crates/drainer/src/query.rs b/crates/drainer/src/query.rs index f79291f3eae..a1e04fb6d0f 100644 --- a/crates/drainer/src/query.rs +++ b/crates/drainer/src/query.rs @@ -37,7 +37,7 @@ impl ExecuteQuery for kv::DBOperation { ]; let (result, execution_time) = - common_utils::date...
2024-01-24T06:55:33Z
## Description <!-- Describe your changes in detail --> - Create a request middleware to create a top level span consisting of all the metadata fields - Update the subscriber layer to propogate the metadata fields to the top layer ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR m...
cc7e33a5751d97b44c7aba561c974f529ce8824a
run the application locally all api requests should have the following log line at the end of request - the fields should be populated when available - These log line will be generated even for health & non-existent paths (e.g `/` or `/favicon.ico`) ```json { "message": "[GOLDEN_LOG_LINE - EVENT] REQUES...
[ "crates/drainer/src/query.rs", "crates/router/src/core/payment_methods/cards.rs", "crates/router/src/core/payments/tokenization.rs", "crates/router/src/lib.rs", "crates/router/src/middleware.rs", "crates/router/src/routes/admin.rs", "crates/router/src/routes/mandates.rs", "crates/router/src/routes/pay...
juspay/hyperswitch
juspay__hyperswitch-3428
Bug: Error: IncompleteMessage: connection closed before message completed ### Bug Description Intermittently few api calls gets closed with the following error `Error: IncompleteMessage: connection closed before message completed`. ### Expected Behavior The application should either kept the connection alive or ...
diff --git a/crates/router/src/routes/metrics.rs b/crates/router/src/routes/metrics.rs index 6c3293dba9d..a6d588bd43a 100644 --- a/crates/router/src/routes/metrics.rs +++ b/crates/router/src/routes/metrics.rs @@ -106,6 +106,7 @@ counter_metric!(APPLE_PAY_MANUAL_FLOW_FAILED_PAYMENT, GLOBAL_METER); counter_metric!(APPLE...
2024-01-23T09:45:40Z
## Description Hyper crate has a bug which allows few calls to connect with a dead connections and fails to send request to the server. This bug of hyper can be tracked with below link. `Error: IncompleteMessage: connection closed before message completed` - [Link](https://github.com/hyperium/hyper/issues/2136) ...
3fbffdc242dafe7983c542573b7c6362f99331e6
Running the test case collections
[ "crates/router/src/routes/metrics.rs", "crates/router/src/services/api.rs", "crates/storage_impl/src/errors.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3423
Bug: Audit trail - Add dispute and refund ID to connector calls
diff --git a/crates/analytics/docs/clickhouse/scripts/connector_events.sql b/crates/analytics/docs/clickhouse/scripts/connector_events.sql index 5821cd03556..4a53f9edb0b 100644 --- a/crates/analytics/docs/clickhouse/scripts/connector_events.sql +++ b/crates/analytics/docs/clickhouse/scripts/connector_events.sql @@ -10,...
2024-01-23T08:03:02Z
added refund_id, dispute_id to connector events ## Description <!-- Describe your changes in detail --> ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application configuration/environment variables <!-- Provide links t...
b2afdc35465426bd11428d8d4ac743617a443128
created payment -> created refund for the payment -> checked ConnectorApiLogs for the refund_id
[ "crates/analytics/docs/clickhouse/scripts/connector_events.sql", "crates/analytics/src/connector_events/events.rs", "crates/api_models/src/analytics/connector_events.rs", "crates/router/src/core/fraud_check/flows/checkout_flow.rs", "crates/router/src/core/fraud_check/flows/fulfillment_flow.rs", "crates/ro...
juspay/hyperswitch
juspay__hyperswitch-3432
Bug: feat: Make invite support email array Invite api should support invite of multiple users at a time, instead of single email, it should take an array of emails and sent invitation to each. In case of invitation fails for an email, proper error message should be should be thrown for that email response. Response ...
diff --git a/crates/api_models/src/user.rs b/crates/api_models/src/user.rs index 8de6a3c0b4f..056d1b593dc 100644 --- a/crates/api_models/src/user.rs +++ b/crates/api_models/src/user.rs @@ -89,6 +89,16 @@ pub struct InviteUserResponse { pub password: Option<Secret<String>>, } +#[derive(Debug, serde::Serialize)] ...
2024-01-22T23:16:47Z
## Description The endpoint `/invite_multiple`, gives support to invite more than one user at a time. ### Additional Changes - [x] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application configuration/environment variables <!-- Provide links to the f...
d827c9af29b8516f379e648e00f4ab307ae1a34d
Curl for invite_multiple: ``` curl --location 'http://localhost:8080/user/user/invite_multiple' \ --header 'Authorization: Bearer JWT' \ --data-raw '[ { "email": "admin7@juspay.in", "name": "25", "role_id": "merchant_view_only" }, { "email": "test2@juspay.in", "name": "25", "r...
[ "crates/api_models/src/user.rs", "crates/router/src/core/errors/user.rs", "crates/router/src/core/user.rs", "crates/router/src/routes/app.rs", "crates/router/src/routes/lock_utils.rs", "crates/router/src/routes/user.rs", "crates/router_env/src/logger/types.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3421
Bug: feat: signin and verify email changes for invite flow
diff --git a/crates/api_models/src/events/user.rs b/crates/api_models/src/events/user.rs index 40d082d1cad..04aabc071ae 100644 --- a/crates/api_models/src/events/user.rs +++ b/crates/api_models/src/events/user.rs @@ -12,9 +12,9 @@ use crate::user::{ }, AuthorizeResponse, ChangePasswordRequest, ConnectAccountR...
2024-01-22T13:11:28Z
## Description <!-- Describe your changes in detail --> This PR adds 2 new APIs 1. `/user/v2/signin` 2. `/user/v2/verify_email` These PRs will have checks as mentioned in the below diagram. ```mermaid flowchart TD A["Connect Account"] -- Email --> B{"User Exists"} B -- No --> C["Create new \n Org \n...
a59ac7d5b98f27f5fb34206c20ef9c37a07259a3
```curl curl --location 'http://localhost:8080/user/v2/signin' \ --header 'Content-Type: application/json' \ --data-raw '{ "email": "email", "password": "password" }' ``` or ```curl curl --location 'http://localhost:8080/user/v2/verify_email' \ --header 'Content-Type: application/json' \ --dat...
[ "crates/api_models/src/events/user.rs", "crates/api_models/src/user.rs", "crates/router/src/core/errors/user.rs", "crates/router/src/core/user.rs", "crates/router/src/routes/app.rs", "crates/router/src/routes/lock_utils.rs", "crates/router/src/routes/user.rs", "crates/router/src/routes/user_role.rs", ...
juspay/hyperswitch
juspay__hyperswitch-3418
Bug: [FEATURE] Add original authorized amount in router data ### Feature Description Add original authorized amount in router data for recurring mandate payments. This field is required in Cybersource for Discover cards recurring mandate payments. ### Possible Implementation Add fields `original_payment_authorize...
diff --git a/crates/router/src/connector/bankofamerica/transformers.rs b/crates/router/src/connector/bankofamerica/transformers.rs index 72e3de0bf77..db96ff62f6c 100644 --- a/crates/router/src/connector/bankofamerica/transformers.rs +++ b/crates/router/src/connector/bankofamerica/transformers.rs @@ -442,7 +442,7 @@ pub...
2024-01-22T09:35:21Z
## Description <!-- Describe your changes in detail --> Add original authorized amount in router data for recurring mandate payments. ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application configuration/environment variable...
629d546aa7c774e86d609abec3b3ab5cf0d100a7
Testing can be done by creating a recurring mandate payment in cybersource and using the following discover cards: 6011111111111117, 6011000991300009 Curls: - Payment Intent Create: ``` curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: applicati...
[ "crates/router/src/connector/bankofamerica/transformers.rs", "crates/router/src/connector/cybersource/transformers.rs", "crates/router/src/connector/utils.rs", "crates/router/src/core/payments.rs", "crates/router/src/core/payments/helpers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3407
Bug: Add API doc in README.md for easy access This will help the users to play through the hyperswitch product
diff --git a/README.md b/README.md index dfa77ebe066..0f5e924589f 100644 --- a/README.md +++ b/README.md @@ -12,13 +12,14 @@ The single API to access payment ecosystems across 130+ countries</div> <a href="#%EF%B8%8F-quick-start-guide">Quick Start Guide</a> • <a href="https://github.com/juspay/hyperswitch/blob/ma...
2024-01-19T10:52:35Z
## Description Add Api Documentation link to the README.md ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application configuration/environment variables <!-- Provide links to the files with corresponding changes. Follo...
ec16ed0f82f258c5699d54a386f67aff06c0d144
[ "README.md" ]
juspay/hyperswitch
juspay__hyperswitch-3403
Bug: [BUG] [CRYPTOPAY] PSYNC Call Failing ### Bug Description The PSYNC call is failing for connector cryptopay which is resulting in payments getting stuck in the `requires_customer_action` state. ### Expected Behavior The PSYNC should work for connector cryptopay and payments should go into `succeeded`. ...
diff --git a/crates/router/src/connector/cryptopay.rs b/crates/router/src/connector/cryptopay.rs index 95ea7ef0c7a..8727461ba34 100644 --- a/crates/router/src/connector/cryptopay.rs +++ b/crates/router/src/connector/cryptopay.rs @@ -69,14 +69,24 @@ where req: &types::RouterData<Flow, Request, Response>, ...
2024-01-19T09:27:21Z
## Description <!-- Describe your changes in detail --> The encoding for empty string in header generation for PSYNC call is removed. This encoding was previously causing the PSYNC call to fail. ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] Th...
1c04ac751240f5c931df0f282af1e0ad745e9509
- Create a crypto_currency payment for connector cryptopay. `curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: API_KEY_HERE' \ --data-raw '{ "amount": 10, "currency": "INR", "confirm": true, ...
[ "crates/router/src/connector/cryptopay.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3395
Bug: Clickhouse - split the ingestion & query tables in separate databases for better access control In order to support our earlier use case where we wanna reduce user confusion etc for tables on grafana, we've decided to restrict grafana (and application) access to query tables only. in order to do this we've de...
diff --git a/crates/analytics/src/clickhouse.rs b/crates/analytics/src/clickhouse.rs index f81c29c801c..00ae3b6e310 100644 --- a/crates/analytics/src/clickhouse.rs +++ b/crates/analytics/src/clickhouse.rs @@ -354,11 +354,11 @@ impl ToSql<ClickhouseClient> for PrimitiveDateTime { impl ToSql<ClickhouseClient> for Analyt...
2024-01-18T19:40:01Z
## Description updated analytics tables of ckh source to new tables ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application configuration/environment variables <!-- Provide links to the files with corresponding changes....
cc7e33a5751d97b44c7aba561c974f529ce8824a
- check the analytics tab in dashboard
[ "crates/analytics/src/clickhouse.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3269
Bug: Deep health check for Hyperswitch Drainer Components to be verified in this check - [x] RDS (PostgreSQL) - Connection to Database - State of Migration - [x] ElastiCache (Redis) - Connection to Redis
diff --git a/Cargo.lock b/Cargo.lock index f0334ce9cfc..49ccfc2c645 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2331,6 +2331,7 @@ checksum = "1aaf95b3e5c8f23aa320147307562d361db0ae0d51242340f558153b4eb2439b" name = "drainer" version = "0.1.0" dependencies = [ + "actix-web", "async-bb8-diesel", "async-trait", ...
2024-01-18T18:14:31Z
## Description <!-- Describe your changes in detail --> This PR adds support for performing a deeper health check of the drainer which includes: Database connection check with read, write and delete queries (Added support for database transaction too) Redis connection check with set, get and delete key (Set key ...
892b04f805c219e2cf7cbe5736aef19909e986f7
1. `/health` ![image](https://github.com/juspay/hyperswitch/assets/70657455/d7784ea7-7d21-426f-ba65-69a0f559356e) 2. `/health/deep_check` ![image](https://github.com/juspay/hyperswitch/assets/70657455/aada988f-0058-48af-8654-1070bd810a29) **THIS CANNOT BE TESTED ON SANBOX AS THE ENDPOINT IS NOT EXPOSED**
[ "Cargo.lock", "crates/api_models/src/health_check.rs", "crates/drainer/Cargo.toml", "crates/drainer/src/errors.rs", "crates/drainer/src/health_check.rs", "crates/drainer/src/lib.rs", "crates/drainer/src/main.rs", "crates/drainer/src/services.rs", "crates/drainer/src/settings.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3394
Bug: bug(EVENT_VIEWER): connector events is missing a status code field The status code is being always registered as `0` in clickhouse. ![Image](https://github.com/juspay/hyperswitch/assets/21202349/6c45e608-d976-453d-9594-0312c59abbb9) It seems that we aren't setting the status code at all from the application.....
diff --git a/crates/router/src/events/connector_api_logs.rs b/crates/router/src/events/connector_api_logs.rs index 871a7af0d77..45c05a3077f 100644 --- a/crates/router/src/events/connector_api_logs.rs +++ b/crates/router/src/events/connector_api_logs.rs @@ -18,6 +18,7 @@ pub struct ConnectorEvent { created_at: i128...
2024-01-18T17:37:58Z
## Description adding status code to connector Kafka events ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application configuration/environment variables <!-- Provide links to the files with corresponding changes. Foll...
0e4e18441d024b7d669b27d6f8a2feb3eccedb2a
f do payment confirm call and then check for the status_code in log in loki where ```topic=hyperswitch-outgoing-connector-events```
[ "crates/router/src/events/connector_api_logs.rs", "crates/router/src/services/api.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3427
Bug: [BUG] Add payout features for euclid_wasm crate ### Bug Description `euclid_wasm` is a dependency of hyperswitch dashboard which includes list of connectors, PMs, and other related structs and enums. This also includes payout related stuff which is enabled under `payouts` feature. However, the feature `payouts...
diff --git a/crates/euclid_wasm/Cargo.toml b/crates/euclid_wasm/Cargo.toml index d9f5330a1b8..13296bcde62 100644 --- a/crates/euclid_wasm/Cargo.toml +++ b/crates/euclid_wasm/Cargo.toml @@ -10,7 +10,7 @@ rust-version.workspace = true crate-type = ["cdylib"] [features] -default = ["connector_choice_bcompat", "connect...
2024-01-18T13:59:39Z
## Description <!-- Describe your changes in detail --> ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application configuration/environment variables <!-- Provide links to the files with corresponding changes. Followin...
f1fd0b101791f20980e21e8fd8bf10fac3179209
<img width="1675" alt="image" src="https://github.com/juspay/hyperswitch/assets/120017870/7d08729a-a8b0-46b7-856d-c5587c795649">
[ "crates/euclid_wasm/Cargo.toml" ]
juspay/hyperswitch
juspay__hyperswitch-3386
Bug: feat: get user role from token
diff --git a/crates/api_models/src/user_role.rs b/crates/api_models/src/user_role.rs index 72fca2b2f08..b057f8ca8bc 100644 --- a/crates/api_models/src/user_role.rs +++ b/crates/api_models/src/user_role.rs @@ -43,6 +43,7 @@ pub enum Permission { SurchargeDecisionManagerRead, UsersRead, UsersWrite, + Me...
2024-01-18T10:53:30Z
## Description Added API to get list of permission user has. <!-- Describe your changes in detail --> ### Additional Changes - [X] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application configuration/environment variables <!-- Provide links to th...
059e86607dc271c25bb3d23f5adfc7d5f21f62fb
``` curl --location --request GET '<URL>/user/role' \ --header 'Authorization: Bearer <JWT>' ``` Above API should give an array of permission. All roles and their permission can be found [here](https://github.com/juspay/hyperswitch/blob/main/crates/router/src/services/authorization/predefined_permissions.rs#L28)...
[ "crates/api_models/src/user_role.rs", "crates/router/src/core/user_role.rs", "crates/router/src/routes/app.rs", "crates/router/src/routes/lock_utils.rs", "crates/router/src/routes/user_role.rs", "crates/router/src/services/authorization/info.rs", "crates/router/src/services/authorization/permissions.rs"...
juspay/hyperswitch
juspay__hyperswitch-3379
Bug: [FEATURE] Pass Customer name to connectors ### Feature Description I need customer_name to be passed to stripe. This is required for evaluating the risk associated with a payment. ### Possible Implementation Pass the `name` field ( `customer.name` ) when creating a customer at the connector. ### Have you sp...
diff --git a/crates/router/src/connector/stax/transformers.rs b/crates/router/src/connector/stax/transformers.rs index 01ae751f748..596ea1145ec 100644 --- a/crates/router/src/connector/stax/transformers.rs +++ b/crates/router/src/connector/stax/transformers.rs @@ -147,7 +147,7 @@ pub struct StaxCustomerRequest { #...
2024-01-18T08:58:20Z
## Description <!-- Describe your changes in detail --> This PR adds the support for sending `customer_name` to the connectors when creating the customer at the connectors end. ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies ap...
6c46e9c19b304bb11f304e60c46e8abf67accf6d
- Create a payment for stripe connector with customer id, email and customer name. ```bash curl --location 'https://sandbox.hyperswitch.io/payments' \ --header 'Content-Type: application/json' \ --header 'api-key: dev_16svHskpygTeiHAoy6RsRf3YxKlSV67FhT5P49UvfA73P1sTG1Tm6VG58a2B79Il' \ --data-raw '{ "amount"...
[ "crates/router/src/connector/stax/transformers.rs", "crates/router/src/connector/stripe/transformers.rs", "crates/router/src/core/payments/flows/authorize_flow.rs", "crates/router/src/core/payments/transformers.rs", "crates/router/src/types.rs", "crates/router/src/types/api/verify_connector.rs", "crates...
juspay/hyperswitch
juspay__hyperswitch-3375
Bug: [CI] Add workflow to ensure a pull request contains at least one linked issue ### Description Add a CI workflow to ensure that each pull request contains at least one linked issue. We wish to introduce this requirement for improved project tracking. The workflow should do nothing else: just succeed/fail the ...
2024-01-17T20:12:40Z
## Description <!-- Describe your changes in detail --> This PR adds a new pull request CI check to ensure that all pull requests have at least one linked issue. However, GitHub does not send any webhooks when a pull request is linked with an issue, so the check does not get triggered automatically when an issue...
eb2a61d8597995838f21b8233653c691118b2191
Temporarily modified the trigger to be `pull_request` instead of `pull_request_target` to test the workflow. 1. The check fails if the PR does not contain any linked issues. ![Screenshot of failed check due to absence of linked issues](https://github.com/juspay/hyperswitch/assets/22217505/a8f5a7ac-d96f-4512-...
[]
juspay/hyperswitch
juspay__hyperswitch-3390
Bug: feat: delete / deactivate user Add endpoint to support a delete user. A user who is part of the organisation can be deleted by users with permission `UsersWrite`, provided user to be deleted should not be the org admin or internal user.
diff --git a/crates/api_models/src/events/user_role.rs b/crates/api_models/src/events/user_role.rs index c8d8fd96a7a..3ec30d6bd97 100644 --- a/crates/api_models/src/events/user_role.rs +++ b/crates/api_models/src/events/user_role.rs @@ -1,8 +1,8 @@ use common_utils::events::{ApiEventMetric, ApiEventsType}; use crat...
2024-01-17T13:43:09Z
## Description Add add new endpoint `/user/user/delete` that deletes the user present in the merchant account Here we have two scenarios - When user is related to more than one merchant accounts: Delete the user role for that particular merchant account. User will be present in other accounts. - When user is par...
cc7e33a5751d97b44c7aba561c974f529ce8824a
- Singup/Singin Use the following curl to invite users: ``` curl --location 'http://localhost:8080/user/user/invite' \ --header 'Authorization: Bearer JWT' \ --header 'Content-Type: application/json' \ --data-raw '{ "email": "user2@juspay.in", "name": "user2", "role_id": "merchant_admin" } ``` ...
[ "crates/api_models/src/events/user_role.rs", "crates/api_models/src/user_role.rs", "crates/diesel_models/src/query/dashboard_metadata.rs", "crates/diesel_models/src/query/user_role.rs", "crates/router/src/core/errors/user.rs", "crates/router/src/core/user_role.rs", "crates/router/src/db/dashboard_metada...
juspay/hyperswitch
juspay__hyperswitch-3372
Bug: feat: update user details api
diff --git a/crates/api_models/src/events/user.rs b/crates/api_models/src/events/user.rs index c0743c8b8fc..40d082d1cad 100644 --- a/crates/api_models/src/events/user.rs +++ b/crates/api_models/src/events/user.rs @@ -13,7 +13,8 @@ use crate::user::{ AuthorizeResponse, ChangePasswordRequest, ConnectAccountRequest, ...
2024-01-17T12:44:24Z
## Description <!-- Describe your changes in detail --> - This PR adds a new column in users table called `preferred_merchant_id`. `preferred_merchant_id` will be used at the time of signin to directly use that `merchant_id` when user has access to multiple merchant accounts. - This PR adds a new API which enables ...
eb2a61d8597995838f21b8233653c691118b2191
Postman. ```curl curl --location 'http://localhost:8080/user/update' \ --header 'Content-Type: application/json' \ --header 'Authorization: Bearer JWT' \ --data '{ "name": "user name", // Optional "preferred_merchant_id": "merchant_id" // Optional, user should have access to this merchant_id }' ``` ...
[ "crates/api_models/src/events/user.rs", "crates/api_models/src/user.rs", "crates/diesel_models/src/query/user_role.rs", "crates/diesel_models/src/schema.rs", "crates/diesel_models/src/user.rs", "crates/router/src/core/user.rs", "crates/router/src/db/kafka_store.rs", "crates/router/src/db/user.rs", "...
juspay/hyperswitch
juspay__hyperswitch-3699
Bug: [FIX] add unresponsive timeout for redis This will check if a connection is unresponsive, if it is it will try to re-construct the connection
diff --git a/Cargo.lock b/Cargo.lock index 2c9293c1701..b466a161097 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2610,9 +2610,9 @@ dependencies = [ [[package]] name = "fred" -version = "7.1.0" +version = "7.1.2" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "9282e65613822eea90c99872c...
2024-01-17T08:43:10Z
## Description <!-- Describe your changes in detail --> Enable `check-unresponsive` in fred and update the version to `7.1.2` ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd rec...
15b367eb792448fb3f3312484ab13dd8241d4a14
- Sanity Test with Payments and Refunds. **This change cannot be tested since we cannot reproduce the situation in sandbox**
[ "Cargo.lock", "config/config.example.toml", "config/deployments/env_specific.toml", "config/development.toml", "config/docker_compose.toml", "crates/redis_interface/Cargo.toml", "crates/redis_interface/src/lib.rs", "crates/redis_interface/src/types.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3366
Bug: feat(invite): make accept invite api
diff --git a/crates/api_models/src/events/user_role.rs b/crates/api_models/src/events/user_role.rs index aa8d13dab6d..c8d8fd96a7a 100644 --- a/crates/api_models/src/events/user_role.rs +++ b/crates/api_models/src/events/user_role.rs @@ -1,8 +1,8 @@ use common_utils::events::{ApiEventMetric, ApiEventsType}; use crat...
2024-01-17T07:14:02Z
## Description <!-- Describe your changes in detail --> This PR will add a new API for accepting invitation and also a new JWT auth type which has only `user_id`. ### Additional Changes - [x] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application confi...
1c04ac751240f5c931df0f282af1e0ad745e9509
```curl curl --location 'http://localhost:8080/user/user/invite/accept' \ --header 'Content-Type: application/json' \ --header 'Authorization: Bearer JWT' \ --data '{ "merchant_ids": [ "merchant_id1", "merchant_id2", "merchant_id3" ], "need_dashboard_entry_response": t...
[ "crates/api_models/src/events/user_role.rs", "crates/api_models/src/user_role.rs", "crates/router/src/core/user.rs", "crates/router/src/core/user_role.rs", "crates/router/src/routes/app.rs", "crates/router/src/routes/lock_utils.rs", "crates/router/src/routes/user_role.rs", "crates/router/src/services/...
juspay/hyperswitch
juspay__hyperswitch-3497
Bug: [FIX] add a metric while pushing data to drainer stream
diff --git a/crates/storage_impl/src/lib.rs b/crates/storage_impl/src/lib.rs index 7e2c7f2fc3c..d31f05b4979 100644 --- a/crates/storage_impl/src/lib.rs +++ b/crates/storage_impl/src/lib.rs @@ -225,6 +225,11 @@ impl<T: DatabaseStore> KVRouterStore<T> { .change_context(RedisError::JsonSerializationFa...
2024-01-17T05:25:30Z
## Description <!-- Describe your changes in detail --> Add a metric to indicate data was pushed to drainer ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend starting wi...
398c5ed51e0547504c3dfbd1d7c23568337e7d1c
- Do a transaction through KV merchant - Check `KV_PUSHED_TO_DRAINER` on grafana keeping data source as `vm-single` ![Screenshot 2024-01-30 at 4 10 56 PM](https://github.com/juspay/hyperswitch/assets/43412619/5c7dbfdc-253f-4895-985a-5bc674a56de4)
[ "crates/storage_impl/src/lib.rs", "crates/storage_impl/src/metrics.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3362
Bug: bug: sample data generation with profile id When trying to generate sample data for users with multiple business profiles, we are getting 500 if the profile id is not passed in the payload.
diff --git a/crates/router/src/utils/user/sample_data.rs b/crates/router/src/utils/user/sample_data.rs index dcf635595e0..3fa2a10629e 100644 --- a/crates/router/src/utils/user/sample_data.rs +++ b/crates/router/src/utils/user/sample_data.rs @@ -52,7 +52,7 @@ pub async fn generate_sample_data( let business_label_...
2024-01-16T10:08:50Z
## Description Currently for user with multiple business profiles. We are getting 500 if the profile id is not passed in the payload. Therefore, need to fetch the profile_id (the first one) from list of business profiles, for the sample data generation. ### Additional Changes - [ ] This PR modifies the API con...
5ad3f8939afafce3eec39704dcaa92270b384dcd
Singup ``` curl --location 'http://localhost:8080/user/signup' \ --header 'Content-Type: application/json' \ --header 'Cookie: token=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1c2VyX2lkIjoiMWZjNzgyOTUtM2JiMy00OGJjLThlZDgtNzFjMzVjMzMxYWU2IiwibWVyY2hhbnRfaWQiOiJtZXJjaGFudF8xNjk3NzE2ODcwIiwicm9sZV9pZCI6Im1lcmNoYW50X2FkbW...
[ "crates/router/src/utils/user/sample_data.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3355
Bug: [REFACTOR]: [Cybersource] Recurring Mandates Payments Flow ### Feature Description In recurring subsequent mandate payment (MIT) the payment was getting processed with card fetched from locker, it should being processed with `connector_mandate_id` ### Possible Implementation Implement a check over `connecto...
diff --git a/crates/router/src/connector/cybersource.rs b/crates/router/src/connector/cybersource.rs index b300e97b44a..ac2d16c9610 100644 --- a/crates/router/src/connector/cybersource.rs +++ b/crates/router/src/connector/cybersource.rs @@ -785,7 +785,10 @@ impl ConnectorIntegration<api::Authorize, types::PaymentsAutho...
2024-01-16T05:35:03Z
## Description <!-- Describe your changes in detail --> In recurring subsequent mandate payment (MIT) the payment was getting processed with card fetched from locker, now it is being processed with `connector_mandate_id` ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the...
398c5ed51e0547504c3dfbd1d7c23568337e7d1c
- Create a CIT with zero and non-zero amount <img width="1296" alt="Screenshot 2024-01-16 at 11 06 18 AM" src="https://github.com/juspay/hyperswitch/assets/55536657/e746049b-257e-4808-9587-583b7b2c78ef"> <img width="1285" alt="Screenshot 2024-01-16 at 11 06 50 AM" src="https://github.com/juspay/hyperswitch/assets...
[ "crates/router/src/connector/cybersource.rs", "crates/router/src/connector/cybersource/transformers.rs", "crates/router/src/services/api.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3387
Bug: [REFACTOR] Add additional field in MandateResponse ### Feature Description Add additional field, `payment_method_response` in MandateResponse ### Possible Implementation Add additional field, `payment_method_response` in MandateResponse ### Have you spent some time checking if this feature request has been ...
diff --git a/config/config.example.toml b/config/config.example.toml index d4e11964192..cf25ef195a2 100644 --- a/config/config.example.toml +++ b/config/config.example.toml @@ -131,6 +131,7 @@ host_rs = "" # Rust Locker host mock_locker = true # Emulate a locker locally using Postgres ba...
2024-01-15T11:31:45Z
## Description Add locker config to enable or disable locker , so that if the locker is enabled we can store the card_details in the locker else if the config is disabled we don't Also this PR involvesaddition in the `MandateResponse`. ### Additional Changes - [ ] This PR modifies the API contract - [ ] Th...
2f693ad1fd857280ef30c6cc0297fb926f0e79e8
- Create an MA & MCA - Disable the `locker_enabled` config > Create a Mandate payment , the details will not be stored in Locker and payment will be successful > List PaymentMethods for a Customer won't have any details as the card was never stored > List the Mandates would have mandate details ![Screens...
[ "config/config.example.toml", "config/development.toml", "config/docker_compose.toml", "crates/api_models/src/mandates.rs", "crates/api_models/src/payment_methods.rs", "crates/router/src/configs/defaults.rs", "crates/router/src/configs/settings.rs", "crates/router/src/core/locker_migration.rs", "cra...
juspay/hyperswitch
juspay__hyperswitch-3361
Bug: [REFACTOR] Add config to enable and disable locker ### Feature Description Add config to disable or enable locker. If the config is set as false then we don't store the card_details in locker else we store the details in the locker. ### Possible Implementation While a payment gets created, make a decision ...
diff --git a/config/config.example.toml b/config/config.example.toml index d4e11964192..cf25ef195a2 100644 --- a/config/config.example.toml +++ b/config/config.example.toml @@ -131,6 +131,7 @@ host_rs = "" # Rust Locker host mock_locker = true # Emulate a locker locally using Postgres ba...
2024-01-15T11:31:45Z
## Description Add locker config to enable or disable locker , so that if the locker is enabled we can store the card_details in the locker else if the config is disabled we don't Also this PR involvesaddition in the `MandateResponse`. ### Additional Changes - [ ] This PR modifies the API contract - [ ] Th...
2f693ad1fd857280ef30c6cc0297fb926f0e79e8
- Create an MA & MCA - Disable the `locker_enabled` config > Create a Mandate payment , the details will not be stored in Locker and payment will be successful > List PaymentMethods for a Customer won't have any details as the card was never stored > List the Mandates would have mandate details ![Screens...
[ "config/config.example.toml", "config/development.toml", "config/docker_compose.toml", "crates/api_models/src/mandates.rs", "crates/api_models/src/payment_methods.rs", "crates/router/src/configs/defaults.rs", "crates/router/src/configs/settings.rs", "crates/router/src/core/locker_migration.rs", "cra...
juspay/hyperswitch
juspay__hyperswitch-3347
Bug: Refactor `s3` to extend other storage logics and provide a runtime flag for the same Provide a runtime flag to handle file storage operations
diff --git a/Cargo.lock b/Cargo.lock index f920b1ea9c5..b86facad816 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2481,6 +2481,7 @@ dependencies = [ "async-trait", "aws-config", "aws-sdk-kms", + "aws-sdk-s3", "aws-sdk-sesv2", "aws-sdk-sts", "aws-smithy-client", @@ -2726,9 +2727,9 @@ dependencies = [ [[pac...
2024-01-14T14:27:35Z
## Description <!-- Describe your changes in detail --> This PR includes refactoring for: * Enabling easy extension of other file storage schemes. * Providing a runtime flag for the file storage feature. * Restrict the file storage objects(structs, methods) visibility wherever possible. ### Additional Changes...
3fbffdc242dafe7983c542573b7c6362f99331e6
* Create a dispute and get the `dispute_id` ### File System 1. File uploading ``` curl --location --request POST 'localhost:8080/files' \ --header 'Accept: application/json' \ --header 'api-key: dev_vbE0ODzAkDHFkW2FFQZEAU4VeSk5ij4kWOZl2JXqRtYf50rVqxefvSofYCqre89Q' \ --header 'Content-Type: multipart/for...
[ "Cargo.lock", "config/config.example.toml", "config/development.toml", "config/docker_compose.toml", "crates/external_services/Cargo.toml", "crates/external_services/src/file_storage.rs", "crates/external_services/src/file_storage/aws_s3.rs", "crates/external_services/src/file_storage/file_system.rs",...
juspay/hyperswitch
juspay__hyperswitch-3338
Bug: [REFACTOR] Enable runtime flag for `s3` feature ### Feature Description Tracking issue for refactoring `s3` to include compile time + runtime time flag Current implementation - We are building 2 docker images, one image contains all the release features including `kms`, `s3`, etc and other without these ...
diff --git a/Cargo.lock b/Cargo.lock index f920b1ea9c5..b86facad816 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2481,6 +2481,7 @@ dependencies = [ "async-trait", "aws-config", "aws-sdk-kms", + "aws-sdk-s3", "aws-sdk-sesv2", "aws-sdk-sts", "aws-smithy-client", @@ -2726,9 +2727,9 @@ dependencies = [ [[pac...
2024-01-14T14:27:35Z
## Description <!-- Describe your changes in detail --> This PR includes refactoring for: * Enabling easy extension of other file storage schemes. * Providing a runtime flag for the file storage feature. * Restrict the file storage objects(structs, methods) visibility wherever possible. ### Additional Changes...
3fbffdc242dafe7983c542573b7c6362f99331e6
* Create a dispute and get the `dispute_id` ### File System 1. File uploading ``` curl --location --request POST 'localhost:8080/files' \ --header 'Accept: application/json' \ --header 'api-key: dev_vbE0ODzAkDHFkW2FFQZEAU4VeSk5ij4kWOZl2JXqRtYf50rVqxefvSofYCqre89Q' \ --header 'Content-Type: multipart/for...
[ "Cargo.lock", "config/config.example.toml", "config/development.toml", "config/docker_compose.toml", "crates/external_services/Cargo.toml", "crates/external_services/src/file_storage.rs", "crates/external_services/src/file_storage/aws_s3.rs", "crates/external_services/src/file_storage/file_system.rs",...
juspay/hyperswitch
juspay__hyperswitch-3359
Bug: [FEATURE] Recon APIs ### Feature Description Add recon related APIs in HyperSwitch for managing recon module for the consumers. Recon dashboard is a separate application hosted at https://sandbox.hyperswitch.io/recon-dashboard/ Recon module in HyperSwitch should be able to perform below tasks - Toggle reco...
diff --git a/crates/api_models/Cargo.toml b/crates/api_models/Cargo.toml index 69980361500..45702a4ecb0 100644 --- a/crates/api_models/Cargo.toml +++ b/crates/api_models/Cargo.toml @@ -8,7 +8,7 @@ readme = "README.md" license.workspace = true [features] -default = ["payouts", "frm"] +default = ["payouts", "frm", "r...
2024-01-12T15:28:13Z
## Description This PR adds recon APIs for activating recon as a feature on HyperSwitch dashboard and generating tokens for Recon dashboard. Issue - #3359 ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application configurat...
58cc8d6109ce49d385b06c762ab3f6670f5094eb
Tested below endpoints for Recon service using the attached postman collection. Postman collection - https://galactic-capsule-229427.postman.co/workspace/My-Workspace~2b563e0d-bad3-420f-8c0b-0fd5b278a4fe/collection/9906252-4ef01bc4-53d4-40c0-a3e7-c84c8e32f105?action=share&creator=9906252 **Endpoints** 1. `/recon/u...
[ "crates/api_models/Cargo.toml", "crates/api_models/src/events.rs", "crates/api_models/src/events/recon.rs", "crates/api_models/src/events/user.rs", "crates/api_models/src/lib.rs", "crates/api_models/src/recon.rs", "crates/api_models/src/user.rs", "crates/common_utils/src/events.rs", "crates/router/C...
juspay/hyperswitch
juspay__hyperswitch-3342
Bug: [FEATURE] [Bankofamerica] Add 3DS flow for cards ### Feature Description Add 3DS flow for cards for connector BankOfAmerica. ### Possible Implementation Add 3DS flow for cards for connector BankOfAmerica. ### Have you spent some time checking if this feature request has been raised before? - [X] I checked ...
diff --git a/config/config.example.toml b/config/config.example.toml index e20f9c1b65d..d4e11964192 100644 --- a/config/config.example.toml +++ b/config/config.example.toml @@ -351,6 +351,7 @@ stripe = { payment_method = "bank_transfer" } nuvei = { payment_method = "card" } shift4 = { payment_method = "card" } blues...
2024-01-12T11:58:44Z
## Description <!-- Describe your changes in detail --> Implement 3DS flow for cards ``` Legend: UB: User Browser M: Merchant HS: Hyperswitch CS: Bankofamerica/Cybersource Connector ``` ![3DS FLOW DIAGRAM](https://github.com/juspay/hyperswitch/assets/41580413/9f2e0e71-65df-4310-84cf-1419090a680f) #...
8678f8d1448b5ce430931bfbbc269ef979d9eea7
### QA Testing ![Screenshot 2024-01-12 at 5 35 04 PM](https://github.com/juspay/hyperswitch/assets/41580413/bdab526f-736b-44c1-8904-3ae51e9781f6) ![Screenshot 2024-01-12 at 5 33 54 PM](https://github.com/juspay/hyperswitch/assets/41580413/55ca3a43-b8de-43f8-b463-3555a8e79e21) ![Screenshot 2024-01-12 at 5 33 10...
[ "config/config.example.toml", "config/development.toml", "config/docker_compose.toml", "crates/router/src/connector/bankofamerica.rs", "crates/router/src/connector/bankofamerica/transformers.rs", "crates/router/src/connector/cybersource.rs", "crates/router/src/core/payments.rs", "crates/router/src/cor...
juspay/hyperswitch
juspay__hyperswitch-3340
Bug: Rename `s3` feature flag to `aws_s3` Rename `s3` feature flag to `aws_s3`. This change is required so that current storage scheme becomes distinguishable, especially if in future new storage implementations like a AWS S3 alternative is integrated.
diff --git a/crates/router/Cargo.toml b/crates/router/Cargo.toml index 8897fdac2c2..88272033fb0 100644 --- a/crates/router/Cargo.toml +++ b/crates/router/Cargo.toml @@ -10,12 +10,12 @@ license.workspace = true [features] default = ["kv_store", "stripe", "oltp", "olap", "backwards_compatibility", "accounts_cache", "...
2024-01-12T11:03:29Z
## Description <!-- Describe your changes in detail --> This PR renames s3 feature flag to aws_s3 so that current storage scheme is distinguishable, especially if in future new storage implementations like a AWS S3 alternative is integrated. ### Additional Changes - [ ] This PR modifies the API contract - [ ]...
eb2a61d8597995838f21b8233653c691118b2191
Just a rename of feature flag, so basic sanity testing should work
[ "crates/router/Cargo.toml", "crates/router/src/configs/settings.rs", "crates/router/src/configs/validations.rs", "crates/router/src/core/files.rs", "crates/router/src/core/files/helpers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3339
Bug: Event Viewer - Add payment_id to PaymentsList API call `PaymentsList` Api call currently does not extract the payment id from payload. Since this API is associated with a payment, we need to add a `payment_id` field to this API call as well
diff --git a/crates/api_models/src/events.rs b/crates/api_models/src/events.rs index 26a9d222d6b..3eb19fcc3d8 100644 --- a/crates/api_models/src/events.rs +++ b/crates/api_models/src/events.rs @@ -37,7 +37,6 @@ impl ApiEventMetric for TimeRange {} impl_misc_api_event_type!( PaymentMethodId, PaymentsSessionRe...
2024-01-12T08:22:57Z
## Description <!-- Describe your changes in detail --> - Add payment_id field in payment methods list ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application configuration/environment variables <!-- Provide links to the...
d533c98b5107fb6876c11b183eb9bc382a77a2f1
1. create a payment with confirm false 2. call `List payment methods for a Merchant` API via postman
[ "crates/api_models/src/events.rs", "crates/api_models/src/events/payment.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3441
Bug: [DOCS] Add Api-Refrence for Blocklist This PR adds the api contracts(utoipa) for all blocklist apis.
diff --git a/crates/api_models/src/blocklist.rs b/crates/api_models/src/blocklist.rs index fc838eed5ce..888b9106ccc 100644 --- a/crates/api_models/src/blocklist.rs +++ b/crates/api_models/src/blocklist.rs @@ -1,7 +1,8 @@ use common_enums::enums; use common_utils::events::ApiEventMetric; +use utoipa::ToSchema; -#[de...
2024-01-11T19:39:29Z
## Description <!-- Describe your changes in detail --> This PR adds the api contracts(utoipa) for blocklist apis. ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application configuration/environment variables <!-- Provide ...
57f2cff75e58b0a7811492a1fdb636f59dcefbd0
The test cases can be found out here in this [PR](https://github.com/juspay/hyperswitch/pull/3056).
[ "crates/api_models/src/blocklist.rs", "crates/router/src/db/blocklist.rs", "crates/router/src/db/blocklist_fingerprint.rs", "crates/router/src/db/blocklist_lookup.rs", "crates/router/src/openapi.rs", "crates/router/src/routes/blocklist.rs", "openapi/openapi_spec.json" ]
juspay/hyperswitch
juspay__hyperswitch-3327
Bug: feat: Add user flow for non-email usecase If a user (merchant) does not have email service enabled, then the current invite user flow does not work. ## Feature Requirement For a merchant with no email service enabled (feature flag), have a add user flow. In this flow, the merchant is asked for a email id and ...
diff --git a/crates/api_models/src/user.rs b/crates/api_models/src/user.rs index 07909a35782..f5af31c8e7f 100644 --- a/crates/api_models/src/user.rs +++ b/crates/api_models/src/user.rs @@ -86,6 +86,7 @@ pub struct InviteUserRequest { #[derive(Debug, serde::Serialize)] pub struct InviteUserResponse { pub is_email...
2024-01-11T10:13:42Z
## Description Enabled invite api to work without "email" feature flag <!-- Describe your changes in detail --> ### Additional Changes - [X] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application configuration/environment variables <!-- Provide l...
9eaebe8db3d83105ef1e8fc784241e1fb795dd22
``` curl --location --request POST '<URL>/user/user/invite' \ --header 'Authorization: Bearer <JWT>' \ --header 'Content-Type: application/json' \ --data-raw '{ "email": "email", "name": "name", "role_id": "valid_role_id" }' ``` Expected Response: with email flag ``` { "is_email_sent": true, ...
[ "crates/api_models/src/user.rs", "crates/router/src/core/user.rs", "crates/router/src/routes/app.rs", "crates/router/src/routes/user.rs", "crates/router/src/types/domain/user.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3514
Bug: [FEATURE] send metadata field in authentication request for nmi, noon and cryptopay ### Feature Description Send metadata in the authorize request for noon, nmi and cryptopay. ### Possible Implementation metadata field is being sent in routerData.request for Authorize request. This needs to be mapped to conn...
diff --git a/crates/api_models/src/payment_methods.rs b/crates/api_models/src/payment_methods.rs index 0540d470a94..ef1812acf11 100644 --- a/crates/api_models/src/payment_methods.rs +++ b/crates/api_models/src/payment_methods.rs @@ -642,7 +642,7 @@ pub struct PaymentMethodListResponse { pub redirect_url: Option<St...
2024-01-11T09:59:47Z
## Description <!-- Describe your changes in detail --> Send metadata in the authorize request for noon, nmi and cryptopay. ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application configuration/environment variables <!-- ...
a9c0d0c55492c14a4a10283ffd8deae04c8ea853
Manual. 1. CryptoPay (connector force sync response) <img width="1728" alt="Cryptopay log" src="https://github.com/juspay/hyperswitch/assets/61539176/1975c066-bcb1-4ae8-ad91-c200d92d28fa"> 2. NMI (connector force sync response) Authomatic capture (auth+capture) <img width="1728" alt="Screenshot 2024-02-06 at...
[ "crates/api_models/src/payment_methods.rs", "crates/router/src/connector/cryptopay/transformers.rs", "crates/router/src/connector/nmi/transformers.rs", "crates/router/src/connector/noon.rs", "crates/router/src/connector/noon/transformers.rs", "openapi/openapi_spec.json" ]
juspay/hyperswitch
juspay__hyperswitch-3320
Bug: audit trail - add connector events ### Connector Events Audit trail Build a connector events audit trail endpoint for fetching all events from `connector_events_audit` table for ops audit trail. ![Image](https://github.com/juspay/hyperswitch/assets/21202349/3ae37c76-117e-46af-8e5c-3c9b74410efa) can refer to...
diff --git a/crates/analytics/src/clickhouse.rs b/crates/analytics/src/clickhouse.rs index b8fd5e6a35d..f81c29c801c 100644 --- a/crates/analytics/src/clickhouse.rs +++ b/crates/analytics/src/clickhouse.rs @@ -21,6 +21,7 @@ use crate::{ filters::ApiEventFilter, metrics::{latency::LatencyAvg, ApiEventMe...
2024-01-10T20:00:48Z
## Description adding GET api for query to fetch connector events log by specified `payment_id` ### Additional Changes - [x] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application configuration/environment variables <!-- Provide links to the files...
398c5ed51e0547504c3dfbd1d7c23568337e7d1c
``` curl 'http://localhost:8080/analytics/v1/connector_event_logs?type=Payment&payment_id=pay_yfkCogrWxVbB8O0biPkh' \ -H 'Accept: */*' \ -H 'Accept-Language: en-GB,en' \ -H 'Authorization: Bearer *' \ -H 'Connection: keep-alive' \ -H 'Content-Type: application/json' \ -H 'Origin: http://localhost:900...
[ "crates/analytics/src/clickhouse.rs", "crates/analytics/src/connector_events.rs", "crates/analytics/src/connector_events/core.rs", "crates/analytics/src/connector_events/events.rs", "crates/analytics/src/lib.rs", "crates/analytics/src/sqlx.rs", "crates/analytics/src/types.rs", "crates/api_models/src/a...
juspay/hyperswitch
juspay__hyperswitch-3316
Bug: [REFACTOR] : [Bluesnap] Add connector_transaction_id as fallback for webhooks ### Bug Description Currently we are only consuming `merchant_transaction_id` from the webhook body, this was done to tackle the timeouts issue, but seems like Bluesnap doesn't always includes this id, so we need to add `connector_tr...
diff --git a/crates/router/src/connector/bluesnap.rs b/crates/router/src/connector/bluesnap.rs index edcad00c983..e54d8320d0f 100644 --- a/crates/router/src/connector/bluesnap.rs +++ b/crates/router/src/connector/bluesnap.rs @@ -1043,11 +1043,19 @@ impl api::IncomingWebhook for Bluesnap { | bluesnap::Blues...
2024-01-10T13:44:27Z
## Description <!-- Describe your changes in detail --> add connector_txn_id fallback for webhook ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application configuration/environment variables <!-- Provide links to the file...
e0e28b87c0647252918ef110cd7614c46b5cf943
Trigger webhooks from Bluesnap with and without `merchant_transaction_id` and receive outgoing webhooks from Hyperswitch <img width="1424" alt="Screenshot 2024-01-10 at 7 13 24 PM" src="https://github.com/juspay/hyperswitch/assets/55536657/5a743336-f53a-421f-9d23-d0e75344232d">
[ "crates/router/src/connector/bluesnap.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3309
Bug: [FEATURE] Add support for card extended bin in payment attempt ### Feature Description Card extended bin is initial 8 digit of card number. we need this field to be sent in payment attempt so that merchant can block payments based on this field too ### Possible Implementation Add a new field `card_extended_b...
diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs index 4ef0c540b51..7cc9296815b 100644 --- a/crates/api_models/src/payments.rs +++ b/crates/api_models/src/payments.rs @@ -1129,6 +1129,7 @@ pub struct AdditionalCardInfo { pub bank_code: Option<String>, pub last4: Option<String...
2024-01-10T11:22:12Z
## Description <!-- Describe your changes in detail --> Card extended bin is the initial 8 digits of card number. we need this field to be sent in payment attempt so that merchant can block payments based on this field too. This PR adds a new field `card_extended_bin` in `AdditionalCardInfo` struct which is mapped ...
fe3cf54781302c733c1682ded2c1735544407a5f
1. Do a payment with card. You should be getting the `card_extended_bin` field in response ![image](https://github.com/juspay/hyperswitch/assets/70657455/ff2a0da3-ef7b-4415-9c15-e49bcd3f43f4) 2. Do a payment retrieve call using the `payment_id` from above call. You should get `card_extended_bin` field in respon...
[ "crates/api_models/src/payments.rs", "crates/cards/src/validate.rs", "crates/router/src/core/payments/helpers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3311
Bug: audit trail - add webhook events ### Webhook Events Audit trail Build a webhook events audit trail endpoint for fetching all events from `webhook_events_audit` table for ops audit trail. ![Image](https://github.com/juspay/hyperswitch/assets/21202349/3ae37c76-117e-46af-8e5c-3c9b74410efa) can refer to the exi...
diff --git a/crates/analytics/src/clickhouse.rs b/crates/analytics/src/clickhouse.rs index 964486c9364..b8fd5e6a35d 100644 --- a/crates/analytics/src/clickhouse.rs +++ b/crates/analytics/src/clickhouse.rs @@ -21,6 +21,7 @@ use crate::{ filters::ApiEventFilter, metrics::{latency::LatencyAvg, ApiEventMe...
2024-01-10T11:16:28Z
## Description adding GET api for query to fetch outgoing webhook events log by specified filters **Filter:** ```payment_id: String``` ```event_id: Option<String>``` ```refund_id: Option<String>``` ```dispute_id: Option<String>``` ```mandate_id: Option<String>``` ```payment_method_id: Option<String>``` ```att...
ed07c5ba90868a3132ca90d72219db3ba8978232
**Api Endpoint:** ```http://localhost:8080/analytics/v1/outgoing_webhook_event_logs``` curl attached below with sample response tested on local machine
[ "crates/analytics/src/clickhouse.rs", "crates/analytics/src/lib.rs", "crates/analytics/src/outgoing_webhook_event.rs", "crates/analytics/src/outgoing_webhook_event/core.rs", "crates/analytics/src/outgoing_webhook_event/events.rs", "crates/analytics/src/sqlx.rs", "crates/analytics/src/types.rs", "crate...
juspay/hyperswitch
juspay__hyperswitch-3307
Bug: [FEATURE] [BOA/Cybersource] Include merchant metadata in capture and void requests ### Feature Description Include merchant metadata in capture and void requests for connectors BOA and Cybersource. ### Possible Implementation Include merchant metadata in capture and void requests for connectors BOA and Cyber...
diff --git a/crates/router/src/connector/bankofamerica/transformers.rs b/crates/router/src/connector/bankofamerica/transformers.rs index 71a44b5a6e6..e024eb7a501 100644 --- a/crates/router/src/connector/bankofamerica/transformers.rs +++ b/crates/router/src/connector/bankofamerica/transformers.rs @@ -988,6 +988,8 @@ pub...
2024-01-10T11:09:41Z
## Description <!-- Describe your changes in detail --> Include merchant metadata in capture and void requests for connectors BOA and Cybersource. ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application configuration/environ...
612f8d9d5f5bcba78aa64c3128cc72be0f2860ea
Testing can be done by creating 2 manual authorized payments for each BOA and Cybersource. While creating these payments you should pass metadata in the requests. ``` "metadata": { "count_tickets": 1, "transaction_number": "5590043" }, ``` Then you should void one payment and capture the other. You sh...
[ "crates/router/src/connector/bankofamerica/transformers.rs", "crates/router/src/connector/cybersource/transformers.rs", "crates/router/src/core/payments/transformers.rs", "crates/router/src/types.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3306
Bug: [BUG] Validation for authtype and metadata in payment connector update ### Bug Description We are validating authtype and metadata while creating payment connector account, But we are not validating in update call. ### Expected Behavior When we try to update payment connector, we should validate authty...
diff --git a/crates/router/src/core/admin.rs b/crates/router/src/core/admin.rs index e8593581126..fd4cae3a2b9 100644 --- a/crates/router/src/core/admin.rs +++ b/crates/router/src/core/admin.rs @@ -1172,6 +1172,34 @@ pub async fn update_payment_connector( field_name: "connector_account_details".to_string(),...
2024-01-10T10:25:29Z
## Description <!-- Describe your changes in detail --> Adding validation for authtype and metadata in update payment connector call. ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application configuration/environment variable...
01c2de223f60595d77c06a59a40dfe041e02cfee
1)Try passing wrong metadata for any connector in update payment connector call <img width="1160" alt="Screenshot 2024-01-10 at 3 51 20 PM" src="https://github.com/juspay/hyperswitch/assets/121822803/8db585b6-9924-41a0-bf32-c3ee12dc5daa"> 2)Try passing wrong authtype for any connector in update payment connecto...
[ "crates/router/src/core/admin.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3268
Bug: Deep health check for Hyperswitch Scheduler Components to be verified in the check: - [x] RDS (PostgreSQL) - Connection to Database - State of Migration - [x] ElastiCache (Redis) - Connection to Redis - [x] Stream Insertion - [x] #3524 - [x] Clickhouse
diff --git a/Cargo.lock b/Cargo.lock index a1aabc89a04..f0334ce9cfc 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -5526,6 +5526,7 @@ dependencies = [ "external_services", "futures 0.3.28", "masking", + "num_cpus", "once_cell", "rand 0.8.5", "redis_interface", diff --git a/config/config.example.toml b/config/c...
2024-01-10T10:08:09Z
## Description <!-- Describe your changes in detail --> This PR adds support for performing a deeper health check of the scheduler which includes: Database connection check with read, write and delete queries (Added support for database transaction too) Redis connection check with set, get and delete key (Set ke...
20efc3020ac389199eed13154f070685417ef82a
1. `/health` ![image](https://github.com/juspay/hyperswitch/assets/70657455/fe87da30-d4ce-424d-9263-ad76a901f90f) 2. `/health/ready` ![image](https://github.com/juspay/hyperswitch/assets/70657455/922b18b9-006e-403f-93e7-714791c7434b) 3. `'health/ready` with some db error ![image](https://github.com/jus...
[ "Cargo.lock", "config/config.example.toml", "config/deployments/scheduler/consumer.toml", "config/deployments/scheduler/producer.toml", "config/development.toml", "config/docker_compose.toml", "crates/api_models/src/health_check.rs", "crates/router/src/bin/scheduler.rs", "crates/router/src/core/erro...
juspay/hyperswitch
juspay__hyperswitch-3292
Bug: Throw an error when outgoing webhook events env var not found
diff --git a/crates/router/src/services/kafka.rs b/crates/router/src/services/kafka.rs index 2b29a61b4a4..2bcfcfe974f 100644 --- a/crates/router/src/services/kafka.rs +++ b/crates/router/src/services/kafka.rs @@ -126,6 +126,15 @@ impl KafkaSettings { )) })?; + common_utils::fp_utils::when...
2024-01-09T07:44:10Z
## Description Throw an error when outgoing webhook events env var not found ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application configuration/environment variables <!-- Provide links to the files with correspon...
ecf51b5e3a30f055634edfafcd36f64cef535a53
[ "crates/router/src/services/kafka.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3296
Bug: [FEATURE]: [Cybersource] Add 3DS flow for cards ### Feature Description Add 3DS flow for cards ### Possible Implementation Add 3DS flow for cards ### Have you spent some time checking if this feature request has been raised before? - [X] I checked and didn't find a similar issue ### Have you read the Co...
diff --git a/config/config.example.toml b/config/config.example.toml index 94f71fa3f70..e20f9c1b65d 100644 --- a/config/config.example.toml +++ b/config/config.example.toml @@ -351,6 +351,7 @@ stripe = { payment_method = "bank_transfer" } nuvei = { payment_method = "card" } shift4 = { payment_method = "card" } blues...
2024-01-09T07:42:45Z
## Description <!-- Describe your changes in detail --> Implement 3DS flow for cards ``` Legend: UB: User Browser M: Merchant HS: Hyperswitch CS: Cybersource ``` ![Cybersource_3DS](https://github.com/juspay/hyperswitch/assets/55536657/eea4b266-970b-4f73-84c2-d19ca05a6ea2) ### Additional Changes ...
af43b07e4394458db478bc16e5fb8d3b0d636a31
<img width="1139" alt="Screenshot 2024-01-09 at 6 23 43 PM" src="https://github.com/juspay/hyperswitch/assets/55536657/e6f5c024-2116-4946-ae67-802e1fc4a126"> <img width="1138" alt="Screenshot 2024-01-09 at 6 23 51 PM" src="https://github.com/juspay/hyperswitch/assets/55536657/9db71df7-a0b4-4c85-b611-1eba611e1ab9"> ...
[ "config/config.example.toml", "config/development.toml", "config/docker_compose.toml", "crates/router/src/connector/cybersource.rs", "crates/router/src/connector/cybersource/transformers.rs", "crates/router/src/connector/utils.rs", "crates/router/src/core/payments.rs", "crates/router/src/core/payments...
juspay/hyperswitch
juspay__hyperswitch-3293
Bug: feat: List merchant id and merchant name
diff --git a/crates/api_models/src/user.rs b/crates/api_models/src/user.rs index d666dfc3bfa..07909a35782 100644 --- a/crates/api_models/src/user.rs +++ b/crates/api_models/src/user.rs @@ -1,4 +1,4 @@ -use common_utils::pii; +use common_utils::{crypto::OptionalEncryptableName, pii}; use masking::Secret; use crate::...
2024-01-09T07:39:44Z
## Description Added Merchant name is list merchant api. <!-- Describe your changes in detail --> ### Additional Changes - [x] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application configuration/environment variables <!-- Provide links to the fi...
ecf51b5e3a30f055634edfafcd36f64cef535a53
``` curl --location --request GET '<URL>/user/switch/list' \ --header 'Authorization: Bearer <JWT>' ``` Above api should return list of merchant accounts the user (whos jwt is being used) has access to. ``` [ { "merchant_id": "merchant_1704706726", "merchant_name": null }, { ...
[ "crates/api_models/src/user.rs", "crates/router/src/core/user.rs", "crates/router/src/utils/user_role.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3260
Bug: [BUG] WASM build fails on latest pull ### Bug Description The workspace builds ok, but wasm-pack build `wasm-pack build --target web --out-dir "${PWD}/wasm" --out-name euclid crates/euclid_wasm -- --features development,dummy_connector` fails on compilation of mio-0.8.8 ### Expected Behavior bui...
diff --git a/crates/cards/Cargo.toml b/crates/cards/Cargo.toml index cf3e25459c6..6892350ce6f 100644 --- a/crates/cards/Cargo.toml +++ b/crates/cards/Cargo.toml @@ -19,6 +19,8 @@ time = "0.3.21" # First party crates common_utils = { version = "0.1.0", path = "../common_utils" } masking = { version = "0.1.0", path = ...
2024-01-08T17:33:58Z
## Description <!-- Describe your changes in detail --> This PR fixes failing `wasm-pack build` for the `euclid_wasm` crate. ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application configuration/environment variables <!-...
5484cf42426d37667266fb952b800a6dab5e305e
<img width="1242" alt="image" src="https://github.com/juspay/hyperswitch/assets/83439957/3d7203ad-c50d-428e-9ec9-d05248c398bd">
[ "crates/cards/Cargo.toml", "crates/cards/src/validate.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3282
Bug: [BUG] [BOA/CYBERSOURCE] merchant_defined_information giving authentication error ### Bug Description Some payments fail when `merchant_defined_information` is passed for each payment with data coming from merchant in payment requests metadata. ### Expected Behavior All payments should succeed when `merchant_...
diff --git a/crates/router/src/connector/bankofamerica/transformers.rs b/crates/router/src/connector/bankofamerica/transformers.rs index def93ec5f83..aa47efbe714 100644 --- a/crates/router/src/connector/bankofamerica/transformers.rs +++ b/crates/router/src/connector/bankofamerica/transformers.rs @@ -1,5 +1,3 @@ -use st...
2024-01-08T17:01:35Z
## Description <!-- Describe your changes in detail --> Some payments fail when merchant_defined_information is passed for the payment with data coming from merchant in payment requests metadata. This was happening because hashmaps were being used to populate key,value pairs in merchantDefinedInformation due to w...
5484cf42426d37667266fb952b800a6dab5e305e
Testing can be done by creating a card/gpay/applepay payment and by passing the following metadata in PAYMENTS-CREATE: `"metadata": { "count_tickets": 1, "transaction_number": "5590043" }` You should then be able to see the metadata on BOA dashboard for that payment: ![292885857-2693f174-0552-45a9-af4...
[ "crates/router/src/connector/bankofamerica/transformers.rs", "crates/router/src/connector/cybersource/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3272
Bug: [FEATURE] [BOA/Cybersource] Store AVS Response in connector metadata ### Feature Description The AVS fields in payments response for authorize flow should be stored in connector metadata. ### Possible Implementation The AVS fields in payments response for authorize flow should be stored in connector metadata...
diff --git a/crates/router/src/connector/bankofamerica.rs b/crates/router/src/connector/bankofamerica.rs index 1e0856a9ccc..aeb3dafcfa2 100644 --- a/crates/router/src/connector/bankofamerica.rs +++ b/crates/router/src/connector/bankofamerica.rs @@ -205,7 +205,7 @@ impl ConnectorCommon for Bankofamerica { }; ...
2024-01-08T09:39:35Z
## Description <!-- Describe your changes in detail --> This PR contains the following changes for BOA/Cybersource: 1. The AVS response being sent by BOA/Cybersource for authorize flow is being stored in `connector_metadata` 2. In case of payments failing due to AVS check the failure reason will also contain the ...
9eaebe8db3d83105ef1e8fc784241e1fb795dd22
1. Create a successful payment and verify that avs_response is stored in connector_metadata in db for the payment <img width="1073" alt="image" src="https://github.com/juspay/hyperswitch/assets/41580413/ceed3f94-523c-424a-be4d-32657b193416"> Curl for creating payment: ```curl curl --location 'http://localhost...
[ "crates/router/src/connector/bankofamerica.rs", "crates/router/src/connector/bankofamerica/transformers.rs", "crates/router/src/connector/cybersource.rs", "crates/router/src/connector/cybersource/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3263
Bug: [FEATURE] : [Connector] Implement Revoke Mandate Flow ### Feature Description When revoke-mandate endpoint is triggered, the mandate should be revoked with connector also. Currently it is being revoked only at core level which is a feature gap. ### Possible Implementation Add a `execute_connector_processing...
diff --git a/crates/api_models/src/mandates.rs b/crates/api_models/src/mandates.rs index 035f7adec9f..5c0810dc21b 100644 --- a/crates/api_models/src/mandates.rs +++ b/crates/api_models/src/mandates.rs @@ -17,6 +17,12 @@ pub struct MandateRevokedResponse { /// The status for mandates #[schema(value_type = Mand...
2024-01-07T21:47:25Z
## Description <!-- Describe your changes in detail --> Add Revoke Mandate flow: When the merchant invokes the revoke-mandate endpoint, the mandate should be revoked at both the connector level and core level. ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database s...
3cd74966b279dc1c43935dc1bceb1c69b9eb0643
- Create a mandate (zero and non-zero) with the connector - Make Payment using the mandates - Revoke the mandate - Try to revoke an already revoked mandate ### Revoke a Mandate <img width="1119" alt="Screenshot 2024-01-08 at 12 26 34 PM" src="https://github.com/juspay/hyperswitch/assets/55536657/ed66827d-c74c-...
[ "crates/api_models/src/mandates.rs", "crates/router/src/connector/cybersource.rs", "crates/router/src/connector/cybersource/transformers.rs", "crates/router/src/connector/utils.rs", "crates/router/src/core/mandate.rs", "crates/router/src/core/mandate/utils.rs", "crates/router/src/core/payments/flows.rs"...
juspay/hyperswitch
juspay__hyperswitch-3588
Bug: [BUG] map error message and connector transaction_id in case connector returns failure status in 2xx response status. ### Bug Description When connector returns failure status in 2xx response, error messages are not persisted for some connectors. ### Expected Behavior When connector returns failure status in...
diff --git a/crates/router/src/connector/bankofamerica/transformers.rs b/crates/router/src/connector/bankofamerica/transformers.rs index de53b991d89..b2a9f14ccce 100644 --- a/crates/router/src/connector/bankofamerica/transformers.rs +++ b/crates/router/src/connector/bankofamerica/transformers.rs @@ -1446,9 +1446,9 @@ i...
2024-01-06T08:14:41Z
## Description <!-- Describe your changes in detail --> Store payment_id and refund_id and error_details in case connector returns 2xx for a failed payment. ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application configurati...
5fb3c001b5dc371f81fe1708fd9a6c6978fb726e
Manual Noon: <img width="1310" alt="noon error mapping" src="https://github.com/juspay/hyperswitch/assets/61539176/84877c5e-ea00-45c9-b32b-fc514859512d"> Payme: <img width="1347" alt="payme error mapping" src="https://github.com/juspay/hyperswitch/assets/61539176/18e9fb84-bba8-48b7-8859-ce1eabe1aef8"> Refu...
[ "crates/router/src/connector/bankofamerica/transformers.rs", "crates/router/src/connector/cryptopay/transformers.rs", "crates/router/src/connector/noon/transformers.rs", "crates/router/src/connector/payme/transformers.rs", "crates/router/src/connector/utils.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3251
Bug: Rename `kms` feature flag to `aws_kms` Rename `kms` feature flag to `aws_kms`, `kms` files to `aws_kms` and the components of kms to include `aws` as its prefix. This change is required so that current kms encryption becomes distinguishable, especially if in future new encryption implementations like a AWS KM...
diff --git a/README.md b/README.md index 0f5e924589f..0da065eeba6 100644 --- a/README.md +++ b/README.md @@ -199,7 +199,7 @@ should be introduced, checking it agrees with the actual structure --> │ ├── data_models : Represents the data/domain models used by the business/domain layer │ ├── diese...
2024-01-04T20:00:07Z
## Description <!-- Describe your changes in detail --> This PR renames `kms` feature flag to `aws_kms`, `kms` files to `aws_kms` and the components of kms to include `aws` as its prefix. This change is done so that current kms encryption is distinguishable, especially if in future new encryption implementations l...
892b04f805c219e2cf7cbe5736aef19909e986f7
Renaming types so just a basic sanity test should suffice
[ "README.md", "config/config.example.toml", "crates/drainer/Cargo.toml", "crates/drainer/src/connection.rs", "crates/drainer/src/services.rs", "crates/drainer/src/settings.rs", "crates/external_services/Cargo.toml", "crates/external_services/src/kms.rs", "crates/external_services/src/aws_kms/decrypt....
juspay/hyperswitch
juspay__hyperswitch-3322
Bug: fix: reset tracking id api for connector onboarding ## Problem To support the onboarding flow where merchants can signin/signup directly into the connector's website and give us the credentials of the account we had created onboarding apis (action_url and sync) which uses `tracking_id` to track the onboarding ...
diff --git a/crates/api_models/src/connector_onboarding.rs b/crates/api_models/src/connector_onboarding.rs index 759d3cb97f1..7e8288d9747 100644 --- a/crates/api_models/src/connector_onboarding.rs +++ b/crates/api_models/src/connector_onboarding.rs @@ -52,3 +52,9 @@ pub struct PayPalOnboardingDone { pub struct PayPalI...
2024-01-03T08:48:26Z
## Description <!-- Describe your changes in detail --> 1. This PR adds checks in connector_onboarding to only proceed if the connector exists for the given merchant_account. 2. Reset tracking id api has been added to connector onboarding, which will reset the tracking details of the onboarded merchant. This can be...
5a1a3da7502ce9e13546b896477d82719162d5b6
Postman. ``` curl --location 'http://localhost:8080/connector_onboarding/action_url' \ --header 'Content-Type: application/json' \ --header 'Authorization: Bearer JWT' \ --data '{ "connector": "paypal", "connector_id": "", "return_url": "https://google.com" }' ``` ``` curl --location 'http://l...
[ "crates/api_models/src/connector_onboarding.rs", "crates/api_models/src/events/connector_onboarding.rs", "crates/router/src/consts.rs", "crates/router/src/core/connector_onboarding.rs", "crates/router/src/core/connector_onboarding/paypal.rs", "crates/router/src/routes/app.rs", "crates/router/src/routes/...
juspay/hyperswitch
juspay__hyperswitch-3232
Bug: [BUG]: Recurring Payments via Wallets for Cybersource ### Bug Description Recurring/Subsequent Mandate payments are not working for cyber source when the payment_method is wallets ### Expected Behavior Zero and non-zero, recurring and non-recurring payments should flow for cards and wallets via cyber source ...
diff --git a/config/development.toml b/config/development.toml index d365abc4674..6e7e040906a 100644 --- a/config/development.toml +++ b/config/development.toml @@ -468,8 +468,8 @@ connectors_with_webhook_source_verification_call = "paypal" [mandates.supported_payment_methods] pay_later.klarna = { connector_list = ...
2024-01-02T13:07:27Z
## Description - [fix]: Recurring Payments via Wallets - [feat]: Implement zero dollar mandates and recurring payments via wallets - [refactor]: Update the mandate token created with cybersource from `instrumentIdentifier` to `PaymentInstrument` ### Additional Changes - [ ] This PR modifies the API contra...
e06ba148b666772fe79d7050d0c505dd2f04f87c
- Create a Merchant and an Mca for cyberource - Make a setup mandate payment for card and also for wallet - Make a recurring mandate payment for card and also google_pay - The payment should succeed - Test both zero and non-zero mandate creation <img width="1177" alt="Screenshot 2024-01-03 at 4 50 42 PM" src="h...
[ "config/development.toml", "crates/router/src/connector/cybersource/transformers.rs", "crates/router/src/core/payments.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3190
Bug: [FEATURE] Replace Routing cache with Moka ### Feature Description Have to replace static routing cache with moka cache in order to use extra features like TTL ### Possible Implementation Just need to replace the current cache. ### Have you spent some time checking if this feature request has been raised bef...
diff --git a/crates/router/src/core/admin.rs b/crates/router/src/core/admin.rs index 4c2ebb516e6..b50c5b69681 100644 --- a/crates/router/src/core/admin.rs +++ b/crates/router/src/core/admin.rs @@ -1245,17 +1245,6 @@ pub async fn update_payment_connector( } } - // The purpose of this merchant account ...
2023-12-28T12:48:19Z
## Description <!-- Describe your changes in detail --> Enabled Moka cache for routing with cache invalidation ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application configuration/environment variables <!-- Provide li...
1523311c479f2caa564b853e668fd47579c2b21f
Look for the pub-sub cache invalidation log ![image](https://github.com/juspay/hyperswitch/assets/76486416/e739ac71-2b2b-4103-9804-b4478c5d0e87) ![image](https://github.com/juspay/hyperswitch/assets/76486416/068743c0-a9d0-49af-859d-f23ab32eb2ec) 1. Update an existing Merchant connector account and look for Cgrpa...
[ "crates/router/src/core/admin.rs", "crates/router/src/core/payments.rs", "crates/router/src/core/payments/routing.rs", "crates/router/src/core/payouts/helpers.rs", "crates/router/src/core/routing/helpers.rs", "crates/router/src/db/merchant_account.rs", "crates/router/src/db/merchant_connector_account.rs...
juspay/hyperswitch
juspay__hyperswitch-3267
Bug: Deep health check for Hyperswitch Server Components to be verified in the check: - [x] RDS (PostgreSQL) - Connection to Database - Read check - Write check (v2) - State of Migration (v2) - [x] ElastiCache (Redis) - Connection to Redis - Stream insertions - [x] Locker Connection (/hea...
diff --git a/crates/api_models/src/health_check.rs b/crates/api_models/src/health_check.rs new file mode 100644 index 00000000000..d7bb120d017 --- /dev/null +++ b/crates/api_models/src/health_check.rs @@ -0,0 +1,6 @@ +#[derive(Debug, Clone, serde::Serialize, serde::Deserialize)] +pub struct RouterHealthCheckResponse { ...
2023-12-27T15:29:09Z
## Description <!-- Describe your changes in detail --> This PR adds support for performing a deeper health check of the application which includes: * Database connection check with read, write and delete queries (Added support for database transaction too) * Redis connection check with set, get and delete key (Se...
72968dcecf16c8821a383a826e4e35408b035633
1. Hit `/health` for getting just the application health. 2. Hit `/health/deep_check` for getting deep report of components health * Test case 1 (Application not able to connect to database because postgresql is down) ![image](https://github.com/juspay/hyperswitch/assets/70657455/5e8af307-0b01-4008-a8e7-30d1aa...
[ "crates/api_models/src/health_check.rs", "crates/api_models/src/lib.rs", "crates/router/src/consts.rs", "crates/router/src/db.rs", "crates/router/src/db/health_check.rs", "crates/router/src/db/kafka_store.rs", "crates/router/src/routes/app.rs", "crates/router/src/routes/health.rs", "crates/router/sr...
juspay/hyperswitch
juspay__hyperswitch-3622
Bug: [FEATURE] Add required fields for giropay ### Feature Description Add giropay wallet required fields for all connectors that implement Giropay ### Possible Implementation Add required fields for Giropay ### Have you spent some time checking if this feature request has been raised before? - [X] I checked an...
diff --git a/config/config.example.toml b/config/config.example.toml index 87999f0e9e9..f592cfeb9eb 100644 --- a/config/config.example.toml +++ b/config/config.example.toml @@ -390,6 +390,8 @@ bank_debit.sepa = { connector_list = "gocardless" } # Mandate supported payment bank_redirect.ideal = {connector_list = "strip...
2023-12-21T15:05:05Z
## Description <!-- Describe your changes in detail --> Resolves [#3622](https://github.com/juspay/hyperswitch/issues/3622) ### Test Cases 1. Create a giropay payment with mollie with empty payment method object. The payment should succeed. ``` { "amount": 1000, "currency": "EUR", "confirm": true, ...
54fb61eeebec503f599774fe9e97f6b6ce3f1458
[ "config/config.example.toml", "config/deployments/integration_test.toml", "config/deployments/production.toml", "config/deployments/sandbox.toml", "config/development.toml", "config/docker_compose.toml", "crates/api_models/src/payments.rs", "crates/router/src/configs/defaults.rs", "crates/router/src...
juspay/hyperswitch
juspay__hyperswitch-2090
Bug: [BUG] Add metrics in router scheduler flow as it is being ignored now ### Bug Description Router is not maintaining any metrics about the task added in scheduler. this has to be fixed File: crates/router/src/core/payments/helpers.rs Method: add_domain_task_to_pt ### Expected Behavior Metrics has to be adde...
diff --git a/crates/router/src/core/api_keys.rs b/crates/router/src/core/api_keys.rs index c1ddc43cd65..78d4e801e8f 100644 --- a/crates/router/src/core/api_keys.rs +++ b/crates/router/src/core/api_keys.rs @@ -270,6 +270,11 @@ pub async fn add_api_key_expiry_task( api_key_expiry_tracker.key_id ...
2023-12-21T11:29:29Z
## Description <!-- Describe your changes in detail --> Currently `TASKS_ADDED_COUNT` and `TASKS_RESET_COUNT` metrics does not exist in router to track the tasks added in scheduler. This PR aims at adding that. Closes #2090 ## Motivation and Context <!-- Why is this change required? What problem does it solv...
5ad3f8939afafce3eec39704dcaa92270b384dcd
Did a few payments (Ran Stripe and Volt collection a few times): <img width="1728" alt="image" src="https://github.com/juspay/hyperswitch/assets/69745008/1e2dca12-c7e8-453c-97c9-bc95e8dbf742"> ### Local setup: Modify 3 files: - `docker-compose.yml`: Expose the `otel-collector` port by replacing `"4317"` w...
[ "crates/router/src/core/api_keys.rs", "crates/router/src/core/payment_methods/cards.rs", "crates/router/src/core/payment_methods/vault.rs", "crates/router/src/core/payments/helpers.rs", "crates/router/src/core/refunds.rs", "crates/router/src/routes/metrics.rs", "crates/router/src/workflows/api_key_expir...
juspay/hyperswitch
juspay__hyperswitch-3175
Bug: [BUG] No provision for approving payments kept in ManualReview state for FRM flows ### Bug Description Once a fraudulent payment transaction is identified before authorization, it can be canceled or kept in manual reviewing state. If it is canceled, the payment is marked as a `failed` transaction. If the dec...
diff --git a/crates/router/src/core/fraud_check.rs b/crates/router/src/core/fraud_check.rs index ad3a7638774..0e3f67c051b 100644 --- a/crates/router/src/core/fraud_check.rs +++ b/crates/router/src/core/fraud_check.rs @@ -431,6 +431,7 @@ pub async fn pre_payment_frm_core<'a, F>( frm_configs: FrmConfigsObject, ...
2023-12-20T09:15:53Z
## Description #3175 ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application configuration/environment variables <!-- Provide links to the files with corresponding changes. Following are the paths where you can find c...
1bbd9d5df0f145f192d0271d89761488e7347989
Tested locally using postman collection https://galactic-capsule-229427.postman.co/workspace/My-Workspace~2b563e0d-bad3-420f-8c0b-0fd5b278a4fe/collection/9906252-e8ad195c-90f5-4527-a40b-1a25bc9bedd2?action=share&creator=9906252 **Test Cases** - Payments <> FRM manual flow (pre + post) - Approve + Rejection shoul...
[ "crates/router/src/core/fraud_check.rs", "crates/router/src/core/payments.rs", "crates/router/src/core/payments/operations/payment_approve.rs", "crates/router/src/core/payments/operations/payment_reject.rs", "crates/router/src/core/payments/operations/payment_response.rs", "crates/router/src/core/payments...
juspay/hyperswitch
juspay__hyperswitch-2899
Bug: [BUG]: MCA metadata deserialization failures should be 4xx ### :memo: Feature Description - We don't have validation for Merchant Connector Account metadata, So while creating MCA we are allowing any json value. Because of which RequestEncodingFailure happening during payments for the MCA which doesn't hav...
diff --git a/crates/router/src/connector/coinbase/transformers.rs b/crates/router/src/connector/coinbase/transformers.rs index ce9bb3e871c..b1435e50df9 100644 --- a/crates/router/src/connector/coinbase/transformers.rs +++ b/crates/router/src/connector/coinbase/transformers.rs @@ -1,5 +1,7 @@ use std::collections::Hash...
2023-12-19T12:53:56Z
## Description <!-- Describe your changes in detail --> I've removed `to_connector_meta_from_secret_with_required_field`, which uses `MissingRequiredField` as an error (I also didn't like the unnecessary initialization of the `MissingRequiredField` before we knew if it would be needed). Instead, I added a `TryFrom...
5a791aaf4dc05e8ffdb60464a03b6fc41f860581
**Run unit test:** ``` cargo test --release --package router --lib connector::coinbase::transformers::tests::coinbase_payments_request_try_from_works -- --exact ``` ![image](https://github.com/juspay/hyperswitch/assets/8159517/a296af9b-a454-4d9b-a8ad-1939a837f04b) ### Migration script test https://onec...
[ "crates/router/src/connector/coinbase/transformers.rs", "crates/router/src/connector/utils.rs", "crates/router/src/core/admin.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3154
Bug: [FEATURE]: [VOLT] Add Support for Webhooks ### Feature Description Adding Support for Payment Webhooks for Volt Connector ### Have you spent some time checking if this feature request has been raised before? - [X] I checked and didn't find a similar issue ### Have you read the Contributing Guideline...
diff --git a/crates/router/src/connector/volt.rs b/crates/router/src/connector/volt.rs index bf36a7bff61..3641c0c3ddc 100644 --- a/crates/router/src/connector/volt.rs +++ b/crates/router/src/connector/volt.rs @@ -2,11 +2,13 @@ pub mod transformers; use std::fmt::Debug; -use common_utils::request::RequestContent; +...
2023-12-17T18:47:23Z
## Description <!-- Describe your changes in detail --> ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application configuration/environment variables <!-- Provide links to the files with corresponding changes. Followin...
252443a50dc48939eb08b3bcd67273bb71bbe349
![Screenshot 2024-01-03 at 8 28 35 PM 2](https://github.com/juspay/hyperswitch/assets/85639103/e2a0a038-6b92-4319-a94b-a57d976b205b) ```json { "amount": 6540, "currency": "EUR", "confirm": true, "capture_method": "automatic", "capture_on": "2022-09-10T10:11:12Z", "amount_to_captu...
[ "crates/router/src/connector/volt.rs", "crates/router/src/connector/volt/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3044
Bug: [FEATURE] Implement `AuthorizationInterface` for `MockDb` Spin off from https://github.com/juspay/hyperswitch/issues/172. Refer to the parent issue for more information
diff --git a/crates/diesel_models/src/authorization.rs b/crates/diesel_models/src/authorization.rs index 64fd1c65187..b6f75bbb9b7 100644 --- a/crates/diesel_models/src/authorization.rs +++ b/crates/diesel_models/src/authorization.rs @@ -57,6 +57,21 @@ pub struct AuthorizationUpdateInternal { pub connector_authoriz...
2023-12-16T23:57:21Z
## Description Implement AuthorizationInterface for MockDb ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application configuration/environment variables <!-- Provide links to the files with corresponding changes. Follo...
dc0e40d54bcff26c9996db6adc0a6071dc37ded0
[ "crates/diesel_models/src/authorization.rs", "crates/router/src/db/authorization.rs", "crates/storage_impl/src/mock_db.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3147
Bug: [REFACTOR] Handle card duplication ### Feature Description Currently card duplication and card metadata (card_holder_name, expiry year, expiry month, etc) changes are not being handled in Hyperswitch. ### Possible Implementation Rust locker sends `duplication_check` status in its store card respons...
diff --git a/crates/router/src/core/payment_methods/cards.rs b/crates/router/src/core/payment_methods/cards.rs index 7b505e7c01c..dfbd9211dfb 100644 --- a/crates/router/src/core/payment_methods/cards.rs +++ b/crates/router/src/core/payment_methods/cards.rs @@ -109,7 +109,10 @@ pub fn store_default_payment_method( ...
2023-12-15T14:56:35Z
## Description <!-- Describe your changes in detail --> Currently card duplication and card metadata (card_holder_name, expiry year, expiry month, etc) changes are not being handled in Hyperswitch. Rust locker has the following changes made - a new field `duplication_check` has been added in stored card respons...
3a869a2d5731a2393a687ed7773eda5344bd8e3f
Create a merchant account, api key and stripe mca. This PR has to be tested in below 2 flows as these are the two ways in which we can send add card request to locker. i) Directly adding card using `/payment_methods` api ii) Using `/payments` api with `setup_future_usage = on_session`
[ "crates/router/src/core/payment_methods/cards.rs", "crates/router/src/core/payment_methods/transformers.rs", "crates/router/src/core/payments/tokenization.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3099
Bug: [FEATURE] Make PM auth service generic across Payment Method types ### Feature Description Currently, PM auth only supports ACH, need to make it generic across SEPA, BACS as well. ### Possible Implementation Will probably need some kind of parent structure to differentiate between types ### Have you spent s...
diff --git a/crates/api_models/src/payment_methods.rs b/crates/api_models/src/payment_methods.rs index 35193b958f2..9873f62bfe1 100644 --- a/crates/api_models/src/payment_methods.rs +++ b/crates/api_models/src/payment_methods.rs @@ -222,17 +222,24 @@ pub struct PaymentMethodDataBankCreds { pub connector_details: V...
2023-12-12T10:21:17Z
## Description <!-- Describe your changes in detail --> Support for SEPA and BACS in direct debit PM auth. Earlier we only supported ACH based response from pm auth connector in PM auth, now have added support for BACS and SEPA based responses as well. ### Additional Changes - [ ] This PR modifies the API...
1e32c6e873711e4f7715176c7d1057c18d4ec540
Have tested locally by hardcoding response from connector. This cannot be tested as it is in sandbox because Plaid always sends a basic ACH based response in sandbox which won't trigger the response structure for BACS and SEPA (the implementation of this PR). A simple sanity testing however can be done for the featu...
[ "crates/api_models/src/payment_methods.rs", "crates/pm_auth/src/connector/plaid/transformers.rs", "crates/pm_auth/src/types.rs", "crates/router/src/configs/defaults.rs", "crates/router/src/core/payment_methods/cards.rs", "crates/router/src/core/pm_auth.rs", "crates/router/src/types/storage/payment_metho...
juspay/hyperswitch
juspay__hyperswitch-3440
Bug: [FEATURE] Add `KMS` encrypt utility ### Feature Description Introducing a new functionality, that seamlessly integrates with Key Management Service (KMS), offering a robust encryption solution. This feature empowers users to encrypt any value with ease, ensuring enhanced security and data protection. Leveragin...
diff --git a/crates/external_services/src/kms.rs b/crates/external_services/src/kms.rs index 31c82253fe8..04a58e4b23f 100644 --- a/crates/external_services/src/kms.rs +++ b/crates/external_services/src/kms.rs @@ -75,7 +75,7 @@ impl KmsClient { // Logging using `Debug` representation of the error as the...
2023-12-12T08:15:43Z
## Description <!-- Describe your changes in detail --> ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application configuration/environment variables ## How did you test it? <!-- Did you write an integration/unit/API tes...
1add2c059f4fb5653f33e2f3ce454793caf2d595
Test cases written for encrpyt as well as decrypt functions. <img width="1400" alt="Screenshot 2023-12-12 at 13 33 03" src="https://github.com/juspay/hyperswitch/assets/61520228/638b199f-15ac-473e-84f5-55c3d8353715">
[ "crates/external_services/src/kms.rs", "crates/external_services/src/lib.rs", "crates/router/src/routes/metrics.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3106
Bug: [FEATURE] Add missing routing features to default feature list and release feature list for Hyperswitch Router ### Feature Description Add routing features like business profile routing as well as connector choice mca id to the default feature lit as well as the release feature list. ### Possible Implementati...
diff --git a/Makefile b/Makefile index 9b62b3c5c99..780d5a993c9 100644 --- a/Makefile +++ b/Makefile @@ -9,6 +9,10 @@ eq = $(if $(or $(1),$(2)),$(and $(findstring $(1),$(2)),\ $(findstring $(2),$(1))),1) + +ROOT_DIR_WITH_SLASH := $(dir $(realpath $(lastword $(MAKEFILE_LIST)))) +ROOT_...
2023-12-11T12:11:43Z
## Description <!-- Describe your changes in detail --> This PR adds required routing features to the release feature list for Hyperswitch and also updates the Makefile with a command to build the euclid WASM. ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database s...
151a30f4eed10924cd93bf7f4f66976af0ab8314
Local cargo build
[ "Makefile", "crates/euclid_wasm/Cargo.toml", "crates/router/Cargo.toml" ]
juspay/hyperswitch
juspay__hyperswitch-3466
Bug: [REFACTOR] Make the function to deserialize hashsets more generic when deserializing application configs ### Description As of opening this issue, there are multiple functions to deserialize hashsets with similar logic. These functions can be made generic, and reduced to one common function for deserializing...
diff --git a/Cargo.lock b/Cargo.lock index 5623fd9f729..24fedf82a27 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2603,9 +2603,9 @@ dependencies = [ [[package]] name = "fred" -version = "7.0.0" +version = "7.1.0" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "f2e8094c30c33132e948eb7e1...
2023-12-11T11:34:43Z
## Description <!-- Describe your changes in detail --> This PR updates the application configuration deserialization logic to use a common generic function to deserialize `HashSet<T>` instead of specific ones. In addition, this PR updates the function to be more lenient in that it allows spaces around the commas fo...
98bf8f5b85d318cd6ad3c7105fdde3149a2ef8ed
Unit tests: ```shell cargo test --package router --lib --all-features -- configs::settings::hashset_deserialization_test ``` <img width="800" alt="Screenshot of unit tests run" src="https://github.com/juspay/hyperswitch/assets/22217505/ac1de2b4-f771-44c7-87a9-03e62e8904f6"> Also, ran the application with eac...
[ "Cargo.lock", "config/config.example.toml", "config/deployments/integration_test.toml", "config/deployments/production.toml", "config/deployments/sandbox.toml", "config/development.toml", "config/docker_compose.toml", "crates/common_enums/src/enums.rs", "crates/currency_conversion/Cargo.toml", "cr...
juspay/hyperswitch
juspay__hyperswitch-3089
Bug: [BUG] Payment Methods List filters not conscious of zero amount setup mandate payments ### Bug Description When a payment method is enabled for a particular connector with a minimum amount of `> 0`, and a zero amount setup mandate payment intent is created, the payment method doesn't show up in the list paymen...
diff --git a/crates/router/src/core/payment_methods/cards.rs b/crates/router/src/core/payment_methods/cards.rs index 84aef952a53..aaecd86627c 100644 --- a/crates/router/src/core/payment_methods/cards.rs +++ b/crates/router/src/core/payment_methods/cards.rs @@ -2237,7 +2237,7 @@ fn filter_amount_based(payment_method: &R...
2023-12-08T06:31:09Z
## Description <!-- Describe your changes in detail --> This PR updates the List Payment Method core filters to allow payment intents with zero amount ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application configuration/e...
777cd5cdc2342fb7195a06505647fa331725e1dd
1. Create a Merchant Account, 1 Merchant Connector Account 2. Create a payment with amount = 0, confirm = false & no payment method given 3. Do a list payment methods call. The returned list should include all the eligible payment methods despite the amount being 0. <img width="551" alt="image" src="https://gith...
[ "crates/router/src/core/payment_methods/cards.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3065
Bug: [REFACTOR] Make the `card_holder_name` optional for card details in the payment APIs ### Description We currently have the `card_holder_name` as mandatory for cards in the payment APIs. We currently do not mandatorily collect it for every payment so this causes the SDK to have to send an empty string for payme...
diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs index 93c97cbd443..b19f4d7b7db 100644 --- a/crates/api_models/src/payments.rs +++ b/crates/api_models/src/payments.rs @@ -682,7 +682,7 @@ pub struct Card { /// The card holder's name #[schema(value_type = String, example = "J...
2023-12-06T16:46:54Z
## Description <!-- Describe your changes in detail --> We currently have the `card_holder_name` as mandatory for cards in the payment APIs. We currently do not mandatorily collect it for every payment so this causes the SDK to have to send an empty string for payments where the card holder name is not collected. ...
777cd5cdc2342fb7195a06505647fa331725e1dd
1. Create merchant account ``` curl --location 'http://localhost:8080/accounts' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: test_admin' \ --data-raw '{ "merchant_id": "merchant_1701880995", "locker_id": "m0010", "merchant_name": "Chethan", "...
[ "crates/api_models/src/payments.rs", "crates/router/src/compatibility/stripe/payment_intents/types.rs", "crates/router/src/compatibility/stripe/setup_intents/types.rs", "crates/router/src/connector/aci/transformers.rs", "crates/router/src/connector/bambora/transformers.rs", "crates/router/src/connector/br...
juspay/hyperswitch
juspay__hyperswitch-3070
Bug: [FEATURE] Make the Euclid Knowledge Graph generic in its supported keys & values ### Feature Description The Euclid Knowledge Graph is a framework that allows the developer to model domain specific constraints in routing, including but not limited to, general payment domain constraints (e.g.: the payment metho...
diff --git a/Cargo.lock b/Cargo.lock index 00c491d7101..7fce1e7f538 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2677,6 +2677,15 @@ version = "1.0.1" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "5443807d6dff69373d433ab9ef5378ad8df50ca6298caf15de6e52e24aaf54d5" +[[package]] +name = "e...
2023-12-06T13:01:25Z
## Description <!-- Describe your changes in detail --> This PR separates out and refactors the Euclid Knowledge Graph into the Constraint Graph in its own crate, and makes the Constraint Graph generic so it can work on custom key and value types as opposed to just the Euclid Key and Value types. This will remove...
ecc97bc8684d57834f62652265316df29cf2cf5d
Unit tests for the `euclid` and `kgraph_utils` crates. No specific API tests required. Euclid: <img width="586" alt="image" src="https://github.com/juspay/hyperswitch/assets/47862918/86ce0f9b-200b-4da7-903e-bf1c49d22c63"> Kgraph_utils: <img width="586" alt="image" src="https://github.com/juspay/hyperswitch/as...
[ "Cargo.lock", "crates/euclid/Cargo.toml", "crates/euclid/src/dssa/analyzer.rs", "crates/euclid/src/dssa/graph.rs", "crates/euclid/src/dssa/truth.rs", "crates/euclid/src/dssa/types.rs", "crates/euclid/src/lib.rs", "crates/euclid/src/utils.rs", "crates/euclid_macros/src/inner/knowledge.rs", "crates/...
juspay/hyperswitch
juspay__hyperswitch-3439
Bug: [FEATURE] `Blocklist` initial implementation ### Feature Description: This feature provides merchants with the ability to customize their transaction controls based on specific criteria. Merchants can tailor the blocklist according to their preferences, blocking the following elements as needed: Card Number...
diff --git a/crates/api_models/src/blocklist.rs b/crates/api_models/src/blocklist.rs new file mode 100644 index 00000000000..fc838eed5ce --- /dev/null +++ b/crates/api_models/src/blocklist.rs @@ -0,0 +1,41 @@ +use common_enums::enums; +use common_utils::events::ApiEventMetric; + +#[derive(Debug, Clone, serde::Serialize...
2023-12-05T11:57:03Z
## Description <!-- Describe your changes in detail --> This feature will allow the merchants to block the following according to their needs: ``` 1. card_numbers 2. card_isins 3. extended_bins ``` ### Additional Changes - [x] This PR modifies the API contract - [x] This PR modifies the database ...
8626bda6d5aa9e7531edc7ea50ed4f30c3b7227a
Refer to the attached postman collection for the API contracts for the blocklist APIs. Currently we support blocking three types of resources i.e. card numbers (payment intrument), card bin, and extended card bin. For Card Bin and Extended Card Bin :- 1. Setup a Merchant Account and any Connector account 2. Make...
[ "crates/api_models/src/blocklist.rs", "crates/api_models/src/lib.rs", "crates/api_models/src/payments.rs", "crates/cards/src/validate.rs", "crates/common_enums/src/enums.rs", "crates/data_models/src/errors.rs", "crates/data_models/src/payments.rs", "crates/data_models/src/payments/payment_intent.rs", ...
juspay/hyperswitch
juspay__hyperswitch-3046
Bug: [FEATURE] Migrate PaymentMethodAuth to OSS ### Feature Description Migrating PM auth services to OSS ### Possible Implementation Migration of PM auth crate and dependent changes ### Have you spent some time checking if this feature request has been raised before? - [X] I checked and didn't find a similar i...
diff --git a/Cargo.lock b/Cargo.lock index d2e8d9dd5df..307a5ca2398 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -405,6 +405,8 @@ dependencies = [ "common_utils", "error-stack", "euclid", + "frunk", + "frunk_core", "masking", "mime", "reqwest", @@ -4436,6 +4438,27 @@ dependencies = [ "plotters-backend", ]...
2023-12-04T10:10:25Z
## Description <!-- Describe your changes in detail --> PM Auth service migration ### Additional Changes - [x] This PR modifies the API contract - [ ] This PR modifies the database schema - [x] This PR modifies application configuration/environment variables <!-- Provide links to the files with correspon...
cfafd5cd29857283d57731dda7c5a332a493f531
1. Create merchant account - ``` curl --location --request POST 'http://localhost:8080/accounts' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: test_admin' \ --data-raw '{ "merchant_id": "merchant_1701764398", "locker_id": "m0010", "merchant_name...
[ "Cargo.lock", "config/config.example.toml", "config/development.toml", "config/docker_compose.toml", "crates/api_models/Cargo.toml", "crates/api_models/src/enums.rs", "crates/api_models/src/lib.rs", "crates/api_models/src/pm_auth.rs", "crates/pm_auth/Cargo.toml", "crates/pm_auth/README.md", "cra...
juspay/hyperswitch
juspay__hyperswitch-3007
Bug: [Feature]: [Braintree] Sync with Hyperswitch Reference ### :memo: Feature Description - In Hyperswitch, we retrieve transaction status in two ways: 1. Using `transaction_id` which is generated by Connectors 2. Using our `reference_id` which can be passed to Connectors during payment creation - If suppor...
diff --git a/crates/router/src/connector/braintree/transformers.rs b/crates/router/src/connector/braintree/transformers.rs index 44daef94e8a..f4bd62add3b 100644 --- a/crates/router/src/connector/braintree/transformers.rs +++ b/crates/router/src/connector/braintree/transformers.rs @@ -228,17 +228,16 @@ impl<F, T> ...
2023-12-02T09:33:58Z
## Description fixes #3007 ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application configuration/environment variables <!-- Provide links to the files with corresponding changes. Following are the paths where you ca...
cfafd5cd29857283d57731dda7c5a332a493f531
test case - Make a transaction, in response for reference field, we should see connector transaction id.
[ "crates/router/src/connector/braintree/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-2961
Bug: Add connector enums for Routing in add_connector script [BUG] ### Bug Description Recently, routing has been moved to OSS. This change breaks the add_connector script. Connector Enums should be added in euclid enums . ### Expected Behavior after running `bash add_connector.sh <connector-name> <connector-ba...
diff --git a/Cargo.lock b/Cargo.lock index e4a317d74f4..2ca33b6910a 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2339,6 +2339,7 @@ name = "euclid_wasm" version = "0.1.0" dependencies = [ "api_models", + "common_enums", "currency_conversion", "euclid", "getrandom 0.2.10", @@ -3306,6 +3307,7 @@ name = "kgraph_u...
2023-11-28T10:06:59Z
## Description <!-- Describe your changes in detail --> This PR have 2 changes 1)Transferring routable connectors to shared enums will reduce the redundancy associated with employing Euclid enums. 2)fixing connector code template script ### Additional Changes - [ ] This PR modifies the API contract - [ ] ...
c0116db271f6afc1b93c04705209bfc346228c68
By running `cargo clippy --all-features --all-targets`
[ "Cargo.lock", "connector-template/mod.rs", "crates/api_models/src/enums.rs", "crates/api_models/src/routing.rs", "crates/common_enums/Cargo.toml", "crates/common_enums/src/enums.rs", "crates/euclid/src/enums.rs", "crates/euclid/src/frontend/ast.rs", "crates/euclid/src/frontend/dir.rs", "crates/euc...
juspay/hyperswitch
juspay__hyperswitch-3001
Bug: [REFACTOR]: Field Type for OpenBankingUk Payment Method ### :memo: Feature Description - In OpenBankingUk, we had two fields issuer and country. As of now these are mandatory fields. But these fields are not required for all the connector, as I came with connector Volt which don't need these fields in their re...
diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs index bd4c59211e2..5ecbf795ac5 100644 --- a/crates/api_models/src/payments.rs +++ b/crates/api_models/src/payments.rs @@ -1204,10 +1204,10 @@ pub enum BankRedirectData { OpenBankingUk { // Issuer banks #[schema(val...
2023-11-28T10:01:59Z
## Description In OpenBankingUk, we had two fields issuer and country. But these fields are not required for all the connector, I came with connector Volt which don't need these fields in their request so I made these fields optional. ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR...
c05432c0bd70f222c2f898ce2cbb47a46364a490
Using Postman
[ "crates/api_models/src/payments.rs", "crates/router/src/connector/adyen/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-2983
Bug: [FEATURE] receive `card_holder_name` in confirm flow when using token for payment ### Feature Description Currently, even though `card_holder_name` was empty, `/confirm` would occur without any error. But few connectors require `card_holder_name` to be sent. ### Possible Implementation Add new object `CardT...
diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs index 74559f8ed69..acb9bbdd6cd 100644 --- a/crates/api_models/src/payments.rs +++ b/crates/api_models/src/payments.rs @@ -717,6 +717,14 @@ pub struct Card { pub nick_name: Option<Secret<String>>, } +#[derive(Eq, PartialEq, Debug,...
2023-11-25T14:20:31Z
## Description <!-- Describe your changes in detail --> Currently, even though `card_holder_name` was empty, `/confirm` would occur without any error. But few connectors require `card_holder_name` to be sent. This PR includes changes for adding new object `CardToken` in `payment_method_data` object which can be us...
0e66b1b5dcce6dd87c9d743c9eb73d0cd8e330b2
1. Make a payment with saving the card. pass card_holder_name empty while saving ``` curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: dev_u67d5zdpJVfHQ5jRhWXNg5F0Wy8MhzG2STAeHBhIKJowJJxAuVtvwhB2lsL427C8' \ --d...
[ "crates/api_models/src/payments.rs", "crates/router/src/connector/aci/transformers.rs", "crates/router/src/connector/adyen/transformers.rs", "crates/router/src/connector/airwallex/transformers.rs", "crates/router/src/connector/bankofamerica/transformers.rs", "crates/router/src/connector/bluesnap/transform...
juspay/hyperswitch
juspay__hyperswitch-2865
Bug: [REFACTOR] : [Wise] Error Message For Connector Implementation ### :memo: Feature Description - In terms of errors, we are currently throwing a 'not supported' message, which shouldn't be the case as we are yet to decide on the implementation. ### :hammer: Possible Implementation - In order to manage...
diff --git a/crates/router/src/connector/wise/transformers.rs b/crates/router/src/connector/wise/transformers.rs index c481f0c7343..e0fc05c3c89 100644 --- a/crates/router/src/connector/wise/transformers.rs +++ b/crates/router/src/connector/wise/transformers.rs @@ -11,7 +11,7 @@ type Error = error_stack::Report<errors::...
2023-11-22T14:59:35Z
## Description <!-- Describe your changes in detail --> ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application configuration/environment variables <!-- Provide links to the files with corresponding changes. Followin...
6c15fc312345ed9520accb4d02b12688f98ba1a1
[ "crates/router/src/connector/wise/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-2866
Bug: [REFACTOR] : [Worldline] Error Message For Connector Implementation ### :memo: Feature Description - In terms of errors, we are currently throwing a 'not supported' message, which shouldn't be the case as we are yet to decide on the implementation. ### :hammer: Possible Implementation - In order to m...
diff --git a/crates/router/src/connector/worldline/transformers.rs b/crates/router/src/connector/worldline/transformers.rs index 6cb8862f69b..049453e325a 100644 --- a/crates/router/src/connector/worldline/transformers.rs +++ b/crates/router/src/connector/worldline/transformers.rs @@ -306,10 +306,9 @@ impl TryFrom<utils...
2023-11-16T17:13:09Z
## Description <!-- Describe your changes in detail --> ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application configuration/environment variables <!-- Provide links to the files with corresponding changes. Followin...
94897d841e25d0be8debdfe1ec674f28848e2ad4
No test cases required. As In this PR only error message have been changed from Not Supported error message to NotImplemented error message.
[ "crates/router/src/connector/worldline/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-2895
Bug: [FEATURE]: Add ability to add connectors without any auth details ### Feature Description Ability to integrate a connector without any auth details. But it need not be used for routing until we get the auth details. ### Possible Implementation Create a new auth_type, which doesn't need any details and use th...
diff --git a/crates/api_models/src/admin.rs b/crates/api_models/src/admin.rs index 6b9928734ce..efde4a04832 100644 --- a/crates/api_models/src/admin.rs +++ b/crates/api_models/src/admin.rs @@ -609,6 +609,9 @@ pub struct MerchantConnectorCreate { pub profile_id: Option<String>, pub pm_auth_config: Option<ser...
2023-11-16T06:18:57Z
## Description <!-- Describe your changes in detail --> Add a new `auth_type` called `TemporaryAuth` which describes that auth details are not yet received. When using this `auth_type` the connector status will be `inactive` and mca will be disabled. ### Additional Changes - [x] This PR modifies the API contra...
94897d841e25d0be8debdfe1ec674f28848e2ad4
Postman. Payment Connector - Create and Payment Connector - Update now supports a new auth type called `TemporaryAuth` and a new field `status`. ``` curl --location 'http://localhost:8080/account/merchant_1700133263/connectors' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ ...
[ "crates/api_models/src/admin.rs", "crates/common_enums/src/enums.rs", "crates/diesel_models/src/enums.rs", "crates/diesel_models/src/merchant_connector_account.rs", "crates/diesel_models/src/schema.rs", "crates/kgraph_utils/benches/evaluation.rs", "crates/kgraph_utils/src/mca.rs", "crates/router/src/c...
juspay/hyperswitch
juspay__hyperswitch-2860
Bug: [REFACTOR] : [Shift4] Error Message For Connector Implementation ### :memo: Feature Description - In terms of errors, we are currently throwing a 'not supported' message, which shouldn't be the case as we are yet to decide on the implementation. ### :hammer: Possible Implementation - In order to mana...
diff --git a/crates/router/src/connector/shift4/transformers.rs b/crates/router/src/connector/shift4/transformers.rs index 606da2129fb..ce68aad25c5 100644 --- a/crates/router/src/connector/shift4/transformers.rs +++ b/crates/router/src/connector/shift4/transformers.rs @@ -168,10 +168,9 @@ impl<T> TryFrom<&types::Router...
2023-11-15T17:32:45Z
## Description <!-- Describe your changes in detail --> ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application configuration/environment variables <!-- Provide links to the files with corresponding changes. Followin...
2e2dbe47156695beff6c0e4c800c0036fc426ed0
No test cases required. As In this PR only error message have been changed from Not Supported error message to NotImplemented error message.
[ "crates/router/src/connector/shift4/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-2862
Bug: [REFACTOR] : [Stax] Error Message For Connector Implementation ### :memo: Feature Description - In terms of errors, we are currently throwing a 'not supported' message, which shouldn't be the case as we are yet to decide on the implementation. ### :hammer: Possible Implementation - In order to manage...
diff --git a/crates/router/src/connector/stax/transformers.rs b/crates/router/src/connector/stax/transformers.rs index bb37bf1fc9e..5aa0949a09c 100644 --- a/crates/router/src/connector/stax/transformers.rs +++ b/crates/router/src/connector/stax/transformers.rs @@ -63,10 +63,9 @@ impl TryFrom<&StaxRouterData<&types::Pay...
2023-11-15T17:15:18Z
## Description <!-- Describe your changes in detail --> ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application configuration/environment variables <!-- Provide links to the files with corresponding changes. Followin...
37ab392488350c22d1d1352edc90f46af25d40be
No test cases required. As In this PR only error message have been changed from Not Supported error message to NotImplemented error message.
[ "crates/router/src/connector/stax/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-2864
Bug: [REFACTOR] : [Volt] Error Message For Connector Implementation ### :memo: Feature Description - In terms of errors, we are currently throwing a 'not supported' message, which shouldn't be the case as we are yet to decide on the implementation. ### :hammer: Possible Implementation - In order to manage...
diff --git a/crates/router/src/connector/volt/transformers.rs b/crates/router/src/connector/volt/transformers.rs index efed7c797c7..6f4c67dce8a 100644 --- a/crates/router/src/connector/volt/transformers.rs +++ b/crates/router/src/connector/volt/transformers.rs @@ -130,10 +130,9 @@ impl TryFrom<&VoltRouterData<&types::P...
2023-11-15T17:01:47Z
## Description <!-- Describe your changes in detail --> ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application configuration/environment variables <!-- Provide links to the files with corresponding changes. Followin...
37ab392488350c22d1d1352edc90f46af25d40be
No test cases required. As In this PR only error message have been changed from Not Supported error message to NotImplemented error message.
[ "crates/router/src/connector/volt/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-2858
Bug: [REFACTOR] : [Paypal] Error Message For Connector Implementation ### :memo: Feature Description - In terms of errors, we are currently throwing a 'not supported' message, which shouldn't be the case as we are yet to decide on the implementation. ### :hammer: Possible Implementation - In order to mana...
diff --git a/crates/router/src/connector/paypal/transformers.rs b/crates/router/src/connector/paypal/transformers.rs index baf8f48279d..88595585fe1 100644 --- a/crates/router/src/connector/paypal/transformers.rs +++ b/crates/router/src/connector/paypal/transformers.rs @@ -396,11 +396,9 @@ fn get_payment_source( ...
2023-11-15T16:31:13Z
## Description Refactored `NotSupported` Error calls to `NotImplemented` in the Paypal transformer. ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application configuration/environment variables <!-- Provide links to the fil...
94cd7b689758a71e13a3eaa655335e658d13afc8
Make any payment for Paypal connector for any PM which is not implemented, and see for the error message - it should be payment method not implemented
[ "crates/router/src/connector/paypal/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-2861
Bug: [REFACTOR] : [Square] Error Message For Connector Implementation ### :memo: Feature Description - In terms of errors, we are currently throwing a 'not supported' message, which shouldn't be the case as we are yet to decide on the implementation. ### :hammer: Possible Implementation - In order to mana...
diff --git a/crates/router/src/connector/square/transformers.rs b/crates/router/src/connector/square/transformers.rs index e159b1d8ade..1e5501575ad 100644 --- a/crates/router/src/connector/square/transformers.rs +++ b/crates/router/src/connector/square/transformers.rs @@ -4,7 +4,7 @@ use masking::{ExposeInterface, Peek...
2023-11-15T11:06:58Z
## Description Consistent error messages for not implemented payment method. ## Motivation and Context Resolves #2861 ## How did you test it? payment connector create ``` { "connector_type": "fiz_operations", "connector_name": "volt", "connector_account_details": { "auth_type": ...
0666d814af93045ff23c85d8fd796da08cd5749b
payment connector create ``` { "connector_type": "fiz_operations", "connector_name": "volt", "connector_account_details": { "auth_type": "MultiAuthKey", "api_key": "{{connector_api_key}}", "api_secret": "{{connector_api_secret}}", "key1": "{{connector_key1}}", ...
[ "crates/router/src/connector/square/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-1973
Bug: [FEATURE] Use empty enums instead of unit structs for PII masking strategies ### Feature Description Currently, we make use of unit structs that implement the `masking::Strategy<T>` trait to represent PII masking strategies. We would like to replace these with empty enums instead (So `struct MyStrategy;` bec...
diff --git a/crates/cards/src/validate.rs b/crates/cards/src/validate.rs index db6957057ec..d083a420a1e 100644 --- a/crates/cards/src/validate.rs +++ b/crates/cards/src/validate.rs @@ -72,7 +72,7 @@ impl<'de> Deserialize<'de> for CardNumber { } } -pub struct CardNumberStrategy; +pub enum CardNumberStrategy {} ...
2023-11-15T09:48:54Z
as per #1973 ## Description Use empty enums as strategy type parameter, instead of unit structs, to prevent instantiation. ### Additional Changes no ## Motivation and Context #1973 ## How did you test it? `cargo clippy --all-features` Assuming existing tests should catch side effects if any...
54d6b1083fab5d2b0c7637c150524460a16a3fec
`cargo clippy --all-features` Assuming existing tests should catch side effects if any.
[ "crates/cards/src/validate.rs", "crates/common_utils/src/pii.rs", "crates/masking/src/secret.rs", "crates/masking/src/strategy.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3003
Bug: [BUG]: [Dlocal] connector transaction id fix ### Bug Description The Dlocal connector Transaction ID wasn't correctly populated, causing failures in subsequent operations like capture, refund, and 3DS redirection. ### Expected Behavior Transaction id should be mapped to `item.response.id` in connector respon...
diff --git a/crates/router/src/connector/dlocal/transformers.rs b/crates/router/src/connector/dlocal/transformers.rs index 668a335cce8..66cf413e991 100644 --- a/crates/router/src/connector/dlocal/transformers.rs +++ b/crates/router/src/connector/dlocal/transformers.rs @@ -302,7 +302,7 @@ pub struct DlocalPaymentsRespon...
2023-11-14T19:49:53Z
## Description - Fix: Dlocal Connector Transaction ID Population Issue ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application configuration/environment variables <!-- Provide links to the files with corresponding chang...
496245d990e123b626089e70c848856ace295fb5
Executed the following test scenario using the Postman collection: - Initiated a 3DS-authorized transaction - Successfully completed the authorization process - Captured the payment" <img width="1512" alt="Dlocal capture" src="https://github.com/juspay/hyperswitch/assets/50401745/711a23ce-05d3-43a6-828b-db2d7ca77...
[ "crates/router/src/connector/dlocal/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-2855
Bug: [REFACTOR] : [Nuvei] Error Message For Connector Implementation ### :memo: Feature Description - In terms of errors, we are currently throwing a 'not supported' message, which shouldn't be the case as we are yet to decide on the implementation. ### :hammer: Possible Implementation - In order to manag...
diff --git a/crates/router/src/connector/nuvei/transformers.rs b/crates/router/src/connector/nuvei/transformers.rs index c23114e2a96..3c9686c4e22 100644 --- a/crates/router/src/connector/nuvei/transformers.rs +++ b/crates/router/src/connector/nuvei/transformers.rs @@ -623,11 +623,9 @@ impl TryFrom<api_models::enums::Ba...
2023-11-13T08:52:39Z
## Description <!-- Describe your changes in detail --> - Fix issue: #2855 - Changes to be made: update the error message - File changed: **```transformers.rs```** (crates/router/src/connector/nuvei/transformers.rs) ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the d...
f88eee7362be2cc3e8e8dc2bb7bfd263892ff01e
[ "crates/router/src/connector/nuvei/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-2842
Bug: [REFACTOR] : [Multisafepay] Error Message For Connector Implementation ### :memo: Feature Description - In terms of errors, we are currently throwing a 'not supported' message, which shouldn't be the case as we are yet to decide on the implementation. ### :hammer: Possible Implementation - In order t...
diff --git a/crates/router/src/connector/multisafepay/transformers.rs b/crates/router/src/connector/multisafepay/transformers.rs index 1780b77379c..fb62643d667 100644 --- a/crates/router/src/connector/multisafepay/transformers.rs +++ b/crates/router/src/connector/multisafepay/transformers.rs @@ -262,10 +262,9 @@ impl T...
2023-11-11T20:15:57Z
## Description <!-- Describe your changes in detail --> ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application configuration/environment variables <!-- Provide links to the files with corresponding changes. Followin...
de8e31b70d9b3c11e268cd1deffa71918dc4270d
[ "crates/router/src/connector/multisafepay/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-2841
Bug: [REFACTOR] : [Helcim] Error Message For Connector Implementation ### :memo: Feature Description - In terms of errors, we are currently throwing a 'not supported' message, which shouldn't be the case as we are yet to decide on the implementation. ### :hammer: Possible Implementation - In order to mana...
diff --git a/crates/router/src/connector/helcim/transformers.rs b/crates/router/src/connector/helcim/transformers.rs index dc38b2eeb25..1a5a8baa7ee 100644 --- a/crates/router/src/connector/helcim/transformers.rs +++ b/crates/router/src/connector/helcim/transformers.rs @@ -143,10 +143,9 @@ impl TryFrom<&types::SetupMand...
2023-11-11T20:11:13Z
## Description <!-- Describe your changes in detail --> ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application configuration/environment variables <!-- Provide links to the files with corresponding changes. Followin...
bc79d522c30aa036378cf1e01354c422585cc226
[ "crates/router/src/connector/helcim/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-2844
Bug: [REFACTOR] : [Noon] Error Message For Connector Implementation ### :memo: Feature Description - In terms of errors, we are currently throwing a 'not supported' message, which shouldn't be the case as we are yet to decide on the implementation. ### :hammer: Possible Implementation - In order to manage...
diff --git a/crates/router/src/connector/noon/transformers.rs b/crates/router/src/connector/noon/transformers.rs index ee06cd064be..8bb3a96a3ca 100644 --- a/crates/router/src/connector/noon/transformers.rs +++ b/crates/router/src/connector/noon/transformers.rs @@ -275,10 +275,9 @@ impl TryFrom<&types::PaymentsAuthorize...
2023-11-11T20:02:31Z
## Description <!-- Describe your changes in detail --> ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application configuration/environment variables <!-- Provide links to the files with corresponding changes. Followin...
1828ea6187c46d9c18dc8a0b5224387403b998e2
Make any payment for Noon connector for any PM which is not implemented, and see for the error message - it should be payment method not implemented
[ "crates/router/src/connector/noon/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-2843
Bug: [REFACTOR] : [NMI] Error Message For Connector Implementation ### :memo: Feature Description - In terms of errors, we are currently throwing a 'not supported' message, which shouldn't be the case as we are yet to decide on the implementation. ### :hammer: Possible Implementation - In order to manage ...
diff --git a/crates/router/src/connector/nmi/transformers.rs b/crates/router/src/connector/nmi/transformers.rs index fcf35bfbe37..5b486aae600 100644 --- a/crates/router/src/connector/nmi/transformers.rs +++ b/crates/router/src/connector/nmi/transformers.rs @@ -494,10 +494,9 @@ impl TryFrom<&api_models::payments::Paymen...
2023-11-11T20:00:09Z
## Description <!-- Describe your changes in detail --> ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application configuration/environment variables <!-- Provide links to the files with corresponding changes. Followin...
db3d53ff1d8b42d107fafe7a6efe7ec9f155d5a0
Make any payment for NMI for any PM which is not implemented, and see for the error message - it should be payment method not implemented
[ "crates/router/src/connector/nmi/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-2840
Bug: [REFACTOR] : [Forte] Error Message For Connector Implementation ### :memo: Feature Description - In terms of errors, we are currently throwing a 'not supported' message, which shouldn't be the case as we are yet to decide on the implementation. ### :hammer: Possible Implementation - In order to manag...
diff --git a/crates/router/src/connector/forte/transformers.rs b/crates/router/src/connector/forte/transformers.rs index 4bb354f6cda..56555a0d97e 100644 --- a/crates/router/src/connector/forte/transformers.rs +++ b/crates/router/src/connector/forte/transformers.rs @@ -54,10 +54,9 @@ impl TryFrom<utils::CardIssuer> for ...
2023-11-11T19:54:50Z
## Description <!-- Describe your changes in detail --> ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application configuration/environment variables <!-- Provide links to the files with corresponding changes. Followin...
bc79d522c30aa036378cf1e01354c422585cc226
[ "crates/router/src/connector/forte/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-2839
Bug: [REFACTOR] : [CryptoPay] Error Message For Connector Implementation ### :memo: Feature Description - In terms of errors, we are currently throwing a 'not supported' message, which shouldn't be the case as we are yet to decide on the implementation. ### :hammer: Possible Implementation - In order to m...
diff --git a/crates/router/src/connector/cryptopay/transformers.rs b/crates/router/src/connector/cryptopay/transformers.rs index 3af604c786b..4102945b201 100644 --- a/crates/router/src/connector/cryptopay/transformers.rs +++ b/crates/router/src/connector/cryptopay/transformers.rs @@ -82,10 +82,9 @@ impl TryFrom<&Crypto...
2023-11-11T19:51:04Z
## Description <!-- Describe your changes in detail --> ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application configuration/environment variables <!-- Provide links to the files with corresponding changes. Followin...
bc79d522c30aa036378cf1e01354c422585cc226
[ "crates/router/src/connector/cryptopay/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-2838
Bug: [REFACTOR] : [Adyen] Error Message For Connector Implementation ### :memo: Feature Description - In terms of errors, we are currently throwing a 'not supported' message, which shouldn't be the case as we are yet to decide on the implementation. ### :hammer: Possible Implementation - In order to manag...
diff --git a/crates/router/src/connector/adyen/transformers.rs b/crates/router/src/connector/adyen/transformers.rs index 1eede78503b..aa5cd2ec695 100644 --- a/crates/router/src/connector/adyen/transformers.rs +++ b/crates/router/src/connector/adyen/transformers.rs @@ -752,10 +752,9 @@ impl TryFrom<&api_enums::BankNames...
2023-11-11T19:43:05Z
## Description <!-- Describe your changes in detail --> ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application configuration/environment variables <!-- Provide links to the files with corresponding changes. Followin...
708cce926125a29b406db48cf0ebd35b217927d4
Test a Payment Method which is not implemented It should give Not implemented error This is an Crypto payment request. ``` { "amount": 6540, "currency": "USD", "confirm": true, "capture_method": "automatic", "capture_on": "2022-09-10T10:11:12Z", "amount_to_capture": 6540, "cus...
[ "crates/router/src/connector/adyen/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-2836
Bug: [REFACTOR] : [ACI] Error Message For Connector Implementation ### :memo: Feature Description - In terms of errors, we are currently throwing a 'not supported' message, which shouldn't be the case as we are yet to decide on the implementation. ### :hammer: Possible Implementation - In order to manage...
diff --git a/crates/router/src/connector/aci/transformers.rs b/crates/router/src/connector/aci/transformers.rs index 9cfb657bdca..8eea6dbb4d5 100644 --- a/crates/router/src/connector/aci/transformers.rs +++ b/crates/router/src/connector/aci/transformers.rs @@ -410,10 +410,9 @@ impl TryFrom<&AciRouterData<&types::Paymen...
2023-11-11T07:35:43Z
## Description <!-- Describe your changes in detail --> ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application configuration/environment variables ## Motivation and Context ## How did you test it? Manual check...
bc79d522c30aa036378cf1e01354c422585cc226
Manual checking
[ "crates/router/src/connector/aci/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-2833
Bug: [FEATURE] Add support for profile-specific default routing fallback ### Feature Description Currently every merchant has a default fallback which is a list of all of their configured connectors. We now want to make this profile-specific, i.e. each profile will have an associated default fallback that is a lis...
diff --git a/crates/api_models/src/events/routing.rs b/crates/api_models/src/events/routing.rs index 5eca01acc6f..a09735bc572 100644 --- a/crates/api_models/src/events/routing.rs +++ b/crates/api_models/src/events/routing.rs @@ -1,8 +1,9 @@ use common_utils::events::{ApiEventMetric, ApiEventsType}; use crate::routi...
2023-11-08T07:55:27Z
## Description `default-fallbacks` are defined specific to profile i.e every profile will correspond to different fallbacks and while deriving the fallbacks we are doing that based on profile. ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This ...
f88eee7362be2cc3e8e8dc2bb7bfd263892ff01e
The tests will be same as this PR: https://github.com/juspay/hyperswitch-cloud/pull/2949
[ "crates/api_models/src/events/routing.rs", "crates/api_models/src/routing.rs", "crates/router/Cargo.toml", "crates/router/src/core/admin.rs", "crates/router/src/core/payments/routing.rs", "crates/router/src/core/routing.rs", "crates/router/src/routes/app.rs", "crates/router/src/routes/routing.rs" ]
juspay/hyperswitch
juspay__hyperswitch-2790
Bug: [BUG] Newly created business profile takes the value of `routing_algorithm` from the `merchant_account.routing_algorithm` column ### Bug Description When creating a new business profile, the value of `routing_algorithm` is taken from the merchant account's `routing_algorithm` field which may contain some stale...
diff --git a/crates/router/src/types/api/admin.rs b/crates/router/src/types/api/admin.rs index 6bbe9149f4d..fe99d084223 100644 --- a/crates/router/src/types/api/admin.rs +++ b/crates/router/src/types/api/admin.rs @@ -124,9 +124,10 @@ impl ForeignTryFrom<(domain::MerchantAccount, BusinessProfileCreate)> ...
2023-11-06T06:36:58Z
## Description This PR updates the code to set the value of the `business_profile.routing_algorithm` column to a default value during creation of business profile in DB. ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies applicati...
ab3dac79b4f138cd1f60a9afc0635dcc137a4a05
Local, compiler-guided
[ "crates/router/src/types/api/admin.rs" ]
juspay/hyperswitch
juspay__hyperswitch-2237
Bug: [FEATURE]: [Noon] Currency Unit Conversion ### :memo: Feature Description - Each currency can be described in terms of base or minor units. - For instance, when dealing with USD currency, the Cent is considered as the minor unit, while the Dollar is considered the base unit. - In Hyperswitch, the amount valu...
diff --git a/crates/router/src/connector/noon.rs b/crates/router/src/connector/noon.rs index 45792864255..3bfcbbc6169 100644 --- a/crates/router/src/connector/noon.rs +++ b/crates/router/src/connector/noon.rs @@ -114,6 +114,10 @@ impl ConnectorCommon for Noon { "noon" } + fn get_currency_unit(&self) ...
2023-11-05T11:34:36Z
## Description - Addressing Issue #2237 - Modified two files in `hyperswitch/crates/router/src/connector/` - `noon.rs` - Implement `get_currency_unit` function - Modify `ConnectorIntegration` implementations for `Noon` - `noon/transformers.rs` - Implement `NoonRouterData<T>` structure and funct...
8e484ddab8d3f4463299c7f7e8ce75b8dd628599
[ "crates/router/src/connector/noon.rs", "crates/router/src/connector/noon/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-2198
Bug: [FEATURE]: [ACI] Currency Unit Conversion ### :memo: Feature Description - Each currency can be described in terms of base or minor units. - For instance, when dealing with USD currency, the Cent is considered as the minor unit, while the Dollar is considered the base unit. - In Hyperswitch, the amount value...
diff --git a/crates/router/src/connector/aci.rs b/crates/router/src/connector/aci.rs index 0a6e0d8a609..0e325a04ddb 100644 --- a/crates/router/src/connector/aci.rs +++ b/crates/router/src/connector/aci.rs @@ -30,7 +30,9 @@ impl ConnectorCommon for Aci { fn id(&self) -> &'static str { "aci" } - + f...
2023-10-31T17:15:03Z
## Description <!-- Describe your changes in detail --> ### Additional Changes - [ ] This PR modifies the API contract - [ ] This PR modifies the database schema - [ ] This PR modifies application configuration/environment variables <!-- Provide links to the files with corresponding changes. Followin...
42261a5306bb99d3e20eb3aa734a895e589b1d94
[ "crates/router/src/connector/aci.rs", "crates/router/src/connector/aci/transformers.rs" ]