id
int64 953M
3.35B
| number
int64 2.72k
7.75k
| title
stringlengths 1
290
| state
stringclasses 2
values | created_at
timestamp[s]date 2021-07-26 12:21:17
2025-08-23 00:18:43
| updated_at
timestamp[s]date 2021-07-26 13:27:59
2025-08-23 12:34:39
| closed_at
timestamp[s]date 2021-07-26 13:27:59
2025-08-20 16:35:55
⌀ | html_url
stringlengths 49
51
| pull_request
dict | user_login
stringlengths 3
26
| is_pull_request
bool 2
classes | comments
listlengths 0
30
|
|---|---|---|---|---|---|---|---|---|---|---|---|
1,064,661,212
| 3,324
|
Can't import `datasets` in python 3.10
|
closed
| 2021-11-26T16:06:14
| 2021-11-26T16:31:23
| 2021-11-26T16:31:23
|
https://github.com/huggingface/datasets/issues/3324
| null |
lhoestq
| false
|
[] |
1,064,660,452
| 3,323
|
Fix wrongly converted assert
|
closed
| 2021-11-26T16:05:39
| 2021-11-26T16:44:12
| 2021-11-26T16:44:11
|
https://github.com/huggingface/datasets/pull/3323
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3323",
"html_url": "https://github.com/huggingface/datasets/pull/3323",
"diff_url": "https://github.com/huggingface/datasets/pull/3323.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3323.patch",
"merged_at": "2021-11-26T16:44:11"
}
|
eliasws
| true
|
[
"Closes #3327 "
] |
1,064,429,705
| 3,322
|
Add missing tags to XTREME
|
closed
| 2021-11-26T12:37:05
| 2021-11-29T13:40:07
| 2021-11-29T13:40:06
|
https://github.com/huggingface/datasets/pull/3322
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3322",
"html_url": "https://github.com/huggingface/datasets/pull/3322",
"diff_url": "https://github.com/huggingface/datasets/pull/3322.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3322.patch",
"merged_at": "2021-11-29T13:40:06"
}
|
mariosasko
| true
|
[] |
1,063,858,386
| 3,321
|
Update URL of tatoeba subset of xtreme
|
closed
| 2021-11-25T18:42:31
| 2021-11-26T10:30:30
| 2021-11-26T10:30:30
|
https://github.com/huggingface/datasets/pull/3321
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3321",
"html_url": "https://github.com/huggingface/datasets/pull/3321",
"diff_url": "https://github.com/huggingface/datasets/pull/3321.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3321.patch",
"merged_at": "2021-11-26T10:30:29"
}
|
mariosasko
| true
|
[
"<s>To be more precise: `os.path.join` is replaced on-the-fly by `xjoin` anyway with patching, to extend it to remote files</s>",
"Oh actually just ignore what I said: they were used to concatenate URLs, which is not recommended. Let me fix that again by appending using `+`"
] |
1,063,531,992
| 3,320
|
Can't get tatoeba.rus dataset
|
closed
| 2021-11-25T12:31:11
| 2021-11-26T10:30:29
| 2021-11-26T10:30:29
|
https://github.com/huggingface/datasets/issues/3320
| null |
mmg10
| false
|
[] |
1,062,749,654
| 3,319
|
Add push_to_hub docs
|
closed
| 2021-11-24T18:21:11
| 2021-11-25T14:47:46
| 2021-11-25T14:47:46
|
https://github.com/huggingface/datasets/pull/3319
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3319",
"html_url": "https://github.com/huggingface/datasets/pull/3319",
"diff_url": "https://github.com/huggingface/datasets/pull/3319.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3319.patch",
"merged_at": "2021-11-25T14:47:46"
}
|
lhoestq
| true
|
[
"Looks good to me! :)\r\n\r\nMaybe we can mention that users can also set the `private` argument if they want to keep their dataset private? It would lead nicely into the next section on Privacy.",
"Thanks for your comments, I fixed the capitalization for consistency and added an passage to mention the `private` parameter and to have a nice transition to the Privacy section :)\r\n\r\nI also added the login instruction that was missing before the user can actually upload a dataset."
] |
1,062,369,717
| 3,318
|
Finish transition to PyArrow 3.0.0
|
closed
| 2021-11-24T12:30:14
| 2021-11-24T15:35:05
| 2021-11-24T15:35:04
|
https://github.com/huggingface/datasets/pull/3318
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3318",
"html_url": "https://github.com/huggingface/datasets/pull/3318",
"diff_url": "https://github.com/huggingface/datasets/pull/3318.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3318.patch",
"merged_at": "2021-11-24T15:35:04"
}
|
mariosasko
| true
|
[] |
1,062,284,447
| 3,317
|
Add desc parameter to Dataset filter method
|
closed
| 2021-11-24T11:01:36
| 2022-01-05T18:31:24
| 2022-01-05T18:31:24
|
https://github.com/huggingface/datasets/issues/3317
| null |
vblagoje
| false
|
[
"Hi,\r\n\r\n`Dataset.map` allows more generic transforms compared to `Dataset.filter`, which purpose is very specific (to filter examples based on a condition). That's why I don't think we need the `desc` parameter there for consistency. #3196 has added descriptions to the `Dataset` methods that call `.map` internally, but not for the `filter` method, so we should do that.\r\n\r\nDo you have a description in mind? Maybe `\"Filtering the dataset\"` or `\"Filtering the indices\"`? If yes, feel free to open a PR.",
"I'm personally ok with adding the `desc` parameter actually. Let's say you have different filters, it can be nice to differentiate between the different filters when they're running no ?",
"@mariosasko the use case is filtering of a dataset prior to tokenization and subsequent training. As the dataset is huge it's just a matter of giving a user (model trainer) some feedback on what's going on. Otherwise, feedback is given for all steps in training preparation and not for filtering and the filtering in my use case lasts about 4-5 minutes. And yes, if there are more filtering stages, as @lhoestq pointed out, it would be nice to give some feedback. I thought desc is there already and got confused when I got the script error. ",
"I don't have a strong opinion on that, so having `desc` as a parameter is also OK."
] |
1,062,185,822
| 3,316
|
Add RedCaps dataset
|
closed
| 2021-11-24T09:23:02
| 2022-01-12T14:13:15
| 2022-01-12T14:13:15
|
https://github.com/huggingface/datasets/issues/3316
| null |
albertvillanova
| false
|
[] |
1,061,678,452
| 3,315
|
Removing query params for dynamic URL caching
|
closed
| 2021-11-23T20:24:12
| 2021-11-25T14:44:32
| 2021-11-25T14:44:31
|
https://github.com/huggingface/datasets/pull/3315
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3315",
"html_url": "https://github.com/huggingface/datasets/pull/3315",
"diff_url": "https://github.com/huggingface/datasets/pull/3315.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3315.patch",
"merged_at": "2021-11-25T14:44:31"
}
|
anton-l
| true
|
[
"IMO it makes more sense to have `ignore_url_params` as an attribute of `DownloadConfig` to avoid defining a new argument in `DownloadManger`'s methods.",
"@mariosasko that would make sense to me too, but it seems like `DownloadConfig` wasn't intended to be modified from a dataset loading script. @lhoestq wdyt?",
"We can expose `DownloadConfig` as a property of `DownloadManager`, and then in the script before the download call we could do: `dl_manager.download_config.ignore_url_params = True`. But yes, let's hear what Quentin thinks.",
"Oh indeed that's a great idea. This parameter is similar to others like `download_config.use_etag` that defines the behavior of the download and caching, so it's better if we have it there, and expose the `download_config`",
"Implemented it via `dl_manager.download_config.ignore_url_params` now, and also added a usage example above :) "
] |
1,061,448,227
| 3,314
|
Adding arg to pass process rank to `map`
|
closed
| 2021-11-23T15:55:21
| 2021-11-24T11:54:13
| 2021-11-24T11:54:13
|
https://github.com/huggingface/datasets/pull/3314
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3314",
"html_url": "https://github.com/huggingface/datasets/pull/3314",
"diff_url": "https://github.com/huggingface/datasets/pull/3314.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3314.patch",
"merged_at": "2021-11-24T11:54:13"
}
|
TevenLeScao
| true
|
[
"Some commits seem to be there twice (made the mistake of rebasing because I wasn't sure whether the doc had changed), is this an issue @lhoestq ?"
] |
1,060,933,392
| 3,313
|
TriviaQA License Mismatch
|
closed
| 2021-11-23T08:00:15
| 2021-11-29T11:24:21
| 2021-11-29T11:24:21
|
https://github.com/huggingface/datasets/issues/3313
| null |
akhilkedia
| false
|
[
"Hi ! You're completely right, this must be mentioned in the dataset card.\r\nIf you're interesting in contributing, feel free to open a pull request to mention this in the `trivia_qa` dataset card in the \"Licensing Information\" section at https://github.com/huggingface/datasets/blob/master/datasets/trivia_qa/README.md"
] |
1,060,440,346
| 3,312
|
add bl books genre dataset
|
closed
| 2021-11-22T17:54:50
| 2021-12-02T16:10:29
| 2021-12-02T16:07:47
|
https://github.com/huggingface/datasets/pull/3312
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3312",
"html_url": "https://github.com/huggingface/datasets/pull/3312",
"diff_url": "https://github.com/huggingface/datasets/pull/3312.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3312.patch",
"merged_at": "2021-12-02T16:07:47"
}
|
davanstrien
| true
|
[
"To fix the CI, feel free to run the `make style` command to format the code.\r\n\r\nThen it also looks like the dummy_data.zip archives are all empty, which makes the tests fail. Can you try regenerating them ? They should have one file inside which is a dummy version of the file at https://bl.iro.bl.uk/downloads/36c7cd20-c8a7-4495-acbe-469b9132c6b1?locale=en",
"@lhoestq, thanks for that feedback. \r\n\r\nI should have made most of these changes now. The `--auto_generate` flag wasn't working because the file wasn't downloaded with a `.csv` extension. I used `--match_text_files \"*\"` to get around this. Because there is a lot of data that isn't annotated using the default line number for the dummy data causes the `annotated_raw` and the `title_genre_classifiction` configs to fail because they don't generate any examples — bumping the line numbers to `250` fixes this. This does make the dummy data a bit bigger, though. \r\n\r\nThe total directory size for the dataset is now `150kb`. Is this okay, or do you want me to generate the dummy data manually instead? ",
"Hi ! yes 150kB is fine :)\r\nFeel free to push your new dummy_data.zip files (I think the current one are still the empty ones)",
"@lhoestq I've pushed those dummy files now and added your other suggestions.",
"The CI failure is unrelated to this PR, merging :)",
"@lhoestq, thanks for all your help with this pull request 😀"
] |
1,060,387,957
| 3,311
|
Add WebSRC
|
open
| 2021-11-22T16:58:33
| 2021-11-22T16:58:33
| null |
https://github.com/huggingface/datasets/issues/3311
| null |
NielsRogge
| false
|
[] |
1,060,098,104
| 3,310
|
Fatal error condition occurred in aws-c-io
|
closed
| 2021-11-22T12:27:54
| 2023-02-08T10:31:05
| 2021-11-29T22:22:37
|
https://github.com/huggingface/datasets/issues/3310
| null |
Crabzmatic
| false
|
[
"Hi ! Are you having this issue only with this specific dataset, or it also happens with other ones like `squad` ?",
"@lhoestq It happens also on `squad`. It successfully downloads the whole dataset and then crashes on: \r\n\r\n```\r\nFatal error condition occurred in D:\\bld\\aws-c-io_1633633258269\\work\\source\\event_loop.c:74: aws_thread_launch(&cleanup_thread, s_event_loop_destroy_async_thread_fn, el_group, &thread_options) == AWS_OP_SUCCESS\r\nExiting Application\r\n```\r\n\r\nI tested it on Ubuntu and its working OK. Didn't test on non-preview version of Windows 11, `Windows-10-10.0.22504-SP0` is a preview version, not sure if this is causing it.",
"I see the same error in Windows-10.0.19042 as of a few days ago:\r\n\r\n`Fatal error condition occurred in D:\\bld\\aws-c-io_1633633258269\\work\\source\\event_loop.c:74: aws_thread_launch(&cleanup_thread, s_event_loop_destroy_async_thread_fn, el_group, &thread_options) == AWS_OP_SUCCESS`\r\n\r\npython 3.8.12 h7840368_2_cpython conda-forge\r\nboto3 1.20.11 pyhd8ed1ab_0 conda-forge\r\nbotocore 1.23.11 pyhd8ed1ab_0 conda-forge\r\n\r\n...but I am not using `datasets` (although I might take a look now that I know about it!)\r\n\r\nThe error has occurred a few times over the last two days, but not consistently enough for me to get it with DEBUG. If there is any interest I can report back here, but it seems not unique to `datasets`.",
"I'm not sure what `datasets` has to do with a crash that seems related to `aws-c-io`, could it be an issue with your environment ?",
"> I'm not sure what `datasets` has to do with a crash that seems related to `aws-c-io`, could it be an issue with your environment ?\r\n\r\nAgreed, this issue is not likely a bug in datasets, since I get the identical error without datasets installed.",
"Will close this issue. Bug in `aws-c-io` shouldn't be in `datasets` repo. Nevertheless, it can be useful to know that it happens. Thanks @leehaust @lhoestq ",
"I have also had this issue since a few days, when running scripts using PyCharm in particular, but it does not seem to affect the script from running, only reporting this error at the end of the run.",
"I also get this issue, It appears after my script has finished running. I get the following error message\r\n```\r\nFatal error condition occurred in /home/conda/feedstock_root/build_artifacts/aws-c-io_1637179816120/work/source/event_loop.c:72: aws_thread_launch(&cleanup_thread, s_event_loop_destroy_async_thread_fn, el_group, &thread_options) == AWS_OP_SUCCESS\r\nExiting Application\r\n################################################################################\r\nStack trace:\r\n################################################################################\r\n/home/user_name/conda_envs/env_name/lib/python3.7/site-packages/pyarrow/../../../././libaws-c-common.so.1(aws_backtrace_print+0x59) [0x2aabe0479579]\r\n/home/user_name/conda_envs/env_name/lib/python3.7/site-packages/pyarrow/../../../././libaws-c-common.so.1(aws_fatal_assert+0x48) [0x2aabe04696c8]\r\n/home/user_name/conda_envs/env_name/lib/python3.7/site-packages/pyarrow/../../.././././libaws-c-io.so.1.0.0(+0x13ad3) [0x2aabe0624ad3]\r\n/home/user_name/conda_envs/env_name/lib/python3.7/site-packages/pyarrow/../../../././libaws-c-common.so.1(aws_ref_count_release+0x1d) [0x2aabe047b60d]\r\n/home/user_name/conda_envs/env_name/lib/python3.7/site-packages/pyarrow/../../.././././libaws-c-io.so.1.0.0(+0x113ca) [0x2aabe06223ca]\r\n/home/user_name/conda_envs/env_name/lib/python3.7/site-packages/pyarrow/../../../././libaws-c-common.so.1(aws_ref_count_release+0x1d) [0x2aabe047b60d]\r\n/home/user_name/conda_envs/env_name/lib/python3.7/site-packages/pyarrow/../../../././libaws-crt-cpp.so(_ZN3Aws3Crt2Io15ClientBootstrapD1Ev+0x3a) [0x2aabe041cf5a]\r\n/home/user_name/conda_envs/env_name/lib/python3.7/site-packages/pyarrow/../../.././libaws-cpp-sdk-core.so(+0x5f570) [0x2aabe00eb570]\r\n/lib64/libc.so.6(+0x39ce9) [0x2aaaab835ce9]\r\n/lib64/libc.so.6(+0x39d37) [0x2aaaab835d37]\r\n/lib64/libc.so.6(__libc_start_main+0xfc) [0x2aaaab81e55c]\r\npython(+0x1c721d) [0x55555571b21d]\r\nAborted\r\n```\r\nI don't get this issue when running my code in a container, and it seems more relevant to PyArrow but thought a more complete stack trace might be helpful to someone\r\n",
"I created an issue on JIRA:\r\nhttps://issues.apache.org/jira/browse/ARROW-15141",
"@CallumMcMahon Do you have a small reproducer for this problem on Linux? I can reproduce this on Windows but sadly not with linux.",
"Any updates on this issue? I started receiving the same error a few days ago on the amazon reviews",
"Hi,\r\n\r\nI also ran into this issue, Windows only. It caused our massive binary to minidump left and right, very annoying.\r\nWhen the program is doing an exit, the destructors in the exit-handlers want to do cleanup, leading to code in event_loop.c, on line 73-ish:\r\n\r\nAWS_FATAL_ASSERT(\r\n aws_thread_launch(&cleanup_thread, s_event_loop_destroy_async_thread_fn, el_group, &thread_options) ==\r\n AWS_OP_SUCCESS);\r\n\r\nThe fatal_assert end in an abort/minidump.\r\n\r\nDigging through the code, I found that aws_thread_launch in the Windows version (aws-c-common/source/windows/thread.c) has only ONE reason to return anything other than AWS_OP_SUCCESS:\r\n\r\nreturn aws_raise_error(AWS_ERROR_THREAD_INSUFFICIENT_RESOURCE);\r\n\r\non line 263, when CreateThread fails. Our conclusion was that, apparently, Windows dislikes launching a new thread while already handling the exit-handlers. And while I appreciate the the fatal_assert is there in case of problems, the cure here is worse than the problem.\r\n\r\nI \"fixed\" this in our (Windows) environment by (bluntly) removing the AWS_FATAL_ASSERT. If Windows cannot start a thread, the program is in deep trouble anyway and the chances of that actually happening are acceptable (to us).\r\nThe exit is going to clean up all resources anyway.\r\n\r\nA neater fix would probably be to detect somehow that the program is actually in the process of exiting and then not bother (on windows, anyway) to start a cleanup thread. Alternatively, try to start the thread but not fatal-assert when it fails during exit. Or perhaps Windows can be convinced somehow to start the thread under these circumstances?\r\n\r\n@xhochy : The problem is Windows-only, the aws_thread_launch has two implementations (posix and windows). The problem is in the windows CreateThread which fails.\r\n",
"I also encountered the same problem, but I made an error in the multi gpu training environment on Linux, and the single gpu training environment will not make an error.\r\ni use accelerate package to do multi gpu training.",
"> I also get this issue, It appears after my script has finished running. I get the following error message\r\n> \r\n> ```\r\n> Fatal error condition occurred in /home/conda/feedstock_root/build_artifacts/aws-c-io_1637179816120/work/source/event_loop.c:72: aws_thread_launch(&cleanup_thread, s_event_loop_destroy_async_thread_fn, el_group, &thread_options) == AWS_OP_SUCCESS\r\n> Exiting Application\r\n> ################################################################################\r\n> Stack trace:\r\n> ################################################################################\r\n> /home/user_name/conda_envs/env_name/lib/python3.7/site-packages/pyarrow/../../../././libaws-c-common.so.1(aws_backtrace_print+0x59) [0x2aabe0479579]\r\n> /home/user_name/conda_envs/env_name/lib/python3.7/site-packages/pyarrow/../../../././libaws-c-common.so.1(aws_fatal_assert+0x48) [0x2aabe04696c8]\r\n> /home/user_name/conda_envs/env_name/lib/python3.7/site-packages/pyarrow/../../.././././libaws-c-io.so.1.0.0(+0x13ad3) [0x2aabe0624ad3]\r\n> /home/user_name/conda_envs/env_name/lib/python3.7/site-packages/pyarrow/../../../././libaws-c-common.so.1(aws_ref_count_release+0x1d) [0x2aabe047b60d]\r\n> /home/user_name/conda_envs/env_name/lib/python3.7/site-packages/pyarrow/../../.././././libaws-c-io.so.1.0.0(+0x113ca) [0x2aabe06223ca]\r\n> /home/user_name/conda_envs/env_name/lib/python3.7/site-packages/pyarrow/../../../././libaws-c-common.so.1(aws_ref_count_release+0x1d) [0x2aabe047b60d]\r\n> /home/user_name/conda_envs/env_name/lib/python3.7/site-packages/pyarrow/../../../././libaws-crt-cpp.so(_ZN3Aws3Crt2Io15ClientBootstrapD1Ev+0x3a) [0x2aabe041cf5a]\r\n> /home/user_name/conda_envs/env_name/lib/python3.7/site-packages/pyarrow/../../.././libaws-cpp-sdk-core.so(+0x5f570) [0x2aabe00eb570]\r\n> /lib64/libc.so.6(+0x39ce9) [0x2aaaab835ce9]\r\n> /lib64/libc.so.6(+0x39d37) [0x2aaaab835d37]\r\n> /lib64/libc.so.6(__libc_start_main+0xfc) [0x2aaaab81e55c]\r\n> python(+0x1c721d) [0x55555571b21d]\r\n> Aborted\r\n> ```\r\n> \r\n> I don't get this issue when running my code in a container, and it seems more relevant to PyArrow but thought a more complete stack trace might be helpful to someone\r\n\r\nAny updates for your issue because I'm getting the same one ",
"Potentially related AWS issue: https://github.com/aws/aws-sdk-cpp/issues/1809\r\n\r\nRan into this issue today while training a BPE tokenizer on a dataset.\r\n\r\nTrain code:\r\n\r\n```python\r\n\"\"\"Train a ByteLevelBPETokenizer based on a given dataset. The dataset must be on the HF Hub.\r\nThis script is adaptated from the Transformers example in https://github.com/huggingface/transformers/tree/main/examples/flax/language-modeling\r\n\"\"\"\r\nfrom os import PathLike\r\nfrom pathlib import Path\r\nfrom typing import Sequence, Union\r\n\r\nfrom datasets import load_dataset\r\nfrom tokenizers import ByteLevelBPETokenizer\r\n\r\n\r\ndef train_tokenizer(dataset_name: str = \"oscar\", dataset_config_name: str = \"unshuffled_deduplicated_nl\",\r\n dataset_split: str = \"train\", dataset_textcol: str = \"text\",\r\n vocab_size: int = 50265, min_frequency: int = 2,\r\n special_tokens: Sequence[str] = (\"<s>\", \"<pad>\", \"</s>\", \"<unk>\", \"<mask>\"),\r\n dout: Union[str, PathLike] = \".\"):\r\n # load dataset\r\n dataset = load_dataset(dataset_name, dataset_config_name, split=dataset_split)\r\n # Instantiate tokenizer\r\n tokenizer = ByteLevelBPETokenizer()\r\n\r\n def batch_iterator(batch_size=1024):\r\n for i in range(0, len(dataset), batch_size):\r\n yield dataset[i: i + batch_size][dataset_textcol]\r\n\r\n # Customized training\r\n tokenizer.train_from_iterator(batch_iterator(), vocab_size=vocab_size, min_frequency=min_frequency,\r\n special_tokens=special_tokens)\r\n\r\n # Save to disk\r\n pdout = Path(dout).resolve()\r\n pdout.mkdir(exist_ok=True, parents=True)\r\n tokenizer.save_model(str(pdout))\r\n\r\n\r\ndef main():\r\n import argparse\r\n cparser = argparse.ArgumentParser(description=__doc__, formatter_class=argparse.ArgumentDefaultsHelpFormatter)\r\n\r\n cparser.add_argument(\"dataset_name\", help=\"Name of dataset to use for tokenizer training\")\r\n cparser.add_argument(\"--dataset_config_name\", default=None,\r\n help=\"Name of the config to use for tokenizer training\")\r\n cparser.add_argument(\"--dataset_split\", default=None,\r\n help=\"Name of the split to use for tokenizer training (typically 'train')\")\r\n cparser.add_argument(\"--dataset_textcol\", default=\"text\",\r\n help=\"Name of the text column to use for tokenizer training\")\r\n cparser.add_argument(\"--vocab_size\", type=int, default=50265, help=\"Vocabulary size\")\r\n cparser.add_argument(\"--min_frequency\", type=int, default=2, help=\"Minimal frequency of tokens\")\r\n cparser.add_argument(\"--special_tokens\", nargs=\"+\", default=[\"<s>\", \"<pad>\", \"</s>\", \"<unk>\", \"<mask>\"],\r\n help=\"Special tokens to add. Useful for specific training objectives. Note that if you wish\"\r\n \" to use this tokenizer with a default transformers.BartConfig, then make sure that the\"\r\n \" order of at least these special tokens are correct: BOS (0), padding (1), EOS (2)\")\r\n cparser.add_argument(\"--dout\", default=\".\", help=\"Path to directory to save tokenizer.json file\")\r\n\r\n train_tokenizer(**vars(cparser.parse_args()))\r\n\r\n\r\nif __name__ == \"__main__\":\r\n main()\r\n```\r\n\r\nCommand:\r\n\r\n```sh\r\n$WDIR=\"your_tokenizer\"\r\npython prepare_tokenizer.py dbrd --dataset_config_name plain_text --dataset_split unsupervised --dout $WDIR\r\n```\r\n\r\nOutput:\r\n\r\n```\r\nReusing dataset dbrd (cache/datasets/dbrd/plain_text/3.0.0/2b12e31348489dfe586c2d0f40694e5d9f9454c9468457ac9f1b51abf686eeb3)\r\n[00:00:30] Pre-processing sequences ████████ 0 / 0\r\n[00:00:00] Tokenize words ████████ 333319 / 333319\r\n[00:01:06] Count pairs ████████ 333319 / 333319\r\n[00:00:03] Compute merges ████████ 50004 / 50004\r\n\r\nFatal error condition occurred in /opt/vcpkg/buildtrees/aws-c-io/src/9e6648842a-364b708815.clean/source/event_loop.c:72: aws_thread_launch(&cleanup_thread, s_event_loop_destroy_async_thread_fn, el_group, &thread_options) == AWS_OP_SUCCESS\r\nExiting Application\r\n################################################################################\r\nStack trace:\r\n################################################################################\r\nvenv/lib/python3.9/site-packages/pyarrow/libarrow.so.900(+0x200af06) [0x155106589f06]\r\nvenv/lib/python3.9/site-packages/pyarrow/libarrow.so.900(+0x20028e5) [0x1551065818e5]\r\nvenv/lib/python3.9/site-packages/pyarrow/libarrow.so.900(+0x1f27e09) [0x1551064a6e09]\r\nvenv/lib/python3.9/site-packages/pyarrow/libarrow.so.900(+0x200ba3d) [0x15510658aa3d]\r\nvenv/lib/python3.9/site-packages/pyarrow/libarrow.so.900(+0x1f25948) [0x1551064a4948]\r\nvenv/lib/python3.9/site-packages/pyarrow/libarrow.so.900(+0x200ba3d) [0x15510658aa3d]\r\nvenv/lib/python3.9/site-packages/pyarrow/libarrow.so.900(+0x1ee0b46) [0x15510645fb46]\r\nvenv/lib/python3.9/site-packages/pyarrow/libarrow.so.900(+0x194546a) [0x155105ec446a]\r\n/lib64/libc.so.6(+0x39b0c) [0x1551075b8b0c]\r\n/lib64/libc.so.6(on_exit+0) [0x1551075b8c40]\r\n/lib64/libc.so.6(__libc_start_main+0xfa) [0x1551075a249a]\r\npython(_start+0x2e) [0x4006ce]\r\nAborted (core dumped)\r\n```\r\n\r\nRunning on datasets==2.4.0 and pyarrow==9.0.0 on RHEL 8.\r\n",
"There is also a discussion here https://issues.apache.org/jira/browse/ARROW-15141 where it is suggested for conda users to use an older version of aws-sdk-cpp: `aws-sdk-cpp=1.8.186`",
"Downgrading pyarrow to 6.0.1 solves the issue for me.\r\n\r\n`pip install pyarrow==6.0.1`",
"First of all, I’d never call a downgrade a solution, at most a (very) temporary workaround.\r\nFurthermore: This bug also happens outside pyarrow, I incorporate AWS in a standalone Windows C-program and that crashes during exit.\r\n\r\nFrom: Bo-Ru (Roy) Lu ***@***.***>\r\nSent: Thursday, 15 September 2022 01:12\r\nTo: huggingface/datasets ***@***.***>\r\nCc: Ruurd Beerstra ***@***.***>; Comment ***@***.***>\r\nSubject: Re: [huggingface/datasets] Fatal error condition occurred in aws-c-io (Issue #3310)\r\n\r\nSent by an external sender. Please be cautious about clicking on links and opening attachments.\r\n--------------------------------------------------------------------------------------------------------------------------------\r\n\r\n\r\nDowngrading pyarrow to 6.0.1 solves the issue.\r\n\r\n—\r\nReply to this email directly, view it on GitHub<https://github.com/huggingface/datasets/issues/3310#issuecomment-1247390774>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKYUE3WBCSMHKJOOA2RQELLV6JLSVANCNFSM5IQ3WG7Q>.\r\nYou are receiving this because you commented.Message ID: ***@***.******@***.***>>\r\n",
"> First of all, I’d never call a downgrade a solution, at most a (very) temporary workaround.\r\n\r\nVery much so! It looks like an apparent fix for the underlying problem [might](https://github.com/awslabs/aws-c-io/pull/515) have landed, but it sounds like it might still be a bit of a [lift](https://github.com/aws/aws-sdk-cpp/issues/1809#issuecomment-1289859795) to get it into aws-sdk-cpp.\r\n\r\n> Downgrading pyarrow to 6.0.1 solves the issue for me.\r\n\r\nSidenote: On conda-forge side, all recent pyarrow releases (all the way up to v9 and soon v10) have carried the respective pin and will not run into this issue.\r\n\r\n```\r\nconda install -c conda-forge pyarrow\r\n```\r\n\r\n",
"For pip people, I confirmed that installing the nightly version of pyarrow also solves this by: `pip install --extra-index-url https://pypi.fury.io/arrow-nightlies/ --prefer-binary --pre pyarrow --upgrade`. (See https://arrow.apache.org/docs/python/install.html#installing-nightly-packages)\r\nAny version after https://github.com/apache/arrow/pull/14157 would work fine.",
"> Furthermore: This bug also happens outside pyarrow, I incorporate AWS in a standalone Windows C-program and that crashes during exit.\r\n\r\nDo you have a reproducer you could share? I'd like to test if the new versions that supposedly solve this actually do, but we don't have a way to test it...",
"Hi,\r\n\r\nNo – sorry. It is part of a massive eco-system which cannot easily be shared.\r\nBut I think the problem was summarized quite clearly: Windows does not allow a CreateThread while doing ExitProcess.\r\nThe cleanup that gets called as part of the exit handler code tries to start a thread, the fatal-assert on that causes the crash, and in windows we get a very big dump file.\r\nThe fix I applied simply removes that fatal assert, that solves the problem for me.\r\nI did not delve into the what the thread was trying to achieve and if that might cause issues when not executed during exit of the process. We did not notice anything of the kind.\r\nHowever, we *did* notice the many, many gigabytes of accumulated dumps of hundreds of processes 😊\r\n\r\nI’ll try and upgrade to the latest AWS version and report my findings, but that will be after I return from a month of vacationing…\r\n\r\n\r\n * Regards – Ruurd Beerstra\r\n\r\n\r\nFrom: h-vetinari ***@***.***>\r\nSent: Friday, 28 October 2022 02:09\r\nTo: huggingface/datasets ***@***.***>\r\nCc: Ruurd Beerstra ***@***.***>; Comment ***@***.***>\r\nSubject: Re: [huggingface/datasets] Fatal error condition occurred in aws-c-io (Issue #3310)\r\n\r\nSent by an external sender. Please be cautious about clicking on links and opening attachments.\r\n--------------------------------------------------------------------------------------------------------------------------------\r\n\r\n\r\nFurthermore: This bug also happens outside pyarrow, I incorporate AWS in a standalone Windows C-program and that crashes during exit.\r\n\r\nDo you have a reproducer you could share? I'd like to test if the new versions that supposedly solve this actually do, but we don't have a way to test it...\r\n\r\n—\r\nReply to this email directly, view it on GitHub<https://github.com/huggingface/datasets/issues/3310#issuecomment-1294251331>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKYUE3SHHPC5AT7KQ4GDAJDWFMKRTANCNFSM5IQ3WG7Q>.\r\nYou are receiving this because you commented.Message ID: ***@***.******@***.***>>\r\n",
"> No – sorry. It is part of a massive eco-system which cannot easily be shared.\r\n\r\nOK, was worth a try...\r\n\r\n> The fix I applied simply removes that fatal assert, that solves the problem for me.\r\n\r\nThis seems to be what https://github.com/awslabs/aws-c-io/pull/515 did upstream.\r\n\r\n> I’ll try and upgrade to the latest AWS version and report my findings, but that will be after I return from a month of vacationing…\r\n\r\ncaution: aws-sdk-cpp hasn't yet upgraded its bundled(?) aws-c-io and hence doesn't contain the fix AFAICT",
"Hi, I also encountered the same problem, but I made an error on Ubuntu without using `datasets` as @Crabzmatic he wrote.\r\n\r\nAt that time, I find my version of pyarrow is 9.0.0, which is different from as follow:\r\n> https://github.com/huggingface/datasets/issues/3310#issuecomment-1247390774\r\n> Downgrading pyarrow to 6.0.1 solves the issue for me.\r\n> \r\n> `pip install pyarrow==6.0.1`\r\n\r\nAs it happens, I found this error message when I introduced the [`Trainer`](https://huggingface.co/docs/transformers/main_classes/trainer) of HuggingFace\r\n\r\nFor example, I write following code:\r\n```python\r\nfrom transformers import Trainer\r\nprint('Hugging Face')\r\n```\r\n I get the following error message:\r\n```python\r\nHugging Face\r\nFatal error condition occurred in /opt/vcpkg/buildtrees/aws-c-io/src/9e6648842a-364b708815.clean/source/event_loop.c:72: aws_thread_launch(&cleanup_thread, s_event_loop_destroy_async_thread_fn, el_group, &thread_options) == AWS_OP_SUCCESS\r\nExiting Application\r\n################################################################################\r\nStack trace:\r\n################################################################################\r\n/home/ubuntu/anaconda3/envs/pytorch38/lib/python3.8/site-packages/pyarrow/libarrow.so.900(+0x200af06) [0x7fa9add1df06]\r\n/home/ubuntu/anaconda3/envs/pytorch38/lib/python3.8/site-packages/pyarrow/libarrow.so.900(+0x20028e5) [0x7fa9add158e5]\r\n/home/ubuntu/anaconda3/envs/pytorch38/lib/python3.8/site-packages/pyarrow/libarrow.so.900(+0x1f27e09) [0x7fa9adc3ae09]\r\n/home/ubuntu/anaconda3/envs/pytorch38/lib/python3.8/site-packages/pyarrow/libarrow.so.900(+0x200ba3d) [0x7fa9add1ea3d]\r\n/home/ubuntu/anaconda3/envs/pytorch38/lib/python3.8/site-packages/pyarrow/libarrow.so.900(+0x1f25948) [0x7fa9adc38948]\r\n/home/ubuntu/anaconda3/envs/pytorch38/lib/python3.8/site-packages/pyarrow/libarrow.so.900(+0x200ba3d) [0x7fa9add1ea3d]\r\n/home/ubuntu/anaconda3/envs/pytorch38/lib/python3.8/site-packages/pyarrow/libarrow.so.900(+0x1ee0b46) [0x7fa9adbf3b46]\r\n/home/ubuntu/anaconda3/envs/pytorch38/lib/python3.8/site-packages/pyarrow/libarrow.so.900(+0x194546a) [0x7fa9ad65846a]\r\n/lib/x86_64-linux-gnu/libc.so.6(+0x468d7) [0x7faa2fcfe8d7]\r\n/lib/x86_64-linux-gnu/libc.so.6(on_exit+0) [0x7faa2fcfea90]\r\n/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xfa) [0x7faa2fcdc0ba]\r\n/home/ubuntu/anaconda3/envs/pytorch38/bin/python(+0x1f9ad7) [0x5654571d1ad7]\r\n```\r\nBut, when I remove the `Trainer` module from transformers, **everthing is OK**.\r\n\r\nSo Why ?\r\n\r\n**Environment info**\r\n- Platform: Ubuntu 18\r\n- Python version: 3.8\r\n- PyArrow version: 9.0.0\r\n- transformers: 4.22.1\r\n- simpletransformers: 0.63.9",
"> I get the following error message:\r\n\r\nNot sure what's going on, but that shouldn't happen, especially as we're pinning to a version that should avoid this.\r\n\r\nCan you please open an issue https://github.com/conda-forge/arrow-cpp-feedstock, including the requested output of `conda list` & `conda info`?",
"pyarrow 10.0.1 was just released in conda-forge, which is the first release where we're building against aws-sdk-cpp 1.9.* again after more than a year. Since we cannot test the failure reported here on our infra, I'd be very grateful if someone could verify that the problem does or doesn't reappear. 🙃 \r\n\r\n```\r\nconda install -c conda-forge pyarrow=10\r\n```",
"> pyarrow 10.0.1 was just released in conda-forge, which is the first release where we're building against aws-sdk-cpp 1.9.* again after more than a year. Since we cannot test the failure reported here on our infra, I'd be very grateful if someone could verify that the problem does or doesn't reappear. 🙃\r\n> \r\n> ```\r\n> conda install -c conda-forge pyarrow=10\r\n> ```\r\n\r\nThe problem is gone after I install the new version. Thanks!\r\npip install pyarrow==10",
"@liuchaoqun, with `pip install pyarrow` you don't get aws-bindings, they're too complicated to package into wheels as far as I know. And even if they're packaged, at the time of the release of pyarrow 10 it would have still been pinned to aws 1.8 for the same reasons as in this issue."
] |
1,059,496,154
| 3,309
|
fix: files counted twice in inferred structure
|
closed
| 2021-11-21T21:50:38
| 2021-11-23T17:00:58
| 2021-11-23T17:00:58
|
https://github.com/huggingface/datasets/pull/3309
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3309",
"html_url": "https://github.com/huggingface/datasets/pull/3309",
"diff_url": "https://github.com/huggingface/datasets/pull/3309.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3309.patch",
"merged_at": "2021-11-23T17:00:58"
}
|
borisdayma
| true
|
[
"I see it creates some errors in the tests.\r\n\r\nAnother solution if needed is to add something like `data_files = list(set(data_files))` after [this line](https://github.com/huggingface/datasets/blob/8555197a3fe826e98bd0206c2d031c4488c53c5c/src/datasets/data_files.py#L511)",
"Hi ! Thanks for the correction :)\r\n\r\nYour change seems right, let me look at the errors and try to fix this",
"Not sure if it's due to this change but I tested `load_dataset('dalle-mini/encoded-vqgan_imagenet_f16_16384', streaming=True)` and the `validation` set is empty.",
"So indeed there was an issue with the patterns `*` and `**/*` that would return some files twice. This issue came from the fact that we were not using the right `glob`.\r\n\r\nIndeed we were using `Path.rglob` for local files and `Path.match` for remote files. Since these two methods don't have the same behavior for such patterns, I decided to change that.\r\n\r\nIn particular, we now use `glob.glob` (same as `fsspec` glob) as a reference for data files resolution from patterns. This is the same as dask for example.\r\n\r\n/!\\ Here are some behaviors specific to `glob.glob` that are different from Path.glob, Path.match or fnmatch:\r\n- '*' matches only first level files\r\n- '**/*' matches only at least second level files\r\n\r\nThis way we have a consistent behavior with respect to other python data libraries and there's no overlap anymore between the two patterns.\r\n\r\nSome implementations details:\r\n\r\nTo ensure that we have the same behavior for local files and for files in a remote dataset repository, I decided to use `fsspec` glob for both. This was made possible by implementing the `HfFileSystem` class as a `fsspec` filesystem.\r\n\r\nI pushed those changes directly to your PR - I hope you don't mind. I'm still fixing the remaining tests.\r\nPlease let me know if that solves your problem, and then we can merge !",
"There's still an issue with fsspec's glob - I'll take a look this afternoon",
"I just found out that actually glob.glob and fsspec glob are different haha\r\nglob.glob needs `**/*` and recursive=True to look into deep subdirectories, while fsspec only requires `**`\r\n\r\nI think we can go with fsspec glob for consistency with dask and since it's our main tool for filesystems management",
"To recap:\r\n```\r\nWe use fsspec glob as a reference for data files resolution from patterns.\r\nThis is the same as dask for example.\r\n\r\n/!\\ Here are some behaviors specific to fsspec glob that are different from glob.glob, Path.glob, Path.match or fnmatch:\r\n- '*' matches only first level items\r\n- '**' matches all items\r\n- '**/*' matches all at least second level items\r\n\r\nMore generally:\r\n- `*`` matches any character except a forward-slash (to match just the file or directory name)\r\n- `**`` matches any character including a forward-slash /\r\n```",
"lol Windows… Maybe `Pathlib` for the tests?\r\n\r\nI tested streaming a repo and it worked perfectly now!"
] |
1,059,255,705
| 3,308
|
"dataset_infos.json" missing for chr_en and mc4
|
open
| 2021-11-21T00:07:22
| 2022-01-19T13:55:32
| null |
https://github.com/huggingface/datasets/issues/3308
| null |
amitness
| false
|
[
"Hi ! Thanks for reporting :) \r\nWe can easily add the metadata for `chr_en` IMO, but for mC4 it will take more time, since it requires to count the number of examples in each language",
"No problem. I am trying to do some analysis on the metadata of all available datasets. Is reading `metadata_infos.json` for each dataset the correct way to go? \r\n\r\nI noticed that the same information is also available as special variables inside .py file of each dataset. So, I was wondering if `metadata_infos.json` has been deprecated?\r\n\r\n\r\n",
"The `dataset_infos.json` files have more information and are made to be used to analyze the datasets without having to run/parse the python scripts. Moreover some datasets on the Hugging face don't even have a python script, and for those ones we'll make tools to generate the JSON file automatically :)"
] |
1,059,226,297
| 3,307
|
Add IndoNLI dataset
|
closed
| 2021-11-20T20:46:03
| 2021-11-25T14:51:48
| 2021-11-25T14:51:48
|
https://github.com/huggingface/datasets/pull/3307
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3307",
"html_url": "https://github.com/huggingface/datasets/pull/3307",
"diff_url": "https://github.com/huggingface/datasets/pull/3307.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3307.patch",
"merged_at": "2021-11-25T14:51:48"
}
|
afaji
| true
|
[
"@lhoestq thanks for the review! I've modified the labels to follow other NLI datasets.\r\nPlease review my change and let me know if I miss anything."
] |
1,059,185,860
| 3,306
|
nested sequence feature won't encode example if the first item of the outside sequence is an empty list
|
closed
| 2021-11-20T16:57:54
| 2021-12-08T13:02:15
| 2021-12-08T13:02:15
|
https://github.com/huggingface/datasets/issues/3306
| null |
function2-llx
| false
|
[
"knock knock",
"Hi, thanks for reporting! I've linked a PR that should fix the issue.",
"I've checked the PR and it looks great, thanks a lot!"
] |
1,059,161,000
| 3,305
|
asserts replaced with exception for ``fingerprint.py``, ``search.py``, ``arrow_writer.py`` and ``metric.py``
|
closed
| 2021-11-20T14:51:23
| 2021-11-22T18:24:32
| 2021-11-22T17:08:13
|
https://github.com/huggingface/datasets/pull/3305
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3305",
"html_url": "https://github.com/huggingface/datasets/pull/3305",
"diff_url": "https://github.com/huggingface/datasets/pull/3305.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3305.patch",
"merged_at": "2021-11-22T17:08:13"
}
|
Ishan-Kumar2
| true
|
[] |
1,059,130,494
| 3,304
|
Dataset object has no attribute `to_tf_dataset`
|
closed
| 2021-11-20T12:03:59
| 2021-11-21T07:07:25
| 2021-11-21T07:07:25
|
https://github.com/huggingface/datasets/issues/3304
| null |
RajkumarGalaxy
| false
|
[
"The issue is due to the older version of transformers and datasets. It has been resolved by upgrading their versions.\r\n\r\n```\r\n# upgrade transformers and datasets to latest versions\r\n!pip install --upgrade transformers\r\n!pip install --upgrade datasets\r\n```\r\n\r\nRegards!"
] |
1,059,129,732
| 3,303
|
DataCollatorWithPadding: TypeError
|
closed
| 2021-11-20T11:59:55
| 2021-11-21T07:05:37
| 2021-11-21T07:05:37
|
https://github.com/huggingface/datasets/issues/3303
| null |
RajkumarGalaxy
| false
|
[
"\r\n> \r\n> Input:\r\n> \r\n> ```\r\n> tokenizer = AutoTokenizer.from_pretrained(checkpoint)\r\n> data_collator = DataCollatorWithPadding(tokenizer=tokenizer, return_tensors=\"tf\")\r\n> ```\r\n> \r\n> Output:\r\n> \r\n> ```\r\n> TypeError Traceback (most recent call last)\r\n> /tmp/ipykernel_42/1563280798.py in <module>\r\n> 1 checkpoint = 'bert-base-uncased'\r\n> 2 tokenizer = AutoTokenizer.from_pretrained(checkpoint)\r\n> ----> 3 data_collator = DataCollatorWithPadding(tokenizer=tokenizer, return_tensors=\"pt\")\r\n> TypeError: __init__() got an unexpected keyword argument 'return_tensors'\r\n> ```\r\n> \r\n\r\nThe issue is due to the older version of transformers and datasets. It has been resolved by upgrading their versions.\r\n\r\n`# upgrade transformers and datasets to latest versions`\r\n`!pip install --upgrade transformers`\r\n`!pip install --upgrade datasets`\r\n\r\nCheers!"
] |
1,058,907,168
| 3,302
|
fix old_val typo in f-string
|
closed
| 2021-11-19T20:51:08
| 2021-11-25T22:14:43
| 2021-11-22T17:04:19
|
https://github.com/huggingface/datasets/pull/3302
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3302",
"html_url": "https://github.com/huggingface/datasets/pull/3302",
"diff_url": "https://github.com/huggingface/datasets/pull/3302.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3302.patch",
"merged_at": "2021-11-22T17:04:19"
}
|
Mehdi2402
| true
|
[] |
1,058,718,957
| 3,301
|
Add wikipedia tags
|
closed
| 2021-11-19T16:39:25
| 2021-11-19T16:49:30
| 2021-11-19T16:49:29
|
https://github.com/huggingface/datasets/pull/3301
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3301",
"html_url": "https://github.com/huggingface/datasets/pull/3301",
"diff_url": "https://github.com/huggingface/datasets/pull/3301.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3301.patch",
"merged_at": "2021-11-19T16:49:29"
}
|
lhoestq
| true
|
[] |
1,058,644,459
| 3,300
|
❓ Dataset loading script from Hugging Face Hub
|
closed
| 2021-11-19T15:20:52
| 2021-12-22T10:57:56
| 2021-12-22T10:57:56
|
https://github.com/huggingface/datasets/issues/3300
| null |
pietrolesci
| false
|
[
"Hi ! In the next version of `datasets`, your train and test splits will be correctly separated (changes from #3027) if you create a dataset repository with only your CSV files.\r\n\r\nAlso it seems that you overwrite the `data_files` and `data_dir` arguments in your code, when you instantiate the AGNewsConfig objects. Those parameters are not necessary since you already know which files you want to load.\r\n\r\nYou can find an example on how to specify which file the dataset has to download in this [example script](https://huggingface.co/datasets/lhoestq/custom_squad/blob/main/custom_squad.py#L101-L107):\r\n```python\r\n_URLS = {\r\n \"train\": \"train-v1.1.json\", # you can use a URL or a relative path from the python script to your file in the repository\r\n \"dev\": \"dev-v1.1.json\",\r\n}\r\n```\r\n```python\r\n def _split_generators(self, dl_manager):\r\n downloaded_files = dl_manager.download_and_extract(_URLS)\r\n\r\n return [\r\n datasets.SplitGenerator(name=datasets.Split.TRAIN, gen_kwargs={\"filepath\": downloaded_files[\"train\"]}),\r\n datasets.SplitGenerator(name=datasets.Split.VALIDATION, gen_kwargs={\"filepath\": downloaded_files[\"dev\"]}),\r\n ]\r\n```",
"Also I think the viewer will be updated when you fix the dataset script, let me know if it doesn't",
"Hi @lhoestq,\r\n\r\nThanks a lot for the super quick answer!\r\n\r\nYour suggestion solves my issue. I am now able to load the dataset properly 🚀 \r\nHowever, the dataviewer is not working yet.\r\n\r\nReally, thanks a lot for your help and consideration!\r\n\r\nBest,\r\nPietro",
"Great ! We'll take a look at the viewer to fix it",
"@lhoestq I think I am having a related problem.\r\nMy call to load_dataset() looks like this:\r\n\r\n```\r\n datasets = load_dataset(\r\n os.path.abspath(layoutlmft.data.datasets.xfun.__file__),\r\n f\"xfun.{data_args.lang}\",\r\n additional_langs=data_args.additional_langs,\r\n keep_in_memory=True,\r\n )\r\n\r\n```\r\n\r\nMy _split_generation code is:\r\n\r\n```\r\n def _split_generators(self, dl_manager):\r\n \"\"\"Returns SplitGenerators.\"\"\"\r\n\r\n downloaded_file = dl_manager.download_and_extract(\"https://guillaumejaume.github.io/FUNSD/dataset.zip\")\r\n return [\r\n datasets.SplitGenerator(\r\n name=datasets.Split.TRAIN, gen_kwargs={\"filepath\": f\"{downloaded_file}/dataset/training_data/\"}\r\n ),\r\n datasets.SplitGenerator(\r\n name=datasets.Split.TEST, gen_kwargs={\"filepath\": f\"{downloaded_file}/dataset/testing_data/\"}\r\n ),\r\n ]\r\n\r\n```\r\nHowever I get the error \"TypeError: _generate_examples() got an unexpected keyword argument 'filepath'\"\r\nThe path looks right and I see the data in the path so I think the only problem I have is that it doesn't like the key \"filepath\". However, the documentation (example [here](https://huggingface.co/datasets/lhoestq/custom_squad/blob/main/custom_squad.py#L101-L107)) seems to show that this is the correct parameter. \r\n\r\nHere is the full stack trace:\r\n\r\n```\r\nDownloading and preparing dataset xfun/xfun.en (download: Unknown size, generated: Unknown size, post-processed: Unknown size, total: Unknown size) to /Users/caseygre/.cache/huggingface/datasets/xfun/xfun.en/0.0.0/96b8cb7c57f6f822f0ab37ae3be7b82d84ac57062e774c9361ccf0a4b9ef61cc...\r\nTraceback (most recent call last):\r\n File \"/Users/caseygre/PycharmProjects/aegis-ml-new/unilm/venv-LayoutLM/lib/python3.9/site-packages/datasets/builder.py\", line 574, in download_and_prepare\r\n self._download_and_prepare(\r\n File \"/Users/caseygre/PycharmProjects/aegis-ml-new/unilm/venv-LayoutLM/lib/python3.9/site-packages/datasets/builder.py\", line 652, in _download_and_prepare\r\n self._prepare_split(split_generator, **prepare_split_kwargs)\r\n File \"/Users/caseygre/PycharmProjects/aegis-ml-new/unilm/venv-LayoutLM/lib/python3.9/site-packages/datasets/builder.py\", line 975, in _prepare_split\r\n generator = self._generate_examples(**split_generator.gen_kwargs)\r\nTypeError: _generate_examples() got an unexpected keyword argument 'filepath'\r\npython-BaseException\r\n```",
"Hi ! The `gen_kwargs` dictionary is passed to `_generate_examples`, so in your case it must be defined this way:\r\n```python\r\ndef _generate_examples(self, filepath):\r\n ...\r\n```\r\n\r\nAnd here is an additional tip: you can use `os.path.join(downloaded_file, \"dataset/testing_data\")` instead of `f\"downloaded_file}/dataset/testing_data/\"` to get compatibility with Windows and streaming.\r\n\r\nIndeed Windows uses a backslash separator, not a slash, and streaming uses chained URLs (like `zip://dataset/testing_data::https://https://guillaumejaume.github.io/FUNSD/dataset.zip` for example)",
"Thanks for you quick reply @lhoestq and so sorry for my very delayed response.\r\nWe have gotten around the error another way but I will try to duplicate this when I can. We may have had \"filepaths\" instead of \"filepath\" in our def of _generate_examples() and not noticed the difference. If I find a more useful answer for others I will add to this ticket so they know what the issue was.\r\nNote: we do have our own _generate_examples() defined with the same def as Quentin has. (But one version does have \"filepaths\".)\r\n",
"Fixed in the viewer: https://huggingface.co/datasets/pietrolesci/ag_news"
] |
1,058,518,213
| 3,299
|
Add option to find unique elements in nested sequences when calling `Dataset.unique`
|
open
| 2021-11-19T13:16:06
| 2023-05-19T14:45:40
| null |
https://github.com/huggingface/datasets/issues/3299
| null |
mariosasko
| false
|
[
"Hi @mariosasko!\r\n\r\nHas this been patched into any of the releases?",
"Hi! Not yet, would you be interested in contributing a PR? I can give you some pointers if needed. ",
"@mariosasko did this ever get implemented? Willing to help if you are still up for it.",
"@dcruiz01 No, but here is an example of how to do this with the existing API:\r\n\r\n\r\n```python\r\nds = Dataset.from_dict({\"tokens\": [[\"a\", \"b\"], [\"c\", \"a\"], [\"c\", \"e\"]]})\r\n\r\ndef flatten_tokens(pa_table):\r\n return pa.table([pc.list_flatten(pa_table[\"tokens\"])], [\"flat_tokens\"])\r\n\r\nds = ds.with_format(\"arrow\")\r\nds = ds.map(flatten_tokens, batched=True)\r\nds = ds.with_format(None)\r\n\r\nunique_tokens = ds.unique(\"flat_tokens\")\r\n```\r\n\r\nWhen I think about it, `.unique` on `Sequence(Value(...))` should return unique sequences/arrays, not unique elements of these sequences..."
] |
1,058,420,201
| 3,298
|
Agnews dataset viewer is not working
|
closed
| 2021-11-19T11:18:59
| 2021-12-21T16:24:05
| 2021-12-21T16:24:05
|
https://github.com/huggingface/datasets/issues/3298
| null |
pietrolesci
| false
|
[
"Hi ! Thanks for reporting\r\nWe've already fixed the code that generates the preview for this dataset, we'll release the fix soon :)",
"Hi @lhoestq, thanks for your feedback!",
"Fixed in the viewer.\r\n\r\nhttps://huggingface.co/datasets/ag_news"
] |
1,058,263,859
| 3,297
|
.map() cache is wrongfully reused - only happens when the mapping function is imported
|
open
| 2021-11-19T08:18:36
| 2025-07-31T16:29:29
| null |
https://github.com/huggingface/datasets/issues/3297
| null |
eladsegal
| false
|
[
"Hi ! Thanks for reporting. Indeed this is a current limitation of the usage we have of `dill` in `datasets`. I'd suggest you use your workaround for now until we find a way to fix this. Maybe functions that are not coming from a module not installed with pip should be dumped completely, rather than only taking their locations into account",
"I agree. Sounds like a solution for it would be pretty dirty, even [cloudpickle](https://stackoverflow.com/a/16891169) doesn't help in this case.\r\nIn the meanwhile I think that adding a warning and the workaround somewhere in the documentation can be helpful.",
"For anyone interested, I see that with `dill==0.3.6` the workaround I suggested doesn't work anymore.\r\nI opened an issue about it: https://github.com/uqfoundation/dill/issues/572.\r\n\r\n ",
"Is there a plan for this issue or some progress made on this issue?\n\nHaving tons of transformations on a dataset doesn't allow to place it in the same file as loading it..\n\nAlso, currently there is no workaround available",
"Hi ! a workaround is to define the `fingerprint` uses to locate the cache file manually:\n\n```python\nds = ds.map(..., new_fingerprint=new_fingerprint)\n```\n\n**PS: make sure to update `new_fingerprint` every time you change your map() function or it will reload previous results from the cache**"
] |
1,057,970,638
| 3,296
|
Fix temporary dataset_path creation for URIs related to remote fs
|
closed
| 2021-11-18T23:32:45
| 2021-12-06T10:45:04
| 2021-12-06T10:45:04
|
https://github.com/huggingface/datasets/pull/3296
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3296",
"html_url": "https://github.com/huggingface/datasets/pull/3296",
"diff_url": "https://github.com/huggingface/datasets/pull/3296.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3296.patch",
"merged_at": "2021-12-06T10:45:03"
}
|
francisco-perez-sorrosal
| true
|
[
"Hi ! Thanks for the fix :) \r\n\r\nI think this should be `extract_path_from_uri` 's responsibility to strip the extra `/` from a badly formatted path like `hdfs:///absolute/path` (or raise an error). Do you think you can simply do the changes in `extract_path_from_uri` ? This way this fix will be available for all the other parts of the lib that need to extract the inner path from an URI of a remote filesystem\r\n\r\nThen we can also keep your test cases but simply apply them to `extract_path_from_uri` instead",
"Hi @lhoestq! No problem! Thanks for your interest! :)\r\n\r\nI think stripping the 3rd `/` in `hdfs:///absolute/path` inside `extract_path_from_uri` is not the solution. When I provide `hdfs:///absolute/path` to `extract_path_from_uri` we want `/absolute/path` to be returned, as it does now (at least in the case of URIs with `hdfs` schemas, for `s3` is different as it should start with a bucket name).\r\n\r\nThe problem comes in line 1041 in the original code below:\r\n\r\nhttps://github.com/huggingface/datasets/blob/42f6b1d18a4a1b6009b6e62d115491be16dfca22/src/datasets/arrow_dataset.py#L1038-L1042\r\n\r\nLets assume the following parameters for line 1041 after `extract_path_from_uri` has removed the `hdfs` schema part and the `://` from `hdfs:///absolute/path`, and `get_temporary_cache_files_directory()` returns `/tmp/a1b2b3c4`, as it is shown below: \r\n\r\n```python\r\nsrc_dataset_path = '/absolute/path'\r\ntmp_dir = '/tmp/a1b2b3c4'\r\ndataset_path = Path(tmp_dir, src_dataset_path)\r\n```\r\n\r\nAfter passing those paths to the `Path` object, `dataset_path` contains only `/absolute/path`; that is, it has lost the temporary directory path. This is because, when two (or more) absolute paths are passed to the `Path` function, only the last one is taken. However, if the contents of those variables are:\r\n\r\n```python\r\nsrc_dataset_path = 'relative/path'\r\ntmp_dir = '/tmp/a1b2b3c4'\r\ndataset_path = Path(tmp_dir, src_dataset_path)\r\n```\r\n\r\nthen `dataset_path` contains `/tmp/a1b2b3c4/relative/path` as expected.\r\n\r\nAbsolute paths are allowed in hdfs URIs, so that's why I added the extra function `build_local_temp_path` in the PR; so in case the second argument is an absolute path, it still will create the correct absolute path by concatenating the temp dir and the path passed by converting it to a relative path (and it also works for windows paths too.) It also allows to add the tests, checking that the main combinations are ok.\r\n\r\nI've checked all the places where the result of `extract_path_from_uri` is used, and as far as I've seen this is the only place where it is concatenated with another possible absolute path, so no need to add `build_local_temp_path` anywhere else. \r\n"
] |
1,057,954,892
| 3,295
|
Temporary dataset_path for remote fs URIs not built properly in arrow_dataset.py::load_from_disk
|
closed
| 2021-11-18T23:24:02
| 2021-12-06T10:45:04
| 2021-12-06T10:45:04
|
https://github.com/huggingface/datasets/issues/3295
| null |
francisco-perez-sorrosal
| false
|
[
"Hi ! Good catch and thanks for opening a PR :)\r\n\r\nI just responded in your PR"
] |
1,057,495,473
| 3,294
|
Add Natural Adversarial Objects dataset
|
open
| 2021-11-18T15:34:44
| 2021-12-08T12:00:02
| null |
https://github.com/huggingface/datasets/issues/3294
| null |
osanseviero
| false
|
[] |
1,057,004,431
| 3,293
|
Pin version exclusion for Markdown
|
closed
| 2021-11-18T06:56:01
| 2021-11-18T10:28:05
| 2021-11-18T10:28:04
|
https://github.com/huggingface/datasets/pull/3293
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3293",
"html_url": "https://github.com/huggingface/datasets/pull/3293",
"diff_url": "https://github.com/huggingface/datasets/pull/3293.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3293.patch",
"merged_at": "2021-11-18T10:28:04"
}
|
albertvillanova
| true
|
[] |
1,056,962,554
| 3,292
|
Not able to load 'wikipedia' dataset
|
closed
| 2021-11-18T05:41:18
| 2021-11-19T16:49:29
| 2021-11-19T16:49:29
|
https://github.com/huggingface/datasets/issues/3292
| null |
abhibisht89
| false
|
[
"Hi ! Indeed it looks like the code snippet on the Hugging face Hub doesn't show the second parameter\r\n\r\n\r\n\r\nThanks for reporting, I'm taking a look\r\n"
] |
1,056,689,876
| 3,291
|
Use f-strings in the dataset scripts
|
closed
| 2021-11-17T22:20:19
| 2021-11-22T16:40:16
| 2021-11-22T16:40:16
|
https://github.com/huggingface/datasets/pull/3291
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3291",
"html_url": "https://github.com/huggingface/datasets/pull/3291",
"diff_url": "https://github.com/huggingface/datasets/pull/3291.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3291.patch",
"merged_at": "2021-11-22T16:40:16"
}
|
Carlosbogo
| true
|
[] |
1,056,414,856
| 3,290
|
Make several audio datasets streamable
|
closed
| 2021-11-17T17:43:41
| 2022-02-01T21:00:52
| 2021-11-19T15:08:57
|
https://github.com/huggingface/datasets/pull/3290
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3290",
"html_url": "https://github.com/huggingface/datasets/pull/3290",
"diff_url": "https://github.com/huggingface/datasets/pull/3290.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3290.patch",
"merged_at": "2021-11-19T15:08:57"
}
|
lhoestq
| true
|
[
"Reading FLAC (for `librispeech_asr`) works OK for me (`soundfile` version: `0.10.3`):\r\n```python\r\nIn [2]: ds = load_dataset(\"datasets/librispeech_asr/librispeech_asr.py\", \"clean\", streaming=True, split=\"train.100\")\r\n\r\nIn [3]: item = next(iter(ds))\r\n\r\nIn [4]: item.keys()\r\nOut[4]: dict_keys(['file', 'audio', 'text', 'speaker_id', 'chapter_id', 'id'])\r\n\r\nIn [5]: item[\"file\"]\r\nOut[5]: '374-180298-0000.flac'\r\n\r\nIn [6]: item[\"audio\"].keys()\r\nOut[6]: dict_keys(['path', 'array', 'sampling_rate'])\r\n\r\nIn [7]: item[\"audio\"][\"sampling_rate\"]\r\nOut[7]: 16000\r\n\r\nIn [8]: item[\"audio\"][\"path\"]\r\nOut[8]: '374-180298-0000.flac'\r\n\r\nIn [9]: item[\"audio\"][\"array\"].shape\r\nOut[9]: (232480,)\r\n```",
"Oh cool ! I think this might have come from an issue with my local `soundfile` installation then",
"I'll do `multilingual_librispeech` in a separate PR since it requires the data to be in another format (in particular separate the train/dev/test splits in different files)",
"@lhoestq @albertvillanova - think it would have been nice to have added a big message at the top stating that this is a breaking change and ping `transformers` people a bit more here."
] |
1,056,323,715
| 3,289
|
Unpin markdown for build_docs now that it's fixed
|
closed
| 2021-11-17T16:22:53
| 2021-11-17T16:23:09
| 2021-11-17T16:23:08
|
https://github.com/huggingface/datasets/pull/3289
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3289",
"html_url": "https://github.com/huggingface/datasets/pull/3289",
"diff_url": "https://github.com/huggingface/datasets/pull/3289.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3289.patch",
"merged_at": "2021-11-17T16:23:08"
}
|
lhoestq
| true
|
[] |
1,056,145,703
| 3,288
|
Allow datasets with indices table when concatenating along axis=1
|
closed
| 2021-11-17T13:41:28
| 2021-11-17T15:41:12
| 2021-11-17T15:41:11
|
https://github.com/huggingface/datasets/pull/3288
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3288",
"html_url": "https://github.com/huggingface/datasets/pull/3288",
"diff_url": "https://github.com/huggingface/datasets/pull/3288.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3288.patch",
"merged_at": "2021-11-17T15:41:11"
}
|
mariosasko
| true
|
[] |
1,056,079,724
| 3,287
|
Add The Pile dataset and PubMed Central subset
|
closed
| 2021-11-17T12:35:58
| 2021-12-01T15:29:08
| 2021-12-01T15:29:07
|
https://github.com/huggingface/datasets/pull/3287
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3287",
"html_url": "https://github.com/huggingface/datasets/pull/3287",
"diff_url": "https://github.com/huggingface/datasets/pull/3287.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3287.patch",
"merged_at": "2021-12-01T15:29:06"
}
|
albertvillanova
| true
|
[] |
1,056,008,586
| 3,286
|
Fix build_docs CI
|
closed
| 2021-11-17T11:18:56
| 2021-11-17T11:19:20
| 2021-11-17T11:19:19
|
https://github.com/huggingface/datasets/pull/3286
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3286",
"html_url": "https://github.com/huggingface/datasets/pull/3286",
"diff_url": "https://github.com/huggingface/datasets/pull/3286.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3286.patch",
"merged_at": "2021-11-17T11:19:19"
}
|
lhoestq
| true
|
[] |
1,055,506,730
| 3,285
|
Add IEMOCAP dataset
|
open
| 2021-11-16T22:47:20
| 2023-06-10T08:14:52
| null |
https://github.com/huggingface/datasets/issues/3285
| null |
osanseviero
| false
|
[
"The IEMOCAP dataset is private and available only on request.\r\n```\r\nTo obtain the IEMOCAP data you just need to fill out an electronic release form below.\r\n```\r\n\r\n- [Request form](https://sail.usc.edu/iemocap/release_form.php)\r\n- [License ](https://sail.usc.edu/iemocap/Data_Release_Form_IEMOCAP.pdf)\r\n\r\n\r\n> We do not share the dataset for commercial purposes due to privacy concerns surrounding the participants of the research. The login details will only be emailed to the given academic email address.\r\n\r\nI think it won't be possible to add this dataset to 🤗 datasets.",
"Hi @dnaveenr ! We can contact the authors to see if they are interested in hosting the dataset on the Hub. In the meantime, feel free to work on a script with manual download.",
"Hi @mariosasko . Thanks for your response. Sure, I will mail them and find out if they're open to this.\r\n\r\nWork on a script with manual download ? This is new to me, any guidelines would be helpful here.\r\n",
"> Thanks for your response. Sure, I will mail them and find out if they're open to this.\r\n\r\nIt's best to leave this part to us because we have to explain how login would work and (potentially) set up a custom verification for the dataset.\r\n\r\n> Work on a script with manual download ? This is new to me, any guidelines would be helpful here.\r\n\r\nFor instance, this is one of the scripts with manual download: https://huggingface.co/datasets/arxiv_dataset. Compared to the standard dataset, it has the `manual_download_instructions` attribute and uses `dl_manager.manual_dir` (derived from `load_dataset(..., data_dir=\"path/to/data\")`) to access the dataset's data files.",
"> It's best to leave this part to us because we have to explain how login would work and (potentially) set up a custom verification for the dataset.\r\n\r\nYes. That would be perfect. Thanks.\r\n\r\n----\r\nOkay. Thanks for giving a reference. This is helpful. I will go through it.\r\n\r\n",
"@mariosasko has this been solved? I would like to use login and custom verification for training on my private dataset.",
"@flckv I think the [gating mechanism](https://huggingface.co/docs/hub/datasets-gated) is what you are looking for. ",
"@mariosasko Thanks, but no. I would like to keep my HuggingFace Dataset private and train a model on it. Is this possible?"
] |
1,055,502,909
| 3,284
|
Add VoxLingua107 dataset
|
open
| 2021-11-16T22:44:08
| 2021-12-06T09:49:45
| null |
https://github.com/huggingface/datasets/issues/3284
| null |
osanseviero
| false
|
[
"#self-assign"
] |
1,055,495,874
| 3,283
|
Add Speech Commands dataset
|
closed
| 2021-11-16T22:39:56
| 2021-12-10T10:30:15
| 2021-12-10T10:30:15
|
https://github.com/huggingface/datasets/issues/3283
| null |
osanseviero
| false
|
[
"#self-assign"
] |
1,055,054,898
| 3,282
|
ConnectionError: Couldn't reach https://huggingface.co/datasets/oscar-corpus/OSCAR-2109/resolve/main/OSCAR-2109.py
|
closed
| 2021-11-16T16:05:19
| 2022-04-12T11:57:43
| 2022-04-12T11:57:43
|
https://github.com/huggingface/datasets/issues/3282
| null |
MinionAttack
| false
|
[
"Hi ! Thanks for reporting :)\r\nI think this is because the dataset is behind an access page. We can fix the dataset viewer\r\n\r\nIf you also have this error when you use the `datasets` library in python, you should probably pass `use_auth_token=True` to the `load_dataset()` function to use your account to access the dataset.",
"Ah ok, I didn't realise about the login page. I'll try `use_auth_token=True` and see if that solves it.\r\n\r\nRegards!",
"Hi, \r\n\r\nUsing `use_auth_token=True` and downloading the credentials with `huggingface-cli login` (stored in .huggingface/token) solved the issue.\r\n\r\nShould I leave the issue open until you fix the Dataset viewer issue?",
"Cool ! Yes let's keep this issue open until the viewer is fixed - I'll close it when this is fixed. Thanks",
"The error I get when trying to load OSCAR 21.09 is this\r\n```\r\nConnectionError: Couldn't reach https://huggingface.co/datasets/oscar-corpus/OSCAR-2109/resolve/main/OSCAR-2109.py\r\n```\r\n\r\nThe URL I get in the browser is this\r\n```\r\nhttps://huggingface.co/datasets/oscar-corpus/OSCAR-2109/blob/main/OSCAR-2109.py\r\n```\r\n\r\nMaybe URL is the issue? (resolve vs blob)",
"> The error I get when trying to load OSCAR 21.09 is this\r\n> \r\n> ```\r\n> ConnectionError: Couldn't reach https://huggingface.co/datasets/oscar-corpus/OSCAR-2109/resolve/main/OSCAR-2109.py\r\n> ```\r\n> \r\n> The URL I get in the browser is this\r\n> \r\n> ```\r\n> https://huggingface.co/datasets/oscar-corpus/OSCAR-2109/blob/main/OSCAR-2109.py\r\n> ```\r\n> \r\n> Maybe URL is the issue? (resolve vs blob)\r\n\r\nYou need to download your login credentials. See `huggingface-cli login` documentation and when loading the dataset use `use_auth_token=True`:\r\n`\r\nload_dataset(corpus, language, split=None, use_auth_token=True, cache_dir=cache_folder)`",
"Fixed.\r\n\r\n<img width=\"1542\" alt=\"Capture d’écran 2022-04-12 à 13 57 24\" src=\"https://user-images.githubusercontent.com/1676121/162957585-af96d19c-f86c-47fe-80c4-2b071083cee4.png\">\r\n"
] |
1,055,018,876
| 3,281
|
[Datasets] Improve Covost 2
|
closed
| 2021-11-16T15:32:19
| 2022-01-26T16:17:06
| 2021-11-18T10:44:04
|
https://github.com/huggingface/datasets/pull/3281
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3281",
"html_url": "https://github.com/huggingface/datasets/pull/3281",
"diff_url": "https://github.com/huggingface/datasets/pull/3281.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3281.patch",
"merged_at": "2021-11-18T10:44:04"
}
|
patrickvonplaten
| true
|
[
"I am trying to use `load_dataset` with the French dataset(common voice corpus 1) which is downloaded from a common voice site and the target language is English (using colab)\r\n\r\nSteps I have followed:\r\n\r\n**1. untar:**\r\n`!tar xvzf fr.tar -C data_dir`\r\n\r\n**2. load data:**\r\n`load_dataset('covost2', 'fr_en', data_dir=\"/content/data_dir\")`\r\n\r\n0 rows are loading as shown below:\r\n```\r\nUsing custom data configuration fr_en-data_dir=%2Fcontent%2Fdata_dir\r\nReusing dataset covost2 (/root/.cache/huggingface/datasets/covost2/fr_en-data_dir=%2Fcontent%2Fdata_dir/1.0.0/bba950aae1ffa5a14b876b7e09c17b44de2c3cf60e7bd5d459640beffc78e35b)\r\n100%\r\n3/3 [00:00<00:00, 54.98it/s]\r\nDatasetDict({\r\n train: Dataset({\r\n features: ['client_id', 'file', 'audio', 'sentence', 'translation', 'id'],\r\n num_rows: 0\r\n })\r\n validation: Dataset({\r\n features: ['client_id', 'file', 'audio', 'sentence', 'translation', 'id'],\r\n num_rows: 0\r\n })\r\n test: Dataset({\r\n features: ['client_id', 'file', 'audio', 'sentence', 'translation', 'id'],\r\n num_rows: 0\r\n })\r\n})\r\n```\r\n\r\nCan you please provide a sample working example code to load the dataset?",
"Hi ! I think it only works with the subsets of Common Voice Corpus 4, not Common Voice Corpus 1"
] |
1,054,766,828
| 3,280
|
Fix bookcorpusopen RAM usage
|
closed
| 2021-11-16T11:27:52
| 2021-11-17T15:53:28
| 2021-11-16T13:34:30
|
https://github.com/huggingface/datasets/pull/3280
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3280",
"html_url": "https://github.com/huggingface/datasets/pull/3280",
"diff_url": "https://github.com/huggingface/datasets/pull/3280.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3280.patch",
"merged_at": "2021-11-16T13:34:30"
}
|
lhoestq
| true
|
[] |
1,054,711,852
| 3,279
|
Minor Typo Fix - Precision to Recall
|
closed
| 2021-11-16T10:32:22
| 2021-11-16T11:18:03
| 2021-11-16T11:18:02
|
https://github.com/huggingface/datasets/pull/3279
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3279",
"html_url": "https://github.com/huggingface/datasets/pull/3279",
"diff_url": "https://github.com/huggingface/datasets/pull/3279.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3279.patch",
"merged_at": "2021-11-16T11:18:02"
}
|
SebastinSanty
| true
|
[] |
1,054,249,463
| 3,278
|
Proposed update to the documentation for WER
|
closed
| 2021-11-15T23:28:31
| 2021-11-16T11:19:37
| 2021-11-16T11:19:37
|
https://github.com/huggingface/datasets/pull/3278
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3278",
"html_url": "https://github.com/huggingface/datasets/pull/3278",
"diff_url": "https://github.com/huggingface/datasets/pull/3278.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3278.patch",
"merged_at": "2021-11-16T11:19:37"
}
|
wooters
| true
|
[] |
1,054,122,656
| 3,277
|
f-string formatting
|
closed
| 2021-11-15T21:37:05
| 2021-11-19T20:40:08
| 2021-11-17T16:18:38
|
https://github.com/huggingface/datasets/pull/3277
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3277",
"html_url": "https://github.com/huggingface/datasets/pull/3277",
"diff_url": "https://github.com/huggingface/datasets/pull/3277.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3277.patch",
"merged_at": "2021-11-17T16:18:38"
}
|
Mehdi2402
| true
|
[
"Hello @lhoestq, ```make style``` is applied as asked. :)"
] |
1,053,793,063
| 3,276
|
Update KILT metadata JSON
|
closed
| 2021-11-15T15:25:25
| 2021-11-16T11:21:59
| 2021-11-16T11:21:58
|
https://github.com/huggingface/datasets/pull/3276
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3276",
"html_url": "https://github.com/huggingface/datasets/pull/3276",
"diff_url": "https://github.com/huggingface/datasets/pull/3276.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3276.patch",
"merged_at": "2021-11-16T11:21:58"
}
|
albertvillanova
| true
|
[] |
1,053,698,898
| 3,275
|
Force data files extraction if download_mode='force_redownload'
|
closed
| 2021-11-15T14:00:24
| 2021-11-15T14:45:23
| 2021-11-15T14:45:23
|
https://github.com/huggingface/datasets/pull/3275
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3275",
"html_url": "https://github.com/huggingface/datasets/pull/3275",
"diff_url": "https://github.com/huggingface/datasets/pull/3275.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3275.patch",
"merged_at": "2021-11-15T14:45:23"
}
|
mariosasko
| true
|
[] |
1,053,689,140
| 3,274
|
Fix some contact information formats
|
closed
| 2021-11-15T13:50:34
| 2021-11-15T14:43:55
| 2021-11-15T14:43:54
|
https://github.com/huggingface/datasets/pull/3274
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3274",
"html_url": "https://github.com/huggingface/datasets/pull/3274",
"diff_url": "https://github.com/huggingface/datasets/pull/3274.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3274.patch",
"merged_at": "2021-11-15T14:43:54"
}
|
lhoestq
| true
|
[
"The CI fail are caused by some missing sections or tags, which is unrelated to this PR. Merging !"
] |
1,053,554,038
| 3,273
|
Respect row ordering when concatenating datasets along axis=1
|
closed
| 2021-11-15T11:27:14
| 2021-11-17T15:41:11
| 2021-11-17T15:41:11
|
https://github.com/huggingface/datasets/issues/3273
| null |
mariosasko
| false
|
[] |
1,053,516,479
| 3,272
|
Make iter_archive work with ZIP files
|
open
| 2021-11-15T10:50:42
| 2021-11-25T00:08:47
| null |
https://github.com/huggingface/datasets/issues/3272
| null |
lhoestq
| false
|
[
"Hello, is this issue open for any contributor ? can I work on it ?\r\n\r\n",
"Hi ! Sure this is open for any contributor. If you're interested feel free to self-assign this issue to you by commenting `#self-assign`. Then if you have any question or if I can help, feel free to ping me.\r\n\r\nTo begin with, feel free to take a look at both implementations of `iter_archive` for local downloads and for data streaming:\r\n\r\nIn the `DownloadManager` for local dowloads:\r\nhttps://github.com/huggingface/datasets/blob/dfa334bd8dc6cbc854b170379c7d2cb7e3d3fe4f/src/datasets/utils/download_manager.py#L218-L242\r\n\r\nIn the `StreamingDownloadManager` to stream the content of the archive directly from the remote file:\r\nhttps://github.com/huggingface/datasets/blob/dfa334bd8dc6cbc854b170379c7d2cb7e3d3fe4f/src/datasets/utils/streaming_download_manager.py#L502-L526\r\n\r\nNotice the call to `xopen` that opens and streams a file given either an URL or a local path :)",
"Okay thank you for the information. I will work on this :) ",
"#self-assign"
] |
1,053,482,919
| 3,271
|
Decode audio from remote
|
closed
| 2021-11-15T10:25:56
| 2021-11-16T11:35:58
| 2021-11-16T11:35:58
|
https://github.com/huggingface/datasets/pull/3271
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3271",
"html_url": "https://github.com/huggingface/datasets/pull/3271",
"diff_url": "https://github.com/huggingface/datasets/pull/3271.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3271.patch",
"merged_at": "2021-11-16T11:35:58"
}
|
lhoestq
| true
|
[] |
1,053,465,662
| 3,270
|
Add os.listdir for streaming
|
closed
| 2021-11-15T10:14:04
| 2021-11-15T10:27:03
| 2021-11-15T10:27:03
|
https://github.com/huggingface/datasets/pull/3270
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3270",
"html_url": "https://github.com/huggingface/datasets/pull/3270",
"diff_url": "https://github.com/huggingface/datasets/pull/3270.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3270.patch",
"merged_at": "2021-11-15T10:27:02"
}
|
lhoestq
| true
|
[] |
1,053,218,769
| 3,269
|
coqa NonMatchingChecksumError
|
closed
| 2021-11-15T05:04:07
| 2022-01-19T13:58:19
| 2022-01-19T13:58:19
|
https://github.com/huggingface/datasets/issues/3269
| null |
ZhaofengWu
| false
|
[
"Hi @ZhaofengWu, thanks for reporting.\r\n\r\nUnfortunately, I'm not able to reproduce your bug:\r\n```python\r\nIn [1]: from datasets import load_dataset\r\n\r\nIn [2]: ds = load_dataset(\"coqa\")\r\nDownloading: 3.82kB [00:00, 1.91MB/s]\r\nDownloading: 1.79kB [00:00, 1.79MB/s]\r\nUsing custom data configuration default\r\nDownloading and preparing dataset coqa/default (download: 55.40 MiB, generated: 18.35 MiB, post-processed: Unknown size, total: 73.75 MiB) to .cache\\coqa\\default\\1.0.0\\553ce70bfdcd15ff4b5f4abc4fc2f37137139cde1f58f4f60384a53a327716f0...\r\nDownloading: 100%|████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 49.0M/49.0M [00:06<00:00, 7.17MB/s]\r\nDownloading: 100%|████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 9.09M/9.09M [00:01<00:00, 6.08MB/s]\r\n100%|████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 2/2 [00:12<00:00, 6.48s/it]\r\n100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 2/2 [00:00<00:00, 333.26it/s]\r\nDataset coqa downloaded and prepared to .cache\\coqa\\default\\1.0.0\\553ce70bfdcd15ff4b5f4abc4fc2f37137139cde1f58f4f60384a53a327716f0. Subsequent calls will reuse this data.\r\n100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 2/2 [00:00<00:00, 285.49it/s]\r\n\r\nIn [3]: ds\r\nOut[3]:\r\nDatasetDict({\r\n train: Dataset({\r\n features: ['source', 'story', 'questions', 'answers'],\r\n num_rows: 7199\r\n })\r\n validation: Dataset({\r\n features: ['source', 'story', 'questions', 'answers'],\r\n num_rows: 500\r\n })\r\n})\r\n```\r\n\r\nCould you please give more details about your development environment? You can run the command `datasets-cli env` and copy-and-paste its output:\r\n```\r\n- `datasets` version:\r\n- Platform:\r\n- Python version:\r\n- PyArrow version:\r\n```\r\nIt might be because you are using an old version of `datasets`. Could you please update it (`pip install -U datasets`) and confirm if the problem parsists? ",
"I'm getting the same error in two separate environments:\r\n```\r\n- `datasets` version: 1.15.1\r\n- Platform: Linux-5.4.0-84-generic-x86_64-with-debian-bullseye-sid\r\n- Python version: 3.7.11\r\n- PyArrow version: 6.0.0\r\n```\r\n\r\n```\r\n- `datasets` version: 1.15.1\r\n- Platform: macOS-10.16-x86_64-i386-64bit\r\n- Python version: 3.9.5\r\n- PyArrow version: 6.0.0\r\n```",
"I'm sorry, but don't get to reproduce the error in the Linux environment.\r\n\r\n@mariosasko @lhoestq can you reproduce it?",
"I also can't reproduce the error on Windows/Linux (tested both the master and the `1.15.1` version). ",
"Maybe the file had issues during the download ? Could you try to delete your cache and try again ?\r\nBy default the downloads cache is at `~/.cache/huggingface/datasets/downloads`\r\n\r\nAlso can you check if you have a proxy that could prevent the download to succeed ? Are you able to download those files via your browser ?",
"I got the same error in a third environment (google cloud) as well. The internet for these three environments are all different so I don't think that's the reason.\r\n```\r\n- `datasets` version: 1.12.1\r\n- Platform: Linux-5.11.0-1022-gcp-x86_64-with-glibc2.31\r\n- Python version: 3.9.7\r\n- PyArrow version: 6.0.0\r\n```\r\nI deleted the entire `~/.cache/huggingface/datasets` on my local mac, and got a different first time error.\r\n```\r\nPython 3.9.5 (default, May 18 2021, 12:31:01) \r\n[Clang 10.0.0 ] :: Anaconda, Inc. on darwin\r\nType \"help\", \"copyright\", \"credits\" or \"license\" for more information.\r\n>>> from datasets import load_dataset\r\n>>> dataset = load_dataset(\"coqa\")\r\nDownloading: 3.82kB [00:00, 1.19MB/s] \r\nDownloading: 1.79kB [00:00, 712kB/s] \r\nUsing custom data configuration default\r\nDownloading and preparing dataset coqa/default (download: 55.40 MiB, generated: 18.35 MiB, post-processed: Unknown size, total: 73.75 MiB) to /Users/zhaofengw/.cache/huggingface/datasets/coqa/default/1.0.0/553ce70bfdcd15ff4b5f4abc4fc2f37137139cde1f58f4f60384a53a327716f0...\r\nDownloading: 100%|█████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 222/222 [00:00<00:00, 1.36MB/s]\r\n 50%|████████████████████████████████████████████████████████████████████████████████████████████████████████████▌ | 1/2 [00:00<00:00, 2.47it/s]Traceback (most recent call last):\r\n File \"<stdin>\", line 1, in <module>\r\n File \"/Users/zhaofengw/miniconda3/lib/python3.9/site-packages/datasets/load.py\", line 1632, in load_dataset\r\n builder_instance.download_and_prepare(\r\n File \"/Users/zhaofengw/miniconda3/lib/python3.9/site-packages/datasets/builder.py\", line 607, in download_and_prepare\r\n self._download_and_prepare(\r\n File \"/Users/zhaofengw/miniconda3/lib/python3.9/site-packages/datasets/builder.py\", line 675, in _download_and_prepare\r\n split_generators = self._split_generators(dl_manager, **split_generators_kwargs)\r\n File \"/Users/zhaofengw/.cache/huggingface/modules/datasets_modules/datasets/coqa/553ce70bfdcd15ff4b5f4abc4fc2f37137139cde1f58f4f60384a53a327716f0/coqa.py\", line 70, in _split_generators\r\n downloaded_files = dl_manager.download_and_extract(urls_to_download)\r\n File \"/Users/zhaofengw/miniconda3/lib/python3.9/site-packages/datasets/utils/download_manager.py\", line 284, in download_and_extract\r\n return self.extract(self.download(url_or_urls))\r\n File \"/Users/zhaofengw/miniconda3/lib/python3.9/site-packages/datasets/utils/download_manager.py\", line 196, in download\r\n downloaded_path_or_paths = map_nested(\r\n File \"/Users/zhaofengw/miniconda3/lib/python3.9/site-packages/datasets/utils/py_utils.py\", line 216, in map_nested\r\n mapped = [\r\n File \"/Users/zhaofengw/miniconda3/lib/python3.9/site-packages/datasets/utils/py_utils.py\", line 217, in <listcomp>\r\n _single_map_nested((function, obj, types, None, True))\r\n File \"/Users/zhaofengw/miniconda3/lib/python3.9/site-packages/datasets/utils/py_utils.py\", line 152, in _single_map_nested\r\n return function(data_struct)\r\n File \"/Users/zhaofengw/miniconda3/lib/python3.9/site-packages/datasets/utils/download_manager.py\", line 217, in _download\r\n return cached_path(url_or_filename, download_config=download_config)\r\n File \"/Users/zhaofengw/miniconda3/lib/python3.9/site-packages/datasets/utils/file_utils.py\", line 295, in cached_path\r\n output_path = get_from_cache(\r\n File \"/Users/zhaofengw/miniconda3/lib/python3.9/site-packages/datasets/utils/file_utils.py\", line 594, in get_from_cache\r\n raise ConnectionError(\"Couldn't reach {}\".format(url))\r\nConnectionError: Couldn't reach https://nlp.stanford.edu/data/coqa/coqa-dev-v1.0.json\r\n>>> dataset = load_dataset(\"coqa\")\r\nUsing custom data configuration default\r\nDownloading and preparing dataset coqa/default (download: 55.40 MiB, generated: 18.35 MiB, post-processed: Unknown size, total: 73.75 MiB) to /Users/zhaofengw/.cache/huggingface/datasets/coqa/default/1.0.0/553ce70bfdcd15ff4b5f4abc4fc2f37137139cde1f58f4f60384a53a327716f0...\r\nDownloading: 100%|█████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 222/222 [00:00<00:00, 1.38MB/s]\r\n100%|█████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 2/2 [00:00<00:00, 6.26it/s]\r\n100%|███████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 2/2 [00:00<00:00, 1087.45it/s]\r\n 50%|████████████████████████████████████████████████████████████████████████████████████████████████████████████▌ | 1/2 [00:45<00:45, 45.60s/it]\r\nTraceback (most recent call last):\r\n File \"<stdin>\", line 1, in <module>\r\n File \"/Users/zhaofengw/miniconda3/lib/python3.9/site-packages/datasets/load.py\", line 1632, in load_dataset\r\n builder_instance.download_and_prepare(\r\n File \"/Users/zhaofengw/miniconda3/lib/python3.9/site-packages/datasets/builder.py\", line 607, in download_and_prepare\r\n self._download_and_prepare(\r\n File \"/Users/zhaofengw/miniconda3/lib/python3.9/site-packages/datasets/builder.py\", line 679, in _download_and_prepare\r\n verify_checksums(\r\n File \"/Users/zhaofengw/miniconda3/lib/python3.9/site-packages/datasets/utils/info_utils.py\", line 40, in verify_checksums\r\n raise NonMatchingChecksumError(error_msg + str(bad_urls))\r\ndatasets.utils.info_utils.NonMatchingChecksumError: Checksums didn't match for dataset source files:\r\n['https://nlp.stanford.edu/data/coqa/coqa-train-v1.0.json', 'https://nlp.stanford.edu/data/coqa/coqa-dev-v1.0.json']\r\n```\r\nI can access the URL using my browser, though I did notice a redirection -- could that have something to do with it?",
"Hi @ZhaofengWu, \r\n\r\nWhat about in Google Colab? Can you run this notebook without errors? \r\nhttps://colab.research.google.com/drive/1CCpiiHmtNlfO_4CZ3-fW-TSShr1M0rL4?usp=sharing",
"I can run your notebook fine, but if I create one myself, it has that error: https://colab.research.google.com/drive/107GIdhrauPO6ZiFDY7G9S74in4qqI2Kx?usp=sharing.\r\n\r\nIt's so funny -- it's like whenever you guys run it it's fine but whenever I run it it fails, whatever the environment is.",
"I guess it must be some connection issue: the data owner may be blocking requests coming from your country or IP range...",
"I mean, I don't think google colab sends the connection from my IP. Same applies to google cloud.",
"Hello, I am having the same error with @ZhaofengWu first with \"social bias frames\" dataset. As I found this report, I tried also \"coqa\" and it fails as well. \r\n\r\nI test this on Google Colab. \r\n\r\n```\r\n- `datasets` version: 1.15.1\r\n- Platform: Linux-5.4.104+-x86_64-with-Ubuntu-18.04-bionic\r\n- Python version: 3.7.12\r\n- PyArrow version: 3.0.0\r\n```\r\n\r\nThen another environment\r\n\r\n```\r\n- `datasets` version: 1.15.1\r\n- Platform: macOS-12.0.1-arm64-arm-64bit\r\n- Python version: 3.9.7\r\n- PyArrow version: 6.0.1\r\n```\r\n\r\nI tried the notebook @albertvillanova provided earlier, and it fails...\r\n",
"Hi, still not able to reproduce the issue with `coqa`. If you still have this issue, could you please run these additional commands ?\r\n```python\r\n>>> import os\r\n>>> from hashlib import md5\r\n>>> from datasets.utils import DownloadManager, DownloadConfig\r\n>>> path = DownloadManager(download_config=DownloadConfig(use_etag=False)).download(\"https://nlp.stanford.edu/data/coqa/coqa-dev-v1.0.json\") # it returns the cached file\r\n>>> os.path.getsize(path)\r\n9090845\r\n>>> m = md5()\r\n>>> m.update(open(path, \"rb\").read())\r\n>>> m.hexdigest()\r\n`95d427588e3733e4ebec55f6938dbba6`\r\n>>> open(path).read(500)\r\n'{\\n \"version\": \"1.0\",\\n \"data\": [\\n {\\n \"source\": \"mctest\",\\n \"id\": \"3dr23u6we5exclen4th8uq9rb42tel\",\\n \"filename\": \"mc160.test.41\",\\n \"story\": \"Once upon a time, in a barn near a farm house, there lived a little white kitten named Cotton. Cotton lived high up in a nice warm place above the barn where all of the farmer\\'s horses slept. But Cotton wasn\\'t alone in her little home above the barn, oh no. She shared her hay bed with her mommy and 5 other sisters. All of her sisters w'\r\n```\r\n\r\nThis way we can know whether you downloaded a corrupted file or an error file that could cause the `NonMatchingChecksumError` error to happen",
"```\r\n>>> import os\r\n>>> from hashlib import md5\r\n>>> from datasets.utils import DownloadManager, DownloadConfig\r\n>>> path = DownloadManager(download_config=DownloadConfig(use_etag=False)).download(\"https://nlp.stanford.edu/data/coqa/coqa-dev-v1.0.json\") # it returns the cached file\r\n>>> os.path.getsize(path)\r\n222\r\n>>> m = md5()\r\n>>> m.update(open(path, \"rb\").read())\r\n>>> m.hexdigest()\r\n'1195812a37c01a4481a4748c85d0c6a9'\r\n>>> open(path).read(500)\r\n'<html>\\n<head><title>503 Service Temporarily Unavailable</title></head>\\n<body bgcolor=\"white\">\\n<center><h1>503 Service Temporarily Unavailable</h1></center>\\n<hr><center>nginx/1.10.3 (Ubuntu)</center>\\n</body>\\n</html>\\n'\r\n```\r\nLooks like there was a server-side error when downloading the dataset? But I don't believe this is a transient error given (a) deleting the cache and re-downloading gives the same error; (b) it happens on multiple platforms with different network configurations; (c) other people are getting this error too, see above. So I'm not sure why it works for some people but not others.",
"`wget https://nlp.stanford.edu/data/coqa/coqa-dev-v1.0.json` does work. So I suspect there might be some problem in `datasets`' networking code? Can you give me some snippet that simulates how `datasets` requests the resource which I can run on my end?",
"There is a redirection -- I don't know if that's the cause.",
"Ok This is an issue with the server that hosts the data at `https://nlp.stanford.edu/nlp/data` that randomly returns 503 (by trying several times it also happens on my side), hopefully it can be fixed soon. I'll try to reach the people in charge of hosting the data",
"Thanks. Also it might help to display a more informative error message?",
"You're right. I just opened a PR that would show this error if it happens again:\r\n```python\r\nConnectionError: Couldn't reach https://nlp.stanford.edu/data/coqa/coqa-dev-v1.0.json (error 503)\r\n```"
] |
1,052,992,681
| 3,268
|
Dataset viewer issue for 'liweili/c4_200m'
|
closed
| 2021-11-14T17:18:46
| 2021-12-21T10:25:20
| 2021-12-21T10:24:51
|
https://github.com/huggingface/datasets/issues/3268
| null |
liliwei25
| false
|
[
"Hi ! I think the issue comes from this [line](https://huggingface.co/datasets/liweili/c4_200m/blob/main/c4_200m.py#L87):\r\n```python\r\npath = filepath + \"/*.tsv*\"\r\n```\r\n\r\nYou can fix this by doing this instead:\r\n```python\r\npath = os.path.join(filepath, \"/*.tsv*\")\r\n```\r\n\r\nHere is why:\r\n\r\nLocally you can append `\"/*.tsv*\"` to your local path, however it doesn't work in streaming mode, and the dataset viewer does use the streaming mode.\r\nIn streaming mode, the download and extract part is done lazily. It means that instead of using local paths, it's still passing around URLs and [chained URLs](https://filesystem-spec.readthedocs.io/en/latest/features.html#url-chaining)\r\n\r\nTherefore in streaming mode, `filepath` is not a local path, but instead is equal to\r\n```python\r\nzip://::https://huggingface.co/datasets/liweili/c4_200m/resolve/main/data.zip\r\n```\r\nThe `zip://` part means that we navigate inside the remote ZIP file.\r\n\r\nYou must use `os.path.join` to navigate inside it and get your TSV files:\r\n```python\r\n>>> os.path.join(filepath, \"/*.tsv*\")\r\nzip://*.tsv*::https://huggingface.co/datasets/liweili/c4_200m/resolve/main/data.zip\r\n```\r\n\r\n`datasets` extends `os.path.join`, `glob.glob`, etc. in your dataset scripts to work with remote files.",
"hi @lhoestq ! thanks for the tip! i've updated the line of code but it's still not working. am i doing something else wrong? thank you!",
"Hi ! Your dataset code is all good now :)\r\n```python\r\nIn [1]: from datasets import load_dataset\r\n\r\nIn [2]: d = load_dataset(\"liweili/c4_200m\", streaming=True)\r\nDownloading: 100%|█████████████████████████████████████████████| 2.79k/2.79k [00:00<00:00, 4.83MB/s]\r\nUsing custom data configuration default\r\n\r\nIn [3]: next(iter(d[\"train\"]))\r\nOut[3]: \r\n{'input': 'Bitcoin is for $7,094 this morning, which CoinDesk says.',\r\n 'output': 'Bitcoin goes for $7,094 this morning, according to CoinDesk.'}\r\n```\r\nThough the viewer doesn't seem to be updated, I'll take a look at what's wrong",
"thank you @lhoestq! 😄 ",
"It's working\r\n\r\n<img width=\"1424\" alt=\"Capture d’écran 2021-12-21 à 11 24 29\" src=\"https://user-images.githubusercontent.com/1676121/146914238-24bf87c0-c68d-4699-8d6c-fa3065656d1d.png\">\r\n\r\n"
] |
1,052,750,084
| 3,267
|
Replacing .format() and % by f-strings
|
closed
| 2021-11-13T19:12:02
| 2021-11-16T21:00:26
| 2021-11-16T14:55:43
|
https://github.com/huggingface/datasets/pull/3267
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3267",
"html_url": "https://github.com/huggingface/datasets/pull/3267",
"diff_url": "https://github.com/huggingface/datasets/pull/3267.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3267.patch",
"merged_at": null
}
|
Mehdi2402
| true
|
[
"Hi ! It looks like most of your changes are just `black` changes. All those changes are not necessary. In particular if you want to use `black`, please use the `make style` command instead. It runs `black` with additional parameters and you shouldn't end up with that many changes\r\n\r\nFeel free to open a new PR that doesn't include all the unnecessary `black` changes that you have on your branch :)",
"> Hi ! It looks like most of your changes are just `black` changes. All those changes are not necessary. In particular if you want to use `black`, please use the `make style` command instead. It runs `black` with additional parameters and you shouldn't end up with that many changes\r\n> \r\n> Feel free to open a new PR that doesn't include all the unnecessary `black` changes that you have on your branch :)\r\n\r\nThank you for your answer :) , I will open a new PR with the correct changes.",
"Hi @lhoestq, I submitted 3 commits in a new PR (#3277) where I did not apply black.\r\n\r\nI can apply the ```make style``` command if asked.",
"Cool thanks ! Yes feel free to make sure you have `black==21.4b0` and run `make style`"
] |
1,052,700,155
| 3,266
|
Fix URLs for WikiAuto Manual, jeopardy and definite_pronoun_resolution
|
closed
| 2021-11-13T15:01:34
| 2021-12-06T11:16:31
| 2021-12-06T11:16:31
|
https://github.com/huggingface/datasets/pull/3266
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3266",
"html_url": "https://github.com/huggingface/datasets/pull/3266",
"diff_url": "https://github.com/huggingface/datasets/pull/3266.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3266.patch",
"merged_at": "2021-12-06T11:16:31"
}
|
LashaO
| true
|
[
"There seems to be problems with datasets metadata, of which I dont have access to. I think one of the datasets is from reddit. Can anyone help?",
"Hello @LashaO , I think the errors were caused by `_DATA_FILES` in `definite_pronoun_resolution.py`. Here are details of the test error.\r\n```\r\nself = BuilderConfig(name='plain_text', version=1.0.0, data_dir=None, data_files={'train': 'train.c.txt', 'test': 'test.c.txt'}, description='Plain text import of the Definite Pronoun Resolution Dataset.')\r\n\r\n def __post_init__(self):\r\n # The config name is used to name the cache directory.\r\n invalid_windows_characters = r\"<>:/\\|?*\"\r\n for invalid_char in invalid_windows_characters:\r\n if invalid_char in self.name:\r\n raise InvalidConfigName(\r\n f\"Bad characters from black list '{invalid_windows_characters}' found in '{self.name}'. \"\r\n f\"They could create issues when creating a directory for this config on Windows filesystem.\"\r\n )\r\n if self.data_files is not None and not isinstance(self.data_files, DataFilesDict):\r\n> raise ValueError(f\"Expected a DataFilesDict in data_files but got {self.data_files}\")\r\nE ValueError: Expected a DataFilesDict in data_files but got {'train': 'train.c.txt', 'test': 'test.c.txt'}\r\n```",
"Hi ! Thanks for the fixes :)\r\n\r\nInstead of uploading the `definite_pronoun_resolution` data files in this PR, maybe we can just update the URL ?\r\nThe old url was http://www.hlt.utdallas.edu/~vince/data/emnlp12/train.c.txt, but now it's https://www.hlt.utdallas.edu/~vince/data/emnlp12/train.c.txt (https instead of http)",
"Actually the bad certificate creates an issue with the download\r\n```python\r\nimport datasets \r\ndatasets.DownloadManager().download(\"https://www.hlt.utdallas.edu/~vince/data/emnlp12/train.c.txt\")\r\n# raises: ConnectionError: Couldn't reach https://www.hlt.utdallas.edu/~vince/data/emnlp12/train.c.txt\r\n```\r\n\r\nLet me see if I can fix that",
"I uploaded them to these URLs, feel free to use them instead of having the text files here in the PR :)\r\nhttps://s3.amazonaws.com/datasets.huggingface.co/definite_pronoun_resolution/train.c.txt\r\nhttps://s3.amazonaws.com/datasets.huggingface.co/definite_pronoun_resolution/test.c.txt",
"Thank you for the tips! Having a busy week so anyone willing to commit the suggestions is welcome. Else, I will try to get back to this in a while.",
"@LashaO Thanks for working on this. Yes, I'll take over as we already have a request to fix the URL of the Jeopardy! dataset in a separate issue.",
"~~Still have to fix the error in the dummy data test of the WikiAuto dataset (so please don't merge).~~ Done! Ready for merging.",
"Thank you, Mario!",
"The CI failure is only related to missing tags in the dataset cards, merging :)"
] |
1,052,666,558
| 3,265
|
Checksum error for kilt_task_wow
|
closed
| 2021-11-13T12:04:17
| 2021-11-16T11:23:53
| 2021-11-16T11:21:58
|
https://github.com/huggingface/datasets/issues/3265
| null |
slyviacassell
| false
|
[
"Using `dataset = load_dataset(\"kilt_tasks\", \"wow\", ignore_verifications=True)` may fix it, but I do not think it is a elegant solution.",
"Hi @slyviacassell, thanks for reporting.\r\n\r\nYes, there is an issue with the checksum verification. I'm fixing it.\r\n\r\nAnd as you pointed out, in the meantime, you can circumvent the problem by passing `ignore_verifications=True`. "
] |
1,052,663,513
| 3,264
|
Downloading URL change for WikiAuto Manual, jeopardy and definite_pronoun_resolution
|
closed
| 2021-11-13T11:47:12
| 2022-06-01T17:38:16
| 2022-06-01T17:38:16
|
https://github.com/huggingface/datasets/issues/3264
| null |
slyviacassell
| false
|
[
"#take\r\nI am willing to fix this. Links can be replaced for WikiAuto Manual and jeopardy with new ones provided by authors.\r\n\r\nAs for the definite_pronoun_resolution URL, a certificate error seems to be preventing a download. I have the files on my local machine. I can include them in the dataset folder as the files are <1MB in size total.",
"> #take I am willing to fix this. Links can be replaced for WikiAuto Manual and jeopardy.\r\n> \r\n> As for the definite_pronoun_resolution URL, a certificate error seems to be preventing a download. I have the files on my local machine. Anyone has opinions on whether it is preferable for me to host them somewhere (e.g. personal GDrive account) or upload them to the dataset folder directly and use github raw URLs? The files are <1MB in size.\r\n\r\nI am planning to fix it next few days. But my to-do list is full and I do not have the cache of definite_pronoun_resolution. I am glad that you can take this. Thanks a lot!",
"No problem, buddy! Will submit a PR over this weekend."
] |
1,052,552,516
| 3,263
|
FET DATA
|
closed
| 2021-11-13T05:46:06
| 2021-11-13T13:31:47
| 2021-11-13T13:31:47
|
https://github.com/huggingface/datasets/issues/3263
| null |
FStell01
| false
|
[] |
1,052,455,082
| 3,262
|
asserts replaced with exception for image classification task, csv, json
|
closed
| 2021-11-12T22:34:59
| 2021-11-15T11:08:37
| 2021-11-15T11:08:37
|
https://github.com/huggingface/datasets/pull/3262
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3262",
"html_url": "https://github.com/huggingface/datasets/pull/3262",
"diff_url": "https://github.com/huggingface/datasets/pull/3262.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3262.patch",
"merged_at": "2021-11-15T11:08:37"
}
|
manisnesan
| true
|
[] |
1,052,346,381
| 3,261
|
Scifi_TV_Shows: Having trouble getting viewer to find appropriate files
|
closed
| 2021-11-12T19:25:19
| 2021-12-21T10:24:10
| 2021-12-21T10:24:10
|
https://github.com/huggingface/datasets/issues/3261
| null |
lara-martin
| false
|
[
"Hi ! I think this is because `iter_archive` doesn't support ZIP files yet. See https://github.com/huggingface/datasets/issues/3272\r\n\r\nYou can navigate into the archive this way instead:\r\n```python\r\n# in split_generators\r\ndata_dir = dl_manager.download_and_extract(url)\r\ntrain_filepath = os.path.join(data_dir, \"all-sci-fi-data-train.txt\")\r\nreturn [\r\n datasets.SplitGenerator(\r\n name=datasets.Split.TRAIN,\r\n gen_kwargs={\r\n \"filepath\": train_filepath,\r\n },\r\n ),\r\n...\r\n])\r\n\r\n# in generate_examples\r\nwith open(filepath, encoding=\"utf-8\") as f:\r\n ...\r\n```",
"It's working: https://huggingface.co/datasets/lara-martin/Scifi_TV_Shows/viewer/Scifi_TV_Shows/test\r\n\r\n<img width=\"1494\" alt=\"Capture d’écran 2021-12-21 à 11 23 51\" src=\"https://user-images.githubusercontent.com/1676121/146914068-f4b7225f-42c5-471d-9c73-2adac722162f.png\">\r\n"
] |
1,052,247,373
| 3,260
|
Fix ConnectionError in Scielo dataset
|
closed
| 2021-11-12T18:02:37
| 2021-11-16T18:18:17
| 2021-11-16T17:55:22
|
https://github.com/huggingface/datasets/pull/3260
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3260",
"html_url": "https://github.com/huggingface/datasets/pull/3260",
"diff_url": "https://github.com/huggingface/datasets/pull/3260.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3260.patch",
"merged_at": "2021-11-16T17:55:22"
}
|
mariosasko
| true
|
[
"The CI error is unrelated to the change."
] |
1,052,189,775
| 3,259
|
Updating details of IRC disentanglement data
|
closed
| 2021-11-12T17:16:58
| 2021-11-18T17:19:33
| 2021-11-18T17:19:33
|
https://github.com/huggingface/datasets/pull/3259
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3259",
"html_url": "https://github.com/huggingface/datasets/pull/3259",
"diff_url": "https://github.com/huggingface/datasets/pull/3259.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3259.patch",
"merged_at": "2021-11-18T17:19:33"
}
|
jkkummerfeld
| true
|
[
"Thank you for the cleanup!"
] |
1,052,188,195
| 3,258
|
Reload dataset that was already downloaded with `load_from_disk` from cloud storage
|
open
| 2021-11-12T17:14:59
| 2021-11-12T17:14:59
| null |
https://github.com/huggingface/datasets/issues/3258
| null |
lhoestq
| false
|
[] |
1,052,118,365
| 3,257
|
Use f-strings for string formatting
|
closed
| 2021-11-12T16:02:15
| 2021-11-17T16:18:38
| 2021-11-17T16:18:38
|
https://github.com/huggingface/datasets/issues/3257
| null |
mariosasko
| false
|
[
"Hi, I would be glad to help with this. Is there anyone else working on it?",
"Hi, I would be glad to work on this too.",
"#self-assign",
"Hi @Carlosbogo,\r\n\r\nwould you be interested in replacing the `.format` and `%` syntax with f-strings in the modules in the `datasets` directory since @Mehdi2402 has opened a PR that does that for all the other directories?",
"Oh I see. I will be glad to help with the `datasets` directory then."
] |
1,052,000,613
| 3,256
|
asserts replaced by exception for text classification task with test.
|
closed
| 2021-11-12T14:05:36
| 2021-11-12T15:09:33
| 2021-11-12T14:59:32
|
https://github.com/huggingface/datasets/pull/3256
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3256",
"html_url": "https://github.com/huggingface/datasets/pull/3256",
"diff_url": "https://github.com/huggingface/datasets/pull/3256.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3256.patch",
"merged_at": "2021-11-12T14:59:32"
}
|
manisnesan
| true
|
[
"Haha it looks like you got the chance of being reviewed twice at the same time and got the same suggestion twice x)\r\nAnyway it's all good now so we can merge !",
"Thanks for the feedback. "
] |
1,051,783,129
| 3,255
|
SciELO dataset ConnectionError
|
closed
| 2021-11-12T09:57:14
| 2021-11-16T17:55:22
| 2021-11-16T17:55:22
|
https://github.com/huggingface/datasets/issues/3255
| null |
WojciechKusa
| false
|
[] |
1,051,351,172
| 3,254
|
Update xcopa dataset (fix checksum issues + add translated data)
|
closed
| 2021-11-11T20:51:33
| 2021-11-12T10:30:58
| 2021-11-12T10:30:57
|
https://github.com/huggingface/datasets/pull/3254
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3254",
"html_url": "https://github.com/huggingface/datasets/pull/3254",
"diff_url": "https://github.com/huggingface/datasets/pull/3254.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3254.patch",
"merged_at": "2021-11-12T10:30:57"
}
|
mariosasko
| true
|
[
"The CI failures are unrelated to the changes (missing fields in the readme and the CER metric error fixed in #3252)."
] |
1,051,308,972
| 3,253
|
`GeneratorBasedBuilder` does not support `None` values
|
closed
| 2021-11-11T19:51:21
| 2021-12-09T14:26:58
| 2021-12-09T14:26:58
|
https://github.com/huggingface/datasets/issues/3253
| null |
pavel-lexyr
| false
|
[
"Hi,\r\n\r\nthanks for reporting and providing a minimal reproducible example. \r\n\r\nThis line of the PR I've linked in our discussion on the Forum will add support for `None` values:\r\nhttps://github.com/huggingface/datasets/blob/a53de01842aac65c66a49b2439e18fa93ff73ceb/src/datasets/features/features.py#L835\r\n\r\nI expect that PR to be merged soon."
] |
1,051,124,749
| 3,252
|
Fix failing CER metric test in CI after update
|
closed
| 2021-11-11T15:57:16
| 2021-11-12T14:06:44
| 2021-11-12T14:06:43
|
https://github.com/huggingface/datasets/pull/3252
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3252",
"html_url": "https://github.com/huggingface/datasets/pull/3252",
"diff_url": "https://github.com/huggingface/datasets/pull/3252.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3252.patch",
"merged_at": "2021-11-12T14:06:43"
}
|
mariosasko
| true
|
[] |
1,050,541,348
| 3,250
|
Add ETHICS dataset
|
closed
| 2021-11-11T03:45:34
| 2022-10-03T09:37:25
| 2022-10-03T09:37:25
|
https://github.com/huggingface/datasets/pull/3250
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3250",
"html_url": "https://github.com/huggingface/datasets/pull/3250",
"diff_url": "https://github.com/huggingface/datasets/pull/3250.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3250.patch",
"merged_at": null
}
|
ssss1029
| true
|
[
"Thanks for your contribution, @ssss1029. Are you still interested in adding this dataset?\r\n\r\nWe are removing the dataset scripts from this GitHub repo and moving them to the Hugging Face Hub: https://huggingface.co/datasets\r\n\r\nWe would suggest you create this dataset there. Please, feel free to tell us if you need some help."
] |
1,050,193,138
| 3,249
|
Fix streaming for id_newspapers_2018
|
closed
| 2021-11-10T18:55:30
| 2021-11-12T14:01:32
| 2021-11-12T14:01:31
|
https://github.com/huggingface/datasets/pull/3249
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3249",
"html_url": "https://github.com/huggingface/datasets/pull/3249",
"diff_url": "https://github.com/huggingface/datasets/pull/3249.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3249.patch",
"merged_at": "2021-11-12T14:01:31"
}
|
lhoestq
| true
|
[] |
1,050,171,082
| 3,248
|
Stream from Google Drive and other hosts
|
closed
| 2021-11-10T18:32:32
| 2021-11-30T16:03:43
| 2021-11-12T17:18:11
|
https://github.com/huggingface/datasets/pull/3248
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3248",
"html_url": "https://github.com/huggingface/datasets/pull/3248",
"diff_url": "https://github.com/huggingface/datasets/pull/3248.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3248.patch",
"merged_at": "2021-11-12T17:18:10"
}
|
lhoestq
| true
|
[
"I just tried some datasets and noticed that `spider` is not working for some reason (the compression type is not recognized), resulting in FileNotFoundError. I can take a look tomorrow",
"I'm fixing the remaining files based on TAR archives",
"THANKS A LOT"
] |
1,049,699,088
| 3,247
|
Loading big json dataset raises pyarrow.lib.ArrowNotImplementedError
|
closed
| 2021-11-10T11:17:59
| 2022-04-10T14:05:57
| 2022-04-10T14:05:57
|
https://github.com/huggingface/datasets/issues/3247
| null |
maxzirps
| false
|
[
"Hi,\r\n\r\nthis issue is similar to https://github.com/huggingface/datasets/issues/3093, so you can either use the solution provided there or try to load the data in one chunk (you can control the chunk size by specifying the `chunksize` parameter (`int`) in `load_dataset`).\r\n\r\n@lhoestq Is this worth opening an issue on Jira? Basically, PyArrow doesn't allow casts that change the order of the struct fields because they treat `pa.struct` as an ordered sequence. Reordering fields manually in Python is probably too slow, so I think this needs to be fixed by them to be usable on our side.",
"I agree I would expect PyArrow to be able to handle this, do you want to open the issue @mariosasko ?\r\nAlthough maybe it's possible to fix struct casting on our side without hurting performance too much, if it's simply a matter of reordering the arrays in the StructArray",
"Fixed in #3575, so I'm closing this issue."
] |
1,049,662,746
| 3,246
|
[tiny] fix typo in stream docs
|
closed
| 2021-11-10T10:40:02
| 2021-11-10T11:10:39
| 2021-11-10T11:10:39
|
https://github.com/huggingface/datasets/pull/3246
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3246",
"html_url": "https://github.com/huggingface/datasets/pull/3246",
"diff_url": "https://github.com/huggingface/datasets/pull/3246.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3246.patch",
"merged_at": "2021-11-10T11:10:39"
}
|
verbiiyo
| true
|
[] |
1,048,726,062
| 3,245
|
Fix load_from_disk temporary directory
|
closed
| 2021-11-09T15:15:15
| 2021-11-09T15:30:52
| 2021-11-09T15:30:51
|
https://github.com/huggingface/datasets/pull/3245
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3245",
"html_url": "https://github.com/huggingface/datasets/pull/3245",
"diff_url": "https://github.com/huggingface/datasets/pull/3245.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3245.patch",
"merged_at": "2021-11-09T15:30:51"
}
|
lhoestq
| true
|
[] |
1,048,675,741
| 3,244
|
Fix filter method for batched=True
|
closed
| 2021-11-09T14:30:59
| 2021-11-09T15:52:58
| 2021-11-09T15:52:57
|
https://github.com/huggingface/datasets/pull/3244
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3244",
"html_url": "https://github.com/huggingface/datasets/pull/3244",
"diff_url": "https://github.com/huggingface/datasets/pull/3244.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3244.patch",
"merged_at": "2021-11-09T15:52:57"
}
|
thomasw21
| true
|
[] |
1,048,630,754
| 3,243
|
Remove redundant isort module placement
|
closed
| 2021-11-09T13:50:30
| 2021-11-12T14:02:45
| 2021-11-12T14:02:45
|
https://github.com/huggingface/datasets/pull/3243
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3243",
"html_url": "https://github.com/huggingface/datasets/pull/3243",
"diff_url": "https://github.com/huggingface/datasets/pull/3243.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3243.patch",
"merged_at": "2021-11-12T14:02:45"
}
|
mariosasko
| true
|
[] |
1,048,527,232
| 3,242
|
Adding ANERcorp-CAMeLLab dataset
|
open
| 2021-11-09T12:04:04
| 2021-11-09T12:41:15
| null |
https://github.com/huggingface/datasets/issues/3242
| null |
vitalyshalumov
| false
|
[
"Adding ANERcorp dataset\r\n\r\n## Adding a Dataset\r\n- **Name:** *ANERcorp-CAMeLLab*\r\n- **Description:** *Since its creation in 2008, the ANERcorp dataset (Benajiba & Rosso, 2008) has been a standard reference used by Arabic named entity recognition researchers around the world. However, over time, this dataset was copied over from user to user, modified slightly here and there, and split in many different configurations that made it hard to compare fairly across papers and systems.\r\n\r\nIn 2020, a group of researchers from CAMeL Lab (Habash, Alhafni and Oudah), and Mind Lab (Antoun and Baly) met with the creator of the corpus, Yassine Benajiba, to consult with him and collectively agree on an exact split, and accepted minor corrections from the original dataset. Bashar Alhafni from CAMeL Lab working with Nizar Habash implemented the decisions provided in this release.*\r\n\r\n- **Paper:** *(a) Benajiba, Yassine, Paolo Rosso, and José Miguel Benedí Ruiz. \"Anersys: An Arabic named entity recognition system based on maximum entropy.\" In International Conference on Intelligent Text Processing and Computational Linguistics, pp. 143-153. Springer, Berlin, Heidelberg, 2007.\r\n\r\n(b)Ossama Obeid, Nasser Zalmout, Salam Khalifa, Dima Taji, Mai Oudah, Bashar Alhafni, Go Inoue, Fadhl Eryani, Alexander Erdmann, and Nizar Habash. \"CAMeL Tools: An Open Source Python Toolkit, for Arabic Natural Language Processing.\" In Proceedings of the Conference on Language Resources and Evaluation (LREC 2020), Marseille, 2020.*\r\n- **Data:** *https://camel.abudhabi.nyu.edu/anercorp/*\r\n- **Motivation:** This is the standard dataset for evaluating NER performance in Arabic*\r\n\r\nInstructions to add a new dataset can be found [here](https://github.com/huggingface/datasets/blob/master/ADD_NEW_DATASET.md)."
] |
1,048,461,852
| 3,241
|
Swap descriptions of v1 and raw-v1 configs of WikiText dataset and fix metadata
|
closed
| 2021-11-09T10:54:15
| 2022-02-14T15:46:00
| 2021-11-09T13:49:28
|
https://github.com/huggingface/datasets/pull/3241
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3241",
"html_url": "https://github.com/huggingface/datasets/pull/3241",
"diff_url": "https://github.com/huggingface/datasets/pull/3241.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3241.patch",
"merged_at": "2021-11-09T13:49:28"
}
|
albertvillanova
| true
|
[] |
1,048,376,021
| 3,240
|
Couldn't reach data file for disaster_response_messages
|
closed
| 2021-11-09T09:26:42
| 2021-12-14T14:38:29
| 2021-12-14T14:38:29
|
https://github.com/huggingface/datasets/issues/3240
| null |
pandya6988
| false
|
[
"It looks like the dataset isn't available anymore on appen.com\r\n\r\nThe CSV files appear to still be available at https://www.kaggle.com/landlord/multilingual-disaster-response-messages though. It says that the data are under the CC0 license so I guess we can host the dataset elsewhere instead ?"
] |
1,048,360,232
| 3,239
|
Inconsistent performance of the "arabic_billion_words" dataset
|
open
| 2021-11-09T09:11:00
| 2021-11-09T09:11:00
| null |
https://github.com/huggingface/datasets/issues/3239
| null |
vitalyshalumov
| false
|
[] |
1,048,226,086
| 3,238
|
Reuters21578 Couldn't reach
|
closed
| 2021-11-09T06:08:56
| 2021-11-11T00:02:57
| 2021-11-11T00:02:57
|
https://github.com/huggingface/datasets/issues/3238
| null |
TingNLP
| false
|
[
"Hi ! The URL works fine on my side today, could you try again ?",
"thank you @lhoestq \r\nit works"
] |
1,048,165,525
| 3,237
|
wikitext description wrong
|
closed
| 2021-11-09T04:06:52
| 2022-02-14T15:45:11
| 2021-11-09T13:49:28
|
https://github.com/huggingface/datasets/issues/3237
| null |
hongyuanmei
| false
|
[
"Hi @hongyuanmei, thanks for reporting.\r\n\r\nI'm fixing it.",
"Duplicate of:\r\n- #795"
] |
1,048,026,358
| 3,236
|
Loading of datasets changed in #3110 returns no examples
|
closed
| 2021-11-08T23:29:46
| 2021-11-09T16:46:05
| 2021-11-09T16:45:47
|
https://github.com/huggingface/datasets/issues/3236
| null |
eladsegal
| false
|
[
"Hi @eladsegal, thanks for reporting.\r\n\r\nI am sorry, but I can't reproduce the bug:\r\n```\r\nIn [1]: from datasets import load_dataset\r\n\r\nIn [2]: ds = load_dataset(\"qasper\")\r\nDownloading: 5.11kB [00:00, ?B/s]\r\nDownloading and preparing dataset qasper/qasper (download: 9.88 MiB, generated: 35.11 MiB, post-processed: Unknown size, total: 44.99 MiB) to .cache\\qasper\\qasper\\0.1.0\\b99154d2a15aa54bfc669f82b2eda715a2e342e81023d39613b0e2920fdb3ad8...\r\nDataset qasper downloaded and prepared to .cache\\qasper\\qasper\\0.1.0\\b99154d2a15aa54bfc669f82b2eda715a2e342e81023d39613b0e2920fdb3ad8. Subsequent calls will reuse this data.\r\n100%|████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 2/2 [00:00<?, ?it/s]\r\n\r\nIn [3]: ds\r\nOut[3]:\r\nDatasetDict({\r\n train: Dataset({\r\n features: ['id', 'title', 'abstract', 'full_text', 'qas'],\r\n num_rows: 888\r\n })\r\n validation: Dataset({\r\n features: ['id', 'title', 'abstract', 'full_text', 'qas'],\r\n num_rows: 281\r\n })\r\n})\r\n``` \r\n\r\nThis makes me suspect that the origin of the problem might be the cache: I didn't have this dataset in my cache, although I guess you already had it, before the code change introduced by #3110.\r\n\r\n@lhoestq might it be possible that the code change introduced by #3110 makes \"inaccessible\" all previously cached TAR-based datasets?\r\n- Before the caching system downloaded and extracted the tar dataset\r\n- Now it only downloads the tar dataset (no extraction is done)",
"I can't reproduce either in my environment (macos, python 3.7).\r\n\r\nIn your case it generates zero examples. This can only happen if the extraction of the TAR archive doesn't output the right filenames. Indeed if the `qasper` script can't find the right file to load, it's currently ignored and it returns zero examples. This case was not even considered when #3110 was developed since we considered the file names to be deterministic - and not depend on your environment.\r\n\r\nTherefore here is my hypothesis:\r\n- either the cache is corrupted somehow with an empty TAR archive\r\n- OR I suspect that the issue comes from python 3.8\r\n",
"I just tried again on python 3.8 and I was able to reproduce the issue. Let me work on a fix",
"Ok I found the issue. It's not related to python 3.8 in itself though. This issue happens because your local installation of `datasets` is outdated compared to the changes to datasets in #3110\r\n\r\nTo fix this you just have to pull the latest changes from `master` :)\r\n\r\nLet me know if that helps !\r\n\r\n--------------\r\n\r\nHere are more details about my investigation:\r\n\r\nIt's possible to reproduce this issue if you use `datasets<=1.15.1` or before b6469baa22c174b3906c631802a7016fedea6780 and if you load the dataset after revision b6469baa22c174b3906c631802a7016fedea6780. This is because `dl_manager.iter_archive` had issues at that time (and it was not used anywhere anyway).\r\n\r\nIn particular it was returning the absolute path to extracted files instead of the relative path of the file inside the archive. This was an issue because `dl_manager.iter_archive` isn't supposed to extract the TAR archive. Instead, it iterates over all the files inside the archive, without creating a directory with the extracted content.\r\n\r\nTherefore if you want to use the datasets on `master`, make sure that you have an up-to-date local installation of `datasets` as well, or you may face incompatibilities like this.",
"Thanks!\r\nBut what about code that is already using older version of datasets? \r\nThe reason I encountered this issue was that suddenly one of my repos with version 1.12.1 started getting 0 examples.\r\nI handled it by adding `revision` to `load_dataset`, but I guess it would still be an issue for other users who doesn't know this.",
"Hi, in 1.12.1 it uses the dataset scripts from that time, not the one on master.\r\n\r\nIt only uses the datasets from master if you installed `datasets` from source, or if the dataset isn't available in your local version (in this case it shows a warning and it loads from master).\r\n",
"OK, I understand the issue a bit better now.\r\nI see I wasn't on 1.12.1, but on 1.12.1.dev0 and since it is a dev version it uses master.\r\nSo users that use an old dev version must specify revision or else they'll encounter this problem.\r\n\r\nBTW, when I opened the issue I installed the latest master version with\r\n```\r\npip install git+git://github.com/huggingface/datasets@master#egg=datasets\r\n```\r\nand also used `download_mode=\"force_redownload\"`, and it still returned 0 examples.\r\nNow I deleted all of the cache and ran the code again, and it worked.\r\nI'm not sure what exactly happened here, but looks like it was due to a mix of an unofficial version and its cache.\r\n\r\nThanks again!"
] |
1,047,808,263
| 3,235
|
Addd options to use updated bleurt checkpoints
|
closed
| 2021-11-08T18:53:54
| 2021-11-12T14:05:28
| 2021-11-12T14:05:28
|
https://github.com/huggingface/datasets/pull/3235
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3235",
"html_url": "https://github.com/huggingface/datasets/pull/3235",
"diff_url": "https://github.com/huggingface/datasets/pull/3235.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3235.patch",
"merged_at": "2021-11-12T14:05:28"
}
|
jaehlee
| true
|
[] |
1,047,634,236
| 3,234
|
Avoid PyArrow type optimization if it fails
|
closed
| 2021-11-08T16:10:27
| 2021-11-10T12:04:29
| 2021-11-10T12:04:28
|
https://github.com/huggingface/datasets/pull/3234
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3234",
"html_url": "https://github.com/huggingface/datasets/pull/3234",
"diff_url": "https://github.com/huggingface/datasets/pull/3234.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3234.patch",
"merged_at": "2021-11-10T12:04:28"
}
|
mariosasko
| true
|
[
"That's good to have a way to disable this easily :)\r\nI just find it a bit unfortunate that users would have to experience the error once and then do `DISABLE_PYARROW_TYPES_OPTIMIZATION=1`. Do you know if there's a way to simply fallback on disabling it automatically when it fails ?",
"@lhoestq Actually, I agree a fallback makes more sense. The current approach is not very practical indeed and would require a mention in the docs.\r\n",
"Replaced the env variable with a fallback!",
"Hmm if the fallback automatically happens without the user knowing it, then I don't think we really need to mention it. But if you really wanted to, I think the [Improve performance](https://huggingface.co/docs/datasets/cache.html#improve-performance) section would be a great place for it! ",
"Yea I think this could just end up in a note that says that `datasets` automatically picks the most optimized integer precision for your tokenized text data to save you disk space. Maybe later if we have a page on text processing we can add this note, but for now I agree it doesn't fit well into the doc.\r\n\r\nIn particular in the \"Improve performance\" section we mention what users can do to speed up their computations, while this behavior is just some internal feature that users don't have control over anyway."
] |
1,047,474,931
| 3,233
|
Improve repository structure docs
|
closed
| 2021-11-08T13:51:35
| 2021-11-09T10:02:18
| 2021-11-09T10:02:17
|
https://github.com/huggingface/datasets/pull/3233
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3233",
"html_url": "https://github.com/huggingface/datasets/pull/3233",
"diff_url": "https://github.com/huggingface/datasets/pull/3233.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3233.patch",
"merged_at": "2021-11-09T10:02:17"
}
|
lhoestq
| true
|
[] |
1,047,361,573
| 3,232
|
The Xsum datasets seems not able to download.
|
closed
| 2021-11-08T11:58:54
| 2021-11-09T15:07:16
| 2021-11-09T15:07:16
|
https://github.com/huggingface/datasets/issues/3232
| null |
FYYFU
| false
|
[
"Hi ! On my side the URL is working fine, could you try again ?",
"> Hi ! On my side the URL is working fine, could you try again ?\r\n\r\nI try it again and cannot download the file (might because of my location). Could you please provide another download link(such as google drive)? :>",
"I don't know other download links - this is the one provided by the authors of the dataset. Maybe you can try downloading from another location ? There are several solutions: a VPN, a remote VM or Google Colab for example.",
"> I don't know other download links - this is the one provided by the authors of the dataset. Maybe you can try downloading from another location ? There are several solutions: a VPN, a remote VM or Google Colab for example.\r\n\r\n:> ok. Thanks for your reply."
] |
1,047,170,906
| 3,231
|
Group tests in multiprocessing workers by test file
|
closed
| 2021-11-08T08:46:03
| 2021-11-08T13:19:18
| 2021-11-08T08:59:44
|
https://github.com/huggingface/datasets/pull/3231
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3231",
"html_url": "https://github.com/huggingface/datasets/pull/3231",
"diff_url": "https://github.com/huggingface/datasets/pull/3231.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3231.patch",
"merged_at": "2021-11-08T08:59:43"
}
|
albertvillanova
| true
|
[] |
1,047,135,583
| 3,230
|
Add full tagset to conll2003 README
|
closed
| 2021-11-08T08:06:04
| 2021-11-09T10:48:38
| 2021-11-09T10:40:58
|
https://github.com/huggingface/datasets/pull/3230
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3230",
"html_url": "https://github.com/huggingface/datasets/pull/3230",
"diff_url": "https://github.com/huggingface/datasets/pull/3230.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3230.patch",
"merged_at": "2021-11-09T10:40:58"
}
|
BramVanroy
| true
|
[
"I also added the missing `pretty_name` tag in the dataset card to fix the CI"
] |
1,046,706,425
| 3,229
|
Fix URL in CITATION file
|
closed
| 2021-11-07T10:04:35
| 2021-11-07T10:04:46
| 2021-11-07T10:04:45
|
https://github.com/huggingface/datasets/pull/3229
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3229",
"html_url": "https://github.com/huggingface/datasets/pull/3229",
"diff_url": "https://github.com/huggingface/datasets/pull/3229.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3229.patch",
"merged_at": "2021-11-07T10:04:45"
}
|
albertvillanova
| true
|
[] |
1,046,702,143
| 3,228
|
Add CITATION file
|
closed
| 2021-11-07T09:40:19
| 2021-11-07T09:51:47
| 2021-11-07T09:51:46
|
https://github.com/huggingface/datasets/pull/3228
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3228",
"html_url": "https://github.com/huggingface/datasets/pull/3228",
"diff_url": "https://github.com/huggingface/datasets/pull/3228.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3228.patch",
"merged_at": "2021-11-07T09:51:46"
}
|
albertvillanova
| true
|
[] |
1,046,667,845
| 3,227
|
Error in `Json(datasets.ArrowBasedBuilder)` class
|
closed
| 2021-11-07T05:50:32
| 2021-11-09T19:09:15
| 2021-11-09T19:09:15
|
https://github.com/huggingface/datasets/issues/3227
| null |
JunShern
| false
|
[
"I have additionally identified the source of the error, being that [this condition](https://github.com/huggingface/datasets/blob/fc46bba66ba4f432cc10501c16a677112e13984c/src/datasets/packaged_modules/json/json.py#L124-L126) in the file\r\n`python3.8/site-packages/datasets/packaged_modules/json/json.py` is not being entered correctly:\r\n```python\r\n if (\r\n isinstance(e, pa.ArrowInvalid)\r\n and \"straddling\" not in str(e)\r\n or block_size > len(batch)\r\n ):\r\n```\r\n\r\nFrom what I can tell, in my case the block_size simply needs to be increased, but the error message does not contain \"straddling\" so the condition does trigger correctly and we fail to reach [the line to increase block_size](https://github.com/huggingface/datasets/blob/fc46bba66ba4f432cc10501c16a677112e13984c/src/datasets/packaged_modules/json/json.py#L135).\r\n\r\nChanging the condition above to simply\r\n```python\r\n if (\r\n block_size > len(batch)\r\n ):\r\n```\r\n\r\nFixes the error for me. I'm happy to create a PR containing this fix if the developers deem the other conditions unnecessary.",
"Hi ! I think the issue comes from the fact that your JSON file is not a valid JSON Lines file.\r\nEach example should be on one single line.\r\n\r\nCan you try fixing the format to have one line per example and try again ?",
":open_mouth: you're right, that did it! I just put everything on a single line (my file only has a single example) and that fixed the error. Thank you so much!"
] |
1,046,584,518
| 3,226
|
Fix paper BibTeX citation with proceedings reference
|
closed
| 2021-11-06T19:52:59
| 2021-11-07T07:05:28
| 2021-11-07T07:05:27
|
https://github.com/huggingface/datasets/pull/3226
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3226",
"html_url": "https://github.com/huggingface/datasets/pull/3226",
"diff_url": "https://github.com/huggingface/datasets/pull/3226.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3226.patch",
"merged_at": "2021-11-07T07:05:27"
}
|
albertvillanova
| true
|
[] |
1,046,530,493
| 3,225
|
Update tatoeba to v2021-07-22
|
closed
| 2021-11-06T15:14:31
| 2021-11-12T11:13:13
| 2021-11-12T11:13:13
|
https://github.com/huggingface/datasets/pull/3225
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3225",
"html_url": "https://github.com/huggingface/datasets/pull/3225",
"diff_url": "https://github.com/huggingface/datasets/pull/3225.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3225.patch",
"merged_at": "2021-11-12T11:13:13"
}
|
KoichiYasuoka
| true
|
[
"How about this? @lhoestq @abhishekkrthakur ",
"Hi ! I think it would be nice if people could still be able to load the old version.\r\nMaybe this can be a parameter ? For example to load the old version they could do\r\n```python\r\nload_dataset(\"tatoeba\", lang1=\"en\", lang2=\"mr\", date=\"v2020-11-09\")\r\n```\r\n\r\nIf it sounds good to you, we can add this parameter to the TatoebaConfig:\r\n```python\r\nclass TatoebaConfig(datasets.BuilderConfig):\r\n def __init__(self, *args, lang1=None, lang2=None, date=\"v2021-07-22\", **kwargs):\r\n self.date = date\r\n```\r\nand then pass the date to the URL\r\n```python\r\n_BASE_URL = \"https://object.pouta.csc.fi/OPUS-Tatoeba/{}/moses/{}-{}.txt.zip\"\r\n```\r\n```python\r\n def _base_url(lang1, lang2, date):\r\n return _BASE_URL.format(date, lang1, lang2)\r\n```\r\n\r\nWhat do you think ?",
"`_DATE = \"v\" + \"-\".join(s.zfill(2) for s in _VERSION.split(\".\"))` seems rather tricky but works well. How about this? @lhoestq \r\n",
"The CI is only failing because of the missing sections in the dataset card, and because of an issue with the CER metric that is unrelated to this PR"
] |
1,046,495,831
| 3,224
|
User-pickling with dynamic sub-classing
|
closed
| 2021-11-06T12:08:24
| 2025-03-26T19:45:37
| 2025-03-26T19:45:36
|
https://github.com/huggingface/datasets/pull/3224
|
{
"url": "https://api.github.com/repos/huggingface/datasets/pulls/3224",
"html_url": "https://github.com/huggingface/datasets/pull/3224",
"diff_url": "https://github.com/huggingface/datasets/pull/3224.diff",
"patch_url": "https://github.com/huggingface/datasets/pull/3224.patch",
"merged_at": null
}
|
BramVanroy
| true
|
[
"@lhoestq Feel free to have a look. The implementation is slightly different from what you suggested. I have opted to overwrite `save` instead of meddling with `save_global`. `save_global` is called very late down in dill/pickle so it is hard to control for what is happening there. I might be wrong. Pickling is more complex than I thought! \r\n\r\nThe linked issue (`map` with spaCy) also works now!\r\n\r\n```python\r\nimport pickle\r\nimport spacy\r\nfrom spacy import Language\r\nfrom datasets import load_dataset\r\nfrom datasets.utils.py_utils import dumps, pklregister\r\n\r\n@pklregister(Language, allow_subclasses=True)\r\ndef hash_spacy_language(pickler, nlp: Language):\r\n pickler.save(nlp.to_bytes())\r\n\r\ndef main():\r\n fin = r\"large/file.txt\"\r\n nlp = spacy.load(\"en_core_web_sm\")\r\n\r\n def tokenize(l):\r\n return {\"tok\": [t.text for t in nlp(l[\"text\"])]}\r\n\r\n ds = load_dataset(\"text\", data_files=fin)\r\n ds = ds[\"train\"].map(tokenize)\r\n\r\n # Sanity check: load NLP from pickle created with our own `dumps`\r\n config = nlp.config\r\n lang_cls = spacy.util.get_lang_class(config[\"nlp\"][\"lang\"])\r\n nlp2 = lang_cls.from_config(config)\r\n nlp2.from_bytes(pickle.loads(dumps(nlp)))\r\n\r\n assert isinstance(nlp2, type(nlp))\r\n assert dumps(nlp) == dumps(nlp2)\r\n\r\nif __name__ == '__main__':\r\n main()\r\n```\r\n\r\nIf this all looks good to you, I'll start writing on some documentation and examples.\r\n",
"One more thing. This is a reduction function for SpaCy Language that should work with the new API:\r\n```python\r\n@pklregister(Language, allow_subclasses=True)\r\ndef hash_spacy_language(pickler, obj):\r\n def create_language(config, bytes_data):\r\n lang_cls = spacy.util.get_lang_class(config[\"nlp\"][\"lang\"])\r\n nlp = lang_cls.from_config(config)\r\n return nlp.from_bytes(bytes_data)\r\n\r\n args = (obj.config, obj.to_bytes())\r\n pickler.save_reduce(create_language, args, obj=obj)\r\n```\r\nso IMO we are missing a test with `pickler.save_reduce`. ",
"> One more thing. This is a reduction function for SpaCy Language that should work with the new API:\r\n> \r\n> ```python\r\n> @pklregister(Language, allow_subclasses=True)\r\n> def hash_spacy_language(pickler, obj):\r\n> def create_language(config, bytes_data):\r\n> lang_cls = spacy.util.get_lang_class(config[\"nlp\"][\"lang\"])\r\n> nlp = lang_cls.from_config(config)\r\n> return nlp.from_bytes(bytes_data)\r\n> \r\n> args = (obj.config, obj.to_bytes())\r\n> pickler.save_reduce(create_language, args, obj=obj)\r\n> ```\r\n> \r\n> so IMO we are missing a test with `pickler.save_reduce`.\r\n\r\nSure that seems a good idea, but I do not quite understand what `save_reduce` does. Could you give some more info about what reduce functions do and how they differ from regular `save` and `save_global`? I've read about it but the docs nor the built-in `pickle` code seem really helpful.",
"I'm no pickle expect, but here is my understanding. I believe the pickler uses the reduce function when you do `loads` to reconstructs the original object from the parameters/arguments that were saved with `dumps`.\r\n\r\nFor example your sanity check could be simplified from\r\n```python\r\n config = nlp.config\r\n lang_cls = spacy.util.get_lang_class(config[\"nlp\"][\"lang\"])\r\n nlp2 = lang_cls.from_config(config)\r\n nlp2 = nlp2.from_bytes(pickle.loads(dumps(nlp)))\r\n```\r\nto\r\nEDIT: <s>pickle.loads(pickle.dumps(nlp))</s>\r\n```python\r\n nlp2 = loads(dumps(nlp)) # using our custom pickler\r\n```\r\n\r\nThough note that while it can be convenient for tests, we actually don't care about the reconstruction of the object since we're only using the pickler for `dumps` to compute hashes.",
"> I'm no pickle expect, but here is my understanding. I believe the pickler uses the reduce function when you do `loads` to reconstructs the original object from the parameters/arguments that were saved with `dumps`.\r\n> \r\n> For example your sanity check could be simplified from\r\n> \r\n> ```python\r\n> config = nlp.config\r\n> lang_cls = spacy.util.get_lang_class(config[\"nlp\"][\"lang\"])\r\n> nlp2 = lang_cls.from_config(config)\r\n> nlp2 = nlp2.from_bytes(pickle.loads(dumps(nlp)))\r\n> ```\r\n> \r\n> to\r\n> \r\n> ```python\r\n> nlp2 = pickle.loads(pickle.dumps(nlp))\r\n> ```\r\n> \r\n> Though note that while it can be convenient for tests, we actually don't care about the reconstruction of the object since we're only using the pickler for `dumps` to compute hashes.\r\n\r\nYes, the sanity check can be simplified like that _if_ we use `pickle.dumps` - but that would not test our own `dumps` functionality and would do a naive dump instead of using `to_bytes`. It won't work if we use our own `dumps`, exactly because of the reason that we want custom pickling and being able to call `to_bytes`. To reconstruct the object from the pickled bytes from `to_bytes` we need `from_bytes`. The result of pickle/dill loads will therefore always be a `bytes` object and not a `Language` object.\r\n\r\nBut `save_reduce` is called when saving, right? Not when loading, AFAICT. I am just not sure what exactly it is saving. It is _potentially_ called [at the end of `save`](https://github.com/python/cpython/blob/24af9a40a8f85af813ea89998aa4e931fcc78cd9/Lib/pickle.py#L603) but only if we haven't returned by then. I just can't figure out what that base case is.",
"I don't think we expect users to write the reduce function that isn't going to be used anyway. So maybe let's stick with `save` ?",
"@BramVanroy \r\nAs I understand `save_reduce` is very similar to `copyreg.pickle`, so I'd suggest you to check the following links:\r\n* https://docs.python.org/3/library/copyreg.html#copyreg.pickle\r\n* https://docs.python.org/3/library/pickle.html#object.__reduce__\r\n\r\n\r\n@lhoestq \r\n> I don't think we expect users to write the reduce function that isn't going to be used anyway. So maybe let's stick with save ?\r\n\r\nI agree. \r\n\r\n`save_reduce` is very similar to `copyreg.pickle` and `object.__reduce__`, which are part of public API (and `save` isn't), so I expect more advanced users to know how to write their own reduction functions. But, as you say, `pklregister` should also work with `save` (even though I think `save` is a bit lower-level, and harder to understand than `save_reduce`).\r\n\r\nAll our examples in `py_utils` that use `pklregister` also use `save_reduce` in the last step, so my reduction for SpaCy is meant to be added there, and not to be written by users (because SpaCy is very popular, so the official support by us makes sense :)).\r\n\r\nAnd in the tests, let's ignore the reconstruction part of pickle/dill, because it's not important for us, and focus on the generated dumps. What do you think?",
"@mariosasko What exactly do you mean with \"isn't part of the public API\"? It is [a public method](https://github.com/python/cpython/blob/24af9a40a8f85af813ea89998aa4e931fcc78cd9/Lib/pickle.py#L535) in base pickle, just like `dump` is but maybe you mean something else.",
"@BramVanroy Oh sorry, it's public (not prefixed with `\"_\"`) but it's not documented in the docs. `save_reduce` is also not in the docs, but its signature/functionality is similar to `copyreg.pickle` and I see it more often being used in the projects on GH, so it's seems \"more public\" to me. ",
"Unfortunately I feel that pickle in general is under-documented. 😄 \r\n\r\nFor the documentation, I can add a brief example, maybe under \"How-to Guides\"? The only thing that isn't immediately obvious to me is how I can add that doc page to the TOC?",
"Yes great idea ! To add that doc page to the TOC, you just have to add it to the index.rst file in the \"How-to guides\" TOC section",
"@mariosasko @lhoestq Feel free to make any edits or suggestions in the text!",
"Hi @mariosasko. I wish you'd told me sooner, as I spent quite some time writing on this.\r\n\r\nI'm also not sure whether it is too advanced to have in the documentation. The spaCy use-case seems potentially frequent. Or do you wish to add that case to the defaults, and whenever new issues come up that seem like frequent/obvious cases, add those internally as well?",
"Documenting the internal `pklregister` is overkill IMO (and it can be kept in docstrings), but we can document something higher level like `register_hash_func` once it's implemented.\r\n\r\nSo we keep the nice documentation you've written (thank you!), except we can rename it to \"Advanced caching\" and show an API that is similar to\r\n```python\r\n>>> @register_hash_func(Language, allow_subclasses=True)\r\n>>> def hash_spacy_language(nlp: Language):\r\n>>> return (nlp.to_bytes(),)\r\n```\r\nThis way we keep the documentation centered around the public API rather than the internals that may evolve/be too complicated to fit only one section.\r\n\r\n> Or do you wish to add that case to the defaults, and whenever new issues come up that seem like frequent/obvious cases, add those internally as well?\r\n\r\nLet's add it to the defaults since it's a frequent use-case. And also allow users to control the hashing using the API mentioned above if they face other non-trivially-hashable objects",
"Sure, I can have a go at implementing spaCy as a built-in. Should it be included in the tests? (Therefore adding spaCy to the tests requirements.)\r\n\r\nNext, from your example, it seems that the return value of `register_hash_func` will be used in pickler.save automatically (calling pklregister a bit deeper). Any reason why it returns a tuple? I can work on this as well, if needed.",
"> Sure, I can have a go at implementing spaCy as a built-in. Should it be included in the tests? (Therefore adding spaCy to the tests requirements.)\r\n\r\nThat would be perfect !\r\n\r\n> Next, from your example, it seems that the return value of register_hash_func will be used in pickler.save automatically (calling pklregister a bit deeper). \r\n\r\nYes I think so. For example register_hash_func can call pklregister with the user's function, but wrapped to use pickler.save.\r\n\r\n> Any reason why it returns a tuple? I can work on this as well, if needed.\r\n\r\nIt can either return an arbitrary object or a tuple. I like it a bit better if it's a tuple, so users understand more easily how to make the function take into account more than one item for the hash. It's also consistent with the streamlit caching functions, that also require a tuple. No strong opinion on this though\r\n\r\nLet me know if I can help with anything",
"@lhoestq I do not have the time anymore to work on this. Can someone else pick this up?",
"Hi ! Sure someone else can continue this PR (either someone from HF, or other contributors can fork the PR).\r\nI think I can work on this next week or the week after, but if anyone wants to work on this earlier feel free to comment here :)"
] |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.