id stringlengths 4 10 | text stringlengths 4 2.14M | source stringclasses 2
values | created timestamp[s]date 2001-05-16 21:05:09 2025-01-01 03:38:30 | added stringdate 2025-04-01 04:05:38 2025-04-01 07:14:06 | metadata dict |
|---|---|---|---|---|---|
2531998898 | Remove clock TODO from scrabble-score
Towards #62
Hi, I know I posted the track but I don't seem to be paying much attention, things are different in my life at the moment and I can't look at the computer since I'm working tho. I don't know how long it will be but it may or may not continue for a while as days. I apologize to everyone
| gharchive/pull-request | 2024-09-17T19:54:06 | 2025-04-01T06:44:07.103058 | {
"authors": [
"BNAndras",
"GroophyLifefor"
],
"repo": "exercism/batch",
"url": "https://github.com/exercism/batch/pull/65",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
796880366 | Build Representer and Analyzer
This issue is part of the migration to v3. You can read full details about the various changes here.
Representer
In Exercism v3, we're introducing a new (optional) tool: the representer. The goal of the representer is to take a solution and returning a representation, which is an extraction of a solution to its essence with normalized names, comments, spacing, etc. but still uniquely identifying the approach taken. Two different ways of solving the same exercise must not have the same representation.
Each representer is track-specific. When a new solution is submitted, we run the track's representer, which outputs two JSON files that describe the representation.
Once we have a normalized representation for a solution, a team of vetted mentors will look at the solution and comment on it (if needed). These comments will then automatically be submitted to each new solution with the same representation. A notification will be sent for old solutions with a matching representation.
Each track should build a representer according to the spec. For tracks building a representer from scratch, we have a starting guide.
The representer is an optional tool though, which means that if a track does not have a representer, it will still function normally.
Analyzer
In Exercism v3, we are making increased use of our v2 analyzers. Analyzers automatically assess student's submissions and provide mentor-style commentary. They can be used to catch common mistakes and/or do complex solution analysis that can't easily be done directly in a test suite.
Each analyzer is track-specific. When a new solution is submitted, we run the track's analyzer, which outputs a JSON file that contains the analysis results.
In v2, analyzer comments were given to a mentor to pass to a student. In v3, the analyzers will normally output directly to students, although we have added an extra key to output suggestions to mentors. If your track already has an analyzer, the only requisite change is updating the outputted copy to be student-facing.
Each track should build an analyzer according to the spec. For tracks building an analyzer from scratch, we have a starting guide.
The analyzer is an optional tool though, which means that if a track does not have an analyzer, it will still function normally.
Goal 1
Build a representer for your track according to the spec. Check this page to help you get started with building a representer.
Note that the simplest representer is one that merely returns the solution's source code.
It can be very useful to check how other tracks have implemented their representer.
Goal 2
Build an analyzer for your track according to the spec. Check this page to help you get started with building an analyzer.
It can be very useful to check how other tracks have implemented their analyzer.
Choosing between representer and analyzer
If you want to build both, we recommend starting by building the representer for the following reasons:
Representers are usually (far) easier to implement
Representers can have a far bigger impact on the mentoring load than analyzers by empowering mentors
Representers apply to all exercises, whereas analyzers usually target specific exercises or a subset
Tracking
https://github.com/exercism/v3-launch/issues/8
We're closing this issue as two separate issues have been created to replace this combined issue.
| gharchive/issue | 2021-01-29T13:26:02 | 2025-04-01T06:44:07.112972 | {
"authors": [
"ErikSchierboom"
],
"repo": "exercism/cfml",
"url": "https://github.com/exercism/cfml/issues/111",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
1603108246 | Append jq-specific instructions to gigasecond
Summary
Follows #148
Closes #149
The blended instructions will look like
# Instructions
Your task is to determine the date and time one gigasecond after a certain date.
A gigasecond is one thousand million seconds.
That is a one with nine zeros after it.
If you were born on _January 24th, 2015 at 22:00 (10:00:00pm)_, then you would be a gigasecond old on _October 2nd, 2046 at 23:46:40 (11:46:40pm)_.
To solve this exercise in jq, you'll need to use the [builtin datetime functions][date-funcs].
jq can only parse datetime strings in full ISO8601 format: `1970-01-01T00:00:00Z`
[date-funcs]: https://stedolan.github.io/jq/manual/v1.6/#Dates
| gharchive/pull-request | 2023-02-28T13:47:19 | 2025-04-01T06:44:07.136550 | {
"authors": [
"glennj"
],
"repo": "exercism/jq",
"url": "https://github.com/exercism/jq/pull/150",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
1639381653 | fizz-buzz: add tests and improve instructions
I felt like the tests could maybe be a bit more gradual in ramping up the difficulty.
I also slightly rephrased the instructions.
Let me know what you think.
@jonmcalder Fair point! I've updated
Thanks!
| gharchive/pull-request | 2023-03-24T13:19:30 | 2025-04-01T06:44:07.164993 | {
"authors": [
"ErikSchierboom",
"jonmcalder"
],
"repo": "exercism/r",
"url": "https://github.com/exercism/r/pull/232",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
222150657 | [Proposal] Use the Ava Test runner
Ava is a new javascript test runner that claims to be futuristic. It built-in babel which allows us to write and run tests in ES2017 without the need of any other tool.
Only thing here is that it does not compile the source code, just the tests. As mentioned in ava's README, this can be easily fixed by using babel-register which hooks into ava and transpiles ESNext code on the fly while running tests.
All it takes is this small snippet of code in package.json:
"ava": {
"require": [
"babel-register"
]
}
For our use case (of small exercises), this completely eliminates the need for bundling tools like gulp and to maintain the huge gulpfile and pass it along to the users with each exercise. Only thing we need to pass to users is package.json.
To demonstrate what it looks like I ported the first two exercises hello and leap to use ava tests in this repository. hello uses the standard xunit style that ava gives out of the box. While leap uses the BDD style which is provided by ava-spec.
PS: I also took the opportunity to use the latest ES using babel-preset-env which addresses my previous issue #259.
If maintainers agree, I would like to work on this.
@tejasbubane this looks very cool. Myself I have been thinking about proposing migrating to using Jest, which appears to provide similar benefits.
Both projects appear similar in popularity, I'm not sure there's a compelling case for migrating to one versus the other. My familiarity with Jest comes from its association with React, which is of course enormously popular these days.
I think there is another consideration involved here though: the gulpfile provides an example of what a typical Javascript build pipeline looks like these days, and I think that's invaluable. Not every user will investigate that, but we should consider that aspect as well.
I have also been thinking about proposing changing the build to use Webpack, which has value for the same reasons that using Gulp has, but is more current technology.
@rchavarria what do you think about this? Is it better to have a dead simple exercise environment, or to help expose users to build tools? @tejasbubane what are your thoughts?
Is it better to have a dead simple exercise environment, or to help expose users to build tools? @tejasbubane what are your thoughts?
I am more of a simple environment guy.
Correct me if I am wrong, but build env and frameworks are not the core focus of exercism. We can probably add some resources to build tools and environments in the resources section.
I should probably investigate jest in context of exercism and see if it works the same way.
To be fair, I have become a fan of on-the-fly transpilation (using babel-register) which may be the reason I am biased towards this approach.
I haven't heard about Ava, and I've heard about Jest a little bit. So, I have no strong opinion on any of them. But something is clear, build tools are evolving.
For this track, it started using a build tool because of the need of the transpilation step. Nowadays, it seems to be better solved issue.
I don't care too much if we use Ava or Jest, but it seems that any of them will simplify things for final users, and that's a good thing.
We could start thinking about what we want to acomplish, more than the tool we want to use. How would final users use Ava or Jest? Is a complex installation needed? Is it complex to run tests? Sorry if the questions look stupid, but I don't know about Ava or Jest.
I don't care too much if we use Ava or Jest, but it seems that any of them will simplify things for final users, and that's a good thing.
We could start thinking about what we want to acomplish, more than the tool we want to use.
Good point. 👍
How would final users use Ava or Jest? Is a complex installation needed? Is it complex to run tests?
In my case, all a user needs to do is cd into the exercise directory, run npm install and then run npm test. The package.json has ava and babel as devDependencies and a script to run ava.
It looks promising. I'm worried about two things:
What happens to users with some completed exercises on this track? Your workflow seem identical to the current one (npm install, npm test, well the current one can be run as gulp test).
Should test specs be modified? Now, they are based on Jasmine. Does Ava follow the same approach? I mean, describe blocks with it blocks, where it blocks are the spec,...
I can speak to one thing: Jest uses essentially the same syntax as Jasmine, FWIW. I have so far been able to run existing tests with no modifications, although I could imagine there might be some matchers that might not work out of the box. @tejasbubane how about Ava?
So @rchavarria @tejasbubane I did some further checking in to this.
Ava does not use the same syntax, so the tests would have to be rewritten.
Jest can be configured to automatically transpile. This would greatly simplify the directory structure. We could change the devDependencies in package.json to be simply:
"devDependencies": {
"babel-jest": "^19.0.0",
"babel-preset-env": "^1.4.0",
"jest": "^19.0.2"
},
and we would need to serve a .babelrc file:
{
"presets": ["env"]
}
The tests can then simply be run by calling jest from the command line in the exercise directory-- no arguments needed.
That would eliminate the need for the gulp build pipeline for testing. If we wanted to continue to provide linting as an option, we could do that, providing an npm script for doing test, linting, or linting then testing as we wanted. It would be pretty simple to set up.
@tejasbubane I feel like the idea behind making the process simpler for the users is very valuable. My gut is telling me that we'd be better off making this change using Jest than Ava, because it wouldn't require changing the tests themselves and the benefits are equivalent.
If we can get agreement on this I'm happy to do the work or work on it with others. LMK.
If Ava uses a different syntax... I wouldn't go that path.
Instead of having a .babelrc file, would it be possible to include it in package.json? I know other tools (such as ESLint) support that. It's just to have less files moving around.
I like the idea of having a linting tool. I hope npm scripts will remain simple.
What do you think @tejasbubane ?
If Ava uses a different syntax... I wouldn't go that path.
Yes Ava uses a different syntax. So if jest works with the given syntax, (which it should since it uses jasmine under the hood) it makes sense to the Jest way. I am not sure what all config will be required and if it will comsume ES6 code directly without the need of a build tool.
I will put together a small repo with all jest config for couple of exercises like I did for ava.
@tejasbubane @rchavarria this sounds like a good plan to me. @tejasbubane see my comments above, it was trivial to get it working. If we could get @rchavarria's suggestion about getting the babel config into package.json instead of a separate file, that would be awesome. I played around with it for a couple of minutes without success, but if it's doable that would be preferable-- one less file to serve!
I know other tools use the approach of extending the package.json file. Don't spend too much time with that because I don't even know if it's possible or not. I was just speaking my mind, without knowing the possibilities of the tool. Sorry if that confused you 😞
@tejasbubane I tried to reach you directly via gitter today-- I got so excited about this idea that I have opened a PR. @rchavarria if you would have a look too please, I think this will work. It may resolve a few other issues in the process.
| gharchive/issue | 2017-04-17T15:05:49 | 2025-04-01T06:44:07.200230 | {
"authors": [
"matthewmorgan",
"rchavarria",
"tejasbubane"
],
"repo": "exercism/xecmascript",
"url": "https://github.com/exercism/xecmascript/issues/272",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
} |
168194837 | Elaborate a bit more on how to run the tests for the first time
This PR adds a more detailed explanation about how a user should run the tests for the first time, because some users didn't find it easy to start running them (see #284).
Addresses #289
@kytrinyx Let me know if you think this PR addresses the issue described on #284 correctly. If so, I would take care and merge it.
Instead of duplicating configuration and fetching instructions I just linked to the CLI overview. BTW, I miss how to fetch a problem on that overview. I can create a issue and write a couple of paragraphs to fix it if you want.
I removed the link ending with #installing. I tried and it doesn't work. Users should read the text in this PR having installing JavaScript instructions on the left side of the screen, so a link shouldn't be needed.
I can create a issue and write a couple of paragraphs to fix it if you want.
Yes please!
I think this is good to go.
@rchavarria @kytrinyx Thanks!
| gharchive/pull-request | 2016-07-28T20:56:40 | 2025-04-01T06:44:07.204472 | {
"authors": [
"kytrinyx",
"matthewmorgan",
"rchavarria"
],
"repo": "exercism/xjavascript",
"url": "https://github.com/exercism/xjavascript/pull/297",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
} |
109446417 | Revert Snapshots & Better Kafka Events
Allow revert snapshots. This is essentially a backport of the 4.6 functionality.
EventBus messages are now produced with additional fields to lower the query overhead in consumers.
[X] Backport revert snapshot logic
[X] Wire in new component: StorageSystemSnapshotStrategy
[X] Inject implementation for new component
[X] Add fields to event bus messages
[X] Version the schema of sent payload
@llambiel @brutasse last review needed and we're good to go.
Latest commit should be split in two.
LGTM
| gharchive/pull-request | 2015-10-02T08:00:34 | 2025-04-01T06:44:07.223039 | {
"authors": [
"llambiel",
"pyr",
"vincentbernat"
],
"repo": "exoscale/cloudstack",
"url": "https://github.com/exoscale/cloudstack/pull/8",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
2686361764 | add perplexity
Example to get the latest geopolitical news.
from edsl import Model
from edsl import QuestionList, Survey
m = Model("llama-3.1-sonar-huge-128k-online")
common_question_text = "What are the top 10 news in past 24 hours regarding {}?"
topics = ["EU", "Nato", "Ukraine war", "South America", "Middle East"]
questions = [QuestionList(question_name=f"q{i+1}", question_text=common_question_text.format(topic)) for i, topic in enumerate(topics)]
s = Survey(questions=questions)
results = s.by(m).run(disable_remote_inference=True, cache=False)
answers = results.data[0]["answer"]
for q in answers:
print("##########")
print("Response for question ",q)
top_news = answers[q]
for news in top_news:
print(news)
awesome - this will be very useful
| gharchive/pull-request | 2024-11-23T18:08:08 | 2025-04-01T06:44:07.237095 | {
"authors": [
"johnjosephhorton",
"zer0dss"
],
"repo": "expectedparrot/edsl",
"url": "https://github.com/expectedparrot/edsl/pull/1311",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
2606160216 | Add BERTScore as potential "non-LLM" metric / MetricWithEmbedding for context-recall and context-precision
Describe the Feature
Add BERTScore as additional evaluation metric scorer for context-precision and context-recall.
Why is the feature important for you?
As a RAGAS user trying to evaluate/benchmark my RAG applications, I would like metrics that are more deterministic than LLM-as-a-Judge and more advanced and indicative of actual recommendation performance than naive string matching. BERTscore uses embeddings to compare documents and is flexible wrt. the embedding model used. This does not require invoking LLMs (so can be run on an analyst machine locally) and provides research-validated scores that are replicable.
Additional context
[1904.09675] BERTScore: Evaluating Text Generation with BERT
bert_score/bert_score/score.py at master · Tiiiger/bert_score
BERT Score - a Hugging Face Space by evaluate-metric
The BERTscore package has not been updated recently; the recommended microsoft/deberta-xlarge-mnli model only allows ~500 tokens. Models with longer context (allenai/longformer-large-4096-finetuned-triviaqa and microsoft/deberta-v3) do not perform as well, and modern embedding models (nomic-embed-*, baii/bge-*) are untested.
It would be interesting to see what happens using the same embedding model used in the RAG pipeline; that way you only have to embed the answer since you already have access the chunk embeddings from the RAG lookup.
@shahules786 what do you think? could we rework https://docs.ragas.io/en/latest/concepts/metrics/available_metrics/semantic_similarity/ for this?
I take back my suggestion re: being able to reuse embeddings -- BERTScore is calculated based on token-level embeddings.
To prevent adding a dependency on bert-score, I may just try to hack a custom Metric that calls BertScore internally.
@ahgraber I have used BERTSCORE in the past, just that with the state of improvement in embeddings /LLMs I feel it doesn't make sense to adopt it anymore. It's not deterministic either. But if users feel adding it to ragas adds value, we can take a look at that. If not please feel free to close the issue.
@shahules786 In your experience, does [cosine] similarity over text embeddings effectively replace BERTscore?
| gharchive/issue | 2024-10-22T18:20:18 | 2025-04-01T06:44:07.269105 | {
"authors": [
"ahgraber",
"jjmachan",
"shahules786"
],
"repo": "explodinggradients/ragas",
"url": "https://github.com/explodinggradients/ragas/issues/1555",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
2662625302 | Duplicate Questions and Spelling Mistakes in Generated Testset
[ ] I checked the documentation and related resources and couldn't find an answer to my question.
Your Question
When using the TestsetGenerator from the ragas.testset module, I am encountering the following issues:
Duplicate questions: The generated test set often contains repeated questions.
Spelling mistakes: The generated questions contain spelling errors (e.g., "Presidnet" instead of "President", "spesial meting" instead of "special meeting").
Code Examples
Initialize the LLM wrapper
generator_llm = LangchainLLMWrapper(ChatOpenAI(model="gpt-4"))
Initialize the Embeddings wrapper
generator_embeddings = LangchainEmbeddingsWrapper(OpenAIEmbeddings())
from ragas.testset import TestsetGenerator
generator = TestsetGenerator(llm=generator_llm, embedding_model=generator_embeddings)
dataset = generator.generate_with_langchain_docs(docs, testset_size=5)
Additional context
Sample Output:
What does the term 'The Site of the University of Missouri' refer to according to the Board Bylaws?
What is the role of the Presidnet in the University of Missouri as per the Board of Curators?
Who can call a spesial meting of the Board?
What are the responsibilities of the Board of Curators as per the Board Bylaws?
What are the responsibilities of the Board of Curators at the University of Missouri?
What are the responsibilities of the Board of Curators at the University of Missouri?
Hey @Jayashree-kalabhavi
duplicate questions: we will take a look at this. This is related to one the issues on the roadmap
spelling mistakes: they are induced because of the query style = misspelled queries. As of now it's not fully configured by user. But we will add that too in the roadmap.
Thanks for reporting.
| gharchive/issue | 2024-11-15T17:16:55 | 2025-04-01T06:44:07.274809 | {
"authors": [
"Jayashree-kalabhavi",
"shahules786"
],
"repo": "explodinggradients/ragas",
"url": "https://github.com/explodinggradients/ragas/issues/1682",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
638075696 | Order placing not working
When I try to submit order by cash app close automatically or its redirect to home .
ok, will fix, thanks
fixed
| gharchive/issue | 2020-06-13T01:56:46 | 2025-04-01T06:44:07.276059 | {
"authors": [
"explorewithnick",
"explorewithnik",
"ravindrasail"
],
"repo": "explorewithnick/GroceryStore",
"url": "https://github.com/explorewithnick/GroceryStore/issues/1",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
1342100820 | Cannot build Android app on Windows "no such directory, lstat 'C:\c..."
Build/Submit details page URL
No response
Summary
When trying to build an app for Android on Windows I get the error no such directory, lstat 'C:\c\... which obviously doesn't exist, since there is no 'c' folder inside C:\
EAS CLI is trying using the Linux path /c/... on Windows.
Managed or bare?
Managed
Environment
expo-env-info 1.0.5 environment info:
System:
OS: Windows 7 6.1.7601
Binaries:
Node: 14.16.1 - C:\Program Files\nodejs\node.EXE
Yarn: 1.22.19 - ~\AppData\Roaming\npm\yarn.CMD
npm: 6.14.12 - C:\Program Files\nodejs\npm.CMD
npmPackages:
@expo/webpack-config: ^0.17.0 => 0.17.0
expo: latest => 46.0.2
react: 18.0.0 => 18.0.0
react-dom: 18.0.0 => 18.0.0
react-native: ^0.69.4 => 0.69.4
react-native-web: latest => 0.18.7
Expo Workflow: managed
× Dependency tree validation for expo-modules-autolinking failed. This validation is only available on Node 16+ / npm 8.
× Dependency tree validation for @expo/config-plugins failed. This validation is only available on Node 16+ / npm 8.
× Dependency tree validation for @expo/prebuild-config failed. This validation is only available on Node 16+ / npm 8.
× Dependency tree validation for @unimodules/core failed. This validation is only available on Node 16+ / npm 8.
× Dependency tree validation for @unimodules/react-native-adapter failed. This validation is only available on Node 16+ / npm 8.
× Dependency tree validation for react-native-unimodules failed. This validation is only available on Node 16+ / npm 8.
🎉 Didn't find any issues with the project!
Error output
PS E:\ReactNative\app> eas build -p android
✔ Linked to project @ttfh/**** (https://expo.dev/accounts/ttfh/projects/****)
✔ Using remote Android credentials (Expo server)
✔ Using Keystore from configuration: Build Credentials **** (default)
Compressing project files and uploading to EAS Build. Learn more: https://expo.fyi/eas-build-archive
Error: ENOENT: no such file or directory, lstat 'E:\e\ReactNative\app'
Code: ENOENT
Reproducible demo or steps to reproduce from a blank project
Execute eas build -p android on Windows
It works on Linux, but I don't want to copy my project to a different computer every time I need to make a new build
It works for me on Windows:
Can you please tell me a little more about your setup? Can you share eas.json?
eas.json
{
"cli": {
"version": ">= 0.60.0"
},
"build": {
"development": {
"android": {
"buildType": "apk"
}
},
"preview": {},
"production": {}
},
"submit": {
"production": {}
}
}
Build command:
eas build -p android --profile development
It works fine on Linux, but on Windows it's seems it's not detecting the operative system correctly and appending the drive letter at the beginning of the path.
@dsokal I found the problem.
I'm using eas version: eas-cli/0.60.0 win32-x64 node-v14.16.1
The program crash on build.js:110
const projectTarball = await (0, repository_1.makeProjectTarballAsync)();
It calls repository.js:80
await (0, vcs_1.getVcsClient)().makeShallowCopyAsync(shallowClonePath);
That calls local.js:73
async function makeShallowCopyAsync(src, dst) {
In this function src has the value:
src = "\e\ReactNative\app";
instead of:
src = "E:\ReactNative\app";
Not sure where the value comes from or why it's wrong
| gharchive/issue | 2022-08-17T17:59:13 | 2025-04-01T06:44:07.308634 | {
"authors": [
"TTFH",
"dsokal"
],
"repo": "expo/eas-cli",
"url": "https://github.com/expo/eas-cli/issues/1284",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
2432665599 | Language support for VSCode?
Thanks for the awesome project!
I'm considering using expr embedded within a product, however I'd want to ensure my end users get syntax highlighting within their editor (VSCode support as a minimum). Without this end users aren't going to have the best possible experience.
I can't really expect them to use the standalone expr editor given that by its nature this is embedded within other syntaxes and contexts (so users pulling out the expression to work on in another editor is too much friction).
I can see on the docs site you've got expr blocks highlighted and you're using prism, but I couldn't track down how that was being implemented.
Do you already have a TextMate grammar, language server or VSCode extension? If not, can something along these lines be added?
VSCode extention for Expr is in the works. 😉
But difficult comes with providing Env completions and embedding in other languages. For now it will be more like a separate highlighter for separate files.
How do you use Expr? How do you think highlighter should work?
For us, expressions will appear within a yaml block which is in turn within markdown frontmatter.
Completions etc would be lovely, but the main things are highlighting (followed by diagnostics).
For highlighting - if there's a TextMate language/grammar spec created for your VSCode extension, then that can also be embedded in other language extensions created by users adding expr to their tools. Language only extensions are pretty straightforward to create - HCL is one example here.
For diagnostics - there's a few ways to skin this cat, but as long as we can run validation of an expression without choking on the absence of runtime variables then users can create their own diagnostics and a lightweight language server.
Of the two, diagnostics is likely the easier to solve as a user of expr, but the highlighting really isn't something I'd want to be implementing from the outside without any formal spec for the language.
Would you be able to share/open source whatever code you have that enables highlighting of expr on the docs site? I imagine that would massively speed up any attempts to create embedded highlighting.
Sure. Will try to shape it into some sort of a package.
But how you will embed one grammar into YAML?
This is actually possible with Expr Editor, btw.
Perhaps I've misunderstood Expr Editor, but I thought it was a standalone tool.
If that's the case, then I couldn't really make use of it in the context Expr is used. My end users will be editing my config syntax within their own IDEs, with Expr being one part of that wider syntax. It'd be a big ask to have them change their local dev flow and tooling in order to make best use of the expression syntax I've chosen.
You can embed languages by matching the key and defining it as using a specific grammar. GitHub Actions do this with the GitHub Actions VSCode extension (also on their expressions). If you check that out, you'll notice that whilst it's YAML, the if statements still highlight correctly rather than as strings with that extension installed.
There's a few ways to support embedded languages though, this VSCode doc goes into more detail.
Cool. Will definitely check this out.
| gharchive/issue | 2024-07-26T17:34:56 | 2025-04-01T06:44:07.421311 | {
"authors": [
"antonmedv",
"manterfield"
],
"repo": "expr-lang/expr",
"url": "https://github.com/expr-lang/expr/issues/690",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
107625211 | Two routers mounted at same path do not isolate their middleware from each other
Using router.use seems to be documented to allow you to add middleware that will only be called for routes added to that router, but that does not seem to be working for me. The issue seems to be because I'm mounting several routers at the same path. The decision for whether a middleware is run seems to be based on the path, not the router. This was confusing.
The use case here is that my application has several modules that are mounted under the same location, as the URLs for these don't always follow a common prefix. There's common middleware that is used on most, but not all, endpoints. I was attempting to refactor the application to use an express.Router for each module, with each router being able to .use whatever middleware is common to all of its routes.
The result has been that the same middleware is called multiple times, because several routers are all using it. They should be separated, if Router worked as described. Another case is that one module used a middleware to require auth on all of the endpoints in its router, but that spilled over to any other routers used after that one.
Is this intended behavior? Is there a workaround?
Here is a Gist demonstrating the issue: https://gist.github.com/mjm/497a23f68826f8ca473b
Hi! Yes, this is currently intended behavior in Express 4, but is open to change if you can whip up a PR for us :) The reason this happens is because Express 4's router is a simple stack; without executing the middleware in router1, Express has no way to know how to proceed, because that middleware may modify req.method, req.url or something else that modifies routing behavior.
P.S., also feel free to open a PR at https://github.com/strongloop/expressjs.com to help document this behavior to your satisfaction, to help others who may run into the same surprise. Since Express 5 is not yet released, Express 5 is open to change. You can also always use another router module or your own router that behaves off something other than strict linear path matching.
Ah, that's disappointing. Basically, all I'm trying to do is go from:
app.get(foo, bar);
app.post(foo, baz);
to being able to not repeat foo so many times. Is there any built-in way in Express to (for lack of a better word) express this, whether it be with routers or not? I'm not really interested in using a different router module. If there's no way to do it, I'll just go back to mostly using what we had before, putting the middleware on each route. I appreciate the response, nonetheless.
And for what it's worth, my vote would be for this to be possible in Express 5 :)
Would app.route (http://expressjs.com/4x/api.html#app.route) fit the bill here? For your example, you can do the following:
// assuming "foo" is a variable to a path:
app.route(foo)
.get(bar)
.post(baz)
// OR assuming "foo" is a middleware:
app.route('/foo')
.all(foo)
.get(bar)
.post(baz)
I could potentially find a good solution, but that example isn't the easiest to understand what you are trying trying to do :) If you provide the real use-case, that would help a lot, especially if there isn't a solution and one needs to be added here (and you're not up to making a PR). Let us help you :)
Your second example is correct, I left the path off my example by accident. As far as I can tell, app.route will help some, but not all of the repetition. In the cases, where I do have multiple methods for the same URL, your second example is very similar to what I've done.
What I was hoping to achieve was a grouping of routes that, independent of their path, could all have a common middleware applied to them, without repeating the middleware for each one. I'm sorry, I don't think I can be much more specific than that.
From what I can tell, though, it appears there are exactly two ways to control what middleware is applied:
Using a path to scope it down (using either router.all or router.use)
Using ordering
I somewhat understand why Express works the way it works now. Since there is so much flexibility in where a request will end up, it's hard to do this logical grouping in a way that makes sense, since I could go all the way through a route and then never actually finish the request there, instead leaving it to some subsequent route, possibly from another router. It's hard to tell what would happen there. That said, given I've structured my app in such a way that all my routes finish their requests, it seems straightforward enough to want to be able to do all the path filtering first, then see what middleware applies to the route that was chosen (and exclude the middleware from other routers).
Just want to leave my :+1: here. Let me know if there's something I'm doing wrong, but my use case is:
I have two routers, one uses some authorization middleware and the other does not require authorization
Both routers are mounted on the same path, and they might be responsible for handling different methods on the same endpoint
In this scenario, I'm seeing that the authorization middleware is being applied to the route/methods being handled by the second router as well. To be more specific, in the following chunk of code, authorization is being applied to the routes in openRouter as well:
var authRouter = express.Router()
authRouter.use(authHandler)
var openRouter = express.Router()
authRouter.route('/applications/:template')
.get(this.cluster.getAllApplications.bind(this.cluster))
openRouter.route('/applications/:template')
.post(this.cluster.createApplication.bind(this.cluster))
app.use('/', openRouter)
app.use('/', authRouter)
Any thoughts on this?
At @andrewosh , you are just describing the issue here. There is no solution except mounting your two routers on non-conflicting routes or you have to push down the authHandler to the route-level. Effectively, all Express currently does is generate a completely linear route stack. This means your given code above turns into the following:
POST /applications/:template -> cluster.createApplication()
ANY / -> authHandler
GET /applications/:template -> cluster.getAllApplications()
So because all router is currently is basically a grouping, the code above is simply mounting authHandler at the path /* for all methods between the two routers, thus why it's called, regardless of if there are any matching routes within authRouter. Because middleware are allowed to alter the request path, method, etc., we cannot even know if the request matches a path without executing all prior middleware in case they alter the state of the request (this supports things like path rewrite, method overrides, etc.).
I'm having the same or a similar issue. It seems that we should be able to treat routers as encapsulated call stacks that extend the parent app functionality yet work independent of each other.
I think the problem is that the new routing is attached to the app via app.use(), so each router must be traversed in the order it was 'use'd by the app. (please correct me if i'm wrong)
Perhaps the solution is to no longer treat routers as their own middleware and rather create a new more specific implementation for attaching routers to the stack. I do believe this functionality is well warranted.
Would my suggested changes in #2828 be of use for you guys? It doesn't make routers an isolated stack, but it does enable a shared stack to be used by each route within a router.
I think this is an issue for quite a few people, logically Router.use() should isolate the middlewares just to its own scope otherwise it becomes app.use() and it goes out of its scope.
Also please see this: http://stackoverflow.com/questions/35489372/expressjs-applying-middleware-only-to-routes-in-router?noredirect=1#comment58671984_35489372
@demalus suggestion sounds good
Sounds like a useful feature expectation. Let's take the discussion to the router middleware repo - https://github.com/pillarjs/router/issues/38.
Wow this is still an issue??? I thought I could get around this like:
const unauthenticatedRouter = Router(); const authenticatedRouter = Router(); authenticatedRouter.use((req, res, next) => { if (!req.header('auth-token')) { return res.status(401).send(); } next(); })
Seems like a common use case. But calling a route with unauthenticated router it still goes into the middleware. Any update on this @hacksparrow ?
Wow this is still an issue??? I thought I could get around this like:
const unauthenticatedRouter = Router(); const authenticatedRouter = Router(); authenticatedRouter.use((req, res, next) => { if (!req.header('auth-token')) { return res.status(401).send(); } next(); })
Seems like a common use case. But calling a route with unauthenticated router it still goes into the middleware. Any update on this @hacksparrow ?
I see if I declare it this way I seem to get the functionality I expect:
app.use('/api', unauthenticatedRouter); app.use('/api', authenticatedRouter);
Just if anyone stumbles upon this who is having the same issue.
| gharchive/issue | 2015-09-22T00:40:09 | 2025-04-01T06:44:07.493649 | {
"authors": [
"Tomino2112",
"andrewosh",
"demalus",
"dougwilson",
"ericuldall",
"hacksparrow",
"kevinclarkadstech",
"mjm"
],
"repo": "expressjs/express",
"url": "https://github.com/expressjs/express/issues/2760",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
} |
176217438 | Set max SSL fragment size in Express
I'm using express to set up an HTTPS server for some embedded devices. However, due to the lack of computing capabilities, the default SSL fragment size 16384 is too large for these devices. I wonder how I can change this size in express.
I found that in tls modules, TLSSocket class has a method tlsSocket.setMaxSendFragment(size) which may work, but I can't find out how to use it in Express.
This is how my server is established:
var app = require('express')();
var cert_path = '/home/houlu/Programs/Node/http/ssl/';
var privateKey = fs.readFileSync(cert_path+'server.key', 'utf8');
var certificate = fs.readFileSync(cert_path+'server.crt', 'utf8');
var credentials = {key: privateKey, cert: certificate};
httpsServer = https.createServer(credentials, app);
Thanks a lot! :-)
Since this is a socket-level option, this would be handled outside of Express, since Express is request/response-level (multiple request/response pairs can share a single socket).
I think the following would work (not 100% sure, as the Node.js documentation isn't very clear, and I'm not at a computer to test), assuming you wanted all sockets to have this setting:
var app = require('express')();
var cert_path = '/home/houlu/Programs/Node/http/ssl/';
var privateKey = fs.readFileSync(cert_path+'server.key', 'utf8');
var certificate = fs.readFileSync(cert_path+'server.crt', 'utf8');
var credentials = {key: privateKey, cert: certificate};
var httpsServer = https.createServer(credentials, app);
httpsServer.on('connection', function (tlsSocket) {
tlsSocket.setMaxSendFragment(/* whatever size */);
});
Thanks a lot, I'll have a try and let you know the results.
Besides, I think it should be 'secureConnection' instead of 'connection' in HTTPS context.
:)
It works! Thanks a lot!
Awesome, good t hear! Let us know if you have any other questions :)
| gharchive/issue | 2016-09-11T03:38:22 | 2025-04-01T06:44:07.497832 | {
"authors": [
"dougwilson",
"houluy"
],
"repo": "expressjs/express",
"url": "https://github.com/expressjs/express/issues/3082",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
} |
2527348366 | i dont know why my token keep returning undefined, please help.
So im trying to secure an endpoint that allows user create blog, so anyone wont just go over to the '/blogPublish' and have access to it but i keep getting faced with an error when i try to access it... ILL BE GLAD IF ANYONE CAN HELP
server.js
require("dotenv").config();
const express = require("express");
const mongoose = require("mongoose");
const path = require('path');
const bodyParser = require('body-parser');
const protectedRoute = require("./routes/protect.route.js");
const app = express();
// middleware
app.use(express.json());
app.use(bodyParser.json());
app.use(express.static(path.join(__dirname, 'public')));
app.use((req, res, next) => {
res.header('Access-Control-Allow-Origin', '*');
res.header('Access-Control-Allow-Headers', 'Origin, X-Requested-With, Content-Type, Accept');
next();
});
// routes
app.use("/blog", protectedRoute);
app.get('/', (req, res) => {
res.sendFile(path.join(__dirname, 'public', 'index.html'));
});
app.get('/signin', (req, res) => {
res.sendFile(path.join(__dirname, 'public', 'login.html'));
});
// connect to DB and run server
mongoose
.connect(process.env.MONGODB_KEY)
.then(() => {
console.log("Connected!");
const port = process.env.PORT;
app.listen(port, () => {
console.log("Server is running on port :", port);
});
})
.catch(() => {
console.log("Connection Failed.");
});
./routes/protect.route.js
const express = require("express");
const path = require("path");
const authMiddleware = require("../middlewares/auth.middleware");
const router = express.Router();
// Protected Route
router.get('/publishBlog', authMiddleware, (req, res) => {
res.sendFile(path.join(__dirname, '..', 'public', 'publishBlog.html'));
});
module.exports = router;
authMiddleware
const jwt = require('jsonwebtoken');
const Admin = require('../models/admin.model');
const authMiddleware = (req, res, next) => {
console.log('Request Headers:', req.headers);
// Retrieve token from header
const token = req.header('x-auth-token');
console.log('Token:', token);
if (!token) {
return res.status(401).json({ message: 'No token provided, access denied.' });
}
try {
// Verify the token
const decoded = jwt.verify(token, process.env.JWT_SECRET);
console.log('Decoded Token:', decoded);
req.user = decoded.admin;
next();
} catch (err) {
console.error('Token verification failed:', err.message);
res.status(401).json({ message: 'Invalid token, access denied.' });
}
};
module.exports = authMiddleware;
and in my publishBlog.html script:
document.addEventListener("DOMContentLoaded", async function () {
const token = localStorage.getItem('authToken');
console.log(token);
if (token) {
try {
const response = await fetch('http://localhost:3000/blog/publishBlog', {
method: 'GET',
headers: {
'Content-Type': 'application/json',
'x-auth-token': token // Include token in headers
}
});
if (response.ok) {
// Success - Continue to the protected area
console.log('Access to protected area granted');
// You can process the response here if needed
} else {
// Token is invalid or expired
console.error('Failed to access protected area');
window.location.href = '/signin'; // Redirect to login
}
} catch (error) {
console.error('Error:', error);
window.location.href = '/signin'; // Redirect to login
}
} else {
// No token - Redirect to login
window.location.href = '/signin';
}
BUT I JUST KEEP GETTING THIS ERROR ON MY TERMINAL, EVEN THO I HAVE AN AUTH Token saved on my local storage authToken | eyJhbGciOiJIUzI1NiIsInR5c:
Request Headers: {
host: 'localhost:3000',
connection: 'keep-alive',
'cache-control': 'max-age=0',
'sec-ch-ua': '"Chromium";v="128", "Not;A=Brand";v="24", "Google Chrome";v="128"',
'sec-ch-ua-mobile': '?0',
'sec-ch-ua-platform': '"Windows"',
'upgrade-insecure-requests': '1',
'user-agent': 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/128.0.0.0 Safari/537.36',
accept: 'text/html,application/xhtml+xml,application/xml;q=0.9,image/avif,image/webp,image/apng,*/*;q=0.8,application/signed-exchange;v=b3;q=0.7',
'sec-fetch-site': 'same-origin',
'sec-fetch-mode': 'navigate',
'sec-fetch-user': '?1',
'sec-fetch-dest': 'document',
referer: 'http://localhost:3000/signin',
'accept-encoding': 'gzip, deflate, br, zstd',
'accept-language': 'en-US,en;q=0.9',
'if-none-match': 'W/"af3-191f78b1f89"',
'if-modified-since': 'Sun, 15 Sep 2024 21:16:15 GMT'
}
Token: undefined
One thing.
Double check your cross origin configuration: Add x-auth-token to Access-Control-Allow-Headers.
Or use the cors middleware.
| gharchive/issue | 2024-09-16T01:43:55 | 2025-04-01T06:44:07.502974 | {
"authors": [
"NewEraCracker",
"oluwakayodedev"
],
"repo": "expressjs/express",
"url": "https://github.com/expressjs/express/issues/5965",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
} |
2518290146 | fix rules issues for update_external_docs workflow
Changes are made to run the workflow correctly and prevent this workflow from running in a forked repository.
Changes:
Now the workflow will only run in the main repository (expressjs/expressjs.com).
The tool is updated to use an external action allowed by the organization.
Automatically add the review for the @expressjs/docs-wg team.
Update the checkout action to its latest version
ping
| gharchive/pull-request | 2024-09-11T02:02:49 | 2025-04-01T06:44:07.505696 | {
"authors": [
"bjohansebas"
],
"repo": "expressjs/expressjs.com",
"url": "https://github.com/expressjs/expressjs.com/pull/1606",
"license": "CC-BY-4.0",
"license_type": "permissive",
"license_source": "github-api"
} |
128220463 | files not downloading on click.
How to make files to download on clicking them?
Hi! This module simply provides a listing of the files, and that question is really regarding the module you are using to serve up the files themselves. What you need to do is add the HTTP header Content-Disposition: attachment to your file responses. If you are using the serve-static module in conjunction, you can find an example of how to do this on that module's readme:
https://github.com/expressjs/serve-static/#serve-all-files-as-downloads
I hope this helps!
Thanx , but i have coded it for myself :)
Thanx , but i have coded it for myself :)
Can you provide example?
| gharchive/issue | 2016-01-22T18:54:07 | 2025-04-01T06:44:07.508239 | {
"authors": [
"Abhivendra",
"dimmduh",
"dougwilson"
],
"repo": "expressjs/serve-index",
"url": "https://github.com/expressjs/serve-index/issues/43",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
} |
1675830581 | The number of constructor arguments in the derived class Controller must be >= than the number of constructor arguments of its base class
Is there an existing issue for this?
[X] I have searched the existing issues
Current behavior
When I create a controller without any useCases:
import { BaseController } from '@expressots/core'
import { controller, httpGet, response } from 'inversify-express-utils'
@controller('/health')
class HealthController extends BaseController {
constructor() {
super('health-controller')
}
@httpGet('/')
execute(@response() res: any) {
return res.send('alive')
}
}
export { HealthController }
I've this error below:
[INFO] 21:49:15 Restarting: /home/thayto/projects/expresso/expressots-realworld-app/src/application/controllers/health.controller.ts has been modified
[2023-04-19 21:49:16] [core-api] [service-unknown] error: unhandledRejection: The number of constructor arguments in the derived class HealthController must be >= than the number of constructor arguments of its base class.
Error: The number of constructor arguments in the derived class HealthController must be >= than the number of constructor arguments of its base class.
at /home/thayto/projects/expresso/expressots-realworld-app/node_modules/.pnpm/inversify@6.0.1/node_modules/inversify/src/planning/planner.ts:189:17
at Array.forEach (<anonymous>)
at _createSubRequests (/home/thayto/projects/expresso/expressots-realworld-app/node_modules/.pnpm/inversify@6.0.1/node_modules/inversify/src/planning/planner.ts:164:18)
at plan (/home/thayto/projects/expresso/expressots-realworld-app/node_modules/.pnpm/inversify@6.0.1/node_modules/inversify/src/planning/planner.ts:240:5)
at /home/thayto/projects/expresso/expressots-realworld-app/node_modules/.pnpm/inversify@6.0.1/node_modules/inversify/src/container/container.ts:623:25
at Container._get (/home/thayto/projects/expresso/expressots-realworld-app/node_modules/.pnpm/inversify@6.0.1/node_modules/inversify/src/container/container.ts:574:37)
at Container._getButThrowIfAsync (/home/thayto/projects/expresso/expressots-realworld-app/node_modules/.pnpm/inversify@6.0.1/node_modules/inversify/src/container/container.ts:580:25)
at Container.getAll (/home/thayto/projects/expresso/expressots-realworld-app/node_modules/.pnpm/inversify@6.0.1/node_modules/inversify/src/container/container.ts:363:17)
at getControllersFromContainer (/home/thayto/projects/expresso/expressots-realworld-app/node_modules/.pnpm/inversify-express-utils@6.4.3/node_modules/inversify-express-utils/src/utils.ts:16:26)
at InversifyExpressServer.registerControllers (/home/thayto/projects/expresso/expressots-realworld-app/node_modules/.pnpm/inversify-express-utils@6.4.3/node_modules/inversify-express-utils/src/server.ts:149:56)
Steps to reproduce
Create a crontroller withour any useCase on constructor
import { BaseController } from '@expressots/core'
import { controller, httpGet, response } from 'inversify-express-utils'
@controller('/health')
class HealthController extends BaseController {
constructor() {
super('health-controller')
}
@httpGet('/')
execute(@response() res: any) {
return res.send('alive')
}
}
export { HealthController }
Expected behavior
Don't break the code and runs the app as usual
Package version
1.2.0
Node.js version
18.15.0
In which operating systems have you tested?
[ ] macOS
[ ] Windows
[X] Linux
Other
Package Manager: PNPM
IDE: Neovim
The solution what I found is add any useCase inside the constructor:
import { AppUseCase } from '@application/use-cases/app.usecase'
import { BaseController } from '@expressots/core'
import { controller, httpGet, response } from 'inversify-express-utils'
@controller('/health')
class HealthController extends BaseController {
// eslint-disable-next-line @typescript-eslint/no-unused-vars
constructor(private _: AppUseCase) {
super('health-controller')
}
@httpGet('/')
execute(@response() res: any) {
return res.send('alive')
}
}
export { HealthController }
But I guess it still an issue
Hi @rafa-thayto , if you update your library to v1.3.0 this issue should be resolved, thank you!
npm i @expressots/core
NPM Package v1.3.0
If you still want to use your current library version, you can eliminate the inheritance from BaseController and your controller will act as any other endpoint with no issue. Before the change we have made on v1.3.0 the BaseController was requiring to have an use case injected. We understood that forcing the user passing a use case will match our opinionated idea but in the other hand removes the user flexibility of not having an use case if he/she don't want it too. And this is very common pattern in case the user want's to implement all controllers in one single file as MVC pattern does.
@controller('/health')
class HealthController {
@httpGet('/')
execute(@response() res: any) {
return res.send('alive')
}
}
| gharchive/issue | 2023-04-20T01:02:49 | 2025-04-01T06:44:07.515905 | {
"authors": [
"rafa-thayto",
"rsaz"
],
"repo": "expressots/expressots",
"url": "https://github.com/expressots/expressots/issues/28",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
2246234822 | Implement Pushsecrets updatePolicy: IfNotExists for AWS
Describe the bug
Just tried to push a secret and did not work. v0.9.15-2
To Reproduce
apiVersion: external-secrets.io/v1alpha1
kind: PushSecret
metadata:
name: postgresql
namespace: controlplane
spec:
updatePolicy: IfNotExists
deletionPolicy: Delete
refreshInterval: 168h
secretStoreRefs:
- name: default
kind: ClusterSecretStore
selector:
secret:
name: postgresql
data:
- match:
remoteRef:
remoteKey: controlplane/postgresql-smg
Expected behavior
The secret to be pushed
Screenshots
{"level":"error","ts":1713276193.4958684,"msg":"Reconciler error","controller":"pushsecret","controllerGroup":"external-secrets.io","controllerKind":"PushSecret","PushSecret":{"name":"postgresql","namespace":"controlplane"},"namespace":"controlplane","name":"postgresql","reconcileID":"8012f29d-4fe7-4c13-a811-d08d54b51574","error":"could not verify if secret exists in store: not implemented","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.2/pkg/internal/controller/controller.go:329\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).proc essNextWorkItem\n\t/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.2/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.2/pkg/internal/controller/controller.go:227"} {"level":"info","ts":1713276208.7876587,"logger":"provider.aws","msg":"using aws session","region":"eu-west-1","external id":"","credentials":null}
Jus tried with SecretStore instead of ClusterSecretStore and got the same error:
apiVersion: external-secrets.io/v1beta1
kind: SecretStore
metadata:
name: aws-secretsmanager
namespace: controlplane
spec:
provider:
aws:
service: SecretsManager
region: eu-west-1
---
apiVersion: external-secrets.io/v1alpha1
kind: PushSecret
metadata:
name: postgresql
namespace: controlplane
spec:
updatePolicy: IfNotExists
deletionPolicy: Delete
refreshInterval: 168h
secretStoreRefs:
- name: aws-secretsmanager
kind: SecretStore
selector:
secret:
name: postgresql
data:
- match:
remoteRef:
remoteKey: controlplane/postgresql-smg
│ {"level":"error","ts":1713278342.1391892,"msg":"Reconciler error","controller":"pushsecret","controllerGroup":"external-secrets.io","controllerKind":"PushSecret","PushSecret":{"name":"postgresql","namespace":"controlplane"},"namespace":"controlplane","name":"postgresql","reconcileID":"31091df3-9a45-4696-a43d-6bd2b4ef8c6f","error":"could │
│ not verify if secret exists in store: not implemented","stacktrace":"sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\t/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.2/pkg/internal/controller/controller.go:329\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).proc │
│ essNextWorkItem\n\t/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.2/pkg/internal/controller/controller.go:266\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2\n\t/home/runner/go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.2/pkg/internal/controller/controller.go:227"}
updatePolicy: IfNotExists -> this is not yet available for some stores. Please remove it. It should work after that.
@gusfcarvalho I have made an attempt to implement this for the secret store. I did test the change locally and works fine when a secret is pushed however pushing the whole secret is still not implemented so that won't work.
I also need to check if similar implementation should be done for the aws parameter store?
@gusfcarvalho I have made an attempt to implement this for the secret store. I did test the change locally and works fine when a secret is pushed however pushing the whole secret is still not implemented so that won't work.
I also need to check if similar implementation should be done for the aws parameter store?
Having only AWS SM is fine
| gharchive/issue | 2024-04-16T14:40:07 | 2025-04-01T06:44:07.522919 | {
"authors": [
"Skarlso",
"gusfcarvalho",
"ppatel1604",
"ricosega"
],
"repo": "external-secrets/external-secrets",
"url": "https://github.com/external-secrets/external-secrets/issues/3380",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
1000987963 | Add Sonar analysis to CI and push coverage to it #168
Added sonar-prpoject.properties file which is used by SonarQube to determine what the project/organization is and it also includes where the coverage file is.
I also updated ci.yaml to delete CodeCov step and added SonarQube analysis instead of that. This way Sonar analysis will run in a push manner instead of its default.
Before this PR is approved, the steps I mentioned in the issue must be taken. #168
Awesome! I did the required manual steps. Gonna merge now.
/approve
/merge
| gharchive/pull-request | 2021-09-20T13:43:20 | 2025-04-01T06:44:07.524972 | {
"authors": [
"knelasevero",
"serdarkalayci"
],
"repo": "external-secrets/external-secrets",
"url": "https://github.com/external-secrets/external-secrets/pull/375",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
804610376 | System Manager path scrapping gives spec.data.name and spec.data.key Required value error
if i use key and name, the parameter store secrets are pulled correctly. However when i try to install the following yaml i get this error
The ExternalSecret "test" is invalid:
spec.data.name: Required value
spec.data.key: Required value
yaml file contains this
apiVersion: kubernetes-client.io/v1 kind: ExternalSecret metadata: name: test spec: backendType: systemManager roleArn: arn:aws:iam::123456789012:role/test-role region: us-east-1 data: - path: /dev/documentdb recursive: true
Feature is not available until next release.
@khaleelali 6.3.0 has been released
| gharchive/issue | 2021-02-09T14:37:04 | 2025-04-01T06:44:07.527685 | {
"authors": [
"Flydiverny",
"khaleelali"
],
"repo": "external-secrets/kubernetes-external-secrets",
"url": "https://github.com/external-secrets/kubernetes-external-secrets/issues/623",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
2133327183 | cmake presets
https://cmake.org/cmake/help/latest/manual/cmake-presets.7.html
share settings with other people for common ways to configure a project
externpro/internpro projects are built driven by cmake configure options/flags from the [ex|in]ternpro/projects .cmake files, for example curl: https://github.com/smanders/externpro/blob/24.02/projects/curl.cmake#L33-L46
set(XP_CONFIGURE
-DCMAKE_INSTALL_INCLUDEDIR=include/${NAME}_${VER}
-DCMAKE_INSTALL_LIBDIR=lib
-DXP_INSTALL_CMAKEDIR=share/cmake/tgt-${NAME}
-DXP_MODULE_PATH=${CMAKE_DIR}
-DXP_NAMESPACE:STRING=xpro
-DBUILD_CURL_EXE=ON
-DBUILD_SHARED_LIBS=OFF
-DBUILD_TESTING=OFF
-DENABLE_ARES=ON
-DCMAKE_USE_OPENSSL=ON
-DCURL_DISABLE_LDAP=ON
-DUSE_LIBIDN2=OFF
)
I was looking for a way for store these configure options in the repo once these projects are built stand-alone as part of the next generation externpro and came across cmake-presets
5 types of preset objects, to list the defined presets:
configure: cmake --list-presets
build: cmake --build --list-presets
test: ctest --list-presets
package: cpack --list-presets
workflow: cmake --workflow --list-presets
examples of running presets:
configure: cmake --preset=debug
build: cmake --build --parallel --preset=debug --target package
package: cpack --preset=debug
workflow: cmake --workflow --preset=release; cmake --workflow --preset=debug
the fact that CMakePresets.json and CMakeUserPresets.json can include other files with the include field https://cmake.org/cmake/help/latest/manual/cmake-presets.7.html#includes means there can be a default or reusable preset .json files in the externpro cmake/ directory, making the(se) .json file(s) accessible to any project that uses externpro cmake
Good reading
https://dominikberner.ch/cmake-presets-best-practices/
https://learn.microsoft.com/en-us/cpp/build/cmake-presets-vs
https://blog.feabhas.com/2023/08/cmake-presets/
https://pspdfkit.com/blog/2021/cmake-presets-in-practice/
a CMakePresets.json file can be as simple as:
{
"version": 8,
"cmakeMinimumRequired": {
"major": 3,
"minor": 28
},
"include": [
".devcontainer/cmake/xppresets.json"
]
}
to include the xppresets.json file committed to the cmake/ directory
some tough things about the initial cmake/xppresets.json https://github.com/externpro/externpro/commit/d288ac932287c59231aa8b8f7f0898f531e4a8c7
using the default generator on Linux ("Unix Makefiles") requires two separate configs (debug and release), which means two separate binaryDirs, two separate packages, and two separate workflows -- downloading the build artifacts from two separate packages (only on linux) would require additional complexity
using the Visual Studio generator on Windows, which is multi-config (https://cmake.org/cmake/help/latest/prop_gbl/GENERATOR_IS_MULTI_CONFIG.html) means that there is a single binaryDir, package, and workflow -- the single package has headers, debug and release builds of the library and targets files -- downloading a single build artifact (one package) is much simpler
enter "Ninja Multi-Config" generator! https://cmake.org/cmake/help/latest/generator/Ninja Multi-Config.html
with an alternative cmake/presets file for Linux... one could switch between Ninja and Makefiles with the following
$ git diff CMakePresets.json
diff --git a/CMakePresets.json b/CMakePresets.json
index b168c95..abf3b8a 100644
--- a/CMakePresets.json
+++ b/CMakePresets.json
@@ -1,7 +1,7 @@
{
"version": 8,
"include": [
- ".devcontainer/cmake/presets/xpLinuxNinja.json",
+ ".devcontainer/cmake/presets/xpLinuxMakefiles.json",
".devcontainer/cmake/presets/xpWindowsVs2019.json"
]
}
with support for the cmake generator "Ninja Multi-Config", CMAKE_CONFIGURATION_TYPES is no longer an MSVC-only thing, so flags.cmake should be updated to reflect that
also, according to the documentation https://cmake.org/cmake/help/latest/variable/CMAKE_CONFIGURATION_TYPES.html
This variable is initialized by the first project() or enable_language() command...
and it does appear that setting CMAKE_CONFIGURATION_TYPES in preproject.cmake has no impact and should just be removed
as a note on preproject.cmake: setting a default CMAKE_BUILD_TYPE should be done in preproject, if having a default is desired https://discourse.cmake.org/t/how-to-deal-with-ninja-setting-cmake-build-type-to-debug/281
any future cmake presets enhancements will be made under a new issue
this issue is completed with the commits to the main branch referenced above
| gharchive/issue | 2024-02-14T00:04:49 | 2025-04-01T06:44:07.541715 | {
"authors": [
"smanders"
],
"repo": "externpro/externpro",
"url": "https://github.com/externpro/externpro/issues/2",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
228457565 | White background on startup
When oni starts up it shows window with white background, which is quite annoying when dark theme is used.
Yes, this is a great point, it really hurts the polish and feel of Oni.
I have this issue tracking some ideas around improving the load flow of Oni: #355
I'll be investing heavily in polishing and smoothing out the UI as part of the 0.4 milestone.
I'll close this because I believe it is tracked in #355, but feel free to add any suggestions / ideas. Thanks!
| gharchive/issue | 2017-05-13T08:09:09 | 2025-04-01T06:44:07.543970 | {
"authors": [
"extr0py",
"nzinov"
],
"repo": "extr0py/oni",
"url": "https://github.com/extr0py/oni/issues/449",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
} |
1359493547 | 🛑 RoutineHub is down
In 5cf54f8, RoutineHub (https://routinehub.co) was down:
HTTP code: 521
Response time: 251 ms
Resolved: RoutineHub is back up in ec86dff.
| gharchive/issue | 2022-09-01T22:52:52 | 2025-04-01T06:44:07.548141 | {
"authors": [
"extratone"
],
"repo": "extratone/up",
"url": "https://github.com/extratone/up/issues/355",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
2214854613 | Add artifacts API
interface ArtifactsAPI {
upload(name: number, files: string[], options: object): Promise<{ id: number, size: number }>
deleteId(id: number): Promise
deleteIdFrom(owner: string, repo: string, id: number): Promise
downloadId(id: number, path: string): Promise
downloadIdFrom(owner: string, repo: string, id: string, path: string): Promise
list(): Promise<Artifact[]>
listFrom(): Promise<Artifact[]>
readTextArtifact(id: number): Promise<Record<string, Artifact>>
readTextArtifactFrom(owner: string, repo: string, id: number): Promise<Record<string, Artifact>>
createTextArtifact(name: string, fileContents: Record<string, string>): Promise<{ id: number, size: number }>
}
/makerelease
| gharchive/pull-request | 2024-03-29T07:47:23 | 2025-04-01T06:44:07.549192 | {
"authors": [
"extremeheat"
],
"repo": "extremeheat/gh-helpers",
"url": "https://github.com/extremeheat/gh-helpers/pull/13",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
2128701415 | fix: update to eye v9.7.9
fix: update to eye v9.7.9
:tada: This PR is included in version 12.5.7 :tada:
The release is available on:
npm package (@latest dist-tag)
GitHub release
v12.5.7
Your semantic-release bot :package::rocket:
| gharchive/pull-request | 2024-02-10T20:16:55 | 2025-04-01T06:44:07.571044 | {
"authors": [
"jeswr"
],
"repo": "eyereasoner/eye-js",
"url": "https://github.com/eyereasoner/eye-js/pull/879",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
2632217675 | An error occurred when using wavelet ezmsg.sigproc.wavelets.cwt
I came across the following error when I used ezmsg.sigproc.wavelets.CWT to do wavelet transform:
2024-11-03 09:59:44.909 - pid: 36349 - TaskThread - WARNING - windowing: windowing is non-deterministic with zero_pad_until='input' as it depends on the size of the first input. We recommend using 'shift' when window_shift is float-valued.
2024-11-03 09:59:45.005 - pid: 36349 - TaskThread - INFO - on_signal: Traceback (most recent call last):
File "/Users/rwu/anaconda3/envs/umcuezmsg/lib/python3.12/site-packages/ezmsg/sigproc/base.py", line 32, in on_signal
ret = self.STATE.gen.send(message)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/rwu/anaconda3/envs/umcuezmsg/lib/python3.12/site-packages/ezmsg/sigproc/wavelets.py", line 108, in cwt
template = AxisArray(
^^^^^^^^^^
File "<string>", line 7, in init
File "/Users/rwu/anaconda3/envs/umcuezmsg/lib/python3.12/site-packages/ezmsg/util/messages/axisarray.py", line 72, in post_init
raise ValueError("dims contains repeated dim names")
ValueError: dims contains repeated dim names
The error occurred in line 109-119, wavelets.py (https://github.com/ezmsg-org/ezmsg-sigproc/blob/main/src/ezmsg/sigproc/wavelets.py)
template = AxisArray(
np.zeros(
dummy_shape, dtype=dt_cplx if wavelet.complex_cwt else dt_data
),
dims=msg_in.dims[:ax_idx] + msg_in.dims[ax_idx + 1 :] + ["freq", axis],
axes={
**msg_in.axes,
"freq": AxisArray.Axis("Hz", offset=freqs[0], gain=fstep),
},
)
I checked the value of dims=msg_in.dims[:ax_idx] + msg_in.dims[ax_idx + 1 :] + ["freq", axis]. The result I got is ['freq', ‘ch', ‘freq', ‘time']. It seems that the two ‘freq’ caused the error.
And here’s the node I created for the wavelet transform:
"GET_WAVELETS": CWT(scales=scales, wavelet="cmor3.0-0.5", min_phase=MinPhaseMode.HOMOMORPHIC, axis='time')
Environment information:
Python version: 3.12
Conda version: conda 24.4.0
Os: MacOs
Hi @RuolingWu , I hope you don't mind that I edited your post to make the formatting a little easier to read -- I didn't change any content other than add some backticks.
I would need to know what your pipeline is preceding the CWT node. It seems like the signal coming into the node already has a freq axis which maybe suggests a misunderstanding of what the CWT node is intended for.
Hi Chad,
Thanks for changing the format. I checked my code and realised I forgot to delete the node for calculating band power. But after I deleted that node, I got a new error in CWT:
2024-11-04 22:00:59.455 - pid: 51795 - TaskThread - WARNING - windowing: windowing is non-deterministic with zero_pad_until='input' as it depends on the size of the first input. We recommend using 'shift' when window_shift is float-valued. 2024-11-04 22:00:59.550 - pid: 51795 - TaskThread - INFO - on_signal: Traceback (most recent call last): File "/Users/rwu/anaconda3/envs/umcuezmsg/lib/python3.12/site-packages/ezmsg/sigproc/base.py", line 32, in on_signal ret = self.STATE.gen.send(message) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/Users/rwu/anaconda3/envs/umcuezmsg/lib/python3.12/site-packages/ezmsg/sigproc/wavelets.py", line 122, in cwt conv_msg = fbgen.send(msg_in) ^^^^^^^^^^^^^^^^^^ File "/Users/rwu/anaconda3/envs/umcuezmsg/lib/python3.12/site-packages/ezmsg/sigproc/filterbank.py", line 107, in filterbank sps.minimum_phase( File "/Users/rwu/anaconda3/envs/umcuezmsg/lib/python3.12/site-packages/scipy/signal/_fir_filter_design.py", line 1230, in minimum_phase raise ValueError('Complex filters not supported') ValueError: Complex filters not supported
I checked the Linear-phase FIR filter coefficients (h) in scipy.signal.minimum_phase.minimum_phase(h, method='homomorphic'), which is a complex array array([2.76796018e-12-2.71181886e-27j])
And here is the entire pipeline:
frequencies = range(60, 120)
scales = pywt.frequency2scale('cmor3.0-0.5', frequencies)
comps = {
"GET_SOURCE": NeoIteratorUnit(
filepath=base_path / playback_file,
chunk_dur=0.1,
),
"SELECT_STREAM": FilterOnKey("Signals"), # checked
"SELECT_CHANNELS": Slicer(selection="0, 1, 2", axis='ch'), # checked
"FILTER_LINENOISE": ButterworthFilter(axis='time', order=5, cuton=105, cutoff=95),# checked
"APPLY_CAR": CommonRereference(mode="mean", axis='ch'), # checked
"GET_WAVELETS": CWT(scales=scales, wavelet="cmor3.0-0.5", min_phase=MinPhaseMode.HOMOMORPHIC, axis='time'),
"APPLY_MEAN": RangedAggregate(axis='freq', operation=AggregationFunction.MEAN),
"APPLY_ABS": Abs(),
"DOWNSAMPLE": Downsample(axis='time', factor=20),
"APPLY_LOG": Log(),
"RELEASE_SINK": Rerun() if has_rerun else DebugLog(name="TEST", max_length=80), # checked
}
conns = [
(comps["GET_SOURCE"].OUTPUT_SIGNAL, comps["SELECT_STREAM"].INPUT_SIGNAL),
(comps["SELECT_STREAM"].OUTPUT_SIGNAL, comps["SELECT_CHANNELS"].INPUT_SIGNAL),
(comps["SELECT_CHANNELS"].OUTPUT_SIGNAL, comps["FILTER_LINENOISE"].INPUT_SIGNAL),
(comps["FILTER_LINENOISE"].OUTPUT_SIGNAL, comps["APPLY_CAR"].INPUT_SIGNAL),
(comps["APPLY_CAR"].OUTPUT_SIGNAL, comps["GET_WAVELETS"].INPUT_SIGNAL),
(comps["GET_WAVELETS"].OUTPUT_SIGNAL, comps["APPLY_MEAN"].INPUT_SIGNAL)
]
I checked the Linear-phase FIR filter coefficients (h) in scipy.signal.minimum_phase.minimum_phase(h, method='homomorphic')
Sorry, what do you mean by "I checked"? Does this mean that you tried running the exact same line of code and it worked for you, so it's only ezmsg that's failing?
I've encountered this problem myself and I was forced to use a different wavelet type when doing a minphase CWT. (Note: minphase may or may not be important depending on your task and how much you care about your lower frequency wavelets' delay.)
Sorry for the confusion. I just put a break point in that line to see the actual value of h. But thank you for your suggestion!
| gharchive/issue | 2024-11-04T08:56:47 | 2025-04-01T06:44:07.584580 | {
"authors": [
"RuolingWu",
"cboulay"
],
"repo": "ezmsg-org/ezmsg-sigproc",
"url": "https://github.com/ezmsg-org/ezmsg-sigproc/issues/41",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
2318324854 | Redesign website home page
In the context of adding versionning to the website (#845), we are discussing redesigning the welcome page so that it become its own thing based on modern web design.
A first version of the new home page has been created by @mariami (but it was deleted?), let keep iterating!
Also, https://github.com/f3d-app/f3d/issues/1439 will be needed before we finish this one.
You can see the Landing page prototype here:
https://www.figma.com/design/gYkb8SN4lqTLAqQ7ozXs1D/Untitled?node-id=346-8&t=HPXqQ9bxIZp7bM0W-0
Nice! I'm not sure about having F3D Web on the landing page though. It is a bit heavy and long to load, and also may be a bit confusing for users about what F3D is.
A few screenshots + videos instead seems more adapted. Wdyt @Meakk ?
Not F3D Web complete app, but having a 3D view would be great.
As per our latest discussions, the new Figma File for the Landing Page is located in the newest F3D Figma Account.
You can access it here.
Big thanks to @MarieZedginidze !
| gharchive/issue | 2024-05-27T06:16:34 | 2025-04-01T06:44:07.637271 | {
"authors": [
"MarieZedginidze",
"Meakk",
"lknknm",
"mwestphal"
],
"repo": "f3d-app/f3d",
"url": "https://github.com/f3d-app/f3d/issues/1438",
"license": "BSD-3-Clause",
"license_type": "permissive",
"license_source": "github-api"
} |
2686375518 | OnDropFiles: Add support for spaces and quotes in filename
OnDropFiles() needs to escape quotes in filenames before adding quotes around them.
Also TriggerBinding() should add a space between commands and first argument instead of expecting said space to be there already.
Test for spaces in filename is not supported by the interaction testing mechanism.
Test for quotes in filename is supported but github actions do not like quotes in filenames, so testing is limited.
Superseed https://github.com/f3d-app/f3d/pull/1725
@snoyer @Meakk please review
| gharchive/pull-request | 2024-11-23T18:31:07 | 2025-04-01T06:44:07.639299 | {
"authors": [
"mwestphal"
],
"repo": "f3d-app/f3d",
"url": "https://github.com/f3d-app/f3d/pull/1728",
"license": "BSD-3-Clause",
"license_type": "permissive",
"license_source": "github-api"
} |
890711488 | [Q&A] Would it be possible to have an is_async feature as well?
The reason I am asking might very well be ignorance, but here I go.
When transforming the git-transport crate to also support async, I am starting out with blocking code. Right now I use feature toggles as follows:
there are no default features
no features means is_async
A feature called blocking-client makes the existing blocking client code available
The problem I am having with this is my inability to conditionally not compile the async-trait crate, as it's required for the async code, but not for the blocking code. However, cargo features are additive and can't be turned off, leaving the blocking code with the need to compile async-trait.
This issue is certainly minor, but if valid might point at an opportunity.
With a feature flag like maybe-async/is_async, I could have the following configuration.
there are no default features, meaning there is neither blocking nor non-blocking client code as the user should choose.
with the async-client, we also require maybe-async/is_async and async-trait
with blocking-client, we require maybe-async/is_sync
if compiled with --all-features, we pick one of the above to be the dominant one
While only having taken a glance at how the is_sync feature toggle is used in this crate, I have a feeling that the addition of is_async would be very possible. If so, I would be happy to contribute it, too.
I am curious to hear what you are thinking. Thanks a lot.
I agree that this would be useful. I am in the process of moving a crate to an optional async. The current crate owner wants a minimally invasive change so default has to be is_async.
I would guess that this will be the same for many as there's a lot of blocking code out there that could be converted to async.
That's great to hear! Making a choice for default features should be fine as they can be turned off easily.
Something that came to mind is the choice to be made when both of the mutually exclusive feature toggles are set, i.e. --all-features compiles turn on is_async and is_sync. In my case, I choose the blocking code to emerge out victorious, but I see how there is no right answer. It's just something that maybe_async would have to make configurable too or else the crate using maybe_async probably won't compile.
In any case, I am already and happily using it in tests to consolidate test cases to work with async and sync code paths and prevent drift in the distinct implementations. Once maybe_async can also handle is_async it would be possible to get rid of some duplication in the crate code itself as well.
Maybe it's interesting to you, so here is how maybe_async is used in tests for deduplication. Currently it won't remove await invocations that are nested in macros, that's quite alright from my experience. Is this related to how deep in the AST the await is located, or is it related to macros?
Yeah! I agree with the idea to add an is_async feature gate to conditionally eliminate the async-trait dependency. And for the --all-features issue, we can just throw an compiler error and leave the choice to users.
Currently it won't remove await invocations that are nested in macros, that's quite alright from my experience. Is this related to how deep in the AST the await is located, or is it related to macros?
The answer is the former. I am affraid this is how procedural macro works. Code inside a declarative macro is not regarded as regular rust code in AST.
Awesome, I will be looking forward to it as it will enable me to use it in non-test code as well.
And for the --all-features issue, we can just throw an compiler error and leave the choice to users.
In a way I like it as it doesn't select something automatically. Thus far I was avoiding doing this because of the expectation that is set in the cargo documentation:
A consequence of this is that features should be additive. That is, enabling a feature should not disable functionality, and it should usually be safe to enable any combination of features. A feature should not introduce a SemVer-incompatible change.
The way we use features here already go against their intended use, so maybe it's time to go 'all in' and error if mutually exclusive features are selected.
The answer is the former. I am affraid this is how procedural macro works. Code inside a declarative macro is not regarded as regular rust code in AST.
Interesting, that sounds like plugins see the code prior to expansion.
When choosing to not allow both blocking and async feature toggles to exist there is no need for configuring anything in maybe-async.
Sacrificing running cargo _ --all-features is probably ok as users of the crate will always have to make a conscious choice about their IO, and silently defaulting to blocking IO is probably surprising in the worst and inefficient in the best case as more dependencies are pulled in.
Hence I close this issue.
Context
Thus far I managed to avoid maybe-async and its dependencies for the lower level crates and only used it in tests. There it was absolutely required to be able to share tests to validate a partially diverged codebase with some duplication in it to accommodate for async and blocking implementations.
Having arrived at a higher level crate I am looking at about 200 lines of code which are full of logic and full of IO, with only a few tests to cover the happy paths. It's probably code that is not quite stable yet either and imagining me maintaining both seems like an unwelcome chore. Now it appears worth it to pull in maybe-async and pay the cost in compile time knowing that typical applications will only pay for maybe-async itself, not for its dependencies as they will depend on other proc-macros somewhere using the same dependency tree.
Maybe one day I will feel comfortable trowing the blocking codepath entirely, too, but more tests about compile speed and binary size will have to be conducted (and assuming that performance is the same or better).
| gharchive/issue | 2021-05-13T05:10:41 | 2025-04-01T06:44:07.659068 | {
"authors": [
"Byron",
"GeoffClements",
"fMeow"
],
"repo": "fMeow/maybe-async-rs",
"url": "https://github.com/fMeow/maybe-async-rs/issues/8",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
1368205558 | fix small design issue within offers view
boxes' background should have same height
fixed with 91e424745c127abf7a00562703338ca005a6f1a0
| gharchive/issue | 2022-09-09T18:50:17 | 2025-04-01T06:44:07.667634 | {
"authors": [
"fabfischer"
],
"repo": "fabfischer/kickbase-plus",
"url": "https://github.com/fabfischer/kickbase-plus/issues/50",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
848819636 | Disable or readonly
How can i let the multi select disabled or in readonly mode?
Tried some parameters but none worked.
Thanks
Solved in a ugly way haha
.multi-wrapper .item{ pointer-events:none; }
Hi, @andreescocard! Multi.js supports the standard HTML disabled attribute on option elements and I would recommend using that instead!
I did that, but won't work.
In that case, it's not possibly with the way the HTML standard is designed. required will only work for the traditional HTML form elements.
| gharchive/issue | 2021-04-01T22:07:32 | 2025-04-01T06:44:07.680622 | {
"authors": [
"andreescocard",
"fabianlindfors"
],
"repo": "fabianlindfors/multi.js",
"url": "https://github.com/fabianlindfors/multi.js/issues/49",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
1125247857 | Implement blend modes
Closes #1
Added BlendModeWidget:
| gharchive/pull-request | 2022-02-06T16:23:57 | 2025-04-01T06:44:07.681977 | {
"authors": [
"fabioarnold"
],
"repo": "fabioarnold/MiniPixel",
"url": "https://github.com/fabioarnold/MiniPixel/pull/24",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
2131358625 | Hello World.ts
Is this supposed to be the contents of hello world.ts?
Well I don't know how that happened, I'll fix it later
fixed
| gharchive/issue | 2024-02-13T02:37:34 | 2025-04-01T06:44:07.746713 | {
"authors": [
"Slav-XpXz",
"face-hh"
],
"repo": "face-hh/subterfuge",
"url": "https://github.com/face-hh/subterfuge/issues/7",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
356201165 | Enable pass attributes to script and link
Motivation
Github issue: #848
Enable pass attributes to script tag and link tag.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
I have tested this locally, it will apply the attributes to script and link.
Related PRs
nope
Retried Netlify deploy!
Will address comments at tonight.
Hi, guys
I have addressed the comments. Because we need to pass down a unique key.
I guess use ternary operator is more readable than use Object.assign.
| gharchive/pull-request | 2018-09-01T13:07:46 | 2025-04-01T06:44:07.749458 | {
"authors": [
"wszgxa",
"yangshun"
],
"repo": "facebook/Docusaurus",
"url": "https://github.com/facebook/Docusaurus/pull/937",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
895504350 | RDP.ALEXA.53 Virus Popup
Describe the bug
IDP.ALEXA.53 Antivirus threat popup when running npm start
Did you try recovering your dependencies?
Yes
Which terms did you search for in User Guide?
Virus Name
Environment
Environment Info:
current version of create-react-app: 4.0.3
running from C:\Users\DevPP~1\AppData\Roaming\npm-cache_npx\9872\node_modules\create-react-app
System:
OS: Windows 10 10.0.19042
CPU: (8) x64 Intel(R) Core(TM) i5-8250U CPU @ 1.60GHz
Binaries:
Node: 14.15.4 - C:\Program Files\nodejs\node.EXE
Yarn: Not Found
npm: 6.14.10 - C:\Program Files\nodejs\npm.CMD
Browsers:
Chrome: 90.0.4430.212
Edge: Spartan (44.19041.964.0), Chromium (90.0.818.62)
Internet Explorer: 11.0.19041.1
npmPackages:
react: ^17.0.2 => 17.0.2
react-dom: ^17.0.2 => 17.0.2
react-scripts: 4.0.3 => 4.0.3
npmGlobalPackages:
create-react-app: Not Found
Steps to reproduce
npx create-react-app my-app
cd my-app
npm start
Expected behavior
Dev server should start
Actual behavior
Virus Threat Popup from my antivirus for RDP.ALEXA.53
This seems like a false positive from Avast, see the following topic:
https://forum.avast.com/index.php?topic=237825.0
Are you using VSCode terminal to run npm start?
| gharchive/issue | 2021-05-19T14:16:42 | 2025-04-01T06:44:07.759189 | {
"authors": [
"codecoffeeme",
"petetnt"
],
"repo": "facebook/create-react-app",
"url": "https://github.com/facebook/create-react-app/issues/10990",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
430974728 | The system could not find the specified path
1.yarn create react-app my-app
2.cd my-app
3.yarn start
Please fill out the issue template so we can help you.
| gharchive/issue | 2019-04-09T13:41:31 | 2025-04-01T06:44:07.761171 | {
"authors": [
"iansu",
"liusiasi"
],
"repo": "facebook/create-react-app",
"url": "https://github.com/facebook/create-react-app/issues/6778",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
629772718 | Click on placeholder rather next to it
Hello everyone,
I have been trying to modify the way the placeholder works in my project.
Currently, if I click next to the placeholder, it will place the caret where I want it to be and the text will start typing as expected.
However if I click on the placeholder itself, it will select it as a normal text.
Instead, I would like the caret to appear when i click on the placeholder.
Maybe I didn't search hard enough but i haven't found any information on that topic so far.
Thank you
Hi @vincentdegheyndt, have you seen #403? See also the note about placeholder styling on https://draftjs.org/docs/api-reference-editor/.
Thnaks @thibaudcolas,
Yes I have seen that issue and already used a custom css file to prevent that behaviour of the caret as they explain.
However I don't know of any css property that would make the placeholder text "unselectable". If there is then a custom css file should do the trick, I reckon.
Oh that’s strange – Draft.css is meant to come with the styles that do this, I think. Here are the relevant styles:
.DraftEditor-editorContainer {
background-color: rgba(255, 255, 255, 0);
border-left: .1px solid transparent;
position: relative;
z-index: 1;
}
.public-DraftEditorPlaceholder-root {
color: #9197a3;
position: absolute;
z-index: 1;
}
At least in my editor this seems to be enough for the placeholder to not be clickable, since the "editor container" is in front of it.
This worked !!!
Thank you very much for your help;
| gharchive/issue | 2020-06-03T07:46:02 | 2025-04-01T06:44:07.767688 | {
"authors": [
"thibaudcolas",
"vincentdegheyndt"
],
"repo": "facebook/draft-js",
"url": "https://github.com/facebook/draft-js/issues/2455",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
} |
165792454 | Nullthrows error when defining custom blockType in blockStyleFn
Hi,
How can I define custom block types like native DraftJS block types?
I tried using custom blockStyleFn and it looks like this:
const getBlockStyle = (block) => { switch(block.getType()) { case 'alignRight': return 'editor-align-right'; case 'blockquote': return 'editor-blockquote'; default: return null; }; };
However, I am getting nullthrows error, when alignRight blockType is passed to this function, but blockquote native DraftJS blockType works just fine.
I searched the repo and I thought that this PR should have fixed the issue, since it was merged into current 0.7.0 version.
Any help or advice on how to accomplish what I am looking for would be greatly appreciated! Thanks!
Is anyone paying attention to the problems of users on this repo at all?
Really? It's been 12 hours.
Check out the docs here about setting blockRenderMap: https://github.com/facebook/draft-js/pull/387/files.
| gharchive/issue | 2016-07-15T13:57:36 | 2025-04-01T06:44:07.771743 | {
"authors": [
"igorpreston",
"spicyj"
],
"repo": "facebook/draft-js",
"url": "https://github.com/facebook/draft-js/issues/540",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
} |
240919166 | Add support for mark (highlight) inline tag when converting from HTML.
Summary
Support for mark (highlight) HTML inline tag style when converting from HTML.
Would it be a better idea to allow for users to pass in a custom inlineTags object which gets merged with the current inlineTags object to convertFromHTMLtoContentBlocks so that we could override or customise this for our particular needs?
| gharchive/pull-request | 2017-07-06T10:56:33 | 2025-04-01T06:44:07.773081 | {
"authors": [
"deep-c"
],
"repo": "facebook/draft-js",
"url": "https://github.com/facebook/draft-js/pull/1277",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
} |
752796002 | Using string IDs generates invalid code
When using string IDs in the generator setup, the associated SQL handling code produced still assumes an int64 ID:
l.ID = string(value.Int64)
ent/list.go
Generated code:
func (l *List) assignValues(values ...interface{}) error {
if m, n := len(values), len(list.Columns); m < n {
return fmt.Errorf("mismatch number of scan values: %d != %d", m, n)
}
value, ok := values[0].(*sql.NullInt64)
if !ok {
return fmt.Errorf("unexpected type %T for field id", value)
}
l.ID = string(value.Int64)
values = values[1:]
if value, ok := values[0].(*sql.NullString); !ok {
return fmt.Errorf("unexpected type %T for field title", values[0])
} else if value.Valid {
l.Title = value.String
}
return nil
}
ent/list_create.go
Generated code:
func (lc *ListCreate) sqlSave(ctx context.Context) (*List, error) {
_node, _spec := lc.createSpec()
if err := sqlgraph.CreateNode(ctx, lc.driver, _spec); err != nil {
if cerr, ok := isSQLConstraintError(err); ok {
err = cerr
}
return nil, err
}
id := _spec.ID.Value.(int64)
_node.ID = string(id)
return _node, nil
}
ent/cmd/entc.go
Custom entc command:
func main() {
err := entc.Generate("./ent/schema", &gen.Config{
Templates: entgql.AllTemplates,
Features: []gen.Feature{
gen.FeaturePrivacy,
},
IDType: &field.TypeInfo{Type: field.TypeString},
})
if err != nil {
log.Fatalf("running ent codegen: %v", err)
}
}
Versions
github.com/facebook/ent v0.5.0
github.com/facebookincubator/ent-contrib v0.0.0-20201101132939-7984b86acfa0
Hey @ivanvanderbyl!
Since string IDs don't have default configuration in ent (in the database), you need to define the ID field (as string) in the Fields configuration. Please see example here and let me know if you still have issue with it.
@a8m thanks for that. I eventually figured that out from an example. Even though that code never runs, go vet complains about it so I figure it's still an issue.
| gharchive/issue | 2020-11-29T00:07:59 | 2025-04-01T06:44:07.780635 | {
"authors": [
"a8m",
"ivanvanderbyl"
],
"repo": "facebook/ent",
"url": "https://github.com/facebook/ent/issues/995",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
59243719 | AbstractParallel has ModelParallel-specific behavior
https://github.com/facebook/fbcunn/blob/master/luasrc/AbstractParallel.lua lines 235-256
AbstractParallel sums up the gradInputs, which is behavior that, I think, should be specific to ModelParallel.
DataParallel should concatenate the gradInputs instead (otherwise it's not possible to plug a DataParallel inside a network).
require 'fbcunn'
require 'cudnn'
basenet=nn.Sequential()
layer=cudnn.SpatialConvolution(3,16,5,5,1,1)
basenet:add(layer)
basenet:add(cudnn.ReLU())
model=nn.DataParallel(1)
model:add(basenet)
model:add(basenet:clone())
model:cuda()
inputTensor=torch.CudaTensor(32,3,10,10)
model:forward(inputTensor)
foo=model.output:clone()
model:backward(inputTensor, foo)
print(inputTensor:size())
print(model.gradInput:size())
Sizes should match but don't.
I would put a call to a _mixGradInputs method in nn.AbstractParallel, that would be specific to Model/DataParallel (that's how I fixed it locally but my code isn't clean)
@jonathantompson also reported the same. cc: @ajtulloch @tudor
fix in-fight, will push soon.
I'm re-writing DataParallel for my own codebase because I also need to be able to a) embed it in another module and b) support table inputs and outputs.
Would this be useful for anyone? Or would too many versions of DataParallel just be confusing for the end user?
i've fixed the (a) already, will push tomorrow or so. (b) will be useful. As many versions of DataParallel as needed, looking forward to your version.
@qassemoquab fixed this bug in https://github.com/facebook/fbcunn/commit/55beb7fa67b838a40e9d6cee8026e908d644665b
Please reinstall fbnn and fbcunn (just do git pull and luarocks make)
Thanks !
I have a small doubt though : I think it's not possible to do accUpdateGradParameters on DataParallel modules since it accumulates gradients directly on the weight tensors. (In that case, _mixGrads in AbstractParallel doesn't help ; one would need a _mixWeights instead.)
Looks very nice otherwise ! Thanks for the quick fixes !
you're right about the _mixWeights. Will fix that on monday. thanks for the review.
| gharchive/issue | 2015-02-27T14:37:21 | 2025-04-01T06:44:07.802215 | {
"authors": [
"jonathantompson",
"qassemoquab",
"soumith"
],
"repo": "facebook/fbcunn",
"url": "https://github.com/facebook/fbcunn/issues/28",
"license": "bsd-3-clause",
"license_type": "permissive",
"license_source": "bigquery"
} |
67002005 | No entry for Object.prototype.toString in lib/core.js
In fact, there is no mention of toString anywhere in lib/core.js. Is there any reason why it's omitted? If so, it would be good to document it in there.
I don't believe this is related to https://github.com/facebook/flow/issues/244.
@bolinfest What specific issue are you having using toString? It might not be in lib/core.js, but can you provide an example where flow doesn't type check actual JS as you expect?
Closed by https://github.com/facebook/flow/commit/945caad4ec203cafd096f08a7d5d40ad0d36b8c0
| gharchive/issue | 2015-04-07T22:13:28 | 2025-04-01T06:44:07.805026 | {
"authors": [
"bolinfest",
"mroch",
"samwgoldman"
],
"repo": "facebook/flow",
"url": "https://github.com/facebook/flow/issues/369",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
282860654 | React HOC gives 'some incompatible instantiation of P' when resulting component has props
Flow try
When the resulting component doesn't have any custom props, it works, but if I add some, when spreading all props it breaks for some reason. What am I doing wrong?
type InjectedProps = {
foo: number;
}
type HOCProps = {
bar: string
}
function enhanceWithFoo<P: {}>(
WrappedComponent: React.ComponentType<InjectedProps & P>
): React.ComponentType<HOCProps & P> {
return class HOC extends React.Component<HOCProps & P> {
render() {
return (<WrappedComponent {...this.props} foo={3} />);
}
}
}
28: return (<WrappedComponent {...this.props} foo={3} />);
^ props of React element `WrappedComponent`. This type is incompatible with
23: function enhanceWithFoo<P: {}>( ^ some incompatible instantiation of `P`
It works in v62+
| gharchive/issue | 2017-12-18T12:22:12 | 2025-04-01T06:44:07.807534 | {
"authors": [
"borlaym"
],
"repo": "facebook/flow",
"url": "https://github.com/facebook/flow/issues/5531",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
363291084 | No destroy method for streams
Since 8.0.0, node has had a destroy method for streams. Should this be added to the built-in node type library? Currently this is missing.
Definitely a dupe of #4999. I wonder why that fix is so stalled. Closing.
Because only things that Facebook needs are implemented, unless there is a PR and somebody has time to merge it. That is not criticism of FB, their open source Flow repo is open source in the traditional sense: They open-sourced something that they happened to create for themselves. It is not a product like TypeScript aimed at other people.
| gharchive/issue | 2018-09-24T19:39:00 | 2025-04-01T06:44:07.809365 | {
"authors": [
"DullReferenceException",
"lll000111"
],
"repo": "facebook/flow",
"url": "https://github.com/facebook/flow/issues/6928",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
229530823 | Document $Shape in types/utilities.md
This adds a (very limited) documentation for $Shape, as requested in #2464.
The documentation is not 100 correct, see this Flow Try example.
Suggestion:
`$Shape<T>` describes a type with a subset of the properties of T, but no properties that are not in T.
For example:
```js
// @flow
type Person = { name: string, age: number };
function createMockPerson(partialPerson: $Shape<Person>): Person {
return {
name: 'Alice',
age: 33,
...partialPerson
};
}
// These are valid:
createMockPerson({}); // { name: 'Alice', age: 33 }
createMockPerson({ name: 'Bob' }); // { name: 'Bob', age: 33 }
createMockPerson({ age: 20 }); // { name: 'Alice', age: 20 }
// This is invalid:
createMockPerson({ propertyThatDoesNotExistInPerson: 123 });
```
| gharchive/pull-request | 2017-05-18T01:30:49 | 2025-04-01T06:44:07.811622 | {
"authors": [
"awestroke",
"bradencanderson"
],
"repo": "facebook/flow",
"url": "https://github.com/facebook/flow/pull/3967",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
267450591 | Add process.binding
It's not documented, but it's there to allow us to access the internal core node C++ bindings.
One common use case is doing process.bindings('fs').realpath to access the native realpath or process.bindings('natives') to get a list of all built-in modules in node.
(I understand if you don't want to add undocumented functions)
but it's there to allow us to access the internal core node C++ bindings
Not really, it's there only for Node.js itself, i.e. it is not a part of public API. Using is causes a lot of problems.
I suppose if things like https://github.com/nodejs/node/pull/15776 are done more often, the use-cases will disappear.
But with https://github.com/nodejs/node-v0.x-archive/issues/624 closed, getting access to a list of built-in modules is a pain (https://github.com/tapjs/stack-utils/blob/459f196b67b01684f6d370ab774944de184a8cfe/index.js#L16-L28 & https://github.com/sindresorhus/builtin-modules/blob/32ab9f2fe30c1cad2b449d7e6058a1b4018d9b88/index.js#L8-L10).
I can agree on them being edge-cases though, and not wanting to make it easier to use/discover process.binding than it is
Meh, bad practice
| gharchive/pull-request | 2017-10-22T09:42:05 | 2025-04-01T06:44:07.815629 | {
"authors": [
"SimenB",
"vkurchatkin"
],
"repo": "facebook/flow",
"url": "https://github.com/facebook/flow/pull/5160",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
108553345 | Add @@iterator to NodeList and HTMLCollection
Add @@iterator support to HTMLCollection and NodeList. This adds support for things like:
let inputs = document.querySelectorAll('input, select');
for ( let el of billingInputOrSelect ) { ... }
I was confused since these things aren't iterable on Chrome, but they are on Firefox. Found http://stackoverflow.com/questions/31283360/are-htmlcollection-and-nodelist-iterables which answers this question. Since they're supposed to be iterable I think we can merge this
Ok, I think I understand the spec now.
This describes what it takes for something to be iterable
NodeList is explicitly iterable
HTMLCollection is implicitly iterable since it has length and a getter.
@gabelevi is this the correct solution for @@iterable then? Or do we need to change how flow interprets for of, to consider anything with length and a getter iterable?
This is right! I'll get it merged today!
Merged! Thanks for the contribution!
| gharchive/pull-request | 2015-09-27T18:46:14 | 2025-04-01T06:44:07.819681 | {
"authors": [
"gabelevi",
"jeffutter"
],
"repo": "facebook/flow",
"url": "https://github.com/facebook/flow/pull/865",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
679446433 | Cannot assign to read only property '...' of object '...'
🐛 Bug Report
Manually transferring https://github.com/facebook/react/issues/18758 to here. During debugging, it was determined to be a Jest issue.
@gaearon rightly agreed with me that the issue won't get fixed by sitting in the React repo. But they used their facebook admin powers to lock the issue, instead of using GitHub's "Transfer Issue" feature to get it here with all its detail in an instant. Ah, well.
People (including React repo maintainers, apparently) are seeing variations on TypeError: Cannot assign to read only property 'Symbol(...)' of object '[object ...]' when they do expect(...).toBe(...) and expect(...).toEqual(...).
The initial response is that it's not a very helpful error message.
Here's one clue that might explain it:
It happens when calling replaceMatchedToAsymmetricMatcher() inside printDiffOrStringify()
https://github.com/facebook/jest/blob/master/packages/jest-matcher-utils/src/index.ts#L359
@SimenB any ideas?
Originally posted by @pahan35 in https://github.com/facebook/react/issues/18758#issuecomment-636249433
And a suggestion about what should be done about it:
We see a current message because replaceMatchedToAsymmetricMatcher fails on preparing the diff.
IMHO it's not about improving the error message, it's about fixing replaceMatchedToAsymmetricMatcher to print the diff for DOM elements without failures.
Originally posted by @pahan35 in https://github.com/facebook/react/issues/18758#issuecomment-647179531
Hmm I didn’t even know there’s a way to transfer issues. 😀
@WeiAnAn ideas? It throws during assignment here: https://github.com/facebook/jest/blob/c9c8dba4dd8de34269bdb971173659399bcbfd55/packages/jest-matcher-utils/src/Replaceable.ts#L57
Sorry guys.
I'm trying to figure out the problem and solve it.
Found problem at https://github.com/facebook/jest/blob/c9c8dba4dd8de34269bdb971173659399bcbfd55/packages/jest-matcher-utils/src/deepCyclicCopyReplaceable.ts#L58-L74
We need to set symbol key property descriptor.
But I got error on typescript that symbol type cannot be object key.
An index signature parameter type must be either 'string' or 'number'.
Will continue work tomorrow.
If anyone interested in, welcom to take it.
Found problem at
https://github.com/facebook/jest/blob/c9c8dba4dd8de34269bdb971173659399bcbfd55/packages/jest-matcher-utils/src/deepCyclicCopyReplaceable.ts#L58-L74
We need to set symbol key property descriptor.
But I got error on typescript that symbol type cannot be object key.
An index signature parameter type must be either 'string' or 'number'.
Will continue work tomorrow.
If anyone interested in, welcom to take it.
https://github.com/microsoft/TypeScript/issues/1863 Probably related to the error
Here is the minimal to reproduce this error.
test('test', () => {
const a = {};
const b = {};
const symbolKey = Symbol.for('key');
Object.defineProperty(a, symbolKey, {
configurable: true,
enumerable: true,
value: {
a: 1,
},
writable: false,
});
Object.defineProperty(b, symbolKey, {
configurable: true,
enumerable: true,
value: {
a: 1,
},
writable: false,
});
expect(a).toBe(b);
});
@WeiAnAn we can do a // @ts-expect-error to suppress it - better than failing at runtime 🙂
https://github.com/facebook/jest/releases/tag/v26.4.1
| gharchive/issue | 2020-08-14T23:17:08 | 2025-04-01T06:44:07.831960 | {
"authors": [
"SimenB",
"WeiAnAn",
"ahnpnl",
"chrisbobbe",
"gaearon"
],
"repo": "facebook/jest",
"url": "https://github.com/facebook/jest/issues/10408",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
341588932 | toMatchInlineSnapshot fails if path module is mocked
🐛 Bug Report
toMatchInlineSnapshot fails if path module is mocked
jest.mock('path', () => ({}));
test('foo', () => {
expect({}).toMatchInlineSnapshot();
});
results in
● Test suite failed to run
TypeError: path.resolve is not a function
Run npx envinfo --preset jest
Paste the results here:
System:
OS: macOS High Sierra 10.13.5
CPU: x64 Intel(R) Core(TM) i7-6567U CPU @ 3.30GHz
Binaries:
Node: 8.9.4 - ~/.nvm/versions/node/v8.9.4/bin/node
Yarn: 1.7.0 - /usr/local/bin/yarn
npm: 5.6.0 - ~/.nvm/versions/node/v8.9.4/bin/npm
npmPackages:
jest: ^23.4.0 => 23.4.0
no, this seems like a separate issue, but comes from the same bug.
right now we're trying to do too much from within the VM. we need to take absolutely everything out of there except the snapshot state object at some point
I'm trying to dig into this. I've got a test that reproduces the bug in e2e/__tests__/to_match_inline_snapshot.test.js.
The error is coming from the compiled node_modules/prettier/third-party.js and originally from this line in cosmiconfig dependency.
node_modules/prettier/prettier-bin.js is right now using these native modules
var path = _interopDefault(require('path'));
var os = _interopDefault(require('os'));
var assert = _interopDefault(require('assert'));
var fs = _interopDefault(require('fs'));
var util = _interopDefault(require('util'));
var events = _interopDefault(require('events'));
var thirdParty = require('./third-party');
var thirdParty__default = thirdParty['default'];
var readline = _interopDefault(require('readline'));
// and these two through ./third-party
var stream = _interopDefault(require('stream'));
var module$1 = _interopDefault(require('module'));
I'm assuming jest.mock will overrider any of the above. I'm unsure how to actually fix this issue (looking at https://github.com/facebook/jest/pull/6687 for inspiration) but I'll keep digging. I'd appreciate any input from folks with more context.
@tryggvigy hey! the issue comes from the fact that we have two environments we execute Jest code in:
Outer environment, where all framework code is running
Test environment inside a VM https://github.com/facebook/jest/blob/master/packages/jest-environment-node/src/index.js#L94
because most of our framework code is in the outer environment we're able to mock native/whatever modules from inside the VM and not affect the framework code.
unfortunately inline snapshots bring a lot of logic that is executed in the inner scope (inside the VM) and interacting with the environment makes it possible to break framework code.
the right fix for this is to take everything framework related to the outer scope and pass a pure/stateless function to the VM
@tryggvigy actually! since you found that the issue comes from inside prettier my PR might have fixed it (cause i did take prettier to the outer scope)
do you mind checking out master and trying to reproduce it?
Thanks for explaining @aaronabramov! Also, yes I can reproduce this on master.
Hey, I noticed that this is not an issue in jest-circus.
JEST_CIRCUS=1 yarn jest to_match_inline_snap passes.
ugh.. that might be my fault :)
i did use require for babel-traverse, but kept localRequire for prettier
https://github.com/facebook/jest/blob/master/packages/jest-jasmine2/src/setup_jest_globals.js#L105
i'm pretty sure that's the reason
Yeah, thats it :) Test passes now, I'll make a PR
Closing the issue. It's fixed by #6776
@tryggvigy thanks for digging into it! :)
| gharchive/issue | 2018-07-16T16:27:37 | 2025-04-01T06:44:07.841926 | {
"authors": [
"aaronabramov",
"tryggvigy"
],
"repo": "facebook/jest",
"url": "https://github.com/facebook/jest/issues/6702",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
343142847 | View outcome of all assertions when a test fails
🚀 Feature Proposal
Jest is commonly used to test complex features of code, i.e. features that cannot be encapsulated in a single expect() statement. Such tests require multiple expect() statements to fully ensure the code is working properly. When I have tests with multiple expect() statements that fail, I want to be able to see the outcome of each expect() that failed, rather than just the first one that failed. It would be much more helpful to me when trying to figure out what is happening when my test fails.
Right now, to figure out what is wrong with the code that corresponds to a failing test, I resort to editing the test file and temporarily reordering the expect statements, so I can see the outcome of each one, or putting in arbitrary console.log() statements. This is silly and should not be required when using an advanced testing library like Jest.
Motivation
The motivation for this proposal is for developers to be able to figure out how a complex test is failing without having to make unnecessary edits to the test code.
Example
Sample Code:
const testRequest = require('./somefile');
...
test('Sample Test', async () => {
const response = await testRequest({
param1:'Test',
param2:20
});
expect(response.statusCode).toBe(200);
const body = JSON.parse(response.body);
expect(Array.isArray(response.body)).toBeTruthy();
expect(response.body.length).toBeGreaterThanOrEqual(1);
expect(response.body.length).toBeLessThanOrEqual(20);
response.body.foreach(item => {
expect(item.title).toBeDefined();
expect(item.description).toBeDefined();
expect(item.rating).toBeGreaterThanOrEqual(1);
expect(item.rating).toBeLessThanOrEqual(5);
});
});
Sample Output:
x Sample Test
expect(received).toBeLessThanOrEqual(expected)
Expected: 20
Received: 21
expect(received).toBeDefined()
Received: undefined
> | expect(item.description).toBeDefined();
expect(received).toBeGreaterThanOrEqual(1);
Expected: 1
Received: 0
> | expect(item.rating).toBeGreaterThanOrEqual(1);
Test Suites: 1 failed, 1 total
...
Actual Output:
x Sample Test
expect(received).toBeLessThanOrEqual(expected)
Expected: 20
Received: 21
> | expect(response.body.length).toBeLessThanOrEqual(20);
Test Suites: 1 failed, 1 total
...
Pitch
This feature belongs in the Jest core platform because it greatly simplifies debugging and removes unnecessary work for the developer (reordering expects and adding unnecessary console.log() statements to test files). This is something that all developers can benefit from. If backwards compatibility is a concern, this feature could be off by default, and could be turned on using a command line or config file switch.
Hey @jextrevor, this would be a really cool feature but would be pretty tough to implement since assertions throw when they fail. Going to close because it would take a significant amount of re-architecting but I'm going to keep this in mind as a long term wishlist feature
| gharchive/issue | 2018-07-20T15:05:26 | 2025-04-01T06:44:07.847210 | {
"authors": [
"jextrevor",
"rickhanlonii"
],
"repo": "facebook/jest",
"url": "https://github.com/facebook/jest/issues/6728",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
355447156 | Debug Jest with current test file doesn't stop at correct breakpoint in VSCode
🐛 Bug Report
Debug Jest with current test file doesn't stop at correct breakpoint in VSCode
To Reproduce
Open Jest source code in VSCode (tested in VSCode 1.26.1 on Ubuntu 18.04.1)
Open any test file (tested with putting breakpoint at on line 28 of is_valid_path.test.js)
Go to debug mode in VSCode, and click "Debug Jest with current test file"
Notice that debugger stops at line 22 instead
Screen Recording
Expected behavior
Debugger stops at Line 28
This issue was moved to jest-community/vscode-jest#372
| gharchive/issue | 2018-08-30T06:48:57 | 2025-04-01T06:44:07.851351 | {
"authors": [
"trivikr"
],
"repo": "facebook/jest",
"url": "https://github.com/facebook/jest/issues/6918",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
223620709 | Support setting returnvalue from mock to undefined
Summary
Fixes #3320
Test plan
yarn jest
SegFault on CI, but I'm not allowed to restart it
Codecov Report
Merging #3354 into master will increase coverage by <.01%.
The diff coverage is 100%.
@@ Coverage Diff @@
## master #3354 +/- ##
==========================================
+ Coverage 64.93% 64.94% +<.01%
==========================================
Files 176 176
Lines 6514 6515 +1
Branches 4 4
==========================================
+ Hits 4230 4231 +1
Misses 2283 2283
Partials 1 1
Impacted Files
Coverage Δ
packages/jest-mock/src/index.js
91.85% <100%> (+0.03%)
:arrow_up:
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9288e4...db657c7. Read the comment docs.
| gharchive/pull-request | 2017-04-23T08:18:41 | 2025-04-01T06:44:07.859293 | {
"authors": [
"SimenB",
"codecov-io"
],
"repo": "facebook/jest",
"url": "https://github.com/facebook/jest/pull/3354",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
284231773 | [Discussion] Expect only overrides error stack for built-in matchers
Proof of concept for Christoph's suggestion from PR #5138.
Resolves #5136
Note: I don't have much context for the Jest project so this might be an unacceptable hack. 😄
Codecov Report
Merging #5162 into master will not change coverage.
The diff coverage is n/a.
@@ Coverage Diff @@
## master #5162 +/- ##
=======================================
Coverage 60.64% 60.64%
=======================================
Files 201 201
Lines 6695 6695
Branches 4 4
=======================================
Hits 4060 4060
Misses 2634 2634
Partials 1 1
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e879099...f39d750. Read the comment docs.
| gharchive/pull-request | 2017-12-22T19:07:17 | 2025-04-01T06:44:07.865606 | {
"authors": [
"bvaughn",
"codecov-io"
],
"repo": "facebook/jest",
"url": "https://github.com/facebook/jest/pull/5162",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
456483458 | proof-of-concept fix for #8570
Summary
This is a fix for #8570.
Test plan
Codecov Report
Merging #8571 into master will not change coverage.
The diff coverage is n/a.
@@ Coverage Diff @@
## master #8571 +/- ##
======================================
Coverage 63.2% 63.2%
======================================
Files 271 271
Lines 11284 11284
Branches 2749 2748 -1
======================================
Hits 7132 7132
Misses 3538 3538
Partials 614 614
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe14493...2f34d49. Read the comment docs.
Another question: I see that a bunch of the jest type declarations refer to NodeJS types but don't declare a "@types/node": "*" dependency.
Do you want to add that dependency to those modules or instead stub out the global NodeJS namespace with empty interfaces?
Another question: I see that a bunch of the jest type declarations refer to NodeJS types but don't declare a "@types/node": "*" dependency.
Do you want to add that dependency to those modules or instead stub out the global NodeJS namespace with empty interfaces?
That's on purpose due to #8092
As far as I know this is good to go. Is there anything else that needs to be added?
Thanks!
Hi, I found this PR referenced here https://stackoverflow.com/questions/56181799/how-to-use-mocha-and-jest-with-typescript-without-conflicts
Is there any reason why this wasn't released? Or is it released already? I am trying to use Mocha for integration test and jest for unit tests and I'm running into this issue.
Thanks!
This was released in 24.9.0 last week
| gharchive/pull-request | 2019-06-15T00:54:22 | 2025-04-01T06:44:07.874688 | {
"authors": [
"SimenB",
"codecov-io",
"cspotcode",
"matthoang08"
],
"repo": "facebook/jest",
"url": "https://github.com/facebook/jest/pull/8571",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
2072337996 | Bug: Inconsistent behaviour from useLexicalTextEntity when there are several matches within the same node
This issue it a bit hard to pin down, so this is the summary and my personal guess/read on it.
Essentially following the HashtagNode and HashtagPlugin example, I wanted to create a plugin which will replace text in the format of ${SOMETHING} with my own VariableNodes. Here's a cut down version of the implementation.
For the most part it works - especially newly written matching strings, correctly get transformed. The lifecycle of my app involves downloading some content, parsing it and then using $insertNodes to add them to the editor, users can then continue editing. However I started noticing some obvious gaps. In the screenshot below ${Tenant.Zip} and ${Facility.Zip} fail to transform into VariableNodes.
After some experimenting I found out this only happens if I select the }, omitting it correctly selected the remainder of text and transformed it.
It would appear this issue only happens to the very last instances of a match within a textNode and only if that last instance is also the final character within that text node's textContent.
Lexical version: 0.12.6
Steps To Reproduce
Visit https://codesandbox.io/p/sandbox/lexical-closing-8n55xm?file=%2Fsrc%2FApp.tsx%3A10%2C9
Paste some content into the editor, with a text node which ends in ${Something.Other}
The current behavior
Everything gets highlit
The expected behavior
Only matches before the last one get highlit
Need to remove isTextEntity declaration | gharchive/issue | 2024-01-09T13:04:49 | 2025-04-01T06:44:07.880397 | {
"authors": [
"GMchris",
"whyour"
],
"repo": "facebook/lexical",
"url": "https://github.com/facebook/lexical/issues/5466",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
1210913627 | How to handle message？
@Override
protected void onCreate(@Nullable Bundle savedInstanceState) {
Intent data = getIntent();
Handler handler = this.y;
Message message = Message.obtain(handler, 1);
message.obj = data;
this.y.sendMessageDelayed(message, 100L);
}
private Handler y = new Handler(Looper.getMainLooper()) {
@Override
public final void handleMessage(Message message) {
super.handleMessage(message);
Object obj = message.obj;
ShareTransActivity.this.startActivity((Intent) obj);
}
};
Hey, can I increase the “Propagation” or sth. to check out this path?
Solution found
| gharchive/issue | 2022-04-21T11:40:04 | 2025-04-01T06:44:07.887252 | {
"authors": [
"houugen"
],
"repo": "facebook/mariana-trench",
"url": "https://github.com/facebook/mariana-trench/issues/84",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
2167629720 | Issue with "Setting up the development environment" Page version=0.73
Update required for Android SDK Platform 34 in the documentation
Description
On this page, under Creating a new application section, the command used for creating a new project with name "Awesome Project" is npx react-native@latest init AwesomeProject.
This creates the project with Android SDK Platform 34, however in the documentation the SDK platform version as well as the system images are mentioned for Android SDK Platform 33. This resulted in a lot weird errors.
Documentation version
Changes needed to be reflected in the following documentation version:
0.73
next
You're right @litoco.
Don't you mind sending over a PR to update the required platform to 34 for 0.73 and next?
@cortinico PR sent.
Thanks for the quick follow up @litoco! 👍 Closing as done!
Yo. I followed the guide just now and it still says to install Android 13, SDK 33 etc for 0.74.
https://reactnative.dev/docs/environment-setup?platform=android
Last updated on Apr 22, 2024
| gharchive/issue | 2024-03-04T19:53:09 | 2025-04-01T06:44:07.945362 | {
"authors": [
"Simek",
"Voxar",
"cortinico",
"litoco"
],
"repo": "facebook/react-native-website",
"url": "https://github.com/facebook/react-native-website/issues/4036",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
75696632 | navigator.pop() doesn't remove the last route
It makes transition to a previous scene, returns true but doesn't remove the last route in stack.
@pukhalski - please post a minimal example demonstrating the issue :smile:
Are you looking for navigator.pop() line of code?) Mkay, honestly I have a pretty much comprehensive usage of navigator within my router module. Anyway, here it goes:
'use strict';
var React = require('react-native');
var Scene1 = require('../scenes/Scene1');
var Scene2 = require('../scenes/Scene2');
var {
Navigator
} = React;
var Router = React.createClass({
displayName: 'Router',
prevState: {},
getInitialState() {
return this.states()['sceneState1']();
},
go(path, data) {
var routes = this.navigator.getCurrentRoutes();
var route = {
path: path,
data: data,
index: routes.length
};
if (routes[routes.length - 1].path === path) {
return false;
}
this.navigator.push(route);
return true;
},
back() {
this.navigator.pop();
},
states() {
return {
scene1: () => {
return {
};
},
scene2: (route) => {
return {
};
}
}
},
views() {
return {
scene1: (route, navigator) => {
return (<Scene1 router={this} />);
},
scene2: (route, navigator) => {
return (<Scene2 router={this} />);
}
}
},
_beforeTransition(route) {
var path = route.path || '';
if (typeof this.states()[path] === 'function') {
this.prevState = this.state;
this.setState(this.states()[path](route));
}
},
render() {
return (
<View style={{flex: 1}}>
<Navigator
onWillFocus={this._beforeTransition}
initialRoute={{index: 0, path: 'scene1'}}
renderScene={
(route, navigator) => {
if (!this.navigator) this.navigator = navigator;
if (typeof this.views()[route.path] === 'function') {
return this.views()[route.path](route, this.navigator);
}
}
}
/>
</View>
);
}
});
module.exports = Router;
I can consistently reproduce this as well...here's an app that pushes 4 pages, and offers a back button that pops...it also renders the index and page count so you can see that after popping the list of current routes has not changed.
'use strict';
var React = require('react-native');
var {
AppRegistry,
Text,
Navigator,
TouchableOpacity
} = React;
var Page = React.createClass({
render: function () { return null; }
});
var App = React.createClass({
render: function () {
return (
<Navigator
initialRouteStack={[
{
name: 'Page 1',
component: Page
},
{
name: 'Page 2',
component: Page
},
{
name: 'Page 3',
component: Page
},
{
name: 'Page 4',
component: Page
}
]}
configureScene={function () {
return Navigator.SceneConfigs.HorizontalSwipeJump;
}}
renderScene={function (route, navigator) {
return <route.component navigator={navigator} route={route} />
}}
navigationBar={
<Navigator.NavigationBar routeMapper={{
Title: function (route, navigator, index, navbar) {
return <Text>{(index + 1) + '/' + navigator.getCurrentRoutes().length}</Text>;
},
LeftButton: function (route, navigator, index, navbar) {
var onPress = function () {
navigator.pop();
};
return <TouchableOpacity onPress={onPress}><Text>Back</Text></TouchableOpacity>;
},
RightButton: function () {
return null;
}
}}/>
} />
);
}
});
AppRegistry.registerComponent('Text', function () {
return App;
});
i'm believe this is related to the size of initialRouteStack. no matter how many pushes/pops i do, navigator.getCurrentRoutes().length is never less than the initial length provided...ie, if i provide 4 routes to start, i can push routes, and that will change the length of getCurrentRoutes, and it will correctly pop those off (and update the length of getCurrentRoutes), but no matter how many times i pop, getCurrentRoutes().length never goes below the original count.
@pwmckenna, Am I understanding correctly that the issue is valid and appears not only for me? Because one of my assumptions was that the problem is with my router module itself.
@pukhalski I'm actually not able to repro your issue. My mistake was assuming that the navigation bar would be re-rendered when the view it was tied to was rendered. Ignore my contributions to this thread.
I've replicated this issue. I adding some code that logs the count of the route stack onDidFocus, and I've noticed that after swiping back, the count does not go down. I should be able to fix this today or tonight.
Perfect! Thanks!
| gharchive/issue | 2015-05-12T18:35:28 | 2025-04-01T06:44:07.952272 | {
"authors": [
"brentvatne",
"ericvicenti",
"pukhalski",
"pwmckenna"
],
"repo": "facebook/react-native",
"url": "https://github.com/facebook/react-native/issues/1252",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
255313676 | CameraModule is not loading correctly
react-native -v: 0.45.1
node -v: 6.10.0
npm -v: 5.3.0
Target Platform: Android/Ios
Development Operating System: Windows 10
Build tools: 23
Put the following line on your react-native code, and debug js remotly.
const CameraManager = NativeModules.CameraManager || NativeModules.CameraModule;
CameraManager is always undefined
Sometimes CameraModule is undefined
When CameraModule is not undefined it does not have all the needed functionality, for example, aspect()
Can you please verify this on the latest version? We don't support old versions.
@facebook-github-bot duplicate #15809
I've just verified my project with last version of RN. Camera module is still not loading all the functionality. In the following image you can see that CameraModule does not have Aspect for instance. So, once I load the application the line CameraModule.Aspect.Fill breaks.
| gharchive/issue | 2017-09-05T15:17:26 | 2025-04-01T06:44:07.956693 | {
"authors": [
"ferminmoli",
"radko93"
],
"repo": "facebook/react-native",
"url": "https://github.com/facebook/react-native/issues/15814",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
283512900 | Absolute positioning inside a SectionList on Android
Is this a bug report?
Yes
Have you read the Contributing Guidelines?
Yes
Environment
OS: macOS Sierra 10.12.6
Node: 8.1.3
Yarn: 1.3.2
npm: 5.5.1
Watchman: 4.9.0and
Xcode: Xcode 9.2 (9C40b)
Android Studio: 3.0, AI-171.4443003
react-native: 0.45.1
react: 16.0.0-alpha.12
Target Platform: iOS (10.3)
Steps to Reproduce
Inside a SectionList component, absolutely position the items of one of the sections.
import React, { Component } from 'react';
import { SectionList, View, Text } from 'react-native';
const boxStyle = {
height: 50,
width: 50,
opactiy: 0.6,
};
const renderRed = () => (
<View style={{
...boxStyle,
backgroundColor: 'red',
}} />
);
const renderBlue = () => (
<View style={{
...boxStyle,
backgroundColor: 'blue',
position: 'absolute',
left: -10,
top: -25,
}} />
);
export default class App extends Component {
render() {
const sections = [
{
data: [{
id: 1,
}],
renderItem: renderRed,
},
{
data: [{
id: 2,
}],
renderItem: renderBlue,
},
];
return (
<View style={{padding: 30}}>
<Text>Section list bug</Text>
<SectionList
keyExtractor={item => item.id}
sections={sections}
/>
</View>
);
}
}
Expected Behavior
On iOS, the components are absolutely positioned as expected:
Actual Behavior
On Android, the absolutely positioned items disappear (or sometimes on Expo the app crashes):
Reproducible Demo
Expo Snack: https://snack.expo.io/@jackvlj/android-sectionlist-with-absolute-positioning
Android View Hierarchy has many issues
| gharchive/issue | 2017-12-20T10:16:24 | 2025-04-01T06:44:07.961508 | {
"authors": [
"bolan9999",
"jacklj"
],
"repo": "facebook/react-native",
"url": "https://github.com/facebook/react-native/issues/17285",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
394330329 | After calling scrollToLocation method of SectionList, scroll is jumping
I want to implement something like scrollspy on the web with section list.
I'm using scrollToLocation method.
The problem is when scrolling is finished the scroll is jumping. I think it causes by loading previous rows. I don't know why this issue happens even when providing getItemLayout prop.
Here is a basic demo.
Looks like the effect you would see if getItemLayout is not implemented correctly. Can you post a reproducible demo?
@bartolkaruza I just created a repo on Gitlab here
Possible duplicate of #20956
I have some pretty deeply nested "list" components and I'm having the same issue. I noticed once I switch to a basic View, Image, and Text component with no expensive calculations, that jumping does not occur anymore.
I'm thinking this issue correlates to having a "complex" repeating list component.
| gharchive/issue | 2018-12-27T08:31:34 | 2025-04-01T06:44:07.965043 | {
"authors": [
"bartolkaruza",
"danilobuerger",
"hamidhadi",
"jeffmon"
],
"repo": "facebook/react-native",
"url": "https://github.com/facebook/react-native/issues/22809",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
484360760 | username autoFill to the previous page's TextInput
snack link: https://snack.expo.io/@bmxklyzj/input-autocorrect-passord
There is two pages:
the first page has a TextInput:
<TextInput
// textContentType="password"
/>
and a button navigate to the second page
2. the second page has a TextInput with property secureTextEntry
<TextInput secureTextEntry />
in second page if i use ios password autoFill, the result is: password is filled in the second page's TextInput, but username is filled in the first page's TextInput.
what i expected is that the username shoud not autoFilled in the first page's TextInput
React Native version:
React Native Environment Info:
System:
OS: macOS 10.14.5
CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
Memory: 2.09 GB / 16.00 GB
Shell: 5.3 - /bin/zsh
Binaries:
Node: 8.9.4 - ~/.nvm/versions/node/v8.9.4/bin/node
Yarn: 1.17.3 - /usr/local/bin/yarn
npm: 5.6.0 - ~/.nvm/versions/node/v8.9.4/bin/npm
SDKs:
iOS SDK:
Platforms: iOS 12.2, macOS 10.14, tvOS 12.2, watchOS 5.2
IDEs:
Android Studio: 3.4 AI-183.6156.11.34.5692245
Xcode: 10.2.1/10E1001 - /usr/bin/xcodebuild
npmPackages:
react: 16.8.3 => 16.8.3
react-native: 0.59.3 => 0.59.3
Steps To Reproduce
open the snack link: https://snack.expo.io/@bmxklyzj/input-autocorrect-passord to see the code. And to use ios password autofill, you must preview the demo on physical devices
in the first page click the button to navigate to the second page
in the second page click password autofill in keyboard accessory
back to the first page to see username is utofilled in TextInput
what i've tried
TextInput textcontenttype set textContentType to 'none' in second page not work, i can not disable password autoFill
Describe what you expected to happen:
two result acceptable:
can disable the password autoFill in ios keyboard accessory
the username not autoFilled in the first page's TextInput
Snack, code example, screenshot, or link to a repository:
Gif:
Still happens to me, really no idea how to resolve it ether.
For reference, these are 3 pages created using react-navigation. You can see that by clicking the password in the current page, it will autofill with a strong password....but also autofill the password in the bottom page of the stack.
Still happens to me, really no idea how to resolve it ether.
yes, I think it's a bug. Althouth you can add an unvisible TextInput in the current page, but it's too ugly
@bmxklYzj This caused more problems than it was worth for me. I had a semi-working solution with several hidden TextInputs, but still ran into bugs on other pages for the same reason. In the end I had to disable the TextInput when navigating away from the page, or replace that screen in the stack entirely. Really a pain.
Still exists
| gharchive/issue | 2019-08-23T06:54:11 | 2025-04-01T06:44:07.975846 | {
"authors": [
"bmxklYzj",
"declanelcocks"
],
"repo": "facebook/react-native",
"url": "https://github.com/facebook/react-native/issues/26159",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
497251013 | [0.61.*] Broken shadow on android
Looks like shadow/elevation is broken on android on react-native@0.61.*, see pictures below
It only happens when the https://github.com/santomegonzalo/react-native-floating-action is being used. I'm not able to reproduce it without this.
To receive the expected result uncomment App.js:25-35 and restart react-native using react-native run-android.
It looks like other packages have this problem aswell, eg callstack/react-native-paper#1341 ,
React Native version:
System:
OS: Windows 10
CPU: (8) x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
Memory: 3.25 GB / 15.86 GB
Binaries:
Node: 11.9.0 - C:\Program Files\nodejs\node.EXE
Yarn: 1.12.3 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
npm: 6.10.1 - C:\Users\bouwm\AppData\Roaming\npm\npm.CMD
IDEs:
Android Studio: Version 3.4.0.0 AI-183.6156.11.34.5692245
Steps To Reproduce
clone the git repo
run npm install and react-native run-android
Describe what you expected to happen:
The circle in the middle should look like this:
But it looks like this:
Snack, code example, screenshot, or link to a repository:
Git repo: https://github.com/mikebouwmans/ShadowTest
Hi @mikebouwmans , does it happen for you with every API level?
For me only with Android API Level 26
I took the liberty to create a minimal example repository which demonstrates the issue without using third party libraries: https://github.com/forsen/shadowTest
This is how the repository is created:
react-native init
Upgrade from v0.60.5 to v0.61.0-rc3 per rn-diff-purge instructions
Add a circular view with elevation
Hi @mikebouwmans , does it happen for you with every API level?
For me only with Android API Level 26
I will check this later today
I met with this issue about a week ago. I use the react-navigation and react-navigation-stack libraries and after upgrading to rn 0.61.0-rc.0 I noticed that when I switch from the root screen to any other, the views disappear, the shadows are drawn on top of the modal screens and the background is drawn on the outlined TextInput ( from the react-native-paper library). However, after making any screen root, everything in it is rendered correctly.
After enumerating different style values, I found the reason for the view to break: if view has a borderRadius other than undefined, then when switching to another screen, the view with borderRadius is rendered under all other views, even if you specify zIndex. Until you reload, all views on all screens with borderRadius (including the root) will be broken. For this reason, it seems that the bug is associated with shadows, but everything is fine with them :)
To reproduce this bug, I created a repository https://github.com/B27/React-Native-borderRadius-test based on rn-diff-purge (branch release/0.61.0-rc.3). The project contains two screens with the same content. After switching to the second screen, the modal window and the other views with borderRadius break until you set their borderRadius to undefined
The following screenshots are from api 28 (also tested on api 21 with the same result)
Normal:
With bugs:
With bugs but borderRadius undefined:
Setting borderRadius on Modal to undefined also solves the react-native-paper Dialog issue
Is it related to https://github.com/styled-components/css-to-react-native/issues/117 ? I though it was specific for styled components but I'm experiencing strange issues with background and positions relative since 0.61-rcX
I could reproduce the exact same issue just using a <TouchableOpacity/> which contains a circular <View />. The View has a shadow on it too.
When you press the element it becomes transparent and shows the exact same issue.
Can reproduce that already with RN 0.60.5 on Android, iOS looks fine.
I have the same issue on react native 0.59.10 so that's not something new I guess :/
@zwenza, @billouboq you are talking about normal shadow behavior in android not related to this issue.
Android and iOS implementation of shadows are very different, even for this they use different properties in styles (abstract elevation on Android, and CSS-like properties in iOS).
I could reproduce the exact same issue just using a <TouchableOpacity/> which contains a circular <View />. The View has a shadow on it too.
I created a new project with react-native 0.54.4 added <TouchableOpacity /> containing <View /> and saw the same. Because it is not a bug. In the android you always need to add an opaque backgroundColor for the View, or if you want to use transparency, then wrap it in an opaque View.
In android, if you want to use shadows + transparency, you always need to add an opaque backgroundColor for the View, or if you want to use transparency, then wrap it in an opaque View.
Thanks @B27 , will give this a try today!
@zwenza for TouchableOpacity there is a simpler way - apply elevation to TouchableOpacity itself. Instead of <TouchableOpacity> <View style={stylesWithElevation} /> </TouchableOpacity> use <TouchableOpacity style={elevationStyle}> <View style={viewStyle} /> </TouchableOpacity>
@zwenza I forgot that for TouchableOpacity there is a simpler way - apply elevation to TouchableOpacity itself. Instead of <TouchableOpacity> <View style={stylesWithElevation} /> </TouchableOpacity> use <TouchableOpacity style={elevationStyle}> <View style={viewStyle} /> </TouchableOpacity>
@gaearon Looks like a serious bug that went though the net :p On android
Since it is not immediately clear what the problem is (https://github.com/facebook/react-native/issues/26544#issuecomment-534616069), I recorded a video of the application from the repository https://github.com/B27/React-Native-borderRadius-test showing a bug: https://www.youtube.com/watch?v=wA6H2m153Yg
Let me remind you that the screens are exactly the same (FirstScreen and SecondScreen use the same BugScreen component inside)
As i Posted in the linked topic here:
Here is an small example with a border radius (it's commented but try with uncommenting it)
const Bug = () => {
return (
<View style={{ flex: 1 }}>
<BuggingView />
<PageWrapper>
<Text>
This should appear above backgroundThis should appear above background This should appear above background This should appear
above above background This should appear above background This should appear above background This should appear above background
This This should appear above background This should appear above background This should appear above background This should
appear above background This should appear above background This should appear above background This should appear above
background This should appear above background This should appear above background This should appear above background This should
appear above background This should appear above background This should appear above background This should appear above
background This should appear above background This should appear above background This should appear above background This should
appear above background This should appear above background This should appear above background This should appear above
background This should appear above background
</Text>
</PageWrapper>
</View>
);
};
const BuggingView = styled.View`
height: 200;
position: absolute;
background-color: blue;
top: 0;
right: 0;
left: 0;
`;
const PageWrapper = styled.View`
background-color: red;
padding: 20px;
/* border-radius: 8px; */
flex: 1;
margin: 20px;
`;
The red box text is going front, and the red is missing behind the blue.
definitely related to border-radius on 0.61 (was also not working in rc-3)
Updating from 0.60.5 to 0.61.1 also caused something similar in our app, but only for Views that are positioned absolutely.
0.60.5
0.61.1
Yes, indeed the problem is about:
border-radius
elevation
or position: absolute
One of those (or all of them) is having issue with android since 0.61.x
Updating from 0.60.5 to 0.61.1 also caused something similar in our app, but only for Views that are positioned absolutely.
remove borderRadius and it will be in the foreground again
In 0.61.1 it works when applied on a white background
Same problem here, would be awesome it this problem gets a quick fix
I'm experiencing this in a few different situations:
I have a TouchableOpacity with a borderRadius of 40 on top of an ImageBackground. The TouchableOpacity backgroundColor is green, but it shows up with an invisible backgroundColor. When I remove the ImageBackground, the green reappears.
I have a react-native-modal Modal component with a borderRadius of 40. The backgroundColor again shows up as invisible, even though I have the styling set to white.
This happened when I upgraded to 0.61.1 from 0.60.5. Everything shows up as expected on iOS.
I am facing this problem and hope to solve it as soon as possible.
Reproduction:
https://github.com/mjmasn/ElevationIssue60 (working)
https://github.com/mjmasn/ElevationIssue61 (broken)
Forcing borderRadius attribute to undefined fixes the glitch. Libraries like react-native-paper or react-native-modal use this attribute with predetermined values on their elements, that is why the bug is manifesting there.
https://github.com/react-native-community/releases/issues/146#issuecomment-537006467
Regression has been introduced by this change: https://github.com/facebook/react-native/commit/14b455f69a30d128db384749347f41b03b9a6000
Shame that it broke everything as that sounds like a really nice fix for a longstanding problem with ripples + border radius :thinking:
Yeah, @mjmasn, hopefully, there's another fix soon.
Just submitted a PR #26682 with a rollback, once merged, this issue will be automatically closed.
Seems like I found workaround.
There is my code:
<TouchableOpacity
style={styles.button}
onPress={onPress}
>
<View style={styles.iconWrapper}>
<Icon
size={14}
name="share"
color="#fff"
/>
</View>
</TouchableOpacity>
and styles
button: {
position: 'absolute',
bottom: 10,
right: 10,
width: 40,
height: 40,
borderRadius: 40, // set borderRadius here
},
iconWrapper: {
display: 'flex',
justifyContent: 'center',
alignItems: 'center',
width: '100%',
height: '100%',
backgroundColor: 'rgba(72, 150, 242, .9)',
borderRadius: 40, // repeat borderRadius here
},
https://github.com/facebook/react-native/issues/26544#issuecomment-541458632
Not a workaround I think you lose the benefit of shadow box and Elevation doing like this.
@ScreamZ Yes, I agree with you, but I believe it is a temporary solution until guys fix this issue.
Was this the issue mentioned in the 0.61.2 release notes: https://github.com/facebook/react-native/releases/tag/v0.61.2 ? If so - shouldn't it be closed?
For some reason, I still get this in android
I used version 0.61.2.
I still get it with RN 0.61.5 version
This is a TextInput with white background, shadow, elevation and borderRadius
On API 28 devices
On API 28 emulator (correct behavior)
This is a View whit white background, shadow and elevation
On API 28 devices
On API 28 emulator (correct behavior)
I can confirm v0.61.2 fixes the absolute + borderRadius undesired effect on zIndex.
I have same issues after update 0.61.5
initially my project is in RN 0.57.0, due to 64-bit i have to update RN version so i have made it 0.60.5
So i getting same issues as above, i have read above comment @samiede to resolved in 0.61.1
Now i have updated my whole code RN in 0.61.5 , but issues is till there
RN in 0.57.0
RN in 0.61.5
"react": "16.9.0", "react-native": "0.61.5", "@react-native-community/datetimepicker": "^2.2.1", "@react-native-community/masked-view": "^0.1.6", "aws-sdk": "^2.610.0", "base-64": "^0.1.0", "locutus": "^2.0.11", "moment": "^2.24.0",
<KeyboardAvoidingView keyboardVerticalOffset={Platform.select({ ios: 0, android: 50 })} behavior={(Platform.OS === 'ios') ? "padding" : null} enabled style={{ flex: 1, backgroundColor: "#fff" }}> <SimpleActionBarWithTitle title={" " + Strings.Title_Scan_Rego} handleBackButtonClick={this.handleBackButtonClick} /> <Loader loading={(this.state.isProcessing || this.props.scanRegoJobDetailsData.isLoading) && (!this.props.unAuthorizedReducer.isUnAuthorised)} /> <Image style={{ height: "60%" }} source={{ uri: this.props.navigation.state.params.uri }} /> <View style={styles.textInputMainView}> <TextInput style={[styles.textInputStyle, { textAlign: "center", paddingLeft: 3 }]} placeholder={Strings.Rego} keyboardType={Platform.OS === 'android' ? 'email-address' : 'ascii-capable'} value={this.state.rego} placeholderTextColor="#9e9e9e" onChangeText={(value) => { this.setState({ rego: value }) }} InputProps={{ disableUnderline: true }} underlineColorAndroid="transparent" /> </View> <View style={{ flex: 1, flexDirection: "row" }}> <TouchableOpacity style={[styles.saveButtonStyle, { marginLeft: "15%", backgroundColor: "#c3c3c3", }]} activeOpacity={0.5} onPress={() => this.onRetakeImageScreen()}> <Text style={{ color: "#fff", textAlign: "center", fontSize: 20 }}> {Strings.Label_Retry} </Text> </TouchableOpacity> <TouchableOpacity style={[styles.saveButtonStyle, { marginRight: "15%" }]} activeOpacity={0.5} onPress={() => this.onJobDetailsScreen()}> <Text style={{ color: "#fff", textAlign: "center", fontSize: 20 }}> {Strings.Next} </Text> </TouchableOpacity> </View> </KeyboardAvoidingView>
`textInputStyle: {
paddingHorizontal: 16,
fontSize: 19,
minWidth: 120,
color: colors.black,
fontWeight: 'bold',
},
textInputMainView: {
justifyContent: "center",
backgroundColor: "#fff",
alignItems: 'center',
borderWidth: 1,
borderColor: "#fff",
height: 60,
borderRadius: 100,
marginTop: 20,
marginBottom: 5,
marginLeft: '15%',
marginRight: '15%',
...Platform.select({
ios: {
shadowColor: 'rgba(0,0,0, 0.4)',
shadowOffset: { height: 3, width: 0 },
shadowOpacity: 0.7,
shadowRadius: 5
},
android: {
elevation: 4,
}
}),
},
saveButtonStyle: {
height: 48,
flex: 1,
marginHorizontal: 10,
marginTop: 20,
marginBottom: 10,
backgroundColor: 'rgba(21, 221, 241, 1)',
borderRadius: 100,
justifyContent: "center",
...Platform.select({
ios: {
shadowColor: 'rgba(0,0,0, 0.4)',
shadowOffset: { height: 3, width: 0 },
shadowOpacity: 0.7,
shadowRadius: 5
},
android: {
elevation: 4,
}
}),
},`
If any one have any solution without change in code, Please let me know, bcz my project is so much large
Has this bug been open 5 months already?
Have the same issue
devices: samsung s9+, s10+
android version: 10
react-native: 0.61.5
on android 8.1.0 looks good
set activeOpacity to 1 on parent TouchableOpacity will fix it.
activeOpacity={1}
Still not fixed.
just set elevation to 0
just set elevation to 0
How does that solve anything?
I'm also facing this issue on "react-native": "0.62.2"
I am having the same issue in "0.61.4"
On long press button on TouchableOpacity i am getting a unwanted shadow like a pentagon on my circled button .
just add a backgroundColor property
can't find a reproducible example to solve this Issue. This post unluckily includes several message, but NO CLEAR REQUIREMENT
Better close this issue and open a new one with clear explanation of the issue. Thanks
it is interesting that this bug appears optionally
odd buttons is fine but even buttons show octagon
Unluckily this issue was opened because the elevation did not work with https://github.com/santomegonzalo/react-native-floating-action
Everybody with similar issue may have joined this thread instead of reporting a new issue
This thread should be closed and you should open a new thread with a minimal reproducible example build with react-native only. Most of the messages in this thread are not relevant for react-native, as they descrive an issue of https://github.com/santomegonzalo/react-native-floating-action
open an issue in https://github.com/santomegonzalo/react-native-floating-action
Thanks
Best Regards
could still confirm this issue with "react-native": "0.63.4"
Hello everyone, please read on renderToHardwareTextureAndroid to resolve this issue
Hhow is this still being ignored? Its obvious that even in 62+ of react native this is still an issue.
I also analyzed this bug, here is what I found and how it can be worked around (in some cases)
https://picostitch.com/tidbits/2020/12/android-ripple-effect-analyzed/#background-color-on-a-child-overlays-ripple-effect
I'm still seeing this - here's a really basic snack that reproduces this issue: https://snack.expo.dev/F3qj5M_AM. Run it on Android and see the weird octagons
Are there any updates on this issue?
until the bug is resolved, you can use this library
https://www.npmjs.com/package/react-native-shadow-2
Also present on 0.64.2. This is easily reproducible with a simple view with elevation + touchable opacity on top.
can confirm, this problem is present in 0.64.3 as well, all components get this inset shadow effect when a fade transition occurs from react-navigation-bottom-tabs navigator
So the thing here is that the shadows on a TouchableOpacity child is not displayed properly when it is pressed.
I can think of sharing two walkarounds for this:
To Match parent width and height: this is not always possible, eg:
<TouchableOpacity style={{width: 100, height: 100, borderRadius: 50}}>
<View style={{width: 100, height: 100, borderRadius: 50}}>
{content}
</View>
</TouchableOpacity>
To use state helpers to turn off the shadow, not really recommended since it is unelegant. eg:
const [showhadow, setShowShadow] = React.useState(true)
const hideShadow = () => setShowShadow(false)
const doShowShadow = () => setTimeout(() => setShowShadow(true), 50)
return (
<TouchableOpacity onPressIn={hideShadow} onPressOut={doShowShadow} onPress={doSomething} >
<View style={showhadow ? SHADOW_STYLE : null} >
<Text text="Text inside the view" style={ICON_TEXT}/>
</View>
<Text text="Text outside the view" style={ICON_TEXT}/>
</TouchableOpacity>
)
Note: in the second example, if the View is replaced for another TouchableOpacity that can also call "doSomething", the shadow will automatically be recalculated correctly displaying a neat shadow when pressing but if the user presses on the Text outside area, shadow will continue to show the deformation (since the parent TouchableOpacity is doing the calculation of the shadow for the inner child and fails).
Hello everyone, please read on renderToHardwareTextureAndroid to resolve this issue
Reproduced the same bug today.
As @Sunhat suggested in the answer above, setting renderToHardwareTextureAndroid={true} in <Animated.View /> resolves this issue.
If someone still experiencing troubles with elevation, give it a try.
And check documentation here.
| gharchive/issue | 2019-09-23T18:16:59 | 2025-04-01T06:44:08.037906 | {
"authors": [
"B27",
"EhsanSarshar",
"Jonathan0wh",
"R8Manzo",
"RandomToni",
"Rapsssito",
"ScreamZ",
"SimonFricker",
"Sunhat",
"UmeshBaldaniya46",
"VehpuS",
"albullington",
"alexeyvax",
"ammoradi",
"atefeh-mt",
"billouboq",
"cuongtora1996",
"ess3nt",
"evtuhovdo",
"fabriziobertoglio1987",
"fellenabmb",
"forsen",
"fqborges",
"gdoudeng",
"grabbou",
"hm-harshit",
"johneyo",
"jongoh-lee",
"karvulf",
"marcorm",
"mikebouwmans",
"mjmasn",
"monkeedev",
"rinxtzu",
"samiede",
"sharad-epam",
"supmanyu",
"wazapenAI",
"wolframkriesing",
"zibs",
"zwenza"
],
"repo": "facebook/react-native",
"url": "https://github.com/facebook/react-native/issues/26544",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
110109415 | Android - Crash obtaining RCTDeviceEventEmitter from ReactContext
I'm following the docs (https://facebook.github.io/react-native/docs/native-modules-android.html#sending-events-to-javascript) to send native events to JavaScript.
I've implemented a native module. I save the ReactApplicationContext passed to the constructor as a local variable private ReactApplicationContext mContext;
Then, I try to access the RCTDeviceEventEmitter like so:
DeviceEventManagerModule.RCTDeviceEventEmitter emitter = mContext.getJSModule(DeviceEventManagerModule.RCTDeviceEventEmitter.class);
This line crashes with the error: Method threw 'java.lang.AssertionError' exception. Cannot evaluate $Proxy4.toString()
same error! How to solve it?
Oh,I solved it by a function sendEvent like docs show,but why?
@marsprince can you explain further how you did this?
@marcshilling I just copied codes in docs and it worked it.I am confused too.
i'm having the same issue. with 0.19
Method threw 'java.lang.AssertionError' exception. Cannot evaluate $Proxy3.toString()
have same issue with 0.20
Method threw 'java.lang.AssertionError' exception. Cannot evaluate $Proxy9.toString()
I think this is because the context received in your module's constructor is of type ReactApplicationContext . If you cast it to ReactContext, it should be ok. The method does so, which is why it works.
@facebook-github-bot answered
I don't think it's really a solution - I am calling getJSModule on a applicationContext and there are no crashes. In fact, it's a subclass, so casting should have no effect.
Can anyone provide a better stack trace and their full example of passing context, assigning and sending an event?
Are you using it inside the constructor? Can you post a full example?
Closing this since there are no details available regarding the issue, and it's not actionable. Please try with latest version of React Native and see if this still happens. Let's reopen if it's still an issue and we have more details.
| gharchive/issue | 2015-10-06T21:55:49 | 2025-04-01T06:44:08.046403 | {
"authors": [
"VonD",
"grabbou",
"kocyigityunus",
"marcshilling",
"marsprince",
"satya164",
"soxunyi"
],
"repo": "facebook/react-native",
"url": "https://github.com/facebook/react-native/issues/3256",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
1913062210 | Issue during release build - A failure occurred while executing com.android.build.gradle.internal.res.Aapt2CompileRunnable
Description
Here's the issue that I've encountered during the release build of my app. I can't share the source code, so if you need anything to identify the problem, just ask me.
I was thinking that the issue is caused by the difference in Gradle versions between the one used by the framework and the one used by the dependencies.
Android gradle plugin: 7.4.2
Gradle: 8.0.1
But if that were the case, I shouldn't be able to build in debug mode.
Thank you in advance for the help provided
React Native Version
0.72.5
Output of npx react-native info
System:
OS: macOS 13.4
CPU: (8) arm64 Apple M1
Memory: 85.11 MB / 8.00 GB
Shell:
version: 3.2.57
path: /bin/bash
Binaries:
Node:
version: 18.17.1
path: ~/.nvm/versions/node/v18.17.1/bin/node
Yarn:
version: 1.22.19
path: ~/.yarn/bin/yarn
npm:
version: 9.6.7
path: ~/.nvm/versions/node/v18.17.1/bin/npm
Watchman:
version: 2023.08.28.00
path: /usr/local/bin/watchman
Managers:
CocoaPods:
version: 1.12.1
path: /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms:
- DriverKit 22.4
- iOS 16.4
- macOS 13.3
- tvOS 16.4
- watchOS 9.4
Android SDK: Not Found
IDEs:
Android Studio: 2022.3 AI-223.8836.35.2231.10671973
Xcode:
version: 14.3.1/14E300c
path: /usr/bin/xcodebuild
Languages:
Java:
version: 11.0.20
path: /usr/bin/javac
Ruby:
version: 2.6.10
path: /usr/bin/ruby
npmPackages:
"@react-native-community/cli": Not Found
react:
installed: 18.2.0
wanted: ^18.2.0
react-native:
installed: 0.72.5
wanted: 0.72.5
react-native-macos: Not Found
npmGlobalPackages:
"*react-native*": Not Found
Android:
hermesEnabled: true
newArchEnabled: false
iOS:
hermesEnabled: true
newArchEnabled: Not found
Steps to reproduce
Initialize react-native project in version 0.72.5
Install dependencies
"dependencies": {
"@gorhom/bottom-sheet": "^4.5.1",
"@react-native-async-storage/async-storage": "^1.19.3",
"@react-native-community/cli-platform-android": "^11.3.8",
"@react-native-community/geolocation": "^3.1.0",
"@react-native-community/push-notification-ios": "^1.11.0",
"@react-native/gradle-plugin": "^0.72.11",
"@react-navigation/bottom-tabs": "^6.5.8",
"@react-navigation/drawer": "^6.6.3",
"@react-navigation/native": "^6.1.7",
"@react-navigation/native-stack": "^6.9.13",
"@sayem314/react-native-keep-awake": "^1.2.2",
"date-fns": "^2.30.0",
"i18next": "^23.5.1",
"mitt": "^3.0.1",
"react-i18next": "^13.2.2",
"react-native-device-info": "^10.11.0",
"react-native-document-picker": "^9.0.1",
"react-native-gesture-handler": "^2.13.1",
"react-native-heroicons": "^3.2.0",
"react-native-image-picker": "^7.0.0",
"react-native-localize": "^3.0.2",
"react-native-notifications": "^5.1.0",
"react-native-pager-view": "^6.2.1",
"react-native-permissions": "^3.9.2",
"react-native-reanimated": "^3.5.4",
"react-native-render-html": "^6.3.4",
"react-native-safe-area-context": "^4.7.2",
"react-native-screens": "^3.25.0",
"react-native-svg": "^13.14.0",
"react-native-tab-view": "^3.5.2",
"react-native-video": "^5.2.1",
"rn-fetch-blob": "^0.12.0",
"tinycolor2": "^1.6.0",
"zustand": "^4.4.1"
},
"devDependencies": {
"@types/react-native-video": "^5.0.15",
"@types/tinycolor2": "^1.4.4",
"babel-plugin-module-resolver": "^5.0.0",
},
Configure dependencies
Run the project on android in debug mode
Everything should works but we should have java deprecated warning
Run the android release build.
And it should crash with the following issue
> Task :app:mergeReleaseResources FAILED
> Task :react-native-safe-area-context:compileReleaseKotlin
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-safe-area-context/android/src/main/java/com/th3rdwave/safeareacontext/SafeAreaView.kt: (58, 23): 'getter for uiImplementation: UIImplementation!' is deprecated. Deprecated in Java
> Task :react-native-screens:compileReleaseKotlin
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/Screen.kt: (77, 22): 'constructor GuardedRunnable(ReactContext!)' is deprecated. Deprecated in Java
...
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':app:mergeReleaseResources'.
> A failure occurred while executing com.android.build.gradle.internal.res.Aapt2CompileRunnable
> Android resource compilation failed
ERROR:/Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/android/app/build/generated/res/createBundleReleaseJsAndAssets/drawable-mdpi/src_assets_icon.png: AAPT: error: file failed to compile.
* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
* Get more help at https://help.gradle.org
BUILD FAILED in 1m 34s
error Failed to install the app.
info Run CLI with --verbose flag for more details.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Snack, screenshot, or link to a repository
> Task :app:mergeReleaseResources FAILED
> Task :react-native-safe-area-context:compileReleaseKotlin
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-safe-area-context/android/src/main/java/com/th3rdwave/safeareacontext/SafeAreaView.kt: (58, 23): 'getter for uiImplementation: UIImplementation!' is deprecated. Deprecated in Java
> Task :react-native-screens:compileReleaseKotlin
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/Screen.kt: (77, 22): 'constructor GuardedRunnable(ReactContext!)' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/ScreenStackFragment.kt: (62, 28): 'setter for targetElevation: Float' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/ScreenStackFragment.kt: (119, 28): 'setter for targetElevation: Float' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/ScreenStackHeaderConfig.kt: (85, 34): 'getter for systemWindowInsetTop: Int' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/ScreenStackHeaderConfig.kt: (227, 37): 'setColorFilter(Int, PorterDuff.Mode): Unit' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/ScreenWindowTraits.kt: (65, 22): 'constructor GuardedRunnable(ReactContext!)' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/ScreenWindowTraits.kt: (110, 22): 'constructor GuardedRunnable(ReactContext!)' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/ScreenWindowTraits.kt: (137, 47): 'replaceSystemWindowInsets(Int, Int, Int, Int): WindowInsetsCompat' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/ScreenWindowTraits.kt: (138, 51): 'getter for systemWindowInsetLeft: Int' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/ScreenWindowTraits.kt: (140, 51): 'getter for systemWindowInsetRight: Int' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/ScreenWindowTraits.kt: (141, 51): 'getter for systemWindowInsetBottom: Int' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/SearchBarManager.kt: (100, 22): Parameter 'view' is never used
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/SearchBarManager.kt: (100, 43): Parameter 'placeholder' is never used
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/SearchBarView.kt: (141, 43): Parameter 'flag' is never used
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/HeaderAttachedEvent.kt: (5, 44): 'RCTEventEmitter' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/HeaderAttachedEvent.kt: (7, 42): 'constructor Event<T : Event<(raw) Event<*>>!>(Int)' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/HeaderAttachedEvent.kt: (17, 44): 'RCTEventEmitter' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/HeaderAttachedEvent.kt: (18, 25): 'receiveEvent(Int, String!, WritableMap?): Unit' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/HeaderBackButtonClickedEvent.kt: (5, 44): 'RCTEventEmitter' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/HeaderBackButtonClickedEvent.kt: (7, 51): 'constructor Event<T : Event<(raw) Event<*>>!>(Int)' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/HeaderBackButtonClickedEvent.kt: (17, 44): 'RCTEventEmitter' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/HeaderBackButtonClickedEvent.kt: (18, 25): 'receiveEvent(Int, String!, WritableMap?): Unit' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/HeaderDetachedEvent.kt: (5, 44): 'RCTEventEmitter' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/HeaderDetachedEvent.kt: (7, 42): 'constructor Event<T : Event<(raw) Event<*>>!>(Int)' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/HeaderDetachedEvent.kt: (17, 44): 'RCTEventEmitter' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/HeaderDetachedEvent.kt: (18, 25): 'receiveEvent(Int, String!, WritableMap?): Unit' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/ScreenAppearEvent.kt: (5, 44): 'RCTEventEmitter' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/ScreenAppearEvent.kt: (7, 40): 'constructor Event<T : Event<(raw) Event<*>>!>(Int)' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/ScreenAppearEvent.kt: (13, 44): 'RCTEventEmitter' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/ScreenAppearEvent.kt: (14, 25): 'receiveEvent(Int, String!, WritableMap?): Unit' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/ScreenDisappearEvent.kt: (5, 44): 'RCTEventEmitter' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/ScreenDisappearEvent.kt: (7, 43): 'constructor Event<T : Event<(raw) Event<*>>!>(Int)' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/ScreenDisappearEvent.kt: (13, 44): 'RCTEventEmitter' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/ScreenDisappearEvent.kt: (14, 25): 'receiveEvent(Int, String!, WritableMap?): Unit' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/ScreenDismissedEvent.kt: (5, 44): 'RCTEventEmitter' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/ScreenDismissedEvent.kt: (7, 43): 'constructor Event<T : Event<(raw) Event<*>>!>(Int)' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/ScreenDismissedEvent.kt: (13, 44): 'RCTEventEmitter' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/ScreenDismissedEvent.kt: (17, 25): 'receiveEvent(Int, String!, WritableMap?): Unit' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/ScreenTransitionProgressEvent.kt: (5, 44): 'RCTEventEmitter' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/ScreenTransitionProgressEvent.kt: (13, 5): 'constructor Event<T : Event<(raw) Event<*>>!>(Int)' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/ScreenTransitionProgressEvent.kt: (22, 44): 'RCTEventEmitter' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/ScreenTransitionProgressEvent.kt: (27, 25): 'receiveEvent(Int, String!, WritableMap?): Unit' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/ScreenWillAppearEvent.kt: (5, 44): 'RCTEventEmitter' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/ScreenWillAppearEvent.kt: (7, 44): 'constructor Event<T : Event<(raw) Event<*>>!>(Int)' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/ScreenWillAppearEvent.kt: (13, 44): 'RCTEventEmitter' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/ScreenWillAppearEvent.kt: (14, 25): 'receiveEvent(Int, String!, WritableMap?): Unit' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/ScreenWillDisappearEvent.kt: (5, 44): 'RCTEventEmitter' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/ScreenWillDisappearEvent.kt: (7, 47): 'constructor Event<T : Event<(raw) Event<*>>!>(Int)' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/ScreenWillDisappearEvent.kt: (13, 44): 'RCTEventEmitter' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/ScreenWillDisappearEvent.kt: (14, 25): 'receiveEvent(Int, String!, WritableMap?): Unit' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/SearchBarBlurEvent.kt: (5, 44): 'RCTEventEmitter' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/SearchBarBlurEvent.kt: (7, 41): 'constructor Event<T : Event<(raw) Event<*>>!>(Int)' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/SearchBarBlurEvent.kt: (17, 44): 'RCTEventEmitter' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/SearchBarBlurEvent.kt: (18, 25): 'receiveEvent(Int, String!, WritableMap?): Unit' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/SearchBarChangeTextEvent.kt: (5, 44): 'RCTEventEmitter' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/SearchBarChangeTextEvent.kt: (10, 5): 'constructor Event<T : Event<(raw) Event<*>>!>(Int)' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/SearchBarChangeTextEvent.kt: (20, 44): 'RCTEventEmitter' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/SearchBarChangeTextEvent.kt: (23, 25): 'receiveEvent(Int, String!, WritableMap?): Unit' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/SearchBarCloseEvent.kt: (5, 44): 'RCTEventEmitter' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/SearchBarCloseEvent.kt: (7, 42): 'constructor Event<T : Event<(raw) Event<*>>!>(Int)' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/SearchBarCloseEvent.kt: (17, 44): 'RCTEventEmitter' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/SearchBarCloseEvent.kt: (18, 25): 'receiveEvent(Int, String!, WritableMap?): Unit' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/SearchBarFocusEvent.kt: (5, 44): 'RCTEventEmitter' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/SearchBarFocusEvent.kt: (7, 42): 'constructor Event<T : Event<(raw) Event<*>>!>(Int)' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/SearchBarFocusEvent.kt: (17, 44): 'RCTEventEmitter' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/SearchBarFocusEvent.kt: (18, 25): 'receiveEvent(Int, String!, WritableMap?): Unit' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/SearchBarOpenEvent.kt: (5, 44): 'RCTEventEmitter' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/SearchBarOpenEvent.kt: (7, 41): 'constructor Event<T : Event<(raw) Event<*>>!>(Int)' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/SearchBarOpenEvent.kt: (17, 44): 'RCTEventEmitter' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/SearchBarOpenEvent.kt: (18, 25): 'receiveEvent(Int, String!, WritableMap?): Unit' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/SearchBarSearchButtonPressEvent.kt: (5, 44): 'RCTEventEmitter' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/SearchBarSearchButtonPressEvent.kt: (7, 81): 'constructor Event<T : Event<(raw) Event<*>>!>(Int)' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/SearchBarSearchButtonPressEvent.kt: (17, 44): 'RCTEventEmitter' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/SearchBarSearchButtonPressEvent.kt: (20, 25): 'receiveEvent(Int, String!, WritableMap?): Unit' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/StackFinishTransitioningEvent.kt: (5, 44): 'RCTEventEmitter' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/StackFinishTransitioningEvent.kt: (7, 52): 'constructor Event<T : Event<(raw) Event<*>>!>(Int)' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/StackFinishTransitioningEvent.kt: (13, 44): 'RCTEventEmitter' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/main/java/com/swmansion/rnscreens/events/StackFinishTransitioningEvent.kt: (14, 25): 'receiveEvent(Int, String!, WritableMap?): Unit' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/paper/java/com/swmansion/rnscreens/FabricEnabledViewGroup.kt: (7, 42): Parameter 'width' is never used
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-screens/android/src/paper/java/com/swmansion/rnscreens/FabricEnabledViewGroup.kt: (7, 54): Parameter 'height' is never used
> Task :react-native-gesture-handler:compileReleaseKotlin
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/core/GestureHandler.kt: (770, 11): Name shadowed: size
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerEnabledRootView.kt: (9, 51): Unreachable code
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerEnabledRootView.kt: (10, 80): Unreachable code
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerRootHelper.kt: (80, 18): 'onChildStartedNativeGesture(MotionEvent!): Unit' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerRootHelper.kt: (86, 42): Parameter 'disallowIntercept' is never used
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerRootHelper.kt: (118, 28): Parameter 'viewTag' is never used
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerTouchEvent.kt: (7, 44): 'RCTEventEmitter' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerTouchEvent.kt: (14, 11): 'init(Int): Unit' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerTouchEvent.kt: (30, 42): 'RCTEventEmitter' is deprecated. Deprecated in Java
w: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-gesture-handler/android/src/main/java/com/swmansion/gesturehandler/react/RNGestureHandlerTouchEvent.kt: (31, 21): 'receiveEvent(Int, String!, WritableMap?): Unit' is deprecated. Deprecated in Java
w: Detected multiple Kotlin daemon sessions at build/kotlin/sessions
Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.
You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.
See https://docs.gradle.org/8.0.1/userguide/command_line_interface.html#sec:command_line_warnings
204 actionable tasks: 189 executed, 15 up-to-date
info 💡 Tip: Make sure that you have set up your development environment correctly, by running react-native doctor. To read more about doctor command visit: https://github.com/react-native-community/cli/blob/main/packages/cli-doctor/README.md#doctor
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/@react-native-async-storage/async-storage/android/src/main/java/com/reactnativecommunity/asyncstorage/AsyncStorageModule.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/@react-native-async-storage/async-storage/android/src/javaPackage/java/com/reactnativecommunity/asyncstorage/AsyncStoragePackage.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-document-picker/android/src/main/java/com/reactnativedocumentpicker/RNDocumentPickerModule.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Note: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-image-picker/android/src/main/java/com/imagepicker/Utils.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-localize/android/src/main/java/com/zoontek/rnlocalize/RNLocalizeModuleImpl.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-permissions/android/src/main/java/com/zoontek/rnpermissions/RNPermissionsPackage.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Note: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-svg/android/src/main/java/com/horcrux/svg/VirtualView.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: /Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/node_modules/react-native-video/android/src/main/java/com/brentvatne/react/ReactVideoViewManager.java uses unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':app:mergeReleaseResources'.
> A failure occurred while executing com.android.build.gradle.internal.res.Aapt2CompileRunnable
> Android resource compilation failed
ERROR:/Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/android/app/build/generated/res/createBundleReleaseJsAndAssets/drawable-mdpi/src_assets_icon.png: AAPT: error: file failed to compile.
* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
* Get more help at https://help.gradle.org
BUILD FAILED in 1m 34s
error Failed to install the app.
info Run CLI with --verbose flag for more details.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Just tried with the latest version (0.72.5)
You have a problem with this file:
ERROR:/Users/quentindrappier/Documents/Clients/Moderato2/moderato_mobile/android/app/build/generated/res/createBundleReleaseJsAndAssets/drawable-mdpi/src_assets_icon.png: AAPT: error: file failed to compile.
Could you share that file in particular?
Also can you provide a reproducer as suggested by the bot?
The file :
src_assets_icon.png.zip
Here is the image, and can you explain to me what you mean by 'a reproducer' ?
src_assets_icon.png.zip
Here is the image but even when the default icons the issue still the same.
And can you explain to me what you mean by 'a reproducer' ?
The issue is with this icon:
$ file ./src_assets_icon.png
./src_assets_icon.png: JPEG image data, JFIF standard 1.01, aspect ratio, density 1x1, segment length 16, progressive, precision 8, 200x200, components 3
The file is saved as .png but it's in reality a .jpg file. You need to use an image convertion tool to properly convert it to PNG.
Closing as this is not related to React Native
i have the same problem but i optimise all png files but it shows the same error
//This is the error
gokul@Gokul MINGW64 /e/Web development/js/Nodejs/React Native/Tieoda/android (main)
$ ./gradlew assembleRelease
Starting a Gradle Daemon, 5 stopped Daemons could not be reused, use --status for details
Configure project :react-native-reanimated
Android gradle plugin: 8.2.1
Gradle: 8.6
Task :app:mergeReleaseResources FAILED
FAILURE: Build failed with an exception.
What went wrong:
Execution failed for task ':app:mergeReleaseResources'.
Multiple task action failures occurred:
A failure occurred while executing com.android.build.gradle.internal.res.Aapt2CompileRunnable
Android resource compilation failed
ERROR: AAPT: com.tieoda.app-res-30:/drawable-mdpi/assets_images_dummy_profiles_profilepic2.png: error: failed to read PNG signature: file does not start with PNG signature.
E:\Web development\js\Nodejs\React Native\Tieoda\android\app\build\generated\res\createBundleReleaseJsAndAssets\drawable-mdpi\assets_images_dummy_profiles_profilepic2.png: error: file failed to compile.
A failure occurred while executing com.android.build.gradle.internal.res.Aapt2CompileRunnable
Android resource compilation failed
ERROR: AAPT: com.tieoda.app-res-30:/drawable-mdpi/assets_images_dummy_profiles_profilepic10.png: error: failed to read PNG signature: file does not start with PNG signature.
E:\Web development\js\Nodejs\React Native\Tieoda\android\app\build\generated\res\createBundleReleaseJsAndAssets\drawable-mdpi\assets_images_dummy_profiles_profilepic10.png: error: file failed to compile.
A failure occurred while executing com.android.build.gradle.internal.res.Aapt2CompileRunnable
Android resource compilation failed
ERROR: AAPT: com.tieoda.app-res-30:/drawable-mdpi/assets_images_recipes_spagetti.png: error: failed to read PNG signature: file does not start with PNG signature.
E:\Web development\js\Nodejs\React Native\Tieoda\android\app\build\generated\res\createBundleReleaseJsAndAssets\drawable-mdpi\assets_images_recipes_spagetti.png: error: file failed to compile.
A failure occurred while executing com.android.build.gradle.internal.res.Aapt2CompileRunnable
Android resource compilation failed
ERROR: AAPT: com.tieoda.app-res-30:/drawable-mdpi/assets_images_recipes_satay.png: error: failed to read PNG signature: file does not start with PNG signature.
E:\Web development\js\Nodejs\React Native\Tieoda\android\app\build\generated\res\createBundleReleaseJsAndAssets\drawable-mdpi\assets_images_recipes_satay.png: error: file failed to compile.
A failure occurred while executing com.android.build.gradle.internal.res.Aapt2CompileRunnable
Android resource compilation failed
ERROR: AAPT: com.tieoda.app-res-30:/drawable-mdpi/assets_images_dummy_profiles_profilepic6.png: error: failed to read PNG signature: file does not start with PNG signature.
E:\Web development\js\Nodejs\React Native\Tieoda\android\app\build\generated\res\createBundleReleaseJsAndAssets\drawable-mdpi\assets_images_dummy_profiles_profilepic6.png: error: file failed to compile.
A failure occurred while executing com.android.build.gradle.internal.res.Aapt2CompileRunnable
Android resource compilation failed
ERROR: AAPT: com.tieoda.app-res-30:/drawable-mdpi/assets_images_dummy_profiles_profile.png: error: failed to read PNG signature: file does not start with PNG signature.
E:\Web development\js\Nodejs\React Native\Tieoda\android\app\build\generated\res\createBundleReleaseJsAndAssets\drawable-mdpi\assets_images_dummy_profiles_profile.png: error: file failed to compile.
A failure occurred while executing com.android.build.gradle.internal.res.Aapt2CompileRunnable
Android resource compilation failed
ERROR: AAPT: com.tieoda.app-res-30:/drawable-mdpi/assets_images_recipes_laksa.png: error: failed to read PNG signature: file does not start with PNG signature.
E:\Web development\js\Nodejs\React Native\Tieoda\android\app\build\generated\res\createBundleReleaseJsAndAssets\drawable-mdpi\assets_images_recipes_laksa.png: error: file failed to compile.
A failure occurred while executing com.android.build.gradle.internal.res.Aapt2CompileRunnable
Android resource compilation failed
ERROR: AAPT: com.tieoda.app-res-30:/drawable-mdpi/assets_images_system_loginbackground.png: error: failed to read PNG signature: file does not start with PNG signature.
E:\Web development\js\Nodejs\React Native\Tieoda\android\app\build\generated\res\createBundleReleaseJsAndAssets\drawable-mdpi\assets_images_system_loginbackground.png: error: file failed to compile.
Try:
Run with --stacktrace option to get the stack trace.
Run with --info or --debug option to get more log output.
Run with --scan to get full insights.
Get more help at https://help.gradle.org.
Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.
You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.
For more on this, please refer to https://docs.gradle.org/8.6/userguide/command_line_interface.html#sec:command_line_warnings in the Gradle documentation.
BUILD FAILED in 31s
147 actionable tasks: 28 executed, 119 up-to-date
now what i need to do
now what i need to do
i have same issue, any news for this issue?
now what i need to do
i tried to open the image on photoshop and save it with png again. and it worked. You can try this.
@Gokul0616 @DoHue97
To fix that issue, I had to import every asset I used in Figma and export them as PNGs. Then, I replaced the old files with the newly downloaded ones from Figma.
FIX
The issue was resolved by changing the file format to JPEG. Although the image was saved as a PNG, it showed as JPEG when opened in an editor. Renaming the file format fixed the problem.
Reason for the Error
The error occurred because appicon.co generated .png icon files from a JPEG input, causing a file format mismatch.
| gharchive/issue | 2023-09-26T09:12:36 | 2025-04-01T06:44:08.081782 | {
"authors": [
"DRAPPIERQ",
"DoHue97",
"Gokul0616",
"cortinico",
"jashwanth0712"
],
"repo": "facebook/react-native",
"url": "https://github.com/facebook/react-native/issues/39650",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
2727915376 | App is crashing after install in new architecture.
Description
My app functions correctly with the debug APK, but it crashes immediately after installation when using the release APK.
Steps to reproduce
Install the apk.
App opens up
App crashes
React Native Version
0.76.0
Affected Platforms
Runtime - iOS
Areas
TurboModule - The New Native Module System
Output of npx react-native info
npx react-native info
info Fetching system and libraries information...
System:
OS: macOS 15.1
CPU: (8) arm64 Apple M1
Memory: 146.39 MB / 8.00 GB
Shell:
version: "5.9"
path: /bin/zsh
Binaries:
Node:
version: 20.14.0
path: ~/.nvm/versions/node/v20.14.0/bin/node
Yarn:
version: 3.6.4
path: /opt/homebrew/bin/yarn
npm:
version: 6.14.18
path: ~/node_modules/.bin/npm
Watchman: Not Found
Managers:
CocoaPods:
version: 1.15.2
path: /opt/homebrew/bin/pod
SDKs:
iOS SDK:
Platforms:
- DriverKit 24.1
- iOS 18.1
- macOS 15.1
- tvOS 18.1
- visionOS 2.1
- watchOS 11.1
Android SDK: Not Found
IDEs:
Android Studio: 2024.2 AI-242.23339.11.2421.12550806
Xcode:
version: 16.1/16B40
path: /usr/bin/xcodebuild
Languages:
Java:
version: 17.0.9
path: /usr/bin/javac
Ruby:
version: 2.6.10
path: /usr/bin/ruby
npmPackages:
"@react-native-community/cli":
installed: 15.0.0-alpha.2
wanted: 15.0.0-alpha.2
react:
installed: 18.3.1
wanted: 18.3.1
react-native:
installed: 0.76.0
wanted: 0.76.0
react-native-macos: Not Found
npmGlobalPackages:
"*react-native*": Not Found
Android:
hermesEnabled: true
newArchEnabled: false
iOS:
hermesEnabled: false
newArchEnabled: true
Stacktrace or Logs
Thread 6 name: Dispatch queue: com.meta.react.turbomodulemanager.queue
Thread 6 Crashed:
0 libsystem_kernel.dylib 0x1bbe4bbbc __pthread_kill + 8
1 libsystem_pthread.dylib 0x1dc8ec844 pthread_kill + 207
2 libsystem_c.dylib 0x18bc546ac abort + 123
3 libc++abi.dylib 0x198e8fde4 abort_message + 127
4 libc++abi.dylib 0x198e8066c demangling_terminate_handler() + 275
5 libobjc.A.dylib 0x198d9d908 _objc_terminate() + 139
6 libc++abi.dylib 0x198e8f280 std::__terminate(void (*)()) + 15
7 libc++abi.dylib 0x198e8f228 std::terminate() + 59
8 libdispatch.dylib 0x1812280a8 _dispatch_client_callout + 35
9 libdispatch.dylib 0x1811ce73c _dispatch_lane_serial_drain$VARIANT$mp + 643
10 libdispatch.dylib 0x1811cf1f4 _dispatch_lane_invoke$VARIANT$mp + 407
11 libdispatch.dylib 0x1811d8ec8 _dispatch_workloop_worker_thread + 631
12 libsystem_pthread.dylib 0x1dc8e0e00 _pthread_wqthread + 283
13 libsystem_pthread.dylib 0x1dc8e092c start_wqthread + 7
Thread 7:
0 libsystem_pthread.dylib 0x1dc8e0924 start_wqthread + 0
Thread 8:
0 libsystem_pthread.dylib 0x1dc8e0924 start_wqthread + 0
Thread 9 name: com.facebook.react.runtime.JavaScript
Thread 9:
0 libsystem_kernel.dylib 0x1bbe45aac mach_msg_trap + 8
1 libsystem_kernel.dylib 0x1bbe4607c mach_msg + 71
2 CoreFoundation 0x1814dbc88 __CFRunLoopServiceMachPort + 367
3 CoreFoundation 0x1814dff90 __CFRunLoopRun + 1159
4 CoreFoundation 0x1814f3174 CFRunLoopRunSpecific + 571
5 tgi_connect_app 0x1049716f8 0x104560000 + 4265720
6 Foundation 0x182c4cbdc __NSThread__start__ + 791
7 libsystem_pthread.dylib 0x1dc8e2338 _pthread_start + 115
8 libsystem_pthread.dylib 0x1dc8e0938 thread_start + 7
Thread 10 name: JavaScriptCore libpas scavenger
Thread 10:
0 libsystem_kernel.dylib 0x1bbe46484 __psynch_cvwait + 8
1 libsystem_pthread.dylib 0x1dc8e8bc4 _pthread_cond_wait$VARIANT$mp + 1239
2 JavaScriptCore 0x18bde90c8 scavenger_thread_main + 1119
3 libsystem_pthread.dylib 0x1dc8e2338 _pthread_start + 115
4 libsystem_pthread.dylib 0x1dc8e0938 thread_start + 7
Thread 11 name: Heap Helper Thread
Thread 11:
0 libsystem_kernel.dylib 0x1bbe46484 __psynch_cvwait + 8
1 libsystem_pthread.dylib 0x1dc8e8bc4 _pthread_cond_wait$VARIANT$mp + 1239
2 JavaScriptCore 0x18bd4d8a4 WTF::ParkingLot::parkConditionallyImpl(void const*, WTF::ScopedLambda<bool ()> const&, WTF::ScopedLambda<void ()> const&, WTF::TimeWithDynamicClockType const&) + 1983
3 JavaScriptCore 0x18bd1572c bool WTF::Condition::waitUntilUnchecked<WTF::Lock>(WTF::Lock&, WTF::TimeWithDynamicClockType const&) + 175
4 JavaScriptCore 0x18bd15b7c WTF::Detail::CallableWrapper<WTF::AutomaticThread::start(WTF::AbstractLocker const&)::$_0, void>::call() + 327
5 JavaScriptCore 0x18bd6d914 WTF::Thread::entryPoint(WTF::Thread::NewThreadContext*) + 335
6 JavaScriptCore 0x18bd6fbec WTF::wtfThreadEntryPoint(void*) + 11
7 libsystem_pthread.dylib 0x1dc8e2338 _pthread_start + 115
8 libsystem_pthread.dylib 0x1dc8e0938 thread_start + 7
Thread 12 name: com.apple.CoreMotion.MotionThread
Thread 12:
0 libsystem_kernel.dylib 0x1bbe45aac mach_msg_trap + 8
1 libsystem_kernel.dylib 0x1bbe4607c mach_msg + 71
2 CoreFoundation 0x1814dbc88 __CFRunLoopServiceMachPort + 367
3 CoreFoundation 0x1814dff90 __CFRunLoopRun + 1159
4 CoreFoundation 0x1814f3174 CFRunLoopRunSpecific + 571
5 CoreFoundation 0x18156e320 CFRunLoopRun + 59
6 CoreMotion 0x18ddc4ab0 0x18ddc4575 + 1339
7 libsystem_pthread.dylib 0x1dc8e2338 _pthread_start + 115
8 libsystem_pthread.dylib 0x1dc8e0938 thread_start + 7
Thread 13 name: com.apple.NSURLConnectionLoader
Thread 13:
0 libsystem_kernel.dylib 0x1bbe45aac mach_msg_trap + 8
1 libsystem_kernel.dylib 0x1bbe4607c mach_msg + 71
2 CoreFoundation 0x1814dbc88 __CFRunLoopServiceMachPort + 367
3 CoreFoundation 0x1814dff90 __CFRunLoopRun + 1159
4 CoreFoundation 0x1814f3174 CFRunLoopRunSpecific + 571
5 CFNetwork 0x181ef7b9c 0x181ef79f1 + 427
6 Foundation 0x182c4cbdc __NSThread__start__ + 791
7 libsystem_pthread.dylib 0x1dc8e2338 _pthread_start + 115
8 libsystem_pthread.dylib 0x1dc8e0938 thread_start + 7
Thread 14 name: JSC Heap Collector Thread
Thread 14:
0 libsystem_kernel.dylib 0x1bbe46484 __psynch_cvwait + 8
1 libsystem_pthread.dylib 0x1dc8e8bc4 _pthread_cond_wait$VARIANT$mp + 1239
2 JavaScriptCore 0x18bd4d8a4 WTF::ParkingLot::parkConditionallyImpl(void const*, WTF::ScopedLambda<bool ()> const&, WTF::ScopedLambda<void ()> const&, WTF::TimeWithDynamicClockType const&) + 1983
3 JavaScriptCore 0x18bd1572c bool WTF::Condition::waitUntilUnchecked<WTF::Lock>(WTF::Lock&, WTF::TimeWithDynamicClockType const&) + 175
4 JavaScriptCore 0x18bd15b7c WTF::Detail::CallableWrapper<WTF::AutomaticThread::start(WTF::AbstractLocker const&)::$_0, void>::call() + 327
5 JavaScriptCore 0x18bd6d914 WTF::Thread::entryPoint(WTF::Thread::NewThreadContext*) + 335
6 JavaScriptCore 0x18bd6fbec WTF::wtfThreadEntryPoint(void*) + 11
7 libsystem_pthread.dylib 0x1dc8e2338 _pthread_start + 115
8 libsystem_pthread.dylib 0x1dc8e0938 thread_start + 7
Thread 6 crashed with ARM Thread State (64-bit):
x0: 0x0000000000000000 x1: 0x0000000000000000 x2: 0x0000000000000000 x3: 0x0000000000000000
x4: 0xfffffffffffffcfc x5: 0x000000000000001c x6: 0x0000000000000020 x7: 0x0000000117e10ab8
x8: 0x000000016bbe3000 x9: 0xe20cac8c1a0ab410 x10: 0x35403e6e776f6e6b x11: 0x0a30323835323a36
x12: 0x6e6b6e753c0a3836 x13: 0x3a3635403e6e776f x14: 0x0000000000000010 x15: 0x6b63617473206f6e
x16: 0x0000000000000148 x17: 0x000000004ea00000 x18: 0x0000000000000000 x19: 0x0000000000000006
x20: 0x0000000000004803 x21: 0x000000016bbe30e0 x22: 0x000000016bbe30e0 x23: 0x00000002808a37b0
x24: 0x0000000000000000 x25: 0x0000000000000114 x26: 0x0000000000000000 x27: 0x0000000000000000
x28: 0x00000002833856c0 fp: 0x000000016bbe2390 lr: 0x00000001dc8ec844
sp: 0x000000016bbe2370 pc: 0x00000001bbe4bbbc cpsr: 0x40000000
far: 0x00000001f78274f8 esr: 0x56000080 Address size fault
Binary Images:
0x1bbe45000 - 0x1bbe78fff libsystem_kernel.dylib arm64 <102e8613667633f6a0b4f6e86a8636ce> /usr/lib/system/libsystem_kernel.dylib
0x1814d5000 - 0x181912fff CoreFoundation arm64 <eec1287d059b38c89bc158a0c8b1e6c2> /System/Library/Frameworks/CoreFoundation.framework/CoreFoundation
0x1a2031000 - 0x1a2039fff GraphicsServices arm64 <bb434d860991365fbed3c3923cf3073c> /System/Library/PrivateFrameworks/GraphicsServices.framework/GraphicsServices
0x183810000 - 0x184fabfff UIKitCore arm64 <9d3018772593385c8f72f075aa0b48fa> /System/Library/PrivateFrameworks/UIKitCore.framework/UIKitCore
0x104560000 - 0x10549bfff tgi_connect_app arm64 <2b7307d621a53ed3a83f40bfda492127> /private/var/containers/Bundle/Application/F4218DFE-21F6-4998-8806-6C8A6C68F036/tgi_connect_app.app/tgi_connect_app
0x105d20000 - 0x105d73fff dyld arm64 <16c8ea1a1c773f4f97a66ae7fb25eb29> /usr/lib/dyld
0x1dc8fe000 - 0x1dc936fff libxpc.dylib arm64 <184a84ec2aaa3c9780d3d7584a851a54> /usr/lib/system/libxpc.dylib
0x182141000 - 0x182b70fff libnetwork.dylib arm64 <7964abafcb993527a2f9ebd13dca3696> /usr/lib/libnetwork.dylib
0x1db904000 - 0x1db90cfff libdns_services.dylib arm64 <4670b424b84e3c7f8ddc8760dd5b56d7> /usr/lib/libdns_services.dylib
0x1811c4000 - 0x181246fff libdispatch.dylib arm64 <9ccdbde315e13a45b3304a5e2c3f92bd> /usr/lib/system/libdispatch.dylib
0x1dc8df000 - 0x1dc8effff libsystem_pthread.dylib arm64 <6679a5b3a40a37a7b1c5565a0f5cb6ab> /usr/lib/system/libsystem_pthread.dylib
0x182be8000 - 0x182eccfff Foundation arm64 <f9235fc7ec4e31c9b56e95cf10b07239> /System/Library/Frameworks/Foundation.framework/Foundation
0x18bc35000 - 0x18bcb0fff libsystem_c.dylib arm64 <f90936ac0df438aeb3ea2cd6e5f97e64> /usr/lib/system/libsystem_c.dylib
0x198e7f000 - 0x198e95fff libc++abi.dylib arm64 <f92ef016d0cd31829fc01ec48f372556> /usr/lib/libc++abi.dylib
0x198d83000 - 0x198dbafff libobjc.A.dylib arm64 <f1b36686ed4835ef88960cea8e9da1c0> /usr/lib/libobjc.A.dylib
0x18bd04000 - 0x18d08cfff JavaScriptCore arm64 <bc6e1e32a3813879b669436b95ee1614> /System/Library/Frameworks/JavaScriptCore.framework/JavaScriptCore
0x18ddb2000 - 0x18e0a9fff CoreMotion arm64 <06b9c1cbe6b2363d8d4c523700487be7> /System/Library/Frameworks/CoreMotion.framework/CoreMotion
0x181cb1000 - 0x182140fff CFNetwork arm64 <db182cd7f43339ad9531e81430e96a77> /System/Library/Frameworks/CFNetwork.framework/CFNetwork
EOF
Reproducer
can't share
Screenshots and Videos
No response
Date/Time: 2024-12-09 22:44:34.3729 +0530
Launch Time: 2024-12-09 20:03:47.5076 +0530
OS Version: iPhone OS 15.8.2 (19H384)
Release Type: User
Baseband Version: 6.03.01
Report Version: 104
Exception Type: EXC_CRASH (SIGABRT)
Exception Codes: 0x0000000000000000, 0x0000000000000000
Exception Note: EXC_CORPSE_NOTIFY
Triggered by Thread: 2
Application Specific Information:
abort() called
Thread 0 name: Dispatch queue: com.apple.main-thread
Thread 0:
0 libsystem_kernel.dylib 0x1bbe45aac mach_msg_trap + 8
1 libsystem_kernel.dylib 0x1bbe4607c mach_msg + 71
2 CoreFoundation 0x1814dbc88 __CFRunLoopServiceMachPort + 367
3 CoreFoundation 0x1814dff90 __CFRunLoopRun + 1159
4 CoreFoundation 0x1814f3174 CFRunLoopRunSpecific + 571
5 GraphicsServices 0x1a2032988 GSEventRunModal + 159
6 UIKitCore 0x183cf5a88 -[UIApplication _run] + 1079
7 UIKitCore 0x183a8ef78 UIApplicationMain + 335
8 tgi_connect_app 0x100d901cc 0x100d8c000 + 16844
9 dyld 0x1024984d0 start + 443
Thread 1:
0 libsystem_pthread.dylib 0x1dc8e0924 start_wqthread + 0
Thread 2 name: Dispatch queue: com.meta.react.turbomodulemanager.queue
Thread 2 Crashed:
0 libsystem_kernel.dylib 0x1bbe4bbbc __pthread_kill + 8
1 libsystem_pthread.dylib 0x1dc8ec844 pthread_kill + 207
2 libsystem_c.dylib 0x18bc546ac abort + 123
3 libc++abi.dylib 0x198e8fde4 abort_message + 127
4 libc++abi.dylib 0x198e8066c demangling_terminate_handler() + 275
5 libobjc.A.dylib 0x198d9d908 _objc_terminate() + 139
6 libc++abi.dylib 0x198e8f280 std::__terminate(void (*)()) + 15
7 libc++abi.dylib 0x198e8f228 std::terminate() + 59
8 libdispatch.dylib 0x1812280a8 _dispatch_client_callout + 35
9 libdispatch.dylib 0x1811ce73c _dispatch_lane_serial_drain$VARIANT$mp + 643
10 libdispatch.dylib 0x1811cf1f4 _dispatch_lane_invoke$VARIANT$mp + 407
11 libdispatch.dylib 0x1811d8ec8 _dispatch_workloop_worker_thread + 631
12 libsystem_pthread.dylib 0x1dc8e0e00 _pthread_wqthread + 283
13 libsystem_pthread.dylib 0x1dc8e092c start_wqthread + 7
Thread 3:
0 libsystem_pthread.dylib 0x1dc8e0924 start_wqthread + 0
Thread 4 name: com.apple.uikit.eventfetch-thread
Thread 4:
0 libsystem_kernel.dylib 0x1bbe45aac mach_msg_trap + 8
1 libsystem_kernel.dylib 0x1bbe4607c mach_msg + 71
2 CoreFoundation 0x1814dbc88 __CFRunLoopServiceMachPort + 367
3 CoreFoundation 0x1814dff90 __CFRunLoopRun + 1159
4 CoreFoundation 0x1814f3174 CFRunLoopRunSpecific + 571
5 Foundation 0x182bffeac -[NSRunLoop(NSRunLoop) runMode:beforeDate:] + 231
6 Foundation 0x182c3efd0 -[NSRunLoop(NSRunLoop) runUntilDate:] + 87
7 UIKitCore 0x183c74ef4 -[UIEventFetcher threadMain] + 511
8 Foundation 0x182c4cbdc NSThread__start + 791
9 libsystem_pthread.dylib 0x1dc8e2338 _pthread_start + 115
10 libsystem_pthread.dylib 0x1dc8e0938 thread_start + 7
Thread 5:
0 libsystem_pthread.dylib 0x1dc8e0924 start_wqthread + 0
Thread 6:
0 libsystem_pthread.dylib 0x1dc8e0924 start_wqthread + 0
Thread 7:
0 libsystem_pthread.dylib 0x1dc8e0924 start_wqthread + 0
Thread 8 name: com.facebook.react.runtime.JavaScript
Thread 8:
0 libsystem_kernel.dylib 0x1bbe45aac mach_msg_trap + 8
1 libsystem_kernel.dylib 0x1bbe4607c mach_msg + 71
2 CoreFoundation 0x1814dbc88 __CFRunLoopServiceMachPort + 367
3 CoreFoundation 0x1814dff90 __CFRunLoopRun + 1159
4 CoreFoundation 0x1814f3174 CFRunLoopRunSpecific + 571
5 tgi_connect_app 0x10119d6f8 0x100d8c000 + 4265720
6 Foundation 0x182c4cbdc NSThread__start + 791
7 libsystem_pthread.dylib 0x1dc8e2338 _pthread_start + 115
8 libsystem_pthread.dylib 0x1dc8e0938 thread_start + 7
Thread 9 name: JavaScriptCore libpas scavenger
Thread 9:
0 libsystem_kernel.dylib 0x1bbe46484 __psynch_cvwait + 8
1 libsystem_pthread.dylib 0x1dc8e8bc4 _pthread_cond_wait$VARIANT$mp + 1239
2 JavaScriptCore 0x18bde90c8 scavenger_thread_main + 1119
3 libsystem_pthread.dylib 0x1dc8e2338 _pthread_start + 115
4 libsystem_pthread.dylib 0x1dc8e0938 thread_start + 7
Thread 10:
0 libsystem_pthread.dylib 0x1dc8e0924 start_wqthread + 0
Thread 11 name: Heap Helper Thread
Thread 11:
0 libsystem_kernel.dylib 0x1bbe46484 __psynch_cvwait + 8
1 libsystem_pthread.dylib 0x1dc8e8bc4 _pthread_cond_wait$VARIANT$mp + 1239
2 JavaScriptCore 0x18bd4d8a4 WTF::ParkingLot::parkConditionallyImpl(void const*, WTF::ScopedLambda<bool ()> const&, WTF::ScopedLambda<void ()> const&, WTF::TimeWithDynamicClockType const&) + 1983
3 JavaScriptCore 0x18bd1572c bool WTF::Condition::waitUntilUncheckedWTF::Lock(WTF::Lock&, WTF::TimeWithDynamicClockType const&) + 175
4 JavaScriptCore 0x18bd15b7c WTF::Detail::CallableWrapper<WTF::AutomaticThread::start(WTF::AbstractLocker const&)::$_0, void>::call() + 327
5 JavaScriptCore 0x18bd6d914 WTF::Thread::entryPoint(WTF::Thread::NewThreadContext*) + 335
6 JavaScriptCore 0x18bd6fbec WTF::wtfThreadEntryPoint(void*) + 11
7 libsystem_pthread.dylib 0x1dc8e2338 _pthread_start + 115
8 libsystem_pthread.dylib 0x1dc8e0938 thread_start + 7
Thread 12 name: com.apple.CoreMotion.MotionThread
Thread 12:
0 libsystem_kernel.dylib 0x1bbe45aac mach_msg_trap + 8
1 libsystem_kernel.dylib 0x1bbe4607c mach_msg + 71
2 CoreFoundation 0x1814dbc88 __CFRunLoopServiceMachPort + 367
3 CoreFoundation 0x1814dff90 __CFRunLoopRun + 1159
4 CoreFoundation 0x1814f3174 CFRunLoopRunSpecific + 571
5 CoreFoundation 0x18156e320 CFRunLoopRun + 59
6 CoreMotion 0x18ddc4ab0 0x18ddc4575 + 1339
7 libsystem_pthread.dylib 0x1dc8e2338 _pthread_start + 115
8 libsystem_pthread.dylib 0x1dc8e0938 thread_start + 7
Thread 13 name: com.apple.NSURLConnectionLoader
Thread 13:
0 libsystem_kernel.dylib 0x1bbe45aac mach_msg_trap + 8
1 libsystem_kernel.dylib 0x1bbe4607c mach_msg + 71
2 CoreFoundation 0x1814dbc88 __CFRunLoopServiceMachPort + 367
3 CoreFoundation 0x1814dff90 __CFRunLoopRun + 1159
4 CoreFoundation 0x1814f3174 CFRunLoopRunSpecific + 571
5 CFNetwork 0x181ef7b9c 0x181ef79f1 + 427
6 Foundation 0x182c4cbdc NSThread__start + 791
7 libsystem_pthread.dylib 0x1dc8e2338 _pthread_start + 115
8 libsystem_pthread.dylib 0x1dc8e0938 thread_start + 7
Thread 14 name: JSC Heap Collector Thread
Thread 14:
0 libsystem_kernel.dylib 0x1bbe46484 __psynch_cvwait + 8
1 libsystem_pthread.dylib 0x1dc8e8bc4 _pthread_cond_wait$VARIANT$mp + 1239
2 JavaScriptCore 0x18bd4d8a4 WTF::ParkingLot::parkConditionallyImpl(void const*, WTF::ScopedLambda<bool ()> const&, WTF::ScopedLambda<void ()> const&, WTF::TimeWithDynamicClockType const&) + 1983
3 JavaScriptCore 0x18bd1572c bool WTF::Condition::waitUntilUncheckedWTF::Lock(WTF::Lock&, WTF::TimeWithDynamicClockType const&) + 175
4 JavaScriptCore 0x18bd15b7c WTF::Detail::CallableWrapper<WTF::AutomaticThread::start(WTF::AbstractLocker const&)::$_0, void>::call() + 327
5 JavaScriptCore 0x18bd6d914 WTF::Thread::entryPoint(WTF::Thread::NewThreadContext*) + 335
6 JavaScriptCore 0x18bd6fbec WTF::wtfThreadEntryPoint(void*) + 11
7 libsystem_pthread.dylib 0x1dc8e2338 _pthread_start + 115
8 libsystem_pthread.dylib 0x1dc8e0938 thread_start + 7
Thread 2 crashed with ARM Thread State (64-bit):
x0: 0x0000000000000000 x1: 0x0000000000000000 x2: 0x0000000000000000 x3: 0x0000000000000000
x4: 0x0000000000000acc x5: 0x000000000000000c x6: 0x0000000000000020 x7: 0x000000010273d518
x8: 0x000000016f187000 x9: 0xb6aed8ef67a83286 x10: 0x323a36354074500a x11: 0x6e753c0a38363734
x12: 0x6e6b6e753c0a3836 x13: 0x3a3635403e6e776f x14: 0x0000000000000010 x15: 0x6b63617473206f6e
x16: 0x0000000000000148 x17: 0x0000000025000000 x18: 0x0000000000000000 x19: 0x0000000000000006
x20: 0x0000000000001007 x21: 0x000000016f1870e0 x22: 0x000000016f1870e0 x23: 0x00000002801056b0
x24: 0x0000000000000000 x25: 0x0000000000000114 x26: 0x0000000283a37880 x27: 0x0000000000000000
x28: 0x0000000283a37880 fp: 0x000000016f186390 lr: 0x00000001dc8ec844
sp: 0x000000016f186370 pc: 0x00000001bbe4bbbc cpsr: 0x40000000
far: 0x00000001f78274f8 esr: 0x56000080 Address size fault
Binary Images:
0x1bbe45000 - 0x1bbe78fff libsystem_kernel.dylib arm64 <102e8613667633f6a0b4f6e86a8636ce> /usr/lib/system/libsystem_kernel.dylib
0x1814d5000 - 0x181912fff CoreFoundation arm64 /System/Library/Frameworks/CoreFoundation.framework/CoreFoundation
0x1a2031000 - 0x1a2039fff GraphicsServices arm64 /System/Library/PrivateFrameworks/GraphicsServices.framework/GraphicsServices
0x183810000 - 0x184fabfff UIKitCore arm64 <9d3018772593385c8f72f075aa0b48fa> /System/Library/PrivateFrameworks/UIKitCore.framework/UIKitCore
0x100d8c000 - 0x101cc7fff tgi_connect_app arm64 <2b7307d621a53ed3a83f40bfda492127> /private/var/containers/Bundle/Application/F4218DFE-21F6-4998-8806-6C8A6C68F036/tgi_connect_app.app/tgi_connect_app
0x102480000 - 0x1024d3fff dyld arm64 <16c8ea1a1c773f4f97a66ae7fb25eb29> /usr/lib/dyld
0x1dc8df000 - 0x1dc8effff libsystem_pthread.dylib arm64 <6679a5b3a40a37a7b1c5565a0f5cb6ab> /usr/lib/system/libsystem_pthread.dylib
0x18bc35000 - 0x18bcb0fff libsystem_c.dylib arm64 /usr/lib/system/libsystem_c.dylib
0x198e7f000 - 0x198e95fff libc++abi.dylib arm64 /usr/lib/libc++abi.dylib
0x198d83000 - 0x198dbafff libobjc.A.dylib arm64 /usr/lib/libobjc.A.dylib
0x1811c4000 - 0x181246fff libdispatch.dylib arm64 <9ccdbde315e13a45b3304a5e2c3f92bd> /usr/lib/system/libdispatch.dylib
0x182be8000 - 0x182eccfff Foundation arm64 /System/Library/Frameworks/Foundation.framework/Foundation
0x18bd04000 - 0x18d08cfff JavaScriptCore arm64 /System/Library/Frameworks/JavaScriptCore.framework/JavaScriptCore
0x18ddb2000 - 0x18e0a9fff CoreMotion arm64 <06b9c1cbe6b2363d8d4c523700487be7> /System/Library/Frameworks/CoreMotion.framework/CoreMotion
0x181cb1000 - 0x182140fff CFNetwork arm64 /System/Library/Frameworks/CFNetwork.framework/CFNetwork
EOF
still the same issue after updating to version 0.76.4
Hey @harish-aexonic, please share a minimal reproducer.
My app functions correctly with the debug APK, but it crashes immediately after installation when using the release APK.
You talk about APK but also this is from a iOS report:
OS Version: iPhone OS 15.8.2 (19H384)
Please provide more information as that's impossible to debug otherwise.
Also as @migueldaipre pointed out, we'll need a reproducer.
| gharchive/issue | 2024-12-09T18:24:02 | 2025-04-01T06:44:08.122308 | {
"authors": [
"cortinico",
"harish-aexonic",
"migueldaipre"
],
"repo": "facebook/react-native",
"url": "https://github.com/facebook/react-native/issues/48187",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
134708223 | Returning control of parent pan responder to a child.
I have a gallery type app that I am working on, but can't seem to get this last piece. I have a parent view that deals with moving through the images, and the image view that allows a user to pan around the image when zoomed in. If a user is at the edge on an image, the scrolling gesture will allow the next image to start coming in. This i can do fine, just passing control of the panresponder to the parent when the edge is hit. but i would like to let the user reverse this without having to life their finger. the user should be able to change their gesture direction, moving the new image back off the screen and allowing the image to be panned again. so effectively i need to pass the control of the panresponder back to the child. i cant seem to find a way to do this. once the child allows control to bubble up (by returning true from the onPanResponderTerminationRequest) it will never get access again until a new touch is initiated. is this possible?
Hey @wgormley, I'm not very familiar with the Pan Responder unfortunately but would like to ask a meta question:
I've added the Issue template and hoping it would make it clear it's best to ask on StackOverflow first before filing a bug on GitHub.
I'd like to ask: is that description clear enough? What did you think when you saw it? Was it too long for example?
@mkonicek probably should have posted it on stackoverflow first, just been in the habit of looking on github first with react native stuff. the description was good.
OK thank you @wgormley. I'll close this issue as it should be posted on StackOverflow.
| gharchive/issue | 2016-02-18T21:57:48 | 2025-04-01T06:44:08.126744 | {
"authors": [
"mkonicek",
"wgormley"
],
"repo": "facebook/react-native",
"url": "https://github.com/facebook/react-native/issues/6015",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
660118567 | Fix image cannot show in iOS 14
Summary
This PR is to fix https://github.com/facebook/react-native/issues/29279, which image cannot show in iOS 14
As https://github.com/facebook/react-native/issues/29279#issuecomment-658244428 mention, this issue can be fixed by calling [super displayLayer:layer]; it it is still image, to let UIImageView handle still image rendering
Changelog
[iOS] [Fixed] - Fix image cannot show in iOS 14
Test Plan
Image can be shown in iOS 14 build with Xcode 12 beta, using
<Image source={require('./images/some_local_image.jpg')}/>
It may also need to test gif image is render correctly
<Image source={{uri: 'https://some_remote_gif_image.gif'}}/>
Was this tested on iOS release mode? It doesn't seem to work for me
If image is not showing on your ios simulator or phone the best bet is to resolve it by upgrading the react-native version within your project
below are the steps to take
`
$ npx react-native upgrade 0.63.2
resolve merge conflicts
delete podlock.file in your ios folder
run below command
gem list --local | grep cocoapods
sudo gem uninstall (each item from above command)
sudo rm -rf ~/.cocoapods
sudo gem install cocoapods
cd (PROJECT DIRECTORY)
pod init
(put cocoapod in podfile)
pod install
rm -rf ~/.cocoapods/repos/trunk/
pod cache clean --all
pod install`
https://stackoverflow.com/a/60849495/7702345
I had the same issues this what I did https://github.com/facebook/react-native/pull/29420#issuecomment-707435412
Is there any plan to cherry pick this commit back into RN 0.62-stable ?
Was this tested on iOS release mode? It doesn't seem to work for me
same issue in release mode, any solution?
Thanks in advance.
If you get this error while taking the step (sudo gem install cocoapods): "You have to install development tools first".
Just run:
xcode-select --install
sudo xcode-select -s /Applications/Xcode.app/Contents/Developer
that worked for me.
Summary
This PR is to fix #29279, which image cannot show in iOS 14
As #29279 (comment) mention, this issue can be fixed by calling [super displayLayer:layer]; it it is still image, to let UIImageView handle still image rendering
Changelog
[iOS] [Fixed] - Fix image cannot show in iOS 14
Test Plan
Image can be shown in iOS 14 build with Xcode 12 beta, using
<Image source={require('./images/some_local_image.jpg')}/>
It may also need to test gif image is render correctly
<Image source={{uri: 'https://some_remote_gif_image.gif'}}/>
@tomcheung But that's exactly what I've got already on react-native/Libraries/Image/RCTUIImageViewAnimated.m (see below) and still not displaying images for device... :-(
(void)displayLayer:(CALayer *)layer
{
if (_currentFrame) {
layer.contentsScale = self.animatedImageScale;
layer.contents = (__bridge id)_currentFrame.CGImage;
} else {
[super displayLayer:layer];
}
}
Summary
This PR is to fix #29279, which image cannot show in iOS 14
As #29279 (comment) mention, this issue can be fixed by calling [super displayLayer:layer]; it it is still image, to let UIImageView handle still image rendering
Changelog
[iOS] [Fixed] - Fix image cannot show in iOS 14
Test Plan
Image can be shown in iOS 14 build with Xcode 12 beta, using
<Image source={require('./images/some_local_image.jpg')}/>
It may also need to test gif image is render correctly
<Image source={{uri: 'https://some_remote_gif_image.gif'}}/>
@tomcheung But that's exactly what I've got already on react-native/Libraries/Image/RCTUIImageViewAnimated.m (see below) and still not displaying images for device... :-(
(void)displayLayer:(CALayer *)layer
{
if (_currentFrame) {
layer.contentsScale = self.animatedImageScale;
layer.contents = (__bridge id)_currentFrame.CGImage;
} else {
[super displayLayer:layer];
}
}
same issue here on ios 15 and Xcode 12.5
I still have this issue...any solution? It passed two years
| gharchive/pull-request | 2020-07-18T12:21:55 | 2025-04-01T06:44:08.143278 | {
"authors": [
"Saadnajmi",
"cinder92",
"fredcoder",
"mateodaza",
"smanzini",
"tbanj",
"tomcheung",
"udaysagartammina",
"webdiego"
],
"repo": "facebook/react-native",
"url": "https://github.com/facebook/react-native/pull/29420",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
120060270 | [Babel] Support plugins that conform to ES6 modules
ES6 modules export an object with a property called default. See Babel itself for how this is handled: https://github.com/babel/babel/commit/b5b7e346a04c99da8793e2c65cc3b3c7c720253d
Test Plan: Used a Babel 6 plugin that is implemented as an ES6 module.
cc @martinbigio @tadeuzagallo for review
@facebook-github-bot shipit
This got stuck in Sandcastle (we need reporting!). Landing now :)
| gharchive/pull-request | 2015-12-02T23:34:15 | 2025-04-01T06:44:08.145601 | {
"authors": [
"ide",
"mkonicek",
"tadeuzagallo"
],
"repo": "facebook/react-native",
"url": "https://github.com/facebook/react-native/pull/4513",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
354152407 | feature request: binary pattern match shorthand
moved from https://github.com/BuckleScript/bucklescript/issues/3020
e.g. x matches {1 | 2 | 3}
Here is the function I had written when I realized I would like a syntax shorthand like this:
let isIntegral: float=>bool = f => f |. modf |. fun
| (0.0, _) => true
| _ => false;
Which could be rewritten as:
let isIntegral: float=>bool = f => modf(f) matches { (0.0, _) };
Plus if you want to parse complex binaries then things like https://github.com/nojb/bitstring-ppx should probably be used and refined instead (it really needs an update, I wonder if there are any forks...).
Closing this one for now, the added benefits don't outweigh the costs.
| gharchive/issue | 2018-08-27T01:48:45 | 2025-04-01T06:44:08.222415 | {
"authors": [
"IwanKaramazow",
"OvermindDL1",
"bobzhang"
],
"repo": "facebook/reason",
"url": "https://github.com/facebook/reason/issues/2161",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
2632808216 | Feature request: typing.Literal
Could we have PEP586 implemented in the type extension? I think that would be handy in a configuration language. There's enum, but that requires using the enum constructor. For me it would be nice to express that a certain argument expects something from a set of specific values, especially strings.
We don't currently have any plans to refine the type system to follow the latest Python type specification.
| gharchive/issue | 2024-11-04T13:22:33 | 2025-04-01T06:44:08.250263 | {
"authors": [
"ndmitchell",
"redsun82"
],
"repo": "facebook/starlark-rust",
"url": "https://github.com/facebook/starlark-rust/issues/134",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
159906931 | removed deprecated foursquare dependency. will perform tests and comm…
…it further if necessary
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!
| gharchive/pull-request | 2016-06-13T09:23:49 | 2025-04-01T06:44:08.253215 | {
"authors": [
"daniyal229",
"facebook-github-bot-7"
],
"repo": "facebookarchive/instagram-ruby-gem",
"url": "https://github.com/facebookarchive/instagram-ruby-gem/pull/209",
"license": "bsd-3-clause",
"license_type": "permissive",
"license_source": "bigquery"
} |
1066621710 | Official guide refers to x-fb-event_id but template expects event_id
The guide at https://developers.facebook.com/docs/marketing-api/conversions-api/guides/gtm-server-side refers to x-fb-event_id being the GA4 event parameter name but this line makes me think it should be just event_id:
https://github.com/facebookincubator/ConversionsAPI-Tag-for-GoogleTagManager/blob/57278940502aff341c06441a558545a63699c245/template.tpl#L172
For instance, with this GTM config:
I see this in the server side GTM debugger:
When I use x-fb-event_id as the param name in GTM, I don't see any event_id in the server side GTM debugger.
+1
+1
+1
| gharchive/issue | 2021-11-29T23:51:28 | 2025-04-01T06:44:08.257195 | {
"authors": [
"agustinv",
"ajosephjohnson",
"weotch",
"whycantidraw"
],
"repo": "facebookincubator/ConversionsAPI-Tag-for-GoogleTagManager",
"url": "https://github.com/facebookincubator/ConversionsAPI-Tag-for-GoogleTagManager/issues/26",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
613391237 | Feature: Policy on Mixins
Hi
Thanks for this awesome project. We are currently evaluating the Ent and would be happy to contribute some features which we would need and also think would be interesting for the community.
So here's our first one 😄
What would you think about putting Policy also onto Mixins? This would allow us to implement some default policies based on fields that come with a mixin.
We would be happy to bring up a PR for this.
Hey @stffabi and thanks for proposing this feature.
We actually discuss about it and we plan to add it to Mixin in the near future.
It's not there at the moment because the Query interface is currently empty and it's not possible to add generic code for mutating the different query builders.
Once we finish the development of entql (a generic query language for ent), the different query builders will share the same interface and it will be possible to add write policies. Then, we'll add this to the Mixin interface.
Also note that ent.Policy is exported but is not documented because it's WIP and considered experimental. We'll change its status to stable once we feel comfortable with its design and implementation and we'll add proper documentation and examples for it as well.
Hi @a8m thanks for your response.
Ah yes, that makes perfectly sense. There's no real win in having them added to Mixin without having entql. By the way entql sounds awesome 😄. I've also standup at some points because of a missing generic entql language. For e.g. to add additional predicates in a Mutator, for some sort of soft-delete mechanism.
I didn't think about it, because I've started some internal proof-of-concept where we generate Mixin based on the Schema Entities, e.g. CardOurFeatureMixin. We wanted to have a way to make some queries while in a Mutator but also needed this logic for several Entities not just one. And we didn't want to explicitly write this on every single Entity. So as a PoC we ended up generating Mixins which can then be added onto an Schema-Entity.
For Bootstrapping a project you need to generate twice, but this is e.g. also needed if you wanna use CardMutateFunc in an Schema-Entity.
Well not as generic as having just one Mixin, but it solved our problem quite well 😄 . And as an extension to such a Mixin we now needed some Policies for filtering Queries. Which would also work because the Mixins get generated.
For e.g. to add additional predicates in a Mutator, for some sort of soft-delete mechanism.
Exactly! that's one of the reason I decided to work on entql. Another reason is mentioned here - https://github.com/facebookincubator/ent/issues/277#issuecomment-622316098
The Policy option was added to Mixin. Please see entgo.io/docs/privacy for more information.
Thanks for proposing this!
| gharchive/issue | 2020-05-06T15:02:45 | 2025-04-01T06:44:08.265764 | {
"authors": [
"a8m",
"stffabi"
],
"repo": "facebookincubator/ent",
"url": "https://github.com/facebookincubator/ent/issues/465",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
1822576561 | : Field not found: row_field0. Available fields are: .
Bug description
Common eval wasn't supposed to throw, but it did. Aborting.
I20230726 12:56:55.968199 180023 ExpressionVerifier.cpp:344] Persisted input: --fuzzer_repro_path /tmp/fuzzer_repro/velox_expressionVerifier_t8MfzJ --input_path /tmp/fuzzer_repro/velox_expressionVerifier_t8MfzJ/input_vector --result_path /tmp/fuzzer_repro/velox_expressionVerifier_t8MfzJ/result_vector --sql_path /tmp/fuzzer_repro/velox_expressionVerifier_t8MfzJ/sql --lazy_column_list_path /tmp/fuzzer_repro/velox_expressionVerifier_t8MfzJ/indices_of_lazy_columns --complex_constant_path /tmp/fuzzer_repro/velox_expressionVerifier_t8MfzJ/complex_constants
terminate called after throwing an instance of 'facebook::velox::VeloxUserError'
what(): Exception: VeloxUserError
Error Source: USER
Error Code: INVALID_ARGUMENT
Reason: Field not found: row_field0. Available fields are: .
Retriable: False
Context: row_field0(switch(false:BOOLEAN, {true}:ROW<"":BOOLEAN>, true:BOOLEAN, switch(not(c2), {true}:ROW<"":BOOLEAN>, cast((switch(c3, c4)) as ROW<row_field0:BOOLEAN>)), true:BOOLEAN, subscript(switch(c2, 1 elements starting at 0 {0.8829143047332764 => {null}}:MAP<REAL,ROW<row_field0:BOOLEAN>>), negate(least(0.1744411289691925:REAL, c5, null:REAL))), array_max(c6), c7, regexp_like(Dp,J!MmI3;#>j8`,+(z+?q&6kfr4k/5_)hL`tIq0>,^.H0kvH*Myd9%(;\$;s|&1*t0%/aq$%{s$<s{v:VARCHAR, url_extract_query(chr(row_field0(coalesce(c8, c8, {8292452129667597201}:ROW<row_field0:BIGINT>, coalesce(null:ROW<row_field0:BIGINT>, c9, null:ROW<row_field0:BIGINT>, {null}:ROW<row_field0:BIGINT>), c8, {2408967779760174990}:ROW<row_field0:BIGINT>))))), cast((row_constructor(minus(c10, c11))) as ROW<row_field0:BOOLEAN>)))
Top-Level Context: try(switch(c1, {true}:ROW<"":BOOLEAN>, switch(row_field0(switch(false:BOOLEAN, {true}:ROW<"":BOOLEAN>, true:BOOLEAN, switch(not(c2), {true}:ROW<"":BOOLEAN>, cast((switch(c3, c4)) as ROW<row_field0:BOOLEAN>)), true:BOOLEAN, subscript(switch(c2, 1 elements starting at 0 {0.8829143047332764 => {null}}:MAP<REAL,ROW<row_field0:BOOLEAN>>), negate(least(0.1744411289691925:REAL, c5, null:REAL))), array_max(c6), c7, regexp_like(Dp,J!MmI3;#>j8`,+(z+?q&6kfr4k/5_)hL`tIq0>,^.H0kvH*Myd9%(;\$;s|&1*t0%/aq$%{s$<s{v:VARCHAR, url_extract_query(chr(row_field0(coalesce(c8, c8, {8292452129667597201}:ROW<row_field0:BIGINT>, coalesce(null:ROW<row_field0:BIGINT>, c9, null:ROW<row_field0:BIGINT>, {null}:ROW<row_field0:BIGINT>), c8, {2408967779760174990}:ROW<row_field0:BIGINT>))))), cast((row_constructor(minus(c10, c11))) as ROW<row_field0:BOOLEAN>))), {false}:ROW<"":BOOLEAN>, eq(array_max(c6), array_max(c6)), c12, c13, {true}:ROW<"":BOOLEAN>, null:ROW<"":BOOLEAN>)))
Function: getChildIdx
File: ../../velox/type/Type.cpp
Line: 367
Stack trace:
Stack trace has been disabled.Use --velox_exception_user_stacktrace=true to enable it.
System information
NA
Relevant logs
NA
(https://circleci.com/gh/facebookincubator/velox/187597)
another meta internal failure caught by this
(link will work for meta only employees
https://www.internalfb.com/intern/testinfra/diagnostics/2533274982325117.562950055970336.1690443898/
)
another meta internal failure, this one uses wide expressions and small nesting might be easier for debugging
https://www.internalfb.com/intern/testinfra/diagnostics/3659174885846795.562950055970332.1690455285/
Fix diff is up and expected
| gharchive/issue | 2023-07-26T14:41:29 | 2025-04-01T06:44:08.276997 | {
"authors": [
"laithsakka"
],
"repo": "facebookincubator/velox",
"url": "https://github.com/facebookincubator/velox/issues/5846",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
1852414536 | Add hamming_distance() Presto function
Add hamming_distance() Presto function
Resolves : https://github.com/prestodb/presto/issues/20531 , https://github.com/facebookincubator/velox/issues/6019, https://github.com/facebookincubator/velox/pull/909
Reference : https://github.com/prestodb/presto/blob/master/presto-main/src/main/java/com/facebook/presto/operator/scalar/StringFunctions.java#L802
@aditi-pandit Can you take another look at this PR?
@arundpanicker : The fuzzer run above shows an error in hamming_distance function. Please can you fix it.
| gharchive/pull-request | 2023-08-16T02:42:54 | 2025-04-01T06:44:08.279786 | {
"authors": [
"aditi-pandit",
"arundpanicker",
"yzhang1991"
],
"repo": "facebookincubator/velox",
"url": "https://github.com/facebookincubator/velox/pull/6120",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
1723340255 | CentOS 7 AttributeError: GLFWError: (65543) b'GLX: Failed to create context: Badlength'
os： CentOS Linux release 7.9.2009 (Core)
log in to the server without display remotely using ssh
remote tool to show: Xmanager
I meet erro
CentOS isn't a supported OS and I haven't encountered this error before. If you do manage to fix it, please share your workaround here.
How about to try "Export MP4 video" instead of "Quick Start"?
from animated_drawings import render
render.start('./examples/config/mvc/export_mp4_example.yaml')
It might kinda hard to use window in ssh environment.
And also you might have to convert the code USE_MESA: True in ./animated_drawings/mvc_base_cfg.yaml.
| gharchive/issue | 2023-05-24T07:18:30 | 2025-04-01T06:44:08.282749 | {
"authors": [
"ADingDing",
"hjessmith",
"kheedogg"
],
"repo": "facebookresearch/AnimatedDrawings",
"url": "https://github.com/facebookresearch/AnimatedDrawings/issues/174",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
998523621 | ModuleNotFoundError: No module named 'monodepth.mannequin_challenge'
When trying to run this "python main.py --video_file data/videos/ayush.mp4 --path results/ayush
--camera_params "1671.770118, 540, 960" --camera_model "SIMPLE_PINHOLE"
--make_video" , I am encountering the following error as shown in the image below .
I had the same issue,
check that you cloned the sub modules as well:
git submodule update --init --recursive
I have the same problem. Have you worked it out?
| gharchive/issue | 2021-09-16T18:48:20 | 2025-04-01T06:44:08.309215 | {
"authors": [
"aharonamir",
"leilei-fu",
"vishnuvardhan58"
],
"repo": "facebookresearch/consistent_depth",
"url": "https://github.com/facebookresearch/consistent_depth/issues/52",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
825001955 | set_weights has some numerical instability around zero values
Hi @awni!
I followed a similar implementation to the TransducerLossFunction in gtn_applications. I'm wondering whether you also experienced some instability when using these lines:
cpu_data = transition_params.cpu().contiguous()
transitions.set_weights(cpu_data.data_ptr())
I experienced this problem where a zero value in a tensor could become a very large, very small, or even nan value after passing through the cycle of gpu_tensor-->cpu_tensor-->gtn-->numpy.
I reproduced this behavior here: https://colab.research.google.com/drive/1AuZJlukSEwadrH6cokrqEjABBWuHJ8wQ?usp=sharing
For example, two of my zero values in a GPU tensor shifted while the remaining did not. And this does not happen if the tensor is only on CPU.
Do you have any suggestions on how to prevent this?
Copying @siddalmia @sw005320 as well.
Wow! That is not at all what I was expecting to be the issue. Thanks for the fast response!
| gharchive/issue | 2021-03-08T22:10:54 | 2025-04-01T06:44:08.338968 | {
"authors": [
"brianyan918"
],
"repo": "facebookresearch/gtn",
"url": "https://github.com/facebookresearch/gtn/issues/46",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
1008033693 | How to pass STOP to the rearrange task
Habitat-Lab and Habitat-Sim versions
Habitat-Lab: master
Habitat-Sim: master
❓ Questions and Help
According to the paper, the STOP action is needed to end the episode and get the success reward in the rearrange task. However, the task action space accepts only ARM_ACTION with kwargs 'arm_action' and 'grip_action'. I tried passing STOP in many ways, but I always get an error.
How do I tell the agent to STOP?
In the Habitat 2.0 paper, each skill had a custom termination condition. For example, for the Pick skill this was based on if the end-effector was at the resting position with an object grasped. However, the stop discrete action can easily be added to the action space through the POSSIBLE_ACTIONS key in the task config (example).
The hab_suite branch now contains most of the functionality from the paper and we are slowly merging this into main. We made this tutorial to help get started with Habitat 2.0.
Please let me know if you have any more questions!
@ASzot
Thanks for your reply, I will check the tutorial!
Just to double check: the task does not require STOP to terminate, right?
The YAMLs I see all only have ARM_ACTION in POSSIBLE_ACTIONS, and this does not allow to pass STOP. Also, the nav task explicitly checks for STOP, while the rearrange task does not.
Yet, the paper says that STOP is required.
Success: The agent is within 0.3 meters of the goal, 0.5 radians of the target angle, and has called
the stop action at the current time step.
Am I missing something in the code, or does the paper has just some "wrong wording"?
Thanks!
@ASzot
Thanks for your reply, I will check the tutorial!
I think I also got confused because the paper says that only 'Navigate' --and not any 'Rearrange'-- needs STOP to terminate.
| gharchive/issue | 2021-09-27T11:27:51 | 2025-04-01T06:44:08.345500 | {
"authors": [
"ASzot",
"sparisi"
],
"repo": "facebookresearch/habitat-lab",
"url": "https://github.com/facebookresearch/habitat-lab/issues/736",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
1906348932 | How to extract get RGBD images from viewer.py?
❓ Questions and Help
Hi,
I am using version 0.2.5 and I wish to run examples/viewer.py using multiprocessing and extract RGBD images to put them in a Queue for another consumer process. It seems that I need to register new sensors and modify the draw_event function. I tried several times but got no luck.
Adding code below to the end of draw_event is working fine, but I cannot get other sensor renders such as depth and semantics.
state = agent.get_state()
obs = self.sim.get_sensor_observations()
rgba = obs["color_sensor"]
And when I try to register new sensors in default_agent_config, the code just crashes. So here I am asking for help. I appreciate any guide or information on hacking the script. Thanks!
Okay... Half an hour later... I'm back with an answer.
The solution is to configure sim_settings before passing it to HabitatSimInteractiveViewer like this:
sim_settings["color_sensor"] = True
sim_settings["depth_sensor"] = True
sim_settings["semantic_sensor"] = True
HabitatSimInteractiveViewer(sim_settings).exec()
| gharchive/issue | 2023-09-21T07:55:46 | 2025-04-01T06:44:08.348750 | {
"authors": [
"ErcBunny"
],
"repo": "facebookresearch/habitat-sim",
"url": "https://github.com/facebookresearch/habitat-sim/issues/2207",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
387277187 | Validation during training produces unsupported keys
❓ Questions and Help
During training once in 20 iterations I perform inference for my validation set.
is same manner as described in tools/test_net.py. In my case I have only one class but during prediction of the validation set I get some other label than 1, usually happening to at first 100 iterations.
mapped_labels = [dataset.contiguous_category_id_to_json_id[i] for i in labels]
KeyError: 15
Problem is that error occurring randomly.
am I doing something wrong?
How can one overcome this issue?
I did not, sorry for dummy question but how do I do that?
You need to follow the instructions in https://github.com/facebookresearch/maskrcnn-benchmark/issues/15
Thank you!
I'm closing this issue, but let me know if you have other problems
@fmassa Hello, I encountered the same issue, I have changed in defaults.py --> _C.MODEL.ROI_BOX_HEAD.NUM_CLASSES = 25, but when I started training, I still encountered this issue. My output class num is 25 including the background. My issues are:
2020-04-21 14:44:26,720 maskrcnn_benchmark.inference INFO: Model inference time: 0:00:00.999555 (0.08329623937606812 s / img per device, on 1 devices) 2020-04-21 14:44:26,725 maskrcnn_benchmark.inference INFO: Preparing results for COCO format 2020-04-21 14:44:26,725 maskrcnn_benchmark.inference INFO: Preparing bbox results Traceback (most recent call last): File "tools/train_net.py", line 201, in <module> main() File "tools/train_net.py", line 197, in main run_test(cfg, model, args.distributed) File "tools/train_net.py", line 128, in run_test output_folder=output_folder, File "/home/drl/workspace/spikelet/4/graindetection2/maskrcnn-benchmark/maskrcnn_benchmark/engine/inference.py", line 120, in inference **extra_args) File "/home/drl/workspace/spikelet/4/graindetection2/maskrcnn-benchmark/maskrcnn_benchmark/data/datasets/evaluation/__init__.py", line 22, in evaluate return coco_evaluation(**args) File "/home/drl/workspace/spikelet/4/graindetection2/maskrcnn-benchmark/maskrcnn_benchmark/data/datasets/evaluation/coco/__init__.py", line 23, in coco_evaluation expected_results_sigma_tol=expected_results_sigma_tol, File "/home/drl/workspace/spikelet/4/graindetection2/maskrcnn-benchmark/maskrcnn_benchmark/data/datasets/evaluation/coco/coco_eval.py", line 44, in do_coco_evaluation coco_results["bbox"] = prepare_for_coco_detection(predictions, dataset) File "/home/drl/workspace/spikelet/4/graindetection2/maskrcnn-benchmark/maskrcnn_benchmark/data/datasets/evaluation/coco/coco_eval.py", line 88, in prepare_for_coco_detection mapped_labels = [dataset.contiguous_category_id_to_json_id[i] for i in labels] File "/home/drl/workspace/spikelet/4/graindetection2/maskrcnn-benchmark/maskrcnn_benchmark/data/datasets/evaluation/coco/coco_eval.py", line 88, in <listcomp> mapped_labels = [dataset.contiguous_category_id_to_json_id[i] for i in labels] KeyError: 18.0
Could you please help me.
| gharchive/issue | 2018-12-04T13:06:56 | 2025-04-01T06:44:08.359432 | {
"authors": [
"Igal20",
"Ruolingdeng",
"fmassa"
],
"repo": "facebookresearch/maskrcnn-benchmark",
"url": "https://github.com/facebookresearch/maskrcnn-benchmark/issues/247",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
468751087 | categories order of val.json and train.json
❓ Questions and Help
I trained mark rcnn on train.json, then tested on val.json. But ap is approximately 0. I checked the predicted bbox in bbox.json and gt, bboxs are localized but not classified.
Afterwards, I find that the categories order of train.json and val.json is different. When generating the json file, I only pay attention to make the name and id of categories correspond.
For example, my train.json is like this:
data['categories']
[{'supercategory': 'SUPER', 'id': 1, 'name': 'CLASS1'},
{'supercategory': 'SUPER', 'id': 2, 'name': 'CLASS2'},
{'supercategory': 'SUPER', 'id': 3, 'name': 'CLASS3'}
]
my val.json is like this:
data['categories']
[{'supercategory': 'SUPER', 'id': 2, 'name': 'CLASS2'},
{'supercategory': 'SUPER', 'id': 1, 'name': 'CLASS1'},
{'supercategory': 'SUPER', 'id': 3, 'name': 'CLASS3'}
]
If you have the same problem with me, you can check the categories order.
Thank you. I transferred the data in VIA format to COCO, without realizing the inconsistency between train and val categories
| gharchive/issue | 2019-07-16T16:27:37 | 2025-04-01T06:44:08.362202 | {
"authors": [
"ZhuoyaYang",
"imyorsten"
],
"repo": "facebookresearch/maskrcnn-benchmark",
"url": "https://github.com/facebookresearch/maskrcnn-benchmark/issues/970",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
1428603865 | why the "vocab_size" in config file is 50272 but the len(tokenizer) is 50265.
🐛 Bug
The "vocab_size" in config file is 50272 but the len(tokenizer) is 50265, they not match eacch other.
To Reproduce
Steps to reproduce the behavior (always include the command you ran):
Run cmd '....'
See error
None
Code sample
model.resize_token_embeddings(len(tokenizer))
Expected behavior
The results seem good when I use the code abbove to align to tokenizer, but I just wonder why the vocab size for training is 50272, did I miss some important parameter?
Environment
metaseq Version (e.g., 1.0 or master):
PyTorch Version (e.g., 1.0)
OS (e.g., Linux, Windows, MacOS):
How you installed metaseq (pip, source):
Build command you used (if compiling from source):
Python version:
CUDA/cuDNN version:
GPU models and configuration:
Any other relevant information:
Additional context
Tokenizer saved has length 50265 but then we add 4 special tokens: https://github.com/facebookresearch/metaseq/blob/e2df6a021cc5ee024533427ae476ce29cdb65b66/metaseq/tasks/streaming_language_modeling.py#L158
which gives us a dictionary vocab size of 50269 at this point. This is followed by a pad_to_multiple(8): https://github.com/facebookresearch/metaseq/blob/e2df6a021cc5ee024533427ae476ce29cdb65b66/metaseq/tasks/streaming_language_modeling.py#L169, which is why vocab size ends up being 50272.
Tokenizer saved has length 50265 but then we add 4 special tokens:
https://github.com/facebookresearch/metaseq/blob/e2df6a021cc5ee024533427ae476ce29cdb65b66/metaseq/tasks/streaming_language_modeling.py#L158
which gives us a dictionary vocab size of 50269 at this point. This is followed by a pad_to_multiple(8):
https://github.com/facebookresearch/metaseq/blob/e2df6a021cc5ee024533427ae476ce29cdb65b66/metaseq/tasks/streaming_language_modeling.py#L169
, which is why vocab size ends up being 50272.
Thank you for your answering! I have known about self.dictionary.pad_to_multiple_(8), however, what do you mean by "add 4 special tokens", it seems that the 4 special token is already be among the 50265 tokens, I 'm still confused about this.
Secondly, so the process of model.resize_token_embeddings(len(tokenizer)) is needed? It only remove the last few tokens which is meaningless added during self.dictionary.pad_to_multiple_(8)
I the same question, and if it is ok to use a roberta tokenizer instead ?
| gharchive/issue | 2022-10-30T04:53:45 | 2025-04-01T06:44:08.370943 | {
"authors": [
"Zcchill",
"baiyuting",
"suchenzang"
],
"repo": "facebookresearch/metaseq",
"url": "https://github.com/facebookresearch/metaseq/issues/469",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
1249438197 | torchrl.envs Turorial
Provides a tutorial on basic usage of torchrl.envs module
cc @alexpalms, @eugenevinitsky
Reviewed @vmoens ! Very interesting composition tool for environment wrapping, cool stuff.
| gharchive/pull-request | 2022-05-26T11:16:35 | 2025-04-01T06:44:08.434200 | {
"authors": [
"alexpalms",
"vmoens"
],
"repo": "facebookresearch/rl",
"url": "https://github.com/facebookresearch/rl/pull/169",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
2463293027 | Make auto template
[x] Use different template instead of <> (more unique)
[x] Make all variables in some kind of templating engine
[x] Split README.md and README_template.md
Variables in files:
README.md
docs/CONTRIBUTING.md
pyproject.toml
app.py
main,py
LICENSE
Variables in paths:
src/<project_path_name>
Fixed in #5
| gharchive/issue | 2024-08-13T12:56:58 | 2025-04-01T06:44:08.490388 | {
"authors": [
"IoannisP-ITENG"
],
"repo": "faebryk/project-template",
"url": "https://github.com/faebryk/project-template/issues/3",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
2676588374 | fix lint
What type of PR is this?
Uncomment one (or more) /kind <> lines:
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind enhancement
/kind failing-test
/kind feature
Any specific area of the project related to this PR?
Uncomment one (or more) /area <> lines:
/area actionners
/area build
/area config
/area context
/area core
/area notifiers
/area ouputs
/area rule-engine
What this PR does / Why we need it:
Fix lint
How to reproduce the issue:
Which issue(s) this PR fixes:
Special notes for your reviewer:
I'll add in test-infra some rules for poiana to block the merge if the CI is not green
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Issif
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
OWNERS [Issif]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
LGTM label has been added. Git tree hash: eca2bcf694e1a02e5aa72a971628542f5240ef15
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: cpanato, Issif
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
OWNERS [Issif,cpanato]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
| gharchive/pull-request | 2024-11-20T17:09:09 | 2025-04-01T06:44:08.573832 | {
"authors": [
"Issif",
"poiana"
],
"repo": "falcosecurity/falco-talon",
"url": "https://github.com/falcosecurity/falco-talon/pull/524",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
793861197 | Fixing Local Rule Loading Limitations
Motivation
The current custom rule loading defined in falco.yaml loads custom rules from:
falco_rules.local.yaml
rules.d/
This means that if I want to write local rules that override or extend k8s_audit_rules.yaml, I would have to either:
remember to modify falco.yaml to add it (I actually initially forgot that this was possible)
add them to falco_rules.local.yaml and not use any macros or lists from k8s_audit_rules.yaml
add them to rules.d/
I know that it's a simple fix (add a local rules file entry for each ruleset file in falco.yaml) but as mentioned, I forgot that this is an option so I'm guessing others have as well
With Falco looking to add support for more inputs (I think I was a PR related to CloudWatch), adding support for a ".local.yaml" file per ruleset automatically in falco.yaml would make things better
Feature
Add a local.rules file for each ruleset in falco.yaml and add a corresponding empty file under /etc/falco/
Alternatives
Additional context
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle rotten
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://github.com/falcosecurity/community.
/close
@poiana: Closing this issue.
In response to this:
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://github.com/falcosecurity/community.
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
| gharchive/issue | 2021-01-26T01:57:20 | 2025-04-01T06:44:08.584435 | {
"authors": [
"ossie-git",
"poiana"
],
"repo": "falcosecurity/falco",
"url": "https://github.com/falcosecurity/falco/issues/1535",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
1146839471 | Getting for k8s.ns and k8s.pod in AKS with default configuration
Describe the bug
Falco v0.31.0 in AKS is generating alerts like the following:
{"output":"10:53:13.816521484: Error File below /etc opened for writing (user=root user_loginuid=-1 command=ruby2.6 tomlparser-npm-config.rb parent=main.sh pcmdline=main.sh /opt/main.sh file=/etc/opt/microsoft/docker-cimprov/telegraf-rs.conf program=ruby2.6 gparent= ggparent= gggparent= container_id=f36f482d44ea image=) k8s.ns= k8s.pod= container=f36f482d44ea k8s.ns= k8s.pod= container=f36f482d44ea k8s.ns= k8s.pod= container=f36f482d44ea","priority":"Error","rule":"Write below etc","source":"syscall","tags":["filesystem","mitre_persistence"],"time":"2022-02-22T10:53:13.816521484Z", "output_fields": {"container.id":"f36f482d44ea","container.image.repository":null,"evt.time":1645527193816521484,"fd.name":"/etc/opt/microsoft/docker-cimprov/telegraf-rs.conf","k8s.ns.name":null,"k8s.pod.name":null,"proc.aname[2]":null,"proc.aname[3]":null,"proc.aname[4]":null,"proc.cmdline":"ruby2.6 tomlparser-npm-config.rb","proc.name":"ruby2.6","proc.pcmdline":"main.sh /opt/main.sh","proc.pname":"main.sh","user.loginuid":-1,"user.name":"root"}}
How to reproduce it
AKS cluster (k8s v1.21)
Falco v0.31.0 (Default values)
Expected behaviour
It should populate the proper k8s data so exceptions work
Environment
Falco version: v0.31.0
System info:
{
"machine": "x86_64",
"nodename": "falco-2x2dd",
"release": "5.4.0-1068-azure",
"sysname": "Linux",
"version": "71~18.04.1-Ubuntu SMP Thu Jan 20 08:21:40 UTC 2022"
}
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle rotten
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://github.com/falcosecurity/community.
/close
@poiana: Closing this issue.
In response to this:
Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://github.com/falcosecurity/community.
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
| gharchive/issue | 2022-02-22T12:17:28 | 2025-04-01T06:44:08.599464 | {
"authors": [
"alfredomagallon",
"poiana"
],
"repo": "falcosecurity/falco",
"url": "https://github.com/falcosecurity/falco/issues/1910",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
335179896 | How and where to whitelist processes and binaries in the local rule file?
Hi there,
We are exploring falco to protect our host and containers, and realized that the default rules only monitor known pre-installed system binaries such as ls/ps etc. for malicious network connections and file read/write. To be able to know if a new process is created or made network connections or performed malicious file access, we created some additional new rules in our local rule file. However, it soon started giving us lots of false positives. My question is -- where and how can we whitelist process/binaries and the network connections/files opened made by them in the local rule file? Also, where and how to whitelist remote IPs in the file?
Your response and help would be highly appreciated.
Thanks
Abhi
If you'd like to attach the local rules file, we can take a look.
There isn't really a hook to globally whitelist the activity of a list of processes. We generally do this by adding conditions to a rule to address false positives. write_etc_common is an example of that, with many many exclusions for programs that write specific files below /etc.
If you'd like to follow up on slack (https://sysdig.slack.com/messages/falco), we can continue the discussion there. For now, closing this issue.
| gharchive/issue | 2018-06-24T13:35:06 | 2025-04-01T06:44:08.602675 | {
"authors": [
"mstemm",
"srivastavaabhinav"
],
"repo": "falcosecurity/falco",
"url": "https://github.com/falcosecurity/falco/issues/385",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
1631855598 | remove brackets in labels + add Number as DataType
What type of PR is this?
Uncomment one (or more) /kind <> lines:
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
Any specific area of the project related to this PR?
Uncomment one (or more) /area <> lines:
/area build
/area config
/area outputs
/area tests
What this PR does / why we need it:
Remove the brackets in MessageAtrributes keys for AWS SNS output to fix:
2023/03/18 21:18:01 [ERROR] : AWS SNS - ParameterValueInvalid: Invalid non-alphanumeric character '#x5B' was found in the message attribute name. Can only include alphanumeric characters, hyphens, underscores, or dots.
Add new DataType for MessageAtrributes keys for AWS SNS output:
"proc.pid": {
"BinaryValue": null,
"DataType": "Number",
"StringValue": "3009605"
},
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Issif
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
OWNERS [Issif]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
LGTM label has been added. Git tree hash: 865d8057b9e5ee9fa1d8066f9ab314a2307503c4
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: cpanato, Issif
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
OWNERS [Issif,cpanato]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
| gharchive/pull-request | 2023-03-20T10:53:27 | 2025-04-01T06:44:08.614480 | {
"authors": [
"Issif",
"poiana"
],
"repo": "falcosecurity/falcosidekick",
"url": "https://github.com/falcosecurity/falcosidekick/pull/419",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
1634841184 | update(cmake): Fix our dependency install patterns
Simplify our FILES_MATCHING PATTERN patterns so that they work on different platforms.
What type of PR is this?
Uncomment one (or more) /kind <> lines:
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
Any specific area of the project related to this PR?
Uncomment one (or more) /area <> lines:
/area API-version
/area build
/area CI
/area driver-kmod
/area driver-bpf
/area driver-modern-bpf
/area libscap-engine-bpf
/area libscap-engine-gvisor
/area libscap-engine-kmod
/area libscap-engine-modern-bpf
/area libscap-engine-nodriver
/area libscap-engine-noop
/area libscap-engine-source-plugin
/area libscap-engine-savefile
/area libscap-engine-udig
/area libscap
/area libpman
/area libsinsp
/area tests
/area proposals
Does this PR require a change in the driver versions?
/version driver-API-version-major
/version driver-API-version-minor
/version driver-API-version-patch
/version driver-SCHEMA-version-major
/version driver-SCHEMA-version-minor
/version driver-SCHEMA-version-patch
What this PR does / why we need it:
This should ensure that we install both our dependent libraries and their versioned symlinks.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: geraldcombs
Once this PR has been reviewed and has the lgtm label, please assign mstemm for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
OWNERS
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
/milestone 0.11.0
LGTM label has been added. Git tree hash: 7ef925b5d142f4aebb3c2a40ab69d538e1b7fe14
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: FedeDP, geraldcombs
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
OWNERS [FedeDP]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, FedeDP, geraldcombs
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
OWNERS [Andreagit97,FedeDP]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
| gharchive/pull-request | 2023-03-21T23:37:21 | 2025-04-01T06:44:08.633929 | {
"authors": [
"FedeDP",
"geraldcombs",
"poiana"
],
"repo": "falcosecurity/libs",
"url": "https://github.com/falcosecurity/libs/pull/1000",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
1945106318 | fix(userspace/libscap): use %lu for uint64 as modifier
What type of PR is this?
Uncomment one (or more) /kind <> lines:
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
Any specific area of the project related to this PR?
Uncomment one (or more) /area <> lines:
/area API-version
/area build
/area CI
/area driver-kmod
/area driver-bpf
/area driver-modern-bpf
/area libscap-engine-bpf
/area libscap-engine-gvisor
/area libscap-engine-kmod
/area libscap-engine-modern-bpf
/area libscap-engine-nodriver
/area libscap-engine-noop
/area libscap-engine-source-plugin
/area libscap-engine-savefile
/area libscap-engine-udig
/area libscap
/area libpman
/area libsinsp
/area tests
/area proposals
Does this PR require a change in the driver versions?
/version driver-API-version-major
/version driver-API-version-minor
/version driver-API-version-patch
/version driver-SCHEMA-version-major
/version driver-SCHEMA-version-minor
/version driver-SCHEMA-version-patch
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
NONE
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: loresuso
Once this PR has been reviewed and has the lgtm label, please assign gnosek for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
OWNERS
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jasondellaluce, loresuso
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
OWNERS [jasondellaluce]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Andreagit97, jasondellaluce, loresuso
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Needs approval from an approver in each of these files:
OWNERS [Andreagit97,jasondellaluce]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
| gharchive/pull-request | 2023-10-16T12:31:09 | 2025-04-01T06:44:08.653015 | {
"authors": [
"loresuso",
"poiana"
],
"repo": "falcosecurity/libs",
"url": "https://github.com/falcosecurity/libs/pull/1416",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
1853645848 | Update rule "Redirect STDOUT/STDIN to Network Connection in Container"
Motivation
@allanembedded would you be in a position to help improve the upstream rule "Redirect STDOUT/STDIN to Network Connection in Container" based on the libs improvements from https://github.com/falcosecurity/libs/pull/1077? Thanks a bunch in advance!
CC @darryk10 @loresuso
@incertum thanks for kicking me about this.
I've put together a proposed change in https://github.com/allanembedded/falco-rules/commit/e92ce21b8f53ddb49d0aaf74b06a4e3155bd726e, however I thought it was worth getting your input on whether or not it's an issue if the new rule means we don't trigger the event if only one or two of std{in,out,err} are redirected?
I mean, it's kind of the point of the change however it is a modification that existing users of the rule could be impacted by.
Thanks @allanembedded, agreed we should do some more experimentations, like what's the minimum that needs to be true for even a more exotic reverse shell using this general tactic? Based on that ensure we still only alert once instead of multiple times? Bunch of additional conditionals for various scenarios would be totally fair game from my perspective as it will improve the logging quality.
@darryk10?
I would go with a new rule for this, keeping the old one as it is. I would just place the new one above since a more precise use case to avoid conflicts. I think it makes sense to keep them.
Since the overall change has been done to reduce the number of alerts, after some testing we might also decide to keep the new one enabled by default and set the old one as disabled. However, before to proceed with this change I would advice to test the new rule with different rev shell types to see the detection.
@allanembedded and @darryk10 should we instead of changing the rule condition, add this suggestion into the description as tuning advice? And yes the testing we need is non significant before cutting over.
I would prefer not to add new rule.
I'm fine with the approach of just amending the description for now.
FWIW, I think a better future approach for reverse shell overall is something like:
spawned_process and shell_procs and (fd.types[0] in (ip_sockets) or fd.types[1] in (ip_sockets) or fd.types[2] in (ip_sockets))
This is better than hanging off of dup events since there's only one execve for a process and we can check for any combination of std{out,err,in} being redirected once. Unfortunately I believe this will require improvements to the file descriptor table handling across clones/execs, @Andreagit97 can correct me if I'm wrong about that though.
Perfect I just approved the PR. Would it be ok to keep this issue open until the next release and hopefully we can then update the upstream condition?
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle rotten
| gharchive/issue | 2023-08-16T17:29:56 | 2025-04-01T06:44:08.662229 | {
"authors": [
"allanembedded",
"darryk10",
"incertum",
"poiana"
],
"repo": "falcosecurity/rules",
"url": "https://github.com/falcosecurity/rules/issues/131",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
2572848624 | 🛑 Tesscut is down
In d6b36d2, Tesscut (https://mast.stsci.edu/tesscut) was down:
HTTP code: 0
Response time: 0 ms
Resolved: Tesscut is back up in d9628a5 after 9 minutes.
| gharchive/issue | 2024-10-08T10:58:06 | 2025-04-01T06:44:08.671944 | {
"authors": [
"falkben"
],
"repo": "falkben/mast-status",
"url": "https://github.com/falkben/mast-status/issues/504",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
155917979 | add track number
add track number to mp3files so files appear in order
implemented
| gharchive/issue | 2016-05-20T09:05:26 | 2025-04-01T06:44:08.675618 | {
"authors": [
"famoser"
],
"repo": "famoser/YoutubePlaylistDownloader",
"url": "https://github.com/famoser/YoutubePlaylistDownloader/issues/2",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
194523542 | 往返票的出发时间错误？
https://www.v2ex.com/t/326346#reply11
另外可以 改进 订单的显示 方式
和之前的相同Bug 已经解决。
| gharchive/issue | 2016-12-09T06:29:32 | 2025-04-01T06:44:08.677751 | {
"authors": [
"fancymax"
],
"repo": "fancymax/12306ForMac",
"url": "https://github.com/fancymax/12306ForMac/issues/135",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
} |
458604123 | Can pushin support log file rotation?
That should be useful on production env. Or can you support syslog also?
logrotate should work. Send SIGHUP to rotate.
Alternatively you can also use the -m command line argument to pushpin to cause almost everything to output to stdout, which you could then do something with like send to syslog. The Mongrel2 access and error logs will still be files, though.
Shouldn't Pushpin support rotate log automatically? It should be done by config and It can do the rotation basing on size or date though. That's much more better to send SIGHUP manually!
| gharchive/issue | 2019-06-20T11:35:49 | 2025-04-01T06:44:08.736483 | {
"authors": [
"jkarneges",
"nghia1986"
],
"repo": "fanout/pushpin",
"url": "https://github.com/fanout/pushpin/issues/47671",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.