id
stringlengths
4
10
text
stringlengths
4
2.14M
source
stringclasses
2 values
created
timestamp[s]date
2001-05-16 21:05:09
2025-01-01 03:38:30
added
stringdate
2025-04-01 04:05:38
2025-04-01 07:14:06
metadata
dict
357493233
When enableNetworkPolicy is to "true" in cluster-defaults not able to import clusters. **Rancher versions: Build from master Steps to Reproduce: Edit cluster-defaults value and enableNetworkPolicy is to "true". This result in the "enableNetworkPolicy" field in https:///v3/schema/cluster set to "true". Create a cluster using "Import existing cluster" option. Cluster creation fails with Validation failed in API: enableNetworkPolicy enableNetworkPolicy should be false for non-RKE clusters is not a valid option Expected Results: We should not be using enableNetworkPolicy value set in cluster-defaults when creating imported clusters. Imported clusters should always get created with enableNetworkPolicy set to false. Tested with latest build from master. Edit cluster-defaults value and enableNetworkPolicy is to "true". Able to Create a cluster using "Import existing cluster" option and import rke cluster successfully. Cluster gets created with "enableNetworkPolicy": false.
gharchive/issue
2018-09-06T04:35:35
2025-04-01T06:45:35.189443
{ "authors": [ "sangeethah" ], "repo": "rancher/rancher", "url": "https://github.com/rancher/rancher/issues/15432", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
408495674
no restriction for moving namespaces between project What kind of request is this (question/bug/enhancement/feature request): BUG/Question Steps to reproduce (least amount of steps as possible): Create 3 project: ProjectA, ProjectB, ProjectC Create 2 namespaces in each project: nsa in ProjectA, nsb in ProjectB. Grant userA "Project Member" role in ProjectA, "Read Only" in ProjectB, Custom "View Project Catalogs" in ProjectC. Login as userA, move nsa to ProjectB, and move nsb to ProjectC Result: UserA's authority over nsa become "Read-Only", and can no longer see anything from nsb through kubectl. Other details that may be helpful: The point is that user could move whatever the namespace he/she can view on web page from one project to another, despite the his/her authority over the projects, which sometime could cause management issues. Is there any work around to keep a user to have the ability to view the projects contents and can only move the namespaces between projects that user have the authority to update , create and delete namespaces? Environment information Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): v2.2.0-alpha6 Installation option (single install/HA): single Cluster information Cluster type (Hosted/Infrastructure Provider/Custom/Imported): Imported Machine type (cloud/VM/metal) and specifications (CPU/memory): VM Ubuntu 16.04.5 LTS 4.4.0-131-generic, 8 Cores, 32GB RAM. Kubernetes version (use kubectl version): clientVersion: buildDate: "2018-12-13T10:39:04Z" compiler: gc gitCommit: eec55b9ba98609a46fee712359c7b5b365bdd920 gitTreeState: clean gitVersion: v1.13.1 goVersion: go1.11.2 major: "1" minor: "13" platform: linux/amd64 serverVersion: buildDate: "2018-12-13T10:31:33Z" compiler: gc gitCommit: eec55b9ba98609a46fee712359c7b5b365bdd920 gitTreeState: clean gitVersion: v1.13.1 goVersion: go1.11.2 major: "1" minor: "13" platform: linux/amd64 Docker version (use docker version): Client: Version: 18.06.1-ce API version: 1.38 Go version: go1.10.4 Git commit: e68fc7a Built: Thu Nov 15 21:12:47 2018 OS/Arch: linux/amd64 Experimental: false Server: Engine: Version: 18.06.1-ce API version: 1.38 (minimum version 1.12) Go version: go1.10.4 Git commit: e68fc7a Built: Sun Nov 11 21:53:22 2018 OS/Arch: linux/amd64 Experimental: false UserA has no role in project C but can still see it in the UI? Do they have some type of admin permission either globally or in the cluster? sry for the wrong info. I updated the description, "View Project Catalogs" is granted for userA in projectC. The point is that user could move namespaces without any permission checks, which I think may cause management issue. And one more question, how can a user create a namespace through kubectl, and move it into a project, when this user can not view all namespaces in the cluster? Any way other than update namespace's annotation?
gharchive/issue
2019-02-10T03:14:09
2025-04-01T06:45:35.197125
{ "authors": [ "cjellick", "slououou" ], "repo": "rancher/rancher", "url": "https://github.com/rancher/rancher/issues/17953", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
423474638
UI: Have to hit Cancel button twice when creating new node template for first time Version: Master 2.2 (3/20/19) What kind of request is this (question/bug/enhancement/feature request): Bug Steps to reproduce (least amount of steps as possible): On a fresh install, go to the Node Templates page Add any node template. Click cancel Result: You have to actually hit cancel twice because there is no cloud credentials set yet. Other details that may be helpful: In this situation where we do not have any cloud credentials set, we would like the cancel button to cancel out of both prompts. Remove Create/Cancel buttons from the Account Access accordion, for the create on bottom, post both the credential & template events? Comments for Tani after discussion with Vincent: There are currently two different paths for RKE clusters: Amazon EC2 & DigitalOcean - Two step process where you need the credentials to fill out which fields & options you get for the node. Azure, Linode & vSphere - One step process where the node fields are already available & we have two cancel/create button on single page. We need to: [ ] Make the experience consistent across all RKE drivers [ ] Remove the two cancel/create buttons on single page Closing in favor of : #23313. We will be dealing with the two cancels in this ticket.
gharchive/issue
2019-03-20T21:11:59
2025-04-01T06:45:35.202398
{ "authors": [ "davidnuzik", "tfiduccia" ], "repo": "rancher/rancher", "url": "https://github.com/rancher/rancher/issues/19049", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
108718960
Admin Page - Audit Logs Create the audit logs admin page. Paret ref: #1734 This one has it's own older issue and will require the API support first, https://github.com/rancher/rancher/issues/1267
gharchive/issue
2015-09-28T18:28:36
2025-04-01T06:45:35.203866
{ "authors": [ "vincent99", "westlywright" ], "repo": "rancher/rancher", "url": "https://github.com/rancher/rancher/issues/2165", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
656515352
Error Facing with Rancher and AKS Very simple way to deploy AKS using Rancher Server. But the facing the same error again and again...but i could find the logs...hence posting this issue. Error getting Resource Group 'aksrancher': resources.GroupsClient#CheckExistence: Failure responding to request: StatusCode=403 -- Original Error: autorest/azure: error response cannot be parsed: "" error: EOF No Internet firewall. No Port block..No authentication and authorization issues..etc. Which version of Rancher? I had this issue before v2.4.5
gharchive/issue
2020-07-14T10:43:10
2025-04-01T06:45:35.206208
{ "authors": [ "junkiebev", "raviseerapu" ], "repo": "rancher/rancher", "url": "https://github.com/rancher/rancher/issues/27921", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
121755530
Can't build containers which are based on some image in a private registry Trying to deploy a stack with container 'someservice' docker-compose.yml: someservice: build: ./someservice someservice/Dockerfile: FROM my-private-registry.org.com/baseimage ... I also copied /root/.docker/config.json to rancher/agent container to get this work. I think the configured registries in rancher don't apply to this kind of build jobs. This fails when my-private-registry.org.com has basic auth enabled and the rancher node runs on docker 1.9. This is because the authentication headers were passed in wrong format to docker: https://github.com/docker/docker-py/blob/master/docker/api/build.py#L137 This is because python-agent defines the docker api version as 1.18 which applies for docker 1.6: https://github.com/rancher/python-agent/blob/master/cattle/plugins/docker/__init__.py#L43 I believe this could be 'auto' by default which for me fixed the issue. By the way is there any simple way to pass these configuration environment variables when running rancher/agent? Versions: Rancher v0.49.1 Cattle v0.121.0 User Interface v0.71.0 Rancher Compose v0.6.1 Have of the issue with the auto version I think we can address easily. We need to do more analysis to see what it would take to pass the credentials from rancher to the agent for builds as we aren't doing that today. FYI @hibooboo2 +1 +1 my docker-compose is as follows: am: labels: io.rancher.container.pull_image: always tty: true image: my-registry.domain.com/app/web:release-1-t5 stdin_open: true Rancher v0.59.0 Cattle v0.148.0 User Interface v0.90.0 Rancher Compose v0.7.2 I defined docker registry with credentials. My regisitry uses trusted ssl cert. I noticed that registrycredentials are not passed to agent. I did try to create a registry with credentials from ui and from API. Closing due to inactivity.
gharchive/issue
2015-12-11T17:28:10
2025-04-01T06:45:35.213125
{ "authors": [ "ibuildthecloud", "keras", "mtrofimm", "will-chan", "wstam88" ], "repo": "rancher/rancher", "url": "https://github.com/rancher/rancher/issues/3008", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
803387556
rancher/kiwigrid-k8s-sidecar:0.1.151 unexpected commit digest What kind of request is this (question/bug/enhancement/feature request): Bug Steps to reproduce (least amount of steps as possible): Install rancher-monitoring chart Result: The rancher-monitoring-grafana Deployment does not succeed for the following reason: Failed to pull image “rancher/kiwigrid-k8s-sidecar:0.1.151”: rpc error: code = FailedPrecondition desc = failed to pull and unpack image “docker.io/rancher/kiwigrid-k8s-sidecar:0.1.151”: failed commit on ref “layer-sha256:038cfaa9de84da577b2d98f03ae51c51dcc92fce84d08a9db1df08bc5917e845”: unexpected commit digest sha256:bd0c974236c81b7d06800183c4d9791575d17f9df5bd7144012fddfb95c17e72, expected sha256:038cfaa9de84da577b2d98f03ae51c51dcc92fce84d08a9db1df08bc5917e845: failed precondition Other details that may be helpful: The cluster runs with containerd. Pulling the image manually via ctr results in the error: ctr: failed commit on ref “layer-sha256:038cfaa9de84da577b2d98f03ae51c51dcc92fce84d08a9db1df08bc5917e845": commit failed: unexpected commit digest sha256:e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855, expected sha256:038cfaa9de84da577b2d98f03ae51c51dcc92fce84d08a9db1df08bc5917e845: failed precondition Environment information Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): 2.5.5 Installation option (single install/HA): HA Cluster information Cluster type (Hosted/Infrastructure Provider/Custom/Imported): Imported Machine type (cloud/VM/metal) and specifications (CPU/memory): metal, 32 Cores | 252 GiB Ram With containerd NOT docker! Kubernetes version (use kubectl version): Client Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.3", GitCommit:"1e11e4a2108024935ecfcb2912226cedeafd99df", GitTreeState:"clean", BuildDate:"2020-10-14T12:50:19Z", GoVersion:"go1.15.2", Compiler:"gc", Platform:"linux/amd64"} Server Version: version.Info{Major:"1", Minor:"19", GitVersion:"v1.19.7+k3s1", GitCommit:"5a00e38db4c198fb0725a6b709380aed8053d637", GitTreeState:"clean", BuildDate:"2021-01-14T23:09:21Z", GoVersion:"go1.15.5", Compiler:"gc", Platform:"linux/amd64"} CTR version (use docker version): ctr github.com/rancher/containerd v1.4.3-k3s1 @cbron I have seen you had to do with rancher images before. You may still be the wrong address but maybe you can forward the issue to someone who is in charge of these images: Okay, manually pulling with sudo worked ... containerd and ctr where installed by the k3s installation... :thinking: sudo ctr image pull docker.io/rancher/kiwigrid-k8s-sidecar:0.1.151 docker.io/rancher/kiwigrid-k8s-sidecar:0.1.151: resolved |++++++++++++++++++++++++++++++++++++++| index-sha256:4d010e274898b9660a0912e79521641c2ff99c0844ed1dc7607ada84a2f54335: done |++++++++++++++++++++++++++++++++++++++| manifest-sha256:7b98eecdf6d117b053622e9f317c632a4b2b97636e8b2e96b311a5fd5c68d211: done |++++++++++++++++++++++++++++++++++++++| layer-sha256:997c8ef56a250de7e9bf6d9a317e116bf098b374526a134d01b0fb0934c8aed7: done |++++++++++++++++++++++++++++++++++++++| layer-sha256:a3916b494c8f7f35e3114e0ea5aad570c15225d0fc7b0283f3c32e590771a128: done |++++++++++++++++++++++++++++++++++++++| layer-sha256:038cfaa9de84da577b2d98f03ae51c51dcc92fce84d08a9db1df08bc5917e845: done |++++++++++++++++++++++++++++++++++++++| layer-sha256:df3b6f61d28f519379c5c613b83e111ff92db9dfcc6377f7ecdf342cc60eb0c1: done |++++++++++++++++++++++++++++++++++++++| config-sha256:234ccff9537fa5e5479376d3110eea7946c093b1c22ecf974460ce8abcc55772: done |++++++++++++++++++++++++++++++++++++++| layer-sha256:33757165140a2ea2102927fd78a3c989013cf950a05c007de22309a1bfe2ba39: done |++++++++++++++++++++++++++++++++++++++| layer-sha256:cbdbe7a5bc2a134ca8ec91be58565ec07d037386d1f1d8385412d224deafca08: done |++++++++++++++++++++++++++++++++++++++| layer-sha256:6d028ed1c0774ec7b981970165b04b6e3d30a16650b51d05fd5fe99c95dad4b0: done |++++++++++++++++++++++++++++++++++++++| layer-sha256:26ebcd19a4e3221ee54d309346df0869af0d74a25920287f70b0ee1da1bf75de: done |++++++++++++++++++++++++++++++++++++++| layer-sha256:f2a4afa74df82dfc5ab95c31577b88e6ba1b754beeb86ff688d264a904aa0898: done |++++++++++++++++++++++++++++++++++++++| elapsed: 18.0s total: 40.2 M (2.2 MiB/s) unpacking linux/amd64 sha256:4d010e274898b9660a0912e79521641c2ff99c0844ed1dc7607ada84a2f54335... done Solved. Running the command with sudo disabled using our https proxy (via environment variables) that goes through a firewall. The firewall detected executable files or ddls inside the pulled container image layers and thus blocked its download.
gharchive/issue
2021-02-08T09:46:04
2025-04-01T06:45:35.221249
{ "authors": [ "uluzox" ], "repo": "rancher/rancher", "url": "https://github.com/rancher/rancher/issues/31180", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
1272257166
Add/remove an authorized IP range for downstream AKS cluster does not work Rancher Server Setup Rancher version: 2.6-head Installation option (Docker install/Helm Chart): If Helm Chart, Kubernetes Cluster and version (RKE1, RKE2, k3s, EKS, etc): Proxy/Cert Details: Information about the Cluster Kubernetes version: 1.23.5 Cluster Type (Local/Downstream): AKS downstream cluster, provisioned via rancher UI If downstream, what type of cluster? (Custom/Imported or specify provider for Hosted/Infrastructure Provider): User Information What is the role of the user logged in? (Admin/Cluster Owner/Cluster Member/Project Owner/Project Member/Custom) admin If custom, define the set of permissions: Describe the bug After provisioning a cluster via the rancher UI, a. You cannot add an auth IP range in the rancher UI. You can click the both but the +Add Range button is greyed out b. Removing an existing IP range in the rancher UI doesn't trigger a change/fails To Reproduce Provision a 1 node AKS cluster via the rancher UI Edit the AKS cluster and try to add an auth IP range (ex: 0.0.0.0/0, 10.0.0.4/32). The +Add Range button will be greyed out Add an auth IP range to the cluster via Azure portal -> Networking Edit the AKS cluster in rancher and try to remove the auth IP range. That will also fail. If you Edit the cluster again, you will see it hasn't been removed. Note: on the backend, neither rancher nor aks-operator detects a change in the AKSClusterConfig when you remove an auth IP range, and it should. Tested on rainbow (latest 2.6-head) this morning and it's reproducible. Partially reproduced on rancher v2.6-head single node AKS cluster; k8s 1.23.8 Test 1 I'm unable to add an IP auth range to an existing AKS cluster via the rancher UI Test 2 I added 0.0.0.0/0 auth IP range to the cluster in Azure Portal It showed up in the rancher config! So data propagation from upstream is working for this field. Once an IP range from Azure is propagated to rancher, it appears you can add additional ranges. @sowmyav27 Tested on rancher 2.6.2. Can confirm the expected behavior on is that the Add Range button is not greyed out when creating AKS clusters. This is a UI bug. @annablender FYI the UI is not team1, it's the dashboard team. I'll transfer there.
gharchive/issue
2022-06-15T13:41:17
2025-04-01T06:45:35.231632
{ "authors": [ "annablender", "cbron" ], "repo": "rancher/rancher", "url": "https://github.com/rancher/rancher/issues/38007", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
220320997
Adding initializing/re-initializing timeouts for all services in infra stack Rancher Versions: Server: v1.5.4-rc1 sometimes services that has healthcheck enabled may be stuck in reinitializing state when the host powered off unexpectedly, these services include: healthcheck stack scheduler stack On a related note, it probably makes sense to have a conservative value set for all services by default. Added in latest version v1.6.22
gharchive/issue
2017-04-07T20:32:18
2025-04-01T06:45:35.233961
{ "authors": [ "galal-hussein", "joshwget", "loganhz" ], "repo": "rancher/rancher", "url": "https://github.com/rancher/rancher/issues/8449", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
232294979
Io.rancher.container.ip Docker label not set on containers Rancher versions: rancher/server: 1.5.9 rancher/agent: 1.2.2 Infrastructure Stack versions: healthcheck: 0.2.0 ipsec: holder network-services: 0.6.6 & 0.91 (Metadata) scheduler: 0.7.5 Docker version: (docker version,docker info preferred) Client: Version: 17.03.1-ce API version: 1.27 Go version: go1.7.5 Git commit: c6d412e Built: Mon Mar 27 17:14:09 2017 OS/Arch: linux/amd64 Server: Version: 17.03.1-ce API version: 1.27 (minimum version 1.12) Go version: go1.7.5 Git commit: c6d412e Built: Mon Mar 27 17:14:09 2017 OS/Arch: linux/amd64 Experimental: false Operating system and kernel: (cat /etc/os-release, uname -r preferred) NAME="Ubuntu" VERSION="16.04.2 LTS (Xenial Xerus)" ID=ubuntu ID_LIKE=debian PRETTY_NAME="Ubuntu 16.04.2 LTS" VERSION_ID="16.04" HOME_URL="http://www.ubuntu.com/" SUPPORT_URL="http://help.ubuntu.com/" BUG_REPORT_URL="http://bugs.launchpad.net/ubuntu/" VERSION_CODENAME=xenial UBUNTU_CODENAME=xenial Kernal: 4.4.0-1017-aws Type/provider of hosts: (VirtualBox/Bare-metal/AWS/GCE/DO) AWS Setup details: (single node rancher vs. HA rancher, internal DB vs. external DB) HA rancher, external db Environment Template: (Cattle/Kubernetes/Swarm/Mesos) Cattle Steps to Reproduce: Deploy stack, go to it's container, see that Io.rancher.container.ip is sometimes missing Results: Here's a screenshot of one of our ElasticSearch containers: You can see that the Io.rancher.container.ip label is missing. This is a major problem for us as we use DataDog for our monitoring and it relies on this label being present as part of its service detection. As far as I can see in the documentation this label should be set for all containers and container the current assigned managed IP address. @lukewhiting Is there more context to when this is happening? "Sometimes missing" is that 1 stack sometimes it does, sometimes it does not? How often does this occur? Looking through the containers it seems to be isolated to just that stack... All containers in that stack seem to be missing it however other stacks in the same environment seem to be fine, including containers running on the same boxes as the "infrastructure" stack that is missing it. I Have the similar issue. Whenever i use "Retain IP" option, io.rancher.container.ip label not set. @ilucker is correct, when setting "Retain IP" the io.rancher.container.ip isn't set. This is a bug right, or is there a reasoning behind this? This turned out to be a rather huge problem for us as well - as we use this label to identify containers in prometheus, we effectively can't track instances that use retain_ip: true. It seems this is due to the fact that the label is added on instance.create in the rancher-agent (this is where it should be added https://github.com/rancher/agent/blob/v0.12.0/core/compute/compute_unix.go#L159) and my guess is that a retained ip is not known yet. The rancher-agent does not seem to differentiate between retained/non-retained containers so I guess the bug is actually within the service that sends out the compute.instance.activate event (https://github.com/rancher/agent/blob/v0.12.0/handlers/common.go#L39), as it should populate the instanceHostMap.instance.nics[0].ipAddresses. (https://github.com/rancher/agent/blob/v0.12.0/handlers/test_events/instance_activate_basic#L74) After more investigation this does indeed seem to happens when retain IP is set. Is there any update on this issue as it continues to cause problems for services that depend on that label for container IP discovery? @superseb any updates on this? Is there a workaround to set that label manually? It breaks the datadog integration. We also had this issue and we use this workaround for services with scale 1. if that does not work we clone the service, like aerospike1, aerospike2, aerospike3. After the service is up we update the service to enable "retain ip" and we add manually the label io.rancher.container.ip=xx.xx.xx.xx/xx with IP the container has received. Not beautiful but it works. With the release of Rancher 2.0, development on v1.6 is only limited to critical bug fixes and security patches.
gharchive/issue
2017-05-30T15:38:26
2025-04-01T06:45:35.249581
{ "authors": [ "0ff", "claudeatsafe", "deniseschannon", "ilucker", "lukewhiting", "mowday", "ofhk", "superseb" ], "repo": "rancher/rancher", "url": "https://github.com/rancher/rancher/issues/8919", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
428080287
improve event alert Problem: Alert resolved time is 5 mins, alert get deleted in alertmanager if the same event did not happen in 5 mins. Event alert is special, an event will trigger only one time, extend the repeat interval then the event alert will be resolved after resolve time. Event for the same resource with the different message will be placed to the same group, alertmanager will send notifications when new alert adds to this group, this notification includes all alerts in this group. If want user only sees current happen event without others in the same group, we need to add event message to the group key. Solution: Add default repeat time for event Add message to event group key Issue: https://github.com/rancher/rancher/issues/19302 https://github.com/rancher/rancher/issues/19058 LGTM LGTM
gharchive/pull-request
2019-04-02T08:05:35
2025-04-01T06:45:35.253350
{ "authors": [ "aiwantaozi", "loganhz", "thxCode" ], "repo": "rancher/rancher", "url": "https://github.com/rancher/rancher/pull/19321", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
449372608
Check if dir is empty before copy v2.1 Problem: If the bin dir is empty stat fails on "*" Solution: Verify the dir has contents before attempting the copy LGTM
gharchive/pull-request
2019-05-28T16:43:57
2025-04-01T06:45:35.254669
{ "authors": [ "cjellick", "dramich" ], "repo": "rancher/rancher", "url": "https://github.com/rancher/rancher/pull/20504", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
478146508
rio doesn't support cpu and memory based autoscalling Hello, I think that cpu and memory based autoscaling still will be actual for a long time, so it will be very useful if they added in rio. Or if it turns out difficult to implement, even let to work out the k8s hpa in some way for the service created by rio. Available to test in v0.4.0-rc1: To create a service that doesn't control the scale of a deployment, set scale=-1: rio run --scale=-1 ${image} Find the deployment that it creates(should be in same name/namespace). You should be able to change the scale of the deployment and rio will not try to revert it back. Version - 0.4.0-rc2 Verified implemented
gharchive/issue
2019-08-07T21:25:13
2025-04-01T06:45:35.256738
{ "authors": [ "StrongMonkey", "harutyundermenjyan", "tfiduccia" ], "repo": "rancher/rio", "url": "https://github.com/rancher/rio/issues/367", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
66970682
[UI] [LB] On an existing LB, 'Add Target' doesn't work Version: Build from Master Create an LB. After the LB is created, 'Add Target'. Result: Nothing happens Expected Result: Ability to add another target. Question: Should this add a new container? Would we have the ability to select an existing container (similar to when setting up the LB)? Adding a target is only for an existing container (or an external IP). This is fixed in rancherio/ui#115 Build from latest 4/8/15 Verified fixed
gharchive/issue
2015-04-07T19:15:16
2025-04-01T06:45:35.269224
{ "authors": [ "deniseschannon", "tfiduccia", "vincent99" ], "repo": "rancherio/rancher", "url": "https://github.com/rancherio/rancher/issues/456", "license": "apache-2.0", "license_type": "permissive", "license_source": "bigquery" }
67417991
Machine_test.py fixes Changed sleep interval to 2 seconds when querying DO for deleted hosts Added try/finally block for request close Removed redundant name assignemt in test_digital_ocean_machine_parallel module @alena1108 , @sonchang , can you please review ? LGTM LGTM
gharchive/pull-request
2015-04-09T18:01:46
2025-04-01T06:45:35.271065
{ "authors": [ "alena1108", "sangeethah", "sonchang" ], "repo": "rancherio/validation-tests", "url": "https://github.com/rancherio/validation-tests/pull/35", "license": "apache-2.0", "license_type": "permissive", "license_source": "bigquery" }
2287517927
OTP after email & password input Hi Ranjan, In Italy VFS , it ask for otp when you input email & password for sign in. Can you share the URL you are trying with? Hi, Please find below the link. https://visa.vfsglobal.com/ind/en/ita/login Regards On Fri, May 10, 2024, 3:54 PM Ranjan Mohanty @.***> wrote: Reopened #51 https://github.com/ranjan-mohanty/vfs-appointment-bot/issues/51. — Reply to this email directly, view it on GitHub https://github.com/ranjan-mohanty/vfs-appointment-bot/issues/51#event-12768066300, or unsubscribe https://github.com/notifications/unsubscribe-auth/BBKS4MWZJUZEW7D4SQ3XBT3ZBSN4JAVCNFSM6AAAAABHOVOBR2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSG43DQMBWGYZTAMA . You are receiving this because you authored the thread.Message ID: <ranjan-mohanty/vfs-appointment-bot/issue/51/issue_event/12768066300@ github.com> Hi @ramakant7153 The bot doesn't support IN-IT (India-Italy) VFS. Supported countries can be found here I will update here once we add the support.
gharchive/issue
2024-05-09T11:45:36
2025-04-01T06:45:35.303807
{ "authors": [ "ramakant7153", "ranjan-mohanty" ], "repo": "ranjan-mohanty/vfs-appointment-bot", "url": "https://github.com/ranjan-mohanty/vfs-appointment-bot/issues/51", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
426143527
Lag accessing items in wireless grid after creating Reborn Storage 9x9x9 Issue description: I created a Reborn Storage 9x9x9 and connected it to my Refined Storage. Now there is a lag when trying to take/place items from/to the wireless grid. I have verified that there is not such a lag when using the Crafting Grid directly. However, when I first access the Crafting Grid, it appears to be empty for a few seconds. What happens: Lag when using the Wireless Grid What you expected to happen: Less or no lag, like it was before building the Reborn Storage Steps to reproduce: Have a RS setup with about 2M items (includes 24 64K discs and about 20 Quantum Storage units holding items with more than 30k count) Create and hookup a 9x9x9 Reborn Storage with 274 CPUs and 69 Storage Craft a wireless grid and try to exchange items to/from personal inventory ... Version (make sure you are on the latest version before reporting): Minecraft: 1.10.2 Forge: 12.18.3.2477 Refined Storage: 1.2.26 RebornCore: 2.13.6.140 reborncore-MCMultiPart: 2.13.6.142 RebornStorage: 1.0.3.30 Does this issue occur on a server? no, single player world If a (crash)log is relevant for this issue, link it here: I have an .nps file per the RS wiki instructions, but I am not sure where to put it. So, for now I have put it here: https://drive.google.com/open?id=1wsTKbtGyZq_YvZB3RxqTvLIsCCzEwnvk If I remember correctly a related issue was fixed in 1.12.2. 1.10.2 is not supported.
gharchive/issue
2019-03-27T19:26:05
2025-04-01T06:45:35.313423
{ "authors": [ "Aang23", "raoulvdberge", "timepieces141" ], "repo": "raoulvdberge/refinedstorage", "url": "https://github.com/raoulvdberge/refinedstorage/issues/2204", "license": "mit", "license_type": "permissive", "license_source": "bigquery" }
167504591
Many issues with SpongeForge Several things are messed up. The grid GUI is acting very strangely, I put it 5 buckets it shows 10, I take one out it shows 8, stuff like that. If I configure an interface to keep one bucket in it, I can't remove that bucket from the GUI. There are probably more issues that I don't know about. I do not support SpongeForge Alright, well I don't know how I'm going to have a server on 1.10 then. Was spongeforge on the client or the server? Uh, server. @Alleluid If you can open an issue on SpongeForge's repo with all the version details preferably, and make sure that you're using the very latest build for 1.10.2 (which is 1601). Please note the full mod list and plugin list and preferably a way to reproduce in order. I'm going to close this issue, please report a bug at SpongeForge's side. Several things are messed up. The grid GUI is acting very strangely, I put it 5 buckets it shows 10, I take one out it shows 8, stuff like that. never happen after a few days of usage ( with and without sponge) If I configure an interface to keep one bucket in it, I can't remove that bucket from the GUI. this also happen without sponge, here is a from the log: http://pastebin.com/raw/H49VPqFF
gharchive/issue
2016-07-26T01:55:56
2025-04-01T06:45:35.317769
{ "authors": [ "Alleluid", "FiveEYZ", "JorVaCoding", "gabizou", "raoulvdberge" ], "repo": "raoulvdberge/refinedstorage", "url": "https://github.com/raoulvdberge/refinedstorage/issues/223", "license": "mit", "license_type": "permissive", "license_source": "bigquery" }
438761427
Rework inline html scans This PR removes InlineScanner in favor of simpler (existing) byte scanners improves scanning throughput on inline HTML and autolinks by ~10% guards against quadratic scanning behavior on pathological HTML (https://github.com/raphlinus/pulldown-cmark/issues/280) fixes a quadratic scanning regression on inline links and improves their general scanning performance by ~4% moves a bunch of scanning functionality from the parse module to the scanner module I may need to take another look at the HtmlScanGuards. Setting a flag may not be enough because I think it may be the case that we do not scan the entire text..
gharchive/pull-request
2019-04-30T12:50:42
2025-04-01T06:45:35.326934
{ "authors": [ "marcusklaas" ], "repo": "raphlinus/pulldown-cmark", "url": "https://github.com/raphlinus/pulldown-cmark/pull/281", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
1280375713
The dask-sql version of Query 18 fails validation test The dask-sql version of Query 18 is currently failing validation tests. For example, at sf100: Sentiment Analysis Query 62.74793928308431% overlap with 42097 rows (RAPIDS denominator) 19.659137424180404% overlap with 134365 rows (Spark denominator) Error Correctness Assertion False However, the dask_cudf version of the query passes: Sentiment Analysis Query 97.27588943359564% overlap with 134833 rows (RAPIDS denominator) 97.61470621069475% overlap with 134365 rows (Spark denominator) Correctness Assertion True It appears that these failures were caused by: https://github.com/rapidsai/cudf/issues/11189
gharchive/issue
2022-06-22T15:32:20
2025-04-01T06:45:35.440391
{ "authors": [ "ChrisJar" ], "repo": "rapidsai/gpu-bdb", "url": "https://github.com/rapidsai/gpu-bdb/issues/262", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
965309345
rapids_export_cpm(BUILD) captures location of locally found packages When cpm find a local package via <project>-config.cmake we cache that location for our users This fixes issues where a project will find a local install in CMAKE_INSTALL_PREFIX but consumers won't as they have a different CMAKE_INSTALL_PREFIX. Needs a test @gpucibot merge
gharchive/pull-request
2021-08-10T19:46:52
2025-04-01T06:45:35.445085
{ "authors": [ "robertmaynard" ], "repo": "rapidsai/rapids-cmake", "url": "https://github.com/rapidsai/rapids-cmake/pull/65", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
829454458
Update readme This PR aims to update Readme files to provide a better introduction of the rapids-js modules Looks great!
gharchive/pull-request
2021-03-11T19:24:50
2025-04-01T06:45:35.445905
{ "authors": [ "AjayThorve", "bryevdv" ], "repo": "rapidsai/rapids-js", "url": "https://github.com/rapidsai/rapids-js/pull/107", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
57023677
permission_role allows for multiple repeating entries @petewwa what steps are you taking to get the above result so I can trace through the source? I just got started and this occurs randomly. I followed your VaultTableSeeder and created some permissions and roles of my own. Then when I tried to manipulate them via the browser I received strange results such as administrator role having the View Administrator Link attached to it 3 times $permission_model = Config::get('vault.permission'); $flyAbove = new $permission_model; $flyAbove->name = 'fly_above_the_ground'; $flyAbove->display_name = 'Fly above the ground'; $flyAbove->system = true; $flyAbove->created_at = \Carbon\Carbon::now(); $flyAbove->updated_at = \Carbon\Carbon::now(); $flyAbove->save(); $rolePrototyper = new $role_model; $rolePrototyper->name = 'Prototyper'; $rolePrototyper->created_at = \Carbon\Carbon::now(); $rolePrototyper->updated_at = \Carbon\Carbon::now(); $rolePrototyper->save(); $rolePrototyper->attachPermission($flyAbove); $user_model = Config::get('auth.model'); $user_model::first()->attachRole($rolePrototyper); By the way what purpose does the "system" attribute in permission model? System is just a flag, it takes away the delete button on the UI so you don't accidentally delete it if it's really important. Also, can you try to wipe everything, run the seed once, then use the UI to add your roles and permissions? The seeder isn't going to do many checks when using it, however the CRUD operations on the UI should prevent it from doing the above, if it isn't then theres a bug that needs to be fixed. However, the above won't crash your application because the code will still see that it exists and perform the right operations, it's just annoying and shouldn't be doing that if it is. But try this first. Have you tried the above?
gharchive/issue
2015-02-09T12:20:38
2025-04-01T06:45:35.460895
{ "authors": [ "petewwa", "rappasoft" ], "repo": "rappasoft/vault", "url": "https://github.com/rappasoft/vault/issues/7", "license": "mit", "license_type": "permissive", "license_source": "bigquery" }
1359824095
getOrderById says order with id not found getOrderById says order with id not found https://testnet-api.rarible.org/v0.1/orders/ETHEREUM%3A0x9e8066fa55406cc9417615bf945f3d9d5f4a8358e670a058954b7fce43008580 At the same time, I am able to fetch other items data using the same api. It seems we don't have this order in the DB. @dsuthardeqode why do you think it should be there? Feel free to reopen if you consider this as an issue on our side
gharchive/issue
2022-09-02T07:41:21
2025-04-01T06:45:35.462911
{ "authors": [ "dsuthardeqode", "evgenynacu", "mystdeim" ], "repo": "rarible/sdk", "url": "https://github.com/rarible/sdk/issues/326", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
2164850938
Warning "invalid json config" Hallo Rasch, ich habe den Deye Sun600 und versuche diesen über IOBroker auszulesen. Die Installation habe ich nun schon mehrfach auf meine Raspi 3B+ durchgeführt, ohne Erfolg. Ich hatte die GitHub Version als auch die freigebene Version probiert, ich kriege keine Daten vom Inverter. Hier der letzte Log: 2024-03-02 15:53:50.662 - info: admin.0 (1329) ==> Connected system.user.admin from ::ffff:192.168.179.2 2024-03-02 15:55:57.703 - warn: admin.0 (1329) deyeidc has an invalid jsonConfig: [{"instancePath":"/items/_coils/items/coils/items/1","schemaPath":"#/items/allOf/17/then/additionalProperties","keyword":"additionalProperties","params":{"additionalProperty":"trim"},"message":"must NOT have additional properties"},{"instancePath":"/items/_coils/items/coils","schemaPath":"#/patternProperties/%5E.%2B/allOf/23/if","keyword":"if","params":{"failingKeyword":"then"},"message":"must match "then" schema"},{"instancePath":"/items/_coils","schemaPath":"#/properties/items/patternProperties/%5E.%2B/allOf/8/if","keyword":"if","params":{"failingKeyword":"then"},"message":"must match "then" schema"}] 2024-03-02 15:57:00.085 - info: host.raspiBDW "system.adapter.deyeidc.0" enabled 2024-03-02 15:57:00.176 - info: host.raspiBDW instance system.adapter.deyeidc.0 started with pid 1717 2024-03-02 15:57:03.558 - info: deyeidc.0 (1717) starting. Version 0.0.14 in /opt/iobroker/node_modules/iobroker.deyeidc, node: v19.9.0, js-controller: 5.0.19 2024-03-02 15:57:03.619 - info: deyeidc.0 (1717) Retrieving data from the inverter will be done every 60 seconds Was mach ich falsch?? Grüße Hans Gar nichts. Hier wird nur eine Warnung ausgegeben, dass eine Datei nicht (mehr) ganz korrekt ist. Sollte aber keine Auswirkungen auf die Funktion des Adapters haben. Wird aber nichts desto trotz beim nächsten Update korrigiert. Wenn die IP und die Logger-Seriennummer korrekt sind, müssen Daten ankommen, zumindest die vom "Apo_t1" - gerade mit einem RPi4 getestet. No new findings. Therefore closed from my side.
gharchive/issue
2024-03-02T15:15:32
2025-04-01T06:45:35.469143
{ "authors": [ "HalloNo", "raschy" ], "repo": "raschy/ioBroker.deyeidc", "url": "https://github.com/raschy/ioBroker.deyeidc/issues/87", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
1903077214
public/uploads directory missing when built from source I built cmprovision from source using dpkg-buildpackage. I then compared my local deb against the 1.6.3 release and noticed that /var/lib/cmprovision/public/uploads was missing from my local deb. This causes the /images endpoint to return a 500 error (Images.php:21). I suspect this is because the uploads directory is not included in the Git source. I solved the problem by creating a debian/dirs file and adding the directory to it, but the documentation suggests this is generally not desirable. Should I be building the source differently, or is this a bug that a PR should be submitted for? My build script does this effectively ... mkdir public/uploads dpkg-buildpackage -us -uc --build=all Thanks barney, I solved the issue locally in a similar way. I created the debian/dirs file (documentation) with the contents: var/lib/cmprovision/public/uploads
gharchive/issue
2023-09-19T14:06:37
2025-04-01T06:45:35.483106
{ "authors": [ "barneyman", "ysica" ], "repo": "raspberrypi/cmprovision", "url": "https://github.com/raspberrypi/cmprovision/issues/28", "license": "BSD-3-Clause", "license_type": "permissive", "license_source": "github-api" }
1523375023
[BUG] save cropped jpg can be distorted Please only report one bug per issue! Describe the bug Save of a still from a cropped stream is distorted if the crop aspect ratio is not the same as the stream aspect ratio. A portrait crop from a landscape stream results in a correctly cropped image rendered in a jpg with the incorrect aspect ratio. The resulting image in the jpg is horizontally stretched. This behavior is inconsistent with the behavior of a cropped video stream, which is correct in a similar case. New issue as requested here https://github.com/raspberrypi/picamera2/issues/498#issuecomment-1373397722 To Reproduce capture_config = picam2.create_still_configuration() picam2.configure(capture_config) crop = picam2.capture_metadata()['ScalerCrop'] with picam2.controls as controls: controls.ScalerCrop = (crop[1] * 3 //4, crop[1]) # create a portrait crop aspect is 3:4 picam2.capture_file('test.jpg', 'main') Expected behaviour The cropped image in a 3:4 aspect (portrait) jpg. Console Output, Screenshots If applicable, any console output or screenshots that show the problem and associated error messages. Hardware : Camera V2.1 Additional context This behavior is inconsistent with video, for example a cropped a 4:3 stream can be cropped to 16:9 (this is not selecting the stream aspect ratio) to record a 16:9 video. This is a different test case, but this is the same behavior that is missing in the photo case. I think the photo issue occurs because request.helpers.make_array() depends on config["size"] to set the jpg size (and aspect ratio). This is the un-cropped size, which does not necessarily have the same aspect ratio as the cropped image. I perhaps confirmed this make_array behavior for a photo_config, using this test which assumes I know the crop is portrait 3:4 (not generally true). The test was successful in that it captured a portrait 3:4 jpg (content was offset, test has side effects - it is not a workaround) crop = picam2.capture_metadata()['ScalerCrop'] picam2.set_controls({'size'} : (size[1]*3//4 , size[1])) The placeholder arguments for width and height are there in CompletedRequest, they are just not used or exposed. Hi, thanks for reporting this. Again, I'm trying to pin down the exact test case here. The script doesn't appear to start the camera, and doesn't specify the crop rectangle properly, so I'm assuming this is what was intended: from picamera2 import Picamera2 import time picam2 = Picamera2() capture_config = picam2.create_still_configuration() picam2.configure(capture_config) picam2.start() crop = picam2.capture_metadata()['ScalerCrop'] with picam2.controls as controls: width = crop[3] * 3 // 4 new_crop = ((crop[2] - width) // 2, 0, width, crop[3]) print(new_crop) controls.ScalerCrop = new_crop time.sleep(1) picam2.capture_file('test.jpg', 'main') and the problem is that the crop region gets stretched to fill the output image. Is that all correct? If that's right, then I think this is probably the intended behaviour. The ScalerCrop specifies the crop performed on the image received from the camera, it is not applied to the output image. If you want to change the size of the output image then you need to reconfigure the camera system (or perform the crop yourself using numpy). Please let me know if that sounds correct, or if I've misunderstood what you wanted to do. Thanks! Yes, that it. I eventually figured out that ScalerCrop is a Scale operation implemented with Crop arguments (all I had to do was decode the name!); this will only work as a pure crop in the special case that the before and after aspect ratios are the same. So yes if I use any other aspect ratio, the image received from the camera is cropped and stretched. And this must be corrected for in the capture and display. I can do this. Enhancement request: Clarify the documentation in Appendix C of the Picamera2 Manual, to make it clear that ScalerCrop can only be used for zoom, and not for any arbitrary crop (unless the user writes their own capture and display functions). I'm complete, close if you are. Great, thanks for the update.
gharchive/issue
2023-01-07T01:09:13
2025-04-01T06:45:35.516282
{ "authors": [ "RobertFlatt", "davidplowman" ], "repo": "raspberrypi/picamera2", "url": "https://github.com/raspberrypi/picamera2/issues/505", "license": "BSD-2-Clause", "license_type": "permissive", "license_source": "github-api" }
769153359
PyTorch or Tensorflow We have to decide on whether to use PyTorch or Tensorflow. I have started a coursera course on GANs, there they use PyTorch and motivate it by this article, which suggests it is the better tool for research. Of course, the article might already be outdated (it's from 2019). @anna-184702 will have an opinion on this :) (But TF isn't so bad either any more 😄 ) @HirtM There is also this Coursera course on GANs: https://www.coursera.org/specializations/generative-adversarial-networks-gans No idea if it's any good though. They also use PyTorch I think. I might have a look at it to refresh my knowledge. My vote is definitely PyTorch 😁 So I guess it's Pytorch for now...
gharchive/issue
2020-12-16T18:01:17
2025-04-01T06:45:35.538598
{ "authors": [ "HirtM", "anna-184702", "raspstephan" ], "repo": "raspstephan/nwp-downscale", "url": "https://github.com/raspstephan/nwp-downscale/issues/7", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
512003963
Deployed to heroku ok but application crashes on launch Everything edployed to heorku without error, but when I try to open the app from within the heroku web interface I'm told there is an Application Error. Examining the app's log from the heroku cli reveals: 2019-10-24T14:55:41.843711+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/" host=slackinkeyshape.herokuapp.com request_id=a44dbec5-5223-4edf-985f-4331feaa76b2 fwd="81.131.144.153" dyno= connect= service= status=503 bytes= protocol=https 2019-10-24T14:55:42.147759+00:00 heroku[router]: at=error code=H10 desc="App crashed" method=GET path="/favicon.ico" host=slackinkeyshape.herokuapp.com request_id=c93a45bd-ce4d-4d4f-a6e2-98c68d298049 fwd="81.131.144.153" dyno= connect= service= status=503 bytes= protocol=https Does anyone have any ideas? Thanks You should try https://github.com/emedvedev/slackin-extended. Do note that there's a bug with many users in both repos. Thanks, I didn't know about that. I gave it a try but am getting a build failure from now ./slackin-extended. 04:06:44 PM | WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.2.9 (node_modules/fsevents): 04:06:44 PM | npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.2.9: wanted {"os":"darwin","arch":"any"} (current: {"os":"linux","arch":"x64"}) 04:06:44 PM | added 736 packages from 900 contributors and audited 4673 packages in 9.507s 04:06:44 PM | found 0 vulnerabilities 04:06:44 PM | Running "npm run build" 04:06:44 PM | > slackin-extended@1.1.11 build /zeit/219c027a 04:06:44 PM | > node-sass --output-style compressed --precision 6 scss/ -o assets/ 04:06:45 PM | Rendering Complete, saving .css file... 04:06:45 PM | Wrote CSS to /zeit/219c027a/assets/main.css 04:06:45 PM | Wrote 1 CSS files to /zeit/219c027a/assets/ 04:06:45 PM | Error: No output directory named "public" found. 04:06:45 PM | More details: https://zeit.co/docs/v2/advanced/platform/frequently-asked-questions#missing-public-directory 04:06:45 PM | at validateDistDir (/zeit/55cfbb27218c985e/.build-utils/.builder/node_modules/@now/static-build/dist/index.js:308:15) 04:06:45 PM | at Object.build (/zeit/55cfbb27218c985e/.build-utils/.builder/node_modules/@now/static-build/dist/index.js:503:13) 04:06:45 PM | at <anonymous> 04:06:45 PM | at process._tickDomainCallback (internal/process/next_tick.js:228:7) 04:06:45 PM | worker exited with code 20 and signal null 04:06:47 PM | done You should ask in the other repo :) I don't use Zeit myself I deployed successfully after a few tries. Check if your reCaptcha keys are right
gharchive/issue
2019-10-24T15:01:43
2025-04-01T06:45:35.617370
{ "authors": [ "Sheikh-Aman", "XhmikosR", "steveharman" ], "repo": "rauchg/slackin", "url": "https://github.com/rauchg/slackin/issues/409", "license": "mit", "license_type": "permissive", "license_source": "bigquery" }
573714806
Misaligned message box Sort of a dupe of #16 The message input text is a lot lower than it should be: Also having this issue Yep me too, might take a look and see if it's easily fixable This should be fixed now.
gharchive/issue
2020-03-02T04:50:44
2025-04-01T06:45:35.623469
{ "authors": [ "BigHeadGeorge", "JakeCover", "SirGhosty22", "rauenzi" ], "repo": "rauenzi/Nox", "url": "https://github.com/rauenzi/Nox/issues/17", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
506373128
refactor libvue js classes the libvue js classes have all sub objects defined at runtime in the constructor. this feels wrong and ugly... they should have all members defined at top level, and there should be a clear separation between static members/methods (if needed at all, we have the global instance variables...) done
gharchive/issue
2019-10-13T19:53:11
2025-04-01T06:45:35.633936
{ "authors": [ "ravermeister" ], "repo": "ravermeister/lastfmtube", "url": "https://github.com/ravermeister/lastfmtube/issues/17", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
1991744083
[Feature] Add new worker groups to Ray Service without rollout Search before asking [X] I had searched in the issues and found no similar feature requirement. Description It would be useful to be able to add a new worker group definition to the Ray Cluster configuration without causing a new cluster rollout. Use case I want to run Ray Serve applications in separate docker images. I can leverage worker groups nicely to do that. The problem comes when I want to add a new Ray Serve application. In Serve, adding a new application is lightweight; a new application is started without touching any existing applications. But if I want to add a new application and define a new worker group for that app to run in, that will cause a new cluster rollout. I want to be able to add new applications and define new worker groups without this happening. Related issues No response Are you willing to submit a PR? [ ] Yes I am willing to submit a PR! @kevin85421 Here's my rough plan: The following functions should be refactored in some way to detect the case "workerGroup(s) added": https://github.com/ray-project/kuberay/blob/666679f8dfc5b7085fc0d93bea89aaa4d9a02c8b/ray-operator/controllers/ray/rayservice_controller.go#L1134-L1158 In the RayService reconcile loop, currently we have two options, (1) create a new RayCluster or (2) do nothing to the RayCluster. If the situation "new workerGroup(s) added" is detected, we will now add option (3), which is update the RayCluster via r.Update() Does this sound good to you? Another question: Should we handle the case where workerGroups are removed, or should we keep the old behavior which is to rollout a new Cluster in this case? In the RayService reconcile loop, currently we have two options, (1) create a new RayCluster or (2) do nothing to the RayCluster. If the situation "new workerGroup(s) added" is detected, we will now add option (3), which is update the RayCluster via r.Update() This makes sense to me. Another question: Should we handle the case where workerGroups are removed, or should we keep the old behavior which is to rollout a new Cluster in this case? Perhaps we could update the RayCluster (option 3) when the number of worker groups changes. Many users do not favor rolling out a new RayCluster, whether it is intended or unexpected. @kevin85421 Thanks, that's helpful! I just want to nail down the desired behavior: If we update the cluster when adding or deleting worker groups, then doesn't this imply that we should also update the cluster even if only Replicas or WorkersToDelete changes? Because that's equivalent to deleting a worker group and adding back the same worker group but with the new Replicas or WorkersToDelete. This would be a change from the existing behavior (which is to do nothing in this case.) That means we'll have three options: Option 1: Create a new RayCluster: If there are any changes outside of workerGroupSpecs Option 2: Do Nothing: Only if the entire spec is identical (in particular, this includes Replicas and WorkersToDelete) Option 3: Update the RayCluster: If the only changes are inside workerGroupSpec So there will be no special handling of Replicas or WorkersToDelete. We could potentially eliminate Option 2 to simplify things, but my guess is that will cause too much overhead by calling client.Update() every reconciliation loop. I think we should still retain option 2 (i.e. do nothing) for Replicas and WorkersToDelete in the short term. This may be a bit more complex than our imagination. Ray Autoscaler only updates RayCluster CR, so there is an inconsistency in the RayClusterSpec between the RayCluster CR and the RayService CR. Most RayService users use Ray Autoscaler because the nondeterministic property of model serving. It is better to make only one source of truth to manage these two fields (RayService controller or Ray Autoscaler). We can do it later if it is necessary.
gharchive/issue
2023-11-14T00:53:25
2025-04-01T06:45:35.652697
{ "authors": [ "architkulkarni", "kevin85421", "zcin" ], "repo": "ray-project/kuberay", "url": "https://github.com/ray-project/kuberay/issues/1643", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
2411034822
[Feature] Event record for failed Pod creation Search before asking [x] I had searched in the issues and found no similar feature requirement. Description Recently, while using RayCluster, a user configured an invalid label in the pod template. I could only discover this issue through the logs of RayOperator. Perhaps, we could use the following methods to help us troubleshoot or avoid such issues more quickly: Record relevant failure information using EventRecorder when pod creation fails. Add validation logic for the pod template in the validating webhook. Use case RayCluster troubleshooting Related issues #2210 Are you willing to submit a PR? [ ] Yes I am willing to submit a PR! So far in KubeRay we've tried to avoid validating webhooks for two reasons: Many users have company-wide policies disallowing webhooks Webhooks potentially introduce additioanl complexity and reliability issues We do have a separate effort to improve RayCluster observability via status conditoins: https://github.com/ray-project/enhancements/pull/54 Maybe we can incorporate invalid Pod templates as part of this @kevin85421 @rueian Also just worth clarifying that we do have config for validating webhooks but it's optional and you need to manually deploy it like this: https://github.com/ray-project/kuberay/blob/master/ray-operator/Makefile#L132-L134 The validation logic is here: https://github.com/ray-project/kuberay/blob/master/ray-operator/apis/ray/v1/raycluster_webhook.go#L51-L68 Ah, I see you changed the issue to ask for events instead of validating webhooks. Related issue: https://github.com/ray-project/kuberay/issues/2189 @andrewsykim. Haha. In fact, we didn't enable webhooks, so the ErrorEvent is sufficient for us to troubleshoot issues. Of course, using validating webhooks to verify the RayCluster would be even better if allowed. A failure to create a pod is not always due to an invalid YAML. Using Events can help us quickly diagnose the issue. Closed by #2286
gharchive/issue
2024-07-16T12:38:27
2025-04-01T06:45:35.660835
{ "authors": [ "Eikykun", "andrewsykim", "kevin85421" ], "repo": "ray-project/kuberay", "url": "https://github.com/ray-project/kuberay/issues/2250", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
1436388514
[Bug][Investigation] Examine reconciliation backoff when there is an issue creating pods Search before asking [X] I searched the issues and found no similar issues. KubeRay Component ray-operator What happened + What you expected to happen The issue comment here indicates there may be a problem with reconciliation backoff when there's a persistent issue creating a pod: https://github.com/ray-project/kuberay/pull/639#issuecomment-1298700181 Investigate and fix! Reproduction script Try applying a resource quota or concocting some other condition that would prevent a worker pod from being created. Check if reconciliation is too frequent with KubeRay master. Anything else No response Are you willing to submit a PR? [ ] Yes I am willing to submit a PR! TLDR: I can't reproduce the issue. I am using Kuberay on Kind to test it locally. I am using github.com/ray-project/kuberay/ray-operator/config/default?ref=master&timeout=90s and provision a ray cluster that exceeds the quota. I can see the backoff reconciling happens. 2022-11-06T23:01:30.511Z ERROR controller.raycluster-controller Reconciler error {"reconciler group": "ray.io", "reconciler kind": "RayCluster", "name": "raycluster-mini", "namespace": "kuberay-debug", "error": "pods \"raycluster-mini-head-cgpsq\" is forbidden: exceeded quota: test-cpu-quota, requested: limits.cpu=500m,requests.cpu=500m, used: limits.cpu=0,requests.cpu=0, limited: limits.cpu=300m,requests.cpu=200m"} sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.1/pkg/internal/controller/controller.go:266 sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2 /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.1/pkg/internal/controller/controller.go:227 2022-11-06T23:01:50.994Z INFO controllers.RayCluster reconciling RayCluster {"cluster name": "raycluster-mini"} 2022-11-06T23:01:50.996Z INFO controllers.RayCluster reconcileServices {"headService service found": "raycluster-mini-head-svc"} 2022-11-06T23:01:50.996Z INFO controllers.RayCluster reconcilePods {"creating head pod for cluster": "raycluster-mini"} 2022-11-06T23:01:50.997Z INFO RayCluster-Controller Setting pod namespaces {"namespace": "kuberay-debug"} 2022-11-06T23:01:50.997Z INFO controllers.RayCluster head pod labels {"labels": {"app.kubernetes.io/created-by":"kuberay-operator","app.kubernetes.io/name":"kuberay","groupName":"headgroup","ray.io/cluster":"raycluster-mini","ray.io/cluster-dashboard":"raycluster-mini-dashboard","ray.io/group":"headgroup","ray.io/identifier":"raycluster-mini-head","ray.io/is-ray-node":"yes","ray.io/node-type":"head","rayCluster":"raycluster-sample","rayNodeType":"head"}} 2022-11-06T23:01:50.998Z INFO RayCluster-Controller Head pod container with index 0 identified as Ray container. 2022-11-06T23:01:50.998Z INFO controllers.RayCluster createHeadPod {"head pod with name": "raycluster-mini-head-"} 2022-11-06T23:01:51.024Z ERROR controller.raycluster-controller Reconciler error {"reconciler group": "ray.io", "reconciler kind": "RayCluster", "name": "raycluster-mini", "namespace": "kuberay-debug", "error": "pods \"raycluster-mini-head-wsvp7\" is forbidden: exceeded quota: test-cpu-quota, requested: limits.cpu=500m,requests.cpu=500m, used: limits.cpu=0,requests.cpu=0, limited: limits.cpu=300m,requests.cpu=200m"} sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.1/pkg/internal/controller/controller.go:266 sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2 /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.1/pkg/internal/controller/controller.go:227 2022-11-06T23:02:32.011Z INFO controllers.RayCluster reconciling RayCluster {"cluster name": "raycluster-mini"} 2022-11-06T23:02:32.017Z INFO controllers.RayCluster reconcileServices {"headService service found": "raycluster-mini-head-svc"} 2022-11-06T23:02:32.115Z INFO controllers.RayCluster reconcilePods {"creating head pod for cluster": "raycluster-mini"} 2022-11-06T23:02:32.117Z INFO RayCluster-Controller Setting pod namespaces {"namespace": "kuberay-debug"} 2022-11-06T23:02:32.117Z INFO controllers.RayCluster head pod labels {"labels": {"app.kubernetes.io/created-by":"kuberay-operator","app.kubernetes.io/name":"kuberay","groupName":"headgroup","ray.io/cluster":"raycluster-mini","ray.io/cluster-dashboard":"raycluster-mini-dashboard","ray.io/group":"headgroup","ray.io/identifier":"raycluster-mini-head","ray.io/is-ray-node":"yes","ray.io/node-type":"head","rayCluster":"raycluster-sample","rayNodeType":"head"}} 2022-11-06T23:02:32.118Z INFO RayCluster-Controller Head pod container with index 0 identified as Ray container. 2022-11-06T23:02:32.120Z INFO controllers.RayCluster createHeadPod {"head pod with name": "raycluster-mini-head-"} 2022-11-06T23:02:32.811Z ERROR controller.raycluster-controller Reconciler error {"reconciler group": "ray.io", "reconciler kind": "RayCluster", "name": "raycluster-mini", "namespace": "kuberay-debug", "error": "pods \"raycluster-mini-head-tskg9\" is forbidden: exceeded quota: test-cpu-quota, requested: limits.cpu=500m,requests.cpu=500m, used: limits.cpu=0,requests.cpu=0, limited: limits.cpu=300m,requests.cpu=200m"} sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.1/pkg/internal/controller/controller.go:266 sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2 /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.1/pkg/internal/controller/controller.go:227 2022-11-06T23:03:53.310Z INFO controllers.RayCluster reconcile RayCluster Event {"event name": "kuberay-operator-77c6cf9455-zmmtt.172520edebc5a5d2"} 2022-11-06T23:03:53.311Z INFO controllers.RayCluster pod not found or no valid annotations {"pod name": "kuberay-operator-77c6cf9455-zmmtt"} 2022-11-06T23:03:54.732Z INFO controllers.RayCluster reconciling RayCluster {"cluster name": "raycluster-mini"} 2022-11-06T23:03:54.743Z INFO controllers.RayCluster reconcileServices {"headService service found": "raycluster-mini-head-svc"} 2022-11-06T23:03:54.744Z INFO controllers.RayCluster reconcilePods {"creating head pod for cluster": "raycluster-mini"} 2022-11-06T23:03:54.744Z INFO RayCluster-Controller Setting pod namespaces {"namespace": "kuberay-debug"} 2022-11-06T23:03:54.744Z INFO controllers.RayCluster head pod labels {"labels": {"app.kubernetes.io/created-by":"kuberay-operator","app.kubernetes.io/name":"kuberay","groupName":"headgroup","ray.io/cluster":"raycluster-mini","ray.io/cluster-dashboard":"raycluster-mini-dashboard","ray.io/group":"headgroup","ray.io/identifier":"raycluster-mini-head","ray.io/is-ray-node":"yes","ray.io/node-type":"head","rayCluster":"raycluster-sample","rayNodeType":"head"}} 2022-11-06T23:03:54.745Z INFO RayCluster-Controller Head pod container with index 0 identified as Ray container. 2022-11-06T23:03:54.745Z INFO controllers.RayCluster createHeadPod {"head pod with name": "raycluster-mini-head-"} 2022-11-06T23:03:54.815Z ERROR controller.raycluster-controller Reconciler error {"reconciler group": "ray.io", "reconciler kind": "RayCluster", "name": "raycluster-mini", "namespace": "kuberay-debug", "error": "pods \"raycluster-mini-head-mbgdc\" is forbidden: exceeded quota: test-cpu-quota, requested: limits.cpu=500m,requests.cpu=500m, used: limits.cpu=0,requests.cpu=0, limited: limits.cpu=300m,requests.cpu=200m"} sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.1/pkg/internal/controller/controller.go:266 sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2 /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.11.1/pkg/internal/controller/controller.go:227 2022-11-06T23:06:38.663Z INFO controllers.RayCluster reconciling RayCluster {"cluster name": "raycluster-mini"} 2022-11-06T23:06:38.664Z INFO controllers.RayCluster reconcileServices {"headService service found": "raycluster-mini-head-svc"} 2022-11-06T23:06:38.710Z INFO controllers.RayCluster reconcilePods {"creating head pod for cluster": "raycluster-mini"} 2022-11-06T23:06:38.711Z INFO RayCluster-Controller Setting pod namespaces {"namespace": "kuberay-debug"} 2022-11-06T23:06:38.711Z INFO controllers.RayCluster head pod labels {"labels": {"app.kubernetes.io/created-by":"kuberay-operator","app.kubernetes.io/name":"kuberay","groupName":"headgroup","ray.io/cluster":"raycluster-mini","ray.io/cluster-dashboard":"raycluster-mini-dashboard","ray.io/group":"headgroup","ray.io/identifier":"raycluster-mini-head","ray.io/is-ray-node":"yes","ray.io/node-type":"head","rayCluster":"raycluster-sample","rayNodeType":"head"}} 2022-11-06T23:06:38.711Z INFO RayCluster-Controller Head pod container with index 0 identified as Ray container. 2022-11-06T23:06:38.712Z INFO controllers.RayCluster createHeadPod {"head pod with name": "raycluster-mini-head-"} 2022-11-06T23:06:39.321Z ERROR controller.raycluster-controller Reconciler error {"reconciler group": "ray.io", "reconciler kind": "RayCluster", "name": "raycluster-mini", "namespace": "kuberay-debug", "error": "pods \"raycluster-mini-head-5ddnc\" is forbidden: exceeded quota: test-cpu-quota, requested: limits.cpu=500m,requests.cpu=500m, used: limits.cpu=0,requests.cpu=0, limited: limits.cpu=300m,requests.cpu=200m"} Thanks! Closing this, then. But it would be nice to get https://github.com/ray-project/kuberay/pull/639 merged... Would you mind trying it out again with that PR branch? Do you see the issue reported by the author? PR branch operator can be deployed by checking out the branch cd'ing to kuberay/ray-operator running the following commands IMG=gekho/kuberay-operator make docker-build && docker push gekho/kuberay-operator IMG=gekho/kuberay-operator make deploy substituting the relevant image name.
gharchive/issue
2022-11-04T17:07:24
2025-04-01T06:45:35.671284
{ "authors": [ "DmitriGekhtman", "sihanwang41" ], "repo": "ray-project/kuberay", "url": "https://github.com/ray-project/kuberay/issues/686", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
680185151
Add discrimination and rank_histogram to probabilistic metrics Description Add the discrimination and rank_histogram probabilistic metric to probabilistic.py Type of change [x] New feature (non-breaking change which adds functionality) How Has This Been Tested? Added tests to test_probabilistic.py for numpy and dask back-ended DataArrays and Datasets. Also added test to test_accessor_probabilistic.py Checklist (while developing) [x] I have added docstrings to all new functions. [x] I have commented my code, particularly in hard-to-understand areas [x] Tests added for pytest, if necessary. Pre-Merge Checklist (final steps) [ ] I have rebased onto master or develop (wherever I am merging) and dealt with any conflicts. [ ] I have squashed commits to a reasonable amount, and force-pushed the squashed commits. Also ready for review. Apologies, but this includes the commits from #134 as well, because I built on some of the methods implemented there. May be easiest just to review both rank_histogram and discrimination together in this PR... so now the metrics all take bin edges rather than bin centers? Apologies for the conflicts. May want to move the stuff that went into the README.rst into the https://github.com/raybellwaves/xskillscore/blob/master/docs/source/quick-start.ipynb so now the metrics all take bin edges rather than bin centers? Good to have this aligned if possible Yup - all take bin edges How should I go about updating the readthedocs to include these metrics? Should I manually edit the appropriate files in https://github.com/raybellwaves/xskillscore/blob/master/docs/source, or is this automated somehow? First add the new functions in api.rst. Then... If you are adding new functions to the API, run sphinx-autogen -o api api.rst from the docs/source directory and add the functions to api.rst. https://github.com/raybellwaves/xskillscore/blob/master/HOWTOCONTRIBUTE.rst But we need to add .egg to .gitignore All these setuptools and scm files shouldn't be there I usually do cat ci/run_linter.sh and do those checks manually to see why travis fails. we are close to merging this also Let me know when you're happy and I'll clean up all the commits Let me know when you're happy and I'll clean up all the commits - this one got kinda messy I just did a squash commit where all commits are collapsed into one. Thanks for adding these two new metrics @dougiesquire
gharchive/pull-request
2020-08-17T12:07:47
2025-04-01T06:45:35.777673
{ "authors": [ "aaronspring", "dougiesquire", "raybellwaves" ], "repo": "raybellwaves/xskillscore", "url": "https://github.com/raybellwaves/xskillscore/pull/136", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
2320084807
MenuBarExtra font size and color Description would be awesome to be able to set the font size and color of the title text in the menubar Who will benefit from this feature? No response Anything else? idea from: https://bjango.com/mac/istatmenus/ I Second this.
gharchive/issue
2024-05-28T04:15:31
2025-04-01T06:45:35.779653
{ "authors": [ "that70schris", "yam-liu" ], "repo": "raycast/extensions", "url": "https://github.com/raycast/extensions/issues/12610", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
1193813962
[Music] ... Extension – Music Author: @Rawnly Description "Search & Play Library Album" for albums with the same title groups the albums together. Steps To Reproduce Add albums with the same name, case insensitive. Example: STAY - Single by The Kid LAROI & Justin Bieber Stay - Single by Zedd and Alessia Cara "Search & Play Library Album" for "stay" The current behavior Trying to play Stay by Zedd, but plays STAY by The Kid LAROI instead. Stay by Zedd doesn't appear in the list. Instead, the album lists as having 🎧2 songs The expected behavior Show Stay by Zedd as well as STAY by the Kid LAROI Raycast version Version: 1.31.0 same as #1294 Unfortunately this can't be fixed. There's no specific API from Apple Music to retrieve the Album ID and play it. Right now the extension uses a workaround which duplicates the songs filtered by album name and adds them to a temporary playlist.
gharchive/issue
2022-04-05T22:54:59
2025-04-01T06:45:35.784498
{ "authors": [ "Rawnly", "naokiiida" ], "repo": "raycast/extensions", "url": "https://github.com/raycast/extensions/issues/1295", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
1837639900
Option to set default, favourite devices to run by default. Extension https://www.raycast.com/zcfan/scrcpy Description Right now whenever I run an extension I need to select the device always, is there any way I can set the default device to run to skip device selection each time? Who will benefit from this feature? No response Anything else? No response Implemented default selection by moving the dropdown item to the top of the devices list. 😉 @krishnaar21 I didn't provide a "default device" setting, instead I'll always select previous device automatically. I believe this is a better solution than manually specify a default devcie.
gharchive/issue
2023-08-05T08:08:28
2025-04-01T06:45:35.787450
{ "authors": [ "krishnaar21", "zcfan" ], "repo": "raycast/extensions", "url": "https://github.com/raycast/extensions/issues/7805", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
1174651259
Add "IATA Code Decoder" extension Description This PR introduces a new Raycast extension, IATA Code Decoder, for decoding IATA codes for airports, airlines and aircraft. The extension contains a command for airports, a command for airlines and a command for aircraft. When you enter an IATA code, it'll tell you what that code refers to (for example, the airport code SFO refers to San Francisco International Airport). It includes typeahead functionality to give helpful suggestions - for example, when you enter 77 as an aircraft code, it'll show you all aircraft with codes beginning in 77 - the Boeing 77- family. The data is sourced from a bespoke API. Screencast See the screencast on Loom Checklist [x] I read the extension guidelines [x] I read the documentation about publishing [x] I ran npm run build and tested this distribution build in Raycast [x] I checked that files in the assets folder are used by the extension itself [x] I checked that assets used by the README are placed in the metadata folder Request a new review when you are ready, feel free to contact me here or at Slack if you have any questions. Thanks ❤️ Good to go! Hi @timrogers 👋 How often do you expect the data to change? I can see you have some GitHub actions taking care of the data as it is right now (but they seem to fail with error 401). If data don't change very frequently, could it then be an idea to just make a new PR with the data instead? 👋 They don't change very frequently, but I'd rather not be responsible for keeping the Raycast repo up to date when they do. Can we stick with the API, and I'll fix the GitHub Actions? I just haven't configured the secret.
gharchive/pull-request
2022-03-20T19:03:53
2025-04-01T06:45:35.794527
{ "authors": [ "pernielsentikaer", "timrogers" ], "repo": "raycast/extensions", "url": "https://github.com/raycast/extensions/pull/1153", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
1838335845
Add kotobaten extension Description Screencast Checklist [ ] I read the extension guidelines [ ] I read the documentation about publishing [ ] I ran npm run build and tested this distribution build in Raycast [ ] I checked that files in the assets folder are used by the extension itself [ ] I checked that assets used by the README are placed outside of the metadata folder Hi @jankratochvilcz 👋 I don't think the current way to log in works, maybe you could set username and password in preferences instead?
gharchive/pull-request
2023-08-06T19:29:12
2025-04-01T06:45:35.798336
{ "authors": [ "jankratochvilcz", "pernielsentikaer" ], "repo": "raycast/extensions", "url": "https://github.com/raycast/extensions/pull/7817", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
479415018
Test our manual concurrency with loom https://crates.io/crates/loom Loom is a model checker for concurrent Rust code. It exhaustively explores the behaviors of code under the C11 memory model, which Rust inherits. It would be nice to test some of our manual synchronization -- pretty much anywhere we manipulate atomics as barriers to any other data. For our part, we don't need to worry about the correctness of stuff like crossbeam, though they might like to take a look at loom for their own testing... Ah, glad to see you opened this issue. I'm pretty excited about loom. I talked to @seanmonstar about how to do the integration at RustConf and it seemed straight forward.
gharchive/issue
2019-08-11T21:33:37
2025-04-01T06:45:35.815781
{ "authors": [ "cuviper", "nikomatsakis" ], "repo": "rayon-rs/rayon", "url": "https://github.com/rayon-rs/rayon/issues/680", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
2259965475
Need to fix unicode input on GuiTextBox gui textbox doesn't handle adding and removing characters properly and causes an underflow (at adding) and overflow (at removal) at lines https://github.com/raysan5/raygui/blob/6f532337ff2d6dc14ba3a5f5b7ee63f9d90ff13b/src/raygui.h#L2582 https://github.com/raysan5/raygui/blob/6f532337ff2d6dc14ba3a5f5b7ee63f9d90ff13b/src/raygui.h#L2562C21-L2562C113 you are just comparing the variable i with the text length or cursor when you really need to >= cursor+codepointsize and <= length-codepointsize @electrolys Good catch! Feel free to send a PR to fix it! It seems there is no interest in this fix...
gharchive/issue
2024-04-23T23:53:27
2025-04-01T06:45:35.821168
{ "authors": [ "electrolys", "raysan5" ], "repo": "raysan5/raygui", "url": "https://github.com/raysan5/raygui/issues/399", "license": "Zlib", "license_type": "permissive", "license_source": "github-api" }
651125135
Skin implementation wip This is a initial implementation addressing issue #82 as you can see it really doesn't complicate the code that much. Still a work in progress and any feedback is appreciated. It can also use existing color styles (if useColor is set to true) in the screenshot i used candy.rgs, just drag & drop a style file in the window to try as i've modified controls_test_suite.c. There's also functions to save a skin GuiSaveSkin(), GuiSaveSkinEx() and load to load a skin GuiLoadSkin() i tried to copy the rgs file format as much as possible. A skin file can hold multiple skin styles each with their own id. This is a lot to take in all at once so before merging extensive testing is required i'm sure there are some bugs. Creating a skin manually is still somewhat hard so i planed to write a skin editor but i'm leaving tomorrow and don't have time :( Unfortunately that also means i won't be able to work on this for at least 1-2 months, sorry :( I understand if you'll hold on merging this, so no problems here :) This a big addition and no plans for the moments to add it... but result is really impressive... I'll take a closer look when I could... Closing this! Will send another pull request tested on latest raylib/raygui, also including a skin editor.
gharchive/pull-request
2020-07-05T18:54:41
2025-04-01T06:45:35.824312
{ "authors": [ "Demizdor", "raysan5" ], "repo": "raysan5/raygui", "url": "https://github.com/raysan5/raygui/pull/98", "license": "Zlib", "license_type": "permissive", "license_source": "github-api" }
331881596
[rlgl] Support texture coordinates for triangles buffer Binding textures using rlgl functions seems to only be available for RL_QUADS. Would be nice to have for RL_TRIANGLES in the future. Why do you need this feature? In those specific cases, is not better to just use your own Mesh data? Actually, I was thinking about removing the RL_TRIANGLES internal buffer... I already implemented this in my own version of rlgl and haven't gotten a chance to write a pull request. The performance difference with mesh structs is insane. Meshes dropped framerates down to 15-25 fps while using the rlgl functions was as high as 700. The problem is Mesh (maybe it's Model) structs have their own VAO that needs to be bound every time you draw one creating insane performance loss. Wow! That's super weird! Actually, it should be the other way round! Mesh static data is preloaded in VRAM while using rlgl, data is created... and uploaded! in a per-frame basis! In both cases VAOs (mesh.vao/buffer vao) are enabled/disabled on drawing. Do you have a test case for profiling? I don't have a test case. Maybe I didn't look into it enough but I still think it has to do with the single VAO versus the numerous VAOs from the 5k or so triangle meshes I had to generate to get the same result. The work flow for Mesh objects would have been Bind VAO Draw single triangle to VAO Send data to GPU for every single triangle mesh. but manually using the triangles buffer would be more like Bind VAO Draw triangle to VAO Draw triangle to VAO Draw triangle to VAO ... and so on ... Send data to GPU Uploading all the triangles to a single mesh would cause them to be connected together strangely so that wasn't an option. Hey @TheLumaio, just reviewing all bugs and I found I didn't answer you here, sorry. Actually both mechanisms are pretty similar. A public Mesh struct is almost the same as a DynamicBuffer rlgl internal struct. Main difference is that Mesh is filled and managed by the user while DynamicBuffer is filled and managed internally by raylib. DynamicBuffer is refilled per-frame while Mesh could be filled only once at beginning, consequently being more performant because you're not uploading data to the GPU every frame. In both cases, you always need to bound the respective VAO before drawing. Out of curiosity, what's your reasoning for removing the triangles buffer? Performance? or something else? That's because currently rlgl manages internally 3 DynamicBuffers (LINES, TRIANGLES, QUADS), that results in a number of issues. Managing a single internal DynamicBuffer would solve some of those issues and simplify the code. Supported by commit https://github.com/raysan5/raylib/commit/97e40ced57489f4d66d4b9bc9fe213c388e1a827.
gharchive/issue
2018-06-13T07:54:18
2025-04-01T06:45:35.831846
{ "authors": [ "TheLumaio", "raysan5" ], "repo": "raysan5/raylib", "url": "https://github.com/raysan5/raylib/issues/556", "license": "Zlib", "license_type": "permissive", "license_source": "github-api" }
2023146461
Use System SDL2 As Failsafe Attempt #2, but correctly solving it this time! (Until SDL3, where you don't have to worry about this, because they decided to then do it like every other library ever) The code works, I tested (except the SDL_LIBRARY_PATH but should just work the same). On Windows this doesn't do anything because I don't know if shell works the same there. Other than that, if there are issues with the code/looks bad, tell me. @mr-sihc Sorry, I can't see the need for those additions. It adds a considerable level of complexity to the Makefile to support a specific use case. it's not actually very specific, SDL is not built standard and anyone who wants to, has to clone it, or change the dir What's the purpose of the shell if statement? to check if the SDL_... path is not there, so to activate the failsafe @mr-sihc I wouldn't bother checking
gharchive/pull-request
2023-12-04T06:46:27
2025-04-01T06:45:35.834715
{ "authors": [ "Peter0x44", "mr-sihc" ], "repo": "raysan5/raylib", "url": "https://github.com/raysan5/raylib/pull/3602", "license": "Zlib", "license_type": "permissive", "license_source": "github-api" }
2706219479
I've created bindings for raylib 5.5 for c3-lang at https://c3-lang.org I've added url and info for raylib 5.0 and raylib 5.5 bindings for c3-lang I'm merging and reviewing it...
gharchive/pull-request
2024-11-29T21:32:28
2025-04-01T06:45:35.836006
{ "authors": [ "devdad", "raysan5" ], "repo": "raysan5/raylib", "url": "https://github.com/raysan5/raylib/pull/4555", "license": "Zlib", "license_type": "permissive", "license_source": "github-api" }
1272923749
Keybinds for switching save slots? Are more features planned for this? Shortcuts for save slots and changing between the waveforms to make them faster to use would be great. Otherwise maybe undo option? @return2monki Shortcuts can be added. I'm adfing them for next version. Thanks, I reported some bugs and a suggestion that would be great before next release. I didn't test it thoroughly yet so I might be missing other problems. I'll close this one now.
gharchive/issue
2022-06-16T01:04:27
2025-04-01T06:45:35.837452
{ "authors": [ "raysan5", "return2monki" ], "repo": "raysan5/rfxgen", "url": "https://github.com/raysan5/rfxgen/issues/23", "license": "Zlib", "license_type": "permissive", "license_source": "github-api" }
427543285
列表子布局设置居中,显示结果向右偏移 系统版本:8.0 库版本:Release 2.1.9 问题描述/重现步骤:RecyclerView 子布局 TextView,设置宽度 match_parent,并设置文本居中,在小米8和模拟器 Pixel 2 XL 中显示结果文本向右偏移,在华为 nova 3e 中显示正常,更换为 Candy 2.2.0 并调用 setMaxWidth(screenWidth) 后,均显示正常 问题代码/截图: <?xml version="1.0" encoding="utf-8"?> <TextView xmlns:android="http://schemas.android.com/apk/res/android" android:id="@+id/tv" android:layout_width="match_parent" android:layout_height="36dp" android:gravity="center" android:background="@color/white" android:textSize="15dp" /> `class FinanceFilterPopup(context: Context, val data: List) : BasePopupWindow(context, true) { private val mAdapter by lazy { PopupContentAdapter(R.layout.item_finance_filter, data) } private var mOnItemClickListener: ((Int) -> Unit)? = null private lateinit var recyclerView: RecyclerView override fun onCreateContentView(): View { val view = createPopupById(R.layout.view_finance_filter) recyclerView = view.findViewById(R.id.recyclerView) mAdapter.setOnItemClickListener { _, _, position -> mOnItemClickListener?.invoke(position) } recyclerView.run { layoutManager = LinearLayoutManager(context) adapter = mAdapter addItemDecoration(DividerItemDecoration(context, DividerItemDecoration.VERTICAL)) } return view } fun setOnItemClickListener(listener: (Int) -> Unit): FinanceFilterPopup { mOnItemClickListener = listener return this } init { delayInit() } }` if (mDateFilterPopup == null) { val list = arrayListOf("今天", "近7天", "近30天") mDateFilterPopup = FinanceFilterPopup(context, list).apply { setOnItemClickListener { position -> when (position) { 0 -> mEntity.A_OrderDate = "0" 1 -> mEntity.A_OrderDate = "1" else -> mEntity.A_OrderDate = "2" } tvFilterDate.text = list[position] if(position != list.lastIndex)requestDataWithResetStatus() dismiss() } popupGravity = Gravity.BOTTOM or Gravity.CENTER_HORIZONTAL setBackgroundColor(0) } } mDateFilterPopup?.showPopupWindow(filterConditions) 报错信息: rv的父布局呢,是match_parent么 rv的父布局呢,是match_parent么 是的,漏了说明 rv,抱歉 有用头条的适配么 用了 本库不适配头条适配方案。。。。 好的,谢谢 兄弟 最后怎么解决的 兄弟 最后怎么解决的 //不设置会让内容向右偏移 int width = ArmsUtils.getScreenWidth(mContext); getPopupWindow().setWidth(width); 初始化里面 设置宽度 ------------------ 原始邮件 ------------------ 发件人: "yoyiyi(soleil雪寂)"notifications@github.com; 发送时间: 2019年7月28日(星期天) 晚上7:57 收件人: "razerdp/BasePopup"BasePopup@noreply.github.com; 抄送: "李垚"245937033@qq.com;"Comment"comment@noreply.github.com; 主题: Re: [razerdp/BasePopup] 列表子布局设置居中,显示结果向右偏移 (#169) 兄弟 最后怎么解决的 — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.
gharchive/issue
2019-04-01T07:03:32
2025-04-01T06:45:35.852427
{ "authors": [ "LeeeeeYao", "Yifpro96", "razerdp", "yoyiyi" ], "repo": "razerdp/BasePopup", "url": "https://github.com/razerdp/BasePopup/issues/169", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
1190980997
Some items are shown in menu and footer even after menu.toml is empty Describe the bug After emptying config\_default\menu.toml and rebuilding site, some items are still shown in the dropdown menu and the footer. To Reproduce Steps to reproduce the behavior: Create an example site like described at https://hbs.razonyang.com/en/docs/installation/hugo-module/ Edit file config\_default\menu.toml and delete all content (but leave the file on disk) Rebuild the site Expected behavior Dropdown menu in header doesn't exist. Footer menu doesn't exist. Screenshots Hugo version: $ hugo version hugo v0.96.0-2fd4a7d3d6845e75f8b8ae3a2a7bd91438967bbb+extended windows/amd64 BuildDate=2022-03-26T09:15:58Z VendorInfo=gohugoio Theme version: $ cd themes/hugo-theme-bootstrap $ git log -n 1 --decorate --pretty=oneline 69144efc9f264380f7a01e151e5ddbcee537cc6e (HEAD -> master, tag: v0.74.0, origin/master, origin/HEAD) fix(viewer): filter the linkable picture tags Desktop (please complete the following information): OS: Windows 10 Browser Firefox Version 98.0.2 There are multiple ways to configure menus, you need to remove the menu from front matter as well. See also https://hbs.razonyang.com/en/docs/menu/
gharchive/issue
2022-04-03T16:40:52
2025-04-01T06:45:35.859365
{ "authors": [ "TheJavaGuy", "razonyang" ], "repo": "razonyang/hugo-theme-bootstrap", "url": "https://github.com/razonyang/hugo-theme-bootstrap/issues/500", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
1089890391
Text Functionality Canvas Is there a way to add text to the vue drawing canvas? If not is there a way to add it to the canvas? I tried to add in the canvas but when I suddenly tried to draw on it the text was instantly removed. You can add text to canvas for watermark, or you can convert your text as image then use it as bg image Hi, I really do want this functionality to have it since it completes the whole concept of my whiteboard functionality if there is a way other than a watermark like a start entering text on the point you just clicked something like. If you are having trouble with it maybe I'll do it, you could let me know. sure, PR are very welcome. can you explain what you gonna do?
gharchive/issue
2021-12-28T13:17:22
2025-04-01T06:45:35.864796
{ "authors": [ "Sovaidsyed", "razztyfication" ], "repo": "razztyfication/vue-drawing-canvas", "url": "https://github.com/razztyfication/vue-drawing-canvas/issues/9", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
2546282317
PPKG Fails to Install - Error Code 0x800700b7 Getting "Provisioning Failure" during OOBE. Setup completes up until this point fine, and the device shows up in Azure but not in Intune. Under advisement from Microsoft, installed from a clean, vanilla windows 11 drive (not the FFU deployment) and escaped the OOBE using the instructions detailed here without setting up using a Microsoft account, as I want the provisioning package to handle that aspect. Once inside Windows, the PPKG installs just fine and reboots, and finishes the OOBE with the device showing up both in Azure and Intune. This leads me to believe it may be an issue with how the this process is handling the PPKG, but Microsoft refuses to help troubleshoot this particular issue as your project is not officially supported by Microsoft. They were willing to troubleshoot the PPKG, but seeing as it works with a vanilla install, I don't see that going anywhere. Do you get a provisioning failure during OOBE with a vanilla image (not bypassing OOBE)? I will find out in the AM when our depot tech is in the office. Thanks for your prompt response. I can say that I have noticed random PPKG failures even with stock ISOs in Hyper-V when testing. Sometimes it's just a matter of trying again. I've also seen issues with the network stack not being available right away when it tries to Azure AD/Entra ID join, so it doesn't join wireless in time and then it fails. In a partial answer to your question, it does not error out in OOBE in a vanilla install in a VM. It didn't configure it correctly, but I attribute that to not paying much attention to it while it was going on, or maybe what you just posted about trying again. But it doesn't error out. @rbalsleyMSFT It produces the same error on a vanilla install when applied via OOBE. It was an issue with the PPKG. It is now functioning normally.
gharchive/issue
2024-09-24T20:07:48
2025-04-01T06:45:35.868687
{ "authors": [ "rbalsleyMSFT", "robzilla10001" ], "repo": "rbalsleyMSFT/FFU", "url": "https://github.com/rbalsleyMSFT/FFU/issues/85", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
254570163
Add missing on_delete on GenericLastTransitionLog model There was still a on_delete attribute, missing on GenericLastTransitionLog. Note: I didn't find any migration for this model. Indeed: it's an abstract model ;)
gharchive/pull-request
2017-09-01T08:23:20
2025-04-01T06:45:35.870037
{ "authors": [ "dzen", "rbarrois" ], "repo": "rbarrois/django_xworkflows", "url": "https://github.com/rbarrois/django_xworkflows/pull/28", "license": "bsd-2-clause", "license_type": "permissive", "license_source": "bigquery" }
136733282
Missing Workshop option I can't seem to find the workshop anywhere in the start menu. It's getting annoying that I have to uninstall budhud everytime I wanna use the workshop. Res: 2560x1440 OS: Windows 8.1 Added in the next version of the hud, I'll close this when I commit the update. :) Very nice !
gharchive/issue
2016-02-26T15:51:41
2025-04-01T06:45:35.921743
{ "authors": [ "SaintGamingston", "rbjaxter" ], "repo": "rbjaxter/budhud", "url": "https://github.com/rbjaxter/budhud/issues/97", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
922203572
ED-242: erlang 24 ожидаем релиз jose с поддержкой erlang 24 сервисный образ не собрался, а так ок ты про image-service-erlang? там исчерпалось количество запросов или что-то в этом духе. сервисный образ не собрался, а так ок ты про image-service-erlang? там исчерпалось количество запросов или что-то в этом духе. Да, жду, когда devops починят.
gharchive/pull-request
2021-06-16T07:28:31
2025-04-01T06:45:35.923612
{ "authors": [ "dinama", "kpy3" ], "repo": "rbkmoney/lechiffre", "url": "https://github.com/rbkmoney/lechiffre/pull/10", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
2614338281
Create express_codespaces_guide.md For issue #724 Please translate the title of the lesson into Urdu as well. As well the words of the title is separated by a dash (-) not an underscore (_) okey @rcallaby
gharchive/pull-request
2024-10-25T14:53:14
2025-04-01T06:45:35.938485
{ "authors": [ "aniruddhaadak80" ], "repo": "rcallaby/Learn-Git", "url": "https://github.com/rcallaby/Learn-Git/pull/749", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
202056703
contrib/scripts/magnum.sh doesn't verify if echo to setup-openstack.yml is needed Do NOT include any confidential information, this issue will be created on a public repo This section is completed by the issue reporter On which version(s) do you encounter this issue? Please provide the output to 'git describe --all' for all deployments where you have confirmed it occurs. git describe --all r13.1.3 What type of issue is this? Please tick the appropriate box. [ x] bug - existing functionality that does not work for you as documented [ ] feature - new functionality that you would like to see added What is the expected behavior? Rerunning deploy.sh doesn't result in multiple '- include: os-magnum-install.yml' being added to setup-openstack.yml What is actually happening? On each deploy.sh run, contrib/scripts/magnum.sh is adding '- include: os-magnum-install.yml' to setup-openstack.yml resulting in multiple lines. root@shane-mitaka:/opt/rpc-openstack/contrib/scripts# grep -n 'echo' magnum.sh 60: echo "- include: os-magnum-install.yml" >> $OA_DIR/playbooks/setup-openstack.yml root@shane-mitaka:/opt/rpc-openstack/openstack-ansible/playbooks# grep magnum setup-openstack.yml - include: os-magnum-install.yml - include: os-magnum-install.yml magnum.sh needs something like a grep for magnum in setup-openstack.yml and echo or not based on return code. What were you attempting to do when you encountered this error (give as much detail as possible)? Ran deploy.sh multiple times How can we reproduce this issue? Run deploy.sh multiple times How can we verify your issue is addressed? Running deploy.sh doesn't result in multiple magnum entries in setup-openstack.yml If you are using or know of a workaround please describe the necessary steps? Remove extra magnum lines from setup-openstack.yml What is your evaluation on the importance of this issue, and why? Low This section is completed during the issue resolution process. If you are reporting an issue, please do not modify the section below. Which branches are impacted by this issue? Remove branches that are not impacted. For each pull request, update the branch line to reference it. [ ] master [ ] mitaka-13.1 [ ] liberty-12.2 [ ] kilo Upgrade impact. Consider the impact on moving between major, minor and patch releases. [ ] This change does not impact upgrades [ ] This change addresses a potential upgrade impact [ ] The upgrade impact is being tracked by another issue. The issue tracking the upgrade impact is: Testing impact [ ] An issue/pull-request has been create or exists to track the testing gap, and is referenced below [ ] This change includes additional testing [ ] This change is tested by the existing setup Additional testing links: Release note [ ] This change includes a release note. [ ] This change does not require a release note. Doc Impact Does your change require documentation? [ ] Yes, and I submitted an issue to Docs issues [ ] Yes, and I contributed a documentation patch to docs-rpc [ ] No documentation required for this change Additional documentation links (please add links if you have ticked yes): cc @chrishultin See https://github.com/rcbops/rpc-openstack/pull/1720 Merged
gharchive/issue
2017-01-20T05:45:35
2025-04-01T06:45:35.951370
{ "authors": [ "alextricity25", "chrishultin", "shane-c" ], "repo": "rcbops/rpc-openstack", "url": "https://github.com/rcbops/rpc-openstack/issues/1695", "license": "apache-2.0", "license_type": "permissive", "license_source": "bigquery" }
172125756
Add the RPC plays for upgrading Take the playbooks that were called as part of the old rpc-upgrade.sh script and add them to the run-upgrade.yml playbook as includes. Additionally, there is a final task that was run as part of the script that should now run against "hosts" after the logging is setup. Connects https://github.com/rcbops/u-suk-dev/issues/298 This seems to be breaking out deploy.sh, while the card does imply that I'm not sure this was every explicitly discussed. Deconstructing deploy.sh is a lot of extra work, this is probably worth some discussion in our meeting later. recheck_swift
gharchive/pull-request
2016-08-19T12:57:41
2025-04-01T06:45:35.954696
{ "authors": [ "andymcc", "git-harry", "hughsaunders" ], "repo": "rcbops/rpc-openstack", "url": "https://github.com/rcbops/rpc-openstack/pull/1340", "license": "apache-2.0", "license_type": "permissive", "license_source": "bigquery" }
109382066
Add task to restart lsync after repo-build (cherry picked from commit 4d43151a01a725c5dc608fea224123404520fa1d) :+1: -1, you've cherry picked the wrong commit. You need to cherry pick 5bd4eee9f8e6d018182ee391acec77e3cea6a347 Good catch, thanks @git-harry
gharchive/pull-request
2015-10-01T20:55:44
2025-04-01T06:45:35.956740
{ "authors": [ "d34dh0r53", "git-harry", "prometheanfire" ], "repo": "rcbops/rpc-openstack", "url": "https://github.com/rcbops/rpc-openstack/pull/434", "license": "apache-2.0", "license_type": "permissive", "license_source": "bigquery" }
135876752
Catch ConfigParser.NoSectionError when reading config file. Fixes #848 (cherry picked from commit 5956c0414f79ae81d9e94784c26fe9a536a639bc) recheck :+1: :shipit: -1 Has this been validated by QE? We can only merge code into this branch if QE have identified it as an issue. :+1: Who from QE should we have confirm this passes okay?
gharchive/pull-request
2016-02-23T21:49:04
2025-04-01T06:45:35.958812
{ "authors": [ "d34dh0r53", "git-harry", "prometheanfire", "sigmavirus24", "tomc603" ], "repo": "rcbops/rpc-openstack", "url": "https://github.com/rcbops/rpc-openstack/pull/860", "license": "apache-2.0", "license_type": "permissive", "license_source": "bigquery" }
1315818967
🛑 RESET Assessment is down In 3e8cfca, RESET Assessment (https://assessment.reset.build) was down: HTTP code: 0 Response time: 0 ms Resolved: RESET Assessment is back up in 1e9934d.
gharchive/issue
2022-07-24T06:06:14
2025-04-01T06:45:36.046402
{ "authors": [ "serco-chen" ], "repo": "rdd-giga/reset-status-page", "url": "https://github.com/rdd-giga/reset-status-page/issues/17", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
1964481220
Remove deep clone comparison I don't think these comparisons are required by the spec? Impls may prefer to cache the components of a quad. I think it should be up to user if they want to do a deep clone. https://github.com/rdfjs-base/data-model/blob/c9c388f891e87ae8e690cd1b87f4ce2bfe9774ba/test/fromQuad.test.js#L22-L25 You are right. I would expect that one calls the method to get an object that has all features of the factory (Term + Quad), but the spec leaves that open. You want to create a PR? fixed in #44
gharchive/issue
2023-10-26T22:48:30
2025-04-01T06:45:36.050925
{ "authors": [ "bergos", "blake-regalia" ], "repo": "rdfjs-base/data-model", "url": "https://github.com/rdfjs-base/data-model/issues/41", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
1768530988
fix: Base theme radii Description Update corner radii of Base theme to be non-zero and adjust snapshots and tests accordingly. References Testing Check out the Theming Tokens story and confirm that the corner radius icons at the right now have values. Components like the Tile and Button should also be more rounded now. Automation Checklist [ ] all commented code has been removed [ ] any new console issues have been resolved [ ] code linter and formatter has been run [ ] test coverage meets repo requirements [ ] PR name matches the expected semantic-commit syntax Sanity Tests Execution Failed. Sanity Tests Execution Failed. Sanity Tests Execution Failed. :tada: This PR is included in version @lightningjs/ui-components-theme-base-v1.0.2 :tada: The release is available on: npm package (@latest dist-tag) GitHub release Your semantic-release bot :package::rocket: :tada: This PR is included in version @lightningjs/ui-components-v2.4.1 :tada: The release is available on: npm package (@latest dist-tag) GitHub release Your semantic-release bot :package::rocket:
gharchive/pull-request
2023-06-21T21:33:50
2025-04-01T06:45:36.060427
{ "authors": [ "erautenberg", "svc-lightning-ui-components" ], "repo": "rdkcentral/Lightning-UI-Components", "url": "https://github.com/rdkcentral/Lightning-UI-Components/pull/256", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
1303234338
RDK-37251: Thunder R2-v1.11 upgrade (Bug Fixes) Reason for change: Change the library version to match release tag Test Procedure: Build and verify. Risks: Low Signed-off-by:Zameerun Rasheed M S zexpen@gmail.com WARNING: A Blackduck scan failure has been waived A prior failure has been upvoted Upvote reason: R2 Commit: 9d920250b81fb4872f79d1af5689fbc0b11477bf
gharchive/pull-request
2022-07-13T10:27:14
2025-04-01T06:45:36.062782
{ "authors": [ "rdkcmf-jenkins", "zrash" ], "repo": "rdkcentral/Thunder", "url": "https://github.com/rdkcentral/Thunder/pull/1023", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
500800614
Hal API's Changes for Constraint Violation in Opensync Table Signed-off-by: Rajakumaran1106 rajakumaran.a@ltts.com Looks good to me.
gharchive/pull-request
2019-10-01T10:17:42
2025-04-01T06:45:36.063840
{ "authors": [ "Rajakumaran1106", "manigandanj" ], "repo": "rdkcentral/rdkb-turris-hal", "url": "https://github.com/rdkcentral/rdkb-turris-hal/pull/12", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
2640348753
DELIA-66586: WPEFramework crash with signature "WPEFramework::Plugin:… …:Packager::Deinitialize" Reason for Change: Fixed the packager plugin failed crash issue. Test Procedure: Refer the ticket Priority: P1 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.
gharchive/pull-request
2024-11-07T09:06:02
2025-04-01T06:45:36.066983
{ "authors": [ "CLAassistant", "Shiva367" ], "repo": "rdkcentral/rdkservices", "url": "https://github.com/rdkcentral/rdkservices/pull/5852", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
947852239
RDKTV-9120 : No Xcast post FTUE Reason for change: No Xcast post FTUE Test Procedure: None Risks: Low Change-Id: I1a2953aa840c163559d267f2005036e8bda7c3c2 Signed-off-by:Anooj Cheriyan Anooj_Cheriyan@comcast.com based on review comments taking : https://github.com/rdkcentral/xdialserver/pull/15
gharchive/pull-request
2021-07-19T17:05:00
2025-04-01T06:45:36.069189
{ "authors": [ "acheri988" ], "repo": "rdkcentral/xdialserver", "url": "https://github.com/rdkcentral/xdialserver/pull/16", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
226311674
Help :-) Hi @jeffwannamaker, Let me introduce myself, I'm working as an embedded engineer at Metrological. For my current project, I was asked to check if I could integrate Westeros into WPEFramework. This way I was hoping to get control of the compositing through Javascript. Is there a way that you can provide me with some information how Westeros is setup? Now I'm looking into westeros-main but I'm a bit lost. What do I need of Westeros to get started? Is there a way we can get in contact for a small introduction? Regards, Bram Hi Bram, Pleased to meet you. The minimum setup for a Westeros compositor instance would be the following sequence: WstCompositorCreate, WstCompositorSetRendererModule, WstCompositorSetDisplayName, WstCompositorStart You create a compositor, you configure it, and then you start it. When you start the compositor instance running by calling WstCompositorStart it will spawn a thread that runs the compositor and then returns. The minimum configuration is specifying the render module to use. The two main options available on all platforms are libwesteros_render_gl.so and libwesteros_render_embedded.so. The gl render module would be used if the compositor is rendering to the screen, while the embedded render module is used if the compositor's composed output frames are gong to be incorporated into the application's (the process creating the compositor) UI. If you don't specify a display name, a unique name will be generated which you can query after starting the compositor with WstCompositorGetDisplayName. How does your goal of integrating Westeros into WPEFramework relate to the current WPE westeros backend? WPEFramework will be the extended version of WPELauncher, it is plugin based and event driven. So WPE will still be using the Westeros backend, its lifetime will be in control of WPEFramework through a pluggable library. WPEFramework enables you to control the browser instances using WebSockets. Now it has also the plugins to synchronise time, get an identifier start a web server do provisioning and so on. My goal is to be able to control the composition of the Wayland clients over WebSockets using WPEFramework. I want to use the WPEFramework events to start WPE as soon as a Wayland server is started. Therefore I also need control of the lifetime of Westeros. This way we can eliminate the use of init scripts and start WPE as fast as possible. Also, I want to be able to control the z-order and window geometry. So I guess I will ask some more questions along the way. Hello Jeff, I'm a colleague of Bram, also working on westeros. The difference is that I'm trying to get it to work on Ubuntu, so I'm using the drm backend. In the drm backend there is a call to find the actual provider of eglGetDisplay: gRealEGLGetDisplay= (PREALEGLGETDISPLAY)dlsym( RTLD_NEXT, "eglGetDisplay" ); In my case this always return null, probably because libEGL is linked before libwesteros_gl. Isn't there a better / more reliable way to get this function pointer than simple scanning the next shared lib? Hi Rene, We use the files in the Westeros drm folder for some embedded systems like HiKey. The way we run Westeros on Ubuntu is to build Westeros with WESTEROS_PLATFORM_EMBEDDED not defined and with WESTEROS_HAVE_WAYLAND_EGL defined, and make sure the Ubuntu environment has EGL and Wayland-EGL support (usually via Mesa) installed. When Makefile.ubuntu is used to build for Ubuntu Wayland-EGL will be detected causing WESTEROS_HAVE_WAYLAND_EGL to be defined. The use of dlsym with RTLD_NEXT finds the first occurrence of the specified symbol following the normal library search order, excluding the calling module. For this to work a library must have already been loaded that supplies the symbol. This is the method for providing a wrapper for a method supplied by another shared library. Alright, clear story. I was using both WESTEROS_PLATFORM_EMBEDDED and WESTEROS_HAVE_WAYLAND_EGL defined. I will try to build with WESTEROS_PLATFORM_EMBEDDED undefined. If that does not work, I will do a LD_PRELOAD. Thanks for the prompt answer! Hi Jeff, I have been able to get Westeros compositor quite nicely running with Netflix and WPE clients using the simple_shell. Now I set the name of the client through wl_simple_shell_set_name. But now I see that always "noname" is broadcasted. I there a way to set the name of the shell before the broadcast is done, or should we add some sort of "client updated" broadcast. https://github.com/rdkcmf/westeros/blob/780b4c744b76ef5873aae1c4068023656cd572d6/simpleshell/westeros-simpleshell.cpp#L232-L237 Now I want to be able to identify what clients are active on a higher level so I have a sort of administrator client running to detect new clients. This client is only receiving clients named "noname". So sending this constant is a bit useless. Also, I never get a KeyboardLeave when a new client becomes active and receives a KeyboardEnter. So all my clients receive all key's at the moment, is this by design? Regards Bram Hi Bram, The place to set the client name is in the client's wl_simple_shell_listener shellSurfaceId method. See this code in westeros_test.cpp and westeros-sink/westeros-sink.c. All clients getting all keys is not the intent. I'll have to look into this. Thanks, Jeff Regarding the name, that is the place where I already set the name. What is the goal of able to the set a name? I was assuming that this name was intended for identification. So I was expecting a broadcast because the name was changed of one of the clients. Maybe we can have a call (skype) about Westeros so we get a more clear view on how to use it. At the moment I discover Westeros doing stuff trail and error. Hi Bram, I've made two commits to Westeros this morning related to your issues. The first changes simple shell service name broadcasting to broadcast the name at the time it is set, or when a timeout occurs, whichever comes first. The timeout has been increased. The second is an extension of keyboard focus support in Westeros. We've been concentrating on the use of embedded composition (a compositor that makes its composed frames available to a containing application for integration into its UI) as a means of integrating third party applications. As a result we mainly use one client per compositor instance and so didn't come across these key issues. Yes, the simpleshell name mechanism is intended to be a means of identifying surfaces in a system attempting to manage multiple known applications. I just noticed a pull request from you. Pull requests directly into this Westeros github repo are not accepted. Code contributions need to go through RDK-M's contribution mechanism: Access to Westeros & RDK opensource code is an automated process. "Existing users with access to RDK-Video code can sign-up for OSS contribution by going to https://wiki.rdkcentral.com and clicking on “Log In” (top right of the page) using existing RDK CMF credentials. Users will be confronted with a CLA sign-up message which they should agree. They are then all set for code contributions. New users may go to https://wiki.rdkcentral.com and click on “Sign Up” on the top right. They can create their User Name and sign the CLA and get ready to contribute. Code can be accessed through RDK CMF at https://code.rdkcentral.com . Contributions follow gerrit work-flow." I see changes to westeros-test and simpleshell. If you could submit these as two separate contributions via the above process that would be great. Hi @jeffwannamaker, i have a question, i'm trying to compile westeros-test and get it work as a part of a project but it seems i have a problem because when i compile the binary i get this error "wl_display_connect: display=(nil) error: unable to connect to primary display" so, i was wondering is there a problem with "NativeDisplayType" and instead it need to be set as "EGL_DEFAULT_DISPLAY" or what exactly Regards, Mariem. HI @jeffwannamaker I have disable the embedded options, but the Makefile still make the recipe ibwesteros_render_embedded.la, and then got error: CC protocol/vpc-protocol.lo CC protocol/version5/xdg-shell-protocol.lo CXXLD libwesteros_compositor.la ar: u' modifier ignored since D' is the default (see `U') CXX westeros-render-embedded.lo CXXLD libwesteros_render_embedded.la /usr/bin/ld: cannot find -lglut /usr/bin/ld: cannot find -lGLEW collect2: error: ld returned 1 exit status Makefile:850: recipe for target 'libwesteros_render_embedded.la' failed make[1]: *** [libwesteros_render_embedded.la] Error 1 ./configure --prefix $(WID) --enable-${XDGOPT} --enable-rendergl --enable-app --enable-test ### --enable-embedded=no --enable-essos=no any suggestion ? thanks. Damon Hi, The “--enable-embedded” flag is not related to the embedded render module. In the case of the embedded render module, the term embedded refers to the fact that the rendering is ‘embedded’ in the render loop of a top level application. For the configure flag, the term embedded refers to whether we are building for an embedded system or not. When the flag is set to false Westeros is being built to run on a desktop Linux system and in this case it requires glut and glew. This configuration was used in the past to allow causual prototyping on a desktop, but the configuration is no longer being actively maintained. From: chenzf @.> Reply-To: rdkcmf/westeros @.> Date: Wednesday, August 3, 2022 at 3:58 AM To: rdkcmf/westeros @.> Cc: "Wannamaker, Jeff" @.>, Mention @.***> Subject: Re: [rdkcmf/westeros] Help :-) (#3) HI @jeffwannamakerhttps://urldefense.com/v3/__https:/github.com/jeffwannamaker__;!!CQl3mcHX2A!BMMTpQodbgqSJraRSi1O-VYE64PIWcZrizWxGN5qkmhNCdSxLHNL2Jv2CVwo7oVlj85QxzbYhgeU-00IpgGHflLtr_-lb_-OxA$ I have disable the embedded options, but the Makefile still make the recipe ibwesteros_render_embedded.la, and then got error: CC protocol/vpc-protocol.lo CC protocol/version5/xdg-shell-protocol.lo CXXLD libwesteros_compositor.la ar: u' modifier ignored since D' is the default (see `U') CXX westeros-render-embedded.lo CXXLD libwesteros_render_embedded.la /usr/bin/ld: cannot find -lglut /usr/bin/ld: cannot find -lGLEW collect2: error: ld returned 1 exit status Makefile:850: recipe for target 'libwesteros_render_embedded.la' failed make[1]: *** [libwesteros_render_embedded.la] Error 1 ./configure --prefix $(WID) --enable-${XDGOPT} --enable-rendergl --enable-app --enable-test ### --enable-embedded=no --enable-essos=no any suggestion ? thanks. Damon — Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/rdkcmf/westeros/issues/3*issuecomment-1203615472__;Iw!!CQl3mcHX2A!BMMTpQodbgqSJraRSi1O-VYE64PIWcZrizWxGN5qkmhNCdSxLHNL2Jv2CVwo7oVlj85QxzbYhgeU-00IpgGHflLtr_-lT_oLiQ$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AADEFF2MDCVFQACL6TWOF2LVXIRDPANCNFSM4DKDGYCA__;!!CQl3mcHX2A!BMMTpQodbgqSJraRSi1O-VYE64PIWcZrizWxGN5qkmhNCdSxLHNL2Jv2CVwo7oVlj85QxzbYhgeU-00IpgGHflLtr_9m3wXMvw$. You are receiving this because you were mentioned.Message ID: @.***> HI @jeffwannamaker Thank you for your help. I have compiled these two dependence libs, and succeed compiled for Ubuntu version. And I'm trying to run the samples. HI @jeffwannamaker I have tried to run the westeron on the Ubuntu, but failed. I got the error infos: damon@ubuntu:~/Wayland/Westeros/westeros$ westeros_test westeros_test: v1.0 calling wl_display_connect for default display wl_display_connect: display=(nil) error: unable to connect to primary display westeros_test: exiting... westeros_test: exit And I read the westeron use case on the RDK page https://wiki.rdkcentral.com/display/RDK/Westeros It seems I miss understand this, right? It seems that one should first runs the westeros --renderer /usr/lib/libwesteros_render_gl.so.0.0.0 --display WPE or so, and the other one runs westeros_test --display WPE? How ever, I compile the weston, and the run the sample of the weston on the Ubuntu, it works ok. Can you help me to point out how can i run the westeron on my Ubuntu? thanks! Damon Hi, As I mentioned, this configuration is no longer being actively maintained. From you log output, it looks like either the WAYLAND_DISPLAY env var is not set properly, or the display is not created and running, or the XDG_RUNTIME_DIR is not set (or not set to the same location as the entity which has created the display). From: chenzf @.> Reply-To: rdkcmf/westeros @.> Date: Thursday, August 4, 2022 at 7:42 AM To: rdkcmf/westeros @.> Cc: "Wannamaker, Jeff" @.>, Mention @.***> Subject: Re: [rdkcmf/westeros] Help :-) (#3) HI @jeffwannamakerhttps://urldefense.com/v3/__https:/github.com/jeffwannamaker__;!!CQl3mcHX2A!Du_8I5ibU6WtRiPqC9hYrJjNhlCeIPMtPqarWVv5WoIzqhQQECV1dxqZ4TYg6DWFJhDDIGCRjKfRCIeG03FXLpbTe5hwBHwf9w$ I have tried to run the westeron on the Ubuntu, but failed. I got the error infos: @.***:~/Wayland/Westeros/westeros$ westeros_test westeros_test: v1.0 calling wl_display_connect for default display wl_display_connect: display=(nil) error: unable to connect to primary display westeros_test: exiting... westeros_test: exit And I read the westeron use case on the RDK page https://wiki.rdkcentral.com/display/RDK/Westeros It seems I miss understand this, right? It seems that one should first runs the westeros --renderer /usr/lib/libwesteros_render_gl.sohttps://urldefense.com/v3/__http:/libwesteros_render_gl.so/__;!!CQl3mcHX2A!Du_8I5ibU6WtRiPqC9hYrJjNhlCeIPMtPqarWVv5WoIzqhQQECV1dxqZ4TYg6DWFJhDDIGCRjKfRCIeG03FXLpbTe5hy1sJg6g$.0.0.0 --display WPE or so, and the other one runs westeros_test --display WPE? How ever, I compile the weston, and the run the sample of the weston on the Ubuntu, it works ok. Can you help me to point out how can i run the westeron on my Ubuntu? thanks! Damon — Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/rdkcmf/westeros/issues/3*issuecomment-1205142415__;Iw!!CQl3mcHX2A!Du_8I5ibU6WtRiPqC9hYrJjNhlCeIPMtPqarWVv5WoIzqhQQECV1dxqZ4TYg6DWFJhDDIGCRjKfRCIeG03FXLpbTe5iUPvvCrw$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AADEFF5BJZ5UFJUMTRCP54TVXOUB7ANCNFSM4DKDGYCA__;!!CQl3mcHX2A!Du_8I5ibU6WtRiPqC9hYrJjNhlCeIPMtPqarWVv5WoIzqhQQECV1dxqZ4TYg6DWFJhDDIGCRjKfRCIeG03FXLpbTe5i7XRMfMQ$. You are receiving this because you were mentioned.Message ID: @.***> hi @jeffwannamaker Thanks. HI @jeffwannamaker I read the source code, and find that both westeros and wersteros_test call wl_display_connect api to connect a display, so if I want to run these two demos westeros and westeros_test on the x86/Ubuntu, I first need to create a display, right? Thanks! Damon In order for westeros_test to run, a wayland display needs to have been created and be actively running. The display would be created by launching some Wayland compositor. That could be by launching the westeros reference compositor app (eg. the app ‘westeros’). A westeros compositor instance does not call wl_display_connect unless it is acting as a nested compositor. From: chenzf @.> Reply-To: rdkcmf/westeros @.> Date: Friday, August 5, 2022 at 6:07 AM To: rdkcmf/westeros @.> Cc: "Wannamaker, Jeff" @.>, Mention @.***> Subject: Re: [rdkcmf/westeros] Help :-) (#3) HI @jeffwannamakerhttps://urldefense.com/v3/__https:/github.com/jeffwannamaker__;!!CQl3mcHX2A!FCAI6Ej1QvKkit3C4jCu8Kuq9bGyPMEStLxfUhi8ko4oDARwK2vvpJcPu3mbOBDP_6Z_L4MlJTeDiAqLk2h33uriJwk0LjylpQ$ I read the source code, and find that both westeros and wersteros_test call wl_display_connect api to connect a display, so if I want to run these two demos westeros and westeros_test on the x86/Ubuntu, I first need to create a display, right? Thanks! Damon — Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/rdkcmf/westeros/issues/3*issuecomment-1206277334__;Iw!!CQl3mcHX2A!FCAI6Ej1QvKkit3C4jCu8Kuq9bGyPMEStLxfUhi8ko4oDARwK2vvpJcPu3mbOBDP_6Z_L4MlJTeDiAqLk2h33uriJwlyff0f6A$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AADEFF6EW4H5XTIMCU2B7V3VXTRUTANCNFSM4DKDGYCA__;!!CQl3mcHX2A!FCAI6Ej1QvKkit3C4jCu8Kuq9bGyPMEStLxfUhi8ko4oDARwK2vvpJcPu3mbOBDP_6Z_L4MlJTeDiAqLk2h33uriJwlgHh8K8w$. You are receiving this because you were mentioned.Message ID: @.***>
gharchive/issue
2017-05-04T15:04:33
2025-04-01T06:45:36.116080
{ "authors": [ "bramoosterhuis", "chenzf", "dridimariem", "jeffwannamaker", "renebarto" ], "repo": "rdkcmf/westeros", "url": "https://github.com/rdkcmf/westeros/issues/3", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
1893457858
🛑 Community 方糖社区 is down In 4e30c07, Community 方糖社区 (https://com.rdpstudio.top) was down: HTTP code: 530 Response time: 297 ms Resolved: Community 方糖社区 is back up in e6e4e55 after 16 minutes.
gharchive/issue
2023-09-12T23:13:42
2025-04-01T06:45:36.126014
{ "authors": [ "rdp-studio" ], "repo": "rdpstudio2019/monitor", "url": "https://github.com/rdpstudio2019/monitor/issues/201", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
465070202
error while unzipping qa_embeddings/bertffn_crossentropy.zip models extraction worked fine but problem with qa_embeddings/bertffn_crossentropy.zip Shows "zip error: Zip file structure invalid (bertffn_crossentropy.zip)" error #4 #3 This is a known issue caused by downloading from OneDrive failed. Currently we don't have a solution. You need to download the file manually through browser to avoid that. Sorry for the inconvenience that may cause. Hello thqs for the reply... Can u provide link for manual download of this.. ? On Mon 8 Jul, 2019, 11:38 AM Jay Yip, notifications@github.com wrote: This is a known issue caused by downloading from OneDrive failed. Currently we don't have a solution. You need to download the file manually through browser to avoid that. Sorry for the inconvenience that may cause. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/re-search/DocProduct/issues/7?email_source=notifications&email_token=AIUNWZLAEZCFBX6C3OXFZS3P6LKVRA5CNFSM4H6YE3NKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZMB6BQ#issuecomment-509091590, or mute the thread https://github.com/notifications/unsubscribe-auth/AIUNWZMVFKHLRSE4XB32B53P6LKVRANCNFSM4H6YE3NA . @WrathofBhuvan11 Please try this link: https://1drv.ms/u/s!An_n1-LB8-2dgoAYrXYnnBSA4d5dsg?e=FSgTNu @WrathofBhuvan11 Please try this link: https://1drv.ms/u/s!An_n1-LB8-2dgoAYrXYnnBSA4d5dsg?e=FSgTNu If it's down it doesn't matter if you try to download it via browser or colab, the only solution is to wait a few hours and if it's open, upload it to your own drive so you'll always have it.
gharchive/issue
2019-07-08T06:05:58
2025-04-01T06:45:36.135890
{ "authors": [ "JayYip", "Santosh-Gupta", "WrathofBhuvan11" ], "repo": "re-search/DocProduct", "url": "https://github.com/re-search/DocProduct/issues/7", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
435824926
Navigate prop is new with each render in a Route component Is there any reason that the navigate function here could not be extracted higher up so that the navigate prop is not new on each render? We ran into a situation with our app where a component was stuck in an infinte render loop. I do not believe that navigate was the culprit of this issue, but I did notice that the navigate prop is being created with each render. It seems like we could extract that into a function so that when it is passed in as a prop, it would pass the reference and not create a new function each time. If there is not a problem with this, I will gladly create a PR for it. It may be a significant problem as it appears to cause components receiving the "navigate" prop to always re-render. I just spent some time tracking down why a component I have was re-rendering 3 times when the props (and state) had not changed and the cause was the injected "navigate" prop changing on each render. Adding shouldComponentUpdate and comparing the current and next "navigate" prop (this.props.navigate === nextProps.navigate) always results in false. Wow this basically breaks any component that uses hooks. I just get constant re-rendering on any component that I pass navigate to (via {...props} for example). This is a MAJOR BUG. navigate does need to change sometimes though because it supports relative navigation, and the paths above it can change. The code was written before hooks though, when it wasn't as easy as dumping a useMemo around it. You can move your elements into a memo'd child component to keep your optimizations, but your route components can't be optimized. @stevensacks I don't understand how this would cause anything to infinitely render, it's not any different than passing an inline function to something <SomeComp navigate={() => {}}/>. I'm confident there's a bug in your app code, but I'd like to validate that. Can you can post the code that's causing infinite rerenders? @stevensacks Are you using the useEffect hook? If so, make sure you're passing an array of values to watch as the second argument for useEffect. See more here. I do not believe that navigate was the culprit of this issue... Because of React having a mechanism to perform memoization whether using class-based components or hooks, and the need for navigate to change due to relative links I'm gonna mark this as simply the docs needing to be updated with perhaps an asterisk on how navigate behaves. I encountered this problem for the first time today and I'm wondering if there is a simple way for me to work around it? In most of my Route Components I do not use navigate - I suppose there is no way for me to design the props of my route components to say "I don't care about the navigate function, don't pass it to me" - I need to use React.memo to prevent the re-rendering due to this prop?
gharchive/issue
2019-04-22T18:08:33
2025-04-01T06:45:36.143600
{ "authors": [ "andrew-cogesic", "dericgw", "mikemorton", "mtliendo", "ryanflorence", "stevensacks" ], "repo": "reach/router", "url": "https://github.com/reach/router/issues/265", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
269500225
How to output CSS separate from JS code when running a build? When the npm run build command is done, all the CSS seems to be baked into the JS code. We need to have CSS files separate from the JS for our production environment (so styling changes can be updated without altering the running JS code). It's one of those policy requirements that we can probably not talk the powers-that-be out of... :-) So, it seems like Webpack is able to do this, I see other repos where the build outputs have both JS and CSS files, separate from each other. But I am still trying to figure out webpack and it is making my head spin! So I hope y'all don't mind if I ask for help here... How can I tweak the webpack config so the CSS is in it's own separate CSS files, and not baked into the JS? Thanks much, /Mark Here is the answer. Where exactly in that doc? I've read it more than once and do not see my question addressed there. On Oct 30, 2017 12:16 AM, "Blling Fa" notifications@github.com wrote: Here https://github.com/react-boilerplate/react-boilerplate/tree/master/docs/css is the answer. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/react-boilerplate/react-boilerplate/issues/2005#issuecomment-340361455, or mute the thread https://github.com/notifications/unsubscribe-auth/AGaRnaspPgLPxin2Z1JLBAsxFtaRnyMWks5sxXevgaJpZM4QKwOV . I think you should use [CSS Module](https://github.com/react-boilerplate/react-boilerplate/tree/master/docs/css#css-modules) instead of styled-components and then use ExtractTextPlugin to seperate css file, some config like this: ExtractTextPlugin = require('extract-text-webpack-plugin'); config.module.loaders.push({ test: /\.css$/, loader: ExtractTextPlugin.extract('style', 'css') }, { test: /\.less$/, loader: ExtractTextPlugin.extract('style', 'css!less') }, { test: /\.scss$/, loader: ExtractTextPlugin.extract('style', 'css!sass') }); Hope this will help you. All, I have applied this change, and also tried several variations of this configuration that I have seen in online docs. However, it is only partially working. For some unknown reason, at least two of my sccs files are not getting picked up and included in the output css file. Instead, I see their fragments in one of the output JS files. What can I do to troubleshoot this? On Mon, Oct 30, 2017 at 12:45 AM, Blling Fa notifications@github.com wrote: I think you should use [CSS Module](https://github.com/ react-boilerplate/react-boilerplate/tree/master/docs/css#css-modules) instead of styled-components and then use ExtractTextPlugin to seperate css file, some config like this: ExtractTextPlugin = require('extract-text-webpack-plugin'); config.module.loaders.push({ test: /.css$/, loader: ExtractTextPlugin.extract('style', 'css') }, { test: /.less$/, loader: ExtractTextPlugin.extract('style', 'css!less') }, { test: /.scss$/, loader: ExtractTextPlugin.extract('style', 'css!sass') }); Hope this will help you. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/react-boilerplate/react-boilerplate/issues/2005#issuecomment-340366371, or mute the thread https://github.com/notifications/unsubscribe-auth/AGaRnTHOFqwQ0cd1QkqumtR7EJATycRKks5sxX6RgaJpZM4QKwOV . Hey there, looks like this isn't an issue with react-boilerplate. If you're looking for help, check out StackOverflow and post your question there.
gharchive/issue
2017-10-30T07:07:38
2025-04-01T06:45:36.155518
{ "authors": [ "blling", "gretzky", "jeghers" ], "repo": "react-boilerplate/react-boilerplate", "url": "https://github.com/react-boilerplate/react-boilerplate/issues/2005", "license": "mit", "license_type": "permissive", "license_source": "bigquery" }
214354770
Save on Mac OS isn't loading changes into app When I make changes to the code and save it, the app reloads but the changes don't show. in Terminal I get "Bundling node_modules/react-native-scripts/build/bin/crna-entry.js No module changed." It works ok on Windows fine Do you have watchman installed? Can you paste the output of watchman version on the terminal? Closing due to inactivity. Please reply with the requested details if you're still facing this issue.
gharchive/issue
2017-03-15T11:03:11
2025-04-01T06:45:36.181006
{ "authors": [ "dikaiosune", "markphughes17" ], "repo": "react-community/create-react-native-app", "url": "https://github.com/react-community/create-react-native-app/issues/72", "license": "bsd-3-clause", "license_type": "permissive", "license_source": "bigquery" }
231289213
navigator doesn't dispatch if setParams I want to pass params to component when route page,but it doesn't work! toProfile(){ const setParamsAction = NavigationActions.setParams({ params: { name: 'Hello' }, key: 'Profile', }) this.props.navigation.dispatch(setParamsAction);//doesn't work this.props.navigation.dispatch({ type: 'Profile' };//works well } reducers: export default function nav(state = initialNavState, action) { let nextState; switch (action.type) { ... case 'Profile': nextState = AppNavigator.router.getStateForAction( NavigationActions.navigate({ routeName: 'Profile'}), state ); break; } if i change the code to: export default function nav(state = initialNavState, action) { let nextState; switch (action.type) { ... case 'Navigation/SET_PARAMS': nextState = AppNavigator.router.getStateForAction( NavigationActions.navigate({ routeName: action.key, params:action.params}), state ); break; } it works ,but it's too ugly, do I miss something?Any suggestions will be appreciated! You did miss a few things. The key isn't always Profile. The key changes when you're using StackNavigator, as you can have the same route used multiple times with different parameters. Imagine a profile for Michael Jackson and another for Mark Zuckerberg. The keys will actually be something like id-1495735912887-0 and id-1495735912887-1. Only for TabRouter--I think--does the key stay the same. ...So, if you are using a StackNavigator and if you are using dispatch(NavigationActions.setParams(..)), then you will need to look into the state for the navigator/router and find what the key is, perhaps via a thunk: dispatch((dispatch, getState) => { const { routerState } = getState() const activeRoute = routerState.routes[routeState.index] const action = NavigationActions.setParams({ params: { name: 'Hello' }, key: activeRoute.key, }) dispatch(action) }) ...however, it's easier if you are calling this within the screen whose params you want to set. addNavigationHelpers automatically sets the key for setParams: const Profile = props => <View> <TouchableOpacity onPress={() => props.navigation.setParams({ name: 'Hello' })} /> </View> const MyStack = StackNavigator({ Profile: { screen: Profile } }, options) thanks for your answer, yes i use a StackNavigator, but still be confused, the relevant code in react-navigations/libs/NavigationActions.js: var SET_PARAMS = 'Navigation/SET_PARAMS'; var createAction = function createAction(type) { return function () { var payload = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : {}; return _extends({ type: type }, payload); }; }; var setParams = createAction(SET_PARAMS); It means if i call setParams method , type should always be Navigation/SET_PARAMS, so i must realize Navigation/SET_PARAMS condition in reducers, just like i do in my code, do i understand correctly? and if found below code in addNavigationHelpers.js: ... setParams: (params: NavigationParams): boolean => navigation.dispatch( NavigationActions.setParams({ params, key: navigation.state.key, }) ), ... so if i call props.navigation.setParams it should dispatch automactically, isn't it?but it still doesn't. you need to simply pass the action and previous state to MyStack.router.getStateForAction(action, prevState). You don't need to do switch. ...and if you do need switch for other actions, simply make the default getStateForAction. Look into src/routers/StackRouter.js. It's the most important file in the entire library, especially when you're first getting started with React Navigation. You will see it is a big file and very advanced. Almost the entire file is the getStateForAction method, and it is very large. It handles all the actions supported by React Navigation, and if your router has children routers/navigators, it will automatically see if the child router for the current index can handle the action. Research that file and you will have all your answers. basically your reducer can often just be: const stackReducer = (state, action) => MyNavigator.router.getStateForAction(action, state) || state ...only if your reducer does custom things for regular actions (e.g. action.type === 'Profile') do you need to make a busier reducer. In those cases, you make the regular action.type checks (such as in a switch statement) and then use getStateForAction as needed, perhaps simply as the default as I said above. But you can get fancier than that. Basically u can get the next state from getStateForAction and then if you want you can modify it, such as change the array of routes or the index. is my mistake ,just do: this.props.navigation.navigate('Profile', {name: 'Hello'})
gharchive/issue
2017-05-25T09:34:34
2025-04-01T06:45:36.190488
{ "authors": [ "cityvoice", "faceyspacey" ], "repo": "react-community/react-navigation", "url": "https://github.com/react-community/react-navigation/issues/1683", "license": "bsd-2-clause", "license_type": "permissive", "license_source": "bigquery" }
225078313
Adding reset key documentation This adds the changes in #789 to the Navigation-Actions documentation. This is insanely useful! I've spent 4 days trying to figure this out. Sooner this is in the docs, the better! 👍 Same here. There was essentially a regression in the situation where you use the StackNavigator { DrawerNavigator { StackNavigator } } pattern and this was the fix. I only found out that key: null was available or even the fix after running react in debug mode and stepping through lines of the navigation calls, reading the source code, and searching for bugs while intending to report the regression as a bug and finding this not obviously related PR. @ThePaulMcBride I've spent a fair amount of time trying to figure this out as well. I'm trying to replace a screen (rather than add it to the stack). Can you share any sample code? I've yet to find an example of where to get the key from: key - string or null - optional - If set, the navigator with the given key will reset. If null, the root navigator will reset. I understand it can be null, but how do we get the key if we don't want to use null? Also, do you know how we can get the existing stack of actions? actions - array - required - Array of Navigation Actions that will replace the navigation state @MrHubble The key is the key of the router which is currently on the stack that you want to reset. If you pass in no key at all, it will reset the current stack, if you pass in null, it will reset to the root navigator. If you pass in any other key, it will look for a matching key in your navigators. I hope that helps.
gharchive/pull-request
2017-04-28T13:19:08
2025-04-01T06:45:36.195146
{ "authors": [ "MrHubble", "ThePaulMcBride", "dantman", "scbrady" ], "repo": "react-community/react-navigation", "url": "https://github.com/react-community/react-navigation/pull/1297", "license": "bsd-2-clause", "license_type": "permissive", "license_source": "bigquery" }
53042982
Can it do variable height? If you get a chance, would love an example with variable-height images, as in hearsay.me or react.rocks. Basic markup, with Bootstrap: <div className="col-lg-3 col-md-4 col-sm-6 col-xs-12"> <a href={this.getArticleLink()} className='thumbnail article'> <img src='whatever'> Thanks! @winkler1 I'm not sure if you're still looking for an answer... I have a similar situation where I'm trying to integrate the react-grid-layout into my project with a variable number of widgets. Each widget loads with a spinner and then fetches data from different endpoints that result in variable size content. The result is that the nested child in GridItem either overlaps other widgets or doesn't take up enough space to "fill" the GridItem. I'll disclaim that I'm new to React, so I'm not sure if this is the best pattern... I have a React component that renders the ReactGridLayout. It stores the layout array in the state. A callback is passed into the child ("widget") component via props. Once it renders, the callback is called with this.getDOMNode().offsetHeight/offsetWidth as a parameters. The callback then computes the dimensions in grid units (similar to GridItem.calcWH(..)) and updates the state. The grid re-renders and the spacing looks correct. That sounds like a good way to do it. You're going to have to reach into the DOM, there's no other way to know how large the item will render in the DOM until you render it. There could be images, variable length text, variable widths, etc. This is one of those cases where if you want a perfect server render, you're going to have to either use something else or render in PhantomJS. On 5/6/15 5:26 PM, phchang wrote: @winkler1 https://github.com/winkler1 I'm not sure if you're still looking for an answer... I have a similar situation where I'm trying to integrate the react-grid-layout into my project with a variable number of widgets. Each widget loads with a spinner and then fetches data from different endpoints that result in variable size content. The result is that the nested child in |GridItem| either overlaps other widgets or doesn't take up enough space to "fill" the |GridItem|. I'll disclaim that I'm new to React, so I'm not sure if this is the best pattern... I have a React component that renders the |ReactGridLayout|. It stores the |layout| array in the |state|. A callback is passed into the child ("widget") component via |props|. Once it renders, the callback is called with |this.getDOMNode().offsetHeight/offsetWidth| as a parameters. The callback then computes the dimensions in grid units (similar to |GridItem.calcWH(..)|) and updates the |state|. The grid re-renders and the spacing looks correct. — Reply to this email directly or view it on GitHub https://github.com/STRML/react-grid-layout/issues/2#issuecomment-99629697. @STRML How does the calculation work with the rowHeight and the GridItem h? Even if I set the rowHeight to 1 the calculations are always way off. I've also tried changing the padding and margin to [1,1] @phchang Would you mind sharing your solution for dynamic resizing? I have the same issue--this widget is perfect for my needs but the heights are dynamic--if I could fix the layout to match then I would be in good shape. @winkler1 I'm not sure if you're still looking for an answer... I have a similar situation where I'm trying to integrate the react-grid-layout into my project with a variable number of widgets. Each widget loads with a spinner and then fetches data from different endpoints that result in variable size content. The result is that the nested child in GridItem either overlaps other widgets or doesn't take up enough space to "fill" the GridItem. I'll disclaim that I'm new to React, so I'm not sure if this is the best pattern... I have a React component that renders the ReactGridLayout. It stores the layout array in the state. A callback is passed into the child ("widget") component via props. Once it renders, the callback is called with this.getDOMNode().offsetHeight/offsetWidth as parameters. The callback then computes the dimensions in grid units (similar to GridItem.calcWH(..)) and updates the state. The grid re-renders and the spacing looks correct. useEffect to help this lag go away. I am also doing similar thing in my PWA. Get a base dimensions for the widgets with ids and layouts also using the same ids as index. in useEffect === onLoad I simply set h = clientHeight/150. works flawlessly. @aphougat, I am dealing with the same issue in my project. Would you mind sharing you solution here?
gharchive/issue
2014-12-29T14:04:23
2025-04-01T06:45:36.212029
{ "authors": [ "KroidHunt", "STRML", "aphougat", "phchang", "scottellis64", "stanleycyang", "winkler1" ], "repo": "react-grid-layout/react-grid-layout", "url": "https://github.com/react-grid-layout/react-grid-layout/issues/2", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
902146572
Find another docs engine (migrate to docz) I have not the best experience with storybook now, we should consider swapping it for something else, like docusaurus. Weelp, looks like docz author back online and project will continue developing. Therefore, when most of current issues with it will be fixed - i will switch the docs engine. Welp it seems that docz is dead again. closing for now since no alternatives.
gharchive/issue
2021-05-26T10:12:03
2025-04-01T06:45:36.268275
{ "authors": [ "xobotyi" ], "repo": "react-hookz/web", "url": "https://github.com/react-hookz/web/issues/88", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
299904644
Override Bug I get this error when trying to use this package and it is an easy fix see here: https://github.com/iRoachie/react-native/commit/3e77e292903901d9bfe25490da1b5d1ceba47f22 iOS only. #328 this was fixed in a recent commit, will be part of the next release
gharchive/issue
2018-02-24T02:48:58
2025-04-01T06:45:36.278193
{ "authors": [ "cds327", "emnsen", "vonovak" ], "repo": "react-native-community/react-native-google-signin", "url": "https://github.com/react-native-community/react-native-google-signin/issues/345", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
500594862
Cannot read property 'tintColor' of null Bug Probably since the merge of PR1131, if null is passed as options to showImagePicker, a TypeError ("Cannot read property 'tintColor' of null") occurs. Environment info React native info output: System: OS: macOS High Sierra 10.13.6 CPU: (8) x64 Intel(R) Core(TM) i7-3740QM CPU @ 2.70GHz Memory: 81.82 MB / 16.00 GB Shell: 3.2.57 - /bin/bash Binaries: Node: 12.8.0 - /usr/local/bin/node Yarn: 1.17.3 - /usr/local/bin/yarn npm: 6.10.3 - /usr/local/bin/npm Watchman: 4.9.0 - /usr/local/bin/watchman SDKs: iOS SDK: Platforms: iOS 12.1, macOS 10.14, tvOS 12.1, watchOS 5.1 Android SDK: API Levels: 23, 25, 26, 27, 28 Build Tools: 23.0.1, 27.0.3, 28.0.1, 28.0.2, 28.0.3 System Images: android-23 | Intel x86 Atom_64, android-23 | Google APIs Intel x86 Atom_64, android-28 | Google APIs Intel x86 Atom, android-28 | Google Play Intel x86 Atom IDEs: Android Studio: 3.3 AI-182.5107.16.33.5314842 Xcode: 10.1/10B61 - /usr/bin/xcodebuild npmPackages: @react-native-community/cli: ^2.9.0 => 2.9.0 react: 16.9.0 => 16.9.0 react-native: 0.61.0 => 0.61.0 Library version: 1.1.0 Steps To Reproduce Call ImagePicker.showImagePicker passing null as options. Expected Behavior I would expect the library to set the default tintColor without attempting to reference tintColor from the options object (which is null). Reproducible sample code ImagePicker.showImagePicker(null, response => { ... }); Any solution? you can pass an empty object instead of null as an option. See code below: ImagePicker.showImagePicker({}, response => { ... }) not sure why it's mentioned as null in docs but passing empty object works.
gharchive/issue
2019-10-01T00:36:52
2025-04-01T06:45:36.281825
{ "authors": [ "cenzovit", "mohitmishra22", "vksgautam1" ], "repo": "react-native-community/react-native-image-picker", "url": "https://github.com/react-native-community/react-native-image-picker/issues/1186", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
526277778
Update react-native to 0.61.4 This updates the react-native dependency of the example project to the latest version 0.61.4 including all project support files. In a separate commit, it fixes a few ESLint errors and warning. There is also an individual commit that adds node_modules to the [untyped] section in .flowconfig. This was an existing setting, but since it's the only difference to a vanilla .flowconfig from the default RN template, I kept it separate for easy revertability. Successfully verified and tested on: Android Device (Xiaomi Mi A2) Android Emulator (Pixel 3a) iOS Device (iPhone 8) iOS Simulator (iPhone X) Once approved, please use a normal GitHub merge (i.e. NO rebase/squash merge) to integrate the commit(s) from the PR head branch. The changes are broken up into meaningful, atomic commits, and my branch should already be up-to-date with the latest base branch. If it isn't, or if you want me to change anything, please let me know, and I will update the branch as soon as possible. Thank you! Thanks for reviewing @MateusAndrade - Just a gentle reminder to use a regular merge (no squash) for this PR, so we can easily git revert the commit that customized .flowconfig (once the existing errors are resolved in a different PR). As always, good question @mikehardy Rebase and/or squash merges on GitHub can be a good option in the following scenarios: The PR head branch contains multiple commits that logically make no sense in having as separate commits on the base branch (a good example are "fixup" commits) The PR head branch is out-of-date with the base branch (which would create a tangled spaghetti Git commit graph) The PR contains merge commits (for example after using the dreaded "Update branch" button, which merges the base branch into the PR branch) If one or more of these conditions are met, and the PR author is unavailable or unresponsive in requests to update/change the PR branch, then a GitHub squash/rebase merge may be the preferred way of merging a PR. Otherwise, if the pull request contains only a single commit (or cleanly structured commits), and is already fully rebased, there is not really any benefit in using a rebase or squash merge on GitHub. All it does is rewrite the commit(s) on the GitHub server, which (as you mentioned) effectively removes any signatures from the commits and changes the committer IDs/dates. In the case of rebase merges, it will also make it impossible to identify the commits that went into the base branch through a particular PR (it would just be one straight line, without a reference to the PR number). For squash merges at least, GitHub would append the PR number to the end of the modified Git commit message. Additionally, in both cases the PR author would have to force delete their local branch using git branch -D (Git does not see it as merged), potentially after manually having to verify that all changes made it into the base branch. With a regular merge, "graceful" branch deletion (git branch -d) can be used, with which Git guarantees that no information will be lost. Thanks for the detailed explanation @friederbluemle - all makes sense. I will say that in practice the rebase merge (not squash) has worked well for years on AnkiDroid and makes for a squeaky clean master timeline without a lot of PR rebasing which is nice, but I can see the benefits of merge as well. Good to think through as a maintainer either way Sorry react-native-share people for chatting up the PR thread :) Thanks for merging. Since the commits were squashed, there's no single commit on the default branch that can easily be reverted once the type errors have been fixed. I'll keep the ref as a separate branch on my fork, so the customization to .flowconfig can be fetched from there and reverted if needed: Step 1 Fix type errors and commit changes Step 2 git fetch https://github.com/friederbluemle/react-native-share.git flowconfig git revert FETCH_HEAD Step 3 Ensure that yarn flow in example/ still passes.
gharchive/pull-request
2019-11-20T23:38:27
2025-04-01T06:45:36.292164
{ "authors": [ "friederbluemle", "mikehardy" ], "repo": "react-native-community/react-native-share", "url": "https://github.com/react-native-community/react-native-share/pull/637", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
495290119
_this.setState is not a function Current behaviour Hello, i have an Problem with this Library. I use React_native 0.60. The Swipe is not working and if i touch on the second Tab, get the followed error: Screenshot: Code sample import * as React from 'react'; import { View, StyleSheet, Dimensions } from 'react-native'; import { TabView, SceneMap } from 'react-native-tab-view'; const screenHeight = Math.round( Dimensions.get( 'window' ).height ); const screenWidth = Math.round( Dimensions.get( 'window' ).width ); const styles = StyleSheet.create({ scene: { flex: 1, }, }); const FirstRoute = () => ( <View style={[styles.scene, { backgroundColor: '#ff4081' }]} /> ); const SecondRoute = () => ( <View style={[styles.scene, { backgroundColor: '#673ab7' }]} /> ); const App = () => { state = { index: 0, routes: [ { key: 'first', title: 'First' }, { key: 'second', title: 'Second' }, ] }; return ( <TabView navigationState={this.state} renderScene={SceneMap({ first: FirstRoute, second: SecondRoute, })} onIndexChange={index => this.setState({ index })} initialLayout={{ width: Dimensions.get('window').width }} /> ); }; export default App;` Your Environment software version ios or android android react-native 0.60.5 react-native-tab-view 2.10.0 react-native-gesture-handler 1.4.1 react-native-reanimated 1.2.0 I Hope someone can help me with this error This is not a bug. Just use class based component if you want to use setState() function. You're using functional component instead. If you wanna use functional component you should use it like this: `const FirstRoute = () => ( <View style={[styles.scene, {backgroundColor: '#ff4081'}]}/> ); const SecondRoute = () => ( <View style={[styles.scene, {backgroundColor: '#673ab7'}]}/> ); const Page = (props: Props) => { const [index, setIndex] = React.useState(0); const routes = { index: index, routes: [ {key: 'first', title: 'First'}, {key: 'second', title: 'Second'}, ] }; return ( <> <StatusBar backgroundColor={properties.color} animated={true} barStyle={"light-content"}/> <SafeAreaView style={styles.safeArea}> <TabView navigationState={routes} renderScene={SceneMap({ first: FirstRoute, second: SecondRoute, })} onIndexChange={index => setIndex(index)} initialLayout={{width: Dimensions.get('window').width}} /> </SafeAreaView> </> ) };`
gharchive/issue
2019-09-18T15:12:00
2025-04-01T06:45:36.300831
{ "authors": [ "VincenzoCarlino", "iSaBo96", "ivanstnsk" ], "repo": "react-native-community/react-native-tab-view", "url": "https://github.com/react-native-community/react-native-tab-view/issues/883", "license": "mit", "license_type": "permissive", "license_source": "bigquery" }
1078676226
[🐛] Add selected images by order of selection Description Hi, is there a way to add the selected images by order of selection when multiSelect? Currently its pretty random. Im guessing its by the time each image is created when uploaded to the library? How to repeat issue and example upload multiple images, check the order of their upload the moment the they return from library Solution maybe have a flag 'bySelectOrder', and this will make each image to be uploaded when you select it (and not when click the Add button), and if image is deselected, it will be removed from the array of uploaded images. Click 'add' will send the finale image array back. Someone? Sent a PR for this. https://github.com/react-native-image-picker/react-native-image-picker/pull/1970 bump Hey We are using this library and facing the same issue. Any idea when this PR will be merged What about a solution for Android? Would be very helpful if there can be a solution for Android as well 🙏 Has anyone been able to figure out how to fix this issue for Android? @mokoshi any suggestions? Thanks I think the problem has only occurred on iOS when I was looking at the issue, but not for sure. Maybe some changes causing the problem were added to Android side later? We need this for Android as well
gharchive/issue
2021-12-13T15:36:20
2025-04-01T06:45:36.312006
{ "authors": [ "Dubask", "MohitGoel9456", "charlie4284", "kadinuguru", "mawenlihk", "mokoshi", "nofacez", "vincentzierigen" ], "repo": "react-native-image-picker/react-native-image-picker", "url": "https://github.com/react-native-image-picker/react-native-image-picker/issues/1893", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
2045689203
Execution failed for task :react-native-community_netinfo:compileReleaseJavaWithJavac. Environment System: OS: Windows 11 10.0.22631 CPU: (12) x64 12th Gen Intel(R) Core(TM) i5-1235U Memory: 2.79 GB / 15.75 GB Binaries: Node: version: 20.10.0 path: C:\Users\MYBOOK~1\AppData\Local\Temp\xfs-00abb495\node.CMD Yarn: version: 4.0.2 path: C:\Users\MYBOOK~1\AppData\Local\Temp\xfs-00abb495\yarn.CMD npm: version: 10.2.5 path: C:\Program Files\nodejs\npm.CMD Watchman: Not Found SDKs: Android SDK: Not Found Windows SDK: Not Found IDEs: Android Studio: AI-231.9392.1.2311.11076708 Visual Studio: Not Found Languages: Java: 11.0.18 Ruby: Not Found npmPackages: "@react-native-community/cli": Not Found react: installed: 18.2.0 wanted: 18.2.0 react-native: installed: 0.73.0 wanted: 0.73.0 react-native-windows: Not Found npmGlobalPackages: "*react-native*": Not Found Android: hermesEnabled: true newArchEnabled: true iOS: hermesEnabled: Not found newArchEnabled: Not found Platforms Android Versions Android: 34 iOS: react-native-netinfo: 11.2.1 react-native: 0.73.0 react: 18.0.2 Description I got this error when running .\gradlew.bat assembleRelease > Task :react-native-community_netinfo:compileReleaseJavaWithJavac FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':react-native-community_netinfo:compileReleaseJavaWithJavac'. > Could not resolve all files for configuration ':react-native-community_netinfo:androidJdkImage'. > Failed to transform core-for-system-modules.jar to match attributes {artifactType=_internal_android_jdk_image, org.gradle.libraryelements=jar, org.gradle.usage=java-runtime}. > Execution failed for JdkImageTransform: C:\AndroidSDK\platforms\android-34\core-for-system-modules.jar. > Error while executing process C:\Program Files\OpenJDK\jdk-21.0.1\bin\jlink.exe with arguments {--module-path C:\Users\MyBook Z Series\.gradle\caches\transforms-3\47e305173a08682f911db0c5055580c3\transformed\output\temp\jmod --add-modules java.base --output C:\Users\MyBook Z Series\.gradle\caches\transforms-3\47e305173a08682f911db0c5055580c3\transformed\output\jdkImage --disable-plugin system-modules} Reproducible Demo npx react-native@latest init MyProject --version=0.73.0 cd MyProject yarn add @react-native-community/netinfo cd android .\gradlew.bat clean .\gradlew.bat assembleRelease android-gradle-plugin 8.2.0 does not work with JDK21, you are using an unsupported toolchain react-native development is still on JDK17 android-gradle-plugin 8.2.1 should work I implore you to look very very carefully at error messages in the future before opening issues, as your error message has nothing to do with netinfo: > Failed to transform core-for-system-modules.jar to match attributes {artifactType=_internal_android_jdk_image, org.gradle.libraryelements=jar, org.gradle.usage=java-runtime}. > Execution failed for JdkImageTransform: C:\AndroidSDK\platforms\android-34\core-for-system-modules.jar. > Error while executing process C:\Program Files\OpenJDK\jdk-21.0.1\bin\jlink.exe with arguments {--module-path C:\Users\MyBook Z Series\.gradle\caches\transforms-3\47e305173a08682f911db0c5055580c3\transformed\output\temp\jmod --add-modules java.base --output C:\Users\MyBook Z Series\.gradle\caches\transforms-3\47e305173a08682f911db0c5055580c3\transformed\output\jdkImage --disable-plugin system-modules} https://issuetracker.google.com/issues/294137077
gharchive/issue
2023-12-18T04:03:54
2025-04-01T06:45:36.317973
{ "authors": [ "achmadk", "mikehardy" ], "repo": "react-native-netinfo/react-native-netinfo", "url": "https://github.com/react-native-netinfo/react-native-netinfo/issues/708", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
614667645
TypeError: TaskQueue: Error with task: undefined is not an object (evaluating '_this.view{component.measureInWindow') Bug This issue comes in the latest version. RN -62.2. I have a project with react-navigation older versions. 3.6.9. Environment info RN -62.2 react-navigation 3.6.9 react-native info output: System: OS: macOS 10.15.4 CPU: (4) x64 Intel(R) Core(TM) i7-5650U CPU @ 2.20GHz Memory: 141.37 MB / 8.00 GB Shell: 5.7.1 - /bin/zsh Binaries: Node: 13.5.0 - /usr/local/bin/node Yarn: 1.15.2 - /usr/local/bin/yarn npm: 6.13.4 - /usr/local/bin/npm Watchman: Not Found Managers: CocoaPods: 1.9.1 - /usr/local/bin/pod SDKs: iOS SDK: Platforms: iOS 13.4, DriverKit 19.0, macOS 10.15, tvOS 13.4, watchOS 6.2 Android SDK: API Levels: 25, 27, 28 Build Tools: 27.0.3, 28.0.3 System Images: android-28 | Intel x86 Atom_64, android-28 | Google APIs Intel x86 Atom Android NDK: Not Found IDEs: Android Studio: 3.6 AI-192.7142.36.36.6392135 Xcode: 11.4/11E146 - /usr/bin/xcodebuild Languages: Java: 1.8.0_211 - /usr/bin/javac Python: 2.7.16 - /usr/bin/python npmPackages: @react-native-community/cli: Not Found react: 16.11.0 => 16.11.0 react-native: 0.62.2 => 0.62.2 npmGlobalPackages: react-native: Not Found // paste it here Library version: x.x.x older version react-navigation with latest react native version issues. install react navigaiton issue. install latest react native project. ... Describe what you expected to happen: Run Normally A hook to pass any such conflicts . Reproducible sample code I am having the same issue. Please help. I am also using react-redux, is that the reason I am getting the error? react-navigation used old version react-native-safe-area-view for solved this issue you need update on fresh version react-navigation Trying to find "react-safe-area-view" in node modules to fix this but it doesn't seem to exist in my project. @fonov I can't update react-navigation right now. Do you know if there's another solution? Currently upgrading RN Version to 0.63 and using react-navigation 3.3.2. From StackOverflow, I found that if you remove _component from this.view._component.measureInWindow inside react-native-safe-area-view index file at node_modules, it solves the problem, but it's not a great solution. @fonov I can't update react-navigation right now. Do you know if there's another solution? Currently upgrading RN Version to 0.63 and using react-navigation 3.3.2. From StackOverflow, I found that if you remove _component from this.view._component.measureInWindow inside react-native-safe-area-view index file at node_modules, it solves the problem, but it's not a great solution. Thanks a LOT enrickdl..It really helped me and the issue is resolveed... @harrhys Great to hear that! Just FYI, I end it up upgrading react-navigation from v3 to v4, since it's very similar, I didn't have problems and it was very simple. I would suggest that as well. Sure @enrickdl ..Thans for you suggestion, I will definitely consider upgrading from v3 to v4. Best Regards, Harrhy I found a workaround for this error, without modifying the index of react-native-safe-area-view, at least for my use case. I'm also using an older version of react-navigation, and update it isn't an option right now. What I did was to add a resolution in my package.json with react-native-safe-area-view v1.1.0 . Like this: "resolutions": { "react-native-safe-area-view": "1.1.0" } Resolutions are only available with yarn: https://classic.yarnpkg.com/en/docs/selective-version-resolutions/ And after that I had to use SafeAreaProvider from react-native-safe-area-context to wrap my app in my entry file: <SafeAreaProvider> <Provider store={store}> <AppNavigator /> </Provider> </SafeAreaProvider> expo SDK: 38 react: 16.11.0 react-native: 0.62.2 Hope this helps someone. Thank you @enrickdl - solved my problem too - I'm stuck on an old version of react navigation and must update but really didn't want it to be this month!!! @matias91 Thank you so muchhhhh it's work for me with expo SDK: 38 react: 16.11.0 react-native: 0.62.2 react-navigation: 2.13.0 it didn't work for me expo SDK:38, "react-native-paper": "2.16.0" react-navigation: 4.4.0 @matias91, Thank you for your suggestion on fixing this issue! It worked for me as well although I forced upgrade the react-navigation@2.0.1 to react-navigation@2.18.3 since it didn't work on react-navigation@2.0.1. expo SDK: 39 react: 16.13.1 react-native: 0.63.3 react-navigation: 2.18.3 I found a workaround for this error, without modifying the index of react-native-safe-area-view, at least for my use case. I'm also using an older version of react-navigation, and update it isn't an option right now. What I did was to add a resolution in my package.json with react-native-safe-area-view v1.1.0 . Like this: "resolutions": { "react-native-safe-area-view": "1.1.0" } Resolutions are only available with yarn: https://classic.yarnpkg.com/en/docs/selective-version-resolutions/ And after that I had to use SafeAreaProvider from react-native-safe-area-context to wrap my app in my entry file: <SafeAreaProvider> <Provider store={store}> <AppNavigator /> </Provider> </SafeAreaProvider> expo SDK: 38 react: 16.11.0 react-native: 0.62.2 react-navigation: 2.18.3 Hope this helps someone. Not worked for me: "react": "16.11.0", "react-native": "0.62.2", "react-navigation": "2.18.2" "react-native-safe-area-context": "^3.1.9",
gharchive/issue
2020-05-08T10:52:57
2025-04-01T06:45:36.342668
{ "authors": [ "DaNiELChIoRo", "Trouble106", "callyb", "christopherguyton", "enrickdl", "eramudeep", "fonov", "halaharr", "harrhys", "ljz-peralta", "matias91", "sudhirkumarojhaa" ], "repo": "react-navigation/react-native-safe-area-view", "url": "https://github.com/react-navigation/react-native-safe-area-view/issues/118", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
850402959
F/refactor i18n @rexebin i id some small changes. what do you think? @macrozone cool refactor, I am good. Learn a few tricks here. Thank you! @macrozone The children prop for the Editor component was removed from the original uiTranslator PR. It is a two-line change, do you want me to start a new PR or you would just add it during your next release? Is there a guideline for submitting adding contributor PR or you would handle it without PR? It was a pleasure working with you. @macrozone The children prop for the Editor component was removed from the original uiTranslator PR. It is a two-line change, do you want me to start a new PR or you would just add it during your next release? Is there a guideline for submitting adding contributor PR or you would handle it without PR? I'll readd it and release it It was a pleasure working with you. same, thank you :-) :tada: This PR is included in version 2.0.0-beta.12 :tada: The release is available on: v2.0.0-beta.12 GitHub release Your semantic-release bot :package::rocket: :tada: This PR is included in version 2.0.0 :tada: The release is available on: v2.0.0 GitHub release Your semantic-release bot :package::rocket:
gharchive/pull-request
2021-04-05T14:23:44
2025-04-01T06:45:36.363381
{ "authors": [ "macrozone", "rexebin" ], "repo": "react-page/react-page", "url": "https://github.com/react-page/react-page/pull/947", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
268766810
Styling does not get applied to a basic button I got stuck on this issue for a long time, I followed this procedure: Install react-css-themr Install react-toolbox-themr Add to package.json "reactToolbox": { "include": [ "BUTTON" ], "output": "src/styling" } Install the theme with with react-toolbox-themr Add to my Index.tsx ( I am using Typescript) declare function require(moduleName: string): any; const theme = require( './styling/theme.css'); import { ThemeProvider } from 'react-css-themr'; import Button from 'react-toolbox/lib/button/Button'; ReactDOM.render( <ThemeProvider theme={theme}> <Button icon='bookmark' label='Bookmark' accent /> </ThemeProvider> , document.getElementById('root') as HTMLElement ) Both import Button from 'react-toolbox/lib/button/Button'; and import { Button } from 'react-toolbox/lib/button/Button'; give as output a single button without any styling: Am I missing something? I forgot to import the css itself ... import './toolbox/theme.css';
gharchive/issue
2017-10-26T13:48:18
2025-04-01T06:45:36.370360
{ "authors": [ "jervtub" ], "repo": "react-toolbox/react-toolbox", "url": "https://github.com/react-toolbox/react-toolbox/issues/1726", "license": "mit", "license_type": "permissive", "license_source": "bigquery" }
284806938
selectTable incorrectly setting width V6.7.6 The width setting needs to be an integer. Fix this with #708 This has been fixed and can be closed: https://github.com/react-tools/react-table/pull/761
gharchive/issue
2017-12-27T22:31:39
2025-04-01T06:45:36.372068
{ "authors": [ "catalinberta", "gary-menzel" ], "repo": "react-tools/react-table", "url": "https://github.com/react-tools/react-table/issues/709", "license": "mit", "license_type": "permissive", "license_source": "bigquery" }
346704335
Update cart.checkout.summary prop in MiniCart component Type: minor Describe the bug MiniCart prop cart.checkout.summary needs to be updated to match the current cart schema. Namely: "subtotal" -> "itemTotal" "tax" -> "taxTotal" :tada: This issue has been resolved in version 0.13.1 :tada: The release is available on: npm package (@latest dist-tag) GitHub release Your semantic-release bot :package::rocket:
gharchive/issue
2018-08-01T17:54:36
2025-04-01T06:45:36.375880
{ "authors": [ "mikemurray", "rc-publisher" ], "repo": "reactioncommerce/reaction-component-library", "url": "https://github.com/reactioncommerce/reaction-component-library/issues/173", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
341605184
docs: add Netlify URL to README Adds Netlify URL to README 🚀 Preview deployed Built with commit 69af4295f018e8f38d2ca6738bfd664f428b11a4 https://deploy-preview-132--stoic-hodgkin-c0179e.netlify.com
gharchive/pull-request
2018-07-16T17:19:26
2025-04-01T06:45:36.377559
{ "authors": [ "machikoyasuda" ], "repo": "reactioncommerce/reaction-component-library", "url": "https://github.com/reactioncommerce/reaction-component-library/pull/132", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
57930502
remove rule 1:12 (produce same elements to all Subscribers) This rule is in conflict with 1:11 which allows a Publisher to treat multiple Subscribers as either as unicast or multicast recipients. The verification of proper multicast behavior (which 1:12 specified) has been retained, the test methods renamed accordingly. Fixes #224. There was agreement on the ticket, no comments here, so merging after 23 days.
gharchive/pull-request
2015-02-17T14:30:24
2025-04-01T06:45:36.387147
{ "authors": [ "rkuhn" ], "repo": "reactive-streams/reactive-streams-jvm", "url": "https://github.com/reactive-streams/reactive-streams-jvm/pull/225", "license": "MIT-0", "license_type": "permissive", "license_source": "github-api" }
2554123247
Complete the Translation of PR #103 'Synchronizing with effects (60%)' This PR continues and completes the work started in PR #103 by @AFM-Taha. Original PR: #103 This PR aims to finish the remaining part of the translation Once reviewed and approved, this PR can replace #103. @nafistiham @moshfiqrony রিভিউ এর অপেক্ষায়। আমি শুরু থেকে শেষ পর্যন্ত পড়ে বানানগত, ব্যাকরণগত এবং অনুবাদের অনেক ভুল সংশোধন করেছি। আপাতত আমার কাছে চলনসই লাগতেছে, আপনাদের কোনো চেঞ্জের সাজেশন থাকলে জানাবেন। অনেক ধন্যবাদ বিশাল একটা পেইজে কাজ করবার জন্য। কিছু কমেন্ট করেছি। কিছু বিষয় পরিবর্তনের অনুরোধ করব। কমিটের সংখ্যা অত্যধিক এবং অপ্রয়োজনীয় মনে হয়েছে। একটা দুইটা শব্দ বদলিয়ে কমিট করা হয়েছে। অনুরোধ করব কমিটগুলোকে স্কোয়াশ করে ২০-৩০ টা কমিটে নিয়ে যেতে। React সহ অনেক টেকনিকাল শব্দ আমরা ইংরেজিতেই রাখার চেষ্টা করছি। এ বিষয়ে আরেকবার রিভাইজ করলে ভাল হয়। কোডের মধ্যকার কিছু না বদলাই। সি আই সি ডি পাইপলাইনে ঝামেলা করে মাঝে মাঝে। এ বিষয়গুলো মাথায় রেখে আরেকবার ঠিক করেন। এর পর আবার রিভিউ করব। @nafistiham রিভিউর জন্য ধন্যবাদ। প্রায় এক সপ্তাহ ধরে কাজের ফাঁকে ফাঁকে প্রুফ রীড করে সংশোধন করায় এত এত ভাঙ্গা কমিট হয়েছে শেষের দিকে, সেগুলো সব (প্রায় ৫৩ টা) আমি squash করে ১ টি কমিট করেছি। বর্তমান কমিটগুলোর মধ্যে ২/৩ টা বাদে বাকিগুলোতে ১ টি করে প্যারাগ্রাফ অনুবাদ করা হয়েছে, আর এত বড় একটা পেজের জন্য এত সংখ্যক কমিট স্বাভাবিক মনে করি। তবুও আরো এডজাস্ট করতে হলে জানাবেন। পুরো পেজ রিভাইজ দিয়ে প্রায় সব টেকনিকাল টার্মগুলোকে ইংরেজিতে ফিরিয়ে নিয়েছি। কোডব্লক সব আগের মতো করে দিয়েছি।
gharchive/pull-request
2024-09-28T09:08:54
2025-04-01T06:45:36.391492
{ "authors": [ "habibium" ], "repo": "reactjs/bn.react.dev", "url": "https://github.com/reactjs/bn.react.dev/pull/160", "license": "CC-BY-4.0", "license_type": "permissive", "license_source": "github-api" }
121889758
Cannot find module "react" from "web/static/bower_components/react/react-dom" I'm getting the following error with my Phoenix app that uses Brunch: Cannot find module "react" from "web/static/bower_components/react/react-dom" I have the following code: import React from 'bower_components/react/react'; import ReactDOM from 'bower_components/react/react-dom'; import Map from './components/Map'; ReactDOM.render(<Map />, document.getElementById('map-container')) I can work around the problem my using React.render() instead of ReactDOM.render(), but I get the depreciation warning for React.render(). My workaround code is: import React from 'bower_components/react/react'; import Map from './components/Map'; React.render(<Map />, document.getElementById('map-container')) I'm getting the same behavior but in a Rails 4.2 app. ReferenceError: ReactDOM is not defined I just ran bower install react in an empty folder with the following index.html: <!DOCTYPE html> <html> <body> <div id="container"> </div> <script src="./bower_components/react/react.js"></script> <script src="./bower_components/react/react-dom.js"></script> <script> var ExampleApplication = React.createClass({ render: function() { var elapsed = Math.round(this.props.elapsed / 100); var seconds = elapsed / 10 + (elapsed % 10 ? '' : '.0' ); var message = 'React has been successfully running for ' + seconds + ' seconds.'; return React.DOM.p(null, message); } }); var ExampleApplicationFactory = React.createFactory(ExampleApplication); var start = new Date().getTime(); setInterval(function() { ReactDOM.render( ExampleApplicationFactory({elapsed: new Date().getTime() - start}), document.getElementById('container') ); }, 50); </script> </body> </html> It ran successfully: react.js and react-dom.js in the Bower distributions are UMD builds. Since the example runs fine in the browser, the problem has to be with the way your build tool of choice (e.g. Brunch) handles UMD files. I don’t think there’s anything here that we can fix so I’m closing, but please feel free to suggest a solution if you’re sure this is something we can fix on our side.
gharchive/issue
2015-12-13T00:50:26
2025-04-01T06:45:36.396369
{ "authors": [ "ajrob27", "gaearon", "stevesuh" ], "repo": "reactjs/react-bower", "url": "https://github.com/reactjs/react-bower/issues/16", "license": "mit", "license_type": "permissive", "license_source": "bigquery" }
204233306
react router v4 @timdorr any working example how it will work with server side rendering of react router v4 Nothing yet. It just went beta yesterday, so you've gotta give me some time to work on something 😄
gharchive/issue
2017-01-31T08:40:32
2025-04-01T06:45:36.408980
{ "authors": [ "abhijeetNmishra", "timdorr" ], "repo": "reactjs/react-router-redux", "url": "https://github.com/reactjs/react-router-redux/issues/519", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
359822060
Update tutorial to use setState with callback when depending on previous state The tutorial currently uses setState while referencing previous state using this.state. According to the docs, "you should not rely on their values for calculating the next state". This PR makes the tutorial consistent with this and explains this best practice. Relates to issue #516 Closing as per discussion in the linked issue. Thank you for taking the time to contribute, @meltuhamy 👍
gharchive/pull-request
2018-09-13T09:48:03
2025-04-01T06:45:36.413678
{ "authors": [ "BartoszKlonowski", "meltuhamy" ], "repo": "reactjs/react.dev", "url": "https://github.com/reactjs/react.dev/pull/1180", "license": "CC-BY-4.0", "license_type": "permissive", "license_source": "github-api" }
263520331
Online IDE in the documentation Continuing the conversation on Twitter here: twitter.com/acemarke/status/913891217385168896. I think it would be very beneficial for beginners to use CodeSandbox/Stackblitz/WebpackBin to start learning React. The environment is like a local code editor, which means that the user already gets familiar with the feel of a code editor. The user doesn't have to install any tooling, so you can start immediately. Also, whenever they want to continue offline they can easily click on 'Download'/'Export' to get a CRA version of the same application so they can work further on it. I think we all agree that this would be beneficial, the question is how to approach this without confusing the user. Would be great to have a discussion on this here. I'm looking forward for this, Personally i prefer codesandbox. Hi, it looks like this has been pretty extensively done throughout the website. I think this can be closed since we link to CodeSandbox pretty commonly. The only thing I can think of adding to this would be embedding CodeSandbox, but I think that would warrant a new issue anyway. So I think this can be closed.
gharchive/issue
2017-10-06T17:38:34
2025-04-01T06:45:36.416235
{ "authors": [ "CompuIves", "damaera", "micpap25" ], "repo": "reactjs/reactjs.org", "url": "https://github.com/reactjs/reactjs.org/issues/18", "license": "CC-BY-4.0", "license_type": "permissive", "license_source": "github-api" }
214075850
Closed STDIN returns endless stream of random data While working on #37, I've tested the following simple and quite common code to check possible combinations of readable/writable streams and closing/ending either side: $stdout = new Stream(STDOUT, $loop); $stdout->pause(); $stdin = new Stream(STDIN, $loop); $stdin->pipe($stdout); Here's what works as expected: $ php test.php #interactive STDIO $ echo test | test.php # STDIN ends once receiving input $ true | php test.php # STDIN ends immediately $ php test.php < /dev/null # STDIN ends immediately $ php test.php < /dev/zero # endless STDIN stream $ php test.php < /dev/urandom #endless STDIN stream $ php test.php > /dev/null # STDOUT closes when trying to write, thus pausing STDIN Here's what does not work (on most of my systems, more below): $ php test.php <&- # no STDIN should error and/or close $ php test.php >&- # no STDOUT should error and/or close when trying to write It turns out explicitly passing no handle actually results in a default stream for all STDIO streams (STDIN, STDOUT and STERR). Arguably, this may be a sane default behavior if this default stream would follow expected behavior for closed streams, but unfortunately it does not. Unfortunately, this default stream behaves just like an endless stream of random data. In fact, it actually is /dev/urandom. This can be verified by checking /proc/{PID}/fd. And it turns out this is not in fact related to ReactPHP at all and can be reproduced with the most simple PHP scripts. Here's a very simple gist to reproduce this output: $ LANG=en php -r 'var_dump(!!fstat(STDIN));passthru("ls -o /proc/".getmypid()."/fd");' <&- This SHOULD show false (because STDIN is not a valid stream) and SHOULD not include file descriptor 0 in the listing. Note that I could reproduce this in multiple setups, but have seen other setups where this does not occur. As such, I'm opening this ticket to gather more information on why this happens and how this could possibly be avoided. Unless I'm missing something obvious, it looks like this may boil down to an issue in PHP itself, but I'd rather collect more evidence first. PHP 7.0.15 on Ubuntu 16.04: STDIN defaults to /dev/urandom PHP 5.3.10 on Ubuntu 12.04: :white_check_mark: STDIN is closed PHP 7.1.2 from Docker php:7.1 STDIN defaults to dev/urandom PHP 5.6.8 from Docker php:5.6 STDIN defaults to dev/urandom I executed the gist and got the following: $ LANG=en php -r 'var_dump(!!fstat(STDIN));passthru("ls -o /proc/".getmypid()."/fd");' <&- Command line code:1: bool(false) total 0 lr-x------ 1 legionth 64 Mar 14 15:40 0 -> pipe:[174916] lrwx------ 1 legionth 64 Mar 14 15:40 1 -> /dev/pts/17 lrwx------ 1 legionth 64 Mar 14 15:40 2 -> /dev/pts/17 This looks good to me, nothing about dev/urandom. :thinking: Executed this with this version: $ php --version PHP 7.0.8-0ubuntu0.16.04.3 (cli) ( NTS ) Copyright (c) 1997-2016 The PHP Group Zend Engine v3.0.0, Copyright (c) 1998-2016 Zend Technologies with Zend OPcache v7.0.8-0ubuntu0.16.04.3, Copyright (c) 1999-2016, by Zend Technologies with Xdebug v2.4.0, Copyright (c) 2002-2016, by Derick Rethans Just tried this with Amp, it does indeed dump random data with the NativeDriver. <?php require "vendor/autoload.php"; use Amp\Loop; // Loop::set(new Loop\NativeDriver); Loop::run(function () { Loop::onReadable(STDIN, function ($watcherId) { var_dump("READ", fread(STDIN, 8192)); var_dump("EOF", feof(STDIN)); if (feof(STDIN)) { Loop::cancel($watcherId); } }); }); EvDriver shows the same behavior. However, this doesn't happen with uv nor event. UvDriver fails with the following error: Fatal error: uv_poll_init_socket(): uv_poll_init failed in UvDriver.php on line 182 EventDriver fails with the following error: Warning: Event::add(): Epoll ADD(1) on fd 0 failed. Old events were 0; read change was 1 (add); write change was 0 (none): Operation not permitted in EventDriver.php on line 238 Warning: Event::add(): Failed adding event in EventDriver.php on line 238 @kelunik This looks like you're affected by the same issue. Can you report the PHP version and the output of the gist as given above? It looks like this may in fact be a PHP issue, but we have yet to dive deeper. Some systems seem to be not affected (see @legionth's output). In case you're affected, this really affects the most simple scripts, you can really confuse any interactive CLI tool, like psysh, boris, those building on top of Symfony console etc. etc. LANG=en php -r 'var_dump(!!fstat(STDIN));passthru("ls -o /proc/".getmypid()."/fd");' <&- bool(true) total 0 lr-x------ 1 kelunik 64 Mar 14 15:54 0 -> /dev/urandom lrwx------ 1 kelunik 64 Mar 14 15:54 1 -> /dev/pts/1 lrwx------ 1 kelunik 64 Mar 14 15:54 2 -> /dev/pts/1 lr-x------ 1 kelunik 64 Mar 14 15:54 3 -> pipe:[5172278] Running on PHP 7.1.3RC1. I don't think this is related to PHP, but probably rather the underlying system. I'm on Ubuntu 16.04.2 LTS. Ok, that's not true, it's not done by the system, (1) because Uv and Event wouldn't fail in that case and (2) because head -c 8 <&- errors out like it should. @clue FD 0 just gets reused. As 0 isn't used yet, that's taken. ┌[kelunik@kelunik] - [~/GitHub/php/php-src] - [16:11:04] - [master] └[5415] $ LANG=en php -r 'var_dump(!!fstat(STDIN));passthru("ls -o /proc/".getmypid()."/fd");' <&- bool(true) total 0 lr-x------ 1 kelunik 64 Mar 14 16:13 0 -> /dev/urandom lrwx------ 1 kelunik 64 Mar 14 16:13 1 -> /dev/pts/1 lrwx------ 1 kelunik 64 Mar 14 16:13 2 -> /dev/pts/1 lr-x------ 1 kelunik 64 Mar 14 16:13 3 -> pipe:[5183812] ┌[kelunik@kelunik] - [~/GitHub/php/php-src] - [16:13:07] - [master] └[5416] $ LANG=en php -r 'var_dump(!!fstat(STDIN));passthru("ls -o /proc/".getmypid()."/fd");' bool(true) total 0 lrwx------ 1 kelunik 64 Mar 14 16:13 0 -> /dev/pts/1 lrwx------ 1 kelunik 64 Mar 14 16:13 1 -> /dev/pts/1 lrwx------ 1 kelunik 64 Mar 14 16:13 2 -> /dev/pts/1 lr-x------ 1 kelunik 64 Mar 14 16:13 3 -> /dev/urandom lr-x------ 1 kelunik 64 Mar 14 16:13 4 -> pipe:[5183821] This is due to https://github.com/php/php-src/blob/16ae9f82e82e2aea5d7deaf8f9a9c825a56dfcc1/ext/standard/php_fopen_wrapper.c#L265 just duplicating instead of registering STDIN as an already closed stream. Thanks to @bwoebi for finding the right place. Thanks to @kelunik for reporting this upstream: https://bugs.php.net/bug.php?id=74252 It looks like there's little we can do about this on our end, so we may as well document and close this? :+1: For the reference only: I'm no longer able to reproduce this issue with a default PHP installation on Ubuntu (PHP 7.0.22-0ubuntu0.17.04.1): $ LANG=en php -r 'var_dump(!!fstat(STDIN));passthru("ls -o /proc/".getmypid()."/fd");' <&- Command line code:1: bool(false) total 0 lr-x------ 1 me 64 Nov 1 13:29 0 -> pipe:[58524] lrwx------ 1 me 64 Nov 1 13:29 1 -> /dev/pts/1 lrwx------ 1 me 64 Nov 1 13:29 2 -> /dev/pts/1 I am having the same problem with 7.2-fpm-alpine on docker.
gharchive/issue
2017-03-14T13:43:43
2025-04-01T06:45:36.467459
{ "authors": [ "clue", "kelunik", "legionth", "mvillalba2016" ], "repo": "reactphp/stream", "url": "https://github.com/reactphp/stream/issues/81", "license": "mit", "license_type": "permissive", "license_source": "bigquery" }
1954491928
Adding Loading Animation to website A cool Loading Animation to the website would be great like a react logo spinner etc Hi @Ayusht777, Can I work on this issue? if the owner allow than okay
gharchive/issue
2023-10-20T15:09:05
2025-04-01T06:45:36.469171
{ "authors": [ "Ayusht777", "vedant-28" ], "repo": "reactplay/activities", "url": "https://github.com/reactplay/activities/issues/155", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
2583176426
(refactor) coverImageUtil, fakeUser and formatCount common/utils methods First thing, PLEASE READ THIS: ReactPlay Code Review Checklist Description PR Summary: Refactored coverImageUtil , formatDurationCount, fakeUser and formatCount function to use constants for time-related values. Moved time thresholds (SECONDS_IN_MINUTE and SECONDS_IN_HOUR) to a separate utilsConstants.ts file for improved readability and maintainability. Updated the function to import and use these constants, reducing magic numbers and enhancing reusability. These changes improve code organization and ensure easier management of constants across the codebase. Fixes #1550 Type of change Please delete options that are not relevant. [ ] Bug fix (non-breaking change which fixes an issue) [ ] New feature (non-breaking change which adds functionality) [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) [ ] This change requires a documentation update How Has This Been Tested? Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Checklist: [X] I have performed a self-review of my own code [X] I have commented my code, particularly in hard-to-understand areas [X] I have made corresponding changes to the documentation [X] My changes generate no new warnings [ ] I have added tests that prove my fix is effective or that my feature works [ ] New and existing unit tests pass locally with my changes [ ] Any dependent changes have been merged and published in downstream modules Screenshots or example output coverImageUtil() method output that shows nothing break after refactoring, banner image is shown properly fakeUser() method output that shows nothing break after refactoring, user data shown properly using fakeUser() method formatDurationCount() and formatViewCount() methods give us the same output, as the previous @all-contributors please add @saddamhr for code
gharchive/pull-request
2024-10-12T15:29:23
2025-04-01T06:45:36.477626
{ "authors": [ "saddamhr" ], "repo": "reactplay/react-play", "url": "https://github.com/reactplay/react-play/pull/1553", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
1584436222
feat(readr): add LayoutWithLogoOnly 更新內容 增加 LayoutWithLogoOnly 的 layout 增加 客製化錯誤頁 (_error, draft) 增加 關於我們頁 (about, draft) 增加 隱私政策頁 (privacy-rule) 增加 SITE_TITLE 設定 修正 footer 中,社群連結 icon 缺少可識別資訊的問題 因應該 commit https://github.com/readr-media/readr-ui/commit/110e741f6484aa4e57cc053155ed5700dc49b4f2 ,調整 footer 的 copyright 資訊 先在 HeaderLogo 元件上增加 TODO comment,等待共用元件完成後再作取代。
gharchive/pull-request
2023-02-14T16:08:14
2025-04-01T06:45:36.484633
{ "authors": [ "erase2004" ], "repo": "readr-media/Sachiel", "url": "https://github.com/readr-media/Sachiel/pull/296", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
105986655
Add a method to calculate the length of an SBE message If you're using an API which requires you to allocate or claim a block of memory in order to write the SBE message into it then you need to know the length of the encoded message. This can be calculated by BLOCK_LENGTH + sum(length of each variable data field + size of length field of each variable data field). However this couples users of the API to the details of the encoding and requires them to know that the size of length fields aren't part of the BLOCK_LENGTH. Having a static requiredLength() method would make the API easier to use. The proposed method should also account for repeating groups. One query is: what is the required memory for a message with X repeating group entries. The inverse is: how many repeating group entries can be held by a buffer or datagram of length Y. This would be useful to help maximize bandwidth utilization. To make this work we will need a signature that takes the number of repeating groups and a collection of all var data items. This could get quite complicated with var data in repeating groups, or repeating groups within repeating groups. In the case of var data containing strings that needs to be encoded to a variable width encoding like UTF-8 then we would need to do the encoding before determining the length, or conservatively estimate. Is there a possible minimum set that would be useful?
gharchive/issue
2015-09-11T10:42:09
2025-04-01T06:45:36.501210
{ "authors": [ "RichardWarburton", "donmendelson", "mjpt777" ], "repo": "real-logic/simple-binary-encoding", "url": "https://github.com/real-logic/simple-binary-encoding/issues/291", "license": "apache-2.0", "license_type": "permissive", "license_source": "bigquery" }
295328273
Update README.md with examples Move Installation section to the top as this is pretty important. Add lots of examples for every command. This is way better to quickly understand then giving some possible params. Thank you ❤️ , looks way better now. I like the examples!
gharchive/pull-request
2018-02-07T23:14:04
2025-04-01T06:45:36.528197
{ "authors": [ "metalmatze", "realfake" ], "repo": "realfake/fubectl", "url": "https://github.com/realfake/fubectl/pull/3", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }