id stringlengths 4 10 | text stringlengths 4 2.14M | source stringclasses 2
values | created timestamp[s]date 2001-05-16 21:05:09 2025-01-01 03:38:30 | added stringdate 2025-04-01 04:05:38 2025-04-01 07:14:06 | metadata dict |
|---|---|---|---|---|---|
110558504 | add RDATE parsing
Closed by #411
| gharchive/pull-request | 2015-10-08T23:05:05 | 2025-04-01T06:46:36.261478 | {
"authors": [
"JackDunham",
"seejohnrun"
],
"repo": "seejohnrun/ice_cube",
"url": "https://github.com/seejohnrun/ice_cube/pull/305",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
} |
158507236 | added variable sensu_pkg_version to Debian and Ubuntu installs
Closed in favor of #47 , which also allows control of CentOS.
| gharchive/pull-request | 2016-06-04T14:32:02 | 2025-04-01T06:46:36.262175 | {
"authors": [
"letac",
"smuth4"
],
"repo": "sensu/sensu-ansible",
"url": "https://github.com/sensu/sensu-ansible/pull/23",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
} |
376001760 | Json as return format from script
Let's start with simple json object containing:
status
output
errorOutput
| gharchive/issue | 2018-10-31T14:51:36 | 2025-04-01T06:46:36.268949 | {
"authors": [
"GoebelL",
"kowalczyka"
],
"repo": "servicecatalog/oscm-app-shell",
"url": "https://github.com/servicecatalog/oscm-app-shell/issues/9",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
519985142 | Public Landing Page refreshed
Close Epic, as all Issues are solved.
| gharchive/issue | 2019-11-08T12:20:12 | 2025-04-01T06:46:36.269677 | {
"authors": [
"farmakiG"
],
"repo": "servicecatalog/oscm",
"url": "https://github.com/servicecatalog/oscm/issues/535",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
757382138 | tobytes/frombytes factories
Added.
| gharchive/issue | 2020-12-04T20:26:05 | 2025-04-01T06:46:36.272121 | {
"authors": [
"william-silversmith"
],
"repo": "seung-lab/mapbuffer",
"url": "https://github.com/seung-lab/mapbuffer/issues/3",
"license": "BSD-3-Clause",
"license_type": "permissive",
"license_source": "github-api"
} |
569222125 | updated authentication to work with backends using middle-auth-client 2
closing in favor of #414
| gharchive/pull-request | 2020-02-21T22:45:45 | 2025-04-01T06:46:36.272777 | {
"authors": [
"chrisj"
],
"repo": "seung-lab/neuroglancer",
"url": "https://github.com/seung-lab/neuroglancer/pull/412",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
} |
435555581 | Longer instructions for installing app and setting scopes
Changes made.
thx
| gharchive/pull-request | 2019-04-21T22:57:16 | 2025-04-01T06:46:36.273712 | {
"authors": [
"puzzlement",
"sgratzl"
],
"repo": "sgratzl/slack-cleaner",
"url": "https://github.com/sgratzl/slack-cleaner/pull/49",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
413957555 | Can't run "npm install" on macOS
I guess the version of package is too old.
| gharchive/issue | 2019-02-25T06:48:59 | 2025-04-01T06:46:36.294147 | {
"authors": [
"shlinym"
],
"repo": "shlinym/electron-serialtool",
"url": "https://github.com/shlinym/electron-serialtool/issues/1",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
59941702 | remove angular-mocks dependency from bower.json
Hi @siddii,
When you will have the time, could you update the angular-timer bower package with this PR merged?
@polomarcus - I pushed a new version v1.3.1. Can you please verify if all looks OK?
Everything looks fine to me, thanks for merging the code @siddii
| gharchive/pull-request | 2015-03-05T11:53:44 | 2025-04-01T06:46:36.405024 | {
"authors": [
"polomarcus",
"siddii"
],
"repo": "siddii/angular-timer",
"url": "https://github.com/siddii/angular-timer/pull/163",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
} |
805460851 | Add dobby
/dobby version minor
/dobby version minor
| gharchive/pull-request | 2021-02-10T12:15:08 | 2025-04-01T06:46:36.413213 | {
"authors": [
"punitcse"
],
"repo": "simplybusiness/twiglet-ruby",
"url": "https://github.com/simplybusiness/twiglet-ruby/pull/24",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
54245306 | Added Fonts
Could use more content.
Maybe a list of great articles about fonts.
| gharchive/pull-request | 2015-01-13T20:41:53 | 2025-04-01T06:46:36.414089 | {
"authors": [
"brabadu",
"sindresorhus"
],
"repo": "sindresorhus/awesome",
"url": "https://github.com/sindresorhus/awesome/pull/72",
"license": "CC0-1.0",
"license_type": "permissive",
"license_source": "github-api"
} |
585365409 | Improving test coverage [adding Thread]
I'll close this with a +0.22% of test coverage.
Let me know if you need some other test covered.
| gharchive/issue | 2020-03-20T22:49:17 | 2025-04-01T06:46:36.430685 | {
"authors": [
"stefanofiorentino"
],
"repo": "skypjack/uvw",
"url": "https://github.com/skypjack/uvw/issues/181",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
} |
330355806 | Upgrade fs2 and cats-effect to 1.x
@wemrysi Floating an idea regarding the smock woes… What if we provide a utility function in smock which applies when you're using a coproduct inside your Free where one side matches the effect monad of the test itself? Such a function would then transparently sequence all effects which appear on the impure side of the coproduct, allowing you to write resilient tests on the pure side.
@djspiewak Aye, that sounds good, much more declarative.
@wemrysi Race you to a smock PR. ;-)
Swapped to feature since it's a compatibility-affecting change due to the classpath shift.
Interesting- how about Stream(x, y).join(2) in place of merge (just as a test)?
On Jun 8, 2018, at 8:58 PM, Emrys Ingersoll notifications@github.com wrote:
@wemrysi commented on this pull request.
In yggdrasil/src/test/scala/quasar/yggdrasil/vfs/SerialVFSSpecs.scala:
_ <- Task delay {
dir.exists() mustEqual true
Files.createFile(new File(dir, "test").toPath())
}
_ <- vfs.commit(blob, version)
_ <- vfs.link(blob, Path.rootDir </> Path.file("foo"))
} yield ()
_ <- Stream.eval(ta)
} yield ()
test.take(1).run.unsafePerformSync
val test = SerialVFS[IO](base).mapAsync(1)(vfs => for {
@djspiewak @mpilquist I just tried concurrently again and it actually works when we're playing by the rules in SerialVFSSpecs and I'm able to change all the mapAsyncs there to evalMaps.
However, since our production usage runs the outer stream due to reasons, that usage halts things immediately (i.e. our regression tests don't run).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
So the failure in the lwc_local tests is due to the lib we’re using to provide a cats.effect.Effect[Task] instance not supporting cats-effect-1.0.0-RC2. I’m looking into adding said support.
I've replaced our usage of https://github.com/christopherdavenport/scalaz-task-effect with a local implementation compatible with cats-effect-1.0.0-RC2. I have a PR open upstream and we can switch back to it once it's been merged if we're still using Task at that point.
| gharchive/pull-request | 2018-06-07T16:52:53 | 2025-04-01T06:46:36.440152 | {
"authors": [
"djspiewak",
"mpilquist",
"wemrysi"
],
"repo": "slamdata/quasar",
"url": "https://github.com/slamdata/quasar/pull/3625",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
} |
476336806 | add-route-arguments-as-attributes-to-the-request-handler-strategy
Coverage remained the same at 100.0% when pulling 1e5d970e37788a50229a8487c9c73ebb4f7f011c on dominikzogg:add-route-arguments-as-attributes-to-the-request-handler-strategy into 2b0ed80b2ab4acfb5e7648797b8202e4d9aea06d on slimphp:4.x.
I’m not sure I’m in favour of doing this. Why can’t we add this to RouteContext Instead. @adriansuter thoughts?
@l0gicgate please don't, cause it make the code of the request handler framework depending on the framework. Expressive and my own work with attribute for the arguments, it seems to be common practice.
How does that make it dependant though? You can already retrieve the route arguments via the route attribute from the RouteContext object.
To me filling up the request’s attributes with a for loop seems like object pollution. I don’t like the “shove it all in there” approach without structure.
With the default strategy it’s contained in $args at least. Also, for the record, you can create your own invocation strategy to achieve this, I don’t agree that this should be default behavior.
RouteContext is Slim only, using PSR15 and still depend on the framework is useless to me. Strategy is not changeable, see https://github.com/slimphp/Slim/blob/2b0ed80b2ab4acfb5e7648797b8202e4d9aea06d/Slim/Routing/Route.php#L366
I think by default we should leave the route arguments in the $args array.
But feel free to create your own route strategy (https://www.slimframework.com/docs/v4/objects/routing.html#route-strategies) or build a middleware that does exactly what you need.
// Middleware (needs to be called after the routing middleware and therefore has to be added before)
$app->add(function (Request $request, \Psr\Http\Server\RequestHandlerInterface $requestHandler) {
/** @var Slim\Routing\Route\Route $route */
$route = $request->getAttribute('route');
foreach ($route->getArguments() as $key => $val) {
$request = $request->withAttribute($key, $val);
}
return $requestHandler->handle($request);
});
Just make sure, that you would not overwrite existing attributes!
@adriansuter as mentioned in my previous post gets the strategy overridden if the controller implements the RequestHandlerInterface. Middleware would work.
But I don't see the point why you're not interested in being compatible with other microframeworks work with PSR15.
I couldn't find any information in the specs of PSR-15 about storing the route placeholders in the server request. Could you give me a link?
Or is this some kind of common silent agreement between many microframeworks? If yes, do you have a list of microframeworks that support this kind of behaviour?
@adriansuter it’s not common practice. And as I said, this can be achieved with creating a different invocation strategy which we could include for users to use if they wanted too.
Then you can set the default invocation strategy with $app->getRouteCollector()->setDefaultInvocationStrategy($requestHandlerWithRouteArgumentsAsAttributesStrategy)
Every route you map thereafter will have that strategy and do what you want.
@l0gicgate @adriansuter
Please read the mentioned if statement to see, that changing the strategy is not possible without a code change.
About common: path values as attribute was default in Slim 3 and is in Expressive.
About middleware: Adding a middleware would mean a general behavior change cause I would need to route first.
About Route Context: this context exists only in slim, so I loose the benefits of PSR15.
@dominikzogg we need to change the logic in the Route component to accept custom strategies for RequestHandler. I can PR this later today. Then we can add a new invocation strategy for that.
@l0gicgate thank you
Follow discussion in #2774
| gharchive/pull-request | 2019-08-02T20:06:01 | 2025-04-01T06:46:36.452724 | {
"authors": [
"adriansuter",
"coveralls",
"dominikzogg",
"l0gicgate"
],
"repo": "slimphp/Slim",
"url": "https://github.com/slimphp/Slim/pull/2773",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
134860997 | JS validations for scheduling Closes #29, Closes #31
@ganeshbsub wrong fork ;)
| gharchive/pull-request | 2016-02-19T13:09:30 | 2025-04-01T06:46:36.458170 | {
"authors": [
"ganeshbsub",
"oliverbarnes"
],
"repo": "smartchicago/kimball",
"url": "https://github.com/smartchicago/kimball/pull/161",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
} |
142435144 | Update travis.yml
:+1: for :white_check_mark: tests.
| gharchive/pull-request | 2016-03-21T18:39:42 | 2025-04-01T06:46:36.469038 | {
"authors": [
"jhawthorn",
"stewart"
],
"repo": "solidusio/solidus_auth_devise",
"url": "https://github.com/solidusio/solidus_auth_devise/pull/39",
"license": "bsd-3-clause",
"license_type": "permissive",
"license_source": "bigquery"
} |
320829936 | wip: added few js libraries
it appears this pr contains a few libraries that we don't yet support, for example, gulpjs/gulp. @yandzee would you mind to update it please?
This is obsolete.
| gharchive/pull-request | 2018-05-07T14:38:30 | 2025-04-01T06:46:36.474162 | {
"authors": [
"asurkov",
"sergey64k",
"yandzee"
],
"repo": "sourcerer-io/awesome-libraries",
"url": "https://github.com/sourcerer-io/awesome-libraries/pull/1",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
303146964 | Fix title space in readme
Thanks!
| gharchive/pull-request | 2018-03-07T15:38:12 | 2025-04-01T06:46:36.477966 | {
"authors": [
"TVke",
"freekmurze"
],
"repo": "spatie/googlesearch",
"url": "https://github.com/spatie/googlesearch/pull/19",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
} |
55117270 | Add mini logo, update logo in readme
Check how it looks over here.
LGTM! (G == Great) :)
| gharchive/pull-request | 2015-01-22T05:55:44 | 2025-04-01T06:46:36.481313 | {
"authors": [
"Tarrasch",
"ravwojdyla"
],
"repo": "spotify/snakebite",
"url": "https://github.com/spotify/snakebite/pull/133",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
} |
261089763 | Align ManagementServerPortUtils strategy from boot 2
@spencergibb could you add some details to the description of the issue? If you think this can be done in Hoxton.SR1 can you move it there?
| gharchive/issue | 2017-09-27T19:24:52 | 2025-04-01T06:46:36.482767 | {
"authors": [
"ryanjbaxter",
"spencergibb"
],
"repo": "spring-cloud/spring-cloud-commons",
"url": "https://github.com/spring-cloud/spring-cloud-commons/issues/256",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
} |
687319716 | LB integration hoxton
Fixes gh-516 in Hoxton.
Have verified that the SC LoadBalancer opt-in mechanism works OOTB here.
| gharchive/pull-request | 2020-08-27T15:06:59 | 2025-04-01T06:46:36.483776 | {
"authors": [
"OlgaMaciaszek"
],
"repo": "spring-cloud/spring-cloud-kubernetes",
"url": "https://github.com/spring-cloud/spring-cloud-kubernetes/pull/610",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
445748344 | rayan commit
@skas0831 Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.
| gharchive/pull-request | 2019-05-18T19:49:21 | 2025-04-01T06:46:36.486774 | {
"authors": [
"pivotal-issuemaster",
"skas0831"
],
"repo": "spring-projects/spring-petclinic",
"url": "https://github.com/spring-projects/spring-petclinic/pull/415",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
581429708 | Add jenkinsfile
@mohhef Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.
| gharchive/pull-request | 2020-03-15T00:08:51 | 2025-04-01T06:46:36.488643 | {
"authors": [
"mohhef",
"pivotal-issuemaster"
],
"repo": "spring-projects/spring-petclinic",
"url": "https://github.com/spring-projects/spring-petclinic/pull/551",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
600713255 | Question 1
@viveanban Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.
@viveanban Thank you for signing the Contributor License Agreement!
| gharchive/pull-request | 2020-04-16T03:05:37 | 2025-04-01T06:46:36.490839 | {
"authors": [
"pivotal-issuemaster",
"viveanban"
],
"repo": "spring-projects/spring-petclinic",
"url": "https://github.com/spring-projects/spring-petclinic/pull/615",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
898177178 | Datatable : total sum for cost.
@vasanthkg it's already done, sorry if the information didn't reach on time.. thanks for the hardwork, Take it easy 😉 ...
@vasanthkg feel free to reopen if anything specifically you think your code is doing which is not in the existing logic!
| gharchive/pull-request | 2021-05-21T15:47:52 | 2025-04-01T06:46:36.498639 | {
"authors": [
"sreekanthsnair",
"vasanthkg"
],
"repo": "sreekanthsnair/project-tracker",
"url": "https://github.com/sreekanthsnair/project-tracker/pull/14",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
465907916 | Set custom file name when adding via ZipFile.addFile
Fixed in v2.1.0
| gharchive/issue | 2019-07-09T17:47:00 | 2025-04-01T06:46:36.499476 | {
"authors": [
"srikanth-lingala"
],
"repo": "srikanth-lingala/zip4j",
"url": "https://github.com/srikanth-lingala/zip4j/issues/16",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
591391938 | SIPs governance proposal
Shared doc / WIP: https://docs.google.com/document/d/1huF3u6BlrEapbjw77wGp_lq3d3kC17ZugCalvpN8M3U/edit?usp=sharing
Draft text proposal, based on the above document: https://github.com/stacksorg/sips/blob/master/sip-000/sip-000.md
Slide deck on the above proposed SIP-000: https://docs.google.com/presentation/d/1k0VB5k5kVrSfib33yaq5n-ZGkrl1ueunqWj7eSKuVm8/edit#slide=id.g8b7270c087_0_48
| gharchive/issue | 2020-03-31T20:10:17 | 2025-04-01T06:46:36.507762 | {
"authors": [
"jcnelson",
"lrettig",
"whoabuddy"
],
"repo": "stacksgov/proposals",
"url": "https://github.com/stacksgov/proposals/issues/1",
"license": "CC0-1.0",
"license_type": "permissive",
"license_source": "github-api"
} |
659138460 | add go releaser
@fahad-rauf Image is available for testing. docker pull stakater/whitelister:SNAPSHOT-PR-13-1
@fahad-rauf Image is available for testing. docker pull stakater/whitelister:SNAPSHOT-PR-13-2
| gharchive/pull-request | 2020-07-17T10:47:20 | 2025-04-01T06:46:36.512744 | {
"authors": [
"fahad-rauf",
"stakater-user"
],
"repo": "stakater/Whitelister",
"url": "https://github.com/stakater/Whitelister/pull/13",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
463764738 | [WIP] feat(Tooltip): add svg beak in Teams theme
Warnings
:warning:
There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.
Generated by :no_entry_sign: dangerJS
| gharchive/pull-request | 2019-07-03T13:49:53 | 2025-04-01T06:46:36.517993 | {
"authors": [
"DustyTheBot",
"mnajdova"
],
"repo": "stardust-ui/react",
"url": "https://github.com/stardust-ui/react/pull/1580",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
618730857 | 按客户要求的审批王html字段只读时的表格样式优化
已兼容申请单打印，可编辑，待审批，进行中等各种情况下html字段样式
本次修改只影响审批王中html字段只读效果，不影响可编辑时的控件效果，也不影响cms等其他地方的html字段效果
规则是：判断到html字段中只有table标签内容，没有其他比如文字，h,a,b等任何标签内容时才把html内容中的表格做撑满单元框,去除边线等样式优化；否则保持本次修改之前的效果！
| gharchive/issue | 2020-05-15T06:27:15 | 2025-04-01T06:46:36.521538 | {
"authors": [
"yinlianghui"
],
"repo": "steedos/creator",
"url": "https://github.com/steedos/creator/issues/1777",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
206996491 | Allow setting JAVA_OPTS on maven plugin
Fixed by #80
| gharchive/issue | 2017-02-11T17:55:29 | 2025-04-01T06:46:36.533004 | {
"authors": [
"wattazoum"
],
"repo": "strator-dev/greenpepper",
"url": "https://github.com/strator-dev/greenpepper/issues/77",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
} |
138656893 | add hyperscript-attribute-to-property
For some context, this patch means you won't need to
hx`<div className="whatever"></div>`
you can simply do:
hx`<div class="whatever"></div>`
Package readme is here: https://github.com/feross/hyperscript-attribute-to-property
I bumped the major because some libs like deku (which is in the hyperx examples) don't (yet) alias className to class.
| gharchive/pull-request | 2016-03-05T07:07:44 | 2025-04-01T06:46:36.539354 | {
"authors": [
"feross",
"substack"
],
"repo": "substack/hyperx",
"url": "https://github.com/substack/hyperx/pull/22",
"license": "bsd-2-clause",
"license_type": "permissive",
"license_source": "bigquery"
} |
223686992 | Adding another test
Trying again after fixing email address
| gharchive/pull-request | 2017-04-24T02:03:29 | 2025-04-01T06:46:36.539970 | {
"authors": [
"sukottokun"
],
"repo": "sukottokun/circle",
"url": "https://github.com/sukottokun/circle/pull/2",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
587831978 | Add disabled attribute to summernote directive.
No funcionó Trix
| gharchive/pull-request | 2020-03-25T16:38:22 | 2025-04-01T06:46:36.551420 | {
"authors": [
"Crzech",
"aalonzolu"
],
"repo": "summernote/angular-summernote",
"url": "https://github.com/summernote/angular-summernote/pull/216",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
} |
495856319 | v1.2
:tada: This PR is included in version 1.2.0 :tada:
The release is available on:
npm package (@latest dist-tag)
GitHub release
Your semantic-release bot :package::rocket:
| gharchive/pull-request | 2019-09-19T14:59:33 | 2025-04-01T06:46:36.553536 | {
"authors": [
"connor-baer",
"ilyanoskov"
],
"repo": "sumup/circuit-ui",
"url": "https://github.com/sumup/circuit-ui/pull/476",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
313566569 | feat: add basic example
Codecov Report
Merging #93 into master will not change coverage.
The diff coverage is n/a.
@@ Coverage Diff @@
## master #93 +/- ##
=======================================
Coverage 85.82% 85.82%
=======================================
Files 5 5
Lines 748 748
=======================================
Hits 642 642
Misses 65 65
Partials 41 41
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f29db0c...143b115. Read the comment docs.
| gharchive/pull-request | 2018-04-12T03:43:28 | 2025-04-01T06:46:36.578598 | {
"authors": [
"codecov-io",
"easonlin404"
],
"repo": "swaggo/swag",
"url": "https://github.com/swaggo/swag/pull/93",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
152735105 | Updated dependencies for Symfony 2.8.5
Hey, this PR update Symfony up to v2.8.5 only
@javiereguiluz updating the commit message and the PR title would be a good idea.
@bocharsky-bw 😱 😱 😱 I don't know what I was thinking. I'm closing this PR. Will you send a PR for 2.8.5 as you usually do? thanks!
Sorry for the noise! I was using the Symfony Demo to test Symfony 3.1 (to write the blog posts, to test the Cache component, etc.) So I made lots of changes in the composer.json file and the app and then reverted everything and I wasn't sure if I had updated to 2.8.x or 3.x.
| gharchive/pull-request | 2016-05-03T09:38:37 | 2025-04-01T06:46:36.585196 | {
"authors": [
"bocharsky-bw",
"javiereguiluz",
"stof"
],
"repo": "symfony/symfony-demo",
"url": "https://github.com/symfony/symfony-demo/pull/333",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
} |
507837255 | Tweak CI config
bors r+
| gharchive/pull-request | 2019-10-16T13:01:31 | 2025-04-01T06:46:36.603770 | {
"authors": [
"taiki-e"
],
"repo": "taiki-e/derive_utils",
"url": "https://github.com/taiki-e/derive_utils/pull/24",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
119323292 | any idea in best way to integrate this sample with backend parse.com?
I did a google and some things came up:
http://www.raywenderlich.com/106369/integrating-parse-react-native-ios
https://github.com/ParsePlatform/ParseReact
High level, you'll need to be able to write and read data -- the library should work for that.
In this sample app it should work if you switch out at library for the http client and the service layer.
For example, the PostService
which handles reading and writing those objects.
Thanks, yeah agree. Service Layer is the best way to switch it to parse
| gharchive/issue | 2015-11-28T22:57:45 | 2025-04-01T06:46:36.616148 | {
"authors": [
"bleonard",
"steve21124"
],
"repo": "taskrabbit/ReactNativeSampleApp",
"url": "https://github.com/taskrabbit/ReactNativeSampleApp/issues/10",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
} |
723265965 | Add CI
Fixed in https://github.com/tdegeus/FrictionQPotFEM/pull/12
| gharchive/issue | 2020-10-16T14:16:01 | 2025-04-01T06:46:36.620068 | {
"authors": [
"tdegeus"
],
"repo": "tdegeus/FrictionQPotFEM",
"url": "https://github.com/tdegeus/FrictionQPotFEM/issues/4",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
499845749 | 魅族16x开启夜间模式，系统崩溃
这个问题可以直接在异常代码进行捕获处理
@Override
protected void dispatchDraw(Canvas canvas) {
// 由于在魅族夜间模式渲染会有问题，加异常捕获处理
try {
if (!isAnimationStarted || getWidth() <= 0 || getHeight() <= 0) {
super.dispatchDraw(canvas);
} else {
dispatchDrawShimmer(canvas);
}
}catch (Exception e){
// Log.i("")
}
}
本地依赖库替换成自己的修改后，这样至少不会crash
| gharchive/issue | 2019-09-29T02:31:27 | 2025-04-01T06:46:36.624220 | {
"authors": [
"caiyishui",
"happinessbyte"
],
"repo": "team-supercharge/ShimmerLayout",
"url": "https://github.com/team-supercharge/ShimmerLayout/issues/81",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
} |
235786904 | added blocks option for lstm2d
Can one of the admins verify this patch?
thanks for review, maybe someone should add these rule in pylint too
Waiting for review!
Jenkins, test this please.
| gharchive/pull-request | 2017-06-14T07:29:13 | 2025-04-01T06:46:36.632354 | {
"authors": [
"drpngx",
"johnsmithm",
"tensorflow-jenkins"
],
"repo": "tensorflow/tensorflow",
"url": "https://github.com/tensorflow/tensorflow/pull/10692",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
376066067 | get testing setup for travis
This is completed
| gharchive/issue | 2018-10-31T17:01:13 | 2025-04-01T06:46:36.632964 | {
"authors": [
"jsnoble"
],
"repo": "terascope/xlucene-evaluator",
"url": "https://github.com/terascope/xlucene-evaluator/issues/5",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
534973028 | Change generics of ExtractAction type from TSource to TKey
:tada: This PR is included in version 3.2.0 :tada:
The release is available on:
GitHub release
npm package (@next dist-tag)
Your semantic-release bot :package::rocket:
:tada: This PR is included in version 3.2.0 :tada:
The release is available on:
GitHub release
npm package (@latest dist-tag)
Your semantic-release bot :package::rocket:
| gharchive/pull-request | 2019-12-09T14:36:34 | 2025-04-01T06:46:36.644629 | {
"authors": [
"kotarella1110",
"thebrodmann"
],
"repo": "thebrodmann/deox",
"url": "https://github.com/thebrodmann/deox/pull/135",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
551070772 | configured stories should be allowed to override built-in stories
Hello, can you describe more? Configured stories currently override built-in stories. Disabling the configured story (story rules) results in getting the built-in answer.
Story rule issue
| gharchive/issue | 2020-01-16T21:39:01 | 2025-04-01T06:46:36.682739 | {
"authors": [
"francoisno",
"vsct-jburet"
],
"repo": "theopenconversationkit/tock",
"url": "https://github.com/theopenconversationkit/tock/issues/742",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
608955443 | Add the models which can deal with unbalanced data
merge unbalanced support
| gharchive/pull-request | 2020-04-29T10:45:38 | 2025-04-01T06:46:36.689014 | {
"authors": [
"Soln-AI",
"zwt233"
],
"repo": "thomas-young-2013/automl-toolkit",
"url": "https://github.com/thomas-young-2013/automl-toolkit/pull/3",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
629314687 | allow specifying kubeconfig
gonna close this and open a new one, forced updated changes not reflected :(
#17
| gharchive/pull-request | 2020-06-02T15:48:51 | 2025-04-01T06:46:36.691287 | {
"authors": [
"mwei0210"
],
"repo": "thyarles/knsk",
"url": "https://github.com/thyarles/knsk/pull/16",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
173514723 | Switch to DirectX and Vulkan coordinates system
Closing because it's not that hard to adjust the coordinates given by immi, and this PR is very hazardous.
| gharchive/pull-request | 2016-08-26T18:28:59 | 2025-04-01T06:46:36.705222 | {
"authors": [
"tomaka"
],
"repo": "tomaka/immi",
"url": "https://github.com/tomaka/immi/pull/17",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
916784510 | DMの履歴みたいなのが欲しい
refs traQ_S-UI#921
直近話した相手が並ぶとかでいいのかなって感じ
向こうからの通知だけでなく自分の発言も考慮したほうがよさそうなので、新しく API 生やさないといけなそう……？
| gharchive/issue | 2021-06-10T00:52:53 | 2025-04-01T06:46:36.724497 | {
"authors": [
"FujishigeTemma",
"TwoSquirrels",
"sapphi-red"
],
"repo": "traPtitech/traQ",
"url": "https://github.com/traPtitech/traQ/issues/1223",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
777105434 | This Inssue is closed.
ti-o dau pe discord tudoor#9999
o sa sterg acest inssue
| gharchive/issue | 2020-12-31T18:23:09 | 2025-04-01T06:46:36.743901 | {
"authors": [
"tt657"
],
"repo": "tt657/malware",
"url": "https://github.com/tt657/malware/issues/1",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
799548904 | Baseline - Refactor GCP baseline
Repository: https://github.com/omerosaienni/tdk
Branch: baseline-refactor-gcp-baseline
| gharchive/issue | 2021-02-02T18:21:35 | 2025-04-01T06:46:36.746871 | {
"authors": [
"omerosaienni"
],
"repo": "turbot/tdk",
"url": "https://github.com/turbot/tdk/issues/383",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
379338454 | Add missing dependency to package.json
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.
!merge
| gharchive/pull-request | 2018-11-09T22:06:25 | 2025-04-01T06:46:36.759235 | {
"authors": [
"CLAassistant",
"ganemone",
"patrik-piskay"
],
"repo": "uber-web/thrift2flow",
"url": "https://github.com/uber-web/thrift2flow/pull/41",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
348123333 | Fix experimental layers: mesh layer Y-reversal issue
@ibgreen I'm afraid if I fix the projection logic, it might break (or maybe fix?) other layers.
| gharchive/pull-request | 2018-08-07T00:18:14 | 2025-04-01T06:46:36.760126 | {
"authors": [
"georgios-uber"
],
"repo": "uber/deck.gl",
"url": "https://github.com/uber/deck.gl/pull/2167",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
425090915 | Update developer guide pages for performance and binary data usage
Coverage remained the same at 60.087% when pulling 6e298c335ce395805de4a7fba71a3e1956f08b3b on developer-guide-update into a46aac7fe545a1b5948bd3c48b0467569e98fea0 on master.
| gharchive/pull-request | 2019-03-25T20:04:14 | 2025-04-01T06:46:36.761661 | {
"authors": [
"Pessimistress",
"coveralls"
],
"repo": "uber/deck.gl",
"url": "https://github.com/uber/deck.gl/pull/2832",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
218632802 | Documentation improvements & updates
Thanks @Apercu !!! I know that master kept changing today so you are rebasing your changes repeatedly * _ * I'll review your change and help on the rebase
| gharchive/pull-request | 2017-03-31T22:30:31 | 2025-04-01T06:46:36.762694 | {
"authors": [
"Apercu",
"shaojingli"
],
"repo": "uber/deck.gl",
"url": "https://github.com/uber/deck.gl/pull/527",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
188970532 | Simplified API for Uberfire Breadcrumbs and also new breadcrumbs area:toolbar
Parts of the ensemble:
https://github.com/uberfire/uberfire/pull/561
https://github.com/droolsjbpm/kie-wb-common/pull/561
https://github.com/droolsjbpm/drools-wb/pull/339
https://github.com/droolsjbpm/droolsjbpm-build-bootstrap/pull/314
https://github.com/droolsjbpm/kie-wb-distributions/pull/405
+1, but with the following comments:
This is Ok for this interaction, but for next interation I'd like to see some changes:
Breadcrumbs should be a Header, like Brand and Navigation (menus). We already covered this with ordered feature of the Headers.
Maybe add a generic Header that would enable different content (ie. remove the Bradcrumb add toolbar capability). I think have directly into Breadcrumb the addition of a toolbar is mixing concerns. Breadcrumb should be just a navigation capability.
Have the current breadcrumb mechanism always available looks weird where it's not used.
@porcelli thanks. I'll do that in the next iteration,.
This is the right on kie-wb-common: https://github.com/droolsjbpm/kie-wb-common/pull/567
| gharchive/pull-request | 2016-11-13T13:34:22 | 2025-04-01T06:46:36.768420 | {
"authors": [
"ederign",
"porcelli"
],
"repo": "uberfire/uberfire",
"url": "https://github.com/uberfire/uberfire/pull/561",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
} |
153080870 | composer: works with Nette 2.4
@paveljanda Can you update packagist? On packagist is still require ~2.3.0
| gharchive/pull-request | 2016-05-04T18:20:32 | 2025-04-01T06:46:36.769294 | {
"authors": [
"dg",
"legendik"
],
"repo": "ublaboo/datagrid",
"url": "https://github.com/ublaboo/datagrid/pull/207",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
} |
534373996 | Updated_README.md
siimacr-pneumothorax-segmentation.ipynb file is public implementation of the note book with kaggle authorization this note book is implemented in colab if some one wants to try then i will put the link in the readme
lastly i have added radam in the same colab notebook and it runs fine
@pranshurastogi29 can you send me a public nbviewer hosted link to the notebook you committed?
Ok i will give the link
Also please make different PR for each tasks.As a maintainer it's not possible to track every little change if all commits are made into one PR. I mentioned Issues for a reason.
| gharchive/pull-request | 2019-12-07T08:40:27 | 2025-04-01T06:46:36.771721 | {
"authors": [
"pranshurastogi29",
"ucalyptus"
],
"repo": "ucalyptus/Pneumothorax-Segmentation-using-Hypercolumns",
"url": "https://github.com/ucalyptus/Pneumothorax-Segmentation-using-Hypercolumns/pull/35",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
891793069 | cls: parallel column reads in rados parquet
Fixed by #124
| gharchive/issue | 2021-05-14T10:05:07 | 2025-04-01T06:46:36.772426 | {
"authors": [
"JayjeetAtGithub"
],
"repo": "uccross/skyhookdm-arrow",
"url": "https://github.com/uccross/skyhookdm-arrow/issues/123",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
475078074 | 使用docz的Props给组件写mdx文档，发现每次起dev时，Props组件都没有渲染出来，需要手动保存一下组件的导出文件，触发热更新，文档上的Props内容才能渲染出来
你的解决吗？我的都出不来
推荐使用 dumi + father-build 进行组件库研发：https://d.umijs.org/guide/getting-started
| gharchive/issue | 2019-07-31T11:02:54 | 2025-04-01T06:46:36.782103 | {
"authors": [
"PeachScript",
"Symboler",
"lisgking"
],
"repo": "umijs/father",
"url": "https://github.com/umijs/father/issues/80",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
788525055 | Add codecov settings
:tada: This PR is included in version 1.1.2 :tada:
The release is available on:
npm package (@latest dist-tag)
GitHub release
Your semantic-release bot :package::rocket:
:tada: This PR is included in version 1.1.2 :tada:
The release is available on:
npm package (@latest dist-tag)
GitHub release
Your semantic-release bot :package::rocket:
| gharchive/pull-request | 2021-01-18T20:19:45 | 2025-04-01T06:46:36.791909 | {
"authors": [
"untemps"
],
"repo": "untemps/svelte-readotron",
"url": "https://github.com/untemps/svelte-readotron/pull/8",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
202461481 | Clean error handling in app.js
https://engineering.gosquared.com/node-js-error-handling-callbacks-vs-promises
http://www.java2s.com/Tutorials/Javascript/Node.js_Tutorial/0210__Node.js_Errors_Exceptions.htm
https://www.safaribooksonline.com/blog/2014/03/12/error-handling-express-js-applications/
http://code.runnable.com/UTlPPF-f2W1TAAEU/error-handling-with-express-for-node-js
https://stackoverflow.com/questions/7310521/node-js-best-practice-exception-handling
https://www.sitepoint.com/proper-error-handling-javascript/
| gharchive/issue | 2017-01-23T07:17:02 | 2025-04-01T06:46:36.824566 | {
"authors": [
"uwefassnacht"
],
"repo": "uwefassnacht/uwesparty",
"url": "https://github.com/uwefassnacht/uwesparty/issues/32",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
} |
115684704 | Syntax highlighting in the examples
Thanks :)
Thanks for the interesting talk at Reactive 2015. I’ve just watched it ;-)
| gharchive/pull-request | 2015-11-07T18:47:11 | 2025-04-01T06:46:36.825468 | {
"authors": [
"marcelka",
"sapegin"
],
"repo": "vacuumlabs/validation",
"url": "https://github.com/vacuumlabs/validation/pull/10",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
103780692 | Fix URL typos in Cargo.toml
Didn't notice it, thanks! :smile:
| gharchive/pull-request | 2015-08-28T19:26:27 | 2025-04-01T06:46:36.831995 | {
"authors": [
"frewsxcv",
"vberger"
],
"repo": "vberger/wayland-kbd",
"url": "https://github.com/vberger/wayland-kbd/pull/1",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
} |
65679072 | Fixed issue #30: Attribute 'configset_name' is not used in 'zkconfigset' provider
:+1:
| gharchive/pull-request | 2015-04-01T13:02:26 | 2025-04-01T06:46:36.859611 | {
"authors": [
"gdud",
"vkhatri"
],
"repo": "vkhatri/chef-solrcloud",
"url": "https://github.com/vkhatri/chef-solrcloud/pull/31",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
} |
180059819 | clear up the README that the master branch is using Vue2 bei default now
Thanks @vuchl :)
| gharchive/pull-request | 2016-09-29T14:09:24 | 2025-04-01T06:46:36.873221 | {
"authors": [
"LinusBorg",
"vuchl"
],
"repo": "vuejs-templates/webpack",
"url": "https://github.com/vuejs-templates/webpack/pull/285",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
} |
759772503 | Add "Composer ready" milestone
Hmmm. I'm a bit inclined to pick drupal-project as the milestone. The composer templatge brought its innovations into the drupal namespace, along with some related work for drupal.org packaging.
Yeah we could put this in back with the introduction of drupal-composer/drupal-project. I feel like getting Composer in core was a major milestone, but my view is biased because I worked on that. 😄 Folks were managing sites with Composer using the third-party components successfully for years before 8.8.0 came out, though.
You could put in both dates, but if two dots is too many for Composer, then just the earlier date is fine.
| gharchive/pull-request | 2020-12-08T20:52:56 | 2025-04-01T06:46:36.906079 | {
"authors": [
"greg-1-anderson",
"weitzman"
],
"repo": "weitzman/drupal-timeline",
"url": "https://github.com/weitzman/drupal-timeline/pull/3",
"license": "Unlicense",
"license_type": "permissive",
"license_source": "github-api"
} |
86190038 | [resolves #683] Provide pluggable SPI for config tool
Refer to this link for build results (access rights to CI server needed):
https://fabric8-ci.fusesource.com/job/wildfly-camel-pullreq/490/
Test PASSed.
| gharchive/pull-request | 2015-06-08T14:04:17 | 2025-04-01T06:46:36.917909 | {
"authors": [
"fusesource-ci",
"tdiesler"
],
"repo": "wildfly-extras/wildfly-camel",
"url": "https://github.com/wildfly-extras/wildfly-camel/pull/697",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
} |
529659944 | one 2080ti gpu,how long it takes to train on VOC dataset
voc2007???
Two 1080, 30min/epoch
voc2007???
麻烦您给个voc预训练模型的权重文件的网盘地址，国内没办法下载
voc2007???
麻烦您给个voc预训练模型的权重文件的网盘地址
voc2007???
麻烦您给个voc预训练模型的权重文件的网盘地址，国内没办法下载
请问这个问题您解决了吗？我现在也在找VOC的预训练模型，请问您那儿有吗？能否分享一下
| gharchive/issue | 2019-11-28T02:34:57 | 2025-04-01T06:46:36.926619 | {
"authors": [
"albert-rabbit",
"cxjaicj",
"henbucuoshanghai",
"yifeichenNJ"
],
"repo": "wizyoung/YOLOv3_TensorFlow",
"url": "https://github.com/wizyoung/YOLOv3_TensorFlow/issues/185",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
907844137 | Includes subtitles support
Please can you link to where the subtitle entry type is defined in the Bibtex or Zotero specs?
Please can you link to where the subtitle entry type is defined in the Bibtex or Zotero specs?
Subtitle entry is particular to the LLNCS format from Springer. See more info at:
https://www.springer.com/gp/computer-science/lncs/conference-proceedings-guidelines
| gharchive/pull-request | 2021-06-01T03:56:22 | 2025-04-01T06:46:36.934215 | {
"authors": [
"armfazh",
"gcushen"
],
"repo": "wowchemy/hugo-academic-cli",
"url": "https://github.com/wowchemy/hugo-academic-cli/pull/94",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
191687632 | Update Dockerfile with the new port (9187)
Thanks.
| gharchive/pull-request | 2016-11-25T12:02:26 | 2025-04-01T06:46:36.934851 | {
"authors": [
"shamil",
"wrouesnel"
],
"repo": "wrouesnel/postgres_exporter",
"url": "https://github.com/wrouesnel/postgres_exporter/pull/37",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
279043270 | Small changes for me to learn how HTML5 works
So do you want me to merge this? @BloodyEM
| gharchive/pull-request | 2017-12-04T15:47:24 | 2025-04-01T06:46:36.936727 | {
"authors": [
"BloodyEM",
"anzx42"
],
"repo": "wundrweapon/SCMC-Website",
"url": "https://github.com/wundrweapon/SCMC-Website/pull/2",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
} |
599677807 | aligned progress bar and create directory if not exists
clean up
| gharchive/pull-request | 2020-04-14T15:52:45 | 2025-04-01T06:46:36.969948 | {
"authors": [
"unique1o1"
],
"repo": "yankeexe/git.ir_downloader",
"url": "https://github.com/yankeexe/git.ir_downloader/pull/2",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
246853400 | Add methods to make images using a DynamicGradient
Hi Guillaume,
I'm not a big fan of the gradient image API because it introduces inconsistent APIs between iOS, tvOS, watchOS and macOS platforms. Moreover, your tests fail on travis.
DynamicColor is about the color manipulation, not visualisation. Either we create a sub-project with a DynamicGradientView that match the NSGradient macOS counterpart, or we create a new project.
However the isOpaque property is a great idea. You can pull those updates to start. I would just update the gradient one with something like that:
var isOpaque: Bool {
return colors.reduce(true) { $0.0 && $0.1.isOpaque }
}
Hi Yannick,
Tests work on Xcode, it's weird that they fail on travis ... One problem I had on Xcode is that ".png" were compress during compilation, to avoid that I changed their extension using ".ref", but I don't know if it works on travis.
I understand your point on APIs inconsistent between iOs and the other platforms, but I don't well know macOs counterpart, so I think I will not find the time to make it, sorry.
At the beginning of my pool request, I have a need: make a color using UIColor.init(patternImage: UIImage) to be able to put gardient in some backgrounds of my UIViews. Do we consider that colors with pattern are not real colors and haven't got their place in DynamicColor ?
I will make another request for isOpaque property.
Thanks for your time.
Codecov Report
Merging #38 into master will decrease coverage by 4.82%.
The diff coverage is 77.57%.
@@ Coverage Diff @@
## master #38 +/- ##
==========================================
- Coverage 100% 95.17% -4.83%
==========================================
Files 13 14 +1
Lines 390 497 +107
==========================================
+ Hits 390 473 +83
- Misses 0 24 +24
Flag
Coverage Δ
#ios
95.17% <77.57%> (-4.83%)
:arrow_down:
#osx
75.65% <0%> (-20.76%)
:arrow_down:
Impacted Files
Coverage Δ
Sources/DynamicColor.swift
100% <100%> (ø)
:arrow_up:
Sources/CGFloat.swift
62.5% <62.5%> (ø)
Sources/DynamicGradient.swift
84.09% <78.35%> (-15.91%)
:arrow_down:
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baac8bd...db4006c. Read the comment docs.
Travis uses Xcode to execute the test suite, so it should work in the same way. I should investigate that when I'll have time.
I think I'll create a sub-project with a DynamicGradientView with the same API as NSGradient and we will use your code.
| gharchive/pull-request | 2017-07-31T19:07:37 | 2025-04-01T06:46:36.983538 | {
"authors": [
"codecov-io",
"gbitaudeau",
"yannickl"
],
"repo": "yannickl/DynamicColor",
"url": "https://github.com/yannickl/DynamicColor/pull/38",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
} |
284519056 | Updated a page for @skapral
@skapral thanks!
| gharchive/pull-request | 2017-12-26T08:47:50 | 2025-04-01T06:46:36.991738 | {
"authors": [
"skapral",
"yegor256"
],
"repo": "yegor256/elegantobjects.github.io",
"url": "https://github.com/yegor256/elegantobjects.github.io/pull/13",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
941320874 | Teknoloji Rehberleri için nasıl gönderi yazılabileceğini anlatan bir gönderi.
Merhaba, elinize sağlık güzel bir rehber olmuş. Sadece etiket eklemeyi unutmuşsunuz. :) Onu ben ekleyeceğim artık. Onun dışında bir de rehber başlığı # ile başlamıyor nedeniyse kullandığımız blogit uygulaması compile ederken ilk satırı başlık olarak alıyor. Hashtag olduğunda o hashtagi de başlıkta gösteriyor.
@Mehmetali345Dev kod bloklarına burada md, html gibi başlayamıyorsun. Kullanılan markdownın değişikliğnden dolayı böyle. Ayrıca dosya düzeninde her yere h1 ile başlamamak lazım. Okunaklığını azaltıyor. Ben gerekli düzeltmeleri yaptım ve sitede paylaştım lütfen incele. Bir sonraki yazında çok daha güzel yapacağına eminim. Eline sağlık tekrardan.
| gharchive/pull-request | 2021-07-10T20:43:09 | 2025-04-01T06:46:36.999527 | {
"authors": [
"Mehmetali345Dev",
"yusufipk"
],
"repo": "yusufipk/teknolojirehberleri.xyz",
"url": "https://github.com/yusufipk/teknolojirehberleri.xyz/pull/2",
"license": "CC0-1.0",
"license_type": "permissive",
"license_source": "github-api"
} |
347757266 | Add attributes to radio
Thanks!
| gharchive/pull-request | 2018-08-06T02:22:11 | 2025-04-01T06:46:37.005978 | {
"authors": [
"leo108",
"z-song"
],
"repo": "z-song/laravel-admin",
"url": "https://github.com/z-song/laravel-admin/pull/2279",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
} |
637636557 | support more configurations
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.minglei.wen seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.
Codecov Report
Merging #97 into master will decrease coverage by 1.26%.
The diff coverage is 0.00%.
@@ Coverage Diff @@
## master #97 +/- ##
============================================
- Coverage 32.65% 31.39% -1.27%
Complexity 47 47
============================================
Files 26 26
Lines 297 309 +12
Branches 16 19 +3
============================================
Hits 97 97
- Misses 192 204 +12
Partials 8 8
Impacted Files
Coverage Δ
Complexity Δ
...ebe/spring/client/bean/value/ZeebeWorkerValue.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)
...lient/bean/value/factory/ReadZeebeWorkerValue.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)
...ent/config/processor/ZeebeWorkerPostProcessor.java
0.00% <0.00%> (ø)
0.00 <0.00> (ø)
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72bbf46...ed99247. Read the comment docs.
I was searching this repo in order to do the same change which I would like to have and found this PR, thank you for it. This PR is opened for a long time though. Is there any chance of resolving and getting it in some future version?
replaced by this: https://github.com/zeebe-io/spring-zeebe/pull/111
replaced by this: https://github.com/zeebe-io/spring-zeebe/pull/111
| gharchive/pull-request | 2020-06-12T10:00:25 | 2025-04-01T06:46:37.034797 | {
"authors": [
"CLAassistant",
"DominikMostek",
"codecov-commenter",
"salaboy",
"wenminglei"
],
"repo": "zeebe-io/spring-zeebe",
"url": "https://github.com/zeebe-io/spring-zeebe/pull/97",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
364463148 | I can model a parallel gateway
Done with release 0.2.0
| gharchive/issue | 2018-09-27T12:56:11 | 2025-04-01T06:46:37.035808 | {
"authors": [
"ThorbenLindhauer",
"dominikhrn"
],
"repo": "zeebe-io/zeebe-modeler",
"url": "https://github.com/zeebe-io/zeebe-modeler/issues/18",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
56523069 | Add option to customise tabline
Thank you @joelmo for the request. However, I cannot merge your PR because of one reasons: wintabs tries very hard to keep lone lines correctly truncated and positioned, customization is only possible if the user uses fixed-length custom strings and knows the exact extra length (will need an extra option for the length). My previous plugin buftabs allows that but that makes it very hard to use, for now I don't want to repeat this in wintabs.
Has this to do with session options or why is this needed? I would really want to add the value returned from getcwd(), but I could truncate it with fnamemodify.
To keep the tabs string correctly truncated, wintabs must know exactly how many characters it will occupy, and that is the window width currently. If it instead relies on vim's native truncation, the current buffer and the highlight of it might be truncated out or incorrectly, so it must use its own truncation method. If you customize it, you have to subtract the extra number of chars you put in, but usually that is dynamic and can't be known in advance. You can check out my buftabs repo to see how that is done, it's not really hard for the plugin writer (only about 10 extra lines), but very confusing for users.
I initially wanted getcwd there too, but eventually I gave up and moved getcwd to statusline. Though more awkward than using tabline, the following code is what I use for my statusline (it chooses between git path and cwd to display, you can ignore the git part):
autocmd BufWinEnter,WinEnter,VimEnter * let w:getcwd = getcwd()
let &statusline = " %{StatuslineTag()} "
let &statusline .= "your other stuff"
function! StatuslineTag()
if exists('b:git_dir')
let dir = fnamemodify(b:git_dir[:-6], ':t')
return dir." \ue0a0 ".fugitive#head(7)
else
return fnamemodify(getwinvar(0, 'getcwd', getcwd()), ':t')
endif
endfunction
Thanks I didn't think about the truncation, I will just use your satusline instead :sun_with_face:
| gharchive/pull-request | 2015-02-04T12:57:23 | 2025-04-01T06:46:37.043038 | {
"authors": [
"joelmo",
"zefei"
],
"repo": "zefei/vim-wintabs",
"url": "https://github.com/zefei/vim-wintabs/pull/4",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
} |
73743585 | Feature/zend.stdlib.hydrator.namingstrategy.identitynamingstrategy
Related to #1396
I moved it back into the stdlib chapter
| gharchive/pull-request | 2015-05-06T21:32:28 | 2025-04-01T06:46:37.046167 | {
"authors": [
"nathanjosiah"
],
"repo": "zendframework/zf2-documentation",
"url": "https://github.com/zendframework/zf2-documentation/pull/1480",
"license": "BSD-3-Clause",
"license_type": "permissive",
"license_source": "github-api"
} |
385140388 | Add support for clock control and spi controller driver for qemu-cortex-m3 board
Codecov Report
Merging #11697 into master will not change coverage.
The diff coverage is n/a.
@@ Coverage Diff @@
## master #11697 +/- ##
=======================================
Coverage 48.23% 48.23%
=======================================
Files 279 279
Lines 43291 43291
Branches 10359 10359
=======================================
Hits 20881 20881
Misses 18270 18270
Partials 4140 4140
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97b7a0a...5494572. Read the comment docs.
What is the motivation for adding this and other I/Os to a qemu target? Can you provide some background?
Qemu supports spi based display ssd0323, the spi and gpio driver is required for adding support to for display.
needs a rebase and checkpatch fixes; @ashokkumar11 do you plan on fixing this up?
no response for three months.
| gharchive/pull-request | 2018-11-28T07:44:28 | 2025-04-01T06:46:37.052457 | {
"authors": [
"ashokkumar11",
"codecov-io",
"mbolivar",
"nashif"
],
"repo": "zephyrproject-rtos/zephyr",
"url": "https://github.com/zephyrproject-rtos/zephyr/pull/11697",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
560935761 | 请问为什么header.md 上传了，但是就显示了一次，就不再显示了
还有就是header.md能不能设置显示在底部呢
@smloli 因为底部是滚动加载的，所以不能放在底部。
@smloli 因为底部是滚动加载的，所以不能放在底部。
谢谢，还有那个头部md为什么就偶尔显示啊，另外那个配置文件中cache:300代表多长时间啊，我想改成3小时刷新一次
@smloli
头部 MD，可能与文件缓存有关，开启缓存后，你上传，程序是无法感知上传的。请在未开启缓存的状态下是否出现偶尔显示的状况。
动态切换缓存刷新时间，这个功能待定。因为涉及的东西比较多，但也应该会支持的。
头部 MD问题，已经修复。动态缓存后续会支持，此问题先关闭了。
| gharchive/issue | 2020-02-06T10:59:06 | 2025-04-01T06:46:37.057290 | {
"authors": [
"smloli",
"zhaojun1998"
],
"repo": "zhaojun1998/zfile",
"url": "https://github.com/zhaojun1998/zfile/issues/18",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
583110047 | 你好，请问有没有什么办法可以修改code block的背景色呢？那个大黑框看着有点不舒服
可以的，加一下自定义的 css 覆盖就好，但是建议不要
.article-entry .highlight {
background: #555;
}
可以的，加一下自定义的 css 覆盖就好，
但是建议不要改的太浅色了，因为 hightlight 的语法颜色是一整套配色
.article-entry .highlight {
background: #555;
}
谢谢，能再问一下，要覆盖到哪个文件呢？
可以的，加一下自定义的 css 覆盖就好，
但是建议不要改的太浅色了，因为 hightlight 的语法颜色是一整套配色
.article-entry .highlight {
background: #555;
}
谢谢，能再问一下，要覆盖到哪个文件呢？
明白了，直接添加themes/Wikitten/source/css/style.styl就好了，感谢大佬！！
hightlight
如果给代码块换一套属性配色，您那边有什么建议嘛？如何添加啊
hightlight
如果给代码块换一套属性配色，您那边有什么建议嘛？如何添加啊
highlightjs 上找现成的配色
https://highlightjs.org/static/demo/
hightlight
如果给代码块换一套属性配色，您那边有什么建议嘛？如何添加啊
highlightjs 上找现成的配色
https://highlightjs.org/static/demo/
多谢
| gharchive/issue | 2020-03-17T15:45:43 | 2025-04-01T06:46:37.066098 | {
"authors": [
"hinzer",
"zthxxx"
],
"repo": "zthxxx/hexo-theme-Wikitten",
"url": "https://github.com/zthxxx/hexo-theme-Wikitten/issues/62",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
} |
53549617 | Detect and report reasons for tasks failing to start beyond 'not root'
command file referenced doesn't exist
inadequate permissions
This is really a proxy for what would be returned by the error stream anyways.
| gharchive/issue | 2015-01-06T19:00:53 | 2025-04-01T06:46:37.067284 | {
"authors": [
"CBrophy"
],
"repo": "zulily/omicron",
"url": "https://github.com/zulily/omicron/issues/18",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
} |
249443301 | [WIP] Add tools/provision, virtual-env and corresponding docs
Merged, with a few tweaks:
Fixed the path to the venv in the README.
Added proper shell quoting to most variables.
Made provision print out the command for activating the virtualenv.
Fixed some tab-based whitespace; @derAnfaenger does our linter not check for that, or is this PR just too old?
A follow-up task we should open issues for and/or just fix:
We should properly support Python 3 here; right now this kinda hardcodes Python 2 in the filenames, even if you're using Python 3.
@timabbott it's seven days, so probably too old. I just added some tabs to a file, and the linter went off.
#78 for the followup.
| gharchive/pull-request | 2017-08-10T18:56:30 | 2025-04-01T06:46:37.070119 | {
"authors": [
"aero31aero",
"derAnfaenger",
"timabbott"
],
"repo": "zulip/python-zulip-api",
"url": "https://github.com/zulip/python-zulip-api/pull/56",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
436313073 | Create 0000-01-02-zvonkovugreshek.md
created a branch, created a file and made a commit, and opened a pull request
| gharchive/pull-request | 2019-04-23T17:49:32 | 2025-04-01T06:46:37.071760 | {
"authors": [
"zvonkovugreshek"
],
"repo": "zvonkovugreshek/github-slideshow",
"url": "https://github.com/zvonkovugreshek/github-slideshow/pull/3",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
477550218 | New PR to test SignCLA at 2019-08-06 12:16:48.461602433 -0700 PDT m=+3.845121084
Body of PR
corp-pass-fork-staging: test succeeded
| gharchive/pull-request | 2019-08-06T19:16:48 | 2025-04-01T06:46:37.078130 | {
"authors": [
"signcla-test-signed-corp"
],
"repo": "google-test/signcla-probe-repo-dev",
"url": "https://github.com/google-test/signcla-probe-repo-dev/pull/344",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
2536859188 | [CHORE] adding semver dep
Need dep for semver
This was for testing, seems this incorrectly was sent to Upstream
| gharchive/pull-request | 2024-09-19T16:39:02 | 2025-04-01T04:32:11.893711 | {
"authors": [
"chris-at-snyk"
],
"repo": "00001k/purpledobie-robot-shop.",
"url": "https://github.com/00001k/purpledobie-robot-shop./pull/13",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
2168792594 | 🛑 Ombi is down
In 9a22034, Ombi (https://ombi.0121.org) was down:
HTTP code: 0
Response time: 0 ms
Resolved: Ombi is back up in 189f429 after 12 minutes.
| gharchive/issue | 2024-03-05T10:04:18 | 2025-04-01T04:32:11.897054 | {
"authors": [
"012101do1"
],
"repo": "012101do1/upptime",
"url": "https://github.com/012101do1/upptime/issues/389",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
2479670905 | 🛑 Ombi is down
In 89e6bea, Ombi (https://ombi.0121.org) was down:
HTTP code: 0
Response time: 0 ms
Resolved: Ombi is back up in 4dd8a86 after 30 minutes.
| gharchive/issue | 2024-08-22T03:11:08 | 2025-04-01T04:32:11.899919 | {
"authors": [
"012101do1"
],
"repo": "012101do1/upptime",
"url": "https://github.com/012101do1/upptime/issues/647",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
153351271 | scheduler test coverage
I have the worst test coverage on the project and need to redeem myself. The ancient test bits I'd written in fake_agent.go and fake_controller.go need morphed into a go test cases which exercise the successful and failed flow of workloads through the scheduling algorithm.
I've just merged some test code (and fixes) bringing scheduler up from 0% to 50%+. More to come, so leaving the issue open, but at least there's some progress.
| gharchive/issue | 2016-05-05T23:52:19 | 2025-04-01T04:32:11.901421 | {
"authors": [
"tpepper"
],
"repo": "01org/ciao",
"url": "https://github.com/01org/ciao/issues/103",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
113533543 | Partial file caching
An add event has field success. Is it set to false when file loading is not complete? and Why in javascript service code this field not processed and file url added to cache list without checking of a success status ?
In java android code:
Class cachehandler hasnt file removing on exception in method get. After application restart this partial loaded files files can be enumerted as success loaded files
An add event has field success. Is it set to false when file loading is not complete?
Yes.
Why in javascript service code this field not processed and file url added to cache list without checking of a success status ?
I'm guessing you are referring to this code? This is listening for a different event: intel.xdk.cache.internal.media.add. This event is only fired when the file has been successfully cached.
Class cachehandler hasnt file removing on exception in method get. After application restart this partial loaded files files can be enumerted as success loaded files
Have you observed this happening? The only time a file should get written is when the HTTP GET status was 200. It looks like it might be possible to have a partial file if the process crashes while writing. In order to fix that, we would need to add some file size validation to the cache initialization logic.
i missed an internal event calling, sorry for disturbance
And i have observed a partial image and tried to dig a code how it happend
Check size of a http response and saved file size its good idea! (I see its not implemented yet)
If you can provide some example code that results in a partial image, we could fix the issue. Currently I don't know why this would happen.
Yes, the file validation would be a new feature. I'm not working on it at this time.
I cant repeat this situation
But in my mind it can be in two cases
A Name of file generated is in a thread and simultaneously of numerous threads file names can be same (solution is take name generation out of thread?)
2.network with lagged connection can recieve not correct EOF without exception (solution is check file and network header file sizes?)
Im not prof in practical java android plugins coding but can suggest it by logical exploration of code.
All of this supposes can be clear foolish :)
Sorry
instead taking a name generation out a thread maybe use mutex enclosing or sinchronized prefix?
Original issue was resolved, no further action at this time.
| gharchive/issue | 2015-10-27T08:53:15 | 2025-04-01T04:32:11.908482 | {
"authors": [
"akaJes",
"tony--"
],
"repo": "01org/cordova-plugin-intel-xdk-cache",
"url": "https://github.com/01org/cordova-plugin-intel-xdk-cache/issues/1",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
} |
105101412 | Complete build options for Pthread API
Would you like to add the configuration script "AX_PTHREAD" to your build specification?
not familiar with this configuration, but we will check this later. thanks for suggestion.
| gharchive/issue | 2015-09-06T16:02:02 | 2025-04-01T04:32:11.916588 | {
"authors": [
"elfring",
"xuguangxin"
],
"repo": "01org/libyami",
"url": "https://github.com/01org/libyami/issues/303",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
} |
183317396 | Decode vp8 stream from libvpx results in video with macroblocks
the vp8 decoder, when decoding attached vp8 stream(unzip to output.ivf), will show many macroblocks and unexpected color blocks. This does not happen if we decode using libvpx.
output.zip
Seems it's a vp8 conformance issue after 169 frames
I'll take a look and report back. I have to confirm a fix is in place.
I try to use "yamidecode -i output.ivf -f I420 -m 0" to dump yuv file, but it returns an error. @xuguangxin @chivakker How can I verify this issue ?
root@yami-kbl:~# yamidecode -i output.ivf -f I420 -m 0
libva info: VA-API version 0.39.4
libva info: va_getDriverName() returns 0
libva info: Trying to open /opt/yami//vaapi/lib/dri/i965_drv_video.so
libva info: Found init function __vaDriverInit_0_39
libva info: va_openDriver() returns 0
fail to read frame data, quit
got fatal error -1021
VppInputDecode config failed.
DecodeTest init failed.
root@yami-kbl:~#
Env:
libyami: 1.0.1 RC1 tag
libyami-utils: 1.0.1 RC1 tag
libva: 1.7.3.pre1
libva-intel-driver: 1.7.3.pre1
Hi Fei:
The file dumped by @taste1981 have some issue.I fixed it, and i can mail to you. Please add this file to regression test set.
thanks
test OK:
libyami: 1.0.1 RC1 tag
libyami-utils: 1.0.1 RC1 tag
libva: 1.7.3.pre1
libva-intel-driver: 1.7.3.pre1
| gharchive/issue | 2016-10-17T03:24:35 | 2025-04-01T04:32:11.922478 | {
"authors": [
"chivakker",
"taste1981",
"wang-fei",
"xuguangxin"
],
"repo": "01org/libyami",
"url": "https://github.com/01org/libyami/issues/620",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
} |
247784239 | fix check-valgrind target for integration tests
The integration test harness currently fails for this target. Not sure why.
resolved in #148
| gharchive/issue | 2017-08-03T17:46:56 | 2025-04-01T04:32:11.923587 | {
"authors": [
"flihp"
],
"repo": "01org/tpm2-abrmd",
"url": "https://github.com/01org/tpm2-abrmd/issues/123",
"license": "BSD-2-Clause",
"license_type": "permissive",
"license_source": "github-api"
} |
1847722030 | 🛑 QR Event is down
In 8c60bc8, QR Event (https://qr.unej.ac.id) was down:
HTTP code: 0
Response time: 0 ms
Resolved: QR Event is back up in 96eddb0.
| gharchive/issue | 2023-08-12T03:59:20 | 2025-04-01T04:32:11.943878 | {
"authors": [
"0rangebananaspy"
],
"repo": "0rangebananaspy/io",
"url": "https://github.com/0rangebananaspy/io/issues/330",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
1866264663 | 🛑 SIREMUN is down
In f9bf4f7, SIREMUN (https://siremun.unej.ac.id) was down:
HTTP code: 502
Response time: 1272 ms
Resolved: SIREMUN is back up in 7057c7f after 34 days, 17 hours, 45 minutes.
| gharchive/issue | 2023-08-25T04:35:20 | 2025-04-01T04:32:11.946538 | {
"authors": [
"0rangebananaspy"
],
"repo": "0rangebananaspy/io",
"url": "https://github.com/0rangebananaspy/io/issues/653",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
1879018372 | 🛑 Lavoro is down
In 83ff1a0, Lavoro (https://lavoro.unej.ac.id) was down:
HTTP code: 502
Response time: 1296 ms
Resolved: Lavoro is back up in 15a666f after 12 minutes.
| gharchive/issue | 2023-09-03T09:39:54 | 2025-04-01T04:32:11.949154 | {
"authors": [
"0rangebananaspy"
],
"repo": "0rangebananaspy/io",
"url": "https://github.com/0rangebananaspy/io/issues/792",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
1611420066 | Design the pseudo-random field elements generator using RPO
During recursive verification, we need to use RPO as a random oracle in order to render the interactive protocol non-interactive. In Winterfell, this is achieved using the Random_Coin<BaseField, RPO> struct in order to get a random oracle, call it public_coin. The Random_Coin struct has two fields; Seed and Counter:
Seed is used for reseeding via public_coin.reseed(digest) (or public_coin.reseed_with_int(integer)) which basically sets public_coin's seed to a new value computed as RPO::merge(public_coin.seed, digest) (or RPO::merge_with_int(public_coin.seed, integer)). After reseeding, the internal counter is set to zero.
Counter is incremented when public_coin.next() is used to draw the next random word as RPO::merge_with_int(public_coin.seed, public_coin.counter).
This issue aims at investigating the changes, if any, needed in Winterfell in order to render the Random_Coin struct friendlier for recursive verification. More precisely, the following questions need to be investigated:
The public inputs are used to initialize the seed for public_coin. This is done by writing the public inputs into a Vec<u8> and then hashing the latter in order to get an initial seed. Do the padding rules for RPO allow us to avoid passing by Vec<u8> and hash instead field elements directly? It seems to be the case but we should double check.
Is the current implementation of reseed_with_int optimal with regards to RPO?
For drawing many field elements it seems rather wasteful, in the context of RPO, to have to run one permutation per 1 random field element drawn. Should we change this?
Yes, I think all 3 of these could be improved in Winterfell and it would make the assembly code both more performant and simpler.
In Triton, we have one global (resetable) Sponge state. When recursively verifying, we use it for the Fiat-Shamir transform[^1]. Seeding is implicitly done through absorption. Multiple pseudo-random field elements can easily be generated by squeezing multiple times, without the need to keep track of any counters.
[^1]: among other things; After all challenges have been generated, we also use it for hashing of inputs with variable length.
Yes, I believe this is the way it is (was?) done in Halo2 and Kimchi as well.
The reason for the current way of doing things is related to the fact that Winterfell doesn't assume that the hash function is a sponge. I am also not sure how many changes are needed to support this in Winterfell.
Apologies for rambling about an approach you are familiar with; I don't know the constraints imposed by Winterfell and that those might disqualify said approach. :relieved:
I actually think it might be a good idea to refactor RandomCoin struct in Winterfell to be a trait which could be provided for specific instances of prover/verifier. This would help with this issue but also probably with #753.
Yes, makes sense! This way we can make use of the sponge structure of RPO as @jan-ferdinand suggested above.
Created an issue here https://github.com/facebook/winterfell/issues/162
Closed by #891
| gharchive/issue | 2023-03-06T13:22:46 | 2025-04-01T04:32:12.017087 | {
"authors": [
"Al-Kindi-0",
"bobbinth",
"jan-ferdinand"
],
"repo": "0xPolygonMiden/miden-vm",
"url": "https://github.com/0xPolygonMiden/miden-vm/issues/751",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.