Split (1)

train · ~30.4M rows (showing the first 2.47M)

id stringlengths 4 10	text stringlengths 4 2.14M	source stringclasses 2 values	created timestamp[s]date 2001-05-16 21:05:09 2025-01-01 03:38:30	added stringdate 2025-04-01 04:05:38 2025-04-01 07:14:06	metadata dict
2067829943	[NO QA] Remove areChatRoomsEnabled checks Details Fixed Issues https://github.com/Expensify/App/issues/33806#top PROPOSAL: Tests Play around with the site Offline tests No QA Steps Same PR Author Checklist [x] I linked the correct issue in the ### Fixed Issues section above [x] I wrote clear testing steps that cover the changes made in this PR [x] I added steps for local testing in the Tests section [x] I added steps for the expected offline behavior in the Offline steps section [x] I added steps for Staging and/or Production testing in the QA steps section [x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct) [x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline) [x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability). [x] I included screenshots or videos for tests on all platforms [x] I ran the tests on all platforms & verified they passed on: [x] Android: Native [x] Android: mWeb Chrome [x] iOS: Native [x] iOS: mWeb Safari [x] MacOS: Chrome / Safari [x] MacOS: Desktop [x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed) [x] I followed proper code patterns (see Reviewing the code) [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick) [x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />. [x] I verified that comments were added to code that is not self explanatory [x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing. [x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method [x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message: [x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods [x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy. [x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README. [x] I verified the JSDocs style guidelines (in STYLE.md) were followed [x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers [x] I followed the guidelines as stated in the Review Guidelines [x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected) [x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests) [x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such [x] I verified that if a function's arguments changed that all usages have also been updated correctly [x] If any new file was added I verified that: [x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory [x] If a new CSS style is added I verified that: [x] A similar style doesn't already exist [x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)) [x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic. [x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases) [x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected. [x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account. [x] If the PR modifies the form input styles: [x] I verified that all the inputs inside a form are aligned with each other. [x] I added Design label so the design team can review the changes. [x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page. [x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps. Screenshots/Videos Android: Native Android: mWeb Chrome iOS: Native iOS: mWeb Safari MacOS: Chrome / Safari MacOS: Desktop Merging without checklist :hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. 🚀 Deployed to staging by https://github.com/Julesssss in version: 1.4.24-0 🚀 platform result 🤖 android 🤖 success ✅ 🖥 desktop 🖥 success ✅ 🍎 iOS 🍎 success ✅ 🕸 web 🕸 success ✅ 🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.24-3 🚀 platform result 🤖 android 🤖 success ✅ 🖥 desktop 🖥 success ✅ 🍎 iOS 🍎 success ✅ 🕸 web 🕸 success ✅	gharchive/pull-request	2024-01-05T18:15:34	2025-04-01T04:32:32.011297	{ "authors": [ "Julesssss", "OSBotify", "iwiznia" ], "repo": "Expensify/App", "url": "https://github.com/Expensify/App/pull/34046", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
2222641415	fix: workspace currency can be changed without existing distance rates Details Removed check for customUnitID when updating workspace currency so it method doesn't return early if no distance rates exist Fixed Issues $ https://github.com/Expensify/App/issues/39435 PROPOSAL: Tests Same as QA steps [x] Verify that no errors appear in the JS console Offline tests QA Steps log into account where user is admin of workspace and doesn't have access to new distance rates feautre go to workspace profile try to change default currency [x] Verify that no errors appear in the JS console PR Author Checklist [x] I linked the correct issue in the ### Fixed Issues section above [x] I wrote clear testing steps that cover the changes made in this PR [x] I added steps for local testing in the Tests section [x] I added steps for the expected offline behavior in the Offline steps section [x] I added steps for Staging and/or Production testing in the QA steps section [x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct) [x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline) [x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability). [x] I included screenshots or videos for tests on all platforms [x] I ran the tests on all platforms & verified they passed on: [x] Android: Native [x] Android: mWeb Chrome [x] iOS: Native [x] iOS: mWeb Safari [x] MacOS: Chrome / Safari [x] MacOS: Desktop [x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed) [x] I followed proper code patterns (see Reviewing the code) [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick) [x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />. [x] I verified that comments were added to code that is not self explanatory [x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing. [x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method [x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message: [x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods [x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue) [x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README. [x] I verified the JSDocs style guidelines (in STYLE.md) were followed [x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers [x] I followed the guidelines as stated in the Review Guidelines [x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected) [x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests) [x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such [x] I verified that if a function's arguments changed that all usages have also been updated correctly [x] If any new file was added I verified that: [x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory [x] If a new CSS style is added I verified that: [x] A similar style doesn't already exist [x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)) [x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic. [x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases) [x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected. [x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account. [x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles: [x] I verified that all the inputs inside a form are aligned with each other. [x] I added Design label and/or tagged @Expensify/design so the design team can review the changes. [x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page. [x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps. Screenshots/Videos https://github.com/Expensify/App/assets/23487612/cd584b9d-37b6-408a-9480-6f9391e66ec1 Android: Native Android: mWeb Chrome iOS: Native iOS: mWeb Safari MacOS: Chrome / Safari MacOS: Desktop Reviewer Checklist [x] I have verified the author checklist is complete (all boxes are checked off). [x] I verified the correct issue is linked in the ### Fixed Issues section above [x] I verified testing steps are clear and they cover the changes made in this PR [x] I verified the steps for local testing are in the Tests section [x] I verified the steps for Staging and/or Production testing are in the QA steps section [x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct) [x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline) [x] I checked that screenshots or videos are included for tests on all platforms [x] I included screenshots or videos for tests on all platforms [x] I verified tests pass on all platforms & I tested again on: [x] Android: Native [x] Android: mWeb Chrome [x] iOS: Native [x] iOS: mWeb Safari [x] MacOS: Chrome / Safari [x] MacOS: Desktop [x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack [x] I verified proper code patterns were followed (see Reviewing the code) [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick). [x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />. [x] I verified that comments were added to code that is not self explanatory [x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing. [x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method [x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods [x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy. [x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README. [x] I verified the JSDocs style guidelines (in STYLE.md) were followed [x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers [x] I verified that this PR follows the guidelines as stated in the Review Guidelines [x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again) [x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests) [x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such [x] If a new component is created I verified that: [x] A similar component doesn't exist in the codebase [x] All props are defined accurately and each prop has a /** comment above it */ [x] The file is named correctly [x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone [x] The only data being stored in the state is data necessary for rendering and nothing else [x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor) [x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick) [x] All JSX used for rendering exists in the render method [x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions [x] If any new file was added I verified that: [x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory [x] If a new CSS style is added I verified that: [x] A similar style doesn't already exist [x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG) [x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic. [x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases) [x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected. [x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account. [x] If the PR modifies the form input styles: [x] I verified that all the inputs inside a form are aligned with each other. [x] I added Design label so the design team can review the changes. [x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page. [x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps. [x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR. Screenshots/Videos Android: Native https://github.com/Expensify/App/assets/59907218/344e3e67-5858-4f52-8762-752ee0402bb9 Android: mWeb Chrome iOS: Native https://github.com/Expensify/App/assets/59907218/71e5f532-9736-4453-a8a2-a4d2027d9909 iOS: mWeb Safari https://github.com/Expensify/App/assets/59907218/ce115b64-51d6-4a10-a762-d1937645abe9 MacOS: Chrome / Safari https://github.com/Expensify/App/assets/59907218/25fd5072-b454-469d-a0b4-cef26f93e605 MacOS: Desktop https://github.com/Expensify/App/assets/59907218/2534c29e-2ea5-4db2-86cb-739ad274c109 🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.61-0 🚀 platform result 🤖 android 🤖 success ✅ 🖥 desktop 🖥 cancelled 🔪 🍎 iOS 🍎 success ✅ 🕸 web 🕸 success ✅ 🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.61-0 🚀 platform result 🤖 android 🤖 success ✅ 🖥 desktop 🖥 success ✅ 🍎 iOS 🍎 success ✅ 🕸 web 🕸 success ✅ 🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.61-8 🚀 platform result 🤖 android 🤖 success ✅ 🖥 desktop 🖥 success ✅ 🍎 iOS 🍎 success ✅ 🕸 web 🕸 success ✅	gharchive/pull-request	2024-04-03T11:14:27	2025-04-01T04:32:32.060222	{ "authors": [ "MrMuzyk", "OSBotify", "alitoshmatov" ], "repo": "Expensify/App", "url": "https://github.com/Expensify/App/pull/39484", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
2564857077	Use setClipboardMessage for html to markdown conversion Details Fixed Issues $ https://github.com/Expensify/App/issues/50090 $ Related to https://github.com/Expensify/App/issues/35091 Tests Set up auto-approvals & run tests from https://github.com/Expensify/App/pull/49909 Copy the report action text & paste in a new message Verify the new pasted text has markdown formatting instead of HTML [ ] Verify that no errors appear in the JS console Offline tests N/A because auto-actions only happen online QA Steps Same as above [ ] Verify that no errors appear in the JS console PR Author Checklist [x] I linked the correct issue in the ### Fixed Issues section above [x] I wrote clear testing steps that cover the changes made in this PR [x] I added steps for local testing in the Tests section [x] I added steps for the expected offline behavior in the Offline steps section [x] I added steps for Staging and/or Production testing in the QA steps section [x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct) [x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline) [x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability). [x] I included screenshots or videos for tests on all platforms [x] I ran the tests on all platforms & verified they passed on: [x] Android: Native [x] Android: mWeb Chrome [x] iOS: Native [x] iOS: mWeb Safari [x] MacOS: Chrome / Safari [x] MacOS: Desktop [x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed) [x] I followed proper code patterns (see Reviewing the code) [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick) [x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />. [x] I verified that comments were added to code that is not self explanatory [x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing. [x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method [x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message: [x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods [x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue) [x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README. [x] I verified the JSDocs style guidelines (in STYLE.md) were followed [x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers [x] I followed the guidelines as stated in the Review Guidelines [x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected) [x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests) [x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such [x] I verified that if a function's arguments changed that all usages have also been updated correctly [x] If any new file was added I verified that: [x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory [x] If a new CSS style is added I verified that: [x] A similar style doesn't already exist [x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)) [x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic. [x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases) [x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected. [x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account. [x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles: [x] I verified that all the inputs inside a form are aligned with each other. [x] I added Design label and/or tagged @Expensify/design so the design team can review the changes. [x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page. [x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps. Screenshots/Videos Android: Native Android: mWeb Chrome iOS: Native iOS: mWeb Safari MacOS: Chrome / Safari MacOS: Desktop Still looking into this, I may have more to update Ok @ishpaul777 i think this is ready for review today :hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.	gharchive/pull-request	2024-10-03T19:31:44	2025-04-01T04:32:32.083791	{ "authors": [ "Beamanator", "OSBotify" ], "repo": "Expensify/App", "url": "https://github.com/Expensify/App/pull/50181", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
2587702789	[Feature]: Add phone number to the private personal details section Details Discussed in this thread Users need a phone number to issue physical Expensify cards. We ask them for the phone number in the form to ship the Expensify card, but otherwise, this phone number is not editable from NewDot. This is a problem in case they want to edit it after adding it for the Expensify card. Fixed Issues $ https://github.com/Expensify/App/issues/50701 PROPOSAL: https://expensify.slack.com/archives/C02NK2DQWUX/p1728885017172809?thread_ts=1728884992.974789&cid=C02NK2DQWUX Tests Open App Go to settings > profile In private details, click on Phone Number Verify that: you are able to enter phone number and styling is correct, and verify that error is displayed on wrong entry [x] Verify that no errors appear in the JS console Offline tests Open App Go to settings > profile In private details, click on Phone Number Verify that: you are able to enter phone number and in offline mode the number is displayed QA Steps Open App Go to settings > profile In private details, click on Phone Number Verify that: you are able to enter phone number and styling is correct, and verify that error is displayed on wrong entry [x] Verify that no errors appear in the JS console PR Author Checklist [x] I linked the correct issue in the ### Fixed Issues section above [x] I wrote clear testing steps that cover the changes made in this PR [x] I added steps for local testing in the Tests section [x] I added steps for the expected offline behavior in the Offline steps section [x] I added steps for Staging and/or Production testing in the QA steps section [x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct) [x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline) [x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability). [x] I included screenshots or videos for tests on all platforms [x] I ran the tests on all platforms & verified they passed on: [x] Android: Native [x] Android: mWeb Chrome [x] iOS: Native [x] iOS: mWeb Safari [x] MacOS: Chrome / Safari [x] MacOS: Desktop [x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed) [x] I followed proper code patterns (see Reviewing the code) [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick) [x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />. [x] I verified that comments were added to code that is not self explanatory [x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing. [x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method [x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message: [x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods [x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue) [x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README. [x] I verified the JSDocs style guidelines (in STYLE.md) were followed [x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers [x] I followed the guidelines as stated in the Review Guidelines [x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected) [x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests) [x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such [x] I verified that if a function's arguments changed that all usages have also been updated correctly [x] If any new file was added I verified that: [x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory [x] If a new CSS style is added I verified that: [x] A similar style doesn't already exist [x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)) [x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic. [x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases) [x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected. [x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account. [x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles: [x] I verified that all the inputs inside a form are aligned with each other. [x] I added Design label and/or tagged @Expensify/design so the design team can review the changes. [x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page. [x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps. Screenshots/Videos Android: Native https://github.com/user-attachments/assets/0427052a-21a5-4499-bb5d-bd6bdbcddfe2 Android: mWeb Chrome iOS: Native https://github.com/user-attachments/assets/fd681814-e252-415d-a0c4-caa3731cc466 iOS: mWeb Safari https://github.com/user-attachments/assets/28ce9a03-4533-4ae4-a743-824710225742 MacOS: Chrome / Safari https://github.com/user-attachments/assets/4ba2dbe9-7ab7-49d6-93b6-bbfddea8e30e MacOS: Desktop https://github.com/user-attachments/assets/b48a9062-6277-4315-8ab8-8df9a6cd8a58 I think the label should simply say Phone number instead of What's your phone number: I also find the adding of the +1 after the fact a bit odd. Is this something we do in the rest of the app? cc @Expensify/design Yup, agree with Jon's comments. Regarding the country code... yeah, that's an interesting one. Do we need to do that automatically or can we just rely on the user to enter one if needed? The country code is added by the BE automatically even when the user submits only number, so if we want to change that, we need to update the BE I think the execution of this feels a bit inelegant, but I get why it's done this way. It kinda feels like there should be a country selector on that screen that'd defaulted to their location. But I also feel like all this is something worth solving later. Thoughts @Expensify/design ? Yeah I think we could improve this with some dedicated country code selector, but I would say that is something for later. @allgandalf @DylanDylann For FE validation, lets use the same as in the card shipping flow. For handling BE errors, show them using RBR dot on the row in the Private setting and then under the input with X to clear it Yeah I agree with Jon that it doesn't feel the nicest, but I also see the point that if it ain't broke... we can revisit that particular part of the flow later. I'm in line with the comments above. A dedicated country picker would be nice on that screen, but I also agree that we don't need to do it right this second. @allgandalf Let's add a padding-top on error message to ensure a space 8px as form error message Let's add RBR on Profile tab and avatar tab when there is a error @allgandalf 2 error messages are displayed at the same time https://github.com/user-attachments/assets/27faf248-2544-41a0-957a-ca194763a3f5 @allgandalf This is video to reproduce @allgandalf This make me confused Enter 0387987987 Submit a request The phone number is updated +84387987987 and an error message appears Remove the error message submit phone number again with no change, but we don't get error https://github.com/user-attachments/assets/cf3abe53-334b-4b57-8dc2-760ffccfc69f The phone number is not updated, we fallback to the previous phone number here, you can check in the video that you fallback to the previous phone number. Kakaaa, wrong video. Wait a sec @dubielzyk-expensify Could you help to check this comment and please give your though on it? we have 2 error message displays at the same time. For this, Let's use shouldHideFixErrorsAlert props. wdyt? @allgandalf Please prevent calling API if the old value === the new value @dubielzyk-expensify Could you help to check https://github.com/Expensify/App/pull/50773#issuecomment-2428503841 and please give your though on it? we have 2 error message displays at the same time. I don't think stacking the error message is terrible—I think the issue is that they're the same error message. I think in this specific case it would be fine for the form error to override the previous (dismissible) error message. cc @Expensify/design for thoughts. Let me know if that makes sense, I realize after re-reading it that maybe I did not explain that super well :) I see what you mean and agree Shawn. I wonder if we error could just disappear onChange i.e. as soon as the user changes anything in the number field Yeah, I think we should show 1 error and just hide it when the users tries to rectify the error. But keen to hear if that's aligned with what @shawnborton meant @shawnborton this is our expect, right? I see what you mean and agree Shawn. I wonder if we error could just disappear onChange i.e. as soon as the user changes anything in the number field I was thinking as soon as the user submits, not types. @shawnborton Wdym? as the user submits https://github.com/user-attachments/assets/27faf248-2544-41a0-957a-ca194763a3f5 @shawnborton You can point out the time on the above video Ah okay, so then maybe we would need to do it onBlur at this moment here: So not onChange, but onBlur. Could that work? Nice, that feels pretty good to me. Curious what others think too! @shawnborton @dubielzyk-expensify This is the current behavior in this flow https://github.com/user-attachments/assets/2a8edf0a-8ebf-40c3-a470-e30589dbea69 Reviewer Checklist [x] I have verified the author checklist is complete (all boxes are checked off). [x] I verified the correct issue is linked in the ### Fixed Issues section above [x] I verified testing steps are clear and they cover the changes made in this PR [x] I verified the steps for local testing are in the Tests section [x] I verified the steps for Staging and/or Production testing are in the QA steps section [x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct) [x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline) [x] I checked that screenshots or videos are included for tests on all platforms [x] I included screenshots or videos for tests on all platforms [x] I verified tests pass on all platforms & I tested again on: [x] Android: Native [x] Android: mWeb Chrome [x] iOS: Native [x] iOS: mWeb Safari [x] MacOS: Chrome / Safari [x] MacOS: Desktop [x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack [x] I verified proper code patterns were followed (see Reviewing the code) [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick). [x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />. [x] I verified that comments were added to code that is not self explanatory [x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing. [x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method [x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods [x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue) [x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README. [x] I verified the JSDocs style guidelines (in STYLE.md) were followed [x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers [x] I verified that this PR follows the guidelines as stated in the Review Guidelines [x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again) [x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests) [x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such [x] If a new component is created I verified that: [x] A similar component doesn't exist in the codebase [x] All props are defined accurately and each prop has a /** comment above it */ [x] The file is named correctly [x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone [x] The only data being stored in the state is data necessary for rendering and nothing else [x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor) [x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick) [x] All JSX used for rendering exists in the render method [x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions [x] If any new file was added I verified that: [x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory [x] If a new CSS style is added I verified that: [x] A similar style doesn't already exist [x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG) [x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic. [x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases) [x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected. [x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account. [x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles: [x] I verified that all the inputs inside a form are aligned with each other. [x] I added Design label and/or tagged @Expensify/design so the design team can review the changes. [x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page. [x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps. [x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR. Screenshots/Videos Android: Native Android: mWeb Chrome iOS: Native iOS: mWeb Safari MacOS: Chrome / Safari MacOS: Desktop The behavior in this video looks good to me. The last video posted doesn't seem to save the number which is a bit odd. Which video particularly Jon? It looks like the two videos posted here are working as expected at least. OH I see what Jon is saying. In the failure video here, we're not saving the "bad" phone number the user entered. Is that expected? Ah, is that because it was considered a "bad" number from the backend? I have no idea how that works TBH. Yeah, I guess I was expecting it to save and show even though it throws an error. Happy to move forward as you've got control 👍 @allgandalf BUG: 2 error messages are display at the same time https://github.com/user-attachments/assets/c7af9f9b-f6dd-4545-b973-cfe5d641a498 :hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.	gharchive/pull-request	2024-10-15T05:45:02	2025-04-01T04:32:32.147750	{ "authors": [ "DylanDylann", "OSBotify", "allgandalf", "dannymcclain", "dubielzyk-expensify", "mountiny", "shawnborton" ], "repo": "Expensify/App", "url": "https://github.com/Expensify/App/pull/50773", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
2611280043	[Snyk] Security upgrade electron from 29.4.6 to 31.7.2 Details Fixed Issues $ PROPOSAL: Tests [x] Verify that no errors appear in the JS console Offline tests QA Steps [x] Verify that no errors appear in the JS console PR Author Checklist [x] I linked the correct issue in the ### Fixed Issues section above [x] I wrote clear testing steps that cover the changes made in this PR [x] I added steps for local testing in the Tests section [x] I added steps for the expected offline behavior in the Offline steps section [x] I added steps for Staging and/or Production testing in the QA steps section [x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct) [x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline) [x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability). [x] I included screenshots or videos for tests on all platforms [x] I ran the tests on all platforms & verified they passed on: [x] Android: Native [x] Android: mWeb Chrome [x] iOS: Native [x] iOS: mWeb Safari [x] MacOS: Chrome / Safari [x] MacOS: Desktop [x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed) [x] I followed proper code patterns (see Reviewing the code) [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick) [x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />. [x] I verified that comments were added to code that is not self explanatory [x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing. [x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method [x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message: [x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods [x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue) [x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README. [x] I verified the JSDocs style guidelines (in STYLE.md) were followed [x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers [x] I followed the guidelines as stated in the Review Guidelines [x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected) [x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests) [x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such [x] I verified that if a function's arguments changed that all usages have also been updated correctly [x] If any new file was added I verified that: [x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory [x] If a new CSS style is added I verified that: [x] A similar style doesn't already exist [x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)) [x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic. [x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases) [x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected. [x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account. [x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles: [x] I verified that all the inputs inside a form are aligned with each other. [x] I added Design label and/or tagged @Expensify/design so the design team can review the changes. [x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page. [x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps. Screenshots/Videos Android: Native Android: mWeb Chrome iOS: Native iOS: mWeb Safari MacOS: Chrome / Safari MacOS: Desktop Will take a look at it as soon as I finish my current task It seems we are already moving forward to a newer version of the library. Closing this one.	gharchive/pull-request	2024-10-24T11:28:27	2025-04-01T04:32:32.171025	{ "authors": [ "MarioExpensify", "MelvinBot" ], "repo": "Expensify/App", "url": "https://github.com/Expensify/App/pull/51399", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
2638551263	[NoQA] e2e: close ANR popup in case if exception happened Explanation of Change Sometimes we may receive ANR popup: It causes us next: Ignoring showSoftInput() as view=com.facebook.react.views.textinput.ReactEditText{e054e1c VFED..CL. .F....ID 140,49-996,119 #658} is not served. This PR fixes that by closing ANR popup before running the next test. Fixed Issues $ N/A PROPOSAL: N/A Tests run e2e pipeline and make sure it doesn't have skipped tests; Offline tests N/A QA Steps N/A PR Author Checklist [x] I linked the correct issue in the ### Fixed Issues section above [x] I wrote clear testing steps that cover the changes made in this PR [x] I added steps for local testing in the Tests section [x] I added steps for the expected offline behavior in the Offline steps section [x] I added steps for Staging and/or Production testing in the QA steps section [x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct) [x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline) [x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability). [x] I included screenshots or videos for tests on all platforms [x] I ran the tests on all platforms & verified they passed on: [x] Android: Native [x] Android: mWeb Chrome [x] iOS: Native [x] iOS: mWeb Safari [x] MacOS: Chrome / Safari [x] MacOS: Desktop [x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed) [x] I followed proper code patterns (see Reviewing the code) [x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick) [x] I verified that comments were added to code that is not self explanatory [x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing. [x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method [x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message: [x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods [x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue) [x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README. [x] I verified the JSDocs style guidelines (in STYLE.md) were followed [x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers [x] I followed the guidelines as stated in the Review Guidelines [x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected) [x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests) [x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such [x] I verified that if a function's arguments changed that all usages have also been updated correctly [x] If any new file was added I verified that: [x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory [x] If a new CSS style is added I verified that: [x] A similar style doesn't already exist [x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)) [x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic. [x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases) [x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected. [x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account. [x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles: [x] I verified that all the inputs inside a form are aligned with each other. [x] I added Design label and/or tagged @Expensify/design so the design team can review the changes. [x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page. [x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps. Screenshots/Videos Android: Native Android: mWeb Chrome iOS: Native iOS: mWeb Safari MacOS: Chrome / Safari MacOS: Desktop @hannojg may I ask you to review this PR? Just want to be sure you are aware about these changes 😊 @mountiny can we merge this PR? Reviewer Checklist [ ] I have verified the author checklist is complete (all boxes are checked off). [ ] I verified the correct issue is linked in the ### Fixed Issues section above [ ] I verified testing steps are clear and they cover the changes made in this PR [ ] I verified the steps for local testing are in the Tests section [ ] I verified the steps for Staging and/or Production testing are in the QA steps section [ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct) [ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline) [ ] I checked that screenshots or videos are included for tests on all platforms [ ] I included screenshots or videos for tests on all platforms [ ] I verified tests pass on all platforms & I tested again on: [ ] Android: Native [ ] Android: mWeb Chrome [ ] iOS: Native [ ] iOS: mWeb Safari [ ] MacOS: Chrome / Safari [ ] MacOS: Desktop [ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack [ ] I verified proper code patterns were followed (see Reviewing the code) [ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick). [ ] I verified that comments were added to code that is not self explanatory [ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing. [ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method [ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods [ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue) [ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README. [ ] I verified the JSDocs style guidelines (in STYLE.md) were followed [ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers [ ] I verified that this PR follows the guidelines as stated in the Review Guidelines [ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again) [ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests) [ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such [ ] If a new component is created I verified that: [ ] A similar component doesn't exist in the codebase [ ] All props are defined accurately and each prop has a /** comment above it */ [ ] The file is named correctly [ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone [ ] The only data being stored in the state is data necessary for rendering and nothing else [ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor) [ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick) [ ] All JSX used for rendering exists in the render method [ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions [ ] If any new file was added I verified that: [ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory [ ] If a new CSS style is added I verified that: [ ] A similar style doesn't already exist [ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG) [ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic. [ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases) [ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected. [ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account. [ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles: [ ] I verified that all the inputs inside a form are aligned with each other. [ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes. [ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page. [ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps. [ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR. Screenshots/Videos Android: Native Android: mWeb Chrome iOS: Native iOS: mWeb Safari MacOS: Chrome / Safari MacOS: Desktop	gharchive/pull-request	2024-11-06T16:07:10	2025-04-01T04:32:32.211980	{ "authors": [ "kirillzyusko", "mountiny" ], "repo": "Expensify/App", "url": "https://github.com/Expensify/App/pull/52121", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
1087256481	Update CONTRIBUTING.md Discussion here https://expensify.slack.com/archives/C01SKUP7QR0/p1640212812255600?thread_ts=1640200344.249400&cid=C01SKUP7QR0 Details Adding more details about expected frequency of updates Fixed Issues Only text in CONTRIBUTING.md Tests Check to see https://github.com/Expensify/App/blob/main/CONTRIBUTING.md is updated. QA Steps Tested On [ ] Web [ ] Mobile Web [ ] Desktop [ ] iOS [ ] Android Screenshots Web Mobile Web Desktop iOS Android Suggested a few edits in slack :D Updated copy, ready for re-review. :hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. 🚀 Deployed to staging by @marcaaron in version: 1.1.24-19 🚀 platform result 🤖 android 🤖 failure ❌ 🖥 desktop 🖥 failure ❌ 🍎 iOS 🍎 failure ❌ 🕸 web 🕸 failure ❌ 🚀 Deployed to production by @francoisl in version: 1.1.24-19 🚀 platform result 🤖 android 🤖 failure ❌ 🖥 desktop 🖥 failure ❌ 🍎 iOS 🍎 failure ❌ 🕸 web 🕸 failure ❌	gharchive/pull-request	2021-12-22T23:30:47	2025-04-01T04:32:32.222019	{ "authors": [ "Beamanator", "OSBotify", "chiragsalian", "mallenexpensify" ], "repo": "Expensify/App", "url": "https://github.com/Expensify/App/pull/6887", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
1196626576	Fix: Request money - Five most recent chats aren't shown correctly Details getNewChatOptions and getSearchOptions functions changed for passing sortByLastMessageTimestamp parameter. NewChatPage.js , OUParticipantsRequest.js , IOUParticipantsSplit.js files changed. "New chat" , "New group" , "Send money" , "Request money" , "Split bill" pages recents chat areas fixed. Fixed Issues $ https://github.com/Expensify/App/issues/8220 Tests 1-) Open Expensify App. 2-) Click left side chat area randomly 3-) Click "Request money". Fill number area then click "next" 4-) on Recent area should same persons for left side chat area (5 people),other contacts need sorted by alphabetical order 5-) Same situations for "New chat" , "New group" , "Send money" , "Split bill" buttons. 6-)Click search button on main screen . persons need to be recent messages 7-)Click profile button, Click workspaces, click manage members, click invite button.persons need sorted by alphabetical order example reproduce issue video before fix: https://user-images.githubusercontent.com/6093207/162324211-ce370681-e5a6-4d85-b03b-fe6c3f5b97dd.mp4 test video: https://user-images.githubusercontent.com/6093207/162325410-4cdb3a8e-955c-41f3-b1f3-62149e04294e.mp4 [x] Verify that no errors appear in the JS console PR Review Checklist Contributor (PR Author) Checklist [x] I linked the correct issue in the ### Fixed Issues section above [x] I wrote clear testing steps that cover the changes made in this PR [x] I added steps for local testing in the Tests section [ ] I added steps for Staging and/or Production testing in the QA steps section [ ] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct) [ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline) [x] I included screenshots or videos for tests on all platforms [x] I ran the tests on all platforms & verified they passed on: [x] iOS / native [x] Android / native [x] iOS / Safari [x] Android / Chrome [x] MacOS / Chrome [x] MacOS / Desktop [x] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed) [x] I followed proper code patterns (see Reviewing the code) [ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick) [ ] I verified that comments were added to code that is not self explanatory [ ] I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing. [ ] I verified any copy / text shown in the product was added in all src/languages/* files [ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy. [ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README. [ ] I verified the JSDocs style guidelines (in STYLE.md) were followed [ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers [x] I followed the guidelines as stated in the Review Guidelines [x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected) [ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests) [ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such [ ] If a new component is created I verified that: [ ] A similar component doesn't exist in the codebase [ ] All props are defined accurately and each prop has a /** comment above it / [ ] Any functional components have the displayName property [ ] The file is named correctly [ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone [ ] The only data being stored in the state is data necessary for rendering and nothing else [ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor) [ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick) [ ] All JSX used for rendering exists in the render method [ ] The component has the minimum amount of code necessary for its purpose and it is [ ] If a new CSS style is added I verified that: [ ] A similar style doesn’t already exist [ ] The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG) [ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases) [ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected. PR Reviewer Checklist [ ] I verified the correct issue is linked in the ### Fixed Issues section above [ ] I verified testing steps are clear and they cover the changes made in this PR [ ] I verified the steps for local testing are in the Tests section [ ] I verified the steps for Staging and/or Production testing are in the QA steps section [ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct) [ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline) [ ] I checked that screenshots or videos are included for tests on all platforms [ ] I verified tests pass on all platforms & I tested again on: [ ] iOS / native [ ] Android / native [ ] iOS / Safari [ ] Android / Chrome [ ] MacOS / Chrome [ ] MacOS / Desktop [ ] I verified there are no console errors (if there’s a console error not related to the PR, report it or open an issue for it to be fixed) [ ] I verified proper code patterns were followed (see Reviewing the code) [ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick). [ ] I verified that comments were added to code that is not self explanatory [ ] I verified that any new or modified comments were clear, correct English, and explained “why” the code was doing something instead of only explaining “what” the code was doing. [ ] I verified any copy / text shown in the product was added in all src/languages/ files [ ] I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy. [ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named “index.js”. All platform-specific files are named for the platform the code supports as outlined in the README. [ ] I verified the JSDocs style guidelines (in STYLE.md) were followed [ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers [ ] I verified that this PR follows the guidelines as stated in the Review Guidelines [ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests) [ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such [ ] If a new component is created I verified that: [ ] A similar component doesn't exist in the codebase [ ] All props are defined accurately and each prop has a /** comment above it */ [ ] Any functional components have the displayName property [ ] The file is named correctly [ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone [ ] The only data being stored in the state is data necessary for rendering and nothing else [ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor) [ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick) [ ] All JSX used for rendering exists in the render method [ ] The component has the minimum amount of code necessary for its purpose and it is broken down into smaller components in order to separate concerns and functions [ ] If a new CSS style is added I verified that: [ ] A similar style doesn’t already exist [ ] The style can’t be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG) [ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases) [ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected. QA Steps 1-) Open Expensify App. 2-) Click left side chat area randomly 3-) Click "Request money". Fill number area then click "next" 4-) on Recent area should same persons for left side chat area (5 people),other contacts need sorted by alphabetical order 5-) Same situations for "New chat" , "New group" , "Send money" , "Split bill" buttons. 6-)Click search button on main screen . persons need to be recent messages 7-)Click profile button, Click workspaces, click manage members, click invite button.persons need sorted by alphabetical order [ ] Verify that no errors appear in the JS console Screenshots Web https://user-images.githubusercontent.com/6093207/166141354-9ef7c485-e41d-49ba-9446-6b0462626a60.mp4 Mobile Web https://user-images.githubusercontent.com/6093207/166141521-88bb3783-8f70-42df-b6a5-486db13e3c7d.mp4 https://user-images.githubusercontent.com/6093207/166141653-63dcdcbd-c43f-4400-97e2-69f3828f4cfd.mp4 Desktop https://user-images.githubusercontent.com/6093207/166141379-86eae33a-8e3b-4a64-82e8-93a11996d90a.mp4 iOS https://user-images.githubusercontent.com/6093207/166141471-06675087-d107-41ea-a0e4-6ef99af0cefa.mp4 Android https://user-images.githubusercontent.com/6093207/166141463-0629fcfa-5c1e-432a-a90c-1e1ee6aa9ec9.mp4 Just leaving a quick comment, but I think it would be easier to default sortByLastMessageTimestamp to true for getNewChatOptions() and then specifically pass false for the "workspace members" usages if we want those not to be sorted. Thank you so much @parasharrajat , @marcaaron . I will immediately update commit and testDocument for changes 🙏. Need to confirm the sort order for various pages. Thanks for the patience. @metehanozyurt Could you please merge the main so that I can test it? Now I merged the conflict problem solved. So Sorry for falling behind the main. I will review this in some time. https://github.com/Expensify/App/pull/8549#discussion_r862389693 I did not write a new wrapper method for the reason I mentioned here. I reverted the parameters it received. I updated PR videos and checked results. I added lines to check the alphabet to the steps in the test file. I hope I succeeded this time. There is one last thing I want to say @parasharrajat . When I examined the PR files, I realized that it is more beautiful now. Thank you very much for your guidance and help. Sorry for not being able to do it earlier. I hope I didn't seem too emotional, but I really thank you 🙏 . I will review this today. Apologies for the delay. It just got out of sync. I made the changes you mentioned. Thank you for your patience and helps @parasharrajat 🙏 . @metehanozyurt We are close to the end, the only change that is left is to correct the WorkspaceInvitePage. it should be ordered in the most recent first. I was pushing this since the start but due to multiple update requests, it slipped my mind. I can not remember any other page that is an exception to the default ordering except WorkspaceInvitePage. Let me know if find any. In the QA steps. Please mention testing each page whose order is changed. Make a checklist using the following syntax. - [ ] page I am so sorry about the delay. I was very sick this week , I feel a little better today. I will complete it today. Have a nice day @parasharrajat . No worries. Take rest and get better. I want to consult about a subject before preparing a new commit @parasharrajat . When we most recent first on the WorkspaceInvitePage, users seem to be missing. Because he may not have spoken to the user in the contact list yet. I have a suggestions about it. 1-) After adding them ordered in the most recent first, can I sort and add user who have not spoken yet but are in the contact list according to the alphabet? 2-) I can change to two section RESENTS and CONTACTS like the other pages(New chat page, New group page). I wanted to ask this because there are not two separate sections like New chat page. I have concerns that users may missing compared to the previous version. Also New chat , New group , Send money , Request money and Split bill contacts lists changed. Previously, It was displayed at the added order to Onyx (ONYXKEYS.PERSONAL_DETAILS). But now it sorts alphabetically. Can I mention this in the QA steps? I created a new wrapper method (OptionsListUtils#getMemberInviteOptions) for the workspace invite page because I need to add one parameter different (maxRecentReportsToShow: 0 , // Unlimited) . For your information, I'm writing a test for this as well. Also New chat , New group , Send money , Request money and Split bill contacts lists changed. Previously, It was displayed at the added order to Onyx (ONYXKEYS.PERSONAL_DETAILS). But now it sorts alphabetically. Can I mention this in the QA steps? yes When we most recent first on the WorkspaceInvitePage, users seem to be missing. Because he may not have spoken to the user in the contact list yet. Why? Wouldn't it be just sortByLastMessageTimestamp:false for OptionsListUtils#getMemberInviteOptions. Do you know why this is happening? I think I know. The reason why we encountered this situation is as follows. We need to recentReports for sorted recent contacts.This list consists of people from the reports object. But there may also be people who do not have a report object. These people return in the personalDetails list. Before The reports object was not given because there was no prior sorting. For this reason, the personalDetails object consisted of all contacts. Before : https://github.com/Expensify/App/blob/0609796c7e0d3768217bc381b7320420c41b27d6/src/pages/workspace/WorkspaceInvitePage.js#L68-L78 After I planning: const { personalDetails, userToInvite, recentReports, } = OptionsListUtils.getMemberInviteOptions( props.reports, props.personalDetails, props.betas, '', [], this.getExcludedUsers(), ); I think we should combine these two lists (recentReports,personalDetails). Can I make a new commit ? I think you might like this idea when you see it 👼 . No, reports are not supposed to be part of this list. Only contacts. Ok , We want to list of contacts like LHN but only contacts. Recents on the top am i right? We need reports to sort contacts because it contains the lastMessageTimestamp information. If we do not give this, we cannot make a sort. For Example New Chat Page; This page give us 5 recent contacts. recentReports represent 5 recent contacts. https://github.com/Expensify/App/blob/fc3e13ea735874b4223b3ce2a88cc03e83ec9ee7/src/pages/NewChatPage.js#L65-L76 If we don't give the reports and only empty array(line 70), it will only give us the contact list(alphabeticly ordered). The recentReports information will never come. Ok, I would say just leave the contacts in A-Z order. @roryabraham Do you think the A-Z order is fine for contacts on the Workspace member invite page? Do you think the A-Z order is fine for contacts on the Workspace member invite page? Yes I think that would be fine in isolation – but for search, new chat, and request pages we'll want to sort results by most recent timestamp. Given that, I would say let's be consistent for the workspace member invite page. Ok so @metehanozyurt we can just keep the workspace behavior the same as it was before. The only change would be that previously it will now be sorted using sortByLastMessageTimestamp. Thank you @parasharrajat . I updated the QA steps and created a checklist. I hope it was in the requested format and descriptive. Thanks for doing that. Do you have an update for https://github.com/Expensify/App/pull/8549#issuecomment-1138335682? I am following this https://github.com/Expensify/App/pull/8549#issuecomment-1137988535. Please feel free to open this on Slack to get consensus. Did you get a chance to ask this on slack? Thanks @parasharrajat for chance to do this. I asked a question, I hope I did it right. I was a little nervous as this was my first time doing something like this. https://expensify.slack.com/archives/C01GTK53T8Q/p1654330306672439 I'm a little sorry that my question didn't get much attention 😢. Would you like me to leave the Workspace invite page as it is currently live version on web? I can't sort by last message time information because it will only be a list of people messaged before. A-Z order was also not considered appropriate. The only option I have left is to write a new wrapper method and show it without A-Z sorting contacts. I have bumped the thread. Thank you for helping me on Slack @parasharrajat . For this i need to one parameter for this so i add sortPersonalDetailsByAlphaAsc in getOptions params its default true . And write new wrapper method getMemberInviteOptions. I couldn't use the sortByAlphaAsc parameter because it was used to sort reports. Reports are not sent on our page (Workspace Invite Page). function getMemberInviteOptions( reports, personalDetails, betas = [], searchValue = '', selectedOptions = [], excludeLogins = [], ) { return getOptions(reports, personalDetails, 0, { betas, searchValue: searchValue.trim(), selectedOptions, excludeDefaultRooms: true, includePersonalDetails: true, excludeLogins, sortPersonalDetailsByAlphaAsc: false, }); } I am currently updating the test document for this new method. I'll update the videos once I'm done with my work. Thank you again about the Slack topic 🙏 . Hi @parasharrajat , I merged it with main branch. I updated test file , PR steps and videos. Thanks for your time 🙏 . @Expensify/applauseleads can we be sure to update the regression test suite to account for the new sorting orders on these pages, and ensure that as part of the TC's we're verifying that these list pages are correctly sorted? Thanks 🙇 🚀 Deployed to staging by @roryabraham in version: 1.1.79-0 🚀 platform result 🤖 android 🤖 success ✅ 🖥 desktop 🖥 success ✅ 🍎 iOS 🍎 success ✅ 🕸 web 🕸 success ✅ 🚀 Deployed to production by @roryabraham in version: 1.1.79-17 🚀 platform result 🤖 android 🤖 failure ❌ 🖥 desktop 🖥 success ✅ 🍎 iOS 🍎 success ✅ 🕸 web 🕸 success ✅	gharchive/pull-request	2022-04-07T22:22:14	2025-04-01T04:32:32.283821	{ "authors": [ "OSBotify", "marcaaron", "metehanozyurt", "parasharrajat", "roryabraham" ], "repo": "Expensify/App", "url": "https://github.com/Expensify/App/pull/8549", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
772641928	Start a chat with anyone Details Fixed Issues Fixes https://github.com/Expensify/Expensify/issues/145241 Tests Create an account. Add a firstname, lastname and profile photo. Open expensify cash and login with your expensify email. Search for the account in step 1. Click the account and confirm the profile photo, first and names show up, Search for an email that does not exist in your account (say test@test123456.com), click the email to DM it and confirm you can send a message to the account. If you check the db you'll see its a closed account. This means that the user will get an email of the chat inviting them to use expensify cash. Search for a phone number (say 5857527440), confirm +1 gets automatically prefixed. Click on the phone to DM it and confirm you can send a message to the account. Once again if you check the db you'll see its a closed account. Type the phone number again, confirm you can edit and place whatever international code you want. Say we put +415857527440. click the phone number and confirm you see this error because our backend couldn't validate it. Type the email test@expensify.cash and click it. Confirm you see the error, I have read the CLA Document and I hereby sign the CLA @expensify.sms is visible. I think it's worth fixing because QA will spot it immediately It's interesting to see that when we add a phone number with country code but no + we see a +[country code] added to the number with the country code. Is this something we have plans to address? @expensify.sms is visible. Ah yeah good catch. I totally didn't think about removing that. Shall update. Addressed review comments, Removed @expensify.sms when we display phone numbers and corrected the code so that external domains also show up with default avatars. Updated code to address the remaining comments. Updated. Fixed a case where the alternate text showed up with expensify.sms but now it doesn't. Taking this off HOLD now that https://github.com/Expensify/Web-Expensify/pull/29942 is on production. Awesome, thanks for taking it off hold and merging it 🙇	gharchive/pull-request	2020-12-22T05:03:44	2025-04-01T04:32:32.294398	{ "authors": [ "chiragsalian", "marcaaron" ], "repo": "Expensify/Expensify.cash", "url": "https://github.com/Expensify/Expensify.cash/pull/1035", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
824824042	Add report action context menu beta Coming from this thread Details Hides the ReportActionContextMenu behind a beta so we can merge the feature-ReportActionContextMenu branch into master and start building out the report actions with master as the base. Fixed Issues https://github.com/Expensify/Expensify/issues/147472 Tests Run the app Play with the ReportActionContextMenu a bit to get a feel for it. Open the console, go to the Application tab, and look at your local storage. Remove all values of the beta key. See that the ReportActionContextMenu will no longer display. Tested On [ ] Web [ ] Mobile Web [ ] Desktop [ ] iOS [ ] Android Screenshots Web Mobile Web Desktop iOS Android Note that the base branch of this PR is still the feature-reportActionContextMenu branch, not master. When I have time, I'll create a separate PR to merge that feature branch into master, with thorough testing on all platforms. I think we could potentially test the beta using the web proxy that contributors use instead of manually altering localstorage too. Sorry, I am not sure I understand this PR, is it implementing a new/different beta system than the one we already have? Nope, it uses the same beta system we already had. Oh ok	gharchive/pull-request	2021-03-08T18:15:39	2025-04-01T04:32:32.300925	{ "authors": [ "iwiznia", "roryabraham" ], "repo": "Expensify/Expensify.cash", "url": "https://github.com/Expensify/Expensify.cash/pull/1659", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
226632902	Feature add unit test Closes #2 @xurxodev done!	gharchive/pull-request	2017-05-05T16:59:02	2025-04-01T04:32:32.313563	{ "authors": [ "idelcano" ], "repo": "EyeSeeTea/dhis2-android-dashboard", "url": "https://github.com/EyeSeeTea/dhis2-android-dashboard/pull/4", "license": "BSD-3-Clause", "license_type": "permissive", "license_source": "github-api" }
1887192031	🛑 SM Medialogia is down In 4b72b2b, SM Medialogia (https://sm.mlg.ru) was down: HTTP code: 0 Response time: 0 ms Resolved: SM Medialogia is back up in 533ea00 after 11 minutes.	gharchive/issue	2023-09-08T08:17:07	2025-04-01T04:32:32.322455	{ "authors": [ "Ezh494" ], "repo": "Ezh494/web-uptime", "url": "https://github.com/Ezh494/web-uptime/issues/265", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
309784454	Add reST documentation for open-tamil classes/methods Continue work started by @arulalant to add reST docs for open-tamil classes and methods. Currently the following modules are exported to user as API via pip install. tamil transliterate ngram tamil.txt2ipa tamil.txt2unicode tamil.utils solthiruthi solthiruthi.stemmer spell and the following command line tools, tamilwordcount.py tamilwordfilter.py tamilurlfilter.py tamilphonetic.py tamiltscii2utf8.py tamilwordgrid.py As first effort : http://tamilpesu.us/apidoc/ will showcase the autogenerated sphinx docs via sphinx-apidoc command. The shell file 'build_sphinx.sh' is added via commit : 58114360659e81c151a994d9d2608c8e1813fb3c Actually, more documentation needs to be added in source files. Commit 58114360659e81c151a994d9d2608c8e1813fb3c only provides a way to showcase our docs.	gharchive/issue	2018-03-29T14:46:50	2025-04-01T04:32:32.327889	{ "authors": [ "arcturusannamalai" ], "repo": "Ezhil-Language-Foundation/open-tamil", "url": "https://github.com/Ezhil-Language-Foundation/open-tamil/issues/148", "license": "mit", "license_type": "permissive", "license_source": "bigquery" }
680186321	Unable to add IPv6 Service_Address using a defaultRouteDomain other than 0 Environment Application Services Version: 3.19.1 and 3.21.0 BIG-IP Version: 15.1.0.4 Summary My goal is to create forwarding virtual servers that pass all IPv4 and IPv6 traffic (as described in "Emulating stateless IP routing with BIG-IP LTM forwarding virtual servers" https://support.f5.com/csp/article/K7595). As I need to control the ICMP response and ARP behaviour, I have to specify and reference a Service_Address object in the Service_Forwarding object. Generally this is possible using IPv4 (0.0.0.0/0) or IPv6 (::/0) as the virtualAddress. However, if I change the defaultRouteDomain from 0 to another value, then it stops working for IPv6, but it still works for IPv4. If "::/0" is directly specified within virtualAddresses in the Service_Forwarding object (without a Service_Address object) the API also accepts this request -- but then I do not have control over the ICMP response... Steps To Reproduce Steps to reproduce the behavior: Create a route domain (in this example: 100). Submit the following declaration: { "schemaVersion": "3.0.0", "class": "ADC", "forwardingvirtualserver": { "class": "Tenant", "defaultRouteDomain": 100, "forwardingvirtualserver": { "class": "Application", "template": "generic", "virtual_forwarding_address": { "class": "Service_Address", "virtualAddress": "::/0" }, "forward_any_to_any": { "class": "Service_Forwarding", "forwardingType": "ip", "virtualAddresses": [ { "use": "virtual_forwarding_address" } ], "virtualPort": 0, "layer4": "any" } } } } Observe the following error response: { "results": "HTML Tag-like Content in the Request URL/Body", "declaration": { "class": "ADC", "schemaVersion": "3.0.0", "id": "autogen_64ddd8b2-0e59-4951-bd91-1c456eec1aa6", "updateMode": "selective", "controls": { "archiveTimestamp": "2020-08-17T09:50:29.985Z", "class": "Controls", "logLevel": "error", "trace": false, "traceResponse": false } }, "code": 422 } Observe the following error in /var/log/restnoded/restnoded.log: Mon, 17 Aug 2020 10:52:30 GMT - severe: [appsvcs] {"message":"Declaration failed: A port number or service name is missing for \"::%100:0\". Please specify a port number or service name using the syntax \"::%100:0.\".","level":"error"} Thank you for reporting this issue. I have confirmed it and added it to our internal product backlog as AUTOTOOL-1837. Hello, any updates on this? We are facing the same issue It looks like AUTOTOOL-1837 is still in our backlog. I will try to increasing the priority of it. This issue has been resolved by the 3.29.0 release.	gharchive/issue	2020-08-17T12:09:45	2025-04-01T04:32:32.341483	{ "authors": [ "dstokesf5", "jovnh", "manhac" ], "repo": "F5Networks/f5-appsvcs-extension", "url": "https://github.com/F5Networks/f5-appsvcs-extension/issues/324", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
157064281	Add upload buffer method to bigip.shared.file_transfer.uploads The f5-sdk currently supports file upload to BIG-IP systems (bigip.shared.file_transfer.uploads.upload_file(). We need an interface that supports uploading an in-memory buffer. With the current implementation of f5-sdk we first must write our in-memory buffer to a temporary file and then call upload_file. We need an interface that allows us to pass in a buffer and write the buffer directly to the REST API, preventing a temporary file copy. @jlongstaf the current implementation is used to read a file from a disk or disk-like location. You're asking for a way to send data after you have already read it from disk? @caphrim007 We don't read our data (certificates and keys in this case) from the file system -- we get that data directly from a certificate manager via a REST API, so it's all in memory. We'd like to keep it in memory instead of writing to a tmp file. @jlongstaf if we changed the function to accept a file-like object, could you put your data in a StringIO object? https://docs.python.org/2/library/stringio.html @caphrim007 That would definitely work for us.	gharchive/issue	2016-05-26T19:50:21	2025-04-01T04:32:32.344521	{ "authors": [ "caphrim007", "jlongstaf" ], "repo": "F5Networks/f5-common-python", "url": "https://github.com/F5Networks/f5-common-python/issues/454", "license": "apache-2.0", "license_type": "permissive", "license_source": "bigquery" }
1425910629	DO always removes some out-of-band changes (routes and managment-ip-rules) Environment Declarative Onboarding Version: 1.31 BIG-IP Version: 15.1.5.1 Summary DO always removes some out-of-band changes (routes and managment-ip-rules) After DO has successfully processed a declaration and updated TMOS config, if you add some out of band configuration such as routes, management-ip-rules, user accounts some of these items will be deleted when DO runs again. Steps To Reproduce Steps to reproduce the behavior: Submit the following declaration: { "schemaVersion": "1.31.0", "class": "Device", "async": true, "label": "my BIG-IP declaration for declarative onboarding", "Common": { "class": "Tenant", "mySystem": { "class": "System", "hostname": "bigip01.local", "autoCheck": true, "guiAuditLog": true, "mcpAuditLog": "enable", "tmshAuditLog": true, "autoPhonehome": false }, "myProvisioning": { "ltm": "nominal", "asm": "nominal", "afm": "nominal", "class": "Provision" }, "external": { "class": "VLAN", "mtu": 1500, "interfaces": [ { "name": "1.2", "tagged": false } ], "cmpHash": "src-ip" }, "internal": { "class": "VLAN", "mtu": 1500, "interfaces": [ { "name": "1.1", "tagged": false } ], "cmpHash": "src-ip" }, "external-self": { "class": "SelfIp", "address": "192.168.1.100/24", "vlan": "external", "trafficGroup": "traffic-group-local-only" }, "internal-self": { "class": "SelfIp", "address": "192.168.2.100/24", "vlan": "internal", "allowService": "default", "trafficGroup": "traffic-group-local-only" }, "dbvars": { "class": "DbVariables", "setup.run": false, "kernel.pti": "disable", "provision.1nicautoconfig": "disable", "provision.extramb": 2048, "provision.tomcat.extramb": 20, "restjavad.useextramb": true, "ui.advisory.enabled": true, "ui.advisory.color": "red", "ui.system.preferences.recordsperscreen": "250", "ui.advisory.text": "bigip01 - ext_ip:192.168.1.100 int_ip:192.168.2.100 - Managed by Automation!" } } } Add out of band changes to users, route, and firewall management-ip-rules: admin@(bigip01)(cfg-sync Standalone)(ModuleNotLicensed::Active)(/Common)(tmos)# list auth user oob-user auth user oob-user { description oob-user encrypted-password redacted partition Common partition-access { all-partitions { role guest } } session-limit -1 shell none } admin@(bigip01)(cfg-sync Standalone)(ModuleNotLicensed::Active)(/Common)(tmos)# list net route net route out-of-band-route { gw 192.168.1.1 network 192.168.100.100/32 } admin@(bigip01)(cfg-sync Standalone)(ModuleNotLicensed::Active)(/Common)(tmos)# list security firewall management-ip-rules security firewall management-ip-rules { rules { oob-rule { action accept description "out of band change" ip-protocol any rule-number 1 } } } Resubmit the same DO as step 1 (no changes) After DO successfully completes applying the DO declaration (no change) observe some of the TMOS changes are deleted: admin@(bigip01)(cfg-sync Standalone)(ModuleNotLicensed::Active)(/Common)(tmos)# list security firewall management-ip-rules security firewall management-ip-rules { } admin@(bigip01)(cfg-sync Standalone)(ModuleNotLicensed::Active)(/Common)(tmos)# list auth user oob-user auth user oob-user { description oob-user encrypted-password redacted partition Common partition-access { all-partitions { role guest } } session-limit -1 shell none } admin@(bigip01)(cfg-sync Standalone)(ModuleNotLicensed::Active)(/Common)(tmos)#(tmos)# list net route <no output> admin@(bigip01)(cfg-sync Standalone)(ModuleNotLicensed::Active)(/Common)(tmos)# Expected Behavior After DO configuration is applied, out of band configuration such as routes (no routes specified in DO), firewall management-ip-rules (no rules specified in DO), and user accounts (none specified in DO) should remain present in TMOS. Actual Behavior After DO configuration is applied, some out of band configuration is removed such as routes (no routes specified in DO) and firewall management-ip-rules (no rules specified in DO). The OOB user accounts (none specified in DO) are still present in TMOS. Why are some out of band changes removed, while others OOB changes are still present? Is there a way to contain the blast radius of DO? Why are some out of band changes removed, while others OOB changes are still present? Any out of band changes to state managed by Declarative onboarding will be removed. https://clouddocs.f5.com/products/extensions/f5-declarative-onboarding/latest/schema-reference.html Is there a way to contain the blast radius of DO? No There is a bit more information on this DO behavior in the docs. The first time you POST a BIG-IP Declarative Onboarding declaration, the system records the configuration that exists prior to processing the declaration. BIG-IP Declarative Onboarding is meant to initially configure a BIG-IP device. However, if you POST subsequent declarations to the same BIG-IP system, and leave out some of the properties you initially used, the system restores the original properties for those items. Important: No matter what you send in a subsequent declaration, BIG-IP Declarative Onboarding will never unlicense a BIG-IP device, it will never delete a user, and it never break the device trust once it has been established. Thus, while BIG-IP Declarative Onboarding is declarative, it is not idempotent. We totally understand there is expected behavior where DO will remove things from TMOS when those things are removed from the DO declaration. That is not what's happening here. We are seeing DO remove config for TMOS configuration, which was never configured via DO. I deployed a fresh VM just to be sure. I submitted the DO declaration mentioned in step 1 and then configured an out of band static route and firewall management-ip-rules. These items are not defined in DO and never have been for this fresh VM. I then re-submitted the same DO declaration as step 1 (no changes) which was successfully applied. The out of band route and management firewall rule was removed by DO. I have never configured DO with the class route schema. Is that expected behavior? Yes, this is expected behavior. The declaration is the source of truth for anything that DO can configure (with the exceptions mentioned in the docs).	gharchive/issue	2022-10-27T16:22:07	2025-04-01T04:32:32.355370	{ "authors": [ "megamattzilla", "seattlevine", "sunitharonan" ], "repo": "F5Networks/f5-declarative-onboarding", "url": "https://github.com/F5Networks/f5-declarative-onboarding/issues/328", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
957932969	Azure CI changes for FIC Description: Add Issue/Feature description Changes Proposed in PR: Fixes: #Github issue id General Checklist [x] Updated Added functionality/ bug fix in release notes [x] Added examples for new feature [x] Updated the documentation CRD Checklist [x] Updated required CR schema /AzurePipelines run /AzurePipelines run /AzurePipelines run /AzurePipelines run	gharchive/pull-request	2021-08-02T09:11:18	2025-04-01T04:32:32.359032	{ "authors": [ "nandakishorepeddi" ], "repo": "F5Networks/f5-ipam-controller", "url": "https://github.com/F5Networks/f5-ipam-controller/pull/46", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
2429272231	Catalog entry without a time axis We have some data that is just 2D and has no time axis. But the catalog seems to not allow submitting such a request, this should be fixed. That's unusual, non-timeseries data is pretty common. Could be 2D, or volumetric 3D, etc. I'm not familiar with the catalog standard/spec so don't really have any suggestions. Maybe @KathiSchleidt has some insights. must have either begin/end time or a datetime value But does it have to be associated with an actual axis? You could put a datetime as a metadata of when the data was created or so, but shouldn't require a time axis for that. yes, providing creation time should suffice, sorry for the confusion! is this also done and only needs approval? Hi @baloola, so to clarify: when the data refers to a single point in time, you recommend to use the fields Date:Creation Date, instead of the Time axis? @mari-s4e I'd worry about using creation date, as that usually refers to the time the dataset was calculated, especially with modeled data this can be years after the fact. While we could implement a different approach for datasets that cover only one point in time, I do like keeping things consistent. Any reason we cannot just use the Time Axis component, provide same begin and end time for such datasets?	gharchive/issue	2024-07-25T07:44:57	2025-04-01T04:32:32.413188	{ "authors": [ "KathiSchleidt", "baloola", "jetschny", "mari-s4e", "misev" ], "repo": "FAIRiCUBE/catalog", "url": "https://github.com/FAIRiCUBE/catalog/issues/29", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
2279650442	fixed unit Thanks @tmusho 🙂 Before we merge, let me go through the unit definitions for properties and adopt SI. It shouldn't take me too much, I can merge and regenerate the files for you to upload in NOMAD. @tmusho this is ready. I will merge, and you can use the generated tests/data/original_data_NOMADschema.archive.yaml and the zipped file to upload the data. Thanks for carefully checking the properties. The descriptions are very good 👏🏻	gharchive/pull-request	2024-05-05T17:54:22	2025-04-01T04:32:32.414935	{ "authors": [ "JosePizarro3" ], "repo": "FAIRmat-NFDI/nomad-ML-generate-smiles-reader", "url": "https://github.com/FAIRmat-NFDI/nomad-ML-generate-smiles-reader/pull/7", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
1094345538	sra_assemblyQC For Jan release to be pushed to data.argos, sra_assemblyQC by parsing SRA XML files. Blocks #9 986178dba8b0145d835d9e5ba04350e65d44d346	gharchive/issue	2022-01-05T13:22:12	2025-04-01T04:32:32.428590	{ "authors": [ "HadleyKing" ], "repo": "FDA-ARGOS/data.argosdb", "url": "https://github.com/FDA-ARGOS/data.argosdb/issues/26", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
269437377	Add shell script to run dotnet tests There is (currently) no CMake integration for C# so a shell script is used to run dotnet core to build and run xunit tests. dotnet core (2.0) allows easy installation of xunit Tests added for Tree and Shape test classes. This PR should not be merged until #287 is closed.	gharchive/pull-request	2017-10-29T21:27:15	2025-04-01T04:32:32.440829	{ "authors": [ "jbcoe" ], "repo": "FFIG/ffig", "url": "https://github.com/FFIG/ffig/pull/293", "license": "mit", "license_type": "permissive", "license_source": "bigquery" }
2617231985	Corrected the logic to consider extras when using requirements Purpose of This Pull Request [x] Bug fix Overview of Changes Bug: When using requirements, irrespective of the arguments given, only requirements.txt is considered. Fix: if no arguments are passed, only then consider requirements.txt. If arguments are passed then consider only them. Thanks so much for the fix! Goes to show I need to write more unit tests to protect against these kinda bugs. I'll merge now and release when I next get some time Cheers 🙂	gharchive/pull-request	2024-10-28T03:59:24	2025-04-01T04:32:32.446466	{ "authors": [ "FredHappyface", "tarunkrishnat0" ], "repo": "FHPythonUtils/LicenseCheck", "url": "https://github.com/FHPythonUtils/LicenseCheck/pull/94", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
1015944028	交易的验证存在安全漏洞 Describe the bug FISCO BCOS对交易的验证是有问题的，可能会导致包括但不限于伪造交易、重放等等的攻击。 To Reproduce （搭建新的区块链网络）安装必要依赖，执行以下js。该段代码生成两个payload，第一个签名签的并非交易前10个字段（的哈希），而是签的随机值；第二个复用（重放）了第一个的签名，而修改了nonce字段。 const { encode } = require('@ethersproject/rlp'); const { ecdsaSign } = require('secp256k1'); const { randomBytes } = require('crypto'); const { signature, recid } = ecdsaSign(randomBytes(32), Buffer.from('744610fbe6fdd90f9e4cdfc3e3fdaf3d1d6b8b50848df4cbd3a07301a2755b2a', 'hex')); const data = [ randomBytes(16).toString('hex'), // nonce '', // gasPrice '0f4240', // gas '01f4', // blockLimit '', // to '', // value '608060405234801561001057600080fd5b50610126806100206000396000f3fe6080604052348015600f57600080fd5b506004361060285760003560e01c80635c0ecfad14602d575b600080fd5b60336047565b604051603e91906067565b60405180910390f35b6000600143605491906080565b40905090565b60618160ad565b82525050565b6000602082019050607a6000830184605a565b92915050565b600060898260b7565b915060928360b7565b92508282101560a25760a160c1565b5b828203905092915050565b6000819050919050565b6000819050919050565b7f4e487b7100000000000000000000000000000000000000000000000000000000600052601160045260246000fdfea2646970667358221220bd01360846c294fda6ad552b95a316e10305aae7afede65dc4ee653b04744bf064736f6c63430008070033', // data '01', // chainId '01', // groupId '00', // extraData ].map(i => Buffer.from(i, 'hex')).concat([ Buffer.from([recid + 27]), // v Buffer.from(signature.slice(0, 32)), // r Buffer.from(signature.slice(32, 64)), // s ]); console.log(JSON.stringify({ jsonrpc: "2.0", method: "sendRawTransaction", params: [1, encode(data)], id: 1 })); data[0] = randomBytes(16); console.log(JSON.stringify({ jsonrpc: "2.0", method: "sendRawTransaction", params: [1, encode(data)], id: 1 })); 发送POST请求到JSON RPC接口。 curl -X POST http://127.0.0.1:8545 --data <payload> Expected behavior 两个请求均应报错。 Screenshots 实际上两个请求均被接受： Environment (please complete the following information): OS: 与OS无关 FISCO BCOS Version 2.8.0 Additional context 如果贵项目认为该issue不适合公开，请告知正确的上报方式并删除本issue。下面是一个比较直观的例子：合约： contract Vote { uint256 counter; mapping(address => bool) votedAddresses; function vote() public { require(votedAddresses[msg.sender] == false); counter++; } function getCount() public view returns (uint256) { return counter; } } 代码，关注signAndSerialize函数（需要安装ethers与secp256k1这两个依赖，同时timers/promises对node.js版本有要求）： const { utils } = require('ethers'); const { encode } = require('@ethersproject/rlp'); const { ecdsaSign } = require('secp256k1'); const { request } = require('http'); const { randomBytes } = require('crypto'); const { setTimeout } = require('timers/promises'); const post = ({ body, ...options }) => new Promise((resolve, reject) => { const req = request({ method: 'POST', ...options, }, res => { const chunks = []; res.on('data', data => chunks.push(data)); res.on('end', () => { const body = Buffer.concat(chunks); switch (res.headers['content-type']) { case 'application/json': return resolve(JSON.parse(body)); default: return resolve(body); } }); }); req.on('error', reject); if (body) { req.write(body); } req.end(); }); const privateKey = Buffer.from('b3e20ffdadfbd2b01e5f3c08b927583aa4247dbe13041d6e4ed6fde9fd50f3c2', 'hex'); const address = utils.computeAddress(privateKey); const groupId = 1; const chainId = 1; const signAndSerialize = (transaction, privateKey) => { const data = [ 'randomid', 'gasPrice', 'gas', 'blockLimit', 'to', 'value', 'data', 'chainId', 'groupId', 'extraData' ].map((key) => utils.arrayify(transaction[key] ?? new Uint8Array())); const { signature, recid } = ecdsaSign(randomBytes(32), privateKey); // 注意这里，签的是随机值而非`data`的哈希 return encode(data.concat([ new Uint8Array([recid + 27]), signature.slice(0, 32), signature.slice(32, 64), ])); }; class Client { getSignTx(to, txData, blockLimit) { return signAndSerialize({ data: txData, to, gas: 1000000, randomid: randomBytes(16), blockLimit, chainId, groupId, extraData: '0x00' }, privateKey); } getSignDeployTx(bin, blockLimit, extraData = '0x00') { return signAndSerialize({ data: `0x${bin}`, gas: 1000000, randomid: randomBytes(16), blockLimit, chainId, groupId, extraData }, privateKey); } request(method, params) { return post({ host: '127.0.0.1', port: 8545, body: JSON.stringify({ jsonrpc: '2.0', method, params, id: 1 }), headers: { 'Content-Type': 'application/json' }, }); } async sendRawTransaction(to, f, params) { const iface = new utils.Interface([f]); const func = Object.values(iface.functions)[0]; const blockNumber = parseInt((await this.request('getBlockNumber', [groupId])).result, 16); const txData = `${iface.getSighash(func)}${iface._encodeParams(func.inputs, params).slice(2)}`; const signTx = this.getSignTx(to, txData, blockNumber + 500); const { result: tx } = await this.request('sendRawTransaction', [groupId, signTx]); await setTimeout(1000); const { result: { status, statusMsg, output } } = await this.request('getTransactionReceipt', [groupId, tx]); if (parseInt(status, 16)) { throw new Error(statusMsg); } else { return utils.defaultAbiCoder.decode(func.outputs, output); } } async deploy(abi, bin, parameters) { const contractAbi = new utils.Interface(abi); const inputs = contractAbi.deploy.inputs; const paramsBin = contractAbi._encodeParams(inputs, parameters); const blockNumber = parseInt((await this.request('getBlockNumber', [groupId])).result, 16); const signTx = this.getSignDeployTx(bin + paramsBin.slice(2), blockNumber + 500); const { result: tx } = await this.request('sendRawTransaction', [groupId, signTx]); await setTimeout(1000); const { result } = await this.request('getTransactionReceipt', [groupId, tx]); return result; } async call(to, f, params) { const iface = new utils.Interface([f]); const func = Object.values(iface.functions)[0]; const { result: { output, status } } = await this.request('call', [groupId, { from: address, to, value: '0x0', data: `${iface.getSighash(func)}${iface._encodeParams(func.inputs, params).slice(2)}` }]); if (parseInt(status, 16)) { throw new Error(`Failed to call ${f}`); } else { return utils.defaultAbiCoder.decode(func.outputs, output); } } } (async () => { const client = new Client(); const { contractAddress } = await client.deploy( '[{"inputs":[],"name":"getCount","outputs":[{"internalType":"uint256","name":"","type":"uint256"}],"stateMutability":"view","type":"function"},{"inputs":[],"name":"vote","outputs":[],"stateMutability":"nonpayable","type":"function"}]', '608060405234801561001057600080fd5b506101c4806100206000396000f3fe608060405234801561001057600080fd5b50600436106100365760003560e01c8063632a9a521461003b578063a87d942c14610045575b600080fd5b610043610063565b005b61004d6100d9565b60405161005a91906100f1565b60405180910390f35b60001515600160003373ffffffffffffffffffffffffffffffffffffffff1673ffffffffffffffffffffffffffffffffffffffff16815260200190815260200160002060009054906101000a900460ff161515146100c057600080fd5b6000808154809291906100d290610116565b9190505550565b60008054905090565b6100eb8161010c565b82525050565b600060208201905061010660008301846100e2565b92915050565b6000819050919050565b60006101218261010c565b91507fffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffffff8214156101545761015361015f565b5b600182019050919050565b7f4e487b7100000000000000000000000000000000000000000000000000000000600052601160045260246000fdfea2646970667358221220c9b8c6b8d1e6300d442605933ffb9a6f90164e1a53c617a4ef3dce61ceab32c464736f6c63430008070033', [], ); console.log(await client.sendRawTransaction(contractAddress, 'function vote() public', [])); console.log(await client.call(contractAddress, 'function getCount() public view returns (uint256)', [])); console.log(await client.sendRawTransaction(contractAddress, 'function vote() public', [])); console.log(await client.call(contractAddress, 'function getCount() public view returns (uint256)', [])); })(); 运行结果如下： > node index.js [] [ BigNumber { _hex: '0x01', _isBigNumber: true } ] [] [ BigNumber { _hex: '0x02', _isBigNumber: true } ] 可见deploy、sendRawTransaction、call均是成功的。而且第二次也是sendRawTransaction成功的，说明了ECDSA.recover恢复出来的公钥（对应的地址）的确是不同于真实sender的。至于为什么不比较真实的sender地址与恢复出来的地址，我认为是由于sender可以自己执行ECDSA.recover，并把自己的地址设置为恢复出来的地址。这样，这个比较就没有意义了。但是我仍然觉得这样做（也就是用ECDSA.recover而非传统的ECDSA.verify）可能存在问题（尽管以太坊也是这样做的），不知道各位的观点如何。	gharchive/issue	2021-10-05T06:39:37	2025-04-01T04:32:32.458139	{ "authors": [ "winderica" ], "repo": "FISCO-BCOS/FISCO-BCOS", "url": "https://github.com/FISCO-BCOS/FISCO-BCOS/issues/1990", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
417872577	Aggregate monitored sub-prefixes into best-effort super-prefixes Is your feature request related to a problem? Please describe. Instead of opening one taps per prefix we should do some internal smart aggregation to aggregate them in batches. Describe the solution you'd like Do the aggregation recursively; monitor the super-prefixes, but discard BGP updates for non-configured prefixes. E.g., if 2 /24 and 1 /23 --> aggregate the /24 in 1 /23 (if neighbors) and then if the new /23 and the old /23 are also neighbors build a /22 and end there. Do this only on monitoring and taps. Describe alternatives you've considered N/A Additional context N/A @slowr are you sure that https://github.com/FORTH-ICS-INSPIRE/artemis/pull/146 resolves this issue? It seems that the prefix aggregation is orthogonal to the RIPE RIS firehose implementation.	gharchive/issue	2019-03-06T15:44:55	2025-04-01T04:32:32.489762	{ "authors": [ "vkotronis" ], "repo": "FORTH-ICS-INSPIRE/artemis", "url": "https://github.com/FORTH-ICS-INSPIRE/artemis/issues/137", "license": "BSD-3-Clause", "license_type": "permissive", "license_source": "github-api" }
1510836864	Move Payment Gateways into folders Add support for payment gateways in folders Current structure is "PaymentProvider.php" in /src/library/Payment/Adapter With this PR we add support for creating a folder for "PaymentProvider" and in the folder contents "Adapter.php" Advantages Allow support for composer that does't need to be loaded into the core Flexibility in the future for allowing to add logo's of the payment provider Easier install as we can treat it more closer as a Module. Just download zip and extract it into /src/library/Payment/Adapter/ Setup Dependabot for each Payment provider in repo. As we still have backward compability with the old system I don't see any issues for implentening it. They only thing we should consider is renaming the the classnames As we currently autoload php classes it need to be the same name as Payment_Adapter_Mollie_Adapter How ever it would be nicer if it can be Payment_Adapter_Mollie but then it doesn't get auto loaded. So far I have testing it with activating / edit settings but currently in the process for writing a "Dutch/EU" based payment provider so I don't know if this works in all the cases so far. How ever I think it is important to start the discussion faster if this something we want. If not we can always revert it and change it now and not continue when we are done. If we agree for Payment providers we should also convert "Hosting" and Domain registers Makes sense to me. LGTM. But I also would be happy to see if at least one of the legacy adapter files were converted into a subfolder as an example. LGTM. But I also would be happy to see if at least one of the legacy adapter files were converted into a subfolder as an example. Working on "non" legacy app the changes are minimal See https://github.com/jaapmarcus/mollie-fossbilling/ But is still in progress... Is this still a draft? Yes but all functions work fine should be fine to merge... Changes that are required move "Stripe" adapter to "Stripe" folder and rename it to adapter.php and change the class name to Stripe_Adapter ... Changes made "Adapter" name needs to follow naming: Adapter/Adapter.php eg 'Mollie/Mollie.php' Class name should be class Payment_Adapter_Adapter for example Payment_Adapter_Mollie in my case	gharchive/pull-request	2022-12-26T10:39:37	2025-04-01T04:32:32.497369	{ "authors": [ "John-S4", "evrifaessa", "jaapmarcus" ], "repo": "FOSSBilling/FOSSBilling", "url": "https://github.com/FOSSBilling/FOSSBilling/pull/630", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
354954731	Dependent tuple projectors do not have a definition Weird, I thought we had finished solving all these things, but see this: module TestSigmaProj open FStar.Tactics noeq type mydep a (b:a->Type) = \| Mk : x:a -> y:(b x) -> mydep a b #set-options "--ugly --print_implicits" let _ = assert (Cons?.hd [1] == 1) by (dump "1"; compute (); dump "2") let _ = assert (Mktuple2?._1 ( 1, 2 ) == 1) by (dump "1"; compute (); dump "2") let _ = assert (Mkdtuple2?._1 (\| 1, 2 \|) == 1) by (dump "1"; compute (); dump "2") Output, summarized: (return_val, uu___, any_result, uu___, any_result, uu___ \|- ?64 : (squash (eq2 #int (__proj__Cons__item__hd #int (Cons #int 1 (Nil #int))) 1))) (return_val, uu___, any_result, uu___, any_result, uu___ \|- ?64 : (squash (eq2 #int 1 1))) ( \|- ?66 : (squash (eq2 #int (__proj__Mktuple2__item___1 #int #int (Mktuple2 #int #int 1 2)) 1))) ( \|- ?66 : (squash (eq2 #int 1 1))) ( \|- ?80 : (squash (eq2 #int (__proj__Mkdtuple2__item___1 #int #(fun uu___ -> (int $$ (residual) Prims.GTot Type)) (Mkdtuple2 #int #(fun uu___ -> (int $$ (residual) Prims.GTot Type)) 1 2)) 1))) ( \|- ?80 : (squash (eq2 #int (__proj__Mkdtuple2__item___1 #int #(fun uu___ -> (int $$ (residual) Prims.GTot Type)) (Mkdtuple2 #int #(fun uu___ -> (int $$ (residual) Prims.GTot Type)) 1 2)) 1))) So Cons?.hd [1] and Mktuple?._1 reduced perfectly, but not Mkdtuple2?._1. From dumping the modules I can see it does not have a definition. Ha, it's actually just Mkdtuple2. Should be easy to find the culprit. Fixed. It required a small reordering in Prims, so cc @aseemr @nikswamy just in case.	gharchive/issue	2018-08-29T00:50:55	2025-04-01T04:32:32.647438	{ "authors": [ "mtzguido" ], "repo": "FStarLang/FStar", "url": "https://github.com/FStarLang/FStar/issues/1526", "license": "apache-2.0", "license_type": "permissive", "license_source": "bigquery" }
586391488	Fixes for FStarLang/FStar#1905 Removes some warnings. thanks Guido!	gharchive/pull-request	2020-03-23T17:34:07	2025-04-01T04:32:32.648371	{ "authors": [ "msprotz", "mtzguido" ], "repo": "FStarLang/kremlin", "url": "https://github.com/FStarLang/kremlin/pull/175", "license": "apache-2.0", "license_type": "permissive", "license_source": "bigquery" }
1013875207	Visible paragraphs' last index is [-1] but visibleParIndex was [0] 1.Run JavaKeywordsDemo to open the "Java Keywords Demo" window. 2.Copy one line text, such as "System.err.println("Warning: empty string as argument");". 3.Press Ctrl + A to select whole text, then Press Ctrl + V to paste, got follow error. 4.It only happens when paste for the first time. Exception in thread "JavaFX Application Thread" java.lang.IllegalArgumentException: Visible paragraphs' last index is [-1] but visibleParIndex was [0] at org.fxmisc.richtext.GenericStyledArea.visibleParToAllParIndex(GenericStyledArea.java:982) at org.fxmisc.richtext.ViewActions.firstVisibleParToAllParIndex(ViewActions.java:284) at org.fxmisc.richtext.LineNumberFactory.deleteParagraphCheck(LineNumberFactory.java:148) at org.fxmisc.richtext.LineNumberFactory.lambda$new$1(LineNumberFactory.java:91) at com.sun.javafx.application.PlatformImpl.lambda$null$5(PlatformImpl.java:295) at java.security.AccessController.doPrivileged(Native Method) at com.sun.javafx.application.PlatformImpl.lambda$runLater$6(PlatformImpl.java:294) at com.sun.glass.ui.InvokeLaterDispatcher$Future.run$$$capture(InvokeLaterDispatcher.java:95) at com.sun.glass.ui.InvokeLaterDispatcher$Future.run(InvokeLaterDispatcher.java) at com.sun.glass.ui.win.WinApplication._runLoop(Native Method) at com.sun.glass.ui.win.WinApplication.lambda$null$4(WinApplication.java:185) at java.lang.Thread.run(Thread.java:748) Yep, We encountered the same with the XML Editor highlighting https://github.com/JabRef/jabref/issues/7860 Seems like its's already fixed in master https://github.com/FXMisc/RichTextFX/issues/1021	gharchive/issue	2021-10-02T01:26:02	2025-04-01T04:32:32.706552	{ "authors": [ "Siedlerchr", "fangzhongwei" ], "repo": "FXMisc/RichTextFX", "url": "https://github.com/FXMisc/RichTextFX/issues/1042", "license": "bsd-2-clause", "license_type": "permissive", "license_source": "bigquery" }
269975313	ExceptionInInitializerError: EventType "MOUSE_OVER_TEXT_ANY"with parent "EVENT" already exists Full trace below, but the issue seems to be that there are classes org/fxmisc/richtext/event/MouseOverTextEvent.java and org/fxmisc/richtext/MouseOverTextEvent.java (i.e. with and without event) both trying to register themselves with the same name. I'm guessing only one of these classes should exist. Seen in 0.8.1 Exception in thread "JavaFX Application Thread" java.lang.ExceptionInInitializerError at org.fxmisc.richtext.GenericStyledArea.lambda$null$40(GenericStyledArea.java:1374) at org.reactfx.util.Right.unify(Either.java:265) at org.fxmisc.richtext.GenericStyledArea.lambda$null$41(GenericStyledArea.java:1372) at org.reactfx.MappedStream.lambda$observeInputs$0(MappedStream.java:25) at org.reactfx.util.NonAccumulativeStreamNotifications.lambda$head$0(NotificationAccumulator.java:134) at org.reactfx.ObservableBase.notifyObservers(ObservableBase.java:68) at org.reactfx.ObservableBase.notifyObservers(ObservableBase.java:57) at org.reactfx.ProperEventStream.emit(ProperEventStream.java:18) at org.reactfx.EventStream$1.lambda$observeInputs$1(EventStream.java:424) at org.reactfx.util.NonAccumulativeStreamNotifications.lambda$head$0(NotificationAccumulator.java:134) at org.reactfx.ObservableBase.notifyObservers(ObservableBase.java:68) at org.reactfx.ObservableBase.notifyObservers(ObservableBase.java:57) at org.reactfx.ProperEventStream.emit(ProperEventStream.java:18) at org.reactfx.MappedStream.lambda$observeInputs$0(MappedStream.java:25) at org.reactfx.util.NonAccumulativeStreamNotifications.lambda$head$0(NotificationAccumulator.java:134) at org.reactfx.ObservableBase.notifyObservers(ObservableBase.java:68) at org.reactfx.ObservableBase.notifyObservers(ObservableBase.java:57) at org.reactfx.ProperEventStream.emit(ProperEventStream.java:18) at org.reactfx.FilterStream.lambda$observeInputs$0(FilterStream.java:20) at org.reactfx.util.NonAccumulativeStreamNotifications.lambda$head$0(NotificationAccumulator.java:134) at org.reactfx.ObservableBase.notifyObservers(ObservableBase.java:68) at org.reactfx.ObservableBase.notifyObservers(ObservableBase.java:57) at org.reactfx.ProperEventStream.emit(ProperEventStream.java:18) at org.reactfx.DistinctStream.lambda$observeInputs$0(DistinctStream.java:23) at org.reactfx.util.NonAccumulativeStreamNotifications.lambda$head$0(NotificationAccumulator.java:134) at org.reactfx.ObservableBase.notifyObservers(ObservableBase.java:68) at org.reactfx.ObservableBase.notifyObservers(ObservableBase.java:57) at org.reactfx.ProperEventStream.emit(ProperEventStream.java:18) at org.reactfx.EventStream$1.lambda$observeInputs$1(EventStream.java:424) at org.reactfx.util.NonAccumulativeStreamNotifications.lambda$head$0(NotificationAccumulator.java:134) at org.reactfx.ObservableBase.notifyObservers(ObservableBase.java:68) at org.reactfx.ObservableBase.notifyObservers(ObservableBase.java:57) at org.reactfx.ProperEventStream.emit(ProperEventStream.java:18) at org.reactfx.MappedStream.lambda$observeInputs$0(MappedStream.java:25) at org.reactfx.util.NonAccumulativeStreamNotifications.lambda$head$0(NotificationAccumulator.java:134) at org.reactfx.ObservableBase.notifyObservers(ObservableBase.java:68) at org.reactfx.ObservableBase.notifyObservers(ObservableBase.java:57) at org.reactfx.ProperEventStream.emit(ProperEventStream.java:18) at com.sun.javafx.event.CompositeEventHandler$NormalEventHandlerRecord.handleBubblingEvent(CompositeEventHandler.java:218) at com.sun.javafx.event.CompositeEventHandler.dispatchBubblingEvent(CompositeEventHandler.java:80) at com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:238) at com.sun.javafx.event.EventHandlerManager.dispatchBubblingEvent(EventHandlerManager.java:191) at com.sun.javafx.event.CompositeEventDispatcher.dispatchBubblingEvent(CompositeEventDispatcher.java:59) at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:58) at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114) at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56) at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114) at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56) at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114) at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56) at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114) at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56) at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114) at com.sun.javafx.event.BasicEventDispatcher.dispatchEvent(BasicEventDispatcher.java:56) at com.sun.javafx.event.EventDispatchChainImpl.dispatchEvent(EventDispatchChainImpl.java:114) at com.sun.javafx.event.EventUtil.fireEventImpl(EventUtil.java:74) at com.sun.javafx.event.EventUtil.fireEvent(EventUtil.java:54) at javafx.event.Event.fireEvent(Event.java:198) at com.sun.javafx.event.EventQueue.fire(EventQueue.java:48) at javafx.scene.Scene$MouseHandler.handleEnterExit(Scene.java:3676) at javafx.scene.Scene$MouseHandler.process(Scene.java:3742) at javafx.scene.Scene$MouseHandler.access$1500(Scene.java:3485) at javafx.scene.Scene.impl_processMouseEvent(Scene.java:1762) at javafx.scene.Scene$ScenePeerListener.mouseEvent(Scene.java:2494) at com.sun.javafx.tk.quantum.GlassViewEventHandler$MouseEventNotification.run(GlassViewEventHandler.java:381) at com.sun.javafx.tk.quantum.GlassViewEventHandler$MouseEventNotification.run(GlassViewEventHandler.java:295) at java.security.AccessController.doPrivileged(Native Method) at com.sun.javafx.tk.quantum.GlassViewEventHandler.lambda$handleMouseEvent$354(GlassViewEventHandler.java:417) at com.sun.javafx.tk.quantum.QuantumToolkit.runWithoutRenderLock(QuantumToolkit.java:389) at com.sun.javafx.tk.quantum.GlassViewEventHandler.handleMouseEvent(GlassViewEventHandler.java:416) at com.sun.glass.ui.View.handleMouseEvent(View.java:555) at com.sun.glass.ui.View.notifyMouse(View.java:937) at com.sun.glass.ui.win.WinApplication._runLoop(Native Method) at com.sun.glass.ui.win.WinApplication.lambda$null$148(WinApplication.java:191) at java.lang.Thread.run(Thread.java:748) Caused by: java.lang.IllegalArgumentException: EventType "MOUSE_OVER_TEXT_ANY"with parent "EVENT" already exists at javafx.event.EventType.register(EventType.java:186) at javafx.event.EventType.<init>(EventType.java:128) at org.fxmisc.richtext.event.MouseOverTextEvent.<clinit>(MouseOverTextEvent.java:19) ... 75 more Hmm... maybe I forgot to delete one of them before making that release? Yup. I copied it there but didn't remove the original location. That's trivial to fix. Could you reproduce the code that causes this? I can't seem to reproduce it on my end. If I can't reproduce, I'm not sure whether I've really fixed it either. @twistedsquare reopen this if #636 doesn't fix this issue. I've made a snapshot release with this fix in it.	gharchive/issue	2017-10-31T14:18:05	2025-04-01T04:32:32.711320	{ "authors": [ "JordanMartinez", "twistedsquare" ], "repo": "FXMisc/RichTextFX", "url": "https://github.com/FXMisc/RichTextFX/issues/634", "license": "bsd-2-clause", "license_type": "permissive", "license_source": "bigquery" }
2063644528	Lab 20-22/Lab 22 directory - BUG BUG BUG	gharchive/pull-request	2024-01-03T09:51:17	2025-04-01T04:32:32.716145	{ "authors": [ "FabianaCampanari" ], "repo": "FabianaCampanari/SQL_LABS", "url": "https://github.com/FabianaCampanari/SQL_LABS/pull/413", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
600431552	Map the new serverbound jigsaw generating packet This is jigsaw generate things not things generate jigsaw Signed-off-by: liach liach@users.noreply.github.com This clashes with #1282, but I believe JigsawGeneratingC2SPacket is better because this is jigsaw generating stuff not stuff generating jigsaw.	gharchive/pull-request	2020-04-15T16:31:16	2025-04-01T04:32:32.805022	{ "authors": [ "liach" ], "repo": "FabricMC/yarn", "url": "https://github.com/FabricMC/yarn/pull/1283", "license": "CC0-1.0", "license_type": "permissive", "license_source": "github-api" }
294373347	Porting to tensorflow Hi do you think it would be possible to port this to tensorflow? Not specifically requesting you to do it(although that would be awesome) just wondering what your thoughts are on this? Cheers I am not very familiar with tensorflow. But my lab colleague told me that it is possible to provide both a data tensor and a filter tensor and perform convolution in tensorflow. I will try to port it to tensorflow if there is enough time (going to graduate...). If you want to port the project, I can help if needed. Please refer to https://ypw.io/style-transfer/ for pytorch implementation.	gharchive/issue	2018-02-05T12:18:26	2025-04-01T04:32:32.950558	{ "authors": [ "FalongShen", "Sugarbank" ], "repo": "FalongShen/styletransfer", "url": "https://github.com/FalongShen/styletransfer/issues/4", "license": "BSD-2-Clause", "license_type": "permissive", "license_source": "github-api" }
1636970507	Client Crashing when opening any kind of inventory like crafting table except players inventory this is with the latest version of the 1.19.4 of fabrication. https://gist.github.com/Phili0p/0ec53072a51a958876abb136eb592f86 fixed in 3.2.2	gharchive/issue	2023-03-23T07:07:23	2025-04-01T04:32:32.951956	{ "authors": [ "Phili0p", "SFort" ], "repo": "FalsehoodMC/Fabrication", "url": "https://github.com/FalsehoodMC/Fabrication/issues/592", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
1713941078	Errors When entering wrong login information, error should be different from "No Server Response" Agreed. Error messages on Auth page can be improved.	gharchive/issue	2023-05-17T13:37:12	2025-04-01T04:32:32.957374	{ "authors": [ "alexistorosina1", "chris-t-li" ], "repo": "Fantasy-Fit/fantasy-fit-web", "url": "https://github.com/Fantasy-Fit/fantasy-fit-web/issues/140", "license": "CC0-1.0", "license_type": "permissive", "license_source": "github-api" }
1991913276	[Question] Why not define the terminate function for some goal tasks like reacher-v4? Question Hi! After reading some documents about truncation and termination, I think the terminate function is used to end the episode in some typical goal-related tasks, e.g., reacher-v4. But the terminate function seems not to be defined explicitly in the reacher-v4 env. Why? Thanks in advance. The reacher-v5 environment does not terminate when the goal is reached because, that is how it was first implemented in reacher-v0 and this is how we have been carrying it forward. I assume (though I have not tested it) that if it did terminate upon reaching the goal, then the trained policy would result in reaching the goal with high velocity, and therefore leaving the goal immediately after reaching it. Thought could also have been an oversight from the original developers of reacher-v0. I have not been able to find the original development documents for the reacher environment, so I am not sure about the design goals. In either case the environment has such low complexity that it practically does not affect its solvability with training algorithms, for more complex manipulation problems you can check the gymansium-robotics repo. main reason for the missing terminate function is to maintain the target state after the goal has been reached That is definitely one of the consequences of not having a terminate functions (though it may not be the most efficient way to achieve such a result)	gharchive/issue	2023-11-14T03:25:44	2025-04-01T04:32:32.963594	{ "authors": [ "Kallinteris-Andreas", "STAY-Melody" ], "repo": "Farama-Foundation/Gymnasium", "url": "https://github.com/Farama-Foundation/Gymnasium/issues/776", "license": "mit", "license_type": "permissive", "license_source": "bigquery" }
2093268713	Pip install gymnasium doesn't work Question Hello i want to try gymnasium on the application pycode that work with python 3.11.2 and I have this error could you help me to solve it? Thank for your help Your image doesn't show most of the error message but it looks like you need to install patchelf. If this doesn't work, could you post a more complete image I tried to install patchelf with 'pip instal patchelf' and I have an error I take the entire error in photo I didn't if this could help you to help me. I think this came from the application I guess. 🤔	gharchive/issue	2024-01-22T07:31:57	2025-04-01T04:32:32.967664	{ "authors": [ "VOCdevShy", "pseudo-rnd-thoughts" ], "repo": "Farama-Foundation/Gymnasium", "url": "https://github.com/Farama-Foundation/Gymnasium/issues/884", "license": "mit", "license_type": "permissive", "license_source": "bigquery" }
1769186837	is_jitted does not properly detect if inside a jit call (tested in version 0.4.12) Since jax 0.4.12 (could be for other versions>0.4.1) the is_jitted function does not properly detect if inside a jit call. import jumpy def f(a): if jumpy.core.is_jitted(): print("JITTED") else: print("NOT JITTED") return a*2 jax.jit(f)(1) --> NOT JITTED Changing the is_jitted function to the following resolves the problem, but it is a very hacky fix. Also not sure about backward compatibility. def is_jitted() -> bool: """Returns true if currently inside a jax.jit call or jit is disabled.""" if jp.is_jax_installed is False: return False elif jax.config.jax_disable_jit: return True else: return len(jax._src.core.thread_local_state.trace_state.trace_stack.stack) > 1 # return jax.core.cur_sublevel().level > 0 I was planning on updating the whole project to jax 0.4.X as 0.4 removes DeviceArray for Array. Therefore, I would be good to include in fix in the project when we update	gharchive/issue	2023-06-22T08:18:58	2025-04-01T04:32:32.970233	{ "authors": [ "bheijden", "pseudo-rnd-thoughts" ], "repo": "Farama-Foundation/Jumpy", "url": "https://github.com/Farama-Foundation/Jumpy/issues/33", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
1509635877	Milestone 01: Initialize Project In this branch, I have worked on the following things 👍 ✔️ Added Person Class ✔️ Added Student Class ✔️ Added Teacher Class ✔️ Implemented Inheritance, Encapsulation, Polymorphism, and Abstraction ✔️ Followed GitFlow ✔️ Followed Ruby's best practices ✔️ Followed Linters ✔️ Documented work in a professional way @codecaiine Thanks for your kind review and feedback, I have implemented all required changes. @BertrandConxy Thanks for your kind review.	gharchive/pull-request	2022-12-23T18:30:55	2025-04-01T04:32:32.972320	{ "authors": [ "FaranoshAmini" ], "repo": "FaranoshAmini/School_Library", "url": "https://github.com/FaranoshAmini/School_Library/pull/1", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
306114694	Reworked german translation That was fun 👍 Coverage remained the same at 89.728% when pulling 7265b7c34e1269acf3e94c0cb5db5b195f0a3fef on AscendFB:staging into 89639726dee974afbb3600f957cd5e31a153e403 on FarmBot:staging. Thanks so much for the help on this @AscendFB !	gharchive/pull-request	2018-03-17T00:56:59	2025-04-01T04:32:32.976775	{ "authors": [ "AscendFB", "RickCarlino", "coveralls" ], "repo": "FarmBot/Farmbot-Web-App", "url": "https://github.com/FarmBot/Farmbot-Web-App/pull/727", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
2288247871	Add Null-conditional operator to Client.Dispose in the DisposeAsync method I noticed while trying to write some tests that I got an error from the dispose async method. When I looked it was not null checking to prevent calling dispose on a null object. This should address that issue. merged... thank you!	gharchive/pull-request	2024-05-09T18:39:37	2025-04-01T04:32:32.979564	{ "authors": [ "dj-nitehawk", "kylelaverty" ], "repo": "FastEndpoints/FastEndpoints", "url": "https://github.com/FastEndpoints/FastEndpoints/pull/678", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
337273519	0.2.0 release Merge the 0.2 branch into master, in preparation for the release of windres 0.2.0. All required tests are green! bors r+	gharchive/pull-request	2018-07-01T08:21:22	2025-04-01T04:32:33.013033	{ "authors": [ "FaultyRAM" ], "repo": "FaultyRAM/windres-rs", "url": "https://github.com/FaultyRAM/windres-rs/pull/11", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
1604166007	✨feat: metric improvements - support more types of metric Fix #179 Changes proposed in this pull request: Add more types of metric, including Conversion, Count, Duration and Revenue Add display of event formula Codecov Report Merging #185 (02d3aa3) into main (7b031d2) will decrease coverage by 29.57%. The diff coverage is n/a. :mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@ ## main #185 +/- ## ============================================= - Coverage 94.53% 64.97% -29.57% - Complexity 0 539 +539 ============================================= Files 40 163 +123 Lines 1080 4716 +3636 Branches 353 604 +251 ============================================= + Hits 1021 3064 +2043 - Misses 58 1503 +1445 - Partials 1 149 +148 Flag Coverage Δ Carryforward flag api_ut 54.02% <ø> (?) Carriedforward from 7d5602e server 68.86% <ø> (?) Carriedforward from 7d5602e ui 94.53% <ø> (ø) This pull request uses carry forward flags. Click here to find out more. Impacted Files Coverage Δ ...om/featureprobe/api/dto/SegmentVersionRequest.java 100.00% <0.00%> (ø) ...rc/main/java/com/featureprobe/api/Application.java 0.00% <0.00%> (ø) ...ava/com/featureprobe/api/mapper/WebHookMapper.java 100.00% <0.00%> (ø) ...va/com/featureprobe/api/service/MemberService.java 84.04% <0.00%> (ø) ...va/com/featureprobe/api/auth/JwtConfiguration.java 0.00% <0.00%> (ø) .../featureprobe/api/controller/ServerController.java 0.00% <0.00%> (ø) ...a/com/featureprobe/api/dto/MemberItemResponse.java 0.00% <0.00%> (ø) ...om/featureprobe/api/controller/MiscController.java 0.00% <0.00%> (ø) ...com/featureprobe/api/mapper/HookContextMapper.java 0.00% <0.00%> (ø) ...featureprobe/api/controller/TrafficController.java 0.00% <0.00%> (ø) ... and 113 more	gharchive/pull-request	2023-03-01T03:26:07	2025-04-01T04:32:33.039322	{ "authors": [ "codecov-commenter", "frankzhaopeng" ], "repo": "FeatureProbe/FeatureProbe", "url": "https://github.com/FeatureProbe/FeatureProbe/pull/185", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
1956918581	🛑 Foundry VTT 002 is down In 0f37bc0, Foundry VTT 002 ($FOUNDRY002) was down: HTTP code: 502 Response time: 175 ms Resolved: Foundry VTT 002 is back up in 5811f99 after 1 hour, 9 minutes.	gharchive/issue	2023-10-23T11:10:45	2025-04-01T04:32:33.080906	{ "authors": [ "FeistyViking" ], "repo": "FeistyViking/crb_foundry-upptime", "url": "https://github.com/FeistyViking/crb_foundry-upptime/issues/225", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
186903627	Feedback on other Serverless setups We are using this plugin in production but would be useful to get some information how does it handle other setups. Cheers! 😃 I've just converted a project to use it (25 functions) and it's sped up deployment a lot. I've had some issues with using npm projects that don't play nicely with (I suspect) browserify (such as nodemailer) which I'm still working through. Errors such as: Unable to import module '_optimize/tsz-serverless-api-dev-wp-shared-email/functions/workers/shared/email/handler': Error at Module.require (module.js:497:17) at require (internal/module.js:20:19) at s (/var/task/_optimize/tsz-serverless-api-dev-wp-shared-email/functions/workers/shared/email/handler.js:1:554) at /var/task/_optimize/tsz-serverless-api-dev-wp-shared-email/functions/workers/shared/email/handler.js:1:745 at Object.467.semver (/var/task/_optimize/tsz-serverless-api-dev-wp-shared-email/functions/workers/shared/email/handler.js:86189:18) at s (/var/task/_optimize/tsz-serverless-api-dev-wp-shared-email/functions/workers/shared/email/handler.js:1:694) at /var/task/_optimize/tsz-serverless-api-dev-wp-shared-email/functions/workers/shared/email/handler.js:1:745 at Object.1190.chalk (/var/task/_optimize/tsz-serverless-api-dev-wp-shared-email/functions/workers/shared/email/handler.js:235973:15) at s (/var/task/_optimize/tsz-serverless-api-dev-wp-shared-email/functions/workers/shared/email/handler.js:1:694) at /var/task/_optimize/tsz-serverless-api-dev-wp-shared-email/functions/workers/shared/email/handler.js:1:745 at Object.1188../css (/var/task/_optimize/tsz-serverless-api-dev-wp-shared-email/functions/workers/shared/email/handler.js:235686:14) at s (/var/task/_optimize/tsz-serverless-api-dev-wp-shared-email/functions/workers/shared/email/handler.js:1:694) at /var/task/_optimize/tsz-serverless-api-dev-wp-shared-email/functions/workers/shared/email/handler.js:1:745 at Object.1189../css (/var/task/_optimize/tsz-serverless-api-dev-wp-shared-email/functions/workers/shared/email/handler.js:235965:15) Currently working through these to see what the issue is. @darbio did u get to resolve this issue? @bwistero yes and no.. See #54 - I removed the offending packages and replaced them with ones that could be webpacked. We're using it in production now with no issues.	gharchive/issue	2016-11-02T19:55:31	2025-04-01T04:32:33.127731	{ "authors": [ "bwisitero", "darbio", "goncaloneves" ], "repo": "FidelLimited/serverless-plugin-optimize", "url": "https://github.com/FidelLimited/serverless-plugin-optimize/issues/2", "license": "mit", "license_type": "permissive", "license_source": "bigquery" }
751847993	Mobile: Unable to 'Paste' text in the textbox while messaging Open FP app and login as valid user and navigate to Inbox Select any user and tap in the textbox to have an option to Paste. Issue: You will observe that options as 'Select/Select all' are displayed but no Paste option. my Android view seems fine, what's your device and browser @rabbi08 my Android view seems fine, what's your device and browser @rabbi08 iPhone 11 pro max This is working for me on iphone 6s Works for me on Android. This is working fine, may be it was more zoom in out the paste was not working. Tested again, it worked Hence closing this issue. Thanks	gharchive/issue	2020-11-26T22:16:56	2025-04-01T04:32:33.138073	{ "authors": [ "Zaydme", "ddveloper", "emtay", "rabbi08" ], "repo": "FightPandemics/FightPandemics", "url": "https://github.com/FightPandemics/FightPandemics/issues/1950", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
1291972679	🛑 logs.zzls.xyz is down In 2b89487, logs.zzls.xyz (https://logs.zzls.xyz) was down: HTTP code: 502 Response time: 407 ms Resolved: logs.zzls.xyz is back up in fb28caf.	gharchive/issue	2022-07-02T05:32:08	2025-04-01T04:32:33.142437	{ "authors": [ "Fijxu" ], "repo": "Fijxu/justlog-instances-uptime", "url": "https://github.com/Fijxu/justlog-instances-uptime/issues/30", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
1502473153	🛑 logs.zzls.xyz is down In 663d53a, logs.zzls.xyz (https://logs.zzls.xyz) was down: HTTP code: 0 Response time: 0 ms Resolved: logs.zzls.xyz is back up in fa9fc37.	gharchive/issue	2022-12-19T07:56:48	2025-04-01T04:32:33.143853	{ "authors": [ "Fijxu" ], "repo": "Fijxu/justlog-instances-uptime", "url": "https://github.com/Fijxu/justlog-instances-uptime/issues/634", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
1599763908	🛑 logs.zzls.xyz is down In 9bc0f35, logs.zzls.xyz (https://logs.zzls.xyz) was down: HTTP code: 0 Response time: 0 ms Resolved: logs.zzls.xyz is back up in b52b081.	gharchive/issue	2023-02-25T16:48:20	2025-04-01T04:32:33.145507	{ "authors": [ "Fijxu" ], "repo": "Fijxu/justlog-instances-uptime", "url": "https://github.com/Fijxu/justlog-instances-uptime/issues/775", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
1895117959	what is events_pb2 where can i get this from No module named 'events_pb2' You need to use protocompiler to compile the protobuf in the Apex Legends game directory, there's a readme inside with how to do it	gharchive/issue	2023-09-13T19:23:23	2025-04-01T04:32:33.150368	{ "authors": [ "FilippoLeone", "t3pmd" ], "repo": "FilippoLeone/apex-live-api", "url": "https://github.com/FilippoLeone/apex-live-api/issues/1", "license": "Unlicense", "license_type": "permissive", "license_source": "github-api" }
186014650	Version 0.1.1 is unavailable {:pandex, "~> 0.1.1"} won't resolve, because 0.1.1 is unavailable in hex.pm. Please publish new version or change mix deps to {:pandex, "~> 0.1"} in Readme. @denispeplin I've just published the latest 0.2.0.	gharchive/issue	2016-10-28T20:30:02	2025-04-01T04:32:33.154015	{ "authors": [ "denispeplin", "seanomlor" ], "repo": "FilterKaapi/pandex", "url": "https://github.com/FilterKaapi/pandex/issues/2", "license": "mit", "license_type": "permissive", "license_source": "bigquery" }
1059354401	compilation break Hi, It seems that a commit you made on Friday broke the compilation for the cumm library. My command for compilation (in a dockerfile) is this: RUN git clone https://github.com/FindDefinition/cumm && cd ./cumm && export CUMM_DISABLE_JIT="1" && python -m pip install -e . Errors look like this: They didn't happen before Friday and they seem to be related to the changes you made. /workspace/cumm/include/tensorview/tensor.h:243:17: error: ‘struct tv::Context’ has no member named ‘has_cuda_stream’ 243 \| if (ctx.has_cuda_stream()) { /workspace/cumm/include/tensorview/tensor.h:245:42: error: ‘struct tv::Context’ has no member named ‘cuda_stream’ 245 \| size_ * sizeof(T), ctx.cuda_stream()); This is a bug, these code should be covered by TV_CUDA macro, will be fixed soon. Do you use export CUMM_CUDA_VERSION=""? If you haven't set this env, the cuda build should be enabled and your bug should't exist, this bug should only exists in CPU-only build. by the way, you shouldn't use export CUMM_DISABLE_JIT="1" in editable install. I will update readme for this. Thanks for the quick reply! I'm not exporting CUMM_CUDA_VERSION; I am building the docker on a machine without gpu, maybe this is the reason? Rolling back to the previous commit before this removes the bug and I can build the package without a problem. Your problem shouldn't happen if you haven't set CUMM_CUDA_VERSION. you can print that env to check whether TV_CUDA is set. Some notes: If you want to build cumm for spconv, you need to build cumm with CUDA because spconv + cuda need cumm + cuda. you can check official build script(github actions). Thanks Yan! I'm building on a cuda docker so I think that is covered, I'll check the official build to see if I can get any more insights from there.	gharchive/issue	2021-11-21T11:25:54	2025-04-01T04:32:33.173402	{ "authors": [ "FindDefinition", "YishGene" ], "repo": "FindDefinition/cumm", "url": "https://github.com/FindDefinition/cumm/issues/1", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
245293638	[General] Update README Updated readme to lower the required GCC version (building w/ gcc5.4 was tested) and specify the Lua version required. Also link to the project for the TODO since it will stay more up to date and easier to maintain than updating readme constantly. okie, done	gharchive/pull-request	2017-07-25T05:59:27	2025-04-01T04:32:33.174081	{ "authors": [ "sedruk" ], "repo": "FiniteReality/disccord", "url": "https://github.com/FiniteReality/disccord/pull/40", "license": "mit", "license_type": "permissive", "license_source": "bigquery" }
1508922178	Incorrect shading with smooth lighting This affects all relevant blocks, but is especially noticeable with carpets. I've been trying to figure this one out for a while. It's an issue in the ambient occlusion - it's pulling the values from the wrong spots. My original thought was it was an issue with the transformed quads, but that doesn't seem to be the case at least.	gharchive/issue	2022-12-23T05:48:39	2025-04-01T04:32:33.183246	{ "authors": [ "FirEmerald", "Zygahedron" ], "repo": "FirEmerald/AdditionalPlacements", "url": "https://github.com/FirEmerald/AdditionalPlacements/issues/23", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
1606912897	chore(storage-image-labeling): rename extension This PR renames the extension to "Image Labeling from Storage" Closing as not needed	gharchive/pull-request	2023-03-02T14:30:32	2025-04-01T04:32:33.184522	{ "authors": [ "cabljac" ], "repo": "FirebaseExtended/experimental-extensions", "url": "https://github.com/FirebaseExtended/experimental-extensions/pull/119", "license": "apache-2.0", "license_type": "permissive", "license_source": "bigquery" }
624973248	[firebase_dynamic_links] Can't see campaign logs in Conversions menu(iOS) Describe the bug Can't see campaign logs in "Conversions" menu after a tap on a dynamic link on iOS. Also, the amount of "clicks", "redirects" and "re-opens" for dynamic link increments fine. "App-installs" and "first open" – not increments after app installing. Android works fine. To Reproduce Steps to reproduce the behavior: Create a dynamic link with UTM parameters using firebase console. Tap it using an iOS device and install app. Try to find utm info Expected behavior Campaign info is counted. Additional context Tutorial I used to implement dynamic links I'm using native code to handle dynamic link. override func application(_ application: UIApplication, continue userActivity: NSUserActivity, restorationHandler: @escaping ([UIUserActivityRestoring]?) -> Void) -> Bool { let handled = DynamicLinks.dynamicLinks().handleUniversalLink(userActivity.webpageURL!) { (dynamiclink, error) in if (dynamiclink != nil) { self.linkStreamHandler.handleLink(dynamiclink?.url?.absoluteString ?? "") } } .... Also, did not forget to use FirebaseApp.configure() Flutter doctor Run flutter doctor and paste the output below: [✓] Flutter (Channel stable, v1.17.1, on Mac OS X 10.15.4 19E266, locale en-UA) [✓] Android toolchain - develop for Android devices (Android SDK version 29.0.0-rc2) [✓] Xcode - develop for iOS and macOS (Xcode 11.4.1) [✓] Android Studio (version 3.6) [✓] Connected device (2 available) Hi @RomanKapshuk Can you please provide your flutter run --verbose and a minimal complete reproducible code sample. Thank you @TahaTesser My code sample AppDelegate.swift import UIKit import Flutter import Firebase import FirebaseInstanceID import GoogleMaps @UIApplicationMain @objc class AppDelegate: FlutterAppDelegate { private var eventChannel: FlutterEventChannel? private let linkStreamHandler = LinkStreamHandler() override func application( _ application: UIApplication, didFinishLaunchingWithOptions launchOptions: [UIApplication.LaunchOptionsKey: Any]? ) -> Bool { if #available(iOS 10.0, ) { UNUserNotificationCenter.current().delegate = self as? UNUserNotificationCenterDelegate } let controller = window.rootViewController as! FlutterBinaryMessenger eventChannel = FlutterEventChannel(name: "app/events", binaryMessenger: controller) FirebaseApp.configure() GeneratedPluginRegistrant.register(with: self) eventChannel?.setStreamHandler(linkStreamHandler) return super.application(application, didFinishLaunchingWithOptions: launchOptions) } override func application(_ application: UIApplication, continue userActivity: NSUserActivity, restorationHandler: @escaping ([UIUserActivityRestoring]?) -> Void) -> Bool { let handled = DynamicLinks.dynamicLinks().handleUniversalLink(userActivity.webpageURL!) { (dynamiclink, error) in if (dynamiclink != nil) { self.linkStreamHandler.handleLink(dynamiclink?.url?.absoluteString ?? "") } } if (!handled) { if userActivity.activityType == NSUserActivityTypeBrowsingWeb { let url = userActivity.webpageURL! eventChannel?.setStreamHandler(linkStreamHandler) return linkStreamHandler.handleLink(url.absoluteString) //handle url and open whatever page you want to open. } } return handled; } } class LinkStreamHandler:NSObject, FlutterStreamHandler { var eventSink: FlutterEventSink? // links will be added to this queue until the sink is ready to process them var queuedLinks = [String]() func onListen(withArguments arguments: Any?, eventSink events: @escaping FlutterEventSink) -> FlutterError? { self.eventSink = events queuedLinks.forEach({ events($0) }) queuedLinks.removeAll() return nil } func onCancel(withArguments arguments: Any?) -> FlutterError? { self.eventSink = nil return nil } func handleLink(_ link: String) -> Bool { guard let eventSink = eventSink else { queuedLinks.append(link) return false } eventSink(link) return true } } main.dart void main() async { WidgetsFlutterBinding.ensureInitialized(); FlutterError.onError = (FlutterErrorDetails details) { Crashlytics.instance.recordError(details, details.stack); }; await SystemChrome.setPreferredOrientations([ DeviceOrientation.portraitUp, ]); final _firebaseMessaging = FirebaseMessaging(); ... /// Other initzializations ... runApp(MyApp(start: startApp())); } BLoC than handle links import 'dart:async'; import 'package:bloc/bloc.dart'; import 'package:flutter/services.dart'; import 'events.dart'; import 'states.dart'; export 'events.dart'; export 'states.dart'; final chanel = EventChannel('app/events'); class DeepLinkBloc extends Bloc<DeepLinkEvent, DeepLinkState> { StreamSubscription _subscription; DeepLinkBloc() { _subscription ??= chanel.receiveBroadcastStream().listen( (data) { add( NewDataReceived(data), ); }, ); } @override DeepLinkState get initialState => IdleState(); @override Stream<DeepLinkState> mapEventToState(DeepLinkEvent event) async { if (event is NewDataReceived) yield* _handleNewEvent(event); } Stream<DeepLinkState> _handleNewEvent(NewDataReceived event) async* { ... /// Handle links and yield events. There are no plugin dependencies. As well as in a widget that handles that events ... } void dispose() { _subscription.cancel(); _subscription = null; super.close(); } } Command line invocation: /Applications/Xcode.app/Contents/Developer/usr/bin/xcodebuild -list Information about project "Runner": Targets: Runner Build Configurations: Debug Release Profile If no build configuration is specified and -scheme is not passed then "Release" is used. Schemes: Runner [ +34 ms] Found plugin apple_sign_in at /Users/r.kapshuk/.pub-cache/hosted/pub.dartlang.org/apple_sign_in-0.1.0/ [ +3 ms] Found plugin camera at /Users/r.kapshuk/.pub-cache/hosted/pub.dartlang.org/camera-0.5.8+2/ [ +5 ms] Found plugin device_info at /Users/r.kapshuk/.pub-cache/hosted/pub.dartlang.org/device_info-0.4.2+4/ [ +2 ms] Found plugin file_picker at /Users/r.kapshuk/.pub-cache/hosted/pub.dartlang.org/file_picker-1.9.0+1/ [ +1 ms] Found plugin firebase_analytics at /Users/r.kapshuk/.pub-cache/hosted/pub.dartlang.org/firebase_analytics-5.0.11/ [ ] Found plugin firebase_core at /Users/r.kapshuk/.pub-cache/hosted/pub.dartlang.org/firebase_core-0.4.4+3/ [ ] Found plugin firebase_core_web at /Users/r.kapshuk/.pub-cache/hosted/pub.dartlang.org/firebase_core_web-0.1.1+2/ [ ] Found plugin firebase_crashlytics at /Users/r.kapshuk/.pub-cache/hosted/pub.dartlang.org/firebase_crashlytics-0.1.3+3/ [ ] Found plugin firebase_dynamic_links at /Users/r.kapshuk/.pub-cache/hosted/pub.dartlang.org/firebase_dynamic_links-0.5.0+11/ [ ] Found plugin firebase_messaging at /Users/r.kapshuk/.pub-cache/hosted/pub.dartlang.org/firebase_messaging-6.0.15/ [ ] Found plugin firebase_remote_config at /Users/r.kapshuk/.pub-cache/hosted/pub.dartlang.org/firebase_remote_config-0.3.0+3/ [ +7 ms] Found plugin flutter_custom_tabs at /Users/r.kapshuk/.pub-cache/hosted/pub.dartlang.org/flutter_custom_tabs-0.6.0/ [ +1 ms] Found plugin flutter_facebook_login at /Users/r.kapshuk/.pub-cache/hosted/pub.dartlang.org/flutter_facebook_login-3.0.0/ [ +2 ms] Found plugin flutter_image_compress at /Users/r.kapshuk/.pub-cache/hosted/pub.dartlang.org/flutter_image_compress-0.6.8/ [ ] Found plugin flutter_inappwebview at /Users/r.kapshuk/.pub-cache/hosted/pub.dartlang.org/flutter_inappwebview-3.2.0/ [ +1 ms] Found plugin flutter_plugin_android_lifecycle at /Users/r.kapshuk/.pub-cache/hosted/pub.dartlang.org/flutter_plugin_android_lifecycle-1.0.8/ [ +2 ms] Found plugin flutter_webview_plugin at /Users/r.kapshuk/.pub-cache/hosted/pub.dartlang.org/flutter_webview_plugin-0.3.11/ [ +2 ms] Found plugin google_maps_flutter at /Users/r.kapshuk/.pub-cache/hosted/pub.dartlang.org/google_maps_flutter-0.5.27+2/ [ +1 ms] Found plugin google_sign_in at /Users/r.kapshuk/.pub-cache/hosted/pub.dartlang.org/google_sign_in-4.4.6/ [ +2 ms] Found plugin google_sign_in_web at /Users/r.kapshuk/.pub-cache/hosted/pub.dartlang.org/google_sign_in_web-0.9.1+1/ [ +2 ms] Found plugin image_crop at Users/appPath/lib/plugins/image_crop/ [ +1 ms] Found plugin image_picker at /Users/r.kapshuk/.pub-cache/hosted/pub.dartlang.org/image_picker-0.6.6+4/ [ +3 ms] Found plugin location at /Users/r.kapshuk/.pub-cache/hosted/pub.dartlang.org/location-3.0.2/ [ ] Found plugin location_web at /Users/r.kapshuk/.pub-cache/hosted/pub.dartlang.org/location_web-1.0.0/ [ +2 ms] Found plugin package_info at /Users/r.kapshuk/.pub-cache/hosted/pub.dartlang.org/package_info-0.4.0+18/ [ +1 ms] Found plugin path_provider at /Users/r.kapshuk/.pub-cache/hosted/pub.dartlang.org/path_provider-1.6.9/ [ ] Found plugin path_provider_macos at /Users/r.kapshuk/.pub-cache/hosted/pub.dartlang.org/path_provider_macos-0.0.4+3/ [ +1 ms] Found plugin permission_handler at /Users/r.kapshuk/.pub-cache/hosted/pub.dartlang.org/permission_handler-5.0.0+hotfix.6/ [ +5 ms] Found plugin screen at /Users/r.kapshuk/.pub-cache/hosted/pub.dartlang.org/screen-0.0.5/ [ +1 ms] Found plugin share at /Users/r.kapshuk/.pub-cache/hosted/pub.dartlang.org/share-0.6.4+2/ [ +1 ms] Found plugin shared_preferences at /Users/r.kapshuk/.pub-cache/hosted/pub.dartlang.org/shared_preferences-0.5.7+2/ [ ] Found plugin shared_preferences_macos at /Users/r.kapshuk/.pub-cache/hosted/pub.dartlang.org/shared_preferences_macos-0.0.1+9/ [ +1 ms] Found plugin shared_preferences_web at /Users/r.kapshuk/.pub-cache/hosted/pub.dartlang.org/shared_preferences_web-0.1.2+7/ [ +1 ms] Found plugin sqflite at /Users/r.kapshuk/.pub-cache/hosted/pub.dartlang.org/sqflite-1.3.0+1/ [ +3 ms] Found plugin url_launcher at /Users/r.kapshuk/.pub-cache/hosted/pub.dartlang.org/url_launcher-5.4.7/ [ ] Found plugin url_launcher_macos at /Users/r.kapshuk/.pub-cache/hosted/pub.dartlang.org/url_launcher_macos-0.0.1+7/ [ +1 ms] Found plugin url_launcher_web at /Users/r.kapshuk/.pub-cache/hosted/pub.dartlang.org/url_launcher_web-0.1.1+6/ [ +1 ms] Found plugin video_player at /Users/r.kapshuk/.pub-cache/hosted/pub.dartlang.org/video_player-0.10.11+1/ [ ] Found plugin video_player_web at /Users/r.kapshuk/.pub-cache/hosted/pub.dartlang.org/video_player_web-0.1.3+1/ [ ] Found plugin wakelock at /Users/r.kapshuk/.pub-cache/hosted/pub.dartlang.org/wakelock-0.1.4+1/ [ ] Found plugin webview_flutter at /Users/r.kapshuk/.pub-cache/hosted/pub.dartlang.org/webview_flutter-0.3.22+1/ [ +33 ms] executing: mkfifo /var/folders/l2/630fk1dj0w5_7hgxtnwlmpt80000gp/T/flutter_build_log_pipe.HHOjvf/pipe_to_stdout [ +8 ms] Exit code 0 from: mkfifo /var/folders/l2/630fk1dj0w5_7hgxtnwlmpt80000gp/T/flutter_build_log_pipe.HHOjvf/pipe_to_stdout [ +3 ms] Running Xcode build... [ +1 ms] executing: [/Users/appPath/ios/] /usr/bin/env xcrun xcodebuild -configuration Debug VERBOSE_SCRIPT_LOGGING=YES -workspace Runner.xcworkspace -scheme Runner BUILD_DIR=/Users/appPath/build/ios -sdk iphonesimulator -arch x86_64 SCRIPT_OUTPUT_STREAM_FILE=/var/folders/l2/630fk1dj0w5_7hgxtnwlmpt80000gp/T/flutter_build_log_pipe.HHOjvf/pipe_to_stdout FLUTTER_SUPPRESS_ANALYTICS=true COMPILER_INDEX_STORE_ENABLE=NO [+20677 ms] Running Xcode build... (completed in 20,667ms, longer than expected) [ ] └─Compiling, linking and signing... ProcessInfoPlistFile /Users/appPath/build/ios/Debug-iphonesimulator/GTMAppAuth/GTMAppAuth.framework/Info.plist /Users/appPath/ios/Pods/Target\ Support\ Files/GTMAppAuth/GTMAppAuth-Info.plist (in target 'GTMAppAuth' from project 'Pods') cd /Users/appPath/ios/Pods builtin-infoPlistUtility /Users/appPath/ios/Pods/Target\ Support\ Files/GTMAppAuth/GTMAppAuth-Info.plist -producttype com.apple.product-type.framework -expandbuildsettings -format binary -platform iphonesimulator -o /Users/appPath/build/ios/Debug-iphonesimulator/GTMAppAuth/GTMAppAuth.framework/Info.plist ProcessInfoPlistFile /Users/appPath/build/ios/Debug-iphonesimulator/FirebaseCoreDiagnostics/FirebaseCoreDiagnostics.framework/Info.plist /Users/appPath/ios/Pods/Target\ Support\ Files/FirebaseCoreDiagnostics/FirebaseCoreDiagnostics-Info.plist (in target 'FirebaseCoreDiagnostics' from project 'Pods') cd /Users/appPath/ios/Pods builtin-infoPlistUtility /Users/appPath/ios/Pods/Target\ Support\ Files/FirebaseCoreDiagnostics/FirebaseCoreDiagnostics-Info.plist -producttype com.apple.product-type.framework -expandbuildsettings -format binary -platform iphonesimulator -o /Users/appPath/build/ios/Debug-iphonesimulator/FirebaseCoreDiagnostics/FirebaseCoreDiagnostics.framework/Info.plist WriteAuxiliaryFile /Users/r.kapshuk/Library/Developer/Xcode/DerivedData/Runner-hdswkbhxyktsyjghzcbbprrekqvs/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/FirebaseCore.build/FirebaseCore-all-target-headers.hmap (in target 'FirebaseCore' from project 'Pods') cd /Users/appPath/ios/Pods write-file /Users/r.kapshuk/Library/Developer/Xcode/DerivedData/Runner-hdswkbhxyktsyjghzcbbprrekqvs/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/FirebaseCore.build/FirebaseCore-all-target-headers.hmap ProcessInfoPlistFile /Users/appPath/build/ios/Debug-iphonesimulator/FBSDKLoginKit/FBSDKLoginKit.framework/Info.plist /Users/appPath/ios/Pods/Target\ Support\ Files/FBSDKLoginKit/FBSDKLoginKit-Info.plist (in target 'FBSDKLoginKit' from project 'Pods') cd /Users/appPath/ios/Pods builtin-infoPlistUtility /Users/appPath/ios/Pods/Target\ Support\ Files/FBSDKLoginKit/FBSDKLoginKit-Info.plist -producttype com.apple.product-type.framework -expandbuildsettings -format binary -platform iphonesimulator -o /Users/appPath/build/ios/Debug-iphonesimulator/FBSDKLoginKit/FBSDKLoginKit.framework/Info.plist CodeSign /Users/appPath/build/ios/Debug-iphonesimulator/DKPhotoGallery/DKPhotoGallery.bundle (in target 'DKPhotoGallery-DKPhotoGallery' from project 'Pods') cd /Users/appPath/ios/Pods export CODESIGN_ALLOCATE=/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/codesign_allocate Signing Identity: "-" /usr/bin/codesign --force --sign - --timestamp=none /Users/appPath/build/ios/Debug-iphonesimulator/DKPhotoGallery/DKPhotoGallery.bundle /Users/appPath/build/ios/Debug-iphonesimulator/DKPhotoGallery/DKPhotoGallery.bundle: replacing existing signature CodeSign /Users/appPath/build/ios/Debug-iphonesimulator/GTMAppAuth/GTMAppAuth.framework (in target 'GTMAppAuth' from project 'Pods') cd /Users/appPath/ios/Pods export CODESIGN_ALLOCATE=/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/codesign_allocate Signing Identity: "-" /usr/bin/codesign --force --sign - --timestamp=none /Users/appPath/build/ios/Debug-iphonesimulator/GTMAppAuth/GTMAppAuth.framework /Users/appPath/build/ios/Debug-iphonesimulator/GTMAppAuth/GTMAppAuth.framework: replacing existing signature CodeSign /Users/appPath/build/ios/Debug-iphonesimulator/FirebaseCoreDiagnostics/FirebaseCoreDiagnostics.framework (in target 'FirebaseCoreDiagnostics' from project 'Pods') cd /Users/appPath/ios/Pods export CODESIGN_ALLOCATE=/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/codesign_allocate Signing Identity: "-" /usr/bin/codesign --force --sign - --timestamp=none /Users/appPath/build/ios/Debug-iphonesimulator/FirebaseCoreDiagnostics/FirebaseCoreDiagnostics.framework /Users/appPath/build/ios/Debug-iphonesimulator/FirebaseCoreDiagnostics/FirebaseCoreDiagnostics.framework: replacing existing signature CodeSign /Users/appPath/build/ios/Debug-iphonesimulator/FBSDKLoginKit/FBSDKLoginKit.framework (in target 'FBSDKLoginKit' from project 'Pods') cd /Users/appPath/ios/Pods export CODESIGN_ALLOCATE=/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/codesign_allocate Signing Identity: "-" /usr/bin/codesign --force --sign - --timestamp=none /Users/appPath/build/ios/Debug-iphonesimulator/FBSDKLoginKit/FBSDKLoginKit.framework /Users/appPath/build/ios/Debug-iphonesimulator/FBSDKLoginKit/FBSDKLoginKit.framework: replacing existing signature WriteAuxiliaryFile /Users/r.kapshuk/Library/Developer/Xcode/DerivedData/Runner-hdswkbhxyktsyjghzcbbprrekqvs/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/FirebaseInstallations.build/FirebaseInstallations-all-target-header s.hmap (in target 'FirebaseInstallations' from project 'Pods') cd /Users/appPath/ios/Pods write-file /Users/r.kapshuk/Library/Developer/Xcode/DerivedData/Runner-hdswkbhxyktsyjghzcbbprrekqvs/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/FirebaseInstallations.build/FirebaseInstallations-all-target-he aders.hmap WriteAuxiliaryFile /Users/r.kapshuk/Library/Developer/Xcode/DerivedData/Runner-hdswkbhxyktsyjghzcbbprrekqvs/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/FirebaseDynamicLinks.build/FirebaseDynamicLinks-all-target-headers. hmap (in target 'FirebaseDynamicLinks' from project 'Pods') cd /Users/appPath/ios/Pods write-file /Users/r.kapshuk/Library/Developer/Xcode/DerivedData/Runner-hdswkbhxyktsyjghzcbbprrekqvs/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/FirebaseDynamicLinks.build/FirebaseDynamicLinks-all-target-head ers.hmap ProcessInfoPlistFile /Users/appPath/build/ios/Debug-iphonesimulator/FirebaseCore/FirebaseCore.framework/Info.plist /Users/appPath/ios/Pods/Target\ Support\ Files/FirebaseCore/FirebaseCore-Info.plist (in target 'FirebaseCore' from project 'Pods') cd /Users/appPath/ios/Pods builtin-infoPlistUtility /Users/appPath/ios/Pods/Target\ Support\ Files/FirebaseCore/FirebaseCore-Info.plist -producttype com.apple.product-type.framework -expandbuildsettings -format binary -platform iphonesimulator -o /Users/appPath/build/ios/Debug-iphonesimulator/FirebaseCore/FirebaseCore.framework/Info.plist WriteAuxiliaryFile /Users/r.kapshuk/Library/Developer/Xcode/DerivedData/Runner-hdswkbhxyktsyjghzcbbprrekqvs/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/FirebaseABTesting.build/FirebaseABTesting-all-target-headers.hmap (in target 'FirebaseABTesting' from project 'Pods') cd /Users/appPath/ios/Pods write-file /Users/r.kapshuk/Library/Developer/Xcode/DerivedData/Runner-hdswkbhxyktsyjghzcbbprrekqvs/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/FirebaseABTesting.build/FirebaseABTesting-all-target-headers.hm ap ProcessInfoPlistFile /Users/appPath/build/ios/Debug-iphonesimulator/google_sign_in/google_sign_in.framework/Info.plist /Users/appPath/Pods/Target\ Support\ Files/google_sign_in/google_sign_in-Info.plist (in target 'google_sign_in' from project 'Pods') cd /Users/appPath/ios/Pods builtin-infoPlistUtility /Users/appPath/ios/Pods/Target\ Support\ Files/google_sign_in/google_sign_in-Info.plist -producttype com.apple.product-type.framework -expandbuildsettings -format binary -platform iphonesimulator -o /Users/appPath/build/ios/Debug-iphonesimulator/google_sign_in/google_sign_in.framework/Info.plist CompileC /Users/r.kapshuk/Library/Developer/Xcode/DerivedData/Runner-hdswkbhxyktsyjghzcbbprrekqvs/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/firebase_dynamic_links.build/Objects-normal/x86_64/FLTFirebaseDynam icLinksPlugin.o /Users/r.kapshuk/.pub-cache/hosted/pub.dartlang.org/firebase_dynamic_links-0.5.0+11/ios/Classes/FLTFirebaseDynamicLinksPlugin.m normal x86_64 objective-c com.apple.compilers.llvm.clang.1_0.compiler (in target 'firebase_dynamic_links' from project 'Pods') cd /Users/appPath/ios/Pods export LANG=en_US.US-ASCII /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -x objective-c -target x86_64-apple-ios8.0-simulator -fmessage-length=0 -fdiagnostics-show-note-include-stack -fmacro-backtrace-limit=0 -std=gnu11 -fobjc-arc -fobjc-weak -fmodules -gmodules -fmodules-cache-path=/Users/r.kapshuk/Library/Developer/Xcode/DerivedData/ModuleCache.noindex -fmodules-prune-interval=86400 -fmodules-prune-after=345600 -fbuild-session-file=/Users/r.kapshuk/Library/Developer/Xcode/DerivedData/ModuleCache.noindex/Session.modulevalidation -fmodules-validate-once-per-build-session -Wnon-modular-include-in-framework-module -Werror=non-modular-include-in-framework-module -fmodule-name=firebase_dynamic_links -Wno-trigraphs -fpascal-strings -O0 -fno-common -Wno-missing-field-initializers -Wno-missing-prototypes -Werror=return-type -Wdocumentation -Wunreachable-code -Wno-implicit-atomic-properties -Werror=deprecated-objc-isa-usage -Wno-objc-interface-ivars -Werror=objc-root-class -Wno-arc-repeated-use-of-weak -Wimplicit-retain-self -Wduplicate-method-match -Wno-missing-braces -Wparentheses -Wswitch -Wunused-function -Wno-unused-label -Wno-unused-parameter -Wunused-variable -Wunused-value -Wempty-body -Wuninitialized -Wconditional-uninitialized -Wno-unknown-pragmas -Wno-shadow -Wno-four-char-constants -Wno-conversion -Wconstant-conversion -Wint-conversion -Wbool-conversion -Wenum-conversion -Wno-float-conversion -Wnon-literal-null-conversion -Wobjc-literal-conversion -Wshorten-64-to-32 -Wpointer-sign -Wno-newline-eof -Wno-selector -Wno-strict-selector-match -Wundeclared-selector -Wdeprecated-implementations -DPOD_CONFIGURATION_DEBUG=1 -DDEBUG=1 -DCOCOAPODS=1 -DPERMISSION_EVENTS=0 -DPERMISSION_REMINDERS=0 -DPERMISSION_CONTACTS=0 -DPERMISSION_MICROPHONE=0 -DPERMISSION_SPEECH_RECOGNIZER=0 -DPERMISSION_MEDIA_LIBRARY=0 -DPERMISSION_SENSORS=0 -DOBJC_OLD_DISPATCH_PROTOTYPES=0 -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator13.4.sdk -fasm-blocks -fstrict-aliasing -Wprotocol -Wdeprecated-declarations -g -Wno-sign-conversion -Winfinite-recursion -Wcomma -Wblock-capture-autoreleasing -Wstrict-prototypes -Wno-semicolon-before-method-body -Wunguarded-availability -fobjc-abi-version=2 -fobjc-legacy-dispatch -iquote /Users/r.kapshuk/Library/Developer/Xcode/DerivedData/Runner-hdswkbhxyktsyjghzcbbprrekqvs/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/firebase_dynamic_links.build/firebase_dynamic_links-generated-f iles.hmap -I/Users/r.kapshuk/Library/Developer/Xcode/DerivedData/Runner-hdswkbhxyktsyjghzcbbprrekqvs/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/firebase_dynamic_links.build/firebase_dynamic_links-own-targe t-headers.hmap -I/Users/r.kapshuk/Library/Developer/Xcode/DerivedData/Runner-hdswkbhxyktsyjghzcbbprrekqvs/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/firebase_dynamic_links.build/firebase_dynamic_links-all-non-f ramework-target-headers.hmap -ivfsoverlay /Users/r.kapshuk/Library/Developer/Xcode/DerivedData/Runner-hdswkbhxyktsyjghzcbbprrekqvs/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/firebase_dynamic_links.build/all-product-headers.yaml -iquote /Users/r.kapshuk/Library/Developer/Xcode/DerivedData/Runner-hdswkbhxyktsyjghzcbbprrekqvs/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/firebase_dynamic_links.build/firebase_dynamic_links-project-hea ders.hmap -I/Users/appPath/build/ios/Debug-iphonesimulator/firebase_dynamic_links/include -I/Users/appPath/ios/Pods/Headers/Public -I/Users/r.kapshuk/Library/Developer/Xcode/DerivedData/Runner-hdswkbhxyktsyjghzcbbprrekqvs/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/firebase_dynamic_links.build/DerivedSources-normal/x86_64 -I/Users/r.kapshuk/Library/Developer/Xcode/DerivedData/Runner-hdswkbhxyktsyjghzcbbprrekqvs/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/firebase_dynamic_links.build/DerivedSources/x86_64 -I/Users/r.kapshuk/Library/Developer/Xcode/DerivedData/Runner-hdswkbhxyktsyjghzcbbprrekqvs/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/firebase_dynamic_links.build/DerivedSources -F/Users/appPath/build/ios/Debug-iphonesimulator/firebase_dynamic_links -F/Users/appPath/build/ios/Debug-iphonesimulator/FirebaseABTesting -F/Users/appPath/build/ios/Debug-iphonesimulator/FirebaseCore -F/Users/appPath/build/ios/Debug-iphonesimulator/FirebaseCoreDiagnostics -F/Users/appPath/build/ios/Debug-iphonesimulator/FirebaseDynamicLinks -F/Users/appPath/build/ios/Debug-iphonesimulator/FirebaseInstallations -F/Users/appPath/build/ios/Debug-iphonesimulator/FirebaseInstanceID -F/Users/appPath/build/ios/Debug-iphonesimulator/FirebaseMessaging -F/Users/appPath/build/ios/Debug-iphonesimulator/FirebaseRemoteConfig -F/Users/appPath/build/ios/Debug-iphonesimulator/GoogleDataTransport -F/Users/appPath/build/ios/Debug-iphonesimulator/GoogleDataTransportCCTSupport -F/Users/appPath/build/ios/Debug-iphonesimulator/GoogleUtilities -F/Users/appPath/build/ios/Debug-iphonesimulator/PromisesObjC -F/Users/appPath/build/ios/Debug-iphonesimulator/Protobuf -F/Users/appPath/build/ios/Debug-iphonesimulator/nanopb -F/Users/appPath/ios/Flutter -F/Users/appPath/ios/Pods/FirebaseAnalytics/Frameworks -F/Users/appPath/ios/Pods/GoogleAppMeasurement/Frameworks -include /Users/appPath/ios/Pods/Target\ Support\ Files/firebase_dynamic_links/firebase_dynamic_links-prefix.pch -MMD -MT dependencies -MF /Users/r.kapshuk/Library/Developer/Xcode/DerivedData/Runner-hdswkbhxyktsyjghzcbbprrekqvs/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/firebase_dynamic_links.build/Objects-normal/x86_64/FLTFirebaseD ynamicLinksPlugin.d --serialize-diagnostics /Users/r.kapshuk/Library/Developer/Xcode/DerivedData/Runner-hdswkbhxyktsyjghzcbbprrekqvs/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/firebase_dynamic_links.build/Objects-normal/x86_64/FLTFirebaseD ynamicLinksPlugin.dia -c /Users/r.kapshuk/.pub-cache/hosted/pub.dartlang.org/firebase_dynamic_links-0.5.0+11/ios/Classes/FLTFirebaseDynamicLinksPlugin.m -o /Users/r.kapshuk/Library/Developer/Xcode/DerivedData/Runner-hdswkbhxyktsyjghzcbbprrekqvs/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/firebase_dynamic_links.build/Objects-normal/x86_64/FLTFirebaseD ynamicLinksPlugin.o Libtool /Users/appPath/build/ios/Debug-iphonesimulator/firebase_dynamic_links/firebase_dynamic_links.framework/firebase_dynamic_links normal x86_64 (in target 'firebase_dynamic_links' from project 'Pods') cd /Users/appPath/ios/Pods export IPHONEOS_DEPLOYMENT_TARGET=8.0 /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/libtool -static -arch_only x86_64 -D -syslibroot /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator13.4.sdk -L/Users/appPath/build/ios/Debug-iphonesimulator/firebase_dynamic_links -filelist /Users/r.kapshuk/Library/Developer/Xcode/DerivedData/Runner-hdswkbhxyktsyjghzcbbprrekqvs/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/firebase_dynamic_links.build/Objects-normal/x86_64/firebase_dyn amic_links.LinkFileList -framework Foundation -dependency_info /Users/r.kapshuk/Library/Developer/Xcode/DerivedData/Runner-hdswkbhxyktsyjghzcbbprrekqvs/Build/Intermediates.noindex/Pods.build/Debug-iphonesimulator/firebase_dynamic_links.build/Objects-normal/x86_64/firebase_dyn amic_links_libtool_dependency_info.dat -o /Users/appPath/build/ios/Debug-iphonesimulator/firebase_dynamic_links/firebase_dynamic_links.framework/firebase_dynamic_links CodeSign /Users/appPath/build/ios/Debug-iphonesimulator/firebase_dynamic_links/firebase_dynamic_links.framework (in target 'firebase_dynamic_links' from project 'Pods') cd /Users/appPath/ios/Pods export CODESIGN_ALLOCATE=/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/codesign_allocate Signing Identity: "-" Any updates? @TahaTesser Have you any plans on this issue? It appears you're using Firebase Dynamic Links native implementation. Please use the firebase_dynamic_links plugin, and if you're still experiencing a problem, please create a new issue. Thanks.	gharchive/issue	2020-05-26T15:27:16	2025-04-01T04:32:33.198044	{ "authors": [ "RomanKapshuk", "TahaTesser", "russellwheatley" ], "repo": "FirebaseExtended/flutterfire", "url": "https://github.com/FirebaseExtended/flutterfire/issues/2637", "license": "BSD-3-Clause", "license_type": "permissive", "license_source": "github-api" }
841715904	[📚] Verify email link and sign in precisions In Verify email link and sign in you write Firebase Authentication uses Firebase Dynamic Links to send the email link to a mobile device. For sign-in completion via mobile application, the application has to be configured to detect the incoming application link, parse the underlying deep link and then complete the sign-in. Follow the setup process for Firebase Dynamic Links on Flutter in this guide. Does it mean that Firebase Dynamic Links should handle the link or that I have to handle it myself? The link I receive in the mail looks like https://myapp.page.link/__/auth/action?apiKey=...&mode=signIn&oobCode=...&continueUrl=https://myapp.com/finishLogin&lang=en and if I click on it, it starts the app but FirebaseDynamicLinks.instance.getInitialLink and FirebaseDynamicLinks.instance.onLink always return null My setup looks like AndroidManifest.xml <intent-filter> <action android:name="android.intent.action.VIEW"/> <category android:name="android.intent.category.DEFAULT"/> <category android:name="android.intent.category.BROWSABLE"/> <data android:host="myapp.page.link" android:scheme="https"/> </intent-filter> main..dart ... @override void initState() { super.initState(); this.initDynamicLinks(); } void initDynamicLinks() async { FirebaseDynamicLinks.instance.onLink( onSuccess: (PendingDynamicLinkData dynamicLink) async { final Uri deepLink = dynamicLink?.link; if (deepLink != null) { print(deepLink); } }, onError: (OnLinkErrorException e) async { print('onLinkError'); print(e.message); }); final PendingDynamicLinkData data = await FirebaseDynamicLinks.instance.getInitialLink(); final Uri deepLink = data?.link; if (deepLink != null) { print(deepLink); } } ... If I add uni_links to the project, I can get the link correctly String initialLink = await getInitialLink(); print(initialLink); Closing in favor of https://github.com/FirebaseExtended/flutterfire/issues/5484	gharchive/issue	2021-03-26T08:29:00	2025-04-01T04:32:33.203783	{ "authors": [ "thomasthiebaud" ], "repo": "FirebaseExtended/flutterfire", "url": "https://github.com/FirebaseExtended/flutterfire/issues/5482", "license": "BSD-3-Clause", "license_type": "permissive", "license_source": "github-api" }
855421831	[📚] Your documentation feedback title (CHANGE ME) Please describe your documentation issue or suggested improvement in detail here and provide links to any pre-existing/relevant documentation and screenshots if necessary: https://github.com/FirebaseExtended/flutterfire/issues/5730	gharchive/issue	2021-04-11T22:21:28	2025-04-01T04:32:33.205129	{ "authors": [ "Duc56789" ], "repo": "FirebaseExtended/flutterfire", "url": "https://github.com/FirebaseExtended/flutterfire/issues/5732", "license": "BSD-3-Clause", "license_type": "permissive", "license_source": "github-api" }
1718624558	🛑 Liga Ardyti is down In 8339379, Liga Ardyti (https://ligaardyti.com.ar) was down: HTTP code: 0 Response time: 0 ms Resolved: Liga Ardyti is back up in adf2701.	gharchive/issue	2023-05-21T20:07:03	2025-04-01T04:32:33.214145	{ "authors": [ "gorositopablo" ], "repo": "FirenzeDigital/upptime", "url": "https://github.com/FirenzeDigital/upptime/issues/519", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
1375015888	🛑 Feast and Fast is down In 5c713f4, Feast and Fast (https://feast-and-fast.fitzmuseum.cam.ac.uk) was down: HTTP code: 0 Response time: 0 ms Resolved: Feast and Fast is back up in bc6da65.	gharchive/issue	2022-09-15T19:58:41	2025-04-01T04:32:33.222283	{ "authors": [ "portableant" ], "repo": "FitzwilliamMuseum/uptime", "url": "https://github.com/FitzwilliamMuseum/uptime/issues/381", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
2454092421	Add amor con hielo by morat Song Name amor con hielo Artist Name morat Source Youtube Youtube Link https://youtu.be/4-cbwT3OHkc?si=5Ks1bhjWEgfSh2Gr Direct File Link https://youtu.be/4-cbwT3OHkc?si=5Ks1bhjWEgfSh2Gr Song ID 696770 Start Offset [ms] 12 Extra Created from Auto Nong. Created for level: 53858796 reject popular songs are too inconvenient to be replaced by smth unrelated and are therefore usually rejected. Note that you can still use the song yourself, but it won't be public plus the id and song dont match	gharchive/issue	2024-08-07T18:35:29	2025-04-01T04:32:33.225398	{ "authors": [ "Lopolo11BA", "SpuckwasserDE" ], "repo": "FlafyDev/auto-nong-indexes", "url": "https://github.com/FlafyDev/auto-nong-indexes/issues/2523", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
1854914207	请问在云服务器中报错 104 是什么问题，本地执行是ok的，是网络配置有问题吗？ Traceback (most recent call last): File "/repo/app.py", line 7, in model = FlagModel('BAAI/bge-large-zh', query_instruction_for_retrieval="为这个句子生成表示以用于检索相关文章：") ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/FlagEmbedding/baai_general_embedding/flag_models.py", line 18, in init self.model = AutoModel.from_pretrained(model_name_or_path) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/transformers/models/auto/auto_factory.py", line 493, in from_pretrained return model_class.from_pretrained( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/transformers/modeling_utils.py", line 2539, in from_pretrained resolved_archive_file = cached_file( ^^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/transformers/utils/hub.py", line 417, in cached_file resolved_file = hf_hub_download( ^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/huggingface_hub/utils/_validators.py", line 118, in _inner_fn return fn(args, kwargs) ^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/huggingface_hub/file_download.py", line 1364, in hf_hub_download http_get( File "/usr/local/lib/python3.11/site-packages/huggingface_hub/file_download.py", line 505, in http_get r = _request_wrapper( ^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/huggingface_hub/file_download.py", line 442, in _request_wrapper return http_backoff( ^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/huggingface_hub/utils/_http.py", line 258, in http_backoff response = session.request(method=method, url=url, kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/requests/sessions.py", line 589, in request resp = self.send(prep, send_kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/requests/sessions.py", line 703, in send r = adapter.send(request, kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/huggingface_hub/utils/_http.py", line 63, in send return super().send(request, args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.11/site-packages/requests/adapters.py", line 501, in send raise ConnectionError(err, request=request) requests.exceptions.ConnectionError: (ProtocolError('Connection aborted.', ConnectionResetError(104, 'Connection reset by peer')), '(Request ID: 4fdd90d4-fed9-44c7-8cf3-1cb8d1c56c6a)') 您好，应该是网络问题，您可以把模型下载好，传到服务器上，让服务器之间从下载好的文件里加载模型。	gharchive/issue	2023-08-17T12:33:33	2025-04-01T04:32:33.236040	{ "authors": [ "hduyyg", "staoxiao" ], "repo": "FlagOpen/FlagEmbedding", "url": "https://github.com/FlagOpen/FlagEmbedding/issues/44", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
2162715589	bge m3混合检索请问该如何把三种检索混合在一起使用？我们实验中使用的是faiss + pyserini: https://github.com/FlagOpen/FlagEmbedding/tree/master/C_MTEB/MLDR#hybrid-retrieval-dense--sparse 社区中有一些实现：vespa 我们实验中使用的是faiss + pyserini: https://github.com/FlagOpen/FlagEmbedding/tree/master/C_MTEB/MLDR#hybrid-retrieval-dense--sparse 社区中有一些实现：vespa 请问如果想用混合检索去测试mteb应该怎么做	gharchive/issue	2024-03-01T06:38:36	2025-04-01T04:32:33.239161	{ "authors": [ "staoxiao", "sunzx8" ], "repo": "FlagOpen/FlagEmbedding", "url": "https://github.com/FlagOpen/FlagEmbedding/issues/510", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
1209801070	Consider using HTTP keep-alive in fetch calls I noticed in https://github.com/Flagsmith/flagsmith-nodejs-client/blob/main/flagsmith-core.js that no custom agent with keep-alive is configured. I believe this means that (despite always connecting to the same host) with every fetch call, a DNS lookup is done, a connection is opened, and a TLS handshake is performed. It might be worth considering implementing this for improved performance of the SDK. @kyle-ssg we were also thinking it might be possible to do either DNS pre-fetching or SSL warming as well if the HTTP client allows it I should add there may be considerations here in the infrastructure side. You might want to consider your idle timeouts and the maximum number of connections your web-server has configured. Understood RE keep-alive. @kyle-ssg we were also thinking it might be possible to do either DNS pre-fetching or SSL warming as well if the HTTP client allows it I'd imagine people would construct an instance of Flagsmith outside of requests/functions. With that being the case, wouldn't that already be essentially done as part of the first request in local evaluation? I should add there may be considerations here in the infrastructure side. You might want to consider your idle timeouts and the maximum number of connections your web-server has configured. Considering this, what do we thing about adding an optional agent as part of the Flagsmith class properties. Example: const agentOptions: AgentOptions = { keepAlive: true, keepAliveMsecs: 6000 }; const httpAgent = new http.Agent(agentOptions); const httpsAgent = new https.Agent(agentOptions); const agent = (_parsedURL:URL) => _parsedURL.protocol == 'http:' ? httpAgent : httpsAgent; .... const flagsmith = new Flagsmith({ environmentKey, agent, ... }); I did the latter but realised actually the ability to supply a custom agent would allow for proxy support, so I think we'll go with that. const agent = require('https-proxy-agent'); const flagsmith = new Flagsmith({ environmentKey, agent, ... }); https://github.com/Flagsmith/flagsmith-nodejs-client/blob/main/examples/custom-fetch-agent/src/api/index.js	gharchive/issue	2022-04-20T14:49:27	2025-04-01T04:32:33.243931	{ "authors": [ "dabeeeenster", "kyle-ssg", "toddbaert" ], "repo": "Flagsmith/flagsmith-nodejs-client", "url": "https://github.com/Flagsmith/flagsmith-nodejs-client/issues/29", "license": "BSD-3-Clause", "license_type": "permissive", "license_source": "github-api" }
2285652142	fix: Validate if the GitHub installation is valid Thanks for submitting a PR! Please check the boxes below: [x] I have run pre-commit to check linting [x] I have added information to docs/ if required so people know about the feature! [x] I have filled in the "Changes" section below? [x] I have filled in the "How did you test this code" section below? [x] I have used a Conventional Commit title for this Pull Request Changes Add an infoMessage if the GitHub installation is invalid. Add the option to update the installation id or delete the integration, if it is invalid. Correct issue when try link a GitHub PR. Add extra logic in the GitHubSetupPage How did you test this code? Create an integration with GH in the Flagsmith App. Uninstall the app in GitHub Go to integration option in the side menu -> GitHub Integration -> Manage integration Reading through the purpose of this PR, I just want to make sure this is the best solution. There must be a way to handle this without UI? E.g. Do GitHub Apps have WebHooks that detect uninstall ? If so we could invalidate the installation ID then Is there a way to get a GH installation ID ? If so we could attempt to fetch it and invalidate if it doesnt exist Reading through the purpose of this PR, I just want to make sure this is the best solution. There must be a way to handle this without UI? E.g. Do GitHub Apps have WebHooks that detect uninstall ? If so we could invalidate the installation ID Is there a way to get a GH installation ID ? If so we could attempt to fetch it and invalidate if it doesnt exist How does e.g. Vercel handle this ? Am I right in saying we could just subscribe to this https://docs.github.com/en/webhooks/webhook-events-and-payloads#github_app_authorization Yes, that is the plan but it was not part of the scope of this first version. However, maybe it is worth it to implement the webhook instead of this. Please let's discuss. Do GitHub Apps have WebHooks that detect uninstall ? If so we could invalidate the installation ID Yep, Is there a way to get a GH installation ID ? If so we could attempt to fetch it and invalidate if it doesnt exist How does e.g. Vercel handle this ? Am I right in saying we could just subscribe to this https://docs.github.com/en/webhooks/webhook-events-and-payloads#github_app_authorization	gharchive/pull-request	2024-05-08T13:47:44	2025-04-01T04:32:33.252445	{ "authors": [ "kyle-ssg", "novakzaballa" ], "repo": "Flagsmith/flagsmith", "url": "https://github.com/Flagsmith/flagsmith/pull/3899", "license": "BSD-3-Clause", "license_type": "permissive", "license_source": "github-api" }
2650063649	Patch: Fixing an error in last PR Removing the 'setIcon' function as it doesn't work in buttons — it just removes the text. Sorry for the mistake! EDIT: Unsure why it has listed all the other commits I made in the other PR. It's just removing the one line Thanks	gharchive/pull-request	2024-11-11T18:28:25	2025-04-01T04:32:33.315199	{ "authors": [ "Fleker", "JCGithu" ], "repo": "Fleker/letterboxd-for-obsidian", "url": "https://github.com/Fleker/letterboxd-for-obsidian/pull/4", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
1199086492	First version of Dockerfile & docker-compose Closes #149. This PR also includes a health check in the FM API (#213) Pull Request Test Coverage Report for Build 2144437070 13 of 30 (43.33%) changed or added relevant lines in 3 files are covered. No unchanged relevant lines lost coverage. Overall coverage decreased (-0.06%) to 68.507% Changes Missing Coverage Covered Lines Changed/Added Lines % flexmeasures/cli/data_add.py 0 7 0.0% flexmeasures/api/v3_0/health.py 11 21 52.38% Totals Change from base Build 2143298525: -0.06% Covered Lines: 7047 Relevant Lines: 9759 💛 - Coveralls @Flix6x Not sure how far your review / testing went. I'm done with the documentation changes, and I have tested the toy tutorial done only in Docker. The last thing I'm trying to accomplish is to move the Docker image to lfenergy/flexmeasures (right now we have our own repository, flexmeasures/fkexmeasures). This hinges on getting the repo set up in the existing lfenergy Docker organisation. I'm on it.	gharchive/pull-request	2022-04-10T16:10:29	2025-04-01T04:32:33.322819	{ "authors": [ "coveralls", "nhoening" ], "repo": "FlexMeasures/flexmeasures", "url": "https://github.com/FlexMeasures/flexmeasures/pull/416", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
154854120	Windows VS2015: Python 3.x compile errors I have tried Python 3.1, 3.2, 3.3, 3.4 and 3.5 and none of them work. Also tried IronPython and regular python launcher. Tried cleaning the project and building again. Understand that this "build" folder is probably special for Visual Studio. Does anyone know why the below are happening? Are they legitimate errors? Issue 1 invalid syntax D:\G\Flexget\build\lib\flexget\plugins\output\memusage.py (Line: 52) ... from ... print 'Resource Module memory usage: %s (kb)' % resource.getrusage(resource.RUSAGE_SELF).ru_maxrss ... in Flexget\build\lib\flexget\plugins\output\memusage.py Issue 2 (Happens in 2 places) ", variable" not allowed in 3.x - use "as variable" instead. (Line 55 & Line 69) ... from ... except re.error, e: ... in Flexget\build\lib\flexget\plugins\modify\regex_extract.py Those lines are from old code, and have since been updated. Only flexget 2.0+ is python 3 compatible. @gazpachoking When will the old code be purged from the repo?	gharchive/issue	2016-05-14T13:38:45	2025-04-01T04:32:33.327950	{ "authors": [ "gazpachoking", "qvazzler" ], "repo": "Flexget/Flexget", "url": "https://github.com/Flexget/Flexget/issues/1170", "license": "mit", "license_type": "permissive", "license_source": "bigquery" }
2512516099	🛑 Flingchat is down In d5d6d11, Flingchat (https://chat.glowberry.xyz) was down: HTTP code: 0 Response time: 0 ms Resolved: Flingchat is back up in f5a6474 after 8 minutes.	gharchive/issue	2024-09-08T18:32:16	2025-04-01T04:32:33.334507	{ "authors": [ "FlingisenFlong" ], "repo": "FlingisenFlong/flingchat-uptime", "url": "https://github.com/FlingisenFlong/flingchat-uptime/issues/26", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
2051789953	Output MP4 error... The Process runs, however when complete there is a black screen in the wrong aspect-ratio and the vid won't playback. I am able to successfully download the Densepose mp4, but the colors are different... (black background instead of purple) It appears that this may be the reason the files don't work in MagicAnimate. Here, are the final error lines: 2023-12-21T06:04:16.163237110Z /home/user/.local/lib/python3.10/site-packages/torch/functional.py:504: UserWarning: torch.meshgrid: in an upcoming release, it will be required to pass the indexing argument. (Triggered internally at ../aten/src/ATen/native/TensorShape.cpp:3526.) 2023-12-21T06:04:16.163286514Z return _VF.meshgrid(tensors, **kwargs) # type: ignore[attr-defined] 2023-12-21T06:07:27.810333894Z /home/user/.local/lib/python3.10/site-packages/gradio/components/video.py:274: UserWarning: Video does not have browser-compatible container or codec. Converting to mp4 2023-12-21T06:07:27.810384571Z warnings.warn( Please advise, Thanks. Did you solve this problem? same problem :( Unfortunately, no. Any suggestions? You might be using an old commit version, the output now is purple.	gharchive/issue	2023-12-21T06:36:57	2025-04-01T04:32:33.345374	{ "authors": [ "Aleon3", "ChanYeongShin", "igorriti" ], "repo": "Flode-Labs/vid2densepose", "url": "https://github.com/Flode-Labs/vid2densepose/issues/21", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
686498038	Build successful, installation complete, but I get fatal error: tensorflow/core/platform/env.h: No such file or directory when I try to build the example code. I am building this in Ubuntu 18.04. I Had same error Can you provide the exact output in order to see the source of the error? Btw it should work on ubuntu 20.04 as it passes in the CI. Same error in Ubuntu 18.04 while building TF 2.3.1. My work around: because "env.h" is in bazel-bin/bin folder, therefore add 2 more lines in /usr/local/lib/cmake/TensorflowCC/TensorflowCCTargets.cmake: set_target_properties(TensorflowCC::TensorflowCC PROPERTIES INTERFACE_COMPILE_FEATURES "cxx_std_11" INTERFACE_INCLUDE_DIRECTORIES "/usr/local/include/tensorflow/bazel-bin/tensorflow/include;/usr/local/include/tensorflow/bazel-bin/tensorflow/include/src;/usr/local/include/tensorflow/bazel-bin/bin/tensorflow/include;/usr/local/include/tensorflow/bazel-bin/bin/tensorflow/include/src" INTERFACE_LINK_LIBRARIES "/usr/local/lib/libtensorflow_cc.so.2;dl;pthread" ) What is your Bazel version? I used bazel version 3.1.0 as recommendation of tensorflow : https://www.tensorflow.org/install/source#gpu	gharchive/issue	2020-08-26T17:36:37	2025-04-01T04:32:33.354530	{ "authors": [ "FloopCZ", "Yasin40", "michaelnguyen11", "ranjanisubramanyan" ], "repo": "FloopCZ/tensorflow_cc", "url": "https://github.com/FloopCZ/tensorflow_cc/issues/237", "license": "mit", "license_type": "permissive", "license_source": "bigquery" }
2229965849	Visual conflict between Iconize and Task plugin's todo tag Describe the bug Applying iconize with "toggle icons while editing notes" interferes with "Tasks" plugin's #task filter (common for those who use tasks plugin) To Reproduce Steps to reproduce the behavior: Have "Tasks", "Checklist", and "Iconize" community plugins installed. Turn on "Toggle icons while editing notes". Create a checkbox followed by a tag - [ ] #todo (commonly used as a Global task filter) while in editing mode See result. Expected behavior Tag should remain visibly present. Error disappears if "Toggle icons while editing notes" is turned off, which suggests that iconize detects tags following checkboxes as icons? Error is also only present in live preview, and not editing mode. Screenshots Additional information Obsidian version: 1.5.12 Checklist version: 2.2.13 Tasks version: 6.2.0 Iconize version: 2.11.7 this might be fixed in v2.11.9	gharchive/issue	2024-04-07T21:24:22	2025-04-01T04:32:33.359355	{ "authors": [ "ArgensVentus", "FlorianWoelki" ], "repo": "FlorianWoelki/obsidian-iconize", "url": "https://github.com/FlorianWoelki/obsidian-iconize/issues/431", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
200363638	Contiki lwm2m fails to register to the AwaLwM2M server Hi, I'm trying connect a contiki device to the AwaLwM2M server but the server respond with a "4.00 Bad request" message to the registration: [DEBUG] [network_abstraction_linux.c:410] Address add (received) [DEBUG] [coap_abstraction_erbium.c:236] Coap POST for /rd [DEBUG] [lwm2m_registration.c:418] Lwm2m_RegisterPost /rd ?ep=SmartSensor4B00063A7631 [DEBUG] [coap_abstraction_erbium.c:265] Coap Response code 400 Wireshark sniffer packet: I start the server as follow: $ ./awa_serverd -f 6 -a bbbb::10 _ _ __ __ ____ __ __ / \__ ____ _ \| \| __ _\| \/ \|___ \\| \/ \| / _ \ \ /\ / / _` \| \| \| \ \ /\ / / \|\/\| \| __) \| \|\/\| \| / ___ \ V V / (_\| \| \| \|__\ V V /\| \| \| \|/ __/\| \| \| \| /_/ \_\_/\_/ \__,_\| \|_____\_/\_/ \|_\| \|_\|_____\|_\| \|_\| Copyright (C) 2016, Imagination Technologies Limited. [INFO] Awa LWM2M Server, version 0.2.4 [INFO] Process ID : 5902 [INFO] DTLS library : None [INFO] CoAP library : Erbium [INFO] CoAP port : 5683 [INFO] CoAP Security : None [INFO] IPC port : 54321 [INFO] IP Address : bbbb::10 [INFO] Bind port: 5683 The Awa LwM2M client connects successfully to the server: $ ./awa_clientd --port 6000 -a 6 --endPointName client1 -f bootstrap.conf _ _ __ __ ____ __ __ / \__ ____ _ \| \| __ _\| \/ \|___ \\| \/ \| / _ \ \ /\ / / _` \| \| \| \ \ /\ / / \|\/\| \| __) \| \|\/\| \| / ___ \ V V / (_\| \| \| \|__\ V V /\| \| \| \|/ __/\| \| \| \| /_/ \_\_/\_/ \__,_\| \|_____\_/\_/ \|_\| \|_\|_____\|_\| \|_\| Copyright (C) 2016, Imagination Technologies Limited. [INFO] Awa LWM2M Client, version 0.2.4 [INFO] Process ID : 6527 [INFO] Endpoint name : 'client1' [INFO] DTLS library : None [INFO] CoAP library : Erbium [INFO] CoAP port : 6000 [INFO] IPC port : 12345 [INFO] Address family : IPv6 [INFO] Bind port: 6000 [INFO] Factory Bootstrap: [INFO] Server Configuration [INFO] ==================== [INFO] ServerURI : coap://[bbbb::10]:5683 [INFO] SecurityMode : 0 [INFO] SecretKey : [INFO] PublicKey : [INFO] ServerID : 1 [INFO] HoldOffTime : 30 [INFO] ShortServerID : 1 [INFO] Binding : U [INFO] LifeTime : 30 [INFO] DisableTimeout : 86400 [INFO] DefaultMinimumPeriod : 1 [INFO] DefaultMaximumPeriod : -1 [INFO] NotificationStoringWhenDisabledOrOffline : 1 [INFO] Register with coap://[bbbb::10]:5683 [INFO] Coap request: coap://[bbbb::10]:5683/rd?ep=client1&lt=30&b=U [INFO] Registered with [bbbb::10]:5683 [INFO] Coap request: coap://[bbbb::10]:5683/rd/2?lt=30&b=U My contiki device connects to a leshan server without problem on the same machine and I can interact with it through the leshan web interface. java -jar leshan-server-demo.jar I'm new to the lwM2M protocol. I couldn't actually understand why that doesn't work with the AwaLwM2M server. I don't know how to debug this furthermore. I'd love to test the Awa LwM2M server with my devices. Thanks a lot for your help. I figured it out. The Content-Format option application/link-format must be included in the coap message from the Contiki device. This is a contiki related problem.	gharchive/issue	2017-01-12T13:13:56	2025-04-01T04:32:33.391894	{ "authors": [ "darkopetrovic" ], "repo": "FlowM2M/AwaLWM2M", "url": "https://github.com/FlowM2M/AwaLWM2M/issues/329", "license": "bsd-3-clause", "license_type": "permissive", "license_source": "bigquery" }
2204280448	How to add qr code and image recognition in flowise with audio conversation I am building a Chatbot that recognize qr code to detect user current location and recognize image to provide what object it is. Also I want to use coqui tts streaming for realtime conversation between bot and user. Guide me regarding it. It will be helpful if any expert guide me stepwise and connect with on zoom today. any update?	gharchive/issue	2024-03-24T10:19:07	2025-04-01T04:32:33.393525	{ "authors": [ "ahsan3219" ], "repo": "FlowiseAI/Flowise", "url": "https://github.com/FlowiseAI/Flowise/issues/2027", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
239480843	Quests not saved. My quests are not saved to the server or plugin reload.. I love this plugin and would really like to use it on my server. A solution ? There is no error in the console... My server is in 1.11.2 What is your Quests version and can you describe this in greater detail? Closing due to lack of response from OP. If this problem persists through Quests v2.8.7, please create a new issue with the requested information. Thanks!	gharchive/issue	2017-06-29T13:34:47	2025-04-01T04:32:33.464891	{ "authors": [ "BlueFoxx", "FlyingPikachu" ], "repo": "FlyingPikachu/Quests", "url": "https://github.com/FlyingPikachu/Quests/issues/21", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
2746305532	🛑 Backend Mercado Pago Foca is down In b621707, Backend Mercado Pago Foca (http://mp.focasoftware.com/webservices/testFront) was down: HTTP code: 0 Response time: 0 ms Resolved: Backend Mercado Pago Foca is back up in 4064673 after 25 minutes.	gharchive/issue	2024-12-17T23:13:21	2025-04-01T04:32:33.490657	{ "authors": [ "ArielGQ" ], "repo": "Foca-Software/status", "url": "https://github.com/Foca-Software/status/issues/1278", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
157187863	SSH port number not taken into account Hello, I run my SSH server on a non-standard port (ie: NOT TCP-22). When I specify the proper network port in the GUI, I can see the following happening in Wireshark (connecting through an HTTP proxy): CONNECT remote.host.com:22 HTTP/1.0 So the connection can't be established... Rgds, Arno make sure you click "save" before you connect :D I did. Same issue. I too am having the same issue I'm using sshfs with this configuration, and I notice that I was not able to reproduce this issue. The SSH server on my linux box is running on a custom port 129. I don't think this is possible becaouse we are using nonstandard ports since the first version here. Maybe this is some specific problem, but description of issue lacks enough informations. Actually this can be gui bug.	gharchive/issue	2016-05-27T11:36:17	2025-04-01T04:32:33.505113	{ "authors": [ "Arno0x", "dimov-cz", "habdulkafi", "juj", "wUFr" ], "repo": "Foreveryone-cz/win-sshfs", "url": "https://github.com/Foreveryone-cz/win-sshfs/issues/91", "license": "BSD-3-Clause", "license_type": "permissive", "license_source": "github-api" }
413058032	updates jest-environment-jsdom to 24.0.0 to fix audit issue https://nodesecurity.io/advisories/786 issue #295 Closing in favor of #297. Thank you for your contributions!	gharchive/pull-request	2019-02-21T18:14:26	2025-04-01T04:32:33.520341	{ "authors": [ "blainekasten", "marplemr", "tgaff" ], "repo": "FormidableLabs/enzyme-matchers", "url": "https://github.com/FormidableLabs/enzyme-matchers/pull/296", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
2198288131	armor stand bug Armorstand doesn't jump and can't be broken Fixed in 1.0.7	gharchive/issue	2024-03-20T18:40:36	2025-04-01T04:32:33.583665	{ "authors": [ "ForwarD-NerN", "arkksu" ], "repo": "ForwarD-NerN/AntiShadowPatch", "url": "https://github.com/ForwarD-NerN/AntiShadowPatch/issues/6", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
2242305295	[REQUEST] Adjust volume with scroll wheel Currently, we need to click the app to adjust the volume. It would be nice to quickly adjust the volume with the mouse scroll by hovering over the volume icon, similar to YouTube Music, with 1% increments if possible. This is useful because you don't need to focus/tab out of the current window to adjust the volume (some applications minimize/pause themselves when they lose focus). We have to see if this is possible when the focus is currently not on the players main window. (I don't know if the events for that trigger properly when its not in focus) I'll will test a bit around with it tomorrow	gharchive/issue	2024-04-14T18:38:26	2025-04-01T04:32:33.597766	{ "authors": [ "Founntain", "InitialDet" ], "repo": "Founntain/osuplayer", "url": "https://github.com/Founntain/osuplayer/issues/270", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
1213268971	Motherboard CAD Reference Hi, please release the cad model of the motherboard with the overall dimensions and fixing points. Ty Available here: https://github.com/FrameworkComputer/Mainboard/tree/main/Mechanical/2D	gharchive/issue	2022-04-23T10:45:31	2025-04-01T04:32:33.652188	{ "authors": [ "ale-nh", "eclecticc" ], "repo": "FrameworkComputer/Mainboard", "url": "https://github.com/FrameworkComputer/Mainboard/issues/3", "license": "CC-BY-4.0", "license_type": "permissive", "license_source": "github-api" }
1446971145	[FEATURE] Improve the video section #355 Working on possibility to embed multiple videos on the page. Files included: content/videos.json components/GetVideos.js Working: Include multiple videoIds in content/videos.json in json format and all the videos will be available in the Video section of the site Good job @AnvaySingh!!	gharchive/pull-request	2022-11-13T15:33:40	2025-04-01T04:32:33.669015	{ "authors": [ "AnvaySingh", "tobySolutions" ], "repo": "FrancescoXX/4c-site", "url": "https://github.com/FrancescoXX/4c-site/pull/378", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
1837005351	Algolia integration Add Algolia integration https://docusaurus.io/docs/search upddate: Algolia request sent. waiting for response(it usually takes around a week) done	gharchive/issue	2023-08-04T15:59:36	2025-04-01T04:32:33.670657	{ "authors": [ "FrancescoXX" ], "repo": "FrancescoXX/contentbox", "url": "https://github.com/FrancescoXX/contentbox/issues/11", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
815386907	Php file in place of Vue file Hello, First thanks for this great tool. My problem. I just want to use a .php file in place of a .vue file into the loadModule function but it's not working. it told me : "TypeError: Unable to handle .php files (js/vue/components/hello_world/test.php), see additionalModuleHandlers" i'v try to add in config: additionalModuleHandlers: { '.php': function(source, path, options) { return source; } } But it's not working at all. May be i'm doing some wrong ? Thanks Hi shaan1974, To handle this situation, your getFile() should inform vue3-sfc-loader that these .php files generate .vue content : async getFile(url) { const res = await fetch(url); if ( !res.ok ) throw Object.assign(new Error(url + " " + res.statusText), { res }); const content = await res.text(); return /\/vue\/components\/.?\.php/.test(url) ? { content: content, extname: ".vue" } : content; }, Think extname like a kind of mimetype. Here we tell vue3-sfc-loader that vue/components//.php generate SFC content. Thanks a lot for you help you save my live ;) By the way nice job, because i'm not a big fan of Cli tools. I'm closing this as answered. Discussion can continue if needed.	gharchive/issue	2021-02-24T11:25:34	2025-04-01T04:32:33.677985	{ "authors": [ "FranckFreiburger", "shaan1974" ], "repo": "FranckFreiburger/vue3-sfc-loader", "url": "https://github.com/FranckFreiburger/vue3-sfc-loader/issues/22", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
696119254	Creation of MariaDB container fails if db/container name contains a dash Repo: Click on menu item to create a new MariaDB container In DB/Container name field use a name with a dash. For example "test-database" In DB Username field enter a username In DB Password field enter a password Complete other required fields in the database Hit the Submit button What should happen: A new database container is created with the name entered in 2) above. Using the username and password entered above you should be able to access it with a command similar to mysql --host mydb --port 32246 --user test-database --password What happens: A new database container is created with the name entered in 2) above. Using the username and password entered above you are unable to login. You see a message similar to mysql --host mydb --port 32246 --user testuser --password Enter password: ERROR 1045 (28000): Access denied for user 'testuser'@'rhino02.fhcrc.org' (using password: YES) After debugging the problem on the db4sci server, I was able to determine the problem is with the password. The DB container is created correctly. The DB is created correctly and the user is created, however the password does not work. When the password is changed, the user is able to access the DB. I mentioned in another issue that dashes are not allowed in mysql/mariadb database names. So the real issue is that mydb is not doing the proper validation/error handling to prevent names with dashes from being used. Actually, I am having trouble finding a reference for my statement above (that dashes are not allowed in database names). I wonder if the dash throws off the parsing of the command line so that it interprets some other argument as the password....	gharchive/issue	2020-09-08T19:25:02	2025-04-01T04:32:33.683023	{ "authors": [ "bdconnolly", "dtenenba" ], "repo": "FredHutch/DB4SCI", "url": "https://github.com/FredHutch/DB4SCI/issues/9", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
158859139	Link to External Pages with Anchor Elements THIS IS MY CODE CatPhotoApp Kitty ipsum dolor sit amet, shed everywhere shed everywhere stretching attack your ankles chase the red dot, hairball run catnip eat the grass sniff. Purr jump eat the grass rip the couch scratched sunbathe, shed everywhere rip the couch sleep in the sink fluffy fur catnip scratched. @naeemsattar thanks for the issue but GitHub is not a place for coding help. If you get stuck with a challenge, please first ask questions to the Help Room. Happy coding!	gharchive/issue	2016-06-07T07:42:19	2025-04-01T04:32:33.768755	{ "authors": [ "erictleung", "naeemsattar" ], "repo": "FreeCodeCamp/FreeCodeCamp", "url": "https://github.com/FreeCodeCamp/FreeCodeCamp/issues/9004", "license": "BSD-3-Clause", "license_type": "permissive", "license_source": "github-api" }
167406671	???? Challenge Link to External Pages with Anchor Elements has an issue. User Agent is: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.103 Safari/537.36. Please describe how to reproduce this issue, and include links to screenshots if possible. My code: <link href="https://fonts.googleapis.com/css?family=Lobster" rel="stylesheet" type="text/css"> <style> .red-text { color: red; } h2 { font-family: Lobster, Monospace; } p { font-size: 16px; font-family: Monospace; } .thick-green-border { border-color: green; border-width: 10px; border-style: solid; border-radius: 50%; } .smaller-image { width: 100px; } </style> <h2 class="red-text">CatPhotoApp</h2> <img class="smaller-image thick-green-border" src="https://bit.ly/fcc-relaxing-cat"> <p class="red-text">Kitty ipsum dolor sit amet, shed everywhere shed everywhere stretching attack your ankles chase the red dot, hairball run catnip eat the grass sniff.</p> <p class="red-text">Purr jump eat the grass rip the couch scratched sunbathe, shed everywhere rip the couch sleep in the sink fluffy fur catnip scratched.</p> <p><a href='http://freecatphotoapp.com'> cat photos</a></p> @amelianstars GitHub Issues are not for coding help. Kindly do not post anymore issues unless you find one, please visit the Help Chat Room for any assistance to code.	gharchive/issue	2016-07-25T16:17:27	2025-04-01T04:32:33.773361	{ "authors": [ "amelianstars", "raisedadead" ], "repo": "FreeCodeCamp/FreeCodeCamp", "url": "https://github.com/FreeCodeCamp/FreeCodeCamp/issues/9882", "license": "BSD-3-Clause", "license_type": "permissive", "license_source": "github-api" }
187531655	Chore: react-router/history versions Pre-Submission Checklist [x] Your pull request targets the staging branch of FreeCodeCamp. [x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue) [x] You have only one commit (if not, squash them into one commit). [x] All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes. Type of Change [x] Small bug fix (non-breaking change which fixes an issue) [ ] New feature (non-breaking change which adds new functionality) [ ] Breaking change (fix or feature that would change existing functionality) [ ] Add new translation (feature adding new translations) Checklist: [x] Tested changes locally. [ ] Closes currently open issue (replace XXXX with an issue no): Closes #XXXX Description Resolved conflicts for react-router v3.0.0, #11361 refers. react-router does not support history@4., so I have updated to history@3. react-router-redux just released v4.0.7 so solve an issue with react-router/history v3, so I have updated that also. Thanks for looking into this 👍	gharchive/pull-request	2016-11-05T23:49:42	2025-04-01T04:32:33.779095	{ "authors": [ "BerkeleyTrue", "Bouncey" ], "repo": "FreeCodeCamp/FreeCodeCamp", "url": "https://github.com/FreeCodeCamp/FreeCodeCamp/pull/11538", "license": "BSD-3-Clause", "license_type": "permissive", "license_source": "github-api" }
59363391	Ouath Login Sessions are now supported but the User isn't being saved to the database. Closing this issue as oauth now works. The much larger job remains of migrating user profile.	gharchive/issue	2015-02-28T22:47:09	2025-04-01T04:32:33.780101	{ "authors": [ "terakilobyte" ], "repo": "FreeCodeCamp/freecodecamp", "url": "https://github.com/FreeCodeCamp/freecodecamp/issues/133", "license": "BSD-3-Clause", "license_type": "permissive", "license_source": "github-api" }
68339447	transport: added function to get bytes written added function to get written bytes on transport. This is needed to get a more accurate bandwidth management. +1	gharchive/pull-request	2015-04-14T10:58:40	2025-04-01T04:32:33.786677	{ "authors": [ "MartinHaimberger", "bmiklautz" ], "repo": "FreeRDP/FreeRDP", "url": "https://github.com/FreeRDP/FreeRDP/pull/2538", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }
801725664	Eliminate 1861 Freecen2 Pieces for London These were not enumerations The pieces were removed Thank you @Captainkirkdawson , closing	gharchive/issue	2021-02-04T23:58:00	2025-04-01T04:32:33.798780	{ "authors": [ "Captainkirkdawson", "PatReynolds" ], "repo": "FreeUKGen/FreeCENMigration", "url": "https://github.com/FreeUKGen/FreeCENMigration/issues/1132", "license": "apache-2.0", "license_type": "permissive", "license_source": "bigquery" }
2554029880	307406684 Prevalidation N/A (Cheryl) Issue reported by Cheggs at 2024-09-27 22:44:44 UTC Time: 2024-09-27T22:35:27+00:00 Session ID: 2b9bf58fb48b14a707c7d3546b352098 Problem Page URL: /manage_counties/select_action?locale=en Previous Page URL: https://www.freecen.org.uk/manage_counties/new?locale=en Reported Issue: I have been doing prevalidation of 1861 POB for LAN for Geoff Jarvis. Yesterday when I went to the list of pieces I saw “prevalidation N/A” and “Man validation N/A” so could not proceed. I checked the lists for a few other counties and their lists were the same. Could someone pls have a look at this. Thanks. Cheryl Meggers. chemeggs@yahoo.com,au Old code was inadvertently deployed to Production and this caused an issue with the CSV Upload/processing of a CSV file that had commenced Validation. I reverted the appropriate code and also reverted the code that was disabling VLD Pre-Validaton which had been implemented in an attempt to resolve the issue but I believe there are not actually issues with VLD Pre-processing. I have tested on Test3 - seems OK. I believe this is ready for Deployment to Production now. DEployed	gharchive/issue	2024-09-28T06:02:07	2025-04-01T04:32:33.802906	{ "authors": [ "AnneV-Learn", "FreeREGcomputer", "Vino-S" ], "repo": "FreeUKGen/FreeCENMigration", "url": "https://github.com/FreeUKGen/FreeCENMigration/issues/1811", "license": "apache-2.0", "license_type": "permissive", "license_source": "bigquery" }
2159587744	Update talker_bloc_logger README.md Thanks a lot for contributing! Provide a description of your changes below Codecov Report All modified and coverable lines are covered by tests :white_check_mark: Project coverage is 100.00%. Comparing base (bc3453f) to head (a97b6bc). :exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files @@ Coverage Diff @@ ## master #195 +/- ## =========================================== + Coverage 99.53% 100.00% +0.46% =========================================== Files 11 3 -8 Lines 213 98 -115 =========================================== - Hits 212 98 -114 + Misses 1 0 -1 :umbrella: View full report in Codecov by Sentry. :loudspeaker: Have feedback on the report? Share it here.	gharchive/pull-request	2024-02-28T18:28:50	2025-04-01T04:32:33.901232	{ "authors": [ "MiladAtef", "codecov-commenter" ], "repo": "Frezyx/talker", "url": "https://github.com/Frezyx/talker/pull/195", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
1510258520	🛑 API (AppWrite) Sekretariat-DJPb is down In 30cc521, API (AppWrite) Sekretariat-DJPb (https://appwrite.setditjen-djpb.net) was down: HTTP code: 0 Response time: 0 ms Resolved: API (AppWrite) Sekretariat-DJPb is back up in 5714030.	gharchive/issue	2022-12-25T06:26:11	2025-04-01T04:32:33.905434	{ "authors": [ "FrideyAlpha" ], "repo": "FrideyAlpha/uptime-setditjen", "url": "https://github.com/FrideyAlpha/uptime-setditjen/issues/992", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
228572338	[WIP] AssertTokens Trait D:\GIT\fork\PHP-CS-Fixer (2.x_assertTokens) λ vendor\bin\phpunit tests\Tokenizer\TokensTest.php PHPUnit 5.7.19 by Sebastian Bergmann and contributors. Testing PhpCsFixer\Tests\Tokenizer\TokensTest ................................................................. 65 / 87 ( 74%) .........S.....FFF.FFF 87 / 87 (100%) Time: 514 ms, Memory: 4.00MB There were 6 failures: 1) PhpCsFixer\Tests\Tokenizer\TokensTest::testEnsureWhitespaceAtIndex with data set #0 ('<?php ', '<?php', 0, 1, ' ') The token at index 0 must be: { "id": 379, "name": "T_OPEN_TAG", "content": "<?php ", "isArray": true, "changed": false }, got: { "id": 321, "name": "T_INLINE_HTML", "content": "<?php", "isArray": true, "changed": false }. Failed asserting that false is true. D:\GIT\fork\PHP-CS-Fixer\src\Test\Assert\AssertTokensTrait.php:33 D:\GIT\fork\PHP-CS-Fixer\tests\Tokenizer\TokensTest.php:879 2) PhpCsFixer\Tests\Tokenizer\TokensTest::testEnsureWhitespaceAtIndex with data set #1 ('<?php\n', '<?php', 0, 1, '\n') The token at index 0 must be: { "id": 379, "name": "T_OPEN_TAG", "content": "<?php\n", "isArray": true, "changed": false }, got: { "id": 321, "name": "T_INLINE_HTML", "content": "<?php", "isArray": true, "changed": false }. Failed asserting that false is true. D:\GIT\fork\PHP-CS-Fixer\src\Test\Assert\AssertTokensTrait.php:33 D:\GIT\fork\PHP-CS-Fixer\tests\Tokenizer\TokensTest.php:879 3) PhpCsFixer\Tests\Tokenizer\TokensTest::testEnsureWhitespaceAtIndex with data set #2 ('<?php ', '<?php', 0, 1, ' ') The token at index 0 must be: { "id": 379, "name": "T_OPEN_TAG", "content": "<?php\t", "isArray": true, "changed": false }, got: { "id": 321, "name": "T_INLINE_HTML", "content": "<?php", "isArray": true, "changed": false }. Failed asserting that false is true. D:\GIT\fork\PHP-CS-Fixer\src\Test\Assert\AssertTokensTrait.php:33 D:\GIT\fork\PHP-CS-Fixer\tests\Tokenizer\TokensTest.php:879 4) PhpCsFixer\Tests\Tokenizer\TokensTest::testEnsureWhitespaceAtIndex with data set #4 ('<?php\n echo $a;', '<?php\necho $a;', 0, 1, '\n ') The token at index 0 must be: { "id": 379, "name": "T_OPEN_TAG", "content": "<?php\n", "isArray": true, "changed": false }, got: { "id": 379, "name": "T_OPEN_TAG", "content": "<?php", "isArray": true, "changed": true }. Failed asserting that false is true. D:\GIT\fork\PHP-CS-Fixer\src\Test\Assert\AssertTokensTrait.php:33 D:\GIT\fork\PHP-CS-Fixer\tests\Tokenizer\TokensTest.php:879 5) PhpCsFixer\Tests\Tokenizer\TokensTest::testEnsureWhitespaceAtIndex with data set #5 ('<?php\necho $a;', '<?php echo $a;', 0, 1, '\n') The token at index 0 must be: { "id": 379, "name": "T_OPEN_TAG", "content": "<?php\n", "isArray": true, "changed": false }, got: { "id": 379, "name": "T_OPEN_TAG", "content": "<?php", "isArray": true, "changed": true }. Failed asserting that false is true. D:\GIT\fork\PHP-CS-Fixer\src\Test\Assert\AssertTokensTrait.php:33 D:\GIT\fork\PHP-CS-Fixer\tests\Tokenizer\TokensTest.php:879 6) PhpCsFixer\Tests\Tokenizer\TokensTest::testEnsureWhitespaceAtIndex with data set #6 ('<?php echo $a;', '<?php echo $a;', 0, 1, ' ') The token at index 0 must be: { "id": 379, "name": "T_OPEN_TAG", "content": "<?php\t", "isArray": true, "changed": false }, got: { "id": 379, "name": "T_OPEN_TAG", "content": "<?php", "isArray": true, "changed": true }. Failed asserting that false is true. D:\GIT\fork\PHP-CS-Fixer\src\Test\Assert\AssertTokensTrait.php:33 D:\GIT\fork\PHP-CS-Fixer\tests\Tokenizer\TokensTest.php:879 FAILURES! Tests: 87, Assertions: 369, Failures: 6, Skipped: 1. hmm it seems; <?php is Tokenized as T_INLINE_HTML and not T_OPEN_TAG, meaning adding white space after it changes the type. Other oddity is that the while the token is inline html is not echo'ed out while other inline html are.	gharchive/pull-request	2017-05-14T21:45:17	2025-04-01T04:32:33.912683	{ "authors": [ "SpacePossum", "keradus" ], "repo": "FriendsOfPHP/PHP-CS-Fixer", "url": "https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/2771", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
1275298688	Add attributes support to statement_indentation Fixes #6421. Coverage increased (+0.002%) to 92.876% when pulling 9adb3300583b30fdb70a541f8f9113adfe430ea9 on julienfalque:statement-indentation-attribute into 7936fb2ef269e364042eb73f066d34e588ddd9b9 on FriendsOfPHP:master.	gharchive/pull-request	2022-06-17T17:30:00	2025-04-01T04:32:33.914784	{ "authors": [ "coveralls", "julienfalque" ], "repo": "FriendsOfPHP/PHP-CS-Fixer", "url": "https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/6429", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
970082287	Custom loggers not viewable in the logger viewer PHP Version 7.4 Shopware Version 6.4.3.0 Actual behaviour I used the logger factory to create a custom logger to log plugin data. The data is saved within a new .log file but the log viewer doesnt recognize my custom logger key and fails. Expected behaviour The log is read and shown Steps to Reproduce? Create your own logger and log something. my-plugin.logger can you send me one row here are a few rows: [2021-08-13T05:49:36.781010+00:00] dvsn.saved-cart.INFO: saved carts found: 1 [] [] [2021-08-13T05:49:36.781071+00:00] dvsn.saved-cart.INFO: removing saved carts [] [] [2021-08-13T05:49:36.810118+00:00] dvsn.saved-cart.INFO: saved carts removed [] [] [2021-08-13T05:49:36.810204+00:00] dvsn.saved-cart.INFO: stopping dvsn.saved-cart.cleanup task [] []	gharchive/issue	2021-08-13T05:47:14	2025-04-01T04:32:33.920912	{ "authors": [ "digitvision", "shyim" ], "repo": "FriendsOfShopware/FroshTools", "url": "https://github.com/FriendsOfShopware/FroshTools/issues/22", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
2385715835	[Translation] RU Я сделал русский перевод вашего модуля. Не могли бы вы включить его в следующую сборку? ru.json This should be in the next Update.	gharchive/issue	2024-07-02T09:18:20	2025-04-01T04:32:33.978007	{ "authors": [ "Frstrm", "VirusNik21" ], "repo": "Frstrm/TokenLightCondition", "url": "https://github.com/Frstrm/TokenLightCondition/issues/67", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
623262592	SCP protocol Hi, there is some news regarding the implementation of SCP ? I'm very interested in it too	gharchive/issue	2020-05-22T14:51:11	2025-04-01T04:32:33.980270	{ "authors": [ "insinfo", "pbonato" ], "repo": "Frugghi/SwiftSH", "url": "https://github.com/Frugghi/SwiftSH/issues/36", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
2187733135	Previous Desktop How would I create a hotkey to return me to the previous desktop? #Include %A_LineFile%\..\..\VD.ah2 VD.RegisterDesktopNotifications() VD.DefineProp("CurrentVirtualDesktopChanged", {Call:CurrentVirtualDesktopChanged}) previous_desktopNum:=1 CurrentVirtualDesktopChanged(desktopNum_Old, desktopNum_New) { global previous_desktopNum previous_desktopNum:=desktopNum_Old } Numpad0::VD.goToDesktopNum(previous_desktopNum) this keeps tracks of windows default shortcuts too, I don't know if you want that where should I put this information ? I'm having trouble getting the code from the readme to work (ahk v1). It always takes me back to desktop 1 instead of the previous desktop #Include %A_LineFile%\..\VD.ahk VD.RegisterDesktopNotifications() VD.CurrentVirtualDesktopChanged:=Func("CurrentVirtualDesktopChanged") previous_desktopNum:=1 CurrentVirtualDesktopChanged(desktopNum_Old, desktopNum_New) { global previous_desktopNum ToolTip % desktopNum_Old previous_desktopNum:=desktopNum_Old } Numpad0::VD.goToDesktopNum(previous_desktopNum) does the ToolTip show when you switch desktops ? does the one in v2 readme work ? which windows build version are you using ? After a bit of debugging, it seems that the issue is related to (this)[https://www.autohotkey.com/boards/viewtopic.php?style=2&t=24145] library. Thanks for the help though! Did you get what you wanted to work ? Can you send your code using LongHotkey ? I want to see what's going on/debug it. I'm currently on vacation, but I'll send my code over when I'm back :) The following code always takes me to the first desktop instead of the previous desktop :L #Include C:\home\ahk\lib\longhotkey.ahk #Include C:\home\ahk\lib\vd\VD.ahk VD.RegisterDesktopNotifications() VD.CurrentVirtualDesktopChanged:=Func("CurrentVirtualDesktopChanged") previous_desktopNum:=1 CurrentVirtualDesktopChanged(desktopNum_Old, desktopNum_New) { global previous_desktopNum previous_desktopNum:=desktopNum_Old } gtpd(){ VD.goToDesktopNum(previous_desktopNum) } new LongHotkey("CapsLock & Backspace", "gtpd") add a global previous_desktopNum in your function #Include C:\home\ahk\lib\longhotkey.ahk #Include C:\home\ahk\lib\vd\VD.ahk VD.RegisterDesktopNotifications() VD.CurrentVirtualDesktopChanged:=Func("CurrentVirtualDesktopChanged") previous_desktopNum:=1 CurrentVirtualDesktopChanged(desktopNum_Old, desktopNum_New) { global previous_desktopNum previous_desktopNum:=desktopNum_Old } gtpd(){ global previous_desktopNum VD.goToDesktopNum(previous_desktopNum) } new LongHotkey("CapsLock & Backspace", "gtpd") or you could do: #Include C:\home\ahk\lib\longhotkey.ahk #Include C:\home\ahk\lib\vd\VD.ahk VD.RegisterDesktopNotifications() VD.CurrentVirtualDesktopChanged:=Func("CurrentVirtualDesktopChanged") VD.previous_desktopNum:=1 CurrentVirtualDesktopChanged(desktopNum_Old, desktopNum_New) { VD.previous_desktopNum:=desktopNum_Old } gtpd(){ VD.goToDesktopNum(VD.previous_desktopNum) } new LongHotkey("CapsLock & Backspace", "gtpd") Thank you! The first one works great!	gharchive/issue	2024-03-15T05:07:27	2025-04-01T04:32:33.985850	{ "authors": [ "FuPeiJiang", "qupufu" ], "repo": "FuPeiJiang/VD.ahk", "url": "https://github.com/FuPeiJiang/VD.ahk/issues/69", "license": "MIT", "license_type": "permissive", "license_source": "github-api" }
1262385174	Wrong generated types on new contract API namespaces With the new contract API namespaces #303. We have enabled a contract call to return not only values but also, receipts or transactions. But the generated types methods are not been correctly generated. Example of an incorrect type dryRunResult: { get_balance( asset_id: ContractIdInput, overrides?: Overrides & { from?: string \| Promise<string> } ): Promise<bigint>; What it should be dryRunResult: { get_balance( asset_id: ContractIdInput, overrides?: Overrides & { from?: string \| Promise<string> } ): Promise<CallResult>; This issue should also cover other namespaces: submit submitResult dryRun dryRunResult simulate simulateResult prepareCall @luizstacio I'm not sure what you mean, I added updates for return types for all of the namespaces - can you add a link or an example? If you look at prepareCall it would have a type the returns ScriptTransactionRequest today is returning void as the sumbit does. I tried on a fresh project folder installing 0.0.0-master-0b31360c and it appears to work. In the PR that was previously merged it also shows all of those types intact: https://github.com/FuelLabs/fuels-ts/pull/319/files#diff-79bb666ce36f9c2e0e08a82382da110ce65c7d6e670f6b15153eb41095d77334 Can you send me your Sway file so I can debug this a little further? Perhaps its related to #320 in some way. Just tested here is also working! Thanks for the check	gharchive/issue	2022-06-06T20:33:48	2025-04-01T04:32:33.989831	{ "authors": [ "luizstacio" ], "repo": "FuelLabs/fuels-ts", "url": "https://github.com/FuelLabs/fuels-ts/issues/318", "license": "Apache-2.0", "license_type": "permissive", "license_source": "github-api" }

Subsets and Splits

No community queries yet

The top public SQL queries from the community will appear here once available.