id stringlengths 4 10 | text stringlengths 4 2.14M | source stringclasses 2
values | created timestamp[s]date 2001-05-16 21:05:09 2025-01-01 03:38:30 | added stringdate 2025-04-01 04:05:38 2025-04-01 07:14:06 | metadata dict |
|---|---|---|---|---|---|
338096872 | JSDoc /** @type */ tags don't check return types
// @ts-check
/** @type {(x: number, y: number, z: number) => string} */
function foo(x, y, z) {
return 100;
}
Expected: Error.
Actual: No error.
Note: doesn't repro for function expressions:
var foo = function (...
// or
var bar = (...
getJSDocReturnType only looks at @return tags, it doesn't check @type tags to see whether their type node has a return type. Seems easy to fix.
| gharchive/issue | 2018-07-04T00:53:22 | 2025-04-01T04:32:46.241516 | {
"authors": [
"DanielRosenwasser",
"sandersn"
],
"repo": "Microsoft/TypeScript",
"url": "https://github.com/Microsoft/TypeScript/issues/25424",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
418100490 | TypeScript unexpectedly inferring 'any' type.
Given the following code:
interface Widget { x: number }
declare type Unwrap<T> = T extends Promise<infer U1> ? UnwrapSimple<U1> : UnwrapSimple<T>;
declare type primitive = Function | string | number | boolean | undefined | null;
declare type UnwrapSimple<T> = T extends primitive ? T : T extends Array<infer U> ? UnwrappedArray<U> : T extends object ? UnwrappedObject<T> : never;
export interface UnwrappedArray<T> extends Array<Unwrap<T>> {
}
export declare type UnwrappedObject<T> = {
[P in keyof T]: Unwrap<T[P]>;
};
declare var w: Widget;
declare type TupleType = [Widget, string];
declare var o: UnwrappedObject<TupleType>;
TypeScript oddly infers a type of [any, string] for o. This is surprising to us given how we would think these type operators would work. First, given the definition UnwrappedObject i would expect UnwrappedObject<TupleType> to expand like so:
UnwrappedObject<TupleType> ->
UnwrappedObject<[Widget, string]> ->
[Unwrap<Widget>, Unwrap<string>] ->
[UnwrappedObject<Widget>, string] ->
[{ x: Unwrap<number> }, string] ->
[{ x: number }, string]
HOwever, instead of getting { x: number } (which is just the Widget type), we end up with 'any'. Cany anyone shed any light on this? Thanks!
Tagging @DanielRosenwasser
@RyanCavanaugh do you have any ideas here? Thanks!
This problem was fixed by #29740
@RyanCavanaugh Thanks! Is there a way to tell what release of TS that may have made it out into?
The PR was 3 days ago, so it'd be in any nightly starting approximately yesterday
@RyanCavanaugh wasn't it almost a month ago?
This is part of github that i'm not really familiar with!
I thought today was February 7th 🤦♂️
This fix wasn't in 3.3, so "nightly" is still the right answer.
The incantation (if you have a local TS repo) to check is
D:\github\TypeScript>git branch -r --contains d9ee867
origin/HEAD -> origin/master
origin/master
origin/no-mkdir-race
upstream/add-globalThis
upstream/applyChangesToOpenFiles
upstream/circularConstraintErrors
upstream/contextualGenericRestParameter
upstream/convert-to-named-parameters
upstream/incrementalBuildInfo
upstream/master
upstream/perfTimeStamp
upstream/revertExecFileSync
upstream/usePrependToSkipBuild
upstream/weswigham-patch-1
I thought today was February 7th 🤦♂️
That's ok. I still think it's 2017 occasionally. :D
Thanks. Have confirmed this is fixed in the latest nightly. I'm going to keep this issue open though until that is released.
@RyanCavanaugh @DanielRosenwasser Any general idea of when 3.4 might be released? Trying to make plans depending on if it's more like in a week or so, or more like a month. Thanks much!
See https://github.com/Microsoft/TypeScript/issues/30281
| gharchive/issue | 2019-03-07T02:33:43 | 2025-04-01T04:32:46.248092 | {
"authors": [
"CyrusNajmabadi",
"RyanCavanaugh"
],
"repo": "Microsoft/TypeScript",
"url": "https://github.com/Microsoft/TypeScript/issues/30250",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
41218409 | Improve error messages for duplicate identifiers
We need to split the "Duplicate identifier" error in to a suite of more detailed errors about various types of illegal merges. "Duplicate identifier" is too general. Some examples of cases that warrant their own message:
Would be a legal merge (like module & module) but exports don't match
Fundule in the wrong order
Clodule in the wrong order
Fundule in different files
Clodule in different files
Interface and enum can't merge
Interface and class can't merge
Class and enum can't merge
Function and enum can't merge
Basically every illegal cell in the matrix of merges should have a separate error message (or some of them can be grouped together in terms of value/type/namespace space). For example:
Class cannot merge with any other type
Additional related request, it would be useful if the message included the source location of the existing identifier.
@robertknight we used to do that in the 1.0 time-frame, but then the error message was too long and not easily piped through IDEs and editors to allow jumping to the location; instead, the new behavior is to error on all instances of the duplicate definitions, this way you can chose which one to jump to.
the new behavior is to error on all instances of the duplicate definitions, this way you can chose which one to jump to.
Unfortunately, if the duplicate identifier is not in your code, for example if you do class Node { ..., then you can't find the other definition easily. Presumably "Node" is colliding with something from the DOM typings.
The compiler outputs all locations...
$ cat test.ts
class Node { }
$ tsc test.ts
/node_modules/typescript/lib/lib.d.ts(12324,11): error TS2300: Duplicate identifier 'Node'.
/node_modules/typescript/lib/lib.d.ts(12376,13): error TS2300: Duplicate identifier 'Node'.
test.ts(1,7): error TS2300: Duplicate identifier 'Node'.
If you are in vscode, the quick info does not provide all locations, but if you were to comment out the offending code and just write:
Node;
The quick info would provide you with the definition locations you could navigate to.
[ ] Would be a legal merge (like module & module) but exports don't match
namespace FF {
export function foo() { // error here, not on FF "Duplicate function implementation"
return 0
}
}
namespace FF {
export function foo() {
return "2"
}
}
which seems appropriate...?
[X] Fundule in the wrong order
[X] Clodule in the wrong order
A namespace declaration cannot be located prior to a class or function with which it is merged.
[X] Fundule in different files
[X] Clodule in different files
A namespace declaration cannot be in a different file from a class or function with which it is merged.
[ ] Interface and class can't merge
No error at all currently: https://www.typescriptlang.org/play/#src=interface FF {%0D%0A foo()%3A void%0D%0A}%0D%0Aclass FF {%0D%0A x%3A string%0D%0A}
The following are still an issue:
[ ] Interface and enum can't merge
[ ] Class and enum can't merge
[ ] Function and enum can't merge
| gharchive/issue | 2014-08-26T20:36:10 | 2025-04-01T04:32:46.257038 | {
"authors": [
"NaridaL",
"brandonbloom",
"kitsonk",
"mhegazy",
"robertknight"
],
"repo": "Microsoft/TypeScript",
"url": "https://github.com/Microsoft/TypeScript/issues/529",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
122029991 | Describing an overridden but incompatible method signature in an ambient class
From SO: http://stackoverflow.com/questions/34087631
/** Represents an iterable collection of Pnp device objects. */
abstract class PnpObjectCollection extends Array {
/** Returns the iterator for iteration over the items in the collection. */
first(): Windows.Foundation.Collections.IIterator<Windows.Devices.Enumeration.Pnp.PnpObject>;
/** Returns the PnpObject located at the specified index. */
getAt(index: number): Windows.Devices.Enumeration.Pnp.PnpObject;
/** Retrieves multiple elements in a single pass through the iterator. */
getMany(startIndex: number): { /** Provides the destination for the result. Size the initial array size as a "capacity" in order to specify how many results should be retrieved. */ items: Windows.Devices.Enumeration.Pnp.PnpObject; /** The number of items retrieved. */ returnValue: number; };
/** Retrieves the index of the specified item. */
indexOf(value: Windows.Devices.Enumeration.Pnp.PnpObject): { /** The index of the item to find, if found. */ index: number; /** True if an item with the specified value was found; otherwise, False. */ returnValue: boolean; };
/** Returns the number of items in the collection. */
size: number;
}
This is the current generated code by expressing UWP PnpObjectCollection. PnpObjectCollection.prototype.__proto__ === Array is true here so I added extends Array but as you see the signature of indexOf method conflicts.
TS2415 Class 'PnpObjectCollection' incorrectly extends base class 'any[]'.
Types of property 'indexOf' are incompatible.
Type '(value: PnpObject) => { index: number; returnValue: boolean; }' is not assignable to type '(searchElement: any, fromIndex?: number) => number'.
Type '{ index: number; returnValue: boolean; }' is not assignable to type 'number'.
30+ classes in entire d.ts file have this problem, so how can I express this class without errors? I cannot add indexOf(value: T, fromIndex: number): number line because calling indexof(value, 0) returns an object, not a number.
Current winrt.d.ts in DefinitelyTyped have manually added ES5 compatible Array methods on IVectorView interface but that will:
force the class declarations to have all the interface members copied
make them lack ES6 methods (adding ES6 ones will break ES5 compatibility)
I've answered on http://stackoverflow.com/a/34299582/4386952.
In general, it seems strange that the library authors disregarded the implementation - but that's the thing. We require all derived signatures to be compatible in an ambient class even if a library author is doing shenanigans, and we should discuss whether that should be the case.
@DanielRosenwasser It helps me a lot, thanks! :+1:
My thought:
abstract class PnpObjectCollection extends Array<PnpObject> {
/* suppress signature confliction error */
override indexOf(value: Windows.Devices.Enumeration.Pnp.PnpObject): { index: number; returnValue: boolean; };
}
let collection: PnpObjectCollection;
let ary: Array<PnpObject>
ary = collection; // error
collection = ary; // error
Answer on SO is generally correct, as well as the observation that you don't really need to extend Array in an ambient class except to save typing (which is sort of a red herring since the type is nonsubstitutable anyway so you should be checking each method individually)
@RyanCavanaugh I think I need to extend Array as the class have Array in its prototype chain and the declaration should not require users to manually add those new ES6 methods, no?
| gharchive/issue | 2015-12-14T12:06:22 | 2025-04-01T04:32:46.263485 | {
"authors": [
"DanielRosenwasser",
"RyanCavanaugh",
"SaschaNaz"
],
"repo": "Microsoft/TypeScript",
"url": "https://github.com/Microsoft/TypeScript/issues/6094",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
124707058 | Wiki broken for tsconfig.json
Refer: https://github.com/Microsoft/TypeScript/wiki/tsconfig.json
It looks OK to me after a quick glance. What specifically is wrong?
I tried to open multiple times, it is returning incomplete HTML, so everything looked like non-rendered HTML text file in the browser.
This seems like more of a GitHub issue? Unless you think this is related to some specific content we put in the wiki
Yes, I think its GitHub issue, Is there a place to log this bug report to GitHub?
I am able to read all other Wiki Pages. Only tsconfig.json is broken
Is this because of .json extension at the end of URL?
Unfortunately GitHub itself doesn't have an issue tracker. There's this form https://github.com/contact, though -- maybe you can just drop a link to this issue.
| gharchive/issue | 2016-01-04T06:58:08 | 2025-04-01T04:32:46.267081 | {
"authors": [
"RyanCavanaugh",
"vamsivarikuti"
],
"repo": "Microsoft/TypeScript",
"url": "https://github.com/Microsoft/TypeScript/issues/6335",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
334244767 | Multifaceted approach to performantly enabling fileExists outside of the synchronize step in the emit host
First, in program, as @sheetalkamat suggested, we use the local caches if they have a result for the desired path. Since they still may not (ie, because the file isn't in the program, which is possibly the case when attempting to check paths for module specifiers), we also keep around a "thin" version of the host cache - effectively a host cache that doesn't contain any file contents, just metadata. (This way if the file is looked up for other reasons, that data is still there.) Finally, if both of those fail, we should hit disk (via the language server host).
Fixes #25047
Deleting the host cache was a performance optimization so we didn't hold on to file contents for files we weren't actively using - this should retain that invariant, since we're replacing the cache with one with no content.
@sheetalkamat I've removed it - we can always go add it later if we decide the perf is an issue.
| gharchive/pull-request | 2018-06-20T20:51:18 | 2025-04-01T04:32:46.269062 | {
"authors": [
"weswigham"
],
"repo": "Microsoft/TypeScript",
"url": "https://github.com/Microsoft/TypeScript/pull/25107",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
347217968 | Test PR [Please Ignore]
I'll be using this PR to test out calling the bot to run RWC on the PR prior to a merge. I'll close it when I'm done ❤️
Except this time the PR's on a fork. ;)
@typescript-bot test this
Nice, good bot ❤️
| gharchive/pull-request | 2018-08-03T00:24:35 | 2025-04-01T04:32:46.270389 | {
"authors": [
"weswigham"
],
"repo": "Microsoft/TypeScript",
"url": "https://github.com/Microsoft/TypeScript/pull/26176",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
126319184 | pre-compute emitted files
Adding a commandline option to pre-compute the files that the compiler will emit when doing the real compilation.
This allows build tools, like MSBuild to decide if they actually need to invoke the compiler or if there have been no changes to the emitted files, skip compilation.
Can you add a test to demo how this works?
After an in-person demonstration I think it is OK without tests (although it would still be nice to get a reusable mock of the filesystem someday so we can write these kind of tests without days of work).
:1+:
consider suppressing this region when listOutputFiles is set: diagnostics are not necessary in your scenario however getting then will force creation of the typechecker (and binding as an intermediate step).
Should this be closed?
| gharchive/pull-request | 2016-01-13T01:33:13 | 2025-04-01T04:32:46.272891 | {
"authors": [
"DanielRosenwasser",
"paulvanbrenk",
"sandersn",
"vladima"
],
"repo": "Microsoft/TypeScript",
"url": "https://github.com/Microsoft/TypeScript/pull/6460",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
130438119 | Ports #6770 into release-18
Ports #6770
:+1:
| gharchive/pull-request | 2016-02-01T18:10:35 | 2025-04-01T04:32:46.273723 | {
"authors": [
"mhegazy",
"vladima"
],
"repo": "Microsoft/TypeScript",
"url": "https://github.com/Microsoft/TypeScript/pull/6787",
"license": "Apache-2.0",
"license_type": "permissive",
"license_source": "github-api"
} |
310243656 | dfu-util does not list devices when Windows-version does
Windows build number: Microsoft Windows [Version 10.0.16299.334]
I am using WSL in combination with a Particle Photon and part of that process involves using dfu-util. This command is used to manage firmware via USB. There are native builds for Windows and Linux. I am using v0.8. When I run the command dfu-util.exe -l on Windows, I see my expected device:
Found DFU: [2b04:d006] ver=0250, devnum=32, cfg=1, intf=0, alt=1, name="@DCT Flash /0x00000000/01*016Kg", serial="<intentionally omitted>"
When I run dfu-util -l via WSL, I get nothing (no output and no errors). Running this setup in native-Linux works the same as Windows.
Note: I can communicate via serial using /dev/ttyS..., so WSL is at-least "aware" of the device.
No strace log because you deleted the template (natch) but on WSL /sys/bus is an empty directory. #1521, #2195, #2287, #2185 et al.
Here's the log for anyone who wants to take a look:
execve("/usr/bin/dfu-util", ["dfu-util", "-l"], [/* 22 vars */]) = 0
brk(NULL) = 0x1ea9000
access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory)
access("/etc/ld.so.preload", R_OK) = -1 ENOENT (No such file or directory)
open("/etc/ld.so.cache", O_RDONLY|O_CLOEXEC) = 3
fstat(3, {st_mode=S_IFREG|0644, st_size=25525, ...}) = 0
mmap(NULL, 25525, PROT_READ, MAP_PRIVATE, 3, 0) = 0x7f98e5171000
close(3) = 0
access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory)
open("/lib/x86_64-linux-gnu/libusb-1.0.so.0", O_RDONLY|O_CLOEXEC) = 3
read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\0=\0\0\0\0\0\0"..., 832) = 832
fstat(3, {st_mode=S_IFREG|0644, st_size=97056, ...}) = 0
mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f98e5170000
mmap(NULL, 2192480, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7f98e4be0000
mprotect(0x7f98e4bf7000, 2093056, PROT_NONE) = 0
mmap(0x7f98e4df6000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x16000) = 0x7f98e4df6000
close(3) = 0
access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory)
open("/lib/x86_64-linux-gnu/libc.so.6", O_RDONLY|O_CLOEXEC) = 3
read(3, "\177ELF\2\1\1\3\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0P\t\2\0\0\0\0\0"..., 832) = 832
fstat(3, {st_mode=S_IFREG|0755, st_size=1868984, ...}) = 0
mmap(NULL, 3971488, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7f98e4810000
mprotect(0x7f98e49d0000, 2097152, PROT_NONE) = 0
mmap(0x7f98e4bd0000, 24576, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x1c0000) = 0x7f98e4bd0000
mmap(0x7f98e4bd6000, 14752, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1, 0) = 0x7f98e4bd6000
close(3) = 0
access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory)
open("/lib/x86_64-linux-gnu/libudev.so.1", O_RDONLY|O_CLOEXEC) = 3
read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\0\0\0\0\0\0\0\0"..., 832) = 832
fstat(3, {st_mode=S_IFREG|0644, st_size=126840, ...}) = 0
mmap(NULL, 130656, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7f98e5150000
mmap(0x7f98e516e000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x1d000) = 0x7f98e516e000
close(3) = 0
access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory)
open("/lib/x86_64-linux-gnu/libpthread.so.0", O_RDONLY|O_CLOEXEC) = 3
read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\260`\0\0\0\0\0\0"..., 832) = 832
fstat(3, {st_mode=S_IFREG|0755, st_size=138696, ...}) = 0
mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f98e5140000
mmap(NULL, 2212904, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7f98e45f0000
mprotect(0x7f98e4608000, 2093056, PROT_NONE) = 0
mmap(0x7f98e4807000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x17000) = 0x7f98e4807000
mmap(0x7f98e4809000, 13352, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_ANONYMOUS, -1, 0) = 0x7f98e4809000
close(3) = 0
access("/etc/ld.so.nohwcap", F_OK) = -1 ENOENT (No such file or directory)
open("/lib/x86_64-linux-gnu/librt.so.1", O_RDONLY|O_CLOEXEC) = 3
read(3, "\177ELF\2\1\1\0\0\0\0\0\0\0\0\0\3\0>\0\1\0\0\0\0!\0\0\0\0\0\0"..., 832) = 832
fstat(3, {st_mode=S_IFREG|0644, st_size=31712, ...}) = 0
mmap(NULL, 2128832, PROT_READ|PROT_EXEC, MAP_PRIVATE|MAP_DENYWRITE, 3, 0) = 0x7f98e43e0000
mprotect(0x7f98e43e7000, 2093056, PROT_NONE) = 0
mmap(0x7f98e45e6000, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_FIXED|MAP_DENYWRITE, 3, 0x6000) = 0x7f98e45e6000
close(3) = 0
mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f98e5130000
mmap(NULL, 8192, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7f98e5120000
arch_prctl(ARCH_SET_FS, 0x7f98e5120740) = 0
mprotect(0x7f98e4bd0000, 16384, PROT_READ) = 0
mprotect(0x7f98e4807000, 4096, PROT_READ) = 0
mprotect(0x7f98e45e6000, 4096, PROT_READ) = 0
mprotect(0x7f98e516e000, 4096, PROT_READ) = 0
mprotect(0x7f98e4df6000, 4096, PROT_READ) = 0
mprotect(0x609000, 4096, PROT_READ) = 0
mprotect(0x7f98e5025000, 4096, PROT_READ) = 0
munmap(0x7f98e5171000, 25525) = 0
set_tid_address(0x7f98e5120a10) = 1978
set_robust_list(0x7f98e5120a20, 24) = 0
rt_sigaction(SIGRTMIN, {0x7f98e45f5b50, [], SA_RESTORER|SA_SIGINFO, 0x7f98e4601390}, NULL, 8) = 0
rt_sigaction(SIGRT_1, {0x7f98e45f5be0, [], SA_RESTORER|SA_RESTART|SA_SIGINFO, 0x7f98e4601390}, NULL, 8) = 0
rt_sigprocmask(SIG_UNBLOCK, [RTMIN RT_1], NULL, 8) = 0
getrlimit(RLIMIT_STACK, {rlim_cur=8192*1024, rlim_max=8192*1024}) = 0
write(1, "dfu-util 0.8\n", 13) = 13
write(1, "\n", 1) = 1
write(1, "Copyright 2005-2009 Weston Schmi"..., 231) = 231
write(1, "\n", 1) = 1
gettimeofday({1522508394, 765302}, NULL) = 0
brk(NULL) = 0x1ea9000
brk(0x1eca000) = 0x1eca000
open("/dev/bus/usb", O_RDONLY|O_NONBLOCK|O_DIRECTORY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
open("/proc/bus/usb", O_RDONLY|O_NONBLOCK|O_DIRECTORY|O_CLOEXEC) = -1 ENOENT (No such file or directory)
open("/dev", O_RDONLY|O_NONBLOCK|O_DIRECTORY|O_CLOEXEC) = 3
fstat(3, {st_mode=S_IFDIR|0755, st_size=512, ...}) = 0
getdents(3, /* 212 entries */, 32768) = 6680
getdents(3, /* 0 entries */, 32768) = 0
close(3) = 0
clock_gettime(CLOCK_MONOTONIC, {5319, 558233000}) = 0
uname({sysname="Linux", nodename="william-boga-iv", ...}) = 0
uname({sysname="Linux", nodename="william-boga-iv", ...}) = 0
uname({sysname="Linux", nodename="william-boga-iv", ...}) = 0
uname({sysname="Linux", nodename="william-boga-iv", ...}) = 0
stat("/sys/bus/usb/devices", 0x7fffea879bf0) = -1 ENOENT (No such file or directory)
open("/etc/udev/udev.conf", O_RDONLY|O_CLOEXEC) = 3
fstat(3, {st_mode=S_IFREG|0644, st_size=153, ...}) = 0
read(3, "# see udev.conf(5) for details\n#"..., 512) = 153
read(3, "", 512) = 0
close(3) = 0
access("/run/udev/control", F_OK) = -1 ENOENT (No such file or directory)
socket(PF_NETLINK, SOCK_RAW|SOCK_CLOEXEC|SOCK_NONBLOCK, NETLINK_KOBJECT_UEVENT) = 3
setsockopt(3, SOL_SOCKET, SO_ATTACH_FILTER, "\10\0\0\0\0\0\0\0P\213\207\352\377\177\0\0", 16) = -1 EINVAL (Invalid argument)
bind(3, {sa_family=AF_NETLINK, pid=0, groups=00000000}, 12) = 0
getsockname(3, {sa_family=AF_NETLINK, pid=1978, groups=00000000}, [12]) = 0
setsockopt(3, SOL_SOCKET, SO_PASSCRED, [1], 4) = -1 EINVAL (Invalid argument)
fcntl(3, F_GETFL) = 0x80802 (flags O_RDWR|O_NONBLOCK|O_CLOEXEC)
fcntl(3, F_SETFL, O_RDWR|O_NONBLOCK|O_CLOEXEC) = 0
pipe([4, 5]) = 0
fcntl(5, F_GETFL) = 0x1 (flags O_WRONLY)
fcntl(5, F_SETFL, O_WRONLY|O_NONBLOCK) = 0
mmap(NULL, 8392704, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS|MAP_STACK, -1, 0) = 0x7f98e3bd0000
mprotect(0x7f98e3bd0000, 4096, PROT_NONE) = 0
clone(child_stack=0x7f98e43cffb0, flags=CLONE_VM|CLONE_FS|CLONE_FILES|CLONE_SIGHAND|CLONE_THREAD|CLONE_SYSVSEM|CLONE_SETTLS|CLONE_PARENT_SETTID|CLONE_CHILD_CLEARTID, parent_tidptr=0x7f98e43d09d0, tls=0x7f98e43d0700, child_tidptr=0x7f98e43d09d0) = 1979
gettid() = 1978
getrandom("-m\365?}\316jz\374-|3~c\271\264", 16, GRND_NONBLOCK) = 16
access("/sys/subsystem", F_OK) = -1 ENOENT (No such file or directory)
open("/sys/bus", O_RDONLY|O_NONBLOCK|O_DIRECTORY|O_CLOEXEC) = 6
fstat(6, {st_mode=S_IFDIR|0755, st_size=0, ...}) = 0
getdents(6, /* 2 entries */, 32768) = 48
getdents(6, /* 0 entries */, 32768) = 0
close(6) = 0
open("/sys/class", O_RDONLY|O_NONBLOCK|O_DIRECTORY|O_CLOEXEC) = 6
fstat(6, {st_mode=S_IFDIR|0755, st_size=0, ...}) = 0
getdents(6, /* 7 entries */, 32768) = 200
getdents(6, /* 0 entries */, 32768) = 0
close(6) = 0
pipe([6, 7]) = 0
fcntl(7, F_GETFL) = 0x1 (flags O_WRONLY)
fcntl(7, F_SETFL, O_WRONLY|O_NONBLOCK) = 0
write(7, "\1", 1) = 1
timerfd_create(CLOCK_MONOTONIC, TFD_NONBLOCK) = 8
recvmsg(3, 0x7fffea877b10, 0) = -1 EAGAIN (Resource temporarily unavailable)
exit_group(0) = ?
+++ exited with 0 +++
open("/sys/bus", O_RDONLY|O_NONBLOCK|O_DIRECTORY|O_CLOEXEC) = 6
fstat(6, {st_mode=S_IFDIR|0755, st_size=0, ...}) = 0
getdents(6, /* 2 entries */, 32768) = 48
getdents(6, /* 0 entries */, 32768) = 0
getdents returned nothing. It would be easier to do ls /sys/bus.
The response here is a little cryptic - what is the solution for this? I also have firmware that needs to be flashed with dfu-util and it is not being picked up in WSL
Any updates on this one?
| gharchive/issue | 2018-03-31T14:12:58 | 2025-04-01T04:32:46.295641 | {
"authors": [
"DanielGGordon",
"MichaelShmalkoProCoder",
"billbogaiv",
"therealkenc"
],
"repo": "Microsoft/WSL",
"url": "https://github.com/Microsoft/WSL/issues/3069",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
350529642 | [Survey] What are you using WinAppDriver for?
Hi all,
I'd like to survey all the different use-cases and reasons you are all using WinAppDriver for - this well help us identify in areas to focus on for future growth.
Appreciate any particular cases you guys can provide!
For example (you don't have to follow this at all) - "I'm Hassan, and I like to use WinAppDriver to automate UWP applications to replicate user-like scenarios for my retail business."
Any feedback will be greatly appreciated. Thank you!
I have used Windows Application Driver for two tests -
dotNet thick client application [Windows 10 platform]
Mobile app for touch devices
I'm David, we use WinAppDriver to automate a UWP application. (We do not use appium, we interact directly with WinAppDriver)
We are using it in react-native-windows to do a smoke test on the Playground WPF application in the AppVeyor CI:
https://github.com/Microsoft/react-native-windows/pull/1765
One issue was finding a specific version of selenium-webdriver that worked with Appium+WinAppDriver, and the fact that there's no JS examples.
"I'm Konstantin, and I like to use WinAppDriver to automate WPF application to testing user scenarios."
| gharchive/issue | 2018-08-14T17:45:23 | 2025-04-01T04:32:46.299963 | {
"authors": [
"DGCBio",
"Soloveykos",
"gitsaquib",
"hassanuz",
"matthargett"
],
"repo": "Microsoft/WinAppDriver",
"url": "https://github.com/Microsoft/WinAppDriver/issues/476",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
190243959 | CGImages loaded from container data (JPEG, PNG, TIFF) can use-after-free their buffers.
In CGImage here, we specify OnDemand caching for images loaded from WIC frame decoders.
Unfortunately, if you do this:
CFDataRef data = CFDataCreate(...);
CGImageRef image = CGImageCreateWithDataProvider(CGDataProviderCreateWithCFData(data), ...);
CFRelease(data);
CGImageDoAnythingAtAll(image);
Line 4 will cause CGImage through WIC to read the buffer backing the CGData destroyed on line 3.
Interim solution: Switch to OnLoad.
Suggested future solution: Implement an IWICStream that is backed by a CGDataProvider.
As part of the aforementioned future solution, we could switch back to OnDemand (and reap all the savings.)
Saw this issue when we did bitmap context, made these changes in bitmap context. missed the decoder one.
Updating
Definitely don't do it tonight! I've worked around it for CoreGraphics.Drawing.UnitTests.
LOL so the existing CGImage tests would of got this easily, but we autoreleased the CFData, rather than a release right away.
#1413
| gharchive/issue | 2016-11-18T06:13:32 | 2025-04-01T04:32:46.303641 | {
"authors": [
"DHowett-MSFT",
"msft-Jeyaram"
],
"repo": "Microsoft/WinObjC",
"url": "https://github.com/Microsoft/WinObjC/issues/1412",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
168715565 | NSData long description tests fail on OSX
Seems to be slightly off from OSX long descriptions - interesting that this happened in ReferenceFoundation:
[ RUN ] NSData.LongDebugDescription
Foundation/ReferenceFoundation/TestNSData.mm:160: Failure
Value of: expected
Actual: <ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ... ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff>
Expected: data.debugDescription
Which is: <OS_dispatch_data: data[0x7fae98c1f760] = { leaf, size = 100000, buf = 0x10f144000 }>
[ FAILED ] NSData.LongDebugDescription (3 ms)
[ RUN ] NSData.EdgeDebugDescription
Foundation/ReferenceFoundation/TestNSData.mm:187: Failure
Value of: expected
Actual: <ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ... ffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ff>
Expected: data.debugDescription
Which is: <ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ff>
[ FAILED ] NSData.EdgeDebugDescription (2 ms)
[ RUN ] NSData.EdgeNoCopyDescription
Foundation/ReferenceFoundation/TestNSData.mm:214: Failure
Value of: expected
Actual: <ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ... ffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ff>
Expected: data.debugDescription
Which is: <ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ffffffff ff>
[ FAILED ] NSData.EdgeNoCopyDescription (2 ms)
NSData.LongDebugDescription seems to fail because the reference platform uses a different class (NSObject<OS_dispatch_data>) in the NSData class cluster when the size of the data is >= 2^16 - 9 (65527) bytes on my test machine, possibly different sizes depending on the test platform. To fix this test we can either A: create the OS_dispatch_data protocol for NSObject, which will probably require quite a lot of work or B: lower the size of the test data so we do not encounter this issue. Because this seems to be more an implementation issue that should only come up during logging than a functionality one, I would recommend option B.
The other tests here fail because they expect the reference platform to shorten the logs past 1024 bytes, but that does not seem to be the case, so testing especially large NSData logs seems unnecessary.
| gharchive/issue | 2016-08-01T18:53:14 | 2025-04-01T04:32:46.317638 | {
"authors": [
"aballway",
"ms-jihua"
],
"repo": "Microsoft/WinObjC",
"url": "https://github.com/Microsoft/WinObjC/issues/748",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
251248507 | ObjC2Winmd Tool: Tool to convert ObjC middleware to WinRT component
This tool generates WinRT component for an ObjC middleware.
The tool auto-generates WinRT wrappers and glue/marshalling code for type marshalling to and from ObjC and WinRT.
This change is
@DHowett-MSFT, Yes the binary and the required DLL gets packaged to WinObjC-tools package and gets installed with it.
| gharchive/pull-request | 2017-08-18T13:39:55 | 2025-04-01T04:32:46.319877 | {
"authors": [
"mukhole"
],
"repo": "Microsoft/WinObjC",
"url": "https://github.com/Microsoft/WinObjC/pull/2786",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
78365607 | Cortana "adventureworks" sample
I've only been able to get cortana to work with this app once. Cortana doesn't provide the commands that are installed under the "?" menu. Uninstalled/Reinstalled and though the commands show in the help menu - after typing them in the ask me anything box, then only "bing search" is an option.
Whats the right way of tickling it to make it work?
in that build of windows, it required you to talk to her - it didn't support typing to her yet.
| gharchive/issue | 2015-05-20T04:32:06 | 2025-04-01T04:32:46.321137 | {
"authors": [
"quincycs"
],
"repo": "Microsoft/Windows-universal-samples",
"url": "https://github.com/Microsoft/Windows-universal-samples/issues/23",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
} |
304976806 | differences between alarmbot and alarmbot-cards
I think over the evolving of this SDK, lots of differences have emerged between alarmbot and alarmbot-cards. I'm having a hard time creating AlarmBot-Cards from AlarmBot in a simple way, but I think the story to be told is "look how easily you can add cards to enhance the experience"
IMO - it might be nice to take AlarmBot and create AlarmBot-Cards directly from that, and then in the Readme for AlarmBot-Cards say exactly what was changed to do so. Finally, reference that in the Wiki for Cards and Attachments. I think that will bring the story all together.
@tomlm, who authored those two bots, found that the flow and implementation across the two bots was different. Using cards totally changed the flow of the bot in such a way as to make them be actually different bots.
I don't think, long term, we'll keep AlarmBot and -Cards around as sample bots, as we want more deliberate, more real-world, samples. For now, they're good technology demonstration bots.
| gharchive/issue | 2018-03-13T23:57:15 | 2025-04-01T04:32:46.325927 | {
"authors": [
"amthomas46",
"cleemullins"
],
"repo": "Microsoft/botbuilder-dotnet",
"url": "https://github.com/Microsoft/botbuilder-dotnet/issues/310",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
379286550 | Make botbuilder-ai browser compatible
Is your feature request related to a problem? Please describe.
botbuilder-ai has a dependency on request which is only used in the QnAMaker class. Additionally, there exists the azure-sdk-for-js repo which contains an isomorphic luis runtime client which can be used instead of the current Node.js-specific client. We can use node-fetch instead of request, and @azure/cognitiveservices-luis-runtime instead of azure-cognitiveservices-luis-runtime to remove the Node.js-specific dependencies.
(Related to #600)
[enhancement]
@juanar Any update on this?
@JuanAr Any update on this?
@cleemullins @gabog we still haven't had the chance to start digging into this one. However, we realized #818 is related to this one and should be tackled first.
As a ballpark ETA, we are going to fix this issue early next week.
Fixed with #914
| gharchive/issue | 2018-11-09T19:11:25 | 2025-04-01T04:32:46.329210 | {
"authors": [
"JuanAr",
"cleemullins",
"gabog",
"stevengum"
],
"repo": "Microsoft/botbuilder-js",
"url": "https://github.com/Microsoft/botbuilder-js/issues/620",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
412302707 | no-outside-dependencies is very angry at the types that ship with typescript itself
See for example https://travis-ci.org/DefinitelyTyped/DefinitelyTyped/builds/495783008, which is balking at packages using lib.es2015 and the whole family of bundled (lib) types.
Error in npm
Error: /home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es2015.collection.d.ts:1:1
ERROR: 1:1 no-outside-dependencies File /home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es2015.collection.d.ts comes from a `node_modules` but is not declared in this type's `package.json`. See: https://github.com/Microsoft/dtslint/blob/master/docs/no-outside-dependencies.md
/home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es2015.core.d.ts:1:1
ERROR: 1:1 no-outside-dependencies File /home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es2015.core.d.ts comes from a `node_modules` but is not declared in this type's `package.json`. See: https://github.com/Microsoft/dtslint/blob/master/docs/no-outside-dependencies.md
/home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es2015.d.ts:1:1
ERROR: 1:1 no-outside-dependencies File /home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es2015.d.ts comes from a `node_modules` but is not declared in this type's `package.json`. See: https://github.com/Microsoft/dtslint/blob/master/docs/no-outside-dependencies.md
/home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es2015.generator.d.ts:1:1
ERROR: 1:1 no-outside-dependencies File /home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es2015.generator.d.ts comes from a `node_modules` but is not declared in this type's `package.json`. See: https://github.com/Microsoft/dtslint/blob/master/docs/no-outside-dependencies.md
/home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es2015.iterable.d.ts:1:1
ERROR: 1:1 no-outside-dependencies File /home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es2015.iterable.d.ts comes from a `node_modules` but is not declared in this type's `package.json`. See: https://github.com/Microsoft/dtslint/blob/master/docs/no-outside-dependencies.md
/home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es2015.promise.d.ts:1:1
ERROR: 1:1 no-outside-dependencies File /home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es2015.promise.d.ts comes from a `node_modules` but is not declared in this type's `package.json`. See: https://github.com/Microsoft/dtslint/blob/master/docs/no-outside-dependencies.md
/home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es2015.proxy.d.ts:1:1
ERROR: 1:1 no-outside-dependencies File /home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es2015.proxy.d.ts comes from a `node_modules` but is not declared in this type's `package.json`. See: https://github.com/Microsoft/dtslint/blob/master/docs/no-outside-dependencies.md
/home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es2015.reflect.d.ts:1:1
ERROR: 1:1 no-outside-dependencies File /home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es2015.reflect.d.ts comes from a `node_modules` but is not declared in this type's `package.json`. See: https://github.com/Microsoft/dtslint/blob/master/docs/no-outside-dependencies.md
/home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es2015.symbol.d.ts:1:1
ERROR: 1:1 no-outside-dependencies File /home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es2015.symbol.d.ts comes from a `node_modules` but is not declared in this type's `package.json`. See: https://github.com/Microsoft/dtslint/blob/master/docs/no-outside-dependencies.md
/home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es2015.symbol.wellknown.d.ts:1:1
ERROR: 1:1 no-outside-dependencies File /home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es2015.symbol.wellknown.d.ts comes from a `node_modules` but is not declared in this type's `package.json`. See: https://github.com/Microsoft/dtslint/blob/master/docs/no-outside-dependencies.md
/home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es2016.array.include.d.ts:1:1
ERROR: 1:1 no-outside-dependencies File /home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es2016.array.include.d.ts comes from a `node_modules` but is not declared in this type's `package.json`. See: https://github.com/Microsoft/dtslint/blob/master/docs/no-outside-dependencies.md
/home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es2016.d.ts:1:1
ERROR: 1:1 no-outside-dependencies File /home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es2016.d.ts comes from a `node_modules` but is not declared in this type's `package.json`. See: https://github.com/Microsoft/dtslint/blob/master/docs/no-outside-dependencies.md
/home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es2017.d.ts:1:1
ERROR: 1:1 no-outside-dependencies File /home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es2017.d.ts comes from a `node_modules` but is not declared in this type's `package.json`. See: https://github.com/Microsoft/dtslint/blob/master/docs/no-outside-dependencies.md
/home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es2017.intl.d.ts:1:1
ERROR: 1:1 no-outside-dependencies File /home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es2017.intl.d.ts comes from a `node_modules` but is not declared in this type's `package.json`. See: https://github.com/Microsoft/dtslint/blob/master/docs/no-outside-dependencies.md
/home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es2017.object.d.ts:1:1
ERROR: 1:1 no-outside-dependencies File /home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es2017.object.d.ts comes from a `node_modules` but is not declared in this type's `package.json`. See: https://github.com/Microsoft/dtslint/blob/master/docs/no-outside-dependencies.md
/home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es2017.sharedmemory.d.ts:1:1
ERROR: 1:1 no-outside-dependencies File /home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es2017.sharedmemory.d.ts comes from a `node_modules` but is not declared in this type's `package.json`. See: https://github.com/Microsoft/dtslint/blob/master/docs/no-outside-dependencies.md
/home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es2017.string.d.ts:1:1
ERROR: 1:1 no-outside-dependencies File /home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es2017.string.d.ts comes from a `node_modules` but is not declared in this type's `package.json`. See: https://github.com/Microsoft/dtslint/blob/master/docs/no-outside-dependencies.md
/home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es2017.typedarrays.d.ts:1:1
ERROR: 1:1 no-outside-dependencies File /home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es2017.typedarrays.d.ts comes from a `node_modules` but is not declared in this type's `package.json`. See: https://github.com/Microsoft/dtslint/blob/master/docs/no-outside-dependencies.md
/home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es2018.asynciterable.d.ts:1:1
ERROR: 1:1 no-outside-dependencies File /home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es2018.asynciterable.d.ts comes from a `node_modules` but is not declared in this type's `package.json`. See: https://github.com/Microsoft/dtslint/blob/master/docs/no-outside-dependencies.md
/home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es2018.d.ts:1:1
ERROR: 1:1 no-outside-dependencies File /home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es2018.d.ts comes from a `node_modules` but is not declared in this type's `package.json`. See: https://github.com/Microsoft/dtslint/blob/master/docs/no-outside-dependencies.md
/home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es2018.intl.d.ts:1:1
ERROR: 1:1 no-outside-dependencies File /home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es2018.intl.d.ts comes from a `node_modules` but is not declared in this type's `package.json`. See: https://github.com/Microsoft/dtslint/blob/master/docs/no-outside-dependencies.md
/home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es2018.promise.d.ts:1:1
ERROR: 1:1 no-outside-dependencies File /home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es2018.promise.d.ts comes from a `node_modules` but is not declared in this type's `package.json`. See: https://github.com/Microsoft/dtslint/blob/master/docs/no-outside-dependencies.md
/home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es2018.regexp.d.ts:1:1
ERROR: 1:1 no-outside-dependencies File /home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es2018.regexp.d.ts comes from a `node_modules` but is not declared in this type's `package.json`. See: https://github.com/Microsoft/dtslint/blob/master/docs/no-outside-dependencies.md
/home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es5.d.ts:1:1
ERROR: 1:1 no-outside-dependencies File /home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.es5.d.ts comes from a `node_modules` but is not declared in this type's `package.json`. See: https://github.com/Microsoft/dtslint/blob/master/docs/no-outside-dependencies.md
/home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.esnext.intl.d.ts:1:1
ERROR: 1:1 no-outside-dependencies File /home/travis/build/DefinitelyTyped/DefinitelyTyped/node_modules/typescript/lib/lib.esnext.intl.d.ts comes from a `node_modules` but is not declared in this type's `package.json`. See: https://github.com/Microsoft/dtslint/blob/master/docs/no-outside-dependencies.md
Oops, I didn't see this issue, and tracked it at #205 instead.
Briefly, it looks like no-outside-dependencies was not running at all before 0.4.4 and didn't recognise lib files as OK to depend on. It is fixed now but I'll need to re-run all the failed builds from overnight.
| gharchive/issue | 2019-02-20T08:30:53 | 2025-04-01T04:32:46.333742 | {
"authors": [
"Jessidhia",
"sandersn"
],
"repo": "Microsoft/dtslint",
"url": "https://github.com/Microsoft/dtslint/issues/203",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
256864853 | Initialize WAS During Docker Build
To avoid WAS initialization been interrupted during docker build, Start WAS immediately after IIS is Installed and wait until reg value NanoSetup under HKLM:\SYSTEM\CurrentControlSet\Services\WAS\Parameters\ is deleted.
https://github.com/Microsoft/iis-docker/issues/47
@mcy94w,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot
@mcy94w,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot
@mcy94w,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot
| gharchive/pull-request | 2017-09-11T22:48:20 | 2025-04-01T04:32:46.337269 | {
"authors": [
"mcy94w",
"msftclas"
],
"repo": "Microsoft/iis-docker",
"url": "https://github.com/Microsoft/iis-docker/pull/49",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
330978509 | ClearType font rendering and DPI awareness
Before:
After:
Before (125% DPI):
After (125% DPI):
Since this is my first time using Rust, feel free to point out any mistake I could have done.
This pull request went mostly ignored for the 21 days it was open. @joaomoreno can we get a review?
@sylveon Not ignored... just postponed... Lots on our plate, sorry for that.
Thanks, great job!
| gharchive/pull-request | 2018-06-10T15:36:29 | 2025-04-01T04:32:46.340060 | {
"authors": [
"joaomoreno",
"sylveon"
],
"repo": "Microsoft/inno-updater",
"url": "https://github.com/Microsoft/inno-updater/pull/1",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
423913034 | Proposal: Give api to disable shadow on flyouts in 19h1+
Proposal: Give api to disable shadow on flyouts in 19h1+
Summary
I want a way to disable the shadow effects on flyouts in 19h1+
Rationale
We are using commandbarflyout, and we have custom types that expand off that of type Panel that doesn't have shadow. So want an option to disable the CommandBarflyout one as stop gap.
Functional Requirements
Important Notes
Open Questions
Are you planning to add shadows to your custom types eventually?
In the meantime does setting IsDefaultShadowEnabled=false on the FlyoutPresenter do what you want?
e.g.:
<Flyout>
<Flyout.FlyoutPresenterStyle>
<Style TargetType="FlyoutPresenter">
<Setter Property="IsDefaultShadowEnabled" Value="False" />
</Style>
</Flyout.FlyoutPresenterStyle>
</Flyout>
@ahhlun , we recommend turning on the shadow for the sub-menu using the code Jesse provided above.
@jesbis can you provide an example using c++ or c++/winrt code behind and not XAML?
The uwp doc site has a lot of setting styles through XAML but I need to do this in code behind.
I have trouble figuring out how to construct "TargetType" and how to set the Setter for the style.
To set TargetType from code in C++/WinRT you can use the xaml_typename helper.
The style setter would need to take a boxed boolean, which you can make through winrt::box_value(false).
@ahhlun , were you able to get this to work? It is preferred that we show shadow on your example case so hope you were able to handle it.
we plan to do this soon
@ahhlun, great! In that case, may I close this issue?
@ahhlun, you previously indicated you are adding shadow in this UI and I do not believe there is additional API needed here, so I am closing this issue.
| gharchive/issue | 2019-03-21T19:52:21 | 2025-04-01T04:32:46.346352 | {
"authors": [
"ahhlun",
"chigy",
"jesbis",
"jevansaks"
],
"repo": "Microsoft/microsoft-ui-xaml",
"url": "https://github.com/Microsoft/microsoft-ui-xaml/issues/468",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
221282912 | Support Connection get/setNetworkTimeout().
This is essential to minimize the effects of network partition events.
Related to #72 and #85.
Codecov Report
Merging #253 into dev will increase coverage by <.01%.
The diff coverage is 55.55%.
@@ Coverage Diff @@
## dev #253 +/- ##
============================================
+ Coverage 33.46% 33.47% +<.01%
+ Complexity 1491 1486 -5
============================================
Files 97 97
Lines 23390 23415 +25
Branches 3840 3841 +1
============================================
+ Hits 7828 7838 +10
- Misses 14001 14010 +9
- Partials 1561 1567 +6
Flag
Coverage Δ
Complexity Δ
#JDBC41
33.35% <55.55%> (-0.02%)
1478 <2> (-5)
#JDBC42
33.39% <55.55%> (+0.04%)
1481 <2> (ø)
:arrow_down:
Impacted Files
Coverage Δ
Complexity Δ
...t/sqlserver/jdbc/SQLServerConnectionPoolProxy.java
13.61% <0%> (-0.22%)
12 <0> (ø)
...in/java/com/microsoft/sqlserver/jdbc/IOBuffer.java
37.01% <100%> (+0.16%)
0 <0> (ø)
:arrow_down:
.../microsoft/sqlserver/jdbc/SQLServerConnection.java
41.27% <60%> (+0.09%)
228 <2> (-1)
:arrow_down:
src/main/java/microsoft/sql/DateTimeOffset.java
37.14% <0%> (-2.86%)
8% <0%> (-2%)
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java
24.55% <0%> (-1.12%)
39% <0%> (-3%)
...om/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java
45.05% <0%> (ø)
183% <0%> (ø)
:arrow_down:
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java
42.69% <0%> (+1.12%)
15% <0%> (+1%)
:arrow_up:
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 598a3b4...3abcebc. Read the comment docs.
@v-xiangs Review recommendations integrated.
@brettwooldridge Thank you for your contribution.
| gharchive/pull-request | 2017-04-12T14:33:06 | 2025-04-01T04:32:46.361235 | {
"authors": [
"brettwooldridge",
"codecov-io",
"v-xiangs"
],
"repo": "Microsoft/mssql-jdbc",
"url": "https://github.com/Microsoft/mssql-jdbc/pull/253",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
374047886 | Fix Geometry.point coordinates
Fixes issue #851.
According to this page, Geography::point method has the coordinates reversed (lat, long instead of the usual long, lat) compared to the other methods of inserting a Geography point. This PR aligns the driver behavior with the expected behavior.
Codecov Report
Merging #853 into dev will increase coverage by 0.31%.
The diff coverage is 100%.
@@ Coverage Diff @@
## dev #853 +/- ##
============================================
+ Coverage 48.58% 48.89% +0.31%
- Complexity 2794 2819 +25
============================================
Files 116 116
Lines 27879 27879
Branches 4651 4651
============================================
+ Hits 13545 13632 +87
Misses 12124 12124
+ Partials 2210 2123 -87
Flag
Coverage Δ
Complexity Δ
#JDBC42
48.15% <100%> (+0.16%)
2754 <1> (+8)
:arrow_up:
#JDBC43
48.8% <100%> (+0.25%)
2814 <1> (+21)
:arrow_up:
Impacted Files
Coverage Δ
Complexity Δ
...n/java/com/microsoft/sqlserver/jdbc/Geography.java
52.38% <100%> (ø)
15 <1> (ø)
:arrow_down:
...m/microsoft/sqlserver/jdbc/SQLServerResultSet.java
32.57% <0%> (-0.2%)
255% <0%> (-1%)
...n/java/com/microsoft/sqlserver/jdbc/Parameter.java
63.72% <0%> (+0.2%)
64% <0%> (ø)
:arrow_down:
...rc/main/java/com/microsoft/sqlserver/jdbc/DDC.java
45.95% <0%> (+0.21%)
107% <0%> (-1%)
:arrow_down:
...m/microsoft/sqlserver/jdbc/SQLServerStatement.java
59.8% <0%> (+0.28%)
141% <0%> (+6%)
:arrow_up:
.../microsoft/sqlserver/jdbc/SQLServerConnection.java
48.63% <0%> (+0.53%)
350% <0%> (+15%)
:arrow_up:
...n/java/com/microsoft/sqlserver/jdbc/tdsparser.java
68.96% <0%> (+0.86%)
0% <0%> (ø)
:arrow_down:
...c/main/java/com/microsoft/sqlserver/jdbc/Util.java
62.06% <0%> (+1.07%)
93% <0%> (+4%)
:arrow_up:
...om/microsoft/sqlserver/jdbc/ReaderInputStream.java
45.05% <0%> (+1.09%)
15% <0%> (ø)
:arrow_down:
...m/microsoft/sqlserver/jdbc/SQLServerException.java
78.94% <0%> (+1.5%)
33% <0%> (+2%)
:arrow_up:
... and 1 more
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e521780...a79b873. Read the comment docs.
| gharchive/pull-request | 2018-10-25T17:15:29 | 2025-04-01T04:32:46.379442 | {
"authors": [
"codecov-io",
"peterbae"
],
"repo": "Microsoft/mssql-jdbc",
"url": "https://github.com/Microsoft/mssql-jdbc/pull/853",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
83836877 | Fix #124 - include error details in mocha unit test results
Fix #124 - include error details in mocha unit test results
use the 'tap' error reporter instead of xunit because 'xunit' does not
print the trace.
We should also consider allowing people to switch use their reporter-of-choice in the future.
| gharchive/pull-request | 2015-06-02T04:44:56 | 2025-04-01T04:32:46.381055 | {
"authors": [
"mousetraps"
],
"repo": "Microsoft/nodejstools",
"url": "https://github.com/Microsoft/nodejstools/pull/161",
"license": "apache-2.0",
"license_type": "permissive",
"license_source": "bigquery"
} |
406607904 | Enabled Ninja Generator in Windows CI
Enabled Ninja Generator in Windows CI PS script and Jenkins stages.
Removed NMake Makefiles Generator as Ninja replaces this.
Renamed the 4 configurations to reflect what they are doing.
- Win 2016 Debug renamed to Win 2016 Debug Cross Compile
- Win 2016 Release renamed to Win 2016 Release Cross Compile
- Win 2016 Debug Cross Platform renamed to Win 2016 Debug Linux-Elf-Build
- Win 2016 Release Cross Platform renamed to Win 2016 Release Linux-Elf-Build
Optimized 2 of the Windows stages to not run ctest on Linux after building ELF enclaves.
bors try
bors try
bors try
@anitagov
The last CI run reported the following error:
-- The C compiler identification is Clang 7.0.1
CMake Error at C:/Program Files/CMake/share/cmake-3.13/Modules/CMakeDetermineCompilerId.cmake:802 (message):
The Clang compiler tool
"C:/Program Files/LLVM/bin/clang-7.exe"
targets the MSVC ABI but has a GNU-like command-line interface. This is
not supported. Use 'clang-cl' instead, e.g. by setting 'CC=clang-cl' in
the environment.
Call Stack (most recent call first):
C:/Program Files/CMake/share/cmake-3.13/Modules/CMakeDetermineCCompiler.cmake:113 (CMAKE_DIAGNOSE_UNSUPPORTED_CLANG)
CMakeLists.txt:28 (project)
CMake Error: CMAKE_CXX_COMPILER not set, after EnableLanguage
CMake Error: CMAKE_ASM_MASM_COMPILER not set, after EnableLanguage
-- Configuring incomplete, errors occurred!
See also "D:/Jenkins/workspace/Bors_trying/build/X64-Debug/CMakeFiles/CMakeOutput.log".
cmake failed
I took a quick look over the updated test-build-config.ps1 and I applied the following diff. After this, the build fails due to some warning treated as errors.
This is the full log of a manual run of test-build-config.ps1 with my changes applied.
You may notice the following to my test-build-config.ps1 script changes:
I removed the hard-coded PATH append:
$env:PATH += ";C:\Program Files\LLVM\bin"
This is not only a quick hack, but it's not even needed. I double checked both our CI servers, and the LLVM is already present in the system PATH. I'd recommend that you remove it in this PR since it doesn't do anything.
I set CC and CXX env variables to get pass the initial CI build error:
$env:CC="clang-cl"
$env:CXX="clang-cl"
If you think this should be set by the script, please feel free to add them to the script.
Regards,
Ionut
Thanks @ionutbalutoiu and @anakrish - I was updating the issue #1283 with my observations.
The Ninja Release built correctly and reported 2 tests as Failures (platform error). This is expected as we have never run Ninja in Release mode (reason we need Ninja in CI). I believe I saw these failures on my system too when I ran in Release mode.
Debug Mode - Why are we seeing build errors only on this platform but not on the other platform?
@anakrish - Is there a manual way to fire the Native X64 Command prompt? I am continuing to use the following to fire the Command window (same path is used for Developer Command Window and Native X64 Command prompt).
C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Auxiliary\Build\vcvars64.bat
@ionutbalutoiu - Yes, we should not be adding the LLVM bin path in the script. The platform should be configured to have this in the path. Will try with your changes to set cc and ccx. Thanks.
When you run cmake from the x64 Native Tools Command Prompt for VS 201 from build\X64-Debug directory, we should see the following:
-- The C compiler identification is MSVC 19.16.27026.1
-- The CXX compiler identification is MSVC 19.16.27026.1
-- The ASM_MASM compiler identification is MSVC
@ionutbalutoiu - Please verify if this works on the failing platform. If not, try rebooting the system. Thanks.
@anitagov
This is expected as we have never run Ninja in Release mode
The Windows workflow based on Ninja has been tested on both Debug and Release builds.
There ought not to be any Release build specific errors on CI machines due to Ninja.
@anitagov
2. Is there a manual way to fire the Native X64 Command prompt?
In interactive workflow (as opposed to scripted CI), the command prompt is launched from the Visual Studio start-menu folder. We want "x64 Native Prompt"; and that is what the CI workflow needs to use as well for consistency. Note, VS start folder has many prompts, only some work for us.
ecall_ocall and filetest fail in Release mode. I did another sandbox run and got the Debug ninja to run on the correctly configured platform. ecall_ocall failed there too with platform_error. The size of the enclave may need to be reduced further or we really need to use the Native X64 Command Prompt. Figuring a way to fire this. The path appears to be the same as the Developer Command Prompt i.e. C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Auxiliary\Build\vcvars64.bat
@anakrish - I verified that the Native X64 Command prompt and Developer Command Prompt are identical but for the title. Both execute the same command as I mentioned earlier i.e.
C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Auxiliary\Build\vcvars64.bat.
One of the CI platforms is not configured correctly and that still needs to be fixed.
bors try
bors try
bors try
Thanks to John for rebooting the Windows CI platforms but that did not help in fixing the botched Visual Studio Tools installation on one of the platforms. Found out that "where cl" returned the correct path in both the systems.
Hard-coded the CC and CXX environment variables to point to cl and get CI to work. Will trouble-shoot the faulty platform tomorrow.
bors r+
bors try
bors r+
| gharchive/pull-request | 2019-02-05T02:41:11 | 2025-04-01T04:32:46.395029 | {
"authors": [
"anakrish",
"anitagov",
"ionutbalutoiu"
],
"repo": "Microsoft/openenclave",
"url": "https://github.com/Microsoft/openenclave/pull/1415",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
366979321 | No results for multiple tags in search query
Search Engine Issue
No results are found on multiple tags in search query for "Search Tags...."
The search query with multiple tags should give results for all the tags in the search query
I noticed this to, I'm going to try and pick up this issue and get it done before hacktoberfest comes to and end ! ps. I've never worked on a node JS backend before wish me luck haha
Any luck with this issue @James-N-M ?
@mykeels I couldn't manage to get the dev environment set up I think the documentation could use a refresh. I've never done any node js development
Thanks for reporting... the underlying tag search is actually a proprietary web site, opensource.microsoft.com, I'm not sure entirely why it is linked here, but I will open a bug with that team!
Jeff
| gharchive/issue | 2018-10-04T21:32:49 | 2025-04-01T04:32:46.398749 | {
"authors": [
"James-N-M",
"jeffwilcox",
"khan0604",
"mykeels"
],
"repo": "Microsoft/opensource-portal",
"url": "https://github.com/Microsoft/opensource-portal/issues/82",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
367458477 | prometheus-deployment Insufficient memory.
I've got a 10 G machine single box for deploy pai, but keep getting
0/1 nodes are available: 1 Insufficient memory.
for prometheus deployment.
Also, when I try to start the webportal, I'm keeping get ImageInspectError for some reason. more details are:
Failed to inspect image "docker.io/openpai/webportal:latest": rpc error: code = Unknown desc = Error response from daemon: readlink /var/lib/docker/overlay2: invalid argument
Do you have any advice?
Thanks in advance
Hi @alvindaiyan ,
Which version are your using?
In our latest code we reserve memory quote for each services, so the SingleBox installation would need at least 64G memory, see [https://github.com/Microsoft/pai/wiki/Resource-Requirement](resource reuqirement).
And here's a workaround, you could set the 'requests' memory for each services, by default, the request would equal to limits, which is obvious bigger.
Take the prometheus as an example:
https://github.com/Microsoft/pai/blob/master/src/prometheus/deploy/prometheus-deployment.yaml.template#L40
resources:
limits:
memory: "256Mi"
add a 'requests' quote
requests:
memory: "26Mi"
close due to idleness.
| gharchive/issue | 2018-10-06T13:45:24 | 2025-04-01T04:32:46.403061 | {
"authors": [
"alvindaiyan",
"hao1939",
"xudifsd"
],
"repo": "Microsoft/pai",
"url": "https://github.com/Microsoft/pai/issues/1454",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
378455619 | Minecraft Update Blog Post
Hey folks,
Can someone prep and publish this blog post? @ganicke are you working/online now?
All the files are here: https://1drv.ms/f/s!AvnYExTCocXPhiP01Sti-GXR0AYd
Should be using this URL: https://makecode.com/blog/minecraft/11-07-2018 (Minecraft team will cross-link to us)
I'm adding it now.
I have your blog post at https://github.com/Microsoft/pxt/tree/minecraft-blog-11072018. Someone can make the PR and merge when you're ready to publish.
It might be helpful if there's a link to the 1.7.1 update that's mentioned towards the end.
Done
Hi again - Galen, can you add a link to the YouTube video that Sam and I just did? https://youtu.be/Lt5n8TbIK7E
Feel free to use this thumbnail for the video link (or do your own).
@Jaqster you can just put a youtube url in the markdown (on its own line) and we'll automatically show the embed.
I thought we couldn't do that in the Blog...?
AAAAARRRGGGH! You're right...
| gharchive/issue | 2018-11-07T20:26:52 | 2025-04-01T04:32:46.410804 | {
"authors": [
"Jaqster",
"abchatra",
"ganicke",
"pelikhan"
],
"repo": "Microsoft/pxt",
"url": "https://github.com/Microsoft/pxt/issues/4983",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
} |
236988319 | Missing language service features for some projects in a solution if the project is up-to-date
ref https://github.com/Microsoft/visualfsharp/issues/3054#issuecomment-302085371
In some projects nothing works at all (colors, completion, ...):
This occurs reliably in a large solution with ~60 projects, but is not reproducible when reduced.
The issue happens in multiple projects, the lowest project is one with 5 dependencies.
If I remove everything except these six projects from the solution, the error stops occurring, even though there should be no change from the view of these projects, so it is impossible for me to provide a reduced reproduction.
For me it looks like something completely unrelated in the solution fucks VS up.
This seems to be related to the up-to-date check:
If I modify a file and restart VS, stuff works.
If I build the solution and restart VS, stuff stops working. (Note that before the restart, stuff continues to work even after the build.)
maybe related: https://github.com/Microsoft/visualfsharp/issues/3221
Note: Build always works fine, this is just tooling
@0x53A I know you've said you can't make a public repro for this, but we'll really need one to make progress on it, unless we get lucky and find the bug by some other means (which is likely sooner or later)
(Also is this using latest nightly? thx)
So, I experimented a bit more.
Remember I said above that it works after a clean, and fails after a build?
I was able to reduce it to one dll with one large embedded resource (15MB). Something else in the VS stack seems to choke on that and then poisons something so that VF# fails.
If I delete the dll and restart VS, everything works.
If I keep the dll, but remove the embedded resources (using dnspy), then restart VS, everything works.
@0x53A Interesting, thanks. Can you share that repro?
No, because when I remove all other projects, the error stops happening.
The error still only happens in the large, 60 project solution.
The solution contains WinForms projects, WPF projects, WIX projects, C++/CLI projects, it must be one of these.
@0x53A Thanks. Nasty bug, we should protect F# (and Roslyn) from whatever is happening
Only F# is affected, C# does not have any issues.
Yikes, that sounds bad. cc @Pilchie this sounds troubling
@cartermp We really need a standalone repro to make progress on this - i the bug is as described it could come from any of those project flavours
Agreed. However, in the essence of narrowing the problem down...
@0x53A Is this using VS 2017 Update 2, or Update 3? About when would you say this issue started happening?
@cartermp VS 2017 Update 2. I have the latest nightly, but have also seen this issue with a colleague, who does not have the nightly.
I'm not sure when it started, at first it was only an unimportant project, so I didn't bother.
That it's now worse is probably related to something changed in our solution (added projects, added references, whatever).
I can try to check old versions from source control, but there are many external references, and some of them are not checked-in, so it may not be trivial to build a version from half a year ago.
Argh. Sorry to hear that. Maybe there's a way for someone at MS to look at your solution under an NDA or something? I honestly don't know how that process works if it exists. @Pilchie probably would know, though.
The easiest way (for me :D) would be if you could look at it on my computer through TeamViewer or something like that.
Sending it out may also be possible, but I would probably need to ask my bosses' boss.
It's interesting that we seem to be the only ones hitting this issue, either no-one uses VS2017, or this is really one specific corner case.
...or this is really one specific corner case.
It feels quite specific. But I do think people often have an option to go back to VS2015 or switch to another editor these days. Which is good...
But I do think people often have an option to go back to VS2015 ...
Not if you want intellisense for C# / F# vLatest, and C#7 >>> C#6 :\
... or switch to another editor these days ...
Rider works well. =)
I will see how hard it is to get rid of the embedded resource, maybe that will "fix" the issue.
We could either set up a OneDrive for Business link for you to upload to, or sure, we can try to get someone to remote into the machine.
It is definitely related to that one project, but it seems like it is not the embedded resource. :-\
I removed all embedded resources from the project, but the issue still occurs. Maybe what "fixed" it when I modified the dll using dnSpy was just the updated timestamp?
Maybe I can find out more tomorrow ...
So it doesn't seem to be related to anything specific:
If the project is up-to-date, nothing works.
If the project is not up-to-date, everything works.
If I do any change that causes a reload (remove/add reference for example), then colorization kicks in.
So modifying the dll with dnSpy just updated the timestamp, which caused to project to NOT be up-to-date, and "fixed" the issue, but it is not related to the embedded resource.
If the project is up-to-date, nothing works.
What this says to me is that the underlying problem is something like
the initial computation of the SourcesAndFlags for the project failed
the initial computation of the SourcesAndFlags produced a bad set of options which caused something else to fail
another error occurred which meant Roslyn decided no to list the file for analysis
or something like that. We can definitely fix this if we have a repro (a private ZIP would be enough)
@dsyme Currently I don't have any spare time to continue with this. Rider works mostly, so I'm using that, and we only have a few F# projects anyway, atm most of my time is in C#.
In a few days I will try again to a) reduce it, and b) send either the original, or the reduced solution to you.
Just to clarify for your title edit, really nothing works, it's not just colorization that's missing. And it's also not time based, if a file got into this state when it was initially loaded, then you can keep it open for hours and colorization (and other features) never appears. The only fix is to force a reload, e.g. by adding/removing a reference.
@0x53A Thanks, I totally understand. Reducing repros from problems that occur in large private solutions is super important. But also super time consuming.
If you send me the original solution privately with repro steps then I can deal with that
thanks again
@0x53A just for being sure, are there any errors shown?
@dsyme I tested it again with master+https://github.com/Microsoft/visualfsharp/pull/3328, but that did not change much.
Where can I send you a repro? I was able to reduce it a little bit.
@0x53A Thanks for the repro!
@0x53A Thanks for the ZIP, it also repros for me.
It's a very odd bug. In LanguageService.fs it seems we are now getting the list of filenames too early, and ComputeSourcesAndFlags has not yet been successfully called for the project. Then, because the project is up-to-date, it is never updated later.
This portion of code is hard - not because it is doing interesting but because it has always been fragile with lots of underlying mutable state. I'm also sure the corresponding code in the "new" project system (https://github.com/dotnet/project-system) won't have this bug.
it also repros for me.
Great!
I'm also sure the corresponding code in the "new" project system (dotnet/project-system) won't have this bug.
Even better!
Normally I would say to not waste too much time on fixing this bug, since the old project system will be obsolete soon anyway, but from what I've read, support for old-style fsproj will only come in VS.next.
( @cartermp ) ?
So if you have any hints what is so special about this project, and whether there is a workaround, that would be great.
Thank you!
We currently don't have a timeline for loading older projects in the new project system, unfortunately. Next version of VS is a target, but we don't know when that will be or what all of the work will entail (e.g., is there a one-time upgrade process? What would that look like?).
Once the new project system work is in a good enough place for us to recommend its usage officially, it may be worthwhile to manually port over the repro project. There will still be some issues (file ordering in the tree view), but I'm hopeful that these sorts of bugs will either be gone or more easily fixed.
e.g., is there a one-time upgrade process? What would that look like?
IF the new project system works well, then anone-time conversion is not an issue (at least for me). That would just be "work".
Yeah, we need to fix this baby in the old project system
@cartermp @dsyme Please note that I now also hit this issue with other solutions, for example paket.
Not sure whether that's because the issue got worse in VS15.3, or because of some recent change in the project files.
Judging from slack, @forki also hit this ;-)
@0x53A Yes I also have this on Paket.Core in the Paket solution. It is really annoying as hell.
I am seeing this too (in 15.3.5) and it is very frustrating.
The issue definitely got worse in 15.3 - I don't recall having so much trouble before.
I've actually seen this happen on small projects too. I thought it was almost random, but reading this thread gives me some hints. FWIW, I'm using 15.4 preview 2 currently, so recent changes in VS did not change this behaviour. @dsyme, did you find anything useful when you analysed this? Can we help? It's rather frustrating, so even a partial fix would be really welcome!
@abelbraaksma Part of the problem is that this isn't easily (or for that matter, reliably) reproducible. So it's going to involve figuring out a way to get a repro every time for debugging, then spelunking through the old project system to see where things are going wrong. Any number of the changes there, since 15.0, could be causing this.
Yes of course it's hard. But I think it's one of the most important things
that it works reliably.
Am 11.10.2017 18:14 schrieb "Phillip Carter" notifications@github.com:
@abelbraaksma https://github.com/abelbraaksma Part of the problem is
that this isn't easily (or for that matter, reliably) reproducible. So it's
going to involve figuring out a way to get a repro every time for
debugging, then spelunking through the old project system to see where
things are going wrong. Any number of the changes there, since 15.0, could
be causing this.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/visualfsharp/issues/3222#issuecomment-335863627,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AADgNCpONNss1q9v5yswa5n4JDzmKOyFks5srOlIgaJpZM4N-pdy
.
@cartermp Even if we cannot figure out what the cause of this is and we do not want to invest the time into debugging the root cause (because it is the old project system). It would be nice to have some kind of workaround that resets this state. The reason why this is so frustrating for users is because when you encounter this situation Visual Studio is as useless as notepad and you cannot do anything (like reloading projects/re-opening files or even restarting VS) this obviously leads to quite a bit of frustration. At least that was my experience with that issue.
Should people hit the feedback button in this situation to at least figure out a workaround when this happens? Will that provide useful insights?
that this isn't easily (or for that matter, reliably) reproducible
I can 100% reproduce it with the solution I attached above:
https://1drv.ms/u/s!AszsyODn72JQjOV8KHr1iWtGRUXjLg
open solution
open AssemblyInfo.fs and notice that everything works.
build project
close vs
reopen solution
open AssemblyInfo.fs and notice that nothing works.
Otherwise this is (with the same steps) also reproducible with the paket solution (and others).
I can reproduce it. It's likely that the file is opened faster than F# package (or whatever) is loaded.
This is an interesting bug:
Close the solution.
Open another simple one.
Everything works (!)
Close it, reopen the problematic one.
Nothing works again (!!)
OK, for this project `IProjectSite.SourceFilesOnDisk() returns empty array:
while for a "good" project it returns all source files.
FSharpProjectNode.AllChildren contains the source files:
Here
Oh wow. They talk about build - but not background build
projectSite.State = Opening
From the comment it should better be a pattern match and only select the not building case
OK, this line is called for both bad and good projects:
But for the good one it results with calling this method:
which fills source files list and everything, for the bad project it's not called.
Ideas?
Commenting one line solves the problem:
<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="15.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<!-- <Import Project="..\..\packages\FSharp.Compiler.Tools\build\FSharp.Compiler.Tools.props" Condition="Exists('..\..\packages\FSharp.Compiler.Tools\build\FSharp.Compiler.Tools.props')" Label="Paket" /> -->
<Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
<Import Project="..\..\Other\Build\TimCSDefaultSettings.proj" />
<Import Project="..\..\Other\Build\TimCSLibDefaultSettings.proj" />
<PropertyGroup>
<Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
<Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
<SchemaVersion>2.0</SchemaVersion>
<ProjectGuid>a7cdff79-0ec3-40d1-8281-7aeae67a5678</ProjectGuid>
<OutputType>Library</OutputType>
<RootNamespace>DbQueries</RootNamespace>
...
Any ideas?
@dsyme
Simpler repro steps:
Create a new library project targeting .net 4.6.1, build it, everything is good, all features work.
Add FSharp.Compiler.Tools package via VS nuget UI.
Build the project, everything is still good.
Close the solution, open it again.
Boom! Nothing works, all black source code.
Wow, good progress thanks! /cc @enricosada
Is it possible to get to the Visual Studio internal msbuild (or whatever they use internally) error? (The one which seems to happen according to the long code-comment above).
I suspect that they might not support $(MSBuildThisFileDirectory) or something funny like that. Or they expect some property to be set.
Boom! Nothing works, all black source code.
But you can still build the project successfully, correct?
Yes, it compiles successfully.
I just tried @0x53A's zip to repro. and it reproduces 100% on VS 15.5 preview1.
That said: if you clear the /obj before you start VS then everything works again. It the case of the repo the obj is custom and lies in root/BuildTemp. so you need to clear that dir.
Further testing reveals: you only need to nuke the BuildTemp\Debug\DbQueries\Debug\DbQueries.fsproj.CoreCompileInputs.cache before VS start.
Any ideas what that things does?
so that file only contains an hash. if you nuke it and rebuild the new file contains the same hash.
https://github.com/Microsoft/visualfsharp/issues/3739#issuecomment-336110300 shows that exactly the same bug is happening with new SDK projects
@davkean is this https://github.com/Microsoft/msbuild/issues/1577 related?
ping
This should have been fixed in 15.5 RTM are you still experiencing this @0x53A?
per https://github.com/Microsoft/visualfsharp/issues/3222#issuecomment-335873359:
@KevinRansom Can you take a look?
@0x53A As a workaround, remove and then add a new file.
cc @TIHan
I'll need to do more digging, but I noticed this when using @auduchinok 's sample from here: https://github.com/Microsoft/visualfsharp/issues/4104
Sometimes it will work, but when it doesn't I see there are ton of exceptions being thrown when trying to open a namespace/module. The exception says "Exception thrown: 'UndefinedName' in FSharp.Compiler.Private.dll'. The exact function name where this happens is ResolveLongIndentAsModuleOrNamespace.
Having just run into this on VS 15.6 Preview 1. Here are my repro steps.
Download and unzip this: https://github.com/Microsoft/visualfsharp/files/1545698/WebApplication1.zip
Open solution
Observe no colorization or any language service light-up.
Delete /.vs, /bin, and /obj folders.
Close and re-open project.
Observe that nothing works, and no NuGet restore has been kicked off.
Build the solution.
Observe that a NuGet restore is finally kicked off, types are resolved, and features all work as expected.
@davkean The lack of restore being kicked off threw me off.
@TIHan @cartermp This is likely us not kicking off CoreCompile because it thinks we're up-to-date. @KevinRansom implemented a workaround, but it looks like said workaround isn't working?
The real fix if the cause is that CoreCompile isn't running is to fix https://github.com/Microsoft/msbuild/issues/2442 by only running this target in full builds.
ping.
most annoying issue ever! Complete deal breaker for me to us VS
Use Rider ;-)
@cartermp @KevinRansom @davkean What's the story with this please?
@KevinRansom Didn't you add a workaround for this for F#?
Next thing on my list to look at, but yes I did.
Okay running through these repros:
The original repro from @0x53A is based on a desktop F# project file, and so the issue is likely not related.
@cartermp 's repro used netsdk, however, it is not repro with 15.6 preview 6.
@vasily-kirichenko 's repro is similarly based on a desktop F# file, and includes the community FSharp.Compiler Tools nuget package.
So ...
@davkean this is probably not on you.
Kevin
Okay .... the project file is at fault.
The F# targets are imported twice.
To get it working I:
deleted from the top of the project file.
<Import Project="..\..\packages\FSharp.Compiler.Tools\build\FSharp.Compiler.Tools.props" Condition="Exists('..\..\packages\FSharp.Compiler.Tools\build\FSharp.Compiler.Tools.props')" Label="Paket" />
Midway through the project file I then replaced this:
<Choose>
<When Condition="'$(VisualStudioVersion)' == '11.0'">
<PropertyGroup Condition=" Exists('$(MSBuildExtensionsPath32)\..\Microsoft SDKs\F#\3.0\Framework\v4.0\Microsoft.FSharp.Targets') ">
<FSharpTargetsPath Condition=" '$(FSharpTargetsPath)' == '' ">$(MSBuildExtensionsPath32)\..\Microsoft SDKs\F#\3.0\Framework\v4.0\Microsoft.FSharp.Targets"</FSharpTargetsPath>
</PropertyGroup>
</When>
<Otherwise>
<PropertyGroup Condition=" Exists('$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)\FSharp\Microsoft.FSharp.Targets') ">
<FSharpTargetsPath Condition=" '$(FSharpTargetsPath)' == '' ">$(MSBuildExtensionsPath32)\Microsoft\VisualStudio\v$(VisualStudioVersion)\FSharp\Microsoft.FSharp.Targets</FSharpTargetsPath>
</PropertyGroup>
</Otherwise>
</Choose>
with
<Import Project="..\..\packages\FSharp.Compiler.Tools\build\FSharp.Compiler.Tools.props" Condition="Exists('..\..\packages\FSharp.Compiler.Tools\build\FSharp.Compiler.Tools.props')" Label="Paket" />
Probably, the guidance to how to modify project files in order to successfully use the FSharp.Compiler.Tools nuget package should be updated.
Kevin
I propose that we start maintaining this package in this repo, similarly to how we maintain the FSharp.Core nuget package. And perhaps update the template, or add a template that creates a correctly specified project file.
Kevin
@kevinransom I can reproduce the same bug with https://github.com/fsprojects/Paket/blob/master/src/Paket.Core/Paket.Core.fsproj - but that project file looks ok, right?
And as described in https://github.com/Microsoft/visualfsharp/issues/3222#issuecomment-336101362 only deletion of obj folder solves it (temporarily)
@KevinRansom can you please check (with your modified project file):
start VS and build project
close VS
start VS and open project again
does it work?
Also, the choose block you quoted doesn't import anything, if I follow your instructions, I end up with
<PropertyGroup>
<MinimumVisualStudioVersion Condition="'$(MinimumVisualStudioVersion)' == ''">11</MinimumVisualStudioVersion>
</PropertyGroup>
<Import Project="..\..\packages\FSharp.Compiler.Tools\build\FSharp.Compiler.Tools.props" Condition="Exists('..\..\packages\FSharp.Compiler.Tools\build\FSharp.Compiler.Tools.props')" Label="Paket" />
<Import Project="$(FSharpTargetsPath)" />
<ItemGroup>
<Compile Include="AssemblyInfo.fs" />
<None Include="Script.fsx" />
<Content Include="paket.references" />
</ItemGroup>
Is that correct?
@0x53A
For the repro supplied the project file becomes:
This allows msbuild to set the FSharp build targets to load to :
FSharpTargetsPath = C:\temp\New folder (2)\Repro\packages\FSharp.Compiler.Tools\build\../tools/Microsoft.FSharp.Targets
<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="15.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
<Import Project="..\..\Other\Build\TimCSDefaultSettings.proj" />
<Import Project="..\..\Other\Build\TimCSLibDefaultSettings.proj" />
<PropertyGroup>
<Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
<Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
<SchemaVersion>2.0</SchemaVersion>
<ProjectGuid>a7cdff79-0ec3-40d1-8281-7aeae67a5678</ProjectGuid>
<OutputType>Library</OutputType>
<RootNamespace>DbQueries</RootNamespace>
<AssemblyName>Precast.DbQueries</AssemblyName>
<Name>DbQueries</Name>
<DocumentationFile>$(OutputPath)$(AssemblyName).XML</DocumentationFile>
</PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' ">
<DebugSymbols>true</DebugSymbols>
<DebugType>full</DebugType>
<Optimize>false</Optimize>
<Tailcalls>false</Tailcalls>
<DefineConstants>DEBUG;TRACE</DefineConstants>
<WarningLevel>3</WarningLevel>
</PropertyGroup>
<PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
<DebugType>pdbonly</DebugType>
<Optimize>true</Optimize>
<Tailcalls>true</Tailcalls>
<DefineConstants>TRACE</DefineConstants>
<WarningLevel>3</WarningLevel>
</PropertyGroup>
<PropertyGroup>
<MinimumVisualStudioVersion Condition="'$(MinimumVisualStudioVersion)' == ''">11</MinimumVisualStudioVersion>
</PropertyGroup>
<Import Project="..\..\packages\FSharp.Compiler.Tools\build\FSharp.Compiler.Tools.props" Condition="Exists('..\..\packages\FSharp.Compiler.Tools\build\FSharp.Compiler.Tools.props')" Label="Paket" />
<Import Project="$(FSharpTargetsPath)" />
<ItemGroup>
<Compile Include="AssemblyInfo.fs" />
<None Include="Script.fsx" />
<Content Include="paket.references" />
</ItemGroup>
<ItemGroup>
<Reference Include="mscorlib" />
<Reference Include="System" />
<Reference Include="System.Core" />
<Reference Include="System.Data" />
<Reference Include="System.Numerics" />
<Reference Include="System.Transactions" />
<Reference Include="System.Xml" />
</ItemGroup>
<!-- To modify your build process, add your task inside one of the targets below and uncomment it.
Other similar extension points exist, see Microsoft.Common.targets.
<Target Name="BeforeBuild">
</Target>
<Target Name="AfterBuild">
</Target>
-->
<Import Project="..\..\.paket\paket.targets" />
<Choose>
<When Condition="$(TargetFrameworkIdentifier) == '.NETFramework' And $(TargetFrameworkVersion) == 'v4.6.1'">
<ItemGroup>
<Reference Include="FSharp.Core">
<HintPath>..\..\packages\FSharp.Core\lib\net40\FSharp.Core.dll</HintPath>
<Private>True</Private>
<Paket>True</Paket>
</Reference>
</ItemGroup>
</When>
</Choose>
<Choose>
<When Condition="$(TargetFrameworkIdentifier) == '.NETFramework' And $(TargetFrameworkVersion) == 'v4.6.1'" />
</Choose>
<Choose>
<When Condition="$(TargetFrameworkIdentifier) == '.NETFramework' And $(TargetFrameworkVersion) == 'v4.6.1'">
<ItemGroup>
<Reference Include="System.ValueTuple">
<HintPath>..\..\packages\System.ValueTuple\lib\netstandard1.0\System.ValueTuple.dll</HintPath>
<Private>True</Private>
<Paket>True</Paket>
</Reference>
</ItemGroup>
</When>
</Choose>
</Project>
@0x53A This repro uses Tools 4.1.7. That doesn't have the fix. When I copied the latest fsharp compiler and targets to the package directory for the compiler it worked.
I note that someone has published 10.0.1 as a nugget package. That set of tools should have the correct fix. Would you like to try with a more recent compiler?
@0x53A what I mean is, try the project when using the 10.0.1 nuget package for F#.
https://www.nuget.org/packages/FSharp.Compiler.Tools/
It has a targets file with the fix:
https://github.com/Microsoft/visualfsharp/blob/dev15.6/src/fsharp/FSharp.Build/Microsoft.FSharp.Targets#L359
Just to say that I remember seeing this bug with bin/obj folders. I'm pretty certain it was anything to do with FCT though since I recall it in much smaller projects that didn't use FCT. @forki also said in private DM that he thought it was nothing to do with FCT - it was happening all the time for him - and he stopped using VS on those projects as a result.
But that's just all anecdotal. We need a repro.
The reliable repro on this issue involves FCT, so it sounds like the issue is resolved as far as that is concerned.
@forki's issues and what you have seen are likely orthagonal issues with /bin and /obj as it relates to the new project system's up to date checker. @KevinRansom has since submitted a fix for that, but it's likely that issues unrelated to FCT lie there and not here.
I can still reproduce it with FCT 10.0.1.
But there was one change, now VS crashes hard ;D
I still see the isue in 15.6.3 - sigh
@forki quoting @KevinRansom 👍
It won't make it into 15.6, but should first appear in a 15.7 preview when they come on stream.
Just saw it again with 15.7.4 on paket solution
Steffen, you know better than to comment on old bugs. File a new bug with either clear repro steps or at least a snapshot of the project folder in the broken state.
| gharchive/issue | 2017-06-19T18:59:30 | 2025-04-01T04:32:46.512100 | {
"authors": [
"0x53A",
"KevinRansom",
"Pilchie",
"TIHan",
"abelbraaksma",
"cartermp",
"cata",
"davkean",
"dsyme",
"forki",
"matthid",
"realvictorprm",
"vasily-kirichenko"
],
"repo": "Microsoft/visualfsharp",
"url": "https://github.com/Microsoft/visualfsharp/issues/3222",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
320593558 | Cannot build visualfsharp
So after my PC broke again I've cracked and decided to just do all my dev work on an Azure instance. I've got VS 2017 installed with the necessary workloads, and I've got visualfsharp checked out. For the life of me I can't get it to build:
build.cmd vs debug
Results in 54 errors:
"C:\Code\visualfsharp\build-everything.proj" (default target) (1) ->
"C:\Code\visualfsharp\vsintegration\fsharp-vsintegration-src-build.proj" (Build target) (10) ->
"C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Project\ProjectSystem.Base.csproj" (Build target) (18) ->
(CoreCompile target) ->
AssemblyInfo.cs(9,41): error CS0433: The type 'ProvideCodeBaseAttribute' exists in both 'Microsoft.VisualStudio.Shell.14.0
, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0
.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Proj
ect\ProjectSystem.Base.csproj]
AssemblyInfo.cs(9,57): error CS0246: The type or namespace name 'CodeBase' could not be found (are you missing a using dir
ective or an assembly reference?) [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Project\ProjectSystem.Ba
se.csproj]
Automation\OAFileItem.cs(14,44): error CS0433: The type 'VSConstants' exists in both 'Microsoft.VisualStudio.Shell.14.0, V
ersion=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0,
Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Project
\ProjectSystem.Base.csproj]
Automation\VSProject\OAReferences.cs(9,45): error CS0433: The type 'ErrorHandler' exists in both 'Microsoft.VisualStudio.S
hell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Versi
on=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.
Base\Project\ProjectSystem.Base.csproj]
FileNode.cs(20,45): error CS0433: The type 'VSConstants' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0
.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neut
ral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Project\ProjectSyste
m.Base.csproj]
FileNode.cs(19,43): error CS0433: The type 'VSConstants' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0
.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neut
ral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Project\ProjectSyste
m.Base.csproj]
FolderNode.cs(18,45): error CS0433: The type 'VSConstants' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0
.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=ne
utral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Project\ProjectSys
tem.Base.csproj]
FolderNode.cs(17,43): error CS0433: The type 'VSConstants' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0
.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=ne
utral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Project\ProjectSys
tem.Base.csproj]
HierarchyNode.cs(25,45): error CS0433: The type 'VSConstants' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=1
4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture
=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Project\Project
System.Base.csproj]
HierarchyNode.cs(24,43): error CS0433: The type 'VSConstants' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=1
4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture
=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Project\Project
System.Base.csproj]
Interfaces.cs(9,45): error CS0433: The type 'VSConstants' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.
0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neu
tral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Project\ProjectSyst
em.Base.csproj]
Interfaces.cs(8,43): error CS0433: The type 'VSConstants' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.
0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neu
tral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Project\ProjectSyst
em.Base.csproj]
LinkedFileNode.cs(19,45): error CS0433: The type 'VSConstants' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=
14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Cultur
e=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Project\Projec
tSystem.Base.csproj]
LinkedFileNode.cs(18,43): error CS0433: The type 'VSConstants' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=
14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Cultur
e=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Project\Projec
tSystem.Base.csproj]
ProjectNode.cs(31,45): error CS0433: The type 'ErrorHandler' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14
.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=
neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Project\ProjectS
ystem.Base.csproj]
ProjectNode.cs(30,44): error CS0433: The type 'VSConstants' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.
0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=n
eutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Project\ProjectSy
stem.Base.csproj]
ProjectNode.cs(29,45): error CS0433: The type 'VSConstants' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.
0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=n
eutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Project\ProjectSy
stem.Base.csproj]
ProjectNode.cs(28,43): error CS0433: The type 'VSConstants' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.
0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=n
eutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Project\ProjectSy
stem.Base.csproj]
ProjectReferenceNode.cs(19,43): error CS0433: The type 'Task' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=1
4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture
=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Project\Project
System.Base.csproj]
ProjectReferenceNode.cs(18,44): error CS0433: The type 'VSConstants' exists in both 'Microsoft.VisualStudio.Shell.14.0, Ve
rsion=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0,
Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Project\
ProjectSystem.Base.csproj]
PropertiesEditorLauncher.cs(14,45): error CS0433: The type 'ErrorHandler' exists in both 'Microsoft.VisualStudio.Shell.14.
0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.
0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Pro
ject\ProjectSystem.Base.csproj]
ReferenceContainerNode.cs(19,45): error CS0433: The type 'VSConstants' exists in both 'Microsoft.VisualStudio.Shell.14.0,
Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0
, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Projec
t\ProjectSystem.Base.csproj]
ReferenceContainerNode.cs(18,43): error CS0433: The type 'VSConstants' exists in both 'Microsoft.VisualStudio.Shell.14.0,
Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0
, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Projec
t\ProjectSystem.Base.csproj]
ReferenceNode.cs(19,45): error CS0433: The type 'VSConstants' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=1
4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture
=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Project\Project
System.Base.csproj]
ReferenceNode.cs(18,43): error CS0433: The type 'VSConstants' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=1
4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture
=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Project\Project
System.Base.csproj]
UIThread.cs(21,46): error CS0433: The type 'VsShellUtilities' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=1
4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture
=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Project\Project
System.Base.csproj]
Utilities.cs(30,49): error CS0433: The type 'VSRegistry' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0
.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neut
ral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Project\ProjectSyste
m.Base.csproj]
Utilities.cs(2,14): error CS0430: The extern alias 'Shell14' was not specified in a /reference option [C:\Code\visualfshar
p\vsintegration\src\FSharp.ProjectSystem.Base\Project\ProjectSystem.Base.csproj]
ProjectFactory.cs(22,82): error CS0433: The type 'FlavoredProjectFactoryBase' exists in both 'Microsoft.VisualStudio.Shell
.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=1
5.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base
\Project\ProjectSystem.Base.csproj]
ProjectFactory.cs(32,45): error CS0433: The type 'Package' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0
.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=ne
utral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Project\ProjectSys
tem.Base.csproj]
ProjectFactory.cs(95,33): error CS0115: 'ProjectFactory.CreateProject(string, string, string, uint, ref Guid, out IntPtr,
out int)': no suitable method found to override [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Project\Pr
ojectSystem.Base.csproj]
ProjectFactory.cs(133,35): error CS0115: 'ProjectFactory.PreCreateForOuter(IntPtr)': no suitable method found to override
[C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Project\ProjectSystem.Base.csproj]
ProjectFactory.cs(157,35): error CS0115: 'ProjectFactory.ProjectTypeGuids(string)': no suitable method found to override [
C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Project\ProjectSystem.Base.csproj]
ProjectFactory.cs(74,60): error CS0433: The type 'Package' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0
.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=ne
utral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Project\ProjectSys
tem.Base.csproj]
ProjectFactory.cs(26,40): error CS0433: The type 'Package' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0
.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=ne
utral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Project\ProjectSys
tem.Base.csproj]
ProjectPackage.cs(23,73): error CS0433: The type 'Package' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0
.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=ne
utral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Project\ProjectSys
tem.Base.csproj]
ProjectPackage.cs(41,33): error CS0115: 'ProjectPackage.Initialize()': no suitable method found to override [C:\Code\visua
lfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Project\ProjectSystem.Base.csproj]
ProjectPackage.cs(56,33): error CS0115: 'ProjectPackage.Dispose(bool)': no suitable method found to override [C:\Code\visu
alfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Project\ProjectSystem.Base.csproj]
ProjectReferenceNode.cs(30,23): error CS0433: The type 'Task' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=1
4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture
=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Project\Project
System.Base.csproj]
PropertiesEditorLauncher.cs(26,41): error CS0433: The type 'ServiceProvider' exists in both 'Microsoft.VisualStudio.Shell.
14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15
.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\
Project\ProjectSystem.Base.csproj]
PropertiesEditorLauncher.cs(24,17): error CS0433: The type 'ServiceProvider' exists in both 'Microsoft.VisualStudio.Shell.
14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15
.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\
Project\ProjectSystem.Base.csproj]
SelectionListener.cs(67,16): error CS0433: The type 'ServiceProvider' exists in both 'Microsoft.VisualStudio.Shell.14.0, V
ersion=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0,
Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Project
\ProjectSystem.Base.csproj]
SelectionListener.cs(37,34): error CS0433: The type 'ServiceProvider' exists in both 'Microsoft.VisualStudio.Shell.14.0, V
ersion=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0,
Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Project
\ProjectSystem.Base.csproj]
SelectionListener.cs(30,17): error CS0433: The type 'ServiceProvider' exists in both 'Microsoft.VisualStudio.Shell.14.0, V
ersion=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0,
Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Project
\ProjectSystem.Base.csproj]
ProjectNode.cs(613,24): error CS0433: The type 'ErrorListProvider' exists in both 'Microsoft.VisualStudio.Shell.14.0, Vers
ion=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Cu
lture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Project\Pr
ojectSystem.Base.csproj]
ProjectNode.cs(962,45): error CS0433: The type 'Url' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0,
Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral,
PublicKeyToken=b03f5f7f11d50a3a' [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Project\ProjectSystem.Ba
se.csproj]
HierarchyNode.cs(85,17): error CS0433: The type 'EventSinkCollection' exists in both 'Microsoft.VisualStudio.Shell.14.0, V
ersion=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0,
Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Project
\ProjectSystem.Base.csproj]
ConfigProvider.cs(33,17): error CS0433: The type 'EventSinkCollection' exists in both 'Microsoft.VisualStudio.Shell.14.0,
Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0
, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Projec
t\ProjectSystem.Base.csproj]
VsCommands.cs(28,22): error CS0433: The type 'VSConstants' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0
.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=ne
utral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Project\ProjectSys
tem.Base.csproj]
VsCommands.cs(28,76): error CS0433: The type 'VSConstants' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0
.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=ne
utral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Project\ProjectSys
tem.Base.csproj]
ProjectNode.cs(494,23): error CS0433: The type 'ErrorListProvider' exists in both 'Microsoft.VisualStudio.Shell.14.0, Vers
ion=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Cu
lture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Project\Pr
ojectSystem.Base.csproj]
ProjectNode.cs(500,46): error CS0433: The type 'Url' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0,
Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral,
PublicKeyToken=b03f5f7f11d50a3a' [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Project\ProjectSystem.Ba
se.csproj]
DataObject.cs(137,17): error CS0433: The type 'EventSinkCollection' exists in both 'Microsoft.VisualStudio.Shell.14.0, Ver
sion=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, C
ulture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Project\P
rojectSystem.Base.csproj]
ProjectConfig.cs(1712,9): error CS0433: The type 'EventSinkCollection' exists in both 'Microsoft.VisualStudio.Shell.14.0,
Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0
, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Code\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Projec
t\ProjectSystem.Base.csproj]
10 Warning(s)
54 Error(s)
Time Elapsed 00:03:10.17
Error build failed
I've done a fresh checkout, git clean -fdX, the usual - what am I doing wrong? 😢
Is this on master branch?
Maybe you're missing this:
https://github.com/Microsoft/visualfsharp/blob/4d75decc7b1e71879c305539c7b8af0f15041a04/vsintegration/src/FSharp.ProjectSystem.Base/Project/ProjectSystem.Base.csproj#L75-L83
@saul I cannot reproduce this as of this morning on latest master.
@dsyme this is just using build.cmd on a clean checkout.
Yes but do you run it from vs 2017 developer command prompt with admin?
Oh sorry, yes - administrator 2017 dev command prompt.
@brettfo have you seen this?
@saul Can you check that you have the changes that @majocha mentioned a few comments above? If you do have those changes can you experiment with the BeforeTargets attribute? Maybe having that target trigger before ResolveAssemblyReferences might change things.
Updating to 15.7 and doing more merges from master seemed to fix this - strange.
Now I can repro this. Clean install of Windows + VS 15.7.3 with master freshly cloned.
@majocha
Oh grief … I will take a look.
git clean -xdf
build vs
build vs debug
no errors (in an ordinary cmd with adm privileges)
The alias is not being set reliably?
Utilities.cs(2,14): error CS0430: The extern alias 'Shell14' was not specified in a /reference option
It seems this happens on fresh installs of Visual Studio. Crazy strange.
Grr!!!! trying to repro this is hard ... at least I have failed miserably.
However, there is a possibility that the HACK_AddAliasToMicrosoftVisualStudioShell140 is specified a bit loosely and it may be that msbuild, performs it before the ResolveAssemblies task. Also, the msbuild team said when reviewing a previous PR that update in targets was a bit iffy. It is supposed to work, but they had a bug, which caused it to not work correctly. We have never seen it not work in our uses, however, it may be that you are seeing that and so ...
@majocha if you are still seeing the error, could you try this:
<Target Name="HACK_AddAliasToMicrosoftVisualStudioShell140" AfterTargets="FindReferenceAssembliesForReferences" BeforeTargets="CoreCompile">
<ItemGroup>
<!--
We require a reference to Microsoft.VisualStudio.Shell.14.0.dll, but that causes some issues with duplicate type
names. The ~hack~ fix is to include the package reference and ensure the Aliases metadata gets set afterwards.
-->
<ReferencePathWithRefAssemblies Aliases="Shell14" Condition="'%(ReferencePathWithRefAssemblies.NuGetPackageId)' == 'Microsoft.VisualStudio.Shell.14.0'" />
</ItemGroup>
</Target>
@KevinRansom it didn't help. 😞
I'll try a official developer VM later to get a reproducible scenario.
@majocha
Can you please try:
msbuild /t:Rebuild /v:diag /p:Configuration=release /p:TArgetDotnet{rofile=net40 vsintegration\src\FSharp.ProjectSystem.Base\Project\ProjectSystem.Base.csproj >log
please and post the log back here, I can take a look at the log, see what can be seen, thanks.
Kevin
@KevinRansom done! log gist , it's largish.
@KevinRansom
I added UWP workflow and it builds fine now 🍾 😄. Strange.
Tried the developer VM and it worked, so I was trying to recreate the same environment on my desktop, hence the idea.
I managed to reproduce this with a fresh VS 2017 community install. However, installing "Universal Windows Platform development" workload made it work.
That's a regression, then. This used to be required due to needing the Windows 10 SDK, but we shouldn't need that anymore. I wonder what the UWP workload installs that makes things good on our end.
I'll close this out. I recently installed VS with only the .NET Desktop workload + F# desktop support and could build the tools with that.
I'm seeing the same issue with the latest version of master. I've tried the suggestions mentioned above but I still get the same error.
Running build.cmd vs debug from Administrator Developer Command Prompt VS 2017
Here is the error log,
Build FAILED.
C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\src\FSharp.Editor\FSharp.Editor.fsproj : warning NU1605: Detected package downgrade: Microsoft.VisualStudio.Language.Sta
ndardClassification from 15.8.238-preview to 15.6.27740. Reference the package directly from the project to select a different version.
C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\src\FSharp.Editor\FSharp.Editor.fsproj : warning NU1605: FSharp.Editor -> Microsoft.CodeAnalysis.EditorFeatures 2.9.0-b
eta8-63208-01 -> Microsoft.VisualStudio.Language.StandardClassification (>= 15.8.238-preview)
C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\src\FSharp.Editor\FSharp.Editor.fsproj : warning NU1605: FSharp.Editor -> Microsoft.VisualStudio.Language.StandardClass
ification (>= 15.6.27740)
C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\src\FSharp.Editor\FSharp.Editor.fsproj : warning NU1605: Detected package downgrade: Microsoft.VisualStudio.Language.Int
ellisense from 15.8.238-preview to 15.6.27740. Reference the package directly from the project to select a different version.
C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\src\FSharp.Editor\FSharp.Editor.fsproj : warning NU1605: FSharp.Editor -> Microsoft.CodeAnalysis.EditorFeatures 2.9.0-b
eta8-63208-01 -> Microsoft.VisualStudio.Language.Intellisense (>= 15.8.238-preview)
C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\src\FSharp.Editor\FSharp.Editor.fsproj : warning NU1605: FSharp.Editor -> Microsoft.VisualStudio.Language.Intellisense
(>= 15.6.27740)
C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\src\FSharp.LanguageService\FSharp.LanguageService.fsproj : warning NU1603: Microsoft.VisualStudio.Language.Intellisense
15.8.525 depends on Microsoft.VisualStudio.ImageCatalog (>= 15.8.27731) but Microsoft.VisualStudio.ImageCatalog 15.8.27731 was not found. An approximate best match of Microsoft.Vi
sualStudio.ImageCatalog 15.8.27828 was resolved.
C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\src\FSharp.LanguageService\FSharp.LanguageService.fsproj : warning NU1603: Microsoft.CodeAnalysis.EditorFeatures 2.9.0-b
eta8-63208-01 depends on Microsoft.VisualStudio.Language.Intellisense (>= 15.8.238-preview) but Microsoft.VisualStudio.Language.Intellisense 15.8.238-preview was not found. An app
roximate best match of Microsoft.VisualStudio.Language.Intellisense 15.8.525 was resolved.
C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\src\FSharp.LanguageService\FSharp.LanguageService.fsproj : warning NU1603: Microsoft.CodeAnalysis.EditorFeatures 2.9.0-b
eta8-63208-01 depends on Microsoft.VisualStudio.Language.StandardClassification (>= 15.8.238-preview) but Microsoft.VisualStudio.Language.StandardClassification 15.8.238-preview w
as not found. An approximate best match of Microsoft.VisualStudio.Language.StandardClassification 15.8.525 was resolved.
C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\src\FSharp.LanguageService\FSharp.LanguageService.fsproj : warning NU1603: Microsoft.VisualStudio.Language 15.8.525 depe
nds on StreamJsonRpc (>= 1.3.6) but StreamJsonRpc 1.3.6 was not found. An approximate best match of StreamJsonRpc 1.3.23 was resolved.
AssemblyInfo.cs(9,41): error CS0433: The type 'ProvideCodeBaseAttribute' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5
f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegratio
n\src\FSharp.ProjectSystem.Base\Project\ProjectSystem.Base.csproj]
AssemblyInfo.cs(9,57): error CS0246: The type or namespace name 'CodeBase' could not be found (are you missing a using directive or an assembly reference?) [C:\Users\Oskar\Documen
ts\GitHub\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Project\ProjectSystem.Base.csproj]
Automation\OAFileItem.cs(14,44): error CS0433: The type 'VSConstants' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f
11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\s
rc\FSharp.ProjectSystem.Base\Project\ProjectSystem.Base.csproj]
Automation\VSProject\OAReferences.cs(9,45): error CS0433: The type 'ErrorHandler' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyTo
ken=b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsi
ntegration\src\FSharp.ProjectSystem.Base\Project\ProjectSystem.Base.csproj]
FileNode.cs(20,45): error CS0433: The type 'VSConstants' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and
'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\src\FSharp.Pro
jectSystem.Base\Project\ProjectSystem.Base.csproj]
FileNode.cs(19,43): error CS0433: The type 'VSConstants' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and
'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\src\FSharp.Pro
jectSystem.Base\Project\ProjectSystem.Base.csproj]
FolderNode.cs(18,45): error CS0433: The type 'VSConstants' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' a
nd 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\src\FSharp.P
rojectSystem.Base\Project\ProjectSystem.Base.csproj]
FolderNode.cs(17,43): error CS0433: The type 'VSConstants' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' a
nd 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\src\FSharp.P
rojectSystem.Base\Project\ProjectSystem.Base.csproj]
HierarchyNode.cs(25,45): error CS0433: The type 'VSConstants' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a
' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\src\FShar
p.ProjectSystem.Base\Project\ProjectSystem.Base.csproj]
HierarchyNode.cs(24,43): error CS0433: The type 'VSConstants' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a
' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\src\FShar
p.ProjectSystem.Base\Project\ProjectSystem.Base.csproj]
Interfaces.cs(9,45): error CS0433: The type 'VSConstants' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' an
d 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\src\FSharp.Pr
ojectSystem.Base\Project\ProjectSystem.Base.csproj]
Interfaces.cs(8,43): error CS0433: The type 'VSConstants' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' an
d 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\src\FSharp.Pr
ojectSystem.Base\Project\ProjectSystem.Base.csproj]
LinkedFileNode.cs(19,45): error CS0433: The type 'VSConstants' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3
a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\src\FSha
rp.ProjectSystem.Base\Project\ProjectSystem.Base.csproj]
LinkedFileNode.cs(18,43): error CS0433: The type 'VSConstants' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3
a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\src\FSha
rp.ProjectSystem.Base\Project\ProjectSystem.Base.csproj]
ProjectNode.cs(31,45): error CS0433: The type 'ErrorHandler' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'
and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\src\FSharp
.ProjectSystem.Base\Project\ProjectSystem.Base.csproj]
ProjectNode.cs(30,44): error CS0433: The type 'VSConstants' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'
and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\src\FSharp.
ProjectSystem.Base\Project\ProjectSystem.Base.csproj]
ProjectNode.cs(29,45): error CS0433: The type 'VSConstants' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'
and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\src\FSharp.
ProjectSystem.Base\Project\ProjectSystem.Base.csproj]
ProjectNode.cs(28,43): error CS0433: The type 'VSConstants' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'
and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\src\FSharp.
ProjectSystem.Base\Project\ProjectSystem.Base.csproj]
ProjectReferenceNode.cs(19,43): error CS0433: The type 'Task' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a
' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\src\FShar
p.ProjectSystem.Base\Project\ProjectSystem.Base.csproj]
ProjectReferenceNode.cs(18,44): error CS0433: The type 'VSConstants' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f1
1d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\sr
c\FSharp.ProjectSystem.Base\Project\ProjectSystem.Base.csproj]
PropertiesEditorLauncher.cs(14,45): error CS0433: The type 'ErrorHandler' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f
5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegrati
on\src\FSharp.ProjectSystem.Base\Project\ProjectSystem.Base.csproj]
ReferenceContainerNode.cs(19,45): error CS0433: The type 'VSConstants' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7
f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration
src\FSharp.ProjectSystem.Base\Project\ProjectSystem.Base.csproj]
ReferenceContainerNode.cs(18,43): error CS0433: The type 'VSConstants' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7
f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration
src\FSharp.ProjectSystem.Base\Project\ProjectSystem.Base.csproj]
ReferenceNode.cs(19,45): error CS0433: The type 'VSConstants' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a
' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\src\FShar
p.ProjectSystem.Base\Project\ProjectSystem.Base.csproj]
ReferenceNode.cs(18,43): error CS0433: The type 'VSConstants' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a
' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\src\FShar
p.ProjectSystem.Base\Project\ProjectSystem.Base.csproj]
UIThread.cs(21,46): error CS0433: The type 'VsShellUtilities' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a
' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\src\FShar
p.ProjectSystem.Base\Project\ProjectSystem.Base.csproj]
Utilities.cs(30,49): error CS0433: The type 'VSRegistry' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and
'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\src\FSharp.Pro
jectSystem.Base\Project\ProjectSystem.Base.csproj]
Utilities.cs(2,14): error CS0430: The extern alias 'Shell14' was not specified in a /reference option [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\src\FSharp.Projec
tSystem.Base\Project\ProjectSystem.Base.csproj]
ProjectFactory.cs(22,82): error CS0433: The type 'FlavoredProjectFactoryBase' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=
b03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsinteg
ration\src\FSharp.ProjectSystem.Base\Project\ProjectSystem.Base.csproj]
ProjectPackage.cs(23,73): error CS0433: The type 'Package' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' a
nd 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\src\FSharp.P
rojectSystem.Base\Project\ProjectSystem.Base.csproj]
ProjectFactory.cs(30,45): error CS0433: The type 'Package' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' a
nd 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\src\FSharp.P
rojectSystem.Base\Project\ProjectSystem.Base.csproj]
ProjectPackage.cs(41,33): error CS0115: 'ProjectPackage.Initialize()': no suitable method found to override [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\src\FSharp.
ProjectSystem.Base\Project\ProjectSystem.Base.csproj]
ProjectPackage.cs(56,33): error CS0115: 'ProjectPackage.Dispose(bool)': no suitable method found to override [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\src\FSharp
.ProjectSystem.Base\Project\ProjectSystem.Base.csproj]
ProjectReferenceNode.cs(30,23): error CS0433: The type 'Task' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a
' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\src\FShar
p.ProjectSystem.Base\Project\ProjectSystem.Base.csproj]
PropertiesEditorLauncher.cs(26,41): error CS0433: The type 'ServiceProvider' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b
03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegr
ation\src\FSharp.ProjectSystem.Base\Project\ProjectSystem.Base.csproj]
PropertiesEditorLauncher.cs(24,17): error CS0433: The type 'ServiceProvider' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b
03f5f7f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegr
ation\src\FSharp.ProjectSystem.Base\Project\ProjectSystem.Base.csproj]
ProjectFactory.cs(93,33): error CS0115: 'ProjectFactory.CreateProject(string, string, string, uint, ref Guid, out IntPtr, out int)': no suitable method found to override [C:\Users
\Oskar\Documents\GitHub\visualfsharp\vsintegration\src\FSharp.ProjectSystem.Base\Project\ProjectSystem.Base.csproj]
ProjectFactory.cs(173,35): error CS0115: 'ProjectFactory.PreCreateForOuter(IntPtr)': no suitable method found to override [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegrati
on\src\FSharp.ProjectSystem.Base\Project\ProjectSystem.Base.csproj]
ProjectFactory.cs(258,35): error CS0115: 'ProjectFactory.ProjectTypeGuids(string)': no suitable method found to override [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegratio
n\src\FSharp.ProjectSystem.Base\Project\ProjectSystem.Base.csproj]
ProjectFactory.cs(72,60): error CS0433: The type 'Package' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' a
nd 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\src\FSharp.P
rojectSystem.Base\Project\ProjectSystem.Base.csproj]
ProjectFactory.cs(24,46): error CS0433: The type 'Package' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' a
nd 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\src\FSharp.P
rojectSystem.Base\Project\ProjectSystem.Base.csproj]
ConfigProvider.cs(33,17): error CS0433: The type 'EventSinkCollection' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7
f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration
src\FSharp.ProjectSystem.Base\Project\ProjectSystem.Base.csproj]
SelectionListener.cs(67,16): error CS0433: The type 'ServiceProvider' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f
11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\s
rc\FSharp.ProjectSystem.Base\Project\ProjectSystem.Base.csproj]
SelectionListener.cs(37,34): error CS0433: The type 'ServiceProvider' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f
11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\s
rc\FSharp.ProjectSystem.Base\Project\ProjectSystem.Base.csproj]
SelectionListener.cs(30,17): error CS0433: The type 'ServiceProvider' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f
11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\s
rc\FSharp.ProjectSystem.Base\Project\ProjectSystem.Base.csproj]
VsCommands.cs(28,22): error CS0433: The type 'VSConstants' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' a
nd 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\src\FSharp.P
rojectSystem.Base\Project\ProjectSystem.Base.csproj]
HierarchyNode.cs(85,17): error CS0433: The type 'EventSinkCollection' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f
11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\s
rc\FSharp.ProjectSystem.Base\Project\ProjectSystem.Base.csproj]
DataObject.cs(137,17): error CS0433: The type 'EventSinkCollection' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11
d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\src
\FSharp.ProjectSystem.Base\Project\ProjectSystem.Base.csproj]
VsCommands.cs(28,76): error CS0433: The type 'VSConstants' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' a
nd 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\src\FSharp.P
rojectSystem.Base\Project\ProjectSystem.Base.csproj]
ProjectNode.cs(611,24): error CS0433: The type 'ErrorListProvider' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d
50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\src
FSharp.ProjectSystem.Base\Project\ProjectSystem.Base.csproj]
ProjectNode.cs(960,45): error CS0433: The type 'Url' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Mi
crosoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\src\FSharp.Project
System.Base\Project\ProjectSystem.Base.csproj]
ProjectConfig.cs(1711,9): error CS0433: The type 'EventSinkCollection' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7
f11d50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration
src\FSharp.ProjectSystem.Base\Project\ProjectSystem.Base.csproj]
ProjectNode.cs(492,23): error CS0433: The type 'ErrorListProvider' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d
50a3a' and 'Microsoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\src
FSharp.ProjectSystem.Base\Project\ProjectSystem.Base.csproj]
ProjectNode.cs(498,46): error CS0433: The type 'Url' exists in both 'Microsoft.VisualStudio.Shell.14.0, Version=14.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' and 'Mi
crosoft.VisualStudio.Shell.15.0, Version=15.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' [C:\Users\Oskar\Documents\GitHub\visualfsharp\vsintegration\src\FSharp.Project
System.Base\Project\ProjectSystem.Base.csproj]
6 Warning(s)
54 Error(s)
@brokenprogrammer I just verified on two machines that I can build latest master. I have installed:
.NET Desktop workload with F# Desktop support
ASP.NET workload (just for the web tooling, not related to work in this repo)
Visual Studio Extensibility workload
Then build vs succeeds, despite some package downgrade warning issues. Can you verify that you also have these components installed?
@cartermp I have Visual Studio Community 2017 15.8.5 installed (Also tried with Professional) with the following workloads, toolsets andcomponents:
.NET desktop development workload
Desktop development with C++ workload
Universal windows platform development workload
Visual Studio extension development toolset
F# desktop language support individual component
Some .NET framework components, NuGet etc..
Both build vs and build vs debug fails with the same issue while building only the compiler works fine.
I've tried to re-install a few times only installing the components and workloads mentioned in this issue but without success. I managed to build it through a developer VM but it's way to slow for my machine.
@brokenprogrammer
there are log files created in the directory release\logs
can you attach the logs to this thread, and I cn take a look, thanks.
Kevin
I can confirm that with default visual studio settings both solutions won't build in visual studio. The workaround known to me right now is to reduce the amount if parallel builds to 1 in the settings.
However that one might be a different story.
@cartermp one thing we could do is gate build.cmd on those workloads being installed. We can use vswhere to ensure that the workloads are installed, and show a helpful error message if not. It seems that many new contributors trip up over this, and it’s very low hanging fruit.
Thanks looking at them.
@realvictorprm Can you upgrade your VS to 15.8.7 if you haven't already? That issue was fixed in a patch update to VS 15.8.
@brokenprogrammer, hmm nothing jumps out as being the cause.
Could you please do a git clean -fxdq and then run build... I wonder if there is some cruft lying around.
Thanks
Kevin
@brokenprogrammer, @brettfo, just spotted you are not on the latest version of VS, it looks like you are using VS2017.5.
Perhaps if you upgrade to the RTM release of VS 2017.8 then at least you will match what we all use.
Kevin
@KevinRansom Tried cleaning before building as well as updating VS but its still the same error message.
Old old issue, closing
| gharchive/issue | 2018-05-06T13:39:38 | 2025-04-01T04:32:46.648834 | {
"authors": [
"KevinRansom",
"TIHan",
"brettfo",
"brokenprogrammer",
"cartermp",
"dsyme",
"forki",
"majocha",
"realvictorprm",
"saul",
"vasily-kirichenko"
],
"repo": "Microsoft/visualfsharp",
"url": "https://github.com/Microsoft/visualfsharp/issues/4842",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
91146392 | Provided methods with static params can't be used as first-class function values
I cobbled together a variation on the regex type provider sample, where the pattern string is now a static method argument, not a static type argument.
It works fine in direct usage, but I get an unexpected error when attempting to use the method as a function value.
let x = RegexTyped.Match< @"(?<first>\w+) (?<last>\w+)"> "John Doe"
printfn "First: %s Last: %s" x.first x.last // works
let y =
"Jane Doe"
|> RegexTyped.Match< @"(?<first>\w+) (?<last>\w+)">
// error: unexpected type arguments
I think this is consistent for F# 4.0 because methods instantiated with generic parameters also can't be used as first-class values
I do think it is worth addressing this in a future version of the language - please add an http://fslang.uservoice.com suggestion and we can mark it as approved for vNext.
type C() =
static member M<'T>(c:'T) = c
1 |> C.M<int>
| gharchive/issue | 2015-06-26T04:05:47 | 2025-04-01T04:32:46.653200 | {
"authors": [
"dsyme",
"latkin"
],
"repo": "Microsoft/visualfsharp",
"url": "https://github.com/Microsoft/visualfsharp/issues/516",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
126072147 | can't use for i in view do within async {} when view is a System.Data.DataView.
Consider this code in a .fsx:
#r "System.Data"
#r "System.Data.DataSetExtensions"
open System.Data
let datatable = new DataTable()
let view =
datatable
.AsEnumerable()
.AsDataView()
for r in view do
()
let filterWorkflow =
async {
for r in view do
()
}
it fails to compile with following message when doing so within an async computation expression while it works fine outside of it.
The type 'DataView' is not compatible with the type 'seq<'a>'. 2. . Type constraint mismatch. The type DataView is not compatible with type seq<'a>. The type 'DataView' is not compatible with the type 'seq<'a>'.
The code seems legit to me.
System.Data.DataView implements a large amount of interfaces and somehow the compiler fails to pick up that it implements IEnumerable when used within async.
It seems that IEnumerable is done with implicit implementation in the C# code for DataView while other interfaces are defined via explicit interface implementation.
I don't know why this type of resolution would differ within a computation expression but it seems to be what is failing here.
@smoothdeveloper i think the problem is IEnumerable vs IEnumerable<T>
the async expect a seq<'t>, an IEnumerable<T>.
if you try
let viewTyped = view |> Seq.cast<DataRowView>;;
let filterWorkflow =
async {
for r in viewTyped do
()
}
that works.
the error is correct
The type 'DataView' is not compatible with the type 'seq<'a>'
because DataView implement lots of interface, but not generic
@enricosada thanks for update.
Do you know why the same code works outside of async?
As a user, it's strange that the same code outside the async computation can't be just moved within it.
Because the for inside async it's not a special instruction, but a function of a computed expression
https://github.com/Microsoft/visualfsharp/blob/master/src/fsharp/FSharp.Core/control.fsi#L533
member For: sequence:seq<'T> * body:('T -> Async<unit>) -> Async<unit>
The enumerable ( not generic ) it's a corner case in modern .net, better without.
It's always possible to make it typed with Seq.cast
My feedback it's to try to improve error messages.
For example add some suggestion about
seq<'t> expected, found IEnumerable, it's missing a Seq.cast?
We can improve a lot learning from elm-lang
@enricosada thanks, explanation makes sense alas the language fails at principle of least surprise on this (code outside the CE assumed to work inside of it).
The current error message is still good as soon as one is aware of this type of distinction.
I guess we can close that issue.
These old .NET v1.0 APIs supporting just IEnumerable are becoming rarer and rarer, and I doubt there are any in Core CLR libraries for example.
So one far off day we may be able to get rid of the special language rules for these types (which are much the same as C# language rules).
| gharchive/issue | 2016-01-12T00:50:41 | 2025-04-01T04:32:46.661566 | {
"authors": [
"dsyme",
"enricosada",
"smoothdeveloper"
],
"repo": "Microsoft/visualfsharp",
"url": "https://github.com/Microsoft/visualfsharp/issues/869",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
198200063 | Speed up checkPathForIllegalChars without a cache.
Timing for 100k checks of the path "c:\dev\myproject\utilities\longstring with spaces\filename.fs":
Original ~250ms
This function ~100ms
I don't expect this to be noticeable in the compiler but it might be in IDEs.
Uses a mutable HashSet but doesn't let it escape the function.
Out of curiosity -- would you mind benchmarking the original function again, but modifying it to iterate over path using the string enumerator (via for c in path do)? I'm wondering if some part of the speedup you're seeing is due to using the string enumerator instead of accessing the path characters via explicit indexing.
Thanks for the suggestion. I tried it, and it didn't help. The improvement comes from HashSet.
For reference, I took the bunch of things I tried and added it to a gist, here: https://gist.github.com/rojepp/6d5cfbbc9b1235645df895ab9c51ee7b
Your suggestion is checkPathForIllegalChars8
| gharchive/pull-request | 2016-12-30T22:11:08 | 2025-04-01T04:32:46.664768 | {
"authors": [
"jack-pappas",
"rojepp"
],
"repo": "Microsoft/visualfsharp",
"url": "https://github.com/Microsoft/visualfsharp/pull/2138",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
156926457 | "Overload:" artifact in "Assertions" article
https://msdn.microsoft.com/en-us/visualfsharpdocs/conceptual/assertions-[fsharp]
I'm not sure, but it seems that Overload:System.Diagnostics.Debug.Assert should be a link.
I'll add "Overload:" to the list of bad prefixes I remove in #61
@dend or @vasily-kirichenko Please close this now. Fixed.
@ReedCopsey there looks to be a note formatting issue. I will fix that and will update the bug after.
@dend So - are the braces actually required?
@ReedCopsey nope, it's the location of the exclamation mark and the prefix.
@dend Does it need a space between the > and ! ? I'll submit a PR to fix, if that's the issue.
| gharchive/issue | 2016-05-26T08:01:58 | 2025-04-01T04:32:46.668003 | {
"authors": [
"ReedCopsey",
"dend",
"vasily-kirichenko"
],
"repo": "Microsoft/visualfsharpdocs",
"url": "https://github.com/Microsoft/visualfsharpdocs/issues/106",
"license": "CC-BY-4.0",
"license_type": "permissive",
"license_source": "github-api"
} |
271056479 | Unable to find package.json
When I open a module in VS code, eslint complains about all my import statements:
file: 'file:///Users/.../myApp/src/app/components/Component.js'
severity: 'Error'
message: 'Resolve error: Error: ENOENT: no such file or directory, open './package.json' (import/namespace)'
at: '1,1'
source: 'eslint'
file: 'file:///Users/.../myApp/src/app/components/Component.js'
severity: 'Error'
message: 'Resolve error: Error: ENOENT: no such file or directory, open './package.json' (import/no-extraneous-dependencies)'
at: '1,1'
source: 'eslint'
And in the output window for eslint I see the following:
ESLint server is running.
ESLint library loaded from: /Users/.../myApp/src/node_modules/eslint/lib/api.js
Failed to load .env.undefined.
Failed to load .env.undefined.
Failed to load .env.undefined.
Failed to load .env.undefined.
...
I can't reproduce this issue when I run eslint from the command line. When I run eslint ./app/**/*.js from the terminal, I see no lint errors (I only see the Failed to load .env.undefined. error). This issue also persists if I disable all extensions except for ESLint. So this seems to be a problem with VS code and this plugin.
@chipit24 do you work in a multi folder setup where the package.json & eslint configuration is in one of the subfolders. Then you need to confugre eslint using the workingDirectories setting. See here for an example: https://github.com/Microsoft/vscode-eslint#settings-options
If this doesn't address your problem please provide a GitHub repository demoing the problem that I can clone with steps on how to reproduce.
Thanks. I had the exact same issue as described in https://github.com/Microsoft/vscode-eslint/issues/196, and using changeProcessCWD as you suggested there has worked for me. The problem stems from eslint-import-resolver-webpack.
@chipit24 currently not. Only if you start code from a terminal and set the env inside the terminal. The eslint server will then inherit the env.
I will close the issue. Please ping if you disagree.
| gharchive/issue | 2017-11-03T17:24:43 | 2025-04-01T04:32:46.676679 | {
"authors": [
"chipit24",
"dbaeumer"
],
"repo": "Microsoft/vscode-eslint",
"url": "https://github.com/Microsoft/vscode-eslint/issues/337",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
280216061 | When hitting stop during Debug, it does not always kill debug process
Environment data
VS Code version: 1.18.1
Python Extension version: 0.8.0
Python Version: 3.6
OS and version: MacOS Sierra
Actual behavior
When entering debug mode and then stopping debug session debug process still alive and you need manually kill it.
Expected behavior
Debug process should be stopped automatically
Steps to reproduce:
Enter debug mode
Click stop button
Process still alive
Configuration
Here is my configuration file
"version": "0.2.0",
"configurations": [
{
"name": "Python",
"type": "python",
"envFile": "${workspaceRoot}/env",
"request": "launch",
"stopOnEntry": true,
"program": "${workspaceRoot}/runners/server.py",
"args": [
"--service=search"
],
"cwd": "${workspaceRoot}",
"debugOptions": [
"RedirectOutput"
],
"env": {"PYTHONASYNCIODEBUG":1}
}
]
Please could you provide the sample code.
@DonJayamanne Sorry, seems like some wrong configuration from my side. I can't reproduce it anymore.
| gharchive/issue | 2017-12-07T17:34:45 | 2025-04-01T04:32:46.692270 | {
"authors": [
"DonJayamanne",
"hzlmn"
],
"repo": "Microsoft/vscode-python",
"url": "https://github.com/Microsoft/vscode-python/issues/364",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
394762271 | Python Interactive not Printing Correctly
Environment data
VS Code version: 1.30.1
Extension version (available under the Extensions sidebar): 2018.12.1
OS and version: MacOS Sierra
Python version (& distribution if applicable, e.g. Anaconda): Anaconda 3.6.7
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): XXX
Relevant/affected Python packages and their versions: requests=2.21, IPython 7.2.0, ipykernel=5.1.0, jupyter
Expected behaviour
I should be able to print a requests object.
Actual behaviour
Nothing shows up!
I attached a screenshot. My terminal at the bottom printed correctly, as a result of clicking to run the selection in Python Terminal.
Steps to reproduce:
make a request
Print it
Logs
none
Output from Console under the Developer Tools panel (toggle Developer Tools on under Help; turn on source maps to make any tracebacks be useful by running Enable source map support for extension debugging)
none
I believe the problem is we're treating the returned data as html directly instead of wrapping it in a span. So the <Response [200]> is treated like an html tag.
@rchiodo that makes sense to me. are you able to change the behavior to wrap output in span, and see if that resolves the issue?
Seems relevant to printing objects generally, not just requests objects. E.g. printing a package is wrapped in tags... <module 'package' from 'path/here.py'>
Seems like a straightforwards fix to make for the next release?
Unfortunately it's not as simple as just sticking a span around everything. It all depends upon the type of stream data. We have to put spans just around text data. It should be fixed soon though.
| gharchive/issue | 2018-12-29T05:13:48 | 2025-04-01T04:32:46.698667 | {
"authors": [
"rchiodo",
"realimpat"
],
"repo": "Microsoft/vscode-python",
"url": "https://github.com/Microsoft/vscode-python/issues/3824",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
422149512 | Automatic Python environment activation does not select the correct environment with a multiproject workspace
Environment data
VS Code version: 1.32.1
Extension version (available under the Extensions sidebar): 1.32.1
OS and version: OSX: 10.14.3
Python version (& distribution if applicable, e.g. Anaconda): 3.7.0
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): virtualenv
Relevant/affected Python packages and their versions: XXX
Expected behaviour
Opening a terminal for a multiproject workspace should also set the python environment activation for the project selected.
Actual behaviour
When opening a terminal on a multiproject workspace, the terminal always defaults the source to the virtualenv of the first project in the workspace tree.
Ie.
Projects:
/project1/ -> venv path ..virtualenvs/project1/bin/activate
/project2/ -> venv path ..virtualenvs/project2/bin/activate
When opening a new terminal and selecting project2, the terminal behaviour is as follows
cd /project2/
source virtualenvs/project1/bin/activate
Steps to reproduce:
Add multiple python projects to workspace
Configure environment python paths for each project
Open an integrated terminal for any python project and it will use the python path for the first project in the tree
Duplicate of #3325
| gharchive/issue | 2019-03-18T10:45:41 | 2025-04-01T04:32:46.703499 | {
"authors": [
"DonJayamanne",
"mr-katsini"
],
"repo": "Microsoft/vscode-python",
"url": "https://github.com/Microsoft/vscode-python/issues/4790",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
428360948 | IntelliSense with python and installed modules
I have followed the guidance in the article below. The part of Intellisense that is not working with Python is the wxWidgets library. I have added the path directly to the wx folder under site packages. I have also tried at the root of site packages.
To be honest, it seems to work intermittently, which is very odd, and only on certain methods.
Any other ideas that I could try? I am on a Mac OS Mojave with the 1.32.3 of VS Code. Thank you kindly!
https://stackoverflow.com/questions/50389852/visual-studio-code-intellisense-not-working
Issue moved to Microsoft/python-language-server #870 via ZenHub
For the record -- I tested this today on windows, and it worked just like you said, without any special consideration. It doesn't work on a Mac. I will make a note on the link posted above
| gharchive/issue | 2019-04-02T17:49:56 | 2025-04-01T04:32:46.706643 | {
"authors": [
"CoderJason123",
"gramster"
],
"repo": "Microsoft/vscode-python",
"url": "https://github.com/Microsoft/vscode-python/issues/5080",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
172946127 | Problem to copy content of a opened file
VSCode Version: 1.4.0
OS Version: Windows 10
Steps to Reproduce:
In "Open Editors", open two different files with some content
Choose one of the two files to open in editor
When it's open, click and open the other file, and press "Ctrl + a" and, after that, try to copy by pressing "Ctrl + c"
Open the first file again, and try to paste the content. The clipboard contains content before the "new copy".
Ps.: Observe when you press "Ctrl + a", the "lines numbers" are selected too.
Yes, sometimes noticed the same behavior. But couldn't find any patterns of occurrence of the problem.
@victorschinaider Can you please make it clear on
Step 4: Open the first file again, and try to paste the content. The clipboard contains content before the "new copy".
Or Is it that the first files contains the copied content before paste?
@sandy081 Ok, the 4th step needs reformulation.
Now, try to paste the copied content in anywhere. You'll see, based on pasted content, that the clipboard memory region do not suffered any changes by the last "Crtl + C" action.
Thanks for confirmation
This has already been fixed on master. @victorschinaider the fix will come out with the August stable release or you can get it already now using the Insiders channel.
| gharchive/issue | 2016-08-24T13:05:13 | 2025-04-01T04:32:46.714600 | {
"authors": [
"alexandrudima",
"mrmlnc",
"sandy081",
"victorschinaider"
],
"repo": "Microsoft/vscode",
"url": "https://github.com/Microsoft/vscode/issues/10891",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
181863858 | VSCode icon will disappear from dock once restart the mac
VSCode Version: Insider 1.6.0 (2016-10-07T18:57:32.707Z) & Stable 1.5.3
OS Version: 10.12
Steps to Reproduce:
Drag any version of vscode into docker.
Restart.
You will see the app icon becomes a question mark, and also you cannot open the app through clicking those icons. Also the insiders version icon remains, but it is not functional!!
Where is the Application installed?
@joaomoreno under /Applications
Can you find anything interesting in the Console application, specific to VS Code?
@joaomoreno Sorry, I dont know how..~ could u please tell me what am I going to do
I can't get the vscode icon into the dock, nor does the icon show up when I alt-tab between open applications. This started happening after I upgraded to vscode 1.6
FWIW: I am still on El Capitan
cc @bpasero Could be related to Electron update
@bjmin @freeformz Does it work if you completely remove Code and download a fresh build from our website?
@joaomoreno sorry, i've tried many times, it doesnt work
Ditto. No luck.
On Thu, Oct 13, 2016 at 08:25 Benjamin Huang notifications@github.com
wrote:
@joaomoreno https://github.com/joaomoreno sorry, i've tried many times,
it doesnt work
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/13389#issuecomment-253546730,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAAZ-D_mtVOp1t4S82mhJhEYdIpSvwSks5qzk1fgaJpZM4KR5ZR
.
The same issue.:+1:
This is fixed for me after upgrading to 1.6.1
@bjmin @Dafrok you?
Yes, fixed!.. but i wanna know what cause this exactly
Yeah me too 👍
@joaomoreno It works, good job 👍
This is still an issue for me. I'm using a new MacBook Pro with VSCode version 1.14.2.
Admit it, this is just so people will start using this IDE on Windows ;)
Still an issue for me, too.
VSCode v1.14.2
macOS Sierra v10.12.6
Every time I shut down VSCode and go to relaunch from the Dock, a question mark appears over the icon and nothing else happens. If I remove the 'corrupted' icon, relaunch VSCode, secondary click the icon and select "Keep in Dock", the same thing happens on the next launch.
Okay, so one of two different things worked for me. I'm not 100% sure which one did it, but I've got it working now and I don't want to end up breaking it by testing further. So I recommend doing both for good measure:
Use the macOS default unarchiving app, "Archive Utility" (when I was having this issue, I was extracting the VSCode app using a 3rd-party utility called "Dr. Unarchiver"
Do not extract the app straight into the Applications directory; extract it into the Downloads folder, then drag and drop it into the Applications directory
Doing these two things worked for me. I even rebooted as a final test, and the dock icon still launched VSCode with no problem.
I believe this to be a broader electron issue, it's occuring for me as described by OP with vscode, atom and flowdock.
See https://github.com/electron/electron/issues/9293, https://github.com/atom/atom/issues/13695
I think I found the issue. It has to do with apps downloaded from the internet. In the case of normal installers, it prompts you at the point of install. But VS Code is an application you get from a zip file, so you actually have access to the app file itself before you've verified it's safe. So, if you unzip, then drag it to your dock (doesn't matter where it is... downloads, applications, etc.) you'll have the issue. However, if before you drag it to the dock you open the app, it will go through the verify step, prompting you about it being downloaded. Let it open, then you can drag it from the Applications folder (or wherever it is) to the dock.
To be sure this was the issue, I deleted it from my dock, then from Applications, then using the exact same ZIP file I already had downloaded, I again extracted the app, moved it to Applications, then added it to the dock, then launched it, and sure enough, it was back to the double-icon/icon disappearing behavior. Again, deleted everything, this time after I unzipped it but before I added it to the dock (I did this twice... one running it right from 'Downloads' before moving it to 'Applications', and a second time where I moved it to 'Applications' then ran it, but again, in both cases before I added it to the dock), and all worked as expected.
TLDR version, it's not a VS Code issue, it's not an Electron issue. It's not an Archive Utility vs Dr. Archiver or anything else issue. It's a 'You added it to the dock before you verified it was safe!' issue.
Hope this helps!
For anyone having this issue, see my root cause and workaround that I just posted at https://github.com/electron/electron/issues/9293#issuecomment-331422359
I am having the same issue . I am using mac os high sierra .
| gharchive/issue | 2016-10-09T03:46:14 | 2025-04-01T04:32:46.729635 | {
"authors": [
"Dafrok",
"LeonineKing1199",
"MarqueIV",
"bjmin",
"freeformz",
"joaomoreno",
"mehedi-sharif",
"normrankin",
"oller",
"stevenreddie"
],
"repo": "Microsoft/vscode",
"url": "https://github.com/Microsoft/vscode/issues/13389",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
182918122 | Files in a folder not aligned to the folder they belong
VSCode Version: 1.6.1 and prev as well
OS Version: Win10
The files in a folder are not aligned to the folder they belong. This gives the impression that the files belong to a subfolder that is actually at the same level of files.
See this sample:
all files seem to be under the "typings" folder when they are actually at root level
https://github.com/Microsoft/vscode/issues/11762
thanks, I did a quick search and didn't find a similar one. I guess my search skills suck :)
| gharchive/issue | 2016-10-13T22:18:45 | 2025-04-01T04:32:46.732658 | {
"authors": [
"alebrozzo",
"bpasero"
],
"repo": "Microsoft/vscode",
"url": "https://github.com/Microsoft/vscode/issues/13707",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
185348916 | Zooming Out Keyboard Databinding Issue
VSCode Version: 1.6.1
OS Version: Windows 10 Enterprise [version 10.0.14393]
AZERTY French Keyboard
Steps to Reproduce:
Open any file text with Visual Studio Code
Do the shortcut Ctrl+-
The shortcut doesn't work
I enclose below the problem in settings of the binding and many other developers on Windows are facing the same issue like me.
Best Regards,
Maher
@MaherJendoubi Please hover over the red x and read the message.
So this means that zoomOut is not bound out of the box for your keyboard layout. The reason is simple:
"ctrl+-" is simply a UI representation for "ctrl+VK_OEM_MINUS", where VK_OEM_MINUS is a key code as defined here. For your current keyboard layout, no single key is mapped to that key code. Meaning regardless what you press on your keyboard, the OS will never generate the key code VK_OEM_MINUS.
Therefore, please go to File > Preferences > Keyboard Shortcuts and define a new keybindings for those commands as you would want them. Here I am doing it:
@alexandrudima Awesome! Thank you for the answer! Which tool are you using please to take such a screenshot?
I'm using LiceCap
Thanks a lot!
👍 👍 👍
| gharchive/issue | 2016-10-26T10:02:34 | 2025-04-01T04:32:46.738793 | {
"authors": [
"MaherJendoubi",
"alexandrudima"
],
"repo": "Microsoft/vscode",
"url": "https://github.com/Microsoft/vscode/issues/14522",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
189086319 | VSCode corrupts 'registered sign' character
VSCode Version: Code 1.7.1 (02611b40b24c9df2726ad8b33f5ef5f67ac30b44, 2016-11-03T13:53:14.822Z)
OS Version: Windows_NT ia32 10.0.10240
Extensions:
Extension
Author
Version
csharp
ms-vscode
1.4.1
PowerShell
ms-vscode
0.7.2
Steps to Reproduce:
Open file containing 'registered sign' character ®
Ex.: Microsoft® .NET Framework
The character is replaced by �
Ex.: Microsoft� .NET Framework
Closing as Duplicate of #15303
| gharchive/issue | 2016-11-14T11:12:21 | 2025-04-01T04:32:46.742885 | {
"authors": [
"iSazonov",
"ramya-rao-a"
],
"repo": "Microsoft/vscode",
"url": "https://github.com/Microsoft/vscode/issues/15453",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
196191928 | [VS Code 1.8][Breaking change] contentChanges of TextDocumentChangeEvent returns wrong text
VSCode Version: 1.8.0
OS Version: All OS
Several Auto Close Tag users complain about the extension not working after they upgrade to VS Code 1.8
Steps to Reproduce:
Install Auto Close Tag
Open a html file, and type a open tag, e.g. <div>
Expected: A close tag </div> is appended
Actual: Nothing happens
After investigation, this issue only happens in a html file and the contentChanges of TextDocumentChangeEvent returns wrong text in https://github.com/formulahendry/vscode-auto-close-tag/blob/master/src/extension.ts#L21
When you type > after <div, it should return >, while it return the text of whole line: <div>
Since a lot of users are using this function and the impact for user is big, I am wondering if we have any other workaround to use this API, or could we fix this in 1.8.1?
@formulahendry The TextDocumentChangeEvent also contains a range property, which you could take into account in your logic. I am not sure why this has changed from 1.7.0 to 1.8.0, but the TextDocumentChangeEvent is correct. e.g.:
when having a file with the contents
<div
and typing >
this is the text document change event being sent:
{
"document": ...,
"contentChanges":[{
"range":[{"line":0,"character":0},{"line":0,"character":4}],
"rangeLength":4,
"text":"<div>"
}]
}
This event is correct, it allows someone to correctly keep a synced version of the text document. (i.e. the purpose of TextDocumentChangeEvent` is fulfilled).
That the change now effectively says "replace <div with <div>" instead of "insert > after <div" is rooted in how the edits reach the buffer, however the TextDocumentChangeEvent is correct.
AFAIK there is no API contract on the shape and semantics of TextDocumentChangeEvent as long as it allows to maintain a correct replica of the text document. i.e. there are cases where in the core buffer logic edits are simplified for memory saving purposes. e.g. try a replace all in a file where there are 100 matches, there will come 100 contentChanges, try a replace all in a file where there are 10000 matches, there will come a single entry in contentChanges.
That seems not acceptable, since
Scenario#1 in a html file
Type <di, then type v, contentChanges return v, then type >, contentChanges return <div>
When typing v, why it returns v not <div?
Scenario#2 in a html file
Type <di, then type v, contentChanges return v, then type 1, contentChanges return 1
When typing 1, why it return 1 not <div1?
Scenario#3 in a file which is not html
Type <di, then type v, contentChanges return v, then type >, contentChanges return >
When typing >, why it returns > not <div>?
Moreover, with below info, it is hard for developer to distinguish whether user is just typing a > after <div or user is copying and pasting a <div>
{
"contentChanges":[{
"range":[{"line":0,"character":0},{"line":0,"character":4}],
"rangeLength":4,
"text":"<div>"
}]
}
Share my understanding of what happens under the hood. When you type any closing electric character, we'll do following steps:
Firstly, check whether there is any complex auto close pair for this particular language. If so, append the character and the closing text in the pair and put the cursor just after the closing electric character.
Take below language definition as example
"autoClosingPairs": [
{ "open": "{", "close": "}"},
{ "open": "[", "close": "]"},
{ "open": "(", "close": ")" },
{ "open": "'", "close": "'" },
{ "open": "\"", "close": "\"" },
{ "open": "<div>", "close": "</div>" }
]
The last pair is the so called complex auto close pair. If you type > after <div, and since there is a matched complex pair, we'll end up with (| is the cursor)
<div>|</div>
so the corresponding content change is
{
"range":[{"line":0,"character":4},{"line":0,"character":4}],
"rangeLength":0,
"text":"></div>"}
}
However we don't have such definitions in HTML's language configuration file. I think it's easy to see why.
Secondly, if there is no matched complex auto close pair, we'll check against those simple ones. With above language configuration in mind, you'll know that > is matched with < so append > to the end of the text and run auto indentation.
For example, if you have tabSize set as 4 and insertSpaces as false, and the text in current line you are editing is <div (starts with four spaces). After you press >, the text of current line will become \t<div>.
In this case, the content change will be
{
"range":[{"line":0,"character":0},{"line":0,"character":8}],
"rangeLength":8,
"text":"\t<div>"
}
Thirdly, if there is still no matched pair for the character, we'll just insert the text user typed.
Our second step right now is what blocks your extension, I think @alexandrudima knows more about why we do auto indentation there. I agree this piece can be somehow improved, let's say there is no real indentation change, just insert the text instead of running a replacement.
But they are not the root cause of the problem you run into, I'll describe it in following comment.
The real problem is you can not use TextDocumentChangeEvent to determine whether users type a character or not. The reason is the contentChange is the combined result of Code's internal logic and any extension that takes effect. Below are some cases that might break your extension with current design
There is a decreaseIndentPattern rule for a language, and when users press enter, the decreaseIndentPattern matches the content of current line. So the contentChange of this component is decreasing the indentation and inserting a line break at the end of line. You don't know if users just press the enter key.
A user installs Vim extension and map > key to [">", "o"] as he/she wants to close the tag and move cursor to next line. As Vim takes over type event, the only thing Code knows is the real content change, >\t, and then we pass it through extension host. You might think users type > and \t but actually they only press > key.
Above two examples might be invalid but I just want to demonstrate that if you rely on contentChange to determine what users type into the editor, the behavior of your extension might be affected by any extension users install.
Thanks @rebornix for the detailed info!
\t<div> in second step is acceptable. However, the weird thing is that when you type abcde<div then type >, content change returns abcde<div>, the whole line, seems not related to auto indentation.
I really meet with other extensions affect each other not just in this TextDocumentChangeEvent. For every extension, there seems no better way to avoid the impact from other extensions. This is a general problem for every extension. Therefore, I just want to make sure the extensions is working correctly on a clean VS Code without other extensions. User may have trade-off between the extensions if they are affected by other extensions.
| gharchive/issue | 2016-12-17T02:57:29 | 2025-04-01T04:32:46.763326 | {
"authors": [
"alexandrudima",
"formulahendry",
"rebornix"
],
"repo": "Microsoft/vscode",
"url": "https://github.com/Microsoft/vscode/issues/17444",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
199147624 | CharWidthReader performance
The character width reader is consuming roughly ~250ms in the open editor cycle. The number is to understood with the knowledge of 'don-distortion'. That is, because it needs to layout and measure things it pays the price of all previous dom modifications, e.g from creating the workbench etc. However, there are things that can be improved
[x] use an off-don canvas to measure character width (no possible as we have dropped support of IE9) @jrieken, @alexandrudima
[ ] don't make the editor do the work twice. The BaseEditor first create an editor widget with the default config just to immediately update the config to the 'real' config @bpasero
[ ] consider running the measure logic before the dom is 'busy'. The theory (needs confirmation) is that the measuring takes longer the more busy and dirty the render tree is
editor-restore1.cpuprofile.zip
@alexandrudima @jrieken I also noticed a little bit of time spend in WindowManager.getPixelRatio() which seems to have similar bad characteristics on Windows. This seems to be used for the overview ruler.
re https://github.com/Microsoft/vscode/issues/18211#issuecomment-270858456 - That's interesting. I assume that's a similar problem to "dom distortion", enforcing a full layout.
IMHO reading the width of characters using the ctx.measureText method is not slow per-se, it is simply triggering a forced dom layout and all the dom changes that happened before it will show up in the profile time. i.e. try that code in a standalone HTML page, it is quite fast.
@alexandrudima what about we do this very early on workbench construction and I can pass this into the editor as some kind of option?
@bpasero :+1:
The thing has a static cache anyways (such that all editors share the measurements). Someone simply needs to call CSSBasedConfiguration.INSTANCE.readConfiguration(bareFontInfo) very early on.
To get a bareFontInfo, some minimal editor logic is needed (i.e. the part that defines a line height if it is configured to be 0, etc.).
But this has to happen with the correct font and the editors should not be created with the default font and then switched to the configured font in order to benefit from it.
If you can point me to some location where I can add this call in the workbench start-up (i.e. needs configuration service) I can extract the editor logic that deduces the line height and do it.
@alexandrudima the configuration service gets created very early before any DOM element is added and is ready after the initialize() call here: https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/electron-browser/main.ts#L135
That is, ready without extensions of course because they are not loaded yet. But including any user and workspace settings.
Maybe add it into the shell.open() method?
Added to shell.open(). There remains the issue that the editor is created with no options and then the options are updated.
Pushed a change to create the editor with the real config. There is still more calls to updateOptions due to extensions contributing to the config and the theme service doing some thing in there, however the options should not change for the editor after being created.
| gharchive/issue | 2017-01-06T08:27:46 | 2025-04-01T04:32:46.772504 | {
"authors": [
"alexandrudima",
"bpasero",
"jrieken"
],
"repo": "Microsoft/vscode",
"url": "https://github.com/Microsoft/vscode/issues/18211",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
199253896 | Show source name in callstack even when path is provided
For #150
This is fine by me, but not sure if it is contradicting with @weinand comment here
We should just come to a consensus, what has priority name or the path?
@isidorn yes, 'name' has priority over 'path' for the callstack 'name' (shown on the right). And 'path' has priority over 'name' for the callstack 'path' (shown on hover).
| gharchive/issue | 2017-01-06T18:10:25 | 2025-04-01T04:32:46.774883 | {
"authors": [
"isidorn",
"roblourens",
"weinand"
],
"repo": "Microsoft/vscode",
"url": "https://github.com/Microsoft/vscode/issues/18234",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
202658054 | Test: Markdown Editor Document Link Provider
OS
[x] Windows @dbaeumer
[ ] any @mousetraps
Complexity: 1
Clone and open the VSCode-docs repo: https://github.com/Microsoft/vscode-docs
Open a markdown file.
Look for a link of the format [link text](path/file.ext)
Hover over the path/file.ext part of the link.
⭐A blue underline should appear under the link along with a message about ctrl-clicking the link
Try ctrl clicking the link
⭐If the link is a local link, it should open that file in the editor. Links of the form ./path or path should resolve to a path relative to the current file. Links of the form /path should resolve relative to the current workspace
Looks good to me: one think I noticed which is different than the description but I thought it is the better behavior: hovering over a link doesn't turn it blue right away. It gets blue when Ctrl is pressed.
@dbaeumer Thanks.
Yes, this is the expected behavior for links inside documents. They should behavior the same as other links inside of documents. If you notice some discrepancy, please let me know
| gharchive/issue | 2017-01-23T21:38:07 | 2025-04-01T04:32:46.779425 | {
"authors": [
"dbaeumer",
"mjbvz"
],
"repo": "Microsoft/vscode",
"url": "https://github.com/Microsoft/vscode/issues/19089",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
212003161 | TypeScript意外终止
VSCode Version: Code 1.10.1 (653f8733dd5a5c43d66d7168b4701f94d72b62e5, 2017-03-02T00:33:15.706Z)
OS Version: Windows_NT ia32 6.1.7601
Extensions:
Extension
Author
Version
html-snippets
abusaidm
0.1.0
vscode-javascript-snippet-pack
akamud
0.1.5
jquerysnippets
donjayamanne
0.0.1
vscode-JS-CSS-HTML-formatter
lonefy
0.2.2
csharp
ms-vscode
1.7.0
vscode-icons
robertohuertasm
7.3.0
JavaScriptSnippets
xabikos
1.4.0
Steps to Reproduce:
看看是不是360删了
我都没有完整的安装过，你能把你的整个安装命令让我看看吗
@cca313 果然是360干的
Please file this issue in english with reproducable steps. Closing until then
360 delete the files after we installed vs code @isidorn
| gharchive/issue | 2017-03-06T01:27:12 | 2025-04-01T04:32:46.785381 | {
"authors": [
"bucaixiaot",
"caogenyin",
"cca313",
"isidorn"
],
"repo": "Microsoft/vscode",
"url": "https://github.com/Microsoft/vscode/issues/22039",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
212349674 | The horizontal scroll bar is somewhat hidden
VSCode Version: Code 1.10.1 (653f8733dd5a5c43d66d7168b4701f94d72b62e5, 2017-03-02T00:33:15.706Z)
OS Version: Windows_NT ia32 10.0.14393
Extensions: none
The bar is not fully visible.
Steps to Reproduce:
1.Just open Visual Sutio Code, and open a file with long enough lines to allow for the horizontal bar to appear.
The bar does get a more solid color on hover.
It's not the color, it looks like the bar is narrower than its vertical
counterpart. Maybe it's my eyes playing tricks on me?
El 7/3/2017 19:19, "Ramya Rao" notifications@github.com escribió:
The bar does get a more solid color on hover.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/22126#issuecomment-284809534,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AJRBXbjKuNBcitins05hzMzxg6S0SSQpks5rjZ-UgaJpZM4MVH6c
.
Yes, the horizontal bar is not as tall as the vertical bar is wide. I am not sure why that is the case.
@bpasero @alexandrudima - do either of you know why this is?
I have no clue, sorry.
Yes, it is intentional that the horizontal scrollbar height !== vertical scrollbar width.
The vertical bar needs more space to show:
git diff annotations
find matches, highlights, etc.
errors, warnings, etc.
Alright, sorry for the troubles. Great job guys!
| gharchive/issue | 2017-03-07T07:15:11 | 2025-04-01T04:32:46.792654 | {
"authors": [
"TFrascaroli",
"alexandrudima",
"bpasero",
"ramya-rao-a",
"stevencl"
],
"repo": "Microsoft/vscode",
"url": "https://github.com/Microsoft/vscode/issues/22126",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
222604058 | vscode performance not good even on small file
VSCode Version: VSCode 1.11.2
OS Version: 10.11.6
Steps to Reproduce:
I was editing a small js file, only 132 lines of code
vs response the keystroke with very high latency
Another timeline screenshot,
Hope this help you to diagnosis the root cause.
clear the search result solve the performance problem
Pretty sure I have the same issue. With the search panel open, editing performance degrades well below a reasonable level on my 4k screen on a Macbook Pro 2015. No other panel noticeably affects performance.
Lots has changed, this is probably faster. If not please upload the perf profile.
| gharchive/issue | 2017-04-19T03:09:22 | 2025-04-01T04:32:46.796266 | {
"authors": [
"bakkerme",
"roblourens",
"z-index1000000"
],
"repo": "Microsoft/vscode",
"url": "https://github.com/Microsoft/vscode/issues/24990",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
238807685 | [I18N] Unresolved message placeholder
When opening a typescript file I get the message
Note the brackets ({1)}. Seems to be a error in the order of the closing brackets.
Duplicate of #28371
| gharchive/issue | 2017-06-27T10:36:59 | 2025-04-01T04:32:46.797718 | {
"authors": [
"kthoms",
"mjbvz"
],
"repo": "Microsoft/vscode",
"url": "https://github.com/Microsoft/vscode/issues/29569",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
240127594 | Task contribution should allow extension to supress problem matcher attach message
Steps:
workspace with package.json
Run Task
Select npm install
Observe: the system ask to attach a problem matcher which is unnecessary unless npm would contribute a specific one.
However it shows that there are tasks where the extension contributing it knows that a problem matcher questions makes no sense. We should support that a extension can flag this.
/cc @egamma
@dbaeumer should we only prompt for a problem matcher for build tasks?
I had that once and then removed it again since it requires a perfect build task auto detection. So I ask for even none build tasks since I thought it is better to ask then to run a build task that is not detected as such and then don't scan for any problems. Lint tasks are a good example for this.
I added support for this and changed npm to pass an empty problem matchers array for install.
@dbaeumer @egamma Am I right in saying that this:
https://github.com/cake-build/cake-vscode/pull/30/files#diff-9b613b29d95ad2d8d2f616bce2ecfbe0R91
Is what is required to "override" the prompt for scanning build output?
I understand that this won't work in the current release of VSCode.
@gep13 LGTM.
@egamma woot! Very excited to get the next version of the Cake Extension released with these new features 😄
@dbaeumer @egamma I have just installed VSCode Insiders, and I can confirm that this is now working as expected 👍
| gharchive/issue | 2017-07-03T10:13:34 | 2025-04-01T04:32:46.802826 | {
"authors": [
"dbaeumer",
"egamma",
"gep13"
],
"repo": "Microsoft/vscode",
"url": "https://github.com/Microsoft/vscode/issues/30044",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
241198747 | Localization smoke test fails due to slow opening of viewlets
"Localization - starts with 'DE' locale and verifies title and viewlets text is in German"
Temporarily fixed with wait() in 6356698cfc4420ce9054c05d076486c6e6f8fa2c.
Closing this as it is no longer the case
| gharchive/issue | 2017-07-07T08:49:37 | 2025-04-01T04:32:46.804213 | {
"authors": [
"michelkaporin",
"sandy081"
],
"repo": "Microsoft/vscode",
"url": "https://github.com/Microsoft/vscode/issues/30234",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
249247930 | Ability to choose different shells on create new terminal
Hello,
I couldn't find a feature request for this and I saw that you're struggling with similar things at #10546 and #7504
But I'd like to be able to configure multiple shells and be able to choose one on the fly (without having to switch the one configured all the time)
So for example sometimes I need to use powershell and sometimes bash on windows - it would be awesome to have them pre configured and be able to choose one of them while creating a new terminal within VSCode.
This extension solves this problem https://marketplace.visualstudio.com/items?itemName=Tyriar.shell-launcher
| gharchive/issue | 2017-08-10T06:43:41 | 2025-04-01T04:32:46.806238 | {
"authors": [
"Morgy93",
"Tyriar"
],
"repo": "Microsoft/vscode",
"url": "https://github.com/Microsoft/vscode/issues/32215",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
269377556 | git command runs indefinetely
VSCode Version: 1.17.2
OS Version: MacOS 10.10.5
When I run the SCM publish command, I can see an indicator that the git command is running. Because I do not have permission to publish, or perhaps git is prompting for credentials, the command hangs indefinitely without any other window.
Steps to Reproduce:
Clone a repository where you do not have write access to. My example was https://github.com/bbiskup/purkinje
Create a new branch
Add a new commit
Publish the branch
Output from Terminal shows a few git processes running
hanxue 29343 0.0 0.0 2444632 1080 ?? S 2:54PM 0:00.00 /bin/sh /Applications/Visual Studio Code.app/Contents/Resources/app/extensions/git/out/askpass.sh Username for 'https://github.com':
hanxue 29338 0.0 0.0 2519972 6576 ?? U 2:54PM 0:00.07 /usr/local/Cellar/git/2.14.1/libexec/git-core/git-remote-https upstream https://github.com/bbiskup/purkinje
hanxue 29337 0.0 0.0 2446940 1728 ?? S 2:54PM 0:00.01 /usr/local/bin/git push -u upstream fix-readme-config-file
Notice in the video there is an indicator showing an ongoing operation in SOURCE CONTROL
Where is the option to terminate the git command?
After terminating the askpass.sh process, I see some git output error
usage: mktemp [-d] [-q] [-t prefix] [-u] template ...
mktemp [-d] [-q] [-u] -t prefix
Missing or invalid credentials.
Missing pipe
I've got the same (loading indicator spinning and CPU/mem load is getting high) even if the repo is perfectly fine and I can easily publish. It happens only when SCM panel is active (as soon as I open file explorer instead the load goes down). Restarting the app doesn't help here.
Here is my VSC version info
Version 1.18.0-insider (1.18.0-insider)
8bc02c7443305a0db442c11b76e67d6f4929dc0e
2017-10-26T05:07:28.835Z
@hanxue What does running mktemp on your system return?
| gharchive/issue | 2017-10-29T07:22:07 | 2025-04-01T04:32:46.811363 | {
"authors": [
"hanxue",
"joaomoreno",
"mostr"
],
"repo": "Microsoft/vscode",
"url": "https://github.com/Microsoft/vscode/issues/37094",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
269902724 | Exception while staging the opened change
Testing #37164
Steps:
Open an inline change from the gutter
Run the command Git: Stage Change
An exception is thrown.
Great catch, that command shouldn't appear in the command palette at all.
| gharchive/issue | 2017-10-31T10:11:59 | 2025-04-01T04:32:46.813394 | {
"authors": [
"joaomoreno",
"sandy081"
],
"repo": "Microsoft/vscode",
"url": "https://github.com/Microsoft/vscode/issues/37226",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
270621167 | Problems when starting debug from status line
When the launch config is run from the status bar:
no launch config errors show up, e.g. if the debug type is wrong or if 'request' attribute is missing
the same launch config can be started multiple times
I suggest to use the identical code for launching from the status line and through the debug drop down menu.
One is an action, and the other is a quick open item entry. Due to that it is not very trivial to share an implementation. THough I have tried to sharae by introducing a statis isEnabled
Verified ok but I've created https://github.com/Microsoft/vscode/issues/39707 to improve the weak UI.
| gharchive/issue | 2017-11-02T11:33:53 | 2025-04-01T04:32:46.815529 | {
"authors": [
"isidorn",
"weinand"
],
"repo": "Microsoft/vscode",
"url": "https://github.com/Microsoft/vscode/issues/37507",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
275456589 | CMD terminal output line is cut at point where it wraps panel width. problem matcher only gets truncated string.
VSCode Version: 1.18.1
OS Version: Windows 10 Pro 1709
CMD terminal output line is cut at point where it wraps panel width. problem matcher only gets truncated string.
Hello, (Stable 1.18.1) When I have my terminal (cmd) width short enough to wrap, the problems window cuts the text at the wrapping point of the text given. I did not already see an issue it. I was wondering if someone else noticed this too?
Steps to Reproduce:
Have CMD as your default terminal
Make sure the window width is small enough where terminal text of a message would wrap to at least two lines for the message.
Run a task that will output to the terminal and has a problem matcher.
Look at the cut off messages in the problem matcher with a sigh.
Reproduces without extensions: Yes
Screen shot small width:
Screen shot large width:
You can see with the larger width, more is available.
@dbaeumer shouldn't this be fixed in v1.18.1? https://github.com/Microsoft/vscode/issues/32042
@Tyriar yes, this should be addressed.
@pr-yemibedu can you provide a GitHub project I can clone that demos the behavior with steps to reproduce. This got fixed and verified: https://github.com/Microsoft/vscode/issues/32042
Hello,
@dbaeumer I will try to get one done this afternoon (EST) with a minimal project. Thank you. Good day.
| gharchive/issue | 2017-11-20T18:38:17 | 2025-04-01T04:32:46.821395 | {
"authors": [
"Tyriar",
"dbaeumer",
"pr-yemibedu"
],
"repo": "Microsoft/vscode",
"url": "https://github.com/Microsoft/vscode/issues/38806",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
141225993 | Review initialization sequence
Cases
happens from command line
happens from context menu
happens on double click
To verify (Windows only):
you can open relative paths from the command line (files and folders) and things work as expected
try to execute some native things to see if you can find regressions (tasks, debug, reveal in explorer, open in command prompt, etc.)
| gharchive/issue | 2016-03-16T10:09:13 | 2025-04-01T04:32:46.823370 | {
"authors": [
"bpasero",
"egamma"
],
"repo": "Microsoft/vscode",
"url": "https://github.com/Microsoft/vscode/issues/4297",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
296345284 | Edit and continue [C#]
Issue Type
Feature Request
Description
I know, that's a very strange question (I had to find the answer, but I'm not able).
Is it possible to edit and continue C# code in VS Code?
VS Code Info
VS Code version: Code 1.20.0 (c63189deaa8e620f650cc28792b8f5f3363f2c5b, 2018-02-07T17:02:34.244Z)
OS version: Darwin x64 17.4.0
Please ask this question against the c# extension
This is the feature request.
Could you please tell me, if the feature "Edit and Continue" is exist in VS Code. If not, do you have any roadmap for it?
| gharchive/issue | 2018-02-12T11:38:12 | 2025-04-01T04:32:46.825694 | {
"authors": [
"7654098",
"mjbvz"
],
"repo": "Microsoft/vscode",
"url": "https://github.com/Microsoft/vscode/issues/43502",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
298257036 | Login-AzureRMAccount - Bring to front
Issue Type
Bug
Description
When trying command Login-AzureRMAccount the login prompt is hidden behind the Studio Code GUI. Please make the login prompt focus (bring to front)
VS Code Info
VS Code version: Code 1.20.1 (f88bbf9137d24d36d968ea6b2911786bfe103002, 2018-02-13T15:33:21.935Z)
OS version: Windows_NT ia32 10.0.16299
System Info
Item
Value
CPUs
Intel(R) Core(TM) i7-6600U CPU @ 2.60GHz (4 x 2808)
Memory (System)
15.93GB (8.76GB free)
Process Argv
C:\Program Files (x86)\Microsoft VS Code\Code.exe
Screen Reader
no
VM
0%
Extensions (10)
Extension
Author (truncated)
Version
azureautomation
Awe
0.6.2
xml
Dot
1.9.2
git-project-manager
fel
1.4.0
prettify-json
moh
0.0.3
azurecli
ms-
0.4.0
PowerShell
ms-
1.5.1
azurerm-vscode-tools
msa
0.4.0
vscode-manifest-yaml
Piv
0.1.3
vscode-icons
rob
7.20.0
arm-snippets
sam
1.1.0
Reproduces without extensions
Please continue this discussion in this repository: https://github.com/Microsoft/vscode-azurearmtools/issues/44
| gharchive/issue | 2018-02-19T12:22:18 | 2025-04-01T04:32:46.834083 | {
"authors": [
"FlemmingRohde",
"tsalinger"
],
"repo": "Microsoft/vscode",
"url": "https://github.com/Microsoft/vscode/issues/43967",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
301936175 | Multiple Monitors / Task View Performance Issue
Version 1.20.1
Commit f88bbf9137d24d36d968ea6b2911786bfe103002
Date 2018-02-13T15:34:36.336Z
Shell 1.7.9
Renderer 58.0.3029.110
Node 7.9.0
Architecture x64
Windows 10 1709
VSCode performance (especially with the terminal) degrades really bad when you create more than one window, and put the second window on a different monitor, or in a different Virtual Desktop.
Steps to Reproduce:
Create a second window
Put that window on another Virtual Desktop or second Monitor
Try to run commands in the integrated terminal, performance should be degraded.
Does this issue occur when all extensions are disabled?: Yes
I think this is https://github.com/Microsoft/vscode/issues/36913
| gharchive/issue | 2018-03-02T23:17:26 | 2025-04-01T04:32:46.837500 | {
"authors": [
"Tyriar",
"rianquinn"
],
"repo": "Microsoft/vscode",
"url": "https://github.com/Microsoft/vscode/issues/44955",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
316302396 | Git problem when .git is outside workspace: branch not updated
I know there was a bug opened about that one but since I couldn't find it, I am opening a new one.
This issue is driving me crazy.
I have a directory layout like this one:
root
root/.git
root/java
root/frontend/project1
root/frontend/project2
Since I am working only on js I added project1 and project2 folders in my workspace.
Even though the .git is outside the workspace, VSCode correctly detects it, and shows current branch at the bottom.
Problem is that sometimes branch change isn't detected by VSCode.
Since VSCode doesn't watch for changes outside the workspace folders, it won't detect the branch change if the change doesn't modify any files in my folder.
So for example, if I type "git checkout -b new_branch", only some changes will be made inside the .git repository, no change will happen in the workspace folders. So VSCode will still show the previous branch.
I guess the fix would be to implicitely add the .git folder to the watch list if it's outside the workspace folder.
This issue is really driving me crazy since I tend to watch the bottom of the VSCode window to check I'm using the correct branch, and most of the time it shows the wrong branch because of this problem.
To easily reproduce the problem, create the following structure:
root
root/.git
root/foo
Open root/foo directory in VSCode and then create and change branch with git checkout -b new_branch.
Notice how the branch at the bottom of the window isn't updated.
This happens on Windows with latest Insider build (but have been happening for months).
That's the issue I already opened: https://github.com/Microsoft/vscode/issues/41085
It seems to rely on this https://github.com/Microsoft/vscode/issues/3025 but I think this bug should be kept opened: this is a real problem.
| gharchive/issue | 2018-04-20T15:00:34 | 2025-04-01T04:32:46.842300 | {
"authors": [
"warpdesign"
],
"repo": "Microsoft/vscode",
"url": "https://github.com/Microsoft/vscode/issues/48287",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
321921089 | Feature Request Advanced Search
I really love Visual Studio code. The only issue is that I wish we had a advanced search like in PHP storm. I am sure it's coming.
There are a bunch of feature requests that cover phpstorm's features, such as search in a tree view: https://github.com/Microsoft/vscode/issues/20224
| gharchive/issue | 2018-05-10T12:54:57 | 2025-04-01T04:32:46.844114 | {
"authors": [
"kyoukhana",
"roblourens"
],
"repo": "Microsoft/vscode",
"url": "https://github.com/Microsoft/vscode/issues/49616",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
146232887 | spawn osascript ENOENT
Issue Id: def759c3-62fe-b6f1-ff32-27679721a3ffVersions - 0.10.8- f291f4ad600767626b24a4b15816b04bee9a3049- 43ff6af3d4564f59196caa9be4897fc33c15f24c- 5b5f4db87c10345b9d5c8d0bed745bcad4533135- 17fa1cbb49e3c5edd5868f304a64115fcc7c9c2cStack Error: spawn osascript ENOENT at exports._errnoException (util.js:837:11) at Process.ChildProcess._handle.onexit (internal/child_process.js:178:32) at onErrorNT (internal/child_process.js:344:16) at doNTCallback2 (node.js:442:9) at process._tickCallback (node.js:356:17)
over 3000000 hits, on 32 machines, 100% on windows
I suspect that uncaught errors from extensions show up in our telemetry... not very happy.
There are two different types of 'osascript' usages in VS Code:
using an absolute path '/usr/bin/osascript'
just 'osascript' and relying on the search PATH
For the first type I've verified on Windows 10 that the error message shows the full absolute path which looks different from the telemetry error entry from above:
Error: spawn /usr/bin/osascript ENOENT
at exports._errnoException (util.js:870:11)
at Process.__dirname._handle.onexit (internal/child_process.js:178:32)
at onErrorNT (internal/child_process.js:344:16)
at nextTickCallbackWith2Args (node.js:441:9)
at process._tickCallback (node.js:355:17)
at Module.runMain [as _onTimeout] (module.js:444:11)
at Timer.listOnTimeout (timers.js:92:15)
The second usage type is in cli.contribution.ts:131. Since this action is only installed on OS X and must be triggered manually, it cannot explain the high number of occurrences on Windows.
From this I conclude that this is an uncaught error from some extension.
| gharchive/issue | 2016-04-06T08:31:15 | 2025-04-01T04:32:46.848883 | {
"authors": [
"aeschli",
"joaomoreno",
"vscodeerrors",
"weinand"
],
"repo": "Microsoft/vscode",
"url": "https://github.com/Microsoft/vscode/issues/5019",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
328314221 | Multiple Tries
We have written the needed data into your clipboard because it was too large to send. Please paste.
Issue Type: Bug
Many times I have to save more than once for the page to update
VS Code version: Code 1.23.1 (d0182c3417d225529c6d5ad24b7572815d0de9ac, 2018-05-10T17:11:17.614Z)
OS version: Windows_NT x64 10.0.17134
System Info
Item
Value
CPUs
Pentium(R) Dual-Core CPU E5400 @ 2.70GHz (2 x 2700)
GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: disabled_offnative_gpu_memory_buffers: disabled_softwarerasterization: unavailable_softwarevideo_decode: unavailable_softwarevideo_encode: enabledvpx_decode: unavailable_softwarewebgl: enabledwebgl2: enabled
Memory (System)
2.97GB (0.31GB free)
Process Argv
C:\Program Files\Microsoft VS Code\Code.exe
Screen Reader
no
VM
0%
Extensions (29)
Extension
Author (truncated)
Version
vscode-javascript-snippet-pack
aka
0.1.5
path-intellisense
chr
1.4.2
bracket-pair-colorizer
Coe
1.0.55
vscode-svgviewer
css
1.4.4
jquerysnippets
don
0.0.1
prettier-vscode
esb
1.3.1
vscode-install-vsix
fab
1.1.1
auto-close-tag
for
0.5.6
auto-rename-tag
for
0.0.15
live-html-previewer
hdg
0.3.0
beautify
Hoo
1.3.0
ftp-simple
hum
0.6.3
html-tag-wrapper
hwe
0.2.3
open-in-browser
igo
0.0.99
vscode-github
Kni
0.28.1
wrapSelection
kon
0.6.8
code-beautifier
mic
2.0.3
view-in-browser
qin
0.0.5
live-sass
rit
1.3.0
LiveServer
rit
4.0.0
vscode-icons
rob
7.23.0
sass-indented
rob
1.4.9
code-settings-sync
Sha
2.9.2
html5-boilerplate
sid
1.0.3
code-spell-checker
str
1.6.10
bootstrap4-vscode
the
4.1.1
change-case
wma
1.0.0
JavaScriptSnippets
xab
1.6.0
html-css-class-completion
Zig
1.17.1
https://github.com/Microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions
Please clearly describe what's the behavior and what's the intended behavior and with gif/images.
| gharchive/issue | 2018-05-31T22:06:29 | 2025-04-01T04:32:46.865697 | {
"authors": [
"dmiller72",
"octref"
],
"repo": "Microsoft/vscode",
"url": "https://github.com/Microsoft/vscode/issues/50903",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
328798683 | Integrated terminal take up the whole window (or independent)
Hi,
Is it possible to let the integrated terminal take up the whole window? I really like thevscode's integrated terminal under Windows 10 and often use the vscode just as a terminal. But other areas cannot be closed and it is really uncomfortable. I even thought of taking the integrated terminal out and make it an standalone application.
Cheers
Duplicate https://github.com/Microsoft/vscode/issues/34442
I recommend setting up a keybinding for maximizing the panel such as:
{ "key": "ctrl+shift+q", "command": "workbench.action.toggleMaximizedPanel" }
| gharchive/issue | 2018-06-03T04:36:24 | 2025-04-01T04:32:46.867954 | {
"authors": [
"LujunWeng",
"Tyriar"
],
"repo": "Microsoft/vscode",
"url": "https://github.com/Microsoft/vscode/issues/51029",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
370871037 | "Back" button & navigation history
When I use "Go to definition" feature I often want to go back to the previous file but it's no longer possible, you should open previous file manually
It would be nice to have "back" button for that
There is a back command you can use (see View menu), we don't plan on adding these buttons to the UI.
@Tyriar thanks for the reply, but from user perspective it would be good to have a button on UI since new users did not know the commands to go back and forth. Since other IDE's like Intellij do provide this type of functionality.
I appreciate if any one can take an initiative on this feature for upcoming build.
| gharchive/issue | 2018-10-17T02:22:06 | 2025-04-01T04:32:46.869824 | {
"authors": [
"Kelin2025",
"Tyriar",
"amitagrawal11"
],
"repo": "Microsoft/vscode",
"url": "https://github.com/Microsoft/vscode/issues/61103",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
387079203 | Tasks: Build task runs on start up if was running in prior session
Insiders
Steps to reproduce:
Start Build VSCode task on current repository
task builds and shows running
close VSCode
restart code
Build task shows as running
@dbaeumer
@alexr00
Yes, running latest insiders building OSS. Sorry I just put "Insiders" and the BOT did not appear to pick it up...
I do see that it is the strict null check, but what confused me was the status bar shows "Building"
Does that task also do building?
You can mark this "as-designed" and close since all sounds correct.
| gharchive/issue | 2018-12-04T01:29:08 | 2025-04-01T04:32:46.872329 | {
"authors": [
"cleidigh"
],
"repo": "Microsoft/vscode",
"url": "https://github.com/Microsoft/vscode/issues/64277",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
162690796 | Search: did we loose the upper limit for search results?
Refs: https://github.com/Microsoft/vscode/issues/8184
When I now search for "e" in our workspace I seem to get all the results back? I think as long as I am not replacing, it is fine to cut the results as we used to.
Marking as important because even for replace I see the entire UI freezing and things getting slow. Imho as long as we are not fit for this in the UI we should maybe keep the 2000er limit alive even for replace.
Agreed.
| gharchive/issue | 2016-06-28T13:50:35 | 2025-04-01T04:32:46.874018 | {
"authors": [
"bpasero",
"sandy081"
],
"repo": "Microsoft/vscode",
"url": "https://github.com/Microsoft/vscode/issues/8369",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
227874025 | Preserve Webview Scroll Position
Fixes #22995
Bug
If you switch away from an editor that users a webview, the scroll position is currently not preserved. This effects our release notes and the markdown preview. The root cause is that the webview is disposed of when the view is hidden.
Fix
Add some presisted state to track scrollProgress through the webview. Use this state in the standard html editor and in the release notes.
TODO
[ ] Make sure html preview handles case where content changes. I believe this should reset the scroll position
[X] Handle dragging editor tab to create duplicate view. This should also copy over the scroll position
Fixes #13256
@mjbvz The editor input can be used for multiple editors (e.g., through Split Editor). You probably want to store the scroll position separately from the input. See WalkThroughPart.load/saveTextEditorViewState() for a similar approach to what the BaseTextEditor and its subclasses do.
Thanks for taking a look @chrmarti. I think I was actually closer to that behavior with my first draft of the implementation (which used private member on HtmlEditor) but since I wasn't using mementos I ran into problems when splitting views. Moving the state to the input fixed this but as you noted, this also introduce some other weird behavior when multiple previews are active.
Let me try the memento based approach and see how that works
What makes it harder than expected is that editors and inputs are both reused. Editors are reused for inputs of the same type in the same editor column IIRC. Switching between editor tabs in the same column can trigger setInput() calls on a single editor with different inputs. So one editor can cover multiple editor tabs.
@chrmarti Thanks for the help. I prototyped the approach using mementos but I don't think it is correct here either, at least for the normal html preview. The scroll position should always be associated with the content, not just with the resource url. At present, we also do not want to restore the previous scroll position in an html preview after you restart VS Code
The approach that saved view state on the Input felt more correct to me when I was actually using it. The problem with it seems to be that the same input can be shared between editors in multiple panes however. Can we sit down together next week to discuss this more?
Ok, merging the initial memento based implementation as we discussed
| gharchive/pull-request | 2017-05-11T04:15:43 | 2025-04-01T04:32:46.879356 | {
"authors": [
"chrmarti",
"joaomoreno",
"mjbvz"
],
"repo": "Microsoft/vscode",
"url": "https://github.com/Microsoft/vscode/pull/26426",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
134790456 | Add "launch"-type config to launch.json
Now I can just hit F5 to build and debug vscode. Also removed 'outDir' which isn't used anymore.
Thanks a lot!
| gharchive/pull-request | 2016-02-19T06:56:25 | 2025-04-01T04:32:46.880447 | {
"authors": [
"roblourens",
"weinand"
],
"repo": "Microsoft/vscode",
"url": "https://github.com/Microsoft/vscode/pull/3149",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
267746058 | deco: Fix link tooltip hover message #36683
This pull request provides users on linux and mac who have enabled "editor.multiCursorModifier": "ctrlCmd" with the correct hyperlink or command tooltip text.
New localization key "links.navigate.al.mac" and "terminalLinkHandler.followLinkAltMac" are added, however I would suggest renaming them.
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: anchepiece sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.
Based on feedback I suggest closing this without merging. If there is a suitable way of reading alt+click binding/usage at the OS level or customization of mouse bindings directly the current functionality is better.
Those encountering a hover message when Alt+click is a system level binding should use Ctrl+Alt+Click instead.
| gharchive/pull-request | 2017-10-23T17:08:24 | 2025-04-01T04:32:46.884289 | {
"authors": [
"anchepiece",
"msftclas"
],
"repo": "Microsoft/vscode",
"url": "https://github.com/Microsoft/vscode/pull/36764",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
296085847 | Remove comments in json file since they're invalid
I love the idea but comments in a json file are invalid
@joshunger VS Code uses a custom parser that ignores comments. There's even a special language mode for this: json with comments
Can you fix Github?
On Mon, Feb 12, 2018 at 1:00 PM Matt Bierner notifications@github.com
wrote:
Closed #43378 https://github.com/Microsoft/vscode/pull/43378.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/pull/43378#event-1470251415, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACMfl8J3Hb72uuX6uNBhh1n-AwWHAmLjks5tUJhXgaJpZM4SA3Bz
.
| gharchive/pull-request | 2018-02-10T08:53:29 | 2025-04-01T04:32:46.887617 | {
"authors": [
"joshunger",
"mjbvz"
],
"repo": "Microsoft/vscode",
"url": "https://github.com/Microsoft/vscode/pull/43378",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
121210181 | Run Title and Publish Test Attachments Changes
Description: The PublishTestResults Task's xplat implementation is currently different from windows implementation. Users choice of Run Title and option to not publish result files do not exist in the current xplat implementation.
Solution: Changes have been made for Junit, xunit and nunit to honor users choice of run ttitle and user can now opt out of publishing test attachments.
https://github.com/Microsoft/vso-agent-tasks/pull/954
https://github.com/Microsoft/vso-agent/pull/168
Testing: Manual for now. Appropriate unit tests will be added if required.
approved with suggestions
| gharchive/pull-request | 2015-12-09T10:49:30 | 2025-04-01T04:32:46.889698 | {
"authors": [
"allendm-msft",
"prawalagarwal"
],
"repo": "Microsoft/vso-task-lib",
"url": "https://github.com/Microsoft/vso-task-lib/pull/19",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
} |
328391630 | Test platform crashes when there's null value in Payload messages
When tests are being discovered/executed if the adapter sends the value as "null" in the payload, platform fails to deserialize the payload causing it crash.
For example:
{
"Key": {
"Id": "VCTestDiscoverer.TestCategory",
"Label": "TestCategory",
"Category": "",
"Description": "",
"Attributes": 1,
"ValueType": "System.String[]"
},
"Value": null
},
TpTrace Verbose: 0 : 4936, 7, 2018/05/31, 17:21:44.662, 12516221489, vstest.console.exe, TestRequestSender: GetAbortErrorMessage: Exception: Newtonsoft.Json.JsonSerializationException: Error setting value to 'StoreKeyValuePairs' on 'Microsoft.VisualStudio.TestPlatform.ObjectModel.TestCase'. ---> System.NotSupportedException: CustomStringArrayConverter cannot convert from (null).
at System.ComponentModel.TypeConverter.GetConvertFromException(Object value)
at System.ComponentModel.TypeConverter.ConvertFrom(ITypeDescriptorContext context, CultureInfo culture, Object value)
at Microsoft.VisualStudio.TestPlatform.ObjectModel.CustomStringArrayConverter.ConvertFrom(ITypeDescriptorContext context, CultureInfo culture, Object value)
at Microsoft.VisualStudio.TestPlatform.ObjectModel.TestObject.ConvertPropertyFrom[T](TestProperty property, CultureInfo culture, Object value)
at Microsoft.VisualStudio.TestPlatform.ObjectModel.TestObject.SetPropertyValue[T](TestProperty property, T value, CultureInfo culture)
at Microsoft.VisualStudio.TestPlatform.ObjectModel.TestObject.set_StoreKeyValuePairs(List`1 value)
at SetStoreKeyValuePairs(Object , Object )
at Newtonsoft.Json.Serialization.DynamicValueProvider.SetValue(Object target, Object value)
--- End of inner exception stack trace ---
at Newtonsoft.Json.Serialization.DynamicValueProvider.SetValue(Object target, Object value)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.SetPropertyValue(JsonProperty property, JsonConverter propertyConverter, JsonContainerContract containerContract, JsonProperty containerProperty, JsonReader reader, Object target)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateObject(Object newObject, JsonReader reader, JsonObjectContract contract, JsonProperty member, String id)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateObject(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateValueInternal(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.PopulateList(IList list, JsonReader reader, JsonArrayContract contract, JsonProperty containerProperty, String id)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateList(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, Object existingValue, String id)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.CreateValueInternal(JsonReader reader, Type objectType, JsonContract contract, JsonProperty member, JsonContainerContract containerContract, JsonProperty containerMember, Object existingValue)
at Newtonsoft.Json.Serialization.JsonSerializerInternalReader.Deserialize(JsonReader reader, Type objectType, Boolean checkAdditionalContent)
at Newtonsoft.Json.JsonSerializer.DeserializeInternal(JsonReader reader, Type objectType)
at Newtonsoft.Json.Linq.JToken.ToObject(Type objectType, JsonSerializer jsonSerializer)
at Newtonsoft.Json.Linq.JToken.ToObject[T](JsonSerializer jsonSerializer)
at Microsoft.VisualStudio.TestPlatform.CommunicationUtilities.JsonDataSerializer.DeserializePayload[T](Message message)
at Microsoft.VisualStudio.TestPlatform.CommunicationUtilities.TestRequestSender.OnDiscoveryMessageReceived(ITestDiscoveryEventsHandler2 discoveryEventsHandler, MessageReceivedEventArgs args)
TpTrace Error: 0 : 4936, 7, 2018/05/31, 17:21:44.662, 12516225635, vstest.console.exe, TestRequestSender: Aborting test discovery because Error setting value to 'StoreKeyValuePairs' on 'Microsoft.VisualStudio.TestPlatform.ObjectModel.TestCase'.
This was fixed with https://github.com/Microsoft/vstest/pull/1640
| gharchive/issue | 2018-06-01T06:00:21 | 2025-04-01T04:32:46.892524 | {
"authors": [
"nigurr",
"smadala"
],
"repo": "Microsoft/vstest",
"url": "https://github.com/Microsoft/vstest/issues/1628",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
299266506 | Web test config support in run settings
Description
Updating the TestPlatformExternalsVersion to 15.7.0-preview-1409276 for the following changes:
1)
DEVDIV Pull Request 105172: Web test configuration support in run settings
DEVDIV Bug 569865: Web test configuration support in run settings
Related issue
NA
@ganesp Add payload changes PR(DevDiv PR) and any devdiv bug/user story to description .
@smadala Done, updated the description.
@singhsarab Can you please approve and merge the PR?
@dotnet-bot test Ubuntu14.04 / Debug Build.
@dotnet-bot test this.
@dotnet-bot test Ubuntu14.04 / Debug Build.
@dotnet-bot test Windows_NT / Release Build.
@dotnet-bot test Windows_NT / Debug Build.
| gharchive/pull-request | 2018-02-22T08:52:02 | 2025-04-01T04:32:46.896989 | {
"authors": [
"ganesp",
"smadala"
],
"repo": "Microsoft/vstest",
"url": "https://github.com/Microsoft/vstest/pull/1443",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
214798714 | npm deprecation on tsc package
Following the vsts-task-lib node installation instructions, it appears tsc is deprecated and typescript should be used. Is this the case?
administrators-MacBook-Pro:node administrator$ sudo npm install tsc -g
Password:
npm WARN deprecated tsc@1.20150623.0: You probably meant to instally 'typescript'. Run 'npm install typescript -g'
/usr/local/bin/tsc -> /usr/local/lib/node_modules/tsc/bin/tsc
/usr/local/bin/tsserver -> /usr/local/lib/node_modules/tsc/bin/tsserver
/usr/local/lib
└── tsc@1.20150623.0
This is no longer in the docs. We can re-open if I missed something ...
| gharchive/issue | 2017-03-16T18:32:06 | 2025-04-01T04:32:46.898222 | {
"authors": [
"bryanmacfarlane",
"dutronlabs"
],
"repo": "Microsoft/vsts-task-lib",
"url": "https://github.com/Microsoft/vsts-task-lib/issues/220",
"license": "mit",
"license_type": "permissive",
"license_source": "bigquery"
} |
257043832 | Add -allowProvisioningUpdates to the xcode-archive step as variable
Hi MS-Team,
Apple will provide XCode9 with automatic signing on the commandline very soon. Please enhance xcode.ts for VSTS to support -allowProvisioningUpdates during archive-export.
E.g. as boolean field or something.
//export the archive
var xcodeExport: ToolRunner = tl.tool(tl.which('xcodebuild', true));
xcodeExport.arg(['-exportArchive', '-archivePath', archive]);
xcodeExport.arg(['-exportPath', exportPath]);
xcodeExport.argIf(exportOptionsPlist, ['-exportOptionsPlist', exportOptionsPlist]);
xcodeExport.arg(['-allowProvisioningUpdates', allowProvisioningUpdates]);
Otherwise Xcode9 Auto-Signing is not working in VSTS
Guys, this is pretty urgent for us. Is there a way to speed this up?
@schmichri : Hi,
We support running Xcode9 builds in VSTS as long as you provide the provisioning profiles. Even with auto-signing, you can collect the provisioning profiles from the developer machine. What issue are you seeing with signing? Please share your logs here or email them to me at madhurig at microsoft.com.
To support "-allowProvisioningUpdates", the build server will need access to your Apple Developer Account. We are reviewing the best way to do that. If you are running the builds on a trusted Mac, you can login to the Apple Developer Portal and store the credentials on the build server and pass "-allowProvisioningUpdates" to the Xcode task via additional arguments in the task. It should be able to download the provisioning profiles in that case.
Thanks,
Madhuri
@madhurig Hi,
If you are running the builds on a trusted Mac, you can login to the Apple Developer Portal and store the credentials on the build server and pass "-allowProvisioningUpdates" to the Xcode task via additional arguments in the task. It should be able to download the provisioning profiles in that case.
This is what we've tried but it's actually not the case. XCode9 in the agent has an valid Developer Portal sign-in.
If've provided -allowProvisioningUpdates in Advanced->Arguments but it is not passed to the exportArchive Step in the task
[command]/usr/bin/xcodebuild -exportArchive -archivePath /Users/builder/vsts-agent/_work/1/s/LS.xcarchive -exportPath /Users/builder/vsts-agent/_work/1/output/iphoneos/Dev/_XcodeTaskExport_LS -exportOptionsPlist _XcodeTaskExportOptions.plist
If I copy/paste this commandline appending -allowProvisioningUpdates on the shell of the buildagent it works fine.
@schmichri: You are right, we are not passing in the additional args to export. In your case it might help to have additional args for export specifically since sharing the additional args for build and export doesn't make sense. I can see that being useful in general too.
Thanks,
Madhuri
This attached zip file has a new version of the task that allows passing in "Export Arguments".
Xcode.zip
To upload to your account:
Unzip attached zip file
Install tfs-cli
tfx login (enter collection url followed by PAT)
Tfx build tasks upload –task-path <unzipped Xcode task location>
Thanks,
Madhuri
@schmichri : Closing since we added the ability to pass additional arguments to export.
Thanks,
Madhuri
| gharchive/issue | 2017-09-12T13:30:37 | 2025-04-01T04:32:46.907105 | {
"authors": [
"madhurig",
"schmichri"
],
"repo": "Microsoft/vsts-tasks",
"url": "https://github.com/Microsoft/vsts-tasks/issues/5295",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
257540292 | dotnet commands (test/pack) do not work if project depends on authenticated feed
There's dotnet commands which implicitly build the projects and implicitly restore packages if needed.
In the case for dotnet pack, the task should probably pass the --no-restore to avoid restoring packages.
There should also be documentation saying that if the project depends on packages coming from authenticated builds, a dotnet restore should be put in place before other dotnet tasks.
Ran into the same issue, it's too bad that the preview task for dotnet when in pack mode doesn't accept arguments (like test does for example)
Closing this as WF. In the upcoming quarter, we'll be moving away from the full-featured Artifacts-related tasks (which have many issues like this because they don't provide the full range of commands supported by the underlying tool) and recommending calling dotnet directly. See the design here for more details.
| gharchive/issue | 2017-09-13T22:27:19 | 2025-04-01T04:32:46.909647 | {
"authors": [
"alexmullans",
"baywet",
"emanuelquintero"
],
"repo": "Microsoft/vsts-tasks",
"url": "https://github.com/Microsoft/vsts-tasks/issues/5319",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
213109803 | Packer Task UI improvments
storage accounts are listed filtered by selected location
resource group is listed filtered by selected storage account
this required a dependent check-in into VSO code for adding new azure RM data source. The PR for that is:
@bishalpd,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot
| gharchive/pull-request | 2017-03-09T17:30:32 | 2025-04-01T04:32:46.911672 | {
"authors": [
"bishalpd",
"msftclas"
],
"repo": "Microsoft/vsts-tasks",
"url": "https://github.com/Microsoft/vsts-tasks/pull/3764",
"license": "MIT",
"license_type": "permissive",
"license_source": "github-api"
} |
419847142 | Integration Test - Release - 2019/03/12 15:57:03
Auto create for integration test. IssueCommandFlow
@PRMergerTest3 : Thanks for your contribution! The author, @v-caxian, has been notified to review your proposed change.
| gharchive/pull-request | 2019-03-12T07:57:04 | 2025-04-01T04:32:46.920084 | {
"authors": [
"PRMerger20",
"PRMergerTest3"
],
"repo": "MicrosoftDocs/CSIDev-Public",
"url": "https://github.com/MicrosoftDocs/CSIDev-Public/pull/1075",
"license": "CC-BY-4.0",
"license_type": "permissive",
"license_source": "github-api"
} |
1167705923 | Trying out a landing page for Converters
@davidbritch @brminnick @jfversluis
Just trying out a landing page for converters that links over to the .NET MAUI docs. The links in the table currently link to our written docs but I suspect these could quite easily link out to the API docs instead. What do you think?
Docs Build status updates of commit 0847ebb:
:warning: Validation status: warnings
File
Status
Preview URL
Details
docs/maui/converters/index.md
:warning:Warning
View
Details
docs/maui/TOC.yml
:white_check_mark:Succeeded
View
docs/maui/converters/index.md
Line 12, Column 59: [Warning: hard-coded-locale - See documentation] Link 'https://docs.microsoft.com/en-gb/dotnet/maui/fundamentals/data-binding/converters' contains locale code 'en-gb'. For localizability, remove 'en-gb' from links to most Microsoft sites.
Line 14, Column 1: [Warning: multiple-h1s - See documentation] Multiple H1s(H1 '.NET MAUI Community Toolkit Converters') are not allowed. You can only have one top-level heading.
Line 4, Column 14: [Suggestion: duplicate-descriptions - See documentation] Attribute 'description' with value 'The .NET MAUI Community Toolkit is a collection of reusable elements for application development with .NET MAUI, including animations, behaviors, converters, effects, and helpers.' is duplicated in 'maui/converters/index.md(4,14)', 'maui/index.md(4,14)'.
Line 12, Column 59: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/en-gb/dotnet/maui/fundamentals/data-binding/converters' will be broken in isolated environments. Replace with a relative link.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel
Docs Build status updates of commit d299cda:
:warning: Validation status: warnings
File
Status
Preview URL
Details
docs/maui/converters/index.md
:warning:Warning
View
Details
docs/maui/TOC.yml
:white_check_mark:Succeeded
View
docs/maui/converters/index.md
Line 14, Column 1: [Warning: multiple-h1s - See documentation] Multiple H1s(H1 '.NET MAUI Community Toolkit Converters') are not allowed. You can only have one top-level heading.
Line 4, Column 14: [Suggestion: duplicate-descriptions - See documentation] Attribute 'description' with value 'The .NET MAUI Community Toolkit is a collection of reusable elements for application development with .NET MAUI, including animations, behaviors, converters, effects, and helpers.' is duplicated in 'maui/converters/index.md(4,14)', 'maui/index.md(4,14)'.
Line 12, Column 59: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/dotnet/maui/fundamentals/data-binding/converters' will be broken in isolated environments. Replace with a relative link.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel
Docs Build status updates of commit 6fcb8b5:
:warning: Validation status: warnings
File
Status
Preview URL
Details
docs/maui/converters/index.md
:warning:Warning
View
Details
docs/maui/TOC.yml
:white_check_mark:Succeeded
View
docs/maui/converters/index.md
Line 14, Column 1: [Warning: multiple-h1s - See documentation] Multiple H1s(H1 '.NET MAUI Community Toolkit Converters') are not allowed. You can only have one top-level heading.
Line 4, Column 14: [Suggestion: duplicate-descriptions - See documentation] Attribute 'description' with value 'The .NET MAUI Community Toolkit is a collection of reusable elements for application development with .NET MAUI, including animations, behaviors, converters, effects, and helpers.' is duplicated in 'maui/converters/index.md(4,14)', 'maui/index.md(4,14)'.
For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel
Docs Build status updates of commit 1be5598:
:white_check_mark: Validation status: passed
File
Status
Preview URL
Details
docs/maui/TOC.yml
:white_check_mark:Succeeded
View
docs/maui/converters/index.md
:white_check_mark:Succeeded
View
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel
PRMerger Results
Issue
Description
Added File(s)
This PR contains added files. New files require human review.
Yaml File(s)
This PR includes changes to .yml file(s) owned by another author.
File Change Percent
This PR contains file(s) with more than 20% file change.
Index File
This PR contains a change to the index file.
@bijington I like it :)
My only minor comment is there's no text between the H1 and the H2, and there should be. Alternatively, I'd dump the H2.
@bijington I like it :)
My only minor comment is there's no text between the H1 and the H2, and there should be. Alternatively, I'd dump the H2.
Good point! I can drop the first H2.
Out of interest does this TOC change mean that when a user clicks on Converters they get to see this new index page? Of course in the long run we probably won't need the child items (specific converters)
Out of interest does this TOC change mean that when a user clicks on Converters they get to see this new index page? Of course in the long run we probably won't need the child items (specific converters)
Yes. If you dump the child items then there's also no need to have an expandable Converters node e.g.
Converters
Overview
would just become:
Converters
Docs Build status updates of commit 0ae60ab:
:white_check_mark: Validation status: passed
File
Status
Preview URL
Details
docs/maui/TOC.yml
:white_check_mark:Succeeded
View
docs/maui/converters/index.md
:white_check_mark:Succeeded
View
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel
PRMerger Results
Issue
Description
Added File(s)
This PR contains added files. New files require human review.
Yaml File(s)
This PR includes changes to .yml file(s) owned by another author.
File Change Percent
This PR contains file(s) with more than 20% file change.
Index File
This PR contains a change to the index file.
Docs Build status updates of commit 2940d6d:
:white_check_mark: Validation status: passed
File
Status
Preview URL
Details
docs/maui/TOC.yml
:white_check_mark:Succeeded
View
docs/maui/converters/index.md
:white_check_mark:Succeeded
View
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel
PRMerger Results
Issue
Description
Added File(s)
This PR contains added files. New files require human review.
Yaml File(s)
This PR includes changes to .yml file(s) owned by another author.
File Change Percent
This PR contains file(s) with more than 20% file change.
Index File
This PR contains a change to the index file.
Docs Build status updates of commit 6fdfaf2:
:white_check_mark: Validation status: passed
File
Status
Preview URL
Details
docs/maui/TOC.yml
:white_check_mark:Succeeded
View
docs/maui/converters/index.md
:white_check_mark:Succeeded
View
For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel
PRMerger Results
Issue
Description
Added File(s)
This PR contains added files. New files require human review.
Yaml File(s)
This PR includes changes to .yml file(s) owned by another author.
File Change Percent
This PR contains file(s) with more than 20% file change.
Index File
This PR contains a change to the index file.
| gharchive/pull-request | 2022-03-13T22:01:34 | 2025-04-01T04:32:46.985165 | {
"authors": [
"PRMerger14",
"PRMerger4",
"PRMerger5",
"PRMerger9",
"bijington",
"davidbritch",
"opbld30",
"opbld31",
"opbld32",
"opbld33"
],
"repo": "MicrosoftDocs/CommunityToolkit",
"url": "https://github.com/MicrosoftDocs/CommunityToolkit/pull/26",
"license": "CC-BY-4.0",
"license_type": "permissive",
"license_source": "github-api"
} |
379526561 | Table examples do not render as expected
The current look of the Tables section in the Markdown reference is as follows:
Note, the all three columns are left-aligned.
At the same time, the GitHub preview of that section is as expected:
The similar issue with alignment is in another Markdown reference article. Check the last example that shows how to align column content:
I look at this issue, it looks fixed right now. All columns are alligned correctly. The left column is rendering left, the right one is rendering to the right and the centered column in rendering in the middle. I checked this also at the Github preview, the docs page. Can you check it on you're end? Otherwise this issue can be closed.
@markgort86 indeed, the issue looks to be resolved. Closing it then. Thanks!
| gharchive/issue | 2018-11-11T14:13:15 | 2025-04-01T04:32:46.989235 | {
"authors": [
"markgort86",
"pkulikov"
],
"repo": "MicrosoftDocs/Contribute",
"url": "https://github.com/MicrosoftDocs/Contribute/issues/136",
"license": "CC-BY-4.0",
"license_type": "permissive",
"license_source": "github-api"
} |
372585287 | Enable the preview
Organization wide share settings seems to be broken in some places, specifically Additional Settings, enable the preview and set sharing per-site to bypass. I wasn't even able to find an acceptable user or group using the lookup.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.
ID: 6ed46514-8036-a543-d690-73d48acef690
Version Independent ID: 8542c3ce-3012-3d23-c3e4-4331dac033d2
Content: Turn external sharing on or off for SharePoint Online
Content Source: SharePoint/SharePointOnline/turn-external-sharing-on-or-off.md
Service: sharepoint-online
GitHub Login: @MikePlumleyMSFT
Microsoft Alias: mikeplum
@nicksequeira Thank you for this feedback
I will get this information over to the SharePoint team for investigation.
The team will get this prioritized into a sprint plan. Thank you for reporting and making the docs better. Much appreciated.
I made a note to request the team to update this when the work is complete.
hello, @nicksequeira I've made a couple clarifications and they'll be live as soon as repo owner will merge it, so it should be more accurate from a content perspective. as for your mentioned issues, it looks more like a product issue and not as a content one.
Right on, glad to see y'all working on it. I'll check it out in a few weeks
thanks
On Thu, Feb 21, 2019, 08:33 Dmitri Plotnikov notifications@github.com
wrote:
hello, @nicksequeira https://github.com/nicksequeira I've made a couple
clarifications and they'll be live as soon as repo owner will merge it, so
it should be more accurate from a content perspective. as for your
mentioned issues, it looks more like a product issue and not as a content
one.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/OfficeDocs-SharePoint/issues/337#issuecomment-466000815,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALJF0wCJTLDqCcilnYbnupwez-TZytnqks5vPqAkgaJpZM4XzqiF
.
| gharchive/issue | 2018-10-22T16:05:29 | 2025-04-01T04:32:47.005269 | {
"authors": [
"AndreaBarr",
"dplotnikov",
"nicksequeira"
],
"repo": "MicrosoftDocs/OfficeDocs-SharePoint",
"url": "https://github.com/MicrosoftDocs/OfficeDocs-SharePoint/issues/337",
"license": "CC-BY-4.0",
"license_type": "permissive",
"license_source": "github-api"
} |
1339204349 | Clarification
The article states "it takes a while for them to be crawled and indexed". I understand that this is a tenant by tenant issue, can you provide guideline on how long this is expected to take? i.e. when should we raise this to support if content is not being scanned. Is this minutes? 10 of minutes? Hours?
This may be better in a separate article.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.
ID: 6a19bcff-df5b-bc9f-269d-482d44d70b61
Version Independent ID: 31a35f88-d3ca-f765-7678-339ad81771f9
Content: Mark new files as sensitive by default - SharePoint in Microsoft 365
Content Source: SharePoint/SharePointOnline/sensitive-by-default.md
Service: sharepoint-online
GitHub Login: @MikePlumleyMSFT
Microsoft Alias: mikeplum
@SanjoyanM can you help?
@mike-pshell : Your question is more related to crawling and searching of content in SPO. This feature inherits the same limitations which crawling and searching of content in SPO has.
I struggle to find a document that describes the "expected" timelines for a crawl/search for DLP
I agree but that is not related to labels. Probably you need to raise the question in DLP forum
Hi @SanjoyanM Hope all is well. Is there an update on this issue? Thanks.
@MikePlumleyMSFT and @scanum : Just FYI we DO NOT have any customer facing SLA for crawling and search in general. Also I am NOT the PM for crawling and search. You can Neetha Tuluri netulu@microsoft.com for this generic question.
Fo now since this question is not specific to this feature BUT a very generic question on SharePoint hence I request to close this issue.
As Sanjoyan mentioned above, it's best to post this to a DLP forum or as in issue on a DLP article. Closing this one out.
| gharchive/issue | 2022-08-15T16:28:11 | 2025-04-01T04:32:47.011988 | {
"authors": [
"MikePlumleyMSFT",
"SanjoyanM",
"mike-pshell",
"scanum"
],
"repo": "MicrosoftDocs/OfficeDocs-SharePoint",
"url": "https://github.com/MicrosoftDocs/OfficeDocs-SharePoint/issues/3399",
"license": "CC-BY-4.0",
"license_type": "permissive",
"license_source": "github-api"
} |
1367717631 | Report pre-requisite
[Enter feedback here]
Hi Everyone,
in this page I've read taht the report is available for Admin Global Reader AND Reports reader (in the pre-requisite section), but my Azure Admin says that it's only available to Administrator and not to Reports Reader.
Can you plese verify and eventually correct the article (or correct my Azure admin :-D)
Thank you and ciao
Stefano
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.
ID: 67197abd-ee35-668f-c454-eb4b07f4a6f9
Version Independent ID: 647d2380-5ddd-cc17-9f43-93773ff75b9c
Content: OneDrive sync reports in the Apps Admin Center - OneDrive
Content Source: OneDrive/sync-health.md
Service: one-drive
GitHub Login: @mkbond007
Microsoft Alias: mabond
Thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.
| gharchive/issue | 2022-09-09T11:48:51 | 2025-04-01T04:32:47.017429 | {
"authors": [
"savagliano",
"scanum"
],
"repo": "MicrosoftDocs/OfficeDocs-SharePoint",
"url": "https://github.com/MicrosoftDocs/OfficeDocs-SharePoint/issues/3436",
"license": "CC-BY-4.0",
"license_type": "permissive",
"license_source": "github-api"
} |
804551696 | Update direct-routing-connect-the-sbc.md
Fixed a typo
@JohanFreelancer9 Copy editing is needed for this PR. Thanks.
@CarolynRowe PR has been copyedited and is ready for final review, could you please check and merge? Thanks!
| gharchive/pull-request | 2021-02-09T13:29:01 | 2025-04-01T04:32:47.019072 | {
"authors": [
"scanum",
"thomasbinder"
],
"repo": "MicrosoftDocs/OfficeDocs-SkypeForBusiness",
"url": "https://github.com/MicrosoftDocs/OfficeDocs-SkypeForBusiness/pull/6638",
"license": "CC-BY-4.0",
"license_type": "permissive",
"license_source": "github-api"
} |
520617544 | Current SQL Server versions create more than one temp file
SQL Server 2016 and later create by default more than one temp file.
Summarize the change in the pull request title
Describe your change, specifically why you think it's needed.
Fixes #Issue_Number (if necessary)
@PanuSaukko : Thanks for your contribution! The author(s) have been notified to review your proposed change.
#sign-off
Once merged, this should be live with the next daily publishing process. Right now that should be today (Monday, 11 November) around 11:00 Pacific time. No further action needed from you.
| gharchive/pull-request | 2019-11-10T15:39:26 | 2025-04-01T04:32:47.049794 | {
"authors": [
"PRMerger16",
"PanuSaukko",
"aczechowski"
],
"repo": "MicrosoftDocs/SCCMdocs",
"url": "https://github.com/MicrosoftDocs/SCCMdocs/pull/1993",
"license": "CC-BY-4.0",
"license_type": "permissive",
"license_source": "github-api"
} |
297316927 | Windows Defender Exploit Guard (Not Device Exploit Guard)
Fixed typo and added link.
Thanks @npherson! One quick ask: please remove "en-us" from the URL. Leave the link language neutral, then the browser handles redirection to the proper localized repo.
Looks good, merging now.
| gharchive/pull-request | 2018-02-15T03:06:44 | 2025-04-01T04:32:47.051210 | {
"authors": [
"aczechowski",
"npherson"
],
"repo": "MicrosoftDocs/SCCMdocs",
"url": "https://github.com/MicrosoftDocs/SCCMdocs/pull/395",
"license": "CC-BY-4.0",
"license_type": "permissive",
"license_source": "github-api"
} |
1519623338 | Fix role requirements in plan-topic-experiences.md
Closes https://github.com/MicrosoftDocs/Viva/issues/484.
@ruthholls
PR has been copyedited and is ready for final review, could you please check and merge? Thanks!
| gharchive/pull-request | 2023-01-04T21:50:21 | 2025-04-01T04:32:47.052808 | {
"authors": [
"dariomws",
"scanum"
],
"repo": "MicrosoftDocs/Viva",
"url": "https://github.com/MicrosoftDocs/Viva/pull/492",
"license": "CC-BY-4.0",
"license_type": "permissive",
"license_source": "github-api"
} |
1031833645 | Include package name in the Package column
This page Azure libraries packages for JavaScript has 2 tables that list various packages. The package column links to the package in npm along with the latest package version
Instead of the word "npm" that is repeated in every row, it would be more useful to have the package name which is not listed anywhere.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.
ID: 003f9d64-7106-95d8-21ab-ea4f9c6208b6
Version Independent ID: 84b70b16-9f60-d175-3d76-b845c15b2d7b
Content: Azure SDK libraries for JavaScript - Azure
Content Source: articles/javascript/azure-sdk-library-package-index.md
Product: azure-nodejs
GitHub Login: @diberry
Microsoft Alias: diberry
Logged - Package listings table design · Issue #3561 · Azure/azure-sdk (github.com)
@ramya-rao-a @weshaggard Is there anything with this issue or can it be closed?
This issue has been closed for a while @diberry :)
| gharchive/issue | 2021-10-20T21:10:49 | 2025-04-01T04:32:47.073352 | {
"authors": [
"diberry",
"ramya-rao-a"
],
"repo": "MicrosoftDocs/azure-dev-docs",
"url": "https://github.com/MicrosoftDocs/azure-dev-docs/issues/621",
"license": "CC-BY-4.0",
"license_type": "permissive",
"license_source": "github-api"
} |
1347065740 | Is there a version for VS For MAC?
The section of the tutorial: https://docs.microsoft.com/en-us/azure/devops/pipelines/artifacts/symbols?view=azure-devops#set-up-visual-studio
is there a version for visual studio for Mac?
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.
ID: bdb2bfcb-0a0c-ce90-fa49-ad2e7fbaa57a
Version Independent ID: 1a295877-ff8f-f8c2-0349-76a69a0f5cfc
Content: Publish symbols with Azure Pipelines - Azure Pipelines
Content Source: docs/pipelines/artifacts/symbols.md
Product: devops
Technology: devops-cicd-artifacts
GitHub Login: @ramiMSFT
Microsoft Alias: rabououn
@Leonardo-Ferreira -- Leonardo, thank you for your question. Please consider these resources and let me know if they help answer:
Azure DevOps Services
Azure DevOps on Stack Overflow
Hi @WilliamAntonRohm yeah, I reviewed those before posting my question here... If I had found a suitable answer, I'd be here suggesting that the documentation reflected such answer.
Because I couldn't find neither a positive or negative answer, I decided to query around here... any chance you can get in touch with the specialists directly and simply ask them if this integration is possible on vs for Mac?
@Leonardo-Ferreira Thanks for your feedback! This feature is not support in VS for Mac. I'm updating the guide shortly
| gharchive/issue | 2022-08-22T22:27:48 | 2025-04-01T04:32:47.079693 | {
"authors": [
"Leonardo-Ferreira",
"WilliamAntonRohm",
"ramiMSFT"
],
"repo": "MicrosoftDocs/azure-devops-docs",
"url": "https://github.com/MicrosoftDocs/azure-devops-docs/issues/12604",
"license": "CC-BY-4.0",
"license_type": "permissive",
"license_source": "github-api"
} |
491393336 | Missing instruction
The unix install of the client tells you how to install the client but not how to register the server into the Azure Portal into the File Sync group. The client is installed but wheres the step to register the server into the Azure File Sync service.
Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.
ID: 93174b3a-3e97-8304-83fc-807be75198fe
Version Independent ID: 1155045b-ce8c-2def-7b0e-043283f8be01
Content: Sign in with the Azure CLI
Content Source: docs-ref-conceptual/authenticate-azure-cli.md
Technology: azure-cli
GitHub Login: @sptramer
Microsoft Alias: sttramer
Sorry, but this article only covers the installation of the Azure CLI. I looked for one, and didn't see a CLI extension for File Sync, either. The best way to find the information that you're looking for is to check the Azure Files documentation.
| gharchive/issue | 2019-09-10T00:54:24 | 2025-04-01T04:32:47.084281 | {
"authors": [
"cosmicbubble69",
"sptramer"
],
"repo": "MicrosoftDocs/azure-docs-cli",
"url": "https://github.com/MicrosoftDocs/azure-docs-cli/issues/1582",
"license": "CC-BY-4.0",
"license_type": "permissive",
"license_source": "github-api"
} |
1679572427 | Incorrect Subnet numbers in the document
The latest diagram under Virtual network and on-premises workloads using a DNS forwarder shows that the on-premise network and the spoke Vnet both have the same range (10.0.0.0) which is incorrect.
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.
ID: a88af182-32aa-a8f3-359d-b92ae1cfb8c7
Version Independent ID: 01ce07fc-4bc2-def5-9ecd-a80330ad9488
Content: Azure Private Endpoint DNS configuration
Content Source: articles/private-link/private-endpoint-dns.md
Service: private-link
GitHub Login: @asudbring
Microsoft Alias: allensu
@FadyMuhareb
Thanks for your feedback! We will investigate and update as appropriate.
@FadyMuhareb
Thank you for your feedback! We have assigned this issue to the author to review further and take the next course of action.
@asudbring the described issue is in this section https://learn.microsoft.com/en-us/azure/private-link/private-endpoint-dns#virtual-network-and-on-premises-workloads-using-a-dns-forwarder
Fixed diagram in PR 247389
#please-close
| gharchive/issue | 2023-04-22T14:48:15 | 2025-04-01T04:32:47.108801 | {
"authors": [
"ChaitanyaNaykodi-MSFT",
"FadyMuhareb",
"RamanathanChinnappan-MSFT",
"asudbring"
],
"repo": "MicrosoftDocs/azure-docs",
"url": "https://github.com/MicrosoftDocs/azure-docs/issues/108613",
"license": "CC-BY-4.0",
"license_type": "permissive",
"license_source": "github-api"
} |
1695846118 | Page UX
First you see table with some information, and versions in this table are not the latest. I think it would be helpful to add Recommended Versions in message, that says that its recommended to user the latest versions.
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.
ID: c4272fbd-ad3d-6099-39bc-966320101b03
Version Independent ID: ac21035f-4145-b309-d45c-3c38e965301d
Content: Page layout versions - Azure AD B2C
Content Source: articles/active-directory-b2c/page-layout.md
Service: active-directory
Sub-service: b2c
GitHub Login: @kengaderdus
Microsoft Alias: kengaderdus
@khanermi
Thanks for your feedback! We will investigate and update as appropriate.
@khanermi
Thanks for bringing this to our attention.
I'm going to assign this to the document author so they can take a look at it accordingly
@kengaderdus
Could you Please review this and update as appropriate.
Thank you for your feedback and we apologize for the delay in our response. We're working to update our documentation. However, please be aware that it may take some time for the updates to be reflected on our documentation site. Thank you for your patience and understanding. #please-close
| gharchive/issue | 2023-05-04T11:43:57 | 2025-04-01T04:32:47.114397 | {
"authors": [
"ManoharLakkoju-MSFT",
"Naveenommi-MSFT",
"kengaderdus",
"khanermi"
],
"repo": "MicrosoftDocs/azure-docs",
"url": "https://github.com/MicrosoftDocs/azure-docs/issues/109079",
"license": "CC-BY-4.0",
"license_type": "permissive",
"license_source": "github-api"
} |
1760530898 | The example contains the driver/protocol abs:// (is this up to date?)
Hi
The headline of the article is Data virtualization with Azure SQL Managed Instance
Why does this article contains an example of creating an external table in a Azure SQL Managed Instance, the example starts here https://learn.microsoft.com/en-us/azure/azure-sql/managed-instance/data-virtualization-overview?view=azuresql&tabs=shared-access-signature#external-tables
The CREATE EXTERNAL TABLE example uses a DATA_SOURCE NYCTaxiExternalDataSource which is created like this
--Create the data source first:
CREATE EXTERNAL DATA SOURCE NYCTaxiExternalDataSource
WITH (
LOCATION = 'abs://nyctlc@azureopendatastorage.blob.core.windows.net'
)
It uses the protocol/driver abs:// - the NYCTaxi eksample works fine for me.
But when I create my own Azure Store Account it’s not possibly to use this protocol/driver, I get the error:
Msg 16562, Level 16, State 1, Line 115
External table 'dbo.tbl_AccountingDistribution' is not accessible because location does not exist, or it is used by another process.
Is it possible to create External table pointing to files located in Azure Storage Accounts – I’m only managed to load data using Bulk Insert or Openrow set?
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.
ID: 0dc34a87-df33-0f50-0df5-5c1224cbce8b
Version Independent ID: 4d412754-8858-b80d-b5b4-3412d5bf064a
Content: Data virtualization - Azure SQL Managed Instance
Content Source: azure-sql/managed-instance/data-virtualization-overview.md
Service: sql-managed-instance
Sub-service: service-overview
GitHub Login: @MladjoA
Microsoft Alias: mlandzic
@nesmoht Thank you for your feedback. We will review this and get back shortly.
Hello @nesmoht , I can confirm that abs:// prefix in the example is up to date, and that data virtualization in Azure SQL Managed Instance supports creating and querying external tables pointing to file(s) stored in Azure Blob Storage.
The error message you got indicates that there were issues with either:
a. access rights granted on the storage account, or
b. accessing the storage account on the network level;
For a. access rights, please check the following section of the same document:
https://learn.microsoft.com/en-us/azure/azure-sql/managed-instance/data-virtualization-overview?view=azuresql&tabs=shared-access-signature#access-to-nonpublic-storage-accounts
It explains how to provide credentials to access storage account. Note that there are two tabs, describing authentication using managed identity (preferred), or SAS key. In both cases it's not enough to just provide credentials. Read access also needs to be granted to the specific SAS key or managed identity.
For b. detailed troubleshooting goes beyond the scope of GitHub issue, and I can list just a few possible causes: Check whether storage account has service endpoint enabled, which might not be configured on the VNet hosting your managed instance. Also, check whether the outgoing traffic to storage account is enabled on the VNet hosting your managed instance. Finally, check whether storage account has access list defined.
Hopefully this helps.
Hi @nesmoht , thanks for contacting Microsoft! It seems your question was addressed - however if your issue persists, you may need to engage support resources as it's outside the scope of improving documentation.
I'll go ahead and close out this Git Issue but please feel free to comment should you need anything further.
Thanks again and I hope you have a wonderful rest of your day!
Masha from the SQL Docs team
#please-close
| gharchive/issue | 2023-06-16T12:21:16 | 2025-04-01T04:32:47.124790 | {
"authors": [
"MashaMSFT",
"MladjoA",
"Oury-MSFT",
"nesmoht"
],
"repo": "MicrosoftDocs/azure-docs",
"url": "https://github.com/MicrosoftDocs/azure-docs/issues/110990",
"license": "CC-BY-4.0",
"license_type": "permissive",
"license_source": "github-api"
} |
1856426331 | Please update SSO information to include servicenowservices.com (FedRamp) instances
Please update the documentation to include instances that have moved to FedRamp and thus have a servicenowservices.com URL
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.
ID: d507f0ce-f27f-1ffd-7129-7bb4e37b07ff
Version Independent ID: ec9f7c43-e967-d2e7-cde7-111c5897a798
Content: Tutorial: Azure Active Directory single sign-on (SSO) integration with ServiceNow - Microsoft Entra
Content Source: articles/active-directory/saas-apps/servicenow-tutorial.md
Service: active-directory
Sub-service: saas-app-tutorial
GitHub Login: @jeevansd
Microsoft Alias: jeedes
@bw44
Thanks for your feedback! We will investigate and update as appropriate.
@jeevansd
Can you please check and add your comments on this doc update request as applicable.
@bw44
Thanks for bringing this to our attention.
I'm going to assign this to the document author so they can take a look at it accordingly
we are working on the issue, will reflects the suggested changes into the main article soon.
#please-close
| gharchive/issue | 2023-08-18T09:54:34 | 2025-04-01T04:32:47.131525 | {
"authors": [
"AjayBathini-MSFT",
"ManoharLakkoju-MSFT",
"bw44",
"v-hgampala"
],
"repo": "MicrosoftDocs/azure-docs",
"url": "https://github.com/MicrosoftDocs/azure-docs/issues/113685",
"license": "CC-BY-4.0",
"license_type": "permissive",
"license_source": "github-api"
} |
1883949086 | Unclear sentence
Wait for every instance in the source slot to complete its restart. If any instance fails to restart, the swap operation reverts all changes to the source slot and stops the operation.
Should not be here "in the target slot"?
[Enter feedback here]
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.
ID: f6e09089-1ae2-8943-5ce2-9d48f458c81f
Version Independent ID: ba780cba-f604-b0a4-a81a-23c7d2384762
Content: Set up staging environments - Azure App Service
Content Source: articles/app-service/deploy-staging-slots.md
Service: app-service
GitHub Login: @cephalin
Microsoft Alias: cephalin
@deivyd321
Thanks for your feedback! We will investigate and update as appropriate.
@deivyd321 Thank you for bringing this up. We always strive to ensure the docs bring clarity but sometimes something slips by. We have gone ahead and made an edit. The change should be merged and visible within the next day or so.
We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue.
This edit is wrong as #114827 points out. The target slot is the production slot, which would not be restarted during the swap. The PR from this ticket should be reverted.
| gharchive/issue | 2023-09-06T12:50:19 | 2025-04-01T04:32:47.136949 | {
"authors": [
"BryanTrach-MSFT",
"ErikPilsits-RJW",
"ManoharLakkoju-MSFT",
"deivyd321"
],
"repo": "MicrosoftDocs/azure-docs",
"url": "https://github.com/MicrosoftDocs/azure-docs/issues/114367",
"license": "CC-BY-4.0",
"license_type": "permissive",
"license_source": "github-api"
} |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.