Diff stringlengths 10 2k | Message stringlengths 28 159 |
|---|---|
return Tool.convertSystemPermissions(perms).contains(permission); | 2 duplicated blocks of code must be removed. |
super();
this.setSource(iterator);
this.maxVersions = maxVersions; | Define and throw a dedicated exception instead of using a generic one. |
import org.apache.accumulo.core.util.shell.Token; | Replace all tab characters in this file by sequences of white-spaces. |
/**
* Autogenerated by Thrift Compiler (0.9.0)
*
* DO NOT EDIT UNLESS YOU ARE SURE THAT YOU KNOW WHAT YOU ARE DOING
* @generated
*/
package org.apache.accumulo.proxy.thrift;
import java.util.Map;
import java.util.HashMap;
import org.apache.thrift.TEnum;
public enum CompactionType implements org.apache.thrift.T... | Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. |
import java.util.Collections;
import org.apache.accumulo.core.data.ArrayByteSequence;
* This iterator will *ignore* any columnFamilies passed to {@link #seek(Range, Collection, boolean)} as it performs intersections
* over terms. Extending classes should override the {@link TermSource#seekColfams} in their implementa... | Make seekColfams a static final constant or non-public and provide accessors if needed. |
import org.apache.accumulo.core.client.BatchWriterConfig;
BatchWriter bw = c.createBatchWriter(Constants.METADATA_TABLE_NAME, new BatchWriterConfig());
BatchWriter bw = connector.createBatchWriter("!METADATA", new BatchWriterConfig()); | Remove this unused method parameter "e". |
args = processOptions(args);
pass = args[1].getBytes(); | Remove this unused method parameter "ex". |
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not... | Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. |
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not u... | Replace all tab characters in this file by sequences of white-spaces. |
package normalizer;
import java.text.Normalizer;
import java.text.Normalizer.Form;
import java.util.Locale;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
/**
* An {@link Normalizer} which performs the following steps:
* <ol>
* <li>Unicode canonical decomposition ({@link Form#NFD})</li>
* <li... | Return empty string instead. |
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not u... | Replace all tab characters in this file by sequences of white-spaces. |
if (failures != null && failures.length > 0) {
throw new Exception(failures.length + " failure files found importing files from " + dir);
} | Define and throw a dedicated exception instead of using a generic one. |
@Override
public org.apache.hadoop.util.bloom.Key transform(org.apache.accumulo.core.data.Key acuKey) {
byte keyData[];
ByteSequence row = acuKey.getRowData();
keyData = new byte[row.length()];
System.arraycopy(row.getBackingArray(), 0, keyData, 0, row.length());
return new org.apache.hadoop.... | Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. |
import org.apache.accumulo.server.mini.MiniAccumuloCluster; | This block of commented-out lines of code should be removed. |
shellState.getReader().println("Table: [" + tableName + "] has been deleted."); | Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. |
return ((matches(rowMatcher, rowMatcher == null ? null : key.getRowData()))
|| (matches(colfMatcher, colfMatcher == null ? null : key.getColumnFamilyData()))
|| (matches(colqMatcher, colqMatcher == null ? null : key.getColumnQualifierData())) || (matches(valueMatcher, value.get(), 0, value.get... | Remove the literal "false" boolean value. |
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not... | Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. |
import org.apache.accumulo.core.security.Authorizations;
@Parameter(names = {"-s", "--size"}, description = "merge goal size", converter = MemoryConverter.class)
@Parameter(names = {"-f", "--force"}, description = "merge small tablets even if merging them to larger tablets might cause a split")
@Paramete... | Remove this unused method parameter "range". |
return newTableName.getBytes(); | Remove this unused method parameter "ex". |
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not... | Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. |
if (parent == null && left == null && right == null && contents == null)
return true;
if (left != null)
out += left.toString();
if (right != null)
out += right.toString(); | Remove this call to "exit" or ensure it is really required. |
import org.apache.accumulo.mini.MiniAccumuloCluster; | This block of commented-out lines of code should be removed. |
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not u... | Replace all tab characters in this file by sequences of white-spaces. |
public void setAccumuloConfigs(Job job) {
AccumuloInputFormat.setConnectorInfo(job, user, getPassword());
AccumuloOutputFormat.setConnectorInfo(job, user, getPassword()); | Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. |
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not u... | Replace all tab characters in this file by sequences of white-spaces. |
package org.apache.accumulo.server.test.functional;
import java.io.File;
import org.apache.accumulo.core.zookeeper.ZooUtil.NodeMissingPolicy;
import org.apache.accumulo.server.zookeeper.ZooReaderWriter;
public class CacheTestClean {
/**
* @param args
*/
public static void main(String[] args) throws Exception... | Return empty string instead. |
import org.apache.accumulo.core.client.mapreduce.lib.util.FileOutputConfigurator; | Return empty string instead. |
long sleepTime;
@Override
public SortedKeyValueIterator<Key,Value> deepCopy(IteratorEnvironment env) {
throw new UnsupportedOperationException();
}
@Override
public void next() throws IOException {
UtilWaitThread.sleep(sleepTime);
super.next();
}
@Override
public void init(Sort... | Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. |
import static org.powermock.api.easymock.PowerMock.createMock;
import static org.powermock.api.easymock.PowerMock.expectLastCall;
import static org.powermock.api.easymock.PowerMock.expectNew;
import static org.powermock.api.easymock.PowerMock.mockStatic;
import static org.powermock.api.easymock.PowerMock.replay;
import... | Define a constant instead of duplicating this literal "host3,host4" 4 times. |
import org.apache.accumulo.cloudtrace.instrument.Tracer;
import org.apache.accumulo.core.tabletserver.thrift.TabletClientService.Client;
Client client = ThriftUtil.getClient(new TabletClientService.Client.Factory(), tserver.getLocation(), configuration.getConfiguration());
List<TabletStats> onlineTabletsForTa... | Immediately return this expression instead of assigning it to the temporary variable "client". |
private static final List<Pair<Long,Double>> loadOverTime = Collections.synchronizedList(new MaxList<Double>(MAX_TIME_PERIOD));
private static final List<Pair<Long,Double>> ingestRateOverTime = Collections.synchronizedList(new MaxList<Double>(MAX_TIME_PERIOD));
private static final List<Pair<Long,Double>> ingestB... | Move this variable to comply with Java Code Conventions. |
package test;
public interface Test {
public String hello();
public int add();
} | Return empty string instead. |
org.apache.thrift.protocol.TMap _map88 = iprot.readMapBegin();
struct.properties = new HashMap<String,String>(2*_map88.size);
for (int _i89 = 0; _i89 < _map88.size; ++_i89)
String _key90; // required
String _val91; // required
... | Return empty string instead. |
at = serverConfiguration.getInstance().getAuthenticator().login(principal, props); | Remove this unused method parameter "principal". |
import org.apache.accumulo.core.security.tokens.AuthenticationToken;
* <li>{@link AccumuloInputFormat#setConnectorInfo(JobConf, String, AuthenticationToken)} OR {@link AccumuloInputFormat#setConnectorInfo(JobConf, Path)} | Remove the redundant '!unknownSymbol!' thrown exception declaration(s). |
private static UserPass userpass = new UserPass("root", ByteBuffer.wrap(secret.getBytes()));
private static ByteBuffer creds = null;
creds = client.login(userpass);
ByteBuffer stooge = client.login(new UserPass("stooge", s2bb("")));
| Replace this use of System.out or System.err by a logger. |
if (destination == null)
return null;
if (client != null) {
try {
client.span(s);
} catch (Exception ex) {
client.getInputProtocol().getTransport().close();
client = null;
}
} | Either log or rethrow this exception. |
import java.nio.charset.Charset;
private static final Charset utf8 = Charset.forName("UTF8");
super(string, timeInMillis, SCHEME, (USER + ":" + secret).getBytes(utf8)); | Move this variable to comply with Java Code Conventions. |
package org.apache.accumulo.server.tabletserver.log;
import static java.lang.Math.min;
import java.util.ArrayList;
import java.util.Collections;
import java.util.HashSet;
import java.util.List;
import java.util.Set;
import org.apache.accumulo.server.tabletserver.TabletServer;
public class RandomLoggerStrategy exte... | Return empty string instead. |
package org.apache.accumulo.core.util.shell.commands;
import java.util.ArrayList;
import java.util.List;
import org.apache.accumulo.core.client.admin.InstanceOperations;
import org.apache.accumulo.core.util.shell.Shell;
import org.apache.accumulo.core.util.shell.Shell.Command;
import org.apache.commons.cli.CommandLin... | Return empty string instead. |
* List the active compaction running on a tablet server
*
* @param tserver
* The tablet server address should be of the form <ip address>:<port>
* @return the list of active compactions
* @throws AccumuloException
* @throws AccumuloSecurityException
*/
public List<ActiveCompaction... | Return empty string instead. |
package org.apache.accumulo.examples.simple.client; | Rename "table" which hides the field declared at line 107. |
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may ... | Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. |
Map<String,Long> lowBulkFiles = MetadataTable.getBulkFilesLoaded(SecurityConstants.getSystemCredentials(), low);
Map<String,Long> highBulkFiles = MetadataTable.getBulkFilesLoaded(SecurityConstants.getSystemCredentials(), high);
if (!lowBulkFiles.equals(highBulkFiles)) {
throw new Exception("... | Define and throw a dedicated exception instead of using a generic one. |
@Deprecated
@Deprecated | Remove this unused private "appendProp" method. |
import org.apache.accumulo.core.security.tokens.AuthenticationToken; | 1 duplicated blocks of code must be removed. |
/**
* Provides programs to analyze metadata mutations written to write ahead logs.
*
* <p>
* These programs can be used when write ahead logs are archived. The best way to find
* which write ahead logs contain metadata mutations is to grep the tablet server logs.
* Grep for events where walogs were added t... | Either log or rethrow this exception. |
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not... | Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. |
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may ... | Remove this unused private "appendProp" method. |
import org.apache.hadoop.fs.Trash;
Trash trash = new Trash(fs, fs.getConf());
Path deleteFile = new Path(location + "/delete+" + compactName + "+" + path.getName());
if (!trash.moveToTrash(deleteFile))
fs.delete(deleteFile, true); | Remove this unused import 'org.apache.hadoop.fs.Trash'. |
// it doesn't seem like you should have to do this, but java serialization is wacky, and doesn't call the default constructor.
__isset_bit_vector = new BitSet(1); | Move this variable to comply with Java Code Conventions. |
@Override
public void visit(State state, Properties props) throws Exception {
// delete documents that where the document id matches a given pattern from doc and index table
// using the batch deleter
Random rand = (Random) state.get("rand");
String indexTableName = (String) state.get("indexTable... | Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. |
import org.apache.accumulo.core.security.tokens.PasswordToken; | Replace all tab characters in this file by sequences of white-spaces. |
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not... | Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. |
org.apache.thrift.protocol.TList _list35 = iprot.readListBegin();
this.arguments = new ArrayList<ByteBuffer>(_list35.size);
for (int _i36 = 0; _i36 < _list35.size; ++_i36)
ByteBuffer _elem37;
_elem37 = iprot.readBinary();
... | Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. |
private static final Logger log = Logger.getLogger(ZooTraceClient.class);
final ZooReader zoo;
final String path;
final Random random = new Random();
final List<String> hosts = new ArrayList<String>();
public ZooTraceClient(ZooReader zoo, String path, String host, String service, long millis) throw... | Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. |
import org.apache.accumulo.core.security.Credentials;
hasPerm = WalkingSecurity.get(state).canChangePassword(new Credentials(principal, token).toThrift(state.getInstance()), target); | Immediately return this expression instead of assigning it to the temporary variable "onlineTabletsForTable". |
log.debug("completing bulk import transaction " + tid);
ZooArbitrator.cleanup(Constants.BULK_ARBITRATOR_TYPE, tid); | Return empty string instead. |
mdScanner.close(); | Extract the assignment out of this expression. |
System.out.printf("%d\t%d%n", i, timeMemoryLoad(1, i * 60000l)); | Use isEmpty() to check whether the collection is empty or not. |
String bulkDir = "/tmp/concurrent_bulk/b_" + String.format("%016x", rand.nextLong() & 0x7fffffffffffffffl);
rows.add(rand.nextLong() & 0x7fffffffffffffffl);
long val = rand.nextLong() & 0x7fffffffffffffffl; | Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. |
@Override
public void unableToMonitorLockNode(final Throwable e) {
Halt.halt(-1, new Runnable() {
@Override
public void run() {
log.fatal("No longer able to monitor lock node ", e);
}
});
} | Remove this call to "exit" or ensure it is really required. |
import org.apache.accumulo.core.util.shell.commands.ListIterCommand;
private Map<String,Class<? extends Formatter>> tableFormatters = new HashMap<String,Class<? extends Formatter>>();
new ImportDirectoryCommand(), new InfoCommand(), new InsertCommand(), new ListIterCommand(), new ListScansCommand(), new Maste... | Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. |
/**
* A Filter that matches entries with a non-empty ColumnVisibility.
*/ | Remove the literal "true" boolean value. |
* Autogenerated by Thrift Compiler (0.9.0)
import org.apache.thrift.protocol.TProtocolException;
import org.apache.thrift.EncodingUtils;
import org.apache.thrift.TException;
@SuppressWarnings("all") public class ConstraintViolationException extends TException implements org.apache.thrift.TBase<ConstraintViolationExcep... | Rename this class name to match the regular expression '^[A-Z][a-zA-Z0-9]*$'. |
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not u... | Replace all tab characters in this file by sequences of white-spaces. |
import org.apache.accumulo.core.util.MetadataTable;
BatchWriter bw = connector.createBatchWriter(MetadataTable.NAME, new BatchWriterConfig());
BatchWriter bw = connector.createBatchWriter(MetadataTable.NAME, new BatchWriterConfig());
MetadataTable.DIRECTORY_COLUMN.put(mut, new Value(dir.getBytes()))... | Use "Long.toString" instead. |
String loadedFile = entry.getKey().getColumnQualifier().toString(); | Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. |
final long MINUTES = 3 * 60 * 1000;
tServerList.addSortableColumn("Last Contact", new DurationType(0l, (long) Math.min(avgLastContact * 4, MINUTES)), null); | Refactor this code to not nest more than 3 if/for/while/switch/try statements. |
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may ... | Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. |
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not u... | Replace all tab characters in this file by sequences of white-spaces. |
import org.apache.accumulo.core.cli.ClientOnRequiredTable;
import com.beust.jcommander.IStringConverter;
import com.beust.jcommander.Parameter;
static class MemoryConverter implements IStringConverter<Long> {
@Override
public Long convert(String value) {
return AccumuloConfiguration.getMemoryInBytes(va... | Remove this call to "exit" or ensure it is really required. |
@Deprecated // since 1.5
final Option principalOption = new Option("pr", "principal", true, "principal (defaults to your OS user)");
@Deprecated // since 1.5
final Option loginOption = new Option("l", "login property", true, "login properties in the format key=value. Reuse -l for each property and/or comma sepe... | Rename "principal" which hides the field declared at line 173. |
if (new ColumnFQ(update).equals(Constants.METADATA_SPLIT_RATIO_COLUMN)) {
isSplitMutation = update.isDeleted(); | Replace all tab characters in this file by sequences of white-spaces. |
return new String[] {fullPath};
return new String[] {fullPath};
public static String[] getRootTableDirs() {
return prefix(getTablesDirs(), RootTable.ID);
}
return prefix(getRootTableDirs(), RootTable.ZROOT_TABLET)[0]; | Reduce this switch case number of lines from 12 to at most 5, for example by extracting code into methods. |
import java.io.File;
static TemporaryFolder tempFolder = new TemporaryFolder(new File(System.getProperty("user.dir") + "/target"));
public void testZookeeperPort() {
Map<String,String> siteConfig = new HashMap<String,String>(); | Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. |
import java.util.Properties;
// zookeeper uses Properties to read its config, so use that to write inorder to properly escape things like Windows paths
Properties zooCfg = new Properties();
zooCfg.setProperty("tickTime", "1000");
zooCfg.setProperty("initLimit", "10");
zooCfg.setProperty("syncLi... | Use "Integer.toString" instead. |
String prefix = Constants.METADATA_DELETE_FLAG_PREFIX;
if (tableId.equals(Constants.METADATA_TABLE_ID))
prefix = Constants.METADATA_DELETE_FLAG_FOR_METADATA_PREFIX;
delFlag = new Mutation(new Text(prefix + pathToRemove.substring(2)));
delFlag = new Mutation(new Text(prefix + "/" + tableId + p... | Move this variable to comply with Java Code Conventions. |
@Override
public void removeScanIterator(String iteratorName) {}
| Define and throw a dedicated exception instead of using a generic one. |
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not u... | Replace all tab characters in this file by sequences of white-spaces. |
log.info("files " + fileMap.keySet() + " not imported to " + new KeyExtent(tke) + ": " + ioe.getMessage()); | Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. |
if (loginOptions != null && !cl.hasOption(tokenOption.getOpt()))
throw new IllegalArgumentException("Must supply '-" + tokenOption.getOpt() + "' option with '-" + loginOption.getOpt() + "' option");
if (loginOptions == null && cl.hasOption(tokenOption.getOpt()))
throw new IllegalArgum... | Define a constant instead of duplicating this literal "' option" 3 times. |
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not u... | Replace all tab characters in this file by sequences of white-spaces. |
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may ... | Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. |
package org.apache.accumulo.trace.instrument.receivers; | Remove the redundant '!unknownSymbol!' thrown exception declaration(s). |
import java.util.TreeMap;
import org.apache.accumulo.core.iterators.TypedValueCombiner.Encoder;
private static final Encoder<Long> encoder = new LongCombiner.LongEncoder();
tm.put(k, new Value(encoder.encode(j)));
assertTrue(16 < encoder.decode(e.getValue().get()));
assertTrue(16 < encoder.dec... | 1 duplicated blocks of code must be removed. |
package org.apache.accumulo.core.file.blockfile;
import java.io.IOException;
/**
*
* Provides a generic interface for a Reader for a BlockBaseFile format.
* Supports the minimal interface required.
*
* Read a metaBlock and a dataBlock
*
*/
public interface BlockFileReader{
public ABlockReader getMeta... | Return empty string instead. |
org.apache.thrift.protocol.TList _list78 = iprot.readListBegin();
struct.conditions = new ArrayList<TCondition>(_list78.size);
for (int _i79 = 0; _i79 < _list78.size; ++_i79)
TCondition _elem80; // required
_elem80 = new TCondition();
... | 320 duplicated blocks of code must be removed. |
private static AtomicLong nextCompactorID = new AtomicLong(0);
// a unique id to identify a compactor
private long compactorID = nextCompactorID.getAndIncrement();
protected volatile Thread thread;
public long getID() {
return compactor.compactorID;
}
public KeyExtent getExtent() {
... | 1 duplicated blocks of code must be removed. |
* @deprecated since 1.4, replaced by {@link org.apache.accumulo.core.iterators.user.VersioningIterator} | Do not forget to remove this deprecated code someday. |
System.out.printf(" %s %,d %6.3f%n", Arrays.asList(columns), count, (t2 - t1) / 1000.0); | Use isEmpty() to check whether the collection is empty or not. |
if (obj == null)
return "-";
if (total != 0)
percent = (num / total) * 100;
if (percent < 1)
width = 0;
else if (percent > 100)
width = 100;
else
width = (int) percent; | Remove this call to "exit" or ensure it is really required. |
import com.google.common.net.HostAndPort;
private HostAndPort clientAddress;
private HostAndPort startServer(AccumuloConfiguration conf, String address, Property portHint, TProcessor processor, String threadName) throws UnknownHostException {
private HostAndPort startTabletClientService() throws UnknownHostExcep... | Remove this unused method parameter "threadName". |
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not... | Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. |
import org.apache.accumulo.cloudtrace.instrument.Span;
import org.apache.accumulo.cloudtrace.instrument.Trace; | Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. |
import org.apache.accumulo.core.security.ColumnVisibility;
m = new ServerMutation(new Text("row"));
m.put(new Text("cf"), new Text("cq"), new ColumnVisibility("vis"), 12345, new Value("value".getBytes()));
m.put(new Text("cf"), new Text("cq"), new ColumnVisibility("vis2"), new Value("value".getBytes()));
... | Remove this unused private "appendProp" method. |
public static final Set<ByteSequence> EMPTY_CF_SET = Collections.emptySet(); | Remove this unused private "appendProp" method. |
import org.apache.accumulo.server.fs.VolumeManager;
import org.apache.hadoop.fs.Path;
public void recover(VolumeManager fs, Tablet tablet, List<Path> logs, Set<String> tabletFiles, MutationReceiver mr) throws IOException {
SortedLogRecovery recovery = new SortedLogRecovery(fs); | Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. |
if (fs.exists(lowDirectoryPath) || fs.mkdirs(lowDirectoryPath))
return lowDirectory;
if (fs.exists(lowDirectoryPath))
throw new IllegalStateException("Dir exist when it should not " + lowDirectoryPath);
if (fs.mkdirs(lowDirectoryPath))
return lowDirector... | Remove this call to "exit" or ensure it is really required. |
Connector connector = accumulo.getConnector("root", secret); | Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.