hash stringlengths 16 16 | value dict | prompt listlengths 12 12 |
|---|---|---|
033b0baff52bb483 | {
"callgraph": "[FindFiles->[Builder->[asOfTime->[inSnapshot],inPartitions->[inPartitions]]]]",
"msg": "If there are no manifests, then entries should be `CloseableIterable.empty()`, not the manifest iterable. That doesn't need to be closeable.",
"patch": "@@ -191,7 +191,10 @@ public class FindFiles {\n Snapshot snapshot = snapshotId != null ?\n ops.current().snapshot(snapshotId) : ops.current().currentSnapshot();\n \n- CloseableIterable<ManifestEntry> entries = new ManifestGroup(ops, snapshot.manifests())\n+ // snapshot could be null when the table just gets created\n+ Iterable<ManifestFile> manifests = (snapshot != null) ? snapshot.manifests() : CloseableIterable.empty();\n+\n+ CloseableIterable<ManifestEntry> entries = new ManifestGroup(ops, manifests)\n .filterData(rowFilter)\n .filterFiles(fileFilter)\n .filterPartitions(partitionFilter)",
"summary": "Collect all data files in the manifest."
} | [
{
"content": "Please Give FORMAL Codereview for software developers in one sentence from the given diff hunk. Don’t start with Codereview/review. Just give the answer. Five examples are given before with code and code review and the code to work on is given after.",
"role": "user"
},
{
"content": "C... |
c1752542d5b833d3 | {
"callgraph": "[OpenTelemetryProtocolExporterEventSource->[FailedToReachCollector->[FailedToReachCollector],ExportMethodException->[ExportMethodException]]]",
"msg": "Didn't went with backwards compatibility since it's still in beta",
"patch": "@@ -26,11 +26,12 @@ namespace OpenTelemetry.Exporter.OpenTelemetryProtocol.Implementation\n public static readonly OpenTelemetryProtocolExporterEventSource Log = new OpenTelemetryProtocolExporterEventSource();\n \n [NonEvent]\n- public void FailedToReachCollector(Exception ex)\n+ public void FailedToReachCollector(Uri collectorUri, Exception ex)\n {\n if (Log.IsEnabled(EventLevel.Error, EventKeywords.All))\n {\n- this.FailedToReachCollector(ex.ToInvariantString());\n+ var rawCollectorUri = collectorUri.ToString();\n+ this.FailedToReachCollector(rawCollectorUri, ex.ToInvariantString());\n }\n }\n ",
"summary": "FailedToReachCollector - Method failed to reach collector."
} | [
{
"content": "Please Give FORMAL Codereview for software developers in one sentence from the given diff hunk. Don’t start with Codereview/review. Just give the answer. Five examples are given before with code and code review and the code to work on is given after.",
"role": "user"
},
{
"content": "C... |
7dc3d2474c83cca7 | {
"callgraph": "[replace,fieldRow,dispose,isShadow,utils,outputConnection,setAttribute,substring,name,Colours,stringify,map,require,WidgetDiv,DUMMY_INPUT,FieldTextInputRemovable,setCheck,provide,setShadow,Blocks,render,dom,setFieldValue,initSvg,appendChild,ScratchBlocks,parse,connection,INPUT_VALUE,Events,trim,type,getField,getFieldValue,getAttribute,createElement]",
"msg": "Is this actually a lint related change?",
"patch": "@@ -185,7 +185,7 @@ Blockly.ScratchBlocks.ProcedureUtils.removeAllInputs_ = function() {\n */\n Blockly.ScratchBlocks.ProcedureUtils.createAllInputs_ = function(connectionMap) {\n // Split the proc into components, by %n, %b, and %s (ignoring escaped).\n- var procComponents = this.procCode_.split(/(?=[^\\\\]\\%[nbs])/);\n+ var procComponents = this.procCode_.split(/(?=[^\\\\]%[nbs])/);\n procComponents = procComponents.map(function(c) {\n return c.trim(); // Strip whitespace.\n });",
"summary": "Creates all inputs of a block and removes all inputs on the block including dummy inputs. function to populate the input."
} | [
{
"content": "Please Give FORMAL Codereview for software developers in one sentence from the given diff hunk. Don’t start with Codereview/review. Just give the answer. Five examples are given before with code and code review and the code to work on is given after.",
"role": "user"
},
{
"content": "C... |
973d5f8f3c42730f | {
"callgraph": "[RefactoringChecker->[_check_superfluous_else_raise->[_check_superfluous_else],process_tokens->[_is_trailing_comma],_check_nested_blocks->[_is_actual_elif],_check_chained_comparison->[_find_lower_upper_bounds],visit_with->[_check_redefined_argument_from_local],_check_consider_merging_isinstance->[_duplicated_isinstance_types],__init__->[__init__],visit_if->[_check_superfluous_else_raise,_check_superfluous_else_return,_check_simplifiable_if,_check_consider_get],_check_swap_variables->[_is_simple_assignment],visit_assign->[_check_swap_variables],_check_superfluous_else->[_is_actual_elif,_if_statement_is_always_returning],visit_excepthandler->[_check_redefined_argument_from_local],leave_module->[_init],visit_augassign->[_check_consider_using_join],visit_for->[_check_redefined_argument_from_local],_is_node_return_ended->[_is_node_return_ended],visit_boolop->[_check_chained_comparison,_check_consider_using_in,_check_consider_merging_isinstance],visit_call->[_check_consider_using_comprehension_constructor],_check_simplifiable_if->[_is_actual_elif,_is_bool_const],_check_superfluous_else_return->[_check_superfluous_else],_check_raising_stopiteration_in_generator_next_call->[_looks_like_infinite_iterator],_check_consider_get->[type_and_name_are_equal]],RecommandationChecker->[visit_for->[_is_constant_zero,_is_builtin]],_is_trailing_comma->[get_curline_index_start],LenChecker->[visit_call->[_is_len_call,_node_is_test_condition],visit_unaryop->[_is_len_call]],register->[RefactoringChecker,RecommandationChecker,NotChecker,LenChecker]]",
"msg": "I don't know if there are strict conventions about this, but I think the name of the warning should be the diagnosis, not the suggested course of action. In this case, that would mean changing the name of the warning to `interactive-exit` or something like that.",
"patch": "@@ -273,6 +273,11 @@ class RefactoringChecker(checkers.BaseTokenChecker):\n \"consider using the list, dict or set constructor. \"\n \"It is faster and simpler.\",\n ),\n+ \"R1722\": (\n+ \"Consider using sys.exit()\",\n+ \"consider-using-sys-exit\",\n+ \"Instead of using exit() or quit(), consider using the sys.exit().\",\n+ ),\n }\n options = (\n (",
"summary": "Uses the dict constructor a list of transient objects and a list of objects that can be used A class that checks a name of functions that never returns."
} | [
{
"content": "Please Give FORMAL Codereview for software developers in one sentence from the given diff hunk. Don’t start with Codereview/review. Just give the answer. Five examples are given before with code and code review and the code to work on is given after.",
"role": "user"
},
{
"content": "C... |
9ef6bf7111827712 | {
"callgraph": "[cleanExpiredHosts->[val,asyncMultiPut,begin,emplace_back,valid,find,size,CHECK_EQ,LOG,end,erase,empty,key,prefix,next],getActiveHosts->[begin,end,size,resize],loadHostMap->[val,valid,LOG,updateHostInfo,key,prefix,next],intervalSeconds_->[CHECK_GT,CHECK_GE,addTimerTask,CHECK,start],updateHostInfo->[wait,asyncMultiPut,emplace_back,find,isLeader,emplace,end,empty,post]]",
"msg": "what to do if some failed? just logging?",
"patch": "@@ -146,7 +146,9 @@ void ActiveHostsMan::cleanExpiredHosts() {\n LOG(INFO) << \"set \" << data.size() << \" expired hosts to offline in meta rocksdb\";\n kvstore_->asyncMultiPut(kDefaultSpaceId, kDefaultPartId, std::move(data),\n [] (kvstore::ResultCode code) {\n- CHECK_EQ(code, kvstore::ResultCode::SUCCEEDED);\n+ if (code != kvstore::ResultCode::SUCCEEDED) {\n+ LOG(WARNING) << \"put failed, ret \" << static_cast<int32_t>(code);\n+ }\n });\n }\n }",
"summary": "Clean expired hosts. expired hosts to offline in meta rocksdb."
} | [
{
"content": "Please Give FORMAL Codereview for software developers in one sentence from the given diff hunk. Don’t start with Codereview/review. Just give the answer. Five examples are given before with code and code review and the code to work on is given after.",
"role": "user"
},
{
"content": "C... |
227dc48253ec11e5 | {
"callgraph": "[Error->[Error],Shutdown->[Wait,add,recoveryHandleCleanup,Close,hasErrors,Errorf,Shutdown,Go,p2pCancel],NewTracer,Start,Sleep,SetAddPeersHandler,Init,Int64,WithConnectionConfigs,Join,NewFixedPricer,SetPaymentThresholdObserver,EthereumAddress,WriterLevel,Background,NewChequeStore,NewStateStore,HexToAddress,NewCashoutService,Debugf,Bytes,SetSwap,SetPushSyncer,Warningf,Addresses,AddProtocol,Register,NewMultiResolver,NewFactory,IsHexAddress,SetNotifyPaymentFunc,Protocol,WithLogger,Metrics,NewRepairHandler,MustRegisterMetrics,After,Ready,Dial,NATManager,Serve,NewService,Debug,New,SetNotifier,DiscoverFactoryAddress,NewAccounting,NewChequeSigner,NewAddressbook,NewTags,Info,Warning,Infof,WithCancel,NewMultiaddr,NewCallback,Addr,Error,ChainID,Errorf,Listen]",
"msg": "It provides a type called Node which is a fully functional bee client. This package is where the dependencies are injected. It is not just a glue-code, it is concept of node.",
"patch": "@@ -2,6 +2,8 @@\n // Use of this source code is governed by a BSD-style\n // license that can be found in the LICENSE file.\n \n+// Package node provides the glue-code needed in order\n+// to start a Bee node.\n package node\n \n import (",
"summary": "License for the BSD - style license of the source code. Package hierarchy for all packages."
} | [
{
"content": "Please Give FORMAL Codereview for software developers in one sentence from the given diff hunk. Don’t start with Codereview/review. Just give the answer. Five examples are given before with code and code review and the code to work on is given after.",
"role": "user"
},
{
"content": "C... |
24d018dc07d55e7c | {
"callgraph": "[EthGetCode->[getName->[getMethodName],blockParameterOrBlockHash->[getRequiredParameter],resultByBlockHash->[toHexString,isPresent,getPrivateWorldStateAtBlock,getRequiredParameter,orElse,get,getBlockHeaderByHash,getGoQuorumPrivacyParameters]]]",
"msg": "Same here, can we presume if `privacyParameters` is set we need goQuorum handling? Or is there a goQuorum sub option in `privacyParametes`?",
"patch": "@@ -64,7 +64,8 @@ public class EthGetCode extends AbstractBlockParameterOrBlockHashMethod {\n @Override\n protected String resultByBlockHash(final JsonRpcRequestContext request, final Hash blockHash) {\n final Address address = request.getRequiredParameter(0, Address.class);\n- if (GoQuorumOptions.goQuorumCompatibilityMode && privacyParameters.isPresent()) {\n+ final boolean isGoQuorumCompatibilityMode = GoQuorumOptions.goQuorumCompatibilityMode;\n+ if (isGoQuorumCompatibilityMode && privacyParameters.isPresent()) {\n // get from private state if we can\n final Optional<BlockHeader> blockHeader =\n blockchainQueries.get().getBlockHeaderByHash(blockHash);",
"summary": "Get the code associated with a block."
} | [
{
"content": "Please Give FORMAL Codereview for software developers in one sentence from the given diff hunk. Don’t start with Codereview/review. Just give the answer. Five examples are given before with code and code review and the code to work on is given after.",
"role": "user"
},
{
"content": "C... |
bdc84bf1acc175a6 | {
"callgraph": "[MethodNameDeclaration->[getParameterDisplaySignature->[getParameterCount,isVarargs],isVarargs->[isVarargs],toString->[getParameterCount],equals->[getParameterCount,isVarargs,equals],hashCode->[getParameterCount,hashCode],getParameterCount->[getParameterCount]]]",
"msg": "In case the method is `void`, there won't be any children and `getChild(0)` throws. We'll need to check with `isVoid()` for that case. I'll update this when I merge.",
"patch": "@@ -32,6 +32,11 @@ public class MethodNameDeclaration extends AbstractNameDeclaration {\n return p.isVarargs();\n }\n \n+ public boolean isPrimitiveReturnType() {\n+ return getMethodNameDeclaratorNode().getParent().getResultType().getChild(0)\n+ .getChild(0) instanceof ASTPrimitiveType;\n+ }\n+\n public ASTMethodDeclarator getMethodNameDeclaratorNode() {\n return (ASTMethodDeclarator) node;\n }",
"summary": "This method returns true if the node is a varargs or a formal parameter."
} | [
{
"content": "Please Give FORMAL Codereview for software developers in one sentence from the given diff hunk. Don’t start with Codereview/review. Just give the answer. Five examples are given before with code and code review and the code to work on is given after.",
"role": "user"
},
{
"content": "C... |
428337f896113abb | {
"callgraph": "[RefactoringChecker->[leave_module->[_init],_check_consider_merging_isinstance->[_duplicated_isinstance_types],__init__->[__init__],visit_augassign->[_check_consider_using_join],visit_if->[_check_superfluous_else_return,_check_simplifiable_if,_check_consider_get],_check_swap_variables->[_is_simple_assignment],visit_for->[_check_redefined_argument_from_local],_check_nested_blocks->[_is_actual_elif],_is_node_return_ended->[_is_node_return_ended],_check_consider_get->[type_and_name_are_equal],_check_superfluous_else_return->[_is_actual_elif,_if_statement_is_always_returning],visit_assign->[_check_swap_variables],_check_raising_stopiteration_in_generator_next_call->[_looks_like_infinite_iterator],visit_boolop->[_check_consider_using_in,_check_consider_merging_isinstance],visit_with->[_check_redefined_argument_from_local],_check_simplifiable_if->[_is_actual_elif,_is_bool_const],visit_excepthandler->[_check_redefined_argument_from_local]],_if_statement_is_always_returning->[_has_return_node->[_if_statement_is_always_returning],_has_return_node,_all_elements_are_true],RecommandationChecker->[visit_for->[_is_builtin]],is_trailing_comma->[get_curline_index_start],LenChecker->[visit_compare->[_is_len_call,_is_constant_zero,_has_constant_value,_node_is_test_condition],visit_call->[_is_len_call,_node_is_test_condition],visit_unaryop->[_is_len_call]],register->[RefactoringChecker,RecommandationChecker,NotChecker,LenChecker]]",
"msg": "I'd rephrase it as `Simplify chained comparison between the operands`.",
"patch": "@@ -155,6 +155,10 @@ class RefactoringChecker(checkers.BaseTokenChecker):\n 'if a key is present or a default if not, is simpler and considered '\n 'more idiomatic, although sometimes a bit slower'\n ),\n+ 'R1716': ('simplify chained comparison',\n+ 'chained-comparison',\n+ 'Chained comparisons like \"a < b and b < c\" can be simplified as \"a < b < c\"',\n+ ),\n }\n options = (('max-nested-blocks',\n {'default': 5, 'type': 'int', 'metavar': '<int>',",
"summary": "Requirements for the n - nested - block function. Constructor for a TokenChecker class."
} | [
{
"content": "Please Give FORMAL Codereview for software developers in one sentence from the given diff hunk. Don’t start with Codereview/review. Just give the answer. Five examples are given before with code and code review and the code to work on is given after.",
"role": "user"
},
{
"content": "C... |
03d2d664448693b3 | {
"callgraph": "[No CFG could be retrieved]",
"msg": "can you replace the tabs with 2 spaces please to match the rest of the project?",
"patch": "@@ -14,3 +14,17 @@ function roots_get_search_form($form) {\n return $form;\n }\n add_filter('get_search_form', 'roots_get_search_form');\n+\n+/**\n+ * Add page slug to body_class() classes if it doesn't exist\n+ */\n+function roots_body_class($classes) {\n+ // Add post/page slug\n+ if (is_single() || is_page() && !is_front_page()) {\n+ \tif (!in_array(basename(get_permalink()), $classes)) {\n+ \t\t$classes[] = basename(get_permalink());\n+ \t}\n+ }\n+ return $classes;\n+}\n+add_filter('body_class', 'roots_body_class');",
"summary": "Get search form from roots."
} | [
{
"content": "Please Give FORMAL Codereview for software developers in one sentence from the given diff hunk. Don’t start with Codereview/review. Just give the answer. Five examples are given before with code and code review and the code to work on is given after.",
"role": "user"
},
{
"content": "C... |
567e3ca0398070bd | {
"callgraph": "[No CFG could be retrieved]",
"msg": "Please explain why a user would enable this (space savings), and the requirements for this option to be safe.",
"patch": "@@ -67,6 +67,10 @@ type Config struct {\n \t// If not set, it uses all versions available.\n \t// Warning: This API should not be considered stable and will change soon.\n \tVersions []protocol.VersionNumber\n+\t// Ask the server to truncate the connection ID sent in the Public Header.\n+\t// This saves 8 bytes in the Public Header in every packet. However, if the IP address of the server changes, the connection cannot be migrated.\n+\t// Currently only valid for the client.\n+\tRequestConnectionIDTruncation bool\n }\n \n // A Listener for incoming QUIC connections",
"summary": " type is the constructor for a single config field."
} | [
{
"content": "Please Give FORMAL Codereview for software developers in one sentence from the given diff hunk. Don’t start with Codereview/review. Just give the answer. Five examples are given before with code and code review and the code to work on is given after.",
"role": "user"
},
{
"content": "C... |
816a4a84590c61b2 | {
"callgraph": "[testCanClickOnALinkThatOverflowsAndFollowIt->[title_is,WebDriverWait,find_element],loadPage->[load],testClickingALinkMadeUpOfNumbersIsHandledCorrectly->[title_is,WebDriverWait,find_element],fixture]",
"msg": "I believe it's misleading name for the condition. I prefer \"element_to_be_disable\" We can have a condition, when element is enabled but we can't click it, because another element overlays above it. So, If we use \"unclickable\" we might mislead people, who use that condition to verify if element can be clicked",
"patch": "@@ -35,3 +35,6 @@ def testCanClickOnALinkThatOverflowsAndFollowIt(driver):\n def testClickingALinkMadeUpOfNumbersIsHandledCorrectly(driver):\n driver.find_element(By.LINK_TEXT, \"333333\").click()\n WebDriverWait(driver, 3).until(EC.title_is(\"XHTML Test Page\"))\n+\n+def testCannotClickDisabledButton(driver):\n+ WebDriverWait(driver, 3).until(EC.element_to_be_unclickable(By.ID, \"disabled-button\"))",
"summary": "Clicks a link with a text that is a link that is made up of numbers and."
} | [
{
"content": "Please Give FORMAL Codereview for software developers in one sentence from the given diff hunk. Don’t start with Codereview/review. Just give the answer. Five examples are given before with code and code review and the code to work on is given after.",
"role": "user"
},
{
"content": "C... |
4757eb9940585aa7 | {
"callgraph": "[PathTemplateCheckView->[newBuilder->[Builder]]]",
"msg": "Should this be called something that indicates its function, rather than its content? validationMessagePrefix, or similar?",
"patch": "@@ -23,6 +23,8 @@ public abstract class PathTemplateCheckView {\n \n public abstract String paramName();\n \n+ public abstract String methodName();\n+\n public static Builder newBuilder() {\n return new AutoValue_PathTemplateCheckView.Builder();\n }",
"summary": "Creates a builder for a path template check view."
} | [
{
"content": "Please Give FORMAL Codereview for software developers in one sentence from the given diff hunk. Don’t start with Codereview/review. Just give the answer. Five examples are given before with code and code review and the code to work on is given after.",
"role": "user"
},
{
"content": "C... |
de9b46b4341d6597 | {
"callgraph": "[remove_pe_defaults_on->[remove_platform_pe_defaults],add_pe_defaults_on->[add_platform_pe_defaults]]",
"msg": "This winds up flipping the desired values. Looks like I gave you a bum steer @kevpl",
"patch": "@@ -32,7 +32,7 @@ module Beaker\n 'puppetbin' => '/opt/puppet/bin/puppet',\n 'puppetbindir' => '/opt/puppet/bin',\n 'puppetsbindir' => '/opt/puppet/sbin',\n- 'privatebindir' => '/opt/puppetlabs/puppet/bin',\n+ 'privatebindir' => '/opt/puppet/bin',\n 'puppetvardir' => '/var/opt/lib/pe-puppet',\n 'hieradatadir' => '/var/lib/hiera',\n 'hieraconf' => '/etc/puppetlabs/puppet/hiera.yaml',",
"summary": "The puppet - labs directory is the root of the system. windows windows puppet service."
} | [
{
"content": "Please Give FORMAL Codereview for software developers in one sentence from the given diff hunk. Don’t start with Codereview/review. Just give the answer. Five examples are given before with code and code review and the code to work on is given after.",
"role": "user"
},
{
"content": "C... |
c2e04cd8e85c8f1f | {
"callgraph": "[Const->[REGISTRY_API->[getRegistryApiVersion,format,equals,getDomainName]]]",
"msg": "are you sure you can read version by this artifactid?",
"patch": "@@ -148,6 +148,10 @@ public final class Const {\n public static final String PATH_CHECKSESSION = \"checksession\";\n \n public static final String URL_PREFIX = \"urlPrefix\";\n- \n+\n public static final String INSTANCE_PUBKEY_PRO = \"publickey\";\n+\n+ public static final String GROUPID = \"io.servicecomb\";\n+\n+ public static final String ARTIFACTID = \"java-chassis\";\n }",
"summary": "Get the path checksession and urlPrefix."
} | [
{
"content": "Please Give FORMAL Codereview for software developers in one sentence from the given diff hunk. Don’t start with Codereview/review. Just give the answer. Five examples are given before with code and code review and the code to work on is given after.",
"role": "user"
},
{
"content": "C... |
d6877a096949d92e | {
"callgraph": "[Start->[Start,Lock,Wait,Debug,Info,Submit,Combine,Unlock,SetRouter],Register->[Type,ApplyUnaryInbound,Unary,Info,NewUnaryHandlerSpec,ApplyOnewayInbound,Oneway,Sprintf,Register,NewOnewayHandlerSpec,Object],Stop->[Debug,Wait,Info,Submit,Combine],ClientConfig->[MultiOutbound],With,UnaryChain,ApplyUnaryOutbound,NewNopContextExtractor,Named,Transports,ValidateServiceName,Error,Sprintf,NewUnary,NewNop,ApplyRouteTable,ApplyOnewayOutbound,String,Namespace]",
"msg": "To minimize the possibility of regret, perhaps we name this `ZapLogger`.",
"patch": "@@ -72,9 +72,7 @@ type Config struct {\n \n \t// Logger provides a logger for the dispatcher. The default logger is a\n \t// no-op.\n-\t// TODO(shah): Export this when we're ready to deploy a branch in\n-\t// demo-yarpc-go.\n-\tlogger *zap.Logger\n+\tLogger *zap.Logger\n }\n \n // Inbounds contains a list of inbound transports. Each inbound transport",
"summary": "Examples of how to configure a new Dispatcher. Easy way to re - enable the EWYY mode."
} | [
{
"content": "Please Give FORMAL Codereview for software developers in one sentence from the given diff hunk. Don’t start with Codereview/review. Just give the answer. Five examples are given before with code and code review and the code to work on is given after.",
"role": "user"
},
{
"content": "C... |
cd49283116e9b05a | {
"callgraph": "[PlansController->[rollup->[new],destroy->[destroy],create->[new],new->[new],visibility->[visibility],status->[status],get_most_recent->[new]]]",
"msg": "Since the IdentifierScheme's don't change without us making additional code changes, perhaps this should be added as a constant as we previously did with Perms?",
"patch": "@@ -38,9 +38,13 @@ class PlansController < ApplicationController\n def create\n @plan = Plan.new\n authorize @plan\n-\n+ \n @plan.principal_investigator = current_user.surname.blank? ? nil : \"#{current_user.firstname} #{current_user.surname}\"\n- @plan.data_contact = current_user.email\n+ @plan.principal_investigator_email = current_user.email\n+ \n+ orcid = current_user.identifier_for(IdentifierScheme.find_by(name: 'orcid'))\n+ @plan.principal_investigator_identifier = orcid.identifier unless orcid.nil?\n+ \n @plan.funder_name = plan_params[:funder_name]\n \n @plan.visibility = (plan_params['visibility'].blank? ? Rails.application.config.default_plan_visibility :",
"summary": "Creates a new n - word word grammar for the given user. This method is called when the user has used a custom version of the template."
} | [
{
"content": "Please Give FORMAL Codereview for software developers in one sentence from the given diff hunk. Don’t start with Codereview/review. Just give the answer. Five examples are given before with code and code review and the code to work on is given after.",
"role": "user"
},
{
"content": "C... |
f60d879bbc59089b | {
"callgraph": "[CommandDispatcher->[move_to_next_line->[_current_widget],view_source->[show_source_cb->[_current_url],_current_widget],search_prev->[_current_widget,search],back->[_back_forward],move_to_prev_line->[_current_widget],_parse_url_input->[_parse_url],paste->[_open],scroll_perc->[_current_widget],move_to_next_word->[_current_widget],quickmark_del->[_current_url],open_editor->[_current_widget],drop_selection->[_current_widget],fake_key->[_current_widget],download->[_current_widget,_current_url],move_to_end_of_line->[_current_widget],zoom->[_current_widget],_cntwidget->[_count],debug_clear_ssl_errors->[_current_widget],move_to_end_of_document->[_current_widget],navigate->[_current_widget,_open,_current_url],zoom_in->[_current_widget],scroll_px->[_current_widget],move_to_end_of_next_block->[_current_widget],jump_mark->[jump_mark],stop->[_cntwidget,stop],search_next->[_current_widget,search],click_element->[_current_widget],jseval->[_current_widget],bookmark_del->[_current_url],move_to_next_char->[_current_widget],_yank_url->[_current_url],insert_text->[_insert_text_cb->[insert_text],_current_widget],move_to_end_of_prev_block->[_current_widget],tab_close->[_cntwidget,_get_selection_override],move_to_end_of_word->[_current_widget],bookmark_add->[_current_url,_current_title],show_help->[_open],move_to_prev_word->[_current_widget],move_to_start_of_next_block->[_current_widget],edit_url->[_current_url],home->[openurl],move_to_start_of_prev_block->[_current_widget],tab_move->[_current_widget,_current_index,_set_current_index,_count],openurl->[openurl,_cntwidget,_open],debug_webaction->[_current_widget],_tab_focus_last->[_set_current_index],toggle_inspector->[_current_widget],tab_next->[_current_index,_set_current_index,_count],move_to_start_of_document->[_current_widget],quickmark_load->[_open],zoom_out->[_current_widget],scroll_page->[_current_widget,navigate],move_to_start_of_line->[_current_widget],tab_detach->[_current_url,_open,_current_widget,_count],tab_focus->[_set_current_index,_count,tab_next,_tab_focus_last],bookmark_load->[_open],follow_selected->[_current_widget],quickmark_save->[_current_url],_open_if_changed->[openurl],reloadpage->[_cntwidget],set_mark->[set_mark],_back_forward->[_current_widget,tab_clone],_run_userscript->[_current_index],_download_mhtml->[_current_widget,_current_title],scroll->[_current_widget],tab_clone->[_current_widget,_current_index,_new_tabbed_browser],_open->[_new_tabbed_browser,_current_widget],printpage->[_cntwidget],forward->[_back_forward],debug_dump_page->[_current_widget],undo->[undo],messages->[_open],search->[_current_widget,search],yank->[_current_url,_current_index,_yank_url,_current_widget],move_to_prev_char->[_current_widget],tab_prev->[_current_index,_set_current_index,_count],toggle_selection->[_current_widget]]]",
"msg": "You can most likely remove that (and the try/finally) too, as we shouldn't have any flickering from removing/inserting tabs anymore now.",
"patch": "@@ -1028,17 +1028,13 @@ class CommandDispatcher:\n raise cmdexc.CommandError(\"Can't move tab to position {}!\".format(\n new_idx + 1))\n \n- tab = self._current_widget()\n cur_idx = self._current_index()\n- icon = self._tabbed_browser.tabIcon(cur_idx)\n- label = self._tabbed_browser.page_title(cur_idx)\n cmdutils.check_overflow(cur_idx, 'int')\n cmdutils.check_overflow(new_idx, 'int')\n self._tabbed_browser.setUpdatesEnabled(False)\n try:\n color = self._tabbed_browser.tab_indicator_color(cur_idx)\n- self._tabbed_browser.removeTab(cur_idx)\n- self._tabbed_browser.insertTab(new_idx, tab, icon, label)\n+ self._tabbed_browser.tabBar().moveTab(cur_idx, new_idx)\n self._set_current_index(new_idx)\n self._tabbed_browser.set_tab_indicator_color(new_idx, color)\n finally:",
"summary": "Move the current tab according to the argument and [ count. Set current tab indicator color and update tabbed browser."
} | [
{
"content": "Please Give FORMAL Codereview for software developers in one sentence from the given diff hunk. Don’t start with Codereview/review. Just give the answer. Five examples are given before with code and code review and the code to work on is given after.",
"role": "user"
},
{
"content": "C... |
5adca273356e738b | {
"callgraph": "[StringConfigurationSource->[GetDouble->[GetString],GetInt32->[GetString],GetBool->[GetString],GetDictionary->[ParseCustomKeyValues,GetString]]]",
"msg": "I looks like we can make `allowOptionalMappings` non-optional since we have another overload without it. (I thought this generated a compiler warning, but maybe it's just R#)",
"patch": "@@ -17,6 +17,18 @@ namespace Datadog.Trace.Configuration\n /// <param name=\"data\">A string containing key-value pairs which are comma-separated, and for which the key and value are colon-separated.</param>\n /// <returns><see cref=\"IDictionary{TKey, TValue}\"/> of key value pairs.</returns>\n public static IDictionary<string, string> ParseCustomKeyValues(string data)\n+ {\n+ return ParseCustomKeyValues(data, allowOptionalMappings: false);\n+ }\n+\n+ /// <summary>\n+ /// Returns a <see cref=\"IDictionary{TKey, TValue}\"/> from parsing\n+ /// <paramref name=\"data\"/>.\n+ /// </summary>\n+ /// <param name=\"data\">A string containing key-value pairs which are comma-separated, and for which the key and value are colon-separated.</param>\n+ /// <param name=\"allowOptionalMappings\">Determines whether to create dictionary entries when the input has no value mapping</param>\n+ /// <returns><see cref=\"IDictionary{TKey, TValue}\"/> of key value pairs.</returns>\n+ public static IDictionary<string, string> ParseCustomKeyValues(string data, bool allowOptionalMappings = false)\n {\n var dictionary = new ConcurrentDictionary<string, string>();\n ",
"summary": "ParseCustomKeyValues - Parses a string into a dictionary of key - value pairs."
} | [
{
"content": "Please Give FORMAL Codereview for software developers in one sentence from the given diff hunk. Don’t start with Codereview/review. Just give the answer. Five examples are given before with code and code review and the code to work on is given after.",
"role": "user"
},
{
"content": "C... |
7a9e0d491239446f | {
"callgraph": "[ConfigUtil->[installDynamicConfig->[createDynamicConfig],createDynamicConfig->[duplicateServiceCombConfigToCse,createConfigFromConfigCenter,createLocalConfig],getMicroserviceConfigLoader->[getProperty],convertEnvVariable->[getProperty],duplicateServiceCombConfigToCse->[duplicateServiceCombConfigToCse,getProperty],getProperty->[getProperty],createLocalConfig->[setMicroserviceConfigLoader,createLocalConfig]]]",
"msg": "I think if we can provide a more convenient method to add configs . e.g. public static void addConfig(String k, Object v)",
"patch": "@@ -52,9 +52,15 @@ public final class ConfigUtil {\n \n private static final String MICROSERVICE_CONFIG_LOADER_KEY = \"cse-microservice-config-loader\";\n \n+ private static ConfigModel model = new ConfigModel();\n+\n private ConfigUtil() {\n }\n \n+ public static void setConfigs(Map<String, Object> config) {\n+ model.setConfig(config);\n+ }\n+\n public static Object getProperty(String key) {\n Object config = DynamicPropertyFactory.getBackingConfigurationSource();\n return getProperty(config, key);",
"summary": "Get a property from the configuration source."
} | [
{
"content": "Please Give FORMAL Codereview for software developers in one sentence from the given diff hunk. Don’t start with Codereview/review. Just give the answer. Five examples are given before with code and code review and the code to work on is given after.",
"role": "user"
},
{
"content": "C... |
9833722d3af985a8 | {
"callgraph": "[createInfoStore,registerStore,addQueryArgs,dispatch,it,describe,createTestRegistry,select,unsubscribeFromAll,beforeEach,expect,afterEach]",
"msg": "Minor detail, but let's use the interpolated template string syntax instead.",
"patch": "@@ -30,6 +30,7 @@ import { STORE_NAME as CORE_SITE } from '../datastore/site/constants';\n import { STORE_NAME as CORE_USER } from '../datastore/user/constants';\n \n const MODULE_SLUG = 'test-slug';\n+const TEST_STORE_NAME = 'test/' + MODULE_SLUG;\n \n describe( 'createInfoStore store', () => {\n \tlet registry;",
"summary": "Info datastore functions tests. requires that the main module is created."
} | [
{
"content": "Please Give FORMAL Codereview for software developers in one sentence from the given diff hunk. Don’t start with Codereview/review. Just give the answer. Five examples are given before with code and code review and the code to work on is given after.",
"role": "user"
},
{
"content": "C... |
68f36e4be46f4cce | {
"callgraph": "[AllDataFilesTable->[AllDataFilesTableScan->[newRefinedScan->[AllDataFilesTableScan],planFiles->[schema]]]]",
"msg": "I think these can all be .name() to get the value we are looking for",
"patch": "@@ -84,6 +84,11 @@ public class AllDataFilesTable extends BaseMetadataTable {\n this.fileSchema = fileSchema;\n }\n \n+ @Override\n+ protected String tableType() {\n+ return String.valueOf(MetadataTableType.ALL_DATA_FILES);\n+ }\n+\n @Override\n protected TableScan newRefinedScan(TableOperations ops, Table table, Schema schema, TableScanContext context) {\n return new AllDataFilesTableScan(ops, table, schema, fileSchema, context);",
"summary": "Create a new scan for the given table and schema."
} | [
{
"content": "Please Give FORMAL Codereview for software developers in one sentence from the given diff hunk. Don’t start with Codereview/review. Just give the answer. Five examples are given before with code and code review and the code to work on is given after.",
"role": "user"
},
{
"content": "C... |
c733dad0abcbf8f4 | {
"callgraph": "[applyProgramsToDirtyDataInterfaces->[setAcceptLocal]]",
"msg": "nit: a switch perhaps?",
"patch": "@@ -614,6 +614,8 @@ func (m *bpfEndpointManager) attachDataIfaceProgram(ifaceName string, polDirecti\n \tepType := tc.EpTypeHost\n \tif ifaceName == \"tunl0\" {\n \t\tepType = tc.EpTypeTunnel\n+\t} else if ifaceName == \"wireguard.cali\" {\n+\t\tepType = tc.EpTypeWireguard\n \t}\n \tap := m.calculateTCAttachPoint(epType, polDirection, ifaceName)\n \tap.HostIP = m.hostIP",
"summary": "attachDataIfaceProgram attaches the data interface program to the endpoint."
} | [
{
"content": "Please Give FORMAL Codereview for software developers in one sentence from the given diff hunk. Don’t start with Codereview/review. Just give the answer. Five examples are given before with code and code review and the code to work on is given after.",
"role": "user"
},
{
"content": "C... |
edabcef092cf4db9 | {
"callgraph": "[No CFG could be retrieved]",
"msg": "can we remove this since `getDocValues` already returns an iterator? (we might need to do `T extends DocIdSetIterator` above)",
"patch": "@@ -21,12 +21,10 @@ import java.io.IOException;\n \n import org.apache.lucene.codecs.DocValuesConsumer;\n import org.apache.lucene.search.DocIdSetIterator;\n-import org.apache.lucene.search.SortField;\n \n-abstract class DocValuesWriter {\n- abstract void finish(int numDoc);\n+abstract class DocValuesWriter<T> {\n abstract void flush(SegmentWriteState state, Sorter.DocMap sortMap, DocValuesConsumer consumer) throws IOException;\n- abstract Sorter.DocComparator getDocComparator(int numDoc, SortField sortField) throws IOException;\n+ abstract T getDocValues();\n abstract DocIdSetIterator getDocIdSet();\n \n }",
"summary": "abstract Flush the writer."
} | [
{
"content": "Please Give FORMAL Codereview for software developers in one sentence from the given diff hunk. Don’t start with Codereview/review. Just give the answer. Five examples are given before with code and code review and the code to work on is given after.",
"role": "user"
},
{
"content": "C... |
6cbe5b01a8dd4552 | {
"callgraph": "[SendWindowSize->[sendWindowSize],EnsureMinimumWindowSize->[Lock,MinByteCount,startNewAutoTuningEpoch,Unlock],IsNewlyBlocked->[sendWindowSize],GetWindowUpdate->[Lock,Debugf,getWindowUpdate,Unlock],IncrementHighestReceived->[Lock,checkFlowControlViolation,Unlock,Error,Sprintf]]",
"msg": "How often do we expect this to trigger? Should we maybe put it behind an if logger.Debug()?",
"patch": "@@ -78,6 +78,7 @@ func (c *connectionFlowController) GetWindowUpdate() protocol.ByteCount {\n func (c *connectionFlowController) EnsureMinimumWindowSize(inc protocol.ByteCount) {\n \tc.mutex.Lock()\n \tif inc > c.receiveWindowSize {\n+\t\tc.logger.Debugf(\"Increasing receive flow control window for the connection to %d kB, in response to stream flow control window increase\", c.receiveWindowSize/(1<<10))\n \t\tc.receiveWindowSize = utils.MinByteCount(inc, c.maxReceiveWindowSize)\n \t\tc.startNewAutoTuningEpoch()\n \t}",
"summary": "EnsureMinimumWindowSize ensures that the receive window size is at least as large as the maximum."
} | [
{
"content": "Please Give FORMAL Codereview for software developers in one sentence from the given diff hunk. Don’t start with Codereview/review. Just give the answer. Five examples are given before with code and code review and the code to work on is given after.",
"role": "user"
},
{
"content": "C... |
9665b5089c93d445 | {
"callgraph": "[HttpAccess->[init->[HttpAccess],getOkHttpClient->[build],getOkHttpClientBuilder->[UserAgentInterceptor,build,addNetworkInterceptor],hasNetwork->[getActiveNetworkInfo,isConnected],UserAgentInterceptor->[intercept->[request,proceed,build]],getSystemService]]",
"msg": "This now throws when running tests (maybe the move to java 11??). Do we want to keep it?",
"patch": "@@ -69,7 +69,6 @@ public class HttpAccess {\n * Initializes HttpAccess. Should be called from the application.\n */\n public static void init(Context app) {\n- assert DEFAULT == null : \"HttpAccess.init should be called once per process\";\n DEFAULT = new HttpAccess(app, null /* user agent will be calculated at request time */);\n }\n ",
"summary": "Initializes the HTTPAccess class."
} | [
{
"content": "Please Give FORMAL Codereview for software developers in one sentence from the given diff hunk. Don’t start with Codereview/review. Just give the answer. Five examples are given before with code and code review and the code to work on is given after.",
"role": "user"
},
{
"content": "C... |
9073a4fd6c2c8180 | {
"callgraph": "[BatchActionTransport->[reject->[commit],ack->[getMessage,commit,getResourceId,getResult,getId,markEntry,last],get->[commit,beginTransaction,fetchAssociative]]]",
"msg": "As far as I can see you're not rollbacking transaction anywhere. This could potentially cause further issues(and very hard to debug ones) with not synchronized transactions between message handling. Is the transaction required in this place anyway? You seem only to be fetching data here. ack method is performing some updates so it makes sense",
"patch": "@@ -16,6 +16,11 @@ use Ergonode\\BatchAction\\Domain\\Entity\\BatchActionId;\n use Ergonode\\SharedKernel\\Domain\\AggregateId;\n use Symfony\\Component\\Messenger\\Stamp\\HandledStamp;\n use Ergonode\\BatchAction\\Domain\\Repository\\BatchActionRepositoryInterface;\n+use Ergonode\\Core\\Application\\Security\\User\\CachedUser;\n+use Ergonode\\Account\\Domain\\Repository\\UserRepositoryInterface;\n+use Ergonode\\SharedKernel\\Domain\\Aggregate\\UserId;\n+use Ergonode\\BatchAction\\Domain\\Event\\BatchActionEndedEvent;\n+use Ergonode\\Core\\Application\\Messenger\\Stamp\\UserStamp;\n \n class BatchActionTransport implements TransportInterface\n {",
"summary": "Creates a transport that processes a single batch action. Mark the last handled stamp for the message."
} | [
{
"content": "Please Give FORMAL Codereview for software developers in one sentence from the given diff hunk. Don’t start with Codereview/review. Just give the answer. Five examples are given before with code and code review and the code to work on is given after.",
"role": "user"
},
{
"content": "C... |
fdb5f91c27e6b65b | {
"callgraph": "[WebEngineTab->[icon->[icon],title->[title],_error_page_workaround->[_show_error_page,url,search],__init__->[WebEngineElements,WebEngineScroller,WebEngineCaret,WebEngineAction,WebEngineSearch,WebEngineHistory,WebEngineZoom,WebEnginePrinting],stop->[stop],_on_history_trigger->[url,title],url->[url],_on_load_started->[clear],_init_stylesheet->[_remove_early_js,_inject_early_js],_on_authentication_required->[_show_error_page],_on_load_finished->[dump_async],_init_js->[_inject_early_js],_show_error_page->[set_html],shutdown->[exit_fullscreen,shutdown],_on_proxy_authentication_required->[_show_error_page]],WebEngineScroller->[page_down->[_repeated_key_press],at_top->[pos_px],up->[_repeated_key_press],page_up->[_repeated_key_press],right->[_repeated_key_press],left->[_repeated_key_press],down->[_repeated_key_press]],WebEngineCaret->[follow_selected->[clear,_follow_selected_cb],_on_mode_entered->[clear]],WebEngineSearch->[prev_result->[_find],next_result->[_find],search->[_find]],WebEngineHistory->[serialize->[serialize],deserialize->[deserialize],load_items->[_on_load_finished->[to_point],serialize,pos_px]]]",
"msg": "We should probably use ctrl-enter if `tab` is given, just like in `follow_selected`?",
"patch": "@@ -335,6 +335,11 @@ class WebEngineCaret(browsertab.AbstractCaret):\n \"\"\"\n if js_elem is None:\n return\n+ if js_elem == \"focused\":\n+ # we had a focused element, not a selected one. Just send <enter>\n+ self._tab.key_press(Qt.Key_Enter)\n+ return\n+\n assert isinstance(js_elem, dict), js_elem\n elem = webengineelem.WebEngineElement(js_elem, tab=self._tab)\n if tab:",
"summary": "Callback for javascript which clicks the selected element."
} | [
{
"content": "Please Give FORMAL Codereview for software developers in one sentence from the given diff hunk. Don’t start with Codereview/review. Just give the answer. Five examples are given before with code and code review and the code to work on is given after.",
"role": "user"
},
{
"content": "C... |
44278f389b1cbc57 | {
"callgraph": "[setupDifferentNamedPorts->[JoinHostPort,Sleep,createNetworkPolicy,Sprint,deleteNetworkpolicy,createServerPod,String,runNetcatCommandFromTestPod,Fatalf],StatsV1alpha1,Sleep,JoinHostPort,Sprint,Sprintf,CoreV1,podWaitForIPs,Fatalf,GetScale,TODO,Create,deleteNetworkpolicy,Deployments,runCommandFromPod,Get,setupDifferentNamedPorts,Add,Skipf,Poll,String,createNetworkPolicy,Unmarshal,Pods,getAntreaPodOnNode,AppsV1,Wait,Done,deleteService,Fatal,NetworkPolicyStats,Logf,createService,UpdateScale,ParseCIDR,Errorf,runNetcatCommandFromTestPod,deletePod]",
"msg": "I think it will revert the change @antoninbas did on purpose 05eee251c9c53400277def576f92d614ca234898",
"patch": "@@ -35,12 +35,13 @@ import (\n \t\"antrea.io/antrea/pkg/features\"\n )\n \n-func skipIfNetworkPolicyStatsDisabled(tb testing.TB, data *TestData) {\n-\tskipIfFeatureDisabled(tb, data, features.NetworkPolicyStats, true, true)\n+func skipIfNetworkPolicyStatsDisabled(tb testing.TB) {\n+\tskipIfFeatureDisabled(tb, features.NetworkPolicyStats, true, true)\n }\n \n-func TestNetworkPolicyStats(t *testing.T) {\n-\tskipIfNotIPv4Cluster(t)\n+// TestNetworkPolicy is the top-level test which contains all subtests for\n+// NetworkPolicy related test cases so they can share setup, teardown.\n+func TestNetworkPolicy(t *testing.T) {\n \tskipIfHasWindowsNodes(t)\n \n \tdata, err := setupTest(t)",
"summary": "END of function testNetworkNetworkStats test - client -."
} | [
{
"content": "Please Give FORMAL Codereview for software developers in one sentence from the given diff hunk. Don’t start with Codereview/review. Just give the answer. Five examples are given before with code and code review and the code to work on is given after.",
"role": "user"
},
{
"content": "C... |
cc0167f27e24098c | {
"callgraph": "[IsLordHowe,SetState,PathOfTempFile,CleanupPath,GetState,Bytes,NewMockStateManager,DoAndReturn,GetCodeHash,Get,BytesToHash160,IsAleutian,Any,Hash256b,NewInt,NewCachedBatch,String,EXPECT,IsKamchatka,IsGreenland,Snapshot,NotEqual,Hash160b,CommitContracts,Run,State,clear,Put,Commit,Nil,SelfState,BytesToHash256,GetCode,Cause,CreateStateConfig,NewController,NoError,New,Serialize,LoadOrCreateAccount,Equal,PutState,AnyTimes,SetCode,GetCommittedState,AddBalance,Address,Deserialize]",
"msg": "`stateDB := NewStateDBAdapter(sm, 0, hash.ZeroHash256, NotFixTopicCopyBugOption())`",
"patch": "@@ -66,9 +66,9 @@ func TestCreateContract(t *testing.T) {\n \taddr := identityset.Address(28)\n \t_, err = accountutil.LoadOrCreateAccount(sm, addr.String())\n \trequire.NoError(err)\n-\tstateDB := NewStateDBAdapter(sm, 0, !cfg.Genesis.IsAleutian(0),\n-\t\tcfg.Genesis.IsGreenland(0), cfg.Genesis.IsKamchatka(0),\n-\t\tcfg.Genesis.IsLordHowe(0), hash.ZeroHash256)\n+\topt := []StateDBAdapterOption{NotFixTopicCopyBugOption()}\n+\tstateDB := NewStateDBAdapter(sm, 0, hash.ZeroHash256, opt...)\n+\n \tcontract := addr.Bytes()\n \tvar evmContract common.Address\n \tcopy(evmContract[:], contract[:])",
"summary": "Get a batch of state records for a given account. TestLoadStoreCommit tests if a code hash is not already present in the stateDB."
} | [
{
"content": "Please Give FORMAL Codereview for software developers in one sentence from the given diff hunk. Don’t start with Codereview/review. Just give the answer. Five examples are given before with code and code review and the code to work on is given after.",
"role": "user"
},
{
"content": "C... |
f1b43da82793436e | {
"callgraph": "[Codebase->[reloadFiles->[loadAnalyzer],getSymbolLocation->[getDeclaringMethodId,getFileContents],getCasedMethodId->[getCasedMethodId],getOverriddenMethodIds->[getOverriddenMethodIds],getCompletionDataAtPosition->[getFileContents],classImplements->[classImplements],classHasCorrectCasing->[classHasCorrectCasing],addTemporaryFileChanges->[addTemporaryFileChanges],classOrInterfaceExists->[classOrInterfaceExists],fileExists->[fileExists],getStatementsForFile->[getStatementsForFile],getSymbolInformation->[getDeclaringMethodId],getMethodReturnTypeLocation->[getMethodReturnTypeLocation],getMethodReturnType->[getMethodReturnType],interfaceExtends->[interfaceExtends],getReferenceAtPosition->[getFileContents],getSignatureInformation->[getDeclaringMethodId],getDeclaringMethodId->[getDeclaringMethodId],methodExists->[methodExists],traitHasCorrectCase->[traitHasCorrectCase],getFunctionArgumentAtPosition->[getFileContents],removeTemporaryFileChanges->[removeTemporaryFileChanges],classExists->[classExists],isVariadic->[isVariadic],scanFiles->[scanFiles],interfaceHasCorrectCasing->[interfaceHasCorrectCasing],getCompletionItemsForPartialSymbol->[getFileContents],getAppearingMethodId->[getAppearingMethodId],getMethodParams->[getMethodParams],queueClassLikeForScanning->[queueClassLikeForScanning],getParentInterfaces->[getParentInterfaces],addFilesToAnalyze->[addFilesToAnalyze],interfaceExists->[interfaceExists],getMethodReturnsByRef->[getMethodReturnsByRef],classExtends->[classExtends]]]",
"msg": "As mentioned below, I'm not sure why this is only allowing refs that are tagged with `*` at the start!",
"patch": "@@ -1279,10 +1279,13 @@ class Codebase\n }\n \n foreach ($reference_map as $start_pos => [$end_pos, $possible_reference]) {\n- if ($offset < $start_pos || $possible_reference[0] !== '*') {\n+ if ($offset < $start_pos) {\n continue;\n }\n-\n+ // If the reference precedes a \"::\" then treat it as a class reference.\n+ if ($offset - $end_pos === 2 && substr($file_contents, $end_pos, 2) === '::') {\n+ return [$possible_reference, '::', $offset];\n+ }\n if ($offset - $end_pos === 0) {\n $recent_type = $possible_reference;\n ",
"summary": "Get completion data at a given position. Recent type."
} | [
{
"content": "Please Give FORMAL Codereview for software developers in one sentence from the given diff hunk. Don’t start with Codereview/review. Just give the answer. Five examples are given before with code and code review and the code to work on is given after.",
"role": "user"
},
{
"content": "C... |
789077752986ed2e | {
"callgraph": "[DeepCopyAsyncCuda->[get_deep_copy_stream,CUDA_SAFE_CALL],attach_texture_object->[CUDA_SAFE_CALL],CUDA_SAFE_CALL->[CUDA_SAFE_CALL],deallocate->[CUDA_SAFE_CALL],reallocate_tracked->[allocate,get_label],allocate_tracked->[allocate],defined->[deallocate]]",
"msg": "Should this be using the `CUDA_SAFE_CALL` macro here?",
"patch": "@@ -917,6 +917,7 @@ void *cuda_resize_scratch_space(std::int64_t bytes, bool force_shrink) {\n \n void cuda_prefetch_pointer(const Cuda &space, const void *ptr, size_t bytes,\n bool to_device) {\n+ if ((ptr == nullptr) || (bytes == 0)) return;\n cudaPointerAttributes attr;\n cudaPointerGetAttributes(&attr, ptr);\n // I measured this and it turns out prefetching towards the host slows",
"summary": "cuda_prefetch_pointer - Cuda prefetch pointer KOKKOS_ENABLE_CUDA KOKKOS_PREVENT_."
} | [
{
"content": "Please Give FORMAL Codereview for software developers in one sentence from the given diff hunk. Don’t start with Codereview/review. Just give the answer. Five examples are given before with code and code review and the code to work on is given after.",
"role": "user"
},
{
"content": "C... |
End of preview. Expand
in Data Studio
README.md exists but content is empty.
- Downloads last month
- 13