patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -42,7 +42,7 @@ func TestDistributorQuerier(t *testing.T) {
querier, err := queryable.Querier(context.Background(), mint, maxt)
require.NoError(t, err)
- seriesSet, _, err := querier.Select(&storage.SelectParams{Start: mint, End: maxt})
+ seriesSet, _, err := querier.Select(false, &storage.SelectHints{Start: mi... | [InjectOrgID,Equal,NewForEncoding,NewChunk,At,Next,Background,Select,False,NoError,Querier,ToChunks,Labels,Err,True] | TestDistributorQuerier tests that the given labels are sorted. TestIngesterStreaming tests that the client has at least one chunk present and that there. | Enabling sorting here would be more clear (internally we returned sorted results anyway). |
@@ -230,9 +230,15 @@ func (a *apiServer) AddCluster(ctx context.Context, req *lc.AddClusterRequest) (
}, nil
}
+func stripSecretFromRequest(req *lc.HeartbeatRequest) *lc.HeartbeatRequest {
+ r := *req
+ r.Secret = ""
+ return &r
+}
+
func (a *apiServer) Heartbeat(ctx context.Context, req *lc.HeartbeatRequest) (re... | [GetActivationCode->[LogReq],DeleteCluster->[LogReq],AddCluster->[validateClusterConfig,checkLicenseState,LogReq],Activate->[LogReq],UpdateCluster->[validateClusterConfig,LogReq],checkLicenseState->[getLicenseRecord],Heartbeat->[LogReq],DeleteAll->[LogReq],ListClusters->[LogReq]] | AddCluster adds a new cluster to the license This is a long running routine that is called by the heartbeat goroutine. | Can you also update `LogReq` to log the request with the secret redacted? |
@@ -70,8 +70,8 @@ module Alaveteli
config.autoload_paths << "#{Rails.root.to_s}/lib/health_checks"
# See Rails::Configuration for more options
- ENV['RECAPTCHA_PUBLIC_KEY'] = ::AlaveteliConfiguration::recaptcha_public_key
- ENV['RECAPTCHA_PRIVATE_KEY'] = ::AlaveteliConfiguration::recaptcha_private_key... | [Application->[enforce_available_locales,after_initialize,recaptcha_public_key,raise_in_transactional_callbacks,root,insert,time_zone,autoload_paths,require,to_s,force_ssl,append,default_url_options,schema_format,encoding,recaptcha_private_key,match,cache_store,rack_cache,insert_before,default_timezone,domain,ip_spoofi... | This method is called after the application is initialized. It adds a catch - all route to. | Squash 2684989e5261f30c170ac1600add735dda997f80 in to this commit. +1 on renaming; easier to figure out what to google to get the keys / fix issues etc. |
@@ -125,6 +125,14 @@ public class PubsubTableProviderIT implements Serializable {
@Test
public void testSQLSelectsPayloadContent() throws Exception {
+
+ // Prepare messages to send later
+ List<PubsubMessage> messages =
+ ImmutableList.of(
+ objectsProvider.messageIdName(ts(1), 3, "foo"... | [PubsubTableProviderIT->[connect->[connect],messagePayload->[message],PubsubAvroObjectProvider->[messageIdName->[message]],PubsubProtoObjectProvider->[messageIdName->[message]],PubsubJsonObjectProvider->[message->[message],messageIdName->[message]]]] | This test method creates a table for the message and creates the pubsub table for the topic and Publish all messages to the events topic and wait for success. | Why do we need to "prepare messages to send later"? We only use the messages in one place, so I don't see why we need to define messages up front. |
@@ -32,6 +32,7 @@ ERROR_CODES_WHITELIST = {
def get_customer_data(payment_information: PaymentData) -> Dict:
+ """ Provides customer info, use only for new customer creation """
billing = payment_information.billing
return {
"order_id": payment_information.order_id,
| [get_client_token->[get_braintree_gateway],capture->[extract_gateway_response,get_error_for_client,get_braintree_gateway],void->[void,extract_gateway_response,get_error_for_client,get_braintree_gateway],refund->[refund,extract_gateway_response,get_error_for_client,get_braintree_gateway],authorize->[extract_gateway_resp... | Get customer data from payment information. | I don't believe we put spaces after and before triple-quotes |
@@ -113,7 +113,7 @@ namespace Microsoft.Xna.Framework.Graphics
Attributes[a].location = reader.ReadInt16();
}
- PlatformConstruct(isVertexShader, shaderBytecode);
+ PlatformConstruct(Stage, shaderBytecode);
}
internal protected override void Grap... | [Shader->[GraphicsDeviceResetting->[PlatformGraphicsDeviceResetting],PlatformProfile,MaxMipLevel,samplerSlot,parameter,textureSlot,Vertex,name,location,Filter,AddressV,ReadBoolean,ReadBytes,Pixel,type,ReadByte,ReadString,PlatformConstruct,BorderColor,MipMapLevelOfDetailBias,index,state,usage,ReadInt16,ReadInt32,Address... | Override this method to reset the state of the graphics device. | This was a convenient change which seemed good for future support of other shader stages. |
@@ -31,6 +31,8 @@ const {
SeleniumWebDriverController,
} = require('./selenium-webdriver-controller');
const {AmpDriver, AmpdocEnvironment} = require('./amp-driver');
+/* eslint-disable-next-line module-resolver/use-alias */
+const {configHelpers} = require('../../../testing/helpers');
const {HOST, PORT} = requir... | [No CFG could be retrieved] | This function is exported to the user by using the nagios - driver package. Load coverage information if needed. | I assume we can't use `#testing` here because this directory isn't part of the runtime, and isn't babel-transformed, minified, etc. Instead of disabling the lint rule like this, I think we should introduce an entry in `build-system/.eslintrc` that completely disables `module-resolver/use-alias` for all of `build-system... |
@@ -454,6 +454,9 @@ public class SlaveComputer extends Computer {
}
@Override public Integer call() {
Channel c = Channel.current();
+ if (c == null) {
+ return -1;
+ }
return resource ? c.resourceLoadingCount.get() : c.classLoadingCount.g... | [SlaveComputer->[getRetentionStrategy->[getNode,getRetentionStrategy],setNode->[setNode],getClassLoadingTime->[call],getResourceLoadingCount->[call],getNode->[getNode],grabLauncher->[getLauncher],taskCompleted->[taskCompleted],taskCompletedWithProblems->[taskCompletedWithProblems],getIcon->[getIcon],disconnect->[discon... | Get the count of the missing resource or class loading. | I think 0 would be more appropriate, as I had in #2934. This is a count, by definition nonnegative. At any rate, the previous behavior was an NPE so this cannot be worse. |
@@ -58,7 +58,7 @@ class TranslatableKinds(graphene.Enum):
PAGE = "Page"
PRODUCT = "Product"
SALE = "Sale"
- SHIPPING_METHOD = "ShippingMethod"
+ SHIPPING_METHOD = "ShippingMethodType"
VARIANT = "ProductVariant"
VOUCHER = "Voucher"
| [TranslationQueries->[resolve_translation->[from_global_id_or_error,models],resolve_translations->[resolve_attribute_values,resolve_shipping_methods,resolve_categories,resolve_menu_items,resolve_vouchers,resolve_product_variants,resolve_pages,resolve_collections,resolve_sales,resolve_attributes,resolve_products],BaseCo... | Creates a TranslatableItem class for a given object. Resolve category pages and shipping methods. | This should stay as `SHIPPING_METHOD` or should we rename it asa well? |
@@ -167,6 +167,18 @@ feature 'saml api', devise: true do
end
context 'visiting /api/saml/logout' do
+ context 'via SP-initiated logout when not logged in to IdP' do
+ it 'does not raise an exception' do
+ request = OneLogin::RubySaml::Logoutrequest.new
+ settings = sp1_saml_settings
+ ... | [visit,assertion_statement_node,create,new,let,phone,to_not,issuer,feature,it,domain_name,travel,to,soft,have_content,response_session_index_assertion,sign_in_before_2fa,return,before,click_button,scenario,second,t,require,include,sign_in_and_2fa_user,saml_response,metadata,each,click_on,fill_in,context,name_identifier... | It reports how the user logs in and displays a signed out request. checks that the logout request is not nil and that the response is a valid CSP form. | This is not a valid spec. The bug we are purporting to fix relates to SLO and session state at IdP. We need to test the following: 1. A user authenticates with a valid SP 2. The IdP session times out. `Timecop.travel` more than `Devise.timeout_in` 3. The SLO request from SP is properly handled by issuing a SAMLResponse... |
@@ -116,7 +116,7 @@ public abstract class ClassLoader {
private Map<String, Boolean> packageAssertionStatus;
private Map<String, Boolean> classAssertionStatus;
/*[IF Sidecar19-SE]*/
- private final Hashtable<String, NamedPackage> packages = new Hashtable();
+ private final Hashtable<String, NamedPackag... | [ClassLoader->[callerClassLoader->[getStackClassLoader],getPackageAssertionStatusHelper->[getPackageAssertionStatus],getResourceAsStream->[getResource],getPackages->[getPackagesHelper,getPackages],defineClass->[defineClass],findClass->[findClass],needsClassLoaderPermissionCheck->[isAncestorOf],initializeClassLoaders->[... | Initialize a class loader. | tab vs space? Formatting seems off here |
@@ -9,12 +9,7 @@ RSpec.describe Dependabot::GoModules::FileUpdater::GoModUpdater do
let(:updater) do
described_class.new(
dependencies: [dependency],
- credentials: [{
- "type" => "git_source",
- "host" => "github.com",
- "username" => "x-access-token",
- "password" => "t... | [new,let,updated_go_sum_content,to_not,describe,subject,it,to,before,double,glob,require,include,updated_go_mod_content,fixture,context,merge,not_to,eq,and_call_original,raise_error,and_return,build_tmp_repo] | requires the name of the package on file changes check if dependencies have changed. | It's more realistic to have empty or valid credentials here. Fake credentials will result in `PrivateSourceAuthenticationFailure` in some of the cases. We have a test for that in another file but I think we could move those cases over here as a future cleanup. |
@@ -211,6 +211,16 @@ namespace MonoGame.Utilities.Png
switch (texture2D.Format)
{
+ case SurfaceFormat.Single:
+ var floatData = new float[colorDataLength];
+ texture2D.GetData<float>(floatData);
+
+ ... | [PngWriter->[CalculateBytesPerPixel->[Palette,GrayscaleWithAlpha,RgbWithAlpha,Grayscale,Rgb],Write->[PngSignature,Write,Height,Data,BitDepth,CompressionMethod,FilterMethod,CopyTo,GetColorData,ColorType,InterlaceMethod,EncodePixelData,Compress,Encode,ToArray,Length,Width],CalculateTotalVariation->[Abs,Length],GetColorDa... | GetColorData - Get color data of a specific texture. private function to get all data in the system which can be found in the system check if any color in the colorData array is missing. | I don't know if the compiler is smart enough to optimize this down to one array access, but to avoid any extraneous bounds checks, read the array once into a temporary `float` and pass that float into the `Color` constructor. Using `fixed` would make it faster still, but see if the first approach makes any improvement.... |
@@ -306,7 +306,7 @@ public final class HeartbeatAgent {
missedCount = (windowEnd - prev - 1) / config.heartbeatSendIntervalMs;
}
- LOG.debug("Host: {} has {} missing heartbeats", host, missedCount);
+ LOG.debug("Host: {} has {} missing heartbeats", ksqlHost, missedCount);
return (miss... | [HeartbeatAgent->[CheckHeartbeatService->[processHeartbeats->[getHostsStatus]],Builder->[build->[HeartbeatAgent]]]] | Decide if the heartbeat frame should be sent. | what do you think about `info` logging this if `missedCount > 0`? |
@@ -264,6 +264,16 @@ public class GetAzureEventHub extends AbstractProcessor {
} else {
configuredEnqueueTime = null;
}
+ if(context.getProperty(RECEIVER_FETCH_SIZE).isSet()) {
+ receiverFetchSize = context.getProperty(RECEIVER_FETCH_SIZE).asInteger();
+ } else {
... | [GetAzureEventHub->[receiveEvents->[getReceiver],onTrigger->[receiveEvents],onScheduled->[setupReceiver]]] | On scheduled process context. | This should be ofMils not ofSeconds |
@@ -688,10 +688,13 @@ class GradeEntryFormsControllerTest < AuthenticatedControllerTest
should 'set an empty grade to a valid value' do
@new_grade = 2.5
- post_as @admin, :update_grade, {:grade_entry_item_id => @grade_entry_items[0].id,
- :student_id => @g... | [GradeEntryFormsControllerTest->[position,update_total_grade,new,find,post_as,fixture_file_upload,assert_raise,errors,name,should,description,find_by_name,assert_equal,body,assert,message,returns,find_by_user_id,find_by_short_identifier,assigns,t,released_to_student,assert_not_nil,date,find_by_grade_entry_student_id_an... | here is a bit of a hack to get around the problem with the administration of the attempt to set an empty grade to a string. | Trailing whitespace detected. |
@@ -127,6 +127,9 @@ public class StandardValidators {
public static final Validator PORT_VALIDATOR = createLongValidator(1, 65535, true);
+ /**
+ * {@link Validator} that ensures that value's length > 0
+ */
public static final Validator NON_EMPTY_VALIDATOR = new Validator() {
@Overrid... | [StandardValidators->[createControllerServiceExistsValidator->[validate->[validate]],createDataSizeBoundsValidator->[validate->[validate]],createAttributeExpressionLanguageValidator->[createAttributeExpressionLanguageValidator]]] | Validate the given subject and value. | For the explanation, rather than indicating that it cannot be empty, i would indicate "must contain at least one character that is not white space" |
@@ -113,8 +113,11 @@ def category_index(request, path, category_id):
if actual_path != path:
return redirect('product:category', permanent=True, path=actual_path,
category_id=category_id)
+ # Check for subcategories
+ categories = category.get_descendants(include_self=True)
... | [product_details->[get_absolute_url,all,get_product_images,product_json_ld,get_slug,get_variant_picker_data,get_product_attributes_data,handle_cart_form,get_availability,dumps,products_with_details,HttpResponsePermanentRedirect,TemplateResponse,today,get_object_or_404],category_index->[get_object_or_404,get_full_path,r... | Show a list of products in a category. | Can we use flat `values_list` on the queryset? |
@@ -422,8 +422,8 @@ namespace System.Net.Sockets
{
Debug.Assert(socketAddress != null, "Expected non-null socketAddress");
- int cmsgBufferLen = Interop.Sys.GetControlMessageBufferSize(isIPv4, isIPv6);
- var cmsgBuffer = stackalloc byte[cmsgBufferLen];
+ int cmsg... | [SocketPal->[TryCompleteSendTo->[TryCompleteSendTo,SysSend],TryCompleteConnect->[SocketError],TryCompleteSendFile->[SendFile],TryCompleteReceiveFrom->[TryCompleteReceiveFrom,SysReceive],TryCompleteReceiveMessageFrom->[SysReceiveMessageFrom],TryCompleteReceive->[SysReceive],SendPacketsAsync->[SocketError],SocketError->[... | This method is called from SysReceiveMessage. | Unrelated question about `byte*` here. Is this being used instead of `Span<T>` because it is immediately passed along and not used in managed? I am trying to enrich my mental model for best practices and want to make sure I am getting the "why". |
@@ -319,7 +319,7 @@ public final class ThriftMetastoreUtil
principal = new HivePrincipal(USER, identity.getUser());
}
else {
- principal = new HivePrincipal(ROLE, identity.getRole().get().getRole().get());
+ principal = new HivePrincipal(ROLE, identity.getRole().get(... | [ThriftMetastoreUtil->[fromMetastoreDistinctValuesCount->[fromMetastoreDistinctValuesCount],toMetastoreApiPartition->[toMetastoreApiPartition],parsePrivilege->[fromMetastoreApiPrincipalType],listEnabledTablePrivileges->[listEnabledPrincipals],fromMetastoreApiTable->[fromMetastoreApiTable]]] | Checks if the given role is enabled in the given identity. | Please extract usage of `Name` in `PrestoPrincipal` and `SelectedRole` to separate commits. |
@@ -252,10 +252,9 @@ module Dependabot
return unless resolved_url
return unless resolved_url.start_with?("http")
- return if CENTRAL_REGISTRIES.any? { |u| resolved_url.start_with?(u) }
return if resolved_url.match?(/(?<!pkg\.)github/)
- private_registry_source_for(resolved_u... | [FileParser->[git_url_with_semver?->[git_url?],version_for->[git_url_with_semver?,git_url?],source_for->[git_url?],git_revision_for->[git_url?],manifest_dependencies->[parse],requirement_for->[git_url?],lockfile_dependencies->[parse]]] | Returns the source for a given dependency name requirement and manifest name. | I wonder why we return here? Seems ok to keep but maybe one to clean up at some point |
@@ -82,6 +82,13 @@ Optional('assessor'): Or({
Optional('start_step'): And(int, lambda x: 0 <= x <= 9999)
},
Optional('gpuNum'): And(int, lambda x: 0 <= x <= 99999)
+},{
+ 'builtinAssessorName': lambda x: x in ['Curvefitting'],
+ Optional('classArgs'): {
+ Optional('start_step'): And(int,... | [Or,Optional,Schema,And,Regex] | A function to filter out the possible values of the n - output node - n - output Schema for object. | would be better to put required before optional. |
@@ -147,6 +147,7 @@ from .math import sqrt_ # noqa: F401
from .math import square # noqa: F401
from .math import stanh # noqa: F401
from .math import sum # noqa: F401
+from .math import nansum # noqa: F401
from .math import tanh # noqa: F401
from .math import tanh_ # noqa: F401
from .math import add_n # n... | [No CFG could be retrieved] | Import all of the functions from the logic module. Imports the given n - node from the given system. | for paddle.Tensor.nansum, we should add nansum in list of tensor_method_func below |
@@ -160,6 +160,7 @@ APPS_ALL = {app.id: app for app in APP_USAGE + (MOZILLA, SUNBIRD, MOBILE)}
APP_IDS = {app.id: app for app in APP_USAGE}
APP_GUIDS = {app.guid: app for app in APP_USAGE}
APPS_CHOICES = tuple((app.id, app.pretty) for app in APP_USAGE)
+APP_USAGE_STATICTHEME = (FIREFOX,)
APP_TYPE_SUPPORT = {}
fo... | [FIREFOX->[_],THUNDERBIRD->[_],SUNBIRD->[_],MOZILLA->[_],MOBILE->[_],ANDROID->[matches_user_agent->[groups,search,vint],_,compile],UNKNOWN_APP->[_],SEAMONKEY->[_],list,append,getattr,tuple,setdefault,values] | Create a list of objects representing the n - grams of the application. Remove the version from the list of versions. | I would put that right below `APP_USAGE` for some reason. Static themes are not yet supported on android? |
@@ -107,7 +107,7 @@ module GobiertoBudgets
terms = [
{term: { kind: conditions[:kind] }},
- {term: { ine_code: conditions[:place].id }}
+ {term: { ine_code: conditions[:site].organization_id }}
]
terms.push({term: { year: conditions[:year] }}) if conditions[:y... | [all->[functional_codes_for_economic_budget_line],compare->[search],any_data?->[search],budget_line_query->[search,for_ranking],top_differences->[search],search->[search]] | all functions that can be found in the budget line This method returns an array of objects representing a single . | Space inside { missing.<br>Space inside } missing. |
@@ -13,6 +13,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
+import {RequestBankE2E} from '../../../../build-system/tasks/e2e/request-bank';
describes.endtoend(
'amp-ad-exit',
| [No CFG could be retrieved] | Displays a page with a specific . Move the product1 ad. | Is `RequestBankE2E` specific to `amp-ad-*` or can it be used in other e2e tests? |
@@ -136,7 +136,11 @@ class RPC:
'ask_strategy': config.get('ask_strategy', {}),
'bid_strategy': config.get('bid_strategy', {}),
'state': str(botstate),
- 'runmode': config['runmode'].value
+ 'runmode': config['runmode'].value,
+ 'position_adjustmen... | [RPC->[_rpc_status_table->[RPCException],_rpc_trade_status->[RPCException],_rpc_analysed_history_full->[_convert_dataframe_to_dict,RPCException],_rpc_stats->[trade_win_loss],_rpc_monthly_profit->[RPCException],_rpc_forcesell->[RPCException,_exec_forcesell],_rpc_analysed_dataframe->[_convert_dataframe_to_dict],_rpc_bala... | Return a dict of options and values from the config dict. Get the status of a single critical node. Calculate the profit ratio of a single node. | unfortunately, the way the defaults are set, this causes a crash in webserver mode (start freqtrade with `freqtrade webserver` with a config that does not contain this key and login to the UI). Not all freqtrade modes load a strategy right away - so to properly set the default, we'll have to have it as part of the json... |
@@ -180,9 +180,11 @@ public class RegistryDirectory<T> extends DynamicDirectory<T> implements NotifyL
return "";
}
- private void refreshOverrideAndInvoker(List<URL> urls) {
+ // Issue: https://github.com/apache/dubbo/issues/6763.
+ // RefreshOverrideAndInvoker will be executed by registryCente... | [RegistryDirectory->[destroy->[destroy],destroyUnusedInvokers->[destroyAllInvokers,destroy],isAvailable->[isAvailable],destroyAllInvokers->[destroy],notify->[notify],subscribe->[subscribe],ReferenceConfigurationListener->[notifyOverrides->[refreshOverrideAndInvoker]],ConsumerConfigurationListener->[notifyOverrides->[re... | Returns the category of the given URL. | remove this line, and we can refer these changes in git blame |
@@ -62,7 +62,7 @@ public class VirtualSystemSetupAction extends RhnAction
public List<VirtualSystemOverview> getResult(RequestContext context) {
User user = context.getCurrentUser();
- DataResult<VirtualSystemOverview> dr = SystemManager.virtualSystemsList(user, null);
+ DataResult<Virtual... | [VirtualSystemSetupAction->[getResult->[getVirtualSystemId,isFakeNode,setSystemId,processList,getUuid,virtualSystemsList,getHostSystemId,getServerName,setName,getCurrentUser],execute->[findForward,setWillClearSet,setListName,setDataSetName,ListRhnSetHelper,execute]]] | Get the list of virtual systems which are not yet available. | This whole class will not be used any more since this was what was behind the old JSP. You should also remove the corresponding `<action>` in `java/code/webapp/WEB-INF/struts-config.xml` and the corresponding jsp page: `/WEB-INF/pages/systems/virtuallist.jsp` |
@@ -191,13 +191,13 @@ public class HistoryPageFilter<T> {
return queueItems.size() + runs.size();
}
- private void sort(List<T> items) {
+ private void sort(List<? extends Object> items) {
// Queue items can start building out of order with how they got added to the queue. Sorting them
... | [HistoryPageFilter->[size->[size],addQueueItem->[add],getNextBuildNumber->[getNextBuildNumber],isFull->[size],getFillCount->[size],addRun->[add],add->[addRun,addQueueItem,add],sort->[sort]]] | Sort the items in the queue and in the order they are added to the page. | Unclear why `T` was dropped from this. |
@@ -31,12 +31,11 @@ class PlatformRepository extends ArrayRepository
*
* @var array
*/
- private $overrides;
+ private $overrides = array();
public function __construct(array $packages = array(), array $overrides = array())
{
parent::__construct($packages);
- $this->o... | [PlatformRepository->[addPackage->[getName],initialize->[normalize,addPackage,buildPackageName,info,setDescription,getVersion]]] | Initializes the object with the given packages and overrides. | I feel like I am not getting through today :p What I mean is that the three lines above here, are used below at line 52 inside initialize(). So these 3 lines need to happen before the parent constructor is called and therefore initialize is triggered. I don't care how $overrides is initialized to an array in the first ... |
@@ -5564,16 +5564,12 @@ void home_all_axes() { gcode_G28(true); }
z_at_pt[axis] /= (2 * offset_circles + 1);
}
}
- if (_7p_intermed_points) // average intermediates to tower and opposites
- for (uint8_t axis = 1; axis < 13; axis += 2)
- z_at_pt[axi... | [No CFG could be retrieved] | Z - offset - offset - offset - offset - offset - offset - offset - offset - The method to find the non - zero standard deviation of the given points. | Or store this file to a safe location (allow me to edit) |
@@ -335,15 +335,15 @@ func createEventBulkMeta(
ID: id,
}
- if opType == opTypeDelete {
+ if opType == events.OpTypeDelete {
if id != "" {
return eslegclient.BulkDeleteAction{Delete: meta}, nil
} else {
- return nil, fmt.Errorf("%s %s requires _id", opTypeKey, opTypeDelete)
+ return nil, fmt.... | [publishEvents->[SetLabel,Error,NewBatch,Failed,Bulk,Now,Duplicate,End,GetVersion,StartSpan,Acked,CaptureError,Errorf,Send,Sub,ErrTooMany,Dropped,Debugf],Test->[Test],Connect->[Connect],Close->[Close],Publish->[Events,RetryEvents,ACK,publishEvents],Unlock,IsEmpty,NewLogger,GetMetaStringValue,Error,New,Warnf,NewConnecti... | getBulkAction returns bulk action object for the given event. bulkCollectPublishFails returns all events for the given and the stats for the publish. | `OpType` implements `fmt.Stringer`. No need to call `String()` explicitely. |
@@ -22,10 +22,10 @@ class LocationContentTypeTest extends \PHPUnit_Framework_TestCase
public function setUp()
{
- $this->nodeRepository = $this->getMock('Sulu\Bundle\ContentBundle\Repository\NodeRepositoryInterface');
- $this->phpcrNode = $this->getMock('PHPCR\NodeInterface');
- $this->... | [LocationContentTypeTest->[testRead->[initReadTest]]] | Sets up the mocked properties. | is this method also available in phpunit 4.8? if yes we should avoid the update and keep PHP 5.5 at least in this PR. all the other things we can discuss in the issue |
@@ -31,7 +31,7 @@
convention = userDefinedConvention.GetTimeToBeReceivedForMessage;
}
- var doesTransportSupportDiscardIfNotReceivedBefore = context.Settings.DoesTransportSupportConstraint<DiscardIfNotReceivedBefore>();
+ var doesTransportSupportDiscardIfNotReceived... | [TimeToBeReceived->[TimeToBeReceivedMappings->[MessageType,DefaultConvention,GetTimeToBeReceivedForMessage,Select,Settings,TryGet],Setup->[Register,GetMappings],EnableByDefault]] | Get mappings for time to receive messages. | we could add TransportDefinition to the feature context, and even make that publicly accessible if we want to allow transport re-configuration at feature setup time. |
@@ -396,7 +396,7 @@ public abstract class Console implements Closeable {
tableBuilder.withColumnHeaders("Query ID", "Kafka Topic", "Query String");
runningQueries.forEach(
r -> tableBuilder.withRow(
- r.getId(), String.join(",", r.getSinks()), r.getQueryString()));
+ r... | [Console->[Clear->[execute->[puts,flush]],printQueryDescriptionList->[printQueryDescription],Help->[execute->[printHelp]],Table->[print->[addResult,getColumnLength,flush],Builder->[build->[Table]]],printStreamedRow->[printErrorMessage],printOverriddenProperties->[print],printSourceDescriptionList->[printSourceDescripti... | Prints the entity as a table. This method is used to build a tableBuilder with a specific topic and format This method is called to print out the KsqlEntity in the KnowledgeBase. | maybe add a `getIdAsString()` or similar? |
@@ -1029,6 +1029,7 @@ class Model(object):
a numpy array or paddle.Tensor, or a list of arrays or tensors
(in case the model has multiple labels). If has no labels,
set None. Default is None.
+ update (bool): Whether update parameters after loss.backward()... | [StaticGraphAdapter->[parameters->[parameters],save->[_save->[to_numpy],_save],_run->[flatten_list,restore_flatten_list,to_list],_make_program->[_all_gather,to_list]],init_communicator->[wait_server_ready],DynamicGraphAdapter->[parameters->[parameters],predict_batch->[_all_gather,_update_input_info,to_numpy,to_list],lo... | Run one training step on a batch of data. | Maybe doc string should not exceed 80 columns:) |
@@ -34,3 +34,6 @@ using System.Reflection;
[assembly: AssemblyProduct("http://www.dnnsoftware.com")]
[assembly: AssemblyCopyright("DotNetNuke is copyright 2002-2018 by DNN Corporation. All Rights Reserved.")]
[assembly: AssemblyTrademark("DNN")]
+[assembly: AssemblyVersion("9.4.2.0")]
+[assembly: AssemblyFileVersion... | [No CFG could be retrieved] | Assembly for DNN. | Is this supposed to be added in here? Or when the manifests are reverted, should this be reverted as well? |
@@ -55,7 +55,7 @@ class WPSEO_Premium_Upsell_Admin_Block {
$arguments = array(
'<strong>' . esc_html__( 'Multiple keyphrases', 'wordpress-seo' ) . '</strong>: ' . esc_html__( 'Increase your SEO reach', 'wordpress-seo' ),
'<strong>' . esc_html__( 'No more dead links', 'wordpress-seo' ) . '</strong>: ' . esc_h... | [WPSEO_Premium_Upsell_Admin_Block->[register_hooks->[is_hidden],is_hidden->[get_query_variable_name,get_option_name],render->[get_query_variable_name,get_html_class],get_argument_html->[get_html_class]]] | Renders the wordpress command Renders a Yoast SEO upgrade button. | In our marketing, we use internal linking suggestions. Please change the other occurrence to `internal linking`. |
@@ -119,7 +119,7 @@ class Admin::BackupsController < Admin::AdminController
return render status: 415, text: I18n.t("backup.backup_file_should_be_tar_gz") unless /\.(tar\.gz|t?gz)$/i =~ filename
return render status: 415, text: I18n.t("backup.not_enough_space_on_disk") unless has_enough_space_on_disk?(t... | [logs->[logs,render,operations_status,store_preloaded,dump],create->[fetch,render,log_backup_operation,merge,backup!,t,id],status->[render_json_dump,operations_status],show->[fetch,path,render,size,send_file],rollback->[t,merge,render,rollback!],readonly->[to_s,disable_readonly_mode,render,enable_readonly_mode],upload_... | upload a backup file in a specific chunk. | Should probably escape the `-` like we do for the `.` in order to prevent the issue from happening again. |
@@ -120,12 +120,14 @@ define(['../createCommand',
*/
this.transitioner = transitioner;
+ this.flightDuration = flightDuration;
+
/**
* The command for switching to home view.
* @type Command
*/
this.command = createCommand(function() {
- ... | [No CFG could be retrieved] | Creates a new instance of HomeButtonViewModel. | This should be an observable `knockout.observable(flightDuration)`. It also needs doc, something like "Gets an Observable whose value is the duration in milliseconds of the flight to home position." |
@@ -54,9 +54,10 @@
</head>
<body class="site <%= yield(:background_cls) %>">
+<%= link_to t('shared.skip_link'), '#main-content', class: 'usa-skipnav' %>
<div class="usa-overlay"></div>
<%= yield(:mobile_nav) if content_for?(:mobile_nav) %>
- <div class="site-wrap bg-light-blue">
+ <div class="bg-light-blue... | [No CFG could be retrieved] | Renders a single - page page with a hidden hidden element. Renders the nagon page. | Do we need this wrapper element anymore? |
@@ -18,14 +18,14 @@ describe "When filtering" do
it "should not fail handling a bounce mail" do
xc = ExternalCommand.new("script/handle-mail-replies",
- { :stdin_string => load_file_fixture("track-response-exim-bounce.email") })
+ stdin_string: l... | [mail_reply_test->[load_file_fixture,to,new,root,chdir,eq,run],load_file_fixture,to,new,describe,eq,mail_reply_test,run,it,require] | test - when - filtering - mail - replies - test - when - filtering - mail - should pass on a non - bounce message. | Line is too long. [99/80] |
@@ -30,9 +30,13 @@ class Dealii(Package):
"""C++ software library providing well-documented tools to build finite
element codes for a broad variety of PDEs."""
homepage = "https://www.dealii.org"
- url = "https://github.com/dealii/dealii/releases/download/v8.4.0/dealii-8.4.0.tar.gz"
+ url ... | [Dealii->[install->[join_path,upper,print,cmake,working_dir,extend,startswith,filter_file,remove,make],setup_environment->[set],variant,depends_on,version]] | Creates a element object with all of the possible values set. variant - Optional description. | you don't need to change that line. Actual URL will be picked up automatically. |
@@ -179,7 +179,7 @@ class FunctionEmitterVisitor(OpVisitor[None], EmitterInterface):
def visit_load_int(self, op: LoadInt) -> None:
dest = self.reg(op)
- if is_c_int_rprimitive(op.type):
+ if is_int32_rprimitive(op.type) or is_int64_rprimitive(op.type):
self.emit_line('%s = %d... | [FunctionEmitterVisitor->[emit_line->[emit_line],c_undefined_value->[c_undefined_value],c_error_value->[c_error_value],visit_call->[get_dest_assign],emit_dec_ref->[emit_dec_ref],label->[label],get_attr_expr->[temp_name],visit_get_attr->[get_attr_expr],visit_call_c->[get_dest_assign],ctype->[ctype],emit_declaration->[em... | Emit load - int values. | I've located the key to fix this. Because we change the create dict's `LoadInt`'s type to `c_pyssize_t_rprimitive` without changing here, the value would be doubled during codegen. Now it's fixed. |
@@ -248,11 +248,13 @@ public abstract class AbstractScriptProcessor extends AbstractSessionFactoryProc
Thread.currentThread().setContextClassLoader(scriptEngineModuleClassLoader);
}
- scriptEngine = createScriptEngine();
+ ScriptEngine scriptEngine = createScriptEng... | [AbstractScriptProcessor->[isFile->[isRegularFile,get],createScriptEngine->[getScriptEngine,get],createScriptEngineModuleClassLoader->[URLClassLoader,getClassLoader],setupEngine->[error,toArray,size,init,getLogger,add,get,toURL,createScriptEngineModuleClassLoader,toLowerCase,createScriptEngine,isDebugEnabled,getContext... | Initializes the script engine. | Obviously you moved the declaration to be locally scoped because you intended to add a for loop here. But as of right now, it only populates the queue with a single engine instance, so despite having multiple threads consume and re-populate it, the queue will only ever contain 1 or 0 engines for use. |
@@ -1069,6 +1069,15 @@ class TypeConverter:
self.node_stack = [] # type: List[AST]
self.assume_str_is_unicode = assume_str_is_unicode
+ def _invalid_type(self, node: AST, note: Optional[str] = None) -> RawExpressionType:
+ return RawExpressionType(
+ None,
+ 'typing.... | [parse_type_string->[parse_type_comment],parse_type_comment->[parse],stringify_name->[stringify_name],TypeConverter->[visit_UnaryOp->[visit,fail],visit_Num->[fail],visit_Str->[parse_type_string],visit_Attribute->[visit,fail],_extract_argument_name->[fail],visit_Subscript->[visit,translate_expr_list,fail],translate_argu... | Initialize a object. | No need for this to be private. Also a short docstring would be great. |
@@ -703,6 +703,9 @@ class BuildManager:
def stats_summary(self) -> Mapping[str, object]:
return self.stats
+ def error_flush(self, msgs: List[str], serious: bool=False) -> None:
+ self.flush_errors(msgs, serious)
+
def remove_cwd_prefix_from_path(p: str) -> str:
"""Remove current worki... | [find_modules_recursive->[BuildSource,find_module,find_modules_recursive],verify_module->[is_file],process_graph->[add_stats,trace,log],BuildManager->[all_imported_modules_in_file->[correct_rel_imp,import_priority],get_stat->[maybe_swap_for_shadow_path],report_file->[is_source]],maybe_reuse_in_memory_tree->[add_stats,t... | Return a mapping from the path to the object that is used to populate the stats. | Consider getting rid of this and just inlining the only call site to add serious=False? |
@@ -3,10 +3,11 @@
#
# SPDX-License-Identifier: (Apache-2.0 OR MIT)
+import os
from spack import *
-class Treelite(CMakePackage):
+class Treelite(CMakePackage, PythonPackage):
"""Treelite is a model compiler for efficient deployment of
decision tree ensembles."""
| [Treelite->[version]] | Creates a model compiler for efficient deployment of decision tree ensembles. | I don't think there's any point in extending both, is there? A lot of the settings in those build systems conflict anyway. |
@@ -49,10 +49,10 @@ func NewCmdPruneImages(f *clientcmd.Factory, parentName, name string, out io.Wri
Run: func(cmd *cobra.Command, args []string) {
if len(args) > 0 {
- glog.Fatalf("No arguments are allowed to this command")
+ glog.Fatal("No arguments are allowed to this command")
}
- osClient, k... | [StringVar,DeletingLayerPruneFunc,DeploymentConfigs,DeletingManifestPruneFunc,IntVar,Flush,ReadFile,ReplicationControllers,Len,Run,DurationVar,CheckErr,Clients,NewWriter,Join,Fprintln,BuildConfigs,Images,DeletingBlobPruneFunc,Fatalf,Builds,TLSConfigFor,Everything,ClientConfig,Fprintf,ImageStreams,NewStringSet,NewImageP... | NewCmdPruneImages returns a Command instance for pruning images. List all images in the system. | Do a `CheckErr` on a `UsageError` to get the common usage text. |
@@ -66,6 +66,7 @@ void GcodeSuite::M575() {
if (set1) { MYSERIAL1.end(); MYSERIAL1.begin(baud); }
#endif
+ if (parser.seen('U')) settings.save();
} break;
default: SERIAL_ECHO_MSG("?(B)aud rate implausible.");
}
| [No CFG could be retrieved] | Start the timers and timers for the BAUD rate. | Does this always happen fast enough to beat the serial disconnect and potential reconnect-and-reboot caused by the baud rate change just above? I would guess, _probably_. |
@@ -77,12 +77,12 @@ public class ESAuditMigrationWork extends AbstractWork {
TransactionHelper.commitOrRollbackTransaction();
long t0 = System.currentTimeMillis();
long nbEntriesMigrated = 0;
- int pageIdx = 1;
+ pageIdx = 1;
while (nbEntriesMigrat... | [ESAuditMigrationWork->[work->[newLogEntry,newInstance,size,onApplicationStopped,setEventId,warn,info,onApplicationStarted,setPrincipalName,setCategory,singletonList,getComponent,getTime,setProgress,nativeQuery,getBackend,getService,currentTimeMillis,AuditBackendDescriptor,commitOrRollbackTransaction,get,setEventDate,a... | This method is invoked when the migration is done. onApplicationStopped - Event date not supported. | Please don't make it a field. The issue is that the lambda needs final or effectively final captured variables, which is not the case of this one. The solution is, just before the lambda, to create `int pageIdxF = pageIdx` and use `pageIdxF` inside the lambda. |
@@ -329,9 +329,16 @@ func (m *ModeManager) tickDR() {
drTickCounter.Inc()
- canSync := m.checkCanSync()
+ totalPrimary, totalDr := m.config.DRAutoSync.PrimaryReplicas, m.config.DRAutoSync.DRReplicas
+ downPrimary, downDr := m.checkStoreStatus()
- if !canSync && m.drGetState() != drStateAsync {
+ // canSync is t... | [checkRegionRecover->[GetReplicationStatus],tickDR->[drSwitchToSync,drSwitchToSyncRecover,drSwitchToAsync,drGetState,getModeName]] | tickDR tick the DR state machine. | seems not belong to this issue. |
@@ -592,7 +592,6 @@ class Context(Configuration):
'bld_path',
'conda_build',
'croot',
- 'allow_conda_downgrades',
'debug',
'default_python',
'dry_run',
| [Context->[default_python_default],determine_target_prefix->[locate_prefix_by_name],reset_context->[__init__],get_prefix->[determine_target_prefix],Context] | List the parameters of the context. | why is this removed? I think it has to stay here? |
@@ -173,6 +173,8 @@ EOF;
file_put_contents($vendorPath.'/autoload.php', $this->getAutoloadFile($vendorPathToTargetDirCode, $suffix));
file_put_contents($targetDir.'/autoload_real.php', $this->getAutoloadRealFile(true, true, (bool) $includePathFile, $targetDirLoader, $filesCode, $vendorPathCode, $appBa... | [No CFG could be retrieved] | Builds the autoload map for the given packages. Returns an ordered list of namespace - > path mappings for the given package instance. | hardcoding the debug mode looks wrong to me |
@@ -441,6 +441,7 @@ function copyCss() {
* @return {!Promise}
*/
function watch() {
+ printConfigHelp('gulp watch', 'dist/amp.js');
$$.watch('css/**/*.css', function() {
compileCss();
});
| [No CFG could be retrieved] | Copy the css from the AMP build folder to the dist folder. Builds a new extension. | Consider moving `dist/amp.js` to a shared const. |
@@ -76,6 +76,8 @@ namespace System.Data
/// Initializes a new instance of a <see cref='System.Data.DataColumn'/>
/// class.
/// </summary>
+ [UnconditionalSuppressMessage("ReflectionAnalysis", "IL2026:UnrecognizedReflectionPattern",
+ Justification = "This is safe because ty... | [AutoIncrementBigInteger->[SetCurrentAndIncrement->[BoundaryCheck],BoundaryCheck],AutoIncrementInt64->[SetCurrentAndIncrement->[IsAutoIncrementType]],DataColumn->[SetCapacity->[SetCapacity],ConvertValue->[ConvertValue],CompareValueTo->[CompareValueTo],FinishInitInProgress->[BindExpression],AddDependentColumn->[AddDepen... | Private methods for the DataColumn class. Missing data column. | NIT: for "IL2026" we usually just add RequiresUnreferencedCode, instead of UnrecognizedReflectionPattern |
@@ -632,6 +632,7 @@ function parseExtensionFlags() {
log(minimalSetMessage);
process.exit(1);
}
+ argv.extensions = argv.extensions.replace(/\s/g, '');
if (argv.extensions === 'minimal_set') {
argv.extensions =
'amp-ad,amp-ad-network-adsense-impl,amp-audio,amp-... | [No CFG could be retrieved] | Parses the command line flags and prints a helpful message if the user has not specified any extensions Enables runtime to be used for local testing by writing AMP_CONFIG to file. | this is separated issue. added here since it's a one line change : ) to fix use case like `--extensions="amp-foo, amp-bar"` |
@@ -95,9 +95,13 @@ module Idv
def throttled_else_increment
return unless document_capture_session
- @throttled = Throttler::IsThrottledElseIncrement.call(
- document_capture_session.user_id,
- :idv_acuant,
+ @throttled = throttler.throttled_else_increment?
+ end
+
+ def throt... | [ApiDocumentVerificationForm->[validate_image_urls->[valid_url?,liveness_checking_enabled?]]] | check if the user has a throttling else increment. | In other classes, this is called `throttle`. Should it be the same here? |
@@ -131,11 +131,11 @@ def test_duplicated_transaction_same_gas_price_raises(deploy_client):
contract_proxy.contract_address,
)
- gas = contract_proxy.estimate_gas('ret') * 2
+ startgas = contract_proxy.estimate_gas('ret') * 2
with pytest.raises(TransactionAlreadyPending):
- second_pr... | [test_transact_opcode_oog->[deploy_rpc_test_contract],test_duplicated_transaction_different_gas_price_raises->[deploy_rpc_test_contract,make_decreasing_gas_price_strategy],test_filter_end_block_inclusive->[deploy_rpc_test_contract,get_list_of_block_numbers],test_call_invalid_selector->[deploy_rpc_test_contract],test_ca... | Test duplicated transaction same gas price raises. This function is called when the contract is not in the chain. | I don't understand the need for doubling the estimate here and below. Either don't double it, or use the safety `GAS_FACTOR` from `raiden.constants`, if this is what you want to test, instead. |
@@ -119,6 +119,11 @@ class Event:
pass
+class EventsError(NamedTuple):
+ events: List[Event]
+ error: str
+
+
@dataclass
class TransferTask(State):
# TODO: When we turn these into dataclasses it would be a good time to move common attributes
| [TransitionResult->[__ne__->[__eq__]],StateManager->[__ne__->[__eq__]]] | Declare the transition to be applied in a state object. Marker used for events which represent on - chain transactions. | How do I interpret an instance of this? Does one of the `events` contain a problem, or all `events` together form a problem? |
@@ -1,10 +1,8 @@
-ENVied.require(*ENV["ENVIED_GROUPS"] || Rails.groups)
-
class ApplicationConfig
URI_REGEXP = %r{(?<scheme>https?://)?(?<host>.+?)(?<port>:\d+)?$}.freeze
def self.[](key)
- ENVied.public_send(key)
+ ENV[key]
end
def self.app_domain_no_port
| [ApplicationConfig->[app_domain_no_port->[match],freeze,public_send],groups,require] | Returns the value of a key in the environment or nil if it is not set. | **suggestion (non-blocking):** Should we use `ENV.fetch(key)` here? The previous code raises a `NameError` for invalid keys, the current one returns `nil` instead. Changing to `fetch` would raise a `KeyError` instead. |
@@ -1659,11 +1659,15 @@ export class ResourcesImpl {
/**
* @param {!./task-queue.TaskDef} task
* @param {boolean} success
- * @param {*=} opt_reason
+ * @param {!AbortSignal|*} data
* @return {!Promise|undefined}
* @private
*/
- taskComplete_(task, success, opt_reason) {
+ taskComplete_(tas... | [No CFG could be retrieved] | Determines if a task has been successfully scheduled and if so schedules it. Checks if the given element is allowed to be preloaded at this time. | Ditto: I'd expect still a rejection reason here. Except that it should be a `AbortError`. |
@@ -278,7 +278,7 @@ def ship_delivery_group(request, order_pk, group_pk):
@staff_member_required
@permission_required('order.edit_order')
-def cancel_delivery_group(request, order_pk, group_pk):
+def delivery_group_cancel(request, order_pk, group_pk):
order = get_object_or_404(Order, pk=order_pk)
group = ... | [refund_payment->[create_history_entry,pgettext_lazy,gross,redirect,refund,RefundPaymentForm,success,is_valid,TemplateResponse,get_object_or_404],cancel_order->[atomic,create_history_entry,pgettext_lazy,TemplateResponse,cancel_order,redirect,success,is_valid,CancelOrderForm,get_object_or_404],order_details->[list,all,g... | Cancels a delivery group. | Why the weird naming? |
@@ -1,12 +1,13 @@
+import warnings
import torch
from functools import partial
from torch import nn, Tensor
-from torch.nn import functional as F
-from typing import Any, Callable, Dict, List, Optional, Sequence
+from typing import Any, Callable, List, Optional, Sequence
from .._internally_replaced_utils import ... | [SqueezeExcitation->[forward->[_scale]],mobilenet_v3_small->[_mobilenet_v3_model,_mobilenet_v3_conf],_mobilenet_v3_model->[MobileNetV3],_mobilenet_v3_conf->[adjust_channels],MobileNetV3->[forward->[_forward_impl]],mobilenet_v3_large->[_mobilenet_v3_model,_mobilenet_v3_conf]] | Creates a model for the . Initialize the object with the parameters for the . | We can try moving it to a separate place in a separate PR. |
@@ -81,7 +81,7 @@ public final class LogicalSchema {
.put(Type.ARRAY, LogicalSchema::validateArray)
.put(Type.MAP, LogicalSchema::validateMap)
.put(Type.STRUCT, LogicalSchema::validateStruct)
- .put(Type.BYTES, DecimalUtil::requireDecimal)
+ .put(Type.BYTES, SchemaUtil... | [LogicalSchema->[withoutMetaAndKeyFieldsInValue->[LogicalSchema],of->[LogicalSchema,of],withMetaAndKeyFieldsInValue->[LogicalSchema],withAlias->[LogicalSchema,of],withoutAlias->[LogicalSchema],equals->[equals],metaFieldNames->[metaFields],keyFieldNames->[keyFields],metaAndKeyFieldNames->[keyFieldNames,metaFieldNames],a... | Creates a logical schema for a given KSQL node. PUBLIC CONSTRUCTORS This constructor creates a new logical schema for the given relation. | This definitely feels wrong. The logical schema should _never_ have a BYTE field that is anything other than Decimal. |
@@ -242,6 +242,10 @@ func WaitContainer(w http.ResponseWriter, r *http.Request) {
// /{version}/containers/(name)/wait
exitCode, err := utils.WaitContainer(w, r)
if err != nil {
+ if errors.Cause(err) == define.ErrNoSuchCtr {
+ logrus.Warnf("container not found %q: %v", utils.GetName(r), err)
+ return
+ }
... | [Context,Value,StatusText,CreatedTime,InternalServerError,GetContainers,Warnf,Vars,WaitContainer,WorkingDir,Hostname,Signal,LogPath,Itoa,Error,Format,Marshal,Cause,New,GetName,RootFsSize,Errorf,RWSize,State,Wait,Labels,SplitN,ID,StopSignal,Wrapf,Join,Unix,RenameContainer,Kill,Name,Sort,User,WriteResponse,Entrypoint,Con... | ContainerNotFound handles requests for containers that are not running or cannot be killed. podToContainer converts a libpod. Container to a handlers. Container. | Is this necessary? Waiting on a container that has been removed by `--rm` will error now |
@@ -334,6 +334,17 @@ namespace System.Net.Sockets
}
}
+ private void ValidateDatagram(ReadOnlyMemory<byte> datagram, IPEndPoint? endPoint)
+ {
+ ThrowIfDisposed();
+
+ if (_active && endPoint != null)
+ {
+ // Do not allow sending pac... | [UdpClient->[Connect->[Connect,Close,IsAddressFamilyCompatible,CheckForBroadcast],GetEndpoint->[CheckForBroadcast,IsAddressFamilyCompatible],IAsyncResult->[CheckForBroadcast],JoinMulticastGroup->[JoinMulticastGroup],Send->[Send,IsAddressFamilyCompatible,CheckForBroadcast],EndSend->[EndSend],SendAsync->[CheckForBroadcas... | Private method for validating datagram. | The `datagram` argument is unused, note that this also makes the naming unfortunate. Since this particular overload has only one usage, it's cleaner to inline probably. |
@@ -54,6 +54,7 @@ public class Gateway extends GenericCli {
TracingUtil.initTracing("S3gateway", ozoneConfiguration);
OzoneConfigurationHolder.setConfiguration(ozoneConfiguration);
UserGroupInformation.setConfiguration(ozoneConfiguration);
+ checkSecurityAndSCMHAEnabled(ozoneConfiguration);
httpS... | [Gateway->[call->[S3GatewayHttpServer,createOzoneConfiguration,start,setConfiguration,initTracing],start->[info,startupShutdownMessage,start,toArray],main->[run],stop->[info,stop],getLogger]] | This method is called when the service is started. | S3G does not talk to SCM directly? We can skip the check here. |
@@ -907,6 +907,7 @@ static void _preset_retrieve_old_presets(dt_lib_module_t *self)
gchar *tx = _preset_retrieve_old_layout(list, fav);
dt_lib_presets_add(pname, self->plugin_name, self->version(), tx, strlen(tx), FALSE);
+ g_free(tx);
}
sqlite3_finalize(stmt);
| [No CFG could be retrieved] | finds all the modules that have a specific version DELETE FROM data. presets. | for some reason, freeing the string was crashing dt at some point. That's why I've not done that. But apparently this is no more the case :) maybe the problem was elsewhere (or something as changed in presets code) |
@@ -1325,7 +1325,7 @@ func (k *KubernetesConfig) IsDashboardEnabled() bool {
// IsIPMasqAgentEnabled checks if the ip-masq-agent addon is enabled
func (k *KubernetesConfig) IsIPMasqAgentEnabled() bool {
- return k.isAddonEnabled(IPMASQAgentAddonName, IPMasqAgentAddonEnabled)
+ return k.isAddonEnabled(IPMASQAgentAdd... | [GetCustomEnvironmentJSON->[IsAzureStackCloud],HasAvailabilityZones->[HasAvailabilityZones],GetUserAssignedID->[UserAssignedIDEnabled],IsMetricsServerEnabled->[isAddonEnabled],GetFirstConsecutiveStaticIPAddress->[IsVirtualMachineScaleSets],GetUserAssignedClientID->[UserAssignedClientIDEnabled],GetCustomCloudAuthenticat... | IsIPMasqAgentEnabled returns true if IPMasqAgent is enabled or. | This is the functional change that will no longer enable `ip-masq-agent` by default if `"networkPlugin"` is `"cilium"` |
@@ -41,6 +41,8 @@ class CriteriaController < ApplicationController
end
head :unprocessable_entity
end
+ @criterion.save!
+ @criterion.set_default_levels if params[:criterion_type] == 'RubricCriterion'
end
def edit
| [CriteriaController->[destroy->[destroy],update_positions->[update],create->[new],update->[create,update]]] | Creates a new object. | Don't do this here, move this to inside the `if` statement above. This eliminates the redundant save. |
@@ -187,13 +187,13 @@ func confirmBeforeUpdating(kind apitype.UpdateKind, stack Stack,
}
func PreviewThenPromptThenExecute(ctx context.Context, kind apitype.UpdateKind, stack Stack,
- op UpdateOperation, apply Applier) (engine.ResourceChanges, error) {
+ op UpdateOperation, apply Applier) (engine.ResourceChanges, *... | [Wrapf,Colorize,Sprintf,IgnoreError,TrimSpace,String,Errorf,Assert,AskOne,WriteString,RenderDiffEvent] | Prompt the user to select a specific cloud link and then proceed accordingly. if returns the id of the node that is not in the list of nodes. | if something changes to return a result it should try to properly folow the rules (i.e. use Bail when appropriate). otherwise, it will be difficult in the future to audit and verify that it's properly doing the right thing. |
@@ -93,7 +93,7 @@ mne.viz.set_3d_view(figure=fig, azimuth=45, elevation=60, distance=0.4,
# Fit dipoles on a subset of time points
with mne.use_coil_def(coil_def_fname):
- dip_opm, _ = mne.fit_dipole(evoked.copy().crop(0.015, 0.080),
+ dip_opm, _ = mne.fit_dipole(evoked.copy().crop(0.040, 0.080),
... | [plot_alignment,plot_locations,notch_filter,filter,argmax,join,make_inverse_operator,set_3d_view,dict,compute_covariance,read_forward_solution,convert_forward_solution,copy,read_raw_fif,use_coil_def,plot,print,find_events,data_path,read_bem_solution,average,apply_inverse,fit_dipole,Epochs,pick_types] | Plot the N20m dipole and the minimum - norm of the N20m. Create a plot of the source estimate of the . | why did you change this? |
@@ -373,10 +373,13 @@ get_spdk_log_page_completion(struct spdk_bdev_io *bdev_io, bool success,
bdev = spdk_bdev_desc_get_bdev(dev_health->bdh_desc);
D_ASSERT(bdev != NULL);
- /* Store device health info in in-memory health state log. */
+ /* Store Intel SMART stats in in-memory health state log. */
+ if (dev_heal... | [No CFG could be retrieved] | This function is called from the page completion handler for the nvme device. Submits an NVMe Admin command to get the controller data and if the device is. | How can this happen? we won't issue the command if vender id isn't intel, right? |
@@ -52,10 +52,13 @@ type distributorQuerier struct {
// Select implements storage.Querier interface.
// The bool passed is ignored because the series is always sorted.
func (q *distributorQuerier) Select(_ bool, sp *storage.SelectHints, matchers ...*labels.Matcher) (storage.SeriesSet, storage.Warnings, error) {
+ lo... | [Select->[Time,MetricsForLabelMatchers,streamingSelect,MetricsToSeriesSet,MatrixToSeriesSet,Query],LabelValues->[LabelValuesForLabelName,LabelName],LabelNames->[LabelNames],streamingSelect->[Time,ExtractOrgID,Sort,NewConcreteSeriesSet,FromLabelAdaptersToLabels,QueryStream,FromChunks],QueryableFunc] | Select selects series from the distributor. | This is almost the same as `Distributor.Query` (just saying, we can have both). |
@@ -536,11 +536,9 @@ class StepsController < ApplicationController
if attrs[:_destroy] == "1"
attr_params[pos] = {id: attrs[:id], _destroy: "1"}
params[key].delete(pos)
- else
- if has_destroy_params(params[key][pos])
- attr_params[pos] = {id: attrs[... | [StepsController->[destroy->[destroy],update->[create],create->[new,create],update_protocol_ts->[update],new->[new],toggle_step_state->[create],extract_destroy_params->[has_destroy_params,extract_destroy_params],checklistitem_state->[create]]] | extract destroy params from params and update params. | Space inside { missing.<br>Space inside } missing. |
@@ -18,7 +18,10 @@ class ChatChannelMembership < ApplicationRecord
ranking ["desc(channel_last_message_at)"]
end
- private
+ include Searchable
+ SEARCH_INDEX_WORKER = Search::ChatChannelMembershipEsIndexWorker
+ SEARCH_SERIALIZER = Search::ChatChannelMembershipSerializer
+ SEARCH_CLASS = Search::ChatCha... | [ChatChannelMembership->[channel_type->[channel_type],channel_image->[channel_type],channel_username->[channel_type],channel_modified_slug->[channel_type],channel_name->[channel_name,channel_type],channel_color->[channel_type]]] | Returns the last message in the channel or nil if no message exists. | I'd put this at the top, it's easier to see what modules a class includes right away |
@@ -535,13 +535,13 @@ public class CoderRegistry implements CoderProvider {
private Coder<?> coder;
private Type type;
- public IncompatibleCoderException(String message, Coder<?> coder, Type type) {
+ IncompatibleCoderException(String message, Coder<?> coder, Type type) {
super(message);
... | [CoderRegistry->[getDefaultOutputCoder->[getDefaultCoder],getTypeToCoderBindings->[getTypeToCoderBindings],getDefaultCoderFromFactory->[getDefaultCoder,getDefaultCoderFactory],getDefaultCoderFromAnnotation->[getCoder],registerCoder->[registerCoder],getDefaultCoders->[getDefaultCoders,getDefaultCoder],getDefaultCoder->[... | Creates a CoderException that can be thrown if the given type is not compatible with this Possible representations of the actual coder type. | This is fine, but redundant and IMO not quite best practice. It means that if one refactors the class to have a different access level, one also has to scrape through the methods and change them. |
@@ -16,9 +16,15 @@ if (isset($config['modules_compat']['rfc1628'][$device['os']]) && $config['modul
$volt_id = $split_oid[(count($split_oid) - 1)];
$volt_oid = "1.3.6.1.2.1.33.1.2.5.$volt_id";
$divisor = 10;
- if ($device['os'] == 'poweralert' ... | [No CFG could be retrieved] | - OsqnU - OsqnU - OsqnU - Osq Reads the network network parameters from the SNMP and returns the list of possible network phase objects. | shouldn't this be using newly generate function? just to standardize things? |
@@ -88,11 +88,11 @@ def get_client_token(**_):
return str(uuid.uuid4())
-def charge(
- payment: Payment,
- payment_token: str,
- amount: Decimal,
- **connection_params: Dict) -> Tuple[Transaction, str]:
+def process_payment(payment_information: Dict, **connection_params) -> Dict:
+ ... | [refund->[check_payment_supported,get_error_message_from_razorpay_error,_generate_transaction,get_client,clean_razorpay_response,refund],charge->[check_payment_supported,get_error_message_from_razorpay_error,_generate_transaction,get_client,clean_razorpay_response]] | Charge a authorized payment using the gateway. | I would put suggest to put `process_payment(...)` under `charge(...)` for better readability. The user that will read the code, won't know yet what is `charge(...)`, which forces them to look around for it. |
@@ -20,7 +20,8 @@ func Read() (*Config, error) {
var c *Config
// Read json file
- if raw, err := ioutil.ReadFile(configPath); err == nil {
+ p := configPath()
+ if raw, err := ioutil.ReadFile(p); err == nil {
err = json.Unmarshal(raw, &c)
if err != nil {
return nil, err
| [Write->[MarshalIndent,MkdirAll,WriteFile],Printf,Write,Join,Println,ReadFile,Unmarshal,NewV4,String,Getenv] | Read returns a Config object if it exists. If it doesn t exist it creates a new. | Also I just noticed looking at our `cmdutil` package that there's a way to read config files using it too. Not sure if that'll make things easier but it might. |
@@ -82,9 +82,7 @@ public enum CustomValidators {
DESCRIBE_FUNCTION(DescribeFunction.class, DescribeFunctionExecutor::execute),
DESCRIBE_CONNECTOR(DescribeConnector.class, new DescribeConnectorExecutor()::execute),
SET_PROPERTY(SetProperty.class, PropertyExecutor::set),
- UNSET_PROPERTY(UnsetProperty.class, Pr... | [validate->[validate],toMap,copyOf,requireNonNull,InsertValuesExecutor,collect,DescribeConnectorExecutor] | ENDPOINT for the PullQueryExecutor. Constructor for the class that implements the Statement interface. | It's nice having all the validators accessible from one place. The code in `TerminateQueryValidator` looks to match the code in your new validator class. Can we not your new validator class use this class and hence call `TerminateQueryValidator` still? |
@@ -518,7 +518,7 @@ var NgModelController = ['$scope', '$exceptionHandler', '$attrs', '$element', '$
// Check if the there's a parse error, so we don't unset it accidentially
var parserName = ctrl.$$parserName || 'parse';
- var parserValid = ctrl.$error[parserName] ? false : undefined;
+ var parserVal... | [No CFG could be retrieved] | Validates the given . This method is called when the user has entered a value that is not a valid . | This variable doesn't seem to be used now. What does this mean for the default of 'parse'? |
@@ -501,7 +501,9 @@ func (a *actuator) createOrUpdateSeedSecrets(ctx context.Context, spec *gardenco
*metav1.NewControllerRef(managedSeed, seedmanagementv1alpha1.SchemeGroupVersion.WithKind("ManagedSeed")),
}
secret.Type = corev1.SecretTypeOpaque
- secret.Data = data
+ secret.Data = map[string][]byte{
... | [deleteGardenlet->[Delete],deleteSeed->[Delete],deleteGardenNamespace->[Delete]] | createOrUpdateSeedSecrets creates or updates seed secrets based on the given seed spec. Initialize seed secret. | Unit tests should be updated as well after this change. |
@@ -128,14 +128,9 @@ func trimGitRemoteURL(url string, prefix string, suffix string) string {
return strings.TrimSuffix(strings.TrimPrefix(url, prefix), suffix)
}
-func parseColorization(debug bool, color string) (colors.Colorization, error) {
+func parseColorization(color string) (colors.Colorization, error) {
... | [Dir,Wrap,HasPrefix,Stack,IgnoreError,New,Diag,NewFilesystemRepository,Errorf,Remote,CurrentStack,CurrentBackends,Current,WalkUp,Base,Split,Config,Fprintf,TrimSuffix,TrimPrefix,Getwd,DetectPackageFrom,Load] | readPackage attempts to read a package from the current workspace. Determines the package path from the current working directory. | This is one place where the PR introduces new functionality. I assume we can live with just requiring the explicit --always or --never as desired. |
@@ -59,14 +59,15 @@ DH *DH_new_method(ENGINE *engine)
ret->meth = DH_get_default_method();
#ifndef OPENSSL_NO_ENGINE
ret->flags = ret->meth->flags; /* early default init */
- if (engine) {
+ if (engine && ENGINE_get_DH(engine)) {
if (!ENGINE_init(engine)) {
DHerr(DH_F_DH_NEW_METH... | [DH_set0_key->[BN_free],DH_new_method->[OPENSSL_zalloc,OPENSSL_free,init,ENGINE_init,ENGINE_get_DH,DHerr,CRYPTO_new_ex_data,ENGINE_get_default_DH,DH_free,DH_get_default_method,CRYPTO_THREAD_lock_new],DH_security_bits->[BN_security_bits,BN_num_bits],DH_set_method->[init,ENGINE_finish,finish],DH_set_ex_data->[CRYPTO_set_... | This function creates a new DH object from an existing engine. | I'm not familiar with the internal details of the engine framework but nevertheless this change looks conceptually wrong to me for two reasons: - A call into the engine (`ENGINE_get_DH()`) is made before calling `ENGINE_init()` - This check competes with the assignment and check of `ENGINE_get_DH()` in lines 72,73. If ... |
@@ -25,7 +25,7 @@ class CmdDestroy(CmdBase):
)
self.repo.destroy()
- except Exception: # noqa, pylint: disable=broad-except
+ except DvcException:
logger.exception("failed to destroy DVC")
return 1
return 0
| [CmdDestroy->[run->[confirm,DvcException,exception,destroy]],add_parser->[add_argument,add_parser,set_defaults,append_doc_link],getLogger] | Destroy a single . | Doing this just to unify the behavior among all of the commands. We'll also need to reconsider(probably remove) Captain Obvious messages like this one, but that's too out-of-scope for this PR. |
@@ -21,9 +21,10 @@ var (
// ServeOptions represent optional fields for serving.
type ServeOptions struct {
- Version *versionpb.Version
- MaxMsgSize int
- Cancel chan struct{}
+ Version *versionpb.Version
+ ClusterInfo *versionpb.ClusterInfo
+ MaxMsgSize int
+ Cancel chan struct{}
}
// ServeEnv... | [Printf,NewAPIServer,Listen,NewServer,MaxRecvMsgSize,MaxConcurrentStreams,KeepaliveEnforcementPolicy,MaxSendMsgSize,Sprintf,New,Close,RegisterAPIServer,Serve] | Serve is a wrapper for the standard Serve function. Serve the server and wait for the next request. | Can we just have the APIServer get the cluster ID out of etcd rather than passing it in? That seems a bit simpler and a bit more resilient in case we add a way to change the ID or something in the future. |
@@ -0,0 +1,16 @@
+<?php
+
+namespace Yoast\WP\SEO\Services\Health_Check;
+
+/**
+ * Interface for the health check runner. The abstract Health_Check uses this to run a health check.
+ */
+interface Runner_Interface {
+
+ /**
+ * Runs the health check.
+ *
+ * @return void
+ */
+ public function run();
+}
| [No CFG could be retrieved] | No Summary Found. | health check runner interface? |
@@ -122,6 +122,7 @@ namespace System.Diagnostics
{
get
{
+ CheckDisposed();
EnsureState(State.Associated);
return GetOrOpenProcessHandle();
}
| [Process->[WaitForInputIdle->[WaitForInputIdle],GetProcessesByName->[GetProcessesByName],EnsureState->[ThrowIfExited,EnsureState],WaitForExit->[RaiseOnExited,WaitForExit],Start->[Start,Close],StopWatchingForExit->[Dispose],RaiseOnExited->[OnExited],ToString->[ToString],Close->[Close,Dispose],GetProcesses->[GetProcesses... | Creates a new instance of the Process class. - Gets the base priority of the associated process. | This and other similar places did not throw exception at all before this change, and will throw exception now. It is a potential breaking change. |
@@ -245,6 +245,10 @@ func (eip *egressIPWatcher) deleteNamespaceEgress(vnid uint32) {
}
func (eip *egressIPWatcher) claimEgressIP(egressIP, egressHex string) error {
+ if egressIP == eip.localIP {
+ return fmt.Errorf("desired egress IP %q is the node IP", egressIP)
+ }
+
if eip.testModeChan != nil {
eip.testM... | [deleteNamespaceEgress->[UpdateNamespaceEgressRules,Lock,Unlock,Errorf],watchHostSubnets->[RESTClient,Network,RunEventQueue,updateNodeEgress],Start->[Forever],updateNodeEgress->[UpdateNamespaceEgressRules,Difference,Unlock,UnsortedList,Lock,Errorf,NewString,claimEgressIP,releaseEgressIP],watchNetNamespaces->[RESTClient... | claimEgressIP adds an egress IP to the local network interface. AddEgressIPRules adds an egress IP rule to the iptables system. | That means if the master is not also configured as a node, the master IP will still be able to set as egressIPs? |
@@ -130,8 +130,9 @@ public abstract class AbstractS3Processor extends AbstractAWSCredentialsProvider
public static final PropertyDescriptor ENCRYPTION_SERVICE = new PropertyDescriptor.Builder()
.name("encryption-service")
.displayName("Encryption Service")
- .description("Speci... | [AbstractS3Processor->[createClient->[createClient],createGrantees->[createGrantee],createACL->[createGrantees]]] | Creates a client using the specified credentials provider and client configuration. | Typo: "used _to_ configure requests. " |
@@ -1243,7 +1243,8 @@ def append_backward(loss,
p_g_list6 = fluid.backward.append_backward(loss=avg_loss, parameter_list=all_weights, no_grad_set=set(all_weights))
"""
- assert isinstance(loss, framework.Variable)
+ check_type(loss, 'loss', (framework.Variable),
+ 'fluid.backward... | [_find_op_path_->[_get_output_names,_some_in_set_],calc_gradient->[_find_op_path_,_get_no_grad_set_name,_append_backward_vars_,_create_op_desc_,_as_list,_get_stop_gradients_,_append_grad_suffix_,_rename_grad_,_append_backward_ops_],_append_backward_vars_->[_infer_var_data_type_shape_,_is_grad_var_,_find_parent_op_,_app... | This function appends a backward part of the n - node gradient operator to the main_program Pair of parameter and its corresponding gradients. missing - node - n - node Missing block - level error. desc_ - Append the op description of the missing node. | I think you can write `framework.Variable` or `(framework.Variable, )` instead of `(framework.Variable)` |
@@ -78,3 +78,14 @@ int PKCS8_pkey_add1_attr_by_NID(PKCS8_PRIV_KEY_INFO *p8, int nid, int type,
return 1;
return 0;
}
+
+int PKCS8_pkey_add1_attr_by_OBJ(PKCS8_PRIV_KEY_INFO *p8, const ASN1_OBJECT *obj, int type,
+ const unsigned char *bytes, int len)
+{
+ return (X509at_a... | [No CFG could be retrieved] | - 1 = 1 1 = 0 0 = 0. | oops - missing ';' - and same below |
@@ -70,7 +70,7 @@ public class StaticFieldsResource extends RestResource {
@ApiResponse(code = 400, message = "Missing or invalid configuration.")
})
public Response create(@ApiParam(title = "JSON body", required = true) String body,
- @ApiParam(title = "inputId", requir... | [StaticFieldsResource->[create->[error,find,write,build,info,checkPermission,Activity,addStaticField,getRunningInput,contains,isEmpty,validKey,getPersistId,WebApplicationException,readValue],delete->[error,find,write,build,info,checkPermission,removeStaticField,Activity,getRunningInput,isEmpty,getPersistId,remove,WebAp... | Creates a new static field in the node. Adds a static field to the input. | FQCN not required here. |
@@ -175,12 +175,13 @@ func (lto *TransferLeaderOperator) Check(region *metapb.Region, leader *metapb.P
return true, nil
}
+ log.Infof("balance [%s], try to transfer leader from %s to %s", region, leader, lto.oldLeader)
return false, nil
}
// Do implements Operator.Doop interface.
func (lto *TransferLeader... | [Check->[GetPeer,GetChangeType,New,Warnf,Trace,GetId],Do->[Check,Do,Trace],Enum] | Check implements the TransferLeaderOperator interface. | from `lto.oldLeader` to `leader` |
@@ -229,6 +229,7 @@ func NewCmdNewApplication(name, baseName string, f *clientcmd.Factory, in io.Rea
}
cmd.Flags().BoolVar(&config.AsTestDeployment, "as-test", config.AsTestDeployment, "If true create this application as a test deployment, which validates that the deployment succeeds and then scales down.")
+ cmd... | [RunNewApp->[PollImmediate,ShouldPrint,DefaultIndent,Fprintf,Infof,RunQuery,CreateMessage,Querying,Compact,Routes,WithMessage,V,Verbose,Errorf,Get,Run,PrintObject],CACert->[Errorf,ReadFile],Complete->[ClientConfig,Object,WarnAboutCommaSeparation,ClientMapperFunc,DiscoveryClient,CommandPath,VersionedPrintObject,ClientMa... | SuggestFor is a list of suggested commands to use for the application. p FOO = BAR to set or override a parameter value in the template. | Why not `--as-deployment` which would turn on the k8s deployments, seems shorter and generally you enable the flag, and not disable as with the current approach. |
@@ -42,10 +42,16 @@ const ProfileNav = ({
console.error(error)
return null
}
- if (!get(data, 'web3.primaryAccount')) {
+ const accountID = get(data, 'web3.primaryAccount.id')
+ if (!accountID) {
return null
}
+ // set the user for sentry
... | [No CFG could be retrieved] | The main function for the network Displays a hidden hidden element with a link to the hidden element in the menu. | I'd suggest to move this out of ~~this HOC~~ component. We could add a component (added to root inside App) that uses withWallet HOC and set the scope inside `useEffect` hook of that component. |
@@ -63,9 +63,7 @@ public final class ContentReader {
checkNotNull(uri);
checkNotNull(file);
- try (FileOutputStream os = new FileOutputStream(file)) {
- downloadAndApplyAction(
- uri, is -> os.getChannel().transferFrom(Channels.newChannel(is), 0L, Long.MAX_VALUE));
- }
+ downloadAndAp... | [ContentReader->[downloadToFile->[downloadAndApplyAction]]] | Download the file with the given uri. | @RoiEXLab are sure downloading multiple maps in parallel will have no issues? |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.