patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -17,7 +17,7 @@
# index_syobocal_alerts_on_sc_prog_item_id (sc_prog_item_id)
#
-class Syobocal::Alert < ActiveRecord::Base
+class Syobocal::Alert < ApplicationRecord
extend Enumerize
enumerize :kind, in: { special_program: 0 }, scope: true
| [new_special_program?->[blank?,find_by],enumerize,belongs_to,extend] | Creates a new SyobocalAlert object for a given sc_prog_item_id. | Use nested module/class definitions instead of compact style. |
@@ -112,6 +112,10 @@ public class KsqlContext {
return ksqlEngine.getLiveQueries();
}
+ public KsqlEngine getKsqlEngine() {
+ return ksqlEngine;
+ }
+
public void close() throws IOException {
ksqlEngine.close();
topicClient.close();
| [KsqlContext->[getMetaStore->[getMetaStore],close->[close],create->[KsqlContext,create]]] | This method returns a set of all running queries. | Do we want to expose this? i.e., it seems it is only required for the purpose of the test. |
@@ -187,9 +187,7 @@ export class ParallaxElement {
*/
shouldUpdate(viewport) {
const viewportRect = viewport.getRect();
- const elementRect = viewport.getLayoutRect(this.element_);
- elementRect.top -= viewportRect.top;
- elementRect.bottom = elementRect.top + elementRect.height;
+ const element... | [No CFG could be retrieved] | Creates a new base layer object. | Why is it ok to use `getBoundingClientRect` here? Could you help me understand the purpose of the rule that disallows it? |
@@ -109,6 +109,8 @@ final class SafeDatasetCommit implements Callable<Void> {
log.error(String.format("Failed to commit dataset state for dataset %s of job %s", this.datasetUrn,
this.jobContext.getJobId()), ioe);
throw new RuntimeException(ioe);
+ } catch (Throwable t) {
+ log.error("Er... | [SafeDatasetCommit->[setTaskFailureException->[setTaskFailureException],persistDatasetState->[persistDatasetState]]] | This method is called when a commit sequence is needed. This method is called when a publisher is thread - safe and is called from within a thread. | Better to have a more descriptive error message. Also, `RuntimeException` should be thrown here? |
@@ -56,6 +56,16 @@ public class KeyGeneratorOptions extends HoodieConfig {
.withDocumentation("Partition path field. Value to be used at the partitionPath component of HoodieKey. "
+ "Actual value ontained by invoking .toString()");
+ public static final ConfigProperty<String> KEYGENERATOR_CONSISTE... | [KeyGeneratorOptions->[key,withDocumentation,defaultValue]] | Config property for HoodieKey. Deprecated. Use the HIVE_STYLE_PARTITIONING_ENABLE property instead. | Can we add an example here so that users know what to expect if not for enabling this config. example covering both row writer and non-writer path. |
@@ -85,6 +85,11 @@ namespace Dynamo.PackageManager
get { return defaultPackagesDirectoryIndex != -1 ? packagesDirectories[defaultPackagesDirectoryIndex] : null; }
}
+ internal void SetPackagesDownloadDirectory(string downloadDirectory)
+ {
+ defaultPackagesDirectoryIndex... | [PackageLoader->[TryLoadPackageIntoLibrary->[OnRequestLoadNodeLibrary,OnRequestLoadCustomNodeDirectory,Add],DoCachedPackageUninstalls->[Add],Load->[TryLoadPackageIntoLibrary,OnPackagesLoaded],Add->[OnPackageAdded,Add],IsUnderPackageControl->[IsUnderPackageControl],LoadCustomNodesAndPackages->[LoadAll,Add],Remove->[OnPa... | Creates a new object that can be used to load a package. Check if a list of packages directories is available. | This does not work right now as I discovered that for some reason there is a mismatch in the `packagesDirectories` list maintained by the `PackageLoader` and the `CustomPackageFolders` held in the `PreferenceSettings`. For example, the former has the entry `C:\Users\pratapa\AppData\Roaming\Dynamo\Dynamo Core\2.12\packa... |
@@ -139,6 +139,7 @@ public final class SettingInputComponentFactory {
private static <T extends HasDefaults> SettingInputComponent<T> build(
JPanel componentPanel,
LabelDescription labelDescription,
+ final Optional<ValueRange> valueRange,
SwingComponentReaderWriter swingReaderWriter,
... | [SettingInputComponentFactory->[build->[setValue->[setText],getErrorMessage->[getText,getErrorMessage],updateSettings->[getText]]]] | Creates a new setting input component. | Optional params are a smell. Looks like can be potentially be fixed by representing `Optional.empty()` with a `ValueRange.ANY` object that will print out to an empty string. |
@@ -46,7 +46,7 @@ class BidirectionalAttentionFlowTest(ModelTestCase):
# `masked_softmax`...) have made this _very_ flaky...
@flaky(max_runs=5)
def test_model_can_train_save_and_load(self):
- self.ensure_model_can_train_save_and_load(self.param_file)
+ self.ensure_model_can_train_save_and_l... | [BidirectionalAttentionFlowTest->[test_forward_pass_runs_correctly->[forward,output_dict,arrays_to_variables,sum,as_array_dict,tuple,instances,get_metrics,isinstance,assert_almost_equal],test_model_can_train_save_and_load->[ensure_model_can_train_save_and_load],test_get_best_span->[numpy,assert_almost_equal,_get_best_s... | Ensures that the model can train and load the model with a . | Can you make this `tolerance=2e-5`, so it's more obvious what this magic number you're passing around is? |
@@ -40,8 +40,11 @@ func NewProvider(kubeConfig *rest.Config, namespaces []string, announcements *ch
kubeClient: kubeClient,
informers: &informerCollection,
caches: &cacheCollection,
- announcements: announcements,
- cacheSynced: make(chan interface{}),
+
+ // TODO(draychev): bridge announcem... | [Run->[Infoln,Infof,V,WaitForCacheSync,Info,Run],ListEndpointsForService->[Infof,IP,Port,Errorf,GetByKey],Informer,NewForConfigOrDie,WithNamespace,AddEventHandler,GetStore,Endpoints,V1,NewSharedInformerFactoryWithOptions,Core,Fatal,Run] | NewProvider creates a new endpoint. Provider for the given service ID. Get Endpoints for a given service on Kubernetes. | Why is a RingChannel still used for announcements? |
@@ -25,6 +25,7 @@ $tools = array(
'seo-tools/jetpack-seo-posts.php',
'simple-payments/simple-payments.php',
'verification-tools/verification-tools-utils.php',
+ 'calypso-redirects.php'
);
// Not every tool needs to be included if Jetpack is inactive and not in development mode
| [No CFG could be retrieved] | Load module code that is needed even when a module is not active. 5. 4. 0 can be used in multisite when Jetpack is not connected. | Maybe this should be placed a bit downer, behind the check for `if ( ! Jetpack::is_active() && ! Jetpack::is_development_mode() ) {` since Jetpack needs to be connected to WordPress.com for the Calypso redirects to make sense. |
@@ -128,7 +128,7 @@ namespace System.Net.NetworkInformation
/// <returns>The cached or new BsdNetworkInterface with the given name.</returns>
private static BsdNetworkInterface GetOrCreate(Dictionary<string, BsdNetworkInterface> interfaces, string name, int index)
{
- BsdNetworkInt... | [BsdNetworkInterface->[GetBsdNetworkInterfaces->[EnumerateInterfaceAddresses,Value,Clear,ProcessIpv4Address,Count,ProcessIpv6Address,GetOrCreate,InterfaceIndex,Add,ProcessLinkLayerAddress,net_PInvokeError],Up,Speed,Mtu,Unknown,InterfaceError,GetNativeIPInterfaceStatistics,InterfaceSupportsMulticast,InterfaceHasLink,net... | Get or create a network interface with the given name. | Unrelated to your change, but what does `oni` stand for here? |
@@ -118,6 +118,9 @@ class Openblas(MakefilePackage):
# See https://github.com/spack/spack/issues/19932#issuecomment-733452619
conflicts('%gcc@7.0.0:7.3.99,8.0.0:8.2.99', when='@0.3.11:')
+ # See https://github.com/xianyi/OpenBLAS/issues/3074
+ conflicts('%gcc@:10.1.99', when='@0.3.13 target=ppc64le:')... | [Openblas->[make_defs->[_microarch_target_args],_microarch_target_args->[_read_targets]]] | Patches for OpenBLAS - specific versions of the application. Property for reading an integer - based sequence number. | Just curious, what does the `:` in `target=ppc64le:` mean? `ppc64le` and supersets of that architecture? |
@@ -477,7 +477,6 @@ func (ex *deploymentExecutor) refresh(callerCtx context.Context, opts Options, p
}
// Make sure if there were any targets specified, that they all refer to existing resources.
- targetMapOpt := createTargetMap(opts.RefreshTargets)
if res := ex.checkTargets(opts.RefreshTargets, OpRefresh); re... | [retirePendingDeletes->[reportExecResult],importResources->[reportExecResult,importResources],Execute->[reportExecResult,checkTargets,reportError],refresh->[reportExecResult,checkTargets]] | refresh refreshes all resources in the previous deployment. | I could revert this, just moved it down 50 lines to where it was actually used while I was looking at this code a lot. |
@@ -193,7 +193,8 @@ export class FixedLayer {
* Adds the element directly into the fixed/sticky layer, bypassing discovery.
* @param {!Element} element
* @param {boolean=} opt_forceTransfer If set to true , then the element needs
- * to be forcefully transferred to the transfer layer.
+ * to be fo... | [No CFG could be retrieved] | Adds an element to the fixed or sticky layer. Remove an element from the fixed or sticky layer. | Mention when you'd use `addElement(el, false)` because that's subtle. |
@@ -22,7 +22,7 @@ OSSL_PROVIDER *OSSL_PROVIDER_try_load(OSSL_LIB_CTX *libctx, const char *name,
int isnew = 0;
/* Find it or create it */
- if ((prov = ossl_provider_find(libctx, name, 0)) == NULL) {
+ if ((prov = ossl_provider_find(libctx, name, 1)) == NULL) {
if ((prov = ossl_provider_new(l... | [OSSL_PROVIDER_add_builtin->[OPENSSL_strdup,memset,ossl_provider_info_clear,ossl_provider_info_add_to_store,ERR_raise],OSSL_PROVIDER_get_params->[ossl_provider_get_params],OSSL_PROVIDER_try_load->[ossl_provider_new,ossl_provider_free,ossl_provider_find,ossl_provider_add_to_store,ossl_provider_activate,ossl_provider_dea... | Ossl_PROVIDER_try_load - try to load OSSL_PROVIDER from lib. | I don't understand this change. This seems to set `noconfig` to true, i.e. don't load config - which seems contrary to the title of this PR |
@@ -56,6 +56,12 @@ func getParentTreeFields(treePath string) (treeNames []string, treePaths []strin
}
func editFile(ctx *context.Context, isNewFile bool) {
+ // Don't allow editing if the repo is archived
+ if ctx.Repo.Repository.IsArchived {
+ ctx.NotFound("", nil)
+ return
+ }
+
ctx.Data["PageIsEdit"] = true
... | [NumFiles,Status,Size,NotFoundOrServerError,Close,DeleteRepoFile,Redirect,CanCommitToBranch,RenderWithErr,PlainText,HTML,GetTreeEntryByPath,Error,Clean,UpdateRepoFile,DeleteUploadByUUID,NotFound,GetDiffPreview,Trace,HasError,JSON,NewUpload,TrimSpace,Tr,ServerError,Join,Data,Name,GetFilesChangedSinceCommit,IsTextFile,Is... | getParentTreeFields returns list of parent tree names and corresponding tree paths based on given tree No way to edit a directory online. | A middleware check isArichived is better I think. |
@@ -89,6 +89,13 @@ export class LightboxManager {
* @private {number}
*/
this.counter_ = 0;
+
+ /**
+ * If the lightbox group is a carousel, this object contains a
+ * mapping of the lightbox group id to the carousel element.
+ * @private {!Object<string, !Element>}
+ */
+ this.li... | [No CFG could be retrieved] | A class that manages lightboxing of carousels. Checks if an element has a lightboxable attribute and updates this. elements_ and returns. | This might need to be a `src/object.js#map` to speed up lookups. `map` is prototypeless so failed lookups happen faster. In the AMP codebase I see we generally prefer `map`s and `map[key]` notation vs `{}` literals and `hasOwnProperty`. |
@@ -1,6 +1,13 @@
from __future__ import print_function, division, absolute_import
from .typing.typeof import typeof
-from .parfor import prange
+import numpy as np
-__all__ = ['typeof', 'prange']
+def pndindex(*args):
+ return np.ndindex(*args)
+
+class prange(object):
+ def __new__(cls, *args):
+ re... | [No CFG could be retrieved] | This is a hack to avoid the import from the future. | Please add a docstring. |
@@ -258,11 +258,9 @@ def write_meas_info(fid, info, data_type=None):
start_block(fid, FIFF.FIFFB_MEAS_INFO)
# Blocks from the original
- blocks = [FIFF.FIFFB_SUBJECT, FIFF.FIFFB_HPI_MEAS, FIFF.FIFFB_HPI_RESULT,
+ blocks = [FIFF.FIFFB_SUBJECT, FIFF.FIFFB_HPI_MEAS,
FIFF.FIFFB_PROCESSING_H... | [read_meas_info->[int,read_ctf_comp,append,info,dir_tree_find,dict,read_tag,len,ValueError,inv,warn,read_proj,float,range,dot,read_bad_channels],write_meas_info->[write_name_list,copy_tree,write_coord_trans,write_float,start_block,fiff_open,end_block,write_proj,write_int,deepcopy,dir_tree_find,enumerate,write_ch_info,w... | This function writes the measurement info to a file descriptor. Writes the next n - block to file and returns None. end of block. | how about isotrack? since you removed it from below |
@@ -414,9 +414,9 @@ public class SingleNodeJdbcStoreIT {
public String getStoredKey(RemoteCache cache, String key) throws IOException, InterruptedException {
// 1. marshall the key
// 2. encode it with base64 (that's what DefaultTwoWayKey2StringMapper does)
- // 3. prefix it with 9 (again,... | [SingleNodeJdbcStoreIT->[createCache->[createCache]]] | Get the key stored in the cache. | Will it be possible to load data created by a previous version ? |
@@ -24,6 +24,9 @@ namespace System
// containing a startup hook, and call each hook in turn.
private static void ProcessStartupHooks()
{
+ if (!IsSupported)
+ return;
+
// Initialize tracing before any user code can be called.
System.Diagnos... | [StartupHookProvider->[ProcessStartupHooks->[AssemblyName,Path,AltDirectorySeparatorChar,Format,DirectorySeparatorChar,IsPathFullyQualified,Contains,Argument_InvalidStartupHookSimpleAssemblyName,IsNullOrEmpty,EndsWith,OrdinalIgnoreCase,Initialize,PathSeparator,CallStartupHook,GetData,Split,Length],CallStartupHook->[Pat... | Process startup hooks. Call all startup hooks that are not in turn on a . | I would structure this so that if someone specifies a startup hook (there's something actionable in STARTUP_HOOKS) and startup hook support was linked out, they get some sort of feedback about it (exception?). |
@@ -56,7 +56,9 @@ public abstract class PartitionAwareClusteringPlanStrategy<T extends HoodieRecor
* Return list of partition paths to be considered for clustering.
*/
protected List<String> filterPartitionPaths(List<String> partitionPaths) {
- return partitionPaths;
+ List<String> filteredPartitions =... | [PartitionAwareClusteringPlanStrategy->[generateClusteringPlan->[filterPartitionPaths]]] | Filters the partition paths and generates clustering plan. | We already get the partition info in replacecommit metadata. Is this log necessary? Let's make it a debug level log if necessary. |
@@ -182,6 +182,7 @@ public class PutHiveStreaming extends AbstractSessionFactoryProcessor {
+ "Please see the Hive documentation for more details.")
.required(false)
.addValidator(HiveUtils.createMultipleFilesExistValidator())
+ .expressionLanguageSupported(Expr... | [PutHiveStreaming->[setupHeartBeatTimer->[run->[setupHeartBeatTimer]],onHiveRecordsError->[ShouldRetryException,appendRecordsToFailure],makeHiveWriter->[makeHiveWriter],FunctionContext->[appendRecordsToSuccess->[appendAvroRecords],initAvroWriters->[initAvroWriter],appendRecordsToFailure->[appendAvroRecords]],onTrigger-... | Hive metastore is 9043. The partition columns. | I think we are missing some EL evaluation in the code where this property is used. (L428 for instance) |
@@ -73,6 +73,8 @@ namespace Dynamo.ViewModels
SetNumberFormatCommand = new DelegateCommand(SetNumberFormat, CanSetNumberFormat);
GetBranchVisualizationCommand = new DelegateCommand(GetBranchVisualization, CanGetBranchVisualization);
DumpLibraryToXmlCommand = new DelegateCommand(mo... | [DynamoViewModel->[InitializeDelegateCommands->[Copy,Paste,PostUIActivation,CanRunExpression,PublishNewPackage,PublishSelectedNodes,CanPublishSelectedNodes,DumpLibraryToXml,PublishCurrentWorkspace,CanPublishNewPackage,PublishCustomNode,CanDumpLibraryToXml,Log,CanPublishCustomNode,ToString,AddToSelection,CanPublishCurre... | Initialize the commands that are registered in the model. Delegate commands to the model Returns all commands that can be handled by the system. | I think you can remove both `CanShowGallery` and `CanCloseGallery`, simply use `() => true` here. Don't forget to remove the actual methods, too. |
@@ -44,13 +44,13 @@ public class DefaultMuleMessageBuilder<PAYLOAD, ATTRIBUTES extends Serializable>
private String id;
private String rootId;
private String correlationId;
- private int correlationSequence;
- private int correlationGroupSize;
+ private int correlationSequence = -1;
+ private... | [DefaultMuleMessageBuilder->[inboundProperties->[addInboundProperty],resolveDataType->[build],outboundProperties->[addOutboundProperty]]] | Create a builder for a message. Adds the outbound properties of the message to the map of outbound properties. | We use CaseInsensitiveHashMap in DefaultMuleMessage. We either need to continue to us this, or deprecate/remove it if the use of CaseInsensitiveMapWrapper is preferred. |
@@ -61,6 +61,8 @@ public final class DimensionHandlerUtils
public static final ColumnCapabilities DEFAULT_STRING_CAPABILITIES =
new ColumnCapabilitiesImpl().setType(ValueType.STRING)
.setDictionaryEncoded(true)
+ .setDictionaryValuesUnique(tr... | [DimensionHandlerUtils->[makeStrategy->[getEffectiveCapabilities],converterFromTypeToType->[convertObjectToType],makeVectorProcessor->[getEffectiveCapabilities,makeVectorProcessor],convertObjectToDouble->[convertObjectToDouble],convertObjectToType->[convertObjectToType,convertObjectToFloat,convertObjectToString,convert... | Get a DimensionHandler from the given capabilities and multi - value handling. | This doesn't seem right. The only place using `DEFAULT_STRING_CAPABILITIES` is `getEffectiveCapabilities` in this same file. And looking at the cases in that method, each one seems like it should behave a bit differently. So consider deleting this constant and having the `getEffectiveCapabilities` should be generating ... |
@@ -51,9 +51,6 @@ public class JsonFormatTest {
private TopicProducer topicProducer;
private TopicConsumer topicConsumer;
- private Map<String, GenericRow> inputData;
- private Map<String, RecordMetadata> inputRecordsMetadata;
-
@ClassRule
public static final EmbeddedSingleNodeKafkaCluster CLUSTER = new... | [JsonFormatTest->[terminateQuery->[terminateQuery]]] | Imports the package containing the JSON data and the necessary information. missing config map. | What do the changes in this test have to do with the ticket? |
@@ -104,6 +104,16 @@ class PipelineOptionsTest(unittest.TestCase):
'display_data': [
DisplayDataItemMatcher('mock_multi_option', ['op1', 'op2'])]
},
+ {'flags': ['--flink_master=testmaster:8081', '--parallelism=42'],
+ 'expected': {'flink_master': 'testmaster:8081',
+ ... | [PipelineOptionsTest->[test_value_provider_options->[UserOptions]]] | Create a mock options object that can be used to provide a display of the newly added flags This test checks that the pipeline options are in the correct order. | It feels odd to put flink-specific tests here. |
@@ -218,6 +218,7 @@ def test_strategy_override_process_only_new_candles(caplog, default_conf):
def test_strategy_override_order_types(caplog, default_conf):
caplog.set_level(logging.INFO)
+ # TODO-lev: Maybe change
order_types = {
'buy': 'market',
'sell': 'limit',
| [test_strategy_override_order_types->[log_has,set_level,update,load_strategy,raises],test_search_all_strategies_with_failed->[search_all_objects,Path,isinstance,len],test_load_strategy->[Path,advise_indicators,update,str,isinstance,load_strategy],test_strategy_override_process_only_new_candles->[log_has,set_level,updat... | Test that the default strategy overrides order - types. | Leverage is going to be a callback, not a configuration setting (`enable-leverage` might be - but i doubt we need that here as the logic for config/strategy overrides is well tested and identical for all settings). Having leverage a static (config) setting would not work - simply because "elsewhere" you're showing that... |
@@ -137,8 +137,7 @@ function prepareEntityForTemplates(entityWithConfig, generator) {
: entityWithConfig.entityStateName
);
- entityWithConfig.reactiveRepositories =
- entityWithConfig.reactive && ['mongodb', 'cassandra', 'couchbase', 'neo4j'].includes(entityWithConfig.databaseType);
+ ... | [No CFG could be retrieved] | Creates a list of all the properties that can be used to create the entity. read relationships from the object. | I think (but probably in another PR since this once is quite big) that we should kill this `reactiveRepositories` config parameter, since it's now equivalent to `reactive` |
@@ -160,7 +160,7 @@ func (c *clientImpl) WatchAll(namespaces Namespaces, labelSelector string, stopC
// GetIngresses returns all Ingresses for observed namespaces in the cluster.
func (c *clientImpl) GetIngresses() []*extensionsv1beta1.Ingress {
var result []*extensionsv1beta1.Ingress
- for ns, factory := range c.f... | [GetService->[Informer,GetStore,V1,Core,lookupNamespace,Services,GetByKey],GetIngresses->[Lister,List,Errorf,Extensions,V1beta1,Ingresses,Everything],GetSecret->[Informer,GetStore,Secrets,V1,Core,lookupNamespace,GetByKey],WatchAll->[Informer,AddEventHandler,Secrets,V1,Endpoints,Start,Core,String,NewFilteredSharedInform... | GetIngresses returns a list of all ingresses. | @timoreimann It looks odd to me to keep 2 factory instances at the same time in `clientImpl`. How do you think about setting `tweakListOptions` to nil for all resources including ingresses but filtering them by selector here? |
@@ -132,11 +132,17 @@ int SSL_SRP_CTX_init(struct ssl_st *s)
SSLerr(SSL_F_SSL_SRP_CTX_INIT, ERR_R_INTERNAL_ERROR);
goto err;
}
+ if ((ctx->srp_ctx.info != NULL) &&
+ ((s->srp_ctx.info = BUF_strdup(ctx->srp_ctx.info)) == NULL)) {
+ SSLerr(SSL_F_SSL_SRP_CTX_INIT, ERR_R_INTERNAL_ERR... | [SRP_Calc_A_param->[SRP_Calc_A,BN_bin2bn,OPENSSL_cleanse,RAND_bytes],SSL_CTX_set_srp_username_callback->[tls1_ctx_callback_ctrl],SSL_srp_server_param_with_username->[SRP_Calc_B,BN_bin2bn,OPENSSL_cleanse,RAND_bytes],srp_generate_client_master_secret->[SRP_Calc_x,SRP_Verify_B_mod_N,strlen,BN_bn2bin,SRP_Calc_client_key,BN... | Initializes the SRP context private static method to check if the SSL context has a missing SRP context. | We should probably also do a memset after all these frees to avoid any possibility of dangling references resulting in a double free. |
@@ -207,7 +207,8 @@ if ($action == 'valid' && $user->rights->facture->creer)
dol_htmloutput_errors($langs->trans("InvoiceIsAlreadyValidated", "TakePos"), null, 1);
}
} elseif (count($invoice->lines) == 0) {
- dol_syslog("Sale without lines");
+ $error++;
+ dol_syslog('Sale without lines', LOG_ERR);
dol_h... | [fetch,addPaymentToBank,update_price,create,getObjectsInCateg,fetch_object,addline,get_full_arbo,order,transcountry,getNomUrl,rollback,insert,getSellPrice,begin,sendToPrinter,load,getRemainToPay,containing,setPaymentMethods,fetch_array,loadLangs,update,setMulticurrencyCode,escape,delete,getFullName,fetch_optionals,text... | Creates an unique identifier for a facture. Validate invoice with stock change into warehouse defined into constant. | The LOG_ERR like LOG_WARNING must be used to report to developer of sysadmin there is an error into setup or a bug somewhere. A common use of Dolibarr should never trigger such error. My understanding is that this case can occurs just with a bad use of end user. In such a case, we should report an error on screen for u... |
@@ -244,7 +244,7 @@ final class DefaultChannelPipeline implements ChannelPipeline {
for (int i = size - 1; i >= 0; i --) {
ChannelHandler h = handlers[i];
- addFirst(group, generateName(h), h);
+ addFirst(group, null, h);
}
return this;
| [DefaultChannelPipeline->[fireChannelActive->[fireChannelActive],fireChannelRegistered->[fireChannelRegistered],destroyUp->[run->[destroyUp]],connect->[connect],write->[write],addAfter->[addAfter],remove->[remove],fireChannelReadComplete->[fireChannelReadComplete],close->[close],TailContext->[generateName0],destroyDown... | Add the given handlers to the pipeline in the order they were registered. | hard to see with the github diff but is the generateName handled somewhere else now when passed as null, or? |
@@ -145,7 +145,9 @@ public class DataSourceConfig implements MuleContextAware
private boolean isDynamicAttribute(String attribute)
{
- return !StringUtils.isEmpty(attribute) && muleContext.getExpressionManager().isValidExpression(attribute);
+ return !StringUtils.isEmpty(attribute)
+ && muleConte... | [DataSourceConfig->[hashCode->[hashCode],resolveAttribute->[isDynamicAttribute],resolve->[DataSourceConfig],equals->[equals]]] | Checks if the attribute is dynamic or not. | which exact cases are you trying to cover with this? If the attribute is an invalid expression, then it should actually fail, so that the user becomes aware of that and fixes it. This change will consider the value as not an expression, will not fail and the connector will not behave as expected. That situation will be... |
@@ -209,6 +209,9 @@ func (o *Operator) CheckTimeout() bool {
// Len returns the operator's steps count.
func (o *Operator) Len() int {
+ if o == nil {
+ return 0
+ }
return len(o.steps)
}
| [Check->[GetStartTime,CheckTimeout,IsEnd],ElapsedTime->[GetCreateTime],RunningTime->[HasStarted,GetStartTime],CheckSuccess->[Status],Status->[Status],CheckTimeout->[CheckSuccess,CheckTimeout],MarshalJSON->[String],ConfVerChanged->[ConfVerChanged],IsEnd->[IsEnd],String->[String],CheckExpired->[CheckExpired]] | Len returns the length of the operator. | When will this happen? I think better to update test to check nil. |
@@ -116,7 +116,12 @@ class Scaffold_Command extends WP_CLI_Command {
*/
function _s( $args, $assoc_args ) {
- $theme_slug = $args[0];
+ // Used for function prefixes, clean for safety.
+ $theme_slug = preg_replace('/[^a-zA-Z0-9\-]/', '', $args[0]);
+
+ if( empty( $theme_slug ) )
+ return false;
+
$theme... | [Scaffold_Command->[plugin->[create_file],plugin_tests->[copy,create_file,mkdir],post_type->[_scaffold],create_file->[put_contents,mkdir],child_theme->[create_file],taxonomy->[_scaffold],_scaffold->[extract_args,pluralize,get_textdomain,quote_comma_list_elements,create_file,get_output_path]]] | Creates a new theme. | Returning `false` will leave the user wondering what went wrong. You should use WP_CLI::error() instead. |
@@ -35,7 +35,7 @@ export default function UserMenu(props: AppNavBarPropsT) {
triggerType={TRIGGER_TYPE.click}
>
<Button overrides={{BaseButton: {component: StyledUserMenuButton}}}>
- <Avatar name={username} src={userImgUrl} size={'32px'} />
+ <Avatar name={username || ''} src={userImgUr... | [No CFG could be retrieved] | A component that displays a single unique identifier. | in the case where the username is `undefined`, do we want to have an empty string as the prop value? or should we remove the prop entirely? |
@@ -1423,6 +1423,7 @@ class Fleet(object):
auto_parallelizer = AutoParallelizer(self)
optimize_ops, params_grads, dist_startup_prog, dist_main_prog = auto_parallelizer.parallelize(
loss, startup_program, parameter_list, no_grad_set)
+
return optimize_ops, params_g... | [Fleet->[get_lr->[get_lr],step->[step],amp_init->[_get_amp_optimizer,amp_init],get_loss_scaling->[get_loss_scaling,_get_amp_optimizer],load_model->[load_model],state_dict->[state_dict],set_state_dict->[set_state_dict],distributed_model->[worker_num],clear_grad->[clear_grad],set_lr->[set_lr],minimize->[_get_applied_grap... | Minimizes a single node in the network. Compute the context of a single node in the network. Compile time - based n - node node. Minimize the on the main program. This function is called when the user has requested a . | this file has no change after reshard module merged. |
@@ -175,9 +175,8 @@ class WatermarkEvent(Event):
def to_runner_api(self, unused_element_coder):
tag = 'None' if self.tag is None else self.tag
- # Assert that no prevision is lost.
- assert 1000 * (
- self.new_watermark.micros // 1000) == self.new_watermark.micros
+ # Assert that no precision ... | [ReverseTestStream->[expand->[PairWithTiming]],_TimingEventGenerator->[on_timing_sampler->[WatermarkEvent,ProcessingTimeEvent],process->[WatermarkEvent,ProcessingTimeEvent]],ElementEvent->[to_runner_api->[Event]],WatermarkEvent->[to_runner_api->[Event]],TestStream->[add_elements->[ElementEvent,_add],to_runner_api_param... | Convert to a BeamRunner API protobuf. | can you do this for processing time events as well |
@@ -164,6 +164,9 @@ class PantsDaemon(ProcessManager):
self.shutdown(service_thread_map)
raise self.StartupFailure('service {} failed to start, shutting down!'.format(service))
+ # Once all services are strted, write our pid.
+ self.write_pid()
+
# Monitor services.
while not self.is... | [_LoggerStream->[fileno->[fileno]],PantsDaemon->[_close_fds->[flush,fileno],_run->[_setup_services,_setup_logging,_write_named_sockets,_run_services],pre_fork->[pre_fork],post_fork_child->[_run],_setup_logging->[shutdown,_close_fds,_LoggerStream],_run_services->[shutdown,RuntimeFailure,StartupFailure]]] | Run services in a separate thread. | started Also, does it make sense to wait until everything starts successfully before writing the PID? If you fail to start up, you'd still want to be killable. |
@@ -430,7 +430,17 @@ function createBaseAmpElementProto(win) {
if (this.isInTemplate_) {
return;
}
- this.implementation_ = new newImplClass(this);
+ this.tryUpgrade_(new newImplClass(this));
+ };
+
+ /**
+ * Completes the upgrade of the element with the provided implementation.
+ * @param ... | [No CFG could be retrieved] | Creates a new instance of the specified element. Get the priority of the element. | Should we be checking if we're already upgraded, too? |
@@ -64,7 +64,7 @@ class Article < ApplicationRecord
before_save :set_caches
before_save :fetch_video_duration
before_save :clean_data
- after_save :async_score_calc, if: :published
+ after_commit :async_score_calc, if: :published, unless: :destroyed?
after_save :bust_c... | [Article->[username->[username],update_notifications->[update_notifications],set_cached_object->[username],readable_edit_date->[edited?]]] | The url for a tag. Initialize the object with the necessary methods. | Can you really combine booleans like this? I think you might want to use a Proc here or possibly add a guard clause to the `async_score_calc` method below. |
@@ -705,7 +705,7 @@ namespace ProtoCore.DSASM
svThisPtr.metaData.type != Constants.kInvalidIndex)
{
int runtimeClassIndex = svThisPtr.metaData.type;
- ClassNode runtimeClass = core.ClassTable.ClassNodes[runtimeClassIndex];
+ ClassNode runtimeC... | [No CFG could be retrieved] | region Private methods This method is called from the main entry point of the interpreter. It is called by the. | I think the first character of property name is capital letter? |
@@ -131,7 +131,7 @@ static int lookup_cert_match(X509 **result, X509_STORE_CTX *ctx, X509 *x)
xtmp = NULL;
}
ret = xtmp != NULL;
- if (ret) {
+ if (ret && result != NULL) {
if (!X509_up_ref(xtmp))
ret = -1;
else
| [No CFG could be retrieved] | This function is used to find a match in the store. It is used to find a Verify a chain cert. | This change is not needed, or is not what you had in mind. The `result` output parameter (pointer) is never NULL, we'd have crashed at `*result = NULL` on line 119 if it were. |
@@ -144,6 +144,9 @@
<%_ if (protractorTests) { _%>
"ts-node": "8.10.2",
<%_ } _%>
+ <%_ if (cypressTests) { _%>
+ "cypress": "4.11.0",
+ <%_ } _%>
"tslint": "6.1.2",
"typescript": "3.9.5",
<%_ otherModules.forEach(module => { _%>
| [No CFG could be retrieved] | Return a list of packages that can be used to run the Jest Sonar reporter The version of the module that is not in the list of modules. | Is it the latest version? I ask because I think I saw yesterday a newer version when playing with the PR |
@@ -49,7 +49,7 @@ function buildArticleHTML(article) {
var profileUsername = article.user.username
var orgHeadline = "";
if (article.organization && !document.getElementById("organization-article-index")) {
- orgHeadline = '<div class="article-organization-headline"><a class="org-headline-filler" hr... | [No CFG could be retrieved] | This function returns an HTML string of the tag identifier. This function is used to generate a snippet that is not the first line in the body_. | This is implemented here and also in the server at `app/views/articles/_single_story.html.erb` and a similar card is rendered in notifications... `app/views/notifications/_article.html.erb` |
@@ -3,7 +3,6 @@
using System.Threading.Tasks;
using AcceptanceTesting;
using EndpointTemplates;
- using Features;
using NUnit.Framework;
public class When_sending_events_bestpractices_disabled_on_endpoint : NServiceBusAcceptanceTest
| [When_sending_events_bestpractices_disabled_on_endpoint->[Task->[Run],Endpoint->[Handler->[Task->[FromResult]],c]]] | Should_allow_sending_events - should be called when there is no endpoint started. | Perhaps shorten to: `When_sending_events_with_best_practices_disabled` ? |
@@ -712,7 +712,7 @@ class MainCoupledFemDem_Solution:
Elem = self.FEM_Solution.main_model_part.GetElement(Idelem)
self.PlotFilesElementsList[iElem] = open("PlotElement_" + str(Idelem) + ".txt","a")
- stress_tensor = Elem.GetValuesOnIntegrationPoints(KratosF... | [MainCoupledFemDem_Solution->[ExecuteBeforeGeneratingDEM->[ExpandWetNodes],GenerateDEM->[ComputeSkinSubModelPart],Initialize->[Initialize],InitializeSolutionStep->[InitializeSolutionStep],ExecuteAfterGeneratingDEM->[UpdateDEMVariables,ExtrapolatePressureLoad],Finalize->[Finalize],InitializeSolutionAfterRemeshing->[Init... | Prints the files that are part of the FEM project. This method calculates the total displacement and reaction values for all nodes in the model. This function prints the total displacement velocity and acceleration of the selected nodes. | @maceligueta you need to be aware of this. |
@@ -43,4 +43,16 @@ public class LivySparkRInterpreter extends BaseLivyInterprereter {
public String getSessionKind() {
return "sparkr";
}
+
+ @Override
+ protected String extractAppId() throws LivyException {
+ //TODO(zjffdu) depends on SparkR
+ return null;
+ }
+
+ @Override
+ protected String ex... | [No CFG could be retrieved] | Returns the session kind. | shouldn't it throw unsupported exception for now? |
@@ -63,5 +63,12 @@ public abstract class AbstractCursorStreamProviderAdapter implements CursorStrea
return creatorEvent;
}
+ /**
+ * @return the {@link ByteBufferManager} that <b>has</b> to be used to allocate byte buffers
+ */
+ protected ByteBufferManager getBufferManager() {
+ return bufferManager... | [AbstractCursorStreamProviderAdapter->[openCursor->[doOpenCursor,checkState,get],isClosed->[get],close->[set],AtomicBoolean]] | Returns the creator event for this cursor. | has to -> `must` to put more enphasis? |
@@ -25,6 +25,8 @@ class ContainerRegistryChallengePolicy(HTTPPolicy):
super(ContainerRegistryChallengePolicy, self).__init__()
self._credential = credential
self._exchange_client = ACRExchangeClient(endpoint, self._credential)
+ if self._credential is None:
+ self._exchange_... | [ContainerRegistryChallengePolicy->[send->[on_request,send]]] | Initializes the object. | Shouldn't this check move before line 28? Otherwise we are building the `ACRExchangeClient` for nothing? |
@@ -360,9 +360,13 @@ def launch_experiment(args, experiment_config, mode, config_file_name, experimen
module_name = AdvisorModuleName.get(package_name)
if package_name and module_name:
try:
- check_call([sys.executable, '-c', 'import %s'%(module_name)], stdout=PIPE, stderr=PIPE)
+ ... | [set_remote_config->[get_log_path,set_trial_config],set_experiment->[get_log_path],print_log_content->[get_log_path],get_nni_installation_path->[try_installation_path_sequentially->[_generate_installation_path],try_installation_path_sequentially],launch_experiment->[set_remote_config,set_experiment,print_log_content,st... | Launch the experiment. Set the n - node config and search space. This function sets the n - node config and starts the experiment. Add an experiment to the network. | why use `a+` rather than 'w'? |
@@ -955,9 +955,16 @@ void PurgeLocks(void)
return;
}
}
+ CloseLock(dbp);
Log(LOG_LEVEL_VERBOSE, "Looking for stale locks to purge");
+ dbp = OpenLock();
+ if(!dbp)
+ {
+ return;
+ }
+
if (!NewDBCursor(dbp, &dbcp))
{
CloseLock(dbp);
| [No CFG could be retrieved] | CopyLockDatabaseAtomically copies the database and all of its locks atomically. Reads the next non - zero index in the system s lock table. | Same. Not necessary. |
@@ -241,6 +241,9 @@ def save_inference_model(dirname,
"fetch_var_names": fetch_var_names
}, f, -1)
+ prepend_feed_ops(inference_program, feeded_var_names)
+ append_fetch_ops(inference_program, fetch_var_names)
+
# Save only programDesc of inference_program in binary format
# in a... | [get_parameter_value_by_name->[get_parameter_value],save_persistables->[save_vars],load_persistables_if_exist->[_is_presistable_and_exist_->[is_persistable],load_vars],load_vars->[_clone_var_in_block_,load_vars],load_inference_model->[load_persistables_if_exist],load_persistables->[load_vars],save_vars->[save_vars,_clo... | Save a model of a n - node model for inference. Writes the last unknown param to a file. | We can remove `Line 265 - 270` now, and change the implementation of `load_inference_model`. |
@@ -54,11 +54,6 @@ except ImportError:
from .slow_stream import get_varint_size
# pylint: enable=wrong-import-order, wrong-import-position, ungrouped-imports
-try:
- long # Python 2
-except NameError:
- long = int # Python 3
-
class CoderImpl(object):
"""For internal use only; no backwards-compati... | [PaneInfoCoderImpl->[estimate_size->[_choose_encoding],encode_to_stream->[_choose_encoding]],IntervalWindowCoderImpl->[decode_from_stream->[_to_normal_time],encode_to_stream->[_from_normal_time]],SequenceCoderImpl->[decode_from_stream->[decode_from_stream,_construct_from_sequence],estimate_size->[get_estimated_size_and... | Reads object from potentially - nested encoding in stream. | <!--new_thread; commit:cc2022157865d44e8dba070a766de78853c508bc; resolved:0--> I think we need to keep `long` for Python 2 compatibility. |
@@ -23,9 +23,14 @@ from ...annotations import Annotations, read_annotations
CAL = 1e-6
-def _check_fname(fname):
- """Check if the file extension is valid."""
- fmt = str(op.splitext(fname)[-1])
+def _check_fname(fname, dataname):
+ """Check whether the filename is valid.
+
+ Check if the file extensio... | [RawEEGLAB->[__init__->[_check_load_mat,_check_fname,_get_info]],EpochsEEGLAB->[__init__->[_check_load_mat,_check_fname,_get_info]],_get_eeg_montage_information->[_to_loc],_get_info->[_eeg_has_montage_information,_get_eeg_montage_information],_read_annotations_eeglab->[_bunchify,_check_load_mat]] | Check if the file extension is valid. | I would say yes. This was not captured by a test? if there is not file containing the data it should crash no? |
@@ -705,9 +705,6 @@ else
{
print load_fiche_titre($langs->trans("DoTestServerAvailability"));
- // If we use SSL/TLS
- if (! empty($conf->global->MAIN_MAIL_EMAIL_TLS) && function_exists('openssl_open')) $server='ssl://'.$server;
-
include_once DOL_DOCUMENT_ROOT.'/core/class/CMailFile.class.php';
$mail = ... | [textwithpicto,getValidAddress,remove_attached_files,transnoentities,selectyesno,get_attached_files,check_server_port,trans,sendfile,clear_attached_files,get_form,close,selectarray,load] | This function checks if the server is available on the server and if it is then sends the Show email send test form. | Why removing this ? |
@@ -820,7 +820,7 @@ function performBuild(watch) {
*/
function checkBinarySize(compiled) {
const file = compiled ? './dist/v0.js' : './dist/amp.js';
- const size = compiled ? '76.79KB' : '334.46KB';
+ const size = compiled ? '76.88KB' : '335.09KB';
const cmd = `npx bundlesize -f "${file}" -s "${size}"`;
l... | [No CFG could be retrieved] | Creates a single and runs the necessary tasks. Provides a function to handle the creation of a new build. | @jridgewell 1/1000 cut. |
@@ -412,12 +412,13 @@ class Cp2k(MakefilePackage, CudaPackage):
])
if '+elpa' in spec:
+ dso_suffix = 'a' if '%aocc' in spec else 'so'
elpa = spec['elpa']
elpa_suffix = '_openmp' if '+openmp' in elpa else ''
elpa_incdir = elpa.headers.directories... | [Cp2k->[install->[install_tree,join],makefile_architecture->[format],edit->[fflags->[format,join],satisfies,join,which,join_path,fflags,int,pkgconf,insert,extend,copy,KeyError,list,IOError,append,format,exists,open,write,str,ancestor,mkdirp],archive_files->[join],build->[set_env,InstallError,super,len],build_directory-... | Edit a sequence of blocks. Flags for missing missing - free - block chains. Finds all missing n - node modules and packages that are not in the library. extend self. compiler. stdcxx_libs with additional libraries. | We recommend use of Spack's `join_path` instead of `os.path.join`. I'm seeing only one use of the former in this package. Consistency would be nice. :) |
@@ -457,6 +457,17 @@ public final class SchemaBuilder {
return choice;
}
+ boolean isImported(MetadataType type) {
+ return importedTypes.stream()
+ .filter(t -> Objects.equals(getTypeId(t.getImportedType()), getTypeId(type)))
+ .findFirst()
+ .isPresent();
+ }
+
+ private String ge... | [SchemaBuilder->[addAttributeAndElement->[createAttribute],load->[load],createTopLevelElement->[createTopLevelElement],createValueAttribute->[createAttribute],registerConnectionProviderElement->[registerConnectionProviderElement],addTlsSupport->[importTlsNamespace],getParameterDeclarationVisitor->[visitObject->[default... | Create a reference type choice for a given type. | use `org.mule.runtime.module.extension.internal.util.MetadataTypeUtils#getId` instead |
@@ -375,6 +375,7 @@ class TypeChecker(NodeVisitor[Type]):
disallow_untyped_defs = False
# Should we check untyped function defs?
check_untyped_defs = False
+ is_typeshed_file = False
def __init__(self, errors: Errors, modules: Dict[str, MypyFile],
pyversion: Tuple[int, int] = ... | [TypeChecker->[visit_op_expr->[visit_op_expr],visit_operator_assignment_stmt->[accept,check_indexed_assignment],visit_unicode_expr->[visit_unicode_expr],visit_yield_from_expr->[accept,get_generator_return_type,get_generator_yield_type],visit_func_expr->[visit_func_expr],check_override->[erase_override],visit_ellipsis->... | Construct a type checker. | I'd rename this to is_typeshed_stub. |
@@ -0,0 +1,13 @@
+# typed: __STDLIB_INTERNAL
+# disable-fast-path: true
+
+class A # error: Type `Elem` declared by parent `Enumerable` must be re-declared in `A`
+# error: Missing definition for abstract method `Enumerable#each`
+ include Enumerable
+end
+
+class B < A # error: Missing definition for abstract method ... | [No CFG could be retrieved] | No Summary Found. | It is not clear to me what this does, or why this is required, but the LSP version of this test will fail if this line is not included. Guidance appreciated. |
@@ -217,7 +217,7 @@ public class CleanActionExecutor<T extends HoodieRecordPayload, I, K, O> extends
throw new HoodieIOException("Failed to clean up after commit", e);
} finally {
if (!skipLocking) {
- this.txnManager.endTransaction();
+ this.txnManager.endTransaction(Option.empty());
... | [CleanActionExecutor->[clean->[deleteFilesFunc],runClean->[clean],execute->[runPendingClean],deleteFilesFunc->[deleteFileAndGetResult]]] | Run the clean operation. Returns the last uncleaned cleaner metadata if any. | can we try to set current trxn at L209. last trxn can be empty. |
@@ -416,10 +416,12 @@ public class HoodieDeltaStreamer implements Serializable {
jssc.setLocalProperty("spark.scheduler.pool", SchedulerConfGenerator.DELTASYNC_POOL_NAME);
}
try {
+ int iteration = 1;
while (!isShutdownRequested()) {
try {
lon... | [HoodieDeltaStreamer->[DeltaSyncService->[startService->[isAsyncCompactionEnabled],onInitializingWriteClient->[isAsyncCompactionEnabled],close->[close],getConfig],main->[sync,Config]]] | Start the delta - sync service. | sorry, I don't quite get why we need to set table name here? Next line will in turn rely on the arg passed for tablename. So, don't really understand why we need static fix (i.e. setTableName). From the diff, I see that cfg.tableName is set passed into DeltaSync.syncOnce(tblName) and HoodieDeltaStreamerMetrics(HoodieWr... |
@@ -501,7 +501,10 @@ export class AmpConsent extends AMP.BaseElement {
) {
this.updateCacheIfNotNull_(
response['consentStateValue'],
- response['consentString'] || undefined
+ response['consentString'] || undefined,
+ response['gdprApplies'] !== undefined
+ ... | [AmpConsent->[handleAction_->[DISMISS,ACCEPTED,ACCEPT,dev,isEnumValue,REJECTED,DISMISSED,REJECT],initialize_->[expandPolicyConfig,all,keys,dict,toggle,registerConsentInstance,ownersForDoc,length,getServicePromiseForDoc],enableInteractions_->[DISMISS,ACCEPT,REJECT],enableExternalInteractions_->[DISMISS,source,user,getDa... | syncRemoteConsentState_ - Sync consent state from remote server. | @zhouyx , We've talked about this before, but I think another thing to consider is that there is no way to tell if the `gdprApplies` signal was sent from CMP or vendor or if it was defaulted to `consentRequired`. I.e. the case when user is in California, but `gdprApplies` is not provided in `checkConsentHref`, so then ... |
@@ -686,9 +686,8 @@ export class Resources {
if (this.documentReady_ && this.firstPassAfterDocumentReady_) {
this.firstPassAfterDocumentReady_ = false;
- this.viewer_.postDocumentReady(this.viewport_.getSize().width,
- this.win.document.body./*OK*/scrollHeight);
- this.updateScrollHeight_... | [No CFG could be retrieved] | Schedules the work pass at the latest with the specified delay. Checks if a given has mutates. | This might, indeed, be not needed. But it does change our behavior, no? |
@@ -116,8 +116,8 @@ class PexEntryPointField(StringField, AsyncFieldMixin, SecondaryOwnerMixin):
help = (
"The entry point for the binary, i.e. what gets run when executing `./my_binary.pex`.\n\n"
"You can specify a full module like 'path.to.module' and 'path.to.module:func', or use a "
- ... | [PythonRequirementsField->[compute_value->[format_invalid_requirement_string_error]]] | A class that represents a binary with the given entry point. Return a dict with the includes and the pex entry_point. | The fewer spaces are important so that Readme.com doesn't interpret this as a code block. |
@@ -192,6 +192,8 @@ type invokeOptions struct {
Parent Resource
// Provider is an optional provider resource to use for this invoke.
Provider ProviderResource
+ // URN is an optional URN of a previously-registered resource of this type to read from the engine for this invoke.
+ URN string
// Version is an optio... | [applyResourceOption,TypeOf,getPackage] | returns the current state of the given object. | Why is this needed on `invokeOptions`? |
@@ -1277,11 +1277,10 @@ class NewSemanticAnalyzer(NodeVisitor[None],
base_types = [] # type: List[Instance]
info = defn.info
+ info.tuple_type = None
for base, base_expr in bases:
if isinstance(base, TupleType):
- # There may be an existing valid tuple ty... | [names_modified_in_lvalue->[names_modified_in_lvalue],NewSemanticAnalyzer->[analyze_comp_for->[analyze_lvalue],refresh_top_level->[add_implicit_module_attrs],name_not_defined->[is_incomplete_namespace,add_fixture_note,record_incomplete_ref,lookup_fully_qualified_or_none],check_classvar->[is_self_member_ref],visit_lambd... | Configures the base classes. Missing base type. | This change was needed to get existing tests passing. |
@@ -200,6 +200,10 @@ size_t rand_drbg_get_entropy(RAND_DRBG *drbg,
}
err:
+ /* we need to reset drbg->pool in the error case */
+ if (ret == 0 && drbg->pool != NULL)
+ drbg->pool = NULL;
+
rand_pool_free(pool);
return ret;
}
| [No CFG could be retrieved] | Get random bits from the system entropy pool. Implementation of the get_nonce function. | Aehm, sorry but there **must** be a better solution than this. |
@@ -461,7 +461,9 @@ const files = {
'spec/helpers/_mock-login.service.ts',
'spec/helpers/_mock-event-manager.service.ts',
'spec/helpers/_mock-active-modal.service.ts',
- 'spec/helpers/_mock-state-storage.service.ts'
+ 'spec/helpers/_mock-s... | [No CFG could be retrieved] | The authentication type - specific tests. Tests for missing components. | unfortunately this file is being removed in another PR #6951, so you may want to remove the test as well |
@@ -113,17 +113,13 @@ async def mypy_lint(
),
)
- address_references = ", ".join(sorted(tgt.address.spec for tgt in transitive_targets.closure))
process = pex.create_process(
python_setup=python_setup,
subprocess_encoding_environment=subprocess_encoding_environment,
pe... | [generate_args->[append,tuple,extend],rules->[SubsystemRule,UnionRule,rules],mypy_lint->[get_entry_point,get_requirement_specs,PathGlobs,LintResults,join,FileContent,PexRequirements,MergeDigests,MultiGet,Addresses,PexInterpreterConstraints,from_fallible_process_result,PexRequest,len,sorted,Targets,generate_args,InputFi... | Lint a missing missing key. Get a from the FallibleProcess. | This was never right. We don't actually run on the whole transitive closure because we were filtering out non-Python and non-resource targets, e.g. skipping `jvm_library` targets. I tried finding a way to accurately calculate the number of targets and gave up because it's complicated by codegen. So, we only report the ... |
@@ -144,9 +144,17 @@ public interface Tree {
CASE_GROUP(CaseGroupTree.class),
/**
+ * case with colon: case <expression-list> :
* {@link CaseLabelTree}
*/
- CASE_LABEL(CaseLabelTree.class),
+ CASE_LABEL_COLON(CaseLabelTree.class),
+
+ /**
+ * java 12 case with arrow: case <expre... | [No CFG could be retrieved] | Replies the properties of a node which is not part of a block. Replies the next node in the tree which is an object literal. | Like mentioned earlier, I would keep only one CASE_LABEL kind and rely on a boolean. |
@@ -3,7 +3,7 @@ import { ajax } from "discourse/lib/ajax";
export default DiscourseRoute.extend({
model() {
- return ajax("/admin/reports").then(json => json);
+ return ajax("/admin/reports");
},
setupController(controller, model) {
| [No CFG could be retrieved] | Default route for a single . | Huh that is pretty pointless isn't it! |
@@ -885,7 +885,7 @@ class TorchRankerAgent(TorchAgent):
'--encode-candidate-vecs True.'
)
- def _make_candidate_encs(self, vecs, path):
+ def _make_candidate_encs(self, vecs):
"""
Encode candidates from candidate vectors.
| [TorchRankerAgent->[eval_step->[score_candidates],train_step->[_get_train_preds,score_candidates,_get_batch_train_metrics],_make_candidate_encs->[encode_candidates]]] | Encode the given candidates into a list of Candidates. | was the purpose of `path` to be able to save the encodings and reload them? |
@@ -187,8 +187,14 @@ class CI_Form_validation {
return $this;
}
+ // Convert an array of rules to a string
+ if (is_array($rules))
+ {
+ $rules = implode('|', $rules);
+ }
+
// No fields? Nothing to do...
- if ( ! is_string($field) OR ! is_string($rules) OR $field === '')
+ if ( ! is_string($field) ... | [CI_Form_validation->[set_rules->[set_rules],_execute->[_execute],strip_image_tags->[strip_image_tags],xss_clean->[xss_clean],valid_emails->[valid_email],run->[set_rules],set_checkbox->[set_radio],valid_ip->[valid_ip],prep_for_form->[prep_for_form],_reduce_array->[_reduce_array]]] | Set the rules for a given field Build the master array. | Why is this needed, when you've already converted the array to a string? |
@@ -11,10 +11,10 @@ class TestScope(unittest.TestCase):
tensor = var.get_tensor()
- tensor.set_dims([1000, 784])
+ tensor.set_dims([100, 84])
tensor.alloc_int(place)
tensor_array = numpy.array(tensor)
- self.assertEqual((1000, 784), tensor_array.shape)
+ self.a... | [TestScope->[test_int_tensor->[set_dims,CPUPlace,Scope,assertEqual,new_var,alloc_int,get_tensor,set,array],test_float_tensor->[set_dims,CPUPlace,Scope,assertAlmostEqual,assertEqual,new_var,set,get_tensor,alloc_float,array]],main] | Test int tensor. | Can you try three configurations -- [7, 0], [0, 7], [7,13] -- 7 and 13 are just small prime numbers. Prime numbers are reasonable becaue they are not power of 2 or any way defactorizable. 0 is a good boundary case. |
@@ -866,6 +866,7 @@ export function installHistoryServiceForDoc(ampdoc) {
registerServiceBuilderForDoc(
ampdoc,
'history',
- /* opt_constructor */ undefined,
- ampdoc => createHistory(ampdoc));
+ function(ampdoc) {
+ return createHistory(ampdoc);
+ });
}
| [No CFG could be retrieved] | Register a service builder for the given ampdoc. | Can't this be just `registerServiceBuilderForDoc(..., createHistory)`? Why reclosure the function with same args? |
@@ -0,0 +1,8 @@
+<div class="content">
+ <p class="title ff-accent fs-l fw-bold">About the Speaker</p>
+ <p class="body">
+ Vaidehi Joshi is a senior engineer at DEV, where she builds community and helps improve the software careers of millions. She enjoys building and breaking code, but loves creating empathetic ... | [No CFG could be retrieved] | No Summary Found. | Do we perhaps want to add this page to `.gitignore` so changes to it don't get written to Github? I like the idea of having a sample page in source control, but I'm concerned about constant updates to it. Perhaps something like `sample_application.yml` (we tell users to copy that to `application.yml`, and that file is ... |
@@ -742,6 +742,12 @@ def non_trivial_bases(info: TypeInfo) -> List[TypeInfo]:
if base.fullname() != 'builtins.object']
+def user_bases(info: TypeInfo) -> List[TypeInfo]:
+ # TODO: skip everything from typeshed?
+ return [base for base in info.mro[1:]
+ if base.module_name not in ('buil... | [dump_all_dependencies->[get_dependencies],DependencyVisitor->[visit_member_expr->[process_global_ref_expr],add_attribute_dependency->[add_dependency],add_attribute_dependency_for_expr->[add_attribute_dependency],add_iter_dependency->[add_attribute_dependency],visit_for_stmt->[process_lvalue],add_operator_method_depend... | Generate dependencies for all interesting modules and print them to stdout. | Since the return is only used as a boolean, maybe rename this to `has_user_bases` and return a bool? This would be a bit simpler and faster. |
@@ -249,7 +249,13 @@ int32_t ESP8266WiFiGenericClass::channel(void) {
* @param type sleep_type_t
* @return bool
*/
-bool ESP8266WiFiGenericClass::setSleepMode(WiFiSleepType_t type) {
+bool ESP8266WiFiGenericClass::setSleepMode(WiFiSleepType_t type, int listenInterval) {
+ if (listenInterval >= 0 && listenInter... | [No CFG could be retrieved] | private helper functions get WiFi sleep mode. | LitenInterval should be uint8_t for consistency. The range check is then not needed. |
@@ -190,13 +190,13 @@ public class Model {
public static class MParameter {
final String name;
- final String description;
final String type;
+ final String description;
- public MParameter(String name, String description, String type) {
+ public MParameter(String name, String ... | [Model->[Component->[hasDependenciesOrLifecycle->[hasLifecycle,isEmpty],hasLifecycle->[isEmpty]]]] | Creates a new object that represents a managed operation. | I preferred changing the order here (to also match the order in its sister JmxOperationParameter) rather than fixing the call site. |
@@ -346,7 +346,7 @@ double WalletManagerImpl::miningHashRate() const
cryptonote::COMMAND_RPC_MINING_STATUS::response mres;
epee::net_utils::http::http_simple_client http_client;
- if (!epee::net_utils::invoke_http_json_remote_command2(m_daemonAddress + "/getinfo", mreq, mres, http_client))
+ if (!epee... | [No CFG could be retrieved] | This function returns the latest version of the wallet manager. This method is used to get the hard fork info. | Was this just the wrong RPC call? |
@@ -1,7 +1,7 @@
import logging
import os
import shutil
-from typing import Optional
+from typing import Optional, List # pylint: disable=unused-import
import torch
from torch.nn.utils.clip_grad import clip_grad_norm
| [Trainer->[train->[train],from_params->[Trainer]]] | Construct a object. Number of training epochs. | Man, every time I see this it makes me want to switch to python 3.6, so we can just put the variable types inline and remove all of these `disable=unused-import` statements. Not for this PR, though... |
@@ -150,10 +150,15 @@ public class InterpreterRestApi {
@PUT
@Path("setting/restart/{settingId}")
@ZeppelinApi
- public Response restartSetting(@PathParam("settingId") String settingId) {
- logger.info("Restart interpreterSetting {}", settingId);
+ public Response restartSetting(String message, @PathParam... | [InterpreterRestApi->[addRepository->[addRepository],removeRepository->[removeRepository]]] | Restarts the interpreter setting with the given id. | If `noteId` is null, does it have any action? I think null valued of `noteId` should return error. |
@@ -106,7 +106,7 @@ namespace System.Net.Sockets
//
private static readonly IntPtr MaxHandles = IntPtr.Size == 4 ? (IntPtr)int.MaxValue : (IntPtr)long.MaxValue;
#endif
- private static readonly IntPtr MinHandlesForAdditionalEngine = s_engineCount == 1 ? MaxHandles : (IntPtr)32;
+ privat... | [No CFG could be retrieved] | Magic number of handles that can be allocated for a particular event port and a handle value. Private helper methods for handling a single handle. | We could remove this. And if it isn't removed, do we want to set this to `1` when the `DOTNET_SYSTEM_NET_SOCKETS_THREAD_COUNT` is set? |
@@ -1382,7 +1382,7 @@ namespace DotNetNuke.Entities.Urls
Guid parentTraceId)
{
string scheme = result.Scheme;
- if (absoluteUri.ToLower().StartsWith(scheme))
+ if (absoluteUri.ToLowerInvariant().StartsWith(scheme))
... | [RewriteController->[CheckTabPath->[CheckSpecialCase],GetTabFromDictionary->[CheckTabPath,ReplaceDefaultPage,SetRewriteParameters,RewriteParametersFromModuleProvider,CheckLanguageMatch,CleanExtension,CheckIfPortalAlias],IdentifyByRegEx->[AddQueryStringToRewritePath,SetRewriteParameters],IsExcludedFromFriendlyUrls->[IsA... | This method is called from the main method of the main method. It identifies the culture. | Please use `String#StartsWith(String, StringComparison)` |
@@ -509,12 +509,13 @@ public class NewestSegmentFirstIterator implements CompactionSegmentIterator
private QueueEntry(List<DataSegment> segments)
{
Preconditions.checkArgument(segments != null && !segments.isEmpty());
- Collections.sort(segments);
+ final List<DataSegment> segmentsToSort = ne... | [NewestSegmentFirstIterator->[CompactibleTimelineObjectHolderCursor->[isCompactibleHolder->[next,hasNext]],QueueEntry->[getDataSource->[getDataSource]],next->[hasNext],findSegmentsToCompact->[needsCompaction,next,hasNext],SegmentsToCompact->[isEmpty->[isEmpty]]]] | Get the data source of the first segment. | Does the order of the segments matter? Why not just calculate the min start and max end with O(n) implementation by looping over `segments` |
@@ -195,6 +195,16 @@ namespace Microsoft.Extensions.Logging.Generators
Diag(DiagnosticDescriptors.RedundantQualifierInMessage, ma.GetLocation(), method.Identifier.ToString());
}
+ try
+ ... | [LoggerMessageGenerator->[LoggerMethod->[OrdinalIgnoreCase,Empty],LoggerParameter->[Empty],LoggerClass->[Empty],Parser->[ExtractTemplates->[Add,IsNullOrEmpty,FindIndexOfAny,Substring,Length,FindBraceIndex],GetLogClasses->[ReturnsVoid,Message,StartsWith,MultipleLoggerFields,ShouldntMentionLogLevelInMessage,Array,LoggerF... | Returns a list of LoggerClasses that are available in the specified classes. Checks if a method has a missing attribute or if it s a static or partial attribute. Checks if a node in the stack is missing a node in the method or if it is Diagnostics if a parameter name is missing from the local parameter map. | What do you think about making it a `TryParse` method, and not using exceptions for control flow? |
@@ -41,8 +41,6 @@ public interface MuleConfiguration
boolean isCacheMessageAsBytes();
- boolean isCacheMessageOriginalPayload();
-
boolean isEnableStreaming();
boolean isValidateExpressions();
| [No CFG could be retrieved] | Returns true if the message is a cache message. | Should not remove also this method? |
@@ -59,7 +59,7 @@ class TableClient(TableClientBase):
account URL already has a SAS token, or the connection string already has shared
access key values. The value can be a SAS token string, an account shared access
key, or an instance of a TokenCredentials class from azure.identi... | [TableClient->[update_entity->[update_entity],delete_entity->[delete_entity],upsert_entity->[update_entity]]] | Create a TableClient from a sequence of Azure Storage keys. | We don't support TokenCredential yet, right? |
@@ -133,7 +133,16 @@ class PriceParser
public function parseExpression($product, $expression, $values)
{
global $user;
-
+ global $hookmanager;
+ $hookmanager->initHooks(array('productcard','globalcard'));
+ $action = 'PARSEEXPRESSION';
+ if ($result = $hookmanager->execut... | [PriceParser->[parseProduct->[parseExpression],testExpression->[parseExpression],parseProductSupplier->[parseExpression]]] | Parse a single node of type Checks if there is a missing variable in the expression and if so fills it with the values - 4 - 4 - 5 - 5 - 4 - 5 - 5 - 4 - 5. | I don't think we should initialize the context of the hook here. parseExpression can be called at any place in a lot of other context. What if you remove this line completely ? |
@@ -294,6 +294,7 @@ public class StringDimensionMergerV9 implements DimensionMergerV9<int[]>
try (
Closeable toCloseEncodedValueWriter = encodedValueWriter;
Closeable toCloseBitmapWriter = bitmapWriter;
+ Closeable toCloseDictionaryMergeIterator = dictionaryMergeIterator;
Closeabl... | [StringDimensionMergerV9->[toIndexSeekers->[IndexSeekerWithConversion,size,get,IndexSeekerWithoutConversion],ConvertingIndexedInts->[size->[size],get->[get],iterator->[nextInt->[nextInt,get],skip->[skip],hasNext->[hasNext],iterator]],writeIndexes->[close]]] | Writes all the indexes to the output directory. no - op if no data in the dictionary. | Do we need to wait until here to close the iterator? Could it be closed in `writeMergedValueMetadata`? |
@@ -141,9 +141,9 @@ namespace Content.Server.GameObjects.Components.Power
switch (LightBulb.State)
{
case LightBulbState.Normal:
- device.Load = Load;
if (device.Powered)
{
+ device.Load = Load... | [PoweredLightComponent->[Initialize->[Initialize],UpdateLight->[UpdateLight]]] | Updates the light state based on the current state of the bulb. | I'm pretty sure this change is gonna re-introduce the bug where lights go strobe light mode when running out of power. Why are you changing it? |
@@ -81,6 +81,11 @@ func newIngesterMetrics(r prometheus.Registerer) *ingesterMetrics {
// A small number of chunks per series - 10*(8^(7-1)) = 2.6m.
Buckets: prometheus.ExponentialBuckets(10, 8, 7),
}),
+ cleanupDuration: prometheus.NewHistogram(prometheus.HistogramOpts{
+ Name: "cortex_ingester_cleanu... | [LabelNames->[LabelNames],ShutdownHandler->[Shutdown],LabelValues->[LabelValues],RegisterFlags->[RegisterFlags],Shutdown->[Shutdown]] | Collector for ingested samples. - > Config for an Ingester. | Maybe we could convert it into a metric to track the duration of 1 single TSDB offload operation? Two reasons: 1. Right now the duration depends on how many TSDBs are closed in a single cleanup operation 2. From the UX, it's not much clear what "cleanup" really does |
@@ -867,7 +867,7 @@ func TestAccAWSS3Bucket_Logging(t *testing.T) {
})
}
-func TestAccAWSS3Bucket_Lifecycle(t *testing.T) {
+func TestAccAWSS3Bucket_LifecycleBasic(t *testing.T) {
rInt := acctest.RandInt()
resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { testAccPreCheck(t) },
| [ParallelTest,HeadBucket,GetBucketPolicy,GetBucketReplication,DeepEqual,Slice,GetBucketLogging,HasPrefix,NonRetryableError,Code,TestCheckNoResourceAttr,Quote,RandInt,RootModule,ComposeTestCheckFunc,Errorf,MustCompile,RetryableError,GetBucketRequestPayment,ListBuckets,Join,TestMatchResourceAttr,DeleteBucketCors,Repeat,F... | TestAccAWSS3Bucket_Logging tests the on AWS S3 bucket. Tests if the resource attributes are defined in the lifecycle rule. | Note for reviewers: this allows to target this acceptance test without also matching the `TestAccAWSS3Bucket_LifecycleExpireMarkerOnly` test. |
@@ -909,6 +909,9 @@ NativeCodeGenerator::CodeGen(PageAllocator * pageAllocator, CodeGenWorkItem* wor
Js::Throw::OutOfMemory();
case VBSERR_OutOfStack:
throw Js::StackOverflowException();
+ case E_ACCESSDENIED:
+ // OOP JIT TODO: if server side can't handle request an... | [No CFG could be retrieved] | The function that jits out is the entry point of the function. This method is called when the code generation process starts. | wonder if we want to assert against this or even throw fatal error? i think it should only happen in case this process is already dead |
@@ -29,6 +29,8 @@ public class NodeInfo {
private Map<String, String> cheatWitnessInfoMap = new HashMap<>();
+ private String totalProcessTxTime;
+
public long getBeginSyncNum() {
return beginSyncNum;
}
| [NodeInfo->[transferToProtoEntity->[setPassiveConnectCount,getTotalFlow,setBeginSyncNum,getActiveConnectCount,setConfigNodeInfo,setSolidityBlock,getPassiveConnectCount,getCurrentConnectCount,getConfigNodeInfo,getSolidityBlock,setTotalFlow,setBlock,setMachineInfo,getBlock,getPeerList,getBeginSyncNum,getMachineInfo,getCh... | Get the begin sync number. | This field is not required |
@@ -6,6 +6,12 @@ import (
"sync"
"time"
+ "github.com/prometheus/client_golang/prometheus/promauto"
+
+ "github.com/pkg/errors"
+
+ "github.com/prometheus/client_golang/prometheus"
+
"github.com/go-kit/kit/log/level"
"github.com/prometheus/common/model"
"github.com/prometheus/prometheus/pkg/labels"
| [GetPendingTombstonesForInterval->[GetPendingTombstones]] | Purges a list of all the pending delete requests for a user and keeps checking for changes reloadTombstones reloads tombstones for all the users in the system. | Why are we spacing out the imports here? |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.