patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -553,6 +553,9 @@ class Command(object):
if args.graph:
self._outputer.info_graph(args.graph, deps_graph, get_cwd())
+ elif args.json:
+ json_arg = True if args.json == "1" else args.json
+ self._outputer.json_info(deps_graph, json_arg, get_cwd())
else:
self._outputer.info(deps_graph, only, args.package_filter, args.paths)
| [Command->[export->[export],info->[info],install->[install],source->[source],remove->[remove,info],new->[new],imports->[imports],link->[link],upload->[upload],copy->[copy],download->[download],run->[_commands,_warn_python2,_show_help],export_pkg->[export_pkg],test->[test],inspect->[inspect],package->[package],_show_help->[check_all_commands_listed],create->[create],build->[build]],main->[Command,run]] | Gets information about a specific . This function is called from the command line interface. It will return the information about a specific Builds a single object. conan source method. | Make it compatible to use `graph` and `json` outputs? Raise an error if both are requested? |
@@ -562,7 +562,9 @@ class GDriveTree(BaseTree):
self.gdrive_delete_file(item_id)
def get_file_hash(self, path_info):
- raise NotImplementedError
+ item_id = self._get_item_id(path_info)
+ file_repr = self._drive.CreateFile({"id": item_id})
+ return HashInfo(self.PARAM_CHECKSUM, file_repr["md5Checksum"])
def _upload(
self, from_file, to_info, name=None, no_progress_bar=False, **_kwargs
| [GDriveTree->[_upload->[_get_item_id,_gdrive_upload_file],_create_dir->[_cache_path_id,_ids_cache,_gdrive_create_dir],_get_remote_item_ids->[_gdrive_list],_drive->[_validate_credentials,GDriveAuthError],exists->[_get_item_id],walk_files->[_list_paths],_gdrive_list->[_gdrive_retry],remove->[_get_item_id,gdrive_delete_file],_list_paths->[_gdrive_list,_ids_cache],_download->[_get_item_id,_gdrive_download_file],_get_cached_item_ids->[_ids_cache],_get_item_id->[_path_to_item_ids],_path_to_item_ids->[_get_remote_item_ids,_create_dir,_path_to_item_ids,_get_cached_item_ids]]] | Returns a function that uploads a file to the Gdrive drive. | btw, what happens if item_id represents a directory? |
@@ -405,6 +405,8 @@ Field.prototype.activate = function(docname) {
function DataField() { } DataField.prototype = new Field();
DataField.prototype.make_input = function() {
+ wn.require('/lib/js/lib/imask.js');
+
var me = this;
this.input = $a_input(this.input_area, this.df.fieldtype=='Password' ? 'password' : 'text');
| [No CFG could be retrieved] | Field for grids set_value - get_value - set_input - set_input. | If you need it everywhere just add it to public/build.json |
@@ -359,11 +359,9 @@ module.exports = class gateio extends Exchange {
parseOrder (order, market = undefined) {
let id = this.safeString (order, 'orderNumber');
let symbol = undefined;
- if (typeof market === 'undefined') {
- let marketId = this.safeString (order, 'currencyPair');
- if (marketId in this.markets_by_id) {
- market = this.markets_by_id[marketId];
- }
+ let marketId = this.safeString (order, 'currencyPair');
+ if (marketId in this.markets_by_id) {
+ market = this.markets_by_id[marketId];
}
if (typeof market !== 'undefined')
symbol = market['symbol'];
| [No CFG could be retrieved] | fetchOrder - fetch order details for a given order number currency pair Parse the order status response. | Just wondering, did you encounter a problem with it? |
@@ -83,6 +83,7 @@ namespace System
buffer[startingIndex] = (char)(packedResult >> 8);
}
+ [MethodImpl(MethodImplOptions.AggressiveInlining)]
public static void EncodeToUtf16(ReadOnlySpan<byte> bytes, Span<char> chars, Casing casing = Casing.Upper)
{
Debug.Assert(chars.Length >= bytes.Length * 2);
| [HexConverter->[ToString->[ToString,EncodeToUtf16,ToCharsBuffer],IsHexChar->[FromChar],EncodeToUtf16->[ToCharsBuffer],TryDecodeFromUtf16->[TryDecodeFromUtf16]]] | ToCharsBuffer - Encode chars in UTF - 16 buffer. | Was this not getting inlined already? I wonder why |
@@ -438,7 +438,7 @@ public abstract class BaseLivyInterprereter extends Interpreter {
|| response.getStatusCode().value() == 201) {
return response.getBody();
} else if (response.getStatusCode().value() == 404) {
- if (response.getBody().matches("Session '\\d+' not found.")) {
+ if (response.getBody().matches("\"Session '\\d+' not found.\"")) {
throw new SessionNotFoundException(response.getBody());
} else {
throw new APINotFoundException("No rest api found for " + targetURL +
| [BaseLivyInterprereter->[createSession->[getSessionInfo],CreateSessionRequest->[toJson->[toJson]],isSessionExpired->[getSessionInfo],LivyVersionResponse->[fromJson->[fromJson]],StatementInfo->[fromJson->[fromJson],StatementOutput->[toJson->[toJson]]],initLivySession->[getSessionKind],callRestAPI->[callRestAPI,getRestTemplate],ExecuteRequest->[toJson->[toJson]],SessionInfo->[fromJson->[fromJson]],closeSession->[callRestAPI],interpret->[initLivySession,interpret]]] | Call the REST API with the given parameters. Checks if the response string contains a . If it is it returns the response string. | add the missing quotation here. |
@@ -16,7 +16,7 @@ public class EpollAvailabilityTest extends AbstractInfinispanTest {
public void testEpollNotAvailable() throws Exception {
Thread testThread = Thread.currentThread();
- StringLogAppender logAppender = new StringLogAppender(EPOLL_AVAILABLE_CLASS,
+ StringLogAppender logAppender = new StringLogAppender("org.infinispan.HOTROD",
Level.TRACE,
t -> t == testThread,
PatternLayout.newBuilder().withPattern(LOG_FORMAT).build());
| [EpollAvailabilityTest->[testEpollNotAvailable->[install,StringLogAppender,assertTrue,CherryPickClassLoader,build,currentThread,forName,getLog,contains,uninstall,getClassLoader]]] | Test if Epoll is not available. | Trying to sneak in a test failure fix I see :D |
@@ -92,6 +92,17 @@ const mode = {
GEO_OVERRIDE: 2, // We've been overriden in test by #amp-geo=xx
};
+/**
+ * @typedef {{
+ * ISOCountry: string,
+ * matchedISOCountryGroups: !Array<string>,
+ * allISOCountryGroups: !Array<string>,
+ * isInCountryGroup: GEO_IN_GROUP,
+ * ISOCountryGroups: !Array<string>
+ * }}
+ */
+export const GeoDef = {};
+
export class AmpGeo extends AMP.BaseElement {
/** @param {!AmpElement} element */
| [No CFG could be retrieved] | Creates an AMP - Geo object from a given AMP element. Adds a to the body. | Who is importing the `GeoDef` here? |
@@ -84,6 +84,9 @@ func run(evm *EVM, contract *Contract, input []byte, readOnly bool) ([]byte, err
}
}
+ if p, ok := precompilesRW[*contract.CodeAddr]; ok {
+ return RunPrecompiledContractRW(p, evm, contract, input, readOnly)
+ }
return RunPrecompiledContract(p, input, contract)
}
}
| [create->[SetCodeOptionalHash,SetNonce,IsEIP155,Now,CanTransfer,Transfer,UseGas,CaptureEnd,IsS3,CaptureStart,Address,Since,CreateAccount,RevertToSnapshot,SetCode,ChainConfig,GetCodeHash,GetNonce,Snapshot],Cancelled->[LoadInt32],Create->[Address,GetNonce,create,CreateAddress],Hash->[Keccak256Hash],StaticCall->[RevertToSnapshot,GetCode,GetCodeHash,AddBalance,Snapshot,SetCallCode,UseGas],Cancel->[StoreInt32],CallCode->[RevertToSnapshot,GetCode,GetCodeHash,CanTransfer,Address,Snapshot,SetCallCode,UseGas],Call->[Now,Exist,CanTransfer,Transfer,UseGas,GetCode,CaptureEnd,IsS3,CaptureStart,Address,Since,CreateAccount,RevertToSnapshot,Sign,SetCallCode,ChainConfig,IsValidator,GetCodeHash,Snapshot],Create2->[create,Hash,BigToHash,Address,Bytes,CreateAddress2],DelegateCall->[RevertToSnapshot,GetCode,GetCodeHash,AsDelegate,Address,Snapshot,SetCallCode,UseGas],GetVRF,Uint64,Cmp,CanRun,IsS3,IsDataCopyFixEpoch,NewInt,SetBytes,Keccak256Hash,Bytes,Sub,ChainConfig,Run,Rules] | Run the contract program if the current block is in S3. type provides the context of the n - th object. | Should VRF be better in another non-r/w precompiles? (Just asking. This change shall not be done in this pr) |
@@ -12,13 +12,16 @@ class Paraview(CMakePackage):
visualization application."""
homepage = 'http://www.paraview.org'
- url = "http://www.paraview.org/files/v5.3/ParaView-v5.3.0.tar.gz"
- _urlfmt = 'http://www.paraview.org/files/v{0}/ParaView-v{1}{2}.tar.gz'
+ url = "http://www.paraview.org/files/v5.6/ParaView-v5.6.2.tar.xz"
+ list_url = "http://www.paraview.org/files"
+ list_depth = 1
+ _urlfmt = 'http://www.paraview.org/files/v{0}/ParaView-v{1}{2}.tar.xz'
git = "https://gitlab.kitware.com/paraview/paraview.git"
maintainers = ['chuckatkins', 'danlipsa']
version('develop', branch='master', submodules=True)
+ version('5.6.2', sha256='1f3710b77c58a46891808dbe23dc59a1259d9c6b7bb123aaaeaa6ddf2be882ea')
version('5.6.0', sha256='cb8c4d752ad9805c74b4a08f8ae6e83402c3f11e38b274dba171b99bb6ac2460')
version('5.5.2', '7eb93c31a1e5deb7098c3b4275e53a4a')
version('5.5.1', 'a7d92a45837b67c3371006cc45163277')
| [Paraview->[cmake_args->[nvariant_bool->[variant_bool],nvariant_bool,variant_bool]]] | Creates a new object. Get a list of all possible packages. | Bumping to `5.6.2` it seems will require a more complex url handler since there was a shift from `tar.gz` to `tar.xz`. Just changing the url like this breaks downloads for anything before `5.5.x` when the `tar.xz` became available and breaks the checksums for everything before `5.6.2` since they were based on the `tar.gz` |
@@ -122,11 +122,11 @@ class MockLogger(object):
@pytest.mark.parametrize(
("location", "trusted", "expected"),
[
- ("http://pypi.python.org/something", [], True),
- ("https://pypi.python.org/something", [], False),
- ("git+http://pypi.python.org/something", [], True),
- ("git+https://pypi.python.org/something", [], False),
- ("git+ssh://git@pypi.python.org/something", [], False),
+ ("http://pypi.org/something", [], True),
+ ("https://pypi.org/something", [], False),
+ ("git+http://pypi.org/something", [], True),
+ ("git+https://pypi.org/something", [], False),
+ ("git+ssh://git@pypi.org/something", [], False),
("http://localhost", [], False),
("http://127.0.0.1", [], False),
("http://example.com/something/", [], True),
| [test_base_url->[HTMLPage],TestLink->[test_splitext->[Link],test_ext_query->[Link],test_filename->[Link],test_is_wheel_false->[Link],test_is_wheel->[Link],test_ext->[Link],test_fragments->[Link],test_ext_fragment->[Link],test_no_ext->[Link],parametrize],test_sort_locations_file_not_find_link->[_sort_locations,PipSession,PackageFinder,index_url],test_secure_origin->[MockLogger,PackageFinder,_validate_secure_origin],test_sort_locations_file_expand_dir->[_sort_locations,PipSession,PackageFinder],test_sort_locations_non_existing_path->[_sort_locations,PipSession,PackageFinder,join],parametrize] | A mock logger that logs a warning on the first call to the package finder. | These are dummy URLs, in the sense that we don't fetch from them (after all, we also use example.com). While I understand you probably just got them by search and replace, is this change necessary? |
@@ -2,6 +2,15 @@ package io.quarkus.deployment.builditem;
import io.quarkus.builder.item.MultiBuildItem;
+/**
+ * All timezones are now included in native executables by default so this build item does not change the build behavior
+ * anymore.
+ * <p>
+ * Keeping it around for now as it marks the extension requiring all the timezones
+ * and better wait for the situation to fully settle on the GraalVM side
+ * before removing it entirely.
+ */
+@Deprecated
public final class NativeImageEnableAllTimeZonesBuildItem extends MultiBuildItem {
}
| [No CFG could be retrieved] | This class is used to enable all time zones for NativeImage. | Maybe mark it with `@Deprecated`? |
@@ -36,6 +36,7 @@ import swinglib.JPanelBuilder;
public enum ErrorMessage {
INSTANCE;
+ private static final String DEFAULT_LOGGER = "";
private final JFrame windowReference = new JFrame("TripleA Error");
private final JLabel errorMessage = JLabelBuilder.builder().errorIcon().iconTextGap(10).build();
private final AtomicBoolean isVisible = new AtomicBoolean(false);
| [windowClosing->[hide],hide->[set,setVisible],show->[setText,textToHtml,getMessage,invokeLater,compareAndSet,nullToEmpty,setLocationRelativeTo,setVisible,pack],enable->[isHeadless,checkState],addWindowListener,setModalExclusionType,AtomicBoolean,build,WindowAdapter,JFrame,setAlwaysOnTop,add] | Creates a window with a message of type ErrorMessage which can be used to show an EDT Horizontal glue. | I find it weird to have a constant variable for an empty string, but ok. |
@@ -138,8 +138,10 @@ def log_package_built(pref, duration, log_run=None):
def log_client_rest_api_call(url, method, duration, headers):
headers = copy.copy(headers)
- headers["Authorization"] = MASKED_FIELD
- headers["X-Client-Anonymous-Id"] = MASKED_FIELD
+ if "Authorization" in headers:
+ headers["Authorization"] = MASKED_FIELD
+ if "X-Client-Anonymous-Id" in headers:
+ headers["X-Client-Anonymous-Id"] = MASKED_FIELD
if "signature=" in url:
url = url.split("signature=")[0] + "signature=%s" % MASKED_FIELD
_append_action("REST_API_CALL", {"method": method, "url": url,
| [log_command->[_append_action],log_exception->[_append_action],log_recipe_sources_download->[_append_action,_file_document],log_recipe_got_from_local_cache->[_append_action],log_recipe_download->[_append_action,_file_document],log_download->[_append_action],log_client_rest_api_call->[_append_action],log_package_built->[_append_action],_append_action->[_validate_action,_append_to_log],log_uncompressed_file->[_append_action],log_compressed_files->[_append_action,_file_document],log_package_upload->[_append_action,_file_document],log_package_download->[_append_action,_file_document],log_package_got_from_local_cache->[_append_action],log_recipe_upload->[_append_action,_file_document],_append_to_log->[_get_tracer_file]] | Log a REST_API_CALL action. | This is what I was talking about the other day |
@@ -156,12 +156,13 @@ feature 'Two Factor Authentication' do
scenario 'allows a user to continue typing even if a number is invalid', :js do
sign_in_before_2fa
- select 'United States of America +1', from: 'International code'
+ find('.selected-flag').click
+ find('.country[data-country-code="us"]:not(.preferred)').click
input = find('#user_phone_form_phone')
input.send_keys('12345678901234567890')
- expect(input.value).to eq('+1 2345678901234567890')
+ expect(input.value).to eq('+1 12345678901234567890')
end
end
end
| [submit_2fa_setup_form_with_empty_string_phone->[fill_in],attempt_to_bypass_2fa_setup->[visit],submit_prefilled_otp_code->[t,click_button],submit_2fa_setup_form_with_invalid_phone->[fill_in],attempt_to_bypass_2fa->[visit],submit_2fa_setup_form_with_valid_phone_and_choose_phone_call_delivery->[fill_in,choose],visit,email,password,create,minute,find,let,phone,to_not,describe,build_stubbed,feature,have_current_path,check,it,travel,contact_url,freeze,to,have_content,sign_in_before_2fa,click_button,click_link,scenario,select,t,require,fingerprint,click,login_two_factor_path,include,to_i,signin,have_link,update,times,sign_in_user,generate_totp_code,receive,now,privacy_url,length,click_on,choose,fill_in,call,context,value,have_received,build,help_url,not_to,send_keys,eq,find_by,direct_otp,and_return,minutes] | If we have a node with a 2FA setup we can bypass it. | Can we encapsulate this logic in a method that takes the country to select and performs the finding and clicking? This can be located in the same file for now, but at some point we may want it shared if we have to access it for other phone number change related tests. |
@@ -32,7 +32,8 @@ export class ElementStub extends BaseElement {
const name = element.tagName.toLowerCase();
if (!loadingChecked[name]) {
loadingChecked[name] = true;
- extensionsFor(this.win).loadExtension(name, /* stubElement */ false);
+ extensionsFor(this.win).loadExtension(
+ name, /* default version */ null, /* stubElement */ false);
}
stubbedElements.push(this);
}
| [No CFG could be retrieved] | Creates a subclass of BaseElement that implements the standard logic for handling the n - ary tag Private functions - functions - functions. | undefined instead of null? |
@@ -314,7 +314,8 @@ public abstract class IngestionTestBase extends InitializedNullHandlingTest
);
final TaskToolbox box = new TaskToolbox(
- new TaskConfig(null, null, null, null, null, false, null, null, null, false, false),
+ new TaskConfig(null, null, null, null, null, false, null, null, null, false, false,
+ TaskConfig.BatchProcessingMode.CLOSED_SEGMENTS.name()),
new DruidNode("druid/middlemanager", "localhost", false, 8091, null, true, false),
taskActionClient,
null,
| [IngestionTestBase->[getRowIngestionMetersFactory->[getRowIngestionMetersFactory],TestLocalTaskActionClient->[submit->[submit],createTaskActionToolbox],TestTaskRunner->[getPublishedSegments->[getPublishedSegments],run->[createActionClient,run,getIndexMerger,getRowIngestionMetersFactory,getIndexIO,getTaskActionClient]]]] | Runs a task in the background. | nit: should this use default instead of this explicit value? |
@@ -12,6 +12,9 @@ class PyPybtexDocutils(PythonPackage):
homepage = "https://pypi.python.org/pypi/pybtex-docutils/"
url = "https://pypi.io/packages/source/p/pybtex-docutils/pybtex-docutils-0.2.1.tar.gz"
+ import_modules = ['pybtex_docutils']
+
+ version('0.2.2', sha256='ea90935da188a0f4de2fe6b32930e185c33a0e306154322ccc12e519ebb5fa7d')
version('0.2.1', sha256='e4b075641c1d68a3e98a6d73ad3d029293fcf9e0773512315ef9c8482f251337')
depends_on('py-setuptools', type='build')
| [PyPybtexDocutils->[depends_on,version]] | A docutils backend for pybtex. | Spack now automatically detects `import_modules`, this might not be needed anymore |
@@ -3161,7 +3161,7 @@ namespace Js
// in EntryConcat like we do with Arrays because a getProperty on an object Length
// is observable. The result is we have to check for overflows separately for
// spreadable objects and promote to a bigger index type when we find them.
- ConcatArgs<BigIndex>(pDestArray, remoteTypeIds, args, scriptContext, idxArg, idxDest, /*firstPromotedItemIsSpreadable*/true, length);
+ ConcatArgs<BigIndex>(pDestObj, remoteTypeIds, args, scriptContext, idxArg, idxDest, /*firstPromotedItemIsSpreadable*/true, length);
return;
}
| [No CFG could be retrieved] | The following functions are used to copy items from the array to the destination array. - - - - - - - - - - - - - - - - - -. | >pDestObj [](start = 45, length = 8) Should we check pDestArray and send pDestObj down the generic path down below instead? |
@@ -305,8 +305,11 @@ public class FileWritingMessageHandler extends AbstractReplyProducingMessageHand
(StringUtils.hasText(this.temporaryFileSuffix) && tempFile.exists()));
if (!ignore) {
-
try {
+ if (!resultFile.exists()) {
+ tempFile.getParentFile().mkdirs();
+ resultFile.getParentFile().mkdirs();
+ }
if (payload instanceof File) {
resultFile = handleFileMessage((File) payload, tempFile, resultFile);
}
| [FileWritingMessageHandler->[renameTo->[renameTo],evaluateDestinationDirectoryExpression->[validateDestinationDirectory]]] | This method is overridden to handle the incoming message. This method is called when the request fails to write the message payload to the file. | Why do we need both of these? In both cases, the parent file is the same. |
@@ -74,6 +74,9 @@ struct EvalContext_
PromiseSet *promises_done;
void *enterprise_state;
+
+ // Full path to directory that the binary was launched from.
+ char *launch_directory;
};
static StackFrame *LastStackFrame(const EvalContext *ctx, size_t offset)
| [No CFG could be retrieved] | The following methods are used to find the next object in the stack that contains the given object Get the name of the class that should be used for the given context. | It is fine to leave this here for now, I understand that there aren't any other options. @dottedmag is looking at a RuntimeContext and we may move it over there later. |
@@ -96,7 +96,7 @@ namespace System.Diagnostics
SafeProcessHandle hCurProcess = SafeProcessHandle.InvalidHandle;
try
{
- hCurProcess = ProcessManager.OpenProcess((int)Interop.Kernel32.GetCurrentProcessId(), Interop.Advapi32.ProcessOptions.PROCESS_QUERY_INFORMATION, true);
+ hCurProcess = ProcessManager.OpenProcess(Environment.ProcessId, Interop.Advapi32.ProcessOptions.PROCESS_QUERY_INFORMATION, true);
if (!Interop.Kernel32.IsWow64Process(hCurProcess, out bool sourceProcessIsWow64))
{
| [NtProcessInfoHelper->[GetProcessInfos->[GetProcessInfos]],MainWindowFinder->[EnumWindowsCallback->[IsMainWindow]]] | Get the modules of a process. Enumerate all modules until it finds a free free free free free free free free free free check for a module that is not in the modules list. | Opening a new process handle for the current process just to call IsWow64Process on it looks like an overkill. Calling `Interop.Kernel32.GetCurrentProcess()` should be enough - it is what we do in the other place where `IsWow64Process` is called. |
@@ -193,10 +193,11 @@ public class BlockInputStream extends InputStream implements Seekable {
if (token != null) {
UserGroupInformation.getCurrentUser().addToken(token);
}
+ tokens = UserGroupInformation.getCurrentUser().getTokens();
DatanodeBlockID datanodeBlockID = blockID
.getDatanodeBlockIDProtobuf();
GetBlockResponseProto response = ContainerProtocolCalls
- .getBlock(xceiverClient, datanodeBlockID);
+ .getBlock(xceiverClient, datanodeBlockID, tokens);
chunks = response.getBlockData().getChunksList();
success = true;
| [BlockInputStream->[seek->[seek],read->[getRemaining,initialize,read],getPos->[getPos]]] | Get the list of chunks in the current container. | Should we just pass down the token from the caller directly and bypass the UGI addToken/getTokens completely? |
@@ -124,10 +124,13 @@ namespace DynamoWebServer.Messages
{
var name = dynamo.Model.CustomNodeManager.LoadedCustomNodes[guid]
.WorkspaceModel.Name;
- var workspace = dynamo.Workspaces.First(elem => elem.Name == name);
- var index = dynamo.Workspaces.IndexOf(workspace);
+ var workspace = dynamo.Workspaces.FirstOrDefault(elem => elem.Name == name);
+ if (workspace != null)
+ {
+ var index = dynamo.Workspaces.IndexOf(workspace);
- dynamo.CurrentWorkspaceIndex = index;
+ dynamo.CurrentWorkspaceIndex = index;
+ }
}
}
}
| [MessageHandler->[NodesDataModified->[OnResultReady]]] | SelectTabByGuid - Select tab by guid. if node is not in the list of nodes add it to the list of nodes and call. | check for not null |
@@ -7,6 +7,7 @@
* @returns {{
* type: BACKGROUND_ENABLED,
* backgroundEffectEnabled: boolean,
+ * blurValue: number,
* }}
*/
export const BACKGROUND_ENABLED = 'BACKGROUND_ENABLED';
| [No CFG could be retrieved] | Provides a description of the type of the action which is dispatched which represents whether the virtual background. | Please remove this from here. |
@@ -52,8 +52,8 @@ class NdsTrialConfig(Model):
'residual_basic',
'vanilla',
])
- model_spec = JSONField(index=True)
- cell_spec = JSONField(index=True, null=True)
+ model_spec = JSONField(json_dumps=json_dumps, index=True)
+ cell_spec = JSONField(json_dumps=json_dumps, index=True, null=True)
dataset = CharField(max_length=15, index=True, choices=['cifar10', 'imagenet'])
generator = CharField(max_length=15, index=True, choices=[
'random',
| [NdsTrialConfig->[CharField,FloatField,JSONField,IntegerField],NdsTrialStats->[ForeignKeyField,FloatField,IntegerField],NdsIntermediateStats->[ForeignKeyField,FloatField,IntegerField],join,SqliteExtDatabase] | This function is used to specify which nodes are actually the second node. Compute statistics for NDS. Each corresponds to one trial. | why this modification can resolve the dict element sequence issue? |
@@ -41,7 +41,7 @@ type Provider interface {
// CheckConfig validates the configuration for this resource provider.
CheckConfig(olds, news resource.PropertyMap) (resource.PropertyMap, []CheckFailure, error)
// DiffConfig checks what impacts a hypothetical change to this provider's configuration will have on the provider.
- DiffConfig(olds, news resource.PropertyMap) (DiffResult, error)
+ DiffConfig(olds, news resource.PropertyMap) (DiffResult, result.Result)
// Configure configures the resource provider with "globals" that control its behavior.
Configure(inputs resource.PropertyMap) error
| [No CFG could be retrieved] | typeProvider is a base implementation of the interface. | I admit, I don't like this - this feels like a layering violation to me. I'm not a fan of mixing and matching result.Result and error as return types for different methods. I think that we should consider logging everything that comes out of `Diff` and `DiffConfig` and keep it returning an `error`, to keep our code consistent here. |
@@ -228,7 +228,7 @@ public class RowBasedColumnSelectorFactory implements ColumnSelectorFactory
}
for (String dimensionValue : dimensionValues) {
- if (Objects.equals(Strings.emptyToNull(dimensionValue), value)) {
+ if (Objects.equals(NullHandling.emptyToNullIfNeeded(dimensionValue), value)) {
return true;
}
}
| [RowBasedColumnSelectorFactory->[makeColumnValueSelector->[TimeLongColumnSelector],makeDimensionSelectorUndecorated->[lookupName->[get],getObject->[get,lookupName]],create->[get->[get],RowBasedColumnSelectorFactory],getColumnCapabilities->[get]]] | Creates a DimensionSelector that only returns objects that are not decorated with a DimensionSelector. Override to provide a customizable implementation of a NoOpMatcher. Returns true if the row matches a constraint. | Group By experts - @gianm / @jon-wei / @jihoonson - could you please check that this change is valid (same below) |
@@ -259,8 +259,16 @@ class Estimator(object):
Raises:
ValueError: If the Estimator has not produced a checkpoint yet.
"""
+ def _check_string_or_not(name):
+ if isinstance(name, six.string_types):
+ return name
+ raise TypeError("Received type {} and was expecting an input of type string or a list of strings".format(type(name)))
+
_check_checkpoint_available(self.model_dir)
- return training.load_variable(self.model_dir, name)
+ if isinstance(name, six.string_types):
+ return training.load_variable(self.model_dir, name)
+ else:
+ return {v:traning.load_variable(self.model_dir, _check_string_or_not(v)) for v in name}
def get_variable_names(self):
"""Returns list of all variable names in this model.
| [_write_dict_to_summary->[_dict_to_str],_load_global_step_from_checkpoint_dir->[latest_checkpoint],_check_checkpoint_available->[latest_checkpoint],Estimator->[export_savedmodel->[latest_checkpoint],_create_and_assert_global_step->[_create_global_step],_evaluate_model->[latest_checkpoint,_call_model_fn,_get_features_and_labels_from_input_fn,_create_and_assert_global_step],predict->[latest_checkpoint],_train_model->[_call_model_fn,_get_features_and_labels_from_input_fn,_create_and_assert_global_step],latest_checkpoint->[latest_checkpoint]]] | Returns the value of the variable given by name. | Add a '.' in the end. |
@@ -97,7 +97,7 @@ def simulate_noise_evoked(evoked, cov, iir_filter=None, random_state=None):
The noise covariance
iir_filter : None | array
IIR filter coefficients (denominator)
- random_state : None | int | ~numpy.random.mtrand.RandomState
+ random_state : None | int | ~numpy.random.RandomState
To specify the random generator state.
Returns
| [_add_noise->[list,arange,_validate_type,pick_info,_generate_noise,len,where,set,_check_preload,in1d,info,slice],_simulate_noise_evoked->[copy,_add_noise],simulate_evoked->[int,_simulate_noise_evoked,get,sqrt,apply_forward,add_proj],_generate_noise->[check_random_state,compute_whitener,len,standard_normal,lfilter,zeros,dot],simulate_noise_evoked->[_simulate_noise_evoked],add_noise->[_add_noise],deprecated] | Simulate a noise as a multivariate Gaussian. | Didn't `fill_doc` this one since it's in a deprecated function anyway. |
@@ -224,7 +224,7 @@ public class TextEditingTargetSpelling implements TypoSpellChecker.Context
}
word = docDisplay_.getTextForRange(wordRange);
- if (word == null || word.length() < 2 || typoSpellChecker_.checkSpelling(word))
+ if (word == null || typoSpellChecker_.checkSpelling(word))
return;
// final variables for lambdas
| [TextEditingTargetSpelling->[injectContextMenuHandler->[checkSpelling,addToDictIcon]]] | Injects a context menu handler which is called when the user clicks on a token in the Add menu item for ignore word add to dictionary item and popup position and show. | This is just removing an inconsistency where the spellchecker would underline something but the context menu wasn't triggering. |
@@ -72,8 +72,12 @@ def make_environment(dirs=None):
"""Returns an configured environment for template rendering."""
if dirs is None:
# Default directories where to search for templates
+ builtins = spack.config.get('config:template_dirs')
+ extension_dirs = spack.config.get('config:extensions') or []
+ extensions = [os.path.join(x, 'templates') for x in extension_dirs]
dirs = [canonicalize_path(d)
- for d in spack.config.get('config:template_dirs')]
+ for d in itertools.chain(builtins, extensions)]
+
# Loader for the templates
loader = jinja2.FileSystemLoader(dirs)
# Environment of the template engine
| [ContextMeta->[__new__->[list,super,extend,dedupe],context_property->[append,property]],Context->[to_dict->[dict,getattr],with_metaclass],quote->[format],make_environment->[get,FileSystemLoader,canonicalize_path,_set_filters,Environment]] | Returns an environment for template rendering. | I think this and the next line should be wrapped into a function in the `extension` module. Where possible, I want to avoid complicating other modules with the details of how files in Spack command extensions are arranged (even something as small as searching for a `templates` directory inside of the extension base directory). |
@@ -38,8 +38,8 @@ class Schema_Generator implements Generator_Interface {
/**
* Generator constructor.
*
- * @param ID_Helper $id_helper A helper to retrieve Schema ID's.
- * @param Current_Page_Helper $current_page_helper A helper to determine current page.
+ * @param ID_Helper $id A helper to retrieve Schema ID's.
+ * @param Current_Page_Helper $current_page A helper to determine current page.
* @param Schema\Organization $organization_generator The organization generator.
* @param Schema\Person $person_generator The person generator.
* @param Schema\Website $website_generator The website generator.
| [Schema_Generator->[generate->[generate,get_graph_pieces,is_needed]]] | Constructor for a schema - generator. Constructor for the main image generator. | Please, fix the alignment |
@@ -19,8 +19,12 @@
*/
package org.nuxeo.runtime.services.config;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.commons.logging.Log;
+import org.apache.commons.logging.LogFactory;
import org.nuxeo.common.xmap.annotation.XNode;
import org.nuxeo.common.xmap.annotation.XObject;
+import org.nuxeo.runtime.model.Descriptor;
/**
* Descriptor for JSF configuration contributions.
| [ConfigurationPropertyDescriptor->[clone->[ConfigurationPropertyDescriptor]]] | Creates a new configuration property descriptor based on a base configuration object. | clone has became useless, please remove it |
@@ -90,6 +90,10 @@ func (l *Line) Next() ([]byte, int, error) {
return bytes, sz, nil
}
+func (r *Line) Stop() error {
+ return nil
+}
+
func (l *Line) advance() error {
var idx int
var err error
| [init->[Bytes,NewDecoder,NewEncoder,New],decode->[Bytes,Transform,Write],advance->[Reset,Append,IndexFrom,Advance,decode,Len,Read],Next->[Reset,Collect,advance,Len,Bytes],init] | Next returns the next potential line from the line. This function tries to decode a byte sequence from the input buffer and decode it into outBuffer. | maybe use io.ReadCloser checking reader at construction time implements Close, otherwise wrap via iotuil . |
@@ -209,7 +209,7 @@ bool bitmapNonEmpty(const SequenceNumberSet& snSet)
return false;
}
- const size_t last_index = num_ulongs - 1;
+ const CORBA::ULong last_index = num_ulongs - 1;
for (CORBA::ULong i = 0; i < last_index; ++i) {
if (snSet.bitmap[i]) {
return true;
| [No CFG could be retrieved] | on - the - fly returns true if the sequence number set is non - zero. | Will this generate a new warning for 64-bit to 32-bit truncation? |
@@ -0,0 +1,12 @@
+using Robust.Shared.GameObjects;
+using System;
+using System.Collections.Generic;
+using System.Text;
+
+namespace Content.Server.GameObjects.Components.MachineLinking
+{
+ public interface IReceiver
+ {
+ void Trigger(bool state);
+ }
+}
| [No CFG could be retrieved] | No Summary Found. | I wonder if we could make this an `IReceiver<T>` so triggering could take any argument, hmm. |
@@ -119,6 +119,9 @@ class DB_Command extends WP_CLI_Command {
* [--<field>=<value>]
* : Extra arguments to pass to mysqldump
*
+ * [--tables=<tables>]
+ * : The comma separated list of specific tables to export. Excluding this parameter will export all tables
+ *
* ## EXAMPLES
*
* wp db dump --add-drop-table
| [DB_Command->[import->[get_file_name],export->[get_file_name]]] | Executes a mysql query against the database and dumps the result to a file or STDOUT. Imports a database from a file or from STDIN. | Could you add an example that uses the new `--tables=` parameter? |
@@ -356,8 +356,7 @@ def flip_left_right(image):
See also `reverse()`.
Args:
- image: 4-D Tensor of shape `[batch, height, width, channels]` or
- 3-D Tensor of shape `[height, width, channels]`.
+ image: N-D Tensor of shape [D0, D1, ... Dn-1].
Returns:
A tensor of the same type and shape as `image`.
| [crop_to_bounding_box->[_assert,_ImageDimensions,_CheckAtLeast3DImage,_is_tensor],resize_image_with_crop_or_pad->[max_->[_is_tensor],equal_->[_is_tensor],min_->[_is_tensor],_ImageDimensions,_assert,max_,crop_to_bounding_box,min_,pad_to_bounding_box,_CheckAtLeast3DImage,_is_tensor,equal_],resize_images_v2->[_ImageDimensions],ssim_multiscale->[_ssim_per_channel,_verify_compatible_image_shapes,do_pad,convert_image_dtype],transpose->[_AssertAtLeast3DImage,transpose],resize_image_with_pad->[max_->[_is_tensor],_ImageDimensions,resize_images,_assert,max_,pad_to_bounding_box,_CheckAtLeast3DImage],rgb_to_grayscale->[convert_image_dtype],ssim->[_ssim_per_channel,_verify_compatible_image_shapes,convert_image_dtype],sobel_edges->[transpose],per_image_standardization->[_AssertAtLeast3DImage],adjust_gamma->[_assert],sample_distorted_bounding_box->[sample_distorted_bounding_box_v2],pad_to_bounding_box->[_assert,_ImageDimensions,_CheckAtLeast3DImage,_is_tensor],adjust_saturation->[convert_image_dtype,adjust_saturation],adjust_hue->[adjust_hue,convert_image_dtype],_ssim_per_channel->[_fspecial_gauss,_ssim_helper],_flip->[fix_image_flip_shape,_AssertAtLeast3DImage],_Assert3DImage->[_Check3DImage],psnr->[_verify_compatible_image_shapes,convert_image_dtype],adjust_jpeg_quality->[convert_image_dtype],decode_image->[_gif->[convert_image_dtype],_jpeg->[convert_image_dtype],_png->[convert_image_dtype],check_png->[_is_png],_bmp->[convert_image_dtype],is_jpeg],_random_flip->[fix_image_flip_shape,_AssertAtLeast3DImage],central_crop->[_get_dim,_AssertAtLeast3DImage],rot90->[_AssertAtLeast3DImage],non_max_suppression_with_overlaps->[non_max_suppression_with_overlaps]] | Flip an image horizontally ( left to right. | Here and everywhere: there is the constraint that `N >= 3`, right? |
@@ -24,6 +24,14 @@ class User::RegistrationTest < ActionDispatch::IntegrationTest
with_current_site(site) do
visit @registration_path
+ within "form#user-registration-form.new_user_registration" do
+ within "label" do
+ within "span.indication" do
+ assert has_content?("Required")
+ end
+ end
+ end
+
fill_in :user_registration_email, with: "user@email.dev"
click_on "Let's go"
| [site->[sites],test_registration_with_registered_user->[visit,email,fill_in,has_message?,assert,with_current_site,click_on],user->[users],test_registration_when_already_signed_in->[visit,with_current_user,has_message?,assert,with_current_site],test_invalid_registration->[visit,fill_in,has_message?,assert,with_current_site,click_on],test_registration_with_registered_user_in_other_site->[visit,email,fill_in,has_message?,assert,with_current_site,click_on],test_registration->[visit,fill_in,has_message?,assert,with_current_site,click_on],other_site->[sites],require] | Checks if a user has a lease. | Prefer single-quoted strings when you don't need string interpolation or special symbols. |
@@ -199,6 +199,17 @@ public final class InstrumenterBuilder<REQUEST, RESPONSE> {
InstrumenterConstructor.propagatingToDownstream(setter), SpanKindExtractor.alwaysClient());
}
+ /**
+ * Returns a new {@link Instrumenter} which will create client spans and inject context into
+ * requests.
+ */
+ public Instrumenter<REQUEST, RESPONSE> newClientInstrumenter(
+ TracingBuilder<REQUEST, RESPONSE, ?> tracingBuilder, TextMapSetter<REQUEST> setter) {
+ applyTracingBuilder(tracingBuilder);
+ return newInstrumenter(
+ InstrumenterConstructor.propagatingToDownstream(setter), SpanKindExtractor.alwaysClient());
+ }
+
/**
* Returns a new {@link Instrumenter} which will create server spans and extract context from
* requests.
| [InstrumenterBuilder->[addAttributesExtractors->[addAttributesExtractors],newInstrumenter->[newInstrumenter]]] | Creates a new client instrumenter that delegates to the downstream and then reads the contents of the. | The idea is to remove the methods that don't accept a `TracingBuilder` |
@@ -29,10 +29,10 @@ LIBRARY_DIRNAMES = {
}
# from time to time, remove the no longer needed ones
+_github_license = "https://github.com/{}/raw/master/LICENSE"
HARDCODED_LICENSE_URLS = {
- 'pytoml': 'https://github.com/avakar/pytoml/raw/master/LICENSE',
- 'webencodings': 'https://github.com/SimonSapin/python-webencodings/raw/'
- 'master/LICENSE',
+ 'pytoml': _github_license.format('avakar/pytoml'),
+ 'webencodings': _github_license.format('SimonSapin/python-webencodings')
}
| [extract_license->[log],extract_license_member->[license_destination,libname_from_dir,log],remove_all->[drop_dir],find_and_extract_license->[log],clean_vendor->[remove_all,log],download_licenses->[drop_dir,log],main->[clean_vendor,download_licenses,vendor,log,_get_vendor_dir],update_stubs->[detect_vendored_libs,_get_vendor_dir],license_fallback->[log],rewrite_imports->[rewrite_imports],apply_patch->[log],vendor->[rewrite_file_imports,remove_all,detect_vendored_libs,drop_dir,rewrite_imports,apply_patch,log]] | Drop a directory and all its contents. | I would leave this as it was. All it takes is one dependency with a `LICENSE.txt` to ruin it. Having to break the strings is annoying but it's the price we pay for keeping this kind of data in files with enforced line lengths. |
@@ -304,7 +304,7 @@ void sound_sdl::update_audio_stream(bool is_throttled, const int16_t *buffer, in
if (stream_buffer->free_size() < bytes_this_frame) {
if (LOG_SOUND)
- fprintf(sound_log, "Overflow: DS=%lu FS=%lu BTF=%lu\n", data_size, free_size, bytes_this_frame);
+ fprintf(sound_log, "Overflow: DS=%zu FS=%zu BTF=%zu\n", data_size, free_size, bytes_this_frame);
buffer_overflows++;
return;
}
| [No CFG could be retrieved] | Updates the audio stream of a single node. This function is called when a user has requested an unknown node in the system. | These changes break SDL Windows builds - the Windows C runtime lacks the SUS extension %z. |
@@ -1699,13 +1699,14 @@ class Jetpack_Share_WhatsApp extends Sharing_Source {
}
public function get_display( $post ) {
- return $this->get_link( 'whatsapp://send?text=' . rawurlencode( $this->get_share_title( $post->ID ) ) . ' ' . rawurlencode( $this->get_share_url( $post->ID ) ), _x( 'WhatsApp', 'share to', 'jetpack' ), __( 'Click to share on WhatsApp', 'jetpack' ) );
+
+ return $this->get_link( 'https://api.whatsapp.com/send?text=' . rawurlencode( $this->get_share_title( $post->ID ) . ' ' . $this->get_share_url( $post->ID ) ), _x( 'WhatsApp', 'share to', 'jetpack' ), __( 'Click to share on WhatsApp', 'jetpack' ) );
}
}
class Share_Skype extends Sharing_Source {
public $shortname = 'skype';
- public $genericon = '\f220';
+ public $icon = '\f220';
private $share_type = 'default';
public function __construct( $id, array $settings ) {
| [Share_Tumblr->[process_request->[get_share_url,get_share_title],get_display->[get_link,get_share_url,get_process_request_url,get_share_title],display_footer->[js_dialog]],Share_Reddit->[process_request->[http,get_share_url,get_share_title],get_display->[get_process_request_url,get_share_title,http,get_link,get_share_url]],Share_Twitter->[process_request->[sharing_twitter_via,get_share_url,get_related_accounts,get_share_title],get_display->[get_process_request_url,get_related_accounts,get_share_title,sharing_twitter_via,get_link,get_share_url],display_footer->[js_dialog]],Share_Custom->[process_request->[get_share_url,get_share_title],get_display->[get_link,get_process_request_url],__construct->[get_options],display_preview->[get_name,get_options]],Share_Facebook->[process_request->[http,get_share_url,get_share_title],get_display->[get_link,get_share_url,get_process_request_url],display_footer->[guess_locale_from_lang,js_dialog]],Share_Skype->[process_request->[get_share_url],get_display->[get_link,get_share_url,get_process_request_url],display_footer->[js_dialog]],Share_PressThis->[process_request->[get_share_url,get_share_title],get_display->[get_link,get_process_request_url]],Share_Pocket->[process_request->[get_share_url,get_share_title],get_display->[get_link,get_share_url,get_process_request_url],display_footer->[js_dialog]],Share_Telegram->[process_request->[get_share_url,get_share_title],get_display->[get_link,get_process_request_url],display_footer->[js_dialog]],Share_Email->[get_display->[get_link,get_process_request_url]],Sharing_Source->[get_link->[get_class],display_preview->[get_name,get_class],get_total->[get_id],get_posts_total->[get_id]],Share_Print->[get_display->[get_link,get_process_request_url]],Share_LinkedIn->[process_request->[get_share_url],get_display->[get_link,get_share_url,get_process_request_url],display_footer->[js_dialog]],Share_Pinterest->[get_external_url->[get_image,get_share_url],process_request->[get_external_url],get_display->[get_external_url,get_link,get_widget_type,get_process_request_url],display_footer->[get_widget_type]],Share_GooglePlus1->[process_request->[get_share_url],get_display->[get_link,get_share_url,get_process_request_url],display_footer->[js_dialog],get_total->[get_id]],Jetpack_Share_WhatsApp->[get_display->[get_link,get_share_url,get_share_title]]] | Get the display of the post. | Is there a reason why you added that empty line here? |
@@ -15,3 +15,6 @@ class ConanInstance(PythonToolInstance):
class ConanPrep(PythonToolPrepBase):
tool_subsystem_cls = Conan
tool_instance_cls = ConanInstance
+
+ def will_be_invoked(self):
+ return len(self.get_targets(lambda t: isinstance(t, ExternalNativeLibrary))) > 0
| [No CFG could be retrieved] | Create a class that will be used to run a Conan tool. | Probably a bit more idiomatic use of the language: `any(self.get_targets(...))`. |
@@ -146,6 +146,7 @@ func (i *Ingester) sweepSeries(userID string, fp model.Fingerprint, series *memo
flushQueueIndex := int(uint64(fp) % uint64(i.cfg.ConcurrentFlushes))
if i.flushQueues[flushQueueIndex].Enqueue(&flushOp{firstTime, userID, fp, immediate}) {
+ i.metrics.seriesEnqueuedForFlush.WithLabelValues(flush.String()).Inc()
util.Event().Log("msg", "add to flush queue", "userID", userID, "reason", flush, "firstTime", firstTime, "fp", fp, "series", series.metric, "nlabels", len(series.metric), "queue", flushQueueIndex)
}
}
| [flushUserSeries->[shouldFlushChunk,shouldFlushSeries,String]] | sweepSeries checks if a series should be flushed. If it is it will be flushed. | Small note: should we have a metric for the 'else' case here? Which would mean the series is already queued. I can't see that it's tremendously interesting, but if it was way out of line with expectations that could be interesting. |
@@ -177,9 +177,10 @@ public class KeycloakAuthenticationPlugin implements NuxeoAuthenticationPlugin,
*/
private Set<String> getRoles(AccessToken token, String keycloakNuxeoApp) {
Set<String> allRoles = new HashSet<>();
- Set<String> roles = token.getRealmAccess().getRoles();
- if (roles != null) {
- allRoles.addAll(roles);
+
+ AccessToken.Access realmAccess = token.getRealmAccess();
+ if (realmAccess != null && realmAccess.getRoles() != null) {
+ allRoles.addAll(realmAccess.getRoles());
}
AccessToken.Access nuxeoResource = token.getResourceAccess(keycloakNuxeoApp);
if (nuxeoResource != null) {
| [KeycloakAuthenticationPlugin->[getRoles->[getRoles]]] | Get the roles from the realm and resource. | The 10.10 commit has an added empty line after this `}`, please make sure your commits are not different without a reason. |
@@ -31,6 +31,10 @@ class SessionDecorator
view_context.root_url
end
+ def mfa_expiration_interval
+ Figaro.env.remember_device_expiration_hours_aal_1.to_i.hours
+ end
+
def failure_to_proof_url; end
def sp_msg; end
| [SessionDecorator->[verification_method_choice->[t],cancel_link_url->[root_url],new_session_heading->[t],attr_reader]] | end of method cancel_link_url_nack. | If this were accidentally unset, what would the impact of this coming out to 0 hours be? (`nil.to_i` is `0`) |
@@ -33,14 +33,10 @@ class PlotParsingError(ParseError):
def plot_data(filename, revision, content):
_, extension = os.path.splitext(filename.lower())
- if extension == ".json":
- return JSONPlotData(filename, revision, content)
- if extension == ".csv":
- return CSVPlotData(filename, revision, content)
- if extension == ".tsv":
- return CSVPlotData(filename, revision, content, delimiter="\t")
- if extension == ".yaml":
- return YAMLPlotData(filename, revision, content)
+ if extension in (".json", ".yaml"):
+ return DictData(filename, revision, content)
+ if extension in (".csv", ".tsv"):
+ return ListData(filename, revision, content)
raise PlotMetricTypeError(filename)
| [plot_data->[PlotMetricTypeError],_find_data->[PlotDataStructureError,_lists],_lists->[_lists],_apply_path->[PlotDataStructureError],PlotData->[to_datapoints->[_processors]]] | Plot data in a specific revision. | After moving data parsing to `collect` in #5984 we can abstract obtained data. |
@@ -128,6 +128,10 @@ func NewOpenShiftKubeAPIServerConfigPatch(delegateAPIServer genericapiserver.Del
// END CONSTRUCT DELEGATE
patchContext.informerStartFuncs = append(patchContext.informerStartFuncs, kubeAPIServerInformers.Start)
+ patchContext.postStartHooks["openshift.io-kubernetes-informers-synched"] = func(context genericapiserver.PostStartHookContext) error {
+ kubeInformers.WaitForCacheSync(context.StopCh)
+ return nil
+ }
patchContext.initialized = true
return openshiftNonAPIServer.GenericAPIServer, nil
| [Start->[Start],PatchServer->[AddPostStartHookOrDie,Errorf],GetOpenshiftUserInformers,Quota,GetOpenshiftQuotaInformers,NewForConfig,SecurityContextConstraints,OAuthClients,NewClusterQuotaMappingController,AddIndexers,NewQuotaConfigurationForAdmission,Secrets,New,Lister,ClusterResourceQuotas,Oauth,OpenshiftRequestInfoResolver,Informer,V1,ServiceAccounts,User,NewSharedInformerFactory,GetClusterQuotaMapper,Groups,Security,Namespaces,Evaluators,CopyConfig,NewInitializer,Core,GetOpenshiftSecurityInformers,NewRegistry,Pods,Run,Complete] | NewInitializer returns a new object that can be used to initialize a new node. This function is used to create a new instance of KubeAPIServerInformers. | Should this fail if you cannot sync? |
@@ -229,9 +229,6 @@ export function getDefaultBootstrapBaseUrl(parentWindow, opt_srcFileBasename) {
}
function getAdsLocalhost(win) {
- if (urls.localDev) {
- return `//${urls.thirdPartyFrameHost}`;
- }
return 'http://ads.localhost:'
+ (win.location.port || win.parent.location.port);
}
| [No CFG could be retrieved] | Returns the default base URL for a 3p bootstrap iframes. Get random number from the array. | this might not work on heroku though |
@@ -390,15 +390,15 @@ class LexicographicKeyRangeTracker(OrderedPositionRangeTracker):
if not s:
return 0
elif len(s) < prec:
- s += '\0' * (prec - len(s))
+ s += b'\0' * (prec - len(s))
else:
s = s[:prec]
return int(codecs.encode(s, 'hex'), 16)
@staticmethod
- def _string_from_int(i, prec):
+ def _bytestring_from_int(i, prec):
"""
- Inverse of _string_to_int.
+ Inverse of _bytestring_to_int.
"""
h = '%x' % i
return codecs.decode('0' * (2 * prec - len(h)) + h, 'hex')
| [UnsplittableRangeTracker->[set_split_points_unclaimed_callback->[set_split_points_unclaimed_callback],position_at_fraction->[position_at_fraction],start_position->[start_position],try_claim->[try_claim],fraction_consumed->[fraction_consumed],stop_position->[stop_position],set_current_position->[set_current_position]],OffsetRangeTracker->[split_points->[stop_position],position_at_fraction->[stop_position,start_position],try_claim->[stop_position,_validate_record_start],fraction_consumed->[stop_position,start_position],try_split->[stop_position,start_position],set_current_position->[_validate_record_start]]] | _string_to_int - Converts a string to an integer. | nit: s/string/bytestring/ on line 401. |
@@ -187,14 +187,11 @@ def recalculate_order_weight(order):
def update_taxes_for_order_line(
line: "OrderLine", order: "Order", manager, tax_included
):
- variant = line.variant
- product = variant.product # type: ignore
-
line_price = line.unit_price.gross if tax_included else line.unit_price.net
line.unit_price = TaxedMoney(line_price, line_price)
- unit_price = manager.calculate_order_line_unit(order, line, variant, product)
- total_price = manager.calculate_order_line_total(order, line, variant, product)
+ unit_price = calculations.order_line_unit(order, line, manager)
+ total_price = calculations.order_line_total(order, line, manager)
line.unit_price = unit_price
line.total_price = total_price
line.undiscounted_unit_price = line.unit_price + line.unit_discount
| [update_order_discount_for_order->[apply_discount_to_value],remove_discount_from_order_line->[update_taxes_for_order_line],create_order_discount_for_order->[apply_discount_to_value],get_products_voucher_discount_for_order->[get_prices_of_discounted_specific_product],get_prices_of_discounted_specific_product->[get_discounted_lines],change_order_line_quantity->[_update_allocations_for_line],update_order_prices->[recalculate_order,update_taxes_for_order_lines],recalculate_order->[recalculate_order_prices,recalculate_order_discounts],restock_order_lines->[get_order_country],update_discount_for_order_line->[apply_discount_to_value,update_taxes_for_order_line],get_valid_collection_points_for_order->[is_shipping_required],get_voucher_discount_for_order->[get_products_voucher_discount_for_order],recalculate_order_prices->[get_voucher_discount_assigned_to_order],update_taxes_for_order_lines->[update_taxes_for_order_line],order_needs_automatic_fulfillment->[order_line_needs_automatic_fulfillment],update_order_status->[_calculate_quantity_including_returns]] | Updates the Taxes for the order line based on the order line s unit price and total. | Is the name still valid? We have now logic with expiration which means, that we could call this method and we won't update anything. |
@@ -261,7 +261,8 @@ class MuleExtensionModelDeclarer {
.withOptionalParameter("ignoreErrorType")
.ofType(BaseTypeBuilder.create(JAVA).stringType().id(String.class.getName())
.enumOf("ANY", "REDELIVERY_EXHAUSTED", "TRANSFORMATION", "EXPRESSION", "SECURITY",
- "CLIENT_SECURITY", "SERVER_SECURITY", "ROUTING", "CONNECTIVITY", "RETRY_EXHAUSTED")
+ "CLIENT_SECURITY", "SERVER_SECURITY", "ROUTING", "CONNECTIVITY", "RETRY_EXHAUSTED", "TIMEOUT",
+ "COMPOSITE_ROUTING")
.build())
.withExpressionSupport(NOT_SUPPORTED)
.withLayout(LayoutModel.builder().tabName("Advanced").build())
| [MuleExtensionModelDeclarer->[declareChoice->[withMaxOccurs,describedAs,withMinOccurs],declareForEach->[describedAs,withChain],declareLogger->[describedAs,load,ofType],declareScheduler->[withSubType,withExpressionSupport,describedAs,addType,ofType,load],declareTry->[withAllowedStereotypes,describedAs,withChain],declareAsync->[describedAs,withChain],declareIdempotentValidator->[build,describedAs,withErrorModel,ofType,load],declareScatterGather->[describedAs,withMinOccurs],declareErrorHandler->[describedAs,declareOnErrorRoute],declareFlowRef->[build,describedAs,ofType],declareConfiguration->[getDeclaration,describedAs,addReconnectionStrategyParameter],declareFlow->[build,withStereotype,ofType,setRequired,withAllowedStereotypes,load],createExtensionModel->[declareChoice,declareForEach,build,declareLogger,declareScheduler,declareTry,declareAsync,withXmlDsl,declareScatterGather,declareErrorHandler,declareIdempotentValidator,declareFlowRef,declareConfiguration,declareFlow,createTypeLoader,declareErrors,getClassLoader],declareErrors->[build,withErrorModel],declareOnErrorRoute->[describedAs,withChain]]] | Declares the for - each extension. Required error types are ignored. | I wouldn't add it here, it's too specific. |
@@ -89,7 +89,8 @@ class SyncFile:
return self
def __exit__(self, exc_type, exc_val, exc_tb):
- self.close()
+ self.fd.__exit__(exc_type, exc_val, exc_tb)
+ #self.close()
def write(self, data):
self.fd.write(data)
| [SaveFile->[__exit__->[close,sync_dir],__enter__->[SyncFile]],SyncFile->[close->[sync,close,sync_dir],write->[write]]] | Exit the process after writing the file contents to the file descriptor. | XXX I really have to dive into this and see what really _is_ correct |
@@ -628,7 +628,7 @@ Rails.application.routes.draw do
namespace :api, defaults: { format: 'json' } do
get 'health', to: 'api#health'
get 'status', to: 'api#status'
- if Api.configuration.core_api_v1_enabled
+ if Api.configuration.core_api_v1_enabled || Rails.env.development?
namespace :v1 do
resources :teams, only: %i(index show) do
resources :inventories,
| [draw->[instance_eval,read,join],draw,use_doorkeeper,collection,resources,member,root,namespace,core_api_v1_enabled,get,constraints,skip_controllers,post,devise_scope,patch,devise_for,match,put,delete] | API endpoint for listing assets Return a list of resources that can be used to create or update a column. | Why is it needed here? |
@@ -3330,7 +3330,15 @@ namespace ProtoAssociative
if (bidx != Constants.kInvalidIndex)
{
baseConstructorName = core.ClassTable.ClassNodes[bidx].Name;
- int cidx = core.ClassTable.ClassNodes[bidx].ProcTable.IndexOf(baseConstructorName, argTypeList);
+ int cidx = core.ClassTable.ClassNodes[bidx].ProcTable.GetFunctionBySignature(new ProcedureMatchOptions()
+ {
+ FunctionName = baseConstructorName,
+ ParameterTypes = argTypeList,
+ ExcludeAutoGeneratedThisProc = true,
+ IsConstructor = true,
+ ExactMatchWithNumArgs = false,
+ ExactMatchWithArgTypes = false
+ }, out ProcedureNode dummy);
// If the base class is a FFI class, it may not contain a
// default constructor, so only assert for design script
// class for which we always generate a default constructor.
| [CodeGen->[EmitDependency->[SetEntry,EmitJumpDependency],GetFirstSymbolFromIdentList->[GetFirstSymbolFromIdentList],CyclicDependencyTest->[StrongConnectComponent],EmitGetterSetterForIdentList->[EmitIdentifierNode,EmitBinaryExpressionNode],TraverseDotCallArguments->[PushSymbolAsDependent],IdentifierNode->[EmitBinaryExpressionNode],EmitClassDeclNode->[EmitMemberVariables],EmitLHSIdentifierListForBinaryExpr->[AutoGenerateUpdateReference,EmitDependency],EmitBinaryExpressionNode->[EmitDependency,EmitLHSIdentifierListForBinaryExpr,EmitLHSThisDotProperyForBinaryExpr,GetUpdatedNodeRef,AutoGenerateUpdateReference,CyclicDependencyTest,HandlePointerList],ProcedureNode->[TraverseDotCallArguments,GetProcedureFromInstance,PushSymbolAsDependent,EmitFunctionCall],DfsTraverse->[EmitFunctionCallNode,EmitIdentifierNode,EmitFunctionDefinitionNode,EmitLanguageBlockNode,EmitInlineConditionalNode,EmitRangeExprNode,EmitClassDeclNode,EmitBinaryExpressionNode,EmitUnaryExpressionNode,EmitConstructorDefinitionNode,EmitImportNode,String,EmitGroupExpressionNode,EmitDynamicBlockNode],EmitFunctionDefinitionNode->[EmitCodeBlock,AllocateArg],StrongConnectComponent->[IsDependentSubNode,StrongConnectComponent],EmitMemberVariables->[EmitGetterForProperty,EmitMemberVariables,AllocateMemberVariable,EmitSetterForProperty],EmitInlineConditionalNode->[EmitFunctionCallNode,EmitDynamicLanguageBlockNode],TraverseAndAppendThisPtrArg->[TraverseAndAppendThisPtrArg],Emit->[AllocateContextGlobals,EmitCodeBlock,EmitExpressionInterpreter],GetReplicationGuides->[GetReplicationGuides],EmitConstructorDefinitionNode->[EmitReturn,EmitAllocc,AllocateArg,EmitCallingForBaseConstructor,EmitCodeBlock],EmitIdentifierNode->[PushSymbolAsDependent,EmitDependency],RemoveAtLevel->[RemoveAtLevel],EmitAllocc->[SetEntry],RemoveReplicationGuides->[RemoveReplicationGuides]]] | Emit calling for base constructor. Private method called to populate the base constructor and the constructor index. | Is `cidx` the class index or function index? |
@@ -27,7 +27,8 @@ class ContentsTest(base.PulpWebserviceTests):
"""
# Setup
path = '/v2/content/actions/delete_orphans/'
- post_body = '[{"content_type_id": "rpm", "unit_id": "d692be5f-f585-4e6d-b816-0285ffecd847"}]'
+ post_body = '[{"content_type_id": "rpm", ' \
+ '"unit_id": "d692be5f-f585-4e6d-b816-0285ffecd847"}]'
# Test
status, body = self.post(path, post_body)
# Verify
| [ContentSourcesTests->[test_get->[assert_called_with,dict,assertEqual,get,values,Mock],test_post->[assertEqual,get,post,assertIsNotNone,Mock],patch],CatalogTests->[test_delete->[assert_called_with,assertEqual,delete],patch],ContentsTest->[test_delete_orphan_by_type->[assert_called_once,assertEqual,delete],tearDown->[reset,super],test_post_to_deleteorphan->[post,assert_called_once,assertEqual],setUp->[install,super,_create_manager],patch],ContentSourceResourceTests->[test_get->[Mock,get,assertEqual,assert_called_with],test_post->[assertEqual,get,post,assertIsNotNone,Mock],test_post_bad_request->[post,Mock,assertEqual],patch]] | Test post to delete an orphan via DeleteOrphansAction . | I think you can drop the `\`. |
@@ -49,9 +49,6 @@ class ServerTests(unittest.TestCase):
shutil.rmtree(storage_dir+'/*', ignore_errors=True)
managers.initialize()
- def setUp(self):
- QueuedCall.get_collection().remove()
-
class ClientTests(TestCase):
| [TaskResult->[__init__->[Task]],ClientTests->[setUp->[setUp]]] | Initialize the pulp client class. | Why is this being removed? |
@@ -40,7 +40,7 @@ public class ParallelCommandList
{
if (running_)
{
- log("cannot add - already running");
+ log(constants_.addCommandLabel());
return;
}
| [ParallelCommandList->[log->[log,size,hashCode],addCommand->[add,log],countdown->[log,clear,execute],run->[onExecute,log,countdown,size]]] | Adds a command to the queue. | We'd prefer to leave logging messages unlocalized. These are often googled/searched in GitHub (by us and our support team) and having them eventually being in other languages will be a support problem. Do you have a mandate to make all UI, even command-line, be localized? Or just end user facing UI? |
@@ -629,6 +629,14 @@ namespace System
{
throw new ArgumentNullException(nameof(values));
}
+ if (values is List<string?> valuesIList)
+ {
+ return Join(separator, CollectionsMarshal.AsSpan(valuesIList), 0, valuesIList.Count);
+ }
+ if (values is string?[] valuesArray)
+ {
+ return Join(separator, valuesArray, 0, valuesArray.Length);
+ }
using (IEnumerator<string?> en = values.GetEnumerator())
{
| [String->[PadRight->[PadRight],SplitInternal->[SplitInternal],ToUpper->[ToUpper],ToLowerInvariant->[ToLower],PadLeft->[PadLeft],Join->[Join],Replace->[Replace],ToUpperInvariant->[ToUpper],CreateTrimmedString->[InternalSubString],JoinCore->[FillStringChecked,JoinCore],Split->[SplitInternal],Concat->[Concat,FillStringChecked],Substring->[Substring],ToLower->[ToLower],ReplaceCore->[ReplaceCore]]] | Join the given values into a string. If the separator is null or empty the string is. | This could access unowned memory in the face of a race condition. If the list is being added to concurrently, the count could end up being larger than the span; the helper then uses unsafe code to walk the list, up to the count. The code needs to use the same span for the count. |
@@ -583,14 +583,14 @@ def compress_files(files, symlinks, name, dest_dir, output=None):
"Compressing %s" % name) as pg_file_list:
for filename, abs_path in pg_file_list:
info = tarfile.TarInfo(name=filename)
- info.size = os.stat(abs_path).st_size
- info.mode = os.stat(abs_path).st_mode & mask
if os.path.islink(abs_path):
info.type = tarfile.SYMTYPE
info.size = 0 # A symlink shouldn't have size
info.linkname = os.readlink(abs_path) # @UndefinedVariable
tgz.addfile(tarinfo=info)
else:
+ info.mode = os.stat(abs_path).st_mode & mask
+ info.size = os.stat(abs_path).st_size
with open(abs_path, 'rb') as file_handler:
tgz.addfile(tarinfo=info, fileobj=file_handler)
tgz.close()
| [_compress_recipe_files->[add_tgz],CmdUpload->[_compress_recipe_files->[_compress_recipe_files],_compress_package_files->[_compress_package_files]]] | Compress files and symlinks into a single file. | wouldn't symlinks suffer the same issue of regular files regarding permissions/modes? (this mask was added because docker). Should use same mask but with ``os.lstat()``? It would also be nice to avoid calling ``os.stat()`` twice for the same file. |
@@ -1125,9 +1125,9 @@ PromiseResult FileInstallPackage(const char *package_file_path,
if (action == cfa_warn || DONTDO)
{
- Log(LOG_LEVEL_WARNING, "Should install file type package: %s",
+ Log(LOG_LEVEL_VERBOSE, "Should install file type package: %s",
package_file_path);
- res = PROMISE_RESULT_FAIL;
+ res = PROMISE_RESULT_WARN;
}
else
{
| [UpdatePackagesDB->[WritePackageDataToDB],FileInstallPackage->[InstallPackage,ValidateChangedPackage],UpdateCache->[UpdatePackagesDB],HandlePresentPromiseAction->[FileInstallPackage,RepoInstallPackage],ValidateChangedPackage->[UpdateCache],RepoInstall->[InstallPackage,GetVersionsFromUpdates,ValidateChangedPackage],UpdatePackagesCache->[DeletePackageModuleWrapper,NewPackageModuleWrapper],RepoInstallPackage->[ValidateChangedPackage,RepoInstall],HandleAbsentPromiseAction->[ValidateChangedPackage,RemovePackage],UpdateSinglePackageModuleCache->[stat,UpdateCache],NewPackageModuleWrapper->[DeletePackageModuleWrapper]] | FileInstallPackage Installs a file type package. | So if I read this correctly, the reason this one and a few others are "verbose" and not "warning" is because of the `switch` statement in `verify_new_packages.c` that checks for `PROMISE_RESULT_WARN`, is that correct? |
@@ -135,6 +135,10 @@ func (j Job) FriendlyCreatedAt() string {
if j.OffChainReportingSpec != nil {
return j.OffChainReportingSpec.CreatedAt.Format(time.RFC3339)
}
+ case KeeperJob:
+ if j.KeeperSpec != nil {
+ return j.KeeperSpec.CreatedAt.Format(time.RFC3339)
+ }
default:
return "unknown"
}
| [toRow->[String,FriendlyCreatedAt],ToRows->[FriendlyTasks],FriendlyTasks->[GetTasks]] | FriendlyCreatedAt returns the string representation of the creation time of a job. | Why use this time format over ISO? |
@@ -167,7 +167,7 @@ MulticastInst::dump_to_str()
os << formatNameForDump("nak_delay_intervals") << this->nak_delay_intervals_ << std::endl;
os << formatNameForDump("nak_max") << this->nak_max_ << std::endl;
os << formatNameForDump("nak_timeout") << this->nak_timeout_.msec() << std::endl;
- os << formatNameForDump("ttl") << int(this->ttl_) << std::endl;
+ os << formatNameForDump("ttl") << this->ttl_ << std::endl;
os << formatNameForDump("rcv_buffer_size");
if (this->rcv_buffer_size_ == 0) {
| [No CFG could be retrieved] | Create a MulticastTransport instance for the given multicast configuration. A list of intervals that can be serialized. | Keep the cast to an integer, to avoid printing an ASCII character. |
@@ -115,6 +115,10 @@ public class TaskSpec {
}
this.functionDescriptor = functionDescriptor;
this.executionDependencies = new ArrayList<>();
+ returnIds = new ObjectId[numReturns];
+ for (int i = 0; i < numReturns; ++i) {
+ returnIds[i] = IdUtil.computeReturnId(taskId, i + 1);
+ }
}
public JavaFunctionDescriptor getJavaFunctionDescriptor() {
| [TaskSpec->[getJavaFunctionDescriptor->[checkState],toString->[toString],isActorCreationTask->[isNil],isActorTask->[isNil],getPyFunctionDescriptor->[checkState],checkArgument,getClass]] | getJavaFunctionDescriptor - get JavaFunctionDescriptor. | Nit, maybe put this right under `this.numReturns = numReturns;`? |
@@ -38,7 +38,7 @@ define ( 'FRIENDICA_PLATFORM', 'Friendica');
define ( 'FRIENDICA_CODENAME', 'Asparagus');
define ( 'FRIENDICA_VERSION', '3.5.1-dev' );
define ( 'DFRN_PROTOCOL_VERSION', '2.23' );
-define ( 'DB_UPDATE_VERSION', 1206 );
+define ( 'DB_UPDATE_VERSION', 1207 );
/**
* @brief Constant with a HTML line break.
| [get_temppath->[get_hostname],z_root->[get_baseurl],get_guid->[get_hostname],login->[get_baseurl],killme->[is_backend],proc_run->[proc_run],App->[get_useragent->[get_baseurl],maxload_reached->[is_backend,maxload_reached],max_processes_reached->[is_backend,max_processes_reached],init_pagehead->[get_baseurl],remove_baseurl->[remove_baseurl,get_baseurl],proc_run->[get_baseurl],get_baseurl->[get_baseurl],init_page_end->[get_baseurl],is_already_running->[is_already_running]],set_template_engine->[set_template_engine],z_path->[get_baseurl],check_url->[get_baseurl]] | Provides a basic description of a specific . Save space at cost of image detail. | Please be aware that - if my pull request might be accepted - I already used this database version number. |
@@ -60,9 +60,11 @@ def stdout_contents(wu):
return f.read().rstrip()
-def dump_digest(output_dir, digest):
- safe_file_dump('{}.digest'.format(output_dir),
- '{}:{}'.format(digest.fingerprint, digest.serialized_bytes_length), mode='w')
+def write_digest(output_dir, digest):
+ safe_file_dump(
+ '{}.digest'.format(output_dir),
+ mode='w',
+ payload='{}:{}'.format(digest.fingerprint, digest.serialized_bytes_length))
def load_digest(output_dir):
| [RscCompile->[create_compile_jobs->[CompositeProductAdder->[add_for_target->[add_for_target]],work_for_vts_metacp->[fast_relpath_collection,_is_scala_core_library,ensure_output_dirs_exist,stdout_contents],work_for_vts_rsc->[register_extra_products_from_contexts,fast_relpath_collection,ensure_output_dirs_exist,_paths_from_classpath,is_java_compile_target],_metacpable,_compile_against_rsc_key_for_target,CompositeProductAdder,_rsc_compilable,_rsc_key_for_target,_metacp_key_for_target,_metacp_dep_key_for_target,_only_zinc_compilable],_runtool->[_runtool_hermetic,_runtool_nonhermetic],register_extra_products_from_contexts->[to_classpath_entries->[load_digest,pathglob_for],confify,to_classpath_entries],_run_metai_tool->[_runtool],create_compile_context->[RscCompileContext],_collect_metai_classpath->[_create_desandboxify_fn,desandboxify],_rsc_key_for_target->[_rsc_compilable,_metacpable,_only_zinc_compilable],_get_jvm_distribution->[HermeticDistribution->[find_libs->[find_libs]],HermeticDistribution],_metacp_dep_key_for_target->[_rsc_compilable,_metacpable,_only_zinc_compilable],_runtool_hermetic->[fast_relpath_collection,dump_digest],select->[_rsc_compilable,_metacpable,_only_zinc_compilable],pre_compile_jobs->[work_for_vts_rsc_jdk->[stdout_contents]]]] | Dump a digest file to output_dir. | When you first started working on this PR, we did not specify what this should be. But since working on it, we merged a PR that changes this to `mode='w'` to fix unicode issues. This should go back to being `w`. |
@@ -57,11 +57,11 @@ namespace NServiceBus.Features
{
var distributorAddress = context.Settings.GetOrDefault<string>("LegacyDistributor.Address");
- var subscriberAddress = distributorAddress ?? context.Settings.LocalAddress();
+ var subscriberAddress = distributorAddress ?? context.Transport.SharedQueue;
var subscriptionRouter = new SubscriptionRouter(publishers, endpointInstances, i => transportInfrastructure.ToTransportAddress(LogicalAddress.CreateRemoteAddress(i)));
- context.Pipeline.Register(b => new MessageDrivenSubscribeTerminator(subscriptionRouter, subscriberAddress, context.Settings.EndpointName(), b.Build<IDispatchMessages>()), "Sends subscription requests when message driven subscriptions is in use");
- context.Pipeline.Register(b => new MessageDrivenUnsubscribeTerminator(subscriptionRouter, subscriberAddress, context.Settings.EndpointName(), b.Build<IDispatchMessages>()), "Sends requests to unsubscribe when message driven subscriptions is in use");
+ context.Pipeline.Register(new MessageDrivenSubscribeTerminator(subscriptionRouter, subscriberAddress, context.Settings.EndpointName(), context.Transport.Dispatcher), "Sends subscription requests when message driven subscriptions is in use");
+ context.Pipeline.Register(new MessageDrivenUnsubscribeTerminator(subscriptionRouter, subscriberAddress, context.Settings.EndpointName(), context.Transport.Dispatcher), "Sends requests to unsubscribe when message driven subscriptions is in use");
var authorizer = context.Settings.GetSubscriptionAuthorizer();
if (authorizer == null)
| [MessageDrivenSubscriptions->[Setup->[PersistenceStartup,CreateRemoteAddress,EndpointName,b,RegisterSingleton,Apply,GetSubscriptionAuthorizer,ToTransportAddress,EnforceBestPracticesSettingsKey,Register,Settings,LocalAddress,Pipeline],Prerequisite,EnableByDefault,Unicast,Defaults,s,Publishes]] | Setup method. Missing subscription authorizer. | I think at this stage we can name `SharedQueue` `MainQueue`. I named the settings key `SharedQueue` but I don't think it should appear under than name. `LocalQueue` sounds also good. |
@@ -339,9 +339,13 @@ public abstract class TemplateAdapterBase extends AdapterBase implements Templat
new VMTemplateVO(profile.getTemplateId(), profile.getName(), profile.getFormat(), profile.getIsPublic(), profile.getFeatured(), profile.getIsExtractable(),
profile.getTemplateType(), profile.getUrl(), profile.getRequiresHVM(), profile.getBits(), profile.getAccountId(), profile.getCheckSum(),
profile.getDisplayText(), profile.getPasswordEnabled(), profile.getGuestOsId(), profile.getBootable(), profile.getHypervisorType(),
- profile.getTemplateTag(), profile.getDetails(), profile.getSshKeyEnabled(), profile.IsDynamicallyScalable());
+ profile.getTemplateTag(), profile.getDetails(), profile.getSshKeyEnabled(), profile.IsDynamicallyScalable(), profile.isDirectDownload());
template.setState(initialState);
+ if (profile.isDirectDownload()) {
+ template.setSize(profile.getSize());
+ }
+
if (zoneIdList == null) {
List<DataCenterVO> dcs = _dcDao.listAll();
| [TemplateAdapterBase->[prepareDelete->[accountAndUserValidation],prepare->[prepare]]] | Method to persist a template in the system. | `profile.isDirectDownload()` might return null since all constructors don't set the direct download `Boolean` variable. The method declaration expects a `boolean`, so no `null`. |
@@ -357,7 +357,6 @@ Rails.application.routes.draw do
get "/async_info/shell_version", controller: "async_info#shell_version", defaults: { format: :json }
get "/future", to: redirect("devteam/the-future-of-dev-160n")
- get "/forem", to: redirect("devteam/for-empowering-community-2k6h")
# Settings
post "users/update_language_settings" => "users#update_language_settings"
| [new,authenticate,authenticated,redirect,devise_scope,mount,put,draw,freeze,resources,member,root,use,scope,post,set,controllers,require,secrets,class_eval,use_doorkeeper,resource,url,patch,devise_for,each,production?,delete,namespace,collection,get,session_options,tech_admin?,app] | Router for channel memberships Redirects all users to their respective methods. | We'll want to tackle /future in a subsequent PR as well. I left it for now because I'd like to get this out first |
@@ -32,12 +32,11 @@ import hudson.PluginWrapper;
import hudson.Util;
import hudson.lifecycle.Lifecycle;
import hudson.model.UpdateCenter.UpdateCenterJob;
-import hudson.util.FormValidation;
+import hudson.util.*;
import hudson.util.FormValidation.Kind;
-import hudson.util.HttpResponses;
-import hudson.util.TextFile;
+
import static hudson.util.TimeUnit2.*;
-import hudson.util.VersionNumber;
+
import java.io.File;
import java.io.IOException;
import java.net.URI;
| [UpdateSite->[updateDirectlyNow->[getId],getMetadataUrlForDownloadable->[getUrl],getJsonSignatureValidator->[getJsonSignatureValidator],getDataFile->[getId],getUpdates->[getData],verifySignature->[verifySignature],getPlugin->[getData],Data->[getJSONObject],Warning->[isRelevantToVersion->[includes],equals->[equals],isRelevant->[getPlugin],hashCode->[hashCode],isPluginWarning->[equals],getJSONObject,WarningVersionRange],getConnectionCheckUrl->[getData],getAvailables->[getData],hasUpdates->[getData],Plugin->[getInstalled->[getPlugin],isNeededDependenciesCompatibleWithInstalledVersion->[isCompatibleWithInstalledVersion,getNeededDependencies,isNeededDependenciesCompatibleWithInstalledVersion],getWarnings->[isRelevantToVersion,isPluginWarning,get],isCompatibleWithInstalledVersion->[getInstalled],getNeededDependencies->[getPlugin,getInstalled],getNeededDependenciesRequiredCore->[getNeededDependenciesRequiredCore,getNeededDependencies,isNewerThan],doInstall->[deploy],doInstallNow->[deploy],doDowngrade->[deployBackup],isForNewerHudson->[isNewerThan],isNeededDependenciesForNewerJenkins->[getNeededDependencies,isForNewerHudson,isNeededDependenciesForNewerJenkins],deploy->[getInstalled,equals,getNeededDependencies,createInstallationJob,deploy],equals]]] | This method imports all the required components of a single from the Software. Imports the given object. | Please do not do it in the production code |
@@ -172,9 +172,12 @@ func (p *asyncLogPublisher) Start() {
case <-p.done:
return
case events := <-p.in:
- pubEvents := make([]common.MapStr, len(events))
- for i, event := range events {
- pubEvents[i] = event.ToMapStr()
+
+ pubEvents := make([]common.MapStr, 0, len(events))
+ for _, event := range events {
+ if event.HasData() {
+ pubEvents = append(pubEvents, event.ToMapStr())
+ }
}
batch := &eventsBatch{
| [Completed->[StoreInt32],Stop->[Close,Wait],Failed->[StoreInt32,Err],Start->[Add,PublishEvents,NewTicker,append,Connect,ToMapStr,Signal,collect,Info,Done,Debug],collect->[LoadInt32,Info,Critical],Canceled->[Info,StoreInt32],NewInt] | Start starts sending events to the output. | `pubEvents := make([]common.MapStr, 0, len(events))`. See line 111. Consider helper function copying events and reuse in sync and async publisher modes. |
@@ -148,8 +148,6 @@ namespace Dynamo.Services
// First run of Dynamo
if (dynamoModel.PreferenceSettings.IsFirstRun)
{
- FirstRun = false;
-
//Analytics enable by defaultwa
IsAnalyticsReportingApproved = true;
| [UsageReportingManager->[CheckIsFirstRun->[IsTestMode,IsFirstRun,ShowUsageReportingPrompt],UsageReportingPromptLoaded->[End,OnRequestMigrationStatusDialog],ToggleIsUsageReportingApproved->[DynamoView,ShowUsageReportingPrompt],ShowUsageReportingPrompt->[ShowDialog,Loaded,MainWindow,Current],InitializeCore->[dynamoModel],RaisePropertyChanged,SaveInternal,IsTestMode,IsCrashing,Message,IsFirstRun,IsUsageReportingApproved,UsageReportingErrorMessage,OnRequestsCrashPrompt,PreferenceFilePath,IsAnalyticsReportingApproved]] | Check if the object is the first run of the DynamoDb object. | Try not to touch this `UsageReportingManager`, it is a very sensitive class (it has legal implications if not done well). We should probably pass the value of `PreferenceSettings.IsFirstRun` to the `StartPage` before it is changed. |
@@ -131,14 +131,14 @@ class Conll2003DatasetReader(DatasetReader):
instance_fields: Dict[str, Field] = {'tokens': sequence}
instance_fields["metadata"] = MetadataField({"words": [x.text for x in tokens]})
- # Recode the labels if necessary.
- if self.coding_scheme == "BIOUL":
+ # Recode the labels to BIOUL
+ if self.convert_to_coding_scheme == "BIOUL":
coded_chunks = to_bioul(chunk_tags,
encoding=self._original_coding_scheme) if chunk_tags is not None else None
coded_ner = to_bioul(ner_tags,
encoding=self._original_coding_scheme) if ner_tags is not None else None
else:
- # the default IOB1
+ # Retain the original coding scheme
coded_chunks = chunk_tags
coded_ner = ner_tags
| [_is_divider->[strip,split],Conll2003DatasetReader->[text_to_instance->[SequenceLabelField,to_bioul,Instance,TextField,ConfigurationError,MetadataField],__init__->[SingleIdTokenIndexer,super,set,format,ConfigurationError],_read->[text_to_instance,list,Token,cached_path,groupby,zip,strip,info,open]],register,getLogger] | Create a sequence of words from a sequence of tokens. label to instance . | I'd keep this as `if necessary`, but no strong opinion |
@@ -87,7 +87,9 @@ class EraseTypeVisitor(TypeVisitor[ProperType]):
def visit_union_type(self, t: UnionType) -> ProperType:
erased_items = [erase_type(item) for item in t.items]
- return UnionType.make_simplified_union(erased_items)
+ from mypy.typeops import make_simplified_union # asdf
+ # XXX: does this need to be simplified?
+ return make_simplified_union(erased_items)
def visit_type_type(self, t: TypeType) -> ProperType:
return TypeType.make_normalized(t.item.accept(self), line=t.line)
| [EraseTypeVisitor->[visit_union_type->[erase_type]],TypeVarEraser->[visit_type_var->[erase_id]]] | Erase union types and normalize them. | I think sometimes it may be useful. For example we probably want `Union[List[T], List[S]]` become just `List[Any]`, not `Union[List[Any], List[Any]]`. I think a similar applies to the question below. |
@@ -285,7 +285,7 @@ class TorchRankerAgent(TorchAgent):
def update_params(self):
"""Do optim step and clip gradients if needed."""
- if self.clip > 0:
+ if hasattr(self, 'clip') and self.clip > 0:
torch.nn.utils.clip_grad_norm_(self.model.parameters(), self.clip)
self.optimizer.step()
| [TorchRankerAgent->[add_cmdline_args->[add_cmdline_args],eval_step->[score_candidates],train_step->[score_candidates]]] | Update the parameters of the model. | simpler: `if self.get('clip', 0) > 0:` |
@@ -70,15 +70,9 @@ func resourceAwsWafRateBasedRule() *schema.Resource {
Required: true,
},
"rate_limit": &schema.Schema{
- Type: schema.TypeInt,
- Required: true,
- ValidateFunc: func(v interface{}, k string) (ws []string, errors []error) {
- value := v.(int)
- if value < 2000 {
- errors = append(errors, fmt.Errorf("%q cannot be less than 2000", k))
- }
- return
- },
+ Type: schema.TypeInt,
+ Required: true,
+ ValidateFunc: validation.IntAtLeast(2000),
},
},
}
| [Printf,UpdateRateBasedRule,CreateRateBasedRule,GetChange,HasChange,List,RetryWithToken,Id,String,Errorf,Int64,SetId,Get,GetRateBasedRule,Set,Code,DeleteRateBasedRule] | resourceAwsWafRateBasedRuleCreate creates a rate - based rule that can be used The function to create a rate - based rule. | Shouldn't this be `validation.IntAtLeast(2000)`? |
@@ -5584,6 +5584,10 @@ amp.validator.ValidationResult.prototype.outputToTerminal = function(
const {status} = this;
if (status === amp.validator.ValidationResult.Status.PASS) {
terminal.info('AMP validation successful.');
+ terminal.info('Review our \'Publishing checklist\' to ensure '
+ + 'successful AMP document distribution. '
+ + 'https://amp.dev/documentation/guides-and-tutorials/'
+ + 'optimize-and-measure/publishing_checklist.html?format=websites');
if (this.errors.length === 0) {
return;
}
| [TagStack->[matchChildTagName->[matchChildTagName],updateFromTagResults->[getSpec],exitTag->[childTagMatcher,referencePointMatcher],updateStackEntryFromTagResult_->[childTagMatcher,cdataMatcher,referencePointMatcher],setDescendantConstraintList->[getSpec]],info->[info],Context->[recordAttrRequiresExtension_->[attrsCanSatisfyExtension,recordUsedExtensions,getAttrsByName,getSpec],markUrlSeenFromMatchingTagSpec_->[containsUrl,getSpec],satisfyMandatoryAlternativesFromTagSpec_->[getSpec],satisfyConditionsFromTagSpec_->[getSpec],recordValidatedFromTagSpec_->[id]],warn->[warn],ParsedValidatorRules->[getReferencePointName->[getSpec],validateTypeIdentifiers->[addError,getLineCol],maybeEmitAlsoRequiresTagValidationErrors->[getLineCol,getExtensions,getAlsoRequiresTagWarning,addWarning,unusedExtensionsRequired,getRules,getSpec,excludes,addError,satisfiesCondition,getTagspecsValidated,requires],maybeEmitMandatoryAlternativesSatisfiedErrors->[addError,getLineCol,getRules,getMandatoryAlternativesSatisfied],maybeEmitMandatoryTagValidationErrors->[getTagspecsValidated,addError,getLineCol],getByTagSpecId->[shouldRecordTagspecValidated],maybeEmitCssLengthSpecErrors->[getLineCol,getInlineStyleByteSize,getRules,addError,getStyleAmpCustomByteSize],constructor->[registerTagSpec,registerDispatchKey]],emitMissingExtensionErrors->[missingExtensionErrors],ParsedTagSpec->[mergeAttrs->[getByAttrSpecId,getSpec,getNameByAttrSpecId]],error->[error],CdataMatcher->[match->[getLineCol]],UrlErrorInAttrAdapter->[disallowedRelativeUrl->[addError,getLineCol],invalidUrlProtocol->[addError,getLineCol],missingUrl->[addError,getLineCol],invalidUrl->[addError,getLineCol]],UrlErrorInStylesheetAdapter->[disallowedRelativeUrl->[addError],invalidUrlProtocol->[addError],missingUrl->[addError],invalidUrl->[addError]],startTag->[validateTag],cdata->[match],ExtensionsContext->[updateFromTagResult->[getSpec],recordFutureErrorsIfMissing->[getCol,getLine,getSpec]],ReferencePointMatcher->[recordMatch->[id],validateTag->[getLineCol],constructor->[empty]],ChildTagMatcher->[matchChildTagName->[getLineCol]],parentOnlyChildTagName,getCol,info,id,parentLastChildTagName,getSpec,addError,getMandatoryValuePropertyNames,isReferencePoint,parentHasChildWithNoSiblingRule,getTagspecsValidated,matchingDispatchKey,hasDispatchKeys,getValuePropertiesOrNull,getAttrsByName,getImplicitAttrspecs,parentChildCount,getMandatoryAttrIds,allTagSpecs,getId,error,getMandatoryAnyofs,warn,getReferencePoints,getValuePropertyByName,disallowedRelativeUrl,match,getValueUrlSpec,hasReferencePoints,parentLastChildErrorLineCol,hasSeenUrl,getExtensions,firstSeenUrlTagName,parentLastChildUrl,getRules,invalidUrlProtocol,isExtensionLoaded,parentOnlyChildErrorLineCol,getMandatoryOneofs,getTagStack,allowedDescendantsList,hasTagSpecs,hasAttrWithName,getLine,getLineCol,addWarning,isAllowedProtocol,parentTagName,parentHasChildWithLastChildRule,invalidUrl,Result,getCssDeclarationByName,requires,missingUrl] | Output the given message to the console if it is not already logged. Check if there are any errors that match the errorCategoryFilter. If there are no errors. | not sure why `Publishing` is capitalized |
@@ -6,7 +6,7 @@ class UsersController < ApplicationController
def edit
unless current_user
skip_authorization
- return redirect_to "/enter"
+ return redirect_to new_user_registration_path_path
end
set_user
set_tabs(params["tab"] || "profile")
| [UsersController->[remove_association->[destroy,update],update->[update],onboarding_update->[update],add_org_admin->[update],update_twitch_username->[update],remove_org_admin->[update]]] | Edits a user s nag with tab and settings. | can we also change the alias into `new_user_registration_path` in routes? If it too much effort, let's stick with this one. |
@@ -149,7 +149,7 @@ namespace Kratos
// by using the ComputePlaneApproximation utility. Otherwise, the distance is computed using
// the plane defined by the 3 intersection points.
auto &r_geometry = rElement1.GetGeometry();
- const bool do_plane_approx = (n_cut_edges == r_geometry.WorkingSpaceDimension()) ? false : true;
+ const bool do_plane_approx = (n_cut_edges == r_geometry.WorkingSpaceDimension() || (int_pts_vector.size() < TDim)) ? false : true;
if (do_plane_approx){
// Call the plane optimization utility
| [No CFG could be retrieved] | The first three elements of the tetrahedra are the elements of the tetrahed 3D - based intersection plane. | Here I check if the number of intersection points is at least equal to Dim. In test 7, the tetrahedron with one edge laying on the horizontal plane at z = 0.0, had n_cut_edges > NDIM but only 2 intersection points, so the approximation utility was giving a plane which was not the horizontal one |
@@ -32,9 +32,9 @@ var (
Args: func(cmd *cobra.Command, args []string) error {
return checkAllAndLatest(cmd, args, false)
},
- Example: `podman checkpoint --keep ctrID
- podman checkpoint --all
- podman checkpoint --leave-running --latest`,
+ Example: `podman container checkpoint --keep ctrID
+ podman container checkpoint --all
+ podman container checkpoint --leave-running --latest`,
}
)
| [ID,Wrapf,Fprintln,IsRootless,Println,TODO,New,Shutdown,GetRuntime,Checkpoint,SetUsageTemplate,BoolVarP,Flags,BoolVar] | var initializes a command object that will checkpoint one or more running container. CheckpointValues returns checkpoint values for a container. | oops, ty for the fix up! |
@@ -0,0 +1,17 @@
+// Copyright 2016 Keybase, Inc. All rights reserved. Use of
+// this source code is governed by the included BSD license.
+
+package libkb
+
+import (
+ "io"
+ "github.com/keybase/client/go/logger"
+)
+
+func OutputWriter() io.Writer {
+ return logger.OutputWriter()
+}
+
+func ErrorWriter() io.Writer {
+ return logger.ErrorWriter()
+}
| [No CFG could be retrieved] | No Summary Found. | what is the point of this function and the one right below? |
@@ -98,7 +98,7 @@ func setUpTXGen() *node.Node {
fmt.Fprintf(os.Stderr, "Error :%v \n", err)
os.Exit(1)
}
- consensusObj, err := consensus.New(myhost, uint32(shardID), p2p.Peer{}, nil)
+ consensusObj, err := consensus.NewOneVotePerValidator(myhost, uint32(shardID), p2p.Peer{}, nil)
chainDBFactory := &shardchain.MemDBFactory{}
txGen := node.New(myhost, consensusObj, chainDBFactory, false) //Changed it : no longer archival node.
txGen.Client = client.NewClient(txGen.GetHost(), uint32(shardID))
| [Warn,ConstructTransactionListMessageAccount,Info,RunServices,Stop,New,Bool,Time,TerminalFormat,Coinbase,GetPublicKey,GetHost,NewClientGroupIDByShardID,AddNewBlock,Now,Blockchain,Exit,FileHandler,NewGroupIDByShardID,After,Logger,NumberU64,MultiHandler,PubkeyToAddress,ParentHash,SetRole,Str,Printf,Float32,StreamHandler,InstanceForEpoch,SetIsClient,NewInt,RandPrivateKey,GetNonce,Sleep,Float64,Root,ShardID,NewTransaction,NewHost,IsSameHeight,SetHandler,LoadKeyFromFile,Lock,NewClient,SetLogVerbosity,Lvl,Var,Hex,SendMessageToGroups,Uint64,DeserializeHexStr,Base,GetCurrentState,Err,NumNodesPerShard,StringsToAddrs,Msg,Sprintf,Transactions,String,Parse,Intn,ConstructP2pMessage,LogfmtFormat,Unlock,NewTicker,Int,Error,Seconds,Errorf,UpdateCurrent,Sub,Debug,SignTx,ServiceManagerSetup,Uint32,SetLogContext,Fprintf,DoSyncWithoutConsensus,CurrentBlock,SetShardGroupID,GetLogger] | setUpTXGen creates a new node with the given private key. This function is the main entry point for the node - level functions. It is responsible for. | One validator can have different voting power, instead of each one has equal power, we can add a field votingPower in consensus object which is calculated from their stake |
@@ -48,7 +48,7 @@ class LogElements(beam.PTransform):
self.with_timestamp = with_timestamp
self.with_window = with_window
- def expand(self, input):
+ def expand(self,input):
input | beam.ParDo(
self._LoggingFn(self.prefix, self.with_timestamp,
self.with_window))
| [LogElements->[_LoggingFn->[process->[str,print,repr,to_rfc3339],__init__->[super]],__init__->[super],expand->[ParDo,_LoggingFn]]] | Initialize LogElements with a sequence of log elements. | I believe we would like to keep the space there for consistency. |
@@ -1159,7 +1159,7 @@ function updateModuleHtml(module, id, name, gridDistX, gridDistY) {
.attr("id", id)
.attr("data-module-id", id)
.attr("data-module-name", name)
- .css("z-index", "");
+ .css("z-index", "20");
var panelHeading = module.find(".panel-heading");
| [No CFG could be retrieved] | Updates a virtual module with the given name and grid distance. Create dropdown menu and header. | module.css("z-index", "20") works also with integers => module.css("z-index", 20) please use single quote if it is possible |
@@ -136,6 +136,8 @@ TransportClient::enable_transport_using_config(bool reliable, bool durable,
}
passive_connect_duration_ = TimeDuration::from_msec(duration);
+ populate_connection_info();
+
const size_t n = tc->instances_.size();
for (size_t i = 0; i < n; ++i) {
| [No CFG could be retrieved] | 7. Set the fallback option if the global_config is empty. - - - - - - - - - - - - - - - - - -. | This is significantly different from what was there before. It's going to get all possible impl objects, not using `check_transport_qos`. |
@@ -270,7 +270,16 @@ class RenewableCert(object): # pylint: disable=too-many-instance-attributes
logger.debug("Expected symlink %s for %s does not exist.",
link, kind)
return None
- target = os.readlink(link)
+ try:
+ target = os.readlink(link)
+ except OSError as e:
+ if not e.errno is errno.EINVAL:
+ raise
+ raise errors.CertStorageError(
+ 'Expected %s to be a symlink to a file in %s, was a '
+ 'hard file. Did you modify the letsencrypt directory?' %
+ (link, self.cli_config.archive_dir))
+
if not os.path.isabs(target):
target = os.path.join(os.path.dirname(link), target)
return os.path.abspath(target)
| [RenewableCert->[available_versions->[current_target],next_free_version->[newest_available_version],should_autorenew->[ocsp_revoked,latest_common_version,version,autorenewal_is_enabled,add_time_interval],current_version->[current_target],names->[version,current_target],has_pending_deployment->[latest_common_version,current_version],latest_common_version->[available_versions],update_all_links_to->[_previous_symlinks,current_target,_update_link_to],__init__->[config_with_defaults],version->[current_target],save_successor->[next_free_version],new_lineage->[config_with_defaults],_fix_symlinks->[_previous_symlinks],should_autodeploy->[autodeployment_is_enabled,current_target,add_time_interval,has_pending_deployment],newest_available_version->[available_versions]]] | Returns the full path to the current version of the specified item currently points to. | Crap, Ive been doing too much ruby lately. This is not right |
@@ -33,7 +33,12 @@ function parsePattern(pattern) {
positive = patternParts[0],
negative = patternParts[1];
- var positiveParts = positive.split(DECIMAL_SEP),
+ // The parsing logic below assumes that there will always be a DECIMAL_SEP in the pattern.
+ // However, some locales (e.g. agq_CM) do not have one, thus we add one after the last ZERO
+ // (which is the last thing before the `posSuf` - if any).
+ // Note: We shouldn't modify `positive` directly, because it is used to parse the negative part.)
+ var positiveWithDecimalSep = ensureDecimalSep(positive),
+ positiveParts = positiveWithDecimalSep.split(DECIMAL_SEP),
integer = positiveParts[0],
fraction = positiveParts[1];
| [No CFG could be retrieved] | Parses a string into an object containing the min max and gSize values. - - - - - - - - - - - - - - - - - -. | I'm a bit confused by this. Does it mean if a locale doesn't have a DECIMAL_SEP, we add it after the last ZERO, which means it will be discarded later (because nothing comes after it)? So we only add it for the sake of parsing? |
@@ -24,10 +24,12 @@ import org.tron.protos.contract.BalanceContract.TransferContract;
public class BandwidthProcessor extends ResourceProcessor {
private Manager dbManager;
+ private ChainBaseManager chainBaseManager;
- public BandwidthProcessor(Manager manager) {
+ public BandwidthProcessor(Manager manager, ChainBaseManager chainBaseManager) {
super(manager.getDynamicPropertiesStore(), manager.getAccountStore());
this.dbManager = manager;
+ this.chainBaseManager = chainBaseManager;
}
@Override
| [BandwidthProcessor->[useAccountNet->[calculateGlobalNetLimit],updateUsage->[updateUsage]]] | Update the usage of a managed block. | the variable dbManager of BandwidthProcessor should be removed completely. The implementation that both Manager and ChainBaseManager reserved used as the combination inheritance is redundancy. So I advise that implementing the function getHeadSlot() in the ChainbaseManager and then removing the Manager from the BandwidthProcessor construction function. |
@@ -58,6 +58,8 @@
/*global jasmineRequire,jasmine,exports,specs*/
+ Cesium.RequestScheduler.prioritize = false;
+
var when = Cesium.when;
if (typeof paths !== 'undefined') {
| [No CFG could be retrieved] | Initialize the The main function that is called by the jasmine framework. | A lot of the specs fail if prioritization is enabled because it lags behind a frame. So I added this here for simplicity sake, but it's probably a bad place... |
@@ -40,6 +40,16 @@ except ImportError:
GCP_TEST_PROJECT = 'apache-beam-testing'
+CATALOG_ITEM = {
+ "id": str(int(random.randrange(100000))),
+ "title": "Sample laptop",
+ "description": "Indisputably the most fantastic laptop ever created.",
+ "language_code": "en",
+ "category_hierarchies": [{
+ "categories": ["Electronic", "Computers"]
+ }]
+}
+
def extract_id(response):
yield response["id"]
| [RecommendationAIIT->[test_create_catalog_item->[Create,int,CreateCatalogItem,ToList,str,assert_that,equal_to,ParDo,randrange,TestPipeline],test_predict->[Create,is_not_empty,assert_that,PredictUserEvent,ParDo,TestPipeline],test_create_user_event->[Create,ToList,assert_that,equal_to,ParDo,WriteUserEvent,TestPipeline]],skipIf,print,main,skip] | Extract the id from a response. | Do we want to choose a different id than this? if we can do a string, could we have something like a date or descriptive ID prefix? Maybe `"aitest-%s-%d" % (datetime.now(). strftime("%Y%m%d-%H%M"), int(random.randint(1,10000)))` or something. I also think that moving this to be global makes it harder to have multiple TestCases that create catalog items, but I'm not sure if we'll really be doing more tests. Would it make sense to have cleanup clean multiple items and not worry about the ID? like list + for each delete |
@@ -89,10 +89,10 @@ export class AmpSelector extends AMP.BaseElement {
this.clearAllSelections_();
return;
}
- let selectedArray = Array.isArray(newValue) ? newValue : [newValue];
+ const selectedArray = Array.isArray(newValue) ? newValue : [newValue];
// Only use first value if multiple selection is disabled.
if (!this.isMultiple_) {
- selectedArray = selectedArray.slice(0, 1);
+ selectedArray.length = 1;
}
// Convert array values to strings and create map for fast lookup.
const selectedMap = selectedArray.reduce((map, value) => {
| [No CFG could be retrieved] | Handles mutations of the selected attribute. Initializes the hidden input element with the selected options. | Ooof, sorry, but this introduced a bug itself. Imagine passing in `[]` as the newly selected values. Now, we change length to `1`, and we get `[undefined]` (sparse array implicit undefined). Sorry, but can you change this back? Or `Math.min(array.length, 1)` |
@@ -1,7 +1,5 @@
<?php
-if (!$os) {
- if (strstr($sysObjectId, '.1.3.6.1.4.1.388')) {
- $os = 'symbol';
- }
+if (str_contains('.1.3.6.1.4.1.388', $sysObjectId)) {
+ $os = 'symbol';
}
| [No CFG could be retrieved] | <?php if - > null ;. | Wrong way round :) |
@@ -35,7 +35,7 @@ func TestNewNode(t *testing.T) {
}
decider := quorum.NewDecider(quorum.SuperMajorityVote)
consensus, err := consensus.New(
- host, values.BeaconChainShardID, leader, blsKey, decider,
+ host, shard.BeaconChainID, leader, blsKey, decider,
)
if err != nil {
t.Fatalf("Cannot craeate consensus: %v", err)
| [AddPeers,NewHost,AddBeaconPeer,Blockchain,Exit,NewDecider,Error,New,GetBLSPrivateKeyFromInt,Errorf,Store,Equal,NoError,GenKeyP2P,Fatalf,Sleep,Println,CurrentBlock,ConstructPingMessage,GetPublicKey,RandPrivateKey,ElementsMatch,Run,SyncingPeers,NewPingMessage] | TestNewNode tests if a new node is a new node. TestLegacySyncingPeerProvider tests that the legacy syncing peer provider is available for the. | Actually this field should be "shard id", so if you want to refactor, better be "BeaconShardID". Because ChainID is a different thing than ShardID. |
@@ -262,10 +262,11 @@ module.exports = {
'overrides': [
{
'files': [
- 'test/**/*.js',
- 'extensions/**/test/**/*.js',
- 'extensions/**/test-e2e/*.js',
'ads/**/test/**/*.js',
+ 'examples/visual-tests/**/*.js',
+ 'extensions/**/test-e2e/*.js',
+ 'extensions/**/test/**/*.js',
+ 'test/**/*.js',
'testing/**/*.js',
],
'rules': {
| [No CFG could be retrieved] | Manages the requirements of a specific license header. JSDoc - specific configuration of the module. | `for...of` is fine to use on tests because they either run on node or they're transpiled down. |
@@ -313,7 +313,8 @@ namespace ILCompiler
}
CompilationBuilder builder = new ReadyToRunCodegenCompilationBuilder(typeSystemContext, compilationGroup, inputFilePath,
ibcTuning: _commandLineOptions.Tuning,
- resilient: _commandLineOptions.Resilient);
+ resilient: _commandLineOptions.Resilient,
+ parallelism: _commandLineOptions.Parallelism);
string compilationUnitPrefix = "";
builder.UseCompilationUnitPrefix(compilationUnitPrefix);
| [Program->[Run->[ProcessCommandLine,InitializeDefaultOptions],InnerMain->[Run,DumpReproArguments]]] | Runs the type system context. Checks if a file is managed and if so determines if a method is required and if so Creates a list of all modules that can be compiled and run. This method is called to build a codegen object. | I'd prefer to see this passed to the builder via the fluent interface pattern like the use of UseBackendOptions below. |
@@ -3763,9 +3763,9 @@ static int test_ciphersuite_change(void)
# if !defined(OPENSSL_NO_CHACHA) && !defined(OPENSSL_NO_POLY1305)
/* Check we can resume a session with a different SHA-256 ciphersuite */
if (!TEST_true(SSL_CTX_set_ciphersuites(cctx,
- "TLS_CHACHA20_POLY1305_SHA256"))
- || !TEST_true(create_ssl_objects(sctx, cctx, &serverssl, &clientssl,
- NULL, NULL))
+ "TLS_AES_128_CCM_SHA256"))
+ || !TEST_true(create_ssl_objects(sctx, cctx, &serverssl,
+ &clientssl, NULL, NULL))
|| !TEST_true(SSL_set_session(clientssl, clntsess))
|| !TEST_true(create_ssl_connection(serverssl, clientssl,
SSL_ERROR_NONE))
| [No CFG could be retrieved] | Creates a new connection or server SSL object based on the server and client ciphersuites. Find the n - tuple of the server and server SSL connections. | These ifdef's are no longer relevant if CHACHA is removed here.. |
@@ -201,6 +201,7 @@ function ping_init(App $a)
if (is_null($ev)) {
$ev = qu("SELECT count(`event`.`id`) AS total, type, start, adjust FROM `event`
WHERE `event`.`uid` = %d AND `start` < '%s' AND `finish` > '%s' and `ignore` = 0
+ GROUP BY type, start, adjust
ORDER BY `start` ASC ",
intval(local_user()),
dbesc(datetime_convert('UTC', 'UTC', 'now + 7 days')),
| [ping_init->[is_friendica_app]] | Ping init function This function is used to provide a callback to the user when a notification is received. This function is used to determine what unseen network posts are spread across groups and forums Descripcion de la nueva en la nueva en la nue This function is called to populate the data array with all the data from the notification. | As suggested by line 219-220 below, `$ev` is supposed to be an array of the events in the next 7 days. The `COUNT` seems to be superfluous here, as it can be obtained by doing `count($ev)`. |
@@ -10,6 +10,9 @@ import java.util.concurrent.Executors;
import java.util.logging.Level;
import java.util.logging.Logger;
+import com.google.common.annotations.VisibleForTesting;
+import com.google.common.base.Preconditions;
+
import games.strategy.engine.message.ConnectionLostException;
import games.strategy.engine.message.HubInvocationResults;
import games.strategy.engine.message.HubInvoke;
| [UnifiedMessenger->[isServer->[isServer],messageReceived->[assertIsServer,send],getLocalNode->[getLocalNode],toString->[isServer],removeImplementor->[removeImplementor],addImplementor->[addImplementor],send->[send,getLocalNode]]] | Package for importing the UnifiedMessenger class. this is called when the hub is ready to return invocations. | The `games.strategy.util.ThreadUtil` import is no longer used. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.