patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -101,7 +101,9 @@ def pane_more_addons(request, section, version, platform, compat_mode=None):
ctx = {'featured_addons': from_api('featured')}
elif section == 'up-and-coming':
ctx = {'up_and_coming': from_api('hotness')}
- return render(request, 'legacy_discovery/more_addons.html', ctx)
+
+ ... | [pane_more_addons->[from_api,get_compat_mode],pane->[from_api,get_compat_mode],pane_promos->[promos,get_compat_mode]] | Returns a list of more addons. | Irrelevant, I used this for debugging. I'll remove this and a few other unrelated changes. |
@@ -30,7 +30,7 @@ p = figure(plot_width=800, plot_height=300, title="US unemployment 1948—2016",
p.rect(x="Year", y="Month", width=1, height=1, source=source,
line_color=None, fill_color=transform('rate', mapper))
-color_bar = ColorBar(color_mapper=mapper, location=(0, 0),
+color_bar = ColorBar(color_mapper=... | [PrintfTickFormatter,max,reversed,DataFrame,transform,figure,astype,show,output_file,rect,min,set_index,drop,ColumnDataSource,LinearColorMapper,list,len,add_layout,ColorBar,BasicTicker] | This function creates a plot of the NYTimes data. | just making sure I understand: the default location for colorbars is now outside the plot? I'm for that, but needs a release note |
@@ -87,7 +87,7 @@ module Dependabot
if ENV["DEBUG_FUNCTION"] == function
puts helper_subprocess_bash_command(stdin_data: stdin_data, command: cmd, env: env)
# Pause execution so we can run helpers inside the temporary directory
- byebug # rubocop:disable Lint/Debugger
+ binding.br... | [run_shell_command->[escape_command],run_helper_subprocess->[escape_command]] | Runs a helper subprocess that returns the result of running the given block of code. if the context is not found raise an exception. | Could have used the generic `debugger` here which is aliased in most (all?) debuggers, but |
@@ -57,14 +57,14 @@ class _TypeMetaclass(ABCMeta):
_typecache[wr] = wr
return inst
- def __call__(cls, *args, **kwargs):
+ def __call__(cls, *args: pt.Any, **kwargs: pt.Any) -> "Type":
"""
Instantiate *cls* (a Type subclass, presumably) and intern it.
If an i... | [Type->[_determine_array_spec->[validate_slice]],_TypeMetaclass->[__call__->[__call__,_intern],_intern->[_autoincr]],Poison->[__unliteral__->[Poison]]] | Intern a object. | if you accept the suggestion about `NumbaTypeInst` then it would apply here and everywhere else where it says Type. |
@@ -300,6 +300,16 @@ export class AmpDoc {
contains(node) {
return this.getRootNode().contains(node);
}
+
+ /**
+ * Binding of macro to function used as part of any installed anchor click
+ * listener.
+ * @return {!Object<string, Object<string, string>>}
+ * @see src/anchor-click-interceptor#instal... | [No CFG could be retrieved] | Provides a function to check if a node is in the DOM of the root document. Provides a function to check if a node is a single document. | seems change in this file not needed anymore |
@@ -119,7 +119,11 @@ namespace System.Net.Http
}
_http2Enabled = _poolManager.Settings._maxHttpVersion >= HttpVersion.Version20;
- _http3Enabled = _poolManager.Settings._maxHttpVersion >= HttpVersion.Version30 && (_poolManager.Settings._quicImplementationProvider ?? QuicImplementa... | [No CFG could be retrieved] | Initializes the HTTP connection pool. This method is used to set the configuration variables for a specific connection kind. | Hm, OSX should be accounted as MacOS but somehow that logic is left out of the analyzer, i will fix that soon. Could you use macOS for the attribute as a workaround `<SupportedOSPlatforms>Windows;Linux;MacOS</SupportedOSPlatforms>`? |
@@ -321,6 +321,7 @@ class DistributeTranspiler:
inputs={"X": splited_vars},
outputs={},
attrs={
+ "sync_mode": True,
"epmap": eplist,
RPC_OP_ROLE_ATTR_NAME: RPC_OP_ROLE_ATTR_VALUE
})
| [DistributeTranspiler->[_is_op_connected->[_append_inname_remove_beta],_append_pserver_ops->[_get_optimizer_input_shape,same_or_split_var],get_startup_program->[_get_splited_name_and_shape->[same_or_split_var],_get_splited_name_and_shape],_create_ufind->[_is_op_connected],_orig_varname->[_get_varname_parts],_get_optimi... | Transpiles a single n - node critical sequence. step 3. 2 - send the n - c - send op. Insert recv op to receive parameters from parameter server and insert send op to send parameters from parameter. | This seems temporary. Can you create an issue and assign to you and me? I feel that I need to think a bit more about it. |
@@ -54,3 +54,12 @@ def password(statement):
"""
logger.info(f"{statement}: ")
return getpass("")
+
+
+def path_input():
+ """Ask the user for a path.
+
+ Returns:
+ str: path entered by the user.
+ """
+ return _ask("")
| [_ask->[input,info,format,isatty],password->[info,getpass],confirm->[_ask,startswith],getLogger] | Ask the user for a password. str. | This one is only used in check-ignore, so let's make `ask` public and use it directly in `check-ignore`. |
@@ -85,10 +85,7 @@ class Configuration implements ConfigurationInterface
->arrayNode('upload')
->addDefaultsIfNotSet()
->children()
- ->integerNode('max_filesize')
- ->defaultValue(256)
- ->min(0)
- ... | [Configuration->[addObjectsSection->[end],getConfigTreeBuilder->[root,addObjectsSection,end]]] | This method returns a TreeBuilder instance for the SuluMediaBundle configuration This method is used to configure a cache object with max_filesize. Adds the tree builder for the given mime - types. | For BC we should not change this type and keep this file as before |
@@ -267,7 +267,10 @@ class URLFetchStrategy(FetchStrategy):
@property
def curl(self):
if not self._curl:
- self._curl = which('curl', required=True)
+ try:
+ self._curl = which('curl', required=True)
+ except CommandNotFoundError as exc:
+ ... | [_from_merged_attrs->[fetcher],SvnFetchStrategy->[_remove_untracked_files->[svn],fetch->[svn],reset->[svn,_remove_untracked_files]],for_package_version->[_from_merged_attrs,check_pkg_attributes,_extrapolate,_check_version_attributes,fetcher,BundleFetchStrategy],from_list_url->[URLFetchStrategy],_extrapolate->[URLFetchS... | Returns a object that can be used to identify a curl result. | Just to make sure I understand what's going on: This is because the calling code is a try/except block that catches the error? |
@@ -49,7 +49,8 @@ public class ElasticsearchConfig
{
public enum Security
{
- AWS
+ AWS,
+ PASSWORD,
}
private String host;
| [ElasticsearchConfig->[getKeystorePath->[ofNullable],getTruststorePassword->[ofNullable],getKeystorePassword->[ofNullable],getTrustStorePath->[ofNullable],getSecurity->[ofNullable],availableProcessors,Duration]] | Creates an instance of ElasticsearchConfig. The ElasticsearchConfig class. | add comma at the end |
@@ -223,7 +223,6 @@ func (s *RollingDeploymentStrategy) Deploy(from *corev1.ReplicationController, t
Timeout: time.Duration(*params.TimeoutSeconds) * time.Second,
MinReadySeconds: config.Spec.MinReadySeconds,
CleanupPolicy: PreserveRollingUpdateCleanupPolicy,
- MaxUnavailable: *params.MaxUnavailabl... | [Deploy->[Percentage,Fprintln,Execute,Get,getUpdateAcceptor,Sprintf,NewConditionReachedErr,rollingUpdate,DecodeDeploymentConfig,Duration,DeployWithAcceptor,Poll,ReplicationControllers,Errorf,RecordConfigWarnings,IsNotFound,LabelForDeployment,Update],Write->[Split,HasPrefix,Fprintln,HasSuffix],CoreV1,NewHookExecutor,New... | Deploy attempts to deploy a deployment from one replication controller to another. prepareForRollingUpdate prepares a rolling update of a deployment. This function is used to get a single cluster cluster cluster cluster cluster cluster cluster cluster cluster cluster MaxSurge and MaxUnavailable are optional. | @tnozicka removed because we set this below if not nil... i think this worked when we did conversion from internal? I wonder if we are not losing the default (1) or it is defaulted on server side. |
@@ -0,0 +1,3 @@
+<?php
+
+echo json_encode($vars);
\ No newline at end of file
| [No CFG could be retrieved] | No Summary Found. | Here we would implement some sort of serializer. IMO, we should make `ElggEntity` implement `Serializable` |
@@ -40,7 +40,7 @@
primaryTermInput = $( '#yoast-wpseo-primary-' + taxonomyName );
- primaryTermInput.val( termId );
+ primaryTermInput.val( termId ).trigger('change');
}
/**
| [No CFG could be retrieved] | Checks if the elements to make a term the primary term and the display for a primary term Find the term that is checked and show it in the interface. | Missing spaces before and after `'change'`. |
@@ -227,11 +227,9 @@ namespace Content.Server.Administration
}
}
- private string GenerateAHelpMessage(string username, string message, bool admin, bool noReceiver)
+ private string GenerateAHelpMessage(string username, string message, bool admin)
{
var string... | [BwoinkSystem->[Initialize->[Initialize],Update->[ProcessQueue,Update],ProcessQueue->[Header],Shutdown->[Shutdown],OnBwoinkTextMessage->[OnBwoinkTextMessage]]] | Override OnBwoinkTextMessage to add a bwoink message to the list of Generate a help message in a channel. | why remove this? |
@@ -115,6 +115,12 @@ import static org.springframework.data.jpa.domain.Specifications.where;
description = "Groups operations")
@Controller("groups")
public class GroupsApi {
+ /**
+ * Group name pattern with allowed chars. Group name may only contain alphanumeric characters or single hyphens.
+ * Can... | [GroupsApi->[getGroups->[getGroups],getImage->[getImage]]] | Provides a list of all groups in the system. This is a utility method to provide a message to the user. | This regular expression doesn't match what is described in the description of the PR: > * **Group names:** Alphanumeric characters or single hyphens. Cannot begin or end with a hyphen. |
@@ -20,8 +20,11 @@ namespace Content.Server.Atmos.Components
{
public override string Name => "Barotrauma";
- [DataField("damageType", required: true)]
- private readonly string _damageType = default!;
+ // TODO PROTOTYPE Replace this datafield variable with prototype references, on... | [BarotraumaComponent->[Update->[HazardHighPressure,Owner,Pressure,Max,ChangeDamage,ShowAlert,Min,HazardLowPressure,MaxHighPressureDamage,AggressiveInlining,TryGetComponent,LowPressure,LowPressureMultiplier,WarningHighPressure,HighPressure,PressureDamageCoefficient,LowPressureDamage,HighPressureMultiplier,GetDamageType,... | Updates the alert with a new air pressure. - Check if there is an alert category in the list of alert categories. | just import Robust.Shared.IoC and use [Dependency] |
@@ -37,12 +37,12 @@ class RGtools(RPackage):
match ('smartbind')
- generate significance stars from p-values ('stars.pval')
- convert characters to/from ASCII codes.
-
"""
homepage = "https://cloud.r-project.org/package=gtools"
url = "https://cloud.r-project.org/src/contrib/gtools... | [RGtools->[version]] | Get a list of significance stars for a given p - value. | Spack removes newline characters from the description when running `spack info`, so this won't format well. Maybe add semicolons at the end of each bullet point? |
@@ -282,8 +282,10 @@ var _ = g.Describe("idling and unidling", func() {
})
g.It("should work with TCP (when fully idled) [Conformance] [local]", func() {
+ err := exutil.WaitForUserBeAuthorized(oc, oc.Username(), "create", "endpoints/restricted")
+ o.Expect(err).ToNot(o.HaveOccurred())
g.By("Idling the ... | [Context,KubeClient,By,XIt,BeTemporally,CoreV1,TempFile,Expect,Now,HaveOccurred,Close,SetDeadline,HaveKey,FixturePath,It,Eventually,ReadFromUDP,DialUDP,ShouldNot,Add,Done,Should,Args,To,Errorf,Services,Namespace,Wait,KubeFramework,ContainSubstring,BeNil,Join,Equal,Output,NewCLI,BeEmpty,BeforeEach,Endpoints,Name,Remove,... | BeforeEach - Tests the tests for the Ethereum Ethereum service. Expects that the service is running in the idle state. | Where is this permission being added? |
@@ -188,7 +188,7 @@ namespace System.Data.Common
return (DbProviderFactory)factory;
}
-
+ [RequiresUnreferencedCode(DataSet.RequiresUnreferencedCodeMessage)]
private static Type GetProviderTypeFromTypeName(string assemblyQualifiedName)
{
Type? providerType =... | [DbProviderFactories->[RegisterFactory->[RegisterFactory],GetFactory->[RegisterFactory]]] | Get the factory instance. | Same here, we should probably adjust message to just say here that the reason why this is unsafe is because we are calling Type.GetType(string) #Closed |
@@ -1237,13 +1237,7 @@ public final class OpenSslEngine extends SSLEngine {
}
String prefix = toJavaCipherSuitePrefix(SSL.getVersion(ssl));
- String converted = CipherSuiteConverter.toJava(openSslCipherSuite, prefix);
- if (converted != null) {
- openSslCipherSuite = convert... | [OpenSslEngine->[closeInbound->[shutdown],finalize->[finalize,shutdown],handshake->[shutdown],closeOutbound->[shutdown],getSession->[getPeerPrincipal->[getPeerCertificates],getLastAccessedTime->[getCreationTime],getPeerCertificates->[initPeerCertChain],getLocalPrincipal->[getLocalCertificates]],memoryAddress->[memoryAd... | converts the cipher suite to the Java cipher suite. | so `CipherSuiteConverter.toJava` can not return null ? |
@@ -86,8 +86,10 @@ func (m OpInfluence) GetRegionsInfluence() map[uint64]*Operator {
// StoreInfluence records influences that pending operators will make.
type StoreInfluence struct {
RegionSize int64
+ RegionRows int64
RegionCount int64
LeaderSize int64
+ LeaderRows int64
LeaderCount int64
}
| [GetAdjacentRegions->[GetAdjacentRegions],GetLeaderStore->[GetStore],GetStore->[GetStore],GetAverageRegionSize->[GetAverageRegionSize],RandLeaderRegion->[RandLeaderRegion],GetRegionStores->[GetStore],UnblockStore->[UnblockStore],RandFollowerRegion->[RandFollowerRegion],GetRegion->[GetRegion],GetStores->[GetStores],Bloc... | ResourceSize returns the size of a resource in bytes. | I think we can exclude `RegionRows` and `LeaderRows` in `StoreInfluence`. |
@@ -329,7 +329,7 @@ class HadoopFileSystemTest(unittest.TestCase):
url = self.fs.join(self.tmpdir, 'new_file')
handle = self.fs.create(url)
self.assertIsNotNone(handle)
- url = self.fs._parse_url(url)
+ _, url = self.fs._parse_url(url)
expected_file = FakeFile(url, 'wb')
self.assertEqual(... | [FakeHdfs->[write->[FakeHdfsError,FakeFile],checksum->[FakeHdfsError,get_file_checksum],status->[get_file_status,FakeHdfsError],makedirs->[FakeFile],walk->[status],delete->[status,list,FakeHdfsError],list->[get_file_status],read->[write,FakeHdfsError,FakeFile],rename->[status,FakeHdfsError]],HadoopFileSystemTest->[test... | Create a new file with a specific name and write it to disk. | Test `server` is None, here and below? |
@@ -1,3 +1,4 @@
from .settings import *
SECRET_KEY = 'NOTREALLY'
+OPENEXCHANGE['APP_ID'] = SECRET_KEY
\ No newline at end of file
| [No CFG could be retrieved] | Set the default secret key for the user. | Not sure why it does that. These two are unrelated. Missing endline. |
@@ -124,7 +124,7 @@ class VirtualHost(object): # pylint: disable=too-few-public-methods
strip_name = re.compile(r"^(?:.+://)?([^ :$]*)")
def __init__(self, filep, path, addrs, ssl, enabled, name=None,
- aliases=None, modmacro=False, ancestor=None):
+ aliases=None, modmacro=F... | [VirtualHost->[__hash__->[get_names],same_server->[get_names],__eq__->[get_names],__ne__->[__eq__],conflicts->[conflicts],display_repr->[get_names]],Addr->[get_sni_addr->[is_wildcard],conflicts->[_addr_less_specific],__ne__->[__eq__]]] | Initialize a VH object. | We should put this parameter as an attribute in the docstring above. |
@@ -61,6 +61,10 @@ public class MyAccount extends AnkiActivity {
Toolbar mToolbar = null;
private TextInputLayout mPasswordLayout;
+ private ImageView mAnkidroidLogo;
+
+ private OrientationEventListener myOrientationEventListener ;
+
private void switchToState(int newState) {
switch (... | [MyAccount->[onPostExecute->[saveUserInformation,switchToState],logout->[switchToState],login->[login],initAllContentViews->[logout,resetPassword,attemptLogin,login],onCreate->[onCreate,switchToState],onKeyDown->[onKeyDown]]] | Switch to a specific state. | I think both of these can be moved inside the method. They're only used in `initAllContentViews` |
@@ -42,11 +42,7 @@ import org.apache.hadoop.ozone.client.io.OzoneInputStream;
import org.apache.hadoop.ozone.client.io.OzoneOutputStream;
import org.apache.hadoop.ozone.om.OMConfigKeys;
import org.apache.hadoop.ozone.om.exceptions.OMException;
-import org.apache.hadoop.ozone.om.helpers.OmMultipartInfo;
-import org.a... | [No CFG could be retrieved] | Imports the objects from the OOM library. Imports the Ozone object and creates a client - side object. | Please replace star import with individual imports. |
@@ -16,7 +16,7 @@ func ToProto(user string, namespace string, rl rulefmt.RuleGroup) *RuleGroupDesc
rg := RuleGroupDesc{
Name: rl.Name,
Namespace: namespace,
- Interval: &dur,
+ Interval: dur,
Rules: formattedRuleToProto(rl.Rules),
User: user,
}
| [FromMap,FromLabelsToLabelAdapters,GetAlert,GetFor,Duration,GetName,GetRules,FromLabelAdaptersToLabels,Map,GetExpr,GetRecord] | ToProto imports a formatted prometheus rulegroup to a protobuf rule group Get formatted RuleGroup for a given duration. | Now there's no more need to assign `dur` above. You can just call `time.Duration(rl.Interval)` here. |
@@ -467,8 +467,12 @@ def analyze_class_attribute_access(itype: Instance,
return builtin_type('types.ModuleType')
if is_decorated:
- # TODO: Return type of decorated function. This is quick hack to work around #998.
- return AnyType(TypeOfAny.special_form)
+ assert isinstance(node.no... | [add_class_tvars->[add_class_tvars],analyze_class_attribute_access->[handle_partial_attribute_type],bind_self->[expand,bind_self],analyze_member_access->[analyze_member_access]] | Analyze a class attribute access. Return the type of . | I thought that we normally return `TypeOfAny.from_error` in all cases where the may be an error. |
@@ -66,6 +66,11 @@ class Geolocalization(graphene.ObjectType):
class Shop(graphene.ObjectType):
available_payment_gateways = graphene.List(
graphene.NonNull(PaymentGateway),
+ currency=graphene.Argument(
+ graphene.String,
+ description="A currency for which gateways will be ... | [Shop->[resolve_translation->[resolve_translation],resolve_navigation->[Navigation],resolve_domain->[Domain],resolve_geolocalization->[Geolocalization]]] | A class that represents a specific authorization key. True if the object is not null. | Not sure of this. - How storefront will fetch what currencies are available for the shop? - IMO `PaymentGateway` type should also have a field `currencies` or `supported_currencies`. - It would be easier for storefronts with multiple currencies support. |
@@ -142,7 +142,7 @@ def reindex_tasks_group(index_name):
from olympia.stats.management.commands.index_stats import (
gather_index_stats_tasks
)
- return gather_index_stats_tasks(index_name)
+ return group(gather_index_stats_tasks(index_name))
def get_mappings():
| [extract_download_count->[es_dict],create_new_index->[get_alias],extract_update_count->[es_dict]] | Return a group of tasks to execute for a full reindex of stats on the given index_. | Goes with the change mentioned above, for consistency both `reindex_tasks_group` functions for stats and addons return a flat `group` of tasks. |
@@ -236,7 +236,7 @@ public class HoodieInputFormatUtils {
return false;
})
.collect(Collectors.joining(","));
- return Option.of(incrementalInputPaths);
+ return StringUtils.isNullOrEmpty(incrementalInputPaths) ? Option.empty(): Option.of(incrementalInputPaths);
}
/**
| [HoodieInputFormatUtils->[filterFileStatusForSnapshotMode->[getFileStatus],getInputFormat->[getInputFormat],getFilteredCommitsTimeline->[filterInstantsTimeline],filterIncrementalFileStatus->[getFileStatus],getFileStatus->[getFileStatus],refreshFileStatus->[getFileStatus]]] | Returns the list of partitions that have incremental changes. Returns an Option that can be used to specify the input paths that are not yet in the. | Looks fine, can we have some test case there ? |
@@ -33,13 +33,13 @@ spec:
name: http
protocol: HTTP
hosts:
- - <%= app.baseName.toLowerCase() %>.<%= kubernetesNamespace %><%= ingressDomain %>
+ - <%= app.baseName.toLowerCase() %>.<%= ingressDomain %>
- port:
number: 80
name: http2
protocol: HTTP2
hosts:
- - <%... | [No CFG could be retrieved] | This function returns a description of the object that represents a single . Exception - handler for the N - HTTP - Gateway response. | I see no harm in having the host name like this (without K8s namespace). Since this will be deployed to a specific namespace, 'host' would get resolved automatically. But, as you know, in general, services (normal/headless) in k8s (without any modification) get assigned a default DNS 'A' name record of the form {servic... |
@@ -65,3 +65,6 @@ class CommunicationIdentityClientTest(CommunicationTestCase):
identity_client.delete_user(user)
assert user.identifier is not None
+
+ def get_endpoint_from_connection_string(self, connection_string):
+ return connection_string.split("=")[1].split("/;")[0]
| [CommunicationIdentityClientTest->[test_create_user->[create_user,from_connection_string],test_delete_user->[create_user,delete_user,from_connection_string],test_revoke_tokens->[create_user,revoke_tokens,issue_token,from_connection_string],test_issue_token->[create_user,issue_token,from_connection_string],setUp->[super... | Test delete user. | inside `_shared/utils` there is a method for parsing connection string. Let's use that. |
@@ -16,8 +16,11 @@ class Admin {
* Construction.
*/
public function __construct() {
- add_action( 'admin_menu', array( $this, 'register_submenu_page' ), 1000 );
- add_action( 'admin_enqueue_scripts', array( $this, 'enqueue_scripts' ) );
+ if ( ! did_action( 'jetpack_on_connection_ui_init' ) ) {
+ add_actio... | [Admin->[get_initial_state->[render],enqueue_scripts->[get_initial_state]]] | This method is called by the constructor of the class. | Do you think you could add a docblock here for this new hook? The docblocks make it possible to extract data into a codex, and may be useful for our future selves needing to use that hook. :) |
@@ -116,6 +116,12 @@ SHOWFOR_DATA = {
}
+def _remove_en_slug_prefix(slug):
+ if slug.startswith('en/'):
+ slug = slug.replace('en/', '')
+ return slug
+
+
def process_document_path(func, reverse_name='wiki.document'):
"""Decorator to process document_path into locale and slug, with
auto-red... | [edit_document->[_get_document_for_json,_join_slug,_split_slug,_format_attachment_obj],get_children->[_make_doc_structure->[_make_doc_structure],_make_doc_structure],_document_PUT->[_split_slug],mindtouch_to_kuma_redirect->[mindtouch_namespace_redirect],json_view->[_get_document_for_json],new_attachment->[_format_attac... | Decorator to process document_path into locale and slug with auto - redirect if necessary. Process a sequence number. | Do we know why this is happening in slugs? This seems like a band-aid fix. And I ask this because... is "en/" special? why? will we have a similar issue with other things that look like legacy Mindtouch locales? |
@@ -28,7 +28,7 @@ namespace System.IO.Pipes
SafePipeHandle? clientHandle = null;
try
{
- socket.Connect(new UnixDomainSocketEndPoint(_normalizedPipePath));
+ socket.Connect(new UnixDomainSocketEndPoint(_normalizedPipePath!));
clientHa... | [NamedPipeClientStream->[TryConnect->[SocketErrorCode,Stream,Unix,ConfigureSocket,Asynchronous,Connected,ConnectionRefused,Dispose,Connect,AddressNotAvailable,Unspecified,ValidateRemotePipeUser,AddressAlreadyInUse,InitializeHandle],ValidateRemotePipeUser->[CreateExceptionForLastError,GetPeerID,GetEUid,UnauthorizedAcces... | Try to connect to the pipe. | Assume it is intended #Closed |
@@ -155,6 +155,10 @@ public class MuleClassPathClassifier implements ClassPathClassifier
pluginClassifications.add(extensionClassPathClassification(extensionClass, extensionMavenArtifactId, extendedContext));
}
}
+ else
+ {
+ logger.debug("There are no ext... | [MuleClassPathClassifier->[extensionClassPathClassification->[createExtensionManager]]] | Build the list of plugin classifications for the given extension. add plugin classifications. | in the classpath |
@@ -1896,13 +1896,11 @@ public class Jenkins extends AbstractCIBase implements DirectlyModifiableTopLeve
// even if we want to offer this atomic operation, CopyOnWriteArrayList
// offers no such operation
public void setViews(Collection<View> views) throws IOException {
- BulkChange bc = new BulkC... | [Jenkins->[getUser->[get],_cleanUpShutdownTcpSlaveAgent->[add],setNumExecutors->[updateComputerList],getPlugin->[getPlugin],getCategorizedManagementLinks->[all,add],getViewActions->[getActions],getJDK->[getJDKs,get],setViews->[addView],getCloud->[getByName],getStaplerFallback->[getPrimaryView],getStoredVersion->[get],g... | Sets the views in this view group. | This doesn't look like it's the same, but it also looks like it might fix a bug ? |
@@ -1,15 +1,15 @@
package cmds
import (
- "encoding/json"
"fmt"
"io"
"os"
"text/tabwriter"
+ "github.com/Jeffail/gabs"
"github.com/golang/protobuf/jsonpb"
"github.com/pachyderm/pachyderm"
- "github.com/pachyderm/pachyderm/src/client"
+ pach "github.com/pachyderm/pachyderm/src/client"
ppsclient "gith... | [InspectJob,MustAsset,Close,PrintJobInfo,ErrorAndExit,RunFixedArgs,CreateJob,Flush,Error,PrintPipelineInfo,Usage,ListPipeline,NewFromAddress,StringVarP,GetLogs,RunPipelineSpec,NewWriter,DeletePipeline,CreateJobRequest,CreatePipeline,InspectPipeline,NewDecoder,MarshalToString,PrintJobHeader,Println,PrintPipelineHeader,S... | cmds import imports a list of commands from the given address. exampleCreateJob creates a new job from a pipeline spec. | I've been using `c` for the variable name to avoid this conflict. But this works too. |
@@ -34,15 +34,18 @@ class OutputStream(object):
def __init__(self):
self.data = []
+ self.byte_count = 0
def write(self, b, nested=False):
assert isinstance(b, bytes)
if nested:
self.write_var_int64(len(b))
self.data.append(b)
+ self.byte_count += len(b)
def write_byte(se... | [ByteCountingOutputStream->[write->[write_var_int64]],InputStream->[read_all->[size,read],read_bigendian_int32->[read],read_bigendian_double->[read],read_bigendian_uint64->[read],read_bigendian_int64->[read]],OutputStream->[write_bigendian_int32->[write],write_bigendian_uint64->[write],write_bigendian_int64->[write],wr... | Initialize object. | Nit: Shall we rely on ` len(self.data)` instead of creating and managing a new field. |
@@ -54,7 +54,8 @@ def type_callable(func):
_overload_default_jit_options = {'no_cpython_wrapper': True}
-def overload(func, jit_options={}, strict=True, inline='never'):
+def overload(func, jit_options={}, strict=True, inline='never',
+ signatures=None):
"""
A decorator marking the decorated ... | [register_jitable->[wrap->[overload],wrap],_Intrinsic->[__reduce__->[reduce_func],_rebuild->[_register,_set_uuid]],make_attribute_wrapper->[struct_getattr_impl->[get_attr_fe_type],StructAttribute->[generic_resolve->[get_attr_fe_type]]],BoundLiteralArgs->[bind->[sentry_literal_args]],overload_attribute->[decorate->[over... | A function decorator to overload a function with a Numba type. Load template function with missing parameters. | The signatures arguments can be removed for this PR. |
@@ -431,7 +431,7 @@ app.use(['/examples/*', '/extensions/*'], function (req, res, next) {
next();
});
-app.get('/examples/*', function(req, res, next) {
+app.get(['/examples/*', '/test/manual/*'], function(req, res, next) {
var filePath = req.path;
var mode = getPathMode(filePath);
if (!mode) {
| [No CFG could be retrieved] | Proxy with unminified JS. Replace URLs in file with absolute paths. | Could you explain a lit what does this do? |
@@ -184,6 +184,17 @@ class Wallets:
return 0
possible_stake = (available_amount + val_tied_up) / self._config['max_open_trades']
+
+ # Position Adjustment dynamic base order size
+ try:
+ if self._config.get('position_adjustment_enable', False):
+ base_sta... | [Wallets->[get_available_stake_amount->[get_free,get_total_stake_amount],get_starting_balance->[get_free],get_trade_stake_amount->[_check_available_stake_amount,get_available_stake_amount,update,_calculate_unlimited_stake_amount,get_free,get_total],update->[_update_live,_update_dry],validate_stake_amount->[get_availabl... | Calculate unlimited stake amount for unlimited trades. | Do we really need this as a parameter? considering we have `custom_stake_amount` to customize stake-amount - we could also just defer this logic to the strategy (it get's the "proposed stake" - so you can just do `proposed_stake / max_entries` in the strategy. Also, assuming your "scaling in" depends on the situation /... |
@@ -418,7 +418,10 @@ abstract class WPSEO_Option {
public function register_setting() {
if ( WPSEO_Capability_Utils::current_user_can( 'wpseo_manage_options' ) ) {
if ( $this->multisite_only === true ) {
- Yoast_Network_Settings_API::get()->register_setting( $this->group_name, $this->option_name );
+ $ne... | [WPSEO_Option->[clean->[get_original_option],get_original_option->[add_option_filters,remove_option_filters,add_default_filters,remove_default_filters],array_filter_merge->[get_defaults],register_setting->[register_setting],validate->[get_defaults,remove_default_filters],import->[update_site_option,get_defaults],update... | Register the current setting. | Is there any way to combat this extra level of nesting? |
@@ -145,6 +145,16 @@ OPENSSL_CTX *OPENSSL_CTX_new(void)
return ctx;
}
+#ifndef FIPS_MODE
+int OPENSSL_CTX_load_config(OPENSSL_CTX *ctx, const char *config_file)
+{
+ if (!OPENSSL_init_crypto(OPENSSL_INIT_LOAD_CONFIG, NULL))
+ return 0;
+
+ return CONF_modules_load_file_with_libctx(ctx, config_file,... | [openssl_ctx_run_once->[openssl_ctx_get_concrete],openssl_ctx_get_data->[openssl_ctx_get_concrete],openssl_ctx_get_ex_data_global->[openssl_ctx_get_concrete],int->[openssl_ctx_get_concrete]] | OpensSSL_CTX_new - creates new OPENSSL_CTX object if not. | Why is this needed? It seems unnecessary? |
@@ -201,6 +201,12 @@ public final class UnitChooser extends JPanel {
final Collection<Unit> units,
final UnitSeparator.SeparatorCategories separatorCategories,
final Collection<Unit> defaultSelections) {
+ spaceRequiredForNonWithdrawableIcon = units
+ .stream()
+ .anyMatch(unit->
+... | [UnitChooser->[selectNone->[selectNone],setMax->[changedValue],ChooserEntry->[size->[size],getFinalHit->[getHits],addChangeListener->[addChangeListener],updateLeftToSelect->[setMax,getMax],createComponents->[addChangeListener],getMax->[getMax],selectAll->[getMax],UnitChooserEntryIcon->[paint->[paint],getPreferredSize->... | Creates the entries for the given missing units. | It's dangerous to get a 'gameData' from a 'GamePlayer' object. The 'getOwner()' could be null. It's probably better to get `GameData` from `UiContext`. |
@@ -142,4 +142,13 @@ public class PlatformManagedOAuthConfig extends OAuthConfig<PlatformManagedOAuth
public ExtensionModel getExtensionModel() {
return extensionModel;
}
+
+ private static String sanitizeUrl(String url) {
+ if (url.endsWith("/")) {
+ url = url.substring(0, url.length() - 1);
+ }... | [PlatformManagedOAuthConfig->[from->[PlatformManagedOAuthConfig]]] | Get the extension model. | this already exists at `com.mulesoft.service.oauth.internal.platform.OCSSettings#sanitizeUrl`. Move to a shared Utils class that both classes can reuse |
@@ -46,6 +46,9 @@ def _prepare_topo_plot(inst, ch_type, layout):
for ii, this_ch in enumerate(info['chs']):
this_ch['ch_name'] = clean_ch_names[ii]
info['bads'] = _clean_names(info['bads'])
+ for comp in info['comps']:
+ comp['data']['col_names'] = _clean_names(comp['data']['col_names'])
+
... | [_init_anim->[set_values,_check_outlines,_hide_frame,_autoshrink,_GridData,_draw_outlines],plot_ica_components->[plot_ica_components,_check_outlines,_prepare_topo_plot,_add_colorbar,plot_topomap,_autoshrink],_plot_topomap->[set_locations,_check_outlines,_show_names,_GridData,_draw_outlines,_plot_sensors],plot_evoked_to... | Prepare topo plot. find topomap coordinates of ch_type and ch_names. | This will modify the object inplace. Do we know that it has been copied already everywhere `_prepare_topo_plot` is used? Is there some new test that shows why this is necessary (i.e., fails on master but passes here)? |
@@ -90,7 +90,7 @@ public class JobsPane extends WorkbenchPane
list_.addJob(job);
// bring the pane to the front so the new job is visible
- bringToFront();
+ if (job.show) bringToFront();
// select the job
events_.fire... | [JobsPane->[syncElapsedTime->[syncElapsedTime],updateJob->[updateJob]]] | Updates a specific job in the list. | We should also skip firing the selection event if we aren't showing the job right away -- otherwise it'll still switch to the job if you have the pane open which probably isn't desired. |
@@ -93,6 +93,13 @@ int PEM_def_callback(char *buf, int num, int w, void *key)
return (i);
}
+#if defined(OPENSSL_NO_STDIO) || defined(OPENSSL_NO_UI)
+ /*
+ * We should not ever call the default callback routine from windows.
+ */
+ PEMerr(PEM_F_PEM_DEF_CALLBACK, ERR_R_SHOULD_NOT_HAVE_BEEN_... | [PEM_do_header->[PEM_def_callback],PEM_ASN1_write_bio->[PEM_def_callback,PEM_dek_info,PEM_proc_type]] | PEM_def_callback - default callback routine. | While you're touching this code anyway please replace all instances in this function of `return (...)` with `return ...` for compliance with the style guide. |
@@ -240,7 +240,6 @@ func CreateMoveLeaderOperator(desc string, cluster Cluster, region *core.RegionI
return nil, err
}
st := CreateAddPeerSteps(peer)
- st = append(st, TransferLeader{ToStore: peer.StoreId, FromStore: oldStore})
steps = append(st, steps...)
brief := fmt.Sprintf("mv leader: store %v to %v", ol... | [String->[Sprintf,Sort],GetStoreId,Uint64s,Error,GetID,New,GetStartKey,GetLabels,CheckLabelProperty,Debug,GetPeers,GetEndKey,Uint64,GetFollowers,GetStore,Sort,GetStoreIds,Sprintf,GetMeta,AllocPeer,Intn,GetRegionEpoch,GetId,GetLeader] | CreateOfflinePeerOperator creates an operator that moves a leader from a peer to a new leader getRegionFollowerIDs returns the list of unique region IDs that can be used to find. | why to remove it. |
@@ -49,8 +49,14 @@ public class MismatchPackageDirectoryCheck extends BaseTreeVisitor implements Ja
File javaFile = context.getFile();
String dir = javaFile.getParent();
if (!dir.endsWith(packageName)) {
- context.reportIssue(
- this, packageDeclaration.packageName(), "This file \""... | [MismatchPackageDirectoryCheck->[visitCompilationUnit->[getParent,reportIssue,packageDeclaration,getName,endsWith,packageName,getFile],scanFile->[scan,getTree]]] | Checks if a CompilationUnitTree is a and reports it if so. | Replace "/" by File.separator |
@@ -19,12 +19,13 @@ package org.apache.beam.sdk.tpcds;
import org.apache.beam.sdk.Pipeline;
import org.apache.beam.sdk.PipelineResult;
+import org.apache.beam.sdk.PipelineResult.State;
import java.util.concurrent.Callable;
/**
* To fulfill multi-threaded execution
*/
-public class TpcdsRun implements Callab... | [TpcdsRun->[call->[waitUntilFinish,run]]] | This class is used to create a new instance of a tpcds run. | Nit: add parentheses around `state == State.DONE;`, which increases readability. |
@@ -318,6 +318,15 @@ public final class MediaType {
return builder.append("; ").append(strParams).toString();
}
+ /**
+ * @return true if the MediaType's java type is a byte array.
+ */
+ public boolean isBinary() {
+ String customType = getClassType();
+ if (customType == null) return ... | [MediaType->[checkValidQuotes->[checkStartAndEnd],MediaTypeExternalizer->[writeObject->[writeObject],readObject->[MediaType,readObject,withParameters]],equals->[equals],fromString->[MediaType],withoutParameters->[MediaType],toStringExcludingParam->[hasParameters],hashCode->[hashCode],withParameter->[MediaType],withPara... | This method returns a string containing type subtype and parameters excluding the weight parameter name. | So to clarify we assume everything is binary if it has ByteArray as a type in the media type (ie. application/object;type=ByteArray) or it doesn't match application object? |
@@ -129,9 +129,9 @@ void GameUI::update(const RunStats &stats, Client *client, MapDrawControl *draw_
<< "pos: (" << (player_position.X / BS)
<< ", " << (player_position.Y / BS)
<< ", " << (player_position.Z / BS)
- << ") | yaw: " << (wrapDegrees_0_360(cam.camera_yaw)) << "° "
+ << ") | yaw: " << (wrapDe... | [No CFG could be retrieved] | Set the in the game object. region GuitextManager methods. | isn't this utf-8 specific? shouldn't this be an `\uabcd` style escape? |
@@ -108,7 +108,11 @@ void dangarj_state::dangarj_io_map(address_map &map)
WRITE8_MEMBER(galivan_state::blit_trigger_w)
{
- m_nb1414m4->exec((m_videoram[0] << 8) | (m_videoram[1] & 0xff),m_videoram,m_scrollx,m_scrolly,m_tx_tilemap);
+ uint16_t message = (m_videoram[0] << 8) | (m_videoram[1] & 0xff);
+ // For avoid c... | [No CFG could be retrieved] | region device - specific map functions 0x13 - > 0x13 - > 0x14 - > 0x14 region Sound Latch Clear. | Do you have any evidence that it really behaves like this? Only ignoring consecutive clear commands looks a lot like a hack to work around some other problem. |
@@ -184,11 +184,11 @@ func marshalInputAndDetermineSecret(v interface{},
destType reflect.Type,
await bool) (resource.PropertyValue, []Resource, bool, error) {
secret := false
+ var deps []Resource
for {
valueType := reflect.TypeOf(v)
// If this is an Input, make sure it is of the proper type and await ... | [IsObject,Index,ElementType,NewArchiveProperty,IsBool,PropertyKey,MapKeys,HasPrefix,NewNumberProperty,New,Len,IsComputed,Bool,ID,TypeOf,IsPath,CanSet,Implements,AssignableTo,SecretValue,IsURI,ConstructProvider,IsValid,IsNumber,Kind,ArchiveValue,Interface,URN,SetUint,IsNull,NewAssetProperty,MakeMap,Construct,TypeString,... | marshalInput marshals an input value and returns its raw serializable value along with any dependencies. Invite the if the input is an Output and await its value. | I assume we could benefit from some deeper testing of this `marshalInputAndDetermineSecret` function? |
@@ -135,7 +135,6 @@ public class ConsistentHashTest extends TestCase {
for (int j=0; j<10; j++) {
ConsistentHash<String> b = new ConsistentHash<String>();
b.addAll(data);
-// System.out.println(Iterables.toString(b.list("x")));
}
System.out.println(Syste... | [ConsistentHashTest->[testUnevenDisribution->[assertTrue,printf,equals,Random,nextInt,lookup,add],testBasic->[assertTrue,hasNext,size,println,iterator,lookup,add,assertEquals,next],testRemoval->[assertTrue,remove,getValue,Random,entrySet,getKey,lookup,nextInt,add,put],testEmptyBehavior->[hasNext,assertFalse,lookup,asse... | testSpeed - test speed of the algorithm. | Can leave such things in; was probably useful at some point when developing the test. |
@@ -181,8 +181,12 @@ class PointOutputProcess(KratosMultiphysics.Process):
my_rank = comm.Rank()
writing_rank = comm.MaxAll(my_rank) # The partition with the larger rank writes
- if my_rank == writing_rank:
+ if my_rank == -1:
+ warn_msg = 'No "{}" was found for input {... | [GetFileHeader->[str,format,Name,IsArrayVariable],IsArrayVariable->[type],Interpolate->[GetSolutionStepValue,type,GetNodes,GetValue,nodes,zip],Factory->[Exception,PointOutputProcess,type],PointOutputProcess->[__SearchPoint->[Rank,GetFileHeader,MaxAll,append,TimeBasedAsciiFileWriterUtility,GetCommunicator,Parameters,Bru... | Search for a point in the model. This method writes a file if the entity type lies in the partition with the larger PID. | I think this is a bit confusing to name this variable like that. I would assume at first glance that this indicates my rank, not if results were found in my rank. Rather than that its ok. |
@@ -183,6 +183,7 @@ def replace_placeholders(text):
data = {
'pid': os.getpid(),
'fqdn': socket.getfqdn(),
+ 'reverse-fqdn': '.'.join(reversed(socket.getfqdn().split('.'))),
'hostname': socket.gethostname(),
'now': DatetimeWrapper(current_time.now()),
'utcnow': D... | [BaseFormatter->[format_item->[get_item_data]],ellipsis_truncate->[swidth_slice],format_line->[InvalidPlaceholder,PlaceholderError],Location->[parse->[replace_placeholders],_parse->[normpath_special]],DatetimeWrapper->[__format__->[__format__]],json_print->[json_dump],ItemFormatter->[get_item_data->[remove_surrogates],... | Replace placeholders in text with their values. | as getfqdn can take rather long, please refactor this so it gets only called once and the result is used for both placeholders. |
@@ -114,9 +114,12 @@ public class Http2StreamChannelBootstrapTest {
assertThat(promise.isDone(), is(false));
closeLatch.countDown();
- exceptionRule.expect(ExecutionException.class);
- exceptionRule.expectCause(IsInstanceOf.<Throwable>instanceOf(ClosedChannelException.c... | [Http2StreamChannelBootstrapTest->[testStreamIsNotCreatedIfParentConnectionIsClosedConcurrently->[initChannel->[build,addLast,countDown,newMultiplexedHandler],run->[await,syncUninterruptibly,error],assertTrue,channel,CountDownLatch,countDown,DefaultEventLoop,expectCause,expect,await,childHandler,shutdownGracefully,Loca... | Test if the parent connection is closed concurrently. shutdownGracefully - shutdown the group if it is not null. | If you use `assertThrows`, it'll return the exception thrown for further checks. |
@@ -266,7 +266,8 @@ public class TrashPolicyOzone extends TrashPolicyDefault {
while (true) {
try {
fs.rename(current, checkpoint);
- LOG.debug("Created trash checkpoint: " + checkpoint.toUri().getPath());
+ LOG.debug("Created trash checkpoint: {}",
+ checkpoint.toUri()... | [TrashPolicyOzone->[Emptier->[run->[TrashPolicyOzone]],moveToTrash->[moveToTrash],initialize]] | Create a checkpoint for the trash. | this one is tricky, because URI.getPath() is not a O(1) operation. It constructs a String on the fly. We need to wrap this debug message with if (LOG.isDebugEnabled()) { |
@@ -35,9 +35,11 @@ class NotifyMailer < ApplicationMailer
@mentioner = User.find(@mention.mentionable.user_id)
@mentionable = @mention.mentionable
+ @mentionable_type = MentionDecorator.new(@mention).formatted_mentionable_type
+
@unsubscribe = generate_unsubscribe_token(@user.id, :email_mention_noti... | [NotifyMailer->[user_contact_email->[email,find,mail],feedback_response_email->[community_name,mail],export_email->[iso8601,mail],unread_notifications_email->[limit_by_email_recipient_address,email,mail,count,community_name,id,generate_unsubscribe_token],new_follower_email->[limit_by_email_recipient_address,email,mail,... | Email a new mention email. | **non blocking**: you can also use `@mention.decorate` instead of `MentionDecorator.new(@mention)` |
@@ -61,11 +61,7 @@ public class StreamAuditEventListener implements EventListener, Synchronization
public static final String STREAM_AUDIT_ENABLED_PROP = "nuxeo.stream.audit.enabled";
- public static final String AUDIT_LOG_CONFIG_PROP = "nuxeo.stream.audit.log.config";
-
- public static final String DEFA... | [StreamAuditEventListener->[getLogManager->[getLogManager],registerSynchronization->[registerSynchronization]]] | This method is called when an event is received from the audit logger. | Should we keep them for backward compat'? Or anyway it's not working anymore and customers must update their code? |
@@ -12,13 +12,13 @@ namespace System.Text.Json
internal static partial class ThrowHelper
{
[MethodImpl(MethodImplOptions.NoInlining)]
- public static void ThrowArgumentException_DeserializeWrongType(Type type, object value)
+ public static void ThrowArgumentException_DeserializeWrongTyp... | [ThrowHelper->[ReThrowWithPath->[AddExceptionInformation]]] | Throw exception if deserialization is not possible. | Same here. Can we annotate **all** the `Throw...` methods with `[DoesNotReturn]` `ThrowArgumentException_DeserializeWrongType` `ThrowInvalidOperationException_SerializerCycleDetected` `ThrowJsonException_DeserializeUnableToConvertValue` overloads `ThrowJsonException_DepthTooLarge` `ThrowJsonException_SerializationConve... |
@@ -34,6 +34,7 @@ namespace Pulumi.Automation
private readonly LocalSerializer _serializer = new LocalSerializer();
private readonly bool _ownsWorkingDir;
private readonly Task _readyTask;
+ private static readonly SemVersion _minimumVersion = SemVersion.Parse("2.21.0");
///... | [LocalWorkspace->[GetStackSettingsAsync->[GetStackSettingsName],CreateOrSelectStackAsync->[CreateOrSelectStackAsync],SelectStackAsync->[SelectStackAsync],CreateStackAsync->[CreateStackAsync,CreateAsync],Dispose->[Dispose],Task->[GetStackSettingsName]]] | A workspace that is used to manage a single global context. The cancellation token for this operation. | Is this something that you guys are intending will be updated regularly? |
@@ -104,7 +104,7 @@ class CarController():
# 20 Hz LFA MFA message
if frame % 5 == 0 and self.car_fingerprint in [CAR.SONATA, CAR.PALISADE, CAR.IONIQ, CAR.KIA_NIRO_EV, CAR.KIA_NIRO_HEV_2021,
CAR.IONIQ_EV_2020, CAR.IONIQ_PHEV, CAR.KIA_CEED, CAR.KIA_SELTOS, CA... | [CarController->[__init__->[CarControllerParams,CANPacker],update->[create_clu11,round,process_hud_alert,int,create_acc_commands,create_lkas11,append,extend,create_lfahda_mfc,apply_std_steer_torque_limits,clip,create_frt_radar_opt,create_acc_opt,interp]]] | Update the state of the tester. create clu11 message returns can_sends list of can_sends. | do the older santa fe's have this msg? |
@@ -334,11 +334,14 @@ func newISTag(tag string, imageStream *imageapi.ImageStream, image *imageapi.Ima
Name: istagName,
CreationTimestamp: event.Created,
Annotations: map[string]string{},
+ Labels: imageStream.Labels,
ResourceVersion: imageStream.ResourceVersion,
UI... | [Create->[NamespaceFrom,Sprintf,BeforeCreate,SplitImageStreamTag,GetImageStream,Resource,UpdateImageStream,Errorf,IsNotFound,IsZero,CreateImageStream,NewBadRequest,NewAlreadyExists],imageFor->[JoinImageStreamTag,Resource,GetImage,LatestTaggedImage,NewNotFound],List->[Matches,ListImageStreams,IsNotFound,InternalListOpti... | newISTag initializes an image stream tag from an image stream and an image. nanononononononononononononononononon. | I'm hesitant copying all labels from IS. I'm not quite convinced it is the right approach... |
@@ -52,7 +52,8 @@ logger = logging.getLogger(__name__)
class PythonSources(Sources):
- expected_file_extensions = (".py", ".pyi")
+ # Note that Python scripts often have no file ending.
+ expected_file_extensions = ("", ".py", ".pyi")
class InterpreterConstraintsField(StringSequenceField):
| [_RequirementSequenceField->[compute_value->[parse,_format_invalid_requirement_string_error]],parse_requirements_file->[parse,_format_invalid_requirement_string_error],PexEntryPointField->[compute_value->[parse]]] | Protected base class for all of the common fields. | - constraints for target object. | To clarify, this is just to allow such files, but doesn't change the default globs for sources= in a `python_library`? |
@@ -714,13 +714,12 @@ namespace Js
#ifdef INTL_ICU
typedef const char * (*GetAvailableLocaleFunc)(int);
typedef int (*CountAvailableLocaleFunc)(void);
- static bool findLocale(const char *langtag, CountAvailableLocaleFunc countAvailable, GetAvailableLocaleFunc getAvailable)
+ static bool findLocale(Jav... | [No CFG could be retrieved] | Finds the next language tag in the script context. Checks if a DtF locale is available for the current platform. | >// TODO(jahorto): can we binary search this instead? [](start = 8, length = 52) +1 -- can we investigate whether this list comes in sorted order? It doesn't look like we're tied to any iterator behavior so we should have random access at this point. |
@@ -22,6 +22,11 @@ import (
"github.com/elastic/beats/x-pack/functionbeat/provider/aws/transformer"
)
+var (
+ logGroupNamePattern = "^[\\.\\-_/#A-Za-z0-9]+$"
+ logGroupNameRE = regexp.MustCompile(logGroupNamePattern)
+)
+
// CloudwatchLogsConfig is the configuration for the cloudwatchlogs event type.
type ... | [MarshalJSON->[Marshal,AWSCloudFormationType],Validate->[New],createHandler->[CloudwatchLogs,PublishAll,Parse,Errorf,Wait,Debugf],Run->[Start,createHandler],Template->[Itoa,Join,NewTemplate,GetAtt,Replace,Ref],Unpack,NewLogger] | type is the configuration for the cloudwatchlogs event type. NewCloudwatchLogs creates a new CloudWatchLogs function. | use backticks for raw strings. Then you don't have to escape the escapes. |
@@ -163,7 +163,10 @@ class Agent:
def _verify_token(self, token: str) -> None:
"""
- Checks whether a token with a `RUNNER` scope was provided
+ Checks whether a token with a `RUNNER` scope was provided (DEPRECATED)
+ Visit https://docs.prefect.io/orchestration/concepts/api_keys.htm... | [Agent->[run_heartbeat_thread->[start],setup->[run->[start],start],__init__->[get],start->[_register_agent,exit_handler,_verify_token],agent_process->[run]],Agent] | Checks whether a token with a RUNNER scope was provided. | This is a private function and is going to be confusing to a developer because this is still validating the key, right? |
@@ -651,16 +651,12 @@ public class ReduceFnRunner<K, InputT, OutputT, W extends BoundedWindow> {
// it but the local output watermark (also for this key) has not. After data is emitted and
// the output watermark hold is released, the output watermark on this key will immediately
// exceed the end ... | [ReduceFnRunner->[emit->[shouldDiscardAfterFiring],prefetchOnTrigger->[prefetchOnTrigger],processElement->[toMergedWindows],onTimers->[windowIsActiveAndOpen,WindowActivation],OnMergeCallback->[prefetchOnMerge->[activeWindows,prefetchOnMerge],onMerge->[activeWindows,onMerge]],processElements->[windowsThatShouldFire,wind... | This method is called by the window manager to activate a window. Get the next window context. | This one was tough. The problem here was, that previously input watermark moved at the end of each bundle. Each bundle also contained its own timers. But - because timers can generate new timers and these are processed in different bundle - the actual timestamp of timer must be taken into account. Otherwise a timer set... |
@@ -153,6 +153,7 @@ export default class JitsiStreamPresenterEffect {
this._videoFrameTimerWorker.postMessage({
id: CLEAR_INTERVAL
});
+ this._videoFrameTimerWorker.terminate();
}
}
| [No CFG could be retrieved] | Post a message to the worker to clear the next frame. | The worker is created only once when the effect is constructed. Worker creation needs to be moved to startEffect. |
@@ -264,13 +264,7 @@ func validateInsecureEdgeTerminationPolicy(tls *routeapi.TLSConfig, fldPath *fie
return nil
}
- // Ensure insecure is set only for edge terminated routes.
- if routeapi.TLSTerminationEdge != tls.Termination {
- // tls.InsecureEdgeTerminationPolicy option is not supported for a non edge-term... | [Index,ValidateImmutableField,Verify,HasPrefix,IsDNS1123Subdomain,NewPath,Required,Has,Error,Child,Errorf,NewString,NotSupported,ValidateObjectMeta,IsDNS1123Label,AddCert,Split,Invalid,NewCertPool,Sprintf,ValidateObjectMetaUpdate,GetNameValidationFunc,X509KeyPair,CertificatesFromPEM] | validateInsecureEdgeTerminationPolicy tests if the field passed in is a valid and get the certs from the certPEM. | Style: Make this a switch statement on the termination field |
@@ -2140,6 +2140,7 @@ public class QueueImpl extends CriticalComponentImpl implements Queue {
QueueIterateAction messageAction) throws Exception {
int count = 0;
int txCount = 0;
+ Integer expectedHits = messageAction.expectedHits();
// This is to avoid s... | [QueueImpl->[getDurableDeliveringCount->[getDurableMessageCount],scheduleDepage->[getName],configureExpiry->[getExpiryAddress],addConsumer->[debug],deleteAllReferences->[deleteAllReferences],configureSlowConsumerReaper->[equals,getName,cancel,debug],getMessageCount->[getMessageCount],getDeliveringCount->[getMessageCoun... | This method is used to perform a queue iteration. check if there is a neccesary failure in the current transaction. | Whats the purpose of this? |
@@ -54,8 +54,8 @@ const (
// MetricsServerPort is the port on which OSM exposes its own metrics server
MetricsServerPort = 9091
- // AggregatedDiscoveryServiceName is the name of the ADS service.
- AggregatedDiscoveryServiceName = "ads"
+ // OSMControllerServiceName is the name of the ADS service.
+ OSMController... | [No CFG could be retrieved] | The port of the Envoy outbound listener. The KubernetesOpaqueSecretCAKey is the secret CA key that is used to sign the. | nit: `ADS Service` -> `OSM Controller Service` |
@@ -35,6 +35,10 @@ module Engine
self
end
+ def corporation
+ nil
+ end
+
def ==(other)
other&.player? && (@name == other&.name)
end
| [Player->[to_s->[name],value->[sum],include,player?,attr_accessor,attr_reader,name],require_relative] | missing player centric order. | Added so that an ownable can call `.corporation` |
@@ -14,6 +14,8 @@ class Directory_helper_test extends CI_TestCase {
public function test_directory_map()
{
+ $ds = DIRECTORY_SEPARATOR;
+
$structure = array(
'libraries' => array(
'benchmark.html' => '',
| [Directory_helper_test->[set_up->[helper],test_directory_map->[assertEquals]]] | test directory map. | Don't change that if you wish, since it's a test and it's not important, but I just can't ignore it - is it really worth it for just 4 occurences? :) |
@@ -122,6 +122,17 @@ module Engine
sm
end
+ def init_tiles
+ tiles = super
+
+ tiles.find { |tile| tile.name == '53' }.label = 'Ba'
+ tiles.find { |tile| tile.name == '61' }.label = 'Ba'
+ tiles.find { |tile| tile.name == '121' }.label = 'Bo'
+ tiles.find { |til... | [G1828->[acquire_va_tunnel_coal_marker->[coal_marker?],buy_coal_marker->[can_buy_coal_marker?],can_buy_coal_marker?->[connected_to_coalfields?,coal_marker?,coal_marker_available?],block_va_coalfields->[coalfields->[coal_marker?]]]] | Initialize the stock market unknown entity. | is there only one tile of this type? if not you could do |
@@ -507,7 +507,7 @@ func (sm *SnapshotManager) snap() *deploy.Snapshot {
manifest := deploy.Manifest{
Time: time.Now(),
Version: version.Version,
- Plugins: sm.plugins,
+ // Plugins: sm.plugins, - Explicitly dropped, since we don't use the plugin list in the manifest anymore.
}
manifest.Magic = manif... | [saveSnapshot->[snap],doCreate->[mutate],doRead->[mutate],doDelete->[mutate],RegisterResourceOutputs->[mutate],End->[mutate,mustWrite],RecordPlugin->[mutate],doUpdate->[mutate],saveSnapshot] | snap creates a snapshot of the current DAG and the base DAG. This function creates a snapshot of the current state that is not in the merged list. | Is there a compelling reason for retaining the `Plugins` field of `deploy.Manifest` at all? |
@@ -170,10 +170,10 @@ WRITE16_MEMBER(srmp2_state::srmp2_flags_w)
*/
- machine().bookkeeping().coin_counter_w(0, ((data & 0x01) >> 0) );
- machine().bookkeeping().coin_lockout_w(0, (((~data) & 0x10) >> 4) );
- m_adpcm_bank = ( (data & 0x20) >> 5 );
- m_color_bank = ( (data & 0x80) >> 7 );
+ machine().bookkeeping().... | [No CFG could be retrieved] | 16 - bit protection in srmp2 region 0x00000000 - 0x0000ff - 0x0100ff - 0x. | It's easier to understand if the bank values are aligned in the LSBs and shifted/multiplied when used. |
@@ -56,8 +56,12 @@ public class NoopTask extends AbstractTask
@Override
public TaskStatus run(TaskToolbox toolbox) throws Exception
{
+ final int sleepTime = 2500;
+
log.info("Running noop task[%s]", getId());
- Thread.sleep(2500);
+ log.info("Sleeping for %,d millis.", sleepTime);
+ Thread.sl... | [NoopTask->[run->[info,sleep,success,getId],days,Interval,DateTime,format,Logger]] | This method is called when the task is not yet scheduled. | Hmm, is this task actually used for anything? |
@@ -216,6 +216,14 @@ public final class PagingProviderProducer<T> implements Producer<List<T>> {
}
}
+ private void tryToMutateConfigurationStats(ConfigurationInstance configurationInstance,
+ Consumer<MutableConfigurationStats> mutableConfigurationStatsConsumer) {... | [PagingProviderProducer->[DefaultConnectionSupplierFactory->[getConnectionSupplier->[getConnection]],StickyConnectionSupplier->[getConnection],StickyConnectionSupplierFactory->[getChecked->[getConnection]],getConnection->[getConnection],close->[close],getConnectionSupplier->[getConnectionSupplier],withConnection->[with... | Returns a connection object that can be used to manage a connection. | repeated code.. Use the utils one |
@@ -175,12 +175,12 @@ function follow_post(&$a) {
notice($result['message']);
goaway($return_url);
} elseif ($result['cid'])
- goaway($a->get_baseurl().'/contacts/'.$result['cid']);
+ goaway(App::get_baseurl().'/contacts/'.$result['cid']);
info( t('Contact added').EOL);
if(strstr($return_url,'contact... | [follow_post->[get_baseurl],follow_content->[get_baseurl]] | Follow a post request to the contact s friendica contact list. | Standards: Could you please add brackets to this conditional statement? |
@@ -22,7 +22,7 @@ define([
* @param {Color} [description.frameTimeColor] The color of the frame time graph.
* @param {Color} [description.backgroundColor] The color of the background of the display.
* @param {String} [description.font] The CSS font of the text in the display.
- * @param {Rectangle... | [No CFG could be retrieved] | Creates a new PerformanceDisplay object. create the canvas. | I see we are not culling this at all right now. As we continue to design the DDR, we will want to render these in a separate pass after all the frustums. |
@@ -18,10 +18,12 @@ import (
"context"
"fmt"
"path"
- "sync"
+ "path/filepath"
"time"
"github.com/vmware/govmomi/object"
+ "github.com/vmware/vic/lib/progresslog"
+
"github.com/vmware/vic/lib/config"
"github.com/vmware/vic/lib/install/data"
"github.com/vmware/vic/lib/install/opsuser"
| [cleanupAfterCreationFailed->[Begin,cleanupBridgeNetwork,End,Errorf,cleanupEmptyPool,Debug],createPool->[Begin,Sprintf,New,End,createResourcePool],uploadImages->[Warnf,Delete,DoWithConfig,Info,Done,Add,NewFileManager,Error,Stat,New,End,Wait,Debug,Debugf,UploadFile,Join,Infof,NewBackoffConfig,Begin,Sprintf],startApplian... | CreateVCH creates a new virtual container instance. creates the pool bridge network and appliance. | Is there a reason for the extra new line here? Looks like this is all from the same pathing for the most part. |
@@ -368,11 +368,13 @@ public class HoodieWriteConfig extends HoodieConfig {
+ "OPTIMISTIC_CONCURRENCY_CONTROL: Multiple writers can operate on the table and exactly one of them succeed "
+ "if a conflict (writes affect the same file group) is detected.");
- public static final ConfigProperty<St... | [HoodieWriteConfig->[Builder->[setDefaults->[setDefaults],build->[HoodieWriteConfig,validate,setDefaults],HoodieWriteConfig],isClusteringEnabled->[isAsyncClusteringEnabled,inlineClusteringEnabled],inlineTableServices->[isAutoClean,inlineCompactionEnabled,inlineClusteringEnabled],getWriteSchema->[getSchema],getFileListi... | This is a utility method that can be used to configure a writer to perform heartbeats This method is used to handle Hudi commit protocol. | do you think we can add in a validation withiin Deltastreamer code base that this config is not enabled. would be good to tighten it and not leave it to end user. |
@@ -284,7 +284,7 @@ public class BootstrapAppModelFactory {
}
}
CurationResult curationResult = new CurationResult(getAppModelResolver()
- .resolveManagedModel(appArtifact, forcedDependencies, managingProject));
+ .resolveManagedModel(appA... | [BootstrapAppModelFactory->[newInstance->[BootstrapAppModelFactory],createAppModelForJar->[getAppModelResolver],getAppModelResolver->[setDevMode],debug->[debug],createBootstrapMavenContext->[setOffline]]] | Resolves the application model. Returns the application model that is curated if any. | I think the app model resolver should be providing the local artifacts instead of the other way around. It resolves them from the workspace anyway. |
@@ -8,6 +8,7 @@
<h1 class='h3'>
<%= t('doc_auth.headings.take_picture') %>
+</h1>
<p class='mt-tiny mb3'><%= t('doc_auth.info.take_picture') %></p>
| [No CFG could be retrieved] | overview page of single user id. | yikes --- is there a way we could have caught this? Like a view spec? |
@@ -155,6 +155,11 @@ func (s *CreateStep) Apply() (resource.Status, error) {
s.new.Outputs = outs
}
+ // Mark the old resource as pending deletion if necessary.
+ if s.replacing {
+ s.old.Delete = true
+ }
+
// And finish the overall operation.
s.goal.Done(s.new, false, nil)
s.iter.AppendStateSnapshot(s.n... | [Color->[Failf],PastTense->[Failf],Apply->[Done,Create,All,AppendStateSnapshot,Delete,MarkStateSnapshot,Assert,URN,AllInputs,Update],Skip->[Done],Prefix->[Failf,Color],Package,Provider,Assert,Type,Plan] | Apply creates a new object in the live object state. | I was slightly surprised this isn't the responsibility of the caller to set. |
@@ -73,9 +73,11 @@ class AuthorizationCodeCredential(object):
return token
def _redeem_refresh_token(self, scopes, **kwargs):
- # type: (Iterable[str], **Any) -> Optional[AccessToken]
+ # type: (Sequence[str], **Any) -> Optional[AccessToken]
for refresh_token in self._client.get_c... | [AuthorizationCodeCredential->[get_token->[ClientAuthenticationError,get_cached_access_token,obtain_token_by_authorization_code,ValueError,_redeem_refresh_token],__init__->[pop,AadClient],_redeem_refresh_token->[get_cached_refresh_tokens,obtain_token_by_refresh_token]]] | Returns the last available refresh token or None if none is found. | Looks like we introduced breaking changes? |
@@ -474,6 +474,16 @@ public class InvokeHTTP extends AbstractProcessor {
.allowableValues("true", "false")
.build();
+ public static final PropertyDescriptor SUPPORT_HTTP2_PROTOCOL = new PropertyDescriptor.Builder()
+ .name("support-http2")
+ .description("Determines... | [InvokeHTTP->[convertAttributesFromHeaders->[csv],OverrideHostnameVerifier->[verify->[verify]]]] | This method is used to create a PropertyDescriptor that can be used to set the HTTP headers and Proxy configuration for all requests. | Recommend a slight wording change to use `HTTP/2` instead of `HTTP 2` in order to match official naming conventions. |
@@ -1237,6 +1237,9 @@ function $ParseProvider() {
return cache[exp];
}
+ // The csp option has to be set here because in tests the $sniffer service sets its csp
+ // property after $get has executed.
+ $parseOptions.csp = $sniffer.csp;
var lexer = new Lexe... | [No CFG could be retrieved] | The function that gets the parsed expression. | I'm still not sure about this though, it seems weird to read this every time $parse is called. If it's the best we can do then that's one thing, but is there not a better solution? |
@@ -0,0 +1,4 @@
+from . import proxy
+
+load_jupyter_server_extension = proxy.setup
+_load_jupyter_server_extension = proxy.setup
| [No CFG could be retrieved] | No Summary Found. | why `load_jupyter_server_extension` and `_load_jupyter_server_extension`, and where we use these? |
@@ -87,7 +87,7 @@ namespace System.Text.Json
internal int Length { get; private set; }
private byte[] _data;
#if DEBUG
- private readonly bool _isLocked;
+ private bool _isLocked;
#endif
internal MetadataDb(byte[] completeDb)
| [JsonDocument->[MetadataDb->[SetNumberOfRows->[AssertValidIndex],SetHasComplexChildren->[AssertValidIndex],JsonTokenType->[AssertValidIndex],SetLength->[AssertValidIndex],DbRow->[AssertValidIndex]]]] | Fields that can be used to store the number of values in the metadata table. Creates an array of bytes for a single token. | Making this mutable for the new JsonElement.Parse API helps prevent a new alloc here. |
@@ -4760,10 +4760,11 @@ bool simple_wallet::try_connect_to_daemon(bool silent, uint32_t* version)
uint32_t version_ = 0;
if (!version)
version = &version_;
- if (!m_wallet->check_connection(version))
+ expect<void> status{};
+ if (!(status = m_wallet->check_connection(version)))
{
if (!silent)
- ... | [No CFG could be retrieved] | Checks if the connection to the daemon is established. Get the mnemonic language from the user. | That is *really* confusing. Above, you inverted the return value check when swithing from bool to expect. Here and below, not. |
@@ -1234,6 +1234,15 @@ public class VmwareStorageProcessor implements StorageProcessor {
details = "create template from volume exception: " + VmwareHelper.getExceptionMessage(e);
return new CopyCmdAnswer(details);
+ } finally {
+ try {
+ if (volume.getVmName... | [VmwareStorageProcessor->[copyTemplateToPrimaryStorage->[getName,copyTemplateFromSecondaryToPrimary],removeVmfsDatastore->[getHostDiscoveryMethod,removeVmfsDatastore,getHostsUsingStaticDiscovery,unmountVmfsDatastore],createVolumeFromSnapshot->[restoreVolumeFromSecStorage],getOVFFilePath->[getName],createTemplateFromSna... | Create a template from a volume. write the OVA for a template. | Ah nevermind, worker VM will be destroyed here. Should we explictly set workerVmMo above and use that to destroy in finally? To avoid any regressions? |
@@ -822,7 +822,7 @@ function settings_content(&$a) {
$settings_connectors .= mini_group_select(local_user(), $default_group, t("Default group for OStatus contacts"));
if ($legacy_contact != "")
- $a->page['htmlhead'] = '<meta http-equiv="refresh" content="0; URL='.$a->get_baseurl().'/ostatus_subscribe?url='.u... | [settings_content->[get_baseurl,get_hostname,get_path],settings_post->[get_baseurl,discover]] | settings_content - Shows the settings page This function renders the settings_oauth. tpl file. This function is used to render the settings page settings_features - Shows the settings features This is the default configuration for the user. | Standards: Can you please add brackets to this conditional statement? |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.