hash
stringlengths 40
40
| diff
stringlengths 172
2.63k
| message
stringlengths 12
593
| project
stringlengths 7
65
| split
stringclasses 1
value | diff_languages
stringclasses 54
values |
|---|---|---|---|---|---|
5d0f9a090082b4550b8b8fd75cd626cfcc8a9c08
|
diff --git a/engine/src/main/java/org/camunda/bpm/engine/FormService.java b/engine/src/main/java/org/camunda/bpm/engine/FormService.java
index <HASH>..<HASH> 100644
--- a/engine/src/main/java/org/camunda/bpm/engine/FormService.java
+++ b/engine/src/main/java/org/camunda/bpm/engine/FormService.java
@@ -248,8 +248,26 @@ public interface FormService {
*/
String getTaskFormKey(String processDefinitionId, String taskDefinitionKey);
+ /**
+ * Retrieves a deployed start form for a process definition with a given id.
+ *
+ *
+ * @throws AuthorizationException
+ * If the user has no {@link Permissions#READ} permission on {@link Resources#PROCESS_DEFINITION}.
+ * @throws DeploymentResourceNotFoundException
+ * If the start form cannot be found in a deployment.
+ */
InputStream getDeployedStartForm(String processDefinitionId);
+ /**
+ * Retrieves a deployed task form for a task with a given id.
+ *
+ *
+ * @throws AuthorizationException
+ * If the user has no {@link Permissions#READ} permission on {@link Resources#TASK}.
+ * @throws DeploymentResourceNotFoundException
+ * If the task form cannot be found in a deployment.
+ */
InputStream getDeployedTaskForm(String taskId);
}
\ No newline at end of file
|
docs(form-service): add missing java docs
related to CAM-<I>
|
camunda_camunda-bpm-platform
|
train
|
java
|
dc70e303abb7a405a666d39d6300168277879676
|
diff --git a/packages/d3fc-chart/src/svg/cartesian.js b/packages/d3fc-chart/src/svg/cartesian.js
index <HASH>..<HASH> 100644
--- a/packages/d3fc-chart/src/svg/cartesian.js
+++ b/packages/d3fc-chart/src/svg/cartesian.js
@@ -60,7 +60,7 @@ export default (xScale = scaleIdentity(), yScale = scaleIdentity()) => {
<d3fc-svg class='plot-area' style='flex: 1; overflow: hidden'></d3fc-svg>
<d3fc-svg class='y-axis' style='width: 3em'></d3fc-svg>
<div style='width: 1em; display: flex; align-items: center; justify-content: center'>
- <div class='y-axis-label' style='transform: rotate(90deg)'></div>
+ <div class='y-axis-label' style='transform: rotate(-90deg)'></div>
</div>
</div>
<d3fc-svg class='x-axis' style='height: 2em; margin-${yOrient}: 4em'></d3fc-svg>
|
fix: flip the vertical axis labels to read ltr (#<I>)
Fixes #9
|
d3fc_d3fc
|
train
|
js
|
1d825eb685ea047333efdb94b0b7908353a091e3
|
diff --git a/gulpfile.js b/gulpfile.js
index <HASH>..<HASH> 100644
--- a/gulpfile.js
+++ b/gulpfile.js
@@ -1126,7 +1126,7 @@ gulp.task('bundles.js.umd.min', ['!bundles.js.umd', '!bundle.ng.polyfills'], fun
// minify production bundles
return gulp.src([
- 'dist/js/bundle/angular-polyfills.js',
+ 'dist/js/bundle/angular2-polyfills.js',
'dist/js/bundle/angular2.umd.js',
'dist/js/bundle/angular2_all.umd.js'
])
@@ -1156,7 +1156,7 @@ gulp.task('!bundle.js.min.deps', ['!bundle.js.min'], function() {
});
gulp.task('!bundle.ng.polyfills', ['clean'],
- function() { return addDevDependencies('angular-polyfills.js'); });
+ function() { return addDevDependencies('angular2-polyfills.js'); });
var JS_DEV_DEPS = [
licenseWrap('node_modules/zone.js/LICENSE', true),
|
chore(bundles): rename angular-polyfills to angular2-polyfills.
|
angular_angular
|
train
|
js
|
4c0cf991173ae4d4c424a3fb88fa4b9bb9679f89
|
diff --git a/inmem/task_test.go b/inmem/task_test.go
index <HASH>..<HASH> 100644
--- a/inmem/task_test.go
+++ b/inmem/task_test.go
@@ -15,7 +15,6 @@ var (
taskBucket = []byte("tasksv1")
organizationBucket = []byte("organizationsv1")
authBucket = []byte("authorizationsv1")
- urmBucket = []byte("userresourcemappingsv1")
idgen influxdb.IDGenerator = snowflake.NewIDGenerator()
)
|
chore(inmem): Resolve staticcheck issue
|
influxdata_influxdb
|
train
|
go
|
082855d9844657a9f31fc2d596837764683fc4b8
|
diff --git a/lib/rules/commit-name.js b/lib/rules/commit-name.js
index <HASH>..<HASH> 100644
--- a/lib/rules/commit-name.js
+++ b/lib/rules/commit-name.js
@@ -80,15 +80,16 @@ module.exports = {
};
function users(cmt) {
- const author = user(cmt, 'author');
- const committer = user(cmt, 'committer');
- if (author == committer) return author;
- if (author && committer) return `${author} and ${committer}`;
- return author || committer;
+ const a = user(cmt, 'author');
+ const c = user(cmt, 'committer');
+ if (a && c && a != c) return `${a} and ${c}`;
+ return a || c;
}
function user(cmt, userType) {
- return cmt[userType] && cmt[userType].login && ('@' + cmt[userType].login) || cmt.commit[userType].name;
+ return cmt[userType] && cmt[userType].login
+ ? '@' + cmt[userType].login
+ : cmt.commit[userType].name;
}
function uniques(arr) {
|
refactor: rule commit-name
|
MailOnline_gh-lint
|
train
|
js
|
da89ee5adc3de6190c8f802267480f6a7bb52f1f
|
diff --git a/src/filters.js b/src/filters.js
index <HASH>..<HASH> 100644
--- a/src/filters.js
+++ b/src/filters.js
@@ -13,6 +13,7 @@ angular.module('angular.filter', [
'a8m.strip-tags',
'a8m.stringular',
'a8m.truncate',
+ 'a8m.start-with',
'a8m.concat',
'a8m.unique',
|
fix(filter): register start-with module
|
a8m_angular-filter
|
train
|
js
|
3eea0fe9d72daab2cd6bbcbb36bcf4a2bdf9afdb
|
diff --git a/views/default/components/list/list.js b/views/default/components/list/list.js
index <HASH>..<HASH> 100644
--- a/views/default/components/list/list.js
+++ b/views/default/components/list/list.js
@@ -169,9 +169,11 @@ define(function (require) {
if (self.timeout) {
clearTimeout(self.timeout);
}
+
+ // We are adding a random offset of 0 to 10s so that multiple lists don't fire all at the same time
self.timeout = setTimeout(function () {
self.fetchNewItems.apply(self, []);
- }, self.options.autoRefresh * 1000);
+ }, self.options.autoRefresh * 1000 + Math.round(Math.random() * 10000));
},
/**
* Trigger init event
|
fix(ajax): throttle simulatenous ajax requests
With too many autorefreshing lists on the page, ajax requests fire
simultaneously freezing the page. This adds a bit of a random offset,
so timeouts are randomized
|
hypeJunction_hypeLists
|
train
|
js
|
262be40d177fe9b877d1c0d2ab04952350041d69
|
diff --git a/zk_shell/shell.py b/zk_shell/shell.py
index <HASH>..<HASH> 100644
--- a/zk_shell/shell.py
+++ b/zk_shell/shell.py
@@ -1564,7 +1564,7 @@ child_watches=%s"""
def color_outliers(group, delta, marker=lambda x: red(str(x))):
colored = False
- outliers = find_outliers(group[1:], 20)
+ outliers = find_outliers(group[1:], delta)
for outlier in outliers:
group[outlier + 1] = marker(group[outlier + 1])
colored = True
|
fix(chkzk): delta for outliers was hard-coded
|
rgs1_zk_shell
|
train
|
py
|
4e260775b29387ef9ebf68263306f9c98de0b51f
|
diff --git a/core/commands/dns.go b/core/commands/dns.go
index <HASH>..<HASH> 100644
--- a/core/commands/dns.go
+++ b/core/commands/dns.go
@@ -32,6 +32,10 @@ remember. To create memorable aliases for multihashes, DNS TXT
records can point to other DNS links, IPFS objects, IPNS keys, etc.
This command resolves those links to the referenced object.
+Note: This command can only recursively resolve DNS links,
+it will fail to recursively resolve through IPNS keys etc.
+For general-purpose recursive resolution, use ipfs name resolve -r.
+
For example, with this DNS TXT record:
> dig +short TXT _dnslink.ipfs.io
|
docs: add a note for dns command
License: MIT
|
ipfs_go-ipfs
|
train
|
go
|
14b8a0cb8b8931214429b5b9ef61e359ac8a95a4
|
diff --git a/fsoopify/paths.py b/fsoopify/paths.py
index <HASH>..<HASH> 100644
--- a/fsoopify/paths.py
+++ b/fsoopify/paths.py
@@ -28,10 +28,6 @@ class PathPart(str):
return self._normcased == os.path.normcase(other)
-class DirectoryPart(PathPart):
- pass
-
-
class NamePart(PathPart):
def __init__(self, val):
super().__init__(val)
@@ -76,11 +72,11 @@ class Path(PathPart):
def __ensure_dirname(self):
if self._dirname is None:
dn, fn = os.path.split(self)
- self._dirname = DirectoryPart(dn)
+ self._dirname = Path(dn)
self._name = NamePart(fn)
@property
- def dirname(self) -> DirectoryPart:
+ def dirname(self):
''' get directory path from path. '''
self.__ensure_dirname()
return self._dirname
|
feat: dirname should be a new Path.
|
Cologler_fsoopify-python
|
train
|
py
|
7fe482cf9a632fcaade2d5827ac9bfd658eb90a3
|
diff --git a/src/core/util/util.js b/src/core/util/util.js
index <HASH>..<HASH> 100644
--- a/src/core/util/util.js
+++ b/src/core/util/util.js
@@ -113,12 +113,14 @@ angular.module('material.core')
var scrollOffset = body.scrollTop + body.parentElement.scrollTop;
var clientWidth = body.clientWidth;
- applyStyles(body, {
- position: 'fixed',
- width: '100%',
- overflowY: 'scroll',
- top: -scrollOffset + 'px'
- });
+ if (body.scrollHeight > body.clientHeight) {
+ applyStyles(body, {
+ position: 'fixed',
+ width: '100%',
+ overflowY: 'scroll',
+ top: -scrollOffset + 'px'
+ });
+ }
applyStyles(htmlNode, {
overflowY: 'hidden'
|
fix(disableScroll): fix disable scroll creating scrollbar when none existed
|
angular_material
|
train
|
js
|
c7e006148357142072b42a8e88ccc329934b4326
|
diff --git a/webpack.config.build.js b/webpack.config.build.js
index <HASH>..<HASH> 100644
--- a/webpack.config.build.js
+++ b/webpack.config.build.js
@@ -29,6 +29,7 @@ module.exports = function(theme, type = 'intact') {
resolve: {
alias: {
'./components/code': './empty',
+ 'intact$': type === 'vue' ? 'intact-vue' : type === 'react' ? 'intact-react' : undefined,
},
},
externals: type === 'intact' ? {
|
chore: fix build kpc.react.js with intact-vue
|
ksc-fe_kpc
|
train
|
js
|
4205b58753712f9f89bd871815a5279c1880c852
|
diff --git a/_postinstall.js b/_postinstall.js
index <HASH>..<HASH> 100755
--- a/_postinstall.js
+++ b/_postinstall.js
@@ -60,7 +60,7 @@ try {
"https://www.bbcweb3hytmzhn5d532owbu6oqadra5z3ar726vq5kgwwn6aucdccrad.onion/russian"
),
"", flags(), "", bold("Прекратите эту бессмысленную агрессию! Остановите Путина!"), "",
- bold("Не позволяйте ФСБ управлять Россией. Верните его Людям!") + "\x1b[39m", "",
+ bold("Не позволяйте ФСБ управлять Россией. Верните её Людям!") + "\x1b[39m", "",
flags(), ""
].join("\n")
);
|
refactor: Fixed pronoun in manifest (#<I>)
|
medikoo_es5-ext
|
train
|
js
|
5e896927ccb0df351239d670f1ebf70d92c5c2a4
|
diff --git a/flask_appbuilder/static/appbuilder/js/ab.js b/flask_appbuilder/static/appbuilder/js/ab.js
index <HASH>..<HASH> 100644
--- a/flask_appbuilder/static/appbuilder/js/ab.js
+++ b/flask_appbuilder/static/appbuilder/js/ab.js
@@ -51,9 +51,9 @@ $(function() {
$('.appbuilder_date').datetimepicker({
pickTime: false });
$(".my_select2").select2({placeholder: "Select a State", allowClear: true});
+ $(".my_select2.readonly").select2("readonly", true);
loadSelectData();
loadSelectDataSlave();
- $(".my_select2.readonly").attr("readonly", "readonly");
$("a").tooltip({container:'.row', 'placement': 'bottom'});
});
|
fix(js): select2 readonly not working (#<I>)
|
dpgaspar_Flask-AppBuilder
|
train
|
js
|
57ba4a84cd03ddb6c771ac19613c38cdf740d4a2
|
diff --git a/src/HttpAnswer.js b/src/HttpAnswer.js
index <HASH>..<HASH> 100644
--- a/src/HttpAnswer.js
+++ b/src/HttpAnswer.js
@@ -138,7 +138,9 @@ HttpAnswer.prototype.end = function(){
}
if( ! this.answered() ){
- this._native.writeHead(this._statusCode, this._headers);
+ //this.writeHeads(this._statusCode, this._headers);
+ this._native.statusCode = this._statusCode;
+ setHeaders(this._native, this);
if( isStream(this.data) ){
pump(this.data, this._native);
}else{
@@ -150,6 +152,14 @@ HttpAnswer.prototype.end = function(){
}
}
+function setHeaders(nativeResponse, wrapper){
+ const headers = Object.keys( wrapper._headers );
+
+ for(let i=0; i< headers.length; i++){
+ nativeResponse.setHeader( headers[i], wrapper._headers[ headers[i] ]);
+ }
+}
+
//TODO: test
// Check section https://tools.ietf.org/html/rfc7230#section-3.3.2
// we should not send content-length for status code < 200, 204.
|
fix: don't send the headers in advance.
as many libraries send the headers when they start sending the stream.
|
node-muneem_muneem
|
train
|
js
|
91b3f6337add88cc03947beacc33233aaa81cbc3
|
diff --git a/index.js b/index.js
index <HASH>..<HASH> 100644
--- a/index.js
+++ b/index.js
@@ -6,10 +6,15 @@ var path = require("path");
module.exports = function (content, sourceMap) {
this.cacheable && this.cacheable();
var resourceDir = path.dirname(this.resourcePath);
- var files = glob.sync(content.trim(), {
+ var pattern = content.trim();
+ var files = glob.sync(pattern, {
cwd: resourceDir
});
+ if (!files.length) {
+ this.emitWarning('Did not find anything for glob "' + pattern + '" in directory "' + resourceDir + '"');
+ }
+
return "module.exports = [\n" + files.map(function (file) {
return " require(" + JSON.stringify(file) + ")"
}).join(",\n") + "\n];"
|
feat: warn if there are no matches for the glob
|
joscha_less-vars-loader
|
train
|
js
|
abc4ce92980829cbfb39e9ca5b5c899f372e8c88
|
diff --git a/src/uiSelectController.js b/src/uiSelectController.js
index <HASH>..<HASH> 100644
--- a/src/uiSelectController.js
+++ b/src/uiSelectController.js
@@ -169,7 +169,6 @@ uis.controller('uiSelectCtrl',
}
ctrl.refreshItems = function (data){
- $scope.calculateDropdownPos();
data = data || ctrl.parserResult.source($scope);
var selectedItems = ctrl.selected;
//TODO should implement for single mode removeSelected
@@ -181,6 +180,9 @@ uis.controller('uiSelectCtrl',
ctrl.setItemsFn(filteredItems);
}
}
+ if (ctrl.dropdownPosition === 'auto' || ctrl.dropdownPosition === 'up'){
+ $scope.calculateDropdownPos();
+ }
};
// See https://github.com/angular/angular.js/blob/v1.2.15/src/ng/directive/ngRepeat.js#L259
|
fix(choices): avoid to recalculate position when set 'down'
|
angular-ui_ui-select
|
train
|
js
|
787075847bebc9c074c8cf900e91181dad816292
|
diff --git a/src/pandas_profiling/model/pandas/duplicates_pandas.py b/src/pandas_profiling/model/pandas/duplicates_pandas.py
index <HASH>..<HASH> 100644
--- a/src/pandas_profiling/model/pandas/duplicates_pandas.py
+++ b/src/pandas_profiling/model/pandas/duplicates_pandas.py
@@ -35,7 +35,7 @@ def pandas_get_duplicates(
duplicated_rows = df.duplicated(subset=supported_columns, keep=False)
duplicated_rows = (
df[duplicated_rows]
- .groupby(supported_columns)
+ .groupby(supported_columns, dropna=False)
.size()
.reset_index(name=duplicates_key)
)
|
fix: pandas groupby ignoring duplicates with nans
|
pandas-profiling_pandas-profiling
|
train
|
py
|
4b47987ab4dd628bc30f6a811082d80335c593e3
|
diff --git a/lib/zendesk_apps_support/product.rb b/lib/zendesk_apps_support/product.rb
index <HASH>..<HASH> 100644
--- a/lib/zendesk_apps_support/product.rb
+++ b/lib/zendesk_apps_support/product.rb
@@ -1,13 +1,13 @@
module ZendeskAppsSupport
module Product
- # The ids below match the values in the database, do not change them!
+ # The product code below match the values in the database, do not change them!
PRODUCTS_AVAILABLE = [
{
- id: 1,
+ code: 1,
name: 'support',
},
{
- id: 2,
+ code: 2,
name: 'zopim',
}
].freeze
|
fix(product): change id to code
|
zendesk_zendesk_apps_support
|
train
|
rb
|
d2aa63d0610d5fadabc7057916f772fa3af7d007
|
diff --git a/lib/index.js b/lib/index.js
index <HASH>..<HASH> 100644
--- a/lib/index.js
+++ b/lib/index.js
@@ -26,7 +26,7 @@ function proxy(callback) {
.concat(require('./inspectors'))
.concat(config.middlewares)
.concat(require('./handlers'));
- server.timeout = config.idleTimeout;
+ server.timeout = server.keepAliveTimeout = config.idleTimeout;
proxyEvents.config = config;
app.logger = logger;
middlewares.forEach(function(mw) {
|
refactor: Reset server.keepAliveTimeout
|
avwo_whistle
|
train
|
js
|
38036c6422883a67bd8c510ee732748a046feb94
|
diff --git a/index.js b/index.js
index <HASH>..<HASH> 100644
--- a/index.js
+++ b/index.js
@@ -2,6 +2,7 @@
const fs = require('fs');
const path = require('path');
+const isJSON = require('is-json');
const posthtml = require('posthtml');
const render = require('posthtml-render');
const match = require('posthtml-match-helper');
@@ -67,7 +68,17 @@ function parse(options) {
})
.then(tree => {
// Remove <content> tags and replace them with node's content
- const content = tree.match(match('content'), () => node.content || '');
+ const content = tree.match(match('content'), () => {
+ if (
+ node.content &&
+ node.attrs &&
+ isJSON(node.attrs.locals)
+ ) {
+ return parseLocals(node.attrs.locals)(node.content);
+ }
+
+ return node.content || '';
+ });
// Remove <module> tag and set inner content
node.tag = false;
node.content = content;
|
fix: fails to parse expressions in <content>, close #<I>
|
posthtml_posthtml-modules
|
train
|
js
|
f7f7cd9d3810ccedfb4779f308ee1374edf9c4e4
|
diff --git a/src/directives/formBuilderDnd.js b/src/directives/formBuilderDnd.js
index <HASH>..<HASH> 100644
--- a/src/directives/formBuilderDnd.js
+++ b/src/directives/formBuilderDnd.js
@@ -38,7 +38,7 @@ module.exports = [
$scope.addComponent = function(component, index) {
// Only edit immediately for components that are not resource comps.
- if (!component.lockConfiguration && (!component.key || (component.key.indexOf('.') === -1))) {
+ if (component.isNew && !component.lockConfiguration && (!component.key || (component.key.indexOf('.') === -1))) {
// Force the component to be flagged as new.
component.isNew = true;
|
fix: only edit newly-added components
If component has been added before, don’t open the edit modal again.
That should fix this issues/<I>
|
formio_ngFormBuilder
|
train
|
js
|
d91e8ca358e468857494d19277d420b7da4ddbb5
|
diff --git a/demo/common/assets.js b/demo/common/assets.js
index <HASH>..<HASH> 100644
--- a/demo/common/assets.js
+++ b/demo/common/assets.js
@@ -754,7 +754,7 @@ shakaAssets.testAssets = [
new ShakaDemoAssetInfo(
/* name= */ 'Low Latency DASH Live',
/* iconUri= */ 'https://storage.googleapis.com/shaka-asset-icons/dash_if_test_pattern.png',
- /* manifestUri= */ 'https://vm2.dashif.org/livesim-chunked/chunkdur_1/ato_7/testpic4_8s/Manifest300.mpd',
+ /* manifestUri= */ 'https://livesim.dashif.org/livesim-chunked/chunkdur_1/ato_7/testpic4_8s/Manifest300.mpd',
/* source= */ shakaAssets.Source.SHAKA)
.addFeature(shakaAssets.Feature.DASH)
.addFeature(shakaAssets.Feature.LIVE)
|
fix: Update low latency dash manifest url
Issue #<I>
Change-Id: I<I>ce<I>cc<I>b<I>fbf<I>b<I>d<I>fa<I>ab
|
google_shaka-player
|
train
|
js
|
ba64c56a298e2af4b74f3e0f4bc870278fffc665
|
diff --git a/service.js b/service.js
index <HASH>..<HASH> 100755
--- a/service.js
+++ b/service.js
@@ -262,7 +262,7 @@ class ServiceConsul extends service.Service {
timeoutForTransition(transition) {
if (transition.name === 'start') {
- return this.startTimeout * 1000; // 600000;
+ return this.startTimeout * 1000;
}
return super.timeoutForTransition(transition);
@@ -309,8 +309,8 @@ class ServiceConsul extends service.Service {
return Promise.resolve();
}), {
- maxAttempts: 5,
- minTimeout: 1000,
+ maxAttempts: 10,
+ minTimeout: 5000,
maxTimeout: this.startTimeout * 1000,
throttle: 1000,
boolRetryFn(e, options) {
|
fix: increase minTimout slightly
|
Kronos-Integration_kronos-service-consul
|
train
|
js
|
c3470b5fe1271bdf85dd8628e47146d0dfd7f42b
|
diff --git a/src/main.js b/src/main.js
index <HASH>..<HASH> 100644
--- a/src/main.js
+++ b/src/main.js
@@ -218,6 +218,12 @@ function configureCommandlineSwitchesSync(cliArgs) {
}
});
+ /* Following features are disabled from the runtime.
+ * `CalculateNativeWinOcclusion` - Disable native window occlusion tracker,
+ * Refs https://groups.google.com/a/chromium.org/g/embedder-dev/c/ZF3uHHyWLKw/m/VDN2hDXMAAAJ
+ */
+ app.commandLine.appendSwitch('disable-features', 'CalculateNativeWinOcclusion');
+
// Support JS Flags
const jsFlags = getJSFlags(cliArgs);
if (jsFlags) {
|
fix: disable occlusion tracker on windows (#<I>)
|
Microsoft_vscode
|
train
|
js
|
b46d7fd5271a103a23c35a6988847b260d07329d
|
diff --git a/pkg/kube/wait.go b/pkg/kube/wait.go
index <HASH>..<HASH> 100644
--- a/pkg/kube/wait.go
+++ b/pkg/kube/wait.go
@@ -267,7 +267,10 @@ func (w *waiter) statefulSetReady(sts *appsv1.StatefulSet) bool {
var partition int
// 1 is the default for replicas if not set
var replicas = 1
- if sts.Spec.UpdateStrategy.RollingUpdate.Partition != nil {
+ // For some reason, even if the update strategy is a rolling update, the
+ // actual rollingUpdate field can be nil. If it is, we can safely assume
+ // there is no partition value
+ if sts.Spec.UpdateStrategy.RollingUpdate != nil && sts.Spec.UpdateStrategy.RollingUpdate.Partition != nil {
partition = int(*sts.Spec.UpdateStrategy.RollingUpdate.Partition)
}
if sts.Spec.Replicas != nil {
|
fix(kube): Fixes nil panic with stateful set waiting
Sometimes the stateful set `rollingUpdate` field can be nil even when the
strategy is a rolling update
Fixes #<I>
|
helm_helm
|
train
|
go
|
05d5fbf09094501e8243b9beb80794f1b64713a4
|
diff --git a/packages/www/gulpfile.js b/packages/www/gulpfile.js
index <HASH>..<HASH> 100644
--- a/packages/www/gulpfile.js
+++ b/packages/www/gulpfile.js
@@ -56,7 +56,7 @@ const buildViewForPageUrl = (basename, pageUrl = config.get("www.publishUrl")) =
packageJson,
pageUrl,
injectedScript: [
- `<script type="text/javascript">window.$crisp=[];window.CRISP_WEBSITE_ID="${config.get("crisp.app.id")}";(function(){d=document;s=d.createElement("script");s.src="https://client.crisp.chat/l.js";s.async=1;d.getElementsByTagName("head")[0].appendChild(s);})();</script>`
+ `<script>window.$crisp=[];window.CRISP_WEBSITE_ID="${config.get("crisp.app.id")}";(function(){d=document;s=d.createElement("script");s.src="https://client.crisp.chat/l.js";s.async=1;d.getElementsByTagName("head")[0].appendChild(s);})();</script>`
].join("")
})
}))
|
chore: `<script type="application/javascript">` -> `<script>`.
|
randytarampi_me
|
train
|
js
|
9c12d96809f0a47d89a79fcd864527d3a3bab6af
|
diff --git a/bootstrap.php b/bootstrap.php
index <HASH>..<HASH> 100644
--- a/bootstrap.php
+++ b/bootstrap.php
@@ -20,8 +20,4 @@ if (!($settings = include(__DIR__ . '/config.php'))) {
throw new \RuntimeException('Could not read config.php, please copy config.php-DEVELOPMENT to config.php & customize to your needs!');
}
-// Class alias used for BC
-// // Enables old code which still extends non namespaced TestCase to work
-class_alias('PHPUnit\Framework\TestCase', 'PHPUnit_Framework_TestCase');
-
require_once __DIR__ . '/vendor/autoload.php';
|
fix: remove conflicting class_alias from boostrap.php
|
ezsystems_ezpublish-kernel
|
train
|
php
|
51c2e19e874be6a7a203cb77829ac9b29dbf1946
|
diff --git a/lib/core/utils/flattened-tree.js b/lib/core/utils/flattened-tree.js
index <HASH>..<HASH> 100644
--- a/lib/core/utils/flattened-tree.js
+++ b/lib/core/utils/flattened-tree.js
@@ -34,13 +34,13 @@ function virtualDOMfromNode(node, shadowId) {
actualNode: node,
_isHidden: null, // will be populated by axe.utils.isHidden
get isFocusable() {
- if (!vNodeCache._isFocusable) {
+ if (!vNodeCache.hasOwnProperty('_isFocusable')) {
vNodeCache._isFocusable = axe.commons.dom.isFocusable(node);
}
return vNodeCache._isFocusable;
},
get tabbableElements() {
- if (!vNodeCache._tabbableElements) {
+ if (!vNodeCache.hasOwnProperty('_tabbableElements')) {
vNodeCache._tabbableElements = axe.commons.dom.getTabbableElements(
this
);
|
fix: check if property exists in cache of flattenedTree (#<I>)
|
dequelabs_axe-core
|
train
|
js
|
da1bb94579c1898d1bbb2a2e43cf1cea8ebebb73
|
diff --git a/src/Cache/FileStore.php b/src/Cache/FileStore.php
index <HASH>..<HASH> 100644
--- a/src/Cache/FileStore.php
+++ b/src/Cache/FileStore.php
@@ -167,7 +167,13 @@ class FileStore extends AbstractCache
public function sharedGet(string $path): string
{
return $this->lock($path, LOCK_SH, function ($handle) use ($path) {
- return fread($handle, filesize($path) ?: 1);
+ $contents = fread($handle, filesize($path) ?: 1);
+
+ if (false === $contents) {
+ return '';
+ }
+
+ return $contents;
});
}
@@ -198,7 +204,7 @@ class FileStore extends AbstractCache
}
return $this->lock($cacheFile, LOCK_EX, function ($handle) use ($cacheKey, $cacheFile, $value) {
- $contents = fread($handle, filesize($cacheFile) ?: 1) ?? [];
+ $contents = fread($handle, filesize($cacheFile) ?: 1) ?? '';
$contents = json_decode($contents, true) ?? [];
if ( ! empty($contents[$cacheKey]) && \is_array($value)) {
|
fix: Typecast issues (#<I>)
|
ankitpokhrel_tus-php
|
train
|
php
|
e05cc61b745c4263b4ff8145c897a424a7e6a1ad
|
diff --git a/quasar/src/components/field/QField.js b/quasar/src/components/field/QField.js
index <HASH>..<HASH> 100644
--- a/quasar/src/components/field/QField.js
+++ b/quasar/src/components/field/QField.js
@@ -47,7 +47,7 @@ export default Vue.extend({
},
floatingLabel () {
- return this.stackLabel || this.focused || (this.innerValue && this.innerValue.length > 0)
+ return this.stackLabel || this.focused || (this.innerValue !== void 0 && ('' + this.innerValue).length > 0)
},
hasBottom () {
|
fix(quasar): [v1] QInput with type=number label will not float with default value #<I>
|
quasarframework_quasar
|
train
|
js
|
509f05507968034f9b775e6325ec2f033d1159a7
|
diff --git a/lib/client.js b/lib/client.js
index <HASH>..<HASH> 100644
--- a/lib/client.js
+++ b/lib/client.js
@@ -423,7 +423,6 @@ let currentParser = null
let currentBufferRef = null
let currentBufferSize = 16384
let currentBufferPtr = llhttp.exports.malloc(currentBufferSize)
-let currentBufferView = new Uint8Array(llhttp.exports.memory.buffer, currentBufferPtr, currentBufferSize)
const TIMEOUT_HEADERS = 1
const TIMEOUT_BODY = 2
@@ -506,11 +505,10 @@ class Parser {
llhttp.exports.free(currentBufferPtr)
currentBufferSize = Math.ceil(data.length / 4096) * 4096
currentBufferPtr = llhttp.exports.malloc(currentBufferSize)
- currentBufferView = new Uint8Array(llhttp.exports.memory.buffer, currentBufferPtr, currentBufferSize)
}
// TODO (perf): Can we avoid this copy somehow?
- currentBufferView.set(data)
+ new Uint8Array(llhttp.exports.memory.buffer, currentBufferPtr, currentBufferSize).set(data)
// Call `execute` on the wasm parser.
// We pass the `llhttp_parser` pointer address, the pointer address of buffer view data,
|
fix: detached buffer error (#<I>)
Somehow the error "Cannot perform %TypedArray%.prototype.set on a detached ArrayBuffer" occurs when using a saved buffer view.
|
mcollina_undici
|
train
|
js
|
444c05ff59fe95e018e3ea820161c322f7572f05
|
diff --git a/packages/components/bolt-trigger/__tests__/trigger.e2e.js b/packages/components/bolt-trigger/__tests__/trigger.e2e.js
index <HASH>..<HASH> 100644
--- a/packages/components/bolt-trigger/__tests__/trigger.e2e.js
+++ b/packages/components/bolt-trigger/__tests__/trigger.e2e.js
@@ -13,6 +13,7 @@ module.exports = {
`${testingUrl}/pattern-lab/patterns/02-components-trigger-30-trigger-advanced-usage/02-components-trigger-30-trigger-advanced-usage.html`,
)
.waitForElementVisible('bolt-trigger[on-click="show"]', 2000)
+ .pause(1000)
.click('bolt-trigger[on-click="show"]')
.pause(1000)
.execute(
|
test: try waiting for lazy images to load
|
bolt-design-system_bolt
|
train
|
js
|
890d3a25c425ad28b9f0679f2ac70802223c9dc5
|
diff --git a/packages/d3fc-webgl/src/buffers/constantAttribute.js b/packages/d3fc-webgl/src/buffers/constantAttribute.js
index <HASH>..<HASH> 100644
--- a/packages/d3fc-webgl/src/buffers/constantAttribute.js
+++ b/packages/d3fc-webgl/src/buffers/constantAttribute.js
@@ -1,9 +1,9 @@
import baseAttributeBuilder from './baseAttribute';
import { rebind } from '@d3fc/d3fc-rebind';
-export default () => {
+export default initialValue => {
const base = baseAttributeBuilder().divisor(1);
- let value = null;
+ let value = initialValue;
const constantAttribute = programBuilder => {
base(programBuilder);
|
feat: support initialValue for constantAttribute
|
d3fc_d3fc
|
train
|
js
|
651490f9614de677b770fdadb58b0afaa5b6ac30
|
diff --git a/app/lib/webpack/ssr/plugin.webserver-assets.js b/app/lib/webpack/ssr/plugin.webserver-assets.js
index <HASH>..<HASH> 100644
--- a/app/lib/webpack/ssr/plugin.webserver-assets.js
+++ b/app/lib/webpack/ssr/plugin.webserver-assets.js
@@ -59,10 +59,6 @@ module.exports = class WebserverAssetsPlugin {
quasar: { ssr: true }
}
- if (this.cfg.store) {
- pkg.dependencies.vuex = cliDeps.vuex
- }
-
if (this.cfg.ssr.extendPackageJson) {
this.cfg.ssr.extendPackageJson(pkg)
}
|
fix(app): removed vuex from ssr package.json (#<I>)
|
quasarframework_quasar
|
train
|
js
|
5c85df90d55d4e1a9ebb3306e7764699ea30c360
|
diff --git a/util/rbac/rbac.go b/util/rbac/rbac.go
index <HASH>..<HASH> 100644
--- a/util/rbac/rbac.go
+++ b/util/rbac/rbac.go
@@ -470,6 +470,12 @@ func loadPolicyLine(line string, model model.Model) error {
key := tokens[0]
sec := key[:1]
+ if _, ok := model[sec]; !ok {
+ return fmt.Errorf("invalid RBAC policy: %s", line)
+ }
+ if _, ok := model[sec][key]; !ok {
+ return fmt.Errorf("invalid RBAC policy: %s", line)
+ }
model[sec][key].Policy = append(model[sec][key].Policy, tokens[1:])
return nil
}
|
fix: Fix a possible crash when parsing RBAC (#<I>)
|
argoproj_argo-cd
|
train
|
go
|
d3ca14947416ea35cbe4540afe7a0a08cbfb14d8
|
diff --git a/src/core/Node.js b/src/core/Node.js
index <HASH>..<HASH> 100644
--- a/src/core/Node.js
+++ b/src/core/Node.js
@@ -88,8 +88,8 @@ let Node = Mixin(Base => {
return self
},
- updated(oldProps, newProps, modifiedProps) {
- Super(this).updated(oldProps, newProps, modifiedProps)
+ updated(oldProps, modifiedProps) {
+ Super(this).updated(oldProps, modifiedProps)
if (modifiedProps.visible) {
this._elementOperations.shouldRender(this.visible)
|
fix: forgot to update Node.updated parameters based on last commit
|
trusktr_infamous
|
train
|
js
|
bd58f00b59843480fd87311fbae620cf5f6360bb
|
diff --git a/src/authentication.js b/src/authentication.js
index <HASH>..<HASH> 100644
--- a/src/authentication.js
+++ b/src/authentication.js
@@ -8,7 +8,10 @@ export class Authentication {
constructor(storage, config) {
this.storage = storage;
this.config = config.current;
- this.tokenName = this.config.tokenPrefix ? this.config.tokenPrefix + '_' + this.config.tokenName : this.config.tokenName;
+ }
+
+ get tokenName() {
+ return this.config.tokenPrefix ? this.config.tokenPrefix + '_' + this.config.tokenName : this.config.tokenName;
}
getLoginRoute() {
|
fix(authentication): use current tokenName
|
SpoonX_aurelia-authentication
|
train
|
js
|
92fd667e9a1566ecb0fdbd8aea2439705b7a807b
|
diff --git a/cobra/flux_analysis/summary.py b/cobra/flux_analysis/summary.py
index <HASH>..<HASH> 100644
--- a/cobra/flux_analysis/summary.py
+++ b/cobra/flux_analysis/summary.py
@@ -136,14 +136,14 @@ def model_summary(model, threshold=1E-8, fva=None, floatfmt='.3g',
lambda x: format_long_string(x.name.id, 15), 1)
# Build a dictionary of metabolite production from the boundary reactions
- # collect rxn.x before fva which invalidates previous solver state
+ # collect rxn.flux before fva which invalidates previous solver state
boundary_reactions = model.exchanges
metabolite_fluxes = {}
for rxn in boundary_reactions:
for met, stoich in iteritems(rxn.metabolites):
metabolite_fluxes[met] = {
'id': format_long_string(met.id, 15),
- 'flux': stoich * rxn.x}
+ 'flux': stoich * rxn.flux}
# Calculate FVA results if requested
if fva:
|
refactor: remove rxn.x call in summary (#<I>)
|
opencobra_cobrapy
|
train
|
py
|
3f808661ce1e44a28602715cccfad096332b9d03
|
diff --git a/workflow/controller/operator.go b/workflow/controller/operator.go
index <HASH>..<HASH> 100644
--- a/workflow/controller/operator.go
+++ b/workflow/controller/operator.go
@@ -2798,7 +2798,7 @@ func parseStringToDuration(durationString string) (time.Duration, error) {
} else if duration, err := time.ParseDuration(durationString); err == nil {
suspendDuration = duration
} else {
- return 0, fmt.Errorf("unable to parse %s as a duration", durationString)
+ return 0, fmt.Errorf("unable to parse %s as a duration: %w", durationString, err)
}
return suspendDuration, nil
}
|
chore: Surface parse duration error in operator (#<I>)
|
argoproj_argo
|
train
|
go
|
04fa40d94cad83b4e3b03bbb58c9c9b2805760d4
|
diff --git a/src/electronApi.js b/src/electronApi.js
index <HASH>..<HASH> 100644
--- a/src/electronApi.js
+++ b/src/electronApi.js
@@ -4,6 +4,7 @@
* Split Electron API from the main code
*/
+var path = require('path');
var electron;
try {
// eslint-disable-next-line global-require
@@ -119,7 +120,8 @@ function isDev() {
}
if (typeof process.execPath === 'string') {
- return process.execPath.toLowerCase().endsWith('electron');
+ var execFileName = path.basename(process.execPath).toLowerCase();
+ return execFileName.startsWith('electron');
}
return process.env.NODE_ENV === 'development'
|
fix(api): isDev should work properly when execName starts with electron
|
megahertz_electron-log
|
train
|
js
|
e87b421dd91979c321035ffdd097238799bcfd26
|
diff --git a/app/lib/webpack/electron/create-node-chain.js b/app/lib/webpack/electron/create-node-chain.js
index <HASH>..<HASH> 100644
--- a/app/lib/webpack/electron/create-node-chain.js
+++ b/app/lib/webpack/electron/create-node-chain.js
@@ -68,6 +68,11 @@ module.exports = (nodeType, cfg, configName) => {
.use('ts-loader')
.loader('ts-loader')
.options({
+ // While `noEmit: true` is needed in the tsconfig preset to prevent VSCode errors,
+ // it prevents emitting transpiled files when run into node context
+ compilerOptions: {
+ noEmit: false
+ },
onlyCompileBundledFiles: true,
transpileOnly: false
})
|
fix(app): fix TS file support for electron
|
quasarframework_quasar
|
train
|
js
|
023bdcf1217b8f86de250f53391ad3b1e356949d
|
diff --git a/storage/memory.go b/storage/memory.go
index <HASH>..<HASH> 100644
--- a/storage/memory.go
+++ b/storage/memory.go
@@ -187,11 +187,6 @@ func (s *MemoryStore) InvalidateAuthorizeCodeSession(ctx context.Context, code s
return nil
}
-func (s *MemoryStore) DeleteAuthorizeCodeSession(_ context.Context, code string) error {
- delete(s.AuthorizeCodes, code)
- return nil
-}
-
func (s *MemoryStore) CreatePKCERequestSession(_ context.Context, code string, req fosite.Requester) error {
s.PKCES[code] = req
return nil
@@ -248,11 +243,6 @@ func (s *MemoryStore) DeleteRefreshTokenSession(_ context.Context, signature str
return nil
}
-func (s *MemoryStore) CreateImplicitAccessTokenSession(_ context.Context, code string, req fosite.Requester) error {
- s.Implicit[code] = req
- return nil
-}
-
func (s *MemoryStore) Authenticate(_ context.Context, name string, secret string) error {
rel, ok := s.Users[name]
if !ok {
|
fix(storage): remove unused methods (#<I>)
|
ory_fosite
|
train
|
go
|
cc6b7a4863b73ffa499ab9c70aea3e3f53c2c171
|
diff --git a/index.js b/index.js
index <HASH>..<HASH> 100644
--- a/index.js
+++ b/index.js
@@ -21,7 +21,7 @@ function addValueBindLocator() {
function loadAndWaitForAureliaPage(pageUrl) {
browser.get(pageUrl);
- return browser.executeAsyncScript(
+ return browser.executeScript(
'var cb = arguments[arguments.length - 1];' +
'if (window.webpackJsonp && document.querySelector("[aurelia-app]")) { cb("Aurelia composed") }' +
'document.addEventListener("aurelia-composed", function (e) {' +
@@ -33,7 +33,7 @@ function loadAndWaitForAureliaPage(pageUrl) {
}
function waitForRouterComplete() {
- return browser.executeAsyncScript(
+ return browser.executeScript(
'var cb = arguments[arguments.length - 1];' +
'document.querySelector("[aurelia-app]")' +
'.aurelia.subscribeOnce("router:navigation:complete", function() {' +
|
fix(index): Replace executeAyncScript with executeScript (#4)
Fixes the issue described in: <URL>
|
aurelia_protractor-plugin
|
train
|
js
|
c9117941c9ddb5661e9daa7ad1263fc8e84df989
|
diff --git a/src/Traits/Stats.php b/src/Traits/Stats.php
index <HASH>..<HASH> 100644
--- a/src/Traits/Stats.php
+++ b/src/Traits/Stats.php
@@ -26,10 +26,10 @@ use Illuminate\Support\Collection;
use Illuminate\Support\Facades\DB;
use Seat\Eveapi\Models\Character\CharacterInfoSkill;
use Seat\Eveapi\Models\Character\CharacterSkill;
-use Seat\Eveapi\Models\Character\CharacterWalletJournal;
use Seat\Eveapi\Models\Industry\CharacterMining;
use Seat\Eveapi\Models\Killmails\KillmailDetail;
use Seat\Eveapi\Models\Wallet\CharacterWalletBalance;
+use Seat\Eveapi\Models\Wallet\CharacterWalletJournal;
/**
* Class Stats.
|
fix: correct path for CharacterWallet Journal class (#<I>)
* Correct path for CharacterWallet Journal class
* Update Stats.php
Changed import order per CI
|
eveseat_web
|
train
|
php
|
ab48ad8f12d95783b819836e707292a9610f6cb6
|
diff --git a/tests/compiler/LLL/test_optimize_lll.py b/tests/compiler/LLL/test_optimize_lll.py
index <HASH>..<HASH> 100644
--- a/tests/compiler/LLL/test_optimize_lll.py
+++ b/tests/compiler/LLL/test_optimize_lll.py
@@ -7,7 +7,6 @@ optimize_list = [
(["ne", 1, 0], ["ne", 1, 0]), # noop
(["if", ["ne", 1, 0], "pass"], ["if", ["xor", 1, 0], "pass"]),
(["assert", ["ne", 1, 0]], ["assert", ["xor", 1, 0]]),
- (["assert_reason", ["ne", 1, 0], 0, 0], ["assert_reason", ["xor", 1, 0], 0, 0]),
(["mstore", 0, ["ne", 1, 0]], ["mstore", 0, ["ne", 1, 0]]), # noop
]
|
test: remove `assert_reason` macro from test cases
|
ethereum_vyper
|
train
|
py
|
05114e438c730cfff851ffa8589913eb0722bcf7
|
diff --git a/packages/plugin-credentials/test/unit/spec/credentials.js b/packages/plugin-credentials/test/unit/spec/credentials.js
index <HASH>..<HASH> 100644
--- a/packages/plugin-credentials/test/unit/spec/credentials.js
+++ b/packages/plugin-credentials/test/unit/spec/credentials.js
@@ -115,7 +115,12 @@ describe(`plugin-credentials`, () => {
})));
});
- it(`falls back to the supertoken`, () => assert.becomes(spark.credentials.getUserToken(`spark:kms`), supertoken));
+ // Note: don't use becomes here. they are different state objects, so
+ // they have different cids. as such, the assertion fails, but then
+ // hangs (I think) because there's a recursive loop trying to render the
+ // diff.
+ it(`falls back to the supertoken`, () => assert.isFulfilled(spark.credentials.getUserToken(`spark:kms`))
+ .then((token) => assert.deepEqual(token.serialize(), supertoken.serialize())));
});
it(`blocks while a token refresh is inflight`, () => {
|
fix(plugin-credentials): fix comparison that can never pass
|
webex_spark-js-sdk
|
train
|
js
|
8ba61284a41324224156038d29b208a7b72c6588
|
diff --git a/anyconfig/inputs.py b/anyconfig/inputs.py
index <HASH>..<HASH> 100644
--- a/anyconfig/inputs.py
+++ b/anyconfig/inputs.py
@@ -140,6 +140,9 @@ def find_parser(ipath, cps_by_ext, cps_by_type, forced_type=None):
if (ipath is None or not ipath) and forced_type is None:
raise ValueError("ipath or forced_type must be some value")
+ if isinstance(forced_type, anyconfig.backend.base.Parser):
+ return forced_type
+
if forced_type is None:
parser = find_by_filepath(ipath, cps_by_ext)
if parser is None:
@@ -147,9 +150,6 @@ def find_parser(ipath, cps_by_ext, cps_by_type, forced_type=None):
return parser()
- if isinstance(forced_type, anyconfig.backend.base.Parser):
- return forced_type
-
parser = find_by_type(forced_type, cps_by_type)
if parser is None:
raise UnknownParserTypeError(forced_type)
|
fix: make .inputs.find_parser return the first arg if it's parser
.inputs.find_parser should return the first argument `ipath` at once if
it's a parser object but it was not and now that wrong behavior was
changed and corrected to do so.
|
ssato_python-anyconfig
|
train
|
py
|
b3db8fc285a1ba274ff63931da7278bae3c6af01
|
diff --git a/packages/openneuro-server/src/datalad/dataset.js b/packages/openneuro-server/src/datalad/dataset.js
index <HASH>..<HASH> 100644
--- a/packages/openneuro-server/src/datalad/dataset.js
+++ b/packages/openneuro-server/src/datalad/dataset.js
@@ -150,7 +150,7 @@ export const datasetsFilter = options => match => {
},
{
$match: {
- $in: [options.modality, 'summaries.0.modalities'],
+ 'summaries.0.modalities': options.modality,
},
},
],
|
fix: Fix regression with public dataset count
|
OpenNeuroOrg_openneuro
|
train
|
js
|
aee0f75c5512974b860043dd390994372961ba0f
|
diff --git a/ibm_watson/discovery_v1.py b/ibm_watson/discovery_v1.py
index <HASH>..<HASH> 100644
--- a/ibm_watson/discovery_v1.py
+++ b/ibm_watson/discovery_v1.py
@@ -1815,7 +1815,7 @@ class DiscoveryV1(BaseService):
parameter.
:param bool spelling_suggestions: (optional) When `true` and the
**natural_language_query** parameter is used, the **natural_languge_query**
- parameter is spell checked. The most likely correction is retunred in the
+ parameter is spell checked. The most likely correction is returned in the
**suggested_query** field of the response (if one exists).
**Important:** this parameter is only valid when using the Cloud Pak
version of Discovery.
|
docs: fix simple typo, retunred -> returned
There is a small typo in ibm_watson/discovery_v1.py.
Should read `returned` rather than `retunred`.
|
watson-developer-cloud_python-sdk
|
train
|
py
|
1db86b80644fd43336e1048d107cc5b8efdd9935
|
diff --git a/packages/drawer/src/react/index.js b/packages/drawer/src/react/index.js
index <HASH>..<HASH> 100644
--- a/packages/drawer/src/react/index.js
+++ b/packages/drawer/src/react/index.js
@@ -129,7 +129,7 @@ class Drawer extends React.Component {
<div>
<DrawerBase isOpen={isOpen} onClick={this.handleClick}>
<DrawerPanelContent themeName={themeName}>
- <Div marginTop={-1} padding={`0 ${core.layout.spacingMedium}`}>
+ <Div padding={`0 ${core.layout.spacingMedium}`}>
{this.props.base}
</Div>
</DrawerPanelContent>
|
refactor(drawer): don't overlap drawer base row border
first rows now have no border top
|
pluralsight_design-system
|
train
|
js
|
d115b0867895ba59b9dcb827dd22c773b69e189f
|
diff --git a/lib/icon/module.js b/lib/icon/module.js
index <HASH>..<HASH> 100755
--- a/lib/icon/module.js
+++ b/lib/icon/module.js
@@ -62,11 +62,11 @@ async function run (pwa, _emitAssets) {
// Verify purpose
if (options.purpose) {
- const purpose = Array.isArray(options.purpose) ? options.purpose : [options.purpose]
- const len = purpose.length
+ if (!Array.isArray(options.purpose)) {
+ options.purpose = [options.purpose]
+ }
const validPurpose = ['badge', 'maskable', 'any']
- options.purpose = purpose.filter(item => validPurpose.includes(item))
- if (len !== options.purpose.length) {
+ if (options.purpose.find(p => !validPurpose.includes(p))) {
// eslint-disable-next-line no-console
console.warn('[pwa] [icon] Some invalid items removed from `options.purpose`. Valid values: ' + validPurpose)
}
|
refactor: simplify purpose validation logic
|
nuxt-community_pwa-module
|
train
|
js
|
5e8504b121a8372a8534b1440c23c3fd157eb351
|
diff --git a/lib/plugins/load-plugin.js b/lib/plugins/load-plugin.js
index <HASH>..<HASH> 100644
--- a/lib/plugins/load-plugin.js
+++ b/lib/plugins/load-plugin.js
@@ -33,6 +33,7 @@ var framesCallbacks = [];
var MAX_LENGTH = 100;
var MAX_BUF_LEN = 1024 * 200;
var TIMEOUT = 600;
+var SERVER_TIMEOUT = 1000 * 60 * 60;
var REQ_INTERVAL = 30;
var pluginOpts, storage;
var pluginKeyMap = {};
@@ -1065,7 +1066,7 @@ module.exports = function(options, callback) {
startTunnelResWrite(tunnelResWrite, options);
tunnelResWritePort = _port;
}
- server.timeout = 0;
+ server.timeout = SERVER_TIMEOUT;
server.on('request', function(req, res) {
switch(getHookName(req)) {
case PLUGIN_HOOKS.UI:
|
refactor: set the plugin server.timeout = 1h
|
avwo_whistle
|
train
|
js
|
a15e6e70cede1fa7219410601f6103089ad8d054
|
diff --git a/quasar/src/components/input/QInput.js b/quasar/src/components/input/QInput.js
index <HASH>..<HASH> 100644
--- a/quasar/src/components/input/QInput.js
+++ b/quasar/src/components/input/QInput.js
@@ -97,6 +97,9 @@ export default Vue.extend({
__emitValue (val, stopWatcher) {
const fn = () => {
+ if (this.hasOwnProperty('tempValue') === true) {
+ delete this.tempValue
+ }
if (this.value !== val) {
stopWatcher === true && (this.stopValueWatcher = true)
this.$emit('input', val)
@@ -105,6 +108,7 @@ export default Vue.extend({
if (this.debounce !== void 0) {
clearTimeout(this.emitTimer)
+ this.tempValue = val
this.emitTimer = setTimeout(fn, this.debounce)
}
else {
@@ -154,7 +158,9 @@ export default Vue.extend({
attrs,
on,
domProps: {
- value: this.innerValue
+ value: this.hasOwnProperty('tempValue') === true
+ ? this.tempValue
+ : this.innerValue
}
})
}
|
fix(QInput): model when using debounce prop and Vue re-renders before QInput emits
|
quasarframework_quasar
|
train
|
js
|
42e441677952e165c17c3a57dd7014666043239e
|
diff --git a/packages/node_modules/@webex/internal-plugin-ediscovery/test/unit/spec/report.js b/packages/node_modules/@webex/internal-plugin-ediscovery/test/unit/spec/report.js
index <HASH>..<HASH> 100644
--- a/packages/node_modules/@webex/internal-plugin-ediscovery/test/unit/spec/report.js
+++ b/packages/node_modules/@webex/internal-plugin-ediscovery/test/unit/spec/report.js
@@ -41,7 +41,7 @@ describe('EDiscovery Report API Tests', () => {
describe('Get Reports Tests', () => {
it('getReportsSuccess', async () => {
- const result = spark.internal.ediscovery.getReports().then((res) => {
+ const result = spark.internal.ediscovery.getReports({}).then((res) => {
expect(res.statusCode).to.equal(200);
});
|
fix(ediscovery): fix test failure
|
webex_spark-js-sdk
|
train
|
js
|
e0bbf83b88e4a20e0a6900b9e3656732212aa7bd
|
diff --git a/packages/vaex-core/vaex/json.py b/packages/vaex-core/vaex/json.py
index <HASH>..<HASH> 100644
--- a/packages/vaex-core/vaex/json.py
+++ b/packages/vaex-core/vaex/json.py
@@ -52,12 +52,18 @@ class NumpySerializer:
@staticmethod
def encode(obj):
- values = obj.tolist()
+ if np.ma.isMaskedArray(obj):
+ values = obj.data.tolist()
+ mask = obj.mask.tolist()
+ else:
+ values = obj.tolist()
+ mask = None
dtype = str(obj.dtype)
return {
'type': 'ndarray',
'data': {
'values': values,
+ 'mask': mask,
'dtype': dtype
}
}
@@ -69,7 +75,10 @@ class NumpySerializer:
@staticmethod
def decode(data):
dtype = np.dtype(data['data']['dtype'])
- value = np.array(data['data']['values'], dtype)
+ if 'mask' in data['data'] and data['data']['mask'] is not None:
+ value = np.ma.array(data['data']['values'], mask=data['data']['mask'], dtype=dtype)
+ else:
+ value = np.array(data['data']['values'], dtype)
return value
|
feat(core): serialize masked arrays into JSON
|
vaexio_vaex
|
train
|
py
|
852f6f0b8bb70f2b03487c6073d7e17c7a97a566
|
diff --git a/epab/cmd/release.py b/epab/cmd/release.py
index <HASH>..<HASH> 100644
--- a/epab/cmd/release.py
+++ b/epab/cmd/release.py
@@ -69,7 +69,6 @@ def release(ctx, new_version):
do(ctx, sys.executable.replace('\\', '/') + ' setup.py bdist_wheel')
do(ctx, 'twine upload dist/* --skip-existing', mute_stdout=True, mute_stderr=True)
- repo_push(ctx)
repo_checkout(ctx, 'develop')
repo_push(ctx)
diff --git a/epab/utils/_repo.py b/epab/utils/_repo.py
index <HASH>..<HASH> 100644
--- a/epab/utils/_repo.py
+++ b/epab/utils/_repo.py
@@ -89,7 +89,7 @@ def repo_push(ctx: click.Context):
_info('Pushing repo to origin')
if dry_run(ctx):
return
- do(ctx, ['git', 'push', '--tags'])
+ do(ctx, ['git', 'push', '--all', '--tags'])
def repo_is_dirty(ctx: click.Context) -> bool:
|
fix: push all refs after release
|
etcher-be_epab
|
train
|
py,py
|
fc5f6eff5d0e76d716de227db3eccf48142ba99b
|
diff --git a/lib/Request.js b/lib/Request.js
index <HASH>..<HASH> 100644
--- a/lib/Request.js
+++ b/lib/Request.js
@@ -107,6 +107,7 @@ Request.prototype = {
data = JSON.parse(data);
} catch (err) {
reject(err);
+ return;
} finally {
//释放当前请求数
var count = +(config.requestLimit * (eval(res.headers[API_CALL_LIMIT]) + 1e-6)).toFixed(0);
|
fix: Cannot read property 'length' of undefined
|
yeezon_yhsd-api-node
|
train
|
js
|
9de814537eed3b571a52581376fe7d72c6f505f3
|
diff --git a/webapps/ui/cockpit/client/scripts/pages/dashboard.js b/webapps/ui/cockpit/client/scripts/pages/dashboard.js
index <HASH>..<HASH> 100644
--- a/webapps/ui/cockpit/client/scripts/pages/dashboard.js
+++ b/webapps/ui/cockpit/client/scripts/pages/dashboard.js
@@ -37,20 +37,6 @@ var Controller = [
$scope.mainPlugins = [];
$scope.miscPlugins = [];
- Views.getProviders({
- component: 'cockpit.dashboard.section'
- }).forEach(function(plugin) {
- (plugin.priority >= 0 ? $scope.mainPlugins : $scope.miscPlugins).push(plugin);
- if (plugin.getSparklineData) {
- if (typeof plugin.getSparklineData === 'function') {
- plugin.sparklineData = plugin.getSparklineData();
- }
- else if (Array.isArray(plugin.getSparklineData)) {
- plugin.sparklineData = $injector.invoke(plugin.getSparklineData);
- }
- }
- });
-
// old plugins are still shown on the dashboard
$scope.dashboardVars = { read: [ 'processData' ] };
$scope.deprecateDashboardProviders = Views.getProviders({ component: 'cockpit.dashboard'});
|
refactor(dashboard): remove some dead code
|
camunda_camunda-bpm-platform
|
train
|
js
|
0d83e493def6d5515b3f3537e73cbacd4c4a4516
|
diff --git a/cli.js b/cli.js
index <HASH>..<HASH> 100755
--- a/cli.js
+++ b/cli.js
@@ -18,7 +18,14 @@ process.cliLogger = require('webpack-log')({
const updateNotifier = require('update-notifier');
const packageJson = require('./package.json');
-updateNotifier({ pkg: packageJson }).notify();
+const notifier = updateNotifier({
+ pkg,
+ updateCheckInterval: 1000 * 60 * 60 * 24 * 7, // 1 week
+});
+
+if (notifier.update) {
+ console.log(`Update available: ${notifier.update.latest}`);
+}
const semver = require('semver');
|
feat: update notify period
set interval to be 1 week
|
webpack_webpack-cli
|
train
|
js
|
94de1f8e847326b37507bf7627f5c95ba8f5c0d2
|
diff --git a/test/support/prepare.js b/test/support/prepare.js
index <HASH>..<HASH> 100644
--- a/test/support/prepare.js
+++ b/test/support/prepare.js
@@ -15,7 +15,7 @@ const npmrc = [
fs.writeFileSync(join(tmpPath, '.npmrc'), npmrc, 'utf-8')
module.exports = function prepare (pkg) {
- const pkgTmpPath = join(tmpPath, Math.random().toString())
+ const pkgTmpPath = join(tmpPath, Number(new Date()).toString())
mkdirp.sync(pkgTmpPath)
const json = JSON.stringify(pkg || {})
fs.writeFileSync(join(pkgTmpPath, 'package.json'), json, 'utf-8')
|
refactor(tests): instead of random temp dir names, use date
It is easier to debug when the folders are sorted
|
pnpm_pnpm
|
train
|
js
|
cde3d8701d976b1b27ce8190514a29989a7041eb
|
diff --git a/lib/https/index.js b/lib/https/index.js
index <HASH>..<HASH> 100644
--- a/lib/https/index.js
+++ b/lib/https/index.js
@@ -334,6 +334,7 @@ function _handleWebsocket(socket, clientIp, clientPort, callback, wss) {
if (retryConnect) {
reqSocket.removeListener('error', retryConnect);
abortIfUnavailable(reqSocket);
+ retryConnect = null;
}
clearTimeout(timeout);
var resDelay = util.getMatcherValue(_rules.resDelay);
diff --git a/lib/tunnel.js b/lib/tunnel.js
index <HASH>..<HASH> 100644
--- a/lib/tunnel.js
+++ b/lib/tunnel.js
@@ -299,6 +299,7 @@ function tunnelProxy(server, proxy) {
if (retryConnect) {
resSocket.removeListener('error', retryConnect);
abortIfUnavailable(resSocket);
+ retryConnect = null;
}
reqSocket.headers = headers;
reqSocket.fullUrl = tunnelUrl;
|
refactor: retry connect if error
|
avwo_whistle
|
train
|
js,js
|
2187deb0a8cd2e5a8a00132954c815581dcd9390
|
diff --git a/templates/hooks/after_prepare/icons_and_splashscreens.js b/templates/hooks/after_prepare/icons_and_splashscreens.js
index <HASH>..<HASH> 100755
--- a/templates/hooks/after_prepare/icons_and_splashscreens.js
+++ b/templates/hooks/after_prepare/icons_and_splashscreens.js
@@ -47,7 +47,9 @@ function copyFile (src, dest, ncpOpts, callback) {
}
// Main
-var platforms = fs.readdirSync('platforms');
+var platforms = _.filter(fs.readdirSync('platforms'), function (file) {
+ return fs.statSync(path.resolve('platforms', file)).isDirectory();
+});
_.each(platforms, function (platform) {
var base = path.resolve('platforms', platform, BASES[platform]);
glob(base + '/**/*.png', function (err, files) {
|
fix(hook): Ignore non-directory platforms when processing icons and
splashscreens. Closes #<I>
|
diegonetto_generator-ionic
|
train
|
js
|
d53b1adc11c65bfb044c7bd4b3f79f602acf9728
|
diff --git a/src/Illuminate/Foundation/Bootstrap/LoadConfiguration.php b/src/Illuminate/Foundation/Bootstrap/LoadConfiguration.php
index <HASH>..<HASH> 100644
--- a/src/Illuminate/Foundation/Bootstrap/LoadConfiguration.php
+++ b/src/Illuminate/Foundation/Bootstrap/LoadConfiguration.php
@@ -24,7 +24,7 @@ class LoadConfiguration
// First we will see if we have a cache configuration file. If we do, we'll load
// the configuration items from that file so that it is very quick. Otherwise
// we will need to spin through every configuration file and load them all.
- if (is_file($cached = $app->getCachedConfigPath())) {
+ if (file_exists($cached = $app->getCachedConfigPath())) {
$items = require $cached;
$loadedFromCache = true;
|
fix: require fails if is_file cached by opcache (#<I>)
|
laravel_framework
|
train
|
php
|
b5dfcfbfda8a307f74a9650c216c349c4c3a864a
|
diff --git a/src/uploader/cos.js b/src/uploader/cos.js
index <HASH>..<HASH> 100644
--- a/src/uploader/cos.js
+++ b/src/uploader/cos.js
@@ -6,6 +6,7 @@
'use strict';
const request = require('superagent');
+const debug = require('debug')('cos');
const Promise = require('../promise');
module.exports = function upload(uploadInfo, data, file, saveOptions = {}) {
|
fix(File): add missing debug requirement
|
leancloud_javascript-sdk
|
train
|
js
|
987c4522f3449b91f9e9a8f54b15a02b5ae02633
|
diff --git a/mapillary_tools/process_geotag_properties.py b/mapillary_tools/process_geotag_properties.py
index <HASH>..<HASH> 100644
--- a/mapillary_tools/process_geotag_properties.py
+++ b/mapillary_tools/process_geotag_properties.py
@@ -57,7 +57,7 @@ def process_geotag_properties(import_path,
"failed",
verbose)
return
- elif geotag_source not in ["exif", 'blackvue'] and not os.path.isfile(geotag_source_path):
+ elif geotag_source != "exif" and not os.path.isfile(geotag_source_path) and not os.path.isdir(geotag_source_path):
print("Error, " + geotag_source_path +
" file source of gps/time properties does not exist. If geotagging from external log, rather than image EXIF, you need to provide full path to the log file.")
processing.create_and_log_process_in_list(process_file_list,
|
fix: gpx source condition
|
mapillary_mapillary_tools
|
train
|
py
|
5ab028a9128b289b0c840bdb6901021fc482e6f5
|
diff --git a/src/core/instance/inject.js b/src/core/instance/inject.js
index <HASH>..<HASH> 100644
--- a/src/core/instance/inject.js
+++ b/src/core/instance/inject.js
@@ -41,14 +41,13 @@ export function resolveInject (inject: any, vm: Component): ?Object {
// inject is :any because flow is not smart enough to figure out cached
const result = Object.create(null)
const keys = hasSymbol
- ? Reflect.ownKeys(inject).filter(key => {
- /* istanbul ignore next */
- return Object.getOwnPropertyDescriptor(inject, key).enumerable
- })
+ ? Reflect.ownKeys(inject)
: Object.keys(inject)
for (let i = 0; i < keys.length; i++) {
const key = keys[i]
+ // #6574 in case the inject object is observed...
+ if (key === '__ob__') continue
const provideKey = inject[key].from
let source = vm
while (source) {
|
refactor: speed up injection resolution
|
kaola-fed_megalo
|
train
|
js
|
34affc1a7a338aa372d5005472ea5c7d123547be
|
diff --git a/packages/vue-styleguidist/src/client/rsg-components/Usage/index.js b/packages/vue-styleguidist/src/client/rsg-components/Usage/index.js
index <HASH>..<HASH> 100644
--- a/packages/vue-styleguidist/src/client/rsg-components/Usage/index.js
+++ b/packages/vue-styleguidist/src/client/rsg-components/Usage/index.js
@@ -1 +1 @@
-export { default } from './Usage'
+export { default } from 'rsg-components/Usage/Usage'
|
style: allow customization of Usage component
|
vue-styleguidist_vue-styleguidist
|
train
|
js
|
f04f5de883cb2421c6bd9fb67951cdb5fc1eeff5
|
diff --git a/index.js b/index.js
index <HASH>..<HASH> 100644
--- a/index.js
+++ b/index.js
@@ -13,14 +13,19 @@ function walkLib ({ lib, parameters, pastParameters = [] }) {
}
const nextCommand = parameters.shift()
+ const nextLib = lib[nextCommand]
+
+ if (typeof nextLib === 'undefined') {
+ return {
+ command: lib,
+ parameters,
+ pastParameters
+ }
+ }
pastParameters.push(nextCommand)
- return walkLib({
- lib: lib[nextCommand],
- parameters,
- pastParameters
- })
+ return walkLib({ lib: nextLib, parameters, pastParameters })
}
async function execute ({
|
fix: when next command does not exist
|
gumieri_lib2cli
|
train
|
js
|
e41f3f74831e67b186ab4ff7d249148e829508c8
|
diff --git a/lib/client-base.js b/lib/client-base.js
index <HASH>..<HASH> 100644
--- a/lib/client-base.js
+++ b/lib/client-base.js
@@ -697,17 +697,16 @@ function resume (client) {
// TODO: Convert into buffer if ended && length > 0.
const state = body._readableState
- if (
- state && state.ended && state.length === 0 &&
- typeof body.destroy === 'function' && !body.destroyed
- ) {
+ if (state && state.ended && state.length === 0) {
// Wait for 'end' before destroying to avoid close before end errors.
body
.on('data', function () {
// TODO: What to do?
})
.on('end', function () {
- this.destroy()
+ if (typeof this.destroy === 'function' && !this.destroyed) {
+ this.destroy()
+ }
})
request.body = null
|
refactor: move body.destroy into end handler
|
mcollina_undici
|
train
|
js
|
d944f9e665988c073e9eab1a81b3b09c50a78506
|
diff --git a/test/output.js b/test/output.js
index <HASH>..<HASH> 100644
--- a/test/output.js
+++ b/test/output.js
@@ -1,3 +1,4 @@
+import path from 'path';
import test from 'ava';
import randomstring from 'randomstring';
import fs from 'fs-extra';
@@ -14,14 +15,16 @@ test('--output works', async t => {
});
test('preserve order with large number of files', async t => {
- const outputFile = tempy.file();
+ const tmp = tempy.directory();
+ const outputFile = path.join(tmp, 'output');
+
const outputFilePromises = [];
const filepaths = [];
const expected = [];
// eslint-disable-next-line no-magic-numbers
for (let i = 0; i < 100; i++) {
- const filepath = tempy.file();
+ const filepath = path.join(tmp, `file-${i}`);
const content = randomstring.generate();
filepaths.push(filepath);
|
test: improve test with large number of files
|
pvdlg_ncat
|
train
|
js
|
a9c195d5d765cc6604aab3fab3a1ac08a6551287
|
diff --git a/app/state.js b/app/state.js
index <HASH>..<HASH> 100644
--- a/app/state.js
+++ b/app/state.js
@@ -47,8 +47,8 @@ const initialState = {
y: 380,
},
},
- 8: {
- id: 8,
+ 5: {
+ id: 5,
typeId: 5,
patchId: 1,
position: {
diff --git a/test/reducersSpec.js b/test/reducersSpec.js
index <HASH>..<HASH> 100644
--- a/test/reducersSpec.js
+++ b/test/reducersSpec.js
@@ -1,5 +1,5 @@
import * as Actions from '../app/actions';
-import { initialState } from '../app/state';
+import initialState from '../app/state';
import { newId, nodes, lastId, copyNode } from '../app/reducers';
import chai from 'chai';
diff --git a/test/stateSpec.js b/test/stateSpec.js
index <HASH>..<HASH> 100644
--- a/test/stateSpec.js
+++ b/test/stateSpec.js
@@ -1,5 +1,5 @@
import { assert } from 'chai';
-import { initialState } from '../app/state';
+import initialState from '../app/state';
describe('Initial state', () => {
describe('node types', () => {
|
fix(tests): fix tests for merged version
|
xodio_xod
|
train
|
js,js,js
|
9c194aa7e2febeab0cbd895067d7d90d82b137f9
|
diff --git a/blocks/blockstore/bloom_cache.go b/blocks/blockstore/bloom_cache.go
index <HASH>..<HASH> 100644
--- a/blocks/blockstore/bloom_cache.go
+++ b/blocks/blockstore/bloom_cache.go
@@ -142,10 +142,7 @@ func (b *bloomcache) Get(k *cid.Cid) (blocks.Block, error) {
}
func (b *bloomcache) Put(bl blocks.Block) error {
- if has, ok := b.hasCached(bl.Cid()); ok && has {
- return nil
- }
-
+ // See comment in PutMany
err := b.blockstore.Put(bl)
if err == nil {
b.bloom.AddTS(bl.Cid().Bytes())
@@ -155,7 +152,7 @@ func (b *bloomcache) Put(bl blocks.Block) error {
func (b *bloomcache) PutMany(bs []blocks.Block) error {
// bloom cache gives only conclusive resulty if key is not contained
- // to reduce number of puts we need conclusive infomration if block is contained
+ // to reduce number of puts we need conclusive information if block is contained
// this means that PutMany can't be improved with bloom cache so we just
// just do a passthrough.
err := b.blockstore.PutMany(bs)
|
fix: remove bloom filter check on Put call in blockstore
To prevent put we need to have conclusive information if item is
contained in the repo, bloom filter won't give this information.
It only says if it is for sure not contained.
License: MIT
|
ipfs_go-ipfs
|
train
|
go
|
8a58d09665eba2ddb12a85424a16442e3e79dac5
|
diff --git a/lib/artillery-global.js b/lib/artillery-global.js
index <HASH>..<HASH> 100644
--- a/lib/artillery-global.js
+++ b/lib/artillery-global.js
@@ -45,11 +45,11 @@ async function createGlobalObject(opts) {
if (typeof opts === 'string') {
level = opts;
} else {
+ opts = opts || {};
level = opts.level || 'info';
}
opts.level = level;
-
global.artillery.globalEvents.emit('log', msg, opts);
},
|
fix(global): handle artillery.log() with just one argument
|
artilleryio_artillery
|
train
|
js
|
69a0eee52da983cfb517deee9b1db9f29bec85f2
|
diff --git a/vaex/file/other.py b/vaex/file/other.py
index <HASH>..<HASH> 100644
--- a/vaex/file/other.py
+++ b/vaex/file/other.py
@@ -382,7 +382,7 @@ class FitsBinTable(DatasetMemoryMapped):
else:
for i in range(arraylength):
name = column_name+"_" +str(i)
- self.addColumn(name, offset=offset+bytessize*i/arraylength, dtype=">" +dtypecode, length=length, stride=arraylength)
+ self.addColumn(name, offset=offset+bytessize*i//arraylength, dtype=">" +dtypecode, length=length, stride=arraylength)
if flatlength > 0: # flatlength can be
offset += bytessize * length
self._check_null(table, column_name, column, i)
|
fix: integer division for mmaped columns with arrays
|
vaexio_vaex
|
train
|
py
|
0dcbbd4d41d61169408517c947b14a7e7c8000af
|
diff --git a/packages/posts/test/integration/db/models/post.js b/packages/posts/test/integration/db/models/post.js
index <HASH>..<HASH> 100644
--- a/packages/posts/test/integration/db/models/post.js
+++ b/packages/posts/test/integration/db/models/post.js
@@ -3,6 +3,8 @@ import {expect} from "chai";
import PostModel, {createPost, createPosts, getPost, getPosts} from "../../../../db/models/post";
describe("Post", function () {
+ this.timeout(60000);
+
let stubPost;
let stubPhoto;
let stubPosts;
|
fix(posts): `Post` model integration tests timeout after <I>s.
Seems like they're actually running. Don't think any `sleep`ing is required.
|
randytarampi_me
|
train
|
js
|
61766e11098921c0df9f2bc4ba99339481a0597c
|
diff --git a/core/src/elements/base/base-input.js b/core/src/elements/base/base-input.js
index <HASH>..<HASH> 100755
--- a/core/src/elements/base/base-input.js
+++ b/core/src/elements/base/base-input.js
@@ -159,8 +159,4 @@ export default class BaseInputElement extends BaseElement {
get disabled() {
return this.hasAttribute('disabled');
}
-
- static get events() {
- return ['change', 'input', 'focus', 'focusin', 'focusout', 'blur'];
- }
}
|
refactor(base-input): Remove native events.
|
OnsenUI_OnsenUI
|
train
|
js
|
795b908095b29e76435479879c1ade7ef759ce7b
|
diff --git a/src/core/vdom/patch.js b/src/core/vdom/patch.js
index <HASH>..<HASH> 100644
--- a/src/core/vdom/patch.js
+++ b/src/core/vdom/patch.js
@@ -120,7 +120,14 @@ export function createPatchFunction (backend) {
if (
!inPre &&
!vnode.ns &&
- !(config.ignoredElements.length && config.ignoredElements.indexOf(tag) > -1) &&
+ !(
+ config.ignoredElements.length &&
+ config.ignoredElements.some(ignore => {
+ return ignore instanceof RegExp
+ ? ignore.test(tag)
+ : ignore === tag
+ })
+ ) &&
config.isUnknownElement(tag)
) {
warn(
|
feat: support RegExp in ignoredElements (#<I>)
|
kaola-fed_megalo
|
train
|
js
|
a7dfc114c2f10d5fb0b442fd21ee94dc678e227e
|
diff --git a/packages/themes/src/g10.js b/packages/themes/src/g10.js
index <HASH>..<HASH> 100644
--- a/packages/themes/src/g10.js
+++ b/packages/themes/src/g10.js
@@ -8,7 +8,7 @@ import { adjustLightness } from './tools';
import {
// Blue
- blue20,
+ blue10,
blue40,
blue60,
blue70,
@@ -124,7 +124,7 @@ export const disabled01 = white;
export const disabled02 = gray30;
export const disabled03 = gray50;
-export const highlight = blue20;
+export const highlight = blue10;
export const decorative01 = gray20;
|
fix(themes): correct color for highlight token in g<I> theme (#<I>)
|
carbon-design-system_carbon-components
|
train
|
js
|
eed6c3edab0d2a5758da3d9cb465c56778d05d99
|
diff --git a/helpers/form/class.FormElement.php b/helpers/form/class.FormElement.php
index <HASH>..<HASH> 100644
--- a/helpers/form/class.FormElement.php
+++ b/helpers/form/class.FormElement.php
@@ -25,7 +25,6 @@ declare(strict_types=1);
use oat\oatbox\validator\ValidatorInterface;
use oat\tao\helpers\form\elements\xhtml\SearchTextBox;
use oat\tao\helpers\form\elements\xhtml\SearchDropdown;
-use oat\tao\helpers\form\validators\CrossPropertyEvaluationAwareInterface;
// Defining aliases for old style class names for backward compatibility
class_alias(SearchTextBox::class, \tao_helpers_form_elements_xhtml_Searchtextbox::class);
|
refactor: remove unnecessary use-statement
|
oat-sa_tao-core
|
train
|
php
|
3a50f9e5abfee01f76dc39e688189421d33d4d86
|
diff --git a/.eslintrc.js b/.eslintrc.js
index <HASH>..<HASH> 100644
--- a/.eslintrc.js
+++ b/.eslintrc.js
@@ -4,6 +4,7 @@ module.exports = {
},
'extends': 'eslint:recommended',
'rules': {
+ 'no-console': 'off',
'curly': ['error', 'all'],
'default-case': 'warn',
'dot-location': ['error', 'property'],
@@ -68,7 +69,7 @@ module.exports = {
'consistent-this': ['error', '_this'],
'func-call-spacing': ['error', 'never'],
'func-style': ['error', 'declaration'],
- 'id-length': ['error', {
+ 'id-length': ['warn', {
'min': 1,
'max': 20,
'properties': 'always'
|
chore: update few rules for linter
|
valerii-zinchenko_inheritance-diagram
|
train
|
js
|
9ca77317ba5b104f6b894ff14860a408007399b5
|
diff --git a/src/plugins/media_control/media_control.js b/src/plugins/media_control/media_control.js
index <HASH>..<HASH> 100644
--- a/src/plugins/media_control/media_control.js
+++ b/src/plugins/media_control/media_control.js
@@ -664,8 +664,13 @@ export default class MediaControl extends UICorePlugin {
* @method configure
* @param {Object} options all the options to change in form of a javascript object
*/
- configure() {
- this.options.chromeless ? this.disable() : this.enable()
+ configure(options) {
+ // Check if chromeless mode or if configure is called with new source(s)
+ if (this.options.chromeless || options.source || options.sources)
+ this.disable()
+ else
+ this.enable()
+
this.trigger(Events.MEDIACONTROL_OPTIONS_CHANGE)
}
|
fix(media_control): check if options has source in configure method
Fixes #<I>.
|
clappr_clappr
|
train
|
js
|
d294ccba7c5b59df911c92953c1e20884c8af4e5
|
diff --git a/packages/themify/src/index.js b/packages/themify/src/index.js
index <HASH>..<HASH> 100755
--- a/packages/themify/src/index.js
+++ b/packages/themify/src/index.js
@@ -56,7 +56,6 @@ function writeToFile(filePath, output) {
return fs.outputFileSync(filePath, output);
}
-
/** Define the default variation */
const defaultVariation = ColorVariation.LIGHT;
@@ -304,9 +303,7 @@ function themify(options) {
}
// define which modes need to be processed
- const execModes = [
- ExecutionMode.CSS_COLOR,
- ];
+ const execModes = [ExecutionMode.CSS_COLOR];
walkFallbackAtRules(root, execModes, output);
walkFallbackRules(root, execModes, output);
|
fix: fix prettier lint issues
|
bolt-design-system_bolt
|
train
|
js
|
dbb5d46d4bb322d35211a772e9eb448091240c35
|
diff --git a/src/library/styles/__tests__/createStyledComponent.spec.js b/src/library/styles/__tests__/createStyledComponent.spec.js
index <HASH>..<HASH> 100644
--- a/src/library/styles/__tests__/createStyledComponent.spec.js
+++ b/src/library/styles/__tests__/createStyledComponent.spec.js
@@ -1,6 +1,7 @@
/* @flow */
import React from 'react';
import { mount } from 'enzyme';
+import semver from 'semver';
import { createStyledComponent } from '../../styles';
const mountButton = (props = {}, styles = {}, options = {}) => {
@@ -53,6 +54,13 @@ describe('createStyledComponent', () => {
});
describe('with forwardProps option', () => {
+ if (semver.lt(React.version, '16.0.0')) {
+ // eslint-disable-next-line no-console
+ console.log(
+ 'NOTE: The following warning is expected and safe to ignore.'
+ );
+ }
+
const wrapper = mountButton(
{ forwardme: 'true' },
{},
|
test(styles): Add note about warning that is safe to ignore
|
mineral-ui_mineral-ui
|
train
|
js
|
2809e0e6ff89d0464fa7b46891034ce101453f1a
|
diff --git a/vyper/parser/arg_clamps.py b/vyper/parser/arg_clamps.py
index <HASH>..<HASH> 100644
--- a/vyper/parser/arg_clamps.py
+++ b/vyper/parser/arg_clamps.py
@@ -1,6 +1,7 @@
import functools
import uuid
+from vyper.opcodes import version_check
from vyper.parser.lll_node import LLLnode
from vyper.types.types import (
ByteArrayLike,
@@ -60,9 +61,11 @@ def make_arg_clamper(datapos, mempos, typ, is_init=False):
)
# Booleans: make sure they're zero or one
elif is_base_type(typ, "bool"):
- return LLLnode.from_list(
- ["uclamplt", data_decl, 2], typ=typ, annotation="checking bool input",
- )
+ if version_check("constantinople"):
+ lll = ["assert", ["iszero", ["shr", 1, data_decl]]]
+ else:
+ lll = ["uclamplt", data_decl, 2]
+ return LLLnode.from_list(lll, typ=typ, annotation="checking bool input")
# Addresses: make sure they're in range
elif is_base_type(typ, "address"):
return LLLnode.from_list(
|
feat: use shr for clamping booleans
|
ethereum_vyper
|
train
|
py
|
c6a8ad9e3a960637526d2dd9dbd31a2080218532
|
diff --git a/script/upload-index-json.py b/script/upload-index-json.py
index <HASH>..<HASH> 100755
--- a/script/upload-index-json.py
+++ b/script/upload-index-json.py
@@ -10,7 +10,7 @@ from lib.util import s3put, scoped_cwd, safe_mkdir
SOURCE_ROOT = os.path.abspath(os.path.dirname(os.path.dirname(__file__)))
OUT_DIR = os.path.join(SOURCE_ROOT, 'out', 'D')
-BASE_URL = 'https://electron-metadumper.herokuapp.com/?version=v'
+BASE_URL = 'https://electron-metadumper.herokuapp.com/?version='
version = sys.argv[1]
authToken = os.getenv('META_DUMPER_AUTH_HEADER')
|
chore: remove v from script :sigh: (#<I>)
|
electron_electron
|
train
|
py
|
ba589430e084f2a0311ac9f2e1a9c58baf377fba
|
diff --git a/lib/components/form/date-time-preview.js b/lib/components/form/date-time-preview.js
index <HASH>..<HASH> 100644
--- a/lib/components/form/date-time-preview.js
+++ b/lib/components/form/date-time-preview.js
@@ -48,7 +48,7 @@ class DateTimePreview extends Component {
)
return (
- <div className='settings-preview'>
+ <div className='settings-preview' onClick={this.props.onClick}>
{summary}
{button}
<div style={{ clear: 'both' }} />
|
feat(form): Make full date/time tab clickable in desktop
|
opentripplanner_otp-react-redux
|
train
|
js
|
44c122d930bafffd95805c3b91a3831ceecf9bfd
|
diff --git a/test/k8sT/DatapathConfiguration.go b/test/k8sT/DatapathConfiguration.go
index <HASH>..<HASH> 100644
--- a/test/k8sT/DatapathConfiguration.go
+++ b/test/k8sT/DatapathConfiguration.go
@@ -631,6 +631,23 @@ var _ = Describe("K8sDatapathConfig", func() {
Expect(testPodConnectivityAcrossNodes(kubectl)).Should(BeTrue(), "Connectivity test between nodes failed")
})
})
+
+ Context("Host firewall", func() {
+ SkipItIf(func() bool {
+ return !helpers.IsIntegration(helpers.CIIntegrationGKE)
+ }, "Check connectivity with IPv6 disabled", func() {
+ deploymentManager.DeployCilium(map[string]string{
+ "ipv4.enabled": "true",
+ "ipv6.enabled": "false",
+ "hostFirewall": "true",
+ // We need the default GKE config. except for per-endpoint
+ // routes (incompatible with host firewall for now).
+ "gke.enabled": "false",
+ "tunnel": "disabled",
+ }, DeployCiliumOptionsAndDNS)
+ Expect(testPodConnectivityAcrossNodes(kubectl)).Should(BeTrue(), "Connectivity test between nodes failed")
+ })
+ })
})
func testPodConnectivityAcrossNodes(kubectl *helpers.Kubectl) bool {
|
test: Minimal test for the host firewall in IPv4-only mode
This test is meant to catch complexity regressions such as fixed
in the previous commit. It runs only on GKE for now and will be extended
in follow up PRs.
|
cilium_cilium
|
train
|
go
|
fd3a7a94ebd0fb8d7c6cd51132b7c784a6b62570
|
diff --git a/lib/ditty/cli.rb b/lib/ditty/cli.rb
index <HASH>..<HASH> 100644
--- a/lib/ditty/cli.rb
+++ b/lib/ditty/cli.rb
@@ -47,7 +47,7 @@ module Ditty
desc 'migrate', 'Run the Ditty migrations'
def migrate
# Prep Ditty
- Rake::Task['ditty:prep'].invoke
+ Rake::Task['ditty:prep:migrations'].invoke
# Run the migrations
Rake::Task['ditty:migrate:up'].invoke
|
fix: Only prep migrations when running migrations
|
EagerELK_ditty
|
train
|
rb
|
ae5a9c1f167435f8718803d4b0cc167003e036a5
|
diff --git a/test/assets/values/rulesFile.js b/test/assets/values/rulesFile.js
index <HASH>..<HASH> 100644
--- a/test/assets/values/rulesFile.js
+++ b/test/assets/values/rulesFile.js
@@ -1 +1,3 @@
-rules.push('rf1.w2.org file://{test.json}');
\ No newline at end of file
+if (isLocalAddress()) {
+ rules.push('rf1.w2.org file://{test.json}');
+}
|
test: isLocalAddress
|
avwo_whistle
|
train
|
js
|
37e8cb73da9ab856eaf9dd640352ae1f22b2c41c
|
diff --git a/codegen/src/main/java/io/sundr/codegen/functions/ClassTo.java b/codegen/src/main/java/io/sundr/codegen/functions/ClassTo.java
index <HASH>..<HASH> 100644
--- a/codegen/src/main/java/io/sundr/codegen/functions/ClassTo.java
+++ b/codegen/src/main/java/io/sundr/codegen/functions/ClassTo.java
@@ -266,7 +266,10 @@ public class ClassTo {
final Object value = method.invoke(annotation, (Object[]) null);
parameters.put(name, value);
} catch (IllegalAccessException | InvocationTargetException e) {
- System.out.printf("Couldn't retrieve '%s' parameter value for %s%n", name, annotationType.getName());
+ //Let's not pollute output with internal jdk stuff.
+ if (!annotationType.getName().startsWith("jdk.")) {
+ System.out.printf("Couldn't retrieve '%s' parameter value for %s%n", name, annotationType.getName());
+ }
}
}
annotationRef = new AnnotationRefBuilder(annotationRef).withParameters(parameters).build();
|
chore: hide output related to processing internal jdk types
|
sundrio_sundrio
|
train
|
java
|
89dc3b88d1f8e878a08e485ee8f1eaf0e918abae
|
diff --git a/public/app/features/dashboard/timeSrv.js b/public/app/features/dashboard/timeSrv.js
index <HASH>..<HASH> 100644
--- a/public/app/features/dashboard/timeSrv.js
+++ b/public/app/features/dashboard/timeSrv.js
@@ -13,7 +13,7 @@ define([
module.service('timeSrv', function($rootScope, $timeout, $routeParams, timer) {
var self = this;
- $rootScope.onAppEvent('zoom-out', function(e, factor) { self.zoomOut(factor); }, $rootScope);
+ $rootScope.$on('zoom-out', function(e, factor) { self.zoomOut(factor); });
this.init = function(dashboard) {
timer.cancel_all();
|
fix(test): fixed failing test caused by recent change
|
grafana_grafana
|
train
|
js
|
c6e041c7dfc4b97645e97f8ffeee8fe636563774
|
diff --git a/tests/Test/StorageApiTestCase.php b/tests/Test/StorageApiTestCase.php
index <HASH>..<HASH> 100644
--- a/tests/Test/StorageApiTestCase.php
+++ b/tests/Test/StorageApiTestCase.php
@@ -107,7 +107,7 @@ class StorageApiTestCase extends \PHPUnit_Framework_TestCase
public function backends()
{
return array(
-// array('mysql'),
+ array('mysql'),
array('redshift'),
);
}
|
fix: mysql backend returned to tests
|
keboola_storage-api-php-client
|
train
|
php
|
6b5c30ce6bf33e323a2721a70f41d924b3ed58b0
|
diff --git a/lib/template-generator.js b/lib/template-generator.js
index <HASH>..<HASH> 100644
--- a/lib/template-generator.js
+++ b/lib/template-generator.js
@@ -363,7 +363,7 @@ module.exports.generateTemplate = function generateTemplate(results, isMultiOn)
if (isMultiOn && isOutputDirKnown()) {
const outputPath = getOutputPath(currWorkingDir);
- buildScriptsAndStyleFiles(outputPath());
+ buildScriptsAndStyleFiles(outputPath);
}
// Iterate over results to get totals
|
fix(assets): wrong var
|
mportuga_eslint-detailed-reporter
|
train
|
js
|
bd00205a08656e4dc70b4506c5fdfc77171ab77c
|
diff --git a/packages/cozy-stack-client/src/CozyStackClient.js b/packages/cozy-stack-client/src/CozyStackClient.js
index <HASH>..<HASH> 100644
--- a/packages/cozy-stack-client/src/CozyStackClient.js
+++ b/packages/cozy-stack-client/src/CozyStackClient.js
@@ -114,7 +114,7 @@ class CozyStackClient {
const fetcher = shouldXMLHTTPRequestBeUsed(method, path, options)
? fetchWithXMLHttpRequest
- : window.fetch
+ : fetch
try {
const response = await fetcher(fullPath, options)
|
fix(cozy-stack-client): Allow fetch to work in node
|
cozy_cozy-client
|
train
|
js
|
58ab76d2caca19e7b6d28fb67bda73bd0bd9488d
|
diff --git a/packages/embark-ui/src/components/Console.js b/packages/embark-ui/src/components/Console.js
index <HASH>..<HASH> 100644
--- a/packages/embark-ui/src/components/Console.js
+++ b/packages/embark-ui/src/components/Console.js
@@ -11,7 +11,7 @@ import Logs from "./Logs";
import "./Console.css";
import {EMBARK_PROCESS_NAME} from '../constants';
-const convert = new Convert();
+const convert = new Convert({newline: true, escapeXML: true});
class Console extends Component {
constructor(props) {
|
fix: format \n as <br> in cockpit console (#<I>)
|
embark-framework_embark
|
train
|
js
|
b1b1639e03ce2e08cd5fc850f9fbad886b0b135f
|
diff --git a/packages/@vue/cli-service/lib/Service.js b/packages/@vue/cli-service/lib/Service.js
index <HASH>..<HASH> 100644
--- a/packages/@vue/cli-service/lib/Service.js
+++ b/packages/@vue/cli-service/lib/Service.js
@@ -31,7 +31,7 @@ module.exports = class Service {
// install plugins.
// If there are inline plugins, they will be used instead of those
- // found in pacakge.json.
+ // found in package.json.
// When useBuiltIn === false, built-in plugins are disabled. This is mostly
// for testing.
this.plugins = this.resolvePlugins(plugins, useBuiltIn)
|
docs: fix comment typo (#<I>)
Small typo
|
vuejs_vue-cli
|
train
|
js
|
d8a3a4cd4f5d4ef6bd4374b6de6a0d179cfeece1
|
diff --git a/components/templates/Hogan/index.js b/components/templates/Hogan/index.js
index <HASH>..<HASH> 100644
--- a/components/templates/Hogan/index.js
+++ b/components/templates/Hogan/index.js
@@ -1,21 +1,15 @@
'use strict';
-var React = require('react');
-
var hogan = require('hogan.js');
+var React = require('react');
var HoganResult = React.createClass({
propTypes: {
template: React.PropTypes.string,
data: React.PropTypes.object
},
- componentWillMount: function() {
- this.setState({
- template: hogan.compile(this.props.template)
- });
- },
render: function() {
- var content = this.state.template.render(this.props.data);
+ var content = hogan.compile(this.props.template).render(this.props.data);
return <div className="hit" dangerouslySetInnerHTML={{__html: content}} />;
}
});
|
fix: no state needed for Hogan component
|
algolia_instantsearch.js
|
train
|
js
|
394f9f5749f0cbd6942d8513b68bf99c68d69de7
|
diff --git a/tests/index.js b/tests/index.js
index <HASH>..<HASH> 100644
--- a/tests/index.js
+++ b/tests/index.js
@@ -81,6 +81,7 @@ describe("style-manifest", function() {
});
});
+
it("should handle a multiple style types", async function() {
input.write({
"src": {
@@ -148,7 +149,6 @@ describe("style-manifest", function() {
});
-
it("should handle a no styles", async function() {
input.write({
"src": {
@@ -171,5 +171,4 @@ describe("style-manifest", function() {
` + os.EOL
});
});
-
});
|
chore(whitespace): cleaned up some whitespace in the tests
|
webark_broccoli-style-manifest
|
train
|
js
|
cf0696522a826c8570effc2d8a486c6f0601814c
|
diff --git a/index.js b/index.js
index <HASH>..<HASH> 100644
--- a/index.js
+++ b/index.js
@@ -1,3 +1,4 @@
+'use strict';
const fsp = require('fs-promise');
const newLineCharacters = ["\n", "\r"]
|
fix(strict): add use strict to index
no issue
- in node v4 requiring this library throws an error because `const` and `let` aren't allowed outside of strict mode
|
alexbbt_read-last-lines
|
train
|
js
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.