hash
stringlengths 40
40
| diff
stringlengths 172
2.63k
| message
stringlengths 12
593
| project
stringlengths 7
65
| split
stringclasses 1
value | diff_languages
stringclasses 54
values |
|---|---|---|---|---|---|
0f2a501bea4435bbd70c6c3f55dd17ecc7d3eeff
|
diff --git a/ipyvolume/pylab.py b/ipyvolume/pylab.py
index <HASH>..<HASH> 100644
--- a/ipyvolume/pylab.py
+++ b/ipyvolume/pylab.py
@@ -186,7 +186,7 @@ def animate_glyphs(scatter, sequence_length=None, add=True, interval=200):
fig.animation = interval
fig.animation_exponent = 1.
play = ipywidgets.Play(min=0, max=sequence_length, interval=interval, value=0, step=1)
- slider = ipywidgets.IntSlider(min=0, max=play.max)
+ slider = ipywidgets.IntSlider(min=0, max=play.max-1)
ipywidgets.jslink((play, 'value'), (slider, 'value'))
ipywidgets.jslink((slider, 'value'), (scatter, 'sequence_index'))
control = ipywidgets.HBox([play, slider])
|
fix: one off for Play, might be fixed for ipywidgets
|
maartenbreddels_ipyvolume
|
train
|
py
|
a66d091a741a8a74deda7ce936fa8fd677ee9cf1
|
diff --git a/maintain/process.py b/maintain/process.py
index <HASH>..<HASH> 100644
--- a/maintain/process.py
+++ b/maintain/process.py
@@ -27,15 +27,3 @@ class chdir(object):
def __exit__(self, typ, value, traceback):
os.chdir(self.working_directory)
-
-
-class temp_directory(object):
- def __enter__(self):
- self.working_directory = os.getcwd()
- self.pathname = tempfile.mkdtemp()
- os.chdir(self.pathname)
- return self.pathname
-
- def __exit__(self, typ, value, traceback):
- os.chdir(self.working_directory)
- shutil.rmtree(self.pathname)
|
chore(process): Remove unused code
|
kylef_maintain
|
train
|
py
|
5d7f89527ea773cdd37583a3c7ab91ee3b1db5a9
|
diff --git a/karma.conf.js b/karma.conf.js
index <HASH>..<HASH> 100644
--- a/karma.conf.js
+++ b/karma.conf.js
@@ -13,8 +13,8 @@ module.exports = karmaConfig({
browsers: {
chrome: host.ci ? host.os.linux : true,
firefox: host.ci ? host.os.linux : true,
- safari: host.ci ? host.os.linux : host.os.mac, // SauceLabs in CI
+ // safari: host.ci ? host.os.linux : host.os.mac, // SauceLabs in CI
edge: host.ci ? host.os.linux : host.os.windows, // SauceLabs in CI
- ie: host.ci ? host.os.windows : false, // IE needs to run by itself, due to Babel transforms
+ // ie: host.ci ? host.os.windows : false, // IE needs to run by itself, due to Babel transforms
},
});
|
chore: disable ie/safari browser tests
|
APIDevTools_json-schema-ref-parser
|
train
|
js
|
74d1b5b754c24ce5abf9a6f7fa3a7572a1a60d72
|
diff --git a/src/index.js b/src/index.js
index <HASH>..<HASH> 100644
--- a/src/index.js
+++ b/src/index.js
@@ -7,6 +7,7 @@ module.exports = function (options) {
build: docker.build,
info: docker.info,
login: docker.login,
+ pull: docker.pull,
push: docker.push,
pushTags: tagImpl.pushTags,
removeImage: docker.removeImage,
|
fix: add missing method to index so pull is accessible via library API
|
npm-wharf_pequod
|
train
|
js
|
c3662db4d01f394a7cfcdf8da3428addf699ae8c
|
diff --git a/cypress/support/commands.js b/cypress/support/commands.js
index <HASH>..<HASH> 100644
--- a/cypress/support/commands.js
+++ b/cypress/support/commands.js
@@ -10,16 +10,16 @@
//
//
// -- This is a parent command --
-// Cypress.Commands.add("login", (email, password) => { ... })
+// Cypress.Commands.add('login', (email, password) => { ... })
//
//
// -- This is a child command --
-// Cypress.Commands.add("drag", { prevSubject: 'element'}, (subject, options) => { ... })
+// Cypress.Commands.add('drag', { prevSubject: 'element'}, (subject, options) => { ... })
//
//
// -- This is a dual command --
-// Cypress.Commands.add("dismiss", { prevSubject: 'optional'}, (subject, options) => { ... })
+// Cypress.Commands.add('dismiss', { prevSubject: 'optional'}, (subject, options) => { ... })
//
//
// -- This is will overwrite an existing command --
-// Cypress.Commands.overwrite("visit", (originalFn, url, options) => { ... })
+// Cypress.Commands.overwrite('visit', (originalFn, url, options) => { ... })
|
style: Change double quotes to single quotes in commented commands
|
cypress-io_cypress-example-kitchensink
|
train
|
js
|
ffb74800638417910f453e108c8a4c6ffabaee29
|
diff --git a/lib/launcher.js b/lib/launcher.js
index <HASH>..<HASH> 100644
--- a/lib/launcher.js
+++ b/lib/launcher.js
@@ -1,4 +1,5 @@
var log = require('./logger').create('launcher');
+var q = require('q');
var baseDecorator = require('./launchers/base').decoratorFactory;
var captureTimeoutDecorator = require('./launchers/capture_timeout').decoratorFactory;
@@ -66,8 +67,16 @@ var Launcher = function(emitter, injector) {
return;
}
- // TODO(vojta): remove in v1.0
- browser.forceKill = browser.forceKill || browser.kill;
+ // TODO(vojta): remove in v1.0 (BC for old launchers)
+ if (!browser.forceKill) {
+ browser.forceKill = function() {
+ var deferred = q.defer();
+ this.kill(function() {
+ deferred.resolve();
+ });
+ return deferred.promise;
+ };
+ }
log.info('Starting browser %s', browser.name);
browser.start(url);
|
fix(launcher): compatibility with old launchers
|
karma-runner_karma
|
train
|
js
|
1bd715babe3a2338c96df1d551e8643a53571d94
|
diff --git a/packages/ringcentral-widgets/lib/hasActiveCalls.js b/packages/ringcentral-widgets/lib/hasActiveCalls.js
index <HASH>..<HASH> 100644
--- a/packages/ringcentral-widgets/lib/hasActiveCalls.js
+++ b/packages/ringcentral-widgets/lib/hasActiveCalls.js
@@ -10,7 +10,7 @@ export default function hasActiveCalls(phone) {
} = phone;
if (webphone && callingSettings.callingMode === callingModes.webphone) {
// need to show the ringout calls
- return !!(webphone.sessions.length) || (callMonitor && callMonitor.calls.length);
+ return !!((webphone.sessions.length) || (callMonitor && callMonitor.otherDeviceCalls.length));
}
return !!(
(callMonitor && callMonitor.calls.length)
|
fix(hasActivecalls): change logic (#<I>)
* fix(hasActivecalls): change logic
when under webphone mode, using callMonitor.otherDeviceCalls.length and webphone.sessions.length
* refactor(hasActiveCalls.js): typo
|
ringcentral_ringcentral-js-widgets
|
train
|
js
|
4ff08d84a11b9eff87cd8f83e33cbda7e44477b3
|
diff --git a/src/utils/AsyncIterator.js b/src/utils/AsyncIterator.js
index <HASH>..<HASH> 100644
--- a/src/utils/AsyncIterator.js
+++ b/src/utils/AsyncIterator.js
@@ -38,7 +38,10 @@ export function fromValue (value) {
// Convert a Node stream to an Async Iterator
export function fromNodeStream (stream) {
// Use native async iteration if it's available.
- if (stream[Symbol.asyncIterator]) return stream
+ if (
+ Object.getOwnPropertyDescriptor(stream, Symbol.asyncIterator) &&
+ Object.getOwnPropertyDescriptor(stream, Symbol.asyncIterator).enumerable
+ ) { return stream }
// Author's Note
// I tried many MANY ways to do this.
// I tried two npm modules (stream-to-async-iterator and streams-to-async-iterator) with no luck.
|
fix: improve AsyncIterator feature detection (#<I>)
|
isomorphic-git_isomorphic-git
|
train
|
js
|
8f98ad75acb29a6ca01fb19972b28a3ac0bf5948
|
diff --git a/platform/nativescript/util/index.js b/platform/nativescript/util/index.js
index <HASH>..<HASH> 100644
--- a/platform/nativescript/util/index.js
+++ b/platform/nativescript/util/index.js
@@ -1,5 +1,6 @@
-import { makeMap } from 'shared/util'
+import { makeMap, once } from 'shared/util'
import { isKnownView, getViewMeta } from '../element-registry'
+import Vue from '../framework'
export const isReservedTag = makeMap('template', true)
@@ -34,7 +35,17 @@ export function query(el, renderer, document) {
export const VUE_VERSION = process.env.VUE_VERSION
export const NS_VUE_VERSION = process.env.NS_VUE_VERSION
+const infoTrace = once(() => {
+ console.log(
+ `NativeScript-Vue has "Vue.config.silent" set to true, to see output logs set it to false.`
+ )
+})
+
export function trace(message) {
+ if (Vue.config.silent) {
+ return infoTrace()
+ }
+
console.log(
`{NSVue (Vue: ${VUE_VERSION} | NSVue: ${NS_VUE_VERSION})} -> ${message}`
)
|
feat: allow silencing the console ouput
closes #<I>
|
nativescript-vue_nativescript-vue
|
train
|
js
|
d6414ced169af84f58fe42f287fa161ae7216e58
|
diff --git a/lib/platform/github/index.js b/lib/platform/github/index.js
index <HASH>..<HASH> 100644
--- a/lib/platform/github/index.js
+++ b/lib/platform/github/index.js
@@ -1222,13 +1222,6 @@ async function getOpenPrs() {
}
async function getClosedPrs() {
- // istanbul ignore if
- if (config.isGhe) {
- logger.debug(
- 'Skipping unsupported graphql PullRequests.mergeStateStatus query on GHE'
- );
- return {};
- }
if (!config.closedPrList) {
config.closedPrList = {};
let query;
|
fix(github): don’t skip graphql for closed PR list
|
renovatebot_renovate
|
train
|
js
|
fdcd680032c68222d1814d6ab25b1d53c44803c3
|
diff --git a/src/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php b/src/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php
index <HASH>..<HASH> 100644
--- a/src/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php
+++ b/src/Symfony/Bundle/DependencyInjection/ApiPlatformExtension.php
@@ -279,12 +279,15 @@ final class ApiPlatformExtension extends Extension implements PrependExtensionIn
$dirname = $bundle['path'];
foreach (['.yaml', '.yml', '.xml', ''] as $extension) {
$paths[] = "$dirname/Resources/config/api_resources$extension";
+ $paths[] = "$dirname/config/api_resources$extension";
}
if ($this->isConfigEnabled($container, $config['doctrine'])) {
$paths[] = "$dirname/Entity";
+ $paths[] = "$dirname/src/Entity";
}
if ($this->isConfigEnabled($container, $config['doctrine_mongodb_odm'])) {
$paths[] = "$dirname/Document";
+ $paths[] = "$dirname/src/Document";
}
foreach ($paths as $path) {
|
feat: adjust mapping paths to the SF best practices for Bundles
|
api-platform_core
|
train
|
php
|
b386e1dbbd4f75785536173ccaabd97308a0cf6c
|
diff --git a/test/unit/base.rb b/test/unit/base.rb
index <HASH>..<HASH> 100644
--- a/test/unit/base.rb
+++ b/test/unit/base.rb
@@ -5,6 +5,7 @@ require "rspec/autorun"
# Require Vagrant itself so we can reference the proper
# classes to test.
require "vagrant"
+require "vagrant/util/platform"
# Add the test directory to the load path
$:.unshift File.expand_path("../../", __FILE__)
@@ -25,6 +26,11 @@ $stderr.sync = true
# Configure RSpec
RSpec.configure do |c|
c.expect_with :rspec, :stdlib
+ c.treat_symbols_as_metadata_keys_with_true_values = true
+
+ if Vagrant::Util::Platform.windows?
+ c.filter_run_excluding :skip_windows
+ end
end
# Configure VAGRANT_CWD so that the tests never find an actual
diff --git a/test/unit/vagrant/util/ssh_test.rb b/test/unit/vagrant/util/ssh_test.rb
index <HASH>..<HASH> 100644
--- a/test/unit/vagrant/util/ssh_test.rb
+++ b/test/unit/vagrant/util/ssh_test.rb
@@ -20,7 +20,7 @@ describe Vagrant::Util::SSH do
key_path.stat.mode.should == mode
end
- it "should fix the permissions" do
+ it "should fix the permissions", :skip_windows do
key_path.chmod(0644)
described_class.check_key_permissions(key_path)
|
test: allow skipping certain tests on Windows
|
hashicorp_vagrant
|
train
|
rb,rb
|
4a5db0cbfe5c50abc2864ded6edcac814721f7a1
|
diff --git a/anyconfig/cli.py b/anyconfig/cli.py
index <HASH>..<HASH> 100644
--- a/anyconfig/cli.py
+++ b/anyconfig/cli.py
@@ -82,7 +82,7 @@ def to_log_level(level):
ValueError: wrong log level passed: 5
>>>
"""
- if not (level >= 0 and level < 3):
+ if level < 0 or level >= 3:
raise ValueError("wrong log level passed: " + str(level))
return [logging.WARN, logging.INFO, logging.DEBUG][level]
|
fix: simplify the chained comparisons
|
ssato_python-anyconfig
|
train
|
py
|
bbe37ed51ea36c9c0372cc16041efba8458d5866
|
diff --git a/tests/test_progress.py b/tests/test_progress.py
index <HASH>..<HASH> 100644
--- a/tests/test_progress.py
+++ b/tests/test_progress.py
@@ -7,7 +7,7 @@ import pyvips
class TestProgress:
def test_progress(self):
- # py27 reques this pattern for non-local modification
+ # py27 requires this pattern for non-local modification
notes = {}
def preeval_cb(image, progress):
|
docs: Fix simple typo, reques -> requires
There is a small typo in tests/test_progress.py.
Should read `requires` rather than `reques`.
|
libvips_pyvips
|
train
|
py
|
cdfe06a772a1107557f74a18fab88a82314d7efc
|
diff --git a/ibis/backends/conftest.py b/ibis/backends/conftest.py
index <HASH>..<HASH> 100644
--- a/ibis/backends/conftest.py
+++ b/ibis/backends/conftest.py
@@ -486,7 +486,9 @@ def ddl_con(ddl_backend):
),
scope='session',
)
-def alchemy_backend(request, data_directory, tmp_path_factory):
+def alchemy_backend(
+ request, data_directory, script_directory, tmp_path_factory
+):
"""
Runs the SQLAlchemy-based backends
(sqlite, mysql, postgres)
@@ -515,7 +517,7 @@ def alchemy_con(alchemy_backend):
params=_get_backends_to_test(keep=("dask", "pandas", "pyspark")),
scope='session',
)
-def udf_backend(request, data_directory, tmp_path_factory):
+def udf_backend(request, data_directory, script_directory, tmp_path_factory):
"""
Runs the UDF-supporting backends
"""
|
chore: pass in script_directory
|
ibis-project_ibis
|
train
|
py
|
633e5d850374694cbe788216dafb22cee788ebc1
|
diff --git a/script/verify-chromedriver.py b/script/verify-chromedriver.py
index <HASH>..<HASH> 100644
--- a/script/verify-chromedriver.py
+++ b/script/verify-chromedriver.py
@@ -35,7 +35,7 @@ def main():
match = re.search(
'^Starting ChromeDriver [0-9]+.[0-9]+.[0-9]+.[0-9]+ .* on port [0-9]+$', output)
- if match == None:
+ if match is None:
returncode = 1
if returncode == 0:
|
chore: change `== None` to `is None` (#<I>)
According to LGTM, this change will improve code efficiency.
<URL>
|
electron_electron
|
train
|
py
|
964e4a1fad93e757dfd6d483aea77c6c34af75e7
|
diff --git a/test/2_consumer.js b/test/2_consumer.js
index <HASH>..<HASH> 100644
--- a/test/2_consumer.js
+++ b/test/2_consumer.js
@@ -18,7 +18,7 @@ describe("#consumer", function() {
var message = [];
var leftReconsume = true;
- this.timeout(0);
+ this.timeout(1000);
function listener(_message, _ack) {
// console.log(_message, _ack);
@@ -128,4 +128,11 @@ describe("#consumer", function() {
setTimeout(verify, 500);
});
+
+ it("should use default options", function(done) {
+ const consumer = new require("../").Consumer(config.consumerId, config.topic, "*", config.accessKey, config.secretKey);
+ consumer.stop(function() {
+ done();
+ });
+ });
});
|
test: add a new test case for consumer with no option
|
XadillaX_aliyun-ons
|
train
|
js
|
f525abbf11d33c6ebb18d648b5731caca1c9ac7c
|
diff --git a/src/number-keyboard/index.js b/src/number-keyboard/index.js
index <HASH>..<HASH> 100644
--- a/src/number-keyboard/index.js
+++ b/src/number-keyboard/index.js
@@ -105,7 +105,7 @@ export default createComponent({
methods: {
onBlur() {
- this.$emit('blur');
+ this.show && this.$emit('blur');
},
onClose() {
|
fix(NumberKeyboard): shouldn't trigger blur event when hidden (#<I>)
|
youzan_vant
|
train
|
js
|
42300114804172e6edd1d4e5840144c25c68a982
|
diff --git a/src/sku/Sku.js b/src/sku/Sku.js
index <HASH>..<HASH> 100644
--- a/src/sku/Sku.js
+++ b/src/sku/Sku.js
@@ -267,9 +267,10 @@ export default createComponent({
}
treeItem.v.forEach((vItem) => {
- const img = vItem.previewImgUrl || vItem.imgUrl || vItem.img_url;
- if (img) {
- imageList.push(img);
+ const imgUrl = vItem.previewImgUrl || vItem.imgUrl || vItem.img_url;
+
+ if (imgUrl && imageList.indexOf(imgUrl) === -1) {
+ imageList.push(imgUrl);
}
});
});
|
fix(Sku): duplicate pictures in image preview (#<I>)
|
youzan_vant
|
train
|
js
|
e9b76dda6519dda5008801aabddaf87b79f6a136
|
diff --git a/lib/configuration.js b/lib/configuration.js
index <HASH>..<HASH> 100644
--- a/lib/configuration.js
+++ b/lib/configuration.js
@@ -102,13 +102,16 @@ function applyConfiguration(config) {
configuration.options = applyLoggingOptions(configuration.options);
- if (config.hooksData || config.options.b || config.options.sandbox) {
- throw new Error('DEPRECATED: Dredd does not support '
- + 'sandboxed JS hooks anymore. Use standard JS hooks instead.');
- }
- if (config.blueprintPath) {
- throw new Error('DEPRECATED: Dredd does not support '
- + "the 'blueprintPath' option anymore. Use 'path' instead.");
+ if (config) {
+ if (config.hooksData
+ || (config.options && (config.options.b || config.options.sandbox))) {
+ throw new Error('DEPRECATED: Dredd does not support '
+ + 'sandboxed JS hooks anymore. Use standard JS hooks instead.');
+ }
+ if (config.blueprintPath) {
+ throw new Error('DEPRECATED: Dredd does not support '
+ + "the 'blueprintPath' option anymore. Use 'path' instead.");
+ }
}
return configuration;
|
fix: don't make assumptions about the input 'config' object
|
apiaryio_dredd
|
train
|
js
|
04fd5f76dbcb0d869279c4de8d60b3d363aa7a77
|
diff --git a/http/source_service.go b/http/source_service.go
index <HASH>..<HASH> 100644
--- a/http/source_service.go
+++ b/http/source_service.go
@@ -226,7 +226,13 @@ func (h *SourceHandler) handleGetSourcesBuckets(w http.ResponseWriter, r *http.R
return
}
- bs, _, err := h.BucketService.FindBuckets(ctx, req.filter)
+ _, err = h.SourceService.FindSourceByID(ctx, req.getSourceRequest.SourceID)
+ if err != nil {
+ EncodeError(ctx, err, w)
+ return
+ }
+
+ bs, _, err := h.BucketService.FindBuckets(ctx, req.getBucketsRequest.filter)
if err != nil {
EncodeError(ctx, err, w)
return
|
fix(http): fix invalid source buckets
|
influxdata_influxdb
|
train
|
go
|
88870cc13512ed43af26f80fc0fc4444e682f0ee
|
diff --git a/models/classes/websource/BaseWebsource.php b/models/classes/websource/BaseWebsource.php
index <HASH>..<HASH> 100644
--- a/models/classes/websource/BaseWebsource.php
+++ b/models/classes/websource/BaseWebsource.php
@@ -129,7 +129,7 @@ abstract class BaseWebsource extends Configurable implements Websource
//manage bugs in finfo
switch ($pathParts['extension']) {
case 'js':
- if (in_array($mimeType, ['text/plain', 'text/html', 'text/x-asm', 'text/x-c'], true)) {
+ if (in_array($mimeType, ['text/plain', 'text/html', 'text/x-asm', 'text/x-c', 'text/x-java'], true)) {
return 'text/javascript';
}
break;
|
fix: add additional mime type under which a js file can be identified (text/x-java)
|
oat-sa_tao-core
|
train
|
php
|
a43e8d28b7c85bcff20119de2b0c384a9853a50e
|
diff --git a/src/resource-type.js b/src/resource-type.js
index <HASH>..<HASH> 100644
--- a/src/resource-type.js
+++ b/src/resource-type.js
@@ -14,7 +14,7 @@ export class ResourceType {
* @return {Promise} Returns a promise for itself, resolving when all dependent resources are loaded.
*/
load(container, target){
- return this;
+ return Promise.resolve(this);
}
/**
@@ -27,4 +27,4 @@ export class ResourceType {
register(registry, name){
throw new Error('All descendents of "ResourceType" must implement the "register" method.');
}
-}
\ No newline at end of file
+}
|
fix(ResourceType): fix load to return Promise
the load method is supposed to return a promise that resolves to the object, not the object itself
|
aurelia_metadata
|
train
|
js
|
02adf78ee14c3ac982ed7e106d7d82b16c7cf7b6
|
diff --git a/src/util/graphicGL.js b/src/util/graphicGL.js
index <HASH>..<HASH> 100644
--- a/src/util/graphicGL.js
+++ b/src/util/graphicGL.js
@@ -191,8 +191,15 @@ graphicGL.BoundingBox = BoundingBox;
graphicGL.Frustum = Frustum;
// Texture utilities
+var blankImage = null;
-var blankImage = textureUtil.createBlank('rgba(255,255,255,0)').image;
+function getBlankImage() {
+ if (blankImage !== null) {
+ return blankImage;
+ }
+ blankImage = textureUtil.createBlank('rgba(255,255,255,0)').image;
+ return blankImage;
+}
function nearestPowerOfTwo(val) {
@@ -340,7 +347,7 @@ graphicGL.loadTexture = function (imgValue, api, textureOpts, cb) {
originalImage.crossOrigin = 'Anonymous';
originalImage.src = imgValue;
// Use blank image as place holder.
- texture.image = blankImage;
+ texture.image = getBlankImage();
textureCache.put(prefix + imgValue, textureObj);
}
@@ -675,4 +682,4 @@ graphicGL.updateVertexAnimation = function (
}
};
-export default graphicGL;
\ No newline at end of file
+export default graphicGL;
|
fix: make code work on server side
|
ecomfe_echarts-gl
|
train
|
js
|
7b748e28a9bebd4127c7fab7a6788952e00ea642
|
diff --git a/test/utils.test.js b/test/utils.test.js
index <HASH>..<HASH> 100644
--- a/test/utils.test.js
+++ b/test/utils.test.js
@@ -121,13 +121,14 @@ describe('utils', () => {
};
var depStack = ['parent', 'chai', 'chai-plugin'];
- // Seems like the only place we actually get the package is with chai.
- // Let the actual code work, rather than changing it for the test to work
utils.getPackage('chai')['build'] = {
'type': 'lib'
};
+
expect(utils.isPluginOfPackage(base, lib, depStack)).to.be.false;
expect(utils.isPluginOfPackage(base, libPlugin, depStack)).to.be.true;
+
+ delete utils.getPackage('chai')['build'];
});
it('should get a priority sort in ascending order', () => {
|
chore(test): removed added attribute
|
ngageoint_opensphere-build-resolver
|
train
|
js
|
c97977a3e806bd5d8682bc7fb22ebec1a8ceecdc
|
diff --git a/packages/discord.js/src/structures/Embed.js b/packages/discord.js/src/structures/Embed.js
index <HASH>..<HASH> 100644
--- a/packages/discord.js/src/structures/Embed.js
+++ b/packages/discord.js/src/structures/Embed.js
@@ -115,10 +115,10 @@ class Embed {
get video() {
if (!this.data.video) return null;
return {
- url: this.data.image.url,
- proxyURL: this.data.image.proxy_url,
- height: this.data.image.height,
- width: this.data.image.width,
+ url: this.data.video.url,
+ proxyURL: this.data.video.proxy_url,
+ height: this.data.video.height,
+ width: this.data.video.width,
};
}
|
fix(Embed): Reference video in video (#<I>)
|
discordjs_discord.js
|
train
|
js
|
15ce79682fa008f7316565ae2c564d47acfcd061
|
diff --git a/src/directives/formly-form.test.js b/src/directives/formly-form.test.js
index <HASH>..<HASH> 100644
--- a/src/directives/formly-form.test.js
+++ b/src/directives/formly-form.test.js
@@ -21,6 +21,14 @@ describe('formly-form', () => {
scope.fields = [];
}));
+ it.skip(`should be possible to use it as an attribute directive`, () => {
+ const el = compileAndDigest(`
+ <div formly-form model="model" fields="fields" form="theForm"></formly-form>
+ `);
+ expect(el.length).to.equal(1);
+ expect(el.prop('nodeName').toLowerCase()).to.equal('ng-form');
+ });
+
it('should use ng-form as the default root tag', () => {
const el = compileAndDigest(`
<formly-form model="model" fields="fields" form="theForm"></formly-form>
|
test(formly-form): Add test for attribute version of formly-form
Some people prefer to specify directives as attributes only. This adds a test to verify this is
possible. This is a skipped test because I'm going to use it for a first-timers-only issue.
tests for #<I>
|
formly-js_angular-formly
|
train
|
js
|
595e0addd3fe9b9becb6bb4d70ac5e153935aaff
|
diff --git a/setup.py b/setup.py
index <HASH>..<HASH> 100644
--- a/setup.py
+++ b/setup.py
@@ -9,7 +9,7 @@ with open(join(CURRENT_DIR, "README.rst")) as long_description_file:
setup(
name="bearychat",
- version="0.2.0",
+ version="0.2.1",
author="bearyinnovative",
url="https://github.com/bearyinnovative/bearychat.py",
description="SDK for BearyChat",
@@ -17,7 +17,7 @@ setup(
packages=find_packages(exclude=["docs"]),
platforms="any",
install_requires=[
- "requests>=2.2.1",
+ "requests>=2.8.0",
],
classifiers=[
"Development Status :: 4 - Beta",
|
fix: requires `requests>=<I>` to make thing works
|
bearyinnovative_bearychat.py
|
train
|
py
|
dfb9202aa26225f8df246f1969ec1332cebbc36a
|
diff --git a/src/ComponentQueries.js b/src/ComponentQueries.js
index <HASH>..<HASH> 100644
--- a/src/ComponentQueries.js
+++ b/src/ComponentQueries.js
@@ -15,7 +15,7 @@ const mergeWith = (x, y, fn) => {
Object.keys(y).forEach(key => {
if (x[key]) {
result[key] = fn(x[key], y[key], key);
- } else {
+ } else if (y[key]) {
result[key] = y[key];
}
});
|
fix(bug): Fixed merge algorithm.
Fixed merge algorithm undefined handling.
|
ctrlplusb_react-component-queries
|
train
|
js
|
bc05a58421bb0b4dc0b6bedc7ceb29a472ae39ff
|
diff --git a/setup.py b/setup.py
index <HASH>..<HASH> 100644
--- a/setup.py
+++ b/setup.py
@@ -51,6 +51,7 @@ extras = {
"local": [
"urllib3>=1.21.1,!=1.25,!=1.25.1",
"docker-compose>=1.25.2",
+ "docker==5.0.0",
"PyYAML>=5.3, <6", # PyYAML version has to match docker-compose requirements
],
"scipy": ["scipy>=0.19.0"],
|
fix: pin docker to <I>
|
aws_sagemaker-python-sdk
|
train
|
py
|
02ad67a563b01168e914d3b5536466a64e07def2
|
diff --git a/collapsible-motion/collapsible-motion.js b/collapsible-motion/collapsible-motion.js
index <HASH>..<HASH> 100644
--- a/collapsible-motion/collapsible-motion.js
+++ b/collapsible-motion/collapsible-motion.js
@@ -109,12 +109,14 @@ class CollapsibleMotion extends React.PureComponent {
children: PropTypes.func.isRequired,
isClosed: PropTypes.bool,
onToggle: PropTypes.func,
+ isDefaultClosed: PropTypes.bool,
};
render() {
return (
<Collapsible
isClosed={this.props.isClosed}
+ isDefaultClosed={this.props.isDefaultClosed}
onToggle={this.props.onToggle}
>
{({ isOpen, toggle }) => (
|
fix(collapsible-motion): pass missing prop down (isDefaultClosed)
pass missing prop down (isDefaultClosed)
|
commercetools_ui-kit
|
train
|
js
|
9b87721c1f22ae5f5372abe9f7ced9bd3d075c9d
|
diff --git a/pkg/provenance/sign.go b/pkg/provenance/sign.go
index <HASH>..<HASH> 100644
--- a/pkg/provenance/sign.go
+++ b/pkg/provenance/sign.go
@@ -402,6 +402,8 @@ func DigestFile(filename string) (string, error) {
// Helm uses SHA256 as its default hash for all non-cryptographic applications.
func Digest(in io.Reader) (string, error) {
hash := crypto.SHA256.New()
- io.Copy(hash, in)
+ if _, err := io.Copy(hash, in); err != nil {
+ return "", nil
+ }
return hex.EncodeToString(hash.Sum(nil)), nil
}
|
fix(provenance): Ports error check for `Digest` to v3
This is a port of #<I>
|
helm_helm
|
train
|
go
|
67738d11e12e4f205b9f3d20f2352a58086ef76d
|
diff --git a/vyper/types/types.py b/vyper/types/types.py
index <HASH>..<HASH> 100644
--- a/vyper/types/types.py
+++ b/vyper/types/types.py
@@ -210,14 +210,6 @@ def parse_type(item, location, sigs=None, custom_structs=None, constants=None):
raise InvalidType("Invalid base type: " + item.id, item)
# Units, e.g. num (1/sec) or contracts
elif isinstance(item, vy_ast.Call) and isinstance(item.func, vy_ast.Name):
- # Mapping type.
- if item.func.id == "HashMap":
- warnings.warn(
- "Mapping definitions using call have deprecated (see VIP1969). "
- "Use HashMap[type1, type2] instead.",
- DeprecationWarning,
- )
- raise InvalidType("map(type1, type2) no longer supported.", item)
# Contract_types
if item.func.id == "address":
if sigs and item.args[0].id in sigs:
|
refactor: Remove deprecation warning because it doesn't work
|
ethereum_vyper
|
train
|
py
|
35af73e2035154401c5907a8d3391bf45293c386
|
diff --git a/test/runtime/privileged_tests.go b/test/runtime/privileged_tests.go
index <HASH>..<HASH> 100644
--- a/test/runtime/privileged_tests.go
+++ b/test/runtime/privileged_tests.go
@@ -29,7 +29,7 @@ import (
const (
// The privileged unit tests can take more than 4 minutes, the default
// timeout for helper commands.
- privilegedUnitTestTimeout = 8 * time.Minute
+ privilegedUnitTestTimeout = 16 * time.Minute
)
var _ = Describe("RuntimePrivilegedUnitTests", func() {
|
test: Increase timeout on privileged unit tests
Flakes on privileged unit tests with 'context deadline exceeded' are
becoming a bit more common. There seem to be a lot of variations [1] in
actual duration of those tests, with a long tail of high durations.
This commit doubles the timeout value in an effort to reduce flakes.
1 - <URL>
|
cilium_cilium
|
train
|
go
|
216564213d100285227d94431a519005bff68223
|
diff --git a/anyconfig/processors.py b/anyconfig/processors.py
index <HASH>..<HASH> 100644
--- a/anyconfig/processors.py
+++ b/anyconfig/processors.py
@@ -226,7 +226,8 @@ class Processors(object):
"""
return find_by_type(ptype, self.list(sort=False))
- def find(self, ipath, ptype=None, cls=anyconfig.models.processor.Processor):
+ def find(self, ipath, ptype=None,
+ cls=anyconfig.models.processor.Processor):
"""
:param ipath: file path
:param ptype: Processor's type or None
|
fix: correct the pylint's error, line-too-long in .processors
|
ssato_python-anyconfig
|
train
|
py
|
7037c8532067d813bfbda24e73a3e61e2db39f9f
|
diff --git a/scheduler/scheduler.go b/scheduler/scheduler.go
index <HASH>..<HASH> 100644
--- a/scheduler/scheduler.go
+++ b/scheduler/scheduler.go
@@ -43,6 +43,12 @@ func (s *Scheduler) DoSchedule() {
continue
}
+ // If someone has reported state for this job, we assume
+ // it's good to go.
+ if jobState := s.Registry.GetJobState(job); jobState != nil {
+ continue
+ }
+
// For now, we assume that if we can initially acquire the lock
// we're safe to move forward with scheduling. This is not ideal.
s.ScheduleJob(job, machines)
|
feat(scheduler): Attempt to reschedule only if a Job has no state
If an Agent has started to report state for a given Job, the scheduler
must not attempt to reschedule it to a new Machine.
|
coreos_fleet
|
train
|
go
|
7496e44d8bd11fb262c587c27e3574a9236252e1
|
diff --git a/lib/features/editing/EditBehavior.js b/lib/features/editing/EditBehavior.js
index <HASH>..<HASH> 100644
--- a/lib/features/editing/EditBehavior.js
+++ b/lib/features/editing/EditBehavior.js
@@ -13,13 +13,7 @@ function EditBehavior(
commandStack,
tableName) {
- var ignoreFocus = false;
-
eventBus.on('element.focus', function(event) {
- if(ignoreFocus) {
- ignoreFocus = false;
- return;
- }
if(rules.allowed('cell.edit', {
row: event.element.row,
column: event.element.column,
@@ -60,11 +54,6 @@ function EditBehavior(
}) && !event.element.row.isFoot &&
selection.get() !== event.element) {
- // when we use the mouse click, we want to select the element, but
- // do not want to perform auto-selection of the content, so
- // ignore the next focus event
- ignoreFocus = true;
-
selection.select(event.element);
// ensure that we get a focus event afterwards
|
chore(selection): select all in inital click in cell
related to CAM-<I>
|
bpmn-io_table-js
|
train
|
js
|
2b52cdc915146c6775bc7565e5ecf31e7c9880e7
|
diff --git a/src/client/voice/receiver/PacketHandler.js b/src/client/voice/receiver/PacketHandler.js
index <HASH>..<HASH> 100644
--- a/src/client/voice/receiver/PacketHandler.js
+++ b/src/client/voice/receiver/PacketHandler.js
@@ -72,8 +72,9 @@ class PacketHandler extends EventEmitter {
if (byte === 0) continue;
offset += 1 + (0b1111 & (byte >> 4));
}
- // Skip over undocumented Discord byte
- offset++;
+ // Skip over undocumented Discord byte (if present)
+ const byte = packet.readUInt8(offset);
+ if (byte === 0x00 || byte === 0x02) offset++;
packet = packet.slice(offset);
}
|
fix(Voice): only skip undocumented voice packet byte if present (#<I>)
* fix(Voice*): Only skip undocumented byte if present
* fix linting errors
|
discordjs_discord.js
|
train
|
js
|
03259bbc8c3a007337593de8809ab59b8fdba4e6
|
diff --git a/tests/Auth0Test.php b/tests/Auth0Test.php
index <HASH>..<HASH> 100644
--- a/tests/Auth0Test.php
+++ b/tests/Auth0Test.php
@@ -294,7 +294,7 @@ class Auth0Test extends TestCase
$mock = new MockHandler( [
// Code exchange response.
- new Response( 200, self::$headers, '{"access_token":"1.2.3","refresh_token":"2.3.4"}' ),
+ new Response( 200, self::$headers, '{"access_token":"1.2.3","refresh_token":"2.3.4","id_token":"'.$id_token.'"}' ),
// Refresh token response.
new Response( 200, self::$headers, '{"access_token":"__test_access_token__","id_token":"'.$id_token.'"}' ),
] );
@@ -315,6 +315,10 @@ class Auth0Test extends TestCase
$_SESSION['auth0__state'] = '__test_state__';
$this->assertTrue( $auth0->exchange() );
+
+ $this->assertArrayNotHasKey('auth0__nonce', $_SESSION);
+ $this->assertArrayNotHasKey('auth0__state', $_SESSION);
+
$auth0->renewTokens(['scope' => 'openid']);
$this->assertEquals( '__test_access_token__', $auth0->getAccessToken() );
|
fix: renew token test should fail nonce check after exchange
|
auth0_auth0-PHP
|
train
|
php
|
bea4756c366bff2fd8eb3c65512a4e37558341a1
|
diff --git a/lib/helpers/git/parse/ember-style.js b/lib/helpers/git/parse/ember-style.js
index <HASH>..<HASH> 100644
--- a/lib/helpers/git/parse/ember-style.js
+++ b/lib/helpers/git/parse/ember-style.js
@@ -56,10 +56,10 @@ function parseMessage(message) {
if (endTitleIndex <= 0) {
return {};
}
- var preTitle = message.substr(0, endTitleIndex);
+ var preTitle = message.substr(0, endTitleIndex + 1);
var postTitle = message.substr(endTitleIndex + 1);
- var preTitleExp = /^\[([a-zA-Z]+\s?)([a-zA-Z]+)?\]/;
+ var preTitleExp = /^\[([a-zA-Z]+)\s?([a-zA-Z]+)?\]/;
var preTitleParts = preTitle.match(preTitleExp);
if (!preTitleParts) {
@@ -67,7 +67,7 @@ function parseMessage(message) {
}
var type = preTitleParts[1].toUpperCase();
-
+
return {
type: type,
typeIsStandard: types.indexOf(type) !== -1,
|
fix(ember-style-parser): commit types are now correctly extracted
|
html-next_ember-cli-changelog
|
train
|
js
|
a1f5955a652c34b5629a7706b092b215663c85f9
|
diff --git a/pkg/storage/driver/cfgmaps.go b/pkg/storage/driver/cfgmaps.go
index <HASH>..<HASH> 100644
--- a/pkg/storage/driver/cfgmaps.go
+++ b/pkg/storage/driver/cfgmaps.go
@@ -100,7 +100,7 @@ func (cfgmaps *ConfigMaps) List(filter func(*rspb.Release) bool) ([]*rspb.Releas
for _, item := range list.Items {
rls, err := decodeRelease(item.Data["release"])
if err != nil {
- logerrf(err, "list: failed to decode release: %s", rls)
+ logerrf(err, "list: failed to decode release: %v", item)
continue
}
if filter(rls) {
@@ -201,7 +201,7 @@ func (cfgmaps *ConfigMaps) Delete(key string) (rls *rspb.Release, err error) {
return nil, ErrReleaseNotFound
}
- logerrf(err, "delete: failed to get release %q", rls.Name)
+ logerrf(err, "delete: failed to get release %q", key)
return nil, err
}
// delete the release
|
fix(tiller): fix nil pointers in error messages
There were a few places where error messages were accessing properties
of objects that were nil because of the error.
Closes #<I>
|
helm_helm
|
train
|
go
|
62e3d11c212c449d777461938efcfbe16575d522
|
diff --git a/packages/demoing-storybook/src/start/cli.js b/packages/demoing-storybook/src/start/cli.js
index <HASH>..<HASH> 100755
--- a/packages/demoing-storybook/src/start/cli.js
+++ b/packages/demoing-storybook/src/start/cli.js
@@ -20,7 +20,7 @@ async function run() {
: process.cwd();
const storybookConfigDir = config.storybookServerConfig['config-dir'];
- const storiesPattern = `${rootDir}/${config.storybookServerConfig.stories}`;
+ const storiesPattern = config.storybookServerConfig.stories;
const storyUrls = (await listFiles(storiesPattern, rootDir)).map(filePath => {
const relativeFilePath = path.relative(rootDir, filePath);
return `/${toBrowserPath(relativeFilePath)}`;
|
fix(demoing-storybook): remove rootDir prefexing on storiesPattern
|
open-wc_open-wc
|
train
|
js
|
3d50680f53860673ef0968fa2ea3217594d843d5
|
diff --git a/packages/date/src/DateRange.js b/packages/date/src/DateRange.js
index <HASH>..<HASH> 100644
--- a/packages/date/src/DateRange.js
+++ b/packages/date/src/DateRange.js
@@ -223,7 +223,9 @@ const DateRange = ({
// Focus the calendar icon once clicked because we don't
// want to get back in the loop of opening the calendar
- calendarIconRef.current.parentElement.focus();
+ if (calendarIconRef && calendarIconRef.current) {
+ calendarIconRef.current.parentElement.focus();
+ }
}}
>
{relativeRange}
|
fix(date): fix console error that happens whenever selecting a range for the date range
|
Availity_availity-react
|
train
|
js
|
01e4c5d743f2f237d2c85481118e467d4f5fde15
|
diff --git a/semantic_release/history/parser_angular.py b/semantic_release/history/parser_angular.py
index <HASH>..<HASH> 100644
--- a/semantic_release/history/parser_angular.py
+++ b/semantic_release/history/parser_angular.py
@@ -1,9 +1,10 @@
"""Angular commit style commit parser
"""
-import ndebug
import re
from typing import Tuple
+import ndebug
+
from ..errors import UnknownCommitMessageStyleError
from .parser_helpers import parse_text_block
diff --git a/semantic_release/vcs_helpers.py b/semantic_release/vcs_helpers.py
index <HASH>..<HASH> 100644
--- a/semantic_release/vcs_helpers.py
+++ b/semantic_release/vcs_helpers.py
@@ -3,8 +3,8 @@
import re
from typing import Optional, Tuple
-from git import GitCommandError, InvalidGitRepositoryError, Repo, TagObject
import ndebug
+from git import GitCommandError, InvalidGitRepositoryError, Repo, TagObject
from .errors import GitError, HvcsRepoParseError
from .settings import config
|
refactor: fix import sorting
|
relekang_python-semantic-release
|
train
|
py,py
|
bf3f0862407c304c5ddde59fd0c20607c7e5f0ee
|
diff --git a/lib/platform/github/gh-got-wrapper.js b/lib/platform/github/gh-got-wrapper.js
index <HASH>..<HASH> 100644
--- a/lib/platform/github/gh-got-wrapper.js
+++ b/lib/platform/github/gh-got-wrapper.js
@@ -188,7 +188,7 @@ get.reset = function reset() {
cache = null;
cache = {};
// istanbul ignore if
- if (stats.requests && stats.requests.length) {
+ if (stats.requests && stats.requests.length > 1) {
logger.info(
{
rateLimit: stats.rateLimit,
@@ -199,8 +199,8 @@ get.reset = function reset() {
);
stats.requests.sort();
logger.debug({ requests: stats.requests }, 'All requests');
+ stats = {};
}
- stats = {};
};
module.exports = get;
|
refactor: clear stats only if more than one request
|
renovatebot_renovate
|
train
|
js
|
8a9521123086e072c664512128b46209b2f00e06
|
diff --git a/src/managers/ThreadManager.js b/src/managers/ThreadManager.js
index <HASH>..<HASH> 100644
--- a/src/managers/ThreadManager.js
+++ b/src/managers/ThreadManager.js
@@ -66,7 +66,7 @@ class ThreadManager extends CachedManager {
* * `1440` (1 day)
* * `4320` (3 days) <warn>This is only available when the guild has the `THREE_DAY_THREAD_ARCHIVE` feature.</warn>
* * `10080` (7 days) <warn>This is only available when the guild has the `SEVEN_DAY_THREAD_ARCHIVE` feature.</warn>
- * * `'MAX'` Based on the guilds boost count
+ * * `'MAX'` Based on the guild's features
* @typedef {number|string} ThreadAutoArchiveDuration
*/
|
docs(ThreadManager): Fix typo (#<I>)
|
discordjs_discord.js
|
train
|
js
|
d6cd43b218419601aa9037b9b92992d7c872d4eb
|
diff --git a/lib/features/editing/EditBehavior.js b/lib/features/editing/EditBehavior.js
index <HASH>..<HASH> 100644
--- a/lib/features/editing/EditBehavior.js
+++ b/lib/features/editing/EditBehavior.js
@@ -36,7 +36,7 @@ function EditBehavior(eventBus, selection, sheet, elementRegistry, modeling, rul
row: event.element.row,
column: event.element.column,
content: event.element.content
- })) {
+ }) && !event.element.row.isFoot) {
event.gfx.setAttribute('contenteditable', true);
}
});
|
fix(modeling): do not make footer editable
|
bpmn-io_table-js
|
train
|
js
|
00ed3579584c785336827b424fae640a466f0f26
|
diff --git a/packages/core.js b/packages/core.js
index <HASH>..<HASH> 100644
--- a/packages/core.js
+++ b/packages/core.js
@@ -7,7 +7,7 @@
*/
import { INVALID_MOVE } from '../src/core/reducer.js';
-import { Pass, TurnOrder } from '../src/core/turn-order.js';
+import { Pass, Stage, TurnOrder } from '../src/core/turn-order.js';
import { PlayerView } from '../src/core/player-view.js';
-export { TurnOrder, Pass, PlayerView, INVALID_MOVE };
+export { Stage, TurnOrder, Pass, PlayerView, INVALID_MOVE };
|
feat: Expose the `Stage` defaults object via core package (#<I>)
Because `setStage` has been moved out of `turn.order`, `TurnOrder` and
`Stage` defaults have been separated. This exposes the new `Stage`
object via the core package — `import { Stage } from
'boardgame.io/core'` and use as `setStage: Stage.ANY_ONCE`.
|
nicolodavis_boardgame.io
|
train
|
js
|
00bb87eb5ffb2af997f41513832e27e7f23eb809
|
diff --git a/src/closure-compiler-plugin.js b/src/closure-compiler-plugin.js
index <HASH>..<HASH> 100644
--- a/src/closure-compiler-plugin.js
+++ b/src/closure-compiler-plugin.js
@@ -1394,7 +1394,7 @@ ClosureCompilerPlugin.DEFAULT_FLAGS_AGGRESSIVE_BUNDLE = {
module_resolution: 'WEBPACK',
rename_prefix_namespace: '__wpcc',
process_common_js_modules: true,
- dependency_mode: 'STRICT',
+ dependency_mode: 'PRUNE',
assume_function_wrapper: true,
source_map_include_content: true,
};
|
fix: STRICT is undefined
|
webpack-contrib_closure-webpack-plugin
|
train
|
js
|
6a087a01656b3e8f6ba2e87b40b0611519b75c2b
|
diff --git a/src/components/tabs/js/tabsController.js b/src/components/tabs/js/tabsController.js
index <HASH>..<HASH> 100644
--- a/src/components/tabs/js/tabsController.js
+++ b/src/components/tabs/js/tabsController.js
@@ -56,8 +56,8 @@ function MdTabsController($scope, $element, $mdUtil, $timeout) {
// Select the new tab if we don't have a selectedIndex, or if the
// selectedIndex we've been waiting for is this tab
- if ($scope.selectedIndex === -1 || !angular.isNumber($scope.selectedIndex) ||
- $scope.selectedIndex === self.indexOf(tab)) {
+ if (!angular.isDefined(tab.element.attr('md-active')) && ($scope.selectedIndex === -1 || !angular.isNumber($scope.selectedIndex) ||
+ $scope.selectedIndex === self.indexOf(tab))) {
tab.onAdd(self.contentArea, false);
self.select(tab);
} else {
|
fix(tabs): factors `me-active` attribute into selection logic to prevent unnecessary `md-on-select` calls
Closes #<I>.
|
angular_material
|
train
|
js
|
1c7a144dfb7a17bc9dacd060059eb9e9fe41c982
|
diff --git a/src/Modal.js b/src/Modal.js
index <HASH>..<HASH> 100644
--- a/src/Modal.js
+++ b/src/Modal.js
@@ -4,7 +4,6 @@ import ownerDocument from 'dom-helpers/ownerDocument';
import canUseDOM from 'dom-helpers/util/inDOM';
import getScrollbarSize from 'dom-helpers/util/scrollbarSize';
import pick from 'lodash-compat/object/pick';
-import merge from 'lodash-compat/object/merge';
import React from 'react';
import ReactDOM from 'react-dom';
import BaseModal from 'react-overlays/lib/Modal';
@@ -157,7 +156,7 @@ const Modal = React.createClass({
let { modalStyles } = this.state;
if (style) {
- modalStyles = merge(modalStyles, style);
+ modalStyles = { ...modalStyles, ...style };
}
let inClass = { in: props.show && !animation };
|
chore: use spread instead of lodash merge
|
react-bootstrap_react-bootstrap
|
train
|
js
|
7af3801d4f67db49867f1ca8077277a01ded48b1
|
diff --git a/src/Zephyrus/Database/Brokers/ListBroker.php b/src/Zephyrus/Database/Brokers/ListBroker.php
index <HASH>..<HASH> 100644
--- a/src/Zephyrus/Database/Brokers/ListBroker.php
+++ b/src/Zephyrus/Database/Brokers/ListBroker.php
@@ -81,6 +81,39 @@ abstract class ListBroker extends DatabaseBroker
}
/**
+ * Allows to manually apply the pagination (LIMIT) to the given SQL query.
+ *
+ * @param string $query
+ * @return string
+ */
+ protected function paginate(string $query): string
+ {
+ return $this->queryFilter->paginate($query);
+ }
+
+ /**
+ * Allows to manually apply the sort (ORDER BY) to the given SQL query.
+ *
+ * @param string $query
+ * @return string
+ */
+ protected function sort(string $query): string
+ {
+ return $this->queryFilter->sort($query);
+ }
+
+ /**
+ * Allows to manually apply the filter (WHERE) to the given SQL query.
+ *
+ * @param string $query
+ * @return string
+ */
+ protected function filter(string $query): string
+ {
+ return $this->queryFilter->filter($query);
+ }
+
+ /**
* Execute a SELECT query which return the entire set of rows in an array. Will filter the query according to the
* current filter loaded into the broker class. Returns null if the query did not fetch any result.
*
|
feat: add helper methods in ListBroker to apply filters
|
dadajuice_zephyrus
|
train
|
php
|
fc1413da0aabc4852e574ca21d4f8b8801297fab
|
diff --git a/tests/Api/CustomersTest.php b/tests/Api/CustomersTest.php
index <HASH>..<HASH> 100644
--- a/tests/Api/CustomersTest.php
+++ b/tests/Api/CustomersTest.php
@@ -65,6 +65,29 @@ class CustomersTest extends FunctionalTestCase
}
/** @test */
+ public function it_can_update_the_default_card_of_an_existing_customer()
+ {
+ $customer = $this->createCustomer();
+
+ $customerId = $customer['id'];
+
+ $card1 = $this->createCardThroughToken($customerId)['id'];
+ $card2 = $this->createCardThroughToken($customerId)['id'];
+
+ $customer = $this->stripe->customers()->find($customerId);
+
+ $this->assertSame($card1, $customer['default_source']);
+
+ $this->stripe->customers()->update($customerId, [
+ 'default_source' => $card2,
+ ]);
+
+ $customer = $this->stripe->customers()->find($customerId);
+
+ $this->assertSame($card2, $customer['default_source']);
+ }
+
+ /** @test */
public function it_can_delete_an_existing_customer()
{
$customer = $this->createCustomer();
|
chore: Add test to verify if the default card of a customer can be updated.
|
cartalyst_stripe
|
train
|
php
|
0b07f603c0a3062cec9e804e340df16a88d5a12d
|
diff --git a/lib/carlo.js b/lib/carlo.js
index <HASH>..<HASH> 100644
--- a/lib/carlo.js
+++ b/lib/carlo.js
@@ -92,6 +92,11 @@ class App extends EventEmitter {
* @return {!Promise}
*/
load(uri) {
+ if (!this.www_.size) {
+ this.page_.close();
+ throw new Error('Please call app.serveFolder(__dirname) or point to ' +
+ 'other folder(s) with your web files');
+ }
return this.page_.goto(`https://domain/${uri}`, {timeout: 0});
}
|
fix(server): throw an error if page is navigated w/o serveFolder call
|
GoogleChromeLabs_carlo
|
train
|
js
|
fce5fbaedec1e1f7e394239f58a46f996b31baf9
|
diff --git a/library/Customizer/Sections/Footer.php b/library/Customizer/Sections/Footer.php
index <HASH>..<HASH> 100644
--- a/library/Customizer/Sections/Footer.php
+++ b/library/Customizer/Sections/Footer.php
@@ -294,7 +294,7 @@ class Footer
'type' => 'upload',
'settings' => 'footer_subfooter_custom_logotype',
'label' => esc_html__('Upload SVG logo', 'municipio'),
- 'description' => 'Upload a custom logo for the subfooter.',
+ 'description' => 'Upload a custom .svg file to use as logo.',
'section' => self::SUBFOOTER_SECTION_ID,
'priority' => 10,
'transport' => 'refresh',
|
fix: Update description for subfooter logo
|
helsingborg-stad_Municipio
|
train
|
php
|
f8aba92234225137af70c71e59f450e95d40b03f
|
diff --git a/packages/posts/sources/instagram/index.js b/packages/posts/sources/instagram/index.js
index <HASH>..<HASH> 100644
--- a/packages/posts/sources/instagram/index.js
+++ b/packages/posts/sources/instagram/index.js
@@ -94,7 +94,8 @@ class InstagramSource extends CachedDataSource {
id: photoJson.user.id,
username: photoJson.user.username,
name: photoJson.user.full_name,
- url: `https://www.instagram.com/${photoJson.user.username}`
+ url: `https://www.instagram.com/${photoJson.user.username}`,
+ image: photoJson.user.profile_picture
}
});
}
|
chore(posts): Store the Instagram creator image URL.
|
randytarampi_me
|
train
|
js
|
29c25d34f61ae4c2058ffc3ae4219ae6ad8b2775
|
diff --git a/semantic_release/vcs_helpers.py b/semantic_release/vcs_helpers.py
index <HASH>..<HASH> 100644
--- a/semantic_release/vcs_helpers.py
+++ b/semantic_release/vcs_helpers.py
@@ -37,7 +37,7 @@ def get_last_version(skip_tags=None):
return x.commit.committed_date
for i in sorted(repo.tags, reverse=True, key=version_finder):
- if re.match('v\d+\.\d+\.\d+', i.name):
+ if re.match(r'v\d+\.\d+\.\d+', i.name):
if i.name in skip_tags:
continue
return i.name[1:]
|
style(vcs_helpers): Add r prefix to regular expression match string
This 'raw' designator gets rid of flake8 complaints
|
relekang_python-semantic-release
|
train
|
py
|
d8738cc3c4df00a1f62b4c659361bafe799a3a8f
|
diff --git a/lib/sender_link.js b/lib/sender_link.js
index <HASH>..<HASH> 100644
--- a/lib/sender_link.js
+++ b/lib/sender_link.js
@@ -122,12 +122,6 @@ SenderLink.prototype._sendMessage = function(message, options) {
}
}
- this.session._transfersInFlight[messageId] = {
- message: message,
- options: options,
- sent: Date.now()
- };
-
// create frame and send
var transferOptions = _.defaults(options, {
channel: this.session.channel,
diff --git a/lib/session.js b/lib/session.js
index <HASH>..<HASH> 100644
--- a/lib/session.js
+++ b/lib/session.js
@@ -120,7 +120,6 @@ function Session(conn) {
this._linksByName = {};
this._linksByRemoteHandle = {};
this._senderLinks = [];
- this._transfersInFlight = {};
this._deliveryTag = 1;
var self = this;
|
fix(SenderLink): temporarily remove transfersInFlight
Session._transfersInFlight was used to keep track of messages that
may have been required to be resent upon link reattachment. As we
currently have no logic for this (and this was being set whether we
were guaranteed to get disposition for the frame or not), I've
opted to remove this until that behavior is more completely
implemented.
|
noodlefrenzy_node-amqp10
|
train
|
js,js
|
7c840bd181f6aa63511317610317c6944d06f5c5
|
diff --git a/src/ContentType.php b/src/ContentType.php
index <HASH>..<HASH> 100644
--- a/src/ContentType.php
+++ b/src/ContentType.php
@@ -15,10 +15,10 @@ final class ContentType
public const KEY = 'content-type';
// Commonly used content types
+ public const XML = 'text/xml';
public const HTML = 'text/html';
public const TEXT = 'text/plain';
public const JSON = 'application/json';
- public const XML = 'application/xml';
public const FORM = 'application/x-www-form-urlencoded';
// For upload file
|
fix: xml content type is error
|
swoft-cloud_swoft-http-message
|
train
|
php
|
b33d990ce4fc283068f8701313d53589bffe44a3
|
diff --git a/lib/features/interaction-events/InteractionEvents.js b/lib/features/interaction-events/InteractionEvents.js
index <HASH>..<HASH> 100644
--- a/lib/features/interaction-events/InteractionEvents.js
+++ b/lib/features/interaction-events/InteractionEvents.js
@@ -7,16 +7,15 @@ var GraphicsUtil = require('../../util/GraphicsUtil');
/**
- * @class
- *
* A plugin that provides interactivity in terms of events (mouse over and selection to a diagram).
*
+ * @class
+ *
* @param {EventBus} eventBus
*/
function InteractionEvents(eventBus, styles) {
var HIT_STYLE = styles.cls('djs-hit', [ 'no-fill', 'no-border' ], {
- pointerEvents: 'stroke',
stroke: 'white',
strokeWidth: 10
});
|
fix(interaction-events): do not explicitly set pointer-events
This allows us to override the property via CSS.
|
bpmn-io_diagram-js
|
train
|
js
|
4d86e86bb9e979146a27b70ec0e807119ba397e9
|
diff --git a/src/plugins/notify.js b/src/plugins/notify.js
index <HASH>..<HASH> 100644
--- a/src/plugins/notify.js
+++ b/src/plugins/notify.js
@@ -88,6 +88,10 @@ function init ({ $q, Vue }) {
})
}
+ if (typeof config.onDismiss === 'function') {
+ notif.onDismiss = config.onDismiss
+ }
+
if (notif.closeBtn) {
const btn = [{
closeBtn: true,
|
fix(Notify): set onDismiss handler (#<I>)
* fix(Notify): set onDismiss handler
* Fix prev commit
|
quasarframework_quasar
|
train
|
js
|
1ee16c602160c8a7135f4a9e44dd69f5476d622a
|
diff --git a/src/Lucid/Model/index.js b/src/Lucid/Model/index.js
index <HASH>..<HASH> 100644
--- a/src/Lucid/Model/index.js
+++ b/src/Lucid/Model/index.js
@@ -191,7 +191,7 @@ class Model extends BaseModel {
*
* @method query
*
- * @return {LucidQueryBuilder}
+ * @return {QueryBuilder}
*
* @static
*/
|
chore(intellisense): fix return of query static method
|
adonisjs_adonis-lucid
|
train
|
js
|
4e5f040a5fc02eabcafa539ac368c5860f4fcb57
|
diff --git a/GVRf/Framework/src/org/gearvrf/GVRContext.java b/GVRf/Framework/src/org/gearvrf/GVRContext.java
index <HASH>..<HASH> 100644
--- a/GVRf/Framework/src/org/gearvrf/GVRContext.java
+++ b/GVRf/Framework/src/org/gearvrf/GVRContext.java
@@ -672,9 +672,7 @@ public abstract class GVRContext {
AiNode node,
AiWrapperProvider<byte[], AiMatrix4f, AiColor, AiNode, byte[]> wrapperProvider) {
try {
- // for (AiNode childNode : childrenNodes) {
for (int i = 0; i < node.getNumMeshes(); i++) {
-
FutureWrapper<GVRMesh> futureMesh = new FutureWrapper<GVRMesh>(
this.getNodeMesh(new GVRAndroidResource(this,
assetRelativeFilename), node.getName(), i));
@@ -770,8 +768,6 @@ public abstract class GVRContext {
wholeSceneObject, node.getChildren().get(i),
wrapperProvider);
}
-
- // }
} catch (Exception e) {
// Error while recursing the Scene Graph
e.printStackTrace();
|
refactor: Recator the GVRContext.java
|
Samsung_GearVRf
|
train
|
java
|
c4ad1c12d7147d5e1635bd1f30a4e956e05ad90b
|
diff --git a/packages/testing-karma/default-settings.js b/packages/testing-karma/default-settings.js
index <HASH>..<HASH> 100644
--- a/packages/testing-karma/default-settings.js
+++ b/packages/testing-karma/default-settings.js
@@ -65,7 +65,7 @@ module.exports = config => ({
loader: 'istanbul-instrumenter-loader',
enforce: 'post',
include: path.resolve('./'),
- exclude: /node_modules|bower_components|\.test\.js$/,
+ exclude: /node_modules|bower_components|\.(spec|test)\.js$/,
options: {
esModules: true,
},
|
fix(testing-karma): exclude spec files in node_modules
previously we only excluded `test` files.
|
open-wc_open-wc
|
train
|
js
|
f0725f3d30f9561895a15a61ddab3097b6416133
|
diff --git a/test/basic-tests.js b/test/basic-tests.js
index <HASH>..<HASH> 100644
--- a/test/basic-tests.js
+++ b/test/basic-tests.js
@@ -12,27 +12,21 @@ const path = require('path')
const schemaDir = path.resolve(__dirname, 'fixtures', 'schema')
const expectedDir = path.resolve(__dirname, 'fixtures', 'expected')
-describe('Run some basic tests', function () {
- it('database structure for a simple schema', done => {
+describe('relationize', () => {
+ it('database structure for a simple schema', async () => {
const peopleSchema = require(path.resolve(schemaDir, 'people/people.json'))
- relationize({
+ const dbStructure = await relationize({
source: {
schemas: [{
namespace: 'relationizeTest',
schema: peopleSchema
}]
}
- },
- (err, dbStructure) => {
- if (err) return done(err)
-
- const expected = require(path.resolve(expectedDir, 'people-structure.json'))
- expect(dbStructure).to.containSubset(expected)
+ })
- done()
- }
- )
+ const expected = require(path.resolve(expectedDir, 'people-structure.json'))
+ expect(dbStructure).to.containSubset(expected)
})
it('database structure for a nested schema', async () => {
|
test: Flip from callback to async/await
|
wmfs_relationize
|
train
|
js
|
d035ecce71f2c1d692930820f1eddf77d86265e2
|
diff --git a/pkg/apis/externaldns/types.go b/pkg/apis/externaldns/types.go
index <HASH>..<HASH> 100644
--- a/pkg/apis/externaldns/types.go
+++ b/pkg/apis/externaldns/types.go
@@ -166,7 +166,7 @@ type Config struct {
RFC2136GSSTSIG bool
RFC2136KerberosRealm string
RFC2136KerberosUsername string
- RFC2136KerberosPassword string
+ RFC2136KerberosPassword string `secure:"yes"`
RFC2136TSIGKeyName string
RFC2136TSIGSecret string `secure:"yes"`
RFC2136TSIGSecretAlg string
|
feat: restrict rfc<I> kerberos password from being exposed in logs
|
kubernetes-incubator_external-dns
|
train
|
go
|
f12e2b08a0faaf77b93cc5ce51313c9d7b3ba204
|
diff --git a/src/Drawer/HeaderAccount.react.js b/src/Drawer/HeaderAccount.react.js
index <HASH>..<HASH> 100644
--- a/src/Drawer/HeaderAccount.react.js
+++ b/src/Drawer/HeaderAccount.react.js
@@ -12,7 +12,7 @@ const propTypes = {
avatar: PropTypes.element,
onPress: PropTypes.func,
})),
- footer: ListItem.propTypes,
+ footer: PropTypes.shape(ListItem.propTypes),
style: PropTypes.shape({
container: ViewPropTypes.style,
accountContainer: ViewPropTypes.style,
|
fix: PropTypes of Drawer.HeaderAccount (#<I>)
|
xotahal_react-native-material-ui
|
train
|
js
|
b740de399a369a2eefd436be40b93295fb0f4362
|
diff --git a/classes/hypeJunction/Prototyper/UI.php b/classes/hypeJunction/Prototyper/UI.php
index <HASH>..<HASH> 100644
--- a/classes/hypeJunction/Prototyper/UI.php
+++ b/classes/hypeJunction/Prototyper/UI.php
@@ -74,7 +74,7 @@ class UI {
$show_access = (bool) elgg_extract('show_access', $options, false);
$relationship = elgg_extract('relationship', $options, array());
- unset($options['reationship']);
+ unset($options['relationship']);
$inverse_relationship = (bool) elgg_extract('inverse_relationship', $relationship, false);
$bilateral = (bool) elgg_extract('bileteral', $relationship, false);
|
fix(ui): fix typo that prevented relationship from being unset from options
|
hypeJunction_hypePrototyper
|
train
|
php
|
05091e02fa692fd4da726ab9007cf5ef9fa0e6c6
|
diff --git a/karma.conf.js b/karma.conf.js
index <HASH>..<HASH> 100644
--- a/karma.conf.js
+++ b/karma.conf.js
@@ -15,8 +15,7 @@ module.exports = function(karma) {
colors: true,
port: 8080,
basePath: '.',
- // browsers: ['ChromeHeadlessNoSandbox'],
- browsers: ['Chrome'],
+ browsers: [process.env.TRAVIS ? 'ChromeHeadlessNoSandbox' : 'Chrome'],
customLaunchers: {
ChromeHeadlessNoSandbox: { base: 'ChromeHeadless', flags: ['--no-sandbox'] },
},
|
test(travis): use ChromHeadless on travis
|
ui-router_rx
|
train
|
js
|
d81f1af139bf79bcf1b8750fe4d9fd5821718331
|
diff --git a/submissions/views.py b/submissions/views.py
index <HASH>..<HASH> 100644
--- a/submissions/views.py
+++ b/submissions/views.py
@@ -3,7 +3,7 @@
import logging
from django.contrib.auth.decorators import login_required
-from django.shortcuts import render_to_response
+from django.shortcuts import render
from submissions.api import SubmissionRequestError, get_submissions
@@ -42,4 +42,4 @@ def get_submissions_for_student_item(request, course_id, student_id, item_id):
except SubmissionRequestError:
context["error"] = "The specified student item was not found."
- return render_to_response('submissions.html', context)
+ return render(request, 'submissions.html', context)
|
refactor: address ancient django feature removal
this was removed in django 3. (Also this view file can likely be deleted.)
|
edx_edx-submissions
|
train
|
py
|
1fb74cd5dd652c8f7b86af2dad80387ea0bb515d
|
diff --git a/lib/change_stream.js b/lib/change_stream.js
index <HASH>..<HASH> 100644
--- a/lib/change_stream.js
+++ b/lib/change_stream.js
@@ -335,7 +335,7 @@ var processNewChange = function(self, err, change, callback) {
// Cache the resume token if it is present. If it is not present return an error.
if (!change || !change._id) {
var noResumeTokenError = new Error(
- 'A change stream document has been recieved that lacks a resume token (_id).'
+ 'A change stream document has been received that lacks a resume token (_id).'
);
if (typeof callback === 'function') return callback(noResumeTokenError, null);
if (self.listenerCount('error')) return self.emit('error', noResumeTokenError);
|
style(change-streams): fix typo in change stream error message
|
mongodb_node-mongodb-native
|
train
|
js
|
6dac81e310cbc297038b92307c83d782e674c463
|
diff --git a/src/plugins/notify.js b/src/plugins/notify.js
index <HASH>..<HASH> 100644
--- a/src/plugins/notify.js
+++ b/src/plugins/notify.js
@@ -163,7 +163,6 @@ export default {
if (this.__installed) { return }
this.__installed = true
- console.log('install')
if (!isSSR) {
init.call(this, args)
}
|
chore: Addition to previous commit; remove debugging
|
quasarframework_quasar
|
train
|
js
|
05c901fd4f622aa9aa87b3eabfc87f0bec6dea30
|
diff --git a/workflow/executor/emissary/binary.go b/workflow/executor/emissary/binary.go
index <HASH>..<HASH> 100644
--- a/workflow/executor/emissary/binary.go
+++ b/workflow/executor/emissary/binary.go
@@ -17,7 +17,9 @@ func copyBinary() error {
return err
}
defer func() { _ = in.Close() }()
- out, err := os.OpenFile("/var/run/argo/argoexec", os.O_RDWR|os.O_CREATE, 0o500) // r-x------
+ // argoexec needs to be executable from non-root user in the main container.
+ // Therefore we set permission 0o555 == r-xr-xr-x.
+ out, err := os.OpenFile("/var/run/argo/argoexec", os.O_RDWR|os.O_CREATE, 0o555)
if err != nil {
return err
}
|
fix(executor): emissary - make argoexec executable from non-root containers. Fixes #<I> (#<I>)
|
argoproj_argo
|
train
|
go
|
74c07acdfbdd509fe677a4d05e16b1c6e5de2be3
|
diff --git a/packages/node_modules/@ciscospark/internal-plugin-wdm/src/device/device.js b/packages/node_modules/@ciscospark/internal-plugin-wdm/src/device/device.js
index <HASH>..<HASH> 100644
--- a/packages/node_modules/@ciscospark/internal-plugin-wdm/src/device/device.js
+++ b/packages/node_modules/@ciscospark/internal-plugin-wdm/src/device/device.js
@@ -70,7 +70,18 @@ const Device = SparkPlugin.extend({
* @type {string}
*/
webFileShareControl: 'string',
- webSocketUrl: 'string'
+ webSocketUrl: 'string',
+ /**
+ * Notifies the client if whiteboarding should be allowed
+ * regardless of webFileShareControl settings.
+ * Currently, the values for it are:
+ * - ALLOW
+ * - BLOCK
+ * @instance
+ * @memberof Device
+ * @type {string}
+ */
+ whiteboardFileShareControl: 'string'
},
derived: {
|
feat(i-p-wdm): Add whiteboardFileShareControl property to device
Pass along "new" wdm property to device spark.internal.device users
|
webex_spark-js-sdk
|
train
|
js
|
fab7496a1862ff8959704b6bb6e127578cb38605
|
diff --git a/src/foremast/utils/gcp_environment.py b/src/foremast/utils/gcp_environment.py
index <HASH>..<HASH> 100644
--- a/src/foremast/utils/gcp_environment.py
+++ b/src/foremast/utils/gcp_environment.py
@@ -57,7 +57,8 @@ class GcpEnvironment:
return self._all_projects_cache
# No cached response found, check GCP APIs
- service = discovery.build('cloudresourcemanager', 'v1', credentials=self.get_credentials(), cache_discovery=False)
+ service = discovery.build('cloudresourcemanager', 'v1', credentials=self.get_credentials(),
+ cache_discovery=False)
project_filter = self._get_project_api_filter()
request = service.projects().list(filter=project_filter)
response = request.execute()
|
chore: linting issues in gcp environment
|
foremast_foremast
|
train
|
py
|
3b9529eb45d7b115d7034ee14c881f3645050aa3
|
diff --git a/packages/components/bolt-toc/src/toc.js b/packages/components/bolt-toc/src/toc.js
index <HASH>..<HASH> 100644
--- a/packages/components/bolt-toc/src/toc.js
+++ b/packages/components/bolt-toc/src/toc.js
@@ -50,11 +50,6 @@ class BoltToc extends withContext(BoltElement) {
// These are fixed for now, make into props if necessary
this.boundaryTop = 0;
this.boundaryBottom = '75%';
-
- // Dislay waypoint boundaries on screen if debug is `true` (only ever IN_DEV!)
- if (IS_DEV && BoltToc.debug && !BoltToc.debuggerAdded) {
- this.addWaypointDebugger();
- }
}
static get styles() {
@@ -94,6 +89,11 @@ class BoltToc extends withContext(BoltElement) {
document.addEventListener('scrollStart', this.logScrollEvent, false);
document.addEventListener('scrollStop', this.logScrollEvent, false);
document.addEventListener('scrollCancel', this.logScrollEvent, false);
+
+ // Dislay waypoint boundaries on screen if debug is `true` (only ever IN_DEV!)
+ if (IS_DEV && BoltToc.debug && !BoltToc.debuggerAdded) {
+ this.addWaypointDebugger();
+ }
}
disconnectedCallback() {
|
refactor: move waypoint debugger to `connectedCallback`
|
bolt-design-system_bolt
|
train
|
js
|
3300daaf23577c02a948a04553b25acb1f5153d1
|
diff --git a/components/datepicker/index.js b/components/datepicker/index.js
index <HASH>..<HASH> 100644
--- a/components/datepicker/index.js
+++ b/components/datepicker/index.js
@@ -167,7 +167,7 @@ export default class Datepicker extends Intact {
} else if (!v.length) {
// calendar cancelled the selected value
this.set('_value', undefined);
- } else if (!value || value && value.length === 2) {
+ } else if (!value || value.length === 0 || value.length === 2) {
value = [v[v.length - 1]];
if (type === 'end') {
begin.set('_isSelectTime', false);
|
fix(datepicker): set the first value when pass an array which length is 0
|
ksc-fe_kpc
|
train
|
js
|
411df151ad730f9ecd793e5bf491e012fa6c9ea1
|
diff --git a/packages/ui-docs-client/src/Properties/index.js b/packages/ui-docs-client/src/Properties/index.js
index <HASH>..<HASH> 100644
--- a/packages/ui-docs-client/src/Properties/index.js
+++ b/packages/ui-docs-client/src/Properties/index.js
@@ -67,9 +67,14 @@ class Properties extends Component {
return Object.keys(props)
.filter((name) => {
const description = props[name].description || ''
+
+ // `styles` and `makeStyles` are added by withStyle decorator,
+ // shouldn't be listed
return (
description.indexOf('@private') < 0 &&
- description.indexOf('@deprecated') < 0
+ description.indexOf('@deprecated') < 0 &&
+ name !== 'styles' &&
+ name !== 'makeStyles'
)
})
.map((name) => {
|
docs(ui-docs-client): filter out styles and makeStyles from component property lists
Closes: INSTUI-<I>
|
instructure_instructure-ui
|
train
|
js
|
dc3b915417f58a251b169505756193e66e8ef7d0
|
diff --git a/test/lib/appTest.js b/test/lib/appTest.js
index <HASH>..<HASH> 100644
--- a/test/lib/appTest.js
+++ b/test/lib/appTest.js
@@ -23,6 +23,8 @@ describe('lib/app', () => {
const spy = sinon.spy();
const expected = `${dirname}/../foo/bar`;
testModule.relativeRequire('foo', 'bar', spy);
+ const actual = spy.firstCall.args[0];
+ actual.should.equal(expected);
spy.calledWith(expected).should.be.true;
});
it('should require relative to config for relative path', () => {
|
test: Update tests for relativeRequire()
|
SockDrawer_SockBot
|
train
|
js
|
00b8d5b401aa8aa47bc664b9a976bf57ca7344e8
|
diff --git a/api/src/opentrons/hardware_control/__init__.py b/api/src/opentrons/hardware_control/__init__.py
index <HASH>..<HASH> 100644
--- a/api/src/opentrons/hardware_control/__init__.py
+++ b/api/src/opentrons/hardware_control/__init__.py
@@ -543,8 +543,8 @@ class API(HardwareAPILike):
for smoothie_plunger, current in smoothie_plungers.items():
self._backend.set_active_current(
smoothie_plunger, current)
- smoothie_pos.update(
- self._backend.home([smoothie_plunger.name.upper()]))
+ self._backend.home([smoothie_plunger.name.upper()])
+ smoothie_pos.update(self._backend.update_position())
self._current_position = self._deck_from_smoothie(smoothie_pos)
async def add_tip(
|
fix(api): Ensure position is fully updated after a home (#<I>)
|
Opentrons_opentrons
|
train
|
py
|
2d38f8c584dce948622c75b5bc4a4d62039d167a
|
diff --git a/lib/handlers/file-proxy.js b/lib/handlers/file-proxy.js
index <HASH>..<HASH> 100644
--- a/lib/handlers/file-proxy.js
+++ b/lib/handlers/file-proxy.js
@@ -1,4 +1,5 @@
var fs = require('fs');
+var path = require('path');
var extend = require('util')._extend;
var util = require('../util');
var url = require('url');
@@ -129,6 +130,7 @@ module.exports = function(req, res, next) {
}
};
+ var realUrl = rule.root ? path.join(rule.root, rule.matcher) : rule.matcher;
if (isTplProtocol(protocol)){
reader.realUrl = rule.matcher;
render(reader);
|
feat: Supports tpl rule.root
|
avwo_whistle
|
train
|
js
|
1c2ac54826493e3f4765833f627dd7560f9a5069
|
diff --git a/src/directives/formly-field.js b/src/directives/formly-field.js
index <HASH>..<HASH> 100644
--- a/src/directives/formly-field.js
+++ b/src/directives/formly-field.js
@@ -69,7 +69,7 @@ function formlyField($http, $q, $compile, $templateCache, $interpolate, formlyCo
setter(field, value);
});
});
- });
+ }, 0, false);
}
function valueGetterSetter(newVal) {
@@ -168,7 +168,6 @@ function formlyField($http, $q, $compile, $templateCache, $interpolate, formlyCo
}
formControl.$render();
- // REMOVE UNDEFINED CHECK WHEN DROPPING ANGULAR 1.2 SUPPORT
formControl.$setUntouched && formControl.$setUntouched();
formControl.$setPristine();
|
perf(expressionProperties): 🌟 Don't fire digest for every runExpressions call
Because we're using to assign the value, this will run in which means only one digest
for all the that are running 😀
closes #<I>
|
formly-js_angular-formly
|
train
|
js
|
15553ec46beb59f8df007606d666c65a0f5f1dab
|
diff --git a/packages/provider-test-tools/src/edition.js b/packages/provider-test-tools/src/edition.js
index <HASH>..<HASH> 100644
--- a/packages/provider-test-tools/src/edition.js
+++ b/packages/provider-test-tools/src/edition.js
@@ -51,6 +51,7 @@ export default ({ variables = () => {} } = {}) => {
return {};
},
Media: () => ({ __typename: "Image" }),
+ PublicationName: () => "TIMES",
Ratio: () => "16:9",
Section: () => ({
__typename: "StandardSection",
|
fix: Attempt to fix Edition Provider Test Tools (#<I>)
* fix: Attempt to fix Edition Provider Test Tools
|
newsuk_times-components
|
train
|
js
|
558750ecfe460ee3729e646a14dd6efb46476fff
|
diff --git a/system-test/vision.js b/system-test/vision.js
index <HASH>..<HASH> 100644
--- a/system-test/vision.js
+++ b/system-test/vision.js
@@ -94,11 +94,7 @@ describe('Vision', function() {
});
describe('single image', () => {
- const TYPES = [
- {type: 'FACE_DETECTION'},
- {type: 'LABEL_DETECTION'},
- {type: 'SAFE_SEARCH_DETECTION'},
- ];
+ const TYPES = [{type: 'LABEL_DETECTION'}, {type: 'SAFE_SEARCH_DETECTION'}];
it('should perform multiple detections', () => {
return client
.annotateImage({
@@ -107,7 +103,6 @@ describe('Vision', function() {
})
.then(responses => {
const response = responses[0];
- assert(response.faceAnnotations.length >= 1);
assert(response.labelAnnotations.length >= 1);
assert(response.safeSearchAnnotation !== null);
});
|
test: remove outdated test (#<I>)
* test: remove outdated test
* lint fix
* fix again
|
googleapis_nodejs-vision
|
train
|
js
|
5088cda3cec9459de9911f0a807a14e85c745613
|
diff --git a/docs/styleguide.config.js b/docs/styleguide.config.js
index <HASH>..<HASH> 100644
--- a/docs/styleguide.config.js
+++ b/docs/styleguide.config.js
@@ -3,6 +3,7 @@ const webpackMerge = require('webpack-merge')
module.exports = {
title: 'Cozy UI React components',
+ pagePerSection: true,
sections: [
{
name: 'Bar',
|
feat: Only one page per section
Since we start to have a lot of examples, performance starts
to degrade when loading the styleguidist. Having only one page
per section could help
|
cozy_cozy-ui
|
train
|
js
|
c7c847056b6d24ba7a54b93837950b7fdff6c477
|
diff --git a/gitlab/__init__.py b/gitlab/__init__.py
index <HASH>..<HASH> 100644
--- a/gitlab/__init__.py
+++ b/gitlab/__init__.py
@@ -31,7 +31,7 @@ from gitlab.exceptions import * # noqa
from gitlab import utils # noqa
__title__ = "python-gitlab"
-__version__ = "1.9.0"
+__version__ = "1.10.0"
__author__ = "Gauvain Pocentek"
__email__ = "gauvainpocentek@gmail.com"
__license__ = "LGPL3"
|
chore: bump package version to <I>
|
python-gitlab_python-gitlab
|
train
|
py
|
e5336c94ca76f4fb18c54937b497d1a914b5c50b
|
diff --git a/public/js/chrome/navigation.js b/public/js/chrome/navigation.js
index <HASH>..<HASH> 100644
--- a/public/js/chrome/navigation.js
+++ b/public/js/chrome/navigation.js
@@ -180,7 +180,7 @@ var dropdownButtons = $('.button-dropdown, .button-open').mousedown(function (e)
if (menuDown) {
$(this.hash).attr('tabindex', 0);
menuDown = false;
- return true;
+ return jsbin.mobile;
}
menuDown = false;
|
fix: file menu following link
Fixes #<I>
|
jsbin_jsbin
|
train
|
js
|
67c9dae0a0024fe64e150c63173be42d35a4b1c8
|
diff --git a/test/encode.test.js b/test/encode.test.js
index <HASH>..<HASH> 100644
--- a/test/encode.test.js
+++ b/test/encode.test.js
@@ -31,6 +31,16 @@ test('bencode#encode()', function (t) {
t.equal(bencode.encode(data).toString(), 'd2:1211:Hello World2:34i12345ee')
})
+ t.test('should encode a Map as dictionary', function (t) {
+ t.plan(1)
+ var data = new Map([
+ [ 12, 'Hello World' ],
+ [ '34', 12345 ],
+ [ Buffer.from('buffer key'), Buffer.from('buffer value') ]
+ ])
+ t.equal(bencode.encode(data).toString(), 'd2:1211:Hello World2:34i12345e10:buffer key12:buffer valuee')
+ })
+
t.test('should be able to encode a positive integer', function (t) {
t.plan(1)
t.equal(bencode.encode(123).toString(), 'i123e')
|
test: Add test for Map dictionary encoding
|
themasch_node-bencode
|
train
|
js
|
e7f819d68994086b61a5c12189912ca35bcf74c4
|
diff --git a/src/InfoViz/Native/ParallelCoordinates/index.js b/src/InfoViz/Native/ParallelCoordinates/index.js
index <HASH>..<HASH> 100644
--- a/src/InfoViz/Native/ParallelCoordinates/index.js
+++ b/src/InfoViz/Native/ParallelCoordinates/index.js
@@ -533,7 +533,7 @@ function parallelCoordinate(publicAPI, model) {
const nbPolyDraw = model.axes.getNumberOf2DHistogram();
const axesCenters = model.axes.extractAxesCenters(model);
- if (!(model.axes.hasSelection() && model.showOnlySelection)) {
+ if (!model.showOnlySelection) {
for (let j = 0; j < nbPolyDraw; ++j) {
const axisOne = model.axes.getAxis(j);
const axisTwo = model.axes.getAxis(j + 1);
|
fix(ParallelCoordinates): Fix bug which prevented hiding bg polys
When showing an anntation where all axes involved were not displayed, we could not hide background
polygons.
|
Kitware_paraviewweb
|
train
|
js
|
b3e20aea9b390729124550c249a45e44e75962e2
|
diff --git a/test/truncate_test.go b/test/truncate_test.go
index <HASH>..<HASH> 100644
--- a/test/truncate_test.go
+++ b/test/truncate_test.go
@@ -34,24 +34,24 @@ func TestSimpleTruncate(t *testing.T) {
truncate("file", 0),
read("file", ""),
truncate("file", mb),
- read("file", string(mzero)),
+ preadBS("file", mzero, 0),
truncate("file", 0),
read("file", ""),
write("file", "world"),
read("file", "world"),
truncate("file", mb),
- read("file", string(mdata)),
- write("file", string(mdat2[:wlen])),
- read("file", string(mdat2)),
+ preadBS("file", mdata, 0),
+ writeBS("file", mdat2[:wlen]),
+ preadBS("file", mdat2, 0),
truncate("file", 0),
read("file", ""),
// Write past an unaligned hole
truncate("file", 777777),
- write("file", string(mdat3)),
- read("file", string(mdat3)),
+ writeBS("file", mdat3),
+ preadBS("file", mdat3, 0),
),
as(bob,
- read("file", string(mdat3)),
+ preadBS("file", mdat3, 0),
),
)
}
|
test: Avoid some extra allocation in truncate tests
|
keybase_client
|
train
|
go
|
33b3308df642b81ab56f6618a224c4c37decbe40
|
diff --git a/lib/workers/repository/process/lookup/index.js b/lib/workers/repository/process/lookup/index.js
index <HASH>..<HASH> 100644
--- a/lib/workers/repository/process/lookup/index.js
+++ b/lib/workers/repository/process/lookup/index.js
@@ -64,7 +64,10 @@ async function lookupUpdates(config) {
// istanbul ignore if
if (allVersions.length === 0) {
const message = `No valid versions returned from registry for this package`;
- logger.debug({ dependency: depName, result: dependency }, message);
+ logger.debug(
+ { purl: config.purl, dependency: depName, result: dependency },
+ message
+ );
if (!config.currentDigest) {
return res;
}
|
refactor: log purl if lookup fails
|
renovatebot_renovate
|
train
|
js
|
79048d7b5b1f09e764b3c47b1133c0ac4db778e1
|
diff --git a/packages/cozy-konnector-libs/src/libs/request/request.spec.js b/packages/cozy-konnector-libs/src/libs/request/request.spec.js
index <HASH>..<HASH> 100644
--- a/packages/cozy-konnector-libs/src/libs/request/request.spec.js
+++ b/packages/cozy-konnector-libs/src/libs/request/request.spec.js
@@ -128,7 +128,7 @@ describe('requestFactory', () => {
new Error('Error: unable to verify the first certificate')
)
})
- test('Self-signed cert should be refused', async () => {
+ test.skip('Self-signed cert should be refused', async () => {
return expect(rq('https://self-signed.badssl.com')).rejects.toEqual(
new Error('Error: self signed certificate')
)
|
fix: Disable a self-signed cert test since test site have an error
|
konnectors_libs
|
train
|
js
|
92fc2db4cefa7e0ed4e225ddd8ff5d46ada39b2b
|
diff --git a/stream.go b/stream.go
index <HASH>..<HASH> 100644
--- a/stream.go
+++ b/stream.go
@@ -24,6 +24,8 @@ func (gitter *Gitter) Stream(roomID string) *Stream {
func (gitter *Gitter) Listen(stream *Stream) {
+ defer stream.destroy()
+
var reader *bufio.Reader
var gitterMessage Message
@@ -43,8 +45,9 @@ Loop:
reader = bufio.NewReader(stream.getResponse().Body)
line, err := reader.ReadBytes('\n')
- if err != nil {
- gitter.log(err)
+ if stream.isClosed() {
+ continue
+ } else if err != nil {
stream.connect()
continue
}
@@ -75,6 +78,10 @@ type Stream struct {
gitter *Gitter
}
+func (stream *Stream) destroy() {
+ close(stream.Event)
+}
+
type Event struct {
Data interface{}
}
|
fix: close the channel on closed stream
|
sromku_go-gitter
|
train
|
go
|
5dc5ce699347ffa2a4088bd12005e684fd2abf73
|
diff --git a/packages/bullet/src/Bullet.js b/packages/bullet/src/Bullet.js
index <HASH>..<HASH> 100644
--- a/packages/bullet/src/Bullet.js
+++ b/packages/bullet/src/Bullet.js
@@ -75,7 +75,9 @@ export class Bullet extends Component {
const max = Math.max(...all)
- const scale = scaleLinear().domain([0, max])
+ const min = Math.min(...all, 0)
+
+ const scale = scaleLinear().domain([min, max])
if (layout === 'horizontal') {
scale.range(reverse === true ? [width, 0] : [0, width])
|
feat(bullet): support ranges that support < 0
|
plouc_nivo
|
train
|
js
|
28a4d5a49bfcae2d4822c1b25ff73ab2bb1ec79a
|
diff --git a/src/define.js b/src/define.js
index <HASH>..<HASH> 100644
--- a/src/define.js
+++ b/src/define.js
@@ -54,7 +54,7 @@ const transform = {
boolean: { from: Boolean, to: String },
array: {
from: val =>
- Array.isArray(val) ? val : (val && String(val).split(" ")) || [],
+ Array.isArray(val) ? val.map(String) : (val && String(val).split(" ")) || [],
to: val => val.join(" "),
},
};
|
fix(define): add strict mapping for array of strings
|
hybridsjs_hybrids
|
train
|
js
|
49eb3ca79172905bf49bab1486ecb91c593ea1d7
|
diff --git a/gitlab/const.py b/gitlab/const.py
index <HASH>..<HASH> 100644
--- a/gitlab/const.py
+++ b/gitlab/const.py
@@ -16,6 +16,7 @@
# along with this program. If not, see <http://www.gnu.org/licenses/>.
NO_ACCESS = 0
+MINIMAL_ACCESS = 5
GUEST_ACCESS = 10
REPORTER_ACCESS = 20
DEVELOPER_ACCESS = 30
|
feat: add MINIMAL_ACCESS constant
A "minimal access" access level was
[introduced](<URL>) in
GitLab <I>.
|
python-gitlab_python-gitlab
|
train
|
py
|
b855cb206ff3f76a08d55b176506fe8561e9d9f2
|
diff --git a/tests/Database/ConnectTest.php b/tests/Database/ConnectTest.php
index <HASH>..<HASH> 100644
--- a/tests/Database/ConnectTest.php
+++ b/tests/Database/ConnectTest.php
@@ -481,11 +481,9 @@ class ConnectTest extends TestCase
$connect->beginTransaction();
- $connect->
-
- table('guest_book')->
-
- insert(['name' => 'tom']); // `tom` will not rollBack
+ $connect
+ ->table('guest_book')
+ ->insert(['name' => 'tom']); // `tom` will not rollBack
$connect->beginTransaction();
$this->assertSame('SAVEPOINT trans2', $connect->lastSql()[0]);
|
fix(tests): try fix
|
hunzhiwange_framework
|
train
|
php
|
06608fbe8d7e01fba19987f7de745af62535b57b
|
diff --git a/lib/default-config.js b/lib/default-config.js
index <HASH>..<HASH> 100644
--- a/lib/default-config.js
+++ b/lib/default-config.js
@@ -544,6 +544,7 @@ module.exports = {
},
injectFileTypes: ["css", "png", "jpg", "jpeg", "svg", "gif", "webp", "map"],
+ injectNotification: false, // console | overlay
excludedFileTypes: [
"js",
"css",
|
feat: (client) added `injectNotification` option & defaulted to false
|
BrowserSync_browser-sync
|
train
|
js
|
d6881bb03cee3160c3c804e7866f606e90065978
|
diff --git a/docs/gatsby-config.js b/docs/gatsby-config.js
index <HASH>..<HASH> 100644
--- a/docs/gatsby-config.js
+++ b/docs/gatsby-config.js
@@ -42,7 +42,7 @@ module.exports = {
'deployment/heroku',
'deployment/lambda',
'deployment/now',
- 'deployment/netlify',
+ // 'deployment/netlify',
],
'API Reference': ['api/apollo-server', 'api/graphql-tools'],
Migration: [
|
docs: remove netlify to fix deployment
|
apollographql_apollo-server
|
train
|
js
|
2e6bde4fef71315df98ad41b9ca8f978652d22b8
|
diff --git a/lib/get-api.js b/lib/get-api.js
index <HASH>..<HASH> 100644
--- a/lib/get-api.js
+++ b/lib/get-api.js
@@ -4,8 +4,8 @@ module.exports = getApi
var defaultsDeep = require('lodash/defaultsDeep')
var internals = module.exports.internals = {}
-internals.Store = require('@hoodie/store/client')
-internals.Account = require('@hoodie/account/client')
+internals.Store = require('@hoodie/store-client')
+internals.Account = require('@hoodie/account-client')
internals.ConnectionStatus = require('@hoodie/connection-status/client')
internals.Log = require('@hoodie/log/client')
|
refactor: replace @hoodie/{account,store}-client with @hoodie/{account,store}
|
hoodiehq_hoodie-client
|
train
|
js
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.