hash
stringlengths 40
40
| diff
stringlengths 172
2.63k
| message
stringlengths 12
593
| project
stringlengths 7
65
| split
stringclasses 1
value | diff_languages
stringclasses 54
values |
|---|---|---|---|---|---|
3bd1a2298699ba8fcc5a824fcc8b26f3f6481bcc
|
diff --git a/src/MarkerClusterGroup.js b/src/MarkerClusterGroup.js
index <HASH>..<HASH> 100644
--- a/src/MarkerClusterGroup.js
+++ b/src/MarkerClusterGroup.js
@@ -209,6 +209,12 @@ export var MarkerClusterGroup = L.MarkerClusterGroup = L.FeatureGroup.extend({
var started = (new Date()).getTime();
var process = L.bind(function () {
var start = (new Date()).getTime();
+
+ // Make sure to unspiderfy before starting to add some layers
+ if (this._map && this._unspiderfy) {
+ this._unspiderfy();
+ }
+
for (; offset < l; offset++) {
if (chunked && offset % 200 === 0) {
// every couple hundred markers, instrument the time elapsed since processing started:
|
fix(addLayers): unspiderfy before adding Markers
to ensure the UI displays correct state.
|
Leaflet_Leaflet.markercluster
|
train
|
js
|
034fb514e4fd83a27d469a6598a5a9d38ffab245
|
diff --git a/spec/server_worker_context.rb b/spec/server_worker_context.rb
index <HASH>..<HASH> 100644
--- a/spec/server_worker_context.rb
+++ b/spec/server_worker_context.rb
@@ -165,8 +165,9 @@ module TestWorker
def run
incr_test_state :worker_run
- 5.times do
- # repeats 5 times because signal handlers
+ # This means this worker will automatically finish after 50 seconds.
+ 10.times do
+ # repeats multiple times because signal handlers
# interrupts wait
@stop_flag.wait(5.0)
end
|
test: Make TestWorker's timeout longer
Some new tests needs the longer timeout.
|
treasure-data_serverengine
|
train
|
rb
|
9fd70b51ee61b9a84839e5f333f1a8a8a3683c77
|
diff --git a/src/js/components/Anchor/StyledAnchor.js b/src/js/components/Anchor/StyledAnchor.js
index <HASH>..<HASH> 100644
--- a/src/js/components/Anchor/StyledAnchor.js
+++ b/src/js/components/Anchor/StyledAnchor.js
@@ -24,7 +24,14 @@ const sizeStyle = props => {
`;
};
-const StyledAnchor = styled.a`
+const StyledAnchor = styled.a.withConfig({
+ // prevent custom props from bleeding into DOM
+ // https://styled-components.com/docs/api#shouldforwardprop
+ shouldForwardProp: (prop, defaultValidatorFn) =>
+ !['as', 'colorProp', 'focus', 'hasIcon', 'hasLabel', 'reverse'].includes(
+ prop,
+ ) && defaultValidatorFn(prop),
+})`
box-sizing: border-box;
${props => sizeStyle(props)}
color: ${props =>
|
fix(StyledAnchor): prevent custom props from bleeding into DOM (#<I>)
* fix(styledanchor): prevent custom props from bleeding into DOM and throwing warnings in console
* fix(anchor props): add focus and reverse to array of not-allowed-to-reach-DOM props
|
grommet_grommet
|
train
|
js
|
ee54ebee9f4ac32209de751e5016ce57c8779c41
|
diff --git a/packages/svg-transform-loader/lib/loader.js b/packages/svg-transform-loader/lib/loader.js
index <HASH>..<HASH> 100644
--- a/packages/svg-transform-loader/lib/loader.js
+++ b/packages/svg-transform-loader/lib/loader.js
@@ -38,6 +38,10 @@ module.exports = function (content, map) {
transformQuery(query);
}
+ Object.keys(query).forEach(param => {
+ query[param] = decodeURIComponent(query[param]);
+ });
+
postsvg()
.use(transformPlugin(stringifyQuery(query), transformPluginCfg))
.process(content)
|
fix: decode param value before usage
|
JetBrains_svg-mixer
|
train
|
js
|
aa257e682f28a041841e4dddf3660760d9302484
|
diff --git a/lib/api.js b/lib/api.js
index <HASH>..<HASH> 100644
--- a/lib/api.js
+++ b/lib/api.js
@@ -454,7 +454,7 @@ NodeCG.Replicant = function (name, namespace, opts) {
};
/**
- * Replicants are objcts which monitor changes to a variable's value.
+ * Replicants are objects which monitor changes to a variable's value.
* The changes are replicated across all extensions, graphics, and dashboard panels.
* When a Replicant changes in one of those places it is quickly updated in the rest,
* and a `change` event is emitted allowing bundles to react to the changes in the data.
|
docs: fix typo (#<I>)
|
nodecg_nodecg
|
train
|
js
|
9a96a7e9bb58a476c1312c83192afaa2f271d61a
|
diff --git a/lib/logger.js b/lib/logger.js
index <HASH>..<HASH> 100644
--- a/lib/logger.js
+++ b/lib/logger.js
@@ -7,6 +7,7 @@
var EventEmitter = require("events").EventEmitter;
var fs = require("fs-extra");
+var os = require("os");
var path = require("path");
var tailStream = require("lei-stream").tailStream;
@@ -18,7 +19,7 @@ var _setLogPath = require("../build/Release/ons").setLogPath;
var logger = new EventEmitter();
var filenames = [];
-var _pathname = path.resolve(__dirname, "../.@ons-log-" + uuid());
+var _pathname = path.resolve(os.tmpdir(), "/.@node-ons/log-" + uuid());
_setLogPath(_pathname);
try {
|
refactor: move log file to /tmp/
|
XadillaX_aliyun-ons
|
train
|
js
|
fd156d4ba2ef04716062b6aeebda339b079865ee
|
diff --git a/scripts/report-jest-screenshots.js b/scripts/report-jest-screenshots.js
index <HASH>..<HASH> 100644
--- a/scripts/report-jest-screenshots.js
+++ b/scripts/report-jest-screenshots.js
@@ -56,10 +56,19 @@ class JestScreenshotReporter {
`/__image_snapshots__/__diff_output__/${file}`,
),
);
- uploadImage(file, imageData).then(url => {
- const urlToDisplay = `https://${url}/${file}`;
- resolve(urlToDisplay);
- });
+ if (process.env.NOW_TOKEN) {
+ uploadImage(file, imageData).then(url => {
+ const urlToDisplay = `https://${url}/${file}`;
+ resolve(urlToDisplay);
+ });
+ } else {
+ resolve(
+ `${path.join(
+ testingDir,
+ `/__image_snapshots__/__diff_output__/${file}`,
+ )}`,
+ );
+ }
});
allImagePromises.push(filePromise);
});
|
fix: update jest screenshot reporting to address missing NOW_TOKEN error thrown when doing local dev testing
|
bolt-design-system_bolt
|
train
|
js
|
8c0ec0e2a3fe603b2e50a8069bae4a2ac298cc96
|
diff --git a/example/src/components/IconPage.react.js b/example/src/components/IconPage.react.js
index <HASH>..<HASH> 100644
--- a/example/src/components/IconPage.react.js
+++ b/example/src/components/IconPage.react.js
@@ -64,9 +64,9 @@ function IconPage(): React.Node {
)}
</p>
<p>
- <code>{`<Icon prefix="${
+ <code>{`<Icon prefix="${
iconSet.prefix
- }" name="ICON_NAME"/>`}</code>
+ }" name="ICON_NAME" />`}</code>
</p>
</Grid.Col>
<Grid.Col lg={9}>
|
feat(IconPage): Formatted code examples did not render ≶ and > correctly
|
tabler_tabler-react
|
train
|
js
|
6bb54b4ab29bab58f20ac614fc96f56071e14c7b
|
diff --git a/lib/BaseWidget.js b/lib/BaseWidget.js
index <HASH>..<HASH> 100644
--- a/lib/BaseWidget.js
+++ b/lib/BaseWidget.js
@@ -9,7 +9,7 @@ var baseWidgetOpts = require('./opts');
function BaseWidget (opts) {
var self = this;
- if (!(self instanceof BaseWidget)) return new BaseWidget(opts);
+ if (!(self instanceof blessed.Node)) return new BaseWidget(opts);
opts = _(baseWidgetOpts).merge(opts || {}).toObject();
if (!opts.screen) opts.screen = (opts.parent || {}).screen;
@@ -87,7 +87,7 @@ BaseWidget.prototype.getBindings = function () {
return this.options.bindings;
};
BaseWidget.prototype.resolveBinding = function (key, source1, source2, etc) {
- return BaseWidget.resolveBinding.apply(null,
+ return BaseWidget.resolveBinding.apply(this,
[key, util.callBase(this, BaseWidget, 'getBindings')].concat([].slice.call(arguments, 1))
);
};
|
fix(init): constructor instanceof checks for blessed.Node instead of BaseWidget for mixin-style calls
|
slap-editor_base-widget
|
train
|
js
|
7508028398d366c37d1a14e254baec9dc39b816c
|
diff --git a/src/LintDirtyModulesPlugin.js b/src/LintDirtyModulesPlugin.js
index <HASH>..<HASH> 100644
--- a/src/LintDirtyModulesPlugin.js
+++ b/src/LintDirtyModulesPlugin.js
@@ -53,7 +53,7 @@ export default class LintDirtyModulesPlugin {
for (const [filename, timestamp] of fileTimestamps.entries()) {
if (hasFileChanged(filename, timestamp) && isMatch(filename, glob)) {
- changedFiles.push(filename);
+ changedFiles.push(filename.replace(/\\/g, '/'));
}
}
|
fix: replace back slashes on changed files (#<I>)
|
webpack-contrib_stylelint-webpack-plugin
|
train
|
js
|
10298e90345da0f9253652a81be34bcb0d67ff53
|
diff --git a/filesystem_test.go b/filesystem_test.go
index <HASH>..<HASH> 100644
--- a/filesystem_test.go
+++ b/filesystem_test.go
@@ -34,6 +34,9 @@ type User struct {
}
func init() {
+ if err := db.DropTableIfExists(&User{}).Error; err != nil {
+ panic(err)
+ }
db.AutoMigrate(&User{})
media_library.RegisterCallbacks(db)
}
|
test: remove user table before auto migrate
|
qor_media
|
train
|
go
|
da294c4d224ad203edd897f9c9b0943bf32a74f6
|
diff --git a/src/authService.js b/src/authService.js
index <HASH>..<HASH> 100644
--- a/src/authService.js
+++ b/src/authService.js
@@ -437,7 +437,7 @@ export class AuthService {
*
* @return {Promise<Object>|Promise<Error>} Server response as Object
*/
- login(emailOrCredentials: string|{}, passwordOrOptions?: string, optionsOrRedirectUri?: {}, redirectUri?: string): Promise<any> {
+ login(emailOrCredentials: string|{}, passwordOrOptions?: string|{}, optionsOrRedirectUri?: {}, redirectUri?: string): Promise<any> {
let normalized = {};
if (typeof emailOrCredentials === 'object') {
|
fix(authService): allow object passed as second arg to authService.login()
modified the type of the second argument to allow string or object as the first argument to the login function does
|
SpoonX_aurelia-authentication
|
train
|
js
|
32316e4c55044d175c230600d9c2669f90bb21c6
|
diff --git a/lib/core/connection/pool.js b/lib/core/connection/pool.js
index <HASH>..<HASH> 100644
--- a/lib/core/connection/pool.js
+++ b/lib/core/connection/pool.js
@@ -720,6 +720,14 @@ Pool.prototype.destroy = function(force, callback) {
* @param {function} [callback]
*/
Pool.prototype.reset = function(callback) {
+ if (this.s.state !== CONNECTED) {
+ if (typeof callback === 'function') {
+ callback(new MongoError('pool is not connected, reset aborted'));
+ }
+
+ return;
+ }
+
const connections = this.availableConnections.concat(this.inUseConnections);
eachAsync(
connections,
@@ -739,6 +747,9 @@ Pool.prototype.reset = function(callback) {
}
resetPoolState(this);
+
+ // attempt reexecution
+ process.nextTick(() => _execute(this)());
if (typeof callback === 'function') {
callback(null, null);
}
|
fix(pool): don't reset a pool if we'not already connected
|
mongodb_node-mongodb-native
|
train
|
js
|
10fb24ced9c52de5013775b7a6583b0cdb198c7f
|
diff --git a/src/Generators/ModelGenerator.php b/src/Generators/ModelGenerator.php
index <HASH>..<HASH> 100755
--- a/src/Generators/ModelGenerator.php
+++ b/src/Generators/ModelGenerator.php
@@ -287,8 +287,8 @@ class ModelGenerator extends BaseGenerator
case 'boolean':
$rule .= "'boolean'";
break;
- case 'dateTime':
- case 'dateTimeTz':
+ case 'datetime':
+ case 'datetimetz':
$rule .= "'datetime'";
break;
case 'date':
diff --git a/src/Generators/SwaggerGenerator.php b/src/Generators/SwaggerGenerator.php
index <HASH>..<HASH> 100755
--- a/src/Generators/SwaggerGenerator.php
+++ b/src/Generators/SwaggerGenerator.php
@@ -91,7 +91,7 @@ class SwaggerGenerator
$fieldType = 'string';
$fieldFormat = 'date';
break;
- case 'dateTime':
+ case 'datetime':
case 'timestamp':
$fieldType = 'string';
$fieldFormat = 'date-time';
|
fix(swagger): #<I> minor swagger fix of date-time fields (#<I>)
|
InfyOmLabs_laravel-generator
|
train
|
php,php
|
c79542fa5a1dec2695011e008813954889bf80dc
|
diff --git a/test/integration-test.py b/test/integration-test.py
index <HASH>..<HASH> 100644
--- a/test/integration-test.py
+++ b/test/integration-test.py
@@ -335,6 +335,7 @@ def check_slow_queries():
AND user_host NOT LIKE "mailer%"
AND user_host NOT LIKE "janitor%"
AND sql_text NOT LIKE 'SELECT status, expires FROM authz2 WHERE id IN %'
+ AND sql_text NOT LIKE '%LEFT JOIN orderToAuthz2 %'
\G
"""
output = subprocess.check_output(
|
test: Add exclusion for GetValidOrderAuthorizations2 slow query. (#<I>)
This was causing intermittent failures.
|
letsencrypt_boulder
|
train
|
py
|
314eb19570c7d867d845fe8a34bdd0619ae649bf
|
diff --git a/eventstore.go b/eventstore.go
index <HASH>..<HASH> 100644
--- a/eventstore.go
+++ b/eventstore.go
@@ -19,7 +19,7 @@ import (
)
// Error returned when no events are found.
-var ErrNotEventsFound = errors.New("could not find events")
+var ErrNoEventsFound = errors.New("could not find events")
// Error returned if no event store has been defined.
var NoEventStoreDefinedError = errors.New("no event store defined")
@@ -59,14 +59,14 @@ func (s *MemoryEventStore) Append(events []Event) {
}
// Load loads all events for the aggregate id from the memory store.
-// Returns ErrNotEventsFound if no events can be found.
+// Returns ErrNoEventsFound if no events can be found.
func (s *MemoryEventStore) Load(id UUID) ([]Event, error) {
if events, ok := s.events[id]; ok {
// log.Printf("event store: loaded %#v", events)
return events, nil
}
- return nil, ErrNotEventsFound
+ return nil, ErrNoEventsFound
}
// TraceEventStore wraps an EventStore and adds debug tracing.
|
fix(typo): ErrNotEventsFound => ErrNoEventsFound
Discussed this with @maxpersson in #8.
|
looplab_eventhorizon
|
train
|
go
|
155c2216aa25407de659b8625fdccac35962b1e4
|
diff --git a/lib/util/parse-req.js b/lib/util/parse-req.js
index <HASH>..<HASH> 100644
--- a/lib/util/parse-req.js
+++ b/lib/util/parse-req.js
@@ -103,7 +103,7 @@ module.exports = function parseReq(socket, callback, readBuffer, neadModifyHeade
var rawHeaders = buffer.slice(0, endIndex).toString().trim().split(/\r\n/g);
var firstLine = rawHeaders.shift();
var status = firstLine.split(/\s/g);
- rawHeaders = parsePairs(headers, rawHeaders);
+ rawHeaders = socket.rawHeaders = parsePairs(headers, rawHeaders);
req.method = status[0] = status[0] || 'GET';
req.url = status[1] || '/';
|
refactor: Keep the original head name
|
avwo_whistle
|
train
|
js
|
0dae2fbd63c11fdcbb4a656558521ddfc0bfb84f
|
diff --git a/src/foremast/s3/s3apps.py b/src/foremast/s3/s3apps.py
index <HASH>..<HASH> 100644
--- a/src/foremast/s3/s3apps.py
+++ b/src/foremast/s3/s3apps.py
@@ -46,7 +46,7 @@ class S3Apps(object):
self.generated = get_details(app=app, env=env)
self.properties = get_properties(prop_path)
self.s3props = self.properties[self.env]['s3']
- self.group = self.generated.project()
+ self.group = self.generated.project
if self.s3props.get('shared_bucket_master'):
self.bucket = self.generated.shared_s3_app_bucket()
@@ -122,7 +122,8 @@ class S3Apps(object):
{'Key': 'app_group',
'Value': self.group},
]}
- self.s3client.put_bucket_tagging(Bucket='string', Tagging=tagset)
+ self.s3client.put_bucket_tagging(Bucket=self.bucket, Tagging=tagset)
+ LOG.info("Adding tagging %s for Bucket", tagset)
def _bucket_exists(self):
"""Checks if the bucket exists"""
|
fix: bucket name, logging, access group as property
|
foremast_foremast
|
train
|
py
|
eb3e70d3a4204441a6b0050102d169a6a2eb39e0
|
diff --git a/packages/sketch/src/commands/icons/shared.js b/packages/sketch/src/commands/icons/shared.js
index <HASH>..<HASH> 100644
--- a/packages/sketch/src/commands/icons/shared.js
+++ b/packages/sketch/src/commands/icons/shared.js
@@ -117,8 +117,6 @@ function createSVGArtboards(
symbolName = `${icon.category} / ${icon.subcategory} / ${symbolName}`;
}
- symbolName = `icon / ${symbolName}`;
-
const artboard = new Artboard({
name: symbolName,
frame: new Rectangle(X_OFFSET, Y_OFFSET, size, size),
|
fix(sketch): match symbol names to existing format (#<I>)
|
carbon-design-system_carbon-components
|
train
|
js
|
89ba62e46fb80317c0ea0f1fbae061b261b44973
|
diff --git a/packages/tessellate-fragment/src/routes/fragment.js b/packages/tessellate-fragment/src/routes/fragment.js
index <HASH>..<HASH> 100644
--- a/packages/tessellate-fragment/src/routes/fragment.js
+++ b/packages/tessellate-fragment/src/routes/fragment.js
@@ -10,10 +10,14 @@ import type Route from '.';
export function fragment(router: Router): Route {
return router.get('fragment', '/fragment', async ctx => {
const { headers, query } = ctx.request;
+
const sources = await resolveSources(headers, query);
- const { bundle, props } = await dispatch(FETCH_BUNDLE, { sources, headers });
- const content = await dispatch(FETCH_CONTENT, { sources });
+ const [{ bundle, props }, content] = await Promise.all([
+ dispatch(FETCH_BUNDLE, { sources, headers }),
+ dispatch(FETCH_CONTENT, { sources })
+ ]);
+
props.content = content;
const { html } = await dispatch(RENDER_BUNDLE, { bundle, props });
|
perf(fragment): parallelized content and bundle HTTP requests
affects: tessellate-fragment
Fetch bundle and content in parallel, they have no dependencies to each other.
ISSUES CLOSED: #<I>
|
zalando-incubator_tessellate
|
train
|
js
|
ca03baf326b333c6518ac852b776d491f7da8e1e
|
diff --git a/packages/build-tools/create-webpack-config.js b/packages/build-tools/create-webpack-config.js
index <HASH>..<HASH> 100644
--- a/packages/build-tools/create-webpack-config.js
+++ b/packages/build-tools/create-webpack-config.js
@@ -457,12 +457,15 @@ async function createWebpackConfig(buildConfig) {
canPrint: config.verbosity > 2,
cssProcessor: require('cssnano'),
cssProcessorPluginOptions: {
- preset: ['default', {
- discardComments: { removeAll: true } ,
- mergeLonghand: false, // don't merge longhand values -- required for CSS Vars theming, etc.
- zindex: false, // don't alter `z-index` values
- mergeRules: false, // this MUST be disabled - otherwise certain selectors (ex. ::slotted(*), which IE 11 can't parse) break
- }],
+ preset: [
+ 'default',
+ {
+ discardComments: { removeAll: true },
+ mergeLonghand: false, // don't merge longhand values -- required for CSS Vars theming, etc.
+ zindex: false, // don't alter `z-index` values
+ mergeRules: false, // this MUST be disabled - otherwise certain selectors (ex. ::slotted(*), which IE 11 can't parse) break
+ },
+ ],
},
}),
);
|
fix: fix eslint issues in webpack config
|
bolt-design-system_bolt
|
train
|
js
|
58cbac6ed86b2d301be05915ba29f9f4c57e9e2a
|
diff --git a/index.js b/index.js
index <HASH>..<HASH> 100644
--- a/index.js
+++ b/index.js
@@ -70,7 +70,7 @@ require('./lib/rollbar')
const queueKeys = Object.keys(queues)
statsd.gauge('queues.account-jobs', queueKeys.length)
queueKeys.map((queueId) => {
- statsd.gauge('queues.account-jobs-by-job', queues[queueId].length || 0, { tag: queueId })
+ statsd.gauge('queues.account-jobs-by-job', queues[queueId].getQueueLength() || 0, { tag: queueId })
})
}, 20000)
}
|
fix(statsd): getQueueLength of the queue
|
greenkeeperio_greenkeeper
|
train
|
js
|
c9bf3bfcd6f89eb4d7adcf55bb5032374f294809
|
diff --git a/packages/node_modules/cerebral/src/utils.js b/packages/node_modules/cerebral/src/utils.js
index <HASH>..<HASH> 100644
--- a/packages/node_modules/cerebral/src/utils.js
+++ b/packages/node_modules/cerebral/src/utils.js
@@ -278,7 +278,7 @@ export function createDummyController(state = {}, signals = {}) {
export function getStateTreeProp(props = {}) {
return Object.keys(props).reduce((prop, key) => {
- if (prop || (isComplexObject(props[key]) && Object.isFrozen(props[key]))) {
+ if (!prop && isComplexObject(props[key]) && Object.isFrozen(props[key])) {
return key
}
|
fix(Views): fix warning prop on state passed as prop (#<I>)
|
cerebral_cerebral
|
train
|
js
|
fb72d92c9ba23a5f41ddf7cd9850efd94fecee9d
|
diff --git a/src/commands/init/init.js b/src/commands/init/init.js
index <HASH>..<HASH> 100644
--- a/src/commands/init/init.js
+++ b/src/commands/init/init.js
@@ -57,7 +57,7 @@ const logGitSetupInstructionsAndExit = () => {
${chalk.cyanBright.bold('git init')}
-2. Commit your files
+2. Add your files
${chalk.cyanBright.bold('git add .')}
|
chore: correct step 2 of git setup instructions (#<I>)
* Correct step 2 of git setup instructions
* chore: update contributors field
* chore: update contributors field
|
netlify_cli
|
train
|
js
|
b0d8841bacd9c0cdc5192647529b7df134361524
|
diff --git a/src/Commands/New.js b/src/Commands/New.js
index <HASH>..<HASH> 100644
--- a/src/Commands/New.js
+++ b/src/Commands/New.js
@@ -114,7 +114,7 @@ get signature () {
*/
* _verifyApplicationDoesntExist () {
try {
- yield pify(fs.access)(this.applicationPath, fs.constants.F_OK)
+ yield pify(fs.access)(this.applicationPath, (fs.constants || fs).F_OK)
this.error(`${this.icon('error')} The directory "${this.applicationName}" already exists!`)
process.exit(0)
} catch (e) {
|
fix(fs): fs.constants is undefined across versions
certain versions of node.js has fs.constants set as undefined
whereas some has fs.constants as an object. Long live Node.js
|
adonisjs_adonis-cli
|
train
|
js
|
583f396e85f9d8f0e4fad6529c1b5d18105df9d0
|
diff --git a/master/buildbot/test/fake/latent.py b/master/buildbot/test/fake/latent.py
index <HASH>..<HASH> 100644
--- a/master/buildbot/test/fake/latent.py
+++ b/master/buildbot/test/fake/latent.py
@@ -42,6 +42,12 @@ class LatentController(object):
self.starting = False
self.stopping = False
self.auto_stop_flag = False
+ self.auto_start_flag = False
+
+ def auto_start(self, result):
+ self.auto_start_flag = result
+ if self.auto_start_flag and self.starting:
+ self.start_instance(True)
def start_instance(self, result):
assert self.starting
@@ -98,10 +104,16 @@ class ControllableLatentWorker(AbstractLatentWorker):
assert not self._controller.stopping
self._controller.starting = True
+ if self._controller.auto_start_flag:
+ self._controller.starting = False
+ return defer.succeed(True)
+
self._controller._start_deferred = defer.Deferred()
return self._controller._start_deferred
def stop_instance(self, build):
+ assert not self._controller.stopping
+
self._controller.stopping = True
if self._controller.auto_stop_flag:
self._controller.stopping = False
|
test: Support auto starting fake latent workers
|
buildbot_buildbot
|
train
|
py
|
af2e8fff6cdef7ef1c0bda35873f782837307dd6
|
diff --git a/scripts/find-cycles.py b/scripts/find-cycles.py
index <HASH>..<HASH> 100644
--- a/scripts/find-cycles.py
+++ b/scripts/find-cycles.py
@@ -3,44 +3,44 @@ import json
import sys
import collections
import pprint
-
+
def find(xs, x):
for i, value in enumerate(xs):
if x == value:
return i
return None
-
+
filenames = sys.argv[1:]
-
+
graph = collections.defaultdict(set)
for filename in filenames:
- with file(filename) as f:
+ with open(filename) as f:
package_json = json.load(f)
-
+
for key in ['devDependencies', 'dependencies']:
if key in package_json:
graph[package_json['name']].update(package_json[key].keys())
-
-
+
+
checked = set()
-
+
# Do a check for cycles for each package. This is slow but it works,
# and it has the advantage that it can give good diagnostics.
def check_for_cycles(package, path):
i = find(path, package)
if i is not None:
cycle = path[i:] + [package]
- print 'Cycle: %s' % ' => '.join(cycle)
+ print('Cycle: %s' % ' => '.join(cycle))
return
-
+
if package in checked:
return
-
+
checked.add(package)
-
+
deps = graph.get(package, [])
for dep in deps:
check_for_cycles(dep, path + [package])
-
+
for package in graph.keys():
check_for_cycles(package, [])
|
chore: update find-cycles to work with Python 2 or 3 (#<I>)
I ran into a cycle issue and tried to use find-cycles to diagnose it; unfortunately, it wasn't Python 3-compatible. A quick update makes it work for either Python 2 or 3.
Apologies for the extra noise -- I've got my editor to automatically delete trailing whitespace.
----
*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-<I> license*
|
awslabs_aws-cdk
|
train
|
py
|
9ccd67190cba3867ba0f6150c5545d757ea2f27e
|
diff --git a/tests/test_metamodel.py b/tests/test_metamodel.py
index <HASH>..<HASH> 100644
--- a/tests/test_metamodel.py
+++ b/tests/test_metamodel.py
@@ -264,14 +264,14 @@ class TestDefineModel(unittest.TestCase):
def testOneToMany(self):
self.metamodel.define_class('A', [('Id', 'unique_id')])
self.metamodel.define_class('B', [('Id', 'unique_id'), ('A_Id', 'unique_id')])
- a_endpint = xtuml.SingleAssociationLink('A')
- b_endpint = xtuml.ManyAssociationLink('B')
+ a_endpint = xtuml.SingleAssociationLink('A', ids=['Id'])
+ b_endpint = xtuml.ManyAssociationLink('B', ids=['A_Id'])
self.metamodel.define_relation('R1', a_endpint, b_endpint)
a = self.metamodel.new('A')
b = self.metamodel.new('B')
- xtuml.relate(a, b, 1)
+ self.assertTrue(xtuml.relate(a, b, 1))
self.assertEqual(a, xtuml.navigate_one(b).A[1]())
|
test: fixed broken testOneToMany test case
|
xtuml_pyxtuml
|
train
|
py
|
9aea72b0811a1e98adf51522561c7598370fbb8d
|
diff --git a/packages/utils/index.js b/packages/utils/index.js
index <HASH>..<HASH> 100644
--- a/packages/utils/index.js
+++ b/packages/utils/index.js
@@ -1,14 +1,14 @@
-const didSetup = new Set;
+const PLUGIN_NAME = 'ember-decorators-debug-macros';
function setupBabelPlugins(addon, options) {
- if (didSetup.has(addon)) return;
- didSetup.add(addon);
-
addon.options = addon.options || {};
addon.options.babel = addon.options.babel || {};
let plugins = addon.options.babel.plugins = addon.options.babel.plugins || [];
+ // If the plugin is already configure, skip.
+ if (plugins.some(p => Array.isArray(p) && p[2] === PLUGIN_NAME)) return;
+
let shouldThrowOnComputedOverride
if (process.env.EMBER_DECORATORS_THROW_ON_COMPUTED_OVERRIDE) {
@@ -48,7 +48,7 @@ function setupBabelPlugins(addon, options) {
plugins.push([
require.resolve('babel-plugin-debug-macros'),
pluginOptions,
- 'ember-decorators-debug-macros'
+ PLUGIN_NAME
]);
}
|
fix(utils): only install debug-macros plugin once (#<I>)
|
ember-decorators_ember-decorators
|
train
|
js
|
09e7a22000d74bc2afc8e9fc98ca1bcefb178b0d
|
diff --git a/packages/metascraper-media-provider/test/index.js b/packages/metascraper-media-provider/test/index.js
index <HASH>..<HASH> 100644
--- a/packages/metascraper-media-provider/test/index.js
+++ b/packages/metascraper-media-provider/test/index.js
@@ -71,6 +71,7 @@ describe('metascraper-media-provider', () => {
;(isCI ? describe.skip : describe)('vimeo', () => {
;[
'https://vimeo.com/channels/staffpicks/287117046',
+ 'https://vimeo.com/showcase/3717822',
'https://vimeo.com/186386161'
].forEach(url => {
it(url, async () => {
|
test: add vimeo URLs for testing
|
microlinkhq_metascraper
|
train
|
js
|
e539de547c302427c56ca84e7550c8d07a37cd82
|
diff --git a/karma.browsers.js b/karma.browsers.js
index <HASH>..<HASH> 100644
--- a/karma.browsers.js
+++ b/karma.browsers.js
@@ -46,7 +46,7 @@ const browsers = {
safari_latest: {
browserName: 'safari',
platform: 'OS X 10.11',
- version: '9',
+ version: 'latest'
},
// IE
|
fix: test in safari latest (not pinned, which was a workaround for sauce labs for awhile)
|
skatejs_build
|
train
|
js
|
aef63d2fcbb15ca641e77f1d881a1b091747c1e2
|
diff --git a/internal/pipe/brew/brew.go b/internal/pipe/brew/brew.go
index <HASH>..<HASH> 100644
--- a/internal/pipe/brew/brew.go
+++ b/internal/pipe/brew/brew.go
@@ -5,6 +5,7 @@ import (
"errors"
"fmt"
"io/ioutil"
+ "path"
"path/filepath"
"strings"
"text/template"
@@ -141,10 +142,7 @@ func doRun(ctx *context.Context, client client.Client) error {
}
func ghFormulaPath(folder, filename string) string {
- if folder == "" {
- return filename
- }
- return folder + "/" + filename
+ return path.Join(folder, filename)
}
func getFormat(ctx *context.Context) string {
|
chore: brew: better join impl
|
goreleaser_goreleaser
|
train
|
go
|
810a1749e0bf0d51c77abbc96827a2f95a8ce5b4
|
diff --git a/plugin/plugins/peerlog/peerlog.go b/plugin/plugins/peerlog/peerlog.go
index <HASH>..<HASH> 100644
--- a/plugin/plugins/peerlog/peerlog.go
+++ b/plugin/plugins/peerlog/peerlog.go
@@ -36,7 +36,7 @@ type plEvent struct {
peer peer.ID
}
-// Log all the PeerIDs we see
+// Log all the PeerIDs. This is considered internal, unsupported, and may break at any point.
//
// Usage:
// GOLOG_FILE=~/peer.log IPFS_LOGGING_FMT=json ipfs daemon
@@ -67,6 +67,11 @@ func (*peerLogPlugin) Version() string {
return "0.1.0"
}
+// extractEnabled extracts the "Enabled" field from the plugin config.
+// Do not follow this as a precedent, this is only applicable to this plugin,
+// since it is internal-only, unsupported functionality.
+// For supported functionality, we should rework the plugin API to support this use case
+// of including plugins that are disabled by default.
func extractEnabled(config interface{}) bool {
// plugin is disabled by default, unless Enabled=true
if config == nil {
|
chore: add comments to peerlog plugin about being unsupported
and also about the ugly config semantics
(cherry picked from commit ae<I>e<I>d<I>abdb<I>e<I>b<I>)
|
ipfs_go-ipfs
|
train
|
go
|
88030a8998cbc524d5a390288f5d54cd4b357fe2
|
diff --git a/src/Components/Pest/Installer.php b/src/Components/Pest/Installer.php
index <HASH>..<HASH> 100644
--- a/src/Components/Pest/Installer.php
+++ b/src/Components/Pest/Installer.php
@@ -27,7 +27,7 @@ final class Installer extends AbstractInstaller
/** {@inheritdoc} */
public function install(): void
{
- $this->remove('phpunit/phpunit');
- $this->require('pestphp/pest');
+ $this->remove('phpunit/phpunit', true);
+ $this->require('pestphp/pest', true);
}
}
diff --git a/tests/Components/PestComponentTest.php b/tests/Components/PestComponentTest.php
index <HASH>..<HASH> 100644
--- a/tests/Components/PestComponentTest.php
+++ b/tests/Components/PestComponentTest.php
@@ -10,11 +10,11 @@ it('installs the required packages', function () {
$composerMock->expects($this->once())
->method('remove')
- ->with('phpunit/phpunit');
+ ->with('phpunit/phpunit', true);
$composerMock->expects($this->once())
->method('require')
- ->with('pestphp/pest');
+ ->with('pestphp/pest', true);
$this->app->instance(ComposerContract::class, $composerMock);
|
fix: install Pest as dev dependency
|
laravel-zero_framework
|
train
|
php,php
|
fe1b6960060880a0fabc423cf8e29b33702046fd
|
diff --git a/tests/integration/index.php b/tests/integration/index.php
index <HASH>..<HASH> 100644
--- a/tests/integration/index.php
+++ b/tests/integration/index.php
@@ -13,8 +13,8 @@ if (!empty($argv[1])) {
}
$config = new Config();
-$config->routeStorageData = require dirname(__DIR__) . '/_data/RouteStorageData.php';
-$config->widgetsStorageData = require dirname(__DIR__) . '/_data/WidgetsStorageData.php';
+$config->routeStorageData = require dirname(__DIR__) . '/_data/routes.php';
+$config->widgetsStorageData = require dirname(__DIR__) . '/_data/widgets.php';
$config->templatesPath = '/tests/integration/templates';
$config->templatesDefault = '';
$debug = new Debug();
|
fix: intergation tests with last changes
|
enikeishik_ufoframework
|
train
|
php
|
a7fa23eea07f9e17615405a7528047d1ad0ef368
|
diff --git a/lib/index.js b/lib/index.js
index <HASH>..<HASH> 100644
--- a/lib/index.js
+++ b/lib/index.js
@@ -102,6 +102,12 @@ export default {
return helpers
.exec(this.pathToFlow, args, options)
+ .catch((error: String) => {
+ if (error.indexOf('Launching Flow server') !== -1) {
+ return helpers.exec(this.pathToFlow, args, options);
+ }
+ return '{}';
+ })
.then((str: string) => str.slice(str.indexOf('{')))
.then(JSON.parse)
.then(handleData);
|
fix(tests): fix initial check when flow server is starting up.
|
AtomLinter_linter-flow
|
train
|
js
|
5d8a8cb5cb2600e0ae55270350e1484f72a5c0bc
|
diff --git a/src/GDS/Gateway/ProtoBuf.php b/src/GDS/Gateway/ProtoBuf.php
index <HASH>..<HASH> 100644
--- a/src/GDS/Gateway/ProtoBuf.php
+++ b/src/GDS/Gateway/ProtoBuf.php
@@ -67,7 +67,9 @@ class ProtoBuf extends \GDS\Gateway
if(null === $str_dataset) {
if(isset($_SERVER['APPLICATION_ID'])) {
$this->str_dataset_id = $_SERVER['APPLICATION_ID'];
- } else {
+ } elseif (isset($_SERVER['GAE_APPLICATION'])) {
+ $this->str_dataset_id = $_SERVER['GAE_APPLICATION'];
+ } else {
throw new \Exception('Could not determine DATASET, please pass to ' . get_class($this) . '::__construct()');
}
} else {
|
fix: use GAE_APPLICATION env var in ProtoBuf gateway
In App Engine PHP 7 runtimes, GAE_APPLICATION is the Google Cloud project ID [0] and the APPLICATION_ID env var is no longer set.
[0] <URL>
|
tomwalder_php-gds
|
train
|
php
|
3710b7e8bb51cf723d4ce36ef4c6d895d7a20387
|
diff --git a/google-cloud-firestore/lib/google/cloud/firestore/convert.rb b/google-cloud-firestore/lib/google/cloud/firestore/convert.rb
index <HASH>..<HASH> 100644
--- a/google-cloud-firestore/lib/google/cloud/firestore/convert.rb
+++ b/google-cloud-firestore/lib/google/cloud/firestore/convert.rb
@@ -50,9 +50,12 @@ module Google
end
def fields_to_hash fields, client
- fields.to_h do |key, value|
- [key.to_sym, value_to_raw(value, client)]
- end
+ # Google::Protobuf::Map#to_h ignores the given block, unlike Hash#to_h
+ # rubocop:disable Style/MapToHash
+ fields
+ .map { |key, value| [key.to_sym, value_to_raw(value, client)] }
+ .to_h
+ # rubocop:enable Style/MapToHash
end
def hash_to_fields hash
|
fix(firestore): Fix a regression in fields conversion (#<I>)
|
googleapis_google-cloud-ruby
|
train
|
rb
|
7f87ef83e4234117e95479ee510fdbbe1852940a
|
diff --git a/p2p/transport/websocket/conn.go b/p2p/transport/websocket/conn.go
index <HASH>..<HASH> 100644
--- a/p2p/transport/websocket/conn.go
+++ b/p2p/transport/websocket/conn.go
@@ -84,7 +84,11 @@ func (c *Conn) Write(b []byte) (n int, err error) {
func (c *Conn) Close() error {
var err error
c.closeOnce.Do(func() {
- err1 := c.Conn.WriteControl(ws.CloseMessage, nil, time.Now().Add(GracefulCloseTimeout))
+ err1 := c.Conn.WriteControl(
+ ws.CloseMessage,
+ ws.FormatCloseMessage(ws.CloseNormalClosure, "closed"),
+ time.Now().Add(GracefulCloseTimeout),
+ )
err2 := c.Conn.Close()
switch {
case err1 != nil:
|
fix: close gracefully
If we send no message, the client gets a <I>. This will send a <I>.
|
libp2p_go-libp2p
|
train
|
go
|
25027d6df883a51dac6398d0c9d17b8b665610a0
|
diff --git a/pkg/middlewares/retry/retry.go b/pkg/middlewares/retry/retry.go
index <HASH>..<HASH> 100644
--- a/pkg/middlewares/retry/retry.go
+++ b/pkg/middlewares/retry/retry.go
@@ -16,7 +16,6 @@ import (
"github.com/traefik/traefik/v2/pkg/config/dynamic"
"github.com/traefik/traefik/v2/pkg/log"
"github.com/traefik/traefik/v2/pkg/middlewares"
- "github.com/traefik/traefik/v2/pkg/safe"
"github.com/traefik/traefik/v2/pkg/tracing"
)
@@ -118,7 +117,7 @@ func (r *retry) ServeHTTP(rw http.ResponseWriter, req *http.Request) {
r.listener.Retried(req, attempts)
}
- err := backoff.RetryNotify(safe.OperationWithRecover(operation), backOff, notify)
+ err := backoff.RetryNotify(operation, backOff, notify)
if err != nil {
log.FromContext(middlewares.GetLoggerCtx(req.Context(), r.name, typeName)).
Debugf("Final retry attempt failed: %v", err.Error())
|
fix: don't retry on panic
|
containous_traefik
|
train
|
go
|
f7eb5668eb56f1767a509c76806ed9214834f3f6
|
diff --git a/core/utils.js b/core/utils.js
index <HASH>..<HASH> 100644
--- a/core/utils.js
+++ b/core/utils.js
@@ -221,8 +221,17 @@
// run the callback
callback(result);
};
- // string adds to stop the command tag being detected in the output
- Espruino.Core.Serial.write('\x03echo(0);\nconsole.log("<<"+"<<<"+JSON.stringify('+expressionToExecute+')+">>>"+">>");\n');
+
+ // Ensure that we have some chars on input line so that next Ctrl-C
+ // character will clear the line and will not cause interrupt
+ Espruino.Core.Serial.write('O_o');
+ // Write main expression after small delay to ensure that 'O_o'
+ // was already read by the board.
+ setTimeout(function() {
+ // string adds to stop the command tag being detected in the output
+ Espruino.Core.Serial.write('\x03echo(0);\nconsole.log("<<"+"<<<"+JSON.stringify('+expressionToExecute+')+">>>"+">>");\n');
+ }, 20);
+
//
var timeout = setTimeout(function(){
console.warn("No result found - just got "+JSON.stringify(receivedData));
|
fix: ensure \x<I> char clears the line, not interrupts for executeExpression(..)
|
espruino_EspruinoTools
|
train
|
js
|
80ac9b91374f3b22aa91f4a6cba418e75263a620
|
diff --git a/src/js/core/drop.js b/src/js/core/drop.js
index <HASH>..<HASH> 100644
--- a/src/js/core/drop.js
+++ b/src/js/core/drop.js
@@ -251,7 +251,7 @@ export default {
}
}),
- ...(this.display === 'static'
+ ...(this.display === 'static' && this.align !== 'stretch'
? []
: (() => {
const handler = () => this.$emit();
|
fix: observe resize for drop component with 'stretch' alignment
|
uikit_uikit
|
train
|
js
|
4e8579c400e8b0850f9816663650fa4c45c9484e
|
diff --git a/packages/collector/test/tracing/messaging/kafkajs/test.js b/packages/collector/test/tracing/messaging/kafkajs/test.js
index <HASH>..<HASH> 100644
--- a/packages/collector/test/tracing/messaging/kafkajs/test.js
+++ b/packages/collector/test/tracing/messaging/kafkajs/test.js
@@ -7,7 +7,6 @@
const path = require('path');
const expect = require('chai').expect;
-const semver = require('semver');
const constants = require('@instana/core').tracing.constants;
const supportedVersion = require('@instana/core').tracing.supportedVersion;
@@ -22,12 +21,7 @@ const {
const ProcessControls = require('../../../test_util/ProcessControls');
const globalAgent = require('../../../globalAgent');
-const mochaSuiteFn =
- supportedVersion(process.versions.node) &&
- // The latest kafkajs version requires Node.js 10.
- semver.gte(process.versions.node, '10.0.0')
- ? describe
- : describe.skip;
+const mochaSuiteFn = supportedVersion(process.versions.node) ? describe : describe.skip;
mochaSuiteFn('tracing/kafkajs', function () {
this.timeout(config.getTestTimeout() * 2);
|
chore: removed node version check in collector/test/tracing/messaging/kafkajs/test.js
refs <I>
|
instana_nodejs-sensor
|
train
|
js
|
970a503c561a0cdb30a7b1ce2ed8d34b1728e61f
|
diff --git a/workflow/util/util.go b/workflow/util/util.go
index <HASH>..<HASH> 100644
--- a/workflow/util/util.go
+++ b/workflow/util/util.go
@@ -227,6 +227,9 @@ func PopulateSubmitOpts(command *cobra.Command, submitOpts *wfv1.SubmitOpts, inc
// Apply the Submit options into workflow object
func ApplySubmitOpts(wf *wfv1.Workflow, opts *wfv1.SubmitOpts) error {
+ if wf == nil {
+ return fmt.Errorf("workflow cannot be nil")
+ }
if opts == nil {
opts = &wfv1.SubmitOpts{}
}
|
fix: nil-pointer in util.ApplySubmitOpts (#<I>)
|
argoproj_argo
|
train
|
go
|
c104ea2f95123918ffb24dc6c6441e4e198d6725
|
diff --git a/src/build-resources.js b/src/build-resources.js
index <HASH>..<HASH> 100644
--- a/src/build-resources.js
+++ b/src/build-resources.js
@@ -85,10 +85,10 @@ function ensurePathHasExtension(fullPath) {
try { stats = fileSystem.statSync(fullPathTest) } catch (_) {}
- if (!stats)
+ if (!stats || stats.isDirectory())
try { stats = fileSystem.statSync(fullPathTest = fullPath + '.js') } catch (_) {}
- if (!stats)
+ if (!stats || stats.isDirectory())
try { stats = fileSystem.statSync(fullPathTest = fullPath + '.ts') } catch (_) {}
if (stats && stats.isFile()) {
|
fix(build-resources): allow sibling directories of the same name as modules
fixes #<I>
|
aurelia_webpack-plugin
|
train
|
js
|
1860bff811e8041484a8b361f0aecb6b2f72a68c
|
diff --git a/python/neuroglancer/server.py b/python/neuroglancer/server.py
index <HASH>..<HASH> 100644
--- a/python/neuroglancer/server.py
+++ b/python/neuroglancer/server.py
@@ -87,7 +87,7 @@ class Server(object):
if global_static_content_source is None:
global_static_content_source = static.get_default_static_content_source()
- if bind_address == '0.0.0.0':
+ if bind_address == '0.0.0.0' or bind_address == '::':
hostname = socket.getfqdn()
else:
hostname = bind_address
|
fix(python): support ipv6 "::" bind address (indicates all interfaces)
|
google_neuroglancer
|
train
|
py
|
882086686d350af9e628cbc053bea65b6bb654b9
|
diff --git a/src/decorator/autorun/core.js b/src/decorator/autorun/core.js
index <HASH>..<HASH> 100644
--- a/src/decorator/autorun/core.js
+++ b/src/decorator/autorun/core.js
@@ -18,8 +18,14 @@ export default (opt = {}, target, property, description) => {
dispose = null
}
- function wrapMethod(method, callback) {
+ function wrapMethod(method, callback, callbackPlacement = 'after') {
return function () {
+ // urlsync 在 autorun 后面执行
+ if (callbackPlacement === 'before') {
+ callback && callback.call(this)
+ return method && method.apply(this, arguments)
+ }
+
// autorun 在 urlsync 后面执行
const rlt = method && method.apply(this, arguments)
callback && callback.call(this)
@@ -30,7 +36,7 @@ export default (opt = {}, target, property, description) => {
target[exitKey] = wrapMethod(target[exitKey], function () {
release()
- })
+ }, 'before')
target[initKey] = wrapMethod(target[initKey], function () {
if (dispose) {
|
fix: fix the execute order about autorun dispose
|
be-fe_react-mobx-vm
|
train
|
js
|
7b8b4c2fa3fa6d1a96596a67be00e9ee9a4244a7
|
diff --git a/src/image/Image.js b/src/image/Image.js
index <HASH>..<HASH> 100644
--- a/src/image/Image.js
+++ b/src/image/Image.js
@@ -723,7 +723,7 @@ export default class Image {
components = [components];
}
if (!components.includes(this.components)) {
- throw new TypeError('The process: ' + processName + ' can only be applied if the number of channels is in: ' + components);
+ throw new TypeError('The process: ' + processName + ' can only be applied if the number of components is in: ' + components);
}
}
if (channels) {
@@ -731,7 +731,7 @@ export default class Image {
channels = [channels];
}
if (!channels.includes(this.channels)) {
- throw new TypeError('The process: ' + processName + ' can only be applied if the number of components is in: ' + channels);
+ throw new TypeError('The process: ' + processName + ' can only be applied if the number of channels is in: ' + channels);
}
}
}
|
fix: inverted components and channels in checkProcessable
|
image-js_image-js
|
train
|
js
|
6a283d484f43f6e8c379d5c16b89f68b54556a4e
|
diff --git a/build/webpack.prod.js b/build/webpack.prod.js
index <HASH>..<HASH> 100644
--- a/build/webpack.prod.js
+++ b/build/webpack.prod.js
@@ -49,6 +49,18 @@ const config = webpackMerge(commonConfig({
minimize: true,
debug: false
}),
+ new webpack.optimize.UglifyJsPlugin({
+ compress: {
+ warnings: false,
+ screw_ie8: true,
+ negate_iife: false // for lazy v8
+ },
+ mangle: { screw_ie8 : true },
+ output: {
+ comments: false
+ },
+ sourceMap: true
+ }),
new webpack.BannerPlugin(BANNER)
]
})
|
chore: return back removed uglify plugin
|
Rebilly_ReDoc
|
train
|
js
|
974efb836667bbc725fc9f2bbfef9e4e268705a1
|
diff --git a/lib/index.js b/lib/index.js
index <HASH>..<HASH> 100644
--- a/lib/index.js
+++ b/lib/index.js
@@ -17,16 +17,27 @@ module.exports = (options = {}) => {
tree.match({tag: 'include'}, node => {
let src = node.attrs.src || false;
- let locals = node.attrs.locals || (node.content ? node.content.join().replace(/'\n'/g, '') : false);
let content;
let subtree;
let source;
+ let locals;
+
+ const localsString = node.attrs.locals || (node.content ? node.content.join().replace(/\n/g, '') : '');
+ const tryToParseLocals = localsString.trim() && localsString.trim().startsWith('{');
+
+ if (tryToParseLocals) {
+ try {
+ locals = JSON.parse(localsString);
+ } catch {
+ locals = false;
+ }
+ }
if (src) {
src = path.resolve(options.root, src);
source = fs.readFileSync(src, options.encoding);
- if (locals && locals.includes(':')) {
- locals = JSON.parse(locals);
+
+ if (locals) {
const result = posthtml()
.use(expressions({locals}))
.process(source, {sync: true});
|
refactor: refactored locals parsing logic to allow inner locals feature
|
posthtml_posthtml-include
|
train
|
js
|
421ec706606798035dda2e2226fd3eb9015ec901
|
diff --git a/scripts/release.js b/scripts/release.js
index <HASH>..<HASH> 100755
--- a/scripts/release.js
+++ b/scripts/release.js
@@ -27,6 +27,7 @@ mergeDevIntoMaster();
showChangelog(shell);
promptVersion(packageJson.version, (version) => {
bumpVersion(version, () => {
+ build();
updateChangelog(shell);
commitNewFiles(version);
publish();
@@ -131,3 +132,7 @@ function goBackToDevelop() {
shell.echo('Pushing the merge to Github');
shell.exec('git push origin develop', {silent: true});
}
+
+function build() {
+ shell.exec('yarn run build');
+}
|
fix(release-script): actually build the library (#<I>)
There is a missing step in the release process: the build step. This patch
adds this step using the existing script.
|
algolia_algoliasearch-helper-js
|
train
|
js
|
0b5c4e396cd2b42d7c59820ff750f40649ff52e3
|
diff --git a/src/template/initd.js b/src/template/initd.js
index <HASH>..<HASH> 100644
--- a/src/template/initd.js
+++ b/src/template/initd.js
@@ -37,7 +37,7 @@ start () {
echo starting ${d.name}
if [ -e "/var/deepstream/DEEPSTREAM_SETUP" ]; then
- bash "/var/deepstream/scripts/DEEPSTREAM_SETUP"
+ bash "/var/deepstream/DEEPSTREAM_SETUP"
fi
if [ -e "/var/deepstream/DEEPSTREAM_ENV_VARS" ]; then
|
refactor: get rid of reference to /var/deepstream/scripts and use /var/deepstream/
|
deepstreamIO_deepstream.io-service
|
train
|
js
|
7a7c3af8cec318b507a73e355be021b867370a75
|
diff --git a/events-manager.js b/events-manager.js
index <HASH>..<HASH> 100644
--- a/events-manager.js
+++ b/events-manager.js
@@ -116,7 +116,7 @@
i = i || 0;
results = results || [];
- if (i === events.length) {
+ if (i >= events.length) {
if (callback) {
callback(results);
}
|
fix(events-manager): prevent removed events in fire loop
|
XavierBoubert_events-manager
|
train
|
js
|
42a173bcbdc92f324b1e459c19ab5197465e65bd
|
diff --git a/lib/forms/camunda-form.js b/lib/forms/camunda-form.js
index <HASH>..<HASH> 100644
--- a/lib/forms/camunda-form.js
+++ b/lib/forms/camunda-form.js
@@ -434,7 +434,9 @@ CamundaForm.prototype.submit = function(callback) {
this.submitPrevented = false;
this.fireEvent('submit');
if (!!this.submitPrevented) {
- return;
+ var err = new Error('camForm submission prevented');
+ this.fireEvent('submit-failed', err);
+ return callback && callback(err);
}
try {
|
fix(camForm-submission): use callback on submitPrevented
cam.submitPrevented now calls the function passed to camForm.submit
and fires a `submit-failed` event.
Related to CAM-<I>
|
camunda_camunda-bpm-sdk-js
|
train
|
js
|
ea21a7ba91b3b0f36d5bcec28df60d674cb3080f
|
diff --git a/packages/dna-core/src/mixins/style-component.js b/packages/dna-core/src/mixins/style-component.js
index <HASH>..<HASH> 100644
--- a/packages/dna-core/src/mixins/style-component.js
+++ b/packages/dna-core/src/mixins/style-component.js
@@ -92,7 +92,7 @@ export const StyleMixin = (SuperClass) => class extends SuperClass {
style.textContent = this.css;
this.shadowRoot.appendChild(style);
}
- } else if (!this.constructor[STYLE_SYMBOL]) {
+ } else if (!this.constructor.hasOwnProperty(STYLE_SYMBOL)) {
let style = this.constructor[STYLE_SYMBOL] = createStyle(this);
ownerDocument(this.node).head.appendChild(style);
convertShadowCSS(style, this.css, this.is);
|
fix: style element for every component constructor #<I>
|
chialab_dna
|
train
|
js
|
e98c908c6d564ee6037fda0527b563918050c6db
|
diff --git a/hrp/internal/boomer/runner.go b/hrp/internal/boomer/runner.go
index <HASH>..<HASH> 100644
--- a/hrp/internal/boomer/runner.go
+++ b/hrp/internal/boomer/runner.go
@@ -380,10 +380,15 @@ func (r *runner) reset() {
}
func (r *runner) runTimeCheck(runTime int64) {
+ if runTime <= 0 {
+ return
+ }
+
for range time.Tick(time.Second * 3) {
nowTime := time.Now().Unix()
if nowTime > runTime {
r.stop()
+ return
}
}
}
@@ -646,10 +651,7 @@ func (r *localRunner) start() {
// output setup
r.outputOnStart()
- runTime := r.getRunTime()
- if runTime != 0 {
- go r.runTimeCheck(runTime)
- }
+ go r.runTimeCheck(r.getRunTime())
go r.spawnWorkers(r.getSpawnCount(), r.getSpawnRate(), r.stoppingChan, nil)
@@ -941,10 +943,7 @@ func (r *workerRunner) start() {
r.outputOnStart()
- runTime := r.getRunTime()
- if runTime != 0 {
- go r.runTimeCheck(runTime)
- }
+ go r.runTimeCheck(r.getRunTime())
go r.spawnWorkers(r.getSpawnCount(), r.getSpawnRate(), r.stoppingChan, r.spawnComplete)
|
feat: hrp boom support set run time
|
HttpRunner_HttpRunner
|
train
|
go
|
12b87f8259f615b02ef4a2d23e0774ed67be7bff
|
diff --git a/src/CreateSignalFactory.js b/src/CreateSignalFactory.js
index <HASH>..<HASH> 100644
--- a/src/CreateSignalFactory.js
+++ b/src/CreateSignalFactory.js
@@ -52,6 +52,7 @@ module.exports = function (controller, model, services, compute, modules) {
signal.isSync = true
signal.branches = options.branches
isPredefinedExecution = true
+ controller.emit('predefinedSignal', { signal: signal })
} else {
controller.emit('signalTrigger', { signal: signal })
}
|
feat(signalFactory): emit `predefinedSignal` event for predefined signal execution
|
cerebral_cerebral
|
train
|
js
|
0892b914085b3900653a7a8d4b45c13331a73e8e
|
diff --git a/teslajsonpy/controller.py b/teslajsonpy/controller.py
index <HASH>..<HASH> 100644
--- a/teslajsonpy/controller.py
+++ b/teslajsonpy/controller.py
@@ -479,7 +479,7 @@ class Controller:
continue
async with self.__lock[vin]:
if (
- online
+ (online or wake_if_asleep)
and ( # pylint: disable=too-many-boolean-expressions
self.__update.get(vin)
)
@@ -493,7 +493,9 @@ class Controller:
)
): # Only update cars with update flag on
try:
- data = await self.get(car_id, "data", wake_if_asleep)
+ data = await self.get(
+ car_id, "data", wake_if_asleep=wake_if_asleep
+ )
except TeslaException:
data = None
if data and data["response"]:
|
fix: fix forced wake up in initial update
|
zabuldon_teslajsonpy
|
train
|
py
|
47dec44948d4bbee634dafc2b047d9959f94309b
|
diff --git a/dpark/file_manager/__init__.py b/dpark/file_manager/__init__.py
index <HASH>..<HASH> 100644
--- a/dpark/file_manager/__init__.py
+++ b/dpark/file_manager/__init__.py
@@ -4,6 +4,7 @@ from .consts import *
from .mfs_proxy import ProxyConn
from dpark.util import get_logger
from .fs import MooseFS, PosixFS
+import os
logger = get_logger(__name__)
@@ -22,6 +23,7 @@ class FileManager(object):
return None
def open_file(self, path):
+ path = os.path.realpath(path)
fs = self._get_fs(path)
return fs.open_file(path)
diff --git a/dpark/file_manager/mfs_proxy.py b/dpark/file_manager/mfs_proxy.py
index <HASH>..<HASH> 100644
--- a/dpark/file_manager/mfs_proxy.py
+++ b/dpark/file_manager/mfs_proxy.py
@@ -183,6 +183,9 @@ class ProxyConn(object):
ans = self.sendAndReceive(CLTOMA_FUSE_READ_CHUNK, inode,
index, uint8(chunkopflags))
n = len(ans)
+ if n == 1:
+ from .utils import Error
+ raise Error(ord(ans))
if n % 2 == 0:
if n < 20:
raise Exception('read chunk invalid length: %s(expected 20 above)' % n)
|
fix: fix the bug for openfile
|
douban_dpark
|
train
|
py,py
|
cdb7ffab1ba84db40cc300fd4be62d5817be924b
|
diff --git a/bin/deepstream-service.js b/bin/deepstream-service.js
index <HASH>..<HASH> 100644
--- a/bin/deepstream-service.js
+++ b/bin/deepstream-service.js
@@ -26,9 +26,17 @@ function response (error, result) {
function execute(action) {
const name = this.serviceName || 'deepstream'
+ let exec
+ try {
+ require('nexeres')
+ exec = process.argv[0]
+ } catch (e) {
+ exec = process.argv[1]
+ }
+
if (action === 'add') {
const options = {
- exec: `${__dirname}/deepstream`,
+ exec,
programArgs: [],
logDir: this.logDir || '/var/log/deepstream',
dryRun: this.dryRun
|
fix: allowing nexe/node combination with services
|
deepstreamIO_deepstream.io
|
train
|
js
|
bb7e32eb5740e25106914d5b789d0cf50684e1a5
|
diff --git a/lib/client/ClientSocket.js b/lib/client/ClientSocket.js
index <HASH>..<HASH> 100644
--- a/lib/client/ClientSocket.js
+++ b/lib/client/ClientSocket.js
@@ -30,6 +30,10 @@ class ClientSocket {
this.socket.addEventListener(...args);
}
+ close() {
+ this.socket.close();
+ }
+
connect() {
if (this.socket) {
delete this.socket;
|
fix: add close passthrough method to ClientSocket (#<I>)
|
shellscape_webpack-plugin-serve
|
train
|
js
|
80028d919782a4880247d66d1a61d5e6d4270357
|
diff --git a/abilian/web/forms/fields.py b/abilian/web/forms/fields.py
index <HASH>..<HASH> 100644
--- a/abilian/web/forms/fields.py
+++ b/abilian/web/forms/fields.py
@@ -522,7 +522,7 @@ class QuerySelect2Field(SelectFieldBase):
raise Exception(
'The sqlalchemy identity_key function could not be imported.',
)
- self.get_pk = get_pk_from_identity
+ self.get_pk = self._get_pk_from_identity
else:
self.get_pk = get_pk
@@ -538,6 +538,16 @@ class QuerySelect2Field(SelectFieldBase):
self.query = None
self._object_list = None
+ @staticmethod
+ def _get_pk_from_identity(obj):
+ """Copied / pasted, and fixed, from WTForms_sqlalchemy due to issue
+ w/ SQLAlchemy >= 1.2.
+ """
+ from sqlalchemy.orm.util import identity_key
+
+ cls, key = identity_key(instance=obj)[0:2]
+ return ':'.join(text_type(x) for x in key)
+
def _get_data(self):
formdata = self._formdata
if formdata is not None:
|
fix: workaround API change in SQLAlchemy <I>.
|
abilian_abilian-core
|
train
|
py
|
007fe31eede68e7e0626a1f577c99a94cd9a6ed6
|
diff --git a/src/project-type/prompt-test.js b/src/project-type/prompt-test.js
index <HASH>..<HASH> 100644
--- a/src/project-type/prompt-test.js
+++ b/src/project-type/prompt-test.js
@@ -21,7 +21,7 @@ suite('project-type prompts', () => {
const chosenType = any.word();
const projectType = any.word();
const decisions = any.simpleObject();
- const answers = {...any.simpleObject(), type: chosenType};
+ const answers = {...any.simpleObject(), [questionNames.PROJECT_TYPE_CHOICE]: chosenType};
const types = any.simpleObject();
prompts.prompt
.withArgs([{
diff --git a/src/project-type/prompt.js b/src/project-type/prompt.js
index <HASH>..<HASH> 100644
--- a/src/project-type/prompt.js
+++ b/src/project-type/prompt.js
@@ -12,5 +12,5 @@ export default async function ({types, projectType, decisions}) {
choices: [...Object.keys(types), new Separator(), 'Other']
}], decisions);
- return answers.type;
+ return answers[questionNames.PROJECT_TYPE_CHOICE];
}
|
fix(project-type): retrieved the choice by the correct question name
|
travi_javascript-scaffolder
|
train
|
js,js
|
c17ce5f9c1bd5d32ccdd0e48f3607ffd41707f1e
|
diff --git a/pkg/kube/client.go b/pkg/kube/client.go
index <HASH>..<HASH> 100644
--- a/pkg/kube/client.go
+++ b/pkg/kube/client.go
@@ -152,7 +152,7 @@ func (c *Client) Get(namespace string, reader io.Reader) (string, error) {
return "", err
}
err = perform(c, namespace, infos, func(info *resource.Info) error {
- log.Printf("Doing get for: '%s'", info.Name)
+ log.Printf("Doing get for %s: '%s'", info.Mapping.GroupVersionKind.Kind, info.Name)
obj, err := resource.NewHelper(info.Client, info.Mapping).Get(info.Namespace, info.Name, info.Export)
if err != nil {
return err
@@ -390,7 +390,7 @@ func updateResource(c *Client, target *resource.Info, currentObj runtime.Object,
return fmt.Errorf("failed to create patch: %s", err)
}
if patch == nil {
- log.Printf("Looks like there are no changes for %s", target.Name)
+ log.Printf("Looks like there are no changes for %s %s", target.Mapping.GroupVersionKind.Kind, target.Name)
// This needs to happen to make sure that tiller has the latest info from the API
// Otherwise there will be no labels and other functions that use labels will panic
if err := target.Get(); err != nil {
|
fix(tiller): adding kind to tiller client logs
Closes #<I>
|
helm_helm
|
train
|
go
|
ee3089980e53027d812f6e09c2f6c79913af2d1a
|
diff --git a/quasar/src/components/select/QSelect.js b/quasar/src/components/select/QSelect.js
index <HASH>..<HASH> 100644
--- a/quasar/src/components/select/QSelect.js
+++ b/quasar/src/components/select/QSelect.js
@@ -83,14 +83,17 @@ export default Vue.extend({
},
watch: {
- selectedString (val) {
- const value = this.multiple !== true && this.hideSelected === true
- ? val
- : ''
+ selectedString: {
+ handler (val) {
+ const value = this.multiple !== true && this.hideSelected === true
+ ? val
+ : ''
- if (this.inputValue !== value) {
- this.inputValue = value
- }
+ if (this.inputValue !== value) {
+ this.inputValue = value
+ }
+ },
+ immediate: true
},
menu (show) {
|
fix(quasar): Populate QSelect's input on first show when use-input and hide-selected (#<I>)
|
quasarframework_quasar
|
train
|
js
|
e0b905476d0d23df9f274cb677f01687abe98468
|
diff --git a/pifpaf/__main__.py b/pifpaf/__main__.py
index <HASH>..<HASH> 100644
--- a/pifpaf/__main__.py
+++ b/pifpaf/__main__.py
@@ -198,8 +198,8 @@ class RunGroup(click.MultiCommand):
driver.cleanUp()
raise RuntimeError("Unable to start command: %s"
% " ".join(command))
- LOG.error(
- "Command `%s` (pid %s) is ready:",
+ LOG.info(
+ "Command `%s` (pid %s) is ready",
" ".join(command), c.pid
)
|
fix: log info, not error when command is ready
|
jd_pifpaf
|
train
|
py
|
e09474a230b647fed2792ff72a6f558b454eb709
|
diff --git a/sl.browsers.js b/sl.browsers.js
index <HASH>..<HASH> 100755
--- a/sl.browsers.js
+++ b/sl.browsers.js
@@ -119,10 +119,9 @@ module.exports = {
},
SL_iOS_10: {
base: 'SauceLabs',
- deviceName: 'iPhone Simulator',
- platformName: 'iOS',
- platformVersion: '10.0',
- browserName: 'Safari',
+ browserName: 'iphone',
+ platform: 'OS X 10.11',
+ version: '10.0',
},
SL_Android_4: {
base: 'SauceLabs',
|
test: fix ios <I>
|
chialab_dna
|
train
|
js
|
71fc3cce30f8940693082f6ca02ace829e6364f5
|
diff --git a/release.js b/release.js
index <HASH>..<HASH> 100644
--- a/release.js
+++ b/release.js
@@ -266,7 +266,7 @@
exec([
'rm -rf dist',
'gulp docs',
- 'sed -i \'\' \'s,http:\\/\\/localhost:8080\\/angular-material,https:\\/\\/gitcdn.xyz/repo/angular/bower-material/v{{newVersion}}/angular-material,g\' dist/docs/docs.js',
+ 'sed -i \'\' \'s,http:\\/\\/localhost:8080\\/angular-material,https:\\/\\/cdn.gitcdn.xyz/cdn/angular/bower-material/v{{newVersion}}/angular-material,g\' dist/docs/docs.js',
'sed -i \'\' \'s,base\ href=\\",base\ href=\\"/{{newVersion}},g\' dist/docs/index.html'
]);
|
docs: Fix incorrect Codepen GitCDN links.
The release script still pointed to the old GitCDN links which
always redirect to the master branch instead of the version
specified.
Update release script to use proper links.
Fixes #<I>. Closes #<I>.
|
angular_material
|
train
|
js
|
9c9aac8631e1106cef1918d63ce458eee89b9804
|
diff --git a/src/lib/error-handler.js b/src/lib/error-handler.js
index <HASH>..<HASH> 100644
--- a/src/lib/error-handler.js
+++ b/src/lib/error-handler.js
@@ -2,7 +2,7 @@
const { HTTPError } = require('ky-universal')
const log = require('debug')('ipfs-http-client:lib:error-handler')
-const { isNode } = require('ipfs-utils/src/env')
+const { isNode, isElectron } = require('ipfs-utils/src/env')
function isJsonResponse (res) {
return (res.headers.get('Content-Type') || '').startsWith('application/json')
@@ -18,7 +18,7 @@ module.exports = async function errorHandler (input, options, response) {
//
// If the body in the clone is not consumed or destroyed the highwater mark
// will be reached (for large payloads) and stop the real body from flowing.
- if (isNode) response.body.destroy()
+ if (isNode || isElectron) response.body.destroy()
return
}
|
fix: big downloads in electron
License: MIT
|
ipfs_js-ipfs
|
train
|
js
|
a58e854f13cf05e222c93e2319476a53810a8af3
|
diff --git a/treetime/treetime.py b/treetime/treetime.py
index <HASH>..<HASH> 100644
--- a/treetime/treetime.py
+++ b/treetime/treetime.py
@@ -982,8 +982,9 @@ def plot_vs_years(tt, step = None, ax=None, confidence=None, ticks=True, **kwarg
raise NotReadyError("confidence needs to be either a float (for max posterior region) or a two numbers specifying lower and upper bounds")
for n in tt.tree.find_clades():
- pos = cfunc(n, confidence)
- ax.plot(pos-offset, np.ones(len(pos))*n.ypos, lw=3, c=(0.5,0.5,0.5))
+ if not n.bad_branch:
+ pos = cfunc(n, confidence)
+ ax.plot(pos-offset, np.ones(len(pos))*n.ypos, lw=3, c=(0.5,0.5,0.5))
return fig, ax
def treetime_to_newick(tt, outf):
|
fix: exclude confidence intervals of branches marked as bad
|
neherlab_treetime
|
train
|
py
|
0311a684ad1a061d6f4071d679545b8eeb6c9465
|
diff --git a/src/test/java/com/conveyal/gtfs/GTFSTest.java b/src/test/java/com/conveyal/gtfs/GTFSTest.java
index <HASH>..<HASH> 100644
--- a/src/test/java/com/conveyal/gtfs/GTFSTest.java
+++ b/src/test/java/com/conveyal/gtfs/GTFSTest.java
@@ -402,7 +402,7 @@ public class GTFSTest {
Multimap<String, ValuePair> fieldsWithMismatches = ArrayListMultimap.create();
// Check that no validators failed during validation.
assertThat(
- "No validators failed during GTFS import.",
+ "One or more validators failed during GTFS import.",
countValidationErrorsOfType(connection, namespace, NewGTFSErrorType.VALIDATOR_FAILED),
equalTo(0)
);
|
test(writer): fix failure message in assertion
|
conveyal_gtfs-lib
|
train
|
java
|
922b4b8d1dd6767d9e675ce95b3ffefe16034a7a
|
diff --git a/superset/utils/database.py b/superset/utils/database.py
index <HASH>..<HASH> 100644
--- a/superset/utils/database.py
+++ b/superset/utils/database.py
@@ -39,10 +39,7 @@ def get_or_create_db(
from superset.models import core as models
database = (
- db.session.query(models.Database)
- .filter_by(database_name=database_name)
- .autoflush(False)
- .first()
+ db.session.query(models.Database).filter_by(database_name=database_name).first()
)
# databases with a fixed UUID
@@ -56,8 +53,11 @@ def get_or_create_db(
database_name=database_name, uuid=uuids.get(database_name)
)
db.session.add(database)
+ database.set_sqlalchemy_uri(sqlalchemy_uri)
+ db.session.commit()
- if database:
+ # todo: it's a bad idea to do an update in a get/create function
+ if database and database.sqlalchemy_uri_decrypted != sqlalchemy_uri:
database.set_sqlalchemy_uri(sqlalchemy_uri)
db.session.commit()
|
fix: unexpected commit causes pytest failure (#<I>)
|
apache_incubator-superset
|
train
|
py
|
0c710b0bee18fccad9223312cab421ff7eb6dd09
|
diff --git a/src/components/VSelect/VSelect.js b/src/components/VSelect/VSelect.js
index <HASH>..<HASH> 100644
--- a/src/components/VSelect/VSelect.js
+++ b/src/components/VSelect/VSelect.js
@@ -266,7 +266,7 @@ export default {
},
isBooted () {
this.$nextTick(() => {
- if (this.content instanceof EventTarget) {
+ if (this.content && this.content.addEventListener) {
this.content.addEventListener('scroll', this.onScroll, false)
}
})
|
fix(VSelect): check for addEventListener in isBooted watcher
Turns out IE<I> doesn't know what an EventTarget is
Fixes #<I>
Regression from #<I>
(cherry picked from commit a2a<I>a8c7b9abbcfcbdacb<I>a0b<I>fcab)
|
vuetifyjs_vuetify
|
train
|
js
|
d5212dfed51e9a370be33e5e739223eb05c33a49
|
diff --git a/taskqueue/__init__.py b/taskqueue/__init__.py
index <HASH>..<HASH> 100644
--- a/taskqueue/__init__.py
+++ b/taskqueue/__init__.py
@@ -1,7 +1,7 @@
from .registered_task import RegisteredTask, MockTask, PrintTask
from .taskqueue import (
TaskQueue, GreenTaskQueue, MockTaskQueue, LocalTaskQueue,
- multiprocess_upload
+ multiprocess_upload, QueueEmpty, totask
)
from .secrets import (
QUEUE_NAME, TEST_QUEUE_NAME, QUEUE_TYPE,
|
fix: export QueueEmpty
|
seung-lab_python-task-queue
|
train
|
py
|
f97296ff3613280f94c8d802ab4c8bea97700a6f
|
diff --git a/spoonx.js b/spoonx.js
index <HASH>..<HASH> 100644
--- a/spoonx.js
+++ b/spoonx.js
@@ -3,7 +3,7 @@
/* @see https://github.com/SpoonX/spoonx-tools */
/************************************************/
-var appRoot = 'src/';
+const appRoot = 'src/';
module.exports = {
path: {
@@ -41,12 +41,12 @@ module.exports = {
/* sort when concating
* sort: true,
*/
- sort: true,
+ sort: false,
/* concat js files
* concat: true,
*/
- concat: true,
+ concat: false,
/* options overwrites for karma. defaults are in ./node_modules/spoonx-tools/karma.conf.js
*
|
chore(project): disable concat builds
|
SpoonX_aurelia-form
|
train
|
js
|
45df3f1cd09d2da72d3426fb3134003aad1434a5
|
diff --git a/src/routes.js b/src/routes.js
index <HASH>..<HASH> 100644
--- a/src/routes.js
+++ b/src/routes.js
@@ -67,7 +67,7 @@ function getProperties(req, res) {
);
}
- const uniqProperties = [...new Set(flat)];
+ const uniqProperties = [...new Set(...flat)];
const sortedProperties = uniqProperties.sort((a, b) => {
if (!a.includes('.') && b.includes('.')) return -1;
if (a.includes('.') && !b.includes('.')) return 1;
|
fix(routes): flatten out properties array
|
zachowj_node-red-contrib-home-assistant-websocket
|
train
|
js
|
939a08249ad905477d3a0f4245cd5e44a439a6e6
|
diff --git a/lib/api-client/resources/history.js b/lib/api-client/resources/history.js
index <HASH>..<HASH> 100644
--- a/lib/api-client/resources/history.js
+++ b/lib/api-client/resources/history.js
@@ -882,8 +882,8 @@ History.cleanupConfiguration = function(params,done) {
/**
* Query for the history cleanup job
*/
-History.cleanupJob = function(params,done) {
- var url = this.path + '/cleanup/job';
+History.cleanupJobs = function(params,done) {
+ var url = this.path + '/cleanup/jobs';
if (typeof params === 'function') {
done = params;
|
chore(api): adjust cleanupJob api call
Related to CAM-<I>
|
camunda_camunda-bpm-sdk-js
|
train
|
js
|
a0d84ce1c11108e4082b7da8eaa0ddef5b933ccf
|
diff --git a/js/ftx.js b/js/ftx.js
index <HASH>..<HASH> 100644
--- a/js/ftx.js
+++ b/js/ftx.js
@@ -404,17 +404,20 @@ module.exports = class ftx extends Exchange {
'ftx.us': 'FTXUS',
},
'networks': {
- 'SOL': 'sol',
- 'SPL': 'sol',
- 'TRX': 'trx',
- 'TRC20': 'trx',
- 'ETH': 'erc20',
- 'ERC20': 'erc20',
- 'OMNI': 'omni',
+ 'AVAX': 'avax',
'BEP2': 'bep2',
- 'BNB': 'bep2',
'BEP20': 'bsc',
+ 'BNB': 'bep2',
'BSC': 'bsc',
+ 'ERC20': 'erc20',
+ 'ETH': 'erc20',
+ 'FTM': 'ftm',
+ 'MATIC': 'matic',
+ 'OMNI': 'omni',
+ 'SOL': 'sol',
+ 'SPL': 'sol',
+ 'TRC20': 'trx',
+ 'TRX': 'trx',
},
},
'commonCurrencies': {
|
fix: update and sort FTX withdrawal method mapping
|
ccxt_ccxt
|
train
|
js
|
07504869529cf1469fb1dcd0e88112dd36b54305
|
diff --git a/src/clappr-dash-shaka-playback.js b/src/clappr-dash-shaka-playback.js
index <HASH>..<HASH> 100644
--- a/src/clappr-dash-shaka-playback.js
+++ b/src/clappr-dash-shaka-playback.js
@@ -93,7 +93,7 @@ class DashShakaPlayback extends HTML5Video {
}
get bandwidthEstimate() {
- if (!this.shakaPlayerInstance) return
+ if (!this.shakaPlayerInstance) return null
return this.shakaPlayerInstance.getStats().estimatedBandwidth
}
|
fix(src): getter always return one value
|
clappr_dash-shaka-playback
|
train
|
js
|
ecd250c8ef2d161420fbaad6be62c2eb64cc224b
|
diff --git a/lib/components/form/settings-preview.js b/lib/components/form/settings-preview.js
index <HASH>..<HASH> 100644
--- a/lib/components/form/settings-preview.js
+++ b/lib/components/form/settings-preview.js
@@ -65,7 +65,7 @@ class SettingsPreview extends Component {
return (
<div className='settings-preview' onClick={this.props.onClick}>
- <div className='summary'>Transit+ Options<br />& Preferences</div>
+ <div className='summary'>Transit Options<br />& Preferences</div>
{button}
<div style={{ clear: 'both' }} />
</div>
|
feat(form): Change "Transit+" to "Transit"
|
opentripplanner_otp-react-redux
|
train
|
js
|
8491cb0034b137d30ec394b726b62f27daa929cd
|
diff --git a/jira.go b/jira.go
index <HASH>..<HASH> 100644
--- a/jira.go
+++ b/jira.go
@@ -35,6 +35,7 @@ type Client struct {
User *UserService
Group *GroupService
Version *VersionService
+ Priority *PriorityService
}
// NewClient returns a new JIRA API client.
@@ -71,6 +72,7 @@ func NewClient(httpClient *http.Client, baseURL string) (*Client, error) {
c.User = &UserService{client: c}
c.Group = &GroupService{client: c}
c.Version = &VersionService{client: c}
+ c.Priority = &PriorityService{client: c}
return c, nil
}
diff --git a/jira_test.go b/jira_test.go
index <HASH>..<HASH> 100644
--- a/jira_test.go
+++ b/jira_test.go
@@ -115,6 +115,9 @@ func TestNewClient_WithServices(t *testing.T) {
if c.Version == nil {
t.Error("No VersionService provided")
}
+ if c.Priority == nil {
+ t.Error("No PriorityService provided")
+ }
}
func TestCheckResponse(t *testing.T) {
|
fix: Add PriorityService to the main
|
andygrunwald_go-jira
|
train
|
go,go
|
c2f4cb245d63609e3bc5a03b28b5e01a05d7bf34
|
diff --git a/source/rafcon/gui/models/container_state.py b/source/rafcon/gui/models/container_state.py
index <HASH>..<HASH> 100644
--- a/source/rafcon/gui/models/container_state.py
+++ b/source/rafcon/gui/models/container_state.py
@@ -276,9 +276,6 @@ class ContainerStateModel(StateModel):
def change_state_type(self, model, prop_name, info):
if info.method_name != 'change_state_type':
return
- self.change_state_type.__func__.last_notification_model = model
- self.change_state_type.__func__.last_notification_prop_name = prop_name
- self.change_state_type.__func__.last_notification_info = info
def insert_meta_data_from_models_dict(self, source_models_dict):
|
fix(ContainerStateModel): Remove unused function storage
No more values are stored at the change_state_type function, as they are
used nowhere
|
DLR-RM_RAFCON
|
train
|
py
|
d9dd53bc02ad86259c642f0d838a23d764bff7f4
|
diff --git a/ui/src/components/icon/QIcon.js b/ui/src/components/icon/QIcon.js
index <HASH>..<HASH> 100644
--- a/ui/src/components/icon/QIcon.js
+++ b/ui/src/components/icon/QIcon.js
@@ -33,7 +33,7 @@ const mRE = /^M/
const imgRE = /^img:/
const svgUseRE = /^svguse:/
const ionRE = /^ion-/
-const faLaRE = /^[l|f]a[s|r|l|b|d]? /
+const faLaRE = /^[l|f]a[s|r|l|b|d|k]? /
export default createComponent({
name: 'QIcon',
|
feat(QIcon): recognize FontAwesome Pro "Kit Uploads" icons #<I>
|
quasarframework_quasar
|
train
|
js
|
9a4e1ed38d3f62bdfa64f96c75b877c2f6a780da
|
diff --git a/lib/components/narrative/narrative-routing-results.js b/lib/components/narrative/narrative-routing-results.js
index <HASH>..<HASH> 100644
--- a/lib/components/narrative/narrative-routing-results.js
+++ b/lib/components/narrative/narrative-routing-results.js
@@ -10,7 +10,7 @@ import { getActiveSearch } from '../../util/state'
class NarrativeRoutingResults extends Component {
static propTypes = {
customIcons: PropTypes.object,
- itineraryClass: PropTypes.object,
+ itineraryClass: PropTypes.func,
routingType: PropTypes.string
}
@@ -38,6 +38,6 @@ const mapStateToProps = (state, ownProps) => {
}
}
-const mapDispatchToProps = (dispatch, ownProps) => { }
+const mapDispatchToProps = { }
export default connect(mapStateToProps, mapDispatchToProps)(NarrativeRoutingResults)
|
fix(narrative): silence react warnings
|
opentripplanner_otp-react-redux
|
train
|
js
|
2554d7907fd1c0ddf7e761318b603cf8f313868b
|
diff --git a/test/basic.js b/test/basic.js
index <HASH>..<HASH> 100644
--- a/test/basic.js
+++ b/test/basic.js
@@ -3,7 +3,7 @@ var util = require("util")
console.error("testing")
var called = 0
-readInstalled(process.cwd(), function (er, map) {
+readInstalled(process.cwd(), console.error, function (er, map) {
console.error(called ++)
if (er) return console.error(er.stack || er.message)
cleanup(map)
|
test: pass console.error as logFn
|
npm_read-installed
|
train
|
js
|
fbec749ec2da9f5cb855b69923f0332668e4d59f
|
diff --git a/src/lib/CollectStore.js b/src/lib/CollectStore.js
index <HASH>..<HASH> 100644
--- a/src/lib/CollectStore.js
+++ b/src/lib/CollectStore.js
@@ -386,7 +386,7 @@ export default class CollectStore {
})
.catch(error => {
this.dispatch(updateConnectionRunningStatus(connection.konnector || konnector, connection.account || account, false))
- this.dispatch(updateConnectionError(konnector, account, error))
+ this.dispatch(updateConnectionError(connection.konnector || konnector, connection.account, error))
connection.error = error
return connection
})
|
fix: avoid undefined konnector on run error :ambulance:
|
cozy_cozy-home
|
train
|
js
|
0a3b5530142de3e7664ddfa73ebb756b7a0a357c
|
diff --git a/test/fixture/nuxt.config.js b/test/fixture/nuxt.config.js
index <HASH>..<HASH> 100644
--- a/test/fixture/nuxt.config.js
+++ b/test/fixture/nuxt.config.js
@@ -1,6 +1,6 @@
-import path from 'path'
+const path = require('path')
-export default {
+module.exports = {
srcDir: __dirname,
rootDir: path.resolve(__dirname, '../../'),
buildDir: path.resolve(__dirname, '.nuxt2'),
|
test: fix jest problems
esm is not supported yet!
|
nuxt-community_pwa-module
|
train
|
js
|
9c43c7fdde7526ba7f3a0759fd129bd254f51634
|
diff --git a/aiogram/contrib/fsm_storage/redis.py b/aiogram/contrib/fsm_storage/redis.py
index <HASH>..<HASH> 100644
--- a/aiogram/contrib/fsm_storage/redis.py
+++ b/aiogram/contrib/fsm_storage/redis.py
@@ -336,9 +336,9 @@ class RedisStorage2(BaseStorage):
bucket: typing.Dict = None, **kwargs):
if bucket is None:
bucket = {}
- temp_bucket = await self.get_data(chat=chat, user=user)
+ temp_bucket = await self.get_bucket(chat=chat, user=user)
temp_bucket.update(bucket, **kwargs)
- await self.set_data(chat=chat, user=user, data=temp_bucket)
+ await self.set_bucket(chat=chat, user=user, data=temp_bucket)
async def reset_all(self, full=True):
"""
|
fix: typo: data -> bucket in update_bucket
|
aiogram_aiogram
|
train
|
py
|
d6b7b46cf96eb792c9192165e6473b154bb25299
|
diff --git a/packages/cli/src/index.test.js b/packages/cli/src/index.test.js
index <HASH>..<HASH> 100644
--- a/packages/cli/src/index.test.js
+++ b/packages/cli/src/index.test.js
@@ -17,7 +17,7 @@ test("init", () => {
const options = {
name: "somepkg",
owner: "tester",
- scope: "36node",
+ scope: "36node"
};
return init(tpl, dest, options)
@@ -30,8 +30,8 @@ test("init", () => {
name: "@36node/somepkg",
repository: {
url: "tester/somepkg",
- type: "git",
- },
+ type: "git"
+ }
},
{ spaces: 2 }
);
diff --git a/packages/cli/src/lib/utils.js b/packages/cli/src/lib/utils.js
index <HASH>..<HASH> 100644
--- a/packages/cli/src/lib/utils.js
+++ b/packages/cli/src/lib/utils.js
@@ -5,7 +5,7 @@ export const promisify = (fn, receiver) => {
...args,
(err, res) => {
return err ? reject(err) : resolve(res);
- },
+ }
]);
});
};
|
chore: remove trailing comma
|
36node_sketch
|
train
|
js,js
|
93b4b3b7b92cba661a6f16b204a7f3514ec1d0bd
|
diff --git a/test/utils.py b/test/utils.py
index <HASH>..<HASH> 100644
--- a/test/utils.py
+++ b/test/utils.py
@@ -836,7 +836,11 @@ def check_tablet_query_service(testcase, tablet, serving, tablet_control_disable
expected_state = 'SERVING'
else:
expected_state = 'NOT_SERVING'
- testcase.assertEqual(tablet_vars['TabletStateName'], expected_state, 'tablet %s is not in the right serving state: got %s expected %s' % (tablet.tablet_alias, tablet_vars['TabletStateName'], expected_state))
+ testcase.assertEqual(tablet_vars['TabletStateName'], expected_state,
+ 'tablet %s (%s/%s, %s) is not in the right serving state: got %s'
+ ' expected %s' % (tablet.tablet_alias, tablet.keyspace, tablet.shard,
+ tablet.tablet_type,
+ tablet_vars['TabletStateName'], expected_state))
status = tablet.get_status()
if tablet_control_disabled:
|
test: Log keyspace, shard and tablet type when utils.check_tablet_query_service() fails.
|
vitessio_vitess
|
train
|
py
|
c71b8bea5db7aa2ab3fecaed4fa45193457eb2d4
|
diff --git a/magicalimport/__init__.py b/magicalimport/__init__.py
index <HASH>..<HASH> 100644
--- a/magicalimport/__init__.py
+++ b/magicalimport/__init__.py
@@ -3,6 +3,13 @@ import sys
from magicalimport.compat import _create_module
from magicalimport.compat import import_module as import_module_original
+try:
+ ModuleNotFoundError
+except NameError:
+ # for <3.6
+ class ModuleNotFoundError(ImportError):
+ pass
+
def expose_all_members(module, globals_=None, _depth=2):
members = {k: v for k, v in module.__dict__.items() if not k.startswith("_")}
|
fix: support <py<I>
|
podhmo_magicalimport
|
train
|
py
|
04e10d5b998bfd391cf322fe81749d6a08846fd5
|
diff --git a/distro/jbossas71/subsystem/src/main/java/org/camunda/bpm/container/impl/jboss/extension/handler/JobAcquisitionAdd.java b/distro/jbossas71/subsystem/src/main/java/org/camunda/bpm/container/impl/jboss/extension/handler/JobAcquisitionAdd.java
index <HASH>..<HASH> 100644
--- a/distro/jbossas71/subsystem/src/main/java/org/camunda/bpm/container/impl/jboss/extension/handler/JobAcquisitionAdd.java
+++ b/distro/jbossas71/subsystem/src/main/java/org/camunda/bpm/container/impl/jboss/extension/handler/JobAcquisitionAdd.java
@@ -107,6 +107,7 @@ public class JobAcquisitionAdd extends AbstractAddStepHandler implements Descrip
// start new service for job executor
ServiceController<RuntimeContainerJobExecutor> serviceController = context.getServiceTarget().addService(ServiceNames.forMscRuntimeContainerJobExecutorService(acquisitionName), mscRuntimeContainerJobExecutor)
+ .addDependency(ServiceNames.forMscRuntimeContainerDelegate())
.addDependency(ServiceNames.forMscExecutorService())
.addListener(verificationHandler)
.setInitialMode(Mode.ACTIVE)
|
fix(job-exe): Add dependency to RuntimeDelegate
|
camunda_camunda-bpm-platform
|
train
|
java
|
d8468e47ae0ca5506173b6ea5c4c91f6dd86c7b2
|
diff --git a/lib/TaskService.js b/lib/TaskService.js
index <HASH>..<HASH> 100644
--- a/lib/TaskService.js
+++ b/lib/TaskService.js
@@ -99,12 +99,15 @@ class TaskService {
}
const sanitizedTask = this.sanitizeTask(task);
+
try {
await this.api.handleBpmnError(
sanitizedTask,
errorCode,
errorMessage,
- variables
+ variables instanceof Variables
+ ? variables.getDirtyVariables()
+ : undefined
);
this.success("handleBpmnError", task);
} catch (e) {
diff --git a/lib/TaskService.test.js b/lib/TaskService.test.js
index <HASH>..<HASH> 100644
--- a/lib/TaskService.test.js
+++ b/lib/TaskService.test.js
@@ -233,7 +233,7 @@ describe("TaskService", () => {
{ id: expectedTaskId },
expectedErrorCode,
expectedErrorMessage,
- variables
+ expectedVariables
);
});
});
|
fix(handleBpmnError): send correct variables to api
Related to CAM-<I>
|
camunda_camunda-external-task-client-js
|
train
|
js,js
|
a67f509c092652dec8eafecf6bf495ff91986b56
|
diff --git a/lib/stub-module.js b/lib/stub-module.js
index <HASH>..<HASH> 100644
--- a/lib/stub-module.js
+++ b/lib/stub-module.js
@@ -22,7 +22,8 @@ const UNAVAIABLE_CORE_MODULES = [
'net',
'readline',
'repl',
- 'tls'
+ 'tls',
+ 'worker_thread'
];
const EMPTY_MODULE = 'define(function(){return {};});';
|
chore: worker_thread is unavailable in browser
|
dumberjs_dumber
|
train
|
js
|
a350e89381c87711618f35fed7e4e1f9ebbb98ab
|
diff --git a/lib/Browser.js b/lib/Browser.js
index <HASH>..<HASH> 100644
--- a/lib/Browser.js
+++ b/lib/Browser.js
@@ -43,11 +43,11 @@ class Browser extends EventEmitter {
/**
* @param {!Puppeteer.Connection} connection
- * @param {boolean} ignoreHTTPSErrors
+ * @param {!Object=} options
* @param {function()=} closeCallback
*/
- static async create(connection, ignoreHTTPSErrors, closeCallback) {
- const browser = new Browser(connection, ignoreHTTPSErrors, closeCallback);
+ static async create(connection, options, closeCallback) {
+ const browser = new Browser(connection, options, closeCallback);
await connection.send('Target.setDiscoverTargets', {discover: true});
return browser;
}
|
chore(Browser): fix jsdoc in Browser.create method (#<I>)
|
GoogleChrome_puppeteer
|
train
|
js
|
1c08f137d7cbe1f64651014db6f7e24f48903532
|
diff --git a/lib/components/state-resources/search/index.js b/lib/components/state-resources/search/index.js
index <HASH>..<HASH> 100644
--- a/lib/components/state-resources/search/index.js
+++ b/lib/components/state-resources/search/index.js
@@ -330,7 +330,7 @@ class Search {
.map(doc =>
this.searchHistory.upsert({
userId: userId,
- docId: doc.docId,
+ docId: doc.doc_id || doc.docId,
category: doc.category
}, {})
)
|
fix: default to doc_id in case of storage search otherwise use docId for solr search
|
wmfs_tymly-solr-plugin
|
train
|
js
|
710f9b96366d182816c35da5f1c1a41daaa85cc4
|
diff --git a/webapps/webapp/src/main/runtime/develop/java/org/camunda/bpm/pa/service/ArchiveInvoiceService.java b/webapps/webapp/src/main/runtime/develop/java/org/camunda/bpm/pa/service/ArchiveInvoiceService.java
index <HASH>..<HASH> 100644
--- a/webapps/webapp/src/main/runtime/develop/java/org/camunda/bpm/pa/service/ArchiveInvoiceService.java
+++ b/webapps/webapp/src/main/runtime/develop/java/org/camunda/bpm/pa/service/ArchiveInvoiceService.java
@@ -10,7 +10,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package org.camunda.bpm.example.invoice.service;
+package org.camunda.bpm.pa.service;
import java.util.logging.Logger;
|
fix(demo): change package declaration
|
camunda_camunda-bpm-platform
|
train
|
java
|
5853e4ed653080ea8dd7e0b6ca754e1277afa108
|
diff --git a/tests/unit_tests/test_sweep_scheduler.py b/tests/unit_tests/test_sweep_scheduler.py
index <HASH>..<HASH> 100644
--- a/tests/unit_tests/test_sweep_scheduler.py
+++ b/tests/unit_tests/test_sweep_scheduler.py
@@ -159,6 +159,7 @@ def test_sweep_scheduler_base_add_to_launch_queue(monkeypatch):
assert _scheduler._runs["foo_run"].state == SimpleRunState.DEAD
+@pytest.mark.xfail(reason="TODO(hupo): fix")
def test_sweep_scheduler_sweeps(monkeypatch):
api = internal.Api()
|
fix(sweeps): mark flakey sweeps test xfail (#<I>)
* remove flake test
* format
* mark xfail, formatting
* mark xfail, format
|
wandb_client
|
train
|
py
|
8ef8840adff0bb3f7abd83af3843d731974e7ba8
|
diff --git a/src/activation.js b/src/activation.js
index <HASH>..<HASH> 100644
--- a/src/activation.js
+++ b/src/activation.js
@@ -71,8 +71,7 @@ function findDeactivatable(plan, callbackName, list: Array<Object> = []): Array<
if (viewPortPlan.childNavigationInstruction) {
findDeactivatable(viewPortPlan.childNavigationInstruction.plan, callbackName, list);
- }
- if (prevComponent) {
+ } else if (prevComponent) {
addPreviousDeactivatable(prevComponent, callbackName, list);
}
}
|
fix(activation): regression in deactivate
|
aurelia_router
|
train
|
js
|
32cc0c8ddbc57e5cff9ee7e33f56d0f988e65fb2
|
diff --git a/lib/errors.js b/lib/errors.js
index <HASH>..<HASH> 100644
--- a/lib/errors.js
+++ b/lib/errors.js
@@ -71,7 +71,7 @@ class RequestAbortedError extends UndiciError {
class ContentLengthMismatch extends UndiciError {
constructor (message) {
super(message)
- Error.captureStackTrace(this, RequestAbortedError)
+ Error.captureStackTrace(this, ContentLengthMismatch)
this.name = 'ContentLengthMismatch'
this.message = message || /* istanbul ignore next */ 'Request body length does not match content-length header'
this.code = 'UND_ERR_CONTENT_LENGTH_MISMATCH'
|
fix: wrong type in captureStackTrace
|
mcollina_undici
|
train
|
js
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.