hash
stringlengths
40
40
diff
stringlengths
172
2.63k
message
stringlengths
12
593
project
stringlengths
7
65
split
stringclasses
1 value
diff_languages
stringclasses
54 values
bdd015c6ef20cd0b952403ad5afe21d1d8864668
diff --git a/src/Factory/Mail/ConfirmationFactory.php b/src/Factory/Mail/ConfirmationFactory.php index <HASH>..<HASH> 100644 --- a/src/Factory/Mail/ConfirmationFactory.php +++ b/src/Factory/Mail/ConfirmationFactory.php @@ -23,7 +23,7 @@ use Laminas\ServiceManager\Factory\FactoryInterface; */ class ConfirmationFactory implements FactoryInterface { - public function __invoke(ContainerInterface $container, $requestedName, array $options = []) + public function __invoke(ContainerInterface $container, $requestedName, ?array $options = null) { $router = $container->get('Router'); $options['router'] = $router;
fix(Applications): Confirmation mail factory is incompatible with Factory Interface.
yawik_applications
train
php
b19324c4a07957f6d0fda9be0a7d8cd01ed13572
diff --git a/lib/index.js b/lib/index.js index <HASH>..<HASH> 100644 --- a/lib/index.js +++ b/lib/index.js @@ -13,7 +13,7 @@ function IndexRegistry(taker) { DefaultRegistry.call(this); - var setTask = taker.set || taker._setTask; + var setTask = (taker.set || taker._setTask).bind(taker); setTask('ng:beforeServe', noop); setTask('ng:afterServe', noop);
fix(undertaker): comply with undertaker new <I> interface bis repetita
ng-tools_undertaker-lib-tasks
train
js
da31f41d353a94f838d7aaac7eb30047f5dcb5d7
diff --git a/wireprotocol/2_6_support.js b/wireprotocol/2_6_support.js index <HASH>..<HASH> 100644 --- a/wireprotocol/2_6_support.js +++ b/wireprotocol/2_6_support.js @@ -43,7 +43,7 @@ var executeWrite = function(pool, bson, type, opsField, ns, ops, options, callba } // Do we have bypassDocumentValidation set, then enable it on the write command - if (typeof options.bypassDocumentValidation === 'boolean') { + if (options.bypassDocumentValidation === true) { writeCommand.bypassDocumentValidation = options.bypassDocumentValidation; } diff --git a/wireprotocol/3_2_support.js b/wireprotocol/3_2_support.js index <HASH>..<HASH> 100644 --- a/wireprotocol/3_2_support.js +++ b/wireprotocol/3_2_support.js @@ -101,7 +101,7 @@ var executeWrite = function(pool, bson, type, opsField, ns, ops, options, callba } // Do we have bypassDocumentValidation set, then enable it on the write command - if (typeof options.bypassDocumentValidation === 'boolean') { + if (options.bypassDocumentValidation === true) { writeCommand.bypassDocumentValidation = options.bypassDocumentValidation; }
fix(wireprotocol): only send bypassDocumentValidation if true The bypassDocumentValidation key will only be set if it explicitly receives a true, otherwise it remains undefined. Fixes NODE-<I>
mongodb_node-mongodb-native
train
js,js
045c95df3d214f5a3843a56b93d2065afd9808a1
diff --git a/src/scrollfire/scrollfire-patch.js b/src/scrollfire/scrollfire-patch.js index <HASH>..<HASH> 100644 --- a/src/scrollfire/scrollfire-patch.js +++ b/src/scrollfire/scrollfire-patch.js @@ -1,3 +1,4 @@ +/* eslint no-new-func:0 */ export class ScrollfirePatch { patched = false;
chore(lint): disable no-new-func in scrollfire-patch
aurelia-ui-toolkits_aurelia-materialize-bridge
train
js
dcab3593d7b0458f164f4c56fb60ec36e3ec091d
diff --git a/.babelrc.js b/.babelrc.js index <HASH>..<HASH> 100644 --- a/.babelrc.js +++ b/.babelrc.js @@ -29,11 +29,4 @@ module.exports = { ], ignore: [/\/node_modules\/(?!@interactjs\/)/], - - extensions: [ - '.ts', - '.tsx', - '.js', - '.jsx', - ] } diff --git a/scripts/bundler.js b/scripts/bundler.js index <HASH>..<HASH> 100644 --- a/scripts/bundler.js +++ b/scripts/bundler.js @@ -44,6 +44,12 @@ module.exports = function (options) { sourceType: 'module', global: true, ...babelrc, + extensions: [ + '.ts', + '.tsx', + '.js', + '.jsx', + ], }], ],
chore: move babelify extensions config to bundler
taye_interact.js
train
js,js
57192ab92bdf7209da069d0635bf77cf16491005
diff --git a/lib/knex.js b/lib/knex.js index <HASH>..<HASH> 100644 --- a/lib/knex.js +++ b/lib/knex.js @@ -200,10 +200,12 @@ function explainAfterQuery (app, knex) { knex.on('query-response', (_response, { sql, bindings }) => { sql = knex.client._formatQuery(sql, bindings).trim(); if (haveQueryPlan(sql)) { - knex.raw(`explain ${sql}`).then(result => { - const explains = helper.rawResult(knex.dialect, result); - app.knexLogger.info('[egg-knex] explains of %s\n=====> result: %j', sql, explains); - }); + knex.raw(`explain ${sql}`) + .then(result => { + const explains = helper.rawResult(knex.dialect, result); + app.knexLogger.info('[egg-knex] explains of %s\n=====> result: %j', sql, explains); + }) + .catch(() => app.knexLogger.info('[egg-knex] Whoops! Explain does\'n work with:', sql)); } }); }
fix: raise explain exception * Mysql <I> only support SELECT statement
sunfuze_egg-knex
train
js
7def116d1b89ba86705054c0a32f0f718ca6060a
diff --git a/samples/automl/automlVisionPredict.js b/samples/automl/automlVisionPredict.js index <HASH>..<HASH> 100755 --- a/samples/automl/automlVisionPredict.js +++ b/samples/automl/automlVisionPredict.js @@ -55,7 +55,7 @@ async function predict( const params = {}; if (scoreThreshold) { - params.scoreThreshold = scoreThreshold; + params.score_threshold = scoreThreshold; } // Set the payload by giving the content and type of the file.
fix: Param "scoreThreshold" should be "score_threshold" (#<I>) Sine <I> Oct <I>, I found that the scoreThreshold param won't work and encounter "Error: 3 INVALID_ARGUMENT: Request contains an invalid argument." during prediction call. I compared the doc below and the params should be score_threshold instead of scoreThreshold. <URL>
googleapis_nodejs-vision
train
js
0ad89ab699c0d8167862e9d8abbd212a1f71f715
diff --git a/notification-portlet-webapp/src/main/java/org/jasig/portlet/notice/service/jpa/JpaEntry.java b/notification-portlet-webapp/src/main/java/org/jasig/portlet/notice/service/jpa/JpaEntry.java index <HASH>..<HASH> 100644 --- a/notification-portlet-webapp/src/main/java/org/jasig/portlet/notice/service/jpa/JpaEntry.java +++ b/notification-portlet-webapp/src/main/java/org/jasig/portlet/notice/service/jpa/JpaEntry.java @@ -86,7 +86,7 @@ import javax.persistence.Table; @JoinColumn(name = "ENTRY_ID") private Set<JpaAction> actions = new HashSet<>(); - @OneToMany(fetch=FetchType.LAZY, cascade=CascadeType.ALL) + @OneToMany(fetch=FetchType.EAGER, cascade=CascadeType.ALL) @JoinColumn(name = "ENTRY_ID") private Set<JpaAddressee> addressees = new HashSet<>();
fix: correct fetch type from LAZY to EAGER
Jasig_NotificationPortlet
train
java
622a3bac0fb72e249c3cc95718204cd885640369
diff --git a/onnxmltools/convert/sparkml/ops_names.py b/onnxmltools/convert/sparkml/ops_names.py index <HASH>..<HASH> 100644 --- a/onnxmltools/convert/sparkml/ops_names.py +++ b/onnxmltools/convert/sparkml/ops_names.py @@ -4,6 +4,7 @@ Mapping and utility functions for Name to Spark ML operators ''' +from pyspark.ml import Transformer, Estimator from pyspark.ml.feature import Binarizer from pyspark.ml.feature import BucketedRandomProjectionLSHModel from pyspark.ml.feature import Bucketizer @@ -86,6 +87,12 @@ def get_sparkml_operator_name(model_type): :param model_type: A spark-ml object (LinearRegression, StringIndexer, ...) :return: A string which stands for the type of the input model in our conversion framework ''' + if not issubclass(model_type, Transformer): + if issubclass(model_type, Estimator): + raise ValueError("Estimator must be fitted before being converted to ONNX") + else: + raise ValueError("Unknown model type: {}".format(model_type)) + if model_type not in sparkml_operator_name_map: raise ValueError("No proper operator name found for '%s'" % model_type) return sparkml_operator_name_map[model_type]
fix: showing better error message when a model of wrong type is being passed. (#<I>)
onnx_onnxmltools
train
py
dd13cbf43a5e1f2b12ed32d0b3a5f80d3f62f007
diff --git a/tests/const.py b/tests/const.py index <HASH>..<HASH> 100644 --- a/tests/const.py +++ b/tests/const.py @@ -7,7 +7,7 @@ # Requirements: # - Must contain /bin/bash (TestMain::test_*shell_override*) # -DOCKER_IMAGE = 'debian:8.2' +DOCKER_IMAGE = 'debian:10' # Alternate Docker image # This image is used for alternate tests (e.g. pulling) and should be small.
test: Update DOCKER_IMAGE to debian:<I> Rationale: - debian:<I> is old - debian:<I> uses a v1 schema manifest - debian:<I> is cached in Ubuntu:<I> GitHub actions image: <URL>
JonathonReinhart_scuba
train
py
0803e002e961c9a4bebe85f965f8025f0b9e3975
diff --git a/tests/integration/Inventory/InventoryUpdateRequestTest.php b/tests/integration/Inventory/InventoryUpdateRequestTest.php index <HASH>..<HASH> 100644 --- a/tests/integration/Inventory/InventoryUpdateRequestTest.php +++ b/tests/integration/Inventory/InventoryUpdateRequestTest.php @@ -206,7 +206,7 @@ class InventoryUpdateRequestTest extends ApiTestCase } while ($result->count() == 0 && $retries <= 20); if ($result->count() == 0) { - $this->markTestSkipped('Product availability not updated in time'); + $this->markTestSkipped('Product not updated in time'); } $retries = 0; @@ -222,6 +222,10 @@ class InventoryUpdateRequestTest extends ApiTestCase $result = $request->mapResponse($response); } while ($result->count() == 0 && $retries <= 9); + if ($result->count() == 0) { + $this->markTestSkipped('Product channel availability not updated in time'); + } + $this->assertSame( $product->getId(), $result->current()->getId()
test(Inventory): fix inventory query for channel test
commercetools_commercetools-php-sdk
train
php
4bffde649fed40a6844f0293926a4e51d6fa772a
diff --git a/lib/cursor.js b/lib/cursor.js index <HASH>..<HASH> 100644 --- a/lib/cursor.js +++ b/lib/cursor.js @@ -1069,7 +1069,10 @@ Cursor.prototype.close = function(options, callback) { this.emit('close'); // Callback if provided - if (typeof callback === 'function') return handleCallback(callback, null, this); + if (typeof callback === 'function') { + return handleCallback(callback, null, this); + } + // Return a Promise return new this.s.promiseLibrary(function(resolve) { resolve(); @@ -1080,7 +1083,7 @@ Cursor.prototype.close = function(options, callback) { return this.s.session.endSession(() => completeClose()); } - completeClose(); + return completeClose(); }; define.classMethod('close', { callback: true, promise: true });
refactor(cursor): return result of `completeClose` for promises NODE-<I>
mongodb_node-mongodb-native
train
js
7fc6ed1c7a3d2d8971216ed02c566ad1df73f6ad
diff --git a/src/cobra/flux_analysis/parsimonious.py b/src/cobra/flux_analysis/parsimonious.py index <HASH>..<HASH> 100644 --- a/src/cobra/flux_analysis/parsimonious.py +++ b/src/cobra/flux_analysis/parsimonious.py @@ -1,7 +1,7 @@ """Provide parsimonious FBA implementation.""" from itertools import chain -from typing import TYPE_CHECKING, Callable, Dict, List, Union +from typing import TYPE_CHECKING, Callable, Dict, List, Optional, Union from warnings import warn from optlang.symbolics import Zero @@ -45,7 +45,7 @@ def pfba( model: "Model", fraction_of_optimum: float = 1.0, objective: Union[Dict, "Objective", None] = None, - reactions: List["Reaction"] = None, + reactions: Optional[List["Reaction"]] = None, ) -> "Solution": """Perform basic pFBA (parsimonious Enzyme Usage Flux Balance Analysis). @@ -70,7 +70,7 @@ def pfba( reactions : list of cobra.Reaction, optional List of cobra.Reaction. Implies `return_frame` to be true. Only return fluxes for the given reactions. Faster than fetching all - fluxes if only a few are needed. + fluxes if only a few are needed (default None). Returns -------
fix: use proper typing annotation in parsimonious.py
opencobra_cobrapy
train
py
f25e43fab8e9d935a155f2a528133871c1cc89b3
diff --git a/gulpfile.js b/gulpfile.js index <HASH>..<HASH> 100644 --- a/gulpfile.js +++ b/gulpfile.js @@ -750,6 +750,7 @@ gulp.task('build.dart', function(done) { 'build/pubspec.dart', 'build/analyze.dart', 'build/pubbuild.dart', + 'build.dart.material.css', sequenceComplete(done) ); }); @@ -1050,14 +1051,16 @@ gulp.task('build.dart2js.material', function(done) { runSequence('build.dart', 'build.css.material', sequenceComplete(done)); }); -// TODO: this target is temporary until we find a way to use the SASS transformer -gulp.task('build.dart.material', ['build/packages.dart'], function() { +gulp.task('build.dart.material.css', function() { return gulp.src('dist/dart/angular2_material/src/**/*.scss') .pipe(sass()) .pipe(autoprefixer()) .pipe(gulp.dest('dist/dart/angular2_material/lib/src')); }); +gulp.task('build.dart.material', ['build/packages.dart'], function(done) { + runSequence('build/packages.dart', 'build.dart.material.css', sequenceComplete(done)) +}); gulp.task('cleanup.builder', function() { return angularBuilder.cleanup();
chore(build): add material css to dart build.
angular_angular
train
js
11c798cd15076d2c70e6a5b863dbd2a158a61778
diff --git a/Response.php b/Response.php index <HASH>..<HASH> 100644 --- a/Response.php +++ b/Response.php @@ -3,6 +3,7 @@ namespace Modulus\Framework; use Modulus\Http\Rest; +use Modulus\Utility\View; use Modulus\Http\Redirect; use Modulus\Framework\Upstart; @@ -41,6 +42,11 @@ class Response if ($response instanceof Redirect) return $response->send(); /** + * Create a view page + */ + if (Response::isView($response)) return; + + /** * Avoid "Segmentation fault (core dumped)" */ echo ' '; @@ -50,4 +56,21 @@ class Response */ return null; } + + /** + * Render a view + * + * @param mixed $response + * @return bool + */ + public static function isView($response) : bool + { + if ($response instanceof View) { + $response->render(); + + return true; + } + + return false; + } }
chore: handle View instances render view component if the returned object was a view instance
modulusphp_framework
train
php
fbbf1b63c113c8f9c1aac16d7ad6bb7280e55a4e
diff --git a/api/src/opentrons/hardware_control/controller.py b/api/src/opentrons/hardware_control/controller.py index <HASH>..<HASH> 100644 --- a/api/src/opentrons/hardware_control/controller.py +++ b/api/src/opentrons/hardware_control/controller.py @@ -41,7 +41,9 @@ class Controller: 'This is intended to run on a robot, and while it can connect ' 'to a smoothie via a usb/serial adapter unexpected things ' 'using gpios (such as smoothie reset or light management) ' - 'will fail') + 'will fail. If you are seeing this message and you are ' + 'running on a robot, you need to set the RUNNING_ON_PI ' + 'environmental variable to 1.') self.config = config or opentrons.config.robot_configs.load()
feat(api): add info to debug warning on how IS_ROBOT is determined (#<I>) If you run a robot without RUNNING_ON_PI in the environment you get this warning message (and substantially reduced functionality), but it is not clear how to resolve it. This provides that information. In my case it was because I was invoking one Python script from another with subprocess.
Opentrons_opentrons
train
py
947049fac1c75b89368d7f329e5acf727855cdf5
diff --git a/src/trumbowyg.js b/src/trumbowyg.js index <HASH>..<HASH> 100644 --- a/src/trumbowyg.js +++ b/src/trumbowyg.js @@ -1225,8 +1225,9 @@ Object.defineProperty(jQuery.trumbowyg, 'defaultOptions', { createLink: function () { var t = this, documentSelection = t.doc.getSelection(), + selectedRange = documentSelection.getRangeAt(0), node = documentSelection.focusNode, - text = new XMLSerializer().serializeToString(documentSelection.getRangeAt(0).cloneContents()), + text = new XMLSerializer().serializeToString(selectedRange.cloneContents()) || selectedRange + '', url, title, target; @@ -1263,7 +1264,7 @@ Object.defineProperty(jQuery.trumbowyg, 'defaultOptions', { } }; if (!t.o.minimalLinks) { - Object.assign(options, { + $.extend(options, { title: { label: t.lang.title, value: title
fix: makes links works on IE<I>
Alex-D_Trumbowyg
train
js
8b139575f8f2bcb995db917a1f3eefe3234a447e
diff --git a/src/exporter/file.js b/src/exporter/file.js index <HASH>..<HASH> 100644 --- a/src/exporter/file.js +++ b/src/exporter/file.js @@ -40,6 +40,7 @@ module.exports = (node, name, pathRest, ipldResolver) => { return pull.values([{ content: content, path: name, + hash: node.multihash, size: file.fileSize() }]) } diff --git a/test/test-exporter.js b/test/test-exporter.js index <HASH>..<HASH> 100644 --- a/test/test-exporter.js +++ b/test/test-exporter.js @@ -45,8 +45,8 @@ module.exports = (repo) => { function onFiles (err, files) { expect(err).to.not.exist() expect(files).to.have.length(1) + expect(files[0]).to.have.property('hash') expect(files[0]).to.have.property('path', hash) - fileEql(files[0], unmarsh.data, done) } }) @@ -117,6 +117,7 @@ module.exports = (repo) => { pull( exporter(hash, ipldResolver), pull.collect((err, files) => { + files.forEach(file => expect(file).to.have.property('hash')) expect(err).to.not.exist() expect(
feat: Include hash field for exported files (#<I>)
ipfs_js-ipfs-unixfs
train
js,js
13c7b7bc97aab4d70e178fdb25af1b2c3b85ac5b
diff --git a/lib/plugins/package/lib/zipService.js b/lib/plugins/package/lib/zipService.js index <HASH>..<HASH> 100644 --- a/lib/plugins/package/lib/zipService.js +++ b/lib/plugins/package/lib/zipService.js @@ -1,5 +1,6 @@ 'use strict'; +const { ServerlessError } = require('../../../classes/Error'); const BbPromise = require('bluebird'); const archiver = require('archiver'); const os = require('os'); @@ -120,11 +121,16 @@ module.exports = { // Get file contents and stat in parallel this.getFileContent(fullPath), fs.statAsync(fullPath), - ]).then(result => ({ - data: result[0], - stat: result[1], - filePath, - })); + ]).then( + result => ({ + data: result[0], + stat: result[1], + filePath, + }), + error => { + throw new ServerlessError(`Cannot read file ${filePath} due to: ${error.message}`); + } + ); }, // Useful point of entry for e.g. transpilation plugins
fix(Packaging): Expose meaningfully file access errors (#<I>)
serverless_serverless
train
js
9ca76795a043b6811515f3476cc825405a50605a
diff --git a/src/components/source.js b/src/components/source.js index <HASH>..<HASH> 100644 --- a/src/components/source.js +++ b/src/components/source.js @@ -59,7 +59,7 @@ module.exports = class ComponentSource extends Source { const content = yield variant.getContent(true); const rendered = yield engine.render(variant.viewPath, content, context); if (layout && variant.preview) { - let layout = source.find(variant.preview); + let layout = source.find(`@${variant.preview.replace('@','')}`); if (!layout) { logger.error(`Preview layout ${variant.preview} for component ${variant._parent.handle} not found.`); return rendered;
fix(components): make preview find call @-prefix agnostic
frctl_fractal
train
js
6b0b3158ff5e10aa6212aa1f9f51b20da71d2a75
diff --git a/test/actions/nodesSpec.js b/test/actions/nodesSpec.js index <HASH>..<HASH> 100644 --- a/test/actions/nodesSpec.js +++ b/test/actions/nodesSpec.js @@ -60,6 +60,7 @@ describe('Node actions with dependencies', () => { x: 10, y: 10, }, + properties: {}, }, }, pins: {
fix(tests): fix nodesSpec tests (missing new property "properties")
xodio_xod
train
js
df6b146ae66560777d797c0399dbf9b2db189e47
diff --git a/packages/feedback/src/FeedbackForm.js b/packages/feedback/src/FeedbackForm.js index <HASH>..<HASH> 100644 --- a/packages/feedback/src/FeedbackForm.js +++ b/packages/feedback/src/FeedbackForm.js @@ -211,7 +211,6 @@ const FeedbackForm = ({ onClick={onClose} color="secondary" onKeyDown={({ keyCode }) => { - console.log(keyCode); if (keyCode === 13) { onClose(); }
fix(feedback): removed console log
Availity_availity-react
train
js
8d8d569633853ea02d9ead983e9baf0c03dc7d82
diff --git a/packages/ui-list/src/List/index.js b/packages/ui-list/src/List/index.js index <HASH>..<HASH> 100644 --- a/packages/ui-list/src/List/index.js +++ b/packages/ui-list/src/List/index.js @@ -51,7 +51,7 @@ category: components **/ @deprecated('8.0.0', { variant: 'List with the isUnstyled boolean or InlineList', - delimeter: + delimiter: 'with delimiter set to [pipe, slash, arrow] will only be available when using [InlineList] as of version 8.0.0.' }) @testable()
chore(ui-list): fix typo
instructure_instructure-ui
train
js
3f850106539daba7ba263fc289245fbd9963ca63
diff --git a/lib/trim-slash.js b/lib/trim-slash.js index <HASH>..<HASH> 100644 --- a/lib/trim-slash.js +++ b/lib/trim-slash.js @@ -14,12 +14,10 @@ * @ nosideeffects */ function trimSlash(string) { - if (typeof string !== 'string') { - return string; - } - if (string.length > 0 && string.charAt(string.length - 1) === '/') { - return string.slice(0, string.length - 1); + if (typeof string === 'string' && string.endsWith('/')) { + return string.slice(0, -1); } + return string; }
style: clean up trimSlash This code violates the ESLint unicorn/prefer-negative-index rule. Clean it up and simplify a bit.
kevinoid_travis-status
train
js
5230178f41619b180ed975fd7bc4c521979a7d2f
diff --git a/lib/pool.js b/lib/pool.js index <HASH>..<HASH> 100644 --- a/lib/pool.js +++ b/lib/pool.js @@ -22,32 +22,16 @@ class Pool { }, () => new Client(url, options)) } - stream (opts, factory, cb) { - if (cb === undefined) { - return new Promise((resolve, reject) => { - this.stream(opts, factory, (err, data) => { - return err ? reject(err) : resolve(data) - }) - }) - } - - getNext(this).stream(opts, factory, cb) + stream (opts, factory, callback) { + return getNext(this).stream(opts, factory, callback) } pipeline (opts, handler) { return getNext(this).pipeline(opts, handler) } - request (opts, cb) { - if (cb === undefined) { - return new Promise((resolve, reject) => { - this.request(opts, (err, data) => { - return err ? reject(err) : resolve(data) - }) - }) - } - - getNext(this).request(opts, cb) + request (opts, callback) { + return getNext(this).request(opts, callback) } upgrade (opts, callback) {
refactor: pool doesn't need to create promise
mcollina_undici
train
js
17d73b77f0676d9a9188ddc066ee65d76a440721
diff --git a/src/components/inputs/select-input/select-input.spec.js b/src/components/inputs/select-input/select-input.spec.js index <HASH>..<HASH> 100644 --- a/src/components/inputs/select-input/select-input.spec.js +++ b/src/components/inputs/select-input/select-input.spec.js @@ -116,6 +116,25 @@ describe('in single mode', () => { }); }); describe('interacting', () => { + describe('when isAutofocussed is `true`', () => { + it('should open the list and all options should be visible', () => { + const { getByLabelText, getByText } = renderInput({ + isAutofocussed: true, + }); + + const input = getByLabelText('Fruit'); + + fireEvent.blur(input); + + fireEvent.keyDown(input, { + key: 'ArrowDown', + }); + + expect(getByText('Mango')).toBeInTheDocument(); + expect(getByText('Lichi')).toBeInTheDocument(); + expect(getByText('Raspberry')).toBeInTheDocument(); + }); + }); it('should open the list and all options should be visible', () => { const { getByLabelText, getByText } = renderInput(); const input = getByLabelText('Fruit');
chore(select-input): add test for when autoFocussed is true (#<I>) * chore(select-input): add test for when autoFocussed is true
commercetools_ui-kit
train
js
11ef853745335cf6302fe51565ecf3b2a159fd3e
diff --git a/test/test.js b/test/test.js index <HASH>..<HASH> 100644 --- a/test/test.js +++ b/test/test.js @@ -551,6 +551,22 @@ describe('S3rver Tests', function () { }); }); + + it('should list objects in a bucket filtered by a prefix 2', function (done) { + s3Client.listObjectsV2({ 'Bucket': buckets[1], Prefix: 'key' }, function (err, objects) { + if (err) { + return done(err) + } + should(objects.Contents.length).equal(4); + should.exist(_.find(objects.Contents, {'Key': 'key1'})); + should.exist(_.find(objects.Contents, {'Key': 'key2'})); + should.exist(_.find(objects.Contents, {'Key': 'key3'})); + should.exist(_.find(objects.Contents, {'Key': 'key/key1'})); + done(); + }) + }) + + it('should list objects in a bucket filtered by a marker', function (done) { s3Client.listObjects({'Bucket': buckets[1], Marker: 'akey3'}, function (err, objects) { if (err) {
test(listObjects): Adds test for issue #<I>
jamhall_s3rver
train
js
7f8f1ad4e3e7b3eb93ec0cf11cf7cb02a947f293
diff --git a/cmd/daily-lifecycle-ops.go b/cmd/daily-lifecycle-ops.go index <HASH>..<HASH> 100644 --- a/cmd/daily-lifecycle-ops.go +++ b/cmd/daily-lifecycle-ops.go @@ -44,22 +44,12 @@ func startDailyLifecycle(ctx context.Context, objAPI ObjectLayer) { return case <-time.NewTimer(bgLifecycleInterval).C: // Perform one lifecycle operation - err := lifecycleRound(ctx, objAPI) - switch err.(type) { - case OperationTimedOut: - // Unable to hold a lock means there is another - // caller holding write lock, ignore and try next round. - continue - default: - logger.LogIf(ctx, err) - } + logger.LogIf(ctx, lifecycleRound(ctx, objAPI)) } } } -var lifecycleLockTimeout = newDynamicTimeout(60*time.Second, time.Second) - func lifecycleRound(ctx context.Context, objAPI ObjectLayer) error { buckets, err := objAPI.ListBuckets(ctx) if err != nil {
fix: cleanup lifecycle unused code (#<I>)
minio_minio
train
go
04258d28f5eb57d2f769eb3b2b3db35aeb4e139d
diff --git a/tests/asm/test_risks.py b/tests/asm/test_risks.py index <HASH>..<HASH> 100644 --- a/tests/asm/test_risks.py +++ b/tests/asm/test_risks.py @@ -125,7 +125,7 @@ TEST_RISK_TYPE_JSON = { "type": "string", } TEST_RISK_TYPES_JSON = { - "constants": [TEST_RISK_TYPE_JSON], + "type": [TEST_RISK_TYPE_JSON], } TEST_PATCH_RISK_TYPE_JSON = { "changes": 0,
fix:update language to match pipeline/discover
censys_censys-python
train
py
872d91a48dd7938f69b9efe352d566e5fdea99eb
diff --git a/packages/cli/src/commands/server/middleware/getSecurityHeadersMiddleware.js b/packages/cli/src/commands/server/middleware/getSecurityHeadersMiddleware.js index <HASH>..<HASH> 100644 --- a/packages/cli/src/commands/server/middleware/getSecurityHeadersMiddleware.js +++ b/packages/cli/src/commands/server/middleware/getSecurityHeadersMiddleware.js @@ -16,7 +16,13 @@ export default function getSecurityHeadersMiddleware(req, res, next) { req.headers.origin && req.headers.origin !== `http://localhost:${address.port}` ) { - next(new Error('Unauthorized')); + next( + new Error( + 'Unauthorized request from ' + + req.headers.origin + + '. This may happen because of a conflicting browser extension. Please try to disable it and try again.', + ), + ); return; }
feat: Add hint for browser extensions that may break debug (#<I>) * Add hint for browser extensions that may break debug * Update getSecurityHeadersMiddleware.js * Fix lint error
react-native-community_cli
train
js
eccfbac1af6f0f770f6f22b56ec313f52de9f24d
diff --git a/test/OverlayTriggerSpec.js b/test/OverlayTriggerSpec.js index <HASH>..<HASH> 100644 --- a/test/OverlayTriggerSpec.js +++ b/test/OverlayTriggerSpec.js @@ -123,6 +123,33 @@ describe('<OverlayTrigger>', () => { wrapper.assertSingle('div.test'); }); + it('Should show after mouseover trigger', (done) => { + const clock = sinon.useFakeTimers(); + + try { + const wrapper = mount( + <OverlayTrigger overlay={<Div className="test" />}> + <span>hover me</span> + </OverlayTrigger>, + ); + + wrapper.assertNone('.test'); + + wrapper.find('span').simulate('mouseover'); + + wrapper.assertSingle('div.test'); + + wrapper.find('span').simulate('mouseout'); + + clock.tick(50); + + wrapper.assertNone('.test'); + } finally { + clock.restore(); + done(); + } + }); + it('Should not set aria-describedby if the state is not show', () => { const [button] = mount( <OverlayTrigger trigger="click" overlay={<Div />}>
test: add tests for mouseover trigger and use fake timers (#<I>)
react-bootstrap_react-bootstrap
train
js
29138ca794786631977646e5eefbecd11fadc307
diff --git a/src/components/list/QItemWrapper.js b/src/components/list/QItemWrapper.js index <HASH>..<HASH> 100644 --- a/src/components/list/QItemWrapper.js +++ b/src/components/list/QItemWrapper.js @@ -45,7 +45,7 @@ export default { push(child, h, QItemSide, slot.left, replace, { icon: cfg.icon, - color: cfg.iconColor, + color: cfg.leftColor, avatar: cfg.avatar, letter: cfg.letter, image: cfg.image @@ -62,7 +62,7 @@ export default { push(child, h, QItemSide, slot.right, replace, { right: true, icon: cfg.rightIcon, - color: cfg.rightIconColor, + color: cfg.rightColor, avatar: cfg.rightAvatar, letter: cfg.rightLetter, image: cfg.rightImage,
feat: Add iconColor and rightIconColor as options to QSelect items #<I>
quasarframework_quasar
train
js
0081089e6c458dd79fc193e7546da75031d87ea6
diff --git a/lib/DirectEditing.js b/lib/DirectEditing.js index <HASH>..<HASH> 100644 --- a/lib/DirectEditing.js +++ b/lib/DirectEditing.js @@ -13,6 +13,8 @@ var TextBox = require('./TextBox'); */ function DirectEditing(eventBus, canvas) { + this._eventBus = eventBus; + this._providers = []; this._textbox = new TextBox({ container: canvas.getContainer(), @@ -55,12 +57,20 @@ DirectEditing.prototype.cancel = function() { return; } + this._fire('cancel'); this.close(); }; +DirectEditing.prototype._fire = function(event) { + this._eventBus.fire('directEditing.' + event, { active: this._active }); +}; + DirectEditing.prototype.close = function() { this._textbox.destroy(); + + this._fire('deactivate'); + this._active = null; }; @@ -79,6 +89,8 @@ DirectEditing.prototype.complete = function() { active.provider.update(active.element, text, active.context.text); } + this._fire('complete'); + this.close(); }; @@ -137,6 +149,8 @@ DirectEditing.prototype.activate = function(element) { context: context, provider: provider }; + + this._fire('activate'); } return !!context;
feat(plug-in): fire events during editing operation
bpmn-io_diagram-js-direct-editing
train
js
35217b9a7868cbfb80dc792467e4af7e3f50ffbd
diff --git a/packages/jsdoc2spec/src/cli.js b/packages/jsdoc2spec/src/cli.js index <HASH>..<HASH> 100755 --- a/packages/jsdoc2spec/src/cli.js +++ b/packages/jsdoc2spec/src/cli.js @@ -99,7 +99,7 @@ const runWithJSDoc = (files) => { const temp = path.join(__dirname, 'temp.conf.json'); fs.writeFileSync(temp, JSON.stringify(cfg, null, 2)); try { - s = cp.execSync('jsdoc -c ./temp.conf.json -p -X', { cwd: __dirname }); + s = cp.execSync('npx jsdoc -c ./temp.conf.json -p -X', { cwd: __dirname }); } finally { fs.unlinkSync(temp); }
fix: fix jsdoc runner to use npx
miralemd_scriptappy
train
js
03a5fc1547cb314acd91b301d6a9dd749ec028d8
diff --git a/lib/tool.js b/lib/tool.js index <HASH>..<HASH> 100644 --- a/lib/tool.js +++ b/lib/tool.js @@ -204,14 +204,20 @@ class WebpackTool { return compiler; } - createDevServerOptions(webpackConfig, devServer) { + createDevServerOptions(webpackConfig, devServer = {}) { const { output } = webpackConfig; + const { headers = {}, index, methods, mimeTypes, publicPath, writeToDisk } = devServer; return { + index, + writeToDisk, + mimeTypes, + methods, + publicPath: publicPath || output.publicPath, headers: { 'x-webpack': 'easywebpack', 'cache-control': 'max-age=0', + ...headers, }, - publicPath: output.publicPath }; }
fix: add webpack-dev-middleware missing options
easy-team_webpack-tool
train
js
cda65b49d06b2e0a8ece8dfd04c39376f77f05b0
diff --git a/webapps/client/scripts/repository/controllers/cam-cockpit-repository-view-ctrl.js b/webapps/client/scripts/repository/controllers/cam-cockpit-repository-view-ctrl.js index <HASH>..<HASH> 100644 --- a/webapps/client/scripts/repository/controllers/cam-cockpit-repository-view-ctrl.js +++ b/webapps/client/scripts/repository/controllers/cam-cockpit-repository-view-ctrl.js @@ -157,7 +157,6 @@ define([ updateSilently({ deployment: focused.id, resource: null, - resourceName: null, viewbox: null, editMode: null }); @@ -169,7 +168,6 @@ define([ updateSilently({ deployment: null, resource: null, - resourceName: null, viewbox: null, editMode: null }); @@ -208,7 +206,7 @@ define([ }; } else if (resourceName) { - + resources = resources || []; for(var i=0, resource; !!(resource = resources[i]); i++) { if (resource.name === resourceName) { return {
chore(repository): keep resource name related to CAM-<I>
camunda_camunda-bpm-platform
train
js
d50589cb46565a3f359872c32dfe02a6b61b864d
diff --git a/src/index.js b/src/index.js index <HASH>..<HASH> 100644 --- a/src/index.js +++ b/src/index.js @@ -1 +1,4 @@ -module.exports = require('./dav'); +module.exports = { + dav: require('./dav'), + web3: require('./web3wrapper') +}; \ No newline at end of file
fix: expose web3 from dav-js
DAVFoundation_dav-js
train
js
5ebeb91c78f2decf2e8d7a8c6c5696cd6f283465
diff --git a/docs/app/Components/ComponentDoc/ComponentExample.js b/docs/app/Components/ComponentDoc/ComponentExample.js index <HASH>..<HASH> 100644 --- a/docs/app/Components/ComponentDoc/ComponentExample.js +++ b/docs/app/Components/ComponentDoc/ComponentExample.js @@ -138,7 +138,7 @@ class ComponentExample extends Component { resetJSX = () => { const { sourceCode } = this.state const original = this.getOriginalSourceCode() - if (sourceCode !== original && confirm('Loose your changes?')) { // eslint-disable-line no-alert + if (sourceCode !== original && confirm('Lose your changes?')) { // eslint-disable-line no-alert this.setState({ sourceCode: original }) this.renderSourceCode() }
fix(ComponentExample): typo "loose" to "lose" (#<I>) fix(ComponentExample): typo "loose" to "lose"
Semantic-Org_Semantic-UI-React
train
js
f5bff24fa4112e43d6a6ee664b93a3d0c02add12
diff --git a/src/Cursor.js b/src/Cursor.js index <HASH>..<HASH> 100644 --- a/src/Cursor.js +++ b/src/Cursor.js @@ -11,6 +11,8 @@ export * from './eraseRegions'; * * @see http://www.termsys.demon.co.uk/vtansi.htm * @see http://misc.flogisoft.com/bash/tip_colors_and_formatting + * @see http://man7.org/linux/man-pages/man4/console_codes.4.html + * @see http://www.x.org/docs/xterm/ctlseqs.pdf * @since 1.0.0 */ export class Cursor {
docs(cursor): Add few useful links to comments
kittikjs_cursor
train
js
75cc56843a5066c2a357082ff85b3dc51ff44748
diff --git a/docs/conf.py b/docs/conf.py index <HASH>..<HASH> 100644 --- a/docs/conf.py +++ b/docs/conf.py @@ -21,8 +21,11 @@ from pathlib import Path on_rtd = os.environ.get('READTHEDOCS') == 'True' if on_rtd: - subprocess.run('pip install -U "pip>=18.0" "setuptools>=40.1"', shell=True) - subprocess.run('pip install -e "..[docs]"', shell=True) + try: + from ai.backend.client import request # noqa + except ImportError: + subprocess.run('pip install -U "pip>=18.0" "setuptools>=40.1"', shell=True) + subprocess.run('pip install -e "..[docs]"', shell=True) # -- Project information -----------------------------------------------------
docs: Install dependencies only when not installed
lablup_backend.ai-client-py
train
py
3e1d8474a952dea8008ccb34bc28fd94b0120d71
diff --git a/lib/platform/github/gh-got-wrapper.js b/lib/platform/github/gh-got-wrapper.js index <HASH>..<HASH> 100644 --- a/lib/platform/github/gh-got-wrapper.js +++ b/lib/platform/github/gh-got-wrapper.js @@ -11,13 +11,11 @@ function sleep(ms) { async function get(path, opts, retries = 5) { const method = opts && opts.method ? opts.method : 'get'; + logger.debug({ retries }, `${method.toUpperCase()} ${path}`); if (method === 'get' && cache[path]) { logger.debug({ path }, 'Returning cached result'); return cache[path]; } - if (retries === 5) { - logger.debug(`${method.toUpperCase()} ${path}`); - } try { if (appMode) { /* eslint-disable no-param-reassign */
refactor: always debug log github get requests
renovatebot_renovate
train
js
f1f88e4443d0d25b0d904caaf8f01fa639d2b120
diff --git a/lib/manager/npm/post-update/index.js b/lib/manager/npm/post-update/index.js index <HASH>..<HASH> 100644 --- a/lib/manager/npm/post-update/index.js +++ b/lib/manager/npm/post-update/index.js @@ -170,12 +170,7 @@ async function writeExistingFiles(config, packageFiles) { if (packageFile.npmrc) { logger.debug(`Writing .npmrc to ${basedir}`); await fs.outputFile(upath.join(basedir, '.npmrc'), packageFile.npmrc); - } else if ( - config.npmrc && - (packageFile.hasYarnLock || - packageFile.hasPackageLock || - config.lernaLockFile) - ) { + } else if (config.npmrc) { logger.debug('Writing repo .npmrc to package file dir'); await fs.outputFile(upath.join(basedir, '.npmrc'), config.npmrc); }
fix: always write config.npmrc
renovatebot_renovate
train
js
82eca716d8c1fad36636f594d0974ad99acb0410
diff --git a/src/Slide.js b/src/Slide.js index <HASH>..<HASH> 100644 --- a/src/Slide.js +++ b/src/Slide.js @@ -1,3 +1,5 @@ +import { Shape } from './Shape'; + export class Slide { /** * Creates new Slide instance @@ -13,6 +15,8 @@ export class Slide { * @returns {Slide} */ addShape(shape) { + if (!(shape instanceof Shape)) throw new Error('You must provide Shape instance'); + this._shapes.push(shape); return this; }
feat(shape): Adds checking for Shape instance when you add it to Slide
ghaiklor_kittik
train
js
51b164953ca207124a327c69f3e3e59277277476
diff --git a/lib/plugins/load-plugin.js b/lib/plugins/load-plugin.js index <HASH>..<HASH> 100644 --- a/lib/plugins/load-plugin.js +++ b/lib/plugins/load-plugin.js @@ -54,8 +54,7 @@ module.exports = function(options, callback) { } }); } - - var execPlugin = require(options.value); + var port, uiPort, rulesPort, resRulesPort, statusPort, tunnelRulesPort, tunnelPort; var count = 0; var callbackHandler = function() { @@ -71,7 +70,13 @@ module.exports = function(options, callback) { }); } }; - + + try { + require.resolve(options.value); + } catch(e) { + return callbackHandler(); + } + var execPlugin = require(options.value); var startServer = execPlugin.pluginServer || execPlugin.server || execPlugin; if (typeof startServer == 'function') { ++count;
chore: Prevents modules from causing errors due to main methods
avwo_whistle
train
js
becfd1939f1af6f87d884b2ab73e4a2dba3f796a
diff --git a/packages/react/src/components/TileGroup/TileGroup.js b/packages/react/src/components/TileGroup/TileGroup.js index <HASH>..<HASH> 100644 --- a/packages/react/src/components/TileGroup/TileGroup.js +++ b/packages/react/src/components/TileGroup/TileGroup.js @@ -127,7 +127,9 @@ export default class TileGroup extends React.Component { return ( <fieldset className={className} disabled={disabled}> {this.renderLegend(legend)} - {this.getRadioTiles()} + <div> + {this.getRadioTiles()} + </div> </fieldset> ); }
fix(TileGroup): Wrap RadioTiles inside TileGroup (#<I>) * Wrap RadioTiles inside TileGroup This adds a wrapper div element around the RadioTiles inside the TileGroup component so that a flex layout can be applied to the tiles to make them render horizontally. * Remove the className on the wrapper div
carbon-design-system_carbon-components
train
js
c525520f04e865e5fe28007cc7735dcb74c23961
diff --git a/components/datepicker/index.js b/components/datepicker/index.js index <HASH>..<HASH> 100644 --- a/components/datepicker/index.js +++ b/components/datepicker/index.js @@ -269,7 +269,9 @@ export default class Datepicker extends Intact { const input = this.refs.input; input.focus(); setTimeout(() => { - input.blur(); + if (!this.destroyed) { + input.blur(); + } }); } }
fix(Datepicker): does not focus when destroyed
ksc-fe_kpc
train
js
ab7d90d1f8ac62e4e8db48ca9e85b97aa56bc0e8
diff --git a/packages/webpack/mixins/render/mixin.core.js b/packages/webpack/mixins/render/mixin.core.js index <HASH>..<HASH> 100644 --- a/packages/webpack/mixins/render/mixin.core.js +++ b/packages/webpack/mixins/render/mixin.core.js @@ -57,7 +57,7 @@ class WebpackRenderMixin extends Mixin { describe: 'Statically build locations', type: 'boolean', }; - if (command === 'start') { + if (command === 'start' && process.env.NODE_ENV !== 'production') { builder.static.implies = ['static', 'production']; builder.static.describe += ' (requires --production, -p)'; }
fix(webpack): allow "start -s" when NODE_ENV=production
untool_untool
train
js
2fecd945690a939931329c1aab29e12c3e773c67
diff --git a/internal/pipe/snapcraft/snapcraft.go b/internal/pipe/snapcraft/snapcraft.go index <HASH>..<HASH> 100644 --- a/internal/pipe/snapcraft/snapcraft.go +++ b/internal/pipe/snapcraft/snapcraft.go @@ -201,14 +201,12 @@ func (Pipe) Publish(ctx *context.Context) error { return pipe.ErrSkipPublishEnabled } snaps := ctx.Artifacts.Filter(artifact.ByType(artifact.PublishableSnapcraft)).List() - g := semerrgroup.New(ctx.Parallelism) for _, snap := range snaps { - snap := snap - g.Go(func() error { - return push(ctx, snap) - }) + if err := push(ctx, snap); err != nil { + return err + } } - return g.Wait() + return nil } func create(ctx *context.Context, snap config.Snapcraft, arch string, binaries []*artifact.Artifact) error {
fix: do not push snaps concurrently (#<I>) It seems that the error I get sometimes (#<I>) is related to snap push not being able to work concurrently. I'm not a <I>% sure though, so I'll try this and see how it goes. If the error still happens, we can ignore the error or retry. closes #<I>
goreleaser_goreleaser
train
go
8ca5bdda15355c0ea7d8620cce679ae529477594
diff --git a/samtranslator/parser/parser.py b/samtranslator/parser/parser.py index <HASH>..<HASH> 100644 --- a/samtranslator/parser/parser.py +++ b/samtranslator/parser/parser.py @@ -63,7 +63,7 @@ class Parser: validation_errors = validator.validate(sam_template) if validation_errors: - LOG.warn("Template schema validation reported the following errors: " + ", ".join(validation_errors)) + LOG.warning("Template schema validation reported the following errors: %s", validation_errors) except Exception as e: # Catching any exception and not re-raising to make sure any validation process won't break transform LOG.exception("Exception from SamTemplateValidator: %s", e)
fix: fix validation errors log message that calls join on a string (#<I>)
awslabs_serverless-application-model
train
py
16f185e5447bc58ed78e924f283bc9ea2d6af131
diff --git a/src/components/zoom/zoom.js b/src/components/zoom/zoom.js index <HASH>..<HASH> 100644 --- a/src/components/zoom/zoom.js +++ b/src/components/zoom/zoom.js @@ -646,7 +646,12 @@ export default { swiper.zoom.onTouchEnd(e); }, doubleTap(swiper, e) { - if (swiper.params.zoom.enabled && swiper.zoom.enabled && swiper.params.zoom.toggle) { + if ( + !swiper.animating && + swiper.params.zoom.enabled && + swiper.zoom.enabled && + swiper.params.zoom.toggle + ) { swiper.zoom.toggle(e); } },
fix(core): don't toggle zoom during transition Fixes #<I>
nolimits4web_swiper
train
js
010371aa2c6dba14426f10284057d4d52a89e767
diff --git a/packages/eslint-config-import/index.js b/packages/eslint-config-import/index.js index <HASH>..<HASH> 100644 --- a/packages/eslint-config-import/index.js +++ b/packages/eslint-config-import/index.js @@ -1,6 +1,6 @@ module.exports = { "parser": "babel-eslint", - "extends": "airbnb-base/rules/import", + "extends": "airbnb-base/rules/imports", "env": { "browser": true, "node": true,
fix(eslint-config-import): fix typo in airbnb rules name affects: @goldwasserexchange/eslint-config-import the rule package is called imports and not import
goldwasserexchange_public
train
js
15a99e22d4b761845abc7e7644b88d7eb45ee538
diff --git a/publish.js b/publish.js index <HASH>..<HASH> 100644 --- a/publish.js +++ b/publish.js @@ -21,7 +21,7 @@ module.exports = function() { function putThemInVendorDir (filepath) { return 'vendor/' + path.basename(filepath); - }g + } return { humaName : 'UI.Ace',
fix(publisher): remove typo
angular-ui_ui-ace
train
js
959a8da1921333699ca78f1e646e1906d5e5ded2
diff --git a/test/test_publish.py b/test/test_publish.py index <HASH>..<HASH> 100644 --- a/test/test_publish.py +++ b/test/test_publish.py @@ -11,7 +11,6 @@ import shutil import six from asv import config -from asv.commands.publish import Publish from asv import util @@ -61,7 +60,6 @@ def test_publish(tmpdir): shutil.copyfile(join(RESULT_DIR, 'cheetah', 'machine.json'), join(result_dir, 'cheetah', 'machine.json')) - # Publish the synthesized data conf = config.Config.from_json( {'benchmark_dir': BENCHMARK_DIR,
test: Remove unused import and too many blank line
airspeed-velocity_asv
train
py
eaa87a7251ce7587f34e61f40464d0f31e23d17e
diff --git a/example/src/components/IconPage.react.js b/example/src/components/IconPage.react.js index <HASH>..<HASH> 100644 --- a/example/src/components/IconPage.react.js +++ b/example/src/components/IconPage.react.js @@ -36,7 +36,7 @@ function IconPage(): React.Node { {iconSets.map(iconSet => ( <Card key={iconSet.prefix}> <Card.Header> - <Card.Title>Feather Icons</Card.Title> + <Card.Title>{iconSet.title}</Card.Title> </Card.Header> <Card.Body> <Grid.Row>
feat(IconPage): Include the title
tabler_tabler-react
train
js
1339556b7e1e6ca52a184b5cb48e41adee61d273
diff --git a/api/models.py b/api/models.py index <HASH>..<HASH> 100644 --- a/api/models.py +++ b/api/models.py @@ -444,7 +444,7 @@ class Release(UuidAuditedModel): config = models.ForeignKey('Config') build = models.ForeignKey('Build') # NOTE: image contains combined build + config, ready to run - image = models.CharField(max_length=256) + image = models.CharField(max_length=256, default=settings.DEFAULT_BUILD) class Meta: get_latest_by = 'created' diff --git a/api/tests/test_release.py b/api/tests/test_release.py index <HASH>..<HASH> 100644 --- a/api/tests/test_release.py +++ b/api/tests/test_release.py @@ -60,6 +60,7 @@ class ReleaseTest(TransactionTestCase): self.assertIn('config', response.data) self.assertIn('build', response.data) self.assertEquals(release1['version'], 1) + self.assertEquals(release1['image'], 'deis/helloworld') # check to see that a new release was created url = '/api/apps/{app_id}/releases/v2'.format(**locals()) response = self.client.get(url)
fix(controller): set default release image If you scale an application with `deis scale cmd=1` before an application has been pushed, it should deploy deis/helloworld. However, the initial release (v1) does not have a image set for the release, only the build. Setting the default to deis/helloworld fixes the "scale before deploy" problem.
deis_controller-sdk-go
train
py,py
4234a1f7056ec707e547a69b14babe1d691568a8
diff --git a/components/tree/node.js b/components/tree/node.js index <HASH>..<HASH> 100644 --- a/components/tree/node.js +++ b/components/tree/node.js @@ -1,8 +1,9 @@ let uniqueId = 0; +const prefix = '__$_'; export default class Node { static createNode = function(data, parent, tree, needRecheckNodes) { - const key = data.key == null ? uniqueId++ : data.key; + const key = data.key == null ? `${prefix}${uniqueId++}` : data.key; // if the node has been set to checked // we should set its children to checked // and recheck the parent to set to checked or indeterminate @@ -64,7 +65,7 @@ export default class Node { this.indeterminate = false; this.tree._updateCheckedKeys(this); - + if (this.tree.get('uncorrelated')) return; const children = this.children; @@ -85,7 +86,7 @@ export default class Node { if (!parent || parent === this.tree.root) return; let checkedCount = 0; - let count = 0; + let count = 0; let indeterminate; const children = parent.children; for (let i = 0; i < children.length; i++) {
fix(Tree): avoid conflicting with custom number key, close #<I>
ksc-fe_kpc
train
js
054c066b74bf3face1a7a3a50068478bd7140e95
diff --git a/src/components/tabs/js/tabDirective.js b/src/components/tabs/js/tabDirective.js index <HASH>..<HASH> 100644 --- a/src/components/tabs/js/tabDirective.js +++ b/src/components/tabs/js/tabDirective.js @@ -67,12 +67,11 @@ function MdTab () { label = angular.element('<md-tab-label></md-tab-label>'); if (attr.label) label.text(attr.label); else label.append(element.contents()); - } - - if (body.length == 0) { - var contents = element.contents().detach(); - body = angular.element('<md-tab-body></md-tab-body>'); - body.append(contents); + if (body.length == 0) { + var contents = element.contents().detach(); + body = angular.element('<md-tab-body></md-tab-body>'); + body.append(contents); + } } element.append(label);
fix(tabs): adds proper detection for bodyless tabs Closes #<I>
angular_material
train
js
4c3fdedcc4e574d19f4ac3e04ff01d99044a5e1f
diff --git a/lib/grunt/tasks/release.js b/lib/grunt/tasks/release.js index <HASH>..<HASH> 100644 --- a/lib/grunt/tasks/release.js +++ b/lib/grunt/tasks/release.js @@ -23,7 +23,7 @@ var path = require("path"), // remove redundancies in css filenames fs.renameSync(path.join(paths.dist, "lib/fine-uploader.css"), path.join(paths.dist, "lib/legacy.css")) fs.renameSync(path.join(paths.dist, "lib/fine-uploader-gallery.css"), path.join(paths.dist, "lib/gallery.css")) - fs.renameSync(path.join(paths.dist, "lib/fine-uploader-new.css"), path.join(paths.dist, "lib/new.css")) + fs.renameSync(path.join(paths.dist, "lib/fine-uploader-new.css"), path.join(paths.dist, "lib/rows.css")) // copy over the CommonJS index files fsSync.copy(path.join(paths.commonJs), path.join(paths.dist, "lib"));
feat(build): better name for modern row-layout stylesheet Only used in new lib directory. #<I>
FineUploader_fine-uploader
train
js
441fd184e2e39e35f609bec7d6badd6ca5797eea
diff --git a/src/api/center.js b/src/api/center.js index <HASH>..<HASH> 100644 --- a/src/api/center.js +++ b/src/api/center.js @@ -1,8 +1,8 @@ const toArray = require('../core/utils/toArray') -/** +/** NOTE: this is not functional YET !! * centers the given object(s) on the given axis - * @param {[Object]} object(s) the shapes to center + * @param {Object|Array} object(s) the shapes to center * @param {Object} options */ const center = (objects, options) => { diff --git a/src/core/utils/canonicalize.js b/src/core/utils/canonicalize.js index <HASH>..<HASH> 100644 --- a/src/core/utils/canonicalize.js +++ b/src/core/utils/canonicalize.js @@ -7,7 +7,7 @@ const {fromSides} = require('../CAGFactories') /** * Returns a cannoicalized version of the input csg/cag : ie every very close * points get deduplicated - * @returns {CSG CAG} + * @returns {CSG|CAG} * @example * let rawInput = someCSGORCAGMakingFunction() * let canonicalized= canonicalize(rawInput)
fix(docstring): fixed a few bad docstrings which prevented docs from being generated (#<I>)
jscad_csg.js
train
js,js
2085166396cce491463a3a9dab9d60b3463f2f2c
diff --git a/fetcher/nvd/json/nvd.go b/fetcher/nvd/json/nvd.go index <HASH>..<HASH> 100644 --- a/fetcher/nvd/json/nvd.go +++ b/fetcher/nvd/json/nvd.go @@ -3,6 +3,7 @@ package json import ( "encoding/json" "fmt" + "sort" "strings" "time" @@ -31,6 +32,10 @@ func FetchConvert(metas []models.FeedMeta) (cves []models.CveDetail, err error) fmt.Errorf("Failed to fetch. err: %s", err) } + // The redis-put-process overwrite without referring the last modified date. + // Sort so that recent-feed is the last element. + sort.Slice(results, func(i, j int) bool { return results[i].URL < results[j].URL }) + errs := []error{} for _, res := range results { var nvd, nvdIncludeRejectedCve NvdJSON
fix(fetch-nvd): prevent overwriting with old cve-details on redis (#<I>)
kotakanbe_go-cve-dictionary
train
go
43127f2a305df29b3cb356d84d886fca831b5e6f
diff --git a/modules/router5.js b/modules/router5.js index <HASH>..<HASH> 100644 --- a/modules/router5.js +++ b/modules/router5.js @@ -145,6 +145,7 @@ class Router5 { } else { // Initialise router with provided start state this.lastKnownState = startState + browser.replaceState(this.lastKnownState, '', this.buildUrl(startState.name, startState.params)) cb(null, startState) } // Listen to popstate
fix: replace history state on start when supplying a starting state
router5_router5
train
js
a66644f1d7284718a8a9ab7fbff9a3d0415c180f
diff --git a/percy/percy.test.js b/percy/percy.test.js index <HASH>..<HASH> 100644 --- a/percy/percy.test.js +++ b/percy/percy.test.js @@ -18,7 +18,10 @@ jest.setTimeout(600000) const PERCY_EXTRA_WAIT = 5000 const percySnapshotWithWait = async (page, name) => { await page.waitForTimeout(PERCY_EXTRA_WAIT) - await percySnapshot(page, name, { enableJavascript: true }) + await percySnapshot(page, name, { + enableJavascript: true, + percyCSS: '.link-button.pull-right: {display:none}' + }) } let browser
ci(percy): hide refresh button that won't let itself be standardized
opentripplanner_otp-react-redux
train
js
4e3a5fc7aa69c14673a73e694513edceb72e6967
diff --git a/src/input.js b/src/input.js index <HASH>..<HASH> 100644 --- a/src/input.js +++ b/src/input.js @@ -60,9 +60,6 @@ const createInputCaret = (element, ctx) => { const format = (val) => { let value = val.replace(/<|>|`|"|&/g, '?') .replace(/\r\n|\r|\n/g,'<br/>'); - if (/firefox/i.test(navigator.userAgent)) { - value = value.replace(/\s/g, '&nbsp;'); - } return value; };
fix(firefox): do not convert space characters to nbsp
deshiknaves_caret-pos
train
js
d1f7582633827b53612746096d738b33697999de
diff --git a/src/react/get-children.js b/src/react/get-children.js index <HASH>..<HASH> 100644 --- a/src/react/get-children.js +++ b/src/react/get-children.js @@ -1,9 +1,13 @@ import React from 'react'; +function isChildSwiperSlide(child) { + return child.type && child.type.displayName.includes('SwiperSlide'); +} + function processChildren(c) { const slides = []; React.Children.toArray(c).forEach((child) => { - if (child.type && child.type.displayName === 'SwiperSlide') { + if (isChildSwiperSlide(child)) { slides.push(child); } else if (child.props && child.props.children) { processChildren(child.props.children).forEach((slide) => slides.push(slide)); @@ -23,7 +27,7 @@ function getChildren(c) { }; React.Children.toArray(c).forEach((child) => { - if (child.type && child.type.displayName === 'SwiperSlide') { + if (isChildSwiperSlide(child)) { slides.push(child); } else if (child.props && child.props.slot && slots[child.props.slot]) { slots[child.props.slot].push(child);
feat(react): Allow SwiperSlide children as long as displayName includes SwiperSlide (#<I>) Refactor getChildren to return all child components whose names contains SwiperSlide to allow for custom components in Swiper that do not have a displayName of SwiperSlide. Adds helper function isChildSwiperSlide(child) to check if react child is a child which contains SwiperSlide in its displayName.
nolimits4web_swiper
train
js
29ab32a95f24cf7ec92e373cccb7ca921c114fdd
diff --git a/fructose/index.js b/fructose/index.js index <HASH>..<HASH> 100644 --- a/fructose/index.js +++ b/fructose/index.js @@ -7,4 +7,4 @@ AppRegistry.registerComponent("storybooknative", () => Fructose(getStories, { platform: "native" }) ); -export default Fructose(getStories); +export default Fructose(getStories, { platform: "native" });
fix: adding the relevant config to allow expo to work with fructose app (#<I>) * fix: adding the relevant config to allow expo to work with fructose app
newsuk_times-components
train
js
b7691cb9e8b76209cb8f5a5c08000a51f127f984
diff --git a/providers/nodebb/category.js b/providers/nodebb/category.js index <HASH>..<HASH> 100644 --- a/providers/nodebb/category.js +++ b/providers/nodebb/category.js @@ -230,7 +230,7 @@ exports.bindCategory = function bindCategory(forum) { * Add a topic to this category * * @public - * + * * @param {string} title The title of the topic * @param {string} body The body of the first post of the topic *
chore: Fix trailing space in jsdoc because eslint hates my jsdoc template
SockDrawer_SockBot
train
js
a3e2a051ad1a63db8475ecb2b13295b92cd92c54
diff --git a/bin/run.js b/bin/run.js index <HASH>..<HASH> 100755 --- a/bin/run.js +++ b/bin/run.js @@ -178,6 +178,9 @@ const results = zip(pool, tests).pipe( ); const emitter = new ResultsEmitter(results); +emitter.on('fail', function () { + process.exitCode = 1; +}); reporter(emitter, reporterOpts); function printVersion() {
feat: set exitCode to 1 when a test fails
bterlson_test262-harness
train
js
087dc13965076ffca70170e241a2e209df31fe75
diff --git a/internal/http/server.go b/internal/http/server.go index <HASH>..<HASH> 100644 --- a/internal/http/server.go +++ b/internal/http/server.go @@ -90,7 +90,7 @@ func (srv *Server) Start(ctx context.Context) (err error) { if atomic.LoadUint32(&srv.inShutdown) != 0 { // To indicate disable keep-alives w.Header().Set("Connection", "close") - w.WriteHeader(http.StatusForbidden) + w.WriteHeader(http.StatusServiceUnavailable) w.Write([]byte(http.ErrServerClosed.Error())) w.(http.Flusher).Flush() return
fix: server in shutdown should return <I> instead of <I> (#<I>) various situations where the client is retrying the request server going through shutdown might incorrectly send <I> which is a non-retriable error, this PR allows for clients when they retry an attempt to go to another healthy pod or server in a distributed cluster - assuming it is a properly load-balanced setup.
minio_minio
train
go
1058a8e3f1d55c33b2c56b8ac192f8ed856a4fe0
diff --git a/cmd/influxd/upgrade/upgrade.go b/cmd/influxd/upgrade/upgrade.go index <HASH>..<HASH> 100644 --- a/cmd/influxd/upgrade/upgrade.go +++ b/cmd/influxd/upgrade/upgrade.go @@ -357,8 +357,10 @@ func runUpgradeE(*cobra.Command, []string) error { options.source.walDir = v1Config.Data.WALDir options.source.dbURL = v1Config.dbURL() } else { - // Otherwise, assume a standard directory layout. + // Otherwise, assume a standard directory layout + // and the default port on localhost. options.source.populateDirs() + options.source.dbURL = (&configV1{}).dbURL() } err = validatePaths(&options.source, &options.target) @@ -453,7 +455,10 @@ func runUpgradeE(*cobra.Command, []string) error { ) } - log.Info("Upgrade successfully completed. Start service now") + log.Info( + "Upgrade successfully completed. Start the influxd service now, then log in", + zap.String("login_url", options.source.dbURL), + ) return nil }
fix(upgrade): add DB URL to log message at end up upgrade (#<I>)
influxdata_influxdb
train
go
3bca5caa5c0cfec3156c3b576948184a4a820bb3
diff --git a/GEOparse/GEOparse.py b/GEOparse/GEOparse.py index <HASH>..<HASH> 100755 --- a/GEOparse/GEOparse.py +++ b/GEOparse/GEOparse.py @@ -305,7 +305,13 @@ def parse_GDS_columns(lines, subsets): subset_ids = defaultdict(dict) for subsetname, subset in iteritems(subsets): for expid in subset.metadata["sample_id"][0].split(","): - pass + try: + subset_type = subset.get_type() + subset_ids[subset_type][expid] = \ + subset.metadata['description'][0] + except Exception as err: + logger.error("Error processing subsets: %s for subset %s" % ( + subset.get_type(), subsetname)) return df.join(DataFrame(subset_ids))
fix: #<I> Roll back to subset type check
guma44_GEOparse
train
py
bb4c6f2d931858389e3f8518242f50f46e349dce
diff --git a/DrdPlus/Codes/Properties/CharacteristicForGameCode.php b/DrdPlus/Codes/Properties/CharacteristicForGameCode.php index <HASH>..<HASH> 100644 --- a/DrdPlus/Codes/Properties/CharacteristicForGameCode.php +++ b/DrdPlus/Codes/Properties/CharacteristicForGameCode.php @@ -14,7 +14,7 @@ class CharacteristicForGameCode extends AbstractCode const SHOOTING = CombatCharacteristicCode::SHOOTING; const ATTACK_NUMBER = 'attack_number'; - const DEFENSE_AGAINST_SHOOTING = 'defense_against_shooting'; + const DEFENSE_NUMBER_AGAINST_SHOOTING = 'defense_number_against_shooting'; const DEFENSE_NUMBER = 'defense_number'; const ENCOUNTER_RANGE = 'encounter_range'; const FIGHT = 'fight'; @@ -32,7 +32,7 @@ class CharacteristicForGameCode extends AbstractCode self::DEFENSE, self::SHOOTING, self::ATTACK_NUMBER, - self::DEFENSE_AGAINST_SHOOTING, + self::DEFENSE_NUMBER_AGAINST_SHOOTING, self::DEFENSE_NUMBER, self::ENCOUNTER_RANGE, self::FIGHT,
fix: Defense number against shooting renamed
drdplusinfo_drdplus-codes
train
php
c451e58b5b46d8692fa5bf906f036131dce81289
diff --git a/algolia/analytics/responses_ab_testing.go b/algolia/analytics/responses_ab_testing.go index <HASH>..<HASH> 100644 --- a/algolia/analytics/responses_ab_testing.go +++ b/algolia/analytics/responses_ab_testing.go @@ -36,6 +36,7 @@ type ABTestResponse struct { ClickSignificance float64 `json:"clickSignificance"` ConversionSignificance float64 `json:"conversionSignificance"` CreatedAt time.Time `json:"createdAt"` + UpdatedAt time.Time `json:"updatedAt"` EndAt time.Time `json:"endAt"` Name string `json:"name"` Status string `json:"status"` @@ -57,5 +58,5 @@ type VariantResponse struct { TrackedSearchCount int `json:"trackedSearchCount"` TrafficPercentage int `json:"trafficPercentage"` UserCount int `json:"userCount"` - CustomSearchParameters *search.QueryParams `json:"customSearchParameters"` + CustomSearchParameters *search.QueryParams `json:"customSearchParameters,omitempty"` }
fix(analytics): add UpdatedAt field to ABTestResponse (#<I>)
algolia_algoliasearch-client-go
train
go
7b77b36ddb8a72ad084cfed6c3f20e8982db4fa1
diff --git a/packages/cli/src/link/ios/getTargets.js b/packages/cli/src/link/ios/getTargets.js index <HASH>..<HASH> 100644 --- a/packages/cli/src/link/ios/getTargets.js +++ b/packages/cli/src/link/ios/getTargets.js @@ -40,4 +40,4 @@ export default function getTargets(project) { false, }; }); -}; +}
fix: make prettier happy (#<I>)
react-native-community_cli
train
js
c6a9f93542b1dc417f002a3b7916862c3313ff83
diff --git a/gdx-ai/src/com/badlogic/gdx/ai/btree/decorator/Include.java b/gdx-ai/src/com/badlogic/gdx/ai/btree/decorator/Include.java index <HASH>..<HASH> 100644 --- a/gdx-ai/src/com/badlogic/gdx/ai/btree/decorator/Include.java +++ b/gdx-ai/src/com/badlogic/gdx/ai/btree/decorator/Include.java @@ -94,12 +94,15 @@ public class Include<E> extends Decorator<E> { Include<E> include = (Include<E>)task; include.subtree = subtree; include.lazy = lazy; + include.guard = guard; return task; } private Task<E> createSubtreeRootTask () { - return BehaviorTreeLibraryManager.getInstance().createRootTask(subtree); + Task<E> rootTask = BehaviorTreeLibraryManager.getInstance().createRootTask(subtree); + rootTask.setGuard(guard); + return rootTask; } @Override
fix(BehaviorTree): properly copy & clone the IncludeTask guard to the generated tree.
libgdx_gdx-ai
train
java
02bc9680148675e14d9bbcc6afad2b506daee2cb
diff --git a/hyperid.js b/hyperid.js index <HASH>..<HASH> 100644 --- a/hyperid.js +++ b/hyperid.js @@ -62,10 +62,17 @@ function pad (count) { function baseId (id, urlSafe) { var base64Id = Buffer.from(parser.parse(id)).toString('base64') + var l = base64Id.length if (urlSafe) { - return base64Id.replace(/\+/g, '_').replace(/\//g, '-').replace(/==$/, '-') + if (base64Id[l - 2] === '=' && base64Id[l - 1] === '=') { + base64Id = base64Id.substr(0, l - 2) + '-' + } + return base64Id.replace(/\+/g, '_').replace(/\//g, '-') + } + if (base64Id[l - 2] === '=' && base64Id[l - 1] === '=') { + return base64Id.substr(0, l - 2) + '/' } - return base64Id.replace(/==$/, '/') + return base64Id } function decode (id, opts) {
feat: avoid regex for end of id (#<I>)
mcollina_hyperid
train
js
ee5e6c418d14c94a2b269a6dc159ed239bde85d0
diff --git a/src/network/index.js b/src/network/index.js index <HASH>..<HASH> 100644 --- a/src/network/index.js +++ b/src/network/index.js @@ -47,14 +47,12 @@ module.exports = class Network { } _onConnection (conn) { + log('connected') pull( conn, lp.decode(), - pull.collect((err, msgs) => msgs.forEach((data) => { + pull.through((data) => { log('raw message', data) - if (err) { - return this.bitswap._receiveError(err) - } let msg try { msg = Message.fromProto(data) @@ -67,7 +65,12 @@ module.exports = class Network { } this.bitswap._receiveMessage(peerInfo.id, msg) }) - })) + }), + pull.onEnd((err) => { + if (err) { + return this.bitswap._receiveError(err) + } + }) ) } @@ -105,6 +108,7 @@ module.exports = class Network { } this.libp2p.dialByPeerInfo(peerInfo, PROTOCOL_IDENTIFIER, (err, conn) => { + log('dialed %s', peerInfo.id.toB58String(), err) if (err) { return cb(err) }
fix(network): correct msg processing
ipfs_js-ipfs-bitswap
train
js
f9a92f6ccd88316720339808c27e2379d46ec48b
diff --git a/src/connection.js b/src/connection.js index <HASH>..<HASH> 100644 --- a/src/connection.js +++ b/src/connection.js @@ -1542,7 +1542,7 @@ export class Connection { const id = ++this._slotSubscriptionCounter; this._slotSubscriptions[id] = { callback, - subscriptionId: id, + subscriptionId: null, }; this._updateSubscriptions(); return id;
fix: broken rpc slot change subscription
solana-labs_solana-web3.js
train
js
e5a3a1e1d3e25238a173e28382ba7002472f5724
diff --git a/src/main/resources/META-INF/resources/primefaces/schedule/1-schedule.js b/src/main/resources/META-INF/resources/primefaces/schedule/1-schedule.js index <HASH>..<HASH> 100644 --- a/src/main/resources/META-INF/resources/primefaces/schedule/1-schedule.js +++ b/src/main/resources/META-INF/resources/primefaces/schedule/1-schedule.js @@ -78,7 +78,9 @@ PrimeFaces.widget.Schedule = PrimeFaces.widget.DeferredWidget.extend({ this.cfg.eventClick = function(calEvent, jsEvent, view) { if (calEvent.url) { - window.open(calEvent.url, $this.cfg.urlTarget); + var targetWindow = window.open('', $this.cfg.urlTarget); + targetWindow.opener = null; + targetWindow.location = calEvent.url; return false; }
fix: schedule: URL events enable phishing attacks (#<I>)
primefaces_primefaces
train
js
d22d5189179ecc3cdea6d4571de8483f49bc4b9a
diff --git a/src/Logging/MonologBase.php b/src/Logging/MonologBase.php index <HASH>..<HASH> 100755 --- a/src/Logging/MonologBase.php +++ b/src/Logging/MonologBase.php @@ -2,6 +2,7 @@ namespace Modulus\Hibernate\Logging; +use Monolog\Logger; use Modulus\Support\Config; use Modulus\Hibernate\Logging\Driver; use Modulus\Hibernate\Exceptions\InvalidLogDriverException; @@ -30,6 +31,7 @@ class MonologBase * Init monolog * * @param null|string $channel + * @throws InvalidLogDriverException * @return void */ public function __construct(string $channel = null) @@ -39,6 +41,9 @@ class MonologBase $this->driver = (new self::$supported[$this->getDriver($driver) ?? 'single']); + if (!$this->driver instanceof Driver) + throw new InvalidLogDriverException; + $this->driver = $channel ? $this->driver->setDefault($channel)->get() : $this->driver->get(); } @@ -67,13 +72,10 @@ class MonologBase /** * Get log * - * @throws InvalidLogDriverException - * @return Driver + * @return Logger */ - public function log() + public function log() : Logger { - if ($this->driver instanceof Driver) return $this->driver; - - throw new InvalidLogDriverException; + return $this->driver; } }
fix: throw exception on __construct if driver is not a valid driver also, expect a logger instance on log function
modulusphp_hibernate
train
php
227549635a24ffb6c385c643b40c87d426f341fb
diff --git a/test/hash-parity-with-go-ipfs.js b/test/hash-parity-with-go-ipfs.js index <HASH>..<HASH> 100644 --- a/test/hash-parity-with-go-ipfs.js +++ b/test/hash-parity-with-go-ipfs.js @@ -38,7 +38,8 @@ module.exports = (repo) => { ipldResolver = new IPLDResolver(bs) }) - it('yields the same tree as go-ipfs', (done) => { + it('yields the same tree as go-ipfs', function (done) { + this.timeout(10 * 1000) pull( pull.values([ {
test: Increase timeout of a test The test in `hash-parity-with-go-ipfs.js` timed out even locally, hence increasing the timeout to <I> seconds.
ipfs_js-ipfs-unixfs
train
js
61ddafdab2c9ac3c762802cbf4f2e74c72e5e4a1
diff --git a/index.js b/index.js index <HASH>..<HASH> 100755 --- a/index.js +++ b/index.js @@ -1,10 +1,14 @@ /** * Created by XadillaX on 2014/8/5. */ -require("sugar"); +var _ = { + uniq: require("lodash.uniq") +}; var escapist = require("node-escapist"); var CharBuffer = require("char-buffer"); +var AND_SHARP = /&#([x|X]{1}[\d|a-f|A-F]+?|\d+?);/g; + /** * escape html * @param html @@ -24,8 +28,7 @@ exports.unescape = function(html) { // with `&#0000;` or `&#xABCD;` // (thanks to mcdong) - var andSharp = /&#([x|X]{1}[\d|a-f|A-F]+?|\d+?);/g; - var result = temp.match(andSharp); + var result = temp.match(AND_SHARP); // no match if(!Array.isArray(result)) { @@ -33,7 +36,7 @@ exports.unescape = function(html) { } // reduce - temp = result.unique().reduce(function(html, code) { + temp = _.uniq(result).reduce(function(html, code) { var buffer = new CharBuffer(); var charCode = (code[2].toUpperCase() === 'X') ?
feat: use lodash to instead of sugar
XadillaX_true-html-escape
train
js
6d5814ba652df963d52dc9265524f84215a6a0fc
diff --git a/cluster/calcium/lambda.go b/cluster/calcium/lambda.go index <HASH>..<HASH> 100644 --- a/cluster/calcium/lambda.go +++ b/cluster/calcium/lambda.go @@ -36,7 +36,7 @@ func (c *Calcium) RunAndWait(ctx context.Context, opts *types.DeployOptions, inC return nil, errors.WithStack(types.ErrRunAndWaitCountOneWithStdin) } - commit, err := c.walCreateLambda(ctx, opts) + commit, err := c.walCreateLambda(opts) if err != nil { return nil, logger.Err(err) } @@ -134,7 +134,7 @@ func (c *Calcium) RunAndWait(ctx context.Context, opts *types.DeployOptions, inC return runMsgCh, nil } -func (c *Calcium) walCreateLambda(ctx context.Context, opts *types.DeployOptions) (wal.Commit, error) { +func (c *Calcium) walCreateLambda(opts *types.DeployOptions) (wal.Commit, error) { uid, err := uuid.NewRandom() if err != nil { return nil, errors.WithStack(err)
fix: make golint works (#<I>)
projecteru2_core
train
go
c727bb6739844f701bdc6ee585708eba60d77cf5
diff --git a/src/autotyper.js b/src/autotyper.js index <HASH>..<HASH> 100644 --- a/src/autotyper.js +++ b/src/autotyper.js @@ -174,7 +174,7 @@ const autotyper = { this.letterTotal = this.settings.text.length; this.letterCount = 0; - this.emit(LOOP_EVENT); + this.emit(LOOP_EVENT, this.loopCount); return this; },
feat: pass `loopCount` on emitting `LOOP_EVENT`
saulhardman_autotyper
train
js
bc0c4e59ead7faa27a7c8f7ed55393fd27c339b7
diff --git a/src/system.config.js b/src/system.config.js index <HASH>..<HASH> 100644 --- a/src/system.config.js +++ b/src/system.config.js @@ -38,7 +38,7 @@ var systemConfig = { * http://localhost:9010/ when you're running tests. The window/tab can be left * open and the tests will automatically occur there during the build. */ - browsers: ['PhantomJS'] + browsers: [] }, e2e: { // Enable / disable running end-to-end tests in dev mode @@ -53,7 +53,7 @@ var systemConfig = { * http://localhost:9011/ when you're running tests. The window/tab can be left * open and the tests will automatically occur there during the build. */ - browsers: ['PhantomJS'] + browsers: [] }, mocks: { /**
fix(test): run tests with no browser started automatically Implements Solution 2: Remove PhantomJS from system.config.js Closes #<I>
w11k_fabs
train
js
3b734b004ad49eec3cc144dc79f2cbd1742f1e90
diff --git a/packages/router5/modules/core/navigation.js b/packages/router5/modules/core/navigation.js index <HASH>..<HASH> 100644 --- a/packages/router5/modules/core/navigation.js +++ b/packages/router5/modules/core/navigation.js @@ -42,7 +42,7 @@ export default function withNavigation(router) { * Navigate to a route * @param {String} routeName The route name * @param {Object} [routeParams] The route params - * @param {Object} [options] The navigation options (`replace`, `reload`) + * @param {Object} [options] The navigation options (`replace`, `reload`, `skipTransition`) * @param {Function} [done] A done node style callback (err, state) * @return {Function} A cancel function */ @@ -98,6 +98,11 @@ export default function withNavigation(router) { const fromState = sameStates ? null : router.getState(); + if (opts.skipTransition) { + done(null, toState); + return noop; + } + // Transition return transitionToState(toState, fromState, opts, (err, state) => { if (err) {
feat: add navigation option to skip transition
router5_router5
train
js
5de0ec44b53ecc67b58519353b04c6381afc23ff
diff --git a/index.js b/index.js index <HASH>..<HASH> 100755 --- a/index.js +++ b/index.js @@ -25,7 +25,15 @@ function run() { console.error('Unable to parse your git URL'); process.exit(2); } - exec('curl "github-changelog-api.herokuapp.com/'+repoInfo[1]+'/'+repoInfo[2]+'"').to('CHANGELOG.md'); + var url = 'github-changelog-api.herokuapp.com/' + repoInfo[1] + '/' + repoInfo[2]; + exec('curl -X POST -s "' + url + '"'); + var newLog; + do { + exec('sleep 1'); + newLog = exec('curl "' + url + '"'); + } while (newLog.match(/^Working, try again.*/)); + // Now that the contents are valid, we can write this out to disk + newLog.to('CHANGELOG.md'); var changelog_was_updated = false; exec('git ls-files --exclude-standard --modified --others').split('\n').forEach(function (file) {
fix: properly works with heroku API (POST then GET)
shelljs_changelog
train
js
73e715d92839de4d8bd89c7ad3366ed06a95020d
diff --git a/packages/theme-data/src/colorSchemes/darkBlue/unresolvedRoles.js b/packages/theme-data/src/colorSchemes/darkBlue/unresolvedRoles.js index <HASH>..<HASH> 100644 --- a/packages/theme-data/src/colorSchemes/darkBlue/unresolvedRoles.js +++ b/packages/theme-data/src/colorSchemes/darkBlue/unresolvedRoles.js @@ -28,7 +28,7 @@ import token from "./components/token"; import tooltip from "./components/tooltip"; import topNav from "./components/topNav"; import treeView from "./components/treeView"; -console.log(tile); + const darkBlueThemeConfig = extendTheme(baseTheme.unresolvedRoles, { ...mediumDensityTheme.unresolvedRoles, ...mapKeys(system.colorScheme, (key) => `colorScheme.${key}`),
refactor: removed console log from dark blue unresolved roles
Autodesk_hig
train
js
52a1e795d844320376c273df68c2e8b26c16f6d0
diff --git a/src/functions/viewClassFactory.js b/src/functions/viewClassFactory.js index <HASH>..<HASH> 100644 --- a/src/functions/viewClassFactory.js +++ b/src/functions/viewClassFactory.js @@ -4,7 +4,7 @@ function viewClassFactory(ctor, defaultOptions) { return function(options) { - return new ctor(mixins({}, defaultOptions || {}, options || {})); + return new ctor(mixins({}, (typeof defaultOptions === 'function' ? defaultOptions() : defaultOptions) || {}, options || {})); } }
feat(viewClassFactory): default options could be a function returning options object This will enable use of lazy initialization of view options, i.e. shared singleton services
karfcz_kff
train
js
2fa09f8086f985b735a4629022ea6e8e9ea8def6
diff --git a/src/prompts/questions.js b/src/prompts/questions.js index <HASH>..<HASH> 100644 --- a/src/prompts/questions.js +++ b/src/prompts/questions.js @@ -80,5 +80,5 @@ export async function promptForVcsHostDetails(hosts, visibility, decisions) { ], decisions); const host = hosts[answers[questionNames.REPO_HOST]]; - return {...answers, ...host && await host.prompt()}; + return {...answers, ...host && await host.prompt({decisions})}; } diff --git a/test/unit/prompts/questions-test.js b/test/unit/prompts/questions-test.js index <HASH>..<HASH> 100644 --- a/test/unit/prompts/questions-test.js +++ b/test/unit/prompts/questions-test.js @@ -131,7 +131,7 @@ suite('project scaffolder prompts', () => { ); const answersWithHostChoice = {...answers, [questionNames.REPO_HOST]: host}; const hostAnswers = any.simpleObject(); - hostPrompt.returns(hostAnswers); + hostPrompt.withArgs({decisions}).returns(hostAnswers); conditionals.filterChoicesByVisibility.withArgs(hosts).returns(filteredHostChoices); prompts.prompt .withArgs([
feat(decisions): passed the decisions to the vcs-host scaffolder
travi_project-scaffolder
train
js,js
455948ad144adc44d99a605adc1eff1b273c6cca
diff --git a/public/app/features/playlist/playlist_routes.js b/public/app/features/playlist/playlist_routes.js index <HASH>..<HASH> 100644 --- a/public/app/features/playlist/playlist_routes.js +++ b/public/app/features/playlist/playlist_routes.js @@ -3,7 +3,7 @@ define([ 'app/core/config', 'lodash' ], -function (angular, config, _) { +function (angular) { 'use strict'; var module = angular.module('grafana.routes');
fix(playlist): fix broken build. unused vars
grafana_grafana
train
js
e2a1995aa28adaea48600010cb3d0d4eb4db4040
diff --git a/test/connection.js b/test/connection.js index <HASH>..<HASH> 100644 --- a/test/connection.js +++ b/test/connection.js @@ -15,11 +15,14 @@ describe('connection', function() { }); }); - it('should work in a worker', function(done){ - var worker = new Worker('/test/support/worker.js'); - worker.onmessage = function(e){ - expect(e.data); - done(); - }; - }); + // no `Worker` on old IE + if (global.Worker) { + it('should work in a worker', function(done){ + var worker = new Worker('/test/support/worker.js'); + worker.onmessage = function(e){ + expect(e.data); + done(); + }; + }); + } });
test: disable worker test via feature detection
socketio_engine.io-client
train
js
c5319fc379885834682685447c9c72911b27b69f
diff --git a/src/Psalm/Internal/PhpVisitor/ReflectorVisitor.php b/src/Psalm/Internal/PhpVisitor/ReflectorVisitor.php index <HASH>..<HASH> 100644 --- a/src/Psalm/Internal/PhpVisitor/ReflectorVisitor.php +++ b/src/Psalm/Internal/PhpVisitor/ReflectorVisitor.php @@ -1264,7 +1264,9 @@ class ReflectorVisitor extends PhpParser\NodeVisitorAbstract implements PhpParse Type::fixUpLocalType( $docblock_info->mixin, $this->aliases, - $this->class_template_types + $this->class_template_types, + $this->type_aliases, + $fq_classlike_name ), null, $this->class_template_types
fix: mixin parameter of self should be properly resolved (#<I>)
vimeo_psalm
train
php
abc875365c6ae0f27f866e5fef2d22cbffe4d094
diff --git a/google-cloud-storage/lib/google/cloud/storage/file/verifier.rb b/google-cloud-storage/lib/google/cloud/storage/file/verifier.rb index <HASH>..<HASH> 100644 --- a/google-cloud-storage/lib/google/cloud/storage/file/verifier.rb +++ b/google-cloud-storage/lib/google/cloud/storage/file/verifier.rb @@ -50,7 +50,7 @@ module Google end def self.md5_for local_file - if local_file.respond_to? :path + if local_file.respond_to? :to_path ::File.open Pathname(local_file).to_path, "rb" do |f| ::Digest::MD5.file(f).base64digest end @@ -63,7 +63,7 @@ module Google end def self.crc32c_for local_file - if local_file.respond_to? :path + if local_file.respond_to? :to_path ::File.open Pathname(local_file).to_path, "rb" do |f| ::Digest::CRC32c.file(f).base64digest end
fix(storage): Update File::Verifier to test for File#to_path closes: #<I>
googleapis_google-cloud-ruby
train
rb
b1f9fdd280a74eb1e3e18af1d84e97b14124e3e2
diff --git a/android/src/main/java/com/swmansion/rnscreens/ScreenStackFragment.java b/android/src/main/java/com/swmansion/rnscreens/ScreenStackFragment.java index <HASH>..<HASH> 100644 --- a/android/src/main/java/com/swmansion/rnscreens/ScreenStackFragment.java +++ b/android/src/main/java/com/swmansion/rnscreens/ScreenStackFragment.java @@ -126,6 +126,10 @@ public class ScreenStackFragment extends ScreenFragment { AppBarLayout.LayoutParams.MATCH_PARENT, AppBarLayout.LayoutParams.WRAP_CONTENT)); view.addView(mAppBarLayout); + if (mShadowHidden) { + mAppBarLayout.setTargetElevation(0); + } + if (mToolbar != null) { mAppBarLayout.addView(recycleView(mToolbar)); }
fix: disable shadow if needed (#<I>) mAppBarLayout is created on every screen change so we need to check if the shadow shouldn't be disabled. This method is needed here since the if clause in setToolbarShadowHidden will return false e.g. when going back to the previous screen.
kmagiera_react-native-screens
train
java
dda25a63cf1ebe70c33c4f45cc65a620de622a84
diff --git a/src/components/checkbox/checkbox.js b/src/components/checkbox/checkbox.js index <HASH>..<HASH> 100644 --- a/src/components/checkbox/checkbox.js +++ b/src/components/checkbox/checkbox.js @@ -111,7 +111,8 @@ function MdCheckboxDirective(inputDirective, $mdAria, $mdConstant, $mdTheming, $ attr.$set('aria-labelledby', labelId); var label = element.children()[1]; - label.remove(); + // Use jQLite here since ChildNode.remove() is not supported in IE11. + angular.element(label).remove(); label.removeAttribute('ng-transclude'); label.className = 'md-checkbox-link-label'; label.setAttribute('id', labelId);
fix(checkbox): labels with links throw exception in IE<I>
angular_material
train
js
871acccbb1409c2864b8dfd69d936878ea3458e3
diff --git a/Gruntfile.js b/Gruntfile.js index <HASH>..<HASH> 100644 --- a/Gruntfile.js +++ b/Gruntfile.js @@ -167,8 +167,8 @@ module.exports = function(grunt) { browsers: [ {browserName: 'chrome'}, {browserName: 'firefox', platform: 'Linux'}, - {browserName: 'safari', version: 9, platform: 'OS X 10.11'}, - {browserName: 'safari', version: 8, platform: 'OS X 10.10'}, + // {browserName: 'safari', version: 9, platform: 'OS X 10.11'}, + // {browserName: 'safari', version: 8, platform: 'OS X 10.10'}, {browserName: 'internet explorer', version: 11, platform: 'Windows 8.1'}, {browserName: 'internet explorer', version: 10, platform: 'Windows 8'} ]
test: remove safari from saucelabs
wycats_handlebars.js
train
js
93e18f78f91790f2a66d00f395fb4c8148a18395
diff --git a/src/notebook/reducers/document.js b/src/notebook/reducers/document.js index <HASH>..<HASH> 100644 --- a/src/notebook/reducers/document.js +++ b/src/notebook/reducers/document.js @@ -56,10 +56,10 @@ export default handleActions({ [constants.TOGGLE_STICKY_CELL]: function toggleStickyCell(state, action) { const { id } = action; const stickyCells = state.get('stickyCells'); - if (stickyCells.get(id)) { + if (stickyCells.has(id)) { return state.set('stickyCells', stickyCells.delete(id)); } - return state.setIn(['stickyCells', id], true); + return state.set('stickyCells', stickyCells.add(id)); }, [constants.UPDATE_CELL_EXECUTION_COUNT]: function updateExecutionCount(state, action) { const { id, count } = action;
refactor(reducers): Use Immutable.Set in toggleStickyCell
nteract_nteract
train
js
112288d331e051e5556e7a2fa81e79d9616ea856
diff --git a/src/Auditable.php b/src/Auditable.php index <HASH>..<HASH> 100644 --- a/src/Auditable.php +++ b/src/Auditable.php @@ -55,7 +55,10 @@ trait Auditable */ public function audits() { - return $this->morphMany(Config::get('audit.implementation'), 'auditable'); + return $this->morphMany( + Config::get('audit.implementation', \OwenIt\Auditing\Models\Audit::class), + 'auditable' + ); } /**
fix(Auditable): set OwenIt\Auditing\Models\Audit as default Audit implementation
owen-it_laravel-auditing
train
php
83dc2654644c5a6d6679cc74ab515f5f9ef07c9c
diff --git a/lib/config.js b/lib/config.js index <HASH>..<HASH> 100644 --- a/lib/config.js +++ b/lib/config.js @@ -384,7 +384,7 @@ exports.extend = function extend(newConf) { }; var isLocalUIUrl = function(url) { var host = getHostname(url); - return isWebUIHost() || !!config.pluginHostMap[host]; + return isWebUIHost(host) || !!config.pluginHostMap[host]; }; config.isLocalUIUrl = isLocalUIUrl;
feat: Support custom the hostname of plugin by cli
avwo_whistle
train
js
3cf7ea55d3acbce0968dca8208d6c0911fff90fb
diff --git a/application/tests/Bootstrap.php b/application/tests/Bootstrap.php index <HASH>..<HASH> 100644 --- a/application/tests/Bootstrap.php +++ b/application/tests/Bootstrap.php @@ -324,6 +324,9 @@ switch (ENVIRONMENT) /* require __DIR__ . '/_ci_phpunit_test/patcher/bootstrap.php'; MonkeyPatchManager::init([ + // If you want debug log, set `debug` true, and optionally you can set the log file path + 'debug' => true, + 'log_file' => '/tmp/monkey-patch-debug.log', // PHP Parser: PREFER_PHP7, PREFER_PHP5, ONLY_PHP7, ONLY_PHP5 'php_parser' => 'PREFER_PHP5', 'cache_dir' => TESTPATH . '_ci_phpunit_test/tmp/cache',
docs: how to enable debug mode and set the log file path, as comment
kenjis_ci-phpunit-test
train
php