Datasets:
djtereano
/
commitbench_conventional

Dataset card Data Studio Files
xet
Community
1
hash
stringlengths
40
40
diff
stringlengths
172
2.63k
message
stringlengths
12
593
project
stringlengths
7
65
split
stringclasses
1 value
diff_languages
stringclasses
54 values
64ee4a528815354905b1f5c92fb7ba1e1604e4b4
diff --git a/lib/classes/console.js b/lib/classes/console.js index <HASH>..<HASH> 100644 --- a/lib/classes/console.js +++ b/lib/classes/console.js @@ -6,6 +6,7 @@ const lazy = require('d/lazy'); const path = require('path'); const os = require('os'); const fsp = require('fs').promises; +const fse = require('fs-extra'); const fetch = require('node-fetch'); const tar = require('tar'); const filesize = require('filesize'); @@ -264,6 +265,7 @@ class Console { async packageOtelExtensionLayer() { const layerFilename = await this.deferredExtensionLayerFilename; log.debug('copy extension file (%s) to package directory', layerFilename); + await fse.ensureDir(path.join(this.serverless.serviceDir, '.serverless')); await fsp.copyFile( layerFilename, path.join(
fix(Console): Ensure to package extension without errors
serverless_serverless
train
js
f07d43fa595d068baa1140de1421b66ee555b224
diff --git a/src/core/core.js b/src/core/core.js index <HASH>..<HASH> 100644 --- a/src/core/core.js +++ b/src/core/core.js @@ -79,10 +79,7 @@ class Swiper { swiper.eventsListeners = {}; swiper.eventsAnyListeners = []; - - if (typeof swiper.modules === 'undefined') { - swiper.modules = []; - } + swiper.modules = [...swiper.__modules__]; if (params.modules && Array.isArray(params.modules)) { swiper.modules.push(...params.modules); } @@ -626,8 +623,8 @@ class Swiper { } static installModule(mod) { - if (!Swiper.prototype.modules) Swiper.prototype.modules = []; - const modules = Swiper.prototype.modules; + if (!Swiper.prototype.__modules__) Swiper.prototype.__modules__ = []; + const modules = Swiper.prototype.__modules__; if (typeof mod === 'function' && modules.indexOf(mod) < 0) { modules.push(mod);
fix(core): passes `modules` shouldn't extend prototype fixes #<I>
nolimits4web_swiper
train
js
425fa06c8f215f2d6b50731196e85244204129c3
diff --git a/webpack-config.js b/webpack-config.js index <HASH>..<HASH> 100644 --- a/webpack-config.js +++ b/webpack-config.js @@ -11,7 +11,7 @@ exports.createModuleRule = function(ExtractTextPlugin, { global = false, plugins options: { sourceMap: false, modules: !global, - minimize: production !== false && { autoprefixer: false }, + minimize: production !== false, importLoaders: 2, localIdentName: production !== false ? '[hash:base64]' : '[name]__[local]___[hash:base64:5]',
fix: css modules minimize autoprefixer is already disabled
christophehurpeau_ynnub
train
js
ec5adc9e400734d245bbc53bd96acfd095210718
diff --git a/src/Server.js b/src/Server.js index <HASH>..<HASH> 100644 --- a/src/Server.js +++ b/src/Server.js @@ -104,7 +104,7 @@ class Server extends EventEmitter { client._setEvents() client.connected = true this.clients.set(client.id, client) - client.on('close', () => this._removeClient(this.id)) + client.on('close', () => this._removeClient(client.id)) client.send('connect', authReplyData) } }).catch(error => {
fix(server): actually remove client
an-sh_ws-messaging
train
js
ec642a5bd4ab48c9d1ada3467655706d6e7bce6c
diff --git a/ui/src/components/pagination/QPagination.js b/ui/src/components/pagination/QPagination.js index <HASH>..<HASH> 100644 --- a/ui/src/components/pagination/QPagination.js +++ b/ui/src/components/pagination/QPagination.js @@ -112,7 +112,9 @@ export default defineComponent({ return } const value = between(val, props.min, props.max) - emit('update:modelValue', value) + if (props.modelValue !== value) { + emit('update:modelValue', value) + } } })
fix(QPagination): do not emit model if current value is the same #<I>
quasarframework_quasar
train
js
7ecf88347787f112034a1bb149e940bc07d743a3
diff --git a/packages/mip/src/viewer.js b/packages/mip/src/viewer.js index <HASH>..<HASH> 100644 --- a/packages/mip/src/viewer.js +++ b/packages/mip/src/viewer.js @@ -206,7 +206,7 @@ let viewer = { // 2. Not MIP page and not only hash change if ((this._isCrossOrigin(to) && window.MIP.standalone) || (!isMipLink && !isHashInCurrentPage)) { - window.top.location[replace ? 'replace' : 'assign'](to) + window.top.location.href = to return }
fix: jump to non-mip-link by window.top
mipengine_mip2
train
js
de91bb330a07d80f96644b62830ced2a76e0494c
diff --git a/scripts/webpack/js-bundle-factory.js b/scripts/webpack/js-bundle-factory.js index <HASH>..<HASH> 100644 --- a/scripts/webpack/js-bundle-factory.js +++ b/scripts/webpack/js-bundle-factory.js @@ -171,7 +171,7 @@ class JsBundleFactory { banner: getAbsolutePath('/packages/mdc-banner/index.ts'), base: getAbsolutePath('/packages/mdc-base/index.ts'), checkbox: getAbsolutePath('/packages/mdc-checkbox/index.ts'), - chips: getAbsolutePath('/packages/mdc-chips/deprecated/index.ts'), + chips: getAbsolutePath('/packages/mdc-chips/index.ts'), circularProgress: getAbsolutePath('packages/mdc-circular-progress/index.ts'), dataTable: getAbsolutePath('/packages/mdc-data-table/index.ts'), dialog: getAbsolutePath('/packages/mdc-dialog/index.ts'),
chore: Fix js-bundle-factory for chips
material-components_material-components-web
train
js
462e4ad9dfd297c9512c70eec27adeb223ca4e24
diff --git a/cmd/nfpm/main.go b/cmd/nfpm/main.go index <HASH>..<HASH> 100644 --- a/cmd/nfpm/main.go +++ b/cmd/nfpm/main.go @@ -12,7 +12,6 @@ import ( "github.com/goreleaser/nfpm" _ "github.com/goreleaser/nfpm/deb" _ "github.com/goreleaser/nfpm/rpm" - yaml "gopkg.in/yaml.v2" ) var ( @@ -56,19 +55,18 @@ func initFile(config string) error { return ioutil.WriteFile(config, box.Bytes("."), 0666) } -func doPackage(config, target string) error { +func doPackage(path, target string) error { format := filepath.Ext(target)[1:] - bts, err := ioutil.ReadFile(config) + config, err := nfpm.ParseFile(path) if err != nil { return err } - var info nfpm.Info - err = yaml.UnmarshalStrict(bts, &info) + info, err := config.Get(format) if err != nil { return err } - if err := nfpm.Validate(info); err != nil { + if err = nfpm.Validate(info); err != nil { return err } fmt.Printf("using %s packager...\n", format)
feat: overrides for nfpm cli
goreleaser_nfpm
train
go
b90f12d79948c1720d0444c93e1c1828eb18ef80
diff --git a/modules/adyoulikeBidAdapter.js b/modules/adyoulikeBidAdapter.js index <HASH>..<HASH> 100644 --- a/modules/adyoulikeBidAdapter.js +++ b/modules/adyoulikeBidAdapter.js @@ -55,7 +55,7 @@ export const spec = { const data = JSON.stringify(payload); const options = { - withCredentials: false + withCredentials: true }; return {
fix(AdyoulikeAdapter): set withCredentials option to true (#<I>)
prebid_Prebid.js
train
js
69728e266c3c29037ca2b8fad4fcd38a2d9e7a6a
diff --git a/routes/rest/v1/users.js b/routes/rest/v1/users.js index <HASH>..<HASH> 100644 --- a/routes/rest/v1/users.js +++ b/routes/rest/v1/users.js @@ -97,4 +97,29 @@ module.exports = function (server) { res.sendStatus(204) }) }) + + /** + * HEAD /v1/users/email/:email + */ + + server.head('/v1/users/email/:email', authorize, function (req, res, next) { + User.getByEmail(req.params.email, function (err, instance) { + if (err) { return next(err) } + if (!instance) { return next(new NotFoundError()) } + res.sendStatus(204) + }) + }) + + /** + * GET /v1/users/email/:email + */ + + server.get('/v1/users/email/:email', authorize, function (req, res, next) { + User.getByEmail(req.params.email, function (err, instance) { + if (err) { return next(err) } + if (!instance) { return next(new NotFoundError()) } + res.json(instance) + }) + }) + }
feat(users): add GET and HEAD API endpoints for user by email
anvilresearch_connect
train
js
166436c99b3bc339a4114edef2ecdf420cc1fe0a
diff --git a/src/website/app/Markdown.js b/src/website/app/Markdown.js index <HASH>..<HASH> 100644 --- a/src/website/app/Markdown.js +++ b/src/website/app/Markdown.js @@ -1,6 +1,6 @@ /* @flow */ import React, { createElement } from 'react'; -import marksy from 'marksy/components'; +import marksy from 'marksy/jsx'; import darken from 'polished/lib/color/darken'; import rgba from 'polished/lib/color/rgba'; import {
chore(website): Adjust marksy import path * console.warning when running jest * DEPRECATED - Importing "marksy/components" causes a large bundle size. Read updated docs for information on avoiding this. If you want jsx support, import from "marksy/jsx"
mineral-ui_mineral-ui
train
js
0744934ba48c09795e76ef5472bde9966c41d029
diff --git a/packages/react/src/components/InlineLoading/InlineLoading.js b/packages/react/src/components/InlineLoading/InlineLoading.js index <HASH>..<HASH> 100644 --- a/packages/react/src/components/InlineLoading/InlineLoading.js +++ b/packages/react/src/components/InlineLoading/InlineLoading.js @@ -8,7 +8,7 @@ import React from 'react'; import PropTypes from 'prop-types'; import classNames from 'classnames'; -import { CheckmarkFilled16, Error20 } from '@carbon/icons-react'; +import { CheckmarkFilled16, ErrorFilled16 } from '@carbon/icons-react'; import { settings } from 'carbon-components'; import deprecate from '../../prop-types/deprecate'; import Loading from '../Loading'; @@ -28,7 +28,7 @@ export default function InlineLoading({ const loadingClasses = classNames(`${prefix}--inline-loading`, className); const getLoading = () => { if (status === 'error') { - return <Error20 className={`${prefix}--inline-loading--error`} />; + return <ErrorFilled16 className={`${prefix}--inline-loading--error`} />; } if (status === 'finished') { setTimeout(() => {
fix(InlineLoading): change error icon to filled (#<I>)
carbon-design-system_carbon-components
train
js
b06573ab667e4070e07bf9fe183f2e9d6bc99708
diff --git a/resources/ec2-tgw.go b/resources/ec2-tgw.go index <HASH>..<HASH> 100644 --- a/resources/ec2-tgw.go +++ b/resources/ec2-tgw.go @@ -72,7 +72,10 @@ func (e *EC2TGW) Properties() types.Properties { for _, tagValue := range e.tgw.Tags { properties.SetTag(tagValue.Key, tagValue.Value) } - properties.Set("ID", e.tgw.TransitGatewayId) + properties. + Set("ID", e.tgw.TransitGatewayId). + Set("OwnerId", e.tgw.OwnerId) + return properties }
feat: Add OwnerId Prop to EC2TGW (#<I>)
rebuy-de_aws-nuke
train
go
0923134ec7b31604208e192f4d209d739096029f
diff --git a/tests/system/I18n/TimeTest.php b/tests/system/I18n/TimeTest.php index <HASH>..<HASH> 100644 --- a/tests/system/I18n/TimeTest.php +++ b/tests/system/I18n/TimeTest.php @@ -28,7 +28,7 @@ final class TimeTest extends CIUnitTestCase parent::setUp(); helper('date'); - Locale::setDefault('America/Chicago'); + Locale::setDefault('en_US'); } public function testNewTimeNow()
test: fix failed test 2) CodeIgniter\I<I>n\TimeTest::testToFormattedDateString Failed asserting that two strings are identical. --- Expected +++ Actual @@ @@ -'May <I>, <I>' +'5月 <I>, <I>' .../CodeIgniter4/tests/system/I<I>n/TimeTest.php:<I>
codeigniter4_CodeIgniter4
train
php
9c7867e6dc75ee8842b4bbfdfeba9e3ccf3bc616
diff --git a/lib/undefsafe.js b/lib/undefsafe.js index <HASH>..<HASH> 100644 --- a/lib/undefsafe.js +++ b/lib/undefsafe.js @@ -18,7 +18,10 @@ function undefsafe(obj, path, value) { i++; c = path.substr(i, 1); } - res.push(key); + + if (key) { // the first value could be a string + res.push(key); + } key = ''; continue; } diff --git a/test/undefsafe.test.js b/test/undefsafe.test.js index <HASH>..<HASH> 100644 --- a/test/undefsafe.test.js +++ b/test/undefsafe.test.js @@ -66,6 +66,13 @@ test('should find properties with periods in them', function (t) { r = undefsafe(value, `a['one.two.and\three'].1`); t.equal(r, true, 'combo: ' + r); + value = { + 'one.two': true + }; + + r = undefsafe(value, `['one.two']`); + t.equal(r, true, 'root: ' + r); + t.end(); });
fix: when first prop is a string lookup
remy_undefsafe
train
js,js
a58694265d2497e1e88195d4e2c36bc91f29722b
diff --git a/modules/router5Middleware.js b/modules/router5Middleware.js index <HASH>..<HASH> 100644 --- a/modules/router5Middleware.js +++ b/modules/router5Middleware.js @@ -27,7 +27,7 @@ export default function replaceRoutesMiddleware(router) { return next => action => { if (action.type === actionTypes.NAVIGATE_TO) { - router.navigate(action.name, action.params, action.options); + router.navigate(action.name, action.params, action.opts); } else if (action.type === actionTypes.CANCEL_TRANSITION) { router.cancel(); }
fix: fix passing of navigate options to router
router5_router5
train
js
cbc0b3c93fcb16beec8ea2f182c6e2f469e8ec06
diff --git a/packages/availity-workflow-settings/webpack/rule-fonts.js b/packages/availity-workflow-settings/webpack/rule-fonts.js index <HASH>..<HASH> 100644 --- a/packages/availity-workflow-settings/webpack/rule-fonts.js +++ b/packages/availity-workflow-settings/webpack/rule-fonts.js @@ -4,6 +4,6 @@ module.exports = { // '../fonts/availity-font.eot?18704236' // '../fonts/availity-font.eot' // - test: /-font\.(otf|ttf|woff2?|eot|svg)(\?.+)?$/, + test: /font\.(otf|ttf|woff2?|eot|svg)(\?.+)?$/, use: ['file-loader?name=fonts/[name].[ext]'] };
fix(fontRule): filename no longer needs hyphen Imported fonts no longer need the hyphen, they just need to end with `font` before the dot-extension. This allows for webfont to be caught. Closes #<I>
Availity_availity-workflow
train
js
ec34d136cf7fce2a55822fa1be426d500e291be4
diff --git a/lib/workers/repository/write.js b/lib/workers/repository/write.js index <HASH>..<HASH> 100644 --- a/lib/workers/repository/write.js +++ b/lib/workers/repository/write.js @@ -10,7 +10,7 @@ module.exports = { async function writeUpdates(config) { let { branches } = config; logger.info(`Processing ${branches.length} branch(es)`); - if (branches.some(upg => upg.isPin)) { + if (!config.mirrorMode && branches.some(upg => upg.isPin)) { branches = branches.filter(upg => upg.isPin); logger.info(`Processing ${branches.length} "pin" PRs first`); }
fix: don’t have blocking pin PRs when in mirror mode
renovatebot_renovate
train
js
0c25c610c716daeb0be7bcfcb44221f190dc540f
diff --git a/ibis/expr/types/relations.py b/ibis/expr/types/relations.py index <HASH>..<HASH> 100644 --- a/ibis/expr/types/relations.py +++ b/ibis/expr/types/relations.py @@ -1093,7 +1093,7 @@ class Table(Expr): ) @util.deprecated(version="4.0", instead="") - def prevent_rewrite(self, client=None) -> Table: + def prevent_rewrite(self, client=None) -> Table: # pragma: no cover """Prevent optimization from happening below this expression. Only valid on SQL-string generating backends.
chore: exclude prevent_rewrite from coverage report
ibis-project_ibis
train
py
007a58e5bde487e3c588ecbbbbb4203a39b008f4
diff --git a/preview/src/pages/typography/script.typography.js b/preview/src/pages/typography/script.typography.js index <HASH>..<HASH> 100644 --- a/preview/src/pages/typography/script.typography.js +++ b/preview/src/pages/typography/script.typography.js @@ -56,7 +56,7 @@ module.exports = { var target = $(this.$el).find('#visibility'); - quasar.events.on('app:visible app:hidden', function(state) { + quasar.events.on('app:visibility', function(state) { target.append('App became ' + state + '<br>'); }); }, diff --git a/src/lib/core-features/app-visibility/app-visibility.js b/src/lib/core-features/app-visibility/app-visibility.js index <HASH>..<HASH> 100644 --- a/src/lib/core-features/app-visibility/app-visibility.js +++ b/src/lib/core-features/app-visibility/app-visibility.js @@ -28,7 +28,7 @@ function onchange(evt) { state = this[hidden] ? h : v; } - quasar.events.trigger('app:' + state, state); + quasar.events.trigger('app:visibility', state); body.removeClass('app-' + (state === 'visible' ? h : v)).addClass('app-' + state); }
refactor: Small enhancement to Page Visibility
quasarframework_quasar
train
js,js
f60e55c099c6121cd7dff5be64935a44c72dd0fb
diff --git a/packages/node_modules/@webex/plugin-meetings/src/constants.js b/packages/node_modules/@webex/plugin-meetings/src/constants.js index <HASH>..<HASH> 100644 --- a/packages/node_modules/@webex/plugin-meetings/src/constants.js +++ b/packages/node_modules/@webex/plugin-meetings/src/constants.js @@ -405,6 +405,8 @@ export const ROAP = { TX_: 'TX_' }; +export const ROAP_SEQ_PRE = -1; + export const EVENTS = { ROAP_OK: 'ROAP_OK', ROAP_ANSWER: 'ROAP_ANSWER',
fix(plugin-meetings): add missing constant
webex_spark-js-sdk
train
js
ffc3f8bada5f9a031ffe3af1e00c01b0edb05740
diff --git a/semantic_release/history/logs.py b/semantic_release/history/logs.py index <HASH>..<HASH> 100644 --- a/semantic_release/history/logs.py +++ b/semantic_release/history/logs.py @@ -106,12 +106,7 @@ def generate_changelog(from_version: str, to_version: str = None) -> dict: if message[1] not in changes: continue - changes[message[1]].append(( - _hash, - # Capitalize the first letter of the message - message[3][0].capitalize() - - )) + changes[message[1]].append((_hash, message[3][0].capitalize())) # Handle breaking change message parts = None
refactor(history): remove unnecessary newlines Since simplifying the capitalization, the comment is no longer needed and so the statement can be compacted onto one line again.
relekang_python-semantic-release
train
py
88ebc6d9e23b4e64d9a6280df5b00ef923e34d1c
diff --git a/packages/site/src/ui/mobile-menu-bar.js b/packages/site/src/ui/mobile-menu-bar.js index <HASH>..<HASH> 100644 --- a/packages/site/src/ui/mobile-menu-bar.js +++ b/packages/site/src/ui/mobile-menu-bar.js @@ -21,6 +21,7 @@ export default props => ( justify-content: center; align-items: center; height: 69px; + background: ${core.colors.bone}; } .burger { position: absolute; diff --git a/packages/site/src/ui/side-nav.js b/packages/site/src/ui/side-nav.js index <HASH>..<HASH> 100644 --- a/packages/site/src/ui/side-nav.js +++ b/packages/site/src/ui/side-nav.js @@ -336,12 +336,12 @@ export default withHeadings(props => ( background: ${core.colors.bone}; overflow-x: hidden; overflow-y: auto; - box-shadow: 0 2px 17px rgba(0, 0, 0, 0.5); transition: transform ${core.motion.speedXFast} ease-in-out; z-index: 10; /* TODO: arbitrary; above code mirror; come back when ready to systemize */ } .sidenavOpen { transform: translateX(0); + box-shadow: 0 2px 17px rgba(0, 0, 0, 0.5); } @media screen and (min-width: 769px) { .sidenav {
fix(site): adjust mobile menu bar bg and shadow
pluralsight_design-system
train
js,js
337a11edf5cccff9865cffbef1ded902c997c995
diff --git a/lib/components/services/rbac/admin/index.js b/lib/components/services/rbac/admin/index.js index <HASH>..<HASH> 100644 --- a/lib/components/services/rbac/admin/index.js +++ b/lib/components/services/rbac/admin/index.js @@ -86,6 +86,21 @@ class RbacAdmin { } }) } // describeRole + + restrictionsOn(resourceType, resourceName) { + const specificRestrictions = this.rbac.index[resourceType][resourceName] + const genericRestrictions = this.rbac.index[resourceType]['*'] + + const restrictions = { } + const allActions = [...Object.keys(specificRestrictions), ...Object.keys(genericRestrictions)] + for (const action of allActions) { + restrictions[action] = [ + ...( specificRestrictions[action] || [] ), + ...( genericRestrictions[action] || [] ) + ] + } + return restrictions + } // restrictionsOn } // RbacAdmin async function makeRbacAdmin (rbacService, options) {
feat: First pass at implementing rbacAdmin.restrictionsOn Allows us to query the specific restrictions on a named resource (ie on a particular state machine)
wmfs_tymly-rbac-plugin
train
js
03a0b7e879d9889f456636c79fca43fdc271c84a
diff --git a/packages/theme/src/fontSizes.js b/packages/theme/src/fontSizes.js index <HASH>..<HASH> 100644 --- a/packages/theme/src/fontSizes.js +++ b/packages/theme/src/fontSizes.js @@ -3,7 +3,7 @@ export const X_LARGE = 20; export const LARGE = 18; export const MEDIUM = 16; export const SMALL = 14; -export const X_SMALL = 14; +export const X_SMALL = 12; export default { HUGE,
fix(theme): adjust font size value of x_small from <I> to <I> affects: @crave/farmblocks-theme ISSUES CLOSED: #<I>
CraveFood_farmblocks
train
js
9af7fd81975d162a58ac355df032721dd097395e
diff --git a/src/http/app.js b/src/http/app.js index <HASH>..<HASH> 100644 --- a/src/http/app.js +++ b/src/http/app.js @@ -72,14 +72,15 @@ function registerListeners({ server }) { console.error(err) process.exit(1) } + process.exit(0) }) } process.on('SIGINT', () => { - console.log(chalk.yellow('Received SIGINT >>> Shutting down...')) + console.log(chalk.bgBlack.yellow('Received SIGINT >>> Shutting down...')) serverClose() }) process.on('SIGTERM', () => { - console.log(chalk.yellow('Received SIGTERM >>> Shutting down...')) + console.log(chalk.bgBlack.yellow('Received SIGTERM >>> Shutting down...')) serverClose() }) }
fix: adds process.exit on successful server.close
jasonsites_proxy-es-aws
train
js
d1799adb2a9bc5417cd5b0a91e3061a395441e53
diff --git a/widget_test.go b/widget_test.go index <HASH>..<HASH> 100644 --- a/widget_test.go +++ b/widget_test.go @@ -23,7 +23,9 @@ func init() { // Runner func TestRender(t *testing.T) { - db.DropTable(&widget.QorWidgetSetting{}) + if err := db.DropTableIfExists(&widget.QorWidgetSetting{}).Error; err != nil { + panic(err) + } db.AutoMigrate(&widget.QorWidgetSetting{}) Widgets := widget.New(&widget.Config{
test: don't panic table doesn't exist error
qor_widget
train
go
bca40391bf6873b9a534f72ec207fe23daf7a0c0
diff --git a/lib/schema_dot_org.rb b/lib/schema_dot_org.rb index <HASH>..<HASH> 100644 --- a/lib/schema_dot_org.rb +++ b/lib/schema_dot_org.rb @@ -11,9 +11,19 @@ module SchemaDotOrg to_json_ld(pretty: true) end + def to_json_ld(pretty: false) "<script type=\"application/ld+json\">\n" + to_json(pretty: pretty) + "\n</script>" end + + def to_json(pretty: false) + if pretty + JSON.pretty_generate(to_json_struct) + else + to_json_struct.to_json + end + end + end end diff --git a/lib/schema_dot_org/place.rb b/lib/schema_dot_org/place.rb index <HASH>..<HASH> 100644 --- a/lib/schema_dot_org/place.rb +++ b/lib/schema_dot_org/place.rb @@ -10,16 +10,6 @@ module SchemaDotOrg validates :address, presence: true validates :address, type: String - - def to_json(pretty: false) - if pretty - JSON.pretty_generate(to_json_struct) - else - to_json_struct.to_json - end - end - - def to_json_struct { "@type" => "Place",
refactor: moved another method to parent class
public-law_schema-dot-org
train
rb,rb
9298245e65611820dc9b9663887a98eb035a10ab
diff --git a/app/interactors/get_posts.rb b/app/interactors/get_posts.rb index <HASH>..<HASH> 100644 --- a/app/interactors/get_posts.rb +++ b/app/interactors/get_posts.rb @@ -19,7 +19,6 @@ class GetPosts private def has_search_params? - param_keys = context.params.keys || [] - (param_keys & SEARCH_PARAMS).any? + (context.params.to_h.keys & SEARCH_PARAMS).any? end end
fix: previous fix wasn't actually grabbing context.params keys for has_search_params?
cortex-cms_cortex
train
rb
c00715f2c2a6c1dbed2b09cf53e6e1e25fc5b794
diff --git a/lib/project.js b/lib/project.js index <HASH>..<HASH> 100644 --- a/lib/project.js +++ b/lib/project.js @@ -27,7 +27,7 @@ class Project { } /** - * Returns whether or not this is a CLEA CLI project. + * Returns whether or not this is a Clea CLI project. * This checks whether `.clea-cli.json` exists in the project. * * @return {boolean} TRUE if it is; FALSE otherwise
docs(project): Clea should be lower cased
groupe-sii_clea-cli
train
js
62e4f2b3d1281297e1671b924c7fb932b56e1961
diff --git a/test/unit/features/component/component-slot.spec.js b/test/unit/features/component/component-slot.spec.js index <HASH>..<HASH> 100644 --- a/test/unit/features/component/component-slot.spec.js +++ b/test/unit/features/component/component-slot.spec.js @@ -153,7 +153,7 @@ describe('Component slot', () => { b: 2, show: true }, - template: '<test :show="show"><p slot="b">{{b}}</a><p>{{a}}</p></test>', + template: '<test :show="show"><p slot="b">{{b}}</p><p>{{a}}</p></test>', components: { test: { props: ['show'], @@ -283,7 +283,7 @@ describe('Component slot', () => { it('programmatic access to $slots', () => { const vm = new Vue({ - template: '<test><p slot="a">A</p><div>C</div><p slot="b">B</div></p></test>', + template: '<test><p slot="a">A</p><div>C</div><p slot="b">B</p></test>', components: { test: { render () {
chore: fix some closetag mismatches (#<I>)
IOriens_wxml-transpiler
train
js
b9a552898a31301e9c2a4c8b16e108e62e6b8108
diff --git a/setup.py b/setup.py index <HASH>..<HASH> 100644 --- a/setup.py +++ b/setup.py @@ -1,14 +1,22 @@ +from os import path + from setuptools import setup __version__ = "2.1.1" +this_directory = path.abspath(path.dirname(__file__)) +with open(path.join(this_directory, "README.md"), encoding="utf-8") as f: + long_description = f.read() + setup( name="aresponses", packages=["aresponses"], version=__version__, description=""" - Asyncio testing server. Similar to the responses library used for 'requests' + Asyncio response mocking. Similar to the responses library used for 'requests' """.strip(), + long_description=long_description, + long_description_content_type="text/markdown", author="Bryce Drennan, CircleUp", author_email="aresponses@brycedrennan.com ", url="https://github.com/circleup/aresponses",
docs: add readme to pypi
CircleUp_aresponses
train
py
2fa6230fb331b9e64fe9a34ec64c11cc4b268cb5
diff --git a/lib/registry/injector.js b/lib/registry/injector.js index <HASH>..<HASH> 100644 --- a/lib/registry/injector.js +++ b/lib/registry/injector.js @@ -235,6 +235,7 @@ class Injector { throw Object.assign(new Error(`Unknown dependency key ${toString(key)}`), { code: 'INVALID_DEPENDENCY_KEY', scope: this.scope.name, + key, }); }
feat: add `key` property to dep key errs This will make providing more useful errors for known missing keys cleaner
groupon_nilo
train
js
1254da59f4f3654782b2b00f6239aef0bef935ce
diff --git a/packages/react/src/components/DataTable/DataTable.js b/packages/react/src/components/DataTable/DataTable.js index <HASH>..<HASH> 100644 --- a/packages/react/src/components/DataTable/DataTable.js +++ b/packages/react/src/components/DataTable/DataTable.js @@ -396,7 +396,7 @@ export default class DataTable extends React.Component { const totalSelected = this.getSelectedRows().length; return { ...props, - shouldShowBatchActions, + shouldShowBatchActions: shouldShowBatchActions && totalSelected > 0, totalSelected, onCancel: this.handleOnCancel, };
feat(DataTable): close batch actions when selected items are removed (#<I>)
carbon-design-system_carbon-components
train
js
108c935edbe7f3d7e0b9f35304284cbdaa7cfcde
diff --git a/stellar_sdk/client/aiohttp_client.py b/stellar_sdk/client/aiohttp_client.py index <HASH>..<HASH> 100644 --- a/stellar_sdk/client/aiohttp_client.py +++ b/stellar_sdk/client/aiohttp_client.py @@ -83,7 +83,7 @@ class AiohttpClient(BaseAsyncClient): headers=dict(response.headers), url=str(response.url), ) - except aiohttp.ClientConnectionError as e: # TODO: need more research + except aiohttp.ClientError as e: # TODO: need more research raise ConnectionError(e) async def post(self, url: str, data: Dict[str, str] = None) -> Response:
fix: catch the exception thrown by aiohttp. We need more testing.
StellarCN_py-stellar-base
train
py
778a3d3db68ca805e9dbf4aea0184a12bdd0a899
diff --git a/lib/vcard.js b/lib/vcard.js index <HASH>..<HASH> 100644 --- a/lib/vcard.js +++ b/lib/vcard.js @@ -53,7 +53,7 @@ vCard.normalize = function( input ) { // Trim whitespace .replace( /^[\s\r\n]+|[\s\r\n]+$/g, '' ) // Trim blank lines - .replace( /(\r?\n)\s*(\r?\n)|$/g, '$1' ) + .replace( /(\r\n)[\x09\x20]?(\r\n)|$/g, '$1' ) // Unfold folded lines .replace( /\r?\n[\x20\x09]+/g, '' ) }
fix(vcard): Only trim blank lines with single WSP
jhermsmeier_node-vcf
train
js
023d63cb107c712fbf9781567c88c9db6076fc8e
diff --git a/src/Configuration/GrumPHP.php b/src/Configuration/GrumPHP.php index <HASH>..<HASH> 100644 --- a/src/Configuration/GrumPHP.php +++ b/src/Configuration/GrumPHP.php @@ -166,7 +166,7 @@ class GrumPHP */ public function getAsciiContentPath($resource) { - if (is_null($this->container->getParameter('ascii'))) { + if (null === $this->container->getParameter('ascii')) { return null; }
style: Update to satisfy a style preference
phpro_grumphp
train
php
c2c2e496478b46f092c946dd6300b2e16b821853
diff --git a/actor-sdk/sdk-core-android/android-sdk/src/main/java/im/actor/sdk/controllers/dialogs/view/DialogHolder.java b/actor-sdk/sdk-core-android/android-sdk/src/main/java/im/actor/sdk/controllers/dialogs/view/DialogHolder.java index <HASH>..<HASH> 100644 --- a/actor-sdk/sdk-core-android/android-sdk/src/main/java/im/actor/sdk/controllers/dialogs/view/DialogHolder.java +++ b/actor-sdk/sdk-core-android/android-sdk/src/main/java/im/actor/sdk/controllers/dialogs/view/DialogHolder.java @@ -81,7 +81,7 @@ public class DialogHolder extends BindedViewHolder { background.setBackgroundResource(R.drawable.selector_fill); fl.addView(background, new FrameLayout.LayoutParams(ViewGroup.LayoutParams.MATCH_PARENT, ViewGroup.LayoutParams.MATCH_PARENT)); avatar = new AvatarView(context); - avatar.init(Screen.dp(56), 24); + avatar.init(Screen.dp(56), 22); { FrameLayout.LayoutParams avatarLayoutParams = new FrameLayout.LayoutParams(Screen.dp(56), Screen.dp(56)); avatarLayoutParams.gravity = Gravity.CENTER_VERTICAL | Gravity.LEFT;
fix(android): Missing changed
actorapp_actor-platform
train
java
d3a0ae10bd2d359f10e75deabe86421856664536
diff --git a/src/http/api/resources/swarm.js b/src/http/api/resources/swarm.js index <HASH>..<HASH> 100644 --- a/src/http/api/resources/swarm.js +++ b/src/http/api/resources/swarm.js @@ -10,13 +10,22 @@ exports = module.exports // common pre request handler that parses the args and returns `addr` which is assigned to `request.pre.args` exports.parseAddrs = (request, reply) => { if (!request.query.arg) { - return reply("Argument 'addr' is required").code(400).takeover() + const err = 'Argument \'addr\' is required' + log.error(err) + return reply({ + Code: 0, + Message: err + }).code(400).takeover() } try { multiaddr(request.query.arg) } catch (err) { - return reply("Argument 'addr' is invalid").code(500).takeover() + log.error(err) + return reply({ + Code: 0, + Message: err.message + }).code(500).takeover() } return reply({
fix: Return swarm http errors as json Closes #<I>
ipfs_js-ipfs
train
js
952d840bef8bc54416deef9a51f76db67c3adfa5
diff --git a/src/commands/deploy.js b/src/commands/deploy.js index <HASH>..<HASH> 100644 --- a/src/commands/deploy.js +++ b/src/commands/deploy.js @@ -360,7 +360,7 @@ const printResults = ({ flags, results, deployToProduction, exit }) => { if (!deployToProduction) { log() log('If everything looks good on your draft URL, deploy it to your main site URL with the --prod flag.') - log(`${chalk.cyanBright.bold('netlify deploy --prod')}`) + log(`${chalk.cyanBright.bold(`netlify deploy${flags.build ? ' --build' : ''} --prod`)}`) log() } }
fix: keep --build flag in deploy message suggestion (#<I>)
netlify_cli
train
js
a9953e1e37c09951ea7111dd2d87937df188aa11
diff --git a/lib/amqp_client.js b/lib/amqp_client.js index <HASH>..<HASH> 100644 --- a/lib/amqp_client.js +++ b/lib/amqp_client.js @@ -350,7 +350,7 @@ AMQPClient.prototype.send = function(msg, target, options) { l.on(Link.Detached, function(details) { debug('link detached: ' + (details ? details.error : 'No details')); self._attached[linkName] = undefined; - if (self._pendingSends[linkName].length > 0) { + if (self._pendingSends[linkName] && self._pendingSends[linkName].length > 0) { attach(); } });
fix(reattach): check for existence of pendingSends before reattach A bug found by @footmarks-skylar where link detach during an attach would cause an exception due to pendingSends not existing (yet).
noodlefrenzy_node-amqp10
train
js
d58d10ff81e929b8c71b4c85d2a38b0eeab2ad5a
diff --git a/chance.js b/chance.js index <HASH>..<HASH> 100644 --- a/chance.js +++ b/chance.js @@ -306,13 +306,14 @@ if (options.exclude) { testRange(!Array.isArray(options.exclude), "Chance: exclude must be an array.") - for (const exclusion of options.exclude) { - testRange(!Number.isInteger(exclusion), "Chance: exclude must be numbers.") + for (var exclusionIndex in options.exclude) { + testRange(!Number.isInteger(options.exclude[exclusionIndex]), "Chance: exclude must be numbers.") } let random = options.min + this.natural({max: options.max - options.min - options.exclude.length}) - for (const exclusion of options.exclude.sort()) { - if (random < exclusion) { + var sortedExclusions = options.exclude.sort(); + for (var exclusionIndex in sortedExclusions) { + if (random < sortedExclusions[exclusionIndex]) { break } random++
fix: make chance js work in es5 environment (#<I>) Chance currently does not work in ie <I> because it uses const and for of These usages can be replaced by var and for in
chancejs_chancejs
train
js
3ec810927d46b37e2e55103a5b1f7751d2cbabe1
diff --git a/cypress/plugins/index.js b/cypress/plugins/index.js index <HASH>..<HASH> 100644 --- a/cypress/plugins/index.js +++ b/cypress/plugins/index.js @@ -23,10 +23,6 @@ const percyHealthCheck = require('@percy/cypress/task'); -module.exports = on => { - on('task', percyHealthCheck); -}; - // plugins file module.exports = (on, cypressConfig) => { // Load the config
chore(cypress): remove duplicated export [skip ci]
commercetools_merchant-center-application-kit
train
js
7b132cf0e9008f5e99d335eed2346cc4e2d009fb
diff --git a/lib/model.js b/lib/model.js index <HASH>..<HASH> 100755 --- a/lib/model.js +++ b/lib/model.js @@ -319,7 +319,14 @@ class Model extends Entity { if (internalTransaction) { // If we created the Transaction instance internally for the update, we commit it // otherwise we leave the commit() call to the transaction creator - return transaction.commit().then(onTransactionSuccess); + return transaction + .commit() + .then(() => transaction.execPostHooks().catch((err) => { + entityUpdated[ + entityUpdated.gstore.ERR_HOOKS + ] = (entityUpdated[entityUpdated.gstore.ERR_HOOKS] || []).push(err); + })) + .then(onTransactionSuccess); } return onTransactionSuccess();
fix: call execPostHooks on internalTransaction (#<I>)
sebelga_gstore-node
train
js
ff5b3ed7a32f9c37db96931b002c8cda7a621c4f
diff --git a/src/Checkpoints/ActivationCheckpoint.php b/src/Checkpoints/ActivationCheckpoint.php index <HASH>..<HASH> 100644 --- a/src/Checkpoints/ActivationCheckpoint.php +++ b/src/Checkpoints/ActivationCheckpoint.php @@ -79,5 +79,7 @@ class ActivationCheckpoint implements CheckpointInterface throw $exception; } + + return $completed; } }
fix: Activations Checkpoint missing return (#<I>)
cartalyst_sentinel
train
php
9beba5c17990b64bd75fcd3a0d1a27bf3f3c6118
diff --git a/lib/iso3166Data.js b/lib/iso3166Data.js index <HASH>..<HASH> 100644 --- a/lib/iso3166Data.js +++ b/lib/iso3166Data.js @@ -1190,7 +1190,7 @@ module.exports = [ alpha3: 'MUS', country_code: '230', country_name: 'Mauritius', - mobile_begin_with: [5], + mobile_begin_with: ['5'], phone_number_lengths: [8] }, {
fix: MUS incorrect int type in mobile_begin_with
AfterShip_phone
train
js
4321f2ee7c4e3b13a527b18a04714f2c26356601
diff --git a/client/js/templating.js b/client/js/templating.js index <HASH>..<HASH> 100644 --- a/client/js/templating.js +++ b/client/js/templating.js @@ -574,6 +574,13 @@ qq.Templating = function(spec) { qq.extend(options, spec); log = options.log; + // No need to worry about conserving CPU or memory on older browsers, + // since there is no ability to preview, and thumbnail display is primitive and quick. + if (!qq.supportedFeatures.imagePreviews) { + options.limits.timeBetweenThumbs = 0; + options.limits.maxThumbs = 0; + } + container = options.containerEl; showThumbnails = options.imageGenerator !== undefined; templateHtml = parseAndGetTemplate();
fix(previews): No limits for older browsers. TODO: - Cleanup templating module code. - Don’t pause before next thumbnail generation attempt if we’ve already hit the maxCount. Only increment generatePreviews if an image without a valid preview has been updated via server’s thumbnail response. - Update styling doc. #<I>
FineUploader_fine-uploader
train
js
30f7402d8ad80c0f36f157848d295a778f607775
diff --git a/lib/grunt/tasks/release.js b/lib/grunt/tasks/release.js index <HASH>..<HASH> 100644 --- a/lib/grunt/tasks/release.js +++ b/lib/grunt/tasks/release.js @@ -22,6 +22,12 @@ module.exports = function(grunt) { "aws_s3:develop" ]); + grunt.registerTask("prepublish", [ + "clean", + "package", + "prepare-npm" + ]); + grunt.registerTask("release-travis", function() { if (process.env.TRAVIS_PULL_REQUEST === "false") { if (process.env.TRAVIS_BRANCH === "master") {
feat(prepublish): prepares for npm publish
FineUploader_fine-uploader
train
js
f09eaa13f4168754793c275e65c44e51661f4264
diff --git a/generics_test.go b/generics_test.go index <HASH>..<HASH> 100644 --- a/generics_test.go +++ b/generics_test.go @@ -5,7 +5,6 @@ package swag import ( "encoding/json" - "os" "testing" "github.com/stretchr/testify/assert" @@ -204,7 +203,7 @@ func TestParseGenericsBasic(t *testing.T) { p := New() err := p.ParseAPI(searchDir, mainAPIFile, defaultParseDepth) assert.NoError(t, err) - b, _ := json.MarshalIndent(p.swagger, "", " ") - os.WriteFile("testdata/generics_basic/swagger.json", b, 0644) + b, err := json.MarshalIndent(p.swagger, "", " ") + assert.NoError(t, err) assert.Equal(t, expected, string(b)) }
chore: cleanup generics_test.go (#<I>)
swaggo_swag
train
go
be3351f52a17da76c0f0fdeb95f1d9dfbb38ea40
diff --git a/scripts/startRelease.js b/scripts/startRelease.js index <HASH>..<HASH> 100644 --- a/scripts/startRelease.js +++ b/scripts/startRelease.js @@ -7,6 +7,7 @@ const packageNames = [ '@ringcentral-integration/locale-loader', '@ringcentral-integration/phone-number', '@ringcentral-integration/glip-widgets', + '@ringcentral-integration/core', ]; const releaseBranchNames = [ 'commons-release', @@ -15,6 +16,7 @@ const releaseBranchNames = [ 'locale-loader-release', 'phone-number-release', 'glip-widgets-release', + 'core-release', ]; const args = process.argv.slice(2);
fix: core release script (#<I>)
ringcentral_ringcentral-js-widgets
train
js
a44e238077b33c1ff57378aa4d469524615cb6fd
diff --git a/src/utils.js b/src/utils.js index <HASH>..<HASH> 100644 --- a/src/utils.js +++ b/src/utils.js @@ -137,7 +137,7 @@ exports.calcCreepCost = function(body) { exports.checkConstructionSite = function(objects, structureType, x, y) { var borderTiles; - if(structureType != 'road' && (x == 1 || x == 48 || y == 1 || y == 48)) { + if(structureType != 'road' && structureType != 'container' && (x == 1 || x == 48 || y == 1 || y == 48)) { if(x == 1) borderTiles = [[0,y-1],[0,y],[0,y+1]]; if(x == 48) borderTiles = [[49,y-1],[49,y],[49,y+1]]; if(y == 1) borderTiles = [[x-1,0],[x,0],[x+1,0]];
feat: Allow containers next to exit tiles DEV-<I>
screeps_engine
train
js
9c36489297baa1897bfefd961c93ac2957c4e254
diff --git a/index.js b/index.js index <HASH>..<HASH> 100644 --- a/index.js +++ b/index.js @@ -734,6 +734,7 @@ var elapsed = (+new Date()) - startTime; if (elapsed >= duration) { setPosition(newX, newY); + fireEvent('scrollMove', eventStartX, eventStartY, newX, newY, newX - x, newY - y); finish(); return; }
fix: scrollMove event not fired if duration is 0
misonou_jquery-scrollable
train
js
c205b93629a3dd724755c6499c1014c82af5e45f
diff --git a/packages/posts/webpack.serverless.config.js b/packages/posts/webpack.serverless.config.js index <HASH>..<HASH> 100644 --- a/packages/posts/webpack.serverless.config.js +++ b/packages/posts/webpack.serverless.config.js @@ -55,6 +55,7 @@ if (process.env.DEPLOY && process.env.SENTRY_AUTH_TOKEN) { module.exports = { entry: slsw.lib.entries, mode: resolveMode(), + target: "node", optimization: { minimize: false },
fix(posts): Webpack explicitly targets `node`.
randytarampi_me
train
js
3abce1699090e85156192b0a3d468d16e9c0e7e6
diff --git a/packages/date/src/DateRange.js b/packages/date/src/DateRange.js index <HASH>..<HASH> 100644 --- a/packages/date/src/DateRange.js +++ b/packages/date/src/DateRange.js @@ -159,7 +159,7 @@ const DateRange = ({ const onFocusChange = async input => { if (!autoSync && !input) await setFieldTouched(name, true); - if (autoSync && !(focusedInput !== input)) await syncDates(); + if (autoSync && focusedInput === input) await syncDates(); setFocusedInput(input); if (onPickerFocusChange) onPickerFocusChange({ focusedInput: input }); };
fix(date): edited condition for clarity
Availity_availity-react
train
js
69f3914bb1b2ed46217ffbc2f0cb8eaaac509a83
diff --git a/lib/stack.js b/lib/stack.js index <HASH>..<HASH> 100644 --- a/lib/stack.js +++ b/lib/stack.js @@ -356,12 +356,20 @@ Stack.prototype.run = function(name, region, revision, user, finalCallback) { }); } async.series(finallyTasks, function(_err) { + var finallySeconds = (Date.now() - start) / 1000; + if (_err) { - baton.log.errorf('Target \'${target}\' FAILED in ${seconds}s while running "finally" block', { - target: name, + baton.log.errorf('Target \'${target}\' FAILED in ${seconds}s', { + target: 'finally', seconds: seconds, err: _err.toString() }); + } else if (err) { + baton.log.errorf('Target \'finally\' SUCCESS in ${seconds}s, but target \'${target}\' FAILED', { + target: 'finally', + seconds: finallySeconds, + err: _err.toString() + }); } else { self.current.success = true; baton.log.infof('Target \'${target}\' SUCCESS in ${seconds}s', {
fix(stack): Fail deploy if deploy target fails, even if finally target succeeds stack.js: do not set success in the 'finally' block if an error occurred in the 'deploy' target
racker_dreadnot
train
js
5013da3d2534ded6bee37288c257caeb613b64c7
diff --git a/pkg/helm/interface.go b/pkg/helm/interface.go index <HASH>..<HASH> 100644 --- a/pkg/helm/interface.go +++ b/pkg/helm/interface.go @@ -27,4 +27,5 @@ type Interface interface { DeleteRelease(rlsName string, opts ...DeleteOption) (*rls.UninstallReleaseResponse, error) ReleaseStatus(rlsName string, opts ...StatusOption) (*rls.GetReleaseStatusResponse, error) UpdateRelease(rlsName string, opts ...UpdateOption) (*rls.UpdateReleaseResponse, error) + ReleaseContent(rlsName string, opts ...ContentOption) (*rls.GetReleaseContentResponse, error) }
fix(helm): add ReleaseContent to interface
helm_helm
train
go
11f9118551b511b5c133eacb2550729e5b696434
diff --git a/src/util/BitField.js b/src/util/BitField.js index <HASH>..<HASH> 100644 --- a/src/util/BitField.js +++ b/src/util/BitField.js @@ -103,7 +103,7 @@ class BitField { */ serialize(...hasParams) { const serialized = {}; - for (const perm in this.constructor.FLAGS) serialized[perm] = this.has(perm, ...hasParams); + for (const [flag, bit] of Object.entries(this.constructor.FLAGS)) serialized[flag] = this.has(bit, ...hasParams); return serialized; }
fix(BitField): remove for..in in favor of Object.entries (#<I>) * fix(BitField): remove for..in in favor of Object.keys * refactor: do not re-resolve bits
discordjs_discord.js
train
js
190e896eb1cacb4c1a348982aafee4747b6ae944
diff --git a/lib/datasource/github.js b/lib/datasource/github.js index <HASH>..<HASH> 100644 --- a/lib/datasource/github.js +++ b/lib/datasource/github.js @@ -39,7 +39,7 @@ function getCacheKey(repo, type) { async function getDigest(config) { let githubRepo = config.githubRepo || config.depNameShort; - if (config.purl) { + if (!githubRepo && config.purl) { githubRepo = config.purl.replace('pkg:github/', '').split('?')[0]; } const cachedResult = await renovateCache.get(
fix(github): getDigest lookup
renovatebot_renovate
train
js
6e8ddcccd73d9000f7d35b3b64eb3f0025fffa9f
diff --git a/packages/@vue/cli-ui/vue.config.js b/packages/@vue/cli-ui/vue.config.js index <HASH>..<HASH> 100644 --- a/packages/@vue/cli-ui/vue.config.js +++ b/packages/@vue/cli-ui/vue.config.js @@ -33,5 +33,6 @@ module.exports = { import: ['~@/style/imports'] } } - } + }, + parallel: !process.env.CIRCLECI }
ci: disable thread-loader on circleci
vuejs_vue-cli
train
js
3c4cfb475b0a4fb3d97397498547c108661978fb
diff --git a/mongo_connector/connector.py b/mongo_connector/connector.py index <HASH>..<HASH> 100755 --- a/mongo_connector/connector.py +++ b/mongo_connector/connector.py @@ -667,9 +667,8 @@ def main(): ## Create a mapping of source ns to dest ns as a dict dest_mapping = dict(zip(ns_set, dest_ns_set)) - if options.fields is None: - fields = [] - else: + fields = options.fields + if fields is not None: fields = options.fields.split(',') key = None
fix: do not set fields to empty list when --fields not parsed on command-line
yougov_mongo-connector
train
py
0e65c768f7787cba992de98932422310816f6154
diff --git a/src/Kernel/index.js b/src/Kernel/index.js index <HASH>..<HASH> 100644 --- a/src/Kernel/index.js +++ b/src/Kernel/index.js @@ -269,6 +269,12 @@ class Kernel { */ invoke () { process.env.NO_ANSI = 'false' + + const commandName = process.argv.slice(2) + if (!commandName || !commandName[0]) { + return commander.outputHelp() + } + commander.parse(process.argv) }
feat(kernel): show help when no command is executed
adonisjs_ace
train
js
972bc555d58e8b7143a27d573e7936973aec7743
diff --git a/lib/platform/bitbucket-server/index.js b/lib/platform/bitbucket-server/index.js index <HASH>..<HASH> 100644 --- a/lib/platform/bitbucket-server/index.js +++ b/lib/platform/bitbucket-server/index.js @@ -594,10 +594,15 @@ async function mergePr(prNo) { logger.debug(`mergePr(${prNo})`); // TODO: Needs implementation // Used for "automerge" feature + const { version } = (await api.get( + `/rest/api/1.0/projects/${config.projectKey}/repos/${ + config.repositorySlug + }/pull-requests/${prNo}` + )).body; await api.post( `/rest/api/1.0/projects/${config.projectKey}/repos/${ config.repositorySlug - }/pull-requests/${prNo}/merge` + }/pull-requests/${prNo}/merge?version=${version}` ); }
fix(bitbucket-server): get the PR version before auto-merging
renovatebot_renovate
train
js
44829ba17fa3ef1e176b1cefdd3d60ce99896aa0
diff --git a/src/AuthenticationRequest.js b/src/AuthenticationRequest.js index <HASH>..<HASH> 100644 --- a/src/AuthenticationRequest.js +++ b/src/AuthenticationRequest.js @@ -82,7 +82,7 @@ class AuthenticationRequest { let configuration = provider.configuration assert(configuration, 'OpenID Configuration required. Invoke the discover method.') - let endpoint = configuration.authorize_endpoint + let endpoint = configuration.authorization_endpoint assert(endpoint, 'OpenID Configuration does not specify the authorize endpoint.') let registration = this.registration
fix(AuthenticationRequest): correct reference to authorization_endpoint
anvilresearch_oidc-rp
train
js
0c0bc1f7695a6bb9b0a88f34c500c1628bb13868
diff --git a/controller/appcontroller.go b/controller/appcontroller.go index <HASH>..<HASH> 100644 --- a/controller/appcontroller.go +++ b/controller/appcontroller.go @@ -360,7 +360,7 @@ func isKnownOrphanedResourceExclusion(key kube.ResourceKey, proj *appv1.AppProje func (ctrl *ApplicationController) getResourceTree(a *appv1.Application, managedResources []*appv1.ResourceDiff) (*appv1.ApplicationTree, error) { nodes := make([]appv1.ResourceNode, 0) - proj, err := argo.GetAppProject(&a.Spec, applisters.NewAppProjectLister(ctrl.projInformer.GetIndexer()), ctrl.namespace, ctrl.settingsMgr, ctrl.db, context.TODO()) + proj, err := ctrl.getAppProj(a) if err != nil { return nil, err }
refactor: use cached project while calculating resource tree (#<I>)
argoproj_argo-cd
train
go
245107aaa87d80d278664a725cec0b8c65df9e64
diff --git a/src/js/showcar-ui.js b/src/js/showcar-ui.js index <HASH>..<HASH> 100644 --- a/src/js/showcar-ui.js +++ b/src/js/showcar-ui.js @@ -13,10 +13,10 @@ window.Pager = require('./components/pager.js'); require('showcar-icons'); -if (document.createElement('as24-tracking').constructor !== HTMLElement) { - // only requiring showcar-tracking when it was not already included before - require('showcar-tracking'); -} +// if (document.createElement('as24-tracking').constructor !== HTMLElement) { +// // only requiring showcar-tracking when it was not already included before +// require('showcar-tracking'); +// } require('./components/custom-dropdown.js');
test: removed showcar-tracking - does it solve the js error?
Scout24_showcar-ui
train
js
fd23eaf1ca1f157ac9f58d6c9216e30046be0ce4
diff --git a/src/store.js b/src/store.js index <HASH>..<HASH> 100644 --- a/src/store.js +++ b/src/store.js @@ -110,12 +110,14 @@ function setupOfflineKey(config, threshold) { /* istanbul ignore next */ if (previousKeys[k] < getCurrentTimestamp() && !offlineKeys[k]) { window.localStorage.removeItem(k); - } else { - offlineKeys[k] = previousKeys[k]; + delete previousKeys[k]; } }); - window.localStorage.setItem(offlinePrefix, JSON.stringify(offlineKeys)); + window.localStorage.setItem( + offlinePrefix, + JSON.stringify({ ...previousKeys, ...offlineKeys }), + ); clearTimeout = null; }, 1); }
fix(store): don't throw for async setup offline key
hybridsjs_hybrids
train
js
89c1a1da2a55125867c1ddae4cb7144ddb5ca6d5
diff --git a/packages/onesignal/index.js b/packages/onesignal/index.js index <HASH>..<HASH> 100755 --- a/packages/onesignal/index.js +++ b/packages/onesignal/index.js @@ -71,10 +71,13 @@ function addOneSignal (moduleOptions) { } // Add the oneSignal SDK script to head - this.options.head.script.push({ - async: true, - src: options.OneSignalSDK - }) + if (!this.options.head.script.find(s => s.hid === 'onesignal')) { + this.options.head.script.push({ + async: true, + src: options.OneSignalSDK, + hid: 'onesignal' + }) + } // Adjust manifest for oneSignal if (!this.options.manifest) {
fix(onesignal): ensure no duplicate script is added (#<I>)
nuxt-community_pwa-module
train
js
e7d5ea8a6c10fcb234487ce81666350d4ecdd503
diff --git a/build.go b/build.go index <HASH>..<HASH> 100644 --- a/build.go +++ b/build.go @@ -328,9 +328,9 @@ func build(pkg string, tags []string) { func ldflags() string { var b bytes.Buffer b.WriteString("-w") - b.WriteString(fmt.Sprintf(" -X main.version=%s", version)) - b.WriteString(fmt.Sprintf(" -X main.commit=%s", getGitSha())) - b.WriteString(fmt.Sprintf(" -X main.buildstamp=%d", buildStamp())) + b.WriteString(fmt.Sprintf(" -X main.version %s", version)) + b.WriteString(fmt.Sprintf(" -X main.commit %s", getGitSha())) + b.WriteString(fmt.Sprintf(" -X main.buildstamp %d", buildStamp())) return b.String() }
fix(build): revert some build script changes to make building on go <I> work again
grafana_grafana
train
go
e01b747c0b04240275ff2fde72326004bf6b404f
diff --git a/src/lib/http.js b/src/lib/http.js index <HASH>..<HASH> 100644 --- a/src/lib/http.js +++ b/src/lib/http.js @@ -9,7 +9,8 @@ type RequestOptionsType = { json? : Object, data? : { [key : string] : string }, body? : string, - win? : any + win? : any, + timeout? : number }; const HEADERS = { @@ -19,7 +20,7 @@ const HEADERS = { let headerBuilders = []; -export function request({ url, method = 'get', headers = {}, json, data, body, win = window } : RequestOptionsType) : SyncPromise<Object> { +export function request({ url, method = 'get', headers = {}, json, data, body, win = window, timeout = 0 } : RequestOptionsType) : SyncPromise<Object> { return new SyncPromise((resolve, reject) => { @@ -106,6 +107,11 @@ export function request({ url, method = 'get', headers = {}, json, data, body, w }).join('&'); } + xhr.timeout = timeout; + xhr.ontimeout = function () { + reject(new Error(`Request to ${method.toLowerCase()} ${url} has timed out`)); + }; + xhr.send(body); }); }
feat(http): Add XHR Timeout configuration (#<I>)
paypal_paypal-checkout-components
train
js
9c42667b3578bb45ac62868273ba2d44d32675d7
diff --git a/src/test/java/com/smartsheet/api/models/ColumnTagTest.java b/src/test/java/com/smartsheet/api/models/ColumnTagTest.java index <HASH>..<HASH> 100644 --- a/src/test/java/com/smartsheet/api/models/ColumnTagTest.java +++ b/src/test/java/com/smartsheet/api/models/ColumnTagTest.java @@ -45,8 +45,9 @@ public class ColumnTagTest { assertNotNull(ColumnTag.valueOf("GANTT_DURATION")); assertNotNull(ColumnTag.valueOf("GANTT_ASSIGNED_RESOURCE")); assertNotNull(ColumnTag.valueOf("GANTT_DURATION")); + assertNotNull(ColumnTag.valueOf("CARD_DONE")); - assertEquals(10,ColumnTag.values().length); + assertEquals(11,ColumnTag.values().length); } }
fix: dev: fix column tag test to include CARD_DONE
smartsheet-platform_smartsheet-java-sdk
train
java
7624c8b9bbf9e30e316dc85e6e28cd06ce030b30
diff --git a/cmd/format-erasure.go b/cmd/format-erasure.go index <HASH>..<HASH> 100644 --- a/cmd/format-erasure.go +++ b/cmd/format-erasure.go @@ -27,6 +27,7 @@ import ( "sync" humanize "github.com/dustin/go-humanize" + "github.com/minio/minio/cmd/config" "github.com/minio/minio/cmd/config/storageclass" "github.com/minio/minio/cmd/logger" "github.com/minio/minio/pkg/color" @@ -908,7 +909,8 @@ func getDefaultParityBlocks(drive int) int { // ecDrivesNoConfig returns the erasure coded drives in a set if no config has been set. // It will attempt to read it from env variable and fall back to drives/2. func ecDrivesNoConfig(setDriveCount int) int { - ecDrives := globalStorageClass.GetParityForSC(storageclass.STANDARD) + sc, _ := storageclass.LookupConfig(config.KVS{}, setDriveCount) + ecDrives := sc.GetParityForSC(storageclass.STANDARD) if ecDrives <= 0 { ecDrives = getDefaultParityBlocks(setDriveCount) }
fix: honor storage class uniformity for multiple pools (#<I>)
minio_minio
train
go
f2044208ad676da3c40c1857cd03f89c76ffdba2
diff --git a/manifest.php b/manifest.php index <HASH>..<HASH> 100755 --- a/manifest.php +++ b/manifest.php @@ -175,11 +175,6 @@ return [ AccessRule::GRANT, TaoItemsRoles::ITEM_CONTENT_CREATOR, ['ext' => 'taoItems', 'mod' => 'Items', 'act' => 'authoring'], - ], - [ - AccessRule::GRANT, - TaoItemsRoles::ITEM_CONTENT_CREATOR, - ['ext' => 'taoItems', 'mod' => 'ItemContent', 'act' => 'files'], ] ], 'optimizableClasses' => [
refactor: remove unecessary rule
oat-sa_extension-tao-item
train
php
ccf1c414fc4b446fe8eefd1d5efe7c8c2b74e87c
diff --git a/test/index.spec.js b/test/index.spec.js index <HASH>..<HASH> 100644 --- a/test/index.spec.js +++ b/test/index.spec.js @@ -45,10 +45,13 @@ let instumenterSuite = describe("Isparta instrumenter", function () { }); -function generateSourceMapTest(done) { +function generateSourceMapTest(allDone) { let instrumenter = new Instrumenter(); - getFixturesTest().map((fixtureTest) => { + const fixturesToTest = getFixturesTest(); + const done = after(fixturesToTest.length, allDone); + + fixturesToTest.map((fixtureTest) => { let {name, actual} = fixtureTest; @@ -66,8 +69,6 @@ function generateSourceMapTest(done) { done(); }); - - }); @@ -128,4 +129,10 @@ function testCoverMaps(maps, fixtureTest) { } +// + +// Minimal Lodash util functions function values(arr) { return Object.keys(arr).map(key => arr[key] || {}); } +function after(n, func) { return function () { + if (--n < 1) { return func.apply(this, arguments); } +};}
fix(test): done() called multiple times
douglasduteil_isparta
train
js
03ff83617e9c636a697686e19022a3d1a3459875
diff --git a/src/geshi.php b/src/geshi.php index <HASH>..<HASH> 100644 --- a/src/geshi.php +++ b/src/geshi.php @@ -1841,12 +1841,14 @@ class GeSHi { // //Now we need to rewrite our array to get a search string that $symbol_preg = array(); - if (!empty($symbol_preg_single)) { - $symbol_preg[] = '[' . implode('', $symbol_preg_single) . ']'; - } if (!empty($symbol_preg_multi)) { + rsort($symbol_preg_multi); $symbol_preg[] = implode('|', $symbol_preg_multi); } + if (!empty($symbol_preg_single)) { + rsort($symbol_preg_single); + $symbol_preg[] = '[' . implode('', $symbol_preg_single) . ']'; + } $this->language_data['SYMBOL_SEARCH'] = implode("|", $symbol_preg); }
fix: Ensure longest match for multichar symbols
GeSHi_geshi-1.0
train
php
e5ed1b43478feeaf1806acb11f8872dd1173a7bd
diff --git a/treetime/treetime.py b/treetime/treetime.py index <HASH>..<HASH> 100644 --- a/treetime/treetime.py +++ b/treetime/treetime.py @@ -270,6 +270,10 @@ class TreeTime(ClockTree): tt_kwargs['time_marginal']=time_marginal self.make_time_tree(**tt_kwargs) + self.trace_run.append(self.tracelog_run(niter=niter+1, ndiff=0, n_resolved=0, + time_marginal = tt_kwargs['time_marginal'], + sequence_marginal = seq_kwargs['marginal_sequences'], Tc=Tc, tracelog=tracelog_file)) + # explicitly print out which branches are bad and whose dates don't correspond to the input dates bad_branches =[n for n in self.tree.get_terminals() if n.bad_branch and n.raw_date_constraint]
feat: add final round to tracelog
neherlab_treetime
train
py
dad2d8b893032b37fd388f83faa6f4819429d931
diff --git a/aftership/tracking.py b/aftership/tracking.py index <HASH>..<HASH> 100644 --- a/aftership/tracking.py +++ b/aftership/tracking.py @@ -58,9 +58,26 @@ def delete_tracking(*, tracking_id=None, slug=None, tracking_number=None, **kwar def list_trackings(**kwargs): """Get tracking results of multiple trackings. """ - optional_keys = ('page', 'limit', 'keyword', 'slug', 'delivery_time', 'origin', - 'destination', 'tag', 'created_at_min', 'created_at_max', - 'fields', 'lang') + optional_keys = ( + 'page', + 'limit', + 'keyword', + 'tracking_numbers', + 'slug', + 'delivery_time', + 'origin', + 'destination', + 'tag', + 'created_at_min', + 'created_at_max', + 'updated_at_min', + 'updated_at_max', + 'fields', + 'lang', + 'last_updated_at', + 'return_to_sender', + 'courier_destination_country_iso3', + ) params = {key: kwargs.pop(key) for key in optional_keys if key in kwargs}
feat: add more fields for `Get trackings` API (#<I>) add more fields for `Get trackings` API
AfterShip_aftership-sdk-python
train
py
2c017df794510982d547f16d4e0cc3668c5eb3a6
diff --git a/build/parse-npm-tag.js b/build/parse-npm-tag.js index <HASH>..<HASH> 100644 --- a/build/parse-npm-tag.js +++ b/build/parse-npm-tag.js @@ -8,6 +8,9 @@ if (!semver.valid(version)) { } const prerelease = semver.prerelease(version) -const prereleaseTag = (prerelease || [])[0] || '' -console.log(/^[a-zA-Z]+$/.test(prereleaseTag) ? prereleaseTag : 'latest') +if (prerelease == null) { + console.log('latest') +} else { + console.log('next') +}
chore(build): always tag prerelease versions as 'next'
vuetifyjs_vuetify
train
js
9dae5a7c854ff24adbe11b0419eda26ac1721fdb
diff --git a/cmd/generic-handlers.go b/cmd/generic-handlers.go index <HASH>..<HASH> 100644 --- a/cmd/generic-handlers.go +++ b/cmd/generic-handlers.go @@ -154,15 +154,15 @@ func setRedirectHandler(h http.Handler) http.Handler { func guessIsBrowserReq(r *http.Request) bool { aType := getRequestAuthType(r) - ok := strings.Contains(r.Header.Get("User-Agent"), "Mozilla") && globalBrowserEnabled && - (aType == authTypeJWT || aType == authTypeAnonymous) - return ok + return strings.Contains(r.Header.Get("User-Agent"), "Mozilla") && + globalBrowserEnabled && aType == authTypeAnonymous } func setBrowserRedirectHandler(h http.Handler) http.Handler { return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { + read := r.Method == http.MethodGet || r.Method == http.MethodHead // Re-direction is handled specifically for browser requests. - if guessIsBrowserReq(r) { + if guessIsBrowserReq(r) && read { // Fetch the redirect location if any. if u := getRedirectLocation(r); u != nil { // Employ a temporary re-direct.
fix: only redirect for GET/HEAD requests (#<I>) fixes #<I>
minio_minio
train
go
4ea11d92dcaed340e24c88421d5642c2b7ea9541
diff --git a/src/init.js b/src/init.js index <HASH>..<HASH> 100644 --- a/src/init.js +++ b/src/init.js @@ -48,7 +48,7 @@ function onInstall(projectDir, testMode) { } function reportNoHooksOnItself() { - console.log(chalk.bgYellow(POST_INSTALL_HOOKS_ARE_IGNORED)); + console.log(chalk.inverse(POST_INSTALL_HOOKS_ARE_IGNORED)); } function reportHooksAdded() {
style(chalk): take a color that is cross-platform friendly
inikulin_publish-please
train
js
fde11a3b7f8aab2b2cd6275b43d4d2e83a65fe8e
diff --git a/tests/test_repro.py b/tests/test_repro.py index <HASH>..<HASH> 100644 --- a/tests/test_repro.py +++ b/tests/test_repro.py @@ -380,7 +380,7 @@ class TestReproExternalGS(TestReproExternalBase): return TEST_GCP_REPO_BUCKET def cmd(self, i, o): - return 'gsutil cp {} {}'.format(i, o) + return 'GOOGLE_APPLICATION_CREDENTIALS={} gsutil cp {} {}'.format(os.getenv(GOOGLE_APPLICATION_CREDENTIALS,''), i, o) def write(self, bucket, key, body): client = gc.Client()
test: use GOOGLE_APPLICATION_CREDENTIALS when running GS repro test
iterative_dvc
train
py
d4e2cde1ea56d96c3d5278277e29857c4ade3535
diff --git a/dev/test/products/list.spec.js b/dev/test/products/list.spec.js index <HASH>..<HASH> 100644 --- a/dev/test/products/list.spec.js +++ b/dev/test/products/list.spec.js @@ -1,6 +1,6 @@ 'use strict'; -describe('Products endpoint', function() { +describe.skip('Products endpoint', function() { before(function() {}); afterEach(async function() {});
test(products): temporary skip products tests MAGENTO-OPS
emartech_magento2-extension
train
js
a0003ef52ba3b92562223e0c3487f4de102f5abe
diff --git a/packages/application-shell/src/components/version-tracker/version-tracker.js b/packages/application-shell/src/components/version-tracker/version-tracker.js index <HASH>..<HASH> 100644 --- a/packages/application-shell/src/components/version-tracker/version-tracker.js +++ b/packages/application-shell/src/components/version-tracker/version-tracker.js @@ -15,6 +15,14 @@ const createVersionMetric = ({ applicationName }) => [ package_version: applicationShellVersion, }, }, + { + metricName: 'npm_dependency_versions', + metricLabels: { + application: applicationName || 'unknown', + package_name: 'react', + package_version: React.version, + }, + }, ]; export class VersionTracker extends React.Component {
feat(app-shell): add reporting react version (#<I>)
commercetools_merchant-center-application-kit
train
js
fb6e00045726d606d24385a6f5c23c7f2048b0a0
diff --git a/test/lib/quagga.py b/test/lib/quagga.py index <HASH>..<HASH> 100644 --- a/test/lib/quagga.py +++ b/test/lib/quagga.py @@ -228,10 +228,13 @@ class QuaggaBGPContainer(BGPContainer): f.writelines(str(c)) def vtysh(self, cmd, config=True): + if type(cmd) is not list: + cmd = [cmd] + cmd = ' '.join("-c '{0}'".format(c) for c in cmd) if config: - return self.local("vtysh -d bgpd -c 'en' -c 'conf t' -c 'router bgp {0}' -c '{1}'".format(self.asn, cmd), capture=True) + return self.local("vtysh -d bgpd -c 'en' -c 'conf t' -c 'router bgp {0}' {1}".format(self.asn, cmd), capture=True) else: - return self.local("vtysh -d bgpd -c '{0}'".format(cmd), capture=True) + return self.local("vtysh -d bgpd {0}".format(cmd), capture=True) def reload_config(self): daemon = []
test: enable pass multiple commands to vtysh()
osrg_gobgp
train
py
72ed33c4eaa4823366fb47f212f0c5e609fa2cf0
diff --git a/npm/react/plugins/next/findNextWebpackConfig.js b/npm/react/plugins/next/findNextWebpackConfig.js index <HASH>..<HASH> 100644 --- a/npm/react/plugins/next/findNextWebpackConfig.js +++ b/npm/react/plugins/next/findNextWebpackConfig.js @@ -29,11 +29,14 @@ async function getNextWebpackConfig (config) { buildId: `@cypress/react-${Math.random().toString()}`, config: nextConfig, dev: true, - isServer: false, pagesDir: findPagesDir(config.projectRoot), entrypoints: {}, rewrites: { fallback: [], afterFiles: [], beforeFiles: [] }, ...runWebpackSpan, + // Client webpack config for Next.js <= 12.1.5 + isServer: false, + // Client webpack config for Next.js > 12.1.5 + compilerType: 'client', }, )
fix: add support for Next.js <I> (#<I>)
cypress-io_cypress
train
js
2a5695aa7bfec918bfbfc847c4823d4038118f6b
diff --git a/models/AssessmentResultResolver/AssessmentResultFileResponseResolver.php b/models/AssessmentResultResolver/AssessmentResultFileResponseResolver.php index <HASH>..<HASH> 100644 --- a/models/AssessmentResultResolver/AssessmentResultFileResponseResolver.php +++ b/models/AssessmentResultResolver/AssessmentResultFileResponseResolver.php @@ -16,7 +16,7 @@ use tao_helpers_File; class AssessmentResultFileResponseResolver { - private const PATTERN = '/^(?<fileName>[^,]+).*download_url,(?<downloadUrl>[^,]+)/'; + private const PATTERN = '/^(?<' . self::FILENAME_KEY . '>[^,]+).*download_url,(?<' . self::DOWNLOAD_URL_KEY . '>[^,]+)/'; private const FILENAME_KEY = 'fileName'; private const DOWNLOAD_URL_KEY = 'downloadUrl';
refactor: use constants in pattern string
oat-sa_extension-tao-outcome
train
php
0fb8037dccaa65ab2c60caebec1ff54f1378259d
diff --git a/lib/with-tarball-stream.js b/lib/with-tarball-stream.js index <HASH>..<HASH> 100644 --- a/lib/with-tarball-stream.js +++ b/lib/with-tarball-stream.js @@ -42,6 +42,13 @@ function withTarballStream (spec, opts, streamHandler) { .pipe(verifier) return streamHandler(stream) }) + .catch(err => { + if (err.code === 'EINTEGRITY') { + opts.log.warn('pacote', `EINTEGRITY while extracting ${spec} from ${file}.You will have to recreate the file.`) + opts.log.verbose('pacote', `EINTEGRITY for ${spec}: ${err.message}`) + } + throw err + }) }) : BB.reject(Object.assign(new Error('no file!'), {code: 'ENOENT'}))
feat(logging): let users know when file: resolved packages fail integrity check
zkat_pacote
train
js
7bcf6f191037d797a5a0a7210873efe889600f10
diff --git a/logspout/logspout.go b/logspout/logspout.go index <HASH>..<HASH> 100644 --- a/logspout/logspout.go +++ b/logspout/logspout.go @@ -68,7 +68,7 @@ func syslogStreamer(target Target, types []string, logstream chan *Log) { // HACK: Go's syslog package hardcodes the log format, so let's send our own message _, err = fmt.Fprintf(conn, "%s %s[%s]: %s", - time.Now().Format("2006-01-02 15:04:05"), + time.Now().Format("2006-01-02 15:04:05 MST"), tag, pid, logline.Data)
fix(logspout): add timezone to logs
deis_deis
train
go
27a0b0f3d372612fd5ae7cc693154730f97ef72b
diff --git a/sdk/dist/cc.angular.js b/sdk/dist/cc.angular.js index <HASH>..<HASH> 100644 --- a/sdk/dist/cc.angular.js +++ b/sdk/dist/cc.angular.js @@ -2514,7 +2514,7 @@ angular.module('sdk.directives.ccInclude') $http .get(templateUrl, {cache: $templateCache}) .success(function (tplContent) { - element.replaceWith($compile(tplContent)(scope)); + element.replaceWith($compile(tplContent.trim())(scope)); }); } }; diff --git a/sdk/src/directives/ccInclude/ccInclude.js b/sdk/src/directives/ccInclude/ccInclude.js index <HASH>..<HASH> 100644 --- a/sdk/src/directives/ccInclude/ccInclude.js +++ b/sdk/src/directives/ccInclude/ccInclude.js @@ -12,7 +12,7 @@ angular.module('sdk.directives.ccInclude') $http .get(templateUrl, {cache: $templateCache}) .success(function (tplContent) { - element.replaceWith($compile(tplContent)(scope)); + element.replaceWith($compile(tplContent.trim())(scope)); }); } };
fix(ccInclude): trim template before compile
sofa_sofa-couch-service
train
js,js
a41ac93f2ca72b1492ab153a1fb7d15805fa963f
diff --git a/src/queue.js b/src/queue.js index <HASH>..<HASH> 100644 --- a/src/queue.js +++ b/src/queue.js @@ -89,6 +89,7 @@ Queue.prototype.addItem = function(item, callback, originalError, originalItem) this._maybeLog(item, originalError); this.removePendingItem(originalItem); if (!this.options.transmit) { + callback(new Error('Transmit disabled')); return; } this.pendingRequests.push(item); diff --git a/test/queue.test.js b/test/queue.test.js index <HASH>..<HASH> 100644 --- a/test/queue.test.js +++ b/test/queue.test.js @@ -514,7 +514,9 @@ describe('addItem', function() { var queue = new Queue(rateLimiter, api, logger, options); var makeApiRequestStub = sinon.stub(queue, '_makeApiRequest'); - queue.addItem({mykey: 'myvalue'}); + queue.addItem({mykey: 'myvalue'}, function(err) { + expect(err.message).to.eql('Transmit disabled'); + }); expect(makeApiRequestStub.called).to.eql(0);
fix: use callback for non-transmitted items
rollbar_rollbar.js
train
js,js
11a8ae9f9c8b4afff916d74cba69eb46096d973e
diff --git a/test/bin-utils.js b/test/bin-utils.js index <HASH>..<HASH> 100644 --- a/test/bin-utils.js +++ b/test/bin-utils.js @@ -62,7 +62,6 @@ test('determine config, rules and plugins, relative path', t => { t.true(typeof retrievedConfig.rules === 'object', 'config object should contain rules') t.same(retrievedRules, expectedRuleSet, 'retrieved rules should equal expected rules') - t.true(Array.isArray(retrievedConfig.plugins), 'config object should contain plugins') t.same(retrievedConfig.plugins, ['react'], 'retrieved plugins should contain only "react"') t.same(possiblePluginRules, expectedPluginRuleSet, 'retrieved plugin rules should equal expected plugin rules') }) @@ -80,7 +79,6 @@ test('determine config, rules and plugins, absolute path', t => { t.true(typeof retrievedConfig.rules === 'object', 'config object should contain rules') t.same(retrievedRules, expectedRuleSet, 'retrieved rules should equal expected rules') - t.true(Array.isArray(retrievedConfig.plugins), 'config object should contain plugins') t.same(retrievedConfig.plugins, ['react'], 'retrieved plugins should contain only "react"') t.same(possiblePluginRules, expectedPluginRuleSet, 'retrieved plugin rules should equal expected plugin rules') })
refactor(tests): Remove unnecessary assertion
kentcdodds_eslint-find-new-rules
train
js
f9b37957d99f487574dd54a9b255b481882d957b
diff --git a/cmd/helm/package.go b/cmd/helm/package.go index <HASH>..<HASH> 100644 --- a/cmd/helm/package.go +++ b/cmd/helm/package.go @@ -166,7 +166,7 @@ func (p *packageCmd) clearsign(filename string) error { // promptUser implements provenance.PassphraseFetcher func promptUser(name string) ([]byte, error) { fmt.Printf("Password for key %q > ", name) - pw, err := terminal.ReadPassword(syscall.Stdin) + pw, err := terminal.ReadPassword(int(syscall.Stdin)) fmt.Println() return pw, err }
fix(helm): fix prompt error on Windows build This backs out an earlier change that removed an int type assertion.
helm_helm
train
go
339cd0851ce022f65a3895341a7e3a825c267c3d
diff --git a/cloudvolume/datasource/graphene/sharding.py b/cloudvolume/datasource/graphene/sharding.py index <HASH>..<HASH> 100644 --- a/cloudvolume/datasource/graphene/sharding.py +++ b/cloudvolume/datasource/graphene/sharding.py @@ -3,8 +3,8 @@ from ..precomputed.sharding import ShardingSpecification, ShardReader class GrapheneShardReader(ShardReader): def compute_shard_location(self, label): shard_loc = self.spec.compute_shard_location(label) - chunk_id = self.meta.meta.decode_chunk_id_number(label) - filename = str(chunk_id) + '-' + str(shard_loc.shard_number) + '.shard' + chunk_pos_num = self.meta.meta.decode_chunk_postion_number(label) + filename = str(chunk_pos_num) + '-' + str(shard_loc.shard_number) + '.shard' return (filename, shard_loc.minishard_number)
fix(GrapheneShardReader): use correct function for chunk position
seung-lab_cloud-volume
train
py
642ebbc78a0afedd42daf2922f98ce63b74d11f6
diff --git a/test/regexp.js b/test/regexp.js index <HASH>..<HASH> 100644 --- a/test/regexp.js +++ b/test/regexp.js @@ -2,14 +2,14 @@ var requireDir = require('../'); -it('should exclude dot folders by default', function(){ - requireDir('./folder/regexp').should.be.eql({ +it('{test: /\.js$/} returns no .dotfile.js', function(){ + requireDir('./folder/regexp', {test: /\.js$/}).should.be.eql({ 'index': 'regexp' }); }); -it('{regexp: /\.js$/, dot: true} also returns .dotfile.js', function(){ - requireDir('./folder/regexp', {regexp: /\.js$/, dot: true}).should.be.eql({ +it('{test: /\.js$/, dot: true} also gives .dotfile.js', function(){ + requireDir('./folder/regexp', {test: /\.js$/, dot: true}).should.be.eql({ 'index': 'regexp', 'dotfile': '' });
test: modified tests for regexp
stringparser_require.dir
train
js
5ad83a6a65e5944ceb3a41fee2df40ba1f5b03e4
diff --git a/src/structures/Webhook.js b/src/structures/Webhook.js index <HASH>..<HASH> 100644 --- a/src/structures/Webhook.js +++ b/src/structures/Webhook.js @@ -293,10 +293,10 @@ class Webhook { /** * Deletes the webhook. * @param {string} [reason] Reason for deleting this webhook - * @returns {Promise} + * @returns {Promise<void>} */ - delete(reason) { - return this.client.api.webhooks(this.id, this.token).delete({ reason }); + async delete(reason) { + await this.client.api.webhooks(this.id, this.token).delete({ reason }); } /**
fix(Webhook): return void from #delete for consistency. (#<I>)
discordjs_discord.js
train
js
a09c5e451d9ef1a60694c56bd7555f41adf729c3
diff --git a/jest-preset-mc-app.config.js b/jest-preset-mc-app.config.js index <HASH>..<HASH> 100644 --- a/jest-preset-mc-app.config.js +++ b/jest-preset-mc-app.config.js @@ -2,4 +2,7 @@ module.exports = { rtlConfig: { asyncUtilTimeout: process.env.RTL_ASYNC_UTIL_TIMEOUT || 2000, }, + babelConfig: { + disableCoreJs: true, + }, };
fix: disable core-js in test environment (#<I>)
commercetools_merchant-center-application-kit
train
js
e05ff9c272418c5e8f7cb383e7681616889388b7
diff --git a/lib/compiler.js b/lib/compiler.js index <HASH>..<HASH> 100644 --- a/lib/compiler.js +++ b/lib/compiler.js @@ -135,10 +135,17 @@ function buildEnvCommandLineParams(config, envData, $logger) { const args = []; envFlagNames.map(item => { let envValue = envData[item]; - if (!Array.isArray(envValue)) { - envValue = [envValue]; + if (typeof envValue === "boolean") { + if (envValue) { + args.push(`--env.${item}`); + } + } else { + if (!Array.isArray(envValue)) { + envValue = [envValue]; + } + + envValue.map(value => args.push(`--env.${item}=${value}`)) } - envValue.map(value => args.push(`--env.${item}=${value}`)) }); return args;
fix: avoid getting the bool params as strings in the webpack config like a truthy "false". (#<I>)
NativeScript_nativescript-dev-webpack
train
js
66bd86e6d3f387a43bc80b4872ed7c0945aa954e
diff --git a/src/Helpers.php b/src/Helpers.php index <HASH>..<HASH> 100644 --- a/src/Helpers.php +++ b/src/Helpers.php @@ -312,7 +312,7 @@ class Helpers $arr = parse_url($url); if ( isset($arr["scheme"]) ) { - $arr["scheme"] == mb_strtolower($arr["scheme"]); + $arr["scheme"] = mb_strtolower($arr["scheme"]); } // Exclude windows drive letters...
fix: comparing instead of assign Closes #<I>
dompdf_dompdf
train
php
3b49a1e0bc04b61724dd3d7c4b36accccf4c3d43
diff --git a/index.js b/index.js index <HASH>..<HASH> 100755 --- a/index.js +++ b/index.js @@ -15,7 +15,8 @@ const lockfileSpecs = [ ["yarn", "yarn.lock"], ["npm", "npm-shrinkwrap.json"], ["npm", "package-lock.json"], - ["pnpm", "shrinkwrap.yaml"] + ["pnpm", "shrinkwrap.yaml"], + ["pnpm", "pnpm-lock.yaml"] ]; const args = {
feat: Add support for pnpm-lock.yaml (#<I>) * feat: Add support for pnpm-lock.yaml * fix: Fix closing quote
frontsideair_yarnhook
train
js
9dfe49af1ac2ab9a6b2ed5a77eb06df7ba50e441
diff --git a/test/test-dockertools.js b/test/test-dockertools.js index <HASH>..<HASH> 100644 --- a/test/test-dockertools.js +++ b/test/test-dockertools.js @@ -295,6 +295,9 @@ describe('cloud-enablement:dockertools', function () { assert.fileContent('.dockerignore', 'workarea'); assert.fileContent('.dockerignore', 'logs'); }); + it('Dockerfile contains installUtility', function () { + assert.fileContent('Dockerfile', 'installUtility'); + }); it('Dockerfile contains LICENSE_JAR_URL', function () { assert.fileContent('Dockerfile', 'LICENSE_JAR_URL'); });
fix: Restore test to validate installUtility present A prior change to remove APM also ended up removing the test that validates the dockerfile uses installUtility.
ibm-developer_generator-ibm-cloud-enablement
train
js
1559e9898dbf8cabf8e2ae02ee0601fe9cc4883c
diff --git a/zk_shell/keys.py b/zk_shell/keys.py index <HASH>..<HASH> 100644 --- a/zk_shell/keys.py +++ b/zk_shell/keys.py @@ -22,7 +22,7 @@ class Keys(object): def validate_one(cls, keystr): """ validates one key string """ if re.match(r"\w+(?:\.\w+)*$", keystr) is None: - raise cls.Bad("Bad key syntax for: %s. Should be: key1.key2..." % (key)) + raise cls.Bad("Bad key syntax for: %s. Should be: key1.key2..." % (keystr)) @classmethod def from_template(cls, template):
fix(keys): bad variable name
rgs1_zk_shell
train
py