diff
stringlengths 38
1.78k
| msg_token
stringlengths 9
190
|
|---|---|
<nb> class DisplayBookPopupAction extends FBAndroidAction {
}
} ) ;
- if ( Build . VERSION . SDK_INT < Build . VERSION_CODES . LOLLIPOP ) {
- downloadButton . setTextColor ( NUMBER0 ) ;
- cancelButton . setTextColor ( NUMBER0 ) ;
- }
+ downloadButton . setTextColor ( NUMBER0 ) ;
+ cancelButton . setTextColor ( NUMBER0 ) ;
popup . setOnDismissListener ( new PopupWindow . OnDismissListener ( ) {
public void onDismiss ( ) {
|
fixed SDK compatibility
|
<nb> public interface Service {
COMMENT
COMMENT
COMMENT
- COMMENT
- COMMENT
COMMENT
COMMENT
COMMENT
|
Remove throws InterruptedRuntimeException from Service javadocs
|
<nb> public class AddActivity extends BaseNavDrawerActivity implements OnAddShowListe
SINGLE
NdefMessage msg = ( NdefMessage ) rawMsgs [ NUMBER0 ] ;
SearchResult show = new SearchResult ( ) ;
- show . tvdbid = new String ( msg . getRecords ( ) [ NUMBER0 ] . getPayload ( ) ) ;
+ show . tvdbid = Integer . valueOf ( new String ( msg . getRecords ( ) [ NUMBER0 ] . getPayload ( ) ) ) ;
show . title = new String ( msg . getRecords ( ) [ NUMBER1 ] . getPayload ( ) ) ;
show . overview = new String ( msg . getRecords ( ) [ NUMBER2 ] . getPayload ( ) ) ;
|
Use new int show tvdbid for Android Beam
|
<nb> public interface ConfigurationService
public void reloadConfiguration ( )
throws IOException , XMLException ;
+ COMMENT
+ COMMENT
+ COMMENT
+ COMMENT
+ COMMENT
+ public void purgeStoredConfiguration ( ) ;
+
}
|
Added a method allowing purge of the configuration file
|
<nb> public abstract class SharedTreeV2 < B extends SharedTree , S extends SharedTreeV2 <
STRING0 , STRING1 , STRING2 , STRING3 , STRING4
} ;
- @ api ( help = STRING5 )
+ @ api ( help = STRING6 )
public int ntrees ;
- @ api ( help = STRING7 )
+ @ api ( help = STRING8 )
public int max_depth ;
- @ api ( help = STRING9 )
+ @ api ( help = STRING10 )
public int min_rows ;
@ api ( help = STRING11 )
<nb> public abstract class SharedTreeV2 < B extends SharedTree , S extends SharedTreeV2 <
@ api ( help = STRING12 , direction = API . Direction . OUTPUT )
public TreeStatsV3 treeStats ;
- @ api ( help = STRING13 , direction = API . Direction . OUTPUT )
+ @ api ( help = STRING14 , direction = API . Direction . OUTPUT )
public double r2 ;
COMMENT
|
Improve annotations for shared tree params
|
<nb>
- COMMENT
+ COMMENT
COMMENT
COMMENT
COMMENT
<nb>
- COMMENT
+ COMMENT
COMMENT
COMMENT
COMMENT
<nb>
- COMMENT
+ COMMENT
COMMENT
COMMENT
COMMENT
<nb>
- COMMENT
+ COMMENT
COMMENT
COMMENT
COMMENT
<nb> package NAMESPACE ;
COMMENT
COMMENT
public final class EventAdminConstants {
-
+
COMMENT
COMMENT
COMMENT
public static final String EVENTADMIN_TOPIC = STRING0 ;
+ private EventAdminConstants ( ) {
+ SINGLE
+ }
}
<nb>
- COMMENT
+ COMMENT
COMMENT
COMMENT
COMMENT
<nb>
- COMMENT
+ COMMENT
COMMENT
COMMENT
COMMENT
<nb>
- COMMENT
+ COMMENT
COMMENT
COMMENT
COMMENT
<nb>
- COMMENT
+ COMMENT
COMMENT
COMMENT
COMMENT
|
Fixed the CS errors of camel eventadmin
|
<nb> public class ShadowTypeface {
@ implementation
public static Typeface createFromFile ( String path ) {
if ( fontPaths . contains ( path ) ) {
- return Robolectric . newInstanceOf ( Typeface . class ) ;
+ Typeface typeface = Robolectric . newInstanceOf ( Typeface . class ) ;
+ shadowOf ( typeface ) . setAssetPath ( path ) ;
+ return typeface ;
}
throw new RuntimeException ( STRING0 ) ;
}
<nb> public class TypefaceTest {
@ test
public void createFromFile_shouldReturnNewTypeface ( ) throws Exception {
SINGLE
- ShadowTypeface . addAllowedTypefacePath ( STRING1 ) ;
+ String path = STRING1 ;
+ ShadowTypeface . addAllowedTypefacePath ( path ) ;
SINGLE
- Typeface typeface = Typeface . createFromFile ( STRING1 ) ;
+ Typeface typeface = Typeface . createFromFile ( path ) ;
assertThat ( typeface , instanceOf ( Typeface . class ) ) ;
+ assertThat ( shadowOf ( typeface ) . getAssetPath ( ) , equalTo ( path ) ) ;
}
}
|
Added path saving to Typeface createFromFile
|
<nb> package NAMESPACE ;
public class CounterMetric {
public long totalCount ;
- public double meanRate ;
+ public long meanRate ;
public long lastCount ;
- public double lastRate ;
+ public long lastRate ;
@ override
public String toString ( ) {
|
metrics fix lastRate meanRate long double problem
|
<nb> public class ClientConnectionManagerImpl implements ClientConnectionManager {
}
private void authenticated ( Address target , ClientConnection connection ) {
- ClientConnection oldConnection = connections . put ( connection . getRemoteEndpoint ( ) , connection ) ;
+ ClientConnection oldConnection = connections . put ( addressTranslator . translate ( connection . getRemoteEndpoint ( ) ) , connection ) ;
if ( oldConnection == null ) {
fireConnectionAddedEvent ( connection ) ;
}
|
small fix for aws address translator
|
<nb> public abstract class AbstractDynamicObject implements DynamicObject {
}
protected MissingPropertyException propertyMissingException ( String name ) {
- throw new MissingPropertyException ( String . format ( STRING0 , name ,
+ return new MissingPropertyException ( String . format ( STRING0 , name ,
getDisplayName ( ) ) , name , null ) ;
}
|
Change propertyMissingException to return exception instead of throw it
|
<nb> public class OsmandExtraSettings extends OsmandPlugin {
entries [ i ] = ( int ) ( floatValues [ i ] * NUMBER0 ) + STRING0 ;
}
Builder b = new AlertDialog . Builder ( view . getContext ( ) ) ;
+ b . setTitle ( R . string . map_text_size ) ;
int i = Arrays . binarySearch ( floatValues , textSizePref . get ( ) ) ;
b . setSingleChoiceItems ( entries , i , new OnClickListener ( ) {
@ override
|
add headline to missing submenu for consistency
|
<nb> public class RowShardResolver {
}
- public synchronized boolean setNextRow ( Row row ) {
+ public synchronized void setNextRow ( Row row ) {
for ( CollectExpression < Row , ? > expression : visitorContext . collectExpressions ( ) ) {
expression . setNextRow ( row ) ;
}
<nb> public class RowShardResolver {
} else {
routing = BytesRefs . toString ( routingInput . value ( ) ) ;
}
- return true ;
}
private List < BytesRef > pkValues ( List < Input < ? > > primaryKeyInputs ) {
|
change setNextRow return type to void instead of boolean
|
<nb> import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
+ import NAMESPACE ;
public class BlockingHttpClient implements AutoCloseable {
<nb> public class BlockingHttpClient implements AutoCloseable {
} ) ;
try {
- requestAction . latch . await ( ) ;
+ requestAction . latch . await ( NUMBER0 , TimeUnit . SECONDS ) ; SINGLE
} catch ( InterruptedException e ) {
throw ExceptionUtils . uncheck ( e ) ;
}
|
Set timeout on blocking httpclient latch so bad request specs don t hang the testing
|
<nb> public final class Main {
context . get ( ) . exit ( exitCode ) ; SINGLE
}
for ( BuckEventListener eventListener : eventListeners ) {
- eventListener . outputTrace ( buildId ) ;
+ try {
+ eventListener . outputTrace ( buildId ) ;
+ } catch ( RuntimeException e ) {
+ System . err . println ( STRING0 ) ;
+ e . printStackTrace ( ) ;
+ }
}
return exitCode ;
}
|
Downgrade errors in outputTrace to warnings
|
<nb> import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
+ import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
<nb> class DefaultRequestDispatcher implements RequestDispatcher {
method , realUri , status , payload . size ( ) , gzip ) ;
}
- return new Response ( method , uri , status , payload . toByteArray ( ) ,
- ImmutableMap . copyOf ( connection . getHeaderFields ( ) ) ) ;
+ return new Response (
+ method , uri , status , payload . toByteArray ( ) ,
+ Collections . unmodifiableMap ( Maps . newHashMap ( connection . getHeaderFields ( ) ) ) ) ;
}
private boolean isGzipCompressed ( final HttpURLConnection connection ) {
|
ImmutableMap doesn t suppot null keys
|
<nb> public class TestClusterService implements ClusterService {
if ( threadPool == null ) {
throw new UnsupportedOperationException ( STRING0 ) ;
}
- NotifyTimeout notifyTimeout = new NotifyTimeout ( listener , timeout ) ;
- notifyTimeout . future = threadPool . schedule ( timeout , ThreadPool . Names . GENERIC , notifyTimeout ) ;
- onGoingTimeouts . add ( notifyTimeout ) ;
+ if ( timeout != null ) {
+ NotifyTimeout notifyTimeout = new NotifyTimeout ( listener , timeout ) ;
+ notifyTimeout . future = threadPool . schedule ( timeout , ThreadPool . Names . GENERIC , notifyTimeout ) ;
+ onGoingTimeouts . add ( notifyTimeout ) ;
+ }
listeners . add ( listener ) ;
listener . postAdded ( ) ;
}
|
Fix NPE in TestClusterService when waiting indefinitely
|
<nb> public class Loader
public List < ModContainer > getModList ( )
{
- return ImmutableList . copyOf ( instance ( ) . mods ) ;
+ return instance ( ) . mods != null ? ImmutableList . copyOf ( instance ( ) . mods ) : ImmutableList . < ModContainer > of ( ) ;
}
COMMENT
<nb> public class Loader
public List < ModContainer > getActiveModList ( )
{
- return modController . getActiveModList ( ) ;
+ return modController != null ? modController . getActiveModList ( ) : ImmutableList . < ModContainer > of ( ) ;
}
public ModState getModState ( ModContainer selectedMod )
|
Try and avoid an NPE in crash reports
|
<nb> import NAMESPACE ;
COMMENT
COMMENT
COMMENT
- COMMENT
+ COMMENT
COMMENT
COMMENT
COMMENT
<nb> import NAMESPACE ;
COMMENT
COMMENT
- COMMENT
+ COMMENT
COMMENT
COMMENT
COMMENT
<nb> public class VCard extends IQ {
COMMENT
COMMENT
COMMENT
- COMMENT
- COMMENT
- COMMENT
- COMMENT
+ COMMENT
+ COMMENT
COMMENT
public String getField ( String field ) {
return ( String ) otherSimpleFields . get ( field ) ;
|
Fixed javadoc comments
|
<nb> public interface IBeaconDataNotifier {
COMMENT
COMMENT
COMMENT
- public void iBeaconDataUpdate ( IBeaconData data , DataProviderException exception ) ;
+ public void iBeaconDataUpdate ( IBeacon iBeacon , IBeaconData data , DataProviderException exception ) ;
}
<nb> public class NullIBeaconDataFactory implements IBeaconDataFactory {
handler . post ( new Runnable ( ) {
@ override
public void run ( ) {
- notifier . iBeaconDataUpdate ( null , new DataProviderException ( STRING0 ) ) ;
+ notifier . iBeaconDataUpdate ( null , null , new DataProviderException ( STRING0 ) ) ;
}
} ) ;
}
|
switch IBeaconDataNotifier to also pass reference to iBeacon
|
<nb> class CGenerator {
JFile f = ( JFile ) i . next ( ) ;
h . write ( STRING0 + f . getName ( ) + STRING1 ) ;
}
+ SINGLE
+ h . write ( STRING2 ) ;
+
c . write ( STRING3 ) ; SINGLE
c . write ( STRING0 + mName + STRING4 ) ;
<nb> class CGenerator {
jr . genCCode ( h , c ) ;
}
+ h . write ( STRING5 ) ;
h . write ( STRING6 + mName . toUpperCase ( ) . replace ( STRING7 , STRING8 ) + STRING9 ) ;
h . close ( ) ;
|
Emit the ifdef extern C guards in the generated
|
<nb> import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
- import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
<nb> import NAMESPACE ;
COMMENT
public class AndroidBuildConfigTest {
- COMMENT
- COMMENT
- COMMENT
- COMMENT
- COMMENT
- COMMENT
- COMMENT
@ test
- public void testSimpleObserverMethods ( ) {
+ public void testGetPathToOutputFile ( ) {
AndroidBuildConfig buildConfig = createSimpleBuildConfigRule ( ) ;
-
assertEquals (
BuckConstant . GEN_PATH . resolve ( STRING0 ) ,
buildConfig . getPathToOutputFile ( ) ) ;
|
Fix outdated comment with link to method that no longer exists
|
<nb> import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
+ import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
<nb> public class PTBTokenizerAnnotator extends TokenizerAnnotator {
this ( verbose , new Properties ( ) ) ;
}
+ public PTBTokenizerAnnotator ( boolean verbose , String propString ) {
+ this ( verbose , PropertiesUtils . fromString ( propString ) ) ;
+ }
+
public PTBTokenizerAnnotator ( boolean verbose , Properties props ) {
super ( verbose ) ;
Language type = getLangType ( props ) ;
|
added new constructors
|
<nb>
package NAMESPACE ;
import NAMESPACE ;
+ import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
<nb> public class CliBaseTest {
}
public static String removePerfOutput ( String output ) {
- return output . replaceAll ( STRING0 , STRING1 ) ;
+ String [ ] lines = StringUtil . splitByLinesKeepSeparators ( output ) ;
+ StringBuilder result = new StringBuilder ( ) ;
+ for ( String line : lines ) {
+ if ( ! line . contains ( STRING2 ) ) {
+ result . append ( line ) ;
+ }
+ }
+ return result . toString ( ) ;
}
private void executeCompilerCompareOutput ( @ notnull CLICompiler < ? > compiler , @ notnull String testDataDir ) throws Exception {
|
rebase ate my changes
|
<nb> class NetworkPolicyManagerShellCommand extends ShellCommand {
final String ssid = removeDoubleQuotes ( config . SSID ) ;
if ( id . equals ( ssid ) ) {
final NetworkPolicy policy = newPolicy ( ssid ) ;
+ policy . metered = true ;
Log . i ( TAG , STRING0 + ssid + STRING1 + policy ) ;
final NetworkPolicy [ ] newPolicies = new NetworkPolicy [ policies . length + NUMBER0 ] ;
System . arraycopy ( policies , NUMBER1 , newPolicies , NUMBER1 , policies . length ) ;
|
Fixed initial metered state of new policy
|
<nb> public class JerseyEurekaHttpClientFactory implements TransportClientFactory {
if ( experimental ) {
return buildExperimental ( additionalHeaders ) ;
}
- return buildLegacy ( additionalHeaders ) ;
+ return buildLegacy ( additionalHeaders , systemSSL ) ;
}
- private JerseyEurekaHttpClientFactory buildLegacy ( Map < String , String > additionalHeaders ) {
+ private JerseyEurekaHttpClientFactory buildLegacy ( Map < String , String > additionalHeaders , boolean systemSSL ) {
EurekaJerseyClientBuilder clientBuilder = new EurekaJerseyClientBuilder ( )
. withClientName ( clientName )
. withUserAgent ( STRING0 )
<nb> public class JerseyEurekaHttpClientFactory implements TransportClientFactory {
. withEncoderWrapper ( encoderWrapper )
. withDecoderWrapper ( decoderWrapper ) ;
+ if ( systemSSL ) {
+ clientBuilder . withSystemSSLConfiguration ( ) ;
+ }
+
EurekaJerseyClient jerseyClient = clientBuilder . build ( ) ;
ApacheHttpClient4 discoveryApacheClient = jerseyClient . getClient ( ) ;
addFilters ( discoveryApacheClient ) ;
|
Propagate systemSSL config for client all the way through
|
<nb> public abstract class AbstractGradleExecuter implements GradleExecuter {
return this ;
}
- @ override
- public void assertCanExecute ( ) throws AssertionError {
-
- }
-
public InputStream getStdin ( ) {
return stdin == null ? new ByteArrayInputStream ( new byte [ NUMBER0 ] ) : stdin ;
}
|
Removing mistakenly implemented interface method
|
<nb> public class AntDirSetImpl extends AntFilesProviderImpl {
}
private static void collectFiles ( List < File > container , File from , String relativePath , final AntPattern pattern ) {
- if ( ! pattern . couldBeIncluded ( relativePath ) ) {
- return ;
- }
final File [ ] children = from . listFiles ( ) ;
if ( children != null ) {
for ( File child : children ) {
<nb> public class AntDirSetImpl extends AntFilesProviderImpl {
if ( pattern . acceptPath ( childPath ) ) {
container . add ( child ) ;
}
- collectFiles ( container , child , childPath , pattern ) ;
+ if ( pattern . couldBeIncluded ( childPath ) ) {
+ collectFiles ( container , child , childPath , pattern ) ;
+ }
}
}
}
|
correctly resolve dirsets
|
<nb> public class SQLExprParser extends SQLParser {
SQLExpr notTarget = expr ( ) ;
accept ( Token . RPAREN ) ;
- notTarget = exprRest ( notTarget ) ;
sqlExpr = new SQLNotExpr ( notTarget ) ;
|
Removed the exprRest from the NOT with parens since it should not expr the rest
|
<nb> public class FlowLayout extends ViewGroup
protected List < List < View > > mAllViews = new ArrayList < List < View > > ( ) ;
protected List < Integer > mLineHeight = new ArrayList < Integer > ( ) ;
private String mGravity ;
+ private List < View > lineViews = new ArrayList < > ( ) ;
public FlowLayout ( Context context , AttributeSet attrs , int defStyle )
{
<nb> public class FlowLayout extends ViewGroup
{
mAllViews . clear ( ) ;
mLineHeight . clear ( ) ;
+ lineViews . clear ( ) ;
int width = getWidth ( ) ;
int lineWidth = NUMBER0 ;
int lineHeight = NUMBER0 ;
- List < View > lineViews = new ArrayList < View > ( ) ;
-
int cCount = getChildCount ( ) ;
for ( int i = NUMBER0 ; i < cCount ; i ++ )
|
Avoid object allocations during draw layout operations preallocate and reuse instead
|
<nb> import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
- import NAMESPACE ;
COMMENT
COMMENT
<nb> public abstract class OIndexOneValue extends OIndexMVRBTreeAbstract < OIdentifiabl
} finally {
releaseExclusiveLock ( ) ;
}
- return result ;
- }
+ return result ;
+ }
}
|
Removed unused import
|
<nb>
SINGLE
package NAMESPACE ;
+ import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
<nb> public class PackageDeserializer {
}
SINGLE
- private static Object deserializeAttributeValue ( Type < ? > expectedType ,
+ @ visiblefortesting
+ static Object deserializeAttributeValue ( Type < ? > expectedType ,
Build . Attribute attrPb )
throws PackageDeserializationException {
switch ( attrPb . getType ( ) ) {
<nb> public class PackageDeserializer {
case TRISTATE :
return attrPb . hasStringValue ( ) ? deserializeTriStateValue ( attrPb . getStringValue ( ) ) : null ;
+ case INTEGER_LIST :
+ return ImmutableList . copyOf ( attrPb . getIntListValueList ( ) ) ;
+
default:
throw new PackageDeserializationException ( STRING0 + attrPb . getType ( ) ) ;
}
|
Fix crash on deserializing INTEGER_LIST attributes in packages
|
<nb> import static NAMESPACE
import static NAMESPACE ;
import NAMESPACE ;
- import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
- import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
<nb> public class CollectionIteratorTester < E > extends AbstractCollectionTester < E > {
fail ( STRING0 ) ;
} catch ( NoSuchElementException expected ) { }
}
-
- COMMENT
- COMMENT
- COMMENT
- COMMENT
- COMMENT
- COMMENT
- COMMENT
- COMMENT
- @ gwtincompatible ( STRING1 )
- public static Method getIteratorKnownOrderRemoveUnsupportedMethod ( ) {
- return Helpers . getMethod (
- CollectionIteratorTester . class , STRING2 ) ;
- }
}
|
Remove no longer needed suppression method
|
<nb> public class MavenPluginCompletionAndResolutionTest extends MavenDomWithIndicesT
STRING0 +
STRING1 ) ;
- assertCompletionVariants ( myProjectPom ) ;
+ assertCompletionVariants ( myProjectPom , STRING2 , STRING3 ) ;
}
public void testWorksWithPropertiesInPluginId ( ) throws Throwable {
|
Fix Maven tests
|
<nb> import NAMESPACE ;
COMMENT
COMMENT
COMMENT
- public class CommentDialogs {
+ class CommentDialogs {
public static final int ID_COMMENT_DLG_APPROVING = NUMBER0 ;
public static final int ID_COMMENT_DLG_UNAPPROVING = NUMBER1 ;
public static final int ID_COMMENT_DLG_SPAMMING = NUMBER2 ;
|
Make CommentDialogs class package private
|
<nb> public class BeanManagerProvider implements Extension
ClassLoader classLoader = ClassUtils . getClassLoader ( null ) ;
bmpSingleton . bmInfos . remove ( classLoader ) ;
-
- SINGLE
- SINGLE
}
COMMENT
|
removed obsolete TODO for Weld
|
<nb> public final class InodeFile extends Inode {
}
public synchronized void setBlockIds ( List < Long > blockIds ) {
- mBlocks = Preconditions . checkNotNull ( blockIds ) ;
+ mBlocks = Preconditions . checkNotNull ( Lists . newArrayList ( blockIds ) ) ;
}
COMMENT
<nb> public final class InodeFile extends Inode {
. build ( ) ;
inode . setBlockIds ( entry . getBlocksList ( ) ) ;
+ inode . setCompleted ( entry . getCompleted ( ) ) ;
inode . setPersisted ( entry . getPersisted ( ) ) ;
inode . setPinned ( entry . getPinned ( ) ) ;
inode . setCacheable ( entry . getCacheable ( ) ) ;
<nb> public final class JournalEntryProtos {
COMMENT
COMMENT
COMMENT
+ COMMENT
COMMENT
COMMENT
COMMENT
<nb> public final class JournalEntryProtos {
COMMENT
COMMENT
COMMENT
+ COMMENT
COMMENT
COMMENT
COMMENT
|
Fix merge conflict
|
<nb> public class XsltBuilder implements Processor {
return false ;
}
- if ( body instanceof Source ) {
+ if ( body instanceof InputStream ) {
+ return true ;
+ } else if ( body instanceof Source ) {
return false ;
} else if ( body instanceof String ) {
return false ;
<nb> public class XsltBuilder implements Processor {
return ( Source ) body ;
}
Source source = null ;
+ if ( body instanceof InputStream ) {
+ return new StreamSource ( ( InputStream ) body ) ;
+ }
if ( body != null ) {
TypeConverter tc = exchange . getContext ( ) . getTypeConverterRegistry ( ) . lookup ( Source . class , body . getClass ( ) ) ;
if ( tc != null ) {
|
If body is an inputstream leave it that way and use a streamsource that
|
<nb> public interface MockMaker {
COMMENT
COMMENT
COMMENT
- COMMENT
+ COMMENT
COMMENT
COMMENT
COMMENT
|
fixed typo in MockMaker javadoc
|
<nb> public class FileUtils {
public static void createDir ( File file ) throws IOException {
file . mkdirs ( ) ;
}
+
+ COMMENT
+ COMMENT
+ COMMENT
+ COMMENT
+ COMMENT
+ COMMENT
+ public static boolean exists ( String path ) {
+ return new File ( path ) . exists ( ) ;
+ }
}
|
Add file existence checking in FileUtils
|
<nb> public abstract class MasterActor < E extends Updateable < ? > > extends UntypedActor
COMMENT
COMMENT
COMMENT
- COMMENT
+ COMMENT
COMMENT
COMMENT
public MasterActor ( Conf conf , ActorRef batchActor , HazelCastStateTracker stateTracker ) {
|
fixed a comment
|
<nb> public class VcsLogManager extends AbstractProjectComponent {
private Set < VirtualFile > safeGetAndClear ( @ notnull Set < VirtualFile > unsafeRefs ) {
Set < VirtualFile > safeRefs = ContainerUtil . newHashSet ( ) ;
synchronized ( REFRESH_LOCK ) {
- safeRefs . addAll ( safeRefs ) ;
+ safeRefs . addAll ( unsafeRefs ) ;
unsafeRefs . clear ( ) ;
}
return safeRefs ;
|
log Fix a misprint in postponed refreshing of the hidden log
|
<nb> public final class PackageGroupConfiguredTarget extends AbstractConfiguredTarget
@ override
public Object get ( String providerKey ) {
- throw new UnsupportedOperationException ( ) ;
+ SINGLE
+ return null ;
}
@ override
|
Fix crash when checking providers
|
<nb> package NAMESPACE ;
import NAMESPACE ;
+ import NAMESPACE ;
+
import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
<nb> import NAMESPACE ;
COMMENT
COMMENT
COMMENT
+ @ threadsafe
public final class NettyUtils {
private NettyUtils ( ) { }
<nb> public final class NetworkAddressUtils {
}
COMMENT
- COMMENT
+ COMMENT
COMMENT
COMMENT
COMMENT
<nb> public final class NetworkAddressUtils {
}
COMMENT
- COMMENT
+ COMMENT
COMMENT
COMMENT
COMMENT
<nb> public final class NetworkAddressUtils {
}
COMMENT
- COMMENT
+ COMMENT
COMMENT
COMMENT
COMMENT
<nb> public final class NetworkAddressUtils {
}
COMMENT
- COMMENT
+ COMMENT
COMMENT
COMMENT
COMMENT
|
Adding thread safety annotations for tachyon utildotNetwork in common module
|
<nb> public interface AgentBuilder {
LambdaInstrumentationStrategy . DISABLED ,
DescriptionStrategy . Default . HYBRID ,
InstallationStrategy . Default . ESCALATING ,
- new RawMatcher . Disjunction ( new RawMatcher . ForElementMatchers ( any ( ) , isBootstrapClassLoader ( ) , any ( ) ) , new RawMatcher . ForElementMatchers ( nameStartsWith ( STRING0 ) . < TypeDescription > or ( isSynthetic ( ) ) , any ( ) , any ( ) ) ) ,
+ new RawMatcher . Disjunction ( new RawMatcher . ForElementMatchers ( any ( ) , isBootstrapClassLoader ( ) , any ( ) ) ,
+ new RawMatcher . ForElementMatchers ( nameStartsWith ( STRING0 ) . or ( nameStartsWith ( STRING1 ) ) . < TypeDescription > or ( isSynthetic ( ) ) , any ( ) , any ( ) ) ) ,
Transformation . Ignored . INSTANCE ) ;
}
|
Included sun reflect from instrumentation by default to avoid accidental instrumentation of accessors
|
<nb> public class StickyListHeadersListView extends FrameLayout {
cancelEvent . recycle ( ) ;
}
- MotionEvent downEvent = MotionEvent . obtain ( ev ) ;
+ MotionEvent downEvent = MotionEvent . obtain ( ev . getDownTime ( ) , ev . getEventTime ( ) , ev . getAction ( ) , ev . getX ( ) , mDownY , ev . getMetaState ( ) ) ;
downEvent . setAction ( MotionEvent . ACTION_DOWN ) ;
handled = mList . dispatchTouchEvent ( downEvent ) ;
downEvent . recycle ( ) ;
|
Initialize down event with original down y position
|
<nb> public final class Downloads {
COMMENT
COMMENT
public boolean isSuccessful ( ) {
- return android . provider . Downloads . Impl . isStatusCompleted ( statusCode ) ;
+ return android . provider . Downloads . Impl . isStatusSuccess ( statusCode ) ;
}
}
|
fix a long standing typo bug
|
<nb>
package NAMESPACE ;
import NAMESPACE ;
- import NAMESPACE ;
+ import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
|
fixing compilation error class moved
|
<nb> public abstract class PsiBasedStripTrailingSpacesFilter implements StripTrailing
protected abstract void process ( @ notnull PsiFile psiFile ) ;
@ nullable
- private static Language getDocumentLanguage ( @ notnull Document document ) {
+ public static Language getDocumentLanguage ( @ notnull Document document ) {
FileDocumentManager manager = FileDocumentManager . getInstance ( ) ;
VirtualFile file = manager . getFile ( document ) ;
if ( file != null && file . isValid ( ) ) {
|
disable all lines no Psi processing
|
<nb> public class SerializationUtils {
QueryMessage query = new QueryMessage ( versions ) ;
return query ;
default :
- throw new IOException ( STRING0 ) ;
+ throw new IOException ( STRING1 ) ;
}
}
}
|
Fix typo in log message
|
<nb> import NAMESPACE ;
COMMENT
COMMENT
COMMENT
+ COMMENT
+ COMMENT
+ COMMENT
+ COMMENT
+ COMMENT
+ COMMENT
+ COMMENT
+ COMMENT
+ COMMENT
+ COMMENT
+ COMMENT
+ COMMENT
+ COMMENT
+ COMMENT
+ COMMENT
+ COMMENT
+ COMMENT
+ COMMENT
+ COMMENT
+ COMMENT
+ COMMENT
+ COMMENT
+ COMMENT
+ COMMENT
+ COMMENT
+ COMMENT
+ COMMENT
+ COMMENT
+ COMMENT
+ COMMENT
+ COMMENT
+ COMMENT
+ COMMENT
+ COMMENT
+ COMMENT
COMMENT
COMMENT
COMMENT
|
Added an example
|
<nb> public class NotificationBuilderTest extends Activity
{
private final static String TAG = STRING0 ;
+ private final static String NOTIFY_TAG = STRING1 ;
+
NotificationManager mNM ;
Handler mHandler ;
int mStartDelay ;
<nb> public class NotificationBuilderTest extends Activity
final Notification n = buildNotification ( id ) ;
mHandler . postDelayed ( new Runnable ( ) {
public void run ( ) {
- mNM . notify ( id , n ) ;
+ mNM . notify ( NOTIFY_TAG , id , n ) ;
}
} , mStartDelay ) ;
}
|
Add tag foo to builder test s notifications
|
<nb> public class WebView extends AbsoluteLayout
return false ;
}
- if ( isEnterActionKey ( keyCode ) ) {
+ if ( keyCode == KeyEvent . KEYCODE_DPAD_CENTER ) {
switchOutDrawHistory ( ) ;
boolean wantsKeyEvents = nativeCursorNodePointer ( ) == NUMBER0
|| nativeCursorWantsKeyEvents ( ) ;
|
only allow dpad center for key long press
|
<nb> public class TranslationCheck extends AbstractFileSetCheck
for ( Iterator it = keysClone . iterator ( ) ; it . hasNext ( ) ; ) {
Object [ ] key = new Object [ ] { it . next ( ) } ;
LocalizedMessage [ ] errors = new LocalizedMessage [ NUMBER0 ] ;
- final String bundle =
- getClass ( ) . getPackage ( ) . getName ( ) + STRING0 ;
+ final String className = getClass ( ) . getName ( ) ;
+ final int pkgEndIndex = className . lastIndexOf ( STRING1 ) ;
+ final String pkgName = className . substring ( NUMBER1 , pkgEndIndex ) ;
+ final String bundle = pkgName + STRING0 ;
errors [ NUMBER1 ] = new LocalizedMessage (
NUMBER1 , bundle , STRING2 , key ) ;
getMessageDispatcher ( ) . fireErrors ( path , errors ) ;
|
fixed NPE Class getPackage sometimes return null use String operations instead
|
<nb> package NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
- import NAMESPACE ;
+ import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
<nb> public class Sharded < R , S extends ShardInfo < R > > {
public static final int DEFAULT_WEIGHT = NUMBER0 ;
private TreeMap < Long , S > nodes ;
private final Hashing algo ;
- private final Map < ShardInfo < R > , R > resources = new HashMap < ShardInfo < R > , R > ( ) ;
+ private final Map < ShardInfo < R > , R > resources = new LinkedHashMap < ShardInfo < R > , R > ( ) ;
COMMENT
COMMENT
|
made shard iterable in the same order as in config during creation
|
<nb> public final class EmbeddedReadOnlyNeo implements NeoService
public EmbeddedReadOnlyNeo ( String storeDir , Map < String , String > params )
{
+ params . put ( STRING0 , STRING1 ) ;
this . neoImpl = new EmbeddedNeoImpl ( storeDir , params , this ) ;
}
|
Fixed bug that caused constructor not to set read only mode
|
<nb> public class BukkitUtil {
public static World toWorld ( WorldVector pt ) {
return ( ( BukkitWorld ) pt . getWorld ( ) ) . getWorld ( ) ;
}
+
+ COMMENT
+ COMMENT
+ COMMENT
+ COMMENT
+ public static boolean equals ( Location a , Location b ) {
+ if ( Math . abs ( a . getX ( ) - b . getX ( ) ) > EQUALS_PRECISION ) return false ;
+ if ( Math . abs ( a . getY ( ) - b . getY ( ) ) > EQUALS_PRECISION ) return false ;
+ if ( Math . abs ( a . getZ ( ) - b . getZ ( ) ) > EQUALS_PRECISION ) return false ;
+ return true ;
+ }
+ public static final double EQUALS_PRECISION = FLOAT0 ;
}
|
Added a utility method for dealing with location precision to bukkit utilities
|
<nb>
- COMMENT
- COMMENT
- COMMENT
package NAMESPACE ;
import NAMESPACE ;
|
remove meaningless copyright comments
|
<nb> abstract class AbstractCommandLineRunner < A extends Compiler ,
this . useNewTypeInference = useNewTypeInference ;
return this ;
}
-
- private String renamePrefixNamespace = null ;
-
- CommandLineConfig setRenamePrefixNamespace ( String renamePrefixNamespace ) {
- this . renamePrefixNamespace = renamePrefixNamespace ;
- return this ;
- }
}
COMMENT
<nb> public class CommandLineRunner extends
. setWarningsWhitelistFile ( flags . warningsWhitelistFile )
. setAngularPass ( flags . angularPass )
. setTracerMode ( flags . tracerMode )
- . setNewTypeInference ( flags . useNewTypeInference )
- . setRenamePrefixNamespace ( flags . renamePrefixNamespace ) ;
+ . setNewTypeInference ( flags . useNewTypeInference ) ;
}
errorStream = null ;
}
|
Remove unused field CommandLineConfig renamePrefixNamespace
|
<nb>
package NAMESPACE ;
+ import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
<nb> public interface Future < T > extends AsyncResult < T > {
COMMENT
COMMENT
COMMENT
- Handler < AsyncResult < T > > completer ( ) ;
+ @ cachereturn
+ default Handler < AsyncResult < T > > completer ( ) {
+ return ar - > {
+ if ( ar . succeeded ( ) ) {
+ complete ( ar . result ( ) ) ;
+ } else {
+ ar . failed ( ) ;
+ }
+ } ;
+ }
static FutureFactory factory = ServiceHelper . loadFactory ( FutureFactory . class ) ;
|
Provide a default impl for completer and cache its return
|
<nb> public class SegmentCreationPhaseMapReduceJob {
schema = OBJECT_MAPPER . readValue ( properties . get ( SEGMENT_CREATION_DATA_SCHEMA . toString ( ) ) , Schema . class ) ;
thirdeyeConfig = OBJECT_MAPPER . readValue ( properties . get ( SEGMENT_CREATION_THIRDEYE_CONFIG . toString ( ) ) , ThirdEyeConfig . class ) ;
+ LOGGER . info ( thirdeyeConfig . encode ( ) ) ;
tableName = thirdeyeConfig . getCollection ( ) ;
segmentWallClockStartTime = Long . valueOf ( properties . get ( SEGMENT_CREATION_WALLCLOCK_START_TIME . toString ( ) ) ) ;
|
Add ability to set startree configs for jobs via properties
|
<nb> import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
+ import NAMESPACE ;
+ import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
<nb> public class JDBCRiver extends AbstractRiverComponent implements StatefulRiver ,
riverThread . interrupt ( ) ;
}
logger . info ( STRING0 , riverName . getType ( ) , riverName . getName ( ) ) ;
+
+ SINGLE
+ DeleteRiverStateRequest riverStateRequest = new DeleteRiverStateRequest ( ) ;
+ riverStateRequest . setRiverName ( riverName . getName ( ) ) . setRiverType ( riverName . getType ( ) ) ;
+ client . admin ( ) . cluster ( ) . execute ( DeleteRiverStateAction . INSTANCE , riverStateRequest ) . actionGet ( ) ;
+ logger . info ( STRING1 , riverName . getType ( ) , riverName . getName ( ) ) ;
}
COMMENT
|
delete state from cluster when river is deleted
|
<nb> public interface FileAnnotation {
VcsRevisionNumber getLineRevisionNumber ( int lineNumber ) ;
COMMENT
- COMMENT
- COMMENT
+ COMMENT
COMMENT
- COMMENT
+ COMMENT
COMMENT
COMMENT
@ nullable
|
Clarified javadoc comment
|
<nb> import NAMESPACE ;
public class SpiderSitemapXMLParser extends SpiderParser {
COMMENT
- private Pattern SITEMAP_XML_FILENAME_PATTERN = Pattern . compile ( STRING0 ) ;
+ private Pattern SITEMAP_XML_FILENAME_PATTERN = Pattern . compile ( STRING1 ) ;
COMMENT
- private static final Pattern xmlPattern = Pattern . compile ( STRING2 ) ;
+ private static final Pattern xmlPattern = Pattern . compile ( STRING3 ) ;
COMMENT
private SpiderParam params ;
<nb> public class SpiderSitemapXMLParser extends SpiderParser {
private static XPathExpression xpathLocationExpression ;
COMMENT
- static {
- if ( log . isDebugEnabled ( ) ) log . debug ( STRING4 ) ;
+ static {
dbFactory = DocumentBuilderFactory . newInstance ( ) ;
try {
dBuilder = dbFactory . newDocumentBuilder ( ) ;
<nb> public class SpiderSitemapXMLParser extends SpiderParser {
} catch ( ParserConfigurationException | XPathExpressionException e ) {
log . error ( e ) ;
}
- if ( log . isDebugEnabled ( ) ) log . debug ( STRING5 ) ;
}
COMMENT
|
Tweaked regexps removed un necessary logging statements
|
<nb> public class XContentFactory {
COMMENT
public static XContentType xContentType ( byte [ ] data , int offset , int length ) {
length = length < GUESS_HEADER_LENGTH ? length : GUESS_HEADER_LENGTH ;
- if ( length > NUMBER0 && data [ NUMBER1 ] == NUMBER2 && data [ NUMBER0 ] == NUMBER2 ) {
+ if ( length > NUMBER0 && data [ offset ] == NUMBER2 && data [ offset + NUMBER0 ] == NUMBER2 ) {
return XContentType . XSON ;
}
for ( int i = offset ; i < length ; i ++ ) {
|
use offset when detecting xcontent type
|
<nb> public class MethodClosure extends Closure {
return InvokerHelper . invokeMethod ( getDelegate ( ) , method , arguments ) ;
}
- public void setDelegate ( Object delegate ) {
- throw new UnsupportedOperationException ( STRING0 ) ;
- }
-
public Object getProperty ( String property ) {
if ( STRING1 . equals ( property ) ) {
return getMethod ( ) ;
|
Remove the implementation of setDelegate whcih thows an exacption
|
<nb> public class ProguardMojo extends AbstractAndroidMojo
{
if ( excludedFilter != null && ! excludedFilter . isEmpty ( ) )
{
- StringBuilder sb = new StringBuilder ( STRING0 ) ;
+ StringBuilder sb = new StringBuilder ( STRING1 ) ;
sb . append ( path ) ;
- sb . append ( STRING2 ) ;
+ sb . append ( STRING3 ) ;
for ( Iterator < String > it = excludedFilter . iterator ( ) ; it . hasNext ( ) ; )
{
sb . append ( STRING4 ) . append ( it . next ( ) ) ;
<nb> public class ProguardMojo extends AbstractAndroidMojo
sb . append ( STRING5 ) ;
}
}
- sb . append ( STRING6 ) ;
+ sb . append ( STRING7 ) ;
return sb . toString ( ) ;
}
else
{
- return STRING8 + path + STRING9 ;
+ return path ;
}
}
|
Fix proguard on windows
|
<nb> import NAMESPACE ;
COMMENT
COMMENT
COMMENT
+ COMMENT
+ COMMENT
COMMENT
public abstract class LexerBasedTodoIndexer extends VersionedTodoIndexer implements IdAndToDoScannerBasedOnFilterLexer {
@ override
<nb> import NAMESPACE ;
COMMENT
COMMENT
+ COMMENT
+ COMMENT
COMMENT
public interface IndexPatternBuilder {
ExtensionPointName < IndexPatternBuilder > EP_NAME = ExtensionPointName . create ( STRING0 ) ;
|
add links in doc from TodoIndexer to PatternBuilder and vice versa
|
<nb> public class CommonRefactoringUtil {
else {
PsiFile file = element . getContainingFile ( ) ;
if ( file == null ) {
- seenNonWritablePsiFilesWithoutVirtualFile = true ;
+ if ( ! element . isWritable ( ) ) {
+ seenNonWritablePsiFilesWithoutVirtualFile = true ;
+ }
}
else {
final VirtualFile vFile = file . getVirtualFile ( ) ;
<nb> public class CommonRefactoringUtil {
readonly . add ( vFile ) ;
}
else {
- seenNonWritablePsiFilesWithoutVirtualFile = true ;
+ if ( ! element . isWritable ( ) ) {
+ seenNonWritablePsiFilesWithoutVirtualFile = true ;
+ }
}
}
}
|
do not treat non physical writable elements as not writable elements without virtual file
|
<nb> public class JreMemoryLeakPreventionListener implements LifecycleListener {
COMMENT
COMMENT
COMMENT
- COMMENT
+ COMMENT
+ COMMENT
+ COMMENT
COMMENT
private boolean xmlParsingProtection = true ;
public boolean isXmlParsingProtection ( ) { return xmlParsingProtection ; }
|
Add the bug url
|
<nb> import NAMESPACE ;
public class JavaThriftLibraryDescriptionTest {
@ test
- public void TestThriftLibraryDepConfig ( ) {
+ public void thriftLibraryDepConfig ( ) {
Map < String , Map < String , String > > sections = new HashMap < > ( ) ;
Map < String , String > javaSection = new HashMap < > ( ) ;
javaSection . put ( STRING0 , STRING1 ) ;
|
Fix a linting error
|
<nb> public class PyActiveSdkConfigurable implements UnnamedConfigurable {
public void consume ( @ nullable Sdk sdk ) {
final Sdk moduleSdk = getSdk ( ) ;
if ( sdk instanceof PyDetectedSdk ) {
- final Sdk addedSdk = SdkConfigurationUtil . setupSdk ( myProjectSdksModel . getSdks ( ) , sdk . getHomeDirectory ( ) ,
- PythonSdkType . getInstance ( ) , true ,
- null , null ) ;
+ final Sdk addedSdk = SdkConfigurationUtil . createAndAddSDK ( sdk . getHomePath ( ) , PythonSdkType . getInstance ( ) ) ;
myProjectSdksModel . addSdk ( addedSdk ) ;
updateSdkList ( false ) ;
if ( addedSdk != null )
|
fixed selecting detected SDK from more dialog
|
<nb> public class NettyCometSupport extends AsynchronousProcessor {
public final static String SUSPEND = NettyCometSupport . class . getName ( ) + STRING0 ;
public final static String RESUME = NettyCometSupport . class . getName ( ) + STRING1 ;
- public final static String CHANNEL = NettyCometSupport . class . getName ( ) + STRING2 ;
private static final Logger logger = LoggerFactory . getLogger ( NettyCometSupport . class ) ;
<nb> public class NettyCometSupport extends AsynchronousProcessor {
@ override
public AsyncSupport complete ( AtmosphereResourceImpl r ) {
- if ( r . getRequest ( false ) . getAttribute ( CHANNEL ) == null ) return this ;
-
try {
- ( ( AsyncIOWriter ) r . getRequest ( false ) . getAttribute ( CHANNEL ) ) . close ( r . getResponse ( false ) ) ;
+ r . getResponse ( ) . getAsyncIOWriter ( ) . close ( r . getResponse ( false ) ) ;
} catch ( IOException e ) {
logger . trace ( STRING3 , e ) ;
}
|
Do not use attribute and use the response directly
|
<nb> import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
+ import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
- import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
<nb> public class NodesApiController extends AuthenticatedController {
public Result nodes ( ) {
final List < NodeDescription > nodes = Lists . newArrayList ( ) ;
- for ( final String nodeId : serverNodes . asMap ( ) . keySet ( ) ) {
- try {
- nodes . add ( new NodeDescription ( nodeService . loadNode ( nodeId ) ) ) ;
- } catch ( NodeService . NodeNotFoundException e ) {
- Logger . error ( STRING0 , e ) ;
- }
+ for ( final Node node : serverNodes . all ( ) ) {
+ nodes . add ( new NodeDescription ( node ) ) ;
}
try {
|
Do not load the nodes again in NodesApiController
|
<nb> public class ListsFragment extends Fragment implements
intent = new Intent ( getActivity ( ) , OverviewActivity . class ) ;
intent . putExtra ( OverviewFragment . InitBundle . SHOW_TVDBID ,
Integer . valueOf ( itemRefId ) ) ;
- startActivity ( intent ) ;
break ;
}
case NUMBER0 : {
<nb> public class ListsFragment extends Fragment implements
intent = new Intent ( getActivity ( ) , EpisodesActivity . class ) ;
intent . putExtra ( EpisodesActivity . InitBundle . SEASON_TVDBID ,
Integer . valueOf ( itemRefId ) ) ;
- startActivity ( intent ) ;
break ;
}
case NUMBER1 : {
<nb> public class ListsFragment extends Fragment implements
intent = new Intent ( getActivity ( ) , EpisodesActivity . class ) ;
intent . putExtra ( EpisodesActivity . InitBundle . EPISODE_TVDBID ,
Integer . valueOf ( itemRefId ) ) ;
- startActivity ( intent ) ;
break ;
}
}
|
Fix list items launching detail view twice
|
<nb> public class ReaderActivity extends WPActionBarActivity implements ChangeTopicLi
@ override
public void onClick ( View v ) {
- showTopics ( ) ;
+ if ( ! isFinishing ( ) )
+ showTopics ( ) ;
}
} ) ;
|
Don t show the Reader topics selector if our activity has finished
|
<nb> import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
- import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
|
remove unused import
|
<nb> public abstract class AbstractAdapter < Item extends IItem > extends RecyclerView . A
COMMENT
COMMENT
COMMENT
- public AbstractAdapter wrap ( FastAdapter < Item > fastAdapter ) {
+ public AbstractAdapter < Item > wrap ( FastAdapter < Item > fastAdapter ) {
SINGLE
this . mFastAdapter = fastAdapter ;
this . mFastAdapter . registerAdapter ( this ) ;
<nb> public abstract class AbstractAdapter < Item extends IItem > extends RecyclerView . A
COMMENT
COMMENT
COMMENT
- public AbstractAdapter wrap ( IAdapter < Item > abstractAdapter ) {
+ public AbstractAdapter < Item > wrap ( IAdapter < Item > abstractAdapter ) {
SINGLE
this . mFastAdapter = abstractAdapter . getFastAdapter ( ) ;
this . mFastAdapter . registerAdapter ( this ) ;
|
also add type to return class
|
<nb> public class BaseModelMBean implements DynamicMBean , MBeanRegistration , ModelMBe
COMMENT
COMMENT
COMMENT
- COMMENT
+ COMMENT
COMMENT
COMMENT
@ override
<nb> public class BaseModelMBean implements DynamicMBean , MBeanRegistration , ModelMBe
COMMENT
COMMENT
COMMENT
- COMMENT
- COMMENT
COMMENT
COMMENT
COMMENT
<nb> public class ManagedBean implements java . io . Serializable {
COMMENT
COMMENT
COMMENT
- COMMENT
- COMMENT
COMMENT
COMMENT
COMMENT
<nb> public class ManagedBean implements java . io . Serializable {
COMMENT
COMMENT
COMMENT
- COMMENT
- COMMENT
COMMENT
COMMENT
COMMENT
|
Fix some Javadoc errors
|
<nb> public class XLineBreakpointImpl < P extends XBreakpointProperties > extends XBreak
}
private boolean canMoveTo ( int line , VirtualFile file ) {
- return file != null &&
- myType . canPutAt ( file , line , getProject ( ) ) &&
- getBreakpointManager ( ) . findBreakpointAtLine ( myType , file , line ) == null ;
+ if ( file != null && myType . canPutAt ( file , line , getProject ( ) ) ) {
+ XLineBreakpoint < P > existing = getBreakpointManager ( ) . findBreakpointAtLine ( myType , file , line ) ;
+ return existing == null || existing == this ;
+ }
+ return false ;
}
public void updatePosition ( ) {
|
do not show disabled drag cursor for the same line the breakpoint is on
|
<nb> import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
- import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
<nb> import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
- import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
|
Removing unused imports
|
<nb> public class SynchronizeFolderOperation extends SyncOperation {
SINGLE
SynchronizeFileOperation operation = new SynchronizeFileOperation (
child ,
- ( child . getEtagInConflict ( ) != null ? null : child ) ,
+ ( child . getEtagInConflict ( ) != null ? child : null ) ,
mAccount ,
true ,
mContext
|
Detect conflict when local and server version are changed
|
<nb> public class LzmaBufferUtils {
}
ScheduledExecutorService executor = Executors . newSingleThreadScheduledExecutor ( ) ;
- executor . scheduleAtFixedRate ( new ByteBufferProgress ( bbc ) , NUMBER0 , NUMBER0 , TimeUnit . SECONDS ) ;
+ executor . scheduleAtFixedRate ( new ByteBufferProgress ( bbc ) , NUMBER0 , NUMBER1 , TimeUnit . SECONDS ) ;
try {
InputStream is = new ByteBufferInputStream ( bbc ) ;
|
Increased process log frequency
|
<nb> public abstract class EntitlementLoggingHelper {
if ( log . isInfoEnabled ( ) ) {
final StringBuilder logLine = new StringBuilder ( STRING0 )
- . append ( bundleId != null ? STRING1 : STRING2 )
+ . append ( bundleId != null ? STRING2 : STRING1 )
. append ( STRING3 ) ;
if ( bundleId != null ) {
|
Fix logging issue in entitlement
|
<nb> public class PortalImpl implements Portal {
themeDisplay . getScopeGroupId ( ) , false ,
PropsValues . COMPANY_SECURITY_STRANGERS_URL ) ;
- return PortalUtil . getLayoutURL ( layout , themeDisplay ) ;
+ return getLayoutURL ( layout , themeDisplay ) ;
}
catch ( NoSuchLayoutException nsle ) {
}
|
Remove redundant calls
|
<nb> import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
- import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
<nb> import NAMESPACE ;
COMMENT
@ threadsafe
public final class ManagedChannelImpl extends ManagedChannel {
- private static final Logger log = Logger . getLogger ( ManagedChannelImpl . class . getName ( ) ) ;
-
SINGLE
SINGLE
SINGLE
|
remove unused var
|
<nb> public class RosterItemProvider {
Connection con = null ;
PreparedStatement pstmt = null ;
try {
- con = DbConnectionManager . getConnection ( ) ;
-
long rosterID = SequenceManager . nextID ( JiveConstants . ROSTER ) ;
+ con = DbConnectionManager . getConnection ( ) ;
pstmt = con . prepareStatement ( CREATE_ROSTER_ITEM ) ;
pstmt . setString ( NUMBER0 , username ) ;
pstmt . setLong ( NUMBER1 , rosterID ) ;
|
Fixed potential deadlock reported by Giancarlo
|
<nb> public interface ResolvableDependencies {
COMMENT
COMMENT
COMMENT
+ COMMENT
COMMENT
@ incubating
ResolutionResult getResolutionResult ( ) ;
|
Added a since tag to the javadoc
|
<nb> public class ShadowWebView extends ShadowAbsoluteLayout {
private int goBackInvocations = NUMBER0 ;
private ShadowWebView . LoadData lastLoadData ;
private LoadDataWithBaseURL lastLoadDataWithBaseURL ;
+ private WebView . PictureListener pictureListener ;
@ override
public void __constructor__ ( Context context , AttributeSet attributeSet ) {
<nb> public class ShadowWebView extends ShadowAbsoluteLayout {
public WebViewClient getWebViewClient ( ) {
return webViewClient ;
}
+
+ @ implementation
+ public void setPictureListener ( WebView . PictureListener listener ) {
+ pictureListener = listener ;
+ }
+
+ public WebView . PictureListener getPictureListener ( ) {
+ return pictureListener ;
+ }
@ implementation
public void addJavascriptInterface ( Object obj , String interfaceName ) {
|
Add support for PictureListener
|
<nb> import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
- import NAMESPACE ;
- import NAMESPACE ;
import NAMESPACE ;
- import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
import NAMESPACE ;
- import NAMESPACE ;
COMMENT
COMMENT
<nb> public class CompletionPreview implements Disposable {
}
private void updatePreview ( ) {
- if ( true ) {
- return ;
- }
-
+ SINGLE
+ COMMENT
final EditorImpl editor = getEditorImpl ( ) ;
editor . setCustomImage ( null ) ;
repaintCaretLine ( ) ;
<nb> public class CompletionPreview implements Disposable {
BufferedImage previewImage = createPreviewImage ( text . substring ( prefixLength ) ) ;
editor . setCustomImage ( Pair . create ( getCaretPoint ( ) , previewImage ) ) ;
repaintCaretLine ( ) ;
+ COMMENT
}
@ override
|
comment out preview showing
|
<nb> public abstract class GenericFileEndpoint < T > extends ScheduledPollEndpoint imple
COMMENT
COMMENT
COMMENT
+ COMMENT
COMMENT
public void setReadLockRemoveOnRollback ( boolean readLockRemoveOnRollback ) {
this . readLockRemoveOnRollback = readLockRemoveOnRollback ;
|
File consumer Add read lock that is based on idempotent repository
|
<nb> public class SearchView extends LinearLayout implements CollapsibleActionView {
} catch ( RuntimeException e2 ) {
rowNum = - NUMBER0 ;
}
- Log . w ( LOG_TAG , STRING0 + rowNum +
- STRING1 + e . toString ( ) ) ;
+ Log . w ( LOG_TAG , STRING2 + rowNum +
+ STRING3 , e ) ;
return null ;
}
}
|
Pass SearchView suggestion cursor exception to Log
|
<nb> public class GrailsDomainClassMappingContext extends AbstractMappingContext {
protected PersistentEntity createPersistentEntity ( Class javaClass ) {
GrailsDomainClass domainClass = ( GrailsDomainClass ) grailsApplication . getArtefact ( DomainClassArtefactHandler . TYPE , javaClass . getName ( ) ) ;
- return new GrailsDomainClassPersistentEntity ( domainClass , this ) ;
+ if ( domainClass != null ) {
+ return new GrailsDomainClassPersistentEntity ( domainClass , this ) ;
+ }
+ return null ;
}
private class GrailsGrailsDomainMappingConfigurationStrategy implements MappingConfigurationStrategy {
|
add null check before creating domain
|
<nb> class BluetoothManagerService extends IBluetoothManager . Stub {
if ( mUnbinding ) return ;
mUnbinding = true ;
mHandler . removeMessages ( MESSAGE_BLUETOOTH_STATE_CHANGE ) ;
+ mHandler . removeMessages ( MESSAGE_BIND_PROFILE_SERVICE ) ;
if ( mBluetooth != null ) {
SINGLE
try {
|
Removed MESSAGE_BIND_PROFILE_SERVICE messages on unbind
|
<nb> public class AsyncOperationRunner extends AbstractService {
if ( operations . get ( requestId ) . getStatus ( ) . isComplete ( ) ) {
logger . debug ( STRING0 + requestId ) ;
- SINGLE
- SINGLE
+ operations . remove ( requestId ) ;
return true ;
}
|
reverted asyncRunner change to Not remove operations after completion
|
<nb> public class FoldingModelSupport {
} ;
}
- lastRunnable . run ( ) ;
+ myDuringSynchronize = true ;
+ try {
+ lastRunnable . run ( ) ;
+ }
+ finally {
+ myDuringSynchronize = false ;
+ }
}
@ nullable
|
disable listeners during init
|
<nb> public class CommandContext {
return Double . parseDouble ( value ) ;
}
- public int length ( ) {
- return args . length ;
- }
-
public int argsLength ( ) {
return args . length - NUMBER0 ;
}
<nb> public class SelectionCommands {
LocalSession session , LocalPlayer player , EditSession editSession )
throws WorldEditException {
- if ( args . length ( ) == NUMBER1 ) {
+ if ( args . argsLength ( ) == NUMBER1 ) {
session . getRegionSelector ( player . getWorld ( ) ) . clear ( ) ;
+ return ;
}
String typeName = args . getString ( NUMBER1 ) ;
if ( typeName . equalsIgnoreCase ( STRING0 ) ) {
|
Fixed AIOOBE and a missing return removed an unused and ambiguous method from CommandContext
|
<nb> import NAMESPACE ;
public class BlockJUnit4ClassRunner extends ParentRunner < FrameworkMethod > {
private final ConcurrentHashMap < FrameworkMethod , Description > methodDescriptions = new ConcurrentHashMap < FrameworkMethod , Description > ( ) ;
COMMENT
- COMMENT
+ COMMENT
COMMENT
COMMENT
COMMENT
- public BlockJUnit4ClassRunner ( Class < ? > klass ) throws InitializationError {
- super ( klass ) ;
+ public BlockJUnit4ClassRunner ( Class < ? > testClass ) throws InitializationError {
+ super ( testClass ) ;
}
SINGLE
|
Changed the name of the constructor variable klass to testClass reveal its true purpose
|
<nb> public class FunctionBuilder {
}
public static Function method ( SootMethod method ) {
- return new FunctionBuilder ( methodSymbol ( method ) , getFunctionType ( method ) ) . linkage ( method . isPrivate ( ) ? internal : external )
+ return new FunctionBuilder ( methodSymbol ( method ) , getFunctionType ( method ) ) . linkage ( external )
. attribs ( noinline , optsize ) . build ( ) ;
}
|
Reverted the change which makes symbols for private methods private to the
|
<nb> public interface PsiElement extends UserDataHolder , Iconable {
COMMENT
COMMENT
COMMENT
- @ nullable PsiFile getContainingFile ( ) ;
+ PsiFile getContainingFile ( ) ;
COMMENT
COMMENT
|
Nullable gives too many false positives
|
<nb> public class HeadsUpNotificationView extends FrameLayout implements SwipeHelper .
public void updateNotification ( NotificationData . Entry headsUp , boolean alert ) {
if ( DEBUG ) Log . v ( TAG , STRING0 ) ;
- if ( alert ) {
- mBar . scheduleHeadsUpDecay ( mHeadsUpNotificationDecay ) ;
- }
- invalidate ( ) ;
-
if ( mHeadsUp == headsUp ) {
resetViewForHeadsup ( ) ;
SINGLE
<nb> public class HeadsUpNotificationView extends FrameLayout implements SwipeHelper .
}
mHeadsUp . setInterruption ( ) ;
-
+ }
+ if ( alert ) {
SINGLE
mBar . scheduleHeadsUpOpen ( ) ;
+ mBar . scheduleHeadsUpDecay ( mHeadsUpNotificationDecay ) ;
}
}
|
Fixed a bug where HUNs would not dissappear
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.