url
string
repository_url
string
labels_url
string
comments_url
string
events_url
string
html_url
string
id
int64
node_id
string
number
int64
title
string
user
dict
labels
list
state
string
locked
bool
assignee
dict
assignees
list
milestone
null
comments
list
created_at
timestamp[ms]
updated_at
timestamp[ms]
closed_at
timestamp[ms]
author_association
string
type
dict
active_lock_reason
null
draft
bool
pull_request
dict
body
string
closed_by
dict
reactions
dict
timeline_url
string
performed_via_github_app
null
state_reason
string
sub_issues_summary
dict
issue_dependencies_summary
dict
is_pull_request
bool
is_closed
bool
https://api.github.com/repos/huggingface/transformers/issues/38326
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38326/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38326/comments
https://api.github.com/repos/huggingface/transformers/issues/38326/events
https://github.com/huggingface/transformers/issues/38326
3,086,751,343
I_kwDOCUB6oc63_BZv
38,326
Allow `MllamaModel` to accept `pixel_values` and `inputs_embeds`
{ "login": "dxoigmn", "id": 1328, "node_id": "MDQ6VXNlcjEzMjg=", "avatar_url": "https://avatars.githubusercontent.com/u/1328?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dxoigmn", "html_url": "https://github.com/dxoigmn", "followers_url": "https://api.github.com/users/dxoigmn/followers", "following_url": "https://api.github.com/users/dxoigmn/following{/other_user}", "gists_url": "https://api.github.com/users/dxoigmn/gists{/gist_id}", "starred_url": "https://api.github.com/users/dxoigmn/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dxoigmn/subscriptions", "organizations_url": "https://api.github.com/users/dxoigmn/orgs", "repos_url": "https://api.github.com/users/dxoigmn/repos", "events_url": "https://api.github.com/users/dxoigmn/events{/privacy}", "received_events_url": "https://api.github.com/users/dxoigmn/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 2648621985, "node_id": "MDU6TGFiZWwyNjQ4NjIxOTg1", "url": "https://api.github.com/repos/huggingface/transformers/labels/Feature%20request", "name": "Feature request", "color": "FBCA04", "default": false, "description": "Request for a new feature" } ]
closed
false
null
[]
null
[]
2025-05-23T15:26:28
2025-05-27T16:33:57
2025-05-27T16:33:57
CONTRIBUTOR
null
null
null
null
### Feature request `MllamaModel` does not allow users to pass `pixel_values` and `inputs_embeds` simultaneously: https://github.com/huggingface/transformers/blob/54cd86708d2b63a1f696ee1c59384a2f04100f57/src/transformers/models/mllama/modeling_mllama.py#L1702-L1705 However, commenting out those lines and running the follow script does generate the same logits: ```python import torch from transformers import MllamaForConditionalGeneration, AutoProcessor model_id = "meta-llama/Llama-3.2-11B-Vision-Instruct" model = MllamaForConditionalGeneration.from_pretrained( model_id, device_map="auto", torch_dtype=torch.bfloat16 ) processor = AutoProcessor.from_pretrained(model_id) messages = [ [ { "role": "user", "content": [ { "type": "image", "url": "https://llava-vl.github.io/static/images/view.jpg", }, {"type": "text", "text": "What does the image show?"}, ], } ], ] inputs = processor.apply_chat_template( messages, add_generation_prompt=True, tokenize=True, return_dict=True, return_tensors="pt", ).to(model.device) outputs = model(**inputs) # Manually compute inputs_embeds input_ids = inputs.pop("input_ids") inputs_embeds = model.get_input_embeddings()(input_ids) new_outputs = model(inputs_embeds=inputs_embeds, **inputs) assert torch.allclose(outputs.logits, new_outputs.logits) ``` ### Motivation Being able to pass `inputs_embeds` along with `pixel_values` enables soft embeddings to be passed to the model in addition to images, which is useful for prompt tuning. ### Your contribution Could contribute a PR removing the check assuming there isn't something I'm unaware of about the check.
{ "login": "zucchini-nlp", "id": 100715397, "node_id": "U_kgDOBgDLhQ", "avatar_url": "https://avatars.githubusercontent.com/u/100715397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zucchini-nlp", "html_url": "https://github.com/zucchini-nlp", "followers_url": "https://api.github.com/users/zucchini-nlp/followers", "following_url": "https://api.github.com/users/zucchini-nlp/following{/other_user}", "gists_url": "https://api.github.com/users/zucchini-nlp/gists{/gist_id}", "starred_url": "https://api.github.com/users/zucchini-nlp/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zucchini-nlp/subscriptions", "organizations_url": "https://api.github.com/users/zucchini-nlp/orgs", "repos_url": "https://api.github.com/users/zucchini-nlp/repos", "events_url": "https://api.github.com/users/zucchini-nlp/events{/privacy}", "received_events_url": "https://api.github.com/users/zucchini-nlp/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38326/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38326/timeline
null
completed
{ "total": 0, "completed": 0, "percent_completed": 0 }
{ "blocked_by": 0, "total_blocked_by": 0, "blocking": 0, "total_blocking": 0 }
false
true
https://api.github.com/repos/huggingface/transformers/issues/38325
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38325/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38325/comments
https://api.github.com/repos/huggingface/transformers/issues/38325/events
https://github.com/huggingface/transformers/pull/38325
3,086,660,867
PR_kwDOCUB6oc6XZyKj
38,325
Stop TF weight rename reDOS
{ "login": "Rocketknight1", "id": 12866554, "node_id": "MDQ6VXNlcjEyODY2NTU0", "avatar_url": "https://avatars.githubusercontent.com/u/12866554?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Rocketknight1", "html_url": "https://github.com/Rocketknight1", "followers_url": "https://api.github.com/users/Rocketknight1/followers", "following_url": "https://api.github.com/users/Rocketknight1/following{/other_user}", "gists_url": "https://api.github.com/users/Rocketknight1/gists{/gist_id}", "starred_url": "https://api.github.com/users/Rocketknight1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Rocketknight1/subscriptions", "organizations_url": "https://api.github.com/users/Rocketknight1/orgs", "repos_url": "https://api.github.com/users/Rocketknight1/repos", "events_url": "https://api.github.com/users/Rocketknight1/events{/privacy}", "received_events_url": "https://api.github.com/users/Rocketknight1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-23T14:56:31
2025-05-26T15:58:53
2025-05-26T15:58:52
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38325", "html_url": "https://github.com/huggingface/transformers/pull/38325", "diff_url": "https://github.com/huggingface/transformers/pull/38325.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38325.patch", "merged_at": "2025-05-26T15:58:51" }
The regex to convert TF names to Pytorch names has potential runtime blowup for malicious inputs, so we add a check to make sure nothing too big or malformed gets passed to it.
{ "login": "Rocketknight1", "id": 12866554, "node_id": "MDQ6VXNlcjEyODY2NTU0", "avatar_url": "https://avatars.githubusercontent.com/u/12866554?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Rocketknight1", "html_url": "https://github.com/Rocketknight1", "followers_url": "https://api.github.com/users/Rocketknight1/followers", "following_url": "https://api.github.com/users/Rocketknight1/following{/other_user}", "gists_url": "https://api.github.com/users/Rocketknight1/gists{/gist_id}", "starred_url": "https://api.github.com/users/Rocketknight1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Rocketknight1/subscriptions", "organizations_url": "https://api.github.com/users/Rocketknight1/orgs", "repos_url": "https://api.github.com/users/Rocketknight1/repos", "events_url": "https://api.github.com/users/Rocketknight1/events{/privacy}", "received_events_url": "https://api.github.com/users/Rocketknight1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38325/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38325/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38324
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38324/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38324/comments
https://api.github.com/repos/huggingface/transformers/issues/38324/events
https://github.com/huggingface/transformers/pull/38324
3,086,645,328
PR_kwDOCUB6oc6XZuxr
38,324
add `vasqu` to `self-comment-ci.yml`
{ "login": "ydshieh", "id": 2521628, "node_id": "MDQ6VXNlcjI1MjE2Mjg=", "avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ydshieh", "html_url": "https://github.com/ydshieh", "followers_url": "https://api.github.com/users/ydshieh/followers", "following_url": "https://api.github.com/users/ydshieh/following{/other_user}", "gists_url": "https://api.github.com/users/ydshieh/gists{/gist_id}", "starred_url": "https://api.github.com/users/ydshieh/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ydshieh/subscriptions", "organizations_url": "https://api.github.com/users/ydshieh/orgs", "repos_url": "https://api.github.com/users/ydshieh/repos", "events_url": "https://api.github.com/users/ydshieh/events{/privacy}", "received_events_url": "https://api.github.com/users/ydshieh/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-23T14:52:08
2025-05-23T15:09:46
2025-05-23T15:09:44
COLLABORATOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38324", "html_url": "https://github.com/huggingface/transformers/pull/38324", "diff_url": "https://github.com/huggingface/transformers/pull/38324.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38324.patch", "merged_at": "2025-05-23T15:09:44" }
# What does this PR do? So they can trigger a CI by leaving a comment on a PR.
{ "login": "ydshieh", "id": 2521628, "node_id": "MDQ6VXNlcjI1MjE2Mjg=", "avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ydshieh", "html_url": "https://github.com/ydshieh", "followers_url": "https://api.github.com/users/ydshieh/followers", "following_url": "https://api.github.com/users/ydshieh/following{/other_user}", "gists_url": "https://api.github.com/users/ydshieh/gists{/gist_id}", "starred_url": "https://api.github.com/users/ydshieh/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ydshieh/subscriptions", "organizations_url": "https://api.github.com/users/ydshieh/orgs", "repos_url": "https://api.github.com/users/ydshieh/repos", "events_url": "https://api.github.com/users/ydshieh/events{/privacy}", "received_events_url": "https://api.github.com/users/ydshieh/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38324/reactions", "total_count": 1, "+1": 0, "-1": 0, "laugh": 1, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38324/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38323
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38323/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38323/comments
https://api.github.com/repos/huggingface/transformers/issues/38323/events
https://github.com/huggingface/transformers/issues/38323
3,086,561,267
I_kwDOCUB6oc63-S_z
38,323
`PYTHONOPTIMIZE=2` seems not work with `transformers-`based library
{ "login": "IchiruTake", "id": 66363520, "node_id": "MDQ6VXNlcjY2MzYzNTIw", "avatar_url": "https://avatars.githubusercontent.com/u/66363520?v=4", "gravatar_id": "", "url": "https://api.github.com/users/IchiruTake", "html_url": "https://github.com/IchiruTake", "followers_url": "https://api.github.com/users/IchiruTake/followers", "following_url": "https://api.github.com/users/IchiruTake/following{/other_user}", "gists_url": "https://api.github.com/users/IchiruTake/gists{/gist_id}", "starred_url": "https://api.github.com/users/IchiruTake/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/IchiruTake/subscriptions", "organizations_url": "https://api.github.com/users/IchiruTake/orgs", "repos_url": "https://api.github.com/users/IchiruTake/repos", "events_url": "https://api.github.com/users/IchiruTake/events{/privacy}", "received_events_url": "https://api.github.com/users/IchiruTake/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 3817266200, "node_id": "MDU6TGFiZWwzODE3MjY2MjAw", "url": "https://api.github.com/repos/huggingface/transformers/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": null } ]
closed
false
null
[]
null
[]
2025-05-23T14:24:34
2025-05-26T14:29:17
2025-05-26T14:29:15
NONE
null
null
null
null
### System Info I am currently having the latest package install. torch 2.6.0+cu124 transformers 4.51.3 sentence-transformers 4.1.0 ### Who can help? _No response_ ### Information - [ ] The official example scripts - [ ] My own modified scripts ### Tasks - [ ] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...) - [ ] My own task or dataset (give details below) ### Reproduction Error: ```python File "<frozen importlib._bootstrap>", line 488, in _call_with_frames_removed File "D:\Dataset\AgentAI\.venv\Lib\site-packages\transformers\modeling_utils.py", line 5494, in <module> class SQuADHead(nn.Module): ...<113 lines>... ) File "D:\Dataset\AgentAI\.venv\Lib\site-packages\transformers\modeling_utils.py", line 5513, in SQuADHead @replace_return_docstrings(output_type=SquadHeadOutput, config_class=PretrainedConfig) ~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "D:\Dataset\AgentAI\.venv\Lib\site-packages\transformers\utils\doc.py", line 1194, in docstring_decorator lines = func_doc.split("\n") ^^^^^^^^^^^^^^ AttributeError: 'NoneType' object has no attribute 'split' ``` A simple reproduction: ```python from sentence_transformers import SentenceTransformer model = SentenceTransformer('all-MiniLM-L6-v2') embedding = model.encode("What is the capital of France?") print(embedding.shape) ``` ### Expected behavior This is not actually an issue, but I expect a documentation update from `transformers` maintainer to any end-users who use or develop a `transformers-` based library on the function `replace_return_docstrings` at `src/transformers/utils/doc.py` is to don't strip out the docstring by switching the option `PYTHONOPTIMIZE=2` to reduce the size of the bytecode. The use of `PYTHONOPTIMIZE=1` is OK The reason is that the function `replace_return_docstrings` is expecting to be a decorator function without supporting the case of empty docstring. In some case, such as web hosting on Docker or production environment, or hosting an LLM without tool call where we usually strip out the docstring. In the reproduction above (my use-case), I am just need to run the RAG search and thus don't need the docstring to be there.
{ "login": "Rocketknight1", "id": 12866554, "node_id": "MDQ6VXNlcjEyODY2NTU0", "avatar_url": "https://avatars.githubusercontent.com/u/12866554?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Rocketknight1", "html_url": "https://github.com/Rocketknight1", "followers_url": "https://api.github.com/users/Rocketknight1/followers", "following_url": "https://api.github.com/users/Rocketknight1/following{/other_user}", "gists_url": "https://api.github.com/users/Rocketknight1/gists{/gist_id}", "starred_url": "https://api.github.com/users/Rocketknight1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Rocketknight1/subscriptions", "organizations_url": "https://api.github.com/users/Rocketknight1/orgs", "repos_url": "https://api.github.com/users/Rocketknight1/repos", "events_url": "https://api.github.com/users/Rocketknight1/events{/privacy}", "received_events_url": "https://api.github.com/users/Rocketknight1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38323/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38323/timeline
null
not_planned
{ "total": 0, "completed": 0, "percent_completed": 0 }
{ "blocked_by": 0, "total_blocked_by": 0, "blocking": 0, "total_blocking": 0 }
false
true
https://api.github.com/repos/huggingface/transformers/issues/38322
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38322/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38322/comments
https://api.github.com/repos/huggingface/transformers/issues/38322/events
https://github.com/huggingface/transformers/pull/38322
3,086,372,665
PR_kwDOCUB6oc6XYz1Y
38,322
[chat] improvements for thinking models and reduce default verbosity
{ "login": "gante", "id": 12240844, "node_id": "MDQ6VXNlcjEyMjQwODQ0", "avatar_url": "https://avatars.githubusercontent.com/u/12240844?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gante", "html_url": "https://github.com/gante", "followers_url": "https://api.github.com/users/gante/followers", "following_url": "https://api.github.com/users/gante/following{/other_user}", "gists_url": "https://api.github.com/users/gante/gists{/gist_id}", "starred_url": "https://api.github.com/users/gante/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gante/subscriptions", "organizations_url": "https://api.github.com/users/gante/orgs", "repos_url": "https://api.github.com/users/gante/repos", "events_url": "https://api.github.com/users/gante/events{/privacy}", "received_events_url": "https://api.github.com/users/gante/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-23T13:25:12
2025-05-27T10:22:09
2025-05-27T10:20:58
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38322", "html_url": "https://github.com/huggingface/transformers/pull/38322", "diff_url": "https://github.com/huggingface/transformers/pull/38322.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38322.patch", "merged_at": "2025-05-27T10:20:58" }
# What does this PR do? Adds a few minor improvements: - `<think>` and `</think>` are now printed in the chat session. More generally, any pattern matching `<word_maybe_with_underscores>` (with optional `/` at the start of the word) should now be printed. Note that tokenizer decoding in `chat` skips special tokens like EOS by default. - By default, warnings (e.g. minor generation issues) and progress bars (e.g. loading kernels) are suppressed in the interactive session, but not when loading a model. There is a `verbose` flag to control it. - The initial help message is clearer about what `!help` does - negative numbers in flags are now properly handled (e.g. `!set eos_token_id=-1`) - added a new example, `numbers2` (9.11 > 9.9?) - bad commands starting with `!example` are now properly handled, instead of throwing an exception _____________________________ Example of an output with a `</think>`: ![Screenshot 2025-05-23 at 14 18 47](https://github.com/user-attachments/assets/47660ee1-a212-4f33-a9e9-74ed0bb3abe3)
{ "login": "gante", "id": 12240844, "node_id": "MDQ6VXNlcjEyMjQwODQ0", "avatar_url": "https://avatars.githubusercontent.com/u/12240844?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gante", "html_url": "https://github.com/gante", "followers_url": "https://api.github.com/users/gante/followers", "following_url": "https://api.github.com/users/gante/following{/other_user}", "gists_url": "https://api.github.com/users/gante/gists{/gist_id}", "starred_url": "https://api.github.com/users/gante/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gante/subscriptions", "organizations_url": "https://api.github.com/users/gante/orgs", "repos_url": "https://api.github.com/users/gante/repos", "events_url": "https://api.github.com/users/gante/events{/privacy}", "received_events_url": "https://api.github.com/users/gante/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38322/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38322/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38321
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38321/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38321/comments
https://api.github.com/repos/huggingface/transformers/issues/38321/events
https://github.com/huggingface/transformers/pull/38321
3,086,248,580
PR_kwDOCUB6oc6XYY6J
38,321
[`FlexAttention`] Reenable flex for encoder-decoder and make the test more robust
{ "login": "vasqu", "id": 73884904, "node_id": "MDQ6VXNlcjczODg0OTA0", "avatar_url": "https://avatars.githubusercontent.com/u/73884904?v=4", "gravatar_id": "", "url": "https://api.github.com/users/vasqu", "html_url": "https://github.com/vasqu", "followers_url": "https://api.github.com/users/vasqu/followers", "following_url": "https://api.github.com/users/vasqu/following{/other_user}", "gists_url": "https://api.github.com/users/vasqu/gists{/gist_id}", "starred_url": "https://api.github.com/users/vasqu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/vasqu/subscriptions", "organizations_url": "https://api.github.com/users/vasqu/orgs", "repos_url": "https://api.github.com/users/vasqu/repos", "events_url": "https://api.github.com/users/vasqu/events{/privacy}", "received_events_url": "https://api.github.com/users/vasqu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-23T12:40:27
2025-05-23T16:16:45
2025-05-23T16:16:43
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38321", "html_url": "https://github.com/huggingface/transformers/pull/38321", "diff_url": "https://github.com/huggingface/transformers/pull/38321.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38321.patch", "merged_at": "2025-05-23T16:16:43" }
The comment in the test describes pretty well what the issue is: ``` # Flex attention relies on triton on compilation # However, triton cannot handle hidden dimensions of less than 16 # --> forcing at least a hidden dim of 16 ``` Flex attention tests were failing because triton needs bigger hidden dimensions to work when compiling. This made a lot of models fail. There still are some models failing but it is at least way more reliable, robust, and manageable what is failing.
{ "login": "vasqu", "id": 73884904, "node_id": "MDQ6VXNlcjczODg0OTA0", "avatar_url": "https://avatars.githubusercontent.com/u/73884904?v=4", "gravatar_id": "", "url": "https://api.github.com/users/vasqu", "html_url": "https://github.com/vasqu", "followers_url": "https://api.github.com/users/vasqu/followers", "following_url": "https://api.github.com/users/vasqu/following{/other_user}", "gists_url": "https://api.github.com/users/vasqu/gists{/gist_id}", "starred_url": "https://api.github.com/users/vasqu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/vasqu/subscriptions", "organizations_url": "https://api.github.com/users/vasqu/orgs", "repos_url": "https://api.github.com/users/vasqu/repos", "events_url": "https://api.github.com/users/vasqu/events{/privacy}", "received_events_url": "https://api.github.com/users/vasqu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38321/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38321/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38320
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38320/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38320/comments
https://api.github.com/repos/huggingface/transformers/issues/38320/events
https://github.com/huggingface/transformers/pull/38320
3,086,133,733
PR_kwDOCUB6oc6XX_qb
38,320
[Falcon H1] Fix slow path forward pass
{ "login": "dhiaEddineRhaiem", "id": 163106757, "node_id": "U_kgDOCbjPxQ", "avatar_url": "https://avatars.githubusercontent.com/u/163106757?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dhiaEddineRhaiem", "html_url": "https://github.com/dhiaEddineRhaiem", "followers_url": "https://api.github.com/users/dhiaEddineRhaiem/followers", "following_url": "https://api.github.com/users/dhiaEddineRhaiem/following{/other_user}", "gists_url": "https://api.github.com/users/dhiaEddineRhaiem/gists{/gist_id}", "starred_url": "https://api.github.com/users/dhiaEddineRhaiem/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dhiaEddineRhaiem/subscriptions", "organizations_url": "https://api.github.com/users/dhiaEddineRhaiem/orgs", "repos_url": "https://api.github.com/users/dhiaEddineRhaiem/repos", "events_url": "https://api.github.com/users/dhiaEddineRhaiem/events{/privacy}", "received_events_url": "https://api.github.com/users/dhiaEddineRhaiem/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-23T11:55:39
2025-05-26T13:30:35
2025-05-26T13:30:35
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38320", "html_url": "https://github.com/huggingface/transformers/pull/38320", "diff_url": "https://github.com/huggingface/transformers/pull/38320.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38320.patch", "merged_at": "2025-05-26T13:30:35" }
This PR: 1. adds **MuP** **multipliers** in the fwd pass of the **slow path** `torch_forward` 2. Fixes the **repeat pattern** in **Mamba heads** , `repeat` **->** `repeat_interleave` see https://github.com/huggingface/transformers/pull/37533 @ArthurZucker
{ "login": "ydshieh", "id": 2521628, "node_id": "MDQ6VXNlcjI1MjE2Mjg=", "avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ydshieh", "html_url": "https://github.com/ydshieh", "followers_url": "https://api.github.com/users/ydshieh/followers", "following_url": "https://api.github.com/users/ydshieh/following{/other_user}", "gists_url": "https://api.github.com/users/ydshieh/gists{/gist_id}", "starred_url": "https://api.github.com/users/ydshieh/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ydshieh/subscriptions", "organizations_url": "https://api.github.com/users/ydshieh/orgs", "repos_url": "https://api.github.com/users/ydshieh/repos", "events_url": "https://api.github.com/users/ydshieh/events{/privacy}", "received_events_url": "https://api.github.com/users/ydshieh/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38320/reactions", "total_count": 3, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 3, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38320/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38319
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38319/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38319/comments
https://api.github.com/repos/huggingface/transformers/issues/38319/events
https://github.com/huggingface/transformers/pull/38319
3,086,111,360
PR_kwDOCUB6oc6XX6xj
38,319
Fix some tests (especially compile with fullgraph=True on Python<3.11)
{ "login": "Cyrilvallez", "id": 71554963, "node_id": "MDQ6VXNlcjcxNTU0OTYz", "avatar_url": "https://avatars.githubusercontent.com/u/71554963?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Cyrilvallez", "html_url": "https://github.com/Cyrilvallez", "followers_url": "https://api.github.com/users/Cyrilvallez/followers", "following_url": "https://api.github.com/users/Cyrilvallez/following{/other_user}", "gists_url": "https://api.github.com/users/Cyrilvallez/gists{/gist_id}", "starred_url": "https://api.github.com/users/Cyrilvallez/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Cyrilvallez/subscriptions", "organizations_url": "https://api.github.com/users/Cyrilvallez/orgs", "repos_url": "https://api.github.com/users/Cyrilvallez/repos", "events_url": "https://api.github.com/users/Cyrilvallez/events{/privacy}", "received_events_url": "https://api.github.com/users/Cyrilvallez/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-23T11:45:24
2025-05-23T15:13:37
2025-05-23T15:11:41
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38319", "html_url": "https://github.com/huggingface/transformers/pull/38319", "diff_url": "https://github.com/huggingface/transformers/pull/38319.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38319.patch", "merged_at": "2025-05-23T15:11:41" }
# What does this PR do? <!-- Congratulations! You've made it this far! You're not quite done yet though. Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution. Then, please replace this with a description of the change and which issue is fixed (if applicable). Please also include relevant motivation and context. List any dependencies (if any) that are required for this change. Once you're done, someone will review your PR shortly (see the section "Who can review?" below to tag some potential reviewers). They may suggest changes to make the code even better. If no one reviewed your PR after a week has passed, don't hesitate to post a new comment @-mentioning the same persons---sometimes notifications get lost. --> <!-- Remove if not applicable --> Fixes # (issue) ## Before submitting - [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [ ] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request), Pull Request section? - [ ] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case. - [ ] Did you make sure to update the documentation with your changes? Here are the [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation). - [ ] Did you write any new necessary tests? ## Who can review? Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR. <!-- Your PR will be replied to more quickly if you can figure out the right person to tag with @ If you know how to use git blame, that is the easiest way, otherwise, here is a rough guide of **who to tag**. Please tag fewer than 3 people. Models: - text models: @ArthurZucker - vision models: @amyeroberts, @qubvel - speech models: @eustlb - graph models: @clefourrier Library: - flax: @gante and @Rocketknight1 - generate: @zucchini-nlp (visual-language models) or @gante (all others) - pipelines: @Rocketknight1 - tensorflow: @gante and @Rocketknight1 - tokenizers: @ArthurZucker - trainer: @zach-huggingface and @SunMarc - chat templates: @Rocketknight1 Integrations: - deepspeed: HF Trainer/Accelerate: @SunMarc @zach-huggingface - ray/raytune: @richardliaw, @amogkam - Big Model Inference: @SunMarc - quantization (bitsandbytes, autogpt): @SunMarc @MekkCyber Documentation: @stevhliu HF projects: - accelerate: [different repo](https://github.com/huggingface/accelerate) - datasets: [different repo](https://github.com/huggingface/datasets) - diffusers: [different repo](https://github.com/huggingface/diffusers) - rust tokenizers: [different repo](https://github.com/huggingface/tokenizers) Maintained examples (not research project or legacy): - Flax: @Rocketknight1 - PyTorch: See Models above and tag the person corresponding to the modality of the example. - TensorFlow: @Rocketknight1 -->
{ "login": "Cyrilvallez", "id": 71554963, "node_id": "MDQ6VXNlcjcxNTU0OTYz", "avatar_url": "https://avatars.githubusercontent.com/u/71554963?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Cyrilvallez", "html_url": "https://github.com/Cyrilvallez", "followers_url": "https://api.github.com/users/Cyrilvallez/followers", "following_url": "https://api.github.com/users/Cyrilvallez/following{/other_user}", "gists_url": "https://api.github.com/users/Cyrilvallez/gists{/gist_id}", "starred_url": "https://api.github.com/users/Cyrilvallez/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Cyrilvallez/subscriptions", "organizations_url": "https://api.github.com/users/Cyrilvallez/orgs", "repos_url": "https://api.github.com/users/Cyrilvallez/repos", "events_url": "https://api.github.com/users/Cyrilvallez/events{/privacy}", "received_events_url": "https://api.github.com/users/Cyrilvallez/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38319/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38319/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38318
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38318/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38318/comments
https://api.github.com/repos/huggingface/transformers/issues/38318/events
https://github.com/huggingface/transformers/issues/38318
3,086,055,611
I_kwDOCUB6oc638Xi7
38,318
Potential mix-up with IMAGENET_STANDARD and IMAGENET_DEFAULT values
{ "login": "szymonkulpinski", "id": 39861049, "node_id": "MDQ6VXNlcjM5ODYxMDQ5", "avatar_url": "https://avatars.githubusercontent.com/u/39861049?v=4", "gravatar_id": "", "url": "https://api.github.com/users/szymonkulpinski", "html_url": "https://github.com/szymonkulpinski", "followers_url": "https://api.github.com/users/szymonkulpinski/followers", "following_url": "https://api.github.com/users/szymonkulpinski/following{/other_user}", "gists_url": "https://api.github.com/users/szymonkulpinski/gists{/gist_id}", "starred_url": "https://api.github.com/users/szymonkulpinski/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/szymonkulpinski/subscriptions", "organizations_url": "https://api.github.com/users/szymonkulpinski/orgs", "repos_url": "https://api.github.com/users/szymonkulpinski/repos", "events_url": "https://api.github.com/users/szymonkulpinski/events{/privacy}", "received_events_url": "https://api.github.com/users/szymonkulpinski/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 3817266200, "node_id": "MDU6TGFiZWwzODE3MjY2MjAw", "url": "https://api.github.com/repos/huggingface/transformers/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": null } ]
closed
false
null
[]
null
[]
2025-05-23T11:21:50
2025-07-02T08:03:13
2025-07-02T08:03:13
NONE
null
null
null
null
### System Info In the constants [file](https://github.com/huggingface/transformers/blob/main/src/transformers/utils/constants.py) used for image pre-processing for CLIP, SigLIP, SigLip 2 etc. there are 2 default/standard values defined: ``` IMAGENET_DEFAULT_MEAN = [0.485, 0.456, 0.406] IMAGENET_DEFAULT_STD = [0.229, 0.224, 0.225] IMAGENET_STANDARD_MEAN = [0.5, 0.5, 0.5] IMAGENET_STANDARD_STD = [0.5, 0.5, 0.5] OPENAI_CLIP_MEAN = [0.48145466, 0.4578275, 0.40821073] OPENAI_CLIP_STD = [0.26862954, 0.26130258, 0.27577711] ``` I think there is a mix-up caused by this. That sometimes the one or the other value is used. In my experience using the STANDARD variants led to way worse results, when using SigLIP and SigLIP2 (they are also the ones currently used in code). When I changed to DEFAULT, the results were way better. This might just be for my use-case, but I wanted to report it anyway. It feels like it STANDARD variants were programmed to be place-holders and somehow made it to the production, but I that is only my feeling 😄 You can see the difference for the resulting images here: ![Image](https://github.com/user-attachments/assets/6e8c39df-1f1f-4e96-b7a0-b4c493a9e47c) I dove deeper into the results topic in the "Image Procesing" part of the article: https://medium.com/@szym.kulpinski/clustering-football-players-using-image-embeddings-umap-and-k-means-part-2-cf0c28c87632 If there is anything unclear, I am happy to help 😄 ### Who can help? @NielsRogge ### Information - [ ] The official example scripts - [x] My own modified scripts ### Tasks - [ ] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...) - [x] My own task or dataset (give details below) ### Reproduction This is more of a theoretical consideration in general, but here is the code that you can use to print the info about the different pre-processers and re-create the images above. https://colab.research.google.com/drive/1xdjzHh8JSna3AJmLqvHFjz4pwK6GFa9g?usp=sharing ### Expected behavior Probably those should be removed ``` IMAGENET_STANDARD_MEAN = [0.5, 0.5, 0.5] IMAGENET_STANDARD_STD = [0.5, 0.5, 0.5] ``` and fully replaced by those: ``` IMAGENET_DEFAULT_MEAN = [0.485, 0.456, 0.406] IMAGENET_DEFAULT_STD = [0.229, 0.224, 0.225] ``` in all the implementations.
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38318/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38318/timeline
null
completed
{ "total": 0, "completed": 0, "percent_completed": 0 }
{ "blocked_by": 0, "total_blocked_by": 0, "blocking": 0, "total_blocking": 0 }
false
true
https://api.github.com/repos/huggingface/transformers/issues/38317
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38317/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38317/comments
https://api.github.com/repos/huggingface/transformers/issues/38317/events
https://github.com/huggingface/transformers/pull/38317
3,085,949,832
PR_kwDOCUB6oc6XXXus
38,317
🔴 [VLM] modeling updates
{ "login": "zucchini-nlp", "id": 100715397, "node_id": "U_kgDOBgDLhQ", "avatar_url": "https://avatars.githubusercontent.com/u/100715397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zucchini-nlp", "html_url": "https://github.com/zucchini-nlp", "followers_url": "https://api.github.com/users/zucchini-nlp/followers", "following_url": "https://api.github.com/users/zucchini-nlp/following{/other_user}", "gists_url": "https://api.github.com/users/zucchini-nlp/gists{/gist_id}", "starred_url": "https://api.github.com/users/zucchini-nlp/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zucchini-nlp/subscriptions", "organizations_url": "https://api.github.com/users/zucchini-nlp/orgs", "repos_url": "https://api.github.com/users/zucchini-nlp/repos", "events_url": "https://api.github.com/users/zucchini-nlp/events{/privacy}", "received_events_url": "https://api.github.com/users/zucchini-nlp/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-23T10:35:37
2025-08-28T11:29:12
2025-05-29T11:08:23
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38317", "html_url": "https://github.com/huggingface/transformers/pull/38317", "diff_url": "https://github.com/huggingface/transformers/pull/38317.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38317.patch", "merged_at": "2025-05-29T11:08:23" }
# What does this PR do? I forgot to change a few more things weren't changed in previous PRs. Specifically: - Attention refactor of Qwen and Persimmon (for Fuyu) - The helper `get_image_features` has to return images of certain shape and format. May be breaking and we had the helper as public prev 🙈
{ "login": "zucchini-nlp", "id": 100715397, "node_id": "U_kgDOBgDLhQ", "avatar_url": "https://avatars.githubusercontent.com/u/100715397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zucchini-nlp", "html_url": "https://github.com/zucchini-nlp", "followers_url": "https://api.github.com/users/zucchini-nlp/followers", "following_url": "https://api.github.com/users/zucchini-nlp/following{/other_user}", "gists_url": "https://api.github.com/users/zucchini-nlp/gists{/gist_id}", "starred_url": "https://api.github.com/users/zucchini-nlp/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zucchini-nlp/subscriptions", "organizations_url": "https://api.github.com/users/zucchini-nlp/orgs", "repos_url": "https://api.github.com/users/zucchini-nlp/repos", "events_url": "https://api.github.com/users/zucchini-nlp/events{/privacy}", "received_events_url": "https://api.github.com/users/zucchini-nlp/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38317/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38317/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38316
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38316/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38316/comments
https://api.github.com/repos/huggingface/transformers/issues/38316/events
https://github.com/huggingface/transformers/pull/38316
3,085,788,098
PR_kwDOCUB6oc6XW0MZ
38,316
[tf/flax] handle `forced_decoder_ids` deletion
{ "login": "gante", "id": 12240844, "node_id": "MDQ6VXNlcjEyMjQwODQ0", "avatar_url": "https://avatars.githubusercontent.com/u/12240844?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gante", "html_url": "https://github.com/gante", "followers_url": "https://api.github.com/users/gante/followers", "following_url": "https://api.github.com/users/gante/following{/other_user}", "gists_url": "https://api.github.com/users/gante/gists{/gist_id}", "starred_url": "https://api.github.com/users/gante/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gante/subscriptions", "organizations_url": "https://api.github.com/users/gante/orgs", "repos_url": "https://api.github.com/users/gante/repos", "events_url": "https://api.github.com/users/gante/events{/privacy}", "received_events_url": "https://api.github.com/users/gante/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-23T09:32:08
2025-05-23T09:45:31
2025-05-23T09:44:58
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38316", "html_url": "https://github.com/huggingface/transformers/pull/38316", "diff_url": "https://github.com/huggingface/transformers/pull/38316.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38316.patch", "merged_at": "2025-05-23T09:44:58" }
# What does this PR do? #38232 (follow-through of the deprecation of `forced_decoder_ids`) killed TF/FLAX generation, this PR fixes it :) failures from the daily CI are now passing, e.g. ``` CUDA_VISIBLE_DEVICES="" py.test tests/models/bart/test_modeling_tf_bart.py::TFBartModelTest::test_pipeline_text2text_generation_fp16 ```
{ "login": "gante", "id": 12240844, "node_id": "MDQ6VXNlcjEyMjQwODQ0", "avatar_url": "https://avatars.githubusercontent.com/u/12240844?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gante", "html_url": "https://github.com/gante", "followers_url": "https://api.github.com/users/gante/followers", "following_url": "https://api.github.com/users/gante/following{/other_user}", "gists_url": "https://api.github.com/users/gante/gists{/gist_id}", "starred_url": "https://api.github.com/users/gante/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gante/subscriptions", "organizations_url": "https://api.github.com/users/gante/orgs", "repos_url": "https://api.github.com/users/gante/repos", "events_url": "https://api.github.com/users/gante/events{/privacy}", "received_events_url": "https://api.github.com/users/gante/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38316/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38316/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38315
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38315/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38315/comments
https://api.github.com/repos/huggingface/transformers/issues/38315/events
https://github.com/huggingface/transformers/pull/38315
3,085,609,491
PR_kwDOCUB6oc6XWNlY
38,315
[Tests] Clean up test cases for few models
{ "login": "yaswanth19", "id": 82788246, "node_id": "MDQ6VXNlcjgyNzg4MjQ2", "avatar_url": "https://avatars.githubusercontent.com/u/82788246?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yaswanth19", "html_url": "https://github.com/yaswanth19", "followers_url": "https://api.github.com/users/yaswanth19/followers", "following_url": "https://api.github.com/users/yaswanth19/following{/other_user}", "gists_url": "https://api.github.com/users/yaswanth19/gists{/gist_id}", "starred_url": "https://api.github.com/users/yaswanth19/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yaswanth19/subscriptions", "organizations_url": "https://api.github.com/users/yaswanth19/orgs", "repos_url": "https://api.github.com/users/yaswanth19/repos", "events_url": "https://api.github.com/users/yaswanth19/events{/privacy}", "received_events_url": "https://api.github.com/users/yaswanth19/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-23T08:21:57
2025-06-27T07:28:37
2025-05-29T08:21:29
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38315", "html_url": "https://github.com/huggingface/transformers/pull/38315", "diff_url": "https://github.com/huggingface/transformers/pull/38315.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38315.patch", "merged_at": "2025-05-29T08:21:29" }
# What does this PR do? <!-- Congratulations! You've made it this far! You're not quite done yet though. Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution. Then, please replace this with a description of the change and which issue is fixed (if applicable). Please also include relevant motivation and context. List any dependencies (if any) that are required for this change. Once you're done, someone will review your PR shortly (see the section "Who can review?" below to tag some potential reviewers). They may suggest changes to make the code even better. If no one reviewed your PR after a week has passed, don't hesitate to post a new comment @-mentioning the same persons---sometimes notifications get lost. --> <!-- Remove if not applicable --> Continuation of #38311 ## Before submitting - [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [ ] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request), Pull Request section? - [ ] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case. - [ ] Did you make sure to update the documentation with your changes? Here are the [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation). - [ ] Did you write any new necessary tests? ## Who can review? Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR. <!-- Your PR will be replied to more quickly if you can figure out the right person to tag with @ If you know how to use git blame, that is the easiest way, otherwise, here is a rough guide of **who to tag**. Please tag fewer than 3 people. Models: - text models: @ArthurZucker - vision models: @amyeroberts, @qubvel - speech models: @eustlb - graph models: @clefourrier Library: - flax: @gante and @Rocketknight1 - generate: @zucchini-nlp (visual-language models) or @gante (all others) - pipelines: @Rocketknight1 - tensorflow: @gante and @Rocketknight1 - tokenizers: @ArthurZucker - trainer: @zach-huggingface and @SunMarc - chat templates: @Rocketknight1 Integrations: - deepspeed: HF Trainer/Accelerate: @SunMarc @zach-huggingface - ray/raytune: @richardliaw, @amogkam - Big Model Inference: @SunMarc - quantization (bitsandbytes, autogpt): @SunMarc @MekkCyber Documentation: @stevhliu HF projects: - accelerate: [different repo](https://github.com/huggingface/accelerate) - datasets: [different repo](https://github.com/huggingface/datasets) - diffusers: [different repo](https://github.com/huggingface/diffusers) - rust tokenizers: [different repo](https://github.com/huggingface/tokenizers) Maintained examples (not research project or legacy): - Flax: @Rocketknight1 - PyTorch: See Models above and tag the person corresponding to the modality of the example. - TensorFlow: @Rocketknight1 -->
{ "login": "zucchini-nlp", "id": 100715397, "node_id": "U_kgDOBgDLhQ", "avatar_url": "https://avatars.githubusercontent.com/u/100715397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zucchini-nlp", "html_url": "https://github.com/zucchini-nlp", "followers_url": "https://api.github.com/users/zucchini-nlp/followers", "following_url": "https://api.github.com/users/zucchini-nlp/following{/other_user}", "gists_url": "https://api.github.com/users/zucchini-nlp/gists{/gist_id}", "starred_url": "https://api.github.com/users/zucchini-nlp/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zucchini-nlp/subscriptions", "organizations_url": "https://api.github.com/users/zucchini-nlp/orgs", "repos_url": "https://api.github.com/users/zucchini-nlp/repos", "events_url": "https://api.github.com/users/zucchini-nlp/events{/privacy}", "received_events_url": "https://api.github.com/users/zucchini-nlp/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38315/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38315/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38314
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38314/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38314/comments
https://api.github.com/repos/huggingface/transformers/issues/38314/events
https://github.com/huggingface/transformers/pull/38314
3,085,579,879
PR_kwDOCUB6oc6XWHS1
38,314
Fix run_slow
{ "login": "cyyever", "id": 17618148, "node_id": "MDQ6VXNlcjE3NjE4MTQ4", "avatar_url": "https://avatars.githubusercontent.com/u/17618148?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cyyever", "html_url": "https://github.com/cyyever", "followers_url": "https://api.github.com/users/cyyever/followers", "following_url": "https://api.github.com/users/cyyever/following{/other_user}", "gists_url": "https://api.github.com/users/cyyever/gists{/gist_id}", "starred_url": "https://api.github.com/users/cyyever/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cyyever/subscriptions", "organizations_url": "https://api.github.com/users/cyyever/orgs", "repos_url": "https://api.github.com/users/cyyever/repos", "events_url": "https://api.github.com/users/cyyever/events{/privacy}", "received_events_url": "https://api.github.com/users/cyyever/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-23T08:10:48
2025-05-23T15:26:27
2025-05-23T08:18:30
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38314", "html_url": "https://github.com/huggingface/transformers/pull/38314", "diff_url": "https://github.com/huggingface/transformers/pull/38314.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38314.patch", "merged_at": "2025-05-23T08:18:30" }
# What does this PR do? `run_slow` was renamed to `slow`
{ "login": "ydshieh", "id": 2521628, "node_id": "MDQ6VXNlcjI1MjE2Mjg=", "avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ydshieh", "html_url": "https://github.com/ydshieh", "followers_url": "https://api.github.com/users/ydshieh/followers", "following_url": "https://api.github.com/users/ydshieh/following{/other_user}", "gists_url": "https://api.github.com/users/ydshieh/gists{/gist_id}", "starred_url": "https://api.github.com/users/ydshieh/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ydshieh/subscriptions", "organizations_url": "https://api.github.com/users/ydshieh/orgs", "repos_url": "https://api.github.com/users/ydshieh/repos", "events_url": "https://api.github.com/users/ydshieh/events{/privacy}", "received_events_url": "https://api.github.com/users/ydshieh/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38314/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38314/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38313
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38313/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38313/comments
https://api.github.com/repos/huggingface/transformers/issues/38313/events
https://github.com/huggingface/transformers/issues/38313
3,085,176,589
I_kwDOCUB6oc635A8N
38,313
The latest transformer.utils.fx does not working on llama. Only far older version(4.45.1) works.
{ "login": "Sangyu-Han", "id": 112687392, "node_id": "U_kgDOBrd5IA", "avatar_url": "https://avatars.githubusercontent.com/u/112687392?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Sangyu-Han", "html_url": "https://github.com/Sangyu-Han", "followers_url": "https://api.github.com/users/Sangyu-Han/followers", "following_url": "https://api.github.com/users/Sangyu-Han/following{/other_user}", "gists_url": "https://api.github.com/users/Sangyu-Han/gists{/gist_id}", "starred_url": "https://api.github.com/users/Sangyu-Han/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Sangyu-Han/subscriptions", "organizations_url": "https://api.github.com/users/Sangyu-Han/orgs", "repos_url": "https://api.github.com/users/Sangyu-Han/repos", "events_url": "https://api.github.com/users/Sangyu-Han/events{/privacy}", "received_events_url": "https://api.github.com/users/Sangyu-Han/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 3817266200, "node_id": "MDU6TGFiZWwzODE3MjY2MjAw", "url": "https://api.github.com/repos/huggingface/transformers/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": null } ]
closed
false
null
[]
null
[]
2025-05-23T05:05:38
2025-06-30T08:02:58
2025-06-30T08:02:58
NONE
null
null
null
null
### System Info - `transformers` version: 4.52.3 - Platform: Linux-6.8.0-59-generic-x86_64-with-glibc2.39 - Python version: 3.12.2 - Huggingface_hub version: 0.31.4 - Safetensors version: 0.4.3 - Accelerate version: 0.30.1 - Accelerate config: not found - DeepSpeed version: not installed - PyTorch version (GPU?): 2.5.1+cu124 (True) - Tensorflow version (GPU?): not installed (NA) - Flax version (CPU?/GPU?/TPU?): not installed (NA) - Jax version: not installed - JaxLib version: not installed - Using distributed or parallel set-up in script?: No - Using GPU in script?: No - GPU type: NVIDIA GeForce RTX 3090 ### Who can help? _No response_ ### Information - [ ] The official example scripts - [ ] My own modified scripts ### Tasks - [ ] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...) - [ ] My own task or dataset (give details below) ### Reproduction from transformers import AutoModelForCausalLM from transformers.utils.fx import symbolic_trace import torch import sys, types, torch.fx._symbolic_trace as st from types import CodeType from transformers import AutoTokenizer import sys, types import torch.fx._symbolic_trace as sym import transformers.utils.fx as tfx model = AutoModelForCausalLM.from_pretrained("meta-llama/Llama-3.2-1B") tokenizer = AutoTokenizer.from_pretrained("meta-llama/Llama-3.2-1B") model.eval() prompt = """\ Context: Mount Everest attracts many climbers, including highly experienced mountaineers. There are two main climbing routes, one approaching the summit from the southeast in Nepal (known as the standard route) and the other from the north in Tibet. While not posing substantial technical climbing challenges on the standard route, Everest presents dangers such as altitude sickness, weather, and wind, as well as hazards from avalanches and the Khumbu Icefall. As of November 2022, 310 people have died on Everest. Over 200 bodies remain on the mountain and have not been removed due to the dangerous conditions. The first recorded efforts to reach Everest's summit were made by British mountaineers. As Nepal did not allow foreigners to enter the country at the time, the British made several attempts on the north ridge route from the Tibetan side. After the first reconnaissance expedition by the British in 1921 reached 7,000 m (22,970 ft) on the North Col, the 1922 expedition pushed the north ridge route up to 8,320 m (27,300 ft), marking the first time a human had climbed above 8,000 m (26,247 ft). The 1924 expedition resulted in one of the greatest mysteries on Everest to this day: George Mallory and Andrew Irvine made a final summit attempt on 8 June but never returned, sparking debate as to whether they were the first to reach the top. Tenzing Norgay and Edmund Hillary made the first documented ascent of Everest in 1953, using the southeast ridge route. Norgay had reached 8,595 m (28,199 ft) the previous year as a member of the 1952 Swiss expedition. The Chinese mountaineering team of Wang Fuzhou, Gonpo, and Qu Yinhua made the first reported ascent of the peak from the north ridge on 25 May 1960. \ Question: How high did they climb in 1922? According to the text, the 1922 expedition reached 8,""" input_ids = tokenizer(prompt, return_tensors="pt", add_special_tokens=True).input_ids.to(model.device) traced = tfx.symbolic_trace(model) <-- ValueError print(traced.graph) The error message is : File "/home/sangyu/Desktop/Master/delphi-main/trace_test.py", line 28, in <module> traced = tfx.symbolic_trace(model) ^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/sangyu/anaconda3/envs/py312/lib/python3.12/site-packages/transformers/utils/fx.py", line 1503, in symbolic_trace traced_graph = tracer.trace(model, concrete_args=concrete_args) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/sangyu/anaconda3/envs/py312/lib/python3.12/site-packages/transformers/utils/fx.py", line 1326, in trace self.graph = super().trace(root, concrete_args=concrete_args) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/sangyu/anaconda3/envs/py312/lib/python3.12/site-packages/torch/fx/_symbolic_trace.py", line 776, in trace fn, args = self.create_args_for_root( ^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/sangyu/anaconda3/envs/py312/lib/python3.12/site-packages/torch/fx/_symbolic_trace.py", line 663, in create_args_for_root root_fn = _patch_function(root_fn, len(args)) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/sangyu/anaconda3/envs/py312/lib/python3.12/site-packages/torch/fx/_symbolic_trace.py", line 189, in _patch_function new_code = CodeType(*co_args) # type: ignore[arg-type] ^^^^^^^^^^^^^^^^^^ ValueError: code: co_varnames is too small ### Expected behavior It should not return error. Even though this is the simplest implemention using transformers.utils.fx.symbolic_trace, it returns error. However, when I run the same code with python==3.10 and transformers==4.45.1 It runs successfully.
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38313/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38313/timeline
null
completed
{ "total": 0, "completed": 0, "percent_completed": 0 }
{ "blocked_by": 0, "total_blocked_by": 0, "blocking": 0, "total_blocking": 0 }
false
true
https://api.github.com/repos/huggingface/transformers/issues/38312
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38312/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38312/comments
https://api.github.com/repos/huggingface/transformers/issues/38312/events
https://github.com/huggingface/transformers/issues/38312
3,085,061,733
I_kwDOCUB6oc634k5l
38,312
LagKV for key-value compression
{ "login": "JoelSeniorLiang", "id": 5005500, "node_id": "MDQ6VXNlcjUwMDU1MDA=", "avatar_url": "https://avatars.githubusercontent.com/u/5005500?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JoelSeniorLiang", "html_url": "https://github.com/JoelSeniorLiang", "followers_url": "https://api.github.com/users/JoelSeniorLiang/followers", "following_url": "https://api.github.com/users/JoelSeniorLiang/following{/other_user}", "gists_url": "https://api.github.com/users/JoelSeniorLiang/gists{/gist_id}", "starred_url": "https://api.github.com/users/JoelSeniorLiang/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JoelSeniorLiang/subscriptions", "organizations_url": "https://api.github.com/users/JoelSeniorLiang/orgs", "repos_url": "https://api.github.com/users/JoelSeniorLiang/repos", "events_url": "https://api.github.com/users/JoelSeniorLiang/events{/privacy}", "received_events_url": "https://api.github.com/users/JoelSeniorLiang/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 2648621985, "node_id": "MDU6TGFiZWwyNjQ4NjIxOTg1", "url": "https://api.github.com/repos/huggingface/transformers/labels/Feature%20request", "name": "Feature request", "color": "FBCA04", "default": false, "description": "Request for a new feature" } ]
open
false
null
[]
null
[]
2025-05-23T03:54:42
2025-06-09T03:12:44
null
NONE
null
null
null
null
### Feature request Integrated the LagKV for KV compression. https://github.com/AI-Lab-China-Merchants-Bank/LagKV ### Motivation Right now, the Cache utils is expanding rapidly. But, it still lack an efficient token eviction algorithm except SinkCache and SlidingWindowCache, which show limited performance in information retrieval tasks. LagKV provides a compression strategy which offers follow features: 1. High accuracy performance in Needle-In-A-Haystack Passkey retrieval and other normal tasks. 2. Training free: no finetune required. 3. Warmup free: no pre warm up required, no additional parameters attached. 4. Efficient: negligible computation overhead, Flash-Attention compatible. ### Your contribution Author of LagKV. Implement a version of Cache Interface.
null
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38312/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38312/timeline
null
null
{ "total": 0, "completed": 0, "percent_completed": 0 }
{ "blocked_by": 0, "total_blocked_by": 0, "blocking": 0, "total_blocking": 0 }
false
false
https://api.github.com/repos/huggingface/transformers/issues/38311
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38311/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38311/comments
https://api.github.com/repos/huggingface/transformers/issues/38311/events
https://github.com/huggingface/transformers/pull/38311
3,085,008,545
PR_kwDOCUB6oc6XUMtH
38,311
[Tests] Cleanup Janus Testcase
{ "login": "yaswanth19", "id": 82788246, "node_id": "MDQ6VXNlcjgyNzg4MjQ2", "avatar_url": "https://avatars.githubusercontent.com/u/82788246?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yaswanth19", "html_url": "https://github.com/yaswanth19", "followers_url": "https://api.github.com/users/yaswanth19/followers", "following_url": "https://api.github.com/users/yaswanth19/following{/other_user}", "gists_url": "https://api.github.com/users/yaswanth19/gists{/gist_id}", "starred_url": "https://api.github.com/users/yaswanth19/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yaswanth19/subscriptions", "organizations_url": "https://api.github.com/users/yaswanth19/orgs", "repos_url": "https://api.github.com/users/yaswanth19/repos", "events_url": "https://api.github.com/users/yaswanth19/events{/privacy}", "received_events_url": "https://api.github.com/users/yaswanth19/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-23T03:07:39
2025-06-18T14:20:02
2025-05-23T07:29:16
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38311", "html_url": "https://github.com/huggingface/transformers/pull/38311", "diff_url": "https://github.com/huggingface/transformers/pull/38311.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38311.patch", "merged_at": "2025-05-23T07:29:16" }
# What does this PR do? For Janus Processor Tests we are importing `CHAT_TEMPLATE` from conversion which is not ideal. Hence this PR fixes that issue. Fixes #38270 <!-- Congratulations! You've made it this far! You're not quite done yet though. Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution. Then, please replace this with a description of the change and which issue is fixed (if applicable). Please also include relevant motivation and context. List any dependencies (if any) that are required for this change. Once you're done, someone will review your PR shortly (see the section "Who can review?" below to tag some potential reviewers). They may suggest changes to make the code even better. If no one reviewed your PR after a week has passed, don't hesitate to post a new comment @-mentioning the same persons---sometimes notifications get lost. --> <!-- Remove if not applicable --> ## Before submitting - [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [ ] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request), Pull Request section? - [ ] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case. - [ ] Did you make sure to update the documentation with your changes? Here are the [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation). - [ ] Did you write any new necessary tests? ## Who can review? Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR. <!-- Your PR will be replied to more quickly if you can figure out the right person to tag with @ If you know how to use git blame, that is the easiest way, otherwise, here is a rough guide of **who to tag**. Please tag fewer than 3 people. Models: - text models: @ArthurZucker - vision models: @amyeroberts, @qubvel - speech models: @eustlb - graph models: @clefourrier Library: - flax: @gante and @Rocketknight1 - generate: @zucchini-nlp (visual-language models) or @gante (all others) - pipelines: @Rocketknight1 - tensorflow: @gante and @Rocketknight1 - tokenizers: @ArthurZucker - trainer: @zach-huggingface and @SunMarc - chat templates: @Rocketknight1 Integrations: - deepspeed: HF Trainer/Accelerate: @SunMarc @zach-huggingface - ray/raytune: @richardliaw, @amogkam - Big Model Inference: @SunMarc - quantization (bitsandbytes, autogpt): @SunMarc @MekkCyber Documentation: @stevhliu HF projects: - accelerate: [different repo](https://github.com/huggingface/accelerate) - datasets: [different repo](https://github.com/huggingface/datasets) - diffusers: [different repo](https://github.com/huggingface/diffusers) - rust tokenizers: [different repo](https://github.com/huggingface/tokenizers) Maintained examples (not research project or legacy): - Flax: @Rocketknight1 - PyTorch: See Models above and tag the person corresponding to the modality of the example. - TensorFlow: @Rocketknight1 -->
{ "login": "ArthurZucker", "id": 48595927, "node_id": "MDQ6VXNlcjQ4NTk1OTI3", "avatar_url": "https://avatars.githubusercontent.com/u/48595927?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ArthurZucker", "html_url": "https://github.com/ArthurZucker", "followers_url": "https://api.github.com/users/ArthurZucker/followers", "following_url": "https://api.github.com/users/ArthurZucker/following{/other_user}", "gists_url": "https://api.github.com/users/ArthurZucker/gists{/gist_id}", "starred_url": "https://api.github.com/users/ArthurZucker/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ArthurZucker/subscriptions", "organizations_url": "https://api.github.com/users/ArthurZucker/orgs", "repos_url": "https://api.github.com/users/ArthurZucker/repos", "events_url": "https://api.github.com/users/ArthurZucker/events{/privacy}", "received_events_url": "https://api.github.com/users/ArthurZucker/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38311/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38311/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38310
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38310/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38310/comments
https://api.github.com/repos/huggingface/transformers/issues/38310/events
https://github.com/huggingface/transformers/pull/38310
3,084,787,210
PR_kwDOCUB6oc6XTd4Z
38,310
Use Gradient Checkpointing Layer in Jamba & Blip Related Models
{ "login": "alex-jw-brooks", "id": 10740300, "node_id": "MDQ6VXNlcjEwNzQwMzAw", "avatar_url": "https://avatars.githubusercontent.com/u/10740300?v=4", "gravatar_id": "", "url": "https://api.github.com/users/alex-jw-brooks", "html_url": "https://github.com/alex-jw-brooks", "followers_url": "https://api.github.com/users/alex-jw-brooks/followers", "following_url": "https://api.github.com/users/alex-jw-brooks/following{/other_user}", "gists_url": "https://api.github.com/users/alex-jw-brooks/gists{/gist_id}", "starred_url": "https://api.github.com/users/alex-jw-brooks/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/alex-jw-brooks/subscriptions", "organizations_url": "https://api.github.com/users/alex-jw-brooks/orgs", "repos_url": "https://api.github.com/users/alex-jw-brooks/repos", "events_url": "https://api.github.com/users/alex-jw-brooks/events{/privacy}", "received_events_url": "https://api.github.com/users/alex-jw-brooks/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-22T23:42:58
2025-05-25T19:46:14
2025-05-23T17:35:25
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38310", "html_url": "https://github.com/huggingface/transformers/pull/38310", "diff_url": "https://github.com/huggingface/transformers/pull/38310.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38310.patch", "merged_at": "2025-05-23T17:35:25" }
Updates a few models to use the new `GradientCheckpointingLayer`. The models changed in this PR are leveraged by IBM model architectures (granite vision / bamba) or share code, either directly or through modular. Happy to submit a follow-up with other models too if that would be helpful! Updated models: - jamba - bamba - blip - blip2 - instructblip - instructblipvideo @ArthurZucker
{ "login": "ArthurZucker", "id": 48595927, "node_id": "MDQ6VXNlcjQ4NTk1OTI3", "avatar_url": "https://avatars.githubusercontent.com/u/48595927?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ArthurZucker", "html_url": "https://github.com/ArthurZucker", "followers_url": "https://api.github.com/users/ArthurZucker/followers", "following_url": "https://api.github.com/users/ArthurZucker/following{/other_user}", "gists_url": "https://api.github.com/users/ArthurZucker/gists{/gist_id}", "starred_url": "https://api.github.com/users/ArthurZucker/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ArthurZucker/subscriptions", "organizations_url": "https://api.github.com/users/ArthurZucker/orgs", "repos_url": "https://api.github.com/users/ArthurZucker/repos", "events_url": "https://api.github.com/users/ArthurZucker/events{/privacy}", "received_events_url": "https://api.github.com/users/ArthurZucker/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38310/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38310/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38307
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38307/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38307/comments
https://api.github.com/repos/huggingface/transformers/issues/38307/events
https://github.com/huggingface/transformers/pull/38307
3,084,677,762
PR_kwDOCUB6oc6XTF7G
38,307
Expose AutoModelForTimeSeriesPrediction for import
{ "login": "jinan-zhou", "id": 22840378, "node_id": "MDQ6VXNlcjIyODQwMzc4", "avatar_url": "https://avatars.githubusercontent.com/u/22840378?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jinan-zhou", "html_url": "https://github.com/jinan-zhou", "followers_url": "https://api.github.com/users/jinan-zhou/followers", "following_url": "https://api.github.com/users/jinan-zhou/following{/other_user}", "gists_url": "https://api.github.com/users/jinan-zhou/gists{/gist_id}", "starred_url": "https://api.github.com/users/jinan-zhou/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jinan-zhou/subscriptions", "organizations_url": "https://api.github.com/users/jinan-zhou/orgs", "repos_url": "https://api.github.com/users/jinan-zhou/repos", "events_url": "https://api.github.com/users/jinan-zhou/events{/privacy}", "received_events_url": "https://api.github.com/users/jinan-zhou/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-22T22:22:59
2025-05-23T13:09:30
2025-05-23T13:09:29
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38307", "html_url": "https://github.com/huggingface/transformers/pull/38307", "diff_url": "https://github.com/huggingface/transformers/pull/38307.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38307.patch", "merged_at": "2025-05-23T13:09:29" }
Add `AutoModelForTimeSeriesPrediction` to `__all__` in `modeling_auto` so that it can be imported: ``` from transformers import AutoModelForTimeSeriesPrediction ``` This class will be the portal to all time series models in Hugging Face. It is a missing part of #34082 and this PR aims to fix it.
{ "login": "Rocketknight1", "id": 12866554, "node_id": "MDQ6VXNlcjEyODY2NTU0", "avatar_url": "https://avatars.githubusercontent.com/u/12866554?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Rocketknight1", "html_url": "https://github.com/Rocketknight1", "followers_url": "https://api.github.com/users/Rocketknight1/followers", "following_url": "https://api.github.com/users/Rocketknight1/following{/other_user}", "gists_url": "https://api.github.com/users/Rocketknight1/gists{/gist_id}", "starred_url": "https://api.github.com/users/Rocketknight1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Rocketknight1/subscriptions", "organizations_url": "https://api.github.com/users/Rocketknight1/orgs", "repos_url": "https://api.github.com/users/Rocketknight1/repos", "events_url": "https://api.github.com/users/Rocketknight1/events{/privacy}", "received_events_url": "https://api.github.com/users/Rocketknight1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38307/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38307/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38306
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38306/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38306/comments
https://api.github.com/repos/huggingface/transformers/issues/38306/events
https://github.com/huggingface/transformers/pull/38306
3,084,432,999
PR_kwDOCUB6oc6XSQWh
38,306
Update altCLIP model card
{ "login": "EmileAydar", "id": 114087019, "node_id": "U_kgDOBszUaw", "avatar_url": "https://avatars.githubusercontent.com/u/114087019?v=4", "gravatar_id": "", "url": "https://api.github.com/users/EmileAydar", "html_url": "https://github.com/EmileAydar", "followers_url": "https://api.github.com/users/EmileAydar/followers", "following_url": "https://api.github.com/users/EmileAydar/following{/other_user}", "gists_url": "https://api.github.com/users/EmileAydar/gists{/gist_id}", "starred_url": "https://api.github.com/users/EmileAydar/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/EmileAydar/subscriptions", "organizations_url": "https://api.github.com/users/EmileAydar/orgs", "repos_url": "https://api.github.com/users/EmileAydar/repos", "events_url": "https://api.github.com/users/EmileAydar/events{/privacy}", "received_events_url": "https://api.github.com/users/EmileAydar/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-22T20:05:49
2025-06-11T21:48:35
2025-06-11T21:48:34
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38306", "html_url": "https://github.com/huggingface/transformers/pull/38306", "diff_url": "https://github.com/huggingface/transformers/pull/38306.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38306.patch", "merged_at": "2025-06-11T21:48:34" }
# What does this PR do? As suggested in this issue - https://github.com/huggingface/transformers/issues/36979#issuecomment-2902300855 - this PR rewrites the altCLIP model card so it matches the standardized template that @stevhliu introduced in #36979. Key points: - Friend-style overview + sidebar badges. - <hfoptions> usage tabs — Pipeline tab explains why it’s missing, AutoModel tab contains a runnable similarity example, transformers-cli tab shows one-liner quantisation. - Quantisation section with dynamic INT-8 snippet (Linear-only, Embeddings left FP32) and link to the Quantization guide. - Attention visualisation section: explains current AttentionMaskVisualizer limitation and shows a manual ViT-attention workaround; embeds a PNG heat-map (CLS attention, last layer, head - All text follows Steve’s template verbatim where required. Check list - [DONE] Brief model description - [ DONE] Ready-to-use code examples (Pipeline ✗, AutoModel ✓, transformers-cli ✓) - [ DONE] Quantisation example for a large model (dynamic INT-8) - [DONE ] Attention mask visualiser (note + workaround ) # I did not provide an image because it is not produced from the HF visualizer, but I can if required. # Who can review? Hi @stevhliu ! I updated the altCLIP model card following the standard format. Let me know what you think of it. Happy to revise. Thanks!
{ "login": "stevhliu", "id": 59462357, "node_id": "MDQ6VXNlcjU5NDYyMzU3", "avatar_url": "https://avatars.githubusercontent.com/u/59462357?v=4", "gravatar_id": "", "url": "https://api.github.com/users/stevhliu", "html_url": "https://github.com/stevhliu", "followers_url": "https://api.github.com/users/stevhliu/followers", "following_url": "https://api.github.com/users/stevhliu/following{/other_user}", "gists_url": "https://api.github.com/users/stevhliu/gists{/gist_id}", "starred_url": "https://api.github.com/users/stevhliu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/stevhliu/subscriptions", "organizations_url": "https://api.github.com/users/stevhliu/orgs", "repos_url": "https://api.github.com/users/stevhliu/repos", "events_url": "https://api.github.com/users/stevhliu/events{/privacy}", "received_events_url": "https://api.github.com/users/stevhliu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38306/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38306/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38305
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38305/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38305/comments
https://api.github.com/repos/huggingface/transformers/issues/38305/events
https://github.com/huggingface/transformers/pull/38305
3,084,087,022
PR_kwDOCUB6oc6XRE3J
38,305
Remove duplicate docstring: resample
{ "login": "qqii", "id": 6891353, "node_id": "MDQ6VXNlcjY4OTEzNTM=", "avatar_url": "https://avatars.githubusercontent.com/u/6891353?v=4", "gravatar_id": "", "url": "https://api.github.com/users/qqii", "html_url": "https://github.com/qqii", "followers_url": "https://api.github.com/users/qqii/followers", "following_url": "https://api.github.com/users/qqii/following{/other_user}", "gists_url": "https://api.github.com/users/qqii/gists{/gist_id}", "starred_url": "https://api.github.com/users/qqii/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/qqii/subscriptions", "organizations_url": "https://api.github.com/users/qqii/orgs", "repos_url": "https://api.github.com/users/qqii/repos", "events_url": "https://api.github.com/users/qqii/events{/privacy}", "received_events_url": "https://api.github.com/users/qqii/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-22T17:28:16
2025-05-23T20:02:59
2025-05-23T20:02:58
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38305", "html_url": "https://github.com/huggingface/transformers/pull/38305", "diff_url": "https://github.com/huggingface/transformers/pull/38305.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38305.patch", "merged_at": "2025-05-23T20:02:58" }
Duplicate of the line above. @stevhliu # What does this PR do? <!-- Congratulations! You've made it this far! You're not quite done yet though. Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution. Then, please replace this with a description of the change and which issue is fixed (if applicable). Please also include relevant motivation and context. List any dependencies (if any) that are required for this change. Once you're done, someone will review your PR shortly (see the section "Who can review?" below to tag some potential reviewers). They may suggest changes to make the code even better. If no one reviewed your PR after a week has passed, don't hesitate to post a new comment @-mentioning the same persons---sometimes notifications get lost. --> <!-- Remove if not applicable --> Fixes # (issue) ## Before submitting - [x] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [x] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request), Pull Request section? - [ ] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case. - [ ] Did you make sure to update the documentation with your changes? Here are the [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation). - [ ] Did you write any new necessary tests? ## Who can review? Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR. <!-- Your PR will be replied to more quickly if you can figure out the right person to tag with @ If you know how to use git blame, that is the easiest way, otherwise, here is a rough guide of **who to tag**. Please tag fewer than 3 people. Models: - text models: @ArthurZucker - vision models: @amyeroberts, @qubvel - speech models: @eustlb - graph models: @clefourrier Library: - flax: @gante and @Rocketknight1 - generate: @zucchini-nlp (visual-language models) or @gante (all others) - pipelines: @Rocketknight1 - tensorflow: @gante and @Rocketknight1 - tokenizers: @ArthurZucker - trainer: @zach-huggingface and @SunMarc - chat templates: @Rocketknight1 Integrations: - deepspeed: HF Trainer/Accelerate: @SunMarc @zach-huggingface - ray/raytune: @richardliaw, @amogkam - Big Model Inference: @SunMarc - quantization (bitsandbytes, autogpt): @SunMarc @MekkCyber Documentation: @stevhliu HF projects: - accelerate: [different repo](https://github.com/huggingface/accelerate) - datasets: [different repo](https://github.com/huggingface/datasets) - diffusers: [different repo](https://github.com/huggingface/diffusers) - rust tokenizers: [different repo](https://github.com/huggingface/tokenizers) Maintained examples (not research project or legacy): - Flax: @Rocketknight1 - PyTorch: See Models above and tag the person corresponding to the modality of the example. - TensorFlow: @Rocketknight1 -->
{ "login": "stevhliu", "id": 59462357, "node_id": "MDQ6VXNlcjU5NDYyMzU3", "avatar_url": "https://avatars.githubusercontent.com/u/59462357?v=4", "gravatar_id": "", "url": "https://api.github.com/users/stevhliu", "html_url": "https://github.com/stevhliu", "followers_url": "https://api.github.com/users/stevhliu/followers", "following_url": "https://api.github.com/users/stevhliu/following{/other_user}", "gists_url": "https://api.github.com/users/stevhliu/gists{/gist_id}", "starred_url": "https://api.github.com/users/stevhliu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/stevhliu/subscriptions", "organizations_url": "https://api.github.com/users/stevhliu/orgs", "repos_url": "https://api.github.com/users/stevhliu/repos", "events_url": "https://api.github.com/users/stevhliu/events{/privacy}", "received_events_url": "https://api.github.com/users/stevhliu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38305/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38305/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38304
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38304/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38304/comments
https://api.github.com/repos/huggingface/transformers/issues/38304/events
https://github.com/huggingface/transformers/pull/38304
3,083,908,492
PR_kwDOCUB6oc6XQeHO
38,304
[custom_generate] don't forward `custom_generate` and `trust_remote_code`
{ "login": "gante", "id": 12240844, "node_id": "MDQ6VXNlcjEyMjQwODQ0", "avatar_url": "https://avatars.githubusercontent.com/u/12240844?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gante", "html_url": "https://github.com/gante", "followers_url": "https://api.github.com/users/gante/followers", "following_url": "https://api.github.com/users/gante/following{/other_user}", "gists_url": "https://api.github.com/users/gante/gists{/gist_id}", "starred_url": "https://api.github.com/users/gante/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gante/subscriptions", "organizations_url": "https://api.github.com/users/gante/orgs", "repos_url": "https://api.github.com/users/gante/repos", "events_url": "https://api.github.com/users/gante/events{/privacy}", "received_events_url": "https://api.github.com/users/gante/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-22T16:14:41
2025-05-23T14:49:40
2025-05-23T14:49:40
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38304", "html_url": "https://github.com/huggingface/transformers/pull/38304", "diff_url": "https://github.com/huggingface/transformers/pull/38304.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38304.patch", "merged_at": "2025-05-23T14:49:40" }
# What does this PR do? When calling a `custom_generate` method, don't forwards the following `generate` arguments: `custom_generate` and `trust_remote_code`. This is done to enable naive pre/post processing extensions to the original `generate`, i.e. a custom generate doing: ```py def generate(model, **kwargs): # some preprocessing return model.generate(**kwargs) ``` (previously, this resulted in an infinite loop)
{ "login": "gante", "id": 12240844, "node_id": "MDQ6VXNlcjEyMjQwODQ0", "avatar_url": "https://avatars.githubusercontent.com/u/12240844?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gante", "html_url": "https://github.com/gante", "followers_url": "https://api.github.com/users/gante/followers", "following_url": "https://api.github.com/users/gante/following{/other_user}", "gists_url": "https://api.github.com/users/gante/gists{/gist_id}", "starred_url": "https://api.github.com/users/gante/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gante/subscriptions", "organizations_url": "https://api.github.com/users/gante/orgs", "repos_url": "https://api.github.com/users/gante/repos", "events_url": "https://api.github.com/users/gante/events{/privacy}", "received_events_url": "https://api.github.com/users/gante/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38304/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38304/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38303
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38303/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38303/comments
https://api.github.com/repos/huggingface/transformers/issues/38303/events
https://github.com/huggingface/transformers/pull/38303
3,083,841,523
PR_kwDOCUB6oc6XQPmd
38,303
Oups typo for HybridChunkedCache
{ "login": "Cyrilvallez", "id": 71554963, "node_id": "MDQ6VXNlcjcxNTU0OTYz", "avatar_url": "https://avatars.githubusercontent.com/u/71554963?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Cyrilvallez", "html_url": "https://github.com/Cyrilvallez", "followers_url": "https://api.github.com/users/Cyrilvallez/followers", "following_url": "https://api.github.com/users/Cyrilvallez/following{/other_user}", "gists_url": "https://api.github.com/users/Cyrilvallez/gists{/gist_id}", "starred_url": "https://api.github.com/users/Cyrilvallez/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Cyrilvallez/subscriptions", "organizations_url": "https://api.github.com/users/Cyrilvallez/orgs", "repos_url": "https://api.github.com/users/Cyrilvallez/repos", "events_url": "https://api.github.com/users/Cyrilvallez/events{/privacy}", "received_events_url": "https://api.github.com/users/Cyrilvallez/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-22T15:52:09
2025-05-22T16:05:29
2025-05-22T15:52:37
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38303", "html_url": "https://github.com/huggingface/transformers/pull/38303", "diff_url": "https://github.com/huggingface/transformers/pull/38303.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38303.patch", "merged_at": "2025-05-22T15:52:37" }
# What does this PR do? <!-- Congratulations! You've made it this far! You're not quite done yet though. Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution. Then, please replace this with a description of the change and which issue is fixed (if applicable). Please also include relevant motivation and context. List any dependencies (if any) that are required for this change. Once you're done, someone will review your PR shortly (see the section "Who can review?" below to tag some potential reviewers). They may suggest changes to make the code even better. If no one reviewed your PR after a week has passed, don't hesitate to post a new comment @-mentioning the same persons---sometimes notifications get lost. --> <!-- Remove if not applicable --> Fixes # (issue) ## Before submitting - [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [ ] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request), Pull Request section? - [ ] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case. - [ ] Did you make sure to update the documentation with your changes? Here are the [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation). - [ ] Did you write any new necessary tests? ## Who can review? Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR. <!-- Your PR will be replied to more quickly if you can figure out the right person to tag with @ If you know how to use git blame, that is the easiest way, otherwise, here is a rough guide of **who to tag**. Please tag fewer than 3 people. Models: - text models: @ArthurZucker - vision models: @amyeroberts, @qubvel - speech models: @eustlb - graph models: @clefourrier Library: - flax: @gante and @Rocketknight1 - generate: @zucchini-nlp (visual-language models) or @gante (all others) - pipelines: @Rocketknight1 - tensorflow: @gante and @Rocketknight1 - tokenizers: @ArthurZucker - trainer: @zach-huggingface and @SunMarc - chat templates: @Rocketknight1 Integrations: - deepspeed: HF Trainer/Accelerate: @SunMarc @zach-huggingface - ray/raytune: @richardliaw, @amogkam - Big Model Inference: @SunMarc - quantization (bitsandbytes, autogpt): @SunMarc @MekkCyber Documentation: @stevhliu HF projects: - accelerate: [different repo](https://github.com/huggingface/accelerate) - datasets: [different repo](https://github.com/huggingface/datasets) - diffusers: [different repo](https://github.com/huggingface/diffusers) - rust tokenizers: [different repo](https://github.com/huggingface/tokenizers) Maintained examples (not research project or legacy): - Flax: @Rocketknight1 - PyTorch: See Models above and tag the person corresponding to the modality of the example. - TensorFlow: @Rocketknight1 -->
{ "login": "Cyrilvallez", "id": 71554963, "node_id": "MDQ6VXNlcjcxNTU0OTYz", "avatar_url": "https://avatars.githubusercontent.com/u/71554963?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Cyrilvallez", "html_url": "https://github.com/Cyrilvallez", "followers_url": "https://api.github.com/users/Cyrilvallez/followers", "following_url": "https://api.github.com/users/Cyrilvallez/following{/other_user}", "gists_url": "https://api.github.com/users/Cyrilvallez/gists{/gist_id}", "starred_url": "https://api.github.com/users/Cyrilvallez/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Cyrilvallez/subscriptions", "organizations_url": "https://api.github.com/users/Cyrilvallez/orgs", "repos_url": "https://api.github.com/users/Cyrilvallez/repos", "events_url": "https://api.github.com/users/Cyrilvallez/events{/privacy}", "received_events_url": "https://api.github.com/users/Cyrilvallez/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38303/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38303/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38302
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38302/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38302/comments
https://api.github.com/repos/huggingface/transformers/issues/38302/events
https://github.com/huggingface/transformers/pull/38302
3,083,841,092
PR_kwDOCUB6oc6XQPf_
38,302
Updated the model card for ViTMAE
{ "login": "mreraser", "id": 33192762, "node_id": "MDQ6VXNlcjMzMTkyNzYy", "avatar_url": "https://avatars.githubusercontent.com/u/33192762?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mreraser", "html_url": "https://github.com/mreraser", "followers_url": "https://api.github.com/users/mreraser/followers", "following_url": "https://api.github.com/users/mreraser/following{/other_user}", "gists_url": "https://api.github.com/users/mreraser/gists{/gist_id}", "starred_url": "https://api.github.com/users/mreraser/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mreraser/subscriptions", "organizations_url": "https://api.github.com/users/mreraser/orgs", "repos_url": "https://api.github.com/users/mreraser/repos", "events_url": "https://api.github.com/users/mreraser/events{/privacy}", "received_events_url": "https://api.github.com/users/mreraser/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-22T15:52:06
2025-05-28T16:19:43
2025-05-28T16:19:43
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38302", "html_url": "https://github.com/huggingface/transformers/pull/38302", "diff_url": "https://github.com/huggingface/transformers/pull/38302.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38302.patch", "merged_at": "2025-05-28T16:19:43" }
# What does this PR do? As suggested in this issue - https://github.com/huggingface/transformers/issues/36979#issue-2947704577 - this PR updates the documentation of the [ViTMAE](https://huggingface.co/docs/transformers/v4.52.1/en/model_doc/vit_mae) model, which will now be aligned with the standardized format for all the docs. ## Check list - [x] Include a brief description of the model - [x] Ready to use code examples (`Pipeline` **not** available, `AutoModel` available, and `transformers-cli` **not** available) - [ ] For large models, provide a quantization example - [ ] Include an attention mask visualizer ## Who can review? Hello @stevhliu! 👋 I updated the ViTMAE model card following the standard format. Since `ViTMAEForPreTraining` isn’t compatible with `Pipeline`, because it is designed for masked autoencoding rather than classification tasks. I’ve tried to follow all formatting and content guidelines, but I'm not sure if I did it correctly. Happy to revise. Thanks!
{ "login": "stevhliu", "id": 59462357, "node_id": "MDQ6VXNlcjU5NDYyMzU3", "avatar_url": "https://avatars.githubusercontent.com/u/59462357?v=4", "gravatar_id": "", "url": "https://api.github.com/users/stevhliu", "html_url": "https://github.com/stevhliu", "followers_url": "https://api.github.com/users/stevhliu/followers", "following_url": "https://api.github.com/users/stevhliu/following{/other_user}", "gists_url": "https://api.github.com/users/stevhliu/gists{/gist_id}", "starred_url": "https://api.github.com/users/stevhliu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/stevhliu/subscriptions", "organizations_url": "https://api.github.com/users/stevhliu/orgs", "repos_url": "https://api.github.com/users/stevhliu/repos", "events_url": "https://api.github.com/users/stevhliu/events{/privacy}", "received_events_url": "https://api.github.com/users/stevhliu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38302/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38302/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38301
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38301/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38301/comments
https://api.github.com/repos/huggingface/transformers/issues/38301/events
https://github.com/huggingface/transformers/pull/38301
3,083,820,557
PR_kwDOCUB6oc6XQLCv
38,301
🔴[`Attention`] Bert-based Models Attention Refactor
{ "login": "vasqu", "id": 73884904, "node_id": "MDQ6VXNlcjczODg0OTA0", "avatar_url": "https://avatars.githubusercontent.com/u/73884904?v=4", "gravatar_id": "", "url": "https://api.github.com/users/vasqu", "html_url": "https://github.com/vasqu", "followers_url": "https://api.github.com/users/vasqu/followers", "following_url": "https://api.github.com/users/vasqu/following{/other_user}", "gists_url": "https://api.github.com/users/vasqu/gists{/gist_id}", "starred_url": "https://api.github.com/users/vasqu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/vasqu/subscriptions", "organizations_url": "https://api.github.com/users/vasqu/orgs", "repos_url": "https://api.github.com/users/vasqu/repos", "events_url": "https://api.github.com/users/vasqu/events{/privacy}", "received_events_url": "https://api.github.com/users/vasqu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-22T15:45:00
2025-10-17T13:40:19
2025-09-19T09:23:58
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38301", "html_url": "https://github.com/huggingface/transformers/pull/38301", "diff_url": "https://github.com/huggingface/transformers/pull/38301.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38301.patch", "merged_at": "2025-09-19T09:23:58" }
Keeping track of the models that are done: - [x] Bert - [x] Roberta - [x] Albert - [x] Data2VecText - [x] Xmod - [x] Electra - [x] XLM Roberta - [x] Roberta Prelayernorm - [x] Ernie - [x] Camembert - [x] Bert Generation - [x] XLM Robert XL - [x] RoCBert - [x] Mobile Bert Up to discussion: - Flash attention is flaky; I suspect the norm layers to be responsible (encountered similar things with gemma3) Would need another round; questionable if worth it (ordered by prio): - [ ] Tapas - [ ] Vision x Text models, e.g. - [ ] Bridgetower (text would be good to go, would need image counterpart) - [ ] Altclip - [ ] ... - [ ] RemBert - [ ] Megatron Bert
{ "login": "ArthurZucker", "id": 48595927, "node_id": "MDQ6VXNlcjQ4NTk1OTI3", "avatar_url": "https://avatars.githubusercontent.com/u/48595927?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ArthurZucker", "html_url": "https://github.com/ArthurZucker", "followers_url": "https://api.github.com/users/ArthurZucker/followers", "following_url": "https://api.github.com/users/ArthurZucker/following{/other_user}", "gists_url": "https://api.github.com/users/ArthurZucker/gists{/gist_id}", "starred_url": "https://api.github.com/users/ArthurZucker/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ArthurZucker/subscriptions", "organizations_url": "https://api.github.com/users/ArthurZucker/orgs", "repos_url": "https://api.github.com/users/ArthurZucker/repos", "events_url": "https://api.github.com/users/ArthurZucker/events{/privacy}", "received_events_url": "https://api.github.com/users/ArthurZucker/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38301/reactions", "total_count": 5, "+1": 2, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 3, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38301/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38300
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38300/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38300/comments
https://api.github.com/repos/huggingface/transformers/issues/38300/events
https://github.com/huggingface/transformers/issues/38300
3,083,768,561
I_kwDOCUB6oc63zpLx
38,300
Will Gemma 3n be added to transformers?
{ "login": "TheMrCodes", "id": 28106561, "node_id": "MDQ6VXNlcjI4MTA2NTYx", "avatar_url": "https://avatars.githubusercontent.com/u/28106561?v=4", "gravatar_id": "", "url": "https://api.github.com/users/TheMrCodes", "html_url": "https://github.com/TheMrCodes", "followers_url": "https://api.github.com/users/TheMrCodes/followers", "following_url": "https://api.github.com/users/TheMrCodes/following{/other_user}", "gists_url": "https://api.github.com/users/TheMrCodes/gists{/gist_id}", "starred_url": "https://api.github.com/users/TheMrCodes/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/TheMrCodes/subscriptions", "organizations_url": "https://api.github.com/users/TheMrCodes/orgs", "repos_url": "https://api.github.com/users/TheMrCodes/repos", "events_url": "https://api.github.com/users/TheMrCodes/events{/privacy}", "received_events_url": "https://api.github.com/users/TheMrCodes/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1843244711, "node_id": "MDU6TGFiZWwxODQzMjQ0NzEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/New%20model", "name": "New model", "color": "fbca04", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2025-05-22T15:26:20
2025-06-30T07:07:53
2025-06-30T07:07:53
NONE
null
null
null
null
### Model description Question: Are there plans from Google or Huggingface to implement Gemma 3n in other frameworks? I've seen the LiteRT weights and Android App Link on Huggingface, and was wandering if it would be possible to convert the model architecture in the *.task file to a transformer pytorch Module? Personally I'll really interested in the Per-Layer Embeddings and MatFormer implementation they used, but do not have any experience with Tensorflow Lite ### Open source status - [ ] The model implementation is available - [X] The model weights are available ### Provide useful links for the implementation https://huggingface.co/google/gemma-3n-E4B-it-litert-preview
{ "login": "zucchini-nlp", "id": 100715397, "node_id": "U_kgDOBgDLhQ", "avatar_url": "https://avatars.githubusercontent.com/u/100715397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zucchini-nlp", "html_url": "https://github.com/zucchini-nlp", "followers_url": "https://api.github.com/users/zucchini-nlp/followers", "following_url": "https://api.github.com/users/zucchini-nlp/following{/other_user}", "gists_url": "https://api.github.com/users/zucchini-nlp/gists{/gist_id}", "starred_url": "https://api.github.com/users/zucchini-nlp/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zucchini-nlp/subscriptions", "organizations_url": "https://api.github.com/users/zucchini-nlp/orgs", "repos_url": "https://api.github.com/users/zucchini-nlp/repos", "events_url": "https://api.github.com/users/zucchini-nlp/events{/privacy}", "received_events_url": "https://api.github.com/users/zucchini-nlp/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38300/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38300/timeline
null
completed
{ "total": 0, "completed": 0, "percent_completed": 0 }
{ "blocked_by": 0, "total_blocked_by": 0, "blocking": 0, "total_blocking": 0 }
false
true
https://api.github.com/repos/huggingface/transformers/issues/38299
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38299/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38299/comments
https://api.github.com/repos/huggingface/transformers/issues/38299/events
https://github.com/huggingface/transformers/pull/38299
3,083,721,793
PR_kwDOCUB6oc6XP1lI
38,299
Fix HybridChunedCache & Llama4
{ "login": "Cyrilvallez", "id": 71554963, "node_id": "MDQ6VXNlcjcxNTU0OTYz", "avatar_url": "https://avatars.githubusercontent.com/u/71554963?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Cyrilvallez", "html_url": "https://github.com/Cyrilvallez", "followers_url": "https://api.github.com/users/Cyrilvallez/followers", "following_url": "https://api.github.com/users/Cyrilvallez/following{/other_user}", "gists_url": "https://api.github.com/users/Cyrilvallez/gists{/gist_id}", "starred_url": "https://api.github.com/users/Cyrilvallez/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Cyrilvallez/subscriptions", "organizations_url": "https://api.github.com/users/Cyrilvallez/orgs", "repos_url": "https://api.github.com/users/Cyrilvallez/repos", "events_url": "https://api.github.com/users/Cyrilvallez/events{/privacy}", "received_events_url": "https://api.github.com/users/Cyrilvallez/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-22T15:12:04
2025-05-22T15:30:04
2025-05-22T15:25:51
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38299", "html_url": "https://github.com/huggingface/transformers/pull/38299", "diff_url": "https://github.com/huggingface/transformers/pull/38299.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38299.patch", "merged_at": "2025-05-22T15:25:51" }
# What does this PR do? As per the title! It aligns HybridChunkedCache on what was done in https://github.com/huggingface/transformers/pull/37972 (i.e. simply take the min between max_len and window), which was causing lengths mismatches with llama4 in `get_mask_sizes` with the default HybridChunkedCache!
{ "login": "Cyrilvallez", "id": 71554963, "node_id": "MDQ6VXNlcjcxNTU0OTYz", "avatar_url": "https://avatars.githubusercontent.com/u/71554963?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Cyrilvallez", "html_url": "https://github.com/Cyrilvallez", "followers_url": "https://api.github.com/users/Cyrilvallez/followers", "following_url": "https://api.github.com/users/Cyrilvallez/following{/other_user}", "gists_url": "https://api.github.com/users/Cyrilvallez/gists{/gist_id}", "starred_url": "https://api.github.com/users/Cyrilvallez/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Cyrilvallez/subscriptions", "organizations_url": "https://api.github.com/users/Cyrilvallez/orgs", "repos_url": "https://api.github.com/users/Cyrilvallez/repos", "events_url": "https://api.github.com/users/Cyrilvallez/events{/privacy}", "received_events_url": "https://api.github.com/users/Cyrilvallez/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38299/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38299/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38298
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38298/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38298/comments
https://api.github.com/repos/huggingface/transformers/issues/38298/events
https://github.com/huggingface/transformers/pull/38298
3,083,674,985
PR_kwDOCUB6oc6XPrX8
38,298
new failure CI reports
{ "login": "ydshieh", "id": 2521628, "node_id": "MDQ6VXNlcjI1MjE2Mjg=", "avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ydshieh", "html_url": "https://github.com/ydshieh", "followers_url": "https://api.github.com/users/ydshieh/followers", "following_url": "https://api.github.com/users/ydshieh/following{/other_user}", "gists_url": "https://api.github.com/users/ydshieh/gists{/gist_id}", "starred_url": "https://api.github.com/users/ydshieh/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ydshieh/subscriptions", "organizations_url": "https://api.github.com/users/ydshieh/orgs", "repos_url": "https://api.github.com/users/ydshieh/repos", "events_url": "https://api.github.com/users/ydshieh/events{/privacy}", "received_events_url": "https://api.github.com/users/ydshieh/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-22T14:56:52
2025-05-24T17:15:04
2025-05-24T17:15:02
COLLABORATOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38298", "html_url": "https://github.com/huggingface/transformers/pull/38298", "diff_url": "https://github.com/huggingface/transformers/pull/38298.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38298.patch", "merged_at": "2025-05-24T17:15:02" }
# What does this PR do? Create and upload new test failure reports for all CI jobs
{ "login": "ydshieh", "id": 2521628, "node_id": "MDQ6VXNlcjI1MjE2Mjg=", "avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ydshieh", "html_url": "https://github.com/ydshieh", "followers_url": "https://api.github.com/users/ydshieh/followers", "following_url": "https://api.github.com/users/ydshieh/following{/other_user}", "gists_url": "https://api.github.com/users/ydshieh/gists{/gist_id}", "starred_url": "https://api.github.com/users/ydshieh/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ydshieh/subscriptions", "organizations_url": "https://api.github.com/users/ydshieh/orgs", "repos_url": "https://api.github.com/users/ydshieh/repos", "events_url": "https://api.github.com/users/ydshieh/events{/privacy}", "received_events_url": "https://api.github.com/users/ydshieh/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38298/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38298/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38297
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38297/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38297/comments
https://api.github.com/repos/huggingface/transformers/issues/38297/events
https://github.com/huggingface/transformers/pull/38297
3,083,615,485
PR_kwDOCUB6oc6XPejs
38,297
[emu3] fix conversion script
{ "login": "zucchini-nlp", "id": 100715397, "node_id": "U_kgDOBgDLhQ", "avatar_url": "https://avatars.githubusercontent.com/u/100715397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zucchini-nlp", "html_url": "https://github.com/zucchini-nlp", "followers_url": "https://api.github.com/users/zucchini-nlp/followers", "following_url": "https://api.github.com/users/zucchini-nlp/following{/other_user}", "gists_url": "https://api.github.com/users/zucchini-nlp/gists{/gist_id}", "starred_url": "https://api.github.com/users/zucchini-nlp/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zucchini-nlp/subscriptions", "organizations_url": "https://api.github.com/users/zucchini-nlp/orgs", "repos_url": "https://api.github.com/users/zucchini-nlp/repos", "events_url": "https://api.github.com/users/zucchini-nlp/events{/privacy}", "received_events_url": "https://api.github.com/users/zucchini-nlp/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
{ "login": "ArthurZucker", "id": 48595927, "node_id": "MDQ6VXNlcjQ4NTk1OTI3", "avatar_url": "https://avatars.githubusercontent.com/u/48595927?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ArthurZucker", "html_url": "https://github.com/ArthurZucker", "followers_url": "https://api.github.com/users/ArthurZucker/followers", "following_url": "https://api.github.com/users/ArthurZucker/following{/other_user}", "gists_url": "https://api.github.com/users/ArthurZucker/gists{/gist_id}", "starred_url": "https://api.github.com/users/ArthurZucker/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ArthurZucker/subscriptions", "organizations_url": "https://api.github.com/users/ArthurZucker/orgs", "repos_url": "https://api.github.com/users/ArthurZucker/repos", "events_url": "https://api.github.com/users/ArthurZucker/events{/privacy}", "received_events_url": "https://api.github.com/users/ArthurZucker/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "ArthurZucker", "id": 48595927, "node_id": "MDQ6VXNlcjQ4NTk1OTI3", "avatar_url": "https://avatars.githubusercontent.com/u/48595927?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ArthurZucker", "html_url": "https://github.com/ArthurZucker", "followers_url": "https://api.github.com/users/ArthurZucker/followers", "following_url": "https://api.github.com/users/ArthurZucker/following{/other_user}", "gists_url": "https://api.github.com/users/ArthurZucker/gists{/gist_id}", "starred_url": "https://api.github.com/users/ArthurZucker/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ArthurZucker/subscriptions", "organizations_url": "https://api.github.com/users/ArthurZucker/orgs", "repos_url": "https://api.github.com/users/ArthurZucker/repos", "events_url": "https://api.github.com/users/ArthurZucker/events{/privacy}", "received_events_url": "https://api.github.com/users/ArthurZucker/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[]
2025-05-22T14:37:48
2025-05-26T01:51:12
2025-05-23T07:49:56
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38297", "html_url": "https://github.com/huggingface/transformers/pull/38297", "diff_url": "https://github.com/huggingface/transformers/pull/38297.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38297.patch", "merged_at": "2025-05-23T07:49:56" }
# What does this PR do? Fixes https://github.com/huggingface/transformers/issues/38121 and updates the weights on the hub. Note, hub PR is not yet merged
{ "login": "zucchini-nlp", "id": 100715397, "node_id": "U_kgDOBgDLhQ", "avatar_url": "https://avatars.githubusercontent.com/u/100715397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zucchini-nlp", "html_url": "https://github.com/zucchini-nlp", "followers_url": "https://api.github.com/users/zucchini-nlp/followers", "following_url": "https://api.github.com/users/zucchini-nlp/following{/other_user}", "gists_url": "https://api.github.com/users/zucchini-nlp/gists{/gist_id}", "starred_url": "https://api.github.com/users/zucchini-nlp/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zucchini-nlp/subscriptions", "organizations_url": "https://api.github.com/users/zucchini-nlp/orgs", "repos_url": "https://api.github.com/users/zucchini-nlp/repos", "events_url": "https://api.github.com/users/zucchini-nlp/events{/privacy}", "received_events_url": "https://api.github.com/users/zucchini-nlp/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38297/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38297/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38296
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38296/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38296/comments
https://api.github.com/repos/huggingface/transformers/issues/38296/events
https://github.com/huggingface/transformers/pull/38296
3,083,603,421
PR_kwDOCUB6oc6XPb7E
38,296
Fix `from_args_and_dict` ProcessorMixin
{ "login": "yonigozlan", "id": 74535834, "node_id": "MDQ6VXNlcjc0NTM1ODM0", "avatar_url": "https://avatars.githubusercontent.com/u/74535834?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yonigozlan", "html_url": "https://github.com/yonigozlan", "followers_url": "https://api.github.com/users/yonigozlan/followers", "following_url": "https://api.github.com/users/yonigozlan/following{/other_user}", "gists_url": "https://api.github.com/users/yonigozlan/gists{/gist_id}", "starred_url": "https://api.github.com/users/yonigozlan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yonigozlan/subscriptions", "organizations_url": "https://api.github.com/users/yonigozlan/orgs", "repos_url": "https://api.github.com/users/yonigozlan/repos", "events_url": "https://api.github.com/users/yonigozlan/events{/privacy}", "received_events_url": "https://api.github.com/users/yonigozlan/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-22T14:33:40
2025-05-28T15:46:34
2025-05-28T15:46:33
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38296", "html_url": "https://github.com/huggingface/transformers/pull/38296", "diff_url": "https://github.com/huggingface/transformers/pull/38296.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38296.patch", "merged_at": "2025-05-28T15:46:33" }
# What does this PR do? Fix issue where kwargs given to `from_pretrained` for processors would not be taken into account in the processor's `__init__` directly, but would override the processor's attributes after the fact, resulting in unexpected behaviors. This might be slightly breaking, as before the kwargs, and even the processor_dict items would be used even if not valid, but I guess this shouldn't be the case :)
{ "login": "yonigozlan", "id": 74535834, "node_id": "MDQ6VXNlcjc0NTM1ODM0", "avatar_url": "https://avatars.githubusercontent.com/u/74535834?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yonigozlan", "html_url": "https://github.com/yonigozlan", "followers_url": "https://api.github.com/users/yonigozlan/followers", "following_url": "https://api.github.com/users/yonigozlan/following{/other_user}", "gists_url": "https://api.github.com/users/yonigozlan/gists{/gist_id}", "starred_url": "https://api.github.com/users/yonigozlan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yonigozlan/subscriptions", "organizations_url": "https://api.github.com/users/yonigozlan/orgs", "repos_url": "https://api.github.com/users/yonigozlan/repos", "events_url": "https://api.github.com/users/yonigozlan/events{/privacy}", "received_events_url": "https://api.github.com/users/yonigozlan/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38296/reactions", "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 1, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38296/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38295
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38295/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38295/comments
https://api.github.com/repos/huggingface/transformers/issues/38295/events
https://github.com/huggingface/transformers/pull/38295
3,083,268,056
PR_kwDOCUB6oc6XOSWm
38,295
Fix image token mask in Gemma3
{ "login": "Cyrilvallez", "id": 71554963, "node_id": "MDQ6VXNlcjcxNTU0OTYz", "avatar_url": "https://avatars.githubusercontent.com/u/71554963?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Cyrilvallez", "html_url": "https://github.com/Cyrilvallez", "followers_url": "https://api.github.com/users/Cyrilvallez/followers", "following_url": "https://api.github.com/users/Cyrilvallez/following{/other_user}", "gists_url": "https://api.github.com/users/Cyrilvallez/gists{/gist_id}", "starred_url": "https://api.github.com/users/Cyrilvallez/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Cyrilvallez/subscriptions", "organizations_url": "https://api.github.com/users/Cyrilvallez/orgs", "repos_url": "https://api.github.com/users/Cyrilvallez/repos", "events_url": "https://api.github.com/users/Cyrilvallez/events{/privacy}", "received_events_url": "https://api.github.com/users/Cyrilvallez/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-22T12:48:06
2025-05-27T09:15:53
2025-05-27T09:15:52
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38295", "html_url": "https://github.com/huggingface/transformers/pull/38295", "diff_url": "https://github.com/huggingface/transformers/pull/38295.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38295.patch", "merged_at": "2025-05-27T09:15:52" }
# What does this PR do? As per the title. It got fixed in https://github.com/huggingface/transformers/pull/38080 in the middle of https://github.com/huggingface/transformers/pull/37866/. This PR corrects the additional mask. See images for correctness for both sliding and full cases. Before https://github.com/huggingface/transformers/pull/37866 however, the masks were first created with full attention, then were truncated with sliding window in the DecoderLayer, so I'm pretty sure the added positions to the mask were removed in the sliding layers (i.e. even with https://github.com/huggingface/transformers/pull/38080 it was not correct)-> kind of similar issue as with the Qwens. This not the case anymore, and everything is correctly generated and passed along 🤗 Of course both squares corresponds to 2 images of 5 image tokens. ![Screenshot 2025-05-22 at 14 39 02](https://github.com/user-attachments/assets/51caaebb-6018-44b8-95cc-efec82cac96e) ![Screenshot 2025-05-22 at 14 35 07](https://github.com/user-attachments/assets/fa4fdd51-3c41-4fc9-8520-aa37bc772c74)
{ "login": "Cyrilvallez", "id": 71554963, "node_id": "MDQ6VXNlcjcxNTU0OTYz", "avatar_url": "https://avatars.githubusercontent.com/u/71554963?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Cyrilvallez", "html_url": "https://github.com/Cyrilvallez", "followers_url": "https://api.github.com/users/Cyrilvallez/followers", "following_url": "https://api.github.com/users/Cyrilvallez/following{/other_user}", "gists_url": "https://api.github.com/users/Cyrilvallez/gists{/gist_id}", "starred_url": "https://api.github.com/users/Cyrilvallez/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Cyrilvallez/subscriptions", "organizations_url": "https://api.github.com/users/Cyrilvallez/orgs", "repos_url": "https://api.github.com/users/Cyrilvallez/repos", "events_url": "https://api.github.com/users/Cyrilvallez/events{/privacy}", "received_events_url": "https://api.github.com/users/Cyrilvallez/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38295/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38295/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38294
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38294/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38294/comments
https://api.github.com/repos/huggingface/transformers/issues/38294/events
https://github.com/huggingface/transformers/pull/38294
3,082,789,026
PR_kwDOCUB6oc6XMpVR
38,294
Fix tp error when torch distributed is already initialized
{ "login": "SunMarc", "id": 57196510, "node_id": "MDQ6VXNlcjU3MTk2NTEw", "avatar_url": "https://avatars.githubusercontent.com/u/57196510?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SunMarc", "html_url": "https://github.com/SunMarc", "followers_url": "https://api.github.com/users/SunMarc/followers", "following_url": "https://api.github.com/users/SunMarc/following{/other_user}", "gists_url": "https://api.github.com/users/SunMarc/gists{/gist_id}", "starred_url": "https://api.github.com/users/SunMarc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SunMarc/subscriptions", "organizations_url": "https://api.github.com/users/SunMarc/orgs", "repos_url": "https://api.github.com/users/SunMarc/repos", "events_url": "https://api.github.com/users/SunMarc/events{/privacy}", "received_events_url": "https://api.github.com/users/SunMarc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 8103865784, "node_id": "LA_kwDOCUB6oc8AAAAB4wctuA", "url": "https://api.github.com/repos/huggingface/transformers/labels/for%20patch", "name": "for patch", "color": "D93F0B", "default": false, "description": "Tag issues / labels that should be included in the next patch" } ]
closed
false
null
[]
null
[]
2025-05-22T09:59:20
2025-05-22T10:34:07
2025-05-22T10:34:06
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38294", "html_url": "https://github.com/huggingface/transformers/pull/38294", "diff_url": "https://github.com/huggingface/transformers/pull/38294.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38294.patch", "merged_at": "2025-05-22T10:34:06" }
# What does this PR do? This PR fixes an issue when the torch distributed is already initialized. current_device is referenced before assignment. Getting the following traceback in accelerate when testing tp training. ``` [rank1]: tp_plan, device_map, device_mesh = initialize_tensor_parallelism(tp_plan, tp_size=None) [rank1]: File "/home/marc/transformers/src/transformers/integrations/tensor_parallel.py", line 79, in initialize_tensor_parallelism [rank1]: index = current_device.current_device() if device_type != "cpu" else None [rank1]: UnboundLocalError: local variable 'current_device' referenced before assignment ```
{ "login": "SunMarc", "id": 57196510, "node_id": "MDQ6VXNlcjU3MTk2NTEw", "avatar_url": "https://avatars.githubusercontent.com/u/57196510?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SunMarc", "html_url": "https://github.com/SunMarc", "followers_url": "https://api.github.com/users/SunMarc/followers", "following_url": "https://api.github.com/users/SunMarc/following{/other_user}", "gists_url": "https://api.github.com/users/SunMarc/gists{/gist_id}", "starred_url": "https://api.github.com/users/SunMarc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SunMarc/subscriptions", "organizations_url": "https://api.github.com/users/SunMarc/orgs", "repos_url": "https://api.github.com/users/SunMarc/repos", "events_url": "https://api.github.com/users/SunMarc/events{/privacy}", "received_events_url": "https://api.github.com/users/SunMarc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38294/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38294/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38293
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38293/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38293/comments
https://api.github.com/repos/huggingface/transformers/issues/38293/events
https://github.com/huggingface/transformers/issues/38293
3,082,785,408
I_kwDOCUB6oc63v5KA
38,293
Gemma3 attn_implementation ignored
{ "login": "okaris", "id": 1448702, "node_id": "MDQ6VXNlcjE0NDg3MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/1448702?v=4", "gravatar_id": "", "url": "https://api.github.com/users/okaris", "html_url": "https://github.com/okaris", "followers_url": "https://api.github.com/users/okaris/followers", "following_url": "https://api.github.com/users/okaris/following{/other_user}", "gists_url": "https://api.github.com/users/okaris/gists{/gist_id}", "starred_url": "https://api.github.com/users/okaris/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/okaris/subscriptions", "organizations_url": "https://api.github.com/users/okaris/orgs", "repos_url": "https://api.github.com/users/okaris/repos", "events_url": "https://api.github.com/users/okaris/events{/privacy}", "received_events_url": "https://api.github.com/users/okaris/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 3817266200, "node_id": "MDU6TGFiZWwzODE3MjY2MjAw", "url": "https://api.github.com/repos/huggingface/transformers/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": null } ]
closed
false
null
[]
null
[]
2025-05-22T09:58:02
2025-05-22T17:52:39
2025-05-22T11:12:24
NONE
null
null
null
null
### System Info 4.52.2 ``` inference.sh: failed to run task: Unexpected type in sourceless builder transformers.models.gemma3.configuration_gemma3.Gemma3TextConfig from user code: File "/app/venv/3.12/lib/python3.12/site-packages/transformers/models/gemma3/modeling_gemma3.py", line 1345, in forward outputs = self.model( File "/app/venv/3.12/lib/python3.12/site-packages/transformers/utils/generic.py", line 969, in wrapper output = func(self, *args, **kwargs) File "/app/venv/3.12/lib/python3.12/site-packages/transformers/models/gemma3/modeling_gemma3.py", line 1205, in forward causal_mask = self._update_causal_mask( File "/app/venv/3.12/lib/python3.12/site-packages/transformers/models/gemma3/modeling_gemma3.py", line 1024, in _update_causal_mask if self.config.text_config._attn_implementation == "flash_attention_2": File "/app/venv/3.12/lib/python3.12/site-packages/transformers/configuration_utils.py", line 211, in __getattribute__ return super().__getattribute__(key) Set TORCHDYNAMO_VERBOSE=1 for the internal stack trace (please do this especially if you're reporting a bug to PyTorch). For even more developer context, set TORCH_LOGS="+dynamo" ``` Following the AutoModel implementation from https://huggingface.co/docs/transformers/en/model_doc/gemma3?usage=AutoModel Passing `attn_implementation` has no effect. ### Who can help? @ArthurZucker, @amyeroberts , @qubvel ### Information - [x] The official example scripts - [ ] My own modified scripts ### Tasks - [x] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...) - [ ] My own task or dataset (give details below) ### Reproduction https://huggingface.co/docs/transformers/en/model_doc/gemma3?usage=AutoModel ### Expected behavior Model doesn't give out an error
{ "login": "okaris", "id": 1448702, "node_id": "MDQ6VXNlcjE0NDg3MDI=", "avatar_url": "https://avatars.githubusercontent.com/u/1448702?v=4", "gravatar_id": "", "url": "https://api.github.com/users/okaris", "html_url": "https://github.com/okaris", "followers_url": "https://api.github.com/users/okaris/followers", "following_url": "https://api.github.com/users/okaris/following{/other_user}", "gists_url": "https://api.github.com/users/okaris/gists{/gist_id}", "starred_url": "https://api.github.com/users/okaris/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/okaris/subscriptions", "organizations_url": "https://api.github.com/users/okaris/orgs", "repos_url": "https://api.github.com/users/okaris/repos", "events_url": "https://api.github.com/users/okaris/events{/privacy}", "received_events_url": "https://api.github.com/users/okaris/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38293/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38293/timeline
null
completed
{ "total": 0, "completed": 0, "percent_completed": 0 }
{ "blocked_by": 0, "total_blocked_by": 0, "blocking": 0, "total_blocking": 0 }
false
true
https://api.github.com/repos/huggingface/transformers/issues/38292
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38292/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38292/comments
https://api.github.com/repos/huggingface/transformers/issues/38292/events
https://github.com/huggingface/transformers/pull/38292
3,082,763,943
PR_kwDOCUB6oc6XMj6w
38,292
add `liger-kernel` to docker file
{ "login": "ydshieh", "id": 2521628, "node_id": "MDQ6VXNlcjI1MjE2Mjg=", "avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ydshieh", "html_url": "https://github.com/ydshieh", "followers_url": "https://api.github.com/users/ydshieh/followers", "following_url": "https://api.github.com/users/ydshieh/following{/other_user}", "gists_url": "https://api.github.com/users/ydshieh/gists{/gist_id}", "starred_url": "https://api.github.com/users/ydshieh/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ydshieh/subscriptions", "organizations_url": "https://api.github.com/users/ydshieh/orgs", "repos_url": "https://api.github.com/users/ydshieh/repos", "events_url": "https://api.github.com/users/ydshieh/events{/privacy}", "received_events_url": "https://api.github.com/users/ydshieh/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-22T09:50:34
2025-05-22T10:03:34
2025-05-22T09:58:17
COLLABORATOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38292", "html_url": "https://github.com/huggingface/transformers/pull/38292", "diff_url": "https://github.com/huggingface/transformers/pull/38292.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38292.patch", "merged_at": "2025-05-22T09:58:17" }
# What does this PR do? As discussed offline
{ "login": "ydshieh", "id": 2521628, "node_id": "MDQ6VXNlcjI1MjE2Mjg=", "avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ydshieh", "html_url": "https://github.com/ydshieh", "followers_url": "https://api.github.com/users/ydshieh/followers", "following_url": "https://api.github.com/users/ydshieh/following{/other_user}", "gists_url": "https://api.github.com/users/ydshieh/gists{/gist_id}", "starred_url": "https://api.github.com/users/ydshieh/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ydshieh/subscriptions", "organizations_url": "https://api.github.com/users/ydshieh/orgs", "repos_url": "https://api.github.com/users/ydshieh/repos", "events_url": "https://api.github.com/users/ydshieh/events{/privacy}", "received_events_url": "https://api.github.com/users/ydshieh/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38292/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38292/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38291
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38291/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38291/comments
https://api.github.com/repos/huggingface/transformers/issues/38291/events
https://github.com/huggingface/transformers/issues/38291
3,082,684,438
I_kwDOCUB6oc63vggW
38,291
4.52.2 报错Could not import module 'Qwen3ForCausalLM'
{ "login": "liuwuwuwu", "id": 49775900, "node_id": "MDQ6VXNlcjQ5Nzc1OTAw", "avatar_url": "https://avatars.githubusercontent.com/u/49775900?v=4", "gravatar_id": "", "url": "https://api.github.com/users/liuwuwuwu", "html_url": "https://github.com/liuwuwuwu", "followers_url": "https://api.github.com/users/liuwuwuwu/followers", "following_url": "https://api.github.com/users/liuwuwuwu/following{/other_user}", "gists_url": "https://api.github.com/users/liuwuwuwu/gists{/gist_id}", "starred_url": "https://api.github.com/users/liuwuwuwu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/liuwuwuwu/subscriptions", "organizations_url": "https://api.github.com/users/liuwuwuwu/orgs", "repos_url": "https://api.github.com/users/liuwuwuwu/repos", "events_url": "https://api.github.com/users/liuwuwuwu/events{/privacy}", "received_events_url": "https://api.github.com/users/liuwuwuwu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 3817266200, "node_id": "MDU6TGFiZWwzODE3MjY2MjAw", "url": "https://api.github.com/repos/huggingface/transformers/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": null } ]
closed
false
null
[]
null
[]
2025-05-22T09:25:50
2025-08-31T00:25:36
2025-07-14T08:03:03
NONE
null
null
null
null
### System Info >>> import transformers >>> print(transformers.__version__) 4.52.2 ### Who can help? _No response_ ### Information - [ ] The official example scripts - [ ] My own modified scripts ### Tasks - [ ] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...) - [ ] My own task or dataset (give details below) ### Reproduction >>> import transformers >>> print(transformers.__version__) 4.52.2 >>> from transformers import Qwen3ForCausalLM raise ModuleNotFoundError( ModuleNotFoundError: Could not import module 'Qwen3ForCausalLM'. Are this object's requirements defined correctly? ### Expected behavior >>> import transformers >>> print(transformers.__version__) 4.52.2 >>> from transformers import Qwen3ForCausalLM raise ModuleNotFoundError( ModuleNotFoundError: Could not import module 'Qwen3ForCausalLM'. Are this object's requirements defined correctly?
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38291/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38291/timeline
null
completed
{ "total": 0, "completed": 0, "percent_completed": 0 }
{ "blocked_by": 0, "total_blocked_by": 0, "blocking": 0, "total_blocking": 0 }
false
true
https://api.github.com/repos/huggingface/transformers/issues/38290
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38290/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38290/comments
https://api.github.com/repos/huggingface/transformers/issues/38290/events
https://github.com/huggingface/transformers/pull/38290
3,082,607,047
PR_kwDOCUB6oc6XMB0B
38,290
[`OPT`] Fix attention scaling
{ "login": "vasqu", "id": 73884904, "node_id": "MDQ6VXNlcjczODg0OTA0", "avatar_url": "https://avatars.githubusercontent.com/u/73884904?v=4", "gravatar_id": "", "url": "https://api.github.com/users/vasqu", "html_url": "https://github.com/vasqu", "followers_url": "https://api.github.com/users/vasqu/followers", "following_url": "https://api.github.com/users/vasqu/following{/other_user}", "gists_url": "https://api.github.com/users/vasqu/gists{/gist_id}", "starred_url": "https://api.github.com/users/vasqu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/vasqu/subscriptions", "organizations_url": "https://api.github.com/users/vasqu/orgs", "repos_url": "https://api.github.com/users/vasqu/repos", "events_url": "https://api.github.com/users/vasqu/events{/privacy}", "received_events_url": "https://api.github.com/users/vasqu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 8103865784, "node_id": "LA_kwDOCUB6oc8AAAAB4wctuA", "url": "https://api.github.com/repos/huggingface/transformers/labels/for%20patch", "name": "for patch", "color": "D93F0B", "default": false, "description": "Tag issues / labels that should be included in the next patch" } ]
closed
false
null
[]
null
[]
2025-05-22T08:59:50
2025-05-28T08:39:05
2025-05-26T09:02:17
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38290", "html_url": "https://github.com/huggingface/transformers/pull/38290", "diff_url": "https://github.com/huggingface/transformers/pull/38290.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38290.patch", "merged_at": "2025-05-26T09:02:17" }
Scaling has been applied twice to OPT. This fixes it by passing `1.0` explicitly to avoid sdpa and co. to create a default scaling. Fixes #38277
{ "login": "vasqu", "id": 73884904, "node_id": "MDQ6VXNlcjczODg0OTA0", "avatar_url": "https://avatars.githubusercontent.com/u/73884904?v=4", "gravatar_id": "", "url": "https://api.github.com/users/vasqu", "html_url": "https://github.com/vasqu", "followers_url": "https://api.github.com/users/vasqu/followers", "following_url": "https://api.github.com/users/vasqu/following{/other_user}", "gists_url": "https://api.github.com/users/vasqu/gists{/gist_id}", "starred_url": "https://api.github.com/users/vasqu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/vasqu/subscriptions", "organizations_url": "https://api.github.com/users/vasqu/orgs", "repos_url": "https://api.github.com/users/vasqu/repos", "events_url": "https://api.github.com/users/vasqu/events{/privacy}", "received_events_url": "https://api.github.com/users/vasqu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38290/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38290/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38289
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38289/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38289/comments
https://api.github.com/repos/huggingface/transformers/issues/38289/events
https://github.com/huggingface/transformers/issues/38289
3,082,586,195
I_kwDOCUB6oc63vIhT
38,289
401 Unauthorized Error: "Invalid credentials" on POST requests to Inference API from multiple services
{ "login": "ekaterina2609", "id": 212860971, "node_id": "U_kgDODLAAKw", "avatar_url": "https://avatars.githubusercontent.com/u/212860971?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ekaterina2609", "html_url": "https://github.com/ekaterina2609", "followers_url": "https://api.github.com/users/ekaterina2609/followers", "following_url": "https://api.github.com/users/ekaterina2609/following{/other_user}", "gists_url": "https://api.github.com/users/ekaterina2609/gists{/gist_id}", "starred_url": "https://api.github.com/users/ekaterina2609/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ekaterina2609/subscriptions", "organizations_url": "https://api.github.com/users/ekaterina2609/orgs", "repos_url": "https://api.github.com/users/ekaterina2609/repos", "events_url": "https://api.github.com/users/ekaterina2609/events{/privacy}", "received_events_url": "https://api.github.com/users/ekaterina2609/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 3817266200, "node_id": "MDU6TGFiZWwzODE3MjY2MjAw", "url": "https://api.github.com/repos/huggingface/transformers/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": null } ]
closed
false
null
[]
null
[]
2025-05-22T08:52:20
2025-07-03T08:02:39
2025-07-03T08:02:39
NONE
null
null
null
null
### System Info I am encountering a persistent issue when trying to use the Inference API for the 'gpt2' model, consistently receiving an HTTP 401 Unauthorized error with the message: {"error": "Invalid credentials in Authorization header"}. I have been trying to set up an API connection from my Bubble application, but I'm replicating the exact same error when testing directly with Postman. Here are the details of my setup and the troubleshooting steps I have already taken: 1. API Endpoint: https://api-inference.huggingface.co/models/gpt2 (confirmed correct). 2. HTTP Method: POST. 3. Headers: o Authorization: Bearer YOUR_HF_TOKEN (I have verified the exact format, including the single space between Bearer and the token, multiple times to ensure no extra spaces or hidden characters). o Content-Type: application/json (confirmed set correctly). 4. Request Body Example (for testing): JSON { "inputs": "Hello, my name is" } 5. Token Status: o I have regenerated my API token 4 times (from https://huggingface.co/settings/tokens), trying different roles (read, write, custom), but the error persists with all of them. 6. Observed Behavior: o When sending OPTIONS requests to the endpoint via Postman, I receive a 200 OK response, indicating the server is reachable and CORS is configured. o However, all POST requests consistently return the 401 Unauthorized error with the specific message {"error": "Invalid credentials in Authorization header"}. o The exact same error occurs when attempting the connection from my Bubble application. o I have also attempted to use a different public model (e.g., distilbert-base-uncased) with the same token and received the same 401 error, suggesting the issue is not specific to the gpt2 model. Given the extensive troubleshooting on my end across different platforms, it appears the issue might be related to the token's validation on Hugging Face's server side for my account, or a specific configuration I am missing. Could you please investigate why my valid API token is being rejected with "Invalid credentials in Authorization header" for the Inference API? Thank you for your time and assistance @SunMarc ### Who can help? _No response_ ### Information - [ ] The official example scripts - [ ] My own modified scripts ### Tasks - [ ] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...) - [ ] My own task or dataset (give details below) ### Reproduction o When sending OPTIONS requests to the endpoint via Postman, I receive a 200 OK response, indicating the server is reachable and CORS is configured. o However, all POST requests consistently return the 401 Unauthorized error with the specific message {"error": "Invalid credentials in Authorization header"}. o The exact same error occurs when attempting the connection from my Bubble application. o I have also attempted to use a different public model (e.g., distilbert-base-uncased) with the same token and received the same 401 error, suggesting the issue is not specific to the gpt2 model. ### Expected behavior Here's the updated "Expected behavior" description, including the mention of Bubble: Expected behavior: When attempting to integrate with a Bubble application, the API call should be successfully authenticated using the provided Hugging Face API token. Subsequently, the gpt2 model should process the input, and the API should return a successful HTTP 200 OK response containing the generated text output.
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38289/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38289/timeline
null
completed
{ "total": 0, "completed": 0, "percent_completed": 0 }
{ "blocked_by": 0, "total_blocked_by": 0, "blocking": 0, "total_blocking": 0 }
false
true
https://api.github.com/repos/huggingface/transformers/issues/38288
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38288/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38288/comments
https://api.github.com/repos/huggingface/transformers/issues/38288/events
https://github.com/huggingface/transformers/pull/38288
3,082,526,625
PR_kwDOCUB6oc6XLwSF
38,288
🚨Early-error🚨 config will error out if `output_attentions=True` and the attn implementation is wrong
{ "login": "ArthurZucker", "id": 48595927, "node_id": "MDQ6VXNlcjQ4NTk1OTI3", "avatar_url": "https://avatars.githubusercontent.com/u/48595927?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ArthurZucker", "html_url": "https://github.com/ArthurZucker", "followers_url": "https://api.github.com/users/ArthurZucker/followers", "following_url": "https://api.github.com/users/ArthurZucker/following{/other_user}", "gists_url": "https://api.github.com/users/ArthurZucker/gists{/gist_id}", "starred_url": "https://api.github.com/users/ArthurZucker/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ArthurZucker/subscriptions", "organizations_url": "https://api.github.com/users/ArthurZucker/orgs", "repos_url": "https://api.github.com/users/ArthurZucker/repos", "events_url": "https://api.github.com/users/ArthurZucker/events{/privacy}", "received_events_url": "https://api.github.com/users/ArthurZucker/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-22T08:32:51
2025-05-23T15:17:40
2025-05-23T15:17:38
COLLABORATOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38288", "html_url": "https://github.com/huggingface/transformers/pull/38288", "diff_url": "https://github.com/huggingface/transformers/pull/38288.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38288.patch", "merged_at": "2025-05-23T15:17:38" }
# What does this PR do? this is aligned with our roadmap to reduce the bloating, this allows us to remove codepaths for warning: <img width="1116" alt="image" src="https://github.com/user-attachments/assets/cd1d9480-667a-48bd-941c-f57f54442799" /> Instead of having it in all of the forwards
{ "login": "ArthurZucker", "id": 48595927, "node_id": "MDQ6VXNlcjQ4NTk1OTI3", "avatar_url": "https://avatars.githubusercontent.com/u/48595927?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ArthurZucker", "html_url": "https://github.com/ArthurZucker", "followers_url": "https://api.github.com/users/ArthurZucker/followers", "following_url": "https://api.github.com/users/ArthurZucker/following{/other_user}", "gists_url": "https://api.github.com/users/ArthurZucker/gists{/gist_id}", "starred_url": "https://api.github.com/users/ArthurZucker/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ArthurZucker/subscriptions", "organizations_url": "https://api.github.com/users/ArthurZucker/orgs", "repos_url": "https://api.github.com/users/ArthurZucker/repos", "events_url": "https://api.github.com/users/ArthurZucker/events{/privacy}", "received_events_url": "https://api.github.com/users/ArthurZucker/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38288/reactions", "total_count": 4, "+1": 0, "-1": 0, "laugh": 0, "hooray": 1, "confused": 0, "heart": 1, "rocket": 2, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38288/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38287
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38287/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38287/comments
https://api.github.com/repos/huggingface/transformers/issues/38287/events
https://github.com/huggingface/transformers/pull/38287
3,082,511,813
PR_kwDOCUB6oc6XLtDR
38,287
Fix pytorch DTensor import issue.(version 2)
{ "login": "syog1ne", "id": 185162774, "node_id": "U_kgDOCwlcFg", "avatar_url": "https://avatars.githubusercontent.com/u/185162774?v=4", "gravatar_id": "", "url": "https://api.github.com/users/syog1ne", "html_url": "https://github.com/syog1ne", "followers_url": "https://api.github.com/users/syog1ne/followers", "following_url": "https://api.github.com/users/syog1ne/following{/other_user}", "gists_url": "https://api.github.com/users/syog1ne/gists{/gist_id}", "starred_url": "https://api.github.com/users/syog1ne/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/syog1ne/subscriptions", "organizations_url": "https://api.github.com/users/syog1ne/orgs", "repos_url": "https://api.github.com/users/syog1ne/repos", "events_url": "https://api.github.com/users/syog1ne/events{/privacy}", "received_events_url": "https://api.github.com/users/syog1ne/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-22T08:27:34
2025-06-02T02:23:01
2025-06-02T02:23:01
NONE
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38287", "html_url": "https://github.com/huggingface/transformers/pull/38287", "diff_url": "https://github.com/huggingface/transformers/pull/38287.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38287.patch", "merged_at": null }
# Resolve DTensor Import Path Inconsistency Across PyTorch Versions Summary: This pull request addresses an import issue for DTensor arising from its path change across different PyTorch versions. It implements a conditional import mechanism to ensure compatibility. Problem: The location of the DTensor module has been refactored within the PyTorch library: In PyTorch versions prior to 2.5, DTensor is accessible via torch.distributed._tensor.DTensor. In PyTorch versions 2.5 and newer, DTensor has been moved to torch.distributed.tensor.DTensor. This discrepancy can cause ImportError exceptions when code expecting one path is run with a different PyTorch version. Solution: Only when pytorch version is lagger or equal to 2.5, we will use (import) DTensor. Evidence of PyTorch Internal Change: The change in DTensor's import path is evident in PyTorch's own codebase. The following links point to the relevant lines in torch/_dynamo/variables/torch.py for different versions, illustrating the path modification: PyTorch 2.4.x (and earlier relevant versions): DTensor is referenced from torch.distributed._tensor. See: [[GitHub - pytorch/pytorch (branch dcfa77... for v2.4)](https://github.com/pytorch/pytorch/blob/dcfa7702c3ecd8754e8a66bc49142de00c8474ee/torch/_dynamo/variables/torch.py#L563)](https://github.com/pytorch/pytorch/blob/dcfa7702c3ecd8754e8a66bc49142de00c8474ee/torch/_dynamo/variables/torch.py#L563) PyTorch 2.5.x (and later relevant versions): DTensor is referenced from torch.distributed.tensor. See: [[GitHub - pytorch/pytorch (branch cfc227... for v2.5)](https://github.com/pytorch/pytorch/blob/cfc227ad43c8a39e52463ef06029dddc00919eae/torch/_dynamo/variables/torch.py#L631)](https://github.com/pytorch/pytorch/blob/cfc227ad43c8a39e52463ef06029dddc00919eae/torch/_dynamo/variables/torch.py#L631)
{ "login": "syog1ne", "id": 185162774, "node_id": "U_kgDOCwlcFg", "avatar_url": "https://avatars.githubusercontent.com/u/185162774?v=4", "gravatar_id": "", "url": "https://api.github.com/users/syog1ne", "html_url": "https://github.com/syog1ne", "followers_url": "https://api.github.com/users/syog1ne/followers", "following_url": "https://api.github.com/users/syog1ne/following{/other_user}", "gists_url": "https://api.github.com/users/syog1ne/gists{/gist_id}", "starred_url": "https://api.github.com/users/syog1ne/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/syog1ne/subscriptions", "organizations_url": "https://api.github.com/users/syog1ne/orgs", "repos_url": "https://api.github.com/users/syog1ne/repos", "events_url": "https://api.github.com/users/syog1ne/events{/privacy}", "received_events_url": "https://api.github.com/users/syog1ne/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38287/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38287/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38286
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38286/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38286/comments
https://api.github.com/repos/huggingface/transformers/issues/38286/events
https://github.com/huggingface/transformers/pull/38286
3,082,505,284
PR_kwDOCUB6oc6XLrnz
38,286
fix total batch size calculation in trainer
{ "login": "inkcherry", "id": 27563729, "node_id": "MDQ6VXNlcjI3NTYzNzI5", "avatar_url": "https://avatars.githubusercontent.com/u/27563729?v=4", "gravatar_id": "", "url": "https://api.github.com/users/inkcherry", "html_url": "https://github.com/inkcherry", "followers_url": "https://api.github.com/users/inkcherry/followers", "following_url": "https://api.github.com/users/inkcherry/following{/other_user}", "gists_url": "https://api.github.com/users/inkcherry/gists{/gist_id}", "starred_url": "https://api.github.com/users/inkcherry/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/inkcherry/subscriptions", "organizations_url": "https://api.github.com/users/inkcherry/orgs", "repos_url": "https://api.github.com/users/inkcherry/repos", "events_url": "https://api.github.com/users/inkcherry/events{/privacy}", "received_events_url": "https://api.github.com/users/inkcherry/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-22T08:25:00
2025-06-06T14:54:37
2025-06-06T14:54:00
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38286", "html_url": "https://github.com/huggingface/transformers/pull/38286", "diff_url": "https://github.com/huggingface/transformers/pull/38286.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38286.patch", "merged_at": "2025-06-06T14:54:00" }
# What does this PR do? <!-- Congratulations! You've made it this far! You're not quite done yet though. Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution. Then, please replace this with a description of the change and which issue is fixed (if applicable). Please also include relevant motivation and context. List any dependencies (if any) that are required for this change. Once you're done, someone will review your PR shortly (see the section "Who can review?" below to tag some potential reviewers). They may suggest changes to make the code even better. If no one reviewed your PR after a week has passed, don't hesitate to post a new comment @-mentioning the same persons---sometimes notifications get lost. --> <!-- Remove if not applicable --> Fixes https://github.com/deepspeedai/DeepSpeed/issues/7298 cc @SunMarc @zach-huggingface ## Before submitting - [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [ ] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request), Pull Request section? - [ ] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case. - [ ] Did you make sure to update the documentation with your changes? Here are the [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation). - [ ] Did you write any new necessary tests? ## Who can review? Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR. <!-- Your PR will be replied to more quickly if you can figure out the right person to tag with @ If you know how to use git blame, that is the easiest way, otherwise, here is a rough guide of **who to tag**. Please tag fewer than 3 people. Models: - text models: @ArthurZucker - vision models: @amyeroberts, @qubvel - speech models: @eustlb - graph models: @clefourrier Library: - flax: @gante and @Rocketknight1 - generate: @zucchini-nlp (visual-language models) or @gante (all others) - pipelines: @Rocketknight1 - tensorflow: @gante and @Rocketknight1 - tokenizers: @ArthurZucker - trainer: @zach-huggingface and @SunMarc - chat templates: @Rocketknight1 Integrations: - deepspeed: HF Trainer/Accelerate: @SunMarc @zach-huggingface - ray/raytune: @richardliaw, @amogkam - Big Model Inference: @SunMarc - quantization (bitsandbytes, autogpt): @SunMarc @MekkCyber Documentation: @stevhliu HF projects: - accelerate: [different repo](https://github.com/huggingface/accelerate) - datasets: [different repo](https://github.com/huggingface/datasets) - diffusers: [different repo](https://github.com/huggingface/diffusers) - rust tokenizers: [different repo](https://github.com/huggingface/tokenizers) Maintained examples (not research project or legacy): - Flax: @Rocketknight1 - PyTorch: See Models above and tag the person corresponding to the modality of the example. - TensorFlow: @Rocketknight1 -->
{ "login": "SunMarc", "id": 57196510, "node_id": "MDQ6VXNlcjU3MTk2NTEw", "avatar_url": "https://avatars.githubusercontent.com/u/57196510?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SunMarc", "html_url": "https://github.com/SunMarc", "followers_url": "https://api.github.com/users/SunMarc/followers", "following_url": "https://api.github.com/users/SunMarc/following{/other_user}", "gists_url": "https://api.github.com/users/SunMarc/gists{/gist_id}", "starred_url": "https://api.github.com/users/SunMarc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SunMarc/subscriptions", "organizations_url": "https://api.github.com/users/SunMarc/orgs", "repos_url": "https://api.github.com/users/SunMarc/repos", "events_url": "https://api.github.com/users/SunMarc/events{/privacy}", "received_events_url": "https://api.github.com/users/SunMarc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38286/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38286/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38285
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38285/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38285/comments
https://api.github.com/repos/huggingface/transformers/issues/38285/events
https://github.com/huggingface/transformers/pull/38285
3,082,464,902
PR_kwDOCUB6oc6XLi3U
38,285
Utility script for generating CI reports locally
{ "login": "ahadnagy", "id": 21314428, "node_id": "MDQ6VXNlcjIxMzE0NDI4", "avatar_url": "https://avatars.githubusercontent.com/u/21314428?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ahadnagy", "html_url": "https://github.com/ahadnagy", "followers_url": "https://api.github.com/users/ahadnagy/followers", "following_url": "https://api.github.com/users/ahadnagy/following{/other_user}", "gists_url": "https://api.github.com/users/ahadnagy/gists{/gist_id}", "starred_url": "https://api.github.com/users/ahadnagy/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ahadnagy/subscriptions", "organizations_url": "https://api.github.com/users/ahadnagy/orgs", "repos_url": "https://api.github.com/users/ahadnagy/repos", "events_url": "https://api.github.com/users/ahadnagy/events{/privacy}", "received_events_url": "https://api.github.com/users/ahadnagy/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-22T08:09:56
2025-09-29T14:56:08
2025-09-29T14:56:07
CONTRIBUTOR
null
null
true
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38285", "html_url": "https://github.com/huggingface/transformers/pull/38285", "diff_url": "https://github.com/huggingface/transformers/pull/38285.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38285.patch", "merged_at": null }
# What does this PR do? This PR adds a small util that lets us perform CI runs locally with report generation as it happens during the prod run. This is used for debugging purposes and for debugging new hardware. Tied to @ivarflakstad's PR: https://github.com/huggingface/transformers/pull/37976 . ## Before submitting - [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [ ] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request), Pull Request section? - [ ] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case. - [ ] Did you make sure to update the documentation with your changes? Here are the [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation). - [ ] Did you write any new necessary tests? ## Who can review? Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR. <!-- Your PR will be replied to more quickly if you can figure out the right person to tag with @ If you know how to use git blame, that is the easiest way, otherwise, here is a rough guide of **who to tag**. Please tag fewer than 3 people. Models: - text models: @ArthurZucker - vision models: @amyeroberts, @qubvel - speech models: @eustlb - graph models: @clefourrier Library: - flax: @gante and @Rocketknight1 - generate: @zucchini-nlp (visual-language models) or @gante (all others) - pipelines: @Rocketknight1 - tensorflow: @gante and @Rocketknight1 - tokenizers: @ArthurZucker - trainer: @zach-huggingface and @SunMarc - chat templates: @Rocketknight1 Integrations: - deepspeed: HF Trainer/Accelerate: @SunMarc @zach-huggingface - ray/raytune: @richardliaw, @amogkam - Big Model Inference: @SunMarc - quantization (bitsandbytes, autogpt): @SunMarc @MekkCyber Documentation: @stevhliu HF projects: - accelerate: [different repo](https://github.com/huggingface/accelerate) - datasets: [different repo](https://github.com/huggingface/datasets) - diffusers: [different repo](https://github.com/huggingface/diffusers) - rust tokenizers: [different repo](https://github.com/huggingface/tokenizers) Maintained examples (not research project or legacy): - Flax: @Rocketknight1 - PyTorch: See Models above and tag the person corresponding to the modality of the example. - TensorFlow: @Rocketknight1 -->
{ "login": "ahadnagy", "id": 21314428, "node_id": "MDQ6VXNlcjIxMzE0NDI4", "avatar_url": "https://avatars.githubusercontent.com/u/21314428?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ahadnagy", "html_url": "https://github.com/ahadnagy", "followers_url": "https://api.github.com/users/ahadnagy/followers", "following_url": "https://api.github.com/users/ahadnagy/following{/other_user}", "gists_url": "https://api.github.com/users/ahadnagy/gists{/gist_id}", "starred_url": "https://api.github.com/users/ahadnagy/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ahadnagy/subscriptions", "organizations_url": "https://api.github.com/users/ahadnagy/orgs", "repos_url": "https://api.github.com/users/ahadnagy/repos", "events_url": "https://api.github.com/users/ahadnagy/events{/privacy}", "received_events_url": "https://api.github.com/users/ahadnagy/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38285/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38285/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38284
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38284/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38284/comments
https://api.github.com/repos/huggingface/transformers/issues/38284/events
https://github.com/huggingface/transformers/pull/38284
3,082,422,411
PR_kwDOCUB6oc6XLZqm
38,284
align xpu's autocast behavior w/ cuda by using device agnostic torch APIs
{ "login": "yao-matrix", "id": 7245027, "node_id": "MDQ6VXNlcjcyNDUwMjc=", "avatar_url": "https://avatars.githubusercontent.com/u/7245027?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yao-matrix", "html_url": "https://github.com/yao-matrix", "followers_url": "https://api.github.com/users/yao-matrix/followers", "following_url": "https://api.github.com/users/yao-matrix/following{/other_user}", "gists_url": "https://api.github.com/users/yao-matrix/gists{/gist_id}", "starred_url": "https://api.github.com/users/yao-matrix/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yao-matrix/subscriptions", "organizations_url": "https://api.github.com/users/yao-matrix/orgs", "repos_url": "https://api.github.com/users/yao-matrix/repos", "events_url": "https://api.github.com/users/yao-matrix/events{/privacy}", "received_events_url": "https://api.github.com/users/yao-matrix/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-22T07:54:51
2025-06-19T23:57:06
2025-06-19T11:48:23
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38284", "html_url": "https://github.com/huggingface/transformers/pull/38284", "diff_url": "https://github.com/huggingface/transformers/pull/38284.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38284.patch", "merged_at": "2025-06-19T11:48:23" }
@ArthurZucker, pls help review, thx very much.
{ "login": "ydshieh", "id": 2521628, "node_id": "MDQ6VXNlcjI1MjE2Mjg=", "avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ydshieh", "html_url": "https://github.com/ydshieh", "followers_url": "https://api.github.com/users/ydshieh/followers", "following_url": "https://api.github.com/users/ydshieh/following{/other_user}", "gists_url": "https://api.github.com/users/ydshieh/gists{/gist_id}", "starred_url": "https://api.github.com/users/ydshieh/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ydshieh/subscriptions", "organizations_url": "https://api.github.com/users/ydshieh/orgs", "repos_url": "https://api.github.com/users/ydshieh/repos", "events_url": "https://api.github.com/users/ydshieh/events{/privacy}", "received_events_url": "https://api.github.com/users/ydshieh/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38284/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38284/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38283
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38283/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38283/comments
https://api.github.com/repos/huggingface/transformers/issues/38283/events
https://github.com/huggingface/transformers/issues/38283
3,082,161,933
I_kwDOCUB6oc63tg8N
38,283
TypeError in Llama-4-Maverick-17B-128E-Instruct-FP8 Resolved with Workaround
{ "login": "pchu2025", "id": 212827289, "node_id": "U_kgDODK98mQ", "avatar_url": "https://avatars.githubusercontent.com/u/212827289?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pchu2025", "html_url": "https://github.com/pchu2025", "followers_url": "https://api.github.com/users/pchu2025/followers", "following_url": "https://api.github.com/users/pchu2025/following{/other_user}", "gists_url": "https://api.github.com/users/pchu2025/gists{/gist_id}", "starred_url": "https://api.github.com/users/pchu2025/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pchu2025/subscriptions", "organizations_url": "https://api.github.com/users/pchu2025/orgs", "repos_url": "https://api.github.com/users/pchu2025/repos", "events_url": "https://api.github.com/users/pchu2025/events{/privacy}", "received_events_url": "https://api.github.com/users/pchu2025/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-22T06:05:26
2025-05-30T13:08:41
2025-05-30T13:08:40
NONE
null
null
null
null
### Issue Description Loading `meta-llama/Llama-4-Maverick-17B-128E-Instruct-FP8` with `transformers==4.53.0.dev0` or `4.51.0` initially failed with `TypeError: argument of type 'NoneType' is not iterable` in `transformers.modeling_utils.post_init`. This occurred with `Llama4ForConditionalGeneration` and `AutoModelForCausalLM` on a 4x NVIDIA RTX A6000 setup (~196GB VRAM, CUDA 12.4, Python 3.12.3, Ubuntu 24.04.2). A similar `TypeError` was seen previously with 2x GPUs. The issue was resolved using `transformers==4.51.0` and `config={"parallel_style": "none"}`. ### Steps to Reproduce 1. Install dependencies: ```bash pip install torch==2.4.1 torchvision==0.19.1 accelerate==1.7.0 compressed-tensors==0.9.4 transformers==4.51.0 2. Confirm model files (~389GB, 84 .safetensors) at /mnt/data/ai_super_palace/models/llama4/. 3. Run (failed): from transformers import Llama4ForConditionalGeneration model = Llama4ForConditionalGeneration.from_pretrained( '/mnt/data/ai_super_palace/models/llama4', torch_dtype=torch.float16, device_map="auto", low_cpu_mem_usage=True ) print('Model OK') 4. Error: TypeError: argument of type 'NoneType' is not iterable 5: Workaround (succeeded): import os import torch os.environ["TORCHVISION_DISABLE_NMS"] = "1" from transformers import AutoModelForCausalLM model = AutoModelForCausalLM.from_pretrained( '/mnt/data/ai_super_palace/models/llama4', torch_dtype=torch.float16, device_map="auto", low_cpu_mem_usage=True, offload_folder="/mnt/data/ai_super_palace/models/llama4/offload", config={"parallel_style": "none"} ) print('Model OK') **Environment** Transformers: 4.51.0 (or 4.53.0.dev0, commit b369a654) Python: 3.12.3 PyTorch: 2.4.1 CUDA: 12.4 Accelerate: 1.7.0 Compressed-tensors: 0.9.4 OS: Ubuntu 24.04.2 LTS Hardware: 4x NVIDIA RTX A6000 (~196GB VRAM) Model: meta-llama/Llama-4-Maverick-17B-128E-Instruct-FP8 **Additional Details** Model card requires transformers>=4.51.0, supports FP8 via compressed-tensors. Previous errors: NameError: init_empty_weights, ValueError: requires accelerate, ImportError: requires compressed-tensors. Config check (cat config.json | grep -E "parallel|tp_plan") empty. Warnings: Uninitialized weights (feed_forward.experts.*) and offloaded parameters (expected due to VRAM). **Request** Is the TypeError a known llama4 bug? Should parallel_style be explicitly set in config.json? Guidance on fine-tuning for sentiment analysis (~100–150GB/day, ~85–90% accuracy). Sharing workaround for community benefit. **Logs** See traceback above. config.json (40KB) available if needed. Thank you!
{ "login": "Rocketknight1", "id": 12866554, "node_id": "MDQ6VXNlcjEyODY2NTU0", "avatar_url": "https://avatars.githubusercontent.com/u/12866554?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Rocketknight1", "html_url": "https://github.com/Rocketknight1", "followers_url": "https://api.github.com/users/Rocketknight1/followers", "following_url": "https://api.github.com/users/Rocketknight1/following{/other_user}", "gists_url": "https://api.github.com/users/Rocketknight1/gists{/gist_id}", "starred_url": "https://api.github.com/users/Rocketknight1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Rocketknight1/subscriptions", "organizations_url": "https://api.github.com/users/Rocketknight1/orgs", "repos_url": "https://api.github.com/users/Rocketknight1/repos", "events_url": "https://api.github.com/users/Rocketknight1/events{/privacy}", "received_events_url": "https://api.github.com/users/Rocketknight1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38283/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38283/timeline
null
completed
{ "total": 0, "completed": 0, "percent_completed": 0 }
{ "blocked_by": 0, "total_blocked_by": 0, "blocking": 0, "total_blocking": 0 }
false
true
https://api.github.com/repos/huggingface/transformers/issues/38282
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38282/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38282/comments
https://api.github.com/repos/huggingface/transformers/issues/38282/events
https://github.com/huggingface/transformers/pull/38282
3,082,129,465
PR_kwDOCUB6oc6XKaeI
38,282
add XPU info print in print_env
{ "login": "yao-matrix", "id": 7245027, "node_id": "MDQ6VXNlcjcyNDUwMjc=", "avatar_url": "https://avatars.githubusercontent.com/u/7245027?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yao-matrix", "html_url": "https://github.com/yao-matrix", "followers_url": "https://api.github.com/users/yao-matrix/followers", "following_url": "https://api.github.com/users/yao-matrix/following{/other_user}", "gists_url": "https://api.github.com/users/yao-matrix/gists{/gist_id}", "starred_url": "https://api.github.com/users/yao-matrix/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yao-matrix/subscriptions", "organizations_url": "https://api.github.com/users/yao-matrix/orgs", "repos_url": "https://api.github.com/users/yao-matrix/repos", "events_url": "https://api.github.com/users/yao-matrix/events{/privacy}", "received_events_url": "https://api.github.com/users/yao-matrix/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-22T05:46:48
2025-05-22T22:18:54
2025-05-22T09:03:56
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38282", "html_url": "https://github.com/huggingface/transformers/pull/38282", "diff_url": "https://github.com/huggingface/transformers/pull/38282.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38282.patch", "merged_at": "2025-05-22T09:03:56" }
@ydshieh , pls help review, thx very much.
{ "login": "ydshieh", "id": 2521628, "node_id": "MDQ6VXNlcjI1MjE2Mjg=", "avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ydshieh", "html_url": "https://github.com/ydshieh", "followers_url": "https://api.github.com/users/ydshieh/followers", "following_url": "https://api.github.com/users/ydshieh/following{/other_user}", "gists_url": "https://api.github.com/users/ydshieh/gists{/gist_id}", "starred_url": "https://api.github.com/users/ydshieh/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ydshieh/subscriptions", "organizations_url": "https://api.github.com/users/ydshieh/orgs", "repos_url": "https://api.github.com/users/ydshieh/repos", "events_url": "https://api.github.com/users/ydshieh/events{/privacy}", "received_events_url": "https://api.github.com/users/ydshieh/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38282/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38282/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38281
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38281/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38281/comments
https://api.github.com/repos/huggingface/transformers/issues/38281/events
https://github.com/huggingface/transformers/issues/38281
3,082,127,479
I_kwDOCUB6oc63tYh3
38,281
KeyError in Llama-4-Maverick-17B-128E-Instruct-FP8 Inference with Offloading
{ "login": "pchu2025", "id": 212827289, "node_id": "U_kgDODK98mQ", "avatar_url": "https://avatars.githubusercontent.com/u/212827289?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pchu2025", "html_url": "https://github.com/pchu2025", "followers_url": "https://api.github.com/users/pchu2025/followers", "following_url": "https://api.github.com/users/pchu2025/following{/other_user}", "gists_url": "https://api.github.com/users/pchu2025/gists{/gist_id}", "starred_url": "https://api.github.com/users/pchu2025/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pchu2025/subscriptions", "organizations_url": "https://api.github.com/users/pchu2025/orgs", "repos_url": "https://api.github.com/users/pchu2025/repos", "events_url": "https://api.github.com/users/pchu2025/events{/privacy}", "received_events_url": "https://api.github.com/users/pchu2025/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-22T05:45:30
2025-07-27T08:03:11
2025-07-27T08:03:11
NONE
null
null
null
null
### Issue Description Loading `meta-llama/Llama-4-Maverick-17B-128E-Instruct-FP8` succeeds with `transformers==4.51.0`, but inference fails with `KeyError: 'model.layers.37.feed_forward.experts.gate_up_proj'` during `model.generate`. This occurs on 4x NVIDIA RTX A6000 (~196GB VRAM, CUDA 12.4, Python 3.12.3, Ubuntu 24.04.2) with offloading, critical for sentiment analysis (~100–150GB/day, ~85–90% accuracy). Disabling MoE (`num_experts=0`) didn’t resolve it. ### Steps to Reproduce 1. Install dependencies: ```bash pip install torch==2.4.1 accelerate==1.7.0 compressed-tensors==0.9.4 transformers==4.51.0 2. Confirm model files (~389GB, 84 .safetensors) at /mnt/data/ai_super_palace/models/llama4/. 3. Run: import os import torch from transformers import AutoModelForCausalLM, AutoTokenizer os.environ["TORCHVISION_DISABLE_NMS"] = "1" model = AutoModelForCausalLM.from_pretrained( '/mnt/data/ai_super_palace/models/llama4', torch_dtype=torch.float16, device_map="auto", low_cpu_mem_usage=True, offload_folder="/mnt/data/ai_super_palace/models/llama4/offload", config={"parallel_style": "none"} ) tokenizer = AutoTokenizer.from_pretrained('/mnt/data/ai_super_palace/models/llama4') prompt = "What is the sentiment of this text: 'I love this product, it's amazing!'" inputs = tokenizer(prompt, return_tensors="pt").to(model.device) outputs = model.generate(**inputs, max_new_tokens=50) print(tokenizer.decode(outputs[0], skip_special_tokens=True)) 4. Error: KeyError: 'model.layers.37.feed_forward.experts.gate_up_proj' **Environment** Transformers: 4.51.0 Python: 3.12.3 PyTorch: 2.4.1 CUDA: 12.4 Accelerate: 1.7.0 Compressed-tensors: 0.9.4 OS: Ubuntu 24.04.2 LTS Hardware: 4x NVIDIA RTX A6000 (~196GB VRAM) Model: meta-llama/Llama-4-Maverick-17B-128E-Instruct-FP8 **Additional Details** Model card requires transformers>=4.51.0, supports FP8 via compressed-tensors. Warnings: Uninitialized MoE weights (feed_forward.experts.*), offloaded parameters (VRAM limit). Prior errors (TypeError: NoneType not iterable) resolved with config={"parallel_style": "none"}. Suspect bug in accelerate offloading or MoE weight initialization. **Request** Is this a known llama4 MoE offloading issue? Can MoE weights be initialized or offloading fixed? Workaround for inference without re-downloading (~389GB)? Urgent for sentiment analysis. **Logs** See traceback above. config.json (40KB) available. Thank you!
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38281/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38281/timeline
null
completed
{ "total": 0, "completed": 0, "percent_completed": 0 }
{ "blocked_by": 0, "total_blocked_by": 0, "blocking": 0, "total_blocking": 0 }
false
true
https://api.github.com/repos/huggingface/transformers/issues/38280
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38280/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38280/comments
https://api.github.com/repos/huggingface/transformers/issues/38280/events
https://github.com/huggingface/transformers/pull/38280
3,082,079,041
PR_kwDOCUB6oc6XKPZa
38,280
Add zero dim tensor check when using flash_attention
{ "login": "ranzhejiang", "id": 35677181, "node_id": "MDQ6VXNlcjM1Njc3MTgx", "avatar_url": "https://avatars.githubusercontent.com/u/35677181?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ranzhejiang", "html_url": "https://github.com/ranzhejiang", "followers_url": "https://api.github.com/users/ranzhejiang/followers", "following_url": "https://api.github.com/users/ranzhejiang/following{/other_user}", "gists_url": "https://api.github.com/users/ranzhejiang/gists{/gist_id}", "starred_url": "https://api.github.com/users/ranzhejiang/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ranzhejiang/subscriptions", "organizations_url": "https://api.github.com/users/ranzhejiang/orgs", "repos_url": "https://api.github.com/users/ranzhejiang/repos", "events_url": "https://api.github.com/users/ranzhejiang/events{/privacy}", "received_events_url": "https://api.github.com/users/ranzhejiang/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-22T05:20:17
2025-06-25T07:48:59
2025-06-25T07:48:50
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38280", "html_url": "https://github.com/huggingface/transformers/pull/38280", "diff_url": "https://github.com/huggingface/transformers/pull/38280.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38280.patch", "merged_at": "2025-06-25T07:48:50" }
The cuda or triton kernel can not support this case: dimensions of size is 0, but traditional SDPA is implemented using PyTorch's tensor operations, which have robust support for tensors with dimensions of size 0. We need to add this check and error tips for developers when using flash_attention. Related issue is in https://github.com/deepspeedai/DeepSpeed/issues/7275
{ "login": "ArthurZucker", "id": 48595927, "node_id": "MDQ6VXNlcjQ4NTk1OTI3", "avatar_url": "https://avatars.githubusercontent.com/u/48595927?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ArthurZucker", "html_url": "https://github.com/ArthurZucker", "followers_url": "https://api.github.com/users/ArthurZucker/followers", "following_url": "https://api.github.com/users/ArthurZucker/following{/other_user}", "gists_url": "https://api.github.com/users/ArthurZucker/gists{/gist_id}", "starred_url": "https://api.github.com/users/ArthurZucker/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ArthurZucker/subscriptions", "organizations_url": "https://api.github.com/users/ArthurZucker/orgs", "repos_url": "https://api.github.com/users/ArthurZucker/repos", "events_url": "https://api.github.com/users/ArthurZucker/events{/privacy}", "received_events_url": "https://api.github.com/users/ArthurZucker/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38280/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38280/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38279
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38279/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38279/comments
https://api.github.com/repos/huggingface/transformers/issues/38279/events
https://github.com/huggingface/transformers/issues/38279
3,082,009,178
I_kwDOCUB6oc63s7pa
38,279
TypeError: NoneType not iterable in Llama-4-Maverick-17B-128E-Instruct-FP8 initialization
{ "login": "pchu2025", "id": 212827289, "node_id": "U_kgDODK98mQ", "avatar_url": "https://avatars.githubusercontent.com/u/212827289?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pchu2025", "html_url": "https://github.com/pchu2025", "followers_url": "https://api.github.com/users/pchu2025/followers", "following_url": "https://api.github.com/users/pchu2025/following{/other_user}", "gists_url": "https://api.github.com/users/pchu2025/gists{/gist_id}", "starred_url": "https://api.github.com/users/pchu2025/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pchu2025/subscriptions", "organizations_url": "https://api.github.com/users/pchu2025/orgs", "repos_url": "https://api.github.com/users/pchu2025/repos", "events_url": "https://api.github.com/users/pchu2025/events{/privacy}", "received_events_url": "https://api.github.com/users/pchu2025/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-22T04:35:19
2025-05-22T16:33:10
2025-05-22T16:33:10
NONE
null
null
null
null
### Issue Description When attempting to load `meta-llama/Llama-4-Maverick-17B-128E-Instruct-FP8` using `transformers==4.53.0.dev0` (or `4.51.0`), I encounter a `TypeError: argument of type 'NoneType' is not iterable` in `transformers.modeling_utils.post_init`. This occurs with both `Llama4ForConditionalGeneration` and `AutoModelForCausalLM`, blocking model verification and inference. The error persists despite installing required dependencies (`accelerate`, `compressed-tensors`) and trying various configurations (e.g., `tp_plan=None`, FP16 quantization, offloading). This is a recurring issue, as I previously encountered a `TypeError` with this model on a 2x GPU setup. Current setup uses 4x NVIDIA RTX A6000 GPUs (~196GB VRAM), CUDA 12.4, Python 3.12.3. ### Steps to Reproduce 1. Install dependencies in a Python 3.12.3 virtual environment: ```bash pip install torch==2.4.1 torchvision==0.19.1 accelerate==1.7.0 compressed-tensors==0.9.4 pip install git+https://github.com/huggingface/transformers.git 2. Confirm model files (~389GB, 84 .safetensors) at /mnt/data/ai_super_palace/models/llama4/. 3 Run: import os import torch os.environ["TORCHVISION_DISABLE_NMS"] = "1" from transformers import Llama4ForConditionalGeneration model = Llama4ForConditionalGeneration.from_pretrained( '/mnt/data/ai_super_palace/models/llama4', torch_dtype=torch.float16, device_map="auto", low_cpu_mem_usage=True, offload_folder="/mnt/data/ai_super_palace/models/llama4/offload", tp_plan=None ) print('Model OK') 4. Error: Traceback (most recent call last): File "verify_llama4.py", line 5, in <module> model = Llama4ForConditionalGeneration.from_pretrained( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File ".../transformers/modeling_utils.py", line 309, in _wrapper return func(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^ File ".../transformers/modeling_utils.py", line 4507, in from_pretrained model = cls(config, *model_args, **model_kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File ".../transformers/models/llama4/modeling_llama4.py", line 1490, in __init__ self.vision_model = Llama4VisionModel(config.vision_config) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File ".../transformers/models/llama4/modeling_llama4.py", line 1376, in __init__ self.post_init() File ".../transformers/modeling_utils.py", line 1968, in post_init if v not in ALL_PARALLEL_STYLES: ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ TypeError: argument of type 'NoneType' is not iterable Environment Transformers: 4.53.0.dev0 (commit b369a654) or 4.51.0 Python: 3.12.3 PyTorch: 2.4.1 CUDA: 12.4 Accelerate: 1.7.0 Compressed-tensors: 0.9.4 OS: Ubuntu 24.04.2 LTS Hardware: 4x NVIDIA RTX A6000 (~196GB VRAM) Model: meta-llama/Llama-4-Maverick-17B-128E-Instruct-FP8 Additional Details Model card requires transformers>=4.51.0, supports FP8 via compressed-tensors. Config check (cat config.json | grep -E "parallel|tp_plan") empty. Previous errors resolved: NameError: init_empty_weights, ValueError: requires accelerate, ImportError: requires compressed-tensors. Recurring TypeError from 2x GPU setup suggests llama4 architecture issue. Suspect bug in post_init for Llama4VisionModel or Llama4TextModel. Expected Behavior Model loads, prints Model OK. Actual Behavior TypeError due to NoneType in parallel style check. Request Is this a known llama4 bug? Are specific config.json settings needed? Can parallel checks be bypassed or text-only loading isolated? Urgent for sentiment analysis; need workaround or fix ASAP. Logs See traceback. config.json (40KB) available if needed. Thank you for urgent help!
{ "login": "Rocketknight1", "id": 12866554, "node_id": "MDQ6VXNlcjEyODY2NTU0", "avatar_url": "https://avatars.githubusercontent.com/u/12866554?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Rocketknight1", "html_url": "https://github.com/Rocketknight1", "followers_url": "https://api.github.com/users/Rocketknight1/followers", "following_url": "https://api.github.com/users/Rocketknight1/following{/other_user}", "gists_url": "https://api.github.com/users/Rocketknight1/gists{/gist_id}", "starred_url": "https://api.github.com/users/Rocketknight1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Rocketknight1/subscriptions", "organizations_url": "https://api.github.com/users/Rocketknight1/orgs", "repos_url": "https://api.github.com/users/Rocketknight1/repos", "events_url": "https://api.github.com/users/Rocketknight1/events{/privacy}", "received_events_url": "https://api.github.com/users/Rocketknight1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38279/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38279/timeline
null
duplicate
{ "total": 0, "completed": 0, "percent_completed": 0 }
{ "blocked_by": 0, "total_blocked_by": 0, "blocking": 0, "total_blocking": 0 }
false
true
https://api.github.com/repos/huggingface/transformers/issues/38278
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38278/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38278/comments
https://api.github.com/repos/huggingface/transformers/issues/38278/events
https://github.com/huggingface/transformers/pull/38278
3,081,943,793
PR_kwDOCUB6oc6XJy2g
38,278
[performance_optim] reduce frequency of declaring attention_mask in Ascend NPU flash attention
{ "login": "FightingZhen", "id": 26176607, "node_id": "MDQ6VXNlcjI2MTc2NjA3", "avatar_url": "https://avatars.githubusercontent.com/u/26176607?v=4", "gravatar_id": "", "url": "https://api.github.com/users/FightingZhen", "html_url": "https://github.com/FightingZhen", "followers_url": "https://api.github.com/users/FightingZhen/followers", "following_url": "https://api.github.com/users/FightingZhen/following{/other_user}", "gists_url": "https://api.github.com/users/FightingZhen/gists{/gist_id}", "starred_url": "https://api.github.com/users/FightingZhen/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/FightingZhen/subscriptions", "organizations_url": "https://api.github.com/users/FightingZhen/orgs", "repos_url": "https://api.github.com/users/FightingZhen/repos", "events_url": "https://api.github.com/users/FightingZhen/events{/privacy}", "received_events_url": "https://api.github.com/users/FightingZhen/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-22T03:43:28
2025-08-14T01:52:40
2025-05-23T15:24:52
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38278", "html_url": "https://github.com/huggingface/transformers/pull/38278", "diff_url": "https://github.com/huggingface/transformers/pull/38278.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38278.patch", "merged_at": "2025-05-23T15:24:52" }
# What does this PR do? During analyzing performance of flash attention on Ascend NPU, we find that a fixed-size 2048*2048 upper triangular matrix `attn_mask_npu` is frequently defined in func `npu_flash_attn_func` and `npu_flash_attn_varlen_func`, which will cost a lot of time. This PR is committed for solving this problem, by defining and using global variable `ATTN_MASK_NPU`, this matrix will not be defined every time func `npu_flash_attn_func` or `npu_flash_attn_varlen_func` is called. Thanks @CurryRice233 for proposing this idea. Fixes # (issue) Not related. ## Before submitting - [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [x] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request), Pull Request section? - [ ] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case. - [ ] Did you make sure to update the documentation with your changes? Here are the [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation). - [ ] Did you write any new necessary tests?
{ "login": "ArthurZucker", "id": 48595927, "node_id": "MDQ6VXNlcjQ4NTk1OTI3", "avatar_url": "https://avatars.githubusercontent.com/u/48595927?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ArthurZucker", "html_url": "https://github.com/ArthurZucker", "followers_url": "https://api.github.com/users/ArthurZucker/followers", "following_url": "https://api.github.com/users/ArthurZucker/following{/other_user}", "gists_url": "https://api.github.com/users/ArthurZucker/gists{/gist_id}", "starred_url": "https://api.github.com/users/ArthurZucker/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ArthurZucker/subscriptions", "organizations_url": "https://api.github.com/users/ArthurZucker/orgs", "repos_url": "https://api.github.com/users/ArthurZucker/repos", "events_url": "https://api.github.com/users/ArthurZucker/events{/privacy}", "received_events_url": "https://api.github.com/users/ArthurZucker/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38278/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38278/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38277
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38277/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38277/comments
https://api.github.com/repos/huggingface/transformers/issues/38277/events
https://github.com/huggingface/transformers/issues/38277
3,081,934,334
I_kwDOCUB6oc63spX-
38,277
large accuracy drop for opt-125m with V4.52.2
{ "login": "wenhuach21", "id": 108330088, "node_id": "U_kgDOBnT8aA", "avatar_url": "https://avatars.githubusercontent.com/u/108330088?v=4", "gravatar_id": "", "url": "https://api.github.com/users/wenhuach21", "html_url": "https://github.com/wenhuach21", "followers_url": "https://api.github.com/users/wenhuach21/followers", "following_url": "https://api.github.com/users/wenhuach21/following{/other_user}", "gists_url": "https://api.github.com/users/wenhuach21/gists{/gist_id}", "starred_url": "https://api.github.com/users/wenhuach21/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/wenhuach21/subscriptions", "organizations_url": "https://api.github.com/users/wenhuach21/orgs", "repos_url": "https://api.github.com/users/wenhuach21/repos", "events_url": "https://api.github.com/users/wenhuach21/events{/privacy}", "received_events_url": "https://api.github.com/users/wenhuach21/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 3817266200, "node_id": "MDU6TGFiZWwzODE3MjY2MjAw", "url": "https://api.github.com/repos/huggingface/transformers/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": null } ]
closed
false
{ "login": "vasqu", "id": 73884904, "node_id": "MDQ6VXNlcjczODg0OTA0", "avatar_url": "https://avatars.githubusercontent.com/u/73884904?v=4", "gravatar_id": "", "url": "https://api.github.com/users/vasqu", "html_url": "https://github.com/vasqu", "followers_url": "https://api.github.com/users/vasqu/followers", "following_url": "https://api.github.com/users/vasqu/following{/other_user}", "gists_url": "https://api.github.com/users/vasqu/gists{/gist_id}", "starred_url": "https://api.github.com/users/vasqu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/vasqu/subscriptions", "organizations_url": "https://api.github.com/users/vasqu/orgs", "repos_url": "https://api.github.com/users/vasqu/repos", "events_url": "https://api.github.com/users/vasqu/events{/privacy}", "received_events_url": "https://api.github.com/users/vasqu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "vasqu", "id": 73884904, "node_id": "MDQ6VXNlcjczODg0OTA0", "avatar_url": "https://avatars.githubusercontent.com/u/73884904?v=4", "gravatar_id": "", "url": "https://api.github.com/users/vasqu", "html_url": "https://github.com/vasqu", "followers_url": "https://api.github.com/users/vasqu/followers", "following_url": "https://api.github.com/users/vasqu/following{/other_user}", "gists_url": "https://api.github.com/users/vasqu/gists{/gist_id}", "starred_url": "https://api.github.com/users/vasqu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/vasqu/subscriptions", "organizations_url": "https://api.github.com/users/vasqu/orgs", "repos_url": "https://api.github.com/users/vasqu/repos", "events_url": "https://api.github.com/users/vasqu/events{/privacy}", "received_events_url": "https://api.github.com/users/vasqu/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[]
2025-05-22T03:36:56
2025-05-26T09:02:18
2025-05-26T09:02:18
CONTRIBUTOR
null
null
null
null
### System Info lm-eval 0.48 A100 Ubuntu ### Reproduction ~~~bash lm_eval --model hf --model_args pretrained="facebook/opt-125m" --tasks lambada_openai ~~~ V4.52.2 | Tasks |Version|Filter|n-shot| Metric | | Value | | Stderr | |--------------|------:|------|-----:|----------|---|----------:|---|---------:| |lambada_openai| 1|none | 0|acc |↑ | 0.0004|± | 0.0003| | | |none | 0|perplexity|↓ |388418.4098|± |29176.4556| V4.51.3 | Tasks |Version|Filter|n-shot| Metric | | Value | |Stderr| |--------------|------:|------|-----:|----------|---|------:|---|-----:| |lambada_openai| 1|none | 0|acc |↑ | 0.3788|± |0.0068| | | |none | 0|perplexity|↓ |26.0214|± |0.9383| ### Expected behavior similar accuracy is expected
{ "login": "vasqu", "id": 73884904, "node_id": "MDQ6VXNlcjczODg0OTA0", "avatar_url": "https://avatars.githubusercontent.com/u/73884904?v=4", "gravatar_id": "", "url": "https://api.github.com/users/vasqu", "html_url": "https://github.com/vasqu", "followers_url": "https://api.github.com/users/vasqu/followers", "following_url": "https://api.github.com/users/vasqu/following{/other_user}", "gists_url": "https://api.github.com/users/vasqu/gists{/gist_id}", "starred_url": "https://api.github.com/users/vasqu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/vasqu/subscriptions", "organizations_url": "https://api.github.com/users/vasqu/orgs", "repos_url": "https://api.github.com/users/vasqu/repos", "events_url": "https://api.github.com/users/vasqu/events{/privacy}", "received_events_url": "https://api.github.com/users/vasqu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38277/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38277/timeline
null
completed
{ "total": 0, "completed": 0, "percent_completed": 0 }
{ "blocked_by": 0, "total_blocked_by": 0, "blocking": 0, "total_blocking": 0 }
false
true
https://api.github.com/repos/huggingface/transformers/issues/38276
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38276/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38276/comments
https://api.github.com/repos/huggingface/transformers/issues/38276/events
https://github.com/huggingface/transformers/pull/38276
3,081,892,068
PR_kwDOCUB6oc6XJny6
38,276
Add Normalized-GPT Architecture
{ "login": "shan18", "id": 12576178, "node_id": "MDQ6VXNlcjEyNTc2MTc4", "avatar_url": "https://avatars.githubusercontent.com/u/12576178?v=4", "gravatar_id": "", "url": "https://api.github.com/users/shan18", "html_url": "https://github.com/shan18", "followers_url": "https://api.github.com/users/shan18/followers", "following_url": "https://api.github.com/users/shan18/following{/other_user}", "gists_url": "https://api.github.com/users/shan18/gists{/gist_id}", "starred_url": "https://api.github.com/users/shan18/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/shan18/subscriptions", "organizations_url": "https://api.github.com/users/shan18/orgs", "repos_url": "https://api.github.com/users/shan18/repos", "events_url": "https://api.github.com/users/shan18/events{/privacy}", "received_events_url": "https://api.github.com/users/shan18/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-22T03:02:08
2025-06-10T14:07:47
2025-06-10T14:07:46
NONE
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38276", "html_url": "https://github.com/huggingface/transformers/pull/38276", "diff_url": "https://github.com/huggingface/transformers/pull/38276.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38276.patch", "merged_at": null }
# What does this PR do? Adds a new architecture called normalized Transformer (nGPT) ([Paper](https://arxiv.org/abs/2410.01131)). Fixes #38275 ## Before submitting - [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [x] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request), Pull Request section? - [x] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case. - [x] Did you make sure to update the documentation with your changes? Here are the [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation). - [x] Did you write any new necessary tests? ## Who can review? Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR. @ArthurZucker
{ "login": "shan18", "id": 12576178, "node_id": "MDQ6VXNlcjEyNTc2MTc4", "avatar_url": "https://avatars.githubusercontent.com/u/12576178?v=4", "gravatar_id": "", "url": "https://api.github.com/users/shan18", "html_url": "https://github.com/shan18", "followers_url": "https://api.github.com/users/shan18/followers", "following_url": "https://api.github.com/users/shan18/following{/other_user}", "gists_url": "https://api.github.com/users/shan18/gists{/gist_id}", "starred_url": "https://api.github.com/users/shan18/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/shan18/subscriptions", "organizations_url": "https://api.github.com/users/shan18/orgs", "repos_url": "https://api.github.com/users/shan18/repos", "events_url": "https://api.github.com/users/shan18/events{/privacy}", "received_events_url": "https://api.github.com/users/shan18/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38276/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38276/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38275
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38275/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38275/comments
https://api.github.com/repos/huggingface/transformers/issues/38275/events
https://github.com/huggingface/transformers/issues/38275
3,081,887,582
I_kwDOCUB6oc63sd9e
38,275
Support for Normalized-GPT architecture
{ "login": "shan18", "id": 12576178, "node_id": "MDQ6VXNlcjEyNTc2MTc4", "avatar_url": "https://avatars.githubusercontent.com/u/12576178?v=4", "gravatar_id": "", "url": "https://api.github.com/users/shan18", "html_url": "https://github.com/shan18", "followers_url": "https://api.github.com/users/shan18/followers", "following_url": "https://api.github.com/users/shan18/following{/other_user}", "gists_url": "https://api.github.com/users/shan18/gists{/gist_id}", "starred_url": "https://api.github.com/users/shan18/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/shan18/subscriptions", "organizations_url": "https://api.github.com/users/shan18/orgs", "repos_url": "https://api.github.com/users/shan18/repos", "events_url": "https://api.github.com/users/shan18/events{/privacy}", "received_events_url": "https://api.github.com/users/shan18/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1843244711, "node_id": "MDU6TGFiZWwxODQzMjQ0NzEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/New%20model", "name": "New model", "color": "fbca04", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2025-05-22T02:58:25
2025-06-10T14:08:12
2025-06-10T14:08:12
NONE
null
null
null
null
### Model description Normalized Transformer (nGPT) is a novel architecture with representation learning on the hypersphere. In nGPT, all vectors forming the embeddings, MLP, attention matrices and hidden states are unit norm normalized. The input stream of tokens travels on the surface of a hypersphere, with each layer contributing a displacement towards the target output predictions. These displacements are defined by the MLP and attention blocks, whose vector components also reside on the same hypersphere. Paper: https://arxiv.org/abs/2410.01131 ### Open source status - [x] The model implementation is available - [x] The model weights are available Weights will be shared on HF soon.
{ "login": "shan18", "id": 12576178, "node_id": "MDQ6VXNlcjEyNTc2MTc4", "avatar_url": "https://avatars.githubusercontent.com/u/12576178?v=4", "gravatar_id": "", "url": "https://api.github.com/users/shan18", "html_url": "https://github.com/shan18", "followers_url": "https://api.github.com/users/shan18/followers", "following_url": "https://api.github.com/users/shan18/following{/other_user}", "gists_url": "https://api.github.com/users/shan18/gists{/gist_id}", "starred_url": "https://api.github.com/users/shan18/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/shan18/subscriptions", "organizations_url": "https://api.github.com/users/shan18/orgs", "repos_url": "https://api.github.com/users/shan18/repos", "events_url": "https://api.github.com/users/shan18/events{/privacy}", "received_events_url": "https://api.github.com/users/shan18/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38275/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38275/timeline
null
completed
{ "total": 0, "completed": 0, "percent_completed": 0 }
{ "blocked_by": 0, "total_blocked_by": 0, "blocking": 0, "total_blocking": 0 }
false
true
https://api.github.com/repos/huggingface/transformers/issues/38274
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38274/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38274/comments
https://api.github.com/repos/huggingface/transformers/issues/38274/events
https://github.com/huggingface/transformers/pull/38274
3,081,694,749
PR_kwDOCUB6oc6XI-I_
38,274
refine `transformers env` output
{ "login": "yao-matrix", "id": 7245027, "node_id": "MDQ6VXNlcjcyNDUwMjc=", "avatar_url": "https://avatars.githubusercontent.com/u/7245027?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yao-matrix", "html_url": "https://github.com/yao-matrix", "followers_url": "https://api.github.com/users/yao-matrix/followers", "following_url": "https://api.github.com/users/yao-matrix/following{/other_user}", "gists_url": "https://api.github.com/users/yao-matrix/gists{/gist_id}", "starred_url": "https://api.github.com/users/yao-matrix/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yao-matrix/subscriptions", "organizations_url": "https://api.github.com/users/yao-matrix/orgs", "repos_url": "https://api.github.com/users/yao-matrix/repos", "events_url": "https://api.github.com/users/yao-matrix/events{/privacy}", "received_events_url": "https://api.github.com/users/yao-matrix/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-22T00:18:37
2025-05-22T22:18:28
2025-05-22T13:22:18
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38274", "html_url": "https://github.com/huggingface/transformers/pull/38274", "diff_url": "https://github.com/huggingface/transformers/pull/38274.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38274.patch", "merged_at": "2025-05-22T13:22:18" }
@ydshieh @Rocketknight1 , sorry i mis-closed https://github.com/huggingface/transformers/pull/38252, pls help review with this PR, thx very much.
{ "login": "ydshieh", "id": 2521628, "node_id": "MDQ6VXNlcjI1MjE2Mjg=", "avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ydshieh", "html_url": "https://github.com/ydshieh", "followers_url": "https://api.github.com/users/ydshieh/followers", "following_url": "https://api.github.com/users/ydshieh/following{/other_user}", "gists_url": "https://api.github.com/users/ydshieh/gists{/gist_id}", "starred_url": "https://api.github.com/users/ydshieh/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ydshieh/subscriptions", "organizations_url": "https://api.github.com/users/ydshieh/orgs", "repos_url": "https://api.github.com/users/ydshieh/repos", "events_url": "https://api.github.com/users/ydshieh/events{/privacy}", "received_events_url": "https://api.github.com/users/ydshieh/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38274/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38274/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38273
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38273/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38273/comments
https://api.github.com/repos/huggingface/transformers/issues/38273/events
https://github.com/huggingface/transformers/pull/38273
3,081,635,250
PR_kwDOCUB6oc6XIxax
38,273
Fix typo: change 'env' to 'environment' in .circleci/config.yml
{ "login": "AbdessamadEnabih", "id": 70137147, "node_id": "MDQ6VXNlcjcwMTM3MTQ3", "avatar_url": "https://avatars.githubusercontent.com/u/70137147?v=4", "gravatar_id": "", "url": "https://api.github.com/users/AbdessamadEnabih", "html_url": "https://github.com/AbdessamadEnabih", "followers_url": "https://api.github.com/users/AbdessamadEnabih/followers", "following_url": "https://api.github.com/users/AbdessamadEnabih/following{/other_user}", "gists_url": "https://api.github.com/users/AbdessamadEnabih/gists{/gist_id}", "starred_url": "https://api.github.com/users/AbdessamadEnabih/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/AbdessamadEnabih/subscriptions", "organizations_url": "https://api.github.com/users/AbdessamadEnabih/orgs", "repos_url": "https://api.github.com/users/AbdessamadEnabih/repos", "events_url": "https://api.github.com/users/AbdessamadEnabih/events{/privacy}", "received_events_url": "https://api.github.com/users/AbdessamadEnabih/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-21T23:28:42
2025-05-24T14:56:48
2025-05-23T08:45:27
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38273", "html_url": "https://github.com/huggingface/transformers/pull/38273", "diff_url": "https://github.com/huggingface/transformers/pull/38273.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38273.patch", "merged_at": "2025-05-23T08:45:27" }
# What does this PR do? <!-- Congratulations! You've made it this far! You're not quite done yet though. Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution. Then, please replace this with a description of the change and which issue is fixed (if applicable). Please also include relevant motivation and context. List any dependencies (if any) that are required for this change. Once you're done, someone will review your PR shortly (see the section "Who can review?" below to tag some potential reviewers). They may suggest changes to make the code even better. If no one reviewed your PR after a week has passed, don't hesitate to post a new comment @-mentioning the same persons---sometimes notifications get lost. --> <!-- Remove if not applicable --> This PR fixes a typo in the CircleCI configuration file ([config.yml](vscode-file://vscode-app/c:/Users/PC/AppData/Local/Programs/Microsoft%20VS%20Code/resources/app/out/vs/code/electron-sandbox/workbench/workbench.html)), replacing the incorrect env key with the correct environment key. This ensures that environment variables are properly set in the CI jobs. ## Before submitting - [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [x] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request), Pull Request section? - [ ] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case. - [ ] Did you make sure to update the documentation with your changes? Here are the [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation). - [ ] Did you write any new necessary tests? ## Who can review? Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR. <!-- Your PR will be replied to more quickly if you can figure out the right person to tag with @ If you know how to use git blame, that is the easiest way, otherwise, here is a rough guide of **who to tag**. Please tag fewer than 3 people. Models: - text models: @ArthurZucker - vision models: @amyeroberts, @qubvel - speech models: @eustlb - graph models: @clefourrier Library: - flax: @gante and @Rocketknight1 - generate: @zucchini-nlp (visual-language models) or @gante (all others) - pipelines: @Rocketknight1 - tensorflow: @gante and @Rocketknight1 - tokenizers: @ArthurZucker - trainer: @zach-huggingface and @SunMarc - chat templates: @Rocketknight1 Integrations: - deepspeed: HF Trainer/Accelerate: @SunMarc @zach-huggingface - ray/raytune: @richardliaw, @amogkam - Big Model Inference: @SunMarc - quantization (bitsandbytes, autogpt): @SunMarc @MekkCyber Documentation: @stevhliu HF projects:
{ "login": "ydshieh", "id": 2521628, "node_id": "MDQ6VXNlcjI1MjE2Mjg=", "avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ydshieh", "html_url": "https://github.com/ydshieh", "followers_url": "https://api.github.com/users/ydshieh/followers", "following_url": "https://api.github.com/users/ydshieh/following{/other_user}", "gists_url": "https://api.github.com/users/ydshieh/gists{/gist_id}", "starred_url": "https://api.github.com/users/ydshieh/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ydshieh/subscriptions", "organizations_url": "https://api.github.com/users/ydshieh/orgs", "repos_url": "https://api.github.com/users/ydshieh/repos", "events_url": "https://api.github.com/users/ydshieh/events{/privacy}", "received_events_url": "https://api.github.com/users/ydshieh/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38273/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38273/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38272
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38272/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38272/comments
https://api.github.com/repos/huggingface/transformers/issues/38272/events
https://github.com/huggingface/transformers/pull/38272
3,081,468,919
PR_kwDOCUB6oc6XINO2
38,272
Fix the shape of ModernBertForMaskedLM's output hidden_states
{ "login": "sheryc", "id": 42371864, "node_id": "MDQ6VXNlcjQyMzcxODY0", "avatar_url": "https://avatars.githubusercontent.com/u/42371864?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sheryc", "html_url": "https://github.com/sheryc", "followers_url": "https://api.github.com/users/sheryc/followers", "following_url": "https://api.github.com/users/sheryc/following{/other_user}", "gists_url": "https://api.github.com/users/sheryc/gists{/gist_id}", "starred_url": "https://api.github.com/users/sheryc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sheryc/subscriptions", "organizations_url": "https://api.github.com/users/sheryc/orgs", "repos_url": "https://api.github.com/users/sheryc/repos", "events_url": "https://api.github.com/users/sheryc/events{/privacy}", "received_events_url": "https://api.github.com/users/sheryc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
open
false
null
[]
null
[]
2025-05-21T21:37:07
2025-07-16T09:24:15
null
CONTRIBUTOR
null
null
true
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38272", "html_url": "https://github.com/huggingface/transformers/pull/38272", "diff_url": "https://github.com/huggingface/transformers/pull/38272.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38272.patch", "merged_at": null }
# What does this PR do? <!-- Congratulations! You've made it this far! You're not quite done yet though. Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution. Then, please replace this with a description of the change and which issue is fixed (if applicable). Please also include relevant motivation and context. List any dependencies (if any) that are required for this change. Once you're done, someone will review your PR shortly (see the section "Who can review?" below to tag some potential reviewers). They may suggest changes to make the code even better. If no one reviewed your PR after a week has passed, don't hesitate to post a new comment @-mentioning the same persons---sometimes notifications get lost. --> Fix the shape of `ModernBertForMaskedLM`'s output `hidden_states` when both having `output_hidden_states=True` and using Flash Attention 2. Before fix: The output hidden states are linearized to shape similar to `(batch_size * sequence_length, hidden_size)` since the input ids are unpadded before passing to `ModernBertModel`. Expected behavior: All output `hidden_states` should have shape `(batch_size, sequence_length, hidden_size)` according to the docs. This PR applies unpadding to the output hidden_states to make the shapes correct. ## Before submitting - [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [x] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request), Pull Request section? - [ ] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case. (There's no issue for this.) - [ ] Did you make sure to update the documentation with your changes? Here are the [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation). (This PR makes the behavior following the current documentation.) - [ ] Did you write any new necessary tests? (No need for extra tests.) @ArthurZucker
null
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38272/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38272/timeline
null
null
null
null
true
false
https://api.github.com/repos/huggingface/transformers/issues/38271
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38271/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38271/comments
https://api.github.com/repos/huggingface/transformers/issues/38271/events
https://github.com/huggingface/transformers/issues/38271
3,081,395,067
I_kwDOCUB6oc63qlt7
38,271
Attention refactor in #35235 adds a `__getitem__` into the forward pass, which causes errors with torch dynamo.
{ "login": "i-colbert", "id": 88047104, "node_id": "MDQ6VXNlcjg4MDQ3MTA0", "avatar_url": "https://avatars.githubusercontent.com/u/88047104?v=4", "gravatar_id": "", "url": "https://api.github.com/users/i-colbert", "html_url": "https://github.com/i-colbert", "followers_url": "https://api.github.com/users/i-colbert/followers", "following_url": "https://api.github.com/users/i-colbert/following{/other_user}", "gists_url": "https://api.github.com/users/i-colbert/gists{/gist_id}", "starred_url": "https://api.github.com/users/i-colbert/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/i-colbert/subscriptions", "organizations_url": "https://api.github.com/users/i-colbert/orgs", "repos_url": "https://api.github.com/users/i-colbert/repos", "events_url": "https://api.github.com/users/i-colbert/events{/privacy}", "received_events_url": "https://api.github.com/users/i-colbert/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 3817266200, "node_id": "MDU6TGFiZWwzODE3MjY2MjAw", "url": "https://api.github.com/repos/huggingface/transformers/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": null }, { "id": 7305045262, "node_id": "LA_kwDOCUB6oc8AAAABs2olDg", "url": "https://api.github.com/repos/huggingface/transformers/labels/ExecuTorch", "name": "ExecuTorch", "color": "33CAA3", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2025-05-21T20:57:40
2025-08-18T08:04:08
2025-08-18T08:04:08
NONE
null
null
null
null
### System Info - `transformers` version: 4.51.3 - Platform: Linux-5.15.0-122-generic-x86_64-with-glibc2.31 - Python version: 3.12.8 - Huggingface_hub version: 0.31.1 - Safetensors version: 0.5.2 - Accelerate version: 1.3.0 - Accelerate config: not found - DeepSpeed version: not installed - PyTorch version (GPU?): 2.4.0+rocm6.1 (True) - Tensorflow version (GPU?): not installed (NA) - Flax version (CPU?/GPU?/TPU?): not installed (NA) - Jax version: not installed - JaxLib version: not installed - Using distributed or parallel set-up in script?: N/A - Using GPU in script?: NA - GPU type: AMD Instinct MI210 ### Who can help? @ArthurZucker, error seems to be introduced with #35235 ### Information - [ ] The official example scripts - [ ] My own modified scripts ### Tasks - [ ] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...) - [ ] My own task or dataset (give details below) ### Reproduction You can reproduce the error with: ```python import torch from transformers import AutoModelForCausalLM from transformers import AutoTokenizer model = AutoModelForCausalLM.from_pretrained("meta-llama/Llama-3.2-1B", torch_dtype=torch.bfloat16) model.eval() tokenizer = AutoTokenizer.from_pretrained("meta-llama/Llama-3.2-1B") data = tokenizer("Once upon a time, ", return_tensors='pt') inputs = { 'input_ids': data.input_ids, 'attention_mask': torch.ones_like(data.input_ids)} model.config.use_cache = False with torch.no_grad(): model(**inputs) # verify forward pass works model, guards = torch._dynamo.export(model)(**inputs) model(**inputs) # verify forward pass works ``` and the error received looks like ```shell Traceback (most recent call last): File "/home/repro.py", line 17, in <module> model, guards = torch._dynamo.export(model)(**inputs) # ... removed for brevity... torch._dynamo.exc.Unsupported: call_method GetAttrVariable(UserDefinedObjectVariable(AttentionInterface), _global_mapping) __getitem__ (ConstantVariable(),) {} from user code: # ...removed for brevity... File "/site-packages/transformers/models/llama/modeling_llama.py", line 274, in forward attention_interface = ALL_ATTENTION_FUNCTIONS[self.config._attn_implementation] File "/site-packages/transformers/modeling_utils.py", line 5841, in __getitem__ return self._global_mapping[key] ``` ### Expected behavior Expected behavior is no errors during the dynamo export. A possible fix is ```python def forward(self, ...): # ...ignored for brevity... if self.attention_interface is None: self.attention_interface: Callable = eager_attention_forward if self.config._attn_implementation != "eager": if self.config._attn_implementation == "sdpa" and kwargs.get("output_attentions", False): logger.warning_once( "`torch.nn.functional.scaled_dot_product_attention` does not support `output_attentions=True`. Falling back to " 'eager attention. This warning can be removed using the argument `attn_implementation="eager"` when loading the model.' ) else: self.attention_interface = ALL_ATTENTION_FUNCTIONS[self.config._attn_implementation] attn_output, attn_weights = self.attention_interface( self, query_states, key_states, value_states, attention_mask, dropout=0.0 if not self.training else self.attention_dropout, scaling=self.scaling, **kwargs, ) ``` where `self.attention_interface = None` in the init
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38271/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38271/timeline
null
completed
{ "total": 0, "completed": 0, "percent_completed": 0 }
{ "blocked_by": 0, "total_blocked_by": 0, "blocking": 0, "total_blocking": 0 }
false
true
https://api.github.com/repos/huggingface/transformers/issues/38270
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38270/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38270/comments
https://api.github.com/repos/huggingface/transformers/issues/38270/events
https://github.com/huggingface/transformers/issues/38270
3,081,302,954
I_kwDOCUB6oc63qPOq
38,270
'transformers.models.janus.convert_janus_weights_to_hf' is missing from release
{ "login": "rasmi", "id": 2267370, "node_id": "MDQ6VXNlcjIyNjczNzA=", "avatar_url": "https://avatars.githubusercontent.com/u/2267370?v=4", "gravatar_id": "", "url": "https://api.github.com/users/rasmi", "html_url": "https://github.com/rasmi", "followers_url": "https://api.github.com/users/rasmi/followers", "following_url": "https://api.github.com/users/rasmi/following{/other_user}", "gists_url": "https://api.github.com/users/rasmi/gists{/gist_id}", "starred_url": "https://api.github.com/users/rasmi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/rasmi/subscriptions", "organizations_url": "https://api.github.com/users/rasmi/orgs", "repos_url": "https://api.github.com/users/rasmi/repos", "events_url": "https://api.github.com/users/rasmi/events{/privacy}", "received_events_url": "https://api.github.com/users/rasmi/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 3817266200, "node_id": "MDU6TGFiZWwzODE3MjY2MjAw", "url": "https://api.github.com/repos/huggingface/transformers/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": null } ]
closed
false
null
[]
null
[]
2025-05-21T20:10:37
2025-05-23T07:29:17
2025-05-23T07:29:17
CONTRIBUTOR
null
null
null
null
### System Info In transformers v.4.52.0 - v4.52.2, the file: src/transformers/models/janus/convert_janus_weights_to_hf.py from #36053 is missing and results in an `ModuleNotFoundError` when running tests/models/janus/test_processor_janus.py: ``` Traceback: tests/models/janus/test_processor_janus.py:23: in <module> from transformers.models.janus.convert_janus_weights_to_hf import CHAT_TEMPLATE E ModuleNotFoundError: No module named 'transformers.models.janus.convert_janus_weights_to_hf' ``` cc: @ArthurZucker @zucchini-nlp @yaswanth19 ### Who can help? _No response_ ### Information - [ ] The official example scripts - [ ] My own modified scripts ### Tasks - [ ] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...) - [ ] My own task or dataset (give details below) ### Reproduction 1. Run test `tests/models/janus/test_processor_janus.py` 2. Test fails with ModuleNotFoundError. ### Expected behavior Test passes.
{ "login": "ArthurZucker", "id": 48595927, "node_id": "MDQ6VXNlcjQ4NTk1OTI3", "avatar_url": "https://avatars.githubusercontent.com/u/48595927?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ArthurZucker", "html_url": "https://github.com/ArthurZucker", "followers_url": "https://api.github.com/users/ArthurZucker/followers", "following_url": "https://api.github.com/users/ArthurZucker/following{/other_user}", "gists_url": "https://api.github.com/users/ArthurZucker/gists{/gist_id}", "starred_url": "https://api.github.com/users/ArthurZucker/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ArthurZucker/subscriptions", "organizations_url": "https://api.github.com/users/ArthurZucker/orgs", "repos_url": "https://api.github.com/users/ArthurZucker/repos", "events_url": "https://api.github.com/users/ArthurZucker/events{/privacy}", "received_events_url": "https://api.github.com/users/ArthurZucker/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38270/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38270/timeline
null
completed
{ "total": 0, "completed": 0, "percent_completed": 0 }
{ "blocked_by": 0, "total_blocked_by": 0, "blocking": 0, "total_blocking": 0 }
false
true
https://api.github.com/repos/huggingface/transformers/issues/38269
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38269/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38269/comments
https://api.github.com/repos/huggingface/transformers/issues/38269/events
https://github.com/huggingface/transformers/issues/38269
3,081,157,513
I_kwDOCUB6oc63pruJ
38,269
release 4.52.2: SentenceTransformer import fails with "NameError: name 'Replicate' is not defined"
{ "login": "pxb5080", "id": 139392220, "node_id": "U_kgDOCE703A", "avatar_url": "https://avatars.githubusercontent.com/u/139392220?v=4", "gravatar_id": "", "url": "https://api.github.com/users/pxb5080", "html_url": "https://github.com/pxb5080", "followers_url": "https://api.github.com/users/pxb5080/followers", "following_url": "https://api.github.com/users/pxb5080/following{/other_user}", "gists_url": "https://api.github.com/users/pxb5080/gists{/gist_id}", "starred_url": "https://api.github.com/users/pxb5080/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/pxb5080/subscriptions", "organizations_url": "https://api.github.com/users/pxb5080/orgs", "repos_url": "https://api.github.com/users/pxb5080/repos", "events_url": "https://api.github.com/users/pxb5080/events{/privacy}", "received_events_url": "https://api.github.com/users/pxb5080/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 3817266200, "node_id": "MDU6TGFiZWwzODE3MjY2MjAw", "url": "https://api.github.com/repos/huggingface/transformers/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": null } ]
closed
false
null
[]
null
[]
2025-05-21T19:01:11
2025-05-22T14:43:30
2025-05-22T14:28:26
NONE
null
null
null
null
### System Info 21 May 2025 11:50:41 | polyaxon-main | from sentence_transformers import SentenceTransformer 21 May 2025 11:50:41 | polyaxon-main | File "/opt/conda/lib/python3.9/site-packages/sentence_transformers/__init__.py", line 14, in <module> 21 May 2025 11:50:41 | polyaxon-main | from sentence_transformers.cross_encoder import ( 21 May 2025 11:50:41 | polyaxon-main | File "/opt/conda/lib/python3.9/site-packages/sentence_transformers/cross_encoder/__init__.py", line 3, in <module> 21 May 2025 11:50:41 | polyaxon-main | from .CrossEncoder import CrossEncoder 21 May 2025 11:50:41 | polyaxon-main | File "/opt/conda/lib/python3.9/site-packages/sentence_transformers/cross_encoder/CrossEncoder.py", line 19, in <module> 21 May 2025 11:50:41 | polyaxon-main | from transformers import ( 21 May 2025 11:50:41 | polyaxon-main | File "<frozen importlib._bootstrap>", line 1055, in _handle_fromlist 21 May 2025 11:50:41 | polyaxon-main | File "/opt/conda/lib/python3.9/site-packages/transformers/utils/import_utils.py", line 2045, in __getattr__ 21 May 2025 11:50:41 | polyaxon-main | module = self._get_module(self._class_to_module[name]) 21 May 2025 11:50:41 | polyaxon-main | File "/opt/conda/lib/python3.9/site-packages/transformers/utils/import_utils.py", line 2075, in _get_module 21 May 2025 11:50:41 | polyaxon-main | raise e 21 May 2025 11:50:41 | polyaxon-main | File "/opt/conda/lib/python3.9/site-packages/transformers/utils/import_utils.py", line 2073, in _get_module 21 May 2025 11:50:41 | polyaxon-main | return importlib.import_module("." + module_name, self.__name__) 21 May 2025 11:50:41 | polyaxon-main | File "/opt/conda/lib/python3.9/importlib/__init__.py", line 127, in import_module 21 May 2025 11:50:41 | polyaxon-main | return _bootstrap._gcd_import(name[level:], package, level) 21 May 2025 11:50:41 | polyaxon-main | File "/opt/conda/lib/python3.9/site-packages/transformers/modeling_utils.py", line 64, in <module> 21 May 2025 11:50:41 | polyaxon-main | from .integrations.tensor_parallel import ( 21 May 2025 11:50:41 | polyaxon-main | File "/opt/conda/lib/python3.9/site-packages/transformers/integrations/tensor_parallel.py", line 723, in <module> 21 May 2025 11:50:41 | polyaxon-main | class ParallelInterface(MutableMapping): 21 May 2025 11:50:41 | polyaxon-main | File "/opt/conda/lib/python3.9/site-packages/transformers/integrations/tensor_parallel.py", line 733, in ParallelInterface 21 May 2025 11:50:41 | polyaxon-main | "colwise": ColwiseParallel(), 21 May 2025 11:50:41 | polyaxon-main | File "/opt/conda/lib/python3.9/site-packages/transformers/integrations/tensor_parallel.py", line 465, in __init__ 21 May 2025 11:50:41 | polyaxon-main | self.input_layouts = (input_layouts or Replicate(),) 21 May 2025 11:50:41 | polyaxon-main | NameError: name 'Replicate' is not defined The issue gets fixed when using the last stable release. ### Who can help? _No response_ ### Information - [ ] The official example scripts - [ ] My own modified scripts ### Tasks - [ ] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...) - [ ] My own task or dataset (give details below) ### Reproduction from sentence_transformers import SentenceTransformer ### Expected behavior No import error.
{ "login": "ArthurZucker", "id": 48595927, "node_id": "MDQ6VXNlcjQ4NTk1OTI3", "avatar_url": "https://avatars.githubusercontent.com/u/48595927?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ArthurZucker", "html_url": "https://github.com/ArthurZucker", "followers_url": "https://api.github.com/users/ArthurZucker/followers", "following_url": "https://api.github.com/users/ArthurZucker/following{/other_user}", "gists_url": "https://api.github.com/users/ArthurZucker/gists{/gist_id}", "starred_url": "https://api.github.com/users/ArthurZucker/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ArthurZucker/subscriptions", "organizations_url": "https://api.github.com/users/ArthurZucker/orgs", "repos_url": "https://api.github.com/users/ArthurZucker/repos", "events_url": "https://api.github.com/users/ArthurZucker/events{/privacy}", "received_events_url": "https://api.github.com/users/ArthurZucker/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38269/reactions", "total_count": 15, "+1": 15, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38269/timeline
null
completed
{ "total": 0, "completed": 0, "percent_completed": 0 }
{ "blocked_by": 0, "total_blocked_by": 0, "blocking": 0, "total_blocking": 0 }
false
true
https://api.github.com/repos/huggingface/transformers/issues/38268
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38268/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38268/comments
https://api.github.com/repos/huggingface/transformers/issues/38268/events
https://github.com/huggingface/transformers/issues/38268
3,081,045,733
I_kwDOCUB6oc63pQbl
38,268
Group beam search with sampling?
{ "login": "adrian-valente", "id": 19488251, "node_id": "MDQ6VXNlcjE5NDg4MjUx", "avatar_url": "https://avatars.githubusercontent.com/u/19488251?v=4", "gravatar_id": "", "url": "https://api.github.com/users/adrian-valente", "html_url": "https://github.com/adrian-valente", "followers_url": "https://api.github.com/users/adrian-valente/followers", "following_url": "https://api.github.com/users/adrian-valente/following{/other_user}", "gists_url": "https://api.github.com/users/adrian-valente/gists{/gist_id}", "starred_url": "https://api.github.com/users/adrian-valente/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/adrian-valente/subscriptions", "organizations_url": "https://api.github.com/users/adrian-valente/orgs", "repos_url": "https://api.github.com/users/adrian-valente/repos", "events_url": "https://api.github.com/users/adrian-valente/events{/privacy}", "received_events_url": "https://api.github.com/users/adrian-valente/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 2648621985, "node_id": "MDU6TGFiZWwyNjQ4NjIxOTg1", "url": "https://api.github.com/repos/huggingface/transformers/labels/Feature%20request", "name": "Feature request", "color": "FBCA04", "default": false, "description": "Request for a new feature" } ]
open
false
null
[]
null
[]
2025-05-21T18:08:59
2025-06-06T18:11:13
null
NONE
null
null
null
null
### Feature request In the current generation code, group beam search is necessarily greedy. From a theoretical point of view, it is not very clear why that should be the case, since the diversity penalty is applied on the logits anyway, yielding a full distribution from which sampling can still be performed. ### Motivation I think there is a reasonable use case for such a feature: diversity beam search is very useful in particular for modalities like biological sequences which increasingly use the transformers library, but I could see it be useful as well for natural language or code, to generate diverse paths without falling to the drawbacks of greedy generation. From a more abstract point of view it is also seemingly unjustified to allow sampling for standard beam search and not for diversity beam search. ### Your contribution I am aware of the work in #30810 so don't want to disrupt but would be happy to look into it.
null
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38268/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38268/timeline
null
null
{ "total": 0, "completed": 0, "percent_completed": 0 }
{ "blocked_by": 0, "total_blocked_by": 0, "blocking": 0, "total_blocking": 0 }
false
false
https://api.github.com/repos/huggingface/transformers/issues/38267
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38267/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38267/comments
https://api.github.com/repos/huggingface/transformers/issues/38267/events
https://github.com/huggingface/transformers/issues/38267
3,080,889,712
I_kwDOCUB6oc63oqVw
38,267
Add support for BAGEL from ByteDance
{ "login": "Shakib-IO", "id": 65369990, "node_id": "MDQ6VXNlcjY1MzY5OTkw", "avatar_url": "https://avatars.githubusercontent.com/u/65369990?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Shakib-IO", "html_url": "https://github.com/Shakib-IO", "followers_url": "https://api.github.com/users/Shakib-IO/followers", "following_url": "https://api.github.com/users/Shakib-IO/following{/other_user}", "gists_url": "https://api.github.com/users/Shakib-IO/gists{/gist_id}", "starred_url": "https://api.github.com/users/Shakib-IO/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Shakib-IO/subscriptions", "organizations_url": "https://api.github.com/users/Shakib-IO/orgs", "repos_url": "https://api.github.com/users/Shakib-IO/repos", "events_url": "https://api.github.com/users/Shakib-IO/events{/privacy}", "received_events_url": "https://api.github.com/users/Shakib-IO/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1843244711, "node_id": "MDU6TGFiZWwxODQzMjQ0NzEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/New%20model", "name": "New model", "color": "fbca04", "default": false, "description": "" } ]
open
false
null
[]
null
[]
2025-05-21T17:02:43
2025-10-15T16:05:46
null
CONTRIBUTOR
null
null
null
null
### Model description ### Model description ByteDance recently released a multimodal understanding and generation model. While the code and weights have been made publicly available, the code requires significant formatting and cleaning to align with the standards of the Hugging Face Transformers library. **BAGEL** BAGEL, an open‑source multimodal foundation model with 7B active parameters (14B total) trained on large‑scale interleaved multimodal data. BAGEL outperforms the current top‑tier open‑source VLMs like Qwen2.5-VL and InternVL-2.5 on standard multimodal understanding leaderboards, and delivers text‑to‑image quality that is competitive with strong specialist generators such as SD3. Moreover, BAGEL demonstrates superior qualitative results in classical image‑editing scenarios than the leading open-source models. More importantly, it extends to free-form visual manipulation, multiview synthesis, and world navigation, capabilities that constitute "world-modeling" tasks beyond the scope of previous image-editing models. The figure below showcases BAGEL's qualitative performance. ### Open source status - [x] The model implementation is available - [x] The model weights are available ### Provide useful links for the implementation Research Paper: https://arxiv.org/pdf/2505.14683 Authors: Chaorui Deng, Deyao Zhu, Kunchang Li, et al. Implementation: - [ByteDance-Seed/BAGLE](https://github.com/bytedance-seed/BAGEL) Model Weights: - [ByteDance-Seed/BAGEL](https://huggingface.co/ByteDance-Seed/BAGEL-7B-MoT)
null
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38267/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38267/timeline
null
null
{ "total": 0, "completed": 0, "percent_completed": 0 }
{ "blocked_by": 0, "total_blocked_by": 0, "blocking": 0, "total_blocking": 0 }
false
false
https://api.github.com/repos/huggingface/transformers/issues/38266
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38266/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38266/comments
https://api.github.com/repos/huggingface/transformers/issues/38266/events
https://github.com/huggingface/transformers/pull/38266
3,080,760,578
PR_kwDOCUB6oc6XFyC1
38,266
[whisper] move processor test into processor test file 🧹
{ "login": "gante", "id": 12240844, "node_id": "MDQ6VXNlcjEyMjQwODQ0", "avatar_url": "https://avatars.githubusercontent.com/u/12240844?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gante", "html_url": "https://github.com/gante", "followers_url": "https://api.github.com/users/gante/followers", "following_url": "https://api.github.com/users/gante/following{/other_user}", "gists_url": "https://api.github.com/users/gante/gists{/gist_id}", "starred_url": "https://api.github.com/users/gante/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gante/subscriptions", "organizations_url": "https://api.github.com/users/gante/orgs", "repos_url": "https://api.github.com/users/gante/repos", "events_url": "https://api.github.com/users/gante/events{/privacy}", "received_events_url": "https://api.github.com/users/gante/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-21T16:07:19
2025-05-22T09:07:15
2025-05-22T09:07:11
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38266", "html_url": "https://github.com/huggingface/transformers/pull/38266", "diff_url": "https://github.com/huggingface/transformers/pull/38266.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38266.patch", "merged_at": "2025-05-22T09:07:11" }
# What does this PR do? Cleanup PR: moves a whisper processor test from the ASR pipeline test file to the whisper processor test file. In the process, it cleans up unused code from the library. Some context: this was originally an ASR test because it used logic that was present in the ASR pipeline (`_find_timestamp_sequence`). However, in [this PR](https://github.com/huggingface/transformers/pull/21427), `_find_timestamp_sequence` stops being used by the pipeline.
{ "login": "gante", "id": 12240844, "node_id": "MDQ6VXNlcjEyMjQwODQ0", "avatar_url": "https://avatars.githubusercontent.com/u/12240844?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gante", "html_url": "https://github.com/gante", "followers_url": "https://api.github.com/users/gante/followers", "following_url": "https://api.github.com/users/gante/following{/other_user}", "gists_url": "https://api.github.com/users/gante/gists{/gist_id}", "starred_url": "https://api.github.com/users/gante/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gante/subscriptions", "organizations_url": "https://api.github.com/users/gante/orgs", "repos_url": "https://api.github.com/users/gante/repos", "events_url": "https://api.github.com/users/gante/events{/privacy}", "received_events_url": "https://api.github.com/users/gante/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38266/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38266/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38265
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38265/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38265/comments
https://api.github.com/repos/huggingface/transformers/issues/38265/events
https://github.com/huggingface/transformers/pull/38265
3,080,717,268
PR_kwDOCUB6oc6XFog6
38,265
[`WIP`][`Bert`] Attention Refactor for Bert-based Models
{ "login": "vasqu", "id": 73884904, "node_id": "MDQ6VXNlcjczODg0OTA0", "avatar_url": "https://avatars.githubusercontent.com/u/73884904?v=4", "gravatar_id": "", "url": "https://api.github.com/users/vasqu", "html_url": "https://github.com/vasqu", "followers_url": "https://api.github.com/users/vasqu/followers", "following_url": "https://api.github.com/users/vasqu/following{/other_user}", "gists_url": "https://api.github.com/users/vasqu/gists{/gist_id}", "starred_url": "https://api.github.com/users/vasqu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/vasqu/subscriptions", "organizations_url": "https://api.github.com/users/vasqu/orgs", "repos_url": "https://api.github.com/users/vasqu/repos", "events_url": "https://api.github.com/users/vasqu/events{/privacy}", "received_events_url": "https://api.github.com/users/vasqu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-21T15:51:19
2025-06-27T10:14:33
2025-05-21T15:51:40
CONTRIBUTOR
null
null
true
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38265", "html_url": "https://github.com/huggingface/transformers/pull/38265", "diff_url": "https://github.com/huggingface/transformers/pull/38265.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38265.patch", "merged_at": null }
Follow up to #38108 (should not be merged before that PR)
{ "login": "vasqu", "id": 73884904, "node_id": "MDQ6VXNlcjczODg0OTA0", "avatar_url": "https://avatars.githubusercontent.com/u/73884904?v=4", "gravatar_id": "", "url": "https://api.github.com/users/vasqu", "html_url": "https://github.com/vasqu", "followers_url": "https://api.github.com/users/vasqu/followers", "following_url": "https://api.github.com/users/vasqu/following{/other_user}", "gists_url": "https://api.github.com/users/vasqu/gists{/gist_id}", "starred_url": "https://api.github.com/users/vasqu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/vasqu/subscriptions", "organizations_url": "https://api.github.com/users/vasqu/orgs", "repos_url": "https://api.github.com/users/vasqu/repos", "events_url": "https://api.github.com/users/vasqu/events{/privacy}", "received_events_url": "https://api.github.com/users/vasqu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38265/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38265/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38264
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38264/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38264/comments
https://api.github.com/repos/huggingface/transformers/issues/38264/events
https://github.com/huggingface/transformers/pull/38264
3,080,660,225
PR_kwDOCUB6oc6XFchW
38,264
Fix convert_internvl_weights_to_hf.py to support local paths
{ "login": "xvyv99", "id": 64140045, "node_id": "MDQ6VXNlcjY0MTQwMDQ1", "avatar_url": "https://avatars.githubusercontent.com/u/64140045?v=4", "gravatar_id": "", "url": "https://api.github.com/users/xvyv99", "html_url": "https://github.com/xvyv99", "followers_url": "https://api.github.com/users/xvyv99/followers", "following_url": "https://api.github.com/users/xvyv99/following{/other_user}", "gists_url": "https://api.github.com/users/xvyv99/gists{/gist_id}", "starred_url": "https://api.github.com/users/xvyv99/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/xvyv99/subscriptions", "organizations_url": "https://api.github.com/users/xvyv99/orgs", "repos_url": "https://api.github.com/users/xvyv99/repos", "events_url": "https://api.github.com/users/xvyv99/events{/privacy}", "received_events_url": "https://api.github.com/users/xvyv99/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-21T15:33:55
2025-07-12T00:16:31
2025-05-30T12:56:32
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38264", "html_url": "https://github.com/huggingface/transformers/pull/38264", "diff_url": "https://github.com/huggingface/transformers/pull/38264.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38264.patch", "merged_at": "2025-05-30T12:56:32" }
# What does this PR do? This PR includes one improvements to the convert_internvl_weights_to_hf.py script for converting InternVL models: - Allows loading model weights directly from a local path, enabling conversion without requiring remote downloads. This change has been tested and verified on the InternVL2_5-1B, InternVL3-1B model. Fixes #38200 ## Before submitting - [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [x] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request), Pull Request section? - [ ] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case. - [ ] Did you make sure to update the documentation with your changes? Here are the [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation). - [ ] Did you write any new necessary tests?
{ "login": "Cyrilvallez", "id": 71554963, "node_id": "MDQ6VXNlcjcxNTU0OTYz", "avatar_url": "https://avatars.githubusercontent.com/u/71554963?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Cyrilvallez", "html_url": "https://github.com/Cyrilvallez", "followers_url": "https://api.github.com/users/Cyrilvallez/followers", "following_url": "https://api.github.com/users/Cyrilvallez/following{/other_user}", "gists_url": "https://api.github.com/users/Cyrilvallez/gists{/gist_id}", "starred_url": "https://api.github.com/users/Cyrilvallez/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Cyrilvallez/subscriptions", "organizations_url": "https://api.github.com/users/Cyrilvallez/orgs", "repos_url": "https://api.github.com/users/Cyrilvallez/repos", "events_url": "https://api.github.com/users/Cyrilvallez/events{/privacy}", "received_events_url": "https://api.github.com/users/Cyrilvallez/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38264/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38264/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38263
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38263/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38263/comments
https://api.github.com/repos/huggingface/transformers/issues/38263/events
https://github.com/huggingface/transformers/issues/38263
3,080,648,876
I_kwDOCUB6oc63nvis
38,263
release 4.52.2: Roberta model code broken on torch 2.4
{ "login": "richard-vogl", "id": 13015421, "node_id": "MDQ6VXNlcjEzMDE1NDIx", "avatar_url": "https://avatars.githubusercontent.com/u/13015421?v=4", "gravatar_id": "", "url": "https://api.github.com/users/richard-vogl", "html_url": "https://github.com/richard-vogl", "followers_url": "https://api.github.com/users/richard-vogl/followers", "following_url": "https://api.github.com/users/richard-vogl/following{/other_user}", "gists_url": "https://api.github.com/users/richard-vogl/gists{/gist_id}", "starred_url": "https://api.github.com/users/richard-vogl/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/richard-vogl/subscriptions", "organizations_url": "https://api.github.com/users/richard-vogl/orgs", "repos_url": "https://api.github.com/users/richard-vogl/repos", "events_url": "https://api.github.com/users/richard-vogl/events{/privacy}", "received_events_url": "https://api.github.com/users/richard-vogl/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 3817266200, "node_id": "MDU6TGFiZWwzODE3MjY2MjAw", "url": "https://api.github.com/repos/huggingface/transformers/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": null } ]
closed
false
null
[]
null
[]
2025-05-21T15:30:32
2025-05-23T17:39:27
2025-05-23T17:39:26
NONE
null
null
null
null
### System Info - `transformers` version: 4.52.1 (the problem occurs on `4.52.2`, but when i ran `transformers env,` I get the same error!) - Platform: Linux-6.8.0-1026-gcp-x86_64-with-glibc2.35 - Python version: 3.11.0rc1 - Huggingface_hub version: 0.31.4 - Safetensors version: 0.5.3 - Accelerate version: not installed - Accelerate config: not found - DeepSpeed version: not installed - PyTorch version (GPU?): 2.4.0+cu121 (True) - Tensorflow version (GPU?): not installed (NA) - Flax version (CPU?/GPU?/TPU?): not installed (NA) - Jax version: not installed - JaxLib version: not installed - Using distributed or parallel set-up in script?: yes (lightning) - Using GPU in script?: yes - GPU type: NVIDIA L4 ### Who can help? @ArthurZucker ### Information - [ ] The official example scripts - [x] My own modified scripts ### Tasks - [x] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...) - [ ] My own task or dataset (give details below) ### Reproduction Using torch 2.4 with transformers 4.52.2, when loading a RoBerta model, the following exception occurs. actually, just running `transformers env` in the shell, also produces the same error! ``` from transformers import BertModel, RobertaModel, BartModel <frozen importlib._bootstrap>:1231: in _handle_fromlist ??? ../venv/lib/python3.11/site-packages/transformers/utils/import_utils.py:2045: in __getattr__ module = self._get_module(self._class_to_module[name]) ../venv/lib/python3.11/site-packages/transformers/utils/import_utils.py:2075: in _get_module raise e ../venv/lib/python3.11/site-packages/transformers/utils/import_utils.py:2073: in _get_module return importlib.import_module("." + module_name, self.__name__) /usr/lib/python3.11/importlib/__init__.py:126: in import_module return _bootstrap._gcd_import(name[level:], package, level) ../venv/lib/python3.11/site-packages/transformers/models/bert/modeling_bert.py:44: in <module> from ...modeling_utils import PreTrainedModel ../venv/lib/python3.11/site-packages/transformers/modeling_utils.py:64: in <module> from .integrations.tensor_parallel import ( ../venv/lib/python3.11/site-packages/transformers/integrations/tensor_parallel.py:723: in <module> class ParallelInterface(MutableMapping): ../venv/lib/python3.11/site-packages/transformers/integrations/tensor_parallel.py:733: in ParallelInterface "colwise": ColwiseParallel(), ../venv/lib/python3.11/site-packages/transformers/integrations/tensor_parallel.py:465: in __init__ self.input_layouts = (input_layouts or Replicate(),) E NameError: name 'Replicate' is not defined ``` This worked until version 4.52.1 Interestingly, `Replicate` (which is only imported for `torch >= 2.5`) is already used in `__init__` in 4.52.1, so I assume `transformers.integrations.tensor_parallel.ColwiseParallel` shouldn't be used with `torch <2.5` but not sure where the root cause for that could be. ### Expected behavior No exception should be thrown when loading the model.
{ "login": "ArthurZucker", "id": 48595927, "node_id": "MDQ6VXNlcjQ4NTk1OTI3", "avatar_url": "https://avatars.githubusercontent.com/u/48595927?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ArthurZucker", "html_url": "https://github.com/ArthurZucker", "followers_url": "https://api.github.com/users/ArthurZucker/followers", "following_url": "https://api.github.com/users/ArthurZucker/following{/other_user}", "gists_url": "https://api.github.com/users/ArthurZucker/gists{/gist_id}", "starred_url": "https://api.github.com/users/ArthurZucker/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ArthurZucker/subscriptions", "organizations_url": "https://api.github.com/users/ArthurZucker/orgs", "repos_url": "https://api.github.com/users/ArthurZucker/repos", "events_url": "https://api.github.com/users/ArthurZucker/events{/privacy}", "received_events_url": "https://api.github.com/users/ArthurZucker/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38263/reactions", "total_count": 6, "+1": 6, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38263/timeline
null
completed
{ "total": 0, "completed": 0, "percent_completed": 0 }
{ "blocked_by": 0, "total_blocked_by": 0, "blocking": 0, "total_blocking": 0 }
false
true
https://api.github.com/repos/huggingface/transformers/issues/38262
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38262/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38262/comments
https://api.github.com/repos/huggingface/transformers/issues/38262/events
https://github.com/huggingface/transformers/pull/38262
3,080,575,075
PR_kwDOCUB6oc6XFJcO
38,262
Protect ParallelInterface
{ "login": "ArthurZucker", "id": 48595927, "node_id": "MDQ6VXNlcjQ4NTk1OTI3", "avatar_url": "https://avatars.githubusercontent.com/u/48595927?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ArthurZucker", "html_url": "https://github.com/ArthurZucker", "followers_url": "https://api.github.com/users/ArthurZucker/followers", "following_url": "https://api.github.com/users/ArthurZucker/following{/other_user}", "gists_url": "https://api.github.com/users/ArthurZucker/gists{/gist_id}", "starred_url": "https://api.github.com/users/ArthurZucker/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ArthurZucker/subscriptions", "organizations_url": "https://api.github.com/users/ArthurZucker/orgs", "repos_url": "https://api.github.com/users/ArthurZucker/repos", "events_url": "https://api.github.com/users/ArthurZucker/events{/privacy}", "received_events_url": "https://api.github.com/users/ArthurZucker/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-21T15:10:47
2025-05-21T15:45:39
2025-05-21T15:45:38
COLLABORATOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38262", "html_url": "https://github.com/huggingface/transformers/pull/38262", "diff_url": "https://github.com/huggingface/transformers/pull/38262.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38262.patch", "merged_at": "2025-05-21T15:45:38" }
# What does this PR do?
{ "login": "ArthurZucker", "id": 48595927, "node_id": "MDQ6VXNlcjQ4NTk1OTI3", "avatar_url": "https://avatars.githubusercontent.com/u/48595927?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ArthurZucker", "html_url": "https://github.com/ArthurZucker", "followers_url": "https://api.github.com/users/ArthurZucker/followers", "following_url": "https://api.github.com/users/ArthurZucker/following{/other_user}", "gists_url": "https://api.github.com/users/ArthurZucker/gists{/gist_id}", "starred_url": "https://api.github.com/users/ArthurZucker/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ArthurZucker/subscriptions", "organizations_url": "https://api.github.com/users/ArthurZucker/orgs", "repos_url": "https://api.github.com/users/ArthurZucker/repos", "events_url": "https://api.github.com/users/ArthurZucker/events{/privacy}", "received_events_url": "https://api.github.com/users/ArthurZucker/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38262/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38262/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38261
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38261/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38261/comments
https://api.github.com/repos/huggingface/transformers/issues/38261/events
https://github.com/huggingface/transformers/pull/38261
3,080,567,595
PR_kwDOCUB6oc6XFHy5
38,261
Update CI Docker base image for AMD tests
{ "login": "ahadnagy", "id": 21314428, "node_id": "MDQ6VXNlcjIxMzE0NDI4", "avatar_url": "https://avatars.githubusercontent.com/u/21314428?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ahadnagy", "html_url": "https://github.com/ahadnagy", "followers_url": "https://api.github.com/users/ahadnagy/followers", "following_url": "https://api.github.com/users/ahadnagy/following{/other_user}", "gists_url": "https://api.github.com/users/ahadnagy/gists{/gist_id}", "starred_url": "https://api.github.com/users/ahadnagy/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ahadnagy/subscriptions", "organizations_url": "https://api.github.com/users/ahadnagy/orgs", "repos_url": "https://api.github.com/users/ahadnagy/repos", "events_url": "https://api.github.com/users/ahadnagy/events{/privacy}", "received_events_url": "https://api.github.com/users/ahadnagy/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-21T15:08:31
2025-05-22T14:38:40
2025-05-22T14:38:40
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38261", "html_url": "https://github.com/huggingface/transformers/pull/38261", "diff_url": "https://github.com/huggingface/transformers/pull/38261.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38261.patch", "merged_at": "2025-05-22T14:38:40" }
# What does this PR do? This PR updates AMD CI image to use the latest PyTorch base image. This fix is required for the MI300 tests as PyTorch falls back to CPU on older versions. ## Before submitting - [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [ ] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request), Pull Request section? - [ ] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case. - [ ] Did you make sure to update the documentation with your changes? Here are the [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation). - [ ] Did you write any new necessary tests? ## Who can review? Transformers CI folks. <!-- Your PR will be replied to more quickly if you can figure out the right person to tag with @ If you know how to use git blame, that is the easiest way, otherwise, here is a rough guide of **who to tag**. Please tag fewer than 3 people. Models: - text models: @ArthurZucker - vision models: @amyeroberts, @qubvel - speech models: @eustlb - graph models: @clefourrier Library: - flax: @gante and @Rocketknight1 - generate: @zucchini-nlp (visual-language models) or @gante (all others) - pipelines: @Rocketknight1 - tensorflow: @gante and @Rocketknight1 - tokenizers: @ArthurZucker - trainer: @zach-huggingface and @SunMarc - chat templates: @Rocketknight1 Integrations: - deepspeed: HF Trainer/Accelerate: @SunMarc @zach-huggingface - ray/raytune: @richardliaw, @amogkam - Big Model Inference: @SunMarc - quantization (bitsandbytes, autogpt): @SunMarc @MekkCyber Documentation: @stevhliu HF projects: - accelerate: [different repo](https://github.com/huggingface/accelerate) - datasets: [different repo](https://github.com/huggingface/datasets) - diffusers: [different repo](https://github.com/huggingface/diffusers) - rust tokenizers: [different repo](https://github.com/huggingface/tokenizers) Maintained examples (not research project or legacy): - Flax: @Rocketknight1 - PyTorch: See Models above and tag the person corresponding to the modality of the example. - TensorFlow: @Rocketknight1 -->
{ "login": "ydshieh", "id": 2521628, "node_id": "MDQ6VXNlcjI1MjE2Mjg=", "avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ydshieh", "html_url": "https://github.com/ydshieh", "followers_url": "https://api.github.com/users/ydshieh/followers", "following_url": "https://api.github.com/users/ydshieh/following{/other_user}", "gists_url": "https://api.github.com/users/ydshieh/gists{/gist_id}", "starred_url": "https://api.github.com/users/ydshieh/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ydshieh/subscriptions", "organizations_url": "https://api.github.com/users/ydshieh/orgs", "repos_url": "https://api.github.com/users/ydshieh/repos", "events_url": "https://api.github.com/users/ydshieh/events{/privacy}", "received_events_url": "https://api.github.com/users/ydshieh/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38261/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38261/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38260
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38260/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38260/comments
https://api.github.com/repos/huggingface/transformers/issues/38260/events
https://github.com/huggingface/transformers/pull/38260
3,080,550,285
PR_kwDOCUB6oc6XFD90
38,260
Falcon-H1 - Fix auto_docstring and add can_return_tuple decorator
{ "login": "yonigozlan", "id": 74535834, "node_id": "MDQ6VXNlcjc0NTM1ODM0", "avatar_url": "https://avatars.githubusercontent.com/u/74535834?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yonigozlan", "html_url": "https://github.com/yonigozlan", "followers_url": "https://api.github.com/users/yonigozlan/followers", "following_url": "https://api.github.com/users/yonigozlan/following{/other_user}", "gists_url": "https://api.github.com/users/yonigozlan/gists{/gist_id}", "starred_url": "https://api.github.com/users/yonigozlan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yonigozlan/subscriptions", "organizations_url": "https://api.github.com/users/yonigozlan/orgs", "repos_url": "https://api.github.com/users/yonigozlan/repos", "events_url": "https://api.github.com/users/yonigozlan/events{/privacy}", "received_events_url": "https://api.github.com/users/yonigozlan/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-21T15:03:11
2025-05-27T20:18:06
2025-05-27T20:18:05
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38260", "html_url": "https://github.com/huggingface/transformers/pull/38260", "diff_url": "https://github.com/huggingface/transformers/pull/38260.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38260.patch", "merged_at": "2025-05-27T20:18:05" }
# What does this PR do? Remove unnecessary decorators and docstring in modular falcon h1, use can_return_tuple decorators
{ "login": "yonigozlan", "id": 74535834, "node_id": "MDQ6VXNlcjc0NTM1ODM0", "avatar_url": "https://avatars.githubusercontent.com/u/74535834?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yonigozlan", "html_url": "https://github.com/yonigozlan", "followers_url": "https://api.github.com/users/yonigozlan/followers", "following_url": "https://api.github.com/users/yonigozlan/following{/other_user}", "gists_url": "https://api.github.com/users/yonigozlan/gists{/gist_id}", "starred_url": "https://api.github.com/users/yonigozlan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yonigozlan/subscriptions", "organizations_url": "https://api.github.com/users/yonigozlan/orgs", "repos_url": "https://api.github.com/users/yonigozlan/repos", "events_url": "https://api.github.com/users/yonigozlan/events{/privacy}", "received_events_url": "https://api.github.com/users/yonigozlan/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38260/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38260/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38259
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38259/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38259/comments
https://api.github.com/repos/huggingface/transformers/issues/38259/events
https://github.com/huggingface/transformers/pull/38259
3,080,451,166
PR_kwDOCUB6oc6XEuVq
38,259
[Whisper + beam search] fix usage of `beam_indices`
{ "login": "gante", "id": 12240844, "node_id": "MDQ6VXNlcjEyMjQwODQ0", "avatar_url": "https://avatars.githubusercontent.com/u/12240844?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gante", "html_url": "https://github.com/gante", "followers_url": "https://api.github.com/users/gante/followers", "following_url": "https://api.github.com/users/gante/following{/other_user}", "gists_url": "https://api.github.com/users/gante/gists{/gist_id}", "starred_url": "https://api.github.com/users/gante/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gante/subscriptions", "organizations_url": "https://api.github.com/users/gante/orgs", "repos_url": "https://api.github.com/users/gante/repos", "events_url": "https://api.github.com/users/gante/events{/privacy}", "received_events_url": "https://api.github.com/users/gante/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-21T14:32:10
2025-05-23T10:05:44
2025-05-23T10:05:44
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38259", "html_url": "https://github.com/huggingface/transformers/pull/38259", "diff_url": "https://github.com/huggingface/transformers/pull/38259.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38259.patch", "merged_at": "2025-05-23T10:05:44" }
# What does this PR do? Fixes the shape issues reported in #36093, which have been around since [the code was added](https://github.com/huggingface/transformers/pull/33665) 👀 . It doesn't fix the quality of word timestamp outputs (see e.g. #36632), but rather how we gather the cross attentions from the right beams with beam search, which was broken. `test_tiny_token_timestamp_batch_generation` is a test that has the same pattern, beam search + timestamps, and is failing on `main` with the same exception as reported in #36093. This PR does NOT fix that test, but allows the test to move past the shape exception until the output quality checks, which are broken 🙃
{ "login": "gante", "id": 12240844, "node_id": "MDQ6VXNlcjEyMjQwODQ0", "avatar_url": "https://avatars.githubusercontent.com/u/12240844?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gante", "html_url": "https://github.com/gante", "followers_url": "https://api.github.com/users/gante/followers", "following_url": "https://api.github.com/users/gante/following{/other_user}", "gists_url": "https://api.github.com/users/gante/gists{/gist_id}", "starred_url": "https://api.github.com/users/gante/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gante/subscriptions", "organizations_url": "https://api.github.com/users/gante/orgs", "repos_url": "https://api.github.com/users/gante/repos", "events_url": "https://api.github.com/users/gante/events{/privacy}", "received_events_url": "https://api.github.com/users/gante/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38259/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38259/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38258
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38258/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38258/comments
https://api.github.com/repos/huggingface/transformers/issues/38258/events
https://github.com/huggingface/transformers/issues/38258
3,079,689,042
I_kwDOCUB6oc63kFNS
38,258
AutoConfig has potential issue with composite config.
{ "login": "Tavish9", "id": 73541181, "node_id": "MDQ6VXNlcjczNTQxMTgx", "avatar_url": "https://avatars.githubusercontent.com/u/73541181?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Tavish9", "html_url": "https://github.com/Tavish9", "followers_url": "https://api.github.com/users/Tavish9/followers", "following_url": "https://api.github.com/users/Tavish9/following{/other_user}", "gists_url": "https://api.github.com/users/Tavish9/gists{/gist_id}", "starred_url": "https://api.github.com/users/Tavish9/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Tavish9/subscriptions", "organizations_url": "https://api.github.com/users/Tavish9/orgs", "repos_url": "https://api.github.com/users/Tavish9/repos", "events_url": "https://api.github.com/users/Tavish9/events{/privacy}", "received_events_url": "https://api.github.com/users/Tavish9/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 2796628563, "node_id": "MDU6TGFiZWwyNzk2NjI4NTYz", "url": "https://api.github.com/repos/huggingface/transformers/labels/WIP", "name": "WIP", "color": "234C99", "default": false, "description": "Label your PR/Issue with WIP for some long outstanding Issues/PRs that are work in progress" }, { "id": 3817266200, "node_id": "MDU6TGFiZWwzODE3MjY2MjAw", "url": "https://api.github.com/repos/huggingface/transformers/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": null } ]
closed
false
{ "login": "zucchini-nlp", "id": 100715397, "node_id": "U_kgDOBgDLhQ", "avatar_url": "https://avatars.githubusercontent.com/u/100715397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zucchini-nlp", "html_url": "https://github.com/zucchini-nlp", "followers_url": "https://api.github.com/users/zucchini-nlp/followers", "following_url": "https://api.github.com/users/zucchini-nlp/following{/other_user}", "gists_url": "https://api.github.com/users/zucchini-nlp/gists{/gist_id}", "starred_url": "https://api.github.com/users/zucchini-nlp/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zucchini-nlp/subscriptions", "organizations_url": "https://api.github.com/users/zucchini-nlp/orgs", "repos_url": "https://api.github.com/users/zucchini-nlp/repos", "events_url": "https://api.github.com/users/zucchini-nlp/events{/privacy}", "received_events_url": "https://api.github.com/users/zucchini-nlp/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "zucchini-nlp", "id": 100715397, "node_id": "U_kgDOBgDLhQ", "avatar_url": "https://avatars.githubusercontent.com/u/100715397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zucchini-nlp", "html_url": "https://github.com/zucchini-nlp", "followers_url": "https://api.github.com/users/zucchini-nlp/followers", "following_url": "https://api.github.com/users/zucchini-nlp/following{/other_user}", "gists_url": "https://api.github.com/users/zucchini-nlp/gists{/gist_id}", "starred_url": "https://api.github.com/users/zucchini-nlp/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zucchini-nlp/subscriptions", "organizations_url": "https://api.github.com/users/zucchini-nlp/orgs", "repos_url": "https://api.github.com/users/zucchini-nlp/repos", "events_url": "https://api.github.com/users/zucchini-nlp/events{/privacy}", "received_events_url": "https://api.github.com/users/zucchini-nlp/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[]
2025-05-21T10:09:31
2025-08-22T11:31:26
2025-08-22T11:31:26
CONTRIBUTOR
null
null
null
null
### System Info - `transformers` version: 4.52.0.dev0 - Platform: Linux-5.10.134-008.12.kangaroo.al8.x86_64-x86_64-with-glibc2.35 - Python version: 3.10.17 - Huggingface_hub version: 0.31.1 - Safetensors version: 0.5.3 - Accelerate version: 1.6.0 - Accelerate config: not found - DeepSpeed version: 0.16.7 - PyTorch version (GPU?): 2.6.0+cu124 (True) - Tensorflow version (GPU?): not installed (NA) - Flax version (CPU?/GPU?/TPU?): not installed (NA) - Jax version: not installed - JaxLib version: not installed - Using distributed or parallel set-up in script?: <fill in> - Using GPU in script?: <fill in> - GPU type: NVIDIA A100-SXM4-80GB ### Who can help? @zucchini-nlp ### Information - [x] The official example scripts - [ ] My own modified scripts ### Tasks - [x] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...) - [ ] My own task or dataset (give details below) ### Reproduction For model which has composite config like `qwen2_5_vl`, `llava_onevision` https://github.com/huggingface/transformers/blob/101b3fa4ea1cfd66e72a73a0f505108454c24cce/src/transformers/models/qwen2_5_vl/configuration_qwen2_5_vl.py#L293-L294 The following code would return `kwargs={'use_cache': True}` ```python config, kwargs = AutoConfig.from_pretrained("Qwen/Qwen2.5-Omni-7B", return_unused_kwargs=True, use_cache=True) ``` So, if we use `AutoModel` or `AutoModelForCausalLM`, etc to load these models, we would get ```bash TypeError: Qwen2_5OmniThinkerForConditionalGeneration.__init__() got an unexpected keyword argument 'use_cache' ``` This is due to the following code in https://github.com/huggingface/transformers/blob/101b3fa4ea1cfd66e72a73a0f505108454c24cce/src/transformers/models/auto/auto_factory.py#L521-L538 https://github.com/huggingface/transformers/blob/101b3fa4ea1cfd66e72a73a0f505108454c24cce/src/transformers/models/auto/auto_factory.py#L568-L573 the kwargs are passed to `PretrainedModel.from_pretrained()`, and then passed to `__init__()`, which cause the error. ### Expected behavior pass `kwargs` to `text_config` if the model has composite config
{ "login": "zucchini-nlp", "id": 100715397, "node_id": "U_kgDOBgDLhQ", "avatar_url": "https://avatars.githubusercontent.com/u/100715397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zucchini-nlp", "html_url": "https://github.com/zucchini-nlp", "followers_url": "https://api.github.com/users/zucchini-nlp/followers", "following_url": "https://api.github.com/users/zucchini-nlp/following{/other_user}", "gists_url": "https://api.github.com/users/zucchini-nlp/gists{/gist_id}", "starred_url": "https://api.github.com/users/zucchini-nlp/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zucchini-nlp/subscriptions", "organizations_url": "https://api.github.com/users/zucchini-nlp/orgs", "repos_url": "https://api.github.com/users/zucchini-nlp/repos", "events_url": "https://api.github.com/users/zucchini-nlp/events{/privacy}", "received_events_url": "https://api.github.com/users/zucchini-nlp/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38258/reactions", "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 1 }
https://api.github.com/repos/huggingface/transformers/issues/38258/timeline
null
completed
{ "total": 0, "completed": 0, "percent_completed": 0 }
{ "blocked_by": 0, "total_blocked_by": 0, "blocking": 0, "total_blocking": 0 }
false
true
https://api.github.com/repos/huggingface/transformers/issues/38257
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38257/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38257/comments
https://api.github.com/repos/huggingface/transformers/issues/38257/events
https://github.com/huggingface/transformers/pull/38257
3,079,621,368
PR_kwDOCUB6oc6XB4wH
38,257
Clearer error on import failure
{ "login": "LysandreJik", "id": 30755778, "node_id": "MDQ6VXNlcjMwNzU1Nzc4", "avatar_url": "https://avatars.githubusercontent.com/u/30755778?v=4", "gravatar_id": "", "url": "https://api.github.com/users/LysandreJik", "html_url": "https://github.com/LysandreJik", "followers_url": "https://api.github.com/users/LysandreJik/followers", "following_url": "https://api.github.com/users/LysandreJik/following{/other_user}", "gists_url": "https://api.github.com/users/LysandreJik/gists{/gist_id}", "starred_url": "https://api.github.com/users/LysandreJik/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/LysandreJik/subscriptions", "organizations_url": "https://api.github.com/users/LysandreJik/orgs", "repos_url": "https://api.github.com/users/LysandreJik/repos", "events_url": "https://api.github.com/users/LysandreJik/events{/privacy}", "received_events_url": "https://api.github.com/users/LysandreJik/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-21T09:47:14
2025-05-21T12:32:32
2025-05-21T12:32:29
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38257", "html_url": "https://github.com/huggingface/transformers/pull/38257", "diff_url": "https://github.com/huggingface/transformers/pull/38257.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38257.patch", "merged_at": "2025-05-21T12:32:29" }
The errors are often hidden deep in the stack trace otherwsie cc @Cyrilvallez @pcuenca @ArthurZucker
{ "login": "LysandreJik", "id": 30755778, "node_id": "MDQ6VXNlcjMwNzU1Nzc4", "avatar_url": "https://avatars.githubusercontent.com/u/30755778?v=4", "gravatar_id": "", "url": "https://api.github.com/users/LysandreJik", "html_url": "https://github.com/LysandreJik", "followers_url": "https://api.github.com/users/LysandreJik/followers", "following_url": "https://api.github.com/users/LysandreJik/following{/other_user}", "gists_url": "https://api.github.com/users/LysandreJik/gists{/gist_id}", "starred_url": "https://api.github.com/users/LysandreJik/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/LysandreJik/subscriptions", "organizations_url": "https://api.github.com/users/LysandreJik/orgs", "repos_url": "https://api.github.com/users/LysandreJik/repos", "events_url": "https://api.github.com/users/LysandreJik/events{/privacy}", "received_events_url": "https://api.github.com/users/LysandreJik/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38257/reactions", "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 1, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38257/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38256
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38256/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38256/comments
https://api.github.com/repos/huggingface/transformers/issues/38256/events
https://github.com/huggingface/transformers/pull/38256
3,079,519,411
PR_kwDOCUB6oc6XBibX
38,256
[Falcon H1] Fix Typo in Integration Test
{ "login": "dhiaEddineRhaiem", "id": 163106757, "node_id": "U_kgDOCbjPxQ", "avatar_url": "https://avatars.githubusercontent.com/u/163106757?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dhiaEddineRhaiem", "html_url": "https://github.com/dhiaEddineRhaiem", "followers_url": "https://api.github.com/users/dhiaEddineRhaiem/followers", "following_url": "https://api.github.com/users/dhiaEddineRhaiem/following{/other_user}", "gists_url": "https://api.github.com/users/dhiaEddineRhaiem/gists{/gist_id}", "starred_url": "https://api.github.com/users/dhiaEddineRhaiem/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dhiaEddineRhaiem/subscriptions", "organizations_url": "https://api.github.com/users/dhiaEddineRhaiem/orgs", "repos_url": "https://api.github.com/users/dhiaEddineRhaiem/repos", "events_url": "https://api.github.com/users/dhiaEddineRhaiem/events{/privacy}", "received_events_url": "https://api.github.com/users/dhiaEddineRhaiem/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-21T09:13:10
2025-05-21T09:25:26
2025-05-21T09:25:26
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38256", "html_url": "https://github.com/huggingface/transformers/pull/38256", "diff_url": "https://github.com/huggingface/transformers/pull/38256.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38256.patch", "merged_at": "2025-05-21T09:25:26" }
This PR fixes a typo in Falcon H1 integration test. @ArthurZucker
{ "login": "ArthurZucker", "id": 48595927, "node_id": "MDQ6VXNlcjQ4NTk1OTI3", "avatar_url": "https://avatars.githubusercontent.com/u/48595927?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ArthurZucker", "html_url": "https://github.com/ArthurZucker", "followers_url": "https://api.github.com/users/ArthurZucker/followers", "following_url": "https://api.github.com/users/ArthurZucker/following{/other_user}", "gists_url": "https://api.github.com/users/ArthurZucker/gists{/gist_id}", "starred_url": "https://api.github.com/users/ArthurZucker/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ArthurZucker/subscriptions", "organizations_url": "https://api.github.com/users/ArthurZucker/orgs", "repos_url": "https://api.github.com/users/ArthurZucker/repos", "events_url": "https://api.github.com/users/ArthurZucker/events{/privacy}", "received_events_url": "https://api.github.com/users/ArthurZucker/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38256/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38256/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38255
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38255/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38255/comments
https://api.github.com/repos/huggingface/transformers/issues/38255/events
https://github.com/huggingface/transformers/pull/38255
3,079,186,990
PR_kwDOCUB6oc6XAa9_
38,255
tp plan should not be NONE
{ "login": "ArthurZucker", "id": 48595927, "node_id": "MDQ6VXNlcjQ4NTk1OTI3", "avatar_url": "https://avatars.githubusercontent.com/u/48595927?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ArthurZucker", "html_url": "https://github.com/ArthurZucker", "followers_url": "https://api.github.com/users/ArthurZucker/followers", "following_url": "https://api.github.com/users/ArthurZucker/following{/other_user}", "gists_url": "https://api.github.com/users/ArthurZucker/gists{/gist_id}", "starred_url": "https://api.github.com/users/ArthurZucker/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ArthurZucker/subscriptions", "organizations_url": "https://api.github.com/users/ArthurZucker/orgs", "repos_url": "https://api.github.com/users/ArthurZucker/repos", "events_url": "https://api.github.com/users/ArthurZucker/events{/privacy}", "received_events_url": "https://api.github.com/users/ArthurZucker/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-21T07:13:29
2025-05-21T11:47:44
2025-05-21T08:22:38
COLLABORATOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38255", "html_url": "https://github.com/huggingface/transformers/pull/38255", "diff_url": "https://github.com/huggingface/transformers/pull/38255.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38255.patch", "merged_at": "2025-05-21T08:22:38" }
# What does this PR do? This PR was reverted because it was failing... 711d78d104366c16dd99ef11084c27848f7a4133
{ "login": "ArthurZucker", "id": 48595927, "node_id": "MDQ6VXNlcjQ4NTk1OTI3", "avatar_url": "https://avatars.githubusercontent.com/u/48595927?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ArthurZucker", "html_url": "https://github.com/ArthurZucker", "followers_url": "https://api.github.com/users/ArthurZucker/followers", "following_url": "https://api.github.com/users/ArthurZucker/following{/other_user}", "gists_url": "https://api.github.com/users/ArthurZucker/gists{/gist_id}", "starred_url": "https://api.github.com/users/ArthurZucker/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ArthurZucker/subscriptions", "organizations_url": "https://api.github.com/users/ArthurZucker/orgs", "repos_url": "https://api.github.com/users/ArthurZucker/repos", "events_url": "https://api.github.com/users/ArthurZucker/events{/privacy}", "received_events_url": "https://api.github.com/users/ArthurZucker/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38255/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38255/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38254
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38254/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38254/comments
https://api.github.com/repos/huggingface/transformers/issues/38254/events
https://github.com/huggingface/transformers/pull/38254
3,079,167,798
PR_kwDOCUB6oc6XAW2Q
38,254
Remove something that should have never been there
{ "login": "ArthurZucker", "id": 48595927, "node_id": "MDQ6VXNlcjQ4NTk1OTI3", "avatar_url": "https://avatars.githubusercontent.com/u/48595927?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ArthurZucker", "html_url": "https://github.com/ArthurZucker", "followers_url": "https://api.github.com/users/ArthurZucker/followers", "following_url": "https://api.github.com/users/ArthurZucker/following{/other_user}", "gists_url": "https://api.github.com/users/ArthurZucker/gists{/gist_id}", "starred_url": "https://api.github.com/users/ArthurZucker/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ArthurZucker/subscriptions", "organizations_url": "https://api.github.com/users/ArthurZucker/orgs", "repos_url": "https://api.github.com/users/ArthurZucker/repos", "events_url": "https://api.github.com/users/ArthurZucker/events{/privacy}", "received_events_url": "https://api.github.com/users/ArthurZucker/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-21T07:05:41
2025-07-16T13:22:46
2025-07-16T13:22:44
COLLABORATOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38254", "html_url": "https://github.com/huggingface/transformers/pull/38254", "diff_url": "https://github.com/huggingface/transformers/pull/38254.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38254.patch", "merged_at": "2025-07-16T13:22:44" }
# What does this PR do?
{ "login": "ArthurZucker", "id": 48595927, "node_id": "MDQ6VXNlcjQ4NTk1OTI3", "avatar_url": "https://avatars.githubusercontent.com/u/48595927?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ArthurZucker", "html_url": "https://github.com/ArthurZucker", "followers_url": "https://api.github.com/users/ArthurZucker/followers", "following_url": "https://api.github.com/users/ArthurZucker/following{/other_user}", "gists_url": "https://api.github.com/users/ArthurZucker/gists{/gist_id}", "starred_url": "https://api.github.com/users/ArthurZucker/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ArthurZucker/subscriptions", "organizations_url": "https://api.github.com/users/ArthurZucker/orgs", "repos_url": "https://api.github.com/users/ArthurZucker/repos", "events_url": "https://api.github.com/users/ArthurZucker/events{/privacy}", "received_events_url": "https://api.github.com/users/ArthurZucker/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38254/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38254/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38253
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38253/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38253/comments
https://api.github.com/repos/huggingface/transformers/issues/38253/events
https://github.com/huggingface/transformers/issues/38253
3,079,132,666
I_kwDOCUB6oc63h9X6
38,253
FEAT WANT: Dynamic quantization config for bitsandbytes
{ "login": "AaronZLT", "id": 35474496, "node_id": "MDQ6VXNlcjM1NDc0NDk2", "avatar_url": "https://avatars.githubusercontent.com/u/35474496?v=4", "gravatar_id": "", "url": "https://api.github.com/users/AaronZLT", "html_url": "https://github.com/AaronZLT", "followers_url": "https://api.github.com/users/AaronZLT/followers", "following_url": "https://api.github.com/users/AaronZLT/following{/other_user}", "gists_url": "https://api.github.com/users/AaronZLT/gists{/gist_id}", "starred_url": "https://api.github.com/users/AaronZLT/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/AaronZLT/subscriptions", "organizations_url": "https://api.github.com/users/AaronZLT/orgs", "repos_url": "https://api.github.com/users/AaronZLT/repos", "events_url": "https://api.github.com/users/AaronZLT/events{/privacy}", "received_events_url": "https://api.github.com/users/AaronZLT/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 2648621985, "node_id": "MDU6TGFiZWwyNjQ4NjIxOTg1", "url": "https://api.github.com/repos/huggingface/transformers/labels/Feature%20request", "name": "Feature request", "color": "FBCA04", "default": false, "description": "Request for a new feature" } ]
open
false
null
[]
null
[]
2025-05-21T06:51:03
2025-06-16T16:58:17
null
CONTRIBUTOR
null
null
null
null
### Feature request Will transformers support dynamic quantization config for bitsandbytes? Currently transformers support hqq dynamic quantization, via ```python q4_config = {"nbits": 4, "group_size": 64} q8_config = {"nbits": 8, "group_size": 64} quant_config = HqqConfig( dynamic_config={ "self_attn.q_proj": q4_config, "self_attn.k_proj": q4_config, "self_attn.v_proj": q4_config, "self_attn.o_proj": q4_config, "mlp.gate_proj": q8_config, "mlp.up_proj": q4_config, "mlp.down_proj": q4_config, } ) ```
null
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38253/reactions", "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 1, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38253/timeline
null
null
{ "total": 0, "completed": 0, "percent_completed": 0 }
{ "blocked_by": 0, "total_blocked_by": 0, "blocking": 0, "total_blocking": 0 }
false
false
https://api.github.com/repos/huggingface/transformers/issues/38252
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38252/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38252/comments
https://api.github.com/repos/huggingface/transformers/issues/38252/events
https://github.com/huggingface/transformers/pull/38252
3,079,111,965
PR_kwDOCUB6oc6XAKtN
38,252
refine `transformers env` output
{ "login": "yao-matrix", "id": 7245027, "node_id": "MDQ6VXNlcjcyNDUwMjc=", "avatar_url": "https://avatars.githubusercontent.com/u/7245027?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yao-matrix", "html_url": "https://github.com/yao-matrix", "followers_url": "https://api.github.com/users/yao-matrix/followers", "following_url": "https://api.github.com/users/yao-matrix/following{/other_user}", "gists_url": "https://api.github.com/users/yao-matrix/gists{/gist_id}", "starred_url": "https://api.github.com/users/yao-matrix/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yao-matrix/subscriptions", "organizations_url": "https://api.github.com/users/yao-matrix/orgs", "repos_url": "https://api.github.com/users/yao-matrix/repos", "events_url": "https://api.github.com/users/yao-matrix/events{/privacy}", "received_events_url": "https://api.github.com/users/yao-matrix/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-21T06:41:50
2025-05-22T00:19:11
2025-05-22T00:15:26
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38252", "html_url": "https://github.com/huggingface/transformers/pull/38252", "diff_url": "https://github.com/huggingface/transformers/pull/38252.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38252.patch", "merged_at": null }
@ydshieh , pls help review, thx. And one more thing is, I can see there is a [print_env.py](https://github.com/huggingface/transformers/blob/711d78d104366c16dd99ef11084c27848f7a4133/utils/print_env.py#L35) in `utils`, I am curious in which situation I should use `transformers env` and in which i should use `print_env.py`? Pls let me know your insights, thx very much.
{ "login": "yao-matrix", "id": 7245027, "node_id": "MDQ6VXNlcjcyNDUwMjc=", "avatar_url": "https://avatars.githubusercontent.com/u/7245027?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yao-matrix", "html_url": "https://github.com/yao-matrix", "followers_url": "https://api.github.com/users/yao-matrix/followers", "following_url": "https://api.github.com/users/yao-matrix/following{/other_user}", "gists_url": "https://api.github.com/users/yao-matrix/gists{/gist_id}", "starred_url": "https://api.github.com/users/yao-matrix/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yao-matrix/subscriptions", "organizations_url": "https://api.github.com/users/yao-matrix/orgs", "repos_url": "https://api.github.com/users/yao-matrix/repos", "events_url": "https://api.github.com/users/yao-matrix/events{/privacy}", "received_events_url": "https://api.github.com/users/yao-matrix/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38252/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38252/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38251
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38251/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38251/comments
https://api.github.com/repos/huggingface/transformers/issues/38251/events
https://github.com/huggingface/transformers/issues/38251
3,079,043,775
I_kwDOCUB6oc63hnq_
38,251
DTensor Import Path Changes in PyTorch 2.5 Causing Compatibility Issues
{ "login": "syog1ne", "id": 185162774, "node_id": "U_kgDOCwlcFg", "avatar_url": "https://avatars.githubusercontent.com/u/185162774?v=4", "gravatar_id": "", "url": "https://api.github.com/users/syog1ne", "html_url": "https://github.com/syog1ne", "followers_url": "https://api.github.com/users/syog1ne/followers", "following_url": "https://api.github.com/users/syog1ne/following{/other_user}", "gists_url": "https://api.github.com/users/syog1ne/gists{/gist_id}", "starred_url": "https://api.github.com/users/syog1ne/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/syog1ne/subscriptions", "organizations_url": "https://api.github.com/users/syog1ne/orgs", "repos_url": "https://api.github.com/users/syog1ne/repos", "events_url": "https://api.github.com/users/syog1ne/events{/privacy}", "received_events_url": "https://api.github.com/users/syog1ne/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 3817266200, "node_id": "MDU6TGFiZWwzODE3MjY2MjAw", "url": "https://api.github.com/repos/huggingface/transformers/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": null } ]
closed
false
null
[]
null
[]
2025-05-21T06:09:22
2025-06-02T02:23:43
2025-06-02T02:23:43
NONE
null
null
null
null
### System Info `DTensor` import was changed during Pytorch 2.5, before 2.5, it uses `from torch.distributed._tensor import DTensor`. And this broke the code, please check [src/pytorch_utils.py](https://github.com/huggingface/transformers/blame/711d78d104366c16dd99ef11084c27848f7a4133/src/transformers/pytorch_utils.py#L300C14-L300C19) also check PyTorch 2.4.x (and earlier relevant versions): DTensor is referenced from torch.distributed._tensor. See: [[GitHub - pytorch/pytorch (branch dcfa77... for v2.4)](https://github.com/pytorch/pytorch/blob/dcfa7702c3ecd8754e8a66bc49142de00c8474ee/torch/_dynamo/variables/torch.py#L563)](https://github.com/pytorch/pytorch/blob/dcfa7702c3ecd8754e8a66bc49142de00c8474ee/torch/_dynamo/variables/torch.py#L563) PyTorch 2.5.x (and later relevant versions): DTensor is referenced from torch.distributed.tensor. See: [[GitHub - pytorch/pytorch (branch cfc227... for v2.5)](https://github.com/pytorch/pytorch/blob/cfc227ad43c8a39e52463ef06029dddc00919eae/torch/_dynamo/variables/torch.py#L631)](https://github.com/pytorch/pytorch/blob/cfc227ad43c8a39e52463ef06029dddc00919eae/torch/_dynamo/variables/torch.py#L631) ### Who can help? @S1ro1 ### Information - [ x] The official example scripts - [ x] My own modified scripts ### Tasks - [x] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...) - [x] My own task or dataset (give details below) ### Reproduction Install pytorch 2.4, then run >>> from torch.distributed.tensor import DTensor will get cannot import name 'DTensor' from 'torch.distributed.tensor' This effect case when use `transformers` to save weights. ### Expected behavior Correct imported
{ "login": "syog1ne", "id": 185162774, "node_id": "U_kgDOCwlcFg", "avatar_url": "https://avatars.githubusercontent.com/u/185162774?v=4", "gravatar_id": "", "url": "https://api.github.com/users/syog1ne", "html_url": "https://github.com/syog1ne", "followers_url": "https://api.github.com/users/syog1ne/followers", "following_url": "https://api.github.com/users/syog1ne/following{/other_user}", "gists_url": "https://api.github.com/users/syog1ne/gists{/gist_id}", "starred_url": "https://api.github.com/users/syog1ne/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/syog1ne/subscriptions", "organizations_url": "https://api.github.com/users/syog1ne/orgs", "repos_url": "https://api.github.com/users/syog1ne/repos", "events_url": "https://api.github.com/users/syog1ne/events{/privacy}", "received_events_url": "https://api.github.com/users/syog1ne/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38251/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38251/timeline
null
completed
{ "total": 0, "completed": 0, "percent_completed": 0 }
{ "blocked_by": 0, "total_blocked_by": 0, "blocking": 0, "total_blocking": 0 }
false
true
https://api.github.com/repos/huggingface/transformers/issues/38250
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38250/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38250/comments
https://api.github.com/repos/huggingface/transformers/issues/38250/events
https://github.com/huggingface/transformers/pull/38250
3,079,024,641
PR_kwDOCUB6oc6W_3uo
38,250
Fix pytorch DTensor import issue.
{ "login": "syog1ne", "id": 185162774, "node_id": "U_kgDOCwlcFg", "avatar_url": "https://avatars.githubusercontent.com/u/185162774?v=4", "gravatar_id": "", "url": "https://api.github.com/users/syog1ne", "html_url": "https://github.com/syog1ne", "followers_url": "https://api.github.com/users/syog1ne/followers", "following_url": "https://api.github.com/users/syog1ne/following{/other_user}", "gists_url": "https://api.github.com/users/syog1ne/gists{/gist_id}", "starred_url": "https://api.github.com/users/syog1ne/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/syog1ne/subscriptions", "organizations_url": "https://api.github.com/users/syog1ne/orgs", "repos_url": "https://api.github.com/users/syog1ne/repos", "events_url": "https://api.github.com/users/syog1ne/events{/privacy}", "received_events_url": "https://api.github.com/users/syog1ne/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-21T05:58:44
2025-05-27T05:50:23
2025-05-27T05:32:50
NONE
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38250", "html_url": "https://github.com/huggingface/transformers/pull/38250", "diff_url": "https://github.com/huggingface/transformers/pull/38250.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38250.patch", "merged_at": null }
## Resolve DTensor Import Path Inconsistency Across PyTorch Versions **Summary:** This pull request addresses an import issue for `DTensor` arising from its path change across different PyTorch versions. It implements a conditional import mechanism to ensure compatibility. **Problem:** The location of the `DTensor` module has been refactored within the PyTorch library: * In PyTorch versions **prior to 2.5**, `DTensor` is accessible via `torch.distributed._tensor.DTensor`. * In PyTorch versions **2.5 and newer**, `DTensor` has been moved to `torch.distributed.tensor.DTensor`. This discrepancy can cause `ImportError` exceptions when code expecting one path is run with a different PyTorch version. **Solution:** To maintain compatibility across PyTorch versions, this PR introduces a version-aware import for `DTensor`: * If the installed PyTorch version is less than 2.5, `DTensor` will be imported from `torch.distributed._tensor`. * If the installed PyTorch version is 2.5 or greater, `DTensor` will be imported from `torch.distributed.tensor`. This approach ensures that the correct import path is used dynamically, based on the runtime environment. **Evidence of PyTorch Internal Change:** The change in `DTensor`'s import path is evident in PyTorch's own codebase. The following links point to the relevant lines in `torch/_dynamo/variables/torch.py` for different versions, illustrating the path modification: * **PyTorch 2.4.x (and earlier relevant versions):** `DTensor` is referenced from `torch.distributed._tensor`. See: [[GitHub - pytorch/pytorch (branch dcfa77... for v2.4)](https://github.com/pytorch/pytorch/blob/dcfa7702c3ecd8754e8a66bc49142de00c8474ee/torch/_dynamo/variables/torch.py#L563)](https://github.com/pytorch/pytorch/blob/dcfa7702c3ecd8754e8a66bc49142de00c8474ee/torch/_dynamo/variables/torch.py#L563) * **PyTorch 2.5.x (and later relevant versions):** `DTensor` is referenced from `torch.distributed.tensor`. See: [[GitHub - pytorch/pytorch (branch cfc227... for v2.5)](https://github.com/pytorch/pytorch/blob/cfc227ad43c8a39e52463ef06029dddc00919eae/torch/_dynamo/variables/torch.py#L631)](https://github.com/pytorch/pytorch/blob/cfc227ad43c8a39e52463ef06029dddc00919eae/torch/_dynamo/variables/torch.py#L631)
{ "login": "syog1ne", "id": 185162774, "node_id": "U_kgDOCwlcFg", "avatar_url": "https://avatars.githubusercontent.com/u/185162774?v=4", "gravatar_id": "", "url": "https://api.github.com/users/syog1ne", "html_url": "https://github.com/syog1ne", "followers_url": "https://api.github.com/users/syog1ne/followers", "following_url": "https://api.github.com/users/syog1ne/following{/other_user}", "gists_url": "https://api.github.com/users/syog1ne/gists{/gist_id}", "starred_url": "https://api.github.com/users/syog1ne/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/syog1ne/subscriptions", "organizations_url": "https://api.github.com/users/syog1ne/orgs", "repos_url": "https://api.github.com/users/syog1ne/repos", "events_url": "https://api.github.com/users/syog1ne/events{/privacy}", "received_events_url": "https://api.github.com/users/syog1ne/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38250/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38250/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38249
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38249/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38249/comments
https://api.github.com/repos/huggingface/transformers/issues/38249/events
https://github.com/huggingface/transformers/pull/38249
3,079,019,466
PR_kwDOCUB6oc6W_2m6
38,249
[MODEL] Add Falcon H1
{ "login": "younesbelkada", "id": 49240599, "node_id": "MDQ6VXNlcjQ5MjQwNTk5", "avatar_url": "https://avatars.githubusercontent.com/u/49240599?v=4", "gravatar_id": "", "url": "https://api.github.com/users/younesbelkada", "html_url": "https://github.com/younesbelkada", "followers_url": "https://api.github.com/users/younesbelkada/followers", "following_url": "https://api.github.com/users/younesbelkada/following{/other_user}", "gists_url": "https://api.github.com/users/younesbelkada/gists{/gist_id}", "starred_url": "https://api.github.com/users/younesbelkada/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/younesbelkada/subscriptions", "organizations_url": "https://api.github.com/users/younesbelkada/orgs", "repos_url": "https://api.github.com/users/younesbelkada/repos", "events_url": "https://api.github.com/users/younesbelkada/events{/privacy}", "received_events_url": "https://api.github.com/users/younesbelkada/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-21T05:55:41
2025-05-23T12:12:31
2025-05-21T08:43:12
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38249", "html_url": "https://github.com/huggingface/transformers/pull/38249", "diff_url": "https://github.com/huggingface/transformers/pull/38249.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38249.patch", "merged_at": "2025-05-21T08:43:12" }
null
{ "login": "ArthurZucker", "id": 48595927, "node_id": "MDQ6VXNlcjQ4NTk1OTI3", "avatar_url": "https://avatars.githubusercontent.com/u/48595927?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ArthurZucker", "html_url": "https://github.com/ArthurZucker", "followers_url": "https://api.github.com/users/ArthurZucker/followers", "following_url": "https://api.github.com/users/ArthurZucker/following{/other_user}", "gists_url": "https://api.github.com/users/ArthurZucker/gists{/gist_id}", "starred_url": "https://api.github.com/users/ArthurZucker/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ArthurZucker/subscriptions", "organizations_url": "https://api.github.com/users/ArthurZucker/orgs", "repos_url": "https://api.github.com/users/ArthurZucker/repos", "events_url": "https://api.github.com/users/ArthurZucker/events{/privacy}", "received_events_url": "https://api.github.com/users/ArthurZucker/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38249/reactions", "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 1, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38249/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38248
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38248/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38248/comments
https://api.github.com/repos/huggingface/transformers/issues/38248/events
https://github.com/huggingface/transformers/pull/38248
3,078,912,504
PR_kwDOCUB6oc6W_fJX
38,248
Add X-Codec model
{ "login": "Manalelaidouni", "id": 25346345, "node_id": "MDQ6VXNlcjI1MzQ2MzQ1", "avatar_url": "https://avatars.githubusercontent.com/u/25346345?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Manalelaidouni", "html_url": "https://github.com/Manalelaidouni", "followers_url": "https://api.github.com/users/Manalelaidouni/followers", "following_url": "https://api.github.com/users/Manalelaidouni/following{/other_user}", "gists_url": "https://api.github.com/users/Manalelaidouni/gists{/gist_id}", "starred_url": "https://api.github.com/users/Manalelaidouni/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Manalelaidouni/subscriptions", "organizations_url": "https://api.github.com/users/Manalelaidouni/orgs", "repos_url": "https://api.github.com/users/Manalelaidouni/repos", "events_url": "https://api.github.com/users/Manalelaidouni/events{/privacy}", "received_events_url": "https://api.github.com/users/Manalelaidouni/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1843244711, "node_id": "MDU6TGFiZWwxODQzMjQ0NzEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/New%20model", "name": "New model", "color": "fbca04", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2025-05-21T04:55:54
2025-08-15T14:24:12
2025-08-15T14:24:12
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38248", "html_url": "https://github.com/huggingface/transformers/pull/38248", "diff_url": "https://github.com/huggingface/transformers/pull/38248.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38248.patch", "merged_at": "2025-08-15T14:24:12" }
# What does this PR do? This PR aims at integrating X-Codec model to `transformers`. The X-Codec model is a neural audio codec that integrates semantic information from self-supervised models (e.g., HuBERT) alongside traditional acoustic information. This enables : - **Music continuation** : Better modeling of musical semantics yields more coherent continuations. - **Text-to-Sound Synthesis** : X-Codec captures semantic alignment between text prompts and generated audio. - **Semantic aware audio tokenization**: X-Codec is used as an audio tokenizer in the YuE lyrics to song generation model. X-codec first encodes the audio using an acoustic model (DAC model) and then extracts semantic information using a pretrained Hubert model, this semantic information is further refined with a semantic encoder. The combined features are then fed into a Residual Vector Quantizer (RVQ) that converts the features into discrete codes. Each individual component reproduce the original X-Codec outputs exactly. Note that I removed the extra padding at the end of the decoded `audio_values` so that the output length matches that of the input, the produced audio closely resembles the original audio with a 1e-5 tolerance; otherwise the forward pass is identical with the output from the original model. X-Codec can be now used as a drop in audio tokenizer in YuE as suggested in the design discussion in https://github.com/huggingface/transformers/issues/36784. ## Who can review? @eustlb @zucchini-nlp
{ "login": "ArthurZucker", "id": 48595927, "node_id": "MDQ6VXNlcjQ4NTk1OTI3", "avatar_url": "https://avatars.githubusercontent.com/u/48595927?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ArthurZucker", "html_url": "https://github.com/ArthurZucker", "followers_url": "https://api.github.com/users/ArthurZucker/followers", "following_url": "https://api.github.com/users/ArthurZucker/following{/other_user}", "gists_url": "https://api.github.com/users/ArthurZucker/gists{/gist_id}", "starred_url": "https://api.github.com/users/ArthurZucker/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ArthurZucker/subscriptions", "organizations_url": "https://api.github.com/users/ArthurZucker/orgs", "repos_url": "https://api.github.com/users/ArthurZucker/repos", "events_url": "https://api.github.com/users/ArthurZucker/events{/privacy}", "received_events_url": "https://api.github.com/users/ArthurZucker/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38248/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38248/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38247
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38247/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38247/comments
https://api.github.com/repos/huggingface/transformers/issues/38247/events
https://github.com/huggingface/transformers/pull/38247
3,078,573,989
PR_kwDOCUB6oc6W-WhD
38,247
switch to device agnostic device calling for test cases
{ "login": "yao-matrix", "id": 7245027, "node_id": "MDQ6VXNlcjcyNDUwMjc=", "avatar_url": "https://avatars.githubusercontent.com/u/7245027?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yao-matrix", "html_url": "https://github.com/yao-matrix", "followers_url": "https://api.github.com/users/yao-matrix/followers", "following_url": "https://api.github.com/users/yao-matrix/following{/other_user}", "gists_url": "https://api.github.com/users/yao-matrix/gists{/gist_id}", "starred_url": "https://api.github.com/users/yao-matrix/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yao-matrix/subscriptions", "organizations_url": "https://api.github.com/users/yao-matrix/orgs", "repos_url": "https://api.github.com/users/yao-matrix/repos", "events_url": "https://api.github.com/users/yao-matrix/events{/privacy}", "received_events_url": "https://api.github.com/users/yao-matrix/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-21T01:01:38
2025-05-26T22:30:23
2025-05-26T08:18:53
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38247", "html_url": "https://github.com/huggingface/transformers/pull/38247", "diff_url": "https://github.com/huggingface/transformers/pull/38247.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38247.patch", "merged_at": "2025-05-26T08:18:53" }
@ydshieh , as we discussed in https://github.com/huggingface/transformers/pull/38192, i propose to change all device callings to device agnostic `backend_xx` calling for test cases, and i go through the `tests` folder and change the rest device-binding callings to that way. Pls help review, and thx for your patience in advance. @ydshieh @IlyasMoutawwakil , pls help review, thx.
{ "login": "ydshieh", "id": 2521628, "node_id": "MDQ6VXNlcjI1MjE2Mjg=", "avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ydshieh", "html_url": "https://github.com/ydshieh", "followers_url": "https://api.github.com/users/ydshieh/followers", "following_url": "https://api.github.com/users/ydshieh/following{/other_user}", "gists_url": "https://api.github.com/users/ydshieh/gists{/gist_id}", "starred_url": "https://api.github.com/users/ydshieh/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ydshieh/subscriptions", "organizations_url": "https://api.github.com/users/ydshieh/orgs", "repos_url": "https://api.github.com/users/ydshieh/repos", "events_url": "https://api.github.com/users/ydshieh/events{/privacy}", "received_events_url": "https://api.github.com/users/ydshieh/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38247/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38247/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38246
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38246/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38246/comments
https://api.github.com/repos/huggingface/transformers/issues/38246/events
https://github.com/huggingface/transformers/pull/38246
3,078,568,192
PR_kwDOCUB6oc6W-VQV
38,246
Remove Japanese sequence_classification doc and update references
{ "login": "ritsumei-aoi", "id": 8552760, "node_id": "MDQ6VXNlcjg1NTI3NjA=", "avatar_url": "https://avatars.githubusercontent.com/u/8552760?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ritsumei-aoi", "html_url": "https://github.com/ritsumei-aoi", "followers_url": "https://api.github.com/users/ritsumei-aoi/followers", "following_url": "https://api.github.com/users/ritsumei-aoi/following{/other_user}", "gists_url": "https://api.github.com/users/ritsumei-aoi/gists{/gist_id}", "starred_url": "https://api.github.com/users/ritsumei-aoi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ritsumei-aoi/subscriptions", "organizations_url": "https://api.github.com/users/ritsumei-aoi/orgs", "repos_url": "https://api.github.com/users/ritsumei-aoi/repos", "events_url": "https://api.github.com/users/ritsumei-aoi/events{/privacy}", "received_events_url": "https://api.github.com/users/ritsumei-aoi/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-21T00:57:55
2025-05-21T15:33:42
2025-05-21T15:33:42
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38246", "html_url": "https://github.com/huggingface/transformers/pull/38246", "diff_url": "https://github.com/huggingface/transformers/pull/38246.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38246.patch", "merged_at": "2025-05-21T15:33:42" }
This PR addresses Issue #38187. - Deleted `docs/source/ja/tasks/sequence_classification.md` - Removed the entry from `_toctree.yml` - Updated links in docs to point to the English sequence_classification page (with "(英語版)" in the link text)
{ "login": "stevhliu", "id": 59462357, "node_id": "MDQ6VXNlcjU5NDYyMzU3", "avatar_url": "https://avatars.githubusercontent.com/u/59462357?v=4", "gravatar_id": "", "url": "https://api.github.com/users/stevhliu", "html_url": "https://github.com/stevhliu", "followers_url": "https://api.github.com/users/stevhliu/followers", "following_url": "https://api.github.com/users/stevhliu/following{/other_user}", "gists_url": "https://api.github.com/users/stevhliu/gists{/gist_id}", "starred_url": "https://api.github.com/users/stevhliu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/stevhliu/subscriptions", "organizations_url": "https://api.github.com/users/stevhliu/orgs", "repos_url": "https://api.github.com/users/stevhliu/repos", "events_url": "https://api.github.com/users/stevhliu/events{/privacy}", "received_events_url": "https://api.github.com/users/stevhliu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38246/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38246/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38245
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38245/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38245/comments
https://api.github.com/repos/huggingface/transformers/issues/38245/events
https://github.com/huggingface/transformers/pull/38245
3,078,455,120
PR_kwDOCUB6oc6W98vB
38,245
Simplify DTensor Check for modeling_utils.py
{ "login": "amd-xiaoyu12", "id": 188109516, "node_id": "U_kgDOCzZSzA", "avatar_url": "https://avatars.githubusercontent.com/u/188109516?v=4", "gravatar_id": "", "url": "https://api.github.com/users/amd-xiaoyu12", "html_url": "https://github.com/amd-xiaoyu12", "followers_url": "https://api.github.com/users/amd-xiaoyu12/followers", "following_url": "https://api.github.com/users/amd-xiaoyu12/following{/other_user}", "gists_url": "https://api.github.com/users/amd-xiaoyu12/gists{/gist_id}", "starred_url": "https://api.github.com/users/amd-xiaoyu12/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/amd-xiaoyu12/subscriptions", "organizations_url": "https://api.github.com/users/amd-xiaoyu12/orgs", "repos_url": "https://api.github.com/users/amd-xiaoyu12/repos", "events_url": "https://api.github.com/users/amd-xiaoyu12/events{/privacy}", "received_events_url": "https://api.github.com/users/amd-xiaoyu12/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-20T23:33:10
2025-05-21T13:36:17
2025-05-21T13:35:45
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38245", "html_url": "https://github.com/huggingface/transformers/pull/38245", "diff_url": "https://github.com/huggingface/transformers/pull/38245.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38245.patch", "merged_at": "2025-05-21T13:35:45" }
# What does this PR do? The if condition check can be simplified, since DTensor is also a Tensor: if isinstance(tensor, torch.Tensor) or isinstance(tensor, DTensor): => if isinstance(tensor, torch.Tensor): The code for DTensor export later within this function will handle it. <!-- Congratulations! You've made it this far! You're not quite done yet though. Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution. Then, please replace this with a description of the change and which issue is fixed (if applicable). Please also include relevant motivation and context. List any dependencies (if any) that are required for this change. Once you're done, someone will review your PR shortly (see the section "Who can review?" below to tag some potential reviewers). They may suggest changes to make the code even better. If no one reviewed your PR after a week has passed, don't hesitate to post a new comment @-mentioning the same persons---sometimes notifications get lost. --> <!-- Remove if not applicable --> Fixes # (issue) ## Before submitting - [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [ ] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request), Pull Request section? - [ ] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case. - [ ] Did you make sure to update the documentation with your changes? Here are the [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation). - [ ] Did you write any new necessary tests? ## Who can review? Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR. <!-- Your PR will be replied to more quickly if you can figure out the right person to tag with @ If you know how to use git blame, that is the easiest way, otherwise, here is a rough guide of **who to tag**. Please tag fewer than 3 people. Models: - text models: @ArthurZucker - vision models: @amyeroberts, @qubvel - speech models: @eustlb - graph models: @clefourrier Library: - flax: @gante and @Rocketknight1 - generate: @zucchini-nlp (visual-language models) or @gante (all others) - pipelines: @Rocketknight1 - tensorflow: @gante and @Rocketknight1 - tokenizers: @ArthurZucker - trainer: @zach-huggingface and @SunMarc - chat templates: @Rocketknight1 Integrations: - deepspeed: HF Trainer/Accelerate: @SunMarc @zach-huggingface - ray/raytune: @richardliaw, @amogkam - Big Model Inference: @SunMarc - quantization (bitsandbytes, autogpt): @SunMarc @MekkCyber Documentation: @stevhliu HF projects: - accelerate: [different repo](https://github.com/huggingface/accelerate) - datasets: [different repo](https://github.com/huggingface/datasets) - diffusers: [different repo](https://github.com/huggingface/diffusers) - rust tokenizers: [different repo](https://github.com/huggingface/tokenizers) Maintained examples (not research project or legacy): - Flax: @Rocketknight1 - PyTorch: See Models above and tag the person corresponding to the modality of the example. - TensorFlow: @Rocketknight1 -->
{ "login": "Rocketknight1", "id": 12866554, "node_id": "MDQ6VXNlcjEyODY2NTU0", "avatar_url": "https://avatars.githubusercontent.com/u/12866554?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Rocketknight1", "html_url": "https://github.com/Rocketknight1", "followers_url": "https://api.github.com/users/Rocketknight1/followers", "following_url": "https://api.github.com/users/Rocketknight1/following{/other_user}", "gists_url": "https://api.github.com/users/Rocketknight1/gists{/gist_id}", "starred_url": "https://api.github.com/users/Rocketknight1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Rocketknight1/subscriptions", "organizations_url": "https://api.github.com/users/Rocketknight1/orgs", "repos_url": "https://api.github.com/users/Rocketknight1/repos", "events_url": "https://api.github.com/users/Rocketknight1/events{/privacy}", "received_events_url": "https://api.github.com/users/Rocketknight1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38245/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38245/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38244
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38244/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38244/comments
https://api.github.com/repos/huggingface/transformers/issues/38244/events
https://github.com/huggingface/transformers/pull/38244
3,078,395,328
PR_kwDOCUB6oc6W9vlR
38,244
Fix KeyError in 4D attention mask creation for encoder-decoder model
{ "login": "OliBomby", "id": 17460441, "node_id": "MDQ6VXNlcjE3NDYwNDQx", "avatar_url": "https://avatars.githubusercontent.com/u/17460441?v=4", "gravatar_id": "", "url": "https://api.github.com/users/OliBomby", "html_url": "https://github.com/OliBomby", "followers_url": "https://api.github.com/users/OliBomby/followers", "following_url": "https://api.github.com/users/OliBomby/following{/other_user}", "gists_url": "https://api.github.com/users/OliBomby/gists{/gist_id}", "starred_url": "https://api.github.com/users/OliBomby/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/OliBomby/subscriptions", "organizations_url": "https://api.github.com/users/OliBomby/orgs", "repos_url": "https://api.github.com/users/OliBomby/repos", "events_url": "https://api.github.com/users/OliBomby/events{/privacy}", "received_events_url": "https://api.github.com/users/OliBomby/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-20T22:51:56
2025-05-22T09:55:35
2025-05-22T09:55:25
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38244", "html_url": "https://github.com/huggingface/transformers/pull/38244", "diff_url": "https://github.com/huggingface/transformers/pull/38244.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38244.patch", "merged_at": null }
# What does this PR do? Fixes KeyError in 4D attention mask creation for encoder-decoder models when generating with attention mask and static cache. This occurs because `inputs_embeds` does not get added to `model_inputs` for encoder-decoder models, like Whisper. Subsequently it tries to check if `model_inputs["inputs_embeds"]` is none and throws a KeyError. cc @gante <!-- Your PR will be replied to more quickly if you can figure out the right person to tag with @ If you know how to use git blame, that is the easiest way, otherwise, here is a rough guide of **who to tag**. Please tag fewer than 3 people. Models: - text models: @ArthurZucker - vision models: @amyeroberts, @qubvel - speech models: @eustlb - graph models: @clefourrier Library: - flax: @gante and @Rocketknight1 - generate: @zucchini-nlp (visual-language models) or @gante (all others) - pipelines: @Rocketknight1 - tensorflow: @gante and @Rocketknight1 - tokenizers: @ArthurZucker - trainer: @zach-huggingface and @SunMarc - chat templates: @Rocketknight1 Integrations: - deepspeed: HF Trainer/Accelerate: @SunMarc @zach-huggingface - ray/raytune: @richardliaw, @amogkam - Big Model Inference: @SunMarc - quantization (bitsandbytes, autogpt): @SunMarc @MekkCyber Documentation: @stevhliu HF projects: - accelerate: [different repo](https://github.com/huggingface/accelerate) - datasets: [different repo](https://github.com/huggingface/datasets) - diffusers: [different repo](https://github.com/huggingface/diffusers) - rust tokenizers: [different repo](https://github.com/huggingface/tokenizers) Maintained examples (not research project or legacy): - Flax: @Rocketknight1 - PyTorch: See Models above and tag the person corresponding to the modality of the example. - TensorFlow: @Rocketknight1 -->
{ "login": "OliBomby", "id": 17460441, "node_id": "MDQ6VXNlcjE3NDYwNDQx", "avatar_url": "https://avatars.githubusercontent.com/u/17460441?v=4", "gravatar_id": "", "url": "https://api.github.com/users/OliBomby", "html_url": "https://github.com/OliBomby", "followers_url": "https://api.github.com/users/OliBomby/followers", "following_url": "https://api.github.com/users/OliBomby/following{/other_user}", "gists_url": "https://api.github.com/users/OliBomby/gists{/gist_id}", "starred_url": "https://api.github.com/users/OliBomby/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/OliBomby/subscriptions", "organizations_url": "https://api.github.com/users/OliBomby/orgs", "repos_url": "https://api.github.com/users/OliBomby/repos", "events_url": "https://api.github.com/users/OliBomby/events{/privacy}", "received_events_url": "https://api.github.com/users/OliBomby/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38244/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38244/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38243
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38243/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38243/comments
https://api.github.com/repos/huggingface/transformers/issues/38243/events
https://github.com/huggingface/transformers/issues/38243
3,078,347,189
I_kwDOCUB6oc63e9m1
38,243
<spam>
{ "login": "DandBman", "id": 212624621, "node_id": "U_kgDODKxk7Q", "avatar_url": "https://avatars.githubusercontent.com/u/212624621?v=4", "gravatar_id": "", "url": "https://api.github.com/users/DandBman", "html_url": "https://github.com/DandBman", "followers_url": "https://api.github.com/users/DandBman/followers", "following_url": "https://api.github.com/users/DandBman/following{/other_user}", "gists_url": "https://api.github.com/users/DandBman/gists{/gist_id}", "starred_url": "https://api.github.com/users/DandBman/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/DandBman/subscriptions", "organizations_url": "https://api.github.com/users/DandBman/orgs", "repos_url": "https://api.github.com/users/DandBman/repos", "events_url": "https://api.github.com/users/DandBman/events{/privacy}", "received_events_url": "https://api.github.com/users/DandBman/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-20T22:14:11
2025-05-21T13:14:41
2025-05-21T13:14:26
NONE
null
null
null
null
We are looking for an experienced Machine Learning Engineer for a BTC/USDT prediction project using CNN, LSTM, and Transformers. The goal is to forecast cryptocurrency price movements with a target accuracy of 90%+. More details here:[ ](https://gist.github.com/DandBman/c76a548b1972da50ffe6bbdd93fdd613)
{ "login": "Rocketknight1", "id": 12866554, "node_id": "MDQ6VXNlcjEyODY2NTU0", "avatar_url": "https://avatars.githubusercontent.com/u/12866554?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Rocketknight1", "html_url": "https://github.com/Rocketknight1", "followers_url": "https://api.github.com/users/Rocketknight1/followers", "following_url": "https://api.github.com/users/Rocketknight1/following{/other_user}", "gists_url": "https://api.github.com/users/Rocketknight1/gists{/gist_id}", "starred_url": "https://api.github.com/users/Rocketknight1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Rocketknight1/subscriptions", "organizations_url": "https://api.github.com/users/Rocketknight1/orgs", "repos_url": "https://api.github.com/users/Rocketknight1/repos", "events_url": "https://api.github.com/users/Rocketknight1/events{/privacy}", "received_events_url": "https://api.github.com/users/Rocketknight1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38243/reactions", "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 1, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38243/timeline
null
completed
{ "total": 0, "completed": 0, "percent_completed": 0 }
{ "blocked_by": 0, "total_blocked_by": 0, "blocking": 0, "total_blocking": 0 }
false
true
https://api.github.com/repos/huggingface/transformers/issues/38242
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38242/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38242/comments
https://api.github.com/repos/huggingface/transformers/issues/38242/events
https://github.com/huggingface/transformers/pull/38242
3,078,281,637
PR_kwDOCUB6oc6W9XDQ
38,242
Add support for auto_docstring with model outputs
{ "login": "yonigozlan", "id": 74535834, "node_id": "MDQ6VXNlcjc0NTM1ODM0", "avatar_url": "https://avatars.githubusercontent.com/u/74535834?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yonigozlan", "html_url": "https://github.com/yonigozlan", "followers_url": "https://api.github.com/users/yonigozlan/followers", "following_url": "https://api.github.com/users/yonigozlan/following{/other_user}", "gists_url": "https://api.github.com/users/yonigozlan/gists{/gist_id}", "starred_url": "https://api.github.com/users/yonigozlan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yonigozlan/subscriptions", "organizations_url": "https://api.github.com/users/yonigozlan/orgs", "repos_url": "https://api.github.com/users/yonigozlan/repos", "events_url": "https://api.github.com/users/yonigozlan/events{/privacy}", "received_events_url": "https://api.github.com/users/yonigozlan/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-20T21:31:01
2025-06-23T14:39:41
2025-06-23T14:39:41
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38242", "html_url": "https://github.com/huggingface/transformers/pull/38242", "diff_url": "https://github.com/huggingface/transformers/pull/38242.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38242.patch", "merged_at": "2025-06-23T14:39:41" }
# What does this PR do? As the title says. However not sure if worth it, as there are a lot of different descriptions currently for the same args. The descriptions that are different from the one in ModelOutputArgs are left in the ModelOutput docstring, which is why the there's not that much more deletions than additions in this PR. Wdyt @Cyrilvallez @ArthurZucker ?
{ "login": "yonigozlan", "id": 74535834, "node_id": "MDQ6VXNlcjc0NTM1ODM0", "avatar_url": "https://avatars.githubusercontent.com/u/74535834?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yonigozlan", "html_url": "https://github.com/yonigozlan", "followers_url": "https://api.github.com/users/yonigozlan/followers", "following_url": "https://api.github.com/users/yonigozlan/following{/other_user}", "gists_url": "https://api.github.com/users/yonigozlan/gists{/gist_id}", "starred_url": "https://api.github.com/users/yonigozlan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yonigozlan/subscriptions", "organizations_url": "https://api.github.com/users/yonigozlan/orgs", "repos_url": "https://api.github.com/users/yonigozlan/repos", "events_url": "https://api.github.com/users/yonigozlan/events{/privacy}", "received_events_url": "https://api.github.com/users/yonigozlan/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38242/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38242/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38241
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38241/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38241/comments
https://api.github.com/repos/huggingface/transformers/issues/38241/events
https://github.com/huggingface/transformers/pull/38241
3,078,184,615
PR_kwDOCUB6oc6W9CS1
38,241
[docs] Tensor parallelism
{ "login": "stevhliu", "id": 59462357, "node_id": "MDQ6VXNlcjU5NDYyMzU3", "avatar_url": "https://avatars.githubusercontent.com/u/59462357?v=4", "gravatar_id": "", "url": "https://api.github.com/users/stevhliu", "html_url": "https://github.com/stevhliu", "followers_url": "https://api.github.com/users/stevhliu/followers", "following_url": "https://api.github.com/users/stevhliu/following{/other_user}", "gists_url": "https://api.github.com/users/stevhliu/gists{/gist_id}", "starred_url": "https://api.github.com/users/stevhliu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/stevhliu/subscriptions", "organizations_url": "https://api.github.com/users/stevhliu/orgs", "repos_url": "https://api.github.com/users/stevhliu/repos", "events_url": "https://api.github.com/users/stevhliu/events{/privacy}", "received_events_url": "https://api.github.com/users/stevhliu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-20T20:39:32
2025-06-26T21:40:52
2025-06-26T21:40:45
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38241", "html_url": "https://github.com/huggingface/transformers/pull/38241", "diff_url": "https://github.com/huggingface/transformers/pull/38241.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38241.patch", "merged_at": "2025-06-26T21:40:45" }
Light refactor of the tensor parallelism docs! I think it's more intuitive and impactful to start by showing `tp_plan` so they understand how it works at a higher-level, and then they can explore the different strategies and how to set those.
{ "login": "stevhliu", "id": 59462357, "node_id": "MDQ6VXNlcjU5NDYyMzU3", "avatar_url": "https://avatars.githubusercontent.com/u/59462357?v=4", "gravatar_id": "", "url": "https://api.github.com/users/stevhliu", "html_url": "https://github.com/stevhliu", "followers_url": "https://api.github.com/users/stevhliu/followers", "following_url": "https://api.github.com/users/stevhliu/following{/other_user}", "gists_url": "https://api.github.com/users/stevhliu/gists{/gist_id}", "starred_url": "https://api.github.com/users/stevhliu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/stevhliu/subscriptions", "organizations_url": "https://api.github.com/users/stevhliu/orgs", "repos_url": "https://api.github.com/users/stevhliu/repos", "events_url": "https://api.github.com/users/stevhliu/events{/privacy}", "received_events_url": "https://api.github.com/users/stevhliu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38241/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38241/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38240
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38240/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38240/comments
https://api.github.com/repos/huggingface/transformers/issues/38240/events
https://github.com/huggingface/transformers/pull/38240
3,078,144,516
PR_kwDOCUB6oc6W85iV
38,240
Revert parallelism temporarily
{ "login": "LysandreJik", "id": 30755778, "node_id": "MDQ6VXNlcjMwNzU1Nzc4", "avatar_url": "https://avatars.githubusercontent.com/u/30755778?v=4", "gravatar_id": "", "url": "https://api.github.com/users/LysandreJik", "html_url": "https://github.com/LysandreJik", "followers_url": "https://api.github.com/users/LysandreJik/followers", "following_url": "https://api.github.com/users/LysandreJik/following{/other_user}", "gists_url": "https://api.github.com/users/LysandreJik/gists{/gist_id}", "starred_url": "https://api.github.com/users/LysandreJik/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/LysandreJik/subscriptions", "organizations_url": "https://api.github.com/users/LysandreJik/orgs", "repos_url": "https://api.github.com/users/LysandreJik/repos", "events_url": "https://api.github.com/users/LysandreJik/events{/privacy}", "received_events_url": "https://api.github.com/users/LysandreJik/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-20T20:21:10
2025-05-20T20:43:06
2025-05-20T20:43:04
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38240", "html_url": "https://github.com/huggingface/transformers/pull/38240", "diff_url": "https://github.com/huggingface/transformers/pull/38240.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38240.patch", "merged_at": "2025-05-20T20:43:04" }
cc @ydshieh
{ "login": "LysandreJik", "id": 30755778, "node_id": "MDQ6VXNlcjMwNzU1Nzc4", "avatar_url": "https://avatars.githubusercontent.com/u/30755778?v=4", "gravatar_id": "", "url": "https://api.github.com/users/LysandreJik", "html_url": "https://github.com/LysandreJik", "followers_url": "https://api.github.com/users/LysandreJik/followers", "following_url": "https://api.github.com/users/LysandreJik/following{/other_user}", "gists_url": "https://api.github.com/users/LysandreJik/gists{/gist_id}", "starred_url": "https://api.github.com/users/LysandreJik/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/LysandreJik/subscriptions", "organizations_url": "https://api.github.com/users/LysandreJik/orgs", "repos_url": "https://api.github.com/users/LysandreJik/repos", "events_url": "https://api.github.com/users/LysandreJik/events{/privacy}", "received_events_url": "https://api.github.com/users/LysandreJik/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38240/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38240/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38239
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38239/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38239/comments
https://api.github.com/repos/huggingface/transformers/issues/38239/events
https://github.com/huggingface/transformers/issues/38239
3,077,984,279
I_kwDOCUB6oc63dlAX
38,239
QuantizationMethod.BITNET Support
{ "login": "mrjha4050", "id": 108355610, "node_id": "U_kgDOBnVgGg", "avatar_url": "https://avatars.githubusercontent.com/u/108355610?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mrjha4050", "html_url": "https://github.com/mrjha4050", "followers_url": "https://api.github.com/users/mrjha4050/followers", "following_url": "https://api.github.com/users/mrjha4050/following{/other_user}", "gists_url": "https://api.github.com/users/mrjha4050/gists{/gist_id}", "starred_url": "https://api.github.com/users/mrjha4050/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mrjha4050/subscriptions", "organizations_url": "https://api.github.com/users/mrjha4050/orgs", "repos_url": "https://api.github.com/users/mrjha4050/repos", "events_url": "https://api.github.com/users/mrjha4050/events{/privacy}", "received_events_url": "https://api.github.com/users/mrjha4050/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1843244711, "node_id": "MDU6TGFiZWwxODQzMjQ0NzEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/New%20model", "name": "New model", "color": "fbca04", "default": false, "description": "" } ]
open
false
null
[]
null
[]
2025-05-20T19:09:31
2025-05-20T20:58:19
null
NONE
null
null
null
null
### Model description request the support for training support for QuantizationMethod.BITNET ### Open source status - [ ] The model implementation is available - [ ] The model weights are available ### Provide useful links for the implementation _No response_
null
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38239/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38239/timeline
null
null
{ "total": 0, "completed": 0, "percent_completed": 0 }
{ "blocked_by": 0, "total_blocked_by": 0, "blocking": 0, "total_blocking": 0 }
false
false
https://api.github.com/repos/huggingface/transformers/issues/38238
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38238/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38238/comments
https://api.github.com/repos/huggingface/transformers/issues/38238/events
https://github.com/huggingface/transformers/pull/38238
3,077,721,929
PR_kwDOCUB6oc6W7e5q
38,238
Fix incorrect bbox_embed initialization when decoder_bbox_embed_share=False in GroundingDINO
{ "login": "islemyakoubi", "id": 79903595, "node_id": "MDQ6VXNlcjc5OTAzNTk1", "avatar_url": "https://avatars.githubusercontent.com/u/79903595?v=4", "gravatar_id": "", "url": "https://api.github.com/users/islemyakoubi", "html_url": "https://github.com/islemyakoubi", "followers_url": "https://api.github.com/users/islemyakoubi/followers", "following_url": "https://api.github.com/users/islemyakoubi/following{/other_user}", "gists_url": "https://api.github.com/users/islemyakoubi/gists{/gist_id}", "starred_url": "https://api.github.com/users/islemyakoubi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/islemyakoubi/subscriptions", "organizations_url": "https://api.github.com/users/islemyakoubi/orgs", "repos_url": "https://api.github.com/users/islemyakoubi/repos", "events_url": "https://api.github.com/users/islemyakoubi/events{/privacy}", "received_events_url": "https://api.github.com/users/islemyakoubi/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-20T17:18:53
2025-05-30T18:03:51
2025-05-30T13:02:19
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38238", "html_url": "https://github.com/huggingface/transformers/pull/38238", "diff_url": "https://github.com/huggingface/transformers/pull/38238.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38238.patch", "merged_at": "2025-05-30T13:02:19" }
Fixes #37333 This PR corrects the initialization of the bbox_embed layers in GroundingDinoForObjectDetection when config.decoder_bbox_embed_share is set to False. What does this PR do? Previously, the bbox_embed list was not properly initialized with independent layers when decoder_bbox_embed_share=False. The current implementation mistakenly overwrites the list in each loop iteration, resulting in incorrect behavior. This PR: Ensures that a new GroundingDinoMLPPredictionHead is created per decoder layer when decoder_bbox_embed_share=False Uses nn.ModuleList properly to store separate instances Preserves shared head behavior when decoder_bbox_embed_share=True Motivation Fixing this ensures that each decoder layer has its own bounding box prediction head when specified, which is essential for the expected decoding behavior and model performance.
{ "login": "Cyrilvallez", "id": 71554963, "node_id": "MDQ6VXNlcjcxNTU0OTYz", "avatar_url": "https://avatars.githubusercontent.com/u/71554963?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Cyrilvallez", "html_url": "https://github.com/Cyrilvallez", "followers_url": "https://api.github.com/users/Cyrilvallez/followers", "following_url": "https://api.github.com/users/Cyrilvallez/following{/other_user}", "gists_url": "https://api.github.com/users/Cyrilvallez/gists{/gist_id}", "starred_url": "https://api.github.com/users/Cyrilvallez/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Cyrilvallez/subscriptions", "organizations_url": "https://api.github.com/users/Cyrilvallez/orgs", "repos_url": "https://api.github.com/users/Cyrilvallez/repos", "events_url": "https://api.github.com/users/Cyrilvallez/events{/privacy}", "received_events_url": "https://api.github.com/users/Cyrilvallez/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38238/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38238/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38237
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38237/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38237/comments
https://api.github.com/repos/huggingface/transformers/issues/38237/events
https://github.com/huggingface/transformers/pull/38237
3,077,558,864
PR_kwDOCUB6oc6W67Eh
38,237
[gptq] Fixing gptq tests after new release of gptqmodel
{ "login": "MekkCyber", "id": 93391238, "node_id": "U_kgDOBZEJhg", "avatar_url": "https://avatars.githubusercontent.com/u/93391238?v=4", "gravatar_id": "", "url": "https://api.github.com/users/MekkCyber", "html_url": "https://github.com/MekkCyber", "followers_url": "https://api.github.com/users/MekkCyber/followers", "following_url": "https://api.github.com/users/MekkCyber/following{/other_user}", "gists_url": "https://api.github.com/users/MekkCyber/gists{/gist_id}", "starred_url": "https://api.github.com/users/MekkCyber/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MekkCyber/subscriptions", "organizations_url": "https://api.github.com/users/MekkCyber/orgs", "repos_url": "https://api.github.com/users/MekkCyber/repos", "events_url": "https://api.github.com/users/MekkCyber/events{/privacy}", "received_events_url": "https://api.github.com/users/MekkCyber/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
open
false
null
[]
null
[]
2025-05-20T16:10:57
2025-05-21T12:27:57
null
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38237", "html_url": "https://github.com/huggingface/transformers/pull/38237", "diff_url": "https://github.com/huggingface/transformers/pull/38237.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38237.patch", "merged_at": null }
# What does this PR do? Fixing some failing gptq tests. Fixing some bnb tests in gptq, It seems there's a regression in the new release — the layer type used to be `tritonv2` in CI, but it's now `torch`. An issue has been opened [here](https://github.com/ModelCloud/GPTQModel/issues/1617). Will update once the issue addressed
null
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38237/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38237/timeline
null
null
null
null
true
false
https://api.github.com/repos/huggingface/transformers/issues/38236
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38236/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38236/comments
https://api.github.com/repos/huggingface/transformers/issues/38236/events
https://github.com/huggingface/transformers/pull/38236
3,077,446,025
PR_kwDOCUB6oc6W6jDd
38,236
[whisper] small changes for faster tests
{ "login": "gante", "id": 12240844, "node_id": "MDQ6VXNlcjEyMjQwODQ0", "avatar_url": "https://avatars.githubusercontent.com/u/12240844?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gante", "html_url": "https://github.com/gante", "followers_url": "https://api.github.com/users/gante/followers", "following_url": "https://api.github.com/users/gante/following{/other_user}", "gists_url": "https://api.github.com/users/gante/gists{/gist_id}", "starred_url": "https://api.github.com/users/gante/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gante/subscriptions", "organizations_url": "https://api.github.com/users/gante/orgs", "repos_url": "https://api.github.com/users/gante/repos", "events_url": "https://api.github.com/users/gante/events{/privacy}", "received_events_url": "https://api.github.com/users/gante/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-20T15:32:15
2025-05-21T13:11:08
2025-05-21T13:11:08
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38236", "html_url": "https://github.com/huggingface/transformers/pull/38236", "diff_url": "https://github.com/huggingface/transformers/pull/38236.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38236.patch", "merged_at": "2025-05-21T13:11:08" }
# What does this PR do? whisper has a very slow set of tests. This PR applies low-hanging fruit changes to get faster tests (slow tests: 7m47s -> 6m59s on my machine) - the main dataset is now loaded once per test suite (as opposed to once per test in relevant tests) - generation tests happen on GPU when possible
{ "login": "gante", "id": 12240844, "node_id": "MDQ6VXNlcjEyMjQwODQ0", "avatar_url": "https://avatars.githubusercontent.com/u/12240844?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gante", "html_url": "https://github.com/gante", "followers_url": "https://api.github.com/users/gante/followers", "following_url": "https://api.github.com/users/gante/following{/other_user}", "gists_url": "https://api.github.com/users/gante/gists{/gist_id}", "starred_url": "https://api.github.com/users/gante/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gante/subscriptions", "organizations_url": "https://api.github.com/users/gante/orgs", "repos_url": "https://api.github.com/users/gante/repos", "events_url": "https://api.github.com/users/gante/events{/privacy}", "received_events_url": "https://api.github.com/users/gante/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38236/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38236/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38235
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38235/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38235/comments
https://api.github.com/repos/huggingface/transformers/issues/38235/events
https://github.com/huggingface/transformers/pull/38235
3,077,426,611
PR_kwDOCUB6oc6W6exA
38,235
🔴[`Attention`] Attention refactor for Whisper-based models
{ "login": "vasqu", "id": 73884904, "node_id": "MDQ6VXNlcjczODg0OTA0", "avatar_url": "https://avatars.githubusercontent.com/u/73884904?v=4", "gravatar_id": "", "url": "https://api.github.com/users/vasqu", "html_url": "https://github.com/vasqu", "followers_url": "https://api.github.com/users/vasqu/followers", "following_url": "https://api.github.com/users/vasqu/following{/other_user}", "gists_url": "https://api.github.com/users/vasqu/gists{/gist_id}", "starred_url": "https://api.github.com/users/vasqu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/vasqu/subscriptions", "organizations_url": "https://api.github.com/users/vasqu/orgs", "repos_url": "https://api.github.com/users/vasqu/repos", "events_url": "https://api.github.com/users/vasqu/events{/privacy}", "received_events_url": "https://api.github.com/users/vasqu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-20T15:25:40
2025-05-28T11:32:39
2025-05-28T11:32:38
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38235", "html_url": "https://github.com/huggingface/transformers/pull/38235", "diff_url": "https://github.com/huggingface/transformers/pull/38235.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38235.patch", "merged_at": "2025-05-28T11:32:38" }
Whisper attention refactor according to the same strategies applied in #38108 Also, several fixes on Whisper along the way, reducing the number of failed tests to 3 (disregarding skipped tests): - `test_small_longform_timestamps_generation` - `test_tiny_token_timestamp_batch_generation` - `test_whisper_longform_multi_batch_hard_prev_cond`
{ "login": "vasqu", "id": 73884904, "node_id": "MDQ6VXNlcjczODg0OTA0", "avatar_url": "https://avatars.githubusercontent.com/u/73884904?v=4", "gravatar_id": "", "url": "https://api.github.com/users/vasqu", "html_url": "https://github.com/vasqu", "followers_url": "https://api.github.com/users/vasqu/followers", "following_url": "https://api.github.com/users/vasqu/following{/other_user}", "gists_url": "https://api.github.com/users/vasqu/gists{/gist_id}", "starred_url": "https://api.github.com/users/vasqu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/vasqu/subscriptions", "organizations_url": "https://api.github.com/users/vasqu/orgs", "repos_url": "https://api.github.com/users/vasqu/repos", "events_url": "https://api.github.com/users/vasqu/events{/privacy}", "received_events_url": "https://api.github.com/users/vasqu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38235/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38235/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38234
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38234/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38234/comments
https://api.github.com/repos/huggingface/transformers/issues/38234/events
https://github.com/huggingface/transformers/pull/38234
3,077,389,106
PR_kwDOCUB6oc6W6WXi
38,234
Add tearDown method to Quark to solve OOM issues
{ "login": "MekkCyber", "id": 93391238, "node_id": "U_kgDOBZEJhg", "avatar_url": "https://avatars.githubusercontent.com/u/93391238?v=4", "gravatar_id": "", "url": "https://api.github.com/users/MekkCyber", "html_url": "https://github.com/MekkCyber", "followers_url": "https://api.github.com/users/MekkCyber/followers", "following_url": "https://api.github.com/users/MekkCyber/following{/other_user}", "gists_url": "https://api.github.com/users/MekkCyber/gists{/gist_id}", "starred_url": "https://api.github.com/users/MekkCyber/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MekkCyber/subscriptions", "organizations_url": "https://api.github.com/users/MekkCyber/orgs", "repos_url": "https://api.github.com/users/MekkCyber/repos", "events_url": "https://api.github.com/users/MekkCyber/events{/privacy}", "received_events_url": "https://api.github.com/users/MekkCyber/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-20T15:14:38
2025-05-21T12:26:47
2025-05-21T12:26:44
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38234", "html_url": "https://github.com/huggingface/transformers/pull/38234", "diff_url": "https://github.com/huggingface/transformers/pull/38234.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38234.patch", "merged_at": "2025-05-21T12:26:44" }
# What does this PR do? As stated in the title
{ "login": "SunMarc", "id": 57196510, "node_id": "MDQ6VXNlcjU3MTk2NTEw", "avatar_url": "https://avatars.githubusercontent.com/u/57196510?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SunMarc", "html_url": "https://github.com/SunMarc", "followers_url": "https://api.github.com/users/SunMarc/followers", "following_url": "https://api.github.com/users/SunMarc/following{/other_user}", "gists_url": "https://api.github.com/users/SunMarc/gists{/gist_id}", "starred_url": "https://api.github.com/users/SunMarc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SunMarc/subscriptions", "organizations_url": "https://api.github.com/users/SunMarc/orgs", "repos_url": "https://api.github.com/users/SunMarc/repos", "events_url": "https://api.github.com/users/SunMarc/events{/privacy}", "received_events_url": "https://api.github.com/users/SunMarc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38234/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38234/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38233
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38233/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38233/comments
https://api.github.com/repos/huggingface/transformers/issues/38233/events
https://github.com/huggingface/transformers/pull/38233
3,077,297,015
PR_kwDOCUB6oc6W6CGl
38,233
Fix convert weights for InternVL
{ "login": "yonigozlan", "id": 74535834, "node_id": "MDQ6VXNlcjc0NTM1ODM0", "avatar_url": "https://avatars.githubusercontent.com/u/74535834?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yonigozlan", "html_url": "https://github.com/yonigozlan", "followers_url": "https://api.github.com/users/yonigozlan/followers", "following_url": "https://api.github.com/users/yonigozlan/following{/other_user}", "gists_url": "https://api.github.com/users/yonigozlan/gists{/gist_id}", "starred_url": "https://api.github.com/users/yonigozlan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yonigozlan/subscriptions", "organizations_url": "https://api.github.com/users/yonigozlan/orgs", "repos_url": "https://api.github.com/users/yonigozlan/repos", "events_url": "https://api.github.com/users/yonigozlan/events{/privacy}", "received_events_url": "https://api.github.com/users/yonigozlan/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-20T14:47:29
2025-05-28T15:14:57
2025-05-28T15:14:56
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38233", "html_url": "https://github.com/huggingface/transformers/pull/38233", "diff_url": "https://github.com/huggingface/transformers/pull/38233.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38233.patch", "merged_at": "2025-05-28T15:14:56" }
# What does this PR do? Fix InternVL conversion script. Fixes #38203
{ "login": "yonigozlan", "id": 74535834, "node_id": "MDQ6VXNlcjc0NTM1ODM0", "avatar_url": "https://avatars.githubusercontent.com/u/74535834?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yonigozlan", "html_url": "https://github.com/yonigozlan", "followers_url": "https://api.github.com/users/yonigozlan/followers", "following_url": "https://api.github.com/users/yonigozlan/following{/other_user}", "gists_url": "https://api.github.com/users/yonigozlan/gists{/gist_id}", "starred_url": "https://api.github.com/users/yonigozlan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yonigozlan/subscriptions", "organizations_url": "https://api.github.com/users/yonigozlan/orgs", "repos_url": "https://api.github.com/users/yonigozlan/repos", "events_url": "https://api.github.com/users/yonigozlan/events{/privacy}", "received_events_url": "https://api.github.com/users/yonigozlan/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38233/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38233/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38232
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38232/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38232/comments
https://api.github.com/repos/huggingface/transformers/issues/38232/events
https://github.com/huggingface/transformers/pull/38232
3,077,210,904
PR_kwDOCUB6oc6W5vN8
38,232
[Whisper] handle deprecation of `forced_decoder_ids`
{ "login": "gante", "id": 12240844, "node_id": "MDQ6VXNlcjEyMjQwODQ0", "avatar_url": "https://avatars.githubusercontent.com/u/12240844?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gante", "html_url": "https://github.com/gante", "followers_url": "https://api.github.com/users/gante/followers", "following_url": "https://api.github.com/users/gante/following{/other_user}", "gists_url": "https://api.github.com/users/gante/gists{/gist_id}", "starred_url": "https://api.github.com/users/gante/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gante/subscriptions", "organizations_url": "https://api.github.com/users/gante/orgs", "repos_url": "https://api.github.com/users/gante/repos", "events_url": "https://api.github.com/users/gante/events{/privacy}", "received_events_url": "https://api.github.com/users/gante/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-20T14:20:54
2025-05-22T09:16:57
2025-05-22T09:16:38
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38232", "html_url": "https://github.com/huggingface/transformers/pull/38232", "diff_url": "https://github.com/huggingface/transformers/pull/38232.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38232.patch", "merged_at": "2025-05-22T09:16:38" }
# What does this PR do? Fixes #37172 `forced_decoder_ids`, an old `whisper` flag, was deprecated in favor of the more explicit `task` and `language` flags (#28687). However, we need to handle it for BC: the original checkpoints have them. This PR does a few deprecation-related changes, in an attempt to move us further away from using this flag: - Removes as many uses of `generation_config.forced_decoder_ids` as possible, except to handle BC in whisper's `generate`. - If the newer flags (`task`/`language`) are set, don't throw any warning, i.e. the deprecated flag is ignored if the newer flags are set. Users who loaded base whisper and applied these new flags were seeing warnings, and they shouldn't. - Don't mutate `generation_config.forced_decoder_ids`, and ignore it in `GenerationMixin.generate` ✅ no regressions in SLOW whisper tests
{ "login": "gante", "id": 12240844, "node_id": "MDQ6VXNlcjEyMjQwODQ0", "avatar_url": "https://avatars.githubusercontent.com/u/12240844?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gante", "html_url": "https://github.com/gante", "followers_url": "https://api.github.com/users/gante/followers", "following_url": "https://api.github.com/users/gante/following{/other_user}", "gists_url": "https://api.github.com/users/gante/gists{/gist_id}", "starred_url": "https://api.github.com/users/gante/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gante/subscriptions", "organizations_url": "https://api.github.com/users/gante/orgs", "repos_url": "https://api.github.com/users/gante/repos", "events_url": "https://api.github.com/users/gante/events{/privacy}", "received_events_url": "https://api.github.com/users/gante/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38232/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38232/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38231
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38231/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38231/comments
https://api.github.com/repos/huggingface/transformers/issues/38231/events
https://github.com/huggingface/transformers/pull/38231
3,077,019,846
PR_kwDOCUB6oc6W5Fru
38,231
Fixup wrong mapping
{ "login": "molbap", "id": 39954772, "node_id": "MDQ6VXNlcjM5OTU0Nzcy", "avatar_url": "https://avatars.githubusercontent.com/u/39954772?v=4", "gravatar_id": "", "url": "https://api.github.com/users/molbap", "html_url": "https://github.com/molbap", "followers_url": "https://api.github.com/users/molbap/followers", "following_url": "https://api.github.com/users/molbap/following{/other_user}", "gists_url": "https://api.github.com/users/molbap/gists{/gist_id}", "starred_url": "https://api.github.com/users/molbap/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/molbap/subscriptions", "organizations_url": "https://api.github.com/users/molbap/orgs", "repos_url": "https://api.github.com/users/molbap/repos", "events_url": "https://api.github.com/users/molbap/events{/privacy}", "received_events_url": "https://api.github.com/users/molbap/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-20T13:23:27
2025-10-13T12:27:07
2025-10-13T12:27:07
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38231", "html_url": "https://github.com/huggingface/transformers/pull/38231", "diff_url": "https://github.com/huggingface/transformers/pull/38231.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38231.patch", "merged_at": null }
# What does this PR do? Should fix https://github.com/huggingface/transformers/issues/38228
{ "login": "molbap", "id": 39954772, "node_id": "MDQ6VXNlcjM5OTU0Nzcy", "avatar_url": "https://avatars.githubusercontent.com/u/39954772?v=4", "gravatar_id": "", "url": "https://api.github.com/users/molbap", "html_url": "https://github.com/molbap", "followers_url": "https://api.github.com/users/molbap/followers", "following_url": "https://api.github.com/users/molbap/following{/other_user}", "gists_url": "https://api.github.com/users/molbap/gists{/gist_id}", "starred_url": "https://api.github.com/users/molbap/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/molbap/subscriptions", "organizations_url": "https://api.github.com/users/molbap/orgs", "repos_url": "https://api.github.com/users/molbap/repos", "events_url": "https://api.github.com/users/molbap/events{/privacy}", "received_events_url": "https://api.github.com/users/molbap/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38231/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38231/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38230
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38230/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38230/comments
https://api.github.com/repos/huggingface/transformers/issues/38230/events
https://github.com/huggingface/transformers/pull/38230
3,076,869,546
PR_kwDOCUB6oc6W4kpz
38,230
CI reporting improvements
{ "login": "ydshieh", "id": 2521628, "node_id": "MDQ6VXNlcjI1MjE2Mjg=", "avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ydshieh", "html_url": "https://github.com/ydshieh", "followers_url": "https://api.github.com/users/ydshieh/followers", "following_url": "https://api.github.com/users/ydshieh/following{/other_user}", "gists_url": "https://api.github.com/users/ydshieh/gists{/gist_id}", "starred_url": "https://api.github.com/users/ydshieh/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ydshieh/subscriptions", "organizations_url": "https://api.github.com/users/ydshieh/orgs", "repos_url": "https://api.github.com/users/ydshieh/repos", "events_url": "https://api.github.com/users/ydshieh/events{/privacy}", "received_events_url": "https://api.github.com/users/ydshieh/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-20T12:34:58
2025-05-23T10:24:36
2025-05-20T17:34:58
COLLABORATOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38230", "html_url": "https://github.com/huggingface/transformers/pull/38230", "diff_url": "https://github.com/huggingface/transformers/pull/38230.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38230.patch", "merged_at": "2025-05-20T17:34:58" }
# What does this PR do? - allow non-Nvidia daily scheduled CI runs being able to compare to Nvidia runs - allow manual trigger by `push` or `workflow_dispatch` - this is useful when we need to trigger a manual runs, like a run for new torch version (RC) to see if there is any regression - (If AMD workflow want to have this, only need to change AMD caller) - avoid the reports on the hub being overridden by new runs - see the `runs` directory [here](https://huggingface.co/datasets/hf-internal-testing/transformers_daily_ci/tree/main/2025-05-20) Plan: - compare reports also for non-model jobs (pipeline, quantization) - check bad commits for non-model jobs - incorporate the changes in #37976 Question: - If AMD workflow runs also want to run `check_bad_commit`? - Probably not very useful (as we have this info from Nvidia runs) - (if AMD want to run this, we need to create a new file in `hf-workflows`)
{ "login": "ydshieh", "id": 2521628, "node_id": "MDQ6VXNlcjI1MjE2Mjg=", "avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ydshieh", "html_url": "https://github.com/ydshieh", "followers_url": "https://api.github.com/users/ydshieh/followers", "following_url": "https://api.github.com/users/ydshieh/following{/other_user}", "gists_url": "https://api.github.com/users/ydshieh/gists{/gist_id}", "starred_url": "https://api.github.com/users/ydshieh/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ydshieh/subscriptions", "organizations_url": "https://api.github.com/users/ydshieh/orgs", "repos_url": "https://api.github.com/users/ydshieh/repos", "events_url": "https://api.github.com/users/ydshieh/events{/privacy}", "received_events_url": "https://api.github.com/users/ydshieh/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38230/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38230/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38229
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38229/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38229/comments
https://api.github.com/repos/huggingface/transformers/issues/38229/events
https://github.com/huggingface/transformers/pull/38229
3,076,810,009
PR_kwDOCUB6oc6W4Xl0
38,229
Fixing Bitnet after use_rms_norm introduction
{ "login": "MekkCyber", "id": 93391238, "node_id": "U_kgDOBZEJhg", "avatar_url": "https://avatars.githubusercontent.com/u/93391238?v=4", "gravatar_id": "", "url": "https://api.github.com/users/MekkCyber", "html_url": "https://github.com/MekkCyber", "followers_url": "https://api.github.com/users/MekkCyber/followers", "following_url": "https://api.github.com/users/MekkCyber/following{/other_user}", "gists_url": "https://api.github.com/users/MekkCyber/gists{/gist_id}", "starred_url": "https://api.github.com/users/MekkCyber/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MekkCyber/subscriptions", "organizations_url": "https://api.github.com/users/MekkCyber/orgs", "repos_url": "https://api.github.com/users/MekkCyber/repos", "events_url": "https://api.github.com/users/MekkCyber/events{/privacy}", "received_events_url": "https://api.github.com/users/MekkCyber/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-20T12:14:29
2025-05-20T15:13:26
2025-05-20T15:13:21
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38229", "html_url": "https://github.com/huggingface/transformers/pull/38229", "diff_url": "https://github.com/huggingface/transformers/pull/38229.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38229.patch", "merged_at": "2025-05-20T15:13:21" }
# What does this PR do? This pr simply fixes an issue related to using `_replace_with_bitnet_linear` outside of the quantizer in tests. It checks if `quantization_config` is not None before accessing `use_rms_norm` Action : https://github.com/huggingface/transformers/actions/runs/15127726788/job/42523132728
{ "login": "SunMarc", "id": 57196510, "node_id": "MDQ6VXNlcjU3MTk2NTEw", "avatar_url": "https://avatars.githubusercontent.com/u/57196510?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SunMarc", "html_url": "https://github.com/SunMarc", "followers_url": "https://api.github.com/users/SunMarc/followers", "following_url": "https://api.github.com/users/SunMarc/following{/other_user}", "gists_url": "https://api.github.com/users/SunMarc/gists{/gist_id}", "starred_url": "https://api.github.com/users/SunMarc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SunMarc/subscriptions", "organizations_url": "https://api.github.com/users/SunMarc/orgs", "repos_url": "https://api.github.com/users/SunMarc/repos", "events_url": "https://api.github.com/users/SunMarc/events{/privacy}", "received_events_url": "https://api.github.com/users/SunMarc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38229/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38229/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38228
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38228/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38228/comments
https://api.github.com/repos/huggingface/transformers/issues/38228/events
https://github.com/huggingface/transformers/issues/38228
3,076,791,702
I_kwDOCUB6oc63ZB2W
38,228
MODEL_FOR_MASK_GENERATION_MAPPING_NAMES is broken for SAM
{ "login": "afaenger", "id": 548598, "node_id": "MDQ6VXNlcjU0ODU5OA==", "avatar_url": "https://avatars.githubusercontent.com/u/548598?v=4", "gravatar_id": "", "url": "https://api.github.com/users/afaenger", "html_url": "https://github.com/afaenger", "followers_url": "https://api.github.com/users/afaenger/followers", "following_url": "https://api.github.com/users/afaenger/following{/other_user}", "gists_url": "https://api.github.com/users/afaenger/gists{/gist_id}", "starred_url": "https://api.github.com/users/afaenger/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/afaenger/subscriptions", "organizations_url": "https://api.github.com/users/afaenger/orgs", "repos_url": "https://api.github.com/users/afaenger/repos", "events_url": "https://api.github.com/users/afaenger/events{/privacy}", "received_events_url": "https://api.github.com/users/afaenger/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 3817266200, "node_id": "MDU6TGFiZWwzODE3MjY2MjAw", "url": "https://api.github.com/repos/huggingface/transformers/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": null } ]
closed
false
null
[]
null
[]
2025-05-20T12:07:49
2025-06-28T08:02:32
2025-06-28T08:02:32
NONE
null
null
null
null
### System Info The new entry for `sam_hq` overwrites the existing entry for regular `sam`. ``` MODEL_FOR_MASK_GENERATION_MAPPING_NAMES = OrderedDict( [ ("sam", "SamModel"), ] ) MODEL_FOR_MASK_GENERATION_MAPPING_NAMES = OrderedDict( [ ("sam_hq", "SamHQModel"), ] ) ``` See https://github.com/huggingface/transformers/blob/d34e21e7dd392c76e7852d836b6f30ba1a2c5d62/src/transformers/models/auto/modeling_auto.py#L1521 https://github.com/huggingface/transformers/blob/d34e21e7dd392c76e7852d836b6f30ba1a2c5d62/src/transformers/models/auto/modeling_auto.py#L1527 Both entries should be merged into one ### Who can help? _No response_ ### Information - [ ] The official example scripts - [ ] My own modified scripts ### Tasks - [ ] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...) - [ ] My own task or dataset (give details below) ### Reproduction generator = pipeline("mask-generation", model="Zigeng/SlimSAM-uniform-77", device=device, points_per_batch=128) ### Expected behavior sam should work again, not only sam_hq
{ "login": "github-actions[bot]", "id": 41898282, "node_id": "MDM6Qm90NDE4OTgyODI=", "avatar_url": "https://avatars.githubusercontent.com/in/15368?v=4", "gravatar_id": "", "url": "https://api.github.com/users/github-actions%5Bbot%5D", "html_url": "https://github.com/apps/github-actions", "followers_url": "https://api.github.com/users/github-actions%5Bbot%5D/followers", "following_url": "https://api.github.com/users/github-actions%5Bbot%5D/following{/other_user}", "gists_url": "https://api.github.com/users/github-actions%5Bbot%5D/gists{/gist_id}", "starred_url": "https://api.github.com/users/github-actions%5Bbot%5D/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/github-actions%5Bbot%5D/subscriptions", "organizations_url": "https://api.github.com/users/github-actions%5Bbot%5D/orgs", "repos_url": "https://api.github.com/users/github-actions%5Bbot%5D/repos", "events_url": "https://api.github.com/users/github-actions%5Bbot%5D/events{/privacy}", "received_events_url": "https://api.github.com/users/github-actions%5Bbot%5D/received_events", "type": "Bot", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38228/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38228/timeline
null
completed
{ "total": 0, "completed": 0, "percent_completed": 0 }
{ "blocked_by": 0, "total_blocked_by": 0, "blocking": 0, "total_blocking": 0 }
false
true
https://api.github.com/repos/huggingface/transformers/issues/38227
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38227/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38227/comments
https://api.github.com/repos/huggingface/transformers/issues/38227/events
https://github.com/huggingface/transformers/pull/38227
3,076,722,334
PR_kwDOCUB6oc6W4F-0
38,227
Mamba2 remove unecessary test parameterization
{ "login": "ivarflakstad", "id": 69173633, "node_id": "MDQ6VXNlcjY5MTczNjMz", "avatar_url": "https://avatars.githubusercontent.com/u/69173633?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ivarflakstad", "html_url": "https://github.com/ivarflakstad", "followers_url": "https://api.github.com/users/ivarflakstad/followers", "following_url": "https://api.github.com/users/ivarflakstad/following{/other_user}", "gists_url": "https://api.github.com/users/ivarflakstad/gists{/gist_id}", "starred_url": "https://api.github.com/users/ivarflakstad/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ivarflakstad/subscriptions", "organizations_url": "https://api.github.com/users/ivarflakstad/orgs", "repos_url": "https://api.github.com/users/ivarflakstad/repos", "events_url": "https://api.github.com/users/ivarflakstad/events{/privacy}", "received_events_url": "https://api.github.com/users/ivarflakstad/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-20T11:45:12
2025-05-20T13:54:06
2025-05-20T13:54:05
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38227", "html_url": "https://github.com/huggingface/transformers/pull/38227", "diff_url": "https://github.com/huggingface/transformers/pull/38227.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38227.patch", "merged_at": "2025-05-20T13:54:04" }
null
{ "login": "ivarflakstad", "id": 69173633, "node_id": "MDQ6VXNlcjY5MTczNjMz", "avatar_url": "https://avatars.githubusercontent.com/u/69173633?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ivarflakstad", "html_url": "https://github.com/ivarflakstad", "followers_url": "https://api.github.com/users/ivarflakstad/followers", "following_url": "https://api.github.com/users/ivarflakstad/following{/other_user}", "gists_url": "https://api.github.com/users/ivarflakstad/gists{/gist_id}", "starred_url": "https://api.github.com/users/ivarflakstad/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ivarflakstad/subscriptions", "organizations_url": "https://api.github.com/users/ivarflakstad/orgs", "repos_url": "https://api.github.com/users/ivarflakstad/repos", "events_url": "https://api.github.com/users/ivarflakstad/events{/privacy}", "received_events_url": "https://api.github.com/users/ivarflakstad/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38227/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38227/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38226
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38226/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38226/comments
https://api.github.com/repos/huggingface/transformers/issues/38226/events
https://github.com/huggingface/transformers/pull/38226
3,076,604,700
PR_kwDOCUB6oc6W3sDz
38,226
Make `train_dataset` attribute in `_get_train_sampler` optional
{ "login": "SunMarc", "id": 57196510, "node_id": "MDQ6VXNlcjU3MTk2NTEw", "avatar_url": "https://avatars.githubusercontent.com/u/57196510?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SunMarc", "html_url": "https://github.com/SunMarc", "followers_url": "https://api.github.com/users/SunMarc/followers", "following_url": "https://api.github.com/users/SunMarc/following{/other_user}", "gists_url": "https://api.github.com/users/SunMarc/gists{/gist_id}", "starred_url": "https://api.github.com/users/SunMarc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SunMarc/subscriptions", "organizations_url": "https://api.github.com/users/SunMarc/orgs", "repos_url": "https://api.github.com/users/SunMarc/repos", "events_url": "https://api.github.com/users/SunMarc/events{/privacy}", "received_events_url": "https://api.github.com/users/SunMarc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-20T11:01:07
2025-05-20T12:59:54
2025-05-20T12:59:53
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38226", "html_url": "https://github.com/huggingface/transformers/pull/38226", "diff_url": "https://github.com/huggingface/transformers/pull/38226.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38226.patch", "merged_at": "2025-05-20T12:59:53" }
# What does this PR do? This PR fixes a breaking change that was caused by https://github.com/huggingface/transformers/pull/38090. We removed in that PR `train_dataset` arg but TRL lib uses it. We make it optional instead now
{ "login": "ArthurZucker", "id": 48595927, "node_id": "MDQ6VXNlcjQ4NTk1OTI3", "avatar_url": "https://avatars.githubusercontent.com/u/48595927?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ArthurZucker", "html_url": "https://github.com/ArthurZucker", "followers_url": "https://api.github.com/users/ArthurZucker/followers", "following_url": "https://api.github.com/users/ArthurZucker/following{/other_user}", "gists_url": "https://api.github.com/users/ArthurZucker/gists{/gist_id}", "starred_url": "https://api.github.com/users/ArthurZucker/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ArthurZucker/subscriptions", "organizations_url": "https://api.github.com/users/ArthurZucker/orgs", "repos_url": "https://api.github.com/users/ArthurZucker/repos", "events_url": "https://api.github.com/users/ArthurZucker/events{/privacy}", "received_events_url": "https://api.github.com/users/ArthurZucker/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38226/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38226/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/38225
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/38225/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/38225/comments
https://api.github.com/repos/huggingface/transformers/issues/38225/events
https://github.com/huggingface/transformers/pull/38225
3,076,544,657
PR_kwDOCUB6oc6W3eyD
38,225
Disable torchscript tests for AriaForConditionalGenerationModelTest
{ "login": "ivarflakstad", "id": 69173633, "node_id": "MDQ6VXNlcjY5MTczNjMz", "avatar_url": "https://avatars.githubusercontent.com/u/69173633?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ivarflakstad", "html_url": "https://github.com/ivarflakstad", "followers_url": "https://api.github.com/users/ivarflakstad/followers", "following_url": "https://api.github.com/users/ivarflakstad/following{/other_user}", "gists_url": "https://api.github.com/users/ivarflakstad/gists{/gist_id}", "starred_url": "https://api.github.com/users/ivarflakstad/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ivarflakstad/subscriptions", "organizations_url": "https://api.github.com/users/ivarflakstad/orgs", "repos_url": "https://api.github.com/users/ivarflakstad/repos", "events_url": "https://api.github.com/users/ivarflakstad/events{/privacy}", "received_events_url": "https://api.github.com/users/ivarflakstad/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-05-20T10:38:34
2025-05-20T12:37:57
2025-05-20T12:37:55
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/38225", "html_url": "https://github.com/huggingface/transformers/pull/38225", "diff_url": "https://github.com/huggingface/transformers/pull/38225.diff", "patch_url": "https://github.com/huggingface/transformers/pull/38225.patch", "merged_at": "2025-05-20T12:37:55" }
null
{ "login": "ivarflakstad", "id": 69173633, "node_id": "MDQ6VXNlcjY5MTczNjMz", "avatar_url": "https://avatars.githubusercontent.com/u/69173633?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ivarflakstad", "html_url": "https://github.com/ivarflakstad", "followers_url": "https://api.github.com/users/ivarflakstad/followers", "following_url": "https://api.github.com/users/ivarflakstad/following{/other_user}", "gists_url": "https://api.github.com/users/ivarflakstad/gists{/gist_id}", "starred_url": "https://api.github.com/users/ivarflakstad/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ivarflakstad/subscriptions", "organizations_url": "https://api.github.com/users/ivarflakstad/orgs", "repos_url": "https://api.github.com/users/ivarflakstad/repos", "events_url": "https://api.github.com/users/ivarflakstad/events{/privacy}", "received_events_url": "https://api.github.com/users/ivarflakstad/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/38225/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/38225/timeline
null
null
null
null
true
true