url
string
repository_url
string
labels_url
string
comments_url
string
events_url
string
html_url
string
id
int64
node_id
string
number
int64
title
string
user
dict
labels
list
state
string
locked
bool
assignee
dict
assignees
list
milestone
null
comments
list
created_at
timestamp[ms]
updated_at
timestamp[ms]
closed_at
timestamp[ms]
author_association
string
type
dict
active_lock_reason
null
draft
bool
pull_request
dict
body
string
closed_by
dict
reactions
dict
timeline_url
string
performed_via_github_app
null
state_reason
string
sub_issues_summary
dict
issue_dependencies_summary
dict
is_pull_request
bool
is_closed
bool
https://api.github.com/repos/huggingface/transformers/issues/41342
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41342/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41342/comments
https://api.github.com/repos/huggingface/transformers/issues/41342/events
https://github.com/huggingface/transformers/pull/41342
3,483,638,093
PR_kwDOCUB6oc6sFm-U
41,342
Make default RoPE path explicit in RotaryEmbedding classes
{ "login": "DevPatel-11", "id": 179735816, "node_id": "U_kgDOCraNCA", "avatar_url": "https://avatars.githubusercontent.com/u/179735816?v=4", "gravatar_id": "", "url": "https://api.github.com/users/DevPatel-11", "html_url": "https://github.com/DevPatel-11", "followers_url": "https://api.github.com/users/DevPatel-11/followers", "following_url": "https://api.github.com/users/DevPatel-11/following{/other_user}", "gists_url": "https://api.github.com/users/DevPatel-11/gists{/gist_id}", "starred_url": "https://api.github.com/users/DevPatel-11/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/DevPatel-11/subscriptions", "organizations_url": "https://api.github.com/users/DevPatel-11/orgs", "repos_url": "https://api.github.com/users/DevPatel-11/repos", "events_url": "https://api.github.com/users/DevPatel-11/events{/privacy}", "received_events_url": "https://api.github.com/users/DevPatel-11/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-04T12:16:18
2025-10-06T13:38:35
2025-10-06T13:36:03
NONE
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41342", "html_url": "https://github.com/huggingface/transformers/pull/41342", "diff_url": "https://github.com/huggingface/transformers/pull/41342.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41342.patch", "merged_at": null }
# 🧩 Pull Request: Make default RoPE path explicit in Llama RotaryEmbedding initialization ## 📜 Summary This PR addresses issue [#39753](https://github.com/huggingface/transformers/issues/39753), ensuring that the *default* Rotary Positional Embedding (RoPE) initialization path is made explicit in the Llama model. Previously, `inv_freq` was implicitly assigned, which went against the library’s philosophy of explicit initialization for reproducibility and clarity. This change: - Makes the `"default"` RoPE path explicit by selecting `ROPE_INIT_FUNCTIONS["default"]` when `self.rope_type == "default"`. - Uses `ROPE_INIT_FUNCTIONS[self.rope_type]` for non-default cases. - Keeps the initialization logic (`inv_freq`, `attention_scaling`) delegated to the RoPE function—no manual computation is done in the constructor. The modification is minimal, isolated, and maintains backward compatibility. --- ## 🧠 Motivation Following the discussion in [#39753](https://github.com/huggingface/transformers/issues/39753), the goal is to make RoPE initialization behavior transparent and avoid implicit defaults. This aligns with 🤗 Transformers’ philosophy of **clarity and explicit model configuration**. --- ## 🛠️ Changes Made In `transformers/src/transformers/models/llama/modeling_llama.py` and more 20 models: ```python self.config = config if self.rope_type == "default": self.rope_init_fn = ROPE_INIT_FUNCTIONS["default"] else: self.rope_init_fn = ROPE_INIT_FUNCTIONS[self.rope_type] inv_freq, self.attention_scaling = self.rope_init_fn(self.config, device) ``` - Delegates all logic to the existing RoPE functions. - Reduces potential maintenance risk by avoiding any new computation paths. - Keeps `inv_freq` and `attention_scaling` initialization consistent with the rest of the library. --- ## ✅ Checklist - [x] The PR title summarizes the contribution. - [x] Linked to issue [#39753](https://github.com/huggingface/transformers/issues/39753). - [x] Tested locally — no change in model outputs or test failures. - [x] Backward compatible (no breaking changes). --- ## 🧪 Testing - Verified initialization behavior for both `"default"` and non-default RoPE types. - Confirmed no change in model outputs. - Ran relevant test subset: ```bash pytest ``` --- ## 💬 Additional Notes This is a small but meaningful cleanup that improves code readability and aligns initialization logic with the library’s explicit philosophy. No other files or RoPE logic were touched.
{ "login": "DevPatel-11", "id": 179735816, "node_id": "U_kgDOCraNCA", "avatar_url": "https://avatars.githubusercontent.com/u/179735816?v=4", "gravatar_id": "", "url": "https://api.github.com/users/DevPatel-11", "html_url": "https://github.com/DevPatel-11", "followers_url": "https://api.github.com/users/DevPatel-11/followers", "following_url": "https://api.github.com/users/DevPatel-11/following{/other_user}", "gists_url": "https://api.github.com/users/DevPatel-11/gists{/gist_id}", "starred_url": "https://api.github.com/users/DevPatel-11/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/DevPatel-11/subscriptions", "organizations_url": "https://api.github.com/users/DevPatel-11/orgs", "repos_url": "https://api.github.com/users/DevPatel-11/repos", "events_url": "https://api.github.com/users/DevPatel-11/events{/privacy}", "received_events_url": "https://api.github.com/users/DevPatel-11/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41342/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41342/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41341
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41341/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41341/comments
https://api.github.com/repos/huggingface/transformers/issues/41341/events
https://github.com/huggingface/transformers/issues/41341
3,483,628,548
I_kwDOCUB6oc7Po_QE
41,341
Cannot install latest transformers version 4.57.0 in free-threaded python version 3.14
{ "login": "fleonce", "id": 8986525, "node_id": "MDQ6VXNlcjg5ODY1MjU=", "avatar_url": "https://avatars.githubusercontent.com/u/8986525?v=4", "gravatar_id": "", "url": "https://api.github.com/users/fleonce", "html_url": "https://github.com/fleonce", "followers_url": "https://api.github.com/users/fleonce/followers", "following_url": "https://api.github.com/users/fleonce/following{/other_user}", "gists_url": "https://api.github.com/users/fleonce/gists{/gist_id}", "starred_url": "https://api.github.com/users/fleonce/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/fleonce/subscriptions", "organizations_url": "https://api.github.com/users/fleonce/orgs", "repos_url": "https://api.github.com/users/fleonce/repos", "events_url": "https://api.github.com/users/fleonce/events{/privacy}", "received_events_url": "https://api.github.com/users/fleonce/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 3817266200, "node_id": "MDU6TGFiZWwzODE3MjY2MjAw", "url": "https://api.github.com/repos/huggingface/transformers/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": null } ]
open
false
null
[]
null
[]
2025-10-04T12:07:45
2025-10-13T15:03:38
null
CONTRIBUTOR
null
null
null
null
### System Info On Debian 12 with `Python 3.14.0rc3 free-threading build (main, Oct 3 2025, 22:25:41) [GCC 12.2.0]` the following command fails: `pip install transformers`, since hf-xet cannot be installed due to the following error: ``` Building wheels for collected packages: hf-xet Building wheel for hf-xet (pyproject.toml) ... error error: subprocess-exited-with-error × Building wheel for hf-xet (pyproject.toml) did not run successfully. │ exit code: 1 ╰─> [263 lines of output] Running `maturin pep517 build-wheel -i /home/x/.threaded/bin/python --compatibility off` Python reports SOABI: cpython-314t-x86_64-linux-gnu Computed rustc target triple: x86_64-unknown-linux-gnu Installation directory: /home/x/.cache/puccinialin Rustup already downloaded Installing rust to /home/x/.cache/puccinialin/rustup warn: It looks like you have an existing rustup settings file at: warn: /home/x/.rustup/settings.toml warn: Rustup will install the default toolchain as specified in the settings file, warn: instead of the one inferred from the default host triple. info: profile set to 'minimal' info: default host triple is x86_64-unknown-linux-gnu warn: Updating existing toolchain, profile choice will be ignored info: syncing channel updates for 'stable-x86_64-unknown-linux-gnu' info: default toolchain set to 'stable-x86_64-unknown-linux-gnu' Checking if cargo is installed cargo 1.90.0 (840b83a10 2025-07-30) ⚠️ Warning: You specified the python source as /tmp/pip-install-haqniebn/hf-xet_cf9de919019944f9af86b1a64876b431/hf_xet/python, but the python module at /tmp/pip-install-haqniebn/hf-xet_cf9de919019944f9af86b1a64876b431/hf_xet/python/hf_xet is missing. No python module will be included. 🔗 Found pyo3 bindings with abi3 support 🐍 Not using a specific python interpreter 📡 Using build options features from pyproject.toml ⚠️ Warning: CPython 3.14t at /home/x/.threaded/bin/python does not yet support abi3 so the build artifacts will be version-specific. Compiling proc-macro2 v1.0.101 Compiling unicode-ident v1.0.18 Compiling libc v0.2.175 Compiling cfg-if v1.0.1 Compiling shlex v1.3.0 Compiling memchr v2.7.5 Compiling itoa v1.0.15 Compiling once_cell v1.21.3 Compiling pin-project-lite v0.2.16 Compiling serde v1.0.219 Compiling bytes v1.10.1 Compiling futures-core v0.3.31 Compiling zerocopy v0.8.26 Compiling futures-sink v0.3.31 Compiling cc v1.2.33 Compiling ryu v1.0.20 Compiling serde_json v1.0.142 Compiling tracing-core v0.1.34 Compiling futures-channel v0.3.31 Compiling pin-utils v0.1.0 Compiling futures-io v0.3.31 Compiling getrandom v0.3.3 Compiling futures-task v0.3.31 Compiling stable_deref_trait v1.2.0 Compiling slab v0.4.11 Compiling crossbeam-utils v0.8.21 Compiling smallvec v1.15.1 Compiling base64 v0.22.1 Compiling autocfg v1.5.0 Compiling thiserror v2.0.15 Compiling lazy_static v1.5.0 Compiling pkg-config v0.3.32 Compiling option-ext v0.2.0 Compiling target-lexicon v0.12.16 Compiling fnv v1.0.7 Compiling litemap v0.8.0 Compiling byteorder v1.5.0 Compiling writeable v0.6.1 Compiling zeroize v1.8.1 Compiling bytemuck v1.23.2 Compiling quote v1.0.40 Compiling crossbeam-queue v0.3.12 Compiling heed-traits v0.8.0 Compiling rustls-pki-types v1.12.0 Compiling http v1.3.1 Compiling syn v2.0.106 Compiling mio v1.0.4 Compiling socket2 v0.6.0 Compiling getrandom v0.2.16 Compiling synchronoise v1.0.1 Compiling page_size v0.4.2 Compiling rand_core v0.9.3 Compiling untrusted v0.9.0 Compiling icu_normalizer_data v2.0.0 Compiling constant_time_eq v0.3.1 Compiling arrayref v0.3.9 Compiling icu_properties_data v2.0.1 Compiling syn v1.0.109 Compiling bitflags v2.9.2 Compiling arrayvec v0.7.6 Compiling pyo3-build-config v0.23.5 Compiling dirs-sys v0.5.0 Compiling ring v0.17.14 Compiling lmdb-rkv-sys v0.11.2 Compiling blake3 v1.8.2 Compiling anstyle v1.0.11 Compiling httparse v1.10.1 Compiling percent-encoding v2.3.1 Compiling safe-transmute v0.11.3 Compiling http-body v1.0.1 Compiling dtor-proc-macro v0.0.5 Compiling dirs v6.0.0 Compiling thiserror v1.0.69 Compiling dtor v0.0.6 Compiling ppv-lite86 v0.2.21 Compiling heck v0.5.0 Compiling ctor-proc-macro v0.0.6 Compiling rustls v0.23.31 Compiling try-lock v0.2.5 Compiling tower-service v0.3.3 Compiling want v0.3.1 Compiling shellexpand v3.1.1 Compiling ctor v0.4.3 Compiling aho-corasick v1.1.3 Compiling anyhow v1.0.99 Compiling subtle v2.6.1 Compiling rand_chacha v0.9.0 Compiling log v0.4.27 Compiling regex-syntax v0.8.5 Compiling rand v0.9.2 Compiling atomic-waker v1.1.2 Compiling utf8parse v0.2.2 Compiling anstyle-parse v0.2.7 Compiling form_urlencoded v1.2.1 Compiling sync_wrapper v1.0.2 Compiling anstyle-query v1.1.4 Compiling ipnet v2.11.0 Compiling rustix v1.0.8 Compiling utf8_iter v1.0.4 Compiling colorchoice v1.0.4 Compiling is_terminal_polyfill v1.70.1 Compiling tower-layer v0.3.3 Compiling openssl-probe v0.1.6 Compiling anstream v0.6.20 Compiling rustls-native-certs v0.8.1 Compiling webpki-roots v1.0.2 Compiling rand_core v0.6.4 Compiling num-traits v0.2.19 Compiling iri-string v0.7.8 Compiling linux-raw-sys v0.9.4 Compiling typenum v1.18.0 Compiling strsim v0.11.1 Compiling clap_lex v0.7.5 Compiling version_check v0.9.5 Compiling clap_builder v4.5.44 Compiling generic-array v0.14.7 Compiling rand_chacha v0.3.1 Compiling http-body-util v0.1.3 Compiling fastrand v2.3.0 Compiling either v1.15.0 Compiling predicates-core v1.0.9 Compiling regex-automata v0.4.9 Compiling mockall_derive v0.13.1 Compiling itertools v0.14.0 Compiling rand v0.8.5 Compiling derivative v2.2.0 Compiling synstructure v0.13.2 Compiling tempfile v3.20.0 Compiling uuid v1.18.0 Compiling cfg-if v0.1.10 Compiling static_assertions v1.1.0 Compiling heapify v0.2.0 Compiling time-core v0.1.4 Compiling num-conv v0.1.0 Compiling powerfmt v0.2.0 Compiling termtree v0.5.1 Compiling crc32fast v1.5.0 Compiling more-asserts v0.3.1 Compiling time-macros v0.2.22 Compiling deranged v0.4.0 Compiling predicates-tree v1.0.12 Compiling gearhash v0.1.3 Compiling predicates v3.1.3 Compiling lock_api v0.4.13 Compiling colored v2.2.0 Compiling csv-core v0.1.12 Compiling downcast v0.11.0 Compiling serde_derive v1.0.219 Compiling tokio-macros v2.5.0 Compiling zerofrom-derive v0.1.6 Compiling tracing-attributes v0.1.30 Compiling yoke-derive v0.8.0 Compiling futures-macro v0.3.31 Compiling zerovec-derive v0.11.1 Compiling displaydoc v0.2.5 Compiling tokio v1.47.1 Compiling thiserror-impl v2.0.15 Compiling async-trait v0.1.89 Compiling futures-util v0.3.31 Compiling pin-project-internal v1.1.10 Compiling rustls-webpki v0.103.4 Compiling tracing v0.1.41 Compiling zerofrom v0.1.6 Compiling yoke v0.8.0 Compiling error_printer v0.14.5 (/tmp/pip-install-haqniebn/hf-xet_cf9de919019944f9af86b1a64876b431/error_printer) Compiling thiserror-impl v1.0.69 Compiling zerovec v0.11.4 Compiling zerotrie v0.2.2 Compiling regex v1.11.1 Compiling clap_derive v4.5.45 Compiling pin-project v1.1.10 Compiling serde_repr v0.1.20 Compiling tinystr v0.8.1 Compiling potential_utf v0.1.2 Compiling icu_collections v2.0.0 Compiling whoami v1.6.1 Compiling icu_locale_core v2.0.0 Compiling fragile v2.0.1 Compiling twox-hash v2.1.1 Compiling parking_lot_core v0.9.11 Compiling lz4_flex v0.11.5 Compiling time v0.3.41 Compiling file_utils v0.14.2 (/tmp/pip-install-haqniebn/hf-xet_cf9de919019944f9af86b1a64876b431/file_utils) Compiling icu_provider v2.0.0 Compiling futures-executor v0.3.31 Compiling num-integer v0.1.46 Compiling retry-policies v0.4.0 Compiling futures v0.3.31 Compiling icu_properties v2.0.1 Compiling icu_normalizer v2.0.0 Compiling pyo3-macros-backend v0.23.5 Compiling pyo3-ffi v0.23.5 Compiling sha2-asm v0.6.4 Compiling countio v0.2.19 Compiling clap v4.5.45 Compiling half v2.6.0 Compiling regex-syntax v0.6.29 Compiling oneshot v0.1.11 Compiling scopeguard v1.2.0 Compiling protobuf v3.7.2 Compiling num-bigint v0.4.6 error: failed to run custom build command for `pyo3-ffi v0.23.5` Caused by: process didn't exit successfully: `/tmp/pip-install-haqniebn/hf-xet_cf9de919019944f9af86b1a64876b431/hf_xet/target/release/build/pyo3-ffi-f89ed39e89227bf3/build-script-build` (exit status: 1) --- stdout cargo:rustc-check-cfg=cfg(Py_LIMITED_API) cargo:rustc-check-cfg=cfg(Py_GIL_DISABLED) cargo:rustc-check-cfg=cfg(PyPy) cargo:rustc-check-cfg=cfg(GraalPy) cargo:rustc-check-cfg=cfg(py_sys_config, values("Py_DEBUG", "Py_REF_DEBUG", "Py_TRACE_REFS", "COUNT_ALLOCS")) cargo:rustc-check-cfg=cfg(invalid_from_utf8_lint) cargo:rustc-check-cfg=cfg(pyo3_disable_reference_pool) cargo:rustc-check-cfg=cfg(pyo3_leak_on_drop_without_reference_pool) cargo:rustc-check-cfg=cfg(diagnostic_namespace) cargo:rustc-check-cfg=cfg(c_str_lit) cargo:rustc-check-cfg=cfg(rustc_has_once_lock) cargo:rustc-check-cfg=cfg(fn_ptr_eq) cargo:rustc-check-cfg=cfg(Py_3_7) cargo:rustc-check-cfg=cfg(Py_3_8) cargo:rustc-check-cfg=cfg(Py_3_9) cargo:rustc-check-cfg=cfg(Py_3_10) cargo:rustc-check-cfg=cfg(Py_3_11) cargo:rustc-check-cfg=cfg(Py_3_12) cargo:rustc-check-cfg=cfg(Py_3_13) cargo:rerun-if-env-changed=PYO3_CROSS cargo:rerun-if-env-changed=PYO3_CROSS_LIB_DIR cargo:rerun-if-env-changed=PYO3_CROSS_PYTHON_VERSION cargo:rerun-if-env-changed=PYO3_CROSS_PYTHON_IMPLEMENTATION cargo:rerun-if-env-changed=PYO3_PRINT_CONFIG --- stderr error: The configured Python interpreter version (3.14) is newer than PyO3's maximum supported version (3.13) = help: please check if an updated version of PyO3 is available. Current version: 0.23.5 = help: The free-threaded build of CPython does not support the limited API so this check cannot be suppressed. warning: build failed, waiting for other jobs to finish... 💥 maturin failed Caused by: Failed to build a native library through cargo Caused by: Cargo build finished with "exit status: 101": `env -u CARGO PYO3_BUILD_EXTENSION_MODULE="1" PYO3_ENVIRONMENT_SIGNATURE="cpython-3.14-64bit" PYO3_PYTHON="/home/x/.threaded/bin/python" PYTHON_SYS_EXECUTABLE="/home/x/.threaded/bin/python" "cargo" "rustc" "--features" "pyo3/extension-module" "--message-format" "json-render-diagnostics" "--manifest-path" "/tmp/pip-install-haqniebn/hf-xet_cf9de919019944f9af86b1a64876b431/hf_xet/Cargo.toml" "--release" "--lib"` Rust not found, installing into a temporary directory Error: command ['maturin', 'pep517', 'build-wheel', '-i', '/home/x/.threaded/bin/python', '--compatibility', 'off'] returned non-zero exit status 1 [end of output] note: This error originates from a subprocess, and is likely not a problem with pip. ERROR: Failed building wheel for hf-xet Failed to build hf-xet error: failed-wheel-build-for-install × Failed to build installable wheels for some pyproject.toml based projects ╰─> hf-xet ``` apparently, supporting this is current not planned (?) https://github.com/huggingface/xet-core/issues/512 Current fallback is installing older versions of huggingface_hub and transformers to bypass this issue (f.e. transformers 4.49.0, huggingface_hub 0.31.4) ### Who can help? _No response_ ### Information - [ ] The official example scripts - [ ] My own modified scripts ### Tasks - [ ] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...) - [ ] My own task or dataset (give details below) ### Reproduction Steps to reproduce the issue: 1. Setup a new virtual environment with Python 3.14 via `python3.14t -m venv .venv` 2. Install latest transformers via `.venv/bin/pip install transformers` ### Expected behavior Install should just work (?)
null
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41341/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41341/timeline
null
null
{ "total": 0, "completed": 0, "percent_completed": 0 }
{ "blocked_by": 0, "total_blocked_by": 0, "blocking": 0, "total_blocking": 0 }
false
false
https://api.github.com/repos/huggingface/transformers/issues/41340
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41340/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41340/comments
https://api.github.com/repos/huggingface/transformers/issues/41340/events
https://github.com/huggingface/transformers/pull/41340
3,483,605,679
PR_kwDOCUB6oc6sFgSU
41,340
🌐 [i18n-KO] Translated sam_hq.md to Korean
{ "login": "HyunZ118", "id": 156191095, "node_id": "U_kgDOCU9Jdw", "avatar_url": "https://avatars.githubusercontent.com/u/156191095?v=4", "gravatar_id": "", "url": "https://api.github.com/users/HyunZ118", "html_url": "https://github.com/HyunZ118", "followers_url": "https://api.github.com/users/HyunZ118/followers", "following_url": "https://api.github.com/users/HyunZ118/following{/other_user}", "gists_url": "https://api.github.com/users/HyunZ118/gists{/gist_id}", "starred_url": "https://api.github.com/users/HyunZ118/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/HyunZ118/subscriptions", "organizations_url": "https://api.github.com/users/HyunZ118/orgs", "repos_url": "https://api.github.com/users/HyunZ118/repos", "events_url": "https://api.github.com/users/HyunZ118/events{/privacy}", "received_events_url": "https://api.github.com/users/HyunZ118/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-04T11:45:17
2025-10-16T18:10:16
2025-10-16T18:10:16
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41340", "html_url": "https://github.com/huggingface/transformers/pull/41340", "diff_url": "https://github.com/huggingface/transformers/pull/41340.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41340.patch", "merged_at": "2025-10-16T18:10:16" }
# What does this PR do? Translated the sam_hq.md file of the documentation to Korean. Thank you in advance for your review. Part of https://github.com/huggingface/transformers/issues/20179 ## Before reviewing - [x] Check for missing / redundant translations (번역 누락/중복 검사) - [x] Grammar Check (맞춤법 검사) - [x] Review or Add new terms to glossary (용어 확인 및 추가) - [x] Check Inline TOC (e.g. `[[lowercased-header]]`) - [x] Check live-preview for gotchas (live-preview로 정상작동 확인) ## Who can review? (Initial) @jungnerd, @yijun-lee, @Kim-Ju-won, @FacerAin, @judy-choi, @AhnJoonSung, @maximizemaxwell, @nsbg
{ "login": "stevhliu", "id": 59462357, "node_id": "MDQ6VXNlcjU5NDYyMzU3", "avatar_url": "https://avatars.githubusercontent.com/u/59462357?v=4", "gravatar_id": "", "url": "https://api.github.com/users/stevhliu", "html_url": "https://github.com/stevhliu", "followers_url": "https://api.github.com/users/stevhliu/followers", "following_url": "https://api.github.com/users/stevhliu/following{/other_user}", "gists_url": "https://api.github.com/users/stevhliu/gists{/gist_id}", "starred_url": "https://api.github.com/users/stevhliu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/stevhliu/subscriptions", "organizations_url": "https://api.github.com/users/stevhliu/orgs", "repos_url": "https://api.github.com/users/stevhliu/repos", "events_url": "https://api.github.com/users/stevhliu/events{/privacy}", "received_events_url": "https://api.github.com/users/stevhliu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41340/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41340/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41339
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41339/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41339/comments
https://api.github.com/repos/huggingface/transformers/issues/41339/events
https://github.com/huggingface/transformers/issues/41339
3,483,444,046
I_kwDOCUB6oc7PoSNO
41,339
Transformers 4.57.0 declares compatibility with Python>=3.9 but is only compatible with >=3.10
{ "login": "anakin87", "id": 44616784, "node_id": "MDQ6VXNlcjQ0NjE2Nzg0", "avatar_url": "https://avatars.githubusercontent.com/u/44616784?v=4", "gravatar_id": "", "url": "https://api.github.com/users/anakin87", "html_url": "https://github.com/anakin87", "followers_url": "https://api.github.com/users/anakin87/followers", "following_url": "https://api.github.com/users/anakin87/following{/other_user}", "gists_url": "https://api.github.com/users/anakin87/gists{/gist_id}", "starred_url": "https://api.github.com/users/anakin87/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/anakin87/subscriptions", "organizations_url": "https://api.github.com/users/anakin87/orgs", "repos_url": "https://api.github.com/users/anakin87/repos", "events_url": "https://api.github.com/users/anakin87/events{/privacy}", "received_events_url": "https://api.github.com/users/anakin87/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 3817266200, "node_id": "MDU6TGFiZWwzODE3MjY2MjAw", "url": "https://api.github.com/repos/huggingface/transformers/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": null } ]
closed
false
null
[]
null
[]
2025-10-04T09:08:52
2025-10-23T12:17:36
2025-10-23T12:17:36
CONTRIBUTOR
null
null
null
null
### System Info - `transformers` version: 4.57.0 - Platform: macOS-15.7-arm64-arm-64bit - Python version: 3.9.6 - Huggingface_hub version: 0.35.3 - Safetensors version: 0.6.2 - Accelerate version: 1.10.1 - Accelerate config: not found - DeepSpeed version: not installed - PyTorch version (accelerator?): 2.8.0 (NA) - Tensorflow version (GPU?): not installed (NA) - Flax version (CPU?/GPU?/TPU?): not installed (NA) - Jax version: not installed - JaxLib version: not installed - Using distributed or parallel set-up in script?: <fill in> ### Who can help? _No response_ ### Information - [x] The official example scripts - [ ] My own modified scripts ### Tasks - [ ] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...) - [ ] My own task or dataset (give details below) ### Reproduction 1. Use Python 3.9 and do `pip install -U "transformers[torch]"` 2. `from transformers import Trainer` Error: ``` Traceback (most recent call last): File "<stdin>", line 1, in <module> File "<frozen importlib._bootstrap>", line 1055, in _handle_fromlist File "/omitted/.venv/lib/python3.9/site-packages/transformers/utils/import_utils.py", line 2317, in __getattr__ module = self._get_module(self._class_to_module[name]) File "/omitted/.venv/lib/python3.9/site-packages/transformers/utils/import_utils.py", line 2347, in _get_module raise e File "/omitted/.venv/lib/python3.9/site-packages/transformers/utils/import_utils.py", line 2345, in _get_module return importlib.import_module("." + module_name, self.__name__) File "/Library/Developer/CommandLineTools/Library/Frameworks/Python3.framework/Versions/3.9/lib/python3.9/importlib/__init__.py", line 127, in import_module return _bootstrap._gcd_import(name[level:], package, level) File "/omitted/.venv/lib/python3.9/site-packages/transformers/trainer.py", line 311, in <module> class Trainer: File "/omitted/.venv/lib/python3.9/site-packages/transformers/trainer.py", line 5593, in Trainer def _get_num_items_in_batch(self, batch_samples: list, device: torch.device) -> int | None: TypeError: unsupported operand type(s) for |: 'type' and 'NoneType' ``` ### Expected behavior Currently, Transformers [requires Python>=3.9](https://pypi.org/project/transformers/4.57.0/) but only works with Python>=3.10 I see two possible solutions: - Python 3.9 is reaching its End Of Life this month, so I think it can be dropped - Modify the implementations to remove syntaxes that are only supported in >=3.10 (such as `|` instead of `Union`)
{ "login": "SunMarc", "id": 57196510, "node_id": "MDQ6VXNlcjU3MTk2NTEw", "avatar_url": "https://avatars.githubusercontent.com/u/57196510?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SunMarc", "html_url": "https://github.com/SunMarc", "followers_url": "https://api.github.com/users/SunMarc/followers", "following_url": "https://api.github.com/users/SunMarc/following{/other_user}", "gists_url": "https://api.github.com/users/SunMarc/gists{/gist_id}", "starred_url": "https://api.github.com/users/SunMarc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SunMarc/subscriptions", "organizations_url": "https://api.github.com/users/SunMarc/orgs", "repos_url": "https://api.github.com/users/SunMarc/repos", "events_url": "https://api.github.com/users/SunMarc/events{/privacy}", "received_events_url": "https://api.github.com/users/SunMarc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41339/reactions", "total_count": 2, "+1": 2, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41339/timeline
null
completed
{ "total": 0, "completed": 0, "percent_completed": 0 }
{ "blocked_by": 0, "total_blocked_by": 0, "blocking": 0, "total_blocking": 0 }
false
true
https://api.github.com/repos/huggingface/transformers/issues/41338
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41338/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41338/comments
https://api.github.com/repos/huggingface/transformers/issues/41338/events
https://github.com/huggingface/transformers/pull/41338
3,483,416,494
PR_kwDOCUB6oc6sE59l
41,338
Add Setup section to README for dev dependencies and doc-builder
{ "login": "Karthikg998", "id": 178138088, "node_id": "U_kgDOCp4r6A", "avatar_url": "https://avatars.githubusercontent.com/u/178138088?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Karthikg998", "html_url": "https://github.com/Karthikg998", "followers_url": "https://api.github.com/users/Karthikg998/followers", "following_url": "https://api.github.com/users/Karthikg998/following{/other_user}", "gists_url": "https://api.github.com/users/Karthikg998/gists{/gist_id}", "starred_url": "https://api.github.com/users/Karthikg998/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Karthikg998/subscriptions", "organizations_url": "https://api.github.com/users/Karthikg998/orgs", "repos_url": "https://api.github.com/users/Karthikg998/repos", "events_url": "https://api.github.com/users/Karthikg998/events{/privacy}", "received_events_url": "https://api.github.com/users/Karthikg998/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-04T08:41:25
2025-10-06T11:00:02
2025-10-06T10:59:17
NONE
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41338", "html_url": "https://github.com/huggingface/transformers/pull/41338", "diff_url": "https://github.com/huggingface/transformers/pull/41338.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41338.patch", "merged_at": null }
Title: Add Setup section for installing dev dependencies and doc-builder Description: This PR adds a Setup section to docs/README.md that guides contributors on installing the necessary development dependencies and the Hugging Face doc-builder tool. This makes it easier for new contributors to generate and preview documentation locally. Motivation & Context: Improves contributor onboarding with clear setup instructions. Ensures the documentation can be built locally without errors. Checklist: Improves documentation. Follows contributor guidelines. No new tests are required (documentation-only change). Who can review: Any contributor familiar with documentation or the docs setup. @zucchini-nlp tagging for prioritising review
{ "login": "Karthikg998", "id": 178138088, "node_id": "U_kgDOCp4r6A", "avatar_url": "https://avatars.githubusercontent.com/u/178138088?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Karthikg998", "html_url": "https://github.com/Karthikg998", "followers_url": "https://api.github.com/users/Karthikg998/followers", "following_url": "https://api.github.com/users/Karthikg998/following{/other_user}", "gists_url": "https://api.github.com/users/Karthikg998/gists{/gist_id}", "starred_url": "https://api.github.com/users/Karthikg998/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Karthikg998/subscriptions", "organizations_url": "https://api.github.com/users/Karthikg998/orgs", "repos_url": "https://api.github.com/users/Karthikg998/repos", "events_url": "https://api.github.com/users/Karthikg998/events{/privacy}", "received_events_url": "https://api.github.com/users/Karthikg998/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41338/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41338/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41337
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41337/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41337/comments
https://api.github.com/repos/huggingface/transformers/issues/41337/events
https://github.com/huggingface/transformers/pull/41337
3,482,894,432
PR_kwDOCUB6oc6sDN5q
41,337
make some ut cases pass on xpu w/ latest torch
{ "login": "yao-matrix", "id": 7245027, "node_id": "MDQ6VXNlcjcyNDUwMjc=", "avatar_url": "https://avatars.githubusercontent.com/u/7245027?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yao-matrix", "html_url": "https://github.com/yao-matrix", "followers_url": "https://api.github.com/users/yao-matrix/followers", "following_url": "https://api.github.com/users/yao-matrix/following{/other_user}", "gists_url": "https://api.github.com/users/yao-matrix/gists{/gist_id}", "starred_url": "https://api.github.com/users/yao-matrix/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yao-matrix/subscriptions", "organizations_url": "https://api.github.com/users/yao-matrix/orgs", "repos_url": "https://api.github.com/users/yao-matrix/repos", "events_url": "https://api.github.com/users/yao-matrix/events{/privacy}", "received_events_url": "https://api.github.com/users/yao-matrix/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-03T23:50:16
2025-10-06T18:09:32
2025-10-06T15:38:01
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41337", "html_url": "https://github.com/huggingface/transformers/pull/41337", "diff_url": "https://github.com/huggingface/transformers/pull/41337.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41337.patch", "merged_at": "2025-10-06T15:38:01" }
make below 12 cases pass on XPU w/ latest torch. > tests/models/llava/test_modeling_llava.py::LlavaForConditionalGenerationIntegrationTest::test_pixtral > tests/models/llava/test_modeling_llava.py::LlavaForConditionalGenerationIntegrationTest::test_pixtral_4bit > tests/models/llava/test_modeling_llava.py::LlavaForConditionalGenerationIntegrationTest::test_pixtral_batched > tests/models/aya_vision/test_modeling_aya_vision.py::AyaVisionIntegrationTest::test_small_model_integration_batched_generate > tests/models/gemma3/test_modeling_gemma3.py::Gemma3IntegrationTest::test_model_4b_batch > tests/models/gemma3/test_modeling_gemma3.py::Gemma3IntegrationTest::test_model_4b_batch_crops > tests/models/gemma3/test_modeling_gemma3.py::Gemma3IntegrationTest::test_model_4b_multiimage > tests/models/glm4v/test_processor_glm4v.py::Glm4vProcessorTest::test_apply_chat_template_video_frame_sampling > tests/models/internvl/test_modeling_internvl.py::InternVLLlamaIntegrationTest::test_llama_small_model_integration_batched_generate > tests/models/internvl/test_modeling_internvl.py::InternVLQwen2IntegrationTest::test_qwen2_small_model_integration_batched_generate > tests/models/llava_onevision/test_modeling_llava_onevision.py::LlavaOnevisionForConditionalGenerationIntegrationTest::test_small_model_integration_test_multi_image > tests/models/llava_onevision/test_modeling_llava_onevision.py::LlavaOnevisionForConditionalGenerationIntegrationTest::test_small_model_integration_test_multi_image_nested @SunMarc @ydshieh , pls help review, thx very much.
{ "login": "SunMarc", "id": 57196510, "node_id": "MDQ6VXNlcjU3MTk2NTEw", "avatar_url": "https://avatars.githubusercontent.com/u/57196510?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SunMarc", "html_url": "https://github.com/SunMarc", "followers_url": "https://api.github.com/users/SunMarc/followers", "following_url": "https://api.github.com/users/SunMarc/following{/other_user}", "gists_url": "https://api.github.com/users/SunMarc/gists{/gist_id}", "starred_url": "https://api.github.com/users/SunMarc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SunMarc/subscriptions", "organizations_url": "https://api.github.com/users/SunMarc/orgs", "repos_url": "https://api.github.com/users/SunMarc/repos", "events_url": "https://api.github.com/users/SunMarc/events{/privacy}", "received_events_url": "https://api.github.com/users/SunMarc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41337/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41337/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41336
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41336/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41336/comments
https://api.github.com/repos/huggingface/transformers/issues/41336/events
https://github.com/huggingface/transformers/issues/41336
3,482,737,704
I_kwDOCUB6oc7Pllwo
41,336
is there a bug in group_videos_by_shape for qwenvl video preprocessiong?
{ "login": "dichencd", "id": 22802700, "node_id": "MDQ6VXNlcjIyODAyNzAw", "avatar_url": "https://avatars.githubusercontent.com/u/22802700?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dichencd", "html_url": "https://github.com/dichencd", "followers_url": "https://api.github.com/users/dichencd/followers", "following_url": "https://api.github.com/users/dichencd/following{/other_user}", "gists_url": "https://api.github.com/users/dichencd/gists{/gist_id}", "starred_url": "https://api.github.com/users/dichencd/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dichencd/subscriptions", "organizations_url": "https://api.github.com/users/dichencd/orgs", "repos_url": "https://api.github.com/users/dichencd/repos", "events_url": "https://api.github.com/users/dichencd/events{/privacy}", "received_events_url": "https://api.github.com/users/dichencd/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 3817266200, "node_id": "MDU6TGFiZWwzODE3MjY2MjAw", "url": "https://api.github.com/repos/huggingface/transformers/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": null } ]
closed
false
null
[]
null
[]
2025-10-03T22:26:26
2025-10-03T22:44:43
2025-10-03T22:44:43
NONE
null
null
null
null
### System Info in src/transformers/video_utils.py, group_videos_by_shape grouped_videos = {shape: torch.stack(videos, dim=0) for shape, videos in grouped_videos.items()}, where each video is of shape BTCHW. This will create a new dimension. However, in qwenvl video preprocess batch_size, grid_t, channel = patches.shape[:3] It does not consider the additional dimension created in group_videos_by_shape I think we should use torch.cat, not torch.stack? @yonigozlan @molbap ### Who can help? _No response_ ### Information - [ ] The official example scripts - [ ] My own modified scripts ### Tasks - [ ] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...) - [ ] My own task or dataset (give details below) ### Reproduction running video preprocessing with list of video inputs, each with different shape ### Expected behavior run without error
{ "login": "dichencd", "id": 22802700, "node_id": "MDQ6VXNlcjIyODAyNzAw", "avatar_url": "https://avatars.githubusercontent.com/u/22802700?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dichencd", "html_url": "https://github.com/dichencd", "followers_url": "https://api.github.com/users/dichencd/followers", "following_url": "https://api.github.com/users/dichencd/following{/other_user}", "gists_url": "https://api.github.com/users/dichencd/gists{/gist_id}", "starred_url": "https://api.github.com/users/dichencd/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dichencd/subscriptions", "organizations_url": "https://api.github.com/users/dichencd/orgs", "repos_url": "https://api.github.com/users/dichencd/repos", "events_url": "https://api.github.com/users/dichencd/events{/privacy}", "received_events_url": "https://api.github.com/users/dichencd/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41336/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41336/timeline
null
completed
{ "total": 0, "completed": 0, "percent_completed": 0 }
{ "blocked_by": 0, "total_blocked_by": 0, "blocking": 0, "total_blocking": 0 }
false
true
https://api.github.com/repos/huggingface/transformers/issues/41335
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41335/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41335/comments
https://api.github.com/repos/huggingface/transformers/issues/41335/events
https://github.com/huggingface/transformers/pull/41335
3,482,655,094
PR_kwDOCUB6oc6sCaDl
41,335
Add `logits_to_keep` to many older CausalLM models
{ "login": "philiproeleveld", "id": 25742753, "node_id": "MDQ6VXNlcjI1NzQyNzUz", "avatar_url": "https://avatars.githubusercontent.com/u/25742753?v=4", "gravatar_id": "", "url": "https://api.github.com/users/philiproeleveld", "html_url": "https://github.com/philiproeleveld", "followers_url": "https://api.github.com/users/philiproeleveld/followers", "following_url": "https://api.github.com/users/philiproeleveld/following{/other_user}", "gists_url": "https://api.github.com/users/philiproeleveld/gists{/gist_id}", "starred_url": "https://api.github.com/users/philiproeleveld/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/philiproeleveld/subscriptions", "organizations_url": "https://api.github.com/users/philiproeleveld/orgs", "repos_url": "https://api.github.com/users/philiproeleveld/repos", "events_url": "https://api.github.com/users/philiproeleveld/events{/privacy}", "received_events_url": "https://api.github.com/users/philiproeleveld/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-03T21:46:46
2025-10-15T09:56:02
2025-10-15T09:56:02
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41335", "html_url": "https://github.com/huggingface/transformers/pull/41335", "diff_url": "https://github.com/huggingface/transformers/pull/41335.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41335.patch", "merged_at": "2025-10-15T09:56:02" }
# What does this PR do? Fixes #40984 Adds `logits_to_keep` to many (older) `ForCausalLM` models that inherit from `GenerationMixin`. Also consistently renames to `loss` and `logits`, and removes some code for float casting and mapping labels to the logits' device for models where that is already handled by the loss function (e.g. `gpt_neo`). ## Before submitting - [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [x] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request), Pull Request section? - [x] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case. - [ ] Did you make sure to update the documentation with your changes? Here are the [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation). - [ ] Did you write any new necessary tests? ## Who can review? Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR. @Rocketknight1
{ "login": "Cyrilvallez", "id": 71554963, "node_id": "MDQ6VXNlcjcxNTU0OTYz", "avatar_url": "https://avatars.githubusercontent.com/u/71554963?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Cyrilvallez", "html_url": "https://github.com/Cyrilvallez", "followers_url": "https://api.github.com/users/Cyrilvallez/followers", "following_url": "https://api.github.com/users/Cyrilvallez/following{/other_user}", "gists_url": "https://api.github.com/users/Cyrilvallez/gists{/gist_id}", "starred_url": "https://api.github.com/users/Cyrilvallez/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Cyrilvallez/subscriptions", "organizations_url": "https://api.github.com/users/Cyrilvallez/orgs", "repos_url": "https://api.github.com/users/Cyrilvallez/repos", "events_url": "https://api.github.com/users/Cyrilvallez/events{/privacy}", "received_events_url": "https://api.github.com/users/Cyrilvallez/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41335/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41335/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41334
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41334/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41334/comments
https://api.github.com/repos/huggingface/transformers/issues/41334/events
https://github.com/huggingface/transformers/pull/41334
3,482,635,349
PR_kwDOCUB6oc6sCVnR
41,334
fix(packaging): remove leftover optax extra (align with #41030, fixes #41331)
{ "login": "MRADULTRIPATHI", "id": 127003798, "node_id": "U_kgDOB5Hslg", "avatar_url": "https://avatars.githubusercontent.com/u/127003798?v=4", "gravatar_id": "", "url": "https://api.github.com/users/MRADULTRIPATHI", "html_url": "https://github.com/MRADULTRIPATHI", "followers_url": "https://api.github.com/users/MRADULTRIPATHI/followers", "following_url": "https://api.github.com/users/MRADULTRIPATHI/following{/other_user}", "gists_url": "https://api.github.com/users/MRADULTRIPATHI/gists{/gist_id}", "starred_url": "https://api.github.com/users/MRADULTRIPATHI/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MRADULTRIPATHI/subscriptions", "organizations_url": "https://api.github.com/users/MRADULTRIPATHI/orgs", "repos_url": "https://api.github.com/users/MRADULTRIPATHI/repos", "events_url": "https://api.github.com/users/MRADULTRIPATHI/events{/privacy}", "received_events_url": "https://api.github.com/users/MRADULTRIPATHI/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-03T21:37:41
2025-10-04T09:02:43
2025-10-04T05:37:05
NONE
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41334", "html_url": "https://github.com/huggingface/transformers/pull/41334", "diff_url": "https://github.com/huggingface/transformers/pull/41334.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41334.patch", "merged_at": null }
## What does this PR do? Removes the leftover `optax` extra from Transformers packaging. - `optax` was intentionally removed in #41030, but the cherry-pick for v4.57.0 was incomplete. - As a result, the lock file contained `optax (<empty>)`, breaking Poetry parsing (#41331). - This PR deletes the stale `optax` entry from `setup.py`, cleans up `pyproject.toml`, and regenerates `dependency_versions_table.py`. ## Fixes Fixes #41331 ## Before submitting - [x] Removed stale dependency (`optax`) - [x] Verified `deps_table_update` runs successfully - [x] Followed contribution guidelines ## Who can review? @ArthurZucker @Cyrilvallez
{ "login": "MRADULTRIPATHI", "id": 127003798, "node_id": "U_kgDOB5Hslg", "avatar_url": "https://avatars.githubusercontent.com/u/127003798?v=4", "gravatar_id": "", "url": "https://api.github.com/users/MRADULTRIPATHI", "html_url": "https://github.com/MRADULTRIPATHI", "followers_url": "https://api.github.com/users/MRADULTRIPATHI/followers", "following_url": "https://api.github.com/users/MRADULTRIPATHI/following{/other_user}", "gists_url": "https://api.github.com/users/MRADULTRIPATHI/gists{/gist_id}", "starred_url": "https://api.github.com/users/MRADULTRIPATHI/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MRADULTRIPATHI/subscriptions", "organizations_url": "https://api.github.com/users/MRADULTRIPATHI/orgs", "repos_url": "https://api.github.com/users/MRADULTRIPATHI/repos", "events_url": "https://api.github.com/users/MRADULTRIPATHI/events{/privacy}", "received_events_url": "https://api.github.com/users/MRADULTRIPATHI/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41334/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41334/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41333
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41333/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41333/comments
https://api.github.com/repos/huggingface/transformers/issues/41333/events
https://github.com/huggingface/transformers/pull/41333
3,482,379,950
PR_kwDOCUB6oc6sBdkM
41,333
[WIP]: Add DeepseekVLV2 Model
{ "login": "Player256", "id": 92082372, "node_id": "U_kgDOBX0QxA", "avatar_url": "https://avatars.githubusercontent.com/u/92082372?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Player256", "html_url": "https://github.com/Player256", "followers_url": "https://api.github.com/users/Player256/followers", "following_url": "https://api.github.com/users/Player256/following{/other_user}", "gists_url": "https://api.github.com/users/Player256/gists{/gist_id}", "starred_url": "https://api.github.com/users/Player256/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Player256/subscriptions", "organizations_url": "https://api.github.com/users/Player256/orgs", "repos_url": "https://api.github.com/users/Player256/repos", "events_url": "https://api.github.com/users/Player256/events{/privacy}", "received_events_url": "https://api.github.com/users/Player256/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
open
false
null
[]
null
[]
2025-10-03T19:54:27
2025-10-19T07:59:33
null
CONTRIBUTOR
null
null
true
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41333", "html_url": "https://github.com/huggingface/transformers/pull/41333", "diff_url": "https://github.com/huggingface/transformers/pull/41333.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41333.patch", "merged_at": null }
Fixes #36111 This is a draft PR for adding deepseek_vl_v2 to the transformers library.
null
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41333/reactions", "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 1, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41333/timeline
null
null
null
null
true
false
https://api.github.com/repos/huggingface/transformers/issues/41332
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41332/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41332/comments
https://api.github.com/repos/huggingface/transformers/issues/41332/events
https://github.com/huggingface/transformers/pull/41332
3,482,363,709
PR_kwDOCUB6oc6sBZ8W
41,332
fix asr ut failures
{ "login": "yao-matrix", "id": 7245027, "node_id": "MDQ6VXNlcjcyNDUwMjc=", "avatar_url": "https://avatars.githubusercontent.com/u/7245027?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yao-matrix", "html_url": "https://github.com/yao-matrix", "followers_url": "https://api.github.com/users/yao-matrix/followers", "following_url": "https://api.github.com/users/yao-matrix/following{/other_user}", "gists_url": "https://api.github.com/users/yao-matrix/gists{/gist_id}", "starred_url": "https://api.github.com/users/yao-matrix/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yao-matrix/subscriptions", "organizations_url": "https://api.github.com/users/yao-matrix/orgs", "repos_url": "https://api.github.com/users/yao-matrix/repos", "events_url": "https://api.github.com/users/yao-matrix/events{/privacy}", "received_events_url": "https://api.github.com/users/yao-matrix/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-03T19:48:47
2025-10-06T18:07:23
2025-10-06T17:12:20
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41332", "html_url": "https://github.com/huggingface/transformers/pull/41332", "diff_url": "https://github.com/huggingface/transformers/pull/41332.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41332.patch", "merged_at": "2025-10-06T17:12:20" }
4 tests failed with AttributeError: 'AudioDecoder' object has no attribute 'copy': `pytest -rA tests/pipelines/test_pipelines_automatic_speech_recognition.py::AutomaticSpeechRecognitionPipelineTests::test_speculative_decoding_whisper_non_distil pytest -rA tests/test_pipeline_mixin.py::AutomaticSpeechRecognitionPipelineTests::test_speculative_decoding_whisper_non_distil pytest -rA tests/pipelines/test_pipelines_automatic_speech_recognition.py::AutomaticSpeechRecognitionPipelineTests::test_whisper_prompted pytest -rA tests/test_pipeline_mixin.py::AutomaticSpeechRecognitionPipelineTests::test_whisper_prompted` after fixing, they all passed @SunMarc @ydshieh , pls help review, thx very much.
{ "login": "eustlb", "id": 94853470, "node_id": "U_kgDOBadZXg", "avatar_url": "https://avatars.githubusercontent.com/u/94853470?v=4", "gravatar_id": "", "url": "https://api.github.com/users/eustlb", "html_url": "https://github.com/eustlb", "followers_url": "https://api.github.com/users/eustlb/followers", "following_url": "https://api.github.com/users/eustlb/following{/other_user}", "gists_url": "https://api.github.com/users/eustlb/gists{/gist_id}", "starred_url": "https://api.github.com/users/eustlb/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/eustlb/subscriptions", "organizations_url": "https://api.github.com/users/eustlb/orgs", "repos_url": "https://api.github.com/users/eustlb/repos", "events_url": "https://api.github.com/users/eustlb/events{/privacy}", "received_events_url": "https://api.github.com/users/eustlb/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41332/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41332/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41331
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41331/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41331/comments
https://api.github.com/repos/huggingface/transformers/issues/41331/events
https://github.com/huggingface/transformers/issues/41331
3,482,351,610
I_kwDOCUB6oc7PkHf6
41,331
Broken metadata in transformers 4.57.0 causing Poetry <empty> version parse error
{ "login": "ashisjena", "id": 9766652, "node_id": "MDQ6VXNlcjk3NjY2NTI=", "avatar_url": "https://avatars.githubusercontent.com/u/9766652?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ashisjena", "html_url": "https://github.com/ashisjena", "followers_url": "https://api.github.com/users/ashisjena/followers", "following_url": "https://api.github.com/users/ashisjena/following{/other_user}", "gists_url": "https://api.github.com/users/ashisjena/gists{/gist_id}", "starred_url": "https://api.github.com/users/ashisjena/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ashisjena/subscriptions", "organizations_url": "https://api.github.com/users/ashisjena/orgs", "repos_url": "https://api.github.com/users/ashisjena/repos", "events_url": "https://api.github.com/users/ashisjena/events{/privacy}", "received_events_url": "https://api.github.com/users/ashisjena/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 3817266200, "node_id": "MDU6TGFiZWwzODE3MjY2MjAw", "url": "https://api.github.com/repos/huggingface/transformers/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": null } ]
closed
false
null
[]
null
[]
2025-10-03T19:44:50
2025-10-15T09:01:21
2025-10-14T15:53:57
NONE
null
null
null
null
### System Info **Description** After upgrading to transformers 4.57.0, Poetry fails to generate the lock file or install dependencies, showing: `Could not parse version constraint: <empty>` **Steps to reproduce** 1. Create a new Poetry project: ``` poetry new test-transformers cd test-transformers poetry add transformers==4.57.0 ``` 2. Run: `poetry install` 3. Error occurs. **Observed behavior** - Poetry lock file contains: `optax (<empty>)` - Installation fails with version parsing error. **Expected behavior** - Lock file should correctly parse extras. - Installation should succeed like previous version (e.g., 4.56.0). **Workaround** ``` Pin transformers to 4.56.0: poetry add transformers==4.56.0 ``` **Environment** OS: Windows 11 Python: 3.12.0 Poetry: 2.2.1 **Additional context** It seems that the metadata for extra optax in 4.57.0 is empty or invalid. This breaks PEP 508 compliance and causes Poetry to fail parsing the version constraints. ### Who can help? _No response_ ### Information - [ ] The official example scripts - [ ] My own modified scripts ### Tasks - [ ] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...) - [ ] My own task or dataset (give details below) ### Reproduction 1. Create a new Poetry project: ``` poetry new test-transformers cd test-transformers poetry add transformers==4.57.0 ``` 2. Run: `poetry install` 3. Error occurs. **Observed behavior** - Poetry lock file contains: `optax (<empty>)` - Installation fails with version parsing error. ### Expected behavior **Expected behavior** - Lock file should correctly parse extras. - Installation should succeed like previous version (e.g., 4.56.0). **Workaround** ``` Pin transformers to 4.56.0: poetry add transformers==4.56.0 ``` **Workaround** ``` Pin transformers to 4.56.0: poetry add transformers==4.56.0 ``` **Environment** OS: Windows 11 Python: 3.12.0 Poetry: 2.2.1 **Additional context** It seems that the metadata for extra optax in 4.57.0 is empty or invalid. This breaks PEP 508 compliance and causes Poetry to fail parsing the version constraints.
{ "login": "Cyrilvallez", "id": 71554963, "node_id": "MDQ6VXNlcjcxNTU0OTYz", "avatar_url": "https://avatars.githubusercontent.com/u/71554963?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Cyrilvallez", "html_url": "https://github.com/Cyrilvallez", "followers_url": "https://api.github.com/users/Cyrilvallez/followers", "following_url": "https://api.github.com/users/Cyrilvallez/following{/other_user}", "gists_url": "https://api.github.com/users/Cyrilvallez/gists{/gist_id}", "starred_url": "https://api.github.com/users/Cyrilvallez/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Cyrilvallez/subscriptions", "organizations_url": "https://api.github.com/users/Cyrilvallez/orgs", "repos_url": "https://api.github.com/users/Cyrilvallez/repos", "events_url": "https://api.github.com/users/Cyrilvallez/events{/privacy}", "received_events_url": "https://api.github.com/users/Cyrilvallez/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41331/reactions", "total_count": 18, "+1": 18, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41331/timeline
null
completed
{ "total": 0, "completed": 0, "percent_completed": 0 }
{ "blocked_by": 0, "total_blocked_by": 0, "blocking": 0, "total_blocking": 0 }
false
true
https://api.github.com/repos/huggingface/transformers/issues/41330
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41330/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41330/comments
https://api.github.com/repos/huggingface/transformers/issues/41330/events
https://github.com/huggingface/transformers/pull/41330
3,482,174,929
PR_kwDOCUB6oc6sAxC_
41,330
Unskip and fix offline mode tests, use HF_HUB_OFFLINE, make hermetic
{ "login": "GovindGoyal4440", "id": 187962500, "node_id": "U_kgDOCzQUhA", "avatar_url": "https://avatars.githubusercontent.com/u/187962500?v=4", "gravatar_id": "", "url": "https://api.github.com/users/GovindGoyal4440", "html_url": "https://github.com/GovindGoyal4440", "followers_url": "https://api.github.com/users/GovindGoyal4440/followers", "following_url": "https://api.github.com/users/GovindGoyal4440/following{/other_user}", "gists_url": "https://api.github.com/users/GovindGoyal4440/gists{/gist_id}", "starred_url": "https://api.github.com/users/GovindGoyal4440/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/GovindGoyal4440/subscriptions", "organizations_url": "https://api.github.com/users/GovindGoyal4440/orgs", "repos_url": "https://api.github.com/users/GovindGoyal4440/repos", "events_url": "https://api.github.com/users/GovindGoyal4440/events{/privacy}", "received_events_url": "https://api.github.com/users/GovindGoyal4440/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
open
false
null
[]
null
[]
2025-10-03T18:41:02
2025-10-03T18:58:46
null
NONE
null
null
true
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41330", "html_url": "https://github.com/huggingface/transformers/pull/41330", "diff_url": "https://github.com/huggingface/transformers/pull/41330.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41330.patch", "merged_at": null }
# What does this PR do? <!-- Congratulations! You've made it this far! You're not quite done yet though. Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution. Then, please replace this with a description of the change and which issue is fixed (if applicable). Please also include relevant motivation and context. List any dependencies (if any) that are required for this change. Once you're done, someone will review your PR shortly (see the section "Who can review?" below to tag some potential reviewers). They may suggest changes to make the code even better. If no one reviewed your PR after a week has passed, don't hesitate to post a new comment @-mentioning the same persons---sometimes notifications get lost. --> <!-- Remove if not applicable --> Fixes #41311 ## Before submitting - [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [x] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request), Pull Request section? - [x] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case. https://github.com/huggingface/transformers/issues/41311 - [ ] Did you make sure to update the documentation with your changes? Here are the [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation). - [ ] Did you write any new necessary tests? ## Who can review? Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR. <!-- Your PR will be replied to more quickly if you can figure out the right person to tag with @ If you know how to use git blame, that is the easiest way, otherwise, here is a rough guide of **who to tag**. Please tag fewer than 3 people. Models: - text models: @ArthurZucker @Cyrilvallez - vision models: @yonigozlan @molbap - audio models: @eustlb @ebezzam @vasqu - multimodal models: @zucchini-nlp - graph models: @clefourrier Library: - generate: @zucchini-nlp (visual-language models) or @gante (all others) - continuous batching: @remi-or @ArthurZucker @McPatate - pipelines: @Rocketknight1 - tokenizers: @ArthurZucker and @itazap - trainer: @zach-huggingface @SunMarc - attention: @vasqu @ArthurZucker @CyrilVallez - model loading (from pretrained, etc): @CyrilVallez - distributed: @3outeille @ArthurZucker @S1ro1 - CIs: @ydshieh Integrations: - deepspeed: HF Trainer/Accelerate: @SunMarc @zach-huggingface - ray/raytune: @richardliaw, @amogkam - Big Model Inference: @SunMarc - quantization (bitsandbytes, autogpt): @SunMarc @MekkCyber - kernels: @MekkCyber @drbh - peft: @BenjaminBossan @githubnemo Devices/Backends: - AMD ROCm: @ivarflakstad - Intel XPU: @IlyasMoutawwakil - Ascend NPU: @ivarflakstad Documentation: @stevhliu Research projects are not maintained and should be taken as is. -->
null
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41330/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41330/timeline
null
null
null
null
true
false
https://api.github.com/repos/huggingface/transformers/issues/41329
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41329/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41329/comments
https://api.github.com/repos/huggingface/transformers/issues/41329/events
https://github.com/huggingface/transformers/pull/41329
3,482,116,199
PR_kwDOCUB6oc6sAk0X
41,329
Fix GIL=0 segfault and Add GIL=0 compat for regex paths
{ "login": "Qubitium", "id": 417764, "node_id": "MDQ6VXNlcjQxNzc2NA==", "avatar_url": "https://avatars.githubusercontent.com/u/417764?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Qubitium", "html_url": "https://github.com/Qubitium", "followers_url": "https://api.github.com/users/Qubitium/followers", "following_url": "https://api.github.com/users/Qubitium/following{/other_user}", "gists_url": "https://api.github.com/users/Qubitium/gists{/gist_id}", "starred_url": "https://api.github.com/users/Qubitium/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Qubitium/subscriptions", "organizations_url": "https://api.github.com/users/Qubitium/orgs", "repos_url": "https://api.github.com/users/Qubitium/repos", "events_url": "https://api.github.com/users/Qubitium/events{/privacy}", "received_events_url": "https://api.github.com/users/Qubitium/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
open
false
null
[]
null
[]
2025-10-03T18:23:49
2025-10-22T01:21:21
null
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41329", "html_url": "https://github.com/huggingface/transformers/pull/41329", "diff_url": "https://github.com/huggingface/transformers/pull/41329.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41329.patch", "merged_at": null }
# What does this PR do? Adds (Full) Regex and (Partial) Tokenization GIL=0 free-threading support. Tested up to Python 3.14T. In simple terms, Transformers code that relies on regex will segfault under true concurrency. I have confirmed with the regex maintainer that the latest GIL=0–compatible regex package is not GIL=0 safe. This has been corroborated by the submitted unit test in this PR, which demonstrates the segfault. Regex caches and reuses compiled patterns internally and executes them, which makes it inherently unsafe without the GIL. The core idea is not to make the entire Transformers library GIL=0 safe all at once, but rather to adapt it piece by piece until everything is as GIL=0 compatible as possible. This PR wraps existing regex calls into a thread-locked, protected serial execution pipeline. Files that import regex only need to adjust their import path to `from util.safe import regex` to minimize migration pain. ```diff - import regex as re + from ...utils.safe import regex as re ``` The current safe wrapper is modular and can be extended to cover additional modules in the future as needed or as issues are discovered. Since Transformers evolves more rapidly than most packages, introducing a local wrapper may be a pragmatic step while waiting for an upstream fix, which may be delayed. Additionally, many if not most Python APIs are not inherently thread-safe, so applying local wrappers is often necessary beyond just external packages.” Two new unit test files are included: A non-crashing test suite that proves the code works under GIL=0 with thread load. A crash-demonstration test that proves regex code paths segfault without the added protection under thread load. [utils/safe.py](https://github.com/huggingface/transformers/compare/main...Qubitium:transformers:regex-thread-safety?expand=1#diff-a7a62ce35afa10519218152098da57fe8ad5012b0068cfcb8e7ced98084e1517) [tests/utils/test_safe.py](https://github.com/huggingface/transformers/compare/main...Qubitium:transformers:regex-thread-safety?expand=1#diff-c36421043b36005fb56f58552a69701e7694997a64c1083816b888494f2666ac) [tests/utils/test_safe_crash.py](https://github.com/huggingface/transformers/compare/main...Qubitium:transformers:regex-thread-safety?expand=1#diff-2c867bbc58cad710595119fe34ae6389ba7f088f799714b2e7c6e93e72893bc1) ## Before submitting - [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [x] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request), Pull Request section? - [ ] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case. - [ ] Did you make sure to update the documentation with your changes? Here are the [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation). - [x] Did you write any new necessary tests? ## Who can review? @ArthurZucker @itazap @SunMarc @Cyrilvallez @gante @ydshieh @stevhliu
null
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41329/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41329/timeline
null
null
null
null
true
false
https://api.github.com/repos/huggingface/transformers/issues/41328
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41328/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41328/comments
https://api.github.com/repos/huggingface/transformers/issues/41328/events
https://github.com/huggingface/transformers/pull/41328
3,481,724,387
PR_kwDOCUB6oc6r_X1G
41,328
Fix incorrect assignment in `update_device_map` for GPTQ quantizer
{ "login": "Sai-Suraj-27", "id": 87087741, "node_id": "MDQ6VXNlcjg3MDg3NzQx", "avatar_url": "https://avatars.githubusercontent.com/u/87087741?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Sai-Suraj-27", "html_url": "https://github.com/Sai-Suraj-27", "followers_url": "https://api.github.com/users/Sai-Suraj-27/followers", "following_url": "https://api.github.com/users/Sai-Suraj-27/following{/other_user}", "gists_url": "https://api.github.com/users/Sai-Suraj-27/gists{/gist_id}", "starred_url": "https://api.github.com/users/Sai-Suraj-27/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Sai-Suraj-27/subscriptions", "organizations_url": "https://api.github.com/users/Sai-Suraj-27/orgs", "repos_url": "https://api.github.com/users/Sai-Suraj-27/repos", "events_url": "https://api.github.com/users/Sai-Suraj-27/events{/privacy}", "received_events_url": "https://api.github.com/users/Sai-Suraj-27/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-03T16:33:00
2025-10-07T15:28:56
2025-10-07T15:28:56
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41328", "html_url": "https://github.com/huggingface/transformers/pull/41328", "diff_url": "https://github.com/huggingface/transformers/pull/41328.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41328.patch", "merged_at": "2025-10-07T15:28:55" }
# What does this PR do? ## Before submitting - [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [x] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request), Pull Request section? - [ ] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case. - [ ] Did you make sure to update the documentation with your changes? Here are the [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation). - [ ] Did you write any new necessary tests? ## Who can review? @SunMarc @MekkCyber
{ "login": "MekkCyber", "id": 93391238, "node_id": "U_kgDOBZEJhg", "avatar_url": "https://avatars.githubusercontent.com/u/93391238?v=4", "gravatar_id": "", "url": "https://api.github.com/users/MekkCyber", "html_url": "https://github.com/MekkCyber", "followers_url": "https://api.github.com/users/MekkCyber/followers", "following_url": "https://api.github.com/users/MekkCyber/following{/other_user}", "gists_url": "https://api.github.com/users/MekkCyber/gists{/gist_id}", "starred_url": "https://api.github.com/users/MekkCyber/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MekkCyber/subscriptions", "organizations_url": "https://api.github.com/users/MekkCyber/orgs", "repos_url": "https://api.github.com/users/MekkCyber/repos", "events_url": "https://api.github.com/users/MekkCyber/events{/privacy}", "received_events_url": "https://api.github.com/users/MekkCyber/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41328/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41328/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41327
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41327/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41327/comments
https://api.github.com/repos/huggingface/transformers/issues/41327/events
https://github.com/huggingface/transformers/issues/41327
3,481,717,278
I_kwDOCUB6oc7Phsoe
41,327
Add DEIMv2
{ "login": "yonigozlan", "id": 74535834, "node_id": "MDQ6VXNlcjc0NTM1ODM0", "avatar_url": "https://avatars.githubusercontent.com/u/74535834?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yonigozlan", "html_url": "https://github.com/yonigozlan", "followers_url": "https://api.github.com/users/yonigozlan/followers", "following_url": "https://api.github.com/users/yonigozlan/following{/other_user}", "gists_url": "https://api.github.com/users/yonigozlan/gists{/gist_id}", "starred_url": "https://api.github.com/users/yonigozlan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yonigozlan/subscriptions", "organizations_url": "https://api.github.com/users/yonigozlan/orgs", "repos_url": "https://api.github.com/users/yonigozlan/repos", "events_url": "https://api.github.com/users/yonigozlan/events{/privacy}", "received_events_url": "https://api.github.com/users/yonigozlan/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1843244711, "node_id": "MDU6TGFiZWwxODQzMjQ0NzEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/New%20model", "name": "New model", "color": "fbca04", "default": false, "description": "" }, { "id": 3081136536, "node_id": "MDU6TGFiZWwzMDgxMTM2NTM2", "url": "https://api.github.com/repos/huggingface/transformers/labels/Good%20Difficult%20Issue", "name": "Good Difficult Issue", "color": "684CC7", "default": false, "description": "" }, { "id": 5769473378, "node_id": "LA_kwDOCUB6oc8AAAABV-MtYg", "url": "https://api.github.com/repos/huggingface/transformers/labels/Vision", "name": "Vision", "color": "C079EF", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2025-10-03T16:29:47
2025-10-03T20:10:48
2025-10-03T20:10:48
MEMBER
{ "id": 5746498, "node_id": "IT_kwDOAYh3p84AV69C", "name": "Feature", "description": "A request, idea, or new functionality", "color": "blue", "created_at": "2024-01-30T10:06:08", "updated_at": "2024-10-08T12:18:58", "is_enabled": true }
null
null
null
### Model description Looks like [DEIMv2](https://github.com/Intellindust-AI-Lab/DEIMv2) could be a great addition to the library. I don't have the bandwidth right now to work on the integration, but happy to review a PR if anyone is interested in adding the model! ### Open source status - [x] The model implementation is available - [x] The model weights are available ### Provide useful links for the implementation _No response_
{ "login": "yonigozlan", "id": 74535834, "node_id": "MDQ6VXNlcjc0NTM1ODM0", "avatar_url": "https://avatars.githubusercontent.com/u/74535834?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yonigozlan", "html_url": "https://github.com/yonigozlan", "followers_url": "https://api.github.com/users/yonigozlan/followers", "following_url": "https://api.github.com/users/yonigozlan/following{/other_user}", "gists_url": "https://api.github.com/users/yonigozlan/gists{/gist_id}", "starred_url": "https://api.github.com/users/yonigozlan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yonigozlan/subscriptions", "organizations_url": "https://api.github.com/users/yonigozlan/orgs", "repos_url": "https://api.github.com/users/yonigozlan/repos", "events_url": "https://api.github.com/users/yonigozlan/events{/privacy}", "received_events_url": "https://api.github.com/users/yonigozlan/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41327/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41327/timeline
null
completed
{ "total": 0, "completed": 0, "percent_completed": 0 }
{ "blocked_by": 0, "total_blocked_by": 0, "blocking": 0, "total_blocking": 0 }
false
true
https://api.github.com/repos/huggingface/transformers/issues/41326
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41326/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41326/comments
https://api.github.com/repos/huggingface/transformers/issues/41326/events
https://github.com/huggingface/transformers/pull/41326
3,481,699,669
PR_kwDOCUB6oc6r_Sk-
41,326
Deprecate warmup_ratio
{ "login": "SunMarc", "id": 57196510, "node_id": "MDQ6VXNlcjU3MTk2NTEw", "avatar_url": "https://avatars.githubusercontent.com/u/57196510?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SunMarc", "html_url": "https://github.com/SunMarc", "followers_url": "https://api.github.com/users/SunMarc/followers", "following_url": "https://api.github.com/users/SunMarc/following{/other_user}", "gists_url": "https://api.github.com/users/SunMarc/gists{/gist_id}", "starred_url": "https://api.github.com/users/SunMarc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SunMarc/subscriptions", "organizations_url": "https://api.github.com/users/SunMarc/orgs", "repos_url": "https://api.github.com/users/SunMarc/repos", "events_url": "https://api.github.com/users/SunMarc/events{/privacy}", "received_events_url": "https://api.github.com/users/SunMarc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-03T16:22:10
2025-10-23T15:17:23
2025-10-23T15:17:21
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41326", "html_url": "https://github.com/huggingface/transformers/pull/41326", "diff_url": "https://github.com/huggingface/transformers/pull/41326.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41326.patch", "merged_at": "2025-10-23T15:17:21" }
# What does this PR do? This PR deprecates `warmup_ratio`. Instead we ask the user to use `warmup_steps` instead as we now allow passing float values. This is something that was already done for a few args like `eval_steps` .
{ "login": "SunMarc", "id": 57196510, "node_id": "MDQ6VXNlcjU3MTk2NTEw", "avatar_url": "https://avatars.githubusercontent.com/u/57196510?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SunMarc", "html_url": "https://github.com/SunMarc", "followers_url": "https://api.github.com/users/SunMarc/followers", "following_url": "https://api.github.com/users/SunMarc/following{/other_user}", "gists_url": "https://api.github.com/users/SunMarc/gists{/gist_id}", "starred_url": "https://api.github.com/users/SunMarc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SunMarc/subscriptions", "organizations_url": "https://api.github.com/users/SunMarc/orgs", "repos_url": "https://api.github.com/users/SunMarc/repos", "events_url": "https://api.github.com/users/SunMarc/events{/privacy}", "received_events_url": "https://api.github.com/users/SunMarc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41326/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41326/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41325
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41325/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41325/comments
https://api.github.com/repos/huggingface/transformers/issues/41325/events
https://github.com/huggingface/transformers/pull/41325
3,481,663,853
PR_kwDOCUB6oc6r_KwG
41,325
Fixing a typo for BLT model
{ "login": "Narsil", "id": 204321, "node_id": "MDQ6VXNlcjIwNDMyMQ==", "avatar_url": "https://avatars.githubusercontent.com/u/204321?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Narsil", "html_url": "https://github.com/Narsil", "followers_url": "https://api.github.com/users/Narsil/followers", "following_url": "https://api.github.com/users/Narsil/following{/other_user}", "gists_url": "https://api.github.com/users/Narsil/gists{/gist_id}", "starred_url": "https://api.github.com/users/Narsil/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Narsil/subscriptions", "organizations_url": "https://api.github.com/users/Narsil/orgs", "repos_url": "https://api.github.com/users/Narsil/repos", "events_url": "https://api.github.com/users/Narsil/events{/privacy}", "received_events_url": "https://api.github.com/users/Narsil/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-03T16:11:09
2025-10-06T12:17:26
2025-10-06T12:16:45
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41325", "html_url": "https://github.com/huggingface/transformers/pull/41325", "diff_url": "https://github.com/huggingface/transformers/pull/41325.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41325.patch", "merged_at": "2025-10-06T12:16:45" }
# What does this PR do? <!-- Congratulations! You've made it this far! You're not quite done yet though. Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution. Then, please replace this with a description of the change and which issue is fixed (if applicable). Please also include relevant motivation and context. List any dependencies (if any) that are required for this change. Once you're done, someone will review your PR shortly (see the section "Who can review?" below to tag some potential reviewers). They may suggest changes to make the code even better. If no one reviewed your PR after a week has passed, don't hesitate to post a new comment @-mentioning the same persons---sometimes notifications get lost. --> <!-- Remove if not applicable --> Fixes # (issue) ## Before submitting - [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [ ] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request), Pull Request section? - [ ] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case. - [ ] Did you make sure to update the documentation with your changes? Here are the [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation). - [ ] Did you write any new necessary tests? ## Who can review? Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR. <!-- Your PR will be replied to more quickly if you can figure out the right person to tag with @ If you know how to use git blame, that is the easiest way, otherwise, here is a rough guide of **who to tag**. Please tag fewer than 3 people. Models: - text models: @ArthurZucker @Cyrilvallez - vision models: @yonigozlan @molbap - audio models: @eustlb @ebezzam @vasqu - multimodal models: @zucchini-nlp - graph models: @clefourrier Library: - generate: @zucchini-nlp (visual-language models) or @gante (all others) - continuous batching: @remi-or @ArthurZucker @McPatate - pipelines: @Rocketknight1 - tokenizers: @ArthurZucker and @itazap - trainer: @zach-huggingface @SunMarc - attention: @vasqu @ArthurZucker @CyrilVallez - model loading (from pretrained, etc): @CyrilVallez - distributed: @3outeille @ArthurZucker @S1ro1 - CIs: @ydshieh Integrations: - deepspeed: HF Trainer/Accelerate: @SunMarc @zach-huggingface - ray/raytune: @richardliaw, @amogkam - Big Model Inference: @SunMarc - quantization (bitsandbytes, autogpt): @SunMarc @MekkCyber - kernels: @MekkCyber @drbh - peft: @BenjaminBossan @githubnemo Devices/Backends: - AMD ROCm: @ivarflakstad - Intel XPU: @IlyasMoutawwakil - Ascend NPU: @ivarflakstad Documentation: @stevhliu Research projects are not maintained and should be taken as is. -->
{ "login": "Rocketknight1", "id": 12866554, "node_id": "MDQ6VXNlcjEyODY2NTU0", "avatar_url": "https://avatars.githubusercontent.com/u/12866554?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Rocketknight1", "html_url": "https://github.com/Rocketknight1", "followers_url": "https://api.github.com/users/Rocketknight1/followers", "following_url": "https://api.github.com/users/Rocketknight1/following{/other_user}", "gists_url": "https://api.github.com/users/Rocketknight1/gists{/gist_id}", "starred_url": "https://api.github.com/users/Rocketknight1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Rocketknight1/subscriptions", "organizations_url": "https://api.github.com/users/Rocketknight1/orgs", "repos_url": "https://api.github.com/users/Rocketknight1/repos", "events_url": "https://api.github.com/users/Rocketknight1/events{/privacy}", "received_events_url": "https://api.github.com/users/Rocketknight1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41325/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41325/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41324
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41324/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41324/comments
https://api.github.com/repos/huggingface/transformers/issues/41324/events
https://github.com/huggingface/transformers/pull/41324
3,481,606,219
PR_kwDOCUB6oc6r--L6
41,324
`JetMoe` Fix jetmoe after #40132
{ "login": "ArthurZucker", "id": 48595927, "node_id": "MDQ6VXNlcjQ4NTk1OTI3", "avatar_url": "https://avatars.githubusercontent.com/u/48595927?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ArthurZucker", "html_url": "https://github.com/ArthurZucker", "followers_url": "https://api.github.com/users/ArthurZucker/followers", "following_url": "https://api.github.com/users/ArthurZucker/following{/other_user}", "gists_url": "https://api.github.com/users/ArthurZucker/gists{/gist_id}", "starred_url": "https://api.github.com/users/ArthurZucker/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ArthurZucker/subscriptions", "organizations_url": "https://api.github.com/users/ArthurZucker/orgs", "repos_url": "https://api.github.com/users/ArthurZucker/repos", "events_url": "https://api.github.com/users/ArthurZucker/events{/privacy}", "received_events_url": "https://api.github.com/users/ArthurZucker/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-03T15:50:29
2025-10-04T09:02:15
2025-10-04T09:02:13
COLLABORATOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41324", "html_url": "https://github.com/huggingface/transformers/pull/41324", "diff_url": "https://github.com/huggingface/transformers/pull/41324.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41324.patch", "merged_at": "2025-10-04T09:02:13" }
# What does this PR do? A typo got in in #40132
{ "login": "ArthurZucker", "id": 48595927, "node_id": "MDQ6VXNlcjQ4NTk1OTI3", "avatar_url": "https://avatars.githubusercontent.com/u/48595927?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ArthurZucker", "html_url": "https://github.com/ArthurZucker", "followers_url": "https://api.github.com/users/ArthurZucker/followers", "following_url": "https://api.github.com/users/ArthurZucker/following{/other_user}", "gists_url": "https://api.github.com/users/ArthurZucker/gists{/gist_id}", "starred_url": "https://api.github.com/users/ArthurZucker/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ArthurZucker/subscriptions", "organizations_url": "https://api.github.com/users/ArthurZucker/orgs", "repos_url": "https://api.github.com/users/ArthurZucker/repos", "events_url": "https://api.github.com/users/ArthurZucker/events{/privacy}", "received_events_url": "https://api.github.com/users/ArthurZucker/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41324/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41324/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41323
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41323/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41323/comments
https://api.github.com/repos/huggingface/transformers/issues/41323/events
https://github.com/huggingface/transformers/pull/41323
3,481,579,338
PR_kwDOCUB6oc6r-4T0
41,323
deprecate `overwrite_output_dir`
{ "login": "SunMarc", "id": 57196510, "node_id": "MDQ6VXNlcjU3MTk2NTEw", "avatar_url": "https://avatars.githubusercontent.com/u/57196510?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SunMarc", "html_url": "https://github.com/SunMarc", "followers_url": "https://api.github.com/users/SunMarc/followers", "following_url": "https://api.github.com/users/SunMarc/following{/other_user}", "gists_url": "https://api.github.com/users/SunMarc/gists{/gist_id}", "starred_url": "https://api.github.com/users/SunMarc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SunMarc/subscriptions", "organizations_url": "https://api.github.com/users/SunMarc/orgs", "repos_url": "https://api.github.com/users/SunMarc/repos", "events_url": "https://api.github.com/users/SunMarc/events{/privacy}", "received_events_url": "https://api.github.com/users/SunMarc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
{ "login": "ArthurZucker", "id": 48595927, "node_id": "MDQ6VXNlcjQ4NTk1OTI3", "avatar_url": "https://avatars.githubusercontent.com/u/48595927?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ArthurZucker", "html_url": "https://github.com/ArthurZucker", "followers_url": "https://api.github.com/users/ArthurZucker/followers", "following_url": "https://api.github.com/users/ArthurZucker/following{/other_user}", "gists_url": "https://api.github.com/users/ArthurZucker/gists{/gist_id}", "starred_url": "https://api.github.com/users/ArthurZucker/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ArthurZucker/subscriptions", "organizations_url": "https://api.github.com/users/ArthurZucker/orgs", "repos_url": "https://api.github.com/users/ArthurZucker/repos", "events_url": "https://api.github.com/users/ArthurZucker/events{/privacy}", "received_events_url": "https://api.github.com/users/ArthurZucker/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "login": "ArthurZucker", "id": 48595927, "node_id": "MDQ6VXNlcjQ4NTk1OTI3", "avatar_url": "https://avatars.githubusercontent.com/u/48595927?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ArthurZucker", "html_url": "https://github.com/ArthurZucker", "followers_url": "https://api.github.com/users/ArthurZucker/followers", "following_url": "https://api.github.com/users/ArthurZucker/following{/other_user}", "gists_url": "https://api.github.com/users/ArthurZucker/gists{/gist_id}", "starred_url": "https://api.github.com/users/ArthurZucker/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ArthurZucker/subscriptions", "organizations_url": "https://api.github.com/users/ArthurZucker/orgs", "repos_url": "https://api.github.com/users/ArthurZucker/repos", "events_url": "https://api.github.com/users/ArthurZucker/events{/privacy}", "received_events_url": "https://api.github.com/users/ArthurZucker/received_events", "type": "User", "user_view_type": "public", "site_admin": false } ]
null
[]
2025-10-03T15:41:07
2025-10-09T16:36:22
2025-10-09T16:36:20
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41323", "html_url": "https://github.com/huggingface/transformers/pull/41323", "diff_url": "https://github.com/huggingface/transformers/pull/41323.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41323.patch", "merged_at": "2025-10-09T16:36:20" }
# What does this PR do? This PR deprecates `overwrite_output_dir`. This arg has no utility at all tbh as this was kind of replaced by `resume_from_checkpoint`. It was used to overwrite the checkpoint when we didn't want to resume the training. It was only used in examples. Sylvain also mentioned that in this thread https://discuss.huggingface.co/t/no-skipping-steps-after-loading-from-checkpoint/6880/14
{ "login": "SunMarc", "id": 57196510, "node_id": "MDQ6VXNlcjU3MTk2NTEw", "avatar_url": "https://avatars.githubusercontent.com/u/57196510?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SunMarc", "html_url": "https://github.com/SunMarc", "followers_url": "https://api.github.com/users/SunMarc/followers", "following_url": "https://api.github.com/users/SunMarc/following{/other_user}", "gists_url": "https://api.github.com/users/SunMarc/gists{/gist_id}", "starred_url": "https://api.github.com/users/SunMarc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SunMarc/subscriptions", "organizations_url": "https://api.github.com/users/SunMarc/orgs", "repos_url": "https://api.github.com/users/SunMarc/repos", "events_url": "https://api.github.com/users/SunMarc/events{/privacy}", "received_events_url": "https://api.github.com/users/SunMarc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41323/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41323/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41322
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41322/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41322/comments
https://api.github.com/repos/huggingface/transformers/issues/41322/events
https://github.com/huggingface/transformers/pull/41322
3,481,337,097
PR_kwDOCUB6oc6r-DBi
41,322
Fix lr_scheduler_parsing
{ "login": "SunMarc", "id": 57196510, "node_id": "MDQ6VXNlcjU3MTk2NTEw", "avatar_url": "https://avatars.githubusercontent.com/u/57196510?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SunMarc", "html_url": "https://github.com/SunMarc", "followers_url": "https://api.github.com/users/SunMarc/followers", "following_url": "https://api.github.com/users/SunMarc/following{/other_user}", "gists_url": "https://api.github.com/users/SunMarc/gists{/gist_id}", "starred_url": "https://api.github.com/users/SunMarc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SunMarc/subscriptions", "organizations_url": "https://api.github.com/users/SunMarc/orgs", "repos_url": "https://api.github.com/users/SunMarc/repos", "events_url": "https://api.github.com/users/SunMarc/events{/privacy}", "received_events_url": "https://api.github.com/users/SunMarc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-03T14:28:55
2025-10-03T15:51:20
2025-10-03T15:51:18
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41322", "html_url": "https://github.com/huggingface/transformers/pull/41322", "diff_url": "https://github.com/huggingface/transformers/pull/41322.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41322.patch", "merged_at": "2025-10-03T15:51:18" }
# What does this PR do? This PR fixes `lr_scheduler_kwargs` type to `Optional[Union[dict, str]] `as HfArgumentParser doesn't handled well args that needs to parsed into dict. For now, it is better to just follow what is done for fsdp_config for example.
{ "login": "SunMarc", "id": 57196510, "node_id": "MDQ6VXNlcjU3MTk2NTEw", "avatar_url": "https://avatars.githubusercontent.com/u/57196510?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SunMarc", "html_url": "https://github.com/SunMarc", "followers_url": "https://api.github.com/users/SunMarc/followers", "following_url": "https://api.github.com/users/SunMarc/following{/other_user}", "gists_url": "https://api.github.com/users/SunMarc/gists{/gist_id}", "starred_url": "https://api.github.com/users/SunMarc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SunMarc/subscriptions", "organizations_url": "https://api.github.com/users/SunMarc/orgs", "repos_url": "https://api.github.com/users/SunMarc/repos", "events_url": "https://api.github.com/users/SunMarc/events{/privacy}", "received_events_url": "https://api.github.com/users/SunMarc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41322/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41322/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41321
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41321/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41321/comments
https://api.github.com/repos/huggingface/transformers/issues/41321/events
https://github.com/huggingface/transformers/pull/41321
3,481,294,116
PR_kwDOCUB6oc6r95kf
41,321
[v5] Delete left traces of feature extractor
{ "login": "zucchini-nlp", "id": 100715397, "node_id": "U_kgDOBgDLhQ", "avatar_url": "https://avatars.githubusercontent.com/u/100715397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zucchini-nlp", "html_url": "https://github.com/zucchini-nlp", "followers_url": "https://api.github.com/users/zucchini-nlp/followers", "following_url": "https://api.github.com/users/zucchini-nlp/following{/other_user}", "gists_url": "https://api.github.com/users/zucchini-nlp/gists{/gist_id}", "starred_url": "https://api.github.com/users/zucchini-nlp/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zucchini-nlp/subscriptions", "organizations_url": "https://api.github.com/users/zucchini-nlp/orgs", "repos_url": "https://api.github.com/users/zucchini-nlp/repos", "events_url": "https://api.github.com/users/zucchini-nlp/events{/privacy}", "received_events_url": "https://api.github.com/users/zucchini-nlp/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-03T14:17:02
2025-10-07T16:24:08
2025-10-07T16:24:08
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41321", "html_url": "https://github.com/huggingface/transformers/pull/41321", "diff_url": "https://github.com/huggingface/transformers/pull/41321.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41321.patch", "merged_at": "2025-10-07T16:24:08" }
# What does this PR do? After rebasing https://github.com/huggingface/transformers/pull/40793 and getting new changes on `TypedDict`, I found out that some traces from feature extractor were still left. Thanks for type validation we can catch inconsistencies easily :) This PR goes over the deprecated properties as well and deletes them. Also it deletes `current_processor` which was also deprecated for v5
{ "login": "zucchini-nlp", "id": 100715397, "node_id": "U_kgDOBgDLhQ", "avatar_url": "https://avatars.githubusercontent.com/u/100715397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zucchini-nlp", "html_url": "https://github.com/zucchini-nlp", "followers_url": "https://api.github.com/users/zucchini-nlp/followers", "following_url": "https://api.github.com/users/zucchini-nlp/following{/other_user}", "gists_url": "https://api.github.com/users/zucchini-nlp/gists{/gist_id}", "starred_url": "https://api.github.com/users/zucchini-nlp/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zucchini-nlp/subscriptions", "organizations_url": "https://api.github.com/users/zucchini-nlp/orgs", "repos_url": "https://api.github.com/users/zucchini-nlp/repos", "events_url": "https://api.github.com/users/zucchini-nlp/events{/privacy}", "received_events_url": "https://api.github.com/users/zucchini-nlp/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41321/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41321/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41320
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41320/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41320/comments
https://api.github.com/repos/huggingface/transformers/issues/41320/events
https://github.com/huggingface/transformers/pull/41320
3,481,250,114
PR_kwDOCUB6oc6r9v8w
41,320
Security/fuyu
{ "login": "molbap", "id": 39954772, "node_id": "MDQ6VXNlcjM5OTU0Nzcy", "avatar_url": "https://avatars.githubusercontent.com/u/39954772?v=4", "gravatar_id": "", "url": "https://api.github.com/users/molbap", "html_url": "https://github.com/molbap", "followers_url": "https://api.github.com/users/molbap/followers", "following_url": "https://api.github.com/users/molbap/following{/other_user}", "gists_url": "https://api.github.com/users/molbap/gists{/gist_id}", "starred_url": "https://api.github.com/users/molbap/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/molbap/subscriptions", "organizations_url": "https://api.github.com/users/molbap/orgs", "repos_url": "https://api.github.com/users/molbap/repos", "events_url": "https://api.github.com/users/molbap/events{/privacy}", "received_events_url": "https://api.github.com/users/molbap/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-03T14:05:16
2025-10-03T14:14:18
2025-10-03T14:13:42
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41320", "html_url": "https://github.com/huggingface/transformers/pull/41320", "diff_url": "https://github.com/huggingface/transformers/pull/41320.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41320.patch", "merged_at": "2025-10-03T14:13:42" }
# What does this PR do? Remove a reference to a compromised github repo. For reference, all conversion scripts are excluded from releases. https://github.com/huggingface/transformers/blob/217ff1e4ef6b006d601d0fa834c2bd68c79b66cd/utils/release.py#L135-L143
{ "login": "molbap", "id": 39954772, "node_id": "MDQ6VXNlcjM5OTU0Nzcy", "avatar_url": "https://avatars.githubusercontent.com/u/39954772?v=4", "gravatar_id": "", "url": "https://api.github.com/users/molbap", "html_url": "https://github.com/molbap", "followers_url": "https://api.github.com/users/molbap/followers", "following_url": "https://api.github.com/users/molbap/following{/other_user}", "gists_url": "https://api.github.com/users/molbap/gists{/gist_id}", "starred_url": "https://api.github.com/users/molbap/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/molbap/subscriptions", "organizations_url": "https://api.github.com/users/molbap/orgs", "repos_url": "https://api.github.com/users/molbap/repos", "events_url": "https://api.github.com/users/molbap/events{/privacy}", "received_events_url": "https://api.github.com/users/molbap/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41320/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41320/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41319
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41319/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41319/comments
https://api.github.com/repos/huggingface/transformers/issues/41319/events
https://github.com/huggingface/transformers/pull/41319
3,481,147,380
PR_kwDOCUB6oc6r9ZOv
41,319
Use torch._check instead of a test in Gemma3Model
{ "login": "xadupre", "id": 22452781, "node_id": "MDQ6VXNlcjIyNDUyNzgx", "avatar_url": "https://avatars.githubusercontent.com/u/22452781?v=4", "gravatar_id": "", "url": "https://api.github.com/users/xadupre", "html_url": "https://github.com/xadupre", "followers_url": "https://api.github.com/users/xadupre/followers", "following_url": "https://api.github.com/users/xadupre/following{/other_user}", "gists_url": "https://api.github.com/users/xadupre/gists{/gist_id}", "starred_url": "https://api.github.com/users/xadupre/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/xadupre/subscriptions", "organizations_url": "https://api.github.com/users/xadupre/orgs", "repos_url": "https://api.github.com/users/xadupre/repos", "events_url": "https://api.github.com/users/xadupre/events{/privacy}", "received_events_url": "https://api.github.com/users/xadupre/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
open
false
null
[]
null
[]
2025-10-03T13:35:56
2025-10-03T15:37:06
null
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41319", "html_url": "https://github.com/huggingface/transformers/pull/41319", "diff_url": "https://github.com/huggingface/transformers/pull/41319.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41319.patch", "merged_at": null }
# What does this PR do? ``torch.export.export`` fails because of a test checking two dimension are equal. This PR replaces the test by ``torch._check``.
null
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41319/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41319/timeline
null
null
null
null
true
false
https://api.github.com/repos/huggingface/transformers/issues/41318
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41318/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41318/comments
https://api.github.com/repos/huggingface/transformers/issues/41318/events
https://github.com/huggingface/transformers/pull/41318
3,480,890,714
PR_kwDOCUB6oc6r8gpM
41,318
[causallm tester] automate pipeline mappings + bloom tests
{ "login": "gante", "id": 12240844, "node_id": "MDQ6VXNlcjEyMjQwODQ0", "avatar_url": "https://avatars.githubusercontent.com/u/12240844?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gante", "html_url": "https://github.com/gante", "followers_url": "https://api.github.com/users/gante/followers", "following_url": "https://api.github.com/users/gante/following{/other_user}", "gists_url": "https://api.github.com/users/gante/gists{/gist_id}", "starred_url": "https://api.github.com/users/gante/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gante/subscriptions", "organizations_url": "https://api.github.com/users/gante/orgs", "repos_url": "https://api.github.com/users/gante/repos", "events_url": "https://api.github.com/users/gante/events{/privacy}", "received_events_url": "https://api.github.com/users/gante/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-03T12:17:58
2025-10-10T09:02:04
2025-10-10T09:02:00
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41318", "html_url": "https://github.com/huggingface/transformers/pull/41318", "diff_url": "https://github.com/huggingface/transformers/pull/41318.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41318.patch", "merged_at": "2025-10-10T09:02:00" }
# What does this PR do? 👉 `CausalLMModelTest`-level changes: - automate `pipeline_model_mapping` whenever possible -- when `all_model_classes` contains the default classes, then `pipeline_model_mapping` must also contain the default mappings. This should reduce room for human error 🙏 👉 `Bloom` (the original target of this PR) - `CausalLMModelTest` refactor - moves integration tests into the correct tester 👉 misc - removes `get_large_model_config` in multiple model testers (this function was never being used)
{ "login": "gante", "id": 12240844, "node_id": "MDQ6VXNlcjEyMjQwODQ0", "avatar_url": "https://avatars.githubusercontent.com/u/12240844?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gante", "html_url": "https://github.com/gante", "followers_url": "https://api.github.com/users/gante/followers", "following_url": "https://api.github.com/users/gante/following{/other_user}", "gists_url": "https://api.github.com/users/gante/gists{/gist_id}", "starred_url": "https://api.github.com/users/gante/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gante/subscriptions", "organizations_url": "https://api.github.com/users/gante/orgs", "repos_url": "https://api.github.com/users/gante/repos", "events_url": "https://api.github.com/users/gante/events{/privacy}", "received_events_url": "https://api.github.com/users/gante/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41318/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41318/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41317
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41317/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41317/comments
https://api.github.com/repos/huggingface/transformers/issues/41317/events
https://github.com/huggingface/transformers/pull/41317
3,480,860,648
PR_kwDOCUB6oc6r8aGu
41,317
Minor security fix for `ssh-runner.yml`
{ "login": "ydshieh", "id": 2521628, "node_id": "MDQ6VXNlcjI1MjE2Mjg=", "avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ydshieh", "html_url": "https://github.com/ydshieh", "followers_url": "https://api.github.com/users/ydshieh/followers", "following_url": "https://api.github.com/users/ydshieh/following{/other_user}", "gists_url": "https://api.github.com/users/ydshieh/gists{/gist_id}", "starred_url": "https://api.github.com/users/ydshieh/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ydshieh/subscriptions", "organizations_url": "https://api.github.com/users/ydshieh/orgs", "repos_url": "https://api.github.com/users/ydshieh/repos", "events_url": "https://api.github.com/users/ydshieh/events{/privacy}", "received_events_url": "https://api.github.com/users/ydshieh/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-03T12:06:59
2025-10-03T12:16:22
2025-10-03T12:14:34
COLLABORATOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41317", "html_url": "https://github.com/huggingface/transformers/pull/41317", "diff_url": "https://github.com/huggingface/transformers/pull/41317.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41317.patch", "merged_at": "2025-10-03T12:14:34" }
# What does this PR do? It's minor as it could not be triggered by external people. But just to be more cautious.
{ "login": "ydshieh", "id": 2521628, "node_id": "MDQ6VXNlcjI1MjE2Mjg=", "avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ydshieh", "html_url": "https://github.com/ydshieh", "followers_url": "https://api.github.com/users/ydshieh/followers", "following_url": "https://api.github.com/users/ydshieh/following{/other_user}", "gists_url": "https://api.github.com/users/ydshieh/gists{/gist_id}", "starred_url": "https://api.github.com/users/ydshieh/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ydshieh/subscriptions", "organizations_url": "https://api.github.com/users/ydshieh/orgs", "repos_url": "https://api.github.com/users/ydshieh/repos", "events_url": "https://api.github.com/users/ydshieh/events{/privacy}", "received_events_url": "https://api.github.com/users/ydshieh/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41317/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41317/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41316
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41316/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41316/comments
https://api.github.com/repos/huggingface/transformers/issues/41316/events
https://github.com/huggingface/transformers/pull/41316
3,480,716,559
PR_kwDOCUB6oc6r76bd
41,316
tests: add dtype/device parity check for GPT‑2
{ "login": "arvinder004", "id": 86292141, "node_id": "MDQ6VXNlcjg2MjkyMTQx", "avatar_url": "https://avatars.githubusercontent.com/u/86292141?v=4", "gravatar_id": "", "url": "https://api.github.com/users/arvinder004", "html_url": "https://github.com/arvinder004", "followers_url": "https://api.github.com/users/arvinder004/followers", "following_url": "https://api.github.com/users/arvinder004/following{/other_user}", "gists_url": "https://api.github.com/users/arvinder004/gists{/gist_id}", "starred_url": "https://api.github.com/users/arvinder004/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/arvinder004/subscriptions", "organizations_url": "https://api.github.com/users/arvinder004/orgs", "repos_url": "https://api.github.com/users/arvinder004/repos", "events_url": "https://api.github.com/users/arvinder004/events{/privacy}", "received_events_url": "https://api.github.com/users/arvinder004/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-03T11:12:25
2025-10-03T12:20:32
2025-10-03T12:20:31
NONE
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41316", "html_url": "https://github.com/huggingface/transformers/pull/41316", "diff_url": "https://github.com/huggingface/transformers/pull/41316.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41316.patch", "merged_at": null }
#### Improve test reliability and coverage: - Add a minimal dtype/device parity test to catch obvious precision/device regressions. #### What’s changed- Added dtype/device parity test for GPT‑2: - Compares CPU fp32 vs CUDA fp16 logits for identical weights (tolerance ≤ 5e‑3). - Gated by `@require_torch_gpu`. #### Files touched - tests/models/gpt2/test_modeling_gpt2.py #### Test plan - Focused: `pytest -q tests/models/gpt2/test_modeling_gpt2.py::GPT2ModelTest::test_dtype_device_parity_logits_fp32_cpu_vs_fp16_cuda` - Smoke: `pytest -q tests/models/gpt2/test_modeling_gpt2.py -k parity` Checklist [x] Minimal diff, follows repo conventions [x] Tests added/updated [x] Style/lint passes locally [x] No runtime code changes @ydshieh @Rocketknight1 @CyrilVallez
{ "login": "Rocketknight1", "id": 12866554, "node_id": "MDQ6VXNlcjEyODY2NTU0", "avatar_url": "https://avatars.githubusercontent.com/u/12866554?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Rocketknight1", "html_url": "https://github.com/Rocketknight1", "followers_url": "https://api.github.com/users/Rocketknight1/followers", "following_url": "https://api.github.com/users/Rocketknight1/following{/other_user}", "gists_url": "https://api.github.com/users/Rocketknight1/gists{/gist_id}", "starred_url": "https://api.github.com/users/Rocketknight1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Rocketknight1/subscriptions", "organizations_url": "https://api.github.com/users/Rocketknight1/orgs", "repos_url": "https://api.github.com/users/Rocketknight1/repos", "events_url": "https://api.github.com/users/Rocketknight1/events{/privacy}", "received_events_url": "https://api.github.com/users/Rocketknight1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41316/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41316/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41315
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41315/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41315/comments
https://api.github.com/repos/huggingface/transformers/issues/41315/events
https://github.com/huggingface/transformers/pull/41315
3,480,676,674
PR_kwDOCUB6oc6r7xxl
41,315
[model deprecations] Define new version-based model deprecation/deletions with user warnings/exceptions
{ "login": "gante", "id": 12240844, "node_id": "MDQ6VXNlcjEyMjQwODQ0", "avatar_url": "https://avatars.githubusercontent.com/u/12240844?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gante", "html_url": "https://github.com/gante", "followers_url": "https://api.github.com/users/gante/followers", "following_url": "https://api.github.com/users/gante/following{/other_user}", "gists_url": "https://api.github.com/users/gante/gists{/gist_id}", "starred_url": "https://api.github.com/users/gante/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gante/subscriptions", "organizations_url": "https://api.github.com/users/gante/orgs", "repos_url": "https://api.github.com/users/gante/repos", "events_url": "https://api.github.com/users/gante/events{/privacy}", "received_events_url": "https://api.github.com/users/gante/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
open
false
null
[]
null
[]
2025-10-03T10:55:23
2025-10-03T11:09:57
null
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41315", "html_url": "https://github.com/huggingface/transformers/pull/41315", "diff_url": "https://github.com/huggingface/transformers/pull/41315.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41315.patch", "merged_at": null }
# What does this PR do? PR 1 out of 3 regarding model deprecation/deletions for v5 We now define a new `{model type: last version where it was supported}` mapping, which we use to: - automatically set deprecation warnings (when set version > current version) - automatically trigger informative exceptions in AutoClasses (when set version < current version, i.e. after the corresponding model is deleted) This should improve our messaging to the users and allow us to stop investing energy in low-usage architectures. 🤗 inspired by our [vllm](https://github.com/vllm-project/vllm/blob/ef283548f75122b0e8ce49ce2548fbb49446d7c7/vllm/model_executor/models/registry.py#L334) friends 🤗 ________________ Follow-up PRs: - 2 out of 3: Move a few models into the deprecated folder, as discussed on slack (target deletion version: 5.2, two minor versions after the first release that will have the deprecation warning) - 3 out of 3: Delete models that were previously in the `deprecated` folder (most of them don't work in `main` in any case 👀 ). If it's not too complex, define import-time exceptions for the deleted classes (e.g. when a user tries to call `from transformers import XXXModel`, `XXXModel` being a deleted class).
null
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41315/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41315/timeline
null
null
null
null
true
false
https://api.github.com/repos/huggingface/transformers/issues/41314
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41314/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41314/comments
https://api.github.com/repos/huggingface/transformers/issues/41314/events
https://github.com/huggingface/transformers/pull/41314
3,480,642,817
PR_kwDOCUB6oc6r7qYs
41,314
🚨 [v5] Rendundant code in nested configs
{ "login": "zucchini-nlp", "id": 100715397, "node_id": "U_kgDOBgDLhQ", "avatar_url": "https://avatars.githubusercontent.com/u/100715397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zucchini-nlp", "html_url": "https://github.com/zucchini-nlp", "followers_url": "https://api.github.com/users/zucchini-nlp/followers", "following_url": "https://api.github.com/users/zucchini-nlp/following{/other_user}", "gists_url": "https://api.github.com/users/zucchini-nlp/gists{/gist_id}", "starred_url": "https://api.github.com/users/zucchini-nlp/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zucchini-nlp/subscriptions", "organizations_url": "https://api.github.com/users/zucchini-nlp/orgs", "repos_url": "https://api.github.com/users/zucchini-nlp/repos", "events_url": "https://api.github.com/users/zucchini-nlp/events{/privacy}", "received_events_url": "https://api.github.com/users/zucchini-nlp/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-03T10:41:04
2025-10-09T11:47:45
2025-10-09T11:47:45
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41314", "html_url": "https://github.com/huggingface/transformers/pull/41314", "diff_url": "https://github.com/huggingface/transformers/pull/41314.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41314.patch", "merged_at": "2025-10-09T11:47:45" }
# What does this PR do? This PR deletes `from_xxx_config` and similar methods from everywhere and instead ensures that the config init can accept subconfigs of all formats (dict or object) Along the way, I found that not all configs call super init in the end and thus they can't set recursively attn implementation on subconfigs. I added a test for it and fixed all cases
{ "login": "zucchini-nlp", "id": 100715397, "node_id": "U_kgDOBgDLhQ", "avatar_url": "https://avatars.githubusercontent.com/u/100715397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zucchini-nlp", "html_url": "https://github.com/zucchini-nlp", "followers_url": "https://api.github.com/users/zucchini-nlp/followers", "following_url": "https://api.github.com/users/zucchini-nlp/following{/other_user}", "gists_url": "https://api.github.com/users/zucchini-nlp/gists{/gist_id}", "starred_url": "https://api.github.com/users/zucchini-nlp/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zucchini-nlp/subscriptions", "organizations_url": "https://api.github.com/users/zucchini-nlp/orgs", "repos_url": "https://api.github.com/users/zucchini-nlp/repos", "events_url": "https://api.github.com/users/zucchini-nlp/events{/privacy}", "received_events_url": "https://api.github.com/users/zucchini-nlp/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41314/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41314/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41313
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41313/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41313/comments
https://api.github.com/repos/huggingface/transformers/issues/41313/events
https://github.com/huggingface/transformers/pull/41313
3,480,626,057
PR_kwDOCUB6oc6r7mxd
41,313
Jitter noise PR
{ "login": "sambhavnoobcoder", "id": 94298612, "node_id": "U_kgDOBZ7h9A", "avatar_url": "https://avatars.githubusercontent.com/u/94298612?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sambhavnoobcoder", "html_url": "https://github.com/sambhavnoobcoder", "followers_url": "https://api.github.com/users/sambhavnoobcoder/followers", "following_url": "https://api.github.com/users/sambhavnoobcoder/following{/other_user}", "gists_url": "https://api.github.com/users/sambhavnoobcoder/gists{/gist_id}", "starred_url": "https://api.github.com/users/sambhavnoobcoder/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sambhavnoobcoder/subscriptions", "organizations_url": "https://api.github.com/users/sambhavnoobcoder/orgs", "repos_url": "https://api.github.com/users/sambhavnoobcoder/repos", "events_url": "https://api.github.com/users/sambhavnoobcoder/events{/privacy}", "received_events_url": "https://api.github.com/users/sambhavnoobcoder/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
open
false
null
[]
null
[]
2025-10-03T10:34:01
2025-10-14T12:53:30
null
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41313", "html_url": "https://github.com/huggingface/transformers/pull/41313", "diff_url": "https://github.com/huggingface/transformers/pull/41313.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41313.patch", "merged_at": null }
## Issue Description This pull request addresses a bug in the Switch Transformers architecture where the jitter noise (intended to be applied only for routing decisions) was also being unintentionally applied to the expert inputs. Fixes : #33969 ## Problem Statement In Switch Transformers, a small amount of jitter noise is added to the inputs at routing time to ensure route diversity. However, these jittered inputs were incorrectly passed along to the experts, which contradicts the original paper’s design and led to unexpected discrepancies in outputs. ## Root Cause It was discovered that the code used the same hidden states for both routing and expert processing. When jitter noise was enabled in training mode, it directly modified these states in place, causing the experts to receive noisy inputs. ## Implementation 1. We now clone the original hidden states before applying jitter noise. 2. A separate copy is used exclusively for computing router logits and probabilities. 3. The unchanged hidden states are then fed to the experts to maintain the original semantics. ## Screenshot <img width="1293" alt="Screenshot 2025-01-23 at 1 14 26 AM" src="https://github.com/user-attachments/assets/2d46438d-6344-4994-aa18-1e14376597e7" /> ## Test Cases 1. **test_router_training_mode** • Objective: Ensures that jitter noise is only applied during training. • Checks that outputs differ between consecutive runs (due to noise) but original inputs remain unchanged. 2. **test_router_jitter_noise_separation ** • Objective: Verifies that jitter noise affects only the router’s internal computations and not the expert inputs. • Confirms the logits differ when jitter is applied, while the main input stays the same. 3. **test_expert_inputs_consistency** • Objective: Asserts that all expert inputs remain consistent, even when jitter is applied during training. • Uses a forward hook on the first expert to capture its inputs across multiple runs and compares them. With these changes and test additions, we ensure that Switch Transformers adhere to the original design while preserving backward compatibility and correctness. **cc :** @ArthurZucker original pr refrence : #35847
null
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41313/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41313/timeline
null
null
null
null
true
false
https://api.github.com/repos/huggingface/transformers/issues/41312
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41312/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41312/comments
https://api.github.com/repos/huggingface/transformers/issues/41312/events
https://github.com/huggingface/transformers/pull/41312
3,480,619,723
PR_kwDOCUB6oc6r7lb8
41,312
tests: unskip and fix offline mode test using HF_HUB_OFFLINE + hermetic cache warmup
{ "login": "arvinder004", "id": 86292141, "node_id": "MDQ6VXNlcjg2MjkyMTQx", "avatar_url": "https://avatars.githubusercontent.com/u/86292141?v=4", "gravatar_id": "", "url": "https://api.github.com/users/arvinder004", "html_url": "https://github.com/arvinder004", "followers_url": "https://api.github.com/users/arvinder004/followers", "following_url": "https://api.github.com/users/arvinder004/following{/other_user}", "gists_url": "https://api.github.com/users/arvinder004/gists{/gist_id}", "starred_url": "https://api.github.com/users/arvinder004/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/arvinder004/subscriptions", "organizations_url": "https://api.github.com/users/arvinder004/orgs", "repos_url": "https://api.github.com/users/arvinder004/repos", "events_url": "https://api.github.com/users/arvinder004/events{/privacy}", "received_events_url": "https://api.github.com/users/arvinder004/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
open
false
null
[]
null
[]
2025-10-03T10:31:14
2025-10-16T15:05:04
null
NONE
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41312", "html_url": "https://github.com/huggingface/transformers/pull/41312", "diff_url": "https://github.com/huggingface/transformers/pull/41312.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41312.patch", "merged_at": null }
# What does this PR do? The offline test was skipped and brittle due to reliance on TRANSFORMERS_OFFLINE and pre-warmed caches. Standardize on HF_HUB_OFFLINE and make the test self-contained and deterministic. Fixes #41311 Changes: - Unskip `test_offline_mode`. - Implement two-step subprocess approach: - Step 1: Warm cache online by loading config, model, tokenizer, and a small pipeline. - Step 2: Run offline with `HF_HUB_OFFLINE=1` and a socket.socket monkey-patch to fail on any network access; load everything from local cache. ## Before submitting - [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [x] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request), Pull Request section? - [ ] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case. - [ ] Did you make sure to update the documentation with your changes? Here are the [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation). - [x] Did you write any new necessary tests? - Updated `tests/utils/test_offline.py::OfflineTests::test_offline_mode` to be hermetic (two-step subprocess: cache warmup online, then offline with `HF_HUB_OFFLINE=1` and socket mock). ### How to validate Run: `pytest -q tests/utils/test_offline.py::OfflineTests::test_offline_mode` @Cyrilvallez @Rocketknight1 @ydshieh
null
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41312/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41312/timeline
null
null
null
null
true
false
https://api.github.com/repos/huggingface/transformers/issues/41311
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41311/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41311/comments
https://api.github.com/repos/huggingface/transformers/issues/41311/events
https://github.com/huggingface/transformers/issues/41311
3,480,602,325
I_kwDOCUB6oc7PdcbV
41,311
Unskip and fix test_offline_mode by using HF_HUB_OFFLINE and hermetic cache warmup
{ "login": "arvinder004", "id": 86292141, "node_id": "MDQ6VXNlcjg2MjkyMTQx", "avatar_url": "https://avatars.githubusercontent.com/u/86292141?v=4", "gravatar_id": "", "url": "https://api.github.com/users/arvinder004", "html_url": "https://github.com/arvinder004", "followers_url": "https://api.github.com/users/arvinder004/followers", "following_url": "https://api.github.com/users/arvinder004/following{/other_user}", "gists_url": "https://api.github.com/users/arvinder004/gists{/gist_id}", "starred_url": "https://api.github.com/users/arvinder004/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/arvinder004/subscriptions", "organizations_url": "https://api.github.com/users/arvinder004/orgs", "repos_url": "https://api.github.com/users/arvinder004/repos", "events_url": "https://api.github.com/users/arvinder004/events{/privacy}", "received_events_url": "https://api.github.com/users/arvinder004/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1834088753, "node_id": "MDU6TGFiZWwxODM0MDg4NzUz", "url": "https://api.github.com/repos/huggingface/transformers/labels/Tests", "name": "Tests", "color": "a6fcca", "default": false, "description": "Related to tests" } ]
open
false
null
[]
null
[]
2025-10-03T10:24:07
2025-10-08T05:44:36
null
NONE
null
null
null
null
`tests/utils/test_offline.py::OfflineTests::test_offline_mode` was skipped and relied on `TRANSFORMERS_OFFLINE`. Update to use `HF_HUB_OFFLINE=1` and make the test hermetic by warming the cache in a first subprocess run, then running offline with socket mocking to forbid network access. ### Affected area: File: `tests/utils/test_offline.py` Test: `OfflineTests::test_offline_mode` ### Problem: Test was `@unittest.skip` with a TODO. Behavior depended on environment set after import and on external cache state.
null
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41311/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41311/timeline
null
null
{ "total": 0, "completed": 0, "percent_completed": 0 }
{ "blocked_by": 0, "total_blocked_by": 0, "blocking": 0, "total_blocking": 0 }
false
false
https://api.github.com/repos/huggingface/transformers/issues/41310
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41310/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41310/comments
https://api.github.com/repos/huggingface/transformers/issues/41310/events
https://github.com/huggingface/transformers/pull/41310
3,480,553,869
PR_kwDOCUB6oc6r7XVq
41,310
v4.57.0 Branch
{ "login": "ArthurZucker", "id": 48595927, "node_id": "MDQ6VXNlcjQ4NTk1OTI3", "avatar_url": "https://avatars.githubusercontent.com/u/48595927?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ArthurZucker", "html_url": "https://github.com/ArthurZucker", "followers_url": "https://api.github.com/users/ArthurZucker/followers", "following_url": "https://api.github.com/users/ArthurZucker/following{/other_user}", "gists_url": "https://api.github.com/users/ArthurZucker/gists{/gist_id}", "starred_url": "https://api.github.com/users/ArthurZucker/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ArthurZucker/subscriptions", "organizations_url": "https://api.github.com/users/ArthurZucker/orgs", "repos_url": "https://api.github.com/users/ArthurZucker/repos", "events_url": "https://api.github.com/users/ArthurZucker/events{/privacy}", "received_events_url": "https://api.github.com/users/ArthurZucker/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-03T10:05:26
2025-10-03T16:29:53
2025-10-03T16:29:52
COLLABORATOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41310", "html_url": "https://github.com/huggingface/transformers/pull/41310", "diff_url": "https://github.com/huggingface/transformers/pull/41310.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41310.patch", "merged_at": "2025-10-03T16:29:52" }
# What does this PR do? <!-- Congratulations! You've made it this far! You're not quite done yet though. Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution. Then, please replace this with a description of the change and which issue is fixed (if applicable). Please also include relevant motivation and context. List any dependencies (if any) that are required for this change. Once you're done, someone will review your PR shortly (see the section "Who can review?" below to tag some potential reviewers). They may suggest changes to make the code even better. If no one reviewed your PR after a week has passed, don't hesitate to post a new comment @-mentioning the same persons---sometimes notifications get lost. --> <!-- Remove if not applicable --> Fixes # (issue) ## Before submitting - [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [ ] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request), Pull Request section? - [ ] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case. - [ ] Did you make sure to update the documentation with your changes? Here are the [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation). - [ ] Did you write any new necessary tests? ## Who can review? Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR. <!-- Your PR will be replied to more quickly if you can figure out the right person to tag with @ If you know how to use git blame, that is the easiest way, otherwise, here is a rough guide of **who to tag**. Please tag fewer than 3 people. Models: - text models: @ArthurZucker @Cyrilvallez - vision models: @yonigozlan @molbap - audio models: @eustlb @ebezzam @vasqu - multimodal models: @zucchini-nlp - graph models: @clefourrier Library: - generate: @zucchini-nlp (visual-language models) or @gante (all others) - continuous batching: @remi-or @ArthurZucker @McPatate - pipelines: @Rocketknight1 - tokenizers: @ArthurZucker and @itazap - trainer: @zach-huggingface @SunMarc - attention: @vasqu @ArthurZucker @CyrilVallez - model loading (from pretrained, etc): @CyrilVallez - distributed: @3outeille @ArthurZucker @S1ro1 - CIs: @ydshieh Integrations: - deepspeed: HF Trainer/Accelerate: @SunMarc @zach-huggingface - ray/raytune: @richardliaw, @amogkam - Big Model Inference: @SunMarc - quantization (bitsandbytes, autogpt): @SunMarc @MekkCyber - kernels: @MekkCyber @drbh - peft: @BenjaminBossan @githubnemo Devices/Backends: - AMD ROCm: @ivarflakstad - Intel XPU: @IlyasMoutawwakil - Ascend NPU: @ivarflakstad Documentation: @stevhliu Research projects are not maintained and should be taken as is. -->
{ "login": "LysandreJik", "id": 30755778, "node_id": "MDQ6VXNlcjMwNzU1Nzc4", "avatar_url": "https://avatars.githubusercontent.com/u/30755778?v=4", "gravatar_id": "", "url": "https://api.github.com/users/LysandreJik", "html_url": "https://github.com/LysandreJik", "followers_url": "https://api.github.com/users/LysandreJik/followers", "following_url": "https://api.github.com/users/LysandreJik/following{/other_user}", "gists_url": "https://api.github.com/users/LysandreJik/gists{/gist_id}", "starred_url": "https://api.github.com/users/LysandreJik/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/LysandreJik/subscriptions", "organizations_url": "https://api.github.com/users/LysandreJik/orgs", "repos_url": "https://api.github.com/users/LysandreJik/repos", "events_url": "https://api.github.com/users/LysandreJik/events{/privacy}", "received_events_url": "https://api.github.com/users/LysandreJik/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41310/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41310/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41309
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41309/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41309/comments
https://api.github.com/repos/huggingface/transformers/issues/41309/events
https://github.com/huggingface/transformers/pull/41309
3,480,284,160
PR_kwDOCUB6oc6r6eRj
41,309
Fix jamba
{ "login": "Cyrilvallez", "id": 71554963, "node_id": "MDQ6VXNlcjcxNTU0OTYz", "avatar_url": "https://avatars.githubusercontent.com/u/71554963?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Cyrilvallez", "html_url": "https://github.com/Cyrilvallez", "followers_url": "https://api.github.com/users/Cyrilvallez/followers", "following_url": "https://api.github.com/users/Cyrilvallez/following{/other_user}", "gists_url": "https://api.github.com/users/Cyrilvallez/gists{/gist_id}", "starred_url": "https://api.github.com/users/Cyrilvallez/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Cyrilvallez/subscriptions", "organizations_url": "https://api.github.com/users/Cyrilvallez/orgs", "repos_url": "https://api.github.com/users/Cyrilvallez/repos", "events_url": "https://api.github.com/users/Cyrilvallez/events{/privacy}", "received_events_url": "https://api.github.com/users/Cyrilvallez/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-03T08:37:14
2025-10-03T14:54:22
2025-10-03T14:54:19
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41309", "html_url": "https://github.com/huggingface/transformers/pull/41309", "diff_url": "https://github.com/huggingface/transformers/pull/41309.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41309.patch", "merged_at": "2025-10-03T14:54:19" }
# What does this PR do? Jamba was mostly destroyed in https://github.com/huggingface/transformers/pull/40132, this PR fixes it! Slow tests are good
{ "login": "Cyrilvallez", "id": 71554963, "node_id": "MDQ6VXNlcjcxNTU0OTYz", "avatar_url": "https://avatars.githubusercontent.com/u/71554963?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Cyrilvallez", "html_url": "https://github.com/Cyrilvallez", "followers_url": "https://api.github.com/users/Cyrilvallez/followers", "following_url": "https://api.github.com/users/Cyrilvallez/following{/other_user}", "gists_url": "https://api.github.com/users/Cyrilvallez/gists{/gist_id}", "starred_url": "https://api.github.com/users/Cyrilvallez/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Cyrilvallez/subscriptions", "organizations_url": "https://api.github.com/users/Cyrilvallez/orgs", "repos_url": "https://api.github.com/users/Cyrilvallez/repos", "events_url": "https://api.github.com/users/Cyrilvallez/events{/privacy}", "received_events_url": "https://api.github.com/users/Cyrilvallez/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41309/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41309/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41308
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41308/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41308/comments
https://api.github.com/repos/huggingface/transformers/issues/41308/events
https://github.com/huggingface/transformers/pull/41308
3,480,256,740
PR_kwDOCUB6oc6r6Ydv
41,308
Subconfig is a class attribute
{ "login": "zucchini-nlp", "id": 100715397, "node_id": "U_kgDOBgDLhQ", "avatar_url": "https://avatars.githubusercontent.com/u/100715397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zucchini-nlp", "html_url": "https://github.com/zucchini-nlp", "followers_url": "https://api.github.com/users/zucchini-nlp/followers", "following_url": "https://api.github.com/users/zucchini-nlp/following{/other_user}", "gists_url": "https://api.github.com/users/zucchini-nlp/gists{/gist_id}", "starred_url": "https://api.github.com/users/zucchini-nlp/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zucchini-nlp/subscriptions", "organizations_url": "https://api.github.com/users/zucchini-nlp/orgs", "repos_url": "https://api.github.com/users/zucchini-nlp/repos", "events_url": "https://api.github.com/users/zucchini-nlp/events{/privacy}", "received_events_url": "https://api.github.com/users/zucchini-nlp/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-03T08:27:35
2025-10-09T08:46:44
2025-10-09T08:46:44
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41308", "html_url": "https://github.com/huggingface/transformers/pull/41308", "diff_url": "https://github.com/huggingface/transformers/pull/41308.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41308.patch", "merged_at": "2025-10-09T08:46:44" }
# What does this PR do? As per title, it should be a class attribute for vision-only models. VLMs already use class attribute. If it is a property, it is unavailable before we init the class. Having it as a class attribute will be needed for integrating type validation and transforming all configs to a dataclass Also cleaned up some duplicate code. An attribute map already maps those keys, so an extra property is not needed
{ "login": "zucchini-nlp", "id": 100715397, "node_id": "U_kgDOBgDLhQ", "avatar_url": "https://avatars.githubusercontent.com/u/100715397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zucchini-nlp", "html_url": "https://github.com/zucchini-nlp", "followers_url": "https://api.github.com/users/zucchini-nlp/followers", "following_url": "https://api.github.com/users/zucchini-nlp/following{/other_user}", "gists_url": "https://api.github.com/users/zucchini-nlp/gists{/gist_id}", "starred_url": "https://api.github.com/users/zucchini-nlp/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zucchini-nlp/subscriptions", "organizations_url": "https://api.github.com/users/zucchini-nlp/orgs", "repos_url": "https://api.github.com/users/zucchini-nlp/repos", "events_url": "https://api.github.com/users/zucchini-nlp/events{/privacy}", "received_events_url": "https://api.github.com/users/zucchini-nlp/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41308/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41308/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41307
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41307/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41307/comments
https://api.github.com/repos/huggingface/transformers/issues/41307/events
https://github.com/huggingface/transformers/pull/41307
3,480,146,127
PR_kwDOCUB6oc6r6Ayy
41,307
Update torch minimum version to 2.3
{ "login": "cyyever", "id": 17618148, "node_id": "MDQ6VXNlcjE3NjE4MTQ4", "avatar_url": "https://avatars.githubusercontent.com/u/17618148?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cyyever", "html_url": "https://github.com/cyyever", "followers_url": "https://api.github.com/users/cyyever/followers", "following_url": "https://api.github.com/users/cyyever/following{/other_user}", "gists_url": "https://api.github.com/users/cyyever/gists{/gist_id}", "starred_url": "https://api.github.com/users/cyyever/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cyyever/subscriptions", "organizations_url": "https://api.github.com/users/cyyever/orgs", "repos_url": "https://api.github.com/users/cyyever/repos", "events_url": "https://api.github.com/users/cyyever/events{/privacy}", "received_events_url": "https://api.github.com/users/cyyever/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
open
false
null
[]
null
[]
2025-10-03T07:46:41
2025-10-17T15:20:40
null
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41307", "html_url": "https://github.com/huggingface/transformers/pull/41307", "diff_url": "https://github.com/huggingface/transformers/pull/41307.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41307.patch", "merged_at": null }
# What does this PR do? PyTorch 2.9 is released. Looking forward to lift the PT minimum version again.
null
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41307/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41307/timeline
null
null
null
null
true
false
https://api.github.com/repos/huggingface/transformers/issues/41306
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41306/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41306/comments
https://api.github.com/repos/huggingface/transformers/issues/41306/events
https://github.com/huggingface/transformers/issues/41306
3,479,461,065
I_kwDOCUB6oc7PZFzJ
41,306
TiledFusedLogitsLoss (LigerFusedLinearCrossEntropy, FLCE) Flag in `from_pretrained()`
{ "login": "Tcc0403", "id": 76503978, "node_id": "MDQ6VXNlcjc2NTAzOTc4", "avatar_url": "https://avatars.githubusercontent.com/u/76503978?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Tcc0403", "html_url": "https://github.com/Tcc0403", "followers_url": "https://api.github.com/users/Tcc0403/followers", "following_url": "https://api.github.com/users/Tcc0403/following{/other_user}", "gists_url": "https://api.github.com/users/Tcc0403/gists{/gist_id}", "starred_url": "https://api.github.com/users/Tcc0403/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Tcc0403/subscriptions", "organizations_url": "https://api.github.com/users/Tcc0403/orgs", "repos_url": "https://api.github.com/users/Tcc0403/repos", "events_url": "https://api.github.com/users/Tcc0403/events{/privacy}", "received_events_url": "https://api.github.com/users/Tcc0403/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 2648621985, "node_id": "MDU6TGFiZWwyNjQ4NjIxOTg1", "url": "https://api.github.com/repos/huggingface/transformers/labels/Feature%20request", "name": "Feature request", "color": "FBCA04", "default": false, "description": "Request for a new feature" } ]
open
false
null
[]
null
[]
2025-10-03T01:36:44
2025-10-28T13:55:39
null
NONE
null
null
null
null
### Feature request Add a native `tiled_fused_logits_loss` flag in `from_pretrained()` that enables memory-efficient cross entropy computation across different backends. Example API: ```python from_pretrained(..., tiled_fused_logits_loss=Union[bool, List["auto", "liger-kernel", "deepspeed"]) ``` Supported options could include: - `"liger-kernel"` : use [Liger Kernel](https://github.com/linkedin/liger-kernel) (triton) - `"deepspeed"` : use [DeepSpeed/ALST implementation](https://github.com/deepspeedai/DeepSpeed/blob/16c1bf429f10db3e681b49fac37d641909aad69d/deepspeed/runtime/sequence_parallel/ulysses_sp.py#L898) (pure pytorch), but still performing the same memory savings. - `True`, `"auto"` : automatically try to use the most efficient solution (liger for now) - `False` (default) : no change If the chosen backend is unavailable or unsupported, Transformers can gracefully fall back to the PyTorch implementation. (Optional) Remind users that they won't be able to retrieve full logits when enabling `tiled_fused_logits_loss`. ### Motivation Manifesting logits and cross entropy loss computation is often the largest memory bottleneck during training when working with long sequence, large batch size and large vocab size. Recent paper on long sequence training: https://arxiv.org/abs/2506.13996 shows sequence tiling can massively reduce memory footprint, enabling longer sequence and larger batch sizes. <img width="633" height="362" alt="Image" src="https://github.com/user-attachments/assets/a39ec6ee-61ee-43d3-bc58-2524d9b1dd73" /> > In Figure 3 we show two plots: (left) without Sequence Tiling the loss calculation we see peak memory usage is around 50 GiB compared to (right) after updating the loss calculation to use Sequence Tiling we see the peak memory usage drops to 36 GiB which results in a > 28% memory reduction <img width="507" height="239" alt="Image" src="https://github.com/user-attachments/assets/b0c9ba25-72f7-488b-94b9-c17b23576d56" /> Table 1 shows that "Tiled Logits & Loss" alone enables training with much longer sequence length. I'm aware that Transformers already includes some `liger_*` training arguments, but those are backend-specific. I believe it's a great time to have a standard native flag that all backend (liger, ds) could rely on, or make it a built-in feature which can avoid monkey patching modeling codes, leading to a huge maintenance overhead. ### More context about native support To apply tiling sequence techniques for fusing logits and loss computation, we need to modify the code in `XXXForCausalLM.forward()` or `XXXForConditionalGeneration.forward()`. I'm not sure whether such replacement can be easily achieved by [HF/kernels](https://github.com/huggingface/kernels). The modificiation itself is pretty straight-forward. The core logic is just replacing ```python self.loss_fn(self.lm_head(hidden_states), labels, ...) ``` with ```python tiled_fused_logits_loss(hidden_states, self.lm_head.weight, labels, ...) ``` plus some rearrangements of `logits_to_keep`, `attention_mask`, etc. I think modularizing the change and making it a built-in feature can benefit users a lot, so they don't have to wait for the patch for unsupported models. ### Your contribution I'm happy to help with making the PR, just want to know your opinions beforehand.
null
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41306/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41306/timeline
null
null
{ "total": 0, "completed": 0, "percent_completed": 0 }
{ "blocked_by": 0, "total_blocked_by": 0, "blocking": 0, "total_blocking": 0 }
false
false
https://api.github.com/repos/huggingface/transformers/issues/41305
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41305/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41305/comments
https://api.github.com/repos/huggingface/transformers/issues/41305/events
https://github.com/huggingface/transformers/pull/41305
3,479,455,552
PR_kwDOCUB6oc6r3tL7
41,305
Remove unnecessary list comprehension
{ "login": "cyyever", "id": 17618148, "node_id": "MDQ6VXNlcjE3NjE4MTQ4", "avatar_url": "https://avatars.githubusercontent.com/u/17618148?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cyyever", "html_url": "https://github.com/cyyever", "followers_url": "https://api.github.com/users/cyyever/followers", "following_url": "https://api.github.com/users/cyyever/following{/other_user}", "gists_url": "https://api.github.com/users/cyyever/gists{/gist_id}", "starred_url": "https://api.github.com/users/cyyever/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cyyever/subscriptions", "organizations_url": "https://api.github.com/users/cyyever/orgs", "repos_url": "https://api.github.com/users/cyyever/repos", "events_url": "https://api.github.com/users/cyyever/events{/privacy}", "received_events_url": "https://api.github.com/users/cyyever/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-03T01:33:30
2025-10-06T23:50:26
2025-10-06T14:49:03
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41305", "html_url": "https://github.com/huggingface/transformers/pull/41305", "diff_url": "https://github.com/huggingface/transformers/pull/41305.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41305.patch", "merged_at": "2025-10-06T14:49:03" }
# What does this PR do? Fix unnecessary list/tuple comprehension in code, other tiny fixes are also included.
{ "login": "Rocketknight1", "id": 12866554, "node_id": "MDQ6VXNlcjEyODY2NTU0", "avatar_url": "https://avatars.githubusercontent.com/u/12866554?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Rocketknight1", "html_url": "https://github.com/Rocketknight1", "followers_url": "https://api.github.com/users/Rocketknight1/followers", "following_url": "https://api.github.com/users/Rocketknight1/following{/other_user}", "gists_url": "https://api.github.com/users/Rocketknight1/gists{/gist_id}", "starred_url": "https://api.github.com/users/Rocketknight1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Rocketknight1/subscriptions", "organizations_url": "https://api.github.com/users/Rocketknight1/orgs", "repos_url": "https://api.github.com/users/Rocketknight1/repos", "events_url": "https://api.github.com/users/Rocketknight1/events{/privacy}", "received_events_url": "https://api.github.com/users/Rocketknight1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41305/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41305/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41304
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41304/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41304/comments
https://api.github.com/repos/huggingface/transformers/issues/41304/events
https://github.com/huggingface/transformers/pull/41304
3,479,015,126
PR_kwDOCUB6oc6r2OzB
41,304
Fix equality-vs-assignment bug in GptqHfQuantizer.update_device_map
{ "login": "gapsong", "id": 15983559, "node_id": "MDQ6VXNlcjE1OTgzNTU5", "avatar_url": "https://avatars.githubusercontent.com/u/15983559?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gapsong", "html_url": "https://github.com/gapsong", "followers_url": "https://api.github.com/users/gapsong/followers", "following_url": "https://api.github.com/users/gapsong/following{/other_user}", "gists_url": "https://api.github.com/users/gapsong/gists{/gist_id}", "starred_url": "https://api.github.com/users/gapsong/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gapsong/subscriptions", "organizations_url": "https://api.github.com/users/gapsong/orgs", "repos_url": "https://api.github.com/users/gapsong/repos", "events_url": "https://api.github.com/users/gapsong/events{/privacy}", "received_events_url": "https://api.github.com/users/gapsong/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
open
false
null
[]
null
[]
2025-10-02T21:33:26
2025-10-08T16:56:08
null
NONE
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41304", "html_url": "https://github.com/huggingface/transformers/pull/41304", "diff_url": "https://github.com/huggingface/transformers/pull/41304.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41304.patch", "merged_at": null }
Fixes a typo in `GptqHfQuantizer.update_device_map` where an equality comparison (`==`) was used instead of an assignment (`=`). Due to this, `device_map` was never updated to CUDA when using `auto-gptq` (which does not support CPU), leaving the model on CPU contrary to the intent expressed in the comment. - File: [src/transformers/quantizers/quantizer_gptq.py](https://github.com/huggingface/transformers/blob/e54defcfc265a1cc4f62edbf977747a0a443c812/src/transformers/quantizers/quantizer_gptq.py) - Function: `GptqHfQuantizer.update_device_map` Before: ```python if not is_gptqmodel_available() and device_map in ("cpu", {"": torch.device("cpu")}): device_map == {"": 0} ``` After: ```python if not is_gptqmodel_available() and device_map in ("cpu", {"": torch.device("cpu")}): device_map = {"": 0} ``` This change makes the code match the intended behavior: when `gptqmodel` is not available and the model would otherwise be placed on CPU, move to CUDA device map (`{"": 0}`). ## Who can review? - quantization (bitsandbytes, autogpt, gptqmodel): @SunMarc @MekkCyber Anyone in the community is also welcome to review.
null
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41304/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41304/timeline
null
null
null
null
true
false
https://api.github.com/repos/huggingface/transformers/issues/41303
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41303/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41303/comments
https://api.github.com/repos/huggingface/transformers/issues/41303/events
https://github.com/huggingface/transformers/pull/41303
3,478,596,145
PR_kwDOCUB6oc6r0zUL
41,303
Fix README.md error when installing from source
{ "login": "TKONIY", "id": 47519522, "node_id": "MDQ6VXNlcjQ3NTE5NTIy", "avatar_url": "https://avatars.githubusercontent.com/u/47519522?v=4", "gravatar_id": "", "url": "https://api.github.com/users/TKONIY", "html_url": "https://github.com/TKONIY", "followers_url": "https://api.github.com/users/TKONIY/followers", "following_url": "https://api.github.com/users/TKONIY/following{/other_user}", "gists_url": "https://api.github.com/users/TKONIY/gists{/gist_id}", "starred_url": "https://api.github.com/users/TKONIY/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/TKONIY/subscriptions", "organizations_url": "https://api.github.com/users/TKONIY/orgs", "repos_url": "https://api.github.com/users/TKONIY/repos", "events_url": "https://api.github.com/users/TKONIY/events{/privacy}", "received_events_url": "https://api.github.com/users/TKONIY/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-02T19:02:04
2025-10-02T23:08:52
2025-10-02T23:08:27
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41303", "html_url": "https://github.com/huggingface/transformers/pull/41303", "diff_url": "https://github.com/huggingface/transformers/pull/41303.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41303.patch", "merged_at": "2025-10-02T23:08:27" }
# What does this PR do? When running the `uv pip install .[torch]` in some shell, e.g., zsh, an error occurs `zsh: no matches found: .[torch]`. This PR fixed it by adding `''`. ## Before submitting - [x] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [x] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request), Pull Request section? - [ ] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case. - [x] Did you make sure to update the documentation with your changes? Here are the [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation). - [ ] Did you write any new necessary tests? ## CC @stevhliu
{ "login": "stevhliu", "id": 59462357, "node_id": "MDQ6VXNlcjU5NDYyMzU3", "avatar_url": "https://avatars.githubusercontent.com/u/59462357?v=4", "gravatar_id": "", "url": "https://api.github.com/users/stevhliu", "html_url": "https://github.com/stevhliu", "followers_url": "https://api.github.com/users/stevhliu/followers", "following_url": "https://api.github.com/users/stevhliu/following{/other_user}", "gists_url": "https://api.github.com/users/stevhliu/gists{/gist_id}", "starred_url": "https://api.github.com/users/stevhliu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/stevhliu/subscriptions", "organizations_url": "https://api.github.com/users/stevhliu/orgs", "repos_url": "https://api.github.com/users/stevhliu/repos", "events_url": "https://api.github.com/users/stevhliu/events{/privacy}", "received_events_url": "https://api.github.com/users/stevhliu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41303/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41303/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41302
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41302/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41302/comments
https://api.github.com/repos/huggingface/transformers/issues/41302/events
https://github.com/huggingface/transformers/pull/41302
3,478,382,161
PR_kwDOCUB6oc6r0E8E
41,302
Fix HfArgumentParser parsing for Union[dict, str] fields (e.g., --lr_scheduler_kwargs)
{ "login": "gmmkmtgk", "id": 51493190, "node_id": "MDQ6VXNlcjUxNDkzMTkw", "avatar_url": "https://avatars.githubusercontent.com/u/51493190?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gmmkmtgk", "html_url": "https://github.com/gmmkmtgk", "followers_url": "https://api.github.com/users/gmmkmtgk/followers", "following_url": "https://api.github.com/users/gmmkmtgk/following{/other_user}", "gists_url": "https://api.github.com/users/gmmkmtgk/gists{/gist_id}", "starred_url": "https://api.github.com/users/gmmkmtgk/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gmmkmtgk/subscriptions", "organizations_url": "https://api.github.com/users/gmmkmtgk/orgs", "repos_url": "https://api.github.com/users/gmmkmtgk/repos", "events_url": "https://api.github.com/users/gmmkmtgk/events{/privacy}", "received_events_url": "https://api.github.com/users/gmmkmtgk/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-02T17:47:55
2025-10-14T14:23:10
2025-10-14T14:01:19
NONE
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41302", "html_url": "https://github.com/huggingface/transformers/pull/41302", "diff_url": "https://github.com/huggingface/transformers/pull/41302.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41302.patch", "merged_at": null }
…scheduler_kwargs) # What does this PR do? This PR fixes the bug where `Union[dict, str]` fields, such as `--lr_scheduler_kwargs` in `TrainingArguments`, could not be parsed correctly from the command line. **Root Cause:** The issue was introduced when the type of `lr_scheduler_kwargs` changed from `Optional[Union[dict[str, Any], str]]` to `Union[dict[str, Any], str]`. `HfArgumentParser` previously filtered out `str` from Union types when `None` was not present, which caused `argparse` to attempt parsing the argument as a `dict` directly, leading to errors when passing JSON strings via CLI. **Fix:** * Modified `src/transformers/hf_argparser.py` to detect `Union[dict, str]` types and keep the type as `str` for `argparse`. * Conversion from JSON string → `dict` now happens later in `TrainingArguments.post_init_`. * Maintains backward compatibility with `Optional[Union[dict, str]]` fields. **Tests added:** * `test_17_union_dict_str_parsing()`: verifies basic Union[dict, str] CLI parsing. * `test_18_lr_scheduler_kwargs_parsing()`: regression test specifically for the `lr_scheduler_kwargs` issue. Fixes the behavior reported in [#41296](https://github.com/huggingface/transformers/issues/41296). <!-- Congratulations! You've made it this far! You're not quite done yet though. Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution. Then, please replace this with a description of the change and which issue is fixed (if applicable). Please also include relevant motivation and context. List any dependencies (if any) that are required for this change. Once you're done, someone will review your PR shortly (see the section "Who can review?" below to tag some potential reviewers). They may suggest changes to make the code even better. If no one reviewed your PR after a week has passed, don't hesitate to post a new comment @-mentioning the same persons---sometimes notifications get lost. --> <!-- Remove if not applicable --> Fixes # (issue) ## Before submitting - [x] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [x] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request), Pull Request section? - [ ] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case. - [ ] Did you make sure to update the documentation with your changes? Here are the [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation). - [x] Did you write any new necessary tests? ## Who can review? Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR. <!-- Your PR will be replied to more quickly if you can figure out the right person to tag with @ If you know how to use git blame, that is the easiest way, otherwise, here is a rough guide of **who to tag**. Please tag fewer than 3 people. Models: - text models: @ArthurZucker @Cyrilvallez - vision models: @yonigozlan @molbap - audio models: @eustlb @ebezzam @vasqu - multimodal models: @zucchini-nlp - graph models: @clefourrier Library: - generate: @zucchini-nlp (visual-language models) or @gante (all others) - continuous batching: @remi-or @ArthurZucker @McPatate - pipelines: @Rocketknight1 - tokenizers: @ArthurZucker and @itazap - trainer: @zach-huggingface @SunMarc - attention: @vasqu @ArthurZucker @CyrilVallez - model loading (from pretrained, etc): @CyrilVallez - distributed: @3outeille @ArthurZucker @S1ro1 - CIs: @ydshieh Integrations: - deepspeed: HF Trainer/Accelerate: @SunMarc @zach-huggingface - ray/raytune: @richardliaw, @amogkam - Big Model Inference: @SunMarc - quantization (bitsandbytes, autogpt): @SunMarc @MekkCyber - kernels: @MekkCyber @drbh - peft: @BenjaminBossan @githubnemo Devices/Backends: - AMD ROCm: @ivarflakstad - Intel XPU: @IlyasMoutawwakil - Ascend NPU: @ivarflakstad Documentation: @stevhliu Research projects are not maintained and should be taken as is. -->
{ "login": "SunMarc", "id": 57196510, "node_id": "MDQ6VXNlcjU3MTk2NTEw", "avatar_url": "https://avatars.githubusercontent.com/u/57196510?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SunMarc", "html_url": "https://github.com/SunMarc", "followers_url": "https://api.github.com/users/SunMarc/followers", "following_url": "https://api.github.com/users/SunMarc/following{/other_user}", "gists_url": "https://api.github.com/users/SunMarc/gists{/gist_id}", "starred_url": "https://api.github.com/users/SunMarc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SunMarc/subscriptions", "organizations_url": "https://api.github.com/users/SunMarc/orgs", "repos_url": "https://api.github.com/users/SunMarc/repos", "events_url": "https://api.github.com/users/SunMarc/events{/privacy}", "received_events_url": "https://api.github.com/users/SunMarc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41302/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41302/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41301
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41301/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41301/comments
https://api.github.com/repos/huggingface/transformers/issues/41301/events
https://github.com/huggingface/transformers/issues/41301
3,478,312,513
I_kwDOCUB6oc7PUtZB
41,301
HTTP proxies via env variables no longer working in the main branch of transformers
{ "login": "jerryzh168", "id": 4958441, "node_id": "MDQ6VXNlcjQ5NTg0NDE=", "avatar_url": "https://avatars.githubusercontent.com/u/4958441?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jerryzh168", "html_url": "https://github.com/jerryzh168", "followers_url": "https://api.github.com/users/jerryzh168/followers", "following_url": "https://api.github.com/users/jerryzh168/following{/other_user}", "gists_url": "https://api.github.com/users/jerryzh168/gists{/gist_id}", "starred_url": "https://api.github.com/users/jerryzh168/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jerryzh168/subscriptions", "organizations_url": "https://api.github.com/users/jerryzh168/orgs", "repos_url": "https://api.github.com/users/jerryzh168/repos", "events_url": "https://api.github.com/users/jerryzh168/events{/privacy}", "received_events_url": "https://api.github.com/users/jerryzh168/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 3817266200, "node_id": "MDU6TGFiZWwzODE3MjY2MjAw", "url": "https://api.github.com/repos/huggingface/transformers/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": null } ]
closed
false
null
[]
null
[]
2025-10-02T17:22:47
2025-10-16T06:31:35
2025-10-16T02:18:26
CONTRIBUTOR
null
null
null
null
### System Info The problem was encountered when trying to use the main branch of the transformers repo which depends on the package `huggingface-hub==1.0.0.rc2` with an HTTP proxy supplied by standard environment variables (`HTTP_PROXY`, `HTTPS_PROXY`, etc). This worked before this dependency upgrade was introduced. This PR mentions that HTTP proxies are now supposed to be configured via environment variables, so it seems it should be supported: https://github.com/huggingface/transformers/pull/40889 This is also officially supported by `httpx`, which is the new http library introduced in the PR: https://www.python-httpx.org/environment_variables/#proxies However, it seems like for some reason `httpx` will ignore the proxy if a custom `Transport` is used: https://github.com/encode/httpx/blob/c0b46ebf4cf724d813c8595602e6a5b59aef5177/httpx/_client.py#L685 `huggingface_hub` provides a custom `Transport` to `httpx`, so it seems like it is not possible to use a proxy using environment variables using the default transport configured here: https://github.com/huggingface/huggingface_hub/blob/f3334dd2da172093264dcc7a681d6eea14c7793d/src/huggingface_hub/utils/_http.py#L133C1-L141C6 It seems like this dependency update broke using HTTP proxies completely with `transformers` because of the removal of the proxy arguments and the environment variable setting no longer working. A way to workaround for this can be done using the `set_client_factory` functions in `huggingface_hub`, but it would preferable if this could be done transparently by the library if the environment variable(s) for proxies are present which is how it worked before. Workaround: ```python import os import httpx from huggingface_hub import set_client_factory, set_async_client_factory, HfHubTransport, constants from huggingface_hub.utils._http import default_client_factory, default_async_client_factory def env_proxy_client_factory(): return httpx.Client( transport=HfHubTransport(), follow_redirects=True, timeout=httpx.Timeout(constants.DEFAULT_REQUEST_TIMEOUT, write=60.0), proxy=os.environ.get("HTTP_PROXY"), ) def async_env_proxy_client_factory(): return httpx.AsyncClient( transport=HfHubTransport(), follow_redirects=True, timeout=httpx.Timeout(constants.DEFAULT_REQUEST_TIMEOUT, write=60.0), proxy=os.environ.get("HTTP_PROXY"), ) set_client_factory(env_proxy_client_factory) set_async_client_factory(async_env_proxy_client_factory) from transformers import AutoModelForCausalLM model = AutoModelForCausalLM.from_pretrained('TinyLlama/TinyLlama-1.1B-Chat-v1.0') ``` ### Who can help? cc @Wauplin @ArthurZucker @ydshieh ### Information - [x] The official example scripts - [ ] My own modified scripts ### Tasks - [ ] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...) - [ ] My own task or dataset (give details below) ### Reproduction This only happens in my internal dev server setup which uses proxy, and the proxy no longer works so there is network error `python -c "from transformers import AutoModelForCausalLM; model = AutoModelForCausalLM.from_pretrained('TinyLlama/TinyLlama-1.1B-Chat-v1.0')"` or `hf download TinyLlama/TinyLlama-1.1B-Chat-v1.0` Got error: ``` httpcore.ConnectError: [Errno 101] Network is unreachable ``` ### Expected behavior we should be able to download models successfully, with internet proxy.
{ "login": "jerryzh168", "id": 4958441, "node_id": "MDQ6VXNlcjQ5NTg0NDE=", "avatar_url": "https://avatars.githubusercontent.com/u/4958441?v=4", "gravatar_id": "", "url": "https://api.github.com/users/jerryzh168", "html_url": "https://github.com/jerryzh168", "followers_url": "https://api.github.com/users/jerryzh168/followers", "following_url": "https://api.github.com/users/jerryzh168/following{/other_user}", "gists_url": "https://api.github.com/users/jerryzh168/gists{/gist_id}", "starred_url": "https://api.github.com/users/jerryzh168/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/jerryzh168/subscriptions", "organizations_url": "https://api.github.com/users/jerryzh168/orgs", "repos_url": "https://api.github.com/users/jerryzh168/repos", "events_url": "https://api.github.com/users/jerryzh168/events{/privacy}", "received_events_url": "https://api.github.com/users/jerryzh168/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41301/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41301/timeline
null
completed
{ "total": 0, "completed": 0, "percent_completed": 0 }
{ "blocked_by": 0, "total_blocked_by": 0, "blocking": 0, "total_blocking": 0 }
false
true
https://api.github.com/repos/huggingface/transformers/issues/41300
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41300/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41300/comments
https://api.github.com/repos/huggingface/transformers/issues/41300/events
https://github.com/huggingface/transformers/pull/41300
3,478,209,069
PR_kwDOCUB6oc6rze84
41,300
Standardize `PretrainedConfig` to `PreTrainedConfig`
{ "login": "Cyrilvallez", "id": 71554963, "node_id": "MDQ6VXNlcjcxNTU0OTYz", "avatar_url": "https://avatars.githubusercontent.com/u/71554963?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Cyrilvallez", "html_url": "https://github.com/Cyrilvallez", "followers_url": "https://api.github.com/users/Cyrilvallez/followers", "following_url": "https://api.github.com/users/Cyrilvallez/following{/other_user}", "gists_url": "https://api.github.com/users/Cyrilvallez/gists{/gist_id}", "starred_url": "https://api.github.com/users/Cyrilvallez/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Cyrilvallez/subscriptions", "organizations_url": "https://api.github.com/users/Cyrilvallez/orgs", "repos_url": "https://api.github.com/users/Cyrilvallez/repos", "events_url": "https://api.github.com/users/Cyrilvallez/events{/privacy}", "received_events_url": "https://api.github.com/users/Cyrilvallez/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-02T16:51:41
2025-10-06T09:34:34
2025-10-06T09:34:02
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41300", "html_url": "https://github.com/huggingface/transformers/pull/41300", "diff_url": "https://github.com/huggingface/transformers/pull/41300.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41300.patch", "merged_at": "2025-10-06T09:34:02" }
# What does this PR do? As per the title! This is very very long due.
{ "login": "Cyrilvallez", "id": 71554963, "node_id": "MDQ6VXNlcjcxNTU0OTYz", "avatar_url": "https://avatars.githubusercontent.com/u/71554963?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Cyrilvallez", "html_url": "https://github.com/Cyrilvallez", "followers_url": "https://api.github.com/users/Cyrilvallez/followers", "following_url": "https://api.github.com/users/Cyrilvallez/following{/other_user}", "gists_url": "https://api.github.com/users/Cyrilvallez/gists{/gist_id}", "starred_url": "https://api.github.com/users/Cyrilvallez/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Cyrilvallez/subscriptions", "organizations_url": "https://api.github.com/users/Cyrilvallez/orgs", "repos_url": "https://api.github.com/users/Cyrilvallez/repos", "events_url": "https://api.github.com/users/Cyrilvallez/events{/privacy}", "received_events_url": "https://api.github.com/users/Cyrilvallez/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41300/reactions", "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 1, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41300/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41299
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41299/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41299/comments
https://api.github.com/repos/huggingface/transformers/issues/41299/events
https://github.com/huggingface/transformers/pull/41299
3,478,193,760
PR_kwDOCUB6oc6rzboy
41,299
copied changes from soghomon-b:add-eval-step-limit-31561
{ "login": "soghomon-b", "id": 113225832, "node_id": "U_kgDOBr-waA", "avatar_url": "https://avatars.githubusercontent.com/u/113225832?v=4", "gravatar_id": "", "url": "https://api.github.com/users/soghomon-b", "html_url": "https://github.com/soghomon-b", "followers_url": "https://api.github.com/users/soghomon-b/followers", "following_url": "https://api.github.com/users/soghomon-b/following{/other_user}", "gists_url": "https://api.github.com/users/soghomon-b/gists{/gist_id}", "starred_url": "https://api.github.com/users/soghomon-b/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/soghomon-b/subscriptions", "organizations_url": "https://api.github.com/users/soghomon-b/orgs", "repos_url": "https://api.github.com/users/soghomon-b/repos", "events_url": "https://api.github.com/users/soghomon-b/events{/privacy}", "received_events_url": "https://api.github.com/users/soghomon-b/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
open
false
null
[]
null
[]
2025-10-02T16:46:56
2025-10-02T16:46:56
null
NONE
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41299", "html_url": "https://github.com/huggingface/transformers/pull/41299", "diff_url": "https://github.com/huggingface/transformers/pull/41299.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41299.patch", "merged_at": null }
# What does this PR do? <!-- Congratulations! You've made it this far! You're not quite done yet though. Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution. Then, please replace this with a description of the change and which issue is fixed (if applicable). Please also include relevant motivation and context. List any dependencies (if any) that are required for this change. Once you're done, someone will review your PR shortly (see the section "Who can review?" below to tag some potential reviewers). They may suggest changes to make the code even better. If no one reviewed your PR after a week has passed, don't hesitate to post a new comment @-mentioning the same persons---sometimes notifications get lost. --> <!-- Remove if not applicable --> closes #31561 ## Before submitting - [no ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [yes ] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request), Pull Request section? - [yes ] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case. closes #31561 - [ no] Did you make sure to update the documentation with your changes? Here are the [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation). There seems to be no documentation for TrainingArgument. I added a line in the training_args.py to explain the new argument. - [yes ] Did you write any new necessary tests? test_number_of_eval_samples_set and test_number_of_eval_samples_unset in tests/trainer/test_trainer.py ## Who can review? Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR. <!-- Your PR will be replied to more quickly if you can figure out the right person to tag with @ If you know how to use git blame, that is the easiest way, otherwise, here is a rough guide of **who to tag**. Please tag fewer than 3 people. Models: - text models: @ArthurZucker - vision models: @amyeroberts, @qubvel - speech models: @eustlb - graph models: @clefourrier Library: - flax: @gante and @Rocketknight1 - generate: @zucchini-nlp (visual-language models) or @gante (all others) - pipelines: @Rocketknight1 - tensorflow: @gante and @Rocketknight1 - tokenizers: @ArthurZucker - trainer: @muellerzr and @SunMarc - chat templates: @Rocketknight1 Integrations: - deepspeed: HF Trainer/Accelerate: @muellerzr - ray/raytune: @richardliaw, @amogkam - Big Model Inference: @SunMarc - quantization (bitsandbytes, autogpt): @SunMarc @MekkCyber Documentation: @stevhliu HF projects: - accelerate: [different repo](https://github.com/huggingface/accelerate) - datasets: [different repo](https://github.com/huggingface/datasets) - diffusers: [different repo](https://github.com/huggingface/diffusers) - rust tokenizers: [different repo](https://github.com/huggingface/tokenizers) Maintained examples (not research project or legacy): - Flax: @Rocketknight1 - PyTorch: See Models above and tag the person corresponding to the modality of the example. - TensorFlow: @Rocketknight1 -->
null
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41299/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41299/timeline
null
null
null
null
true
false
https://api.github.com/repos/huggingface/transformers/issues/41298
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41298/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41298/comments
https://api.github.com/repos/huggingface/transformers/issues/41298/events
https://github.com/huggingface/transformers/pull/41298
3,478,187,997
PR_kwDOCUB6oc6rzaae
41,298
fix resample in asr pipeline
{ "login": "yhzx233", "id": 16619108, "node_id": "MDQ6VXNlcjE2NjE5MTA4", "avatar_url": "https://avatars.githubusercontent.com/u/16619108?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yhzx233", "html_url": "https://github.com/yhzx233", "followers_url": "https://api.github.com/users/yhzx233/followers", "following_url": "https://api.github.com/users/yhzx233/following{/other_user}", "gists_url": "https://api.github.com/users/yhzx233/gists{/gist_id}", "starred_url": "https://api.github.com/users/yhzx233/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yhzx233/subscriptions", "organizations_url": "https://api.github.com/users/yhzx233/orgs", "repos_url": "https://api.github.com/users/yhzx233/repos", "events_url": "https://api.github.com/users/yhzx233/events{/privacy}", "received_events_url": "https://api.github.com/users/yhzx233/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-02T16:44:37
2025-10-06T17:31:52
2025-10-06T17:31:10
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41298", "html_url": "https://github.com/huggingface/transformers/pull/41298", "diff_url": "https://github.com/huggingface/transformers/pull/41298.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41298.patch", "merged_at": "2025-10-06T17:31:10" }
# What does this PR do? <!-- Congratulations! You've made it this far! You're not quite done yet though. Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution. Then, please replace this with a description of the change and which issue is fixed (if applicable). Please also include relevant motivation and context. List any dependencies (if any) that are required for this change. Once you're done, someone will review your PR shortly (see the section "Who can review?" below to tag some potential reviewers). They may suggest changes to make the code even better. If no one reviewed your PR after a week has passed, don't hesitate to post a new comment @-mentioning the same persons---sometimes notifications get lost. --> <!-- Remove if not applicable --> Fixes duplicated line in ASR pipeline that passed `in_sampling_rate` twice, causing `F.resample` to no-op. <!-- Your PR will be replied to more quickly if you can figure out the right person to tag with @ If you know how to use git blame, that is the easiest way, otherwise, here is a rough guide of **who to tag**. Please tag fewer than 3 people. Models: - text models: @ArthurZucker @Cyrilvallez - vision models: @yonigozlan @molbap - audio models: @eustlb @ebezzam @vasqu - multimodal models: @zucchini-nlp - graph models: @clefourrier Library: - generate: @zucchini-nlp (visual-language models) or @gante (all others) - continuous batching: @remi-or @ArthurZucker @McPatate - pipelines: @Rocketknight1 - tokenizers: @ArthurZucker and @itazap - trainer: @zach-huggingface @SunMarc - attention: @vasqu @ArthurZucker @CyrilVallez - model loading (from pretrained, etc): @CyrilVallez - distributed: @3outeille @ArthurZucker @S1ro1 - CIs: @ydshieh Integrations: - deepspeed: HF Trainer/Accelerate: @SunMarc @zach-huggingface - ray/raytune: @richardliaw, @amogkam - Big Model Inference: @SunMarc - quantization (bitsandbytes, autogpt): @SunMarc @MekkCyber - kernels: @MekkCyber @drbh - peft: @BenjaminBossan @githubnemo Devices/Backends: - AMD ROCm: @ivarflakstad - Intel XPU: @IlyasMoutawwakil - Ascend NPU: @ivarflakstad Documentation: @stevhliu Research projects are not maintained and should be taken as is. -->
{ "login": "eustlb", "id": 94853470, "node_id": "U_kgDOBadZXg", "avatar_url": "https://avatars.githubusercontent.com/u/94853470?v=4", "gravatar_id": "", "url": "https://api.github.com/users/eustlb", "html_url": "https://github.com/eustlb", "followers_url": "https://api.github.com/users/eustlb/followers", "following_url": "https://api.github.com/users/eustlb/following{/other_user}", "gists_url": "https://api.github.com/users/eustlb/gists{/gist_id}", "starred_url": "https://api.github.com/users/eustlb/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/eustlb/subscriptions", "organizations_url": "https://api.github.com/users/eustlb/orgs", "repos_url": "https://api.github.com/users/eustlb/repos", "events_url": "https://api.github.com/users/eustlb/events{/privacy}", "received_events_url": "https://api.github.com/users/eustlb/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41298/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41298/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41297
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41297/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41297/comments
https://api.github.com/repos/huggingface/transformers/issues/41297/events
https://github.com/huggingface/transformers/pull/41297
3,477,995,532
PR_kwDOCUB6oc6ryxQT
41,297
ENH: Add support for LoRA hotswapping
{ "login": "BenjaminBossan", "id": 6229650, "node_id": "MDQ6VXNlcjYyMjk2NTA=", "avatar_url": "https://avatars.githubusercontent.com/u/6229650?v=4", "gravatar_id": "", "url": "https://api.github.com/users/BenjaminBossan", "html_url": "https://github.com/BenjaminBossan", "followers_url": "https://api.github.com/users/BenjaminBossan/followers", "following_url": "https://api.github.com/users/BenjaminBossan/following{/other_user}", "gists_url": "https://api.github.com/users/BenjaminBossan/gists{/gist_id}", "starred_url": "https://api.github.com/users/BenjaminBossan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/BenjaminBossan/subscriptions", "organizations_url": "https://api.github.com/users/BenjaminBossan/orgs", "repos_url": "https://api.github.com/users/BenjaminBossan/repos", "events_url": "https://api.github.com/users/BenjaminBossan/events{/privacy}", "received_events_url": "https://api.github.com/users/BenjaminBossan/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
open
false
null
[]
null
[]
2025-10-02T15:38:39
2025-10-27T09:07:19
null
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41297", "html_url": "https://github.com/huggingface/transformers/pull/41297", "diff_url": "https://github.com/huggingface/transformers/pull/41297.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41297.patch", "merged_at": null }
# What does this PR do? LoRA hotswapping has been available in PEFT since 0.15.0. There is already a diffusers integration (https://github.com/huggingface/diffusers/pull/9453), but the transformers integration was still missing this feature. This PR remedies this. It sticks closely to the diffusers PR, both implementation-wise and API-wise. Hotswapping allows to swap different LoRA adapters in-place instead of loading multiple adapters and switching between them. Not only can this be advantageous to safe memory and potentially for quicker loading, the biggest advantage is that if the model is compiled, we can hotswap without triggering recompilation (loading a separate adapter would require recompilation). There are some caveats to using this feature, most notably that only LoRA is supported. This was fine for diffusers, as it only works with LoRA, but the transformers integration works with other PEFT methods too. However, LoRA should be by far the most common method, so this should be fine for now. This and other caveats have been documented. Note that testing is not super deep, there could be more edge cases being tested. However, as this is mainly about calling PEFT functionality, which is extensively tested in PEFT, I focused the tests mostly on the integration, with only a couple of tests for the functionality itself (namely the tests that call `_check_model_hotswap`). ## Before submitting - [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [x] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request), Pull Request section? - [ ] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case. - [x] Did you make sure to update the documentation with your changes? Here are the [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation). - [x] Did you write any new necessary tests?
null
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41297/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41297/timeline
null
null
null
null
true
false
https://api.github.com/repos/huggingface/transformers/issues/41296
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41296/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41296/comments
https://api.github.com/repos/huggingface/transformers/issues/41296/events
https://github.com/huggingface/transformers/issues/41296
3,477,896,164
I_kwDOCUB6oc7PTHvk
41,296
Parsing error with --lr-scheduler-kwargs: invalid dict value
{ "login": "stephankoe", "id": 14936555, "node_id": "MDQ6VXNlcjE0OTM2NTU1", "avatar_url": "https://avatars.githubusercontent.com/u/14936555?v=4", "gravatar_id": "", "url": "https://api.github.com/users/stephankoe", "html_url": "https://github.com/stephankoe", "followers_url": "https://api.github.com/users/stephankoe/followers", "following_url": "https://api.github.com/users/stephankoe/following{/other_user}", "gists_url": "https://api.github.com/users/stephankoe/gists{/gist_id}", "starred_url": "https://api.github.com/users/stephankoe/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/stephankoe/subscriptions", "organizations_url": "https://api.github.com/users/stephankoe/orgs", "repos_url": "https://api.github.com/users/stephankoe/repos", "events_url": "https://api.github.com/users/stephankoe/events{/privacy}", "received_events_url": "https://api.github.com/users/stephankoe/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 3817266200, "node_id": "MDU6TGFiZWwzODE3MjY2MjAw", "url": "https://api.github.com/repos/huggingface/transformers/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": null } ]
closed
false
null
[]
null
[]
2025-10-02T15:09:22
2025-10-14T14:07:28
2025-10-14T14:07:28
NONE
null
null
null
null
### System Info - `transformers` version: 4.57.0.dev0 - Platform: Linux-5.10.134-008.18.kangaroo.al8.x86_64-x86_64-with-glibc2.39 - Python version: 3.12.7+gc - Huggingface_hub version: 1.0.0.rc2 - Safetensors version: 0.5.3 - Accelerate version: 1.7.0 - Accelerate config: not found - DeepSpeed version: 0.16.9+ali - PyTorch version (accelerator?): 2.6.0+ali.7.post2.ppu1.5.2.cu126 (CUDA) - Using distributed or parallel set-up in script?: <fill in> - Using GPU in script?: <fill in> - GPU type: PPU-ZW810E ### Who can help? When using the `--lr-scheduler-kwargs` option with a dict argument, such as `'{"min_lr": 1e-06}'`, the parser reports the following error: ```text test.py: error: argument --lr_scheduler_kwargs/--lr-scheduler-kwargs: invalid dict value: '{"min_lr": 1e-06}' ``` It appears that this error was introduced in https://github.com/huggingface/transformers/commit/a61fc6a0b985548c681df89c15f8053dafe322bf (title: "Fix typing of train_args"). It works as expected when reversing the data type of `lr_scheduler_kwargs` back to `Optional[Union[dict[str, Any], str]]`. ### Information - [x] The official example scripts - [x] My own modified scripts ### Tasks - [ ] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...) - [x] My own task or dataset (give details below) ### Reproduction You can simply reproduce it with a short script, such as: ```python from transformers import TrainingArguments, HfArgumentParser parser = HfArgumentParser((TrainingArguments,)) training_args, = parser.parse_args_into_dataclasses() ``` and then run it with `python test.py --lr-scheduler-kwargs '{"min_lr": 1e-06}'` It will report the following error: ``` usage: test.py [-h] [--output_dir OUTPUT_DIR] [--overwrite_output_dir [OVERWRITE_OUTPUT_DIR]] [--do_train [DO_TRAIN]] [--do_eval [DO_EVAL]] [--do_predict [DO_PREDICT]] [--eval_strategy {no,steps,epoch}] [--prediction_loss_only [PREDICTION_LOSS_ONLY]] [--per_device_train_batch_size PER_DEVICE_TRAIN_BATCH_SIZE] [--per_device_eval_batch_size PER_DEVICE_EVAL_BATCH_SIZE] [--gradient_accumulation_steps GRADIENT_ACCUMULATION_STEPS] [--eval_accumulation_steps EVAL_ACCUMULATION_STEPS] [--eval_delay EVAL_DELAY] [--torch_empty_cache_steps TORCH_EMPTY_CACHE_STEPS] [--learning_rate LEARNING_RATE] [--weight_decay WEIGHT_DECAY] [--adam_beta1 ADAM_BETA1] [--adam_beta2 ADAM_BETA2] [--adam_epsilon ADAM_EPSILON] [--max_grad_norm MAX_GRAD_NORM] [--num_train_epochs NUM_TRAIN_EPOCHS] ... [--eval_use_gather_object [EVAL_USE_GATHER_OBJECT]] [--average_tokens_across_devices [AVERAGE_TOKENS_ACROSS_DEVICES]] [--no_average_tokens_across_devices] test.py: error: argument --lr_scheduler_kwargs/--lr-scheduler-kwargs: invalid dict value: '{"min_lr": 1e-06}' ``` ### Expected behavior It's expected that the parser parses the string `'{"min_lr": 1e-06}'` as a dictionary.
{ "login": "SunMarc", "id": 57196510, "node_id": "MDQ6VXNlcjU3MTk2NTEw", "avatar_url": "https://avatars.githubusercontent.com/u/57196510?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SunMarc", "html_url": "https://github.com/SunMarc", "followers_url": "https://api.github.com/users/SunMarc/followers", "following_url": "https://api.github.com/users/SunMarc/following{/other_user}", "gists_url": "https://api.github.com/users/SunMarc/gists{/gist_id}", "starred_url": "https://api.github.com/users/SunMarc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SunMarc/subscriptions", "organizations_url": "https://api.github.com/users/SunMarc/orgs", "repos_url": "https://api.github.com/users/SunMarc/repos", "events_url": "https://api.github.com/users/SunMarc/events{/privacy}", "received_events_url": "https://api.github.com/users/SunMarc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41296/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41296/timeline
null
completed
{ "total": 0, "completed": 0, "percent_completed": 0 }
{ "blocked_by": 0, "total_blocked_by": 0, "blocking": 0, "total_blocking": 0 }
false
true
https://api.github.com/repos/huggingface/transformers/issues/41295
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41295/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41295/comments
https://api.github.com/repos/huggingface/transformers/issues/41295/events
https://github.com/huggingface/transformers/pull/41295
3,477,887,757
PR_kwDOCUB6oc6ryZyx
41,295
AutoAWQ tests
{ "login": "MekkCyber", "id": 93391238, "node_id": "U_kgDOBZEJhg", "avatar_url": "https://avatars.githubusercontent.com/u/93391238?v=4", "gravatar_id": "", "url": "https://api.github.com/users/MekkCyber", "html_url": "https://github.com/MekkCyber", "followers_url": "https://api.github.com/users/MekkCyber/followers", "following_url": "https://api.github.com/users/MekkCyber/following{/other_user}", "gists_url": "https://api.github.com/users/MekkCyber/gists{/gist_id}", "starred_url": "https://api.github.com/users/MekkCyber/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MekkCyber/subscriptions", "organizations_url": "https://api.github.com/users/MekkCyber/orgs", "repos_url": "https://api.github.com/users/MekkCyber/repos", "events_url": "https://api.github.com/users/MekkCyber/events{/privacy}", "received_events_url": "https://api.github.com/users/MekkCyber/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-02T15:07:31
2025-10-03T13:17:12
2025-10-03T13:17:10
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41295", "html_url": "https://github.com/huggingface/transformers/pull/41295", "diff_url": "https://github.com/huggingface/transformers/pull/41295.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41295.patch", "merged_at": "2025-10-03T13:17:10" }
# What does this PR do? Fixes AutoAwq tests
{ "login": "SunMarc", "id": 57196510, "node_id": "MDQ6VXNlcjU3MTk2NTEw", "avatar_url": "https://avatars.githubusercontent.com/u/57196510?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SunMarc", "html_url": "https://github.com/SunMarc", "followers_url": "https://api.github.com/users/SunMarc/followers", "following_url": "https://api.github.com/users/SunMarc/following{/other_user}", "gists_url": "https://api.github.com/users/SunMarc/gists{/gist_id}", "starred_url": "https://api.github.com/users/SunMarc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SunMarc/subscriptions", "organizations_url": "https://api.github.com/users/SunMarc/orgs", "repos_url": "https://api.github.com/users/SunMarc/repos", "events_url": "https://api.github.com/users/SunMarc/events{/privacy}", "received_events_url": "https://api.github.com/users/SunMarc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41295/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41295/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41294
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41294/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41294/comments
https://api.github.com/repos/huggingface/transformers/issues/41294/events
https://github.com/huggingface/transformers/pull/41294
3,477,868,775
PR_kwDOCUB6oc6ryVoD
41,294
[v5] Remove deprecated `use_auth_token`
{ "login": "cyyever", "id": 17618148, "node_id": "MDQ6VXNlcjE3NjE4MTQ4", "avatar_url": "https://avatars.githubusercontent.com/u/17618148?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cyyever", "html_url": "https://github.com/cyyever", "followers_url": "https://api.github.com/users/cyyever/followers", "following_url": "https://api.github.com/users/cyyever/following{/other_user}", "gists_url": "https://api.github.com/users/cyyever/gists{/gist_id}", "starred_url": "https://api.github.com/users/cyyever/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cyyever/subscriptions", "organizations_url": "https://api.github.com/users/cyyever/orgs", "repos_url": "https://api.github.com/users/cyyever/repos", "events_url": "https://api.github.com/users/cyyever/events{/privacy}", "received_events_url": "https://api.github.com/users/cyyever/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-02T15:02:45
2025-10-17T10:19:27
2025-10-17T10:19:23
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41294", "html_url": "https://github.com/huggingface/transformers/pull/41294", "diff_url": "https://github.com/huggingface/transformers/pull/41294.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41294.patch", "merged_at": null }
# What does this PR do? Remove `use_auth_token` from code and docs.
{ "login": "cyyever", "id": 17618148, "node_id": "MDQ6VXNlcjE3NjE4MTQ4", "avatar_url": "https://avatars.githubusercontent.com/u/17618148?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cyyever", "html_url": "https://github.com/cyyever", "followers_url": "https://api.github.com/users/cyyever/followers", "following_url": "https://api.github.com/users/cyyever/following{/other_user}", "gists_url": "https://api.github.com/users/cyyever/gists{/gist_id}", "starred_url": "https://api.github.com/users/cyyever/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cyyever/subscriptions", "organizations_url": "https://api.github.com/users/cyyever/orgs", "repos_url": "https://api.github.com/users/cyyever/repos", "events_url": "https://api.github.com/users/cyyever/events{/privacy}", "received_events_url": "https://api.github.com/users/cyyever/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41294/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41294/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41293
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41293/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41293/comments
https://api.github.com/repos/huggingface/transformers/issues/41293/events
https://github.com/huggingface/transformers/pull/41293
3,477,822,877
PR_kwDOCUB6oc6ryLpq
41,293
Tiny Cleanup - Removed duplicate class field definition's
{ "login": "Sai-Suraj-27", "id": 87087741, "node_id": "MDQ6VXNlcjg3MDg3NzQx", "avatar_url": "https://avatars.githubusercontent.com/u/87087741?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Sai-Suraj-27", "html_url": "https://github.com/Sai-Suraj-27", "followers_url": "https://api.github.com/users/Sai-Suraj-27/followers", "following_url": "https://api.github.com/users/Sai-Suraj-27/following{/other_user}", "gists_url": "https://api.github.com/users/Sai-Suraj-27/gists{/gist_id}", "starred_url": "https://api.github.com/users/Sai-Suraj-27/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Sai-Suraj-27/subscriptions", "organizations_url": "https://api.github.com/users/Sai-Suraj-27/orgs", "repos_url": "https://api.github.com/users/Sai-Suraj-27/repos", "events_url": "https://api.github.com/users/Sai-Suraj-27/events{/privacy}", "received_events_url": "https://api.github.com/users/Sai-Suraj-27/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-02T14:49:33
2025-10-08T08:49:34
2025-10-08T08:49:34
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41293", "html_url": "https://github.com/huggingface/transformers/pull/41293", "diff_url": "https://github.com/huggingface/transformers/pull/41293.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41293.patch", "merged_at": "2025-10-08T08:49:34" }
# What does this PR do? Tiny cleanup. Used [Ruff-PIE794](https://docs.astral.sh/ruff/rules/duplicate-class-field-definition/). Will be happy to add the rule to [existing rules](https://github.com/huggingface/transformers/blob/e4930d6bde027ed21fd3dd91dbbfdc95e0221dd4/pyproject.toml#L36) ## Before submitting - [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [x] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request), Pull Request section? - [ ] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case. - [ ] Did you make sure to update the documentation with your changes? Here are the [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation). - [ ] Did you write any new necessary tests? ## Who can review? @ydshieh @Rocketknight1
{ "login": "Cyrilvallez", "id": 71554963, "node_id": "MDQ6VXNlcjcxNTU0OTYz", "avatar_url": "https://avatars.githubusercontent.com/u/71554963?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Cyrilvallez", "html_url": "https://github.com/Cyrilvallez", "followers_url": "https://api.github.com/users/Cyrilvallez/followers", "following_url": "https://api.github.com/users/Cyrilvallez/following{/other_user}", "gists_url": "https://api.github.com/users/Cyrilvallez/gists{/gist_id}", "starred_url": "https://api.github.com/users/Cyrilvallez/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Cyrilvallez/subscriptions", "organizations_url": "https://api.github.com/users/Cyrilvallez/orgs", "repos_url": "https://api.github.com/users/Cyrilvallez/repos", "events_url": "https://api.github.com/users/Cyrilvallez/events{/privacy}", "received_events_url": "https://api.github.com/users/Cyrilvallez/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41293/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41293/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41292
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41292/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41292/comments
https://api.github.com/repos/huggingface/transformers/issues/41292/events
https://github.com/huggingface/transformers/pull/41292
3,477,779,032
PR_kwDOCUB6oc6ryCM9
41,292
Fix mxfp4 dequantization
{ "login": "Cyrilvallez", "id": 71554963, "node_id": "MDQ6VXNlcjcxNTU0OTYz", "avatar_url": "https://avatars.githubusercontent.com/u/71554963?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Cyrilvallez", "html_url": "https://github.com/Cyrilvallez", "followers_url": "https://api.github.com/users/Cyrilvallez/followers", "following_url": "https://api.github.com/users/Cyrilvallez/following{/other_user}", "gists_url": "https://api.github.com/users/Cyrilvallez/gists{/gist_id}", "starred_url": "https://api.github.com/users/Cyrilvallez/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Cyrilvallez/subscriptions", "organizations_url": "https://api.github.com/users/Cyrilvallez/orgs", "repos_url": "https://api.github.com/users/Cyrilvallez/repos", "events_url": "https://api.github.com/users/Cyrilvallez/events{/privacy}", "received_events_url": "https://api.github.com/users/Cyrilvallez/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-02T14:36:29
2025-10-03T12:16:29
2025-10-02T14:47:42
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41292", "html_url": "https://github.com/huggingface/transformers/pull/41292", "diff_url": "https://github.com/huggingface/transformers/pull/41292.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41292.patch", "merged_at": "2025-10-02T14:47:42" }
# What does this PR do? https://github.com/huggingface/transformers/pull/41222 changed the signature of a caller in TP without updating the function calls, so `dequantization` is currently broken. This fixes it.
{ "login": "Cyrilvallez", "id": 71554963, "node_id": "MDQ6VXNlcjcxNTU0OTYz", "avatar_url": "https://avatars.githubusercontent.com/u/71554963?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Cyrilvallez", "html_url": "https://github.com/Cyrilvallez", "followers_url": "https://api.github.com/users/Cyrilvallez/followers", "following_url": "https://api.github.com/users/Cyrilvallez/following{/other_user}", "gists_url": "https://api.github.com/users/Cyrilvallez/gists{/gist_id}", "starred_url": "https://api.github.com/users/Cyrilvallez/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Cyrilvallez/subscriptions", "organizations_url": "https://api.github.com/users/Cyrilvallez/orgs", "repos_url": "https://api.github.com/users/Cyrilvallez/repos", "events_url": "https://api.github.com/users/Cyrilvallez/events{/privacy}", "received_events_url": "https://api.github.com/users/Cyrilvallez/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41292/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41292/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41291
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41291/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41291/comments
https://api.github.com/repos/huggingface/transformers/issues/41291/events
https://github.com/huggingface/transformers/pull/41291
3,477,720,923
PR_kwDOCUB6oc6rx1wr
41,291
Add-Deimv2
{ "login": "kekwlboy12469", "id": 182772448, "node_id": "U_kgDOCuTi4A", "avatar_url": "https://avatars.githubusercontent.com/u/182772448?v=4", "gravatar_id": "", "url": "https://api.github.com/users/kekwlboy12469", "html_url": "https://github.com/kekwlboy12469", "followers_url": "https://api.github.com/users/kekwlboy12469/followers", "following_url": "https://api.github.com/users/kekwlboy12469/following{/other_user}", "gists_url": "https://api.github.com/users/kekwlboy12469/gists{/gist_id}", "starred_url": "https://api.github.com/users/kekwlboy12469/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/kekwlboy12469/subscriptions", "organizations_url": "https://api.github.com/users/kekwlboy12469/orgs", "repos_url": "https://api.github.com/users/kekwlboy12469/repos", "events_url": "https://api.github.com/users/kekwlboy12469/events{/privacy}", "received_events_url": "https://api.github.com/users/kekwlboy12469/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
open
false
null
[]
null
[]
2025-10-02T14:18:43
2025-10-03T12:04:07
null
NONE
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41291", "html_url": "https://github.com/huggingface/transformers/pull/41291", "diff_url": "https://github.com/huggingface/transformers/pull/41291.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41291.patch", "merged_at": null }
# What does this PR do? This PR introduces an initial DEIMv2 object detection integration that uses the AutoBackbone API to reuse DINOv3/ViT backbones without duplicating backbone code. It adds configuration, modeling, image processing, minimal tests, and documentation, paving the way for full STA/decoder and Dense O2O parity in follow-up <!-- Congratulations! You've made it this far! You're not quite done yet though. Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution. Then, please replace this with a description of the change and which issue is fixed (if applicable). Please also include relevant motivation and context. List any dependencies (if any) that are required for this change. Once you're done, someone will review your PR shortly (see the section "Who can review?" below to tag some potential reviewers). They may suggest changes to make the code even better. If no one reviewed your PR after a week has passed, don't hesitate to post a new comment @-mentioning the same persons---sometimes notifications get lost. --> <!-- Remove if not applicable --> Fixes #41211 ## Before submitting - [x] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [x] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request), Pull Request section? - [x] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case. - [x] Did you make sure to update the documentation with your changes? Here are the [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation). - [x] Did you write any new necessary tests? ## Who can review? Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR. <!-- Your PR will be replied to more quickly if you can figure out the right person to tag with @ If you know how to use git blame, that is the easiest way, otherwise, here is a rough guide of **who to tag**. Please tag fewer than 3 people. Models: - text models: @ArthurZucker @Cyrilvallez - vision models: @yonigozlan @molbap - audio models: @eustlb @ebezzam @vasqu - multimodal models: @zucchini-nlp - graph models: @clefourrier Library: - generate: @zucchini-nlp (visual-language models) or @gante (all others) - continuous batching: @remi-or @ArthurZucker @McPatate - pipelines: @Rocketknight1 - tokenizers: @ArthurZucker and @itazap - trainer: @zach-huggingface @SunMarc - attention: @vasqu @ArthurZucker @CyrilVallez - model loading (from pretrained, etc): @CyrilVallez - distributed: @3outeille @ArthurZucker @S1ro1 - CIs: @ydshieh Integrations: - deepspeed: HF Trainer/Accelerate: @SunMarc @zach-huggingface - ray/raytune: @richardliaw, @amogkam - Big Model Inference: @SunMarc - quantization (bitsandbytes, autogpt): @SunMarc @MekkCyber - kernels: @MekkCyber @drbh - peft: @BenjaminBossan @githubnemo Devices/Backends: - AMD ROCm: @ivarflakstad - Intel XPU: @IlyasMoutawwakil - Ascend NPU: @ivarflakstad Documentation: @stevhliu Research projects are not maintained and should be taken as is. -->
null
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41291/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41291/timeline
null
null
null
null
true
false
https://api.github.com/repos/huggingface/transformers/issues/41290
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41290/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41290/comments
https://api.github.com/repos/huggingface/transformers/issues/41290/events
https://github.com/huggingface/transformers/pull/41290
3,477,707,384
PR_kwDOCUB6oc6rxywC
41,290
Build doc in 2 jobs: `en` and `other languages`
{ "login": "ydshieh", "id": 2521628, "node_id": "MDQ6VXNlcjI1MjE2Mjg=", "avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ydshieh", "html_url": "https://github.com/ydshieh", "followers_url": "https://api.github.com/users/ydshieh/followers", "following_url": "https://api.github.com/users/ydshieh/following{/other_user}", "gists_url": "https://api.github.com/users/ydshieh/gists{/gist_id}", "starred_url": "https://api.github.com/users/ydshieh/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ydshieh/subscriptions", "organizations_url": "https://api.github.com/users/ydshieh/orgs", "repos_url": "https://api.github.com/users/ydshieh/repos", "events_url": "https://api.github.com/users/ydshieh/events{/privacy}", "received_events_url": "https://api.github.com/users/ydshieh/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-02T14:15:26
2025-10-02T14:54:10
2025-10-02T14:33:57
COLLABORATOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41290", "html_url": "https://github.com/huggingface/transformers/pull/41290", "diff_url": "https://github.com/huggingface/transformers/pull/41290.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41290.patch", "merged_at": "2025-10-02T14:33:57" }
# What does this PR do? See https://github.com/huggingface/transformers/pull/41286#issuecomment-3361383120
{ "login": "ydshieh", "id": 2521628, "node_id": "MDQ6VXNlcjI1MjE2Mjg=", "avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ydshieh", "html_url": "https://github.com/ydshieh", "followers_url": "https://api.github.com/users/ydshieh/followers", "following_url": "https://api.github.com/users/ydshieh/following{/other_user}", "gists_url": "https://api.github.com/users/ydshieh/gists{/gist_id}", "starred_url": "https://api.github.com/users/ydshieh/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ydshieh/subscriptions", "organizations_url": "https://api.github.com/users/ydshieh/orgs", "repos_url": "https://api.github.com/users/ydshieh/repos", "events_url": "https://api.github.com/users/ydshieh/events{/privacy}", "received_events_url": "https://api.github.com/users/ydshieh/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41290/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41290/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41289
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41289/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41289/comments
https://api.github.com/repos/huggingface/transformers/issues/41289/events
https://github.com/huggingface/transformers/pull/41289
3,477,678,870
PR_kwDOCUB6oc6rxsbS
41,289
Add modular detector
{ "login": "molbap", "id": 39954772, "node_id": "MDQ6VXNlcjM5OTU0Nzcy", "avatar_url": "https://avatars.githubusercontent.com/u/39954772?v=4", "gravatar_id": "", "url": "https://api.github.com/users/molbap", "html_url": "https://github.com/molbap", "followers_url": "https://api.github.com/users/molbap/followers", "following_url": "https://api.github.com/users/molbap/following{/other_user}", "gists_url": "https://api.github.com/users/molbap/gists{/gist_id}", "starred_url": "https://api.github.com/users/molbap/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/molbap/subscriptions", "organizations_url": "https://api.github.com/users/molbap/orgs", "repos_url": "https://api.github.com/users/molbap/repos", "events_url": "https://api.github.com/users/molbap/events{/privacy}", "received_events_url": "https://api.github.com/users/molbap/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-02T14:08:37
2025-10-06T17:12:43
2025-10-03T12:11:10
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41289", "html_url": "https://github.com/huggingface/transformers/pull/41289", "diff_url": "https://github.com/huggingface/transformers/pull/41289.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41289.patch", "merged_at": "2025-10-03T12:11:10" }
# What does this PR do? Adds a new util to parse a new `modeling_*` file, whether or not it is from `transformers`, and lists the closest possible matches from existing models in the library using embeddings from Qwen3. # Why? Because most models should be able to be defined as `modular`s from each other. It's not exactly the case yet, see [this space](https://huggingface.co/spaces/Molbap/transformers-modular-refactor) to see the existing links between models and the ones yet to be included. <img width="1888" height="838" alt="image" src="https://github.com/user-attachments/assets/3e4aa954-6a9c-4818-a6a3-fb3bcef7f81a" /> Also, there are more than 400 models. We cannot remember where is what. Hopefully this will accelerate development/porting of new models into a `modular` format and the modernization of older, non-modular models. # How do I use it? If you're adding a new model to `transformers` and have already some form of runnable `modeling` file, the only action is (with a sufficiently powerful machine) to run (here from https://github.com/huggingface/transformers/pull/39534 that adds beit3 model) from the `transformers` repository: ```bash python utils/modular_model_detector.py --modeling-file /path/to/your/modeling_file.py ``` will get you the following (excerpt): ```bash stuff.py::Beit3ImageTextMatchingOutput: embedding: blip_2::Blip2ImageTextMatchingModelOutput (0.9994) chinese_clip::ChineseCLIPOutput (0.9818) metaclip_2::MetaClip2Output (0.9817) owlv2::Owlv2Output (0.9817) aimv2::Aimv2Output (0.9817) jaccard: owlv2::Owlv2Output (0.9667) metaclip_2::MetaClip2Output (0.9667) altclip::AltCLIPOutput (0.9667) owlvit::OwlViTOutput (0.9667) blip::BlipOutput (0.9667) intersection: metaclip_2::MetaClip2Output owlv2::Owlv2Output stuff.py::Beit3MLP: embedding: efficientloftr::EfficientLoFTRMLP (0.9717) seggpt::SegGptMlp (0.9650) mgp_str::MgpstrMlp (0.9645) vitpose_backbone::VitPoseBackboneMLP (0.9640) granitemoehybrid::GraniteMoeHybridMLP (0.9634) jaccard: chinese_clip::ChineseCLIPTextSelfOutput (0.5294) convbert::ConvBertSelfOutput (0.5294) bert::BertSelfOutput (0.5294) roformer::RoFormerSelfOutput (0.5294) layoutlmv3::LayoutLMv3SelfOutput (0.5294) intersection: stuff.py::Beit3FeedForwardNetwork: embedding: prophetnet::ProphetNetFeedForward (0.9764) dab_detr::DabDetrDecoderLayerFFN (0.9729) kosmos2::Kosmos2TextFFN (0.9698) kosmos2_5::Kosmos2_5TextFFN (0.9698) parakeet::ParakeetEncoderFeedForward (0.9677) jaccard: groupvit::GroupViTMLP (0.4898) convbert::ConvBertOutput (0.4600) chinese_clip::ChineseCLIPTextOutput (0.4565) bert::BertOutput (0.4565) roformer::RoFormerOutput (0.4565) intersection: .... ``` From experience: Jaccard-based indices are lower in value because they punish more harshly token differences but are still useful. Embeddings scores calibration is a bit effy - a score below 0.90 is definitely on the lower end. The intersection exists to guide the user a bit more. In any case, the command above will take care of downloading the precomputed indices from [the corresponding hub dataset](https://huggingface.co/datasets/hf-internal-testing/transformers_code_embeddings) - we will need to setup a scheduled job to do it from time to time (like weekly?). Should you want to recompute the index, simply run ```bash python utils/modular_model_detector.py --build ``` Where you can change the model ID to try other models for instance. HF members can also push to the dataset, should you find better embeddings/matches. This is a relatively minimal API, I didn't want to over-engineer it. Compared to the space above where I link models together, the main difference is that here I'm linking `functions`, ` methods` and `Classes` together rather than whole models.
{ "login": "molbap", "id": 39954772, "node_id": "MDQ6VXNlcjM5OTU0Nzcy", "avatar_url": "https://avatars.githubusercontent.com/u/39954772?v=4", "gravatar_id": "", "url": "https://api.github.com/users/molbap", "html_url": "https://github.com/molbap", "followers_url": "https://api.github.com/users/molbap/followers", "following_url": "https://api.github.com/users/molbap/following{/other_user}", "gists_url": "https://api.github.com/users/molbap/gists{/gist_id}", "starred_url": "https://api.github.com/users/molbap/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/molbap/subscriptions", "organizations_url": "https://api.github.com/users/molbap/orgs", "repos_url": "https://api.github.com/users/molbap/repos", "events_url": "https://api.github.com/users/molbap/events{/privacy}", "received_events_url": "https://api.github.com/users/molbap/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41289/reactions", "total_count": 8, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 5, "rocket": 3, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41289/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41288
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41288/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41288/comments
https://api.github.com/repos/huggingface/transformers/issues/41288/events
https://github.com/huggingface/transformers/pull/41288
3,477,474,094
PR_kwDOCUB6oc6rw_nd
41,288
Diabled FA on AMD docker
{ "login": "remi-or", "id": 83456801, "node_id": "MDQ6VXNlcjgzNDU2ODAx", "avatar_url": "https://avatars.githubusercontent.com/u/83456801?v=4", "gravatar_id": "", "url": "https://api.github.com/users/remi-or", "html_url": "https://github.com/remi-or", "followers_url": "https://api.github.com/users/remi-or/followers", "following_url": "https://api.github.com/users/remi-or/following{/other_user}", "gists_url": "https://api.github.com/users/remi-or/gists{/gist_id}", "starred_url": "https://api.github.com/users/remi-or/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/remi-or/subscriptions", "organizations_url": "https://api.github.com/users/remi-or/orgs", "repos_url": "https://api.github.com/users/remi-or/repos", "events_url": "https://api.github.com/users/remi-or/events{/privacy}", "received_events_url": "https://api.github.com/users/remi-or/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-02T13:10:13
2025-10-13T09:58:56
2025-10-13T09:58:55
COLLABORATOR
null
null
true
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41288", "html_url": "https://github.com/huggingface/transformers/pull/41288", "diff_url": "https://github.com/huggingface/transformers/pull/41288.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41288.patch", "merged_at": null }
In a recent PR #41069 we enabled `flash-attention` in the AMD docker by adding a step to build it from source. But it turns out this is taking too long to be done on our CI runners, so this PR disables it until we find a faster installation process.
{ "login": "remi-or", "id": 83456801, "node_id": "MDQ6VXNlcjgzNDU2ODAx", "avatar_url": "https://avatars.githubusercontent.com/u/83456801?v=4", "gravatar_id": "", "url": "https://api.github.com/users/remi-or", "html_url": "https://github.com/remi-or", "followers_url": "https://api.github.com/users/remi-or/followers", "following_url": "https://api.github.com/users/remi-or/following{/other_user}", "gists_url": "https://api.github.com/users/remi-or/gists{/gist_id}", "starred_url": "https://api.github.com/users/remi-or/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/remi-or/subscriptions", "organizations_url": "https://api.github.com/users/remi-or/orgs", "repos_url": "https://api.github.com/users/remi-or/repos", "events_url": "https://api.github.com/users/remi-or/events{/privacy}", "received_events_url": "https://api.github.com/users/remi-or/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41288/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41288/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41287
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41287/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41287/comments
https://api.github.com/repos/huggingface/transformers/issues/41287/events
https://github.com/huggingface/transformers/pull/41287
3,477,467,129
PR_kwDOCUB6oc6rw-Gr
41,287
[v5] remove load_in_4bit and load_in_8bit
{ "login": "SunMarc", "id": 57196510, "node_id": "MDQ6VXNlcjU3MTk2NTEw", "avatar_url": "https://avatars.githubusercontent.com/u/57196510?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SunMarc", "html_url": "https://github.com/SunMarc", "followers_url": "https://api.github.com/users/SunMarc/followers", "following_url": "https://api.github.com/users/SunMarc/following{/other_user}", "gists_url": "https://api.github.com/users/SunMarc/gists{/gist_id}", "starred_url": "https://api.github.com/users/SunMarc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SunMarc/subscriptions", "organizations_url": "https://api.github.com/users/SunMarc/orgs", "repos_url": "https://api.github.com/users/SunMarc/repos", "events_url": "https://api.github.com/users/SunMarc/events{/privacy}", "received_events_url": "https://api.github.com/users/SunMarc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 9105758243, "node_id": "LA_kwDOCUB6oc8AAAACHr7YIw", "url": "https://api.github.com/repos/huggingface/transformers/labels/for_v5?", "name": "for_v5?", "color": "35BC94", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2025-10-02T13:08:08
2025-10-09T14:38:38
2025-10-09T14:34:04
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41287", "html_url": "https://github.com/huggingface/transformers/pull/41287", "diff_url": "https://github.com/huggingface/transformers/pull/41287.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41287.patch", "merged_at": "2025-10-09T14:34:04" }
# What does this PR do? This PR removes `load_in_4bit` and `load_in_8bit` deprecated arguments for v5. This is something that I didn't want to do in a minor release as this might be breaking for a lot of users.
{ "login": "SunMarc", "id": 57196510, "node_id": "MDQ6VXNlcjU3MTk2NTEw", "avatar_url": "https://avatars.githubusercontent.com/u/57196510?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SunMarc", "html_url": "https://github.com/SunMarc", "followers_url": "https://api.github.com/users/SunMarc/followers", "following_url": "https://api.github.com/users/SunMarc/following{/other_user}", "gists_url": "https://api.github.com/users/SunMarc/gists{/gist_id}", "starred_url": "https://api.github.com/users/SunMarc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SunMarc/subscriptions", "organizations_url": "https://api.github.com/users/SunMarc/orgs", "repos_url": "https://api.github.com/users/SunMarc/repos", "events_url": "https://api.github.com/users/SunMarc/events{/privacy}", "received_events_url": "https://api.github.com/users/SunMarc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41287/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41287/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41286
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41286/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41286/comments
https://api.github.com/repos/huggingface/transformers/issues/41286/events
https://github.com/huggingface/transformers/pull/41286
3,477,409,259
PR_kwDOCUB6oc6rwxhk
41,286
[docs] remove references to recently deleted classes in non-`en` docs (onnx, feature processors)
{ "login": "gante", "id": 12240844, "node_id": "MDQ6VXNlcjEyMjQwODQ0", "avatar_url": "https://avatars.githubusercontent.com/u/12240844?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gante", "html_url": "https://github.com/gante", "followers_url": "https://api.github.com/users/gante/followers", "following_url": "https://api.github.com/users/gante/following{/other_user}", "gists_url": "https://api.github.com/users/gante/gists{/gist_id}", "starred_url": "https://api.github.com/users/gante/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gante/subscriptions", "organizations_url": "https://api.github.com/users/gante/orgs", "repos_url": "https://api.github.com/users/gante/repos", "events_url": "https://api.github.com/users/gante/events{/privacy}", "received_events_url": "https://api.github.com/users/gante/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-02T12:50:22
2025-10-02T14:07:21
2025-10-02T12:59:28
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41286", "html_url": "https://github.com/huggingface/transformers/pull/41286", "diff_url": "https://github.com/huggingface/transformers/pull/41286.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41286.patch", "merged_at": "2025-10-02T12:59:28" }
# What does this PR do? See title. These are causing our doc builder to crash. _______________________ how to locally test the doc builder: 1. clone and install the doc builder 2. run `doc-builder build transformers docs/source/ja/ --language ja --clean` (replace `ja` by the target language of your choice)
{ "login": "gante", "id": 12240844, "node_id": "MDQ6VXNlcjEyMjQwODQ0", "avatar_url": "https://avatars.githubusercontent.com/u/12240844?v=4", "gravatar_id": "", "url": "https://api.github.com/users/gante", "html_url": "https://github.com/gante", "followers_url": "https://api.github.com/users/gante/followers", "following_url": "https://api.github.com/users/gante/following{/other_user}", "gists_url": "https://api.github.com/users/gante/gists{/gist_id}", "starred_url": "https://api.github.com/users/gante/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/gante/subscriptions", "organizations_url": "https://api.github.com/users/gante/orgs", "repos_url": "https://api.github.com/users/gante/repos", "events_url": "https://api.github.com/users/gante/events{/privacy}", "received_events_url": "https://api.github.com/users/gante/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41286/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41286/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41285
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41285/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41285/comments
https://api.github.com/repos/huggingface/transformers/issues/41285/events
https://github.com/huggingface/transformers/pull/41285
3,477,378,555
PR_kwDOCUB6oc6rwq0B
41,285
feat: use `aws-highcpu-32-priv` for amd docker img build
{ "login": "McPatate", "id": 9112841, "node_id": "MDQ6VXNlcjkxMTI4NDE=", "avatar_url": "https://avatars.githubusercontent.com/u/9112841?v=4", "gravatar_id": "", "url": "https://api.github.com/users/McPatate", "html_url": "https://github.com/McPatate", "followers_url": "https://api.github.com/users/McPatate/followers", "following_url": "https://api.github.com/users/McPatate/following{/other_user}", "gists_url": "https://api.github.com/users/McPatate/gists{/gist_id}", "starred_url": "https://api.github.com/users/McPatate/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/McPatate/subscriptions", "organizations_url": "https://api.github.com/users/McPatate/orgs", "repos_url": "https://api.github.com/users/McPatate/repos", "events_url": "https://api.github.com/users/McPatate/events{/privacy}", "received_events_url": "https://api.github.com/users/McPatate/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-02T12:41:36
2025-10-02T12:53:50
2025-10-02T12:53:15
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41285", "html_url": "https://github.com/huggingface/transformers/pull/41285", "diff_url": "https://github.com/huggingface/transformers/pull/41285.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41285.patch", "merged_at": "2025-10-02T12:53:15" }
change the runner group to something more powerful, amd docker image build is very greedy in resources
{ "login": "McPatate", "id": 9112841, "node_id": "MDQ6VXNlcjkxMTI4NDE=", "avatar_url": "https://avatars.githubusercontent.com/u/9112841?v=4", "gravatar_id": "", "url": "https://api.github.com/users/McPatate", "html_url": "https://github.com/McPatate", "followers_url": "https://api.github.com/users/McPatate/followers", "following_url": "https://api.github.com/users/McPatate/following{/other_user}", "gists_url": "https://api.github.com/users/McPatate/gists{/gist_id}", "starred_url": "https://api.github.com/users/McPatate/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/McPatate/subscriptions", "organizations_url": "https://api.github.com/users/McPatate/orgs", "repos_url": "https://api.github.com/users/McPatate/repos", "events_url": "https://api.github.com/users/McPatate/events{/privacy}", "received_events_url": "https://api.github.com/users/McPatate/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41285/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41285/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41284
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41284/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41284/comments
https://api.github.com/repos/huggingface/transformers/issues/41284/events
https://github.com/huggingface/transformers/pull/41284
3,477,270,947
PR_kwDOCUB6oc6rwTLf
41,284
Use canonical get_size_with_aspect_ratio (with max_size) from transformers.image_transforms to fix #37939
{ "login": "sonianuj287", "id": 41353742, "node_id": "MDQ6VXNlcjQxMzUzNzQy", "avatar_url": "https://avatars.githubusercontent.com/u/41353742?v=4", "gravatar_id": "", "url": "https://api.github.com/users/sonianuj287", "html_url": "https://github.com/sonianuj287", "followers_url": "https://api.github.com/users/sonianuj287/followers", "following_url": "https://api.github.com/users/sonianuj287/following{/other_user}", "gists_url": "https://api.github.com/users/sonianuj287/gists{/gist_id}", "starred_url": "https://api.github.com/users/sonianuj287/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/sonianuj287/subscriptions", "organizations_url": "https://api.github.com/users/sonianuj287/orgs", "repos_url": "https://api.github.com/users/sonianuj287/repos", "events_url": "https://api.github.com/users/sonianuj287/events{/privacy}", "received_events_url": "https://api.github.com/users/sonianuj287/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-02T12:06:39
2025-10-06T14:15:56
2025-10-06T14:15:56
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41284", "html_url": "https://github.com/huggingface/transformers/pull/41284", "diff_url": "https://github.com/huggingface/transformers/pull/41284.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41284.patch", "merged_at": "2025-10-06T14:15:56" }
Removed max_size parameter from ConditionalDetrImageProcessor to simplify image resizing logic and fix #37939. Used canonical get_size_with_aspect_ratio (with max_size) from transformers.image_transforms Tested with pytest suite and all tests are passed. Happy to be guided further for improvement. Thanks
{ "login": "yonigozlan", "id": 74535834, "node_id": "MDQ6VXNlcjc0NTM1ODM0", "avatar_url": "https://avatars.githubusercontent.com/u/74535834?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yonigozlan", "html_url": "https://github.com/yonigozlan", "followers_url": "https://api.github.com/users/yonigozlan/followers", "following_url": "https://api.github.com/users/yonigozlan/following{/other_user}", "gists_url": "https://api.github.com/users/yonigozlan/gists{/gist_id}", "starred_url": "https://api.github.com/users/yonigozlan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yonigozlan/subscriptions", "organizations_url": "https://api.github.com/users/yonigozlan/orgs", "repos_url": "https://api.github.com/users/yonigozlan/repos", "events_url": "https://api.github.com/users/yonigozlan/events{/privacy}", "received_events_url": "https://api.github.com/users/yonigozlan/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41284/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41284/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41283
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41283/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41283/comments
https://api.github.com/repos/huggingface/transformers/issues/41283/events
https://github.com/huggingface/transformers/pull/41283
3,477,266,247
PR_kwDOCUB6oc6rwSJS
41,283
[v5] Bump min version of bitsandbytes to 0.46.1
{ "login": "SunMarc", "id": 57196510, "node_id": "MDQ6VXNlcjU3MTk2NTEw", "avatar_url": "https://avatars.githubusercontent.com/u/57196510?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SunMarc", "html_url": "https://github.com/SunMarc", "followers_url": "https://api.github.com/users/SunMarc/followers", "following_url": "https://api.github.com/users/SunMarc/following{/other_user}", "gists_url": "https://api.github.com/users/SunMarc/gists{/gist_id}", "starred_url": "https://api.github.com/users/SunMarc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SunMarc/subscriptions", "organizations_url": "https://api.github.com/users/SunMarc/orgs", "repos_url": "https://api.github.com/users/SunMarc/repos", "events_url": "https://api.github.com/users/SunMarc/events{/privacy}", "received_events_url": "https://api.github.com/users/SunMarc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-02T12:05:06
2025-10-08T10:04:29
2025-10-08T10:04:27
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41283", "html_url": "https://github.com/huggingface/transformers/pull/41283", "diff_url": "https://github.com/huggingface/transformers/pull/41283.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41283.patch", "merged_at": "2025-10-08T10:04:27" }
# What does this PR do? This PR cleans bitsandbytes integration as we bump the min version. With the multi-backend integrated in bitsanbytes for a few versions, I think we can safely bump to 0.46.1 as vllm did. I also removed a bunch as deprecated code
{ "login": "SunMarc", "id": 57196510, "node_id": "MDQ6VXNlcjU3MTk2NTEw", "avatar_url": "https://avatars.githubusercontent.com/u/57196510?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SunMarc", "html_url": "https://github.com/SunMarc", "followers_url": "https://api.github.com/users/SunMarc/followers", "following_url": "https://api.github.com/users/SunMarc/following{/other_user}", "gists_url": "https://api.github.com/users/SunMarc/gists{/gist_id}", "starred_url": "https://api.github.com/users/SunMarc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SunMarc/subscriptions", "organizations_url": "https://api.github.com/users/SunMarc/orgs", "repos_url": "https://api.github.com/users/SunMarc/repos", "events_url": "https://api.github.com/users/SunMarc/events{/privacy}", "received_events_url": "https://api.github.com/users/SunMarc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41283/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41283/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41282
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41282/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41282/comments
https://api.github.com/repos/huggingface/transformers/issues/41282/events
https://github.com/huggingface/transformers/pull/41282
3,477,097,238
PR_kwDOCUB6oc6rvsvV
41,282
Fix - remove deprecated args checking in deepspeed intergrations
{ "login": "nguyen599", "id": 144032789, "node_id": "U_kgDOCJXEFQ", "avatar_url": "https://avatars.githubusercontent.com/u/144032789?v=4", "gravatar_id": "", "url": "https://api.github.com/users/nguyen599", "html_url": "https://github.com/nguyen599", "followers_url": "https://api.github.com/users/nguyen599/followers", "following_url": "https://api.github.com/users/nguyen599/following{/other_user}", "gists_url": "https://api.github.com/users/nguyen599/gists{/gist_id}", "starred_url": "https://api.github.com/users/nguyen599/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/nguyen599/subscriptions", "organizations_url": "https://api.github.com/users/nguyen599/orgs", "repos_url": "https://api.github.com/users/nguyen599/repos", "events_url": "https://api.github.com/users/nguyen599/events{/privacy}", "received_events_url": "https://api.github.com/users/nguyen599/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-02T11:08:57
2025-10-02T14:00:25
2025-10-02T13:59:50
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41282", "html_url": "https://github.com/huggingface/transformers/pull/41282", "diff_url": "https://github.com/huggingface/transformers/pull/41282.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41282.patch", "merged_at": "2025-10-02T13:59:50" }
# What does this PR do? `adafactor` training args removed in this pr [#41017](https://github.com/huggingface/transformers/pull/41017). This PR remove adafactor checking in the deepspeed intergrations. <!-- Congratulations! You've made it this far! You're not quite done yet though. Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution. Then, please replace this with a description of the change and which issue is fixed (if applicable). Please also include relevant motivation and context. List any dependencies (if any) that are required for this change. Once you're done, someone will review your PR shortly (see the section "Who can review?" below to tag some potential reviewers). They may suggest changes to make the code even better. If no one reviewed your PR after a week has passed, don't hesitate to post a new comment @-mentioning the same persons---sometimes notifications get lost. --> <!-- Remove if not applicable --> Fixes # (issue) ## Before submitting - [x] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [x] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request), Pull Request section? - [ ] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case. - [x] Did you make sure to update the documentation with your changes? Here are the [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation). - [ ] Did you write any new necessary tests? ## Who can review? Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR. <!-- Your PR will be replied to more quickly if you can figure out the right person to tag with @ If you know how to use git blame, that is the easiest way, otherwise, here is a rough guide of **who to tag**. Please tag fewer than 3 people. Models: - text models: @ArthurZucker @Cyrilvallez - vision models: @yonigozlan @molbap - audio models: @eustlb @ebezzam @vasqu - multimodal models: @zucchini-nlp - graph models: @clefourrier Library: - generate: @zucchini-nlp (visual-language models) or @gante (all others) - continuous batching: @remi-or @ArthurZucker @McPatate - pipelines: @Rocketknight1 - tokenizers: @ArthurZucker and @itazap - trainer: @zach-huggingface @SunMarc - attention: @vasqu @ArthurZucker @CyrilVallez - model loading (from pretrained, etc): @CyrilVallez - distributed: @3outeille @ArthurZucker @S1ro1 - CIs: @ydshieh Integrations: - deepspeed: HF Trainer/Accelerate: @SunMarc @zach-huggingface - ray/raytune: @richardliaw, @amogkam - Big Model Inference: @SunMarc - quantization (bitsandbytes, autogpt): @SunMarc @MekkCyber - kernels: @MekkCyber @drbh - peft: @BenjaminBossan @githubnemo Devices/Backends: - AMD ROCm: @ivarflakstad - Intel XPU: @IlyasMoutawwakil - Ascend NPU: @ivarflakstad Documentation: @stevhliu Research projects are not maintained and should be taken as is. -->
{ "login": "SunMarc", "id": 57196510, "node_id": "MDQ6VXNlcjU3MTk2NTEw", "avatar_url": "https://avatars.githubusercontent.com/u/57196510?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SunMarc", "html_url": "https://github.com/SunMarc", "followers_url": "https://api.github.com/users/SunMarc/followers", "following_url": "https://api.github.com/users/SunMarc/following{/other_user}", "gists_url": "https://api.github.com/users/SunMarc/gists{/gist_id}", "starred_url": "https://api.github.com/users/SunMarc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SunMarc/subscriptions", "organizations_url": "https://api.github.com/users/SunMarc/orgs", "repos_url": "https://api.github.com/users/SunMarc/repos", "events_url": "https://api.github.com/users/SunMarc/events{/privacy}", "received_events_url": "https://api.github.com/users/SunMarc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41282/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41282/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41281
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41281/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41281/comments
https://api.github.com/repos/huggingface/transformers/issues/41281/events
https://github.com/huggingface/transformers/pull/41281
3,476,871,614
PR_kwDOCUB6oc6ru65s
41,281
Adding kernels tests
{ "login": "MekkCyber", "id": 93391238, "node_id": "U_kgDOBZEJhg", "avatar_url": "https://avatars.githubusercontent.com/u/93391238?v=4", "gravatar_id": "", "url": "https://api.github.com/users/MekkCyber", "html_url": "https://github.com/MekkCyber", "followers_url": "https://api.github.com/users/MekkCyber/followers", "following_url": "https://api.github.com/users/MekkCyber/following{/other_user}", "gists_url": "https://api.github.com/users/MekkCyber/gists{/gist_id}", "starred_url": "https://api.github.com/users/MekkCyber/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/MekkCyber/subscriptions", "organizations_url": "https://api.github.com/users/MekkCyber/orgs", "repos_url": "https://api.github.com/users/MekkCyber/repos", "events_url": "https://api.github.com/users/MekkCyber/events{/privacy}", "received_events_url": "https://api.github.com/users/MekkCyber/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
open
false
null
[]
null
[]
2025-10-02T09:57:49
2025-10-21T10:45:09
null
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41281", "html_url": "https://github.com/huggingface/transformers/pull/41281", "diff_url": "https://github.com/huggingface/transformers/pull/41281.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41281.patch", "merged_at": null }
# What does this PR do? PR to add kernel tests and ci
null
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41281/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41281/timeline
null
null
null
null
true
false
https://api.github.com/repos/huggingface/transformers/issues/41280
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41280/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41280/comments
https://api.github.com/repos/huggingface/transformers/issues/41280/events
https://github.com/huggingface/transformers/pull/41280
3,476,727,435
PR_kwDOCUB6oc6rubef
41,280
Use max/min
{ "login": "cyyever", "id": 17618148, "node_id": "MDQ6VXNlcjE3NjE4MTQ4", "avatar_url": "https://avatars.githubusercontent.com/u/17618148?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cyyever", "html_url": "https://github.com/cyyever", "followers_url": "https://api.github.com/users/cyyever/followers", "following_url": "https://api.github.com/users/cyyever/following{/other_user}", "gists_url": "https://api.github.com/users/cyyever/gists{/gist_id}", "starred_url": "https://api.github.com/users/cyyever/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cyyever/subscriptions", "organizations_url": "https://api.github.com/users/cyyever/orgs", "repos_url": "https://api.github.com/users/cyyever/repos", "events_url": "https://api.github.com/users/cyyever/events{/privacy}", "received_events_url": "https://api.github.com/users/cyyever/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-02T09:11:19
2025-10-02T12:19:17
2025-10-02T12:15:27
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41280", "html_url": "https://github.com/huggingface/transformers/pull/41280", "diff_url": "https://github.com/huggingface/transformers/pull/41280.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41280.patch", "merged_at": "2025-10-02T12:15:27" }
# What does this PR do? Some code can directly use `max/min` to avoid sorting.
{ "login": "Rocketknight1", "id": 12866554, "node_id": "MDQ6VXNlcjEyODY2NTU0", "avatar_url": "https://avatars.githubusercontent.com/u/12866554?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Rocketknight1", "html_url": "https://github.com/Rocketknight1", "followers_url": "https://api.github.com/users/Rocketknight1/followers", "following_url": "https://api.github.com/users/Rocketknight1/following{/other_user}", "gists_url": "https://api.github.com/users/Rocketknight1/gists{/gist_id}", "starred_url": "https://api.github.com/users/Rocketknight1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Rocketknight1/subscriptions", "organizations_url": "https://api.github.com/users/Rocketknight1/orgs", "repos_url": "https://api.github.com/users/Rocketknight1/repos", "events_url": "https://api.github.com/users/Rocketknight1/events{/privacy}", "received_events_url": "https://api.github.com/users/Rocketknight1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41280/reactions", "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41280/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41279
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41279/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41279/comments
https://api.github.com/repos/huggingface/transformers/issues/41279/events
https://github.com/huggingface/transformers/pull/41279
3,476,711,899
PR_kwDOCUB6oc6ruYJp
41,279
Fix unnecessary single-item container checks
{ "login": "cyyever", "id": 17618148, "node_id": "MDQ6VXNlcjE3NjE4MTQ4", "avatar_url": "https://avatars.githubusercontent.com/u/17618148?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cyyever", "html_url": "https://github.com/cyyever", "followers_url": "https://api.github.com/users/cyyever/followers", "following_url": "https://api.github.com/users/cyyever/following{/other_user}", "gists_url": "https://api.github.com/users/cyyever/gists{/gist_id}", "starred_url": "https://api.github.com/users/cyyever/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cyyever/subscriptions", "organizations_url": "https://api.github.com/users/cyyever/orgs", "repos_url": "https://api.github.com/users/cyyever/repos", "events_url": "https://api.github.com/users/cyyever/events{/privacy}", "received_events_url": "https://api.github.com/users/cyyever/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-02T09:06:32
2025-10-02T12:39:46
2025-10-02T12:35:11
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41279", "html_url": "https://github.com/huggingface/transformers/pull/41279", "diff_url": "https://github.com/huggingface/transformers/pull/41279.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41279.patch", "merged_at": "2025-10-02T12:35:11" }
# What does this PR do? Simplify container tests.
{ "login": "Rocketknight1", "id": 12866554, "node_id": "MDQ6VXNlcjEyODY2NTU0", "avatar_url": "https://avatars.githubusercontent.com/u/12866554?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Rocketknight1", "html_url": "https://github.com/Rocketknight1", "followers_url": "https://api.github.com/users/Rocketknight1/followers", "following_url": "https://api.github.com/users/Rocketknight1/following{/other_user}", "gists_url": "https://api.github.com/users/Rocketknight1/gists{/gist_id}", "starred_url": "https://api.github.com/users/Rocketknight1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Rocketknight1/subscriptions", "organizations_url": "https://api.github.com/users/Rocketknight1/orgs", "repos_url": "https://api.github.com/users/Rocketknight1/repos", "events_url": "https://api.github.com/users/Rocketknight1/events{/privacy}", "received_events_url": "https://api.github.com/users/Rocketknight1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41279/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41279/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41278
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41278/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41278/comments
https://api.github.com/repos/huggingface/transformers/issues/41278/events
https://github.com/huggingface/transformers/issues/41278
3,476,653,172
I_kwDOCUB6oc7POYR0
41,278
Segmentation Fault with Qwen2 on Multi-GPU (device_map='auto')
{ "login": "justice-Pan", "id": 162892809, "node_id": "U_kgDOCbWMCQ", "avatar_url": "https://avatars.githubusercontent.com/u/162892809?v=4", "gravatar_id": "", "url": "https://api.github.com/users/justice-Pan", "html_url": "https://github.com/justice-Pan", "followers_url": "https://api.github.com/users/justice-Pan/followers", "following_url": "https://api.github.com/users/justice-Pan/following{/other_user}", "gists_url": "https://api.github.com/users/justice-Pan/gists{/gist_id}", "starred_url": "https://api.github.com/users/justice-Pan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/justice-Pan/subscriptions", "organizations_url": "https://api.github.com/users/justice-Pan/orgs", "repos_url": "https://api.github.com/users/justice-Pan/repos", "events_url": "https://api.github.com/users/justice-Pan/events{/privacy}", "received_events_url": "https://api.github.com/users/justice-Pan/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 3817266200, "node_id": "MDU6TGFiZWwzODE3MjY2MjAw", "url": "https://api.github.com/repos/huggingface/transformers/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": null } ]
open
false
null
[]
null
[]
2025-10-02T08:48:12
2025-10-03T15:46:25
null
NONE
null
null
null
null
### System Info **Library versions** - `transformers`: 4.40.1 - `accelerate`: 0.29.3 - `torch`: 2.1.2+cu121 - `bitsandbytes`: 0.41.3 - `CUDA`: 12.1 - `Python`: 3.10 **Hardware** - GPUs: 2x NVIDIA RTX 3090 (24GB) - Driver: NVIDIA 535.171.04 ### Who can help? **Description** When attempting to load the `deepseek-ai/DeepSeek-R1-Distill-Qwen-14B` model (a `qwen2` model type) using `device_map="auto"` on a multi-GPU system, a `Segmentation fault (core dumped)` occurs immediately after the model weights are loaded. **The bug persists even when 4-bit quantization (`bitsandbytes`) and PEFT (LoRA) are completely disabled.** This strongly suggests the issue is not with those libraries, but with a core incompatibility between the Qwen2 model's remote code implementation and `accelerate`'s `device_map` functionality. **Minimal Reproducible Code** ```python import torch from transformers import AutoModelForCausalLM, AutoTokenizer # This is sufficient to trigger the crash model_name = "deepseek-ai/DeepSeek-R1-Distill-Qwen-14B" print("Loading tokenizer...") tokenizer = AutoTokenizer.from_pretrained(model_name, trust_remote_code=True) print("Loading model...") model = AutoModelForCausalLM.from_pretrained( model_name, device_map="auto", trust_remote_code=True, torch_dtype=torch.float16 # Using float16 to even attempt loading ) print("Model loading finished. The script crashes right after this.") # The script never reaches this point ``` **Expected behavior** The script should either load the model successfully or fail with a clear `CUDA out of memory` error if the model is too large. **Actual behavior** The script prints `Loading checkpoint shards... 100%` and then immediately exits with `Segmentation fault (core dumped)`. This bug prevents any form of multi-GPU inference or training with Qwen2 models using `device_map` on this hardware configuration. ### Information - [ ] The official example scripts - [ ] My own modified scripts ### Tasks - [ ] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...) - [ ] My own task or dataset (give details below) ### Reproduction import os import yaml import argparse import torch import warnings import importlib.metadata # 忽略一些不影响结果的警告 warnings.filterwarnings("ignore") from datasets import load_dataset from peft import LoraConfig, get_peft_model, prepare_model_for_kbit_training from transformers import ( AutoModelForCausalLM, AutoTokenizer, BitsAndBytesConfig, TrainingArguments, Trainer, DataCollatorForSeq2Seq, ) def main(config_path: str): # --- 1. 加载配置 --- with open(config_path, 'r') as f: config = yaml.safe_load(f) model_cfg = config['model_params'] data_cfg = config['data_params'] lora_cfg = config['lora_params'] training_cfg = config['training_params'] logging_cfg = config.get('logging_params', {}) optim_cfg = config.get('optim_params', {}) print("--- 配置加载完毕 ---") # --- 2. 检查并升级关键库版本 --- print("--- 正在检查关键库版本... ---") try: # 使用 importlib.metadata 进行更可靠的版本检查 bitsandbytes_version = importlib.metadata.version("bitsandbytes") peft_version = importlib.metadata.version("peft") accelerate_version = importlib.metadata.version("accelerate") print(f"bitsandbytes version: {bitsandbytes_version}") print(f"peft version: {peft_version}") print(f"accelerate version: {accelerate_version}") except importlib.metadata.PackageNotFoundError as e: print(f"错误: 无法找到包的版本: {e}。请确保库已在当前环境中正确安装。") return except Exception as e: print(f"检查版本时发生未知错误: {e}") return # --- 3. 加载Tokenizer --- tokenizer = AutoTokenizer.from_pretrained( model_cfg['model_dir'], trust_remote_code=True, local_files_only=True ) if tokenizer.pad_token is None: tokenizer.pad_token = tokenizer.eos_token print("--- Tokenizer加载完毕 ---") # --- 4. [关键修改] 加载4-bit量化模型 --- # 使用fp16作为计算类型,这在3090上更稳定 compute_dtype = torch.float16 # bnb_config = BitsAndBytesConfig( # load_in_4bit=True, # bnb_4bit_quant_type="nf4", # bnb_4bit_compute_dtype=compute_dtype, # bnb_4bit_use_double_quant=True, # ) print("--- 正在加载模型 (已禁用量化,预期会OOM)... ---") model = AutoModelForCausalLM.from_pretrained( model_cfg['model_dir'], # quantization_config=bnb_config, device_map="auto", # 保持模型并行 trust_remote_code=True, local_files_only=True, attn_implementation="sdpa" # attn_implementation="flash_attention_2" # use_flash_attention_2=True, # [关键新增] 使用Flash Attention 2节省显存并加速 ) # # 修复一个已知的bug,当使用梯度检查点时需要设置 # model.config.pretraining_tp = 1 # model = prepare_model_for_kbit_training(model) # peft_config = LoraConfig(**lora_cfg, task_type="CAUSAL_LM") # model = get_peft_model(model, peft_config) # model.print_trainable_parameters() # print("--- 4-bit量化与LoRA模型准备完毕 ---") # --- 5. 加载和预处理数据集 --- def preprocess_function(examples): # 假设数据格式是 {"messages": [...]} prompts = [tokenizer.apply_chat_template(msgs, tokenize=False, add_generation_prompt=False) for msgs in examples["messages"]] inputs = tokenizer(prompts, max_length=data_cfg['max_seq_length'], truncation=True, padding=False) # 标签也需要被截断 labels = tokenizer(prompts, max_length=data_cfg['max_seq_length'], truncation=True, padding=False) inputs['labels'] = labels['input_ids'] return inputs dataset = load_dataset("json", data_files=data_cfg['train_file'], split="train") processed_dataset = dataset.map(preprocess_function, batched=True, remove_columns=dataset.column_names) print("--- 数据集处理完毕 ---") # --- 6. [关键修改] 配置训练参数 --- trainer_args = TrainingArguments( output_dir=model_cfg['output_dir'], per_device_train_batch_size=training_cfg['per_device_train_batch_size'], gradient_accumulation_steps=training_cfg['gradient_accumulation_steps'], # 使用8位分页优化器 optim=optim_cfg.get('optim', 'paged_adamw_8bit'), learning_rate=training_cfg['learning_rate'], weight_decay=training_cfg['weight_decay'], num_train_epochs=training_cfg['num_train_epochs'], lr_scheduler_type=training_cfg['lr_scheduler_type'], warmup_ratio=training_cfg['warmup_ratio'], max_grad_norm=training_cfg['max_grad_norm'], # 混合精度与梯度检查点 fp16=True, # 明确使用fp16 bf16=False, gradient_checkpointing=training_cfg['use_gradient_checkpointing'], # 日志与保存 logging_steps=logging_cfg.get('logging_steps', 10), save_strategy=logging_cfg.get('save_strategy', 'epoch'), save_steps=logging_cfg.get('save_steps', 500), save_total_limit=2, # 禁用tf32,有时它会与4-bit量化冲突 tf32=False, report_to="wandb" if logging_cfg.get('wandb_project') else "none", run_name=f"qwen-qlora-{os.path.basename(model_cfg['output_dir'])}" ) # --- 7. 初始化并开始训练 --- trainer = Trainer( model=model, args=trainer_args, train_dataset=processed_dataset, tokenizer=tokenizer, data_collator=DataCollatorForSeq2Seq(tokenizer, pad_to_multiple_of=8, return_tensors="pt", padding=True), ) # 修复 `use_cache=True` 与梯度检查点的冲突 if training_cfg['use_gradient_checkpointing']: model.config.use_cache = False print("--- 开始训练 ---") trainer.train() # --- 8. 保存最终模型 --- print("--- 训练完成,正在保存最终模型... ---") trainer.save_model(os.path.join(model_cfg['output_dir'], "final_checkpoint")) print("--- 最终模型已保存 ---") if __name__ == "__main__": parser = argparse.ArgumentParser() parser.add_argument("--config", type=str, required=True, help="Path to the config.yaml file") args = parser.parse_args() main(args.config) ### Expected behavior --- name: "Bug Report: Segmentation Fault with Qwen2 on Multi-GPU (device_map='auto')" --- **Library versions** - `transformers`: 4.40.1 - `accelerate`: 0.29.3 - `torch`: 2.1.2+cu121 - `bitsandbytes`: 0.41.3 - `CUDA`: 12.1 - `Python`: 3.10 **Hardware** - GPUs: 2x NVIDIA RTX 3090 (24GB) - Driver: NVIDIA 535.171.04 **Description** When attempting to load the `deepseek-ai/DeepSeek-R1-Distill-Qwen-14B` model (a `qwen2` model type) using `device_map="auto"` on a multi-GPU system, a `Segmentation fault (core dumped)` occurs immediately after the model weights are loaded. **The bug persists even when 4-bit quantization (`bitsandbytes`) and PEFT (LoRA) are completely disabled.** This strongly suggests the issue is not with those libraries, but with a core incompatibility between the Qwen2 model's remote code implementation and `accelerate`'s `device_map` functionality. **Minimal Reproducible Code** ```python import torch from transformers import AutoModelForCausalLM, AutoTokenizer # This is sufficient to trigger the crash model_name = "deepseek-ai/DeepSeek-R1-Distill-Qwen-14B" print("Loading tokenizer...") tokenizer = AutoTokenizer.from_pretrained(model_name, trust_remote_code=True) print("Loading model...") model = AutoModelForCausalLM.from_pretrained( model_name, device_map="auto", trust_remote_code=True, torch_dtype=torch.float16 # Using float16 to even attempt loading ) print("Model loading finished. The script crashes right after this.") # The script never reaches this point ``` **Expected behavior** The script should either load the model successfully or fail with a clear `CUDA out of memory` error if the model is too large. **Actual behavior** The script prints `Loading checkpoint shards... 100%` and then immediately exits with `Segmentation fault (core dumped)`. This bug prevents any form of multi-GPU inference or training with Qwen2 models using `device_map` on this hardware configuration.
null
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41278/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41278/timeline
null
null
{ "total": 0, "completed": 0, "percent_completed": 0 }
{ "blocked_by": 0, "total_blocked_by": 0, "blocking": 0, "total_blocking": 0 }
false
false
https://api.github.com/repos/huggingface/transformers/issues/41277
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41277/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41277/comments
https://api.github.com/repos/huggingface/transformers/issues/41277/events
https://github.com/huggingface/transformers/pull/41277
3,476,371,236
PR_kwDOCUB6oc6rtNir
41,277
Add processor and intergration test for qwen3vl
{ "login": "JJJYmmm", "id": 92386084, "node_id": "U_kgDOBYGzJA", "avatar_url": "https://avatars.githubusercontent.com/u/92386084?v=4", "gravatar_id": "", "url": "https://api.github.com/users/JJJYmmm", "html_url": "https://github.com/JJJYmmm", "followers_url": "https://api.github.com/users/JJJYmmm/followers", "following_url": "https://api.github.com/users/JJJYmmm/following{/other_user}", "gists_url": "https://api.github.com/users/JJJYmmm/gists{/gist_id}", "starred_url": "https://api.github.com/users/JJJYmmm/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/JJJYmmm/subscriptions", "organizations_url": "https://api.github.com/users/JJJYmmm/orgs", "repos_url": "https://api.github.com/users/JJJYmmm/repos", "events_url": "https://api.github.com/users/JJJYmmm/events{/privacy}", "received_events_url": "https://api.github.com/users/JJJYmmm/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-02T07:18:31
2025-10-02T12:59:04
2025-10-02T12:59:04
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41277", "html_url": "https://github.com/huggingface/transformers/pull/41277", "diff_url": "https://github.com/huggingface/transformers/pull/41277.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41277.patch", "merged_at": "2025-10-02T12:59:04" }
# What does this PR do? - support aux loss in qwen3vlmoe - update qwen3vl processor test since the Qwen3-VL-235B-A22B is released! - fix multi-video inference - add intergration test for 30a3 (skip for now) # Who can review? - text models: @ArthurZucker @Cyrilvallez - multimodal models: @zucchini-nlp
{ "login": "zucchini-nlp", "id": 100715397, "node_id": "U_kgDOBgDLhQ", "avatar_url": "https://avatars.githubusercontent.com/u/100715397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zucchini-nlp", "html_url": "https://github.com/zucchini-nlp", "followers_url": "https://api.github.com/users/zucchini-nlp/followers", "following_url": "https://api.github.com/users/zucchini-nlp/following{/other_user}", "gists_url": "https://api.github.com/users/zucchini-nlp/gists{/gist_id}", "starred_url": "https://api.github.com/users/zucchini-nlp/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zucchini-nlp/subscriptions", "organizations_url": "https://api.github.com/users/zucchini-nlp/orgs", "repos_url": "https://api.github.com/users/zucchini-nlp/repos", "events_url": "https://api.github.com/users/zucchini-nlp/events{/privacy}", "received_events_url": "https://api.github.com/users/zucchini-nlp/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41277/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41277/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41276
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41276/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41276/comments
https://api.github.com/repos/huggingface/transformers/issues/41276/events
https://github.com/huggingface/transformers/pull/41276
3,476,142,577
PR_kwDOCUB6oc6rsbBm
41,276
Add dinov3 autobackbone
{ "login": "vijayabhaskar-ev", "id": 21217929, "node_id": "MDQ6VXNlcjIxMjE3OTI5", "avatar_url": "https://avatars.githubusercontent.com/u/21217929?v=4", "gravatar_id": "", "url": "https://api.github.com/users/vijayabhaskar-ev", "html_url": "https://github.com/vijayabhaskar-ev", "followers_url": "https://api.github.com/users/vijayabhaskar-ev/followers", "following_url": "https://api.github.com/users/vijayabhaskar-ev/following{/other_user}", "gists_url": "https://api.github.com/users/vijayabhaskar-ev/gists{/gist_id}", "starred_url": "https://api.github.com/users/vijayabhaskar-ev/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/vijayabhaskar-ev/subscriptions", "organizations_url": "https://api.github.com/users/vijayabhaskar-ev/orgs", "repos_url": "https://api.github.com/users/vijayabhaskar-ev/repos", "events_url": "https://api.github.com/users/vijayabhaskar-ev/events{/privacy}", "received_events_url": "https://api.github.com/users/vijayabhaskar-ev/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
open
false
null
[]
null
[]
2025-10-02T05:52:56
2025-10-28T05:42:54
null
NONE
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41276", "html_url": "https://github.com/huggingface/transformers/pull/41276", "diff_url": "https://github.com/huggingface/transformers/pull/41276.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41276.patch", "merged_at": null }
This PR implements DINOv3 support for AutoBackbone. What's Implemented: DINOv3ViTConfig: Complete configuration class with all DINOv3-specific parameters DINOv3ViTModel: Full model implementation with RoPE embeddings, register tokens, and SwiGLU MLP DINOv3ViTBackbone: AutoBackbone integration with multi-scale feature extraction AutoBackbone Integration: Added to MODEL_FOR_BACKBONE_MAPPING_NAMES in modeling_auto.py Facebook API Compatibility: get_intermediate_layers method matching Facebook Research implementation Multi-scale Features: Support for object detection and segmentation downstream tasks Fixes #40323
null
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41276/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41276/timeline
null
null
null
null
true
false
https://api.github.com/repos/huggingface/transformers/issues/41275
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41275/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41275/comments
https://api.github.com/repos/huggingface/transformers/issues/41275/events
https://github.com/huggingface/transformers/pull/41275
3,476,043,133
PR_kwDOCUB6oc6rsEnf
41,275
fix asr pipeline ut failures
{ "login": "yao-matrix", "id": 7245027, "node_id": "MDQ6VXNlcjcyNDUwMjc=", "avatar_url": "https://avatars.githubusercontent.com/u/7245027?v=4", "gravatar_id": "", "url": "https://api.github.com/users/yao-matrix", "html_url": "https://github.com/yao-matrix", "followers_url": "https://api.github.com/users/yao-matrix/followers", "following_url": "https://api.github.com/users/yao-matrix/following{/other_user}", "gists_url": "https://api.github.com/users/yao-matrix/gists{/gist_id}", "starred_url": "https://api.github.com/users/yao-matrix/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/yao-matrix/subscriptions", "organizations_url": "https://api.github.com/users/yao-matrix/orgs", "repos_url": "https://api.github.com/users/yao-matrix/repos", "events_url": "https://api.github.com/users/yao-matrix/events{/privacy}", "received_events_url": "https://api.github.com/users/yao-matrix/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-02T05:08:03
2025-10-02T14:49:39
2025-10-02T08:32:04
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41275", "html_url": "https://github.com/huggingface/transformers/pull/41275", "diff_url": "https://github.com/huggingface/transformers/pull/41275.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41275.patch", "merged_at": "2025-10-02T08:32:04" }
4 ASR cases failed on transformers > pytest -rA tests/pipelines/test_pipelines_automatic_speech_recognition.py::AutomaticSpeechRecognitionPipelineTests::test_pipeline_assisted_generation > pytest -rA tests/test_pipeline_mixin.py::AutomaticSpeechRecognitionPipelineTests::test_pipeline_assisted_generation > pytest -rA tests/pipelines/test_pipelines_automatic_speech_recognition.py::AutomaticSpeechRecognitionPipelineTests::test_torch_whisper_batched > pytest -rA tests/test_pipeline_mixin.py::AutomaticSpeechRecognitionPipelineTests::test_torch_whisper_batched @SunMarc @ydshieh , pls help review, thx very much
{ "login": "ydshieh", "id": 2521628, "node_id": "MDQ6VXNlcjI1MjE2Mjg=", "avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ydshieh", "html_url": "https://github.com/ydshieh", "followers_url": "https://api.github.com/users/ydshieh/followers", "following_url": "https://api.github.com/users/ydshieh/following{/other_user}", "gists_url": "https://api.github.com/users/ydshieh/gists{/gist_id}", "starred_url": "https://api.github.com/users/ydshieh/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ydshieh/subscriptions", "organizations_url": "https://api.github.com/users/ydshieh/orgs", "repos_url": "https://api.github.com/users/ydshieh/repos", "events_url": "https://api.github.com/users/ydshieh/events{/privacy}", "received_events_url": "https://api.github.com/users/ydshieh/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41275/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41275/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41274
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41274/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41274/comments
https://api.github.com/repos/huggingface/transformers/issues/41274/events
https://github.com/huggingface/transformers/issues/41274
3,475,776,197
I_kwDOCUB6oc7PLCLF
41,274
does DeepSeek-V3.2-Exp have update?
{ "login": "Mally-cj", "id": 51468122, "node_id": "MDQ6VXNlcjUxNDY4MTIy", "avatar_url": "https://avatars.githubusercontent.com/u/51468122?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Mally-cj", "html_url": "https://github.com/Mally-cj", "followers_url": "https://api.github.com/users/Mally-cj/followers", "following_url": "https://api.github.com/users/Mally-cj/following{/other_user}", "gists_url": "https://api.github.com/users/Mally-cj/gists{/gist_id}", "starred_url": "https://api.github.com/users/Mally-cj/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Mally-cj/subscriptions", "organizations_url": "https://api.github.com/users/Mally-cj/orgs", "repos_url": "https://api.github.com/users/Mally-cj/repos", "events_url": "https://api.github.com/users/Mally-cj/events{/privacy}", "received_events_url": "https://api.github.com/users/Mally-cj/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
open
false
null
[]
null
[]
2025-10-02T02:39:29
2025-10-02T12:04:03
null
NONE
null
null
null
null
cannot find DeepSeek-V3.2-Exp
null
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41274/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41274/timeline
null
null
{ "total": 0, "completed": 0, "percent_completed": 0 }
{ "blocked_by": 0, "total_blocked_by": 0, "blocking": 0, "total_blocking": 0 }
false
false
https://api.github.com/repos/huggingface/transformers/issues/41273
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41273/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41273/comments
https://api.github.com/repos/huggingface/transformers/issues/41273/events
https://github.com/huggingface/transformers/pull/41273
3,475,582,874
PR_kwDOCUB6oc6rql8O
41,273
fix(quantization): Skip weight initialization for quantized models
{ "login": "mauricioharley", "id": 19189450, "node_id": "MDQ6VXNlcjE5MTg5NDUw", "avatar_url": "https://avatars.githubusercontent.com/u/19189450?v=4", "gravatar_id": "", "url": "https://api.github.com/users/mauricioharley", "html_url": "https://github.com/mauricioharley", "followers_url": "https://api.github.com/users/mauricioharley/followers", "following_url": "https://api.github.com/users/mauricioharley/following{/other_user}", "gists_url": "https://api.github.com/users/mauricioharley/gists{/gist_id}", "starred_url": "https://api.github.com/users/mauricioharley/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/mauricioharley/subscriptions", "organizations_url": "https://api.github.com/users/mauricioharley/orgs", "repos_url": "https://api.github.com/users/mauricioharley/repos", "events_url": "https://api.github.com/users/mauricioharley/events{/privacy}", "received_events_url": "https://api.github.com/users/mauricioharley/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
open
false
null
[]
null
[]
2025-10-02T00:23:25
2025-10-02T12:26:00
null
NONE
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41273", "html_url": "https://github.com/huggingface/transformers/pull/41273", "diff_url": "https://github.com/huggingface/transformers/pull/41273.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41273.patch", "merged_at": null }
## Description This Pull Request fixes a `RuntimeError` that occurs when loading `llmcompressor` W8A8 quantized models (e.g., `RedHatAI/Qwen2.5-VL-7B-Instruct-quantized.w8a8`) due to an attempt to initialize `int8` weights using `torch.nn.init.normal_()`, which only supports floating-point dtypes. The issue was identified in `modeling_utils.py` within the `_initialize_missing_keys` method. When `is_quantized` is `True`, the `else` branch was still calling `self.initialize_weights()`, leading to the `RuntimeError`. ## Proposed Change Added a conditional check `if not is_quantized:` before the call to `self.initialize_weights()` in the `else` branch of the `_initialize_missing_keys` method. This ensures that weight initialization is skipped for quantized models, as their weights are either already defined or will be loaded from a pretrained state dictionary, making the initialization redundant and problematic. ## Related Issue Closes #39366
null
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41273/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41273/timeline
null
null
null
null
true
false
https://api.github.com/repos/huggingface/transformers/issues/41272
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41272/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41272/comments
https://api.github.com/repos/huggingface/transformers/issues/41272/events
https://github.com/huggingface/transformers/pull/41272
3,475,537,723
PR_kwDOCUB6oc6rqcY7
41,272
feat: Add HRM Model
{ "login": "zbloss", "id": 7165947, "node_id": "MDQ6VXNlcjcxNjU5NDc=", "avatar_url": "https://avatars.githubusercontent.com/u/7165947?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zbloss", "html_url": "https://github.com/zbloss", "followers_url": "https://api.github.com/users/zbloss/followers", "following_url": "https://api.github.com/users/zbloss/following{/other_user}", "gists_url": "https://api.github.com/users/zbloss/gists{/gist_id}", "starred_url": "https://api.github.com/users/zbloss/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zbloss/subscriptions", "organizations_url": "https://api.github.com/users/zbloss/orgs", "repos_url": "https://api.github.com/users/zbloss/repos", "events_url": "https://api.github.com/users/zbloss/events{/privacy}", "received_events_url": "https://api.github.com/users/zbloss/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
open
false
null
[]
null
[]
2025-10-01T23:54:41
2025-10-27T08:49:37
null
NONE
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41272", "html_url": "https://github.com/huggingface/transformers/pull/41272", "diff_url": "https://github.com/huggingface/transformers/pull/41272.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41272.patch", "merged_at": null }
# What does this PR do? Adds the new Hierarchical Reasoning Model. Fixes #41271 ## Before submitting - [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [x] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request), Pull Request section? - [ ] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case. - [x] Did you make sure to update the documentation with your changes? Here are the [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation). - [x] Did you write any new necessary tests? ## Who can review? Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR. @ArthurZucker @Cyrilvallez hoping you can take a look. The model is currently implemented as a text model though further research hints it may be helpful for understanding images as well.
null
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41272/reactions", "total_count": 2, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 2, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41272/timeline
null
null
null
null
true
false
https://api.github.com/repos/huggingface/transformers/issues/41271
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41271/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41271/comments
https://api.github.com/repos/huggingface/transformers/issues/41271/events
https://github.com/huggingface/transformers/issues/41271
3,475,526,664
I_kwDOCUB6oc7PKFQI
41,271
Add Hierarchical Reasoning Model
{ "login": "zbloss", "id": 7165947, "node_id": "MDQ6VXNlcjcxNjU5NDc=", "avatar_url": "https://avatars.githubusercontent.com/u/7165947?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zbloss", "html_url": "https://github.com/zbloss", "followers_url": "https://api.github.com/users/zbloss/followers", "following_url": "https://api.github.com/users/zbloss/following{/other_user}", "gists_url": "https://api.github.com/users/zbloss/gists{/gist_id}", "starred_url": "https://api.github.com/users/zbloss/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zbloss/subscriptions", "organizations_url": "https://api.github.com/users/zbloss/orgs", "repos_url": "https://api.github.com/users/zbloss/repos", "events_url": "https://api.github.com/users/zbloss/events{/privacy}", "received_events_url": "https://api.github.com/users/zbloss/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 1843244711, "node_id": "MDU6TGFiZWwxODQzMjQ0NzEx", "url": "https://api.github.com/repos/huggingface/transformers/labels/New%20model", "name": "New model", "color": "fbca04", "default": false, "description": "" } ]
open
false
null
[]
null
[]
2025-10-01T23:45:33
2025-10-01T23:45:33
null
NONE
null
null
null
null
### Model description The Hierarchical Reasoning Model (HRM) is showing promise in reasoning tasks. I have been working on cleaning up the [original codebase](https://github.com/sapientinc/HRM) and decided I would also integrate it into the Transformers library so a larger audience could benefit from this project. Below is a snippet from the team's paper which best describes the model. ```abstract ... Inspired by the hierarchical and multi-timescale processing in the human brain, we propose the Hierarchical Reasoning Model (HRM), a novel recurrent architecture that attains significant computational depth while maintaining both training stability and efficiency. HRM executes sequential reasoning tasks in a single forward pass without explicit supervision of the intermediate process, through two interdependent recurrent modules: a high-level module responsible for slow, abstract planning, and a low-level module handling rapid, detailed computations. With only 27 million parameters, HRM achieves exceptional performance on complex reasoning tasks using only 1000 training samples. The model operates without pre-training or CoT data, yet achieves nearly perfect performance on challenging tasks including complex Sudoku puzzles and optimal path finding in large mazes. Furthermore, HRM outperforms much larger models with significantly longer context windows on the Abstraction and Reasoning Corpus (ARC), a key benchmark for measuring artificial general intelligence capabilities. These results underscore HRM’s potential as a transformative advancement toward universal computation and general-purpose reasoning systems. ``` I have a PR ready to close out this issue. ### Open source status - [x] The model implementation is available - [x] The model weights are available ### Provide useful links for the implementation # Authors - @imoneoi - @btoo - @raincchio - @liamnorm - @WC-william - @zbloss - not an original author but I've implemented a refactor to the original codebase. # Weights - [sapientinc/HRM-checkpoint-ARC-2](https://huggingface.co/sapientinc/HRM-checkpoint-ARC-2) - [sapientinc/HRM-checkpoint-sudoku-extreme](https://huggingface.co/sapientinc/HRM-checkpoint-sudoku-extreme) - [sapientinc/HRM-checkpoint-maze-30x30-hard](https://huggingface.co/sapientinc/HRM-checkpoint-maze-30x30-hard) # Original Implementation - Code: https://github.com/sapientinc/HRM - Paper: https://arxiv.org/abs/2506.21734 # Relevant Incoming Changes - I've got a PR currently open in their repo that improves readability and organizes the code. This may be helpful to read through if it has not been merged into main yet: https://github.com/sapientinc/HRM/pull/89
null
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41271/reactions", "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 1, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41271/timeline
null
null
{ "total": 0, "completed": 0, "percent_completed": 0 }
{ "blocked_by": 0, "total_blocked_by": 0, "blocking": 0, "total_blocking": 0 }
false
false
https://api.github.com/repos/huggingface/transformers/issues/41270
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41270/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41270/comments
https://api.github.com/repos/huggingface/transformers/issues/41270/events
https://github.com/huggingface/transformers/pull/41270
3,474,963,961
PR_kwDOCUB6oc6rodiZ
41,270
Biogptlogits
{ "login": "0x-avi", "id": 119068217, "node_id": "U_kgDOBxjWOQ", "avatar_url": "https://avatars.githubusercontent.com/u/119068217?v=4", "gravatar_id": "", "url": "https://api.github.com/users/0x-avi", "html_url": "https://github.com/0x-avi", "followers_url": "https://api.github.com/users/0x-avi/followers", "following_url": "https://api.github.com/users/0x-avi/following{/other_user}", "gists_url": "https://api.github.com/users/0x-avi/gists{/gist_id}", "starred_url": "https://api.github.com/users/0x-avi/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/0x-avi/subscriptions", "organizations_url": "https://api.github.com/users/0x-avi/orgs", "repos_url": "https://api.github.com/users/0x-avi/repos", "events_url": "https://api.github.com/users/0x-avi/events{/privacy}", "received_events_url": "https://api.github.com/users/0x-avi/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-01T20:11:16
2025-10-02T12:34:34
2025-10-02T12:33:48
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41270", "html_url": "https://github.com/huggingface/transformers/pull/41270", "diff_url": "https://github.com/huggingface/transformers/pull/41270.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41270.patch", "merged_at": "2025-10-02T12:33:48" }
# What does this PR do? <!-- Then, please replace this with a description of the change and which issue is fixed (if applicable). Please also include relevant motivation and context. List any dependencies (if any) that are required for this change. Once you're done, someone will review your PR shortly (see the section "Who can review?" below to tag some potential reviewers). They may suggest changes to make the code even better. If no one reviewed your PR after a week has passed, don't hesitate to post a new comment @-mentioning the same persons---sometimes notifications get lost. --> <!-- Remove if not applicable --> Fixes #40984 adds logits_to_keep argument to the `BioGptForSequenceClassification` ## Before submitting - [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [x] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request), Pull Request section? - [x] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case. - [ ] Did you make sure to update the documentation with your changes? Here are the [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation). - [ ] Did you write any new necessary tests? ## Who can review? Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR. @Rocketknight1 <!-- Your PR will be replied to more quickly if you can figure out the right person to tag with @ If you know how to use git blame, that is the easiest way, otherwise, here is a rough guide of **who to tag**. Please tag fewer than 3 people. Models: - text models: @ArthurZucker @Cyrilvallez - vision models: @yonigozlan @molbap - audio models: @eustlb @ebezzam @vasqu - multimodal models: @zucchini-nlp - graph models: @clefourrier Library: - generate: @zucchini-nlp (visual-language models) or @gante (all others) - continuous batching: @remi-or @ArthurZucker @McPatate - pipelines: @Rocketknight1 - tokenizers: @ArthurZucker and @itazap - trainer: @zach-huggingface @SunMarc - attention: @vasqu @ArthurZucker @CyrilVallez - model loading (from pretrained, etc): @CyrilVallez - distributed: @3outeille @ArthurZucker @S1ro1 - CIs: @ydshieh Integrations: - deepspeed: HF Trainer/Accelerate: @SunMarc @zach-huggingface - ray/raytune: @richardliaw, @amogkam - Big Model Inference: @SunMarc - quantization (bitsandbytes, autogpt): @SunMarc @MekkCyber - kernels: @MekkCyber @drbh - peft: @BenjaminBossan @githubnemo Devices/Backends: - AMD ROCm: @ivarflakstad - Intel XPU: @IlyasMoutawwakil - Ascend NPU: @ivarflakstad Documentation: @stevhliu Research projects are not maintained and should be taken as is. -->
{ "login": "Rocketknight1", "id": 12866554, "node_id": "MDQ6VXNlcjEyODY2NTU0", "avatar_url": "https://avatars.githubusercontent.com/u/12866554?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Rocketknight1", "html_url": "https://github.com/Rocketknight1", "followers_url": "https://api.github.com/users/Rocketknight1/followers", "following_url": "https://api.github.com/users/Rocketknight1/following{/other_user}", "gists_url": "https://api.github.com/users/Rocketknight1/gists{/gist_id}", "starred_url": "https://api.github.com/users/Rocketknight1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Rocketknight1/subscriptions", "organizations_url": "https://api.github.com/users/Rocketknight1/orgs", "repos_url": "https://api.github.com/users/Rocketknight1/repos", "events_url": "https://api.github.com/users/Rocketknight1/events{/privacy}", "received_events_url": "https://api.github.com/users/Rocketknight1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41270/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41270/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41269
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41269/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41269/comments
https://api.github.com/repos/huggingface/transformers/issues/41269/events
https://github.com/huggingface/transformers/pull/41269
3,474,607,185
PR_kwDOCUB6oc6rnOou
41,269
Italian translation for README.md
{ "login": "fedtti", "id": 8849891, "node_id": "MDQ6VXNlcjg4NDk4OTE=", "avatar_url": "https://avatars.githubusercontent.com/u/8849891?v=4", "gravatar_id": "", "url": "https://api.github.com/users/fedtti", "html_url": "https://github.com/fedtti", "followers_url": "https://api.github.com/users/fedtti/followers", "following_url": "https://api.github.com/users/fedtti/following{/other_user}", "gists_url": "https://api.github.com/users/fedtti/gists{/gist_id}", "starred_url": "https://api.github.com/users/fedtti/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/fedtti/subscriptions", "organizations_url": "https://api.github.com/users/fedtti/orgs", "repos_url": "https://api.github.com/users/fedtti/repos", "events_url": "https://api.github.com/users/fedtti/events{/privacy}", "received_events_url": "https://api.github.com/users/fedtti/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-01T18:18:07
2025-10-02T22:59:29
2025-10-02T22:59:29
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41269", "html_url": "https://github.com/huggingface/transformers/pull/41269", "diff_url": "https://github.com/huggingface/transformers/pull/41269.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41269.patch", "merged_at": "2025-10-02T22:59:29" }
This PR simply adds an Italian translation of `README.md` to the `i18n` folder and links it in the other available translations, including the `README.md` file itself.
{ "login": "stevhliu", "id": 59462357, "node_id": "MDQ6VXNlcjU5NDYyMzU3", "avatar_url": "https://avatars.githubusercontent.com/u/59462357?v=4", "gravatar_id": "", "url": "https://api.github.com/users/stevhliu", "html_url": "https://github.com/stevhliu", "followers_url": "https://api.github.com/users/stevhliu/followers", "following_url": "https://api.github.com/users/stevhliu/following{/other_user}", "gists_url": "https://api.github.com/users/stevhliu/gists{/gist_id}", "starred_url": "https://api.github.com/users/stevhliu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/stevhliu/subscriptions", "organizations_url": "https://api.github.com/users/stevhliu/orgs", "repos_url": "https://api.github.com/users/stevhliu/repos", "events_url": "https://api.github.com/users/stevhliu/events{/privacy}", "received_events_url": "https://api.github.com/users/stevhliu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41269/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41269/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41268
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41268/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41268/comments
https://api.github.com/repos/huggingface/transformers/issues/41268/events
https://github.com/huggingface/transformers/pull/41268
3,474,485,999
PR_kwDOCUB6oc6rm0Zu
41,268
🚨 Bump to Python 3.10 and rework how we check 3rd-party libraries existence
{ "login": "Cyrilvallez", "id": 71554963, "node_id": "MDQ6VXNlcjcxNTU0OTYz", "avatar_url": "https://avatars.githubusercontent.com/u/71554963?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Cyrilvallez", "html_url": "https://github.com/Cyrilvallez", "followers_url": "https://api.github.com/users/Cyrilvallez/followers", "following_url": "https://api.github.com/users/Cyrilvallez/following{/other_user}", "gists_url": "https://api.github.com/users/Cyrilvallez/gists{/gist_id}", "starred_url": "https://api.github.com/users/Cyrilvallez/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Cyrilvallez/subscriptions", "organizations_url": "https://api.github.com/users/Cyrilvallez/orgs", "repos_url": "https://api.github.com/users/Cyrilvallez/repos", "events_url": "https://api.github.com/users/Cyrilvallez/events{/privacy}", "received_events_url": "https://api.github.com/users/Cyrilvallez/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 9105758243, "node_id": "LA_kwDOCUB6oc8AAAACHr7YIw", "url": "https://api.github.com/repos/huggingface/transformers/labels/for_v5?", "name": "for_v5?", "color": "35BC94", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2025-10-01T17:38:03
2025-10-09T08:49:33
2025-10-06T09:04:19
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41268", "html_url": "https://github.com/huggingface/transformers/pull/41268", "diff_url": "https://github.com/huggingface/transformers/pull/41268.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41268.patch", "merged_at": "2025-10-06T09:04:19" }
# What does this PR do? Python 3.9 is officially EOL starting this month, so let's bump it! Took the opportunity of the new features available in 3.10 to simplify quite a bit our library checks Note that it is breaking BC a bit as I removed some old and unused library checks that were public members
{ "login": "Cyrilvallez", "id": 71554963, "node_id": "MDQ6VXNlcjcxNTU0OTYz", "avatar_url": "https://avatars.githubusercontent.com/u/71554963?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Cyrilvallez", "html_url": "https://github.com/Cyrilvallez", "followers_url": "https://api.github.com/users/Cyrilvallez/followers", "following_url": "https://api.github.com/users/Cyrilvallez/following{/other_user}", "gists_url": "https://api.github.com/users/Cyrilvallez/gists{/gist_id}", "starred_url": "https://api.github.com/users/Cyrilvallez/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Cyrilvallez/subscriptions", "organizations_url": "https://api.github.com/users/Cyrilvallez/orgs", "repos_url": "https://api.github.com/users/Cyrilvallez/repos", "events_url": "https://api.github.com/users/Cyrilvallez/events{/privacy}", "received_events_url": "https://api.github.com/users/Cyrilvallez/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41268/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41268/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41267
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41267/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41267/comments
https://api.github.com/repos/huggingface/transformers/issues/41267/events
https://github.com/huggingface/transformers/pull/41267
3,474,222,736
PR_kwDOCUB6oc6rl6VC
41,267
Remove SageMakerTrainer
{ "login": "cyyever", "id": 17618148, "node_id": "MDQ6VXNlcjE3NjE4MTQ4", "avatar_url": "https://avatars.githubusercontent.com/u/17618148?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cyyever", "html_url": "https://github.com/cyyever", "followers_url": "https://api.github.com/users/cyyever/followers", "following_url": "https://api.github.com/users/cyyever/following{/other_user}", "gists_url": "https://api.github.com/users/cyyever/gists{/gist_id}", "starred_url": "https://api.github.com/users/cyyever/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cyyever/subscriptions", "organizations_url": "https://api.github.com/users/cyyever/orgs", "repos_url": "https://api.github.com/users/cyyever/repos", "events_url": "https://api.github.com/users/cyyever/events{/privacy}", "received_events_url": "https://api.github.com/users/cyyever/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 9105758243, "node_id": "LA_kwDOCUB6oc8AAAACHr7YIw", "url": "https://api.github.com/repos/huggingface/transformers/labels/for_v5?", "name": "for_v5?", "color": "35BC94", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2025-10-01T16:09:31
2025-10-02T09:25:14
2025-10-02T09:16:33
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41267", "html_url": "https://github.com/huggingface/transformers/pull/41267", "diff_url": "https://github.com/huggingface/transformers/pull/41267.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41267.patch", "merged_at": "2025-10-02T09:16:32" }
# What does this PR do? It is replaced by Trainer.
{ "login": "ydshieh", "id": 2521628, "node_id": "MDQ6VXNlcjI1MjE2Mjg=", "avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ydshieh", "html_url": "https://github.com/ydshieh", "followers_url": "https://api.github.com/users/ydshieh/followers", "following_url": "https://api.github.com/users/ydshieh/following{/other_user}", "gists_url": "https://api.github.com/users/ydshieh/gists{/gist_id}", "starred_url": "https://api.github.com/users/ydshieh/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ydshieh/subscriptions", "organizations_url": "https://api.github.com/users/ydshieh/orgs", "repos_url": "https://api.github.com/users/ydshieh/repos", "events_url": "https://api.github.com/users/ydshieh/events{/privacy}", "received_events_url": "https://api.github.com/users/ydshieh/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41267/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41267/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41266
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41266/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41266/comments
https://api.github.com/repos/huggingface/transformers/issues/41266/events
https://github.com/huggingface/transformers/pull/41266
3,474,212,875
PR_kwDOCUB6oc6rl4Ld
41,266
docs: update bitsandbytes platform support
{ "login": "matthewdouglas", "id": 38992547, "node_id": "MDQ6VXNlcjM4OTkyNTQ3", "avatar_url": "https://avatars.githubusercontent.com/u/38992547?v=4", "gravatar_id": "", "url": "https://api.github.com/users/matthewdouglas", "html_url": "https://github.com/matthewdouglas", "followers_url": "https://api.github.com/users/matthewdouglas/followers", "following_url": "https://api.github.com/users/matthewdouglas/following{/other_user}", "gists_url": "https://api.github.com/users/matthewdouglas/gists{/gist_id}", "starred_url": "https://api.github.com/users/matthewdouglas/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/matthewdouglas/subscriptions", "organizations_url": "https://api.github.com/users/matthewdouglas/orgs", "repos_url": "https://api.github.com/users/matthewdouglas/repos", "events_url": "https://api.github.com/users/matthewdouglas/events{/privacy}", "received_events_url": "https://api.github.com/users/matthewdouglas/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-01T16:06:11
2025-10-01T18:27:21
2025-10-01T18:27:20
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41266", "html_url": "https://github.com/huggingface/transformers/pull/41266", "diff_url": "https://github.com/huggingface/transformers/pull/41266.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41266.patch", "merged_at": "2025-10-01T18:27:20" }
# What does this PR do? Updates the quantization docs to reflect that bitsandbytes now provides official support for CPU, Intel XPU, and Intel Gaudi. See the [v0.48.0 release notes](https://github.com/bitsandbytes-foundation/bitsandbytes/releases/tag/0.48.0) for more information. Additionally I keep the yellow icon in the quantization overview section for AMD ROCm and add it for Apple Silicon, as these platforms have preliminary support when built from source. ## Before submitting - [x] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [x] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request), Pull Request section? - [ ] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case. - [x] Did you make sure to update the documentation with your changes? Here are the [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation). - [x] Did you write any new necessary tests? ## Who can review? @SunMarc @MekkCyber @IlyasMoutawwakil
{ "login": "matthewdouglas", "id": 38992547, "node_id": "MDQ6VXNlcjM4OTkyNTQ3", "avatar_url": "https://avatars.githubusercontent.com/u/38992547?v=4", "gravatar_id": "", "url": "https://api.github.com/users/matthewdouglas", "html_url": "https://github.com/matthewdouglas", "followers_url": "https://api.github.com/users/matthewdouglas/followers", "following_url": "https://api.github.com/users/matthewdouglas/following{/other_user}", "gists_url": "https://api.github.com/users/matthewdouglas/gists{/gist_id}", "starred_url": "https://api.github.com/users/matthewdouglas/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/matthewdouglas/subscriptions", "organizations_url": "https://api.github.com/users/matthewdouglas/orgs", "repos_url": "https://api.github.com/users/matthewdouglas/repos", "events_url": "https://api.github.com/users/matthewdouglas/events{/privacy}", "received_events_url": "https://api.github.com/users/matthewdouglas/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41266/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41266/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41265
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41265/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41265/comments
https://api.github.com/repos/huggingface/transformers/issues/41265/events
https://github.com/huggingface/transformers/pull/41265
3,474,191,793
PR_kwDOCUB6oc6rlzjF
41,265
:rotating_light: [`Attention Masks`] Bidirectional masks for encoder and encoder-decoder models
{ "login": "vasqu", "id": 73884904, "node_id": "MDQ6VXNlcjczODg0OTA0", "avatar_url": "https://avatars.githubusercontent.com/u/73884904?v=4", "gravatar_id": "", "url": "https://api.github.com/users/vasqu", "html_url": "https://github.com/vasqu", "followers_url": "https://api.github.com/users/vasqu/followers", "following_url": "https://api.github.com/users/vasqu/following{/other_user}", "gists_url": "https://api.github.com/users/vasqu/gists{/gist_id}", "starred_url": "https://api.github.com/users/vasqu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/vasqu/subscriptions", "organizations_url": "https://api.github.com/users/vasqu/orgs", "repos_url": "https://api.github.com/users/vasqu/repos", "events_url": "https://api.github.com/users/vasqu/events{/privacy}", "received_events_url": "https://api.github.com/users/vasqu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-01T15:59:34
2025-10-09T14:56:21
2025-10-09T14:56:11
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41265", "html_url": "https://github.com/huggingface/transformers/pull/41265", "diff_url": "https://github.com/huggingface/transformers/pull/41265.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41265.patch", "merged_at": "2025-10-09T14:56:11" }
Introduces attention masks for encoder and encoder-decoder models, aka full bidirectional masks, fully compatible with our interface system. Some exceptions, like autoformer, have been ignored for now + there are probably a lot more models that have some weird update patterns but these are imo the most important (related) models here, i.e. Bert and Bart models. Breaking changes: - Executorch now also needs a mask workaround due to vmapping in our general interface - 3D masks are no longer supported (looking at you grounding dino models :eye:) - they just needed to expand to the head dim as well... - Torch fx will no longer work for these models, ig vmapping again (?)
{ "login": "vasqu", "id": 73884904, "node_id": "MDQ6VXNlcjczODg0OTA0", "avatar_url": "https://avatars.githubusercontent.com/u/73884904?v=4", "gravatar_id": "", "url": "https://api.github.com/users/vasqu", "html_url": "https://github.com/vasqu", "followers_url": "https://api.github.com/users/vasqu/followers", "following_url": "https://api.github.com/users/vasqu/following{/other_user}", "gists_url": "https://api.github.com/users/vasqu/gists{/gist_id}", "starred_url": "https://api.github.com/users/vasqu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/vasqu/subscriptions", "organizations_url": "https://api.github.com/users/vasqu/orgs", "repos_url": "https://api.github.com/users/vasqu/repos", "events_url": "https://api.github.com/users/vasqu/events{/privacy}", "received_events_url": "https://api.github.com/users/vasqu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41265/reactions", "total_count": 2, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 2, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41265/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41264
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41264/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41264/comments
https://api.github.com/repos/huggingface/transformers/issues/41264/events
https://github.com/huggingface/transformers/pull/41264
3,474,189,856
PR_kwDOCUB6oc6rlzIU
41,264
Use regex defailed flags
{ "login": "cyyever", "id": 17618148, "node_id": "MDQ6VXNlcjE3NjE4MTQ4", "avatar_url": "https://avatars.githubusercontent.com/u/17618148?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cyyever", "html_url": "https://github.com/cyyever", "followers_url": "https://api.github.com/users/cyyever/followers", "following_url": "https://api.github.com/users/cyyever/following{/other_user}", "gists_url": "https://api.github.com/users/cyyever/gists{/gist_id}", "starred_url": "https://api.github.com/users/cyyever/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cyyever/subscriptions", "organizations_url": "https://api.github.com/users/cyyever/orgs", "repos_url": "https://api.github.com/users/cyyever/repos", "events_url": "https://api.github.com/users/cyyever/events{/privacy}", "received_events_url": "https://api.github.com/users/cyyever/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-01T15:58:53
2025-10-02T08:38:39
2025-10-02T08:34:09
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41264", "html_url": "https://github.com/huggingface/transformers/pull/41264", "diff_url": "https://github.com/huggingface/transformers/pull/41264.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41264.patch", "merged_at": "2025-10-02T08:34:09" }
# What does this PR do? This PR uses full names of regex flags for better code readability.
{ "login": "ydshieh", "id": 2521628, "node_id": "MDQ6VXNlcjI1MjE2Mjg=", "avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ydshieh", "html_url": "https://github.com/ydshieh", "followers_url": "https://api.github.com/users/ydshieh/followers", "following_url": "https://api.github.com/users/ydshieh/following{/other_user}", "gists_url": "https://api.github.com/users/ydshieh/gists{/gist_id}", "starred_url": "https://api.github.com/users/ydshieh/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ydshieh/subscriptions", "organizations_url": "https://api.github.com/users/ydshieh/orgs", "repos_url": "https://api.github.com/users/ydshieh/repos", "events_url": "https://api.github.com/users/ydshieh/events{/privacy}", "received_events_url": "https://api.github.com/users/ydshieh/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41264/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41264/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41263
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41263/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41263/comments
https://api.github.com/repos/huggingface/transformers/issues/41263/events
https://github.com/huggingface/transformers/pull/41263
3,474,176,838
PR_kwDOCUB6oc6rlwTq
41,263
Remove some previous team members from allow list of triggering Github Actions
{ "login": "ydshieh", "id": 2521628, "node_id": "MDQ6VXNlcjI1MjE2Mjg=", "avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ydshieh", "html_url": "https://github.com/ydshieh", "followers_url": "https://api.github.com/users/ydshieh/followers", "following_url": "https://api.github.com/users/ydshieh/following{/other_user}", "gists_url": "https://api.github.com/users/ydshieh/gists{/gist_id}", "starred_url": "https://api.github.com/users/ydshieh/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ydshieh/subscriptions", "organizations_url": "https://api.github.com/users/ydshieh/orgs", "repos_url": "https://api.github.com/users/ydshieh/repos", "events_url": "https://api.github.com/users/ydshieh/events{/privacy}", "received_events_url": "https://api.github.com/users/ydshieh/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-01T15:54:14
2025-10-02T14:32:30
2025-10-02T14:32:29
COLLABORATOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41263", "html_url": "https://github.com/huggingface/transformers/pull/41263", "diff_url": "https://github.com/huggingface/transformers/pull/41263.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41263.patch", "merged_at": "2025-10-02T14:32:29" }
# What does this PR do? Better security practice.
{ "login": "ydshieh", "id": 2521628, "node_id": "MDQ6VXNlcjI1MjE2Mjg=", "avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ydshieh", "html_url": "https://github.com/ydshieh", "followers_url": "https://api.github.com/users/ydshieh/followers", "following_url": "https://api.github.com/users/ydshieh/following{/other_user}", "gists_url": "https://api.github.com/users/ydshieh/gists{/gist_id}", "starred_url": "https://api.github.com/users/ydshieh/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ydshieh/subscriptions", "organizations_url": "https://api.github.com/users/ydshieh/orgs", "repos_url": "https://api.github.com/users/ydshieh/repos", "events_url": "https://api.github.com/users/ydshieh/events{/privacy}", "received_events_url": "https://api.github.com/users/ydshieh/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41263/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41263/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41262
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41262/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41262/comments
https://api.github.com/repos/huggingface/transformers/issues/41262/events
https://github.com/huggingface/transformers/pull/41262
3,474,144,826
PR_kwDOCUB6oc6rlpUp
41,262
add peft team members to issue/pr template
{ "login": "ydshieh", "id": 2521628, "node_id": "MDQ6VXNlcjI1MjE2Mjg=", "avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ydshieh", "html_url": "https://github.com/ydshieh", "followers_url": "https://api.github.com/users/ydshieh/followers", "following_url": "https://api.github.com/users/ydshieh/following{/other_user}", "gists_url": "https://api.github.com/users/ydshieh/gists{/gist_id}", "starred_url": "https://api.github.com/users/ydshieh/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ydshieh/subscriptions", "organizations_url": "https://api.github.com/users/ydshieh/orgs", "repos_url": "https://api.github.com/users/ydshieh/repos", "events_url": "https://api.github.com/users/ydshieh/events{/privacy}", "received_events_url": "https://api.github.com/users/ydshieh/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-01T15:43:48
2025-10-01T17:27:00
2025-10-01T17:26:59
COLLABORATOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41262", "html_url": "https://github.com/huggingface/transformers/pull/41262", "diff_url": "https://github.com/huggingface/transformers/pull/41262.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41262.patch", "merged_at": "2025-10-01T17:26:59" }
# What does this PR do? PEFT go brrrrr
{ "login": "ydshieh", "id": 2521628, "node_id": "MDQ6VXNlcjI1MjE2Mjg=", "avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ydshieh", "html_url": "https://github.com/ydshieh", "followers_url": "https://api.github.com/users/ydshieh/followers", "following_url": "https://api.github.com/users/ydshieh/following{/other_user}", "gists_url": "https://api.github.com/users/ydshieh/gists{/gist_id}", "starred_url": "https://api.github.com/users/ydshieh/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ydshieh/subscriptions", "organizations_url": "https://api.github.com/users/ydshieh/orgs", "repos_url": "https://api.github.com/users/ydshieh/repos", "events_url": "https://api.github.com/users/ydshieh/events{/privacy}", "received_events_url": "https://api.github.com/users/ydshieh/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41262/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41262/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41261
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41261/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41261/comments
https://api.github.com/repos/huggingface/transformers/issues/41261/events
https://github.com/huggingface/transformers/pull/41261
3,474,143,501
PR_kwDOCUB6oc6rlpBu
41,261
Remove `test_initialization`
{ "login": "Cyrilvallez", "id": 71554963, "node_id": "MDQ6VXNlcjcxNTU0OTYz", "avatar_url": "https://avatars.githubusercontent.com/u/71554963?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Cyrilvallez", "html_url": "https://github.com/Cyrilvallez", "followers_url": "https://api.github.com/users/Cyrilvallez/followers", "following_url": "https://api.github.com/users/Cyrilvallez/following{/other_user}", "gists_url": "https://api.github.com/users/Cyrilvallez/gists{/gist_id}", "starred_url": "https://api.github.com/users/Cyrilvallez/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Cyrilvallez/subscriptions", "organizations_url": "https://api.github.com/users/Cyrilvallez/orgs", "repos_url": "https://api.github.com/users/Cyrilvallez/repos", "events_url": "https://api.github.com/users/Cyrilvallez/events{/privacy}", "received_events_url": "https://api.github.com/users/Cyrilvallez/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-01T15:43:26
2025-10-02T14:59:32
2025-10-02T13:23:43
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41261", "html_url": "https://github.com/huggingface/transformers/pull/41261", "diff_url": "https://github.com/huggingface/transformers/pull/41261.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41261.patch", "merged_at": "2025-10-02T13:23:43" }
# What does this PR do? As per the title. The test is very old and not useful anymore. We have the much more recent and accurate `test_can_init_all_missing_weights` I added some time ago to actually test that all weights are correctly taken into account in `_init_weights`. What distribution is then used on those weights is not really important to be tested, and way too hard for a general test as it can be anything. This can be seen by the fact that the test is basically skipped/overwritten for more than half the models in the lib, which is a *strong* sign that the test is quite badly designed to start with 🙃 cc @ArthurZucker @gante
{ "login": "Cyrilvallez", "id": 71554963, "node_id": "MDQ6VXNlcjcxNTU0OTYz", "avatar_url": "https://avatars.githubusercontent.com/u/71554963?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Cyrilvallez", "html_url": "https://github.com/Cyrilvallez", "followers_url": "https://api.github.com/users/Cyrilvallez/followers", "following_url": "https://api.github.com/users/Cyrilvallez/following{/other_user}", "gists_url": "https://api.github.com/users/Cyrilvallez/gists{/gist_id}", "starred_url": "https://api.github.com/users/Cyrilvallez/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Cyrilvallez/subscriptions", "organizations_url": "https://api.github.com/users/Cyrilvallez/orgs", "repos_url": "https://api.github.com/users/Cyrilvallez/repos", "events_url": "https://api.github.com/users/Cyrilvallez/events{/privacy}", "received_events_url": "https://api.github.com/users/Cyrilvallez/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41261/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41261/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41260
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41260/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41260/comments
https://api.github.com/repos/huggingface/transformers/issues/41260/events
https://github.com/huggingface/transformers/pull/41260
3,474,096,829
PR_kwDOCUB6oc6rleoA
41,260
UpdatedREADME.md
{ "login": "aastha44ma", "id": 141214756, "node_id": "U_kgDOCGrEJA", "avatar_url": "https://avatars.githubusercontent.com/u/141214756?v=4", "gravatar_id": "", "url": "https://api.github.com/users/aastha44ma", "html_url": "https://github.com/aastha44ma", "followers_url": "https://api.github.com/users/aastha44ma/followers", "following_url": "https://api.github.com/users/aastha44ma/following{/other_user}", "gists_url": "https://api.github.com/users/aastha44ma/gists{/gist_id}", "starred_url": "https://api.github.com/users/aastha44ma/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/aastha44ma/subscriptions", "organizations_url": "https://api.github.com/users/aastha44ma/orgs", "repos_url": "https://api.github.com/users/aastha44ma/repos", "events_url": "https://api.github.com/users/aastha44ma/events{/privacy}", "received_events_url": "https://api.github.com/users/aastha44ma/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-01T15:31:16
2025-10-02T11:45:09
2025-10-02T11:45:09
NONE
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41260", "html_url": "https://github.com/huggingface/transformers/pull/41260", "diff_url": "https://github.com/huggingface/transformers/pull/41260.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41260.patch", "merged_at": null }
# What does this PR do? <!-- Congratulations! You've made it this far! You're not quite done yet though. Fixes #41244 Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution. Then, please replace this with a description of the change and which issue is fixed (if applicable). Please also include relevant motivation and context. List any dependencies (if any) that are required for this change. Once you're done, someone will review your PR shortly (see the section "Who can review?" below to tag some potential reviewers). They may suggest changes to make the code even better. If no one reviewed your PR after a week has passed, don't hesitate to post a new comment @-mentioning the same persons---sometimes notifications get lost. --> <!-- Remove if not applicable --> Fixes #41244 ## Before submitting - [x] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [x] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request), Pull Request section? - [x] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case. - [x] Did you make sure to update the documentation with your changes? Here are the [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation). - [x] Did you write any new necessary tests? ## Who can review? Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR. <!-- Your PR will be replied to more quickly if you can figure out the right person to tag with @ If you know how to use git blame, that is the easiest way, otherwise, here is a rough guide of **who to tag**. Please tag fewer than 3 people. Models: - text models: @ArthurZucker @Cyrilvallez - vision models: @yonigozlan @molbap - audio models: @eustlb @ebezzam @vasqu - multimodal models: @zucchini-nlp - graph models: @clefourrier Library: - generate: @zucchini-nlp (visual-language models) or @gante (all others) - continuous batching: @remi-or @ArthurZucker @McPatate - pipelines: @Rocketknight1 - tokenizers: @ArthurZucker and @itazap - trainer: @zach-huggingface @SunMarc - attention: @vasqu @ArthurZucker @CyrilVallez - model loading (from pretrained, etc): @CyrilVallez - distributed: @3outeille @ArthurZucker @S1ro1 - CIs: @ydshieh Integrations: - deepspeed: HF Trainer/Accelerate: @SunMarc @zach-huggingface - ray/raytune: @richardliaw, @amogkam - Big Model Inference: @SunMarc - quantization (bitsandbytes, autogpt): @SunMarc @MekkCyber - kernels: @MekkCyber @drbh Devices/Backends: - AMD ROCm: @ivarflakstad - Intel XPU: @IlyasMoutawwakil - Ascend NPU: @ivarflakstad Documentation: @stevhliu Research projects are not maintained and should be taken as is. -->
{ "login": "Rocketknight1", "id": 12866554, "node_id": "MDQ6VXNlcjEyODY2NTU0", "avatar_url": "https://avatars.githubusercontent.com/u/12866554?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Rocketknight1", "html_url": "https://github.com/Rocketknight1", "followers_url": "https://api.github.com/users/Rocketknight1/followers", "following_url": "https://api.github.com/users/Rocketknight1/following{/other_user}", "gists_url": "https://api.github.com/users/Rocketknight1/gists{/gist_id}", "starred_url": "https://api.github.com/users/Rocketknight1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Rocketknight1/subscriptions", "organizations_url": "https://api.github.com/users/Rocketknight1/orgs", "repos_url": "https://api.github.com/users/Rocketknight1/repos", "events_url": "https://api.github.com/users/Rocketknight1/events{/privacy}", "received_events_url": "https://api.github.com/users/Rocketknight1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41260/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41260/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41259
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41259/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41259/comments
https://api.github.com/repos/huggingface/transformers/issues/41259/events
https://github.com/huggingface/transformers/pull/41259
3,474,076,467
PR_kwDOCUB6oc6rlaH1
41,259
Unify is_torchvision_v2_available with is_torchvision_available
{ "login": "cyyever", "id": 17618148, "node_id": "MDQ6VXNlcjE3NjE4MTQ4", "avatar_url": "https://avatars.githubusercontent.com/u/17618148?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cyyever", "html_url": "https://github.com/cyyever", "followers_url": "https://api.github.com/users/cyyever/followers", "following_url": "https://api.github.com/users/cyyever/following{/other_user}", "gists_url": "https://api.github.com/users/cyyever/gists{/gist_id}", "starred_url": "https://api.github.com/users/cyyever/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cyyever/subscriptions", "organizations_url": "https://api.github.com/users/cyyever/orgs", "repos_url": "https://api.github.com/users/cyyever/repos", "events_url": "https://api.github.com/users/cyyever/events{/privacy}", "received_events_url": "https://api.github.com/users/cyyever/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-01T15:25:44
2025-10-02T12:05:59
2025-10-02T11:56:37
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41259", "html_url": "https://github.com/huggingface/transformers/pull/41259", "diff_url": "https://github.com/huggingface/transformers/pull/41259.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41259.patch", "merged_at": "2025-10-02T11:56:37" }
# What does this PR do? This PR fixes the remaining files, a follow-up of #41227 .
{ "login": "Rocketknight1", "id": 12866554, "node_id": "MDQ6VXNlcjEyODY2NTU0", "avatar_url": "https://avatars.githubusercontent.com/u/12866554?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Rocketknight1", "html_url": "https://github.com/Rocketknight1", "followers_url": "https://api.github.com/users/Rocketknight1/followers", "following_url": "https://api.github.com/users/Rocketknight1/following{/other_user}", "gists_url": "https://api.github.com/users/Rocketknight1/gists{/gist_id}", "starred_url": "https://api.github.com/users/Rocketknight1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Rocketknight1/subscriptions", "organizations_url": "https://api.github.com/users/Rocketknight1/orgs", "repos_url": "https://api.github.com/users/Rocketknight1/repos", "events_url": "https://api.github.com/users/Rocketknight1/events{/privacy}", "received_events_url": "https://api.github.com/users/Rocketknight1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41259/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41259/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41258
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41258/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41258/comments
https://api.github.com/repos/huggingface/transformers/issues/41258/events
https://github.com/huggingface/transformers/pull/41258
3,474,057,549
PR_kwDOCUB6oc6rlV7M
41,258
Fix pylint generator warnings
{ "login": "cyyever", "id": 17618148, "node_id": "MDQ6VXNlcjE3NjE4MTQ4", "avatar_url": "https://avatars.githubusercontent.com/u/17618148?v=4", "gravatar_id": "", "url": "https://api.github.com/users/cyyever", "html_url": "https://github.com/cyyever", "followers_url": "https://api.github.com/users/cyyever/followers", "following_url": "https://api.github.com/users/cyyever/following{/other_user}", "gists_url": "https://api.github.com/users/cyyever/gists{/gist_id}", "starred_url": "https://api.github.com/users/cyyever/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/cyyever/subscriptions", "organizations_url": "https://api.github.com/users/cyyever/orgs", "repos_url": "https://api.github.com/users/cyyever/repos", "events_url": "https://api.github.com/users/cyyever/events{/privacy}", "received_events_url": "https://api.github.com/users/cyyever/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-01T15:20:17
2025-10-02T12:39:39
2025-10-02T12:35:42
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41258", "html_url": "https://github.com/huggingface/transformers/pull/41258", "diff_url": "https://github.com/huggingface/transformers/pull/41258.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41258.patch", "merged_at": "2025-10-02T12:35:42" }
# What does this PR do? As the title says..
{ "login": "Rocketknight1", "id": 12866554, "node_id": "MDQ6VXNlcjEyODY2NTU0", "avatar_url": "https://avatars.githubusercontent.com/u/12866554?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Rocketknight1", "html_url": "https://github.com/Rocketknight1", "followers_url": "https://api.github.com/users/Rocketknight1/followers", "following_url": "https://api.github.com/users/Rocketknight1/following{/other_user}", "gists_url": "https://api.github.com/users/Rocketknight1/gists{/gist_id}", "starred_url": "https://api.github.com/users/Rocketknight1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Rocketknight1/subscriptions", "organizations_url": "https://api.github.com/users/Rocketknight1/orgs", "repos_url": "https://api.github.com/users/Rocketknight1/repos", "events_url": "https://api.github.com/users/Rocketknight1/events{/privacy}", "received_events_url": "https://api.github.com/users/Rocketknight1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41258/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41258/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41257
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41257/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41257/comments
https://api.github.com/repos/huggingface/transformers/issues/41257/events
https://github.com/huggingface/transformers/pull/41257
3,474,033,258
PR_kwDOCUB6oc6rlQlk
41,257
Fix typos and clarify docstring in DocumentQuestionAnswering pipeline
{ "login": "CodeByHarini", "id": 225563490, "node_id": "U_kgDODXHTYg", "avatar_url": "https://avatars.githubusercontent.com/u/225563490?v=4", "gravatar_id": "", "url": "https://api.github.com/users/CodeByHarini", "html_url": "https://github.com/CodeByHarini", "followers_url": "https://api.github.com/users/CodeByHarini/followers", "following_url": "https://api.github.com/users/CodeByHarini/following{/other_user}", "gists_url": "https://api.github.com/users/CodeByHarini/gists{/gist_id}", "starred_url": "https://api.github.com/users/CodeByHarini/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/CodeByHarini/subscriptions", "organizations_url": "https://api.github.com/users/CodeByHarini/orgs", "repos_url": "https://api.github.com/users/CodeByHarini/repos", "events_url": "https://api.github.com/users/CodeByHarini/events{/privacy}", "received_events_url": "https://api.github.com/users/CodeByHarini/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-01T15:13:50
2025-10-02T11:44:09
2025-10-02T11:44:09
NONE
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41257", "html_url": "https://github.com/huggingface/transformers/pull/41257", "diff_url": "https://github.com/huggingface/transformers/pull/41257.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41257.patch", "merged_at": null }
Improved clarity and fixed minor typos in the docstring of the DocumentQuestionAnswering pipeline.
{ "login": "Rocketknight1", "id": 12866554, "node_id": "MDQ6VXNlcjEyODY2NTU0", "avatar_url": "https://avatars.githubusercontent.com/u/12866554?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Rocketknight1", "html_url": "https://github.com/Rocketknight1", "followers_url": "https://api.github.com/users/Rocketknight1/followers", "following_url": "https://api.github.com/users/Rocketknight1/following{/other_user}", "gists_url": "https://api.github.com/users/Rocketknight1/gists{/gist_id}", "starred_url": "https://api.github.com/users/Rocketknight1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Rocketknight1/subscriptions", "organizations_url": "https://api.github.com/users/Rocketknight1/orgs", "repos_url": "https://api.github.com/users/Rocketknight1/repos", "events_url": "https://api.github.com/users/Rocketknight1/events{/privacy}", "received_events_url": "https://api.github.com/users/Rocketknight1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41257/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41257/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41256
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41256/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41256/comments
https://api.github.com/repos/huggingface/transformers/issues/41256/events
https://github.com/huggingface/transformers/pull/41256
3,473,998,153
PR_kwDOCUB6oc6rlI8p
41,256
path validation for security reason
{ "login": "ydshieh", "id": 2521628, "node_id": "MDQ6VXNlcjI1MjE2Mjg=", "avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ydshieh", "html_url": "https://github.com/ydshieh", "followers_url": "https://api.github.com/users/ydshieh/followers", "following_url": "https://api.github.com/users/ydshieh/following{/other_user}", "gists_url": "https://api.github.com/users/ydshieh/gists{/gist_id}", "starred_url": "https://api.github.com/users/ydshieh/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ydshieh/subscriptions", "organizations_url": "https://api.github.com/users/ydshieh/orgs", "repos_url": "https://api.github.com/users/ydshieh/repos", "events_url": "https://api.github.com/users/ydshieh/events{/privacy}", "received_events_url": "https://api.github.com/users/ydshieh/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-01T15:04:06
2025-10-17T10:36:06
2025-10-17T10:36:05
COLLABORATOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41256", "html_url": "https://github.com/huggingface/transformers/pull/41256", "diff_url": "https://github.com/huggingface/transformers/pull/41256.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41256.patch", "merged_at": "2025-10-17T10:36:04" }
# What does this PR do? See the comment in file change tab
{ "login": "ydshieh", "id": 2521628, "node_id": "MDQ6VXNlcjI1MjE2Mjg=", "avatar_url": "https://avatars.githubusercontent.com/u/2521628?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ydshieh", "html_url": "https://github.com/ydshieh", "followers_url": "https://api.github.com/users/ydshieh/followers", "following_url": "https://api.github.com/users/ydshieh/following{/other_user}", "gists_url": "https://api.github.com/users/ydshieh/gists{/gist_id}", "starred_url": "https://api.github.com/users/ydshieh/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ydshieh/subscriptions", "organizations_url": "https://api.github.com/users/ydshieh/orgs", "repos_url": "https://api.github.com/users/ydshieh/repos", "events_url": "https://api.github.com/users/ydshieh/events{/privacy}", "received_events_url": "https://api.github.com/users/ydshieh/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41256/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41256/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41255
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41255/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41255/comments
https://api.github.com/repos/huggingface/transformers/issues/41255/events
https://github.com/huggingface/transformers/pull/41255
3,473,983,880
PR_kwDOCUB6oc6rlF3B
41,255
fix async client for transformers chat
{ "login": "SunMarc", "id": 57196510, "node_id": "MDQ6VXNlcjU3MTk2NTEw", "avatar_url": "https://avatars.githubusercontent.com/u/57196510?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SunMarc", "html_url": "https://github.com/SunMarc", "followers_url": "https://api.github.com/users/SunMarc/followers", "following_url": "https://api.github.com/users/SunMarc/following{/other_user}", "gists_url": "https://api.github.com/users/SunMarc/gists{/gist_id}", "starred_url": "https://api.github.com/users/SunMarc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SunMarc/subscriptions", "organizations_url": "https://api.github.com/users/SunMarc/orgs", "repos_url": "https://api.github.com/users/SunMarc/repos", "events_url": "https://api.github.com/users/SunMarc/events{/privacy}", "received_events_url": "https://api.github.com/users/SunMarc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-01T15:00:30
2025-10-02T11:23:39
2025-10-02T11:23:37
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41255", "html_url": "https://github.com/huggingface/transformers/pull/41255", "diff_url": "https://github.com/huggingface/transformers/pull/41255.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41255.patch", "merged_at": "2025-10-02T11:23:37" }
# What does this PR do? This PR fixes the async client for transformers chat. There were some error due to the latest version of `huggingface-hub` since we migrated to httpx and i'm not sure why the previous code actually worked ... ### Traceback ``` Traceback (most recent call last): File "/admin/home/marc/miniconda3/envs/test/bin/transformers", line 8, in <module> sys.exit(main()) File "/admin/home/marc/transformers/src/transformers/commands/transformers_cli.py", line 48, in main service.run() File "/admin/home/marc/transformers/src/transformers/commands/chat.py", line 665, in run asyncio.run(self._inner_run()) File "/admin/home/marc/miniconda3/envs/test/lib/python3.10/asyncio/runners.py", line 44, in run return loop.run_until_complete(main) File "/admin/home/marc/miniconda3/envs/test/lib/python3.10/asyncio/base_events.py", line 649, in run_until_complete return future.result() File "/admin/home/marc/transformers/src/transformers/commands/chat.py", line 747, in _inner_run model_output = await interface.stream_output(stream) File "/admin/home/marc/transformers/src/transformers/commands/chat.py", line 134, in stream_output async for token in await stream: File "/admin/home/marc/miniconda3/envs/test/lib/python3.10/site-packages/huggingface_hub/inference/_generated/_async_client.py", line 956, in chat_completion data = await self._inner_post(request_parameters, stream=stream) File "/admin/home/marc/miniconda3/envs/test/lib/python3.10/site-packages/huggingface_hub/inference/_generated/_async_client.py", line 282, in _inner_post response = await self.exit_stack.enter_async_context( File "/admin/home/marc/miniconda3/envs/test/lib/python3.10/contextlib.py", line 619, in enter_async_context result = await _cm_type.__aenter__(cm) File "/admin/home/marc/miniconda3/envs/test/lib/python3.10/contextlib.py", line 199, in __aenter__ return await anext(self.gen) File "/admin/home/marc/miniconda3/envs/test/lib/python3.10/site-packages/httpx/_client.py", line 1583, in stream response = await self.send( File "/admin/home/marc/miniconda3/envs/test/lib/python3.10/site-packages/httpx/_client.py", line 1616, in send raise RuntimeError("Cannot send a request, as the client has been closed.") RuntimeError: Cannot send a request, as the client has been closed. ```
{ "login": "LysandreJik", "id": 30755778, "node_id": "MDQ6VXNlcjMwNzU1Nzc4", "avatar_url": "https://avatars.githubusercontent.com/u/30755778?v=4", "gravatar_id": "", "url": "https://api.github.com/users/LysandreJik", "html_url": "https://github.com/LysandreJik", "followers_url": "https://api.github.com/users/LysandreJik/followers", "following_url": "https://api.github.com/users/LysandreJik/following{/other_user}", "gists_url": "https://api.github.com/users/LysandreJik/gists{/gist_id}", "starred_url": "https://api.github.com/users/LysandreJik/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/LysandreJik/subscriptions", "organizations_url": "https://api.github.com/users/LysandreJik/orgs", "repos_url": "https://api.github.com/users/LysandreJik/repos", "events_url": "https://api.github.com/users/LysandreJik/events{/privacy}", "received_events_url": "https://api.github.com/users/LysandreJik/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41255/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41255/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41254
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41254/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41254/comments
https://api.github.com/repos/huggingface/transformers/issues/41254/events
https://github.com/huggingface/transformers/pull/41254
3,473,957,507
PR_kwDOCUB6oc6rk_-K
41,254
docs: Add Hacktoberfest banner, Contributing and License sections to README
{ "login": "Shootingstar-99", "id": 213097693, "node_id": "U_kgDODLOc3Q", "avatar_url": "https://avatars.githubusercontent.com/u/213097693?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Shootingstar-99", "html_url": "https://github.com/Shootingstar-99", "followers_url": "https://api.github.com/users/Shootingstar-99/followers", "following_url": "https://api.github.com/users/Shootingstar-99/following{/other_user}", "gists_url": "https://api.github.com/users/Shootingstar-99/gists{/gist_id}", "starred_url": "https://api.github.com/users/Shootingstar-99/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Shootingstar-99/subscriptions", "organizations_url": "https://api.github.com/users/Shootingstar-99/orgs", "repos_url": "https://api.github.com/users/Shootingstar-99/repos", "events_url": "https://api.github.com/users/Shootingstar-99/events{/privacy}", "received_events_url": "https://api.github.com/users/Shootingstar-99/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
open
false
null
[]
null
[]
2025-10-01T14:54:04
2025-10-02T15:07:35
null
NONE
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41254", "html_url": "https://github.com/huggingface/transformers/pull/41254", "diff_url": "https://github.com/huggingface/transformers/pull/41254.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41254.patch", "merged_at": null }
Closes #41246 and #41244 ## What does this PR do? Adds missing sections to the README: - Contributing Guidelines section with link to CONTRIBUTING.md and Code of Conduct - License section with link to LICENSE file Adds: - Hacktoberfest 2025 banner to the top. ## Why? Makes the project more professional and contributor-friendly by following open-source best practices. These sections help new contributors understand how to get involved and clarify the project's licensing terms. It also allows Hacktoberfest participants to more easily understand that this repository is a part of Hacktoberfest.
null
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41254/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41254/timeline
null
null
null
null
true
false
https://api.github.com/repos/huggingface/transformers/issues/41253
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41253/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41253/comments
https://api.github.com/repos/huggingface/transformers/issues/41253/events
https://github.com/huggingface/transformers/pull/41253
3,473,582,720
PR_kwDOCUB6oc6rjsXt
41,253
transformers serve quantization docs + some api fixes for bitsandbytes
{ "login": "SunMarc", "id": 57196510, "node_id": "MDQ6VXNlcjU3MTk2NTEw", "avatar_url": "https://avatars.githubusercontent.com/u/57196510?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SunMarc", "html_url": "https://github.com/SunMarc", "followers_url": "https://api.github.com/users/SunMarc/followers", "following_url": "https://api.github.com/users/SunMarc/following{/other_user}", "gists_url": "https://api.github.com/users/SunMarc/gists{/gist_id}", "starred_url": "https://api.github.com/users/SunMarc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SunMarc/subscriptions", "organizations_url": "https://api.github.com/users/SunMarc/orgs", "repos_url": "https://api.github.com/users/SunMarc/repos", "events_url": "https://api.github.com/users/SunMarc/events{/privacy}", "received_events_url": "https://api.github.com/users/SunMarc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-01T13:29:11
2025-10-23T16:00:55
2025-10-23T16:00:54
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41253", "html_url": "https://github.com/huggingface/transformers/pull/41253", "diff_url": "https://github.com/huggingface/transformers/pull/41253.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41253.patch", "merged_at": "2025-10-23T16:00:54" }
# What does this PR do? This PR adds some docs for transformers serve x quantization and fixes the quantization api for bitsandbytes. Following PR will add more support for other methods and I will add a section in each quantization method to show what is the preferred setup (compile ? dtype ?) when using serve !
{ "login": "SunMarc", "id": 57196510, "node_id": "MDQ6VXNlcjU3MTk2NTEw", "avatar_url": "https://avatars.githubusercontent.com/u/57196510?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SunMarc", "html_url": "https://github.com/SunMarc", "followers_url": "https://api.github.com/users/SunMarc/followers", "following_url": "https://api.github.com/users/SunMarc/following{/other_user}", "gists_url": "https://api.github.com/users/SunMarc/gists{/gist_id}", "starred_url": "https://api.github.com/users/SunMarc/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SunMarc/subscriptions", "organizations_url": "https://api.github.com/users/SunMarc/orgs", "repos_url": "https://api.github.com/users/SunMarc/repos", "events_url": "https://api.github.com/users/SunMarc/events{/privacy}", "received_events_url": "https://api.github.com/users/SunMarc/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41253/reactions", "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 1, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41253/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41252
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41252/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41252/comments
https://api.github.com/repos/huggingface/transformers/issues/41252/events
https://github.com/huggingface/transformers/pull/41252
3,473,431,212
PR_kwDOCUB6oc6rjK3U
41,252
FIX: Bug in PEFT integration delete_adapter method
{ "login": "BenjaminBossan", "id": 6229650, "node_id": "MDQ6VXNlcjYyMjk2NTA=", "avatar_url": "https://avatars.githubusercontent.com/u/6229650?v=4", "gravatar_id": "", "url": "https://api.github.com/users/BenjaminBossan", "html_url": "https://github.com/BenjaminBossan", "followers_url": "https://api.github.com/users/BenjaminBossan/followers", "following_url": "https://api.github.com/users/BenjaminBossan/following{/other_user}", "gists_url": "https://api.github.com/users/BenjaminBossan/gists{/gist_id}", "starred_url": "https://api.github.com/users/BenjaminBossan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/BenjaminBossan/subscriptions", "organizations_url": "https://api.github.com/users/BenjaminBossan/orgs", "repos_url": "https://api.github.com/users/BenjaminBossan/repos", "events_url": "https://api.github.com/users/BenjaminBossan/events{/privacy}", "received_events_url": "https://api.github.com/users/BenjaminBossan/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-01T12:50:00
2025-10-02T16:37:00
2025-10-02T16:36:57
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41252", "html_url": "https://github.com/huggingface/transformers/pull/41252", "diff_url": "https://github.com/huggingface/transformers/pull/41252.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41252.patch", "merged_at": "2025-10-02T16:36:57" }
# What does this PR do? The main content of this PR is to fix a bug in the `delete_adapter` method of the `PeftAdapterMixin`. Previously, it did not take into account auxiliary modules from PEFT, e.g. those added by `modules_to_save`. This PR fixes this oversight. Note that the PR uses a new functionality from PEFT that exposes integration functions like delete_adapter. Those will be contained in the next PEFT release, 0.18.0 (yet unreleased). Therefore, the bug is only fixed when users have a PEFT version fulfilling this requirement. I ensured that with old PEFT versions, the integration still works the same as previously. The newly added test for this is skipped if the PEFT version is too low. (Note: I tested locally with that the test will pass with PEFT 0.18.0) While working on this, I also cleaned up the following: - The `active_adapter` property has been deprecated for more than 2 years (#26407). It is safe to remove it now. - There were numerous small errors or outdated pieces of information in the docstrings, which have been addressed. ## Before submitting - [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [x] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request), Pull Request section? - [ ] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case. - [x] Did you make sure to update the documentation with your changes? Here are the [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation). - [x] Did you write any new necessary tests?
{ "login": "BenjaminBossan", "id": 6229650, "node_id": "MDQ6VXNlcjYyMjk2NTA=", "avatar_url": "https://avatars.githubusercontent.com/u/6229650?v=4", "gravatar_id": "", "url": "https://api.github.com/users/BenjaminBossan", "html_url": "https://github.com/BenjaminBossan", "followers_url": "https://api.github.com/users/BenjaminBossan/followers", "following_url": "https://api.github.com/users/BenjaminBossan/following{/other_user}", "gists_url": "https://api.github.com/users/BenjaminBossan/gists{/gist_id}", "starred_url": "https://api.github.com/users/BenjaminBossan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/BenjaminBossan/subscriptions", "organizations_url": "https://api.github.com/users/BenjaminBossan/orgs", "repos_url": "https://api.github.com/users/BenjaminBossan/repos", "events_url": "https://api.github.com/users/BenjaminBossan/events{/privacy}", "received_events_url": "https://api.github.com/users/BenjaminBossan/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41252/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41252/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41251
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41251/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41251/comments
https://api.github.com/repos/huggingface/transformers/issues/41251/events
https://github.com/huggingface/transformers/pull/41251
3,473,402,936
PR_kwDOCUB6oc6rjEpB
41,251
Add deepseek 3.2 exp
{ "login": "ArthurZucker", "id": 48595927, "node_id": "MDQ6VXNlcjQ4NTk1OTI3", "avatar_url": "https://avatars.githubusercontent.com/u/48595927?v=4", "gravatar_id": "", "url": "https://api.github.com/users/ArthurZucker", "html_url": "https://github.com/ArthurZucker", "followers_url": "https://api.github.com/users/ArthurZucker/followers", "following_url": "https://api.github.com/users/ArthurZucker/following{/other_user}", "gists_url": "https://api.github.com/users/ArthurZucker/gists{/gist_id}", "starred_url": "https://api.github.com/users/ArthurZucker/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/ArthurZucker/subscriptions", "organizations_url": "https://api.github.com/users/ArthurZucker/orgs", "repos_url": "https://api.github.com/users/ArthurZucker/repos", "events_url": "https://api.github.com/users/ArthurZucker/events{/privacy}", "received_events_url": "https://api.github.com/users/ArthurZucker/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
open
false
null
[]
null
[]
2025-10-01T12:41:21
2025-10-09T14:53:54
null
COLLABORATOR
null
null
true
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41251", "html_url": "https://github.com/huggingface/transformers/pull/41251", "diff_url": "https://github.com/huggingface/transformers/pull/41251.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41251.patch", "merged_at": null }
# What does this PR do? <!-- Congratulations! You've made it this far! You're not quite done yet though. Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution. Then, please replace this with a description of the change and which issue is fixed (if applicable). Please also include relevant motivation and context. List any dependencies (if any) that are required for this change. Once you're done, someone will review your PR shortly (see the section "Who can review?" below to tag some potential reviewers). They may suggest changes to make the code even better. If no one reviewed your PR after a week has passed, don't hesitate to post a new comment @-mentioning the same persons---sometimes notifications get lost. --> <!-- Remove if not applicable --> Fixes # (issue) ## Before submitting - [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [ ] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request), Pull Request section? - [ ] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case. - [ ] Did you make sure to update the documentation with your changes? Here are the [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation). - [ ] Did you write any new necessary tests? ## Who can review? Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR. <!-- Your PR will be replied to more quickly if you can figure out the right person to tag with @ If you know how to use git blame, that is the easiest way, otherwise, here is a rough guide of **who to tag**. Please tag fewer than 3 people. Models: - text models: @ArthurZucker @Cyrilvallez - vision models: @yonigozlan @molbap - audio models: @eustlb @ebezzam @vasqu - multimodal models: @zucchini-nlp - graph models: @clefourrier Library: - generate: @zucchini-nlp (visual-language models) or @gante (all others) - continuous batching: @remi-or @ArthurZucker @McPatate - pipelines: @Rocketknight1 - tokenizers: @ArthurZucker and @itazap - trainer: @zach-huggingface @SunMarc - attention: @vasqu @ArthurZucker @CyrilVallez - model loading (from pretrained, etc): @CyrilVallez - distributed: @3outeille @ArthurZucker @S1ro1 - CIs: @ydshieh Integrations: - deepspeed: HF Trainer/Accelerate: @SunMarc @zach-huggingface - ray/raytune: @richardliaw, @amogkam - Big Model Inference: @SunMarc - quantization (bitsandbytes, autogpt): @SunMarc @MekkCyber - kernels: @MekkCyber @drbh Devices/Backends: - AMD ROCm: @ivarflakstad - Intel XPU: @IlyasMoutawwakil - Ascend NPU: @ivarflakstad Documentation: @stevhliu Research projects are not maintained and should be taken as is. -->
null
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41251/reactions", "total_count": 2, "+1": 0, "-1": 0, "laugh": 0, "hooray": 1, "confused": 0, "heart": 0, "rocket": 1, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41251/timeline
null
null
null
null
true
false
https://api.github.com/repos/huggingface/transformers/issues/41250
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41250/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41250/comments
https://api.github.com/repos/huggingface/transformers/issues/41250/events
https://github.com/huggingface/transformers/pull/41250
3,473,233,423
PR_kwDOCUB6oc6rifFP
41,250
Validate config attributes
{ "login": "zucchini-nlp", "id": 100715397, "node_id": "U_kgDOBgDLhQ", "avatar_url": "https://avatars.githubusercontent.com/u/100715397?v=4", "gravatar_id": "", "url": "https://api.github.com/users/zucchini-nlp", "html_url": "https://github.com/zucchini-nlp", "followers_url": "https://api.github.com/users/zucchini-nlp/followers", "following_url": "https://api.github.com/users/zucchini-nlp/following{/other_user}", "gists_url": "https://api.github.com/users/zucchini-nlp/gists{/gist_id}", "starred_url": "https://api.github.com/users/zucchini-nlp/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/zucchini-nlp/subscriptions", "organizations_url": "https://api.github.com/users/zucchini-nlp/orgs", "repos_url": "https://api.github.com/users/zucchini-nlp/repos", "events_url": "https://api.github.com/users/zucchini-nlp/events{/privacy}", "received_events_url": "https://api.github.com/users/zucchini-nlp/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
open
false
null
[]
null
[]
2025-10-01T11:50:47
2025-10-09T17:11:01
null
MEMBER
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41250", "html_url": "https://github.com/huggingface/transformers/pull/41250", "diff_url": "https://github.com/huggingface/transformers/pull/41250.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41250.patch", "merged_at": null }
# What does this PR do? As per title. Continues from https://github.com/huggingface/transformers/pull/40793 and supersedes https://github.com/huggingface/transformers/pull/36534/files
null
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41250/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41250/timeline
null
null
null
null
true
false
https://api.github.com/repos/huggingface/transformers/issues/41249
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41249/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41249/comments
https://api.github.com/repos/huggingface/transformers/issues/41249/events
https://github.com/huggingface/transformers/pull/41249
3,473,083,219
PR_kwDOCUB6oc6rh9am
41,249
[`Flex Attn`] Fix lse x attention sinks logic
{ "login": "vasqu", "id": 73884904, "node_id": "MDQ6VXNlcjczODg0OTA0", "avatar_url": "https://avatars.githubusercontent.com/u/73884904?v=4", "gravatar_id": "", "url": "https://api.github.com/users/vasqu", "html_url": "https://github.com/vasqu", "followers_url": "https://api.github.com/users/vasqu/followers", "following_url": "https://api.github.com/users/vasqu/following{/other_user}", "gists_url": "https://api.github.com/users/vasqu/gists{/gist_id}", "starred_url": "https://api.github.com/users/vasqu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/vasqu/subscriptions", "organizations_url": "https://api.github.com/users/vasqu/orgs", "repos_url": "https://api.github.com/users/vasqu/repos", "events_url": "https://api.github.com/users/vasqu/events{/privacy}", "received_events_url": "https://api.github.com/users/vasqu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-01T11:07:50
2025-10-02T15:49:45
2025-10-02T15:49:40
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41249", "html_url": "https://github.com/huggingface/transformers/pull/41249", "diff_url": "https://github.com/huggingface/transformers/pull/41249.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41249.patch", "merged_at": "2025-10-02T15:49:40" }
We always return lse except for CPU #40352 (it simply isn't supported in torch yet) Let's rather raise a proper error for this than encountering a verbose torch exception
{ "login": "vasqu", "id": 73884904, "node_id": "MDQ6VXNlcjczODg0OTA0", "avatar_url": "https://avatars.githubusercontent.com/u/73884904?v=4", "gravatar_id": "", "url": "https://api.github.com/users/vasqu", "html_url": "https://github.com/vasqu", "followers_url": "https://api.github.com/users/vasqu/followers", "following_url": "https://api.github.com/users/vasqu/following{/other_user}", "gists_url": "https://api.github.com/users/vasqu/gists{/gist_id}", "starred_url": "https://api.github.com/users/vasqu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/vasqu/subscriptions", "organizations_url": "https://api.github.com/users/vasqu/orgs", "repos_url": "https://api.github.com/users/vasqu/repos", "events_url": "https://api.github.com/users/vasqu/events{/privacy}", "received_events_url": "https://api.github.com/users/vasqu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41249/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41249/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41248
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41248/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41248/comments
https://api.github.com/repos/huggingface/transformers/issues/41248/events
https://github.com/huggingface/transformers/pull/41248
3,473,041,499
PR_kwDOCUB6oc6rh0CQ
41,248
[`v5`] Sync Bert and Bart eager attention
{ "login": "vasqu", "id": 73884904, "node_id": "MDQ6VXNlcjczODg0OTA0", "avatar_url": "https://avatars.githubusercontent.com/u/73884904?v=4", "gravatar_id": "", "url": "https://api.github.com/users/vasqu", "html_url": "https://github.com/vasqu", "followers_url": "https://api.github.com/users/vasqu/followers", "following_url": "https://api.github.com/users/vasqu/following{/other_user}", "gists_url": "https://api.github.com/users/vasqu/gists{/gist_id}", "starred_url": "https://api.github.com/users/vasqu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/vasqu/subscriptions", "organizations_url": "https://api.github.com/users/vasqu/orgs", "repos_url": "https://api.github.com/users/vasqu/repos", "events_url": "https://api.github.com/users/vasqu/events{/privacy}", "received_events_url": "https://api.github.com/users/vasqu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 9105758243, "node_id": "LA_kwDOCUB6oc8AAAACHr7YIw", "url": "https://api.github.com/repos/huggingface/transformers/labels/for_v5?", "name": "for_v5?", "color": "35BC94", "default": false, "description": "" } ]
closed
false
null
[]
null
[]
2025-10-01T10:57:11
2025-10-06T16:49:06
2025-10-06T16:49:01
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41248", "html_url": "https://github.com/huggingface/transformers/pull/41248", "diff_url": "https://github.com/huggingface/transformers/pull/41248.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41248.patch", "merged_at": "2025-10-06T16:49:01" }
Syncs the eager attentions if those model groups to have less intertwined versions of essentially the same; sync goes from bert as being the primary source NOTE: Since it has a hard dependency on #41170, it should only come with v5 as well - do we still use the labels or just go for it since we have v4.57? cc @zucchini-nlp
{ "login": "vasqu", "id": 73884904, "node_id": "MDQ6VXNlcjczODg0OTA0", "avatar_url": "https://avatars.githubusercontent.com/u/73884904?v=4", "gravatar_id": "", "url": "https://api.github.com/users/vasqu", "html_url": "https://github.com/vasqu", "followers_url": "https://api.github.com/users/vasqu/followers", "following_url": "https://api.github.com/users/vasqu/following{/other_user}", "gists_url": "https://api.github.com/users/vasqu/gists{/gist_id}", "starred_url": "https://api.github.com/users/vasqu/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/vasqu/subscriptions", "organizations_url": "https://api.github.com/users/vasqu/orgs", "repos_url": "https://api.github.com/users/vasqu/repos", "events_url": "https://api.github.com/users/vasqu/events{/privacy}", "received_events_url": "https://api.github.com/users/vasqu/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41248/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41248/timeline
null
null
null
null
true
true
https://api.github.com/repos/huggingface/transformers/issues/41247
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41247/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41247/comments
https://api.github.com/repos/huggingface/transformers/issues/41247/events
https://github.com/huggingface/transformers/issues/41247
3,473,011,025
I_kwDOCUB6oc7PAfFR
41,247
Custom loss function for Qwen 2.5 VL 7b training
{ "login": "akhila1729", "id": 62430823, "node_id": "MDQ6VXNlcjYyNDMwODIz", "avatar_url": "https://avatars.githubusercontent.com/u/62430823?v=4", "gravatar_id": "", "url": "https://api.github.com/users/akhila1729", "html_url": "https://github.com/akhila1729", "followers_url": "https://api.github.com/users/akhila1729/followers", "following_url": "https://api.github.com/users/akhila1729/following{/other_user}", "gists_url": "https://api.github.com/users/akhila1729/gists{/gist_id}", "starred_url": "https://api.github.com/users/akhila1729/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/akhila1729/subscriptions", "organizations_url": "https://api.github.com/users/akhila1729/orgs", "repos_url": "https://api.github.com/users/akhila1729/repos", "events_url": "https://api.github.com/users/akhila1729/events{/privacy}", "received_events_url": "https://api.github.com/users/akhila1729/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[ { "id": 5769473378, "node_id": "LA_kwDOCUB6oc8AAAABV-MtYg", "url": "https://api.github.com/repos/huggingface/transformers/labels/Vision", "name": "Vision", "color": "C079EF", "default": false, "description": "" } ]
open
false
null
[]
null
[]
2025-10-01T10:45:47
2025-10-15T09:12:21
null
NONE
null
null
null
null
/raid/akhila/conda_envs/mswift/lib/python3.10/site-packages/transformers/models/qwen2_5_vl/modeling_qwen2_5_vl.py here there is self.loss_function under Qwen2_5_VLForConditionalGeneration class. I want to add a custom loss function which should be accessed from config. I am doing SFT training using mswift
null
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41247/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41247/timeline
null
null
{ "total": 0, "completed": 0, "percent_completed": 0 }
{ "blocked_by": 0, "total_blocked_by": 0, "blocking": 0, "total_blocking": 0 }
false
false
https://api.github.com/repos/huggingface/transformers/issues/41246
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41246/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41246/comments
https://api.github.com/repos/huggingface/transformers/issues/41246/events
https://github.com/huggingface/transformers/issues/41246
3,472,695,090
I_kwDOCUB6oc7O_R8y
41,246
Add Contribution Guidelines and License Section in README
{ "login": "dimpal-yadav", "id": 177777929, "node_id": "U_kgDOCpitCQ", "avatar_url": "https://avatars.githubusercontent.com/u/177777929?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dimpal-yadav", "html_url": "https://github.com/dimpal-yadav", "followers_url": "https://api.github.com/users/dimpal-yadav/followers", "following_url": "https://api.github.com/users/dimpal-yadav/following{/other_user}", "gists_url": "https://api.github.com/users/dimpal-yadav/gists{/gist_id}", "starred_url": "https://api.github.com/users/dimpal-yadav/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dimpal-yadav/subscriptions", "organizations_url": "https://api.github.com/users/dimpal-yadav/orgs", "repos_url": "https://api.github.com/users/dimpal-yadav/repos", "events_url": "https://api.github.com/users/dimpal-yadav/events{/privacy}", "received_events_url": "https://api.github.com/users/dimpal-yadav/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
open
false
null
[]
null
[]
2025-10-01T09:09:19
2025-10-05T18:48:32
null
NONE
null
null
null
null
Description Currently, the README.md does not have a Contribution section and the License section is either missing/not clearly visible. Adding these two sections will make the project more professional, contributor-friendly, and compliant with open-source standards. 🎯 Acceptance Criteria Contribution section added in README.md License section added in README.md Link to CONTRIBUTING.md and LICENSE file included
null
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41246/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41246/timeline
null
null
{ "total": 0, "completed": 0, "percent_completed": 0 }
{ "blocked_by": 0, "total_blocked_by": 0, "blocking": 0, "total_blocking": 0 }
false
false
https://api.github.com/repos/huggingface/transformers/issues/41245
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41245/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41245/comments
https://api.github.com/repos/huggingface/transformers/issues/41245/events
https://github.com/huggingface/transformers/issues/41245
3,472,690,845
I_kwDOCUB6oc7O_Q6d
41,245
Add Pull Request (PR) Template
{ "login": "dimpal-yadav", "id": 177777929, "node_id": "U_kgDOCpitCQ", "avatar_url": "https://avatars.githubusercontent.com/u/177777929?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dimpal-yadav", "html_url": "https://github.com/dimpal-yadav", "followers_url": "https://api.github.com/users/dimpal-yadav/followers", "following_url": "https://api.github.com/users/dimpal-yadav/following{/other_user}", "gists_url": "https://api.github.com/users/dimpal-yadav/gists{/gist_id}", "starred_url": "https://api.github.com/users/dimpal-yadav/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dimpal-yadav/subscriptions", "organizations_url": "https://api.github.com/users/dimpal-yadav/orgs", "repos_url": "https://api.github.com/users/dimpal-yadav/repos", "events_url": "https://api.github.com/users/dimpal-yadav/events{/privacy}", "received_events_url": "https://api.github.com/users/dimpal-yadav/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
open
false
null
[]
null
[]
2025-10-01T09:08:09
2025-10-14T04:46:14
null
NONE
null
null
null
null
Currently, the repository does not have a Pull Request (PR) template. This makes it harder for contributors to provide consistent information when opening PRs. Proposed Solution: Add a PR template file at .github/pull_request_template.md. The template should include: Description of changes Related issues (Fixes #issue) Screenshots (if applicable) Type of change (Bug fix, Feature, Enhancement, Documentation) Checklist (self-review, code style, documentation update) Benefits: Ensures all PRs have consistent structure. Helps maintainers review PRs faster. Improves contributor experience and professionalism of the project.
null
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41245/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41245/timeline
null
null
{ "total": 0, "completed": 0, "percent_completed": 0 }
{ "blocked_by": 0, "total_blocked_by": 0, "blocking": 0, "total_blocking": 0 }
false
false
https://api.github.com/repos/huggingface/transformers/issues/41244
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41244/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41244/comments
https://api.github.com/repos/huggingface/transformers/issues/41244/events
https://github.com/huggingface/transformers/issues/41244
3,472,687,891
I_kwDOCUB6oc7O_QMT
41,244
Add hacktoberfest-2025 Banner to README
{ "login": "dimpal-yadav", "id": 177777929, "node_id": "U_kgDOCpitCQ", "avatar_url": "https://avatars.githubusercontent.com/u/177777929?v=4", "gravatar_id": "", "url": "https://api.github.com/users/dimpal-yadav", "html_url": "https://github.com/dimpal-yadav", "followers_url": "https://api.github.com/users/dimpal-yadav/followers", "following_url": "https://api.github.com/users/dimpal-yadav/following{/other_user}", "gists_url": "https://api.github.com/users/dimpal-yadav/gists{/gist_id}", "starred_url": "https://api.github.com/users/dimpal-yadav/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/dimpal-yadav/subscriptions", "organizations_url": "https://api.github.com/users/dimpal-yadav/orgs", "repos_url": "https://api.github.com/users/dimpal-yadav/repos", "events_url": "https://api.github.com/users/dimpal-yadav/events{/privacy}", "received_events_url": "https://api.github.com/users/dimpal-yadav/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
open
false
null
[]
null
[]
2025-10-01T09:07:20
2025-10-04T06:31:58
null
NONE
null
null
null
null
The repository currently does not display any hacktoberfest-2025 banner in the README. Adding the banner will help highlight the project’s participation in hacktoberfest-2025 and increase visibility.
null
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41244/reactions", "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41244/timeline
null
null
{ "total": 0, "completed": 0, "percent_completed": 0 }
{ "blocked_by": 0, "total_blocked_by": 0, "blocking": 0, "total_blocking": 0 }
false
false
https://api.github.com/repos/huggingface/transformers/issues/41243
https://api.github.com/repos/huggingface/transformers
https://api.github.com/repos/huggingface/transformers/issues/41243/labels{/name}
https://api.github.com/repos/huggingface/transformers/issues/41243/comments
https://api.github.com/repos/huggingface/transformers/issues/41243/events
https://github.com/huggingface/transformers/pull/41243
3,472,614,183
PR_kwDOCUB6oc6rgWiW
41,243
Resolve remote custom module path warnings
{ "login": "XuehaiPan", "id": 16078332, "node_id": "MDQ6VXNlcjE2MDc4MzMy", "avatar_url": "https://avatars.githubusercontent.com/u/16078332?v=4", "gravatar_id": "", "url": "https://api.github.com/users/XuehaiPan", "html_url": "https://github.com/XuehaiPan", "followers_url": "https://api.github.com/users/XuehaiPan/followers", "following_url": "https://api.github.com/users/XuehaiPan/following{/other_user}", "gists_url": "https://api.github.com/users/XuehaiPan/gists{/gist_id}", "starred_url": "https://api.github.com/users/XuehaiPan/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/XuehaiPan/subscriptions", "organizations_url": "https://api.github.com/users/XuehaiPan/orgs", "repos_url": "https://api.github.com/users/XuehaiPan/repos", "events_url": "https://api.github.com/users/XuehaiPan/events{/privacy}", "received_events_url": "https://api.github.com/users/XuehaiPan/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
[]
closed
false
null
[]
null
[]
2025-10-01T08:44:09
2025-10-01T15:56:21
2025-10-01T15:55:43
CONTRIBUTOR
null
null
false
{ "url": "https://api.github.com/repos/huggingface/transformers/pulls/41243", "html_url": "https://github.com/huggingface/transformers/pull/41243", "diff_url": "https://github.com/huggingface/transformers/pull/41243.diff", "patch_url": "https://github.com/huggingface/transformers/pull/41243.patch", "merged_at": "2025-10-01T15:55:43" }
# What does this PR do? <!-- Congratulations! You've made it this far! You're not quite done yet though. Once merged, your PR is going to appear in the release notes with the title you set, so make sure it's a great title that fully reflects the extent of your awesome contribution. Then, please replace this with a description of the change and which issue is fixed (if applicable). Please also include relevant motivation and context. List any dependencies (if any) that are required for this change. Once you're done, someone will review your PR shortly (see the section "Who can review?" below to tag some potential reviewers). They may suggest changes to make the code even better. If no one reviewed your PR after a week has passed, don't hesitate to post a new comment @-mentioning the same persons---sometimes notifications get lost. --> <!-- Remove if not applicable --> Fixes https://github.com/huggingface/transformers/pull/40809#issuecomment-3354623703 ## Before submitting - [ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case). - [X] Did you read the [contributor guideline](https://github.com/huggingface/transformers/blob/main/CONTRIBUTING.md#create-a-pull-request), Pull Request section? - [X] Was this discussed/approved via a Github issue or the [forum](https://discuss.huggingface.co/)? Please add a link to it if that's the case. - [X] Did you make sure to update the documentation with your changes? Here are the [documentation guidelines](https://github.com/huggingface/transformers/tree/main/docs), and [here are tips on formatting docstrings](https://github.com/huggingface/transformers/tree/main/docs#writing-source-documentation). - [ ] Did you write any new necessary tests? ## Who can review? Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR. <!-- Your PR will be replied to more quickly if you can figure out the right person to tag with @ If you know how to use git blame, that is the easiest way, otherwise, here is a rough guide of **who to tag**. Please tag fewer than 3 people. Models: - text models: @ArthurZucker @Cyrilvallez - vision models: @yonigozlan @molbap - audio models: @eustlb @ebezzam @vasqu - multimodal models: @zucchini-nlp - graph models: @clefourrier Library: - generate: @zucchini-nlp (visual-language models) or @gante (all others) - continuous batching: @remi-or @ArthurZucker @McPatate - pipelines: @Rocketknight1 - tokenizers: @ArthurZucker and @itazap - trainer: @zach-huggingface @SunMarc - attention: @vasqu @ArthurZucker @CyrilVallez - model loading (from pretrained, etc): @CyrilVallez - distributed: @3outeille @ArthurZucker @S1ro1 - CIs: @ydshieh Integrations: - deepspeed: HF Trainer/Accelerate: @SunMarc @zach-huggingface - ray/raytune: @richardliaw, @amogkam - Big Model Inference: @SunMarc - quantization (bitsandbytes, autogpt): @SunMarc @MekkCyber - kernels: @MekkCyber @drbh Devices/Backends: - AMD ROCm: @ivarflakstad - Intel XPU: @IlyasMoutawwakil - Ascend NPU: @ivarflakstad Documentation: @stevhliu Research projects are not maintained and should be taken as is. --> cc @Rocketknight1 @st81
{ "login": "Rocketknight1", "id": 12866554, "node_id": "MDQ6VXNlcjEyODY2NTU0", "avatar_url": "https://avatars.githubusercontent.com/u/12866554?v=4", "gravatar_id": "", "url": "https://api.github.com/users/Rocketknight1", "html_url": "https://github.com/Rocketknight1", "followers_url": "https://api.github.com/users/Rocketknight1/followers", "following_url": "https://api.github.com/users/Rocketknight1/following{/other_user}", "gists_url": "https://api.github.com/users/Rocketknight1/gists{/gist_id}", "starred_url": "https://api.github.com/users/Rocketknight1/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/Rocketknight1/subscriptions", "organizations_url": "https://api.github.com/users/Rocketknight1/orgs", "repos_url": "https://api.github.com/users/Rocketknight1/repos", "events_url": "https://api.github.com/users/Rocketknight1/events{/privacy}", "received_events_url": "https://api.github.com/users/Rocketknight1/received_events", "type": "User", "user_view_type": "public", "site_admin": false }
{ "url": "https://api.github.com/repos/huggingface/transformers/issues/41243/reactions", "total_count": 2, "+1": 2, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 }
https://api.github.com/repos/huggingface/transformers/issues/41243/timeline
null
null
null
null
true
true