repo stringclasses 200
values | pull_number int64 13 143k | instance_id stringlengths 12 47 | issue_numbers listlengths 1 7 | base_commit stringlengths 40 40 | patch stringlengths 354 98.3k | test_patch stringlengths 137 8.74M | problem_statement stringlengths 142 63.8k | hints_text stringlengths 2 70.5k | all_hints_text stringlengths 2 70.5k | commit_urls listlengths 1 119 | created_at timestamp[s]date 2015-04-16 11:31:38 2025-12-17 10:26:03 | version stringclasses 196
values | language stringclasses 10
values |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
sveltejs/svelte | 10,846 | sveltejs__svelte-10846 | [
9517
] | 682f4a651351d4c0c492be1806bfb119b6bb76a7 | diff --git a/.changeset/smart-turkeys-tell.md b/.changeset/smart-turkeys-tell.md
new file mode 100644
index 000000000000..b4598ca14bc0
--- /dev/null
+++ b/.changeset/smart-turkeys-tell.md
@@ -0,0 +1,5 @@
+---
+"svelte": patch
+---
+
+fix: ensure select value is updated upon select element removal
diff --git a/packages/... | diff --git a/packages/svelte/tests/runtime-legacy/samples/binding-select-unmatched-3/_config.js b/packages/svelte/tests/runtime-legacy/samples/binding-select-unmatched-3/_config.js
new file mode 100644
index 000000000000..7c73cec9a2c5
--- /dev/null
+++ b/packages/svelte/tests/runtime-legacy/samples/binding-select-unmat... | Svelte 5: select value doesn't match bound value after removing option
### Describe the bug
When options are rendered from an array via an `#each` loop, and the selected item is removed from the array, no option should be selected since none match the bound value. This works as expected in Svelte 4, but in Svelte 5 ... | I'm unsure what the correct behavior should be here. Should the selected option be updated, or should it be out of sync?
I would suggest making it behave like v4 for compatibility.
It can just be the responsibility of whoever removes the option to also update the selection/value if necessary/desired.
I agree the beh... | I'm unsure what the correct behavior should be here. Should the selected option be updated, or should it be out of sync?
I would suggest making it behave like v4 for compatibility.
It can just be the responsibility of whoever removes the option to also update the selection/value if necessary/desired.
I agree the beh... | [
"https://github.com/sveltejs/svelte/commit/2e795f6f4787be61291108406d767dc486eed27a",
"https://github.com/sveltejs/svelte/commit/8c95d9b176c62d4e49d8a644e208a7f065d8ed9d",
"https://github.com/sveltejs/svelte/commit/691ebf96e313e595621ba1acb496486147b60d54"
] | 2024-03-19T21:11:44 | 0.0 | JavaScript |
sveltejs/svelte | 13,646 | sveltejs__svelte-13646 | [
13645
] | 372884cf99420dd9d343a4ad78f6aa540a4df289 | diff --git a/.changeset/eight-pans-worry.md b/.changeset/eight-pans-worry.md
new file mode 100644
index 000000000000..61c970b97f4e
--- /dev/null
+++ b/.changeset/eight-pans-worry.md
@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: transitions within dynamic components now function correctly
diff --git a/packages/svel... | diff --git a/packages/svelte/tests/runtime-runes/samples/transition-component/Foo.svelte b/packages/svelte/tests/runtime-runes/samples/transition-component/Foo.svelte
new file mode 100644
index 000000000000..eef87a1ec5ef
--- /dev/null
+++ b/packages/svelte/tests/runtime-runes/samples/transition-component/Foo.svelte
@@ ... | Svelte 5: animation not triggered when component imported from index
### Describe the bug
Both lines are the same component. The difference is that the first one uses import from index.ts file and the 2nd uses direct import from .svelte file
https://github.com/user-attachments/assets/d5bbd0a2-9b55-47b2-a3d9-d5e06... | Hello,
It's seem that the problem come from `$.component()`, as `import { Item as FooItem } from "./foo.js";` works fine.
Here a reproduction on the REPL : https://svelte-5-preview.vercel.app/#H4sIAAAAAAAACo2TTW_cIBCG_8qIVtrdKrLbQy_UdpNDIvXQU491D2g93hLZgGC8aoT47wX8ke02_cAHM8zLvDB68KyXAzrGv3qmxIiMsztj2A2jJ5MCd8aBM... | Hello,
It's seem that the problem come from `$.component()`, as `import { Item as FooItem } from "./foo.js";` works fine.
Here a reproduction on the REPL : https://svelte-5-preview.vercel.app/#H4sIAAAAAAAACo2TTW_cIBCG_8qIVtrdKrLbQy_UdpNDIvXQU491D2g93hLZgGC8aoT47wX8ke02_cAHM8zLvDB68KyXAzrGv3qmxIiMsztj2A2jJ5MCd8aBM... | [
"https://github.com/sveltejs/svelte/commit/37ccf609aafb9d2f92128e0b86f0099a8b74aa3d",
"https://github.com/sveltejs/svelte/commit/0b0371d378e2c473b820bacfb1d3b8907ed4e865",
"https://github.com/sveltejs/svelte/commit/cb7f39df5455ebd6f96bf1845f797d67e03f436b"
] | 2024-10-17T12:57:39 | 0.0 | JavaScript |
sveltejs/svelte | 15,283 | sveltejs__svelte-15283 | [
15281
] | 21dadfc997c5572730e607bd98d513437215dd06 | diff --git a/.changeset/lovely-chairs-compete.md b/.changeset/lovely-chairs-compete.md
new file mode 100644
index 000000000000..d311a3dde6f0
--- /dev/null
+++ b/.changeset/lovely-chairs-compete.md
@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: prevent writable store value from becoming a proxy when reassigning usin... | diff --git a/packages/svelte/tests/runtime-runes/samples/store-reassign-object/_config.js b/packages/svelte/tests/runtime-runes/samples/store-reassign-object/_config.js
new file mode 100644
index 000000000000..f9a329889d21
--- /dev/null
+++ b/packages/svelte/tests/runtime-runes/samples/store-reassign-object/_config.js
... | Reassigning an object to a writable store using $-prefix causes its value to become a proxy in runes mode
### Describe the bug
related #15280
When writing a Svelte component like the following in runes mode...
```svelte
<script>
import { writable } from 'svelte/store';
let obj = writable({ name: 'foo'});
const... | Is it possible for store to return proxy always?
From us, user sight, store looks to return original object or proxy unpredictably. If it was proxy always, we could avoid "lucky shot" and deal with improper usage from the beginning. How about doing so in dev mode at least?
I also tested the behavior in Svelte 4 and ob... | [
"https://github.com/sveltejs/svelte/commit/542cda3f6853838ea18cf8465a4d14c809829915",
"https://github.com/sveltejs/svelte/commit/8b326b0ea77a2614869212c05e2832d531025010",
"https://github.com/sveltejs/svelte/commit/5aa2b7c8b5105940bfbaaf7d755ac0cf8cf8e90c"
] | 2025-02-13T10:14:07 | 0.0 | JavaScript | |
sveltejs/svelte | 12,949 | sveltejs__svelte-12949 | [
12807,
12900
] | af35fb7ae6be1d4b4dea00c7e49379e7bbd7d3c6 | diff --git a/.changeset/spotty-trees-provide.md b/.changeset/spotty-trees-provide.md
new file mode 100644
index 000000000000..0652fda04959
--- /dev/null
+++ b/.changeset/spotty-trees-provide.md
@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: more robust handling of var declarations
diff --git a/packages/svelte/src/c... | diff --git a/packages/svelte/tests/runtime-runes/samples/var-declarations/_config.js b/packages/svelte/tests/runtime-runes/samples/var-declarations/_config.js
new file mode 100644
index 000000000000..46349dd2dcd3
--- /dev/null
+++ b/packages/svelte/tests/runtime-runes/samples/var-declarations/_config.js
@@ -0,0 +1,7 @@... | Svelte 5: using `var` with `$state` is brittle
### Describe the bug
State declarations are transformed thusly:
```diff
-let count = $state(0);
+let count = $.source(0);
```
If we tried to `console.log(count)` before the declaration, we would get a TDZ error:
> Can't access lexical declaration 'count' befor... | Can't we statically detect it's referenced before and just statically compile the read to `undefined`?
Not trivially:
```js
var a = get_b(), b = $state();
function get_b() {
return b; // we certainly can't compile this to `undefined`
}
```
With sufficiently sophisticated static analysis we could determin... | Can't we statically detect it's referenced before and just statically compile the read to `undefined`?
Not trivially:
```js
var a = get_b(), b = $state();
function get_b() {
return b; // we certainly can't compile this to `undefined`
}
```
With sufficiently sophisticated static analysis we could determin... | [
"https://github.com/sveltejs/svelte/commit/e0c73ab3b35583ce5bf4579eb0f1231ddaf69428",
"https://github.com/sveltejs/svelte/commit/77c528c8e07d03b3daa17981ecd4574139c29f6b"
] | 2024-08-21T10:47:04 | 0.0 | JavaScript |
sveltejs/svelte | 10,114 | sveltejs__svelte-10114 | [
10104
] | 6acf7f3fc3609c28395c77d7953a66509c857db5 | diff --git a/.changeset/slimy-walls-draw.md b/.changeset/slimy-walls-draw.md
new file mode 100644
index 000000000000..fd0ec42dd0ec
--- /dev/null
+++ b/.changeset/slimy-walls-draw.md
@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: correctly call exported state
diff --git a/packages/svelte/src/compiler/phases/3-transf... | diff --git a/packages/svelte/tests/runtime-runes/samples/ambiguous-source/_config.js b/packages/svelte/tests/runtime-runes/samples/ambiguous-source/_config.js
index 046603c063fa..2775015dffd9 100644
--- a/packages/svelte/tests/runtime-runes/samples/ambiguous-source/_config.js
+++ b/packages/svelte/tests/runtime-runes/s... | Svelte 5: Signals are exposed when exporting $state from svelte component
### Describe the bug
It's a bit obscure, but you can access the raw signal when doing this:
*App.svelte*
```svelte
<script>
import Counter from './Counter.svelte'
let counter = $state();
if (counter) console.log(counter.exportedCo... | [
"https://github.com/sveltejs/svelte/commit/07af262f49dea89266727dc2606e896c6e81a9c4"
] | 2024-01-08T13:24:34 | 0.0 | JavaScript | ||
nodejs/undici | 3,495 | nodejs__undici-3495 | [
3410,
3493
] | b7254574e54d135d41baa5193f89007e78a3c710 | diff --git a/benchmarks/timers/compare-timer-getters.mjs b/benchmarks/timers/compare-timer-getters.mjs
new file mode 100644
index 00000000000..aadff558f1f
--- /dev/null
+++ b/benchmarks/timers/compare-timer-getters.mjs
@@ -0,0 +1,18 @@
+import { bench, group, run } from 'mitata'
+
+group('timers', () => {
+ bench('Dat... | diff --git a/test/issue-3410.js b/test/issue-3410.js
new file mode 100644
index 00000000000..d5bb8093ef2
--- /dev/null
+++ b/test/issue-3410.js
@@ -0,0 +1,88 @@
+'use strict'
+
+const { tspl } = require('@matteo.collina/tspl')
+const { fork } = require('node:child_process')
+const { resolve: pathResolve } = require('no... | `UND_ERR_CONNECT_TIMEOUT` errors thrown when there is CPU intensive code on the event loop
## Bug Description
Work on the event loop can interrupt the Undici lifecycle for making requests, causing errors to be thrown even when there is no problem with the underlying connection. For example, if a fetch request is sta... | I think something like this would also do the trick:
```js
diff --git a/lib/util/timers.js b/lib/util/timers.js
index d0091cc1..fa56be8b 100644
--- a/lib/util/timers.js
+++ b/lib/util/timers.js
@@ -2,13 +2,13 @@
const TICK_MS = 499
-let fastNow = Date.now()
+let fastNow = 0
let fastNowTimeout
c... | I think something like this would also do the trick:
```js
diff --git a/lib/util/timers.js b/lib/util/timers.js
index d0091cc1..fa56be8b 100644
--- a/lib/util/timers.js
+++ b/lib/util/timers.js
@@ -2,13 +2,13 @@
const TICK_MS = 499
-let fastNow = Date.now()
+let fastNow = 0
let fastNowTimeout
c... | [
"https://github.com/nodejs/undici/commit/a36e1843b3625424c43967278f5d9f59707714b5",
"https://github.com/nodejs/undici/commit/50cc05d3d212325fae04d816273e9c2fc61e3fe5",
"https://github.com/nodejs/undici/commit/4c75ee3cdec967aab2dc85267395058a38fbc172",
"https://github.com/nodejs/undici/commit/5f275eb3051dd959b... | 2024-08-23T14:56:16 | 4.15 | JavaScript |
nodejs/undici | 2,344 | nodejs__undici-2344 | [
2343
] | 026c1d5ffc38017425fd4e477bf1241f7841afc7 | diff --git a/lib/api/readable.js b/lib/api/readable.js
index 508fbdef928..d106568cd4b 100644
--- a/lib/api/readable.js
+++ b/lib/api/readable.js
@@ -268,7 +268,7 @@ function consumeEnd (consume) {
pos += buf.byteLength
}
- resolve(dst)
+ resolve(dst.buffer)
} else if (type === 'blob') {... | diff --git a/test/client-request.js b/test/client-request.js
index 703cedf6803..3e6670523b8 100644
--- a/test/client-request.js
+++ b/test/client-request.js
@@ -413,7 +413,7 @@ test('request blob', { skip: nodeMajor < 16 }, (t) => {
})
test('request arrayBuffer', (t) => {
- t.plan(1)
+ t.plan(2)
const obj = ... | body mixin returns Uint8Array instead of ArrayBuffer
## Bug Description
According to the documentation the body mixin arrayBuffer() should return Promise<ArrayBuffer>, however it returns Promise<Uint8Array>.
References:
https://github.com/nodejs/undici/blob/main/docs/api/Dispatcher.md#dispatcherrequestoptions-ca... | Reproduced on undici@5.26.3
```
> let promiseBuffer = response.body.arrayBuffer()
undefined
> promiseBuffer
Promise {
Uint8Array(336) [
...
],
[Symbol(async_id_symbol)]: 1095,
[Symbol(trigger_async_id_symbol)]: 6
}
>
```
| Reproduced on undici@5.26.3
```
> let promiseBuffer = response.body.arrayBuffer()
undefined
> promiseBuffer
Promise {
Uint8Array(336) [
...
],
[Symbol(async_id_symbol)]: 1095,
[Symbol(trigger_async_id_symbol)]: 6
}
>
```
| [
"https://github.com/nodejs/undici/commit/1afabf0fe5301337ae33a70c2f63e920aa6b874b"
] | 2023-10-12T17:32:23 | 4.15 | JavaScript |
nodejs/undici | 4,031 | nodejs__undici-4031 | [
3959
] | c7f3d77011234fe243c317ada1398044032342cc | diff --git a/lib/cache/memory-cache-store.js b/lib/cache/memory-cache-store.js
index dd5ac00b5a3..6fa7356b366 100644
--- a/lib/cache/memory-cache-store.js
+++ b/lib/cache/memory-cache-store.js
@@ -79,7 +79,13 @@ class MemoryCacheStore {
const entry = this.#entries.get(topLevelKey)?.find((entry) => (
entry.d... | diff --git a/test/cache-interceptor/utils.js b/test/cache-interceptor/utils.js
index 2fc8bc17dea..2ae75d15489 100644
--- a/test/cache-interceptor/utils.js
+++ b/test/cache-interceptor/utils.js
@@ -214,6 +214,40 @@ describe('parseVaryHeader', () => {
'another-one': '123'
})
})
+
+ test('handles missing h... | Response headers `vary: Accept-Encoding` is stopping undici from caching the http request
## Bug Description
I was trying to try out undici cache with the following code snippets:
```ts
import undici, {
interceptors,
Agent,
setGlobalDispatcher
} from 'undici';
setGlobalDispatcher(agent.compose(
interceptors.... | Many CDNs will always return the `Vary: Accept-Encoding` header whether the HTTP client is sending an `Accept-Encoding` request header or not. However `undici.request` doesn't include `Accept-Encoding` and gzip & br decompression.
Same for GitHub RAW. GitHub RAW always returns `Vary: Authorization,Accept-Encoding,Orig... | Many CDNs will always return the `Vary: Accept-Encoding` header whether the HTTP client is sending an `Accept-Encoding` request header or not. However `undici.request` doesn't include `Accept-Encoding` and gzip & br decompression.
Same for GitHub RAW. GitHub RAW always returns `Vary: Authorization,Accept-Encoding,Orig... | [
"https://github.com/nodejs/undici/commit/5a94cf080c619443b9ea359c972cb2c0af9c664a",
"https://github.com/nodejs/undici/commit/d6fcb21664b0c06c2966801a0319dbf60e496be5"
] | 2025-01-27T21:04:25 | 4.15 | JavaScript |
nodejs/undici | 2,432 | nodejs__undici-2432 | [
2431
] | f996014708489a81f4c5f0bb803ebe2835b5f7de | diff --git a/lib/fetch/headers.js b/lib/fetch/headers.js
index f37c5c99e03..035560428bc 100644
--- a/lib/fetch/headers.js
+++ b/lib/fetch/headers.js
@@ -190,7 +190,7 @@ class HeadersList {
// the first such header to value and remove the
// others.
// 2. Otherwise, append header (name, value) to li... | diff --git a/test/fetch/headers.js b/test/fetch/headers.js
index c4b4e03d297..5da1a1ded1f 100644
--- a/test/fetch/headers.js
+++ b/test/fetch/headers.js
@@ -250,7 +250,7 @@ tap.test('Headers has', t => {
})
tap.test('Headers set', t => {
- t.plan(4)
+ t.plan(5)
t.test('sets valid header entry to instance', t... | `Headers#set` returns `Map`
## Bug Description
<!-- A clear and concise description of what the bug is. -->
`Headers#set` returns `Map`
## Reproducible By
<!-- A step by step list on how the bug can be reproduced for examination. -->
```js
console.log(new Headers().set("x", "0") instanceof Map); // true... | [
"https://github.com/nodejs/undici/commit/91cac31f795409b3a729ac67f53f287aa37bda8c",
"https://github.com/nodejs/undici/commit/ea135c8f1d9022531a26ee26764f1374448bdb0e",
"https://github.com/nodejs/undici/commit/013d1e94a906b191dd0a0ffb469dde42f69db225",
"https://github.com/nodejs/undici/commit/2faa1297a66de0448... | 2023-11-13T09:35:53 | 4.15 | JavaScript | ||
nodejs/undici | 2,545 | nodejs__undici-2545 | [
2543
] | 4ed060feb0a9d77ff0e57fa0643653b6cfa13d11 | diff --git a/lib/fetch/index.js b/lib/fetch/index.js
index 54dc6f35b18..f16ce4b4536 100644
--- a/lib/fetch/index.js
+++ b/lib/fetch/index.js
@@ -1206,7 +1206,7 @@ async function httpFetch (fetchParams) {
// encouraged to, transmit an RST_STREAM frame.
// See, https://github.com/whatwg/fetch/issues/1288
i... | diff --git a/test/fetch/redirect.js b/test/fetch/redirect.js
index 7e3681b3d23..dd90418880c 100644
--- a/test/fetch/redirect.js
+++ b/test/fetch/redirect.js
@@ -48,3 +48,29 @@ test('Redirecting with an empty body does not throw an error - #2027', async (t)
t.equal(await resp.text(), '/redirect/')
t.ok(resp.redire... | fetch fails with RequestContentLengthMismatchError when following redirect
## Bug Description
`fetch` fails with a `RequestContentLengthMismatchError` error when following a redirect under the following conditions:
* The request has a body.
* The redirect preserves the body, e.g. 307 temporary redirects.
* The ... | cc @KhafraDev
PR would be appreciated.
PR sent @KhafraDev: https://github.com/nodejs/undici/pull/2545
| cc @KhafraDev
PR would be appreciated.
PR sent @KhafraDev: https://github.com/nodejs/undici/pull/2545
| [
"https://github.com/nodejs/undici/commit/5b0771072e22638c36e94da01d1020e428e452f3"
] | 2023-12-26T16:29:27 | 4.15 | JavaScript |
vuejs/eslint-plugin-vue | 2,221 | vuejs__eslint-plugin-vue-2221 | [
2220
] | e944bb8ed51be4c3605773586416e28c8b153b4a | diff --git a/lib/rules/no-console.js b/lib/rules/no-console.js
index cf4254035..5c5e8b5e0 100644
--- a/lib/rules/no-console.js
+++ b/lib/rules/no-console.js
@@ -8,6 +8,7 @@ const utils = require('../utils')
// eslint-disable-next-line no-invalid-meta, no-invalid-meta-docs-categories
module.exports = utils.wrapCoreR... | diff --git a/tests/lib/rules/no-console.js b/tests/lib/rules/no-console.js
index a0c273042..7b6acfeab 100644
--- a/tests/lib/rules/no-console.js
+++ b/tests/lib/rules/no-console.js
@@ -53,6 +53,15 @@ tester.run('no-console', rule, {
</template>
`,
options: [{ allow: ['log', 'warn', 'info'] }]
+ ... | [Bug] `vue/no-console` affects code in `<script>`
`vue/no-console` is supposed to only check code in the `<template>`.
Repro: https://github.com/wenfangdu/vite-vue-3/tree/vue/no-console
| Seems to have been overlooked in #2194. @ItMaga would you fancy to restrict the rule to the `<template>` block? Please also add a test case.
Yes, I'll fix that. Thank you!
| Seems to have been overlooked in #2194. @ItMaga would you fancy to restrict the rule to the `<template>` block? Please also add a test case.
Yes, I'll fix that. Thank you!
| [
"https://github.com/vuejs/eslint-plugin-vue/commit/3c2d0590b00efc6828e5600049a28bccb5344bde",
"https://github.com/vuejs/eslint-plugin-vue/commit/4efc651c698e355fed11f394a81bc7c91a770da7"
] | 2023-06-19T14:36:20 | 6.2 | JavaScript |
vuejs/eslint-plugin-vue | 2,301 | vuejs__eslint-plugin-vue-2301 | [
2299
] | 15b99af0552c89b5f94667cf5e2a0a92f603d08d | diff --git a/lib/rules/component-name-in-template-casing.js b/lib/rules/component-name-in-template-casing.js
index fc1849b18..487af7714 100644
--- a/lib/rules/component-name-in-template-casing.js
+++ b/lib/rules/component-name-in-template-casing.js
@@ -123,7 +123,8 @@ module.exports = {
if (
(!utils.isH... | diff --git a/tests/lib/rules/component-name-in-template-casing.js b/tests/lib/rules/component-name-in-template-casing.js
index 3aa4ee43d..992063808 100644
--- a/tests/lib/rules/component-name-in-template-casing.js
+++ b/tests/lib/rules/component-name-in-template-casing.js
@@ -86,6 +86,10 @@ tester.run('component-name-i... | `vue/component-name-in-template-casing`: ignore `<component>` built-in element
<!--
Before proposing rule changes, please make sure it hasn't been posted already.
You can see all open propositions here:
https://github.com/vuejs/eslint-plugin-vue/issues?q=is%3Aopen+is%3Aissue+label%3A%22new+rule+proposition%22
... | [
"https://github.com/vuejs/eslint-plugin-vue/commit/a999b34a4611297a4a70a144cd47fe86b991fa33",
"https://github.com/vuejs/eslint-plugin-vue/commit/b3c724a2bf6ac31a1cade01c61c41e064869eaea",
"https://github.com/vuejs/eslint-plugin-vue/commit/53d3ba076432e302abd62776c40979d55bb60106"
] | 2023-10-24T03:17:47 | 6.2 | JavaScript | ||
vuejs/eslint-plugin-vue | 2,198 | vuejs__eslint-plugin-vue-2198 | [
2188
] | 13167ed832f1171112b8906d1b39709c441b4f68 | diff --git a/docs/rules/index.md b/docs/rules/index.md
index c3e4b8ed7..d6469f3e0 100644
--- a/docs/rules/index.md
+++ b/docs/rules/index.md
@@ -262,6 +262,7 @@ For example:
| [vue/require-direct-export](./require-direct-export.md) | require the component to be directly exported | | :hammer: |
| [vue/require-emit-va... | diff --git a/tests/lib/rules/require-macro-variable-name.js b/tests/lib/rules/require-macro-variable-name.js
new file mode 100644
index 000000000..c54c224a5
--- /dev/null
+++ b/tests/lib/rules/require-macro-variable-name.js
@@ -0,0 +1,324 @@
+/**
+ * @author ItMaga
+ * See LICENSE file in root directory for full licens... | New rule `vue/require-macro-variable-name`
**What rule do you want to change?**
New config fields:
- Require using a defined name for the `define*` variable (e.g. `{ "name": "props" }`)
- Require name prefix in html (not for `vue/define-emits-declaration` e.g. `{ "prefix": true }`)
**Does this change cause the ru... | Those are two different requests. The second one sounds like #2172; this should not be part of the `vue/define-*-declaration` rules.
The first one sounds good, but might also be better suited as a new rule (one for all, with good defaults). I suggest the name `vue/require-macro-variable-name` with one options object... | Those are two different requests. The second one sounds like #2172; this should not be part of the `vue/define-*-declaration` rules.
The first one sounds good, but might also be better suited as a new rule (one for all, with good defaults). I suggest the name `vue/require-macro-variable-name` with one options object... | [
"https://github.com/vuejs/eslint-plugin-vue/commit/5303bd68c4087c485e387f3c0164be1b0f007824",
"https://github.com/vuejs/eslint-plugin-vue/commit/3f3bcb251d629e0cb85e57a1b77dc73c7225e335",
"https://github.com/vuejs/eslint-plugin-vue/commit/abdeaa729c42423e5501d362e3cdd54d4c931930",
"https://github.com/vuejs/es... | 2023-05-30T22:44:28 | 6.2 | JavaScript |
vuejs/eslint-plugin-vue | 2,110 | vuejs__eslint-plugin-vue-2110 | [
2109
] | 77af4b4c43b5afbe2b58f2d67e117597c24a451d | diff --git a/docs/rules/enforce-style-attribute.md b/docs/rules/enforce-style-attribute.md
new file mode 100644
index 000000000..6dc042353
--- /dev/null
+++ b/docs/rules/enforce-style-attribute.md
@@ -0,0 +1,86 @@
+---
+pageClass: rule-details
+sidebarDepth: 0
+title: vue/enforce-style-attribute
+description: enforce o... | diff --git a/tests/lib/rules/enforce-style-attribute.js b/tests/lib/rules/enforce-style-attribute.js
new file mode 100644
index 000000000..994b785ed
--- /dev/null
+++ b/tests/lib/rules/enforce-style-attribute.js
@@ -0,0 +1,148 @@
+/**
+ * @author Mussin Benarbia
+ * See LICENSE file in root directory for full license.
... | Rule Proposal: `vue/enforce-style-attribute`
<!--
Before proposing new rule, please make sure it hasn't been posted already.
You can see all open propositions here:
https://github.com/vuejs/eslint-plugin-vue/issues?q=is%3Aopen+is%3Aissue+label%3A%22new+rule+proposition%22
-->
**Please describe what the rul... | Thank you for the rule proposal.
Sounds good to me.
However, I think your proposed rule is a little too strict.
Also, I have a similar rule available in another plugin.
https://future-architect.github.io/eslint-plugin-vue-scoped-css/rules/enforce-style-type.html
`eslint-plugin-vue-scoped-css`'s rule can use arra... | [
"https://github.com/vuejs/eslint-plugin-vue/commit/d36bf2c61d50b5553567441e2b246bd6061a16fb",
"https://github.com/vuejs/eslint-plugin-vue/commit/e9ea5b1009ae5a6c5df6f7a305274a0b1905dae5",
"https://github.com/vuejs/eslint-plugin-vue/commit/06ba377540cce324e6535560ef7da6458c38e5f6",
"https://github.com/vuejs/es... | 2023-03-21T08:44:54 | 6.2 | JavaScript | |
vuejs/eslint-plugin-vue | 2,275 | vuejs__eslint-plugin-vue-2275 | [
2263
] | 8ba6d9a19dcf431b4ab048732c7d8a50c5b3a884 | diff --git a/lib/rules/prefer-define-options.js b/lib/rules/prefer-define-options.js
index cd9240445..90c83fa9a 100644
--- a/lib/rules/prefer-define-options.js
+++ b/lib/rules/prefer-define-options.js
@@ -34,9 +34,14 @@ module.exports = {
let defineOptionsNode = null
/** @type {ExportDefaultDeclaration | null... | diff --git a/tests/lib/rules/prefer-define-options.js b/tests/lib/rules/prefer-define-options.js
index 2fd9bdfec..f3d9d88b0 100644
--- a/tests/lib/rules/prefer-define-options.js
+++ b/tests/lib/rules/prefer-define-options.js
@@ -104,6 +104,32 @@ defineOptions({ name: 'Foo' })
line: 4
}
]
+ ... | `prefer-define-options` should insert `defineOptions` after import expressions
<!--
Before proposing rule changes, please make sure it hasn't been posted already.
You can see all open propositions here:
https://github.com/vuejs/eslint-plugin-vue/issues?q=is%3Aopen+is%3Aissue+label%3A%22new+rule+proposition%22
... | PR welcome :slightly_smiling_face:
| PR welcome :slightly_smiling_face:
| [
"https://github.com/vuejs/eslint-plugin-vue/commit/8bb8e0b58fefb34287f9837733edcb53276cd55a",
"https://github.com/vuejs/eslint-plugin-vue/commit/055be647515ff2e1b08014c647209955470352a2",
"https://github.com/vuejs/eslint-plugin-vue/commit/5b9d329bc12ec18ef4411fa52e65917651c2f615",
"https://github.com/vuejs/es... | 2023-08-15T16:11:21 | 6.2 | JavaScript |
camunda/camunda-modeler | 4,169 | camunda__camunda-modeler-4169 | [
4102
] | fdd9ec61d24ba15fb85e7219ca4c46a5852bf079 | diff --git a/app/lib/zeebe-api/zeebe-api.js b/app/lib/zeebe-api/zeebe-api.js
index 52e2de9fd3..7dd06f57aa 100644
--- a/app/lib/zeebe-api/zeebe-api.js
+++ b/app/lib/zeebe-api/zeebe-api.js
@@ -66,6 +66,7 @@ const RESOURCE_TYPES = {
* @property {'oauth'} type
* @property {string} url
* @property {string} audience
+ ... | diff --git a/app/test/spec/zeebe-api/zeebe-api-spec.js b/app/test/spec/zeebe-api/zeebe-api-spec.js
index 7757a63ad7..f621d28f5e 100644
--- a/app/test/spec/zeebe-api/zeebe-api-spec.js
+++ b/app/test/spec/zeebe-api/zeebe-api-spec.js
@@ -1210,6 +1210,59 @@ describe('ZeebeAPI', function() {
});
+ describe('OAut... | Add OAuth scope field to deploy modal
_Related to https://github.com/camunda/product-hub/issues/2089._
### Problem you would like to solve
As a user, I want to be able to deploy to Zeebe clusters that use OAuth2 as authentication mechanism with a provider that requires a `scope` in the token request, e.g. Microso... | We'd need [zeebe-node](https://github.com/camunda-community-hub/zeebe-client-node-js) to support passing a custom `scope` within the token request and this [seems to be not implemented (yet)](https://github.com/search?q=repo%3Acamunda-community-hub%2Fzeebe-client-node-js+scope&type=code). So as it stands we're currentl... | We'd need [zeebe-node](https://github.com/camunda-community-hub/zeebe-client-node-js) to support passing a custom `scope` within the token request and this [seems to be not implemented (yet)](https://github.com/search?q=repo%3Acamunda-community-hub%2Fzeebe-client-node-js+scope&type=code). So as it stands we're currentl... | [
"https://github.com/camunda/camunda-modeler/commit/7216740d6d8a6eae2d16e16bac64cbe37c5c6185",
"https://github.com/camunda/camunda-modeler/commit/0422c9c240a9343943e3420a236c6352d86691f6",
"https://github.com/camunda/camunda-modeler/commit/519764b3ed1be88f86df5f17e6f85355f6fb334f"
] | 2024-03-01T13:54:35 | 3.0 | JavaScript |
camunda/camunda-modeler | 4,372 | camunda__camunda-modeler-4372 | [
4245,
4369
] | 467cc666fca8018ee7f26d5122d69363e441bf9c | diff --git a/client/src/plugins/privacy-preferences/PrivacyPreferencesView.js b/client/src/plugins/privacy-preferences/PrivacyPreferencesView.js
index 404ceca0db..0933ebbec4 100644
--- a/client/src/plugins/privacy-preferences/PrivacyPreferencesView.js
+++ b/client/src/plugins/privacy-preferences/PrivacyPreferencesView.... | diff --git a/client/src/plugins/privacy-preferences/__tests__/PrivacyPreferencesViewSpec.js b/client/src/plugins/privacy-preferences/__tests__/PrivacyPreferencesViewSpec.js
index 1ec230965d..2f573b632c 100644
--- a/client/src/plugins/privacy-preferences/__tests__/PrivacyPreferencesViewSpec.js
+++ b/client/src/plugins/p... | Element template documentation link has odd coloring
### Describe the bug
Consider the colors of links in the modeler UI (different), where the properties panel link has an odd (not matching the existing color scheme) color:
 is integrated in the Modeler app.
@holygeek00 Find my feedback on the fix [here](https://github.com/bpmn-io/bpmn-js-element-templates... | @holygeek00 We usually move issues that are _fixed upstream_ to the respective column on our board. An issue in Camunda Modeler is only closed once the fix (and upstream library release) is integrated in the Modeler app.
@holygeek00 Find my feedback on the fix [here](https://github.com/bpmn-io/bpmn-js-element-templates... | [
"https://github.com/camunda/camunda-modeler/commit/ce276b020ac10896d8af570b1d01674db4faeac6"
] | 2024-06-17T09:20:23 | 3.0 | JavaScript |
camunda/camunda-modeler | 5,238 | camunda__camunda-modeler-5238 | [
5222
] | f8861c8fb5d939a49a211a7dd584bdd1ba64134f | diff --git a/client/src/plugins/privacy-preferences/PrivacyPreferences.js b/client/src/plugins/privacy-preferences/PrivacyPreferences.js
index e7f8406533..4ee1b1eb74 100644
--- a/client/src/plugins/privacy-preferences/PrivacyPreferences.js
+++ b/client/src/plugins/privacy-preferences/PrivacyPreferences.js
@@ -13,6 +13,... | diff --git a/client/src/plugins/privacy-preferences/__tests__/PrivacyPreferencesSpec.js b/client/src/plugins/privacy-preferences/__tests__/PrivacyPreferencesSpec.js
index ee181ce24c..12c46ddda1 100644
--- a/client/src/plugins/privacy-preferences/__tests__/PrivacyPreferencesSpec.js
+++ b/client/src/plugins/privacy-prefe... | Opt out from telemetry on new installations
### What should we do?
Change the telemetry popup from the current opt-in to opt-out by checking all boxes by default on new installations
It was discussed in the
[#prj-desktop-modeler-telemetry-on-by-default](https://camunda.slack.com/archives/C098UG89MGA) channel and both... | if you want `to track the used connector usage` be aware of this [issue](https://github.com/camunda/camunda-modeler/issues/5207)
@Buckwich thanks for mentioning that issue, it will be also important. But we have the deployment events in place already, so at least [we can track how many deployments have at least on of t... | if you want `to track the used connector usage` be aware of this [issue](https://github.com/camunda/camunda-modeler/issues/5207)
@Buckwich thanks for mentioning that issue, it will be also important. But we have the deployment events in place already, so at least [we can track how many deployments have at least on of t... | [
"https://github.com/camunda/camunda-modeler/commit/0aa4b71898969b0ea8df24d29f2431aace565ade",
"https://github.com/camunda/camunda-modeler/commit/da53154b16f31eca14629723d74effdda9db9464",
"https://github.com/camunda/camunda-modeler/commit/4a339c7811d8276446d4c55835ea538fcddfbb91"
] | 2025-08-28T09:48:10 | 3.0 | JavaScript |
camunda/camunda-modeler | 3,673 | camunda__camunda-modeler-3673 | [
3357
] | ee0d46bfa380bdcf90b6aab14776e988a7da8c2a | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 198bc0b550..32c06cfec6 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -8,6 +8,7 @@ ___Note:__ Yet to be released changes appear here._
### General
+* `FEAT`: show element template errors in the errors panel ([#3357](https://github.com/camunda/camunda-modeler/issues/3... | diff --git a/client/src/app/__tests__/TabsProviderSpec.js b/client/src/app/__tests__/TabsProviderSpec.js
index f22f382f3e..3c7170972a 100644
--- a/client/src/app/__tests__/TabsProviderSpec.js
+++ b/client/src/app/__tests__/TabsProviderSpec.js
@@ -951,7 +951,7 @@ describe('TabsProvider', function() {
'dmn'
]... | Show element template errors in the error panel
### Problem you would like to solve
As a user I don't see element template errors in the `Problems` panel. As a result I cannot batch fix issues related to re-usable building blocks:
![screely-1670929997045](https://user-images.githubusercontent.com/58601/207303100-... | [
"https://github.com/camunda/camunda-modeler/commit/242b0b6868c27328f7e099c53567eed66e908d33",
"https://github.com/camunda/camunda-modeler/commit/9767c9662ac4e5e3910d72809be1e8cc28813dc4",
"https://github.com/camunda/camunda-modeler/commit/11fb112d96f480140764cac0336fece34bf64096",
"https://github.com/camunda/... | 2023-06-16T08:31:56 | 3.0 | JavaScript | ||
camunda/camunda-modeler | 5,361 | camunda__camunda-modeler-5361 | [
5345
] | 98a916217dc97c6165e5a4986cf6d9b99dfa918f | diff --git a/CHANGELOG.md b/CHANGELOG.md
index ab9aa6731c..9bdc6d38d2 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,6 +7,7 @@ All notable changes to the [Camunda Modeler](https://github.com/camunda/camunda-
___Note:__ Yet to be released changes appear here._
* `FIX`: use `ZEEBE_GRPC_ADDRESS` in favor of deprec... | diff --git a/app/test/spec/zeebe-api/utils-spec.js b/app/test/spec/zeebe-api/utils-spec.js
index bf3cc49a99..c92fef2f81 100644
--- a/app/test/spec/zeebe-api/utils-spec.js
+++ b/app/test/spec/zeebe-api/utils-spec.js
@@ -3,7 +3,8 @@ const {
isRestSaasUrl,
isSaasUrl,
sanitizeCamundaClientOptions,
- sanitizeConfi... | Gracefully handle c8run `/v2/` path in the orchestration cluster endpoint
### What should we do?
* [x] I can connect to c8run if I provide `http://localhost:8088` endpoint
* [ ] I can connect to c8run if I provide `http://localhost:8088/v2/` endpoint
### Why should we do it?
c8run provides the orchestration cluste... | its not only c8run, console also defaults to the v2 path (if you reopen a credential) (cf. slack https://camunda.slack.com/archives/GP70M0J6M/p1759244643413549?thread_ts=1759241005.289019&cid=GP70M0J6M)
but also note that even if we fix this, you can't connect to c8run (the java version) with rest. at least during my t... | its not only c8run, console also defaults to the v2 path (if you reopen a credential) (cf. slack https://camunda.slack.com/archives/GP70M0J6M/p1759244643413549?thread_ts=1759241005.289019&cid=GP70M0J6M)
but also note that even if we fix this, you can't connect to c8run (the java version) with rest. at least during my t... | [
"https://github.com/camunda/camunda-modeler/commit/b3feb098bb2e4ca112bcf6bcbe896a0c068e04e5"
] | 2025-10-22T20:16:01 | 3.0 | JavaScript |
mrdoob/three.js | 26,589 | mrdoob__three.js-26589 | [
26588
] | c849b5da3cb56aff580716450563c6f95f0fb458 | diff --git a/src/objects/Line.js b/src/objects/Line.js
index e359bcfb297227..6a6d0d4e2c4daa 100644
--- a/src/objects/Line.js
+++ b/src/objects/Line.js
@@ -34,7 +34,7 @@ class Line extends Object3D {
super.copy( source, recursive );
- this.material = source.material;
+ this.material = Array.isArray( source.mate... | diff --git a/test/unit/src/objects/Line.tests.js b/test/unit/src/objects/Line.tests.js
index 7258948db6748a..04f8f815c04f42 100644
--- a/test/unit/src/objects/Line.tests.js
+++ b/test/unit/src/objects/Line.tests.js
@@ -3,6 +3,7 @@
import { Line } from '../../../../src/objects/Line.js';
import { Object3D } from '../... | Clone the material array when Object3D.clone() is called
### Description
I get that cloning the materials themselves doesn't make sense. This would be a big performance hit.
But the materials array seems like it is part of the object to me. So if I call `Object3D.clone()`, I'd expect that array to get cloned as well.... | The `animations` array is also cloned, see:
https://github.com/mrdoob/three.js/blob/c849b5da3cb56aff580716450563c6f95f0fb458/src/core/Object3D.js#L948
I think it makes sense to do the same for an array of materials in all relevant 3D object classes (it should be `Mesh`, `Points` and `Line`). Are you interested in... | The `animations` array is also cloned, see:
https://github.com/mrdoob/three.js/blob/c849b5da3cb56aff580716450563c6f95f0fb458/src/core/Object3D.js#L948
I think it makes sense to do the same for an array of materials in all relevant 3D object classes (it should be `Mesh`, `Points` and `Line`). Are you interested in... | [
"https://github.com/mrdoob/three.js/commit/26deff1579cc3dc139a8ae8679ba5b30b9eca939",
"https://github.com/mrdoob/three.js/commit/1a47d5d0fd1fb31873fa10d46339399a5a879847",
"https://github.com/mrdoob/three.js/commit/1b73fa07f5160f03aa6eaa8652d0e59272c7b670",
"https://github.com/mrdoob/three.js/commit/9f7d0c7e3... | 2023-08-15T21:20:29 | 0.0 | JavaScript |
mrdoob/three.js | 29,514 | mrdoob__three.js-29514 | [
29478
] | 86b8447f70535ee21d624f5bf3244be5b6880053 | diff --git a/examples/jsm/curves/NURBSCurve.js b/examples/jsm/curves/NURBSCurve.js
index 8be8dde2d61b4b..f0ee02b398a52d 100644
--- a/examples/jsm/curves/NURBSCurve.js
+++ b/examples/jsm/curves/NURBSCurve.js
@@ -26,14 +26,17 @@ class NURBSCurve extends Curve {
super();
+ const knotsLength = knots ? knots.length ... | diff --git a/test/unit/addons/curves/NURBSCurve.tests.js b/test/unit/addons/curves/NURBSCurve.tests.js
new file mode 100644
index 00000000000000..06150bf07fcafa
--- /dev/null
+++ b/test/unit/addons/curves/NURBSCurve.tests.js
@@ -0,0 +1,70 @@
+/* global QUnit */
+
+import { NURBSCurve } from '../../../../examples/jsm/cu... | NURBSCurve.toJSON doesn't serialize points data
### Description
The JSON object returned from `NURBSCurve.toJSON()` doesn't contain data relating points, knots or control points, but instead contains:
```
{
"metadata": {
"version": 4.6,
"type": "Curve",
"generator": "Curve.toJSON"... | `NURBSCurve` is part of the addons and there is no JSON support for this class right now. Only curves classes in the core support that.
Even with a proper `NURBSCurve.toJSON()` implementation you also need the `fromJSON()` counterpart to make a deserialization work.
The next problem is that objects deserialized with... | `NURBSCurve` is part of the addons and there is no JSON support for this class right now. Only curves classes in the core support that.
Even with a proper `NURBSCurve.toJSON()` implementation you also need the `fromJSON()` counterpart to make a deserialization work.
The next problem is that objects deserialized with... | [
"https://github.com/mrdoob/three.js/commit/fc07eb7eff32d000051b8f90095394e7fa8142c4",
"https://github.com/mrdoob/three.js/commit/18198db53d20358df7974e6b88e7054e4141a5c0",
"https://github.com/mrdoob/three.js/commit/7ee60a88d55f82b459eb646cb4aed1cc30dd7b6f",
"https://github.com/mrdoob/three.js/commit/bb8813138... | 2024-09-27T19:54:53 | 0.0 | JavaScript |
mrdoob/three.js | 31,096 | mrdoob__three.js-31096 | [
31095
] | b77e864e73bb3190b293fa50c6b3dfdd01684a3c | diff --git a/src/core/BufferGeometry.js b/src/core/BufferGeometry.js
index 13915ebedde11f..8cf0cba4460a4c 100644
--- a/src/core/BufferGeometry.js
+++ b/src/core/BufferGeometry.js
@@ -1201,7 +1201,7 @@ class BufferGeometry extends EventDispatcher {
const data = {
metadata: {
- version: 4.6,
+ version: 4.7... | diff --git a/test/unit/src/core/BufferGeometry.tests.js b/test/unit/src/core/BufferGeometry.tests.js
index 813d47f4f62a64..0fe36ba52b6a74 100644
--- a/test/unit/src/core/BufferGeometry.tests.js
+++ b/test/unit/src/core/BufferGeometry.tests.js
@@ -654,7 +654,7 @@ export default QUnit.module( 'Core', () => {
let j = ... | Increment metadata.version in Material.toJSON
### Description
Hi, the handling of `bumpScale` was changed in [#26899](https://github.com/mrdoob/three.js/pull/26899), which is saved in `Material.toJSON`.
To distinguish between old and new files `metadata.version` is checked while loading, so that either a warning can... | Bumping the material version sounds fine. The line to updated should be:
https://github.com/mrdoob/three.js/blob/b77e864e73bb3190b293fa50c6b3dfdd01684a3c/src/materials/Material.js#L618
| Bumping the material version sounds fine. The line to updated should be:
https://github.com/mrdoob/three.js/blob/b77e864e73bb3190b293fa50c6b3dfdd01684a3c/src/materials/Material.js#L618
| [
"https://github.com/mrdoob/three.js/commit/383902f0fc81762b3d802404ef4c99c7418bca11",
"https://github.com/mrdoob/three.js/commit/34dee388f72d4423b2eddd9a3a8c3b1dac261a3a"
] | 2025-05-13T14:25:49 | 0.0 | JavaScript |
mrdoob/three.js | 25,560 | mrdoob__three.js-25560 | [
25552
] | 52d5a0879a4ef890ab2734840437026dd5254975 | diff --git a/src/renderers/shaders/UniformsUtils.js b/src/renderers/shaders/UniformsUtils.js
index b20b4abd60aa32..ce1315af893b59 100644
--- a/src/renderers/shaders/UniformsUtils.js
+++ b/src/renderers/shaders/UniformsUtils.js
@@ -21,7 +21,16 @@ export function cloneUniforms( src ) {
property.isVector2 || property... | diff --git a/test/unit/src/renderers/shaders/UniformsUtils.tests.js b/test/unit/src/renderers/shaders/UniformsUtils.tests.js
index eb0acd4cf0b1c4..81d2980f09756b 100644
--- a/test/unit/src/renderers/shaders/UniformsUtils.tests.js
+++ b/test/unit/src/renderers/shaders/UniformsUtils.tests.js
@@ -1,6 +1,16 @@
/* global Q... | WebGL Error when using UniformsUtils.merge to merge a WebGLCubeRenderTarget texture
### Description
When using a WebGLCubeRenderTarget texture as an input to a shader, and then passing that through UniformsUtils.merge, you get the following error:
THREE.WebGLState: TypeError: Failed to execute 'texSubImage2D' on 'W... | The problem is that cloning a render target texture is an invalid operation. You have to clone the render target itself (the framebuffer) and not it's texture (the attachment). Besides, setting `needsUpdate` to `true` is also not valid for render target textures. Unlike normal (image based) textures, their data does no... | The problem is that cloning a render target texture is an invalid operation. You have to clone the render target itself (the framebuffer) and not it's texture (the attachment). Besides, setting `needsUpdate` to `true` is also not valid for render target textures. Unlike normal (image based) textures, their data does no... | [
"https://github.com/mrdoob/three.js/commit/5443b21e3caf35c64ace0c16ab65eaef2cfe7eea",
"https://github.com/mrdoob/three.js/commit/b59ed3857ed5283f4f7fa624de8944b292a85037",
"https://github.com/mrdoob/three.js/commit/92e0d914b512688fff84a8739e23c14a4566c1bd",
"https://github.com/mrdoob/three.js/commit/967553a0b... | 2023-02-24T00:46:13 | 0.0 | JavaScript |
mrdoob/three.js | 30,944 | mrdoob__three.js-30944 | [
30926
] | 09826c0ba8abbb8c2587e6a733ca4cdf3b5cfede | diff --git a/src/nodes/core/Node.js b/src/nodes/core/Node.js
index 358fbcaacb11fb..171b640edfc96a 100644
--- a/src/nodes/core/Node.js
+++ b/src/nodes/core/Node.js
@@ -586,12 +586,14 @@ class Node extends EventDispatcher {
}
/**
- * This method performs the build of a node. The behavior of this method as well as ... | diff --git a/test/e2e/puppeteer.js b/test/e2e/puppeteer.js
index 693dbb9ad979fb..802288667294bf 100644
--- a/test/e2e/puppeteer.js
+++ b/test/e2e/puppeteer.js
@@ -168,6 +168,7 @@ const exceptionList = [
'webgpu_materials_envmaps_bpcem',
'webgpu_postprocessing_sobel',
'webgpu_postprocessing_3dlut',
+ 'webgpu_postp... | TSL: Using debug() changes the compiled code
### Description
Using the debug() function can in some cases change the compiled wgsl code. See attached fiddle for an example.
The compute shader with the following tsl code:
```js
const foo = float(1).toVar();
const foo2 = float(2).toVar();
const bar = ... | Looking further into it, the bug only exists for compute shaders, debug() works well with vertex and fragment shaders.
Also, the following change in DebugNode.js fixes the problem:
replace
```
setup( builder ) {
return this.node.build( builder );
}
```
with:
```
setup( builder ) {
this.node.build( builder );
retu... | Looking further into it, the bug only exists for compute shaders, debug() works well with vertex and fragment shaders.
Also, the following change in DebugNode.js fixes the problem:
replace
```
setup( builder ) {
return this.node.build( builder );
}
```
with:
```
setup( builder ) {
this.node.build( builder );
retu... | [
"https://github.com/mrdoob/three.js/commit/4d2e24a2aaecea6b700ba4d3bd4eeda4355f9945",
"https://github.com/mrdoob/three.js/commit/dc72bfe8be951145b4772439bd49f5f2b9132747",
"https://github.com/mrdoob/three.js/commit/45735d3011b79d65d718ad93f9e4a9e523e73c17"
] | 2025-04-17T02:08:21 | 0.0 | JavaScript |
dequelabs/axe-core | 4,303 | dequelabs__axe-core-4303 | [
4302
] | f3569c53d6ad7964fc2928c869d0d60df2864eed | diff --git a/lib/core/utils/get-selector.js b/lib/core/utils/get-selector.js
index 3ac8aeab99..470946705b 100644
--- a/lib/core/utils/get-selector.js
+++ b/lib/core/utils/get-selector.js
@@ -22,7 +22,8 @@ const ignoredAttributes = [
'aria-expanded',
'aria-grabbed',
'aria-pressed',
- 'aria-valuenow'
+ 'aria-v... | diff --git a/test/core/utils/get-selector.js b/test/core/utils/get-selector.js
index 520bfbea56..0a2cab5b78 100644
--- a/test/core/utils/get-selector.js
+++ b/test/core/utils/get-selector.js
@@ -471,7 +471,8 @@ describe('axe.utils.getSelector', function () {
'aria-expanded',
'aria-grabbed',
'aria-p... | axe-core's selectors incorrectly handle the `xmlns` attribute
### Product
axe-core
### Product Version
4.8.1
### Latest Version
- [X] I have tested the issue with the latest version of the product
### Issue Description
#### Expectation
The selector produced by axe-core should match an element on t... | [
"https://github.com/dequelabs/axe-core/commit/b88713c4ff2a8e35f1b88a88273b72ac0952488e"
] | 2024-01-17T20:18:04 | 4.7 | JavaScript | ||
dequelabs/axe-core | 3,861 | dequelabs__axe-core-3861 | [
3848
] | 3be2bad2a896e72a92fe70810500fc1ef67b7027 | diff --git a/doc/check-options.md b/doc/check-options.md
index 0f6c60d027..87c6adda42 100644
--- a/doc/check-options.md
+++ b/doc/check-options.md
@@ -36,6 +36,7 @@
- [region](#region)
- [inline-style-property](#inline-style-property)
- [invalid-children](#invalid-children)
+ - [link-in-text-block](#link-in-t... | diff --git a/test/checks/color/link-in-text-block.js b/test/checks/color/link-in-text-block.js
index 9811041797..46fe3e362a 100644
--- a/test/checks/color/link-in-text-block.js
+++ b/test/checks/color/link-in-text-block.js
@@ -98,7 +98,7 @@ describe('link-in-text-block', function () {
it('passes the selected nod... | axe core throws relying on color alone false positive issue when the link and surrounded text have same color
### Product
axe-core
### Product Version
4.5.1 and 4.5.2
### Latest Version
- [X] I have tested the issue with the latest version of the product
### Issue Description
#### Expectation
If t... | This is not a false positive, if you look at the "fix this" section you will see that it is complaining that the text contrast with the surrounding text is too low - which is 100% accurate.
@WilcoFiers should we change the help text to make it more precise?
@dylanb Contrast is low here because the link and surroundi... | This is not a false positive, if you look at the "fix this" section you will see that it is complaining that the text contrast with the surrounding text is too low - which is 100% accurate.
@WilcoFiers should we change the help text to make it more precise?
@dylanb Contrast is low here because the link and surroundi... | [
"https://github.com/dequelabs/axe-core/commit/7532a2a1f793985c31ba211828019d2482875232"
] | 2023-01-19T13:47:04 | 4.6 | JavaScript |
dequelabs/axe-core | 4,702 | dequelabs__axe-core-4702 | [
4701
] | 8a0faffee1857fb9737f5f55d3085e500791c8e6 | diff --git a/lib/checks/aria/valid-scrollable-semantics-evaluate.js b/lib/checks/aria/valid-scrollable-semantics-evaluate.js
index 0241f6cf83..946f290471 100644
--- a/lib/checks/aria/valid-scrollable-semantics-evaluate.js
+++ b/lib/checks/aria/valid-scrollable-semantics-evaluate.js
@@ -30,7 +30,8 @@ const VALID_ROLES_F... | diff --git a/test/checks/aria/has-widget-role.js b/test/checks/aria/has-widget-role.js
index f7324cadc9..3abb3a537e 100644
--- a/test/checks/aria/has-widget-role.js
+++ b/test/checks/aria/has-widget-role.js
@@ -172,15 +172,6 @@ describe('has-widget-role', function () {
);
});
- it('should return true for rol... | target-size: false positive for small targets in focusable tabpanels
### Product
axe-core
### Product Version
4.10.2
### Latest Version
- [x] I have tested the issue with the latest version of the product
### Issue Description
A common pattern with tab panels is for the panel to be focusable, but not clickable. ... | Confirmed with @WilcoFiers that he's on board with making this change to treat tabpanel as structure
| [
"https://github.com/dequelabs/axe-core/commit/ce9ceb6a602b7068295ca9e46786dcb7d8efdd83",
"https://github.com/dequelabs/axe-core/commit/982300bfde0a7c7f6f403f89919e3ae6650402bb",
"https://github.com/dequelabs/axe-core/commit/67f975c8d43332abe788184829bd87cfdd1092c3",
"https://github.com/dequelabs/axe-core/comm... | 2025-02-07T00:11:07 | 4.7 | JavaScript | |
dequelabs/axe-core | 3,847 | dequelabs__axe-core-3847 | [
3329
] | 6fa6331d505ebbd98e9d7f84e57ec7e5a13aded3 | diff --git a/lib/commons/dom/create-grid.js b/lib/commons/dom/create-grid.js
index f4c0278502..509fbba5f9 100644
--- a/lib/commons/dom/create-grid.js
+++ b/lib/commons/dom/create-grid.js
@@ -54,10 +54,17 @@ export default function createGrid(
while (node) {
let vNode = getNodeFromTree(node);
+ if (vNode &&... | diff --git a/test/checks/color/color-contrast.js b/test/checks/color/color-contrast.js
index d5ae1deea3..d6f5fcb627 100644
--- a/test/checks/color/color-contrast.js
+++ b/test/checks/color/color-contrast.js
@@ -906,6 +906,29 @@ describe('color-contrast', function () {
}
);
+ (shadowSupported ? it : xit)('han... | Color-contrast does not take into account <slot> elements and the light DOM
Product: axe-core && axe Extension
Expectation: Correctly Report the Contrast on a Manual Scan
Actual: False Reports of an Issue
Motivation: This was Previously working
<pre><code>
axe-core version: 4.3.5
extension: 4.19.0
</code></pre... | Hey @tmcconechy - thanks for the report, and thanks for including the URL! I can confirm that I'm seeing the same results you are, and that it does appear to be a bug. I will pass thing along to the correct team members to review.
The issue is being raised as a "needs review" item a.k.a. incomplete, this is expected be... | Hey @tmcconechy - thanks for the report, and thanks for including the URL! I can confirm that I'm seeing the same results you are, and that it does appear to be a bug. I will pass thing along to the correct team members to review.
The issue is being raised as a "needs review" item a.k.a. incomplete, this is expected be... | [
"https://github.com/dequelabs/axe-core/commit/d6ffb90f70c847c2cdb0a142195460fcf397c421",
"https://github.com/dequelabs/axe-core/commit/873f85af9a5604145f52bf617f1097bf402404f3"
] | 2023-01-05T17:05:05 | 4.6 | JavaScript |
dequelabs/axe-core | 4,518 | dequelabs__axe-core-4518 | [
4515
] | 0d8a99eadd8d49e5d3ea0f11ad77be732148431e | diff --git a/lib/checks/aria/aria-required-attr-evaluate.js b/lib/checks/aria/aria-required-attr-evaluate.js
index f10642c4c4..f623ba4be7 100644
--- a/lib/checks/aria/aria-required-attr-evaluate.js
+++ b/lib/checks/aria/aria-required-attr-evaluate.js
@@ -54,6 +54,11 @@ export default function ariaRequiredAttrEvaluate(
... | diff --git a/test/checks/aria/aria-required-attr.js b/test/checks/aria/aria-required-attr.js
index a18a96e42e..4aa7d3a1bb 100644
--- a/test/checks/aria/aria-required-attr.js
+++ b/test/checks/aria/aria-required-attr.js
@@ -49,6 +49,13 @@ describe('aria-required-attr', () => {
assert.isTrue(requiredAttrCheck.apply(... | Should role=slider allow aria-valuetext as an alternative to aria-valuenow?
According to WAI-ARIA, aria-valuenow is required for role=slider, even if it has aria-valuetext. From NVDA, JAWS and VO testing it looks like aria-valuetext works well as an alternative. While slider is intended as a value input mechanic, it is... | [
"https://github.com/dequelabs/axe-core/commit/57497bd44fa6c379346b9a665bb734f2fb601875"
] | 2024-07-01T11:44:57 | 4.7 | JavaScript | ||
shaka-project/shaka-player | 6,916 | shaka-project__shaka-player-6916 | [
3781
] | 339bab44ec58cfdf288e7e9532f4c92b34568e65 | diff --git a/demo/config.js b/demo/config.js
index 40c6eddf6b..04659fa9f7 100644
--- a/demo/config.js
+++ b/demo/config.js
@@ -200,7 +200,9 @@ shakaDemo.Config = class {
.addBoolInput_('Disable Text', 'manifest.disableText')
.addBoolInput_('Disable Thumbnails', 'manifest.disableThumbnails')
.... | diff --git a/test/offline/storage_integration.js b/test/offline/storage_integration.js
index c405743aaa..42d29a821e 100644
--- a/test/offline/storage_integration.js
+++ b/test/offline/storage_integration.js
@@ -1755,6 +1755,9 @@ filterDescribe('Storage', storageSupport, () => {
/** @override */
banLocation(... | Continue loading live stream manifest when paused
**Have you read the [FAQ](https://bit.ly/ShakaFAQ) and checked for duplicate open issues?**
yes
**What version of Shaka Player are you using?**
3.2.1
**Can you reproduce the issue with our latest release version?**
yes
**Can you reproduce the issue with the ... | Hi @TheModMaker, any update on this issue?
Our use case, we sometimes want to pause playback and any processing of AV and do another operation and then resume playback, this is especially important on low end devices where memory is limited.
Specifically this gets more complicated if manifests are too big (live with... | Hi @TheModMaker, any update on this issue?
Our use case, we sometimes want to pause playback and any processing of AV and do another operation and then resume playback, this is especially important on low end devices where memory is limited.
Specifically this gets more complicated if manifests are too big (live with... | [
"https://github.com/shaka-project/shaka-player/commit/f31f2df7abf6a9521dc7ce0bd03b72a7c7664ad4",
"https://github.com/shaka-project/shaka-player/commit/8877d10bca52ee3fe80cc1451e5aeea107a0ae4d",
"https://github.com/shaka-project/shaka-player/commit/8e8d4d5fd7baf546de6776d3556ccacad24f3e93"
] | 2024-06-26T09:31:19 | 2.4 | JavaScript |
shaka-project/shaka-player | 6,433 | shaka-project__shaka-player-6433 | [
6355
] | 3b5a71c5bf34c88b3b020e558fbecdbeb69d1e64 | diff --git a/lib/media/play_rate_controller.js b/lib/media/play_rate_controller.js
index f0917d117c..bd3dbe1ab2 100644
--- a/lib/media/play_rate_controller.js
+++ b/lib/media/play_rate_controller.js
@@ -30,6 +30,9 @@ shaka.media.PlayRateController = class {
/** @private {number} */
this.rate_ = this.harness_.... | diff --git a/test/media/play_rate_controller_unit.js b/test/media/play_rate_controller_unit.js
index 916166fc6e..25e715dd7a 100644
--- a/test/media/play_rate_controller_unit.js
+++ b/test/media/play_rate_controller_unit.js
@@ -66,4 +66,52 @@ describe('PlayRateController', () => {
controller.set(1);
expect(set... | steaming.rebufferingGoal is being ignored after v4.6.0
<!-- NOTE: If you ignore this template, we will send it again and ask you to fill it out anyway. -->
**Have you read the [FAQ](https://bit.ly/ShakaFAQ) and checked for duplicate open issues?**
Yes.
**If the problem is related to FairPlay, have you read the t... | if i'm not wrong the rebufferingGoal is only apply with manifest.dash.ignoreMinBufferTime <= true
@Iragne By reading the code([1](https://github.com/shaka-project/shaka-player/blob/main/lib/media/playhead.js#L469), [2](https://github.com/shaka-project/shaka-player/blob/07a32419d3069dbf65fda8d9c56244175f934a4a/lib/media... | if i'm not wrong the rebufferingGoal is only apply with manifest.dash.ignoreMinBufferTime <= true
@Iragne By reading the code([1](https://github.com/shaka-project/shaka-player/blob/main/lib/media/playhead.js#L469), [2](https://github.com/shaka-project/shaka-player/blob/07a32419d3069dbf65fda8d9c56244175f934a4a/lib/media... | [
"https://github.com/shaka-project/shaka-player/commit/b11af26e8fc80f45ca6869d21d3af502611bfe35",
"https://github.com/shaka-project/shaka-player/commit/b781ef41e9a3f735de064cfa627fda6b3a2deb09",
"https://github.com/shaka-project/shaka-player/commit/1a55ec052f4c8ca2888fea129325b4a6b88dcb95",
"https://github.com... | 2024-04-10T13:04:28 | 2.4 | JavaScript |
shaka-project/shaka-player | 8,415 | shaka-project__shaka-player-8415 | [
8402
] | a27434bf31b0b2075391755ad287abb5226ef6df | diff --git a/lib/media/playhead.js b/lib/media/playhead.js
index 9998414bbc..53ff6eab88 100644
--- a/lib/media/playhead.js
+++ b/lib/media/playhead.js
@@ -45,7 +45,7 @@ shaka.media.Playhead = class {
* Set the start time. If the content has already started playback, this will
* be ignored.
*
- * @param {n... | diff --git a/test/media/playhead_unit.js b/test/media/playhead_unit.js
index f0a98e1374..a131741cb6 100644
--- a/test/media/playhead_unit.js
+++ b/test/media/playhead_unit.js
@@ -130,6 +130,8 @@ describe('Playhead', () => {
timeline.getSeekRangeStart.and.returnValue(5);
timeline.getSeekRangeEnd.and.returnValu... | Ability to pass in a Date object for playback start time
**Have you read the [FAQ](https://bit.ly/ShakaFAQ) and checked for duplicate open issues?**
Yes
**Is your feature request related to a problem? Please describe.**
<!-- A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] -... | I’d prefer option B
FYI, dash.js provides a way to specify start time as string with `posix` prefix.
I'm going to assume that they use the posix prefix because of mpd anchors. I think a Date object is the most JSy, but a string could be converted internally if we felt the need.
| I’d prefer option B
FYI, dash.js provides a way to specify start time as string with `posix` prefix.
I'm going to assume that they use the posix prefix because of mpd anchors. I think a Date object is the most JSy, but a string could be converted internally if we felt the need.
| [
"https://github.com/shaka-project/shaka-player/commit/b3a6d70db9e8e93346bb0f81dcd7a50e0e14a3d2",
"https://github.com/shaka-project/shaka-player/commit/e587b6afc07fc4a73ba210e565c021c99d75563e",
"https://github.com/shaka-project/shaka-player/commit/008554a7296346c9122e95f255ddcf39564c2765"
] | 2025-04-08T09:51:33 | 2.4 | JavaScript |
shaka-project/shaka-player | 7,682 | shaka-project__shaka-player-7682 | [
7680
] | f765e05985968f7881893d8515705078ff80fb4f | diff --git a/lib/media/drm_engine.js b/lib/media/drm_engine.js
index 5ccd43d57d..606853ee02 100644
--- a/lib/media/drm_engine.js
+++ b/lib/media/drm_engine.js
@@ -15,6 +15,7 @@ goog.require('shaka.util.DrmUtils');
goog.require('shaka.util.Error');
goog.require('shaka.util.EventManager');
goog.require('shaka.util.Fak... | diff --git a/test/util/functional_unit.js b/test/util/functional_unit.js
new file mode 100644
index 0000000000..46d09e93ef
--- /dev/null
+++ b/test/util/functional_unit.js
@@ -0,0 +1,34 @@
+/*! @license
+ * Shaka Player
+ * Copyright 2016 Google LLC
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+describe('Functional',... | [Android][WebView] Calls to decodingInfo or requestMediaKeySystemAccess do not resolve or reject at least without RESOURCE_PROTECTED_MEDIA_ID
<!-- NOTE: If you ignore this template, we will send it again and ask you to fill it out anyway. -->
**Have you read the [FAQ](https://bit.ly/ShakaFAQ) and checked for duplica... | [
"https://github.com/shaka-project/shaka-player/commit/d9b9bae785525487bd5e0f4b07b3ad49b77dcfc5",
"https://github.com/shaka-project/shaka-player/commit/190c14796265a93cdd959a8ef99e7ab4bd305b45",
"https://github.com/shaka-project/shaka-player/commit/c8f33ba9c9d199f9a1821c8cc4330201554e45c2",
"https://github.com... | 2024-11-27T12:39:22 | 2.4 | JavaScript | ||
shaka-project/shaka-player | 7,010 | shaka-project__shaka-player-7010 | [
4393,
5202
] | dc34ec484a241c420eb6216a1151ffc7ed3c4817 | diff --git a/lib/media/playhead.js b/lib/media/playhead.js
index ea60821602..03277b84ca 100644
--- a/lib/media/playhead.js
+++ b/lib/media/playhead.js
@@ -18,6 +18,7 @@ goog.require('shaka.media.VideoWrapper');
goog.require('shaka.util.EventManager');
goog.require('shaka.util.IReleasable');
goog.require('shaka.util.... | diff --git a/test/media/playhead_unit.js b/test/media/playhead_unit.js
index ff2beb2867..cb8dc26a6b 100644
--- a/test/media/playhead_unit.js
+++ b/test/media/playhead_unit.js
@@ -593,7 +593,10 @@ describe('Playhead', () => {
expect(onSeek).toHaveBeenCalled();
}); // clamps playhead after seeking for VOD
- i... | Playback is broken after seeking to video end
**Have you read the [FAQ](https://bit.ly/ShakaFAQ) and checked for duplicate open issues?**
Yes. The issue is similar to #1967 and #1014.
**What version of Shaka Player are you using?**
4.1.2 & 3.1.0
**Can you reproduce the issue with our latest release version?**... | Confirmed. Thank you for the report!
This is reproducible with both our UI and the native browser controls, so it's not a Shaka UI bug.
It does not appear to happen when you seek via the video element API. I tried both video.currentTime = 60 or video.currentTime = 90 on a 60-second clip.
I still have not determine... | Confirmed. Thank you for the report!
This is reproducible with both our UI and the native browser controls, so it's not a Shaka UI bug.
It does not appear to happen when you seek via the video element API. I tried both video.currentTime = 60 or video.currentTime = 90 on a 60-second clip.
I still have not determine... | [
"https://github.com/shaka-project/shaka-player/commit/39b5c729411ac1fe75ff75bfe8eda055691d08d7",
"https://github.com/shaka-project/shaka-player/commit/c6b55f4eccde80de7b83377a37eeebca908125e4"
] | 2024-07-09T10:39:59 | 2.4 | JavaScript |
parse-community/Parse-SDK-JS | 1,735 | parse-community__Parse-SDK-JS-1735 | [
1734
] | f79680c691a895cbf2c073f597bad3e980619a09 | diff --git a/src/LiveQueryClient.js b/src/LiveQueryClient.js
index 17b4ab40c..893ba365e 100644
--- a/src/LiveQueryClient.js
+++ b/src/LiveQueryClient.js
@@ -258,6 +258,7 @@ class LiveQueryClient extends EventEmitter {
}
this.socket = new WebSocketImplementation(this.serverURL);
+ this.socket.closingPromi... | diff --git a/integration/test/ParseLiveQueryTest.js b/integration/test/ParseLiveQueryTest.js
index de066757c..ec7575e47 100644
--- a/integration/test/ParseLiveQueryTest.js
+++ b/integration/test/ParseLiveQueryTest.js
@@ -9,6 +9,12 @@ describe('Parse LiveQuery', () => {
Parse.User.enableUnsafeCurrentUser();
});
... | Ensure LiveQueryClient closes
### New Feature / Enhancement Checklist
<!--
Check every following box [x] before submitting your issue.
Click the "Preview" tab for better readability.
Thanks for contributing to Parse Platform!
-->
- [x] I am not disclosing a [vulnerability](https://github.com/parse-c... |
### Thanks for opening this issue!
- ❌ Please edit your post and use the provided template when creating a new issue. This helps everyone to understand your post better and asks for essential information to quicker review the issue.
<!-- parse-issue-bot-meta-tag-id {"requireTemplate":true} -->
|
### Thanks for opening this issue!
- ❌ Please edit your post and use the provided template when creating a new issue. This helps everyone to understand your post better and asks for essential information to quicker review the issue.
<!-- parse-issue-bot-meta-tag-id {"requireTemplate":true} -->
| [
"https://github.com/parse-community/Parse-SDK-JS/commit/06e2ca5f307189bb1cba878e6529557cf0183071",
"https://github.com/parse-community/Parse-SDK-JS/commit/9d046703e206e0778e77ae7def1fe996ceb0a99d",
"https://github.com/parse-community/Parse-SDK-JS/commit/a089cb87c0a5f30bdfdfceffdfddf96223902950",
"https://gith... | 2023-02-05T05:00:43 | 4.0 | JavaScript |
parse-community/Parse-SDK-JS | 2,078 | parse-community__Parse-SDK-JS-2078 | [
2056
] | eff6932fe863f2806695aa4df451bff8d10c7349 | diff --git a/src/ObjectStateMutations.js b/src/ObjectStateMutations.js
index d594d5d70..271e4f6b5 100644
--- a/src/ObjectStateMutations.js
+++ b/src/ObjectStateMutations.js
@@ -82,16 +82,15 @@ export function mergeFirstPendingState(pendingOps: Array<OpsMap>) {
export function estimateAttribute(
serverData: Attribut... | diff --git a/integration/test/ParseRelationTest.js b/integration/test/ParseRelationTest.js
index 32c925739..adec87117 100644
--- a/integration/test/ParseRelationTest.js
+++ b/integration/test/ParseRelationTest.js
@@ -43,6 +43,26 @@ describe('Parse Relation', () => {
});
});
+ it('can do consecutive adds (#... | Calling `.add` multiple times on relations is broken
### New Issue Checklist
<!--
Check every following box [x] before submitting your issue.
Click the "Preview" tab for better readability.
Thanks for contributing to Parse Platform!
-->
- [x] I am not disclosing a [vulnerability](https://github.com/... |
### Thanks for opening this issue!
- 🚀 You can help us to fix this issue faster by opening a pull request with a failing test. See our [Contribution Guide](https://github.com/parse-community/parse-server/blob/master/CONTRIBUTING.md) for how to make a pull request, or read our [New Contributor's Guide](https://blog.p... |
### Thanks for opening this issue!
- 🚀 You can help us to fix this issue faster by opening a pull request with a failing test. See our [Contribution Guide](https://github.com/parse-community/parse-server/blob/master/CONTRIBUTING.md) for how to make a pull request, or read our [New Contributor's Guide](https://blog.p... | [
"https://github.com/parse-community/Parse-SDK-JS/commit/bdad64c8a4d535708b6cfc0ef9b6035d97dfc707",
"https://github.com/parse-community/Parse-SDK-JS/commit/8969f0bc2d3a87d1077378cc40298d42eddc1419"
] | 2024-01-21T13:12:50 | 4.3 | JavaScript |
parse-community/Parse-SDK-JS | 1,939 | parse-community__Parse-SDK-JS-1939 | [
1938
] | 473babfec81e2062122f72f91c836bbbd3978324 | diff --git a/package-lock.json b/package-lock.json
index 00e883d1a..0548f1250 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -45402,7 +45402,7 @@
"version": "git+ssh://git@github.com/parse-community/parse-server.git#c78a5a6f10ce09032579fed8ef4cbd84c1ee96a9",
"integrity": "sha512-C6E8mkVW5IUtliq... | diff --git a/src/__tests__/Cloud-test.js b/src/__tests__/Cloud-test.js
index a43788b8a..48243b635 100644
--- a/src/__tests__/Cloud-test.js
+++ b/src/__tests__/Cloud-test.js
@@ -80,6 +80,15 @@ describe('Cloud', () => {
]);
});
+ it('run passes installationId option', () => {
+ Cloud.run('myfunction', {}, {... | Add `installationId` option to `Parse.Cloud.run`
### New Feature / Enhancement Checklist
<!--
Check every following box [x] before submitting your issue.
Click the "Preview" tab for better readability.
Thanks for contributing to Parse Platform!
-->
- [x] I am not disclosing a [vulnerability](https:/... |
### Thanks for opening this issue!
- 🎉 We are excited about your ideas for improvement!
<!-- parse-issue-bot-meta-tag-id {"suggestPr":false,"thanksFeature":true,"thanksPr":false} -->
🎉 This change has been released in version [4.2.0-alpha.3](https://github.com/parse-community/Parse-SDK-JS/releases/tag/4.2.0-alph... |
### Thanks for opening this issue!
- 🎉 We are excited about your ideas for improvement!
<!-- parse-issue-bot-meta-tag-id {"suggestPr":false,"thanksFeature":true,"thanksPr":false} -->
🎉 This change has been released in version [4.2.0-alpha.3](https://github.com/parse-community/Parse-SDK-JS/releases/tag/4.2.0-alph... | [
"https://github.com/parse-community/Parse-SDK-JS/commit/8a50d8376850fafc9d2839565e5e7ac5a1472c0b"
] | 2023-06-11T00:03:21 | 4.2 | JavaScript |
parse-community/Parse-SDK-JS | 1,781 | parse-community__Parse-SDK-JS-1781 | [
1162
] | 04a02f0bcf99dd96427c17b58cb08717ef4bf66a | diff --git a/gulpfile.js b/gulpfile.js
index 6993286c0..e79632709 100644
--- a/gulpfile.js
+++ b/gulpfile.js
@@ -65,8 +65,8 @@ const FULL_HEADER = (
' */\n'
);
-gulp.task('compile', function() {
- return gulp.src('src/*.js')
+function compileTask(stream) {
+ return stream
.pipe(babel({
presets: PRES... | diff --git a/integration/test/ParseDistTest.js b/integration/test/ParseDistTest.js
index d3fa39db5..fa2090d76 100644
--- a/integration/test/ParseDistTest.js
+++ b/integration/test/ParseDistTest.js
@@ -1,11 +1,15 @@
const puppeteer = require('puppeteer');
+const { resolvingPromise } = require('../../lib/node/promiseUti... | Unsuccessful cancellation of Parse File
### Issue Description
I was trying to cancel an a PFile when I noticed in my network that it successfully cancelled the PFile but created another request to continue saving the file. I tried checking who called it the second time and to my surprise, it went another attempt to ... | That's an interesting one! I assume this affects all requests to parse server since its the `RESTController`, not only Parse.File requests?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@Jerom... | That's an interesting one! I assume this affects all requests to parse server since its the `RESTController`, not only Parse.File requests?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
@Jerom... | [
"https://github.com/parse-community/Parse-SDK-JS/commit/c2bdc0b8a5f09285c52faf82fbe00765e466551c",
"https://github.com/parse-community/Parse-SDK-JS/commit/25c7e56b4147b0ee81ac19c4832e3c83ef43b4ff",
"https://github.com/parse-community/Parse-SDK-JS/commit/bba60256c3742a4e978ba07d561257de1f7a873f",
"https://gith... | 2023-02-17T20:22:42 | 4.1 | JavaScript |
parse-community/Parse-SDK-JS | 1,727 | parse-community__Parse-SDK-JS-1727 | [
1720
] | 6899c0f09381de16add85f9340ff30f59ea9fadb | diff --git a/src/LiveQueryClient.js b/src/LiveQueryClient.js
index 7e8f4d8c4..17b4ab40c 100644
--- a/src/LiveQueryClient.js
+++ b/src/LiveQueryClient.js
@@ -224,19 +224,20 @@ class LiveQueryClient extends EventEmitter {
* After calling unsubscribe you'll stop receiving events from the subscription object.
*
... | diff --git a/src/__tests__/LiveQueryClient-test.js b/src/__tests__/LiveQueryClient-test.js
index ba98ea561..a0dbd765c 100644
--- a/src/__tests__/LiveQueryClient-test.js
+++ b/src/__tests__/LiveQueryClient-test.js
@@ -72,34 +72,6 @@ describe('LiveQueryClient', () => {
liveQueryClient.open();
});
- it('can uns... | Ensure live query subscription unsubscribes
### New Feature / Enhancement Checklist
<!--
Check every following box [x] before submitting your issue.
Click the "Preview" tab for better readability.
Thanks for contributing to Parse Platform!
-->
- [x] I am not disclosing a [vulnerability](https://gith... |
### Thanks for opening this issue!
- ❌ Please edit your post and use the provided template when creating a new issue. This helps everyone to understand your post better and asks for essential information to quicker review the issue.
<!-- parse-issue-bot-meta-tag-id {"requireTemplate":true} -->
|
### Thanks for opening this issue!
- ❌ Please edit your post and use the provided template when creating a new issue. This helps everyone to understand your post better and asks for essential information to quicker review the issue.
<!-- parse-issue-bot-meta-tag-id {"requireTemplate":true} -->
| [
"https://github.com/parse-community/Parse-SDK-JS/commit/4af34831628cfbc082dbbbc6e17848e34a326046",
"https://github.com/parse-community/Parse-SDK-JS/commit/e519851d9535843f50afc90a21c3a8e674fe2df0",
"https://github.com/parse-community/Parse-SDK-JS/commit/f279c7dd1dca4c7d829cb2c729bf59f0b296b8b3",
"https://gith... | 2023-02-03T23:02:12 | 4.0 | JavaScript |
npm/node-semver | 538 | npm__node-semver-538 | [
521
] | aa516b50b32f5a144017d8fc1b9efe0540963c91 | diff --git a/classes/comparator.js b/classes/comparator.js
index 54ce1394..2146c884 100644
--- a/classes/comparator.js
+++ b/classes/comparator.js
@@ -90,32 +90,43 @@ class Comparator {
return new Range(this.value, options).test(comp.semver)
}
- const sameDirectionIncreasing =
- (this.operator ===... | diff --git a/test/classes/comparator.js b/test/classes/comparator.js
index 6c2e1215..209a024b 100644
--- a/test/classes/comparator.js
+++ b/test/classes/comparator.js
@@ -22,17 +22,18 @@ test('tostrings', (t) => {
test('intersect comparators', (t) => {
t.plan(comparatorIntersection.length)
- comparatorIntersecti... | [BUG] `intersects(r1, r2, options)` function returns `true` if the not intersected range `< 0.0.0` and `0.x` are supplied
### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current Behavior
Range `< 0.0.0` (or range `< 0.0.0-0` if the `includePrerelease` option is `true`) sh... | Technically this should be true if including pre releases, because 0.0.0-0 is less than 0.0.0.
> Technically this should be true if including pre releases, because 0.0.0-0 is less than 0.0.0.
> https://github.com/npm/node-semver/issues/521#issuecomment-1475325186
If the `includePrerelease` option is true, then yes... | Technically this should be true if including pre releases, because 0.0.0-0 is less than 0.0.0.
> Technically this should be true if including pre releases, because 0.0.0-0 is less than 0.0.0.
> https://github.com/npm/node-semver/issues/521#issuecomment-1475325186
If the `includePrerelease` option is true, then yes... | [
"https://github.com/npm/node-semver/commit/ed24de329c13750bf5dff7a4e40881b9eb2325c3",
"https://github.com/npm/node-semver/commit/efd559e2153a2a04111b1920415abaea87556d6f"
] | 2023-04-06T23:58:50 | 7.4 | JavaScript |
npm/node-semver | 754 | npm__node-semver-754 | [
349
] | 868d4bbe3d318c52544f38d5f9977a1103e924c2 | diff --git a/classes/semver.js b/classes/semver.js
index 13e66ce4..12832462 100644
--- a/classes/semver.js
+++ b/classes/semver.js
@@ -10,7 +10,7 @@ class SemVer {
if (version instanceof SemVer) {
if (version.loose === !!options.loose &&
- version.includePrerelease === !!options.includePrerelease... | diff --git a/test/classes/semver.js b/test/classes/semver.js
index 85a0ec31..946fa417 100644
--- a/test/classes/semver.js
+++ b/test/classes/semver.js
@@ -106,6 +106,34 @@ test('incrementing', t => {
}))
})
+test('invalid increments', (t) => {
+ t.throws(
+ () => new SemVer('1.2.3').inc('prerelease', '', fals... | [BUG] inc() may produce invalid semver with ReleaseType: prerelease
# What / Why
Given an identifier I want to increment a prerelease version.
### Current Behavior
Given an 'invalid' identifier, `inc()` will produce an invalid `semver`.
### Steps to Reproduce
```
const identifier = 'hotfix/410';
const increm... | [
"https://github.com/npm/node-semver/commit/47498de65fcf67455f36bc7447311d2bbedb26bd",
"https://github.com/npm/node-semver/commit/c0d679d2fa34b3c08dfd6ae2783cabd23fe3e2e1"
] | 2025-01-21T19:38:38 | 6.3 | JavaScript | ||
npm/node-semver | 588 | npm__node-semver-588 | [
587
] | 99d8287516a1d2abf0286033e2e26eca6b69c09f | diff --git a/classes/range.js b/classes/range.js
index a7d37203..7e7c4141 100644
--- a/classes/range.js
+++ b/classes/range.js
@@ -38,7 +38,7 @@ class Range {
this.set = this.raw
.split('||')
// map the range to a 2d array of comparators
- .map(r => this.parseRange(r))
+ .map(r => this.pars... | diff --git a/test/fixtures/range-exclude.js b/test/fixtures/range-exclude.js
index 4b6c5631..2789148a 100644
--- a/test/fixtures/range-exclude.js
+++ b/test/fixtures/range-exclude.js
@@ -102,4 +102,6 @@ module.exports = [
['>=1.0.0 <1.1.0', '1.1.0', { includePrerelease: true }],
['>=1.0.0 <1.1.0', '1.1.0-pre'],
... | [BUG] semver.satisfied false positive
### Is there an existing issue for this?
- [X] I have searched the existing issues
### Current Behavior
From: https://github.com/npm/npm-pick-manifest/pull/87#pullrequestreview-1514076507
> This now returns true: semver.satisfies('2.0.0', '== 1.0.0 || foo', { loose: true })) ... | [
"https://github.com/npm/node-semver/commit/4564a901f35840c73c01cbddf8f1359b5371a368"
] | 2023-07-07T17:05:34 | 5.7 | JavaScript | ||
npm/node-semver | 533 | npm__node-semver-533 | [
333
] | f66cc45c6e82eebb4b5b51af73e7b8dcaeda7e21 | diff --git a/functions/diff.js b/functions/diff.js
index 651a3018..ce9004bd 100644
--- a/functions/diff.js
+++ b/functions/diff.js
@@ -10,11 +10,27 @@ const diff = (version1, version2) => {
const hasPre = v1.prerelease.length || v2.prerelease.length
const prefix = hasPre ? 'pre' : ''
const defaultResult ... | diff --git a/test/functions/diff.js b/test/functions/diff.js
index 2369c98f..11663c95 100644
--- a/test/functions/diff.js
+++ b/test/functions/diff.js
@@ -4,19 +4,25 @@ const diff = require('../../functions/diff')
test('diff versions test', (t) => {
// [version1, version2, result]
// diff(version1, version2) -> re... | [BUG] semver.diff returns incorrect responses
# What / Why
```js
const semver = require('semver');
let releaseArray = ['prepatch', 'prerelease', 'patch', 'preminor', 'prerelease', 'minor', 'premajor', 'prerelease', 'major'];
let v = '0.0.1';
releaseArray.forEach((release) => {
let bump = semver.inc(v, r... | [
"https://github.com/npm/node-semver/commit/acc4e581508e2a96c599fb5f3b83f82ce06d4433"
] | 2023-04-05T23:32:21 | 7.4 | JavaScript | ||
npm/node-semver | 781 | npm__node-semver-781 | [
775
] | 2677f2a88334b0e728dbfe9ad9f5f57458437c87 | diff --git a/classes/semver.js b/classes/semver.js
index 6fbc062b..97049a40 100644
--- a/classes/semver.js
+++ b/classes/semver.js
@@ -1,6 +1,6 @@
const debug = require('../internal/debug')
const { MAX_LENGTH, MAX_SAFE_INTEGER } = require('../internal/constants')
-const { safeRe: re, safeSrc: src, t } = require('../i... | diff --git a/test/classes/semver.js b/test/classes/semver.js
index 946fa417..f4abad04 100644
--- a/test/classes/semver.js
+++ b/test/classes/semver.js
@@ -3,7 +3,22 @@ const SemVer = require('../../classes/semver')
const increments = require('../fixtures/increments.js')
const comparisons = require('../fixtures/compar... | [BUG] Coercing version with prerelease identifier that starts with digits returns truncated identifier
### Is there an existing issue for this?
- [x] I have searched the existing issues
### Current Behavior
Using semver `7.7.1` (and possibly earlier versions), attempting to coerce a version string that contains a pr... | [
"https://github.com/npm/node-semver/commit/cbca3e5ade99a4a187326874ef473a294cf93c48",
"https://github.com/npm/node-semver/commit/14325dd82fa2f136b14020876f60c3dd4f18c3f6"
] | 2025-04-24T20:06:57 | 6.3 | JavaScript | ||
openstreetmap/iD | 10,521 | openstreetmap__iD-10521 | [
10287
] | ec65e8b37e05c222bdf4da8b6c5ed804be9c6692 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 38830ed22b..a278b0df9c 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -38,6 +38,7 @@ _Breaking developer changes, which may affect downstream projects or sites that
# unreleased (v2.37.0-dev)
#### :sparkles: Usability & Accessibility
+* Don't suggest values from Tagin... | diff --git a/test/spec/services/taginfo.js b/test/spec/services/taginfo.js
index 26285fdc2d..8996058238 100644
--- a/test/spec/services/taginfo.js
+++ b/test/spec/services/taginfo.js
@@ -218,19 +218,44 @@ describe('iD.serviceTaginfo', function() {
it('does not get values for extremely popular keys', async ()... | Don't suggest values from Taginfo for `name:xx` tags
### URL
_No response_
### How to reproduce the issue?
1. Create an element
2. Go to it's tags
3. Add `name:xx`
4. Switch to the value box
5. Start typing
6. (notice the suggestions below)
### Screenshot(s) or anything else?
![image](https://github.com/opens... | Related discussion: https://github.com/openstreetmap/iD/issues/7485.
There’s a hard-coded list of keys that don’t get taginfo suggestions. It could be supplemented by a regular expression for keys starting with `name:`.
https://github.com/openstreetmap/iD/blob/49492a0e06aef71f90e96ab3ed50098df0f4ce93/modules/serv... | Related discussion: https://github.com/openstreetmap/iD/issues/7485.
There’s a hard-coded list of keys that don’t get taginfo suggestions. It could be supplemented by a regular expression for keys starting with `name:`.
https://github.com/openstreetmap/iD/blob/49492a0e06aef71f90e96ab3ed50098df0f4ce93/modules/serv... | [
"https://github.com/openstreetmap/iD/commit/db8f89f5174d448225c4121ce7116fa66e24bfc8",
"https://github.com/openstreetmap/iD/commit/9a546ee9da4d5c9cdc59aa49fe2588842efb244a",
"https://github.com/openstreetmap/iD/commit/8bef190614fea9fdb216951bb40d7aa4440829c2",
"https://github.com/openstreetmap/iD/commit/c113d... | 2024-11-01T12:37:13 | 2.15 | JavaScript |
openstreetmap/iD | 9,522 | openstreetmap__iD-9522 | [
9455
] | f513ccd03de0f82b2f277e3ac1bc95cce222783d | diff --git a/CHANGELOG.md b/CHANGELOG.md
index ca0c66b0abd..8733e988532 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -51,6 +51,7 @@ _Breaking developer changes, which may affect downstream projects or sites that
#### :white_check_mark: Validation
* Add warning if aeroways cross each other, buildings or highways ([... | diff --git a/test/spec/validations/suspicious_name.js b/test/spec/validations/suspicious_name.js
index f7696353dad..6acb69390b2 100644
--- a/test/spec/validations/suspicious_name.js
+++ b/test/spec/validations/suspicious_name.js
@@ -31,6 +31,10 @@ describe('iD.validations.suspicious_name', function () {
iD.fil... | Suspicious names in non-English languages are not removed
**Describe the bug**
When a `building=garage` has `name=garage` iD suggest to remove the suspicious name. On the other hand if the same building has `name=гараж` (meaning "garage" in Bulgarian), iD doesn't suggest to remove that name. The same applies for `buil... | [
"https://github.com/openstreetmap/iD/commit/97166e9350602fc98e31ff459e1d391b8cd96805",
"https://github.com/openstreetmap/iD/commit/3d59f4010dd911fdb6e7f666a45b29237ced3356"
] | 2023-03-04T10:22:21 | 2.15 | JavaScript | ||
openstreetmap/iD | 10,165 | openstreetmap__iD-10165 | [
10065
] | 12b0528175015d5c8964b1d1db28204016ac7b9c | diff --git a/modules/ui/fields/wikipedia.js b/modules/ui/fields/wikipedia.js
index 832881c770b..30f313d2a19 100644
--- a/modules/ui/fields/wikipedia.js
+++ b/modules/ui/fields/wikipedia.js
@@ -11,6 +11,8 @@ import { utilGetSetValue, utilNoAuto, utilRebind } from '../../util';
export function uiFieldWikipedia(field... | diff --git a/test/spec/ui/fields/wikipedia.js b/test/spec/ui/fields/wikipedia.js
index 6a6d4a122c1..dc31d78f9b3 100644
--- a/test/spec/ui/fields/wikipedia.js
+++ b/test/spec/ui/fields/wikipedia.js
@@ -113,6 +113,48 @@ describe('iD.uiFieldWikipedia', function() {
}, 20);
});
+ describe('encodePath', f... | Wikipedia link with question mark
### URL
https://www.openstreetmap.org/edit?way=394705975#map=19/44.81767/20.45303
### How to reproduce the issue?
1. Clear the wikipedia tag.
2. Select language "српски / srpski".
3. Start typing "Кафана „?”". Select such value from the drop-down.
4. Click on the button "vi... | In URL encoding, "?" is represented as "%3F"
That is why Кафана_„%3F” works while the former doesn't.
| In URL encoding, "?" is represented as "%3F"
That is why Кафана_„%3F” works while the former doesn't.
| [
"https://github.com/openstreetmap/iD/commit/34a07edfc9d93be1dce947428c5d6807716e4b4c",
"https://github.com/openstreetmap/iD/commit/49455bc995291a4342f21d861a6a8f629f602e3d",
"https://github.com/openstreetmap/iD/commit/7fa53f40b95ddadd688d24dcae254b3c2828a0e8",
"https://github.com/openstreetmap/iD/commit/c730e... | 2024-03-17T06:37:57 | 2.15 | JavaScript |
openstreetmap/iD | 11,158 | openstreetmap__iD-11158 | [
11133
] | 11c1a6fd86ab05afe38ce151bea182f32159e94e | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 79e60443f32..2a09e2d36fb 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -43,6 +43,7 @@ _Breaking developer changes, which may affect downstream projects or sites that
* Consider other name-like tags for labelling features, such as `lock_name` ([#9588], thanks [@k-yle])
... | diff --git a/test/spec/renderer/features.js b/test/spec/renderer/features.js
index 7ee85a73918..32e560af3d3 100644
--- a/test/spec/renderer/features.js
+++ b/test/spec/renderer/features.js
@@ -141,6 +141,9 @@ describe('iD.rendererFeatures', function() {
iD.osmWay({id: 'downhill_piste', tags: {'piste:type':... | Add rendering for climbing route features
### Description
Right now, climbing features don't have any styling
> <img width="688" alt="Image" src="https://github.com/user-attachments/assets/c988ba39-a3df-485b-933a-6d5f4ef4c737" />
[Location](https://ideditor.netlify.app/#locale=en&map=17.54/68.16505/16.59361&disable_f... | I'd like to "claim" this issue, if I can. I should have a draft PR ready to go shortly after the related schema changes land. I think you have the right idea for the design @tordans, and I'd love to discuss the specifics of the PR with you when the time comes.
For your information
- Adding new styles at this point conf... | [
"https://github.com/openstreetmap/iD/commit/a762829d05e27e8459ee8d31eeffd4de190283a8",
"https://github.com/openstreetmap/iD/commit/0cd7bf56e43af4bb943d5de62f2930b7d019f4e7",
"https://github.com/openstreetmap/iD/commit/b4e53e1ded3b4811d5b35a291a2990ee2937bb8d",
"https://github.com/openstreetmap/iD/commit/610cd... | 2025-06-27T08:47:17 | 2.15 | JavaScript | |
openstreetmap/iD | 10,801 | openstreetmap__iD-10801 | [
10672
] | 7beace6698d7bffe5c692d0a752989cc5c2cd678 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index f065f2f0e33..e72d7627e66 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -59,6 +59,7 @@ _Breaking developer changes, which may affect downstream projects or sites that
* Revalidate ways that are added to or removed from relations ([#10786])
* Preserve `crossing:markings`... | diff --git a/test/spec/validations/outdated_tags.js b/test/spec/validations/outdated_tags.js
index 1d2d04c26f1..ff0687ad3fa 100644
--- a/test/spec/validations/outdated_tags.js
+++ b/test/spec/validations/outdated_tags.js
@@ -5,13 +5,29 @@ describe('iD.validations.outdated_tags', function () {
before(function() {... | When object has NSI entry, tag fix is displayed as brand fix
### URL
_No response_
### How to reproduce the issue?
When editing an object with an NSI entry, tag fix/upgrade/suggestion warnings are shown as non-standard brand warnings.
This happens even when the corresponding tags are already present and there are n... | Hi, I would like to contribute to OpenStreetMap and ask if you can assign this issue to me. I want to contribute as much as I can and I am still a learner so I would appreciate it if you could help me out if I get stuck anywhere.
I can confirm this bug… There seems to be some unwanted interaction between the NSI matchi... | Hi, I would like to contribute to OpenStreetMap and ask if you can assign this issue to me. I want to contribute as much as I can and I am still a learner so I would appreciate it if you could help me out if I get stuck anywhere.
I can confirm this bug… There seems to be some unwanted interaction between the NSI matchi... | [
"https://github.com/openstreetmap/iD/commit/ae9e3be97ead07eb8fd715d139d988e94d894d9a",
"https://github.com/openstreetmap/iD/commit/5fb8dd00ffd86b601dc368d68b0116dde5006d36",
"https://github.com/openstreetmap/iD/commit/ef758d268825f397043d69de8d2c4b203d561eff"
] | 2025-02-22T03:10:03 | 2.15 | JavaScript |
processing/p5.js | 6,788 | processing__p5.js-6788 | [
6770
] | 23ac24b2058e17a2daaec72e63b5823d44f3e5ac | diff --git a/src/image/p5.Image.js b/src/image/p5.Image.js
index b9188c4b44..8ab3175afc 100644
--- a/src/image/p5.Image.js
+++ b/src/image/p5.Image.js
@@ -1111,7 +1111,8 @@ p5.Image = class {
*
* `img.mask()` uses another <a href="#/p5.Image">p5.Image</a> object's
* alpha channel as the alpha channel for th... | diff --git a/test/unit/image/p5.Image.js b/test/unit/image/p5.Image.js
index 0e44d84a29..6db53702d2 100644
--- a/test/unit/image/p5.Image.js
+++ b/test/unit/image/p5.Image.js
@@ -51,8 +51,44 @@ suite('p5.Image', function() {
});
suite('p5.Image.prototype.mask', function() {
- test('it should mask the image',... | Masking behaviour change between 1.4.1 and latest
### Most appropriate sub-area of p5.js?
- [ ] Accessibility
- [ ] Color
- [X] Core/Environment/Rendering
- [ ] Data
- [ ] DOM
- [ ] Events
- [ ] Image
- [ ] IO
- [ ] Math
- [ ] Typography
- [ ] Utilities
- [ ] WebGL
- [ ] Build process
- [ ] Unit testing
- [ ] Internat... | For now, setting `pixelDensity(1)` after creating your canvas seems to make it work again for me? I wonder if it broke after this https://github.com/processing/p5.js/pull/6447 and there's something we need to update to get `graphics.get()` images to mask correctly
Thank you for the swift response, just as a curiosity, ... | For now, setting `pixelDensity(1)` after creating your canvas seems to make it work again for me? I wonder if it broke after this https://github.com/processing/p5.js/pull/6447 and there's something we need to update to get `graphics.get()` images to mask correctly
Thank you for the swift response, just as a curiosity, ... | [
"https://github.com/processing/p5.js/commit/84d4d0cfe86ed70dd0ae37a4232e5b51b6fd4bed",
"https://github.com/processing/p5.js/commit/23ad4f4606f786f50b8bb31f2707aab356ce4129",
"https://github.com/processing/p5.js/commit/2e2abf521777d53b8b9927119b60ccc567677ff0",
"https://github.com/processing/p5.js/commit/f841a... | 2024-02-04T02:44:20 | 1.3 | JavaScript |
processing/p5.js | 6,069 | processing__p5.js-6069 | [
6068
] | 0cf6487547791c9ef9519752f5b434abe27857b4 | diff --git a/src/webgl/p5.RendererGL.Retained.js b/src/webgl/p5.RendererGL.Retained.js
index a024f0d67f..e32ad93d41 100644
--- a/src/webgl/p5.RendererGL.Retained.js
+++ b/src/webgl/p5.RendererGL.Retained.js
@@ -238,6 +238,8 @@ p5.RendererGL.prototype._drawPoints = function(vertices, vertexBuffer) {
pointShader.ena... | diff --git a/test/unit/webgl/p5.RendererGL.js b/test/unit/webgl/p5.RendererGL.js
index dbecaee74f..e0eabf65b7 100644
--- a/test/unit/webgl/p5.RendererGL.js
+++ b/test/unit/webgl/p5.RendererGL.js
@@ -622,6 +622,19 @@ suite('p5.RendererGL', function() {
);
done();
});
+
+ test('blendModes are applie... | blendMode not working when doing point() drawing in webgl
### Most appropriate sub-area of p5.js?
- [ ] Accessibility
- [X] Color
- [ ] Core/Environment/Rendering
- [ ] Data
- [ ] DOM
- [ ] Events
- [ ] Image
- [ ] IO
- [ ] Math
- [ ] Typography
- [ ] Utilities
- [X] WebGL
- [ ] Build Process
- [ ] Unit Testing
- [ ] ... | [
"https://github.com/processing/p5.js/commit/80b23c597f9760fd3682666cb1c6de7ff0f167c7",
"https://github.com/processing/p5.js/commit/f65e52272f704a82bbba641e5f44bf1f9973a08a",
"https://github.com/processing/p5.js/commit/16b804bac7a7c3a903df0c031cae7f24f89dcf34",
"https://github.com/processing/p5.js/commit/82b4b... | 2023-03-13T12:24:38 | 1.3 | JavaScript | ||
processing/p5.js | 6,542 | processing__p5.js-6542 | [
6540
] | 17304ce9e9ef3f967bd828102a51b62a2d39d4f4 | diff --git a/src/core/p5.Renderer.js b/src/core/p5.Renderer.js
index c869f3e6b4..21ce3bd64b 100644
--- a/src/core/p5.Renderer.js
+++ b/src/core/p5.Renderer.js
@@ -159,7 +159,7 @@ class Renderer extends p5.Element {
}
const region = new p5.Image(w*pd, h*pd);
- region._pixelDensity = pd;
+ region.pixelD... | diff --git a/test/unit/image/p5.Image.js b/test/unit/image/p5.Image.js
index 2600be63ff..0e44d84a29 100644
--- a/test/unit/image/p5.Image.js
+++ b/test/unit/image/p5.Image.js
@@ -122,4 +122,23 @@ suite('p5.Image', function() {
});
});
});
+
+ suite('p5.Graphics.get()', function() {
+ for (const densi... | get(x, y, w, h) output image width/height is doubled
### Most appropriate sub-area of p5.js?
- [ ] Accessibility
- [ ] Color
- [X] Core/Environment/Rendering
- [ ] Data
- [ ] DOM
- [ ] Events
- [x] Image
- [ ] IO
- [ ] Math
- [ ] Typography
- [ ] Utilities
- [ ] WebGL
- [ ] Build Process
- [ ] Unit Testing
- [ ] Inter... | @davepagurek @Gaurav-1306 – curious if you also experience the issue mentioned above. I tracked down the [commit](https://github.com/processing/p5.js/commit/963b77f26bb8dea7bbb25cfd010840aa17324f1d) that changed the `get()` along with similar changes for `pixelDensity()`, which came out of [this issue](https://github.... | @davepagurek @Gaurav-1306 – curious if you also experience the issue mentioned above. I tracked down the [commit](https://github.com/processing/p5.js/commit/963b77f26bb8dea7bbb25cfd010840aa17324f1d) that changed the `get()` along with similar changes for `pixelDensity()`, which came out of [this issue](https://github.... | [
"https://github.com/processing/p5.js/commit/897b9e126bba249c9101e0552862aea8afafabc0"
] | 2023-11-09T00:10:58 | 1.3 | JavaScript |
processing/p5.js | 5,970 | processing__p5.js-5970 | [
5968
] | 69702de9f245b2b960fa24f127e5e3b2b3d21ecc | diff --git a/src/webgl/p5.RenderBuffer.js b/src/webgl/p5.RenderBuffer.js
index a586fb0323..84304fdd8c 100644
--- a/src/webgl/p5.RenderBuffer.js
+++ b/src/webgl/p5.RenderBuffer.js
@@ -58,6 +58,13 @@ p5.RenderBuffer.prototype._prepareBuffer = function(geometry, shader) {
}
// enable the attribute
shader.en... | diff --git a/test/unit/webgl/p5.RendererGL.js b/test/unit/webgl/p5.RendererGL.js
index bd6b915a2e..99bd247a65 100644
--- a/test/unit/webgl/p5.RendererGL.js
+++ b/test/unit/webgl/p5.RendererGL.js
@@ -1392,6 +1392,44 @@ suite('p5.RendererGL', function() {
});
});
+ suite('Test for register availability', funct... | On my android phone sometimes objects in sketches drawn with webgl in p5.js disappear
### Most appropriate sub-area of p5.js?
- [ ] Accessibility
- [ ] Color
- [X] Core/Environment/Rendering
- [ ] Data
- [ ] DOM
- [ ] Events
- [ ] Image
- [ ] IO
- [ ] Math
- [ ] Typography
- [ ] Utilities
- [X] WebGL
- [ ] Build Proce... | Thanks for isolating the problem! Adding `geom.uvs.push([0, 0], [0, 0], [0, 0], [0, 0])` to your sketch seems to fix the issue, so that can be a temporary fix if anyone else stumbles upon this issue.
I think your solution of enabling/disabling attributes works! I think the question will be whether or not we want our... | Thanks for isolating the problem! Adding `geom.uvs.push([0, 0], [0, 0], [0, 0], [0, 0])` to your sketch seems to fix the issue, so that can be a temporary fix if anyone else stumbles upon this issue.
I think your solution of enabling/disabling attributes works! I think the question will be whether or not we want our... | [
"https://github.com/processing/p5.js/commit/15c0313cdc1d0ef3b7febfe1f748c60fca7c4c4b",
"https://github.com/processing/p5.js/commit/b1690b3632497c1715fcca9993e5a9a01f529f50",
"https://github.com/processing/p5.js/commit/cbc1677dff9d328f6e11dc35ab51a5467f70726a",
"https://github.com/processing/p5.js/commit/e8fea... | 2023-01-23T09:35:01 | 1.3 | JavaScript |
processing/p5.js | 6,990 | processing__p5.js-6990 | [
6989
] | 2f583d5e3358886d0caa0de00057053cd88fd48a | diff --git a/src/webgl/p5.Framebuffer.js b/src/webgl/p5.Framebuffer.js
index 28b0c6ec61..1347bed038 100644
--- a/src/webgl/p5.Framebuffer.js
+++ b/src/webgl/p5.Framebuffer.js
@@ -849,6 +849,7 @@ class Framebuffer {
this.target._renderer.uMVMatrix.set(
this.target._renderer._curCamera.cameraMatrix
);
+ ... | diff --git a/test/unit/webgl/p5.RendererGL.js b/test/unit/webgl/p5.RendererGL.js
index e747b12d36..1c2672b587 100644
--- a/test/unit/webgl/p5.RendererGL.js
+++ b/test/unit/webgl/p5.RendererGL.js
@@ -2462,5 +2462,42 @@ suite('p5.RendererGL', function() {
}
}
);
+
+ test(
+ 'Main canvas masks... | beginClip() is accidentally being applied to framebuffers
### Most appropriate sub-area of p5.js?
- [x] WebGL
### p5.js version
1.9.1
### Web browser and version
Chrome 124 (not Firefox, weirdly!)
### Operating system
MacOS 14.2.1
### Steps to reproduce this
### Steps:
1. Start clipping to a s... | [
"https://github.com/processing/p5.js/commit/ef4aa35b4b72369e8f9a0c76c9b8c0baa1de92b1"
] | 2024-04-22T16:32:09 | 1.3 | JavaScript | ||
nwutils/nw-builder | 1,412 | nwutils__nw-builder-1412 | [
1411
] | 548d0e5d09e091ba9eaceaa957dbd49a01becdad | diff --git a/.gitignore b/.gitignore
index 4141dd47..e8ab2294 100644
--- a/.gitignore
+++ b/.gitignore
@@ -6,3 +6,4 @@ node_modules
tests/fixtures/cache
tests/fixtures/out
+tests/fixtures/macos
diff --git a/README.md b/README.md
index f37caa13..16deabc5 100644
--- a/README.md
+++ b/README.md
@@ -30,7 +30,7 @@ Build... | diff --git a/tests/specs/bld.test.js b/tests/specs/bld.test.js
index f4362837..476e5ee0 100644
--- a/tests/specs/bld.test.js
+++ b/tests/specs/bld.test.js
@@ -22,7 +22,7 @@ describe.skip('bld test suite', async () => {
platform: util.PLATFORM_KV[process.platform],
arch: util.ARCH_KV[process.arch],
downlo... | "The version manifest does not exist/was not downloaded. Please try again in some time."
The script that I was using usually works fine without any issues. However, this just happened now as I was trying to publish a release. The build failed and spit out this error:
```
"The version manifest does not exist/was not dow... | The fix would be to update the link from `https://nwjs.io/versions` to `https://nwjs.io/versions.json` in the repo. Feel free to open a PR!
| The fix would be to update the link from `https://nwjs.io/versions` to `https://nwjs.io/versions.json` in the repo. Feel free to open a PR!
| [
"https://github.com/nwutils/nw-builder/commit/5d0fe66c025134d9a4d216f98ca4f207d7eaa020",
"https://github.com/nwutils/nw-builder/commit/87236cedbe05a8b9ca14d552381acb033759f7b3"
] | 2025-07-07T07:46:57 | 4.13 | JavaScript |
nwutils/nw-builder | 1,236 | nwutils__nw-builder-1236 | [
1235
] | 6135682dc01f8a1dad12660957ddd637e6a20864 | diff --git a/README.md b/README.md
index 7324dfc8..e824474d 100644
--- a/README.md
+++ b/README.md
@@ -286,6 +286,7 @@ This object defines additional properties used for building for a specific platf
| CFBundleVersion | `string` | The version of the build that identifies an iteration of the bundle. |
| CFBundleShortV... | diff --git a/tests/specs/osx.test.js b/tests/specs/osx.test.js
index ed4dabaf..5a15ba21 100644
--- a/tests/specs/osx.test.js
+++ b/tests/specs/osx.test.js
@@ -80,7 +80,8 @@ describe.runIf(process.platform === 'darwin')('bld/setOsxConfig', async function
CFBundleSpokenName: 'Demo',
CFBundleVersion: '0.... | New mac-specific option needed: `NSLocalNetworkUsageDescription`
### Issue Type
- [ ] Bug Report
- [x] Feature Request
- [ ] Other
### Current/Missing Behaviour
macOS 15 now requires `NSLocalNetworkUsageDescription` in the `Info.plist` to enable local networking, so we need to be able to specify it.
### E... | https://developer.apple.com/documentation/bundleresources/information_property_list/nslocalnetworkusagedescription
@beaugunderson Looks like it is supported since MacOS 11. Are you open to creating a pull request?
There's a FAQ here as well: https://developer.apple.com/forums/thread/663858
Very open! I'll do that now.... | https://developer.apple.com/documentation/bundleresources/information_property_list/nslocalnetworkusagedescription
@beaugunderson Looks like it is supported since MacOS 11. Are you open to creating a pull request?
There's a FAQ here as well: https://developer.apple.com/forums/thread/663858
Very open! I'll do that now.... | [
"https://github.com/nwutils/nw-builder/commit/5a807632ce926f4c97af1e3ed3717f7cf33dbce5"
] | 2024-09-20T02:16:03 | 4.11 | JavaScript |
nwutils/nw-builder | 990 | nwutils__nw-builder-990 | [
931
] | eb7906abeea67445bd66f7b6ace9cea9783aeee0 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 9c430e95b..3cdaa92c1 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -7,9 +7,22 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
## [Unreleased]
+## [4.5.1] - 2023-12-19
+
+### Changed
+
+- Manually create symbolic links for MacOS builds.
+
+#... | diff --git a/.github/workflows/e2e.yml b/.github/workflows/e2e.yml
index 4e08d24a6..9a2cec376 100644
--- a/.github/workflows/e2e.yml
+++ b/.github/workflows/e2e.yml
@@ -36,7 +36,5 @@ jobs:
run: npm ci
- name: Check for linting errors
run: npm run lint
- - name: Link module
- run: np... | Symlinks are copied as files on decompress
### Issue Type
- [x] Bug Report
- [ ] Feature Request
- [ ] Other
### Current/Missing Behaviour
- Symbolic link is copied as a file and the link is lost. More info [here](https://github.com/nwutils/nw-builder/issues/923).
### Expected/Proposed Behaviour
- Symb... | Good work!
I'll test this on our build server asap
Still doesn't work. These are files instead of symlinks
static:nwjs Framework.framework distiller$ ls -al
total 32
drwxr-xr-x 7 distiller staff 224 Aug 25 07:34 .
drwxr-xr-x 3 distiller staff 96 Aug 25 07:34 ..
-rwxr-xr-x 1 distiller staff 24 Aug 25 07:34 Helpe... | Good work!
I'll test this on our build server asap
Still doesn't work. These are files instead of symlinks
static:nwjs Framework.framework distiller$ ls -al
total 32
drwxr-xr-x 7 distiller staff 224 Aug 25 07:34 .
drwxr-xr-x 3 distiller staff 96 Aug 25 07:34 ..
-rwxr-xr-x 1 distiller staff 24 Aug 25 07:34 Helpe... | [
"https://github.com/nwutils/nw-builder/commit/986b9d5db9e371e80944ff5cb0ed4ba9b1ed4ec3",
"https://github.com/nwutils/nw-builder/commit/9e8a488ef7b51a5843244d11ddd8df06c47dc51c",
"https://github.com/nwutils/nw-builder/commit/b56ccf1379fe9db1b789094add58cc32a0ca6776",
"https://github.com/nwutils/nw-builder/comm... | 2023-12-07T04:52:28 | 4.5 | JavaScript |
nwutils/nw-builder | 772 | nwutils__nw-builder-772 | [
770
] | b6d561274be434c13311d5e1bb0b086e7a86578a | diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index 7b18db739..389ade3c1 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -3,7 +3,9 @@ Fixes: #
- [ ] Format
- [ ] Lint
- [ ] Test
+- [ ] Docs
- [ ] Add name to AUTHORS (first time contributors)... | diff --git a/test/e2e/cli.js b/test/e2e/cli.js
index 41b97cb38..bb7090a02 100644
--- a/test/e2e/cli.js
+++ b/test/e2e/cli.js
@@ -1,3 +1,5 @@
import { exec } from "child_process";
-exec("nwbuild ./nwapp/**/* ./node_modules/**/* --mode=build --version=latest --flavour=normal --platform=win --arch=x64 --outDir=./build"... | manifest.json not being downloaded due to inexistent cache directory
### Issue Type
- [X] Bug Fix
- [ ] Feature
- [ ] Other
### Current/Missing Behaviour
Currently, the `cache` directory is not created when running the nwbuild CLI, resulting in the error below:
![image](https://user-images.githubusercontent.c... | Create cache code:
https://github.com/nwutils/nw-builder/blob/d39a6d345edead51ca74c726f44560d554697c2c/src/nwbuild.js#L147-L156
Get release info code:
https://github.com/nwutils/nw-builder/blob/d39a6d345edead51ca74c726f44560d554697c2c/src/nwbuild.js#L138-L142
Looks like the create cache dir code is after the `g... | Create cache code:
https://github.com/nwutils/nw-builder/blob/d39a6d345edead51ca74c726f44560d554697c2c/src/nwbuild.js#L147-L156
Get release info code:
https://github.com/nwutils/nw-builder/blob/d39a6d345edead51ca74c726f44560d554697c2c/src/nwbuild.js#L138-L142
Looks like the create cache dir code is after the `g... | [
"https://github.com/nwutils/nw-builder/commit/83f30fb1b70e5ed074d3e1235b1f9d364a309506",
"https://github.com/nwutils/nw-builder/commit/b39ff9a7c5757bed67533f2aed1e0babbd515da0",
"https://github.com/nwutils/nw-builder/commit/e9a12c6273d26572ae40f762283e3a708f6f1435",
"https://github.com/nwutils/nw-builder/comm... | 2023-01-15T22:44:34 | 4.0 | JavaScript |
nwutils/nw-builder | 904 | nwutils__nw-builder-904 | [
897
] | daff3f8a3e0843fd45742af9c248b0eec5e05be0 | diff --git a/changelog.md b/changelog.md
index 58700f448..397cc5a16 100644
--- a/changelog.md
+++ b/changelog.md
@@ -7,6 +7,16 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
## [Unreleased]
+## [4.3.3] - 2023-07-11
+
+## Changed
+
+- Set `NSHumanReadableCopyright` property in `*.app/Reso... | diff --git a/test/fixture/demo.js b/test/fixture/demo.js
index b2c7a1718..33a96c81d 100644
--- a/test/fixture/demo.js
+++ b/test/fixture/demo.js
@@ -5,14 +5,13 @@ await nwbuild({
version: "latest",
srcDir: "app",
platform: "osx",
- arch: "arm64",
- downloadUrl: "https://github.com/corwin-of-amber/nw.js/relea... | [osx64] Copyright is not configurable - always set to default nwjs
### Issue Type
- [X] Bug Report
- [ ] Feature Request
- [ ] Other
### Current/Missing Behaviour
Given the following:
```
await nwbuild({
mode: 'build',
version: '0.70.0',
flavor: 'normal',
platform: 'osx',... | I'm pretty sure CFBundleGetInfoString is no longer supported/used in OSX 10 and above. Let me see what I can do about this.
https://github.com/nwutils/nw-builder/commit/5864c5b7458a8324abb90134c104e9b7a33dface
Updating `NSHumanReadableCopyright` in `Contents/Resources/en.lproj/InfoPlist.strings` did not update the cop... | I'm pretty sure CFBundleGetInfoString is no longer supported/used in OSX 10 and above. Let me see what I can do about this.
https://github.com/nwutils/nw-builder/commit/5864c5b7458a8324abb90134c104e9b7a33dface
Updating `NSHumanReadableCopyright` in `Contents/Resources/en.lproj/InfoPlist.strings` did not update the cop... | [
"https://github.com/nwutils/nw-builder/commit/5864c5b7458a8324abb90134c104e9b7a33dface",
"https://github.com/nwutils/nw-builder/commit/8ccfddfd92d986b27a67882ac779568017c06090",
"https://github.com/nwutils/nw-builder/commit/1430ef024f8c7da8b3a8f4581da4e51b176e2158",
"https://github.com/nwutils/nw-builder/comm... | 2023-07-19T12:12:34 | 4.3 | JavaScript |
sindresorhus/execa | 722 | sindresorhus__execa-722 | [
718
] | 5eeaab5953b29147f3899614172538c45ab29a57 | diff --git a/lib/stream.js b/lib/stream.js
index 153acff003..6192917fb7 100644
--- a/lib/stream.js
+++ b/lib/stream.js
@@ -118,6 +118,7 @@ export const getSpawnedResult = async ({
const stdioPromises = spawned.stdio.map((stream, index) => getStdioPromise({stream, stdioStreams: stdioStreamsGroups[index], encoding, b... | diff --git a/test/stdio/node-stream.js b/test/stdio/node-stream.js
index 9e3e338afe..5b440bc269 100644
--- a/test/stdio/node-stream.js
+++ b/test/stdio/node-stream.js
@@ -2,6 +2,8 @@ import {once} from 'node:events';
import {createReadStream, createWriteStream} from 'node:fs';
import {readFile, writeFile, rm} from 'n... | Wait for streams completion on errors
When passing a `{ file }`, `Writable` or `WritableStream` to the `stdout`/`stderr` option, and the process is terminated (e.g. due to a `timeout`), those streams are destroyed. However, we currently do not wait for their destruction before resolving the Execa promise. We should do ... | [
"https://github.com/sindresorhus/execa/commit/62efe60633b27f6128add562bf9beae9d24ce753"
] | 2024-01-23T21:17:29 | 0.0 | JavaScript | ||
sindresorhus/execa | 873 | sindresorhus__execa-873 | [
872
] | 7b044bb41968b24c47a42c9b8163f2f3fd9e541d | diff --git a/lib/arguments/escape.js b/lib/arguments/escape.js
index 22afd7104b..2bb3ad6522 100644
--- a/lib/arguments/escape.js
+++ b/lib/arguments/escape.js
@@ -7,9 +7,7 @@ export const joinCommand = (filePath, rawArgs) => {
return {command, escapedCommand};
};
-const escapeControlCharacters = arg => typeof arg ... | diff --git a/test/arguments/options.js b/test/arguments/options.js
index 710076bf1a..059c497ee5 100644
--- a/test/arguments/options.js
+++ b/test/arguments/options.js
@@ -133,6 +133,40 @@ test('execa()\'s second argument must be an array', testInvalidArgs, execa);
test('execaSync()\'s second argument must be an array'... | Improve validation of process arguments
We currently validate that the file passed as argument is a string, the arguments is an array and the options is a plain object.
We should also validate that the arguments are not objects. Allowing non-string primitive types might be ok since that's pretty common to pass those... | [
"https://github.com/sindresorhus/execa/commit/741db309a19578e8f6fb009a01d4226053ad6622"
] | 2024-03-01T05:14:19 | 0.0 | JavaScript | ||
sindresorhus/execa | 757 | sindresorhus__execa-757 | [
580,
743
] | d16c305163f815b7cf8e1e1128e3f3819388a6be | diff --git a/docs/scripts.md b/docs/scripts.md
index 762429e39c..d45be60619 100644
--- a/docs/scripts.md
+++ b/docs/scripts.md
@@ -6,7 +6,7 @@ With Execa, you can write scripts with Node.js instead of a shell language. It i
import {$} from 'execa';
const {stdout: name} = await $`cat package.json`
- .pipeStdout($({... | diff --git a/index.test-d.ts b/index.test-d.ts
index b4bc972d28..72d0a2f70a 100644
--- a/index.test-d.ts
+++ b/index.test-d.ts
@@ -82,23 +82,14 @@ try {
const execaBufferPromise = execa('unicorns', {encoding: 'buffer', all: true});
const writeStream = createWriteStream('output.txt');
- expectAssignable<Function |... | TypeScript: pipeStdout (and other pipeXxx) is optional property
What is the reason to keep it optional?
```ts
pipeStdout?<Target extends ExecaChildPromise<StdoutStderrAll>>(target: Target): Target;
pipeStdout?(target: WritableStream | string): ExecaChildProcess<StdoutStderrType>;
```
It can't be user without ... | Hi @koshic,
[`pipeStdout()`](https://github.com/sindresorhus/execa#pipestdouttarget) is `undefined` if the [`stdout` option](https://github.com/sindresorhus/execa#stdout-1) is `'ignore'`, `'ipc'`, a file descriptor integer, or a stream. Default value is `'pipe'`.
The same applies to [`pipeStderr()`](https://github.... | Hi @koshic,
[`pipeStdout()`](https://github.com/sindresorhus/execa#pipestdouttarget) is `undefined` if the [`stdout` option](https://github.com/sindresorhus/execa#stdout-1) is `'ignore'`, `'ipc'`, a file descriptor integer, or a stream. Default value is `'pipe'`.
The same applies to [`pipeStderr()`](https://github.... | [
"https://github.com/sindresorhus/execa/commit/0e47a09b8d4b3968579c826263b1d93857a647e7"
] | 2024-01-30T03:42:14 | 0.0 | JavaScript |
sindresorhus/execa | 699 | sindresorhus__execa-699 | [
121,
695
] | b8c1f555f607733a9a66787527f9ab4d1ace12a5 | diff --git a/docs/transform.md b/docs/transform.md
index 885031e424..3305f0bf33 100644
--- a/docs/transform.md
+++ b/docs/transform.md
@@ -7,9 +7,10 @@ Transforms map or filter the input or output of a child process. They are define
```js
import {execa} from 'execa';
-const transform = async function * (chunks) {
-... | diff --git a/index.test-d.ts b/index.test-d.ts
index 5f6c04c3e8..0600177d09 100644
--- a/index.test-d.ts
+++ b/index.test-d.ts
@@ -569,35 +569,35 @@ const asyncStringGenerator = async function * () {
const fileUrl = new URL('file:///test');
-const stringOrUint8ArrayGenerator = async function * (chunks: Iterable<st... | Ability to prefix child process stdio lines with a custom string
Proposal: add a new option `prefix` (optional, string). If given, the child's stdout and stderr streams would be transformed so **each line** is prefixed with the given string.
Use case: when running several child processes in parallel and using `inher... | It's not possible to intercept the stdout/stderr when you're using `inherit` (Really wish it was though). We could support it on `pipe`, but not sure it belongs here.
Can't we just reimplement `inherit` so it doesn't actually use the underlying cp's `inherit`? AFAICT inherit is just shorthand for `[process.stdin, proce... | It's not possible to intercept the stdout/stderr when you're using `inherit` (Really wish it was though). We could support it on `pipe`, but not sure it belongs here.
Can't we just reimplement `inherit` so it doesn't actually use the underlying cp's `inherit`? AFAICT inherit is just shorthand for `[process.stdin, proce... | [
"https://github.com/sindresorhus/execa/commit/e8db3cacbee7715b2f7934793bbad22456d58fe9",
"https://github.com/sindresorhus/execa/commit/51881563dec1a20ad9d336d0c20c49908c887121",
"https://github.com/sindresorhus/execa/commit/57aee674db88342f3a83fad9a507f86272729669",
"https://github.com/sindresorhus/execa/comm... | 2024-01-17T21:05:51 | 0.0 | JavaScript |
sindresorhus/execa | 794 | sindresorhus__execa-794 | [
782
] | 4080212af658c0ec8c839b3c906564cfec39dc76 | diff --git a/index.d.ts b/index.d.ts
index fef129c2df..65865c9032 100644
--- a/index.d.ts
+++ b/index.d.ts
@@ -309,7 +309,6 @@ type CommonOptions<IsSync extends boolean = boolean> = {
- `'pipe'`: Sets [`childProcess.stdin`](https://nodejs.org/api/child_process.html#subprocessstdin) stream.
- `'overlapped'`: Like `'... | diff --git a/index.test-d.ts b/index.test-d.ts
index 72d0a2f70a..a1f330f787 100644
--- a/index.test-d.ts
+++ b/index.test-d.ts
@@ -1233,6 +1233,8 @@ expectError(execaSync('unicorns', {stdio: [[[new Uint8Array(), new Uint8Array()]
expectError(execaSync('unicorns', {stdio: [[[{}, {}]]]}));
expectError(execaSync('unicor... | `ipc` option
When using Node.js IPC feature (which is pretty nice), I sometimes find having to add `'ipc'` at the end of the `stdio` array slightly cumbersome. It is also potentially error-prone, since one needs to remember for it to be the 4th item (or later), and not to repeat it (as some users might be tempted to). ... | > I am wondering whether Node.js should have exposed this feature using an { ipc: true } option instead? Should we add that option, which would automatically add ipc to the underlying stdio option? We would then undocument passing ipc to the stdio option, but still support it for compatibility.
Yes, I agree that Nod... | > I am wondering whether Node.js should have exposed this feature using an { ipc: true } option instead? Should we add that option, which would automatically add ipc to the underlying stdio option? We would then undocument passing ipc to the stdio option, but still support it for compatibility.
Yes, I agree that Nod... | [
"https://github.com/sindresorhus/execa/commit/7765d9dc233415d0ac14392c4790b3cee51b09a9"
] | 2024-02-07T01:38:50 | 0.0 | JavaScript |
style-dictionary/style-dictionary | 1,322 | style-dictionary__style-dictionary-1322 | [
1320
] | ccf27b7c364a5a4ee190463c1c2b3e07ac169dde | diff --git a/.changeset/seven-dolphins-dream.md b/.changeset/seven-dolphins-dream.md
new file mode 100644
index 000000000..e20be5587
--- /dev/null
+++ b/.changeset/seven-dolphins-dream.md
@@ -0,0 +1,5 @@
+---
+'style-dictionary': patch
+---
+
+Added link to logging documentation inside all of the warnings and errors th... | diff --git a/__integration__/__snapshots__/nameCollisions.test.snap.js b/__integration__/__snapshots__/nameCollisions.test.snap.js
index fe25bec64..9dee061e1 100644
--- a/__integration__/__snapshots__/nameCollisions.test.snap.js
+++ b/__integration__/__snapshots__/nameCollisions.test.snap.js
@@ -17,6 +17,7 @@ snapshots... | Error message that suggests setting log.verbosity to verbose should link to docs
Would be nice if the error message about setting the log.verbosity to verbose gave a link to the Logging section in the docs so the user can see how exactly to do this, as this isn't always immediately clear to users just from the error me... | [
"https://github.com/style-dictionary/style-dictionary/commit/f142f6fc0602fe960024658815d558a34df462db"
] | 2024-08-27T12:39:31 | 2.10 | JavaScript | ||
style-dictionary/style-dictionary | 1,033 | style-dictionary__style-dictionary-1033 | [
986
] | f88fe97f696909f4eecd72ffc3a04b3b7a417189 | diff --git a/lib/common/formatHelpers/createPropertyFormatter.js b/lib/common/formatHelpers/createPropertyFormatter.js
index 2e28ea718..e41eaad94 100644
--- a/lib/common/formatHelpers/createPropertyFormatter.js
+++ b/lib/common/formatHelpers/createPropertyFormatter.js
@@ -184,7 +184,10 @@ function createPropertyFormatt... | diff --git a/__tests__/common/formatHelpers/createPropertyFormatter.test.js b/__tests__/common/formatHelpers/createPropertyFormatter.test.js
index a80e0c264..b3864d266 100644
--- a/__tests__/common/formatHelpers/createPropertyFormatter.test.js
+++ b/__tests__/common/formatHelpers/createPropertyFormatter.test.js
@@ -114... | Does not output reference when values is zero
When using `outputReference`, if the referenced alias has a value of zero it being ignored and the reference is not being replaced.
Input to recreate the issue:
```code
// json
{
"Offset": {
"value": "0",
"type": "other"
},
"Spacing": {
"value"... | Like [here](https://github.com/amzn/style-dictionary/issues/988) you can use function in `filter`
```
function(token) {
// omit empty or zero tokens
if (token.value !=0) {
return token
}
```
I have reproduced this bug. There have been some fixes to outp... | Like [here](https://github.com/amzn/style-dictionary/issues/988) you can use function in `filter`
```
function(token) {
// omit empty or zero tokens
if (token.value !=0) {
return token
}
```
I have reproduced this bug. There have been some fixes to outp... | [
"https://github.com/style-dictionary/style-dictionary/commit/83a9934c4bda0bfe6ba711b92ddee6a064dfb0e5"
] | 2023-10-24T13:02:44 | 2.10 | JavaScript |
style-dictionary/style-dictionary | 1,370 | style-dictionary__style-dictionary-1370 | [
1365
] | f1f60f1252766dfc1a44cd2031cd7f3e66cf8a64 | diff --git a/.changeset/gentle-lamps-add.md b/.changeset/gentle-lamps-add.md
new file mode 100644
index 000000000..f4d55b749
--- /dev/null
+++ b/.changeset/gentle-lamps-add.md
@@ -0,0 +1,5 @@
+---
+'style-dictionary': patch
+---
+
+Pass PlatformConfig as options param to platform-applied preprocessors.
diff --git a/doc... | diff --git a/__tests__/register/preprocessor.test.js b/__tests__/register/preprocessor.test.js
index f3d66d37e..da846759e 100644
--- a/__tests__/register/preprocessor.test.js
+++ b/__tests__/register/preprocessor.test.js
@@ -23,11 +23,11 @@ registerSuite({
});
describe('register/transformGroup', async () => {
- le... | options param is not populated when running preprocessor at platform level
I have a custom preprocessor which I want to run only on a single platform, however I want access to the config via the `options` param that is passed to the `preprocess` function. If I specify this preprocessor at the root level, the `options` ... | [
"https://github.com/style-dictionary/style-dictionary/commit/a67ed31f5bde275b8e222431e093b1b5a364032b"
] | 2024-10-16T14:32:40 | 2.10 | JavaScript | ||
style-dictionary/style-dictionary | 1,474 | style-dictionary__style-dictionary-1474 | [
1451
] | 31c29df0382a61b085f6392dc3225c5009fbffc5 | diff --git a/.changeset/friendly-rice-hide.md b/.changeset/friendly-rice-hide.md
new file mode 100644
index 000000000..5bf7fe9a8
--- /dev/null
+++ b/.changeset/friendly-rice-hide.md
@@ -0,0 +1,5 @@
+---
+'style-dictionary': minor
+---
+
+Add a 'flat' option to the javascriptEsm format
diff --git a/docs/src/content/docs... | diff --git a/__tests__/formats/__snapshots__/javascriptEsmFlat.test.snap.js b/__tests__/formats/__snapshots__/javascriptEsmFlat.test.snap.js
new file mode 100644
index 000000000..ab8ad07d3
--- /dev/null
+++ b/__tests__/formats/__snapshots__/javascriptEsmFlat.test.snap.js
@@ -0,0 +1,15 @@
+/* @web/test-runner snapshot v... | [Format Request]: Javascript esm flattern format request
Hi,
I know there is [javascriptModuleFlat](https://github.com/amzn/style-dictionary/blob/main/lib/common/formats.js#L483) format, wondering if there is a similar one but with esm export? basically, it's replacing `module.exports` with `export default`. I tried ... | Hi @kossel,
I hope you're well?
I don't know if I understood your question correctly, but it seems to me that StyleDictionary already allows you to do this natively using the built-in format: **javascript/esm**.
You can see the associated documentation here:
=> https://styledictionary.com/reference/hooks/formats/prede... | Hi @kossel,
I hope you're well?
I don't know if I understood your question correctly, but it seems to me that StyleDictionary already allows you to do this natively using the built-in format: **javascript/esm**.
You can see the associated documentation here:
=> https://styledictionary.com/reference/hooks/formats/prede... | [
"https://github.com/style-dictionary/style-dictionary/commit/c0a219ae351b537c5f8fb44b0f5a8c6599030273",
"https://github.com/style-dictionary/style-dictionary/commit/ac0f054f5894b3f0daa82772b259695f2832ca03",
"https://github.com/style-dictionary/style-dictionary/commit/db197dc61f1b11b3b187d5b4b5e0018280c83b60",
... | 2025-03-19T09:56:14 | 2.10 | JavaScript |
style-dictionary/style-dictionary | 1,562 | style-dictionary__style-dictionary-1562 | [
1316
] | 0dba4ccde6ced7bcd8677e6d74052740c6aae05e | diff --git a/.changeset/short-garlics-search.md b/.changeset/short-garlics-search.md
new file mode 100644
index 000000000..c63f2e769
--- /dev/null
+++ b/.changeset/short-garlics-search.md
@@ -0,0 +1,5 @@
+---
+'style-dictionary': patch
+---
+
+Fix an issue with token collisions being way to eager about complaining when... | diff --git a/__integration__/logging/__snapshots__/config.test.snap.js b/__integration__/logging/__snapshots__/config.test.snap.js
index 1aa37996b..7e6b59e71 100644
--- a/__integration__/logging/__snapshots__/config.test.snap.js
+++ b/__integration__/logging/__snapshots__/config.test.snap.js
@@ -2,14 +2,14 @@
export c... | Unexpected collision log
As discussed in #1308, the following two files:
```
// colors-1.json
{
"colors": {
"$type": "color",
"black": { "$value": "#000000" }
}
}
```
```
// colors-2.json
{
"colors": {
"$type": "color",
"white": { "$value": "#ffffff" }
}
}
```
Result in th... | Confirmed bug: https://github.com/amzn/style-dictionary/blob/main/lib/utils/deepExtend.js#L93 here somewhere
| Confirmed bug: https://github.com/amzn/style-dictionary/blob/main/lib/utils/deepExtend.js#L93 here somewhere
| [
"https://github.com/style-dictionary/style-dictionary/commit/d2f7923953947d55e78b889a61d81754da8589fb"
] | 2025-08-28T14:48:39 | 2.10 | JavaScript |
playcanvas/engine | 7,482 | playcanvas__engine-7482 | [
7481
] | 3831b938ed9444b61d02edf26e8a3c6804924b26 | diff --git a/src/framework/handlers/gsplat.js b/src/framework/handlers/gsplat.js
index dd34a15768f..74bd60fef43 100644
--- a/src/framework/handlers/gsplat.js
+++ b/src/framework/handlers/gsplat.js
@@ -14,7 +14,7 @@ class GSplatHandler extends ResourceHandler {
*/
constructor(app) {
super(app, 'gspla... | diff --git a/test/assets/test.ply b/test/assets/test.ply
new file mode 100644
index 00000000000..4d647177dab
Binary files /dev/null and b/test/assets/test.ply differ
diff --git a/test/framework/asset/asset-list-loader.test.mjs b/test/framework/asset/asset-list-loader.test.mjs
index 1850cfce82f..b09276c570b 100644
--- a... | Splats multi app - Failed to compile vertex shader
Currently, it's not possible to render splats when multiple `Application` instances exist within the page. When separate splat assets are loaded into separate Applications, it fails to render either splat and throws a `Failed to compile vertex shader` error.
See [this... | [
"https://github.com/playcanvas/engine/commit/c0903f971469521679141b456f242d054de7cc97"
] | 2025-03-26T10:39:22 | 0.0 | JavaScript | ||
playcanvas/engine | 5,413 | playcanvas__engine-5413 | [
3808,
4426
] | c1bc7412806230a33ec7a447f1fc300d9c22974d | diff --git a/src/framework/anim/evaluator/anim-clip.js b/src/framework/anim/evaluator/anim-clip.js
index a58e7db805d..5edba2d97bc 100644
--- a/src/framework/anim/evaluator/anim-clip.js
+++ b/src/framework/anim/evaluator/anim-clip.js
@@ -9,6 +9,12 @@ import { AnimSnapshot } from './anim-snapshot.js';
* @ignore
*/
c... | diff --git a/test/framework/anim/evaluator/anim-clip.test.mjs b/test/framework/anim/evaluator/anim-clip.test.mjs
index 075c239a579..a70458bb1c0 100644
--- a/test/framework/anim/evaluator/anim-clip.test.mjs
+++ b/test/framework/anim/evaluator/anim-clip.test.mjs
@@ -19,7 +19,9 @@ describe('AnimClip', function () {
... | Make anim events fire for reversed anims.
### Description
Make anim events work when an animation is running in reverse due to using a negative speed setting.
### Steps to Reproduce
In the Animation Events example, if you swap the sign on the speed, the anim events don't fire:
`113: modelEntity.anim.assignA... | forum link https://forum.playcanvas.com/t/anim-events-for-reversed-anims/23346/3
Hey, just wanted to check if there has been any progress on this issue? I frequently run into it when linking sounds to animations.
Unfortunately, no progress on this
| forum link https://forum.playcanvas.com/t/anim-events-for-reversed-anims/23346/3
Hey, just wanted to check if there has been any progress on this issue? I frequently run into it when linking sounds to animations.
Unfortunately, no progress on this
| [
"https://github.com/playcanvas/engine/commit/c3292f45e3712821928b73250966622b91b85b49",
"https://github.com/playcanvas/engine/commit/df11bc857d487f54acf72ecef2b2640023bea006",
"https://github.com/playcanvas/engine/commit/fe7429b6649f2d59596dcdb2c3090bb857c456f8",
"https://github.com/playcanvas/engine/commit/3... | 2023-06-19T15:50:14 | 1.66 | JavaScript |
playcanvas/engine | 6,648 | playcanvas__engine-6648 | [
6647
] | 5a6ff8668e0c0f3deb56ce89d4897b523b020abd | diff --git a/src/core/sort.js b/src/core/sort.js
index 062667ced3a..627891ff00e 100644
--- a/src/core/sort.js
+++ b/src/core/sort.js
@@ -6,6 +6,15 @@
*/
const cmpPriority = (a, b) => a.priority - b.priority;
+
+/**
+ * @param {{order: number}} a - First object with `order` property.
+ * @param {{order: number}} b ... | diff --git a/test/framework/entity.test.mjs b/test/framework/entity.test.mjs
index 51dd33c1ea3..1cd6385078e 100644
--- a/test/framework/entity.test.mjs
+++ b/test/framework/entity.test.mjs
@@ -32,6 +32,7 @@ import { DummyComponentSystem } from './test-component/system.mjs';
import { HTMLCanvasElement } from '@playcanv... | Allow entity components enabling order on hierarchy change
When working with custom components (e.g. added via code), we need some components to be enabled before others. At the moment the components are called in random order:
https://github.com/playcanvas/engine/blob/55a3ff8845f0cf30829aeec515f24ac98b6baf4d/src/fr... | This is also the reason, why Collision Component system sometimes creates a new Trigger, which gets immediately destroyed.
First, Collision Component is added and a Trigger is created, since no Rigidbody Component is available yet:
https://github.com/playcanvas/engine/blob/55a3ff8845f0cf30829aeec515f24ac98b6baf4d/... | This is also the reason, why Collision Component system sometimes creates a new Trigger, which gets immediately destroyed.
First, Collision Component is added and a Trigger is created, since no Rigidbody Component is available yet:
https://github.com/playcanvas/engine/blob/55a3ff8845f0cf30829aeec515f24ac98b6baf4d/... | [
"https://github.com/playcanvas/engine/commit/8e5a7baf5fc6e0aace8dc7034692da84935b5a04",
"https://github.com/playcanvas/engine/commit/0508a0211e3140d9dd03f4fce3f16b8e98584247",
"https://github.com/playcanvas/engine/commit/8843d0f7328b32850140e1f0e3907b3cb86aac0a",
"https://github.com/playcanvas/engine/commit/8... | 2024-06-03T12:01:49 | 1.71 | JavaScript |
playcanvas/engine | 8,003 | playcanvas__engine-8003 | [
8002
] | bf0ece5974f883d61f98c21ea50cc8708c51fd38 | diff --git a/src/framework/handlers/template.js b/src/framework/handlers/template.js
index c580999d45e..c4f915f95da 100644
--- a/src/framework/handlers/template.js
+++ b/src/framework/handlers/template.js
@@ -52,6 +52,18 @@ class TemplateHandler extends ResourceHandler {
this.decoder ??= new TextDecoder('utf-8... | diff --git a/test/framework/handlers/template-handler.test.mjs b/test/framework/handlers/template-handler.test.mjs
new file mode 100644
index 00000000000..2919e4588c4
--- /dev/null
+++ b/test/framework/handlers/template-handler.test.mjs
@@ -0,0 +1,67 @@
+import { expect } from 'chai';
+
+import { Asset } from '../../..... | When updating the raw `data` of a template asset, the associated template does not get updated
### Issue
In the Editor, template assets get updated, when the user applies an override on them. The underlying raw `data` gets updated here:
https://github.com/playcanvas/engine/blob/2d32970cbc83dcc6e0aefcc77956d5fd547bcd2... | [
"https://github.com/playcanvas/engine/commit/2d32970cbc83dcc6e0aefcc77956d5fd547bcd26"
] | 2025-09-26T11:27:33 | 0.0 | JavaScript | ||
playcanvas/engine | 5,702 | playcanvas__engine-5702 | [
5114
] | def1935aac72e670ec4bbf15531b45edc50ae444 | diff --git a/src/core/math/vec2.js b/src/core/math/vec2.js
index 10add95fa24..97765fbe2cf 100644
--- a/src/core/math/vec2.js
+++ b/src/core/math/vec2.js
@@ -103,6 +103,27 @@ class Vec2 {
return this;
}
+ /**
+ * Adds a 2-dimensional vector scaled by scalar value. Does not modify the vector being ... | diff --git a/test/core/math/vec2.test.mjs b/test/core/math/vec2.test.mjs
index 843f66a2c57..9aa91803b82 100644
--- a/test/core/math/vec2.test.mjs
+++ b/test/core/math/vec2.test.mjs
@@ -76,6 +76,17 @@ describe('Vec2', function () {
});
+ describe('#addScaled', function () {
+
+ it('adds a scaled vecto... | Add vector + scaled vector math
A feature request here.
I know, we don't want to bloat the vector math with convenience methods. However, this one I found I am using too often. Almost every time I do any vector math - when I am trying to add a scaled vector (without changing the original) to another vector.
Norma... | Definitely could be useful.
You can also add a function to your Vec3 prototype, but agree, not as convenient.
Can this be called a more generic approach? Offseting an existing point with a scaled normal.
Example:
```js
pc.Vec3.prototype.mulAdd = function (a, s, b) {
this.x = a.x + s * b.x;
this.y = a.... | Definitely could be useful.
You can also add a function to your Vec3 prototype, but agree, not as convenient.
Can this be called a more generic approach? Offseting an existing point with a scaled normal.
Example:
```js
pc.Vec3.prototype.mulAdd = function (a, s, b) {
this.x = a.x + s * b.x;
this.y = a.... | [
"https://github.com/playcanvas/engine/commit/8addce8bdd3a9b155b38cee40792b79152c8253b",
"https://github.com/playcanvas/engine/commit/1ab03070fbd5dd60f5181d885a5d0ec62c1e8c50",
"https://github.com/playcanvas/engine/commit/e33f1df7fc5ba8c299c31260bbe696bb0e53d5d1",
"https://github.com/playcanvas/engine/commit/5... | 2023-10-01T12:31:34 | 1.66 | JavaScript |
clientIO/joint | 2,385 | clientIO__joint-2385 | [
2379
] | 8d3a09f4988880034b090b5b3c361613b26afa97 | diff --git a/src/util/util.mjs b/src/util/util.mjs
index 57d08f1a0..fe369310a 100644
--- a/src/util/util.mjs
+++ b/src/util/util.mjs
@@ -631,7 +631,7 @@ export const breakText = function(text, size, styles = {}, opt = {}) {
// If separator is a RegExp, we use the space character to join words together again (not i... | diff --git a/test/jointjs/core/util.js b/test/jointjs/core/util.js
index a5c442fb9..b0e1545ed 100644
--- a/test/jointjs/core/util.js
+++ b/test/jointjs/core/util.js
@@ -402,6 +402,79 @@ QUnit.module('util', function(hooks) {
assert.notOk(r.includes(NO_SPACE));
});
+
+ QUnit.test('takes in... | [Bug]: RegEx for breakText and textWrap opt.hyphen does not include international characters
### What happened?
By default breakText and textWrap do not include chraracters from international alphabets leading to strange behaviour when wrapping words containing them. In my opinion the default should include those.
... | This might work better `/[^\w\d\u00C0-\u1FFF\u2800-\uFFFD]/` (from [StackOverflow answer](https://stackoverflow.com/a/59828814/2921495)).
The one you provided doesn't work for Czech `ř`, for example.
Note, this should not be a blocker as you can provide a custom `hyphen` to the `textWrap` attribute.
| This might work better `/[^\w\d\u00C0-\u1FFF\u2800-\uFFFD]/` (from [StackOverflow answer](https://stackoverflow.com/a/59828814/2921495)).
The one you provided doesn't work for Czech `ř`, for example.
Note, this should not be a blocker as you can provide a custom `hyphen` to the `textWrap` attribute.
| [
"https://github.com/clientIO/joint/commit/9a0c05a7b1eabe05109c83151e477cd94f8e4ec7",
"https://github.com/clientIO/joint/commit/7ab052b378e5116d75fc81987934073550540e71"
] | 2023-11-06T17:22:56 | 3.7 | JavaScript |
clientIO/joint | 3,014 | clientIO__joint-3014 | [
2967
] | 5bebaa05bf21cc68e85f42a66fc1ad6342016524 | diff --git a/packages/joint-core/src/V/index.mjs b/packages/joint-core/src/V/index.mjs
index 15814d233..12fb117ea 100644
--- a/packages/joint-core/src/V/index.mjs
+++ b/packages/joint-core/src/V/index.mjs
@@ -485,10 +485,19 @@ const V = (function() {
if (content && typeof content !== 'string') throw new Erro... | diff --git a/packages/joint-core/test/jointjs/basic.js b/packages/joint-core/test/jointjs/basic.js
index b0078317e..ff793f382 100644
--- a/packages/joint-core/test/jointjs/basic.js
+++ b/packages/joint-core/test/jointjs/basic.js
@@ -1,3 +1,7 @@
+const USE_NO_BREAK_SPACE_LABEL_ATTRS = {
+ useNoBreakSpace: true
+}
+
... | Vectorizer: Input Space Character Becomes \u00A0 (Non-Breaking Space)
## Description
The conversion from `\u0020` to `\u00A0` was introduced for historical reasons but is no longer necessary and can be safely removed from the codebase.
See [`V.sanitizeText()`](https://github.com/clientIO/joint/blob/master/packages/jo... | [
"https://github.com/clientIO/joint/commit/a0b318cc9fa260648d429893b4bc208d18974c45",
"https://github.com/clientIO/joint/commit/55585eb824e0527aa88ce1481809c6fb7e76fced",
"https://github.com/clientIO/joint/commit/35f7e1c33ef5e5d99f8d6310574ced6d9b57395a",
"https://github.com/clientIO/joint/commit/88fc7f7e4c68e... | 2025-07-07T10:43:37 | 4.1 | JavaScript | ||
clientIO/joint | 2,542 | clientIO__joint-2542 | [
2295
] | e07dc52deb7f3a94714a2f9db891e240395026a5 | diff --git a/packages/joint-core/src/dia/attributes/text.mjs b/packages/joint-core/src/dia/attributes/text.mjs
index 79928344f..26d9bd867 100644
--- a/packages/joint-core/src/dia/attributes/text.mjs
+++ b/packages/joint-core/src/dia/attributes/text.mjs
@@ -123,12 +123,16 @@ const textAttributesNS = {
if (t... | diff --git a/packages/joint-core/test/jointjs/dia/attributes.js b/packages/joint-core/test/jointjs/dia/attributes.js
index bd7da35bf..fe8166db5 100644
--- a/packages/joint-core/test/jointjs/dia/attributes.js
+++ b/packages/joint-core/test/jointjs/dia/attributes.js
@@ -104,6 +104,38 @@ QUnit.module('Attributes', functio... | [Bug]: textWrap is not calculating properly text size when using custom fonts / size (Bootstrap repro)
### What happened?
It seems that textWrap isn't working as expected when using css styling. A simple repro: https://codesandbox.io/s/textwrap-bug-76f2md?file=/src/index.js
Note that commenting the bootstrap import... | Now you must explicitly set all font-related attributes in the `<text>` element for the `textWrap` function to work correctly. Back then, this decision was made consciously for performance reasons.
Now it is probably a good time to use the `getComputedStyle()` function to retrieve the actual font attributes needed t... | Now you must explicitly set all font-related attributes in the `<text>` element for the `textWrap` function to work correctly. Back then, this decision was made consciously for performance reasons.
Now it is probably a good time to use the `getComputedStyle()` function to retrieve the actual font attributes needed t... | [
"https://github.com/clientIO/joint/commit/3b51467791a1cec9173e3e3e3beb1e85ed4c2daf"
] | 2024-02-18T15:33:43 | 4.0 | JavaScript |
clientIO/joint | 2,139 | clientIO__joint-2139 | [
2137
] | 27472deef7adb11703254fa78bc6f4698cca2994 | diff --git a/docs/src/joint/api/dia/Paper/prototype/options/drawGridSize.html b/docs/src/joint/api/dia/Paper/prototype/options/drawGridSize.html
new file mode 100644
index 000000000..aa5e3ed79
--- /dev/null
+++ b/docs/src/joint/api/dia/Paper/prototype/options/drawGridSize.html
@@ -0,0 +1,4 @@
+<code>drawGridSize</code>... | diff --git a/test/jointjs/paper.js b/test/jointjs/paper.js
index 18551e446..29468e92c 100644
--- a/test/jointjs/paper.js
+++ b/test/jointjs/paper.js
@@ -1398,6 +1398,36 @@ QUnit.module('paper', function(hooks) {
return paper;
};
+ QUnit.module('drawGridSize option', function(hooks) {
+
+ ... | [Bug]: drawGrid() generates invalid images
### What happened?
I found out that the `drawBackgroundImage()` method will, sometimes, generate invalid images.
I prepared a simple demo: https://codesandbox.io/s/rappid-background-bug-kin1pg?file=/src/index.js
Steps to repro:
1. Wait for the demo to load and the pa... | Additional notes:
Note that I'm setting the grid size to `1.001` when on `cell:pointerdown`. This is as of your recommendation here: https://github.com/clientIO/joint/issues/1425
Note that I'm using `1.001` instead of `1` because while reading the Paper.mjs's code I found out that a grid size of `1` will cause `d... | Additional notes:
Note that I'm setting the grid size to `1.001` when on `cell:pointerdown`. This is as of your recommendation here: https://github.com/clientIO/joint/issues/1425
Note that I'm using `1.001` instead of `1` because while reading the Paper.mjs's code I found out that a grid size of `1` will cause `d... | [
"https://github.com/clientIO/joint/commit/9e31af7ad74eea6d3d72401dde542ee7feeabc34",
"https://github.com/clientIO/joint/commit/e96ba44e26769915e58c4386b1989b4daf810a7d"
] | 2023-04-18T10:18:46 | 3.7 | JavaScript |
clientIO/joint | 2,720 | clientIO__joint-2720 | [
2719
] | fa3d51e0d6b0e341200224a85ed24fe28f954fd5 | diff --git a/packages/joint-core/src/linkTools/Arrowhead.mjs b/packages/joint-core/src/linkTools/Arrowhead.mjs
index afcc1be39..e2d426137 100644
--- a/packages/joint-core/src/linkTools/Arrowhead.mjs
+++ b/packages/joint-core/src/linkTools/Arrowhead.mjs
@@ -51,7 +51,8 @@ const Arrowhead = ToolView.extend({
var ... | diff --git a/packages/joint-core/test/jointjs/dia/linkTools.js b/packages/joint-core/test/jointjs/dia/linkTools.js
index be5f2775e..e230e800f 100644
--- a/packages/joint-core/test/jointjs/dia/linkTools.js
+++ b/packages/joint-core/test/jointjs/dia/linkTools.js
@@ -341,6 +341,30 @@ QUnit.module('linkTools', function(hoo... | [Bug]: Changing link target or source breaks CommandManager in Angular
### Current versus expected behaviour
When running the kitchensink application in Angular 16, changing the target or source of a link breaks the CommandManager. The change itself and any changes made after that action are no longer put on the undo ... | We can reproduce the issue.
Here's a workaround for the time being:
```ts
this.paper.on('link:connect', () => {
this.commandManager.storeBatchCommand()
});
```
Here's a proper patch that you need to apply locally until we release a new version.
```ts
joint.dia.CellView.prototype.pointerup = function(e... | We can reproduce the issue.
Here's a workaround for the time being:
```ts
this.paper.on('link:connect', () => {
this.commandManager.storeBatchCommand()
});
```
Here's a proper patch that you need to apply locally until we release a new version.
```ts
joint.dia.CellView.prototype.pointerup = function(e... | [
"https://github.com/clientIO/joint/commit/bd2f631370731a0a2b7923eb38f10bb478a58a3c"
] | 2024-07-24T13:58:46 | 4.0 | JavaScript |
iTowns/itowns | 2,143 | iTowns__itowns-2143 | [
1859,
1888
] | 1d10290b5a7d36ff30cf28f69e9f4efbacd33df9 | diff --git a/src/Core/3DTiles/C3DTBatchTable.js b/src/Core/3DTiles/C3DTBatchTable.js
index 2157846670..7574e7e532 100644
--- a/src/Core/3DTiles/C3DTBatchTable.js
+++ b/src/Core/3DTiles/C3DTBatchTable.js
@@ -1,6 +1,6 @@
import utf8Decoder from 'Utils/Utf8Decoder';
import binaryPropertyAccessor from './utils/BinaryProp... | diff --git a/test/unit/3dtiles.js b/test/unit/3dtiles.js
index 61fb2f33c9..c5ac00d76a 100644
--- a/test/unit/3dtiles.js
+++ b/test/unit/3dtiles.js
@@ -1,6 +1,6 @@
import proj4 from 'proj4';
import assert from 'assert';
-import { Matrix4, Object3D } from 'three';
+import { Matrix4, Object3D, Sphere } from 'three';
im... | Unstable 3d tiles rendering in itowns
When I zoom or pan some tiles just not render or whole tileset destructs until the view angle or zoom will not be changed.
## Your Environment
- itowns version used: 2.38.1
- b3dm tiles
- link to json: hided
## Context
Here is videos to see the behavior:
1. https://youtu... | Thanks to report this issue!
I try with your data and there's issue with itowns
> Thanks to report this issue! I try with your data and there's issue with itowns
Thank you very much for your involvment. We really like your product and hope the issue can be solved.
@gchoqueux
is there any news about this issue?
Hi... | Thanks to report this issue!
I try with your data and there's issue with itowns
> Thanks to report this issue! I try with your data and there's issue with itowns
Thank you very much for your involvment. We really like your product and hope the issue can be solved.
@gchoqueux
is there any news about this issue?
Hi... | [
"https://github.com/iTowns/itowns/commit/f888d369e71818c28344201975732f6f063700ed"
] | 2023-07-17T16:08:30 | 2.5 | JavaScript |
iTowns/itowns | 2,128 | iTowns__itowns-2128 | [
1927
] | e6eb4cf1a1a76c91de584aed3875a2854dac612f | diff --git a/src/Parser/GeoJsonParser.js b/src/Parser/GeoJsonParser.js
index 41905f4dc2..3c31645c5b 100644
--- a/src/Parser/GeoJsonParser.js
+++ b/src/Parser/GeoJsonParser.js
@@ -217,7 +217,7 @@ export default {
if (out.filteringExtent) {
if (typeof out.filteringExtent == 'boolean') {
- ... | diff --git a/test/data/mapboxMulti.json b/test/data/mapboxMulti.json
new file mode 100644
index 0000000000..c51f51804d
--- /dev/null
+++ b/test/data/mapboxMulti.json
@@ -0,0 +1,438 @@
+{
+ "attribution": "<a href=\"https://www.mapbox.com/about/maps/\" target=\"_blank\" title=\"Mapbox\" aria-label=\"Mapbox\">© M... | Mapbox Style with multiple sources not being rendered correctly
Hi,
I'm trying to use a Mapbox vector style that is working fine for a 2D map using Openalyers + ol-maplibre-layer.
Using the same json file as style leads to only 1 layer being shown.
<!--- Provide a general summary of the issue in the Title ... | Hi, and thanks for this feedback !
Indeed, iTowns `VectorTileSource` only considers the first `source` specified in Mapbox vector style. This is partly due to [this piece of code](https://github.com/iTowns/itowns/blob/9ee991c3cd6595de6c058cd2cf81976a3daab7e0/src/Source/VectorTilesSource.js#L90).
The issue is tha... | Hi, and thanks for this feedback !
Indeed, iTowns `VectorTileSource` only considers the first `source` specified in Mapbox vector style. This is partly due to [this piece of code](https://github.com/iTowns/itowns/blob/9ee991c3cd6595de6c058cd2cf81976a3daab7e0/src/Source/VectorTilesSource.js#L90).
The issue is tha... | [
"https://github.com/iTowns/itowns/commit/2f90e3337d633e269a8e48547a9743a8c20451a2",
"https://github.com/iTowns/itowns/commit/521a85064fac7bd9754c013990ceb6463dc766c7",
"https://github.com/iTowns/itowns/commit/23e3c1d8189622c143a6a9c9dc8c503e7cea2532",
"https://github.com/iTowns/itowns/commit/5662290f53509f856... | 2023-07-03T13:16:27 | 2.5 | JavaScript |
iTowns/itowns | 2,586 | iTowns__itowns-2586 | [
2049
] | 872baed1f11300e60a19de000af4fe5658c10627 | diff --git a/.github/workflows/integration.yml b/.github/workflows/integration.yml
index 301924abf3..f1d9e5dcdb 100644
--- a/.github/workflows/integration.yml
+++ b/.github/workflows/integration.yml
@@ -19,7 +19,7 @@ jobs:
# Use specific Node.js version
- uses: actions/checkout@v4
- - name: Use Nod... | diff --git a/packages/Main/test/unit/entwine.js b/packages/Main/test/unit/entwine.js
index 54dd09e39e..edc4a3f27f 100644
--- a/packages/Main/test/unit/entwine.js
+++ b/packages/Main/test/unit/entwine.js
@@ -118,8 +118,7 @@ describe('Entwine Point Tile', function () {
it('tries to update on the root and succe... | Better handle near and far camera values depending on camera position
The near and far plane [are fixed](https://github.com/iTowns/itowns/blob/master/src/Core/Prefab/GlobeView.js#L102) in the `GlobeView` and the `PlanarView`.
1. Make them configurable
2. Update the far distance dynamically depending on the camera posi... | Yes, it's good idea, i started in this branch https://github.com/gchoqueux/itowns/tree/nearFar_2.0
You could use the global bounding box to compute the near and the far.
| Yes, it's good idea, i started in this branch https://github.com/gchoqueux/itowns/tree/nearFar_2.0
You could use the global bounding box to compute the near and the far.
| [
"https://github.com/iTowns/itowns/commit/3e5efe3cf9fc912bc5cea0bfe1cd37e6949b07a6",
"https://github.com/iTowns/itowns/commit/9144c4901f0433f34c220f7dab330f70386b4164"
] | 2025-07-22T12:35:01 | 2.5 | JavaScript |
iTowns/itowns | 2,296 | iTowns__itowns-2296 | [
2256
] | f55ee068e79a4e0a574d21b44eb8bd4f6cea1b02 | diff --git a/.babelrc b/.babelrc
index 728dc8aae5..ded830aa4d 100644
--- a/.babelrc
+++ b/.babelrc
@@ -4,7 +4,7 @@
"targets": {
"browsers": "defaults and supports webgl2"
},
- "modules": "auto"
+ "modules": false
}]
],
"plugins": [
@@ -... | diff --git a/test/.eslintrc.js b/test/.eslintrc.cjs
similarity index 100%
rename from test/.eslintrc.js
rename to test/.eslintrc.cjs
diff --git a/test/functional/.eslintrc.js b/test/functional/.eslintrc.cjs
similarity index 98%
rename from test/functional/.eslintrc.js
rename to test/functional/.eslintrc.cjs
index abb7f... | [Proposal - Requirements] Formalize web browsers requirements for iTowns
## Context
There is currently no documented web browsers requirements for iTowns in the whole repository.
The closest to a documentation is our configuration file of the `babel` compiler which states that we are *theoretically* targeting the... | Hi, thanks for the proposal.
The defaults target sounds good to me.
> A proposed solution is too only support the defaults target given by [browserlist](https://github.com/browserslist/browserslist), that is the last two versions of all mainstream browsers (> 0.5% usage) + Firefox ESR at the date of release.
... | Hi, thanks for the proposal.
The defaults target sounds good to me.
> A proposed solution is too only support the defaults target given by [browserlist](https://github.com/browserslist/browserslist), that is the last two versions of all mainstream browsers (> 0.5% usage) + Firefox ESR at the date of release.
... | [
"https://github.com/iTowns/itowns/commit/0578433b0bf08c8df91330fc471ca72fc20f9e54",
"https://github.com/iTowns/itowns/commit/faa42219faecb3d7ff162439131ea07039226aec"
] | 2024-03-15T12:16:46 | 2.5 | JavaScript |
iTowns/itowns | 2,584 | iTowns__itowns-2584 | [
2561
] | d343727da3146592a881a70c46554a9a6e78c4cc | diff --git a/packages/Main/src/Core/Prefab/Globe/Atmosphere.js b/packages/Main/src/Core/Prefab/Globe/Atmosphere.js
index 3ff24ae6bb..9716947ef4 100644
--- a/packages/Main/src/Core/Prefab/Globe/Atmosphere.js
+++ b/packages/Main/src/Core/Prefab/Globe/Atmosphere.js
@@ -71,7 +71,6 @@ class Atmosphere extends GeometryLayer ... | diff --git a/packages/Main/test/unit/ogc3dtileslayer.js b/packages/Main/test/unit/ogc3dtileslayer.js
index 5de9aa3454..b7b6185b73 100644
--- a/packages/Main/test/unit/ogc3dtileslayer.js
+++ b/packages/Main/test/unit/ogc3dtileslayer.js
@@ -6,7 +6,7 @@ import OGC3DTilesLayer, {
enableKtx2Loader,
enableMeshoptDe... | [REGRESSION] We can't change the opacity of the globe
Since https://github.com/iTowns/itowns/pull/2374/files#diff-2cbabdb42b34b51f54a3ad1eabf469e8990ea4073b43780ff5f2cc6709e08847
It seems that we can't edit the opactiy of the globe anymore
## Steps to Reproduce
<!--- Provide a link to a live example, or an unamb... | PR #2562
Should fix the problem
@ftoromanoff
After this https://github.com/iTowns/itowns/pull/2562
The render of point cloud looks a bit laggy:
Can be tried with the 3dtiles_loader example (Sete)
Maybe the collision with th... | PR #2562
Should fix the problem
@ftoromanoff
After this https://github.com/iTowns/itowns/pull/2562
The render of point cloud looks a bit laggy:
Can be tried with the 3dtiles_loader example (Sete)
Maybe the collision with th... | [
"https://github.com/iTowns/itowns/commit/053452acd104c979a3582760f72730d2d3e141a1",
"https://github.com/iTowns/itowns/commit/ac373b796ec9016621a66db45f285f36f1542b36",
"https://github.com/iTowns/itowns/commit/c353901414d84d93fdeebb52b66542767b8b0e5a",
"https://github.com/iTowns/itowns/commit/32ace44a81699a456... | 2025-07-17T14:21:52 | 2.5 | JavaScript |
zotero/zotero | 5,289 | zotero__zotero-5289 | [
5282
] | 086b0c3d84236a80142c5db5c8a292ad103d2df5 | diff --git a/chrome/content/zotero/elements/bubbleInput.js b/chrome/content/zotero/elements/bubbleInput.js
index 309562ab762..d6f21205f6b 100644
--- a/chrome/content/zotero/elements/bubbleInput.js
+++ b/chrome/content/zotero/elements/bubbleInput.js
@@ -50,21 +50,20 @@
* are not present, remove bubbles whose citatio... | diff --git a/test/tests/citationDialogTest.js b/test/tests/citationDialogTest.js
index 6c5a1961437..c39b4f6aa0e 100644
--- a/test/tests/citationDialogTest.js
+++ b/test/tests/citationDialogTest.js
@@ -5,6 +5,7 @@ describe("Citation Dialog", function () {
sort() {},
sortable: false,
citation: {
+ citationItem... | Citation dialog: prefix and suffix values persist on item in the citation
Prefix and suffix on a citation item will stick to it. So if the item is deleted but then re-added into the citation, suffix and prefix remain.
https://github.com/user-attachments/assets/3a4f6b1c-3425-4bdb-bd3b-0feed8a9e829
More curious, this b... | [
"https://github.com/zotero/zotero/commit/a8d21cd7d548fa800a2f88b2e35928576c27a98f"
] | 2025-05-12T23:20:28 | 0.0 | JavaScript | ||
zotero/zotero | 4,488 | zotero__zotero-4488 | [
4484
] | 144f2caed897d579c461b69eb34f263b46b38747 | diff --git a/chrome/content/zotero/xpcom/attachments.js b/chrome/content/zotero/xpcom/attachments.js
index 5e9d1c9f9dc..855f410ca0f 100644
--- a/chrome/content/zotero/xpcom/attachments.js
+++ b/chrome/content/zotero/xpcom/attachments.js
@@ -2503,6 +2503,12 @@ Zotero.Attachments = new function () {
};
+ this.sho... | diff --git a/test/tests/recognizeDocumentTest.js b/test/tests/recognizeDocumentTest.js
index d4c5bc1f94c..14525f3db5d 100644
--- a/test/tests/recognizeDocumentTest.js
+++ b/test/tests/recognizeDocumentTest.js
@@ -238,7 +238,7 @@ describe("Document Recognition", function() {
it("should rename a linked file attach... | Don't rename files during Retrieve Metadata/Create Parent Item if renaming not enabled for file type
Following up on https://github.com/zotero/zotero/pull/4474#issuecomment-2263338123:
> If the file is stored, or linked file renaming is enabled, regardless of the file's content type (I don't totally understand why R... | [
"https://github.com/zotero/zotero/commit/8da144f67665954635d09d2c910aea9d3358bc92",
"https://github.com/zotero/zotero/commit/1160e4df78ddc60cb99382cf87017ebcaadbeaff"
] | 2024-08-02T19:45:15 | 0.0 | JavaScript | ||
zotero/zotero | 5,010 | zotero__zotero-5010 | [
5007
] | 71d697801e9e785b02d7a20809c251b81dd356eb | diff --git a/chrome/content/zotero/xpcom/data/item.js b/chrome/content/zotero/xpcom/data/item.js
index 1aab0ff396d..0cbb4c27971 100644
--- a/chrome/content/zotero/xpcom/data/item.js
+++ b/chrome/content/zotero/xpcom/data/item.js
@@ -5652,12 +5652,13 @@ Zotero.Item.prototype.toResponseJSONAsync = async function (options... | diff --git a/test/tests/itemTest.js b/test/tests/itemTest.js
index 10737619732..5ee261f2d9b 100644
--- a/test/tests/itemTest.js
+++ b/test/tests/itemTest.js
@@ -3147,4 +3147,17 @@ describe("Zotero.Item", function () {
}
});
});
+
+ describe("#toResponseJSONAsync()", function () {
+ it("should not throw when a... | Local search fails when an attachment has an erroneous path
The local search API returns 500 Internal Server Error if an attachment has an erroneous path. Tested on `7.1-beta.6+9f83790ed` and `7.1-beta.7+296edc3fd`
I found out that an `NS_ERROR_FILE_UNRECOGNIZED_PATH` for one attachment causes an `OperationError` in t... | @dstillman: While we're at it, should we change [this](https://github.com/zotero/zotero/blob/7a467b8bfa24ebd78bedbce389aa9678a8150914/chrome/content/zotero/xpcom/data/item.js#L5663-L5677) to behave consistently? Right now, if the request was for an attachment item, it only adds the file size if it's an imported attachm... | @dstillman: While we're at it, should we change [this](https://github.com/zotero/zotero/blob/7a467b8bfa24ebd78bedbce389aa9678a8150914/chrome/content/zotero/xpcom/data/item.js#L5663-L5677) to behave consistently? Right now, if the request was for an attachment item, it only adds the file size if it's an imported attachm... | [
"https://github.com/zotero/zotero/commit/8f272089a5314e397b473efe4d78df98cbb9dc39"
] | 2025-01-27T18:26:08 | 0.0 | JavaScript |
zotero/zotero | 5,095 | zotero__zotero-5095 | [
5092,
5093
] | 6787dcd596f987fdae5ed08d09f85da4242e7806 | diff --git a/chrome/content/zotero/integration/citationDialog.js b/chrome/content/zotero/integration/citationDialog.js
index 349734332f8..3ec70d94354 100644
--- a/chrome/content/zotero/integration/citationDialog.js
+++ b/chrome/content/zotero/integration/citationDialog.js
@@ -30,6 +30,9 @@ const { COLUMNS } = require('... | diff --git a/test/tests/citationDialogTest.js b/test/tests/citationDialogTest.js
new file mode 100644
index 00000000000..6c5a1961437
--- /dev/null
+++ b/test/tests/citationDialogTest.js
@@ -0,0 +1,169 @@
+describe("Citation Dialog", function () {
+ let io = {
+ accept() {},
+ cancel() {},
+ sort() {},
+ sortable: f... | Citation dialog: Change `last-closed` pref value to `last-used`
I think I made a comment about this, but it looks like it didn't happen. The pref value should match what we're calling it in the UI.
Add a pref migration to set library mode as last-used for people using the classic dialog
In prefs.js, add a pref migratio... | Sorry about that - it must have gotten lost during rebasing and squashing
And `citationDialogLastClosedMode` too
| Sorry about that - it must have gotten lost during rebasing and squashing
And `citationDialogLastClosedMode` too
| [
"https://github.com/zotero/zotero/commit/7b4a9f2eeffcd57f6c9f8867225f624c10acab82"
] | 2025-03-11T20:58:16 | 0.0 | JavaScript |
zotero/zotero | 5,482 | zotero__zotero-5482 | [
1780
] | 71c2ffb3ee7fcee4688813714cc5f6738527b11f | diff --git a/chrome/content/zotero/elements/relatedBox.js b/chrome/content/zotero/elements/relatedBox.js
index 4ef7a4ff5dd..a7d54ff94a0 100644
--- a/chrome/content/zotero/elements/relatedBox.js
+++ b/chrome/content/zotero/elements/relatedBox.js
@@ -85,17 +85,7 @@ import { getCSSItemTypeIcon } from 'components/icons';
... | diff --git a/test/tests/relatedboxTest.js b/test/tests/relatedboxTest.js
index 846d2fd78fa..72f2bc12692 100644
--- a/test/tests/relatedboxTest.js
+++ b/test/tests/relatedboxTest.js
@@ -114,6 +114,32 @@ describe("Related Box", function () {
while (relatedbox.querySelector('.body').innerHTML.includes(title1));
});
... | Items in trash shouldn't show up in Related tab for items not in trash
But items not in the trash should appear for items in the trash. If both items are in the trash, the items should appear.
https://forums.zotero.org/discussion/81033/items-in-trash-appear-in-the-list-of-related-items
| [
"https://github.com/zotero/zotero/commit/e5ad5ea05ee6485e69928ec69f34291f7545cc96"
] | 2025-08-13T21:02:07 | 0.0 | JavaScript | ||
facebook/stylex | 782 | facebook__stylex-782 | [
771
] | 307a6d5fcae8abbd90da4d4ec4b76f529f03c92f | diff --git a/packages/shared/src/transform-value.js b/packages/shared/src/transform-value.js
index adc4d6166..c40b028aa 100644
--- a/packages/shared/src/transform-value.js
+++ b/packages/shared/src/transform-value.js
@@ -24,8 +24,6 @@ export default function transformValue(
? String(Math.round(rawValue * 10000) ... | diff --git a/packages/shared/__tests__/stylex-transform-value.js b/packages/shared/__tests__/stylex-transform-value.js
new file mode 100644
index 000000000..779301677
--- /dev/null
+++ b/packages/shared/__tests__/stylex-transform-value.js
@@ -0,0 +1,77 @@
+/**
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
... | Don't wrap `content: counters(...)` in quotes.
StyleX wraps values passed to `content` in quotes for you. However, this is sometimes problematic because it is also legal to use the `counters()` function instead of a string literal.
The compiler should be updated to detect this function, (and any other such valid valu... | Hey @nmn , I’d love to work on this issue as my second PR alongside my work on the playground. I have a few questions to help me get started:
**- Where to Start in the Codebase:** Could you point me to the files where content wrapping is handled? Knowing which files contain the core logic for handling values passed ... | Hey @nmn , I’d love to work on this issue as my second PR alongside my work on the playground. I have a few questions to help me get started:
**- Where to Start in the Codebase:** Could you point me to the files where content wrapping is handled? Knowing which files contain the core logic for handling values passed ... | [
"https://github.com/facebook/stylex/commit/e739e0911335e15090b34b981bd1f776e62ec4d0",
"https://github.com/facebook/stylex/commit/0566af326feb61ca70ccedcbd210169bffdd7175",
"https://github.com/facebook/stylex/commit/554931b35266ddb254abc0a69c5092055aedb4d7",
"https://github.com/facebook/stylex/commit/93b3500b9... | 2024-11-25T18:52:40 | 0.9 | JavaScript |
facebook/stylex | 835 | facebook__stylex-835 | [
821
] | 80992ce4a3b1a7f13ef7a0130efb61ad7ebc8b8a | diff --git a/apps/nextjs-example/app/CardTokens.stylex.ts b/apps/nextjs-example/app/CardTokens.stylex.ts
index ef9609290..70ca9268f 100644
--- a/apps/nextjs-example/app/CardTokens.stylex.ts
+++ b/apps/nextjs-example/app/CardTokens.stylex.ts
@@ -10,5 +10,5 @@
import * as stylex from '@stylexjs/stylex';
export const ... | diff --git a/packages/babel-plugin/__tests__/stylex-transform-create-test.js b/packages/babel-plugin/__tests__/stylex-transform-create-test.js
index a16c04397..1f8fbebac 100644
--- a/packages/babel-plugin/__tests__/stylex-transform-create-test.js
+++ b/packages/babel-plugin/__tests__/stylex-transform-create-test.js
@@ ... | CamelCased variable names are unexpected turned into kebab-case when setting them
Previously, all variable names are always hashes that only included small-case letters.
Now, with the `debug` option set to true, variables are prefixed with their in-source key name.
This behavior has exposed a bug in how StyleX se... | [
"https://github.com/facebook/stylex/commit/93133f23a925f80e42490744337e28aca40dee65"
] | 2025-01-04T13:18:04 | 0.10 | JavaScript | ||
facebook/stylex | 625 | facebook__stylex-625 | [
432
] | 194135167fc8040f696458e79779d80c7db3358b | diff --git a/packages/shared/src/stylex-first-that-works.js b/packages/shared/src/stylex-first-that-works.js
index 0aaf7108d..cba5ec866 100644
--- a/packages/shared/src/stylex-first-that-works.js
+++ b/packages/shared/src/stylex-first-that-works.js
@@ -7,8 +7,40 @@
* @flow strict
*/
-export default function style... | diff --git a/packages/shared/__tests__/stylex-first-that-works-test.js b/packages/shared/__tests__/stylex-first-that-works-test.js
index 1e89f84e2..3b9c6bc40 100644
--- a/packages/shared/__tests__/stylex-first-that-works-test.js
+++ b/packages/shared/__tests__/stylex-first-that-works-test.js
@@ -11,6 +11,49 @@ import f... | API for CSS variable fallback
## Feature request
I would like to be able to use fallback for css variables.
## Suggestion 1
I suggest an API like:
```tsx
const styles = stylex.create({
slot: {
color: stylex.fallback(vars.specificSlotColor, vars.textColor),
},
});
<div {...stylex.props(styles... | The existing `stylex.firstThatWorks` will soon be extended to support this use-case.
Shouldn't `undefined` be disallowed for values in `defineVars`, and then the type system can tell you if you're using a var that's actually `undefined`? The value in `defineVars` is the fallback as currently defined.
@necolas There are... | The existing `stylex.firstThatWorks` will soon be extended to support this use-case.
Shouldn't `undefined` be disallowed for values in `defineVars`, and then the type system can tell you if you're using a var that's actually `undefined`? The value in `defineVars` is the fallback as currently defined.
@necolas There are... | [
"https://github.com/facebook/stylex/commit/240fbe537f327cf1cceb67cf27213ad48a92bfad",
"https://github.com/facebook/stylex/commit/78103e5af8631e31f60d871b0b08844f36be832b"
] | 2024-06-30T14:19:49 | 0.7 | JavaScript |
facebook/stylex | 694 | facebook__stylex-694 | [
689
] | deaa7ce0694af2402fbab014a3ebb6f4bfbc6c03 | diff --git a/package-lock.json b/package-lock.json
index 8ea683a22..76f862dc2 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -31782,7 +31782,6 @@
"cpu": [
"arm64"
],
- "dev": true,
"optional": true,
"os": [
"darwin"
@@ -31798,7 +31797,6 @@
"cpu": [
... | diff --git a/packages/babel-plugin/__tests__/stylex-transform-create-test.js b/packages/babel-plugin/__tests__/stylex-transform-create-test.js
index ffb0a9876..4be1eea61 100644
--- a/packages/babel-plugin/__tests__/stylex-transform-create-test.js
+++ b/packages/babel-plugin/__tests__/stylex-transform-create-test.js
@@ ... | using data attributes token conversions break sometimes
### Describe the issue
in this code:
**text.stylex.ts**
```ts
export const text = stylex.defineVars({
fontWeight: stylex.types.integer(400),
});
```
**component.tsx**
```tsx
const styles = stylex.create({
div: {
[text.fontWeight]: {
":is(... | I could be wrong, but this could work:
```jsx
const styles = stylex.create({
div: {
[text.fontWeight]: {
":is([data-size='default'])": stylex.types.integer(500),
":is([data-size='large'])": stylex.types.integer(600),
},
},
});
```
@srikrsna that might fix a type error (not sure if the ... | I could be wrong, but this could work:
```jsx
const styles = stylex.create({
div: {
[text.fontWeight]: {
":is([data-size='default'])": stylex.types.integer(500),
":is([data-size='large'])": stylex.types.integer(600),
},
},
});
```
@srikrsna that might fix a type error (not sure if the ... | [
"https://github.com/facebook/stylex/commit/1c14c04762877f767dce23396f9f3235d2729779"
] | 2024-09-24T00:46:52 | 0.8 | JavaScript |
facebook/stylex | 392 | facebook__stylex-392 | [
391
] | 8a1892b4cd6c3ad664d4520295420932fce728b1 | diff --git a/packages/eslint-plugin/src/stylex-sort-keys.js b/packages/eslint-plugin/src/stylex-sort-keys.js
index ff3da7f43..fe51dc5c6 100644
--- a/packages/eslint-plugin/src/stylex-sort-keys.js
+++ b/packages/eslint-plugin/src/stylex-sort-keys.js
@@ -169,7 +169,7 @@ const stylexSortKeys = {
objectExpressio... | diff --git a/packages/eslint-plugin/__tests__/stylex-sort-keys-test.js b/packages/eslint-plugin/__tests__/stylex-sort-keys-test.js
index d0b9ab031..62bb05d66 100644
--- a/packages/eslint-plugin/__tests__/stylex-sort-keys-test.js
+++ b/packages/eslint-plugin/__tests__/stylex-sort-keys-test.js
@@ -147,6 +147,19 @@ eslint... | `sort-keys` comparing `default` with parent property
### Describe the issue
The new `sort-keys` eslint rule seems to give some unexpected errors, suggesting it's comparing the inner keys with parent keys.
### Expec... | [
"https://github.com/facebook/stylex/commit/670a5a08ff4ab1484314c5a85b8f406ebadf16f1"
] | 2024-01-27T20:20:25 | 0.3 | JavaScript | ||
nodejs/node | 57,498 | nodejs__node-57498 | [
46808
] | 2cb1d07e0f6d9456438016bab7db4688ab354fd2 | diff --git a/lib/internal/debugger/inspect_repl.js b/lib/internal/debugger/inspect_repl.js
index 8dc5e9823cae6e..2a0bd4e5149fd7 100644
--- a/lib/internal/debugger/inspect_repl.js
+++ b/lib/internal/debugger/inspect_repl.js
@@ -56,6 +56,7 @@ const { fileURLToPath } = require('internal/url');
const { customInspectSymb... | diff --git a/test/parallel/test-debugger-exec.js b/test/parallel/test-debugger-exec.js
index 51bc7497345ba2..536e0128ea2a84 100644
--- a/test/parallel/test-debugger-exec.js
+++ b/test/parallel/test-debugger-exec.js
@@ -60,6 +60,11 @@ async function waitInitialBreak() {
/\[ 'undefined', 'function' \]/,
'no... | Different behavior of { a: 1 } in the REPL and the debugger
### Version
v19.7.0
### Platform
_No response_
### Subsystem
_No response_
### What steps will reproduce the bug?
Evaluating `{ a: 1 }` in the REPL and the debugger have different result
```
% node
> { a: 1 }
{ a: 1 }
```
```
% node inspect a... | > We have a similar bug (#45964) but we have not fixed yet and it was closed
That's because it's not considered a bug but working as expected, it's a deliberate choice. Thanks for the report but I'm going to go ahead and close it.
@bnoordhuis We reached the consensus that it's not a bug, so the `node inspect` REPL s... | > We have a similar bug (#45964) but we have not fixed yet and it was closed
That's because it's not considered a bug but working as expected, it's a deliberate choice. Thanks for the report but I'm going to go ahead and close it.
@bnoordhuis We reached the consensus that it's not a bug, so the `node inspect` REPL s... | [
"https://github.com/nodejs/node/commit/7377a78f351114d3f54c36bc4b024cdc6014c6f0",
"https://github.com/nodejs/node/commit/146f2682dabd382d9d3663786789f472151d639c",
"https://github.com/nodejs/node/commit/0804e770a361b8be235c6b407a2a6d7ba2b5566f"
] | 2025-03-16T12:17:58 | 0.5 | JavaScript |
nodejs/node | 49,713 | nodejs__node-49713 | [
47993
] | 2ccfb23b7fc8e938a87d52949bf24e9720f846b1 | diff --git a/lib/internal/blob.js b/lib/internal/blob.js
index c5b417ddc291b6..a54adb615fbc17 100644
--- a/lib/internal/blob.js
+++ b/lib/internal/blob.js
@@ -320,6 +320,7 @@ class Blob {
const reader = this[kHandle].getReader();
return new lazyReadableStream({
+ type: 'bytes',
start(c) {
... | diff --git a/test/parallel/test-blob.js b/test/parallel/test-blob.js
index a517bad1ccb42d..e17824d2833682 100644
--- a/test/parallel/test-blob.js
+++ b/test/parallel/test-blob.js
@@ -331,12 +331,54 @@ assert.throws(() => new Blob({}), {
const b = new Blob(Array(10).fill('hello'));
const stream = b.stream();
co... | byob reader support for Blob.stream()
### Version
all
### Platform
_No response_
### Subsystem
_No response_
### What steps will reproduce the bug?
```js
new Blob([1,2]).stream().getReader({mode: 'byob'})
```
### How often does it reproduce? Is there a required condition?
every time
### What is the expected... | Hey! so I was trying to look around to solve this issue and while writing tests for it I noticed a weird behavior of node in comparison to browsers:
take the following script:
```mjs
async function fn() {
const b = new Blob([1, 2, 3, 4, 5, 5, 6, 6]).stream().getReader();
const chunks = [];
while (true... | Hey! so I was trying to look around to solve this issue and while writing tests for it I noticed a weird behavior of node in comparison to browsers:
take the following script:
```mjs
async function fn() {
const b = new Blob([1, 2, 3, 4, 5, 5, 6, 6]).stream().getReader();
const chunks = [];
while (true... | [
"https://github.com/nodejs/node/commit/50ab5572f3512e35c6568087bd51be16fa388efa",
"https://github.com/nodejs/node/commit/23cf23ff6f010af64edbeb6bb5aa7949fa256b48",
"https://github.com/nodejs/node/commit/7e446f1ffffc19aed08ae0cc126691ac698bbf71"
] | 2023-09-19T08:24:48 | 0.5 | JavaScript |
nodejs/node | 46,818 | nodejs__node-46818 | [
46765
] | b6c56cb63c85eac19ee3642e56113179a17b2a64 | diff --git a/lib/internal/streams/destroy.js b/lib/internal/streams/destroy.js
index 76433594662d91..358422e12a33e0 100644
--- a/lib/internal/streams/destroy.js
+++ b/lib/internal/streams/destroy.js
@@ -272,9 +272,11 @@ function constructNT(stream) {
}
try {
- stream._construct(onConstruct);
+ stream._con... | diff --git a/test/parallel/test-stream2-transform.js b/test/parallel/test-stream2-transform.js
index 849cfb3538b306..6f57384eb02443 100644
--- a/test/parallel/test-stream2-transform.js
+++ b/test/parallel/test-stream2-transform.js
@@ -468,3 +468,27 @@ const { PassThrough, Transform } = require('stream');
assert.st... | stream.Transform changing order of items
### Version
v18.14.1
### Platform
Linux 703748a51615 5.18.8-051808-generic #202206290850 SMP PREEMPT_DYNAMIC Wed Jun 29 08:59:08 UTC 2022 x86_64 Linux
### Subsystem
stream
### What steps will reproduce the bug?
```js
const stream = require("node:stream");
... | You accidentally wrote the expected in the current behavior
> You accidentally wrote the expected in the current behavior
I corrected it, thank you
Do you think you can make an even simpler example?
What I saw is when you remove the `construct` it works well
That's a good hint.
sometimes it starts/stops occuring w... | You accidentally wrote the expected in the current behavior
> You accidentally wrote the expected in the current behavior
I corrected it, thank you
Do you think you can make an even simpler example?
What I saw is when you remove the `construct` it works well
That's a good hint.
sometimes it starts/stops occuring w... | [
"https://github.com/nodejs/node/commit/e2fc14d3c72f68eb50260af4bee3b18fce8f294b",
"https://github.com/nodejs/node/commit/e65f74351cb638c950bd7ee5c2f26516167d997d",
"https://github.com/nodejs/node/commit/fb1fba4ec19620f5741479241025b02d5709a20d"
] | 2023-02-24T15:48:44 | 0.5 | JavaScript |
nodejs/node | 50,126 | nodejs__node-50126 | [
49971
] | f8c27e61761deffe1a20425c88d74afb830c33e4 | diff --git a/lib/internal/webstreams/readablestream.js b/lib/internal/webstreams/readablestream.js
index a5f95596e3082a..a3b22afd2f2ea0 100644
--- a/lib/internal/webstreams/readablestream.js
+++ b/lib/internal/webstreams/readablestream.js
@@ -14,6 +14,7 @@ const {
ObjectCreate,
ObjectDefineProperties,
ObjectSe... | diff --git a/test/fixtures/wpt/README.md b/test/fixtures/wpt/README.md
index 26dd520f8f3eed..6d635668f81a1c 100644
--- a/test/fixtures/wpt/README.md
+++ b/test/fixtures/wpt/README.md
@@ -27,7 +27,7 @@ Last update:
- performance-timeline: https://github.com/web-platform-tests/wpt/tree/17ebc3aea0/performance-timeline
-... | Implement TransformStream cleanup using "transformer.cancel"
The Streams specification has been updated with support for a hook to cleanup a TransformStream on error / abort. See https://github.com/whatwg/streams/pull/1283. WPTs are available: https://github.com/web-platform-tests/wpt/pull/40453
| I am trying to implement this, i am coming across some weird behaviour for the test https://github.com/web-platform-tests/wpt/blob/1267d50de7f8adf06dbddaba00b4d9651ae146a4/streams/transform-streams/errors.any.js#L266 it seems after calling controller.error the writable stream should also error? if so cancelPromise shou... | I am trying to implement this, i am coming across some weird behaviour for the test https://github.com/web-platform-tests/wpt/blob/1267d50de7f8adf06dbddaba00b4d9651ae146a4/streams/transform-streams/errors.any.js#L266 it seems after calling controller.error the writable stream should also error? if so cancelPromise shou... | [
"https://github.com/nodejs/node/commit/ee89ba1919431a91389a5c0e64f1382688890afc",
"https://github.com/nodejs/node/commit/867f64e663498a3d448d4d54f7b3e985d0b9dd69",
"https://github.com/nodejs/node/commit/02205e782ce904068af96cdcc972de5599ff41e2",
"https://github.com/nodejs/node/commit/67b094424b762bdd1a617192b... | 2023-10-10T18:02:35 | 0.5 | JavaScript |
nodejs/node | 46,742 | nodejs__node-46742 | [
46731
] | fadcee71e0c684d28b6c5e0c09723c4b39be183c | diff --git a/lib/internal/readline/interface.js b/lib/internal/readline/interface.js
index 45524612aea37b..4a5ec4973695fa 100644
--- a/lib/internal/readline/interface.js
+++ b/lib/internal/readline/interface.js
@@ -1322,18 +1322,22 @@ class Interface extends InterfaceConstructor {
// falls through
def... | diff --git a/test/parallel/test-readline-interface-recursive-writes.js b/test/parallel/test-readline-interface-recursive-writes.js
new file mode 100644
index 00000000000000..3a0aee5be9d619
--- /dev/null
+++ b/test/parallel/test-readline-interface-recursive-writes.js
@@ -0,0 +1,33 @@
+'use strict';
+const common = requi... | `.load` infinite loop in REPL
### Version
v19.6.0
### Platform
Darwin <hostname> 22.3.0 Darwin Kernel Version 22.3.0: Mon Jan 30 20:38:43 PST 2023; root:xnu-8792.81.3~2/RELEASE_ARM64_T8112 arm64
### Subsystem
repl
### What steps will reproduce the bug?
```
$ cat foo.js
function a(b) {
return b... | The behavior is the same with v18.14.1 and v18.13.0, but works fine with v18.12.1. The only relevant change I can see between the two is from #45539, but I'm not sure why that would be causing this issue. It's also a little too in the weeds for me to spend much more time on it right now, unfortunately. Hopefully this i... | The behavior is the same with v18.14.1 and v18.13.0, but works fine with v18.12.1. The only relevant change I can see between the two is from #45539, but I'm not sure why that would be causing this issue. It's also a little too in the weeds for me to spend much more time on it right now, unfortunately. Hopefully this i... | [
"https://github.com/nodejs/node/commit/2b0871d009a869110a41f8b663bc38209d649600",
"https://github.com/nodejs/node/commit/f5c31901d7510ba02966a6dd8c4cbfb5944a5c26",
"https://github.com/nodejs/node/commit/a9010dcc9bd359f4e176fbf52a1eedfd3f61703c",
"https://github.com/nodejs/node/commit/6797e756ad06b5ee5a49e0469... | 2023-02-20T11:54:47 | 0.5 | JavaScript |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.