code
stringlengths
41
34.3k
lang
stringclasses
8 values
review
stringlengths
1
4.74k
@@ -2,33 +2,43 @@ import jakarta.servlet.FilterChain; import jakarta.servlet.ServletException; +import jakarta.servlet.ServletRequest; +import jakarta.servlet.ServletResponse; import jakarta.servlet.http.HttpServletRequest; import jakarta.servlet.http.HttpServletResponse; import nextstep.security.authentication....
Java
๋งŒ์•ฝ ์ธ์ฆ์ด ๋˜์ง€์•Š์€ ๊ฒฝ์šฐ 401์‘๋‹ต์ด ํ•„์š”ํ•  ์ˆ˜ ์žˆ๋Š”๋ฐ ํ˜„์žฌ๋Š” ๋ชจ๋“  ์—๋กœ ์ƒํ™ฉ์—์„œ 403์ด ์‘๋‹ต์ด ๋˜๋Š” ๊ฒƒ ๊ฐ™๋„ค์š”!
@@ -0,0 +1,11 @@ +package nextstep.security.authorization; + +import java.util.Collection; + +public class NullRoleHierarchy implements RoleHierarchy { + + @Override + public Collection<String> getReachableGrantedAuthorities(Collection<String> authorities) { + return authorities; + } +}
Java
๋„ ๊ฐ์ฒด ํŒจํ„ด ๐Ÿ‘
@@ -0,0 +1,57 @@ +package nextstep.security.authorization; + +import java.util.*; + +public class RoleHierarchyImpl implements RoleHierarchy { + private final Map<String, Set<String>> hierarchyPath; + + private RoleHierarchyImpl(Map<String, Set<String>> hierarchyPath) { + this.hierarchyPath = hierarchyPath...
Java
RoleHierarchy ๊ตฌํ˜„ ์ž˜ ํ•ด์ฃผ์…จ์Šต๋‹ˆ๋‹ค ๐Ÿ‘
@@ -1,24 +0,0 @@ -package nextstep.security.authorization; - -import nextstep.security.authentication.Authentication; - -public class HasAuthorityAuthorizationManager implements AuthorizationManager { - private final String allowRole; - - public HasAuthorityAuthorizationManager(String allowRole) { - this.a...
Java
์‹œํ๋ฆฌํ‹ฐ ์ฝ”๋“œ๋ฅผ ๋ณด๋ฉด AuthorityAuthorizationManager ์™€ AuthoritiesAuthorizationManager๊ฐ€ ์žˆ๋Š”๋ฐ์š” ์ด ๊ตฌ์กฐ๋ฅผ ๋ถ„์„ํ•ด๋ณด์‹œ๊ณ  HasAuthorityAuthorizationManager ์— ๋Œ€์ž…ํ•ด๋ณด์…”๋„ ์ข‹์„ ๊ฒƒ ๊ฐ™์•„์š”.
@@ -0,0 +1,38 @@ +package nextstep.security.authorization; + +import org.junit.jupiter.api.DisplayName; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.Arguments; +import org.junit.jupiter.params.provider.MethodSource; + +import java.util.Collection; +import java.util.List;...
Java
Role Hierarchy ํ…Œ์ŠคํŠธ ๐Ÿ‘
@@ -13,15 +13,13 @@ import nextstep.security.context.SecurityContextHolderFilter; import nextstep.security.matcher.AnyRequestMatcher; import nextstep.security.matcher.MvcRequestMatcher; -import nextstep.security.matcher.RequestMatcherEntry; import nextstep.security.userdetails.UserDetails; import nextstep.security...
Java
๊ณ ๋ฏผ ๋์— ๋นŒ๋” ํด๋ž˜์Šค๋ฅผ ์ถ”์ถœํ•˜์—ฌ ๊ฐœ์„ ํ•ด๋ณด์•˜์Šต๋‹ˆ๋‹ค! [72fe548](https://github.com/next-step/spring-security-authorization/pull/23/commits/72fe5487d07f732b75950f6ce55af19c9dabd72b) ํ•ด๋‹น ์ปค๋ฐ‹์— ๋ฐ˜์˜ํ•˜์˜€์Šต๋‹ˆ๋‹ค.
@@ -2,33 +2,43 @@ import jakarta.servlet.FilterChain; import jakarta.servlet.ServletException; +import jakarta.servlet.ServletRequest; +import jakarta.servlet.ServletResponse; import jakarta.servlet.http.HttpServletRequest; import jakarta.servlet.http.HttpServletResponse; import nextstep.security.authentication....
Java
์•—.. ๊ทธ๋Ÿด์ˆ˜๋„ ์žˆ๊ฒ ๋„ค์š”! ์ธ๊ฐ€์‹คํŒจ์ธ ๊ฒฝ์šฐ ์œ ๋™์ ์œผ๋กœ ์ฒ˜๋ฆฌํ•  ์ˆ˜ ์žˆ๋„๋ก ์ธ๊ฐ€ ์‹คํŒจ ํ•ธ๋“ค๋Ÿฌ ์ธํ„ฐํŽ˜์ด์Šค๋ฅผ ์ •์˜ํ•˜์—ฌ ์ฒ˜๋ฆฌํ•ด๋ณด์•˜์Šต๋‹ˆ๋‹ค! [fc99a7a](https://github.com/next-step/spring-security-authorization/pull/23/commits/fc99a7a726f73bf39d3a30e7f02f4d2ecab0ec4e) ํ•ด๋‹น ์ปค๋ฐ‹์— ๋ฐ˜์˜ํ•ด๋‘์—ˆ์Šต๋‹ˆ๋‹ค
@@ -1,24 +0,0 @@ -package nextstep.security.authorization; - -import nextstep.security.authentication.Authentication; - -public class HasAuthorityAuthorizationManager implements AuthorizationManager { - private final String allowRole; - - public HasAuthorityAuthorizationManager(String allowRole) { - this.a...
Java
์ฝ”๋“œ ๊ตฌ์กฐ๋ฅผ ๋ถ„์„ํ•ด๋ณด๋‹ˆ AuthoritiesAuthorizationManager๋Š” ์—ฌ๋Ÿฌ๊ฑด์˜ ์ธ๊ฐ€๋ฅผ ์ฒดํฌํ•  ์ˆ˜ ์žˆ๋Š” ์—ญํ• , AuthorityAuthorizationManager ๋Š” ์ธ๊ฐ€์ •๋ณด๋ฅผ ์„ค์ •ํ•˜๋Š” ์—ญํ• ๋กœ ๋ถ„๋ฆฌํ•œ๊ฒƒ ๊ฐ™์•„์š”. ํ•ด๋‹น ๋ถ€๋ถ„์„ ๊ด€์ ์œผ๋กœ ๋ฆฌํŒฉํ† ๋ง ํ•ด๋ณด์•˜์Šต๋‹ˆ๋‹ค [8ab4798](https://github.com/next-step/spring-security-authorization/pull/23/commits/8ab47981b3de163a355d9c4c50ef54f1cacf497c)ํ•ด๋‹น ์ปค๋ฐ‹์— ๋ฐ˜์˜ํ•ด๋ณด์•˜์Šต๋‹ˆ๋‹ค
@@ -13,15 +13,13 @@ import nextstep.security.context.SecurityContextHolderFilter; import nextstep.security.matcher.AnyRequestMatcher; import nextstep.security.matcher.MvcRequestMatcher; -import nextstep.security.matcher.RequestMatcherEntry; import nextstep.security.userdetails.UserDetails; import nextstep.security...
Java
๋นŒ๋” ํŒจํ„ด์„ ์ ์šฉํ•˜์…จ๊ตฐ์š”! ์žฌ๋ฏธ์žˆ๋Š” ์‹œ๋„์ž…๋‹ˆ๋‹ค ๐Ÿ‘
@@ -0,0 +1,44 @@ +package nextstep.security.authorization; + +import nextstep.security.authentication.Authentication; +import org.springframework.util.CollectionUtils; + +import java.util.Collection; +import java.util.Set; + +public class AuthoritiesAuthorizationManager implements AuthorizationManager<Collection<String...
Java
AuthoritiesAuthorizationManager ๋ถ„๋ฆฌ๋ฅผ ํ†ตํ•œ ์ฑ…์ž„๊ณผ ์—ญํ•  ๋ถ„๋ฆฌ ๐Ÿ‘
@@ -2,33 +2,43 @@ import jakarta.servlet.FilterChain; import jakarta.servlet.ServletException; +import jakarta.servlet.ServletRequest; +import jakarta.servlet.ServletResponse; import jakarta.servlet.http.HttpServletRequest; import jakarta.servlet.http.HttpServletResponse; import nextstep.security.authentication....
Java
๊ตฌํ˜„ํ•ด์ฃผ์‹  ์ฝ”๋“œ๋ฅผ ๋ณด๋‹ˆ ExceptionTranslationFilter์—์„œ ์ฒ˜๋ฆฌํ•˜๋Š” ๊ฒƒ ์ฒ˜๋Ÿผ AuthorizationDeniedHandler๋ฅผ ํ†ตํ•ด ์—๋Ÿฌ๋ฅผ ์ฒ˜๋ฆฌํ•˜๋„๋ก ์ž‘์—…ํ•ด์ฃผ์…จ๊ตฐ์š” ๐Ÿ‘ ์‚ฌ์‹ค ์ฝ”๋ฉ˜ํŠธ ๋“œ๋ฆฌ๋ ค ํ–ˆ๋˜ ๋ถ€๋ถ„์€ 401์ด ๋ฐœ์ƒํ•  ์ˆ˜๋„ ์žˆ์–ด์„œ 403 ์™ธ ๋‹ค๋ฅธ ์‘๋‹ต ์ฝ”๋“œ๊ฐ€ ์‘๋‹ต๋  ์ˆ˜ ์žˆ๋„๋ก ์ฒ˜๋ฆฌํ•ด๋ณด๋Š” ๊ฒƒ์„ ์ƒ๊ฐํ•ด๋ณด์‹œ๊ธธ ์˜๋ฏธํ•˜๋Š” ์ฝ”๋ฉ˜ํŠธ์—ฟ์Šต๋‹ˆ๋‹ค :) ์ด๋ ‡๊ฒŒ ํ•  ๊ฒฝ์šฐ AuthorizationDeniedHandler ์™ธ ๋‹ค๋ฅธ handler๊ฐ€ ํ•„์š”ํ•  ์ˆ˜ ์žˆ๊ณ , ํŠนํžˆ Authentication ๊ด€๋ จ ์˜ˆ์™ธ๋ฅผ ์ฒ˜๋ฆฌํ•˜๋Š” handler๋Š” ๋‹ค๋ฅธ ์ธ์ฆ ํ•„ํ„ฐ์—์„œ๋„ ์‚ฌ์šฉ๋  ์ˆ˜ ์žˆ...
@@ -0,0 +1,104 @@ +import React from "react"; +import { useState } from "react"; + +const dummies = [ + { reviewId: 1, isAwarded: true, applicationYear: 2023, semester: "1ํ•™๊ธฐ", content: "์žฅํ•™๊ธˆ ์‹ ์ฒญ ๊ณผ์ •์ด ๊ฐ„๋‹จํ–ˆ์–ด์š”!" }, + { reviewId: 2, isAwarded: false, applicationYear: 2024, semester: "2ํ•™๊ธฐ", content: "์„ ๋ฐœ ๊ธฐ์ค€์ด ๋ช…ํ™•ํ•˜์ง€ ์•Š์•„์„œ ์•„์‰ฌ์› ์–ด์š”...
Unknown
์‚ฌ์šฉํ•˜์ง€ ์•Š๋Š” ๋ถˆํ•„์š”ํ•œ import React๋Š” ์ œ๊ฑฐํ•ด์ฃผ์„ธ์š”~
@@ -0,0 +1,104 @@ +import React from "react"; +import { useState } from "react"; + +const dummies = [ + { reviewId: 1, isAwarded: true, applicationYear: 2023, semester: "1ํ•™๊ธฐ", content: "์žฅํ•™๊ธˆ ์‹ ์ฒญ ๊ณผ์ •์ด ๊ฐ„๋‹จํ–ˆ์–ด์š”!" }, + { reviewId: 2, isAwarded: false, applicationYear: 2024, semester: "2ํ•™๊ธฐ", content: "์„ ๋ฐœ ๊ธฐ์ค€์ด ๋ช…ํ™•ํ•˜์ง€ ์•Š์•„์„œ ์•„์‰ฌ์› ์–ด์š”...
Unknown
์˜คํ˜ธ~ dummies๋กœ ๋งŒ๋“ค์–ด ์ž„์‹œ ๊ตฌํ˜„ ๊ตฟ๐Ÿ‘๐Ÿ‘๐Ÿ‘
@@ -0,0 +1,104 @@ +import React from "react"; +import { useState } from "react"; + +const dummies = [ + { reviewId: 1, isAwarded: true, applicationYear: 2023, semester: "1ํ•™๊ธฐ", content: "์žฅํ•™๊ธˆ ์‹ ์ฒญ ๊ณผ์ •์ด ๊ฐ„๋‹จํ–ˆ์–ด์š”!" }, + { reviewId: 2, isAwarded: false, applicationYear: 2024, semester: "2ํ•™๊ธฐ", content: "์„ ๋ฐœ ๊ธฐ์ค€์ด ๋ช…ํ™•ํ•˜์ง€ ์•Š์•„์„œ ์•„์‰ฌ์› ์–ด์š”...
Unknown
๋ณดํ†ต ๋ณ€ํ•˜์ง€ ์•Š๋Š” ์ƒ์ˆ˜๋Š” `REVIEWS_IN_ONE_PAGE`์™€ ๊ฐ™์ด ๋Œ€๋ฌธ์ž๋กœ ๋„ค์ด๋ฐํ•˜๋Š” ๊ฒƒ์ด ๋ณดํŽธ์ ์ž…๋‹ˆ๋‹ค~ ์ฐธ๊ณ ํ•ด์„œ ์ ์šฉํ•ด๋ณผ๊นŒ์š”~? - cf. https://ko.javascript.info/variables#ref-337 <img width="777" alt="image" src="https://github.com/user-attachments/assets/038d8339-e35a-4608-a4a3-5e847fe7ad1e" />
@@ -0,0 +1,104 @@ +import React from "react"; +import { useState } from "react"; + +const dummies = [ + { reviewId: 1, isAwarded: true, applicationYear: 2023, semester: "1ํ•™๊ธฐ", content: "์žฅํ•™๊ธˆ ์‹ ์ฒญ ๊ณผ์ •์ด ๊ฐ„๋‹จํ–ˆ์–ด์š”!" }, + { reviewId: 2, isAwarded: false, applicationYear: 2024, semester: "2ํ•™๊ธฐ", content: "์„ ๋ฐœ ๊ธฐ์ค€์ด ๋ช…ํ™•ํ•˜์ง€ ์•Š์•„์„œ ์•„์‰ฌ์› ์–ด์š”...
Unknown
๋ฐ˜๋ณต๋ฌธ์œผ๋กœ ์‚ฌ์šฉํ• ๋•Œ ๋””์ŠคํŠธ๋Ÿญ์ณ๋ง์„ ์‚ฌ์šฉํ•˜๋ฉด ๋” ๊น”๋”ํ•˜๊ฒŒ ํ‘œํ˜„์ด ๊ฐ€๋Šฅํ•ฉ๋‹ˆ๋‹ค~ ์ง€๊ธˆ๋„ map ๋‚ด๋ถ€์—์„œ `review.reviewId`, `reveiw.isAwarded` ์ฒ˜๋Ÿผ `review.`์ด ๊ณ„์† ์ค‘๋ณตํ•ด์„œ ์‚ฌ์šฉํ•˜๊ณ  ์žˆ์ฃ ~ ๋””์ŠคํŠธ๋Ÿญ์ณ๋ง์œผ๋กœ ์ข€ ๋” ๊น”๋”ํ•˜๊ฒŒ ํ‘œํ˜„ํ•ด ๋ณผ๊นŒ์š”~? - cf. https://developer.mozilla.org/ko/docs/Web/JavaScript/Reference/Operators/Destructuring_assignment
@@ -0,0 +1,104 @@ +import React from "react"; +import { useState } from "react"; + +const dummies = [ + { reviewId: 1, isAwarded: true, applicationYear: 2023, semester: "1ํ•™๊ธฐ", content: "์žฅํ•™๊ธˆ ์‹ ์ฒญ ๊ณผ์ •์ด ๊ฐ„๋‹จํ–ˆ์–ด์š”!" }, + { reviewId: 2, isAwarded: false, applicationYear: 2024, semester: "2ํ•™๊ธฐ", content: "์„ ๋ฐœ ๊ธฐ์ค€์ด ๋ช…ํ™•ํ•˜์ง€ ์•Š์•„์„œ ์•„์‰ฌ์› ์–ด์š”...
Unknown
์˜คํ˜ธ~ ์„ธ์‹ฌํ•˜๊ฒŒ disabled๊นŒ์ง€ ์ฑ™๊ธฐ๋‹ค๋‹ˆ~๐Ÿ‘
@@ -0,0 +1,65 @@ +import History from "@models/History"; +import { + getHistoryItemTemplate, + NO_HISTORY_TEMPLATE, +} from "@templates/history"; + +export default class HistoryController { + constructor(historyContainer) { + this.historyContainer = historyContainer; + this.numberOfHistory = 0; + this._init...
JavaScript
๐Ÿ‘ ๐Ÿ‘ ๋ฆฌ๋ทฐ๋“œ๋ฆฐ ๋ถ€๋ถ„ ๋ฐ˜์˜ํ•ด์ฃผ์…จ๋„ค์š”~! ํ™•์‹คํžˆ ํ…œํ”Œ๋ฆฟ์„ ์ƒ์ˆ˜๋กœ ๋ถ„๋ฆฌํ•˜๋‹ˆ๊นŒ ๊ฐ€๋…์„ฑ์ด ์ข‹์•„์กŒ๋„ค์š” :)
@@ -19,41 +19,56 @@ export default class Repo { }) { this.id = id; this.name = name; - this.full_name = full_name; + this.fullName = full_name; this.owner = owner; - this.html_url = html_url; + this.htmlUrl = html_url; this.description = description; - this.stargazers_count = starg...
JavaScript
`models/User.js` ์—์„œ ์‚ฌ์šฉ๋˜๋Š” ์ด๋ฏธ์ง€์—๋Š” alt๊ฐ€ ํ•œ๊ธ€๋กœ ๋˜์–ด์žˆ๋Š”๋ฐ ์ด๋ถ€๋ถ„์€ ์˜์–ด๋กœ ๋˜์–ด์žˆ๋„ค์š”! ํ†ต์ผ์‹œ์ผœ์ฃผ๋Š” ๊ฒƒ๋„ ์ข‹์„ ๊ฒƒ ๊ฐ™์•„์š”~
@@ -1,83 +1,112 @@ import GithubApiController from "@controllers/githubController"; import User from "@models/User"; +import { + NO_SEARCH_RESULT_TEMPLATE, + SEARCH_LOADING_TEMPLATE, + getReposTemplate, + NO_REPOS_TEMPLATE, +} from "@templates/search"; +import { SPINNER_TEMPLATE } from "@templates/spinner"; +impo...
JavaScript
๊ฐœ์ธ์ ์ธ ์ƒ๊ฐ์œผ๋ก  ํ•จ์ˆ˜๋ช…์ด `getXXXEl`๋กœ ๋˜์–ด์žˆ์–ด์„œ ๊ธฐ์กด์— ์กด์žฌํ•˜๋Š” ์—˜๋ ˆ๋จผํŠธ๋ฅผ ์ฟผ๋ฆฌ์…€๋ ‰ํŠธ๋กœ ๊ฐ€์ ธ์˜ค๋Š” ๊ฒƒ ๊ฐ™์€ ๋А๋‚Œ์ด ์žˆ๋Š”๋ฐ์š”, ์ƒˆ๋กœ์šด ์—˜๋ ˆ๋จผํŠธ๋ฅผ ๋งŒ๋“ค์–ด์„œ ๋ฐ˜ํ™˜ํ•˜๋Š” ์—ญํ• ์„ ํ•ด์ฃผ๊ณ  ์žˆ์œผ๋‹ˆ `get` ๋Œ€์‹  `create`๋ผ๋Š” ์ด๋ฆ„์œผ๋กœ ๋„ค์ด๋ฐํ•ด๋„ ์ข‹์„ ๊ฒƒ ๊ฐ™๋„ค์š” :)
@@ -1,83 +1,112 @@ import GithubApiController from "@controllers/githubController"; import User from "@models/User"; +import { + NO_SEARCH_RESULT_TEMPLATE, + SEARCH_LOADING_TEMPLATE, + getReposTemplate, + NO_REPOS_TEMPLATE, +} from "@templates/search"; +import { SPINNER_TEMPLATE } from "@templates/spinner"; +impo...
JavaScript
์ง€๋‚œ๋ฒˆ์— `keyCode`๋กœ ์ฒ˜๋ฆฌํ–ˆ์„ ๋•Œ ๋ณด๋‹ค ์–ด๋–ค ํ‚ค๋ฅผ ๋ˆŒ๋ €์„ ๋•Œ ๋™์ž‘ํ•˜๋Š” ๋กœ์ง์ธ์ง€ ํŒŒ์•…ํ•˜๊ธฐ๊ฐ€ ์‰ฌ์›Œ์กŒ๋„ค์š” ๐Ÿ‘
@@ -0,0 +1,65 @@ +import History from "@models/History"; +import { + getHistoryItemTemplate, + NO_HISTORY_TEMPLATE, +} from "@templates/history"; + +export default class HistoryController { + constructor(historyContainer) { + this.historyContainer = historyContainer; + this.numberOfHistory = 0; + this._init...
JavaScript
์ง€์–ด์ฃผ์‹  ๋ณ€์ˆ˜๋ช…๋„ ์ถฉ๋ถ„ํžˆ ์˜๋ฏธํŒŒ์•…์ด ์ž˜๋˜๋Š”๋ฐ์š”! ํ˜น์‹œ ์ข€๋” ๊ฐ„๊ฒฐํ•œ ๋ณ€์ˆ˜๋ช…์„ ์›ํ•˜์‹ ๋‹ค๋ฉด `historyCount` ๋กœ ๋„ค์ด๋ฐํ•˜๋Š” ๋ฐฉ๋ฒ•๋„ ์žˆ์„ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค ใ…Žใ…Ž
@@ -1,11 +1,13 @@ import Repo from "@models/Repo"; +import { getDateDiff } from "@utils/dateUtils"; export default class User { constructor({ id, avatar_url, created_at, email, + bio, followers, following, login, @@ -22,57 +24,114 @@ export default class User { this.id ...
JavaScript
`loginId` ๋งŒ ์นด๋ฉœ์ผ€์ด์Šค๋กœ ์ •์˜ ๋˜์–ด์žˆ๋„ค์š”! ๋ณ€์ˆ˜๋ช… ํ‘œ๊ธฐ๋ฒ•์„ ํ†ต์ผ์‹œํ‚ค๋ฉด ์ข‹์„ ๊ฒƒ ๊ฐ™์•„์š”
@@ -19,41 +19,56 @@ export default class Repo { }) { this.id = id; this.name = name; - this.full_name = full_name; + this.fullName = full_name; this.owner = owner; - this.html_url = html_url; + this.htmlUrl = html_url; this.description = description; - this.stargazers_count = starg...
JavaScript
๊ทธ ๋ถ€๋ถ„์€ ์‹ ๊ฒฝ์“ฐ์ง€ ๋ชปํ–ˆ๋„ค์š”! ํ•œ๊ตญ ์„œ๋น„์Šค์—์„œ๋Š” alt๋„ ํ•œ๊ธ€๋กœ ์ ์–ด์ฃผ๋Š”๊ฒŒ ๋” ๋‚˜์„๊นŒ์š”?
@@ -1,83 +1,112 @@ import GithubApiController from "@controllers/githubController"; import User from "@models/User"; +import { + NO_SEARCH_RESULT_TEMPLATE, + SEARCH_LOADING_TEMPLATE, + getReposTemplate, + NO_REPOS_TEMPLATE, +} from "@templates/search"; +import { SPINNER_TEMPLATE } from "@templates/spinner"; +impo...
JavaScript
๊ธฐ์กด vs ์ƒˆ๋กœ ์ƒ์„ฑ์€ ๋‹ค๋ฅธ ๊ฒฝ์šฐ๋‹ˆ๊นŒ create๊ฐ€ ๋” ๋ช…ํ™•ํ•˜๊ฒ ๋„ค์š” :)
@@ -0,0 +1,65 @@ +import History from "@models/History"; +import { + getHistoryItemTemplate, + NO_HISTORY_TEMPLATE, +} from "@templates/history"; + +export default class HistoryController { + constructor(historyContainer) { + this.historyContainer = historyContainer; + this.numberOfHistory = 0; + this._init...
JavaScript
๊ฐ„๊ฒฐํ•œ ๋ฒ„์ „๋„ ๊ดœ์ฐฎ๊ตฐ์š” ใ…Žใ…Ž
@@ -1,11 +1,13 @@ import Repo from "@models/Repo"; +import { getDateDiff } from "@utils/dateUtils"; export default class User { constructor({ id, avatar_url, created_at, email, + bio, followers, following, login, @@ -22,57 +24,114 @@ export default class User { this.id ...
JavaScript
๊ฐ์ฒด ํ”„๋กœํผํ‹ฐ๋ฅผ ๋ณต์‚ฌํ•ด์˜ค๋Š” ๊ณผ์ •์—์„œ ๋‹ค๋ฅธ ๋ถ€๋ถ„์€ ์‹ ๊ฒฝ์„ ์“ฐ์ง€ ๋ชปํ–ˆ๋„ค์š”...! ํ†ต์ผ ์‹œ์ผœ๋ณด๊ฒ ์Šต๋‹ˆ๋‹ค
@@ -19,41 +19,56 @@ export default class Repo { }) { this.id = id; this.name = name; - this.full_name = full_name; + this.fullName = full_name; this.owner = owner; - this.html_url = html_url; + this.htmlUrl = html_url; this.description = description; - this.stargazers_count = starg...
JavaScript
๋„ต~ ์ œ๊ฐ€ ์ง€๊ธˆ ์ง„ํ–‰ํ•˜๊ณ  ์žˆ๋Š” ํ”„๋กœ์ ํŠธ์˜ ๊ฒฝ์šฐ ๋‹ค ํ•œ๊ธ€๋กœ alt ์ ์–ด์ฃผ๊ณ  ์žˆ์Šต๋‹ˆ๋‹ค!
@@ -19,41 +19,56 @@ export default class Repo { }) { this.id = id; this.name = name; - this.full_name = full_name; + this.fullName = full_name; this.owner = owner; - this.html_url = html_url; + this.htmlUrl = html_url; this.description = description; - this.stargazers_count = starg...
JavaScript
์•„ํ•˜! ์ฐธ๊ณ ํ•ด์„œ ์ง„ํ–‰ํ•ด๋ณด๋„๋ก ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค~
@@ -0,0 +1,73 @@ +package com.eureka.spartaonetoone.review.application; + +import com.eureka.spartaonetoone.review.application.dtos.request.ReviewRequestDto; +import com.eureka.spartaonetoone.review.application.dtos.response.ReviewResponseDto; +import com.eureka.spartaonetoone.review.application.exception.ReviewExcepti...
Java
์•„๋ž˜ ์ฝ”๋“œ๋กœ ๋ณ€๊ฒฝ ๋ถ€ํƒ๋“œ๋ฆด๊ฒŒ์š” ~~ :) return ReviewResponseDto.from(review);
@@ -0,0 +1,73 @@ +package com.eureka.spartaonetoone.review.application; + +import com.eureka.spartaonetoone.review.application.dtos.request.ReviewRequestDto; +import com.eureka.spartaonetoone.review.application.dtos.response.ReviewResponseDto; +import com.eureka.spartaonetoone.review.application.exception.ReviewExcepti...
Java
์š” ๋ฉ”์„œ๋“œ๋Š” ์ œ๊ฑฐํ•ด์ฃผ์…”๋„ ๋  ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค ๋ฏผ์ˆ˜๋‹˜ ~~!
@@ -0,0 +1,152 @@ +package com.eureka.spartaonetoone.store.application; + +import com.eureka.spartaonetoone.common.client.OrderClient; +import com.eureka.spartaonetoone.common.client.ReviewClient; +import com.eureka.spartaonetoone.common.dtos.response.ReviewResponse; +import com.eureka.spartaonetoone.common.dtos.respon...
Java
๋ฏผ์ˆ˜๋‹˜ ์—ฌ๊ธฐ .from ์ด ๋˜์–ด์•ผ ํ•  ๊ฒƒ ๊ฐ™๋„ค์š” ~!! ์ฝ”๋“œ ๋ณต๋ถ™ํ•˜๋А๋ผ ์ œ๊ฐ€ of๋ฅผ ๋ณต๋ถ™ํ–ˆ๋„ค์š” ใ…Žใ…Ž :) from์œผ๋กœ ๋ถ€ํƒ๋“œ๋ฆด๊ฒŒ์š”
@@ -0,0 +1,152 @@ +package com.eureka.spartaonetoone.store.application; + +import com.eureka.spartaonetoone.common.client.OrderClient; +import com.eureka.spartaonetoone.common.client.ReviewClient; +import com.eureka.spartaonetoone.common.dtos.response.ReviewResponse; +import com.eureka.spartaonetoone.common.dtos.respon...
Java
from์œผ๋กœ ๋ถ€ํƒ๋“œ๋ฆด๊ฒŒ์š”
@@ -0,0 +1,152 @@ +package com.eureka.spartaonetoone.store.application; + +import com.eureka.spartaonetoone.common.client.OrderClient; +import com.eureka.spartaonetoone.common.client.ReviewClient; +import com.eureka.spartaonetoone.common.dtos.response.ReviewResponse; +import com.eureka.spartaonetoone.common.dtos.respon...
Java
๋ฏผ์ˆ˜๋‹˜ ์—ฌ๊ธฐ๋„ .from ์ด ๋˜์–ด์•ผ ํ•  ๊ฒƒ ๊ฐ™๋„ค์š” ~!!
@@ -0,0 +1,152 @@ +package com.eureka.spartaonetoone.store.application; + +import com.eureka.spartaonetoone.common.client.OrderClient; +import com.eureka.spartaonetoone.common.client.ReviewClient; +import com.eureka.spartaonetoone.common.dtos.response.ReviewResponse; +import com.eureka.spartaonetoone.common.dtos.respon...
Java
๋ฏผ์ˆ˜๋‹˜ ์—ฌ๊ธฐ๋„ .from ์ด ๋˜์–ด์•ผ ํ•  ๊ฒƒ ๊ฐ™๋„ค์š” ~!!
@@ -0,0 +1,152 @@ +package com.eureka.spartaonetoone.store.application; + +import com.eureka.spartaonetoone.common.client.OrderClient; +import com.eureka.spartaonetoone.common.client.ReviewClient; +import com.eureka.spartaonetoone.common.dtos.response.ReviewResponse; +import com.eureka.spartaonetoone.common.dtos.respon...
Java
๋ฏผ์ˆ˜๋‹˜ createStore ์•„๋ž˜ ์ฒ˜๋Ÿผ ๋ฐ”๊ฟ”๋ณด์‹œ์ฃ  ใ…Žใ…Ž ``` public StoreResponseDto createStore(StoreRequestDto dto) { StoreState stateEnum = parseStoreState(dto.getState()); Store store = Store.createStore( dto.getUserId(), dto.getName(), stateEnum, dto.getTellNumber(), dto.getDescription(), dto.getMinOrd...
@@ -1,70 +1,10 @@ -# Getting Started with Create React App +# React Westagram 3ํŒ€ -This project was bootstrapped with [Create React App](https://github.com/facebook/create-react-app). +instagram์„ ๋ชจํ‹ฐ๋ธŒ๋กœ ํ•œ ํด๋ก  ํŒ€ ํ”„๋กœ์ ํŠธ -## Available Scripts +# ํŒ€์› -In the project directory, you can run: - -### `npm start` - -Runs the app...
Unknown
๐Ÿ‘ README.md ํŒŒ์ผ ์ˆ˜์ •ํ•ด์ฃผ์…”์„œ ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค ^^
@@ -0,0 +1,61 @@ +import React, { useState, useEffect } from "react"; +import { useNavigate } from "react-router-dom"; +import "./Login.scss"; + +const Login = () => { + const navigate = useNavigate(); + const [showErrorMessage, setShowErrorMessage] = useState(false); + + const [userInfo, setUserInfo] = useState({ +...
Unknown
๋” ์ด์ƒ ์‚ฌ์šฉํ•˜์ง€ ์•Š๋Š” ๋ถˆํ•„์š”ํ•œ ์ฝ”๋“œ์— ๋Œ€ํ•œ ์ฃผ์„์€ ๊ผญ ์‚ญ์ œํ•ด์ฃผ์„ธ์š”
@@ -0,0 +1,61 @@ +import React, { useState, useEffect } from "react"; +import { useNavigate } from "react-router-dom"; +import "./Login.scss"; + +const Login = () => { + const navigate = useNavigate(); + const [showErrorMessage, setShowErrorMessage] = useState(false); + + const [userInfo, setUserInfo] = useState({ +...
Unknown
์ฝ˜์†”๋„ ๋งˆ์ฐฌ๊ฐ€์ง€์ž…๋‹ˆ๋‹ค ํ…Œ์ŠคํŠธ๊ฐ€ ๋๋‚œ ์ฝ”๋“œ๋Š” ํ•ญ์ƒ ์ง€์›Œ์ฃผ์„ธ์š”! ์•„๋ž˜์— ๋‚จ์•„์žˆ๋Š” ๋ชจ๋“  ์ฝ˜์†”์€ ์‚ญ์ œ ํ•ด์ฃผ์„ธ์š”
@@ -0,0 +1,61 @@ +import React, { useState, useEffect } from "react"; +import { useNavigate } from "react-router-dom"; +import "./Login.scss"; + +const Login = () => { + const navigate = useNavigate(); + const [showErrorMessage, setShowErrorMessage] = useState(false); + + const [userInfo, setUserInfo] = useState({ +...
Unknown
๐Ÿ‘ useEffect ๊นŒ์ง€ ํ™œ์šฉํ•ด๋ณด์…จ๊ตฐ์š”! condition ๋ณ€์ˆ˜๊ฐ€ userInfo๋ผ๋Š” state๋ฅผ ์ด๋ฏธ ์ฐธ์กฐํ•œ ๊ฐ’์ด๊ธฐ๋•Œ๋ฌธ์— isActive๋ผ๋Š” ๊ฐ’์„ ๋”ฐ๋กœ state๋กœ ๊ด€๋ฆฌํ•˜์ง€์•Š์•„๋„ condition ๋ณ€์ˆ˜๊ฐ€ ์ฐธ์กฐํ•˜๊ณ ์žˆ๋Š” ๊ฐ’์ด ์ด๋ฏธ state๋ผ์„œ state๋ณ€ํ™”์— ๋”ฐ๋ผ ์ฆ‰๊ฐ์ ์œผ๋กœ ๋‹ค๋ฅธ ๊ฐ’์„ ๊ฐ€์งˆ ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค. isActive๋ฅผ state๊ฐ€ ์•„๋‹Œ ์ผ๋ฐ˜๋ณ€์ˆ˜๋กœ ๊ด€๋ฆฌํ•ด๋ณด์‹œ๋Š”๊ฒŒ ์–ด๋–จ๊นŒ์š”?
@@ -0,0 +1,61 @@ +import React, { useState, useEffect } from "react"; +import { useNavigate } from "react-router-dom"; +import "./Login.scss"; + +const Login = () => { + const navigate = useNavigate(); + const [showErrorMessage, setShowErrorMessage] = useState(false); + + const [userInfo, setUserInfo] = useState({ +...
Unknown
๐Ÿ‘ ์กฐ๊ฑด๋ถ€๋žœ๋”๋ง ํ™œ์šฉํ•ด๋ณด์…จ๊ตฐ์š”!! ์˜คํžˆ๋ ค showErrorMessage๋ฅผ ๊ด€๋ฆฌํ•˜๋Š” ํ•จ์ˆ˜๋ฅผ useEffectํ•จ์ˆ˜ ๋‚ด์—์„œ ์„ ์–ธํ•œ condition๊ฐ’์— ๋”ฐ๋ผ ๋‹ค๋ฅด๊ฒŒ ๊ด€๋ฆฌํ•ด๋ณผ ์ˆ˜ ์žˆ๊ฒ ์Šต๋‹ˆ๋‹ค!
@@ -0,0 +1,144 @@ +.login { + width: 100%; + height: 100vh; + display: flex; + flex-direction: column; + justify-content: center; + align-items: center; + + .box { + padding: 25px 40px; + display: flex; + flex-direction: column; + align-items: center; + width: 100%; + max-width: 350px; + box...
Unknown
์›นํฐํŠธ ๊ฐ™์€๊ฒฝ์šฐ๋Š” index.htmlํŒŒ์ผ์—์„œ ์ถ”๊ฐ€ํ•  ์ˆ˜๋„ ์žˆ๊ณ  common.scss์—์„œ ๊ด€๋ฆฌํ•  ์ˆ˜๋„ ์žˆ์Šต๋‹ˆ๋‹ค
@@ -0,0 +1,160 @@ +import React from "react"; +import "./Main.scss"; +import { Link, useNavigate } from "react-router-dom"; + +const Main = () => { + const navigate = useNavigate(); + + const goToMain = () => { + navigate("/jisun-main"); + }; + + return ( + <div className="main"> + <nav> + <Link t...
Unknown
reset.scss ํŒŒ์ผ๋„ ๋งˆ์ฐฌ๊ฐ€์ง€๋กœ ์ „์—ญ์—์„œ ์ ์šฉ๋˜์–ด์•ผ ํ•˜๋Š” ํŒŒ์ผ์ž„์œผ๋กœ index.js์—์„œ importํ•ด ์˜ค๋Š”๊ฒƒ์ด ์ข‹์Šต๋‹ˆ๋‹ค.
@@ -0,0 +1,160 @@ +import React from "react"; +import "./Main.scss"; +import { Link, useNavigate } from "react-router-dom"; + +const Main = () => { + const navigate = useNavigate(); + + const goToMain = () => { + navigate("/jisun-main"); + }; + + return ( + <div className="main"> + <nav> + <Link t...
Unknown
์•„์ด์ฝ˜๋“ค์„ ๋ˆŒ๋ €์„๋•Œ ํŠน์ •ํŽ˜์ด์ง€๋กœ ์ด๋™ํ•ด์•ผํ•˜๋Š”๊ฒƒ์ด ์•„๋‹ˆ๋ผ๋ฉด a ํƒœ๊ทธ๋‚˜ Link ํƒœ๊ทธ๊ฐ€ ์•„๋‹Œ ์—ฌํƒ€ ๋‹ค๋ฅธํƒœ๊ทธ๋ฅผ ํ™œ์šฉํ•ด์„œ ๊ธฐ๋Šฅ์„ ๊ตฌํ˜„ํ•  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค!
@@ -0,0 +1,160 @@ +import React from "react"; +import "./Main.scss"; +import { Link, useNavigate } from "react-router-dom"; + +const Main = () => { + const navigate = useNavigate(); + + const goToMain = () => { + navigate("/jisun-main"); + }; + + return ( + <div className="main"> + <nav> + <Link t...
Unknown
ํ•ด๋‹น ์ƒ๋Œ€๊ฒฝ๋กœ๊ฐ€ publicํด๋”๋ฅผ ์ฐธ๊ณ ํ•˜๋Š”๊ฑฐ๋ผ๋ฉด ```suggestion <img alt="๊ณ„์ • ํ”„๋กœํ•„ ์‚ฌ์ง„" src="/images/jisun/img_profile.png" /> ``` ์ด๋ ‡๊ฒŒ ํ‘œํ˜„ํ•  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค
@@ -0,0 +1,160 @@ +import React from "react"; +import "./Main.scss"; +import { Link, useNavigate } from "react-router-dom"; + +const Main = () => { + const navigate = useNavigate(); + + const goToMain = () => { + navigate("/jisun-main"); + }; + + return ( + <div className="main"> + <nav> + <Link t...
Unknown
className์ด ๋„ˆ๋ฌด ๋ชจํ˜ธํ•ฉ๋‹ˆ๋‹ค!! ์–ด๋–ค ์•„์ด์ฝ˜์ธ์ง€ ์•Œ๋ ค์ฃผ์„ธ์š”
@@ -1 +1,23 @@ # spring-security +## ๐Ÿš€ 1-1๋‹จ๊ณ„ - OAuth 2.0 Login + +- [x] Github Application ๋“ฑ๋ก +- [x] ์ธ์ฆ URL ๋ฆฌ๋‹ค์ด๋ ‰ํŠธ ํ•„ํ„ฐ ๊ตฌํ˜„ +- [x] Github Access Token ํš๋“ +- [x] OAuth2 ์‚ฌ์šฉ์ž ์ •๋ณด ์กฐํšŒ +- [x] ํ›„์ฒ˜๋ฆฌ + - [x] ์ดํ›„ ํ”„๋กœํ•„ ์ •๋ณด๋ฅผ ๊ฐ€์ง€๊ณ  ํšŒ์› ๊ฐ€์ž… & ๋กœ๊ทธ์ธ์„ ๊ตฌํ˜„ํ•œ๋‹ค. + - [x] ๊ธฐ์กด ๋ฉค๋ฒ„ ์ •๋ณด๊ฐ€ ์žˆ๋Š” ๊ฒฝ์šฐ ์„ธ์…˜์— ๋กœ๊ทธ์ธ ์ •๋ณด๋ฅผ ์ €์žฅํ•œ ๋’ค "/"์œผ๋กœ ๋ฆฌ๋‹ค์ด๋ ‰ํŠธ + - [x] ์ƒˆ๋กœ์šด ๋ฉค๋ฒ„์ธ ๊ฒฝ์šฐ ํšŒ์› ๊ฐ€์ž… ํ›„ ์„ธ์…˜์— ๋กœ๊ทธ์ธ...
Unknown
์š”๊ตฌ์‚ฌํ•ญ ์ •๋ฆฌ ๐Ÿ‘
@@ -0,0 +1,50 @@ +package nextstep.security.oauth2.authentication; + +import jakarta.servlet.FilterChain; +import jakarta.servlet.ServletException; +import jakarta.servlet.http.HttpServletRequest; +import jakarta.servlet.http.HttpServletResponse; +import nextstep.security.authentication.AuthenticationException; +import...
Java
OAuth2AuthorizationRequestResolver์—์„œ OAuth2AuthorizationRequest๋ฅผ ์ƒ์„ฑํ•  ๋•Œ, authorizationRequestUri์— ํ•„์ˆ˜์ ์ธ ์ฟผ๋ฆฌ ํŒŒ๋ผ๋ฏธํ„ฐ(client_id, response_type, scope, redirect_uri ๋“ฑ)๋ฅผ ๋ฏธ๋ฆฌ ํฌํ•จํ•  ์ˆ˜๋„ ์žˆ์„ ๊ฒƒ ๊ฐ™์€๋ฐ, ์–ด๋–ป๊ฒŒ ์ƒ๊ฐํ•˜์‹œ๋‚˜์š”? ๐Ÿ˜„ ```suggestion response.sendRedirect(authorizationRequest.getAuthorizationRequestUri()); ```
@@ -0,0 +1,115 @@ +package nextstep.security.oauth2.authentication; + +import jakarta.servlet.FilterChain; +import jakarta.servlet.http.HttpServletRequest; +import jakarta.servlet.http.HttpServletResponse; +import nextstep.security.authentication.AbstractAuthenticationProcessingFilter; +import nextstep.security.authent...
Java
Spring Security์—์„œ๋Š” OAuth2AuthorizationResponseUtils.toMultiMap(request.getParameterMap())์„ ์‚ฌ์šฉํ•˜์—ฌ OAuth2 ์‘๋‹ต์„ MultiValueMap์œผ๋กœ ๋ณ€ํ™˜ํ•œ ํ›„, OAuth2AuthorizationResponseUtils.isAuthorizationResponse()๋ฅผ ํ†ตํ•ด ์œ ํšจ์„ฑ์„ ๊ฒ€์‚ฌํ•˜๋Š” ๋ฐฉ์‹์„ ์‚ฌ์šฉํ•ฉ๋‹ˆ๋‹ค. ํ•œ๋ฒˆ ํ™•์ธํ•ด ๋ณด์…”๋„ ์ข‹์„ ๊ฒƒ ๊ฐ™์•„์š” ๐Ÿ˜„
@@ -0,0 +1,115 @@ +package nextstep.security.oauth2.authentication; + +import jakarta.servlet.FilterChain; +import jakarta.servlet.http.HttpServletRequest; +import jakarta.servlet.http.HttpServletResponse; +import nextstep.security.authentication.AbstractAuthenticationProcessingFilter; +import nextstep.security.authent...
Java
๋ถˆํ•„์š”ํ•œ ์˜ค๋ฒ„๋ผ์ด๋”ฉ ์ด๋ผ๊ณ  ์ƒ๊ฐ๋˜๋„ค์š”. ์ œ๊ฑฐํ•ด๋„ ๋˜๊ฒ ์Šต๋‹ˆ๋‹ค ๐Ÿ˜„
@@ -0,0 +1,115 @@ +package nextstep.security.oauth2.authentication; + +import jakarta.servlet.FilterChain; +import jakarta.servlet.http.HttpServletRequest; +import jakarta.servlet.http.HttpServletResponse; +import nextstep.security.authentication.AbstractAuthenticationProcessingFilter; +import nextstep.security.authent...
Java
ํ•ด๋‹น ์ฃผ์„์€ ์ œ๊ฑฐํ•  ์˜ˆ์ •์ด์‹ค๊นŒ์š”? ๐Ÿค”
@@ -0,0 +1,115 @@ +package nextstep.security.oauth2.authentication; + +import jakarta.servlet.FilterChain; +import jakarta.servlet.http.HttpServletRequest; +import jakarta.servlet.http.HttpServletResponse; +import nextstep.security.authentication.AbstractAuthenticationProcessingFilter; +import nextstep.security.authent...
Java
๋„ต๋„ต ใ…Žใ…Žใ…Ž ์ œ๊ฑฐํ•˜๋„๋ก ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค. ๐Ÿ™
@@ -0,0 +1,115 @@ +package nextstep.security.oauth2.authentication; + +import jakarta.servlet.FilterChain; +import jakarta.servlet.http.HttpServletRequest; +import jakarta.servlet.http.HttpServletResponse; +import nextstep.security.authentication.AbstractAuthenticationProcessingFilter; +import nextstep.security.authent...
Java
์•„ํ•˜, OAuth2AuthorizationResponseUtils์—์„œ Request Paramater๋ฅผ Map์œผ๋กœ ๋ณ€ํ™˜ํ•˜์—ฌ ์‚ฌ์šฉํ•˜๋Š” ๋ถ€๋ถ„์„ ์ฐธ๊ณ ํ•˜์—ฌ ์ˆ˜์ •ํ•ด๋ณด์•˜์Šต๋‹ˆ๋‹ค ๐Ÿ‘
@@ -0,0 +1,50 @@ +package nextstep.security.oauth2.authentication; + +import jakarta.servlet.FilterChain; +import jakarta.servlet.ServletException; +import jakarta.servlet.http.HttpServletRequest; +import jakarta.servlet.http.HttpServletResponse; +import nextstep.security.authentication.AuthenticationException; +import...
Java
์ด๋ถ€๋ถ„์€ Redirect Filter๊ฐ€ ๋ชจ๋“  Redirect Url ์ŠคํŽ™์„ ์•Œ๊ฒŒ ๋˜๋Š” ๊ฒƒ ๊ฐ™์•„์„œ, ์ƒ์„ฑ ์ฑ…์ž„์„ Resolver์—๊ฒŒ ๋งก๊ธฐ๋Š” ๊ฒƒ์ด ์ข‹์•„๋ณด์ด๋„ค์š” !! ๐Ÿ‘
@@ -78,6 +78,7 @@ public List<ReviewPhoto> createReviewPhoto(Long reviewId, List<MultipartFile> re List<ReviewPhoto> reviewPhotoList = new ArrayList<>(); List<String> photoUrls = new ArrayList<>(); + if(reviewPhotos == null) return reviewPhotoList; reviewPhotos.forEach(multipartFile ...
Java
์ด ๋ถ€๋ถ„์€ ์–ด๋–ค ์˜๋ฏธ์ธ๊ฐ€์š”?
@@ -78,6 +78,7 @@ public List<ReviewPhoto> createReviewPhoto(Long reviewId, List<MultipartFile> re List<ReviewPhoto> reviewPhotoList = new ArrayList<>(); List<String> photoUrls = new ArrayList<>(); + if(reviewPhotos == null) return reviewPhotoList; reviewPhotos.forEach(multipartFile ...
Java
์ด ๋ถ€๋ถ„์€ ์–ด๋–ค ์˜๋ฏธ์ธ๊ฐ€์š”?
@@ -0,0 +1,34 @@ +package com.luckytree.shop.utils; + +import com.fasterxml.jackson.databind.ObjectMapper; +import org.springframework.http.MediaType; +import org.springframework.http.converter.json.AbstractJackson2HttpMessageConverter; +import org.springframework.stereotype.Component; + +import java.lang.reflect.Type;...
Java
์ด ํด๋ž˜์Šค๋ฅผ ์‚ฌ์šฉํ•˜๋Š” ๊ณณ์ด ์–ด๋”˜๊ฐ€์š”?
@@ -32,12 +32,11 @@ public class ReviewController { private final ReviewUseCase reviewUseCase; @Operation(summary = "๋ฆฌ๋ทฐ ๋“ฑ๋ก") - @PostMapping(consumes = MediaType.MULTIPART_FORM_DATA_VALUE) + @PostMapping(consumes = {MediaType.APPLICATION_JSON_VALUE, MediaType.MULTIPART_FORM_DATA_VALUE}) public Res...
Java
๋ฆฌํ€˜์ŠคํŠธ๋ฐ”๋””๊ฐ€ ์‚ฌ๋ผ์กŒ๋Š”๋ฐ, ์ด ๊ฒฝ์šฐ์—๋„ ํด๋ผ์ด์–ธํŠธ์—์„œ JSON ํ˜•์‹์˜ Body ํƒœ๊ทธ ๋ฐ์ดํ„ฐ๋ฅผ ๋ฐ›์•„์˜ค๋Š” ๋ฐ์— ๋ฌธ์ œ๊ฐ€ ์—†๋‚˜์š”?
@@ -78,6 +78,7 @@ public List<ReviewPhoto> createReviewPhoto(Long reviewId, List<MultipartFile> re List<ReviewPhoto> reviewPhotoList = new ArrayList<>(); List<String> photoUrls = new ArrayList<>(); + if(reviewPhotos == null) return reviewPhotoList; reviewPhotos.forEach(multipartFile ...
Java
๋ฆฌ๋ทฐ ์ƒ์„ฑ ์‹œ ํฌํ† ๋ฅผ ์„ ํƒํ•˜์ง€ ์•Š์•„๋„ ์ด ์„œ๋น„์Šค๊ฐ€ ์‹คํ–‰๋˜์–ด์„œ ์„ ํƒ๋˜์ง€ ์•Š์•˜์„ ๋•Œ ๋ฐ”๋กœ ๋น ์ ธ๋‚˜๊ฐ€๊ฒŒ ํ•œ๊ฒ๋‹ˆ๋‹ค
@@ -0,0 +1,34 @@ +package com.luckytree.shop.utils; + +import com.fasterxml.jackson.databind.ObjectMapper; +import org.springframework.http.MediaType; +import org.springframework.http.converter.json.AbstractJackson2HttpMessageConverter; +import org.springframework.stereotype.Component; + +import java.lang.reflect.Type;...
Java
swagger์—์„œ ๋ฆฌ๋ทฐ ์ƒ์„ฑ API์— multipartfile์„ ์‚ฌ์šฉํ•ด์„œ ๊ทธ๊ฑฐ ์‚ฌ์šฉํ•˜๊ฒŒ ๋งŒ๋“ค์–ด์ฃผ๋Š” ํด๋ž˜์Šค์ž…๋‹ˆ๋‹ค
@@ -32,12 +32,11 @@ public class ReviewController { private final ReviewUseCase reviewUseCase; @Operation(summary = "๋ฆฌ๋ทฐ ๋“ฑ๋ก") - @PostMapping(consumes = MediaType.MULTIPART_FORM_DATA_VALUE) + @PostMapping(consumes = {MediaType.APPLICATION_JSON_VALUE, MediaType.MULTIPART_FORM_DATA_VALUE}) public Res...
Java
swagger๋ž‘ postman์—์„œ ํ™•์ธํ–ˆ๊ณ  ์˜คํžˆ๋ ค ๋ฆฌํ€˜์ŠคํŠธ๋ฐ”๋””๋ฅผ ์ผ์„ ๋•Œ ์•ˆ๋ผ์„œ ๋ฐ”๊ฟจ์Šต๋‹ˆ๋‹ค. ์ด์œ ๋Š” ์ฐพ์•„๋ณด๊ฒ ์Šต๋‹ˆ๋‹ค
@@ -3,49 +3,96 @@ import { useNavigate } from 'react-router'; import { useRecoilState } from 'recoil'; import ReviewZoneIcon from '@/assets/reviewZone.svg'; -import { Button, ImgWithSkeleton } from '@/components'; +import { ImgWithSkeleton, LoginRequestModal } from '@/components'; import { ROUTE } from '@/constant...
Unknown
์ด ์ฃผ์„์„ ๋ณด๊ธฐ ์ „์—๋Š” isGroupLoggedIn์ด ๋ฌด์Šจ ๋œป์ธ์ง€ ์ถ”์ธกํ•˜๊ธฐ ์–ด๋ ค์› ์–ด์š”. ์ˆœ๊ฐ„ ์œ ์ € ๋ง๊ณ  ๋‹ค๋ฅธ ๊ทธ๋ฃน์ด ์žˆ๋‚˜? ์‹ถ์—ˆ๋Š”๋ฐ ๋งํฌ๋ฅผ ์–ด๋–ค ์ƒํƒœ๋กœ ๋งŒ๋“ค์—ˆ๋ƒ๋ฅผ ๋‚˜ํƒ€๋‚ด๋Š” ๋ณ€์ˆ˜์˜€๊ตฐ์š”~ ์ด ๋งํฌ๊ฐ€ ๋กœ๊ทธ์ธํ•œ ์‚ฌ์šฉ์ž๊ฐ€ ๋งŒ๋“  ๊ฒƒ์ธ์ง€๋ฅผ ๋ณ€์ˆ˜๋ช…์—์„œ ๋ณด๋‹ค ์ง๊ด€์ ์œผ๋กœ ๋‚˜ํƒ€๋‚ฌ์œผ๋ฉด ์ข‹๊ฒ ์–ด์š”! ๋‹ค๋ฅธ ๋ถ„๋“ค์€ ์–ด๋–ป๊ฒŒ ์ƒ๊ฐํ•˜์‹œ๋‚˜์š”?
@@ -1,5 +1,7 @@ import { ReviewGroupData } from '@/types'; +import { MOCK_USER_PROFILE } from './userProfileData'; + export const VALIDATED_PASSWORD = '1234'; export const MOCK_AUTH_TOKEN_NAME = 'mockAuthToken'; @@ -14,12 +16,18 @@ export const bothCookie = [MOCK_AUTH_TOKEN_NAME, MOCK_LOGIN_TOKEN_NAME]; */ ...
TypeScript
revieweeId๊ฐ€ ์ˆ˜์ •๋œ ์ด์œ ๊ฐ€ ๊ถ๊ธˆํ•ฉ๋‹ˆ๋‹ค! ์˜๋ฏธ ์žˆ๋Š” ๊ฐ’์ด๋ผ๋ฉด ์ƒ์ˆ˜ํ™”ํ•ด์•ผ ํ•  ๊ฒƒ ๊ฐ™์•„์„œ์š”.
@@ -3,49 +3,96 @@ import { useNavigate } from 'react-router'; import { useRecoilState } from 'recoil'; import ReviewZoneIcon from '@/assets/reviewZone.svg'; -import { Button, ImgWithSkeleton } from '@/components'; +import { ImgWithSkeleton, LoginRequestModal } from '@/components'; import { ROUTE } from '@/constant...
Unknown
`reviewWrite`๊ฐ€ `ActionOnLogin`ํƒ€์ž…์˜ ๊ฐ’์ด๋ผ ์—ฌ๊ธฐ์„œ๋„ ์ž๋™์™„์„ฑ์ด ๋˜๋ฉด ์ข‹์„ ๊ฒƒ ๊ฐ™์•„์š”. ํ˜„ `ActionOnLogin` ํƒ€์ž…์˜ ๊ฐ’๋“ค์„ ์ƒ์ˆ˜ํ™”ํ•˜๊ณ , `ActionOnLogin` ํƒ€์ž…์„ ์ƒ์ˆ˜์—์„œ ํŒŒ์ƒ๋œ ํƒ€์ž…์œผ๋กœ ๋งŒ๋“ค๋ฉด ์œ ์ง€๋ณด์ˆ˜๊ฐ€ ํŽธํ•  ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค! (๋‚˜์ค‘์—๋ผ๋„)
@@ -3,49 +3,96 @@ import { useNavigate } from 'react-router'; import { useRecoilState } from 'recoil'; import ReviewZoneIcon from '@/assets/reviewZone.svg'; -import { Button, ImgWithSkeleton } from '@/components'; +import { ImgWithSkeleton, LoginRequestModal } from '@/components'; import { ROUTE } from '@/constant...
Unknown
์ฟผ๋ฆฌ ํŒŒ๋ผ๋ฏธํ„ฐ์— ๋”ฐ๋ผ์„œ ํŽ˜์ด์ง€ ์ด๋™ํ•˜๋Š” useEffect ๋‚ด๋ถ€ ์ฝ”๋“œ๋ฅผ ๋ฐ–์œผ๋กœ ๋ถ„๋ฆฌํ–ˆ์œผ๋ฉด ์ข‹๊ฒ ์–ด์š”.
@@ -3,49 +3,96 @@ import { useNavigate } from 'react-router'; import { useRecoilState } from 'recoil'; import ReviewZoneIcon from '@/assets/reviewZone.svg'; -import { Button, ImgWithSkeleton } from '@/components'; +import { ImgWithSkeleton, LoginRequestModal } from '@/components'; import { ROUTE } from '@/constant...
Unknown
๋ฆฌ๋ทฐ ์—ฐ๊ฒฐ ํŽ˜์ด์ง€ ๋ถ„๊ธฐ ์ฒ˜๋ฆฌ๋กœ ์ธํ•ด, jsx ์ฝ”๋“œ๊ฐ€ ๋งŽ์•„์ง€๋‹ค๋ณด๋‹ˆ, ํ”„๋กœ์ ํŠธ ์ด๋ฆ„์— ๋”ฐ๋ฅธ ์กฐ์‚ฌ ์ฒ˜๋ฆฌ ์ฝ”๋“œ ๊ฐ€๋…์„ฑ ๋ถ€๋ถ„์„ ์‹ ๊ฒฝ์จ์•ผ๊ฒ ์–ด์š”. jsx๊ฐ€ ์•„๋‹Œ ์ƒ์œ„์—์„œ ๋ณ€์ˆ˜๋กœ ์ฒ˜๋ฆฌํ•˜๋Š” ๊ฒƒ์€ ์–ด๋–จ๊นŒ์š”?
@@ -3,49 +3,96 @@ import { useNavigate } from 'react-router'; import { useRecoilState } from 'recoil'; import ReviewZoneIcon from '@/assets/reviewZone.svg'; -import { Button, ImgWithSkeleton } from '@/components'; +import { ImgWithSkeleton, LoginRequestModal } from '@/components'; import { ROUTE } from '@/constant...
Unknown
ํ•˜์œ„ ์ปดํฌ๋„ŒํŠธ๋กœ ๋‚˜๋ˆˆ๋‹ค๋ฉด, ๋ถ„๋ฆฌ ์ฒ˜๋ฆฌ๋กœ ๋ณต์žกํ•œ ๋ฆฌ๋ทฐ ์—ฐ๊ฒฐ ํŽ˜์ด์ง€์˜ ์—ญํ• ์ด ํ•˜์œ„ ์ปดํฌ๋„ŒํŠธ๋ณ„๋กœ ํ•œ ๋ˆˆ์— ์ž˜ ๋ณด์ผ ๊ฑฐ ๊ฐ™์•„์š”.
@@ -1,5 +1,7 @@ import { ReviewGroupData } from '@/types'; +import { MOCK_USER_PROFILE } from './userProfileData'; + export const VALIDATED_PASSWORD = '1234'; export const MOCK_AUTH_TOKEN_NAME = 'mockAuthToken'; @@ -14,12 +16,18 @@ export const bothCookie = [MOCK_AUTH_TOKEN_NAME, MOCK_LOGIN_TOKEN_NAME]; */ ...
TypeScript
์˜๋ฏธ ์žˆ๋Š” ๊ฐ’์€ ์•„๋‹™๋‹ˆ๋‹ค๐Ÿ˜… ๋ฆฌ๋ทฐ ํ™•์ธ ์‹œ, ๋ณธ์ธ์ด ๋งŒ๋“  ๋งํฌ์ธ์ง€ ์•„๋‹Œ์ง€ ํŒ๋‹จํ•˜๋Š” ๊ณผ์ •์—์„œ ๊ฐ’์„ ๋ฐ”๊พธ๋ฉด์„œ ๋น„๊ตํ•˜๋‹ค๊ฐ€ ๊ทธ๋ƒฅ ์ปค๋ฐ‹๋๋„ค์š”. ๋ฐ”๋‹ค๊ฐ€ ์ƒ์ˆ˜ํ™” ์ž‘์—…ํ•ด์ฃผ์—ˆ์Šต๋‹ˆ๋‹ค๐Ÿ™๐Ÿป
@@ -3,49 +3,96 @@ import { useNavigate } from 'react-router'; import { useRecoilState } from 'recoil'; import ReviewZoneIcon from '@/assets/reviewZone.svg'; -import { Button, ImgWithSkeleton } from '@/components'; +import { ImgWithSkeleton, LoginRequestModal } from '@/components'; import { ROUTE } from '@/constant...
Unknown
๋ฐ˜์˜ํ–ˆ์Šต๋‹ˆ๋‹ค๐Ÿ‘๐Ÿป
@@ -3,49 +3,96 @@ import { useNavigate } from 'react-router'; import { useRecoilState } from 'recoil'; import ReviewZoneIcon from '@/assets/reviewZone.svg'; -import { Button, ImgWithSkeleton } from '@/components'; +import { ImgWithSkeleton, LoginRequestModal } from '@/components'; import { ROUTE } from '@/constant...
Unknown
์ €๋„ ๊ทธ๋ฃน ๋ณด๋‹ค๋Š” ๋งํฌ๊ฐ€ ์กฐ๊ธˆ ๋” ์ง๊ด€์ ์œผ๋กœ ์™€๋‹ฟ์•„์„œ, `isMemberLink`๋กœ ์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค. ๋‹ค๋งŒ ๊ด€๋ จ API ํ•จ์ˆ˜ ๋ฐ ํƒ€์ž…๋ช…์ด ๋ชจ๋‘ ReviewGroup์œผ๋กœ ํ‘œ๊ธฐ๋˜์–ด ์žˆ์–ด์„œ, `ReviewGroup`์ด๋ผ๋Š” ํ‘œ๊ธฐ ์ž์ฒด๋ฅผ `ReviewLink`๋กœ ํ†ต์ผํ•˜๋Š” ๊ฒŒ ์ข‹์„ ๊ฒƒ ๊ฐ™์•„์š”. ์ด๊ฑด ๋ชจ๋‘์˜ ์˜๊ฒฌ์„ ๋“ค์–ด๋ณด๊ณ  ์‹ถ์–ด์„œ ์šฐ์„  ๋ฐ˜์˜ํ•˜์ง€ ์•Š๊ฒ ์Šต๋‹ˆ๋‹ค.
@@ -3,49 +3,96 @@ import { useNavigate } from 'react-router'; import { useRecoilState } from 'recoil'; import ReviewZoneIcon from '@/assets/reviewZone.svg'; -import { Button, ImgWithSkeleton } from '@/components'; +import { ImgWithSkeleton, LoginRequestModal } from '@/components'; import { ROUTE } from '@/constant...
Unknown
> ์ฟผ๋ฆฌ ํŒŒ๋ผ๋ฏธํ„ฐ์— ๋”ฐ๋ผ์„œ ํŽ˜์ด์ง€ ์ด๋™ํ•˜๋Š” useEffect ๋‚ด๋ถ€ ์ฝ”๋“œ๋ฅผ ๋ฐ–์œผ๋กœ ๋ถ„๋ฆฌ ์ข€ ๋” ์ž์„ธํ•˜๊ฒŒ ์„ค๋ช…ํ•ด์ฃผ์‹œ๊ฒ ์–ด์š”? ๋ณ„๋„์˜ ํ•จ์ˆ˜๋กœ ๋ถ„๋ฆฌํ•ด์„œ useEffect ๋‚ด๋ถ€ ์ฝ”๋“œ๋ฅผ ์งง๊ฒŒ ์œ ์ง€ํ•˜๋Š” ๊ฒƒ์ด ๋ชฉ์ ์ธ์ง€ ๊ถ๊ธˆํ•ด์š”
@@ -3,49 +3,96 @@ import { useNavigate } from 'react-router'; import { useRecoilState } from 'recoil'; import ReviewZoneIcon from '@/assets/reviewZone.svg'; -import { Button, ImgWithSkeleton } from '@/components'; +import { ImgWithSkeleton, LoginRequestModal } from '@/components'; import { ROUTE } from '@/constant...
Unknown
ํ•ฉ์„ฑ ์ปดํฌ๋„ŒํŠธ ํŒจํ„ด์œผ๋กœ ๊ตฌํ˜„ํ•œ ๋ฒ„ํŠผ๋“ค์„ ๊ฐ๊ฐ์˜ ์ปดํฌ๋„ŒํŠธ๋กœ ๋ถ„๋ฆฌํ•˜๋ฉด ์ข‹๊ฒ ๋‹ค๋Š” ์˜๊ฒฌ์ผ๊นŒ์š”? ๋ฒ„ํŠผ๋งˆ๋‹ค ์Šคํƒ€์ผ ์ฝ”๋“œ๊ฐ€ ๊ฐ™๊ณ , ๋‚˜๋ˆˆ๋‹ค๋ฉด Write/Check ๋‘˜๋กœ๋งŒ ๋‚˜๋ˆŒ์ง€ ๋“ฑ ์ƒ๊ฐํ•  ๋ถ€๋ถ„๋“ค์ด ์žˆ์–ด์„œ ์ข€ ๋” ๊ณ ๋ฏผํ•ด๋ณด๊ฒ ์Šต๋‹ˆ๋‹ค (์ด ๋ถ€๋ถ„ ์ฝ”๋“œ๋ฅผ ๋‹ค๋“ฌ์–ด์•ผ ํ•œ๋‹ค๋Š” ๊ฒƒ์— ๋™์˜ํ•ด์š”)
@@ -3,49 +3,96 @@ import { useNavigate } from 'react-router'; import { useRecoilState } from 'recoil'; import ReviewZoneIcon from '@/assets/reviewZone.svg'; -import { Button, ImgWithSkeleton } from '@/components'; +import { ImgWithSkeleton, LoginRequestModal } from '@/components'; import { ROUTE } from '@/constant...
Unknown
์Šคํƒ€์ผ ์ปดํฌ๋„ŒํŠธ๋ช…์œผ๋กœ ๋ ˆ์ด์•„์›ƒ ๊ตฌ๋ถ„์€ ํ•  ์ˆ˜ ์žˆ์ง€๋งŒ, ์ปดํฌ๋„ŒํŠธ๋“ค์ด ๋‚˜์—ด๋œ ๋А๋‚Œ์ด๋ผ ํฌ๊ฒŒ ๋ฆฌ๋ทฐ ๊ทธ๋ฃน ์ •๋ณด, ์“ฐ๊ธฐ ๋ฒ„ํŠผ, ํ™•์ธ ๋ฒ„ํŠผ, ๋ชจ๋‹ฌ๋กœ ๋‚˜๋‰˜์–ด์งˆ ์ˆ˜ ์žˆ์„ ๊ฒƒ ๊ฐ™์•„์š”. ๋ชจ๋‹ฌ์€ ํ•ด๋‹น ๋ชจ๋‹ฌ์„ ์—ด๊ฒŒํ•˜๋Š” ๋ฒ„ํŠผ๊ณผ ์—ฎ์–ด์„œ ํ•˜๋‚˜์˜ ์ปดํฌ๋„ŒํŠธ๋‚ด์—์„œ ๊ด€๋ฆฌํ•˜๋ฉด ํ๋ฆ„ ํŒŒ์•…์— ๋” ์ข‹์„ ๊ฒƒ ๊ฐ™์•„์š”.
@@ -11,12 +11,178 @@ on: jobs: code_review: runs-on: ubuntu-latest - name: ChatGPT Code Review + name: Gemini Code Review steps: - - uses: anc95/ChatGPT-CodeReview@main + - uses: actions/checkout@v4 + + - name: Setup Node.js + uses: actions/setup-node@v4 + with: + ...
Unknown
์ด ์ฝ”๋“œ๋Š” GitHub Actions๋ฅผ ์ด์šฉํ•˜์—ฌ Google Gemini API๋ฅผ ํ†ตํ•ด Pull Request์— ๋Œ€ํ•œ ์ฝ”๋“œ ๋ฆฌ๋ทฐ๋ฅผ ์ž๋™ํ™”ํ•˜๋Š” ์ž‘์—…์ž…๋‹ˆ๋‹ค. ํ•˜์ง€๋งŒ ๋ช‡ ๊ฐ€์ง€ ๊ฐœ์„ ์ด ํ•„์š”ํ•ฉ๋‹ˆ๋‹ค. **1. ์ฝ”๋“œ์˜ ํ’ˆ์งˆ๊ณผ ๊ฐ€๋…์„ฑ:** * **๊ฐ€๋…์„ฑ ๊ฐœ์„ :** `reviewCode` ํ•จ์ˆ˜ ๋‚ด๋ถ€์˜ JSON ๊ตฌ์กฐ๊ฐ€ ์ค‘์ฒฉ๋˜์–ด ๊ฐ€๋…์„ฑ์ด ๋–จ์–ด์ง‘๋‹ˆ๋‹ค. ๋” ๋ช…ํ™•ํ•œ ๋ณ€์ˆ˜๋ช…์„ ์‚ฌ์šฉํ•˜๊ณ , JSON ์ƒ์„ฑ ๋ถ€๋ถ„์„ ์—ฌ๋Ÿฌ ์ค„๋กœ ๋‚˜๋ˆ„์–ด ๊ฐ€๋…์„ฑ์„ ๋†’์—ฌ์•ผ ํ•ฉ๋‹ˆ๋‹ค. ์˜ˆ๋ฅผ ๋“ค์–ด, `contents`, `parts` ๋“ฑ์˜ ๋ณ€์ˆ˜๋ช…์€ ์ปจํ…์ŠคํŠธ๋ฅผ ๋ช…ํ™•ํžˆ ํ•˜๋„๋ก ์ˆ˜์ •ํ•  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค. * **์˜ค๋ฅ˜ ์ฒ˜๋ฆฌ ๋ถ€์กฑ:*...
@@ -11,12 +11,178 @@ on: jobs: code_review: runs-on: ubuntu-latest - name: ChatGPT Code Review + name: Gemini Code Review steps: - - uses: anc95/ChatGPT-CodeReview@main + - uses: actions/checkout@v4 + + - name: Setup Node.js + uses: actions/setup-node@v4 + with: + ...
Unknown
## Gemini Code Review Workflow ํŒŒ์ผ ๋ฆฌ๋ทฐ (code_review.yml) ๋‹ค์Œ์€ ์ œ๊ณต๋œ `code_review.yml` ํŒŒ์ผ์— ๋Œ€ํ•œ ์ƒ์„ธ ๋ฆฌ๋ทฐ์ž…๋‹ˆ๋‹ค. ์‹œ๋‹ˆ์–ด ๊ฐœ๋ฐœ์ž์˜ ๊ด€์ ์—์„œ ์ฝ”๋“œ ํ’ˆ์งˆ, ์ž ์žฌ์  ๋ฌธ์ œ์ , ์„ฑ๋Šฅ ๊ฐœ์„ , ๋ณด์•ˆ ์ด์Šˆ ๋ฐ ๊ฐœ์„  ์ œ์•ˆ์„ ๋‹ค๋ฃน๋‹ˆ๋‹ค. **1. ์ฝ”๋“œ์˜ ํ’ˆ์งˆ๊ณผ ๊ฐ€๋…์„ฑ** * **์ „๋ฐ˜์ ์œผ๋กœ ์–‘ํ˜ธ:** ์ฝ”๋“œ์˜ ๊ตฌ์กฐ๊ฐ€ ๋น„๊ต์  ๋ช…ํ™•ํ•˜๊ณ , ์ฃผ์„์ด ์ ์ ˆํ•˜๊ฒŒ ์‚ฌ์šฉ๋˜์–ด ๊ฐ€๋…์„ฑ์ด ๋†’์Šต๋‹ˆ๋‹ค. ํ•จ์ˆ˜๋ณ„ ์—ญํ•  ๋ถ„๋‹ด๋„ ์ž˜ ๋˜์–ด ์žˆ์Šต๋‹ˆ๋‹ค. * **ํ•จ์ˆ˜๋ช…:** ํ•จ์ˆ˜๋ช…(`reviewCode`, `processFile`)์€ ์—ญํ• ์„ ๋ช…ํ™•ํžˆ ์„ค๋ช…ํ•˜๋ฉฐ...
@@ -11,12 +11,178 @@ on: jobs: code_review: runs-on: ubuntu-latest - name: ChatGPT Code Review + name: Gemini Code Review steps: - - uses: anc95/ChatGPT-CodeReview@main + - uses: actions/checkout@v4 + + - name: Setup Node.js + uses: actions/setup-node@v4 + with: + ...
Unknown
## .github/workflows/code_review.yml ์ฝ”๋“œ ๋ฆฌ๋ทฐ ๋‹ค์Œ์€ ์ฃผ์–ด์ง„ `.github/workflows/code_review.yml` ํŒŒ์ผ์— ๋Œ€ํ•œ ์ฝ”๋“œ ๋ฆฌ๋ทฐ์ž…๋‹ˆ๋‹ค. **1. ์ฝ”๋“œ ํ’ˆ์งˆ ๋ฐ ๊ฐ€๋…์„ฑ** * **์ „๋ฐ˜์ ์œผ๋กœ ์–‘ํ˜ธ:** ์ฝ”๋“œ๋Š” ๋น„๊ต์  ๊น”๋”ํ•˜๊ณ  ๊ฐ€๋…์„ฑ์ด ์ข‹์Šต๋‹ˆ๋‹ค. ์ฃผ์„๋„ ์ ์ ˆํ•˜๊ฒŒ ๋‹ฌ๋ ค ์žˆ์–ด ์ฝ”๋“œ์˜ ์˜๋„๋ฅผ ํŒŒ์•…ํ•˜๋Š” ๋ฐ ๋„์›€์ด ๋ฉ๋‹ˆ๋‹ค. * **์ผ๊ด€์„ฑ:** ๋“ค์—ฌ์“ฐ๊ธฐ, ๋ณ€์ˆ˜๋ช… ๊ทœ์น™ ๋“ฑ์ด ์ผ๊ด€์„ฑ์„ ์œ ์ง€ํ•˜๊ณ  ์žˆ์Šต๋‹ˆ๋‹ค. * **๋ชจ๋“ˆํ™”:** `reviewCode`, `processFile` ๋“ฑ์˜ ํ•จ์ˆ˜๋กœ ๋กœ์ง์„ ๋ถ„๋ฆฌํ•˜์—ฌ ์žฌ์‚ฌ์šฉ์„ฑ๊ณผ ์œ ์ง€...
@@ -0,0 +1,88 @@ +import styled from "styled-components"; + +export const ReviewSectionName = styled.h2` + +`; + +export const ReviewFormArea = styled.div` + position: absolute; + width: 918px; + height: 240px; + padding: 14px 23px; + background-color: #00462A; + border-radius: 20px; + flex-directi...
Unknown
styled-component ๊น”๋”ํ•˜๊ฒŒ ์ž˜ ์“ฐ์‹  ๊ฒƒ ๊ฐ™์•„์š”! ์ˆ˜๊ณ  ๋งŽ์œผ์…จ์Šต๋‹ˆ๋‹ค~
@@ -0,0 +1,7 @@ +package nextstep.security.role; + +import java.util.Collection; + +public interface RoleHierarchy { + Collection<GrantedAuthority> getReachableRoles(Collection<GrantedAuthority> authorities); +}
Java
> ๊ทธ๋Ÿฐ๋ฐ Spring Security ์ฝ”๋“œ ์ „๋ฐ˜์—์„œ๋Š” Authority๋ฅผ ์ฃผ๋กœ ์‚ฌ์šฉํ•˜๋Š”๋ฐ, > RoleHierarchy์—์„œ ํŠน๋ณ„ํžˆ Role์ด๋ผ๋Š” ์šฉ์–ด๋ฅผ ์‚ฌ์šฉํ•˜๋Š” ์ด์œ ๊ฐ€ ๊ถ๊ธˆํ•˜๋„ค์š”. > ์ด๋ ‡๊ฒŒ Role์ด๋ผ๋Š” ์šฉ์–ด๋ฅผ ์‚ฌ์šฉํ•˜๋Š” ์ด์œ ๋Š” ์—ญํ• ๋กœ ๋น„๊ตํ•œ๋‹ค๊ณ  ๋ช…์‹œ์ ์œผ๋กœ ๋ณด์—ฌ์ฃผ๊ธฐ ์œ„ํ•ด์„œ ์ผ๊นŒ์š”?? ํ˜น์‹œ ์–ด๋”” ์ฝ”๋“œ์—์„œ `RoleHierarchy.getReachableRoles`๋กœ ๋˜์–ด์žˆ์„๊นŒ์š”? ์‹ค์ œ ์Šคํ”„๋ง ์‹œํ๋ฆฌํ‹ฐ ์ฝ”๋“œ์—์„œ๋„ ๋ง์”€ํ•ด์ฃผ์‹ ๋Œ€๋กœ authority๋ผ๋Š” ํ‘œํ˜„์„ ์‚ฌ์šฉํ•˜๊ณ  ์žˆ์–ด์š”. ```java Collection<? extends GrantedAuthority>...
@@ -17,6 +17,7 @@ import nextstep.security.matcher.AnyRequestMatcher; import nextstep.security.matcher.MvcRequestMatcher; import nextstep.security.matcher.RequestMatcherEntry; +import nextstep.security.role.*; import nextstep.security.userdetails.UserDetails; import nextstep.security.userdetails.UserDetailsService...
Java
์ž˜ ์ถ”๊ฐ€ํ•ด์ฃผ์…จ๋„ค์š” ๐Ÿ‘
@@ -0,0 +1,10 @@ +package nextstep.security.role; + +import java.util.Collection; + +public class NullRoleHierarchy implements RoleHierarchy { + @Override + public Collection<GrantedAuthority> getReachableRoles(Collection<GrantedAuthority> authorities) { + return authorities; + } +}
Java
`RoleHierarchy`์˜ ์˜๋ฌธ๋ช… ๊ทธ๋Œ€๋กœ ์ด ์ธํ„ฐํŽ˜์ด์Šค์˜ ์—ญํ• ์€ "์—ญํ•  ๊ณ„์ธต"์„ ๋งŒ๋“ค์–ด์ฃผ๋Š” ๊ฒƒ์ด์—์š”. ๊ทธ๋ž˜์„œ ๊ตฌํ˜„์ฒด๋“ค๋„ ์—ญํ•  ๊ณ„์ธต์„ ๋งŒ๋“ค์–ด์ฃผ๋Š” ๊ฒƒ์œผ๋กœ ๊ตฌ์„ฑ์ด ๋˜์–ด์•ผํ•˜๋Š”๋ฐ์š”. `NullRoleHierarchy`์ด๋ผ๋Š” ๊ฒƒ์€ null์ด๋ผ๋Š” ๋ง์ด ํ‘œํ˜„๋˜์–ด์žˆ๊ธฐ๋Š”ํ•˜์ง€๋งŒ ์ง์—ญํ•˜๋ฉด "์—ญํ•  ๊ณ„์ธต์ด ์—†๋‹ค"์ž…๋‹ˆ๋‹ค. ๊ณ„์ธต์ด ์—†๋‹ค๋Š” ๊ฒƒ์ด์ง€ authority๊ฐ€ ์—†๋‹ค๋Š” ๋œป์€ ์•„๋‹ˆ๊ธฐ ๋•Œ๋ฌธ์— empty๋ฅผ ๋ฐ˜ํ™˜ํ•˜๊ธฐ๋ณด๋‹ค๋Š” ์ธ์ž…๋œ ํŒŒ๋ผ๋ฉ”ํ„ฐ๋ฅผ ๊ทธ๋Œ€๋กœ ๋ฐ˜ํ™˜ํ•ด์ฃผ๋Š” ๊ฒƒ์ด ๊ทธ ๋ชฉ์ ์ด๋ผ๊ณ  ๋ณผ ์ˆ˜ ์žˆ์–ด์š”.
@@ -0,0 +1,96 @@ +package nextstep.security.role; + +import org.springframework.util.StringUtils; + +import java.util.*; + +public class RoleHierarchyImpl implements RoleHierarchy { + + private static final List<GrantedAuthority> EMPTY_AUTHORITIES = Collections.emptyList(); + + private final Map<String, Set<Grant...
Java
```suggestion private static final List<GrantedAuthority> EMPTY_AUTHORITIES = Collections.emptyList(); private final Map<String, Set<GrantedAuthority>> roleHierarchy; ``` ์ƒ์ˆ˜๋Š” ์ž๋ฐ” ์ปจ๋ฒค์…˜์ƒ ๊ฐ€์žฅ ์œ„์— ์žˆ์–ด์•ผํ•˜๊ณ , `roleHierarchy`๋Š” ์ ‘๊ทผ์ œ์–ด๊ฐ€ ํ•„์š”ํ•ด๋ณด์ด๋„ค์š” :)
@@ -0,0 +1,96 @@ +package nextstep.security.role; + +import org.springframework.util.StringUtils; + +import java.util.*; + +public class RoleHierarchyImpl implements RoleHierarchy { + + private static final List<GrantedAuthority> EMPTY_AUTHORITIES = Collections.emptyList(); + + private final Map<String, Set<Grant...
Java
`RoleHierarchyImpl`์— ๋Œ€ํ•œ ํ…Œ์ŠคํŠธ๋„ ์ถ”๊ฐ€ํ•ด๋ณด๋ฉด ์–ด๋–จ๊นŒ์š”? ๊ธฐ๋Šฅ์ด ๋ณต์žกํ•œ ๊ฐ์ฒด์ด๋‹ˆ ์ด๋ฅผ ๋ฌธ์„œํ™”ํ•œ๋‹ค๋Š” ๋А๋‚Œ์œผ๋กœ ํ…Œ์ŠคํŠธ๋ฅผ ์งœ๋ณด์…”๋„ ์ข‹์€ ๊ฒฝํ—˜์ด ๋  ๊ฒƒ ๊ฐ™์•„์š” :)
@@ -0,0 +1,7 @@ +package nextstep.security.role; + +import java.util.Collection; + +public interface RoleHierarchy { + Collection<GrantedAuthority> getReachableRoles(Collection<GrantedAuthority> authorities); +}
Java
์ œ๊ฐ€ ์ž˜๋ชป ์งˆ๋ฌธ์„ ๋“œ๋ ธ๋„ค์š”. ์ฃ„์†กํ•ฉ๋‹ˆ๋‹ค. getReachableRoles๋Š” ๋ฏธ์…˜ ์ฝ”๋“œ์— ๋ถ€๋ถ„์ด์˜€๋„ค์š”. ๐Ÿ˜… ๊ทธ๋ž˜๋„ Role ์ด๋ฆ„์€ ์‹œํ๋ฆฌํ‹ฐ์˜ RoleHierarchy์˜ ๊ตฌํ˜„์ฒด ์ฝ”๋“œ์—๋„ ์ข…์ข… ์‚ฌ์šฉ๋˜๋Š” ๊ฒƒ ๊ฐ™์•„์š” ์˜ˆ๋ฅผ ๋“ค์–ด์„œ getReachableGrantedAuthorities ์˜ ๊ตฌํ˜„ ๋ฉ”์„œ๋“œ ์ค‘ ``` java Set<GrantedAuthority> lowerRoles = this.rolesReachableInOneOrMoreStepsMap.get(authority.getAuthority()); if (lowerRoles == null) { ...
@@ -0,0 +1,10 @@ +package nextstep.security.role; + +import java.util.Collection; + +public class NullRoleHierarchy implements RoleHierarchy { + @Override + public Collection<GrantedAuthority> getReachableRoles(Collection<GrantedAuthority> authorities) { + return authorities; + } +}
Java
์•„ํ•˜ ์ €๋„ NULL์„ ์™œ ์“ฐ์ง€ ๋ผ๋Š” ์˜๋ฌธ์ด ์žˆ์—ˆ๋Š”๋ฐ , ๋นˆ ๊ถŒํ•œ์„ ์ฃผ๋Š” ๊ฒƒ์ด ์•„๋‹ˆ๋ผ ๋ง ๊ทธ๋Œ€๋กœ RoleHierarchy ๊ฐ€ ์—†๋‹ค๋ผ๋Š” ์˜๋ฏธ๊ตฐ์š”!
@@ -0,0 +1,96 @@ +package nextstep.security.role; + +import org.springframework.util.StringUtils; + +import java.util.*; + +public class RoleHierarchyImpl implements RoleHierarchy { + + private static final List<GrantedAuthority> EMPTY_AUTHORITIES = Collections.emptyList(); + + private final Map<String, Set<Grant...
Java
์ˆ˜์ •ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค!
@@ -0,0 +1,7 @@ +package nextstep.security.role; + +import java.util.Collection; + +public interface RoleHierarchy { + Collection<GrantedAuthority> getReachableRoles(Collection<GrantedAuthority> authorities); +}
Java
๋„ค spring security์—์„œ๋Š” ์ธ๊ฐ€์ฒ˜๋ฆฌ ๊ถŒํ•œ(Authority)๊ฐ€ ์žˆ์ง€๋งŒ, ๊ทธ ๊ถŒํ•œ์„ ์—ญํ• ๋ณ„๋กœ ๊ณ„์ธต์œผ๋กœ ๋ถ„๋ฆฌํ•˜๋ คํ–ˆ๊ณ  ๊ทธ๋ ‡๊ฒŒ ๋‚˜์˜จ ๊ฒƒ์ด `RoleHierarchy`๋ผ๊ณ  ๋ณด์‹œ๋ฉด ๋  ๊ฒƒ ๊ฐ™์•„์š”. ๋‘ ์ •๋ณด๊ฐ€ ๋™์ผํ•  ์ˆ˜๋Š” ์žˆ๋Š”๋ฐ ์“ฐ์ž„์ƒˆ ์ž์ฒด๊ฐ€ ๊ถŒํ•œ, ๊ถŒํ•œ๋ณ„ ์—ญํ• ๋กœ ํ•œ๋ฒˆ ๋” ์ชผ๊ฐœ์ง„๋‹ค๊ณ  ๋ณด์‹œ๋ฉด ๋  ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค. https://docs.spring.io/spring-security/reference/servlet/authorization/architecture.html?utm_source=chatgpt.com#authz-hierarchical-roles
@@ -0,0 +1,101 @@ +package nextstep.security.role; + +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.DisplayName; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.NullAndEmptySource; +import org.junit.jupiter.params...
Java
junit5์—์„œ๋Š” ์ดˆ๊ธฐํ™” ๋‹จ์œ„๊ฐ€ ๋ฉ”์†Œ๋“œ ๋‹จ์œ„์ด๊ธฐ ๋•Œ๋ฌธ์— ๋”ฐ๋กœ setup์œผ๋กœ ์ดˆ๊ธฐํ™”ํ•ด์ฃผ์‹œ ์•Š์œผ์…”๋„ ๋ฉ๋‹ˆ๋‹ค. https://junit.org/junit5/docs/current/user-guide/#writing-tests-test-instance-lifecycle
@@ -0,0 +1,101 @@ +package nextstep.security.role; + +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.DisplayName; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.NullAndEmptySource; +import org.junit.jupiter.params...
Java
1. ์ถ”๊ฐ€ํ•œ๋‹ค๊ธฐ๋ณด๋‹ค๋Š” ๊ณ„์ธต์„ ๊ฐ€์ ธ์˜จ๋‹ค์— ๋” ๊ฐ€๊นŒ์šด ํ…Œ์ŠคํŠธ๋กœ ๋ณด์ด๋„ค์š”. 2. `SimpleGrantedAuthority authority = new SimpleGrantedAuthority(target);`๋Š” ๊ทธ๋ž˜์„œ ๋”ฐ์ง€๊ณ ๋ณด๋ฉด ์ฃผ์–ด์ง„ ๋ฐ์ดํ„ฐ์ธ given์— ๋” ๊ฐ€๊น์Šต๋‹ˆ๋‹ค. when์—๋Š” ํ…Œ์ŠคํŠธ๋ฅผ ์ฆ๋ช…ํ•˜๊ณ ์žํ•˜๋Š” ๋Œ€์ƒ์˜ ์‹คํ–‰ ๊ทธ์ž์ฒด๋งŒ์„ ๋„ฃ์–ด์ฃผ์‹œ๋ฉด ์ข‹์„ ๊ฒƒ ๊ฐ™์•„์š”. 3. expected ๋˜ํ•œ given์— ๋“ค์–ด๊ฐ€๋Š” ๊ฒƒ์ด ๋งž๊ฒ ์ฃ . 74๋ฒˆ๋ผ์ธ์— ๊ฐ’์„ ๊ทธ๋Œ€๋กœ ๋„ฃ๋Š” ๊ฒฝ์šฐ๋Š” ์ƒ๊ด€์ด ์—†์ง€๋งŒ ๊ธฐ๋Œ“๊ฐ’ ๋˜ํ•œ ์ฃผ์–ด์ง„ ๋ฐ์ดํ„ฐ๋ผ๊ณ  ๋ณด๋Š” ํŽธ์ž…๋‹ˆ๋‹ค.
@@ -0,0 +1,101 @@ +package nextstep.security.role; + +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.DisplayName; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.NullAndEmptySource; +import org.junit.jupiter.params...
Java
๊ทธ๋ž˜์„œ ์ถ”๊ฐ€ํ•จ(`addImplies`)๋ฅผ ํ…Œ์ŠคํŠธํ•˜๊ณ ์‹ถ๋‹ค๋ฉด ์ •๋ง ๊ฐ’์ด ์ถ”๊ฐ€๋˜์—ˆ๋Š”์ง€ ๊ทธ ์ž์ฒด๋งŒ์„ ํ…Œ์ŠคํŠธํ•˜๋Š” ๊ฒƒ์ด ๋‚˜์„ ์ˆ˜๋„ ์žˆ์–ด์š”. `private final Map<String, Set<GrantedAuthority>> rolesReachableInOneOrMoreStepsMap;`์— ์›ํ•˜๋Š” ๊ฐ’์ด ์žˆ๋Š”์ง€ ํ™•์ธํ•˜๋Š” ๊ฒƒ์œผ๋กœ์š”.
@@ -0,0 +1,101 @@ +package nextstep.security.role; + +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.DisplayName; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.NullAndEmptySource; +import org.junit.jupiter.params...
Java
`@CsvSource`๋ฅผ ํ™œ์šฉํ•˜๋ฉด ๊ธฐ๋Œ“๊ฐ’์— ๋Œ€ํ•œ ๋ถ„๊ธฐ์ฒ˜๋ฆฌ๋ฅผ ํ…Œ์ŠคํŠธ์—์„œ ํ•˜์ง€ ์•Š์•„๋„ ๋  ๊ฒƒ ๊ฐ™์•„์š”.
@@ -0,0 +1,101 @@ +package nextstep.security.role; + +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.DisplayName; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.NullAndEmptySource; +import org.junit.jupiter.params...
Java
ํ…Œ์ŠคํŠธ๋กœ ์–ด๋–ค ๊ธฐ๋Šฅ์ด ์žˆ๋Š”์ง€ ์ž˜ ๋ณด์ด๋„ค์š” ๐Ÿ‘
@@ -0,0 +1,101 @@ +package nextstep.security.role; + +import org.junit.jupiter.api.BeforeEach; +import org.junit.jupiter.api.DisplayName; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.params.ParameterizedTest; +import org.junit.jupiter.params.provider.NullAndEmptySource; +import org.junit.jupiter.params...
Java
์ „์ฒด ๋™์ž‘์ด ์•„๋‹Œ rolesReachableInOneOrMoreStepsMap ์ž์ฒด์— ๊ฐ’์ด ์ €์žฅ๋˜์–ด์žˆ๋Š”์ง€ ํ™•์ธํ•˜๋Š”๊ฒŒ ์ถ”๊ฐ€๋˜์—ˆ๋Š”๊ฐ€ ์— ๋Œ€ํ•œ ํ…Œ์ŠคํŠธ๋กœ ๋” ์ขํ˜€์ง€๊ฒ ๋„ค์š”!
@@ -0,0 +1,77 @@ +import React, { useState } from "react"; +import styled from "styled-components"; +import { Star as StarIcon } from "lucide-react"; + +interface StarRatingProps { + totalStars?: number; + initialRating?: number; + onRatingChange?: (rating: number) => void; +} + +const BackgroundContainer = styled.d...
Unknown
filled ์•ˆ์ชฝ์— String์œผ๋กœ ๊ฐ์‹ธ์ฃผ์„ธ์š”
@@ -0,0 +1,77 @@ +import React, { useState } from "react"; +import styled from "styled-components"; +import { Star as StarIcon } from "lucide-react"; + +interface StarRatingProps { + totalStars?: number; + initialRating?: number; + onRatingChange?: (rating: number) => void; +} + +const BackgroundContainer = styled.d...
Unknown
์ œ๊ฐ€ ํ›„๊ธฐ ํŽ˜์ด์ง€ ๋งŒ๋“ค๋ฉด์„œ ์ด ๋ถ€๋ถ„ ์ˆ˜์ •ํ•ด์„œ ํ•œ๊บผ๋ฒˆ์— PR ์˜ฌ๋ฆฌ๊ฒ ์Šต๋‹ˆ๋‹ค
@@ -1,5 +1,7 @@ package com.chone.server.domains.review.domain; +import static org.springframework.util.StringUtils.hasText; + import com.chone.server.commons.jpa.BaseEntity; import com.chone.server.domains.order.domain.Order; import com.chone.server.domains.store.domain.Store; @@ -80,4 +82,12 @@ public static Re...
Java
ํ•ด๋‹น update ๋ฉ”์„œ๋“œ์˜ ๊ฒฝ์šฐ์— not null์ด๋‚˜ not blank ์œ ํšจ์„ฑ ๊ฒ€์ฆ์„ ์•ˆ ํ•˜๊ณ  ์žˆ์Šต๋‹ˆ๋‹ค. ๋”ฐ๋กœ ์ด์œ ๊ฐ€ ์žˆ์„๊นŒ์š”? ๋งŒ์ผ ์ด๋Ÿด ๊ฒฝ์šฐ request์—์„œ null์ด ์žˆ๋Š” ๊ฐ’์ด ์žˆ๋‹ค๋ฉด ์—”ํ‹ฐํ‹ฐ์˜ ํ•„๋“œ ๊ฐ’์ด null๋กœ ๋ณ€๊ฒฝ๋˜๊ณ , ์ด๊ฒƒ์ด ๋ณ€๊ฒฝ๊ฐ์ง€๊ฐ€ ๋˜์–ด์„œ ๋ฐ์ดํ„ฐ๋ฒ ์ด์Šค์— ๋ฐ์ดํ„ฐ๊ฐ€ null ๊ฐ’์œผ๋กœ ์—…๋ฐ์ดํŠธ๋  ๊ฐ€๋Šฅ์„ฑ์ด ์žˆ์Šต๋‹ˆ๋‹ค!(์˜ˆ๋ฅผ ๋“ค์–ด, `update(null, null, null, null)`์„ ํ˜ธ์ถœํ•˜๋ฉด ํ•ด๋‹น ํ•„๋“œ๊ฐ€ null๋กœ ๋ฎ์–ด์”Œ์›Œ์ง‘๋‹ˆ๋‹ค) ```java import static org.springframework.util.StringUtils.has...
@@ -8,9 +8,11 @@ import com.chone.server.domains.review.domain.Review; import com.chone.server.domains.review.dto.request.CreateRequestDto; import com.chone.server.domains.review.dto.request.ReviewListRequestDto; +import com.chone.server.domains.review.dto.request.UpdateRequestDto; import com.chone.server.domains.r...
Java
์ €๋„ ์ด๋ฒˆ์— ์ฃผ๋ฌธ ์‚ญ์ œ ๊ธฐ๋Šฅ์„ ๊ตฌํ˜„ํ•˜๋ฉด์„œ ๊ฐ‘์ž๊ธฐ ๊นจ๋‹ฌ์€ ๊ฑด๋ฐ, ์ €ํฌ๊ฐ€ soft delete๋ฅผ ํ•˜๊ณ  ์žˆ์–ด์„œ findById๋ฅผ ํ•  ๋•Œ ์กฐ๊ฑด์œผ๋กœ deletedAt null ์กฐ๊ฑด์„ ๊ฑธ์–ด์•ผ ์‚ญ์ œ๋œ ๊ฒƒ์„ ์ œ์™ธํ•  ์ˆ˜ ์žˆ๊ฒŒ ๋ฉ๋‹ˆ๋‹ค. ๊ทธ๋ž˜์„œ ์กฐํšŒ ์‹œ ํ•ด๋‹น ์กฐ๊ฑด์„ ํฌํ•จํ•˜์—ฌ ์ˆ˜์ •ํ•˜๋Š” ๊ฒƒ์ด ์ข‹์„ ๊ฒƒ ๊ฐ™์•„์š”! ์•„๋‹ˆ๋ฉด ๋ธŒ๋žœ์น˜๋ฅผ ์ƒˆ๋กœ ํŒŒ์„œ ํ•ด๋‹น ๊ด€๋ จ ์กฐํšŒ๋“ค์„ ์ˆ˜์ •ํ•ด๋ณด๋ฉด ์ข‹์„ ๊ฒƒ ๊ฐ™์Šต๋‹ˆ๋‹ค!
@@ -1,5 +1,7 @@ package com.chone.server.domains.review.domain; +import static org.springframework.util.StringUtils.hasText; + import com.chone.server.commons.jpa.BaseEntity; import com.chone.server.domains.order.domain.Order; import com.chone.server.domains.store.domain.Store; @@ -80,4 +82,12 @@ public static Re...
Java
์„œ๋น„์Šค ๋ ˆ์ด์–ด์—์„œ ์œ ํšจ์„ฑ ๊ฒ€์‚ฌ๋ฅผ ์ˆ˜ํ–‰ํ•˜๊ณ  ์žˆ๊ธฐ ๋•Œ๋ฌธ์— ์ด๋ ‡๊ฒŒ ๋˜๋ฉด ํ•ด๋‹น ํ•„๋“œ์—์„œ null ๋กœ DB ๋ฐ˜์˜๋œ๋‹ค๋Š” ๊ฑธ ๋†“์ณค์Šต๋‹ˆ๋‹ค! ์•Œ๋ ค์ฃผ์‹  ๋ฐฉ๋ฒ•์œผ๋กœ ์ˆ˜์ •ํ•˜๋„๋ก ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค :)
@@ -8,9 +8,11 @@ import com.chone.server.domains.review.domain.Review; import com.chone.server.domains.review.dto.request.CreateRequestDto; import com.chone.server.domains.review.dto.request.ReviewListRequestDto; +import com.chone.server.domains.review.dto.request.UpdateRequestDto; import com.chone.server.domains.r...
Java
์กฐํšŒ ์‹œ ์‚ญ์ œ๋œ ๋ฆฌ๋ทฐ ์กฐํšŒ๋˜์ง€ ์•Š๋„๋ก ์ˆ˜์ •ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค~
@@ -0,0 +1,48 @@ +package com.ioteam.order_management_platform.review.entity; + +import com.ioteam.order_management_platform.global.entity.BaseEntity; +import com.ioteam.order_management_platform.review.dto.CreateReviewRequestDto; +import com.ioteam.order_management_platform.review.dto.ReviewResponseDto; +import jakart...
Java
P5: ๋‹จ์ˆœ ๊ถ๊ธˆ์ฆ์ž…๋‹ˆ๋‹ค! ๊ธฐ๋ณธ ์ง€์‹์ด ๋ถ€์กฑํ•˜์—ฌ Boolean์€ default ๊ฐ’์ด null์ด๊ณ , boolean์€ false์ธ ๊ฒƒ์ด ์ฐจ์ด์ ์ด๋ผ๋Š” ๊ฒƒ๋งŒ ์•Œ๊ณ  ์—ฌ์ญค๋ณด๋Š” ์ .. ์–‘ํ•ด๋ถ€ํƒ๋“œ๋ฆฝ๋‹ˆ๋‹ค..! ๐Ÿ˜… Boolean์„ ์‚ฌ์šฉํ•œ ์ด์œ ๊ฐ€ ๊ถ๊ธˆํ•ฉ๋‹ˆ๋‹ค. P4: ๊ณต๊ฐœ ์—ฌ๋ถ€ ๊ธฐ๋ณธ๊ฐ’์ด true ์ด๋ฏ€๋กœ @ColumnDefault ๋กœ ๊ธฐ๋ณธ๊ฐ’ ์„ค์ •์ด ํ•„์š”ํ•˜์ง„ ์•Š์„๊นŒ์š”?? ๐Ÿ˜€
@@ -0,0 +1,48 @@ +package com.ioteam.order_management_platform.review.entity; + +import com.ioteam.order_management_platform.global.entity.BaseEntity; +import com.ioteam.order_management_platform.review.dto.CreateReviewRequestDto; +import com.ioteam.order_management_platform.review.dto.ReviewResponseDto; +import jakart...
Java
@Ryujy ๋‹˜, ์˜๊ฒฌ ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค! @ColumnDefault ๋กœ ๊ธฐ๋ณธ๊ฐ’ ์„ค์ •ํ•˜๋Š” ๋ถ€๋ถ„์„ ๋†“์ณค๋„ค์š”. ์ถ”๊ฐ€ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค. Boolean์„ ์‚ฌ์šฉํ•˜๋Š” ์ด์œ ๋Š” ํŠน๋ณ„ํžˆ๋Š” ์—†์Šต๋‹ˆ๋‹ค.
@@ -0,0 +1,48 @@ +package com.ioteam.order_management_platform.review.entity; + +import com.ioteam.order_management_platform.global.entity.BaseEntity; +import com.ioteam.order_management_platform.review.dto.CreateReviewRequestDto; +import com.ioteam.order_management_platform.review.dto.ReviewResponseDto; +import jakart...
Java
@Ryujy ๋‹˜ Boolean ์‚ฌ์šฉํ•œ ์ด์œ  ๊ณต๋ถ€ํ•ด๋‘๊ณ  ๊นŒ๋จน๊ณ  ์žˆ์—ˆ๋„ค์š”. - boolean์œผ๋กœ ์‚ฌ์šฉํ•˜๋Š” ๊ฒฝ์šฐ ์ž๋ฐ” ๋นˆ ๊ทœ์•ฝ์— ๋”ฐ๋ฅด๋ฉด getter ๋ฉ”์†Œ๋“œ๊ฐ€ isXXX() ํ˜•ํƒœ๋กœ ์ƒ์„ฑ๋˜์–ด์•ผ ํ•ฉ๋‹ˆ๋‹ค. - ๊ทธ๋ž˜์„œ getter ๋ฉ”์†Œ๋“œ ์ž๋™์ƒ์„ฑ(๋กฌ๋ณต, ์ธํ…”๋ฆฌ์ œ์ด ํ™œ์šฉ)ํ•˜๋Š” ๊ฒฝ์šฐ์— ๊ฐ์ฒด ํ”„๋กœํผํ„ฐ์˜ ๋„ค์ด๋ฐ์—์„œ ๋ฌธ์ œ(isXXX ์ด ์•„๋‹Œ XXX ํ˜•ํƒœ๋กœ ๋„ค์ด๋ฐ์ด ๋˜๋Š” ๋ฌธ์ œ)๊ฐ€ ๋ฐœ์ƒํ•˜๊ฒŒ ๋ฉ๋‹ˆ๋‹ค. - ํ•ด๊ฒฐ ๋ฐฉ์•ˆ์œผ๋กœ ๋ช‡ ๊ฐ€์ง€๊ฐ€ ์กด์žฌํ•˜๋Š”๋ฐ( [์ œ ๋ธ”๋กœ๊ทธ์— ๊ฐ„๋‹จํžˆ ์ •๋ฆฌํ•ด๋’€์–ด์š”.](https://ichmww2.tistory.com/87)) ์ €๋Š” wrapper ํด๋ž˜์Šค๋กœ ์‚ฌ์šฉํ•˜๋Š” ๊ฒƒ์„ ์„ ํ˜ธํ•ด์„œ...