code stringlengths 41 34.3k | lang stringclasses 8
values | review stringlengths 1 4.74k |
|---|---|---|
@@ -0,0 +1,85 @@
+package com.codesquad.datastructurestudy.list.arraylist;
+
+public class ArrayList implements List<Integer> {
+
+ private int[] numbers;
+ private int numOfData;
+
+ public ArrayList() {
+ this.numbers = new int[100];
+ this.numOfData = 0;
+ }
+
+ public ArrayList(int[] numbers, int numOfData) {
+ this.numbers = numbers;
+ this.numOfData = numOfData;
+ }
+
+ public void add(int index, Integer element) {
+ if (numOfData > this.numbers.length) {
+ System.out.println("배열이 가득 찼습니다");
+// throw new ArrayIndexOutOfBoundsException();
+ }
+ this.numbers[index] = element;
+ numOfData++;
+ }
+
+ public void add(Integer element) {
+ if (numOfData > this.numbers.length) {
+ System.out.println("배열이 가득 찼습니다");
+ }
+ this.numbers[numOfData] = element;
+ numOfData++;
+ }
+
+ public int count() {
+ return this.numOfData;
+ }
+
+ public Integer get(int index) {
+ return this.numbers[index];
+ }
+
+ public Integer remove(int index) {
+ Integer data = this.numbers[index];
+
+ for (int i = index; i < this.numOfData - 1; i++) {
+ this.numbers[i] = this.numbers[i+1];
+ }
+
+ this.numOfData--;
+ return data;
+ }
+
+ public int size() {
+ return this.numbers.length;
+ }
+
+ public static void main(String[] args) {
+ List<Integer> list = new ArrayList();
+
+ // 데이터 삽입
+ list.add(1);
+ list.add(2);
+ list.add(3);
+ list.add(4);
+
+ // 저장된 데이터 출력
+ System.out.println("현재 데이터의 수: " + list.count());
+
+ for (int i = 0; i < list.count(); i++) {
+ System.out.println(list.get(i));
+ }
+
+ list.remove(2);
+ list.remove(3);
+
+ System.out.println("삭제 후 데이터의 수: " + list.count());
+
+ for (int i = 0; i < list.count(); i++) {
+ System.out.println(list.get(i));
+ }
+
+ System.out.println("삭제 후 배열 크기: " + list.size());
+ }
+} | Java | 특이하네요 ㅋㅋㅋ 제네릭을 이렇게 구현하신 이유가 있을까요? |
@@ -0,0 +1,85 @@
+package com.codesquad.datastructurestudy.list.arraylist;
+
+public class ArrayList implements List<Integer> {
+
+ private int[] numbers;
+ private int numOfData;
+
+ public ArrayList() {
+ this.numbers = new int[100];
+ this.numOfData = 0;
+ }
+
+ public ArrayList(int[] numbers, int numOfData) {
+ this.numbers = numbers;
+ this.numOfData = numOfData;
+ }
+
+ public void add(int index, Integer element) {
+ if (numOfData > this.numbers.length) {
+ System.out.println("배열이 가득 찼습니다");
+// throw new ArrayIndexOutOfBoundsException();
+ }
+ this.numbers[index] = element;
+ numOfData++;
+ }
+
+ public void add(Integer element) {
+ if (numOfData > this.numbers.length) {
+ System.out.println("배열이 가득 찼습니다");
+ }
+ this.numbers[numOfData] = element;
+ numOfData++;
+ }
+
+ public int count() {
+ return this.numOfData;
+ }
+
+ public Integer get(int index) {
+ return this.numbers[index];
+ }
+
+ public Integer remove(int index) {
+ Integer data = this.numbers[index];
+
+ for (int i = index; i < this.numOfData - 1; i++) {
+ this.numbers[i] = this.numbers[i+1];
+ }
+
+ this.numOfData--;
+ return data;
+ }
+
+ public int size() {
+ return this.numbers.length;
+ }
+
+ public static void main(String[] args) {
+ List<Integer> list = new ArrayList();
+
+ // 데이터 삽입
+ list.add(1);
+ list.add(2);
+ list.add(3);
+ list.add(4);
+
+ // 저장된 데이터 출력
+ System.out.println("현재 데이터의 수: " + list.count());
+
+ for (int i = 0; i < list.count(); i++) {
+ System.out.println(list.get(i));
+ }
+
+ list.remove(2);
+ list.remove(3);
+
+ System.out.println("삭제 후 데이터의 수: " + list.count());
+
+ for (int i = 0; i < list.count(); i++) {
+ System.out.println(list.get(i));
+ }
+
+ System.out.println("삭제 후 배열 크기: " + list.size());
+ }
+} | Java | 음 가급적이면 숫자 상수도 private static final로 빼서 사용하는 편이 좋지 않을까 싶어요.
그리고 numOfData는 그냥 제거해도 0으로 초기화 되니 그 점을 염두에 두시는게 좋을 것 같네요. |
@@ -0,0 +1,85 @@
+package com.codesquad.datastructurestudy.list.arraylist;
+
+public class ArrayList implements List<Integer> {
+
+ private int[] numbers;
+ private int numOfData;
+
+ public ArrayList() {
+ this.numbers = new int[100];
+ this.numOfData = 0;
+ }
+
+ public ArrayList(int[] numbers, int numOfData) {
+ this.numbers = numbers;
+ this.numOfData = numOfData;
+ }
+
+ public void add(int index, Integer element) {
+ if (numOfData > this.numbers.length) {
+ System.out.println("배열이 가득 찼습니다");
+// throw new ArrayIndexOutOfBoundsException();
+ }
+ this.numbers[index] = element;
+ numOfData++;
+ }
+
+ public void add(Integer element) {
+ if (numOfData > this.numbers.length) {
+ System.out.println("배열이 가득 찼습니다");
+ }
+ this.numbers[numOfData] = element;
+ numOfData++;
+ }
+
+ public int count() {
+ return this.numOfData;
+ }
+
+ public Integer get(int index) {
+ return this.numbers[index];
+ }
+
+ public Integer remove(int index) {
+ Integer data = this.numbers[index];
+
+ for (int i = index; i < this.numOfData - 1; i++) {
+ this.numbers[i] = this.numbers[i+1];
+ }
+
+ this.numOfData--;
+ return data;
+ }
+
+ public int size() {
+ return this.numbers.length;
+ }
+
+ public static void main(String[] args) {
+ List<Integer> list = new ArrayList();
+
+ // 데이터 삽입
+ list.add(1);
+ list.add(2);
+ list.add(3);
+ list.add(4);
+
+ // 저장된 데이터 출력
+ System.out.println("현재 데이터의 수: " + list.count());
+
+ for (int i = 0; i < list.count(); i++) {
+ System.out.println(list.get(i));
+ }
+
+ list.remove(2);
+ list.remove(3);
+
+ System.out.println("삭제 후 데이터의 수: " + list.count());
+
+ for (int i = 0; i < list.count(); i++) {
+ System.out.println(list.get(i));
+ }
+
+ System.out.println("삭제 후 배열 크기: " + list.size());
+ }
+} | Java | 추가로...
저라면 생성자를
```java
public ArrayList(int initialSize) {
this.numbers = new int[initialSize];
}
```
이런 식으로 만들고 생성자 오버로딩을 통해서
```java
public ArrayList() {
this(INITIAL_SIZE);
}
```
와 같은 식으로 구현해봤을 것 같네요. |
@@ -0,0 +1,85 @@
+package com.codesquad.datastructurestudy.list.arraylist;
+
+public class ArrayList implements List<Integer> {
+
+ private int[] numbers;
+ private int numOfData;
+
+ public ArrayList() {
+ this.numbers = new int[100];
+ this.numOfData = 0;
+ }
+
+ public ArrayList(int[] numbers, int numOfData) {
+ this.numbers = numbers;
+ this.numOfData = numOfData;
+ }
+
+ public void add(int index, Integer element) {
+ if (numOfData > this.numbers.length) {
+ System.out.println("배열이 가득 찼습니다");
+// throw new ArrayIndexOutOfBoundsException();
+ }
+ this.numbers[index] = element;
+ numOfData++;
+ }
+
+ public void add(Integer element) {
+ if (numOfData > this.numbers.length) {
+ System.out.println("배열이 가득 찼습니다");
+ }
+ this.numbers[numOfData] = element;
+ numOfData++;
+ }
+
+ public int count() {
+ return this.numOfData;
+ }
+
+ public Integer get(int index) {
+ return this.numbers[index];
+ }
+
+ public Integer remove(int index) {
+ Integer data = this.numbers[index];
+
+ for (int i = index; i < this.numOfData - 1; i++) {
+ this.numbers[i] = this.numbers[i+1];
+ }
+
+ this.numOfData--;
+ return data;
+ }
+
+ public int size() {
+ return this.numbers.length;
+ }
+
+ public static void main(String[] args) {
+ List<Integer> list = new ArrayList();
+
+ // 데이터 삽입
+ list.add(1);
+ list.add(2);
+ list.add(3);
+ list.add(4);
+
+ // 저장된 데이터 출력
+ System.out.println("현재 데이터의 수: " + list.count());
+
+ for (int i = 0; i < list.count(); i++) {
+ System.out.println(list.get(i));
+ }
+
+ list.remove(2);
+ list.remove(3);
+
+ System.out.println("삭제 후 데이터의 수: " + list.count());
+
+ for (int i = 0; i < list.count(); i++) {
+ System.out.println(list.get(i));
+ }
+
+ System.out.println("삭제 후 배열 크기: " + list.size());
+ }
+} | Java | 살짝 애매한 생성자 같아요.
이 생성자가 과연 필요할까? 라는 생각도 들고요. |
@@ -0,0 +1,85 @@
+package com.codesquad.datastructurestudy.list.arraylist;
+
+public class ArrayList implements List<Integer> {
+
+ private int[] numbers;
+ private int numOfData;
+
+ public ArrayList() {
+ this.numbers = new int[100];
+ this.numOfData = 0;
+ }
+
+ public ArrayList(int[] numbers, int numOfData) {
+ this.numbers = numbers;
+ this.numOfData = numOfData;
+ }
+
+ public void add(int index, Integer element) {
+ if (numOfData > this.numbers.length) {
+ System.out.println("배열이 가득 찼습니다");
+// throw new ArrayIndexOutOfBoundsException();
+ }
+ this.numbers[index] = element;
+ numOfData++;
+ }
+
+ public void add(Integer element) {
+ if (numOfData > this.numbers.length) {
+ System.out.println("배열이 가득 찼습니다");
+ }
+ this.numbers[numOfData] = element;
+ numOfData++;
+ }
+
+ public int count() {
+ return this.numOfData;
+ }
+
+ public Integer get(int index) {
+ return this.numbers[index];
+ }
+
+ public Integer remove(int index) {
+ Integer data = this.numbers[index];
+
+ for (int i = index; i < this.numOfData - 1; i++) {
+ this.numbers[i] = this.numbers[i+1];
+ }
+
+ this.numOfData--;
+ return data;
+ }
+
+ public int size() {
+ return this.numbers.length;
+ }
+
+ public static void main(String[] args) {
+ List<Integer> list = new ArrayList();
+
+ // 데이터 삽입
+ list.add(1);
+ list.add(2);
+ list.add(3);
+ list.add(4);
+
+ // 저장된 데이터 출력
+ System.out.println("현재 데이터의 수: " + list.count());
+
+ for (int i = 0; i < list.count(); i++) {
+ System.out.println(list.get(i));
+ }
+
+ list.remove(2);
+ list.remove(3);
+
+ System.out.println("삭제 후 데이터의 수: " + list.count());
+
+ for (int i = 0; i < list.count(); i++) {
+ System.out.println(list.get(i));
+ }
+
+ System.out.println("삭제 후 배열 크기: " + list.size());
+ }
+} | Java | 안쓰는 주석은 제거해주세요~ |
@@ -0,0 +1,85 @@
+package com.codesquad.datastructurestudy.list.arraylist;
+
+public class ArrayList implements List<Integer> {
+
+ private int[] numbers;
+ private int numOfData;
+
+ public ArrayList() {
+ this.numbers = new int[100];
+ this.numOfData = 0;
+ }
+
+ public ArrayList(int[] numbers, int numOfData) {
+ this.numbers = numbers;
+ this.numOfData = numOfData;
+ }
+
+ public void add(int index, Integer element) {
+ if (numOfData > this.numbers.length) {
+ System.out.println("배열이 가득 찼습니다");
+// throw new ArrayIndexOutOfBoundsException();
+ }
+ this.numbers[index] = element;
+ numOfData++;
+ }
+
+ public void add(Integer element) {
+ if (numOfData > this.numbers.length) {
+ System.out.println("배열이 가득 찼습니다");
+ }
+ this.numbers[numOfData] = element;
+ numOfData++;
+ }
+
+ public int count() {
+ return this.numOfData;
+ }
+
+ public Integer get(int index) {
+ return this.numbers[index];
+ }
+
+ public Integer remove(int index) {
+ Integer data = this.numbers[index];
+
+ for (int i = index; i < this.numOfData - 1; i++) {
+ this.numbers[i] = this.numbers[i+1];
+ }
+
+ this.numOfData--;
+ return data;
+ }
+
+ public int size() {
+ return this.numbers.length;
+ }
+
+ public static void main(String[] args) {
+ List<Integer> list = new ArrayList();
+
+ // 데이터 삽입
+ list.add(1);
+ list.add(2);
+ list.add(3);
+ list.add(4);
+
+ // 저장된 데이터 출력
+ System.out.println("현재 데이터의 수: " + list.count());
+
+ for (int i = 0; i < list.count(); i++) {
+ System.out.println(list.get(i));
+ }
+
+ list.remove(2);
+ list.remove(3);
+
+ System.out.println("삭제 후 데이터의 수: " + list.count());
+
+ for (int i = 0; i < list.count(); i++) {
+ System.out.println(list.get(i));
+ }
+
+ System.out.println("삭제 후 배열 크기: " + list.size());
+ }
+} | Java | 이 메서드 확실한가요?
행동하는 것은 replace에 가까운데, 하는 동작에 군더더기가 많이 들어간 느낌입니다.
특히 개수 체크하는 로직은 없어도 될 것 같고, 마찬가지로 `numOfData++;` 도 불필요해보입니다.
그리고 `IndexOutOfBoundException`도 발생가능한 코드입니다.
1. add인데, 만약 0번 위치에 계속 데이터를 집어넣으면? 나중엔 배열이 가득 찼다고 하면서 데이터는 바뀌고, `numOfData`도 계속 증가할겁니다. if문이 종료되고 아래 라인들이 실행될 필요가 없다면 `return`문을 사용해주세요.
2. `numOfData`라는 멤버변수에 `this` 키워드를 추가해주세요. 헷갈릴 수 있습니다.
3. 23번 라인에 `IndexOutOfBoundException`이 발생가능한 코드가 그대로 있습니다. 예외 처리를 추가해주시던지, if 문으로 조건을 달아주세요. (인덱스의 범위를 생각해봅시다.)
4. 23번 라인에 element가 unboxing될 때, 어떻게 될지도 생각해봅시다. `null`이 그대로 들어가게 된다면? 어떤 결과가 벌어질까요? |
@@ -0,0 +1,85 @@
+package com.codesquad.datastructurestudy.list.arraylist;
+
+public class ArrayList implements List<Integer> {
+
+ private int[] numbers;
+ private int numOfData;
+
+ public ArrayList() {
+ this.numbers = new int[100];
+ this.numOfData = 0;
+ }
+
+ public ArrayList(int[] numbers, int numOfData) {
+ this.numbers = numbers;
+ this.numOfData = numOfData;
+ }
+
+ public void add(int index, Integer element) {
+ if (numOfData > this.numbers.length) {
+ System.out.println("배열이 가득 찼습니다");
+// throw new ArrayIndexOutOfBoundsException();
+ }
+ this.numbers[index] = element;
+ numOfData++;
+ }
+
+ public void add(Integer element) {
+ if (numOfData > this.numbers.length) {
+ System.out.println("배열이 가득 찼습니다");
+ }
+ this.numbers[numOfData] = element;
+ numOfData++;
+ }
+
+ public int count() {
+ return this.numOfData;
+ }
+
+ public Integer get(int index) {
+ return this.numbers[index];
+ }
+
+ public Integer remove(int index) {
+ Integer data = this.numbers[index];
+
+ for (int i = index; i < this.numOfData - 1; i++) {
+ this.numbers[i] = this.numbers[i+1];
+ }
+
+ this.numOfData--;
+ return data;
+ }
+
+ public int size() {
+ return this.numbers.length;
+ }
+
+ public static void main(String[] args) {
+ List<Integer> list = new ArrayList();
+
+ // 데이터 삽입
+ list.add(1);
+ list.add(2);
+ list.add(3);
+ list.add(4);
+
+ // 저장된 데이터 출력
+ System.out.println("현재 데이터의 수: " + list.count());
+
+ for (int i = 0; i < list.count(); i++) {
+ System.out.println(list.get(i));
+ }
+
+ list.remove(2);
+ list.remove(3);
+
+ System.out.println("삭제 후 데이터의 수: " + list.count());
+
+ for (int i = 0; i < list.count(); i++) {
+ System.out.println(list.get(i));
+ }
+
+ System.out.println("삭제 후 배열 크기: " + list.size());
+ }
+} | Java | 여기도 마찬가지입니다. 위의 코멘트를 참고해서 정확한 로직으로 변경해주세요. |
@@ -0,0 +1,85 @@
+package com.codesquad.datastructurestudy.list.arraylist;
+
+public class ArrayList implements List<Integer> {
+
+ private int[] numbers;
+ private int numOfData;
+
+ public ArrayList() {
+ this.numbers = new int[100];
+ this.numOfData = 0;
+ }
+
+ public ArrayList(int[] numbers, int numOfData) {
+ this.numbers = numbers;
+ this.numOfData = numOfData;
+ }
+
+ public void add(int index, Integer element) {
+ if (numOfData > this.numbers.length) {
+ System.out.println("배열이 가득 찼습니다");
+// throw new ArrayIndexOutOfBoundsException();
+ }
+ this.numbers[index] = element;
+ numOfData++;
+ }
+
+ public void add(Integer element) {
+ if (numOfData > this.numbers.length) {
+ System.out.println("배열이 가득 찼습니다");
+ }
+ this.numbers[numOfData] = element;
+ numOfData++;
+ }
+
+ public int count() {
+ return this.numOfData;
+ }
+
+ public Integer get(int index) {
+ return this.numbers[index];
+ }
+
+ public Integer remove(int index) {
+ Integer data = this.numbers[index];
+
+ for (int i = index; i < this.numOfData - 1; i++) {
+ this.numbers[i] = this.numbers[i+1];
+ }
+
+ this.numOfData--;
+ return data;
+ }
+
+ public int size() {
+ return this.numbers.length;
+ }
+
+ public static void main(String[] args) {
+ List<Integer> list = new ArrayList();
+
+ // 데이터 삽입
+ list.add(1);
+ list.add(2);
+ list.add(3);
+ list.add(4);
+
+ // 저장된 데이터 출력
+ System.out.println("현재 데이터의 수: " + list.count());
+
+ for (int i = 0; i < list.count(); i++) {
+ System.out.println(list.get(i));
+ }
+
+ list.remove(2);
+ list.remove(3);
+
+ System.out.println("삭제 후 데이터의 수: " + list.count());
+
+ for (int i = 0; i < list.count(); i++) {
+ System.out.println(list.get(i));
+ }
+
+ System.out.println("삭제 후 배열 크기: " + list.size());
+ }
+} | Java | 메서드명은 관례상 `size()`가 좀 더 적합해보입니다. |
@@ -0,0 +1,85 @@
+package com.codesquad.datastructurestudy.list.arraylist;
+
+public class ArrayList implements List<Integer> {
+
+ private int[] numbers;
+ private int numOfData;
+
+ public ArrayList() {
+ this.numbers = new int[100];
+ this.numOfData = 0;
+ }
+
+ public ArrayList(int[] numbers, int numOfData) {
+ this.numbers = numbers;
+ this.numOfData = numOfData;
+ }
+
+ public void add(int index, Integer element) {
+ if (numOfData > this.numbers.length) {
+ System.out.println("배열이 가득 찼습니다");
+// throw new ArrayIndexOutOfBoundsException();
+ }
+ this.numbers[index] = element;
+ numOfData++;
+ }
+
+ public void add(Integer element) {
+ if (numOfData > this.numbers.length) {
+ System.out.println("배열이 가득 찼습니다");
+ }
+ this.numbers[numOfData] = element;
+ numOfData++;
+ }
+
+ public int count() {
+ return this.numOfData;
+ }
+
+ public Integer get(int index) {
+ return this.numbers[index];
+ }
+
+ public Integer remove(int index) {
+ Integer data = this.numbers[index];
+
+ for (int i = index; i < this.numOfData - 1; i++) {
+ this.numbers[i] = this.numbers[i+1];
+ }
+
+ this.numOfData--;
+ return data;
+ }
+
+ public int size() {
+ return this.numbers.length;
+ }
+
+ public static void main(String[] args) {
+ List<Integer> list = new ArrayList();
+
+ // 데이터 삽입
+ list.add(1);
+ list.add(2);
+ list.add(3);
+ list.add(4);
+
+ // 저장된 데이터 출력
+ System.out.println("현재 데이터의 수: " + list.count());
+
+ for (int i = 0; i < list.count(); i++) {
+ System.out.println(list.get(i));
+ }
+
+ list.remove(2);
+ list.remove(3);
+
+ System.out.println("삭제 후 데이터의 수: " + list.count());
+
+ for (int i = 0; i < list.count(); i++) {
+ System.out.println(list.get(i));
+ }
+
+ System.out.println("삭제 후 배열 크기: " + list.size());
+ }
+} | Java | `wrapper type`으로 반환하게 되면 `auto boxing`이 일어나기 때문에
여기선 불필요하다고 보입니다.
`Integer`와 `int` 타입은 많은 차이가 있습니다.
특히 메모리 공간, Nullable 등의 차이가 있겠네요. |
@@ -0,0 +1,85 @@
+package com.codesquad.datastructurestudy.list.arraylist;
+
+public class ArrayList implements List<Integer> {
+
+ private int[] numbers;
+ private int numOfData;
+
+ public ArrayList() {
+ this.numbers = new int[100];
+ this.numOfData = 0;
+ }
+
+ public ArrayList(int[] numbers, int numOfData) {
+ this.numbers = numbers;
+ this.numOfData = numOfData;
+ }
+
+ public void add(int index, Integer element) {
+ if (numOfData > this.numbers.length) {
+ System.out.println("배열이 가득 찼습니다");
+// throw new ArrayIndexOutOfBoundsException();
+ }
+ this.numbers[index] = element;
+ numOfData++;
+ }
+
+ public void add(Integer element) {
+ if (numOfData > this.numbers.length) {
+ System.out.println("배열이 가득 찼습니다");
+ }
+ this.numbers[numOfData] = element;
+ numOfData++;
+ }
+
+ public int count() {
+ return this.numOfData;
+ }
+
+ public Integer get(int index) {
+ return this.numbers[index];
+ }
+
+ public Integer remove(int index) {
+ Integer data = this.numbers[index];
+
+ for (int i = index; i < this.numOfData - 1; i++) {
+ this.numbers[i] = this.numbers[i+1];
+ }
+
+ this.numOfData--;
+ return data;
+ }
+
+ public int size() {
+ return this.numbers.length;
+ }
+
+ public static void main(String[] args) {
+ List<Integer> list = new ArrayList();
+
+ // 데이터 삽입
+ list.add(1);
+ list.add(2);
+ list.add(3);
+ list.add(4);
+
+ // 저장된 데이터 출력
+ System.out.println("현재 데이터의 수: " + list.count());
+
+ for (int i = 0; i < list.count(); i++) {
+ System.out.println(list.get(i));
+ }
+
+ list.remove(2);
+ list.remove(3);
+
+ System.out.println("삭제 후 데이터의 수: " + list.count());
+
+ for (int i = 0; i < list.count(); i++) {
+ System.out.println(list.get(i));
+ }
+
+ System.out.println("삭제 후 배열 크기: " + list.size());
+ }
+} | Java | 데이터가 없다면 0을 주겠네요?
뭔가 이상하지 않을까요 ㅎㅎ |
@@ -0,0 +1,85 @@
+package com.codesquad.datastructurestudy.list.arraylist;
+
+public class ArrayList implements List<Integer> {
+
+ private int[] numbers;
+ private int numOfData;
+
+ public ArrayList() {
+ this.numbers = new int[100];
+ this.numOfData = 0;
+ }
+
+ public ArrayList(int[] numbers, int numOfData) {
+ this.numbers = numbers;
+ this.numOfData = numOfData;
+ }
+
+ public void add(int index, Integer element) {
+ if (numOfData > this.numbers.length) {
+ System.out.println("배열이 가득 찼습니다");
+// throw new ArrayIndexOutOfBoundsException();
+ }
+ this.numbers[index] = element;
+ numOfData++;
+ }
+
+ public void add(Integer element) {
+ if (numOfData > this.numbers.length) {
+ System.out.println("배열이 가득 찼습니다");
+ }
+ this.numbers[numOfData] = element;
+ numOfData++;
+ }
+
+ public int count() {
+ return this.numOfData;
+ }
+
+ public Integer get(int index) {
+ return this.numbers[index];
+ }
+
+ public Integer remove(int index) {
+ Integer data = this.numbers[index];
+
+ for (int i = index; i < this.numOfData - 1; i++) {
+ this.numbers[i] = this.numbers[i+1];
+ }
+
+ this.numOfData--;
+ return data;
+ }
+
+ public int size() {
+ return this.numbers.length;
+ }
+
+ public static void main(String[] args) {
+ List<Integer> list = new ArrayList();
+
+ // 데이터 삽입
+ list.add(1);
+ list.add(2);
+ list.add(3);
+ list.add(4);
+
+ // 저장된 데이터 출력
+ System.out.println("현재 데이터의 수: " + list.count());
+
+ for (int i = 0; i < list.count(); i++) {
+ System.out.println(list.get(i));
+ }
+
+ list.remove(2);
+ list.remove(3);
+
+ System.out.println("삭제 후 데이터의 수: " + list.count());
+
+ for (int i = 0; i < list.count(); i++) {
+ System.out.println(list.get(i));
+ }
+
+ System.out.println("삭제 후 배열 크기: " + list.size());
+ }
+} | Java | 응? 이거 어떻게보면 맞는 것 같기도 하고 아닌 것 같기도 합니다.
java의 size는 어떻게 동작하나요? |
@@ -0,0 +1,27 @@
+package com.codesquad.datastructurestudy.list.arraylist;
+
+public interface List<T> {
+
+ void add(T element);
+ void add(int index, T element);
+
+ int count();
+
+ T get(int index);
+
+ T remove(int index);
+
+ int size();
+
+// int indexOf(T o);
+// int lastIndexOf(T o);
+
+// ListIterator listIterator();
+// ListIterator listIterator(int index);
+
+// T set(int index, T element);
+
+// void sort(Comparator c);
+
+// List subList(int fromIndex, int toIndex);
+} | Java | ㅋㅋㅋ 나중에 구현할 사항들인가요? |
@@ -0,0 +1,35 @@
+package com.codesquad.datastructurestudy.list.arraylist;
+
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.LinkedList;
+import java.util.List;
+
+public class ListMain {
+
+ public static void main(String[] args) {
+ List<Integer> list = new ArrayList<>();
+ for (int i = 0; i < 9; i++) {
+ list.add(i,i+1);
+ }
+
+ int sum = 0;
+ for (int i = 0; i < list.size(); i++) {
+ sum += list.get(i);
+ }
+ System.out.println("리스트의 합계는 : " + sum);
+
+ List list1 = new ArrayList();
+
+ for (int i = 0; i < list.size(); i++) {
+ if (!(list.get(i) % 3 == 0 || list.get(i) % 2 == 0)) {
+ list1.add(list.get(i));
+ }
+ }
+
+ Iterator<Integer> iterator = list1.iterator();
+ while (iterator.hasNext()) {
+ System.out.println(iterator.next());
+ }
+ }
+} | Java | 전반적으로 java coding convention이 잘 지켜지지 않는 모습이네요. |
@@ -0,0 +1,35 @@
+package com.codesquad.datastructurestudy.list.arraylist;
+
+import java.util.ArrayList;
+import java.util.Iterator;
+import java.util.LinkedList;
+import java.util.List;
+
+public class ListMain {
+
+ public static void main(String[] args) {
+ List<Integer> list = new ArrayList<>();
+ for (int i = 0; i < 9; i++) {
+ list.add(i,i+1);
+ }
+
+ int sum = 0;
+ for (int i = 0; i < list.size(); i++) {
+ sum += list.get(i);
+ }
+ System.out.println("리스트의 합계는 : " + sum);
+
+ List list1 = new ArrayList();
+
+ for (int i = 0; i < list.size(); i++) {
+ if (!(list.get(i) % 3 == 0 || list.get(i) % 2 == 0)) {
+ list1.add(list.get(i));
+ }
+ }
+
+ Iterator<Integer> iterator = list1.iterator();
+ while (iterator.hasNext()) {
+ System.out.println(iterator.next());
+ }
+ }
+} | Java | enhanced for loop를 사용해도 됩니다. |
@@ -0,0 +1,50 @@
+package com.codesquad.datastructurestudy.list.arraylist;
+
+public class NameCard {
+
+ private String[] name;
+ private String[] phone;
+
+ // NameCard 구조체 변수의 동적 할당 및 초기화 후 주소 값 반환
+ public NameCard(String[] name, String[] phone) {
+ this.name = name;
+ this.phone = phone;
+ }
+
+ public NameCard() {
+ this.name = new String[30];
+ this.phone = new String[30];
+ }
+
+ // NameCard 구조체 변수의 정보 출력
+ public static void showNameCardInfo(NameCard nameCard) {
+ System.out.println("[이름] : " + nameCard.name);
+ System.out.println("[번호] : " + nameCard.phone);
+ }
+
+ // 이름이 같으면 true, 다르면 false 값 반환
+ public static boolean nameCompare(NameCard nameCard, String[] name) {
+ return nameCard.name.equals(name);
+ }
+
+ // 전화번호 정보를 변경
+ public static void changePhoneNum(NameCard nameCard, String[] phone) {
+ nameCard.phone = phone;
+ }
+
+ public static void main(String[] args) {
+ NameCard nameCard = new NameCard();
+ List<Integer> list = new ArrayList();
+
+ // 총 3명의 전화번호 정보를, 앞서 우리가 구현한 리스트에 저장한다.
+ nameCard.name[0] = "이진수";
+ nameCard.name[1] = "한지영";
+ nameCard.name[2] = "조수진";
+ nameCard.phone[0] = "010-1111-2222";
+ nameCard.phone[1] = "010-2222-5555";
+ nameCard.phone[2] = "010-3333-7777";
+
+ }
+
+
+} | Java | 좀 더 객체지향적인 접근을 해보세요 ㅎㅎ |
@@ -0,0 +1,50 @@
+package com.codesquad.datastructurestudy.list.arraylist;
+
+public class NameCard {
+
+ private String[] name;
+ private String[] phone;
+
+ // NameCard 구조체 변수의 동적 할당 및 초기화 후 주소 값 반환
+ public NameCard(String[] name, String[] phone) {
+ this.name = name;
+ this.phone = phone;
+ }
+
+ public NameCard() {
+ this.name = new String[30];
+ this.phone = new String[30];
+ }
+
+ // NameCard 구조체 변수의 정보 출력
+ public static void showNameCardInfo(NameCard nameCard) {
+ System.out.println("[이름] : " + nameCard.name);
+ System.out.println("[번호] : " + nameCard.phone);
+ }
+
+ // 이름이 같으면 true, 다르면 false 값 반환
+ public static boolean nameCompare(NameCard nameCard, String[] name) {
+ return nameCard.name.equals(name);
+ }
+
+ // 전화번호 정보를 변경
+ public static void changePhoneNum(NameCard nameCard, String[] phone) {
+ nameCard.phone = phone;
+ }
+
+ public static void main(String[] args) {
+ NameCard nameCard = new NameCard();
+ List<Integer> list = new ArrayList();
+
+ // 총 3명의 전화번호 정보를, 앞서 우리가 구현한 리스트에 저장한다.
+ nameCard.name[0] = "이진수";
+ nameCard.name[1] = "한지영";
+ nameCard.name[2] = "조수진";
+ nameCard.phone[0] = "010-1111-2222";
+ nameCard.phone[1] = "010-2222-5555";
+ nameCard.phone[2] = "010-3333-7777";
+
+ }
+
+
+} | Java | 요 코드는 다시 작성하는게 좋아보입니다.
전체적으로 자바로 짠 느낌이 하나도 들지 않았어요. |
@@ -0,0 +1,13 @@
+package com.codesquad.datastructurestudy.list.arraylist;
+
+public interface Wallet {
+
+ // 모든 멤버변수는 public static final. 생략 가능
+ int coin100Num = 0;
+ int bill5000Num = 0;
+
+ // 모든 메서드는 public abstract 이어야함. 생략 가능
+ int takeOutMoney(int coin100Num, int bill5000Num);
+ void putMoney(int coin100Num, int bill5000Num);
+
+} | Java | 학습 내용은 좋아보입니다.
근데 보통 interface에서는 멤버변수 선언을 잘 안하는 편이고, 네이밍 컨벤션에 맞게 작성해주시는게 좋을 것 같아요. |
@@ -0,0 +1,164 @@
+package com.codesquad.datastructurestudy.list.linkedlist.yoon;
+
+public class CircularLinkedList {
+
+ private Node tail;
+ private int count;
+ private Node before;
+ private Node cur;
+
+ public void add(int data) {
+ Node newNode = new Node(data);
+
+ if (tail == null) {
+ tail = newNode;
+ newNode.next = newNode;
+ } else {
+ newNode.next = tail.next;
+ tail.next = newNode;
+ tail = newNode;
+ }
+ count++;
+ }
+
+ public void addName(int data, String name) {
+ Node newNode = new Node(data);
+ newNode.name = name;
+
+ if (tail == null) {
+ tail = newNode;
+ newNode.next = newNode;
+ } else {
+ newNode.next = tail.next;
+ tail.next = newNode;
+ tail = newNode;
+ }
+ count++;
+ }
+
+ public void addFront(int data) {
+ Node newNode = new Node(data);
+
+ if (tail == null) {
+ tail = newNode;
+ newNode.next = newNode;
+ } else {
+ newNode.next = tail.next;
+ tail.next = newNode;
+ }
+ count++;
+ }
+
+ public void addNameFront(int data, String name) {
+ Node newNode = new Node(data);
+ newNode.name = name;
+
+ if (tail == null) {
+ tail = newNode;
+ newNode.next = newNode;
+ } else {
+ newNode.next = tail.next;
+ tail.next = newNode;
+ }
+ count++;
+ }
+
+ public boolean first() {
+ if (tail == null) {
+ return false;
+ } else {
+ before = tail;
+ cur = tail.next;
+ return true;
+ }
+ }
+
+ public boolean next(int data) {
+ if (tail == null) {
+ return false;
+ } else {
+ before = cur;
+ cur = cur.next;
+ return true;
+ }
+ }
+
+ public int remove() {
+ Node deleteNode = cur;
+ int data = deleteNode.data;
+
+ if (deleteNode == tail) {
+ if (tail == tail.next) {
+ tail = null;
+ } else {
+ tail = before;
+ }
+ }
+
+ before.next = cur.next;
+ cur = before;
+ count--;
+ return data;
+ }
+
+ public int size() {
+ return this.count;
+ }
+
+ public String identifyWatcher(String name, int afterNum) {
+ Node searchNode = new Node();
+ searchNode.next = tail.next;
+ int count = 0;
+ String watcher = null;
+
+ while (true) {
+ if (searchNode.name == name) {
+ break;
+ } else {
+ searchNode = searchNode.next;
+ count++;
+ }
+ }
+
+ for (int i = 0; i < afterNum + count; i++) {
+ if (i != afterNum + count - 1) {
+ searchNode = searchNode.next;
+ continue;
+ } else {
+ watcher = searchNode.name;
+ }
+ }
+ return watcher;
+ }
+
+ public static void main(String[] args) {
+ CircularLinkedList members = new CircularLinkedList();
+
+ members.addName(1, "김");
+ members.addName(2, "나");
+ members.addName(3, "박");
+ members.addName(4, "이");
+
+ System.out.println("서치 시작");
+
+ System.out.println(members.identifyWatcher("김", 7));
+
+ }
+
+ private class Node {
+
+ private int data;
+ private String name;
+ private Node next;
+
+ public Node() {
+ this.data = 0;
+ this.next = null;
+ }
+
+ public Node(int data) {
+ this.data = data;
+ this.next = null;
+ }
+ }
+} | Java | 생성자에 대해서 좀만 더 공부해보세요. 불필요한 초기화 코드는 제거해주는게 좋습니다. |
@@ -0,0 +1,164 @@
+package com.codesquad.datastructurestudy.list.linkedlist.yoon;
+
+public class CircularLinkedList {
+
+ private Node tail;
+ private int count;
+ private Node before;
+ private Node cur;
+
+ public void add(int data) {
+ Node newNode = new Node(data);
+
+ if (tail == null) {
+ tail = newNode;
+ newNode.next = newNode;
+ } else {
+ newNode.next = tail.next;
+ tail.next = newNode;
+ tail = newNode;
+ }
+ count++;
+ }
+
+ public void addName(int data, String name) {
+ Node newNode = new Node(data);
+ newNode.name = name;
+
+ if (tail == null) {
+ tail = newNode;
+ newNode.next = newNode;
+ } else {
+ newNode.next = tail.next;
+ tail.next = newNode;
+ tail = newNode;
+ }
+ count++;
+ }
+
+ public void addFront(int data) {
+ Node newNode = new Node(data);
+
+ if (tail == null) {
+ tail = newNode;
+ newNode.next = newNode;
+ } else {
+ newNode.next = tail.next;
+ tail.next = newNode;
+ }
+ count++;
+ }
+
+ public void addNameFront(int data, String name) {
+ Node newNode = new Node(data);
+ newNode.name = name;
+
+ if (tail == null) {
+ tail = newNode;
+ newNode.next = newNode;
+ } else {
+ newNode.next = tail.next;
+ tail.next = newNode;
+ }
+ count++;
+ }
+
+ public boolean first() {
+ if (tail == null) {
+ return false;
+ } else {
+ before = tail;
+ cur = tail.next;
+ return true;
+ }
+ }
+
+ public boolean next(int data) {
+ if (tail == null) {
+ return false;
+ } else {
+ before = cur;
+ cur = cur.next;
+ return true;
+ }
+ }
+
+ public int remove() {
+ Node deleteNode = cur;
+ int data = deleteNode.data;
+
+ if (deleteNode == tail) {
+ if (tail == tail.next) {
+ tail = null;
+ } else {
+ tail = before;
+ }
+ }
+
+ before.next = cur.next;
+ cur = before;
+ count--;
+ return data;
+ }
+
+ public int size() {
+ return this.count;
+ }
+
+ public String identifyWatcher(String name, int afterNum) {
+ Node searchNode = new Node();
+ searchNode.next = tail.next;
+ int count = 0;
+ String watcher = null;
+
+ while (true) {
+ if (searchNode.name == name) {
+ break;
+ } else {
+ searchNode = searchNode.next;
+ count++;
+ }
+ }
+
+ for (int i = 0; i < afterNum + count; i++) {
+ if (i != afterNum + count - 1) {
+ searchNode = searchNode.next;
+ continue;
+ } else {
+ watcher = searchNode.name;
+ }
+ }
+ return watcher;
+ }
+
+ public static void main(String[] args) {
+ CircularLinkedList members = new CircularLinkedList();
+
+ members.addName(1, "김");
+ members.addName(2, "나");
+ members.addName(3, "박");
+ members.addName(4, "이");
+
+ System.out.println("서치 시작");
+
+ System.out.println(members.identifyWatcher("김", 7));
+
+ }
+
+ private class Node {
+
+ private int data;
+ private String name;
+ private Node next;
+
+ public Node() {
+ this.data = 0;
+ this.next = null;
+ }
+
+ public Node(int data) {
+ this.data = data;
+ this.next = null;
+ }
+ }
+} | Java | 생성자를 하나 더 추가하는 것도 좋아보입니다.
`Node newNode = new Node(data, name);` |
@@ -0,0 +1,164 @@
+package com.codesquad.datastructurestudy.list.linkedlist.yoon;
+
+public class CircularLinkedList {
+
+ private Node tail;
+ private int count;
+ private Node before;
+ private Node cur;
+
+ public void add(int data) {
+ Node newNode = new Node(data);
+
+ if (tail == null) {
+ tail = newNode;
+ newNode.next = newNode;
+ } else {
+ newNode.next = tail.next;
+ tail.next = newNode;
+ tail = newNode;
+ }
+ count++;
+ }
+
+ public void addName(int data, String name) {
+ Node newNode = new Node(data);
+ newNode.name = name;
+
+ if (tail == null) {
+ tail = newNode;
+ newNode.next = newNode;
+ } else {
+ newNode.next = tail.next;
+ tail.next = newNode;
+ tail = newNode;
+ }
+ count++;
+ }
+
+ public void addFront(int data) {
+ Node newNode = new Node(data);
+
+ if (tail == null) {
+ tail = newNode;
+ newNode.next = newNode;
+ } else {
+ newNode.next = tail.next;
+ tail.next = newNode;
+ }
+ count++;
+ }
+
+ public void addNameFront(int data, String name) {
+ Node newNode = new Node(data);
+ newNode.name = name;
+
+ if (tail == null) {
+ tail = newNode;
+ newNode.next = newNode;
+ } else {
+ newNode.next = tail.next;
+ tail.next = newNode;
+ }
+ count++;
+ }
+
+ public boolean first() {
+ if (tail == null) {
+ return false;
+ } else {
+ before = tail;
+ cur = tail.next;
+ return true;
+ }
+ }
+
+ public boolean next(int data) {
+ if (tail == null) {
+ return false;
+ } else {
+ before = cur;
+ cur = cur.next;
+ return true;
+ }
+ }
+
+ public int remove() {
+ Node deleteNode = cur;
+ int data = deleteNode.data;
+
+ if (deleteNode == tail) {
+ if (tail == tail.next) {
+ tail = null;
+ } else {
+ tail = before;
+ }
+ }
+
+ before.next = cur.next;
+ cur = before;
+ count--;
+ return data;
+ }
+
+ public int size() {
+ return this.count;
+ }
+
+ public String identifyWatcher(String name, int afterNum) {
+ Node searchNode = new Node();
+ searchNode.next = tail.next;
+ int count = 0;
+ String watcher = null;
+
+ while (true) {
+ if (searchNode.name == name) {
+ break;
+ } else {
+ searchNode = searchNode.next;
+ count++;
+ }
+ }
+
+ for (int i = 0; i < afterNum + count; i++) {
+ if (i != afterNum + count - 1) {
+ searchNode = searchNode.next;
+ continue;
+ } else {
+ watcher = searchNode.name;
+ }
+ }
+ return watcher;
+ }
+
+ public static void main(String[] args) {
+ CircularLinkedList members = new CircularLinkedList();
+
+ members.addName(1, "김");
+ members.addName(2, "나");
+ members.addName(3, "박");
+ members.addName(4, "이");
+
+ System.out.println("서치 시작");
+
+ System.out.println(members.identifyWatcher("김", 7));
+
+ }
+
+ private class Node {
+
+ private int data;
+ private String name;
+ private Node next;
+
+ public Node() {
+ this.data = 0;
+ this.next = null;
+ }
+
+ public Node(int data) {
+ this.data = data;
+ this.next = null;
+ }
+ }
+} | Java | 메소드명만 보고 어떤 기능을 하는지 알 수 없네요. |
@@ -0,0 +1,164 @@
+package com.codesquad.datastructurestudy.list.linkedlist.yoon;
+
+public class CircularLinkedList {
+
+ private Node tail;
+ private int count;
+ private Node before;
+ private Node cur;
+
+ public void add(int data) {
+ Node newNode = new Node(data);
+
+ if (tail == null) {
+ tail = newNode;
+ newNode.next = newNode;
+ } else {
+ newNode.next = tail.next;
+ tail.next = newNode;
+ tail = newNode;
+ }
+ count++;
+ }
+
+ public void addName(int data, String name) {
+ Node newNode = new Node(data);
+ newNode.name = name;
+
+ if (tail == null) {
+ tail = newNode;
+ newNode.next = newNode;
+ } else {
+ newNode.next = tail.next;
+ tail.next = newNode;
+ tail = newNode;
+ }
+ count++;
+ }
+
+ public void addFront(int data) {
+ Node newNode = new Node(data);
+
+ if (tail == null) {
+ tail = newNode;
+ newNode.next = newNode;
+ } else {
+ newNode.next = tail.next;
+ tail.next = newNode;
+ }
+ count++;
+ }
+
+ public void addNameFront(int data, String name) {
+ Node newNode = new Node(data);
+ newNode.name = name;
+
+ if (tail == null) {
+ tail = newNode;
+ newNode.next = newNode;
+ } else {
+ newNode.next = tail.next;
+ tail.next = newNode;
+ }
+ count++;
+ }
+
+ public boolean first() {
+ if (tail == null) {
+ return false;
+ } else {
+ before = tail;
+ cur = tail.next;
+ return true;
+ }
+ }
+
+ public boolean next(int data) {
+ if (tail == null) {
+ return false;
+ } else {
+ before = cur;
+ cur = cur.next;
+ return true;
+ }
+ }
+
+ public int remove() {
+ Node deleteNode = cur;
+ int data = deleteNode.data;
+
+ if (deleteNode == tail) {
+ if (tail == tail.next) {
+ tail = null;
+ } else {
+ tail = before;
+ }
+ }
+
+ before.next = cur.next;
+ cur = before;
+ count--;
+ return data;
+ }
+
+ public int size() {
+ return this.count;
+ }
+
+ public String identifyWatcher(String name, int afterNum) {
+ Node searchNode = new Node();
+ searchNode.next = tail.next;
+ int count = 0;
+ String watcher = null;
+
+ while (true) {
+ if (searchNode.name == name) {
+ break;
+ } else {
+ searchNode = searchNode.next;
+ count++;
+ }
+ }
+
+ for (int i = 0; i < afterNum + count; i++) {
+ if (i != afterNum + count - 1) {
+ searchNode = searchNode.next;
+ continue;
+ } else {
+ watcher = searchNode.name;
+ }
+ }
+ return watcher;
+ }
+
+ public static void main(String[] args) {
+ CircularLinkedList members = new CircularLinkedList();
+
+ members.addName(1, "김");
+ members.addName(2, "나");
+ members.addName(3, "박");
+ members.addName(4, "이");
+
+ System.out.println("서치 시작");
+
+ System.out.println(members.identifyWatcher("김", 7));
+
+ }
+
+ private class Node {
+
+ private int data;
+ private String name;
+ private Node next;
+
+ public Node() {
+ this.data = 0;
+ this.next = null;
+ }
+
+ public Node(int data) {
+ this.data = data;
+ this.next = null;
+ }
+ }
+} | Java | `this` 를 가능한한 붙여주세요. |
@@ -6,25 +6,33 @@ import { css } from '@emotion/react';
import Rating from '@/components/Rating';
import Profile from '../Profile';
import { formatDate } from '@/utils/format';
+import useModalStore from '@/stores/useModalStore';
+import useDeleteReview from '@/hooks/query/useDeleteReview';
+import ConfirmModal from '@/components/ConfirmModal';
interface ReviewCardProps {
review: Review;
- onDelete?: () => void;
showTitle: boolean;
showUser: boolean;
showDate: boolean;
showDelete: boolean;
}
-const ReviewCard = ({
- review,
- onDelete,
- showTitle,
- showUser,
- showDate,
- showDelete,
-}: ReviewCardProps) => {
- // console.log(review.imgSrc.map((src, index) => src);
+const ReviewCard = ({ review, showTitle, showUser, showDate, showDelete }: ReviewCardProps) => {
+ const setModalName = useModalStore((state) => state.setModalName);
+ const { mutate } = useDeleteReview();
+
+ const handleDelete = () => {
+ mutate(
+ { reviewId: review.reviewId },
+ {
+ onSuccess: () => {
+ setModalName(null);
+ },
+ },
+ );
+ };
+
return (
<div css={reviewStyle}>
<div className="titleStyle">
@@ -52,7 +60,21 @@ const ReviewCard = ({
<Rating rating={Number(review.rating)} />
</div>
</div>
- {showDelete && <DeleteIcon onDelete={onDelete || (() => {})} />}
+ {showDelete && (
+ <ConfirmModal
+ modalId={`my.review.delete.${review.reviewId}`}
+ onConfirm={handleDelete}
+ trigger={
+ <DeleteIcon onClick={() => setModalName(`my.review.delete.${review.reviewId}`)} />
+ }
+ message={
+ <div css={modalStyle}>
+ <p className="modalText">정말 리뷰를 삭제하시겠습니까?</p>
+ <p className="modalSubText">유저 평점은 삭제되지 않습니다</p>
+ </div>
+ }
+ />
+ )}
</div>
<div
css={css`
@@ -134,15 +156,16 @@ const reviewStyle = css`
.imgContainer {
display: flex;
justify-content: center;
- width: 110px;
- height: 120px;
+ width: 120px;
+ height: 100px;
margin-bottom: 16px;
border-radius: 5px;
overflow: hidden;
}
img {
width: 100%;
+ object-fit: cover;
}
.ratingContainer {
@@ -155,3 +178,17 @@ const reviewStyle = css`
transform: translateY(-3px);
}
`;
+
+const modalStyle = css`
+ display: flex;
+ flex-direction: column;
+ align-items: center;
+ .modalText {
+ font-weight: 600;
+ }
+
+ .modalSubText {
+ font-size: 14px;
+ color: #999;
+ }
+`; | Unknown | _:hammer_and_wrench: Refactor suggestion_
**에러 처리 로직 추가 필요**
`handleDelete` 함수에서 mutation 실패 시의 에러 처리가 누락되어 있습니다.
다음과 같이 `onError` 핸들러를 추가하는 것을 제안합니다:
```diff
const handleDelete = () => {
mutate(
{ reviewId: review.reviewId },
{
onSuccess: () => {
setModalName(null);
},
+ onError: (error) => {
+ console.error('리뷰 삭제 실패:', error);
+ // 에러 메시지를 사용자에게 표시하는 로직 추가
+ },
},
);
};
```
<!-- suggestion_start -->
<details>
<summary>📝 Committable suggestion</summary>
> ‼️ **IMPORTANT**
> Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
`````suggestion
const ReviewCard = ({ review, showTitle, showUser, showDate, showDelete }: ReviewCardProps) => {
const setModalName = useModalStore((state) => state.setModalName);
const { mutate } = useDeleteReview();
const handleDelete = () => {
mutate(
{ reviewId: review.reviewId },
{
onSuccess: () => {
setModalName(null);
},
onError: (error) => {
console.error('리뷰 삭제 실패:', error);
// 에러 메시지를 사용자에게 표시하는 로직 추가
},
},
);
};
`````
</details>
<!-- suggestion_end -->
<!-- This is an auto-generated comment by CodeRabbit --> |
@@ -0,0 +1,41 @@
+import domain.Point
+
+class AroundMineChecker(private val mineBoard: Map<Point, Square>, private val currentPoint: Point) {
+
+ fun isFinish(): Boolean = mineBoard.getValue(currentPoint).isMine()
+
+ fun getBoard(): Map<Point, Square> {
+ val checkLeft = checkLeft(currentPoint, mineBoard)
+ return checkRight(currentPoint, checkLeft)
+ }
+
+ private fun checkLeft(currentPoint: Point, acc: Map<Point, Square> = emptyMap()): Map<Point, Square> {
+ val board = acc.toMutableMap()
+
+ if (!board.containsKey(currentPoint)) return acc
+ if (board.getValue(currentPoint).isMine()) return acc
+
+ val countMine = AroundMine(board, currentPoint).countMine()
+ board.replace(currentPoint, NonMine(countMine))
+
+ val diagonalUpLeft = checkLeft(currentPoint.diagonalUpLeft(), board)
+ val left = checkLeft(currentPoint.left(), diagonalUpLeft)
+ val diagonalBottomLeft = checkLeft(currentPoint.diagonalBottomLeft(), left)
+ return checkLeft(currentPoint.bottom(), diagonalBottomLeft)
+ }
+
+ private fun checkRight(currentPoint: Point, acc: Map<Point, Square> = emptyMap()): Map<Point, Square> {
+ val board = acc.toMutableMap()
+
+ if (!board.containsKey(currentPoint)) return acc
+ if (board.getValue(currentPoint).isMine()) return acc
+
+ val countMine = AroundMine(board, currentPoint).countMine()
+ board.replace(currentPoint, NonMine(countMine))
+ val up = checkRight(currentPoint.up(), board)
+ val diagonalUpRight = checkRight(currentPoint.diagonalUpRight(), up)
+ val diagonalBottomRight = checkRight(currentPoint.diagonalBottomRight(), diagonalUpRight)
+ return checkRight(currentPoint.right(), diagonalBottomRight)
+ }
+
+} | Kotlin | [공식 컨벤션](https://kotlinlang.org/docs/coding-conventions.html#control-flow-statements)에 따르면 if문과 when문은 2줄 이상이면 중괄호를 사용합니다.
다만, 현재 코드는 early return을 하고 있어서 굳이 else 문을 쓸 필요가 없어보입니다. |
@@ -0,0 +1,41 @@
+import domain.Point
+
+class AroundMineChecker(private val mineBoard: Map<Point, Square>, private val currentPoint: Point) {
+
+ fun isFinish(): Boolean = mineBoard.getValue(currentPoint).isMine()
+
+ fun getBoard(): Map<Point, Square> {
+ val checkLeft = checkLeft(currentPoint, mineBoard)
+ return checkRight(currentPoint, checkLeft)
+ }
+
+ private fun checkLeft(currentPoint: Point, acc: Map<Point, Square> = emptyMap()): Map<Point, Square> {
+ val board = acc.toMutableMap()
+
+ if (!board.containsKey(currentPoint)) return acc
+ if (board.getValue(currentPoint).isMine()) return acc
+
+ val countMine = AroundMine(board, currentPoint).countMine()
+ board.replace(currentPoint, NonMine(countMine))
+
+ val diagonalUpLeft = checkLeft(currentPoint.diagonalUpLeft(), board)
+ val left = checkLeft(currentPoint.left(), diagonalUpLeft)
+ val diagonalBottomLeft = checkLeft(currentPoint.diagonalBottomLeft(), left)
+ return checkLeft(currentPoint.bottom(), diagonalBottomLeft)
+ }
+
+ private fun checkRight(currentPoint: Point, acc: Map<Point, Square> = emptyMap()): Map<Point, Square> {
+ val board = acc.toMutableMap()
+
+ if (!board.containsKey(currentPoint)) return acc
+ if (board.getValue(currentPoint).isMine()) return acc
+
+ val countMine = AroundMine(board, currentPoint).countMine()
+ board.replace(currentPoint, NonMine(countMine))
+ val up = checkRight(currentPoint.up(), board)
+ val diagonalUpRight = checkRight(currentPoint.diagonalUpRight(), up)
+ val diagonalBottomRight = checkRight(currentPoint.diagonalBottomRight(), diagonalUpRight)
+ return checkRight(currentPoint.right(), diagonalBottomRight)
+ }
+
+} | Kotlin | 재귀적으로 처리하는 방식이 좋네요. 다만 반환을 하지 않고 내부의 상태를 변경한다는 점이 조금 아쉽습니다.
내부 상태를 변경하는대신 반환하도록 만들고 순수함수로 만들어보면 어떨까요?
아래와 같은 함수 서명으로 만들어보면 좋겠어요.
```kotlin
private fun checkLeft(
currentPoint: Point,
acc: Map<Point, Square> = emptyMap(),
): Map<Point, Square> {
// TODO
}
``` |
@@ -0,0 +1,41 @@
+import domain.Point
+
+class AroundMineChecker(private val mineBoard: Map<Point, Square>, private val currentPoint: Point) {
+
+ fun isFinish(): Boolean = mineBoard.getValue(currentPoint).isMine()
+
+ fun getBoard(): Map<Point, Square> {
+ val checkLeft = checkLeft(currentPoint, mineBoard)
+ return checkRight(currentPoint, checkLeft)
+ }
+
+ private fun checkLeft(currentPoint: Point, acc: Map<Point, Square> = emptyMap()): Map<Point, Square> {
+ val board = acc.toMutableMap()
+
+ if (!board.containsKey(currentPoint)) return acc
+ if (board.getValue(currentPoint).isMine()) return acc
+
+ val countMine = AroundMine(board, currentPoint).countMine()
+ board.replace(currentPoint, NonMine(countMine))
+
+ val diagonalUpLeft = checkLeft(currentPoint.diagonalUpLeft(), board)
+ val left = checkLeft(currentPoint.left(), diagonalUpLeft)
+ val diagonalBottomLeft = checkLeft(currentPoint.diagonalBottomLeft(), left)
+ return checkLeft(currentPoint.bottom(), diagonalBottomLeft)
+ }
+
+ private fun checkRight(currentPoint: Point, acc: Map<Point, Square> = emptyMap()): Map<Point, Square> {
+ val board = acc.toMutableMap()
+
+ if (!board.containsKey(currentPoint)) return acc
+ if (board.getValue(currentPoint).isMine()) return acc
+
+ val countMine = AroundMine(board, currentPoint).countMine()
+ board.replace(currentPoint, NonMine(countMine))
+ val up = checkRight(currentPoint.up(), board)
+ val diagonalUpRight = checkRight(currentPoint.diagonalUpRight(), up)
+ val diagonalBottomRight = checkRight(currentPoint.diagonalBottomRight(), diagonalUpRight)
+ return checkRight(currentPoint.right(), diagonalBottomRight)
+ }
+
+} | Kotlin | 각 방향을 반환하는 함수들 가독성이 좋네요 👍 |
@@ -0,0 +1,41 @@
+import domain.Point
+
+class AroundMineChecker(private val mineBoard: Map<Point, Square>, private val currentPoint: Point) {
+
+ fun isFinish(): Boolean = mineBoard.getValue(currentPoint).isMine()
+
+ fun getBoard(): Map<Point, Square> {
+ val checkLeft = checkLeft(currentPoint, mineBoard)
+ return checkRight(currentPoint, checkLeft)
+ }
+
+ private fun checkLeft(currentPoint: Point, acc: Map<Point, Square> = emptyMap()): Map<Point, Square> {
+ val board = acc.toMutableMap()
+
+ if (!board.containsKey(currentPoint)) return acc
+ if (board.getValue(currentPoint).isMine()) return acc
+
+ val countMine = AroundMine(board, currentPoint).countMine()
+ board.replace(currentPoint, NonMine(countMine))
+
+ val diagonalUpLeft = checkLeft(currentPoint.diagonalUpLeft(), board)
+ val left = checkLeft(currentPoint.left(), diagonalUpLeft)
+ val diagonalBottomLeft = checkLeft(currentPoint.diagonalBottomLeft(), left)
+ return checkLeft(currentPoint.bottom(), diagonalBottomLeft)
+ }
+
+ private fun checkRight(currentPoint: Point, acc: Map<Point, Square> = emptyMap()): Map<Point, Square> {
+ val board = acc.toMutableMap()
+
+ if (!board.containsKey(currentPoint)) return acc
+ if (board.getValue(currentPoint).isMine()) return acc
+
+ val countMine = AroundMine(board, currentPoint).countMine()
+ board.replace(currentPoint, NonMine(countMine))
+ val up = checkRight(currentPoint.up(), board)
+ val diagonalUpRight = checkRight(currentPoint.diagonalUpRight(), up)
+ val diagonalBottomRight = checkRight(currentPoint.diagonalBottomRight(), diagonalUpRight)
+ return checkRight(currentPoint.right(), diagonalBottomRight)
+ }
+
+} | Kotlin | 이 함수들을 Point 클래스로 옮겨보면 어떨까요? |
@@ -0,0 +1,45 @@
+* 기능 요구 사항
+ 1. 주어진 횟수 동안 n 대의 자동차는 전진 또는 멈출 수 있다.
+ 2. 사용자는 몇 대의 자동차로 몇 번의 이동을 할 것인지를 입력할 수 있어야 한다.
+ 3. 전진하는 조건은 0에서 9 사이에서 random 값을 구한 후 random 값이 4 이상일 경우이다.
+ 4. 자동차의 상태를 화면에 출력한다. 어느 시점에 출력할 것인지에 대한 제약은 없다.
+
+* 프로그래밍 요구 사항
+ 1. 모든 로직에 단위 테스트를 구현한다. 단, UI(System.out, System.in) 로직은 제외
+ 2. else 예약어를 쓰지 않는다.
+
+* 기능 목록 및 commit 로그 요구사항
+ git의 commit 단위는 앞 단계에서 README.md 파일에 정리한 기능 목록 단위로 추가한다.
+
+* 기능 목록
+ 1. 사용자로부터 자동차 대수와 이동횟수를 입력받는다.
+ 2. 0에서 9 사이의 랜덤 값을 구한다.
+ 3. 랜덤 값이 4 이상(4 <= n <= 9)일 때 전진한다. 이 외의 값을 입력받으면 움직이지 않는다.
+ 4. 자동차의 상태를 화면에 출력한다.
+
+P.S
+안녕하세요 이동규 리뷰어님
+
+스텝 3 부터 난이도가 많이 올라갔네요..ㅠㅠ
+
+요구사항 대로 맞게 구현했는지 잘 모르겠습니다 ㅠㅠ
+부족한 부분들에 대해 가감없이 팩트 폭격 부탁드릴게요..ㅠㅠ
+
+그리고 한 가지 질문이 있습니다.
+
+테스트 진행 시 각 파라미터마다 산출되는 결과가 다를 때는 어떻게 코드를 짜야하나요?
+예를 들어, 제가 구현한 테스트 소스에서 moving() 메소드의 경우
+
+각각의 파라미터 값 마다 문자열 값이 다르게 나오는데 이를 어떻게 비교하면 되나요?
+
+제가 생각해본건 if 조건문을 걸어서 => if (randomValueForMove == N)
+각 파라미터 마다 나와야 하는 값을 일일이 비교하는 건데 너무 번거로운 것 같아서요..
+
+이 부분에 대해서 코멘트 부탁드릴게요!
+
+감사합니다.
+
+
+
+
+ | Unknown | 파라미터 마다 다른 값이 나오는 경우는 ParameterizedTest를 활용하시면 테스트 가능합니다~ |
@@ -0,0 +1,113 @@
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Random;
+import java.util.Scanner;
+
+public class RacingCar {
+
+ static String move = "-";
+
+ static List<Car> recordMovingCar = new ArrayList<>();
+
+ public static void main(String[] args) {
+
+ InputView userInput = scannerInput();
+
+ int numberOfCarsValue = userInput.getNumberOfCars();
+ int numberOfAttemptsValue = userInput.getNumberOfAttempts();
+
+ System.out.println("======= READY =========");
+ for (int carNumber=0; carNumber < numberOfCarsValue; carNumber++) { System.out.println(move); }
+
+ System.out.println("======= START!! =======");
+ randomMove(numberOfCarsValue, numberOfAttemptsValue);
+
+ }
+
+ public static void randomMove(int numberOfCarsValue, int numberOfAttemptsValue) {
+ Random random = new Random();
+
+ for (int attempt=0; attempt < numberOfAttemptsValue; attempt++) {
+ for (int eachCar = 0; eachCar < numberOfCarsValue; eachCar++) {
+
+ int randomValueForMove = random.nextInt(numberOfAttemptsValue);
+
+ String move = "-";
+ Car car = new Car();
+ car.setMoving(move);
+ recordMovingCar.add(car);
+
+ String beforeMoving = "";
+
+// System.out.println("랜덤 값 : " + randomValueForMove);
+
+ if (randomValueForMove > 9 || randomValueForMove < 4) {
+ beforeMoving = recordMovingCar.get(eachCar).getMoving();
+ String doNotMove = beforeMoving + moving(randomValueForMove);
+ car.setMoving(doNotMove);
+ }
+
+
+ if (randomValueForMove > 0 & randomValueForMove > 3 & randomValueForMove <= 9) {
+ beforeMoving = recordMovingCar.get(eachCar).getMoving();
+ String plusMoving = beforeMoving + moving(randomValueForMove);
+ car.setMoving(plusMoving);
+ }
+
+ recordMovingCar.add(car);
+ recordMovingCar.get(eachCar).setMoving(car.getMoving());
+ System.out.println(recordMovingCar.get(eachCar).getMoving());
+ }
+ System.out.print(System.lineSeparator());
+ }
+ }
+
+ public static String moving(int randomValueForMove) {
+ String move = "-";
+
+ if (randomValueForMove > 9 || randomValueForMove < 4) {
+ move = "";
+ return move;
+ }
+
+ for (int number=0; number < randomValueForMove; number++) { move = move + "-";}
+
+ return move;
+ }
+
+ public static InputView scannerInput() {
+
+ InputView inputView = new InputView();
+ Scanner scanner = new Scanner(System.in);
+
+ System.out.println("자동차 대수는 몇 대인가요?");
+ inputView.setNumberOfCars(scanner.nextInt());
+
+ System.out.println("시도 횟수는 몇 회인가요?");
+ inputView.setNumberOfAttempts(scanner.nextInt());
+
+ return inputView;
+ }
+
+}
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ | Java | 코드를 한줄로 작성하시는 경향이 있으신데요.
개행을 하는 습관을 들이시는게 좋습니다.
당장은 코드 라인 수가 줄어들어 깔끔한 인상을 줄 수 있으나, 휴먼 에러를 발생시킬 수 있어요.
---
기능 요구사항의 실행 결과와 다르군요~
---
code format이 안맞는데요. IntelliJ 단축키는 Ctrl+Alt+L(윈도우), Cmd+Alt+L(맥) 입니다~ |
@@ -0,0 +1,113 @@
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Random;
+import java.util.Scanner;
+
+public class RacingCar {
+
+ static String move = "-";
+
+ static List<Car> recordMovingCar = new ArrayList<>();
+
+ public static void main(String[] args) {
+
+ InputView userInput = scannerInput();
+
+ int numberOfCarsValue = userInput.getNumberOfCars();
+ int numberOfAttemptsValue = userInput.getNumberOfAttempts();
+
+ System.out.println("======= READY =========");
+ for (int carNumber=0; carNumber < numberOfCarsValue; carNumber++) { System.out.println(move); }
+
+ System.out.println("======= START!! =======");
+ randomMove(numberOfCarsValue, numberOfAttemptsValue);
+
+ }
+
+ public static void randomMove(int numberOfCarsValue, int numberOfAttemptsValue) {
+ Random random = new Random();
+
+ for (int attempt=0; attempt < numberOfAttemptsValue; attempt++) {
+ for (int eachCar = 0; eachCar < numberOfCarsValue; eachCar++) {
+
+ int randomValueForMove = random.nextInt(numberOfAttemptsValue);
+
+ String move = "-";
+ Car car = new Car();
+ car.setMoving(move);
+ recordMovingCar.add(car);
+
+ String beforeMoving = "";
+
+// System.out.println("랜덤 값 : " + randomValueForMove);
+
+ if (randomValueForMove > 9 || randomValueForMove < 4) {
+ beforeMoving = recordMovingCar.get(eachCar).getMoving();
+ String doNotMove = beforeMoving + moving(randomValueForMove);
+ car.setMoving(doNotMove);
+ }
+
+
+ if (randomValueForMove > 0 & randomValueForMove > 3 & randomValueForMove <= 9) {
+ beforeMoving = recordMovingCar.get(eachCar).getMoving();
+ String plusMoving = beforeMoving + moving(randomValueForMove);
+ car.setMoving(plusMoving);
+ }
+
+ recordMovingCar.add(car);
+ recordMovingCar.get(eachCar).setMoving(car.getMoving());
+ System.out.println(recordMovingCar.get(eachCar).getMoving());
+ }
+ System.out.print(System.lineSeparator());
+ }
+ }
+
+ public static String moving(int randomValueForMove) {
+ String move = "-";
+
+ if (randomValueForMove > 9 || randomValueForMove < 4) {
+ move = "";
+ return move;
+ }
+
+ for (int number=0; number < randomValueForMove; number++) { move = move + "-";}
+
+ return move;
+ }
+
+ public static InputView scannerInput() {
+
+ InputView inputView = new InputView();
+ Scanner scanner = new Scanner(System.in);
+
+ System.out.println("자동차 대수는 몇 대인가요?");
+ inputView.setNumberOfCars(scanner.nextInt());
+
+ System.out.println("시도 횟수는 몇 회인가요?");
+ inputView.setNumberOfAttempts(scanner.nextInt());
+
+ return inputView;
+ }
+
+}
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ | Java | ```suggestion
int numberOfCars = userInput.getNumberOfCars();
int numberOfAttempts = userInput.getNumberOfAttempts();
```
- 네이밍시에 의미를 가지지 않거나, 중복되는 부분은 최대한 없애보세요 |
@@ -0,0 +1,113 @@
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Random;
+import java.util.Scanner;
+
+public class RacingCar {
+
+ static String move = "-";
+
+ static List<Car> recordMovingCar = new ArrayList<>();
+
+ public static void main(String[] args) {
+
+ InputView userInput = scannerInput();
+
+ int numberOfCarsValue = userInput.getNumberOfCars();
+ int numberOfAttemptsValue = userInput.getNumberOfAttempts();
+
+ System.out.println("======= READY =========");
+ for (int carNumber=0; carNumber < numberOfCarsValue; carNumber++) { System.out.println(move); }
+
+ System.out.println("======= START!! =======");
+ randomMove(numberOfCarsValue, numberOfAttemptsValue);
+
+ }
+
+ public static void randomMove(int numberOfCarsValue, int numberOfAttemptsValue) {
+ Random random = new Random();
+
+ for (int attempt=0; attempt < numberOfAttemptsValue; attempt++) {
+ for (int eachCar = 0; eachCar < numberOfCarsValue; eachCar++) {
+
+ int randomValueForMove = random.nextInt(numberOfAttemptsValue);
+
+ String move = "-";
+ Car car = new Car();
+ car.setMoving(move);
+ recordMovingCar.add(car);
+
+ String beforeMoving = "";
+
+// System.out.println("랜덤 값 : " + randomValueForMove);
+
+ if (randomValueForMove > 9 || randomValueForMove < 4) {
+ beforeMoving = recordMovingCar.get(eachCar).getMoving();
+ String doNotMove = beforeMoving + moving(randomValueForMove);
+ car.setMoving(doNotMove);
+ }
+
+
+ if (randomValueForMove > 0 & randomValueForMove > 3 & randomValueForMove <= 9) {
+ beforeMoving = recordMovingCar.get(eachCar).getMoving();
+ String plusMoving = beforeMoving + moving(randomValueForMove);
+ car.setMoving(plusMoving);
+ }
+
+ recordMovingCar.add(car);
+ recordMovingCar.get(eachCar).setMoving(car.getMoving());
+ System.out.println(recordMovingCar.get(eachCar).getMoving());
+ }
+ System.out.print(System.lineSeparator());
+ }
+ }
+
+ public static String moving(int randomValueForMove) {
+ String move = "-";
+
+ if (randomValueForMove > 9 || randomValueForMove < 4) {
+ move = "";
+ return move;
+ }
+
+ for (int number=0; number < randomValueForMove; number++) { move = move + "-";}
+
+ return move;
+ }
+
+ public static InputView scannerInput() {
+
+ InputView inputView = new InputView();
+ Scanner scanner = new Scanner(System.in);
+
+ System.out.println("자동차 대수는 몇 대인가요?");
+ inputView.setNumberOfCars(scanner.nextInt());
+
+ System.out.println("시도 횟수는 몇 회인가요?");
+ inputView.setNumberOfAttempts(scanner.nextInt());
+
+ return inputView;
+ }
+
+}
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ | Java | RacingCar가 Application을 구동하는 책임을 가지는걸로 보이는데요.
그래서 InputView를 의존하고 있고, main 메소드를 수행하고 있네요.
그런 맥락에서 randomMove 등의 역할도 모두 수행하는 것은 SRP (단일 책임원칙) 위반으로 보입니다.
단일책임원칙은, 각 클래스가 변경될 이유가 하나라는 의미인데요.
현재는 입력, 수행, 출력 등을 제어, 자동차 게임 수행, 입력, 출력 등 모든 로직이 RacingCar class에 존재하네요. |
@@ -0,0 +1,113 @@
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Random;
+import java.util.Scanner;
+
+public class RacingCar {
+
+ static String move = "-";
+
+ static List<Car> recordMovingCar = new ArrayList<>();
+
+ public static void main(String[] args) {
+
+ InputView userInput = scannerInput();
+
+ int numberOfCarsValue = userInput.getNumberOfCars();
+ int numberOfAttemptsValue = userInput.getNumberOfAttempts();
+
+ System.out.println("======= READY =========");
+ for (int carNumber=0; carNumber < numberOfCarsValue; carNumber++) { System.out.println(move); }
+
+ System.out.println("======= START!! =======");
+ randomMove(numberOfCarsValue, numberOfAttemptsValue);
+
+ }
+
+ public static void randomMove(int numberOfCarsValue, int numberOfAttemptsValue) {
+ Random random = new Random();
+
+ for (int attempt=0; attempt < numberOfAttemptsValue; attempt++) {
+ for (int eachCar = 0; eachCar < numberOfCarsValue; eachCar++) {
+
+ int randomValueForMove = random.nextInt(numberOfAttemptsValue);
+
+ String move = "-";
+ Car car = new Car();
+ car.setMoving(move);
+ recordMovingCar.add(car);
+
+ String beforeMoving = "";
+
+// System.out.println("랜덤 값 : " + randomValueForMove);
+
+ if (randomValueForMove > 9 || randomValueForMove < 4) {
+ beforeMoving = recordMovingCar.get(eachCar).getMoving();
+ String doNotMove = beforeMoving + moving(randomValueForMove);
+ car.setMoving(doNotMove);
+ }
+
+
+ if (randomValueForMove > 0 & randomValueForMove > 3 & randomValueForMove <= 9) {
+ beforeMoving = recordMovingCar.get(eachCar).getMoving();
+ String plusMoving = beforeMoving + moving(randomValueForMove);
+ car.setMoving(plusMoving);
+ }
+
+ recordMovingCar.add(car);
+ recordMovingCar.get(eachCar).setMoving(car.getMoving());
+ System.out.println(recordMovingCar.get(eachCar).getMoving());
+ }
+ System.out.print(System.lineSeparator());
+ }
+ }
+
+ public static String moving(int randomValueForMove) {
+ String move = "-";
+
+ if (randomValueForMove > 9 || randomValueForMove < 4) {
+ move = "";
+ return move;
+ }
+
+ for (int number=0; number < randomValueForMove; number++) { move = move + "-";}
+
+ return move;
+ }
+
+ public static InputView scannerInput() {
+
+ InputView inputView = new InputView();
+ Scanner scanner = new Scanner(System.in);
+
+ System.out.println("자동차 대수는 몇 대인가요?");
+ inputView.setNumberOfCars(scanner.nextInt());
+
+ System.out.println("시도 횟수는 몇 회인가요?");
+ inputView.setNumberOfAttempts(scanner.nextInt());
+
+ return inputView;
+ }
+
+}
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ | Java | https://edu.nextstep.camp/s/wLaV8qhA/lt/SuvyWqa2
프로그래밍 요구사항을 미준수하셨네요. 아래 규칙을 준수하며 프로그래밍을 하다보면 객체지향 설계 연습이 되니, 지켜주셔요~
규칙 1: 한 메서드에 오직 한 단계의 들여쓰기만 한다.
규칙 2: else 예약어를 쓰지 않는다.
메소드의 라인 수를 15라인이 넘지 않도록 구현한다.
---
TDD 를 했을 때의 장점이 여럿 있지만, 그 중 하나는 기능 단위로 테스트코드를 작성하고 이를 검증하며 점진적으로 개발을 할 수 있다는 점이에요.
소프트웨어가 좀만 복잡해져도 우리는 한번에 모든 로직을 바로 구현할 수 없어요.
기능 요구사항을 보면, 아래와 같은 요구사항들이 있지요.
- 주어진 횟수 동안 n대의 자동차는 전진 또는 멈출 수 있다.
- 사용자는 몇 대의 자동차로 몇 번의 이동을 할 것인지를 입력할 수 있어야 한다.
- 전진하는 조건은 0에서 9 사이에서 random 값을 구한 후 random 값이 4이상일 경우이다.
그렇다면, 아래와 같이 작은 단위부터 차곡차곡 기능을 구현해갈 수 있어요.
- 자동차가 랜덤 값이 4이상일 경우, 전진한다.
- 자동차가 랜덤 값이 4미만일 경우, 멈춘다.
- 주어진 횟수 동안 n대의 자동차가 게임을 수행한다.
...
위와 같이 프로그래밍을 하게 될 경우, 현재 어떤 값을 가지고 있는지 계속 디버깅해가면서 작성할 수 밖에 없고,
이에 객체지향적인 설계가 아닌 절차지향적인 사고를 하게 됩니다.
지금은 좀 낯설더라도 포비가 가이드하는대로 천천히 미션을 수행해보시길 바래요. |
@@ -0,0 +1,113 @@
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Random;
+import java.util.Scanner;
+
+public class RacingCar {
+
+ static String move = "-";
+
+ static List<Car> recordMovingCar = new ArrayList<>();
+
+ public static void main(String[] args) {
+
+ InputView userInput = scannerInput();
+
+ int numberOfCarsValue = userInput.getNumberOfCars();
+ int numberOfAttemptsValue = userInput.getNumberOfAttempts();
+
+ System.out.println("======= READY =========");
+ for (int carNumber=0; carNumber < numberOfCarsValue; carNumber++) { System.out.println(move); }
+
+ System.out.println("======= START!! =======");
+ randomMove(numberOfCarsValue, numberOfAttemptsValue);
+
+ }
+
+ public static void randomMove(int numberOfCarsValue, int numberOfAttemptsValue) {
+ Random random = new Random();
+
+ for (int attempt=0; attempt < numberOfAttemptsValue; attempt++) {
+ for (int eachCar = 0; eachCar < numberOfCarsValue; eachCar++) {
+
+ int randomValueForMove = random.nextInt(numberOfAttemptsValue);
+
+ String move = "-";
+ Car car = new Car();
+ car.setMoving(move);
+ recordMovingCar.add(car);
+
+ String beforeMoving = "";
+
+// System.out.println("랜덤 값 : " + randomValueForMove);
+
+ if (randomValueForMove > 9 || randomValueForMove < 4) {
+ beforeMoving = recordMovingCar.get(eachCar).getMoving();
+ String doNotMove = beforeMoving + moving(randomValueForMove);
+ car.setMoving(doNotMove);
+ }
+
+
+ if (randomValueForMove > 0 & randomValueForMove > 3 & randomValueForMove <= 9) {
+ beforeMoving = recordMovingCar.get(eachCar).getMoving();
+ String plusMoving = beforeMoving + moving(randomValueForMove);
+ car.setMoving(plusMoving);
+ }
+
+ recordMovingCar.add(car);
+ recordMovingCar.get(eachCar).setMoving(car.getMoving());
+ System.out.println(recordMovingCar.get(eachCar).getMoving());
+ }
+ System.out.print(System.lineSeparator());
+ }
+ }
+
+ public static String moving(int randomValueForMove) {
+ String move = "-";
+
+ if (randomValueForMove > 9 || randomValueForMove < 4) {
+ move = "";
+ return move;
+ }
+
+ for (int number=0; number < randomValueForMove; number++) { move = move + "-";}
+
+ return move;
+ }
+
+ public static InputView scannerInput() {
+
+ InputView inputView = new InputView();
+ Scanner scanner = new Scanner(System.in);
+
+ System.out.println("자동차 대수는 몇 대인가요?");
+ inputView.setNumberOfCars(scanner.nextInt());
+
+ System.out.println("시도 횟수는 몇 회인가요?");
+ inputView.setNumberOfAttempts(scanner.nextInt());
+
+ return inputView;
+ }
+
+}
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ | Java | 값을 하드코딩하기보다는 상수로 관리하는 것이 유지보수하기에 좋다고 생각합니다.
상수(static final)를 만들고 이름을 부여하면 이 변수의 역할이 무엇인지 의도를 드러내기에 좋다고 생각합니다. |
@@ -0,0 +1,19 @@
+public class Car {
+
+ private String moving;
+
+ public Car () {}
+
+ public Car(String moving) {
+ this.moving = moving;
+ }
+
+ public String getMoving() {
+ return moving;
+ }
+
+ public void setMoving(String moving) {
+ this.moving = moving;
+ }
+
+} | Java | 단순히 데이터를 전달하는 dto를 제외하고는 getter, setter를 사용하지 말고 프로그래밍해보세요. (적어도 이번 과정에서만이라도요)
혹여 getter를 사용하지 않고는 못하겠다 하더라도 setter 없이는 프로그래밍 가능합니다. |
@@ -0,0 +1,113 @@
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Random;
+import java.util.Scanner;
+
+public class RacingCar {
+
+ static String move = "-";
+
+ static List<Car> recordMovingCar = new ArrayList<>();
+
+ public static void main(String[] args) {
+
+ InputView userInput = scannerInput();
+
+ int numberOfCarsValue = userInput.getNumberOfCars();
+ int numberOfAttemptsValue = userInput.getNumberOfAttempts();
+
+ System.out.println("======= READY =========");
+ for (int carNumber=0; carNumber < numberOfCarsValue; carNumber++) { System.out.println(move); }
+
+ System.out.println("======= START!! =======");
+ randomMove(numberOfCarsValue, numberOfAttemptsValue);
+
+ }
+
+ public static void randomMove(int numberOfCarsValue, int numberOfAttemptsValue) {
+ Random random = new Random();
+
+ for (int attempt=0; attempt < numberOfAttemptsValue; attempt++) {
+ for (int eachCar = 0; eachCar < numberOfCarsValue; eachCar++) {
+
+ int randomValueForMove = random.nextInt(numberOfAttemptsValue);
+
+ String move = "-";
+ Car car = new Car();
+ car.setMoving(move);
+ recordMovingCar.add(car);
+
+ String beforeMoving = "";
+
+// System.out.println("랜덤 값 : " + randomValueForMove);
+
+ if (randomValueForMove > 9 || randomValueForMove < 4) {
+ beforeMoving = recordMovingCar.get(eachCar).getMoving();
+ String doNotMove = beforeMoving + moving(randomValueForMove);
+ car.setMoving(doNotMove);
+ }
+
+
+ if (randomValueForMove > 0 & randomValueForMove > 3 & randomValueForMove <= 9) {
+ beforeMoving = recordMovingCar.get(eachCar).getMoving();
+ String plusMoving = beforeMoving + moving(randomValueForMove);
+ car.setMoving(plusMoving);
+ }
+
+ recordMovingCar.add(car);
+ recordMovingCar.get(eachCar).setMoving(car.getMoving());
+ System.out.println(recordMovingCar.get(eachCar).getMoving());
+ }
+ System.out.print(System.lineSeparator());
+ }
+ }
+
+ public static String moving(int randomValueForMove) {
+ String move = "-";
+
+ if (randomValueForMove > 9 || randomValueForMove < 4) {
+ move = "";
+ return move;
+ }
+
+ for (int number=0; number < randomValueForMove; number++) { move = move + "-";}
+
+ return move;
+ }
+
+ public static InputView scannerInput() {
+
+ InputView inputView = new InputView();
+ Scanner scanner = new Scanner(System.in);
+
+ System.out.println("자동차 대수는 몇 대인가요?");
+ inputView.setNumberOfCars(scanner.nextInt());
+
+ System.out.println("시도 횟수는 몇 회인가요?");
+ inputView.setNumberOfAttempts(scanner.nextInt());
+
+ return inputView;
+ }
+
+}
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ | Java | static 변수를 공유 가변 필드로 활용하는 것을 지양하세요.
현재는 로컬에서만 사용하니 별다른 문제를 못느끼시겠지만,
다수의 사용자가 사용할 경우, thread-safe하지 않아 동기화하기 위한 복잡한 로직들을 고려해야 합니다.
동시성을 보장하기 위해 여러 방법이 있지만 기본적으로 아래와 같이 설계를 합니다.
- 상태변수를 쓰레드간 공유하지 않는다.
- 상태 변수를 변경할 수 없도록 만든다. - [불변객체](https://brainbackdoor.tistory.com/141) |
@@ -0,0 +1,113 @@
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Random;
+import java.util.Scanner;
+
+public class RacingCar {
+
+ static String move = "-";
+
+ static List<Car> recordMovingCar = new ArrayList<>();
+
+ public static void main(String[] args) {
+
+ InputView userInput = scannerInput();
+
+ int numberOfCarsValue = userInput.getNumberOfCars();
+ int numberOfAttemptsValue = userInput.getNumberOfAttempts();
+
+ System.out.println("======= READY =========");
+ for (int carNumber=0; carNumber < numberOfCarsValue; carNumber++) { System.out.println(move); }
+
+ System.out.println("======= START!! =======");
+ randomMove(numberOfCarsValue, numberOfAttemptsValue);
+
+ }
+
+ public static void randomMove(int numberOfCarsValue, int numberOfAttemptsValue) {
+ Random random = new Random();
+
+ for (int attempt=0; attempt < numberOfAttemptsValue; attempt++) {
+ for (int eachCar = 0; eachCar < numberOfCarsValue; eachCar++) {
+
+ int randomValueForMove = random.nextInt(numberOfAttemptsValue);
+
+ String move = "-";
+ Car car = new Car();
+ car.setMoving(move);
+ recordMovingCar.add(car);
+
+ String beforeMoving = "";
+
+// System.out.println("랜덤 값 : " + randomValueForMove);
+
+ if (randomValueForMove > 9 || randomValueForMove < 4) {
+ beforeMoving = recordMovingCar.get(eachCar).getMoving();
+ String doNotMove = beforeMoving + moving(randomValueForMove);
+ car.setMoving(doNotMove);
+ }
+
+
+ if (randomValueForMove > 0 & randomValueForMove > 3 & randomValueForMove <= 9) {
+ beforeMoving = recordMovingCar.get(eachCar).getMoving();
+ String plusMoving = beforeMoving + moving(randomValueForMove);
+ car.setMoving(plusMoving);
+ }
+
+ recordMovingCar.add(car);
+ recordMovingCar.get(eachCar).setMoving(car.getMoving());
+ System.out.println(recordMovingCar.get(eachCar).getMoving());
+ }
+ System.out.print(System.lineSeparator());
+ }
+ }
+
+ public static String moving(int randomValueForMove) {
+ String move = "-";
+
+ if (randomValueForMove > 9 || randomValueForMove < 4) {
+ move = "";
+ return move;
+ }
+
+ for (int number=0; number < randomValueForMove; number++) { move = move + "-";}
+
+ return move;
+ }
+
+ public static InputView scannerInput() {
+
+ InputView inputView = new InputView();
+ Scanner scanner = new Scanner(System.in);
+
+ System.out.println("자동차 대수는 몇 대인가요?");
+ inputView.setNumberOfCars(scanner.nextInt());
+
+ System.out.println("시도 횟수는 몇 회인가요?");
+ inputView.setNumberOfAttempts(scanner.nextInt());
+
+ return inputView;
+ }
+
+}
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ | Java | 이 로직은 InputView에 역할을 위임하는 건 어떨까요 |
@@ -0,0 +1,113 @@
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Random;
+import java.util.Scanner;
+
+public class RacingCar {
+
+ static String move = "-";
+
+ static List<Car> recordMovingCar = new ArrayList<>();
+
+ public static void main(String[] args) {
+
+ InputView userInput = scannerInput();
+
+ int numberOfCarsValue = userInput.getNumberOfCars();
+ int numberOfAttemptsValue = userInput.getNumberOfAttempts();
+
+ System.out.println("======= READY =========");
+ for (int carNumber=0; carNumber < numberOfCarsValue; carNumber++) { System.out.println(move); }
+
+ System.out.println("======= START!! =======");
+ randomMove(numberOfCarsValue, numberOfAttemptsValue);
+
+ }
+
+ public static void randomMove(int numberOfCarsValue, int numberOfAttemptsValue) {
+ Random random = new Random();
+
+ for (int attempt=0; attempt < numberOfAttemptsValue; attempt++) {
+ for (int eachCar = 0; eachCar < numberOfCarsValue; eachCar++) {
+
+ int randomValueForMove = random.nextInt(numberOfAttemptsValue);
+
+ String move = "-";
+ Car car = new Car();
+ car.setMoving(move);
+ recordMovingCar.add(car);
+
+ String beforeMoving = "";
+
+// System.out.println("랜덤 값 : " + randomValueForMove);
+
+ if (randomValueForMove > 9 || randomValueForMove < 4) {
+ beforeMoving = recordMovingCar.get(eachCar).getMoving();
+ String doNotMove = beforeMoving + moving(randomValueForMove);
+ car.setMoving(doNotMove);
+ }
+
+
+ if (randomValueForMove > 0 & randomValueForMove > 3 & randomValueForMove <= 9) {
+ beforeMoving = recordMovingCar.get(eachCar).getMoving();
+ String plusMoving = beforeMoving + moving(randomValueForMove);
+ car.setMoving(plusMoving);
+ }
+
+ recordMovingCar.add(car);
+ recordMovingCar.get(eachCar).setMoving(car.getMoving());
+ System.out.println(recordMovingCar.get(eachCar).getMoving());
+ }
+ System.out.print(System.lineSeparator());
+ }
+ }
+
+ public static String moving(int randomValueForMove) {
+ String move = "-";
+
+ if (randomValueForMove > 9 || randomValueForMove < 4) {
+ move = "";
+ return move;
+ }
+
+ for (int number=0; number < randomValueForMove; number++) { move = move + "-";}
+
+ return move;
+ }
+
+ public static InputView scannerInput() {
+
+ InputView inputView = new InputView();
+ Scanner scanner = new Scanner(System.in);
+
+ System.out.println("자동차 대수는 몇 대인가요?");
+ inputView.setNumberOfCars(scanner.nextInt());
+
+ System.out.println("시도 횟수는 몇 회인가요?");
+ inputView.setNumberOfAttempts(scanner.nextInt());
+
+ return inputView;
+ }
+
+}
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+
+ | Java | ```suggestion
public static void main(String[] args) {
int numberOfCars = InputView.inputNumberOfCars();
int numberOfAttempts = InputView.inputNumberOfAttempts();
RacingGame racingGame = new RacingGame(numberOfCars);
GameResult result = racingGame.play(numberOfAttempts);
ResultView.draw(result);
}
```
- 한번 위와 같이 main 메소드를 작성하고 진행해보시겠어요? (없는 객체들은 추가해서 진행해보세요.) |
@@ -0,0 +1,77 @@
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.DisplayName;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.CsvSource;
+import org.junit.jupiter.params.provider.ValueSource;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Random;
+
+import static org.assertj.core.api.Assertions.*;
+
+public class RacingCarTest {
+
+ List<Car> recordMovingCar = new ArrayList<>();
+
+ @ParameterizedTest
+ @ValueSource(ints = {1, 2, 3, 4, 5})
+ @DisplayName("입력한 횟수 만큼의 '-' 문자열 만들기")
+ public String moving(int randomValueForMove) {
+ String move = "-";
+
+ if (randomValueForMove > 9 || randomValueForMove < 4) {
+ move = "";
+ return move;
+ }
+
+ for (int number=0; number < randomValueForMove; number++) { move = move + "-";}
+
+ return move;
+ }
+
+ @ParameterizedTest
+ @CsvSource({
+ "1, 2",
+ "5, 7",
+ "3, 5",
+ "2, 7"
+ })
+ @DisplayName("입력한 자동차 대수 및 시도 횟수에 맞게 결과가 출력 되는가")
+ public void randomNumberForMove(int numberOfCarsValue, int numberOfAttemptsValue) {
+ Random random = new Random();
+
+ for (int attempt=0; attempt < numberOfAttemptsValue; attempt++) {
+ for (int eachCar = 0; eachCar < numberOfCarsValue; eachCar++) {
+ int carIndex = eachCar + 1;
+ int randomValueForMove = random.nextInt(numberOfAttemptsValue);
+
+ String move = "-";
+ Car car = new Car();
+ car.setMoving(move);
+ recordMovingCar.add(car);
+
+ String beforeMoving = "";
+
+// System.out.println("랜덤 값 : " + randomValueForMove);
+
+ if (randomValueForMove > 9 || randomValueForMove < 4) {
+ beforeMoving = recordMovingCar.get(eachCar).getMoving();
+ String doNotMove = beforeMoving + moving(randomValueForMove);
+ car.setMoving(doNotMove);
+ }
+
+ if (randomValueForMove > 0 & randomValueForMove > 3 & randomValueForMove <= 9) {
+ beforeMoving = recordMovingCar.get(eachCar).getMoving();
+ String plusMoving = beforeMoving + moving(randomValueForMove);
+ car.setMoving(plusMoving);
+ }
+
+ recordMovingCar.add(car);
+ recordMovingCar.get(eachCar).setMoving(car.getMoving());
+ System.out.println(recordMovingCar.get(eachCar).getMoving());
+ }
+ System.out.print(System.lineSeparator());
+ }
+ }
+} | Java | - 테스트코드에 if 조건 분기를 작성할 일은 없습니다. 테스트하고자 하는 대상에 메시지를 보낸 후 응답받은 값이 의도한 결과와 같은지만 검증하면 됩니다.
- 단위 테스트에 return 문을 작성한 후 이를 활용하는 형태는 지양합니다. 필요하다면 별도의 Test Fixture를 작성하고 활용하시면 됩니다. |
@@ -0,0 +1,77 @@
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.DisplayName;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.CsvSource;
+import org.junit.jupiter.params.provider.ValueSource;
+
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Random;
+
+import static org.assertj.core.api.Assertions.*;
+
+public class RacingCarTest {
+
+ List<Car> recordMovingCar = new ArrayList<>();
+
+ @ParameterizedTest
+ @ValueSource(ints = {1, 2, 3, 4, 5})
+ @DisplayName("입력한 횟수 만큼의 '-' 문자열 만들기")
+ public String moving(int randomValueForMove) {
+ String move = "-";
+
+ if (randomValueForMove > 9 || randomValueForMove < 4) {
+ move = "";
+ return move;
+ }
+
+ for (int number=0; number < randomValueForMove; number++) { move = move + "-";}
+
+ return move;
+ }
+
+ @ParameterizedTest
+ @CsvSource({
+ "1, 2",
+ "5, 7",
+ "3, 5",
+ "2, 7"
+ })
+ @DisplayName("입력한 자동차 대수 및 시도 횟수에 맞게 결과가 출력 되는가")
+ public void randomNumberForMove(int numberOfCarsValue, int numberOfAttemptsValue) {
+ Random random = new Random();
+
+ for (int attempt=0; attempt < numberOfAttemptsValue; attempt++) {
+ for (int eachCar = 0; eachCar < numberOfCarsValue; eachCar++) {
+ int carIndex = eachCar + 1;
+ int randomValueForMove = random.nextInt(numberOfAttemptsValue);
+
+ String move = "-";
+ Car car = new Car();
+ car.setMoving(move);
+ recordMovingCar.add(car);
+
+ String beforeMoving = "";
+
+// System.out.println("랜덤 값 : " + randomValueForMove);
+
+ if (randomValueForMove > 9 || randomValueForMove < 4) {
+ beforeMoving = recordMovingCar.get(eachCar).getMoving();
+ String doNotMove = beforeMoving + moving(randomValueForMove);
+ car.setMoving(doNotMove);
+ }
+
+ if (randomValueForMove > 0 & randomValueForMove > 3 & randomValueForMove <= 9) {
+ beforeMoving = recordMovingCar.get(eachCar).getMoving();
+ String plusMoving = beforeMoving + moving(randomValueForMove);
+ car.setMoving(plusMoving);
+ }
+
+ recordMovingCar.add(car);
+ recordMovingCar.get(eachCar).setMoving(car.getMoving());
+ System.out.println(recordMovingCar.get(eachCar).getMoving());
+ }
+ System.out.print(System.lineSeparator());
+ }
+ }
+} | Java | - 위에 언급했듯 테스트 코드에 도메인 로직을 작성해선 안됩니다.
- 단위테스트는 assertion으로만 검증해야 합니다. |
@@ -0,0 +1,330 @@
+body {
+ font-family: '-apple-system', 'BlinkMacSystemFont', 'Segoe UI', 'Roboto', 'Helvetica Neue',
+ 'Arial', 'Noto Sans', 'sans-serif', 'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol',
+ 'Noto Color Emoji';
+ font-size: 18px;
+ color: #212124;
+}
+
+/* components > header */
+.header {
+ position: fixed;
+ top: 0;
+ left: 0;
+ display: flex;
+ width: 100%;
+ height: 68px;
+ justify-content: center;
+ background-color: white;
+ z-index: 10;
+}
+
+.nav__box {
+ display: flex;
+ padding: 0 1.5rem;
+ width: 100%;
+ max-width: 1200px;
+ align-items: center;
+ justify-content: space-between;
+}
+
+.nav__list {
+ display: flex;
+ gap: 56px;
+}
+
+.nav__link {
+ text-decoration: none;
+ font-size: 16px;
+ font-weight: 600;
+ line-height: 0;
+}
+
+.nav__link:hover {
+ color: #868b94;
+}
+
+/* components > footer */
+.footer__wrapper {
+ display: flex;
+ width: 100%;
+ justify-content: center;
+ align-items: center;
+ margin-top: 160px;
+ border-top: solid 1px #f2f3f6;
+ padding: 70px 0px 96px 0px;
+}
+
+.footer__container {
+ display: flex;
+ flex-direction: column;
+ gap: 36px;
+ padding: 0px 24px;
+}
+
+.footer__nav {
+ max-width: 1200px;
+ display: flex;
+ /* 임의 설정 */
+ gap: 500px;
+ align-items: center;
+ justify-content: space-between;
+}
+
+.footer__nav > ul {
+ padding: 0px;
+ display: flex;
+ margin: 0px;
+}
+
+.footer__nav__link {
+ font-size: 13px;
+ font-weight: 400;
+ color: #212124;
+ cursor: pointer;
+ margin-left: 48px;
+}
+
+.footer__nav__link:first-child {
+ margin-left: 0px;
+}
+
+.footer__nav__link:hover {
+ color: #868b94;
+ filter: invert(57%) sepia(4%) saturate(791%) hue-rotate(180deg) brightness(97%) contrast(77%);
+}
+
+.footer__nav__link > a {
+ display: inline-flex;
+ align-items: center;
+ opacity: 1;
+}
+
+.footer__nav__link > a > h4 {
+ font-size: 13px;
+ font-weight: 600;
+}
+
+.footer__nav__link > a > img {
+ width: 16px;
+ height: 16px;
+}
+
+.sns__box {
+ display: flex;
+ gap: 24px;
+ padding: 0px;
+}
+
+.sns__link {
+ width: 24px;
+ height: 24px;
+ cursor: pointer;
+}
+
+.sns__link:hover {
+ filter: invert(57%) sepia(4%) saturate(791%) hue-rotate(180deg) brightness(97%) contrast(77%);
+}
+
+.footer__information {
+ font-size: 14px;
+ color: #868b94;
+ font-weight: 400;
+}
+
+.footer__information__box {
+ display: flex;
+}
+
+.footer__information__address {
+ margin-right: 8px;
+}
+
+.footer__contact {
+ text-decoration: underline;
+}
+
+.corporate__name {
+ font-size: 13px;
+ color: #868b94;
+ font-weight: 600;
+ margin-top: 16px;
+}
+
+/* Blog */
+.blog__wrapper {
+ margin: 40px 120px 0px 120px;
+ padding: 0 24px;
+ display: flex;
+ flex-direction: column;
+ justify-content: center;
+}
+
+.tag__box {
+ display: flex;
+ gap: 10px;
+ margin-bottom: 44px;
+ margin: 0px 48px;
+}
+
+.card__box {
+ display: grid;
+ grid-template-columns: repeat(2, 1fr);
+ row-gap: 3rem;
+ margin-top: 44px;
+}
+
+.card__box > a {
+ display: flex;
+ justify-items: center;
+ justify-content: center;
+}
+
+/* Blog > MainCard */
+.maincard__wrapper {
+ display: flex;
+ flex-direction: column;
+ margin-bottom: 100px;
+ cursor: pointer;
+ margin: 0px 48px 100px 48px;
+}
+
+.maincard__thumbnail {
+ border-radius: 40px;
+ max-width: 1200px;
+ aspect-ratio: 1160 / 650;
+}
+
+.maincard__body {
+ display: flex;
+ flex-direction: column;
+ align-items: center;
+ margin-top: 44px;
+}
+
+.maincard__body > h1 {
+ line-height: 39px;
+ font-size: 32px;
+ margin-bottom: 2px;
+ font-weight: 600;
+}
+
+.maincard__body > p {
+ line-height: 28px;
+ font-size: 18px;
+ color: #868b94;
+}
+
+/* Blog > Tag */
+.tag__wrapper {
+ /* display: flex; */
+ border-radius: 40px;
+ line-height: 14px;
+ border: none;
+ padding: 14px 20px;
+ font-size: 18px;
+ color: #868b94;
+ background-color: #f2f3f6;
+ cursor: pointer;
+}
+
+.tag__wrapper:hover {
+ background-color: #212124;
+ color: #ffffff;
+ font-weight: 600;
+}
+
+/* Blog > Card */
+.card__wrapper {
+ width: 100%;
+ display: flex;
+ flex-direction: column;
+ cursor: pointer;
+ margin: 0 48px;
+}
+
+.card__wrapper:hover {
+ transform: translateY(-8px);
+ transition: all 0.3s ease-in-out;
+}
+
+.card__wrapper > img {
+ border-radius: 20px;
+}
+
+.card__body > h3 {
+ font-size: 22px;
+ margin-top: 20px;
+ font-weight: 600;
+}
+
+.card__body > h3:hover {
+ color: #4d5159;
+}
+
+.card__body > p {
+ font-size: 16px;
+ margin-top: 12px;
+ color: #868b94;
+ white-space: pre-line;
+}
+
+.card__samlltagbox {
+ display: flex;
+}
+
+.card__smalltag {
+ font-size: 13px;
+ height: 30px;
+ color: #868b94;
+ background-color: #f2f3f6;
+ border-radius: 40px;
+ padding: 4px 10px;
+ margin-top: 24px;
+}
+
+/* Post */
+.post__wrapper {
+ display: flex;
+ flex-direction: column;
+ justify-content: center;
+ align-items: center;
+ margin: 40px 120px 0px 120px;
+ padding: 0px 24px;
+}
+
+.post_article {
+ margin: 0px 126px;
+}
+
+.post__title {
+ display: flex;
+ flex-direction: column;
+ justify-content: center;
+ align-items: center;
+ margin-bottom: 66px;
+}
+
+.post__title > h1 {
+ font-size: 42px;
+ margin-bottom: 12px;
+}
+
+.post__title > div {
+ font-size: 16px;
+ color: #868b94;
+}
+
+.post__image {
+ padding: 0 24px;
+}
+
+.post__image > img {
+ object-fit: cover;
+ border-radius: 30px;
+ margin-bottom: 88px;
+}
+
+.post_article > p {
+ padding: 0 24px;
+} | Unknown | CSS의 경우, [BEM 방법론](https://getbem.com/)을 토대로 작성하고자 노력하였습니다. |
@@ -0,0 +1,108 @@
+package christmas.validate;
+
+import christmas.constants.Constants;
+import christmas.domain.Menu;
+
+import java.util.Arrays;
+import java.util.List;
+import java.util.stream.Collectors;
+
+public class Validate {
+ private static final String errorMessage = "[ERROR]";
+ private static final String COMMA = ",";
+ private static final int MENUMAXCOUNT = 20;
+ private static final String menuInputPattern = "(([가-힣]*)-[0-9]*)";
+ private static final String integerPattern = "([0-9]*)";
+ private static final String delimeterPattern = "(-[0-9]*.)";
+ private static final String delimeterNamePattern = "(.[가-힣]+-)";
+ private static final String mentionErrorDate = " 유효하지 않은 날짜입니다. 다시 입력해 주세요.";
+ private static final String mentionErrorMenu = " 유효하지 않은 주문입니다. 다시 입력해 주세요.";
+
+ public static void isOnlyDrinkValidate(String order) {
+ List<String> menuName = replaceStringToName(order);
+ try {
+ check(!menuName.stream().allMatch(menu -> Menu.isOnlyDrinkMenu(menu)));
+ } catch (IllegalArgumentException e) {
+ System.out.println(errorMessage + mentionErrorMenu);
+ }
+ }
+
+ public static void integerTypeValidate(String number) {
+ try {
+ check(number.matches(integerPattern));
+ } catch (IllegalArgumentException e) {
+ System.out.println(errorMessage + mentionErrorDate);
+ throw new IllegalArgumentException();
+ }
+ }
+
+ public static void menuFormatValidate(String order) {
+ List<String> orderList = Arrays.stream(order.split(COMMA)).toList();
+ try {
+ if (!orderList.stream().allMatch(s -> s.matches(menuInputPattern))) {
+ throw new IllegalArgumentException();
+ }
+ } catch (IllegalArgumentException e) {
+ System.out.println(errorMessage + mentionErrorMenu);
+ throw new IllegalArgumentException();
+ }
+ }
+
+ public static void menuDuplicationValidate(String order) {
+ List<String> menuName = replaceStringToName(order);
+ try {
+ check(menuName.stream().distinct().collect(Collectors.toList()).size() == menuName.size());
+ } catch (IllegalArgumentException e) {
+ System.out.println(errorMessage + mentionErrorMenu);
+ throw new IllegalArgumentException();
+ }
+ }
+
+ public static void menuOrderNumberValidate(String order) {
+ try {
+ check(replaceStringToCount(order).stream().mapToInt(Integer::intValue).sum() <= MENUMAXCOUNT);
+ } catch (IllegalArgumentException e) {
+ System.out.println(errorMessage + mentionErrorMenu);
+ throw new IllegalArgumentException();
+ }
+ }
+
+ private static void check(boolean validate) {
+ if (!validate) {
+ throw new IllegalArgumentException();
+ }
+ }
+
+ public static void menuValidate(String order) {
+ List<String> menuName = replaceStringToName(order);
+ try {
+ for (String input : menuName) {
+ check(Arrays.stream(Menu.values()).anyMatch(Menu -> Menu.getName().equals(input)));
+ }
+ } catch (IllegalArgumentException e) {
+ System.out.println(errorMessage + mentionErrorMenu);
+ throw new IllegalArgumentException();
+ }
+ }
+
+ public static void visitDateValidate(int visitDate) {
+ try {
+ check(visitDate <= Constants.MAXDATE && visitDate >= Constants.MINDATE);
+ } catch (IllegalArgumentException e) {
+ System.out.println(errorMessage + mentionErrorDate);
+ throw new IllegalArgumentException();
+ }
+ }
+
+ private static List<String> replaceStringToName(String order) {
+ return Arrays.stream(order.replaceAll(delimeterPattern, ",").split(","))
+ .collect(Collectors.toList());
+ }
+
+ public static List<Integer> replaceStringToCount(String order) {
+ return Arrays.stream(order.replaceAll(delimeterNamePattern, ",").split(","))
+ .filter(s -> !s.equals(""))
+ .map(Integer::parseInt).collect(Collectors.toList());
+ }
+
+} | Java | static final한 변수들은 SCREAMING_SNAKE_CASE로 작성하는 것이 컨벤션입니다 |
@@ -0,0 +1,117 @@
+package christmas.model;
+
+import christmas.domain.Holiday;
+import christmas.domain.Menu;
+
+import java.util.Arrays;
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.stream.Collectors;
+
+public class Discount {
+
+ private final static int DISCOUNTUNIT = 100;
+ private final static int CHRISTMASDATE = 25;
+ private final static int BASICDISCOUNT = 1000;
+ private final static int PERIOD = 7;
+ private final static int DISCOUNT = 2023;
+ private final static int STARTDISCOUNT = 1000;
+ private final static int NOTDISCOUNT = 0;
+ private final static int CHAMPAGNEEVENT = 120000;
+ private final static String christmasDayDiscount = "크리스마스 디데이 할인";
+ private final static String weekendDiscount = "평일 할인";
+ private final static String holidayDiscount = "주말 할인";
+ private final static String specialDiscount = "특별 할인";
+ private final static String bonusEvent = "증정 이벤트";
+
+ public Map<String, Integer> discountTotal(int date, Map<Menu, Integer> orderMenu, int payAmount) {
+ Map<String, Integer> discountResult = new LinkedHashMap<>();
+ discountInput(date, orderMenu, payAmount, discountResult);
+ return discountResult;
+ }
+
+ private void discountInput(int date, Map<Menu, Integer> orderMenu, int payAmount, Map<String, Integer> discountResult) {
+ if (discountChristmas(date) != 0) {
+ discountResult.put(christmasDayDiscount, discountChristmas(date));
+ }
+ if (discountDay(date).stream().anyMatch(menu -> orderMenu.containsKey(menu))) {
+ weekEndOrHolidayTotalDiscount(date, discountResult, discountDay(date), orderMenu);
+ }
+ if (discountStar(date) != 0) {
+ discountResult.put(specialDiscount, discountStar(date));
+ }
+ if (eventChampagne(payAmount)) {
+ discountResult.put(bonusEvent, Menu.CHAMPAGNE.getPrice());
+ }
+ }
+
+ public int discountTotalAmount(Map<String, Integer> discountTotal) {
+ return discountTotal.values().stream().mapToInt(Integer::intValue).sum();
+ }
+
+ public int discountTotalAmountExceptBonus(Map<String, Integer> discountTotal) {
+ return discountTotal.keySet().stream().filter(key -> !key.equals(bonusEvent))
+ .mapToInt(key -> discountTotal.get(key)).sum();
+ }
+
+ public void weekEndOrHolidayTotalDiscount(int date, Map<String, Integer> discountResult,
+ List<Menu> discount, Map<Menu, Integer> orderMenu) {
+ int sum = orderMenu.keySet().stream()
+ .filter(menu -> discount.contains(menu)).mapToInt(key -> orderMenu.get(key) * DISCOUNT).sum();
+ if (weekOrHoliday(date)) {
+ discountResult.put(holidayDiscount, sum);
+ return;
+ }
+ discountResult.put(weekendDiscount, sum);
+ }
+
+ public boolean eventChampagne(int orderAmount) {
+ if (orderAmount >= CHAMPAGNEEVENT) {
+ return true;
+ }
+ return false;
+ }
+
+ public int discountStar(int date) {
+ if (Arrays.stream(Holiday.values()).anyMatch(i -> i.getDate() == date)) {
+ return STARTDISCOUNT;
+ }
+ return NOTDISCOUNT;
+ }
+
+ public int discountChristmas(int date) {
+ int result = 0;
+ if (date <= CHRISTMASDATE) {
+ result = BASICDISCOUNT + DISCOUNTUNIT * (date - 1);
+ }
+ return result;
+ }
+
+ public List<Menu> discountDay(int date) {
+ if (weekOrHoliday(date)) {
+ return discountHoliday();
+ }
+ return discountWeekday();
+ }
+
+ //true : 주말 | false : 평일
+ private boolean weekOrHoliday(int date) {
+ if (date % 7 == 1 || date % 7 == 2) {
+ return true;
+ }
+ return false;
+ }
+
+ private List<Menu> discountWeekday() {
+ return Arrays.stream(Menu.values()).filter(menu -> menu != menu.NONE)
+ .filter(menu -> menu.getType().equals("desert"))
+ .collect(Collectors.toList());
+ }
+
+ private List<Menu> discountHoliday() {
+ return Arrays.stream(Menu.values()).filter(menu -> menu != menu.NONE)
+ .filter(menu -> menu.getType().equals("main"))
+ .collect(Collectors.toList());
+ }
+} | Java | private static final의 순서로 작성해주시면 좋을 것 같아요 |
@@ -0,0 +1,13 @@
+package christmas.model;
+
+import christmas.domain.Badge;
+
+import java.util.Arrays;
+import java.util.Comparator;
+
+public class BadgeEvent {
+ public Badge giveBadge(int orderAmount) {
+ return Arrays.stream(Badge.values()).sorted(Comparator.reverseOrder())
+ .filter(b -> b.getCutLine() <= orderAmount).findFirst().orElse(Badge.NONE);
+ }
+} | Java | 도메인과 모델의 차이가 무엇인가요? |
@@ -0,0 +1,117 @@
+package christmas.model;
+
+import christmas.domain.Holiday;
+import christmas.domain.Menu;
+
+import java.util.Arrays;
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.stream.Collectors;
+
+public class Discount {
+
+ private final static int DISCOUNTUNIT = 100;
+ private final static int CHRISTMASDATE = 25;
+ private final static int BASICDISCOUNT = 1000;
+ private final static int PERIOD = 7;
+ private final static int DISCOUNT = 2023;
+ private final static int STARTDISCOUNT = 1000;
+ private final static int NOTDISCOUNT = 0;
+ private final static int CHAMPAGNEEVENT = 120000;
+ private final static String christmasDayDiscount = "크리스마스 디데이 할인";
+ private final static String weekendDiscount = "평일 할인";
+ private final static String holidayDiscount = "주말 할인";
+ private final static String specialDiscount = "특별 할인";
+ private final static String bonusEvent = "증정 이벤트";
+
+ public Map<String, Integer> discountTotal(int date, Map<Menu, Integer> orderMenu, int payAmount) {
+ Map<String, Integer> discountResult = new LinkedHashMap<>();
+ discountInput(date, orderMenu, payAmount, discountResult);
+ return discountResult;
+ }
+
+ private void discountInput(int date, Map<Menu, Integer> orderMenu, int payAmount, Map<String, Integer> discountResult) {
+ if (discountChristmas(date) != 0) {
+ discountResult.put(christmasDayDiscount, discountChristmas(date));
+ }
+ if (discountDay(date).stream().anyMatch(menu -> orderMenu.containsKey(menu))) {
+ weekEndOrHolidayTotalDiscount(date, discountResult, discountDay(date), orderMenu);
+ }
+ if (discountStar(date) != 0) {
+ discountResult.put(specialDiscount, discountStar(date));
+ }
+ if (eventChampagne(payAmount)) {
+ discountResult.put(bonusEvent, Menu.CHAMPAGNE.getPrice());
+ }
+ }
+
+ public int discountTotalAmount(Map<String, Integer> discountTotal) {
+ return discountTotal.values().stream().mapToInt(Integer::intValue).sum();
+ }
+
+ public int discountTotalAmountExceptBonus(Map<String, Integer> discountTotal) {
+ return discountTotal.keySet().stream().filter(key -> !key.equals(bonusEvent))
+ .mapToInt(key -> discountTotal.get(key)).sum();
+ }
+
+ public void weekEndOrHolidayTotalDiscount(int date, Map<String, Integer> discountResult,
+ List<Menu> discount, Map<Menu, Integer> orderMenu) {
+ int sum = orderMenu.keySet().stream()
+ .filter(menu -> discount.contains(menu)).mapToInt(key -> orderMenu.get(key) * DISCOUNT).sum();
+ if (weekOrHoliday(date)) {
+ discountResult.put(holidayDiscount, sum);
+ return;
+ }
+ discountResult.put(weekendDiscount, sum);
+ }
+
+ public boolean eventChampagne(int orderAmount) {
+ if (orderAmount >= CHAMPAGNEEVENT) {
+ return true;
+ }
+ return false;
+ }
+
+ public int discountStar(int date) {
+ if (Arrays.stream(Holiday.values()).anyMatch(i -> i.getDate() == date)) {
+ return STARTDISCOUNT;
+ }
+ return NOTDISCOUNT;
+ }
+
+ public int discountChristmas(int date) {
+ int result = 0;
+ if (date <= CHRISTMASDATE) {
+ result = BASICDISCOUNT + DISCOUNTUNIT * (date - 1);
+ }
+ return result;
+ }
+
+ public List<Menu> discountDay(int date) {
+ if (weekOrHoliday(date)) {
+ return discountHoliday();
+ }
+ return discountWeekday();
+ }
+
+ //true : 주말 | false : 평일
+ private boolean weekOrHoliday(int date) {
+ if (date % 7 == 1 || date % 7 == 2) {
+ return true;
+ }
+ return false;
+ }
+
+ private List<Menu> discountWeekday() {
+ return Arrays.stream(Menu.values()).filter(menu -> menu != menu.NONE)
+ .filter(menu -> menu.getType().equals("desert"))
+ .collect(Collectors.toList());
+ }
+
+ private List<Menu> discountHoliday() {
+ return Arrays.stream(Menu.values()).filter(menu -> menu != menu.NONE)
+ .filter(menu -> menu.getType().equals("main"))
+ .collect(Collectors.toList());
+ }
+} | Java | 사용되고 있지 않은 변수인 것 같아요 |
@@ -0,0 +1,25 @@
+package christmas.domain;
+
+public enum Badge {
+ NONE("없음", 0),
+ STAR("별", 5000),
+ TREE("트리", 10000),
+ SANTA("산타", 20000);
+
+
+ private String name;
+ private int cutLine;
+
+ Badge(String name, int cutLine) {
+ this.name = name;
+ this.cutLine = cutLine;
+ }
+
+ public String getName() {
+ return name;
+ }
+
+ public int getCutLine() {
+ return cutLine;
+ }
+} | Java | enum의 이 변수들은 재할당 될 일이 없으니 private final하게 작성해주시면 좋을 것 같아요 |
@@ -0,0 +1,13 @@
+package christmas.model;
+
+import christmas.domain.Badge;
+
+import java.util.Arrays;
+import java.util.Comparator;
+
+public class BadgeEvent {
+ public Badge giveBadge(int orderAmount) {
+ return Arrays.stream(Badge.values()).sorted(Comparator.reverseOrder())
+ .filter(b -> b.getCutLine() <= orderAmount).findFirst().orElse(Badge.NONE);
+ }
+} | Java | 1. 스트림은 한 줄에 한 개씩 해서 늘여써 주시면 보기 편할 것 같습니다
2. 커트라인을 물어본 다음 직접 로직을 계산하는게 아니라, 커트라인을 넘냐고 시키면 어떨까요?
3. 람다의 b라는 변수명을 조금 더 파악하기 쉬운 이름을 적어주시면 좋을 것 같아요
4. 이 코드는 Badge의 순서가 바뀌게 되면 오류가 납니다. 커트라인을 기준으로 reverseOrder로 정렬해야 할 것 같아요
```suggestion
public Badge giveBadge(int orderAmount) {
return Arrays.stream(Badge.values())
.filter(badge -> badge.isOverCutLine(orderAmount))
.max(Comparator.comparingInt(Badge::getCutLine))
.orElse(Badge.NONE);
}
``` |
@@ -0,0 +1,62 @@
+package christmas.domain;
+
+import java.util.Arrays;
+
+public enum Menu {
+
+ STAKE("티본스테이크", 55000, "main"),
+ LEAF("바비큐립", 54000, "main"),
+ PASTA("해산물파스타", 35000, "main"),
+ CHRISMASPASTA("크리스마스파스타", 25000, "main"),
+
+ COKE("제로콜라", 3000, "drink"),
+ WINE("레드와인", 60000, "drink"),
+ CHAMPAGNE("샴페인", 25000, "drink"),
+
+ CAKE("초코케이크", 15000, "desert"),
+ ICECREAM("아이스크림", 5000, "desert"),
+
+ SOUP("양송이수프", 6000, "appetizer"),
+ TAPAS("타파스", 5500, "appetizer"),
+ SALAD("시저샐러드", 8000, "appetizer"),
+
+ NONE("없음", 0, "none");
+
+ private String name;
+ private int price;
+ private String type;
+
+ public String getType() {
+ return type;
+ }
+
+ public String getName() {
+ return name;
+ }
+
+ public int getPrice() {
+ return price;
+ }
+
+ Menu(String name, int price, String type) {
+ this.name = name;
+ this.price = price;
+ this.type = type;
+ }
+
+ public static Menu getMenuWithName(String menuName) {
+ return Arrays.stream(Menu.values())
+ .filter(menu -> menu.getName().equals(menuName)).findAny().get();
+ }
+
+ public static int getPriceWithName(String name) {
+ return Arrays.stream(Menu.values()).filter(Menu -> Menu.name.equals(name)).findAny()
+ .orElse(NONE).getPrice();
+ }
+
+ // Drink만 포함된 메뉴가 아니면 True
+ public static boolean isOnlyDrinkMenu(String name) {
+ return Arrays.stream(Menu.values()).filter(n -> n.getName().equals(name))
+ .allMatch(n -> n.getType().equals("drink"));
+ }
+} | Java | 1. 없는 메뉴 이름이 들어오면 터질 수 있으니, get보단 orElseThrow와 같은 식으로 구현하면 좋을 것 같아요
2. 있을 수도, 없을 수도 있으니 get보단 `findMenuByName` 같은 이름도 좋을 것 같네요 |
@@ -0,0 +1,30 @@
+package christmas.domain;
+
+import java.util.Map;
+
+public class Order {
+
+ private int orderDate;
+ private Map<Menu, Integer> orderMenu;
+
+ public Order(int orderDate, Map<Menu, Integer> orderMenu) {
+ this.orderDate = orderDate;
+ this.orderMenu = orderMenu;
+ }
+
+ public int getOrderDate() {
+ return orderDate;
+ }
+
+ public Map<Menu, Integer> getOrderMenu() {
+ return orderMenu;
+ }
+
+ public int orderAmount() {
+ int result = 0;
+ for (Menu menu : orderMenu.keySet()) {
+ result += Menu.getPriceWithName(menu.getName()) * orderMenu.get(menu);
+ }
+ return result;
+ }
+} | Java | ```suggestion
result += menu.getPrice() * orderMenu.get(menu);
```
그냥 menu.getPrice를 써도 될 것 같아요 😄 |
@@ -0,0 +1,62 @@
+package christmas.domain;
+
+import java.util.Arrays;
+
+public enum Menu {
+
+ STAKE("티본스테이크", 55000, "main"),
+ LEAF("바비큐립", 54000, "main"),
+ PASTA("해산물파스타", 35000, "main"),
+ CHRISMASPASTA("크리스마스파스타", 25000, "main"),
+
+ COKE("제로콜라", 3000, "drink"),
+ WINE("레드와인", 60000, "drink"),
+ CHAMPAGNE("샴페인", 25000, "drink"),
+
+ CAKE("초코케이크", 15000, "desert"),
+ ICECREAM("아이스크림", 5000, "desert"),
+
+ SOUP("양송이수프", 6000, "appetizer"),
+ TAPAS("타파스", 5500, "appetizer"),
+ SALAD("시저샐러드", 8000, "appetizer"),
+
+ NONE("없음", 0, "none");
+
+ private String name;
+ private int price;
+ private String type;
+
+ public String getType() {
+ return type;
+ }
+
+ public String getName() {
+ return name;
+ }
+
+ public int getPrice() {
+ return price;
+ }
+
+ Menu(String name, int price, String type) {
+ this.name = name;
+ this.price = price;
+ this.type = type;
+ }
+
+ public static Menu getMenuWithName(String menuName) {
+ return Arrays.stream(Menu.values())
+ .filter(menu -> menu.getName().equals(menuName)).findAny().get();
+ }
+
+ public static int getPriceWithName(String name) {
+ return Arrays.stream(Menu.values()).filter(Menu -> Menu.name.equals(name)).findAny()
+ .orElse(NONE).getPrice();
+ }
+
+ // Drink만 포함된 메뉴가 아니면 True
+ public static boolean isOnlyDrinkMenu(String name) {
+ return Arrays.stream(Menu.values()).filter(n -> n.getName().equals(name))
+ .allMatch(n -> n.getType().equals("drink"));
+ }
+} | Java | ```suggestion
STAKE("티본스테이크", 55000, Category.MAIN),
```
카테고리의 오타 방지나 변경의 유연함을 위해 카테고리를 enum으로 만들거나, 상수들을 변수로 빼줬어도 좋을 것 같아요 |
@@ -0,0 +1,62 @@
+package christmas.domain;
+
+import java.util.Arrays;
+
+public enum Menu {
+
+ STAKE("티본스테이크", 55000, "main"),
+ LEAF("바비큐립", 54000, "main"),
+ PASTA("해산물파스타", 35000, "main"),
+ CHRISMASPASTA("크리스마스파스타", 25000, "main"),
+
+ COKE("제로콜라", 3000, "drink"),
+ WINE("레드와인", 60000, "drink"),
+ CHAMPAGNE("샴페인", 25000, "drink"),
+
+ CAKE("초코케이크", 15000, "desert"),
+ ICECREAM("아이스크림", 5000, "desert"),
+
+ SOUP("양송이수프", 6000, "appetizer"),
+ TAPAS("타파스", 5500, "appetizer"),
+ SALAD("시저샐러드", 8000, "appetizer"),
+
+ NONE("없음", 0, "none");
+
+ private String name;
+ private int price;
+ private String type;
+
+ public String getType() {
+ return type;
+ }
+
+ public String getName() {
+ return name;
+ }
+
+ public int getPrice() {
+ return price;
+ }
+
+ Menu(String name, int price, String type) {
+ this.name = name;
+ this.price = price;
+ this.type = type;
+ }
+
+ public static Menu getMenuWithName(String menuName) {
+ return Arrays.stream(Menu.values())
+ .filter(menu -> menu.getName().equals(menuName)).findAny().get();
+ }
+
+ public static int getPriceWithName(String name) {
+ return Arrays.stream(Menu.values()).filter(Menu -> Menu.name.equals(name)).findAny()
+ .orElse(NONE).getPrice();
+ }
+
+ // Drink만 포함된 메뉴가 아니면 True
+ public static boolean isOnlyDrinkMenu(String name) {
+ return Arrays.stream(Menu.values()).filter(n -> n.getName().equals(name))
+ .allMatch(n -> n.getType().equals("drink"));
+ }
+} | Java | 1. 람다식의 변수는 camelCase로 적어주시면 좋을 것 같아요
2. `getMenuWithName`의 로직과 중복이지 않나요? 메소드로 추출할 수 있을 것 같아요 |
@@ -0,0 +1,62 @@
+package christmas.domain;
+
+import java.util.Arrays;
+
+public enum Menu {
+
+ STAKE("티본스테이크", 55000, "main"),
+ LEAF("바비큐립", 54000, "main"),
+ PASTA("해산물파스타", 35000, "main"),
+ CHRISMASPASTA("크리스마스파스타", 25000, "main"),
+
+ COKE("제로콜라", 3000, "drink"),
+ WINE("레드와인", 60000, "drink"),
+ CHAMPAGNE("샴페인", 25000, "drink"),
+
+ CAKE("초코케이크", 15000, "desert"),
+ ICECREAM("아이스크림", 5000, "desert"),
+
+ SOUP("양송이수프", 6000, "appetizer"),
+ TAPAS("타파스", 5500, "appetizer"),
+ SALAD("시저샐러드", 8000, "appetizer"),
+
+ NONE("없음", 0, "none");
+
+ private String name;
+ private int price;
+ private String type;
+
+ public String getType() {
+ return type;
+ }
+
+ public String getName() {
+ return name;
+ }
+
+ public int getPrice() {
+ return price;
+ }
+
+ Menu(String name, int price, String type) {
+ this.name = name;
+ this.price = price;
+ this.type = type;
+ }
+
+ public static Menu getMenuWithName(String menuName) {
+ return Arrays.stream(Menu.values())
+ .filter(menu -> menu.getName().equals(menuName)).findAny().get();
+ }
+
+ public static int getPriceWithName(String name) {
+ return Arrays.stream(Menu.values()).filter(Menu -> Menu.name.equals(name)).findAny()
+ .orElse(NONE).getPrice();
+ }
+
+ // Drink만 포함된 메뉴가 아니면 True
+ public static boolean isOnlyDrinkMenu(String name) {
+ return Arrays.stream(Menu.values()).filter(n -> n.getName().equals(name))
+ .allMatch(n -> n.getType().equals("drink"));
+ }
+} | Java | 이건 이 클래스의 메뉴들 중, name과 같은 이름의 메뉴가 drink인지에 대한 로직인 것 같아요.
다시 말해, name으로 들어온 애가 drink인지를 판단하는 로직인데요. 주석으로 작성하신 설명과 조금 다른 것 같아요
`isDrinkMenu`가 어울리지 않을까요? |
@@ -0,0 +1,62 @@
+package christmas.domain;
+
+import java.util.Arrays;
+
+public enum Menu {
+
+ STAKE("티본스테이크", 55000, "main"),
+ LEAF("바비큐립", 54000, "main"),
+ PASTA("해산물파스타", 35000, "main"),
+ CHRISMASPASTA("크리스마스파스타", 25000, "main"),
+
+ COKE("제로콜라", 3000, "drink"),
+ WINE("레드와인", 60000, "drink"),
+ CHAMPAGNE("샴페인", 25000, "drink"),
+
+ CAKE("초코케이크", 15000, "desert"),
+ ICECREAM("아이스크림", 5000, "desert"),
+
+ SOUP("양송이수프", 6000, "appetizer"),
+ TAPAS("타파스", 5500, "appetizer"),
+ SALAD("시저샐러드", 8000, "appetizer"),
+
+ NONE("없음", 0, "none");
+
+ private String name;
+ private int price;
+ private String type;
+
+ public String getType() {
+ return type;
+ }
+
+ public String getName() {
+ return name;
+ }
+
+ public int getPrice() {
+ return price;
+ }
+
+ Menu(String name, int price, String type) {
+ this.name = name;
+ this.price = price;
+ this.type = type;
+ }
+
+ public static Menu getMenuWithName(String menuName) {
+ return Arrays.stream(Menu.values())
+ .filter(menu -> menu.getName().equals(menuName)).findAny().get();
+ }
+
+ public static int getPriceWithName(String name) {
+ return Arrays.stream(Menu.values()).filter(Menu -> Menu.name.equals(name)).findAny()
+ .orElse(NONE).getPrice();
+ }
+
+ // Drink만 포함된 메뉴가 아니면 True
+ public static boolean isOnlyDrinkMenu(String name) {
+ return Arrays.stream(Menu.values()).filter(n -> n.getName().equals(name))
+ .allMatch(n -> n.getType().equals("drink"));
+ }
+} | Java | 람다 식의 변수명을 조금더 자세히 적어주시면 좋겠습니다 |
@@ -0,0 +1,32 @@
+package christmas.model;
+
+import christmas.domain.Menu;
+
+import java.util.Map;
+
+public class Condition {
+
+ private final static int CONDITION = 10000;
+ private final static int ORDERCOUNTCONDITION = 20;
+
+ public boolean checkEventConditionAmount(int orderAmount) {
+ if (orderAmount >= CONDITION) {
+ return true;
+ }
+ return false;
+ }
+
+ public boolean checkEventConditionMenu(Map<Menu, Integer> orderMenu) {
+ if (orderMenu.keySet().stream().allMatch(menu -> Menu.isOnlyDrinkMenu(menu.getName()))) {
+ return false;
+ }
+ return true;
+ }
+
+ public boolean checkEventConditionMenuCount(Map<Menu, Integer> orderMenu) {
+ if (orderMenu.values().stream().mapToInt(Integer::intValue).sum() > ORDERCOUNTCONDITION) {
+ return false;
+ }
+ return true;
+ }
+} | Java | `return orderAmount >= CONDITION;` 과 같이 줄여도 좋을 것 같아요 |
@@ -0,0 +1,32 @@
+package christmas.model;
+
+import christmas.domain.Menu;
+
+import java.util.Map;
+
+public class Condition {
+
+ private final static int CONDITION = 10000;
+ private final static int ORDERCOUNTCONDITION = 20;
+
+ public boolean checkEventConditionAmount(int orderAmount) {
+ if (orderAmount >= CONDITION) {
+ return true;
+ }
+ return false;
+ }
+
+ public boolean checkEventConditionMenu(Map<Menu, Integer> orderMenu) {
+ if (orderMenu.keySet().stream().allMatch(menu -> Menu.isOnlyDrinkMenu(menu.getName()))) {
+ return false;
+ }
+ return true;
+ }
+
+ public boolean checkEventConditionMenuCount(Map<Menu, Integer> orderMenu) {
+ if (orderMenu.values().stream().mapToInt(Integer::intValue).sum() > ORDERCOUNTCONDITION) {
+ return false;
+ }
+ return true;
+ }
+} | Java | 컨디션은 조건이란 뜻인데, int 변수인지라 조건이랑은 안 맞는 것 같아요.
MAX_ORDER_COUNT 같은 이름은 어떨까요 |
@@ -0,0 +1,117 @@
+package christmas.model;
+
+import christmas.domain.Holiday;
+import christmas.domain.Menu;
+
+import java.util.Arrays;
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.stream.Collectors;
+
+public class Discount {
+
+ private final static int DISCOUNTUNIT = 100;
+ private final static int CHRISTMASDATE = 25;
+ private final static int BASICDISCOUNT = 1000;
+ private final static int PERIOD = 7;
+ private final static int DISCOUNT = 2023;
+ private final static int STARTDISCOUNT = 1000;
+ private final static int NOTDISCOUNT = 0;
+ private final static int CHAMPAGNEEVENT = 120000;
+ private final static String christmasDayDiscount = "크리스마스 디데이 할인";
+ private final static String weekendDiscount = "평일 할인";
+ private final static String holidayDiscount = "주말 할인";
+ private final static String specialDiscount = "특별 할인";
+ private final static String bonusEvent = "증정 이벤트";
+
+ public Map<String, Integer> discountTotal(int date, Map<Menu, Integer> orderMenu, int payAmount) {
+ Map<String, Integer> discountResult = new LinkedHashMap<>();
+ discountInput(date, orderMenu, payAmount, discountResult);
+ return discountResult;
+ }
+
+ private void discountInput(int date, Map<Menu, Integer> orderMenu, int payAmount, Map<String, Integer> discountResult) {
+ if (discountChristmas(date) != 0) {
+ discountResult.put(christmasDayDiscount, discountChristmas(date));
+ }
+ if (discountDay(date).stream().anyMatch(menu -> orderMenu.containsKey(menu))) {
+ weekEndOrHolidayTotalDiscount(date, discountResult, discountDay(date), orderMenu);
+ }
+ if (discountStar(date) != 0) {
+ discountResult.put(specialDiscount, discountStar(date));
+ }
+ if (eventChampagne(payAmount)) {
+ discountResult.put(bonusEvent, Menu.CHAMPAGNE.getPrice());
+ }
+ }
+
+ public int discountTotalAmount(Map<String, Integer> discountTotal) {
+ return discountTotal.values().stream().mapToInt(Integer::intValue).sum();
+ }
+
+ public int discountTotalAmountExceptBonus(Map<String, Integer> discountTotal) {
+ return discountTotal.keySet().stream().filter(key -> !key.equals(bonusEvent))
+ .mapToInt(key -> discountTotal.get(key)).sum();
+ }
+
+ public void weekEndOrHolidayTotalDiscount(int date, Map<String, Integer> discountResult,
+ List<Menu> discount, Map<Menu, Integer> orderMenu) {
+ int sum = orderMenu.keySet().stream()
+ .filter(menu -> discount.contains(menu)).mapToInt(key -> orderMenu.get(key) * DISCOUNT).sum();
+ if (weekOrHoliday(date)) {
+ discountResult.put(holidayDiscount, sum);
+ return;
+ }
+ discountResult.put(weekendDiscount, sum);
+ }
+
+ public boolean eventChampagne(int orderAmount) {
+ if (orderAmount >= CHAMPAGNEEVENT) {
+ return true;
+ }
+ return false;
+ }
+
+ public int discountStar(int date) {
+ if (Arrays.stream(Holiday.values()).anyMatch(i -> i.getDate() == date)) {
+ return STARTDISCOUNT;
+ }
+ return NOTDISCOUNT;
+ }
+
+ public int discountChristmas(int date) {
+ int result = 0;
+ if (date <= CHRISTMASDATE) {
+ result = BASICDISCOUNT + DISCOUNTUNIT * (date - 1);
+ }
+ return result;
+ }
+
+ public List<Menu> discountDay(int date) {
+ if (weekOrHoliday(date)) {
+ return discountHoliday();
+ }
+ return discountWeekday();
+ }
+
+ //true : 주말 | false : 평일
+ private boolean weekOrHoliday(int date) {
+ if (date % 7 == 1 || date % 7 == 2) {
+ return true;
+ }
+ return false;
+ }
+
+ private List<Menu> discountWeekday() {
+ return Arrays.stream(Menu.values()).filter(menu -> menu != menu.NONE)
+ .filter(menu -> menu.getType().equals("desert"))
+ .collect(Collectors.toList());
+ }
+
+ private List<Menu> discountHoliday() {
+ return Arrays.stream(Menu.values()).filter(menu -> menu != menu.NONE)
+ .filter(menu -> menu.getType().equals("main"))
+ .collect(Collectors.toList());
+ }
+} | Java | 1. Menu.NONE은 static 변수이니, menu.NONE과 같이 인스턴스화한 변수에서 액세스 되면 안됩니다
2. isDesert 와 같이, Menu에게 직접 디저트냐고 물어보면 어떨까요
3. toList()로 축약할 수 있을 것 같아요
```suggestion
return Arrays.stream(Menu.values())
.filter(menu -> menu != Menu.NONE)
.filter(Menu::isDesert)
.toList();
``` |
@@ -0,0 +1,32 @@
+package christmas.model;
+
+import christmas.domain.Menu;
+
+import java.util.Map;
+
+public class Condition {
+
+ private final static int CONDITION = 10000;
+ private final static int ORDERCOUNTCONDITION = 20;
+
+ public boolean checkEventConditionAmount(int orderAmount) {
+ if (orderAmount >= CONDITION) {
+ return true;
+ }
+ return false;
+ }
+
+ public boolean checkEventConditionMenu(Map<Menu, Integer> orderMenu) {
+ if (orderMenu.keySet().stream().allMatch(menu -> Menu.isOnlyDrinkMenu(menu.getName()))) {
+ return false;
+ }
+ return true;
+ }
+
+ public boolean checkEventConditionMenuCount(Map<Menu, Integer> orderMenu) {
+ if (orderMenu.values().stream().mapToInt(Integer::intValue).sum() > ORDERCOUNTCONDITION) {
+ return false;
+ }
+ return true;
+ }
+} | Java | menu의 배열을 돌면서 모두 drink인지 판단하는 로직입니다.
allMatch에서, 갖고 있는 menu한테 drink 메뉴인지 물어보면 되는데요.
굳이 이름을 꺼내서, Menu의 static 함수한테 물어볼 필요가 없다고 생각합니다.
```java
return !orderMenu.keySet()
.stream()
.allMatch(Menu::isDrink);
``` |
@@ -0,0 +1,52 @@
+package christmas.model;
+
+import camp.nextstep.edu.missionutils.Console;
+import christmas.domain.Menu;
+import christmas.validate.Validate;
+
+import java.util.Arrays;
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;
+
+public class Input {
+
+ private static final String delimeterComma = "(,)";
+ private static final String delimeterDash = "(-)";
+
+ public int inputOrderDate() {
+ String input = Console.readLine();
+ try {
+ Validate.integerTypeValidate(input);
+ int date = Integer.parseInt(input);
+ Validate.visitDateValidate(date);
+ } catch (IllegalArgumentException e) {
+ inputOrderDate();
+ }
+ return Integer.parseInt(input);
+ }
+
+ public Map<Menu, Integer> inputOrderMenu() {
+ String input = Console.readLine();
+ try {
+ Validate.menuFormatValidate(input);
+ Validate.isOnlyDrinkValidate(input);
+ Validate.menuDuplicationValidate(input);
+ Validate.menuValidate(input);
+ Validate.menuOrderNumberValidate(input);
+ } catch (IllegalArgumentException e) {
+ inputOrderMenu();
+ }
+ return createOrder(input);
+ }
+
+ private Map<Menu, Integer> createOrder(String input) {
+ Map<Menu, Integer> result = new LinkedHashMap<>();
+ List<String[]> pair = Arrays.stream(input.trim().split(delimeterComma))
+ .map(s -> s.split(delimeterDash)).toList();
+ for (String[] strings : pair) {
+ result.put(Menu.getMenuWithName(strings[0]), Integer.parseInt(strings[1]));
+ }
+ return result;
+ }
+} | Java | Input 그 자체가 아니라 Input을 받는 클래스이기 때문에, 더 의미가 드러나는 이름이면 좋을 것 같아요 |
@@ -0,0 +1,52 @@
+package christmas.model;
+
+import camp.nextstep.edu.missionutils.Console;
+import christmas.domain.Menu;
+import christmas.validate.Validate;
+
+import java.util.Arrays;
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;
+
+public class Input {
+
+ private static final String delimeterComma = "(,)";
+ private static final String delimeterDash = "(-)";
+
+ public int inputOrderDate() {
+ String input = Console.readLine();
+ try {
+ Validate.integerTypeValidate(input);
+ int date = Integer.parseInt(input);
+ Validate.visitDateValidate(date);
+ } catch (IllegalArgumentException e) {
+ inputOrderDate();
+ }
+ return Integer.parseInt(input);
+ }
+
+ public Map<Menu, Integer> inputOrderMenu() {
+ String input = Console.readLine();
+ try {
+ Validate.menuFormatValidate(input);
+ Validate.isOnlyDrinkValidate(input);
+ Validate.menuDuplicationValidate(input);
+ Validate.menuValidate(input);
+ Validate.menuOrderNumberValidate(input);
+ } catch (IllegalArgumentException e) {
+ inputOrderMenu();
+ }
+ return createOrder(input);
+ }
+
+ private Map<Menu, Integer> createOrder(String input) {
+ Map<Menu, Integer> result = new LinkedHashMap<>();
+ List<String[]> pair = Arrays.stream(input.trim().split(delimeterComma))
+ .map(s -> s.split(delimeterDash)).toList();
+ for (String[] strings : pair) {
+ result.put(Menu.getMenuWithName(strings[0]), Integer.parseInt(strings[1]));
+ }
+ return result;
+ }
+} | Java | 링크드 해시맵으로 작성하신 이유가 있을까요? |
@@ -0,0 +1,59 @@
+package christmas.domain.order;
+
+import christmas.domain.menu.Menu;
+import christmas.error.ErrorMessage;
+import java.util.Objects;
+
+public class OrderMenu {
+
+ private static final int MIN_QUANTITY = 1;
+ private static final int MAX_QUANTITY = 20;
+
+ private final Menu menu;
+ private final int quantity;
+
+ public OrderMenu(Menu menu, int quantity) {
+ this.menu = menu;
+ if (quantity < MIN_QUANTITY || quantity > MAX_QUANTITY) {
+ throw new IllegalArgumentException(ErrorMessage.INVALID_ORDER.getMessage());
+ }
+ this.quantity = quantity;
+ }
+
+ public boolean isMenuMain() {
+ return menu.isMain();
+ }
+
+ public boolean isMenuDessert() {
+ return menu.isDessert();
+ }
+
+ public int calculatePrice() {
+ return menu.getPrice() * quantity;
+ }
+
+ public boolean isNotBeverage() {
+ return menu.isNotBeverage();
+ }
+
+ @Override
+ public boolean equals(Object o) {
+ if (this == o) return true;
+ if (o == null || getClass() != o.getClass()) return false;
+ OrderMenu orderMenu = (OrderMenu) o;
+ return menu == orderMenu.menu;
+ }
+
+ @Override
+ public int hashCode() {
+ return Objects.hash(menu);
+ }
+
+ public Menu getMenu() {
+ return menu;
+ }
+
+ public int getQuantity() {
+ return quantity;
+ }
+} | Java | OrderMenus에서 예외 처리 하신 거 같은데 여기서는 왜 하셨는지 의견이 궁금해요! |
@@ -0,0 +1,28 @@
+package christmas.domain.event;
+
+import java.util.function.Predicate;
+
+public enum EventBadge {
+
+ SANTA("산타", (amount) -> amount >= 20_000),
+ TREE("트리", (amount) -> amount >= 10_000 && amount < 20_000),
+ STAR("별", (amount) -> amount >= 5_000 && amount < 10_000),
+ MISS("없음", (amount) -> amount < 5_000);
+
+ private final String name;
+ private final Predicate<Integer> totalBenefitAmountMatcher;
+
+ EventBadge(String name, Predicate<Integer> totalBenefitAmountMatcher) {
+ this.name = name;
+ this.totalBenefitAmountMatcher = totalBenefitAmountMatcher;
+ }
+
+ public boolean matchesTotalBenefitAmount(int totalBenefitAmount) {
+ return totalBenefitAmountMatcher.test(totalBenefitAmount);
+ }
+
+ @Override
+ public String toString() {
+ return name;
+ }
+} | Java | 이걸 사용하는거랑 따로 메서드를 만들어서 사용하는것 중에 Predicate를 선택하신 이유가 궁금해요 |
@@ -0,0 +1,52 @@
+package christmas.domain;
+
+import christmas.error.ErrorMessage;
+import java.time.DayOfWeek;
+import java.time.LocalDate;
+import java.util.List;
+
+public class VisitDay {
+
+ private static final int MIN_VISIT_DAY = 1;
+ private static final int MAX_VISIT_DAY = 31;
+ private static final int EVENT_YEAR = 2023;
+ private static final int EVENT_MONTH = 12;
+
+ private final int visitDay;
+
+ public VisitDay(int visitDay) {
+ validate(visitDay);
+ this.visitDay = visitDay;
+ }
+
+ private void validate(int visitDay) {
+ if (invalidDay(visitDay)) {
+ throw new IllegalArgumentException(ErrorMessage.INVALID_VISIT_DAY.getMessage());
+ }
+ }
+
+ private boolean invalidDay(int visitDay) {
+ return visitDay < MIN_VISIT_DAY || visitDay > MAX_VISIT_DAY;
+ }
+
+ public boolean isNotWithinChristmasPeriod(int christmasDDay) {
+ return visitDay < MIN_VISIT_DAY || visitDay > christmasDDay;
+ }
+
+ public int decreaseOneDay() {
+ return visitDay - 1;
+ }
+
+ public boolean isWeekend() {
+ DayOfWeek visitDayOfWeek = LocalDate.of(EVENT_YEAR, EVENT_MONTH, visitDay).getDayOfWeek();
+ return visitDayOfWeek == DayOfWeek.FRIDAY || visitDayOfWeek == DayOfWeek.SATURDAY;
+ }
+
+ public boolean isNotSpecialDay(List<Integer> specialDays) {
+ return !specialDays.contains(visitDay);
+ }
+
+ public int getVisitDay() {
+ return visitDay;
+ }
+} | Java | 요청할 때마다 `DayOfWeek`를 만드는데 아니라 객체 생성시에 미리 만들어 놓은 다음에 쓰는건 어떨까요? 어짜피 visitDay는 안바뀌니까요. |
@@ -0,0 +1,57 @@
+package christmas.domain.menu;
+
+import christmas.error.ErrorMessage;
+import java.util.Arrays;
+
+public enum Menu {
+
+ MUSHROOM_SOUP("양송이 수프", 6_000, MenuCategory.APPETIZER),
+ TAPAS("타파스", 5_500, MenuCategory.APPETIZER),
+ CAESAR_SALAD("시저샐러드", 8_000, MenuCategory.APPETIZER),
+ T_BONE_STEAK("티본스테이크", 55_000, MenuCategory.MAIN),
+ BARBECUE_RIBS("바비큐립", 54_000, MenuCategory.MAIN),
+ SEAFOOD_PASTA("해산물파스타", 35_000, MenuCategory.MAIN),
+ CHRISTMAS_PASTA("크리스마스파스타", 25_000, MenuCategory.MAIN),
+ CHOCOLATE_CAKE("초코케이크", 15_000, MenuCategory.DESSERT),
+ ICE_CREAM("아이스크림", 5_000, MenuCategory.DESSERT),
+ COKE_ZERO("제로콜라", 3_000, MenuCategory.BEVERAGE),
+ RED_WINE("레드와인", 60_000, MenuCategory.BEVERAGE),
+ CHAMPAGNE("샴페인", 25_000, MenuCategory.BEVERAGE);
+
+ private final String name;
+ private final int price;
+ private final MenuCategory category;
+
+ Menu(String name, int price, MenuCategory category) {
+ this.name = name;
+ this.price = price;
+ this.category = category;
+ }
+
+ public static Menu from(String menuName) {
+ return Arrays.stream(Menu.values())
+ .filter(menu -> menu.name.equals(menuName))
+ .findFirst()
+ .orElseThrow(() -> new IllegalArgumentException(ErrorMessage.INVALID_ORDER.getMessage()));
+ }
+
+ public boolean isMain() {
+ return this.category == MenuCategory.MAIN;
+ }
+
+ public boolean isDessert() {
+ return this.category == MenuCategory.DESSERT;
+ }
+
+ public boolean isNotBeverage() {
+ return this.category != MenuCategory.BEVERAGE;
+ }
+
+ public String getName() {
+ return name;
+ }
+
+ public int getPrice() {
+ return price;
+ }
+} | Java | 객체를 객체답게 사용하신 코드네요! |
@@ -0,0 +1,59 @@
+package christmas.domain.order;
+
+import christmas.domain.menu.Menu;
+import christmas.error.ErrorMessage;
+import java.util.Objects;
+
+public class OrderMenu {
+
+ private static final int MIN_QUANTITY = 1;
+ private static final int MAX_QUANTITY = 20;
+
+ private final Menu menu;
+ private final int quantity;
+
+ public OrderMenu(Menu menu, int quantity) {
+ this.menu = menu;
+ if (quantity < MIN_QUANTITY || quantity > MAX_QUANTITY) {
+ throw new IllegalArgumentException(ErrorMessage.INVALID_ORDER.getMessage());
+ }
+ this.quantity = quantity;
+ }
+
+ public boolean isMenuMain() {
+ return menu.isMain();
+ }
+
+ public boolean isMenuDessert() {
+ return menu.isDessert();
+ }
+
+ public int calculatePrice() {
+ return menu.getPrice() * quantity;
+ }
+
+ public boolean isNotBeverage() {
+ return menu.isNotBeverage();
+ }
+
+ @Override
+ public boolean equals(Object o) {
+ if (this == o) return true;
+ if (o == null || getClass() != o.getClass()) return false;
+ OrderMenu orderMenu = (OrderMenu) o;
+ return menu == orderMenu.menu;
+ }
+
+ @Override
+ public int hashCode() {
+ return Objects.hash(menu);
+ }
+
+ public Menu getMenu() {
+ return menu;
+ }
+
+ public int getQuantity() {
+ return quantity;
+ }
+} | Java | eqauls()에 대해 공부를 많이 하셨네요! hashCode까지 다시 구현하신거 인상깊습니다! |
@@ -0,0 +1,51 @@
+package christmas.service;
+
+import christmas.domain.BenefitDetails;
+import christmas.domain.ExpectedPaymentAmountCalculator;
+import christmas.domain.event.EventBadge;
+import christmas.domain.event.EventBadgeAssigner;
+import christmas.domain.menu.Menu;
+import christmas.domain.order.OrderMenu;
+import christmas.domain.order.OrderMenus;
+import christmas.dto.OrderMenusDto;
+import java.util.List;
+import java.util.stream.Collectors;
+
+public class Service {
+
+ private final ExpectedPaymentAmountCalculator expectedPaymentAmountCalculator;
+ private final EventBadgeAssigner eventBadgeAssigner;
+
+ public Service(
+ ExpectedPaymentAmountCalculator expectedPaymentAmountCalculator,
+ EventBadgeAssigner eventBadgeAssigner) {
+ this.expectedPaymentAmountCalculator = expectedPaymentAmountCalculator;
+ this.eventBadgeAssigner = eventBadgeAssigner;
+ }
+
+ public OrderMenus order(OrderMenusDto orderMenusDto) {
+ return new OrderMenus(convertToOrderMenuList(orderMenusDto));
+ }
+
+ private List<OrderMenu> convertToOrderMenuList(OrderMenusDto orderMenusDto) {
+ return orderMenusDto.getMenus().entrySet()
+ .stream()
+ .map(orderMenus -> new OrderMenu(Menu.from(orderMenus.getKey()), orderMenus.getValue()))
+ .collect(Collectors.toList());
+ }
+
+ public int calculateTotalOrderAmount(OrderMenus orderMenus) {
+ return orderMenus.calculateTotalOrderAmount();
+ }
+
+ public int calculateExpectedPaymentAmount(OrderMenus orderMenus, BenefitDetails benefitDetails) {
+ return expectedPaymentAmountCalculator.calculateExpectedPaymentAmount(
+ orderMenus.calculateTotalOrderAmount(),
+ benefitDetails.calculateTotalBenefitAmount()
+ );
+ }
+
+ public EventBadge assignEventBadge(BenefitDetails benefitDetails) {
+ return eventBadgeAssigner.assignEventBadge(benefitDetails.calculateTotalBenefitAmount());
+ }
+} | Java | 전반적으로 여러 곳에서 stream을 잘 쓰셔서 드릴 말씀이 없네요;; 추가적으로 이야기만 드리면 stream에서 `( )` 안이 길다면 메서드로 분리하는 것을 추천드립니다.
```java
private List<OrderMenu> convertToOrderMenuList(OrderMenusDto orderMenusDto) {
return orderMenusDto.getMenus().entrySet()
.stream()
.map(this::convertToOrderMenu)
.collect(Collectors.toList());
}
private OrderMenu convertToOrderMenu(OrderMenuDto orderMenu) {
return new OrderMenu(Menu.from(orderMenu.getKey()), orderMenu.getValue())
}
``` |
@@ -0,0 +1,35 @@
+package christmas.dto;
+
+import christmas.domain.order.OrderMenu;
+import christmas.domain.order.OrderMenus;
+import java.util.Map;
+import java.util.stream.Collectors;
+
+public class OrderMenusDto {
+
+ private final Map<String, Integer> menus;
+
+ private OrderMenusDto(OrderMenus orderMenus) {
+ this.menus = orderMenus.getOrderMenus()
+ .stream()
+ .collect(Collectors.toMap(
+ orderMenu -> orderMenu.getMenu().getName(),
+ OrderMenu::getQuantity));
+ }
+
+ private OrderMenusDto(Map<String, Integer> inputOrderMenus) {
+ this.menus = inputOrderMenus;
+ }
+
+ public static OrderMenusDto from(OrderMenus orderMenus) {
+ return new OrderMenusDto(orderMenus);
+ }
+
+ public static OrderMenusDto from(Map<String, Integer> inputOrderMenus) {
+ return new OrderMenusDto(inputOrderMenus);
+ }
+
+ public Map<String, Integer> getMenus() {
+ return menus;
+ }
+} | Java | OrderMenuDto 객체를 생성하는 메서드를 해당 클래스 내부에 정적으로 선언하셨군요! 참신한 방법이네요 🫢
저는 재모님 코드로 치면 OrderMenus 객체 내부에 toDto() 메서드로 OrderMenusDto 객체를 반환하게 했는데, 재모님은 어떤 이점을 생각하셔서 이 방법으로 구현하셨는지 궁금합니다! 😊 (저도 다음에 써먹어 보려구요 :-)) |
@@ -0,0 +1,92 @@
+package constants;
+
+public class Menus {
+
+ public enum Appetizer {
+
+ BUTTON_MUSHROOM_SOUP("양송이수프",6000),
+ TAPAS("타파스",5500),
+ CAESAR_SALAD("시저샐러드",8000);
+
+ private final String dish;
+ private final int price;
+
+ Appetizer(String dish,int price) {
+ this.dish=dish;
+ this.price=price;
+ }
+
+ public String appetizer() {
+ return dish;
+ }
+ public int price() {
+ return price;
+ }
+ }
+
+ public enum MainMenu {
+
+ TBONE_STEAK("티본스테이크",55000),
+ BARBECUE_RIP("바비큐립",54000),
+ SEAFOOD_PASTA("해산물파스타",35000),
+ CHRISTRMAS_PASTA("크리스마스파스타",25000);
+
+ private final String dish;
+ private final int price;
+
+ MainMenu(String dish,int price) {
+ this.dish=dish;
+ this.price=price;
+ }
+
+ public String main() {
+ return dish;
+ }
+ public int price() {
+ return price;
+ }
+ }
+
+ public enum Dessert {
+
+ CHOCOLATE_CAKE("초코케이크",15000),
+ ICECREAM("아이스크림",5000);
+
+ private final String dish;
+ private final int price;
+
+ Dessert(String dish,int price) {
+ this.dish=dish;
+ this.price=price;
+ }
+
+ public String dessert() {
+ return dish;
+ }
+ public int price() {
+ return price;
+ }
+ }
+
+ public enum Beverage {
+
+ ZERO_COLA("제로콜라",3000),
+ RED_WINE("레드와인",60000),
+ CHAMPAGNE("샴페인",25000);
+
+ private final String dish;
+ private final int price;
+
+ Beverage(String dish,int price) {
+ this.dish=dish;
+ this.price=price;
+ }
+
+ public String beverage() {
+ return dish;
+ }
+ public int price() {
+ return price;
+ }
+ }
+} | Java | 열거체마다 중복 코드가 있는 것 같아요! 차라리 열거체에 `MenuType`같은 필드를 추가하여 하나로 통일하는건 어떨까요? |
@@ -0,0 +1,25 @@
+package constants;
+
+import creator.ObjectCreator;
+
+public class Constants {
+
+ //input 오류
+ public final static String INVALID_DATE_OUTPUT=ErrorMessages.INVALID_DATE_OUTPUT.detected();
+ public final static String INVALID_MENU_OUTPUT=ErrorMessages.INVALID_MENU_OUTPUT.detected();
+
+ //할인가정보
+ public final static int D_DAY_DISCOUNT_BASIC=-1000;
+ public final static int D_DAY_DISCOUNT_PER_DAY=-100;
+ public final static int WEEK_DISCOUNT=-2023;
+ public final static int SPECIAL_DISCOUNT=-1000;
+ public final static int DISCOUNT_TYPES_CNT=4;
+
+ public final static int DAYS_OF_A_WEEK=7;
+ public final static int SUNDAY_METER=3;
+ public final static int SATURDAY_METER=2;
+ public final static int FRIDAY_METER=1;
+ public final static int DATE_OF_CHRISTMAS=25;
+
+ public final static ObjectCreator CREATE=new ObjectCreator();
+} | Java | 이 값을 `Constants`에 포함시킨 이유가 있으실까요? 외부에서 `ErrorMessages`를 통해 사용해도 충분할 것 같습니다! |
@@ -0,0 +1,40 @@
+package creator;
+
+import data.EventData;
+import features.Controller;
+import features.Input;
+import features.Statistics;
+import features.Validator;
+import view.InputView;
+import view.OutputView;
+
+public class ObjectCreator {
+
+ public EventData dto() {
+ return new EventData();
+ }
+
+ public Input input() {
+ return new Input();
+ }
+
+ public Validator valid() {
+ return new Validator();
+ }
+
+ public InputView reader() {
+ return new InputView();
+ }
+
+ public OutputView announcer() {
+ return new OutputView();
+ }
+
+ public Statistics stat(EventData dto) {
+ return new Statistics(dto);
+ }
+
+ public Controller player() {
+ return new Controller();
+ }
+} | Java | 메서드명이 너무 축약된 것 같아요! `create` + 객체명 과 같이 의미가 명확한 네이밍은 어떨까요? (e.g. `cretaeOutputView`) |
@@ -0,0 +1,163 @@
+package features;
+
+import java.util.Map;
+
+import constants.Menus.Appetizer;
+import constants.Menus.Beverage;
+import constants.Menus.Dessert;
+import constants.Menus.MainMenu;
+import data.EventData;
+
+import static constants.Constants.*;
+
+public class Statistics {
+
+ public Statistics(EventData dto) {
+ this.visitDate=dto.getVisitDate();
+ this.orders=dto.getOrders();
+ this.day_week_meter=visitDate%DAYS_OF_A_WEEK;
+ }
+
+ private Map<String, Integer> orders;
+ private int visitDate;
+ private int day_week_meter;
+
+ //처리요구 데이터
+ private int totalCostOrigin;
+ private int totalDiscount;
+ private int[] discountDetails=new int[5];
+
+ private int dessertOrderedCnt;
+ private int mainMenuOrderedCnt;
+
+ //증정메뉴
+ public boolean deserveGift() {
+ if(totalCostOrigin>=120000) {
+ return true;
+ }
+ return false;
+ }
+
+ //할인전 총주문금액
+ public int getTotalCostOrigin() {
+ for(Map.Entry<String, Integer> order:orders.entrySet()) {
+ getSum(order.getKey(), order.getValue());
+ }
+ return totalCostOrigin;
+ }
+
+ private void getSum(String dish,int servings) {
+ appetizerCost(dish, servings);
+ mainMenuCost(dish, servings);
+ dessertCost(dish, servings);
+ beverageCost(dish, servings);
+ }
+
+ private void appetizerCost(String dish,int servings) {
+ for(Appetizer ap:Appetizer.values()) {
+ if(ap.appetizer().equals(dish)) {
+ totalCostOrigin+=servings*ap.price();
+ }
+ }
+ }
+
+ private void mainMenuCost(String dish,int servings) {
+ for(MainMenu ma:MainMenu.values()) {
+ if(ma.main().equals(dish)) {
+ totalCostOrigin+=servings*ma.price();
+ mainMenuOrderedCnt+=servings;
+ }
+ }
+ }
+
+ private void dessertCost(String dish,int servings) {
+ for(Dessert de:Dessert.values()) {
+ if(de.dessert().equals(dish)) {
+ totalCostOrigin+=servings*de.price();
+ dessertOrderedCnt+=servings;
+ }
+ }
+ }
+
+ private void beverageCost(String dish,int servings) {
+ for(Beverage be:Beverage.values()) {
+ if(be.beverage().equals(dish)) {
+ totalCostOrigin+=servings*be.price();
+ }
+ }
+ }
+
+ //혜택내역
+ public int[] getDiscountDetails() {
+ discountDetails[0]=d_dayDiscount();
+ discountDetails[1]=weekDiscount();
+ discountDetails[2]=specialDiscount();
+ discountDetails[3]=giftDiscount();
+
+ return discountDetails;
+ }
+
+ private int d_dayDiscount() {
+ if(visitDate<=25) {
+ return D_DAY_DISCOUNT_BASIC+(visitDate-1)*D_DAY_DISCOUNT_PER_DAY;
+ }
+ return 0;
+ }
+
+ private int weekDiscount() {
+ if(isWeekend()) {
+ discountDetails[4]=1;
+ return mainMenuOrderedCnt*WEEK_DISCOUNT;
+ }
+ discountDetails[4]=0;
+ return dessertOrderedCnt*WEEK_DISCOUNT;
+ }
+
+ private boolean isWeekend() {
+ if(day_week_meter==FRIDAY_METER||day_week_meter==SATURDAY_METER) {
+ return true;
+ }
+ return false;
+ }
+
+ private int specialDiscount() {
+ if(day_week_meter==SUNDAY_METER||visitDate==DATE_OF_CHRISTMAS) {
+ return SPECIAL_DISCOUNT;
+ }
+ return 0;
+ }
+
+ private int giftDiscount() {
+ if(deserveGift()) {
+ return -Beverage.CHAMPAGNE.price();
+ }
+ return 0;
+ }
+
+ //총혜택금액
+ public int getTotalDiscount() {
+ for(int i=0;i<DISCOUNT_TYPES_CNT;i++) {
+ totalDiscount+=discountDetails[i];
+ }
+ return totalDiscount;
+ }
+
+ //할인후 예상결제금액
+ public int getResultCost() {
+ return totalCostOrigin+totalDiscount;
+ }
+
+ //이벤트 배지
+ public String badgeReceivable() {
+ if(-totalDiscount>=5000&&-totalDiscount<10000) {
+ return "별";
+ }
+ if(-totalDiscount>=10000&&-totalDiscount<20000) {
+ return "트리";
+ }
+ if(-totalDiscount>=20000) {
+ return "산타";
+ }
+ return "없음";
+ }
+} | Java | 수식을 반환해도 될 것 같아요!
```java
return totalCostOrigin >= 120000;
``` |
@@ -0,0 +1,163 @@
+package features;
+
+import java.util.Map;
+
+import constants.Menus.Appetizer;
+import constants.Menus.Beverage;
+import constants.Menus.Dessert;
+import constants.Menus.MainMenu;
+import data.EventData;
+
+import static constants.Constants.*;
+
+public class Statistics {
+
+ public Statistics(EventData dto) {
+ this.visitDate=dto.getVisitDate();
+ this.orders=dto.getOrders();
+ this.day_week_meter=visitDate%DAYS_OF_A_WEEK;
+ }
+
+ private Map<String, Integer> orders;
+ private int visitDate;
+ private int day_week_meter;
+
+ //처리요구 데이터
+ private int totalCostOrigin;
+ private int totalDiscount;
+ private int[] discountDetails=new int[5];
+
+ private int dessertOrderedCnt;
+ private int mainMenuOrderedCnt;
+
+ //증정메뉴
+ public boolean deserveGift() {
+ if(totalCostOrigin>=120000) {
+ return true;
+ }
+ return false;
+ }
+
+ //할인전 총주문금액
+ public int getTotalCostOrigin() {
+ for(Map.Entry<String, Integer> order:orders.entrySet()) {
+ getSum(order.getKey(), order.getValue());
+ }
+ return totalCostOrigin;
+ }
+
+ private void getSum(String dish,int servings) {
+ appetizerCost(dish, servings);
+ mainMenuCost(dish, servings);
+ dessertCost(dish, servings);
+ beverageCost(dish, servings);
+ }
+
+ private void appetizerCost(String dish,int servings) {
+ for(Appetizer ap:Appetizer.values()) {
+ if(ap.appetizer().equals(dish)) {
+ totalCostOrigin+=servings*ap.price();
+ }
+ }
+ }
+
+ private void mainMenuCost(String dish,int servings) {
+ for(MainMenu ma:MainMenu.values()) {
+ if(ma.main().equals(dish)) {
+ totalCostOrigin+=servings*ma.price();
+ mainMenuOrderedCnt+=servings;
+ }
+ }
+ }
+
+ private void dessertCost(String dish,int servings) {
+ for(Dessert de:Dessert.values()) {
+ if(de.dessert().equals(dish)) {
+ totalCostOrigin+=servings*de.price();
+ dessertOrderedCnt+=servings;
+ }
+ }
+ }
+
+ private void beverageCost(String dish,int servings) {
+ for(Beverage be:Beverage.values()) {
+ if(be.beverage().equals(dish)) {
+ totalCostOrigin+=servings*be.price();
+ }
+ }
+ }
+
+ //혜택내역
+ public int[] getDiscountDetails() {
+ discountDetails[0]=d_dayDiscount();
+ discountDetails[1]=weekDiscount();
+ discountDetails[2]=specialDiscount();
+ discountDetails[3]=giftDiscount();
+
+ return discountDetails;
+ }
+
+ private int d_dayDiscount() {
+ if(visitDate<=25) {
+ return D_DAY_DISCOUNT_BASIC+(visitDate-1)*D_DAY_DISCOUNT_PER_DAY;
+ }
+ return 0;
+ }
+
+ private int weekDiscount() {
+ if(isWeekend()) {
+ discountDetails[4]=1;
+ return mainMenuOrderedCnt*WEEK_DISCOUNT;
+ }
+ discountDetails[4]=0;
+ return dessertOrderedCnt*WEEK_DISCOUNT;
+ }
+
+ private boolean isWeekend() {
+ if(day_week_meter==FRIDAY_METER||day_week_meter==SATURDAY_METER) {
+ return true;
+ }
+ return false;
+ }
+
+ private int specialDiscount() {
+ if(day_week_meter==SUNDAY_METER||visitDate==DATE_OF_CHRISTMAS) {
+ return SPECIAL_DISCOUNT;
+ }
+ return 0;
+ }
+
+ private int giftDiscount() {
+ if(deserveGift()) {
+ return -Beverage.CHAMPAGNE.price();
+ }
+ return 0;
+ }
+
+ //총혜택금액
+ public int getTotalDiscount() {
+ for(int i=0;i<DISCOUNT_TYPES_CNT;i++) {
+ totalDiscount+=discountDetails[i];
+ }
+ return totalDiscount;
+ }
+
+ //할인후 예상결제금액
+ public int getResultCost() {
+ return totalCostOrigin+totalDiscount;
+ }
+
+ //이벤트 배지
+ public String badgeReceivable() {
+ if(-totalDiscount>=5000&&-totalDiscount<10000) {
+ return "별";
+ }
+ if(-totalDiscount>=10000&&-totalDiscount<20000) {
+ return "트리";
+ }
+ if(-totalDiscount>=20000) {
+ return "산타";
+ }
+ return "없음";
+ }
+} | Java | 배지 발급은 다른 객체에서 처리해도 좋을 것 같아요! |
@@ -0,0 +1,163 @@
+package features;
+
+import java.util.Map;
+
+import constants.Menus.Appetizer;
+import constants.Menus.Beverage;
+import constants.Menus.Dessert;
+import constants.Menus.MainMenu;
+import data.EventData;
+
+import static constants.Constants.*;
+
+public class Statistics {
+
+ public Statistics(EventData dto) {
+ this.visitDate=dto.getVisitDate();
+ this.orders=dto.getOrders();
+ this.day_week_meter=visitDate%DAYS_OF_A_WEEK;
+ }
+
+ private Map<String, Integer> orders;
+ private int visitDate;
+ private int day_week_meter;
+
+ //처리요구 데이터
+ private int totalCostOrigin;
+ private int totalDiscount;
+ private int[] discountDetails=new int[5];
+
+ private int dessertOrderedCnt;
+ private int mainMenuOrderedCnt;
+
+ //증정메뉴
+ public boolean deserveGift() {
+ if(totalCostOrigin>=120000) {
+ return true;
+ }
+ return false;
+ }
+
+ //할인전 총주문금액
+ public int getTotalCostOrigin() {
+ for(Map.Entry<String, Integer> order:orders.entrySet()) {
+ getSum(order.getKey(), order.getValue());
+ }
+ return totalCostOrigin;
+ }
+
+ private void getSum(String dish,int servings) {
+ appetizerCost(dish, servings);
+ mainMenuCost(dish, servings);
+ dessertCost(dish, servings);
+ beverageCost(dish, servings);
+ }
+
+ private void appetizerCost(String dish,int servings) {
+ for(Appetizer ap:Appetizer.values()) {
+ if(ap.appetizer().equals(dish)) {
+ totalCostOrigin+=servings*ap.price();
+ }
+ }
+ }
+
+ private void mainMenuCost(String dish,int servings) {
+ for(MainMenu ma:MainMenu.values()) {
+ if(ma.main().equals(dish)) {
+ totalCostOrigin+=servings*ma.price();
+ mainMenuOrderedCnt+=servings;
+ }
+ }
+ }
+
+ private void dessertCost(String dish,int servings) {
+ for(Dessert de:Dessert.values()) {
+ if(de.dessert().equals(dish)) {
+ totalCostOrigin+=servings*de.price();
+ dessertOrderedCnt+=servings;
+ }
+ }
+ }
+
+ private void beverageCost(String dish,int servings) {
+ for(Beverage be:Beverage.values()) {
+ if(be.beverage().equals(dish)) {
+ totalCostOrigin+=servings*be.price();
+ }
+ }
+ }
+
+ //혜택내역
+ public int[] getDiscountDetails() {
+ discountDetails[0]=d_dayDiscount();
+ discountDetails[1]=weekDiscount();
+ discountDetails[2]=specialDiscount();
+ discountDetails[3]=giftDiscount();
+
+ return discountDetails;
+ }
+
+ private int d_dayDiscount() {
+ if(visitDate<=25) {
+ return D_DAY_DISCOUNT_BASIC+(visitDate-1)*D_DAY_DISCOUNT_PER_DAY;
+ }
+ return 0;
+ }
+
+ private int weekDiscount() {
+ if(isWeekend()) {
+ discountDetails[4]=1;
+ return mainMenuOrderedCnt*WEEK_DISCOUNT;
+ }
+ discountDetails[4]=0;
+ return dessertOrderedCnt*WEEK_DISCOUNT;
+ }
+
+ private boolean isWeekend() {
+ if(day_week_meter==FRIDAY_METER||day_week_meter==SATURDAY_METER) {
+ return true;
+ }
+ return false;
+ }
+
+ private int specialDiscount() {
+ if(day_week_meter==SUNDAY_METER||visitDate==DATE_OF_CHRISTMAS) {
+ return SPECIAL_DISCOUNT;
+ }
+ return 0;
+ }
+
+ private int giftDiscount() {
+ if(deserveGift()) {
+ return -Beverage.CHAMPAGNE.price();
+ }
+ return 0;
+ }
+
+ //총혜택금액
+ public int getTotalDiscount() {
+ for(int i=0;i<DISCOUNT_TYPES_CNT;i++) {
+ totalDiscount+=discountDetails[i];
+ }
+ return totalDiscount;
+ }
+
+ //할인후 예상결제금액
+ public int getResultCost() {
+ return totalCostOrigin+totalDiscount;
+ }
+
+ //이벤트 배지
+ public String badgeReceivable() {
+ if(-totalDiscount>=5000&&-totalDiscount<10000) {
+ return "별";
+ }
+ if(-totalDiscount>=10000&&-totalDiscount<20000) {
+ return "트리";
+ }
+ if(-totalDiscount>=20000) {
+ return "산타";
+ }
+ return "없음";
+ }
+} | Java | 너무 많은 역할을 하는 것 같아요! 일부 기능들은 다른 객체에 위임하는건 어떨까요? |
@@ -0,0 +1,17 @@
+package christmas.domain.menu
+
+import christmas.exception.OrdersException
+
+data class MenuCount(private val count: Int) {
+ init {
+ require(count >= 1) { OrdersException.INVALID.message }
+ }
+
+ fun getCount() = count
+
+ override fun toString(): String = "%,d$UNIT_SUFFIX".format(count)
+
+ companion object {
+ private const val UNIT_SUFFIX = "개"
+ }
+}
\ No newline at end of file | Kotlin | val 선언 때문에 따로 private로 제한하지 않아도 값 수정이 불가능할텐데, 혹시 private로 선언한 이유가 따로 있을까요..?! |
@@ -0,0 +1,29 @@
+package christmas.domain
+
+import christmas.exception.DecemberDayException
+
+data class DecemberDay(private val day: Int) {
+ init {
+ require(day in DAY_START..DAY_END) { DecemberDayException.INVALID.message }
+ }
+
+ fun hasPassedChristmas() = day > DAY_CHRISTMAS
+ fun getDaySinceStartOfMonth() = day - DAY_START
+ fun isWeekEnd() = day in WEEKENDS
+ fun isSpecialDay() = day in SPECIAL_DAYS
+ override fun toString(): String = "%d${UNIT_SUFFIX}".format(day)
+
+ companion object {
+ private const val DAY_START = 1
+ private const val DAY_END = 31
+ private const val DAY_CHRISTMAS = 25
+ private const val UNIT_SUFFIX = "일"
+ private val WEEKENDS = listOf(1, 2, 8, 9, 15, 16, 22, 23, 29, 30)
+ private val SPECIAL_DAYS = listOf(3, 10, 17, 24, 25, 31)
+
+ fun fromString(input: String): DecemberDay {
+ val day = requireNotNull(input.toIntOrNull()) { DecemberDayException.INVALID.message }
+ return DecemberDay(day)
+ }
+ }
+}
\ No newline at end of file | Kotlin | 이부분은 fromString 보다는 checkDay가 좀더 자연스러워 보입니다..!! 개인적으로 fromString을 보면 toString처럼 String 포맷 함수처럼 보여요..!! |
@@ -0,0 +1,90 @@
+package christmas.domain
+
+import christmas.domain.benefit.Benefit
+import christmas.domain.benefit.BenefitType
+import christmas.domain.benefit.Benefits
+import christmas.domain.menu.*
+
+class DecemberEvent {
+
+ fun getFreeGift(totalOrderAmount: Money): FreeGift? {
+ if (!totalOrderAmount.isGreaterOrEqual(MIN_ORDER_AMOUNT_FOR_FREE_GIFT)) return null
+ return FreeGift(FREE_GIFT_MENU, FREE_GIFT_MENU_COUNT)
+ }
+
+ fun getBenefits(reservationDay: DecemberDay, reservationOrders: Orders): Benefits? {
+ val totalOrderAmount = reservationOrders.getTotalOrderAmount()
+ if (!totalOrderAmount.isGreaterOrEqual(MIN_ORDER_AMOUNT_FOR_EVENT)) return null
+
+ val benefits = listOfNotNull(
+ getChristmasDDayDiscountBenefit(reservationDay),
+ getWeekDayDiscountBenefit(reservationDay, reservationOrders),
+ getWeekEndDiscountBenefit(reservationDay, reservationOrders),
+ getSpecialDiscountBenefit(reservationDay),
+ getFreeGiftBenefit(totalOrderAmount)
+ )
+ return benefits.takeIf { it.isNotEmpty() }?.let { Benefits(it) }
+ }
+
+ private fun getChristmasDDayDiscountBenefit(reservationDay: DecemberDay): Benefit? {
+ if (reservationDay.hasPassedChristmas()) return null
+ val daySinceStartOfMonth = reservationDay.getDaySinceStartOfMonth()
+ val discountPerDay = DISCOUNT_CHRISTMAS_PER_D_DAY.multiplyBy(daySinceStartOfMonth)
+ val discountAmount = DISCOUNT_CHRISTMAS_START_D_DAY.plus(discountPerDay)
+ return Benefit(BENEFIT_CHRISTMAS_D_DAY_TYPE, BENEFIT_CHRISTMAS_D_DAY_TITLE, discountAmount)
+ }
+
+ private fun getWeekDayDiscountBenefit(reservationDay: DecemberDay, reservationOrders: Orders): Benefit? {
+ if (reservationDay.isWeekEnd()) return null
+ val discountMenuCount = reservationOrders.getMenuCountInCategory(WEEKDAY_DISCOUNT_CATEGORY) ?: return null
+ val discountAmount = DISCOUNT_WEEKDAY_PER_MENU.multiplyBy(discountMenuCount.getCount())
+ return Benefit(BENEFIT_WEEKDAY_TYPE, BENEFIT_WEEKDAY_TITLE, discountAmount)
+ }
+
+ private fun getWeekEndDiscountBenefit(reservationDay: DecemberDay, reservationOrders: Orders): Benefit? {
+ if (!reservationDay.isWeekEnd()) return null
+ val discountMenuCount = reservationOrders.getMenuCountInCategory(WEEKEND_DISCOUNT_CATEGORY) ?: return null
+ val discountAmount = DISCOUNT_WEEKEND_PER_MENU.multiplyBy(discountMenuCount.getCount())
+ return Benefit(BENEFIT_WEEKEND_TYPE, BENEFIT_WEEKEND_TITLE, discountAmount)
+ }
+
+ private fun getSpecialDiscountBenefit(reservationDay: DecemberDay): Benefit? {
+ if (!reservationDay.isSpecialDay()) return null
+ return Benefit(BENEFIT_SPECIAL_TYPE, BENEFIT_SPECIAL_TITLE, DISCOUNT_SPECIAL)
+ }
+
+ private fun getFreeGiftBenefit(totalOrderAmount: Money): Benefit? {
+ val freeGift = getFreeGift(totalOrderAmount) ?: return null
+ val benefitAmount = freeGift.getTotalPrice()
+ return Benefit(BENEFIT_FREE_GIFT_TYPE, BENEFIT_FREE_GIFT_TITLE, benefitAmount.toNegative())
+ }
+
+ companion object {
+ private val MIN_ORDER_AMOUNT_FOR_EVENT = Money(10000)
+
+ private const val BENEFIT_CHRISTMAS_D_DAY_TITLE = "크리스마스 디데이"
+ private val BENEFIT_CHRISTMAS_D_DAY_TYPE = BenefitType.DISCOUNT
+ private val DISCOUNT_CHRISTMAS_START_D_DAY = Money(-1000)
+ private val DISCOUNT_CHRISTMAS_PER_D_DAY = Money(-100)
+
+ private const val BENEFIT_WEEKDAY_TITLE = "평일"
+ private val BENEFIT_WEEKDAY_TYPE = BenefitType.DISCOUNT
+ private val WEEKDAY_DISCOUNT_CATEGORY = MenuCategory.DESSERT
+ private val DISCOUNT_WEEKDAY_PER_MENU = Money(-2023)
+
+ private const val BENEFIT_WEEKEND_TITLE = "주말"
+ private val BENEFIT_WEEKEND_TYPE = BenefitType.DISCOUNT
+ private val WEEKEND_DISCOUNT_CATEGORY = MenuCategory.MAIN
+ private val DISCOUNT_WEEKEND_PER_MENU = Money(-2023)
+
+ private const val BENEFIT_SPECIAL_TITLE = "특별"
+ private val BENEFIT_SPECIAL_TYPE = BenefitType.DISCOUNT
+ private val DISCOUNT_SPECIAL = Money(-1000)
+
+ private const val BENEFIT_FREE_GIFT_TITLE = "증정"
+ private val BENEFIT_FREE_GIFT_TYPE = BenefitType.EVENT
+ private val FREE_GIFT_MENU = Menu.CHAMPAGNE
+ private val FREE_GIFT_MENU_COUNT = MenuCount(1)
+ private val MIN_ORDER_AMOUNT_FOR_FREE_GIFT = Money(120000)
+ }
+}
\ No newline at end of file | Kotlin | 코드를 다루는 관점에 따라 다르겠지만, 저는 자바와 코틀린의 가장 큰 차이점은 null 안정성이라고 생각합니다..!!
non-null type이 디폴트인 코틀린의 장점을 살려서, 되도록이면 null을 반환하지 않도록 고민해봐도 좋을거같아요!!😊😊 |
@@ -0,0 +1,90 @@
+package christmas.domain
+
+import christmas.domain.benefit.Benefit
+import christmas.domain.benefit.BenefitType
+import christmas.domain.benefit.Benefits
+import christmas.domain.menu.*
+
+class DecemberEvent {
+
+ fun getFreeGift(totalOrderAmount: Money): FreeGift? {
+ if (!totalOrderAmount.isGreaterOrEqual(MIN_ORDER_AMOUNT_FOR_FREE_GIFT)) return null
+ return FreeGift(FREE_GIFT_MENU, FREE_GIFT_MENU_COUNT)
+ }
+
+ fun getBenefits(reservationDay: DecemberDay, reservationOrders: Orders): Benefits? {
+ val totalOrderAmount = reservationOrders.getTotalOrderAmount()
+ if (!totalOrderAmount.isGreaterOrEqual(MIN_ORDER_AMOUNT_FOR_EVENT)) return null
+
+ val benefits = listOfNotNull(
+ getChristmasDDayDiscountBenefit(reservationDay),
+ getWeekDayDiscountBenefit(reservationDay, reservationOrders),
+ getWeekEndDiscountBenefit(reservationDay, reservationOrders),
+ getSpecialDiscountBenefit(reservationDay),
+ getFreeGiftBenefit(totalOrderAmount)
+ )
+ return benefits.takeIf { it.isNotEmpty() }?.let { Benefits(it) }
+ }
+
+ private fun getChristmasDDayDiscountBenefit(reservationDay: DecemberDay): Benefit? {
+ if (reservationDay.hasPassedChristmas()) return null
+ val daySinceStartOfMonth = reservationDay.getDaySinceStartOfMonth()
+ val discountPerDay = DISCOUNT_CHRISTMAS_PER_D_DAY.multiplyBy(daySinceStartOfMonth)
+ val discountAmount = DISCOUNT_CHRISTMAS_START_D_DAY.plus(discountPerDay)
+ return Benefit(BENEFIT_CHRISTMAS_D_DAY_TYPE, BENEFIT_CHRISTMAS_D_DAY_TITLE, discountAmount)
+ }
+
+ private fun getWeekDayDiscountBenefit(reservationDay: DecemberDay, reservationOrders: Orders): Benefit? {
+ if (reservationDay.isWeekEnd()) return null
+ val discountMenuCount = reservationOrders.getMenuCountInCategory(WEEKDAY_DISCOUNT_CATEGORY) ?: return null
+ val discountAmount = DISCOUNT_WEEKDAY_PER_MENU.multiplyBy(discountMenuCount.getCount())
+ return Benefit(BENEFIT_WEEKDAY_TYPE, BENEFIT_WEEKDAY_TITLE, discountAmount)
+ }
+
+ private fun getWeekEndDiscountBenefit(reservationDay: DecemberDay, reservationOrders: Orders): Benefit? {
+ if (!reservationDay.isWeekEnd()) return null
+ val discountMenuCount = reservationOrders.getMenuCountInCategory(WEEKEND_DISCOUNT_CATEGORY) ?: return null
+ val discountAmount = DISCOUNT_WEEKEND_PER_MENU.multiplyBy(discountMenuCount.getCount())
+ return Benefit(BENEFIT_WEEKEND_TYPE, BENEFIT_WEEKEND_TITLE, discountAmount)
+ }
+
+ private fun getSpecialDiscountBenefit(reservationDay: DecemberDay): Benefit? {
+ if (!reservationDay.isSpecialDay()) return null
+ return Benefit(BENEFIT_SPECIAL_TYPE, BENEFIT_SPECIAL_TITLE, DISCOUNT_SPECIAL)
+ }
+
+ private fun getFreeGiftBenefit(totalOrderAmount: Money): Benefit? {
+ val freeGift = getFreeGift(totalOrderAmount) ?: return null
+ val benefitAmount = freeGift.getTotalPrice()
+ return Benefit(BENEFIT_FREE_GIFT_TYPE, BENEFIT_FREE_GIFT_TITLE, benefitAmount.toNegative())
+ }
+
+ companion object {
+ private val MIN_ORDER_AMOUNT_FOR_EVENT = Money(10000)
+
+ private const val BENEFIT_CHRISTMAS_D_DAY_TITLE = "크리스마스 디데이"
+ private val BENEFIT_CHRISTMAS_D_DAY_TYPE = BenefitType.DISCOUNT
+ private val DISCOUNT_CHRISTMAS_START_D_DAY = Money(-1000)
+ private val DISCOUNT_CHRISTMAS_PER_D_DAY = Money(-100)
+
+ private const val BENEFIT_WEEKDAY_TITLE = "평일"
+ private val BENEFIT_WEEKDAY_TYPE = BenefitType.DISCOUNT
+ private val WEEKDAY_DISCOUNT_CATEGORY = MenuCategory.DESSERT
+ private val DISCOUNT_WEEKDAY_PER_MENU = Money(-2023)
+
+ private const val BENEFIT_WEEKEND_TITLE = "주말"
+ private val BENEFIT_WEEKEND_TYPE = BenefitType.DISCOUNT
+ private val WEEKEND_DISCOUNT_CATEGORY = MenuCategory.MAIN
+ private val DISCOUNT_WEEKEND_PER_MENU = Money(-2023)
+
+ private const val BENEFIT_SPECIAL_TITLE = "특별"
+ private val BENEFIT_SPECIAL_TYPE = BenefitType.DISCOUNT
+ private val DISCOUNT_SPECIAL = Money(-1000)
+
+ private const val BENEFIT_FREE_GIFT_TITLE = "증정"
+ private val BENEFIT_FREE_GIFT_TYPE = BenefitType.EVENT
+ private val FREE_GIFT_MENU = Menu.CHAMPAGNE
+ private val FREE_GIFT_MENU_COUNT = MenuCount(1)
+ private val MIN_ORDER_AMOUNT_FOR_FREE_GIFT = Money(120000)
+ }
+}
\ No newline at end of file | Kotlin | 앗 진짜 사소한 오타 발견했네요😅 |
@@ -0,0 +1,94 @@
+package christmas.domain
+
+import org.assertj.core.api.Assertions
+import org.junit.jupiter.api.Assertions.*
+import org.junit.jupiter.api.Test
+import org.junit.jupiter.params.ParameterizedTest
+import org.junit.jupiter.params.provider.ValueSource
+
+class DecemberDayTest {
+ @ParameterizedTest
+ @ValueSource(ints = [1, 31, 20])
+ fun `객체 생성 - 정상 입력`(input: Int) {
+ // when & then
+ assertDoesNotThrow { DecemberDay(input) }
+ }
+
+ @ParameterizedTest
+ @ValueSource(ints = [-1, 32, 50])
+ fun `객체 생성 - 범위 초과 예외 처리`(input: Int) {
+ // when & then
+ Assertions.assertThatExceptionOfType(IllegalArgumentException::class.java)
+ .isThrownBy { DecemberDay(input) }
+ .withMessage("[ERROR] 유효하지 않은 날짜입니다. 다시 입력해 주세요.")
+ }
+
+ @Test
+ fun `문자열로 객체 생성 - 정상 입력`() {
+ // given
+ val input = "30"
+ // when
+ val result = DecemberDay.fromString(input)
+ // then
+ assertEquals(DecemberDay(30), result)
+ }
+
+ @Test
+ fun `문자열로 객체 생성 - 빈 값 입력 예외 처리`() {
+ // given
+ val input = ""
+ // when & then
+ Assertions.assertThatExceptionOfType(IllegalArgumentException::class.java)
+ .isThrownBy { DecemberDay.fromString(input) }
+ .withMessage("[ERROR] 유효하지 않은 날짜입니다. 다시 입력해 주세요.")
+ }
+
+ @ParameterizedTest
+ @ValueSource(strings = ["", "abcd", "2147483648", "-2147483649"])
+ fun `문자열로 객체 생성 - Int 범위 초과 입력 예외 처리`(input: String) {
+ // when & then
+ Assertions.assertThatExceptionOfType(IllegalArgumentException::class.java)
+ .isThrownBy { DecemberDay.fromString(input) }
+ .withMessage("[ERROR] 유효하지 않은 날짜입니다. 다시 입력해 주세요.")
+ }
+
+ @Test
+ fun `크리스마스를 지났는지 확인`() {
+ // given
+ val input = DecemberDay(26)
+ // when
+ val result = input.hasPassedChristmas()
+ // then
+ assertEquals(true, result)
+ }
+
+ @Test
+ fun `달의 시작일로부터 몇일이 지났는지 계산`() {
+ // given
+ val input = DecemberDay(17)
+ // when
+ val result = input.getDaySinceStartOfMonth()
+ // then
+ assertEquals(16, result)
+ }
+
+ @Test
+ fun `주말인지 확인`() {
+ // given
+ val input = DecemberDay(17)
+ // when
+ val result = input.isWeekEnd()
+ // then
+ assertEquals(false, result)
+ }
+
+ @Test
+ fun `별이 있는 날인지 확인`() {
+ // given
+ val input = DecemberDay(17)
+ // when
+ val result = input.isSpecialDay()
+ // then
+ assertEquals(true, result)
+ }
+}
\ No newline at end of file | Kotlin | @ValueSource 보니깐 빈값 예외처리도 같이 테스트하는거 같은데, 따로 함수를 둔 이유가 혹시 있을까요..? |
@@ -0,0 +1,14 @@
+package christmas.domain
+
+data class Money(private val amount: Int) {
+
+ fun toNegative() = Money(-amount)
+ fun isGreaterOrEqual(other: Money): Boolean = amount >= other.amount
+ fun plus(other: Money): Money = Money(amount + other.amount)
+ fun multiplyBy(input: Int): Money = Money(amount * input)
+ override fun toString(): String = "%,d$UNIT_SUFFIX".format(amount)
+
+ companion object {
+ private const val UNIT_SUFFIX = "원"
+ }
+}
\ No newline at end of file | Kotlin | 사실 저는 이번 미션을 하면서 가장 헷갈렸던 점은 **어디까지를 객체로** 봐야하는가 였습니다!
코드리뷰를 하면서 확장성과 유지보수를 위한 관심사 분리는 필수지만, 오히려 과도한 객체 분리는 오히려 코드 가독성을 해친다는 생각도 많이 들었습니다. multiplyBy의 경우, 함수의 뜻만 봤을 때는 곱셈 연산인 것을 알 수 있지만 혹시나 따로 함수로 빼둔 이유가 있을까봐 코드를 찾는데 시간을 소요했었습니다! 개인적으로는 객체를 조금 줄여도 되지 않을까 싶어요...!!!
너무 잘하셔서 이런 리뷰밖에 못드리네요 죄송합니다😂😂 |
@@ -0,0 +1,17 @@
+package christmas.domain.menu
+
+import christmas.exception.OrdersException
+
+data class MenuCount(private val count: Int) {
+ init {
+ require(count >= 1) { OrdersException.INVALID.message }
+ }
+
+ fun getCount() = count
+
+ override fun toString(): String = "%,d$UNIT_SUFFIX".format(count)
+
+ companion object {
+ private const val UNIT_SUFFIX = "개"
+ }
+}
\ No newline at end of file | Kotlin | 사실 저도 이 부분이 많이 고민됐어요
자동으로 생성되는 getter 메서드를 이용할지, 혹은 직접 이렇게 함수로 구현할지 고민이 됐는데 일단 private로 통일을 하고 메서드를 제공하는게 가독성이 좋을것 같아서 시도해봤어요! |
@@ -0,0 +1,29 @@
+package christmas.domain
+
+import christmas.exception.DecemberDayException
+
+data class DecemberDay(private val day: Int) {
+ init {
+ require(day in DAY_START..DAY_END) { DecemberDayException.INVALID.message }
+ }
+
+ fun hasPassedChristmas() = day > DAY_CHRISTMAS
+ fun getDaySinceStartOfMonth() = day - DAY_START
+ fun isWeekEnd() = day in WEEKENDS
+ fun isSpecialDay() = day in SPECIAL_DAYS
+ override fun toString(): String = "%d${UNIT_SUFFIX}".format(day)
+
+ companion object {
+ private const val DAY_START = 1
+ private const val DAY_END = 31
+ private const val DAY_CHRISTMAS = 25
+ private const val UNIT_SUFFIX = "일"
+ private val WEEKENDS = listOf(1, 2, 8, 9, 15, 16, 22, 23, 29, 30)
+ private val SPECIAL_DAYS = listOf(3, 10, 17, 24, 25, 31)
+
+ fun fromString(input: String): DecemberDay {
+ val day = requireNotNull(input.toIntOrNull()) { DecemberDayException.INVALID.message }
+ return DecemberDay(day)
+ }
+ }
+}
\ No newline at end of file | Kotlin | 아하 언뜻 보면 String 포맷 함수랑 헷갈릴 수 있겠네요! 좋은 의견 감사합니다
원래는 객체를 생성할 때 문자열로부터 생성한다는 의미를 줄려고 했는데 다소 애매한 표현이 될 수 있겠네요🙈 |
@@ -0,0 +1,90 @@
+package christmas.domain
+
+import christmas.domain.benefit.Benefit
+import christmas.domain.benefit.BenefitType
+import christmas.domain.benefit.Benefits
+import christmas.domain.menu.*
+
+class DecemberEvent {
+
+ fun getFreeGift(totalOrderAmount: Money): FreeGift? {
+ if (!totalOrderAmount.isGreaterOrEqual(MIN_ORDER_AMOUNT_FOR_FREE_GIFT)) return null
+ return FreeGift(FREE_GIFT_MENU, FREE_GIFT_MENU_COUNT)
+ }
+
+ fun getBenefits(reservationDay: DecemberDay, reservationOrders: Orders): Benefits? {
+ val totalOrderAmount = reservationOrders.getTotalOrderAmount()
+ if (!totalOrderAmount.isGreaterOrEqual(MIN_ORDER_AMOUNT_FOR_EVENT)) return null
+
+ val benefits = listOfNotNull(
+ getChristmasDDayDiscountBenefit(reservationDay),
+ getWeekDayDiscountBenefit(reservationDay, reservationOrders),
+ getWeekEndDiscountBenefit(reservationDay, reservationOrders),
+ getSpecialDiscountBenefit(reservationDay),
+ getFreeGiftBenefit(totalOrderAmount)
+ )
+ return benefits.takeIf { it.isNotEmpty() }?.let { Benefits(it) }
+ }
+
+ private fun getChristmasDDayDiscountBenefit(reservationDay: DecemberDay): Benefit? {
+ if (reservationDay.hasPassedChristmas()) return null
+ val daySinceStartOfMonth = reservationDay.getDaySinceStartOfMonth()
+ val discountPerDay = DISCOUNT_CHRISTMAS_PER_D_DAY.multiplyBy(daySinceStartOfMonth)
+ val discountAmount = DISCOUNT_CHRISTMAS_START_D_DAY.plus(discountPerDay)
+ return Benefit(BENEFIT_CHRISTMAS_D_DAY_TYPE, BENEFIT_CHRISTMAS_D_DAY_TITLE, discountAmount)
+ }
+
+ private fun getWeekDayDiscountBenefit(reservationDay: DecemberDay, reservationOrders: Orders): Benefit? {
+ if (reservationDay.isWeekEnd()) return null
+ val discountMenuCount = reservationOrders.getMenuCountInCategory(WEEKDAY_DISCOUNT_CATEGORY) ?: return null
+ val discountAmount = DISCOUNT_WEEKDAY_PER_MENU.multiplyBy(discountMenuCount.getCount())
+ return Benefit(BENEFIT_WEEKDAY_TYPE, BENEFIT_WEEKDAY_TITLE, discountAmount)
+ }
+
+ private fun getWeekEndDiscountBenefit(reservationDay: DecemberDay, reservationOrders: Orders): Benefit? {
+ if (!reservationDay.isWeekEnd()) return null
+ val discountMenuCount = reservationOrders.getMenuCountInCategory(WEEKEND_DISCOUNT_CATEGORY) ?: return null
+ val discountAmount = DISCOUNT_WEEKEND_PER_MENU.multiplyBy(discountMenuCount.getCount())
+ return Benefit(BENEFIT_WEEKEND_TYPE, BENEFIT_WEEKEND_TITLE, discountAmount)
+ }
+
+ private fun getSpecialDiscountBenefit(reservationDay: DecemberDay): Benefit? {
+ if (!reservationDay.isSpecialDay()) return null
+ return Benefit(BENEFIT_SPECIAL_TYPE, BENEFIT_SPECIAL_TITLE, DISCOUNT_SPECIAL)
+ }
+
+ private fun getFreeGiftBenefit(totalOrderAmount: Money): Benefit? {
+ val freeGift = getFreeGift(totalOrderAmount) ?: return null
+ val benefitAmount = freeGift.getTotalPrice()
+ return Benefit(BENEFIT_FREE_GIFT_TYPE, BENEFIT_FREE_GIFT_TITLE, benefitAmount.toNegative())
+ }
+
+ companion object {
+ private val MIN_ORDER_AMOUNT_FOR_EVENT = Money(10000)
+
+ private const val BENEFIT_CHRISTMAS_D_DAY_TITLE = "크리스마스 디데이"
+ private val BENEFIT_CHRISTMAS_D_DAY_TYPE = BenefitType.DISCOUNT
+ private val DISCOUNT_CHRISTMAS_START_D_DAY = Money(-1000)
+ private val DISCOUNT_CHRISTMAS_PER_D_DAY = Money(-100)
+
+ private const val BENEFIT_WEEKDAY_TITLE = "평일"
+ private val BENEFIT_WEEKDAY_TYPE = BenefitType.DISCOUNT
+ private val WEEKDAY_DISCOUNT_CATEGORY = MenuCategory.DESSERT
+ private val DISCOUNT_WEEKDAY_PER_MENU = Money(-2023)
+
+ private const val BENEFIT_WEEKEND_TITLE = "주말"
+ private val BENEFIT_WEEKEND_TYPE = BenefitType.DISCOUNT
+ private val WEEKEND_DISCOUNT_CATEGORY = MenuCategory.MAIN
+ private val DISCOUNT_WEEKEND_PER_MENU = Money(-2023)
+
+ private const val BENEFIT_SPECIAL_TITLE = "특별"
+ private val BENEFIT_SPECIAL_TYPE = BenefitType.DISCOUNT
+ private val DISCOUNT_SPECIAL = Money(-1000)
+
+ private const val BENEFIT_FREE_GIFT_TITLE = "증정"
+ private val BENEFIT_FREE_GIFT_TYPE = BenefitType.EVENT
+ private val FREE_GIFT_MENU = Menu.CHAMPAGNE
+ private val FREE_GIFT_MENU_COUNT = MenuCount(1)
+ private val MIN_ORDER_AMOUNT_FOR_FREE_GIFT = Money(120000)
+ }
+}
\ No newline at end of file | Kotlin | 당시에는 Null 타입이 해당 없음을 표현하기 적합하다 생각했었는데 말씀하신 것처럼 코틀린 언어 특성상 non-null 타입으로 사용하는 것이 좋아 보이네요! 어떻게 변환해야 할지 고민해봐야겠어요 |
@@ -0,0 +1,90 @@
+package christmas.domain
+
+import christmas.domain.benefit.Benefit
+import christmas.domain.benefit.BenefitType
+import christmas.domain.benefit.Benefits
+import christmas.domain.menu.*
+
+class DecemberEvent {
+
+ fun getFreeGift(totalOrderAmount: Money): FreeGift? {
+ if (!totalOrderAmount.isGreaterOrEqual(MIN_ORDER_AMOUNT_FOR_FREE_GIFT)) return null
+ return FreeGift(FREE_GIFT_MENU, FREE_GIFT_MENU_COUNT)
+ }
+
+ fun getBenefits(reservationDay: DecemberDay, reservationOrders: Orders): Benefits? {
+ val totalOrderAmount = reservationOrders.getTotalOrderAmount()
+ if (!totalOrderAmount.isGreaterOrEqual(MIN_ORDER_AMOUNT_FOR_EVENT)) return null
+
+ val benefits = listOfNotNull(
+ getChristmasDDayDiscountBenefit(reservationDay),
+ getWeekDayDiscountBenefit(reservationDay, reservationOrders),
+ getWeekEndDiscountBenefit(reservationDay, reservationOrders),
+ getSpecialDiscountBenefit(reservationDay),
+ getFreeGiftBenefit(totalOrderAmount)
+ )
+ return benefits.takeIf { it.isNotEmpty() }?.let { Benefits(it) }
+ }
+
+ private fun getChristmasDDayDiscountBenefit(reservationDay: DecemberDay): Benefit? {
+ if (reservationDay.hasPassedChristmas()) return null
+ val daySinceStartOfMonth = reservationDay.getDaySinceStartOfMonth()
+ val discountPerDay = DISCOUNT_CHRISTMAS_PER_D_DAY.multiplyBy(daySinceStartOfMonth)
+ val discountAmount = DISCOUNT_CHRISTMAS_START_D_DAY.plus(discountPerDay)
+ return Benefit(BENEFIT_CHRISTMAS_D_DAY_TYPE, BENEFIT_CHRISTMAS_D_DAY_TITLE, discountAmount)
+ }
+
+ private fun getWeekDayDiscountBenefit(reservationDay: DecemberDay, reservationOrders: Orders): Benefit? {
+ if (reservationDay.isWeekEnd()) return null
+ val discountMenuCount = reservationOrders.getMenuCountInCategory(WEEKDAY_DISCOUNT_CATEGORY) ?: return null
+ val discountAmount = DISCOUNT_WEEKDAY_PER_MENU.multiplyBy(discountMenuCount.getCount())
+ return Benefit(BENEFIT_WEEKDAY_TYPE, BENEFIT_WEEKDAY_TITLE, discountAmount)
+ }
+
+ private fun getWeekEndDiscountBenefit(reservationDay: DecemberDay, reservationOrders: Orders): Benefit? {
+ if (!reservationDay.isWeekEnd()) return null
+ val discountMenuCount = reservationOrders.getMenuCountInCategory(WEEKEND_DISCOUNT_CATEGORY) ?: return null
+ val discountAmount = DISCOUNT_WEEKEND_PER_MENU.multiplyBy(discountMenuCount.getCount())
+ return Benefit(BENEFIT_WEEKEND_TYPE, BENEFIT_WEEKEND_TITLE, discountAmount)
+ }
+
+ private fun getSpecialDiscountBenefit(reservationDay: DecemberDay): Benefit? {
+ if (!reservationDay.isSpecialDay()) return null
+ return Benefit(BENEFIT_SPECIAL_TYPE, BENEFIT_SPECIAL_TITLE, DISCOUNT_SPECIAL)
+ }
+
+ private fun getFreeGiftBenefit(totalOrderAmount: Money): Benefit? {
+ val freeGift = getFreeGift(totalOrderAmount) ?: return null
+ val benefitAmount = freeGift.getTotalPrice()
+ return Benefit(BENEFIT_FREE_GIFT_TYPE, BENEFIT_FREE_GIFT_TITLE, benefitAmount.toNegative())
+ }
+
+ companion object {
+ private val MIN_ORDER_AMOUNT_FOR_EVENT = Money(10000)
+
+ private const val BENEFIT_CHRISTMAS_D_DAY_TITLE = "크리스마스 디데이"
+ private val BENEFIT_CHRISTMAS_D_DAY_TYPE = BenefitType.DISCOUNT
+ private val DISCOUNT_CHRISTMAS_START_D_DAY = Money(-1000)
+ private val DISCOUNT_CHRISTMAS_PER_D_DAY = Money(-100)
+
+ private const val BENEFIT_WEEKDAY_TITLE = "평일"
+ private val BENEFIT_WEEKDAY_TYPE = BenefitType.DISCOUNT
+ private val WEEKDAY_DISCOUNT_CATEGORY = MenuCategory.DESSERT
+ private val DISCOUNT_WEEKDAY_PER_MENU = Money(-2023)
+
+ private const val BENEFIT_WEEKEND_TITLE = "주말"
+ private val BENEFIT_WEEKEND_TYPE = BenefitType.DISCOUNT
+ private val WEEKEND_DISCOUNT_CATEGORY = MenuCategory.MAIN
+ private val DISCOUNT_WEEKEND_PER_MENU = Money(-2023)
+
+ private const val BENEFIT_SPECIAL_TITLE = "특별"
+ private val BENEFIT_SPECIAL_TYPE = BenefitType.DISCOUNT
+ private val DISCOUNT_SPECIAL = Money(-1000)
+
+ private const val BENEFIT_FREE_GIFT_TITLE = "증정"
+ private val BENEFIT_FREE_GIFT_TYPE = BenefitType.EVENT
+ private val FREE_GIFT_MENU = Menu.CHAMPAGNE
+ private val FREE_GIFT_MENU_COUNT = MenuCount(1)
+ private val MIN_ORDER_AMOUNT_FOR_FREE_GIFT = Money(120000)
+ }
+}
\ No newline at end of file | Kotlin | 앗 D-Day인데 붙여 쓰다 보니 오타로 보일 수 있었네요🤣 |
@@ -0,0 +1,94 @@
+package christmas.domain
+
+import org.assertj.core.api.Assertions
+import org.junit.jupiter.api.Assertions.*
+import org.junit.jupiter.api.Test
+import org.junit.jupiter.params.ParameterizedTest
+import org.junit.jupiter.params.provider.ValueSource
+
+class DecemberDayTest {
+ @ParameterizedTest
+ @ValueSource(ints = [1, 31, 20])
+ fun `객체 생성 - 정상 입력`(input: Int) {
+ // when & then
+ assertDoesNotThrow { DecemberDay(input) }
+ }
+
+ @ParameterizedTest
+ @ValueSource(ints = [-1, 32, 50])
+ fun `객체 생성 - 범위 초과 예외 처리`(input: Int) {
+ // when & then
+ Assertions.assertThatExceptionOfType(IllegalArgumentException::class.java)
+ .isThrownBy { DecemberDay(input) }
+ .withMessage("[ERROR] 유효하지 않은 날짜입니다. 다시 입력해 주세요.")
+ }
+
+ @Test
+ fun `문자열로 객체 생성 - 정상 입력`() {
+ // given
+ val input = "30"
+ // when
+ val result = DecemberDay.fromString(input)
+ // then
+ assertEquals(DecemberDay(30), result)
+ }
+
+ @Test
+ fun `문자열로 객체 생성 - 빈 값 입력 예외 처리`() {
+ // given
+ val input = ""
+ // when & then
+ Assertions.assertThatExceptionOfType(IllegalArgumentException::class.java)
+ .isThrownBy { DecemberDay.fromString(input) }
+ .withMessage("[ERROR] 유효하지 않은 날짜입니다. 다시 입력해 주세요.")
+ }
+
+ @ParameterizedTest
+ @ValueSource(strings = ["", "abcd", "2147483648", "-2147483649"])
+ fun `문자열로 객체 생성 - Int 범위 초과 입력 예외 처리`(input: String) {
+ // when & then
+ Assertions.assertThatExceptionOfType(IllegalArgumentException::class.java)
+ .isThrownBy { DecemberDay.fromString(input) }
+ .withMessage("[ERROR] 유효하지 않은 날짜입니다. 다시 입력해 주세요.")
+ }
+
+ @Test
+ fun `크리스마스를 지났는지 확인`() {
+ // given
+ val input = DecemberDay(26)
+ // when
+ val result = input.hasPassedChristmas()
+ // then
+ assertEquals(true, result)
+ }
+
+ @Test
+ fun `달의 시작일로부터 몇일이 지났는지 계산`() {
+ // given
+ val input = DecemberDay(17)
+ // when
+ val result = input.getDaySinceStartOfMonth()
+ // then
+ assertEquals(16, result)
+ }
+
+ @Test
+ fun `주말인지 확인`() {
+ // given
+ val input = DecemberDay(17)
+ // when
+ val result = input.isWeekEnd()
+ // then
+ assertEquals(false, result)
+ }
+
+ @Test
+ fun `별이 있는 날인지 확인`() {
+ // given
+ val input = DecemberDay(17)
+ // when
+ val result = input.isSpecialDay()
+ // then
+ assertEquals(true, result)
+ }
+}
\ No newline at end of file | Kotlin | 이 부분은 놓치고 있었네요..!! 아래는 실수입니다! |
@@ -0,0 +1,14 @@
+package christmas.domain
+
+data class Money(private val amount: Int) {
+
+ fun toNegative() = Money(-amount)
+ fun isGreaterOrEqual(other: Money): Boolean = amount >= other.amount
+ fun plus(other: Money): Money = Money(amount + other.amount)
+ fun multiplyBy(input: Int): Money = Money(amount * input)
+ override fun toString(): String = "%,d$UNIT_SUFFIX".format(amount)
+
+ companion object {
+ private const val UNIT_SUFFIX = "원"
+ }
+}
\ No newline at end of file | Kotlin | 아니에요!! 혼자 볼 때는 익숙해져 보이지 않았던 부분들도 보이게 되고 다양한 시점에서 고민할 부분이 많아졌어요😄
소중한 리뷰 남겨주셔서 감사합니다!! |
@@ -0,0 +1,90 @@
+package christmas.domain
+
+import christmas.domain.benefit.Benefit
+import christmas.domain.benefit.BenefitType
+import christmas.domain.benefit.Benefits
+import christmas.domain.menu.*
+
+class DecemberEvent {
+
+ fun getFreeGift(totalOrderAmount: Money): FreeGift? {
+ if (!totalOrderAmount.isGreaterOrEqual(MIN_ORDER_AMOUNT_FOR_FREE_GIFT)) return null
+ return FreeGift(FREE_GIFT_MENU, FREE_GIFT_MENU_COUNT)
+ }
+
+ fun getBenefits(reservationDay: DecemberDay, reservationOrders: Orders): Benefits? {
+ val totalOrderAmount = reservationOrders.getTotalOrderAmount()
+ if (!totalOrderAmount.isGreaterOrEqual(MIN_ORDER_AMOUNT_FOR_EVENT)) return null
+
+ val benefits = listOfNotNull(
+ getChristmasDDayDiscountBenefit(reservationDay),
+ getWeekDayDiscountBenefit(reservationDay, reservationOrders),
+ getWeekEndDiscountBenefit(reservationDay, reservationOrders),
+ getSpecialDiscountBenefit(reservationDay),
+ getFreeGiftBenefit(totalOrderAmount)
+ )
+ return benefits.takeIf { it.isNotEmpty() }?.let { Benefits(it) }
+ }
+
+ private fun getChristmasDDayDiscountBenefit(reservationDay: DecemberDay): Benefit? {
+ if (reservationDay.hasPassedChristmas()) return null
+ val daySinceStartOfMonth = reservationDay.getDaySinceStartOfMonth()
+ val discountPerDay = DISCOUNT_CHRISTMAS_PER_D_DAY.multiplyBy(daySinceStartOfMonth)
+ val discountAmount = DISCOUNT_CHRISTMAS_START_D_DAY.plus(discountPerDay)
+ return Benefit(BENEFIT_CHRISTMAS_D_DAY_TYPE, BENEFIT_CHRISTMAS_D_DAY_TITLE, discountAmount)
+ }
+
+ private fun getWeekDayDiscountBenefit(reservationDay: DecemberDay, reservationOrders: Orders): Benefit? {
+ if (reservationDay.isWeekEnd()) return null
+ val discountMenuCount = reservationOrders.getMenuCountInCategory(WEEKDAY_DISCOUNT_CATEGORY) ?: return null
+ val discountAmount = DISCOUNT_WEEKDAY_PER_MENU.multiplyBy(discountMenuCount.getCount())
+ return Benefit(BENEFIT_WEEKDAY_TYPE, BENEFIT_WEEKDAY_TITLE, discountAmount)
+ }
+
+ private fun getWeekEndDiscountBenefit(reservationDay: DecemberDay, reservationOrders: Orders): Benefit? {
+ if (!reservationDay.isWeekEnd()) return null
+ val discountMenuCount = reservationOrders.getMenuCountInCategory(WEEKEND_DISCOUNT_CATEGORY) ?: return null
+ val discountAmount = DISCOUNT_WEEKEND_PER_MENU.multiplyBy(discountMenuCount.getCount())
+ return Benefit(BENEFIT_WEEKEND_TYPE, BENEFIT_WEEKEND_TITLE, discountAmount)
+ }
+
+ private fun getSpecialDiscountBenefit(reservationDay: DecemberDay): Benefit? {
+ if (!reservationDay.isSpecialDay()) return null
+ return Benefit(BENEFIT_SPECIAL_TYPE, BENEFIT_SPECIAL_TITLE, DISCOUNT_SPECIAL)
+ }
+
+ private fun getFreeGiftBenefit(totalOrderAmount: Money): Benefit? {
+ val freeGift = getFreeGift(totalOrderAmount) ?: return null
+ val benefitAmount = freeGift.getTotalPrice()
+ return Benefit(BENEFIT_FREE_GIFT_TYPE, BENEFIT_FREE_GIFT_TITLE, benefitAmount.toNegative())
+ }
+
+ companion object {
+ private val MIN_ORDER_AMOUNT_FOR_EVENT = Money(10000)
+
+ private const val BENEFIT_CHRISTMAS_D_DAY_TITLE = "크리스마스 디데이"
+ private val BENEFIT_CHRISTMAS_D_DAY_TYPE = BenefitType.DISCOUNT
+ private val DISCOUNT_CHRISTMAS_START_D_DAY = Money(-1000)
+ private val DISCOUNT_CHRISTMAS_PER_D_DAY = Money(-100)
+
+ private const val BENEFIT_WEEKDAY_TITLE = "평일"
+ private val BENEFIT_WEEKDAY_TYPE = BenefitType.DISCOUNT
+ private val WEEKDAY_DISCOUNT_CATEGORY = MenuCategory.DESSERT
+ private val DISCOUNT_WEEKDAY_PER_MENU = Money(-2023)
+
+ private const val BENEFIT_WEEKEND_TITLE = "주말"
+ private val BENEFIT_WEEKEND_TYPE = BenefitType.DISCOUNT
+ private val WEEKEND_DISCOUNT_CATEGORY = MenuCategory.MAIN
+ private val DISCOUNT_WEEKEND_PER_MENU = Money(-2023)
+
+ private const val BENEFIT_SPECIAL_TITLE = "특별"
+ private val BENEFIT_SPECIAL_TYPE = BenefitType.DISCOUNT
+ private val DISCOUNT_SPECIAL = Money(-1000)
+
+ private const val BENEFIT_FREE_GIFT_TITLE = "증정"
+ private val BENEFIT_FREE_GIFT_TYPE = BenefitType.EVENT
+ private val FREE_GIFT_MENU = Menu.CHAMPAGNE
+ private val FREE_GIFT_MENU_COUNT = MenuCount(1)
+ private val MIN_ORDER_AMOUNT_FOR_FREE_GIFT = Money(120000)
+ }
+}
\ No newline at end of file | Kotlin | 아!!!! 살짝 부끄럽네요😳 |
@@ -0,0 +1,40 @@
+const food = {
+ APPETIZER: ['양송이수프', '타파스', '시저샐러드'],
+ MAIN: ['티본스테이크', '바비큐립', '해산물파스타', '크리스마스파스타'],
+ DESSERT: ['초코케이크', '아이스크림'],
+ BEVERAGE: ['제로콜라', '레드와인', '샴페인'],
+};
+
+const foodCost = {
+ 양송이수프: 6000,
+ 타파스: 5500,
+ 시저샐러드: 8000,
+ 티본스테이크: 55000,
+ 바비큐립: 54000,
+ 해산물파스타: 35000,
+ 크리스마스파스타: 25000,
+ 초코케이크: 15000,
+ 아이스크림: 5000,
+ 제로콜라: 3000,
+ 레드와인: 60000,
+ 샴페인: 25000,
+};
+
+const menuBoard = [
+ '양송이수프',
+ '타파스',
+ '시저샐러드',
+ '티본스테이크',
+ '바비큐립',
+ '해산물파스타',
+ '크리스마스파스타',
+ '초코케이크',
+ '아이스크림',
+ '제로콜라',
+ '레드와인',
+ '샴페인',
+];
+
+const specialDay = [3, 10, 17, 24, 25, 31];
+
+export { food, foodCost, menuBoard, specialDay }; | JavaScript | 코스 따로 가격 따로 데이터를 만드셨군요!
저도 처음엔 이렇게 각각 만들려고 했는데, 이렇게 하면 나중에 수정해야 할 때 같은 음식을 여러번 여러곳에서 수정해줘야 할 것 같다는 생각이 들어서,
전 한 음식에 코스, 가격 정보를 담아서 음식들을 Map 형태로 데이터했습니다!
이 외에도 다른 더 좋은 방법이 있으시다면 공유 부탁드려요! ㅎㅎ |
@@ -0,0 +1,32 @@
+const uiConstants = {
+ DATE: 'DATE',
+ MENU: 'MENU',
+ GREETING_MESSAGE: '안녕하세요! 우테코 식당 12월 이벤트 플래너입니다.',
+ WHEN_VISIT_MESSAGE:
+ '12월 중 식당 예상 방문 날짜는 언제인가요? (숫자만 입력해 주세요!)\n',
+ ORDER_MENU_MESSAGE:
+ '주문하실 메뉴를 메뉴와 개수를 알려 주세요. (e.g. 해산물파스타-2,레드와인-1,초코케이크-1)\n',
+ PREVIEW_EVENT_MESSAGE: '일에 우테코 식당에서 받을 이벤트 혜택 미리 보기!',
+ DECEMBER: '12월 ',
+ ORDER_MENU: '<주문 메뉴>',
+ COUNT: '개',
+ TOTAL_COST: '<할인 전 총주문 금액>',
+ MONEY_UNIT: '원',
+ FREE_GIFT_MENU: '<증정 메뉴>',
+ FREE_GIFT: '샴페인',
+ NOTING: '없음',
+ EVENT_DETAIL: '<혜택 내역>',
+ DDAY_DISCOUNT: '크리스마스 디데이 할인: ',
+ WEEKDAY_DISCOUNT: '평일 할인: ',
+ WEEKEND_DISCOUNT: '주말 할인: ',
+ SPECIAL_DISCOUNT: '특별 할인: ',
+ FREE_GIFT_EVENT_DISCOUNT: '증정 이벤트: ',
+ TOTAL_EVENT_COST: '<총혜택 금액>',
+ EXPECTATION_COST: '<할인 후 예상 결제 금액>',
+ BADGE: '<12월 이벤트 배지>',
+ STAR: '스타',
+ TREE: '트리',
+ SANTA: '산타',
+};
+
+export default uiConstants; | JavaScript | 전 상수들은 모두 constants 라는 파일에 몰아 넣었는데,
이렇게 구분해놓으니까 훨씬 깔끔하고 가독성도 좋아보이는군요!! |
@@ -0,0 +1,21 @@
+import { foodCost } from '../constants/index.js';
+
+// 문자열인 주문목록을 Map 객체로 변환
+export const createMapObj = (menuStr) => {
+ const menuArr = menuStr.split(',');
+ const menuObj = new Map();
+ menuArr.forEach((menu) => {
+ const tmp = menu.split('-');
+ menuObj.set(tmp[0], Number(tmp[1]));
+ });
+ return menuObj;
+};
+
+// 총 비용 계산
+export const createTotalCost = (menu) => {
+ let totalCost = 0;
+ menu.forEach((value, key) => {
+ totalCost += foodCost[key] * value;
+ });
+ return totalCost;
+}; | JavaScript | 혹시 tmp 는 어떤 단어의 약자일까요..?? 템플릿..?인가요? |
@@ -0,0 +1,114 @@
+import {
+ error,
+ magicNumber,
+ uiConstants,
+ food,
+ menuBoard,
+} from './constants/index.js';
+import { createMapObj } from './utils/index.js';
+
+export default class Validate {
+ excute(obj, type) {
+ switch (type) {
+ case uiConstants.DATE:
+ this.#dateValidate(obj);
+ break;
+ case uiConstants.MENU:
+ this.#menuValidate(obj);
+ break;
+ }
+ }
+
+ #dateValidate(obj) {
+ this.#isEmpty(obj);
+ this.#isNumber(obj);
+ this.#isInRange(obj);
+ }
+
+ #menuValidate(obj) {
+ this.#isGoodForm(obj);
+ this.#isInMenuBoard(obj);
+ this.#isNotSameMenu(obj);
+ this.#isMenuCntNumber(obj);
+ this.#isOnlyBeverage(obj);
+ this.#upToTwenty(obj);
+ }
+
+ // --------------
+ // 유효성 검사 메서드모음
+
+ // 숫자인지 아닌지
+ #isNumber(obj) {
+ if (isNaN(obj)) throw new Error(error.WRONG_DATE);
+ }
+
+ // 공백인지 아닌지 체크
+ #isEmpty(obj) {
+ const regExp = /\s/;
+ if (!obj || regExp.test(obj)) throw new Error(error.WRONG_DATE);
+ }
+
+ // 숫자가 조건에 맞는지 (1~31), 0인지 아닌지도 검사가 된다.
+ #isInRange(num) {
+ if (num < magicNumber.FIRST_DAY || num > magicNumber.END_DAY)
+ throw new Error(error.WRONG_DATE);
+ }
+
+ // 음료만 주문 x
+ #isOnlyBeverage(menu) {
+ const menuObj = createMapObj(menu);
+ const menuLen = menuObj.size;
+ let beverageCnt = 0;
+ menuObj.forEach((value, key) => {
+ if (food.BEVERAGE.includes(key)) beverageCnt += 1;
+ });
+ if (menuLen === beverageCnt) throw new Error(error.NOT_ONLY_BEVERAGE);
+ }
+
+ // 메뉴 개수는 20개이하로
+ #upToTwenty(menu) {
+ const menuObj = createMapObj(menu);
+ let menuCnt = 0;
+ menuObj.forEach((value, key) => {
+ menuCnt += value;
+ });
+ if (menuCnt > magicNumber.MENU_MAX_CNT) throw new Error(error.UP_TO_TWENTY);
+ }
+
+ // 메뉴판에 없는 메뉴 x
+ #isInMenuBoard(menu) {
+ const menuObj = createMapObj(menu);
+ menuObj.forEach((value, key) => {
+ if (!menuBoard.includes(key)) throw new Error(error.WRONG_MENU);
+ });
+ }
+
+ // 메뉴 개수가 1이상의 숫자인지.
+ #isMenuCntNumber(menu) {
+ const menuObj = createMapObj(menu);
+ menuObj.forEach((value, key) => {
+ if (isNaN(value) || value < magicNumber.MENU_MIN_CNT)
+ throw new Error(error.WRONG_MENU);
+ });
+ }
+
+ // 입력이 올바른 형태로 받아지는지
+ #isGoodForm(menuStr) {
+ const menuArr = menuStr.split(',');
+ const regExp = /^[가-힣]{1,}[-]{1}[0-9]{1,}$/;
+ if (!menuArr.every((menu) => regExp.test(menu)))
+ throw new Error(error.WRONG_MENU);
+ }
+
+ // 중복 메뉴 x
+ #isNotSameMenu(menuStr) {
+ const menuArr = menuStr.split(',');
+ let before = [];
+ menuArr.forEach((menu) => {
+ const tmp = menu.split('-');
+ if (before.includes(tmp[magicNumber.BEFORE]))
+ throw new Error(error.WRONG_MENU);
+ before.push(tmp[magicNumber.BEFORE]);
+ });
+ }
+} | JavaScript | 1.1 같은 소수점을 작성했을때 예기치 못한 문제가 발생할 수 있을 것 같아요!!
양의 정수인지 검증하는 로직이 있으면 좋을 것 같습니다! |
@@ -0,0 +1,42 @@
+import { createTotalCost } from '../utils/index.js';
+import { EventDiscount, EventCheck, Planner } from './index.js';
+
+// 전체적인 이벤트를 출력해주는 플래너 클래스
+export default class PlannerPrint {
+ #date;
+
+ #menu;
+
+ constructor(date, menu) {
+ this.#date = Number(date);
+ this.#menu = menu;
+ }
+
+ preview() {
+ const event = new EventDiscount();
+ const discountTotal = event.discount(this.#date, this.#menu);
+ const [totalCost, eventList, menuObj] = this.#createObj(
+ this.#date,
+ this.#menu,
+ );
+ this.#print(new Planner(), [menuObj, totalCost, eventList, discountTotal]);
+ }
+
+ #print(obj, variable) {
+ const [menuObj, totalCost, eventList, discountTotal] = [...variable];
+ obj.outputOrderMenu(menuObj);
+ obj.outputTotalCost(totalCost);
+ obj.outputFreeGift(eventList);
+ obj.outputDiscountDetail(discountTotal, eventList);
+ obj.outputTotalEventCost(discountTotal);
+ obj.outputExpectationCost(discountTotal, totalCost);
+ obj.outputBadge(discountTotal);
+ }
+
+ #createObj(date, menu) {
+ const eventCheck = new EventCheck(date, menu);
+ const [eventList, menuObj] = eventCheck.get();
+ const totalCost = createTotalCost(menuObj);
+ return [totalCost, eventList, menuObj];
+ }
+} | JavaScript | 플래너와 플래너프린트를 나눠 놓으신 이유가 있으실까요?? 궁금합니다 ㅎㅅㅎ! |
@@ -0,0 +1,114 @@
+import {
+ error,
+ magicNumber,
+ uiConstants,
+ food,
+ menuBoard,
+} from './constants/index.js';
+import { createMapObj } from './utils/index.js';
+
+export default class Validate {
+ excute(obj, type) {
+ switch (type) {
+ case uiConstants.DATE:
+ this.#dateValidate(obj);
+ break;
+ case uiConstants.MENU:
+ this.#menuValidate(obj);
+ break;
+ }
+ }
+
+ #dateValidate(obj) {
+ this.#isEmpty(obj);
+ this.#isNumber(obj);
+ this.#isInRange(obj);
+ }
+
+ #menuValidate(obj) {
+ this.#isGoodForm(obj);
+ this.#isInMenuBoard(obj);
+ this.#isNotSameMenu(obj);
+ this.#isMenuCntNumber(obj);
+ this.#isOnlyBeverage(obj);
+ this.#upToTwenty(obj);
+ }
+
+ // --------------
+ // 유효성 검사 메서드모음
+
+ // 숫자인지 아닌지
+ #isNumber(obj) {
+ if (isNaN(obj)) throw new Error(error.WRONG_DATE);
+ }
+
+ // 공백인지 아닌지 체크
+ #isEmpty(obj) {
+ const regExp = /\s/;
+ if (!obj || regExp.test(obj)) throw new Error(error.WRONG_DATE);
+ }
+
+ // 숫자가 조건에 맞는지 (1~31), 0인지 아닌지도 검사가 된다.
+ #isInRange(num) {
+ if (num < magicNumber.FIRST_DAY || num > magicNumber.END_DAY)
+ throw new Error(error.WRONG_DATE);
+ }
+
+ // 음료만 주문 x
+ #isOnlyBeverage(menu) {
+ const menuObj = createMapObj(menu);
+ const menuLen = menuObj.size;
+ let beverageCnt = 0;
+ menuObj.forEach((value, key) => {
+ if (food.BEVERAGE.includes(key)) beverageCnt += 1;
+ });
+ if (menuLen === beverageCnt) throw new Error(error.NOT_ONLY_BEVERAGE);
+ }
+
+ // 메뉴 개수는 20개이하로
+ #upToTwenty(menu) {
+ const menuObj = createMapObj(menu);
+ let menuCnt = 0;
+ menuObj.forEach((value, key) => {
+ menuCnt += value;
+ });
+ if (menuCnt > magicNumber.MENU_MAX_CNT) throw new Error(error.UP_TO_TWENTY);
+ }
+
+ // 메뉴판에 없는 메뉴 x
+ #isInMenuBoard(menu) {
+ const menuObj = createMapObj(menu);
+ menuObj.forEach((value, key) => {
+ if (!menuBoard.includes(key)) throw new Error(error.WRONG_MENU);
+ });
+ }
+
+ // 메뉴 개수가 1이상의 숫자인지.
+ #isMenuCntNumber(menu) {
+ const menuObj = createMapObj(menu);
+ menuObj.forEach((value, key) => {
+ if (isNaN(value) || value < magicNumber.MENU_MIN_CNT)
+ throw new Error(error.WRONG_MENU);
+ });
+ }
+
+ // 입력이 올바른 형태로 받아지는지
+ #isGoodForm(menuStr) {
+ const menuArr = menuStr.split(',');
+ const regExp = /^[가-힣]{1,}[-]{1}[0-9]{1,}$/;
+ if (!menuArr.every((menu) => regExp.test(menu)))
+ throw new Error(error.WRONG_MENU);
+ }
+
+ // 중복 메뉴 x
+ #isNotSameMenu(menuStr) {
+ const menuArr = menuStr.split(',');
+ let before = [];
+ menuArr.forEach((menu) => {
+ const tmp = menu.split('-');
+ if (before.includes(tmp[magicNumber.BEFORE]))
+ throw new Error(error.WRONG_MENU);
+ before.push(tmp[magicNumber.BEFORE]);
+ });
+ }
+} | JavaScript | 유효성 검사를 따로 모아두면 전 오히려 너무 정리가 안되어 보일거라고 생각했는데, 이렇게 switch 문과 함께 깔끔하게도 쓸 수 있군요..! |
@@ -0,0 +1,21 @@
+import { foodCost } from '../constants/index.js';
+
+// 문자열인 주문목록을 Map 객체로 변환
+export const createMapObj = (menuStr) => {
+ const menuArr = menuStr.split(',');
+ const menuObj = new Map();
+ menuArr.forEach((menu) => {
+ const tmp = menu.split('-');
+ menuObj.set(tmp[0], Number(tmp[1]));
+ });
+ return menuObj;
+};
+
+// 총 비용 계산
+export const createTotalCost = (menu) => {
+ let totalCost = 0;
+ menu.forEach((value, key) => {
+ totalCost += foodCost[key] * value;
+ });
+ return totalCost;
+}; | JavaScript | 저는 로직에서 하나의 값을 도출하는 경우에는 `reduce` 메서드가 더 적합하다고 생각하는데 어떻게 생각하시나요?? |
@@ -0,0 +1,28 @@
+const magicNumber = {
+ ZERO: 0,
+ EVENT_START: 1,
+ EVENT_END: 25,
+ WEEK: 7,
+ GIFT_COST: 120000,
+ MIN_COST: 10000,
+ DDAY_DISCOUNT: 1000,
+ DISCOUNT_UNIT: 100,
+ DESSERT_DISCOUNT: 2023,
+ MAIN_DISCOUNT: 2023,
+ SPECIAL_DISCOUNT: 1000,
+ FREE_GIFT_CNT: 1,
+ CHAMPAGNE_COST: 25000,
+ STAR_COST: 5000,
+ TREE_COST: 10000,
+ SANTA_COST: 20000,
+ EVENT_COUNT: 5,
+ FIRST_DAY: 1,
+ END_DAY: 31,
+ MENU_MAX_CNT: 20,
+ MENU_MIN_CNT: 1,
+ BEFORE: 0,
+ NOTHING: 0,
+ INITIAL_NUM: 0,
+};
+
+export default magicNumber; | JavaScript | 이번에 많은 숫자를 다루면서 `numeric seperator` 라는 개념을 처음 알고 적용해 보았는데
숫자 단위 파악에 이점이 있었던 것 같아요!
한번 적용해보시면 좋을 것 같습니다
```
GIFT_COST: 120_000,
``` |
@@ -0,0 +1,21 @@
+import { foodCost } from '../constants/index.js';
+
+// 문자열인 주문목록을 Map 객체로 변환
+export const createMapObj = (menuStr) => {
+ const menuArr = menuStr.split(',');
+ const menuObj = new Map();
+ menuArr.forEach((menu) => {
+ const tmp = menu.split('-');
+ menuObj.set(tmp[0], Number(tmp[1]));
+ });
+ return menuObj;
+};
+
+// 총 비용 계산
+export const createTotalCost = (menu) => {
+ let totalCost = 0;
+ menu.forEach((value, key) => {
+ totalCost += foodCost[key] * value;
+ });
+ return totalCost;
+}; | JavaScript | temporary - 임시라는 뜻이었는데
사실 저게 미리 아무 변수명이나 작성하고,
나중에 고쳤어야 했는데, 미처 확인을 하지 못했네요.. |
@@ -0,0 +1,42 @@
+import { createTotalCost } from '../utils/index.js';
+import { EventDiscount, EventCheck, Planner } from './index.js';
+
+// 전체적인 이벤트를 출력해주는 플래너 클래스
+export default class PlannerPrint {
+ #date;
+
+ #menu;
+
+ constructor(date, menu) {
+ this.#date = Number(date);
+ this.#menu = menu;
+ }
+
+ preview() {
+ const event = new EventDiscount();
+ const discountTotal = event.discount(this.#date, this.#menu);
+ const [totalCost, eventList, menuObj] = this.#createObj(
+ this.#date,
+ this.#menu,
+ );
+ this.#print(new Planner(), [menuObj, totalCost, eventList, discountTotal]);
+ }
+
+ #print(obj, variable) {
+ const [menuObj, totalCost, eventList, discountTotal] = [...variable];
+ obj.outputOrderMenu(menuObj);
+ obj.outputTotalCost(totalCost);
+ obj.outputFreeGift(eventList);
+ obj.outputDiscountDetail(discountTotal, eventList);
+ obj.outputTotalEventCost(discountTotal);
+ obj.outputExpectationCost(discountTotal, totalCost);
+ obj.outputBadge(discountTotal);
+ }
+
+ #createObj(date, menu) {
+ const eventCheck = new EventCheck(date, menu);
+ const [eventList, menuObj] = eventCheck.get();
+ const totalCost = createTotalCost(menuObj);
+ return [totalCost, eventList, menuObj];
+ }
+} | JavaScript | 이번에 UI로직과 비즈니스 로직을 확실히 분리시켜 보고 싶었습니다.
그래서 마지막 플래너 내용을 다 출력하는 역할만 하는 PlannerPrint와
출력하기 위한 로직을 담은 Planner로 나눠봤습니다.
이렇게 나누는게 맞는지는 확실하지는 않네😂 |
@@ -0,0 +1,114 @@
+import {
+ error,
+ magicNumber,
+ uiConstants,
+ food,
+ menuBoard,
+} from './constants/index.js';
+import { createMapObj } from './utils/index.js';
+
+export default class Validate {
+ excute(obj, type) {
+ switch (type) {
+ case uiConstants.DATE:
+ this.#dateValidate(obj);
+ break;
+ case uiConstants.MENU:
+ this.#menuValidate(obj);
+ break;
+ }
+ }
+
+ #dateValidate(obj) {
+ this.#isEmpty(obj);
+ this.#isNumber(obj);
+ this.#isInRange(obj);
+ }
+
+ #menuValidate(obj) {
+ this.#isGoodForm(obj);
+ this.#isInMenuBoard(obj);
+ this.#isNotSameMenu(obj);
+ this.#isMenuCntNumber(obj);
+ this.#isOnlyBeverage(obj);
+ this.#upToTwenty(obj);
+ }
+
+ // --------------
+ // 유효성 검사 메서드모음
+
+ // 숫자인지 아닌지
+ #isNumber(obj) {
+ if (isNaN(obj)) throw new Error(error.WRONG_DATE);
+ }
+
+ // 공백인지 아닌지 체크
+ #isEmpty(obj) {
+ const regExp = /\s/;
+ if (!obj || regExp.test(obj)) throw new Error(error.WRONG_DATE);
+ }
+
+ // 숫자가 조건에 맞는지 (1~31), 0인지 아닌지도 검사가 된다.
+ #isInRange(num) {
+ if (num < magicNumber.FIRST_DAY || num > magicNumber.END_DAY)
+ throw new Error(error.WRONG_DATE);
+ }
+
+ // 음료만 주문 x
+ #isOnlyBeverage(menu) {
+ const menuObj = createMapObj(menu);
+ const menuLen = menuObj.size;
+ let beverageCnt = 0;
+ menuObj.forEach((value, key) => {
+ if (food.BEVERAGE.includes(key)) beverageCnt += 1;
+ });
+ if (menuLen === beverageCnt) throw new Error(error.NOT_ONLY_BEVERAGE);
+ }
+
+ // 메뉴 개수는 20개이하로
+ #upToTwenty(menu) {
+ const menuObj = createMapObj(menu);
+ let menuCnt = 0;
+ menuObj.forEach((value, key) => {
+ menuCnt += value;
+ });
+ if (menuCnt > magicNumber.MENU_MAX_CNT) throw new Error(error.UP_TO_TWENTY);
+ }
+
+ // 메뉴판에 없는 메뉴 x
+ #isInMenuBoard(menu) {
+ const menuObj = createMapObj(menu);
+ menuObj.forEach((value, key) => {
+ if (!menuBoard.includes(key)) throw new Error(error.WRONG_MENU);
+ });
+ }
+
+ // 메뉴 개수가 1이상의 숫자인지.
+ #isMenuCntNumber(menu) {
+ const menuObj = createMapObj(menu);
+ menuObj.forEach((value, key) => {
+ if (isNaN(value) || value < magicNumber.MENU_MIN_CNT)
+ throw new Error(error.WRONG_MENU);
+ });
+ }
+
+ // 입력이 올바른 형태로 받아지는지
+ #isGoodForm(menuStr) {
+ const menuArr = menuStr.split(',');
+ const regExp = /^[가-힣]{1,}[-]{1}[0-9]{1,}$/;
+ if (!menuArr.every((menu) => regExp.test(menu)))
+ throw new Error(error.WRONG_MENU);
+ }
+
+ // 중복 메뉴 x
+ #isNotSameMenu(menuStr) {
+ const menuArr = menuStr.split(',');
+ let before = [];
+ menuArr.forEach((menu) => {
+ const tmp = menu.split('-');
+ if (before.includes(tmp[magicNumber.BEFORE]))
+ throw new Error(error.WRONG_MENU);
+ before.push(tmp[magicNumber.BEFORE]);
+ });
+ }
+} | JavaScript | 아이고.. 그 부분을 놓쳤네요 ㅜㅜ |
@@ -0,0 +1,21 @@
+import { foodCost } from '../constants/index.js';
+
+// 문자열인 주문목록을 Map 객체로 변환
+export const createMapObj = (menuStr) => {
+ const menuArr = menuStr.split(',');
+ const menuObj = new Map();
+ menuArr.forEach((menu) => {
+ const tmp = menu.split('-');
+ menuObj.set(tmp[0], Number(tmp[1]));
+ });
+ return menuObj;
+};
+
+// 총 비용 계산
+export const createTotalCost = (menu) => {
+ let totalCost = 0;
+ menu.forEach((value, key) => {
+ totalCost += foodCost[key] * value;
+ });
+ return totalCost;
+}; | JavaScript | 간단한 로직이 필요한 경우에는 그냥 `forEach`를 쓴 것 같아요
대신에 더 복잡한 경우에는 `reduce`를 쓸 것 같아요.
`forEach` 보다 다양한 로직을 넣을(?)수 있는 `reduce`의 활용법이 더 많은 것 같아요. |
@@ -0,0 +1,59 @@
+package christmas.utils
+
+object Constant {
+ /* Model */
+ const val FIRST_DAY_DISCOUNT_AMOUNT = 1_000
+ const val DAILY_DISCOUNT_AMOUNT = 100
+ const val ONE_DAY_DECREASE = 1
+ const val WEEK_DISCOUNT_AMOUNT = 2_023
+ const val CHRISTMAS_DAY_DISCOUNT_AMOUNT = 1_000
+ const val CHAMPAGNE_CONDITION_AMOUNT = 120_000
+ const val CHRISTMAS_DAY = 25
+ const val DISCOUNT_THRESHOLD = 10_000
+ const val EMPTY = 0
+ const val BADGE_STAR = "별"
+ const val BADGE_TREE = "트리"
+ const val BADGE_SANTA = "산타"
+ const val NONE = "없음"
+ const val STAR_MIN = 5_000
+ const val STAR_MAX = 9_999
+ const val TREE_MIN = 10_000
+ const val TREE_MAX = 19_999
+ const val SANTA_MIN = 20_000
+ const val FIRST_INDEX = 0
+ const val SECOND_INDEX = 1
+
+ /* Validate */
+ const val ORDER_ITEMS_SIZE = 2
+ const val VISIT_DATE_MIN = 1
+ const val VISIT_DATE_MAX = 31
+ const val QUANTITY_MINIMUM = 1
+ const val QUANTITY_MAXIMUM = 20
+ const val HYPHEN = "-"
+ const val COMMA = ","
+ const val NUMERIC_REGEX = "^\\d+$"
+ private const val ERROR_MESSAGE_PREFIX = "[ERROR] "
+ const val ERROR_MESSAGE_INPUT_VISIT_DATE = ERROR_MESSAGE_PREFIX + "유효하지 않은 날짜입니다. 다시 입력해 주세요."
+ const val ERROR_MESSAGE_INPUT_MENU = ERROR_MESSAGE_PREFIX + "유효하지 않은 주문입니다. 다시 입력해 주세요."
+
+ /* InputView */
+ const val VISIT_DATE_ANNOUNCE_MESSAGE = "12월 중 식당 예상 방문 날짜는 언제인가요? (숫자만 입력해 주세요!)"
+ const val MENU_ANNOUNCE_MESSAGE = "주문하실 메뉴를 메뉴와 개수를 알려 주세요. (e.g. 해산물파스타-2,레드와인-1,초코케이크-1)"
+
+ /* OutPutView */
+ private const val PRINT_ENTER = "\n"
+ const val START_PLANNER_MESSAGE = "안녕하세요! 우테코 식당 12월 이벤트 플래너입니다."
+ const val PREVIEW_ANNOUNCE_MESSAGE = "12월 %d일에 우테코 식당에서 받을 이벤트 혜택 미리 보기!"
+ const val ORDER_MENU_TITLE_MESSAGE = "$PRINT_ENTER<주문 메뉴>"
+ const val ITEMS_RESULT = "%s %d개"
+ const val TOTAL_ORDER_SUM_TITLE_MESSAGE = "$PRINT_ENTER<할인 전 총주문 금액>"
+ const val TOTAL_AMOUNT_RESULT = "%,d원"
+ const val PRESENT_MENU_TITLE_MESSAGE = "$PRINT_ENTER<증정 메뉴>"
+ const val PRESENT_AMOUNT = 1
+ const val BENEFIT_DETAILS_TITLE_MESSAGE = "$PRINT_ENTER<혜택 내역>"
+ const val FREEBIE_EVENT_NAME = "증정 이벤트"
+ const val BENEFIT_RESULT = "%s: -%,d원"
+ const val BENEFIT_AMOUNT_TITLE_MESSAGE = "$PRINT_ENTER<총혜택 금액>"
+ const val PAYMENT_AMOUNT_TITLE_MESSAGE = "$PRINT_ENTER<할인 후 예상 결제 금액>"
+ const val BADGE_TITLE_MESSAGE = "$PRINT_ENTER<12월 이벤트 배지>"
+}
\ No newline at end of file | Kotlin | "ERROR"을 저렇게 따로 const val로 빼놓으니까 한결 가독성도 올라가고 혹시 모를 오타가 있어도 발견하기 쉬울 것 같네요(ex.ERROR을 Error로 썼다거나 하는 오류 들이요) |
@@ -0,0 +1,79 @@
+package christmas.model
+
+import christmas.utils.Constant.BADGE_SANTA
+import christmas.utils.Constant.BADGE_STAR
+import christmas.utils.Constant.BADGE_TREE
+import christmas.utils.Constant.CHAMPAGNE_CONDITION_AMOUNT
+import christmas.utils.Constant.CHRISTMAS_DAY_DISCOUNT_AMOUNT
+import christmas.utils.Constant.DAILY_DISCOUNT_AMOUNT
+import christmas.utils.Constant.FIRST_DAY_DISCOUNT_AMOUNT
+import christmas.utils.Constant.EMPTY
+import christmas.utils.Constant.NONE
+import christmas.utils.Constant.ONE_DAY_DECREASE
+import christmas.utils.Constant.SANTA_MIN
+import christmas.utils.Constant.STAR_MAX
+import christmas.utils.Constant.STAR_MIN
+import christmas.utils.Constant.TREE_MAX
+import christmas.utils.Constant.TREE_MIN
+import christmas.utils.Constant.WEEK_DISCOUNT_AMOUNT
+
+class DecemberEvent {
+ fun applyTheDayDiscount(date: Int): Int {
+ val dailyDiscount = (date - ONE_DAY_DECREASE) * DAILY_DISCOUNT_AMOUNT
+
+ return FIRST_DAY_DISCOUNT_AMOUNT + dailyDiscount
+ }
+
+ fun applyWeekdayDiscount(orderMenu: List<OrderItems>): Int {
+ var dessertMenuCount = EMPTY
+
+ for (item in orderMenu) {
+ val increaseCount = increaseDessertMenuCount(item.getMenuName(), item.getQuantity())
+ dessertMenuCount += increaseCount
+ }
+
+ return dessertMenuCount * WEEK_DISCOUNT_AMOUNT
+ }
+
+ private fun increaseDessertMenuCount(menuName: String, quantity: Int): Int {
+ if (menuName == StoreMenu.CHOCO_CAKE.menuName || menuName == StoreMenu.ICE_CREAM.menuName)
+ return quantity
+
+ return EMPTY
+ }
+
+
+ fun applyWeekendDiscount(orderMenu: List<OrderItems>): Int {
+ var mainMenuCount = EMPTY
+
+ for (item in orderMenu) {
+ val increaseCount = increaseMainMenuCount(item.getMenuName(), item.getQuantity())
+ mainMenuCount += increaseCount
+ }
+
+ return mainMenuCount * WEEK_DISCOUNT_AMOUNT
+ }
+
+ private fun increaseMainMenuCount(menuName: String, quantity: Int): Int {
+ if (menuName == StoreMenu.T_BONE_STEAK.menuName || menuName == StoreMenu.BBQ_RIBS.menuName ||
+ menuName == StoreMenu.SEAFOOD_PASTA.menuName || menuName == StoreMenu.CHRISTMAS_PASTA.menuName
+ )
+ return quantity
+
+ return EMPTY
+ }
+
+ fun applySpecialDiscount(): Int = CHRISTMAS_DAY_DISCOUNT_AMOUNT
+
+ fun presentChampagne(totalOrderAmount: Int): Boolean = totalOrderAmount >= CHAMPAGNE_CONDITION_AMOUNT
+
+ fun assignBadge(benefitAmount: Int): String {
+ when {
+ benefitAmount in STAR_MIN..STAR_MAX -> return BADGE_STAR
+ benefitAmount in TREE_MIN..TREE_MAX -> return BADGE_TREE
+ benefitAmount >= SANTA_MIN -> return BADGE_SANTA
+ }
+
+ return NONE
+ }
+}
\ No newline at end of file | Kotlin | 코틀린 코딩 컨벤션에서는 의무 사항은 아니지만, 3개 이상의 조건에 대해서는 when의 사용을 권장합니다. 만약 if를 사용하고 싶으시다면, 가독성 적인 측면을 위해서 각각 조건에 대해 여러 줄로 나누시는 등의 방법으로 가독성을 높이는 것이 좋을 것 같습니다. |
@@ -0,0 +1,58 @@
+package christmas.controller
+
+import christmas.model.Customer
+import christmas.model.EventHelper
+import christmas.model.OrderItems
+import christmas.model.StoreMenu.Companion.sortOrderMenu
+import christmas.model.StoreMenu.Companion.splitOrderMenu
+import christmas.model.StoreMenu.Companion.splitOrderMenuForValidate
+import christmas.utils.Validate.validateOrderMenu
+import christmas.utils.Validate.validateVisitDate
+import christmas.view.InputView
+import christmas.view.OutputView
+
+class ChristmasController {
+ private val input = InputView()
+ private val output = OutputView()
+
+ fun run() {
+ output.printStartPlanner()
+ val customer = Customer(inputVisitDate(), inputOrderMenu())
+
+ customer.requestApplyDecemberEvent()
+ previewBenefit(customer, customer.getEventHelper())
+ }
+
+ private fun inputVisitDate(): Int {
+ return try {
+ val visitDateInput = input.readVisitDate()
+ validateVisitDate(visitDateInput)
+ visitDateInput.toInt()
+ } catch (e: IllegalArgumentException) {
+ println(e.message)
+ inputVisitDate()
+ }
+ }
+
+ private fun inputOrderMenu(): List<OrderItems> {
+ return try {
+ val orderMenuInput = input.readOrderMenu()
+ validateOrderMenu(splitOrderMenuForValidate(orderMenuInput))
+ splitOrderMenu(orderMenuInput)
+ } catch (e: IllegalArgumentException) {
+ println(e.message)
+ inputOrderMenu()
+ }
+ }
+
+ private fun previewBenefit(customer: Customer, eventHelper: EventHelper) {
+ output.printPreviewAnnounce(customer.getVisitDate())
+ output.printOrderMenu(sortOrderMenu(customer.getOrderMenu()))
+ output.printTotalOrderPrize(customer.calculateTotalOrderSum())
+ output.printFreebieMenu(eventHelper.getFreebie())
+ output.printBenefitDetails(eventHelper.getDiscountHistory(), eventHelper.getFreebie())
+ output.printBenefitAmount(eventHelper.calculateTotalBenefitAmount())
+ output.printPaymentAmount(customer.calculateTotalOrderSum(), eventHelper.getDiscountHistory())
+ output.printBadge(eventHelper.getBadge())
+ }
+}
\ No newline at end of file | Kotlin | 이름에 맞게 검증이 완료되면 검증이 완료된 값을 뱉는건 어떨까요? |
@@ -0,0 +1,59 @@
+package christmas.utils
+
+object Constant {
+ /* Model */
+ const val FIRST_DAY_DISCOUNT_AMOUNT = 1_000
+ const val DAILY_DISCOUNT_AMOUNT = 100
+ const val ONE_DAY_DECREASE = 1
+ const val WEEK_DISCOUNT_AMOUNT = 2_023
+ const val CHRISTMAS_DAY_DISCOUNT_AMOUNT = 1_000
+ const val CHAMPAGNE_CONDITION_AMOUNT = 120_000
+ const val CHRISTMAS_DAY = 25
+ const val DISCOUNT_THRESHOLD = 10_000
+ const val EMPTY = 0
+ const val BADGE_STAR = "별"
+ const val BADGE_TREE = "트리"
+ const val BADGE_SANTA = "산타"
+ const val NONE = "없음"
+ const val STAR_MIN = 5_000
+ const val STAR_MAX = 9_999
+ const val TREE_MIN = 10_000
+ const val TREE_MAX = 19_999
+ const val SANTA_MIN = 20_000
+ const val FIRST_INDEX = 0
+ const val SECOND_INDEX = 1
+
+ /* Validate */
+ const val ORDER_ITEMS_SIZE = 2
+ const val VISIT_DATE_MIN = 1
+ const val VISIT_DATE_MAX = 31
+ const val QUANTITY_MINIMUM = 1
+ const val QUANTITY_MAXIMUM = 20
+ const val HYPHEN = "-"
+ const val COMMA = ","
+ const val NUMERIC_REGEX = "^\\d+$"
+ private const val ERROR_MESSAGE_PREFIX = "[ERROR] "
+ const val ERROR_MESSAGE_INPUT_VISIT_DATE = ERROR_MESSAGE_PREFIX + "유효하지 않은 날짜입니다. 다시 입력해 주세요."
+ const val ERROR_MESSAGE_INPUT_MENU = ERROR_MESSAGE_PREFIX + "유효하지 않은 주문입니다. 다시 입력해 주세요."
+
+ /* InputView */
+ const val VISIT_DATE_ANNOUNCE_MESSAGE = "12월 중 식당 예상 방문 날짜는 언제인가요? (숫자만 입력해 주세요!)"
+ const val MENU_ANNOUNCE_MESSAGE = "주문하실 메뉴를 메뉴와 개수를 알려 주세요. (e.g. 해산물파스타-2,레드와인-1,초코케이크-1)"
+
+ /* OutPutView */
+ private const val PRINT_ENTER = "\n"
+ const val START_PLANNER_MESSAGE = "안녕하세요! 우테코 식당 12월 이벤트 플래너입니다."
+ const val PREVIEW_ANNOUNCE_MESSAGE = "12월 %d일에 우테코 식당에서 받을 이벤트 혜택 미리 보기!"
+ const val ORDER_MENU_TITLE_MESSAGE = "$PRINT_ENTER<주문 메뉴>"
+ const val ITEMS_RESULT = "%s %d개"
+ const val TOTAL_ORDER_SUM_TITLE_MESSAGE = "$PRINT_ENTER<할인 전 총주문 금액>"
+ const val TOTAL_AMOUNT_RESULT = "%,d원"
+ const val PRESENT_MENU_TITLE_MESSAGE = "$PRINT_ENTER<증정 메뉴>"
+ const val PRESENT_AMOUNT = 1
+ const val BENEFIT_DETAILS_TITLE_MESSAGE = "$PRINT_ENTER<혜택 내역>"
+ const val FREEBIE_EVENT_NAME = "증정 이벤트"
+ const val BENEFIT_RESULT = "%s: -%,d원"
+ const val BENEFIT_AMOUNT_TITLE_MESSAGE = "$PRINT_ENTER<총혜택 금액>"
+ const val PAYMENT_AMOUNT_TITLE_MESSAGE = "$PRINT_ENTER<할인 후 예상 결제 금액>"
+ const val BADGE_TITLE_MESSAGE = "$PRINT_ENTER<12월 이벤트 배지>"
+}
\ No newline at end of file | Kotlin | 저는 개인적으로 이런 경우에는, Constants 파일 안에 object를 여러개 두는 편이에요!!
예시로
```
object Model {
const val FIRST_DAY_DISCOUNT_AMOUNT = 1_000
const val DAILY_DISCOUNT_AMOUNT = 100 ...
}
object Validate {
const val ORDER_ITEMS_SIZE = 2
const val VISIT_DATE_MIN = 1....
}
```
이런 식으로 하면 주석을 안 달아도 되어요!! |
@@ -0,0 +1,79 @@
+package christmas.model
+
+import christmas.utils.Constant.BADGE_SANTA
+import christmas.utils.Constant.BADGE_STAR
+import christmas.utils.Constant.BADGE_TREE
+import christmas.utils.Constant.CHAMPAGNE_CONDITION_AMOUNT
+import christmas.utils.Constant.CHRISTMAS_DAY_DISCOUNT_AMOUNT
+import christmas.utils.Constant.DAILY_DISCOUNT_AMOUNT
+import christmas.utils.Constant.FIRST_DAY_DISCOUNT_AMOUNT
+import christmas.utils.Constant.EMPTY
+import christmas.utils.Constant.NONE
+import christmas.utils.Constant.ONE_DAY_DECREASE
+import christmas.utils.Constant.SANTA_MIN
+import christmas.utils.Constant.STAR_MAX
+import christmas.utils.Constant.STAR_MIN
+import christmas.utils.Constant.TREE_MAX
+import christmas.utils.Constant.TREE_MIN
+import christmas.utils.Constant.WEEK_DISCOUNT_AMOUNT
+
+class DecemberEvent {
+ fun applyTheDayDiscount(date: Int): Int {
+ val dailyDiscount = (date - ONE_DAY_DECREASE) * DAILY_DISCOUNT_AMOUNT
+
+ return FIRST_DAY_DISCOUNT_AMOUNT + dailyDiscount
+ }
+
+ fun applyWeekdayDiscount(orderMenu: List<OrderItems>): Int {
+ var dessertMenuCount = EMPTY
+
+ for (item in orderMenu) {
+ val increaseCount = increaseDessertMenuCount(item.getMenuName(), item.getQuantity())
+ dessertMenuCount += increaseCount
+ }
+
+ return dessertMenuCount * WEEK_DISCOUNT_AMOUNT
+ }
+
+ private fun increaseDessertMenuCount(menuName: String, quantity: Int): Int {
+ if (menuName == StoreMenu.CHOCO_CAKE.menuName || menuName == StoreMenu.ICE_CREAM.menuName)
+ return quantity
+
+ return EMPTY
+ }
+
+
+ fun applyWeekendDiscount(orderMenu: List<OrderItems>): Int {
+ var mainMenuCount = EMPTY
+
+ for (item in orderMenu) {
+ val increaseCount = increaseMainMenuCount(item.getMenuName(), item.getQuantity())
+ mainMenuCount += increaseCount
+ }
+
+ return mainMenuCount * WEEK_DISCOUNT_AMOUNT
+ }
+
+ private fun increaseMainMenuCount(menuName: String, quantity: Int): Int {
+ if (menuName == StoreMenu.T_BONE_STEAK.menuName || menuName == StoreMenu.BBQ_RIBS.menuName ||
+ menuName == StoreMenu.SEAFOOD_PASTA.menuName || menuName == StoreMenu.CHRISTMAS_PASTA.menuName
+ )
+ return quantity
+
+ return EMPTY
+ }
+
+ fun applySpecialDiscount(): Int = CHRISTMAS_DAY_DISCOUNT_AMOUNT
+
+ fun presentChampagne(totalOrderAmount: Int): Boolean = totalOrderAmount >= CHAMPAGNE_CONDITION_AMOUNT
+
+ fun assignBadge(benefitAmount: Int): String {
+ when {
+ benefitAmount in STAR_MIN..STAR_MAX -> return BADGE_STAR
+ benefitAmount in TREE_MIN..TREE_MAX -> return BADGE_TREE
+ benefitAmount >= SANTA_MIN -> return BADGE_SANTA
+ }
+
+ return NONE
+ }
+}
\ No newline at end of file | Kotlin | 이거
return when{
어쩌고 저쩌고
else -> NONE
}
이렇게도 쓸 수 있는 걸루 알아요! |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.