patch stringlengths 17 31.2k | y int64 1 1 | oldf stringlengths 0 2.21M | idx int64 1 1 | id int64 4.29k 68.4k | msg stringlengths 8 843 | proj stringclasses 212
values | lang stringclasses 9
values |
|---|---|---|---|---|---|---|---|
@@ -1,7 +1,10 @@
class Video < ActiveRecord::Base
+ extend FriendlyId
+
belongs_to :watchable, polymorphic: true
validates :published_on, presence: true
+ validates :slug, presence: true, uniqueness: true
validates :title, presence: true
validates :watchable_id, presence: true
validates :watchable_t... | 1 | class Video < ActiveRecord::Base
belongs_to :watchable, polymorphic: true
validates :published_on, presence: true
validates :title, presence: true
validates :watchable_id, presence: true
validates :watchable_type, presence: true
validates :wistia_id, presence: true
delegate :included_in_plan?, to: :watc... | 1 | 10,763 | There's a good bit of class-level stuff that's repeated in our various product types. Think it's worth extracting a...dare I say it...module? | thoughtbot-upcase | rb |
@@ -79,7 +79,10 @@ func Build(pkgName, outpath string, config *compileopts.Config, action func(Buil
// keep functions interoperable, pass int64 types as pointers to
// stack-allocated values.
// Use -wasm-abi=generic to disable this behaviour.
- if config.Options.WasmAbi == "js" && strings.HasPrefix(config.Triple... | 1 | // Package builder is the compiler driver of TinyGo. It takes in a package name
// and an output path, and outputs an executable. It manages the entire
// compilation pipeline in between.
package builder
import (
"debug/elf"
"encoding/binary"
"errors"
"fmt"
"io/ioutil"
"os"
"path/filepath"
"sort"
"strconv"
"... | 1 | 10,841 | Please do not modify the `config.Target` field, it should contain exactly what is extracted from the JSON files. Instead, you can either: * Add a getter to the `config` variable (`*compileopts.Config`), so you can simply call `config.WasmAbi()` to get the value. * Use a local variable instead. The getter would be sligh... | tinygo-org-tinygo | go |
@@ -159,6 +159,14 @@ func newTestEnv(inboundOptions []InboundOption, outboundOptions []OutboundOption
testRouter := newTestRouter(procedures)
t := NewTransport()
+ if err := t.Start(); err != nil {
+ return nil, err
+ }
+ defer func() {
+ if err != nil {
+ err = multierr.Append(err, t.Stop())
+ }
+ }()
l... | 1 | // Copyright (c) 2017 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge... | 1 | 15,096 | The nil check is not necessary for these. Append checks both sides for nil. | yarpc-yarpc-go | go |
@@ -62,6 +62,7 @@ func main() {
trace.WithAttributes(attrs...),
trace.ChildOf(spanCtx),
)
+ span.SetAttributes(entries...)
defer span.End()
span.AddEvent(ctx, "handling this...") | 1 | // Copyright 2019, OpenTelemetry Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or ag... | 1 | 10,893 | Shouldn't we instead have the SDK apply these, internally? I.e., I would expect to see the dctx entries included in the span as first-class distributed correlations, not as span attributes. | open-telemetry-opentelemetry-go | go |
@@ -60,5 +60,12 @@ func (t *topologyAPI) GetTopology(ctx context.Context, req *topologyv1.GetTopolo
}
func (t *topologyAPI) SearchTopology(ctx context.Context, req *topologyv1.SearchTopologyRequest) (*topologyv1.SearchTopologyResponse, error) {
- return nil, errors.New("not implemented")
+ resources, err := t.topol... | 1 | package topology
import (
"context"
"errors"
"github.com/golang/protobuf/ptypes/any"
"github.com/uber-go/tally"
"go.uber.org/zap"
topologyv1 "github.com/lyft/clutch/backend/api/topology/v1"
"github.com/lyft/clutch/backend/module"
"github.com/lyft/clutch/backend/service"
topologyservice "github.com/lyft/clut... | 1 | 9,768 | nit: rename this in proto and update impl to `Search` to avoid stutter | lyft-clutch | go |
@@ -78,7 +78,8 @@ class SliderController extends AdminBaseController
->from(SliderItem::class, 's')
->where('s.domainId = :selectedDomainId')
->setParameter('selectedDomainId', $this->adminDomainTabsFacade->getSelectedDomainId())
- ->orderBy('s.position');
+ ... | 1 | <?php
namespace Shopsys\FrameworkBundle\Controller\Admin;
use Shopsys\FrameworkBundle\Component\Domain\AdminDomainTabsFacade;
use Shopsys\FrameworkBundle\Component\Grid\GridFactory;
use Shopsys\FrameworkBundle\Component\Grid\QueryBuilderDataSource;
use Shopsys\FrameworkBundle\Component\Router\Security\Annotation\Csrf... | 1 | 24,272 | is it necessary to order by id as a second ordering? this will take place only when several new slider items are created without reordering (position is then null). Wouldn't be better to recalculate position after creating a new item? (right now items with null in position behave differently in administration and on fr... | shopsys-shopsys | php |
@@ -18,8 +18,10 @@ import (
)
var (
- claimFromRewardingFundBaseGas = uint64(10000)
- claimFromRewardingFundGasPerByte = uint64(100)
+ // ClaimFromRewardingFundBaseGas represents the base intrinsic gas for claimFromRewardingFund
+ ClaimFromRewardingFundBaseGas = uint64(10000)
+ // ClaimFromRewardingFundGasPerByt... | 1 | // Copyright (c) 2019 IoTeX
// This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no
// warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent
// permitted by law, all liability for your use of the cod... | 1 | 17,289 | `ClaimFromRewardingFundBaseGas` is a global variable (from `gochecknoglobals`) | iotexproject-iotex-core | go |
@@ -89,9 +89,11 @@ namespace RDKit {
}
PyObject *GetSubstructMatch(const ROMol &mol, const ROMol &query,bool useChirality=false,
bool useQueryQueryMatches=false){
- NOGIL gil;
MatchVectType matches;
- SubstructMatch(mol,query,matches,true,useChirality,useQueryQueryMatches);... | 1 | // $Id$
//
// Copyright (C) 2003-2009 Greg Landrum and Rational Discovery LLC
//
// @@ All Rights Reserved @@
// This file is part of the RDKit.
// The contents are covered by the terms of the BSD license
// which is included in the file license.txt, found at the root
// of the RDKit source tree.
//
#define NO_I... | 1 | 14,213 | How about modifying the NOGIL definition so that it only does anything if the thread safety flag (RDK_BUILD_THREADSAFE_SSS) is set? | rdkit-rdkit | cpp |
@@ -29,6 +29,11 @@ type chainState interface {
LatestState(ctx context.Context) (state.Tree, error)
}
+// BlockTimer defines a interface to a struct that can give the current block height.
+type BlockTimer interface {
+ BlockHeight() (uint64, error)
+}
+
// PublishFunc is a function the Sender calls to publish a ... | 1 | package msg
import (
"context"
"sync"
"github.com/ipfs/go-cid"
"github.com/pkg/errors"
"github.com/filecoin-project/go-filecoin/abi"
"github.com/filecoin-project/go-filecoin/actor"
"github.com/filecoin-project/go-filecoin/address"
"github.com/filecoin-project/go-filecoin/chain"
"github.com/filecoin-project/... | 1 | 18,451 | blockheighter would be more clear | filecoin-project-venus | go |
@@ -949,5 +949,15 @@ void OptimizerUtils::copyIndexScanData(const nebula::graph::IndexScan* from,
to->setFilter(from->filter() == nullptr ? nullptr : from->filter()->clone());
}
+Status OptimizerUtils::compareAndSwapBound(std::pair<Value, bool>& a, std::pair<Value, bool>& b) {
+ if (a.first > b.first) {
+ std... | 1 | /* Copyright (c) 2020 vesoft inc. All rights reserved.
*
* This source code is licensed under Apache 2.0 License.
*/
#include "graph/optimizer/OptimizerUtils.h"
#include <algorithm>
#include <iterator>
#include <memory>
#include <unordered_set>
#include "common/base/Status.h"
#include "common/datatypes/Value.h"
#... | 1 | 31,923 | This is so weird as a utility function. | vesoft-inc-nebula | cpp |
@@ -58,7 +58,8 @@ func TestPlanQuery(t *testing.T) {
return m
}
- cmpopt := cmp.AllowUnexported(dynamodb.ScanInput{}, dynamodb.QueryInput{}, dynamodb.AttributeValue{})
+ // Ignores the ConsistentRead field from both QueryInput and ScanInput.
+ cmpopt := cmp.FilterPath(func(p cmp.Path) bool { return p.Last().Stri... | 1 | // Copyright 2019 The Go Cloud Development Kit Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// https://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by appli... | 1 | 19,704 | Why? What would happen if you did not? | google-go-cloud | go |
@@ -752,7 +752,9 @@ public class SmartStore {
String[] pathElements = path.split("[.]");
Object o = soup;
for (String pathElement : pathElements) {
- o = ((JSONObject) o).opt(pathElement);
+ if (o != null) {
+ o = ((JSONObject) o).opt(pathElement);
+ ... | 1 | /*
* Copyright (c) 2012, salesforce.com, inc.
* All rights reserved.
* Redistribution and use of this software in source and binary forms, with or
* without modification, are permitted provided that the following conditions
* are met:
* - Redistributions of source code must retain the above copyright notice, this... | 1 | 13,835 | Unrelated bugfix for NPE. | forcedotcom-SalesforceMobileSDK-Android | java |
@@ -387,7 +387,7 @@ class AdminController extends Controller
throw new \Exception(sprintf('The "%s" property is not a switchable toggle.', $propertyName));
}
- if (!$propertyMetadata['canBeSet']) {
+ if (!$propertyMetadata['isWritable']) {
throw new \Exception(sprintf(... | 1 | <?php
/*
* This file is part of the EasyAdminBundle.
*
* (c) Javier Eguiluz <javier.eguiluz@gmail.com>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/
namespace JavierEguiluz\Bundle\EasyAdminBundle\Controller;
use Doctrine\DBAL\... | 1 | 9,283 | What if some extended the `AdminController` and had a check for the old option name? Could that be a valid use case? | EasyCorp-EasyAdminBundle | php |
@@ -524,6 +524,17 @@
dataType: "json"
});
},
+ fetchSegmentMap: function() {
+ return CV.$.ajax({
+ type: "GET",
+ url: countlyCommon.API_PARTS.data.r + '/data-manager/event-segment',
+ data: {
+ "ap... | 1 | /*global countlyVue, CV, _, countlyCommon, jQuery */
(function(countlyAllEvents) {
countlyAllEvents.helpers = {
getLineChartData: function(context, eventData) {
var chartData = eventData.chartData;
var graphData = [[], [], []];
var labels = context.state.labels;
... | 1 | 14,733 | This will be only available when data-manager is enabled, is there a fallback in case data manager is disabled? | Countly-countly-server | js |
@@ -219,7 +219,7 @@ func (o *deploySvcOpts) generateWorkerServiceRecommendedActions() {
retrieveEnvVarCode := "const eventsQueueURI = process.env.COPILOT_QUEUE_URI"
actionRetrieveEnvVar := fmt.Sprintf(
`Update %s's code to leverage the injected environment variable "COPILOT_QUEUE_URI".
-In JavaScript you can wri... | 1 | // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
// SPDX-License-Identifier: Apache-2.0
package cli
import (
"errors"
"fmt"
"os"
"path/filepath"
"regexp"
"strings"
"github.com/aws/aws-sdk-go/aws/session"
"github.com/aws/copilot-cli/internal/pkg/apprunner"
"github.com/aws/copilot-cli/int... | 1 | 19,108 | Do you think we want to move the call to `generateWorkerServiceRecommendedActions` inside `RecommandedActions()`? | aws-copilot-cli | go |
@@ -3277,7 +3277,7 @@ bool CoreChecks::PreCallValidateGetQueryPoolResults(VkDevice device, VkQueryPool
VkQueryResultFlags flags) const {
if (disabled.query_validation) return false;
bool skip = false;
- skip |= ValidateQueryPoolStride("VUID-vkGetQueryPoo... | 1 | /* Copyright (c) 2015-2019 The Khronos Group Inc.
* Copyright (c) 2015-2019 Valve Corporation
* Copyright (c) 2015-2019 LunarG, Inc.
* Copyright (C) 2015-2019 Google Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You m... | 1 | 12,273 | The VUIDs in this area are not great, but I think `ValidateQueryPoolStride` should probably be skipped if the query pool was created with type `VK_QUERY_TYPE_PERFORMANCE_QUERY`. VUID-02828 might be a better fit, but again, the existing VUIDs step on each other so it requires a bit of interpretation. | KhronosGroup-Vulkan-ValidationLayers | cpp |
@@ -74,11 +74,12 @@ namespace Nethermind.Store
db[key.ToBigEndianByteArrayWithoutLeadingZeros()] = value;
}
- public static byte[] Get(this IDb db, long key)
- {
- return db[key.ToBigEndianByteArrayWithoutLeadingZeros()];
- }
-
+ public stat... | 1 | // Copyright (c) 2018 Demerzel Solutions Limited
// This file is part of the Nethermind library.
//
// The Nethermind library is free software: you can redistribute it and/or modify
// it under the terms of the GNU Lesser General Public License as published by
// the Free Software Foundation, either version 3 of ... | 1 | 23,311 | Iguess you should use ToDbKey here | NethermindEth-nethermind | .cs |
@@ -179,16 +179,7 @@ func (x *blockIndexer) DeleteTipBlock(blk *block.Block) error {
func (x *blockIndexer) Height() (uint64, error) {
x.mutex.RLock()
defer x.mutex.RUnlock()
-
- index, err := db.GetCountingIndex(x.kvStore, totalBlocksBucket)
- if err != nil {
- if errors.Cause(err) == db.ErrBucketNotExist || err... | 1 | // Copyright (c) 2019 IoTeX Foundation
// This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no
// warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent
// permitted by law, all liability for your use... | 1 | 21,652 | x.tbk is the "index" below, and is done in Start() | iotexproject-iotex-core | go |
@@ -8,6 +8,7 @@ namespace Datadog.Trace.Util
/// </summary>
internal static class DomainMetadata
{
+ private const string IsAppInsightKey = "DD_IsAppInsight";
private const string UnknownName = "unknown";
private static Process _currentProcess;
private static bool _proce... | 1 | using System;
using System.Diagnostics;
namespace Datadog.Trace.Util
{
/// <summary>
/// Dedicated helper class for consistently referencing Process and AppDomain information.
/// </summary>
internal static class DomainMetadata
{
private const string UnknownName = "unknown";
private... | 1 | 17,184 | Do we already have a convention for this? If not, would we consider "DataDog.IsAppInsights". And then use "DataDog." prefix for all this settings, environment variables etc..? Such settings are, essentially, public APIs because they may conflict with customer data. Regardless of that , AppInsights has an s at the end :... | DataDog-dd-trace-dotnet | .cs |
@@ -95,6 +95,16 @@ static int cb_firehose_init(struct flb_output_instance *ins,
ctx->time_key_format = DEFAULT_TIME_KEY_FORMAT;
}
+ tmp = flb_output_get_property("log_key", ins);
+ if (tmp) {
+ ctx->log_key = tmp;
+ }
+
+ if (ctx->log_key && ctx->time_key) {
+ flb_plg_error(ctx... | 1 | /* -*- Mode: C; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/* Fluent Bit
* ==========
* Copyright (C) 2019-2020 The Fluent Bit Authors
* Copyright (C) 2015-2018 Treasure Data Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in co... | 1 | 12,909 | this assignment is not necessary if the offsetof() is used in the configmap | fluent-fluent-bit | c |
@@ -268,11 +268,6 @@ func (p *Protocol) claimFromAccount(sm protocol.StateManager, addr address.Addre
balance := big.NewInt(0).Sub(acc.balance, amount)
if balance.Cmp(big.NewInt(0)) < 0 {
return errors.New("no enough available balance")
- } else if balance.Cmp(big.NewInt(0)) == 0 {
- // If the account balance i... | 1 | // Copyright (c) 2019 IoTeX
// This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no
// warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent
// permitted by law, all liability for your use of the cod... | 1 | 16,748 | I'd rather leave a TODO here at least. | iotexproject-iotex-core | go |
@@ -115,10 +115,10 @@ class BatchViewTest(BaseWebTest, unittest.TestCase):
request = {"path": "/mushrooms/"} # trailing slash
body = {"requests": [request]}
resp = self.app.post_json("/batch", body, headers=self.headers)
- collection = resp.json["responses"][0]
- self.assertEqu... | 1 | import colander
import uuid
import unittest
from unittest import mock
from pyramid.response import Response
from kinto.core.views.batch import BatchPayloadSchema, batch as batch_service
from kinto.core.testing import DummyRequest
from kinto.core.utils import json
from .support import BaseWebTest
class BatchViewTes... | 1 | 12,010 | Shouldn't this be `resource`? | Kinto-kinto | py |
@@ -37,13 +37,12 @@ namespace {
/** CPU implementation of evaluation layer forward prop. */
void fp_cpu(lbann_comm& comm,
const AbsDistMat& input,
- DataType& value,
- Al::request& req) {
+ DataType& value) {
const auto& local_input = input.LockedMatrix();
const aut... | 1 | ////////////////////////////////////////////////////////////////////////////////
// Copyright (c) 2014-2016, Lawrence Livermore National Security, LLC.
// Produced at the Lawrence Livermore National Laboratory.
// Written by the LBANN Research Team (B. Van Essen, et al.) listed in
// the CONTRIBUTORS file. <lbann-dev@l... | 1 | 13,205 | Why does this become blocking for the CPU path? Shouldn't it remain independent of the GPU path? | LLNL-lbann | cpp |
@@ -24,7 +24,7 @@ module Travis
sh.export 'TRAVIS_RUBY_VERSION', config[:rvm], echo: false if rvm?
end
- def setup
+ def configure
super
setup_rvm if rvm?
end | 1 | module Travis
module Build
class Script
module RVM
include Chruby
MSGS = {
setup_ruby_head: 'Setting up latest %s'
}
CONFIG = %w(
rvm_remote_server_url3=https://s3.amazonaws.com/travis-rubies/binaries
rvm_remote_server_type3=rubies
... | 1 | 15,414 | Do we need to change occurences where `setup` was called before? | travis-ci-travis-build | rb |
@@ -61,6 +61,16 @@ func (a *API) resolveReferences() {
o.ErrorRefs[i].Shape.IsError = true
}
}
+
+ // TODO put this somewhere better
+ for _, s := range a.Shapes {
+ switch s.Type {
+ case "list":
+ s.MemberRef.Shape.UsedInList = true
+ case "map":
+ s.ValueRef.Shape.UsedInMap = true
+ }
+ }
}
// A... | 1 | // +build codegen
package api
import (
"fmt"
"regexp"
"strings"
)
// updateTopLevelShapeReferences moves resultWrapper, locationName, and
// xmlNamespace traits from toplevel shape references to the toplevel
// shapes for easier code generation
func (a *API) updateTopLevelShapeReferences() {
for _, o := range a.... | 1 | 8,858 | Is this TODO still valid? Or are we going to put this somewhere else later? | aws-aws-sdk-go | go |
@@ -15,12 +15,17 @@ def generate_data(test_user_id, user_name, from_ts, num_records):
test_data = []
artist_msid = str(uuid.uuid4())
- for i in range(num_records):
+ if (from_ts == None): #check for playing now listens
+ timestamp = None
+ else:
from_ts += 1 # Add one second
+ ... | 1 | # coding=utf-8
import json
import os
import uuid
from datetime import datetime
from listenbrainz.listen import Listen
TEST_DATA_PATH = os.path.join(os.path.dirname(os.path.realpath(__file__)), '..', '..', 'testdata')
def generate_data(test_user_id, user_name, from_ts, num_records):
test_data = []
artist_m... | 1 | 15,137 | We generally don't do parantheses in if conditions in Python. :) this could be better written as `if from_ts is None` | metabrainz-listenbrainz-server | py |
@@ -460,9 +460,13 @@ void tm_process_req_requestregioninfo(CTmTxMessage * pp_msg)
TM_Txid_legacy lv_transid;
} u;
- char tname[2000], ername[50], rname[100], offline[20], regid[200], hostname[200], port[100];
+ char tname[2000];
+ tname[299] = '\0';
+/*
+ char ername[50], rname[100], offline[20], ... | 1 | // @@@ START COPYRIGHT @@@
//
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The ASF licenses this file
// to you under the Apache License, Version 2... | 1 | 18,344 | Odd that we'd set just element 299 of a 2000-byte buffer to null. But I see that this is the way it was before. | apache-trafodion | cpp |
@@ -28,3 +28,9 @@ type PeerAdder interface {
type ClosestPeerer interface {
ClosestPeer(addr swarm.Address) (peerAddr swarm.Address, err error)
}
+
+// ScoreFunc is implemented by components that need to score peers in a different way than XOR distance.
+type ScoreFunc func(peer swarm.Address) (score float32)
+
+//... | 1 | // Copyright 2020 The Swarm Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
package topology
import (
"context"
"errors"
"io"
"github.com/ethersphere/bee/pkg/swarm"
)
var ErrNotFound = errors.New("no peer found")
var ErrWantSe... | 1 | 9,861 | ScoreFunc is not used in this PR. Maybe to add it later when needed? | ethersphere-bee | go |
@@ -171,9 +171,9 @@ func customResponseForwarder(ctx context.Context, w http.ResponseWriter, resp pr
http.SetCookie(w, cookie)
}
- if redirects := md.HeaderMD.Get("Location"); len(redirects) > 0 {
- w.Header().Set("Location", redirects[0])
-
+ // Redirect if it's the browser (non-XHR).
+ redirects := md.HeaderM... | 1 | package mux
import (
"context"
"fmt"
"io"
"net/http"
"net/http/httptest"
"net/http/pprof"
"net/textproto"
"net/url"
"path"
"regexp"
"strconv"
"strings"
"github.com/grpc-ecosystem/grpc-gateway/v2/runtime"
"golang.org/x/net/http2"
"golang.org/x/net/http2/h2c"
"google.golang.org/grpc"
"google.golang.org... | 1 | 11,174 | super nit: I think this might be easier to read as `requestHeadersFromResponseWriter` | lyft-clutch | go |
@@ -4,12 +4,8 @@
* (found in the LICENSE.Apache file in the root directory)
*/
#include <gtest/gtest.h>
-#include <cstdlib>
-#include <thread>
-#include <mutex>
-#include <atomic>
-#include "common/concurrent/Barrier.h"
-#include "common/thread/GenericThreadPool.h"
+#include "concurrent/Barrier.h"
+#include "thre... | 1 | /* Copyright (c) 2018 - present, VE Software Inc. All rights reserved
*
* This source code is licensed under Apache 2.0 License
* (found in the LICENSE.Apache file in the root directory)
*/
#include <gtest/gtest.h>
#include <cstdlib>
#include <thread>
#include <mutex>
#include <atomic>
#include "common/concurrent/... | 1 | 13,975 | Need to include "common/base/Base.h" in front of this line | vesoft-inc-nebula | cpp |
@@ -1,6 +1,5 @@
import getRole from '../aria/get-role';
-import matches from '../matches/matches';
-import nativeElementType from './native-element-type';
+import getElementSpec from '../standards/get-element-spec';
import nativeTextMethods from './native-text-methods';
/** | 1 | import getRole from '../aria/get-role';
import matches from '../matches/matches';
import nativeElementType from './native-element-type';
import nativeTextMethods from './native-text-methods';
/**
* Get the accessible text using native HTML methods only
* @param {VirtualNode} element
* @param {Object} context
* @pr... | 1 | 15,747 | Changes in this file should go into a separate PR. | dequelabs-axe-core | js |
@@ -243,10 +243,15 @@ public class PhpSurfaceNamer extends SurfaceNamer {
if (token.equals(InitFieldConfig.RANDOM_TOKEN)) {
stringParts.add("time()");
} else {
- stringParts.add("\"" + token + "\"");
+ stringParts.add(quoted(token));
}
}
}
return ... | 1 | /* Copyright 2016 Google Inc
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in ... | 1 | 23,996 | Please ensure that this will not start putting single quotes where double quotes are expected. | googleapis-gapic-generator | java |
@@ -68,7 +68,7 @@ type Manager struct {
}
// ProvideConfig provides the config for consumer
-func (manager *Manager) ProvideConfig(publicKey json.RawMessage, pingerPort func(int) int) (session.ServiceConfiguration, session.DestroyCallback, error) {
+func (manager *Manager) ProvideConfig(publicKey json.RawMessage, p... | 1 | /*
* Copyright (C) 2019 The "MysteriumNetwork/node" Authors.
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
... | 1 | 14,282 | `ProvideConfig` was changed, looks like it will not compile for windows, and should be changed too. | mysteriumnetwork-node | go |
@@ -76,9 +76,8 @@ func Search(ctx *context.APIContext) {
})
}
-// https://github.com/gogits/go-gogs-client/wiki/Repositories#list-your-repositories
-func ListMyRepos(ctx *context.APIContext) {
- ownRepos, err := models.GetUserRepositories(ctx.User.ID, true, 1, ctx.User.NumRepos)
+func listUserRepos(ctx *context.AP... | 1 | // Copyright 2014 The Gogs Authors. All rights reserved.
// Use of this source code is governed by a MIT-style
// license that can be found in the LICENSE file.
package repo
import (
"path"
api "github.com/gogits/go-gogs-client"
"github.com/gogits/gogs/models"
"github.com/gogits/gogs/modules/auth"
"github.com/... | 1 | 11,865 | This does not look right, you're listing all private repositories.. | gogs-gogs | go |
@@ -20,4 +20,6 @@ C2::Application.routes.draw do
get 'bookmarklet', to: redirect('bookmarklet.html')
get "/498", :to => "errors#token_authentication_error"
+ match "*path" => "application#xss_options_request", :via => :options
+
end | 1 | C2::Application.routes.draw do
get 'approval_groups/search' => "approval_groups#search"
resources :approval_groups
post 'send_cart' => 'communicarts#send_cart'
post 'approval_reply_received' => 'communicarts#approval_reply_received'
match 'approval_response', to: 'communicarts#approval_response', via: [:get, ... | 1 | 12,022 | An OPTIONS request should respond from _any_ path? Seems weird to me... | 18F-C2 | rb |
@@ -40,6 +40,8 @@ class MediaAdmin extends Admin
->add('category', null, array(
'show_filter' => false,
))
+ ->add('width')
+ ->add('height')
;
$providers = array(); | 1 | <?php
/*
* This file is part of the Sonata package.
*
* (c) Thomas Rabaix <thomas.rabaix@sonata-project.org>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/
namespace Sonata\MediaBundle\Admin\ORM;
use Sonata\MediaBundle\Admin\Ba... | 1 | 6,454 | you need to add the content type | sonata-project-SonataMediaBundle | php |
@@ -12,6 +12,14 @@ namespace Datadog.Trace
{
private static Task _traceAgentMonitor;
private static Task _dogStatsDMonitor;
+ private static Process _traceAgentProcess;
+ private static Process _dogStatsProcess;
+
+ public static void StopSubProcesses()
+ {
+ ... | 1 | using System;
using System.Diagnostics;
using System.IO;
using System.Threading;
using System.Threading.Tasks;
using Datadog.Trace.Configuration;
using Datadog.Trace.Logging;
namespace Datadog.Trace
{
internal class TracerSubProcessManager
{
private static Task _traceAgentMonitor;
private stati... | 1 | 16,534 | Do we need to distinguish between these two processes? I'm thinking maybe we can have a list of processes and treat them all equally. | DataDog-dd-trace-dotnet | .cs |
@@ -61,8 +61,8 @@ callee_info_t default_callee_info;
int
get_clean_call_switch_stack_size(void)
{
-#ifdef AARCH64
- /* Stack size needs to be 16 byte aligned on ARM */
+#if defined(AARCH64) || defined(X64)
+ /* Stack size needs to be 16 byte aligned on ARM and x64. */
return ALIGN_FORWARD(sizeof(priv_mcon... | 1 | /* ******************************************************************************
* Copyright (c) 2010-2017 Google, Inc. All rights reserved.
* Copyright (c) 2010 Massachusetts Institute of Technology All rights reserved.
* Copyright (c) 2000-2010 VMware, Inc. All rights reserved.
* *****************************... | 1 | 11,855 | This is used only for out-of-line -- so yes this seems right to do for x64. Inlined is aligned separately at the end of prepare_for_clean_call(). There the ifdef is x86_64 or MACOS -- no ARM, why not? Also, please add || MACOS here to match the inlined. | DynamoRIO-dynamorio | c |
@@ -271,7 +271,8 @@ final class MySQLSpanStore implements SpanStore {
.selectDistinct(ZIPKIN_SPANS.NAME)
.from(ZIPKIN_SPANS)
.join(ZIPKIN_ANNOTATIONS)
- .on(ZIPKIN_SPANS.TRACE_ID.eq(ZIPKIN_ANNOTATIONS.TRACE_ID))
+ .on(ZIPKIN_SPANS.TRACE_ID_HIGH.eq(ZIPKIN_ANNOTATIONS.TR... | 1 | /**
* Copyright 2015-2017 The OpenZipkin Authors
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except
* in compliance with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or ... | 1 | 13,160 | guess I'm wondering if this needs to be refactored to use Schema.joinCondition() or similar? | openzipkin-zipkin | java |
@@ -53,6 +53,7 @@ module Beaker
class_option :'xml-time-order', :type => :boolean, :group => 'Beaker run'
class_option :'debug-errors', :type => :boolean, :group => 'Beaker run'
class_option :'exec_manual_tests', :type => :boolean, :group => 'Beaker run'
+ class_option :'test-tag-exclude', :type => :s... | 1 | require "thor"
require "fileutils"
require "beaker/subcommands/subcommand_util"
module Beaker
class Subcommand < Thor
SubcommandUtil = Beaker::Subcommands::SubcommandUtil
def initialize(*args)
super
FileUtils.mkdir_p(SubcommandUtil::CONFIG_DIR)
FileUtils.touch(SubcommandUtil::SUBCOMMAND_O... | 1 | 15,755 | Does it make sense to restrict this option to `exec` only? You could add it specific to that subcommand using the `method_option`...method. There's an example of it for hosts in the `init` function. | voxpupuli-beaker | rb |
@@ -143,7 +143,10 @@ namespace OpenTelemetry.Context.Propagation
break;
}
- if (NameValueHeaderValue.TryParse(pair, out NameValueHeaderValue baggageItem))
+ var decodedPair = WebUtility.UrlDecode(pair);
+ var escape... | 1 | // <copyright file="BaggagePropagator.cs" company="OpenTelemetry Authors">
// Copyright The OpenTelemetry Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apac... | 1 | 20,026 | This is very expensive (lots of allocations, lots of data copying). Could we do something like check IndexOf('%') and bypass if no hit? | open-telemetry-opentelemetry-dotnet | .cs |
@@ -55,10 +55,17 @@ public class PvPUtil
public static boolean isAttackable(Client client, Player player)
{
int wildernessLevel = 0;
- if (!(client.getVar(Varbits.IN_WILDERNESS) == 1 || WorldType.isPvpWorld(client.getWorldType())))
+ if (!(client.getVar(Varbits.IN_WILDERNESS) == 1
+ || WorldType.isPvpWorld(... | 1 | /*
* Copyright (c) 2019. PKLite - All Rights Reserved
* Unauthorized modification, distribution, or possession of this source file, via any medium is strictly prohibited.
* Proprietary and confidential. Refer to PKLite License file for more information on
* full terms of this copyright and to determine what consti... | 1 | 16,191 | This should be `WorldType.isDeadmanWorld(client.getWorldType())` to be inline with the other WorldType calls. | open-osrs-runelite | java |
@@ -600,11 +600,11 @@ class SABLRetinaHead(BaseDenseHead, BBoxTestMixin):
bbox_cls_pred.contiguous(),
bbox_reg_pred.contiguous()
]
- bboxes, confids = self.bbox_coder.decode(
+ bboxes, confidences = self.bbox_coder.decode(
anchors.con... | 1 | # Copyright (c) OpenMMLab. All rights reserved.
import numpy as np
import torch
import torch.nn as nn
from mmcv.cnn import ConvModule
from mmcv.runner import force_fp32
from mmdet.core import (build_anchor_generator, build_assigner,
build_bbox_coder, build_sampler, images_to_levels,
... | 1 | 25,917 | do we also need to change `mlvl_confid` -> `mlvl_confidences`> | open-mmlab-mmdetection | py |
@@ -125,7 +125,8 @@ type Config struct {
MetadataAddr string `config:"hostname;127.0.0.1;die-on-fail"`
MetadataPort int `config:"int(0,65535);8775;die-on-fail"`
- InterfacePrefix string `config:"iface-list;cali;non-zero,die-on-fail"`
+ InterfacePrefix string `config:"iface-list;cali;non-zero,die-on-fail"`
+ I... | 1 | // Copyright (c) 2016-2017 Tigera, Inc. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by ... | 1 | 15,810 | I feel slightly that InterfaceExclude is not a clear name - bearing in mind that our config names are, to some extent, an external API. From an external point of view, a clearer name might be IPVSInterfaces. Then it would obviously make sense for the value to be something like 'kube-ipvs0', and it would be a matter of ... | projectcalico-felix | go |
@@ -180,7 +180,7 @@ def transform_path(path):
path = utils.expand_windows_drive(path)
# Drive dependent working directories are not supported, e.g.
# E:filename is invalid
- if re.match(r'[A-Z]:[^\\]', path, re.IGNORECASE):
+ if re.fullmatch(r'[A-Z]:[^\\]', path, re.IGNORECASE):
return Non... | 1 | # vim: ft=python fileencoding=utf-8 sts=4 sw=4 et:
# Copyright 2014-2017 Florian Bruhin (The Compiler) <mail@qutebrowser.org>
#
# This file is part of qutebrowser.
#
# qutebrowser is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free S... | 1 | 20,064 | This should be `re.search` with a `^` anchor added to the regex, as what we want here is really any path starting with something like `E:`. | qutebrowser-qutebrowser | py |
@@ -108,6 +108,14 @@ func determineResourceHealth(key ResourceKey, obj *unstructured.Unstructured) (s
return determineClusterRoleHealth(obj)
case KindClusterRoleBinding:
return determineClusterRoleBindingHealth(obj)
+ case KindVirtualService:
+ return determineVirtualService(obj)
+ case KindDestinationRule:
+ ... | 1 | // Copyright 2020 The PipeCD Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agree... | 1 | 21,852 | Since `IsKubernetesBuiltInResource` at L69 returns false due to lack `networking.istio.io/v1alpha3` in `builtInApiVersions` within `pkg/app/piped/cloudprovider/kubernetes/resourcekey.go`, it will never reach this point. | pipe-cd-pipe | go |
@@ -40,7 +40,7 @@ import (
// themselves.
func RunEndToEndTest(ctx context.Context, t *testing.T, exp *otlpmetric.Exporter, mcMetrics Collector) {
selector := simple.NewWithInexpensiveDistribution()
- proc := processor.New(selector, exportmetric.StatelessExportKindSelector())
+ proc := processor.NewFactory(selector... | 1 | // Copyright The OpenTelemetry Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agre... | 1 | 16,307 | Does codecov not run this test? Not sure how else it would not be covered. | open-telemetry-opentelemetry-go | go |
@@ -30,8 +30,9 @@ func main() {
// rootCmd represents the base command when called without any subcommands
var rootCmd = &cobra.Command{
- Use: "multisend [command]",
- Args: cobra.ExactArgs(1),
+ Use: "multisend 'JSON_DATA'",
+ Short: "multisend bytecode generator",
+ Args: cobra.ExactArgs(1),
RunE: func(cmd... | 1 | // Copyright (c) 2018 IoTeX
// This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no
// warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent
// permitted by law, all liability for your use of the cod... | 1 | 17,122 | can we add some sample of JSON_DATA format in the usage? | iotexproject-iotex-core | go |
@@ -25,13 +25,13 @@ namespace Datadog.Trace.Logging
_logProvider = logProvider;
}
- public void Initialize(IScopeManager scopeManager, string defaultServiceName, string version, string env)
+ public void Initialize(string defaultServiceName, string version, string env)
{
... | 1 | // <copyright file="LogEnricher.cs" company="Datadog">
// Unless explicitly stated otherwise all files in this repository are licensed under the Apache 2 License.
// This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
// </copyright>
using System;
namespace D... | 1 | 24,968 | Using `Tracer.Instance` in here is problematic for testing It will likely cause some other tests to break I think - that's why we started passing in `IScopeManager` EDIT: I see you used `[TracerRestore]` - maybe that'll be enough! | DataDog-dd-trace-dotnet | .cs |
@@ -22,7 +22,10 @@ import javax.annotation.Nullable;
*/
@AutoValue
public abstract class InitFieldConfig {
+ public static final String projectIdVariableName = "project_id";
+
private static final String randomValueToken = "$RANDOM";
+ private static final String projectIdToken = "$PROJECT_ID";
public abs... | 1 | /* Copyright 2016 Google Inc
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in ... | 1 | 19,361 | make all of these `static final` fields UPPER_SNAKE - they are constants. | googleapis-gapic-generator | java |
@@ -3298,7 +3298,8 @@ int32 Mob::AffectMagicalDamage(int32 damage, uint16 spell_id, const bool iBuffTi
// If this is a DoT, use DoT Shielding...
if (iBuffTic) {
- damage -= (damage * itembonuses.DoTShielding / 100);
+ int total_dotshielding = itembonuses.DoTShielding + itembonuses.MitigateDotRune[SBIndex::MITIG... | 1 | /* EQEMu: Everquest Server Emulator
Copyright (C) 2001-2002 EQEMu Development Team (http://eqemulator.net)
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; version 2 of the License.
This program is d... | 1 | 11,029 | No possible chance for weird overflows here, right? | EQEmu-Server | cpp |
@@ -39,9 +39,13 @@ import org.apache.lucene.search.Weight;
* @lucene.experimental
*/
public abstract class ValueSourceScorer extends Scorer {
+ // Fixed cost for a single iteration of the TwoPhaseIterator instance
+ private static final int DEF_COST = 5;
+
protected final FunctionValues values;
private fin... | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may ... | 1 | 32,878 | Or we could use a Float object to more clearly show as user-settable via non-null? | apache-lucene-solr | java |
@@ -107,7 +107,7 @@ namespace Nethermind.Merge.Plugin.Handlers.V1
if (headUpdated && shouldUpdateHead)
{
- _poSSwitcher.ForkchoiceUpdated(newHeadBlock!.Header);
+ _poSSwitcher.ForkchoiceUpdated(newHeadBlock!.Header, finalizedHeader);
... | 1 | // Copyright (c) 2021 Demerzel Solutions Limited
// This file is part of the Nethermind library.
//
// The Nethermind library is free software: you can redistribute it and/or modify
// it under the terms of the GNU Lesser General Public License as published by
// the Free Software Foundation, either version 3 of... | 1 | 26,429 | finalizedHeader should be saved in FinalizationManager when we have FinalizationBlockHash != Keccak.Zero | NethermindEth-nethermind | .cs |
@@ -48,6 +48,7 @@ func AddDiskImportSteps(w *daisy.Workflow, dataDiskInfos []ovfutils.DiskInfo) {
setupDataDiskStepName := fmt.Sprintf("setup-data-disk-%v", dataDiskIndex)
diskImporterDiskName := fmt.Sprintf("disk-importer-%v", dataDiskIndex)
+ scratchDiskDiskName := fmt.Sprintf("disk-importer-scratch-%s-%v", ... | 1 | // Copyright 2019 Google Inc. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by appl... | 1 | 9,319 | Not using ExactName: true would remove the need for manually adding workflow ID as it would be added automatically by Daisy. E.g. 'disk-importer-2-import-ovf-7mn7h' was created from diskImporterDiskName above even though only 'disk-importer-2' was specified. ExactName: true should be used for resources that shouldn't i... | GoogleCloudPlatform-compute-image-tools | go |
@@ -8469,8 +8469,13 @@ defaultdict(<class 'list'>, {'col..., 'col...})]
'For argument "inplace" expected type bool, received type {}.'
.format(type(inplace).__name__))
- sdf = self._sdf.filter(expr)
- internal = self._internal.copy(sdf=sdf)
+ data_columns = [labe... | 1 | #
# Copyright (C) 2019 Databricks, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to i... | 1 | 14,300 | If we support multi-index column later, we need to rename to fit the pandas' requirement. | databricks-koalas | py |
@@ -0,0 +1,11 @@
+package aws
+
+// JSONValue is a representation of a grab bag type that will be marshaled
+// into a json string. This type can be used just like any other map.
+//
+// Example:
+// values := JSONValue{
+// "Foo": "Bar",
+// }
+// values["Baz"] = "Qux"
+type JSONValue map[string]interface{} | 1 | 1 | 8,547 | I'm not sure this is really needed. JSONValue type can be used the same as a map as far as operators go, including range. I'd leave this out for now unless there is a strong reason to keep it. | aws-aws-sdk-go | go | |
@@ -724,6 +724,7 @@ void Container::internalAddThing(uint32_t, Thing* thing)
void Container::startDecaying()
{
+ Item::startDecaying();
for (Item* item : itemlist) {
item->startDecaying();
} | 1 | /**
* The Forgotten Server - a free and open-source MMORPG server emulator
* Copyright (C) 2019 Mark Samman <mark.samman@gmail.com>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; eithe... | 1 | 19,909 | sorry for nitpicking but I would love a new line under this line | otland-forgottenserver | cpp |
@@ -21,5 +21,5 @@ package node
type OptionsTransactor struct {
TransactorEndpointAddress string
RegistryAddress string
- AccountantID string
+ ChannelImplementation string
} | 1 | /*
* Copyright (C) 2019 The "MysteriumNetwork/node" Authors.
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
... | 1 | 15,021 | ChannelImplementation field naming is not clear, is it some kind of standard? Maybe it can be named ChannelID? | mysteriumnetwork-node | go |
@@ -67,4 +67,11 @@ public interface ActionsProvider {
default ExpireSnapshots expireSnapshots(Table table) {
throw new UnsupportedOperationException(this.getClass().getName() + " does not implement expireSnapshots");
}
+
+ /**
+ * Instantiates an action to remove all the files referenced by given metadata... | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you ... | 1 | 35,820 | Looks like there is a typo: `expireSnapshots` -> `removeFiles` or whatever name we go with. | apache-iceberg | java |
@@ -31,7 +31,7 @@ public abstract class IntraFeedSortDialog {
int idxCurrentSort = -1;
for (int i = 0; i < values.length; i++) {
- if (currentSortOrder == values[i]) {
+ if (currentSortOrder == values[i] || currentSortOrder == null) {
idxCurrentSort = i;
... | 1 | package de.danoeh.antennapod.dialog;
import android.content.Context;
import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
import androidx.appcompat.app.AlertDialog;
import de.danoeh.antennapod.R;
import de.danoeh.antennapod.core.util.SortOrder;
public abstract class IntraFeedSortDialog {
@N... | 1 | 15,917 | Thanks for looking into this. I think it looks a bit strange to have this check inside the for loop. Wouldn't it also work to initialize `idxCurrentSort` with 0 instead? | AntennaPod-AntennaPod | java |
@@ -72,6 +72,8 @@ public class Notification {
public static final int OMNIPOD_POD_NOT_ATTACHED = 59;
public static final int CARBS_REQUIRED = 60;
public static final int IMPORTANCE_HIGH = 2;
+ public static final int OMNIPOD_POD_SUSPENDED = 61;
+ public static final int OMNIPOD_POD_ALERTS_UPDATED =... | 1 | package info.nightscout.androidaps.plugins.general.overview.notifications;
import androidx.annotation.NonNull;
import info.nightscout.androidaps.utils.T;
public class Notification {
// TODO join with NotificationWithAction after change to enums
public static final int URGENT = 0;
public static final int ... | 1 | 32,545 | Just a small ordering thing: Could you please bring `IMPORTANCE_HIGH` to the bottom and maybe even have one line between it and the Notification IDs? | MilosKozak-AndroidAPS | java |
@@ -48,7 +48,7 @@ void prepareMolForDrawing(RWMol &mol, bool kekulize, bool addChiralHs,
if (kekulize) {
try {
MolOps::Kekulize(mol, false); // kekulize, but keep the aromatic flags!
- } catch(const RDKit::AtomKekulizeException &e) {
+ } catch (const RDKit::AtomKekulizeException &e) {
std::... | 1 | //
// Copyright (C) 2016-2019 Greg Landrum
//
// @@ All Rights Reserved @@
// This file is part of the RDKit.
// The contents are covered by the terms of the BSD license
// which is included in the file license.txt, found at the root
// of the RDKit source tree.
//
#include <GraphMol/MolDraw2D/MolDraw2D.h>
#incl... | 1 | 21,525 | Should this be boost logged? | rdkit-rdkit | cpp |
@@ -57,9 +57,10 @@ def find_notifiers(notifier_name):
# pylint: enable=inconsistent-return-statements
-def convert_to_timestamp(violations):
+def convert_to_timestamp(session, violations):
"""Convert violation created_at_datetime to timestamp string.
Args:
+ session (object): session object to wor... | 1 | # Copyright 2017 The Forseti Security Authors. All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by ap... | 1 | 29,611 | What is the reason for doing expunge here? This method is purely for converting the timestamp. | forseti-security-forseti-security | py |
@@ -86,9 +86,15 @@ class TypeToSchema extends TypeUtil.SchemaVisitor<Schema> {
List<Schema.Field> fields = Lists.newArrayListWithExpectedSize(fieldSchemas.size());
for (int i = 0; i < structFields.size(); i += 1) {
Types.NestedField structField = structFields.get(i);
+ String origFieldName = struc... | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you ... | 1 | 13,898 | This calls sanitize twice if the name isn't valid. | apache-iceberg | java |
@@ -0,0 +1,13 @@
+class Proposal < ActiveRecord::Base
+ has_one :cart
+
+ validates :flow, presence: true, inclusion: {in: ApprovalGroup::FLOWS}
+ validates :status, presence: true, inclusion: {in: Approval::STATUSES}
+
+ after_initialize :set_default_flow
+
+
+ def set_default_flow
+ self.flow ||= 'parallel'
+... | 1 | 1 | 12,120 | Is there an equivalent that'd allow zero or one? | 18F-C2 | rb | |
@@ -234,6 +234,13 @@ func (m *taskExecutor) repeatWith() (err error) {
m.resetK8sClient(resource)
}
+ if rwExec.isTaskObjectNameRepeat() {
+ // if repetition is based on task object name itself, then the task's
+ // object name needs to be set
+ m.metaTaskExec.setObjectName(resource)
+ m.objectName = ... | 1 | /*
Copyright 2017 The OpenEBS Authors
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, soft... | 1 | 8,698 | Is it possible to update/re-evaluate entire metatask object for every repeat? If we decide/need to use a repeatWith resources in let us say labelSelector(bad example) then we would have to add another logic to update those properties. | openebs-maya | go |
@@ -47,7 +47,7 @@ func accountImport(args []string) string {
}
wallet := cfg.Wallet
fmt.Printf("#%s: Enter your private key, which will not be exposed on the screen.\n", name)
- privateKeyBytes, err := terminal.ReadPassword(syscall.Stdin)
+ privateKeyBytes, err := terminal.ReadPassword(int(syscall.Stdin))
if er... | 1 | // Copyright (c) 2019 IoTeX
// This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no
// warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent
// permitted by law, all liability for your use of the cod... | 1 | 16,474 | unnecessary conversion (from `unconvert`) | iotexproject-iotex-core | go |
@@ -30,7 +30,6 @@ int main (int argc, char *argv[])
int universe_size;
char *kvsname;
char *val;
- char pmi_fd[16];
char pmi_rank[16];
char pmi_size[16];
int result; | 1 | /************************************************************\
* Copyright 2019 Lawrence Livermore National Security, LLC
* (c.f. AUTHORS, NOTICE.LLNS, COPYING)
*
* This file is part of the Flux resource manager framework.
* For details, see https://github.com/flux-framework.
*
* SPDX-License-Identifier: LGPL-3.... | 1 | 25,839 | typo in commit message `openening` | flux-framework-flux-core | c |
@@ -10,7 +10,10 @@
#include <mpi.h>
-#include <adios2.h>
+#define ADIOS_HAVE_PHDF5 // so hdf5 related items are loaded in ADIOS_CPP.h
+//#include "ADIOS_CPP.h"
+#include "adios2.h"
+#include "adios2/engine/hdf5/HDF5ReaderP.h"
int main(int argc, char *argv[])
{ | 1 | /*
* HDF5Writer.cpp
*
* Created on: March 20, 2017
* Author: Junmin
*/
#include <iostream>
#include <vector>
#include <mpi.h>
#include <adios2.h>
int main(int argc, char *argv[])
{
MPI_Init(&argc, &argv);
int rank, size;
MPI_Comm_rank(MPI_COMM_WORLD, &rank);
MPI_Comm_size(MPI_COMM_WORLD, ... | 1 | 11,479 | User-code doesn't see the internal ADIOS headers anymore. This whole include block should just be `#include <adios2.h>` | ornladios-ADIOS2 | cpp |
@@ -20,7 +20,8 @@ class BucketViewTest(BaseWebTest, unittest.TestCase):
def test_buckets_are_global_to_every_users(self):
self.app.patch_json(self.record_url,
- {'permissions': {'read': [Authenticated]}},
+ {'data': {},
+ ... | 1 | from pyramid.security import Authenticated
from .support import (BaseWebTest, unittest, get_user_headers,
MINIMALIST_BUCKET, MINIMALIST_GROUP,
MINIMALIST_COLLECTION, MINIMALIST_RECORD)
class BucketViewTest(BaseWebTest, unittest.TestCase):
collection_url = '/buckets'
... | 1 | 7,711 | nit: I guess we can omit this (unless you had a reason to specify it) | Kinto-kinto | py |
@@ -74,6 +74,11 @@ func (c *client) isSolicitedLeafNode() bool {
return c.kind == LEAF && c.leaf.remote != nil
}
+// Returns true if this is a solicited leafnode and is not configured to be treated as a hub.
+func (c *client) isSpokeLeafNode() bool {
+ return c.kind == LEAF && c.leaf.remote != nil && !c.leaf.remot... | 1 | // Copyright 2019-2020 The NATS Authors
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to ... | 1 | 10,194 | Why is Hub public? | nats-io-nats-server | go |
@@ -114,7 +114,6 @@ func (agent *ecsAgent) capabilities() ([]*ecs.Attribute, error) {
}
capabilities = agent.appendTaskENICapabilities(capabilities)
- capabilities = agent.appendENITrunkingCapabilities(capabilities)
capabilities = agent.appendDockerDependentCapabilities(capabilities, supportedVersions)
| 1 | // Copyright 2014-2017 Amazon.com, Inc. or its affiliates. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License"). You may
// not use this file except in compliance with the License. A copy of the
// License is located at
//
// http://aws.amazon.com/apache2.0/
//
// or in the "license... | 1 | 22,279 | why is this deleted? | aws-amazon-ecs-agent | go |
@@ -1,5 +1,6 @@
<div class="<%= trail.unstarted? ? "unstarted" : "started" %>">
<section class="trail <%= topic_class(trail.topic) %>">
+ <p class="prerequisite">Hey, before you start this...Have you done the <a href="">Intro to Rails</a> tutorial?</p>
<header>
<span class="topic-label"><%= trail.top... | 1 | <div class="<%= trail.unstarted? ? "unstarted" : "started" %>">
<section class="trail <%= topic_class(trail.topic) %>">
<header>
<span class="topic-label"><%= trail.topic.name %></span>
<h1><%= link_to trail.name, trail %></h1>
<p class="description"><%= trail.description %></p>
<%= render... | 1 | 14,141 | Maybe move that into a partial | thoughtbot-upcase | rb |
@@ -158,10 +158,13 @@ func TestBlockDAO(t *testing.T) {
require := require.New(t)
ctx := context.Background()
- dao := NewBlockDAO(kvstore, indexer, false, config.Default.DB)
+ testDBFile, _ := ioutil.TempFile(os.TempDir(), "db")
+ cfg := config.Default.DB
+ cfg.DbPath = testDBFile.Name()
+ dao := NewBlock... | 1 | package blockdao
import (
"context"
"hash/fnv"
"io/ioutil"
"math/big"
"math/rand"
"os"
"testing"
"time"
"github.com/iotexproject/go-pkgs/hash"
"github.com/pkg/errors"
"github.com/stretchr/testify/require"
"github.com/iotexproject/iotex-core/action"
"github.com/iotexproject/iotex-core/blockchain/block"
... | 1 | 20,013 | Error return value of `dao.Stop` is not checked (from `errcheck`) | iotexproject-iotex-core | go |
@@ -172,7 +172,7 @@ func handleMainConfigArgs(cmd *cobra.Command, args []string, app *ddevapp.DdevAp
if docrootRelPath != "" {
app.Docroot = docrootRelPath
if _, err = os.Stat(docrootRelPath); os.IsNotExist(err) {
- util.Failed("The docroot provided (%v) does not exist", docrootRelPath)
+ output.UserOut.War... | 1 | package cmd
import (
"fmt"
"os"
"strings"
"path/filepath"
"github.com/drud/ddev/pkg/ddevapp"
"github.com/drud/ddev/pkg/output"
"github.com/drud/ddev/pkg/util"
"github.com/spf13/cobra"
)
// docrootRelPath is the relative path to the docroot where index.php is
var docrootRelPath string
// siteName is the nam... | 1 | 13,056 | util.Warning()? Easier to say. | drud-ddev | go |
@@ -38,6 +38,14 @@ func Trie(tx ethdb.Tx, slowChecks bool, quit <-chan struct{}) {
if errc != nil {
panic(errc)
}
+ select {
+ default:
+ case <-quit:
+ return
+ case <-logEvery.C:
+ log.Info("trie account integrity", "key", fmt.Sprintf("%x", k))
+ }
+
hasState, hasBranch, hasHash, hash... | 1 | package integrity
import (
"bytes"
"encoding/binary"
"fmt"
"math/bits"
"time"
"github.com/ledgerwatch/turbo-geth/common"
"github.com/ledgerwatch/turbo-geth/common/dbutils"
"github.com/ledgerwatch/turbo-geth/common/hexutil"
"github.com/ledgerwatch/turbo-geth/ethdb"
"github.com/ledgerwatch/turbo-geth/log"
"g... | 1 | 22,022 | this default is kinda superfluous (although i see it was already there before PR ) | ledgerwatch-erigon | go |
@@ -53,11 +53,7 @@ public class NodeList<N extends Node> implements List<N>, Iterable<N>, HasParent
private List<AstObserver> observers = new ArrayList<>();
public NodeList() {
- this((Node) null);
- }
-
- public NodeList(Node parent) {
- setParentNode(parent);
+ parentNode = null... | 1 | /*
* Copyright (C) 2007-2010 Júlio Vilmar Gesser.
* Copyright (C) 2011, 2013-2016 The JavaParser Team.
*
* This file is part of JavaParser.
*
* JavaParser can be used either under the terms of
* a) the GNU Lesser General Public License as published by
* the Free Software Foundation, either version 3 of the ... | 1 | 11,938 | How is this related? | javaparser-javaparser | java |
@@ -3,6 +3,7 @@ class SubscriptionsController < ApplicationController
def new
@plans = IndividualPlan.featured.active.ordered
+ @team_plans = TeamPlan.featured.ordered
end
def edit | 1 | class SubscriptionsController < ApplicationController
before_filter :assign_mentor, only: [:new, :edit]
def new
@plans = IndividualPlan.featured.active.ordered
end
def edit
@plans = IndividualPlan.featured.active.ordered
end
def update
plan = IndividualPlan.find_by_sku!(params[:plan_id])
... | 1 | 8,735 | I'm breaking one of the rules here, it feels like the right thing to do. Open to alternative suggestions. | thoughtbot-upcase | rb |
@@ -1,8 +1,8 @@
shared_examples_for 'disables OpenSSH roaming' do
let(:disable_ssh_roaming) { %(echo -e "Host *\n UseRoaming no\n" | cat - $HOME/.ssh/config > $HOME/.ssh/config.tmp && mv $HOME/.ssh/config.tmp $HOME/.ssh/config) }
- let(:sexp) { sexp_find(subject, [:if, "$(sw_vers -productVersion | cut -d . -f 2) ... | 1 | shared_examples_for 'disables OpenSSH roaming' do
let(:disable_ssh_roaming) { %(echo -e "Host *\n UseRoaming no\n" | cat - $HOME/.ssh/config > $HOME/.ssh/config.tmp && mv $HOME/.ssh/config.tmp $HOME/.ssh/config) }
let(:sexp) { sexp_find(subject, [:if, "$(sw_vers -productVersion | cut -d . -f 2) -lt 12"]) }
it '... | 1 | 14,576 | The use of `#should` was triggering an rspec depracation warning for me, which is why I switched this to the rspec 3 style. | travis-ci-travis-build | rb |
@@ -172,7 +172,7 @@ bool ReaderProxy::requested_changes_set(std::vector<SequenceNumber_t>& seqNumSet
{
auto chit = m_changesForReader.find(ChangeForReader_t(*sit));
- if(chit != m_changesForReader.end() && chit->isValid())
+ if(chit != m_changesForReader.end())
{
Chan... | 1 | // Copyright 2016 Proyectos y Sistemas de Mantenimiento SL (eProsima).
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless re... | 1 | 12,792 | Why are you setting the CacheChange as REQUESTED when it is not valid (it was erased from history)? | eProsima-Fast-DDS | cpp |
@@ -44,9 +44,12 @@ import {
isDataZeroForReporting,
} from '../util';
-const { __ } = wp.i18n;
-const { Component, Fragment } = wp.element;
-const { isEmpty } = lodash;
+/**
+ * WordPress dependencies
+ */
+import { __ } from '@wordpress/i18n';
+import { Component, Fragment } from '@wordpress/element';
+import { i... | 1 | /**
* AnalyticsDashboardWidgetTopLevel component.
*
* Site Kit by Google, Copyright 2019 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/lic... | 1 | 24,750 | `lodash` shouldn't be grouped under WordPress dependencies | google-site-kit-wp | js |
@@ -69,7 +69,7 @@ class GenericDataFile
/**
* Used by Avro reflection to instantiate this class when reading manifest files.
*/
- public GenericDataFile(org.apache.avro.Schema avroSchema) {
+ GenericDataFile(org.apache.avro.Schema avroSchema) {
this.avroSchema = avroSchema;
Types.StructType sch... | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you ... | 1 | 13,201 | This needs to be public so that Avro can call it. | apache-iceberg | java |
@@ -18,18 +18,7 @@
/**
* External dependencies
*/
-import data, { TYPE_CORE } from 'GoogleComponents/data';
-import SvgIcon from 'GoogleUtil/svg-icon';
-
-export * from './storage';
-
-const { apiFetch } = wp;
-const {
- addFilter,
- applyFilters,
-} = wp.hooks;
-
-const {
+import {
map,
isNull,
isUndefined, | 1 | /**
* Utility functions.
*
* Site Kit by Google, Copyright 2019 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* U... | 1 | 24,756 | `Google*` shouldn't be under External dependencies - seems like ESlint is not properly recognizing that these are aliases to internal dependencies. | google-site-kit-wp | js |
@@ -245,6 +245,13 @@ class DataFrame(_Frame):
else:
super(DataFrame, self).__init__(_InternalFrame(
data, data_columns=index.data_columns, index_map=index.index_map))
+ elif isinstance(data, ks.Series):
+ assert index is None
+ assert colum... | 1 | #
# Copyright (C) 2019 Databricks, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to i... | 1 | 10,128 | I think he meant the docstring in this constructor. yea we should fix | databricks-koalas | py |
@@ -150,7 +150,18 @@ public abstract class BinaryDictionary implements Dictionary {
throw new IllegalStateException("unknown resource scheme " + resourceScheme);
}
}
-
+
+ public static InputStream getResource(ResourceScheme scheme, String path) throws IOException {
+ switch(scheme) {
+ case... | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may ... | 1 | 32,830 | so .. this basically follows the pattern from JapaneseTokenizer, I think. .. but somehow I don't see where we defined ResourceScheme? We're not referencing the one in kuromoji, right? | apache-lucene-solr | java |
@@ -525,8 +525,11 @@ namespace SkylineNightly
private void DownloadSkylineTester(string skylineTesterZip, RunMode mode)
{
- // Make sure we can negotiate with HTTPS servers that demand TLS 1.2 (default in dotNet 4.6, but has to be turned on in 4.5)
- ServicePointManager.Securit... | 1 | /*
* Original author: Don Marsh <donmarsh .at. u.washington.edu>,
* MacCoss Lab, Department of Genome Sciences, UW
*
* Copyright 2014 University of Washington - Seattle, WA
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with... | 1 | 14,343 | It would probably be better to do: const SecurityProtocolType Tls13 = (SecurityProtocolType)12288 | ProteoWizard-pwiz | .cs |
@@ -70,16 +70,6 @@ export default [
updated_by: 1,
value: ''
},
- {
- id: 12,
- key: 'labs',
- value: '{"subscribers":true}',
- type: 'blog',
- created_at: '2015-01-12T18:29:01.000Z',
- created_by: 1,
- updated_at: '2015-10-27T17:39:58.288Z',
- ... | 1 | /* eslint-disable camelcase */
export default [
{
id: 1,
created_at: '2015-09-11T09:44:30.805Z',
created_by: 1,
key: 'title',
type: 'blog',
updated_at: '2015-10-04T16:26:05.195Z',
updated_by: 1,
value: 'Test Blog'
},
{
id: 2,
cr... | 1 | 9,309 | Similar to the above, put this setting back but keep the value as `'{}'` | TryGhost-Admin | js |
@@ -130,7 +130,7 @@ def refresh_listen_count_aggregate():
Assuming today is 2022-01-01 and this function is called for year_offset 1 and
year_count 1 then all of 2021 will be refreshed.
"""
-
+ logger.info("Starting to refresh continuous aggregates:")
timescale.init_db_connection(co... | 1 | import time
from collections import defaultdict
from datetime import datetime, timedelta
import psycopg2
from psycopg2.errors import UntranslatableCharacter
import sqlalchemy
import logging
from brainzutils import cache
from listenbrainz.utils import init_cache
from listenbrainz import db
from listenbrainz.db import t... | 1 | 18,883 | As discussed in chat - we should run this function within an app context which means that we'd already have a logger configured, and a connection to timescale set up | metabrainz-listenbrainz-server | py |
@@ -33,12 +33,4 @@
<div id="about" class="card">
<h2 class='card-header collapsed collapse-toggle' data-toggle="collapse" data-target="#about-content"><a href="/rails/info/properties">About your application’s environment</a></h2>
<div id="about-content" class="card-body collapse"></div>
-</div>
-
-<script>... | 1 | <div class="jumbotron text-center">
<h1 class="jumbotron-heading"><%= t('blacklight.welcome') %></h1>
<p class="lead">Blacklight is a multi-institutional open-source collaboration building a better discovery platform framework.</p>
<p>
<%= link_to 'Read the Documentation', 'https://github.com/projectblackli... | 1 | 8,098 | I'm curious about why this needed to be removed. | projectblacklight-blacklight | rb |
@@ -17,10 +17,10 @@ from scapy.config import conf
from scapy.base_classes import BasePacket,BasePacketList
from scapy.utils import do_graph,hexdump,make_table,make_lined_table,make_tex_table,get_temp_file
-from scapy.consts import plt, MATPLOTLIB_INLINED, MATPLOTLIB_DEFAULT_PLOT_KARGS
+from scapy.extlib import plt,... | 1 | ## This file is part of Scapy
## See http://www.secdev.org/projects/scapy for more informations
## Copyright (C) Philippe Biondi <phil@secdev.org>
## This program is published under a GPLv2 license
"""
PacketList: holds several packets and allows to do operations on them.
"""
from __future__ import absolute_import
f... | 1 | 12,032 | why did you remove `zip`? It is used! | secdev-scapy | py |
@@ -90,7 +90,7 @@ func (bs *BrokerStatus) MarkTopicUnknown(reason, format string, args ...interfac
brokerCondSet.Manage(bs).MarkUnknown(BrokerConditionTopic, reason, format, args...)
}
-func (bs *BrokerStatus) MarkTopicReady() {
+func (bs *BrokerStatus) MarkTopicReady(_ string) {
brokerCondSet.Manage(bs).MarkTru... | 1 | /*
Copyright 2020 Google LLC
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
dist... | 1 | 19,562 | Is there any reason that we don't add a similar condition like `ChannelConditionTopic` to the channel? | google-knative-gcp | go |
@@ -1,4 +1,4 @@
-<?php namespace TestVendor\Goto;
+<?php namespace TestVendor\_Goto;
use System\Classes\PluginBase;
| 1 | <?php namespace TestVendor\Goto;
use System\Classes\PluginBase;
class Plugin extends PluginBase
{
public function pluginDetails()
{
return [
'name' => 'Invalid Test Plugin',
'description' => 'Test plugin used by unit tests to detect plugins with invalid namespaces.',
... | 1 | 19,341 | before php8 "goto" was a reserved word and was not allowed as part of the namespace. Now test checks for validity of plugin namespace according to PSR-4 | octobercms-october | php |
@@ -85,6 +85,7 @@ func (t *Transport) NewInbound(listener net.Listener, options ...InboundOption)
}
// NewSingleOutbound returns a new Outbound for the given adrress.
+// Note: This does not support TLS. See TLS example in doc.go.
func (t *Transport) NewSingleOutbound(address string, options ...OutboundOption) *Ou... | 1 | // Copyright (c) 2018 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge... | 1 | 16,731 | nit: I'm not sure it can be addressed in this diff, but it seems odd that NewOutbound supports TLS but NewSingleOutbound does not. As a somewhat naive user I would expect the only difference between these two APIs is how peers are chosen. | yarpc-yarpc-go | go |
@@ -226,11 +226,17 @@ func (o *Outbound) CallOneway(ctx context.Context, treq *transport.Request) (tra
return nil, yarpcerrors.InvalidArgumentErrorf("request for http oneway outbound was nil")
}
- _, err := o.call(ctx, treq)
+ // res is used to close the response body to avoid memory/connection leak
+ // even wh... | 1 | // Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge... | 1 | 19,439 | I would advise to enhance the test for the method `CallOneway` - we should have a test very similar to `TestCallSuccess`. We should test: - Success with response (even if it is callOneway) - Success with no response and empty payload - Errors | yarpc-yarpc-go | go |
@@ -8,7 +8,7 @@ import java.util.regex.Pattern;
public class EmailAddressValidator implements Validator {
private static final Pattern EMAIL_ADDRESS_PATTERN = Pattern.compile(
- "[a-zA-Z0-9\\+\\.\\_\\%\\-\\+]{1,256}" +
+ "[a-zA-Z0-9\\+\\.\\_\\%\\-]{1,256}" +
"\\@" +
"[a-z... | 1 |
package com.fsck.k9;
import android.text.util.Rfc822Tokenizer;
import android.widget.AutoCompleteTextView.Validator;
import java.util.regex.Pattern;
public class EmailAddressValidator implements Validator {
private static final Pattern EMAIL_ADDRESS_PATTERN = Pattern.compile(
"[a-zA-Z0-9\\+\\.\\_\\%\\... | 1 | 15,602 | We're already matching +. Not sure why this changed. | k9mail-k-9 | java |
@@ -34,6 +34,14 @@ class Configuration implements ConfigurationInterface
->children()
->scalarNode('db_driver')->isRequired()->end()
->scalarNode('default_context')->isRequired()->end()
+ ->scalarNode('category_manager')
+ ->info('if sonat... | 1 | <?php
/*
* This file is part of the Sonata Project package.
*
* (c) Thomas Rabaix <thomas.rabaix@sonata-project.org>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/
namespace Sonata\MediaBundle\DependencyInjection;
use Symfony\C... | 1 | 6,915 | Please add line breaks, so the line doesn't exceed 80 chars. | sonata-project-SonataMediaBundle | php |
@@ -29,11 +29,10 @@ namespace OpenTelemetry.Instrumentation.AspNetCore
/// <summary>
/// Initializes a new instance of the <see cref="AspNetCoreInstrumentation"/> class.
/// </summary>
- /// <param name="activitySource">ActivitySource adapter instance.</param>
/// <param name=... | 1 | // <copyright file="AspNetCoreInstrumentation.cs" company="OpenTelemetry Authors">
// Copyright The OpenTelemetry Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://... | 1 | 19,274 | I initially thought (inccoreclty) this is a breaking change! The public api analyzer is a gift! | open-telemetry-opentelemetry-dotnet | .cs |
@@ -243,7 +243,7 @@ _ostree_delta_compute_similar_objects (OstreeRepo *repo,
{
gboolean ret = FALSE;
g_autoptr(GHashTable) ret_modified_regfile_content =
- g_hash_table_new_full (g_str_hash, g_str_equal, g_free, (GDestroyNotify)g_ptr_array_unref);
+ g_hash_table_new_full (g_str_hash, g_str_... | 1 | /* -*- mode: C; c-file-style: "gnu"; indent-tabs-mode: nil; -*-
*
* Copyright (C) 2015 Colin Walters <walters@verbum.org>
*
* This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public
* License as published by the Free Software Foundation; either
*... | 1 | 9,056 | I'm not sure how this one didn't segfault before. | ostreedev-ostree | c |
@@ -27,6 +27,13 @@ import (
)
var _ = Describe("Endpoints", func() {
+ const (
+ ProtoUDP = 17
+ ProtoIPIP = 4
+ VXLANPort = 0
+ VXLANVNI = 0
+ )
+
for _, trueOrFalse := range []bool{true, false} {
kubeIPVSEnabled := trueOrFalse
var rrConfigNormalMangleReturn = Config{ | 1 | // Copyright (c) 2017-2018 Tigera, Inc. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by ... | 1 | 16,990 | Same points as in other test file. | projectcalico-felix | c |
@@ -16,14 +16,7 @@
*/
package org.apache.lucene.analysis.hunspell;
-import java.io.BufferedInputStream;
-import java.io.BufferedOutputStream;
-import java.io.BufferedReader;
-import java.io.IOException;
-import java.io.InputStream;
-import java.io.InputStreamReader;
-import java.io.LineNumberReader;
-import java.i... | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may ... | 1 | 39,406 | Did you run gradlew tidy? Wildcard imports shouldn't be there, hence the question. | apache-lucene-solr | java |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.