patch stringlengths 17 31.2k | y int64 1 1 | oldf stringlengths 0 2.21M | idx int64 1 1 | id int64 4.29k 68.4k | msg stringlengths 8 843 | proj stringclasses 212
values | lang stringclasses 9
values |
|---|---|---|---|---|---|---|---|
@@ -35,7 +35,6 @@ class BZAObject(dict):
self.token = None
self.log = logging.getLogger(self.__class__.__name__)
self.http_session = requests.Session()
- self.http_request = self.http_session.request
# copy infrastructure from prototype
if isinstance(proto, BZAObjec... | 1 | """
The idea for this module is to keep it separate from bzt codebase as much as possible,
it may become separate library in the future. Things like imports and logging should be minimal.
"""
import base64
import json
import logging
import time
from collections import OrderedDict
import requests
from bzt import Tauru... | 1 | 14,993 | this is used as important way of mocking for unit tests, FYI | Blazemeter-taurus | py |
@@ -156,6 +156,7 @@ if not config.style_17:
options.Points = Options('plot', show_frame=True)
options.Histogram = Options('style', line_color='black', fill_color=Cycle())
+options.Distribution = Options('style', muted_alpha=0.2)
options.ErrorBars = Options('style', color='black')
options.Spread = Options('sty... | 1 | from __future__ import absolute_import
from distutils.version import LooseVersion
import numpy as np
import bokeh
from bokeh.palettes import all_palettes
from ...core import (Store, Overlay, NdOverlay, Layout, AdjointLayout,
GridSpace, GridMatrix, NdLayout, config)
from ...element import (Curve,... | 1 | 19,715 | Sorry, should have been clearer, I meant adding this to the ``Histogram`` options one line above. | holoviz-holoviews | py |
@@ -566,7 +566,7 @@ namespace pwiz.SkylineTest
// Bad terminus
AssertEx.DeserializeError<StaticMod>("<static_modification name=\"Mod\" terminus=\"X\" formula=\"C23N\" />");
// Bad formula
- AssertEx.DeserializeError<StaticMod, ArgumentException>("<static_modification na... | 1 | /*
* Original author: Brendan MacLean <brendanx .at. u.washington.edu>,
* MacCoss Lab, Department of Genome Sciences, UW
*
* Copyright 2009 University of Washington - Seattle, WA
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in com... | 1 | 12,410 | Just ignorance on my part, but what is the significance of the change from C23NHe2 to C23NHx2? | ProteoWizard-pwiz | .cs |
@@ -486,6 +486,12 @@ class histogram(Operation):
bin_range = param.NumericTuple(default=None, length=2, doc="""
Specifies the range within which to compute the bins.""")
+ bins = param.ClassSelector(default=None, class_=(np.ndarray, list), doc="""
+ An explicit set of bin edges.""")
+
+ cumula... | 1 | """
Collection of either extremely generic or simple Operation
examples.
"""
from __future__ import division
import numpy as np
import param
from param import _is_number
from ..core import (Operation, NdOverlay, Overlay, GridMatrix,
HoloMap, Dataset, Element, Collator, Dimension)
from ..core.data... | 1 | 21,264 | What about tuples or pandas series? Do we want to support lots of different types or force a single type? | holoviz-holoviews | py |
@@ -294,10 +294,6 @@ public class ZkStateReader implements SolrCloseable {
log.debug("Loading collection config from: [{}]", path);
try {
- if (zkClient.exists(path, true) == false) {
- log.warn("No collection found at path {}.", path);
- throw new KeeperException.NoNodeException("No coll... | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may ... | 1 | 33,384 | Small thing, without the check above this will throw a NoNodeException if the path doesn't exist. Maybe this can be wrapped in a try/catch just for the NoNodeException, so that the more user-friendly message used above can be thrown instead: `throw new KeeperException.NoNodeException("No collection found at path: " + p... | apache-lucene-solr | java |
@@ -17,7 +17,7 @@ class Project < ActiveRecord::Base
validates :url_name, presence: true, length: 1..60, allow_nil: false, uniqueness: { case_sensitive: false }
validates :description, length: 0..800, allow_nil: true # , if: proc { |p| p.validate_url_name_and_desc == 'true' }
validates_each :url, :download_url... | 1 | class Project < ActiveRecord::Base
include ProjectAssociations
include LinkAccessors
include Tsearch
include ProjectSearchables
include ProjectScopes
include ProjectJobs
acts_as_editable editable_attributes: [:name, :url_name, :logo_id, :organization_id, :best_analysis_id,
... | 1 | 7,981 | I don't know why this worked before, but we should be explicit on not verifying that a blank string (allowed as a way to remove a url/download_url) is a valid url as it is not. | blackducksoftware-ohloh-ui | rb |
@@ -212,8 +212,7 @@ module Bolt
return unless !stdout.empty? && stdout.to_i < 3
- msg = "Detected PowerShell 2 on controller. PowerShell 2 is deprecated and "\
- "support will be removed in Bolt 3.0."
+ msg = "Detected PowerShell 2 on controller. PowerShell 2 is unsupported."
... | 1 | # frozen_string_literal: true
# Avoid requiring the CLI from other files. It has side-effects - such as loading r10k -
# that are undesirable when using Bolt as a library.
require 'uri'
require 'benchmark'
require 'json'
require 'io/console'
require 'logging'
require 'optparse'
require 'bolt/analytics'
require 'bolt/... | 1 | 17,454 | Do we want to raise an error here instead of warning? Or would it be better to just see if Bolt happens to succeed, and let it fail on it's own if it fails? I'd lean towards raising an error, but that's different from "removing support". | puppetlabs-bolt | rb |
@@ -44,7 +44,12 @@ module Bolt
# Returns options this transport supports
def self.options
- raise NotImplementedError, "self.options() must be implemented by the transport class"
+ raise NotImplementedError,
+ "self.options() or self.filter_options(unfiltered) must be implemen... | 1 | # frozen_string_literal: true
require 'logging'
require 'bolt/result'
module Bolt
module Transport
# This class provides the default behavior for Transports. A Transport is
# responsible for uploading files and running commands, scripts, and tasks
# on Targets.
#
# Bolt executes work on the Tran... | 1 | 10,095 | This is kind of confusing with the other `filter_options`. | puppetlabs-bolt | rb |
@@ -160,7 +160,12 @@ func (fs *KBFSOpsStandard) DeleteFavorite(ctx context.Context,
return fs.opsByFav[fav]
}()
if ops != nil {
- return ops.deleteFromFavorites(ctx, fs.favs)
+ err := ops.deleteFromFavorites(ctx, fs.favs)
+ if _, ok := err.(OpsCantHandleFavorite); !ok {
+ return err
+ }
+ // If the ops co... | 1 | // Copyright 2016 Keybase Inc. All rights reserved.
// Use of this source code is governed by a BSD
// license that can be found in the LICENSE file.
package libkbfs
import (
"fmt"
"sync"
"time"
"github.com/keybase/client/go/logger"
"golang.org/x/net/context"
)
// KBFSOpsStandard implements the KBFSOps interf... | 1 | 11,883 | Could the `deleteFromFavorites` happen when `head == nil` because it's not initialized yet somehow but not because TLF doesn't exist? I was concerned if this would make it possible in any way to have favorites seemingly deleted on a device while it's not actually happened on server. | keybase-kbfs | go |
@@ -457,7 +457,7 @@ void CmpSeabaseDDL::dropSeabaseSchema(StmtDDLDropSchema * dropSchemaNode)
bool isVolatile = (memcmp(schName.data(),"VOLATILE_SCHEMA",strlen("VOLATILE_SCHEMA")) == 0);
int32_t length = 0;
- int32_t rowCount = 0;
+ Int64 rowCount = 0;
bool someObjectsCouldNotBeDropped = false;
ch... | 1 | /**********************************************************************
// @@@ START COPYRIGHT @@@
//
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. ... | 1 | 16,373 | It doesn't look like this particular "rowCount" variable is used anywhere. I suppose we could delete it. The code change is harmless though. | apache-trafodion | cpp |
@@ -380,6 +380,10 @@ func (s *Server) ServeHTTP(w http.ResponseWriter, r *http.Request) {
status, _ := s.serveHTTP(w, r)
+ if status == 204 {
+ w.WriteHeader(http.StatusNoContent)
+ }
+
// Fallback error response in case error handling wasn't chained in
if status >= 400 {
DefaultErrorFunc(w, r, status) | 1 | // Copyright 2015 Light Code Labs, LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agre... | 1 | 12,491 | Hmm, probably we should instead write whatever `status` is returned instead of coding a special case. | caddyserver-caddy | go |
@@ -128,6 +128,10 @@ func parsedRuleToProtoRule(in *ParsedRule) *proto.Rule {
}
}
+ if in.HTTPMatch != nil {
+ out.HttpMatch = &proto.HTTPMatch{Methods: in.HTTPMatch.Methods}
+ }
+
// Fill in the ICMP fields. We can't follow the pattern and make a
// convertICMP() function because we can't name the return ... | 1 | // Copyright (c) 2016-2018 Tigera, Inc. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by ... | 1 | 16,363 | Could using the pointer-to-struct approach here cause confusion later? We've had several problems of that kind in the past. What does it mean if the struct is non-nil but its fields are nil? Is that even allowed? (libcalico-go question) Are there any validation requirements for this new rule addition; should it only be... | projectcalico-felix | c |
@@ -11,6 +11,7 @@ class User < ActiveRecord::Base
has_many :approvals
has_many :observations
+ has_many :observers, through: :observers, source: :user
has_many :comments
# we do not use rolify gem (e.g.) but declare relationship like any other. | 1 | class User < ActiveRecord::Base
has_paper_trail class_name: 'C2Version'
validates :client_slug, inclusion: {
in: ->(_) { Proposal.client_slugs },
message: "'%{value}' is not in Proposal.client_slugs #{Proposal.client_slugs.inspect}",
allow_blank: true
}
validates :email_address, presence: true, uni... | 1 | 14,963 | why this recursive relationship definition? | 18F-C2 | rb |
@@ -40,7 +40,8 @@ type Procedure struct {
// HandlerSpec specifiying which handler and rpc type.
HandlerSpec HandlerSpec
- // Encoding of the handler, for introspection.
+ // Encoding of the handler, optional, used for introspection, and used for
+ // routing if present.
Encoding Encoding
// Signature of th... | 1 | // Copyright (c) 2017 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge... | 1 | 13,900 | More sentence, less list please. > Encoding of the handler. This field is optional. We don't need to mention exactly what it's used for because that list can expand (as it has already in this change). | yarpc-yarpc-go | go |
@@ -66,6 +66,10 @@
// are included because they call NewRangeReader.)
// - NewWriter, from creation until the call to Close.
//
+// It also collects the following metrics:
+// - gocloud.dev/blob/bytes_read: the total number of bytes read, by provider.
+// - gocloud.dev/blob/bytes_written: the total number of bytes... | 1 | // Copyright 2018 The Go Cloud Development Kit Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// https://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by appli... | 1 | 14,205 | Not part of this PR, but should the section above say what the name of the metric is for each method? | google-go-cloud | go |
@@ -75,13 +75,13 @@ namespace OpenTelemetry.Exporter
case MetricType.LongGauge:
{
- // TODOs
+ valueDisplay = (metric as IGaugeMetric).LastValue.Value.ToString();
break;... | 1 | // <copyright file="ConsoleMetricExporter.cs" company="OpenTelemetry Authors">
// Copyright The OpenTelemetry Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.... | 1 | 21,014 | there are changes that are upcoming to this section. For now, this works (to demo the usage of Gauge), and the changes to this section are coming as separate PRs. | open-telemetry-opentelemetry-dotnet | .cs |
@@ -95,7 +95,7 @@ func (t *Terminal) run(ctx context.Context) {
for {
select {
case <-ctx.Done():
- if IsProcessBackground() {
+ if IsProcessBackground(t.fd) {
// ignore all messages, do nothing, we are in the background process group
continue
} | 1 | package termstatus
import (
"bufio"
"bytes"
"context"
"fmt"
"io"
"os"
"strings"
"golang.org/x/crypto/ssh/terminal"
)
// Terminal is used to write messages and display status lines which can be
// updated. When the output is redirected to a file, the status lines are not
// printed.
type Terminal struct {
wr... | 1 | 14,270 | This is equivalent to stdout. Why not just replace stdin with stdout in `IsProcessBackground`? | restic-restic | go |
@@ -61,7 +61,10 @@ void DataMan::add_stream(json p_jmsg)
man->init(p_jmsg);
this->add_next(method, man);
}
- add_man_to_path("zfp", method);
+ if (p_jmsg["compress_method"] != nullptr)
+ {
+ add_man_to_path(p_jmsg["compress_method"], method);
+ }
}
void DataMan::flush() { f... | 1 | /*
* Distributed under the OSI-approved Apache License, Version 2.0. See
* accompanying file Copyright.txt for details.
*
* DataMan.cpp
*
* Created on: Apr 12, 2017
* Author: Jason Wang
*/
#include "DataMan.h"
int DataMan::init(json p_jmsg) { return 0; }
int DataMan::put(const void *p_data, std::strin... | 1 | 11,411 | Rather than test for nullptr, just treat the pointer as a bool, i.e. `if(p_jmsg["compress_method"])` | ornladios-ADIOS2 | cpp |
@@ -146,6 +146,17 @@ public class LibraryFeaturePanel extends FeaturePanel<LibraryFeaturePanel, Libra
// get container
// TODO: smarter way using container manager
final String executablePath = shortcutCreationDTO.getExecutable().getAbsolutePath();
+ if (!executablePath.startsWith(getC... | 1 | package org.phoenicis.javafx.components.library.control;
import com.fasterxml.jackson.databind.ObjectMapper;
import javafx.application.Platform;
import javafx.beans.property.ObjectProperty;
import javafx.beans.property.SimpleObjectProperty;
import javafx.beans.property.SimpleStringProperty;
import javafx.beans.propert... | 1 | 14,525 | Can we move the remaining code of this method to a new method? I don't like the `return;` here, we could try to replace it with an `if ... else ...` syntax. What do you think? | PhoenicisOrg-phoenicis | java |
@@ -0,0 +1,14 @@
+from kinto.core.events import ResourceChanged
+
+from .listener import on_resource_changed
+
+
+def includeme(config):
+ config.add_api_capability('quotas',
+ description='Quotas Management on Buckets.',
+ url='https://kinto.readthedocs.io')... | 1 | 1 | 9,625 | nitpick: _and collections_ | Kinto-kinto | py | |
@@ -42,6 +42,8 @@ struct rp_generator_t {
int is_websocket_handshake;
int had_body_error; /* set if an error happened while fetching the body so that we can propagate the error */
h2o_timer_t send_headers_timeout;
+ unsigned req_done : 1;
+ unsigned res_done : 1;
};
struct rp_ws_upgrade_info_t ... | 1 | /*
* Copyright (c) 2014,2015 DeNA Co., Ltd., Kazuho Oku, Masahiro Nagano
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to
* deal in the Software without restriction, including without limitation the
* rights... | 1 | 13,511 | I believe these need to be explicitly initialized in `proxy_send_prepare` | h2o-h2o | c |
@@ -160,6 +160,7 @@ class TaskProcess(multiprocessing.Process):
# Need to have different random seeds if running in separate processes
random.seed((os.getpid(), time.time()))
+ t0 = time.time() # Failed task start time
status = FAILED
expl = ''
missing = [] | 1 | # -*- coding: utf-8 -*-
#
# Copyright 2012-2015 Spotify AB
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law... | 1 | 16,239 | This is unnecessary. The declaration of `t0` on line 179 is still in scope inside the `except` block. | spotify-luigi | py |
@@ -1,6 +1,15 @@
*/
+/**
+ * The border color when the client is marked.
+ * It has priority over the rest of beautiful border color properties.
+ * Note that only solid colors are supported.
+ * @beautiful beautiful.border_color_marked
+ * @param color
+ * @see request::border
+ */
+
/**
* The fallback border ... | 1 | */
/**
* The fallback border color when the client is floating.
*
* @beautiful beautiful.border_color_floating
* @param color
* @see request::border
* @see beautiful.border_color_floating_active
* @see beautiful.border_color_floating_normal
* @see beautiful.border_color_floating_urgent
* @see beautiful.borde... | 1 | 18,741 | The `border_color_`... properties don't support solid colors, not only this one. Maybe `@param solid_color` should be used instead of adding this note to every one of them? | awesomeWM-awesome | c |
@@ -0,0 +1,19 @@
+module.exports = {
+ roots: [
+ "<rootDir>/javascript/grid-ui/src"
+ ],
+ testMatch: [
+ "<rootDir>/javascript/grid-ui/src/tests/**/*.test.tsx"
+ ],
+ transform: {
+ "^.+\\.(ts|tsx)$": "ts-jest"
+ },
+ moduleFileExtensions: ["ts", "tsx", "js", "jsx", "json", "node"],
+ snapshotSeriali... | 1 | 1 | 18,309 | We don't need this file, we can use the one that is in the grid-ui directory | SeleniumHQ-selenium | js | |
@@ -48,6 +48,10 @@ public class BazelIgnoreParser {
try {
for (String path : FileOperationProvider.getInstance().readAllLines(bazelIgnoreFile)) {
+ if (!isEmptyLine(path)) {
+ continue;
+ }
+
if (path.endsWith("/")) {
// .bazelignore allows the "/" path suffix, b... | 1 | /*
* Copyright 2019 The Bazel Authors. All rights reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by a... | 1 | 5,478 | FYI: inlined this method in the internal review. | bazelbuild-intellij | java |
@@ -17,10 +17,8 @@ import org.junit.Test;
import org.junit.runner.RunWith;
import java.util.ArrayList;
-import java.util.Arrays;
import java.util.Date;
import java.util.List;
-import java.util.concurrent.CountDownLatch;
import java.util.concurrent.TimeUnit;
import de.danoeh.antennapod.core.feed.Feed; | 1 | package de.test.antennapod.service.download;
import android.content.Context;
import android.content.Intent;
import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
import androidx.core.util.Consumer;
import androidx.test.platform.app.InstrumentationRegistry;
import androidx.test.ext.junit.runners.Andr... | 1 | 17,830 | Werid, the checksum between this file and the one on branch `develop` is the same not sure why it's showing a diff | AntennaPod-AntennaPod | java |
@@ -47,7 +47,7 @@ namespace OpenTelemetry.Exporter
foreach (var metric in exporter.Metrics)
{
var builder = new PrometheusMetricBuilder()
- .WithName(metric.Name)
+ .WithName(metric.Meter.Name + metric.Name)
.WithDescr... | 1 | // <copyright file="PrometheusExporterExtensions.cs" company="OpenTelemetry Authors">
// Copyright The OpenTelemetry Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http... | 1 | 21,561 | Prometheus doesn't have concept of Meter (like OTLP does).. Trying to see if this is a good approach to use the meter name as namespace, to avoid name collisions, when same instrument name is used across multiple instruments, from different Meter. | open-telemetry-opentelemetry-dotnet | .cs |
@@ -78,10 +78,17 @@ class LibraryCardsController extends AbstractBase
// Connect to the ILS for login drivers:
$catalog = $this->getILS();
+ $config = $this->getConfig();
+ $allowConnectingCards = !empty(
+ $config->Catalog
+ ->auth_based_library_cards
+ ... | 1 | <?php
/**
* LibraryCards Controller
*
* PHP version 7
*
* Copyright (C) Villanova University 2010.
* Copyright (C) The National Library of Finland 2015-2019.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 2,
* as publishe... | 1 | 30,733 | The formatting of this is a bit strange; I'd suggest collapsing this back to a single line, and moving the `&&` to the beginning of the second line to meet the line length restriction. | vufind-org-vufind | php |
@@ -1791,7 +1791,7 @@ create_and_initialize_module_data(app_pc start, app_pc end, app_pc entry_point,
copy->segments[i].end = os_segments[i].end;
copy->segments[i].prot = os_segments[i].prot;
}
- } else
+ } else if (segments != NULL)
memcpy(copy->segments, segments, num... | 1 | /* ******************************************************************************
* Copyright (c) 2010-2017 Google, Inc. All rights reserved.
* Copyright (c) 2010-2011 Massachusetts Institute of Technology All rights reserved.
* Copyright (c) 2002-2010 VMware, Inc. All rights reserved.
* ************************... | 1 | 11,122 | One or the other should be non-NULL. If segments is NULL, the alloc above will have size zero, which we do not allow (there's no header): it should assert in debug build. So there should be asserts that one is non-NULL at the top, and if there really needs to be some kind of defensive check down here, it should cover t... | DynamoRIO-dynamorio | c |
@@ -106,7 +106,11 @@ class User < ActiveRecord::Base
def self.from_oauth_hash(auth_hash)
user_data = auth_hash.extra.raw_info.to_hash
- self.find_or_create_by(email_address: user_data['email'])
+ user = self.for_email(user_data['email'])
+ if user_data['first_name'].present? && user_data['last_name']... | 1 | class User < ActiveRecord::Base
has_paper_trail class_name: 'C2Version'
validates :client_slug, inclusion: {
in: ->(_) { Proposal.client_slugs },
message: "'%{value}' is not in Proposal.client_slugs #{Proposal.client_slugs.inspect}",
allow_blank: true
}
validates :email_address, presence: true, uni... | 1 | 15,372 | I'm surprised rubocop isn't picking up singe quotes? | 18F-C2 | rb |
@@ -251,14 +251,7 @@ import (
var _ time.Duration
var _ strings.Reader
var _ aws.Config
-
-func parseTime(layout, value string) *time.Time {
- t, err := time.Parse(layout, value)
- if err != nil {
- panic(err)
- }
- return &t
-}
+var _, _ = protocol.ParseTime("unixTimestamp", "2016-09-27T15:50Z")
`))
| 1 | // +build codegen
package api
import (
"bytes"
"encoding/json"
"fmt"
"os"
"sort"
"strings"
"text/template"
"github.com/aws/aws-sdk-go/private/util"
)
type Examples map[string][]Example
// ExamplesDefinition is the structural representation of the examples-1.json file
type ExamplesDefinition struct {
*API ... | 1 | 9,824 | Is this line still needed? | aws-aws-sdk-go | go |
@@ -153,10 +153,8 @@ bool EDPSimple::createSEDPEndpoints()
watt.endpoint.multicastLocatorList = this->mp_PDP->getLocalParticipantProxyData()->m_metatrafficMulticastLocatorList;
//watt.endpoint.remoteLocatorList = m_discovery.initialPeersList;
watt.endpoint.durabilityKind = TRANSIENT_LOCAL;
- ... | 1 | // Copyright 2016 Proyectos y Sistemas de Mantenimiento SL (eProsima).
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless re... | 1 | 13,524 | Maybe use specific values for all the watt.times fields? Even better, have a const for it at the top of the file? | eProsima-Fast-DDS | cpp |
@@ -21,9 +21,10 @@ import inputCore
#: The directory in which liblouis braille tables are located.
TABLES_DIR = r"louis\tables"
+PATTERNS_TABLE = os.path.join(TABLES_DIR, "braille-patterns.cti")
-#: The table file names and information.
-TABLES = (
+#: The braille table file names and information.
+tables = [
#... | 1 | #braille.py
#A part of NonVisual Desktop Access (NVDA)
#This file is covered by the GNU General Public License.
#See the file COPYING for more details.
#Copyright (C) 2008-2014 NV Access Limited
import itertools
import os
import pkgutil
import wx
import louis
import keyboardHandler
import baseObject
impor... | 1 | 17,316 | nit: UNICODE_BRAILLE_TABLE or something might be a better name for this. IMO, braille-patterns.cti is a terrible name. This table allows Unicode braille characters to be used anywhere to produce raw dots. | nvaccess-nvda | py |
@@ -104,9 +104,6 @@ type Builder struct {
// MachineNetwork is the subnet to use for the cluster's machine network.
MachineNetwork string
-
- // SkipMachinePoolGeneration is set to skip generating MachinePool objects
- SkipMachinePoolGeneration bool
}
// Validate ensures that the builder's fields are logicall... | 1 | package clusterresource
import (
"fmt"
"github.com/ghodss/yaml"
hivev1 "github.com/openshift/hive/pkg/apis/hive/v1"
"github.com/openshift/hive/pkg/constants"
"github.com/openshift/installer/pkg/ipnet"
installertypes "github.com/openshift/installer/pkg/types"
corev1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachin... | 1 | 11,785 | Why are we removing the option to skip machine pool generation? | openshift-hive | go |
@@ -0,0 +1,9 @@
+using System;
+
+namespace Microsoft.AspNetCore.Server.Kestrel.Internal.Http
+{
+ public interface IHttpStartLineHandler
+ {
+ void OnStartLine(HttpMethod method, HttpVersion version, Span<byte> target, Span<byte> path, Span<byte> query, Span<byte> customMethod);
+ }
+} | 1 | 1 | 11,700 | "Request line" here too. | aspnet-KestrelHttpServer | .cs | |
@@ -1292,6 +1292,19 @@ void Corpse::LootItem(Client *client, const EQApplicationPacket *app)
std::vector<EQ::Any> args;
args.push_back(inst);
args.push_back(this);
+ if (RuleB(Zone, UseZoneController)) {
+ if (entity_list.GetNPCByNPCTypeID(ZONE_CONTROLLER_NPC_ID)){
+ if (parse->EventNPC(EVENT_LOOT_ZONE, ... | 1 | /* EQEMu: Everquest Server Emulator
Copyright (C) 2001-2003 EQEMu Development Team (http://eqemulator.net)
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; version 2 of the License.
This program... | 1 | 10,872 | Please remove this. | EQEmu-Server | cpp |
@@ -15,6 +15,7 @@ class Organization::Affiliated < Organization::AccountFacts
accounts = @organization.accounts.joins([:person, :positions])
accounts = accounts.group('accounts.id, people.kudo_position').order('kudo_position nulls last')
accounts.paginate(per_page: limit, page: page)
+ Account.paginat... | 1 | class Organization::Affiliated < Organization::AccountFacts
def initialize(organization)
@organization = organization
end
def stats
Organization.connection.select_one <<-SQL
SELECT #{Organization.send(:sanitize_sql, selects)}
FROM accounts A #{Organization.send(:sanitize_sql, account_facts_jo... | 1 | 6,963 | Weird bug. Combining those joins and group calls was triggering AREL to generate the sql cache inside of will_paginate before the final call. This is a harmless workaround, but hints that will_paginate might becoming seriously deprecated. | blackducksoftware-ohloh-ui | rb |
@@ -75,6 +75,12 @@ class Analysis < ActiveRecord::Base
end.compact.join(' AND ')
end
+ def allowed_tuples
+ [].tap do |tuples|
+ analysis_sloc_sets.each { |analysis_sloc_set| tuples << analysis_sloc_set.allowed_tuples }
+ end.compact.join(' AND ')
+ end
+
def angle
(Math.atan(hotness_scor... | 1 | # frozen_string_literal: true
class Analysis < ActiveRecord::Base
include Analysis::Report
AVG_SALARY = 55_000
EARLIEST_DATE = Time.utc(1971, 1, 1)
EARLIEST_DATE_SQL_STRING = "TIMESTAMP '#{EARLIEST_DATE.strftime('%Y-%m-%d')}'"
ACTIVITY_LEVEL_INDEX_MAP = {
na: 0, new: 10, inactive: 20, very_low: 30, low: ... | 1 | 9,518 | This can be simplified as discussed before. | blackducksoftware-ohloh-ui | rb |
@@ -1,7 +1,14 @@
package execute
-import "github.com/influxdata/flux"
+import (
+ "github.com/influxdata/flux"
+ "github.com/influxdata/flux/execute/table"
+)
func NewProcessMsg(tbl flux.Table) ProcessMsg {
return &processMsg{table: tbl}
}
+
+func NewProcessChunkMsg(chunk table.Chunk) ProcessChunkMsg {
+ retur... | 1 | package execute
import "github.com/influxdata/flux"
func NewProcessMsg(tbl flux.Table) ProcessMsg {
return &processMsg{table: tbl}
}
| 1 | 16,487 | Does `internal` or `test` in the file name actually do anything here? Or is that just to show these functions are only for tests? | influxdata-flux | go |
@@ -12,7 +12,7 @@ describe('Transaction deserialization', function() {
vectors_valid.forEach(function(vector) {
if (vector.length > 1) {
var hexa = vector[1];
- Transaction(hexa).serialize().should.equal(hexa);
+ Transaction(hexa).serialize(true).should.equal(hexa);
index++;
... | 1 | 'use strict';
var Transaction = require('../../lib/transaction');
var vectors_valid = require('../data/bitcoind/tx_valid.json');
var vectors_invalid = require('../data/bitcoind/tx_invalid.json');
describe('Transaction deserialization', function() {
describe('valid transaction test case', function() {
var inde... | 1 | 13,751 | does this boolean indicate unsafe serialization? | bitpay-bitcore | js |
@@ -332,6 +332,13 @@ class Realm {
*/
static deleteFile(config) {}
+ /**
+ * Copy bundled Realm files to app's default file folder.
+ * This is not implemented for node.js.
+ * @throws {Error} If an I/O error occured or method is not implemented.
+ */
+ static copyBundledRealmFiles() ... | 1 | ////////////////////////////////////////////////////////////////////////////
//
// Copyright 2016 Realm Inc.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/li... | 1 | 17,364 | Maybe rewrite to `Is only implemented for React Native`? (I assume that is the case). | realm-realm-js | js |
@@ -246,8 +246,15 @@ public abstract class PageStreamingConfig {
if (pageSizeField == null) {
// TODO: Conform to design doc spec, once approved, for using non-standard paging fields
// (such as max_results for page_size)
- if (language == TargetLanguage.JAVA && transportProtocol == Transp... | 1 | /* Copyright 2016 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in... | 1 | 31,044 | Do we not need this in Java because Java *is* handling map responses? | googleapis-gapic-generator | java |
@@ -279,6 +279,14 @@ class Task(object):
except BaseException:
logger.exception("Error in event callback for %r", event)
+ @property
+ def accepted_messages(self):
+ """
+ Configures which scheduler messages can be received and returns them. When falsy, this t... | 1 | # -*- coding: utf-8 -*-
#
# Copyright 2012-2015 Spotify AB
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law... | 1 | 17,954 | Maybe "For configuring which scheduler messages can be received."? | spotify-luigi | py |
@@ -141,7 +141,7 @@ class SyncThumbsCommand extends BaseCommand
}
//clear entity manager for saving memory
- $this->getMediaManager()->getEntityManager()->clear();
+ $this->getMediaManager()->getObjectManager()->clear();
if ($batchesLimit > 0 && $batchCou... | 1 | <?php
/*
* This file is part of the Sonata Project package.
*
* (c) Thomas Rabaix <thomas.rabaix@sonata-project.org>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/
namespace Sonata\MediaBundle\Command;
use Sonata\MediaBundle\Mo... | 1 | 9,979 | It will stop working with orm, so this is not a good fix, Try using some method in a common interface | sonata-project-SonataMediaBundle | php |
@@ -40,7 +40,11 @@ namespace OpenTelemetry.Collector.Dependencies
{
this.diagnosticSourceSubscriber = new DiagnosticSourceSubscriber(
new Dictionary<string, Func<ITracer, Func<HttpRequestMessage, ISampler>, ListenerHandler>>()
- { { "HttpHandlerDiagnosticListener", ... | 1 | // <copyright file="DependenciesCollector.cs" company="OpenTelemetry Authors">
// Copyright 2018, OpenTelemetry Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://w... | 1 | 12,056 | `s` is not necessarily the same as `sampler` - sampler could be null and this crazy lambda underneath falls back to something. So please use `s` | open-telemetry-opentelemetry-dotnet | .cs |
@@ -83,9 +83,14 @@ public class PojoOperationGenerator extends AbstractOperationGenerator {
bodyModel = new ModelImpl();
bodyModel.setType(ModelImpl.OBJECT);
for (ParameterGenerator parameterGenerator : bodyFields) {
- SwaggerUtils.addDefinitions(swagger, parameterGenerator.getGenericType());
+ ... | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may ... | 1 | 11,231 | This code is a bit confusing. Should HttpParameterType set to the original one or it is always BODY? | apache-servicecomb-java-chassis | java |
@@ -741,7 +741,7 @@ func (c *Client) reallyExecute(tid int, target *core.BuildTarget, command *pb.Co
return nil, nil, err
}
log.Debug("Completed remote build action for %s", target)
- if err := c.verifyActionResult(target, command, digest, response.Result, false, isTest); err != nil {
+ if err := c.verifyAc... | 1 | // Package remote provides our interface to the Google remote execution APIs
// (https://github.com/bazelbuild/remote-apis) which Please can use to distribute
// work to remote servers.
package remote
import (
"context"
"encoding/hex"
"fmt"
"io/ioutil"
"os"
"path"
"path/filepath"
"strings"
"sync"
"time"
"g... | 1 | 9,779 | Why did this change? | thought-machine-please | go |
@@ -55,11 +55,14 @@ func (c *client) DescribeTable(ctx context.Context, region string, tableName str
globalSecondaryIndexes := getGlobalSecondaryIndexes(result.Table.GlobalSecondaryIndexes)
+ status := newProtoForTableStatus(result.Table.TableStatus)
+
ret := &dynamodbv1.Table{
Name: aws.To... | 1 | package aws
import (
"context"
"github.com/aws/aws-sdk-go-v2/aws"
"github.com/aws/aws-sdk-go-v2/service/dynamodb"
"github.com/aws/aws-sdk-go-v2/service/dynamodb/types"
"go.uber.org/zap"
"google.golang.org/grpc/codes"
"google.golang.org/grpc/status"
dynamodbv1 "github.com/lyft/clutch/backend/api/aws/dynamodb/... | 1 | 11,692 | nit: `status` collides with imported package named `status` | lyft-clutch | go |
@@ -584,6 +584,14 @@ func (l *Ledger) trackerEvalVerified(blk bookkeeping.Block, accUpdatesLedger led
return eval(context.Background(), accUpdatesLedger, blk, false, nil, nil)
}
+// IsWritingCatchpointFile returns true when a catchpoint file is being generated. The function is used by the catchup service so
+// th... | 1 | // Copyright (C) 2019-2020 Algorand, Inc.
// This file is part of go-algorand
//
// go-algorand is free software: you can redistribute it and/or modify
// it under the terms of the GNU Affero General Public License as
// published by the Free Software Foundation, either version 3 of the
// License, or (at your option) ... | 1 | 39,913 | "memory pressure could be decreased" --> "to avoid memory pressure" | algorand-go-algorand | go |
@@ -426,8 +426,11 @@ class TestTimescaleListenStore(DatabaseTestCase):
self.assertEqual(count + 1, int(cache.get(user_key, decode=False) or 0))
def test_delete_listens(self):
- self._create_test_data(self.testuser_name)
- listens, min_ts, max_ts = self.logstore.fetch_listens(user_name=self... | 1 | # coding=utf-8
import os
from time import time
from datetime import datetime
import logging
import shutil
import subprocess
import tarfile
import tempfile
import random
import ujson
import psycopg2
import sqlalchemy
import listenbrainz.db.user as db_user
from psycopg2.extras import execute_values
from listenbrainz.db... | 1 | 18,828 | I think it would make sense to fetch the cache values after deleting the listens and making sure they are what we expect. | metabrainz-listenbrainz-server | py |
@@ -169,6 +169,11 @@ export class CollapsibleColumns extends BasePlugin {
});
} else if (Array.isArray(collapsibleColumns)) {
+
+ this.headerStateManager.mapState(() => {
+ return { collapsible: false };
+ });
+
this.headerStateManager.mergeStateWith(collapsibleColumns)... | 1 | import { BasePlugin } from '../base';
import { arrayEach, arrayFilter, arrayUnique } from '../../helpers/array';
import { rangeEach } from '../../helpers/number';
import { warn } from '../../helpers/console';
import {
addClass,
hasClass,
fastInnerText
} from '../../helpers/dom/element';
import EventManager from '... | 1 | 20,749 | I'm thinking about covering this change with the test. Can you do that? | handsontable-handsontable | js |
@@ -41,7 +41,7 @@ var (
// NATProviderPinger pings provider and optionally hands off connection to consumer proxy.
type NATProviderPinger interface {
- PingProvider(ip string, providerPort, consumerPort, proxyPort int, stop <-chan struct{}) error
+ PingProvider(ip string, cPorts, pPorts []int, proxyPort int) (*net.... | 1 | /*
* Copyright (C) 2019 The "MysteriumNetwork/node" Authors.
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
... | 1 | 15,760 | Not sure if it's a good idea to remove stop channel. If user cancels connection how will you stop pinger? | mysteriumnetwork-node | go |
@@ -373,7 +373,13 @@ func (dg *dockerGoClient) pullImage(image string, authData *apicontainer.Registr
return CannotGetDockerClientError{version: dg.version, err: err}
}
- authConfig, err := dg.getAuthdata(image, authData)
+ sdkAuthConfig, err := dg.getAuthdata(image, authData)
+ authConfig := docker.AuthConfigur... | 1 | // Copyright 2014-2018 Amazon.com, Inc. or its affiliates. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License"). You may
// not use this file except in compliance with the License. A copy of the
// License is located at
//
// http://aws.amazon.com/apache2.0/
//
// or in the "license... | 1 | 20,637 | Could you please add a `TODO` here that we won't need `docker.AuthConfiguration` anymore when we migrate to SDK's pull image? | aws-amazon-ecs-agent | go |
@@ -31,6 +31,8 @@ namespace Microsoft.DotNet.Build.CloudTestTasks
public string BlobNamePrefix { get; set; }
+ public ITaskItem[] BlobNames { get; set; }
+
public override bool Execute()
{
return ExecuteAsync().GetAwaiter().GetResult(); | 1 | // Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.
using Microsoft.Build.Framework;
using System;
using System.Collections.Generic;
using System.Globalization;
using ... | 1 | 12,841 | Is there a scenario were we want to get an arbitrary set of blobs that don't share a common root? | dotnet-buildtools | .cs |
@@ -22,5 +22,7 @@ describe('Client Side Encryption', function() {
return testContext.setup(this.configuration);
});
- generateTopologyTests(testSuites, testContext);
+ generateTopologyTests(testSuites, testContext, spec => {
+ return !spec.description.match(/type=regex/);
+ });
}); | 1 | 'use strict';
const path = require('path');
const TestRunnerContext = require('./spec-runner').TestRunnerContext;
const gatherTestSuites = require('./spec-runner').gatherTestSuites;
const generateTopologyTests = require('./spec-runner').generateTopologyTests;
const missingAwsConfiguration =
process.env.AWS_ACCESS_K... | 1 | 16,810 | Can you leave a note about why we are skipping regex tests? | mongodb-node-mongodb-native | js |
@@ -55,10 +55,15 @@ var initCmd = &cmds.Command{
if err != nil {
return err
}
- rep, err := repo.CreateRepo(repoDir, newConfig)
+
+ if err := repo.InitFSRepo(repoDir, newConfig); err != nil {
+ return err
+ }
+ rep, err := repo.OpenFSRepo(repoDir)
if err != nil {
return err
}
+
// The only ... | 1 | package commands
import (
"context"
"fmt"
"io"
"io/ioutil"
"net/http"
"net/url"
"os"
"github.com/ipfs/go-car"
hamt "github.com/ipfs/go-hamt-ipld"
"github.com/ipfs/go-ipfs-blockstore"
cmdkit "github.com/ipfs/go-ipfs-cmdkit"
cmds "github.com/ipfs/go-ipfs-cmds"
"github.com/libp2p/go-libp2p-crypto"
"github... | 1 | 19,023 | This was the only caller of CreateRepo, so I inlined it. | filecoin-project-venus | go |
@@ -109,6 +109,8 @@ type VaultAuth struct {
TokenSecretRef SecretKeySelector `json:"tokenSecretRef,omitempty"`
// This Secret contains a AppRole and Secret
AppRole VaultAppRole `json:"appRole,omitempty"`
+ // Where the authentication path is mounted in Vault.
+ AuthPath string `json:"authPath,omitempty"`
}
ty... | 1 | /*
Copyright 2017 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, ... | 1 | 12,604 | As this is already a child of `auth`, I think we can shorten this to `path` | jetstack-cert-manager | go |
@@ -297,6 +297,14 @@ class UIATextInfo(textInfos.TextInfo):
elif position==textInfos.POSITION_LAST:
self._rangeObj=self.obj.UIATextPattern.documentRange
self.collapse(True)
+ elif position in (textInfos.POSITION_FIRSTVISIBLE, textInfos.POSITION_LASTVISIBLE):
+ try:
+ visiRanges = self.obj.UIATextPatter... | 1 | #NVDAObjects/UIA/__init__.py
#A part of NonVisual Desktop Access (NVDA)
#This file is covered by the GNU General Public License.
#See the file COPYING for more details.
#Copyright (C) 2009-2019 NV Access Limited, Joseph Lee, Mohammad Suliman, Babbage B.V., Leonard de Ruijter
"""Support for UI Automation (UIA) co... | 1 | 25,717 | This call should use element, not 0 I think. | nvaccess-nvda | py |
@@ -223,6 +223,8 @@ type Options struct {
ChunkSize fs.SizeSuffix `config:"chunk_size"`
NoChunk bool `config:"no_chunk"`
Enc encoder.MultiEncoder `config:"encoding"`
+ FetchUntilEmptyPage bool `config:"fet... | 1 | // Package swift provides an interface to the Swift object storage system
package swift
import (
"bufio"
"bytes"
"context"
"errors"
"fmt"
"io"
"net/url"
"path"
"strconv"
"strings"
"time"
"github.com/google/uuid"
"github.com/ncw/swift/v2"
"github.com/rclone/rclone/fs"
"github.com/rclone/rclone/fs/config... | 1 | 13,455 | This is missing the definition of `fetch_until_empty_page` - it needs to go in the config section above. | rclone-rclone | go |
@@ -170,8 +170,8 @@ module Selenium
def macosx_path
path = "/Applications/Firefox.app/Contents/MacOS/firefox-bin"
- path = "~/Applications/Firefox.app/Contents/MacOS/firefox-bin" unless File.exist?(path)
- path = Platform.find_binary("firefox-bin") unless File.exist?(path... | 1 | # encoding: utf-8
#
# Licensed to the Software Freedom Conservancy (SFC) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The SFC licenses this file
# to you under the Apache License, Version 2.0 (the
# "Li... | 1 | 12,881 | I don't think this one needs to be changed since the only previous path is already an absolute one. | SeleniumHQ-selenium | rb |
@@ -200,7 +200,7 @@ public class BaseExpireSnapshotsSparkAction
}
private Dataset<Row> buildValidFileDF(TableMetadata metadata) {
- Table staticTable = newStaticTable(metadata, this.table.io());
+ Table staticTable = newStaticTable(metadata, this.table.io(), table.locationProvider());
return appendTy... | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you ... | 1 | 35,098 | Since we kept the original constructor we might not need this change now. | apache-iceberg | java |
@@ -130,6 +130,7 @@ public class HiveTableOperations extends BaseMetastoreTableOperations {
}
refreshFromMetadataLocation(metadataLocation);
+ LOG.debug("Refreshed [{}]", fullName);
}
@Override | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you ... | 1 | 23,824 | There is already a log in `BaseMetastoreTableOperations` for this. It has the location, but not the table name. Maybe just add table name to that one. | apache-iceberg | java |
@@ -21,6 +21,8 @@ import (
"net/http"
"time"
+ "github.com/pipe-cd/pipe/pkg/filestore/minio"
+
jwtgo "github.com/dgrijalva/jwt-go"
"github.com/spf13/cobra"
"go.uber.org/zap" | 1 | // Copyright 2020 The PipeCD Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agree... | 1 | 9,533 | This should be in the last group. | pipe-cd-pipe | go |
@@ -106,6 +106,7 @@ namespace Datadog.Trace.Agent
{
// stop retrying
Log.Error(exception, "An error occurred while sending traces to the agent at {0}", _tracesEndpoint);
+ _statsd?.Send();
return false... | 1 | using System;
using System.Collections.Generic;
using System.Net.Sockets;
using System.Threading.Tasks;
using Datadog.Trace.Agent.MessagePack;
using Datadog.Trace.DogStatsd;
using Datadog.Trace.Logging;
using Datadog.Trace.PlatformHelpers;
using Datadog.Trace.Vendors.Newtonsoft.Json;
using Datadog.Trace.Vendors.StatsdC... | 1 | 17,592 | I believe you should either remove this or rename the PR. You can't change the behavior of the tracer (even to fix a bug) in a PR named "unit test improvements" | DataDog-dd-trace-dotnet | .cs |
@@ -0,0 +1,8 @@
+// +k8s:deepcopy-gen=package,register
+// +k8s:conversion-gen=github.com/munnerz/cert-manager/pkg/apis/certmanager
+// +k8s:openapi-gen=true
+// +k8s:defaulter-gen=TypeMeta
+
+// Package v1alpha1 is the v1alpha1 version of the API.
+// +groupName=certmanager.k8s.io
+package v1alpha1 | 1 | 1 | 10,629 | I've gone with this group name, however I'm open to suggestions on alternatives! | jetstack-cert-manager | go | |
@@ -32,6 +32,7 @@ public class RpcApis {
public static final RpcApi TX_POOL = new RpcApi("TXPOOL");
public static final RpcApi TRACE = new RpcApi("TRACE");
public static final RpcApi PLUGINS = new RpcApi("PLUGINS");
+ public static final RpcApi QUORUM = new RpcApi("QUORUM");
public static final List<RpcA... | 1 | /*
* Copyright ConsenSys AG.
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing... | 1 | 24,284 | should this be GOQUORUM | hyperledger-besu | java |
@@ -49,7 +49,7 @@ type (
var cpuprofile = flag.String("cpuprofile", "", "write cpu profile to file")
// Validate for the byzantine node uses the actual block validator and returns the opposite
-func (v *byzVal) Validate(blk *blockchain.Block, tipHeight uint64, tipHash hash.Hash32B) error {
+func (v *byzVal) Validat... | 1 | // Copyright (c) 2018 IoTeX
// This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no
// warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent
// permitted by law, all liability for your use of the cod... | 1 | 12,154 | I think checkCoinbase is not skipping checking coinbase. Instead, true-> checking num(coinbase tx) = 1, false -> checking num(coinbase tx) = 0. | iotexproject-iotex-core | go |
@@ -24,14 +24,13 @@ import (
"github.com/iotexproject/iotex-core/config"
"github.com/iotexproject/iotex-core/db"
"github.com/iotexproject/iotex-core/state"
- "github.com/iotexproject/iotex-core/state/factory"
"github.com/iotexproject/iotex-core/test/identityset"
"github.com/iotexproject/iotex-core/test/mock/m... | 1 | // Copyright (c) 2019 IoTeX Foundation
// This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no
// warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent
// permitted by law, all liability for your use... | 1 | 19,623 | same here, move it out | iotexproject-iotex-core | go |
@@ -42,11 +42,17 @@
//@HEADER
*/
+#ifndef KOKKOS_TOOLS_INDEPENDENT_BUILD
#include <Kokkos_Macros.hpp>
#include <Kokkos_Tuners.hpp>
+#endif
+
#include <impl/Kokkos_Profiling.hpp>
-#if defined(KOKKOS_ENABLE_LIBDL)
+#include <impl/Kokkos_Profiling_Interface.hpp>
+
+#if defined(KOKKOS_ENABLE_LIBDL) || defined(KOKKOS... | 1 | /*
//@HEADER
// ************************************************************************
//
// Kokkos v. 3.0
// Copyright (2020) National Technology & Engineering
// Solutions of Sandia, LLC (NTESS).
//
// Under the terms of Contract DE-NA0003525 with NTESS,
// the U.S. Govern... | 1 | 31,347 | Can you elaborate on why you need different behavior depending on Tools being built independently or not? | kokkos-kokkos | cpp |
@@ -18,7 +18,8 @@ class AnnotationsController < ApplicationController
guid_save = guidance.present? ? guidance.save : true
if ex_save && guid_save
- redirect_to admin_show_phase_path(id: @question.section.phase_id, section_id: @question.section_id, question_id: @question.id, edit: 'true'), notice: _('I... | 1 | class AnnotationsController < ApplicationController
respond_to :html
after_action :verify_authorized
#create annotations
def admin_create
# authorize the question (includes to reduce queries)
@question = Question.includes(section: { phase: :template}).find(params[:question_id])
authorize @question
... | 1 | 16,750 | because of the above if statement will requires both ex_save and guid_save to be true, this code will always return 'example answer'. This should be revised with `example_answer.present?` and `guidance.present?` | DMPRoadmap-roadmap | rb |
@@ -5,6 +5,7 @@ import (
"testing"
"github.com/stretchr/testify/assert"
+ "golang.org/x/net/context"
"github.com/sonm-io/core/insonmnia/structs"
pb "github.com/sonm-io/core/proto" | 1 | package marketplace
import (
"fmt"
"testing"
"github.com/stretchr/testify/assert"
"github.com/sonm-io/core/insonmnia/structs"
pb "github.com/sonm-io/core/proto"
)
func makeOrder() *pb.Order {
return &pb.Order{
Price: 1,
Slot: &pb.Slot{
Resources: &pb.Resources{},
},
}
}
func TestInMemOrderStorage_C... | 1 | 5,962 | why not context from stdlib? | sonm-io-core | go |
@@ -48,7 +48,7 @@ func GenerateCRC32(
return Checksum{
Value: checksum,
Version: payloadVersion,
- Flavor: FlavorIEEECRC32OverThriftBinary,
+ Flavor: FlavorIEEECRC32OverProto3Binary,
}, nil
}
| 1 | // Copyright (c) 2019 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge... | 1 | 9,454 | Just saw this and wasn't able to hold myself from renaming :-). | temporalio-temporal | go |
@@ -278,9 +278,7 @@ describe('src/Core', () => {
plugins: {},
totalProgress: 0
})
- expect(core.plugins.acquirer[0].mocks.uninstall.mock.calls.length).toEqual(
- 1
- )
+ expect(core.plugins[Object.keys(core.plugins)[0]].length).toEqual(0)
})
describe('upload hooks', () => { | 1 | const fs = require('fs')
const path = require('path')
const Core = require('./Core')
const utils = require('./Utils')
const Plugin = require('./Plugin')
const AcquirerPlugin1 = require('../../test/mocks/acquirerPlugin1')
const AcquirerPlugin2 = require('../../test/mocks/acquirerPlugin2')
const InvalidPlugin = require('... | 1 | 10,883 | Can we keep the other assertion too? I think it's helpful to ensure that the uninstall function was called too | transloadit-uppy | js |
@@ -109,7 +109,7 @@ module RSpec
def warn_if_key_taken(source, key, new_block)
return unless existing_block = example_block_for(source, key)
- Kernel.warn <<-WARNING.gsub(/^ +\|/, '')
+ RSpec.warn_with <<-WARNING.gsub(/^ +\|/, '')
|WARNING: Shared example group '#{ke... | 1 | module RSpec
module Core
module SharedExampleGroup
# @overload shared_examples(name, &block)
# @overload shared_examples(name, tags, &block)
#
# Wraps the `block` in a module which can then be included in example
# groups using `include_examples`, `include_context`, or
# `it_be... | 1 | 9,601 | `warn_with` prefixes the message with `WARNING:`, right? So this will put `WARNING:` twice. It would be good to verify all the warnings look good after this change, given how easy it is to make a simple mistake like this :(. | rspec-rspec-core | rb |
@@ -12,6 +12,19 @@ import (
"github.com/filecoin-project/go-filecoin/types"
)
+// MessageTimeOut is the number of tipsets we should receive before timing out messages
+const MessageTimeOut = 6
+
+type timedmessage struct {
+ message *types.SignedMessage
+ addedAt uint64
+}
+
+// BlockTimer defines a interface to a... | 1 | package core
import (
"context"
"sync"
"gx/ipfs/QmNf3wujpV2Y7Lnj2hy2UrmuX8bhMDStRHbnSLh7Ypf36h/go-hamt-ipld"
"gx/ipfs/QmR8BauakNcBa3RbE4nbQu76PDiJgoQgz8AJdhJuiU4TAw/go-cid"
"gx/ipfs/QmVmDhyTTUcQXFD1rRQ64fGLMSAoaQvNH3hwuaCFAPq2hy/errors"
"github.com/filecoin-project/go-filecoin/address"
"github.com/filecoin-pr... | 1 | 17,718 | FYI In the message queue I use the term "stamp" to refer to the time-like mark associated with each message. It's opaque to the queue/pool and should make no difference if the stamps and age limit were converted to seconds. So this could then become `Stamper` with `CurrentStamp()` method, no reference to "blocks" or he... | filecoin-project-venus | go |
@@ -508,8 +508,13 @@ def remove_xml_preamble(response):
# --------------
def get_lifecycle(bucket_name):
bucket_name = normalize_bucket_name(bucket_name)
+ exists, code, body = is_bucket_available(bucket_name)
+ if not exists:
+ return requests_response(body, status_code=code)
+
lifecycle = BUC... | 1 | import random
import re
import logging
import json
import time
from pytz import timezone
import uuid
import base64
import codecs
import xmltodict
import collections
import botocore.config
import six
import datetime
import dateutil.parser
from six.moves.urllib import parse as urlparse
from botocore.client import ClientE... | 1 | 11,027 | Can we remove the `TODO` statement here? (as this is actually fixed in this PR) | localstack-localstack | py |
@@ -198,6 +198,7 @@ public class Account implements BaseAccount, StoreConfig {
private SortType mSortType;
private Map<SortType, Boolean> mSortAscending = new HashMap<SortType, Boolean>();
private ShowPictures mShowPictures;
+ private DisplayPreference mDisplayPreference;
private boolean mIsSigna... | 1 |
package com.fsck.k9;
import java.security.cert.CertificateException;
import java.security.cert.X509Certificate;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Calendar;
import java.util.Collections;
import java.util.Date;
import java.util.List;
import java.util.Map;
import java.util.UUID;
impor... | 1 | 13,598 | m prefix no longer in code style | k9mail-k-9 | java |
@@ -168,6 +168,10 @@ func (kvb *kvStoreWithBuffer) MustDelete(ns string, key []byte) {
kvb.buffer.Delete(ns, key, "failed to delete %x in %s", key, ns)
}
+func (kvb *kvStoreWithBuffer) Filter(ns string, c Condition) ([][]byte, [][]byte, error) {
+ return kvb.store.Filter(ns, c)
+}
+
func (kvb *kvStoreWithBuffer) ... | 1 | package db
import (
"context"
"github.com/pkg/errors"
"github.com/iotexproject/iotex-core/db/batch"
"github.com/iotexproject/iotex-core/pkg/log"
)
type (
withBuffer interface {
Snapshot() int
Revert(int) error
SerializeQueue(batch.WriteInfoFilter) []byte
MustPut(string, []byte, []byte)
MustDelete(str... | 1 | 20,980 | need to filter the entities in buffer as well | iotexproject-iotex-core | go |
@@ -12,6 +12,7 @@ import java.nio.charset.Charset;
import java.security.MessageDigest;
public class FastBlurTransformation extends BitmapTransformation {
+ private static final String ID="de.danoeh.antennapod.core.glide.FastBlurTransformation";
private static final String TAG = FastBlurTransformation.clas... | 1 | package de.danoeh.antennapod.core.glide;
import android.graphics.Bitmap;
import android.media.ThumbnailUtils;
import androidx.annotation.NonNull;
import android.util.Log;
import com.bumptech.glide.load.engine.bitmap_recycle.BitmapPool;
import com.bumptech.glide.load.resource.bitmap.BitmapTransformation;
import java.... | 1 | 20,250 | Please add spaces before and after the equals sign | AntennaPod-AntennaPod | java |
@@ -49,7 +49,7 @@
#endif
#include "common/sql.error_event.pb.h"
#include "common/sql.info_event.pb.h"
-#include "wrapper/amqpwrapper.h"
+//#include "wrapper/amqpwrapper.h"
#include "sq_sql_eventids.h"
#include "common/evl_sqlog_eventnum.h"
| 1 | /**********************************************************************
// @@@ START COPYRIGHT @@@
//
// Licensed to the Apache Software Foundation (ASF) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. ... | 1 | 10,134 | This file could also be cleaned up/deleted. But lets do this separately after ensuring all the event logging has been ported to the current logmxevent_traf.cpp file completely. | apache-trafodion | cpp |
@@ -7,12 +7,13 @@ module RSpec::Core::Formatters
it 'produces the expected full output' do
output = run_example_specs_with_formatter('failures')
expect(output).to eq(<<-EOS.gsub(/^\s+\|/, ''))
- |./spec/rspec/core/resources/formatter_specs.rb:4:is marked as pending but passes
- |./spec/... | 1 | require 'rspec/core/formatters/failure_list_formatter'
module RSpec::Core::Formatters
RSpec.describe FailureListFormatter do
include FormatterSupport
it 'produces the expected full output' do
output = run_example_specs_with_formatter('failures')
expect(output).to eq(<<-EOS.gsub(/^\s+\|/, ''))
... | 1 | 18,054 | :thinking:, the line number here is the line of the example (`example.location`), that's probably why I finally chose to display the example title because it's what can be found on this line, and saying that the error is from there is confusing. But presenting the actual failures is indeed better, so maybe we can get t... | rspec-rspec-core | rb |
@@ -35,7 +35,7 @@ class WebDriver(ChromiumDriver):
def __init__(self, executable_path="chromedriver", port=DEFAULT_PORT,
options=None, service_args=None,
desired_capabilities=None, service_log_path=DEFAULT_SERVICE_LOG_PATH,
- chrome_options=None, service=None, ke... | 1 | # Licensed to the Software Freedom Conservancy (SFC) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The SFC licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not... | 1 | 17,875 | We shouldn't add this as a new `kwarg` here. This should all be done on the options class | SeleniumHQ-selenium | js |
@@ -134,6 +134,7 @@ module Beaker
:openstack_keyname => ENV['OS_KEYNAME'],
:openstack_network => ENV['OS_NETWORK'],
:openstack_region => ENV['OS_REGION'],
+ :openstack_volume_support => ENV['OS_VOL_SUPPORT'] || true,
:jenkins_build_url => nil,
... | 1 | module Beaker
module Options
#A class representing the environment variables and preset argument values to be incorporated
#into the Beaker options Object.
class Presets
# This is a constant that describes the variables we want to collect
# from the environment. The keys correspond to the key... | 1 | 14,817 | Should this be `OS_VOLUME_SUPPORT` to match the symbol key names? | voxpupuli-beaker | rb |
@@ -38,6 +38,8 @@
#include <flux/core.h>
#include "heaptrace.h"
+static flux_msg_handler_t **handlers = NULL;
+
static void start_cb (flux_t *h, flux_msg_handler_t *mh,
const flux_msg_t *msg, void *arg)
{ | 1 | /*****************************************************************************\
* Copyright (c) 2014 Lawrence Livermore National Security, LLC. Produced at
* the Lawrence Livermore National Laboratory (cf, AUTHORS, DISCLAIMER.LLNS).
* LLNL-CODE-658032 All rights reserved.
*
* This file is part of the Flux res... | 1 | 19,606 | In C, file scope variables are already initialized to 0 so the "= NULL" is redundant. Not a big deal. | flux-framework-flux-core | c |
@@ -2,7 +2,7 @@
var nodeName = node.nodeName.toUpperCase(),
nodeType = node.type,
- doc = document;
+ doc = axe.commons.dom.getRootNode(node);
if (node.getAttribute('aria-disabled') === 'true' || axe.commons.dom.findUp(node, '[aria-disabled="true"]')) {
return false; | 1 | /* global document */
var nodeName = node.nodeName.toUpperCase(),
nodeType = node.type,
doc = document;
if (node.getAttribute('aria-disabled') === 'true' || axe.commons.dom.findUp(node, '[aria-disabled="true"]')) {
return false;
}
if (nodeName === 'INPUT') {
return ['hidden', 'range', 'color', 'checkbox', 'radio... | 1 | 11,262 | on line 40, the `relevantNode` can change and therefore the `doc` might change too for the lookup on line 43. I think this code should be moved to where the `doc` is actually being used | dequelabs-axe-core | js |
@@ -57,6 +57,7 @@ namespace OpenTelemetry.Internal
{
throw new ArgumentOutOfRangeException(
nameof(milliseconds),
+ milliseconds,
string.Format(CultureInfo.InvariantCulture, "milliseconds must be between {0} and {1}", MinMillisec... | 1 | // <copyright file="DateTimeOffsetExtensions.net452.cs" company="OpenTelemetry Authors">
// Copyright The OpenTelemetry Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// h... | 1 | 17,486 | nit: just to be similar to others, can you change to interpolation? | open-telemetry-opentelemetry-dotnet | .cs |
@@ -111,6 +111,9 @@ type ControllerOptions struct {
// CertificateRequest -> Order. Slice of string literals that are
// treated as prefixes for annotation keys.
CopiedAnnotationPrefixes []string
+
+ //Return full Certchain including root cert for k8s CSRs
+ FullCertChain bool
}
const ( | 1 | /*
Copyright 2020 The cert-manager Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing... | 1 | 28,671 | Would this make more sense as an option on an Issuer resource (specifically on the CA issuer) rather than as a flag? It's not ideal that we have a flag that _looks_ like it could be 'global' but is actually not IMO. Also, if Istio is reading the CSR object, is it possible for it to read the CA from the CSR itself too a... | jetstack-cert-manager | go |
@@ -10,6 +10,7 @@ class TargetType(Enum):
PANDAS = 'pandas'
FILE = 'file'
+SERVER_TIME_F = "%Y-%m-%dT%H:%M:%S"
DATEF = '%F'
TIMEF = '%T'
DTIMEF = '%s %s' % (DATEF, TIMEF) | 1 | """
Constants
"""
from enum import Enum
class TargetType(Enum):
"""
Enums for target types
"""
PANDAS = 'pandas'
FILE = 'file'
DATEF = '%F'
TIMEF = '%T'
DTIMEF = '%s %s' % (DATEF, TIMEF)
LATEST_TAG = 'latest'
PACKAGE_DIR_NAME = 'quilt_packages'
# reserved words in build.yml
RESERVED = {
'file'... | 1 | 14,973 | Because this acts as a coordination point between client and server, it should go in core.py instead of const.py (so eventually the server could use it to guarantee that it delivers dates in the expected format). | quiltdata-quilt | py |
@@ -212,8 +212,11 @@ func (r *createOrUpdate) Apply(obj *unstructured.Unstructured, subresources ...s
return
}
resource, err = r.options.Getter.Get(obj.GetName(), metav1.GetOptions{})
- if err != nil && apierrors.IsNotFound(errors.Cause(err)) {
- return r.options.Creator.Create(obj, subresources...)
+ if err !=... | 1 | /*
Copyright 2018 The OpenEBS Authors
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, soft... | 1 | 12,865 | expected statement, found 'else' (and 1 more errors) | openebs-maya | go |
@@ -16,6 +16,17 @@ func FakeID(b byte, public bool) ID {
return ID{bytes}
}
+// FakeIDRandomOrBust creates a fake public or private TLF ID from the given
+// byte, and fill the rest with empty bytes.
+func FakeIDRandomOrBust(b byte, public bool) ID {
+ id, err := MakeRandomID(public)
+ if err != nil {
+ panic(err... | 1 | // Copyright 2016 Keybase Inc. All rights reserved.
// Use of this source code is governed by a BSD
// license that can be found in the LICENSE file.
package tlf
// FakeID creates a fake public or private TLF ID from the given
// byte.
func FakeID(b byte, public bool) ID {
bytes := [idByteLen]byte{b}
if public {
... | 1 | 16,741 | IMO this doesn't need to be in the `kbfs` repo. And I don't like setting the byte. We can always compare with the randomly generated `TlfID`. | keybase-kbfs | go |
@@ -0,0 +1,7 @@
+package constants
+
+const (
+ DeviceControllerModuleName = "devicecontroller"
+ CloudHubControllerModuleName = "cloudhub"
+ EdgeControllerModuleName = "edgecontroller"
+) | 1 | 1 | 14,442 | What's the difference from ModuleName in `pkg/apis/meta/v1alpha1/types.go`? | kubeedge-kubeedge | go | |
@@ -8,11 +8,12 @@ using System;
using System.Collections.Generic;
using System.IO;
using System.Linq;
-using System.Reflection.Metadata;
-using System.Reflection.PortableExecutable;
using System.Text;
using Newtonsoft.Json.Linq;
using Newtonsoft.Json;
+using System.Security.Cryptography;
+using System.Reflection.... | 1 | // Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.
using Microsoft.Build.Framework;
using Microsoft.Build.Utilities;
using System;
using System.Collections.Generic;
us... | 1 | 8,542 | We shouldn't be changing this task as we are trying to break our dependency on it and switch to using the shipped version. | dotnet-buildtools | .cs |
@@ -737,8 +737,10 @@ analyze_clean_call(dcontext_t *dcontext, clean_call_info_t *cci, instr_t *where,
* unless multiple regs are able to be skipped.
* XXX: This should probably be in arch-specific clean_call_opt.c.
*/
+
if ((cci->num_simd_skip == 0 /* save all xmms */ &&
- cci->num_regs_s... | 1 | /* **********************************************************
* Copyright (c) 2016 ARM Limited. All rights reserved.
* Copyright (c) 2010-2014 Google, Inc. All rights reserved.
* Copyright (c) 2010 Massachusetts Institute of Technology All rights reserved.
* Copyright (c) 2000-2010 VMware, Inc. All rights reserv... | 1 | 11,614 | Shouldn't we have a low bar for generating out-of-line context switch, i.e., if we need save more than n (3?) simd or m (4) gprs we should go out-of-line? And it should be || instead &&. It seems the bar is still very high after this change. | DynamoRIO-dynamorio | c |
@@ -23,6 +23,7 @@ import (
"go.opentelemetry.io/otel/api/kv"
"go.opentelemetry.io/otel/api/metric"
"go.opentelemetry.io/otel/api/metric/registry"
+ "go.opentelemetry.io/otel/sdk/instrumentation"
)
// This file contains the forwarding implementation of metric.Provider | 1 | // Copyright The OpenTelemetry Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agre... | 1 | 12,520 | Should the API have a dependency on the SDK? | open-telemetry-opentelemetry-go | go |
@@ -1475,7 +1475,7 @@ describe('Change Streams', function() {
}
});
- it('should resume piping of Change Streams when a resumable error is encountered', {
+ it.skip('should resume piping of Change Streams when a resumable error is encountered', {
metadata: {
requires: {
generators: true... | 1 | 'use strict';
const path = require('path');
const assert = require('assert');
const Transform = require('stream').Transform;
const MongoNetworkError = require('../../lib/core').MongoNetworkError;
const setupDatabase = require('./shared').setupDatabase;
const withClient = require('./shared').withClient;
const withCursor... | 1 | 19,152 | Is this a sometimes leaky test? | mongodb-node-mongodb-native | js |
@@ -96,7 +96,11 @@ func (v ConstraintGenerator) typeof(n Node) (PolyType, error) {
ftv := n.ExternType.freeVars(nil)
subst := make(Substitution, len(ftv))
for _, tv := range ftv {
- subst[tv] = v.cs.f.Fresh()
+ f := v.cs.f.Fresh()
+ for ftv.contains(f) {
+ f = v.cs.f.Fresh()
+ }
+ subst[tv] = f
... | 1 | package semantic
import (
"fmt"
"strings"
"github.com/influxdata/flux/ast"
"github.com/pkg/errors"
)
// GenerateConstraints walks the graph and generates constraints between type vairables provided in the annotations.
func GenerateConstraints(node Node, annotator Annotator) (*Constraints, error) {
cg := Constra... | 1 | 9,155 | It should be possible to create a test case that enter the loop. That would be a good enough test case for me. Have a look at the extern type inference test cases that already exist. Since you can just pick the type variables the extern type use, you should be able to create a conflict that requires this loop to fix. | influxdata-flux | go |
@@ -368,6 +368,11 @@ This initializes all modules such as audio, IAccessible, keyboard, mouse, and GU
wxLang=locale.FindLanguageInfo(lang.split('_')[0])
if hasattr(sys,'frozen'):
locale.AddCatalogLookupPathPrefix(os.path.join(os.getcwdu(),"locale"))
+ # #8064: Wx might know the language, but may not actually co... | 1 | # -*- coding: UTF-8 -*-
#core.py
#A part of NonVisual Desktop Access (NVDA)
#Copyright (C) 2006-2018 NV Access Limited, Aleksey Sadovoy, Christopher Toth, Joseph Lee, Peter Vágner, Derek Riemer, Babbage B.V., Zahari Yurukov
#This file is covered by the GNU General Public License.
#See the file COPYING for more det... | 1 | 23,014 | It might make sense to log this. | nvaccess-nvda | py |
@@ -340,12 +340,10 @@ module Blacklight
# too. These model names should not be `#dup`'ed or we might break ActiveModel::Naming.
def deep_copy
deep_dup.tap do |copy|
- copy.repository_class = self.repository_class
- copy.response_model = self.response_model
- copy.docume... | 1 | module Blacklight
##
# Blacklight::Configuration holds the configuration for a Blacklight::Controller, including
# fields to display, facets to show, sort options, and search fields.
class Configuration < OpenStructWithHashAccess
require 'blacklight/configuration/view_config'
require 'blacklight/config... | 1 | 6,032 | Line is too long. [84/80] | projectblacklight-blacklight | rb |
@@ -22,6 +22,7 @@ from selenium.webdriver.common.desired_capabilities import DesiredCapabilities
class Options(object):
+ KEY = "goog:chromeOptions"
def __init__(self):
self._binary_location = '' | 1 | # Licensed to the Software Freedom Conservancy (SFC) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The SFC licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not... | 1 | 14,945 | nice touch since Google likes to change things every now and then. | SeleniumHQ-selenium | java |
@@ -0,0 +1,19 @@
+# Provides a helper utility for loading branding configs.
+module Branding
+
+ module_function
+
+ # Loads branding config from YAML file.
+ #
+ # @param keys [Array<Object>] A list of the keys to return configs for.
+ #
+ # @example Return a value
+ # Branding.fetch(:settings, :should_work) ... | 1 | 1 | 17,781 | Thank you this is so much nicer than the old `Rails.configuration.branding['blah']['blah']['blah']` :) | DMPRoadmap-roadmap | rb |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.