patch stringlengths 17 31.2k | y int64 1 1 | oldf stringlengths 0 2.21M | idx int64 1 1 | id int64 4.29k 68.4k | msg stringlengths 8 843 | proj stringclasses 212
values | lang stringclasses 9
values |
|---|---|---|---|---|---|---|---|
@@ -575,7 +575,7 @@ class decimate(ElementOperation):
The x_range as a tuple of min and max y-value. Auto-ranges
if set to None.""")
- def _process(self, element, key=None):
+ def _apply(self, element, key=None):
if not isinstance(element, Dataset):
raise ValueError("Cannot... | 1 | """
Collection of either extremely generic or simple ElementOperation
examples.
"""
import numpy as np
import param
from param import _is_number
from ..core import (ElementOperation, NdOverlay, Overlay, GridMatrix,
HoloMap, Dataset, Element, Collator)
from ..core.data import ArrayInterface, DictI... | 1 | 16,675 | Not sure I like the name ``_apply``. Even though ``_process`` is supposed to process elements already, how about ``_process_element`` which processes elements, *excluding* Overlays/NdOverlays. | holoviz-holoviews | py |
@@ -131,6 +131,9 @@ const (
// MachineNameTagKey is the key for machine name.
MachineNameTagKey = "MachineName"
+
+ // NodeRoleTagValue describes the value for the node role.
+ NodeRoleTagValue = "node"
)
// ClusterTagKey generates the key for resources associated with a cluster. | 1 | /*
Copyright 2021 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, ... | 1 | 21,456 | Let's use this constant when ASG is created as well (currently hardcoded). | kubernetes-sigs-cluster-api-provider-aws | go |
@@ -152,6 +152,10 @@ CREATE_PACKAGE_HASHES = textwrap.dedent(f"""\
FROM named_packages
""")
+# All GROUP BY statements are supposed to be:
+# - in the order from most unique values to least unique
+# - integers rather than strings
+
OBJECT_ACCESS_COUNTS = textwrap.dedent("""\
SELECT
eventname, | 1 | """
Lambda function that runs Athena queries over CloudTrail logs and .quilt/named_packages/
and creates summaries of object and package access events.
"""
from datetime import datetime, timedelta, timezone
import os
import textwrap
import time
import boto3
ATHENA_DATABASE = os.environ['ATHENA_DATABASE']
# Bucket wh... | 1 | 18,498 | Oh is `bucket` actually higher cardinality than `eventname`? | quiltdata-quilt | py |
@@ -33,6 +33,7 @@ import sip
from PyQt5.QtCore import QUrl
# so it's available for :debug-pyeval
from PyQt5.QtWidgets import QApplication # pylint: disable=unused-import
+from PyQt5.QtWebEngineWidgets import QWebEngineProfile # pylint: disable=unused-import
from qutebrowser.browser import qutescheme
from quteb... | 1 | # vim: ft=python fileencoding=utf-8 sts=4 sw=4 et:
# Copyright 2014-2017 Florian Bruhin (The Compiler) <mail@qutebrowser.org>
#
# This file is part of qutebrowser.
#
# qutebrowser is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free S... | 1 | 18,487 | You can't rely on QtWebEngine being available - but why do you need to import this here at all? | qutebrowser-qutebrowser | py |
@@ -234,6 +234,12 @@ setup(
],
"packages": [
"NVDAObjects",
+ # As of py2exe 0.11.0.0 if the forcibly included package contains subpackages
+ # they need to be listed explicitly (py2exe issue 113).
+ "NVDAObjects.IAccessible",
+ "NVDAObjects.JAB",
+ "NVDAObjects.UIA",
+ "NVDAObjects.window",
... | 1 | # -*- coding: UTF-8 -*-
#setup.py
#A part of NonVisual Desktop Access (NVDA)
#Copyright (C) 2006-2018 NV Access Limited, Peter Vágner, Joseph Lee
#This file is covered by the GNU General Public License.
#See the file COPYING for more details.
import os
import sys
import copy
import gettext
gettext.install("... | 1 | 34,468 | How did you determine these - and how can we be confident that nothing is missing? | nvaccess-nvda | py |
@@ -0,0 +1,3 @@
+<h2>Workshops</h2>
+<h2>Videos</h2>
+<h2>Books</h2> | 1 | 1 | 6,861 | What is this page going to do that is different than the products index we already have? | thoughtbot-upcase | rb | |
@@ -87,7 +87,10 @@ module Selenium
return unless File.exist?(manifest_path)
manifest = JSON.parse(File.read(manifest_path))
- [manifest['name'].delete(' '), manifest['version']].join('@')
+ id = if manifest.key?('application') && manifest['application'].key?('gecko')
+ ... | 1 | # Licensed to the Software Freedom Conservancy (SFC) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The SFC licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not... | 1 | 15,944 | Couldn't you just write this as an if/else or a guard clause like on line 87? Just seems a bit weird doing this conditional assignment for essentially an if/else. | SeleniumHQ-selenium | rb |
@@ -3,9 +3,10 @@ module Travis
class Script
module Addons
class Deploy
- VERSIONED_RUNTIMES = [:jdk, :node, :perl, :php, :python, :ruby, :scala, :node]
+ VERSIONED_RUNTIMES = [:jdk, :node, :perl, :php, :python, :ruby, :scala, :node, :go]
USE_RUBY = '1.9.3'
- ... | 1 | module Travis
module Build
class Script
module Addons
class Deploy
VERSIONED_RUNTIMES = [:jdk, :node, :perl, :php, :python, :ruby, :scala, :node]
USE_RUBY = '1.9.3'
attr_accessor :script, :config, :allow_failure
def initialize(script, config)
... | 1 | 11,223 | Is this intended to be here? Seems it belongs to a different PR. | travis-ci-travis-build | rb |
@@ -20,7 +20,7 @@ namespace Xunit.ConsoleClient
{
try
{
- SetConsoleForegroundColor(ConsoleColor.White);
+ Console.ForegroundColor = ConsoleColor.White;
#if !NETCORE
var netVersion = Environment.Version;
#else | 1 | using System;
using System.Collections.Concurrent;
using System.Diagnostics;
using System.IO;
using System.Linq;
using System.Reflection;
using System.Threading.Tasks;
using System.Xml.Linq;
namespace Xunit.ConsoleClient
{
public class Program
{
volatile static bool cancel;
static bool failed;
... | 1 | 9,822 | These changes, while harmless, were no longer needed with newer versions of System.Console thanks to @ianhays | dotnet-buildtools | .cs |
@@ -58,7 +58,11 @@ logger = logging.getLogger('luigi-interface')
try:
import boto3
- client = boto3.client('ecs')
+ try:
+ import botocore.exceptions
+ client = boto3.client('ecs')
+ except botocore.exceptions.NoRegionError:
+ logger.warning('Your AWS config is missing Region infor... | 1 | # -*- coding: utf-8 -*-
#
# Copyright 2015 Outlier Bio, LLC
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable la... | 1 | 15,688 | Umm... this isn't relevant to this PR | spotify-luigi | py |
@@ -24,6 +24,7 @@ namespace Xunit
Netcoreapp = 0x1000,
Uap = 0x2000,
UapAot = 0x4000,
- NetcoreCoreRT = 0x8000
+ NetcoreCoreRT = 0x8000,
+ All = ~0
}
} | 1 | // Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.
using System;
namespace Xunit
{
[Flags]
public enum TargetFrameworkMonikers
{
Net45 = 0x1,
... | 1 | 12,716 | While All make some sense here it doesn't make a lot of sense in the SkipOnFramework context. I wonder if we really need to expose anything more here. You can just blindly use 0. | dotnet-buildtools | .cs |
@@ -0,0 +1,7 @@
+// Copyright 2021 The Swarm Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+// Package main provides the bee binary viper-cobra
+// command definitions.
+package main | 1 | 1 | 13,681 | Actually, this is not correct. Package `cmd/bee` doe snot have any notion of commands or even libraries used for them. It is as simple as possible, just calling the function from `cmd/bee/cmd` which actually implements commands. | ethersphere-bee | go | |
@@ -7,15 +7,11 @@ const Router = Ember.Router.extend({
});
Router.map(function() {
- this.route('admin', {
- resetNamespace: true
- }, function() {
+ this.route('admin', function() {
this.route('address');
this.route('loaddb');
this.route('lookup', { path: '/' });
- this.route('users', {
- ... | 1 | import Ember from 'ember';
import config from './config/environment';
const Router = Ember.Router.extend({
location: config.locationType,
rootURL: config.rootURL
});
Router.map(function() {
this.route('admin', {
resetNamespace: true
}, function() {
this.route('address');
this.route('loaddb');
... | 1 | 13,237 | This change is causing tests to fail because users sits at `/app/users`, not `/app/admin/users` | HospitalRun-hospitalrun-frontend | js |
@@ -150,4 +150,19 @@ return [
'secure' => false,
+ /*
+ |--------------------------------------------------------------------------
+ | Same-Site Cookies
+ |--------------------------------------------------------------------------
+ |
+ | This option determines how your cookies behave when c... | 1 | <?php
return [
/*
|--------------------------------------------------------------------------
| Default Session Driver
|--------------------------------------------------------------------------
|
| This option controls the default session "driver" that will be used on
| requests. By defau... | 1 | 13,517 | Could you provide more information on what exactly each of those three options do? | octobercms-october | php |
@@ -1,10 +1,12 @@
using System.Collections.Generic;
+using System;
namespace ScenarioMeasurement
{
public class LinuxTraceSession : ITraceSession
{
- public string TraceFilePath { get { return perfCollect?.TraceFilePath; } }
+ public string TraceFilePath {
+ get { return perfCo... | 1 | using System.Collections.Generic;
namespace ScenarioMeasurement
{
public class LinuxTraceSession : ITraceSession
{
public string TraceFilePath { get { return perfCollect?.TraceFilePath; } }
private PerfCollect perfCollect;
private Dictionary<TraceSessionManager.KernelKeyword, PerfColle... | 1 | 11,197 | Why this line break? | dotnet-performance | .cs |
@@ -27,6 +27,7 @@ import (
admissionregistrationv1 "k8s.io/api/admissionregistration/v1"
"k8s.io/apiextensions-apiserver/pkg/apis/apiextensions"
apiextensionsinstall "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/install"
+ apiextensionsv1 "k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1"
v1 "k... | 1 | /*
Copyright 2020 The cert-manager Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing... | 1 | 29,603 | We're importing this twice with different aliases. | jetstack-cert-manager | go |
@@ -98,6 +98,7 @@ if __name__ == "__main__":
"grpcio-tools==1.32.0",
"isort>=4.3.21,<5",
"mock==3.0.5",
+ "pandera<0.8.0",
"protobuf==3.13.0", # without this, pip will install the most up-to-date protobuf
"pylint==2.6.0... | 1 | from typing import Dict
from setuptools import find_packages, setup # type: ignore
def long_description() -> str:
return """
## Dagster
Dagster is a data orchestrator for machine learning, analytics, and ETL.
Dagster lets you define pipelines in terms of the data flow between reusable, logical components,
then... | 1 | 16,951 | We should avoid adding a pandera dependency to Dagster itself. | dagster-io-dagster | py |
@@ -163,9 +163,16 @@ public abstract class PostgrePrivilege implements DBAPrivilege, Comparable<Postg
public void setPermission(PostgrePrivilegeType privilegeType, boolean permit) {
for (ObjectPermission permission : permissions) {
- if (permission.privilegeType == privilegeType) {
+ ... | 1 | /*
* DBeaver - Universal Database Manager
* Copyright (C) 2010-2021 DBeaver Corp and others
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICE... | 1 | 11,591 | Can be replaced with `org.jkiss.utils.ArrayUtils#add`. | dbeaver-dbeaver | java |
@@ -653,7 +653,12 @@ public class ZkController implements Closeable {
customThreadPool.submit(() -> Collections.singleton(overseer).parallelStream().forEach(IOUtils::closeQuietly));
try {
- customThreadPool.submit(() -> electionContexts.values().parallelStream().forEach(IOUtils::closeQuietly));
+ ... | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may ... | 1 | 37,868 | While we're here, this line (and a few others) should be `customThreadPool.submit(() -> IOUtils.closeQuietly(overseer);` I have no idea why we're creating a collection and a stream for a single object. | apache-lucene-solr | java |
@@ -335,6 +335,18 @@ func ValidateACMEChallengeSolverDNS01(p *cmacme.ACMEChallengeSolverDNS01, fldPat
if len(p.AzureDNS.TenantID) == 0 {
el = append(el, field.Required(fldPath.Child("azureDNS", "tenantID"), ""))
}
+ if len(p.AzureDNS.ManagedIdentityClientID) > 0 {
+ el = append(el, field.Forbidde... | 1 | /*
Copyright 2020 The cert-manager Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing... | 1 | 29,054 | Should these restrictions also be reflected in the API docs? | jetstack-cert-manager | go |
@@ -209,6 +209,13 @@ func (s *Server) ServeHTTP(w http.ResponseWriter, r *http.Request) {
return
}
+ // restore original request before invoking error handler chain (issue #3717)
+ origReq := r.Context().Value(OriginalRequestCtxKey).(http.Request)
+ r.Method = origReq.Method
+ r.RemoteAddr = origReq.RemoteAddr
+... | 1 | // Copyright 2015 Matthew Holt and The Caddy Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicab... | 1 | 15,712 | What about the request headers if someone uses `request_header`? :thinking: | caddyserver-caddy | go |
@@ -54,7 +54,12 @@ func (r *ReconcileHiveConfig) deployExternalDNS(hLog log.FieldLogger, h *resourc
deployment := resourceread.ReadDeploymentV1OrDie(asset)
// Make AWS-specific changes to external-dns deployment
- deployment.Spec.Template.Spec.Containers[0].Args = append(deployment.Spec.Template.Spec.Containers[0... | 1 | /*
Copyright 2018 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, ... | 1 | 5,792 | Verify that external-dns allows setting this parameter multiple times (that it's not "last one wins"). | openshift-hive | go |
@@ -80,6 +80,7 @@ class Docker(base.Base):
- nofile:262144:262144
dns_servers:
- 8.8.8.8
+ etc_hosts: "{'host1.example.com': '10.3.1.5'}"
networks:
- name: foo
- name: bar | 1 | # Copyright (c) 2015-2018 Cisco Systems, Inc.
#
# Permission is hereby granted, free of charge, to any person obtaining a copy
# of this software and associated documentation files (the "Software"), to
# deal in the Software without restriction, including without limitation the
# rights to use, copy, modify, merge... | 1 | 9,380 | Maybe 2 host/ip values could be used in the example? | ansible-community-molecule | py |
@@ -139,7 +139,9 @@ namespace Datadog.Trace.Tests.Sampling
var limiter = new RateLimiter(maxTracesPerInterval: intervalLimit);
- var traceContext = new TraceContext(Tracer.Instance);
+ var tracerInstance = new Tracer();
+
+ var traceContext = new TraceContext(tracerInst... | 1 | using System;
using System.Collections.Concurrent;
using System.Diagnostics;
using System.Threading;
using System.Threading.Tasks;
using Datadog.Trace.Sampling;
using Xunit;
namespace Datadog.Trace.Tests.Sampling
{
[Collection(nameof(Datadog.Trace.Tests.Sampling))]
public class RateLimiterTests
{
p... | 1 | 18,299 | We're only testing `RateLimiter.Allowed(Span)`, so I think we can use a mock `ITraceContext` instead of a real `Tracer` or `TraceContext`. | DataDog-dd-trace-dotnet | .cs |
@@ -89,7 +89,8 @@ int main(int argc, char *argv[]) {
lbann_data::Model *pb_model = pb.mutable_model();
auto model = build_model_from_prototext(argc, argv, pb_trainer, pb,
- comm.get(), opts, io_thread_pool, true);
+ comm.g... | 1 | ////////////////////////////////////////////////////////////////////////////////
// Copyright (c) 2014-2019, Lawrence Livermore National Security, LLC.
// Produced at the Lawrence Livermore National Laboratory.
// Written by the LBANN Research Team (B. Van Essen, et al.) listed in
// the CONTRIBUTORS file. <lbann-dev@l... | 1 | 15,193 | IMO, this is the wrong way to associate a model with a trainer... Why the string when you actually have a trainer object? | LLNL-lbann | cpp |
@@ -217,7 +217,7 @@ void ledger_processor::state_block (rai::state_block const & block_a)
void ledger_processor::state_block_impl (rai::state_block const & block_a)
{
auto hash (block_a.hash ());
- auto existing (ledger.store.block_exists (transaction, hash));
+ auto existing (ledger.store.block_exists (transaction... | 1 | #include <rai/node/common.hpp>
#include <rai/node/stats.hpp>
#include <rai/secure/blockstore.hpp>
#include <rai/secure/ledger.hpp>
namespace
{
/**
* Roll back the visited block
*/
class rollback_visitor : public rai::block_visitor
{
public:
rollback_visitor (rai::transaction const & transaction_a, rai::ledger & led... | 1 | 14,603 | Wondering if we can directly put types here & for other similar ledger_processor items like rai::block_type::state | nanocurrency-nano-node | cpp |
@@ -296,17 +296,8 @@ func pruneRepository(gopts GlobalOptions, repo restic.Repository) error {
}
if len(removePacks) != 0 {
- bar = newProgressMax(!gopts.Quiet, uint64(len(removePacks)), "packs deleted")
- bar.Start()
- for packID := range removePacks {
- h := restic.Handle{Type: restic.DataFile, Name: packI... | 1 | package main
import (
"fmt"
"time"
"github.com/restic/restic/internal/debug"
"github.com/restic/restic/internal/errors"
"github.com/restic/restic/internal/index"
"github.com/restic/restic/internal/repository"
"github.com/restic/restic/internal/restic"
"github.com/spf13/cobra"
)
var cmdPrune = &cobra.Command... | 1 | 13,489 | As `DeleteFiles` is not only used for prune this function deserves its own file. Maybe something like `delete_files.go` or `parallel.go`? | restic-restic | go |
@@ -35,7 +35,7 @@ return [
'digits' => ':attribute 必须是 :digits 位的数字。',
'digits_between' => ':attribute 必须是介于 :min 和 :max 位的数字。',
'dimensions' => ':attribute 图片尺寸不正确。',
- 'distinct' => ':attribute 已經存在。',
+ 'distinct' => ':attribute 已经存在。',
... | 1 | <?php
return [
/*
|--------------------------------------------------------------------------
| Validation Language Lines
|--------------------------------------------------------------------------
|
| The following language lines contain the default error messages used by
| the validator ... | 1 | 6,671 | It should be simplified character. `` -> `` | Laravel-Lang-lang | php |
@@ -33,5 +33,9 @@ namespace Nethermind.Trie
void VisitLeaf(TrieNode node, TrieVisitContext trieVisitContext, byte[] value = null);
void VisitCode(Keccak codeHash, TrieVisitContext trieVisitContext);
+
+ bool VisitAccounts => true;
+
+ int ParallelLevels => -1;
}
} | 1 | // Copyright (c) 2021 Demerzel Solutions Limited
// This file is part of the Nethermind library.
//
// The Nethermind library is free software: you can redistribute it and/or modify
// it under the terms of the GNU Lesser General Public License as published by
// the Free Software Foundation, either version 3 of ... | 1 | 25,708 | I am pretty sure it breaks the visitor pattern, visitor should have no knowledge about the structure of what it is visiting or control over visiting mechanism | NethermindEth-nethermind | .cs |
@@ -20,7 +20,7 @@ import java.util.stream.Collector;
import static javaslang.collection.Comparators.naturalComparator;
/**
- * An {@link HashMap}-based implementation of {@link Multimap}
+ * An {@link TreeMap}-based implementation of {@link Multimap}
*
* @param <K> Key type
* @param <V> Value type | 1 | /* / \____ _ _ ____ ______ / \ ____ __ _______
* / / \/ \ / \/ \ / /\__\/ // \/ \ // /\__\ JΛVΛSLΛNG
* _/ / /\ \ \/ / /\ \\__\\ \ // /\ \ /\\/ \ /__\ \ Copyright 2014-2017 Javaslang, http://javaslang.io
* /___/\_/ \_/\____/\_/ \_/\__\/__/\__\_/ \_// \__/\_____/ ... | 1 | 11,922 | 'A' instead of 'An' here | vavr-io-vavr | java |
@@ -37,7 +37,7 @@ import (
const (
// DefaultTimeout is the default timeout used to make calls
- DefaultTimeout = 10 * time.Second
+ DefaultTimeout = time.Second * 10
// DefaultLongPollTimeout is the long poll default timeout used to make calls
DefaultLongPollTimeout = time.Minute * 3
) | 1 | // The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Soft... | 1 | 11,778 | Can you flip it back (here and in other places)? It is more natural to represent "10 seconds" as `10 * time.Second`. | temporalio-temporal | go |
@@ -133,6 +133,11 @@ def test_classifier(output, centers, client, listen_port):
centers=centers
)
+ X_1, y_1, w_1, dX_1, dy_1, dw_1 = _create_data(
+ objective='classification',
+ output='array'
+ )
+
params = {
"n_estimators": 10,
"num_leaves": 10 | 1 | # coding: utf-8
"""Tests for lightgbm.dask module"""
import itertools
import os
import socket
import sys
import pytest
if not sys.platform.startswith('linux'):
pytest.skip('lightgbm.dask is currently supported in Linux environments', allow_module_level=True)
import dask.array as da
import dask.dataframe as dd
im... | 1 | 28,063 | Why was this necessary? You should just use the `dask_classifier` defined below this. With this change, you'd only be doing the local predict on arrays each time, but we want to test on all of DataFrame, Array, and sparse matrix. | microsoft-LightGBM | cpp |
@@ -0,0 +1,6 @@
+<div class="text-box-wrapper">
+ <div class="text-box">
+ <h3><%= t('.added_to_github_repo') %></h3>
+ <p>Give it a few seconds for the background job to work, and then <%= link_to 'check out the repo', @purchaseable.github_url %>.</p>
+ </div>
+</div> | 1 | 1 | 6,934 | To me, this is sort of weird to have a completely separate page for this. Can we extract the different stuff (github, videos, downloads) presentation from the top of `app/views/purchases/show.html.erb` and reuse it on this page. I worry that we'll change things with fulfillment or copy and have to change it in multiple... | thoughtbot-upcase | rb | |
@@ -1,6 +1,8 @@
package de.danoeh.antennapod.adapter;
import android.content.Context;
+import android.view.View;
+
import androidx.appcompat.app.AlertDialog;
import de.danoeh.antennapod.R; | 1 | package de.danoeh.antennapod.adapter;
import android.content.Context;
import androidx.appcompat.app.AlertDialog;
import de.danoeh.antennapod.R;
import de.danoeh.antennapod.core.storage.StatisticsItem;
import de.danoeh.antennapod.core.util.Converter;
import de.danoeh.antennapod.view.PieChartView;
import java.util.Lis... | 1 | 17,483 | Please revert the lines above. Not touching unrelated code keeps the git history clean. | AntennaPod-AntennaPod | java |
@@ -0,0 +1,3 @@
+# Copyright (c) Open-MMLab. All rights reserved.
+
+__version__ = '2.3.0rc0' | 1 | 1 | 20,923 | `short_version` and `version_info` | open-mmlab-mmdetection | py | |
@@ -52,7 +52,7 @@ type TaskStateChange struct {
Reason string
// Task is a pointer to the task involved in the state change that gives the event handler a hook into storing
- // what status was sent. This is used to ensure the same event is handled only once.
+ // what stats was sent. This is used to ensure the... | 1 | // Copyright 2014-2017 Amazon.com, Inc. or its affiliates. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License"). You may
// not use this file except in compliance with the License. A copy of the
// License is located at
//
// http://aws.amazon.com/apache2.0/
//
// or in the "license... | 1 | 15,044 | This is supposed to be `status`. Why did you change this? | aws-amazon-ecs-agent | go |
@@ -1,3 +1,6 @@
+// Copyright 2012-2017 Apcera Inc. All rights reserved.
+// Copyright 2018 Synadia Communications Inc. All rights reserved.
+
package server
import ( | 1 | package server
import (
"fmt"
"runtime"
"strings"
"sync"
"testing"
dbg "runtime/debug"
)
func stackFatalf(t *testing.T, f string, args ...interface{}) {
lines := make([]string, 0, 32)
msg := fmt.Sprintf(f, args...)
lines = append(lines, msg)
// Generate the Stack of callers: Skip us and verify* frames.
f... | 1 | 7,491 | I will change all of these at some point next week. | nats-io-nats-server | go |
@@ -42,7 +42,7 @@ namespace Datadog.Trace.ClrProfiler
/// </summary>
public string TargetAssembly
{
- get => throw new NotSupportedException("Use property TargetAssemblies instead of TargetAssembly.");
+ get => string.Empty;
set => TargetAssemblies = new[] {... | 1 | using System;
using System.Linq;
namespace Datadog.Trace.ClrProfiler
{
/// <summary>
/// Attribute that indicates that the decorated method is meant to intercept calls
/// to another method. Used to generate the integration definitions file.
/// </summary>
[AttributeUsage(AttributeTargets.Method, A... | 1 | 16,400 | I made this change because, while trying to debug, in Visual Studio, the `IntegrationSignatureTests`, this property getter was hit and interfered with my ability to complete the debugging. | DataDog-dd-trace-dotnet | .cs |
@@ -106,7 +106,8 @@ func determineDeploymentHealth(obj *unstructured.Unstructured) (status model.Kub
d := &appsv1.Deployment{}
err := scheme.Scheme.Convert(obj, d, nil)
if err != nil {
- desc = fmt.Sprintf("Failed while convert %T to %T: %v", obj, d, err)
+ status = model.KubernetesResourceState_OTHER
+ desc =... | 1 | // Copyright 2020 The PipeCD Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agree... | 1 | 7,912 | nit: `"Unexpected error while calculating: unable to convert %T to %T: %v"` | pipe-cd-pipe | go |
@@ -87,6 +87,10 @@ public abstract class SampleConfig {
@JsonProperty("packagePrefix")
public abstract String packagePrefix();
+ /** Returns a sample application name. */
+ @JsonProperty("appName")
+ public abstract String appName();
+
/** Returns a map of method names to methods. */
@JsonProperty("met... | 1 | /* Copyright 2016 Google Inc
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in ... | 1 | 19,164 | I'd actually recommend not putting this in the `SampleConfig`, it's intended more for properties that are inherent of the discovery format. Add a method `getSampleAppName(String apiTypeName)` to `SampleNamer` and override it in the language specific `SampleNamer`s if needed. Then assign it in the transformer. | googleapis-gapic-generator | java |
@@ -53,6 +53,8 @@ export * from './standalone';
export * from './storage';
export * from './i18n';
export * from './helpers';
+export * from './sort-object-map-by-key';
+export * from './convert-array-to-keyed-object-map';
/**
* Remove a parameter from a URL string. | 1 | /**
* Utility functions.
*
* Site Kit by Google, Copyright 2019 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* U... | 1 | 29,400 | Do we need to export these new functions? I thought the plan going forward was to keep util imports separated to make circular imports less likely and possibly do better chunk splitting. Since only new code references these files, we can scope the import to the specific files. | google-site-kit-wp | js |
@@ -0,0 +1 @@
+require "#{Rails.root}/app/models/acts_as_editable/acts_as_editable.rb" | 1 | 1 | 6,772 | Rails will autorequire `acts_as_editable` once it encounters the constant `ActsAsEditable`. Thus if we move `ActiveRecord::Base.send :include, ActsAsEditable` from _acts_as_editable.rb_ to this file, the require line will not be needed anymore. Instead of requiring the file ourselves, we will let Rails do it for us. Th... | blackducksoftware-ohloh-ui | rb | |
@@ -23,6 +23,9 @@ public abstract class GrpcStreamingDetailView {
public abstract String methodName();
+ @Nullable
+ public abstract String upperCamelMethodName();
+
public abstract GrpcStreamingType grpcStreamingType();
@Nullable | 1 | /* Copyright 2016 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in... | 1 | 24,402 | I think we should name this `grpcMethodName` or similar. That is what this refers to, right? The fact that it is upper camel is an implementation. | googleapis-gapic-generator | java |
@@ -47,6 +47,13 @@
} \
} while (false);
+#define VALIDATE_NAME(_N) \
+ do { \
+ if (_N[0] == '.' || _N[0] == '/') { ... | 1 | // Copyright(c) 2017-2018, Intel Corporation
//
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are met:
//
// * Redistributions of source code must retain the above copyright notice,
// this list of conditions and... | 1 | 17,270 | What if .. appears, but not as the first character, eg "errors/../../../../../../../../../../../"? | OPAE-opae-sdk | c |
@@ -81,7 +81,7 @@ class Guidance < ActiveRecord::Base
# Returns whether or not a given user can view a given guidance
# we define guidances viewable to a user by those owned by a guidance group:
- # owned by the managing curation center
+ # owned by the default orgs
# owned by a funder organisation
... | 1 | # frozen_string_literal: true
# Guidance provides information from organisations to Users, helping them when
# answering questions. (e.g. "Here's how to think about your data
# protection responsibilities...")
#
# == Schema Information
#
# Table name: guidances
#
# id :integer not null, primar... | 1 | 18,853 | Thanks, this should make things a bit easier for people who pick up the codebase but aren't a `curation center` | DMPRoadmap-roadmap | rb |
@@ -122,6 +122,8 @@ public class AzkabanWebServer extends AzkabanServer {
private static final int MAX_FORM_CONTENT_SIZE = 10 * 1024 * 1024;
private static final String DEFAULT_TIMEZONE_ID = "default.timezone.id";
private static final String DEFAULT_STATIC_DIR = "";
+
+ @Deprecated
private static AzkabanWe... | 1 | /*
* Copyright 2012 LinkedIn Corp.
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not
* use this file except in compliance with the License. You may obtain a copy of
* the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to i... | 1 | 14,219 | why not removing it? | azkaban-azkaban | java |
@@ -84,9 +84,9 @@ func NewCliApp() *cli.App {
EnvVar: "TEMPORAL_CLI_TLS_CA",
},
cli.BoolFlag{
- Name: FlagTLSEnableHostVerification,
- Usage: "validates hostname of temporal cluster against server certificate",
- EnvVar: "TEMPORAL_CLI_TLS_ENABLE_HOST_VERIFICATION",
+ Name: FlagTLSDisableHostVerif... | 1 | // The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Soft... | 1 | 11,627 | same nit here: maybe word as - "disables validation of the temporal cluster's server certificate" | temporalio-temporal | go |
@@ -59,6 +59,7 @@ public class TestFlinkCatalogDatabase extends FlinkCatalogTestBase {
@Test
public void testDefaultDatabase() {
sql("USE CATALOG %s", catalogName);
+ sql("show tables");
Assert.assertEquals("Should use the current catalog", getTableEnv().getCurrentCatalog(), catalogName);
Asse... | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you ... | 1 | 24,398 | Nit: other statements use all caps for SQL reserved words. Should this be `SHOW TABLES`? | apache-iceberg | java |
@@ -60,7 +60,7 @@ static bool is_a_code_line (const unsigned char *line)
static bool isLuaIdentifier (char c)
{
- return (bool) !(isspace(c) || c == '(' || c == ')' || c == '=');
+ return (bool) !(isspace(c) || c == '(' || c == ')' || c == '=' || c == '.' || c == ':');
}
static void extract_next_token (const ... | 1 | /*
* Copyright (c) 2000-2001, Max Ischenko <mfi@ukr.net>.
*
* This source code is released for free distribution under the terms of the
* GNU General Public License version 2 or (at your option) any later version.
*
* This module contains functions for generating tags for Lua language.
*/
/*
* INCLUDE FILES
... | 1 | 21,314 | Do we need this? isLuaIdentifier() is used not only in extract_next_token() but also in extract_prev_toke(). I wonder whether the change for isLuaIdentifier() has an impact on extract_prev_toke() or not. If you are not sure, keep isLuaIdentifier() as is. If you are sure, could you write your conviction to the commit lo... | universal-ctags-ctags | c |
@@ -942,7 +942,7 @@ func ConfigureDefaultMTUs(hostMTU int, c *Config) {
c.VXLANMTU = hostMTU - vxlanMTUOverhead
}
if c.Wireguard.MTU == 0 {
- if c.KubernetesProvider == config.ProviderAKS && c.RouteSource == "WorkloadIPs" {
+ if c.Wireguard.EncryptHostTraffic {
// The default MTU on Azure is 1500, but the ... | 1 | // Copyright (c) 2020-2021 Tigera, Inc. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by ... | 1 | 19,217 | This line should actually be: `if c.KubernetesProvider == config.ProviderAKS && c.Wireguard.EncryptHostTraffic {` because we only need to tweak the MTU like this on AKS. | projectcalico-felix | c |
@@ -71,7 +71,7 @@ var (
const (
projectFlagDescription = "Name of the project."
- appFlagDescription = "Name of the application."
+ svcFlagDescription = "Name of the service."
envFlagDescription = "Name of the environment."
pipelineFlagDescription = "Name of the pipeline."
profileFlagDescript... | 1 | // Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
// SPDX-License-Identifier: Apache-2.0
package cli
import (
"fmt"
"strconv"
"strings"
"github.com/aws/amazon-ecs-cli-v2/internal/pkg/manifest"
)
// Long flag names.
const (
// Common flags.
projectFlag = "project"
nameFlag = "name"
appF... | 1 | 13,083 | Do we need to change this flag as well? | aws-copilot-cli | go |
@@ -10,7 +10,9 @@ module.exports = function (grunt) {
return grunt.file.read(fn);
}).join('\n');
- grunt.file.write(fileset.dest, 'exports.source = ' + JSON.stringify(source) + ';');
+ var file = grunt.file.read(fileset.dest);
+
+ grunt.file.write(fileset.dest, file + 'module.exports.source = ' + JSON.... | 1 | /*jshint node: true */
'use strict';
module.exports = function (grunt) {
grunt.registerMultiTask('nodeify', function () {
grunt.task.requires('configure');
grunt.task.requires('concat:engine');
this.files.forEach(function (fileset) {
var source = fileset.src.map(function (fn) {
return grunt.file.read(fn)... | 1 | 10,742 | Including the source twice here makes the filesize jump to 432kb. Is there any way to minimize repeating it? | dequelabs-axe-core | js |
@@ -1656,7 +1656,7 @@ class TargetLocator {
window(nameOrHandle) {
return this.driver_.schedule(
new command.Command(command.Name.SWITCH_TO_WINDOW).
- setParameter('name', nameOrHandle),
+ setParameter('handle', nameOrHandle),
'WebDriver.switchTo().window(' + nameOrHandle... | 1 | // Licensed to the Software Freedom Conservancy (SFC) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The SFC licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you m... | 1 | 13,587 | This should only be sent if the driver is speaking to a W3C conformant remote, so we need an if-condition check like we have in the Python bindings. | SeleniumHQ-selenium | rb |
@@ -76,7 +76,15 @@ module Bolt
target = request['target']
plan_vars = shadow_vars('plan', request['plan_vars'], target['facts'])
target_vars = shadow_vars('target', target['variables'], target['facts'])
- topscope_vars = target_vars.merge(plan_vars)
+
+ # Merge plan vars with target vars,... | 1 | # frozen_string_literal: true
require 'bolt/apply_inventory'
require 'bolt/apply_target'
require 'bolt/config'
require 'bolt/error'
require 'bolt/inventory'
require 'bolt/pal'
require 'bolt/puppetdb'
require 'bolt/util'
Bolt::PAL.load_puppet
require 'bolt/catalog/logging'
module Bolt
class Catalog
def initial... | 1 | 15,564 | Only one line of code? What a simple issue! | puppetlabs-bolt | rb |
@@ -111,10 +111,8 @@ func NewHandler(
status: common.DaemonStatusInitialized,
config: config,
tokenSerializer: common.NewProtoTaskTokenSerializer(),
- rateLimiter: quotas.NewDynamicRateLimiter(
- func() float64 {
- return float64(config.RPS())
- },
+ rateLimiter: quotas.NewDefaultInc... | 1 | // The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Soft... | 1 | 11,023 | Conceptual question: why do history and matching need throttler at all? Shouldn't throttling to be handled on FE only? | temporalio-temporal | go |
@@ -126,12 +126,14 @@ func (n *NetworkPolicyController) deleteCNP(old interface{}) {
n.deleteDereferencedAddressGroups(oldInternalNP)
}
-// reprocessCNP is triggered by Namespace ADD/UPDATE/DELETE events when they impact the
-// per-namespace rules of a CNP.
-func (n *NetworkPolicyController) reprocessCNP(cnp *crd... | 1 | // Copyright 2020 Antrea Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to ... | 1 | 45,214 | Would this be possible: `addCNP` has already processed the CNP to an internalNP, just hasn't added this internalNP to the `internalNetworkPolicyStore`. In this case, `reprocessCNP` will skip processing this CNP and `addCNP` will just add the "old" internalNP to `internalNetworkPolicyStore`. | antrea-io-antrea | go |
@@ -22,6 +22,11 @@ module CartsHelper
current_linear_approval?(cart, user)
end
+ # Todo: Move this to an NCR specific template?
+ def display_restart?(cart, user)
+ cart.ncr? && user == cart.requester && (cart.pending? || cart.rejected?)
+ end
+
def parallel_approval_is_pending?(cart, user)
retu... | 1 | module CartsHelper
# need to pass in the user because the current_user controller helper can't be stubbed
# https://github.com/rspec/rspec-rails/issues/1076
def display_status(cart, user)
if cart.pending?
approvers = cart.currently_awaiting_approvers
if approvers.include?(user)
content_tag... | 1 | 12,507 | Minor: you can access `current_user` in here directly - don't need to pass it in. Unless you prefer passing it explicitly? | 18F-C2 | rb |
@@ -45,6 +45,7 @@ module Mongoid
# @param [ Hash ] attributes The attributes hash to attempt to set.
# @param [ Hash ] options The options defined.
def initialize(association, attributes, options = {})
+ attributes = attributes&.to_h if attributes.respond_to?(:keys)
if att... | 1 | # frozen_string_literal: true
# encoding: utf-8
module Mongoid
module Association
module Nested
class Many
include Buildable
# Builds the association depending on the attributes and the options
# passed to the macro.
#
# This attempts to perform 3 operations, either... | 1 | 13,154 | What is the purpose of `&` on this line? | mongodb-mongoid | rb |
@@ -58,5 +58,5 @@ export function isValidPropertySelection( value ) {
* @return {boolean} TRUE if the web data stream ID is valid, otherwise FALSE.
*/
export function isValidWebDataStreamID( webDataStreamID ) {
- return typeof webDataStreamID === 'string' && /\d+/.test( webDataStreamID );
+ return typeof webDataSt... | 1 | /**
* Validation utilities.
*
* Site Kit by Google, Copyright 2021 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | 1 | 38,861 | See above, the `isValidWebDataStreamID` implementation from before is actually correct. What we need here instead is a new `isValidMeasurementID` function. | google-site-kit-wp | js |
@@ -628,7 +628,12 @@ func (s *Server) createLeafNode(conn net.Conn, remote *leafNodeCfg) *client {
c.mu.Unlock()
// Error will be handled below, so ignore here.
- c.parse([]byte(info))
+ err = c.parse([]byte(info))
+ if err != nil {
+ c.Debugf("Error reading remote leafnode's INFO: %s", err)
+ c.closeCon... | 1 | // Copyright 2019 The NATS Authors
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in wr... | 1 | 9,892 | Should be an error... it is important for the admin of the server attempting to create the leafnode connection to see the error asap. | nats-io-nats-server | go |
@@ -313,6 +313,15 @@ def speakObjectProperties(obj,reason=controlTypes.REASON_QUERY,index=None,**allo
newPropertyValues['current']=obj.isCurrent
if allowedProperties.get('placeholder', False):
newPropertyValues['placeholder']=obj.placeholder
+ # When speaking an object due to a focus change, the 'selected' state... | 1 | # -*- coding: UTF-8 -*-
#speech.py
#A part of NonVisual Desktop Access (NVDA)
#This file is covered by the GNU General Public License.
#See the file COPYING for more details.
#Copyright (C) 2006-2017 NV Access Limited, Peter Vágner, Aleksey Sadovoy, Babbage B.V.
"""High-level functions to speak information.
""... | 1 | 23,534 | Could you split these conditions up over multiple lines please. | nvaccess-nvda | py |
@@ -33,7 +33,7 @@ func (t *tag) parseJSONTag(structTag reflect.StructTag) {
}
func (t *tag) parseTagStr(tagStr string) {
- parts := strings.SplitN(tagStr, ",", 2)
+ parts := strings.SplitN(tagStr, ",", 3)
if len(parts) == 0 {
return
} | 1 | package dynamodbattribute
import (
"reflect"
"strings"
)
type tag struct {
Name string
Ignore bool
OmitEmpty bool
OmitEmptyElem bool
AsString bool
AsBinSet, AsNumSet, AsStrSet bool
}
func (t *tag) parseAVTag(s... | 1 | 8,334 | I think we can just change this to `Split` instead of `SplitN`. I don't think we need to limit the number of parts in the tag. | aws-aws-sdk-go | go |
@@ -69,10 +69,8 @@ services:
image: {{ .router_image }}:{{ .router_tag }}
container_name: nginx-proxy
ports:
- - "80:80"
- - {{ .mailhogport }}:{{ .mailhogport }}
- - {{ .dbaport }}:{{ .dbaport }}
- - {{ .dbport }}:{{ .dbport }}
+ {{ range $port := .ports }}- "{{ $port }}:{{ $por... | 1 | package platform
// SequelproTemplate is the template for Sequelpro config.
var SequelproTemplate = `<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
<key>ContentFilters</key>
<dict/>
<... | 1 | 11,142 | So this is actually a mistake that I introduced without realizing it, and have known would need to be fixed when we get here . The format of the ports directive is "host:container". We only want the host port to change, not the internal container ports. The ports variable probably needs to be a map which maps external... | drud-ddev | php |
@@ -1176,7 +1176,9 @@ func (s *ContextImpl) transitionLocked(request contextRequest) {
s.state = contextStateStopping
// The change in state should cause all write methods to fail, but just in case, set this also,
// which will cause failures at the persistence level
- s.shardInfo.RangeId = -1
+ if s.shardIn... | 1 | // The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Soft... | 1 | 13,196 | An alternate approach would be to always initialize shardInfo with a dummy (non-nil) value, which could protect against other uses before it's initialized (I couldn't find any though). But I can change it to do it that way instead. | temporalio-temporal | go |
@@ -960,3 +960,8 @@ func SessionInfoFromProtocol(session keybase1.Session) (SessionInfo, error) {
VerifyingKey: verifyingKey,
}, nil
}
+
+// NodeMetadata has metadata about a node needed for higher level operations.
+type NodeMetadata struct {
+ LastWriter keybase1.UID
+} | 1 | // Copyright 2016 Keybase Inc. All rights reserved.
// Use of this source code is governed by a BSD
// license that can be found in the LICENSE file.
package libkbfs
import (
"encoding/hex"
"fmt"
"reflect"
"strings"
"time"
"github.com/keybase/client/go/libkb"
"github.com/keybase/client/go/protocol/keybase1"
)... | 1 | 12,788 | Maybe we can just put the entire `DirEntry` in here? I can imagine it might be useful for debugging to get the block ID/refnonce, encrypted size, key gen, data version, etc. What do you think? | keybase-kbfs | go |
@@ -49,9 +49,9 @@ ewmh_client_update_hints(lua_State *L)
state[i++] = _NET_WM_STATE_MODAL;
if(c->fullscreen)
state[i++] = _NET_WM_STATE_FULLSCREEN;
- if(c->maximized_vertical)
+ if(c->maximized_vertical || c->maximized)
state[i++] = _NET_WM_STATE_MAXIMIZED_VERT;
- if(c->maximize... | 1 | /*
* ewmh.c - EWMH support functions
*
* Copyright © 2007-2009 Julien Danjou <julien@danjou.info>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* ... | 1 | 12,025 | For the commit message: The paragraphs seem to be out of order? The `Would not work because` refers to the stuff before, but there is a `This may seem pointless, but` in-between. | awesomeWM-awesome | c |
@@ -88,12 +88,6 @@ var (
prelude = []string{
"universe",
"influxdata/influxdb",
- "math",
- "strings",
- "regexp",
- "date",
- "json",
- "http",
}
preludeScope = &scopeSet{
packages: make([]*interpreter.Package, len(prelude)), | 1 | package flux
import (
"fmt"
"path"
"regexp"
"strings"
"time"
"github.com/influxdata/flux/ast"
"github.com/influxdata/flux/interpreter"
"github.com/influxdata/flux/parser"
"github.com/influxdata/flux/semantic"
"github.com/influxdata/flux/values"
"github.com/pkg/errors"
)
const (
TablesParameter = "tables... | 1 | 11,417 | Why did you remove these packages from the prelude, will your new functions not work without this change? | influxdata-flux | go |
@@ -36,10 +36,14 @@ GetProcessor::asyncProcess(PartitionID part,
const std::vector<std::string>& keys) {
folly::Promise<std::pair<PartitionID, kvstore::ResultCode>> promise;
auto future = promise.getFuture();
+ std::vector<std::string> kvKeys;
+ std::transform(keys.begin(), k... | 1 | /* Copyright (c) 2019 vesoft inc. All rights reserved.
*
* This source code is licensed under Apache 2.0 License,
* attached with Common Clause Condition 1.0, found in the LICENSES directory.
*/
#include "storage/GetProcessor.h"
#include "base/NebulaKeyUtils.h"
namespace nebula {
namespace storage {
void GetProc... | 1 | 23,451 | We'd better reserve enough space before using kvKeys to avoid extra malloc. | vesoft-inc-nebula | cpp |
@@ -213,3 +213,12 @@ func GetLocalPVType(pv *v1.PersistentVolume) string {
}
return ""
}
+
+// GetNodeHostname extracts the Hostname from the labels on the Node
+func GetNodeHostname(n *v1.Node) string {
+ hostname, found := n.Labels[KeyNodeHostname]
+ if found {
+ return hostname
+ }
+ return n.Name
+} | 1 | /*
Copyright 2019 The OpenEBS Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, sof... | 1 | 17,252 | would it make sense to return empty or error if label doesn't exists? | openebs-maya | go |
@@ -38,13 +38,15 @@ var PATH_SEPARATOR = process.platform === 'win32' ? ';' : ':';
exports.rmDir = function(path) {
return new promise.Promise(function(fulfill, reject) {
var numAttempts = 0;
+ var maxAttempts = 5;
+ var attemptTimeout = 250;
attemptRm();
function attemptRm() {
numAttemp... | 1 | // Copyright 2013 Selenium committers
// Copyright 2013 Software Freedom Conservancy
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
/... | 1 | 11,567 | Don't penalize everyone with 250ms delay b/c some machines have problems. | SeleniumHQ-selenium | py |
@@ -119,6 +119,15 @@ func (s SortedCidSet) Equals(s2 SortedCidSet) bool {
return true
}
+// String returns a string listing the cids in the set.
+func (s SortedCidSet) String() string {
+ out := "{"
+ for it := s.Iter(); !it.Complete(); it.Next() {
+ out = fmt.Sprintf("%s %s", out, it.Value().String())
+ }
+ retu... | 1 | package types
import (
"bytes"
"encoding/json"
"fmt"
"sort"
cbor "gx/ipfs/QmRiRJhn427YVuufBEHofLreKWNw7P7BWNq86Sb9kzqdbd/go-ipld-cbor"
cid "gx/ipfs/QmcZfnkapfECQGcLZaf9B79NRg7cRa9EnZh4LSbkCzwNvY/go-cid"
"gx/ipfs/QmcrriCMhjb5ZWzmPNxmP53px47tSPcXBNaMtLdgcKFJYk/refmt/obj/atlas"
)
func init() {
cbor.RegisterCbor... | 1 | 12,739 | Probably want a space after the second %s? | filecoin-project-venus | go |
@@ -206,7 +206,7 @@ func (h *historyArchiver) Get(
dirPath := URI.Path()
exists, err := directoryExists(dirPath)
if err != nil {
- return nil, serviceerror.NewInternal(err.Error())
+ return nil, serviceerror.NewUnavailable(err.Error())
}
if !exists {
return nil, serviceerror.NewInvalidArgument(archiver.E... | 1 | // The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Soft... | 1 | 12,570 | This seems like an internal error still? | temporalio-temporal | go |
@@ -85,7 +85,7 @@ describe PurchasesController do
post :create, purchase: customer_params(stripe_token), product_id: product.to_param
- FakeStripe.should have_charged(1500).to('test@example.com').with_token(stripe_token)
+ expect(FakeStripe).to have_charged(1500).to('test@example.com').with_token(s... | 1 | require 'spec_helper'
include StubCurrentUserHelper
describe PurchasesController do
describe '#new when purchasing a screencast as a user with an active subscription' do
it 'renders a subscriber-specific layout' do
user = create(:subscriber)
product = create(:screencast)
stub_current_user_with... | 1 | 9,607 | Line is too long. [94/80] | thoughtbot-upcase | rb |
@@ -125,10 +125,16 @@ func (a *ClusterIdentityAllocator) Run(stopCh <-chan struct{}) {
}
}
+type ClusterIdentity struct {
+ UUID uuid.UUID
+}
+
// ClusterIdentityProvider is an interface used to retrieve the cluster identity information (UUID),
-// as provided by the user or generated by the Antrea Controller.
+/... | 1 | // Copyright 2021 Antrea Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to ... | 1 | 34,102 | out of curiosity, why creating another struct to wrap it? | antrea-io-antrea | go |
@@ -9549,8 +9549,15 @@ bool Bot::UseDiscipline(uint32 spell_id, uint32 target) {
if(spells[spell_id].timer_id > 0 && spells[spell_id].timer_id < MAX_DISCIPLINE_TIMERS)
SetDisciplineRecastTimer(spells[spell_id].timer_id, spell.recast_time);
} else {
- uint32 remain = (GetDisciplineRemainingTime(this, spell... | 1 | /* EQEMu: Everquest Server Emulator
Copyright (C) 2001-2016 EQEMu Development Team (http://eqemulator.org)
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; version 2 of the License.
This program... | 1 | 11,033 | discipline vs. Discipline? Not sure of which is correct. Also not sure if there is already an existing string const. | EQEmu-Server | cpp |
@@ -135,6 +135,7 @@ public abstract class ResourceDescriptorConfig {
.setEntityId(nameMap.get(p).toUpperCamel())
.setEntityName(overrideConfig.getEntityName())
.setCommonResourceName(overrideConfig.getCommonResourceName())
+ .setA... | 1 | /* Copyright 2019 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in... | 1 | 30,348 | I believe this will break common resources, as they are defined in a common file, but must generate classes in service-specific namespace, so using protoFile to determine package of the generated class would not work, because common_resources namespace does not match service namespace. | googleapis-gapic-generator | java |
@@ -63,6 +63,8 @@ NATURAL_ORDER_COLUMN_NAME = "__natural_order__"
HIDDEN_COLUMNS = {NATURAL_ORDER_COLUMN_NAME}
+SERIES_DEFAULT_NAME = "0"
+
class InternalFrame(object):
""" | 1 | #
# Copyright (C) 2019 Databricks, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to i... | 1 | 15,460 | How about `SPARK_DEFAULT_SERIES_NAME`? | databricks-koalas | py |
@@ -36,9 +36,18 @@ public class TableProperties {
public static final String COMMIT_TOTAL_RETRY_TIME_MS = "commit.retry.total-timeout-ms";
public static final int COMMIT_TOTAL_RETRY_TIME_MS_DEFAULT = 1800000; // 30 minutes
- public static final String COMMIT_NUM_STATUS_CHECKS = "commit.num-status-checks";
+ p... | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you ... | 1 | 37,630 | The other properties are in `commit.status-check`, not `commit.status-checks`. Could you remove the extra `s`? | apache-iceberg | java |
@@ -6,6 +6,12 @@ var setupDatabase = require('./shared').setupDatabase;
describe('Authentication', function() {
before(function() {
+ const configuration = this.configuration;
+ if (configuration.usingUnifiedTopology()) {
+ // The unified topology does not currently support authentication
+ return... | 1 | 'use strict';
var f = require('util').format;
var test = require('./shared').assert;
var setupDatabase = require('./shared').setupDatabase;
describe('Authentication', function() {
before(function() {
return setupDatabase(this.configuration);
});
/**
* Fail due to illegal authentication mechanism
*
... | 1 | 14,817 | Side note: I'd love to see more of these fields exposed on configuration. | mongodb-node-mongodb-native | js |
@@ -5,7 +5,7 @@
contact_us = (Rails.configuration.branding[:organisation][:contact_us_url] || contact_us_url)
email_subject = _('Query or feedback related to %{tool_name}') %{ :tool_name => tool_name }
user_name = User.find_by(email: @resource.email).nil? ? @resource.email : User.find_by(email: @resource.emai... | 1 | <%
tool_name = Rails.configuration.branding[:application][:name]
link = accept_invitation_url(@resource, :invitation_token => @token)
helpdesk_email = Rails.configuration.branding[:organisation][:helpdesk_email]
contact_us = (Rails.configuration.branding[:organisation][:contact_us_url] || contact_us_url)
... | 1 | 19,027 | In the case of accounts generated by API clients, what name gets put for the `inviter_name` or `invited_by` record? | DMPRoadmap-roadmap | rb |
@@ -33,6 +33,8 @@ public class MutableQbftConfigOptions extends MutableBftConfigOptions implements
qbftConfigOptions.getValidatorContractAddress().map(String::toLowerCase);
}
+ // TODO-lucas do I need to implement getStartBlock here?
+
@Override
public Optional<String> getValidatorContractAddress()... | 1 | /*
* Copyright Hyperledger Besu Contributors.
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agr... | 1 | 26,645 | I think this class is only relevant for updating the QbftConfigOptions based on the transitions config, so probably not. | hyperledger-besu | java |
@@ -89,5 +89,10 @@ namespace Nethermind.JsonRpc
///
/// </summary>
public const int ExecutionError = -32015;
+
+ /// <summary>
+ /// Request exceedes defined tracer timeout limit
+ /// </sumary>
+ public const int TracerTimeout = -32016;
}
} | 1 | // Copyright (c) 2018 Demerzel Solutions Limited
// This file is part of the Nethermind library.
//
// The Nethermind library is free software: you can redistribute it and/or modify
// it under the terms of the GNU Lesser General Public License as published by
// the Free Software Foundation, either version 3 of... | 1 | 24,194 | what is the number thrown by Geth? | NethermindEth-nethermind | .cs |
@@ -2036,8 +2036,8 @@ common.checkDatabaseConfigMatch = (apiConfig, frontendConfig) => {
// mongodb0.example.com:27017
let apiMongoHost = apiConfig.split("/")[2];
let frontendMongoHost = frontendConfig.split("/")[2];
- let apiMongoDb = apiConfig.split("/... | 1 | /**
* Module for some common utility functions and references
* @module api/utils/common
*/
/** @lends module:api/utils/common */
var common = {},
moment = require('moment-timezone'),
time = require('time')(Date),
crypto = require('crypto'),
logger = require('./log.js'),
mcc_mnc_list = require('mcc... | 1 | 13,268 | This would still crash on malformed database connection string like "test" | Countly-countly-server | js |
@@ -0,0 +1,14 @@
+package interfaces
+
+import "context"
+
+type pluginNameKey struct{}
+
+func PluginNameFromHostServiceContext(ctx context.Context) (string, bool) {
+ name, ok := ctx.Value(pluginNameKey{}).(string)
+ return name, ok
+}
+
+func WithPluginName(ctx context.Context, name string) context.Context {
+ retur... | 1 | 1 | 10,846 | it is not an interface, maybe we can move to another package? | spiffe-spire | go | |
@@ -4,14 +4,15 @@ import { stopPropagation, stopImmediatePropagation, isImmediatePropagationStoppe
import { getEditorInstance } from './editors';
import EventManager from './eventManager';
import { EditorState } from './editors/_baseEditor';
+import { getParentWindow } from './helpers/dom/element';
class EditorMa... | 1 | import { CellCoords } from './3rdparty/walkontable/src';
import { KEY_CODES, isMetaKey, isCtrlMetaKey } from './helpers/unicode';
import { stopPropagation, stopImmediatePropagation, isImmediatePropagationStopped } from './helpers/dom/event';
import { getEditorInstance } from './editors';
import EventManager from './eve... | 1 | 15,839 | Same here. Can we use `this.instance.getSettings()` to get `tableMeta`? | handsontable-handsontable | js |
@@ -13,7 +13,15 @@ import (
"github.com/opencontainers/runc/libcontainer/configs"
)
+func isCpuSet(cgroup *configs.Cgroup) bool {
+ return cgroup.Resources.CpuWeight != 0 || cgroup.Resources.CpuMax != ""
+}
+
func setCpu(dirPath string, cgroup *configs.Cgroup) error {
+ if !isCpuSet(cgroup) {
+ return nil
+ }
+
... | 1 | // +build linux
package fs2
import (
"bufio"
"os"
"path/filepath"
"strconv"
"github.com/opencontainers/runc/libcontainer/cgroups"
"github.com/opencontainers/runc/libcontainer/cgroups/fscommon"
"github.com/opencontainers/runc/libcontainer/configs"
)
func setCpu(dirPath string, cgroup *configs.Cgroup) error {
... | 1 | 19,108 | Not sure whether this validation is useful. | opencontainers-runc | go |
@@ -422,6 +422,17 @@ class PromptContainer(QWidget):
except UnsupportedOperationError:
pass
+ @cmdutils.register(instance='prompt-container', scope='window',
+ modes=[usertypes.KeyMode.prompt])
+ def prompt_yank(self):
+ """Yank URLs or other data in prompts.""... | 1 | # vim: ft=python fileencoding=utf-8 sts=4 sw=4 et:
# Copyright 2016-2017 Florian Bruhin (The Compiler) <mail@qutebrowser.org>
#
# This file is part of qutebrowser.
#
# qutebrowser is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free S... | 1 | 20,581 | Various things to note here: - Why would `question` ever be falsey (or `None`) here, i.e. why the `if question`? - Why would `question` ever not have that attribute? You set it in `Question.__init__`, so that check does nothing at all (and generally, `hasattr()` should be avoided if possible). - Why do you want to yank... | qutebrowser-qutebrowser | py |
@@ -121,8 +121,10 @@ def buffer_s3response(s3response):
found_records = True
elif 'Progress' in event:
logger_.info("select progress: %s", event['Progress'].get('Details'))
+ print(event['Progress'].get('Details'))
elif 'Stats' in event:
logger_.info("... | 1 | """
Helper functions.
"""
import gzip
import io
import json
import logging
import os
from base64 import b64decode
from typing import Iterable
LOGGER_NAME = "quilt-lambda"
MANIFEST_PREFIX_V1 = ".quilt/packages/"
POINTER_PREFIX_V1 = ".quilt/named_packages/"
def separated_env_to_iter(
env_var: str,
*,
... | 1 | 19,957 | If this is needed for testing, you should use `pytest --log-cli-level=INFO` instead. | quiltdata-quilt | py |
@@ -115,7 +115,7 @@ func DefaultNodeOptions() *MobileNodeOptions {
EtherClientRPC: metadata.Testnet2Definition.EtherClientRPC,
FeedbackURL: "https://feedback.mysterium.network",
QualityOracleURL: "https://testnet2-quality.mysterium.network/api/v1",
- IPDetec... | 1 | /*
* Copyright (C) 2018 The "MysteriumNetwork/node" Authors.
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
... | 1 | 16,878 | We should drop ipify in all places i guess | mysteriumnetwork-node | go |
@@ -137,8 +137,8 @@ type ConsensusParams struct {
DownCommitteeSize uint64
DownCommitteeThreshold uint64
- FilterTimeoutSmallLambdas uint64
- FilterTimeoutPeriod0SmallLambdas uint64
+ AgreementFilterTimeout time.Duration
+ AgreementFilterTimeoutPeriod0 time.Duration
FastRecoveryLa... | 1 | // Copyright (C) 2019-2020 Algorand, Inc.
// This file is part of go-algorand
//
// go-algorand is free software: you can redistribute it and/or modify
// it under the terms of the GNU Affero General Public License as
// published by the Free Software Foundation, either version 3 of the
// License, or (at your option) ... | 1 | 40,221 | Add explanations around these variables - what do they mean, how they should be configured, etc. | algorand-go-algorand | go |
@@ -106,6 +106,11 @@ class SiteController < ApplicationController
@locale = params[:about_locale] || I18n.locale
end
+ def communities
+ OsmCommunityIndex::LocalChapter.add_to_i18n # this should be called on app init
+ @local_chapters = OsmCommunityIndex::LocalChapter.local_chapters
+ end
+
def exp... | 1 | class SiteController < ApplicationController
layout "site"
layout :map_layout, :only => [:index, :export]
before_action :authorize_web
before_action :set_locale
before_action :redirect_browse_params, :only => :index
before_action :redirect_map_params, :only => [:index, :edit, :export]
before_action :requ... | 1 | 13,558 | One thing tho - I would really appreciate any advice on where to move this to, so that it's called on initialisation of the website. | openstreetmap-openstreetmap-website | rb |
@@ -321,4 +321,16 @@ public interface GauntletConfig extends Config
{
return false;
}
+
+ @ConfigItem(
+ position = 21,
+ keyName = "displayResources",
+ name = "Show raw resources gathered",
+ description = "Displays how much of each resource you have gathered.",
+ titleSection = "resources"
+ )
+ def... | 1 | /*
* Copyright (c) 2019, kThisIsCvpv <https://github.com/kThisIsCvpv>
* Copyright (c) 2019, ganom <https://github.com/Ganom>
* Copyright (c) 2019, kyle <https://github.com/Kyleeld>
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided... | 1 | 15,901 | To much tabs here (1 tab) | open-osrs-runelite | java |
@@ -135,12 +135,12 @@ public class ExecutionLogsDao {
}
}
- int removeExecutionLogsByTime(final long millis)
+ int removeExecutionLogsByTime(final long millis, final int recordCleanupLimit)
throws ExecutorManagerException {
final String DELETE_BY_TIME =
- "DELETE FROM execution_logs WHERE... | 1 | /*
* Copyright 2017 LinkedIn Corp.
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not
* use this file except in compliance with the License. You may obtain a copy of
* the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to i... | 1 | 19,370 | This is not maintaining retention time for logs as we are deleting only 1000 entries and we might end up with huge number of rows spanning over multiple months over a period of time if the cluster generates more rows as we are restricting ourselves to delete only 24k rows/day. Like I pointed out earlier a better would ... | azkaban-azkaban | java |
@@ -1319,10 +1319,10 @@ func (s *timerQueueActiveTaskExecutorSuite) TestWorkflowTimeout_ContinueAsNew_Re
// need to override the workflow retry policy
executionInfo := mutableState.executionInfo
executionInfo.HasRetryPolicy = true
- executionInfo.WorkflowExpirationTime = s.now.Add(1000 * time.Second)
+ executionI... | 1 | // The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Soft... | 1 | 10,197 | I don't like this helper func :-). Yeah, definitely don't like. | temporalio-temporal | go |
@@ -18,17 +18,7 @@ describe( 'PageSpeed Insights Activation', () => {
beforeAll( async () => {
await page.setRequestInterception( true );
useRequestInterception( ( request ) => {
- if ( request.url().match( 'google-site-kit/v1/data/' ) ) {
- request.respond( { status: 200 } );
- } else if (
- request
... | 1 | /**
* WordPress dependencies
*/
import { visitAdminPage, activatePlugin } from '@wordpress/e2e-test-utils';
/**
* Internal dependencies
*/
import {
deactivateUtilityPlugins,
resetSiteKit,
setSearchConsoleProperty,
setSiteVerification,
useRequestInterception,
} from '../../../utils';
describe( 'PageSpeed Insi... | 1 | 40,663 | Same here. This should remain unchanged. Please, add it back. | google-site-kit-wp | js |
@@ -2052,6 +2052,9 @@ Collection.prototype.mapReduce = function(map, reduce, options, callback) {
*/
Collection.prototype.initializeUnorderedBulkOp = function(options) {
options = options || {};
+ if (this.s.options.ignoreUndefined) {
+ options.ignoreUndefined = this.s.options.ignoreUndefined;
+ }
options... | 1 | 'use strict';
const deprecate = require('util').deprecate;
const deprecateOptions = require('./utils').deprecateOptions;
const checkCollectionName = require('./utils').checkCollectionName;
const ObjectID = require('mongodb-core').BSON.ObjectID;
const AggregationCursor = require('./aggregation_cursor');
const MongoErro... | 1 | 15,088 | @kvwalker should this method have `ignoreUndefined` supported as an `option`? | mongodb-node-mongodb-native | js |
@@ -52,10 +52,11 @@ func New(_ *any.Any, logger *zap.Logger, _ tally.Scope) (service.Service, error)
return nil, errors.New("experiment store wrong type")
}
- transformer := NewTransformer()
+ sugaredLogger := logger.Sugar()
+ transformer := NewTransformer(sugaredLogger)
return &storer{
client.DB(),
- logg... | 1 | package experimentstore
import (
"bytes"
"context"
"database/sql"
"errors"
"strings"
"time"
"github.com/golang/protobuf/jsonpb"
"github.com/golang/protobuf/ptypes"
"github.com/golang/protobuf/ptypes/any"
"github.com/golang/protobuf/ptypes/timestamp"
"github.com/uber-go/tally"
"go.uber.org/zap"
experimen... | 1 | 8,979 | we dont use a `sugaredlogger` anywhere else in clutch, just curious why were using it here? | lyft-clutch | go |
@@ -388,7 +388,6 @@ class ServerCallback(MessageCallback):
if not self._queue:
self._active = False
return
- self._queue = []
# Get unique event types in the queue
events = list(OrderedDict([(event.event_name, event)
for eve... | 1 | from collections import defaultdict
from bokeh.models import CustomJS, FactorRange, DatetimeAxis
from ...core import OrderedDict
from ...streams import (Stream, PointerXY, RangeXY, Selection1D, RangeX,
RangeY, PointerX, PointerY, BoundsX, BoundsY,
Tap, SingleTap, Double... | 1 | 19,704 | Not evident from looking at this diff but the queue is already being cleared four lines below. | holoviz-holoviews | py |
@@ -293,6 +293,16 @@ func (pool *TransactionPool) computeFeePerByte() uint64 {
// checkSufficientFee take a set of signed transactions and verifies that each transaction has
// sufficient fee to get into the transaction pool
func (pool *TransactionPool) checkSufficientFee(txgroup []transactions.SignedTxn) error {
+ ... | 1 | // Copyright (C) 2019-2020 Algorand, Inc.
// This file is part of go-algorand
//
// go-algorand is free software: you can redistribute it and/or modify
// it under the terms of the GNU Affero General Public License as
// published by the Free Software Foundation, either version 3 of the
// License, or (at your option) ... | 1 | 39,852 | Why is this a 'transaction' and not in the block header? | algorand-go-algorand | go |
@@ -2,12 +2,14 @@
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
using System.IO;
+using System.Security.Cryptography.X509Certificates;
namespace Microsoft.AspNet.Server.Kestrel.Filter
{
public class ConnectionFilterContext
{
pu... | 1 | // Copyright (c) .NET Foundation. All rights reserved.
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
using System.IO;
namespace Microsoft.AspNet.Server.Kestrel.Filter
{
public class ConnectionFilterContext
{
public ServerAddress Addres... | 1 | 6,565 | This doesn't fit the abstraction level. Should we have a property bag for extra stuff? | aspnet-KestrelHttpServer | .cs |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.