patch stringlengths 17 31.2k | y int64 1 1 | oldf stringlengths 0 2.21M | idx int64 1 1 | id int64 4.29k 68.4k | msg stringlengths 8 843 | proj stringclasses 212
values | lang stringclasses 9
values |
|---|---|---|---|---|---|---|---|
@@ -36,3 +36,17 @@ TWO_ENABLED = {'scanners': [
{'name': 'cloudsql_acl', 'enabled': False},
{'name': 'iam_policy', 'enabled': True}
]}
+
+NONEXISTENT_ENABLED = {'scanners': [
+ {'name': 'bigquery', 'enabled': False},
+ {'name': 'bucket_acl', 'enabled': True},
+ {'name': 'cloudsql_acl', 'enabled': Fa... | 1 | # Copyright 2017 The Forseti Security Authors. All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by ap... | 1 | 32,440 | This is not being used anymore, so can be removed. | forseti-security-forseti-security | py |
@@ -127,6 +127,17 @@ type PodIPs struct {
ipStrings []string
}
+func (p PodIPs) String() string {
+ res := ""
+ if p.ipv4 != nil {
+ res += fmt.Sprintf("IPv4: %s, ", p.ipv4.String())
+ }
+ if p.ipv6 != nil {
+ res += fmt.Sprintf("IPv6: %s, ", p.ipv6.String())
+ }
+ return fmt.Sprintf("%sIP strings: %s", res, str... | 1 | // Copyright 2019 Antrea Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to ... | 1 | 26,252 | Is it called some where? | antrea-io-antrea | go |
@@ -20,10 +20,11 @@ import (
"bytes"
"encoding/json"
"fmt"
- . "github.com/openebs/maya/pkg/msg/v1alpha1"
+ "reflect"
+
+ _ "github.com/openebs/maya/pkg/msg/v1alpha1"
ft "k8s.io/client-go/third_party/forked/golang/template"
jp "k8s.io/client-go/util/jsonpath"
- "reflect"
)
type selection struct { | 1 | /*
Copyright 2018 The OpenEBS Authors
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, soft... | 1 | 9,882 | Please remove this extra blank line. | openebs-maya | go |
@@ -176,7 +176,7 @@ public class CheckUnusedDependenciesTask extends DefaultTask {
return ignore.get().contains(BaselineExactDependencies.asString(artifact));
}
- @Input
+ @InputFiles
public final Provider<List<Configuration>> getDependenciesConfigurations() {
return dependenciesConf... | 1 | /*
* (c) Copyright 2019 Palantir Technologies Inc. All rights reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless ... | 1 | 8,351 | this is really the key, if you don't set this then gradle doesn't wire up the tasks that produce various files inside these configurations as inputs... I think we were just getting lucky before. | palantir-gradle-baseline | java |
@@ -14,3 +14,13 @@ func TestNewSnapshot(t *testing.T) {
_, err := restic.NewSnapshot(paths, nil, "foo", time.Now())
rtest.OK(t, err)
}
+
+func TestTagList(t *testing.T) {
+ paths := []string{"/home/foobar"}
+ tags := []string{""}
+
+ sn, _ := restic.NewSnapshot(paths, nil, "foo", time.Now())
+
+ r := sn.HasTags(ta... | 1 | package restic_test
import (
"testing"
"time"
"github.com/restic/restic/internal/restic"
rtest "github.com/restic/restic/internal/test"
)
func TestNewSnapshot(t *testing.T) {
paths := []string{"/home/foobar"}
_, err := restic.NewSnapshot(paths, nil, "foo", time.Now())
rtest.OK(t, err)
}
| 1 | 15,225 | Sorry if I'm missing something here, but shouldn't this message be about failing to match with an *empty* selector, and/or perhaps even an empty *tag* instead of selector? The message seems a bit disconnected from what we're testing? | restic-restic | go |
@@ -1,5 +1,8 @@
// Copyright (c) Microsoft. All rights reserved.
+using System.IO;
+using Microsoft.TestPlatform.VsTestConsole.TranslationLayer.Payloads;
+
namespace Microsoft.TestPlatform.VsTestConsole.TranslationLayer.UnitTests
{
using System; | 1 | // Copyright (c) Microsoft. All rights reserved.
namespace Microsoft.TestPlatform.VsTestConsole.TranslationLayer.UnitTests
{
using System;
using System.Collections.Generic;
using System.Linq;
using System.Linq.Expressions;
using System.Threading;
using System.Threading.Tasks;
using Micros... | 1 | 11,178 | nit: please move these inside namespace. | microsoft-vstest | .cs |
@@ -139,6 +139,13 @@ var (
Value: metadata.Testnet3Definition.Testnet3HermesURL,
Hidden: true,
}
+ // FlagPaymentsDuringSessionDebug sets if we're in debug more for the payments done in a VPN session.
+ FlagPaymentsDuringSessionDebug = cli.BoolFlag{
+ Name: "payments.during-session-debug",
+ Usage: "Set d... | 1 | /*
* Copyright (C) 2019 The "MysteriumNetwork/node" Authors.
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
... | 1 | 17,383 | may users try to abuse it? | mysteriumnetwork-node | go |
@@ -242,8 +242,9 @@ public class FlatBufferBuilder {
int new_buf_size = old_buf_size == 0 ? 1 : old_buf_size << 1;
bb.position(0);
ByteBuffer nbb = bb_factory.newByteBuffer(new_buf_size);
+ new_buf_size = nbb.capacity(); // TODO - Maybe we get the buffer's `limit()`
nbb.positi... | 1 | /*
* Copyright 2014 Google Inc. All rights reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applica... | 1 | 16,603 | why is this space removed? | google-flatbuffers | java |
@@ -1,3 +1,4 @@
+//go:build !windows
// +build !windows
// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | 1 | // +build !windows
// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
// SPDX-License-Identifier: Apache-2.0
package main
const (
shortDescription = "👩✈️ Launch and manage containerized applications on AWS."
)
| 1 | 19,874 | Can we remove this other line now then? | aws-copilot-cli | go |
@@ -52,6 +52,7 @@ PERFECT_FILES = [
'qutebrowser/misc/checkpyver.py',
'qutebrowser/misc/guiprocess.py',
'qutebrowser/misc/editor.py',
+ 'qutebrowser/misc/cmdhistory.py'
'qutebrowser/mainwindow/statusbar/keystring.py',
'qutebrowser/mainwindow/statusbar/percentage.py', | 1 | #!/usr/bin/env python3
# vim: ft=python fileencoding=utf-8 sts=4 sw=4 et:
# Copyright 2015 Florian Bruhin (The Compiler) <mail@qutebrowser.org>
# This file is part of qutebrowser.
#
# qutebrowser is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as publishe... | 1 | 13,411 | There's a comma missing here at the end :wink: | qutebrowser-qutebrowser | py |
@@ -19,13 +19,8 @@ namespace Microsoft.DotNet.Build.Tasks.Feed
[Required]
public string AccountKey { get; set; }
- [Required]
public ITaskItem[] ItemsToPush { get; set; }
- public string IndexDirectory { get; set; }
-
- public bool PublishFlatContainer { get; set; }
-... | 1 | // Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.
using System;
using System.Threading.Tasks;
using MSBuild = Microsoft.Build.Utilities;
using Microsoft.Build.Framewo... | 1 | 13,761 | Why is this not required any longer? | dotnet-buildtools | .cs |
@@ -6,11 +6,13 @@ package admin
import (
"github.com/Unknwon/com"
+ "github.com/Unknwon/paginater"
"github.com/gogits/gogs/models"
"github.com/gogits/gogs/modules/base"
"github.com/gogits/gogs/modules/log"
"github.com/gogits/gogs/modules/middleware"
+ "github.com/gogits/gogs/modules/setting"
)
... | 1 | // Copyright 2014 The Gogs Authors. All rights reserved.
// Use of this source code is governed by a MIT-style
// license that can be found in the LICENSE file.
package admin
import (
"github.com/Unknwon/com"
"github.com/gogits/gogs/models"
"github.com/gogits/gogs/modules/base"
"github.com/gogits/gogs/modules/lo... | 1 | 9,379 | Indentation seems a bit fucked up here. Run `go fmt`. | gogs-gogs | go |
@@ -650,6 +650,9 @@ func (api *Server) GetLogs(
ctx context.Context,
in *iotexapi.GetLogsRequest,
) (*iotexapi.GetLogsResponse, error) {
+ if in.GetFilter() == nil {
+ return nil, status.Error(codes.InvalidArgument, "empty filter")
+ }
switch {
case in.GetByBlock() != nil:
req := in.GetByBlock() | 1 | // Copyright (c) 2019 IoTeX Foundation
// This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no
// warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent
// permitted by law, all liability for your use... | 1 | 22,274 | any chance in == nil? same below | iotexproject-iotex-core | go |
@@ -150,15 +150,15 @@ static int create_spawnproc(h2o_configurator_command_t *cmd, yoml_t *node, const
}
/* create socket */
- if ((listen_fd = socket(AF_UNIX, SOCK_STREAM, 0)) == -1) {
+ if ((listen_fd = h2o_sysfn(socket, AF_UNIX, SOCK_STREAM, 0)) == -1) {
h2o_configurator_errprintf(cmd, nod... | 1 | /*
* Copyright (c) 2015 DeNA Co., Ltd. Kazuho Oku
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to
* deal in the Software without restriction, including without limitation the
* rights to use, copy, modify, ... | 1 | 14,407 | We would change the source code of h2o so that certain syscalls will be invoked through the `h2o_sysfn` macro. | h2o-h2o | c |
@@ -2895,7 +2895,8 @@ struct SemaphoreSubmitState {
(pSemaphore->scope == kSyncScopeInternal || internal_semaphores.count(semaphore))) {
if (unsignaled_semaphores.count(semaphore) ||
(!(signaled_semaphores.count(semaphore)) && !(pSemaphore->signaled) && !core->SemaphoreWasSign... | 1 | /* Copyright (c) 2015-2021 The Khronos Group Inc.
* Copyright (c) 2015-2021 Valve Corporation
* Copyright (c) 2015-2021 LunarG, Inc.
* Copyright (C) 2015-2021 Google Inc.
* Modifications Copyright (C) 2020-2021 Advanced Micro Devices, Inc. All rights reserved.
*
* Licensed under the Apache License, Version 2.0 (t... | 1 | 15,230 | the name kTimelineCannotBeSignalled is confusing. It's not that a TimelineSemphore cannot be signaled... it's the "VK_KHR_timeline_semaphore is enabled *variant* of the "binary cannot be signaled" message. We should probably have a consistent naming scheme to clarify. kBinaryCannotBeSignalledAltTimeline or hide the com... | KhronosGroup-Vulkan-ValidationLayers | cpp |
@@ -2541,7 +2541,7 @@ defaultdict(<class 'list'>, {'col..., 'col...})]
return DataFrame(sdf, self._metadata.copy())
# TODO: percentiles, include, and exclude should be implemented.
- def describe(self) -> 'DataFrame':
+ def describe(self, percentiles=None) -> 'DataFrame':
"""
Gen... | 1 | #
# Copyright (C) 2019 Databricks, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to i... | 1 | 9,546 | Could you add a type hint? `percentiles: Optional[List[float]] = None` | databricks-koalas | py |
@@ -0,0 +1,16 @@
+module Ncr
+ module WorkOrdersHelper
+ def approver_options
+ # @todo should this list be limited by client/something else?
+ # @todo is there a better order? maybe by current_user's use?
+ User.order(:email_address).pluck(:email_address)
+ end
+
+ def building_options
+ ... | 1 | 1 | 13,371 | Maybe putting ones they've used before first would be good, but this is fine for now. | 18F-C2 | rb | |
@@ -105,6 +105,9 @@ func newVXLANManager(
blackHoleProto = dpConfig.DeviceRouteProtocol
}
+ noencTarget := routetable.Target{Type: routetable.TargetTypeNoEncap}
+ bhTarget := routetable.Target{Type: routetable.TargetTypeBlackhole}
+
brt := routetable.New(
[]string{routetable.InterfaceNone},
4, | 1 | // Copyright (c) 2016-2021 Tigera, Inc. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by ... | 1 | 19,551 | I don't think we need these. Simpler just to put `routetable.TargetType...` inline below. | projectcalico-felix | c |
@@ -43,7 +43,8 @@ class Dispatcher
when 'parallel'
ParallelDispatcher.new
when 'linear'
- if cart.ncr?
+ # @todo: dynamic dispatch for selection
+ if cart.proposal.client_data_legacy.client == "ncr"
NcrDispatcher.new
else
LinearDispatcher.new | 1 | class Dispatcher
def email_approver(approval)
approval.create_api_token!
send_notification_email(approval)
end
def email_observers(cart)
cart.approvals.observing.each do |observer|
CommunicartMailer.cart_observer_email(observer.user_email_address, cart).deliver
end
end
def email_sent_c... | 1 | 12,672 | Why this instead of the old way? | 18F-C2 | rb |
@@ -549,10 +549,14 @@ void Mob::SetInvisible(uint8 state)
invisible = state;
SendAppearancePacket(AT_Invis, invisible);
// Invis and hide breaks charms
-
auto formerpet = GetPet();
- if (formerpet && formerpet->GetPetType() == petCharmed && (invisible || hidden || improved_hidden))
- formerpet->BuffFadeByEffec... | 1 | /* EQEMu: Everquest Server Emulator
Copyright (C) 2001-2016 EQEMu Development Team (http://eqemu.org)
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; version 2 of the License.
This program is d... | 1 | 10,390 | Just combining the inner if/else blocks like this is what I originally meant (I didn't mean replacing all the invisible checks in the outer if, I realize that would have been a functionality change regarding the rule) This should now be equivalent to `if (RuleB(Pets, LivelikeBreakCharmOnInvis) || IsInvisible(formerpet)... | EQEmu-Server | cpp |
@@ -964,6 +964,9 @@ func loadPluginConfig(subrepoConfig *core.Configuration, packageState *core.Buil
contextPackage := &core.Package{SubrepoName: packageState.CurrentSubrepo}
configValueDefinitions := subrepoConfig.PluginConfig
for key, definition := range configValueDefinitions {
+ if definition.ConfigKey == ""... | 1 | package asp
import (
"context"
"fmt"
"reflect"
"sort"
"strconv"
"strings"
"sync"
"github.com/thought-machine/please/src/core"
)
// A pyObject is the base type for all interpreter objects.
// Strictly the "py" prefix is a misnomer but it's short and easy to follow...
type pyObject interface {
// All pyObject... | 1 | 10,345 | We don't want to write this back to the definition do we? Probably just want to create a local variable for it. | thought-machine-please | go |
@@ -964,6 +964,7 @@ public class PlaybackService extends MediaBrowserServiceCompat {
@Override
public void onPlaybackEnded(MediaType mediaType, boolean stopPlaying) {
+ PlaybackPreferences.clearCurrentlyPlayingTemporaryPlaybackSpeed();
PlaybackService.this.onPlaybackEnded(med... | 1 | package de.danoeh.antennapod.core.service.playback;
import android.app.NotificationManager;
import android.app.PendingIntent;
import android.app.Service;
import android.app.UiModeManager;
import android.bluetooth.BluetoothA2dp;
import android.content.BroadcastReceiver;
import android.content.ComponentName;
import andr... | 1 | 17,812 | Good catch! Could you please move this to `PlaybackService.this.onPlaybackEnded`? I think it's more clean if everything is in one single place. | AntennaPod-AntennaPod | java |
@@ -421,6 +421,7 @@ void LXQtTaskButton::activateWithDraggable()
// in progress to allow drop it into an app
raiseApplication();
KWindowSystem::forceActiveWindow(mWindow);
+ xcb_flush(QX11Info::connection());
}
/************************************************ | 1 | /* BEGIN_COMMON_COPYRIGHT_HEADER
* (c)LGPL2+
*
* LXQt - a lightweight, Qt based, desktop toolset
* https://lxqt.org
*
* Copyright: 2011 Razor team
* 2014 LXQt team
* Authors:
* Alexander Sokoloff <sokoloff.a@gmail.com>
* Kuzma Shapran <kuzma.shapran@gmail.com>
*
* This program or library is f... | 1 | 6,593 | We're trying to avoid X.org specific code. So I'm not a fan of this. Can't this be achieved in display server agnostic way? | lxqt-lxqt-panel | cpp |
@@ -0,0 +1,8 @@
+using System;
+
+namespace Collections.Core
+{
+ public class Class1
+ {
+ }
+} | 1 | 1 | 13,557 | This class can be removed? | MvvmCross-MvvmCross | .cs | |
@@ -13,8 +13,10 @@ import (
"net"
"strconv"
+ "github.com/iotexproject/iotex-core/action/protocol"
+
"github.com/golang/protobuf/proto"
- grpc_prometheus "github.com/grpc-ecosystem/go-grpc-prometheus"
+ "github.com/grpc-ecosystem/go-grpc-prometheus"
"github.com/pkg/errors"
"go.uber.org/zap"
"google.golang... | 1 | // Copyright (c) 2019 IoTeX
// This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no
// warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent
// permitted by law, all liability for your use of the cod... | 1 | 15,285 | File is not `goimports`-ed (from `goimports`) | iotexproject-iotex-core | go |
@@ -72,9 +72,7 @@ type Config struct {
// Logger provides a logger for the dispatcher. The default logger is a
// no-op.
- // TODO(shah): Export this when we're ready to deploy a branch in
- // demo-yarpc-go.
- logger *zap.Logger
+ Logger *zap.Logger
}
// Inbounds contains a list of inbound transports. Each i... | 1 | // Copyright (c) 2017 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge... | 1 | 13,235 | To minimize the possibility of regret, perhaps we name this `ZapLogger`. | yarpc-yarpc-go | go |
@@ -40,8 +40,9 @@ IntercomRails.config do |config|
user_hash: Proc.new { |current_user| OpenSSL::HMAC.hexdigest("sha256",
ENV['INTERCOM_API_SECRET'],
current_user.email) },
-
- :pl... | 1 | IntercomRails.config do |config|
# == Intercom app_id
#
config.app_id = ENV["INTERCOM_APP_ID"]
# == Intercom secret key
# This is required to enable secure mode, you can find it on your Intercom
# "security" configuration page.
#
config.api_secret = ENV['INTERCOM_API_SECRET']
# == Intercom API Key
... | 1 | 8,092 | This looks a little weird, but it's a feature of the gem we're using. You can give it a symbol representing the method you want called on current_user. | thoughtbot-upcase | rb |
@@ -20,13 +20,11 @@
# ----------------------------------------------------------------------
"""
-Template file used by the OPF Experiment Generator to generate the actual
-description.py file by replacing $XXXXXXXX tokens with desired values.
-
-This description.py file was generated by:
-'~/nupic/eng/lib/python2.... | 1 | # ----------------------------------------------------------------------
# Numenta Platform for Intelligent Computing (NuPIC)
# Copyright (C) 2013, Numenta, Inc. Unless you have an agreement
# with Numenta, Inc., for a separate license for this software code, the
# following terms and conditions apply:
#
# This progra... | 1 | 17,808 | `Anomaly` imported here, but not used. Please run the changed files through pylint with nupic pylint config and fix pylint findings related to your changes. | numenta-nupic | py |
@@ -42,8 +42,18 @@ testUtils.checkSetup = function (content, options, target) {
target = options;
options = {};
}
+ // Normalize target, allow it to be the inserted node or '#target'
+ target = target || (content instanceof Node ? content : '#target');
testUtils.fixtureSetup(content);
- var node = axe.utils.q... | 1 | var testUtils = {};
testUtils.shadowSupport = (function(document) {
'use strict';
var v0 = document.body && typeof document.body.createShadowRoot === 'function',
v1 = document.body && typeof document.body.attachShadow === 'function';
return {
v0: (v0 === true),
v1: (v1 === true),
undefined: (
document.... | 1 | 11,342 | We needed this testutils file after all | dequelabs-axe-core | js |
@@ -46,7 +46,7 @@ func addTestingTsfBlocks(bc Blockchain) error {
big.NewInt(10),
)
pubk, _ := keypair.DecodePublicKey(Gen.CreatorPubKey)
- sig, _ := hex.DecodeString("9c1fb14affb398f850d0642f22f12433526bed742fbfb39115f9df2549b2751347bafe9ddbe50e6f02906bdc83b7c905944adc19583726dfaea83245318132ff01")
+ sig, _ := ... | 1 | // Copyright (c) 2018 IoTeX
// This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no
// warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent
// permitted by law, all liability for your use of the cod... | 1 | 14,872 | line is 161 characters (from `lll`) | iotexproject-iotex-core | go |
@@ -19,6 +19,8 @@ import (
"fmt"
"time"
+ "github.com/chaos-mesh/chaos-mesh/pkg/controllerutils"
+
dnspb "github.com/chaos-mesh/k8s_dns_chaos/pb"
"github.com/go-logr/logr"
"golang.org/x/sync/errgroup" | 1 | // Copyright 2020 Chaos Mesh Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agree... | 1 | 19,806 | Please re-format/groupimport this line. You might need a little manual work. | chaos-mesh-chaos-mesh | go |
@@ -35,7 +35,11 @@ type DaisyWorker interface {
// designed to be run once and discarded. In other words, don't run RunAndReadSerialValue
// twice on the same instance.
func NewDaisyWorker(wf *daisy.Workflow, env EnvironmentSettings, logger logging.Logger) DaisyWorker {
- return &defaultDaisyWorker{wf, env, logger}
... | 1 | // Copyright 2020 Google Inc. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by appl... | 1 | 13,798 | minor, you can just use `wf` instead of `worker.wf` | GoogleCloudPlatform-compute-image-tools | go |
@@ -161,11 +161,12 @@ public final class HttpRequestUtilsTest {
@Test
public void testGetJsonBodyForSingleMapObject() throws IOException, ServletException {
final HttpServletRequest httpRequest = Mockito.mock(HttpServletRequest.class);
- final String originalString = " {\n" + " \"action\": \"update\",... | 1 | /*
* Copyright 2015 LinkedIn Corp.
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not
* use this file except in compliance with the License. You may obtain a copy of
* the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to i... | 1 | 20,040 | I would suggest putting this in the resources directory with the same package as of this test class. Then you can utilize the method azkaban.utils.TestUtils#readResource to read it as string. | azkaban-azkaban | java |
@@ -21,6 +21,7 @@ import (
"text/template"
errors "github.com/openebs/maya/pkg/errors/v1alpha1"
+ templates "github.com/openebs/maya/pkg/upgrade/templates"
appsv1 "k8s.io/api/apps/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
types "k8s.io/apimachinery/pkg/types" | 1 | /*
Copyright 2019 The OpenEBS Authors
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, soft... | 1 | 17,156 | could not import github.com/openebs/maya/pkg/upgrade/templates (invalid package name: "") (from `typecheck`) | openebs-maya | go |
@@ -182,7 +182,7 @@ namespace OpenTelemetry.Exporter.Prometheus.Tests
// Once a pull model is implemented, we'll not have this issue and we need to add tests
// at that time.
- // If in future, there is a official .NET Prometheus Client library, and OT Exporter
+ // If ... | 1 | // <copyright file="PrometheusExporterTests.cs" company="OpenTelemetry Authors">
// Copyright The OpenTelemetry Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://w... | 1 | 16,052 | a official -> an official | open-telemetry-opentelemetry-dotnet | .cs |
@@ -37,7 +37,7 @@ class ProxyListenerKinesis(ProxyListener):
def forward_request(self, method, path, data, headers):
data, encoding_type = self.decode_content(data or '{}', True)
action = headers.get('X-Amz-Target', '').split('.')[-1]
- if action == 'RegisterStreamConsumer':
+ if ac... | 1 | import re
import json
import time
import base64
import random
import logging
import cbor2
from requests.models import Response
from localstack import config
from localstack.constants import APPLICATION_JSON, APPLICATION_CBOR
from localstack.utils.aws import aws_stack
from localstack.utils.common import to_str, json_saf... | 1 | 12,570 | I only want the proxy request for this to run for kinesalite. | localstack-localstack | py |
@@ -272,7 +272,7 @@ var DatePicker = React.createClass({displayName: 'DatePicker',
React.DOM.div(null,
DateInput({
date: this.props.selected,
- dateFormat: this.props.dateFormat,
+ dateFormat: this.props.dateFormat,
focus: this.state.focus,
onBlur: ... | 1 | !function(e){if("object"==typeof exports&&"undefined"!=typeof module)module.exports=e();else if("function"==typeof define&&define.amd)define([],e);else{var f;"undefined"!=typeof window?f=window:"undefined"!=typeof global?f=global:"undefined"!=typeof self&&(f=self),f.DatePicker=e()}}(function(){var define,module,exports... | 1 | 4,792 | White space boya? | Hacker0x01-react-datepicker | js |
@@ -79,6 +79,9 @@ type StackEvent cloudformation.StackEvent
// StackDescription represents an existing AWS CloudFormation stack.
type StackDescription cloudformation.Stack
+// StackSummary represents a summary of an existing AWS CloudFormation stack.
+type StackSummary cloudformation.StackSummary
+
// SDK returns ... | 1 | // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
// SPDX-License-Identifier: Apache-2.0
package cloudformation
import (
"github.com/aws/aws-sdk-go/aws"
"github.com/aws/aws-sdk-go/service/cloudformation"
)
// Stack represents a AWS CloudFormation stack.
type Stack struct {
Name string
*stackC... | 1 | 15,659 | Maybe ditch these since `StackSummary` is not used anymore. | aws-copilot-cli | go |
@@ -21,14 +21,15 @@ class BaseSemanticHead(BaseModule, metaclass=ABCMeta):
num_classes,
init_cfg=None,
loss_seg=dict(
- type='CrossEntropyLoss', ignore_index=-1,
+ type='CrossEntropyLoss',
+ ignore_index=25... | 1 | # Copyright (c) OpenMMLab. All rights reserved.
from abc import ABCMeta, abstractmethod
import torch.nn.functional as F
from mmcv.runner import BaseModule, force_fp32
from ..builder import build_loss
from ..utils import interpolate_as
class BaseSemanticHead(BaseModule, metaclass=ABCMeta):
"""Base module of Sema... | 1 | 25,858 | suggest to indicate the value range & meaning in docstring | open-mmlab-mmdetection | py |
@@ -20,7 +20,7 @@ const (
// calls.
listenAddress = ":9500"
// metricsPath is the endpoint of exporter.
- metricsPath = "/metrics"
+ metricsPath = "/metrics/"
// controllerAddress is the address where jiva controller listens.
controllerAddress = "http://localhost:9501"
// casType is the type of container at... | 1 | package command
import (
"errors"
goflag "flag"
"log"
"net/url"
"github.com/golang/glog"
"github.com/openebs/maya/cmd/maya-exporter/app/collector"
"github.com/openebs/maya/pkg/util"
"github.com/prometheus/client_golang/prometheus"
"github.com/spf13/cobra"
)
// Constants defined here are the default value of... | 1 | 10,573 | not sure if it works with prometheus by default, otherwise we will have to add this into prometheus config also | openebs-maya | go |
@@ -24,6 +24,10 @@ import (
"github.com/projectcalico/felix/stringutils"
)
+func (r *DefaultRuleRenderer) CleanupEndPoint(ifaceName string) {
+ r.epmm.RemoveEndPointMark(ifaceName)
+}
+
func (r *DefaultRuleRenderer) WorkloadDispatchChains(
endpoints map[proto.WorkloadEndpointID]*proto.WorkloadEndpoint,
) []*Ch... | 1 | // Copyright (c) 2017 Tigera, Inc. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by appli... | 1 | 16,061 | The rule renderer isn't meant to be stateful so probably best to move this out of here | projectcalico-felix | c |
@@ -57,6 +57,7 @@ func setupContainerdConfig(ctx context.Context, cfg *config.Node) error {
DisableCgroup: disableCgroup,
IsRunningInUserNS: isRunningInUserNS,
PrivateRegistryConfig: privRegistries.Registry(),
+ ExtraRuntimes: findNvidiaContainerRuntimes(nil),
}
selEnabled, selConfig... | 1 | // +build linux
package containerd
import (
"context"
"io/ioutil"
"os"
"time"
"github.com/opencontainers/runc/libcontainer/userns"
"github.com/pkg/errors"
"github.com/rancher/k3s/pkg/agent/templates"
util2 "github.com/rancher/k3s/pkg/agent/util"
"github.com/rancher/k3s/pkg/cgroups"
"github.com/rancher/k3s/... | 1 | 10,032 | passing in a `nil` here just so that the tests can pass in an alternative implementation seems weird, but I don't know what the convention is for doing something like this - @briandowns? | k3s-io-k3s | go |
@@ -3,12 +3,12 @@
'use strict';
var clone = require('clone');
-var dot = require('@deque/dot');
+var doT = require('@deque/dot');
var templates = require('./templates');
var buildManual = require('./build-manual');
var entities = new (require('html-entities').AllHtmlEntities)();
var packageJSON = require('../pa... | 1 | /*eslint-env node */
/*eslint max-len: off */
'use strict';
var clone = require('clone');
var dot = require('@deque/dot');
var templates = require('./templates');
var buildManual = require('./build-manual');
var entities = new (require('html-entities').AllHtmlEntities)();
var packageJSON = require('../package.json');
... | 1 | 17,212 | IMO `dot` should be preferred. Remember `aXe`? | dequelabs-axe-core | js |
@@ -59,6 +59,7 @@ namespace AppDomain.Instance
return -10;
}
+ Console.ReadKey();
return 0;
}
} | 1 | using System;
using System.Data.Common;
using System.Data.SqlClient;
using System.Net.Http;
using System.Net.Http.Headers;
using System.Reflection;
using System.Runtime.InteropServices;
using System.Threading;
namespace AppDomain.Instance
{
public class AppDomainInstanceProgram : MarshalByRefObject
{
p... | 1 | 16,162 | Not a huge deal but this will block tests, also, don't they stay open by default now? | DataDog-dd-trace-dotnet | .cs |
@@ -70,7 +70,7 @@ func makeLevels(min logrus.Level) []logrus.Level {
}
func makeTelemetryState(cfg TelemetryConfig, hookFactory hookFactory) (*telemetryState, error) {
- history := createLogBuffer(cfg.LogHistoryDepth)
+ history := createLogBuffer(2)
if cfg.SessionGUID == "" {
cfg.SessionGUID = uuid.NewV4().Str... | 1 | // Copyright (C) 2019 Algorand, Inc.
// This file is part of go-algorand
//
// go-algorand is free software: you can redistribute it and/or modify
// it under the terms of the GNU Affero General Public License as
// published by the Free Software Foundation, either version 3 of the
// License, or (at your option) any l... | 1 | 36,913 | Could you make it a local constant for now ? | algorand-go-algorand | go |
@@ -950,6 +950,10 @@ class UserResource(object):
if has_invalid_value:
raise_invalid(self.request, **error_details)
+ if field in ('id', 'collection_id'):
+ if isinstance(value, int):
+ value = str(value)
+
filters.append(... | 1 | import re
import functools
import colander
import venusian
import six
from pyramid import exceptions as pyramid_exceptions
from pyramid.decorator import reify
from pyramid.security import Everyone
from pyramid.httpexceptions import (HTTPNotModified, HTTPPreconditionFailed,
HTTPNotFo... | 1 | 9,919 | What is this `collection_id` field here? | Kinto-kinto | py |
@@ -698,7 +698,10 @@ class Automaton(six.with_metaclass(Automaton_metaclass)):
# Services
def debug(self, lvl, msg):
if self.debug_level >= lvl:
- log_interactive.debug(msg)
+ if conf.interactive:
+ log_interactive.debug(msg)
+ else:
+ pr... | 1 | # This file is part of Scapy
# See http://www.secdev.org/projects/scapy for more information
# Copyright (C) Philippe Biondi <phil@secdev.org>
# Copyright (C) Gabriel Potter <gabriel@potter.fr>
# This program is published under a GPLv2 license
"""
Automata with states, transitions and actions.
"""
from __future__ imp... | 1 | 17,443 | Is there a reason why we don't use logging for this? | secdev-scapy | py |
@@ -0,0 +1,18 @@
+<?php
+
+/**
+ * Copyright © Bold Brand Commerce Sp. z o.o. All rights reserved.
+ * See LICENSE.txt for license details.
+ */
+
+declare(strict_types=1);
+
+namespace Ergonode\Core\Infrastructure\Exception;
+
+class DenoralizationException extends NormalizerException
+{
+ public function __constru... | 1 | 1 | 9,393 | Exceptions should be placed in application layer -> infrastructure is aware of application - not the other way around | ergonode-backend | php | |
@@ -34,6 +34,7 @@ def test_simple_json_output():
("column", 0),
("line", 1),
("message", "Line too long (1/2)"),
+ ("message-id", "C0301"),
("module", "0123"),
("obj", ""),
("path", "0123"), | 1 | # Copyright (c) 2015-2016 Claudiu Popa <pcmanticore@gmail.com>
# Licensed under the GPL: https://www.gnu.org/licenses/old-licenses/gpl-2.0.html
# For details: https://github.com/PyCQA/pylint/blob/master/COPYING
"""Test for the JSON reporter."""
import json
import six
from pylint.lint import PyLinter
from pylint im... | 1 | 9,445 | IIRC issue mentioned reporting _symbolic message_ - so in this case it would be `line-too-long`. | PyCQA-pylint | py |
@@ -1427,6 +1427,7 @@ int GetSpellStatValue(uint32 spell_id, const char* stat_identifier, uint8 slot)
else if (id == "descnum") { return spells[spell_id].descnum; }
else if (id == "effectdescnum") { return spells[spell_id].effectdescnum; }
else if (id == "npc_no_los") { return spells[spell_id].npc_no_los; }
+ els... | 1 | /* EQEMu: Everquest Server Emulator
Copyright (C) 2001-2002 EQEMu Development Team (http://eqemu.org)
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; version 2 of the License.
This program is d... | 1 | 10,848 | Is this intended to be `spells[spell_id].reflectable` here? Edit: Should be `spells[spell_id].feedbackable`, right? | EQEmu-Server | cpp |
@@ -0,0 +1,11 @@
+class AddUsersAllowedToTeams < ActiveRecord::Migration
+ def up
+ add_column :teams, :max_users, :integer
+
+ change_column_null :teams, :max_users, false, 0
+ end
+
+ def down
+ remove_column :teams, :max_users
+ end
+end | 1 | 1 | 8,996 | How should we set this for existing teams? | thoughtbot-upcase | rb | |
@@ -145,6 +145,11 @@ func TestInstallManager(t *testing.T) {
expectPasswordSecret: true,
expectProvisionMetadataUpdate: true,
},
+ {
+ name: "infraID already set on cluster provision", // fatal error
+ existing: []runtime.Object{testClusterDeployment(), testClusterProvisionWithInfraID... | 1 | package installmanager
import (
"context"
"fmt"
"io/ioutil"
"os"
"path"
"path/filepath"
"testing"
"github.com/stretchr/testify/require"
log "github.com/sirupsen/logrus"
"github.com/stretchr/testify/assert"
corev1 "k8s.io/api/core/v1"
apierrors "k8s.io/apimachinery/pkg/api/errors"
metav1 "k8s.io/apimach... | 1 | 20,899 | It would be nice if we could verify that this is in fact the error we expected. But that's a latent issue, something for the backlog. | openshift-hive | go |
@@ -23,11 +23,11 @@ import (
"testing"
"time"
+ "github.com/mysteriumnetwork/go-openvpn/openvpn"
+ "github.com/mysteriumnetwork/go-openvpn/openvpn/middlewares/state"
"github.com/mysteriumnetwork/node/client/stats"
"github.com/mysteriumnetwork/node/communication"
"github.com/mysteriumnetwork/node/identity"
-... | 1 | /*
* Copyright (C) 2017 The "MysteriumNetwork/node" Authors.
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
... | 1 | 11,897 | I hate then some internal process specific middleware leaks into connection manager :( todo later. | mysteriumnetwork-node | go |
@@ -102,7 +102,14 @@ def setupNupic():
name = "nupic",
version = version,
packages = findPackages(repositoryDir),
+ # A lot of this stuff may not be packaged properly, most if it was added in
+ # an effort to get a binary package prepared for nupic.regression testing
+ # on Travis-CI, but it was... | 1 | import shutil
import sys
import os
import subprocess
from setuptools import setup
"""
This file only will call CMake process to generate scripts, build, and then
install the NuPIC binaries. ANY EXTRA code related to build process MUST be
put into CMake file.
"""
repositoryDir = os.getcwd()
# Read command line optio... | 1 | 16,782 | Reflects where these files were moved for `pkg_resources`. | numenta-nupic | py |
@@ -1,8 +1,12 @@
import AbstractIndexRoute from 'hospitalrun/routes/abstract-index-route';
import { translationMacro as t } from 'ember-i18n';
+import Ember from 'ember';
+const { computed } = Ember;
export default AbstractIndexRoute.extend({
- pageTitle: t('admin.textReplacements.pageTitle'),
+ pageTitle: compu... | 1 | import AbstractIndexRoute from 'hospitalrun/routes/abstract-index-route';
import { translationMacro as t } from 'ember-i18n';
export default AbstractIndexRoute.extend({
pageTitle: t('admin.textReplacements.pageTitle'),
hideNewButton: true,
model() {
let store = this.get('store');
return store.findAll('t... | 1 | 13,690 | This should be computed('i18n.locale'.... | HospitalRun-hospitalrun-frontend | js |
@@ -1351,6 +1351,12 @@ func describeBPFTests(opts ...bpfTestOpt) bool {
// Add a route to felix[1] to be able to reach the nodeport
_, err = eth20.RunCmd("ip", "route", "add", felixes[1].IP+"/32", "via", "10.0.0.20")
Expect(err).NotTo(HaveOccurred())
+ // This multi-NIC scenario wo... | 1 | // Copyright (c) 2020 Tigera, Inc. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by appli... | 1 | 17,879 | Can you explain to me what goes wrong here? Can the test be adjusted to set up working routing instead? | projectcalico-felix | c |
@@ -32,10 +32,10 @@ import org.openqa.selenium.remote.tracing.HttpTracing;
import org.openqa.selenium.remote.tracing.Tracer;
import java.net.URL;
+import java.util.Objects;
import java.util.UUID;
import java.util.logging.Logger;
-import static org.openqa.selenium.net.Urls.fromUri;
import static org.openqa.sele... | 1 | // Licensed to the Software Freedom Conservancy (SFC) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The SFC licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you m... | 1 | 17,752 | We can get rid of this import then. | SeleniumHQ-selenium | py |
@@ -36,14 +36,14 @@ type morqaTransport struct {
}
func (transport *morqaTransport) SendEvent(event Event) error {
- if metric := mapEventToMetric(event); metric != nil {
- return transport.morqaClient.SendMetric(metric)
+ if id, metric := mapEventToMetric(event); metric != nil {
+ return transport.morqaClient.Se... | 1 | /*
* Copyright (C) 2019 The "MysteriumNetwork/node" Authors.
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
... | 1 | 16,364 | Not sure how useful is unlock event. | mysteriumnetwork-node | go |
@@ -31,8 +31,8 @@ import (
// This code is copied from memdocstore/codec.go, with some changes:
// - special treatment for primitive.Binary
-func encodeDoc(doc driver.Document) (map[string]interface{}, error) {
- var e encoder
+func encodeDoc(doc driver.Document, lowercaseFields bool) (map[string]interface{}, error... | 1 | // Copyright 2019 The Go Cloud Development Kit Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// https://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by appli... | 1 | 17,156 | Consider make the second argument a `encoderOptions` which includes the `lowercaseFields` just like opening a collection. | google-go-cloud | go |
@@ -82,11 +82,13 @@ public class HiveIcebergOutputCommitter extends OutputCommitter {
/**
* Collects the generated data files and creates a commit file storing the data file list.
- * @param context The job context
+ * @param ctx The task attempt context
* @throws IOException Thrown if there is an erro... | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you ... | 1 | 32,776 | What is the value of renaming this to `ctx`? We generally prefer the longer names because they are easier to read and to type. | apache-iceberg | java |
@@ -352,8 +352,14 @@ bool TurnLaneHandler::isSimpleIntersection(const LaneDataVector &lane_data,
if (lane_data.back().tag == TurnLaneType::uturn)
return findBestMatchForReverse(lane_data[lane_data.size() - 2].tag, intersection);
- BOOST_ASSERT(lane_data.front().tag == TurnLane... | 1 | #include "extractor/guidance/turn_lane_handler.hpp"
#include "extractor/guidance/constants.hpp"
#include "extractor/guidance/turn_discovery.hpp"
#include "extractor/guidance/turn_lane_augmentation.hpp"
#include "extractor/guidance/turn_lane_matcher.hpp"
#include "util/simple_logger.hpp"
#include "util/typedefs.hpp"
#i... | 1 | 17,232 | Hm. This could be a case of left-sided driving, having u-turn lanes on the right side. Good catch, but looks good to me. | Project-OSRM-osrm-backend | cpp |
@@ -21,12 +21,12 @@ namespace Nethermind.Merge.Plugin.Data
{
public class Result
{
- public static readonly Result Success = new Result() {Value = true};
- public static readonly Result Fail = new Result() {Value = false};
+ public static readonly Result OK = new() {success = true};
+ ... | 1 | // Copyright (c) 2021 Demerzel Solutions Limited
// This file is part of the Nethermind library.
//
// The Nethermind library is free software: you can redistribute it and/or modify
// it under the terms of the GNU Lesser General Public License as published by
// the Free Software Foundation, either version 3 of... | 1 | 25,329 | There was a [JsonPropertyName("success")] here it did serialize fine for me, so I am not sure what was the matter? Also maybe uppercase? | NethermindEth-nethermind | .cs |
@@ -246,7 +246,8 @@ namespace Nethermind.Runner.Ethereum.Steps
case SealEngineType.AuRa:
AbiEncoder abiEncoder = new AbiEncoder();
_context.ValidatorStore = new ValidatorStore(_context.DbProvider.BlockInfosDb);
- IAuRaValidatorProcessor valid... | 1 | // Copyright (c) 2018 Demerzel Solutions Limited
// This file is part of the Nethermind library.
//
// The Nethermind library is free software: you can redistribute it and/or modify
// it under the terms of the GNU Lesser General Public License as published by
// the Free Software Foundation, either version 3 of ... | 1 | 23,154 | we can just use read env here, pretty sure | NethermindEth-nethermind | .cs |
@@ -91,6 +91,7 @@ class MergeCells extends BasePlugin {
this.autofillCalculations = new AutofillCalculations(this);
this.selectionCalculations = new SelectionCalculations();
+ this.hot.selection.transformation.addLocalHook('afterTransformStart', (...args) => this.onAfterLocalTransformStart(...args));
... | 1 | import BasePlugin from './../_base';
import Hooks from './../../pluginHooks';
import {registerPlugin} from './../../plugins';
import {stopImmediatePropagation} from './../../helpers/dom/event';
import {CellCoords, CellRange} from './../../3rdparty/walkontable/src';
import MergedCellsCollection from './cellsCollection';... | 1 | 14,685 | Could you replace local hook with global hook `afterModifyTransformStart`? | handsontable-handsontable | js |
@@ -854,3 +854,10 @@ class FileArchive(Archive):
def listing(self):
"Return a list of filename entries currently in the archive"
return ['.'.join([f,ext]) if ext else f for (f,ext) in self._files.keys()]
+
+ def clear(self):
+ "Clears the file archive"
+ self._files.clear()
+
+ ... | 1 | """
Module defining input/output interfaces to HoloViews.
There are two components for input/output:
Exporters: Process (composite) HoloViews objects one at a time. For
instance, an exporter may render a HoloViews object as a
svg or perhaps pickle it.
Archives: A collection of HoloViews objects... | 1 | 23,635 | You seem to be basing your PRs off an commit, which keeps reintroducing these changes, which makes it harder to review your PRs. | holoviz-holoviews | py |
@@ -52,6 +52,8 @@ var Server = function(requestHandler) {
* with the server host when it has fully started.
*/
this.start = function(opt_port) {
+ assert(typeof opt_port !== 'function',
+ "start invoked with function, not port (mocha callback)?");
var port = opt_port || portprober.findF... | 1 | // Copyright 2013 Selenium committers
// Copyright 2013 Software Freedom Conservancy
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
/... | 1 | 11,552 | Maybe it would simpler to ignore opt_port if type !== 'number'? | SeleniumHQ-selenium | py |
@@ -38,7 +38,7 @@ namespace OpenTelemetry.Trace
/// <summary>
/// Gets or sets attributes known prior to span creation.
/// </summary>
- public IDictionary<string, object> Attributes { get; set; }
+ public IEnumerable<KeyValuePair<string, object>> Attributes { get; set; }
... | 1 | // <copyright file="SpanCreationOptions.cs" company="OpenTelemetry Authors">
// Copyright 2018, OpenTelemetry Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www... | 1 | 13,618 | As far as I can tell, `IDictionary<string, object>` implements `IEnumerable<KeyValuePair,string, object>>` so we are just making it more generic. From the issue, I understood that we want to maintain sequence/order. I believe `IEnumerable<>` won't fix the issue. | open-telemetry-opentelemetry-dotnet | .cs |
@@ -124,7 +124,7 @@ public class DockerOptions {
for (int i = 0; i < maxContainerCount; i++) {
node.add(caps, new DockerSessionFactory(clientFactory, docker, image, caps));
}
- LOG.info(String.format(
+ LOG.finest(String.format(
"Mapping %s to docker image %s %d times",
... | 1 | // Licensed to the Software Freedom Conservancy (SFC) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The SFC licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you m... | 1 | 16,469 | This change prevents a user understanding how their server is configured. Best to leave at `info` level. | SeleniumHQ-selenium | java |
@@ -32,6 +32,15 @@ import (
"google.golang.org/grpc/status"
)
+var (
+ ephemeralDenyList = []string{
+ api.SpecPriorityAlias,
+ api.SpecPriority,
+ api.SpecSticky,
+ api.SpecScale,
+ }
+)
+
func (s *OsdCsiServer) NodeGetInfo(
ctx context.Context,
req *csi.NodeGetInfoRequest, | 1 | /*
Package csi is CSI driver interface for OSD
Copyright 2017 Portworx
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law... | 1 | 8,812 | I will add the following to the list: - api.SpecScale - api.SpecSticky | libopenstorage-openstorage | go |
@@ -58,7 +58,7 @@ bool EprosimaClient::init()
//CREATE RTPSParticipant
ParticipantAttributes PParam;
- PParam.rtps.defaultSendPort = 10042;
+ //PParam.rtps.defaultSendPort = 10042; // TODO Create transport?
PParam.rtps.builtin.domainId = 80;
PParam.rtps.builtin.use_SIMPLE_EndpointDiscoveryProtocol = true;
P... | 1 | // Copyright 2016 Proyectos y Sistemas de Mantenimiento SL (eProsima).
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless re... | 1 | 12,892 | As defaultSendPort is being removed, and I don't like TODOs on examples, please remove the whole line | eProsima-Fast-DDS | cpp |
@@ -158,7 +158,6 @@ namespace OpenTelemetry.Resources.Tests
{ "dynamic", new { } },
{ "array", new int[1] },
{ "complex", this },
- { "float", 0.1f },
};
var resource = new Resource(attributes); | 1 | // <copyright file="ResourceTest.cs" company="OpenTelemetry Authors">
// Copyright The OpenTelemetry Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.or... | 1 | 18,583 | since we are now no longer expecting an input of float to return an empty string, i have removed this test case. | open-telemetry-opentelemetry-dotnet | .cs |
@@ -36,6 +36,18 @@ func MakeCounter(metric MetricName) *Counter {
return c
}
+func NewCounter(name, desc string) *Counter {
+ c := &Counter{
+ name: name,
+ description: desc,
+ values: make([]*counterValues, 0),
+ labels: make(map[string]int),
+ valuesIndices: make(map[int]int),
+ }
... | 1 | // Copyright (C) 2019-2020 Algorand, Inc.
// This file is part of go-algorand
//
// go-algorand is free software: you can redistribute it and/or modify
// it under the terms of the GNU Affero General Public License as
// published by the Free Software Foundation, either version 3 of the
// License, or (at your option) ... | 1 | 40,194 | It would be cleaner if you were to pack the name&desc in a `MetricName` and pass it to `MakeCounter` | algorand-go-algorand | go |
@@ -24,5 +24,5 @@ using System.Runtime.CompilerServices;
#else
[assembly: InternalsVisibleTo("OpenTelemetry.Exporter.Jaeger.Tests")]
[assembly: InternalsVisibleTo("Benchmarks")]
-[assembly: InternalsVisibleTo("DynamicProxyGenAssembly2] // Used by Moq.
+[assembly: InternalsVisibleTo("DynamicProxyGenAssembly2")] // Us... | 1 | // <copyright file="AssemblyInfo.cs" company="OpenTelemetry Authors">
// Copyright The OpenTelemetry Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.o... | 1 | 14,813 | Do you know why do we need this? | open-telemetry-opentelemetry-dotnet | .cs |
@@ -7,6 +7,7 @@ using System.Collections.Generic;
using System.Linq;
using MvvmCross.Platform.Ios.Presenters;
using MvvmCross.Platform.Ios.Presenters.Attributes;
+using MvvmCross.iOS.Views;
using MvvmCross.ViewModels;
using UIKit;
| 1 | // Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MS-PL license.
// See the LICENSE file in the project root for more information.
using System;
using System.Collections.Generic;
using System.Linq;
using MvvmCross.Platform.Ios.Presenters;
using... | 1 | 13,766 | I guess this using is what causes the build to fail | MvvmCross-MvvmCross | .cs |
@@ -239,6 +239,7 @@ DECLARE_THREAD_FN(ponyint_asio_backend_dispatch)
close(b->wakeup);
ponyint_messageq_destroy(&b->q);
POOL_FREE(asio_backend_t, b);
+ pony_unregister_thread();
return NULL;
}
| 1 | #define PONY_WANT_ATOMIC_DEFS
#include "asio.h"
#include "event.h"
#ifdef ASIO_USE_EPOLL
#include "../actor/messageq.h"
#include "../mem/pool.h"
#include <sys/epoll.h>
#include <sys/eventfd.h>
#include <sys/timerfd.h>
#include <unistd.h>
#include <string.h>
#include <signal.h>
#include <stdbool.h>
#ifdef USE_VALGRIN... | 1 | 9,948 | I like the explicit unregister approach. | ponylang-ponyc | c |
@@ -25,8 +25,11 @@ namespace OpenTelemetry.Metrics
Type:
0x10: Sum
0x20: Gauge
- 0x30: Histogram
- 0x40: Summary (reserved)
+ 0x40: Histogram
+ 0x50: HistogramWithMinMax (reserved)
+ 0x60: ExponentialHistogram (reserved)
+ ... | 1 | // <copyright file="MetricType.cs" company="OpenTelemetry Authors">
// Copyright The OpenTelemetry Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/... | 1 | 22,922 | We should able to use 0x30 as summary, and make 0x80 reserved for future. | open-telemetry-opentelemetry-dotnet | .cs |
@@ -104,7 +104,7 @@ namespace Datadog.Trace.ClrProfiler
{
tags = null;
- if (!tracer.Settings.IsIntegrationEnabled(integrationId) || HttpBypassHelper.UriContainsAnyOf(requestUri, tracer.Settings.HttpClientExcludedUrlSubstrings))
+ if (!tracer.Settings.IsIntegrationEnabled(i... | 1 | // <copyright file="ScopeFactory.cs" company="Datadog">
// Unless explicitly stated otherwise all files in this repository are licensed under the Apache 2 License.
// This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
// </copyright>
using System;
using Syste... | 1 | 21,424 | This allows strategic exclusion of http spans. | DataDog-dd-trace-dotnet | .cs |
@@ -19,8 +19,10 @@ final class SearchDto
private $searchableProperties;
/** @var string[]|null */
private $appliedFilters;
+ /** @var string[]|null */
+ private $strictTextSearchFields;
- public function __construct(Request $request, ?array $searchableProperties, ?string $query, array $default... | 1 | <?php
namespace EasyCorp\Bundle\EasyAdminBundle\Dto;
use Symfony\Component\HttpFoundation\Request;
/**
* @author Javier Eguiluz <javier.eguiluz@gmail.com>
*/
final class SearchDto
{
private $request;
private $defaultSort;
private $customSort;
/** @internal */
private $mergedSort;
private $q... | 1 | 13,567 | why not just `string[]` instead of nullable | EasyCorp-EasyAdminBundle | php |
@@ -150,7 +150,7 @@ func (e *Extractor) listPackages(query ...string) ([]*jsonPackage, error) {
// TODO(schroederc): support GOPACKAGESDRIVER
args := append([]string{"list",
"-compiler=" + e.BuildContext.Compiler,
- "-tags=" + strings.Join(e.BuildContext.BuildTags, ","),
+ "-tags=" + strings.Join(e.BuildContex... | 1 | /*
* Copyright 2018 The Kythe Authors. All rights reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by ap... | 1 | 10,816 | How does this work? Why isn't each tag after the first picked up as a new arg/flag? | kythe-kythe | go |
@@ -37,5 +37,10 @@ namespace Datadog.Trace
/// The id of the container where the traced application is running.
/// </summary>
public const string ContainerId = "Datadog-Container-ID";
+
+ /// <summary>
+ /// The resource id of the site instance in azure app services where the t... | 1 | using System.Runtime.InteropServices;
namespace Datadog.Trace
{
/// <summary>
/// Names of HTTP headers that can be used when sending traces to the Trace Agent.
/// </summary>
internal static class AgentHttpHeaderNames
{
/// <summary>
/// The language-specific tracer that generated ... | 1 | 16,586 | This key is actually yet to be determined. Meeting with the backend team and Garner to discuss. | DataDog-dd-trace-dotnet | .cs |
@@ -1298,12 +1298,8 @@ bool CoreChecks::ValidateImageUpdate(VkImageView image_view, VkImageLayout image
const char *func_name, std::string *error_code, std::string *error_msg) {
*error_code = "VUID-VkWriteDescriptorSet-descriptorType-00326";
auto iv_state = GetImageViewSt... | 1 | /* Copyright (c) 2015-2019 The Khronos Group Inc.
* Copyright (c) 2015-2019 Valve Corporation
* Copyright (c) 2015-2019 LunarG, Inc.
* Copyright (C) 2015-2019 Google Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You m... | 1 | 11,094 | Why remove the crash protection? We're just going to get a bug filed on it. | KhronosGroup-Vulkan-ValidationLayers | cpp |
@@ -24,6 +24,10 @@ export const HEADERS = {
TEXT_PLAIN: 'text/plain',
TEXT_HTML: 'text/html',
FORWARDED_PROTO: 'X-Forwarded-Proto',
+ XFRAMES_OPTIONS: 'X-Frame-Options',
+ CSP: 'Content-Security-Policy',
+ CTO: 'X-Content-Type-Options',
+ XSS: 'X-XSS-Protection',
ETAG: 'ETag',
JSON_CHARSET: 'applicat... | 1 | /**
* @prettier
*/
// @flow
export const DEFAULT_PORT: string = '4873';
export const DEFAULT_PROTOCOL: string = 'http';
export const DEFAULT_DOMAIN: string = 'localhost';
export const TIME_EXPIRATION_24H: string = '24h';
export const TIME_EXPIRATION_7D: string = '7d';
export const DIST_TAGS = 'dist-tags';
export co... | 1 | 19,982 | Maybe be consistent and name it `FRAME_OPTIONS`. | verdaccio-verdaccio | js |
@@ -170,15 +170,6 @@ Blockly.Connection.prototype.connect_ = function(childConnection) {
if (!orphanBlock.outputConnection) {
throw 'Orphan block does not have an output connection.';
}
- // Attempt to reattach the orphan at the end of the newly inserted
- // block. Since this block ma... | 1 | /**
* @license
* Visual Blocks Editor
*
* Copyright 2011 Google Inc.
* https://developers.google.com/blockly/
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apach... | 1 | 7,939 | This check/exception is a guard for the next few lines of code. It shouldn't be necessary now. In fact, I don't think you need the if (parentConnection.type == Blockly.INPUT_VALUE) branch at all. | LLK-scratch-blocks | js |
@@ -72,8 +72,10 @@ class TestStringMethods(testtools.TestCase):
def test_parse_provisioning_output_failure_00(self):
res = self.molecule._parse_provisioning_output(TestStringMethods.OUTPUT_MIXED_FAILED)
+
self.assertFalse(res)
def test_parse_provisioning_output_success_00(self):
... | 1 | # Copyright (c) 2015 Cisco Systems
#
# Permission is hereby granted, free of charge, to any person obtaining a copy
# of this software and associated documentation files (the "Software"), to deal
# in the Software without restriction, including without limitation the rights
# to use, copy, modify, merge, publish, ... | 1 | 5,669 | Could probably move these constants too? | ansible-community-molecule | py |
@@ -100,9 +100,8 @@ func (cmd *Command) Start() (err error) {
case <-time.After(1 * time.Minute):
err := cmd.mysteriumClient.PingProposal(proposal, signer)
if err != nil {
- //TODO failed to refresh proposal. Stop everything?
log.Error("Failed to ping proposal", err)
- cmd.Kill()
+ // do... | 1 | package server
import (
"errors"
log "github.com/cihub/seelog"
"github.com/mysterium/node/communication"
"github.com/mysterium/node/identity"
"github.com/mysterium/node/ip"
"github.com/mysterium/node/location"
"github.com/mysterium/node/nat"
"github.com/mysterium/node/openvpn"
"github.com/mysterium/node/openv... | 1 | 10,621 | Maybe 'failed' instead of 'missing'. Also do we really need to write ticket numbers here? | mysteriumnetwork-node | go |
@@ -26,7 +26,6 @@ import org.apache.solr.common.params.SolrParams;
import org.apache.solr.request.SolrQueryRequest;
import org.apache.solr.response.transform.DocTransformer;
import org.apache.solr.response.transform.TransformerFactory;
-import org.bouncycastle.util.Strings;
import org.junit.After;
import org.junit... | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may ... | 1 | 28,379 | Test used to use old bouncycastle dependency which isn't needed anymore from Hadoop. Switched to use builtin Java split. | apache-lucene-solr | java |
@@ -193,9 +193,11 @@ class SynthDriver(SynthDriver):
voices=OrderedDict()
for v in _espeak.getVoiceList():
l=v.languages[1:]
+ # #7167: Some languages names require unicode characters EG: Norwegian Bokmål
+ name=v.name.decode("UTF-8")
# #5783: For backwards compatibility, voice identifies should alway... | 1 | # -*- coding: UTF-8 -*-
#synthDrivers/espeak.py
#A part of NonVisual Desktop Access (NVDA)
#Copyright (C) 2007-2015 NV Access Limited, Peter Vágner, Aleksey Sadovoy
#This file is covered by the GNU General Public License.
#See the file COPYING for more details.
import os
from collections import OrderedDict
im... | 1 | 19,573 | nit: I think this would be more readable as "Some language names contain Unicode characters". | nvaccess-nvda | py |
@@ -1,3 +1,9 @@
+#NVDAHelper.py
+#A part of NonVisual Desktop Access (NVDA)
+#Copyright (C) 2017-2018 NV Access Limited, Peter Vagner, Davy Kager
+#This file is covered by the GNU General Public License.
+#See the file COPYING for more details.
+
import os
import sys
import _winreg | 1 | import os
import sys
import _winreg
import msvcrt
import versionInfo
import winKernel
import config
from ctypes import *
from ctypes.wintypes import *
from comtypes import BSTR
import winUser
import eventHandler
import queueHandler
import api
import globalVars
from logHandler import log
import time
i... | 1 | 22,467 | Thanks for adding the header, but I don't think 2017 is a very accurate guess here. Could you do a quick search with git blame and change this accordingly? | nvaccess-nvda | py |
@@ -1,7 +1,6 @@
-import { createElement, createContext } from '../../';
+import { createElement, createContext } from '../../src';
import { expect } from 'chai';
-/** @jsx createElement */
/* eslint-env browser, mocha */
describe('createContext', () => { | 1 | import { createElement, createContext } from '../../';
import { expect } from 'chai';
/** @jsx createElement */
/* eslint-env browser, mocha */
describe('createContext', () => {
it('should return a Provider and a Consumer', () => {
const context = createContext();
expect(context).to.have.property('Provider');
... | 1 | 16,139 | Oh interesting - does web-test-runner not resolve package.json files? | preactjs-preact | js |
@@ -5,6 +5,7 @@
selected={startDate}
onChange={date => setStartDate(date)}
locale={fi}
+ ariaDayPrefix="Päivä"
/>
);
}; | 1 | () => {
const [startDate, setStartDate] = useState(new Date());
return (
<DatePicker
selected={startDate}
onChange={date => setStartDate(date)}
locale={fi}
/>
);
};
| 1 | 7,231 | Is there a way to derive this value from the locale itself? I feel hardcoding the prefix in the props isn't the right approach, but I'm not sure what the locale file contains exactly. | Hacker0x01-react-datepicker | js |
@@ -21,11 +21,18 @@ export function setComponentProps(component, props, opts, context, mountAll) {
if ((component.__key = props.key)) delete props.key;
if (!component.base || mountAll) {
- if (component.componentWillMount) component.componentWillMount();
+ if (component.componentWillMount) {
+ options.warn("'... | 1 | import { SYNC_RENDER, NO_RENDER, FORCE_RENDER, ASYNC_RENDER, ATTR_KEY } from '../constants';
import options from '../options';
import { extend } from '../util';
import { enqueueRender } from '../render-queue';
import { getNodeProps } from './index';
import { diff, mounts, diffLevel, flushMounts, recollectNodeTree, remo... | 1 | 11,968 | I'd much rather see these warnings in our devtools (`debug/index.js`). Strings contribute quite a bit to our file size and moving them there would prevent bloating core. | preactjs-preact | js |
@@ -96,6 +96,10 @@ public class SmartStoreInspectorActivity extends Activity implements AdapterView
private String lastAlertMessage;
private JSONArray lastResults;
+ // Default queries
+ private String SOUPS_QUERY = String.format("select %s from %s", SmartStore.SOUP_NAME_COL, SmartStore.SOUP_ATTRS_TABLE);
+ priva... | 1 | /*
* Copyright (c) 2014-present, salesforce.com, inc.
* All rights reserved.
* Redistribution and use of this software in source and binary forms, with or
* without modification, are permitted provided that the following conditions
* are met:
* - Redistributions of source code must retain the above copyright noti... | 1 | 17,057 | Use `String.format(Locale.US, ...) to avoid the `Lint` warning. | forcedotcom-SalesforceMobileSDK-Android | java |
@@ -34,9 +34,17 @@ type AppliedToGroup struct {
// PodReference represents a Pod Reference.
type PodReference struct {
- // The name of this pod.
+ // The name of this Pod.
Name string
- // The namespace of this pod.
+ // The Namespace of this Pod.
+ Namespace string
+}
+
+// ServiceReference represents reference... | 1 | // Copyright 2019 Antrea Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to ... | 1 | 32,217 | nit: ServiceReference represents a reference to a v1.Service. | antrea-io-antrea | go |
@@ -73,7 +73,7 @@ type GcpChaosSpec struct {
// The device name of the disk to detach.
// Needed in disk-loss.
// +optional
- DeviceName *string `json:"deviceName,omitempty"`
+ DeviceName *[]string `json:"deviceName,omitempty"`
}
// GcpChaosStatus represents the status of a GcpChaos | 1 | // Copyright 2021 Chaos Mesh Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agree... | 1 | 20,663 | since it changes to the array, how about change the name to `DeviceNames` | chaos-mesh-chaos-mesh | go |
@@ -41,6 +41,12 @@ const (
// top level property
ConfigTLP TopLevelProperty = "Config"
+ // RuntimeTLP is a top level property supported by CAS template engine
+ //
+ // The policy specific properties are placed with RuntimeTLP as the
+ // top level property
+ RuntimeTLP TopLevelProperty = "Runtime"
+
// Volume... | 1 | /*
Copyright 2017 The OpenEBS Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, sof... | 1 | 12,887 | Can we avoid this. upgrade engine code should take care of this. | openebs-maya | go |
@@ -36,3 +36,4 @@ ACTIVATE_SALT = 'activate'
PASSWORD_RESET_SALT = 'reset'
MAX_LINK_AGE = 60 * 60 * 24 # 24 hours
CODE_EXP_MINUTES = 10
+TOKEN_EXP_DEFAULT = {'days': 90} | 1 | # Copyright (c) 2017 Quilt Data, Inc. All rights reserved.
"""
Constants
"""
from enum import Enum
import re
PUBLIC = 'public' # This username is blocked by Quilt signup
TEAM = 'team'
VALID_NAME_RE = re.compile(r'^[a-zA-Z]\w*$')
VALID_USERNAME_RE = re.compile(r'^[a-z][a-z0-9_]*$')
VALID_EMAIL_RE = re.compile(r'^([^... | 1 | 16,862 | should also be alphabetized or at least grouped and alphabetized within group | quiltdata-quilt | py |
@@ -287,6 +287,7 @@ def _try_import_backends():
assert results.webengine_error is not None
return results
+ # pylint: enable=unused-variable
def _handle_ssl_support(fatal=False): | 1 | # vim: ft=python fileencoding=utf-8 sts=4 sw=4 et:
# Copyright 2017 Florian Bruhin (The Compiler) <mail@qutebrowser.org>
#
# This file is part of qutebrowser.
#
# qutebrowser is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Softwa... | 1 | 19,415 | No need for this, as pylint already only turns things off for this function and it's needed for the entire function. | qutebrowser-qutebrowser | py |
@@ -29,6 +29,7 @@ const (
var (
errUnmarshalBuildOpts = errors.New("can't unmarshal build field into string or compose-style map")
+ errUnmarshalCountOpts = errors.New("can't unmarshal count field into task count or auto scaling config")
)
var dockerfileDefaultName = "Dockerfile" | 1 | // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
// SPDX-License-Identifier: Apache-2.0
// Package manifest provides functionality to create Manifest files.
package manifest
import (
"errors"
"fmt"
"path/filepath"
"strconv"
"strings"
"time"
"github.com/aws/aws-sdk-go/aws"
"github.com/aws... | 1 | 14,897 | nit: can we remove "can't" from the error message? | aws-copilot-cli | go |
@@ -114,7 +114,14 @@ func NewCStorVolumeReplicaController(
q.Operation = common.QOpAdd
glog.Infof("cStorVolumeReplica Added event : %v, %v", cVR.ObjectMeta.Name, string(cVR.ObjectMeta.UID))
controller.recorder.Event(cVR, corev1.EventTypeNormal, string(common.SuccessSynced), string(common.MessageCreateSynced... | 1 | /*
Copyright 2018 The OpenEBS Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, sof... | 1 | 11,189 | instead of modifying 'Status' which impacts the state diagram, how about using some annotations on CVR? This can probably help for our upgrade as well. Is this possible? cc: @AmitKumarDas | openebs-maya | go |
@@ -38,9 +38,10 @@ const (
DefaultDownloadURL = "https://download.docker.com"
DockerPreqReqList = "apt-transport-https ca-certificates curl gnupg-agent software-properties-common"
- KubernetesDownloadURL = "https://apt.kubernetes.io/"
- KubernetesGPGURL = "https://packages.cloud.google.com/apt/doc/apt-key.g... | 1 | /*
Copyright 2019 The Kubeedge Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, so... | 1 | 11,939 | Rename this as KubernetesGPGURL - >KubernetesUbuntuGPGURL , Modify it where ever it is used. | kubeedge-kubeedge | go |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.