patch stringlengths 17 31.2k | y int64 1 1 | oldf stringlengths 0 2.21M | idx int64 1 1 | id int64 4.29k 68.4k | msg stringlengths 8 843 | proj stringclasses 212
values | lang stringclasses 9
values |
|---|---|---|---|---|---|---|---|
@@ -243,12 +243,12 @@ public class SmartStoreLoadTest extends InstrumentationTestCase {
// Without indexing for new index specs
alterSoup("Adding one index / no re-indexing", false, new IndexSpec[]{new IndexSpec("k_0", indexType), new IndexSpec("k_1", indexType)});
alterSoup("Adding one index... | 1 | /*
* Copyright (c) 2011-present, salesforce.com, inc.
* All rights reserved.
* Redistribution and use of this software in source and binary forms, with or
* without modification, are permitted provided that the following conditions
* are met:
* - Redistributions of source code must retain the above copyright noti... | 1 | 15,246 | That way we are back to having just one index on k_0 So we can really compare the execution times with and without re-indexing | forcedotcom-SalesforceMobileSDK-Android | java |
@@ -52,6 +52,13 @@ public class AttachmentView extends FrameLayout {
public String contentType;
public long size;
public ImageView iconView;
+
+ /**
+ * Regular expression that represents characters that aren't allowed
+ * to be used in file names saved using K-9
+ */
+ private stat... | 1 | package com.fsck.k9.view;
import java.io.File;
import java.io.FileOutputStream;
import java.io.IOException;
import java.io.InputStream;
import java.io.OutputStream;
import org.apache.commons.io.IOUtils;
import android.content.Context;
import android.content.Intent;
import android.content.pm.PackageManager;
import an... | 1 | 11,659 | Expression that uses a negation pattern to exclude all characters that aren't in the expression. | k9mail-k-9 | java |
@@ -82,6 +82,10 @@ const (
// feature is supported on the server. If any non-empty value is set,
// this indicates true.
BothResponseErrorHeader = "Rpc-Both-Response-Error"
+
+ // Echo ServiceHeader in Request header which can be used by clients/HC to
+ // validate request went to the correct service
+ RespondSer... | 1 | // Copyright (c) 2018 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge... | 1 | 16,752 | Similar to my suggestion for HTTP, let's remove this and use `ServiceHeader` instead. | yarpc-yarpc-go | go |
@@ -135,7 +135,7 @@ func addCustomCommands(rootCmd *cobra.Command) error {
}
descSuffix := " (shell " + service + " container command)"
- if serviceDirOnHost[0:1] == "." {
+ if commandSet == targetGlobalCommandPath {
descSuffix = " (global shell " + service + " container command)"
}
co... | 1 | package cmd
import (
"bufio"
"fmt"
"github.com/drud/ddev/pkg/ddevapp"
"github.com/drud/ddev/pkg/exec"
"github.com/drud/ddev/pkg/fileutil"
"github.com/drud/ddev/pkg/globalconfig"
"github.com/drud/ddev/pkg/util"
"github.com/gobuffalo/packr/v2"
"github.com/mattn/go-isatty"
"github.com/spf13/cobra"
"io/ioutil"
... | 1 | 14,672 | The serviceDirOnHost[0:1] was completely wrong. It wasn't just Windows, glad you got this fixed! | drud-ddev | php |
@@ -38,7 +38,7 @@ import (
controllerconfig "antrea.io/antrea/pkg/config/controller"
)
-const waitEgressRealizedTimeout = 3 * time.Second
+const waitEgressRealizedTimeout = 15 * time.Second
func TestEgress(t *testing.T) {
skipIfProviderIs(t, "kind", "pkt_mark field is not properly supported for OVS userspace ... | 1 | // Copyright 2021 Antrea Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to ... | 1 | 50,935 | Would membership take 10+ seconds to detect the failed node? | antrea-io-antrea | go |
@@ -227,11 +227,14 @@ def _sanitize_markdown(mdtext):
def _load_introduction(path):
"Loads the introduction text from a Markdown file"
+ if not os.path.exists(path):
+ return None
+
try:
with open(path) as f:
return _sanitize_markdown(f.read())
- except:
- return N... | 1 | import collections
from pathlib import Path
import os
import bleach
from librelingo_types import (
Course,
DictionaryItem,
Language,
License,
Module,
Phrase,
Skill,
Word,
Settings,
AudioSettings,
TextToSpeechSettings,
)
import markdown
from yaml import safe_load
from yaml.co... | 1 | 11,449 | hmm, in this case perhaps the whole try-except could be removed altogether? because if the file does not exist, it's already returning `None`. In any other case it should actually probably fail with the exception, no? | kantord-LibreLingo | py |
@@ -0,0 +1,14 @@
+package cmd
+
+import (
+ "github.com/mitchellh/go-homedir"
+ "path/filepath"
+)
+
+func GetDirectory(paths ...string) string {
+ dir, _ := homedir.Dir()
+
+ dir = filepath.Join(dir, ".mysterium", filepath.Join(paths...))
+
+ return dir
+} | 1 | 1 | 9,577 | This function does not need to be public | mysteriumnetwork-node | go | |
@@ -60,14 +60,14 @@ export default function SetupForm( { finishSetup } ) {
>
<ErrorNotice />
+ <ExistingTagNotice />
+
{ ( !! accounts.length && ! hasExistingTag ) && (
- <p>
+ <p style={ { marginBottom: 0 } }>
{ __( 'Please select the account information below. You can change this view later... | 1 | /**
* Analytics Setup form.
*
* Site Kit by Google, Copyright 2020 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
... | 1 | 28,441 | Any chance we can get a CSS class for this? I know it's just in one place but feels like a dangerous precedent to set. | google-site-kit-wp | js |
@@ -119,7 +119,7 @@ namespace AutoRest.Ruby.Azure.TemplateModels
if (ReturnType.Body is CompositeType)
{
CompositeType compositeType = (CompositeType)ReturnType.Body;
- if (compositeType.Extensions.ContainsKey(AzureExtensions.PageableExtension))
... | 1 | // Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for license information.
using System;
using System.Collections.Generic;
using System.Globalization;
using System.Linq;
using System.Net;
using System.Text;
using AutoRest.Core.ClientMod... | 1 | 22,670 | > && this.Extensions.ContainsKey("nextMethodName") [](start = 96, length = 48) From line 124, looks like we don't need `&& this.Extensions.ContainsKey("nextMethodName")` condition or we don't need line 124 #Closed | Azure-autorest | java |
@@ -1,16 +1,5 @@
-import { options } from 'preact';
import { assign } from './util';
-let oldVNodeHook = options.vnode;
-options.vnode = vnode => {
- if (vnode.type && vnode.type._forwarded && vnode.ref) {
- vnode.props.ref = vnode.ref;
- vnode.ref = null;
- }
-
- if (oldVNodeHook) oldVNodeHook(vnode);
-};
-
/**
... | 1 | import { options } from 'preact';
import { assign } from './util';
let oldVNodeHook = options.vnode;
options.vnode = vnode => {
if (vnode.type && vnode.type._forwarded && vnode.ref) {
vnode.props.ref = vnode.ref;
vnode.ref = null;
}
if (oldVNodeHook) oldVNodeHook(vnode);
};
/**
* Pass ref down to a child. Th... | 1 | 14,775 | Moving this code from compat to core shaves 47 bytes out of compat and only adds 6 bytes to core so I thought it was worth it. | preactjs-preact | js |
@@ -52,11 +52,11 @@ namespace NLog.LayoutRenderers
private readonly string _baseDir;
#if !SILVERLIGHT && !NETSTANDARD1_3
-
/// <summary>
/// cached
/// </summary>
private string _processDir;
+#endif
/// <summary>
/// Use base dir of current process. | 1 | //
// Copyright (c) 2004-2019 Jaroslaw Kowalski <jaak@jkowalski.net>, Kim Christensen, Julian Verdurmen
//
// All rights reserved.
//
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions
// are met:
//
// * Redistributions of s... | 1 | 20,102 | Please use ".NET Core 3" - i'm trying hard to use one form, and this is the one MS advices | NLog-NLog | .cs |
@@ -87,6 +87,11 @@ func StartSession(params *TelemetrySessionParams, statsEngine stats.Engine) erro
seelog.Errorf("Error: lost websocket connection with ECS Telemetry service (TCS): %v", tcsError)
params.time().Sleep(backoff.Duration())
}
+ select {
+ case <-params.Ctx.Done():
+ return nil
+ default:
+ ... | 1 | // Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License"). You may
// not use this file except in compliance with the License. A copy of the
// License is located at
//
// http://aws.amazon.com/apache2.0/
//
// or in the "license" file acco... | 1 | 24,330 | Unrelated to this change, but this is a fix for when TestDoStartCgroupInitHappyPath has a failure after the test goroutine has already exited. | aws-amazon-ecs-agent | go |
@@ -29,6 +29,7 @@ import qutebrowser
from qutebrowser.utils import docutils
from qutebrowser.browser import pdfjs
+from end2end.features.test_scroll_bdd import check_scrolled, check_not_scrolled
bdd.scenarios('misc.feature')
| 1 | # vim: ft=python fileencoding=utf-8 sts=4 sw=4 et:
# Copyright 2015-2016 Florian Bruhin (The Compiler) <mail@qutebrowser.org>
#
# This file is part of qutebrowser.
#
# qutebrowser is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free S... | 1 | 15,026 | Hmm, I'd really expect this to work, and yet it doesn't. I'll investigate later, though it might get Monday until I get the time. | qutebrowser-qutebrowser | py |
@@ -356,7 +356,7 @@ TEST(svm_thunder_dense_test, can_classify_any_two_labels) {
auto support_indices_table = result_train.get_support_indices();
const auto support_indices = row_accessor<const float>(support_indices_table).pull();
- for (size_t i = 0; i < support_indices.get_count(); i++) {
+... | 1 | /*******************************************************************************
* Copyright 2020 Intel Corporation
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.o... | 1 | 24,326 | Does this changes affect process building dynamic libraries anyhow? | oneapi-src-oneDAL | cpp |
@@ -26,7 +26,7 @@ import struct
import time
from scapy.packet import *
from scapy.fields import *
-from scapy.contrib.ppi import PPIGenericFldHdr, addPPIType
+from scapy.layers.dot11 import *
from scapy.error import warning
import scapy.modules.six as six
from scapy.modules.six.moves import range | 1 | # This file is part of Scapy
# Scapy is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 2 of the License, or
# any later version.
#
# Scapy is distributed in the hope that it will be useful,
# but ... | 1 | 13,185 | Could you limit what is imported here? | secdev-scapy | py |
@@ -1078,12 +1078,15 @@ def do_set_function_code(lambda_function: LambdaFunction):
if not lambda_cwd:
return
- # get local lambda working directory
+ # get local lambda code archive path
tmp_file = os.path.join(lambda_cwd, LAMBDA_ZIP_FILE_NAME)
if not zip_file_content:
zip_fil... | 1 | import base64
import functools
import hashlib
import importlib.machinery
import json
import logging
import os
import re
import sys
import threading
import time
import traceback
import uuid
from datetime import datetime
from io import BytesIO
from threading import BoundedSemaphore
from typing import Any, Dict, List
fro... | 1 | 13,168 | just to clarify - on line 1074 we update `zip_file_content` for non-local lambdas, but never store it, which means lambda never picks it up | localstack-localstack | py |
@@ -170,10 +170,18 @@ func udpPkt(src, dst string) packet {
func icmpPkt(src, dst string) packet {
return packetWithPorts(1, src+":0", dst+":0")
}
+func icmpPkt_with_type_code(src, dst string, icmpType, icmpCode int) packet {
+ return packet{
+ protocol: 1,
+ srcAddr: src,
+ srcPort: 0,
+ dstAddr: dst,
+ ds... | 1 | // Copyright (c) 2020 Tigera, Inc. All rights reserved.
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applica... | 1 | 17,658 | Golang naming convention is to use camel case `icmpPktWithTypeCode` Often the linter will complain | projectcalico-felix | go |
@@ -127,11 +127,7 @@ namespace OpenTelemetry.Exporter.Zipkin
{
using (var response = await client.SendAsync(request).ConfigureAwait(false))
{
- if (response.StatusCode != HttpStatusCode.OK &&
- response.StatusCode != HttpStatusCode.Accepted)
- ... | 1 | // <copyright file="ZipkinTraceExporter.cs" company="OpenTelemetry Authors">
// Copyright 2018, OpenTelemetry Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www... | 1 | 13,220 | We can do away with assigning the response here too. | open-telemetry-opentelemetry-dotnet | .cs |
@@ -18,7 +18,7 @@ function ngGridFlexibleHeightPlugin (opts) {
}
}
- var newViewportHeight = naturalHeight + 2;
+ var newViewportHeight = naturalHeight + 3;
if (!self.scope.baseViewportHeight || self.scope.baseViewportHeight !== newViewportHeight) {
... | 1 | function ngGridFlexibleHeightPlugin (opts) {
var self = this;
self.grid = null;
self.scope = null;
self.init = function (scope, grid, services) {
self.domUtilityService = services.DomUtilityService;
self.grid = grid;
self.scope = scope;
var recalcHeightForData = function ... | 1 | 9,862 | Bumping the newViewportHeight | angular-ui-ui-grid | js |
@@ -47,7 +47,7 @@ import org.apache.solr.util.LongIterator;
* <li><a href="https://github.com/aggregateknowledge/postgresql-hll">postgresql-hll</a>, and</li>
* <li><a href="https://github.com/aggregateknowledge/js-hll">js-hll</a></li>
* </ul>
- * when <a href="https://github.com/aggregateknowledge/postgresql-... | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may ... | 1 | 35,955 | Is this change correct? Looks like a typo and not sure this should be changed? | apache-lucene-solr | java |
@@ -43,6 +43,14 @@ def _read_stdin():
return sys.stdin.read()
+def _load_reporter_by_class(reporter_class: str) -> type:
+ qname = reporter_class
+ module_part = astroid.modutils.get_module_part(qname)
+ module = astroid.modutils.load_module_from_name(module_part)
+ class_name = qname.split(".")[-1... | 1 | # Licensed under the GPL: https://www.gnu.org/licenses/old-licenses/gpl-2.0.html
# For details: https://github.com/PyCQA/pylint/blob/master/LICENSE
import collections
import contextlib
import functools
import operator
import os
import sys
import tokenize
import traceback
import warnings
from io import TextIOWrapper
i... | 1 | 14,034 | I checked the tests coverage and strangely it look like those three lines are not covered (?!). Do you have the same result on your side ? | PyCQA-pylint | py |
@@ -35,4 +35,4 @@ namespace System.MathBenchmarks
}
}
}
-}
+} | 1 | // Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.
using System;
using BenchmarkDotNet.Attributes;
namespace System.MathBenchmarks
{
public partial class Double
... | 1 | 10,955 | nit: please try to avoid changing end of the file (it adds a noise to the code review, but does not provide too much value) | dotnet-performance | .cs |
@@ -57,9 +57,16 @@ namespace AutoRest.Swagger.Model.Utilities
.Where(modelName => !(IsBaseResourceModelName(modelName))
&& serviceDefinition.Definitions.ContainsKey(modelName)
... | 1 | // Copyright (c) Microsoft Corporation. All rights reserved.
// Licensed under the MIT License. See License.txt in the project root for license information.
using AutoRest.Swagger;
using AutoRest.Core.Utilities;
using System.Collections.Generic;
using System.Linq;
using System.Text.RegularExpressions;
using AutoRest.... | 1 | 25,168 | I don't see the "only" part reflected in the code but maybe I'm missing it. Also, the indentation is misleading: the `.SelectMany` calls are perfectly aligned but are *not* operating on the same "level". I'd expect the second `SelectMany` to be on the same height as the inner `Where`, just break `pathObj => pathObj<HER... | Azure-autorest | java |
@@ -20,7 +20,8 @@ Puppet::DataTypes.create_type('Target') do
vars => { type => Optional[Hash[String[1], Data]], kind => given_or_derived },
facts => { type => Optional[Hash[String[1], Data]], kind => given_or_derived },
features => { type => Optional[Array[String[1]]], kind => given_or_derived },
-... | 1 | # frozen_string_literal: true
Puppet::DataTypes.create_type('Target') do
begin
inventory = Puppet.lookup(:bolt_inventory)
target_implementation_class = inventory.target_implementation_class
rescue Puppet::Context::UndefinedBindingError
target_implementation_class = Bolt::Target
end
require 'bolt/t... | 1 | 14,599 | It seems like most of these will never be nil, are they optional just in case? | puppetlabs-bolt | rb |
@@ -88,7 +88,7 @@ public class TableCodecTest {
try {
byte[] bytes = TableCodec.encodeRow(tblInfo.getColumns(), values, tblInfo.isPkHandle());
// testing the correctness via decodeRow
- Row row = TableCodec.decodeRow(bytes, tblInfo.getColumns());
+ Row row = TableCodec.decodeRow(b... | 1 | package com.pingcap.tikv.codec;
import static org.junit.Assert.*;
import com.google.common.collect.ImmutableList;
import com.pingcap.tikv.meta.MetaUtils;
import com.pingcap.tikv.meta.TiColumnInfo;
import com.pingcap.tikv.meta.TiTableInfo;
import com.pingcap.tikv.row.Row;
import com.pingcap.tikv.types.IntegerType;
imp... | 1 | 10,240 | `.addColumn("c1", IntegerType.INT, true)` means `PkHandle=true`, maybe should add `.setPkHandle(true)` in line 31 | pingcap-tispark | java |
@@ -56,8 +56,10 @@ public class RowKey extends Key implements Serializable {
Object obj = handle.getValue();
if (obj instanceof Long) {
return new RowKey(tableId, (long) obj);
+ } else if (obj instanceof Integer) {
+ return new RowKey(tableId, ((Integer) obj).longValue());
}
- throw new... | 1 | /*
* Copyright 2017 PingCAP, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed ... | 1 | 11,353 | how about `Cannot encode row key with non-integer type` directly? | pingcap-tispark | java |
@@ -42,6 +42,9 @@ public interface ExecutorLoader {
Map<Integer, Pair<ExecutionReference, ExecutableFlow>> fetchUnfinishedFlows()
throws ExecutorManagerException;
+ Map<Integer, Pair<ExecutionReference, ExecutableFlow>> fetchUnfinishedExecutions()
+ throws ExecutorManagerException;
+
Pair<Execution... | 1 | /*
* Copyright 2012 LinkedIn Corp.
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not
* use this file except in compliance with the License. You may obtain a copy of
* the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to i... | 1 | 17,108 | The method names `fetchUnfinishedExecutions` and `fetchUnfinishedFlows` are too similar to each other. Would it be better to use the name `fetchUnfinishedFlowsMetadata` since you are only fetching metadata info about the flow? | azkaban-azkaban | java |
@@ -26,6 +26,17 @@ module Travis
sh.cmd "wget -q -O tmate.tar.xz #{static_build_linux_url}", echo: false, retry: true
sh.cmd "tar --strip-components=1 -xf tmate.tar.xz", echo: false
end
+ sh.elif "$(uname) = 'FreeBSD'" do
+ sh.cmd 'sudo pkg in... | 1 | require 'shellwords'
require 'travis/build/appliances/base'
require 'travis/build/helpers/template'
module Travis
module Build
module Appliances
class DebugTools < Base
include Template
TEMPLATES_PATH = File.expand_path('templates', __FILE__.sub('.rb', ''))
def_delegators :script, ... | 1 | 17,504 | Note that `sudo` is not available by default on BSDs; there are a few places in the codebase here where that's explicitly worked around by using `su`. | travis-ci-travis-build | rb |
@@ -0,0 +1,5 @@
+// Package importpath is used to implement a test on Go import paths.
+package importpath
+
+// Answer is the answer to Life, the Universe and Everything.
+const Answer = 42 | 1 | 1 | 8,037 | ultra nit: missing Oxford comma :P | thought-machine-please | go | |
@@ -729,6 +729,16 @@ class SparkFrameMethods(object):
== Physical Plan ==
...
+ >>> df.spark.explain("extended") # doctest: +SKIP
+ == Parsed Logical Plan ==
+ ...
+ == Analyzed Logical Plan ==
+ ...
+ == Optimized Logical Plan ==
+ ...
+ == P... | 1 | #
# Copyright (C) 2019 Databricks, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to i... | 1 | 15,449 | This is not supported in Spark 3.0.0-rc2 yet. I'd skip this for now. | databricks-koalas | py |
@@ -13,5 +13,6 @@ import (
// like sending and awaiting mined ones.
type Message interface {
Send(ctx context.Context, from, to types.Address, val *types.AttoFIL, method string, params ...interface{}) (*cid.Cid, error)
+ Query(ctx context.Context, from, to types.Address, method string, params ...interface{}) ([][]b... | 1 | package api
import (
"context"
"gx/ipfs/QmYVNvtQkeZ6AKSwDrjQTs432QtL6umrrK41EBq3cu7iSP/go-cid"
"github.com/filecoin-project/go-filecoin/exec"
"github.com/filecoin-project/go-filecoin/types"
)
// Message is the interface that defines methods to manage various message operations,
// like sending and awaiting mine... | 1 | 13,717 | BLOCKING: Why does `Query` return an `*exec.FunctionSignature`? | filecoin-project-venus | go |
@@ -562,14 +562,14 @@ func (c *ConfigLocal) MaxDirBytes() uint64 {
return c.maxDirBytes
}
-// ResetCaches implements the Config interface for ConfigLocal.
-func (c *ConfigLocal) ResetCaches() {
+func (c *ConfigLocal) resetCachesWithoutShutdown() DirtyBlockCache {
c.lock.Lock()
defer c.lock.Unlock()
c.mdcache... | 1 | // Copyright 2016 Keybase Inc. All rights reserved.
// Use of this source code is governed by a BSD
// license that can be found in the LICENSE file.
package libkbfs
import (
"fmt"
"sync"
"time"
"github.com/keybase/client/go/libkb"
"github.com/keybase/client/go/logger"
keybase1 "github.com/keybase/client/go/pr... | 1 | 11,803 | please move this down to immediately above the assignment to `c.dirtyBcache` | keybase-kbfs | go |
@@ -63,3 +63,19 @@ func Example() {
// Output:
// foo.com running on port 80
}
+
+func Example_openVariable() {
+ // OpenVariable creates a *runtimevar.Variable from a URL.
+ // This example watches a variable based on a file-based blob.Bucket with JSON.
+ ctx := context.Background()
+ v, err := runtimevar.OpenVar... | 1 | // Copyright 2019 The Go Cloud Development Kit Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// https://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by appli... | 1 | 15,146 | Don't need the `, err` part since you've already handled it. | google-go-cloud | go |
@@ -222,4 +222,18 @@ TEST_CASE("negative charge queries. Part of testing changes for github #2604",
CHECK(nWarnings == 1);
CHECK(nErrors == 0);
}
+}
+
+TEST_CASE("GithHub #2954: Reaction Smarts with Dative Bonds not parsed",
+ "[Reaction, Bug]") {
+
+ SECTION("Rxn Smart Processing with Dative B... | 1 | //
// Copyright (c) 2018 Greg Landrum
//
// @@ All Rights Reserved @@
// This file is part of the RDKit.
// The contents are covered by the terms of the BSD license
// which is included in the file license.txt, found at the root
// of the RDKit source tree.
///
#define CATCH_CONFIG_MAIN // This tells Catch to p... | 1 | 20,752 | Please add two additional SECTIONs that show that this also works if the dative bond is in the reactant (reaction SMARTS `[O:1]->[H+]>>[O:1].[H+]`) or in the agents (reaction SMARTS `[O:1][H]>N->[Cu]>[O:1].[H]`) | rdkit-rdkit | cpp |
@@ -54,6 +54,15 @@ func (c *Cluster) newListener(ctx context.Context) (net.Listener, http.Handler,
MinVersion: c.config.TLSMinVersion,
CipherSuites: c.config.TLSCipherSuites,
},
+ RegenerateCerts: func() bool {
+ const regenerateDynamicListenerFile = "dynamic-cert-regenerate"
+ dynamicListenerRegenFil... | 1 | package cluster
import (
"context"
"crypto/tls"
"errors"
"io/ioutil"
"log"
"net"
"net/http"
"os"
"path/filepath"
"github.com/rancher/dynamiclistener"
"github.com/rancher/dynamiclistener/factory"
"github.com/rancher/dynamiclistener/storage/file"
"github.com/rancher/dynamiclistener/storage/kubernetes"
"gi... | 1 | 10,602 | What happens if the certificate rotation fails and we are prematurely removing this file? | k3s-io-k3s | go |
@@ -97,6 +97,18 @@ func (s *Single) IsRunning() bool {
// Introspect returns a ChooserStatus with a single PeerStatus.
func (s *Single) Introspect() introspection.ChooserStatus {
+ if !s.once.IsRunning() {
+ return introspection.ChooserStatus{
+ Name: "Single",
+ Peers: []introspection.PeerStatus{
+ {
+ ... | 1 | // Copyright (c) 2017 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge... | 1 | 14,025 | does this change belong here? | yarpc-yarpc-go | go |
@@ -291,6 +291,8 @@ func (w *Workflow) populate() error {
"DATETIME": now.Format("20060102150405"),
"TIMESTAMP": strconv.FormatInt(now.Unix(), 10),
"USERNAME": w.username,
+ "WFDIR": w.workflowDir,
+ "CWD": os.Getwd(),
}
var replacements []string | 1 | // Copyright 2017 Google Inc. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by appl... | 1 | 6,510 | This returns an error | GoogleCloudPlatform-compute-image-tools | go |
@@ -131,6 +131,8 @@ type Config struct {
Ipv6Support bool `config:"bool;true"`
IgnoreLooseRPF bool `config:"bool;false"`
+ // FIXME Add this to libcalico-go
+ IptablesBackend string `config:"oneof(legacy,nft);legacy;local"`
RouteRefreshInterval time.Duration `config:"s... | 1 | // Copyright (c) 2016-2019 Tigera, Inc. All rights reserved.
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by ap... | 1 | 17,009 | If we think we might someday write a native nftables backend, do you think it would make sense to just use generic dataplane configuration? e.g, `dataplane = iptables | ebpf | nftables`, but for now selecting `nftables` uses iptables in nft compat mode? | projectcalico-felix | go |
@@ -53,7 +53,10 @@ func TestBlockPropsManyNodes(t *testing.T) {
connect(t, nodes[1], nodes[2])
connect(t, nodes[2], nodes[3])
- baseTS := minerNode.ChainReader.Head()
+ head := minerNode.ChainReader.GetHead()
+ headTipSetAndState, err := minerNode.ChainReader.GetTipSetAndState(ctx, head)
+ require.NoError(err)
+ ... | 1 | package node
import (
"context"
"testing"
"time"
"github.com/libp2p/go-libp2p-peerstore"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"github.com/filecoin-project/go-filecoin/address"
"github.com/filecoin-project/go-filecoin/protocol/storage"
"github.com/filecoin-project/go-fil... | 1 | 18,239 | Looks like that helper function is general enough that it should reside in testhelpers | filecoin-project-venus | go |
@@ -456,6 +456,11 @@ func writeDrupal6DdevSettingsFile(settings *DrupalSettings, filePath string) err
// WriteDrushrc writes out drushrc.php based on passed-in values.
// This works on Drupal 6 and Drupal 7 or with drush8 and older
func WriteDrushrc(app *DdevApp, filePath string) error {
+ // Ignore because this is ... | 1 | package ddevapp
import (
"fmt"
"github.com/drud/ddev/pkg/dockerutil"
"github.com/drud/ddev/pkg/nodeps"
"github.com/gobuffalo/packr/v2"
"github.com/drud/ddev/pkg/output"
"github.com/drud/ddev/pkg/util"
"io/ioutil"
"os"
"path"
"path/filepath"
"text/template"
"github.com/drud/ddev/pkg/fileutil"
"github.c... | 1 | 14,956 | This isn't incorrect IMO, but I think it would be better to fix this in drupal7PostStartAction and also in drupal6PostStartAction. It seems to me like those were both somehow neglected on this. Use drupal8PostStartAction as example. Congrats on your first golang PR! Please make sure to test it manually. | drud-ddev | go |
@@ -10,8 +10,10 @@ test_name 'use the provision subcommand' do
delete_root_folder_contents
on(default, 'beaker init')
result = on(default, 'beaker provision --hosts centos6-64')
+ assert_match(/ERROR/, result.raw_output)
+ on(default, 'beaker init --hosts centos6-64')
+ result = on(default, 'bea... | 1 | test_name 'use the provision subcommand' do
SubcommandUtil = Beaker::Subcommands::SubcommandUtil
def delete_root_folder_contents
on default, 'rm -rf /root/* /root/.beaker'
end
step 'run beaker init and provision' do
delete_root_folder_contents
on(default, 'beaker init')
result = on(default, '... | 1 | 15,058 | I'd like to ensure that the error message at least has some reference to the flag that is not allowed. Something like `/ERROR(.+)--hosts/` would work. | voxpupuli-beaker | rb |
@@ -470,8 +470,8 @@ https://aws.amazon.com/premiumsupport/knowledge-center/ecs-pull-container-api-er
publicSubnets, err := o.selVPC.PublicSubnets(envInitPublicSubnetsSelectPrompt, "", o.importVPC.ID)
if err != nil {
if err == selector.ErrSubnetsNotFound {
- log.Warningf(`No existing public subnets were fou... | 1 | // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
// SPDX-License-Identifier: Apache-2.0
package cli
import (
"errors"
"fmt"
"net"
"os"
"strings"
"github.com/aws/aws-sdk-go/aws"
"github.com/aws/aws-sdk-go/aws/session"
"github.com/aws/copilot-cli/internal/pkg/aws/cloudformation"
"github.c... | 1 | 18,017 | Should we say "specifying two public subnets"? | aws-copilot-cli | go |
@@ -32,6 +32,8 @@ func (current *PubSubSource) CheckImmutableFields(ctx context.Context, og apis.I
return nil
}
+ // TODO: revisit this.
+
// All of the fields are immutable because the controller doesn't understand when it would need
// to delete and create a new Receive Adapter with updated arguments. We c... | 1 | /*
Copyright 2019 Google LLC
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
dist... | 1 | 7,990 | Issue number? When? Why? | google-knative-gcp | go |
@@ -35,6 +35,7 @@ from ._sapi4 import (
VOICECHARSET
)
import config
+import speech
import nvwave
import weakref
| 1 | #synthDrivers/sapi4.py
#A part of NonVisual Desktop Access (NVDA)
# Copyright (C) 2006-2020 NV Access Limited
#This file is covered by the GNU General Public License.
#See the file COPYING for more details.
import locale
from collections import OrderedDict
import winreg
from comtypes import CoCreateInstance, ... | 1 | 32,523 | You should not rely on `PitchCommand` being imported into speech. Please import it from `speech.commands`. | nvaccess-nvda | py |
@@ -108,7 +108,7 @@ public abstract class BaseTestIceberg {
newCatalog.setConf(hadoopConfig);
newCatalog.initialize("nessie", ImmutableMap.of("ref", ref,
CatalogProperties.URI, uri,
- "auth_type", "NONE",
+ "auth-type", "NONE",
CatalogProperties.WAREHOUSE_LOCATION, temp.toUri()... | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you ... | 1 | 39,296 | Is this a constant used in the Nessie project itself? If so, perhaps you might consider a follow up for adding `NessieCatalogProperties` class at some point, to help make them more clear to users looking to adopt Nessie coming from the Iceberg repo itself | apache-iceberg | java |
@@ -146,12 +146,12 @@ func (db *taskQueueDB) CreateTasks(tasks []*persistencespb.AllocatedTaskInfo) (*
// GetTasks returns a batch of tasks between the given range
func (db *taskQueueDB) GetTasks(minTaskID int64, maxTaskID int64, batchSize int) (*persistence.GetTasksResponse, error) {
return db.store.GetTasks(&pers... | 1 | // The MIT License
//
// Copyright (c) 2020 Temporal Technologies Inc. All rights reserved.
//
// Copyright (c) 2020 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Soft... | 1 | 13,559 | maybe we should rename: MinTaskID -> MinTaskIDExclusive, MaxTaskID -> MaxTaskIDInclusive, | temporalio-temporal | go |
@@ -70,7 +70,7 @@ const (
NvidiaVisibleDevicesEnvVar = "NVIDIA_VISIBLE_DEVICES"
GPUAssociationType = "gpu"
- NvidiaRuntime = "nvidia"
+ NvidiaRuntime = "ecs-nvidia"
arnResourceSections = 2
arnResourceDelimiter = "/" | 1 | // Copyright 2014-2018 Amazon.com, Inc. or its affiliates. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License"). You may
// not use this file except in compliance with the License. A copy of the
// License is located at
//
// http://aws.amazon.com/apache2.0/
//
// or in the "license... | 1 | 21,661 | You may need to make this configurable if we expect people to be able to use the normal Nvidia runtime on other Linux distributions like Ubuntu or Debian. | aws-amazon-ecs-agent | go |
@@ -177,10 +177,10 @@ func newLeafNodeCfg(remote *RemoteLeafOpts) *leafNodeCfg {
if len(remote.DenyExports) > 0 || len(remote.DenyImports) > 0 {
perms := &Permissions{}
if len(remote.DenyExports) > 0 {
- perms.Subscribe = &SubjectPermission{Deny: remote.DenyExports}
+ perms.Publish = &SubjectPermission{Deny... | 1 | // Copyright 2019-2020 The NATS Authors
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to ... | 1 | 10,945 | Originally the DenyExport was a subscribe permission because it meant that if on this LN connection, if we deny export of "foo" it means that it would reject a subscription (hence subscribe permission) on "foo" from the other side. Now you are changing to simply not allowing this server to publish on "foo". I am not sa... | nats-io-nats-server | go |
@@ -159,6 +159,12 @@ dsts_first(void)
return TESTANY(DR_DISASM_INTEL | DR_DISASM_ARM, DYNAMO_OPTION(disasm_mask));
}
+static inline bool
+opmask_with_dsts(void)
+{
+ return TESTANY(DR_DISASM_INTEL | DR_DISASM_ATT, DYNAMO_OPTION(disasm_mask));
+}
+
static void
internal_instr_disassemble(char *buf, size_t bu... | 1 | /* **********************************************************
* Copyright (c) 2011-2019 Google, Inc. All rights reserved.
* Copyright (c) 2001-2009 VMware, Inc. All rights reserved.
* **********************************************************/
/*
* Redistribution and use in source and binary forms, with or witho... | 1 | 17,034 | > k1 src0 src2 -> dst s/src2/src1/ nit: k1 is actually src0 according to instr_get_src(instr, 0) which makes this a little confusing | DynamoRIO-dynamorio | c |
@@ -192,7 +192,7 @@ func (kc *KMDController) StartKMD(args KMDStartArgs) (alreadyRunning bool, err e
return false, errors.New("bad kmd data dir")
}
if (dataDirStat.Mode() & 0077) != 0 {
- logging.Base().Errorf("%s: kmd data dir exists but is too permissive (%o)", kc.kmdDataDir, dataDirStat.Mode()&0777)
+ ... | 1 | // Copyright (C) 2019-2020 Algorand, Inc.
// This file is part of go-algorand
//
// go-algorand is free software: you can redistribute it and/or modify
// it under the terms of the GNU Affero General Public License as
// published by the Free Software Foundation, either version 3 of the
// License, or (at your option) ... | 1 | 41,285 | I believe that you meant to have the following on the second one, right ? `dataDirStat.Mode()^0077` | algorand-go-algorand | go |
@@ -386,8 +386,8 @@ func (s *stream) SetDeadline(t time.Time) error {
}
// CloseRemote makes the stream receive a "virtual" FIN stream frame at a given offset
-func (s *stream) CloseRemote(offset protocol.ByteCount) {
- s.AddStreamFrame(&wire.StreamFrame{FinBit: true, Offset: offset})
+func (s *stream) CloseRemote(... | 1 | package quic
import (
"context"
"fmt"
"io"
"net"
"sync"
"time"
"github.com/lucas-clemente/quic-go/internal/flowcontrol"
"github.com/lucas-clemente/quic-go/internal/protocol"
"github.com/lucas-clemente/quic-go/internal/utils"
"github.com/lucas-clemente/quic-go/internal/wire"
)
type streamI interface {
Stre... | 1 | 7,067 | The reason a `ByteCount` is used here, is that the H2 mapping in gQUIC requires this layer violation, which is why `CloseRemote` is not part of the public API. This layer violation will be resolved in IETF QUIC | lucas-clemente-quic-go | go |
@@ -260,6 +260,17 @@ bool IsDetrimentalSpell(uint16 spell_id)
return !IsBeneficialSpell(spell_id);
}
+bool IsInvisSpell(uint16 spell_id)
+{
+ if (IsEffectInSpell(spell_id, SE_Invisibility) ||
+ IsEffectInSpell(spell_id, SE_Invisibility2) ||
+ IsEffectInSpell(spell_id, SE_InvisVsUndead) ||
+ IsEffectInSpell(spel... | 1 | /* EQEMu: Everquest Server Emulator
Copyright (C) 2001-2002 EQEMu Development Team (http://eqemu.org)
This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; version 2 of the License.
This program is d... | 1 | 10,604 | I dig the helper function! | EQEmu-Server | cpp |
@@ -0,0 +1,2 @@
+// package samples contains sample programs using the pubsub API.
+package samples | 1 | 1 | 13,279 | Please add the Copyright header. | google-go-cloud | go | |
@@ -37,6 +37,7 @@ import sys
import tempfile
import luigi
+from ..target import FileSystemTarget
logger = logging.getLogger('luigi-interface')
| 1 | # -*- coding: utf-8 -*-
#
# Copyright 2012-2016 Spotify AB
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law... | 1 | 17,389 | Is this the best way to import `FileSystemTarget`? | spotify-luigi | py |
@@ -2751,10 +2751,10 @@ static void
replace_thread_id(thread_id_t old, thread_id_t new)
{
#ifdef HAVE_TLS
- thread_id_t new_tid = new;
+ int32_t new_tid = (int32_t) new; /* can't use thread_id_t since it's 64-bits on x64 */
ASSERT(is_thread_tls_initialized());
DOCHECK(1, {
- thread_id_t old_ti... | 1 | /* *******************************************************************************
* Copyright (c) 2010-2017 Google, Inc. All rights reserved.
* Copyright (c) 2011 Massachusetts Institute of Technology All rights reserved.
* Copyright (c) 2000-2010 VMware, Inc. All rights reserved.
* ****************************... | 1 | 10,900 | Wait -- os_local_state_t.tid is thread_id_t though, so we need to read a pointer-sized value via READ_TLS_SLOT_IMM, rather than changing these locals to ints. Maybe have a READ_TLS_TIDSZ_SLOT_IMM or sthg. | DynamoRIO-dynamorio | c |
@@ -13311,7 +13311,11 @@ public:
HRESULT Status;
ICorDebugProcess* pCorDebugProcess;
- IfFailRet(g_pRuntime->GetCorDebugInterface(&pCorDebugProcess));
+ if (FAILED(Status = g_pRuntime->GetCorDebugInterface(&pCorDebugProcess)))
+ {
+ ExtOut("\n\n\n!clrstack -i is unsup... | 1 | // Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.
// ==++==
//
//
// ==--==
// ===========================================================================
// STR... | 1 | 11,107 | Don't use ! in the messages because it isn't used on xplat. There is a SOSPrefix define that can be used (blank on xplat and ! on Windows). Do we really need 3 newlines? | dotnet-diagnostics | cpp |
@@ -52,7 +52,13 @@ def _dagster_home():
'DAGSTER_HOME is not set, check is_dagster_home_set before invoking.'
)
- return os.path.expanduser(dagster_home_path)
+ dagster_home_path = os.path.expanduser(dagster_home_path)
+
+ if not os.path.isabs(dagster_home_path):
+ raise DagsterI... | 1 | import datetime
import logging
import os
import time
from abc import ABCMeta
from collections import defaultdict, namedtuple
from enum import Enum
import six
import yaml
from rx import Observable
from dagster import check, seven
from dagster.config import Field, Permissive
from dagster.core.definitions.events import ... | 1 | 13,759 | print out what we got here in the error | dagster-io-dagster | py |
@@ -43,6 +43,9 @@ See the file COPYING for details.
)); \
} while (false)
+//Stores select query before evaluation
+struct jx *select_expr = NULL;
+
static struct jx *jx_check_errors(struct jx *j);
static struct jx *jx_eval_null(struct jx_operator *op, struct jx *left, struct jx *right) { | 1 | /*
Copyright (C) 2016- The University of Notre Dame
This software is distributed under the GNU General Public License.
See the file COPYING for details.
*/
#include "jx_eval.h"
#include "debug.h"
#include "jx_function.h"
#include "jx_print.h"
#include <assert.h>
#include <string.h>
#include <stdbool.h>
#include <math... | 1 | 14,874 | Does this need to be global? | cooperative-computing-lab-cctools | c |
@@ -1349,7 +1349,7 @@ public final class TreeMap<K, V> implements SortedMap<K, V>, Serializable {
@Override
public Seq<V> values() {
- return iterator().map(Tuple2::_2).toStream();
+ return map(Tuple2::_2);
}
// -- Object | 1 | /* __ __ __ __ __ ___
* \ \ / / \ \ / / __/
* \ \/ / /\ \ \/ / /
* \____/__/ \__\____/__/
*
* Copyright 2014-2017 Vavr, http://vavr.io
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may ... | 1 | 12,468 | Yep, could be simplified. Now looks like other *Map.values() impls | vavr-io-vavr | java |
@@ -183,6 +183,15 @@ class ApiContext extends \Imbo\BehatApiExtension\Context\ApiContext
$this->assertJsonObjectContainsKeys('configuration,columns,collection,info');
}
+ /**
+ * @Then /^print last api response$/
+ */
+ public function printLastApiResponse(): void
+ {
+ $this->re... | 1 | <?php
/**
* Copyright © Bold Brand Commerce Sp. z o.o. All rights reserved.
* See LICENSE.txt for license details.
*/
use Assert\Assertion;
use Assert\AssertionFailedException as AssertionFailure;
use Behat\Behat\Hook\Scope\BeforeScenarioScope;
use Behat\Gherkin\Node\TableNode;
use Imbo\BehatApiExtension\Exception... | 1 | 8,439 | This method will be for debug? | ergonode-backend | php |
@@ -9,9 +9,16 @@ import (
"errors"
)
+// ErrInvalidPassword is returned when the password for decrypting content where
+// private key is stored is not valid.
var ErrInvalidPassword = errors.New("invalid password")
+// Service for managing keystore private keys.
type Service interface {
+ // Key returns privat... | 1 | // Copyright 2020 The Swarm Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
package keystore
import (
"crypto/ecdsa"
"errors"
)
var ErrInvalidPassword = errors.New("invalid password")
type Service interface {
Key(name, password... | 1 | 12,837 | // Key returns the private key for a specified name that was encrypted with the // provided password. If the private key does not exists it creates a new one // with a name and the password, and returns with `created` set to true. | ethersphere-bee | go |
@@ -45,6 +45,19 @@ class DiagramEntity(Figure):
self.node = node
+class PackageEntity(DiagramEntity):
+ """A diagram object representing a package"""
+
+
+class ClassEntity(DiagramEntity):
+ """A diagram object representing a class"""
+
+ def __init__(self, title, node):
+ super().__init__(... | 1 | # Copyright (c) 2006, 2008-2010, 2012-2014 LOGILAB S.A. (Paris, FRANCE) <contact@logilab.fr>
# Copyright (c) 2014-2018, 2020 Claudiu Popa <pcmanticore@gmail.com>
# Copyright (c) 2014 Brett Cannon <brett@python.org>
# Copyright (c) 2014 Arun Persaud <arun@nubati.net>
# Copyright (c) 2015 Ionel Cristian Maries <contact@i... | 1 | 14,758 | Adding the type hints revealed that it was necessary to distinguish between a ``PackageEntity`` and a ``ClassEntity``, because the ``ClassEntity`` has additional attributes that were dynamically added in the previous code, which confused ``mypy``. | PyCQA-pylint | py |
@@ -43,7 +43,8 @@ class _MissingPandasLikeDataFrame(object):
blocks = unsupported_property('blocks', deprecated=True)
# Functions
- add = unsupported_function('add')
+ add_prefix = unsupported_function('add_prefix')
+ add_suffix = unsupported_function('add_suffix')
agg = unsupported_function('... | 1 | #
# Copyright (C) 2019 Databricks, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to i... | 1 | 9,905 | These two functions should be available now. | databricks-koalas | py |
@@ -651,10 +651,17 @@ type localOpenFile struct {
o *Object // object that is open
in io.ReadCloser // handle we are wrapping
hash *hash.MultiHasher // currently accumulating hashes
+ fd *os.File // file object reference
}
// Read bytes from the object - see io.Reader
func (file... | 1 | // Package local provides a filesystem interface
package local
import (
"fmt"
"io"
"io/ioutil"
"os"
"path"
"path/filepath"
"regexp"
"runtime"
"strings"
"sync"
"time"
"unicode/utf8"
"github.com/ncw/rclone/fs"
"github.com/ncw/rclone/fs/config"
"github.com/ncw/rclone/fs/config/flags"
"github.com/ncw/rclo... | 1 | 6,791 | `fi` is what the result of Stat is called elsewhere in this file not `finfo` | rclone-rclone | go |
@@ -62,15 +62,6 @@ RSpec.describe Blacklight::OpenStructWithHashAccess do
end
end
- describe "#replace" do
- subject { described_class.new a: 1 }
-
- it "can use #replace to reorder the hash" do
- subject.replace b: 1
- expect(subject.b).to eq 1
- end
- end
-
describe "#sort_by" do
... | 1 | # frozen_string_literal: true
RSpec.describe Blacklight::OpenStructWithHashAccess do
it "provides hash-like accessors for OpenStruct data" do
a = described_class.new foo: :bar, baz: 1
expect(a[:foo]).to eq :bar
expect(a[:baz]).to eq 1
expect(a[:asdf]).to be_nil
end
it "provides hash-like writer... | 1 | 8,807 | I'm confused; are we just dropping these methods without deprecation? | projectblacklight-blacklight | rb |
@@ -16,12 +16,18 @@ void AddEdgesProcessor::process(const cpp2::AddEdgesRequest& req) {
auto spaceId = req.get_space_id();
auto version =
std::numeric_limits<int64_t>::max() - time::WallClock::fastNowInMicroSec();
+ // Switch version to big-endian, make sure the key is in ordered.
+ version = f... | 1 | /* Copyright (c) 2018 vesoft inc. All rights reserved.
*
* This source code is licensed under Apache 2.0 License,
* attached with Common Clause Condition 1.0, found in the LICENSES directory.
*/
#include "storage/AddEdgesProcessor.h"
#include "base/NebulaKeyUtils.h"
#include <algorithm>
#include <limits>
#include "... | 1 | 21,977 | can we use PC's time to version in Distributed Systems? | vesoft-inc-nebula | cpp |
@@ -100,9 +100,11 @@
<% cart.comments.each do |c| %>
<div class='comment-item'>
<div class='row'>
- <p class='comment-sender col-sm-6 col-xs-12'>
- <strong>requester@test.com</strong>
- </p>
+ <% unless c.user.nil? %>
+ ... | 1 | <div class="inset">
<div class="row">
<div class="col-md-12 col-xs-12">
<h1 class="communicart_header">
<%= cart.name %>
</h1>
<div class="communicart_description">
<p>
Purchase Request: <strong>#<%= cart.id %></strong>
</p>
<p>
Requested by:... | 1 | 12,399 | is this "unless" actually needed? | 18F-C2 | rb |
@@ -94,6 +94,10 @@ final class Stemmer {
}
List<CharsRef> list = new ArrayList<>();
+ if (length == 0) {
+ return list;
+ }
+
RootProcessor processor =
(stem, formID, stemException) -> {
list.add(newStem(stem, stemException)); | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may ... | 1 | 40,765 | We don't accept empty words for lookup anymore, again | apache-lucene-solr | java |
@@ -0,0 +1,18 @@
+#!/usr/bin/env node
+
+const fs = require('fs')
+const yarnOut = fs.readFileSync(0, {encoding: 'utf8'})
+
+const [installTimeString] = /(?<=^Done in )\d+\.\d+(?=s\.$)/m.exec(yarnOut)
+const installTime = Number(installTimeString)
+
+console.log(`Install time: ${installTime}s`)
+
+if (installTime < 30)... | 1 | 1 | 9,145 | We'll have to account for CI installations being faster than local ones. Do y'all think we should leave it at < 30 green / < 50 orange | >= 50 red or lower our thresholds? | blitz-js-blitz | js | |
@@ -101,6 +101,7 @@ class Command(object):
EXECUTE_ASYNC_SCRIPT = "executeAsyncScript"
SET_SCRIPT_TIMEOUT = "setScriptTimeout"
SET_TIMEOUTS = "setTimeouts"
+ W3C_MINIMIZE_WINDOW = "w3cMinimizeWindow"
MAXIMIZE_WINDOW = "windowMaximize"
W3C_MAXIMIZE_WINDOW = "w3cMaximizeWindow"
GET_LOG = ... | 1 | # Licensed to the Software Freedom Conservancy (SFC) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The SFC licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not... | 1 | 14,686 | No need for this to be `W3C_` since there is no JWP equivalent | SeleniumHQ-selenium | rb |
@@ -1,5 +1,12 @@
module RSpec
module Core
+ if defined?(::Random)
+ RandomNumberGenerator = ::Random
+ else
+ require 'rspec/core/backport_random'
+ RandomNumberGenerator = RSpec::Core::Backports::Random
+ end
+
# @private
module Ordering
# @private | 1 | module RSpec
module Core
# @private
module Ordering
# @private
# The default global ordering (defined order).
class Identity
def order(items)
items
end
end
# @private
# Orders items randomly.
class Random
def initialize(configuration... | 1 | 10,779 | As far as I can tell, there's nothing that creates an instance of `Random` or that calls `rand` or `seed`. Am I missing it? If not, let's remove the `Random` class since we don't really need it and we can move the definitions of `shuffle` into `RSpec::Core::Ordering`. One less type :). | rspec-rspec-core | rb |
@@ -480,3 +480,13 @@ func (s *Server) NumSubscriptions() uint32 {
stats := s.sl.Stats()
return stats.NumSubs
}
+
+// Addr will return the net.Addr object for the current listener.
+func (s *Server) Addr() net.Addr {
+ s.mu.Lock()
+ defer s.mu.Unlock()
+ if s.listener == nil {
+ return nil
+ }
+ return s.listener.... | 1 | // Copyright 2012-2014 Apcera Inc. All rights reserved.
package server
import (
"encoding/json"
"fmt"
"io/ioutil"
"net"
"net/http"
"os"
"os/signal"
"strconv"
"sync"
"time"
// Allow dynamic profiling.
_ "net/http/pprof"
"github.com/apcera/gnatsd/sublist"
)
// Info is the information sent to clients to ... | 1 | 5,971 | Is this ever actually used? | nats-io-nats-server | go |
@@ -158,7 +158,7 @@ func (w *Waiter) receiptFromTipSet(ctx context.Context, msgCid cid.Cid, ts conse
if err != nil {
return nil, err
}
- res, err := consensus.ProcessTipSet(ctx, ts, st, vm.NewStorageMap(w.bs))
+ res, err := consensus.NewDefaultProcessor().ProcessTipSet(ctx, st, vm.NewStorageMap(w.bs), ts)
if e... | 1 | package msgapi
import (
"context"
"fmt"
"gx/ipfs/QmR8BauakNcBa3RbE4nbQu76PDiJgoQgz8AJdhJuiU4TAw/go-cid"
"gx/ipfs/QmRXf2uUSdGSunRJsM9wXSUNVwLUGCY3So5fAs7h2CBJVf/go-hamt-ipld"
bstore "gx/ipfs/QmS2aqUZLJp8kF1ihE5rvDGE5LvmKDPnx32w9Z1BW9xLV5/go-ipfs-blockstore"
"gx/ipfs/QmVmDhyTTUcQXFD1rRQ64fGLMSAoaQvNH3hwuaCFAPq2hy... | 1 | 15,897 | this section of the codebase should be noted as a candidate for caching, and as a place where multiple tipsets is making things extra tricky | filecoin-project-venus | go |
@@ -1749,6 +1749,10 @@ translate_from_synchall_to_dispatch(thread_record_t *tr, thread_synch_state_t sy
arch_mcontext_reset_stolen_reg(dcontext, mc);
}
});
+ IF_AARCHXX({
+ set_stolen_reg_val(mc, (reg_t)os_get_dr_tls_base(dcontext));
+ IF_ARM(ASSERT_NO... | 1 | /* **********************************************************
* Copyright (c) 2012-2020 Google, Inc. All rights reserved.
* Copyright (c) 2008-2010 VMware, Inc. All rights reserved.
* **********************************************************/
/*
* Redistribution and use in source and binary forms, with or witho... | 1 | 21,896 | Do we need to save the existing value of the stolen reg somehow? | DynamoRIO-dynamorio | c |
@@ -94,7 +94,8 @@ class AdminDirectoryClient(_base_client.BaseClient):
api_errors.ApiExecutionError
"""
members_stub = self.service.members()
- request = members_stub.list(groupKey=group_key)
+ request = members_stub.list(groupKey=group_key,
+ ... | 1 | # Copyright 2017 Google Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, s... | 1 | 25,672 | maxResults should come from FLAGS once #244 is submitted. | forseti-security-forseti-security | py |
@@ -12,6 +12,8 @@ using Datadog.Trace.TestHelpers;
using Xunit;
using Xunit.Abstractions;
+#if NETCOREAPP
+
namespace Datadog.Trace.ClrProfiler.IntegrationTests
{
[CollectionDefinition(nameof(HttpMessageHandlerTests), DisableParallelization = true)] | 1 | // <copyright file="HttpMessageHandlerTests.cs" company="Datadog">
// Unless explicitly stated otherwise all files in this repository are licensed under the Apache 2 License.
// This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
// </copyright>
using System.C... | 1 | 24,835 | is this wanted? | DataDog-dd-trace-dotnet | .cs |
@@ -268,6 +268,14 @@ def get_docker_executable():
return distutils.spawn.find_executable('docker')
+def get_linode_executable():
+ try:
+ pytest.importorskip('linode')
+ return True
+ except Exception:
+ return False
+
+
def get_lxc_executable():
return distutils.spawn.find_exe... | 1 | # Copyright (c) 2015-2018 Cisco Systems, Inc.
# Copyright (c) 2018 Red Hat, Inc.
#
# Permission is hereby granted, free of charge, to any person obtaining a copy
# of this software and associated documentation files (the "Software"), to
# deal in the Software without restriction, including without limitation the
#... | 1 | 8,117 | What exception is actually happening here? AFAIK `pytest.importorskip` with just return `None` if there's nothing to import. Which means that this check'd always return `True`. `pytest.importorskip` is specifically designed to trigger skipping the current test anyway so I don't know why you would wrap it like this. | ansible-community-molecule | py |
@@ -22,7 +22,7 @@ module Selenium
class Common
MAX_REDIRECTS = 20 # same as chromium/gecko
CONTENT_TYPE = 'application/json'.freeze
- DEFAULT_HEADERS = {'Accept' => CONTENT_TYPE}.freeze
+ DEFAULT_HEADERS = {'Accept' => CONTENT_TYPE, 'Content-Type' => 'application/x-... | 1 | # Licensed to the Software Freedom Conservancy (SFC) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The SFC licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not... | 1 | 15,359 | Does it send requests with urlencoded bodies anywhere? I thought it sends only json. Maybe content-type should be `application/json` by default? | SeleniumHQ-selenium | js |
@@ -21,6 +21,7 @@ program
.option('--target_arch <target_arch>', 'target architecture')
.option('--target_apk_base <target_apk_base>', 'target Android OS apk (classic, modern, mono)')
.option('--submodule_sync', 'run submodule sync')
+ .option('--ignore_chromium', 'do not update chromium')
.option('--init'... | 1 | // Copyright (c) 2019 The Brave Authors. All rights reserved.
// This Source Code Form is subject to the terms of the Mozilla Public
// License, v. 2.0. If a copy of the MPL was not distributed with this file,
// you can obtain one at http://mozilla.org/MPL/2.0/.
const program = require('commander')
const config = req... | 1 | 6,692 | I'm not sure about adding more flags here when we're trying to simplify things, I thought we were going to check for patches changes to decide if we needed to update or not? | brave-brave-browser | js |
@@ -57,13 +57,15 @@ var (
ta.Keyinfo["alfa"].PriKey, 3, big.NewInt(10), []byte{}, testutil.TestGasLimit,
big.NewInt(testutil.TestGasPriceInt64))
- testTransferPb = testTransfer.Proto()
+ testTransferHash = testTransfer.Hash()
+ testTransferPb = testTransfer.Proto()
testExecution, _ = testutil.SignedExecut... | 1 | // Copyright (c) 2019 IoTeX
// This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no
// warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent
// permitted by law, all liability for your use of the cod... | 1 | 17,260 | `testExecutionPb` is a global variable (from `gochecknoglobals`) | iotexproject-iotex-core | go |
@@ -127,17 +127,6 @@ class ImageProvider extends FileProvider
return array_merge($params, $options);
}
- /**
- * {@inheritdoc}
- */
- public function getReferenceImage(MediaInterface $media)
- {
- return sprintf('%s/%s',
- $this->generatePath($media),
- $med... | 1 | <?php
/*
* This file is part of the Sonata Project package.
*
* (c) Thomas Rabaix <thomas.rabaix@sonata-project.org>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/
namespace Sonata\MediaBundle\Provider;
use Gaufrette\Filesystem... | 1 | 10,301 | ~Method is public and removing it would be a BC Break, you can deprecate it if you want.~ | sonata-project-SonataMediaBundle | php |
@@ -113,7 +113,7 @@ func (i *interpreter) interpretStatements(s *scope, statements []*Statement) (re
} else {
err = fmt.Errorf("%s", r)
}
- log.Debug("%s", debug.Stack())
+ log.Debug("%v:\n %s", err, debug.Stack())
}
}()
return s.interpretStatements(statements), nil // Would have panicked if th... | 1 | package asp
import (
"context"
"fmt"
"reflect"
"runtime/debug"
"runtime/pprof"
"strings"
"sync"
"github.com/thought-machine/please/src/core"
"github.com/thought-machine/please/src/fs"
)
// An interpreter holds the package-independent state about our parsing process.
type interpreter struct {
scope ... | 1 | 10,020 | this got me a little confused when reading `build.log`. The err is printed with a log.Error later on but that ends up after the stack trace. | thought-machine-please | go |
@@ -157,6 +157,7 @@ std::string FlatCompiler::GetUsageString(const char *program_name) const {
" --include-prefix Prefix this path to any generated include statements.\n"
" PATH\n"
" --keep-prefix Keep original prefix of schema include statement.\n"
+ " --keep-namespaces Keep... | 1 | /*
* Copyright 2014 Google Inc. All rights reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applica... | 1 | 19,210 | Can we make these more explicitly for Rust only? It seems like JS and Go use flags with their name in them. | google-flatbuffers | java |
@@ -88,6 +88,9 @@ type URLOpener struct{}
// - file://localhost/c:/foo/bar
// -> Also passes "c:\foo\bar".
func (*URLOpener) OpenBucketURL(ctx context.Context, u *url.URL) (*blob.Bucket, error) {
+ for param := range u.Query() {
+ return nil, fmt.Errorf("open bucket %q: invalid query parameter %q", u, param)
+ ... | 1 | // Copyright 2018 The Go Cloud Development Kit Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// https://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by appli... | 1 | 15,065 | Should unsupported query parameters just be ignored? I think that's more common than error out. | google-go-cloud | go |
@@ -52,9 +52,9 @@ def namespace(namespace=None):
Call to set namespace of tasks declared after the call.
If called without arguments or with ``None`` as the namespace, the namespace
- is reset, which is recommended to do at the end of any file where the
- namespace is set to avoid unintentionally sett... | 1 | # -*- coding: utf-8 -*-
#
# Copyright 2012-2015 Spotify AB
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law... | 1 | 16,359 | Actually can we avoid mentioning `Register._UNSET_NAMESPACE`. I thought of it as an implementation detail of the simpler concept of "being unset". Perhaps the docs become more natural if we remove the "If called without arguments or with ..." part and just say "you have to call this function without arguments at the en... | spotify-luigi | py |
@@ -426,8 +426,16 @@ class WinWordCollectionQuicknavIterator(object):
if self.direction=="previous":
index=itemCount-(index-1)
collectionItem=items[index]
- item=self.quickNavItemClass(self.itemType,self.document,collectionItem)
- itemRange=item.rangeObj
+ try:
+ item=self.quickNavItemClass(self.i... | 1 | #appModules/winword.py
#A part of NonVisual Desktop Access (NVDA)
#Copyright (C) 2006-2016 NV Access Limited, Manish Agrawal, Derek Riemer
#This file is covered by the GNU General Public License.
#See the file COPYING for more details.
import ctypes
import time
from comtypes import COMError, GUID, BSTR
import... | 1 | 18,558 | I assume it raises COMError? If so perhaps best to just catch that specifically, so as to not hide other more critical errors. | nvaccess-nvda | py |
@@ -328,6 +328,7 @@ var directives = []string{
"git", // github.com/abiosoft/caddy-git
// directives that add middleware to the stack
+ "minify", // github.com/hacdias/caddy-minify
"log",
"gzip",
"errors", | 1 | package httpserver
import (
"flag"
"fmt"
"log"
"net"
"net/url"
"strings"
"time"
"github.com/mholt/caddy"
"github.com/mholt/caddy/caddyfile"
"github.com/mholt/caddy/caddytls"
)
const serverType = "http"
func init() {
flag.StringVar(&Host, "host", DefaultHost, "Default host")
flag.StringVar(&Port, "port",... | 1 | 8,445 | Since minify can generate errors, it should at least go after the errors middleware. And you definitely don't want to be minifying after the gzip writer has closed. | caddyserver-caddy | go |
@@ -31,7 +31,8 @@ type Tracer struct {
// Version is the instrumentation version.
Version string
- config *config
+ config *config
+ provider *TracerProvider
}
// Start creates a span. If t is configured with a SpanRecorder its OnStart | 1 | // Copyright The OpenTelemetry Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agre... | 1 | 15,750 | nit: we could remove the `config` field as it is a duplicate of the `provider.config` field. | open-telemetry-opentelemetry-go | go |
@@ -112,7 +112,8 @@ class ForsetiServerInstaller(ForsetiInstaller):
# Create firewall rule to open only port tcp:50051
# within the internal network (ip-ranges - 10.128.0.0/9)
gcloud.create_firewall_rule(
- self.format_firewall_rule_name('forseti-server-allow-grpc')... | 1 | # Copyright 2017 The Forseti Security Authors. All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by a... | 1 | 29,053 | Nit: from the Internet. | forseti-security-forseti-security | py |
@@ -7,11 +7,15 @@
package hdwallet
import (
+ "bytes"
"fmt"
"io/ioutil"
+ ecrypt "github.com/ethereum/go-ethereum/crypto"
+ "github.com/iotexproject/go-pkgs/crypto"
+ "github.com/iotexproject/iotex-address/address"
+ hdwallet "github.com/miguelmota/go-ethereum-hdwallet"
"github.com/spf13/cobra"
-
"github.... | 1 | // Copyright (c) 2019 IoTeX Foundation
// This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no
// warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent
// permitted by law, all liability for your use... | 1 | 22,766 | this is internal package, move to bottom and run 'make fmt' | iotexproject-iotex-core | go |
@@ -0,0 +1,14 @@
+// Copyright (c) .NET Foundation. All rights reserved.
+// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+
+using System.Threading;
+
+namespace Microsoft.AspNetCore.Connections.Features
+{
+ public interface IConnectionLifetimeNotifica... | 1 | 1 | 16,391 | Why is this better than ApplicationStopping? | aspnet-KestrelHttpServer | .cs | |
@@ -70,8 +70,8 @@ type ChallengeSpec struct {
// +optional
Wildcard bool `json:"wildcard"`
- // Type is the type of ACME challenge this resource represents, e.g. "dns01"
- // or "http01".
+ // Type is the type of ACME challenge this resource represents.
+ // One of "http-01" or "dns-01".
Type ACMEChallengeType ... | 1 | /*
Copyright 2019 The Jetstack cert-manager contributors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed... | 1 | 22,450 | Maybe worth expanding that these 2 are supported by cert-manager but other values exist | jetstack-cert-manager | go |
@@ -169,7 +169,7 @@ class MediaExtension extends \Twig_Extension
$options = array_merge($defaultOptions, $options);
- $options['src'] = $provider->generatePublicUrl($media, $format);
+ $options = $provider->getHelperProperties($media, $format, $options);
return $this->render($provi... | 1 | <?php
/*
* This file is part of sonata-project.
*
* (c) 2010 Thomas Rabaix
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/
namespace Sonata\MediaBundle\Twig\Extension;
use Sonata\CoreBundle\Model\ManagerInterface;
use Sonata\Med... | 1 | 7,322 | Why was this merged? It should have raised some questions IMO @core23 @OskarStark . It's already in 3 releases now, so we can't revert it can we? How can we fix this? Please have a look at #1065 | sonata-project-SonataMediaBundle | php |
@@ -125,6 +125,10 @@ public class ProcessBesuNodeRunner implements BesuNodeRunner {
params.add("--rpc-http-authentication-credentials-file");
params.add(node.jsonRpcConfiguration().getAuthenticationCredentialsFile());
}
+ if (node.jsonRpcConfiguration().getAuthenticationPublicKeyFile() != ... | 1 | /*
* Copyright ConsenSys AG.
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing... | 1 | 20,408 | What if `node.jsonRpcConfiguration().getAuthenticationPublicKeyFile()` is empty string, would that cause a problem here? | hyperledger-besu | java |
@@ -57,6 +57,12 @@ type CertificateSpec struct {
// Organization is the organization to be used on the Certificate
Organization []string `json:"organization,omitempty"`
+ // Certificate default Duration
+ Duration metav1.Duration `json:"duration,omitempty"`
+
+ // Certificate renew before expiration duration
+ Re... | 1 | /*
Copyright 2018 The Jetstack cert-manager contributors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed... | 1 | 13,832 | The `omitempty` struct tag does not do anything for non-pointer structs. I think we may need to consider making both of these fields pointers, so that they are excluded from output when not set, and also to make it easier to compare to the zero value. That said, I'm happy to merge this now and open an issue to verify t... | jetstack-cert-manager | go |
@@ -120,7 +120,7 @@ public interface GenericToken<T extends GenericToken<T>> {
+ ") must come before " + to + " (at " + to.getStartInDocument() + ")"
);
}
- return IteratorUtil.generate(from, t -> t == to ? null : t.getNext());
+ return IteratorUtil.generate(from... | 1 | /**
* BSD-style license; for more info see http://pmd.sourceforge.net/license.html
*/
package net.sourceforge.pmd.lang.ast;
import java.util.Iterator;
import net.sourceforge.pmd.annotation.Experimental;
import net.sourceforge.pmd.internal.util.IteratorUtil;
import net.sourceforge.pmd.lang.ast.impl.javacc.JavaccTok... | 1 | 19,282 | I think this is should absolutely be `==`, as the interface cannot control the implementation of equals (and it's part of the contract of the enclosing function). Can we add this interface to the exceptions of the rule? | pmd-pmd | java |
@@ -22,11 +22,12 @@ type ns struct {
ipt iptables.Interface // interface to iptables
ips ipset.Interface // interface to ipset
- name string // k8s Namespace name
- nodeName string // my node name
- namespace *coreapi.Namespace // k8s Namespace object
- pod... | 1 | package npc
import (
"errors"
"fmt"
coreapi "k8s.io/api/core/v1"
extnapi "k8s.io/api/extensions/v1beta1"
networkingv1 "k8s.io/api/networking/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/types"
"k8s.io/apimachinery/pkg/util/uuid"
"github.com/weaveworks/weave/common"
"github.com... | 1 | 16,046 | It looks like the UID is the only other thing that we use from `namespace`, so I suggest to copy that out and lose `namespace`, so we don't have to worry about setting it to nil. | weaveworks-weave | go |
@@ -17,6 +17,7 @@ const (
GithubV1ProviderName = "GitHubV1"
CodeCommitProviderName = "CodeCommit"
BitbucketProviderName = "Bitbucket"
+ DefaultImage = "aws/codebuild/amazonlinux2-x86_64-standard:3.0"
pipelineManifestPath = "cicd/pipeline.yml"
) | 1 | // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
// SPDX-License-Identifier: Apache-2.0
package manifest
import (
"errors"
"fmt"
"github.com/aws/copilot-cli/internal/pkg/template"
"github.com/fatih/structs"
"gopkg.in/yaml.v3"
)
const (
GithubProviderName = "GitHub"
GithubV1ProviderNa... | 1 | 16,954 | Can we define this constant in the`deploy` pkg instead? this would allow us to keep it private | aws-copilot-cli | go |
@@ -251,7 +251,7 @@ def reporter():
@pytest.fixture
def init_linter(linter: PyLinter) -> PyLinter:
linter.open()
- linter.set_current_module("toto")
+ linter.set_current_module("toto", "mydir/toto")
linter.file_state = FileState("toto")
return linter
| 1 | # Copyright (c) 2006-2014 LOGILAB S.A. (Paris, FRANCE) <contact@logilab.fr>
# Copyright (c) 2011-2014 Google, Inc.
# Copyright (c) 2012 Kevin Jing Qiu <kevin.jing.qiu@gmail.com>
# Copyright (c) 2012 Anthony VEREZ <anthony.verez.external@cassidian.com>
# Copyright (c) 2012 FELD Boris <lothiraldan@gmail.com>
# Copyright ... | 1 | 19,440 | I don't like this fixture name, should be a noun like `initialized_linter` ? But it's outside of the scope of this MR. | PyCQA-pylint | py |
@@ -154,7 +154,9 @@ public class ExportService {
if (releasedVersion == null) {
throw new ExportException("No released version for dataset " + dataset.getGlobalId().toString());
}
- final JsonObjectBuilder datasetAsJsonBuilder = JsonPrinter.jsonAsDatasetDto(released... | 1 | package edu.harvard.iq.dataverse.export;
import edu.harvard.iq.dataverse.Dataset;
import edu.harvard.iq.dataverse.DatasetVersion;
import static edu.harvard.iq.dataverse.GlobalIdServiceBean.logger;
import edu.harvard.iq.dataverse.dataaccess.DataAccess;
import static edu.harvard.iq.dataverse.dataaccess.DataAccess.getSto... | 1 | 38,872 | Could we keep this as a static reference (JsonPrinter.jsonAsDatasetDto(releasedVersion); and perhaps change the constructor line to just be a static set method and use that here instead? (I suspect it was the warning that 'static methods should be accessed in a static manner' from my IDE that caused me to make this cha... | IQSS-dataverse | java |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.