patch stringlengths 17 31.2k | y int64 1 1 | oldf stringlengths 0 2.21M | idx int64 1 1 | id int64 4.29k 68.4k | msg stringlengths 8 843 | proj stringclasses 212
values | lang stringclasses 9
values |
|---|---|---|---|---|---|---|---|
@@ -30,8 +30,9 @@ func NewGlobalOpts() *GlobalOpts {
bindProjectName()
return &GlobalOpts{
- projectName: viper.GetString(projectFlag),
- prompt: prompt.New(),
+ // Leave the projectName as empty in case it's overwritten by a global flag.
+ // See https://github.com/aws/amazon-ecs-cli-v2/issues/570#issue... | 1 | // Copyright 2019 Amazon.com, Inc. or its affiliates. All Rights Reserved.
// SPDX-License-Identifier: Apache-2.0
// Package cli contains the ecs-preview subcommands.
package cli
import (
"fmt"
"os"
"github.com/aws/amazon-ecs-cli-v2/internal/pkg/archer"
"github.com/aws/amazon-ecs-cli-v2/internal/pkg/aws/ecr"
"g... | 1 | 11,582 | I feel like since now we don't initiate the `opts.projectName` with `opts.ProjectName()`, which means `opts.projectName` and `opts.ProjectName()` they don't necessarily equal to each other, we need to also substitute all usage of `opts.ProjectName()` within `Ask()`, `Validate()`, and `Execute()` to `opts.projectName`. ... | aws-copilot-cli | go |
@@ -531,7 +531,7 @@ namespace Nethermind.Core.Extensions
[DebuggerStepThrough]
public static string ByteArrayToHexViaLookup32Safe(byte[] bytes, bool withZeroX)
{
- if (bytes.Length == 0)
+ if (bytes?.Length == 0 || bytes == null)
{
return wi... | 1 | // Copyright (c) 2018 Demerzel Solutions Limited
// This file is part of the Nethermind library.
//
// The Nethermind library is free software: you can redistribute it and/or modify
// it under the terms of the GNU Lesser General Public License as published by
// the Free Software Foundation, either version 3 of... | 1 | 24,274 | why do we thinkg that an empty string is ok to return from this method? I think the null should never be passed in here in the first place | NethermindEth-nethermind | .cs |
@@ -142,15 +142,12 @@ axe.utils.getNodeFromTree = function(vNode, node) {
return vNode;
}
vNode.children.forEach(candidate => {
- var retVal;
-
- if (candidate.actualNode === node) {
+ if (found) {
+ return;
+ } else if (candidate.actualNode === node) {
found = candidate;
} else {
- retVal = axe.u... | 1 | /*eslint no-use-before-define: 0*/
var axe = axe || { utils: {} };
/**
* This implemnts the flatten-tree algorithm specified:
* Originally here https://drafts.csswg.org/css-scoping/#flat-tree
* Hopefully soon published here: https://www.w3.org/TR/css-scoping-1/#flat-tree
*
* Some notable information:
******* NOT... | 1 | 13,767 | nit: can remove this `else` since we return from the condition above. | dequelabs-axe-core | js |
@@ -39,11 +39,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
_flushCompleted = OnFlushCompleted;
}
- public void Write(ArraySegment<byte> buffer, bool chunk = false)
- {
- WriteAsync(buffer, default(CancellationToken), chunk).GetAwaiter().GetResult... | 1 | // Copyright (c) .NET Foundation. All rights reserved.
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
using System;
using System.Threading;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Infrastructure;
using Micros... | 1 | 13,219 | You missed `Write<T>(...)`! I'm kidding ofc. | aspnet-KestrelHttpServer | .cs |
@@ -5,7 +5,7 @@ class SubscriptionUpcomingInvoiceUpdater
def process
@subscriptions.each do |subscription|
- if subscription.stripe_customer_id
+ if subscription.stripe_customer_id.present?
upcoming_invoice = upcoming_invoice_for(subscription.stripe_customer_id)
update_next_payment... | 1 | class SubscriptionUpcomingInvoiceUpdater
def initialize(subscriptions)
@subscriptions = subscriptions
end
def process
@subscriptions.each do |subscription|
if subscription.stripe_customer_id
upcoming_invoice = upcoming_invoice_for(subscription.stripe_customer_id)
update_next_payment... | 1 | 12,920 | Was there a customer who had this set to an empty string? | thoughtbot-upcase | rb |
@@ -13,6 +13,14 @@ module Ncr
approver_email_address(final_approver)
end
+ def status_aware_approver_email_address
+ if proposal.approved?
+ final_approver_email_address
+ else
+ current_approver_email_address
+ end
+ end
+
private
def approver_email_address(... | 1 | module Ncr
class WorkOrderDecorator < Draper::Decorator
delegate_all
EMERGENCY_APPROVER_EMAIL = 'Emergency - Verbal Approval'
NO_APPROVER_FOUND = 'No Approver Found'
def current_approver_email_address
approver_email_address(current_approver)
end
def final_approver_email_address
... | 1 | 14,838 | I know we have the `reporter` spec below, but what about a unit test for this to explain reasoning behind logic? If I were going to update this decorator, I would assume it wasn't covered by tests because there is no unit test. | 18F-C2 | rb |
@@ -34,4 +34,6 @@ public interface RestClientRequest {
void addForm(String name, Object value);
Buffer getBodyBuffer() throws Exception;
+
+ void attach(String name, String filename);
} | 1 | /*
* Copyright 2017 Huawei Technologies Co., Ltd
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable l... | 1 | 7,632 | it's better to be : void attach(String name, Part part); | apache-servicecomb-java-chassis | java |
@@ -77,7 +77,8 @@ public abstract class BasePageIterator {
protected abstract void initDefinitionLevelsReader(DataPageV1 dataPageV1, ColumnDescriptor descriptor,
ByteBufferInputStream in, int count) throws IOException;
- protected abstract void initDefinitionL... | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you ... | 1 | 38,669 | I didn't see where the IOException can get thrown, is this just to match the V1 reader? | apache-iceberg | java |
@@ -418,7 +418,7 @@ unsigned int compute2DCoordsMimicDistMat(
RDKit::ROMol &mol, const DOUBLE_SMART_PTR *dmat, bool canonOrient,
bool clearConfs, double weightDistMat, unsigned int nFlipsPerSample,
unsigned int nSamples, int sampleSeed, bool permuteDeg4Nodes,
- bool forceRDKit) {
+ bool /* forceRDK... | 1 | //
// Copyright (C) 2003-2017 Greg Landrum and Rational Discovery LLC
//
// @@ All Rights Reserved @@
// This file is part of the RDKit.
// The contents are covered by the terms of the BSD license
// which is included in the file license.txt, found at the root
// of the RDKit source tree.
//
#include "RDDepicto... | 1 | 18,527 | We normally suppress this warning with `RDUSED_PARAM(forceRDKit)` | rdkit-rdkit | cpp |
@@ -473,12 +473,11 @@ Player* Game::getPlayerByGUID(const uint32_t& guid)
return nullptr;
}
- for (const auto& it : players) {
- if (guid == it.second->getGUID()) {
- return it.second;
- }
+ auto it = mappedPlayerGuids.find(guid);
+ if (it == mappedPlayerGuids.end()) {
+ return nullptr;
}
- return nullptr... | 1 | /**
* The Forgotten Server - a free and open-source MMORPG server emulator
* Copyright (C) 2018 Mark Samman <mark.samman@gmail.com>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; eithe... | 1 | 16,371 | What if `Game::getPlayerByNameWildcard` had not been called before. It would not find a player, wouldn't it? | otland-forgottenserver | cpp |
@@ -129,7 +129,7 @@ public class ApplicationsSidebar extends Sidebar {
this.testingCheck = new SidebarCheckBox(tr("Testing"));
this.testingCheck.selectedProperty().bindBidirectional(filter.containTestingApplicationsProperty());
- this.requiresPatchCheck = new SidebarCheckBox(tr("Requires patc... | 1 | package org.phoenicis.javafx.views.mainwindow.apps;
import javafx.beans.binding.Bindings;
import javafx.collections.FXCollections;
import javafx.collections.ObservableList;
import javafx.geometry.Pos;
import javafx.scene.control.CheckBox;
import javafx.scene.control.ToggleButton;
import org.phoenicis.javafx.settings.J... | 1 | 12,072 | Why upper case "R"? | PhoenicisOrg-phoenicis | java |
@@ -107,3 +107,19 @@ func relativeDockerfilePath(ws copilotDirGetter, dockerfilePath string) (string,
}
return relDfPath, nil
}
+
+// dfBuildRequired returns if the container image should be built from local Dockerfile.
+func dfBuildRequired(svc interface{}) (bool, error) {
+ type manifest interface {
+ BuildRequ... | 1 | // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
// SPDX-License-Identifier: Apache-2.0
// Package cli contains the copilot subcommands.
package cli
import (
"errors"
"fmt"
"os"
"path/filepath"
"github.com/aws/aws-sdk-go/aws/awserr"
"github.com/aws/copilot-cli/internal/pkg/term/color"
"gi... | 1 | 15,287 | Does this need to return an error or could it return `false, nil`? | aws-copilot-cli | go |
@@ -94,7 +94,7 @@ public abstract class Analyzer implements Closeable {
* Create a new Analyzer, reusing the same set of components per-thread
* across calls to {@link #tokenStream(String, Reader)}.
*/
- public Analyzer() {
+ protected Analyzer() {
this(GLOBAL_REUSE_STRATEGY);
}
| 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may ... | 1 | 36,178 | Can you not change those scopes in public API classes? This applies here and in other places -- protected changed to package-scope for source is not really an API-compatible change. | apache-lucene-solr | java |
@@ -85,7 +85,7 @@ class TranslationsController extends BaseAdminController
'item_to_translate' => $item_to_translate,
'item_name' => $item_name,
'module_part' => $module_part,
- 'view_missing_traductions_... | 1 | <?php
/*************************************************************************************/
/* This file is part of the Thelia package. */
/* */
/* Copyright (c) OpenStudio ... | 1 | 10,745 | this parameter is only used in POST, please use `getRequest()->request->get('...');` Thanks | thelia-thelia | php |
@@ -29,8 +29,8 @@ export default function(config: Config, auth: IAuth, storage: IStorageHandler) {
// this might be too harsh, so ask if it causes trouble
// $FlowFixMe
app.param('package', validatePackage);
+ app.param('filename', validatePackage);
// $FlowFixMe
- app.param('filename', validateName);
... | 1 | /**
* @prettier
* @flow
*/
import type { IAuth, IStorageHandler } from '../../../types';
import type { Config } from '@verdaccio/types';
import express from 'express';
import bodyParser from 'body-parser';
import whoami from './api/whoami';
import ping from './api/ping';
import user from './api/user';
import distT... | 1 | 20,275 | Problem number 1: Scoped packages would have a `/` character here. Changing this to `validatePackage` resolves the 403. | verdaccio-verdaccio | js |
@@ -639,7 +639,11 @@ class LabelledData(param.Parameterized):
for k, v in self.items():
new_val = v.map(map_fn, specs, clone)
if new_val is not None:
- deep_mapped[k] = new_val
+ # Ensure key validation doesn't cause errors
+ ... | 1 | """
Provides Dimension objects for tracking the properties of a value,
axis or map dimension. Also supplies the Dimensioned abstract
baseclass for classes that accept Dimension values.
"""
from __future__ import unicode_literals
import re
import datetime as dt
from operator import itemgetter
import numpy as np
import ... | 1 | 18,659 | I don't quite get why there would be key errors: ``deep_mapped`` is a clone of ``self`` and ``k`` comes from ``self.items()`` so why would the key ever be rejected? | holoviz-holoviews | py |
@@ -427,6 +427,15 @@ func (te *transactorEndpoint) Withdraw(c *gin.Context) {
}
chainID := config.GetInt64(config.FlagChainID)
+ if req.ChainID != 0 {
+ if _, ok := registry.Chains()[req.ChainID]; !ok {
+ utils.SendError(resp, errors.New("Unsupported chain"), http.StatusBadRequest)
+ return
+ }
+
+ chainID... | 1 | /*
* Copyright (C) 2019 The "MysteriumNetwork/node" Authors.
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
... | 1 | 17,285 | this chain ID determines only from which chain to withdraw, therefore your changes do not accomplish what you want them to accomplish. You'll need changes to `func (aps *hermesPromiseSettler) Withdraw(chainID int64, providerID identity.Identity, hermesID, beneficiary common.Address) error`. The method probably has to i... | mysteriumnetwork-node | go |
@@ -57,7 +57,11 @@ func (TraceContext) Inject(ctx context.Context, supplier propagation.HTTPSupplie
}
func (tc TraceContext) Extract(ctx context.Context, supplier propagation.HTTPSupplier) context.Context {
- return ContextWithRemoteSpanContext(ctx, tc.extract(supplier))
+ sc := tc.extract(supplier)
+ if !sc.IsVali... | 1 | // Copyright The OpenTelemetry Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agre... | 1 | 12,028 | If instead we had `TraceContext.extract` return a bool value as a second return value, we could avoid the byte array comparison in `TraceID.IsValid`. Did you consider that alternative? | open-telemetry-opentelemetry-go | go |
@@ -22,8 +22,8 @@
#include "depotchest.h"
#include "tools.h"
-DepotChest::DepotChest(uint16_t type) :
- Container(type), maxDepotItems(2000) {}
+DepotChest::DepotChest(uint16_t type, bool paginated /*= true*/) :
+ Container(type, items[type].maxItems, true, paginated), maxDepotItems(2000) {}
ReturnValue DepotChe... | 1 | /**
* The Forgotten Server - a free and open-source MMORPG server emulator
* Copyright (C) 2019 Mark Samman <mark.samman@gmail.com>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; eithe... | 1 | 19,677 | here shouldn't we use `depotFreeLimit`? | otland-forgottenserver | cpp |
@@ -0,0 +1,3 @@
+# A secret token used to encrypt user_id's in the Bookmarks#export callback URL
+# functionality, for example in Refworks export of Bookmarks.
+Rails.application.config.blacklight_export_secret_token = '<%= SecureRandom.hex(64) %>' | 1 | 1 | 5,242 | Could we use the Rails application's secret token instead? Do we actually need our own here? | projectblacklight-blacklight | rb | |
@@ -80,6 +80,10 @@ class GroupByTest(ReusedSQLTestCase, TestUtils):
self.assertRaises(TypeError, lambda: kdf.a.groupby(kdf.b, as_index=False))
+ self.assertRaises(ValueError, lambda: kdf.groupby('a', axis=1))
+ self.assertRaises(ValueError, lambda: kdf.groupby('a', 'b'))
+ self.assertR... | 1 | #
# Copyright (C) 2019 Databricks, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to i... | 1 | 14,084 | so should be fixed here also | databricks-koalas | py |
@@ -6478,8 +6478,13 @@ dr_get_mcontext_priv(dcontext_t *dcontext, dr_mcontext_t *dmc, priv_mcontext_t *
* when most old clients have been converted, remove this (we'll
* still return false)
*/
- CLIENT_ASSERT(dmc->size == sizeof(dr_mcontext_t),
- "dr_mcontext_t.... | 1 | /* ******************************************************************************
* Copyright (c) 2010-2019 Google, Inc. All rights reserved.
* Copyright (c) 2010-2011 Massachusetts Institute of Technology All rights reserved.
* Copyright (c) 2002-2010 VMware, Inc. All rights reserved.
* ************************... | 1 | 17,684 | I would just remove this assert as it's going to get un-maintainable with a long list of valid sizes. Ditto below. | DynamoRIO-dynamorio | c |
@@ -28,6 +28,7 @@ func DefaultConfig() Config {
ReservedPorts: []uint16{SSHPort, DockerReservedPort, DockerReservedSSLPort, AgentIntrospectionPort, AgentCredentialsPort},
ReservedPortsUDP: []uint16{},
DataDir: "/data/",
+ HostDataDir: "/var/lib/ecs/... | 1 | // +build !windows
// Copyright 2014-2017 Amazon.com, Inc. or its affiliates. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License"). You may
// not use this file except in compliance with the License. A copy of the
// License is located at
//
// http://aws.amazon.com/apache2.0/
//
//... | 1 | 15,637 | `HostDataDir` is misleading. Can we rename it to something more relevant ? The constant should also be moved up and reused as necessary. | aws-amazon-ecs-agent | go |
@@ -37,6 +37,9 @@ const (
defaultMTUGRE = 1462
defaultMTUSTT = 1500
defaultMTU = 1500
+ // IPsec ESP can add a maximum of 38 bytes to the packet including the ESP
+ // header and trailer.
+ ipsecESPOverhead = 38
)
type Options struct { | 1 | // Copyright 2019 Antrea Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to ... | 1 | 13,177 | I still feel like we are double-counting the outer IP header here (once in `defaultMTUGRE` and once in `ipsecESPOverhead`) but I'm not that familiar with IPsec. | antrea-io-antrea | go |
@@ -14,11 +14,15 @@
// limitations under the License.
// </copyright>
-#nullable enable
+using System;
+using System.Collections.Generic;
+using System.Diagnostics.Metrics;
namespace OpenTelemetry.Metrics
{
public abstract class MeasurementProcessor : BaseProcessor<MeasurementItem>
{
+ public a... | 1 | // <copyright file="MeasurementProcessor.cs" company="OpenTelemetry Authors">
// Copyright The OpenTelemetry Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.a... | 1 | 20,223 | Not sure what benefit we gain by extending BaseProcessor here, as this seems to be defining a new OnEnd method. Could we modify MeasurementItem to have all the things, and then MeasurementProcessor can be simply extending BaseProcessor<MeasurementItem> (not blocking. just noting some observations in the PR :) ) | open-telemetry-opentelemetry-dotnet | .cs |
@@ -3,6 +3,13 @@ package cmd
import (
"bufio"
"fmt"
+ "io/ioutil"
+ "os"
+ "path"
+ "path/filepath"
+ "runtime"
+ "strings"
+
"github.com/drud/ddev/pkg/ddevapp"
"github.com/drud/ddev/pkg/exec"
"github.com/drud/ddev/pkg/fileutil" | 1 | package cmd
import (
"bufio"
"fmt"
"github.com/drud/ddev/pkg/ddevapp"
"github.com/drud/ddev/pkg/exec"
"github.com/drud/ddev/pkg/fileutil"
"github.com/drud/ddev/pkg/globalconfig"
"github.com/drud/ddev/pkg/util"
"github.com/gobuffalo/packr/v2"
"github.com/mattn/go-isatty"
"github.com/spf13/cobra"
"io/ioutil"
... | 1 | 14,642 | This change was not really intended but made by the linter of VS Code. And looking at other packages this looks like a best practise to place interal packages on the top and gh imports afterwards. | drud-ddev | go |
@@ -51,7 +51,8 @@ type Options struct {
DefaultSamplingPolicy trace.Sampler
}
-// New creates a new server. New(nil) is the same as new(Server).
+// New creates a new server. New(nil) is the same as new(Server). Note: A
+// configured Requestlogger will not log HealthChecks.
func New(opts *Options) *Server {
sr... | 1 | // Copyright 2018 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// https://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in ... | 1 | 10,759 | This seems like a more appropriate message under `ListenAndServe`. WDYT? | google-go-cloud | go |
@@ -156,7 +156,6 @@ test.suite(
await driver.get(fileServer.Pages.basicAuth)
let source = await driver.getPageSource()
assert.strictEqual(source.includes('Access granted!'), true)
- await server.stop()
})
})
| 1 | // Licensed to the Software Freedom Conservancy (SFC) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The SFC licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you m... | 1 | 18,850 | Is this not required? | SeleniumHQ-selenium | py |
@@ -360,7 +360,16 @@ class AdminController extends Controller
}
$searchableFields = $this->entity['search']['fields'];
- $paginator = $this->findBy($this->entity['class'], $this->request->query->get('query'), $searchableFields, $this->request->query->get('page', 1), $this->config['list']['max... | 1 | <?php
/*
* This file is part of the EasyAdminBundle.
*
* (c) Javier Eguiluz <javier.eguiluz@gmail.com>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/
namespace EasyCorp\Bundle\EasyAdminBundle\Controller;
use Doctrine\DBAL\Excep... | 1 | 11,163 | We should start thinking of an object that encapsulates this information :) we might need more arguments in the future. | EasyCorp-EasyAdminBundle | php |
@@ -4652,10 +4652,12 @@ TEST_F(VkLayerTest, RenderPassBarrierConflicts) {
img_barrier.subresourceRange.levelCount = 1;
// Mis-match src stage mask
m_errorMonitor->SetDesiredFailureMsg(VK_DEBUG_REPORT_ERROR_BIT_EXT, "VUID-vkCmdPipelineBarrier-srcStageMask-01173");
+ m_errorMonitor->SetDesiredFailureMsg... | 1 | /*
* Copyright (c) 2015-2017 The Khronos Group Inc.
* Copyright (c) 2015-2017 Valve Corporation
* Copyright (c) 2015-2017 LunarG, Inc.
* Copyright (c) 2015-2017 Google, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* Y... | 1 | 8,301 | Given that we are (conceptually) searching across multiple self-dependencies, all we can say is that we didn't have a self dependency in which *both* source and dest masks were correct. Since the spec doesn't imagine this case, the valid usage statement assume we can differentiate only wrong source from only wrong dest... | KhronosGroup-Vulkan-ValidationLayers | cpp |
@@ -52,11 +52,11 @@ public class EthMiningTest {
public void shouldReturnTrueWhenMiningCoordinatorExistsAndRunning() {
final JsonRpcRequest request = requestWithParams();
final JsonRpcResponse expectedResponse = new JsonRpcSuccessResponse(request.getId(), true);
- when(miningCoordinator.isRunning()).the... | 1 | /*
* Copyright ConsenSys AG.
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing... | 1 | 20,034 | rename? MiningCoordinator always exists | hyperledger-besu | java |
@@ -8,7 +8,8 @@
var ip = {},
net = require('net'),
extIP = require('external-ip'),
- plugins = require('../../../plugins/pluginManager.js');
+ plugins = require('../../../plugins/pluginManager.js'),
+ offlineMode = plugins.getConfig("api").offline_mode;
/**
* Function to get the hostname/ip add... | 1 | /**
* Module returning hostname value
* @module api/parts/mgmt/ip
*/
/** @lends module:api/parts/mgmt/ip */
var ip = {},
net = require('net'),
extIP = require('external-ip'),
plugins = require('../../../plugins/pluginManager.js');
/**
* Function to get the hostname/ip address/url to access dashboard
* ... | 1 | 13,365 | Here would be the same case you don't need to call `loadConfigs`, but you would need to reread configs using `getConfig` on each getHost function call, not once per file. | Countly-countly-server | js |
@@ -486,6 +486,8 @@ func (d *Dir) Cleanup(ctx context.Context, fi *dokan.FileInfo) {
defer func() { d.folder.reportErr(ctx, libkbfs.WriteMode, err) }()
if fi != nil && fi.IsDeleteOnClose() && d.parent != nil {
+ d.folder.fs.renameAndDeletionLock.Lock()
+ defer d.folder.fs.renameAndDeletionLock.Unlock()
d.fol... | 1 | // Copyright 2016 Keybase Inc. All rights reserved.
// Use of this source code is governed by a BSD
// license that can be found in the LICENSE file.
package libdokan
import (
"fmt"
"strings"
"sync"
"time"
"github.com/keybase/kbfs/dokan"
"github.com/keybase/kbfs/libfs"
"github.com/keybase/kbfs/libkbfs"
"gola... | 1 | 13,598 | Unlocking with defer means that this lock is still held curing the call to forgetNode(), below, which I see attempts to acquire `f.mu`, which looks dangerous to me. | keybase-kbfs | go |
@@ -56,7 +56,7 @@ func Test_Mine(t *testing.T) {
baseBlock := &block.Block{Height: 2, StateRoot: stateRoot, Tickets: []block.Ticket{{VRFProof: []byte{0}}}}
tipSet := th.RequireNewTipSet(t, baseBlock)
- st, pool, addrs, cst, bs := sharedSetup(t, mockSignerVal)
+ st, pool, addrs, _, bs := sharedSetup(t, mockSignerV... | 1 | package mining_test
import (
"context"
"errors"
"testing"
"time"
"github.com/filecoin-project/go-bls-sigs"
"github.com/filecoin-project/go-filecoin/block"
"github.com/ipfs/go-cid"
"github.com/ipfs/go-datastore"
"github.com/ipfs/go-hamt-ipld"
"github.com/ipfs/go-ipfs-blockstore"
"github.com/stretchr/testif... | 1 | 21,912 | Does anyone still use the cst out of this method? If not consider deleting | filecoin-project-venus | go |
@@ -9,6 +9,7 @@ get(
"/getting-started-with-ios-development?utm_source=podcast"
)
)
+get "/videos/vim-for-rails-developers" => redirect("https://www.youtube.com/watch?v=9J2OjH8Ao_A")
get "/humans-present/oss" => redirect( "https://www.youtube.com/watch?v=VMBhumlUP-A")
get "/ios-on-rails" => redirect("https:/... | 1 | get "/5by5" => redirect("/design-for-developers?utm_source=5by5")
get "/:id/articles" => redirect("http://robots.thoughtbot.com/tags/%{id}")
get "/backbone-js-on-rails" => redirect("https://gumroad.com/l/backbone-js-on-rails")
get "/courses/:id" => redirect("/%{id}")
get "/d4d-resources" => redirect("/design-for-develo... | 1 | 15,166 | Line is too long. [97/80] | thoughtbot-upcase | rb |
@@ -1,12 +1,14 @@
""" Testing for data_transfer.py """
### Python imports
+from io import BytesIO
import pathlib
from unittest import mock
### Third-party imports
from botocore.stub import ANY
+from botocore.exceptions import ReadTimeoutError
import pandas as pd
import pytest
| 1 | """ Testing for data_transfer.py """
### Python imports
import pathlib
from unittest import mock
### Third-party imports
from botocore.stub import ANY
import pandas as pd
import pytest
### Project imports
from quilt3 import data_transfer
from quilt3.util import PhysicalKey
from .utils import QuiltTestCase
### Cod... | 1 | 18,320 | This seems unused. | quiltdata-quilt | py |
@@ -184,8 +184,8 @@ func GetOSInterface() types.OSTypeInstaller {
case CentOSType:
return &CentOS{}
default:
+ panic("unsupport os-release")
}
- return nil
}
//IsKubeEdgeController identifies if the node is having edge controller and k8s api-server already running. | 1 | /*
Copyright 2019 The Kubeedge Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, so... | 1 | 12,834 | @luguanglong , Thanks for the fix, can you re-phrase it to sound better something like "This OS version is currently un-supported by keadm" | kubeedge-kubeedge | go |
@@ -53,6 +53,10 @@ from rdkit.Chem.Draw import rdMolDraw2D
from rdkit.Chem import rdDepictor
from rdkit.Chem import rdMolDescriptors as rdMD
+def _CleanFpInfoAttr_(mol):
+ if hasattr(mol, '_fpInfo'):
+ delattr(mol, '_fpInfo')
+
def GetAtomicWeightsForFingerprint(refMol, probeMol, fpFunction, metric=DataStruc... | 1 | #
# Copyright (c) 2013, Novartis Institutes for BioMedical Research Inc.
# Copyright (c) 2021, Greg Landrum
# All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions are
# met:
#
# * Redistributions of source... | 1 | 24,000 | should probably be called `_DeleteFpInfoAttr` because it removes it. Cleaning gives the impression it is still there. I would also move this to the end of the function `GetAtomicWeightsForFingerprint`. | rdkit-rdkit | cpp |
@@ -7101,6 +7101,13 @@ bool CoreChecks::PreCallValidateCmdBindDescriptorSets(VkCommandBuffer commandBuf
"(%zu) when pipeline layout was created",
firstSet, setCount, pipeline_layout->set_layouts.size());
}
+
+ static const std::map<VkPipelineBindPoint, std::st... | 1 | /* Copyright (c) 2015-2021 The Khronos Group Inc.
* Copyright (c) 2015-2021 Valve Corporation
* Copyright (c) 2015-2021 LunarG, Inc.
* Copyright (C) 2015-2021 Google Inc.
* Modifications Copyright (C) 2020-2021 Advanced Micro Devices, Inc. All rights reserved.
*
* Licensed under the Apache License, Version 2.0 (t... | 1 | 18,127 | nit, can we use `VK_PIPELINE_BIND_POINT_RAY_TRACING_KHR` here (granted it isn't else where, maybe worth fixing here or in separate PR) | KhronosGroup-Vulkan-ValidationLayers | cpp |
@@ -23,6 +23,6 @@ class Api::V1::ExercisesController < ApiController
end
def exercise_parameters
- params.require(:exercise).permit(:edit_url, :summary, :title, :url)
+ params.require(:exercise).permit(:edit_url, :summary, :name, :url)
end
end | 1 | class Api::V1::ExercisesController < ApiController
before_action :doorkeeper_authorize!
skip_before_filter :verify_authenticity_token
def update
if authenticated_via_client_credentials_token?
exercise = Exercise.find_or_initialize_by(uuid: params[:id])
if exercise.update_attributes(exercise_para... | 1 | 13,925 | This will need to be updated in the upcase-exercises repo as well. | thoughtbot-upcase | rb |
@@ -21,7 +21,7 @@ class Trail < ActiveRecord::Base
def steps_remaining_for(user)
ExerciseWithProgressQuery.
new(user: user, exercises: exercises).
- count { |exercise| exercise.state != Status::REVIEWED }
+ count { |exercise| exercise.state != Status::COMPLETE }
end
def self.most_recent... | 1 | class Trail < ActiveRecord::Base
extend FriendlyId
validates :name, :description, presence: true
has_many :steps, -> { order "position ASC" }, dependent: :destroy
has_many :exercises, through: :steps
friendly_id :name, use: [:slugged, :finders]
# Override setters so it preserves the ordering
def exerc... | 1 | 12,461 | Think it's worth extracting this to `Exercise#complete?`? | thoughtbot-upcase | rb |
@@ -87,14 +87,6 @@ class Currency
return $this->exchangeRate;
}
- /**
- * @return string
- */
- public function getReversedExchangeRate()
- {
- return 1 / $this->exchangeRate;
- }
-
/**
* @param string $exchangeRate
*/ | 1 | <?php
namespace Shopsys\FrameworkBundle\Model\Pricing\Currency;
use Doctrine\ORM\Mapping as ORM;
/**
* @ORM\Table(name="currencies")
* @ORM\Entity
*/
class Currency
{
const CODE_CZK = 'CZK';
const CODE_EUR = 'EUR';
const DEFAULT_EXCHANGE_RATE = 1;
/**
* @var int
*
* @ORM\Column(ty... | 1 | 12,682 | This is still a potentially useful public method - should we remove such methods? | shopsys-shopsys | php |
@@ -40,15 +40,9 @@ public abstract class ApiDefaultsConfig {
/** The name of the license of the client library. */
public abstract String licenseName();
- protected abstract Map<TargetLanguage, ReleaseLevel> releaseLevel();
-
/** The development status of the client library. Configured per language. */
- p... | 1 | /* Copyright 2018 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in... | 1 | 25,626 | I don't understand this change, what is happening here? | googleapis-gapic-generator | java |
@@ -944,7 +944,8 @@ class ExcelCellTextInfo(NVDAObjectTextInfo):
def _getFormatFieldAndOffsets(self,offset,formatConfig,calculateOffsets=True):
formatField=textInfos.FormatField()
- if (self.obj.excelCellObject.Application.Version > "12.0"):
+ version=int(self.obj.excelCellObject.Application.Version.split('.')... | 1 | #NVDAObjects/excel.py
#A part of NonVisual Desktop Access (NVDA)
#Copyright (C) 2006-2016 NV Access Limited, Dinesh Kaushal, Siddhartha Gupta
#This file is covered by the GNU General Public License.
#See the file COPYING for more details.
from comtypes import COMError
import comtypes.automation
import wx
impo... | 1 | 19,830 | I think its worth stating this is `versionMajor` | nvaccess-nvda | py |
@@ -375,3 +375,14 @@ func (nc NodeController) readGenesisJSON(genesisFile string) (genesisLedger book
err = protocol.DecodeJSON(genesisText, &genesisLedger)
return
}
+
+// SetConsensus applies a new consensus settings which would get deployed before
+// any of the nodes starts
+func (nc NodeController) SetConsensu... | 1 | // Copyright (C) 2019-2020 Algorand, Inc.
// This file is part of go-algorand
//
// go-algorand is free software: you can redistribute it and/or modify
// it under the terms of the GNU Affero General Public License as
// published by the Free Software Foundation, either version 3 of the
// License, or (at your option) ... | 1 | 37,409 | rebuild: say loads and merges | algorand-go-algorand | go |
@@ -20,7 +20,6 @@
* External dependencies
*/
import { getDefaultOptions } from 'expect-puppeteer';
-import { Page, ElementHandle } from 'puppeteer';
/**
* Jest matcher for asserting the given instance has tracking loaded or not. | 1 | /**
* Custom matcher for checking the presence of Site Kit event tracking.
*
* Site Kit by Google, Copyright 2020 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* h... | 1 | 30,285 | Why was this removed here (also in the other file)? Shouldn't we import them so that the reference in the docs below is interpreted correctly? | google-site-kit-wp | js |
@@ -32,13 +32,12 @@ from databricks.koalas.series import Series
class PySparkTestCase(unittest.TestCase):
-
def setUp(self):
self._old_sys_path = list(sys.path)
if SparkContext._active_spark_context is not None:
SparkContext._active_spark_context.stop()
class_name = sel... | 1 | #
# Copyright (C) 2019 Databricks, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to i... | 1 | 11,433 | I'd prefer to have a blank line between the class declaration and its first member. Is it possible? | databricks-koalas | py |
@@ -299,7 +299,7 @@ describe('Mongos SRV Polling', function () {
return records.map(r => `${r.name}:${r.port}`);
}
- const MONGOS_DEFAULT_ISMASTER = Object.assign({}, mock.DEFAULT_ISMASTER_36, {
+ const MONGOS_LEGACY_HELLO = Object.assign({}, mock.HELLO, {
msg: 'isdbgrid'
});... | 1 | 'use strict';
const { Topology } = require('../../../src/sdam/topology');
const { TopologyDescription } = require('../../../src/sdam/topology_description');
const { TopologyType } = require('../../../src/sdam/common');
const { SrvPoller, SrvPollingEvent } = require('../../../src/sdam/srv_polling');
const sdamEvents = ... | 1 | 21,278 | Is it really LEGACY_HELLO if we are using the most up to date HELLO? Perhaps `MONGOS_HELLO` would work here? | mongodb-node-mongodb-native | js |
@@ -1922,10 +1922,10 @@ detach_on_permanent_stack(bool internal, bool do_cleanup)
DEBUG_DECLARE(bool ok;)
DEBUG_DECLARE(int exit_res;)
/* synch-all flags: if we fail to suspend a thread (e.g., privilege
- * problems) ignore it. XXX Should we retry instead?
+ * problems) retry it.
*/
/... | 1 | /* **********************************************************
* Copyright (c) 2012-2017 Google, Inc. All rights reserved.
* Copyright (c) 2008-2010 VMware, Inc. All rights reserved.
* **********************************************************/
/*
* Redistribution and use in source and binary forms, with or witho... | 1 | 12,624 | I am afraid this is going to cause problems on Windows where it is not uncommon to have injected threads (CTRL_SHUTDOWN, CTRL_LOGOFF, etc.) we have no privileges to suspend -- and thus retrying will just fail again, and with the new "synchall failure is fatal and should kill the process" approach it turns what used to ... | DynamoRIO-dynamorio | c |
@@ -45,6 +45,7 @@ program
.option('-C <build_dir>', 'build config (out/Debug, out/Release')
.option('--target_arch <target_arch>', 'target architecture', 'x64')
.option('--mac_signing_identifier <id>', 'The identifier to use for signing')
+ .option('--mac_installer_signing_identifier <id>', 'The identifier to... | 1 | /* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this file,
* You can obtain one at http://mozilla.org/MPL/2.0/. */
const program = require('commander');
const path = require('path')
const fs = require('fs-extra')
const config = r... | 1 | 5,472 | think it should only be in create_dist | brave-brave-browser | js |
@@ -429,9 +429,14 @@ func (c *NPLController) handleAddUpdatePod(key string, obj interface{}) error {
podPorts[port] = struct{}{}
portData := c.portTable.GetEntryByPodIPPort(podIP, int(cport.ContainerPort))
if portData == nil { // rule does not exist
- nodePort, err = c.portTable.AddRule(podIP, port)
- ... | 1 | // +build !windows
// Copyright 2020 Antrea Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicab... | 1 | 35,093 | Do you plan to support Pod spec change? Like hostPort is added/removed later after Pod creation? | antrea-io-antrea | go |
@@ -157,13 +157,14 @@ func (tlf *TLF) GetFileInformation(ctx context.Context, fi *dokan.FileInfo) (st
}
// open tries to open a file.
-func (tlf *TLF) open(ctx context.Context, oc *openContext, path []string) (dokan.File, bool, error) {
+func (tlf *TLF) open(ctx context.Context, oc *openContext, path []string) (
+ ... | 1 | // Copyright 2016 Keybase Inc. All rights reserved.
// Use of this source code is governed by a BSD
// license that can be found in the LICENSE file.
package libdokan
import (
"sync"
"time"
"github.com/keybase/kbfs/dokan"
"github.com/keybase/kbfs/libfs"
"github.com/keybase/kbfs/libkbfs"
"github.com/keybase/kbf... | 1 | 19,468 | Is this behavior correct? It used to return `true`, which should map to `dokan.ExistingDir`. Was that previously a bug? | keybase-kbfs | go |
@@ -27,7 +27,11 @@ void deleteRegion(const storage::SharedRegionRegister::ShmKey key)
void listRegions()
{
-
+ if (!storage::SharedMonitor<storage::SharedRegionRegister>::exists())
+ {
+ osrm::util::Log() << "No shared memory regions found. Try running osrm-datastore";
+ return;
+ }
stor... | 1 | #include "storage/shared_memory.hpp"
#include "storage/shared_monitor.hpp"
#include "storage/storage.hpp"
#include "osrm/exception.hpp"
#include "util/log.hpp"
#include "util/meminfo.hpp"
#include "util/typedefs.hpp"
#include "util/version.hpp"
#include <boost/filesystem.hpp>
#include <boost/program_options.hpp>
#inc... | 1 | 23,691 | What about just printing an empty list in this case? That would make the output more predictable. | Project-OSRM-osrm-backend | cpp |
@@ -24,7 +24,6 @@ export default Component.extend({
init() {
this._super(...arguments);
- this.container = document.querySelector('.gh-editor-container')[0];
let mobiledoc = this.get('value') || BLANK_DOC;
let userCards = this.get('cards') || []; | 1 | import Component from 'ember-component';
import {A as emberA} from 'ember-array/utils';
import run from 'ember-runloop';
import layout from '../templates/components/gh-koenig';
import Mobiledoc from 'mobiledoc-kit';
import {MOBILEDOC_VERSION} from 'mobiledoc-kit/renderers/mobiledoc';
import createCardFactory from '../l... | 1 | 7,925 | I looked and couldn't find any usage of `container` in any of the editor component files (js or hbs), so I assume this was used once and didn't get removed? | TryGhost-Admin | js |
@@ -256,11 +256,11 @@ function roots_request_filter($query_vars) {
add_filter('request', 'roots_request_filter');
/**
- * Tell WordPress to use searchform.php from the templates/ directory
+ * Tell WordPress to use searchform.php from the templates/ directory. Requires WordPress 3.6+
*/
-function roots_get_search... | 1 | <?php
/**
* Clean up wp_head()
*
* Remove unnecessary <link>'s
* Remove inline CSS used by Recent Comments widget
* Remove inline CSS used by posts with galleries
* Remove self-closing tag and change ''s to "'s on rel_canonical()
*/
function roots_head_cleanup() {
// Originally from http://wpengineer.com/1438/... | 1 | 7,968 | I just updated a number of sites using older versions of Roots onto WP 3.6 and this little function change was required. Multiple search bars were displaying when I used the search widget in a widgetized sidebar. Updated the roots_get_search_form as seen in this change resolved it for me! | roots-sage | php |
@@ -19,6 +19,7 @@ use Thelia\Condition\ConditionEvaluator;
use Thelia\Condition\Implementation\MatchForTotalAmount;
use Thelia\Condition\Operators;
use Thelia\Coupon\FacadeInterface;
+use Thelia\Coupon\Type\FreeProduct;
use Thelia\Model\CartItem;
use Thelia\Model\CountryQuery;
use Thelia\Model\CurrencyQuery; | 1 | <?php
/*************************************************************************************/
/* This file is part of the Thelia package. */
/* */
/* Copyright (c) OpenStudio ... | 1 | 12,258 | Fixes test failed in some cases | thelia-thelia | php |
@@ -23,9 +23,7 @@ module.exports = [
'https://balance-staging.mercury.basicattentiontoken.org/',
'https://publishers.basicattentiontoken.org/',
'https://publishers-staging.basicattentiontoken.org/',
- 'https://updates.bravesoftware.com/', // remove this once updates are moved to the prod environment
- 'https... | 1 | // Before adding to this list, get approval from the security team
module.exports = [
'http://update.googleapis.com/service/update2', // allowed because it 307's to go-updater.brave.com. should never actually connect to googleapis.com.
'https://update.googleapis.com/service/update2', // allowed because it 307's to ... | 1 | 6,366 | what's the prod url for this? just curious. @amirsaber | brave-brave-browser | js |
@@ -153,6 +153,12 @@ public class Constants {
// Overridable plugin load properties
public static final String AZ_PLUGIN_LOAD_OVERRIDE_PROPS = "azkaban.plugin.load.override.props";
+ // Append JVM args to job commands
+ public static final String AZ_JOB_COMMAND_ARGS = "azkaban.jvm.cmd.args";
+
+ // Ignore th... | 1 | /*
* Copyright 2018 LinkedIn Corp.
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not
* use this file except in compliance with the License. You may obtain a copy of
* the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to i... | 1 | 22,874 | Can you please change this to azkaban.jobs.java.opts? | azkaban-azkaban | java |
@@ -66,11 +66,10 @@ function AcquisitionPieChart( { data, args, source } ) {
let sourceMessage = '';
if ( source ) {
- sourceMessage = sprintf(
- /* translators: %1$s: URL to Analytics Module page in Site Kit Admin, %2$s: Analytics (Service Name) */
- __( 'Source: <a class="googlesitekit-cta-link googlesitek... | 1 | /**
* AcquisitionPieChart component.
*
* Site Kit by Google, Copyright 2020 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE... | 1 | 32,232 | Here is another concatenation which should be updated. Even though `Source:` and the link are essentially separate, it isn't RTL friendly. This would be another good use for `createInterpolateElement` I think so that we wouldn't need to include all of the classnames in the translation string (or extract them to a place... | google-site-kit-wp | js |
@@ -26,12 +26,15 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Infrastructure
#endif
}
- public static Task<int> GetCancelledZeroTask()
+ public static Task<int> GetCancelledZeroTask(CancellationToken cancellationToken = default(CancellationToken))
{
- // Task<int>.FromC... | 1 | // Copyright (c) .NET Foundation. All rights reserved.
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
using System.Threading;
using System.Threading.Tasks;
namespace Microsoft.AspNetCore.Server.Kestrel.Infrastructure
{
public static class TaskUtilit... | 1 | 8,668 | I would add an overload `GetCancelledZeroTask()` which calls `GetCancelledZeroTask(CancellationToken.None)`. This is cleaner than requiring the caller to pass `default(CancellationToken)` or `CancellationToken.None`. | aspnet-KestrelHttpServer | .cs |
@@ -295,9 +295,13 @@ void BestPractices::PreCallRecordDestroyImage(VkDevice device, VkImage image, co
}
void BestPractices::PreCallRecordDestroySwapchainKHR(VkDevice device, VkSwapchainKHR swapchain, const VkAllocationCallbacks* pAllocator) {
- SWAPCHAIN_NODE* chain = GetSwapchainState(swapchain);
- for (auto... | 1 | /* Copyright (c) 2015-2021 The Khronos Group Inc.
* Copyright (c) 2015-2021 Valve Corporation
* Copyright (c) 2015-2021 LunarG, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
... | 1 | 16,716 | Would it be equivalent to check if `chain != nullptr` below? Not suggesting a change, just curious. | KhronosGroup-Vulkan-ValidationLayers | cpp |
@@ -1131,9 +1131,10 @@ bool nano::wallet::change_sync (nano::account const & source_a, nano::account co
void nano::wallet::change_async (nano::account const & source_a, nano::account const & representative_a, std::function<void(std::shared_ptr<nano::block>)> const & action_a, uint64_t work_a, bool generate_work_a)
... | 1 | #include <nano/node/wallet.hpp>
#include <nano/crypto_lib/random_pool.hpp>
#include <nano/lib/utility.hpp>
#include <nano/node/node.hpp>
#include <nano/node/wallet.hpp>
#include <nano/node/xorshift.hpp>
#include <argon2.h>
#include <boost/filesystem.hpp>
#include <boost/polymorphic_cast.hpp>
#include <future>
nano... | 1 | 15,337 | Should probably do `auto this_l (shared_from_this ());` and pass/use that instead of `this`. Same a few other places. IOW, replace both `shared_from_this()` and `this` with `this_l` | nanocurrency-nano-node | cpp |
@@ -55,7 +55,8 @@ module.exports = iterateJsdoc(
) {
context.report( {
data: { name: jsdocNode.name },
- message: `The first word in a function's description should be a third-person verb (eg "runs" not "run").`,
+ message:
+ 'The first word in a function\'s description should be a third-person ve... | 1 | /**
* ESLint rules: verb form.
*
* Site Kit by Google, Copyright 2021 Google LLC
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
... | 1 | 42,326 | And here. Please, use `'` for apostrophes in changed strings in this file. | google-site-kit-wp | js |
@@ -100,7 +100,7 @@ func (gs *GasStation) EstimateGasForAction(actPb *iotextypes.Action) (uint64, er
if err != nil {
return 0, err
}
- _, receipt, err := gs.bc.ExecuteContractRead(callerAddr, sc)
+ _, receipt, err := gs.bc.SimulateExecution(callerAddr, sc)
if err != nil {
return 0, err
} | 1 | // Copyright (c) 2019 IoTeX Foundation
// This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no
// warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent
// permitted by law, all liability for your use... | 1 | 19,514 | assignments should only be cuddled with other assignments (from `wsl`) | iotexproject-iotex-core | go |
@@ -504,7 +504,15 @@ func (c *ConfigLocal) MetadataVersion() MetadataVer {
// DataVersion implements the Config interface for ConfigLocal.
func (c *ConfigLocal) DataVersion() DataVer {
- return 1
+ return FilesWithHolesDataVer
+}
+
+// DefaultNewBlockDataVersion returns the default data version for new blocks.
+fun... | 1 | // Copyright 2016 Keybase Inc. All rights reserved.
// Use of this source code is governed by a BSD
// license that can be found in the LICENSE file.
package libkbfs
import (
"sync"
"time"
"github.com/keybase/client/go/libkb"
"github.com/keybase/client/go/logger"
keybase1 "github.com/keybase/client/go/protocol"... | 1 | 11,309 | Please move this to `block_types.go`. | keybase-kbfs | go |
@@ -40,9 +40,6 @@ namespace NLog.Layouts
/// JSON attribute.
/// </summary>
[NLogConfigurationItem]
- [ThreadAgnostic]
- [ThreadSafe]
- [AppDomainFixedOutput]
public class JsonAttribute
{
/// <summary> | 1 | //
// Copyright (c) 2004-2020 Jaroslaw Kowalski <jaak@jkowalski.net>, Kim Christensen, Julian Verdurmen
//
// All rights reserved.
//
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions
// are met:
//
// * Redistributions of s... | 1 | 21,267 | So this is not needed anymore for all attributes? | NLog-NLog | .cs |
@@ -46,13 +46,13 @@ namespace OpenTelemetry.Extensions.Hosting.Implementation
}
}
- [Event(1, Message = "Failed to initialize: '{0}'. OpenTelemetry will not work.", Level = EventLevel.Error)]
+ [Event(1, Message = "An exception occured while adding OpenTelemetry Tracing to ServiceC... | 1 | // <copyright file="HostingExtensionsEventSource.cs" company="OpenTelemetry Authors">
// Copyright The OpenTelemetry Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// htt... | 1 | 16,906 | Happy to get suggestion for better messaging here. Here's what I intended to convey: Something is wrong - the Exception is a hint to what might be the cause The impact of that - tracing wont work. | open-telemetry-opentelemetry-dotnet | .cs |
@@ -108,6 +108,11 @@ def start_acm(port=None, asynchronous=False):
return start_moto_server('acm', port, name='ACM', asynchronous=asynchronous)
+def start_ses(port=None, asynchronous=False, update_listener=None):
+ port = port or config.PORT_SES
+ return start_moto_server('ses', port, name='SES', asynchr... | 1 | # noqa
import os
import re
import sys
import json
import time
import signal
import logging
import traceback
import boto3
import subprocess
from moto import core as moto_core
from requests.models import Response
from localstack import config, constants
from localstack.utils import common, persistence
from localstack.con... | 1 | 11,990 | I think we can remove this function, right? (duplicate with `ses_starter.py`) | localstack-localstack | py |
@@ -195,6 +195,10 @@ class PandasLikeSeries(_Frame):
"Field {} not found, possible values are {}".format(name, ", ".join(fnames)))
return anchor_wrap(self, self._spark_getField(name))
+ # TODO: automate the process here
+ def alias(self, name):
+ return self.rename(name)... | 1 | #
# Copyright (C) 2019 Databricks, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to i... | 1 | 8,227 | With this fix, I am not even sure we need to overwrite this function. | databricks-koalas | py |
@@ -311,6 +311,8 @@ class PackageEntry(object):
class Package(object):
""" In-memory representation of a package """
+ use_tqdm = os.getenv('QUILT_USE_TQDM').lower() == 'true'
+
def __init__(self):
self._children = {}
self._meta = {'version': 'v0'} | 1 | from collections import deque
import gc
import hashlib
import io
import json
import pathlib
import os
import re
import shutil
import time
from multiprocessing import Pool
import uuid
import warnings
import jsonlines
from tenacity import retry, stop_after_attempt, wait_exponential
from tqdm import tqdm
from .data_tran... | 1 | 18,409 | Why not just import this from `data_transfer`? As a rule copying the same code twice is not a good idea. Also: please run `pylint` on all files in this PR. | quiltdata-quilt | py |
@@ -99,7 +99,7 @@ module Beaker
it "can correctly combine arguments from different sources" do
FakeFS.deactivate!
args = ["-h", hosts_path, "--debug", "--type", "git", "--install", "PUPPET/1.0,HIERA/hello"]
- expect(parser.parse_args(args)).to be === {:hosts_file=>hosts_path, :options_fi... | 1 | require "spec_helper"
module Beaker
module Options
describe Parser do
let(:parser) { Parser.new }
let(:opts_path) { File.join(File.expand_path(File.dirname(__FILE__)), "data", "opts.txt") }
let(:hosts_path) { File.join(File.expand_path(File.dirname(__FILE__)), "data", "hosts.cfg") }
... | 1 | 4,595 | You've got an absolute path here referencing your home dir :-). | voxpupuli-beaker | rb |
@@ -526,10 +526,10 @@ public final class JavaParserMetaModel {
unaryExprMetaModel.getDeclaredPropertyMetaModels().add(unaryExprMetaModel.expressionPropertyMetaModel);
unaryExprMetaModel.operatorPropertyMetaModel = new PropertyMetaModel(unaryExprMetaModel, "operator", com.github.javaparser.ast.expr.Una... | 1 | package com.github.javaparser.metamodel;
import com.github.javaparser.ast.*;
import java.util.ArrayList;
import java.util.List;
import java.util.Optional;
/**
* The model contains meta-data about all nodes in the AST.
*/
public final class JavaParserMetaModel {
private JavaParserMetaModel() {
}
privat... | 1 | 10,635 | Maybe I should do some sorting so that these properties don't keep moving around... | javaparser-javaparser | java |
@@ -32,14 +32,6 @@ func TestCheckMountDestFalsePositive(t *testing.T) {
}
}
-func TestCheckMountRoot(t *testing.T) {
- dest := "/rootfs"
- err := checkMountDestination("/rootfs", dest)
- if err == nil {
- t.Fatal(err)
- }
-}
-
func TestNeedsSetupDev(t *testing.T) {
config := &configs.Config{
Mounts: []*conf... | 1 | // +build linux
package libcontainer
import (
"testing"
"github.com/opencontainers/runc/libcontainer/configs"
)
func TestCheckMountDestOnProc(t *testing.T) {
dest := "/rootfs/proc/"
err := checkMountDestination("/rootfs", dest)
if err == nil {
t.Fatal("destination inside proc should return an error")
}
}
f... | 1 | 12,922 | Can we keep this test anyway, as it's part of the spec? | opencontainers-runc | go |
@@ -0,0 +1,19 @@
+<?php
+
+/**
+ * Copyright © Bold Brand Commerce Sp. z o.o. All rights reserved.
+ * See license.txt for license details.
+ */
+
+declare(strict_types = 1);
+
+namespace Ergonode\Mailer;
+
+use Ergonode\Mailer\Application\DependencyInjection\CompilerPass\MailerStrategyInterfaceCompilerPass;
+use Ergon... | 1 | 1 | 8,865 | Can be removed | ergonode-backend | php | |
@@ -1,5 +1,7 @@
<?php namespace System\Controllers;
+use Config;
+use Request;
use Lang;
use Flash;
use Backend; | 1 | <?php namespace System\Controllers;
use Lang;
use Flash;
use Backend;
use BackendMenu;
use System\Classes\SettingsManager;
use Backend\Classes\Controller;
use ApplicationException;
use Exception;
/**
* Settings controller
*
* @package october\system
* @author Alexey Bobkov, Samuel Georges
*
*/
class Settings ex... | 1 | 18,863 | It's a minor quibble I know, but I like having the imports ordered by lengt | octobercms-october | php |
@@ -216,7 +216,7 @@ public abstract class AbstractRestInvocation {
}
}
responseEx.setStatus(response.getStatusCode(), response.getReasonPhrase());
- responseEx.setContentType(produceProcessor.getName());
+ responseEx.setContentType(produceProcessor.getName()+"; charset=utf-8");
Object body... | 1 | /*
* Copyright 2017 Huawei Technologies Co., Ltd
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law ... | 1 | 7,961 | It's better to get the charset from context or other setting to let the user override it. | apache-servicecomb-java-chassis | java |
@@ -70,7 +70,7 @@ func NewCStorPoolController(
cStorInformerFactory informers.SharedInformerFactory) *CStorPoolController {
// obtain references to shared index informers for the cStorPool resources
- cStorPoolInformer := cStorInformerFactory.Openebs().V1alpha1().NewTestCStorPools()
+ cStorPoolInformer := cStorIn... | 1 | /*
Copyright 2018 The OpenEBS Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, sof... | 1 | 17,144 | this filename as well needs change | openebs-maya | go |
@@ -179,10 +179,11 @@ type ACMEIssuerDNS01ProviderCloudflare struct {
// ACMEIssuerDNS01ProviderRoute53 is a structure containing the Route 53
// configuration for AWS
type ACMEIssuerDNS01ProviderRoute53 struct {
- AccessKeyID string `json:"accessKeyID"`
- SecretAccessKey SecretKeySelector `json:"secr... | 1 | /*
Copyright 2017 The Kubernetes Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, ... | 1 | 11,039 | I think we want to remove `omitempty` here | jetstack-cert-manager | go |
@@ -129,6 +129,8 @@ func startContainer(context *cli.Context, spec *specs.LinuxSpec) (int, error) {
if err != nil {
return -1, err
}
+ handler := newSignalHandler(tty)
+ defer handler.Close()
if err := container.Start(process); err != nil {
return -1, err
} | 1 | // +build linux
package main
import (
"fmt"
"os"
"runtime"
"syscall"
"github.com/Sirupsen/logrus"
"github.com/codegangsta/cli"
"github.com/coreos/go-systemd/activation"
"github.com/opencontainers/runc/libcontainer"
"github.com/opencontainers/specs"
)
// default action is to start a container
var startComma... | 1 | 9,732 | You cannot move this here because it breaks detach. Just call `tty.Close()` before returning the error from start | opencontainers-runc | go |
@@ -376,8 +376,7 @@ lookupTables.role = {
one: ['rowgroup', 'row']
},
nameFrom: ['author'],
- context: null,
- implicit: ['table']
+ context: null
},
'gridcell': {
type: 'widget', | 1 | /**
* Namespace for aria-related utilities.
* @namespace commons.aria
* @memberof axe
*/
var aria = commons.aria = {},
lookupTables = aria._lut = {};
lookupTables.attributes = {
'aria-activedescendant': {
type: 'idref'
},
'aria-atomic': {
type: 'boolean',
values: ['true', 'false']
},
'aria-autocomplet... | 1 | 11,786 | I updated only the implicit roles who needed a update for this new rule to validate. | dequelabs-axe-core | js |
@@ -7,11 +7,12 @@
package pb
import (
+ reflect "reflect"
+ sync "sync"
+
proto "github.com/golang/protobuf/proto"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
)
const ( | 1 | // Code generated by protoc-gen-go. DO NOT EDIT.
// versions:
// protoc-gen-go v1.22.0
// protoc v3.7.1
// source: payment.proto
package pb
import (
proto "github.com/golang/protobuf/proto"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoim... | 1 | 16,515 | > // Code generated by protoc-gen-go. DO NOT EDIT. | mysteriumnetwork-node | go |
@@ -46,6 +46,9 @@ var (
utils.GcloudProdWrapperLatest: "gcloud",
utils.GcloudLatestWrapperLatest: "gcloud",
}
+ // Apply this as instance metadata if the OS config agent is not
+ // supported for the platform or version being imported.
+ skipOSConfig = map[string]string{"osconfig_not_supported": "true"}
)
... | 1 | // Copyright 2019 Google Inc. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by appl... | 1 | 11,954 | minor: skipOSConfigMetadata, otherwise, the name sounds like a boolean | GoogleCloudPlatform-compute-image-tools | go |
@@ -56,7 +56,9 @@ public class NSRSS20 extends Namespace {
boolean validType = false;
boolean validUrl = !TextUtils.isEmpty(url);
- if (type == null) {
+ if(SyndTypeUtils.enclosureTypeValid(type)) {
+ validType = true;
+ } else {
type = SyndTypeUtils.getMimeTypeFromUrl(url);
}
| 1 | package de.danoeh.antennapod.core.syndication.namespace;
import android.text.TextUtils;
import android.util.Log;
import org.xml.sax.Attributes;
import de.danoeh.antennapod.core.feed.Feed;
import de.danoeh.antennapod.core.feed.FeedImage;
import de.danoeh.antennapod.core.feed.FeedItem;
import de.danoeh.antennapod.core... | 1 | 13,454 | ~~I think lines 65-67 should be moved into this else clause after `type = ...` Else, it is a bit confusing why we check the enclose type validity a second time~~ Nevermind, will do some refactoring, myself. But thanks for "fixing" this! | AntennaPod-AntennaPod | java |
@@ -239,3 +239,16 @@ func (client *Client) Stop() error {
return nil
}
+
+// GetSessions returns all sessions from history
+func (client *Client) GetSessions() (endpoints.SessionsDTO, error) {
+ response, err := client.http.Get("sessions", url.Values{})
+ if err != nil {
+ return endpoints.SessionsDTO{}, err
+ }
... | 1 | /*
* Copyright (C) 2017 The "MysteriumNetwork/node" Authors.
*
* This program is free software: you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation, either version 3 of the License, or
* (at your option) any later version.
*
... | 1 | 12,518 | `sessions := endpoints.SessionsDTO{}` and using only `sessions` should be simpler. | mysteriumnetwork-node | go |
@@ -5242,8 +5242,11 @@ master_signal_handler_C(byte *xsp)
/* Ensure we didn't get the app's sigstack into our frame. On Mac, the kernel
* doesn't use the frame's uc_stack, so we limit this to Linux.
+ * The pointers may be different if a thread is on its way to exit, and the app's
+ * sigstack was... | 1 | /* **********************************************************
* Copyright (c) 2011-2019 Google, Inc. All rights reserved.
* Copyright (c) 2000-2010 VMware, Inc. All rights reserved.
* **********************************************************/
/*
* Redistribution and use in source and binary forms, with or witho... | 1 | 15,464 | These need to be in the other order to avoid crashing when dcontext == GLOBAL_DCONTEXT (==-1) | DynamoRIO-dynamorio | c |
@@ -24,7 +24,8 @@ namespace Http2SampleApp
factory.SetMinimumLevel(LogLevel.Trace);
factory.AddConsole();
})
- .UseKestrel((context, options) =>
+ .UseKestrel()
+ .ConfigureKestrel((context, options) =>
... | 1 | using System;
using System.IO;
using System.Net;
using System.Security.Authentication;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Connections.Features;
using Microsoft.AspNetCore.Hosting;
using Microsoft.AspNetCore.Server.Kestrel.Core;
using Microsoft.AspNetCore.Server.Kestrel.Core.Adapter.Internal;
using... | 1 | 16,140 | Why not change the other samples? | aspnet-KestrelHttpServer | .cs |
@@ -10,8 +10,9 @@ table.isHeader = function (cell) {
return true;
}
- if (cell.id) {
- return !!document.querySelector('[headers~="' + axe.utils.escapeSelector(cell.id) + '"]');
+ if (cell.getAttribute('id')) {
+ const id = axe.utils.escapeSelector(cell.getAttribute('id'));
+ return !!document.querySelector... | 1 | /*global table, axe */
/**
* Determine if a `HTMLTableCellElement` is a header
* @param {HTMLTableCellElement} node The table cell to test
* @return {Boolean}
*/
table.isHeader = function (cell) {
if (table.isColumnHeader(cell) || table.isRowHeader(cell)) {
return true;
}
if (cell.id) {
return !!document... | 1 | 11,199 | Indentation is mixed up here due to spaces/tabs, I'm guessing. | dequelabs-axe-core | js |
@@ -738,9 +738,15 @@ static fpga_result poll_interrupt(fpga_dma_handle dma_h) {
res = FPGA_EXCEPTION;
} else {
uint64_t count = 0;
- read(pfd.fd, &count, sizeof(count));
- debug_print("Poll success. Return = %d, count = %d\n",poll_res, (int)count);
- res = FPGA_OK;
+ ssize_t bytes_read = read(pfd.fd, &count... | 1 | // Copyright(c) 2017, Intel Corporation
//
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions are met:
//
// * Redistributions of source code must retain the above copyright notice,
// this list of conditions and the ... | 1 | 15,046 | Should we provide a little more context in the error message? Maybe throw in something about what operation was being performed? | OPAE-opae-sdk | c |
@@ -138,7 +138,10 @@ class PluginBase extends ServiceProviderBase
*/
public function registerSettings()
{
- return [];
+ $configuration = $this->getConfigurationFromYaml();
+ if (array_key_exists('settings', $configuration)) {
+ return $configuration['settings'];
+ }
}
/** | 1 | <?php namespace System\Classes;
use Illuminate\Support\ServiceProvider as ServiceProviderBase;
use ReflectionClass;
use SystemException;
use Yaml;
use Backend;
/**
* Plugin base class
*
* @package october\system
* @author Alexey Bobkov, Samuel Georges
*/
class PluginBase extends ServiceProviderBase
{
/**
... | 1 | 12,031 | Project standard is spaces, not tabs. Please fix and then we can merge this. | octobercms-october | php |
@@ -1,12 +1,14 @@
#include "dynamic_zone.h"
-#include "expedition.h"
-#include "expedition_state.h"
+#include "cliententry.h"
+#include "clientlist.h"
+#include "dynamic_zone_manager.h"
#include "worlddb.h"
#include "zonelist.h"
#include "zoneserver.h"
#include "../common/eqemu_logsys.h"
#include "../common/repos... | 1 | #include "dynamic_zone.h"
#include "expedition.h"
#include "expedition_state.h"
#include "worlddb.h"
#include "zonelist.h"
#include "zoneserver.h"
#include "../common/eqemu_logsys.h"
#include "../common/repositories/instance_list_repository.h"
extern ZSList zoneserver_list;
Database& DynamicZone::GetDatabase()
{
ret... | 1 | 10,537 | @hgtw is there anything we're worried about with regards to using this cache? Do we want to do staged testing around expeditions before we merge? Curious your thoughts here | EQEmu-Server | cpp |
@@ -226,11 +226,11 @@ public class ManifestReader extends CloseableGroup implements Filterable<Filtere
@Override
public Iterator<DataFile> iterator() {
- return iterator(alwaysTrue(), fileSchema);
+ return iterator(fileSchema);
}
// visible for use by PartialManifest
- Iterator<DataFile> iterator... | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you ... | 1 | 17,506 | The purpose of this was to allow pushing filters into the manifest files if we ever use a format other than Parquet. I think overall this is a good change because we can add it back later. Just wanted to note why the unused argument was there. | apache-iceberg | java |
@@ -24,7 +24,15 @@ module Mongoid
# @since 1.0.0
def evolve(object)
__evolve__(object) do |obj|
- obj ? obj.to_s : obj
+ if obj
+ if obj.is_a?(::BigDecimal) && Mongoid.map_big_decimal_to_decimal128
+ BSON::Decimal... | 1 | # encoding: utf-8
require "bigdecimal"
module Mongoid
class Criteria
module Queryable
module Extensions
# The big decimal module adds custom behaviour for Origin onto the
# BigDecimal class.
module BigDecimal
module ClassMethods
# Evolves the big decimal into... | 1 | 11,623 | I think BSON::Decimal128 should always be serialized as Decimal128 regardless of config option. | mongodb-mongoid | rb |
@@ -1,6 +1,7 @@
# frozen_string_literal: true
require 'bolt/application'
+require 'bolt/plan_creator'
require 'bolt_spec/files'
| 1 | # frozen_string_literal: true
require 'bolt/application'
require 'bolt_spec/files'
describe Bolt::Application do
include BoltSpec::Files
let(:analytics) { double('analytics').as_null_object }
let(:config) { double('config').as_null_object }
let(:executor) { double('executor').as_null_object }
let(:... | 1 | 19,014 | We should probably just move the `require 'bolt/plan_creator'` in `Bolt::CLI` to `Bolt::Application` so it will already be loaded. | puppetlabs-bolt | rb |
@@ -34,7 +34,10 @@ namespace Benchmarks
private static IConfig GetConfig(Options options)
{
- var baseJob = Job.ShortRun; // let's use the Short Run for better first user experience ;)
+ var baseJob = Job.Default
+ .WithWarmupCount(1) // 1 warmup is enough for ou... | 1 | using System.Collections.Generic;
using System.Linq;
using BenchmarkDotNet.Attributes;
using BenchmarkDotNet.Columns;
using BenchmarkDotNet.Configs;
using BenchmarkDotNet.Diagnosers;
using BenchmarkDotNet.Environments;
using BenchmarkDotNet.Exporters;
using BenchmarkDotNet.Exporters.Csv;
using BenchmarkDotNet.Horology... | 1 | 7,149 | >20 [](start = 45, length = 2) Can we override this at runtime? Maybe it should be a command line option with default. | dotnet-performance | .cs |
@@ -47,7 +47,7 @@ class Service(object):
self.start_error_message = start_error_message
self.log_file = log_file
self.env = env or os.environ
-
+
@property
def service_url(self):
""" | 1 | # Licensed to the Software Freedom Conservancy (SFC) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The SFC licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not... | 1 | 15,260 | can just remove it ? | SeleniumHQ-selenium | java |
@@ -654,7 +654,17 @@ func MigrateRepository(u *User, opts MigrateRepoOptions) (*Repository, error) {
return repo, UpdateRepository(repo, false)
}
- if err = createUpdateHook(repoPath); err != nil {
+ repo, err = FinishMigrateRepository(repo, repoPath)
+ if err != nil {
+ return repo, err
+ }
+
+ return repo, Up... | 1 | // Copyright 2014 The Gogs Authors. All rights reserved.
// Use of this source code is governed by a MIT-style
// license that can be found in the LICENSE file.
package models
import (
"bytes"
"errors"
"fmt"
"html/template"
"io/ioutil"
"os"
"os/exec"
"path"
"path/filepath"
"regexp"
"sort"
"strings"
"sync... | 1 | 10,313 | Better call it `CleanUpMirrorInfo`? | gogs-gogs | go |
@@ -405,6 +405,19 @@ func (node *Node) SetupMining(ctx context.Context) error {
}
}
+ if err := node.StorageMining.Start(ctx); err != nil {
+ fmt.Printf("error starting storage miner: %s\n", err)
+ }
+
+ if err := node.StorageProtocol.StorageProvider.Start(ctx); err != nil {
+ fmt.Printf("error starting storag... | 1 | package node
import (
"context"
"fmt"
"os"
"reflect"
"runtime"
"github.com/filecoin-project/go-address"
"github.com/filecoin-project/go-sectorbuilder"
"github.com/filecoin-project/go-sectorbuilder/fs"
"github.com/filecoin-project/specs-actors/actors/abi"
fbig "github.com/filecoin-project/specs-actors/actors... | 1 | 23,540 | @shannonwells is there still something missing here? | filecoin-project-venus | go |
@@ -149,6 +149,9 @@ MESSAGE
# don't accidentally leave the seed encoded.
define_reader :seed
+ # Time limit for stress testing, if any (default: nil).
+ add_setting :stress_test
+
# When a block passed to pending fails (as expected), display the failure
# without reporting it as ... | 1 | require 'fileutils'
require 'rspec/core/backtrace_cleaner'
require 'rspec/core/ruby_project'
module RSpec
module Core
# Stores runtime configuration information.
#
# Configuration options are loaded from `~/.rspec`, `.rspec`,
# `.rspec-local`, command line switches, and the `SPEC_OPTS` environment
... | 1 | 9,178 | This could be more indicative of what it is... e.g... `stresstest_time_limit` | rspec-rspec-core | rb |
@@ -279,7 +279,6 @@ bool PDPSimple::createPDPEndpoints()
delete mp_listener;
mp_listener = nullptr;
reader_payload_pool_->release_history(reader_pool_cfg, true);
- TopicPayloadPoolRegistry::release(reader_payload_pool_);
return false;
}
| 1 | // Copyright 2016 Proyectos y Sistemas de Mantenimiento SL (eProsima).
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless re... | 1 | 21,519 | Shouldn't we do a `reader_payload_pool_.reset()` here? | eProsima-Fast-DDS | cpp |
@@ -33,9 +33,9 @@ type Block struct {
// ElectionProof is the vrf proof giving this block's miner authoring rights
ElectionProof *crypto.ElectionProof
- // DrandEntries contain the verifiable oracle randomness used to elect
+ // BeaconEntries contain the verifiable oracle randomness used to elect
// this block'... | 1 | package block
import (
"encoding/json"
"fmt"
"github.com/filecoin-project/go-address"
"github.com/filecoin-project/specs-actors/actors/abi"
fbig "github.com/filecoin-project/specs-actors/actors/abi/big"
blocks "github.com/ipfs/go-block-format"
cid "github.com/ipfs/go-cid"
cbor "github.com/ipfs/go-ipld-cbor"
... | 1 | 23,707 | I'd prefer the nomenclature less tightly coupled to DRAND throughout. I played with renaming the `drand` package to `beacon` but it was too much noise in this change. | filecoin-project-venus | go |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.