patch
stringlengths
17
31.2k
y
int64
1
1
oldf
stringlengths
0
2.21M
idx
int64
1
1
id
int64
4.29k
68.4k
msg
stringlengths
8
843
proj
stringclasses
212 values
lang
stringclasses
9 values
@@ -72,9 +72,13 @@ module Beaker def cmd_line host, cmd = @command, env = @environment, pc = @prepend_cmds env_string = host.environment_string( env ) prepend_commands = host.prepend_commands( cmd, pc, :cmd_exe => @cmdexe ) + if host[:platform] =~ /cisco_nexus/ && host[:user] != 'root' + ...
1
module Beaker # An object that represents a "command" on a remote host. Is responsible # for munging the environment correctly. Probably poorly named. # # @api public class Command # A string representing the (possibly) incomplete command attr_accessor :command # A hash key-values where the keys...
1
12,498
Doesn't this go in the opposite direction of #1051 / #1062 by putting platform-specific logic back into this module?
voxpupuli-beaker
rb
@@ -31,7 +31,7 @@ export const refreshAuthentication = async () => { // We should really be using state management. This is terrible. global.googlesitekit.setup = global.googlesitekit.setup || {}; - global.googlesitekit.setup.isAuthenticated = response.isAuthenticated; + global.googlesitekit.setup.authenticat...
1
/** * Refresh Authentication utility. * * Site Kit by Google, Copyright 2020 Google LLC * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * https://www.apache.org/licenses/LICENS...
1
28,384
I think this is the only line in JS legacy code that should be updated based on the renaming. `global.googlesitekit.setup.isAuthenticated = response.authenticated;` would be sufficient to keep the old name for the legacy JS data (which will be phased out in the long term) while supporting the new name in the API route....
google-site-kit-wp
js
@@ -36,7 +36,7 @@ function sendCommandToFrame(node, parameters, resolve, reject) { reject(err('No response from frame', node)); } }, 0); - }, 500); + }, parameters.options?.pingWaitTime ?? 500); // send 'axe.ping' to the frame respondable(win, 'axe.ping', null, undefined, () => {
1
import getSelector from './get-selector'; import respondable from './respondable'; import log from '../log'; function err(message, node) { var selector; // TODO: es-modules_tree if (axe._tree) { selector = getSelector(node); } return new Error(message + ': ' + (selector || node)); } /** * Sends a comma...
1
17,243
Technically, this would allow `pingWaitTime` to be `false`. I don't know if it matters here.
dequelabs-axe-core
js
@@ -11,11 +11,15 @@ TEST_DATA = '{"StreamName": "NotExistingStream"}' class KinesisListenerTest(unittest.TestCase): def test_describe_stream_summary_is_redirected(self): - describe_stream_summary_header = {'X-Amz-Target': 'Kinesis_20131202.DescribeStreamSummary'} + if config.KINESIS_PROVIDER == 'k...
1
import json import unittest from requests.models import Response from localstack import config from localstack.services.kinesis.kinesis_listener import UPDATE_KINESIS from localstack.utils.common import to_str TEST_DATA = '{"StreamName": "NotExistingStream"}' class KinesisListenerTest(unittest.TestCase): def te...
1
12,569
I only want the proxy request for this to run for kinesalite. So this just returns true if the KINESIS_PROVIDER is kinesis-mock
localstack-localstack
py
@@ -3,7 +3,7 @@ #A part of NonVisual Desktop Access (NVDA) #This file is covered by the GNU General Public License. #See the file COPYING for more details. -#Copyright (C) 2006-2017 NV Access Limited, Peter Vágner, Aleksey Sadovoy, Joseph Lee +#Copyright (C) 2006-2019 NV Access Limited, Peter Vágner, Aleksey Sadovoy...
1
# -*- coding: UTF-8 -*- #synthDriverHandler.py #A part of NonVisual Desktop Access (NVDA) #This file is covered by the GNU General Public License. #See the file COPYING for more details. #Copyright (C) 2006-2017 NV Access Limited, Peter Vágner, Aleksey Sadovoy, Joseph Lee from copy import deepcopy import os i...
1
24,937
Please add your name to the list of copyright holders.
nvaccess-nvda
py
@@ -50,6 +50,12 @@ public class IpPortManager { private boolean autoDiscoveryInited = false; + private int maxRetryTimes; + + public int getMaxRetryTimes() { + return maxRetryTimes; + } + public IpPortManager(ServiceRegistryConfig serviceRegistryConfig, InstanceCacheManager instanceCacheManager) { ...
1
/* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may ...
1
9,187
Maybe maxRetryTimes should be bigger than 2. Return Max(maxRestryTime, 2)?
apache-servicecomb-java-chassis
java
@@ -439,7 +439,7 @@ type CloneLink struct { Git string } -func (repo *Repository) cloneLink(isWiki bool) *CloneLink { +func (repo *Repository) cloneLink(isWiki bool, signedUserName string) *CloneLink { repoName := repo.Name if isWiki { repoName += ".wiki"
1
// Copyright 2014 The Gogs Authors. All rights reserved. // Use of this source code is governed by a MIT-style // license that can be found in the LICENSE file. package models import ( "bytes" "errors" "fmt" "html/template" "io/ioutil" "os" "os/exec" "path" "path/filepath" "regexp" "sort" "strings" "sync...
1
10,335
Call `userName` is good enough, `signedUserName` is narrowing the actual usage of this method.
gogs-gogs
go
@@ -65,6 +65,13 @@ namespace Datadog.Trace AppDomain.CurrentDomain.ProcessExit += CurrentDomain_ProcessExit; AppDomain.CurrentDomain.UnhandledException += CurrentDomain_UnhandledException; Console.CancelKeyPress += Console_CancelKeyPress; + + // If configured, add/remov...
1
using System; using System.Collections.Generic; using System.Diagnostics; using System.Reflection; using Datadog.Trace.Agent; using Datadog.Trace.Configuration; using Datadog.Trace.Logging; using Datadog.Trace.Sampling; namespace Datadog.Trace { /// <summary> /// The tracer is responsible for creating spans an...
1
15,101
How would you feel about a static method to express intent?
DataDog-dd-trace-dotnet
.cs
@@ -75,7 +75,8 @@ func (t LoggableTLSConnState) MarshalLogObject(enc zapcore.ObjectEncoder) error enc.AddUint16("version", t.Version) enc.AddUint16("cipher_suite", t.CipherSuite) enc.AddString("proto", t.NegotiatedProtocol) - enc.AddBool("proto_mutual", t.NegotiatedProtocolIsMutual) + // NegotiatedProtocolIsMutua...
1
// Copyright 2015 Matthew Holt and The Caddy Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicab...
1
15,749
Do we know for sure that no other code changed its value? (Maybe some weird testing use case or something) Why not just use the actual value instead of risk lying?
caddyserver-caddy
go
@@ -16,8 +16,7 @@ package account -//go:generate dbgen -i root.sql -p account -n root -o rootInstall.go -//go:generate dbgen -i part.sql -p account -n part -o partInstall.go +//go:generate dbgen -i root.sql -p account -n root -o rootInstall.go -h ../../scripts/LICENSE_HEADER import ( "database/sql" "fmt"
1
// Copyright (C) 2019-2020 Algorand, Inc. // This file is part of go-algorand // // go-algorand is free software: you can redistribute it and/or modify // it under the terms of the GNU Affero General Public License as // published by the Free Software Foundation, either version 3 of the // License, or (at your option) ...
1
38,996
the partInstall.go isn't an auto-generated file, and the part.sql doesn't exists either.
algorand-go-algorand
go
@@ -97,3 +97,11 @@ func (c *TTLCache) Delete(key interface{}) error { c.entries.Delete(key) return nil } + +func (c *TTLCache) GetAll() ([]interface{}, error) { + return nil, cache.ErrUnimplemented +} + +func (c *TTLCache) PutHash(k interface{}, v interface{}) error { + return cache.ErrUnimplemented +}
1
// Copyright 2020 The PipeCD Authors. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agree...
1
17,840
`k` is unused in PutHash
pipe-cd-pipe
go
@@ -277,4 +277,12 @@ public class Utils { Method method = clazz.getDeclaredMethod(methodName, argTypes); return method.invoke(null, args); } + + public static void copyStream(InputStream input, OutputStream output) throws IOException { + byte[] buffer = new byte[1024]; + int bytesRead; + while ((bytesRead =...
1
/* * Copyright 2012 LinkedIn, Inc * * Licensed under the Apache License, Version 2.0 (the "License"); you may not * use this file except in compliance with the License. You may obtain a copy of * the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to...
1
9,366
Use IOUtils instead
azkaban-azkaban
java
@@ -27,6 +27,8 @@ type idmFake struct { unlockFails bool } +// NewIdentityManagerFake creates fake identity manager for testing purposes +// TODO each caller should use it's own mocked manager part instead of global one func NewIdentityManagerFake(existingIdentities []Identity, newIdentity Identity) *idm...
1
/* * Copyright (C) 2017 The "MysteriumNetwork/node" Authors. * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation, either version 3 of the License, or * (at your option) any later version. * ...
1
13,089
It's not related to the line of code, but I don't know how to write it in a more proper place. Looks like `e2e/myst-provider/db/myst.db` should be in `.gitignore` file and should not be commited.
mysteriumnetwork-node
go
@@ -22,6 +22,7 @@ from selenium.webdriver.common.desired_capabilities import DesiredCapabilities class Options(object): + KEY = "goog:chromeOptions" def __init__(self): self._binary_location = ''
1
# Licensed to the Software Freedom Conservancy (SFC) under one # or more contributor license agreements. See the NOTICE file # distributed with this work for additional information # regarding copyright ownership. The SFC licenses this file # to you under the Apache License, Version 2.0 (the # "License"); you may not...
1
14,945
nice touch since Google likes to change things every now and then.
SeleniumHQ-selenium
rb
@@ -1174,7 +1174,8 @@ public final class SolrCore implements SolrInfoBean, Closeable { } private CircuitBreakerManager initCircuitBreakerManager() { - CircuitBreakerManager circuitBreakerManager = CircuitBreakerManager.build(solrConfig); + final PluginInfo info = solrConfig.getPluginInfo(CircuitBreakerMan...
1
/* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may ...
1
36,600
Make `CircuitBreakerManager` implement `PluginInfoInitialized`
apache-lucene-solr
java
@@ -679,7 +679,7 @@ class _ServerCapabilities: def _as_uint32(x: int) -> QVariant: """Convert the given int to an uint32 for DBus.""" variant = QVariant(x) - successful = variant.convert(QVariant.Type.UInt) + successful = variant.convert(QMetaType(QMetaType.Type.UInt.value)) assert successful ...
1
# vim: ft=python fileencoding=utf-8 sts=4 sw=4 et: # Copyright 2020 Florian Bruhin (The Compiler) <mail@qutebrowser.org> # # This file is part of qutebrowser. # # qutebrowser is free software: you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Softwa...
1
26,484
This is extra awkward, QVariant.convert() takes a QMetaType which takes the value of a QMetaType.Type.
qutebrowser-qutebrowser
py
@@ -59,6 +59,12 @@ type Writer struct { // These fields exist only when w is not created in the first place when // NewWriter is called. + // + // A ctx is stored in the Writer since we need to pass it into NewTypedWriter + // when we finished detecting the content type of the object and create the + // underlyin...
1
// Copyright 2018 Google LLC // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // https://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to in ...
1
10,779
Nit: finished -> finish, "done passing it" -> "passed it".
google-go-cloud
go
@@ -46,5 +46,18 @@ module C2 config.autoload_paths << Rails.root.join('lib') config.assets.precompile << 'common/communicarts.css' + + # Paperclip's attachment settings are determined by S3 env vars + if ENV['S3_BUCKET_NAME'] && ENV['S3_ACCESS_KEY_ID'] && ENV['S3_SECRET_ACCESS_KEY'] + Paperclip::...
1
require File.expand_path('../boot', __FILE__) require 'rails/all' # Require the gems listed in Gemfile, including any gems # you've limited to :test, :development, or :production. Bundler.require(:default, Rails.env) module C2 class Application < Rails::Application # Settings in config/environments/* take prec...
1
12,901
Maybe mention that it will be saved to the filesystem otherwise?
18F-C2
rb
@@ -108,7 +108,11 @@ namespace pwiz.Skyline.FileUI { for (var i = 0; i < numColumns; i++) { - dataGrid.Columns[i].ToolTipText = + // In the case when we don't have user provided headers, we still want localized headers that can be tran...
1
/* * Original author: Alex MacLean <alex.maclean2000 .at. gmail.com>, * MacCoss Lab, Department of Genome Sciences, UW * * Copyright 2018 University of Washington - Seattle, WA * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance ...
1
14,323
Probably cleaner and more general to do this: string,Format("Column {0}", i+1) That way if the local language has a convention like "3 column, this is" it still works.
ProteoWizard-pwiz
.cs
@@ -74,11 +74,14 @@ func (v *validator) verifyActions(blk *Block, containCoinbase bool) error { // Verify transfers, votes, executions, witness, and secrets (balance is checked in RunActions) confirmedNonceMap := make(map[string]uint64) accountNonceMap := make(map[string][]uint64) + + transfers, votes, executions...
1
// Copyright (c) 2018 IoTeX // This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no // warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent // permitted by law, all liability for your use of the cod...
1
12,879
This can be uniformed too
iotexproject-iotex-core
go
@@ -16,14 +16,14 @@ type mock struct { peers []swarm.Address closestPeer swarm.Address closestPeerErr error - addPeerErr error + AddPeersErr error marshalJSONFunc func() ([]byte, error) mtx sync.Mutex } -func WithAddPeerErr(err error) Option { +func WithAddPeersErr(err e...
1
// Copyright 2020 The Swarm Authors. All rights reserved. // Use of this source code is governed by a BSD-style // license that can be found in the LICENSE file. package mock import ( "context" "sync" "github.com/ethersphere/bee/pkg/swarm" "github.com/ethersphere/bee/pkg/topology" ) type mock struct { peers ...
1
11,867
It looks to me that this does not have to be exported.
ethersphere-bee
go
@@ -61,6 +61,14 @@ public abstract class ApiConfig { } } + /** + * Creates an ApiConfig with no content. Exposed for testing. + */ + public static ApiConfig createDummyApiConfig() { + return new AutoValue_ApiConfig(ImmutableMap.<String, InterfaceConfig> builder().build(), null, + false); + } ...
1
/* Copyright 2016 Google Inc * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in ...
1
15,347
It looks like this is only used in order to extract the snippet file names from GapicProviderFactory. I wonder if it would be better expose the snippet file names directly, without exposing a test-only function in non-test code.
googleapis-gapic-generator
java
@@ -511,18 +511,6 @@ public class DataversePage implements java.io.Serializable { } setEditInputLevel(false); } - - public void toggleInputLevel( Long mdbId, long dsftId){ - for (MetadataBlock mdb : allMetadataBlocks) { - if (mdb.getId().equals(mdbId)) { - ...
1
package edu.harvard.iq.dataverse; import edu.harvard.iq.dataverse.UserNotification.Type; import edu.harvard.iq.dataverse.authorization.Permission; import edu.harvard.iq.dataverse.authorization.users.AuthenticatedUser; import edu.harvard.iq.dataverse.authorization.users.User; import edu.harvard.iq.dataverse.dataaccess....
1
43,872
Another question: this is being removed, but I don't see a corresponding removal if it being called? Was it never used (or am I just missing it)? (is it related to what was in the onclick that got removed, i.e. was that supposed to call this and not something in the backing bean?)
IQSS-dataverse
java
@@ -186,6 +186,10 @@ func (h *Helper) ValidateIssuedCertificateRequest(cr *cmapi.CertificateRequest, } } + if !apiutil.CertificateRequestHasApproved(cr) { + return nil, fmt.Errorf("CertificateRequest does not have an Approved condition: %+v", cr.Status.Conditions) + } + return cert, nil }
1
/* Copyright 2020 The cert-manager Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing...
1
25,469
Suggestion: `.. does not have an Approved condition set to true`
jetstack-cert-manager
go
@@ -77,6 +77,7 @@ class BlazeMeterUploader(Reporter, AggregatorListener): self.client.user_id = self.parameters.get("user-id", None) self.client.data_signature = self.parameters.get("signature", None) self.client.kpi_target = self.parameters.get("kpi-target", self.client.kpi_target) + ...
1
""" Module for reporting into http://www.blazemeter.com/ service Copyright 2015 BlazeMeter Inc. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unles...
1
13,697
I would say that client class should have default of False and Cloud prov should enable deleting.
Blazemeter-taurus
py
@@ -1,4 +1,4 @@ -// Copyright (c) .NET Foundation. All rights reserved. +// Copyright (c) .NET Foundation. All rights reserved. // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. using System;
1
// Copyright (c) .NET Foundation. All rights reserved. // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. using System; using System.Collections.Generic; using System.IO.Pipelines; using System.Threading; using Microsoft.AspNetCore.Http.Features; using Micr...
1
14,323
Did this remove the BOM or something?
aspnet-KestrelHttpServer
.cs
@@ -99,6 +99,10 @@ public class BlockHeaderValidator<C> { return parent; } + public void addRule(final AttachedBlockHeaderValidationRule<C> rule) { + this.rules.add(new Rule<>(false, rule, rule.includeInLightValidation())); + } + private static class Rule<C> { private final boolean detachedSuppor...
1
/* * Copyright ConsenSys AG. * * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with * the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing...
1
22,069
This makes the BlockHeaderValidator mutable, and IMHO should not be done. Note we have a builder that has the exact same method, so instead of mutating a produced BlockHeaderValidator we should hook into wherever the builder is being created.
hyperledger-besu
java
@@ -383,7 +383,7 @@ def outputDeviceNameToID(name, useDefaultIfInvalid=False): fileWavePlayer = None fileWavePlayerThread=None -def playWaveFile(fileName, async=True): +def playWaveFile(fileName, asynchronous=True): """plays a specified wave file. """ global fileWavePlayer, fileWavePlayerThread
1
#nvwave.py #A part of NonVisual Desktop Access (NVDA) #Copyright (C) 2007-2017 NV Access Limited, Aleksey Sadovoy #This file is covered by the GNU General Public License. #See the file COPYING for more details. """Provides a simple Python interface to playing audio using the Windows multimedia waveOut functions,...
1
23,142
May be add information about parameters to the doc string while at it?
nvaccess-nvda
py
@@ -43,8 +43,8 @@ public enum RpcMethod { PRIV_DELETE_PRIVACY_GROUP("priv_deletePrivacyGroup"), PRIV_FIND_PRIVACY_GROUP("priv_findPrivacyGroup"), PRIV_DISTRIBUTE_RAW_TRANSACTION("priv_distributeRawTransaction"), + PRIV_GET_TRANSACTION_COUNT_LEGACY("priv_getTransactionCountLegacy"), EEA_SEND_RAW_TRANSACTION...
1
/* * Copyright ConsenSys AG. * * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with * the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing...
1
20,045
Naming of this sounds a bit awkward. Perhaps priv_legacy_getTransactionCount or priv_legacyGetTransactionCount?
hyperledger-besu
java
@@ -3901,9 +3901,6 @@ void CoreChecks::PreCallRecordFreeMemory(VkDevice device, VkDeviceMemory mem, co // Clear mem binding for any bound objects for (auto obj : mem_info->obj_bindings) { - log_msg(report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, get_debug_report_enum[obj.type], obj.handle, - ...
1
/* Copyright (c) 2015-2019 The Khronos Group Inc. * Copyright (c) 2015-2019 Valve Corporation * Copyright (c) 2015-2019 LunarG, Inc. * Copyright (C) 2015-2019 Google Inc. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You m...
1
10,686
This one should probably be added to the list in #24 . It's possibly indicative of an issue, but there isn't a VUID for it.
KhronosGroup-Vulkan-ValidationLayers
cpp
@@ -139,13 +139,11 @@ def build_network_url(project, network): The fully qualified network url for the given project/network. """ return (u'%(root)s%(api_name)s/%(version)s/projects/%(project)s/global/' - 'networks/%(network)s') % { - 'api_name': API_NAME, - 'ne...
1
# Copyright 2017 The Forseti Security Authors. All rights reserved. # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by ap...
1
29,382
Why this indentation change? Seems the original indentation would be fine, and leaves more room.
forseti-security-forseti-security
py
@@ -145,7 +145,7 @@ class MultiDimensionalMapping(Dimensioned): raise KeyError('Key has to match number of dimensions.') - def _add_item(self, dim_vals, data, sort=True): + def _add_item(self, dim_vals, data, sort=True, update=True): """ Adds item to the data, applying dimension...
1
""" Supplies MultiDimensionalMapping and NdMapping which are multi-dimensional map types. The former class only allows indexing whereas the latter also enables slicing over multiple dimension ranges. """ from collections import Sequence from itertools import cycle from operator import itemgetter import numpy as np im...
1
13,867
Would be nice to know what the `update` argument does in the docstring.
holoviz-holoviews
py
@@ -1,10 +1,10 @@ -import StringIO from pathod import log from netlib.exceptions import TcpDisconnect -import netlib.tcp +from six.moves import cStringIO -class DummyIO(StringIO.StringIO): + +class DummyIO(cStringIO): def start_log(self, *args, **kwargs): pass
1
import StringIO from pathod import log from netlib.exceptions import TcpDisconnect import netlib.tcp class DummyIO(StringIO.StringIO): def start_log(self, *args, **kwargs): pass def get_log(self, *args, **kwargs): return "" def test_disconnect(): outf = DummyIO() rw = DummyIO() ...
1
11,479
I think we can just use `io.BytesIO` here.
mitmproxy-mitmproxy
py
@@ -155,13 +155,14 @@ func NewGCPgRPCConn(ctx context.Context, t *testing.T, endPoint, api string) (*g } // NewAzureTestPipeline creates a new connection for testing against Azure Blob. -func NewAzureTestPipeline(ctx context.Context, t *testing.T, accountName string, accountKey string) (pipeline pipeline.Pipeline, ...
1
package setup // import "gocloud.dev/internal/testing/setup" import ( "context" "flag" "fmt" "net" "net/http" "regexp" "testing" "github.com/aws/aws-sdk-go/aws" awscreds "github.com/aws/aws-sdk-go/aws/credentials" "github.com/aws/aws-sdk-go/aws/session" "github.com/dnaeon/go-vcr/recorder" "gocloud.dev/gcp...
1
13,515
This ensures that the User-Agent header matches during replay.
google-go-cloud
go
@@ -3517,6 +3517,7 @@ XDDkwd__(SUBQUERY_UNNESTING, "ON"), XDDui1__(USTAT_MIN_ROWCOUNT_FOR_LOW_SAMPLE, "1000000"), XDDui1__(USTAT_MIN_ROWCOUNT_FOR_SAMPLE, "10000"), DDflt0_(USTAT_MODIFY_DEFAULT_UEC, "0.05"), + DDflt0_(USTAT_NAHEAP_ESTIMATED_MAX, "1.3"), // estimated max memory ...
1
/* -*-C++-*- // @@@ START COPYRIGHT @@@ // // (C) Copyright 1996-2015 Hewlett-Packard Development Company, L.P. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.ap...
1
7,086
What units are used for this default?
apache-trafodion
cpp
@@ -47,7 +47,13 @@ public struct Ability : IFlatbufferObject public class AbilityT { +#if ENABLE_JSON_SERIALIZATION + [Newtonsoft.Json.JsonProperty("id")] +#endif public uint Id { get; set; } +#if ENABLE_JSON_SERIALIZATION + [Newtonsoft.Json.JsonProperty("distance")] +#endif public uint Distance { get; set;...
1
// <auto-generated> // automatically generated by the FlatBuffers compiler, do not modify // </auto-generated> namespace MyGame.Example { using global::System; using global::System.Collections.Generic; using global::FlatBuffers; public struct Ability : IFlatbufferObject { private Struct __p; public ByteBuffer B...
1
17,711
I am wondering if it makes sense to make this a flag to `flatc` rather than a preprocessor flag, since this is generated code, it would make more sense to simply omit this code completely if the flag is not specified
google-flatbuffers
java
@@ -584,8 +584,7 @@ class MainWindow(QWidget): quit_texts = [] # Ask if multiple-tabs are open if 'multiple-tabs' in config.val.confirm_quit and tab_count > 1: - quit_texts.append("{} {} open.".format( - tab_count, "tab is" if tab_count == 1 else "tabs are")) + ...
1
# vim: ft=python fileencoding=utf-8 sts=4 sw=4 et: # Copyright 2014-2019 Florian Bruhin (The Compiler) <mail@qutebrowser.org> # # This file is part of qutebrowser. # # qutebrowser is free software: you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free S...
1
23,357
Doesn't this change the behavior (edit: oh, I see, never mind).
qutebrowser-qutebrowser
py
@@ -216,11 +216,15 @@ module Travis sh.cmd 'sudo ln -f -s /lib/i386-linux-gnu/libpam.so.0 /lib/libpam.so.0' sh.cmd 'sudo ln -f -s /usr/lib/i386-lin-gnu/libstdc++.so.6 /usr/lib/i386-linux-gnu/libstdc++.so' end - sh.if '$(uname -m) != ppc64le && $(lsb_release -cs) = t...
1
# Copyright (c) 2015-2017 Software Architecture Group (Hasso Plattner Institute) # Copyright (c) 2015-2017 Fabio Niephaus, Google Inc. module Travis module Build class Script class Smalltalk < Script DEFAULTS = {} DEFAULT_REPOSITORY = 'hpi-swa/smalltalkCI' DEFAULT_BRANCH = 'master' ...
1
17,289
I think you need a `do` at the end of this line.
travis-ci-travis-build
rb
@@ -5,7 +5,7 @@ <%= link_to(t('blacklight.search.sort.label', :field =>current_sort_field.label), "#") %> <span class="caret"></span> <ul> <%- blacklight_config.sort_fields.each do |sort_key, field| %> - <li><%= link_to(field.label, url_for(params_for_search(:sort => sort_key))) %></li> ...
1
<% if show_sort_and_per_page? and !blacklight_config.sort_fields.blank? %> <div id="sort-dropdown" class="dropdown pull-right hidden-phone"> <ul class="css-dropdown"> <li class="btn"> <%= link_to(t('blacklight.search.sort.label', :field =>current_sort_field.label), "#") %> <span class="caret"></span> ...
1
4,781
Not passing in a `:params` key here.
projectblacklight-blacklight
rb
@@ -308,6 +308,7 @@ func (r *ReconcileClusterClaim) reconcileForDeletedCluster(claim *hivev1.Cluster func (r *ReconcileClusterClaim) reconcileForNewAssignment(claim *hivev1.ClusterClaim, cd *hivev1.ClusterDeployment, logger log.FieldLogger) (reconcile.Result, error) { logger.Info("cluster assigned to claim") cd.Sp...
1
package clusterclaim import ( "context" "reflect" "time" "github.com/pkg/errors" log "github.com/sirupsen/logrus" corev1 "k8s.io/api/core/v1" rbacv1 "k8s.io/api/rbac/v1" apierrors "k8s.io/apimachinery/pkg/api/errors" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/apimachinery/pkg/types" "sigs.k8s.io...
1
13,496
Feels like this should be an option and not the default. Leaving them running would give you immediate response to claims, which might be what some people would want. Hibernation is AWS only right now and probably other clouds will just disregard the setting but arguably validation should be rejecting attempts to creat...
openshift-hive
go
@@ -5,13 +5,14 @@ // The conditions looks weird, but it seems like _OR_GREATER is not supported yet in all environments // We can trim all the additional conditions when this is fixed -#if NETCOREAPP3_0 || NETCOREAPP3_1 || NET5_0 +#if NETCOREAPP3_0 || NETCOREAPP3_1 || NET5_0 || NET6_0 using System; using System...
1
// <copyright file="AspNetCore5.cs" company="Datadog"> // Unless explicitly stated otherwise all files in this repository are licensed under the Apache 2 License. // This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc. // </copyright> // The conditions looks we...
1
25,568
I think I saw somewhere that it has been fixed and that you can use #NETCOREAPP3_0_OR_GREATER but I may be wrong.
DataDog-dd-trace-dotnet
.cs
@@ -236,6 +236,15 @@ func (r *RollDPoS) CurrentState() fsm.State { return r.cfsm.CurrentState() } +// Activate activates or pauses the roll-DPoS consensus. When it is deactivated, the node will finish the current +// consensus round if it is doing the work and then return the the initial state +func (r *RollDPoS) ...
1
// Copyright (c) 2019 IoTeX // This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no // warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent // permitted by law, all liability for your use of the cod...
1
17,167
what's the second part for?
iotexproject-iotex-core
go
@@ -79,7 +79,7 @@ public class DirectSolrSpellCheckerTest extends SolrTestCaseJ4 { return null; }); } - + @Test public void testOnlyMorePopularWithExtendedResults() throws Exception { assertQ(req("q", "teststop:fox", "qt", "/spellCheckCompRH", SpellCheckComponent.COMPONENT_NAME, "true", Spel...
1
/* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may ...
1
31,682
It's not clear to me what the "super" test above is for. As far as I can see, the test runs a spellcheck for "super" but then uses "fob" as the index into suggestions, which will never find an entry.
apache-lucene-solr
java
@@ -24,7 +24,7 @@ import ( "google.golang.org/grpc/status" logfilter "github.com/iotexproject/iotex-core/api/logfilter" - "github.com/iotexproject/iotex-core/ioctl/util" + ioctlUtil "github.com/iotexproject/iotex-core/ioctl/util" "github.com/iotexproject/iotex-core/pkg/log" )
1
package api import ( "context" "encoding/hex" "encoding/json" "fmt" "math/big" "strconv" "strings" "time" "github.com/ethereum/go-ethereum/common" "github.com/go-redis/redis/v8" "github.com/iotexproject/go-pkgs/cache/ttl" "github.com/iotexproject/go-pkgs/hash" "github.com/iotexproject/iotex-address/addre...
1
24,226
revert this file change
iotexproject-iotex-core
go
@@ -74,9 +74,9 @@ class FileState: # # 1. def meth8(self): # 2. """test late disabling""" - # 3. pylint: disable=not-callable + # 3. pylint: disable=not-callable, useless-suppression # 4. print(self.blip) - # 5. pylint: disabl...
1
# Licensed under the GPL: https://www.gnu.org/licenses/old-licenses/gpl-2.0.html # For details: https://github.com/PyCQA/pylint/blob/main/LICENSE import collections import sys from typing import ( TYPE_CHECKING, DefaultDict, Dict, Iterator, Optional, Set, Tuple, Union, ) from astroid i...
1
17,762
I think this is the most elegant way to allow us to still fail on `I`.
PyCQA-pylint
py
@@ -415,10 +415,15 @@ class AdminController extends Controller ->from($entityClass, 'entity') ; + $wildcards = $this->getDoctrine()->getConnection()->getDatabasePlatform()->getWildcards(); + $searchQuery = addcslashes($searchQuery, implode('', $wildcards)); + foreach ($sea...
1
<?php /* * This file is part of the EasyAdminBundle. * * (c) Javier Eguiluz <javier.eguiluz@gmail.com> * * For the full copyright and license information, please view the LICENSE * file that was distributed with this source code. * * Some parts of this file are copied and/or inspired by the * DoctrineCRUDGene...
1
8,427
Wouldn't it be better to use a sql `IN ( :exact_value )` ?
EasyCorp-EasyAdminBundle
php
@@ -9,9 +9,14 @@ module Bolt @shell = shell @endpoint = "http://#{host}:#{port}/wsman" - @connection = ::WinRM::Connection.new(endpoint: @endpoint, - user: @user, - password: @password) + options = { endpoint...
1
require 'winrm' require 'winrm-fs' require 'bolt/result' module Bolt class WinRM < Node def initialize(host, port, user, password, shell: :powershell, **kwargs) super(host, port, user, password, **kwargs) @shell = shell @endpoint = "http://#{host}:#{port}/wsman" @connection = ::WinRM::Co...
1
6,620
So far this is not working as expected... working to further investigate WinRM protocol and the gems behavior.
puppetlabs-bolt
rb
@@ -68,7 +68,7 @@ class ApacheBenchmarkExecutor(ScenarioExecutor, WidgetProvider, HavingInstallabl return self.widget def __first_http_request(self): - for request in self.scenario.get_requests(): + for request in self.get_requests(): if isinstance(request, HTTPRequest): ...
1
""" Module holds all stuff regarding usage of Apache Benchmark Copyright 2016 BlazeMeter Inc. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless ...
1
15,333
So now there're two ways to get requests: `ScenarioExecutor.get_requests()` and `Scenario.get_requests()`. To avoid confusion we should probably make `Scenario.get_requests()` method private, or hide it in some other way.
Blazemeter-taurus
py
@@ -2436,10 +2436,10 @@ public: } else if (message_a.response) { - auto node_id (message_a.response->first); - connection->remote_node_id = node_id; + nano::account node_id (message_a.response->first); if (!connection->node->network.syn_cookies.validate (nano::transport::map_tcp_to_endpoint (connecti...
1
#include <nano/crypto_lib/random_pool.hpp> #include <nano/node/bootstrap.hpp> #include <nano/node/common.hpp> #include <nano/node/node.hpp> #include <nano/node/transport/tcp.hpp> #include <nano/node/transport/udp.hpp> #include <boost/log/trivial.hpp> #include <algorithm> constexpr double bootstrap_connection_scale_t...
1
15,726
This existed already, but seeing as you are changing the variable to have an explicit type it could be made a const reference to remove a copy.
nanocurrency-nano-node
cpp
@@ -0,0 +1,11 @@ +module Faker + class FamousLastWords < Base + flexible :famous_last_words + + class << self + def name + fetch('famous_last_words.phrase') + end + end + end +end
1
1
7,986
I don't think this code is being tested; this method can be removed without the test failing
faker-ruby-faker
rb
@@ -298,6 +298,11 @@ public class FrameFragment extends BaseEditFragment { // Asynchronous loading of thumbnails private class asyncThumbs extends AsyncTask<Void, Void, Void> { + @Override + protected void onPreExecute() { + arrayList=new ArrayList<>(); + } + @Overri...
1
package org.fossasia.phimpme.editor.fragment; import android.content.res.AssetManager; import android.graphics.Bitmap; import android.graphics.BitmapFactory; import android.graphics.Canvas; import android.os.AsyncTask; import android.os.Bundle; import android.support.annotation.Nullable; import android.support.v7.widge...
1
12,554
@codepoet2017390 You have already initialized this ArrayList in the onPreExecute method then why do it here too?
fossasia-phimpme-android
java
@@ -0,0 +1,13 @@ +describe Gsa18f::ProcurementPolicy do + subject { described_class } + + permissions :can_create? do + with_feature 'RESTRICT_ACCESS' do + it "doesn't allow someone with a non-GSA email to create" do + user = User.new(email_address: 'intruder@some.com') + procurement = Gsa18f::P...
1
1
13,340
This covers the `RESTRICT_ACCESS=true` x non-gsa pair, but we probably want to test the three other permutations: (`RA=true`, gsa), (`RA=false`, non-gsa), (`RA=false`, gsa)
18F-C2
rb
@@ -18,13 +18,13 @@ define(['dom', 'scroller', 'browser', 'layoutManager', 'focusManager', 'register function onFocus(e) { - if (layoutManager.tv) { + /*if (layoutManager.tv) { if (this.focusTimeout) { clearTimeout(this.focusTimeout); } th...
1
define(['dom', 'scroller', 'browser', 'layoutManager', 'focusManager', 'registerElement', 'css!./emby-tabs', 'scrollStyles'], function (dom, scroller, browser, layoutManager, focusManager) { 'use strict'; var EmbyTabs = Object.create(HTMLDivElement.prototype); var buttonClass = 'emby-tab-button'; var a...
1
11,979
Please don't do this - if you want to disable code permanently delete the code, if you need to disable it to test don't commit. Such sections are very poorly highlighted during review and can cause unspotted issues slipping through the process...
jellyfin-jellyfin-web
js
@@ -23,3 +23,10 @@ import ( type ConnTrackDumper interface { DumpFlows(zoneFilter uint16) ([]*flowexporter.Connection, error) } + +// ConnTrackInterfacer is an interface created to consume the required dump functions from either the third party +// conntrack library or internal packages depending on OVS datapath ty...
1
// Copyright 2020 Antrea Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to...
1
19,291
I'm starting too feel we have too much abstraction and too many interfaces here. But this method is definitely the most confusing IMO. For one, it's called "Get*" but it does not return anything... I don't have a good understanding of what's going on anymore, so it's hard for me to suggest an alternative, but it's pret...
antrea-io-antrea
go
@@ -25,6 +25,7 @@ import com.google.common.collect.HashMultimap; import com.google.common.collect.ImmutableMap; import com.google.common.collect.Multimap; +import org.openqa.selenium.devtools.target.model.SessionId; import org.openqa.selenium.json.Json; import org.openqa.selenium.json.JsonInput; import org.openq...
1
// Licensed to the Software Freedom Conservancy (SFC) under one // or more contributor license agreements. See the NOTICE file // distributed with this work for additional information // regarding copyright ownership. The SFC licenses this file // to you under the Apache License, Version 2.0 (the // "License"); you m...
1
16,697
It fills me with endless sadness that we can't use Selenium's own `SessionId` here.
SeleniumHQ-selenium
rb
@@ -2269,7 +2269,12 @@ public class ZkStateReader implements SolrCloseable { log.debug("Checking ZK for most up to date Aliases {}", ALIASES); // Call sync() first to ensure the subsequent read (getData) is up to date. zkClient.getSolrZooKeeper().sync(ALIASES, null, null); - Stat stat = new St...
1
/* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may ...
1
40,991
Interesting. So you've found that it's faster to request only the "Stat" without the data so long as this is the typical path?
apache-lucene-solr
java
@@ -33,6 +33,7 @@ var skip = map[string]string{ "yield": "yield requires special test case (https://github.com/influxdata/flux/issues/535)", "task_per_line": "join produces inconsistent/racy results when table schemas do not match (https://github.com/influxdata/flux/issues/855)",...
1
package stdlib_test import ( "bytes" "context" "strings" "testing" "github.com/influxdata/flux" "github.com/influxdata/flux/ast" "github.com/influxdata/flux/execute" "github.com/influxdata/flux/lang" "github.com/influxdata/flux/querytest" "github.com/influxdata/flux/stdlib" ) func init() { flux.FinalizeBu...
1
9,973
Is this a future fix? I thought the local identifier scope and the package issue were the same one.
influxdata-flux
go
@@ -247,7 +247,17 @@ class TextInfoQuickNavItem(QuickNavItem): class BrowseModeTreeInterceptor(treeInterceptorHandler.TreeInterceptor): scriptCategory = inputCore.SCRCAT_BROWSEMODE disableAutoPassThrough = False - APPLICATION_ROLES = (controlTypes.ROLE_APPLICATION, controlTypes.ROLE_DIALOG) + + def _isApplicationO...
1
#browseMode.py #A part of NonVisual Desktop Access (NVDA) #Copyright (C) 2007-2017 NV Access Limited, Babbage B.V. #This file is covered by the GNU General Public License. #See the file COPYING for more details. import itertools import collections import winsound import time import weakref import wx from l...
1
22,046
Not super important, but this line could be split up.
nvaccess-nvda
py
@@ -150,6 +150,17 @@ void h2o_context_dispose(h2o_context_t *ctx) h2o_filecache_destroy(ctx->filecache); ctx->filecache = NULL; + /* clear storage */ + for (i = 0; i != ctx->storage.size; ++i) { + h2o_context_storage_item_t item = ctx->storage.entries[i]; + if (item.data != NULL) { + ...
1
/* * Copyright (c) 2014 DeNA Co., Ltd. * * Permission is hereby granted, free of charge, to any person obtaining a copy * of this software and associated documentation files (the "Software"), to * deal in the Software without restriction, including without limitation the * rights to use, copy, modify, merge, publ...
1
11,468
Maybe we should better call the dispose function without checking the value of `item.data` (since the dispose function is setup before `data` is set up).
h2o-h2o
c
@@ -33,6 +33,7 @@ inline void SyncedMemory::to_cpu() { CaffeMallocHost(&cpu_ptr_, size_); own_cpu_data_ = true; } + Caffe::set_mode(Caffe::GPU); caffe_memcpy(size_, gpu_ptr_, cpu_ptr_); head_ = SYNCED; break;
1
// Copyright 2014 BVLC and contributors. #include <cuda_runtime.h> #include <cstring> #include "caffe/common.hpp" #include "caffe/syncedmem.hpp" #include "caffe/util/math_functions.hpp" namespace caffe { SyncedMemory::~SyncedMemory() { if (cpu_ptr_ && own_cpu_data_) { CaffeFreeHost(cpu_ptr_); } if (gpu_...
1
29,361
Why set to GPU, is it CPU?
BVLC-caffe
cpp
@@ -1,10 +1,16 @@ import AppointmentIndexRoute from 'hospitalrun/appointments/index/route'; import moment from 'moment'; import { translationMacro as t } from 'ember-i18n'; +import Ember from 'ember'; + +const { computed } = Ember; + export default AppointmentIndexRoute.extend({ editReturn: 'appointments.today',...
1
import AppointmentIndexRoute from 'hospitalrun/appointments/index/route'; import moment from 'moment'; import { translationMacro as t } from 'ember-i18n'; export default AppointmentIndexRoute.extend({ editReturn: 'appointments.today', modelName: 'appointment', pageTitle: t('appointments.todayTitle'), _modelQue...
1
13,693
This should be `computed('i18n.locale'....`
HospitalRun-hospitalrun-frontend
js
@@ -49,7 +49,7 @@ type Session struct { DataTransferred DataTransferred TokensEarned uint64 Last bool - done chan struct{} + Done chan struct{} } // newSession creates a blank new session with an ID.
1
/* * Copyright (C) 2017 The "MysteriumNetwork/node" Authors. * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation, either version 3 of the License, or * (at your option) any later version. * ...
1
15,998
can we not expose the channel directly? or at least expose it as a read only channel?
mysteriumnetwork-node
go
@@ -88,6 +88,17 @@ AS_IF([test "$YACC" != "bison -y"], [AC_MSG_ERROR([bison not found but required] PKG_PROG_PKG_CONFIG +# PKG_CHECK_VAR added to pkg-config 0.28 +m4_define_default( + [PKG_CHECK_VAR], + [AC_ARG_VAR([$1], [value of $3 for $2, overriding pkg-config]) + AS_IF([test -z "$$1"], [$1=`$PKG_CONF...
1
AC_PREREQ([2.63]) dnl If doing a final release, remember to follow the instructions to dnl update libostree-released.sym from libostree-devel.sym, and update the checksum dnl in test-symbols.sh, and also set is_release_build=yes below. Then make dnl another post-release commit to bump the version, and set is_release_b...
1
11,784
Can we add a `--with-bashcompdir` here to override this? I'd like to be able to do unprivileged builds.
ostreedev-ostree
c
@@ -0,0 +1,13 @@ +package cstor + +import ( + "github.com/openebs/maya/cmd/cstor-volume-grpc/app/command" +) + +func Snapshot(volName, snapName, targetIP string) (interface{}, error) { + return command.CreateSnapshot(volName, snapName, targetIP) +} + +func SnapshotDelete(volName, snapName, targetIP string) (interface{}...
1
1
9,685
We will be removing this maya/volume package completely. Do not use this.
openebs-maya
go
@@ -67,7 +67,7 @@ static train_result call_daal_kernel(const context_gpu& ctx, daal::algorithms::classifier::ModelPtr model_ptr(new daal_knn::Model(column_count)); if (!model_ptr) { - throw bad_alloc(); + throw host_bad_alloc(); } auto knn_model = static_cast<daal_knn::Model*>(mode...
1
/******************************************************************************* * Copyright 2020 Intel Corporation * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.o...
1
24,355
Why you think that `model_ptr` will be `nullptr` when memory allocation is failed? I think `new daal_knn::Model(column_count)` would throw `std::bad_alloc` if `operator new` is not overloaded. Is it overloaded by DAAL in the way it simply returns `nullptr` in case of bad allocation?
oneapi-src-oneDAL
cpp
@@ -42,14 +42,15 @@ type MinerCreateResult struct { var minerCreateCmd = &cmds.Command{ Helptext: cmdkit.HelpText{ - Tagline: "Create a new file miner with <pledge> sectors and <collateral> FIL", + Tagline: "Create a new file miner with <collateral> FIL", ShortDescription: `Issues a new message to the network...
1
package commands import ( "encoding/json" "fmt" "io" "math/big" "strconv" "github.com/ipfs/go-cid" "github.com/ipfs/go-ipfs-cmdkit" "github.com/ipfs/go-ipfs-cmds" "github.com/libp2p/go-libp2p-peer" "github.com/pkg/errors" "github.com/filecoin-project/go-filecoin/address" "github.com/filecoin-project/go-f...
1
19,503
Where does this 0.001 come from? Is this from the network collateral cost function, which happens to be hardcoded right now? I think it's going to rot very quickly: it depends on sector size and (probably) block height.
filecoin-project-venus
go
@@ -0,0 +1,5 @@ +# ----------------------------------------------------------------------------- +# The CodeChecker Infrastructure +# This file is distributed under the University of Illinois Open Source +# License. See LICENSE.TXT for details. +# ------------------------------------------------...
1
1
11,668
Please update the license header in each source file. For more information see: #2697
Ericsson-codechecker
c
@@ -144,8 +144,9 @@ class HttpClient { * @param {function(!Error)} onError The function to call if the request fails. * @param {?string=} opt_data The data to send with the request. * @param {?RequestOptions=} opt_proxy The proxy server to use for the request. + * @param {!number=} retries The current number of r...
1
// Licensed to the Software Freedom Conservancy (SFC) under one // or more contributor license agreements. See the NOTICE file // distributed with this work for additional information // regarding copyright ownership. The SFC licenses this file // to you under the Apache License, Version 2.0 (the // "License"); you m...
1
14,969
!numbers -> numbers
SeleniumHQ-selenium
rb
@@ -64,6 +64,6 @@ namespace AutoRest.Swagger.Validation.Core /// <summary> /// The collection of rules that apply to all properties regardless of other rules. /// </summary> - public static IEnumerable<Rule> UniversalRules = new[] { new NoControlCharacters() }; + public static I...
1
using System; using System.Collections.Generic; using System.Linq; using System.Reflection; using AutoRest.Core.Utilities.Collections; using AutoRest.Core.Utilities; namespace AutoRest.Swagger.Validation.Core { internal static class RulesExtensions { /// <summary> /// Gets an enumerable of prop...
1
24,948
so we don't have universal rules afterwards? In that case I'd remove this entirely (and maybe some places where it's used get cleaner) since we shouldn't ever add a universal rule. Not only because it's way simpler in TS, I'm also just super skeptical about "universal". In case of this rule, even control characters may...
Azure-autorest
java
@@ -115,7 +115,8 @@ module.exports = function exec(command, opt_options) { var proc = childProcess.spawn(command, options.args || [], { env: options.env || process.env, - stdio: options.stdio || 'ignore' + stdio: options.stdio || 'ignore', + detached: true }); // This process should not wait ...
1
// Licensed to the Software Freedom Conservancy (SFC) under one // or more contributor license agreements. See the NOTICE file // distributed with this work for additional information // regarding copyright ownership. The SFC licenses this file // to you under the Apache License, Version 2.0 (the // "License"); you m...
1
13,332
You're welcome to surface this option through the API, but I'm not going to make this the default behavior.
SeleniumHQ-selenium
py
@@ -76,10 +76,10 @@ func buildBinary(source, target string) error { if !ok { targetArch = runtime.GOARCH } - return buildBinaryFor(source, target, targetOS, targetArch) + return buildBinaryFor(source, target, targetOS, targetArch, false) } -func buildBinaryFor(source, target, targetOS, targetArch string) erro...
1
/* * Copyright (C) 2020 The "MysteriumNetwork/node" Authors. * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation, either version 3 of the License, or * (at your option) any later version. * ...
1
17,071
Just a thought that any further extensions of `buildBinaryFor` signature could be done as `buildBinaryFor(..., opts... BuildOptions)` for better readability.
mysteriumnetwork-node
go
@@ -44,8 +44,11 @@ namespace OpenTelemetry.Metrics var options = new InMemoryExporterOptions(); configure?.Invoke(options); - var exporter = new InMemoryMetricExporter(exportedItems, options); - return builder.AddMetricReader(new PeriodicExportingMetricReader(exporter, ...
1
// <copyright file="InMemoryExporterMetricHelperExtensions.cs" company="OpenTelemetry Authors"> // Copyright The OpenTelemetry Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // /...
1
21,285
I'll fix the InMemoryExporter right after this PR lands
open-telemetry-opentelemetry-dotnet
.cs
@@ -11098,7 +11098,7 @@ bool CoreChecks::ValidateCreateSwapchain(const char *func_name, VkSwapchainCreat auto physical_device_state = GetPhysicalDeviceState(); if (physical_device_state->vkGetPhysicalDeviceSurfaceCapabilitiesKHRState == UNCALLED) { - if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT...
1
/* Copyright (c) 2015-2019 The Khronos Group Inc. * Copyright (c) 2015-2019 Valve Corporation * Copyright (c) 2015-2019 LunarG, Inc. * Copyright (C) 2015-2019 Google Inc. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You m...
1
11,109
Good call, none of these are technically invalid
KhronosGroup-Vulkan-ValidationLayers
cpp
@@ -20,7 +20,7 @@ partial class Build .OnlyWhenStatic(() => IsWin) .Executes(() => { - var project = ProfilerDirectory.GlobFiles("**/Datadog.AutoInstrumentation.Profiler.Native.Windows.vcxproj").Single(); + var project = ProfilerDirectory.GlobFiles("**/Datadog.Profiler.N...
1
using Nuke.Common; using Nuke.Common.Tools.DotNet; using Nuke.Common.IO; using System.Linq; using Nuke.Common.Tooling; using Nuke.Common.Tools.MSBuild; using static Nuke.Common.EnvironmentInfo; using static Nuke.Common.IO.FileSystemTasks; using static Nuke.Common.Tools.MSBuild.MSBuildTasks; partial class Build { T...
1
25,233
this one should be updated too
DataDog-dd-trace-dotnet
.cs
@@ -39,6 +39,7 @@ public final class InvocationFactory { operationMeta, swaggerArguments); invocation.addContext(Const.SRC_MICROSERVICE, getMicroserviceName()); + invocation.addContext(Const.SRC_INSTANCE, getInstanceId()); return invocation; }
1
/* * Copyright 2017 Huawei Technologies Co., Ltd * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable l...
1
7,550
maybe need to add microserviceId too.
apache-servicecomb-java-chassis
java
@@ -0,0 +1,6 @@ +"""Tests for missing-param-doc and missing-type-doc for Numpy style docstrings +with accept-no-param-doc = no +""" +# pylint: disable=invalid-name, unused-argument, undefined-variable +# pylint: disable=line-too-long, too-few-public-methods, missing-class-docstring +# pylint: disable=missing-function-d...
1
1
18,964
I'm curious, do you create this commit at the very end by rebasing and taking the value you had after moving everything ?
PyCQA-pylint
py
@@ -939,12 +939,10 @@ describe('Core_alter', () => { expect(spec().$container.find('tr:eq(6) td:eq(0)').html()).toEqual('b1'); }); - it('should not add more source rows than defined in maxRows when trimming rows using the modifyRow hook', () => { + it('should not add more source rows than defined in...
1
describe('Core_alter', () => { const id = 'testContainer'; beforeEach(function() { this.$container = $(`<div id="${id}"></div>`).appendTo('body'); }); afterEach(function() { if (this.$container) { destroy(); this.$container.remove(); } }); const arrayOfNestedObjects = function() {...
1
15,203
It's no longer possible to use `modifyRow` to trim rows and that's ok to use TrimRows instead. But I think we should move this test to TrimRows plugin tests as `trimRows` setting is not a part of the `core`.
handsontable-handsontable
js
@@ -688,6 +688,17 @@ static int on_config_mime_setdefaulttype(h2o_configurator_command_t *cmd, h2o_co return 0; } +static const char *get_ext(h2o_configurator_command_t *cmd, yoml_t *node) +{ + if (strcmp(node->data.scalar, "default") == 0) { + return node->data.scalar; + } else if (assert_is_exte...
1
/* * Copyright (c) 2014-2016 DeNA Co., Ltd., Kazuho Oku, Fastly, Inc. * * Permission is hereby granted, free of charge, to any person obtaining a copy * of this software and associated documentation files (the "Software"), to * deal in the Software without restriction, including without limitation the * rights to...
1
12,482
The function seems to either return "default" or return the extension stripping the preceding dot. Does the fact mean that we can no longer register `.default` as an extension?
h2o-h2o
c
@@ -110,6 +110,8 @@ type Container struct { Image string // ImageID is the local ID of the image used in the container ImageID string + // ImageDigest is the sha-256 digest of the container image as pulled from the repository + ImageDigest string // Command is the command to run in the container which is specif...
1
// Copyright 2014-2018 Amazon.com, Inc. or its affiliates. All Rights Reserved. // // Licensed under the Apache License, Version 2.0 (the "License"). You may // not use this file except in compliance with the License. A copy of the // License is located at // // http://aws.amazon.com/apache2.0/ // // or in the "license...
1
23,337
this may require a statefile version update
aws-amazon-ecs-agent
go
@@ -4,6 +4,9 @@ namespace Shopsys\FrameworkBundle\Component\Csv; use Symfony\Component\Filesystem\Exception\FileNotFoundException; +/** + * @deprecated Class is obsolete and will be removed in the next major. Use SplFileObject::fgetcsv() instead. + */ class CsvReader { /**
1
<?php namespace Shopsys\FrameworkBundle\Component\Csv; use Symfony\Component\Filesystem\Exception\FileNotFoundException; class CsvReader { /** * @param string $filename * @param string $delimiter * @return array */ public function getRowsFromCsv($filename, $delimiter = ';') { ...
1
24,103
I like when `@deprecated` contains how to resolve it - eg. "use `SplFileObject::fgetcsv()` instead". The information in upgrade notes is usefull only during upgrade.
shopsys-shopsys
php
@@ -7,8 +7,8 @@ package mock import ( gomock "github.com/golang/mock/gomock" gcpclient "github.com/openshift/hive/pkg/gcpclient" - v1 "google.golang.org/api/compute/v1" - v10 "google.golang.org/api/dns/v1" + compute "google.golang.org/api/compute/v1" + dns "google.golang.org/api/dns/v1" reflect "reflect" )
1
// Code generated by MockGen. DO NOT EDIT. // Source: ./client.go // Package mock is a generated GoMock package. package mock import ( gomock "github.com/golang/mock/gomock" gcpclient "github.com/openshift/hive/pkg/gcpclient" v1 "google.golang.org/api/compute/v1" v10 "google.golang.org/api/dns/v1" reflect "refle...
1
14,805
Nice to see that your local environment is up-to-date now for these changes.
openshift-hive
go
@@ -1268,7 +1268,13 @@ var AppRouter = Backbone.Router.extend({ } // Init sidebar based on the current url - self.sidebar.init(); + if (countlyVue.sideBarComponent) { + var selectedMenuItem = countlyVue.sideBarComponent.$store.getters["countlySidebar/getSelectedMenuItem"]; +...
1
/* global Backbone, countlyAuth, Handlebars, countlyEvent, countlyCommon, countlyGlobal, CountlyHelpers, countlySession, moment, Drop, _, store, countlyLocation, jQuery, $, T, countlyTaskManager, countlyVue*/ /** * Default Backbone View template from which all countly views should inherit. * A countly view is defined a...
1
14,581
Instead of setting it to null, i think lets set it to {}
Countly-countly-server
js
@@ -23,8 +23,8 @@ import ( ) const ( - TPRGroup = "monitoring.coreos.com" - TPRVersion = "v1alpha1" + Group = "monitoring.coreos.com" + Version = "v1alpha1" ) type MonitoringV1alpha1Interface interface {
1
// Copyright 2016 The prometheus-operator Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable ...
1
8,541
We should bump this before releasing and remove all legacy fields that are safe to do so. Since we cannot have multiple versions anyway there's little value in walking around with the "alpha" stamp.
prometheus-operator-prometheus-operator
go
@@ -59,6 +59,15 @@ AS_CASE($ax_cv_cxx_compiler_vendor, AX_CXX_COMPILE_STDCXX([11], [noext], [mandatory]) X_AC_ENABLE_SANITIZER +if test "x$san_enabled" != "xno" ; then + AC_DEFINE([DEEPBIND], [0], + [deepbind is unsupported with asan, musl and so-forth]) +else + AC_DEFINE([DEEPBIND], [RTLD_DEEPBIND], +...
1
## # Prologue ## AC_INIT([flux-core], m4_esyscmd([git describe --always | awk '/.*/ {sub(/^v/, ""); printf "%s",$1; exit}'])) AC_CONFIG_AUX_DIR([config]) AC_CONFIG_MACRO_DIR([config]) AC_CONFIG_SRCDIR([NEWS]) AC_CANONICAL_SYSTEM ## # If runstatedir not explicitly set on command line, use '/run' as default # N.B...
1
21,601
I might suggest a different name for the `DEEPBIND` config.h macro. Perhaps `FLUX_DEEPBIND` to give a hint in the code that we're using a locally provided define.
flux-framework-flux-core
c
@@ -393,7 +393,7 @@ func init() { proto.RegisterType((*StatusResponse)(nil), "bpfki.StatusResponse") } -func init() { proto.RegisterFile("bpfki.proto", fileDescriptor_62eed357eb71de0e) } +func init() { protoregistry.GlobalFiles.RegisterFile("bpfki.proto", fileDescriptor_62eed357eb71de0e) } var fileDescriptor_62...
1
// Code generated by protoc-gen-go. DO NOT EDIT. // source: bpfki.proto package bpfki import ( context "context" fmt "fmt" math "math" proto "github.com/golang/protobuf/proto" grpc "google.golang.org/grpc" codes "google.golang.org/grpc/codes" status "google.golang.org/grpc/status" ) // Reference imports to s...
1
21,630
Code generated by protoc-gen-go. **DO NOT EDIT.**. The correct way to fix `deprecated` in this file may be updating the protoc / protobuf / grpc and regenerate this file.
chaos-mesh-chaos-mesh
go
@@ -15,6 +15,7 @@ import java.util.List; * * @author Brian Remedios */ +@Deprecated public class IntegerPropertyTest extends AbstractNumericPropertyDescriptorTester<Integer> { private static final int MIN = 1;
1
/** * BSD-style license; for more info see http://pmd.sourceforge.net/license.html */ package net.sourceforge.pmd.properties; import java.util.List; /** * Evaluates the functionality of the IntegerProperty descriptor by testing its * ability to catch creation errors (illegal args), flag out-of-range test * val...
1
14,995
We should make sure that we cover the testcases in a new unit test class.
pmd-pmd
java
@@ -0,0 +1,19 @@ +package proofs + +// #cgo LDFLAGS: -L${SRCDIR}/../proofs/lib -lfilecoin_proofs +// #cgo pkg-config: ${SRCDIR}/../proofs/lib/pkgconfig/libfilecoin_proofs.pc +// #include "../proofs/include/libfilecoin_proofs.h" +import "C" +import ( + "unsafe" +) + +func SectorSize(ssType Mode) uint64 { + scfg, err := ...
1
1
18,399
Is this only used in test code? Is there future utility in it for production code? If not, it would be nice if this could be moved into a test package. I'm not sure how hard that would be. CC @laser
filecoin-project-venus
go
@@ -192,7 +192,7 @@ func (p *Plugin) setConfig(config *pluginConfig) error { p.cancelWatcher() p.cancelWatcher = nil } - if config.WebhookLabel != "" { + if config.WebhookLabel != "" || config.APIServiceLabel != "" { p.cancelWatcher = cancelWatcher }
1
package k8sbundle import ( "bytes" "context" "encoding/json" "encoding/pem" "errors" "fmt" "strings" "sync" "github.com/hashicorp/go-hclog" "github.com/hashicorp/hcl" "github.com/spiffe/spire-plugin-sdk/pluginsdk" "github.com/spiffe/spire/pkg/common/catalog" "github.com/spiffe/spire/proto/spire/common" ...
1
16,533
Super curious how you noticed this, as SPIRE itself currently only configures once...?
spiffe-spire
go
@@ -21,11 +21,18 @@ public class NotFoundExceptionHandler implements ExceptionMapper<NotFoundExcepti @Override public Response toResponse(NotFoundException ex){ String uri = request.getRequestURI(); + String exMessage = ex.getMessage(); + String outputMessage; + if (exMessage !=...
1
package edu.harvard.iq.dataverse.api.errorhandlers; import javax.json.Json; import javax.servlet.http.HttpServletRequest; import javax.ws.rs.NotFoundException; import javax.ws.rs.core.Context; import javax.ws.rs.core.Response; import javax.ws.rs.ext.ExceptionMapper; import javax.ws.rs.ext.Provider; /** * Produces cu...
1
37,771
This `startsWith` seems a bit brittle because in the code base we'll occasionally spell it "DataFile".
IQSS-dataverse
java
@@ -18,5 +18,6 @@ package azkaban.db; public class AzDBUtil { - static final int MAX_DB_RETRY_COUNT = 5; + // A very big Integer + static final int MAX_DB_RETRY_COUNT = 999999; }
1
/* * Copyright 2017 LinkedIn Corp. * * Licensed under the Apache License, Version 2.0 (the "License"); you may not * use this file except in compliance with the License. You may obtain a copy of * the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to i...
1
14,593
if it keeps reconnecting for too long, how should we get alerted?
azkaban-azkaban
java
@@ -263,7 +263,11 @@ void* CNSKListenerSrvr::OpenTCPIPSession() //LCOV_EXCL_STOP } - + TCP_SetKeepalive(nSocketFnum, + srvrGlobal->clientKeepaliveStatus, + srvrGlobal->clientKeepaliveIdletime, + srvrGlobal->clientKeepaliveIntervaltime, + srvrGlobal->clientKeepaliveRet...
1
/********************************************************************** // @@@ START COPYRIGHT @@@ // // Licensed to the Apache Software Foundation (ASF) under one // or more contributor license agreements. See the NOTICE file // distributed with this work for additional information // regarding copyright ownership. ...
1
20,377
it's better to use single name style in one name.
apache-trafodion
cpp
@@ -70,7 +70,7 @@ bool EprosimaServer::init() { //CREATE RTPSParticipant ParticipantAttributes PParam; - PParam.rtps.defaultSendPort = 10042; + //PParam.rtps.defaultSendPort = 10042; // TODO Create transport? PParam.rtps.builtin.domainId = 80; PParam.rtps.builtin.use_SIMPLE_EndpointDiscoveryProtocol = true; ...
1
// Copyright 2016 Proyectos y Sistemas de Mantenimiento SL (eProsima). // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless re...
1
12,893
As defaultSendPort is being removed, and I don't like TODOs on examples, please remove the whole line
eProsima-Fast-DDS
cpp
@@ -95,7 +95,8 @@ func (cf CloudFormation) DelegateDNSPermissions(project *archer.Project, account deployProject.DNSDelegationAccounts = append(dnsDelegatedAccounts, accountID) updatedProjectConfig := stack.NewProjectStackConfig(&deployProject) - if err := cf.update(updatedProjectConfig); err != nil { + // swallo...
1
// Copyright 2019 Amazon.com, Inc. or its affiliates. All Rights Reserved. // SPDX-License-Identifier: Apache-2.0 package cloudformation import ( "context" "errors" "fmt" "time" "github.com/aws/amazon-ecs-cli-v2/internal/pkg/archer" "github.com/aws/amazon-ecs-cli-v2/internal/pkg/deploy" "github.com/aws/amazon...
1
12,243
Should we return `nil` when `err == errChangeSetEmpty` instead of calling l.103 `WaitUntilStackUpdateCompleteWithContext`?
aws-copilot-cli
go
@@ -153,13 +153,12 @@ public abstract class VectorWriter implements Closeable { private final DocIDMerger<VectorValuesSub> docIdMerger; private final int[] ordBase; private final int cost; - private final int size; + private int size; private int docId; private VectorValuesSub current; ...
1
/* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may ...
1
39,677
Hmmm I thought spotless would wrap this line, but it doesn't seem to complain about it
apache-lucene-solr
java
@@ -47,10 +47,11 @@ type Selector struct { // SpiffeIDSpec defines the desired state of SpiffeID type SpiffeIDSpec struct { - ParentId string `json:"parentId"` - SpiffeId string `json:"spiffeId"` - Selector Selector `json:"selector"` - DnsNames []string `json:"dnsNames,omitempty"` + ParentId string `json...
1
/* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License ...
1
16,095
I think this will require updating the api version. we are planning to do this anyways, so perhaps we can lump this in so we don't have to update too many times?
spiffe-spire
go
@@ -215,13 +215,12 @@ public abstract class RSSceneMixin implements RSScene for (int z = minLevel; z < maxY; ++z) { - RSTile[][] planeTiles = tiles[z]; for (int x = minTileX; x < maxTileX; ++x) { for (int y = minTileZ; y < maxTileZ; ++y) { - RSTile tile = planeTiles[x][y]; + RSTile...
1
/* * Copyright (c) 2018 Abex * All rights reserved. * * Redistribution and use in source and binary forms, with or without * modification, are permitted provided that the following conditions are met: * * 1. Redistributions of source code must retain the above copyright notice, this * list of conditions and ...
1
16,464
revert this for parity
open-osrs-runelite
java
@@ -15,6 +15,10 @@ #include <valgrind/helgrind.h> #endif +#define INITIAL_BATCH 100 +#define INCR_BATCH 50 +#define DECR_BATCH 25 + enum { FLAG_BLOCKED = 1 << 0,
1
#define PONY_WANT_ATOMIC_DEFS #include "actor.h" #include "../sched/scheduler.h" #include "../sched/cpu.h" #include "../mem/pool.h" #include "../gc/cycle.h" #include "../gc/trace.h" #include <string.h> #include <stdio.h> #include <assert.h> #include <dtrace.h> #ifdef USE_VALGRIND #include <valgrind/helgrind.h> #endif...
1
9,335
INCR_BATCH and DECR_BATCH could be exposed as tuneable command line options but that might be too low level to expose. I think keeping private for now where "in the know" folks could use to try and tune makes sense. These values were choosen mostly "at random" and have worked out for us thus far.
ponylang-ponyc
c
@@ -27,6 +27,11 @@ static tagWriter *writerTable [WRITER_COUNT] = { static tagWriter *writer; +extern void setCustomTagWriter(tagWriter *w) +{ + writer = w; +} + extern void setTagWriter (writerType wtype) { writer = writerTable [wtype];
1
/* * Copyright (c) 2016, Red Hat, Inc. * Copyright (c) 2016, Masatake YAMATO * * This source code is released for free distribution under the terms of the * GNU General Public License version 2 or (at your option) any later version. * */ #include "general.h" #include "entry_p.h" #include "writer_p.h" extern t...
1
17,618
Currently this isn't very clean because we have to re-use some of the predefined parser types - the demo uses WRITER_U_CTAGS but there should be some support for custom writer type.
universal-ctags-ctags
c
@@ -1,6 +1,7 @@ module RequestSpecHelper def get_json(url) get(url) + puts response.pretty_inspect JSON.parse(response.body) end
1
module RequestSpecHelper def get_json(url) get(url) JSON.parse(response.body) end # requires IntegrationSpecHelper def login_as(user) setup_mock_auth(:myusa, user) get '/auth/myusa/callback' end def time_to_json(time) time.utc.iso8601(3) end # Add support for testing `options` req...
1
17,224
I think this was left it accidentally :)
18F-C2
rb
@@ -64,12 +64,12 @@ func IsNamespaceSupported(ns NamespaceType) bool { func NamespaceTypes() []NamespaceType { return []NamespaceType{ + NEWUSER, // Keep user NS always first, don't move it. + NEWIPC, + NEWUTS, NEWNET, NEWPID, NEWNS, - NEWUTS, - NEWIPC, - NEWUSER, } }
1
// +build linux freebsd package configs import ( "fmt" "os" "sync" ) const ( NEWNET NamespaceType = "NEWNET" NEWPID NamespaceType = "NEWPID" NEWNS NamespaceType = "NEWNS" NEWUTS NamespaceType = "NEWUTS" NEWIPC NamespaceType = "NEWIPC" NEWUSER NamespaceType = "NEWUSER" ) var ( nsLock syn...
1
14,671
Can you finish re-ordering this list to match the one that was deleted?
opencontainers-runc
go