patch
stringlengths
17
31.2k
y
int64
1
1
oldf
stringlengths
0
2.21M
idx
int64
1
1
id
int64
4.29k
68.4k
msg
stringlengths
8
843
proj
stringclasses
212 values
lang
stringclasses
9 values
@@ -67,11 +67,11 @@ public abstract class AbstractWebDriverEventListener implements WebDriverEventLi // Do nothing. } - public void beforeChangeValueOf(WebElement element, WebDriver driver) { + public void beforeChangeValueOf(WebElement element, WebDriver driver, CharSequence[] value) { // Do nothing. ...
1
// Licensed to the Software Freedom Conservancy (SFC) under one // or more contributor license agreements. See the NOTICE file // distributed with this work for additional information // regarding copyright ownership. The SFC licenses this file // to you under the Apache License, Version 2.0 (the // "License"); you m...
1
12,802
change 'value' to keysToSend, here and in other references in this commit. 'value' implies the user is getting the value of the element, rather than just the keys we're sending to it.
SeleniumHQ-selenium
js
@@ -1244,6 +1244,8 @@ func (engine *DockerTaskEngine) provisionContainerResources(task *apitask.Task, taskIP := result.IPs[0].Address.IP.String() seelog.Infof("Task engine [%s]: associated with ip address '%s'", task.Arn, taskIP) engine.state.AddTaskIPAddress(taskIP, task.Arn) + task.SetLocalIPAddress(taskIP) + e...
1
// Copyright Amazon.com Inc. or its affiliates. All Rights Reserved. // // Licensed under the Apache License, Version 2.0 (the "License"). You may // not use this file except in compliance with the License. A copy of the // License is located at // // http://aws.amazon.com/apache2.0/ // // or in the "license" file acco...
1
24,702
is the plan to fully migrate to boltdb and then remove the state save here?
aws-amazon-ecs-agent
go
@@ -153,6 +153,8 @@ function themeStyle(theme) { output.colorUrl = '#7B81FF'; + output.strongTextColor = 'rgb(220,220,220)'; + themeCache_[theme] = output; return addExtraStyles(themeCache_[theme]); }
1
const Setting = require('lib/models/Setting.js'); const { Platform } = require('react-native'); const globalStyle = { fontSize: 16, margin: 15, // No text and no interactive component should be within this margin itemMarginTop: 10, itemMarginBottom: 10, backgroundColor: '#ffffff', color: '#555555', // For regula...
1
13,787
This should be `output.colorBright`. Unless I'm missing some reason for adding a new theme variable.
laurent22-joplin
js
@@ -6,6 +6,11 @@ import os +version_year=2016 +version_major=3 +version_minor=0 +version_build=0 + def _updateVersionFromVCS(): """Update the version from version control system metadata if possible. """
1
#versionInfo.py #A part of NonVisual Desktop Access (NVDA) #Copyright (C) 2006-2016 NV Access Limited #This file is covered by the GNU General Public License. #See the file COPYING for more details. import os def _updateVersionFromVCS(): """Update the version from version control system metadata if possible...
1
18,224
nit: I wonder if these should be moved down to where version is defined, just to keep them all in the same place.
nvaccess-nvda
py
@@ -99,7 +99,7 @@ const LanguageParameters& GetLangParams(IDLOptions::Language lang) { "", "", "", - "import java.nio.*;\nimport java.lang.*;\nimport java.util.*;\n" + "import java.nio.*;\nimport java.lang.*;\nimport java.util.*;\nimport javax.annotation.*;\n" "import com.google....
1
/* * Copyright 2014 Google Inc. All rights reserved. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applica...
1
12,531
Is this supported by every implementation of Java (and Android)? Should it be conditional upon `gen_nullable`?
google-flatbuffers
java
@@ -50,8 +50,8 @@ class Phase < ActiveRecord::Base has_many :suffix_sections, -> (phase) { modifiable.where(<<~SQL, phase_id: phase.id, modifiable: false) sections.number > (SELECT MAX(number) FROM sections - WHERE sections.modifiable = :modifiable) - A...
1
# == Schema Information # # Table name: phases # # id :integer not null, primary key # description :text # modifiable :boolean # number :integer # slug :string # title :string # created_at :datetime # updated_at :datetime # template_id :integer # # Indexes # # index_phas...
1
17,848
@briri Thanks! I just caught this too updating my feature branch
DMPRoadmap-roadmap
rb
@@ -214,8 +214,17 @@ var errorConfigFileNotFound = errors.New("config file not found") // automatically decrypt it. func loadConfigFile() (*goconfig.ConfigFile, error) { b, err := ioutil.ReadFile(ConfigPath) + envpw := os.Getenv("RCLONE_CONFIG_PASS") if err != nil { if os.IsNotExist(err) { + if len(configKey...
1
// Package config reads, writes and edits the config file and deals with command line flags package config import ( "bufio" "bytes" "crypto/rand" "crypto/sha256" "encoding/base64" "encoding/json" "fmt" "io" "io/ioutil" "log" mathrand "math/rand" "os" "path/filepath" "regexp" "runtime" "sort" "strconv"...
1
8,707
I think you should move this block (and the `envpw := os.Getenv("RCLONE_CONFIG_PASS")`) right to the start of the function, then we can remove the duplicate code below
rclone-rclone
go
@@ -424,6 +424,17 @@ public class NodeTest { return baseDir; } + //Test that the draining command sets Host status to DRAINING + @Test + public void drainingNodeStatusDraining() { + + } + + //Test that a draining node doesn't accept new sessions by any means + //Test that a draining node continues to ru...
1
// Licensed to the Software Freedom Conservancy (SFC) under one // or more contributor license agreements. See the NOTICE file // distributed with this work for additional information // regarding copyright ownership. The SFC licenses this file // to you under the Apache License, Version 2.0 (the // "License"); you m...
1
17,748
Is this only to set the node to draining? I think we can do that inside `Before` or something?
SeleniumHQ-selenium
java
@@ -647,6 +647,11 @@ namespace Datadog.Trace { try { + if (AzureAppServices.Metadata.IsRelevant) + { + return AzureAppServices.Metadata.SiteName; + } + if (TryLoadAspNetSit...
1
// <copyright file="Tracer.cs" company="Datadog"> // Unless explicitly stated otherwise all files in this repository are licensed under the Apache 2 License. // This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc. // </copyright> using System; using System.Coll...
1
23,757
This should have been moved up above this inner `try` because the log message in the `catch` block does not apply to this.
DataDog-dd-trace-dotnet
.cs
@@ -43,12 +43,13 @@ module Bolt Bolt::ResultSet.include_iterable end - # Create a top-level alias for TargetSpec so that users don't have to + # Create a top-level alias for TargetSpec and PlanResult so that users don't have to # namespace it with Boltlib, which is just an implementation detail...
1
# frozen_string_literal: true require 'bolt/executor' require 'bolt/error' module Bolt class PAL BOLTLIB_PATH = File.join(__FILE__, '../../../bolt-modules') MODULES_PATH = File.join(__FILE__, '../../../modules') def initialize(config) # Nothing works without initialized this global state. Reiniti...
1
8,456
Do we expect people to use PlanResult directly?
puppetlabs-bolt
rb
@@ -48,7 +48,8 @@ func NewBackoff() wait.Backoff { // WaitForWithRetryable repeats a condition check with exponential backoff. func WaitForWithRetryable(backoff wait.Backoff, condition wait.ConditionFunc, retryableErrors ...string) error { //nolint - return wait.ExponentialBackoff(backoff, func() (bool, error) { + ...
1
/* Copyright 2018 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, ...
1
11,608
Maybe we should call this something like `errToReturn`?
kubernetes-sigs-cluster-api-provider-aws
go
@@ -215,7 +215,8 @@ func (p *Protocol) GrantEpochReward( } // Reward additional bootstrap bonus - if epochNum <= a.foundationBonusLastEpoch { + fairBankEpochNum := rp.GetEpochNum(hu.FairbankBlockHeight()) // extend foundation bonus from fairbank to fairbank + 1 year + if epochNum <= a.foundationBonusLastEpoch || ...
1
// Copyright (c) 2019 IoTeX Foundation // This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no // warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent // permitted by law, all liability for your use...
1
21,695
should calculate numEpochIn1Year = xxx and <= fairBankEpochNum+numEpochIn1Year a.foundationBonusLastEpoch just happens to be equal to 1 year now, but should not count on that
iotexproject-iotex-core
go
@@ -350,14 +350,17 @@ const htmlElms = { }, usemap: { matches: '[usemap]', - contentTypes: ['interactive', 'embedded', 'phrasing', 'flow'] + contentTypes: ['interactive', 'embedded', 'flow'] }, default: { // Note: allow role presentation and none on image with...
1
// Source: https://www.w3.org/TR/html-aria/#allowed-aria-roles-states-and-properties // Source: https://www.w3.org/TR/html-aam-1.0/#html-element-role-mappings // Source https://html.spec.whatwg.org/multipage/dom.html#content-models // Source https://dom.spec.whatwg.org/#dom-element-attachshadow const htmlElms = { a: ...
1
16,507
I wasn't sure if the content type needed to be removed from both the `default` and `usemap` objects - I'm not sure how usemap is used.
dequelabs-axe-core
js
@@ -20,11 +20,13 @@ """ Geneve: Generic Network Virtualization Encapsulation -draft-ietf-nvo3-geneve-06 +draft-ietf-nvo3-geneve-16 """ +import struct + from scapy.fields import BitField, XByteField, XShortEnumField, X3BytesField, \ - XStrField + XStrField, XShortField, StrField, XByteField, FieldLenField,...
1
# Copyright (C) 2018 Hao Zheng <haozheng10@gmail.com> # This file is part of Scapy # Scapy is free software: you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free Software Foundation, either version 2 of the License, or # any later version. # # Scapy is...
1
19,682
Duplication of line 28 Please refer your tox -e flake8 It seems that XStrField, XShortField, FieldLenField are not used
secdev-scapy
py
@@ -630,6 +630,18 @@ class FilenamePrompt(_BasePrompt): self._to_complete = '' + def _directories_hide_show_model(self, path): + """Get rid of non-matching directories.""" + try: + num_rows = self._file_model.rowCount(self._root_index) + for row in range(num_rows): + ...
1
# vim: ft=python fileencoding=utf-8 sts=4 sw=4 et: # Copyright 2016-2021 Florian Bruhin (The Compiler) <mail@qutebrowser.org> # # This file is part of qutebrowser. # # qutebrowser is free software: you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free S...
1
26,182
I don't really understand the `self._file_model.index(path)` as parent here - you use `self._root_index` for `rowCount` above, so wouldn't the parent here need to be `self._root_index` as well?
qutebrowser-qutebrowser
py
@@ -75,6 +75,8 @@ public class DirectSpellChecker { private float thresholdFrequency = 0f; /** minimum length of a query word to return suggestions */ private int minQueryLength = 4; + /** maximum length of a query word to return suggestions */ + private int maxQueryLength = 0; /** value in [0..1] (or abs...
1
/* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may ...
1
31,620
Do we want validation somewhere that max >= min? Or simply treat the max < min case as ignoring max?
apache-lucene-solr
java
@@ -81,7 +81,7 @@ namespace NLog.LayoutRenderers { if (TopFrames == 1) { - // Allows fast rendering of ${when:when='${ndc:topframes=1}' == '':inner=:else=${ndc}|} + // Allows fast rendering of ${ndc:topframes=1} var topFrame = NestedDiagn...
1
// // Copyright (c) 2004-2019 Jaroslaw Kowalski <jaak@jkowalski.net>, Kim Christensen, Julian Verdurmen // // All rights reserved. // // Redistribution and use in source and binary forms, with or without // modification, are permitted provided that the following conditions // are met: // // * Redistributions of s...
1
18,908
:+1: that's a easier example :)
NLog-NLog
.cs
@@ -117,4 +117,9 @@ interface ProductQueryInterface * @return AttributeId[] */ public function findAttributeIdsByProductId(ProductId $productId): array; + + /** + * @return array + */ + public function findProductIdsWithBoundAttributeByAttributeId(AggregateId $id): array; }
1
<?php /** * Copyright © Bold Brand Commerce Sp. z o.o. All rights reserved. * See LICENSE.txt for license details. */ declare(strict_types=1); namespace Ergonode\Product\Domain\Query; use Ergonode\Product\Domain\ValueObject\Sku; use Ergonode\SharedKernel\Domain\Aggregate\AttributeId; use Ergonode\SharedKernel\Do...
1
9,678
If an external module decorates this interface, such a change will cause it to generate an error
ergonode-backend
php
@@ -254,7 +254,7 @@ static int jobtap_remove (struct jobtap *jobtap, while (p) { const char *name = jobtap_plugin_name (p); if (all - || (isglob && fnmatch (arg, name, 0) == 0) + || (isglob && fnmatch (arg, name, FNM_PERIOD) == 0) || strcmp (arg, name) == 0) { ...
1
/************************************************************\ * Copyright 2020 Lawrence Livermore National Security, LLC * (c.f. AUTHORS, NOTICE.LLNS, COPYING) * * This file is part of the Flux resource manager framework. * For details, see https://github.com/flux-framework. * * SPDX-License-Identifier: LGPL-3....
1
31,195
Oh ha hah, FNM_PERIOD worked out nicely there. Points for co-opting a file system convention.
flux-framework-flux-core
c
@@ -7,11 +7,12 @@ package action import ( + "encoding/hex" "fmt" - "math/big" - "github.com/spf13/cobra" "go.uber.org/zap" + "math/big" + "strings" "github.com/iotexproject/iotex-core/action" "github.com/iotexproject/iotex-core/cli/ioctl/cmd/account"
1
// Copyright (c) 2019 IoTeX // This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no // warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent // permitted by law, all liability for your use of the cod...
1
17,978
wrong grouping. As you can tell from the other files, we put system packages in the first group, the 3rd party packages in the second group, and our own packages in the third group.
iotexproject-iotex-core
go
@@ -78,8 +78,10 @@ func newJobLogOpts(vars jobLogsVars) (*jobLogsOpts, error) { // Validate returns an error if the values provided by flags are invalid. func (o *jobLogsOpts) Validate() error { if o.appName != "" { - _, err := o.configStore.GetApplication(o.appName) - if err != nil { + if _, err := o.configStor...
1
// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. // SPDX-License-Identifier: Apache-2.0 package cli import ( "errors" "fmt" "github.com/aws/aws-sdk-go/aws" "github.com/aws/copilot-cli/internal/pkg/aws/sessions" "github.com/aws/copilot-cli/internal/pkg/config" "github.com/aws/copilot-cli/in...
1
19,093
Is `o.name` always set here?
aws-copilot-cli
go
@@ -73,7 +73,8 @@ func dependenciesCanBeResolved(target *api.Container, by []*api.Container) bool } return verifyStatusResolvable(target, nameMap, neededVolumeContainers, volumeCanResolve) && - verifyStatusResolvable(target, nameMap, linksToContainerNames(target.Links), linkCanResolve) + verifyStatusResolvable(...
1
// Copyright 2014-2017 Amazon.com, Inc. or its affiliates. All Rights Reserved. // // Licensed under the Apache License, Version 2.0 (the "License"). You may // not use this file except in compliance with the License. A copy of the // License is located at // // http://aws.amazon.com/apache2.0/ // // or in the "license...
1
17,533
Can this line be removed, as `SteadyStateDependencies` isn't updated anywhere? Also do we need to check the `TransitionDependencySet` here?
aws-amazon-ecs-agent
go
@@ -73,7 +73,7 @@ class User < ActiveRecord::Base end def eligible_for_annual_upgrade? - plan.present? && plan.has_annual_plan? + has_active_subscription? && plan.present? && plan.has_annual_plan? end def annualized_payment
1
class User < ActiveRecord::Base include Clearance::User has_many :attempts, dependent: :destroy has_many :beta_replies, dependent: :destroy, class_name: "Beta::Reply" has_many :collaborations, dependent: :destroy has_many :statuses, dependent: :destroy has_many :subscriptions, dependent: :destroy belongs...
1
16,772
`plan.present?` and `has_active_subscription?` are equivalent. We can drop this change, while leaving the one on `app/controllers/application_controller.rb`.
thoughtbot-upcase
rb
@@ -100,6 +100,7 @@ class Command: if scope != 'global' and instance is None: raise ValueError("Setting scope without setting instance makes " "no sense!") + # pylint: enable=too-many-locals self.name = name self.maxsplit = maxsplit
1
# vim: ft=python fileencoding=utf-8 sts=4 sw=4 et: # Copyright 2014-2017 Florian Bruhin (The Compiler) <mail@qutebrowser.org> # # This file is part of qutebrowser. # # qutebrowser is free software: you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free S...
1
19,412
No need for this, as pylint already only turns things off for this function and it's needed for the entire function.
qutebrowser-qutebrowser
py
@@ -188,7 +188,7 @@ func (c *Operator) bootstrap(ctx context.Context) error { } c.secrInfs, err = informers.NewInformersForResource( informers.NewKubeInformerFactories( - c.config.Namespaces.AllowList, + c.config.Namespaces.AlertmanagerConfigAllowList, c.config.Namespaces.DenyList, c.kclient, res...
1
// Copyright 2016 The prometheus-operator Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable ...
1
17,284
L171 needs to be modified too?
prometheus-operator-prometheus-operator
go
@@ -19,6 +19,16 @@ See the file COPYING for details. #include <stdlib.h> #include <unistd.h> +int dag_node_comp(void *item, const void *arg) +{ + struct dag_node *d = ((struct dag_node *) item); + struct dag_node *e = ((struct dag_node *) arg); + + if(d->nodeid == e->nodeid) + return 1; + return 0; +} + struct da...
1
/* Copyright (C) 2014- The University of Notre Dame This software is distributed under the GNU General Public License. See the file COPYING for details. */ #include "dag.h" #include "dag_node.h" #include "debug.h" #include "rmsummary.h" #include "list.h" #include "stringtools.h" #include "xxmalloc.h" #include "jx.h" ...
1
12,658
Why do you compare by nodeid? Simply saying d == e should be enough. Unless we have to objects in memory with the same nodeid. If that is so, something went really wrong.
cooperative-computing-lab-cctools
c
@@ -0,0 +1,18 @@ +_base_ = [ + '../_base_/models/retinanet_r50_fpn.py', + '../_base_/datasets/coco_detection.py', + '../_base_/schedules/schedule_1x.py', '../_base_/default_runtime.py' +] +model = dict( + type='RetinaNet', + backbone=dict( + _delete_=True, + type='PyramidVisionTransformer',...
1
1
25,004
configs/pvt/retinanet_pvt_t_fpn_1x_coco.py --> configs/pvt/retinanet_pvt-t_fpn_1x_coco.py
open-mmlab-mmdetection
py
@@ -20,7 +20,7 @@ type MetadataResponse struct { type TaskResponse struct { Arn string - DesiredStatus string + DesiredStatus string `json:"DesiredStatus,omitempty"` KnownStatus string Family string Version string
1
// Copyright 2014-2015 Amazon.com, Inc. or its affiliates. All Rights Reserved. // // Licensed under the Apache License, Version 2.0 (the "License"). You may // not use this file except in compliance with the License. A copy of the // License is located at // // http://aws.amazon.com/apache2.0/ // // or in the "license...
1
13,287
Nit, this could be json:",omitempty"
aws-amazon-ecs-agent
go
@@ -113,7 +113,12 @@ func tplDirName(s string) string { return filepath.Dir(s) } -//BuildArgs returns a docker.BuildArguments object given a ws root directory. +// BuildRequired returns if the service requires building from the local Dockerfile. +func (s *LoadBalancedWebService) BuildRequired() (bool, error) { + r...
1
// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. // SPDX-License-Identifier: Apache-2.0 package manifest import ( "path/filepath" "github.com/aws/aws-sdk-go/aws" "github.com/aws/copilot-cli/internal/pkg/template" "github.com/imdario/mergo" ) const ( lbWebSvcManifestPath = "workloads/servic...
1
15,291
It's kinda funny to read `s.Image.Image` I wonder why it resulted to this way. What would it take to refactor to just `s.Image`?
aws-copilot-cli
go
@@ -1,4 +1,4 @@ -// +build integration +// +build integration,deploy // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. // SPDX-License-Identifier: Apache-2.0
1
// +build integration // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. // SPDX-License-Identifier: Apache-2.0 package cloudformation_test import ( "fmt" "os" "testing" "github.com/aws/aws-sdk-go/aws" awsCF "github.com/aws/aws-sdk-go/service/cloudformation" "github.com/stretchr/testify/req...
1
16,469
nit: I like the idea! can we instead change the tag to `integration-remote` to be more specific? I feel like it's possible for us to use the `deploy` build tag for possibly another scenario
aws-copilot-cli
go
@@ -4701,8 +4701,8 @@ XS(XS_Mob_HasNPCSpecialAtk) { XS(XS_Mob_SendAppearanceEffect); /* prototype to pass -Wmissing-prototypes */ XS(XS_Mob_SendAppearanceEffect) { dXSARGS; - if (items < 2 || items > 7) - Perl_croak(aTHX_ "Usage: Mob::SendAppearanceEffect(THIS, int32 param_1, [int32 param_2 = 0], [int32 param_3 = ...
1
#include "../common/features.h" #ifdef EMBPERL_XS_CLASSES #include "../common/global_define.h" #include "embperl.h" #ifdef seed #undef seed #endif typedef const char Const_char; #include "mob.h" #include "client.h" #include "../common/spdat.h" #include "dialogue_window.h" #ifdef BOTS #include "bot.h" #endif #ifd...
1
11,068
Copy and paste error here. Edit: Also missing commas here and in other Perl croaks between some parameters and not others.
EQEmu-Server
cpp
@@ -16,11 +16,12 @@ using System.Collections.Generic; using Nethermind.Core; +using Nethermind.Core.Crypto; namespace Nethermind.Consensus { public interface IPendingTxSelector { - IEnumerable<Transaction> SelectTransactions(long gasLimit); + IEnumerable<Transaction> SelectTransactions(K...
1
// Copyright (c) 2018 Demerzel Solutions Limited // This file is part of the Nethermind library. // // The Nethermind library is free software: you can redistribute it and/or modify // it under the terms of the GNU Lesser General Public License as published by // the Free Software Foundation, either version 3 of...
1
23,503
stateRoot or maybe ParentHeader would make more sense from API point of view?
NethermindEth-nethermind
.cs
@@ -151,7 +151,6 @@ public class PlaybackServiceFlavorHelper { // hardware volume buttons control the local device volume mediaRouter.setMediaSessionCompat(null); unregisterWifiBroadcastReceiver(); - callback.setupNotification(false, info); ...
1
package de.danoeh.antennapod.core.service.playback; import android.content.BroadcastReceiver; import android.content.Context; import android.content.Intent; import android.content.IntentFilter; import android.net.NetworkInfo; import android.net.wifi.WifiManager; import android.os.Bundle; import android.support.annotat...
1
14,258
Are you sure that this is no longer needed?
AntennaPod-AntennaPod
java
@@ -57,7 +57,11 @@ class BaseTableScan implements TableScan { private static final Logger LOG = LoggerFactory.getLogger(TableScan.class); private static final SimpleDateFormat DATE_FORMAT = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss.SSS"); - private static final List<String> SNAPSHOT_COLUMNS = ImmutableList.of(...
1
/* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you ...
1
13,733
Would it help to use SCAN_COLUMNS as base to build SCAN_WITH_STATS_COLUMNS e.g like so `SCAN_WITHSTATS_COLUMNS = ImmutableList.<String>builder().addAll(SCAN_COLUMNS).add("value_counts",....).build()` ?
apache-iceberg
java
@@ -85,11 +85,19 @@ func (a *PipedAPI) Register(server *grpc.Server) { // Ping is periodically sent to report its realtime status/stats to control-plane. // The received stats will be pushed to the metrics collector. +// Note: This service is deprecated, use ReportStat instead. func (a *PipedAPI) Ping(ctx context....
1
// Copyright 2020 The PipeCD Authors. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agree...
1
17,770
`ctx` is unused in ReportStat
pipe-cd-pipe
go
@@ -21,12 +21,15 @@ #include <fstream> #include <iostream> #include <vector> +#include <list> +#include <map> #include <stdlib.h> #include <sys/stat.h> #include <sys/types.h> #include <sstream> #include <algorithm> + #include "t_generator.h" #include "platform.h" #include "version.h"
1
/* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you ma...
1
11,959
We don't want to add boost as a dependency when building the Thrift compiler. Sorry.
apache-thrift
c
@@ -323,7 +323,8 @@ bool Monsters::deserializeSpell(const pugi::xml_node& node, spellBlock_t& sb, co combat->setParam(COMBAT_PARAM_TYPE, COMBAT_HEALING); combat->setParam(COMBAT_PARAM_AGGRESSIVE, 0); } else if (tmpName == "speed") { - int32_t speedChange = 0; + int32_t minSpeedChange = 0; + int32_t max...
1
/** * The Forgotten Server - a free and open-source MMORPG server emulator * Copyright (C) 2019 Mark Samman <mark.samman@gmail.com> * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; eithe...
1
16,571
It's not printing the range. Also I think it's useful to print a warning above stating that the minimum change is -1000.
otland-forgottenserver
cpp
@@ -332,3 +332,15 @@ func (c *clusterClient) SchedPolicyDelete(name string) error { return nil } + +// SchedPolicyGet returns schedule policy matching given name. +func (c *clusterClient) SchedPolicyGet(name string) (*sched.SchedPolicy, error) { + policy := new(sched.SchedPolicy) + req := c.c.Get().Resource(cluste...
1
package cluster import ( "errors" "strconv" "time" "github.com/libopenstorage/openstorage/api" "github.com/libopenstorage/openstorage/api/client" "github.com/libopenstorage/openstorage/cluster" sched "github.com/libopenstorage/openstorage/schedpolicy" "github.com/libopenstorage/openstorage/secrets" ) const (...
1
6,936
if name is empty will this become enumerate ? (and cause the unmarshal to fail ?)
libopenstorage-openstorage
go
@@ -15,7 +15,7 @@ module ProductsHelper if current_user_has_access_to?(:exercises) link_to url, options, &block else - content_tag "a", &block + link_to edit_subscription_path, options, &block end end end
1
module ProductsHelper def test_driven_rails_url "https://upcase.com/video_tutorials/18-test-driven-rails" end def design_for_developers_url "https://upcase.com/video_tutorials/19-design-for-developers" end def intermediate_rails_url "https://upcase.com/video_tutorials/21-intermediate-ruby-on-rai...
1
11,838
How about including a flash message that explains the exercises are only available to subscribers of X plan?
thoughtbot-upcase
rb
@@ -232,6 +232,11 @@ class Command(misc.MinimalLineEditMixin, misc.CommandLineEdit): Enter/Shift+Enter/etc. will cause QLineEdit to think it's finished without command_accept to be called. """ + text = self.text() + if text in modeparsers.STARTCHARS and e.key() == Qt.Key_Backspa...
1
# vim: ft=python fileencoding=utf-8 sts=4 sw=4 et: # Copyright 2014-2017 Florian Bruhin (The Compiler) <mail@qutebrowser.org> # # This file is part of qutebrowser. # # qutebrowser is free software: you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free S...
1
20,425
You should also call `e.accept()` and `return` so the key press isn't processed further (as we're leaving insert mode anyways).
qutebrowser-qutebrowser
py
@@ -0,0 +1,14 @@ +MAIL_SETTINGS = { + address: "smtp.sendgrid.net", + port: "587", + authentication: :plain, + user_name: ENV["SENDGRID_USERNAME"], + password: ENV["SENDGRID_PASSWORD"], + domain: "heroku.com" +} + +if ENV["EMAIL_RECIPIENTS"] + Mail.register_interceptor( + RecipientInterceptor.new(ENV.fetch("E...
1
1
16,483
Freeze mutable objects assigned to constants.
thoughtbot-upcase
rb
@@ -34,8 +34,11 @@ import { async function toggleOptIn() { await page.waitForSelector( '#googlesitekit-opt-in' ); - await expect( page ).toClick( '#googlesitekit-opt-in' ); - await page.waitForResponse( ( res ) => res.url().match( 'wp/v2/users/me' ) ); + await pageWait(); + await Promise.all( [ + page.waitForResp...
1
/** * Admin tracking opt in/out e2e tests. * * Site Kit by Google, Copyright 2020 Google LLC * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * https://www.apache.org/licenses/L...
1
30,455
Hmm, this feels hacky. Maybe good enough if it makes the test more stable, but why is timing even an aspect here, since below it should wait for these two things anyway?
google-site-kit-wp
js
@@ -144,6 +144,12 @@ namespace OpenTelemetry.Instrumentation.AspNetCore.Implementation { activity.SetTag(SemanticConventions.AttributeHttpUserAgent, userAgent); } + + var xForwardedFor = request.Headers["X-Forwarded-For"].FirstOrDefault(); + ...
1
// <copyright file="HttpInListener.cs" company="OpenTelemetry Authors"> // Copyright The OpenTelemetry Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache....
1
18,214
Do we want this on by default, or an opt-in (e.g. via some config while add the instrumentation)? I guess a more general question is - what's the bar for the default vs opt-in tags.
open-telemetry-opentelemetry-dotnet
.cs
@@ -91,7 +91,7 @@ int main(int argc, char *argv[]) { } LOG(INFO) << "Starting Graph HTTP Service"; - nebula::WebService::registerHandler("/graph", [] { + nebula::WebService::registerHandler("/status", [] { return new nebula::graph::GraphHttpHandler(); }); status = nebula::WebService...
1
/* Copyright (c) 2018 - present, VE Software Inc. All rights reserved * * This source code is licensed under Apache 2.0 License * (found in the LICENSE.Apache file in the root directory) */ #include "base/Base.h" #include "network/NetworkUtils.h" #include <signal.h> #include "base/Status.h" #include "fs/FileUtils...
1
16,415
`status` is just one of the features, named as status is not suitable.
vesoft-inc-nebula
cpp
@@ -296,9 +296,17 @@ public class NavListAdapter extends BaseAdapter .getSystemService(Context.LAYOUT_INFLATER_SERVICE); convertView = inflater.inflate(R.layout.nav_section_item, parent, false); + TextView feedsFilteredMsg = convertView.findViewById(R.id.nav_feeds_filtered_message); ...
1
package de.danoeh.antennapod.adapter; import android.app.Activity; import android.content.Context; import android.content.SharedPreferences; import android.content.res.TypedArray; import android.graphics.drawable.Drawable; import android.preference.PreferenceManager; import android.util.TypedValue; import android.view...
1
16,721
There is an option to hide the subscriptions list from the sidebar. If it is hidden, the filter text should not be displayed.
AntennaPod-AntennaPod
java
@@ -224,6 +224,11 @@ public class SolrConfig extends XmlConfigFile implements MapSerializable { queryResultWindowSize = Math.max(1, getInt("query/queryResultWindowSize", 1)); queryResultMaxDocsCached = getInt("query/queryResultMaxDocsCached", Integer.MAX_VALUE); enableLazyFieldLoading = getBool("query/en...
1
/* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may ...
1
35,041
I'd like for all of this to be dynamically configurable at some point, but it doesn't have to be in this PR. Can add it to the future SIP or create a separate JIRA for it, as you think would be appropriate.
apache-lucene-solr
java
@@ -57,8 +57,6 @@ extern Events* g_events; extern Chat* g_chat; extern LuaEnvironment g_luaEnvironment; -using ErrorCode = boost::system::error_code; - Signals::Signals(boost::asio::io_service& service) : set(service) {
1
/** * The Forgotten Server - a free and open-source MMORPG server emulator * Copyright (C) 2019 Mark Samman <mark.samman@gmail.com> * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either...
1
18,282
move the constructor to down the `namespace`
otland-forgottenserver
cpp
@@ -123,6 +123,10 @@ type ClusterDeploymentStatus struct { // Federated is true if the cluster deployment has been federated with the host cluster. Federated bool `json:"federated,omitempty"` + // FederatedClusterRef is the reference to the federated cluster resource associated with + // this ClusterDeployment + ...
1
/* Copyright 2018 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, ...
1
4,925
Nit: ending with a '.' looks consistent with the fields around it.
openshift-hive
go
@@ -138,7 +138,7 @@ func (s *Service) MintX509SVID(ctx context.Context, req *svidv1.MintX509SVIDRequ } func (s *Service) MintJWTSVID(ctx context.Context, req *svidv1.MintJWTSVIDRequest) (*svidv1.MintJWTSVIDResponse, error) { - rpccontext.AddRPCAuditFields(ctx, s.fieldsFromJWTSvidParams(req.Id, req.Audience, req.Ttl...
1
package svid import ( "context" "crypto/x509" "strings" "time" "github.com/sirupsen/logrus" "github.com/spiffe/go-spiffe/v2/spiffeid" svidv1 "github.com/spiffe/spire-api-sdk/proto/spire/api/server/svid/v1" "github.com/spiffe/spire-api-sdk/proto/spire/api/types" "github.com/spiffe/spire/pkg/common/idutil" "g...
1
18,291
Audit log will not have a warning about they are using a deprecated path, is it something we must care about?
spiffe-spire
go
@@ -23,7 +23,7 @@ namespace Microsoft.Cci.Differs.Rules // If implementation is protected then contract must be protected as well. if (impl.Visibility == TypeMemberVisibility.Family) { - if (contract.Visibility != TypeMemberVisibility.Family) + if (c...
1
// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. // See the LICENSE file in the project root for more information. using Microsoft.Cci.Extensions; using Microsoft.Cci.Writers.CSharp; namespace Microsoft.Cci.Differs.Rules { //...
1
12,401
I think you also want to update the condition to add ` || impl.Visibility == TypeMemberVisibility.FamilyOrAssembly`.
dotnet-buildtools
.cs
@@ -18,7 +18,10 @@ import ( ) var ( - depositToRewardingFundBaseGas = uint64(10000) + // DepositToRewardingFundBaseGas represents the base intrinsic gas for depositToRewardingFund + DepositToRewardingFundBaseGas = uint64(10000) + // DepositToRewardingFundGasPerByte represents the depositToRewardingFund payload gas ...
1
// Copyright (c) 2019 IoTeX // This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no // warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent // permitted by law, all liability for your use of the cod...
1
17,349
`DepositToRewardingFundBaseGas` is a global variable (from `gochecknoglobals`)
iotexproject-iotex-core
go
@@ -3,12 +3,14 @@ // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. // SPDX-License-Identifier: Apache-2.0 -// Package groups contains the names of command groups +// Package groups contains the names of command groups. package group +// Categories for each top level command in the CLI. cons...
1
// +build !windows // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. // SPDX-License-Identifier: Apache-2.0 // Package groups contains the names of command groups package group const ( GettingStarted = "Getting Started ✨" Develop = "Develop 🔧" Settings = "Settings ⚙️" Release ...
1
13,221
What do you think of "operations"?? Also what do these emojis look like on Linux??
aws-copilot-cli
go
@@ -0,0 +1,16 @@ +<% content_for :subject_block do %> + <h1><%= t('shared.subscription.name') %> for Teams</h1> + <h2 class="tagline"> + Sign your team up for <%= t('shared.subscription.name') %> today, and give them the finest Ruby on Rails content and the best expert teachers. + </h2> +<% end %> + +<p>Your team...
1
1
8,416
I like the word "give" here. Feels like I'm giving a gift to my team.
thoughtbot-upcase
rb
@@ -11,12 +11,16 @@ import numpy as np from sklearn import __version__ as sk_version from sklearn.base import clone from sklearn.datasets import (load_boston, load_breast_cancer, load_digits, - load_iris, load_svmlight_file) + load_iris, load_linnerud, load_s...
1
# coding: utf-8 import itertools import joblib import math import os import unittest import warnings import lightgbm as lgb import numpy as np from sklearn import __version__ as sk_version from sklearn.base import clone from sklearn.datasets import (load_boston, load_breast_cancer, load_digits, ...
1
25,305
Is it possible to use `np.random` module instead?
microsoft-LightGBM
cpp
@@ -49,7 +49,7 @@ legend_dimensions = ['label_standoff', 'label_width', 'label_height', 'glyph_wid class ElementPlot(BokehPlot, GenericElementPlot): - bgcolor = param.Parameter(default='white', doc=""" + bgcolor = param.Parameter(default=None, allow_None=True, doc=""" Background color of the plot.""...
1
from itertools import groupby import warnings import param import numpy as np import bokeh import bokeh.plotting from bokeh.core.properties import value from bokeh.models import (HoverTool, Renderer, Range1d, DataRange1d, Title, FactorRange, FuncTickFormatter, Tool, Legend) from bokeh.models....
1
19,818
``default=None`` implies ``allow_None`` so ``allow_None`` is superfluous here. As a special case, if allow_None=True (which is true by default if the parameter has a default of None when declared) then a value of None is also allowed.
holoviz-holoviews
py
@@ -551,8 +551,8 @@ func genClientCerts(config *config.Control, runtime *config.ControlRuntime) erro if _, err = factory("system:kube-proxy", nil, runtime.ClientKubeProxyCert, runtime.ClientKubeProxyKey); err != nil { return err } - // this must be hardcoded to k3s-controller because it's hard coded in the roleb...
1
package control import ( "context" "crypto" cryptorand "crypto/rand" "crypto/x509" b64 "encoding/base64" "encoding/json" "fmt" "io/ioutil" "math/rand" "net" "net/http" "os" "path/filepath" "strconv" "strings" "text/template" "time" "k8s.io/apimachinery/pkg/util/sets" "github.com/pkg/errors" certu...
1
8,593
Is there anything in particular that makes setting up the downstream rolebinding(s) to `system:k3s-controller` burdensome or confusing? This changes looks fine to me but it seems a shame to alias an embedded k3s controller. If we are doing this in other places that I am not aware of then we can dismiss this concern out...
k3s-io-k3s
go
@@ -21,7 +21,7 @@ import ( "strings" "time" - acd "github.com/ncw/go-acd" + "github.com/ncw/go-acd" "github.com/ncw/rclone/fs" "github.com/ncw/rclone/fs/config" "github.com/ncw/rclone/fs/config/configmap"
1
// Package amazonclouddrive provides an interface to the Amazon Cloud // Drive object storage system. package amazonclouddrive /* FIXME make searching for directory in id and file in id more efficient - use the name: search parameter - remember the escaping rules - use Folder GetNode and GetFile FIXME make the defaul...
1
8,102
File is not `goimports`-ed (from `goimports`)
rclone-rclone
go
@@ -0,0 +1,15 @@ +// Licensed to the .NET Foundation under one or more agreements. +// The .NET Foundation licenses this file to you under the MIT license. +// See the LICENSE file in the project root for more information. + +namespace Reporting +{ + public class Os + { + public string Locale { get; set; ...
1
1
9,014
nit: all other types in this project have full names, so maybe a better name would be `OperatingSystem`?
dotnet-performance
.cs
@@ -16,7 +16,7 @@ #include <GraphMol/SmilesParse/SmilesParse.h> #include <GraphMol/FileParsers/FileParsers.h> #include <Geometry/point.h> -#include "MolTransforms.h" +#include <GraphMol/MolTransforms/MolTransforms.h> using namespace RDKit; using namespace MolTransforms;
1
// // Copyright (C) 2003-2017 Greg Landrum and Rational Discovery LLC // // @@ All Rights Reserved @@ // This file is part of the RDKit. // The contents are covered by the terms of the BSD license // which is included in the file license.txt, found at the root // of the RDKit source tree. // #include <RDGeneral...
1
20,760
Why is this needed here?
rdkit-rdkit
cpp
@@ -192,7 +192,7 @@ public interface Context { methodUsage = ((TypeVariableResolutionCapability) methodDeclaration) .resolveTypeVariables(this, argumentsTypes); } else { - throw new UnsupportedOperationException(); + retu...
1
/* * Copyright 2016 Federico Tomassetti * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed...
1
13,100
mmm, why a method declaration should not have the TypeVariableResolutionCapability? Is this ok?
javaparser-javaparser
java
@@ -32,8 +32,8 @@ public class EeaSendRawTransaction extends PrivacySendTransaction { public EeaSendRawTransaction( final PrivacyParameters privacyParameters, - final PrivateTransactionHandler privateTransactionHandler, - final TransactionPool transactionPool) { + final TransactionPool transa...
1
/* * Copyright ConsenSys AG. * * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with * the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing...
1
20,781
nit: any reason you swapped the ordering?
hyperledger-besu
java
@@ -4,7 +4,7 @@ define(["jQuery", "loading", "globalize", "dom"], function($, loading, globalize function loadPage(page, config, systemInfo) { Array.prototype.forEach.call(page.querySelectorAll(".chkDecodeCodec"), function(c) { c.checked = -1 !== (config.HardwareDecodingCodecs || []).indexOf(...
1
define(["jQuery", "loading", "globalize", "dom"], function($, loading, globalize, dom) { "use strict"; function loadPage(page, config, systemInfo) { Array.prototype.forEach.call(page.querySelectorAll(".chkDecodeCodec"), function(c) { c.checked = -1 !== (config.HardwareDecodingCodecs || [])....
1
10,673
can you de-uglify at least this line?.. hard to tell what changed...
jellyfin-jellyfin-web
js
@@ -354,13 +354,10 @@ type BPFDataplane interface { RemoveXDP(ifName string, mode XDPMode) error UpdateCIDRMap(ifName string, family IPFamily, ip net.IP, mask int, refCount uint32) error UpdateFailsafeMap(proto uint8, port uint16) error - loadXDPRaw(objPath, ifName string, mode XDPMode, mapArgs []string) error ...
1
// Copyright (c) 2019 Tigera, Inc. All rights reserved. // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applica...
1
17,204
Please can you merge master in before making these changes. I just reinstated a bunch of BPF UTs. Possible that the UTs use this code.
projectcalico-felix
go
@@ -66,3 +66,14 @@ class MyCls: @classmethod def get_class_var(cls): return cls.__class_var + + +class Bla: + """Regression test for issue 4638""" + + def __init__(self): + type(self).__a() + + @classmethod + def __a(cls): + pass
1
# pylint: disable=missing-docstring, invalid-name, too-few-public-methods, no-self-use, line-too-long, unused-argument, protected-access class AnotherClass(): def __test(self): # [unused-private-member] pass class HasUnusedInClass(): __my_secret = "I have no secrets" # [unused-private-member] __...
1
14,498
Do you want to add additional cases for `Bla.__b()` and `self.__c()`? (Just add additional classmethods `__b` and `__c` and the calls to `__init__`)
PyCQA-pylint
py
@@ -462,7 +462,7 @@ def search(collection, p, of, ot, so, rm): ctx = dict( facets=facets.get_facets_config(collection, qid), - records=len(get_current_user_records_that_can_be_displayed(qid)), + records=len(recids), qid=qid, rg=rg, create_nearest_terms_box=lambda: _create...
1
# -*- coding: utf-8 -*- # # This file is part of Invenio. # Copyright (C) 2012, 2013, 2014, 2015 CERN. # # Invenio is free software; you can redistribute it and/or # modify it under the terms of the GNU General Public License as # published by the Free Software Foundation; either version 2 of the # License, or (at your...
1
16,925
the recids is never changed after. So, it should contains the exact shown results, whatever are the rights for the user (admin or simple user, restricted collections...)
inveniosoftware-invenio
py
@@ -669,7 +669,15 @@ func (b *Bucket) newRangeReader(ctx context.Context, key string, offset, length // WriteAll is a shortcut for creating a Writer via NewWriter and writing p. func (b *Bucket) WriteAll(ctx context.Context, key string, p []byte, opts *WriterOptions) (err error) { - w, err := b.NewWriter(ctx, key, ...
1
// Copyright 2018 The Go Cloud Development Kit Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // https://www.apache.org/licenses/LICENSE-2.0 // // Unless required by appli...
1
16,852
Shouldn't the docstring mention that the MD5 checksum of `p` is computed each time and verified? Also, could there be use cases where a caller might not want such a check to happen because, eg, a blob storage solution doesn't provide MD5 verification or uses another hash algorithm such as SHA256?
google-go-cloud
go
@@ -143,6 +143,9 @@ def executeEvent(eventName,obj,**kwargs): @param kwargs: Additional event parameters as keyword arguments. """ try: + # Allow NVDAObjects to redirect focus events to another object of their choosing. + if eventName=="gainFocus" and obj.focusRedirect: + obj=obj.focusRedirect sleepMode=ob...
1
#eventHandler.py #A part of NonVisual Desktop Access (NVDA) #This file is covered by the GNU General Public License. #See the file COPYING for more details. #Copyright (C) 2007-2017 NV Access Limited, Babbage B.V. import threading import queueHandler import api import speech import appModuleHandler import t...
1
23,207
focusRedirect is used in the powerpnt appModule. We might have to make sure that this does not break. Having said that, I really like this being handled on the events level!
nvaccess-nvda
py
@@ -21,6 +21,8 @@ import ( "encoding/base64" "encoding/json" "fmt" + "github.com/GoogleCloudPlatform/compute-image-tools/osconfig_tests/config" + "github.com/GoogleCloudPlatform/compute-image-tools/osconfig_tests/gcp_clients" "io" "log" "path"
1
// Copyright 2018 Google Inc. All Rights Reserved. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by appl...
1
8,693
You imports are out of order
GoogleCloudPlatform-compute-image-tools
go
@@ -45,7 +45,7 @@ import org.slf4j.LoggerFactory; public class QuartzScheduler { //Unless specified, all Quartz jobs's identities comes with the default job name. - private static final String DEFAULT_JOB_NAME = "job1"; + public static final String DEFAULT_JOB_NAME = "job1"; private static final Logger logge...
1
/* * Copyright 2017 LinkedIn Corp. * * Licensed under the Apache License, Version 2.0 (the "License"); you may not * use this file except in compliance with the License. You may obtain a copy of * the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to i...
1
15,567
This should not be called Flow Trigger. FlowTrigger should has its own flowTrigger job name, for instance, "flowtrigger"
azkaban-azkaban
java
@@ -0,0 +1,19 @@ +// Copyright (c) 2018 IoTeX +// This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no +// warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent +// permitted by law, all liability fo...
1
1
14,135
File is not `goimports`-ed (from `goimports`)
iotexproject-iotex-core
go
@@ -30,6 +30,10 @@ public partial class Program public static void Stress(int concurrency = 0) { +#if DEBUG + Console.WriteLine("***WARNING*** The current build is DEBUG which may affect timing!\n"); +#endif + if (concurrency < 0) { throw new ArgumentOutOfRangeException...
1
// <copyright file="Skeleton.cs" company="OpenTelemetry Authors"> // Copyright The OpenTelemetry Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/li...
1
21,741
Why do we need `\n` if we already use `WriteLine`? (and `\n` is not cross platform)
open-telemetry-opentelemetry-dotnet
.cs
@@ -30,12 +30,15 @@ import com.google.common.base.MoreObjects; public class MetricsConfiguration { private static final String DEFAULT_METRICS_HOST = "127.0.0.1"; public static final int DEFAULT_METRICS_PORT = 9545; - + private static final String DEFAULT_INSTRUMENTATION_NAME = "besu"; + private static final S...
1
/* * Copyright ConsenSys AG. * * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with * the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing...
1
23,631
What is instrumentation name used for? I'm not seeing other classes use it, only a getter, constructor, and builder.
hyperledger-besu
java
@@ -21,8 +21,10 @@ namespace Nethermind.TxPool.Collections { public partial class SortedPool<TKey, TValue, TGroupKey> { +#pragma warning disable 67 public event EventHandler<SortedPoolEventArgs>? Inserted; public event EventHandler<SortedPoolRemovedEventArgs>? Removed; +#pragma warning rest...
1
// Copyright (c) 2021 Demerzel Solutions Limited // This file is part of the Nethermind library. // // The Nethermind library is free software: you can redistribute it and/or modify // it under the terms of the GNU Lesser General Public License as published by // the Free Software Foundation, either version 3 of ...
1
26,216
@kristofgazso could you review these warnings?
NethermindEth-nethermind
.cs
@@ -0,0 +1,3 @@ +require("child_process"); + +console.log("hi");
1
1
25,482
will delete this.
Azure-autorest
java
@@ -104,9 +104,9 @@ module PurchasesHelper def new_plan_link(plan) link_to( - I18n.t('subscriptions.choose_plan_html', plan_name: plan.name).html_safe, - new_individual_plan_purchase_path(plan), - class: 'button' + I18n.t('subscriptions.choose_plan_html', plan_name: plan.name).html_safe...
1
module PurchasesHelper def display_card_type(type) if type == "American Express" "AMEX" else type end end def include_receipt?(purchase) purchase.user.blank? || !purchase.user.has_active_subscription? || (purchase.user.has_active_subscription? && purchase.subscription?) end ...
1
8,409
~~Indent 2 lines above~~ Disregard. My fault
thoughtbot-upcase
rb
@@ -366,7 +366,7 @@ public class InitCodeTransformer { default: throw new UnsupportedOperationException("unexpected entity name type"); } - } else if (initValueConfig.hasFormattingConfig()) { + } else if (initValueConfig.hasFormattingConfig() && !item.getType().isRepeated()) { if...
1
/* Copyright 2016 Google Inc * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in ...
1
21,389
What was the bug that this is fixing?
googleapis-gapic-generator
java
@@ -471,6 +471,9 @@ class RemoteConnection(object): request.add_header('Accept', 'application/json') request.add_header('Content-Type', 'application/json;charset=UTF-8') + base64string = base64.b64encode('%s:%s' % (parsed_url.username, parsed_url.password)) + request.ad...
1
# Licensed to the Software Freedom Conservancy (SFC) under one # or more contributor license agreements. See the NOTICE file # distributed with this work for additional information # regarding copyright ownership. The SFC licenses this file # to you under the Apache License, Version 2.0 (the # "License"); you may not...
1
14,022
This will always add the authorization header to the request object. Is this the right scope for these two lines? If username/password are not defined, it will encode 'Basic :'
SeleniumHQ-selenium
rb
@@ -50,7 +50,12 @@ uint32_t lcg_rand() { } void lcg_reset() { lcg_seed = 48271; } -std::string test_data_path = "tests/"; +std::string test_data_path = +#ifdef BAZEL_TEST_DATA_PATH + "../com_github_google_flatbuffers/tests/"; +#else + "tests/"; +#endif // example of how to build up a serialized buffer algo...
1
/* * Copyright 2014 Google Inc. All rights reserved. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applic...
1
14,461
Is this always how Bazel does paths? Would it be nicer to do `-DBAZEL_TEST_DATA_PATH=../com_github_google_flatbuffers/tests/` so this string is not hardcoded in the the source?
google-flatbuffers
java
@@ -169,7 +169,9 @@ class ElasticsearchTarget(luigi.Target): The document id would be sufficient but, for documentation, - we index the parameters `update_id`, `target_index`, `target_doc_type` and `date` as well. + we index the parameters `update_id`, `target_index`, `target_doc_type`...
1
# -*- coding: utf-8 -*- # # Copyright 2012-2015 Spotify AB # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law...
1
20,038
Not an expert of ES, so not sure of the impact here.
spotify-luigi
py
@@ -1665,10 +1665,10 @@ NABoolean ExExeUtilGetMetadataInfoTcb::checkUserPrivs( if (ComUser::isRootUserID()) return FALSE; - // any user granted the DB__ROOTROLE sees everything Int32 numRoles; Int32 *roleList; - if (currContext->getRoleList(numRoles, roleList) == SUCCESS) + Int32 *granteeList; + if ...
1
/********************************************************************** // @@@ START COPYRIGHT @@@ // // Licensed to the Apache Software Foundation (ASF) under one // or more contributor license agreements. See the NOTICE file // distributed with this work for additional information // regarding copyright ownership. ...
1
22,339
Who deletes the memory for the granteeList? (or the roleList for that matter)
apache-trafodion
cpp
@@ -13,6 +13,11 @@ ws_listener (listener_a), ws (std::move (socket_a)), write_strand (ws.get_execut nano::websocket::session::~session () { + for (auto & subscription : subscriptions) + { + ws_listener.decrease_subscription_count (subscription); + } + ws_listener.get_node ().logger.try_log ("websocket session en...
1
#include <algorithm> #include <boost/property_tree/json_parser.hpp> #include <chrono> #include <nano/node/node.hpp> #include <nano/node/websocket.hpp> nano::websocket::session::session (nano::websocket::listener & listener_a, boost::asio::ip::tcp::socket socket_a) : ws_listener (listener_a), ws (std::move (socket_a)),...
1
15,368
This loop is missing a lock on subscriptions_mutex.
nanocurrency-nano-node
cpp
@@ -62,7 +62,9 @@ Workshops::Application.routes.draw do match '/backbone-js-on-rails' => redirect("/products/1-backbone-js-on-rails") match '/rubyist-booster-shot' => "high_voltage/pages#show", as: :rubyist_booster_shot, id: "rubyist-booster-shot" - match 'sign_in' => 'sessions#new', as: 'sign_in' + match '/...
1
Workshops::Application.routes.draw do mount RailsAdmin::Engine => '/new_admin', :as => 'rails_admin' root to: 'topics#index' match '/pages/tmux' => redirect("/products/4-humans-present-tmux") resource :session, controller: 'sessions' resources :sections, only: [:show] do resources :registrations, only:...
1
6,357
shouldn't clearance be setting these up for us?
thoughtbot-upcase
rb
@@ -46,6 +46,10 @@ type ( } defaultServiceNameDetector struct{} + + // noOp is a Detector that only provides an empty resource. Used + // to disable automatic detection. + noOp struct{} ) var (
1
// Copyright The OpenTelemetry Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agre...
1
14,890
Need to update the doc for `TelemetrySDK` and `Host` structs deleting references from removed functions.
open-telemetry-opentelemetry-go
go
@@ -55,12 +55,6 @@ public final class ASTRecordDeclaration extends AbstractAnyTypeDeclaration { return isNested() || isLocal(); } - @Override - public boolean isFinal() { - // A record is implicitly final - return true; - } - @Override public boolean isLocal() { ...
1
/* * BSD-style license; for more info see http://pmd.sourceforge.net/license.html */ package net.sourceforge.pmd.lang.java.ast; import java.util.List; import net.sourceforge.pmd.lang.ast.Node; /** * A record declaration is a special data class type (JDK 16 feature). * This is a {@linkplain Node#isFindBoundary(...
1
19,340
I think we should keep that here and add a new method `isSyntacticallyFinal` that returns `super.isFinal()` (and can be used in UnnecessaryModifier). Otherwise the contract of `isFinal` is not respected
pmd-pmd
java
@@ -2444,6 +2444,11 @@ angular.module('ui.grid') // to get the full position we need scrollPixels = self.renderContainers.body.prevScrollTop - (topBound - pixelsToSeeRow); + //Since scrollIfNecessary is called multiple times when enableCellEditOnFocus is true we need to make sure the ...
1
(function(){ angular.module('ui.grid') .factory('Grid', ['$q', '$compile', '$parse', 'gridUtil', 'uiGridConstants', 'GridOptions', 'GridColumn', 'GridRow', 'GridApi', 'rowSorter', 'rowSearcher', 'GridRenderContainer', '$timeout','ScrollEvent', function($q, $compile, $parse, gridUtil, uiGridConstants, GridOptions, ...
1
11,981
Is there a reason why we wouldn't want to check this every time? Why are we only checking for the footer and scroll bar when enableCellEditOnFocus is true?
angular-ui-ui-grid
js
@@ -23,6 +23,7 @@ import com.playonlinux.common.dtos.*; import com.playonlinux.domain.PlayOnLinuxError; import com.playonlinux.injection.Scan; import com.playonlinux.injection.Inject; +import com.playonlinux.ui.api.InstallerFilter; import com.playonlinux.webservice.RemoteAvailableInstallers; import java.net.Malf...
1
/* * Copyright (C) 2015 PÂRIS Quentin * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation; either version 2 of the License, or * (at your option) any later version. * * This program is dist...
1
8,030
You need to create an API for this class. This class should follow roughly the same dependency structure than RemoteAvailableInstallersPlayOnLinuxImplementation / RemoteAvailableInstallers. Maybe we could use a inner class here?
PhoenicisOrg-phoenicis
java
@@ -42,7 +42,7 @@ const ( templateCreateWorkflowExecutionClosed = `INSERT INTO executions_visibility (` + `namespace_id, workflow_id, run_id, start_time, execution_time, workflow_type_name, close_time, status, history_length, memo, encoding) ` + `VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) ` + - `ON DUPLICATE KEY...
1
// The MIT License // // Copyright (c) 2020 Temporal Technologies Inc. All rights reserved. // // Copyright (c) 2020 Uber Technologies, Inc. // // Permission is hereby granted, free of charge, to any person obtaining a copy // of this software and associated documentation files (the "Software"), to deal // in the Soft...
1
10,360
This should not be a case, right? If `run_id` is the same `workflow_id` can't be changed. Actually surprised that it is not part of a key.
temporalio-temporal
go
@@ -4520,7 +4520,9 @@ RelExpr * GenericUpdate::preCodeGen(Generator * generator, { oltOptInfo().setOltOpt(FALSE); generator->oltOptInfo()->setOltOpt(FALSE); - generator->setAqrEnabled(FALSE); + //enabling AQR to take care of the lock conflict error 8558 that + // should be retried. + ...
1
/********************************************************************** // @@@ START COPYRIGHT @@@ // // Licensed to the Apache Software Foundation (ASF) under one // or more contributor license agreements. See the NOTICE file // distributed with this work for additional information // regarding copyright ownership. ...
1
21,209
How would AQR work for an INSERT/SELECT of one table into another where a LOB column is being copied?
apache-trafodion
cpp
@@ -6,9 +6,11 @@ import ( "net" "os" - sds_v2 "github.com/envoyproxy/go-control-plane/envoy/service/discovery/v2" + discovery_v2 "github.com/envoyproxy/go-control-plane/envoy/service/discovery/v2" + secret_v3 "github.com/envoyproxy/go-control-plane/envoy/service/secret/v3" attestor "github.com/spiffe/spire/pkg/...
1
package endpoints import ( "context" "fmt" "net" "os" sds_v2 "github.com/envoyproxy/go-control-plane/envoy/service/discovery/v2" attestor "github.com/spiffe/spire/pkg/agent/attestor/workload" "github.com/spiffe/spire/pkg/agent/endpoints/sds" "github.com/spiffe/spire/pkg/agent/endpoints/workload" "github.com/...
1
14,974
Since these are ultimately different endpoints, it would be nice if we could move them up one level and nuke the common `sds` directory in order to reduce path stutter
spiffe-spire
go
@@ -927,7 +927,7 @@ export default function Core(rootElement, userSettings, rootInstanceSymbol = fal if (isFunction(beforeChangeResult)) { warn('Your beforeChange callback returns a function. It\'s not supported since Handsontable 0.12.1 (and the returned function will not be executed).'); - } else if ...
1
import { addClass, empty, isChildOfWebComponentTable, removeClass } from './helpers/dom/element'; import { columnFactory } from './helpers/setting'; import { isFunction } from './helpers/function'; import { warn } from './helpers/console'; import { isDefined, isUndefined, isRegExp, _injectProductInfo, isEmpty } from '....
1
15,371
Please check also whether `null` occurs in the rest of `beforeChangeResult` array.
handsontable-handsontable
js
@@ -22,9 +22,10 @@ package transport import "context" -// Filter defines transport-level middleware for Outbounds. +// UnaryFilter defines transport-level middleware for `UnaryOutbound`s. +// Note: this is client side. // -// Filters MAY +// UnaryFilter MAY // // - change the context // - change the request
1
// Copyright (c) 2016 Uber Technologies, Inc. // // Permission is hereby granted, free of charge, to any person obtaining a copy // of this software and associated documentation files (the "Software"), to deal // in the Software without restriction, including without limitation the rights // to use, copy, modify, merge...
1
11,369
Outdated docs. There is no response, there's an ack.
yarpc-yarpc-go
go
@@ -27,7 +27,7 @@ your host.`, } switch status { case libcontainer.Created: - return container.Signal(libcontainer.InitContinueSignal) + return container.Exec() case libcontainer.Stopped: return fmt.Errorf("cannot start a container that has run and stopped") case libcontainer.Running:
1
package main import ( "fmt" "github.com/opencontainers/runc/libcontainer" "github.com/urfave/cli" ) var startCommand = cli.Command{ Name: "start", Usage: "start signals a created container to execute the user defined process", ArgsUsage: `<container-id> Where "<container-id>" is your name for the instance of...
1
11,533
I'd rather have the container process remove the FIFO after it unblocks. Then `start` can always `Exec()`, and you can catch the "FIFO does not exist" error and translate it to a prettier "someone must have already started the container".
opencontainers-runc
go
@@ -284,7 +284,7 @@ func (svr *Web3Server) getTransactionFromActionInfo(actInfo *iotexapi.ActionInfo func (svr *Web3Server) getTransactionCreateFromActionInfo(actInfo *iotexapi.ActionInfo) (transactionObject, error) { tx, err := svr.getTransactionFromActionInfo(actInfo) - if err != nil { + if err != nil || tx == n...
1
package api import ( "context" "encoding/hex" "encoding/json" "fmt" "math/big" "strconv" "strings" "time" "github.com/ethereum/go-ethereum/common" "github.com/go-redis/redis/v8" "github.com/iotexproject/go-pkgs/cache/ttl" "github.com/iotexproject/go-pkgs/hash" "github.com/iotexproject/iotex-address/addre...
1
24,296
can you check if there's other similar cases to add nil-check like this?
iotexproject-iotex-core
go
@@ -106,7 +106,10 @@ def dummy_cert(privkey, cacert, commonname, sans, organization): cert.gmtime_adj_notBefore(-3600 * 48) cert.gmtime_adj_notAfter(DEFAULT_EXP_DUMMY_CERT) cert.set_issuer(cacert.get_subject()) - if commonname is not None and len(commonname) < 64: + is_valid_commonname = ( + ...
1
import os import ssl import time import datetime import ipaddress import sys import typing import contextlib from pyasn1.type import univ, constraint, char, namedtype, tag from pyasn1.codec.der.decoder import decode from pyasn1.error import PyAsn1Error import OpenSSL from mitmproxy.coretypes import serializable # De...
1
14,825
`<= 64`? I just picked up what you said in #3981 ("the CN field is limited to 64 characters") but maybe there's something I don't know where the 64th character is needed (trailing dot or whatever?) Also this sounds like something that could be beautifully unit tested. Sorry for bugging you :grin:
mitmproxy-mitmproxy
py
@@ -20,4 +20,10 @@ class License < ActiveRecord::Base def short_name abbreviation.blank? ? nice_name : abbreviation end + + class << self + def autocomplete(term) + License.select([:nice_name, :id]).where(['lower(nice_name) LIKE ?', "#{term.downcase}%"]).limit(10) + end + end end
1
class License < ActiveRecord::Base scope :from_param, ->(id) { where(name: id) } acts_as_editable editable_attributes: [:name, :nice_name, :abbreviation, :description, :url], merge_within: 30.minutes acts_as_protected def to_param name end def allow_undo_to_nil?(key) ![:name, :...
1
7,208
I understand that this grabs a Licenses objects but what is the autocomplete method used for? What does this do in context of the auto_completes controller?
blackducksoftware-ohloh-ui
rb
@@ -480,6 +480,10 @@ public class BlockchainQueries { txs.get(txIndex), header.getNumber(), blockHeaderHash, txIndex); } + public Optional<TransactionLocation> transactionLocationByHash(final Hash transactionHash) { + return blockchain.getTransactionLocation(transactionHash); + } + /** * Retur...
1
/* * Copyright ConsenSys AG. * * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with * the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing...
1
22,358
I don't really like that way of naming methods based on their arguments. But I can see that the other method names are the same ...
hyperledger-besu
java
@@ -180,6 +180,19 @@ public class StringUtil { } } + public static String sanitizeFileDirectory(String value){ + + while (value.startsWith("\\") || value.startsWith("/") || value.startsWith("-") || value.startsWith(".")){ + value = value.substring(1); + } + ...
1
package edu.harvard.iq.dataverse.util; import edu.harvard.iq.dataverse.authorization.providers.oauth2.OAuth2LoginBackingBean; import java.io.UnsupportedEncodingException; import java.security.InvalidKeyException; import java.security.MessageDigest; import java.security.NoSuchAlgorithmException; import java.util.ArrayL...
1
39,477
@sekmiller This method correctly strips the leading and trailing slashes (and also "." and "-"); But I thought the plan was also to replace any multiple slashes between nested folders with a single slash. For example, as implemented now, I can enter "folder1///folder2", and it gets saved and displayed like this, with t...
IQSS-dataverse
java
@@ -45,7 +45,7 @@ int main() { - int pid; + int64_t pid; fprintf(stderr, "starting\n"); #if defined(AARCH64) asm("movz x8, " STRINGIFY(SYS_getpid) ";"
1
/* ********************************************************** * Copyright (c) 2015 Google, Inc. All rights reserved. * Copyright (c) 2008-2010 VMware, Inc. All rights reserved. * **********************************************************/ /* * Redistribution and use in source and binary forms, with or without *...
1
13,266
Looks like the X86 inline assembly is not happy with this type. I will update that
DynamoRIO-dynamorio
c
@@ -6,6 +6,12 @@ <h2><%= link_to h(diary_entry.title), :action => 'view', :display_name => diary_entry.user.display_name, :id => diary_entry.id %></h2> + <% if @user and diary_entry.user.id != @user.id %> + <%= link_to new_issue_url(reportable_id: diary_entry.id, reportable_type: diary_entry.class...
1
<div class='diary_post'> <div class='post_heading clearfix'> <% if !@this_user %> <%= user_thumbnail diary_entry.user %> <% end %> <h2><%= link_to h(diary_entry.title), :action => 'view', :display_name => diary_entry.user.display_name, :id => diary_entry.id %></h2> <small class='deemphasize'> ...
1
10,053
Tabs and a space, again.
openstreetmap-openstreetmap-website
rb
@@ -2441,6 +2441,16 @@ bool QuestManager::istaskappropriate(int task) { return false; } +std::string QuestManager::gettaskname(uint32 task_id) { + QuestManagerCurrentQuestVars(); + + if (RuleB(TaskSystem, EnableTaskSystem)) { + return taskmanager->GetTaskName(task_id); + } + + return std::string(); +} + void Que...
1
/* EQEMu: Everquest Server Emulator Copyright (C) 2001-2005 EQEMu Development Team (http://eqemulator.net) This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; version 2 of the License. This program...
1
9,979
Please just enclose if blocks with brackets; this has created issues in the past so I'd prefer we don't use them
EQEmu-Server
cpp