patch stringlengths 17 31.2k | y int64 1 1 | oldf stringlengths 0 2.21M | idx int64 1 1 | id int64 4.29k 68.4k | msg stringlengths 8 843 | proj stringclasses 212
values | lang stringclasses 9
values |
|---|---|---|---|---|---|---|---|
@@ -22,6 +22,11 @@ var (
ErrMinusAmount = errors.New("invalid amount that is minus")
)
+const (
+ // IotxAddressLength defines length of IoTeX address
+ IotxAddressLength = 41
+)
+
// ValidateAddress validates IoTeX address
func ValidateAddress(addr string) error {
if _, err := address.FromString(addr); err !=... | 1 | // Copyright (c) 2019 IoTeX
// This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no
// warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent
// permitted by law, all liability for your use of the cod... | 1 | 16,146 | IoAddrLen Golang prefers short variable names | iotexproject-iotex-core | go |
@@ -34,7 +34,7 @@ class MediaAdmin extends Admin
*/
public function createQuery($context = 'list')
{
- $query = $this->getModelManager()->createQuery($this->getClass(), '', $this->root);
+ $query = $this->getModelManager()->createQuery($this->getClass(), 'a', $this->root);
forea... | 1 | <?php
/*
* This file is part of the Sonata package.
*
* (c) Thomas Rabaix <thomas.rabaix@sonata-project.org>
*
* For the full copyright and license information, please view the LICENSE
* file that was distributed with this source code.
*/
namespace Sonata\MediaBundle\Admin\PHPCR;
use Sonata\MediaBundle\Admin\... | 1 | 6,385 | PHPCR-ODM does not allow blank aliases.. | sonata-project-SonataMediaBundle | php |
@@ -358,7 +358,11 @@ public class HttpSolrClient extends BaseHttpSolrClient {
if (parser == null) {
parser = this.parser;
}
-
+
+ Header[] contextHeaders = new Header[2];
+ contextHeaders[0] = new BasicHeader(CommonParams.SOLR_REQUEST_CONTEXT_PARAM, getContext().toString());
+ contextHeade... | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may ... | 1 | 35,714 | This seems trivial to forge. Can we tie this into the authentication code paths somehow so that we can really trust that the request is coming from a server instead of just some application claiming to be a server? | apache-lucene-solr | java |
@@ -42,6 +42,7 @@
//@HEADER
*/
+#include <Kokkos_Core.hpp>
#include <Kokkos_Concepts.hpp>
#include <SYCL/Kokkos_SYCL_Instance.hpp>
#include <KokkosCore_Config_DeclareBackend.hpp> | 1 | /*
//@HEADER
// ************************************************************************
//
// Kokkos v. 3.0
// Copyright (2020) National Technology & Engineering
// Solutions of Sandia, LLC (NTESS).
//
// Under the terms of Contract DE-NA0003525 with NTESS,
// the U.S. Govern... | 1 | 28,416 | Why are you including `<Kokkos_Core.hpp>`? | kokkos-kokkos | cpp |
@@ -323,7 +323,7 @@ int api_v1_health(struct flb_hs *hs)
counter_init(hs);
/* Create a message queue */
- hs->qid_metrics = mk_mq_create(hs->ctx, "/health",
+ hs->qid_health = mk_mq_create(hs->ctx, "/health",
cb_mq_health, NULL);
mk_vhost_handler(hs->ctx, hs-... | 1 | /* -*- Mode: C; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/* Fluent Bit
* ==========
* Copyright (C) 2019-2021 The Fluent Bit Authors
* Copyright (C) 2015-2018 Treasure Data Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in co... | 1 | 16,081 | So previously health check was consuming from the normal metrics queue, now we duplicate the data to a new queue? I feel like there should be more changes to ensure the health check handler reads from the new queue? @DrewZhang13 | fluent-fluent-bit | c |
@@ -1470,6 +1470,7 @@ func isValidRuleForXDP(rule *proto.Rule) bool {
len(rule.DstPorts) == 0 &&
len(rule.DstNamedPortIpSetIds) == 0 &&
len(rule.DstIpSetIds) == 0 &&
+ len(rule.DstIpPortSetIds) == 0 &&
len(rule.NotDstNet) == 0 &&
len(rule.NotDstPorts) == 0 &&
len(rule.NotDstIpSetIds) == 0 && | 1 | // Copyright (c) 2019-2021 Tigera, Inc. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by ... | 1 | 19,135 | Yep, looks right; your new selector _should_ disqualify the rule from being XDP accelerated. | projectcalico-felix | go |
@@ -0,0 +1,12 @@
+// Copyright (c) .NET Foundation. All rights reserved.
+// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+
+using System;
+
+namespace Microsoft.AspNetCore.Connections.Features
+{
+ public interface IConnectionHeartbeatTickFeature
+ ... | 1 | 1 | 16,384 | cc @anurse This exists now. Kestrel currently passes the current time to all callbacks as an optimization. Just an FYI. | aspnet-KestrelHttpServer | .cs | |
@@ -126,7 +126,7 @@ class Entry(MSONable, metaclass=ABCMeta):
elif mode == "formula_unit":
factor = self.composition.get_reduced_composition_and_factor()[1]
else:
- raise ValueError(f"{mode=} is not an allowed option for normalization")
+ raise ValueError(f"{mode} is... | 1 | # coding: utf-8
# Copyright (c) Pymatgen Development Team.
# Distributed under the terms of the MIT License.
"""
Entries are containers for calculated information, which is used in
many analyses. This module contains entry related tools and implements
the base Entry class, which is the basic entity that can be used to... | 1 | 20,121 | remove 3.8+ f-string format to allow use in google colab | materialsproject-pymatgen | py |
@@ -196,6 +196,10 @@ save_xmm(dcontext_t *dcontext, sigframe_rt_t *frame)
int i;
sigcontext_t *sc = get_sigcontext_from_rt_frame(frame);
kernel_xstate_t *xstate = (kernel_xstate_t *)sc->fpstate;
+ /* For pending signals, the alignment of xstate ultimately depends on the alignment of
+ * the specia... | 1 | /* **********************************************************
* Copyright (c) 2011-2019 Google, Inc. All rights reserved.
* Copyright (c) 2000-2010 VMware, Inc. All rights reserved.
* **********************************************************/
/*
* Redistribution and use in source and binary forms, with or witho... | 1 | 17,995 | Should we assert that xstate is aligned here? | DynamoRIO-dynamorio | c |
@@ -49,8 +49,8 @@ import com.tdunning.math.stats.AVLTreeDigest;
// TestCloudJSONFacetJoinDomain for random field faceting tests with domain modifications
// TestJsonFacetRefinement for refinement tests
-@LuceneTestCase.SuppressCodecs({"Lucene3x","Lucene40","Lucene41","Lucene42","Lucene45","Appending"})
-public ... | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may ... | 1 | 28,754 | any particular reason for suppressing this change? | apache-lucene-solr | java |
@@ -67,6 +67,17 @@ public abstract class MainnetDifficultyCalculators {
return periodCount > 1 ? adjustForPeriod(periodCount, difficulty) : difficulty;
};
+ public static DifficultyCalculator<Void> DIFFICULTY_BOMB_REMOVED =
+ (time, parent, protocolContext) -> {
+ final BigInteger parentD... | 1 | /*
* Copyright ConsenSys AG.
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing... | 1 | 20,312 | Hot take: could this instead become `NO_DIFFICULTY_BOMB` and have` HOMESTEAD` wrap it? So this comes first then homestad with the bomb adjustment, making no difficulty the base case? | hyperledger-besu | java |
@@ -16,6 +16,19 @@
// variables read from a blob.Bucket.
// Use NewVariable to construct a *runtimevar.Variable.
//
+// URLs
+//
+// For runtimevar.OpenVariable URLs, blobvar registers for the scheme "blob".
+// The host+path is used as the blob key. blobvar supports the following URL
+// parameters:
+// - bucket:... | 1 | // Copyright 2019 The Go Cloud Development Kit Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// https://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by appli... | 1 | 15,142 | I suggest to use a scheme like "blobvar". "blob" would potentially collide if we have another API that use the blob package as a driver. | google-go-cloud | go |
@@ -116,6 +116,14 @@ def get_listens(user_name):
for listen in listens:
listen_data.append(listen.to_api())
+ latest_listen = db_conn.fetch_listens(
+ user_name,
+ limit=1,
+ to_ts=max_ts,
+ )
+ latest_listen_ts = latest_listen[0].ts_since_epoch if len(latest_listen) > 0 el... | 1 |
import ujson
from flask import Blueprint, request, jsonify, current_app
from werkzeug.exceptions import BadRequest, InternalServerError, Unauthorized, ServiceUnavailable, NotFound
from listenbrainz.db.exceptions import DatabaseException
from listenbrainz.webserver.decorators import crossdomain
from listenbrainz import... | 1 | 15,321 | This assumes that the user has at least one listen, it should have a guard around it, because this won't always be the case | metabrainz-listenbrainz-server | py |
@@ -365,7 +365,7 @@ namespace pwiz.Skyline.Properties {
}
/// <summary>
- /// Looks up a localized string similar to An error occurred while trying to display the document '{0}'.
+ /// Looks up a localized string similar to An error occurred while trying to displ... | 1 | //------------------------------------------------------------------------------
// <auto-generated>
// This code was generated by a tool.
// Runtime Version:4.0.30319.42000
//
// Changes to this file may cause incorrect behavior and will be lost if
// the code is regenerated.
// </auto-generate... | 1 | 14,016 | Seems like a lot of unintended changes. Are your line break settings causing these? | ProteoWizard-pwiz | .cs |
@@ -231,9 +231,10 @@ def generate_r_docs(app):
r-jsonlite=1.5=r351h96ca727_0 \
r-matrix=1.2_14=r351h96ca727_0 \
r-testthat=2.0.0=r351h29659fb_0 \
- cmake=3.14.0=h52cb24c_0
+ cmake=3.14.0=h52cb24c_0 \
+ ca-certificates=2019.11.27=0
/home/docs/.conda/bin/conda install ... | 1 | #!/usr/bin/env python3
# -*- coding: utf-8 -*-
#
# LightGBM documentation build configuration file, created by
# sphinx-quickstart on Thu May 4 14:30:58 2017.
#
# This file is execfile()d with the current directory set to its
# containing dir.
#
# Note that not all possible configuration values are present in this
# a... | 1 | 22,080 | @StrikerRUS what if we just removed build numbers and did `r-pkgdown=1.3.0`? Won't we have to fix this again if the RTD build machines change? | microsoft-LightGBM | cpp |
@@ -1,6 +1,5 @@
-# $Id$
#
-# Copyright (C) 2003-2006 Rational Discovery LLC
+# Copyright (C) 2002-2006 greg Landrum and Rational Discovery LLC
#
# @@ All Rights Reserved @@
# This file is part of the RDKit. | 1 | # $Id$
#
# Copyright (C) 2003-2006 Rational Discovery LLC
#
# @@ All Rights Reserved @@
# This file is part of the RDKit.
# The contents are covered by the terms of the BSD license
# which is included in the file license.txt, found at the root
# of the RDKit source tree.
#
""" unit testing code for molecule sup... | 1 | 16,667 | I'm not arguing with it, but how did you decide to make this change? | rdkit-rdkit | cpp |
@@ -1,7 +1,7 @@
# -*- coding: utf-8 -*-
##
## This file is part of Invenio.
-## Copyright (C) 2011, 2012 CERN.
+## Copyright (C) 2011, 2012, 2013, 2014 CERN.
##
## Invenio is free software; you can redistribute it and/or
## modify it under the terms of the GNU General Public License as | 1 | # -*- coding: utf-8 -*-
##
## This file is part of Invenio.
## Copyright (C) 2011, 2012 CERN.
##
## Invenio is free software; you can redistribute it and/or
## modify it under the terms of the GNU General Public License as
## published by the Free Software Foundation; either version 2 of the
## License, or (at your opt... | 1 | 12,801 | 1: D400 First line should end with '.', not 'd' 4: I102 copyright year is outdated, expected 2014 but got 2012 25:29: E126 continuation line over-indented for hanging indent 31: D103 Docstring missing 40: D103 Docstring missing 57: D103 Docstring missing 68: D103 Docstring missing 101: D103 Docstring missing 115: D401 ... | inveniosoftware-invenio | py |
@@ -42,6 +42,14 @@ type ACMEIssuer struct {
// Only ACME v2 endpoints (i.e. RFC 8555) are supported.
Server string `json:"server"`
+ // PreferredChain is the chain to use if the ACME server outputs multiple.
+ // PreferredChain is no guarantee that this one gets delivered by the ACME
+ // endpoint.
+ // For examp... | 1 | /*
Copyright 2020 The Jetstack cert-manager contributors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed... | 1 | 23,196 | Explain that this must match the `CommonName` of the first (or is it last?) certificate in the chain, where the first certificate is the chain root CA and the last certificate is the leaf certificate. | jetstack-cert-manager | go |
@@ -16,7 +16,7 @@ type Config struct {
Storage *storageConfig `yaml:"storage" required:"true"`
Blockchain *blockchain.Config `yaml:"blockchain"`
MetricsListenAddr string `yaml:"metrics_listen_addr" default:"127.0.0.1:14004"`
- ColdStart *ColdStartConfig `yaml:"cold_start... | 1 | package dwh
import (
"github.com/jinzhu/configor"
"github.com/pkg/errors"
"github.com/sonm-io/core/accounts"
"github.com/sonm-io/core/blockchain"
"github.com/sonm-io/core/insonmnia/logging"
)
type Config struct {
Logging LoggingConfig `yaml:"logging"`
GRPCListenAddr string `yaml:"... | 1 | 7,062 | do we really need this behavour to be configurable? | sonm-io-core | go |
@@ -3,7 +3,7 @@
*/
var MongooseArray = require('./array')
- , ObjectId = require('../drivers/node-mongodb-native/objectid')
+ , ObjectId = require('./objectid')
, ObjectIdSchema = require('../schema/objectid')
, utils = require('../utils')
, util = require('util') | 1 | /*!
* Module dependencies.
*/
var MongooseArray = require('./array')
, ObjectId = require('../drivers/node-mongodb-native/objectid')
, ObjectIdSchema = require('../schema/objectid')
, utils = require('../utils')
, util = require('util')
, Document = require('../document')
/**
* DocumentArray constructor
... | 1 | 12,517 | Hmm interesting. Do the tests check out on this? | Automattic-mongoose | js |
@@ -26,11 +26,15 @@ import java.util.concurrent.TimeUnit;
import com.google.common.base.Stopwatch;
import org.apache.logging.log4j.Logger;
+import org.apache.tuweni.bytes.Bytes;
+import org.apache.tuweni.concurrent.ExpiringMap;
import org.apache.tuweni.units.bigints.UInt256;
public class PoWSolver {
+ privat... | 1 | /*
* Copyright ConsenSys AG.
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing... | 1 | 25,612 | For another PR, another `--X` candidate. | hyperledger-besu | java |
@@ -10,4 +10,5 @@ const (
GettingStarted = "Getting Started ✨"
Develop = "Develop 🔧"
Settings = "Settings"
-)
+ Release = "Release"
+) | 1 | // +build !windows
// Copyright 2019 Amazon.com, Inc. or its affiliates. All Rights Reserved.
// SPDX-License-Identifier: Apache-2.0
// Package groups contains the names of command groups
package group
const (
GettingStarted = "Getting Started ✨"
Develop = "Develop 🔧"
Settings = "Settings"
) | 1 | 10,776 | Do we need to add this constant for `group_windows.go`? Otherwise, I believe the build will fail on windows. Also what do you think of adding the emoji at the end? The windows one could be plain. | aws-copilot-cli | go |
@@ -4,6 +4,8 @@
package net.sourceforge.pmd.lang.ast.xpath;
+import static junit.framework.TestCase.assertTrue;
+
import java.util.HashMap;
import java.util.Map;
| 1 | /**
* BSD-style license; for more info see http://pmd.sourceforge.net/license.html
*/
package net.sourceforge.pmd.lang.ast.xpath;
import java.util.HashMap;
import java.util.Map;
import org.junit.Assert;
import org.junit.Test;
import net.sourceforge.pmd.lang.ast.DummyNode;
/**
* Unit test for {@link AttributeAxi... | 1 | 13,865 | this is a junit 3 import, not a junit 4 | pmd-pmd | java |
@@ -113,9 +113,16 @@ func TestReconcile(t *testing.T) {
assert.Equal(t, hivev1.UnsupportedHibernationReason, cond.Reason)
},
},
+ {
+ name: "clustersync not yet created",
+ cd: cdBuilder.Options(o.shouldHibernate).Build(),
+ expectError: true,
+ },
{
name: "start hibernating, ... | 1 | package hibernation
import (
"context"
"fmt"
"testing"
"time"
"github.com/golang/mock/gomock"
log "github.com/sirupsen/logrus"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
batchv1 "k8s.io/api/batch/v1"
certsv1 "k8s.io/api/certificates/v1"
corev1 "k8s.io/api/core/v1"
metav1 "... | 1 | 19,942 | shouldn't there be a reque expected here? | openshift-hive | go |
@@ -63,7 +63,7 @@ namespace NLog.Layouts
///
/// Thread-agnostic layouts only use contents of <see cref="LogEventInfo"/> for its output.
/// </remarks>
- internal bool ThreadAgnostic { get; private set; }
+ internal bool ThreadAgnostic { get; set; }
/// <summary>
... | 1 | //
// Copyright (c) 2004-2016 Jaroslaw Kowalski <jaak@jkowalski.net>, Kim Christensen, Julian Verdurmen
//
// All rights reserved.
//
// Redistribution and use in source and binary forms, with or without
// modification, are permitted provided that the following conditions
// are met:
//
// * Redistributions of s... | 1 | 15,361 | I prefer to make it `protected set`. What do you think? | NLog-NLog | .cs |
@@ -178,7 +178,9 @@ type Options struct {
Gateway GatewayOpts `json:"gateway,omitempty"`
LeafNode LeafNodeOpts `json:"leaf,omitempty"`
JetStream bool `json:"jetstream"`
- StoreDir string `json:"store_dir"`
+ JetStreamMaxMemory int64 ... | 1 | // Copyright 2012-2019 The NATS Authors
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to ... | 1 | 9,908 | Maybe rename this to JetStreamStoreDir? | nats-io-nats-server | go |
@@ -52,7 +52,8 @@ var _ = Describe("UsageReporter with mocked URL and short interval", func() {
httpHandler = &requestRecorder{}
go func() {
defer GinkgoRecover()
- http.Serve(tcpListener, httpHandler)
+ // TODO: Investigate why this call sometimes returns an error.
+ _ = http.Serve(tcpListener, httpHan... | 1 | // Copyright (c) 2016-2018 Tigera, Inc. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by ... | 1 | 17,213 | You can start by logging out the error | projectcalico-felix | c |
@@ -31,7 +31,7 @@ namespace Nethermind.JsonRpc.Modules.Eth.GasPrice
{
private readonly IBlockFinder _blockFinder;
private readonly UInt256 _minGasPrice;
- public UInt256 FallbackGasPrice => LastGasPrice ?? _minGasPrice;
+ public UInt256 FallbackGasPrice(in UInt256? baseFeePerGas = n... | 1 | // Copyright (c) 2021 Demerzel Solutions Limited
// This file is part of the Nethermind library.
//
// The Nethermind library is free software: you can redistribute it and/or modify
// it under the terms of the GNU Lesser General Public License as published by
// the Free Software Foundation, either version 3 of ... | 1 | 26,373 | In general, what is the reason for the fallback price to be public? If it is public, why does it take baseFeePerGas instead of a block header? | NethermindEth-nethermind | .cs |
@@ -80,7 +80,7 @@ import java.util.function.*;
* @param <V> Value type
* @author Daniel Dietrich, Ruslan Sennov
*/
-public interface Map<K, V> extends Traversable<Tuple2<K, V>>, Function1<K, V>, PartialFunction<K, V>, Serializable {
+public interface Map<K, V> extends Traversable<Tuple2<K, V>>, PartialFunction<K,... | 1 | /* __ __ __ __ __ ___
* \ \ / / \ \ / / __/
* \ \/ / /\ \ \/ / /
* \____/__/ \__\____/__/.ɪᴏ
* ᶜᵒᵖʸʳᶦᵍʰᵗ ᵇʸ ᵛᵃᵛʳ ⁻ ˡᶦᶜᵉⁿˢᵉᵈ ᵘⁿᵈᵉʳ ᵗʰᵉ ᵃᵖᵃᶜʰᵉ ˡᶦᶜᵉⁿˢᵉ ᵛᵉʳˢᶦᵒⁿ ᵗʷᵒ ᵈᵒᵗ ᶻᵉʳᵒ
*/
package io.vavr.collect... | 1 | 12,354 | follow-up of #2002 | vavr-io-vavr | java |
@@ -162,7 +162,7 @@ public class TiSession implements AutoCloseable {
if (tableScanThreadPool == null) {
tableScanThreadPool =
Executors.newFixedThreadPool(
- conf.getTableScanConcurrency(),
+ conf.getTableScanConcurrency() / conf.getPartitionPerSplit... | 1 | /*
* Copyright 2017 PingCAP, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed ... | 1 | 12,081 | could you give some explanations of what problem do you want to solve by this change, and how/why it works? | pingcap-tispark | java |
@@ -2,16 +2,18 @@
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.
+using System;
using System.Collections.Generic;
using System.Threading;
using System.Threading.Tasks;
+using Xunit;
using Xunit.Abstractions;
using Xunit.... | 1 | // Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.
using System.Collections.Generic;
using System.Threading;
using System.Threading.Tasks;
using Xunit.Abstractions;
us... | 1 | 12,779 | LongLivedMarshalByRefObject exists in both the netstandard and netfx xunit? | dotnet-buildtools | .cs |
@@ -47,6 +47,12 @@ module Selenium
@bridge.send_command(cmd: cmd, params: params)
end
+ def print_page(**options)
+ options[:page_ranges] &&= Array(options[:page_ranges])
+
+ bridge.print_page(options)
+ end
+
private
def debugger_address | 1 | # frozen_string_literal: true
# Licensed to the Software Freedom Conservancy (SFC) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The SFC licenses this file
# to you under the Apache License, Version 2.0... | 1 | 18,367 | the bridge here isn't defined as an accessor / reader to try mask it better. So you need to directly call the iVar `@bridge` here. | SeleniumHQ-selenium | rb |
@@ -85,12 +85,11 @@ func Run(ctx context.Context, cfg *config.Node) error {
}
logrus.Infof("Running containerd %s", config.ArgString(args[1:]))
- cmd := exec.Command(args[0], args[1:]...)
+ cmd := exec.CommandContext(ctx, args[0], args[1:]...)
cmd.Stdout = stdOut
cmd.Stderr = stdErr
cmd.Env = env
-... | 1 | package containerd
import (
"bufio"
"compress/bzip2"
"compress/gzip"
"context"
"fmt"
"io"
"io/ioutil"
"os"
"os/exec"
"path/filepath"
"strings"
"time"
"github.com/containerd/containerd"
"github.com/containerd/containerd/errdefs"
"github.com/containerd/containerd/images"
"github.com/containerd/container... | 1 | 9,961 | Testing on linux with this change, containerd no longer stops when k3s stops. | k3s-io-k3s | go |
@@ -266,6 +266,11 @@ type Config struct {
// MaxConnectionReceiveWindow is the connection-level flow control window for receiving data.
// If this value is zero, it will default to 15 MB.
MaxConnectionReceiveWindow uint64
+ // AllowConnectionWindowIncrease is called every time the connection flow controller attem... | 1 | package quic
import (
"context"
"errors"
"io"
"net"
"time"
"github.com/lucas-clemente/quic-go/internal/handshake"
"github.com/lucas-clemente/quic-go/internal/protocol"
"github.com/lucas-clemente/quic-go/logging"
)
// The StreamID is the ID of a QUIC stream.
type StreamID = protocol.StreamID
// A VersionNumb... | 1 | 10,098 | Maybe [u]int64 to be consistent with other byte-valued vars in this struct? | lucas-clemente-quic-go | go |
@@ -25,7 +25,9 @@
<%- if signed_in? %>
<div class="mycart-link">
<ul class="header-nav">
- <li><%= link_to("My Requests", carts_path) %> <%= image_tag "img-cart.png", width: '18px', height:'16px' %></li>
+ <li><%= link_to "My Requests", carts_path %> <%= image_tag "img-cart.png"... | 1 | <div id='communicart_header'>
<div class='container'>
<div id='header-identity'>
<div id="communicart_logo">Communicart</div>
<h1>Approval Portal</h1>
</div>
<ul class='header-nav'>
<%- unless signed_in? %>
<li>
<%= link_to 'Sign in with MyUSA', "/auth/myusa" %>
... | 1 | 12,517 | This brings up the question... do we need to start assigning users to the different use cases in some way? We don't want this link to show up for Ric, for example. | 18F-C2 | rb |
@@ -36,9 +36,12 @@ template <typename Dtype>
BasePrefetchingDataLayer<Dtype>::BasePrefetchingDataLayer(
const LayerParameter& param)
: BaseDataLayer<Dtype>(param),
- prefetch_free_(), prefetch_full_() {
- for (int i = 0; i < PREFETCH_COUNT; ++i) {
- prefetch_free_.push(&prefetch_[i]);
+ prefetc... | 1 | #include <boost/thread.hpp>
#include <vector>
#include "caffe/blob.hpp"
#include "caffe/data_transformer.hpp"
#include "caffe/internal_thread.hpp"
#include "caffe/layer.hpp"
#include "caffe/layers/base_data_layer.hpp"
#include "caffe/proto/caffe.pb.h"
#include "caffe/util/blocking_queue.hpp"
namespace caffe {
templa... | 1 | 37,568 | Unless I'm misunderstanding something, this should just be `prefetch_(param.data_param().prefetch())`, no? That should just use the default value if there's no explicit `data_param` or `data_param.prefetch` set, removing the need to also duplicate and hardcode `PREFETCH_COUNT`. | BVLC-caffe | cpp |
@@ -55,6 +55,16 @@ func nodeStatus(node *node.AlgorandFullNode) (res v1.NodeStatus, err error) {
}, nil
}
+func txEncode(tx transactions.Transaction, ad transactions.ApplyData) (res v1.Transaction, err error) {
+ switch tx.Type {
+ case protocol.PaymentTx:
+ return paymentTxEncode(tx, ad), nil
+ case protocol.Key... | 1 | // Copyright (C) 2019 Algorand, Inc.
// This file is part of go-algorand
//
// go-algorand is free software: you can redistribute it and/or modify
// it under the terms of the GNU Affero General Public License as
// published by the Free Software Foundation, either version 3 of the
// License, or (at your option) any l... | 1 | 35,877 | nit : move this into a default clause in the previous switch statement. | algorand-go-algorand | go |
@@ -27,14 +27,12 @@ var formatter = this;
string = function(value) {
if (value != null) {
value = value.replace(/\\/g, '\\\\');
- value = value.replace(/\"/g, '\\"');
+ value = value.replace(/\'/g, '\\\'');
value = value.replace(/\r/g, '\\r');
value = value.replace(/\n/g, '\\n');
- value = value.replace(... | 1 | /*
* Format for Selenium Remote Control Perl client.
*/
var subScriptLoader = Components.classes["@mozilla.org/moz/jssubscript-loader;1"].getService(Components.interfaces.mozIJSSubScriptLoader);
subScriptLoader.loadSubScript('chrome://selenium-ide/content/formats/remoteControl.js', this);
this.name = "perl-rc";
//... | 1 | 10,826 | It should be return "''"; I will fix it | SeleniumHQ-selenium | js |
@@ -43,14 +43,14 @@ type ClusterEvent interface{}
// Specific type of cluster event emitted when new member joins cluster
type NewMemberEvent struct {
endpointsInfo
- Id string
+ ID string
}
// Specific type of cluster event emitted when leadership is transferred.
// It is not always loss or acquire of leaders... | 1 | package hub
import (
"bytes"
"context"
"crypto/tls"
"encoding/json"
"fmt"
"net"
"reflect"
"strings"
"sync"
"time"
"github.com/docker/leadership"
"github.com/docker/libkv"
"github.com/docker/libkv/store"
"github.com/docker/libkv/store/boltdb"
"github.com/docker/libkv/store/consul"
log "github.com/noxio... | 1 | 6,298 | Go standard linter hates `Id`s and likes `ID`s, please do not resist. | sonm-io-core | go |
@@ -71,11 +71,11 @@ module Travis
end
def fetch_ref
- cmd "git fetch origin +#{data.ref}: ", assert: true, timeout: :git_fetch_ref, fold: "git.#{next_git_fold_number}"
+ cmd "git fetch origin +#{data.ref}: ", assert: true, timeout: :git_fetch_ref, fold: "git.#{next_git_fold... | 1 | require 'shellwords'
module Travis
module Build
class Script
module Git
DEFAULTS = {
git: { depth: 50, submodules: true, strategy: 'clone' }
}
def checkout
install_source_key
if tarball_clone?
download_tarball
else
git... | 1 | 11,378 | I don't think retrying here is as useful, since `git-checkout` doesn't access the network AFAIK, and if it fails once it's probably going to fail all three times. | travis-ci-travis-build | rb |
@@ -172,7 +172,7 @@ func SetCertificateNotBefore(p metav1.Time) CertificateModifier {
}
}
-func SetCertificateRenewalTIme(p metav1.Time) CertificateModifier {
+func SetCertificateRenewalTime(p metav1.Time) CertificateModifier {
return func(crt *v1.Certificate) {
crt.Status.RenewalTime = &p
} | 1 | /*
Copyright 2020 The cert-manager Authors.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing... | 1 | 29,449 | Fixing this typo caused a build failure in `cmd/ctl/pkg/status/certificate/certificate_test.go:238` Could you also update it there? | jetstack-cert-manager | go |
@@ -25,6 +25,8 @@ _rtp_payload_types = {
31: 'H261', 32: 'MPV',
33: 'MP2T', 34: 'H263' }
+extension_condition = lambda pkt: pkt.extension
+
class RTP(Packet):
name="RTP"
fields_desc = [ BitField('version', 2, 2), | 1 | ## This file is part of Scapy
## See http://www.secdev.org/projects/scapy for more informations
## Copyright (C) Philippe Biondi <phil@secdev.org>
## This program is published under a GPLv2 license
"""
RTP (Real-time Transport Protocol).
"""
from scapy.packet import *
from scapy.fields import *
_rtp_payload_types = ... | 1 | 10,597 | Please note that adding this will import `extension_condition` in the entire scapy (as you are located in a layer). You might want to move this inside the RTP class ? Would be better i think | secdev-scapy | py |
@@ -72,7 +72,7 @@ module RSpec::Core
end
parser.on('--seed SEED', Integer, 'Equivalent of --order rand:SEED.') do |seed|
- options[:order] = "rand:#{seed}"
+ options[:seed] = seed
end
parser.on('--fail-fast', 'Abort the run on first failure.') do |o| | 1 | # http://www.ruby-doc.org/stdlib/libdoc/optparse/rdoc/classes/OptionParser.html
require 'optparse'
module RSpec::Core
class Parser
def self.parse!(args)
new.parse!(args)
end
class << self
alias_method :parse, :parse!
end
def parse!(args)
return {} if args.empty?
convert... | 1 | 10,523 | This will need updating, as I'm not sure we'll want to turn on random ordering if they've specified a seed for programmatic use. | rspec-rspec-core | rb |
@@ -112,6 +112,9 @@ loader_init(void)
char name_copy[MAXIMUM_PATH];
mod = privload_insert(NULL, privmod_static[i].base, privmod_static[i].size,
privmod_static[i].name, privmod_static[i].path);
+#ifdef CLIENT_INTERFACE
+ mod->is_client = true;
+#endif
LOG(... | 1 | /* *******************************************************************************
* Copyright (c) 2011-2019 Google, Inc. All rights reserved.
* Copyright (c) 2010 Massachusetts Institute of Technology All rights reserved.
* Copyright (c) 2009 Derek Bruening All rights reserved.
* ******************************... | 1 | 19,140 | Are you sure these are all client libs? This seems fragile: if we later load sthg else early this will break. Seems best to have some kind of sanity check: at least add an assert in the current location where this is set. | DynamoRIO-dynamorio | c |
@@ -2167,7 +2167,9 @@ namespace pwiz.Skyline.Model.Lib
}
if (!string.IsNullOrEmpty(OtherKeys))
{
- smallMolLines.Add(new KeyValuePair<string, string> (Resources.SmallMoleculeLibraryAttributes_KeyValuePairs_OtherIDs, OtherKeys.Replace('\t','\n')));
+ ... | 1 | /*
* Original author: Brendan MacLean <brendanx .at. u.washington.edu>,
* MacCoss Lab, Department of Genome Sciences, UW
*
* Copyright 2009 University of Washington - Seattle, WA
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in co... | 1 | 14,500 | Picking nits here, but as a Dictionary already is a collection of KeyValuePairs there's undoubtably a way to code this that doesn't involve constructing any new ones. | ProteoWizard-pwiz | .cs |
@@ -19,12 +19,7 @@ package org.camunda.bpm.model.cmmn;
import static org.camunda.bpm.model.cmmn.impl.CmmnModelConstants.CMMN10_NS;
import static org.camunda.bpm.model.cmmn.impl.CmmnModelConstants.CMMN11_NS;
-import java.io.File;
-import java.io.FileInputStream;
-import java.io.FileNotFoundException;
-import java.io... | 1 | /*
* Copyright Camunda Services GmbH and/or licensed to Camunda Services GmbH
* under one or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information regarding copyright
* ownership. Camunda licenses this file to you under the Apache License,
* Version 2.0; y... | 1 | 11,005 | As Miklas stated, please avoid wildcard imports. | camunda-camunda-bpm-platform | java |
@@ -204,5 +204,4 @@ function server (inputCompanionOptions = {}) {
return { app, companionOptions }
}
-const { app, companionOptions } = server()
-module.exports = { app, companionOptions, server }
+module.exports = { server } | 1 | const express = require('express')
const qs = require('querystring')
const helmet = require('helmet')
const morgan = require('morgan')
const bodyParser = require('body-parser')
const { URL } = require('url')
const merge = require('lodash/merge')
const session = require('express-session')
const addRequestId = require('e... | 1 | 14,051 | Maybe change it to `module.exports = server` ? Becase there's nothing else to export here | transloadit-uppy | js |
@@ -24,14 +24,13 @@ import (
"cloud.google.com/go/pubsub"
"cloud.google.com/go/pubsub/pstest"
+ "google.golang.org/grpc/codes"
reconcilertestingv1 "github.com/google/knative-gcp/pkg/reconciler/testing/v1"
"github.com/google/knative-gcp/pkg/utils/authcheck"
"google.golang.org/api/option"
"google.golang... | 1 | /*
Copyright 2019 Google LLC
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
dist... | 1 | 19,411 | This may be an automated change, but the import seems to fit better where it was previously. | google-knative-gcp | go |
@@ -0,0 +1,9 @@
+<script type="text/javascript">
+ window.analytics||(window.analytics=[]),window.analytics.methods=["identify","track","trackLink","trackForm","trackClick","trackSubmit","page","pageview","ab","alias","ready","group","on","once","off"],window.analytics.factory=function(t){return function(){var a=Array... | 1 | 1 | 9,016 | Might we want to separate including this snippet and sending the data for signed in users into different partials? | thoughtbot-upcase | rb | |
@@ -32,7 +32,11 @@ type PeerAdder interface {
}
type ClosestPeerer interface {
- ClosestPeer(addr swarm.Address) (peerAddr swarm.Address, err error)
+ // ClosestPeer returns the closest connected peer we have in relation to a
+ // given chunk address.
+ // This function will ignore peers with addresses provided in ... | 1 | // Copyright 2020 The Swarm Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
package topology
import (
"context"
"errors"
"io"
"github.com/ethersphere/bee/pkg/swarm"
)
var (
ErrNotFound = errors.New("no peer found")
ErrWantSe... | 1 | 13,044 | closest to the address | ethersphere-bee | go |
@@ -18,13 +18,17 @@ const ROW_WIDTHS_MAP_NAME = 'autoRowSize';
* @plugin AutoRowSize
* @class AutoRowSize
* @description
- * This plugin allows to set row heights based on their highest cells.
+ * The `AutoRowSize` plugin allows you to set row heights based on their highest cells.
*
* By default, the plugin i... | 1 | import { BasePlugin } from '../base';
import { arrayEach, arrayFilter } from '../../helpers/array';
import { cancelAnimationFrame, requestAnimationFrame } from '../../helpers/feature';
import { isVisible } from '../../helpers/dom/element';
import GhostTable from '../../utils/ghostTable';
import { isObject, hasOwnProper... | 1 | 20,451 | It should be much more clear for end-user | handsontable-handsontable | js |
@@ -82,7 +82,7 @@ SINGLE_QUOTED_REGEX = re.compile("(%s)?'''" % "|".join(_PREFIXES))
DOUBLE_QUOTED_REGEX = re.compile('(%s)?"""' % "|".join(_PREFIXES))
QUOTE_DELIMITER_REGEX = re.compile("(%s)?(\"|')" % "|".join(_PREFIXES), re.DOTALL)
-MSGS = {
+MSGS = { # pylint: disable=consider-using-namedtuple
"E1300": (
... | 1 | # Copyright (c) 2009-2014 LOGILAB S.A. (Paris, FRANCE) <contact@logilab.fr>
# Copyright (c) 2010 Daniel Harding <dharding@gmail.com>
# Copyright (c) 2012-2014 Google, Inc.
# Copyright (c) 2013-2020 Claudiu Popa <pcmanticore@gmail.com>
# Copyright (c) 2014 Brett Cannon <brett@python.org>
# Copyright (c) 2014 Arun Persau... | 1 | 14,151 | Isn't this an example that this will be prone to false positives ? We had nothing to fix in the codebase (And I think there is dict that could be named tuple in the MessageStore/MessageIdStore), but we have a false positives on our checkers. | PyCQA-pylint | py |
@@ -55,11 +55,11 @@ func TestOpenCensus(t *testing.T) {
const provider = "gocloud.dev/blob/memblob"
diff := octest.Diff(te.Spans(), te.Counts(), "gocloud.dev/blob", provider, []octest.Call{
- {"NewWriter", gcerrors.OK},
- {"NewRangeReader", gcerrors.OK},
- {"Attributes", gcerrors.OK},
- {"Delete", gcerrors.OK... | 1 | // Copyright 2019 The Go Cloud Development Kit Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// https://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by appli... | 1 | 15,798 | We control `octest`, so it shouldn't be necessary to provide struct literal keys. This is a case of vet being too picky. | google-go-cloud | go |
@@ -90,5 +90,8 @@ module DMPRoadmap
# is_test - (NOT advisable because test plans are excluded from statistics)
# privately_visible - Only the owner and people they invite can access the plan
config.default_plan_visibility = 'privately_visible'
+
+ # The percentage of ... | 1 | require File.expand_path('../boot', __FILE__)
require 'rails/all'
#require 'devise'
require 'recaptcha/rails'
require 'csv'
# Require the gems listed in Gemfile, including any gems
# you've limited to :test, :development, or :production.
#if defined?(Bundler)
# If you precompile assets before deploying to productio... | 1 | 16,958 | I would put that constant under config/initializers/constant.rb and I would leave application.rb for rails specific. | DMPRoadmap-roadmap | rb |
@@ -572,7 +572,18 @@ func (fup folderUpdatePrepper) updateResolutionUsage(ctx context.Context,
// addUnrefToFinalResOp makes a resolutionOp at the end of opsList if
// one doesn't exist yet, and then adds the given pointer as an unref
// block to it.
-func addUnrefToFinalResOp(ops opsList, ptr BlockPointer) opsList ... | 1 | // Copyright 2017 Keybase Inc. All rights reserved.
// Use of this source code is governed by a BSD
// license that can be found in the LICENSE file.
package libkbfs
import (
"fmt"
"github.com/keybase/client/go/logger"
"github.com/keybase/client/go/protocol/keybase1"
"github.com/keybase/kbfs/kbfsblock"
"github.... | 1 | 16,594 | Is there a reason not to do something like `if _, ok := doNotUnref[ptr.ID]; ok { return ops }` here? | keybase-kbfs | go |
@@ -539,7 +539,10 @@ class WebElement(object):
@property
def rect(self):
"""A dictionary with the size and location of the element."""
- return self._execute(Command.GET_ELEMENT_RECT)['value']
+ if self._w3c:
+ return self._execute(Command.GET_ELEMENT_RECT)['value']
+ ... | 1 | # Licensed to the Software Freedom Conservancy (SFC) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The SFC licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not... | 1 | 15,812 | This would return a tuple of two dictionaries. You need to combine them and return a dictionary | SeleniumHQ-selenium | js |
@@ -29,10 +29,10 @@ class Node(object):
def __repr__(self):
return self._class_repr()
- def __call__(self):
- return self._data()
+ def __call__(self, asa=None):
+ raise NotImplementedError
- def _data(self):
+ def _data(self, asa=None):
raise NotImplementedError
| 1 | """
Nodes that represent the data in a Quilt package.
"""
import copy
import os
import pandas as pd
from six import iteritems, string_types
from .tools import core
from .tools.const import SYSTEM_METADATA
from .tools.util import is_nodename
class Node(object):
"""
Abstract class that represents a group or a... | 1 | 16,721 | Why not always forward it to `_data`? | quiltdata-quilt | py |
@@ -263,7 +263,7 @@ def connect_spotify_callback():
return redirect(url_for('profile.connect_spotify'))
-@profile_bp.route('/refresh-spotify-token', methods=['GET'])
+@profile_bp.route('/refresh-spotify-token', methods=['POST'])
@crossdomain()
@api_login_required
def refresh_spotify_token(): | 1 | import listenbrainz.db.stats as db_stats
import listenbrainz.db.user as db_user
import listenbrainz.webserver.rabbitmq_connection as rabbitmq_connection
from listenbrainz.webserver.decorators import crossdomain
import os
import re
import ujson
import zipfile
from datetime import datetime
from flask import Blueprint, ... | 1 | 15,338 | there are tests that use `client.get` which will fail now | metabrainz-listenbrainz-server | py |
@@ -371,7 +371,7 @@ func (fs *FS) mkdirAll(filename string, perm os.FileMode) (err error) {
switch errors.Cause(err).(type) {
case libkbfs.NameExistsError:
// The child directory already exists.
- case libkbfs.WriteAccessError:
+ case libkbfs.WriteAccessError, libkbfs.WriteToReadonlyNodeError:
// If the... | 1 | // Copyright 2017 Keybase Inc. All rights reserved.
// Use of this source code is governed by a BSD
// license that can be found in the LICENSE file.
package libfs
import (
"bytes"
"context"
"crypto/rand"
"encoding/base64"
"net/http"
"os"
"path"
"strings"
"sync"
"time"
"github.com/keybase/client/go/logger... | 1 | 18,951 | Whoa, TIL about this syntax. | keybase-kbfs | go |
@@ -34,12 +34,14 @@ type fakeHandler struct {
}
func (h fakeHandler) Handle(context.Context, *yarpc.Request, *yarpc.Buffer) (*yarpc.Response, *yarpc.Buffer, error) {
- errorInfo := yarpcerror.ExtractInfo(h.applicationErr)
- res := &yarpc.Response{ApplicationErrorInfo: &errorInfo}
if h.applicationErr != nil {
+ e... | 1 | // Copyright (c) 2018 Uber Technologies, Inc.
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge... | 1 | 18,358 | This is a smell. When is this valid? Perhaps this should be `nil, nil, ErrNoResponse` or some such. While it is usually invalid to have neither a return value or error, we rarely check for the case in other idiomatic Go. Nothing wrong with extra defenses here, but think about it. | yarpc-yarpc-go | go |
@@ -0,0 +1,7 @@
+_base_ = './faster_rcnn_r50_fpn_1x_coco.py'
+classes = ('person', 'bicycle', 'car')
+data = dict(
+ train=dict(classes=classes),
+ val=dict(classes=classes),
+ test=dict(classes=classes))
+load_from = 'https://s3.ap-northeast-2.amazonaws.com/open-mmlab/mmdetection/models/faster_rcnn_r50_fpn_1x... | 1 | 1 | 18,919 | This URL is outdated, add a `TODO` to fix it. | open-mmlab-mmdetection | py | |
@@ -23,10 +23,13 @@ type (
Proto() *iotextypes.ActionCore
LoadProto(pbAct *iotextypes.ActionCore) error
SetNonce(n uint64)
+ ChainID() uint32
+ SetChainID(chainID uint32)
}
envelope struct {
version uint32
+ chainID uint32
nonce uint64
gasLimit uint64
gasPrice *big.Int | 1 | package action
import (
"math/big"
"github.com/iotexproject/iotex-proto/golang/iotextypes"
"github.com/pkg/errors"
"github.com/iotexproject/iotex-core/pkg/log"
)
type (
// Envelope defines an envelope wrapped on action with some envelope metadata.
Envelope interface {
Version() uint32
Nonce() uint64
Gas... | 1 | 23,636 | `ChainID()` is a getter method, move up to `Nonce()` | iotexproject-iotex-core | go |
@@ -163,6 +163,10 @@ public class FlowTriggerScheduler {
flowId, flowTrigger, submitUser, quartzTriggers.isEmpty() ? null
: quartzTriggers.get(0), isPaused, flow.isLocked());
} catch (final Exception ex) {
+ if (QuartzScheduler.isSerializationBug(ex) && this.scheduler.ena... | 1 | /*
* Copyright 2017 LinkedIn Corp.
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not
* use this file except in compliance with the License. You may obtain a copy of
* the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to i... | 1 | 19,004 | If this condition is not met, shall we just throw the exception rather than logging it? @li-ygerchikov Your thoughts? | azkaban-azkaban | java |
@@ -57,6 +57,7 @@ REQUIRED_PACKAGES = [
'mock>=2.0.0',
'parameterized>=0.6.1',
'simple-crypt>=4.1.7',
+ 'ruamel.yaml'
]
if sys.version_info < (2, 7): | 1 | #!/usr/bin/env python
# Copyright 2017 The Forseti Security Authors. All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
#... | 1 | 28,861 | nit: alpha-sort `ruamel.yaml` in this list please | forseti-security-forseti-security | py |
@@ -58,6 +58,15 @@ public class TableScanUtil {
Function<FileScanTask, Long> weightFunc = file -> Math.max(file.length(), openFileCost);
+ Preconditions.checkArgument(splitSize > 0,
+ "Cannot create a plan with a split size that is not positive, splitSize = %s", splitSize);
+
+ Preconditions.check... | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you ... | 1 | 37,513 | Remove this because we already added it in another pr | apache-iceberg | java |
@@ -79,7 +79,13 @@ public class ShortcutManager {
try {
if (shortcutDTO.getIcon() != null) {
- File file = new File(shortcutDTO.getIcon());
+ File file;
+ try {
+ file = new File(shortcutDTO.getIcon());
+ ... | 1 | /*
* Copyright (C) 2015-2017 PÂRIS Quentin
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2 of the License, or
* (at your option) any later version.
*
* This program is... | 1 | 12,521 | Can we maybe move the `File` creation to a new method? I mean both changes look equal to me with the difference of two parts, which could be specified using two input parameters. | PhoenicisOrg-phoenicis | java |
@@ -9,6 +9,8 @@ class ApiToken < ActiveRecord::Base
# TODO validates :access_token, presence: true
validates :approval_id, presence: true
+ validates :access_token, presence: true, allow_blank: true, length: { minimum: 0, maximum: 255 }
+ validates :user, presence: true, allow_blank: true
scope :unexpire... | 1 | class ApiToken < ActiveRecord::Base
has_paper_trail
before_create :generate_token
belongs_to :approval, class_name: 'Approvals::Individual'
has_one :proposal, through: :approval
has_one :user, through: :approval
# TODO validates :access_token, presence: true
validates :approval_id, presence: true
sc... | 1 | 13,884 | I think we want to require the association with the user...? | 18F-C2 | rb |
@@ -110,8 +110,17 @@ func (smsg *SignedMessage) VerifySignature() error {
}
// OnChainLen returns the amount of bytes used to represent the message on chain.
+// Dragons: verify this is the correct way to determine a signed messages size on chain.
func (smsg *SignedMessage) OnChainLen() uint32 {
- panic("byteme")
... | 1 | package types
import (
"bytes"
"encoding/json"
"fmt"
blocks "github.com/ipfs/go-block-format"
"github.com/ipfs/go-cid"
cbor "github.com/ipfs/go-ipld-cbor"
ipld "github.com/ipfs/go-ipld-format"
"github.com/pkg/errors"
"github.com/filecoin-project/go-filecoin/internal/pkg/constants"
"github.com/filecoin-proj... | 1 | 23,004 | I am unsure the below implementation is correct, but need this method to not panic else it borks the chain-validation tests. | filecoin-project-venus | go |
@@ -19,7 +19,7 @@ A wrapper class for Spark Column to behave similar to pandas Series.
"""
import re
import inspect
-from collections import Iterable
+from collections import Iterable, OrderedDict
from functools import partial, wraps
from typing import Any, Generic, List, Optional, Tuple, TypeVar, Union
| 1 | #
# Copyright (C) 2019 Databricks, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to i... | 1 | 11,697 | nit: no need this change anymore. | databricks-koalas | py |
@@ -1967,9 +1967,7 @@ class Codebase
$this->taint_flow_graph->addSource($source);
- $expr_type->parent_nodes = [
- $source->id => $source,
- ];
+ $expr_type->parent_nodes[$source->id] = $source;
}
/** | 1 | <?php
namespace Psalm;
use Exception;
use InvalidArgumentException;
use LanguageServerProtocol\Command;
use LanguageServerProtocol\CompletionItem;
use LanguageServerProtocol\CompletionItemKind;
use LanguageServerProtocol\InsertTextFormat;
use LanguageServerProtocol\ParameterInformation;
use LanguageServerProtocol\Pos... | 1 | 12,524 | This isn't really that closely related to everything else in this PR, but I'm pretty sure it's a correct change. I'm not familiar enough with the taint feature to know how to test it, but I worry that without this change some of the taint stuff might mess up the `parent_nodes` for a reference. | vimeo-psalm | php |
@@ -6,8 +6,9 @@
package javaslang;
import javaslang.collection.Iterator;
-import javaslang.collection.List;
import javaslang.collection.Seq;
+import javaslang.collection.Stream;
+import javaslang.collection.Vector;
import javaslang.control.Option;
import java.io.IOException; | 1 | /* / \____ _ _ ____ ______ / \ ____ __ _______
* / / \/ \ / \/ \ / /\__\/ // \/ \ // /\__\ JΛVΛSLΛNG
* _/ / /\ \ \/ / /\ \\__\\ \ // /\ \ /\\/ \ /__\ \ Copyright 2014-2016 Javaslang, http://javaslang.io
* /___/\_/ \_/\____/\_/ \_/\__\/__/\__\_/ \_// \__/\_____/ ... | 1 | 10,395 | [Checkstyle] ERROR: Unused import - javaslang.collection.Stream. | vavr-io-vavr | java |
@@ -126,7 +126,7 @@ public class TestPseudoReturnFields extends SolrTestCaseJ4 {
,"//result/doc/str[@name='ssto']"
,"//result/doc/str[@name='subject']"
- ,"//result/doc[count(*)=4]"
+ ,"//result/doc[count(*)=5]"
);
}
} | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may ... | 1 | 28,004 | The numbers were changed since now _root_ is also added to the doc, increasing the field count by 1. | apache-lucene-solr | java |
@@ -169,12 +169,6 @@ class ArrayMapReturnTypeProvider implements FunctionReturnTypeProviderInterface
$function_call_arg->value->items[1]->value->value,
[]
);
- } elseif ($variable_atomic_type instanceof... | 1 | <?php
namespace Psalm\Internal\Provider\ReturnTypeProvider;
use PhpParser;
use Psalm\Context;
use Psalm\Internal\Analyzer\Statements\Expression\AssertionFinder;
use Psalm\Internal\Analyzer\Statements\Expression\Call\FunctionCallAnalyzer;
use Psalm\Internal\Analyzer\Statements\Expression\Call\MethodCallAnalyzer;
use P... | 1 | 12,394 | TTemplateParamClass is handled above with the same content in the conditional | vimeo-psalm | php |
@@ -597,6 +597,17 @@ class Upgrade
}
}
+ // Upgrade CAPTCHA Options
+ $oldKeys
+ = ['siteKey', 'publicKey', 'secretKey', 'privateKey'];
+ foreach ($oldKeys as $key) {
+ if (isset($newConfig['Captcha'][$key])) {
+ $newConfig['Captcha']['re... | 1 | <?php
/**
* VF Configuration Upgrade Tool
*
* PHP version 7
*
* Copyright (C) Villanova University 2010.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 2,
* as published by the Free Software Foundation.
*
* This program ... | 1 | 29,047 | Do we need to add `theme` here? | vufind-org-vufind | php |
@@ -160,6 +160,9 @@ type Network struct {
// VPC defines the cluster vpc.
VPC *VPC `json:"vpc"`
+ // InternetGatewayID is the id of the internet gateway associated with the VPC.
+ InternetGatewayID *string `json:"internetGatewayId"`
+
// Subnets includes all the subnets defined inside the VPC.
Subnets Subnets... | 1 | // Copyright © 2018 The Kubernetes Authors.
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or ag... | 1 | 6,076 | i think you have to regen the api stuff, `make generate` | kubernetes-sigs-cluster-api-provider-aws | go |
@@ -187,9 +187,17 @@ public class SECP256K1 {
signer.init(true, privKey);
final BigInteger[] components = signer.generateSignature(dataHash.toArrayUnsafe());
- final BigInteger r = components[0];
- BigInteger s = components[1];
+ return normaliseSignature(components[0], components[1], keyPair.get... | 1 | /*
* Copyright ConsenSys AG.
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing... | 1 | 22,188 | DataHash shouldn't be needed here | hyperledger-besu | java |
@@ -110,7 +110,7 @@ public class WebDriverBackedSeleniumHandler implements Routable {
StringBuilder printableArgs = new StringBuilder("[");
Joiner.on(", ").appendTo(printableArgs, args);
printableArgs.append("]");
- LOG.info(String.format("Command request: %s%s on session %s", cmd, printableArgs, sess... | 1 | // Licensed to the Software Freedom Conservancy (SFC) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The SFC licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you m... | 1 | 17,121 | `info` was chosen deliberately to mirror the old behaviour that users expected. | SeleniumHQ-selenium | rb |
@@ -31,8 +31,8 @@ describeComponent(
component._selectize.setValue(['item 3', 'item 2']);
});
- expect(component.get('value'), 'component value').to.deep.equal(['item 3', 'item 2']);
- expect(component.get('selection'), 'component selection').to.deep.equal(['item 3'... | 1 | /* jshint expr:true */
import { expect } from 'chai';
import {
describeComponent,
it
} from 'ember-mocha';
import {A as emberA} from 'ember-array/utils';
import run from 'ember-runloop';
describeComponent(
'gh-selectize',
'Unit: Component: gh-selectize',
{
// Specify the other units that ar... | 1 | 7,398 | For some reason, Safari handles ember arrays differently than Chrome/Firefox. To get around that, we cast the ember array to a regular array to verify the deep equal. (Note: I tried wrapping the expected value in an emberA - which would look like `expect(someEmberArray).to.deep.equal(emberA(['a', 'b']));` but that didn... | TryGhost-Admin | js |
@@ -36,6 +36,7 @@ public class VectorHolder {
private final Dictionary dictionary;
private final NullabilityHolder nullabilityHolder;
private final Type icebergType;
+ private final Type originalIcebergType;
public VectorHolder(
ColumnDescriptor columnDescriptor, FieldVector vector, boolean isDict... | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you ... | 1 | 42,993 | `icebergType` indicates the corresponding iceberg type of the `FieldVector` `originalIcebergType` indicates what the real type we will read from the `FieldVector`. For example, the parquet int backed decimal, the `icebergType` should be integer, `originalIcebergType` is decimal. I intend to only keep the `originalIcebe... | apache-iceberg | java |
@@ -43,7 +43,7 @@
// - Reader: *storage.Reader
// - Attributes: storage.ObjectAttrs
// - CopyOptions.BeforeCopy: *storage.Copier
-// - WriterOptions.BeforeWrite: *storage.Writer
+// - WriterOptions.BeforeWrite: **storage.ObjectHandle, *storage.Writer
package gcsblob // import "gocloud.dev/blob/gcsblob"
impo... | 1 | // Copyright 2018 The Go Cloud Development Kit Authors
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// https://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by appli... | 1 | 17,073 | The double (and thus triple as seen below) pointer gives me pause. I could imagine providing some larger API surface to smooth it out, but it's likely not worth it. | google-go-cloud | go |
@@ -1011,13 +1011,13 @@ describe('document', function() {
});
describe('Errors', function() {
- it('MongooseErrors should be instances of Error (gh-209)', function(done) {
+ it('MongooseError should be instances of Error (gh-209)', function(done) {
const MongooseError = require('../lib/error');
... | 1 | 'use strict';
/**
* Module dependencies.
*/
const Document = require('../lib/document');
const EventEmitter = require('events').EventEmitter;
const EmbeddedDocument = require('../lib/types/embedded');
const Query = require('../lib/query');
const _ = require('lodash');
const assert = require('assert');
const co = re... | 1 | 13,988 | The test name as written was grammatically correct, but now it isn't. Both 'MongooseError' and 'instance' should be both singular or both plural. | Automattic-mongoose | js |
@@ -125,8 +125,8 @@ public class SmartStoreInspectorActivity extends Activity {
private void readExtras() {
Bundle bundle = getIntent().getExtras();
- isGlobal = bundle.getBoolean(IS_GLOBAL_STORE, false);
- dbName = bundle.getString(DB_NAME, DBOpenHelper.DEFAULT_DB_NAME);
+ isGlobal = bundle == null ? false :... | 1 | /*
* Copyright (c) 2014, salesforce.com, inc.
* All rights reserved.
* Redistribution and use of this software in source and binary forms, with or
* without modification, are permitted provided that the following conditions
* are met:
* - Redistributions of source code must retain the above copyright notice, this... | 1 | 14,765 | SmartStoreInspectorTest was throwing a NPE here | forcedotcom-SalesforceMobileSDK-Android | java |
@@ -134,9 +134,13 @@ public abstract class DeleteFilter<T> {
Iterable<CloseableIterable<Record>> deleteRecords = Iterables.transform(deletes,
delete -> openDeletes(delete, deleteSchema));
- StructLikeSet deleteSet = Deletes.toEqualitySet(
- // copy the delete records because they will ... | 1 | /*
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you ... | 1 | 42,111 | We prefer line wrapping that keeps arguments to the same method aligned rather than aligning arguments to different levels. Here, the lambda to create an `InternalRecordWrapper` is an argument to `transform`, but it is aligned with `deleteSchema.asStruct()` that is an argument to the outer `toEqualitySet` call. Instead... | apache-iceberg | java |
@@ -173,6 +173,10 @@ import ServerConnections from '../ServerConnections';
value: session.TranscodingInfo.TranscodeReasons.map(translateReason).join('<br/>')
});
}
+ sessionStats.push({
+ label: globalize.translate('LabelHardwareEncoding'),
+ ... | 1 | import { Events } from 'jellyfin-apiclient';
import '../../elements/emby-button/paper-icon-button-light';
import globalize from '../../scripts/globalize';
import layoutManager from '../layoutManager';
import { playbackManager } from '../playback/playbackmanager';
import playMethodHelper from '../playback/playmethodhelp... | 1 | 19,345 | I think it would be a good idea to wrap this in an if like the stats above, just in case. | jellyfin-jellyfin-web | js |
@@ -289,6 +289,9 @@ public class LFMainActivity extends SharedMediaActivity {
mediaAdapter.notifyItemChanged(toggleSelectPhoto(m));
editMode = true;
}
+ else {
+ selectAllPhotosUpToFav(getImagePosition(m.getPath()));
+ ... | 1 | package org.fossasia.phimpme.gallery.activities;
import android.animation.Animator;
import android.annotation.TargetApi;
import android.content.ContentResolver;
import android.content.ContentUris;
import android.content.Context;
import android.content.DialogInterface;
import android.content.Intent;
import android.con... | 1 | 12,801 | @angmas1 just make one more change here too. Move the else line to the line above it, where the if block ends and remove the braces like in line 280. | fossasia-phimpme-android | java |
@@ -21,7 +21,7 @@ func (s *BlkioGroup) Name() string {
}
func (s *BlkioGroup) Apply(path string, d *cgroupData) error {
- return join(path, d.pid)
+ return apply(path, d.pid)
}
func (s *BlkioGroup) Set(path string, r *configs.Resources) error { | 1 | package fs
import (
"bufio"
"os"
"path/filepath"
"strconv"
"strings"
"github.com/opencontainers/runc/libcontainer/cgroups"
"github.com/opencontainers/runc/libcontainer/configs"
)
type BlkioGroup struct {
weightFilename string
weightDeviceFilename string
}
func (s *BlkioGroup) Name() string {
return ... | 1 | 24,849 | Looks like the actual rename is missing in this commit edit: Arf, nevermind, I was at the wrong commit | opencontainers-runc | go |
@@ -67,7 +67,9 @@ module.exports = class Transloadit extends Plugin {
this._onRestored = this._onRestored.bind(this)
this._getPersistentData = this._getPersistentData.bind(this)
- if (this.opts.params) {
+ if (this.opts.params ||
+ // No params _and_ no custom getAssemblyOptions is an early err... | 1 | const Translator = require('@uppy/utils/lib/Translator')
const { Plugin } = require('@uppy/core')
const Tus = require('@uppy/tus')
const Assembly = require('./Assembly')
const Client = require('./Client')
const AssemblyOptions = require('./AssemblyOptions')
const AssemblyWatcher = require('./AssemblyWatcher')
function... | 1 | 11,203 | I'm a little stuck understanding, how would this result in an error when `this.opts.params` is not set? It will just not do `AssemblyOptions.validateParams(this.opts.params)` | transloadit-uppy | js |
@@ -20,6 +20,15 @@ import (
"github.com/GoogleCloudPlatform/compute-image-tools/daisy"
)
+var (
+ // These patterns match a key of "Vars" in a daisy workflow. All CLI tools use these variables.
+ //
+ // For network and subnet, some workflows use the prefix `import_`.
+ networkPattern = regexp.MustCo... | 1 | // Copyright 2021 Google Inc. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by appl... | 1 | 14,008 | networkVarPattern (etc) then? | GoogleCloudPlatform-compute-image-tools | go |
@@ -138,8 +138,10 @@ module RSpec
# don't clone the example group because the new example
# must belong to the same example group (not a clone).
+ #
+ # block is nil in new_metadata so we have to get it from metadata.
Example.new(example_group, description.clone,
- ... | 1 | module RSpec
module Core
# Wrapper for an instance of a subclass of {ExampleGroup}. An instance of
# `RSpec::Core::Example` is returned by example definition methods
# such as {ExampleGroup.it it} and is yielded to the {ExampleGroup.it it},
# {Hooks#before before}, {Hooks#after after}, {Hooks#around a... | 1 | 16,279 | I think it makes sense to do `metadata[:block].clone`, as thats what `new_metadata` is, but somehow it's missing the block from its clone. | rspec-rspec-core | rb |
@@ -51,10 +51,12 @@ class ClosureAnalyzer extends FunctionLikeAnalyzer
*/
public function getClosureId(): string
{
- return strtolower($this->getFilePath())
- . ':' . $this->function->getLine()
- . ':' . (int)$this->function->getAttribute('startFilePos')
- . ':-:c... | 1 | <?php
namespace Psalm\Internal\Analyzer;
use PhpParser;
use Psalm\CodeLocation;
use Psalm\Context;
use Psalm\Issue\DuplicateParam;
use Psalm\Issue\PossiblyUndefinedVariable;
use Psalm\Issue\UndefinedVariable;
use Psalm\IssueBuffer;
use Psalm\Internal\DataFlow\DataFlowNode;
use Psalm\Type;
use Psalm\Type\Atomic\TNamedO... | 1 | 10,254 | Just realized this should be fixed instead of changing here. Concatenating int should still result in lowercase string. | vimeo-psalm | php |
@@ -79,7 +79,7 @@ module Selenium
opts[:browser_version] = opts.delete(:version) if opts.key?(:version)
opts[:platform_name] = opts.delete(:platform) if opts.key?(:platform)
- new({browser_name: 'firefox'}.merge(opts))
+ new({browser_name: 'firefox', marionette: true}.m... | 1 | # encoding: utf-8
#
# Licensed to the Software Freedom Conservancy (SFC) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The SFC licenses this file
# to you under the Apache License, Version 2.0 (the
# "Li... | 1 | 13,902 | For Se 3.x we shouldn't need to specify `marionette: true`? I'll see if I can figure out where this is getting used that it might be necessary here. | SeleniumHQ-selenium | py |
@@ -34,14 +34,14 @@ func initStoreTest(ctx context.Context, t *testing.T, dstP *DefaultSyncerTestPar
requireSetTestChain(t, con, true, dstP)
}
-func newChainStore(dstP *DefaultSyncerTestParams) chain.Store {
+func newChainStore(dstP *DefaultSyncerTestParams) *chain.DefaultStore {
r := repo.NewInMemoryRepo()
ds... | 1 | package chain_test
import (
"context"
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"github.com/ipfs/go-cid"
"github.com/ipfs/go-hamt-ipld"
bstore "github.com/ipfs/go-ipfs-blockstore"
"github.com/filecoin-project/go-filecoin/chain"
"github.com/filecoin-project/go-file... | 1 | 19,358 | This should be renamed to `chain.Store`. It was named `DefaultStore` as an alternative to `StoreImpl`, which is the (bad) Java convention. | filecoin-project-venus | go |
@@ -85,8 +85,12 @@ func (a *AttachDisks) validate(ctx context.Context, s *Step) (errs DError) {
ad.zone = disk["zone"]
// Register disk attachments.
- errs = addErrs(errs, s.w.instances.w.disks.regAttach(ad.Source, ad.Instance, ad.Mode, s))
-
+ // If device name is not given explicitly, its device name will b... | 1 | // Copyright 2017 Google Inc. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by appl... | 1 | 11,524 | ad.Source is disk name? Shouldn't the order of initialization be reversed here then? First set ad.DeviceName, if it's empty, set ad.Source? Or this is a different use case? This is the third place where this device/disk default logic is implemented, so another reason to move it to regAttach, if it's possible to be gene... | GoogleCloudPlatform-compute-image-tools | go |
@@ -26,6 +26,11 @@ namespace Microsoft.DotNet.Build.Tasks.Feed
[Output]
public ITaskItem[] PackageInfos { get; set; }
+ /// <summary>
+ /// Specify max number of minutes that the lock of the feed container will be hold.
+ /// </summary>
+ public int FeedLockTimeoutMinutes... | 1 | // Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.
// See the LICENSE file in the project root for more information.
using Microsoft.Build.Framework;
using NuGet.Packaging.Core;
using System;
using System.Collections.Generic;
using S... | 1 | 15,346 | typo: "be hold" -> "be held" | dotnet-buildtools | .cs |
@@ -44,10 +44,10 @@ namespace Nethermind.Blockchain.Receipts
public long? LowestInsertedReceiptBlockNumber
{
- get => long.MaxValue;
+ get => 1;
set { }
}
public long MigratedBlockNumber { get; set; } = 0;
}
-}
+} | 1 | // Copyright (c) 2018 Demerzel Solutions Limited
// This file is part of the Nethermind library.
//
// The Nethermind library is free software: you can redistribute it and/or modify
// it under the terms of the GNU Lesser General Public License as published by
// the Free Software Foundation, either version 3 of ... | 1 | 24,722 | I do not think we should have any logic inside the null storage. 1 has a very specific magical meaning. We should either return null here or long.maxValue. | NethermindEth-nethermind | .cs |
@@ -397,7 +397,7 @@ func TestInitProcessEnabled(t *testing.T) {
}
agent := RunAgent(t, nil)
defer agent.Cleanup()
- agent.RequireVersion(">=1.14.5")
+ agent.RequireVersion(">=1.15.0")
td, err := GetTaskDefinition("init-process")
if err != nil { | 1 | // +build functional,!windows
// Copyright 2014-2016 Amazon.com, Inc. or its affiliates. All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License"). You may
// not use this file except in compliance with the License. A copy of the
// License is located at
//
// http://aws.amazon.com/apac... | 1 | 18,463 | Why did this change? | aws-amazon-ecs-agent | go |
@@ -168,7 +168,6 @@ class PlansController < ApplicationController
render('/phases/edit', locals: {
base_template_org: phase.template.base_org,
plan: plan, phase: phase, readonly: readonly,
- question_guidance: plan.guidance_by_question_as_hash,
guidance_groups: guidance_groups,
ans... | 1 | require 'pp'
class PlansController < ApplicationController
include ConditionalUserMailer
helper PaginableHelper
helper SettingsTemplateHelper
include FeedbacksHelper
after_action :verify_authorized, except: [:overview]
def index
authorize Plan
@plans = Plan.active(current_user).page(1)
@organi... | 1 | 17,916 | Removed this method. Doesn't seem to be used in the code, and the variable set here doesn't seem to be used in the views. | DMPRoadmap-roadmap | rb |
@@ -16,7 +16,12 @@ namespace Microsoft.CodeAnalysis.Sarif
{
internal const string DEFAULT_POLICY_NAME = "default";
- public PropertyBagDictionary() : base() { }
+ public PropertyBagDictionary() : this(null) { }
+
+ public PropertyBagDictionary(PropertyBagDictionary initializer) :
+ ... | 1 | // Copyright (c) Microsoft. All rights reserved.
// Licensed under the MIT license. See LICENSE file in the project root for full license information.
using System;
using System.Collections.Generic;
using System.Collections.Immutable;
using System.ComponentModel;
using System.IO;
using System.Runtime.Serialization;
u... | 1 | 11,058 | Remove the initializers ("`= null`") from both parameters. Remember that that's why we added the overloads: to ensure that all languages could have the convenience of the abbreviated argument lists (not all languages understand default parameters). | microsoft-sarif-sdk | .cs |
@@ -0,0 +1,13 @@
+package values
+
+import (
+ "github.com/influxdata/flux/semantic"
+)
+
+type Vector interface {
+ Value
+ ElementType() semantic.MonoType
+ Get(i int) Value
+ Set(i int, value Value)
+ Len() int
+} | 1 | 1 | 17,607 | I think you can just remove most of these attributes outside of `ElementType()`. Instead, this should expose the arrow array. We're not going to use these methods anyway. | influxdata-flux | go | |
@@ -5,8 +5,7 @@ import { enqueueRender } from '../render-queue';
import { getNodeProps } from './index';
import { diff, mounts, diffLevel, flushMounts, recollectNodeTree, removeChildren } from './diff';
import { createComponent, collectComponent } from './component-recycler';
-
-
+import remove from './remove';
/... | 1 | import { SYNC_RENDER, NO_RENDER, FORCE_RENDER, ASYNC_RENDER, ATTR_KEY } from '../constants';
import options from '../options';
import { extend } from '../util';
import { enqueueRender } from '../render-queue';
import { getNodeProps } from './index';
import { diff, mounts, diffLevel, flushMounts, recollectNodeTree, remo... | 1 | 10,735 | Thinking this should be `removeNode()` exported from `dom/index.js`. Thoughts? | preactjs-preact | js |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.