patch
stringlengths
17
31.2k
y
int64
1
1
oldf
stringlengths
0
2.21M
idx
int64
1
1
id
int64
4.29k
68.4k
msg
stringlengths
8
843
proj
stringclasses
212 values
lang
stringclasses
9 values
@@ -0,0 +1,15 @@ +import re +import logging +from localstack.utils.common import to_str, to_bytes +from localstack.services.generic_proxy import ProxyListener +from moto.elbv2 import urls + +LOG = logging.getLogger(__name__) + + +class ProxyListenerELBV2(ProxyListener): + pass + + +# # instantiate listener +UPDATE_E...
1
1
12,106
As we're currently not applying any logic in the proxy listener, I guess we can simply remove this file (and remove the `listener` argument from the `register_plugin(..)` call above).
localstack-localstack
py
@@ -86,6 +86,7 @@ func (w *DefaultWorker) Generate(ctx context.Context, Proof: proof, StateRoot: newStateTreeCid, Ticket: ticket, + Timestamp: types.Uint64(time.Now().Unix()), } for i, msg := range res.PermanentFailures {
1
package mining // Block generation is part of the logic of the DefaultWorker. // 'generate' is that function that actually creates a new block from a base // TipSet using the DefaultWorker's many utilities. import ( "context" "time" "github.com/pkg/errors" "github.com/filecoin-project/go-filecoin/types" "githu...
1
19,642
Isn't the point of the clock module to encapsulate access to `time.Now()`? Coming later?
filecoin-project-venus
go
@@ -117,6 +117,10 @@ func generateFastUpgradeConsensus() (fastUpgradeProtocols config.ConsensusProtoc } fastUpgradeProtocols[consensusTestFastUpgrade(proto)] = fastParams + + // support the ALGOSMALLLAMBDAMSEC = 500 env variable + fastParams.AgreementFilterTimeout = time.Second + fastParams.AgreementFilterTi...
1
// Copyright (C) 2019-2020 Algorand, Inc. // This file is part of go-algorand // // go-algorand is free software: you can redistribute it and/or modify // it under the terms of the GNU Affero General Public License as // published by the Free Software Foundation, either version 3 of the // License, or (at your option) ...
1
40,226
as before - if you've set this, you should be able to get rid of the `os.Setenv("ALGOSMALLLAMBDAMSEC", "500")`. make sure that the various tests still takes have the same execution time.
algorand-go-algorand
go
@@ -450,8 +450,8 @@ module Travis mactex = 'BasicTeX.pkg' # TODO(craigcitro): Confirm that this will route us to the # nearest mirror. - sh.cmd 'wget http://mirror.ctan.org/systems/mac/mactex/'\ - "#{mactex} -O \"/tmp/#{mactex}\"" + sh.cmd '...
1
# Maintained by: # Jim Hester @jimhester james.hester@rstudio.com # Craig Citro @craigcitro craigcitro@google.com # module Travis module Build class Script class R < Script DEFAULTS = { # Basic config options cran: 'https://cloud.r-project.org', repos:...
1
15,558
Pretty sure the single quotes here should be double quotes, single quotes are not expanded by the shell.
travis-ci-travis-build
rb
@@ -109,8 +109,11 @@ public final class ValidateConstantMessageTests { " void f(boolean bArg, int iArg, Object oArg, Integer[] arrayArg, " + "Collection<String> collectionArg, Map<String, String> mapArg, String stringArg, " + "Iterable<...
1
/* * Copyright 2017 Palantir Technologies, Inc. All rights reserved. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless req...
1
6,152
these are not really constants, right?
palantir-gradle-baseline
java
@@ -1,3 +1,4 @@ +from boto.compat import six # Copyright (c) 2012 Mitch Garnaat http://garnaat.org/ # Copyright (c) 2012 Amazon.com, Inc. or its affiliates. All Rights Reserved #
1
# Copyright (c) 2012 Mitch Garnaat http://garnaat.org/ # Copyright (c) 2012 Amazon.com, Inc. or its affiliates. All Rights Reserved # # Permission is hereby granted, free of charge, to any person obtaining a # copy of this software and associated documentation files (the # "Software"), to deal in the Software without ...
1
10,151
import below copyright statement
boto-boto
py
@@ -49,7 +49,7 @@ describe InvoiceNotifier do def customer_should_receive_receipt_email(invoice) email = ActionMailer::Base.deliveries.first - email.subject.should include('receipt') - email.to.should eq [invoice.user_email] + expect(email.subject).to include('receipt') + expect(email.to).to eq [i...
1
require 'spec_helper' describe InvoiceNotifier do describe '#send_receipt' do context 'invoice has a user' do it 'sends a receipt to the person who was charged' do ActionMailer::Base.deliveries.clear payment_processor = InvoiceNotifier.new(stub_invoice) payment_processor.send_recei...
1
9,672
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
thoughtbot-upcase
rb
@@ -200,11 +200,11 @@ class Field implements Translatable } /** - * @return string|Markup + * @return string|array|Markup */ public function getTwigValue() { - $value = $this->__toString(); + $value = $this->getFlattenedValue(); if ($this->getDefinition()->ge...
1
<?php declare(strict_types=1); namespace Bolt\Entity; use Bolt\Content\FieldType; use Doctrine\ORM\Mapping as ORM; use Gedmo\Mapping\Annotation as Gedmo; use Symfony\Component\Serializer\Annotation\Groups; use Tightenco\Collect\Support\Collection as LaravelCollection; use Twig\Markup; /** * @ORM\Entity(repositoryC...
1
11,134
`if (is_string($value) && $this->getDefinition()->get('allow_html')) {`
bolt-core
php
@@ -133,7 +133,7 @@ namespace OpenTelemetry.Trace private void AddInternal(string key, object value) { - Guard.Null(key, nameof(key)); + Debug.Assert(key != null, $"{nameof(key)} must not be null"); this.Attributes[key] = value; }
1
// <copyright file="SpanAttributes.cs" company="OpenTelemetry Authors"> // Copyright The OpenTelemetry Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache....
1
22,254
I think we have the same problem here - if folks called the `public void Add` with a `null` key, we need to use `Guard`.
open-telemetry-opentelemetry-dotnet
.cs
@@ -0,0 +1,12 @@ +// +// Copyright (C) 2020 Greg Landrum +// @@ All Rights Reserved @@ +// This file is part of the RDKit. +// The contents are covered by the terms of the BSD license +// which is included in the file license.txt, found at the root +// of the RDKit source tree. +// + +#define CATCH_CONFIG_MAIN ...
1
1
22,130
I thought that the main was in catch_qt.cpp?
rdkit-rdkit
cpp
@@ -87,7 +87,7 @@ public class ImagesManageActivity extends BaseActivity { private static final int REQUEST_UNSELECT_IMAGE_AFTER_LOGIN = 4; public static final int REQUEST_EDIT_IMAGE = 1000; private static final int REQUEST_CHOOSE_IMAGE = 1001; - private static final List<ProductImageField> TYPE_IMAGE...
1
/* * Copyright 2016-2020 Open Food Facts * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * https://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agre...
1
68,386
I would rename the field to IMAGE_TYPES and make it an array. I don't think we need list operations. Also, if possible, I would move the field to the ApiFields class. What do you think?
openfoodfacts-openfoodfacts-androidapp
java
@@ -117,6 +117,17 @@ func verifyContainerRunningStateChangeWithRuntimeID(t *testing.T, taskEngine Tas "Expected container runtimeID should not empty") } +func verifyExecAgentRunningStateChange(t *testing.T, taskEngine TaskEngine) { + stateChangeEvents := taskEngine.StateChangeEvents() + event := <-stateChangeEven...
1
// +build sudo integration // Copyright Amazon.com Inc. or its affiliates. All Rights Reserved. // // Licensed under the Apache License, Version 2.0 (the "License"). You may // not use this file except in compliance with the License. A copy of the // License is located at // // http://aws.amazon.com/apache2.0/ // // o...
1
25,471
I'd prefer to timeout on this, but I know it's not a pattern that is being followed
aws-amazon-ecs-agent
go
@@ -37,10 +37,7 @@ import org.apache.lucene.store.BufferedChecksumIndexInput; import org.apache.lucene.store.ChecksumIndexInput; import org.apache.lucene.store.IOContext; import org.apache.lucene.store.IndexInput; -import org.apache.lucene.util.BytesRef; -import org.apache.lucene.util.BytesRefBuilder; -import org.ap...
1
/* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may ...
1
40,671
hmm let's not use * imports please
apache-lucene-solr
java
@@ -497,6 +497,10 @@ func generateAlertmanagerConfig(version semver.Version, am v1.AlertmanagerEndpoi cfg = append(cfg, k8sSDWithNamespaces([]string{am.Namespace})) } + if am.BearerTokenFile != "" { + cfg = append(cfg, yaml.MapItem{Key: "bearer_token_file", Value: am.BearerTokenFile}) + } + var relabelings []...
1
// Copyright 2016 The prometheus-operator Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable ...
1
9,896
is this configuration key already exist in prometheus ?
prometheus-operator-prometheus-operator
go
@@ -2,6 +2,7 @@ require "test_helper" class DiaryEntryControllerTest < ActionController::TestCase include ActionView::Helpers::NumberHelper + api_fixtures def setup # Create the default language for diary entries
1
require "test_helper" class DiaryEntryControllerTest < ActionController::TestCase include ActionView::Helpers::NumberHelper def setup # Create the default language for diary entries create(:language, :code => "en") # Stub nominatim response for diary entry locations stub_request(:get, %r{^http://n...
1
10,675
As @gravitystorm said new tests need to be using factories, not fixtures.
openstreetmap-openstreetmap-website
rb
@@ -171,8 +171,8 @@ bool CliManager::readLine(std::string &line, bool linebreak) { if (!isInteractive_) { break; } - auto purePrompt = folly::stringPrintf("(%s@%s:%d) [%s]> ", - username_.c_str(), addr_.c_str(), port_, + auto pure...
1
/* Copyright (c) 2018 vesoft inc. All rights reserved. * * This source code is licensed under Apache 2.0 License, * attached with Common Clause Condition 1.0, found in the LICENSES directory. */ #include "base/Base.h" #include "base/Status.h" #include <termios.h> #include <unistd.h> #include "readline/readline.h" ...
1
28,362
You can replace IP by hostname.
vesoft-inc-nebula
cpp
@@ -123,13 +123,14 @@ def getDriversForConnectedUsbDevices(): for port in deviceInfoFetcher.comPorts if "usbID" in port) ) for match in usbDevs: - # check for the Braille HID protocol before any other device matching. - if match.type == KEY_HID and match.deviceInfo.get('HIDUsagePage') == HID_USAGE_PAGE_BRAILL...
1
#bdDetect.py #A part of NonVisual Desktop Access (NVDA) #This file is covered by the GNU General Public License. #See the file COPYING for more details. #Copyright (C) 2013-2017 NV Access Limited """Support for braille display detection. This allows devices to be automatically detected and used when they become...
1
34,656
This should say "why" NVDA should do things in this order.
nvaccess-nvda
py
@@ -114,7 +114,7 @@ func TestPopulateLocationConstraint(t *testing.T) { func TestNoPopulateLocationConstraintIfProvided(t *testing.T) { s := s3.New(unit.Session) req, _ := s.CreateBucketRequest(&s3.CreateBucketInput{ - Bucket: aws.String("bucket"), + Bucket: aws.String("bucket"), CreateBuck...
1
package s3_test import ( "bytes" "io/ioutil" "net/http" "testing" "github.com/aws/aws-sdk-go/aws" "github.com/aws/aws-sdk-go/aws/awsutil" "github.com/aws/aws-sdk-go/aws/request" "github.com/aws/aws-sdk-go/awstesting/unit" "github.com/aws/aws-sdk-go/service/s3" ) var s3LocationTests = []struct { body string...
1
9,370
nit these will get changed back during next release.
aws-aws-sdk-go
go
@@ -0,0 +1,8 @@ +// Copyright 2021 The Swarm Authors. All rights reserved. +// Use of this source code is governed by a BSD-style +// license that can be found in the LICENSE file. + +package api + +// Version is set in the build process. +var Version string
1
1
15,911
it is actually not needed to make the member public. the build tags can also set a package scoped variable.
ethersphere-bee
go
@@ -38,6 +38,7 @@ trait ContentExtrasTrait 'excerpt' => $this->contentExtension->getExcerpt($content), 'link' => $this->contentExtension->getLink($content), 'editLink' => $this->contentExtension->getEditLink($content), + 'icon' => $this->contentExtension->getIcon($conte...
1
<?php declare(strict_types=1); namespace Bolt\Entity; use Bolt\Twig\ContentExtension; use Symfony\Component\Serializer\Annotation\Groups; /** * @see \Bolt\Entity\Content */ trait ContentExtrasTrait { /** * @var ContentExtension */ private $contentExtension; public function setContentExtensi...
1
11,751
We already have a method for it 'icon' => $content->getIcon()
bolt-core
php
@@ -9,6 +9,7 @@ import ( "github.com/aws/aws-sdk-go/service/kms" "github.com/aws/aws-sdk-go/service/s3" "github.com/aws/aws-sdk-go/service/s3/s3iface" + "golang.org/x/net/context" ) // WrapEntry is builder that return a proper key decrypter and error
1
package s3crypto import ( "strings" "github.com/aws/aws-sdk-go/aws" "github.com/aws/aws-sdk-go/aws/client" "github.com/aws/aws-sdk-go/aws/request" "github.com/aws/aws-sdk-go/service/kms" "github.com/aws/aws-sdk-go/service/s3" "github.com/aws/aws-sdk-go/service/s3/s3iface" ) // WrapEntry is builder that return...
1
9,855
Instead of importing `golang.org/x/net/context` The SDK should use `aws.BackgroundContext()` instead of `context.Background()`
aws-aws-sdk-go
go
@@ -38,7 +38,7 @@ class MediaController extends Controller */ public function getMedia($id) { - return $this->get('sonata.media.manager.media')->findOneBy(array('id' => $id)); + return $this->get('sonata.media.manager.media')->find($id); } /**
1
<?php /* * This file is part of the Sonata package. * * (c) Thomas Rabaix <thomas.rabaix@sonata-project.org> * * For the full copyright and license information, please view the LICENSE * file that was distributed with this source code. */ namespace Sonata\MediaBundle\Controller; use Symfony\Bundle\FrameworkBu...
1
6,381
I think this is an agnostic change for the ORM right? Why was it doing this? - this does not work on PHPCR-ODM as the `id` is not a field - although I guess it could be mapped as such.
sonata-project-SonataMediaBundle
php
@@ -73,7 +73,7 @@ class ApplicationController < ActionController::Base helper_method :included_in_current_users_plan? def topics - Topic.top + Topic.all end helper_method :topics
1
class ApplicationController < ActionController::Base include Clearance::Controller helper :all protect_from_forgery with: :exception before_filter :capture_campaign_params protected def must_be_admin unless current_user_is_admin? flash[:error] = 'You do not have permission to view that page.'...
1
14,216
I'm not 100% sure, but I think this should be `explorable`. If not, I think `explorable` can be removed entirely.
thoughtbot-upcase
rb
@@ -124,15 +124,13 @@ class MockTarget(target.FileSystemTarget): self.wrapper = wrapper def write(self, data): - if six.PY3: - stderrbytes = sys.stderr.buffer - else: - stderrbytes = sys.stderr - if mock...
1
# -*- coding: utf-8 -*- # # Copyright 2012-2015 Spotify AB # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law...
1
14,809
Note to self: Why was this not originally not using `stderrbytes`?
spotify-luigi
py
@@ -364,6 +364,14 @@ bool FileUtils::exist(const std::string& path) { return access(path.c_str(), F_OK) == 0; } +// static +bool FileUtils::rename(const std::string& src, const std::string& dst) { + auto status = ::rename(src.c_str(), dst.c_str()); + LOG_IF(WARNING, status < 0) << "Rename " << src << " to...
1
/* Copyright (c) 2018 vesoft inc. All rights reserved. * * This source code is licensed under Apache 2.0 License, * attached with Common Clause Condition 1.0, found in the LICENSES directory. */ #include "base/Base.h" #include "fs/FileUtils.h" #include <dirent.h> #include <fnmatch.h> #include <limits.h> #include <...
1
25,618
Is betterLOG_IF(ERROR, status != 0) ?
vesoft-inc-nebula
cpp
@@ -38,6 +38,9 @@ class BaseLoadTest(TestCase): self.session.auth = self.auth self.session.headers.update({'Content-Type': 'application/json'}) + self.bucket = 'default' + self.collection = 'default' + # Keep track of created objects. self._collections_created = {}
1
import json import os import uuid from requests.auth import HTTPBasicAuth, AuthBase from loads.case import TestCase from konfig import Config class RawAuth(AuthBase): def __init__(self, authorization): self.authorization = authorization def __call__(self, r): r.headers['Authorization'] = sel...
1
8,057
I wouldn't call it default too.
Kinto-kinto
py
@@ -2,6 +2,7 @@ * and will be replaced soon by a Vue component. */ +/* eslint-disable no-var */ import browser from 'browser'; import dom from 'dom'; import 'css!./navdrawer';
1
/* Cleaning this file properly is not neecessary, since it's an outdated library * and will be replaced soon by a Vue component. */ import browser from 'browser'; import dom from 'dom'; import 'css!./navdrawer'; import 'scrollStyles'; export default function (options) { function getTouches(e) { return e...
1
17,726
Why disable the rule for this file?
jellyfin-jellyfin-web
js
@@ -76,6 +76,7 @@ CTA.propTypes = { 'aria-label': PropTypes.string, error: PropTypes.bool, onClick: PropTypes.func, + ctaLinkExternal: PropTypes.bool, }; CTA.defaultProps = {
1
/** * CTA component. * * Site Kit by Google, Copyright 2021 Google LLC * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * https://www.apache.org/licenses/LICENSE-2.0 * * Unles...
1
42,186
Thanks for adding this :+1:. Could you please move it to go after the `ctaLink` prop?
google-site-kit-wp
js
@@ -193,7 +193,7 @@ namespace Nethermind.Core.Collections public T Current => _array[_index]; - object IEnumerator.Current => Current; + object IEnumerator.Current => Current!; public void Dispose() { } }
1
// Copyright (c) 2021 Demerzel Solutions Limited // This file is part of the Nethermind library. // // The Nethermind library is free software: you can redistribute it and/or modify // it under the terms of the GNU Lesser General Public License as published by // the Free Software Foundation, either version 3 of ...
1
26,301
The other way around Current can be null.
NethermindEth-nethermind
.cs
@@ -230,7 +230,8 @@ class SideMenuBuilder $communicationMenu = $menu->addChild('communication', ['label' => t('Communication with customer')]); $communicationMenu->addChild('mail_settings', ['route' => 'admin_mail_setting', 'label' => t('Email settings')]); - $communicationMenu->addChild('mai...
1
<?php namespace Shopsys\FrameworkBundle\Model\AdminNavigation; use Knp\Menu\FactoryInterface; use Knp\Menu\ItemInterface; use Shopsys\FrameworkBundle\Component\Domain\Domain; use Shopsys\FrameworkBundle\Model\Security\Roles; use Symfony\Component\EventDispatcher\EventDispatcherInterface; use Symfony\Component\Securit...
1
22,304
why does it have to be here? Due to breadcrumb navigation?
shopsys-shopsys
php
@@ -21,10 +21,18 @@ import ( apis "github.com/openebs/maya/pkg/apis/openebs.io/v1alpha1" "github.com/openebs/maya/pkg/util" + "k8s.io/apimachinery/pkg/api/resource" v1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/apimachinery/pkg/types" ) +//TODO: Move to some common function +func StrToQuantity(capacity...
1
// Copyright © 2017-2019 The OpenEBS Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law o...
1
17,092
I fear moving this to some common func. We are swallowing the error here. This might be ok in UT but not in actual source code.
openebs-maya
go
@@ -716,12 +716,9 @@ class TestMessagesStore(object): with pytest.raises(InvalidMessageError) as cm: store.add_renamed_message( 'W1234', 'old-msg-symbol', 'duplicate-keyword-arg') - assert str(cm.value) == "Message id 'W1234' is already defined" - # conflicting messa...
1
# -*- coding: utf-8 -*- # Copyright (c) 2006-2014 LOGILAB S.A. (Paris, FRANCE) <contact@logilab.fr> # Copyright (c) 2009 Charles Hebert <charles.hebert@logilab.fr> # Copyright (c) 2011-2014 Google, Inc. # Copyright (c) 2012 Kevin Jing Qiu <kevin.jing.qiu@gmail.com> # Copyright (c) 2012 Anthony VEREZ <anthony.verez.exte...
1
10,171
Please don't use \ as a line continuation. Do an implicit string join instead with parens: ``` ("Message ..." "and ...")
PyCQA-pylint
py
@@ -258,7 +258,6 @@ func NewBee(addr string, swarmAddress swarm.Address, publicKey ecdsa.PublicKey, return nil, fmt.Errorf("localstore: %w", err) } b.localstoreCloser = storer - // register localstore unreserve function on the batchstore before batch service starts listening to blockchain events batchStore, ...
1
// Copyright 2020 The Swarm Authors. All rights reserved. // Use of this source code is governed by a BSD-style // license that can be found in the LICENSE file. package node import ( "context" "crypto/ecdsa" "errors" "fmt" "io" "log" "math/big" "net" "net/http" "path/filepath" "time" "github.com/ethereu...
1
14,095
there needs to be a change here. setting up the batchstore with localstore.Unreserve hook
ethersphere-bee
go
@@ -52,9 +52,15 @@ public final class ConfigUtil { private static final String MICROSERVICE_CONFIG_LOADER_KEY = "cse-microservice-config-loader"; + private static ConfigModel model = new ConfigModel(); + private ConfigUtil() { } + public static void setConfigs(Map<String, Object> config) { + model.s...
1
/* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may ...
1
9,200
I think if we can provide a more convenient method to add configs . e.g. public static void addConfig(String k, Object v)
apache-servicecomb-java-chassis
java
@@ -266,7 +266,7 @@ func TestActPool_AddActs(t *testing.T) { err = ap.AddTsf(overBalTsf) require.Equal(ErrBalance, errors.Cause(err)) // Case VI: over gas limit - creationExecution, err := action.NewExecution(addr1.RawAddress, action.EmptyAddress, uint64(5), big.NewInt(int64(0)), blockchain.GasLimit+100, big.NewI...
1
// Copyright (c) 2018 IoTeX // This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no // warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent // permitted by law, all liability for your use of the cod...
1
11,966
line is 165 characters
iotexproject-iotex-core
go
@@ -0,0 +1,8 @@ +package org.jkiss.dbeaver.ext.oceanbase.data; + +import org.jkiss.dbeaver.model.impl.jdbc.data.handlers.JDBCStandardValueHandlerProvider; + +public class OceanbaseValueHandlerProvider extends JDBCStandardValueHandlerProvider{ + + +}
1
1
11,205
Please add a copyright notice. Also, could you tell me please why do we need this empty provider here?
dbeaver-dbeaver
java
@@ -95,8 +95,11 @@ public class EeaSendRawTransaction implements JsonRpcMethod { maybePrivacyGroup = privacyController.retrieveOnChainPrivacyGroup( maybePrivacyGroupId.get(), enclavePublicKey); - if (maybePrivacyGroup.isEmpty() - && !privacyController.isGroupAddi...
1
/* * Copyright ConsenSys AG. * * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with * the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing...
1
23,257
I feel like this would be easier to read if we join the two if's together: `if (maybePrivacyGroup.isEmpty() && !privacyController.isGroupAdditionTransaction(privateTransaction))`
hyperledger-besu
java
@@ -567,7 +567,7 @@ public class DBOpenHelper extends SQLiteOpenHelper { try { result = new JSONObject(loadSoupBlobAsString(soupTableName, soupEntryId, passcode)); - } catch (JSONException ex) { + } catch (Exception ex) { Log.e("DBOpenHelper:loadSoupBlob", "Exception occurred while attempting to read ext...
1
/* * Copyright (c) 2014-2015, salesforce.com, inc. * All rights reserved. * Redistribution and use of this software in source and binary forms, with or * without modification, are permitted provided that the following conditions * are met: * - Redistributions of source code must retain the above copyright notice,...
1
15,553
Tests are failing because the exception type is NullPointException here if the soupBlob is deleted (so instead of a mal-format json, it's a null)
forcedotcom-SalesforceMobileSDK-Android
java
@@ -439,12 +439,8 @@ Blockly.Connection.prototype.isConnectionAllowed = function(candidate) { break; } case Blockly.OUTPUT_VALUE: { - // Don't offer to connect an already connected left (male) value plug to - // an available right (female) value plug. - if (candidate.targetConnection || ...
1
/** * @license * Visual Blocks Editor * * Copyright 2011 Google Inc. * https://developers.google.com/blockly/ * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apach...
1
7,848
Glad we fixed this as well. Blockly is going to be left as-is for this case, right?
LLK-scratch-blocks
js
@@ -36,9 +36,7 @@ import java.util.Locale; * This class represents a typical Salesforce object. * * @author bhariharan - * @deprecated Will be removed in Mobile SDK 7.0. */ -@Deprecated public class SalesforceObject { protected String objectType;
1
/* * Copyright (c) 2014-present, salesforce.com, inc. * All rights reserved. * Redistribution and use of this software in source and binary forms, with or * without modification, are permitted provided that the following conditions * are met: * - Redistributions of source code must retain the above copyright noti...
1
16,812
I had accidentally deprecated this class. This is meant to stick around. Only `SalesforceObjectType` goes away.
forcedotcom-SalesforceMobileSDK-Android
java
@@ -208,6 +208,7 @@ def rev_hex(s): def int_to_hex(i, length=1): assert isinstance(i, int) s = hex(i)[2:].rstrip('L') + s = s.lstrip('0x') s = "0"*(2*length - len(s)) + s return rev_hex(s)
1
# -*- coding: utf-8 -*- # # Electrum - lightweight Bitcoin client # Copyright (C) 2011 thomasv@gitorious # # Permission is hereby granted, free of charge, to any person # obtaining a copy of this software and associated documentation files # (the "Software"), to deal in the Software without restriction, # including wit...
1
12,283
`hex(i)[2:]` is trying to do the same thing above. what is `i` in your malformed case?
spesmilo-electrum
py
@@ -126,8 +126,8 @@ public class XML { } } - /** escapes character data in val */ - public final static void writeXML(Writer out, String tag, String val, Object... attrs) throws IOException { + /** escapes character data in val if shouldEscape is true*/ + public final static void writeXML(Writer out, Stri...
1
/* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may ...
1
27,508
I think this change is redundant; see the previously defined method "writeUnescapedXML".
apache-lucene-solr
java
@@ -0,0 +1,18 @@ +package types + +import cbor "gx/ipfs/QmRoARq3nkUb13HSKZGepCZSWe5GrVPwx7xURJGZ7KWv9V/go-ipld-cbor" + +func init() { + cbor.RegisterCborType(Commitments{}) +} + +// CommitmentLength is the length of a single commitment (in bytes). +const CommitmentLength = 32 + +// Commitments is a struct containing th...
1
1
15,793
Ah now I have at least some idea what these are for.
filecoin-project-venus
go
@@ -58,8 +58,8 @@ public class DataReader<T> implements DatumReader<T> { } @Override - public void setSchema(Schema fileSchema) { - this.fileSchema = Schema.applyAliases(fileSchema, readSchema); + public void setSchema(Schema schema) { + this.fileSchema = Schema.applyAliases(schema, readSchema); } ...
1
/* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you ...
1
13,501
I believe in previous PRs @mccheah frequently used `fileSchema` -> `newFileSchema` type of renames to avoid hiding fields in builders. Would it make sense to make it consistent?
apache-iceberg
java
@@ -62,9 +62,17 @@ func (manager *connectionManager) Connect(consumerID, providerID identity.Identi } }() + err = manager.startConnection(consumerID, providerID) + if err == utils.ErrRequestCancelled { + return ErrConnectionCancelled + } + return err +} + +func (manager *connectionManager) startConnection(consu...
1
package connection import ( "errors" log "github.com/cihub/seelog" "github.com/mysterium/node/communication" "github.com/mysterium/node/identity" "github.com/mysterium/node/openvpn" "github.com/mysterium/node/openvpn/middlewares/client/bytescount" "github.com/mysterium/node/server" "github.com/mysterium/node/s...
1
10,894
Do we really need separate error in manager if utils.ErrRequestCancelled is the only error which indicates cancelation ?
mysteriumnetwork-node
go
@@ -136,7 +136,7 @@ MODEL_PARAMS = { # Temporal Pooler implementation selector (see _getTPClass in # CLARegion.py). - 'temporalImp': 'cpp', + 'temporalImp': 'tm_cpp', # New Synapse formation count # NOTE: If None, use spNumActivePerInhArea
1
# ---------------------------------------------------------------------- # Numenta Platform for Intelligent Computing (NuPIC) # Copyright (C) 2013, Numenta, Inc. Unless you have an agreement # with Numenta, Inc., for a separate license for this software code, the # following terms and conditions apply: # # This progra...
1
21,191
Leave as `cpp` since that still gives better results.
numenta-nupic
py
@@ -27,7 +27,7 @@ import ( "sigs.k8s.io/controller-runtime/pkg/predicate" ) -func pausedPredicates(logger logr.Logger) predicate.Funcs { +func PausedPredicates(logger logr.Logger) predicate.Funcs { return predicate.Funcs{ UpdateFunc: func(e event.UpdateEvent) bool { return processIfUnpaused(logger.WithVal...
1
/* Copyright 2020 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, ...
1
16,852
temp change so the predicate can be used by the `exp` package
kubernetes-sigs-cluster-api-provider-aws
go
@@ -387,6 +387,11 @@ class KeyboardInputGesture(inputCore.InputGesture): # This could be for an event such as gyroscope movement, # so don't report it. return False + if self.vkCode in self.TOGGLE_KEYS: + # #5490: Dont report for keys that toggle on off. + # This is to avoid them from reported twice: o...
1
# -*- coding: UTF-8 -*- #keyboardHandler.py #A part of NonVisual Desktop Access (NVDA) #This file is covered by the GNU General Public License. #See the file COPYING for more details. #Copyright (C) 2006-2015 NV Access Limited, Peter Vágner, Aleksey Sadovoy """Keyboard support""" import time import re impo...
1
17,890
Just as a tiny clarification, this isn't affected in any way by "speak typed characters". That is, "caps lock on", etc. is always spoken, even if speak typed characters is off.
nvaccess-nvda
py
@@ -61,10 +61,11 @@ func (r *ReconcileHiveConfig) deployHive(hLog log.FieldLogger, h *resource.Helpe } hLog.Info("deployment applied (%s)", result) - // Deploy the desired ClusterImageSets representing installable releases of OpenShift. - // TODO: in future this should be pipelined somehow. applyAssets := []str...
1
/* Copyright 2018 The Kubernetes Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, ...
1
6,296
@dgoodwin Will it cause an issue when the issue get fixed in OLM?
openshift-hive
go
@@ -29,9 +29,8 @@ namespace Nethermind.Blockchain.Processing IgnoreParentNotOnMainChain = 16, DoNotVerifyNonce = 32, DoNotUpdateHead = 64, - DumpParityTraces = 128, - DumpGetTraces = 256, - All = 511, + RerunWithTraceOnFailure = 128, + All = 255, Pr...
1
// Copyright (c) 2018 Demerzel Solutions Limited // This file is part of the Nethermind library. // // The Nethermind library is free software: you can redistribute it and/or modify // it under the terms of the GNU Lesser General Public License as published by // the Free Software Foundation, either version 3 of ...
1
24,263
This option is now unnecessary
NethermindEth-nethermind
.cs
@@ -360,10 +360,7 @@ func TestWriter(t *testing.T) { t.Fatal(err) } - b, err := NewBucket(subdir) - if err != nil { - t.Fatal(err) - } + b := &bucket{dir: subdir} ctx := context.Background() names := []string{ // Backslashes not allowed.
1
// Copyright 2018 Google LLC // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // https://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to in ...
1
10,180
Don't jump down to the unexported interface: just set the content type to `"application/octet-stream"` explicitly when creating the `Writer`.
google-go-cloud
go
@@ -176,8 +176,11 @@ class BufferedUpdates implements Accountable { } void clearDeleteTerms() { - deleteTerms.clear(); numTermDeletes.set(0); + deleteTerms.forEach((term, docIDUpto) -> { + bytesUsed.addAndGet(-(BYTES_PER_DEL_TERM + term.bytes.length + (Character.BYTES * term.field().length())));...
1
/* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may ...
1
33,478
Instead of counting this here on clear, can we use a second counter for the deleteTerms next to `bytesUsed`? This would be great. It doesn't need to be thread safe IMO
apache-lucene-solr
java
@@ -24,10 +24,10 @@ class User extends UserBase * Validation rules */ public $rules = [ - 'email' => 'required|between:6,255|email|unique:backend_users', - 'login' => 'required|between:2,255|unique:backend_users', - 'password' => 'required:create|between:4,255|confirmed', - ...
1
<?php namespace Backend\Models; use Mail; use Event; use Backend; use October\Rain\Auth\Models\User as UserBase; /** * Administrator user model * * @package october\backend * @author Alexey Bobkov, Samuel Georges */ class User extends UserBase { use \October\Rain\Database\Traits\SoftDelete; /** * @...
1
17,908
@daftspunk @bennothommo I wonder if we need to go as deep as detecting what the default varchar length is with a special character to be parsed by the validation trait since we've introduced the config for it.
octobercms-october
php
@@ -2186,7 +2186,7 @@ class WebElement { if (!this.driver_.fileDetector_) { return this.schedule_( new command.Command(command.Name.SEND_KEYS_TO_ELEMENT). - setParameter('text', keys). + setParameter('text', keys.then(keys => keys.join(''))). setParameter(...
1
// Licensed to the Software Freedom Conservancy (SFC) under one // or more contributor license agreements. See the NOTICE file // distributed with this work for additional information // regarding copyright ownership. The SFC licenses this file // to you under the Apache License, Version 2.0 (the // "License"); you m...
1
14,518
Also update line 2205 below
SeleniumHQ-selenium
py
@@ -158,7 +158,7 @@ public class MessageCompose extends K9Activity implements OnClickListener, "com.fsck.k9.activity.MessageCompose.quotedTextFormat"; private static final String STATE_KEY_NUM_ATTACHMENTS_LOADING = "numAttachmentsLoading"; private static final String STATE_KEY_WAITING_FOR_ATTACHM...
1
package com.fsck.k9.activity; import java.text.DateFormat; import java.util.ArrayList; import java.util.Collection; import java.util.Date; import java.util.HashMap; import java.util.List; import java.util.Locale; import java.util.Map; import java.util.regex.Matcher; import java.util.regex.Pattern; import android.ann...
1
13,427
Typo, should read `firstTimeEmptySubject`
k9mail-k-9
java
@@ -22,7 +22,7 @@ package transport import "golang.org/x/net/context" -// Handler handles a single transport-level request. +// Handler handles a single, transport-level, unary request. type Handler interface { // Handle the given request, writing the response to the given // ResponseWriter.
1
// Copyright (c) 2016 Uber Technologies, Inc. // // Permission is hereby granted, free of charge, to any person obtaining a copy // of this software and associated documentation files (the "Software"), to deal // in the Software without restriction, including without limitation the rights // to use, copy, modify, merge...
1
10,858
The more I see this the more I think the transport layer _should_ actually refer to this as `UnaryHandler`.
yarpc-yarpc-go
go
@@ -267,6 +267,7 @@ module Beaker logger.warn "#{e.class} error in scp'ing. Forcing the connection to close, which should " << "raise an error." close + raise "#{e}\n#{e.backtrace}" end
1
require 'socket' require 'timeout' require 'net/scp' module Beaker class SshConnection attr_accessor :logger attr_accessor :ip, :vmhostname, :hostname, :ssh_connection_preference SUPPORTED_CONNECTION_METHODS = [:ip, :vmhostname, :hostname] RETRYABLE_EXCEPTIONS = [ SocketError, Timeout:...
1
16,250
The `warn` message here seems to indicate that the forced closure of the SSH connection should raise an error; is that getting swallowed up somewhere and not raising?
voxpupuli-beaker
rb
@@ -616,6 +616,8 @@ class FilenamePrompt(_BasePrompt): self._init_texts(question) self._init_key_label() + self._expands_user = False + self._lineedit = LineEdit(self) if question.default: self._lineedit.setText(question.default)
1
# vim: ft=python fileencoding=utf-8 sts=4 sw=4 et: # Copyright 2016-2021 Florian Bruhin (The Compiler) <mail@qutebrowser.org> # # This file is part of qutebrowser. # # qutebrowser is free software: you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free S...
1
26,360
I wonder if this is a fitting name. Why "expands user"? Wouldn't be `user_expanded` or so be more fitting?
qutebrowser-qutebrowser
py
@@ -28,10 +28,11 @@ var axe = axe || { utils: {} }; */ function virtualDOMfromNode(node, shadowId) { const vNodeCache = {}; - return { + const vNode = { shadowId: shadowId, children: [], actualNode: node, + _isHidden: null, // will be populated by axe.utils.isHidden get isFocusable() { if (!vNodeC...
1
/*eslint no-use-before-define: 0*/ var axe = axe || { utils: {} }; /** * This implemnts the flatten-tree algorithm specified: * Originally here https://drafts.csswg.org/css-scoping/#flat-tree * Hopefully soon published here: https://www.w3.org/TR/css-scoping-1/#flat-tree * * Some notable information: ******* NOT...
1
14,375
I see what you are doing here, but to stay with the `getter/setter` pattern, should we introduce `set isHidden(value)` & `get isHidden()` which them maintains `_isHidden` with in `vNodeCache`. This will avoid what looks like accessing an internal property like `_isHidden` from `axe.utils.isHidden` & keeps things neat.
dequelabs-axe-core
js
@@ -41,6 +41,7 @@ public class CSharpBasicPackageTransformer implements ModelToViewTransformer<Pro "csharp/gapic_snippets_csproj.snip"; private static final String UNITTEST_CSPROJ_TEMPLATE_FILENAME = "csharp/gapic_unittest_csproj.snip"; + private static final String SAMPLE_CSPROJ_TEMPLATE_FILENAME = "...
1
/* Copyright 2017 Google LLC * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * https://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in...
1
29,985
nit: for consistency, have this line and the previous formatted similarly
googleapis-gapic-generator
java
@@ -165,6 +165,9 @@ public class PrivacyParameters { private PrivacyStorageProvider storageProvider; private EnclaveFactory enclaveFactory; private boolean multiTenancyEnabled; + private Path orionKeyStoreFile; + private Path orionKeyStorePasswordFile; + private Path orionClientWhitelistFile; ...
1
/* * Copyright ConsenSys AG. * * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with * the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing...
1
21,228
As before, shouldn't mention these as being orion options I don't think. Perhaps just enclaveKeyStoreFile etc.
hyperledger-besu
java
@@ -152,10 +152,8 @@ async function observeRestResponse( res ) { // The response may fail to resolve if the test ends before it completes. try { args.push( await res.text() ); + console.log( ...args ); // eslint-disable-line no-console } catch ( err ) {} // eslint-disable-line no-empty - - // eslint-dis...
1
/** * External dependencies */ import { get } from 'lodash'; /** * WordPress dependencies */ import { clearLocalStorage, enablePageDialogAccept, setBrowserViewport, } from '@wordpress/e2e-test-utils'; /** * Internal dependencies */ import { clearSessionStorage, deactivateAllOtherPlugins, resetSiteKit, } f...
1
24,621
What's the thinking here? Only logging when the test has not ended yet?
google-site-kit-wp
js
@@ -57,6 +57,12 @@ def _column_op(f): args = [arg._scol if isinstance(arg, IndexOpsMixin) else arg for arg in args] scol = f(self._scol, *args) + # If f is a logistic operator, fill NULL with False + log_ops = ['eq', 'ne', 'lt', 'le', 'ge', 'gt'] + is_log_op ...
1
# # Copyright (C) 2019 Databricks, Inc. # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to i...
1
12,847
@HyukjinKwon @ueshin (cc @itholic @charlesdong1991 ) Not sure if this is the right implementation ...
databricks-koalas
py
@@ -10,7 +10,13 @@ module.exports = function(url, options, callback) { if (typeof options === 'function') (callback = options), (options = {}); options = options || {}; - let result = parser.parse(url, true); + let result; + try { + result = parser.parse(url, true); + } catch (e) { + return callback(n...
1
'use strict'; const ReadPreference = require('mongodb-core').ReadPreference, parser = require('url'), f = require('util').format, Logger = require('mongodb-core').Logger, dns = require('dns'); module.exports = function(url, options, callback) { if (typeof options === 'function') (callback = options), (optio...
1
14,166
Do we want to add any specific error on how the url is malformed?
mongodb-node-mongodb-native
js
@@ -190,6 +190,10 @@ void Host::appendLogsInternal(folly::EventBase* eb, { std::lock_guard<std::mutex> g(self->lock_); self->setResponse(r); + self->lastLogIdSent_++; + if (self->lastLogIdSent_ < self->logIdToSend_) { + ++se...
1
/* Copyright (c) 2018 vesoft inc. All rights reserved. * * This source code is licensed under Apache 2.0 License, * attached with Common Clause Condition 1.0, found in the LICENSES directory. */ #include "base/Base.h" #include "kvstore/raftex/Host.h" #include "kvstore/raftex/RaftPart.h" #include "kvstore/wal/FileB...
1
23,382
why NOT self->lastLogIdSent_ = self->logIdToSend_
vesoft-inc-nebula
cpp
@@ -599,6 +599,18 @@ func (r *ReconcileClusterDeployment) reconcile(request reconcile.Request, cd *hi return reconcile.Result{Requeue: true}, nil } } + // Set the Provisioned status condition for adopted clusters (and in case we upgraded to/past where that condition was introduced) + if err := r.updateCon...
1
package clusterdeployment import ( "context" "fmt" "os" "reflect" "sort" "strconv" "strings" "time" "github.com/pkg/errors" log "github.com/sirupsen/logrus" routev1 "github.com/openshift/api/route/v1" batchv1 "k8s.io/api/batch/v1" corev1 "k8s.io/api/core/v1" apierrors "k8s.io/apimachinery/pkg/api/error...
1
19,929
Shouldn't this be in the above `if` block where we are setting the installedtimestamp to ensure this only happens for already installed (and/or adopted) clusters?
openshift-hive
go
@@ -422,7 +422,7 @@ class SessionManager(QObject): window=window.win_id) tab_to_focus = None for i, tab in enumerate(win['tabs']): - new_tab = tabbed_browser.tabopen() + new_tab = tabbed_browser.tabopen(background=False) ...
1
# vim: ft=python fileencoding=utf-8 sts=4 sw=4 et: # Copyright 2015-2017 Florian Bruhin (The Compiler) <mail@qutebrowser.org> # # This file is part of qutebrowser. # # qutebrowser is free software: you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free S...
1
20,046
This seems like another unrelated change I've done in `master`.
qutebrowser-qutebrowser
py
@@ -873,6 +873,15 @@ module RSpec::Core expect(config.formatters.first.output.path).to eq(path) end end + + context "when a duplicate formatter exists for the same output target" do + it "does not add the formatter" do + config.add_formatter :documentation + expe...
1
require 'spec_helper' require 'tmpdir' module RSpec::Core describe Configuration do let(:config) { Configuration.new } describe "RSpec.configuration with a block" do before { allow(RSpec).to receive(:warn_deprecation) } it "is deprecated" do expect(RSpec).to receive(:warn_deprecation)...
1
11,084
Would be good to have another context `"when a duplicate formatter exists for a different output target"` that shows that it keeps both. As this stands, the specs could pass w/o the `formatter.output == new_formatter.output` check.
rspec-rspec-core
rb
@@ -217,14 +217,15 @@ void SYCLSharedUSMSpace::deallocate(const char* arg_label, Kokkos::Tools::make_space_handle(name())); } -void SYCLDeviceUSMSpace::impl_access_error() { +KOKKOS_DEPRECATED void SYCLDeviceUSMSpace::impl_access_error() { const std::string msg( "Kokkos::Experimental::SY...
1
/* //@HEADER // ************************************************************************ // // Kokkos v. 3.0 // Copyright (2020) National Technology & Engineering // Solutions of Sandia, LLC (NTESS). // // Under the terms of Contract DE-NA0003525 with NTESS, // the U.S. Govern...
1
27,821
Why not just remove? The CUDA one has been around for while. This one has not been part of any release (?)
kokkos-kokkos
cpp
@@ -83,8 +83,9 @@ public class Session implements ContentBlocking.Delegate, GeckoSession.Navigatio private transient SharedPreferences mPrefs; private transient GeckoRuntime mRuntime; private transient byte[] mPrivatePage; - private transient boolean mFirstContentfulPaint; + private transient boole...
1
/* -*- Mode: Java; c-basic-offset: 4; tab-width: 4; indent-tabs-mode: nil; -*- * This Source Code Form is subject to the terms of the Mozilla Public * License, v. 2.0. If a copy of the MPL was not distributed with this * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ package org.mozilla.vrbrowser.brows...
1
8,737
nit: `Contentful` is the word used in the GV API, without the uppercase in F
MozillaReality-FirefoxReality
java
@@ -83,6 +83,12 @@ public class SchemaMeta extends CommonService<OperationMeta> { } private void initOperations() { + if (swagger.getPaths() == null) { + LOGGER.error(swagger.getInfo().getTitle() + " with path " + swagger.getBasePath() + + " is an empty interface, please delete it or fill with ...
1
/* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may ...
1
9,666
It just does the check, maybe we can name it as checkOperations.
apache-servicecomb-java-chassis
java
@@ -344,7 +344,7 @@ describe('runRules', function() { }); fixture.innerHTML = - '<div id="t1"><span></span></div><div id="t2"><em></em></div>'; + '<div id="t1"><em></em></div><div id="t2"><em></em></div>'; var $test = { 0: fixture.querySelector('#t1'),
1
/*global runRules */ describe('runRules', function() { 'use strict'; // These tests can sometimes be flaky in IE, allow for up to 3 retries if (axe.testUtils.isIE11) { this.retries(3); } function iframeReady(src, context, id, cb) { var i = document.createElement('iframe'); i.addEventListener('load', functi...
1
14,952
We no longer have karma output in the test file so these selectors were now unique and the target didn't need a child selector. Updated to force non-unique nodes
dequelabs-axe-core
js
@@ -1,8 +1,14 @@ +<% content_for :additional_header_links do %> + <% if current_user.has_subscription_with_mentor? %> + <li class="mentor"> + <%= mentor_image(current_user.mentor) %> + <%= mentor_contact_link(current_user.mentor) %> + </li> + <% end %> +<% end %> + <section class="workshops vertical-...
1
<section class="workshops vertical-slider revealed"> <figure class="meta product-card"> <%= render 'mentor' %> <%= render 'trails' %> </figure> <%= render partial: 'products/workshop', collection: online_workshops %> <%= render partial: 'products/workshop', collection: in_person_workshops %> </section> ...
1
8,640
This moved from a partial to not being in a partial. How about cleaning this view up further by moving it back into a partial?
thoughtbot-upcase
rb
@@ -42,6 +42,7 @@ func NewLightweightInformer( objType runtime.Object, resync time.Duration, h cache.ResourceEventHandler, + recieveUpdates bool, ) cache.Controller { cacheStore := cache.NewIndexer(cache.DeletionHandlingMetaNamespaceKeyFunc, cache.Indexers{}) fifo := cache.NewDeltaFIFOWithOptions(cache.Delta...
1
package k8s import ( "fmt" "time" "k8s.io/apimachinery/pkg/api/meta" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" "k8s.io/apimachinery/pkg/runtime" "k8s.io/client-go/tools/cache" ) type lightweightCacheObject struct { metav1.Object Name string Namespace string } func (lw *lightweightCacheObject) GetN...
1
9,571
add some form of docs in docstring or on :74 for what the effect is
lyft-clutch
go
@@ -13,7 +13,8 @@ from kinto.core.storage import ( StorageBase, exceptions, ) -from kinto.core.utils import COMPARISON, find_nested_value, json +from kinto.core.utils import COMPARISON, find_nested_value +import json def tree():
1
import numbers import operator import re from collections import abc, defaultdict from kinto.core import utils from kinto.core.decorators import deprecate_kwargs, synchronized from kinto.core.storage import ( DEFAULT_DELETED_FIELD, DEFAULT_ID_FIELD, DEFAULT_MODIFIED_FIELD, MISSING, StorageBase, ...
1
12,801
Couldn't you import `json` from `kinto.core.utils` here too?
Kinto-kinto
py
@@ -8,6 +8,9 @@ require 'rspec/rails' require 'steps/user_steps' require 'steps/approval_steps' +# mimic production env for view+mail +ENV["DISABLE_SANDBOX_WARNING"] = 'true' + # Requires supporting ruby files with custom matchers and macros, etc, in # spec/support/ and its subdirectories. Files matching `spec/**...
1
# This file is copied to spec/ when you run 'rails generate rspec:install' ENV["RAILS_ENV"] ||= 'test' require 'spec_helper' require File.expand_path("../../config/environment", __FILE__) require 'rspec/rails' # Add additional requires below this line. Rails is not loaded until this point! require 'steps/user_steps' r...
1
14,079
Minor: Hmmm...is it worth setting this explicitly for the tests that it affects?
18F-C2
rb
@@ -42,7 +42,6 @@ using namespace eprosima::fastrtps::rtps; StatefulReader::~StatefulReader() { - std::lock_guard<std::recursive_timed_mutex> guard(mp_mutex); logInfo(RTPS_READER,"StatefulReader destructor."); is_alive_ = false;
1
// Copyright 2016 Proyectos y Sistemas de Mantenimiento SL (eProsima). // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless re...
1
14,492
This was added to fix a race condition and you are reverting it here, right?
eProsima-Fast-DDS
cpp
@@ -2,11 +2,16 @@ package commands import ( "context" + "fmt" "github.com/ledgerwatch/turbo-geth/common" ) -// Etherbase is the address that mining rewards will be send to +// Coinbase is the address that mining rewards will be sent to func (api *APIImpl) Coinbase(_ context.Context) (common.Address, error)...
1
package commands import ( "context" "github.com/ledgerwatch/turbo-geth/common" ) // Etherbase is the address that mining rewards will be send to func (api *APIImpl) Coinbase(_ context.Context) (common.Address, error) { return api.ethBackend.Etherbase() }
1
21,783
Could you add some extra text here, so that it reads "eth_coinbase function is not available, please use --private.api.addr option instead of --chaindata option", so that it is clear that the function can work, but different options
ledgerwatch-erigon
go
@@ -159,6 +159,19 @@ feature 'Creating an NCR work order' do expect(page).to have_content('$2,000 for construction') end + scenario "selecting Expense Type toggles Building required flag", :js do + login_as(requester) + visit "/ncr/work_orders/new" + find("#ncr_work_order_expense_type_ba...
1
feature 'Creating an NCR work order' do scenario 'requires sign-in' do visit '/ncr/work_orders/new' expect(current_path).to eq('/') expect(page).to have_content("You need to sign in") end with_feature 'RESTRICT_ACCESS' do scenario 'requires a GSA email address' do user = create(:user, email...
1
15,755
`new_ncr_work_order_path` ? (I've been slowly moving specs over to that way of calling paths)
18F-C2
rb
@@ -15,7 +15,9 @@ application/javascript text/css image/* - application/x-shockwave-flash + application/x-shockwave-flash ? + font/* + application/font-*...
1
""" The following operators are understood: ~q Request ~s Response Headers: Patterns are matched against "name: value" strings. Field names are all-lowercase. ~a Asset content-type in response. Asset content types are: ...
1
16,004
Should flash be included in the patterns too? It currently isn't.
mitmproxy-mitmproxy
py
@@ -18,7 +18,7 @@ namespace Microsoft.Cci.Differs.Rules if (impl.IsEffectivelySealed() && !contract.IsEffectivelySealed()) { differences.AddIncompatibleDifference(this, - "Type '{0}' is sealed in the implementation but not sealed in the contract.", impl.Full...
1
// Licensed to the .NET Foundation under one or more agreements. // The .NET Foundation licenses this file to you under the MIT license. // See the LICENSE file in the project root for more information. using Microsoft.Cci.Extensions; using Microsoft.Cci.Extensions.CSharp; namespace Microsoft.Cci.Differs.Rules { ...
1
14,803
I suspect I will have to keep looking whether Left/Right refers to contract/Implementation while working on the rules code.
dotnet-buildtools
.cs
@@ -76,7 +76,7 @@ namespace AutoRest.CSharp.Azure if (model.Extensions.ContainsKey(AzureExtensions.AzureResourceExtension) && (bool)model.Extensions[AzureExtensions.AzureResourceExtension]) { - model.BaseModelType = new Composite...
1
// Copyright (c) Microsoft Corporation. All rights reserved. // Licensed under the MIT License. See License.txt in the project root for license information. using System.Collections.Generic; using System.Globalization; using System.IO; using System.Linq; using System.Threading.Tasks; using AutoRest.Core; using AutoRes...
1
22,605
(ignore this. testing a codeflow bug)
Azure-autorest
java
@@ -137,9 +137,9 @@ func buildCLIOptions() *cli.App { EnvVar: "CASSANDRA_TLS_CA", }, cli.BoolFlag{ - Name: schema.CLIFlagTLSEnableHostVerification, - Usage: "TLS host verification", - EnvVar: "CASSANDRA_TLS_VERIFY_HOST", + Name: schema.CLIFlagTLSDisableHostVerification, + Usage: "Cassandra tls...
1
// The MIT License // // Copyright (c) 2020 Temporal Technologies Inc. All rights reserved. // // Copyright (c) 2020 Uber Technologies, Inc. // // Permission is hereby granted, free of charge, to any person obtaining a copy // of this software and associated documentation files (the "Software"), to deal // in the Soft...
1
11,626
[Nit] can you change the Usage wording to indicate that the flag is used to opt-out of server certificate verification? (e.g. "disables validation of the Cassandra cluster's server certificate.")
temporalio-temporal
go
@@ -14,6 +14,8 @@ package zipkin.storage.elasticsearch; import com.google.common.base.Throwables; +import java.io.IOException; +import java.util.List; import zipkin.DependencyLink; import zipkin.Span; import zipkin.internal.MergeById;
1
/** * Copyright 2015-2016 The OpenZipkin Authors * * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except * in compliance with the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or ...
1
11,977
Sorry :) Would be really helpful to integrate something like Eclipse Code Formatter, so it will fail if the code style is broken (the same as eslint fails on the frontend) I use IntelliJ IDEA and their vision of imports is a bit different :)
openzipkin-zipkin
java
@@ -362,7 +362,17 @@ module Beaker block_on host do |host| if host['platform'] =~ /centos|el-|redhat|fedora/ logger.debug("Disabling iptables on #{host.name}") - host.exec(Command.new("sudo su -c \"/etc/init.d/iptables stop\""), {:pty => true}) + if host.exec(Command.new('wh...
1
[ 'command', "dsl/patterns" ].each do |lib| require "beaker/#{lib}" end module Beaker #Provides convienience methods for commonly run actions on hosts module HostPrebuiltSteps include Beaker::DSL::Patterns NTPSERVER = 'pool.ntp.org' SLEEPWAIT = 5 TRIES = 5 UNIX_PACKAGES = ['curl', 'ntpdate']...
1
7,499
this will still fail on systemd
voxpupuli-beaker
rb
@@ -3760,6 +3760,8 @@ class RDSConnection(AWSQueryConnection): path='/', params=params) body = response.read() boto.log.debug(body) + if type(body) == bytes: + body = body.decode('utf-8') if response.status == 200: return js...
1
# Copyright (c) 2014 Amazon.com, Inc. or its affiliates. All Rights Reserved # # Permission is hereby granted, free of charge, to any person obtaining a # copy of this software and associated documentation files (the # "Software"), to deal in the Software without restriction, including # without limitation the rights ...
1
10,841
The convention in most of the codebase is to use `if isinstance(body, bytes):` instead.
boto-boto
py
@@ -249,7 +249,9 @@ class ConsoleUI(wx.Frame): if self.completionAmbiguous: menu = wx.Menu() for comp in completions: - item = menu.Append(wx.ID_ANY, comp) + # Only show text after the last dot (so as to not keep repeting the class or module in the context menu) + label=comp.split('.')[-1] + item...
1
#pythonConsole.py #A part of NonVisual Desktop Access (NVDA) #This file is covered by the GNU General Public License. #See the file COPYING for more details. #Copyright (C) 2008-2013 NV Access Limited import watchdog """Provides an interactive Python console which can be run from within NVDA. To use, call L{...
1
19,371
I think this would be better as: `label = comp.rsplit('.', 1)[-1]`
nvaccess-nvda
py
@@ -57,8 +57,8 @@ public class RubyProvider { } @SuppressWarnings("unchecked") - public <Element> GeneratedResult generate( - Element element, SnippetDescriptor snippetDescriptor, RubyGapicContext context) { + public <Element, ContextT> GeneratedResult generate( + Element element, SnippetDescriptor ...
1
/* Copyright 2016 Google Inc * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in ...
1
14,953
We have been creating a language-level context interface for each language instead of parameterizing the generate function.
googleapis-gapic-generator
java
@@ -21,6 +21,6 @@ class UuidGenerator implements GeneratorInterface { $id = (string) $media->getId(); - return sprintf('%s/%04s/%02s', $media->getContext(), substr($id, 0, 4), substr($id, 4, 2)); + return sprintf('%s/%04s/%02s', $media->getContext() ?? '', substr($id, 0, 4), substr($id, 4,...
1
<?php declare(strict_types=1); /* * This file is part of the Sonata Project package. * * (c) Thomas Rabaix <thomas.rabaix@sonata-project.org> * * For the full copyright and license information, please view the LICENSE * file that was distributed with this source code. */ namespace Sonata\MediaBundle\Generator...
1
12,403
Same thing about context here.
sonata-project-SonataMediaBundle
php
@@ -634,9 +634,16 @@ func (handler *workflowTaskHandlerImpl) handleCommandContinueAsNewWorkflow( return handler.failCommand(enumspb.WORKFLOW_TASK_FAILED_CAUSE_UNHANDLED_COMMAND, nil) } + namespaceEntry, err := handler.namespaceCache.GetNamespaceByID(handler.mutableState.GetExecutionInfo().NamespaceId) + if err !...
1
// The MIT License // // Copyright (c) 2020 Temporal Technologies Inc. All rights reserved. // // Copyright (c) 2020 Uber Technologies, Inc. // // Permission is hereby granted, free of charge, to any person obtaining a copy // of this software and associated documentation files (the "Software"), to deal // in the Soft...
1
11,524
there is a function to get namespace entry from mutable state directly
temporalio-temporal
go
@@ -191,7 +191,7 @@ module Bolt hiera_config: @hiera_config, plan_vars: plan_vars, # This data isn't available on the target config hash - config: @inventory.config.transport_data_get + config: @inventory.transport_data_get } description = options[:description] |...
1
# frozen_string_literal: true require 'base64' require 'bolt/apply_result' require 'bolt/apply_target' require 'bolt/config' require 'bolt/error' require 'bolt/task' require 'bolt/util/puppet_log_level' require 'find' require 'json' require 'logging' require 'open3' module Bolt class Applicator def initialize(i...
1
14,119
The `Transport::Config` objects don't serialize properly. We probably want to just turn them into hashes at this point.
puppetlabs-bolt
rb
@@ -251,11 +251,11 @@ const ConfigInstructions = ` # These values specify the destination directory for ddev ssh and the # directory in which commands passed into ddev exec are run. -# omit_containers: ["dba", "ddev-ssh-agent"] -# would omit the dba (phpMyAdmin) and ddev-ssh-agent containers. Currently -# only thos...
1
package ddevapp // DDevComposeTemplate is used to create the main docker-compose.yaml // file for a ddev site. const DDevComposeTemplate = `version: '{{ .ComposeVersion }}' {{ .DdevGenerated }} services: {{if not .OmitDB }} db: container_name: {{ .Plugin }}-${DDEV_SITENAME}-db build: context: '{{ .DBBu...
1
14,124
Sorry, typo s/unusuable/unusable/
drud-ddev
go
@@ -242,6 +242,13 @@ public class SparkSessionCatalog<T extends TableCatalog & SupportsNamespaces> @Override public final void initialize(String name, CaseInsensitiveStringMap options) { + if (options.containsKey("type") && options.get("type").equalsIgnoreCase("hive") && options.containsKey("uri")) { + ...
1
/* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you ...
1
42,018
If this is needed, should we check that the configured `uri` isn't already equal to the value of the metastore URI configured via `spark.hadoop.hive.metastore.uris` or any of the other ways of setting it. This would be a breaking change for people who have `uri` configured on the SparkSessionCatalog and have it correct...
apache-iceberg
java
@@ -21,4 +21,7 @@ class ViewMultipart(base.View): return "Multipart form", self._format(v) def render_priority(self, data: bytes, *, content_type: Optional[str] = None, **metadata) -> float: - return float(content_type == "multipart/form-data") + if content_type and content_type.starts...
1
from typing import Optional from mitmproxy.coretypes import multidict from mitmproxy.net.http import multipart from . import base class ViewMultipart(base.View): name = "Multipart Form" @staticmethod def _format(v): yield [("highlight", "Form data:\n")] yield from base.format_dict(multid...
1
15,760
see above - this is only used to select the correct view, we don't need to handle the boundary information here.
mitmproxy-mitmproxy
py
@@ -555,6 +555,7 @@ func TestSign(t *testing.T) { LastTransitionTime: &metaFixedClockStart, }), gen.SetCertificateRequestCertificate(certPEM), + gen.SetCertificateRequestCA(certPEM), gen.AddCertificateRequestAnnotations(map[string]string{cmapi.VenafiPickupIDAnnotationKey: "test"})...
1
/* Copyright 2020 The cert-manager Authors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing...
1
24,623
These tests use a self-signed cert so the CA *is* the cert. I considered making a proper chain to use in the tests, but wasn't sure it was necessary to test here, since we test it in the E2E tests anyway.
jetstack-cert-manager
go
@@ -212,6 +212,10 @@ function diffElementNodes(dom, newVNode, oldVNode, context, isSvg, excessDomChil if (newVNode.type===null) { if (oldProps !== newProps) { + if (excessDomChildren!=null) { + const index = excessDomChildren.indexOf(dom); + if (index > -1) excessDomChildren[index] = null; + } dom....
1
import { EMPTY_OBJ, EMPTY_ARR } from '../constants'; import { Component, enqueueRender } from '../component'; import { coerceToVNode, Fragment } from '../create-element'; import { diffChildren, toChildArray } from './children'; import { diffProps } from './props'; import { assign, removeNode } from '../util'; import op...
1
14,115
We could, maybe, just directly do `excessDomChildren[excessDomChildren.indexOf(dom)] = null;`. Would this improve the size in any way? This will end-up with a property on the `excessDomChildren["-1"]` but maybe we could live with that?
preactjs-preact
js
@@ -1278,6 +1278,11 @@ module.service('gridUtil', ['$log', '$window', '$document', '$http', '$templateC for ( var i = mouseWheeltoBind.length; i; ) { $elm.on(mouseWheeltoBind[--i], cbs[fn]); } + $elm.on('$destroy', function unbindEvents() { + for ( var i = mouseWheeltoBind.length; i; ) { + ...
1
(function() { var module = angular.module('ui.grid'); var bindPolyfill; if (typeof Function.prototype.bind !== "function") { bindPolyfill = function() { var slice = Array.prototype.slice; return function(context) { var fn = this, args = slice.call(arguments, 1); if (args.length) { ...
1
11,759
this looks like it may be something that needs additional refactoring
angular-ui-ui-grid
js
@@ -300,7 +300,7 @@ class Resource(object): for resource in yielder.iter(): res = resource new_stack = stack + [self] - + # Parallelization for resource subtrees. if res.should_dispatch(): ...
1
# Copyright 2017 The Forseti Security Authors. All rights reserved. # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by ap...
1
33,421
Nit: Remove whitespace (and below)
forseti-security-forseti-security
py
@@ -205,7 +205,10 @@ return [ 'error_moving_file' => 'Error moving file :file', 'error_moving_directory' => 'Error moving directory :dir', 'error_deleting_directory' => 'Error deleting the original directory :dir', - 'path' => 'Path' + 'path' => 'Path', + 'unzip' => 'Unzi...
1
<?php return [ 'cms_object' => [ 'invalid_file' => 'Invalid file name: :name. File names can contain only alphanumeric symbols, underscores, dashes and dots. Some examples of correct file names: page.htm, page, subdirectory/page', 'invalid_property' => "The property ':name' cannot be set", ...
1
11,401
"Failed opening" or "Failed to open".
octobercms-october
php
@@ -131,8 +131,12 @@ func (d *Disk) validate(ctx context.Context, s *Step) DError { if _, err := s.w.images.regUse(d.SourceImage, s); err != nil { errs = addErrs(errs, Errf("%s: can't use image %q: %v", pre, d.SourceImage, err)) } + } else if d.SourceSnapshot != "" { + if _, err := s.w.snapshots.regUse(d.Sou...
1
// Copyright 2017 Google Inc. All Rights Reserved. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by appl...
1
10,368
and -> or
GoogleCloudPlatform-compute-image-tools
go