patch
stringlengths
17
31.2k
y
int64
1
1
oldf
stringlengths
0
2.21M
idx
int64
1
1
id
int64
4.29k
68.4k
msg
stringlengths
8
843
proj
stringclasses
212 values
lang
stringclasses
9 values
@@ -227,8 +227,13 @@ AX_CODE_COVERAGE AC_ARG_WITH([flux-security], AS_HELP_STRING([--with-flux-security], [Build with flux-security])) AS_IF([test "x$with_flux_security" = "xyes"], [ - PKG_CHECK_MODULES([FLUX_SECURITY], [flux-security], [], []) + PKG_CHECK_MODULES([FLUX_SECURITY], [flux-security],...
1
## # Prologue ## AC_INIT([flux-core], m4_esyscmd([git describe --always | awk '/.*/ {sub(/^v/, ""); printf "%s",$1; exit}'])) AC_CONFIG_AUX_DIR([config]) AC_CONFIG_MACRO_DIR([config]) AC_CONFIG_SRCDIR([NEWS]) AC_CANONICAL_SYSTEM ## # If runstatedir not explicitly set on command line, use '/run' as default # N.B...
1
21,568
Should this line set the value to `x` since that is checked below?
flux-framework-flux-core
c
@@ -138,6 +138,14 @@ public interface DataFile { */ DataFile copy(); + /** + * Copies this {@link DataFile data file} without file stats. Manifest readers can reuse data file instances; use + * this method to copy data without stats when collecting files. + * + * @return a copy of this data file + *...
1
/* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you ...
1
13,732
I don't particularly love the terminology here. Why not simply add `copy(boolean stats)` or a copy with an enum to indicate what portions of the datafile to include? At some point we may want just some of the values (e.g. CBO may want counts, but not lower/upper bounds). Just a thought.
apache-iceberg
java
@@ -220,11 +220,12 @@ public final class QueryRequest { public Builder parseAnnotationQuery(String annotationQuery) { if (annotationQuery != null && !annotationQuery.isEmpty()) { for (String ann : annotationQuery.split(" and ")) { - if (ann.indexOf('=') == -1) { + int idx = ann.in...
1
/** * Copyright 2015-2016 The OpenZipkin Authors * * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except * in compliance with the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or ...
1
11,853
you could probably remove keyValue and just compare idx vs ann.length (ex I think the goal here is to ensure it works with a value like `foo=`
openzipkin-zipkin
java
@@ -94,8 +94,8 @@ exports.getMimeType = (item) => { } exports.getId = (item) => { - if (item.file_type && item.file_type === 'TIMELINE') { - return `${encodeURIComponent(item.meeting_id)}__TIMELINE` + if (item.file_type && item.file_type === 'CC') { + return `${encodeURIComponent(item.meeting_id)}__CC__${en...
1
const moment = require('moment') const MIMETYPES = { MP4: 'video/mp4', M4A: 'audio/mp4', CHAT: 'text/plain', TRANSCRIPT: 'text/vtt', CC: 'text/vtt', TIMELINE: 'application/json' } const EXT = { MP4: 'mp4', M4A: 'm4a', CHAT: 'txt', TRANSCRIPT: 'vtt', CC: 'vtt', TIMELINE: 'json' } const ICONS = {...
1
13,493
we do this to differentiate between the multiple cc files for when the recording is stopped / restarted multiple times within a single meeting
transloadit-uppy
js
@@ -182,7 +182,6 @@ class KohaRest extends \VuFind\ILS\Driver\AbstractBase implements */ protected $itemStatusMappings = [ 'Item::Held' => 'On Hold', - 'Item::Lost' => 'Lost--Library Applied', 'Item::Waiting' => 'On Holdshelf', ];
1
<?php /** * VuFind Driver for Koha, using REST API * * PHP version 7 * * Copyright (C) The National Library of Finland 2016-2020. * Copyright (C) Moravian Library 2019. * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2, * ...
1
30,250
You've deleted this code but not added it anywhere else. Should this be used as my proposed example in the .ini file? Do we need a mechanism for configuring a global fallback string independent of the numeric codes?
vufind-org-vufind
php
@@ -46,6 +46,9 @@ import com.google.common.collect.ImmutableMap; import com.google.common.collect.ImmutableSet; import com.google.protobuf.DescriptorProtos.FieldDescriptorProto.Type; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Collections; import java.util.List; import javax.annotat...
1
/* Copyright 2016 Google Inc * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in ...
1
18,069
nit: strip away those imports? seems not used in the new code.
googleapis-gapic-generator
java
@@ -25,8 +25,12 @@ import ( "os" "time" + "github.com/ethereum/go-ethereum/common" + + "github.com/ethereum/go-ethereum/accounts/abi/bind" "github.com/ethereum/go-ethereum/core/types" "github.com/ethereum/go-ethereum/ethclient" + "github.com/mysteriumnetwork/node/blockchain/generated" "github.com/mysteriumn...
1
/* * Copyright (C) 2017 The "MysteriumNetwork/node" Authors. * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation, either version 3 of the License, or * (at your option) any later version. * ...
1
14,587
redundant whitespace :octocat:
mysteriumnetwork-node
go
@@ -698,7 +698,8 @@ class TestCloudFormationSetStackPolicy(CloudFormationConnectionBase): self.set_http_response(status_code=200) api_response = self.service_connection.set_stack_policy('stack-id', stack_policy_body='{}') - self.assertEqual(api_response['Some'], 'content') + ...
1
#!/usr/bin/env python import unittest from datetime import datetime from mock import Mock from tests.unit import AWSMockServiceTestCase from boto.cloudformation.connection import CloudFormationConnection from boto.exception import BotoServerError from boto.compat import json SAMPLE_TEMPLATE = r""" { "AWSTemplateFor...
1
10,928
I don't believe that the `assertDictEqual` call can pass without `api_response` being a `dict`, so this second check isn't needed!
boto-boto
py
@@ -213,8 +213,10 @@ static h2o_iovec_t *decode_string(h2o_mem_pool_t *pool, const uint8_t **src, con if (len > src_end - *src) return NULL; ret = alloc_buf(pool, len * 2); /* max compression ratio is >= 0.5 */ - if ((ret->len = h2o_hpack_decode_huffman(ret->base, *src, len, is_hea...
1
/* * Copyright (c) 2014-2016 DeNA Co., Ltd., Kazuho Oku, Fastly, Inc. * * Permission is hereby granted, free of charge, to any person obtaining a copy * of this software and associated documentation files (the "Software"), to * deal in the Software without restriction, including without limitation the * rights to...
1
14,313
Fuzzer did not like this change. Looks like I misunderstood how the pool works... if allocated from a pool we should never free it manually, right? I think I'll need to drop this patch.
h2o-h2o
c
@@ -4,16 +4,13 @@ import javafx.beans.property.ObjectProperty; import javafx.beans.property.SimpleObjectProperty; import javafx.scene.control.Alert; import javafx.scene.control.ButtonType; -import javafx.scene.control.Label; -import javafx.scene.layout.Region; -import javafx.stage.Window; import java.util.Optiona...
1
package org.phoenicis.javafx.dialogs; import javafx.beans.property.ObjectProperty; import javafx.beans.property.SimpleObjectProperty; import javafx.scene.control.Alert; import javafx.scene.control.ButtonType; import javafx.scene.control.Label; import javafx.scene.layout.Region; import javafx.stage.Window; import java...
1
13,517
Wouldn't it make sense to already have title, owner etc in this class?
PhoenicisOrg-phoenicis
java
@@ -18,6 +18,19 @@ module Faker def character fetch('aqua_teen_hunger_force.character') end + + ## + # Produces a perl of great AHTF wisdom + # + # @return [String] + # + # @example + # Faker::TvShows::AquaTeenHungerForce.quote #=> "Friends...
1
# frozen_string_literal: true module Faker class TvShows class AquaTeenHungerForce < Base flexible :aqua_teen_hunger_force class << self ## # Produces a character from Aqua Teen Hunger Force. # # @return [String] # # @example # Faker::TvShows...
1
9,684
New generators should have version `next`
faker-ruby-faker
rb
@@ -204,6 +204,8 @@ public class ProcessBesuNodeRunner implements BesuNodeRunner { params.add("--metrics-category"); params.add(((Enum<?>) category).name()); } + params.add("--metrics-protocol"); + params.add(metricsConfiguration.getProtocol().name()); if (metricsConfiguration....
1
/* * Copyright ConsenSys AG. * * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with * the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing...
1
23,824
Wrap these two lines inside an `if (node.isMetricsEnabled() || metricsConfiguration.isPushEnabled()) { ... }`
hyperledger-besu
java
@@ -85,13 +85,14 @@ class FPN(BaseModule): self.fp16_enabled = False self.upsample_cfg = upsample_cfg.copy() - if end_level == -1: + if end_level == -1 or end_level == self.num_ins: + # if end_level == len(inputs) or end_level == -1, extra level is allowed self....
1
# Copyright (c) OpenMMLab. All rights reserved. import torch.nn as nn import torch.nn.functional as F from mmcv.cnn import ConvModule from mmcv.runner import BaseModule, auto_fp16 from ..builder import NECKS @NECKS.register_module() class FPN(BaseModule): r"""Feature Pyramid Network. This is an implementati...
1
27,038
if end_level == -1 or end_level == (self.num_ins - 1): for end_level is the Index of the end input backbone level.
open-mmlab-mmdetection
py
@@ -33,6 +33,17 @@ namespace Nethermind.Store public bool IsLeaf { get; } public bool IsExtension => !IsLeaf; + public int Size + { + get + { + const int refSize = sizeof(long); + const int arrayOverhead = sizeof(long); + ...
1
// Copyright (c) 2018 Demerzel Solutions Limited // This file is part of the Nethermind library. // // The Nethermind library is free software: you can redistribute it and/or modify // it under the terms of the GNU Lesser General Public License as published by // the Free Software Foundation, either version 3 of...
1
23,032
No CLR overhead?
NethermindEth-nethermind
.cs
@@ -414,6 +414,18 @@ func TestCreateInstanceValidateMachineType(t *testing.T) { p := "project" z := "zone" + _, c, err := daisyCompute.NewTestClient(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { + if r.Method == "GET" && r.URL.String() == "/project/zones/zone/machineTypes/mt?alt=json" { + fmt...
1
// Copyright 2017 Google Inc. All Rights Reserved. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by appl...
1
6,661
Consider faking the TestClient's GetProject/GetZone/GetMachine methods.
GoogleCloudPlatform-compute-image-tools
go
@@ -88,13 +88,15 @@ func AddHeader(key, value string) OutboundOption { } } -// NewOutbound builds an HTTP outbound which sends requests to peers supplied +// NewOutbound builds an HTTP outbound that sends requests to peers supplied // by the given peer.Chooser. The URL template for used for the different // peer...
1
// Copyright (c) 2017 Uber Technologies, Inc. // // Permission is hereby granted, free of charge, to any person obtaining a copy // of this software and associated documentation files (the "Software"), to deal // in the Software without restriction, including without limitation the rights // to use, copy, modify, merge...
1
14,278
Returning a private type as part of the public API? Isn't this impossible for users to implement?
yarpc-yarpc-go
go
@@ -422,9 +422,9 @@ std::string MolToSmiles(const ROMol &mol, bool doIsomericSmiles, bool doKekule, if (canonical) { if (tmol->hasProp("_canonicalRankingNumbers")) { for (unsigned int i = 0; i < tmol->getNumAtoms(); ++i) { - unsigned int rankNum; - tmol->getAtomWithIdx(i) - ...
1
// $Id$ // // Copyright (C) 2002-2012 Greg Landrum and Rational Discovery LLC // // @@ All Rights Reserved @@ // This file is part of the RDKit. // The contents are covered by the terms of the BSD license // which is included in the file license.txt, found at the root // of the RDKit source tree. // #include "Sm...
1
14,855
prefer common_properties::_canonicalRankingNumber if possible, should be quicker in general.
rdkit-rdkit
cpp
@@ -52,6 +52,8 @@ class AnchorHead(nn.Module): loss_weight=1.0), loss_bbox=dict( type='SmoothL1Loss', beta=1.0 / 9.0, loss_weight=1.0), + loss_normalizer=-1, + loss_normalizer_momentum=0.9, train_cfg=None, ...
1
import torch import torch.nn as nn from mmcv.cnn import normal_init from mmdet.core import (anchor_inside_flags, build_anchor_generator, build_assigner, build_bbox_coder, build_sampler, force_fp32, images_to_levels, multi_apply, multiclass_nms, un...
1
19,671
The meaning of `loss_normalizer` and `loss_normalizer_momentum` should be reflected in docstring.
open-mmlab-mmdetection
py
@@ -87,11 +87,16 @@ static void init_async(h2o_multithread_queue_t *queue, h2o_loop_t *loop) { int fds[2]; +#ifndef _WIN32 if (cloexec_pipe(fds) != 0) { perror("pipe"); abort(); } fcntl(fds[1], F_SETFL, O_NONBLOCK); +#else + u_long nonblock = 1; + ioctlsocket(fds[1], FIONB...
1
/* * Copyright (c) 2015 DeNA Co., Ltd., Kazuho Oku * * Permission is hereby granted, free of charge, to any person obtaining a copy * of this software and associated documentation files (the "Software"), to * deal in the Software without restriction, including without limitation the * rights to use, copy, modify,...
1
10,686
Call to `cloexec_pipe` (or an equivalent function) is missing. I presume that this is the reason why you are seeing timeout errors.
h2o-h2o
c
@@ -26,11 +26,7 @@ import org.springframework.security.oauth2.jwt.Jwt; import java.time.Duration; import java.time.Instant; -import java.util.Arrays; -import java.util.Collection; -import java.util.Collections; -import java.util.HashMap; -import java.util.Map; +import java.util.*; import static org.assertj.core....
1
/* * Copyright 2002-2019 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * https://www.apache.org/licenses/LICENSE-2.0 * * Unless required by a...
1
14,210
There are no changes in this file. Please reset.
spring-projects-spring-security
java
@@ -731,9 +731,11 @@ def nullDistribution(verbosity=0): def normalProbability(x, distributionParams): """ - Given the normal distribution specified by the mean and standard deviation in - distributionParams, return the probability of getting samples > x. - This is the Q-function: the tail probability of the no...
1
# ---------------------------------------------------------------------- # Numenta Platform for Intelligent Computing (NuPIC) # Copyright (C) 2014-2016, Numenta, Inc. Unless you have an agreement # with Numenta, Inc., for a separate license for this software code, the # following terms and conditions apply: # # This p...
1
21,700
Should we rename this to tailProbability?
numenta-nupic
py
@@ -431,6 +431,9 @@ drutil_insert_get_mem_addr_arm(void *drcontext, instrlist_t *bb, instr_t *where, index = replace_stolen_reg(drcontext, bb, where, memref, dst, scratch, scratch_used); } + if (opnd_get_base_aligned(memref)) { + // TODO + ...
1
/* ********************************************************** * Copyright (c) 2011-2021 Google, Inc. All rights reserved. * Copyright (c) 2008-2010 VMware, Inc. All rights reserved. * **********************************************************/ /* drutil: DynamoRIO Instrumentation Utilities * Derived from Dr. Mem...
1
25,840
Add the issue number too i#4400
DynamoRIO-dynamorio
c
@@ -373,7 +373,7 @@ abstract class BaseFile<F> if (list != null) { List<E> copy = Lists.newArrayListWithExpectedSize(list.size()); copy.addAll(list); - return Collections.unmodifiableList(copy); + return copy; } return null; }
1
/* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you ...
1
20,982
Why make this modifiable?
apache-iceberg
java
@@ -8,13 +8,11 @@ package blockchain const ( // Erc721Binary a simple erc721 token bin - Erc721Binary="60806040523480156200001157600080fd5b5060408051808201825260068082527f4e6674696573000000000000000000000000000000000000000000000000000060208084019190915283518085019094529083527f4e465449455300000000000000000000000000...
1
// Copyright (c) 2019 IoTeX // This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no // warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent // permitted by law, all liability for your use of the cod...
1
16,970
Why this file is changed?
iotexproject-iotex-core
go
@@ -9,6 +9,11 @@ def includeme(config): description='Track changes on data.', url='http://kinto.readthedocs.io/en/latest/api/1.x/history.html') + config.add_api_capability( + 'revert', + description='discard all changes after given timestamp.', + url='http://kinto.readthedocs...
1
from kinto.core.events import ResourceChanged from .listener import on_resource_changed def includeme(config): config.add_api_capability( 'history', description='Track changes on data.', url='http://kinto.readthedocs.io/en/latest/api/1.x/history.html') # Activate end-points. conf...
1
9,994
I'm not sure that we need this
Kinto-kinto
py
@@ -22,7 +22,7 @@ namespace Microsoft.DotNet.Build.Tasks string dependencyVersion; if (package.Value is JObject) { - dependencyVersion = package.Value["version"].Value<string>(); + dependencyVersion = package.Value["version"]?.Value<string>(); ...
1
using Microsoft.Build.Framework; using Newtonsoft.Json; using Newtonsoft.Json.Linq; using System; namespace Microsoft.DotNet.Build.Tasks { public class UpdatePackageDependencyVersion : VisitProjectDependencies { [Required] public string PackageId { get; set; } [Required] publi...
1
8,889
Is this going to cause issues in any other places were someone forgets the version? Should we consider also checking for type=project?
dotnet-buildtools
.cs
@@ -86,3 +86,18 @@ func extractASMValue(out *secretsmanager.GetSecretValueOutput) (docker.AuthConfi return dac, nil } + +// GetSecretFromASM makes the api call to the AWS Secrets Manager service to +// retrieve the secret value +func GetSecretFromASM(secretID string, client secretsmanageriface.SecretsManagerAPI) (...
1
// Copyright 2018 Amazon.com, Inc. or its affiliates. All Rights Reserved. // // Licensed under the Apache License, Version 2.0 (the "License"). You may // not use this file except in compliance with the License. A copy of the // License is located at // // http://aws.amazon.com/apache2.0/ // // or in the "license" ...
1
21,533
Does this have retries? Is there a possibility that customer would hit throttle errors here?
aws-amazon-ecs-agent
go
@@ -3,15 +3,17 @@ #endif #include <platform.h> -#if defined(PLATFORM_IS_LINUX) || defined(PLATFORM_IS_FREEBSD) +#if defined(PLATFORM_IS_LINUX) || defined(PLATFORM_IS_BSD) #include <sched.h> #include <sys/time.h> #include <sys/resource.h> #include <sys/mman.h> #endif -#if defined(PLATFORM_IS_FREEBSD) +#if def...
1
#ifdef __linux__ #define _GNU_SOURCE #endif #include <platform.h> #if defined(PLATFORM_IS_LINUX) || defined(PLATFORM_IS_FREEBSD) #include <sched.h> #include <sys/time.h> #include <sys/resource.h> #include <sys/mman.h> #endif #if defined(PLATFORM_IS_FREEBSD) #include <pthread_np.h> #include <sys/cpuset.h> typedef cpus...
1
11,148
i noted that we are inconsistent with when we indent includes (see atomics.h which is rather different) and for example cpu.c which is also different. we seem to have 3 styles.
ponylang-ponyc
c
@@ -80,6 +80,12 @@ const start = (passthroughArgs, buildConfig = config.defaultBuildConfig, options if (user_data_dir) { // clear the data directory before doing a network test fs.removeSync(user_data_dir.replace('\\', '')) + if (fs.existsSync(networkLogFile)) { + fs.unlinkSync(networkLog...
1
const path = require('path') const fs = require('fs-extra') const ip = require('ip') const URL = require('url').URL const config = require('../lib/config') const util = require('../lib/util') const whitelistedUrlPrefixes = require('./whitelistedUrlPrefixes') const start = (passthroughArgs, buildConfig = config.default...
1
5,630
Deleting the files before starting the audit helps avoid stale results if the new file is not created.
brave-brave-browser
js
@@ -70,14 +70,8 @@ func (c *Controller) spcEventHandler(operation string, spcGot *apis.StoragePoolC // CreateStoragePool function will create the storage pool // It is a create event so resync should be false and pendingPoolcount is passed 0 // pendingPoolcount is not used when resync is false. - var newSpcLe...
1
/* Copyright 2018 The OpenEBS Authors Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, soft...
1
9,639
Remove this blank line
openebs-maya
go
@@ -23,12 +23,19 @@ import com.google.api.codegen.discovery.Schema.Format; import com.google.api.codegen.discovery.Schema.Type; import com.google.api.codegen.transformer.ImportTypeTable; import com.google.api.codegen.util.Name; +import com.google.api.codegen.util.SymbolTable; import com.google.api.codegen.util.Type...
1
/* Copyright 2017 Google LLC * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * https://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in...
1
25,374
This is... quite unconventional (use a map entry as a key). I would suggest making your own data class for the key.
googleapis-gapic-generator
java
@@ -213,7 +213,11 @@ class OutputList(RecycleView): res = [] for o in outputs: value = self.app.format_amount_and_units(o.value) - res.append({'address': o.get_ui_address_str(), 'value': value}) + res.append({ + 'address': o.get_ui_address_str(), +...
1
from typing import TYPE_CHECKING, Sequence from kivy.app import App from kivy.clock import Clock from kivy.factory import Factory from kivy.properties import NumericProperty, StringProperty, BooleanProperty from kivy.core.window import Window from kivy.uix.recycleview import RecycleView from kivy.uix.boxlayout import ...
1
13,393
why are these colors needed to be specified here? when are they used?
spesmilo-electrum
py
@@ -139,7 +139,12 @@ abstract class BaseMetadataTable implements Table { @Override public Rollback rollback() { - throw new UnsupportedOperationException("Cannot roll back a metadata table"); + throw new UnsupportedOperationException("Cannot rollback snapshots from a metadata table"); + } + + @Override ...
1
/* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you ...
1
17,201
Nit: no need to change this method.
apache-iceberg
java
@@ -19,11 +19,15 @@ import inspect # pylint: disable=line-too-long from google.cloud.forseti.common.util import logger from google.cloud.forseti.common.util import string_formats +from google.cloud.forseti.services.inventory.storage import DataAccess + from google.cloud.forseti.notifier.notifiers.base_notification ...
1
# Copyright 2017 The Forseti Security Authors. All rights reserved. # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by ap...
1
33,097
Why a blank line?
forseti-security-forseti-security
py
@@ -103,7 +103,7 @@ <h2><%= _('Request expert feedback') %></h2> <p><%= _('Click below to give data management staff at your organisation access to read and comment on your plan.') %></p> <div class="well well-sm"> - <%= current_user.org.feedback_email_msg.html_safe %> + <%= current_u...
1
<h2><%= _('Set plan visibility') %></h2> <p class="form-control-static"><%= _('Public or organisational visibility is intended for finished plans. You must answer at least %{percentage}%% of the questions to enable these options. Note: test plans are set to private visibility by default.') % { :percentage => Rails.appl...
1
17,844
Why remove the `.html_safe` here? Should we use `sanitize` or `raw` instead? This info comes off of the org edit page and is entered by users.
DMPRoadmap-roadmap
rb
@@ -383,7 +383,7 @@ get_dr_stats(void) * returns zero on success, non-zero on failure */ DYNAMORIO_EXPORT int -dynamorio_app_init(void) +dynamorio_app_init(bool attach_case) { int size;
1
/* ********************************************************** * Copyright (c) 2010-2019 Google, Inc. All rights reserved. * Copyright (c) 2000-2010 VMware, Inc. All rights reserved. * **********************************************************/ /* * Redistribution and use in source and binary forms, with or witho...
1
18,013
I think we need some docs about how to set this parameter correctly. Are we OK with changing the public API like this? We probably at least want to make a change notice to the release doc.
DynamoRIO-dynamorio
c
@@ -329,10 +329,13 @@ type ProtocolTag byte const ( ProtocolHeartbeat ProtocolTag = iota - ProtocolOverlayControlMsg + ProtocolConnectionEstablished + ProtocolFragmentationReceived + ProtocolPMTUVerified ProtocolGossip ProtocolGossipUnicast ProtocolGossipBroadcast + ProtocolOverlayControlMsg ) type Proto...
1
package router import ( "bytes" "encoding/gob" "encoding/hex" "fmt" "io" "time" ) const ( Protocol = "weave" ProtocolMinVersion = 1 ProtocolMaxVersion = 2 ) var ( ProtocolBytes = []byte(Protocol) HeaderTimeout = 10 * time.Second ProtocolV1Features = []string{ "ConnID", "Name", "NickName...
1
11,030
When we undo this for 1.3, do we not need to leave these three entries intact to avoid renumbering of the subsequent constants? If so perhaps the changes to this file should be pulled into a separate initial commit so we can just `git revert` the remainder...
weaveworks-weave
go
@@ -60,5 +60,9 @@ func (a *API) Setup() { a.removeUnusedShapes() } + if !a.NoValidataShapeMethods { + a.addShapeValidations() + } + a.initialized = true }
1
package api import ( "encoding/json" "os" "path/filepath" ) // Load takes a set of files for each filetype and returns an API pointer. // The API will be initialized once all files have been loaded and parsed. // // Will panic if any failure opening the definition JSON files, or there // are unrecognized exported ...
1
7,848
This is never set anywhere in the `cli/gen-api` folder. Should it be?
aws-aws-sdk-go
go
@@ -23,13 +23,13 @@ import ( "sync" "time" - v1 "k8s.io/api/core/v1" + corev1 "k8s.io/api/core/v1" "k8s.io/apimachinery/pkg/api/resource" metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" kubeinformers "k8s.io/client-go/informers" "k8s.io/client-go/kubernetes" "k8s.io/client-go/kubernetes/scheme" - corev1 "...
1
/* Copyright 2019 The Jetstack cert-manager contributors. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed...
1
23,144
All the changes in this commit are mechanical. Produced by the script in the previous commit.
jetstack-cert-manager
go
@@ -76,7 +76,7 @@ module Travis true when 'server_error' cmd 'echo -e "\033[31;1mCould not fetch .travis.yml from GitHub.\033[0m"', assert: false, echo: false - cmd 'travis_terminate 2', assert: false, echo: false + raw 'travis_terminate 2', assert: false, echo...
1
require 'core_ext/hash/deep_merge' require 'core_ext/hash/deep_symbolize_keys' require 'core_ext/object/false' require 'erb' module Travis module Build class Script autoload :Addons, 'travis/build/script/addons' autoload :Android, 'travis/build/script/android' autoload :C, ...
1
11,720
What's the difference between these 2 versions?
travis-ci-travis-build
rb
@@ -224,7 +224,7 @@ class KMSScannerTest(unittest_utils.ForsetiTestCase): self.scanner.run() crypto_key = self.scanner._retrieve() violations = self.scanner._find_violations(crypto_key) - self.assertEquals(1, len(violations)) + self.assertEquals(6, len(violations)) self...
1
# Copyright 2017 The Forseti Security Authors. All rights reserved. # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by ap...
1
34,060
@red2k18 Are we sure its correct to only have 1 now?
forseti-security-forseti-security
py
@@ -151,6 +151,7 @@ void AddFragToMol(RWMol *mol, RWMol *frag, Bond::BondType bondOrder, newB->setOwningMol(mol); newB->setBeginAtomIdx(atomIdx1); newB->setEndAtomIdx(atomIdx2); + newB->setProp(RDKit::common_properties::_unspecifiedOrder, 1); mol->addBond(newB); delet...
1
// // Copyright (C) 2001-2020 Greg Landrum and Rational Discovery LLC // // @@ All Rights Reserved @@ // This file is part of the RDKit. // The contents are covered by the terms of the BSD license // which is included in the file license.txt, found at the root // of the RDKit source tree. // #include <GraphMol/R...
1
21,456
@greglandrum interesting, is this related to #3307 by any chance?
rdkit-rdkit
cpp
@@ -48,7 +48,15 @@ class ApplicationController < ActionController::Base private def current_user - @current_user ||= User.find_or_create_by(email_address: session[:user]['email']) if session[:user] && session[:user]['email'] + @current_user ||= find_current_user + end + + def find_current_user + if E...
1
class ApplicationController < ActionController::Base include Pundit # For authorization checks include ReturnToHelper include MarkdownHelper helper ValueHelper add_template_helper ClientHelper protect_from_forgery with: :exception helper_method :current_user, :signed_in?, :return_to before_action ...
1
14,100
Minor: how about moving the trailing `if` to an `elsif` above?
18F-C2
rb
@@ -321,6 +321,8 @@ class DBUpgrader { db.execSQL("UPDATE " + PodDBAdapter.TABLE_NAME_FEED_ITEMS + " SET content_encoded = NULL"); db.execSQL("ALTER TABLE " + PodDBAdapter.TABLE_NAME_FEEDS + " ADD COLUMN " + PodDBAdapter.KEY_FEED_TAGS + " TEXT;"); + db.execSQL("...
1
package de.danoeh.antennapod.core.storage; import android.content.ContentValues; import android.database.Cursor; import android.database.sqlite.SQLiteDatabase; import android.media.MediaMetadataRetriever; import android.util.Log; import de.danoeh.antennapod.model.feed.FeedItem; import static de.danoeh.antennapod.mod...
1
20,843
That's only executed when users switch from 2.2 to 2.3. Please create a new block with code `2050000` for the next release :) Please also adapt the version number in PodDbAdapter
AntennaPod-AntennaPod
java
@@ -351,6 +351,16 @@ func (c *client) sendConnect(tlsRequired bool) { // Process the info message if we are a route. func (c *client) processRouteInfo(info *Info) { + // We may need to update route permissions and will need the account + // sublist. Since getting the account requires server lock, do the + // lookup...
1
// Copyright 2013-2018 The NATS Authors // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to ...
1
8,558
Safe to reference c.srv without capturing it first under a client lock?
nats-io-nats-server
go
@@ -1,3 +1,19 @@ +/* +Copyright 2018 The Kubernetes Authors. + +Licensed under the Apache License, Version 2.0 (the "License"); +you may not use this file except in compliance with the License. +You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable la...
1
package actuators import ( "github.com/aws/aws-sdk-go/service/ec2/ec2iface" "github.com/aws/aws-sdk-go/service/elb/elbiface" ) // AWSClients contains all the aws clients used by the scopes. type AWSClients struct { EC2 ec2iface.EC2API ELB elbiface.ELBAPI }
1
7,422
@vincepri blame tells me this was you, any objections to the change?
kubernetes-sigs-cluster-api-provider-aws
go
@@ -0,0 +1,19 @@ +package main + +import ( + "net/http" + "time" + + "github.com/yarpc/yarpc-go/crossdock/client" + "github.com/yarpc/yarpc-go/crossdock/server" +) + +func main() { + // TODO need to be able to wait till all inbounds are finished listening + go server.StartServerUnderTest() + // TODO maybe sleep? + time...
1
1
9,158
@abhinav here is where i need to be able to block/wait until the server is started
yarpc-yarpc-go
go
@@ -64,6 +64,9 @@ public class MetricsServlet extends HttpServlet { /** * Returns the name of the parameter used to specify the jsonp callback, if any. + * + * @return the name of the parameter used to specify the jsonp callback, or <code>null</code>, if + * no suc...
1
package com.codahale.metrics.servlets; import java.io.IOException; import java.io.OutputStream; import java.util.Locale; import java.util.concurrent.TimeUnit; import javax.servlet.ServletConfig; import javax.servlet.ServletContext; import javax.servlet.ServletContextEvent; import javax.servlet.ServletContextListener;...
1
6,605
It seems to me as an unrelated change. Could you please revert it?
dropwizard-metrics
java
@@ -0,0 +1,3 @@ +package iface + +type DaemonAPI interface{}
1
1
13,485
~Why are putting all these APIs in their own ~packages~ files? So many more ~directories~ files, to what end? Why not just have them all be a part of the same API file and all live alongside each other so you can easily see them?~ Edit: nevermind, probably works best in separate files.
filecoin-project-venus
go
@@ -32,6 +32,10 @@ import static com.github.javaparser.StaticJavaParser.parseClassOrInterfaceType; */ public interface NodeWithExtends<N extends Node> { + /** + * @return All extended types that have been explicitly added. + * Note that this will not include {@code java.lang.Object} unless it is expli...
1
/* * Copyright (C) 2007-2010 Júlio Vilmar Gesser. * Copyright (C) 2011, 2013-2020 The JavaParser Team. * * This file is part of JavaParser. * * JavaParser can be used either under the terms of * a) the GNU Lesser General Public License as published by * the Free Software Foundation, either version 3 of the ...
1
14,103
This likely needs to be double checked -- I recall being convinced at the time of writing this, but now I am less sure
javaparser-javaparser
java
@@ -56,7 +56,7 @@ func main() { if csv { // produce a csv report - fmt.Printf("Module Name,Module Path,Whitelisted,License Path,License Name,Confidence,Exact Match,Similar To,Similarity Confidence,State\n") + fmt.Printf("Module Name,Module Path,Whitelisted,License Path,License Name,Confidence,Similar To,Simila...
1
// Copyright Istio Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to in wri...
1
8,533
For a followup - it is better to use acceptlist/denylist. I realize this is a historical artifact of our codebase.
istio-tools
go
@@ -77,6 +77,13 @@ import org.apache.commons.io.FileUtils; import java.util.zip.GZIPInputStream; import java.util.zip.ZipEntry; import java.util.zip.ZipInputStream; +import static edu.harvard.iq.dataverse.datasetutility.FileSizeChecker.bytesToHumanReadable; +import static edu.harvard.iq.dataverse.datasetutility.File...
1
/* Copyright (C) 2005-2012, by the President and Fellows of Harvard College. Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unle...
1
39,313
Looks like glassfish went a bit nuts doing a refactor
IQSS-dataverse
java
@@ -47,4 +47,12 @@ describe('dom.visuallyContains', function () { assert.isTrue(axe.commons.dom.visuallyContains(target, target.parentNode)); }); + it('should return true when element is inline', function () { + // result depends on the display property of the element + fixture.innerHTML = '<label>' + + 'My ...
1
describe('dom.visuallyContains', function () { 'use strict'; var fixture = document.getElementById('fixture'); afterEach(function () { document.getElementById('fixture').innerHTML = ''; }); it('should return true when element is trivially contained', function () { fixture.innerHTML = '<div style="height: 40...
1
11,014
Couldn't you use position:absolute or float to move inline elements outside their parent? Through clipping an child element can also be outside it's parent. There are probably some other ways to do it too. So I'm not sure the assumption you're making here is right.
dequelabs-axe-core
js
@@ -78,7 +78,7 @@ public class ExpireSnapshotsProcedure extends BaseProcedure { @Override public InternalRow[] call(InternalRow args) { Identifier tableIdent = toIdentifier(args.getString(0), PARAMETERS[0].name()); - Long olderThanMillis = args.isNullAt(1) ? null : DateTimeUtils.toMillis(args.getLong(1));...
1
/* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you ...
1
36,038
This could be copied into iceberg code to avoid the spark internal dep? We could use a version check to adjust the method used if needed.
apache-iceberg
java
@@ -254,7 +254,7 @@ static void subprocess_destroy_finish (flux_future_t *f, void *arg) if (flux_future_get (f, NULL) < 0) { flux_t *h = flux_subprocess_aux_get (p, "flux_t"); flux_log_error (h, "subprocess_kill: %ju: %s", - (uintmax_t) flux_subprocess_pid, + ...
1
/************************************************************\ * Copyright 2019 Lawrence Livermore National Security, LLC * (c.f. AUTHORS, NOTICE.LLNS, COPYING) * * This file is part of the Flux resource manager framework. * For details, see https://github.com/flux-framework. * * SPDX-License-Identifier: LGPL-3....
1
30,335
This one had me stumped!
flux-framework-flux-core
c
@@ -190,10 +190,7 @@ class SettingsAdmin extends Component { googlesitekit-settings-module__meta-item googlesitekit-settings-module__meta-item--nomargin "> - <Optin - id="opt-in" - name="optin" - /> + <Optin /> </...
1
/** * SettingsOverview component. * * Site Kit by Google, Copyright 2019 Google LLC * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * https://www.apache.org/licenses/LICENSE-2....
1
25,296
Note that this name differs from the name used as default (and thus used now that you removed this). That should be fine, but wanted to flag it.
google-site-kit-wp
js
@@ -388,12 +388,17 @@ abstract class AbstractCrudController extends AbstractController implements Crud public function autocomplete(AdminContext $context): JsonResponse { - $queryBuilder = $this->createIndexQueryBuilder($context->getSearch(), $context->getEntity(), FieldCollection::new([]), FilterCol...
1
<?php namespace EasyCorp\Bundle\EasyAdminBundle\Controller; use Doctrine\DBAL\Exception\ForeignKeyConstraintViolationException; use Doctrine\ORM\EntityManagerInterface; use Doctrine\ORM\QueryBuilder; use EasyCorp\Bundle\EasyAdminBundle\Collection\FieldCollection; use EasyCorp\Bundle\EasyAdminBundle\Collection\FilterC...
1
12,811
Why public and not protected?
EasyCorp-EasyAdminBundle
php
@@ -51,7 +51,7 @@ locals: {current_org: current_org.id, published: published, scopes: scopes[:all], hide_actions: true}) %> </div> <% end %> - <div id="organisation-templates" role="tabpanel" class="tab-pane<%= !current_user.can_super_admin? || current_tab == 'organisation-templates' ?...
1
<% # locals: funder_templates, org_templates, current_user, current_org, orgs, current_tab %> <div class="row"> <div class="col-md-12"> <h1><%= _('Templates') %></h1> </div> <% if current_user.can_super_admin? %> <div class="col-md-12"> <p><%= _('If you would like to modify one of the templates belo...
1
17,442
We definitely need to address this duplication after MVP
DMPRoadmap-roadmap
rb
@@ -113,6 +113,12 @@ export default function UserInputKeywords( { slug, max } ) { return ( <Cell lgStart={ 6 } lgSize={ 6 } mdSize={ 8 } smSize={ 4 }> <div ref={ keywordsContainer } className="googlesitekit-user-input__text-options"> + <label + htmlFor={ `${ slug }-keyword-0` } + className="screen-r...
1
/** * User Input Keywords. * * Site Kit by Google, Copyright 2021 Google LLC * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * https://www.apache.org/licenses/LICENSE-2.0 * *...
1
36,743
This will always generate a label for the first keyword, which means this will be a label linked to no element after the first keyword is entered. This label should be generated inside the `values.map` next to the `<TextField><Input /></TextField>` it is for, because the ID changes based on the index. Also, we have a `...
google-site-kit-wp
js
@@ -323,6 +323,14 @@ struct roots_desktop *desktop_create(struct roots_server *server, desktop->server = server; desktop->config = config; + + desktop->xcursor_theme = roots_xcursor_theme_create("default"); + if (desktop->xcursor_theme == NULL) { + wlr_list_free(desktop->views); + free(desktop); + return NULL;...
1
#define _POSIX_C_SOURCE 199309L #include <assert.h> #include <time.h> #include <stdlib.h> #include <math.h> #include <wlr/types/wlr_box.h> #include <wlr/types/wlr_compositor.h> #include <wlr/types/wlr_cursor.h> #include <wlr/types/wlr_gamma_control.h> #include <wlr/types/wlr_server_decoration.h> #include <wlr/types/wlr...
1
9,047
Does it make sense for this to be fatal? Could there be an embedded application that does not have xcursor themes at all? For instance, compositors without a pointer (like a touch-screen kiosk) will never show a cursor. I think I'm ok with this assumption since it simplifies the code and rootston is assumed to have des...
swaywm-wlroots
c
@@ -0,0 +1,15 @@ +using Nethermind.Core; + +namespace Nethermind.Blockchain.Filters.Topics +{ + public abstract class TopicsFilterBase + { + public abstract bool Accepts(LogEntry entry); + + public abstract bool Accepts(ref LogEntryStructRef entry); + + public abstract bool Matches(Bloom bloo...
1
1
24,624
would rename to TopicsFilter and original one to SequenceTopicsFilter
NethermindEth-nethermind
.cs
@@ -240,7 +240,7 @@ class MPLPlot(DimensionedPlot): def update(self, key): - if len(self) == 1 and key == 0 and not self.drawn: + if len(self) == 1 and ((key == 0) or (key == self.keys[0])) and not self.drawn: return self.initialize_plot() return self.__getitem__(key)
1
from __future__ import division from itertools import chain from contextlib import contextmanager import numpy as np import matplotlib as mpl from mpl_toolkits.mplot3d import Axes3D # noqa (For 3D plots) from matplotlib import pyplot as plt from matplotlib import gridspec, animation import param from ...core import ...
1
20,308
Is the idea that ``self.keys[0]`` here normally matches ``init_key``?
holoviz-holoviews
py
@@ -262,6 +262,11 @@ class UIAHandler(COMObject): eventHandler.queueEvent(NVDAEventName,obj) def _isUIAWindowHelper(self,hwnd): + if hwnd == winUser.getDesktopWindow(): + # #6301: In Windows 10 build >= 14901, + # calling UiaHasServerSideProvider with the desktop window sometimes freezes when bringing up NV...
1
from ctypes import * from ctypes.wintypes import * import comtypes.client from comtypes.automation import VT_EMPTY from comtypes import * import weakref import threading import time import api import appModuleHandler import queueHandler import controlTypes import NVDAHelper import winKernel import winUser...
1
18,555
Can this be clarified to "Exit early when hwnd is the windows desktop handle, UiaHasServerSideProvider would return false anyway." ?
nvaccess-nvda
py
@@ -72,11 +72,11 @@ type Task struct { Containers []*Container // Volumes are the volumes for the task Volumes []TaskVolume `json:"volumes"` - // VCPULimit is a task-level limit for compute resources. A value of 1 means that + // Cpu is a task-level limit for compute resources. A value of 1 means that // the ta...
1
// Copyright 2014-2017 Amazon.com, Inc. or its affiliates. All Rights Reserved. // // Licensed under the Apache License, Version 2.0 (the "License"). You may // not use this file except in compliance with the License. A copy of the // License is located at // // http://aws.amazon.com/apache2.0/ // // or in the "license...
1
17,631
I'm okay with leaving VCPULimit and MemoryLimit on our internal model
aws-amazon-ecs-agent
go
@@ -73,6 +73,10 @@ const ( defaultWorkers = 4 // Default rule priority for K8s NetworkPolicy rules. defaultRulePriority = -1 + // TierIndex is used to index ClusterNetworkPolicies by Tier names. + TierIndex = "tier" + // maxSupportedTiers is the maximum number of supported Tiers. + maxSupportedTiers = 10 ) va...
1
// Copyright 2019 Antrea Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to ...
1
20,675
5 or 10?
antrea-io-antrea
go
@@ -27,6 +27,10 @@ internal class MyExporter : ActivityExporter public override Task<ExportResult> ExportAsync( IEnumerable<Activity> batch, CancellationToken cancellationToken) { + // Exporter code which can generate further + // telemetry should do so inside SuppressInstrumentation + ...
1
// <copyright file="MyExporter.cs" company="OpenTelemetry Authors"> // Copyright The OpenTelemetry Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apa...
1
16,151
Should we explain more here?
open-telemetry-opentelemetry-dotnet
.cs
@@ -30,9 +30,10 @@ import ( // ec2Svc are the functions from the ec2 service, not the client, this actuator needs. // This should never need to import the ec2 sdk. type ec2Svc interface { - CreateInstance(*clusterv1.Machine) (*ec2svc.Instance, error) + CreateInstance(*clusterv1.Machine, *v1alpha1.AWSMachineProviderC...
1
// Copyright © 2018 The Kubernetes Authors. // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or ag...
1
6,306
I've been struggling with this on my cloud-init integration work as well. In addition to info that is currently stored in the cluster providerstatus, we also need some of the info that is available within the base cluster object as well. I think it would make sense to unify the machine and cluster info needed into a co...
kubernetes-sigs-cluster-api-provider-aws
go
@@ -17,7 +17,9 @@ import java.util.Map; * UIs without the package prefixes. * * @author Brian Remedios + * @deprecated Is internal API */ +@Deprecated public final class ClassUtil { public static final Class<?>[] EMPTY_CLASS_ARRAY = new Class[0];
1
/** * BSD-style license; for more info see http://pmd.sourceforge.net/license.html */ package net.sourceforge.pmd.util; import java.lang.reflect.Method; import java.math.BigDecimal; import java.util.ArrayList; import java.util.HashMap; import java.util.List; import java.util.Map; /** * Various class-related utili...
1
16,679
Why not `@InternalApi`?
pmd-pmd
java
@@ -22,6 +22,11 @@ import datetime import decimal from inspect import getfullargspec, isclass +try: + from typing import _GenericAlias # type: ignore +except ImportError: + from typing import GenericMeta as _GenericAlias # type: ignore + import numpy as np import pandas as pd from pandas.api.types import...
1
# # Copyright (C) 2019 Databricks, Inc. # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by applicable law or agreed to i...
1
16,942
FYI: `GenericMeta` is renamed to `_GenericAlias` in Python3.7.
databricks-koalas
py
@@ -63,7 +63,7 @@ <% unless phase.sections.all?(&:modifiable?) %> <%= _("You may place them before or after the main template sections.") %> <% end %> - <% else %> + <% elsif template.latest? %> ...
1
<% title "#{template.title}" %> <% modifiable = template.latest? && !template.customization_of.present? && template.id.present? && (template.org_id = current_user.org.id) %> <div class="row"> <div class="col-md-12"> <h1><%= template.title %></h1> <% referrer = template.customization_of.present? ? customisable...
1
19,014
So this hides the link to re-order sections on Historic Templates? Good catch, Just checked on DMPonline and hitting that throws a 404
DMPRoadmap-roadmap
rb
@@ -69,7 +69,7 @@ module RSpec # same process. def self.clear_examples world.reset - configuration.reporter.reset + configuration.reset_reporter configuration.start_time = ::RSpec::Core::Time.now configuration.reset_filters end
1
# rubocop:disable Style/GlobalVars $_rspec_core_load_started_at = Time.now # rubocop:enable Style/GlobalVars require "rspec/support" RSpec::Support.require_rspec_support "caller_filter" RSpec::Support.define_optimized_require_for_rspec(:core) { |f| require_relative f } %w[ version warnings set flat_map fi...
1
16,585
Is `Reporter#reset` no longer used? If so, can we remove it?
rspec-rspec-core
rb
@@ -188,7 +188,7 @@ public final class EthHash { out.writeLongScalar(header.getTimestamp()); out.writeBytes(header.getExtraData()); if (header.getBaseFee().isPresent()) { - out.writeLongScalar(header.getBaseFee().get()); + out.writeUInt256Scalar(header.getBaseFee().get()); } out.endLi...
1
/* * Copyright ConsenSys AG. * * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with * the License. You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing...
1
26,687
same concern here about difference in the write scalar implementation. I am not sure if this could present a consensus problem or not
hyperledger-besu
java
@@ -0,0 +1,7 @@ +using UIKit; +using MvvmCross.Core.ViewModels; + +namespace MvvmCross.tvOS.Views +{ + public interface IMvxSplitViewController : IMvxTvosView { } +}
1
1
13,512
Can we remove this file?
MvvmCross-MvvmCross
.cs
@@ -799,7 +799,7 @@ func (c *Operator) sync(ctx context.Context, key string) error { if ok && sErr.ErrStatus.Code == 422 && sErr.ErrStatus.Reason == metav1.StatusReasonInvalid { c.metrics.StsDeleteCreateCounter().Inc() - level.Info(c.logger).Log("msg", "resolving illegal update of Alertmanager StatefulSet", "de...
1
// Copyright 2016 The prometheus-operator Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable ...
1
16,190
Why listing only first error reason (`ErrStatus.Details.Causes[0].Message`)?
prometheus-operator-prometheus-operator
go
@@ -77,6 +77,17 @@ public interface RewriteDataFiles extends SnapshotUpdate<RewriteDataFiles, Rewri */ String TARGET_FILE_SIZE_BYTES = "target-file-size-bytes"; + /** + * If the compaction should use the sequence number of the snapshot at compaction start time for new data files, + * instead of using the ...
1
/* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you ...
1
45,799
Now that this is true, do we have to ignore it with V1 Tables?
apache-iceberg
java
@@ -87,6 +87,12 @@ Blockly.Css.inject = function(hasCss, pathToMedia) { // Strip off any trailing slash (either Unix or Windows). Blockly.Css.mediaPath_ = pathToMedia.replace(/[\\\/]$/, ''); text = text.replace(/<<<PATH>>>/g, Blockly.Css.mediaPath_); + // Dynamically replace colours in the CSS text, in case t...
1
/** * @license * Visual Blocks Editor * * Copyright 2013 Google Inc. * https://developers.google.com/blockly/ * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apach...
1
7,648
prefer if (condition) { stuff; } to if !(condition) { continue; } stuff
LLK-scratch-blocks
js
@@ -1,11 +1,8 @@ -<h1><%= h(@title) %></h1> - -<% content_for :head do %> -<%= auto_discovery_link_tag :atom, :action => 'georss', :display_name => @display_name, :tag => @tag %> -<% end %> - -<p> - <%= rss_link_to :action => 'georss', :display_name => @display_name, :tag => @tag %> +<% content_for :heading do %> + <...
1
<h1><%= h(@title) %></h1> <% content_for :head do %> <%= auto_discovery_link_tag :atom, :action => 'georss', :display_name => @display_name, :tag => @tag %> <% end %> <p> <%= rss_link_to :action => 'georss', :display_name => @display_name, :tag => @tag %> | <%= link_to t('trace.trace_header.upload_trace'), :actio...
1
7,999
Should this section not be converted to a secondary action list?
openstreetmap-openstreetmap-website
rb
@@ -225,8 +225,17 @@ class CommandDispatcher: count: The tab index to close, or None """ tab = self._cntwidget(count) + result = True if tab is None: return + + if tab.pin is True: + result = message.ask("Are you sure you want to close a pinn...
1
# vim: ft=python fileencoding=utf-8 sts=4 sw=4 et: # Copyright 2014-2016 Florian Bruhin (The Compiler) <mail@qutebrowser.org> # # This file is part of qutebrowser. # # qutebrowser is free software: you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by # the Free S...
1
16,978
This askes a blocking question, which means a local Qt eventloop will be running. While this is unavoidable sometimes, the async functions should be used whenever possible (`message.confirm_async` in this case). This means: - Split everything after this question in a separate private method (you can probably just call ...
qutebrowser-qutebrowser
py
@@ -28,7 +28,7 @@ define(["jQuery", "loading", "libraryMenu", "fnchecked"], function($, loading, l IsHidden: !1 })).then(function(folders) { loadDeleteFolders(page, user, folders.Items) - }), user.Policy.IsDisabled ? $(".disabledUserBanner", page).show() : $(".disabledUserBanne...
1
define(["jQuery", "loading", "libraryMenu", "fnchecked"], function($, loading, libraryMenu) { "use strict"; function loadDeleteFolders(page, user, mediaFolders) { ApiClient.getJSON(ApiClient.getUrl("Channels", { SupportsMediaDeletion: !0 })).then(function(channelsResult) { ...
1
10,983
Can we deuglify this?
jellyfin-jellyfin-web
js
@@ -177,7 +177,7 @@ public interface Option<T> extends Value<T>, Serializable { */ default <R> Option<R> collect(PartialFunction<? super T, ? extends R> partialFunction) { Objects.requireNonNull(partialFunction, "partialFunction is null"); - return filter(partialFunction::isDefinedAt).map(par...
1
/* __ __ __ __ __ ___ * \ \ / / \ \ / / __/ * \ \/ / /\ \ \/ / / * \____/__/ \__\____/__/.ɪᴏ * ᶜᵒᵖʸʳᶦᵍʰᵗ ᵇʸ ᵛᵃᵛʳ ⁻ ˡᶦᶜᵉⁿˢᵉᵈ ᵘⁿᵈᵉʳ ᵗʰᵉ ᵃᵖᵃᶜʰᵉ ˡᶦᶜᵉⁿˢᵉ ᵛᵉʳˢᶦᵒⁿ ᵗʷᵒ ᵈᵒᵗ ᶻᵉʳᵒ */ package io.vavr.control...
1
12,404
@skestle Just recognized that the `::apply` is not necessary. Does it compile if you leave it away? Could you please check that, I'm on vacation and have no IDE at hand... Thx!
vavr-io-vavr
java
@@ -366,7 +366,8 @@ public class TestMergeAppend extends TableTestBase { 1, base.currentSnapshot().manifests().size()); ManifestFile initialManifest = base.currentSnapshot().manifests().get(0); - // build the new spec using the table's schema, which uses fresh IDs + // build the new spec using the...
1
/* * Licensed to the Apache Software Foundation (ASF) under one * or more contributor license agreements. See the NOTICE file * distributed with this work for additional information * regarding copyright ownership. The ASF licenses this file * to you under the Apache License, Version 2.0 (the * "License"); you ...
1
17,133
Looks like this is an unnecessary change.
apache-iceberg
java
@@ -290,7 +290,7 @@ class CrawlerTest(CrawlerBase): 'disk': {'resource': 3}, 'firewall': {'resource': 3}, 'folder': {'iam_policy': 2, 'resource': 2}, - 'forwardingrule': {'resource': 1}, + 'forwardingrule': {'resource': 2}, 'instance': {'resource...
1
# Copyright 2017 The Forseti Security Authors. All rights reserved. # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 # # Unless required by ap...
1
34,036
This one won't change as the resource is not included in the project getting tested with the composite root.
forseti-security-forseti-security
py
@@ -336,6 +336,7 @@ static CALI_BPF_INLINE int calico_tc(struct __sk_buff *skb) .reason = CALI_REASON_UNKNOWN, }; struct calico_nat_dest *nat_dest = NULL; + __u8 nat_lvl1_drop = 0; /* we assume we do FIB and from this point on, we only set it to false * if we decide not to do it.
1
// Project Calico BPF dataplane programs. // Copyright (c) 2020 Tigera, Inc. All rights reserved. // // This program is free software; you can redistribute it and/or modify // it under the terms of the GNU General Public License as published by // the Free Software Foundation; either version 2 of the License, or // (at...
1
17,892
We have `stdbool` imported, might as well use that for clarity.
projectcalico-felix
go
@@ -30,8 +30,8 @@ namespace Datadog.Trace.ClrProfiler.IntegrationTests Assert.True(spans.Count > 0, "expected at least one span"); foreach (var span in spans) { - Assert.Equal(SqlServerIntegration.OperationName, span.Name); - Asser...
1
using Datadog.Trace.ClrProfiler.Integrations; using Datadog.Trace.TestHelpers; using Xunit; using Xunit.Abstractions; // EFCore targets netstandard2.0, so it requires net461 or higher or netcoreapp2.0 or higher #if !NET452 namespace Datadog.Trace.ClrProfiler.IntegrationTests { public class SqlServerTests : TestHe...
1
14,590
Why do we not also have integration tests for postgres?
DataDog-dd-trace-dotnet
.cs
@@ -205,7 +205,7 @@ describe('Db', function() { /** * An example showing how to force a reindex of a collection. */ - it('shouldCorrectlyForceReindexOnCollection', { + it.skip('shouldCorrectlyForceReindexOnCollection', { metadata: { requires: { topology: ['single'] } },
1
'use strict'; var test = require('./shared').assert; var setupDatabase = require('./shared').setupDatabase; const expect = require('chai').expect; const { Db, DBRef } = require('../..'); describe('Db', function() { before(function() { return setupDatabase(this.configuration); }); it('shouldCorrectlyHandleIl...
1
17,702
I think its safe to remove this if we're removing `reIndex` outright. The description shows us that the test is "An example showing how to force a reindex of a collection"
mongodb-node-mongodb-native
js
@@ -43,6 +43,7 @@ const ( EEXIST Errno = 0x11 EINTR Errno = 0x4 ENOTDIR Errno = 0x14 + EINVAL Errno = 22 EMFILE Errno = 0x18 EAGAIN Errno = 0x23 ETIMEDOUT Errno = 0x3c
1
// +build darwin package syscall // This file defines errno and constants to match the darwin libsystem ABI. // Values have been copied from src/syscall/zerrors_darwin_amd64.go. // This function returns the error location in the darwin ABI. // Discovered by compiling the following code using Clang: // // #includ...
1
12,950
Can you make this hexadecimal to match the other constants?
tinygo-org-tinygo
go
@@ -209,12 +209,5 @@ module Bolt Bolt::Logger.warn("missing_project_name", message) end end - - def check_deprecated_file - if (@path + 'project.yaml').file? - msg = "Project configuration file 'project.yaml' is deprecated; use 'bolt-project.yaml' instead." - Bolt::Logger.warn...
1
# frozen_string_literal: true require 'pathname' require 'bolt/config' require 'bolt/validator' require 'bolt/pal' require 'bolt/module' module Bolt class Project BOLTDIR_NAME = 'Boltdir' CONFIG_NAME = 'bolt-project.yaml' attr_reader :path, :data, :inventory_file, :hiera_config, :puppe...
1
18,580
Can this get moved to `Bolt::Project#validate`?
puppetlabs-bolt
rb
@@ -426,7 +426,15 @@ public interface List<T> extends Seq<T>, Stack<T> { @Override default Tuple2<List<T>, List<T>> partition(Predicate<? super T> predicate) { Objects.requireNonNull(predicate, "predicate is null"); - return Tuple.of(filter(predicate), filter(predicate.negate())); + Lis...
1
/* / \____ _ ______ _____ / \____ ____ _____ * / \__ \/ \ / \__ \ / __// \__ \ / \/ __ \ Javaslang * _/ // _\ \ \/ / _\ \\_ \/ // _\ \ /\ \__/ / Copyright 2014-2015 Daniel Dietrich * /___/ \_____/\____/\_____/____/\___\_____/_/ \_/____/ Licensed under the Apache License...
1
5,989
I'm pretty sure it doesn't harm, but don't we have a second pass here with the reverse() operation?
vavr-io-vavr
java
@@ -24,6 +24,7 @@ public interface CapabilityType { String PLATFORM = "platform"; String SUPPORTS_JAVASCRIPT = "javascriptEnabled"; String TAKES_SCREENSHOT = "takesScreenshot"; + String TAKES_HEAP_SNAPSHOT = "takesHeapSnapshot"; String VERSION = "version"; String SUPPORTS_ALERTS = "handlesAlerts"; St...
1
/* Copyright 2007-2010 Selenium committers Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing...
1
10,646
This is not a standard capability and should be hidden behind a vendor prefix: -chromium-takesHeapSnapshot
SeleniumHQ-selenium
py
@@ -144,9 +144,9 @@ trainer::execution_context_key_pair_t trainer::check_and_build_execution_context if(dynamic_cast<observer_ptr<sgd_training_algorithm>>(&alg) != nullptr) { /// @todo BVE FIXME Figure out how to get a good mini-batch size /// in here - context = make_unique<sgd_execution_contex...
1
//////////////////////////////////////////////////////////////////////////////// // Copyright (c) 2014-2016, Lawrence Livermore National Security, LLC. // Produced at the Lawrence Livermore National Laboratory. // Written by the LBANN Research Team (B. Van Essen, et al.) listed in // the CONTRIBUTORS file. <lbann-dev@l...
1
15,284
This shouldn't work with pointers -- prefer references unless you can meaningfully pass `nullptr`. The address-of operator here is clunky at best.
LLNL-lbann
cpp
@@ -140,7 +140,8 @@ func TestBuild(t *testing.T) { for _, t := range tests { switch t { case "atomic.go": - // Not supported due to unaligned atomic accesses. + // Requires GCC 11.2.0 or above for interface comparison. + // https://github.com/gcc-mirror/gcc/commit/f30dd607669212de135dec1f1d8a93b8954...
1
package main // This file tests the compiler by running Go files in testdata/*.go and // comparing their output with the expected output in testdata/*.txt. import ( "bufio" "bytes" "errors" "flag" "fmt" "io" "io/ioutil" "os" "os/exec" "path/filepath" "runtime" "strings" "sync" "testing" "time" "githu...
1
14,183
Sidenote: some day we'll drop the avr-gcc and avr-libc dependencies so that this case becomes supported.
tinygo-org-tinygo
go
@@ -619,6 +619,6 @@ public class TestFieldCacheVsDocValues extends LuceneTestCase { protected boolean codecAcceptsHugeBinaryValues(String field) { String name = TestUtil.getDocValuesFormat(field); - return !(name.equals("Memory")); // Direct has a different type of limit + return true; } }
1
/* * Licensed to the Apache Software Foundation (ASF) under one or more * contributor license agreements. See the NOTICE file distributed with * this work for additional information regarding copyright ownership. * The ASF licenses this file to You under the Apache License, Version 2.0 * (the "License"); you may ...
1
26,988
do we still need this method?
apache-lucene-solr
java
@@ -618,10 +618,14 @@ RETDesc *GenericUpdate::createOldAndNewCorrelationNames(BindWA *bindWA, NABoolea rd = new (bindWA->wHeap()) RETDesc(bindWA); } + /* if ((getOperatorType() != REL_UNARY_INSERT) || + getUpdateCKorUniqueIndexKey() || + ((getOperatorType() == REL_UNARY_INSERT) &&((Insert *)this)...
1
/********************************************************************** // @@@ START COPYRIGHT @@@ // // Licensed to the Apache Software Foundation (ASF) under one // or more contributor license agreements. See the NOTICE file // distributed with this work for additional information // regarding copyright ownership. ...
1
15,903
It's better to not leave this old code here... it just clutters things up and makes reading the code more confusing. We can always recover the old code from the repository if needed.
apache-trafodion
cpp
@@ -21,6 +21,8 @@ import com.google.common.base.Charsets; import com.google.common.io.ByteStreams; import com.google.common.net.MediaType; +import com.sun.org.glassfish.gmbal.ManagedObject; + import org.apache.http.Header; import org.apache.http.HttpEntity; import org.apache.http.HttpHost;
1
/* Copyright 2011 Selenium committers Copyright 2011 Software Freedom Conservancy Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 Unless required by...
1
11,531
Again, you don't want to depend on glassfish.
SeleniumHQ-selenium
js
@@ -1,6 +1,6 @@ FactoryGirl.define do factory :post do - association :account + association :account, factory: :account association :topic body { Faker::Lorem.sentence } sequence :created_at do |n|
1
FactoryGirl.define do factory :post do association :account association :topic body { Faker::Lorem.sentence } sequence :created_at do |n| Time.now + n end end end
1
7,189
This shouldn't be required. What was going on here?
blackducksoftware-ohloh-ui
rb
@@ -80,6 +80,7 @@ func (cp ConnectionPolicies) TLSConfig(ctx caddy.Context) *tls.Config { } return &tls.Config{ + MinVersion: tls.VersionTLS12, GetConfigForClient: func(hello *tls.ClientHelloInfo) (*tls.Config, error) { // filter policies by SNI first, if possible, to speed things up // when there may...
1
// Copyright 2015 Matthew Holt and The Caddy Authors // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicab...
1
15,761
Why add this here?
caddyserver-caddy
go
@@ -141,15 +141,15 @@ namespace AutoRest.CSharp.Model { if (ReturnType.Body != null && ReturnType.Headers != null) { - return $"Microsoft.Rest.HttpOperationResponse<{ReturnType.Body.AsNullableType(HttpMethod != HttpMethod.Head)},{ReturnType.Headers.AsNul...
1
// Copyright (c) Microsoft Corporation. All rights reserved. // Licensed under the MIT License. See License.txt in the project root for license information. using System; using System.Collections.Generic; using System.Globalization; using System.Linq; using System.Net; using System.Text.RegularExpressions; using AutoR...
1
23,839
nullability does not apply to headers type (that is always an object)
Azure-autorest
java
@@ -166,7 +166,7 @@ static fpga_result map_mmio_region(fpga_handle handle, uint32_t mmio_num) wsid = wsid_gen(); if (!wsid_add(&_handle->mmio_root, wsid, - (uint64_t) NULL, + (uint64_t) addr, (uint64_t) NULL, size, (uint64_t) addr,
1
// Copyright(c) 2017, Intel Corporation // // Redistribution and use in source and binary forms, with or without // modification, are permitted provided that the following conditions are met: // // * Redistributions of source code must retain the above copyright notice, // this list of conditions and the ...
1
14,630
Do we also need to add the iova, or is that done somewhere else?
OPAE-opae-sdk
c
@@ -19,9 +19,7 @@ package selector import "github.com/mysteriumnetwork/node/identity" -// Handler allows selecting identity to be used +// Handler interface type Handler interface { - UseExisting(address, passphrase string) (identity.Identity, error) - UseLast(passphrase string) (identity.Identity, error) - UseNe...
1
/* * Copyright (C) 2017 The "MysteriumNetwork/node" Authors. * * This program is free software: you can redistribute it and/or modify * it under the terms of the GNU General Public License as published by * the Free Software Foundation, either version 3 of the License, or * (at your option) any later version. * ...
1
14,566
why change this?
mysteriumnetwork-node
go
@@ -173,7 +173,7 @@ void h2o_get_timestamp(h2o_context_t *ctx, h2o_mem_pool_t *pool, h2o_timestamp_t if (ctx->_timestamp_cache.value != NULL) h2o_mem_release_shared(ctx->_timestamp_cache.value); ctx->_timestamp_cache.value = h2o_mem_alloc_shared(NULL, sizeof(h2o_timestamp_stri...
1
/* * Copyright (c) 2014 DeNA Co., Ltd. * * Permission is hereby granted, free of charge, to any person obtaining a copy * of this software and associated documentation files (the "Software"), to * deal in the Software without restriction, including without limitation the * rights to use, copy, modify, merge, publ...
1
10,692
If there is no guarantee that tv_sec is of type `time_t`, IMO you should copy the value instead of enforcing a pointer typecast.
h2o-h2o
c