source
large_stringclasses
2 values
subject
large_stringclasses
112 values
code
large_stringclasses
112 values
critique
large_stringlengths
61
3.04M
metadata
dict
lkml
[PATCH v3 00/47] arm_mpam: Add KVM/arm64 and resctrl glue code
This new version of the mpam missing pieces has no major rework from the previous version. It's mainly small corrections and code tidying based on review and things I spotted along the way. To be able to merge this we need review from more people and people to start testing on their platforms and giving some Tested-by ...
Hi Gavin, On 1/19/26 06:50, Gavin Shan wrote: Ah yes, I'll add a system_supports_mpam() check here. Thanks, Ben
{ "author": "Ben Horgan <ben.horgan@arm.com>", "date": "Mon, 19 Jan 2026 15:08:39 +0000", "thread_id": "20260112165914.4086692-1-ben.horgan@arm.com.mbox.gz" }
lkml
[PATCH v3 00/47] arm_mpam: Add KVM/arm64 and resctrl glue code
This new version of the mpam missing pieces has no major rework from the previous version. It's mainly small corrections and code tidying based on review and things I spotted along the way. To be able to merge this we need review from more people and people to start testing on their platforms and giving some Tested-by ...
Hi Gavin, On 1/19/26 06:51, Gavin Shan wrote: Addded. Thanks, Ben
{ "author": "Ben Horgan <ben.horgan@arm.com>", "date": "Mon, 19 Jan 2026 15:31:34 +0000", "thread_id": "20260112165914.4086692-1-ben.horgan@arm.com.mbox.gz" }
lkml
[PATCH v3 00/47] arm_mpam: Add KVM/arm64 and resctrl glue code
This new version of the mpam missing pieces has no major rework from the previous version. It's mainly small corrections and code tidying based on review and things I spotted along the way. To be able to merge this we need review from more people and people to start testing on their platforms and giving some Tested-by ...
Hi Catalin, On 1/15/26 19:13, Catalin Marinas wrote: Yes, I'll remove the inner #ifdef. Thanks, Ben
{ "author": "Ben Horgan <ben.horgan@arm.com>", "date": "Mon, 19 Jan 2026 15:47:07 +0000", "thread_id": "20260112165914.4086692-1-ben.horgan@arm.com.mbox.gz" }
lkml
[PATCH v3 00/47] arm_mpam: Add KVM/arm64 and resctrl glue code
This new version of the mpam missing pieces has no major rework from the previous version. It's mainly small corrections and code tidying based on review and things I spotted along the way. To be able to merge this we need review from more people and people to start testing on their platforms and giving some Tested-by ...
Hi Gavin, On 1/19/26 07:01, Gavin Shan wrote: Sure, I'll align these. I'll move the #ifdef CONFIG_ARM64_MPAM up to cover these. Thanks, Ben
{ "author": "Ben Horgan <ben.horgan@arm.com>", "date": "Mon, 19 Jan 2026 15:49:05 +0000", "thread_id": "20260112165914.4086692-1-ben.horgan@arm.com.mbox.gz" }
lkml
[PATCH v3 00/47] arm_mpam: Add KVM/arm64 and resctrl glue code
This new version of the mpam missing pieces has no major rework from the previous version. It's mainly small corrections and code tidying based on review and things I spotted along the way. To be able to merge this we need review from more people and people to start testing on their platforms and giving some Tested-by ...
Hi Reinette, On 1/13/26 16:49, Reinette Chatre wrote: Yeah, that leaks the memory and the offline call is unnecessary. Yes. Indeed. Yes, it's missing. I've reworked the code to move the resctrl_online_*() calls further up so there is less to do on error, added a kfree(dom) and made the ctrl_mon cleanup after the mo...
{ "author": "Ben Horgan <ben.horgan@arm.com>", "date": "Mon, 19 Jan 2026 17:20:51 +0000", "thread_id": "20260112165914.4086692-1-ben.horgan@arm.com.mbox.gz" }
lkml
[PATCH v3 00/47] arm_mpam: Add KVM/arm64 and resctrl glue code
This new version of the mpam missing pieces has no major rework from the previous version. It's mainly small corrections and code tidying based on review and things I spotted along the way. To be able to merge this we need review from more people and people to start testing on their platforms and giving some Tested-by ...
Hi Gavin, On 1/19/26 11:57, Gavin Shan wrote: Similarly to the other blank line checkpatch.pl warning I expect this is to do with how it handles the __free() annotation. I'm not intending to change this code unless there is some style guideline that I've missed or other reason to do so. Thanks, Ben
{ "author": "Ben Horgan <ben.horgan@arm.com>", "date": "Mon, 19 Jan 2026 20:27:48 +0000", "thread_id": "20260112165914.4086692-1-ben.horgan@arm.com.mbox.gz" }
lkml
[PATCH v3 00/47] arm_mpam: Add KVM/arm64 and resctrl glue code
This new version of the mpam missing pieces has no major rework from the previous version. It's mainly small corrections and code tidying based on review and things I spotted along the way. To be able to merge this we need review from more people and people to start testing on their platforms and giving some Tested-by ...
Hi Shaopeng, On 1/16/26 11:04, Ben Horgan wrote: Actually, resctl_arch_cntr_assign_set() only gets called on an attempt to change the value so I'll keep it as is. Thanks, Ben
{ "author": "Ben Horgan <ben.horgan@arm.com>", "date": "Mon, 19 Jan 2026 20:34:06 +0000", "thread_id": "20260112165914.4086692-1-ben.horgan@arm.com.mbox.gz" }
lkml
[PATCH v3 00/47] arm_mpam: Add KVM/arm64 and resctrl glue code
This new version of the mpam missing pieces has no major rework from the previous version. It's mainly small corrections and code tidying based on review and things I spotted along the way. To be able to merge this we need review from more people and people to start testing on their platforms and giving some Tested-by ...
Hi Gavin, On 1/19/26 12:14, Gavin Shan wrote: That's a real error. Fixed. Thanks, Ben
{ "author": "Ben Horgan <ben.horgan@arm.com>", "date": "Mon, 19 Jan 2026 20:48:45 +0000", "thread_id": "20260112165914.4086692-1-ben.horgan@arm.com.mbox.gz" }
lkml
[PATCH v3 00/47] arm_mpam: Add KVM/arm64 and resctrl glue code
This new version of the mpam missing pieces has no major rework from the previous version. It's mainly small corrections and code tidying based on review and things I spotted along the way. To be able to merge this we need review from more people and people to start testing on their platforms and giving some Tested-by ...
Hi Gavin, On 1/19/26 12:16, Gavin Shan wrote: Fixed Thanks, Ben
{ "author": "Ben Horgan <ben.horgan@arm.com>", "date": "Mon, 19 Jan 2026 20:54:19 +0000", "thread_id": "20260112165914.4086692-1-ben.horgan@arm.com.mbox.gz" }
lkml
[PATCH v3 00/47] arm_mpam: Add KVM/arm64 and resctrl glue code
This new version of the mpam missing pieces has no major rework from the previous version. It's mainly small corrections and code tidying based on review and things I spotted along the way. To be able to merge this we need review from more people and people to start testing on their platforms and giving some Tested-by ...
Hi Fenghua, On 1/15/26 23:20, Fenghua Yu wrote: Isn't that a policy decision rather than something we should be putting in a quirk framework? Thanks, Ben
{ "author": "Ben Horgan <ben.horgan@arm.com>", "date": "Mon, 19 Jan 2026 20:56:17 +0000", "thread_id": "20260112165914.4086692-1-ben.horgan@arm.com.mbox.gz" }
lkml
[PATCH v3 00/47] arm_mpam: Add KVM/arm64 and resctrl glue code
This new version of the mpam missing pieces has no major rework from the previous version. It's mainly small corrections and code tidying based on review and things I spotted along the way. To be able to merge this we need review from more people and people to start testing on their platforms and giving some Tested-by ...
Hi Gavin, On 1/19/26 12:18, Gavin Shan wrote: Fixed Thanks, Ben
{ "author": "Ben Horgan <ben.horgan@arm.com>", "date": "Mon, 19 Jan 2026 20:58:02 +0000", "thread_id": "20260112165914.4086692-1-ben.horgan@arm.com.mbox.gz" }
lkml
[PATCH v3 00/47] arm_mpam: Add KVM/arm64 and resctrl glue code
This new version of the mpam missing pieces has no major rework from the previous version. It's mainly small corrections and code tidying based on review and things I spotted along the way. To be able to merge this we need review from more people and people to start testing on their platforms and giving some Tested-by ...
Hi Ben and Jonathan, On 1/19/26 10:00 PM, Ben Horgan wrote: Yeah, I'm fine to keep it as of being :-) Thanks, Gavin
{ "author": "Gavin Shan <gshan@redhat.com>", "date": "Tue, 20 Jan 2026 09:42:09 +0800", "thread_id": "20260112165914.4086692-1-ben.horgan@arm.com.mbox.gz" }
lkml
[PATCH v3 00/47] arm_mpam: Add KVM/arm64 and resctrl glue code
This new version of the mpam missing pieces has no major rework from the previous version. It's mainly small corrections and code tidying based on review and things I spotted along the way. To be able to merge this we need review from more people and people to start testing on their platforms and giving some Tested-by ...
Hi Ben, On Fri, Jan 16, 2026 at 11:29 AM Ben Horgan <ben.horgan@arm.com> wrote: We actually ended up going with the "mon_id_includes_control_id" approach. The property it represents is rather fundamental to what a monitoring group actually is and is a low-level implementation detail that is difficult to hide. Google...
{ "author": "Peter Newman <peternewman@google.com>", "date": "Tue, 20 Jan 2026 16:28:01 +0100", "thread_id": "20260112165914.4086692-1-ben.horgan@arm.com.mbox.gz" }
lkml
[PATCH v3 00/47] arm_mpam: Add KVM/arm64 and resctrl glue code
This new version of the mpam missing pieces has no major rework from the previous version. It's mainly small corrections and code tidying based on review and things I spotted along the way. To be able to merge this we need review from more people and people to start testing on their platforms and giving some Tested-by ...
Hi Ben and Peter, On 1/20/26 7:28 AM, Peter Newman wrote: Thank you for confirming. I was hoping we could deprecate num_rmids after introducing a per resource group file but this does not seem to support all the use cases as highlighted by Ben. As I see it, a name like "mon_id_includes_control_id" also implies that...
{ "author": "Reinette Chatre <reinette.chatre@intel.com>", "date": "Wed, 21 Jan 2026 09:58:45 -0800", "thread_id": "20260112165914.4086692-1-ben.horgan@arm.com.mbox.gz" }
lkml
[PATCH v3 00/47] arm_mpam: Add KVM/arm64 and resctrl glue code
This new version of the mpam missing pieces has no major rework from the previous version. It's mainly small corrections and code tidying based on review and things I spotted along the way. To be able to merge this we need review from more people and people to start testing on their platforms and giving some Tested-by ...
Hi Ben, On Mon, Jan 19, 2026 at 12:23:13PM +0000, Ben Horgan wrote: It's fine to keep it this way if LDTR/STTR are not affected by the MPAM0 register. Since you use it for CPU suspend/resume, I guess it's fine, it saves us from having to preserve it in the low-level asm sleep code. I don't have a strong preference ...
{ "author": "Catalin Marinas <catalin.marinas@arm.com>", "date": "Fri, 23 Jan 2026 14:29:42 +0000", "thread_id": "20260112165914.4086692-1-ben.horgan@arm.com.mbox.gz" }
lkml
[PATCH v3 00/47] arm_mpam: Add KVM/arm64 and resctrl glue code
This new version of the mpam missing pieces has no major rework from the previous version. It's mainly small corrections and code tidying based on review and things I spotted along the way. To be able to merge this we need review from more people and people to start testing on their platforms and giving some Tested-by ...
Hi Catalin, On 1/23/26 14:29, Catalin Marinas wrote: I see, I had misinterpreted your question. When looking into this I spotted that the per-cpu default, arm64_mpam_default, is not updated on the cdp enable and so the default tasks carry on running with the non-cdp default pmg/partid configuration. On the race its...
{ "author": "Ben Horgan <ben.horgan@arm.com>", "date": "Mon, 26 Jan 2026 14:30:14 +0000", "thread_id": "20260112165914.4086692-1-ben.horgan@arm.com.mbox.gz" }
lkml
[PATCH v3 00/47] arm_mpam: Add KVM/arm64 and resctrl glue code
This new version of the mpam missing pieces has no major rework from the previous version. It's mainly small corrections and code tidying based on review and things I spotted along the way. To be able to merge this we need review from more people and people to start testing on their platforms and giving some Tested-by ...
On 1/26/26 14:30, Ben Horgan wrote: Rather than the resume path I'll just set all the arm64_mpam_default in resctrl_arch_set_cdp_enabled(). In code: --- a/drivers/resctrl/mpam_resctrl.c +++ b/drivers/resctrl/mpam_resctrl.c @@ -193,6 +193,7 @@ static void resctrl_reset_task_closids(void) int resctrl_arch_set_cdp_enab...
{ "author": "Ben Horgan <ben.horgan@arm.com>", "date": "Mon, 26 Jan 2026 14:50:12 +0000", "thread_id": "20260112165914.4086692-1-ben.horgan@arm.com.mbox.gz" }
lkml
[PATCH v3 00/47] arm_mpam: Add KVM/arm64 and resctrl glue code
This new version of the mpam missing pieces has no major rework from the previous version. It's mainly small corrections and code tidying based on review and things I spotted along the way. To be able to merge this we need review from more people and people to start testing on their platforms and giving some Tested-by ...
Hi Peter, James, On 1/19/26 12:47, Peter Newman wrote: Indeed we should base our discussion on the event definition in the Intel SDM. For our reference, the description for the external bandwidth monitoring event (mbm_total) is: "This event monitors the L3 total external bandwidth to the next level of the cache hier...
{ "author": "Ben Horgan <ben.horgan@arm.com>", "date": "Mon, 26 Jan 2026 16:00:04 +0000", "thread_id": "20260112165914.4086692-1-ben.horgan@arm.com.mbox.gz" }
lkml
[PATCH v3 00/47] arm_mpam: Add KVM/arm64 and resctrl glue code
This new version of the mpam missing pieces has no major rework from the previous version. It's mainly small corrections and code tidying based on review and things I spotted along the way. To be able to merge this we need review from more people and people to start testing on their platforms and giving some Tested-by ...
Hi, Ben, On 1/19/26 12:56, Ben Horgan wrote: MBW_MIN is 1% or 5% less than MBW_MAX. The lower MBW_MIN hints hardware to lower mem bandwidth when mem access contention. That causes memory performance degradation. Is it possible to do the following changes to fix the performance issue? 1. By default min mbw is equal...
{ "author": "Fenghua Yu <fenghuay@nvidia.com>", "date": "Thu, 29 Jan 2026 14:14:45 -0800", "thread_id": "20260112165914.4086692-1-ben.horgan@arm.com.mbox.gz" }
lkml
[PATCH v3 00/47] arm_mpam: Add KVM/arm64 and resctrl glue code
This new version of the mpam missing pieces has no major rework from the previous version. It's mainly small corrections and code tidying based on review and things I spotted along the way. To be able to merge this we need review from more people and people to start testing on their platforms and giving some Tested-by ...
Hi Reinette, Peter, On 1/21/26 17:58, Reinette Chatre wrote: I had a chat offline with James about this. Currently, userspace expects either the copy to succeed and the counters not to glitch or the move to fail. If we were going to support a monitor move in MPAM with counter reset (or a best effort counter value) we...
{ "author": "Ben Horgan <ben.horgan@arm.com>", "date": "Fri, 30 Jan 2026 11:07:31 +0000", "thread_id": "20260112165914.4086692-1-ben.horgan@arm.com.mbox.gz" }
lkml
[PATCH v3 00/47] arm_mpam: Add KVM/arm64 and resctrl glue code
This new version of the mpam missing pieces has no major rework from the previous version. It's mainly small corrections and code tidying based on review and things I spotted along the way. To be able to merge this we need review from more people and people to start testing on their platforms and giving some Tested-by ...
Replying to myself... On 1/12/26 16:58, Ben Horgan wrote: As the counter is named llc_occupancy (llc = last level cache) and we are naming the resource L3 it would be surprising to have llc_occupancy on anything other than an L3. Also, that L3 should be a last level cache. I'll update this as part of a general push t...
{ "author": "Ben Horgan <ben.horgan@arm.com>", "date": "Fri, 30 Jan 2026 11:19:29 +0000", "thread_id": "20260112165914.4086692-1-ben.horgan@arm.com.mbox.gz" }
lkml
[PATCH v3 00/47] arm_mpam: Add KVM/arm64 and resctrl glue code
This new version of the mpam missing pieces has no major rework from the previous version. It's mainly small corrections and code tidying based on review and things I spotted along the way. To be able to merge this we need review from more people and people to start testing on their platforms and giving some Tested-by ...
Hi Fenghua, On 1/29/26 22:14, Fenghua Yu wrote: Thanks for bringing this up. It raises some more general queries about the handling of mbw_min and so I'll move the discussion to [PATCH v3 41/47] arm_mpam: Generate a configuration for min controls as it isn't specific to the nvidia quirks. Thanks, Ben
{ "author": "Ben Horgan <ben.horgan@arm.com>", "date": "Fri, 30 Jan 2026 12:21:42 +0000", "thread_id": "20260112165914.4086692-1-ben.horgan@arm.com.mbox.gz" }
lkml
[PATCH v3 00/47] arm_mpam: Add KVM/arm64 and resctrl glue code
This new version of the mpam missing pieces has no major rework from the previous version. It's mainly small corrections and code tidying based on review and things I spotted along the way. To be able to merge this we need review from more people and people to start testing on their platforms and giving some Tested-by ...
Hi Ben, On Mon, Jan 26, 2026 at 5:00 PM Ben Horgan <ben.horgan@arm.com> wrote: The text you quoted from Intel was in the context of the L3. I assume if such an event were implemented at a different level of the memory system, it would continue to refer to downstream bandwidth. That should be ok for now. If I see a ...
{ "author": "Peter Newman <peternewman@google.com>", "date": "Fri, 30 Jan 2026 14:04:29 +0100", "thread_id": "20260112165914.4086692-1-ben.horgan@arm.com.mbox.gz" }
lkml
[PATCH v3 00/47] arm_mpam: Add KVM/arm64 and resctrl glue code
This new version of the mpam missing pieces has no major rework from the previous version. It's mainly small corrections and code tidying based on review and things I spotted along the way. To be able to merge this we need review from more people and people to start testing on their platforms and giving some Tested-by ...
Hi Fenghua, Jonathan, On 1/13/26 15:39, Jonathan Cameron wrote: I've realised it's not harmless :( In the discussion on a platform quirk, arm_mpam: Add workaround for T241-MPAM-4, Fenghua raised the following issues. " MBW_MIN is 1% or 5% less than MBW_MAX. The lower MBW_MIN hints hardware to lower mem bandwidth...
{ "author": "Ben Horgan <ben.horgan@arm.com>", "date": "Fri, 30 Jan 2026 14:17:38 +0000", "thread_id": "20260112165914.4086692-1-ben.horgan@arm.com.mbox.gz" }
lkml
[PATCH v3 00/47] arm_mpam: Add KVM/arm64 and resctrl glue code
This new version of the mpam missing pieces has no major rework from the previous version. It's mainly small corrections and code tidying based on review and things I spotted along the way. To be able to merge this we need review from more people and people to start testing on their platforms and giving some Tested-by ...
Hi Peter, On 1/30/26 13:04, Peter Newman wrote: Yes, that does seem reasonable. That cache level would have to match with what is reported in resctrl too. I expect that would involve adding a new entry in enum resctrl_scope. Good to know. I'm looking into tightening the heuristics in general. Please shout if any of...
{ "author": "Ben Horgan <ben.horgan@arm.com>", "date": "Fri, 30 Jan 2026 14:38:00 +0000", "thread_id": "20260112165914.4086692-1-ben.horgan@arm.com.mbox.gz" }
lkml
[PATCH v3 00/47] arm_mpam: Add KVM/arm64 and resctrl glue code
This new version of the mpam missing pieces has no major rework from the previous version. It's mainly small corrections and code tidying based on review and things I spotted along the way. To be able to merge this we need review from more people and people to start testing on their platforms and giving some Tested-by ...
Hi Ben, On 1/30/2026 8:17 AM, Ben Horgan wrote: Background: I previouslyshared original fix(seecodesnippet below) with James Morse ~2 years ago to address the errata, which explicitly recommends usinga 5% gap for mitigation of the Hardware issue (the problem described in commit text of T241-MPAM-4) For some reaso...
{ "author": "Shanker Donthineni <sdonthineni@nvidia.com>", "date": "Fri, 30 Jan 2026 20:30:01 -0600", "thread_id": "20260112165914.4086692-1-ben.horgan@arm.com.mbox.gz" }
lkml
[PATCH v3 00/47] arm_mpam: Add KVM/arm64 and resctrl glue code
This new version of the mpam missing pieces has no major rework from the previous version. It's mainly small corrections and code tidying based on review and things I spotted along the way. To be able to merge this we need review from more people and people to start testing on their platforms and giving some Tested-by ...
Hi Shanker, On 1/31/26 02:30, Shanker Donthineni wrote: What's the behaviour on T241 when MBW_MIN is always 0xFFFF? I'm worried if we make a policy decision of how to set MBW_MIN based on MBW_MAX for this platform then we won't be able to support a configurable MBW_MIN in the future for this platform. As when MBW_M...
{ "author": "Ben Horgan <ben.horgan@arm.com>", "date": "Mon, 2 Feb 2026 10:21:28 +0000", "thread_id": "20260112165914.4086692-1-ben.horgan@arm.com.mbox.gz" }
lkml
[PATCH v3 00/47] arm_mpam: Add KVM/arm64 and resctrl glue code
This new version of the mpam missing pieces has no major rework from the previous version. It's mainly small corrections and code tidying based on review and things I spotted along the way. To be able to merge this we need review from more people and people to start testing on their platforms and giving some Tested-by ...
Hi Ben, On 2/2/2026 4:21 AM, Ben Horgan wrote: Memory bandwidth throttling will not function correctly. The MPAM hardware monitors MIN and MAX values for each active partition to maintain memory bandwidth usage between MBW_MIN and MBW_MAX. Therefore, MBW_MIN must be less than MBW_MAX (IMO, setting MBW_MIN to always 0...
{ "author": "Shanker Donthineni <sdonthineni@nvidia.com>", "date": "Mon, 2 Feb 2026 10:34:18 -0600", "thread_id": "20260112165914.4086692-1-ben.horgan@arm.com.mbox.gz" }
lkml
[PATCH v4 00/13] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
The "qup-memory" interconnect path is optional and may not be defined in all device trees. Unroll the loop-based ICC path initialization to allow specific error handling for each path type. The "qup-core" and "qup-config" paths remain mandatory and will fail probe if missing, while "qup-memory" is now handled as optio...
{ "author": "Praveen Talari <praveen.talari@oss.qualcomm.com>", "date": "Mon, 2 Feb 2026 23:39:10 +0530", "thread_id": "20260202180922.1692428-7-praveen.talari@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v4 00/13] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
Add a new function geni_icc_set_bw_ab() that allows callers to set average bandwidth values for all ICC (Interconnect) paths in a single call. This function takes separate parameters for core, config, and DDR average bandwidth values and applies them to the respective ICC paths. This provides a more convenient API for...
{ "author": "Praveen Talari <praveen.talari@oss.qualcomm.com>", "date": "Mon, 2 Feb 2026 23:39:11 +0530", "thread_id": "20260202180922.1692428-7-praveen.talari@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v4 00/13] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
The GENI Serial Engine drivers (I2C, SPI, and SERIAL) currently duplicate code for initializing shared resources such as clocks and interconnect paths. Introduce a new helper API, geni_se_resources_init(), to centralize this initialization logic, improving modularity and simplifying the probe function. Signed-off-by:...
{ "author": "Praveen Talari <praveen.talari@oss.qualcomm.com>", "date": "Mon, 2 Feb 2026 23:39:12 +0530", "thread_id": "20260202180922.1692428-7-praveen.talari@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v4 00/13] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
Currently, core clk is handled individually in protocol drivers like the I2C driver. Move this clock management to the common clock APIs (geni_se_clks_on/off) that are already present in the common GENI SE driver to maintain consistency across all protocol drivers. Core clk is now properly managed alongside the other ...
{ "author": "Praveen Talari <praveen.talari@oss.qualcomm.com>", "date": "Mon, 2 Feb 2026 23:39:13 +0530", "thread_id": "20260202180922.1692428-7-praveen.talari@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v4 00/13] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
The GENI SE protocol drivers (I2C, SPI, UART) implement similar resource activation/deactivation sequences independently, leading to code duplication. Introduce geni_se_resources_activate()/geni_se_resources_deactivate() to power on/off resources.The activate function enables ICC, clocks, and TLMM whereas the deactiva...
{ "author": "Praveen Talari <praveen.talari@oss.qualcomm.com>", "date": "Mon, 2 Feb 2026 23:39:14 +0530", "thread_id": "20260202180922.1692428-7-praveen.talari@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v4 00/13] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
The GENI Serial Engine drivers (I2C, SPI, and SERIAL) currently handle the attachment of power domains. This often leads to duplicated code logic across different driver probe functions. Introduce a new helper API, geni_se_domain_attach(), to centralize the logic for attaching "power" and "perf" domains to the GENI SE...
{ "author": "Praveen Talari <praveen.talari@oss.qualcomm.com>", "date": "Mon, 2 Feb 2026 23:39:15 +0530", "thread_id": "20260202180922.1692428-7-praveen.talari@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v4 00/13] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
The GENI Serial Engine (SE) drivers (I2C, SPI, and SERIAL) currently manage performance levels and operating points directly. This resulting in code duplication across drivers. such as configuring a specific level or find and apply an OPP based on a clock frequency. Introduce two new helper APIs, geni_se_set_perf_leve...
{ "author": "Praveen Talari <praveen.talari@oss.qualcomm.com>", "date": "Mon, 2 Feb 2026 23:39:16 +0530", "thread_id": "20260202180922.1692428-7-praveen.talari@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v4 00/13] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
Add DT bindings for the QUP GENI I2C controller on sa8255p platforms. SA8255p platform abstracts resources such as clocks, interconnect and GPIO pins configuration in Firmware. SCMI power and perf protocol are utilized to request resource configurations. SA8255p platform does not require the Serial Engine (SE) common...
{ "author": "Praveen Talari <praveen.talari@oss.qualcomm.com>", "date": "Mon, 2 Feb 2026 23:39:17 +0530", "thread_id": "20260202180922.1692428-7-praveen.talari@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v4 00/13] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
Moving the serial engine setup to geni_i2c_init() API for a cleaner probe function and utilizes the PM runtime API to control resources instead of direct clock-related APIs for better resource management. Enables reusability of the serial engine initialization like hibernation and deep sleep features where hardware co...
{ "author": "Praveen Talari <praveen.talari@oss.qualcomm.com>", "date": "Mon, 2 Feb 2026 23:39:18 +0530", "thread_id": "20260202180922.1692428-7-praveen.talari@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v4 00/13] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
Refactor the resource initialization in geni_i2c_probe() by introducing a new geni_i2c_resources_init() function and utilizing the common geni_se_resources_init() framework and clock frequency mapping, making the probe function cleaner. Acked-by: Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com> Signed-off-by: Pravee...
{ "author": "Praveen Talari <praveen.talari@oss.qualcomm.com>", "date": "Mon, 2 Feb 2026 23:39:19 +0530", "thread_id": "20260202180922.1692428-7-praveen.talari@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v4 00/13] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
To manage GENI serial engine resources during runtime power management, drivers currently need to call functions for ICC, clock, and SE resource operations in both suspend and resume paths, resulting in code duplication across drivers. The new geni_se_resources_activate() and geni_se_resources_deactivate() helper APIs...
{ "author": "Praveen Talari <praveen.talari@oss.qualcomm.com>", "date": "Mon, 2 Feb 2026 23:39:20 +0530", "thread_id": "20260202180922.1692428-7-praveen.talari@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v4 00/13] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
To avoid repeatedly fetching and checking platform data across various functions, store the struct of_device_id data directly in the i2c private structure. This change enhances code maintainability and reduces redundancy. Acked-by: Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com> Signed-off-by: Praveen Talari <prave...
{ "author": "Praveen Talari <praveen.talari@oss.qualcomm.com>", "date": "Mon, 2 Feb 2026 23:39:21 +0530", "thread_id": "20260202180922.1692428-7-praveen.talari@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH v4 00/13] Enable I2C on SA8255p Qualcomm platforms
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
The Qualcomm automotive SA8255p SoC relies on firmware to configure platform resources, including clocks, interconnects and TLMM. The driver requests resources operations over SCMI using power and performance protocols. The SCMI power protocol enables or disables resources like clocks, interconnect paths, and TLMM (GP...
{ "author": "Praveen Talari <praveen.talari@oss.qualcomm.com>", "date": "Mon, 2 Feb 2026 23:39:22 +0530", "thread_id": "20260202180922.1692428-7-praveen.talari@oss.qualcomm.com.mbox.gz" }
lkml
[PATCH] Cleanup ipu3 driver
Clean up warnings generated by ./scripts/checkpatch.pl regarding the ipu3 driver at /drivers/staging/media/ipu3 More specifically, the following files have been affected: ipu3-css.c, ipu3-mmu.c, ipu3-mmu.h, ipu3-v4l2.c, ipu3.c, ipu3.h Signed-off-by: Bogdan Sandu <bogdanelsandu2011@gmail.com> --- drivers/staging/medi...
On Mon, Feb 02, 2026 at 12:03:11PM +0200, Bogdan Sandu wrote: Was this an AI generated patch? Either way, it needs to be properly broken up into "one logical change per patch" like all others. thanks, greg k-h
{ "author": "Greg KH <gregkh@linuxfoundation.org>", "date": "Mon, 2 Feb 2026 11:14:26 +0100", "thread_id": "20260202175033.8640-3-bogdanelsandu2011@gmail.com.mbox.gz" }
lkml
[PATCH] Cleanup ipu3 driver
Clean up warnings generated by ./scripts/checkpatch.pl regarding the ipu3 driver at /drivers/staging/media/ipu3 More specifically, the following files have been affected: ipu3-css.c, ipu3-mmu.c, ipu3-mmu.h, ipu3-v4l2.c, ipu3.c, ipu3.h Signed-off-by: Bogdan Sandu <bogdanelsandu2011@gmail.com> --- drivers/staging/medi...
I can assure you, it is not AI-generated. per patch" like all others. Understood. I'll resend it afterwards. Thank you for your patience.
{ "author": "Bogdan Sandu <bogdanelsandu2011@gmail.com>", "date": "Mon, 2 Feb 2026 12:18:43 +0200", "thread_id": "20260202175033.8640-3-bogdanelsandu2011@gmail.com.mbox.gz" }
lkml
[PATCH] Cleanup ipu3 driver
Clean up warnings generated by ./scripts/checkpatch.pl regarding the ipu3 driver at /drivers/staging/media/ipu3 More specifically, the following files have been affected: ipu3-css.c, ipu3-mmu.c, ipu3-mmu.h, ipu3-v4l2.c, ipu3.c, ipu3.h Signed-off-by: Bogdan Sandu <bogdanelsandu2011@gmail.com> --- drivers/staging/medi...
Clean up warnings generated by ./scripts/checkpatch.pl regarding the ipu3 driver at /drivers/staging/media/ipu3 More specifically, the following files have been affected: ipu3-css.c, ipu3-mmu.c, ipu3-mmu.h, ipu3-v4l2.c, ipu3.c, ipu3.h Signed-off-by: Bogdan Sandu <bogdanelsandu2011@gmail.com> --- drivers/staging/medi...
{ "author": "Bogdan Sandu <bogdanelsandu2011@gmail.com>", "date": "Mon, 2 Feb 2026 12:18:44 +0200", "thread_id": "20260202175033.8640-3-bogdanelsandu2011@gmail.com.mbox.gz" }
lkml
[PATCH] Cleanup ipu3 driver
Clean up warnings generated by ./scripts/checkpatch.pl regarding the ipu3 driver at /drivers/staging/media/ipu3 More specifically, the following files have been affected: ipu3-css.c, ipu3-mmu.c, ipu3-mmu.h, ipu3-v4l2.c, ipu3.c, ipu3.h Signed-off-by: Bogdan Sandu <bogdanelsandu2011@gmail.com> --- drivers/staging/medi...
On Mon, Feb 02, 2026 at 12:18:44PM +0200, Bogdan Sandu wrote: You resent the same thing again? confused, greg k-h
{ "author": "Greg KH <gregkh@linuxfoundation.org>", "date": "Mon, 2 Feb 2026 11:32:15 +0100", "thread_id": "20260202175033.8640-3-bogdanelsandu2011@gmail.com.mbox.gz" }
lkml
[PATCH] Cleanup ipu3 driver
Clean up warnings generated by ./scripts/checkpatch.pl regarding the ipu3 driver at /drivers/staging/media/ipu3 More specifically, the following files have been affected: ipu3-css.c, ipu3-mmu.c, ipu3-mmu.h, ipu3-v4l2.c, ipu3.c, ipu3.h Signed-off-by: Bogdan Sandu <bogdanelsandu2011@gmail.com> --- drivers/staging/medi...
The previous patch has now been separated into four smaller ones, each one fixing a specific type of checkpatch.pl issue. Bogdan Sandu (4): media: ipu3: fix alignment media: ipu3: use tabs media: ipu3: avoid ending lines with paranthesis media: ipu3: use BIT() drivers/staging/media/ipu3/ipu3-css.c | 39 ++++...
{ "author": "Bogdan Sandu <bogdanelsandu2011@gmail.com>", "date": "Mon, 2 Feb 2026 19:50:29 +0200", "thread_id": "20260202175033.8640-3-bogdanelsandu2011@gmail.com.mbox.gz" }
lkml
[PATCH] Cleanup ipu3 driver
Clean up warnings generated by ./scripts/checkpatch.pl regarding the ipu3 driver at /drivers/staging/media/ipu3 More specifically, the following files have been affected: ipu3-css.c, ipu3-mmu.c, ipu3-mmu.h, ipu3-v4l2.c, ipu3.c, ipu3.h Signed-off-by: Bogdan Sandu <bogdanelsandu2011@gmail.com> --- drivers/staging/medi...
Fix alignment with parentheses. Signed-off-by: Bogdan Sandu <bogdanelsandu2011@gmail.com> --- drivers/staging/media/ipu3/ipu3-css.c | 22 +++++++++++----------- drivers/staging/media/ipu3/ipu3-v4l2.c | 11 +++++------ drivers/staging/media/ipu3/ipu3.c | 4 ++-- 3 files changed, 18 insertions(+), 19 deletions(-...
{ "author": "Bogdan Sandu <bogdanelsandu2011@gmail.com>", "date": "Mon, 2 Feb 2026 19:50:30 +0200", "thread_id": "20260202175033.8640-3-bogdanelsandu2011@gmail.com.mbox.gz" }
lkml
[PATCH] Cleanup ipu3 driver
Clean up warnings generated by ./scripts/checkpatch.pl regarding the ipu3 driver at /drivers/staging/media/ipu3 More specifically, the following files have been affected: ipu3-css.c, ipu3-mmu.c, ipu3-mmu.h, ipu3-v4l2.c, ipu3.c, ipu3.h Signed-off-by: Bogdan Sandu <bogdanelsandu2011@gmail.com> --- drivers/staging/medi...
Use tabs instead of spaces. Signed-off-by: Bogdan Sandu <bogdanelsandu2011@gmail.com> --- drivers/staging/media/ipu3/ipu3-css.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/ipu3/ipu3-css.c b/drivers/staging/media/ipu3/ipu3-css.c index 145501e90..e990eb5b3 100644 --- a/...
{ "author": "Bogdan Sandu <bogdanelsandu2011@gmail.com>", "date": "Mon, 2 Feb 2026 19:50:31 +0200", "thread_id": "20260202175033.8640-3-bogdanelsandu2011@gmail.com.mbox.gz" }
lkml
[PATCH] Cleanup ipu3 driver
Clean up warnings generated by ./scripts/checkpatch.pl regarding the ipu3 driver at /drivers/staging/media/ipu3 More specifically, the following files have been affected: ipu3-css.c, ipu3-mmu.c, ipu3-mmu.h, ipu3-v4l2.c, ipu3.c, ipu3.h Signed-off-by: Bogdan Sandu <bogdanelsandu2011@gmail.com> --- drivers/staging/medi...
Don't end line with paranthesis. Signed-off-by: Bogdan Sandu <bogdanelsandu2011@gmail.com> --- drivers/staging/media/ipu3/ipu3-css.c | 13 +++++-------- drivers/staging/media/ipu3/ipu3.c | 3 +-- 2 files changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/staging/media/ipu3/ipu3-css.c b/drivers/stagi...
{ "author": "Bogdan Sandu <bogdanelsandu2011@gmail.com>", "date": "Mon, 2 Feb 2026 19:50:32 +0200", "thread_id": "20260202175033.8640-3-bogdanelsandu2011@gmail.com.mbox.gz" }
lkml
[PATCH] Cleanup ipu3 driver
Clean up warnings generated by ./scripts/checkpatch.pl regarding the ipu3 driver at /drivers/staging/media/ipu3 More specifically, the following files have been affected: ipu3-css.c, ipu3-mmu.c, ipu3-mmu.h, ipu3-v4l2.c, ipu3.c, ipu3.h Signed-off-by: Bogdan Sandu <bogdanelsandu2011@gmail.com> --- drivers/staging/medi...
Prefer BIT() macro over manual bitshift. Signed-off-by: Bogdan Sandu <bogdanelsandu2011@gmail.com> --- drivers/staging/media/ipu3/ipu3-mmu.c | 2 +- drivers/staging/media/ipu3/ipu3-mmu.h | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/media/ipu3/ipu3-mmu.c b/drivers/staging/me...
{ "author": "Bogdan Sandu <bogdanelsandu2011@gmail.com>", "date": "Mon, 2 Feb 2026 19:50:33 +0200", "thread_id": "20260202175033.8640-3-bogdanelsandu2011@gmail.com.mbox.gz" }
lkml
[PATCH 1/2] media: rkvdec: reduce excessive stack usage in assemble_hw_pps()
From: Arnd Bergmann <arnd@arndb.de> The rkvdec_pps had a large set of bitfields, all of which as misaligned. This causes clang-21 and likely other versions to produce absolutely awful object code and a warning about very large stack usage, on targets without unaligned access: drivers/media/platform/rockchip/rkvdec/rk...
From: Arnd Bergmann <arnd@arndb.de> The deeply nested loop in rkvdec_init_v4l2_vp9_count_tbl() needs a lot of registers, so when the clang register allocator runs out, it ends up spilling countless temporaries to the stack: drivers/media/platform/rockchip/rkvdec/rkvdec-vp9.c:966:12: error: stack frame size (1472) exc...
{ "author": "Arnd Bergmann <arnd@kernel.org>", "date": "Mon, 2 Feb 2026 10:47:51 +0100", "thread_id": "5c1b6a5a5a10404e51bc281054d733dc78374994.camel@collabora.com.mbox.gz" }
lkml
[PATCH 1/2] media: rkvdec: reduce excessive stack usage in assemble_hw_pps()
From: Arnd Bergmann <arnd@arndb.de> The rkvdec_pps had a large set of bitfields, all of which as misaligned. This causes clang-21 and likely other versions to produce absolutely awful object code and a warning about very large stack usage, on targets without unaligned access: drivers/media/platform/rockchip/rkvdec/rk...
Hi Arnd, Le lundi 02 février 2026 à 10:47 +0100, Arnd Bergmann a écrit : We had already addressed and validated that on clang-21, which indicates me that we likely are missing an architecture (or a config) in our CI. Can you document which architecture, configuration and flags was affected so we can add it on our sid...
{ "author": "Nicolas Dufresne <nicolas.dufresne@collabora.com>", "date": "Mon, 02 Feb 2026 08:42:41 -0500", "thread_id": "5c1b6a5a5a10404e51bc281054d733dc78374994.camel@collabora.com.mbox.gz" }
lkml
[PATCH 1/2] media: rkvdec: reduce excessive stack usage in assemble_hw_pps()
From: Arnd Bergmann <arnd@arndb.de> The rkvdec_pps had a large set of bitfields, all of which as misaligned. This causes clang-21 and likely other versions to produce absolutely awful object code and a warning about very large stack usage, on targets without unaligned access: drivers/media/platform/rockchip/rkvdec/rk...
On Mon, Feb 2, 2026, at 14:42, Nicolas Dufresne wrote: The configuration that hit this for me was an ARMv7-M NOMMU build. I'm doing 'randconfig' builds here, so I inevitably hit some corner cases that all deterministic CI systems miss. I don't think that you should add ARMv7-M here, since that would take up useful bui...
{ "author": "\"Arnd Bergmann\" <arnd@arndb.de>", "date": "Mon, 02 Feb 2026 15:09:14 +0100", "thread_id": "5c1b6a5a5a10404e51bc281054d733dc78374994.camel@collabora.com.mbox.gz" }
lkml
[PATCH 1/2] media: rkvdec: reduce excessive stack usage in assemble_hw_pps()
From: Arnd Bergmann <arnd@arndb.de> The rkvdec_pps had a large set of bitfields, all of which as misaligned. This causes clang-21 and likely other versions to produce absolutely awful object code and a warning about very large stack usage, on targets without unaligned access: drivers/media/platform/rockchip/rkvdec/rk...
Hi Arnd, Le lundi 02 février 2026 à 15:09 +0100, Arnd Bergmann a écrit : All fair comments. I plan to take this into fixes (no changes needed), hopefully for rc-2. Performance wise, this code is to replace read/mask/write into hardware registers which was significantly slower for this amount of registers (~200 32bit...
{ "author": "Nicolas Dufresne <nicolas.dufresne@collabora.com>", "date": "Mon, 02 Feb 2026 10:12:53 -0500", "thread_id": "5c1b6a5a5a10404e51bc281054d733dc78374994.camel@collabora.com.mbox.gz" }
lkml
[PATCH 1/2] media: rkvdec: reduce excessive stack usage in assemble_hw_pps()
From: Arnd Bergmann <arnd@arndb.de> The rkvdec_pps had a large set of bitfields, all of which as misaligned. This causes clang-21 and likely other versions to produce absolutely awful object code and a warning about very large stack usage, on targets without unaligned access: drivers/media/platform/rockchip/rkvdec/rk...
On Mon, Feb 2, 2026, at 16:12, Nicolas Dufresne wrote: I think there are multiple things going on here, some of which are more relevant than others: - The problem I'm addressing with my patch is purely a clang issue for CPU architectures with high register pressure when assembling the structure in memory. As ...
{ "author": "\"Arnd Bergmann\" <arnd@arndb.de>", "date": "Mon, 02 Feb 2026 16:59:05 +0100", "thread_id": "5c1b6a5a5a10404e51bc281054d733dc78374994.camel@collabora.com.mbox.gz" }
lkml
[PATCH 1/2] media: rkvdec: reduce excessive stack usage in assemble_hw_pps()
From: Arnd Bergmann <arnd@arndb.de> The rkvdec_pps had a large set of bitfields, all of which as misaligned. This causes clang-21 and likely other versions to produce absolutely awful object code and a warning about very large stack usage, on targets without unaligned access: drivers/media/platform/rockchip/rkvdec/rk...
Hi, Le lundi 02 février 2026 à 16:59 +0100, Arnd Bergmann a écrit : Ok, got it, clearly the registers bitfield (which is a set of 32bit bitfield) is fine (appart from endian, but this is deliberatly ignored). These are the one I had mind, and are optimized with copy_toio. For the SPS/PPS bistream, which is shared me...
{ "author": "Nicolas Dufresne <nicolas.dufresne@collabora.com>", "date": "Mon, 02 Feb 2026 11:31:40 -0500", "thread_id": "5c1b6a5a5a10404e51bc281054d733dc78374994.camel@collabora.com.mbox.gz" }
lkml
[PATCH 1/2] media: rkvdec: reduce excessive stack usage in assemble_hw_pps()
From: Arnd Bergmann <arnd@arndb.de> The rkvdec_pps had a large set of bitfields, all of which as misaligned. This causes clang-21 and likely other versions to produce absolutely awful object code and a warning about very large stack usage, on targets without unaligned access: drivers/media/platform/rockchip/rkvdec/rk...
Le lundi 02 février 2026 à 10:47 +0100, Arnd Bergmann a écrit : Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
{ "author": "Nicolas Dufresne <nicolas.dufresne@collabora.com>", "date": "Mon, 02 Feb 2026 11:32:16 -0500", "thread_id": "5c1b6a5a5a10404e51bc281054d733dc78374994.camel@collabora.com.mbox.gz" }
lkml
[PATCH 0/2] idpf: skip NULL pointers during deallocation.
In idpf txq and rxq error paths, some pointers are not allocated in the first place. In the corresponding deallocation logic, we should not deallocate them to prevent kernel panics. Li Li (2): idpf: skip deallocating bufq_sets from rx_qgrp if it is NULL. idpf: skip deallocating txq group's txqs if it is NULL. dr...
In idpf_rxq_group_alloc(), if rx_qgrp->splitq.bufq_sets failed to get allocated: rx_qgrp->splitq.bufq_sets = kcalloc(vport->num_bufqs_per_qgrp, sizeof(struct idpf_bufq_set), GFP_KERNEL); if (!rx_qgrp->splitq.bufq_sets) { err = -ENOMEM; goto err_alloc; } idpf_rxq_group_rel() would attempt to d...
{ "author": "Li Li <boolli@google.com>", "date": "Mon, 12 Jan 2026 23:09:43 +0000", "thread_id": "20260112230944.3085309-2-boolli@google.com.mbox.gz" }
lkml
[PATCH 0/2] idpf: skip NULL pointers during deallocation.
In idpf txq and rxq error paths, some pointers are not allocated in the first place. In the corresponding deallocation logic, we should not deallocate them to prevent kernel panics. Li Li (2): idpf: skip deallocating bufq_sets from rx_qgrp if it is NULL. idpf: skip deallocating txq group's txqs if it is NULL. dr...
In idpf_txq_group_alloc(), if any txq group's txqs failed to allocate memory: for (j = 0; j < tx_qgrp->num_txq; j++) { tx_qgrp->txqs[j] = kzalloc(sizeof(*tx_qgrp->txqs[j]), GFP_KERNEL); if (!tx_qgrp->txqs[j]) goto err_alloc; } It would cause a NULL ptr kernel panic in idpf_txq_group_rel(): for (j =...
{ "author": "Li Li <boolli@google.com>", "date": "Mon, 12 Jan 2026 23:09:44 +0000", "thread_id": "20260112230944.3085309-2-boolli@google.com.mbox.gz" }
lkml
[PATCH 0/2] idpf: skip NULL pointers during deallocation.
In idpf txq and rxq error paths, some pointers are not allocated in the first place. In the corresponding deallocation logic, we should not deallocate them to prevent kernel panics. Li Li (2): idpf: skip deallocating bufq_sets from rx_qgrp if it is NULL. idpf: skip deallocating txq group's txqs if it is NULL. dr...
Dear Li, Thank you for your patch. Am 13.01.26 um 00:09 schrieb Li Li via Intel-wired-lan: Is it easy to reproduce? (Just for the future, a blank in the “tag section” is uncommon.) Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de> Kind regards, Paul
{ "author": "Paul Menzel <pmenzel@molgen.mpg.de>", "date": "Tue, 13 Jan 2026 07:31:26 +0100", "thread_id": "20260112230944.3085309-2-boolli@google.com.mbox.gz" }
lkml
[PATCH 0/2] idpf: skip NULL pointers during deallocation.
In idpf txq and rxq error paths, some pointers are not allocated in the first place. In the corresponding deallocation logic, we should not deallocate them to prevent kernel panics. Li Li (2): idpf: skip deallocating bufq_sets from rx_qgrp if it is NULL. idpf: skip deallocating txq group's txqs if it is NULL. dr...
Dear Li, Thank you for your patch. Am 13.01.26 um 00:09 schrieb Li Li: The reproduction steps would be nice to have documented. Reviewed-by: Paul Menzel <pmenzel@molgen.mpg.de> Kind regards, Paul
{ "author": "Paul Menzel <pmenzel@molgen.mpg.de>", "date": "Tue, 13 Jan 2026 07:43:07 +0100", "thread_id": "20260112230944.3085309-2-boolli@google.com.mbox.gz" }
lkml
[PATCH 0/2] idpf: skip NULL pointers during deallocation.
In idpf txq and rxq error paths, some pointers are not allocated in the first place. In the corresponding deallocation logic, we should not deallocate them to prevent kernel panics. Li Li (2): idpf: skip deallocating bufq_sets from rx_qgrp if it is NULL. idpf: skip deallocating txq group's txqs if it is NULL. dr...
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
{ "author": "\"Loktionov, Aleksandr\" <aleksandr.loktionov@intel.com>", "date": "Tue, 13 Jan 2026 07:34:09 +0000", "thread_id": "20260112230944.3085309-2-boolli@google.com.mbox.gz" }
lkml
[PATCH 0/2] idpf: skip NULL pointers during deallocation.
In idpf txq and rxq error paths, some pointers are not allocated in the first place. In the corresponding deallocation logic, we should not deallocate them to prevent kernel panics. Li Li (2): idpf: skip deallocating bufq_sets from rx_qgrp if it is NULL. idpf: skip deallocating txq group's txqs if it is NULL. dr...
Reviewed-by: Aleksandr Loktionov <aleksandr.loktionov@intel.com>
{ "author": "\"Loktionov, Aleksandr\" <aleksandr.loktionov@intel.com>", "date": "Tue, 13 Jan 2026 07:34:57 +0000", "thread_id": "20260112230944.3085309-2-boolli@google.com.mbox.gz" }
lkml
[PATCH 0/2] idpf: skip NULL pointers during deallocation.
In idpf txq and rxq error paths, some pointers are not allocated in the first place. In the corresponding deallocation logic, we should not deallocate them to prevent kernel panics. Li Li (2): idpf: skip deallocating bufq_sets from rx_qgrp if it is NULL. idpf: skip deallocating txq group's txqs if it is NULL. dr...
On Mon, Jan 12, 2026 at 10:31 PM Paul Menzel <pmenzel@molgen.mpg.de> wrote: In our internal environments, we have the idpf driver running on machines with small RAM, and it's not uncommon for them to run out of memory and encounter kalloc issues, especially in kcallocs where we allocate higher order memory. To reliab...
{ "author": "Li Li <boolli@google.com>", "date": "Thu, 15 Jan 2026 12:07:12 -0800", "thread_id": "20260112230944.3085309-2-boolli@google.com.mbox.gz" }
lkml
[PATCH v1 0/4] usb: phy: tegra: HSIC adjustments
Followup to a recent HSIC bringup with a few small improvements. Svyatoslav Ryhel (4): usb: phy: tegra: cosmetic fixes usb: phy: tegra: return error value from utmi_wait_register usb: phy: tegra: parametrize HSIC PTS value usb: phy: tegra: parametrize PORTSC1 register offset drivers/usb/phy/phy-tegra-usb.c ...
Change TEGRA_USB_HOSTPC1_DEVLC_PTS_HSIC to its literal value instead of using the BIT macro, as it is an enumeration. Correct the spelling in the comment and rename uhsic_registers_shift to uhsic_registers_offset. These changes are cosmetic and do not affect code behavior. Signed-off-by: Svyatoslav Ryhel <clamor95@gma...
{ "author": "Svyatoslav Ryhel <clamor95@gmail.com>", "date": "Mon, 2 Feb 2026 10:05:23 +0200", "thread_id": "aabfe8bb-cd04-43f4-b0e5-07aca86c3ae0@gmail.com.mbox.gz" }
lkml
[PATCH v1 0/4] usb: phy: tegra: HSIC adjustments
Followup to a recent HSIC bringup with a few small improvements. Svyatoslav Ryhel (4): usb: phy: tegra: cosmetic fixes usb: phy: tegra: return error value from utmi_wait_register usb: phy: tegra: parametrize HSIC PTS value usb: phy: tegra: parametrize PORTSC1 register offset drivers/usb/phy/phy-tegra-usb.c ...
Return exact error value from utmi_wait_register during HSIC power on. Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com> --- drivers/usb/phy/phy-tegra-usb.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/usb/phy/phy-tegra-usb.c b/drivers/usb/phy/phy-tegra-usb.c index 3a7a74f01...
{ "author": "Svyatoslav Ryhel <clamor95@gmail.com>", "date": "Mon, 2 Feb 2026 10:05:24 +0200", "thread_id": "aabfe8bb-cd04-43f4-b0e5-07aca86c3ae0@gmail.com.mbox.gz" }
lkml
[PATCH v1 0/4] usb: phy: tegra: HSIC adjustments
Followup to a recent HSIC bringup with a few small improvements. Svyatoslav Ryhel (4): usb: phy: tegra: cosmetic fixes usb: phy: tegra: return error value from utmi_wait_register usb: phy: tegra: parametrize HSIC PTS value usb: phy: tegra: parametrize PORTSC1 register offset drivers/usb/phy/phy-tegra-usb.c ...
The parallel transceiver select used in HSIC mode differs on Tegra20, where it uses the UTMI value (0), whereas Tegra30+ uses a dedicated HSIC value. Reflect this in the SoC config. Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com> --- drivers/usb/phy/phy-tegra-usb.c | 7 +++---- include/linux/usb/tegra_usb_phy....
{ "author": "Svyatoslav Ryhel <clamor95@gmail.com>", "date": "Mon, 2 Feb 2026 10:05:25 +0200", "thread_id": "aabfe8bb-cd04-43f4-b0e5-07aca86c3ae0@gmail.com.mbox.gz" }
lkml
[PATCH v1 0/4] usb: phy: tegra: HSIC adjustments
Followup to a recent HSIC bringup with a few small improvements. Svyatoslav Ryhel (4): usb: phy: tegra: cosmetic fixes usb: phy: tegra: return error value from utmi_wait_register usb: phy: tegra: parametrize HSIC PTS value usb: phy: tegra: parametrize PORTSC1 register offset drivers/usb/phy/phy-tegra-usb.c ...
The PORTSC1 register has a different offset in Tegra20 compared to Tegra30+, yet they share a crucial set of registers required for HSIC functionality. Reflect this register offset change in the SoC config. Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com> --- drivers/usb/phy/phy-tegra-usb.c | 17 ++++++---------...
{ "author": "Svyatoslav Ryhel <clamor95@gmail.com>", "date": "Mon, 2 Feb 2026 10:05:26 +0200", "thread_id": "aabfe8bb-cd04-43f4-b0e5-07aca86c3ae0@gmail.com.mbox.gz" }
lkml
[PATCH v1 0/4] usb: phy: tegra: HSIC adjustments
Followup to a recent HSIC bringup with a few small improvements. Svyatoslav Ryhel (4): usb: phy: tegra: cosmetic fixes usb: phy: tegra: return error value from utmi_wait_register usb: phy: tegra: parametrize HSIC PTS value usb: phy: tegra: parametrize PORTSC1 register offset drivers/usb/phy/phy-tegra-usb.c ...
On Monday, February 2, 2026 5:05 PM Svyatoslav Ryhel wrote: Series Reviewed-by: Mikko Perttunen <mperttunen@nvidia.com>
{ "author": "Mikko Perttunen <mperttunen@nvidia.com>", "date": "Mon, 02 Feb 2026 17:10:37 +0900", "thread_id": "aabfe8bb-cd04-43f4-b0e5-07aca86c3ae0@gmail.com.mbox.gz" }
lkml
[PATCH v1 0/4] usb: phy: tegra: HSIC adjustments
Followup to a recent HSIC bringup with a few small improvements. Svyatoslav Ryhel (4): usb: phy: tegra: cosmetic fixes usb: phy: tegra: return error value from utmi_wait_register usb: phy: tegra: parametrize HSIC PTS value usb: phy: tegra: parametrize PORTSC1 register offset drivers/usb/phy/phy-tegra-usb.c ...
On 2/2/26 11:05 AM, Svyatoslav Ryhel wrote: This initialization seems pointless -- the newly added variable gets overwritten by you later... [...] MBR, Sergey
{ "author": "Sergey Shtylyov <sergei.shtylyov@gmail.com>", "date": "Mon, 2 Feb 2026 15:05:03 +0300", "thread_id": "aabfe8bb-cd04-43f4-b0e5-07aca86c3ae0@gmail.com.mbox.gz" }
lkml
[PATCH v1 0/4] usb: phy: tegra: HSIC adjustments
Followup to a recent HSIC bringup with a few small improvements. Svyatoslav Ryhel (4): usb: phy: tegra: cosmetic fixes usb: phy: tegra: return error value from utmi_wait_register usb: phy: tegra: parametrize HSIC PTS value usb: phy: tegra: parametrize PORTSC1 register offset drivers/usb/phy/phy-tegra-usb.c ...
пн, 2 лют. 2026 р. о 14:05 Sergey Shtylyov <sergei.shtylyov@gmail.com> пише: So? let it better be initialized and rewritten then later on catch errors.
{ "author": "Svyatoslav Ryhel <clamor95@gmail.com>", "date": "Mon, 2 Feb 2026 14:14:13 +0200", "thread_id": "aabfe8bb-cd04-43f4-b0e5-07aca86c3ae0@gmail.com.mbox.gz" }
lkml
[PATCH v1 0/4] usb: phy: tegra: HSIC adjustments
Followup to a recent HSIC bringup with a few small improvements. Svyatoslav Ryhel (4): usb: phy: tegra: cosmetic fixes usb: phy: tegra: return error value from utmi_wait_register usb: phy: tegra: parametrize HSIC PTS value usb: phy: tegra: parametrize PORTSC1 register offset drivers/usb/phy/phy-tegra-usb.c ...
On 2/2/26 3:14 PM, Svyatoslav Ryhel wrote: I'm not sure what errors you mean here. To me, it (contrariwise) seems to mask the possible errors when you forget to set err to e.g. -ENOMEM before returning (when adding a call to kmalloc() or any other function that doesn't return an error code itself)... I'm pretty ...
{ "author": "Sergey Shtylyov <sergei.shtylyov@gmail.com>", "date": "Mon, 2 Feb 2026 21:01:36 +0300", "thread_id": "aabfe8bb-cd04-43f4-b0e5-07aca86c3ae0@gmail.com.mbox.gz" }
lkml
[PATCH v4 00/10] x86/entry/vdso: clean up the vdso build, vdso updates
This patchset cleans up the vdso build by building the 32- and 64-bit vdsos in separate directories, moving the vdso2c tool to arch/x86/tools, and by merging common code and especially Makefile rules between the 32- and 64-bit vdsos to the greatest extent possible. Be more strict about sanitizing and standardizing the...
Currently the vdso doesn't include .note.gnu.property or a GNU noexec stack annotation (the -z noexecstack in the linker script is ineffective because we specify PHDRs explicitly.) The motivation is that the dynamic linker currently do not check these. However, this is a weak excuse: the vdso*.so are also supposed to...
{ "author": "\"H. Peter Anvin\" <hpa@zytor.com>", "date": "Tue, 16 Dec 2025 13:26:01 -0800", "thread_id": "223707e2-3231-4037-bd1f-490ddf6aeeb6@linux.ibm.com.mbox.gz" }
lkml
[PATCH v4 00/10] x86/entry/vdso: clean up the vdso build, vdso updates
This patchset cleans up the vdso build by building the 32- and 64-bit vdsos in separate directories, moving the vdso2c tool to arch/x86/tools, and by merging common code and especially Makefile rules between the 32- and 64-bit vdsos to the greatest extent possible. Be more strict about sanitizing and standardizing the...
A macro SYSCALL_ENTER_KERNEL was defined in sigreturn.S, with the ability of overriding it. The override capability, however, is not used anywhere, and the macro name is potentially confusing because it seems to imply that sysenter/syscall could be used here, which is NOT true: the sigreturn system calls MUST use int $...
{ "author": "\"H. Peter Anvin\" <hpa@zytor.com>", "date": "Tue, 16 Dec 2025 13:25:59 -0800", "thread_id": "223707e2-3231-4037-bd1f-490ddf6aeeb6@linux.ibm.com.mbox.gz" }
lkml
[PATCH v4 00/10] x86/entry/vdso: clean up the vdso build, vdso updates
This patchset cleans up the vdso build by building the 32- and 64-bit vdsos in separate directories, moving the vdso2c tool to arch/x86/tools, and by merging common code and especially Makefile rules between the 32- and 64-bit vdsos to the greatest extent possible. Be more strict about sanitizing and standardizing the...
It is generally better to build tools in arch/x86/tools to keep host cflags proliferation down, and to reduce makefile sequencing issues. Move the vdso build tool vdso2c into arch/x86/tools in preparation for refactoring the vdso makefiles. Signed-off-by: H. Peter Anvin (Intel) <hpa@zytor.com> --- arch/x86/Makefile ...
{ "author": "\"H. Peter Anvin\" <hpa@zytor.com>", "date": "Tue, 16 Dec 2025 13:25:56 -0800", "thread_id": "223707e2-3231-4037-bd1f-490ddf6aeeb6@linux.ibm.com.mbox.gz" }
lkml
[PATCH v4 00/10] x86/entry/vdso: clean up the vdso build, vdso updates
This patchset cleans up the vdso build by building the 32- and 64-bit vdsos in separate directories, moving the vdso2c tool to arch/x86/tools, and by merging common code and especially Makefile rules between the 32- and 64-bit vdsos to the greatest extent possible. Be more strict about sanitizing and standardizing the...
The vdso32 sigreturn.S contains open-coded DWARF bytecode, which includes a hack for gdb to not try to step back to a previous call instruction when backtracing from a signal handler. Neither of those are necessary anymore: the backtracing issue is handled by ".cfi_entry simple" and ".cfi_signal_frame", both of which ...
{ "author": "\"H. Peter Anvin\" <hpa@zytor.com>", "date": "Tue, 16 Dec 2025 13:26:00 -0800", "thread_id": "223707e2-3231-4037-bd1f-490ddf6aeeb6@linux.ibm.com.mbox.gz" }
lkml
[PATCH v4 00/10] x86/entry/vdso: clean up the vdso build, vdso updates
This patchset cleans up the vdso build by building the 32- and 64-bit vdsos in separate directories, moving the vdso2c tool to arch/x86/tools, and by merging common code and especially Makefile rules between the 32- and 64-bit vdsos to the greatest extent possible. Be more strict about sanitizing and standardizing the...
The vdso .so files are named vdso*.so. These structures are binary images and descriptions of these files, so it is more consistent for them to have a naming that more directly mirrors the filenames. It is also very slightly more compact (by one character...) and simplifies the Makefile just a little bit. Signed-off-...
{ "author": "\"H. Peter Anvin\" <hpa@zytor.com>", "date": "Tue, 16 Dec 2025 13:25:55 -0800", "thread_id": "223707e2-3231-4037-bd1f-490ddf6aeeb6@linux.ibm.com.mbox.gz" }
lkml
[PATCH v4 00/10] x86/entry/vdso: clean up the vdso build, vdso updates
This patchset cleans up the vdso build by building the 32- and 64-bit vdsos in separate directories, moving the vdso2c tool to arch/x86/tools, and by merging common code and especially Makefile rules between the 32- and 64-bit vdsos to the greatest extent possible. Be more strict about sanitizing and standardizing the...
There is no fundamental reason to use the int80_landing_pad symbol to adjust ip when moving the vdso. If ip falls within the vdso, and the vdso is moved, we should change the ip accordingly, regardless of mode or location within the vdso. This *currently* can only happen on 32 bits, but there isn't any reason not to do...
{ "author": "\"H. Peter Anvin\" <hpa@zytor.com>", "date": "Tue, 16 Dec 2025 13:25:58 -0800", "thread_id": "223707e2-3231-4037-bd1f-490ddf6aeeb6@linux.ibm.com.mbox.gz" }
lkml
[PATCH v4 00/10] x86/entry/vdso: clean up the vdso build, vdso updates
This patchset cleans up the vdso build by building the 32- and 64-bit vdsos in separate directories, moving the vdso2c tool to arch/x86/tools, and by merging common code and especially Makefile rules between the 32- and 64-bit vdsos to the greatest extent possible. Be more strict about sanitizing and standardizing the...
When neither sysenter32 nor syscall32 is available (on either FRED-capable 64-bit hardware or old 32-bit hardware), there is no reason to do a bunch of stack shuffling in __kernel_vsyscall. Unfortunately, just overwriting the initial "push" instructions will mess up the CFI annotations, so suffer the 3-byte NOP if not ...
{ "author": "\"H. Peter Anvin\" <hpa@zytor.com>", "date": "Tue, 16 Dec 2025 13:26:04 -0800", "thread_id": "223707e2-3231-4037-bd1f-490ddf6aeeb6@linux.ibm.com.mbox.gz" }
lkml
[PATCH v4 00/10] x86/entry/vdso: clean up the vdso build, vdso updates
This patchset cleans up the vdso build by building the 32- and 64-bit vdsos in separate directories, moving the vdso2c tool to arch/x86/tools, and by merging common code and especially Makefile rules between the 32- and 64-bit vdsos to the greatest extent possible. Be more strict about sanitizing and standardizing the...
Abstract out the calling of true system calls from the vdso into macros. It has been a very long time since gcc did not allow %ebx or %ebp in inline asm in 32-bit PIC mode; remove the corresponding hacks. Remove the use of memory output constraints in gettimeofday.h in favor of "memory" clobbers. The resulting code i...
{ "author": "\"H. Peter Anvin\" <hpa@zytor.com>", "date": "Tue, 16 Dec 2025 13:26:02 -0800", "thread_id": "223707e2-3231-4037-bd1f-490ddf6aeeb6@linux.ibm.com.mbox.gz" }
lkml
[PATCH v4 00/10] x86/entry/vdso: clean up the vdso build, vdso updates
This patchset cleans up the vdso build by building the 32- and 64-bit vdsos in separate directories, moving the vdso2c tool to arch/x86/tools, and by merging common code and especially Makefile rules between the 32- and 64-bit vdsos to the greatest extent possible. Be more strict about sanitizing and standardizing the...
In most cases, the use of "fast 32-bit system call" depends either on X86_FEATURE_SEP or X86_FEATURE_SYSENTER32 || X86_FEATURE_SYSCALL32. However, nearly all the logic for both is identical. Define X86_FEATURE_SYSFAST32 which indicates that *either* SYSENTER32 or SYSCALL32 should be used, for either 32- or 64-bit kern...
{ "author": "\"H. Peter Anvin\" <hpa@zytor.com>", "date": "Tue, 16 Dec 2025 13:26:03 -0800", "thread_id": "223707e2-3231-4037-bd1f-490ddf6aeeb6@linux.ibm.com.mbox.gz" }
lkml
[PATCH v4 00/10] x86/entry/vdso: clean up the vdso build, vdso updates
This patchset cleans up the vdso build by building the 32- and 64-bit vdsos in separate directories, moving the vdso2c tool to arch/x86/tools, and by merging common code and especially Makefile rules between the 32- and 64-bit vdsos to the greatest extent possible. Be more strict about sanitizing and standardizing the...
- Separate out the vdso sources into common, vdso32, and vdso64 directories. - Build the 32- and 64-bit vdsos in their respective subdirectories; this greatly simplifies the build flags handling. - Unify the mangling of Makefile flags between the 32- and 64-bit vdso code as much as possible; all common rules are ...
{ "author": "\"H. Peter Anvin\" <hpa@zytor.com>", "date": "Tue, 16 Dec 2025 13:25:57 -0800", "thread_id": "223707e2-3231-4037-bd1f-490ddf6aeeb6@linux.ibm.com.mbox.gz" }
lkml
[PATCH v4 00/10] x86/entry/vdso: clean up the vdso build, vdso updates
This patchset cleans up the vdso build by building the 32- and 64-bit vdsos in separate directories, moving the vdso2c tool to arch/x86/tools, and by merging common code and especially Makefile rules between the 32- and 64-bit vdsos to the greatest extent possible. Be more strict about sanitizing and standardizing the...
On Tue, Dec 16, 2025 at 4:26 PM H. Peter Anvin <hpa@zytor.com> wrote: Do we even still support the old linkers that need these constants? Brian Gerst
{ "author": "Brian Gerst <brgerst@gmail.com>", "date": "Wed, 17 Dec 2025 21:16:08 -0500", "thread_id": "223707e2-3231-4037-bd1f-490ddf6aeeb6@linux.ibm.com.mbox.gz" }
lkml
[PATCH v4 00/10] x86/entry/vdso: clean up the vdso build, vdso updates
This patchset cleans up the vdso build by building the 32- and 64-bit vdsos in separate directories, moving the vdso2c tool to arch/x86/tools, and by merging common code and especially Makefile rules between the 32- and 64-bit vdsos to the greatest extent possible. Be more strict about sanitizing and standardizing the...
On Wed, Dec 17, 2025 at 9:16 PM Brian Gerst <brgerst@gmail.com> wrote: Digging into the binutils source, PT_GNU_EH_FRAME and PT_GNU_STACK were added to the parser around bintils-2.15. PT_GNU_PROPERTY was added in binutils-2.38, which is newer than the minimum supported version of binutils-2.30. Probably better to ju...
{ "author": "Brian Gerst <brgerst@gmail.com>", "date": "Thu, 18 Dec 2025 01:56:49 -0500", "thread_id": "223707e2-3231-4037-bd1f-490ddf6aeeb6@linux.ibm.com.mbox.gz" }
lkml
[PATCH v4 00/10] x86/entry/vdso: clean up the vdso build, vdso updates
This patchset cleans up the vdso build by building the 32- and 64-bit vdsos in separate directories, moving the vdso2c tool to arch/x86/tools, and by merging common code and especially Makefile rules between the 32- and 64-bit vdsos to the greatest extent possible. Be more strict about sanitizing and standardizing the...
On Tue, Dec 16, 2025 at 10:26 PM H. Peter Anvin <hpa@zytor.com> wrote: Acked-by: Uros Bizjak <ubizjak@gmail.com>
{ "author": "Uros Bizjak <ubizjak@gmail.com>", "date": "Tue, 6 Jan 2026 19:09:48 +0100", "thread_id": "223707e2-3231-4037-bd1f-490ddf6aeeb6@linux.ibm.com.mbox.gz" }
lkml
[PATCH v4 00/10] x86/entry/vdso: clean up the vdso build, vdso updates
This patchset cleans up the vdso build by building the 32- and 64-bit vdsos in separate directories, moving the vdso2c tool to arch/x86/tools, and by merging common code and especially Makefile rules between the 32- and 64-bit vdsos to the greatest extent possible. Be more strict about sanitizing and standardizing the...
When neither sysenter32 nor syscall32 is available (on either FRED-capable 64-bit hardware or old 32-bit hardware), there is no reason to do a bunch of stack shuffling in __kernel_vsyscall. Unfortunately, just overwriting the initial "push" instructions will mess up the CFI annotations, so suffer the 3-byte NOP if not ...
{ "author": "\"H. Peter Anvin\" <hpa@zytor.com>", "date": "Tue, 6 Jan 2026 13:18:43 -0800", "thread_id": "223707e2-3231-4037-bd1f-490ddf6aeeb6@linux.ibm.com.mbox.gz" }
lkml
[PATCH v4 00/10] x86/entry/vdso: clean up the vdso build, vdso updates
This patchset cleans up the vdso build by building the 32- and 64-bit vdsos in separate directories, moving the vdso2c tool to arch/x86/tools, and by merging common code and especially Makefile rules between the 32- and 64-bit vdsos to the greatest extent possible. Be more strict about sanitizing and standardizing the...
Currently the vdso doesn't include .note.gnu.property or a GNU noexec stack annotation (the -z noexecstack in the linker script is ineffective because we specify PHDRs explicitly.) The motivation is that the dynamic linker currently do not check these. However, this is a weak excuse: the vdso*.so are also supposed to...
{ "author": "\"H. Peter Anvin\" <hpa@zytor.com>", "date": "Tue, 6 Jan 2026 13:18:40 -0800", "thread_id": "223707e2-3231-4037-bd1f-490ddf6aeeb6@linux.ibm.com.mbox.gz" }
lkml
[PATCH v4 00/10] x86/entry/vdso: clean up the vdso build, vdso updates
This patchset cleans up the vdso build by building the 32- and 64-bit vdsos in separate directories, moving the vdso2c tool to arch/x86/tools, and by merging common code and especially Makefile rules between the 32- and 64-bit vdsos to the greatest extent possible. Be more strict about sanitizing and standardizing the...
In most cases, the use of "fast 32-bit system call" depends either on X86_FEATURE_SEP or X86_FEATURE_SYSENTER32 || X86_FEATURE_SYSCALL32. However, nearly all the logic for both is identical. Define X86_FEATURE_SYSFAST32 which indicates that *either* SYSENTER32 or SYSCALL32 should be used, for either 32- or 64-bit kern...
{ "author": "\"H. Peter Anvin\" <hpa@zytor.com>", "date": "Tue, 6 Jan 2026 13:18:42 -0800", "thread_id": "223707e2-3231-4037-bd1f-490ddf6aeeb6@linux.ibm.com.mbox.gz" }
lkml
[PATCH v4 00/10] x86/entry/vdso: clean up the vdso build, vdso updates
This patchset cleans up the vdso build by building the 32- and 64-bit vdsos in separate directories, moving the vdso2c tool to arch/x86/tools, and by merging common code and especially Makefile rules between the 32- and 64-bit vdsos to the greatest extent possible. Be more strict about sanitizing and standardizing the...
Abstract out the calling of true system calls from the vdso into macros. It has been a very long time since gcc did not allow %ebx or %ebp in inline asm in 32-bit PIC mode; remove the corresponding hacks. Remove the use of memory output constraints in gettimeofday.h in favor of "memory" clobbers. The resulting code i...
{ "author": "\"H. Peter Anvin\" <hpa@zytor.com>", "date": "Tue, 6 Jan 2026 13:18:41 -0800", "thread_id": "223707e2-3231-4037-bd1f-490ddf6aeeb6@linux.ibm.com.mbox.gz" }
lkml
[PATCH v4 00/10] x86/entry/vdso: clean up the vdso build, vdso updates
This patchset cleans up the vdso build by building the 32- and 64-bit vdsos in separate directories, moving the vdso2c tool to arch/x86/tools, and by merging common code and especially Makefile rules between the 32- and 64-bit vdsos to the greatest extent possible. Be more strict about sanitizing and standardizing the...
The vdso32 sigreturn.S contains open-coded DWARF bytecode, which includes a hack for gdb to not try to step back to a previous call instruction when backtracing from a signal handler. Neither of those are necessary anymore: the backtracing issue is handled by ".cfi_entry simple" and ".cfi_signal_frame", both of which ...
{ "author": "\"H. Peter Anvin\" <hpa@zytor.com>", "date": "Tue, 6 Jan 2026 13:18:39 -0800", "thread_id": "223707e2-3231-4037-bd1f-490ddf6aeeb6@linux.ibm.com.mbox.gz" }
lkml
[PATCH v4 00/10] x86/entry/vdso: clean up the vdso build, vdso updates
This patchset cleans up the vdso build by building the 32- and 64-bit vdsos in separate directories, moving the vdso2c tool to arch/x86/tools, and by merging common code and especially Makefile rules between the 32- and 64-bit vdsos to the greatest extent possible. Be more strict about sanitizing and standardizing the...
There is no fundamental reason to use the int80_landing_pad symbol to adjust ip when moving the vdso. If ip falls within the vdso, and the vdso is moved, we should change the ip accordingly, regardless of mode or location within the vdso. This *currently* can only happen on 32 bits, but there isn't any reason not to do...
{ "author": "\"H. Peter Anvin\" <hpa@zytor.com>", "date": "Tue, 6 Jan 2026 13:18:37 -0800", "thread_id": "223707e2-3231-4037-bd1f-490ddf6aeeb6@linux.ibm.com.mbox.gz" }
lkml
[PATCH v4 00/10] x86/entry/vdso: clean up the vdso build, vdso updates
This patchset cleans up the vdso build by building the 32- and 64-bit vdsos in separate directories, moving the vdso2c tool to arch/x86/tools, and by merging common code and especially Makefile rules between the 32- and 64-bit vdsos to the greatest extent possible. Be more strict about sanitizing and standardizing the...
It is generally better to build tools in arch/x86/tools to keep host cflags proliferation down, and to reduce makefile sequencing issues. Move the vdso build tool vdso2c into arch/x86/tools in preparation for refactoring the vdso makefiles. Signed-off-by: H. Peter Anvin (Intel) <hpa@zytor.com> --- arch/x86/Makefile ...
{ "author": "\"H. Peter Anvin\" <hpa@zytor.com>", "date": "Tue, 6 Jan 2026 13:18:35 -0800", "thread_id": "223707e2-3231-4037-bd1f-490ddf6aeeb6@linux.ibm.com.mbox.gz" }
lkml
[PATCH v4 00/10] x86/entry/vdso: clean up the vdso build, vdso updates
This patchset cleans up the vdso build by building the 32- and 64-bit vdsos in separate directories, moving the vdso2c tool to arch/x86/tools, and by merging common code and especially Makefile rules between the 32- and 64-bit vdsos to the greatest extent possible. Be more strict about sanitizing and standardizing the...
The vdso .so files are named vdso*.so. These structures are binary images and descriptions of these files, so it is more consistent for them to have a naming that more directly mirrors the filenames. It is also very slightly more compact (by one character...) and simplifies the Makefile just a little bit. Signed-off-...
{ "author": "\"H. Peter Anvin\" <hpa@zytor.com>", "date": "Tue, 6 Jan 2026 13:18:34 -0800", "thread_id": "223707e2-3231-4037-bd1f-490ddf6aeeb6@linux.ibm.com.mbox.gz" }
lkml
[PATCH v4 00/10] x86/entry/vdso: clean up the vdso build, vdso updates
This patchset cleans up the vdso build by building the 32- and 64-bit vdsos in separate directories, moving the vdso2c tool to arch/x86/tools, and by merging common code and especially Makefile rules between the 32- and 64-bit vdsos to the greatest extent possible. Be more strict about sanitizing and standardizing the...
This is intended as a ping, since I think the v4 got swallowed by the holidays. v4.1 IS BASICALLY A REBASE AND RESEND OF v4; THE ONLY CODE CHANGE IS A SINGLE SPACE CHARACTER. This patchset cleans up the vdso build by building the 32- and 64-bit vdsos in separate directories, moving the vdso2c tool to arch/x86/tools, a...
{ "author": "\"H. Peter Anvin\" <hpa@zytor.com>", "date": "Tue, 6 Jan 2026 13:18:33 -0800", "thread_id": "223707e2-3231-4037-bd1f-490ddf6aeeb6@linux.ibm.com.mbox.gz" }
lkml
[PATCH v4 00/10] x86/entry/vdso: clean up the vdso build, vdso updates
This patchset cleans up the vdso build by building the 32- and 64-bit vdsos in separate directories, moving the vdso2c tool to arch/x86/tools, and by merging common code and especially Makefile rules between the 32- and 64-bit vdsos to the greatest extent possible. Be more strict about sanitizing and standardizing the...
A macro SYSCALL_ENTER_KERNEL was defined in sigreturn.S, with the ability of overriding it. The override capability, however, is not used anywhere, and the macro name is potentially confusing because it seems to imply that sysenter/syscall could be used here, which is NOT true: the sigreturn system calls MUST use int $...
{ "author": "\"H. Peter Anvin\" <hpa@zytor.com>", "date": "Tue, 6 Jan 2026 13:18:38 -0800", "thread_id": "223707e2-3231-4037-bd1f-490ddf6aeeb6@linux.ibm.com.mbox.gz" }
lkml
[PATCH v4 00/10] x86/entry/vdso: clean up the vdso build, vdso updates
This patchset cleans up the vdso build by building the 32- and 64-bit vdsos in separate directories, moving the vdso2c tool to arch/x86/tools, and by merging common code and especially Makefile rules between the 32- and 64-bit vdsos to the greatest extent possible. Be more strict about sanitizing and standardizing the...
- Separate out the vdso sources into common, vdso32, and vdso64 directories. - Build the 32- and 64-bit vdsos in their respective subdirectories; this greatly simplifies the build flags handling. - Unify the mangling of Makefile flags between the 32- and 64-bit vdso code as much as possible; all common rules are ...
{ "author": "\"H. Peter Anvin\" <hpa@zytor.com>", "date": "Tue, 6 Jan 2026 13:18:36 -0800", "thread_id": "223707e2-3231-4037-bd1f-490ddf6aeeb6@linux.ibm.com.mbox.gz" }
lkml
[PATCH v4 00/10] x86/entry/vdso: clean up the vdso build, vdso updates
This patchset cleans up the vdso build by building the 32- and 64-bit vdsos in separate directories, moving the vdso2c tool to arch/x86/tools, and by merging common code and especially Makefile rules between the 32- and 64-bit vdsos to the greatest extent possible. Be more strict about sanitizing and standardizing the...
On 06/01/2026 9:18 pm, H. Peter Anvin wrote: The v4/v4.1 notes will presumably want dropping before committing?
{ "author": "Andrew Cooper <andrew.cooper3@citrix.com>", "date": "Wed, 7 Jan 2026 12:10:52 +0000", "thread_id": "223707e2-3231-4037-bd1f-490ddf6aeeb6@linux.ibm.com.mbox.gz" }
lkml
[PATCH v4 00/10] x86/entry/vdso: clean up the vdso build, vdso updates
This patchset cleans up the vdso build by building the 32- and 64-bit vdsos in separate directories, moving the vdso2c tool to arch/x86/tools, and by merging common code and especially Makefile rules between the 32- and 64-bit vdsos to the greatest extent possible. Be more strict about sanitizing and standardizing the...
The following commit has been merged into the x86/entry branch of tip: Commit-ID: 93d73005bff4f600696ce30e366e742c3373b13d Gitweb: https://git.kernel.org/tip/93d73005bff4f600696ce30e366e742c3373b13d Author: H. Peter Anvin <hpa@zytor.com> AuthorDate: Tue, 16 Dec 2025 13:25:55 -08:00 Committer: ...
{ "author": "\"tip-bot2 for H. Peter Anvin\" <tip-bot2@linutronix.de>", "date": "Wed, 14 Jan 2026 00:01:26 -0000", "thread_id": "223707e2-3231-4037-bd1f-490ddf6aeeb6@linux.ibm.com.mbox.gz" }
lkml
[PATCH v4 00/10] x86/entry/vdso: clean up the vdso build, vdso updates
This patchset cleans up the vdso build by building the 32- and 64-bit vdsos in separate directories, moving the vdso2c tool to arch/x86/tools, and by merging common code and especially Makefile rules between the 32- and 64-bit vdsos to the greatest extent possible. Be more strict about sanitizing and standardizing the...
The following commit has been merged into the x86/entry branch of tip: Commit-ID: a76108d05ee13cddb72b620752a80b2c3e87aee1 Gitweb: https://git.kernel.org/tip/a76108d05ee13cddb72b620752a80b2c3e87aee1 Author: H. Peter Anvin <hpa@zytor.com> AuthorDate: Tue, 16 Dec 2025 13:25:56 -08:00 Committer: ...
{ "author": "\"tip-bot2 for H. Peter Anvin\" <tip-bot2@linutronix.de>", "date": "Wed, 14 Jan 2026 00:01:25 -0000", "thread_id": "223707e2-3231-4037-bd1f-490ddf6aeeb6@linux.ibm.com.mbox.gz" }
lkml
[PATCH v4 00/10] x86/entry/vdso: clean up the vdso build, vdso updates
This patchset cleans up the vdso build by building the 32- and 64-bit vdsos in separate directories, moving the vdso2c tool to arch/x86/tools, and by merging common code and especially Makefile rules between the 32- and 64-bit vdsos to the greatest extent possible. Be more strict about sanitizing and standardizing the...
The following commit has been merged into the x86/entry branch of tip: Commit-ID: 693c819fedcdcabfda7488e2d5e355a84c2fd1b0 Gitweb: https://git.kernel.org/tip/693c819fedcdcabfda7488e2d5e355a84c2fd1b0 Author: H. Peter Anvin <hpa@zytor.com> AuthorDate: Tue, 16 Dec 2025 13:25:57 -08:00 Committer: ...
{ "author": "\"tip-bot2 for H. Peter Anvin\" <tip-bot2@linutronix.de>", "date": "Wed, 14 Jan 2026 00:01:23 -0000", "thread_id": "223707e2-3231-4037-bd1f-490ddf6aeeb6@linux.ibm.com.mbox.gz" }