data_type
large_stringclasses
3 values
source
large_stringclasses
29 values
code
large_stringlengths
98
49.4M
filepath
large_stringlengths
5
161
message
large_stringclasses
234 values
commit
large_stringclasses
234 values
subject
large_stringclasses
418 values
critique
large_stringlengths
101
1.26M
metadata
dict
lkml_critique
lkml
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Hi, Order in which early memory reservation for hugetlb happens depends on architecture, on configuration options and on command line parameters. Some architectures rely on the core MM to call hugetlb_bootmem_alloc() while others call it very early to allow pre-all...
null
null
null
[PATCH v3 00/29] arch, mm: consolidate hugetlb early reservation
Hi Thomas, On Mon, Feb 23, 2026 at 02:52:45PM +0100, Thomas Weischuh wrote: Hm, most architectures do alternatives patching much later in the boot, when much more subsystems (including mm) is already initialized. Any particular reason riscv does it that early? Looking at patch_map it's quite clear why movement o...
{ "author": "Mike Rapoport <rppt@kernel.org>", "date": "Mon, 23 Feb 2026 21:40:59 +0200", "is_openbsd": false, "thread_id": "b9527ed4-7a5c-42e9-8814-b276b3741f63@suse.cz.mbox.gz" }
lkml_critique
lkml
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Hi, Order in which early memory reservation for hugetlb happens depends on architecture, on configuration options and on command line parameters. Some architectures rely on the core MM to call hugetlb_bootmem_alloc() while others call it very early to allow pre-all...
null
null
null
[PATCH v3 00/29] arch, mm: consolidate hugetlb early reservation
Mike Rapoport <rppt@kernel.org> writes: Hello Mike, [ 0.000000][ T0] ------------[ cut here ]------------ [ 0.000000][ T0] WARNING: arch/powerpc/include/asm/io.h:879 at virt_to_phys+0x44/0x1b8, CPU#0: swapper/0 [ 0.000000][ T0] Modules linked in: [ 0.000000][ T0] CPU: 0 UID: 0 PID: 0 Comm: sw...
{ "author": "Ritesh Harjani (IBM) <ritesh.list@gmail.com>", "date": "Wed, 25 Feb 2026 09:00:35 +0530", "is_openbsd": false, "thread_id": "b9527ed4-7a5c-42e9-8814-b276b3741f63@suse.cz.mbox.gz" }
lkml_critique
lkml
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Hi, Order in which early memory reservation for hugetlb happens depends on architecture, on configuration options and on command line parameters. Some architectures rely on the core MM to call hugetlb_bootmem_alloc() while others call it very early to allow pre-all...
null
null
null
[PATCH v3 00/29] arch, mm: consolidate hugetlb early reservation
Hello Ritesh, On Wed, Feb 25, 2026 at 09:00:35AM +0530, Ritesh Harjani wrote: Yes, I agree. It surely will work for powerpc :) I checked the definitions of __pa() on other architectures and it seems the safest and the easiest way to fix this. Would you send a formal patch? -- Sincerely yours, Mike.
{ "author": "Mike Rapoport <rppt@kernel.org>", "date": "Wed, 25 Feb 2026 18:25:24 +0200", "is_openbsd": false, "thread_id": "b9527ed4-7a5c-42e9-8814-b276b3741f63@suse.cz.mbox.gz" }
lkml_critique
lkml
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Hi, Order in which early memory reservation for hugetlb happens depends on architecture, on configuration options and on command line parameters. Some architectures rely on the core MM to call hugetlb_bootmem_alloc() while others call it very early to allow pre-all...
null
null
null
[PATCH v3 00/29] arch, mm: consolidate hugetlb early reservation
Mike Rapoport <rppt@kernel.org> writes: Thanks Mike for taking a look at above and confirming. Sure, let me prepare the patch and send it by tomorrow. -ritesh
{ "author": "Ritesh Harjani (IBM) <ritesh.list@gmail.com>", "date": "Wed, 25 Feb 2026 23:08:38 +0530", "is_openbsd": false, "thread_id": "b9527ed4-7a5c-42e9-8814-b276b3741f63@suse.cz.mbox.gz" }
lkml_critique
lkml
From: "Mike Rapoport (Microsoft)" <rppt@kernel.org> Hi, Order in which early memory reservation for hugetlb happens depends on architecture, on configuration options and on command line parameters. Some architectures rely on the core MM to call hugetlb_bootmem_alloc() while others call it very early to allow pre-all...
null
null
null
[PATCH v3 00/29] arch, mm: consolidate hugetlb early reservation
On 1/11/26 09:20, Mike Rapoport wrote: I've bisected a problem with virtme-ng testing a NUMA memoryless node setup (on x86_64) to this patch (commit d49004c5f0c1). It's executed like this, where node 0 has memory and node 1 only cpus: vng -vr . -p 8 -m 4G --numa 4G,cpus=0-3 --numa 0,cpus=4-7 This fails to boot due t...
{ "author": "Vlastimil Babka <vbabka@suse.cz>", "date": "Fri, 27 Feb 2026 16:14:42 +0100", "is_openbsd": false, "thread_id": "b9527ed4-7a5c-42e9-8814-b276b3741f63@suse.cz.mbox.gz" }
lkml_critique
lkml
File-scope 'atcphy_dwc3_reset_ops' is not used outside of this unit, so make it static to silence sparse warning: atc.c:2026:32: warning: symbol 'atcphy_dwc3_reset_ops' was not declared. Should it be static? Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> --- drivers/phy/apple/atc.c | 2 +...
null
null
null
[PATCH 1/3] phy: apple: atc: Make atcphy_dwc3_reset_ops variable static
__iomem annotated memory must be accessed via dedicated accessors, even if actual code is correct (accessing the driver data in mmp3_hsic_phy_init() brings back the __iomem cast), but dropping its cast (with or without __force) when storing as driver data seems like less readable code for any future changes. Instead, ...
{ "author": "Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>", "date": "Mon, 16 Feb 2026 12:04:15 +0100", "is_openbsd": false, "thread_id": "177220616334.330302.2835774532682598962.b4-ty@kernel.org.mbox.gz" }
lkml_critique
lkml
File-scope 'atcphy_dwc3_reset_ops' is not used outside of this unit, so make it static to silence sparse warning: atc.c:2026:32: warning: symbol 'atcphy_dwc3_reset_ops' was not declared. Should it be static? Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> --- drivers/phy/apple/atc.c | 2 +...
null
null
null
[PATCH 1/3] phy: apple: atc: Make atcphy_dwc3_reset_ops variable static
Pointers should not use explicit '0' comparison, so just use standard evaluation as non-NULL: phy-qcom-qmp-usbc.c:1682:31: warning: Using plain integer as NULL pointer Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> --- drivers/phy/qualcomm/phy-qcom-qmp-usbc.c | 6 +++--- 1 file changed, ...
{ "author": "Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>", "date": "Mon, 16 Feb 2026 12:04:16 +0100", "is_openbsd": false, "thread_id": "177220616334.330302.2835774532682598962.b4-ty@kernel.org.mbox.gz" }
lkml_critique
lkml
File-scope 'atcphy_dwc3_reset_ops' is not used outside of this unit, so make it static to silence sparse warning: atc.c:2026:32: warning: symbol 'atcphy_dwc3_reset_ops' was not declared. Should it be static? Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> --- drivers/phy/apple/atc.c | 2 +...
null
null
null
[PATCH 1/3] phy: apple: atc: Make atcphy_dwc3_reset_ops variable static
On 2/16/26 12:04 PM, Krzysztof Kozlowski wrote: Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Konrad
{ "author": "Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>", "date": "Mon, 16 Feb 2026 12:33:05 +0100", "is_openbsd": false, "thread_id": "177220616334.330302.2835774532682598962.b4-ty@kernel.org.mbox.gz" }
lkml_critique
lkml
File-scope 'atcphy_dwc3_reset_ops' is not used outside of this unit, so make it static to silence sparse warning: atc.c:2026:32: warning: symbol 'atcphy_dwc3_reset_ops' was not declared. Should it be static? Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> --- drivers/phy/apple/atc.c | 2 +...
null
null
null
[PATCH 1/3] phy: apple: atc: Make atcphy_dwc3_reset_ops variable static
On 26-02-16 12:04:16, Krzysztof Kozlowski wrote: Reviewed-by: Abel Vesa <abel.vesa@oss.qualcomm.com>
{ "author": "Abel Vesa <abel.vesa@oss.qualcomm.com>", "date": "Mon, 16 Feb 2026 16:58:22 +0200", "is_openbsd": false, "thread_id": "177220616334.330302.2835774532682598962.b4-ty@kernel.org.mbox.gz" }
lkml_critique
lkml
File-scope 'atcphy_dwc3_reset_ops' is not used outside of this unit, so make it static to silence sparse warning: atc.c:2026:32: warning: symbol 'atcphy_dwc3_reset_ops' was not declared. Should it be static? Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> --- drivers/phy/apple/atc.c | 2 +...
null
null
null
[PATCH 1/3] phy: apple: atc: Make atcphy_dwc3_reset_ops variable static
On Mon, Feb 16, 2026 at 12:04:16PM +0100, Krzysztof Kozlowski wrote: Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> -- With best wishes Dmitry
{ "author": "Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>", "date": "Tue, 24 Feb 2026 09:47:37 +0200", "is_openbsd": false, "thread_id": "177220616334.330302.2835774532682598962.b4-ty@kernel.org.mbox.gz" }
lkml_critique
lkml
File-scope 'atcphy_dwc3_reset_ops' is not used outside of this unit, so make it static to silence sparse warning: atc.c:2026:32: warning: symbol 'atcphy_dwc3_reset_ops' was not declared. Should it be static? Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> --- drivers/phy/apple/atc.c | 2 +...
null
null
null
[PATCH 1/3] phy: apple: atc: Make atcphy_dwc3_reset_ops variable static
On Mon, Feb 16, 2026 at 12:04:14PM +0100, Krzysztof Kozlowski wrote: Reviewed-by: Janne Grunau <j@jannau.net> thanks Janne
{ "author": "Janne Grunau <j@jannau.net>", "date": "Tue, 24 Feb 2026 08:57:05 +0100", "is_openbsd": false, "thread_id": "177220616334.330302.2835774532682598962.b4-ty@kernel.org.mbox.gz" }
lkml_critique
lkml
File-scope 'atcphy_dwc3_reset_ops' is not used outside of this unit, so make it static to silence sparse warning: atc.c:2026:32: warning: symbol 'atcphy_dwc3_reset_ops' was not declared. Should it be static? Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> --- drivers/phy/apple/atc.c | 2 +...
null
null
null
[PATCH 1/3] phy: apple: atc: Make atcphy_dwc3_reset_ops variable static
On Mon, 16 Feb 2026 12:04:14 +0100, Krzysztof Kozlowski wrote: Applied, thanks! [1/3] phy: apple: atc: Make atcphy_dwc3_reset_ops variable static commit: b3fddddf3fb49c7472e73680d6ea5d771f9514e8 [2/3] phy: marvell: mmp3-hsic: Avoid re-casting __iomem commit: c77eee5b44b8d32d471cf17fa193b395e321ef37 [3/3] ...
{ "author": "Vinod Koul <vkoul@kernel.org>", "date": "Fri, 27 Feb 2026 20:59:23 +0530", "is_openbsd": false, "thread_id": "177220616334.330302.2835774532682598962.b4-ty@kernel.org.mbox.gz" }
lkml_critique
lkml
ice_dpll_notify_changes() sends dpll_pin_change_ntf() only for the direct CGU input pin stored in d->active_input. Software-controlled pins (SMA/U.FL) are separate dpll_pin objects that wrap a backing CGU input, but they never receive a change notification. As a result, userspace consumers such as synce4l that monitor ...
null
null
null
[PATCH iwl-net v3] ice: fix missing dpll notification for SW pins
Petr, many thanks for your patch! LGTM. Reviewed-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>
{ "author": "\"Kubalewski, Arkadiusz\" <arkadiusz.kubalewski@intel.com>", "date": "Fri, 27 Feb 2026 14:46:45 +0000", "is_openbsd": false, "thread_id": "SA3PR11MB948594FB98369E2FC7D6FC189B73A@SA3PR11MB9485.namprd11.prod.outlook.com.mbox.gz" }
lkml_critique
lkml
From: Arnd Bergmann <arnd@arndb.de> All combined i2c/i3c drivers appear to suffer from the same link time problem when CONFIG_I3C is set to 'm': arm-linux-gnueabi-ld: drivers/iio/magnetometer/mmc5633.o: in function `mmc5633_i3c_driver_init': mmc5633.c:(.init.text+0x30): undefined reference to `i3c_driver_register_wit...
null
null
null
[PATCH] [v3, apply after -rc1] i3c: simplify combined i3c/i2c dependencies
On Wed, 4 Feb 2026 10:15:56 -0800 Guenter Roeck <linux@roeck-us.net> wrote: I think can drop the Fixes tag now given there is a fix in between for the original issue. For IIO Acked-by: Jonathan Cameron <jonathan.cameron@huawei.com> Thanks! Jonathan
{ "author": "Jonathan Cameron <jic23@kernel.org>", "date": "Thu, 5 Feb 2026 20:11:26 +0000", "is_openbsd": false, "thread_id": "177220641632.201056.5029746753419046340.b4-ty@bootlin.com.mbox.gz" }
lkml_critique
lkml
From: Arnd Bergmann <arnd@arndb.de> All combined i2c/i3c drivers appear to suffer from the same link time problem when CONFIG_I3C is set to 'm': arm-linux-gnueabi-ld: drivers/iio/magnetometer/mmc5633.o: in function `mmc5633_i3c_driver_init': mmc5633.c:(.init.text+0x30): undefined reference to `i3c_driver_register_wit...
null
null
null
[PATCH] [v3, apply after -rc1] i3c: simplify combined i3c/i2c dependencies
On Wed, 04 Feb 2026 17:41:58 +0100, Arnd Bergmann wrote: Applied, thanks! [1/1] i3c: simplify combined i3c/i2c dependencies https://git.kernel.org/abelloni/c/663eb8763c25 Best regards, -- Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
{ "author": "Alexandre Belloni <alexandre.belloni@bootlin.com>", "date": "Fri, 27 Feb 2026 16:33:58 +0100", "is_openbsd": false, "thread_id": "177220641632.201056.5029746753419046340.b4-ty@bootlin.com.mbox.gz" }
lkml_critique
lkml
This series introduces the hierarchical tree counter (hpcc) to increase accuracy of approximated RSS counters exposed through proc interfaces. With a test program hopping across CPUs doing frequent mmap/munmap operations, the upstream implementation approximation reaches a 1GB delta from the precise value after a few ...
null
null
null
[PATCH v17 0/3] Improve proc RSS accuracy
Introduce Kunit tests for hierarchical per-cpu counters. Keep track of two sets of hierarchical counters, each meant to have the same precise sum at any time, but distributed differently across the topology. Keep track of an atomic counter along with each hierarchical counter, for sum validation. Those tests cover: ...
{ "author": "Mathieu Desnoyers <mathieu.desnoyers@efficios.com>", "date": "Tue, 17 Feb 2026 11:10:05 -0500", "is_openbsd": false, "thread_id": "20260227151352.10882Ca0-hca@linux.ibm.com.mbox.gz" }
lkml_critique
lkml
This series introduces the hierarchical tree counter (hpcc) to increase accuracy of approximated RSS counters exposed through proc interfaces. With a test program hopping across CPUs doing frequent mmap/munmap operations, the upstream implementation approximation reaches a 1GB delta from the precise value after a few ...
null
null
null
[PATCH v17 0/3] Improve proc RSS accuracy
Use hierarchical per-cpu counters for RSS tracking to improve the accuracy of per-mm RSS sum approximation on large many-core systems [1]. This improves the accuracy of the RSS values returned by proc interfaces. Here is a (possibly incomplete) list of the prior approaches that were used or proposed, along with their ...
{ "author": "Mathieu Desnoyers <mathieu.desnoyers@efficios.com>", "date": "Tue, 17 Feb 2026 11:10:06 -0500", "is_openbsd": false, "thread_id": "20260227151352.10882Ca0-hca@linux.ibm.com.mbox.gz" }
lkml_critique
lkml
This series introduces the hierarchical tree counter (hpcc) to increase accuracy of approximated RSS counters exposed through proc interfaces. With a test program hopping across CPUs doing frequent mmap/munmap operations, the upstream implementation approximation reaches a 1GB delta from the precise value after a few ...
null
null
null
[PATCH v17 0/3] Improve proc RSS accuracy
* Motivation The purpose of this hierarchical split-counter scheme is to: - Minimize contention when incrementing and decrementing counters, - Provide fast access to a sum approximation, - Provide a sum approximation with an acceptable accuracy level when scaling to many-core systems. - Provide approximate and prec...
{ "author": "Mathieu Desnoyers <mathieu.desnoyers@efficios.com>", "date": "Tue, 17 Feb 2026 11:10:04 -0500", "is_openbsd": false, "thread_id": "20260227151352.10882Ca0-hca@linux.ibm.com.mbox.gz" }
lkml_critique
lkml
This series introduces the hierarchical tree counter (hpcc) to increase accuracy of approximated RSS counters exposed through proc interfaces. With a test program hopping across CPUs doing frequent mmap/munmap operations, the upstream implementation approximation reaches a 1GB delta from the precise value after a few ...
null
null
null
[PATCH v17 0/3] Improve proc RSS accuracy
On Tue, Feb 17, 2026 at 11:10:03AM -0500, Mathieu Desnoyers wrote: This seems to cause crashes with linux-next on s390, at least I could bisect it to the last patch of this series. Reverting the last one, makes the crashes go away: 0acac6604c1cfd7a1762901f0a4abe87cf3a8619 is the first bad commit commit 0acac6604c1cfd...
{ "author": "Heiko Carstens <hca@linux.ibm.com>", "date": "Thu, 26 Feb 2026 13:04:22 +0100", "is_openbsd": false, "thread_id": "20260227151352.10882Ca0-hca@linux.ibm.com.mbox.gz" }
lkml_critique
lkml
This series introduces the hierarchical tree counter (hpcc) to increase accuracy of approximated RSS counters exposed through proc interfaces. With a test program hopping across CPUs doing frequent mmap/munmap operations, the upstream implementation approximation reaches a 1GB delta from the precise value after a few ...
null
null
null
[PATCH v17 0/3] Improve proc RSS accuracy
On 2026-02-26 07:04, Heiko Carstens wrote: It looks like either an issue with ordering of the bootup sequence, or an issue with the size of struct mm_struct init_mm. I'll have a look. Thanks, Mathieu -- Mathieu Desnoyers EfficiOS Inc. https://www.efficios.com
{ "author": "Mathieu Desnoyers <mathieu.desnoyers@efficios.com>", "date": "Thu, 26 Feb 2026 10:00:51 -0500", "is_openbsd": false, "thread_id": "20260227151352.10882Ca0-hca@linux.ibm.com.mbox.gz" }
lkml_critique
lkml
This series introduces the hierarchical tree counter (hpcc) to increase accuracy of approximated RSS counters exposed through proc interfaces. With a test program hopping across CPUs doing frequent mmap/munmap operations, the upstream implementation approximation reaches a 1GB delta from the precise value after a few ...
null
null
null
[PATCH v17 0/3] Improve proc RSS accuracy
On 2026-02-26 10:00, Mathieu Desnoyers wrote: I've successfully booted a linux-next 7.0.0-rc1-next-20260226 within a x86-64 vm, with a swap partition. I wonder if s390x somehow alters the value of nr_cpus_ids late in bootup, after percpu_counter_tree_subsystem_init() ? Can you share your .config and kernel command l...
{ "author": "Mathieu Desnoyers <mathieu.desnoyers@efficios.com>", "date": "Thu, 26 Feb 2026 10:42:22 -0500", "is_openbsd": false, "thread_id": "20260227151352.10882Ca0-hca@linux.ibm.com.mbox.gz" }
lkml_critique
lkml
This series introduces the hierarchical tree counter (hpcc) to increase accuracy of approximated RSS counters exposed through proc interfaces. With a test program hopping across CPUs doing frequent mmap/munmap operations, the upstream implementation approximation reaches a 1GB delta from the precise value after a few ...
null
null
null
[PATCH v17 0/3] Improve proc RSS accuracy
On Thu, 26 Feb 2026 13:04:22 +0100 Heiko Carstens <hca@linux.ibm.com> wrote: Thanks, I'll remove this series from linux-next for now.
{ "author": "Andrew Morton <akpm@linux-foundation.org>", "date": "Thu, 26 Feb 2026 08:51:51 -0800", "is_openbsd": false, "thread_id": "20260227151352.10882Ca0-hca@linux.ibm.com.mbox.gz" }
lkml_critique
lkml
This series introduces the hierarchical tree counter (hpcc) to increase accuracy of approximated RSS counters exposed through proc interfaces. With a test program hopping across CPUs doing frequent mmap/munmap operations, the upstream implementation approximation reaches a 1GB delta from the precise value after a few ...
null
null
null
[PATCH v17 0/3] Improve proc RSS accuracy
On 2026-02-26 10:42, Mathieu Desnoyers wrote: I've successfully booted a defconfig s390x next-20260226 kernel in qemu with 1 and 4 CPUs, and within a nested s390x VM on 2 cpus. I guess I'll really need more info about your specific .config and command line args to help further. Thanks, Mathieu -- Mathieu Desnoy...
{ "author": "Mathieu Desnoyers <mathieu.desnoyers@efficios.com>", "date": "Thu, 26 Feb 2026 14:38:04 -0500", "is_openbsd": false, "thread_id": "20260227151352.10882Ca0-hca@linux.ibm.com.mbox.gz" }
lkml_critique
lkml
This series introduces the hierarchical tree counter (hpcc) to increase accuracy of approximated RSS counters exposed through proc interfaces. With a test program hopping across CPUs doing frequent mmap/munmap operations, the upstream implementation approximation reaches a 1GB delta from the precise value after a few ...
null
null
null
[PATCH v17 0/3] Improve proc RSS accuracy
Hi Mathieu, On Thu, Feb 26, 2026 at 02:38:04PM -0500, Mathieu Desnoyers wrote: FWIW, the ClangBuiltLinux CI sees a boot failure with sparc64_defconfig, which does not appear to be clang specific. I can reproduce it here with: $ make -skj"$(nproc)" ARCH=sparc CROSS_COMPILE=sparc64-linux- mrproper sparc64_defconfig ...
{ "author": "Nathan Chancellor <nathan@kernel.org>", "date": "Thu, 26 Feb 2026 18:12:01 -0700", "is_openbsd": false, "thread_id": "20260227151352.10882Ca0-hca@linux.ibm.com.mbox.gz" }
lkml_critique
lkml
This series introduces the hierarchical tree counter (hpcc) to increase accuracy of approximated RSS counters exposed through proc interfaces. With a test program hopping across CPUs doing frequent mmap/munmap operations, the upstream implementation approximation reaches a 1GB delta from the precise value after a few ...
null
null
null
[PATCH v17 0/3] Improve proc RSS accuracy
On Thu, Feb 26, 2026 at 06:12:01PM -0700, Nathan Chancellor wrote: On s390 cpumask_set_cpu(0, mm_cpumask(&init_mm)); in arch_mm_preinit() writes out-of-bounds into swap_attrs[] overwriting the terminating NULL. This seems to happen because the return value of get_rss_stat_items_size() is larger than PERCPU_COUNTER_TR...
{ "author": "Heiko Carstens <hca@linux.ibm.com>", "date": "Fri, 27 Feb 2026 14:11:28 +0100", "is_openbsd": false, "thread_id": "20260227151352.10882Ca0-hca@linux.ibm.com.mbox.gz" }
lkml_critique
lkml
This series introduces the hierarchical tree counter (hpcc) to increase accuracy of approximated RSS counters exposed through proc interfaces. With a test program hopping across CPUs doing frequent mmap/munmap operations, the upstream implementation approximation reaches a 1GB delta from the precise value after a few ...
null
null
null
[PATCH v17 0/3] Improve proc RSS accuracy
On 2026-02-27 08:11, Heiko Carstens wrote: Indeed! So in get_rss_stat_items_size() we have: static inline size_t get_rss_stat_items_size(void) { return percpu_counter_tree_items_size() * NR_MM_COUNTERS; } And just above: #define MM_STRUCT_FLEXIBLE_ARRAY_INIT ...
{ "author": "Mathieu Desnoyers <mathieu.desnoyers@efficios.com>", "date": "Fri, 27 Feb 2026 08:25:46 -0500", "is_openbsd": false, "thread_id": "20260227151352.10882Ca0-hca@linux.ibm.com.mbox.gz" }
lkml_critique
lkml
This series introduces the hierarchical tree counter (hpcc) to increase accuracy of approximated RSS counters exposed through proc interfaces. With a test program hopping across CPUs doing frequent mmap/munmap operations, the upstream implementation approximation reaches a 1GB delta from the precise value after a few ...
null
null
null
[PATCH v17 0/3] Improve proc RSS accuracy
On 2026-02-26 20:12, Nathan Chancellor wrote: I found the issue with the info provided by Heiko. Thanks for the reproducer! Good catch. I will fix this as well for v18. Thanks! Mathieu -- Mathieu Desnoyers EfficiOS Inc. https://www.efficios.com
{ "author": "Mathieu Desnoyers <mathieu.desnoyers@efficios.com>", "date": "Fri, 27 Feb 2026 08:39:56 -0500", "is_openbsd": false, "thread_id": "20260227151352.10882Ca0-hca@linux.ibm.com.mbox.gz" }
lkml_critique
lkml
Hi folks, It has been a while since I last posted an updated. Had some big life changes that have kept me from working on this more actively, so I have not been able to get on top of this till now. Hoping my pace going forward should be a lot faster. Using the conversation from LPC as well as other refactors needed, I...
null
null
null
[PATCH v6 0/2] Initial work for Rust abstraction for HID device driver development
These abstractions enable the development of HID drivers in Rust by binding with the HID core C API. They provide Rust types that map to the equivalents in C. In this initial draft, only hid_device and hid_device_id are provided direct Rust type equivalents. hid_driver is specially wrapped with a custom Driver type. Th...
{ "author": "Rahul Rameshbabu <sergeantsagara@protonmail.com>", "date": "Sun, 22 Feb 2026 21:56:39 +0000", "is_openbsd": false, "thread_id": "DGPUMHQSACGL.1ITBM2W573WD1@garyguo.net.mbox.gz" }
lkml_critique
lkml
Hi folks, It has been a while since I last posted an updated. Had some big life changes that have kept me from working on this more actively, so I have not been able to get on top of this till now. Hoping my pace going forward should be a lot faster. Using the conversation from LPC as well as other refactors needed, I...
null
null
null
[PATCH v6 0/2] Initial work for Rust abstraction for HID device driver development
Demonstrate how to perform a report fixup from a Rust HID driver. The mice specify the const flag incorrectly in the consumer input report descriptor, which leads to inputs being ignored. Correctly patch the report descriptor for the Model O and O- mice. Portions of the HID report post-fixup: device 0:0 ... 0x81, 0x06...
{ "author": "Rahul Rameshbabu <sergeantsagara@protonmail.com>", "date": "Sun, 22 Feb 2026 21:56:51 +0000", "is_openbsd": false, "thread_id": "DGPUMHQSACGL.1ITBM2W573WD1@garyguo.net.mbox.gz" }
lkml_critique
lkml
Hi folks, It has been a while since I last posted an updated. Had some big life changes that have kept me from working on this more actively, so I have not been able to get on top of this till now. Hoping my pace going forward should be a lot faster. Using the conversation from LPC as well as other refactors needed, I...
null
null
null
[PATCH v6 0/2] Initial work for Rust abstraction for HID device driver development
On 2/22/26 1:56 PM, Rahul Rameshbabu wrote: HID_MAIN_ITEM_BUFFERED_BYTE has a value of 0x100 which will not fit in a u8. Maybe all the MAIN_ITEM_* bits should bound as u16? HID 1.11 actually defines them as a u32 with bits 9-31 reserved for future use. Thanks Terry +
{ "author": "Terry Junge <linuxhid@cosmicgizmosystems.com>", "date": "Sun, 22 Feb 2026 15:39:45 -0800", "is_openbsd": false, "thread_id": "DGPUMHQSACGL.1ITBM2W573WD1@garyguo.net.mbox.gz" }
lkml_critique
lkml
Hi folks, It has been a while since I last posted an updated. Had some big life changes that have kept me from working on this more actively, so I have not been able to get on top of this till now. Hoping my pace going forward should be a lot faster. Using the conversation from LPC as well as other refactors needed, I...
null
null
null
[PATCH v6 0/2] Initial work for Rust abstraction for HID device driver development
On Sun, Feb 22, 2026 at 09:56:51PM +0000, Rahul Rameshbabu wrote: You seem to have the same file in here in two different locations :(
{ "author": "Greg KH <gregkh@linuxfoundation.org>", "date": "Mon, 23 Feb 2026 03:38:23 +0100", "is_openbsd": false, "thread_id": "DGPUMHQSACGL.1ITBM2W573WD1@garyguo.net.mbox.gz" }
lkml_critique
lkml
Hi folks, It has been a while since I last posted an updated. Had some big life changes that have kept me from working on this more actively, so I have not been able to get on top of this till now. Hoping my pace going forward should be a lot faster. Using the conversation from LPC as well as other refactors needed, I...
null
null
null
[PATCH v6 0/2] Initial work for Rust abstraction for HID device driver development
On Sun, 22 Feb, 2026 15:39:45 -0800 "Terry Junge" <linuxhid@cosmicgizmosystems.com> wrote: Thanks Terry for pointing this out. I will give some time for other reviewers to comment but will make the needed change for a v7. Thanks, Rahul Rameshbabu
{ "author": "Rahul Rameshbabu <sergeantsagara@protonmail.com>", "date": "Mon, 23 Feb 2026 02:47:25 +0000", "is_openbsd": false, "thread_id": "DGPUMHQSACGL.1ITBM2W573WD1@garyguo.net.mbox.gz" }
lkml_critique
lkml
Hi folks, It has been a while since I last posted an updated. Had some big life changes that have kept me from working on this more actively, so I have not been able to get on top of this till now. Hoping my pace going forward should be a lot faster. Using the conversation from LPC as well as other refactors needed, I...
null
null
null
[PATCH v6 0/2] Initial work for Rust abstraction for HID device driver development
On Mon, 23 Feb, 2026 03:38:23 +0100 "Greg KH" <gregkh@linuxfoundation.org> wrote: Yeah, I noticed this right after sending out the patches.... drivers/hid/hid_glorious_rust.rs was meant to be removed. https://lore.kernel.org/rust-for-linux/wjfjzjc626n55zvhksiyldobwubr2imbvfavqej333lvnka2wn@r4zfcjqtanvu/ I accident...
{ "author": "Rahul Rameshbabu <sergeantsagara@protonmail.com>", "date": "Mon, 23 Feb 2026 02:52:16 +0000", "is_openbsd": false, "thread_id": "DGPUMHQSACGL.1ITBM2W573WD1@garyguo.net.mbox.gz" }
lkml_critique
lkml
Hi folks, It has been a while since I last posted an updated. Had some big life changes that have kept me from working on this more actively, so I have not been able to get on top of this till now. Hoping my pace going forward should be a lot faster. Using the conversation from LPC as well as other refactors needed, I...
null
null
null
[PATCH v6 0/2] Initial work for Rust abstraction for HID device driver development
On Sun Feb 22, 2026 at 9:56 PM GMT, Rahul Rameshbabu wrote: These can be bitflags with `impl_flags!`? This and many functions in the abstraction can be `#[inline]`. Please define a custom error type or just use a kernel error code. The main description should be the first sentence, and C equivalent sentence foll...
{ "author": "\"Gary Guo\" <gary@garyguo.net>", "date": "Fri, 27 Feb 2026 15:27:59 +0000", "is_openbsd": false, "thread_id": "DGPUMHQSACGL.1ITBM2W573WD1@garyguo.net.mbox.gz" }
lkml_critique
lkml
S2MU005 is an MFD chip manufactured by Samsung Electronics. This is found in various devices manufactured by Samsung and others, including all Exynos 7870 devices. It is known to have the following features: 1. Two LED channels with adjustable brightness for use as a torch, or a flash strobe. 2. An RGB LED with 8-b...
null
null
null
[PATCH v3 00/13] Support for Samsung S2MU005 PMIC and its sub-devices
Certain Samsung S2M series PMICs have a flash LED controller with two LED channels, and with torch and flash control modes. Document the devicetree schema for the device. Acked-by: Conor Dooley <conor.dooley@microchip.com> Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org> --- .../bindings/leds/samsung,s2mu...
{ "author": "Kaustabh Chakraborty <kauschluss@disroot.org>", "date": "Wed, 25 Feb 2026 00:45:03 +0530", "is_openbsd": false, "thread_id": "DGPUA2NC5ZJI.O10VWM5D15B3@disroot.org.mbox.gz" }
lkml_critique
lkml
S2MU005 is an MFD chip manufactured by Samsung Electronics. This is found in various devices manufactured by Samsung and others, including all Exynos 7870 devices. It is known to have the following features: 1. Two LED channels with adjustable brightness for use as a torch, or a flash strobe. 2. An RGB LED with 8-b...
null
null
null
[PATCH v3 00/13] Support for Samsung S2MU005 PMIC and its sub-devices
Certain Samsung S2M series PMICs have a three-channel LED device with independent brightness control for each channel, typically used as status indicators in mobile phones. Document the devicetree schema for this device. Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org> --- .../bindings/leds/samsung,s2mu00...
{ "author": "Kaustabh Chakraborty <kauschluss@disroot.org>", "date": "Wed, 25 Feb 2026 00:45:04 +0530", "is_openbsd": false, "thread_id": "DGPUA2NC5ZJI.O10VWM5D15B3@disroot.org.mbox.gz" }
lkml_critique
lkml
S2MU005 is an MFD chip manufactured by Samsung Electronics. This is found in various devices manufactured by Samsung and others, including all Exynos 7870 devices. It is known to have the following features: 1. Two LED channels with adjustable brightness for use as a torch, or a flash strobe. 2. An RGB LED with 8-b...
null
null
null
[PATCH v3 00/13] Support for Samsung S2MU005 PMIC and its sub-devices
Certain Samsung S2M series PMICs have a MUIC device which reports various cable states by measuring the ID-GND resistance with an internal ADC. Document the devicetree schema for this device. Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org> --- .../bindings/extcon/samsung,s2mu005-muic.yaml | 39 +++++...
{ "author": "Kaustabh Chakraborty <kauschluss@disroot.org>", "date": "Wed, 25 Feb 2026 00:45:05 +0530", "is_openbsd": false, "thread_id": "DGPUA2NC5ZJI.O10VWM5D15B3@disroot.org.mbox.gz" }
lkml_critique
lkml
S2MU005 is an MFD chip manufactured by Samsung Electronics. This is found in various devices manufactured by Samsung and others, including all Exynos 7870 devices. It is known to have the following features: 1. Two LED channels with adjustable brightness for use as a torch, or a flash strobe. 2. An RGB LED with 8-b...
null
null
null
[PATCH v3 00/13] Support for Samsung S2MU005 PMIC and its sub-devices
Certain Samsung S2M series PMICs have a battery charger device which, among other things, manages power interfacing of the USB port. It may supply power, as done in USB OTG operation mode, or it may accept power and redirect it to the battery fuelgauge for charging. Document this device. Signed-off-by: Kaustabh Chakra...
{ "author": "Kaustabh Chakraborty <kauschluss@disroot.org>", "date": "Wed, 25 Feb 2026 00:45:06 +0530", "is_openbsd": false, "thread_id": "DGPUA2NC5ZJI.O10VWM5D15B3@disroot.org.mbox.gz" }
lkml_critique
lkml
S2MU005 is an MFD chip manufactured by Samsung Electronics. This is found in various devices manufactured by Samsung and others, including all Exynos 7870 devices. It is known to have the following features: 1. Two LED channels with adjustable brightness for use as a torch, or a flash strobe. 2. An RGB LED with 8-b...
null
null
null
[PATCH v3 00/13] Support for Samsung S2MU005 PMIC and its sub-devices
Samsung's S2MU005 PMIC includes subdevices for a charger, an MUIC (Micro USB Interface Controller), and flash and RGB LED controllers. Since regulators are not supported by this device, unmark this property as required and instead set this in a per-device basis for ones which need it. Add the compatible and documenta...
{ "author": "Kaustabh Chakraborty <kauschluss@disroot.org>", "date": "Wed, 25 Feb 2026 00:45:07 +0530", "is_openbsd": false, "thread_id": "DGPUA2NC5ZJI.O10VWM5D15B3@disroot.org.mbox.gz" }
lkml_critique
lkml
S2MU005 is an MFD chip manufactured by Samsung Electronics. This is found in various devices manufactured by Samsung and others, including all Exynos 7870 devices. It is known to have the following features: 1. Two LED channels with adjustable brightness for use as a torch, or a flash strobe. 2. An RGB LED with 8-b...
null
null
null
[PATCH v3 00/13] Support for Samsung S2MU005 PMIC and its sub-devices
Samsung's S2MU005 PMIC includes subdevices for a charger, an MUIC (Micro USB Interface Controller), and flash and RGB LED controllers. S2MU005's interrupt registers can be properly divided into three regmap IRQ chips, one each for the charger, flash LEDs, and the MUIC. Add initial support for S2MU005 in the PMIC driv...
{ "author": "Kaustabh Chakraborty <kauschluss@disroot.org>", "date": "Wed, 25 Feb 2026 00:45:08 +0530", "is_openbsd": false, "thread_id": "DGPUA2NC5ZJI.O10VWM5D15B3@disroot.org.mbox.gz" }
lkml_critique
lkml
S2MU005 is an MFD chip manufactured by Samsung Electronics. This is found in various devices manufactured by Samsung and others, including all Exynos 7870 devices. It is known to have the following features: 1. Two LED channels with adjustable brightness for use as a torch, or a flash strobe. 2. An RGB LED with 8-b...
null
null
null
[PATCH v3 00/13] Support for Samsung S2MU005 PMIC and its sub-devices
Kernel logs are filled with "DMA mask not set" messages for every sub-device. The device does not use DMA for communication, so these messages are useless. Disable the coherent DMA mask for the PMIC device, which is also propagated to sub-devices. Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org> --- drive...
{ "author": "Kaustabh Chakraborty <kauschluss@disroot.org>", "date": "Wed, 25 Feb 2026 00:45:09 +0530", "is_openbsd": false, "thread_id": "DGPUA2NC5ZJI.O10VWM5D15B3@disroot.org.mbox.gz" }
lkml_critique
lkml
S2MU005 is an MFD chip manufactured by Samsung Electronics. This is found in various devices manufactured by Samsung and others, including all Exynos 7870 devices. It is known to have the following features: 1. Two LED channels with adjustable brightness for use as a torch, or a flash strobe. 2. An RGB LED with 8-b...
null
null
null
[PATCH v3 00/13] Support for Samsung S2MU005 PMIC and its sub-devices
In devices other than S2MPG1X, the revision can be retrieved from the first register of the PMIC regmap. In S2MU005 however, the location is in offset 0x73. Introduce a switch-case block to allow selecting the REG_ID register. S2MU005 also has a field mask for the revision. Apply it using FIELD_GET() and get the extra...
{ "author": "Kaustabh Chakraborty <kauschluss@disroot.org>", "date": "Wed, 25 Feb 2026 00:45:10 +0530", "is_openbsd": false, "thread_id": "DGPUA2NC5ZJI.O10VWM5D15B3@disroot.org.mbox.gz" }
lkml_critique
lkml
S2MU005 is an MFD chip manufactured by Samsung Electronics. This is found in various devices manufactured by Samsung and others, including all Exynos 7870 devices. It is known to have the following features: 1. Two LED channels with adjustable brightness for use as a torch, or a flash strobe. 2. An RGB LED with 8-b...
null
null
null
[PATCH v3 00/13] Support for Samsung S2MU005 PMIC and its sub-devices
Add support for flash LEDs found in certain Samsung S2M series PMICs. The device has two channels for LEDs, typically for the back and front cameras in mobile devices. Both channels can be independently controlled, and can be operated in torch or flash modes. The driver includes initial support for the S2MU005 PMIC fl...
{ "author": "Kaustabh Chakraborty <kauschluss@disroot.org>", "date": "Wed, 25 Feb 2026 00:45:11 +0530", "is_openbsd": false, "thread_id": "DGPUA2NC5ZJI.O10VWM5D15B3@disroot.org.mbox.gz" }
lkml_critique
lkml
S2MU005 is an MFD chip manufactured by Samsung Electronics. This is found in various devices manufactured by Samsung and others, including all Exynos 7870 devices. It is known to have the following features: 1. Two LED channels with adjustable brightness for use as a torch, or a flash strobe. 2. An RGB LED with 8-b...
null
null
null
[PATCH v3 00/13] Support for Samsung S2MU005 PMIC and its sub-devices
Add support for the RGB LEDs found in certain Samsung S2M series PMICs. The device has three LED channels, controlled as a single device. These LEDs are typically used as status indicators in mobile phones. The driver includes initial support for the S2MU005 PMIC RGB LEDs. Signed-off-by: Kaustabh Chakraborty <kauschl...
{ "author": "Kaustabh Chakraborty <kauschluss@disroot.org>", "date": "Wed, 25 Feb 2026 00:45:12 +0530", "is_openbsd": false, "thread_id": "DGPUA2NC5ZJI.O10VWM5D15B3@disroot.org.mbox.gz" }
lkml_critique
lkml
S2MU005 is an MFD chip manufactured by Samsung Electronics. This is found in various devices manufactured by Samsung and others, including all Exynos 7870 devices. It is known to have the following features: 1. Two LED channels with adjustable brightness for use as a torch, or a flash strobe. 2. An RGB LED with 8-b...
null
null
null
[PATCH v3 00/13] Support for Samsung S2MU005 PMIC and its sub-devices
Add documentation to describe how hardware patterns (as defined by the documentation of led-class-multicolor) are parsed and implemented by the Samsung S2M series PMIC RGB LED driver. Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org> --- Documentation/leds/index.rst | 1 + Documentation/leds/leds-s...
{ "author": "Kaustabh Chakraborty <kauschluss@disroot.org>", "date": "Wed, 25 Feb 2026 00:45:13 +0530", "is_openbsd": false, "thread_id": "DGPUA2NC5ZJI.O10VWM5D15B3@disroot.org.mbox.gz" }
lkml_critique
lkml
S2MU005 is an MFD chip manufactured by Samsung Electronics. This is found in various devices manufactured by Samsung and others, including all Exynos 7870 devices. It is known to have the following features: 1. Two LED channels with adjustable brightness for use as a torch, or a flash strobe. 2. An RGB LED with 8-b...
null
null
null
[PATCH v3 00/13] Support for Samsung S2MU005 PMIC and its sub-devices
Add a driver for MUIC devices found in certain Samsung S2M series PMICs These are USB port accessory detectors. These devices report multiple cable states depending on the ID-GND resistance measured by an internal ADC. The driver includes initial support for the S2MU005 PMIC extcon. Signed-off-by: Kaustabh Chakrabort...
{ "author": "Kaustabh Chakraborty <kauschluss@disroot.org>", "date": "Wed, 25 Feb 2026 00:45:14 +0530", "is_openbsd": false, "thread_id": "DGPUA2NC5ZJI.O10VWM5D15B3@disroot.org.mbox.gz" }
lkml_critique
lkml
S2MU005 is an MFD chip manufactured by Samsung Electronics. This is found in various devices manufactured by Samsung and others, including all Exynos 7870 devices. It is known to have the following features: 1. Two LED channels with adjustable brightness for use as a torch, or a flash strobe. 2. An RGB LED with 8-b...
null
null
null
[PATCH v3 00/13] Support for Samsung S2MU005 PMIC and its sub-devices
Add a driver for charger controllers found in certain Samsung S2M series PMICs. The driver has very basic support for the device, with only charger online reporting working. The driver includes initial support for the S2MU005 PMIC charger. Signed-off-by: Kaustabh Chakraborty <kauschluss@disroot.org> --- drivers/powe...
{ "author": "Kaustabh Chakraborty <kauschluss@disroot.org>", "date": "Wed, 25 Feb 2026 00:45:15 +0530", "is_openbsd": false, "thread_id": "DGPUA2NC5ZJI.O10VWM5D15B3@disroot.org.mbox.gz" }
lkml_critique
lkml
S2MU005 is an MFD chip manufactured by Samsung Electronics. This is found in various devices manufactured by Samsung and others, including all Exynos 7870 devices. It is known to have the following features: 1. Two LED channels with adjustable brightness for use as a torch, or a flash strobe. 2. An RGB LED with 8-b...
null
null
null
[PATCH v3 00/13] Support for Samsung S2MU005 PMIC and its sub-devices
On Wed, Feb 25, 2026 at 12:45:06AM +0530, Kaustabh Chakraborty wrote: Review from v1 still applies. I think you ignored several reviews, so I will mark entire patchset as changes requested. Best regards, Krzysztof
{ "author": "Krzysztof Kozlowski <krzk@kernel.org>", "date": "Wed, 25 Feb 2026 11:44:46 +0100", "is_openbsd": false, "thread_id": "DGPUA2NC5ZJI.O10VWM5D15B3@disroot.org.mbox.gz" }
lkml_critique
lkml
S2MU005 is an MFD chip manufactured by Samsung Electronics. This is found in various devices manufactured by Samsung and others, including all Exynos 7870 devices. It is known to have the following features: 1. Two LED channels with adjustable brightness for use as a torch, or a flash strobe. 2. An RGB LED with 8-b...
null
null
null
[PATCH v3 00/13] Support for Samsung S2MU005 PMIC and its sub-devices
On 2026-02-25 11:44 +01:00, Krzysztof Kozlowski wrote: Somehow I missed this one... anyways I address them here: Why do you need a dedicated child node for this? It's got one property, other than the compatible, that you're using. It could easily just go in the parent without a dedicated node etc. The dt node ...
{ "author": "\"Kaustabh Chakraborty\" <kauschluss@disroot.org>", "date": "Fri, 27 Feb 2026 19:56:58 +0530", "is_openbsd": false, "thread_id": "DGPUA2NC5ZJI.O10VWM5D15B3@disroot.org.mbox.gz" }
lkml_critique
lkml
S2MU005 is an MFD chip manufactured by Samsung Electronics. This is found in various devices manufactured by Samsung and others, including all Exynos 7870 devices. It is known to have the following features: 1. Two LED channels with adjustable brightness for use as a torch, or a flash strobe. 2. An RGB LED with 8-b...
null
null
null
[PATCH v3 00/13] Support for Samsung S2MU005 PMIC and its sub-devices
On 2026-02-25 00:45 +05:30, Kaustabh Chakraborty wrote: A v1 review from Conor says: Why does this need a dedicated child node for just a port property? In v3, connector is added. This now has the same properties as maxim,max14526. If this still applies, it would be nice to have more insight...
{ "author": "\"Kaustabh Chakraborty\" <kauschluss@disroot.org>", "date": "Fri, 27 Feb 2026 20:41:46 +0530", "is_openbsd": false, "thread_id": "DGPUA2NC5ZJI.O10VWM5D15B3@disroot.org.mbox.gz" }
lkml_critique
lkml
Even though the type of the 'groups' property of a pinmux node is specified as string-array in pinmux-node.yaml, but trying to use multiple strings causes dtbs_check warnings. For example, checking the following dts ... $ cat arch/arm64/boot/dts/marvell/armada-3720-test.dts /dts-v1/; #include "armada-372x.dtsi...
null
null
null
[PATCH] dt-bindings: pinctrl: marvell,armada3710-xb-pinctrl: add missing items keyword
On 27/02/2026 at 15:15:54 +01, Gabor Juhos <j4g8y7@gmail.com> wrote: Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com> Thanks! Miquèl
{ "author": "Miquel Raynal <miquel.raynal@bootlin.com>", "date": "Fri, 27 Feb 2026 16:44:28 +0100", "is_openbsd": false, "thread_id": "20260227-a3720-pinctlr-missing-items-v1-1-e476e4df1ad6@gmail.com.mbox.gz" }
lkml_critique
lkml
Add devicetree bindings for the TI BQ25630 battery charger. It's I2C controlled and sends interrupts. Signed-off-by: Waqar Hameed <waqar.hameed@axis.com> --- .../bindings/power/supply/bq25630.yaml | 68 +++++++++++++++++++ 1 file changed, 68 insertions(+) create mode 100644 Documentation/devicetree/bindings/p...
null
null
null
[RFC PATCH 1/2] dt-bindings: power: supply: Add TI BQ25630 charger
This patch series contains a fully working driver for the basic functionality for the new TI BQ25630 charger (see datasheet [1]). However, some functionality has no straightforward implementation. The following features have therefore been left out and hopefully we can have some design discussions to reach a clear reso...
{ "author": "Waqar Hameed <waqar.hameed@axis.com>", "date": "Fri, 27 Feb 2026 16:35:32 +0100", "is_openbsd": false, "thread_id": "cover.1772201049.git.waqar.hameed@axis.com.mbox.gz" }
lkml_critique
lkml
Add devicetree bindings for the TI BQ25630 battery charger. It's I2C controlled and sends interrupts. Signed-off-by: Waqar Hameed <waqar.hameed@axis.com> --- .../bindings/power/supply/bq25630.yaml | 68 +++++++++++++++++++ 1 file changed, 68 insertions(+) create mode 100644 Documentation/devicetree/bindings/p...
null
null
null
[RFC PATCH 1/2] dt-bindings: power: supply: Add TI BQ25630 charger
TI BQ25630 is a battery charger that is I2C controlled. Despite its model name, it is rather different from the other devices in the BQ256xx family; it has a completely different register layout and some other additional functionality (see the datasheet for more details [1]). The most "annoying" thing is that it has t...
{ "author": "Waqar Hameed <waqar.hameed@axis.com>", "date": "Fri, 27 Feb 2026 16:35:33 +0100", "is_openbsd": false, "thread_id": "cover.1772201049.git.waqar.hameed@axis.com.mbox.gz" }
lkml_critique
lkml
According to internal documentation, on SM8650, when the PHY is configured in Gear 4, the QPHY_V6_PCS_UFS_PLL_CNTL register needs to have the same value as for Gear 5. At the moment, there is no board that comes with a UFS 3.x device, so this issue doesn't show up, but with the new Eliza SoC, which uses the same init ...
null
null
null
[PATCH] phy: qcom: qmp-ufs: Fix SM8650 PCS table for Gear 4
On 2/19/26 12:11 PM, Abel Vesa wrote: Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Konrad
{ "author": "Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>", "date": "Thu, 19 Feb 2026 14:34:57 +0100", "is_openbsd": false, "thread_id": "177220591758.320398.17176823670810946893.b4-ty@kernel.org.mbox.gz" }
lkml_critique
lkml
According to internal documentation, on SM8650, when the PHY is configured in Gear 4, the QPHY_V6_PCS_UFS_PLL_CNTL register needs to have the same value as for Gear 5. At the moment, there is no board that comes with a UFS 3.x device, so this issue doesn't show up, but with the new Eliza SoC, which uses the same init ...
null
null
null
[PATCH] phy: qcom: qmp-ufs: Fix SM8650 PCS table for Gear 4
On 2/19/26 12:11, Abel Vesa wrote: Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org> Tested-by: Neil Armstrong <neil.armstrong@linaro.org> # on SM8650-HDK Thanks, Neil
{ "author": "Neil Armstrong <neil.armstrong@linaro.org>", "date": "Fri, 20 Feb 2026 09:30:27 +0100", "is_openbsd": false, "thread_id": "177220591758.320398.17176823670810946893.b4-ty@kernel.org.mbox.gz" }
lkml_critique
lkml
According to internal documentation, on SM8650, when the PHY is configured in Gear 4, the QPHY_V6_PCS_UFS_PLL_CNTL register needs to have the same value as for Gear 5. At the moment, there is no board that comes with a UFS 3.x device, so this issue doesn't show up, but with the new Eliza SoC, which uses the same init ...
null
null
null
[PATCH] phy: qcom: qmp-ufs: Fix SM8650 PCS table for Gear 4
On Thu, 19 Feb 2026 13:11:48 +0200, Abel Vesa wrote: Applied, thanks! [1/1] phy: qcom: qmp-ufs: Fix SM8650 PCS table for Gear 4 commit: 81af9e40e2e4e1aa95f09fb34811760be6742c58 Best regards, -- ~Vinod
{ "author": "Vinod Koul <vkoul@kernel.org>", "date": "Fri, 27 Feb 2026 20:55:17 +0530", "is_openbsd": false, "thread_id": "177220591758.320398.17176823670810946893.b4-ty@kernel.org.mbox.gz" }
lkml_critique
lkml
The gate action can be replaced while the hrtimer callback or dump path is walking the schedule list. Convert the parameters to an RCU-protected snapshot and swap updates under tcf_lock, freeing the previous snapshot via call_rcu(). When REPLACE omits the entry list, preserve the existing schedule so the effective sta...
null
null
null
[PATCH net v8 1/1] net/sched: act_gate: snapshot parameters with RCU on replace
This series fixes a schedule lifetime race in `act_gate` between the control-plane replace path and the running hrtimer callback (`gate_timer_func`). Changes since v7: - remove unreachable `!cycletime` error branch and dead `unlock:` label Paul Moses (1): net/sched: act_gate: snapshot parameters with RCU on replace...
{ "author": "Paul Moses <p@1g4.org>", "date": "Mon, 23 Feb 2026 15:05:39 +0000", "is_openbsd": false, "thread_id": "20260227145628.hcqon4eokhx54ai4@skbuf.mbox.gz" }
lkml_critique
lkml
The gate action can be replaced while the hrtimer callback or dump path is walking the schedule list. Convert the parameters to an RCU-protected snapshot and swap updates under tcf_lock, freeing the previous snapshot via call_rcu(). When REPLACE omits the entry list, preserve the existing schedule so the effective sta...
null
null
null
[PATCH net v8 1/1] net/sched: act_gate: snapshot parameters with RCU on replace
On Mon, Feb 23, 2026 at 10:05 AM Paul Moses <p@1g4.org> wrote: Looks good - but can we have Vlad (added to Cc) review this as well in case it breaks anything in the offload case? More specifically, regarding an update policy.. cheers, jamal
{ "author": "Jamal Hadi Salim <jhs@mojatatu.com>", "date": "Wed, 25 Feb 2026 08:55:30 -0500", "is_openbsd": false, "thread_id": "20260227145628.hcqon4eokhx54ai4@skbuf.mbox.gz" }
lkml_critique
lkml
The gate action can be replaced while the hrtimer callback or dump path is walking the schedule list. Convert the parameters to an RCU-protected snapshot and swap updates under tcf_lock, freeing the previous snapshot via call_rcu(). When REPLACE omits the entry list, preserve the existing schedule so the effective sta...
null
null
null
[PATCH net v8 1/1] net/sched: act_gate: snapshot parameters with RCU on replace
On Wed, Feb 25, 2026 at 08:55:30AM -0500, Jamal Hadi Salim wrote: I've regression-tested this with tools/testing/selftests/drivers/net/ocelot/psfp.sh and haven't noticed issues. However, that doesn't test very much of the action possibilities - no dynamic gate parameters change (as part of standalone action or bound ...
{ "author": "Vladimir Oltean <vladimir.oltean@nxp.com>", "date": "Fri, 27 Feb 2026 03:31:51 +0200", "is_openbsd": false, "thread_id": "20260227145628.hcqon4eokhx54ai4@skbuf.mbox.gz" }
lkml_critique
lkml
The gate action can be replaced while the hrtimer callback or dump path is walking the schedule list. Convert the parameters to an RCU-protected snapshot and swap updates under tcf_lock, freeing the previous snapshot via call_rcu(). When REPLACE omits the entry list, preserve the existing schedule so the effective sta...
null
null
null
[PATCH net v8 1/1] net/sched: act_gate: snapshot parameters with RCU on replace
On Fri, Feb 27, 2026 at 7:07 AM Paul Moses <p@1g4.org> wrote: Yes, it just means that Vladmir's hardware doesnt like replacement of an existing rule, therefore it gets rejected with that message (error code -EEXIST). Yes, the message is not the best it can be but could be fixed later. Thanks Vladmir for spending the t...
{ "author": "Jamal Hadi Salim <jhs@mojatatu.com>", "date": "Fri, 27 Feb 2026 08:16:41 -0500", "is_openbsd": false, "thread_id": "20260227145628.hcqon4eokhx54ai4@skbuf.mbox.gz" }
lkml_critique
lkml
MANA relies on page_pool for RX buffers, and the buffer refill paths can behave quite differently across architectures and configurations (e.g. base page size, fragment vs full-page usage). This makes it harder to understand and compare RX buffer behavior when investigating performance and memory differences across pla...
null
null
null
[PATCH net-next] net: mana: Expose page_pool stats via ethtool
You should not need this #ifdef. The stubs should make the code do sensible things if CONFIG_PAGE_POOL_STATS is not enabled. Andrew
{ "author": "Andrew Lunn <andrew@lunn.ch>", "date": "Fri, 27 Feb 2026 16:11:05 +0100", "is_openbsd": false, "thread_id": "74a4113a-1e44-42a4-b366-c0e54fe84497@lunn.ch.mbox.gz" }
lkml_critique
lkml
Replace unbounded sprintf() calls with the safer snprintf(). Avoid using magic numbers and use strlen() to calculate the key descriptor buffer size. Save the size in a local variable and reuse it for the bounded snprintf() calls. Remove CIFSCREDS_DESC_SIZE. Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev> --- f...
null
null
null
[PATCH] smb: client: Use snprintf in cifs_set_cifscreds
merged into cifs-2.6.git for-next pending additional review and testing On Thu, Feb 26, 2026 at 4:16 PM Thorsten Blum <thorsten.blum@linux.dev> wrote: -- Thanks, Steve
{ "author": "Steve French <smfrench@gmail.com>", "date": "Thu, 26 Feb 2026 17:26:04 -0600", "is_openbsd": false, "thread_id": "be77b89f71b05754469c8e6945e907bc@manguebit.org.mbox.gz" }
lkml_critique
lkml
Replace unbounded sprintf() calls with the safer snprintf(). Avoid using magic numbers and use strlen() to calculate the key descriptor buffer size. Save the size in a local variable and reuse it for the bounded snprintf() calls. Remove CIFSCREDS_DESC_SIZE. Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev> --- f...
null
null
null
[PATCH] smb: client: Use snprintf in cifs_set_cifscreds
Thorsten Blum <thorsten.blum@linux.dev> writes: Acked-by: Paulo Alcantara (Red Hat) <pc@manguebit.org>
{ "author": "Paulo Alcantara <pc@manguebit.org>", "date": "Fri, 27 Feb 2026 12:03:01 -0300", "is_openbsd": false, "thread_id": "be77b89f71b05754469c8e6945e907bc@manguebit.org.mbox.gz" }
lkml_critique
lkml
Add a way for Rust code to create fault-injection control points. The control points can be attached to a configfs tree as default groups and controlled from user space. On the kernel side, provide a `should_fail` method to query if an operation should fail. Cc: Akinobu Mita <akinobu.mita@gmail.com> Signed-off-by: And...
null
null
null
[PATCH] fault-inject: rust: add a Rust API for fault-injection
On Sun Feb 15, 2026 at 9:30 PM GMT, Andreas Hindborg wrote: #[inline] What is the meaning of a negative `size` here? I did a quick grep on the C codebase and cannot find a case where negative number is used here. It is either number of bytes for allocations, or `1` for when injecting based on number of operations p...
{ "author": "\"Gary Guo\" <gary@garyguo.net>", "date": "Fri, 27 Feb 2026 14:32:13 +0000", "is_openbsd": false, "thread_id": "DGPTFSM1EK7V.1VEG57EE9DT6K@garyguo.net.mbox.gz" }
lkml_critique
lkml
If no KTAP header is found in the kernel output (e.g., because the kernel crashed before the KUnit executor was run), it's very useful to re-run the test with --raw_output=all, as that will show any error output (such as a stacktrace, log message, BUG, etc). This is not particularly intuitive, however, as --raw_output=...
null
null
null
[PATCH] kunit: tool: Recommend --raw_output=all if no KTAP found
On Fri, Feb 27, 2026 at 06:56:49PM +0800, David Gow wrote: What's the difference to "full"? Thanks for adding this, btw! -- With Best Regards, Andy Shevchenko
{ "author": "Andy Shevchenko <andriy.shevchenko@intel.com>", "date": "Fri, 27 Feb 2026 16:46:44 +0200", "is_openbsd": false, "thread_id": "aaGuVA4q5BXSxBWX@ashevche-desk.local.mbox.gz" }
lkml_critique
lkml
We shall send forget request if lookup/create/open success but returned outarg.attr is invalid, because FUSEdaemon had increase the lookup count Reported-by: Xie Yongji <xieyongji@bytedance.com> Signed-off-by: Zhang Tianci <zhangtianci.1997@bytedance.com> --- Changes in v2: - Fix wrong usage of goto label. ...
null
null
null
[PATCH v2] fuse: send forget req when lookup outarg is invalid
On Thu, 26 Feb 2026 at 13:50, Zhang Tianci <zhangtianci.1997@bytedance.com> wrote: These are cases when the fuse daemon is broken anyway. Keeping it working does not make much sense, and adds complexity to the kernel. So NAK unless there's a use case which explains why this would be a good thing. Thanks, Miklos
{ "author": "Miklos Szeredi <miklos@szeredi.hu>", "date": "Fri, 27 Feb 2026 16:34:36 +0100", "is_openbsd": false, "thread_id": "CAJfpeguobO4UHmb1n+zQUMrSCH0FYh6DLAWNfGYNj29iX9Pxjg@mail.gmail.com.mbox.gz" }
lkml_critique
lkml
Hi, This is based on today's linux.git. A git branch with this (plus a fix for a CLIPPY warning on a core Rust for Linux issue which I suspect others have already found and fixed) is here: https://github.com/johnhubbard/linux/tree/nova-core-blackwell-v5 This is quite a large overhaul, multiple passes to fix up a...
null
null
null
[PATCH v5 00/38] gpu: nova-core: firmware: Hopper/Blackwell support
The auxiliary device registration was using a hardcoded ID of 0, which caused probe() to fail on multi-GPU systems with: sysfs: cannot create duplicate filename '/bus/auxiliary/devices/NovaCore.nova-drm.0' Fix this by using an atomic counter to generate unique IDs for each GPU's aux device registration. The TODO i...
{ "author": "John Hubbard <jhubbard@nvidia.com>", "date": "Fri, 20 Feb 2026 18:09:15 -0800", "is_openbsd": false, "thread_id": "DGPUWPJCFPZH.4NVAAQS1I6HR@garyguo.net.mbox.gz" }
lkml_critique
lkml
Hi, This is based on today's linux.git. A git branch with this (plus a fix for a CLIPPY warning on a core Rust for Linux issue which I suspect others have already found and fixed) is here: https://github.com/johnhubbard/linux/tree/nova-core-blackwell-v5 This is quite a large overhaul, multiple passes to fix up a...
null
null
null
[PATCH v5 00/38] gpu: nova-core: firmware: Hopper/Blackwell support
The dev_dbg!, dev_info!, dev_err!, and dev_warn! macros now accept pci::Device directly without requiring an explicit .as_ref() conversion to device::Device, thanks to commit a38cd1fea989 ("rust: device: support `dev_printk` on all devices"). Signed-off-by: John Hubbard <jhubbard@nvidia.com> --- drivers/gpu/nova-core...
{ "author": "John Hubbard <jhubbard@nvidia.com>", "date": "Fri, 20 Feb 2026 18:09:16 -0800", "is_openbsd": false, "thread_id": "DGPUWPJCFPZH.4NVAAQS1I6HR@garyguo.net.mbox.gz" }
lkml_critique
lkml
Hi, This is based on today's linux.git. A git branch with this (plus a fix for a CLIPPY warning on a core Rust for Linux issue which I suspect others have already found and fixed) is here: https://github.com/johnhubbard/linux/tree/nova-core-blackwell-v5 This is quite a large overhaul, multiple passes to fix up a...
null
null
null
[PATCH v5 00/38] gpu: nova-core: firmware: Hopper/Blackwell support
For convenience of the reader: now you can directly see the sizes of each range. It is surprising just how much this helps. Sample output (using an Ampere GA104): NovaCore 0000:e1:00.0: FbLayout { fb: 0x0..0x3ff800000 (16376 MiB), vga_workspace: 0x3ff700000..0x3ff800000 (1 MiB), frts: 0x3ff600000..0x3ff70...
{ "author": "John Hubbard <jhubbard@nvidia.com>", "date": "Fri, 20 Feb 2026 18:09:17 -0800", "is_openbsd": false, "thread_id": "DGPUWPJCFPZH.4NVAAQS1I6HR@garyguo.net.mbox.gz" }
lkml_critique
lkml
Hi, This is based on today's linux.git. A git branch with this (plus a fix for a CLIPPY warning on a core Rust for Linux issue which I suspect others have already found and fixed) is here: https://github.com/johnhubbard/linux/tree/nova-core-blackwell-v5 This is quite a large overhaul, multiple passes to fix up a...
null
null
null
[PATCH v5 00/38] gpu: nova-core: firmware: Hopper/Blackwell support
A tiny simplification: now that FbLayout uses its own specific FbRange type, add an FbRange.len() method, and use that to (very slightly) simplify the calculation of Frts::frts_size initialization. Suggested-by: Alexandre Courbot <acourbot@nvidia.com> Reviewed-by: Gary Guo <gary@garyguo.net> Signed-off-by: John Hubbar...
{ "author": "John Hubbard <jhubbard@nvidia.com>", "date": "Fri, 20 Feb 2026 18:09:18 -0800", "is_openbsd": false, "thread_id": "DGPUWPJCFPZH.4NVAAQS1I6HR@garyguo.net.mbox.gz" }
lkml_critique
lkml
Hi, This is based on today's linux.git. A git branch with this (plus a fix for a CLIPPY warning on a core Rust for Linux issue which I suspect others have already found and fixed) is here: https://github.com/johnhubbard/linux/tree/nova-core-blackwell-v5 This is quite a large overhaul, multiple passes to fix up a...
null
null
null
[PATCH v5 00/38] gpu: nova-core: firmware: Hopper/Blackwell support
Keep Gsp::new() from getting too cluttered, by factoring out the selection of .fwsignature* items. This will continue to grow as we add GPUs. Cc: Danilo Krummrich <dakr@kernel.org> Reviewed-by: Gary Guo <gary@garyguo.net> Signed-off-by: John Hubbard <jhubbard@nvidia.com> --- drivers/gpu/nova-core/firmware/gsp.rs | 60...
{ "author": "John Hubbard <jhubbard@nvidia.com>", "date": "Fri, 20 Feb 2026 18:09:20 -0800", "is_openbsd": false, "thread_id": "DGPUWPJCFPZH.4NVAAQS1I6HR@garyguo.net.mbox.gz" }
lkml_critique
lkml
Hi, This is based on today's linux.git. A git branch with this (plus a fix for a CLIPPY warning on a core Rust for Linux issue which I suspect others have already found and fixed) is here: https://github.com/johnhubbard/linux/tree/nova-core-blackwell-v5 This is quite a large overhaul, multiple passes to fix up a...
null
null
null
[PATCH v5 00/38] gpu: nova-core: firmware: Hopper/Blackwell support
Hopper (GH100) and Blackwell identification, including ELF .fwsignature_* items. Signed-off-by: John Hubbard <jhubbard@nvidia.com> --- drivers/gpu/nova-core/falcon/hal.rs | 3 ++- drivers/gpu/nova-core/fb/hal.rs | 5 ++--- drivers/gpu/nova-core/firmware/gsp.rs | 17 +++++++++++++++++ drivers/gpu/nova-core/g...
{ "author": "John Hubbard <jhubbard@nvidia.com>", "date": "Fri, 20 Feb 2026 18:09:19 -0800", "is_openbsd": false, "thread_id": "DGPUWPJCFPZH.4NVAAQS1I6HR@garyguo.net.mbox.gz" }
lkml_critique
lkml
Hi, This is based on today's linux.git. A git branch with this (plus a fix for a CLIPPY warning on a core Rust for Linux issue which I suspect others have already found and fixed) is here: https://github.com/johnhubbard/linux/tree/nova-core-blackwell-v5 This is quite a large overhaul, multiple passes to fix up a...
null
null
null
[PATCH v5 00/38] gpu: nova-core: firmware: Hopper/Blackwell support
As per [1], we need one "use" item per line, in order to reduce merge conflicts. Furthermore, we need a trailing ", //" in order to tell rustfmt(1) to leave it alone. This does that for commands.rs, which is the only file in nova-core that has any remaining instances of the old style. [1] https://docs.kernel.org/rust...
{ "author": "John Hubbard <jhubbard@nvidia.com>", "date": "Fri, 20 Feb 2026 18:09:22 -0800", "is_openbsd": false, "thread_id": "DGPUWPJCFPZH.4NVAAQS1I6HR@garyguo.net.mbox.gz" }
lkml_critique
lkml
Hi, This is based on today's linux.git. A git branch with this (plus a fix for a CLIPPY warning on a core Rust for Linux issue which I suspect others have already found and fixed) is here: https://github.com/johnhubbard/linux/tree/nova-core-blackwell-v5 This is quite a large overhaul, multiple passes to fix up a...
null
null
null
[PATCH v5 00/38] gpu: nova-core: firmware: Hopper/Blackwell support
Replace per-chipset match arms with Architecture-based matching in the falcon and FB HAL selection functions. This reduces the number of match arms that need updating when new chipsets are added within an existing architecture. Signed-off-by: John Hubbard <jhubbard@nvidia.com> --- drivers/gpu/nova-core/falcon/hal.rs ...
{ "author": "John Hubbard <jhubbard@nvidia.com>", "date": "Fri, 20 Feb 2026 18:09:21 -0800", "is_openbsd": false, "thread_id": "DGPUWPJCFPZH.4NVAAQS1I6HR@garyguo.net.mbox.gz" }
lkml_critique
lkml
Hi, This is based on today's linux.git. A git branch with this (plus a fix for a CLIPPY warning on a core Rust for Linux issue which I suspect others have already found and fixed) is here: https://github.com/johnhubbard/linux/tree/nova-core-blackwell-v5 This is quite a large overhaul, multiple passes to fix up a...
null
null
null
[PATCH v5 00/38] gpu: nova-core: firmware: Hopper/Blackwell support
Move Spec creation, the dev_info log, and DMA mask setup from the driver's probe() into Gpu::new(), so that all GPU-specific initialization lives in the Gpu constructor. This restructures Gpu::new() to use pin_init_scope wrapping try_pin_init!, which allows running fallible setup code (Spec::new, dma_set_mask_and_cohe...
{ "author": "John Hubbard <jhubbard@nvidia.com>", "date": "Fri, 20 Feb 2026 18:09:23 -0800", "is_openbsd": false, "thread_id": "DGPUWPJCFPZH.4NVAAQS1I6HR@garyguo.net.mbox.gz" }
lkml_critique
lkml
Hi, This is based on today's linux.git. A git branch with this (plus a fix for a CLIPPY warning on a core Rust for Linux issue which I suspect others have already found and fixed) is here: https://github.com/johnhubbard/linux/tree/nova-core-blackwell-v5 This is quite a large overhaul, multiple passes to fix up a...
null
null
null
[PATCH v5 00/38] gpu: nova-core: firmware: Hopper/Blackwell support
Replace the hardcoded 47-bit DMA mask with per-architecture values. Hopper and Blackwell support 52-bit DMA addresses, while Turing, Ampere, and Ada use 47-bit. Add Architecture::dma_mask() as a const method with an exhaustive match, so that new architectures will get a compile-time reminder to specify their DMA mask ...
{ "author": "John Hubbard <jhubbard@nvidia.com>", "date": "Fri, 20 Feb 2026 18:09:24 -0800", "is_openbsd": false, "thread_id": "DGPUWPJCFPZH.4NVAAQS1I6HR@garyguo.net.mbox.gz" }
lkml_critique
lkml
Hi, This is based on today's linux.git. A git branch with this (plus a fix for a CLIPPY warning on a core Rust for Linux issue which I suspect others have already found and fixed) is here: https://github.com/johnhubbard/linux/tree/nova-core-blackwell-v5 This is quite a large overhaul, multiple passes to fix up a...
null
null
null
[PATCH v5 00/38] gpu: nova-core: firmware: Hopper/Blackwell support
Hopper and Blackwell GPUs use FSP-based secure boot and do not require waiting for GFW_BOOT completion. Skip this step for these architectures, and in fact for all future architectures, because we have moved on: there will not be any future GPUs using the older GFW_BOOT system. Cc: Danilo Krummrich <dakr@kernel.org> S...
{ "author": "John Hubbard <jhubbard@nvidia.com>", "date": "Fri, 20 Feb 2026 18:09:25 -0800", "is_openbsd": false, "thread_id": "DGPUWPJCFPZH.4NVAAQS1I6HR@garyguo.net.mbox.gz" }
lkml_critique
lkml
Hi, This is based on today's linux.git. A git branch with this (plus a fix for a CLIPPY warning on a core Rust for Linux issue which I suspect others have already found and fixed) is here: https://github.com/johnhubbard/linux/tree/nova-core-blackwell-v5 This is quite a large overhaul, multiple passes to fix up a...
null
null
null
[PATCH v5 00/38] gpu: nova-core: firmware: Hopper/Blackwell support
Factor out a chunk of complexity into a new subroutine. This is an incremental step in adding ELF32 support to the existing ELF64 section support, for handling GPU firmware. Signed-off-by: John Hubbard <jhubbard@nvidia.com> --- drivers/gpu/nova-core/firmware.rs | 40 ++++++++++++------------------- 1 file changed, 15...
{ "author": "John Hubbard <jhubbard@nvidia.com>", "date": "Fri, 20 Feb 2026 18:09:27 -0800", "is_openbsd": false, "thread_id": "DGPUWPJCFPZH.4NVAAQS1I6HR@garyguo.net.mbox.gz" }
lkml_critique
lkml
Hi, This is based on today's linux.git. A git branch with this (plus a fix for a CLIPPY warning on a core Rust for Linux issue which I suspect others have already found and fixed) is here: https://github.com/johnhubbard/linux/tree/nova-core-blackwell-v5 This is quite a large overhaul, multiple passes to fix up a...
null
null
null
[PATCH v5 00/38] gpu: nova-core: firmware: Hopper/Blackwell support
Up until now, only the GSP required parsing of its firmware headers. However, upcoming support for Hopper/Blackwell+ adds another firmware image (FMC), along with another format (ELF32). Therefore, the current ELF64 section parsing support needs to be moved up a level, so that both of the above can use it. There are ...
{ "author": "John Hubbard <jhubbard@nvidia.com>", "date": "Fri, 20 Feb 2026 18:09:26 -0800", "is_openbsd": false, "thread_id": "DGPUWPJCFPZH.4NVAAQS1I6HR@garyguo.net.mbox.gz" }
lkml_critique
lkml
Hi, This is based on today's linux.git. A git branch with this (plus a fix for a CLIPPY warning on a core Rust for Linux issue which I suspect others have already found and fixed) is here: https://github.com/johnhubbard/linux/tree/nova-core-blackwell-v5 This is quite a large overhaul, multiple passes to fix up a...
null
null
null
[PATCH v5 00/38] gpu: nova-core: firmware: Hopper/Blackwell support
Add ELF32 header and section header newtypes with ElfHeader and ElfSectionHeader trait implementations, mirroring the existing ELF64 support. Add elf32_section() for extracting sections from ELF32 images. Signed-off-by: John Hubbard <jhubbard@nvidia.com> --- drivers/gpu/nova-core/firmware.rs | 46 ++++++++++++++++++++...
{ "author": "John Hubbard <jhubbard@nvidia.com>", "date": "Fri, 20 Feb 2026 18:09:29 -0800", "is_openbsd": false, "thread_id": "DGPUWPJCFPZH.4NVAAQS1I6HR@garyguo.net.mbox.gz" }
lkml_critique
lkml
Hi, This is based on today's linux.git. A git branch with this (plus a fix for a CLIPPY warning on a core Rust for Linux issue which I suspect others have already found and fixed) is here: https://github.com/johnhubbard/linux/tree/nova-core-blackwell-v5 This is quite a large overhaul, multiple passes to fix up a...
null
null
null
[PATCH v5 00/38] gpu: nova-core: firmware: Hopper/Blackwell support
Add ElfHeader and ElfSectionHeader traits to abstract out differences between ELF32 and ELF64. Implement these for ELF64. This is in preparation for upcoming ELF32 section support, and for auto-selecting ELF32 or ELF64. Signed-off-by: John Hubbard <jhubbard@nvidia.com> --- drivers/gpu/nova-core/firmware.rs | 99 ++++...
{ "author": "John Hubbard <jhubbard@nvidia.com>", "date": "Fri, 20 Feb 2026 18:09:28 -0800", "is_openbsd": false, "thread_id": "DGPUWPJCFPZH.4NVAAQS1I6HR@garyguo.net.mbox.gz" }
lkml_critique
lkml
Hi, This is based on today's linux.git. A git branch with this (plus a fix for a CLIPPY warning on a core Rust for Linux issue which I suspect others have already found and fixed) is here: https://github.com/johnhubbard/linux/tree/nova-core-blackwell-v5 This is quite a large overhaul, multiple passes to fix up a...
null
null
null
[PATCH v5 00/38] gpu: nova-core: firmware: Hopper/Blackwell support
Add elf_section() which automatically detects ELF32 vs ELF64 based on the ELF header's class byte, and dispatches to the appropriate parser. Switch gsp.rs callers from elf64_section() to elf_section(), making both elf32_section() and elf64_section() private. Signed-off-by: John Hubbard <jhubbard@nvidia.com> --- drive...
{ "author": "John Hubbard <jhubbard@nvidia.com>", "date": "Fri, 20 Feb 2026 18:09:30 -0800", "is_openbsd": false, "thread_id": "DGPUWPJCFPZH.4NVAAQS1I6HR@garyguo.net.mbox.gz" }
lkml_critique
lkml
Hi, This is based on today's linux.git. A git branch with this (plus a fix for a CLIPPY warning on a core Rust for Linux issue which I suspect others have already found and fixed) is here: https://github.com/johnhubbard/linux/tree/nova-core-blackwell-v5 This is quite a large overhaul, multiple passes to fix up a...
null
null
null
[PATCH v5 00/38] gpu: nova-core: firmware: Hopper/Blackwell support
FSP is a hardware unit that runs FMC firmware. The FMC ELF file is loaded and stored in two forms: the "image" ELF section alone (which FSP uses for boot) and the full ELF (needed later for signature extraction during Chain of Trust verification). Co-developed-by: Alexandre Courbot <acourbot@nvidia.com> Signed-off-by:...
{ "author": "John Hubbard <jhubbard@nvidia.com>", "date": "Fri, 20 Feb 2026 18:09:31 -0800", "is_openbsd": false, "thread_id": "DGPUWPJCFPZH.4NVAAQS1I6HR@garyguo.net.mbox.gz" }
lkml_critique
lkml
Hi, This is based on today's linux.git. A git branch with this (plus a fix for a CLIPPY warning on a core Rust for Linux issue which I suspect others have already found and fixed) is here: https://github.com/johnhubbard/linux/tree/nova-core-blackwell-v5 This is quite a large overhaul, multiple passes to fix up a...
null
null
null
[PATCH v5 00/38] gpu: nova-core: firmware: Hopper/Blackwell support
Add the FSP (Firmware System Processor) falcon engine type that will handle secure boot and Chain of Trust operations on Hopper and Blackwell architectures. The FSP falcon replaces SEC2's role in the boot sequence for these newer architectures. This initial stub just defines the falcon type and its base address. Sign...
{ "author": "John Hubbard <jhubbard@nvidia.com>", "date": "Fri, 20 Feb 2026 18:09:32 -0800", "is_openbsd": false, "thread_id": "DGPUWPJCFPZH.4NVAAQS1I6HR@garyguo.net.mbox.gz" }
lkml_critique
lkml
Hi, This is based on today's linux.git. A git branch with this (plus a fix for a CLIPPY warning on a core Rust for Linux issue which I suspect others have already found and fixed) is here: https://github.com/johnhubbard/linux/tree/nova-core-blackwell-v5 This is quite a large overhaul, multiple passes to fix up a...
null
null
null
[PATCH v5 00/38] gpu: nova-core: firmware: Hopper/Blackwell support
Add const_align_up<ALIGN>() to kernel::ptr as the const-compatible equivalent of Alignable::align_up(). This uses inline_const to validate the alignment at compile time with a clear error message. Add inline_const to rust_allowed_features in scripts/Makefile.build, following the approach in [1]. [1] https://lore.kern...
{ "author": "John Hubbard <jhubbard@nvidia.com>", "date": "Fri, 20 Feb 2026 18:09:35 -0800", "is_openbsd": false, "thread_id": "DGPUWPJCFPZH.4NVAAQS1I6HR@garyguo.net.mbox.gz" }
lkml_critique
lkml
Hi, This is based on today's linux.git. A git branch with this (plus a fix for a CLIPPY warning on a core Rust for Linux issue which I suspect others have already found and fixed) is here: https://github.com/johnhubbard/linux/tree/nova-core-blackwell-v5 This is quite a large overhaul, multiple passes to fix up a...
null
null
null
[PATCH v5 00/38] gpu: nova-core: firmware: Hopper/Blackwell support
Add external memory (EMEM) read/write operations to the GPU's FSP falcon engine. These operations use Falcon PIO (Programmed I/O) to communicate with the FSP through indirect memory access. Cc: Gary Guo <gary@garyguo.net> Cc: Timur Tabi <ttabi@nvidia.com> Signed-off-by: John Hubbard <jhubbard@nvidia.com> --- drivers/...
{ "author": "John Hubbard <jhubbard@nvidia.com>", "date": "Fri, 20 Feb 2026 18:09:33 -0800", "is_openbsd": false, "thread_id": "DGPUWPJCFPZH.4NVAAQS1I6HR@garyguo.net.mbox.gz" }
lkml_critique
lkml
Hi, This is based on today's linux.git. A git branch with this (plus a fix for a CLIPPY warning on a core Rust for Linux issue which I suspect others have already found and fixed) is here: https://github.com/johnhubbard/linux/tree/nova-core-blackwell-v5 This is quite a large overhaul, multiple passes to fix up a...
null
null
null
[PATCH v5 00/38] gpu: nova-core: firmware: Hopper/Blackwell support
Add FspCotVersion to represent the FSP Chain of Trust protocol version, and Chipset::fsp_cot_version() which returns the version for each architecture. Hopper uses version 1, Blackwell uses version 2. Non-FSP architectures return None. Signed-off-by: John Hubbard <jhubbard@nvidia.com> --- drivers/gpu/nova-core/fsp.rs...
{ "author": "John Hubbard <jhubbard@nvidia.com>", "date": "Fri, 20 Feb 2026 18:09:42 -0800", "is_openbsd": false, "thread_id": "DGPUWPJCFPZH.4NVAAQS1I6HR@garyguo.net.mbox.gz" }
lkml_critique
lkml
Hi, This is based on today's linux.git. A git branch with this (plus a fix for a CLIPPY warning on a core Rust for Linux issue which I suspect others have already found and fixed) is here: https://github.com/johnhubbard/linux/tree/nova-core-blackwell-v5 This is quite a large overhaul, multiple passes to fix up a...
null
null
null
[PATCH v5 00/38] gpu: nova-core: firmware: Hopper/Blackwell support
Add the FSP messaging infrastructure needed for Chain of Trust communication on Hopper/Blackwell GPUs. Reviewed-by: Joel Fernandes <joelagnelf@nvidia.com> Signed-off-by: John Hubbard <jhubbard@nvidia.com> --- drivers/gpu/nova-core/falcon/fsp.rs | 79 ++++++++++++++++++++++++++++- drivers/gpu/nova-core/regs.rs |...
{ "author": "John Hubbard <jhubbard@nvidia.com>", "date": "Fri, 20 Feb 2026 18:09:34 -0800", "is_openbsd": false, "thread_id": "DGPUWPJCFPZH.4NVAAQS1I6HR@garyguo.net.mbox.gz" }
lkml_critique
lkml
Hi, This is based on today's linux.git. A git branch with this (plus a fix for a CLIPPY warning on a core Rust for Linux issue which I suspect others have already found and fixed) is here: https://github.com/johnhubbard/linux/tree/nova-core-blackwell-v5 This is quite a large overhaul, multiple passes to fix up a...
null
null
null
[PATCH v5 00/38] gpu: nova-core: firmware: Hopper/Blackwell support
Add extract_fmc_signatures() which extracts SHA-384 hash, RSA public key, and RSA signature from FMC ELF32 firmware sections. These are needed for FSP Chain of Trust verification. Signed-off-by: John Hubbard <jhubbard@nvidia.com> --- drivers/gpu/nova-core/firmware.rs | 1 - drivers/gpu/nova-core/fsp.rs | 61 +++...
{ "author": "John Hubbard <jhubbard@nvidia.com>", "date": "Fri, 20 Feb 2026 18:09:40 -0800", "is_openbsd": false, "thread_id": "DGPUWPJCFPZH.4NVAAQS1I6HR@garyguo.net.mbox.gz" }
lkml_critique
lkml
Hi, This is based on today's linux.git. A git branch with this (plus a fix for a CLIPPY warning on a core Rust for Linux issue which I suspect others have already found and fixed) is here: https://github.com/johnhubbard/linux/tree/nova-core-blackwell-v5 This is quite a large overhaul, multiple passes to fix up a...
null
null
null
[PATCH v5 00/38] gpu: nova-core: firmware: Hopper/Blackwell support
Add the MCTP (Management Component Transport Protocol) and NVDM (NVIDIA Device Management) wire-format types used for communication between the kernel driver and GPU firmware processors. This includes typed MCTP transport headers, NVDM message headers, and NVDM message type identifiers. Both the FSP boot path and the ...
{ "author": "John Hubbard <jhubbard@nvidia.com>", "date": "Fri, 20 Feb 2026 18:09:37 -0800", "is_openbsd": false, "thread_id": "DGPUWPJCFPZH.4NVAAQS1I6HR@garyguo.net.mbox.gz" }
lkml_critique
lkml
Hi, This is based on today's linux.git. A git branch with this (plus a fix for a CLIPPY warning on a core Rust for Linux issue which I suspect others have already found and fixed) is here: https://github.com/johnhubbard/linux/tree/nova-core-blackwell-v5 This is quite a large overhaul, multiple passes to fix up a...
null
null
null
[PATCH v5 00/38] gpu: nova-core: firmware: Hopper/Blackwell support
Drivers that operate on 64-bit address spaces (GPU framebuffer layouts, DMA regions, etc.) frequently need these size constants as a u64 type. Today this requires repeated usize-to-u64 conversion calls like usize_as_u64(SZ_1M) or u64::from_safe_cast(SZ_1M), which adds boilerplate without any safety benefit. Add u64-ty...
{ "author": "John Hubbard <jhubbard@nvidia.com>", "date": "Fri, 20 Feb 2026 18:09:51 -0800", "is_openbsd": false, "thread_id": "DGPUWPJCFPZH.4NVAAQS1I6HR@garyguo.net.mbox.gz" }
lkml_critique
lkml
Hi, This is based on today's linux.git. A git branch with this (plus a fix for a CLIPPY warning on a core Rust for Linux issue which I suspect others have already found and fixed) is here: https://github.com/johnhubbard/linux/tree/nova-core-blackwell-v5 This is quite a large overhaul, multiple passes to fix up a...
null
null
null
[PATCH v5 00/38] gpu: nova-core: firmware: Hopper/Blackwell support
Various "reserved" areas of FB (frame buffer: vidmem) have to be calculated, because the GSP booting process needs this information. PMU_RESERVED_SIZE is computed at compile time using const_align_up(). The total reserved size is computed at runtime using Alignable::align_up because it depends on the heap layout. Cc:...
{ "author": "John Hubbard <jhubbard@nvidia.com>", "date": "Fri, 20 Feb 2026 18:09:36 -0800", "is_openbsd": false, "thread_id": "DGPUWPJCFPZH.4NVAAQS1I6HR@garyguo.net.mbox.gz" }
lkml_critique
lkml
Hi, This is based on today's linux.git. A git branch with this (plus a fix for a CLIPPY warning on a core Rust for Linux issue which I suspect others have already found and fixed) is here: https://github.com/johnhubbard/linux/tree/nova-core-blackwell-v5 This is quite a large overhaul, multiple passes to fix up a...
null
null
null
[PATCH v5 00/38] gpu: nova-core: firmware: Hopper/Blackwell support
Add the NVDM COT payload, FSP message, and FSP response structures needed for FSP Chain of Trust communication. Also add FmcSignatures to hold the hash, public key, and signature extracted from FMC firmware. Signed-off-by: John Hubbard <jhubbard@nvidia.com> --- drivers/gpu/nova-core/firmware.rs | 5 +- drivers/gpu/n...
{ "author": "John Hubbard <jhubbard@nvidia.com>", "date": "Fri, 20 Feb 2026 18:09:39 -0800", "is_openbsd": false, "thread_id": "DGPUWPJCFPZH.4NVAAQS1I6HR@garyguo.net.mbox.gz" }
lkml_critique
lkml
Hi, This is based on today's linux.git. A git branch with this (plus a fix for a CLIPPY warning on a core Rust for Linux issue which I suspect others have already found and fixed) is here: https://github.com/johnhubbard/linux/tree/nova-core-blackwell-v5 This is quite a large overhaul, multiple passes to fix up a...
null
null
null
[PATCH v5 00/38] gpu: nova-core: firmware: Hopper/Blackwell support
Hopper and Blackwell GPUs use a different PCI config space mirror address (0x088000) compared to older architectures (0x088480). Update SetSystemInfo to accept a chipset parameter and select the correct address based on architecture. Signed-off-by: John Hubbard <jhubbard@nvidia.com> --- drivers/gpu/nova-core/gsp/boot...
{ "author": "John Hubbard <jhubbard@nvidia.com>", "date": "Fri, 20 Feb 2026 18:09:49 -0800", "is_openbsd": false, "thread_id": "DGPUWPJCFPZH.4NVAAQS1I6HR@garyguo.net.mbox.gz" }
lkml_critique
lkml
Hi, This is based on today's linux.git. A git branch with this (plus a fix for a CLIPPY warning on a core Rust for Linux issue which I suspect others have already found and fixed) is here: https://github.com/johnhubbard/linux/tree/nova-core-blackwell-v5 This is quite a large overhaul, multiple passes to fix up a...
null
null
null
[PATCH v5 00/38] gpu: nova-core: firmware: Hopper/Blackwell support
Add the FSP (Firmware System Processor) module for Hopper/Blackwell GPUs. These architectures use a simplified firmware boot sequence: FMC --> FSP --> GSP, with no SEC2 involvement. This commit adds the ability to wait for FSP secure boot completion by polling the I2CS thermal scratch register until FSP signals s...
{ "author": "John Hubbard <jhubbard@nvidia.com>", "date": "Fri, 20 Feb 2026 18:09:38 -0800", "is_openbsd": false, "thread_id": "DGPUWPJCFPZH.4NVAAQS1I6HR@garyguo.net.mbox.gz" }
lkml_critique
lkml
Hi, This is based on today's linux.git. A git branch with this (plus a fix for a CLIPPY warning on a core Rust for Linux issue which I suspect others have already found and fixed) is here: https://github.com/johnhubbard/linux/tree/nova-core-blackwell-v5 This is quite a large overhaul, multiple passes to fix up a...
null
null
null
[PATCH v5 00/38] gpu: nova-core: firmware: Hopper/Blackwell support
Add send_sync_fsp() which sends an MCTP/NVDM message to FSP and waits for the response. Response validation uses the typed MctpHeader and NvdmHeader wrappers from the previous commit. A MessageToFsp trait provides the NVDM type constant for each message struct, so send_sync_fsp() can verify that the response matches t...
{ "author": "John Hubbard <jhubbard@nvidia.com>", "date": "Fri, 20 Feb 2026 18:09:41 -0800", "is_openbsd": false, "thread_id": "DGPUWPJCFPZH.4NVAAQS1I6HR@garyguo.net.mbox.gz" }
lkml_critique
lkml
Hi, This is based on today's linux.git. A git branch with this (plus a fix for a CLIPPY warning on a core Rust for Linux issue which I suspect others have already found and fixed) is here: https://github.com/johnhubbard/linux/tree/nova-core-blackwell-v5 This is quite a large overhaul, multiple passes to fix up a...
null
null
null
[PATCH v5 00/38] gpu: nova-core: firmware: Hopper/Blackwell support
Replace manual usize_as_u64(SZ_*) and u64::from_safe_cast(SZ_*) conversions with the new SZ_*_U64 constants throughout fb.rs, gsp/fw.rs, and regs.rs. This removes the conversion boilerplate and the now-unused usize_as_u64 import in fb.rs. Signed-off-by: John Hubbard <jhubbard@nvidia.com> --- drivers/gpu/nova-core/fb....
{ "author": "John Hubbard <jhubbard@nvidia.com>", "date": "Fri, 20 Feb 2026 18:09:52 -0800", "is_openbsd": false, "thread_id": "DGPUWPJCFPZH.4NVAAQS1I6HR@garyguo.net.mbox.gz" }
lkml_critique
lkml
Hi, This is based on today's linux.git. A git branch with this (plus a fix for a CLIPPY warning on a core Rust for Linux issue which I suspect others have already found and fixed) is here: https://github.com/johnhubbard/linux/tree/nova-core-blackwell-v5 This is quite a large overhaul, multiple passes to fix up a...
null
null
null
[PATCH v5 00/38] gpu: nova-core: firmware: Hopper/Blackwell support
Add boot_fmc() which builds and sends the Chain of Trust message to FSP, and FmcBootArgs which bundles the DMA-coherent boot parameters that FSP reads at boot time. The FspFirmware struct fields become pub(crate) and fmc_full changes from DmaObject to KVec<u8> for CPU-side signature extraction. Co-developed-by: Alexan...
{ "author": "John Hubbard <jhubbard@nvidia.com>", "date": "Fri, 20 Feb 2026 18:09:44 -0800", "is_openbsd": false, "thread_id": "DGPUWPJCFPZH.4NVAAQS1I6HR@garyguo.net.mbox.gz" }
lkml_critique
lkml
Hi, This is based on today's linux.git. A git branch with this (plus a fix for a CLIPPY warning on a core Rust for Linux issue which I suspect others have already found and fixed) is here: https://github.com/johnhubbard/linux/tree/nova-core-blackwell-v5 This is quite a large overhaul, multiple passes to fix up a...
null
null
null
[PATCH v5 00/38] gpu: nova-core: firmware: Hopper/Blackwell support
Blackwell GPUs moved the sysmem flush page registers away from the legacy NV_PFB_NISO_FLUSH_SYSMEM_ADDR used by Ampere/Ada. GB10x uses HSHUB0 registers, with both a primary and EG (egress) pair that must be programmed to the same address. GB20x uses FBHUB0 registers. Add separate GB100 and GB202 fb HALs, and split th...
{ "author": "John Hubbard <jhubbard@nvidia.com>", "date": "Fri, 20 Feb 2026 18:09:45 -0800", "is_openbsd": false, "thread_id": "DGPUWPJCFPZH.4NVAAQS1I6HR@garyguo.net.mbox.gz" }
lkml_critique
lkml
Hi, This is based on today's linux.git. A git branch with this (plus a fix for a CLIPPY warning on a core Rust for Linux issue which I suspect others have already found and fixed) is here: https://github.com/johnhubbard/linux/tree/nova-core-blackwell-v5 This is quite a large overhaul, multiple passes to fix up a...
null
null
null
[PATCH v5 00/38] gpu: nova-core: firmware: Hopper/Blackwell support
Move the SEC2 reset/load/boot sequence into a BooterFirmware::run() method, and call it from a thin run_booter() helper on Gsp. This is almost a pure refactoring with no behavior change, done in preparation for adding an alternative FSP boot path. The one slight difference is that an MBOX1 printing typo is fixed: Prev...
{ "author": "John Hubbard <jhubbard@nvidia.com>", "date": "Fri, 20 Feb 2026 18:09:47 -0800", "is_openbsd": false, "thread_id": "DGPUWPJCFPZH.4NVAAQS1I6HR@garyguo.net.mbox.gz" }