repo
stringclasses
15 values
fix_commit
stringlengths
40
40
buggy_commit
stringlengths
40
40
message
stringlengths
3
64.3k
files
listlengths
1
300
timestamp
timestamp[s]date
2013-03-13 20:45:00
2026-04-11 07:48:46
golang/go
ddaf68200a485ae9605a397372b5d59f4dfba759
533cd80315904661e3d644a140bdf52c8ac7aad6
cmd/internal/objfile: read file/line information for ELF PIE binaries For PIE binaries, the .gopclntab section doesn't have the usual name, but .data.rel.ro.gopclntab. Try the relro version as well. If both failed (e.g. for externally linked PIE binaries), try runtime.pclntab symbol. This should make cmd/objdump able...
[ { "path": "src/cmd/internal/objfile/elf.go", "patch": "@@ -68,16 +68,35 @@ func (f *elfFile) pcln() (textStart uint64, symtab, pclntab []byte, err error) {\n \tif sect := f.elf.Section(\".text\"); sect != nil {\n \t\ttextStart = sect.Addr\n \t}\n-\tif sect := f.elf.Section(\".gosymtab\"); sect != nil {\n+\n...
2022-09-16T23:41:55
electron/electron
b3d60bfb3a74d1378728ec6a9801ff7d91815f1d
97fd383c5322e707d5a664c623c8f725f1a3be59
Fix building on Linux
[ { "path": "atom/browser/api/atom_api_app.cc", "patch": "@@ -453,8 +453,8 @@ int ImportIntoCertStore(\n \n if (!cert_path.empty()) {\n if (base::ReadFileToString(base::FilePath(cert_path), &file_data)) {\n- auto module = model->cert_db()->GetPublicModule();\n- rv = model->ImportFromPKCS12(mod...
2017-04-17T08:17:02
rust-lang/rust
8296ad04568597fbfab4460530032cd54f5cd26b
3672a55b7cfd0a12e7097197b6242872473ffaa7
Print regions in `type_name`. Currently they are skipped, which is a bit weird, and it sometimes causes malformed output like `Foo<>` and `dyn Bar<, A = u32>`. Most regions are erased by the time `type_name` does its work. So all regions are now printed as `'_` in non-optional places. Not perfect, but better than the...
[ { "path": "compiler/rustc_const_eval/src/util/type_name.rs", "patch": "@@ -5,7 +5,7 @@ use rustc_hir::def_id::CrateNum;\n use rustc_hir::definitions::DisambiguatedDefPathData;\n use rustc_middle::bug;\n use rustc_middle::ty::print::{PrettyPrinter, PrintError, Printer};\n-use rustc_middle::ty::{self, Generic...
2025-08-07T18:56:41
facebook/react
e938116549fad743afa02308c5a43ff2c305e06f
eebcf9f888b8a8fc3ed1f31c2789584a235aa089
Fix EnterLeaveEventPlugin-test in IE10 Previously this was failing because iframeDocument.body wasn't properly initialized. Creating the document this way seems to work in all environments Test Plan: Ran the test in jest, phantomjs, IE10, Chrome, and Firefox.
[ { "path": "src/browser/eventPlugins/__tests__/EnterLeaveEventPlugin-test.js", "patch": "@@ -46,9 +46,10 @@ describe('EnterLeaveEventPlugin', function() {\n \n var iframeDocument = iframe.contentDocument;\n \n- if (!iframeDocument.innerHTML) {\n- iframeDocument.innerHTML = '<html><head></head><bo...
2014-06-08T01:45:32
vercel/next.js
7458ffa042c2141bd18b119d93d064acaba42315
cdff6df0980b854b7c0ce06ada82bc58ab545d2a
Support adding CSP nonce with `content-security-policy-report-only` header (#59071) **Note**: this is a 1-to-1 copy of #48969 by @danieltott with all the merge conflicts fixed. ## Checklist * Fixes https://github.com/vercel/next.js/issues/48966 * Tests added to `test/production/app-dir/subresource-integrity/s...
[ { "path": "packages/next/src/server/app-render/app-render.tsx", "patch": "@@ -658,7 +658,9 @@ async function renderToHTMLOrFlightImpl(\n : null\n \n // Get the nonce from the incoming request if it has one.\n- const csp = req.headers['content-security-policy']\n+ const csp =\n+ req.headers['conte...
2023-12-01T03:40:57
electron/electron
7d9d82b522316d991ace6611872370c9407abc0b
08069e18db85e9c79736a0441c010d4d879d6b4d
Fix lack of some Chromium headers
[ { "path": "script/lib/config.py", "patch": "@@ -9,7 +9,7 @@\n BASE_URL = os.getenv('LIBCHROMIUMCONTENT_MIRROR') or \\\n 'https://s3.amazonaws.com/github-janky-artifacts/libchromiumcontent'\n LIBCHROMIUMCONTENT_COMMIT = os.getenv('LIBCHROMIUMCONTENT_COMMIT') or \\\n- '1433d43a013f6029aec7c1263e1576ad9...
2017-04-17T07:14:05
facebook/react
eebcf9f888b8a8fc3ed1f31c2789584a235aa089
41ed67d222ca98bc8a88537fe352cc979a1ae5ae
Fix ExecutionEnvironment.canUseDOM for IE8.
[ { "path": "src/vendor/core/ExecutionEnvironment.js", "patch": "@@ -20,10 +20,11 @@\n \n \"use strict\";\n \n-var canUseDOM =\n+var canUseDOM = !!(\n typeof window !== 'undefined' &&\n window.document &&\n- typeof window.document.createElement === 'function';\n+ window.document.createElement\n+);\n \n ...
2014-06-05T19:44:24
nodejs/node
2c0a4fab11f8aa866056a857a42b55a1882391b6
de35c030b5a1b86ad06bdd3e5cc4608fa67f4893
win: allow skipping the supported platform check Fixes: https://github.com/nodejs/node/issues/33034 PR-URL: https://github.com/nodejs/node/pull/33176 Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewe...
[ { "path": "doc/api/cli.md", "patch": "@@ -1366,6 +1366,15 @@ added:\n Path to a Node.js module which will be loaded in place of the built-in REPL.\n Overriding this value to an empty string (`''`) will use the built-in REPL.\n \n+### `NODE_SKIP_PLATFORM_CHECK=value`\n+<!-- YAML\n+added: REPLACEME\n+-->\n+\n...
2020-04-30T19:19:52
vercel/next.js
cdff6df0980b854b7c0ce06ada82bc58ab545d2a
a5e60f179b9589fc64f8c11d42940a7a5628d0e5
Add NEXT_MANUAL_SIG_HANDLE handling to start-server.ts (#59117) If a manual signal handler is registered, SIGINT and SIGTERM should not be handled by Next.js. This was already the case in the standalone server.js but was missing here, rendering the env flag useless. With this fix, the example given in https://ne...
[ { "path": "packages/next/src/server/lib/start-server.ts", "patch": "@@ -280,9 +280,11 @@ export async function startServer(\n console.error(err)\n }\n process.on('exit', (code) => cleanup(code))\n- // callback value is signal string, exit with 0\n- process.on('SIGINT'...
2023-12-01T03:05:20
golang/go
42a46206b97ca7cf4246d3c1230a70cf42ad5bb0
88a6a4d1ba75c01fcc7ab8b2b5c6108c36eb92b9
cmd/go: omit VCS stamping during bootstrap cmd/dist can't easily hard-code -buildvcs=false because not all versions of cmd/go supported for bootstrapping recognize that flag. However, we don't want to stamp the bootstrap binaries: the stamping is redundant with the VERSION file writted during bootstrapping (which is ...
[ { "path": "misc/reboot/reboot_test.go", "patch": "@@ -20,11 +20,27 @@ func TestRepeatBootstrap(t *testing.T) {\n \t\tt.Skipf(\"skipping test that rebuilds the entire toolchain\")\n \t}\n \n-\tgoroot := t.TempDir()\n+\trealGoroot, err := filepath.Abs(filepath.Join(\"..\", \"..\"))\n+\tif err != nil {\n+\t\tt...
2022-09-09T21:29:12
electron/electron
08069e18db85e9c79736a0441c010d4d879d6b4d
b2b2d8d9a4d55a5c3903e7e44a9a9c04affaa874
Don't use gzip when uploading crash reports
[ { "path": "atom/common/crash_reporter/crash_reporter_mac.mm", "patch": "@@ -43,11 +43,16 @@\n base::FilePath handler_path =\n framework_bundle_path.Append(\"Resources\").Append(\"crashpad_handler\");\n \n+ std::vector<std::string> args = {\n+ \"--no-rate-limit\",\n+ \"--no...
2017-04-17T07:03:57
vercel/next.js
a5e60f179b9589fc64f8c11d42940a7a5628d0e5
1c61153d779da0699d2542842a7d87f8d2cd4d65
fix typedRoutes when used with webpackBuildWorker (#59140) When using `experimental.typedRoutes` in conjunction with `experimental.webpackBuildWorker`, type errors would be erroneously thrown during build. This is because the build workers are parallelized between multiple runtimes (edge, server, client), but th...
[ { "path": "packages/next/src/build/webpack/plugins/next-types-plugin/index.ts", "patch": "@@ -15,6 +15,7 @@ import { isDynamicRoute } from '../../../../shared/lib/router/utils'\n import { normalizeAppPath } from '../../../../shared/lib/router/utils/app-paths'\n import { getPageFromPath } from '../../../entr...
2023-12-01T02:25:08
facebook/react
e501238c1010f68fe9b57ac7453ca9fd9d2598d7
87bcbff21896e6b362012a0bc82c35d42a6f955d
Fix getEventModifierState, no allocations Alternative to #1637 that doesn't allocate on every event. Test Plan: Crossed fingers.
[ { "path": "src/browser/ui/dom/getEventModifierState.js", "patch": "@@ -31,14 +31,22 @@ var modifierKeyToProp = {\n 'shift': 'shiftKey'\n };\n \n+// IE8 does not implement getModifierState so we simply map it to the only\n+// modifier keys exposed by the event itself, does not support Lock-keys.\n+// Curre...
2014-06-03T21:27:08
golang/go
441223050335590875581275cd538034111f28d8
e246cf626d1768ab56fa9eeafe4d23266e956ef6
net/http: add tracing to TestTransportReuseConnection_Gzip_* These tests are flaky; add some additional logging in hopes it will aid in debugging. For #53373 Change-Id: I971a2815f50932a9700ef8c2f684c5416951e6de Reviewed-on: https://go-review.googlesource.com/c/go/+/432375 Reviewed-by: Bryan Mills <bcmills@google.com...
[ { "path": "src/net/http/transport_test.go", "patch": "@@ -4429,8 +4429,19 @@ func testTransportReuseConnection_Gzip(t *testing.T, chunked bool) {\n \tdefer ts.Close()\n \tc := ts.Client()\n \n+\ttrace := &httptrace.ClientTrace{\n+\t\tGetConn: func(hostPort string) { t.Logf(\"GetConn(%q)\", hostPort) },...
2022-09-21T15:11:40
nodejs/node
69612b70da7cec270bc96ac3741076eb5d26b742
c095808e7363f1b6f6d2fbe3e3cd07173d319820
build: fix python-version selection with actions s/PYTHON\_VERSION/python-version Refs: https://github.com/actions/setup-python Refs: https://github.com/nodejs/node/pull/32609 PR-URL: https://github.com/nodejs/node/pull/33589 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benj...
[ { "path": ".github/workflows/linters.yml", "patch": "@@ -26,7 +26,7 @@ jobs:\n - name: Set up Python ${{ env.PYTHON_VERSION }}\n uses: actions/setup-python@v1\n with:\n- PYTHON_VERSION: ${{ env.PYTHON_VERSION }}\n+ python-version: ${{ env.PYTHON_VERSION }}\n - n...
2020-05-27T16:19:06
electron/electron
b2b2d8d9a4d55a5c3903e7e44a9a9c04affaa874
d85b58fdb59082abf336b1eed54afbcc3766b872
Fix crash on exit
[ { "path": "atom/browser/net/atom_url_request_job_factory.cc", "patch": "@@ -81,6 +81,7 @@ bool AtomURLRequestJobFactory::HasProtocolHandler(\n void AtomURLRequestJobFactory::Clear() {\n for (auto& it : protocol_handler_map_)\n delete it.second;\n+ protocol_handler_map_.clear();\n }\n \n net::URLReque...
2017-04-13T11:34:47
facebook/react
7172b1d5daff92b65dc6326f79286eab9d93548c
87bcbff21896e6b362012a0bc82c35d42a6f955d
Update 2014-03-21-react-v0.10.md Fix link to React v0.10 RC
[ { "path": "docs/_posts/2014-03-21-react-v0.10.md", "patch": "@@ -4,7 +4,7 @@ layout: post\n author: Paul O’Shannessy\n ---\n \n-Hot on the heels of the [release candidate earlier this week](/react/blog/2014/02/20/react-v0.10rc.html), we're ready to call v0.10 done. The only major issue we discovered had to ...
2014-06-03T16:05:49
vercel/next.js
511867ceec25441cec83e89ab93d83257658549c
3159fa197bf851df07c867c57029ae9c0b217729
fix variable name in release workflow (#59135) Follow up to https://github.com/vercel/next.js/pull/59134
[ { "path": ".github/workflows/trigger_release.yml", "patch": "@@ -59,7 +59,7 @@ jobs:\n \n - name: Check if new commits since last tag\n run: |\n- if [ \"$LATEST_TAG\" = \"$LATEST_COMMIT\" ]; then\n+ if [ \"$LATEST_TAG_COMMIT\" = \"$LATEST_COMMIT\" ]; then\n echo \...
2023-11-30T23:19:46
nodejs/node
05db68245ba63bc908d09c1cc64098ce97fa9d1f
4a20cc937f6a2b830a2752e35da7e389bbc4e006
tools: fix check-imports.py to match on word boundaries `check-imports.py` was missing some unused `using` statements as it was not matching on word boundaries (e.g. `MaybeLocal` was considered a use of `Local`). Fix that and add some unit tests (which required the script to be renamed to drop the `-` so it could be i...
[ { "path": "Makefile", "patch": "@@ -1328,13 +1328,13 @@ else\n CPPLINT_QUIET = --quiet\n endif\n .PHONY: lint-cpp\n-# Lints the C++ code with cpplint.py and check-imports.py.\n+# Lints the C++ code with cpplint.py and checkimports.py.\n lint-cpp: tools/.cpplintstamp\n \n tools/.cpplintstamp: $(LINT_CPP_FILE...
2020-05-06T15:20:14
golang/go
e246cf626d1768ab56fa9eeafe4d23266e956ef6
493ebc359029a066d039adf861ea33bec68422b8
net/http: accept HEAD requests with a body RFC 7231 permits HEAD requests to contain a body, although it does state there are no defined semantics for payloads of HEAD requests and that some servers may reject HEAD requests with a payload. Accept HEAD requests with a body. Fix a bug where a HEAD request with a chunk...
[ { "path": "src/net/http/readrequest_test.go", "patch": "@@ -450,9 +450,12 @@ Content-Length: 3\n Content-Length: 4\n \n abc`)},\n-\t{\"smuggle_content_len_head\", reqBytes(`HEAD / HTTP/1.1\n+\t{\"smuggle_two_content_len_head\", reqBytes(`HEAD / HTTP/1.1\n Host: foo\n-Content-Length: 5`)},\n+Content-Length: ...
2022-07-20T20:38:56
electron/electron
d85b58fdb59082abf336b1eed54afbcc3766b872
6da696b6f28d771a5dbe04ebef24b258f8a0c8d9
Fix API changes of FrameSubscriber
[ { "path": "atom/browser/api/atom_api_web_contents.cc", "patch": "@@ -76,6 +76,7 @@\n #include \"third_party/WebKit/public/platform/WebInputEvent.h\"\n #include \"third_party/WebKit/public/web/WebFindOptions.h\"\n #include \"ui/display/screen.h\"\n+#include \"ui/events/base_event_utils.h\"\n \n #if !defined(...
2017-04-13T10:21:30
vercel/next.js
c5834ab48db1f351b35422f5cc3664d21c7824c2
d5bc1f7f90f2cb2ad31d5c3ddaeaddf52ff466d1
Fix: remove deprecated option from standalone server (#59036) Remove deprecated option passed to nextjs server when running in standalone mode. Co-authored-by: JJ Kasper <jj@jjsweb.site>
[ { "path": "packages/next/src/build/utils.ts", "patch": "@@ -2029,7 +2029,6 @@ startServer({\n port: currentPort,\n allowRetry: false,\n keepAliveTimeout,\n- useWorkers: true,\n }).catch((err) => {\n console.error(err);\n process.exit(1);", "additions": 0, "deletions": 1, "language": "...
2023-11-30T22:52:44
golang/go
493ebc359029a066d039adf861ea33bec68422b8
68370187fafe9c355e489d6976c35cd908f37a00
all: update vendored golang.org/x/net Pull in HTTP/2 fix needed for net/http test case. f8f703f979 http2: accept HEAD requests with a body For #53960 Change-Id: I59bbd83977daced5ed21ec5345af8cdb607e532e Reviewed-on: https://go-review.googlesource.com/c/go/+/432197 Run-TryBot: Damien Neil <dneil@google.com> TryBot-...
[ { "path": "src/go.mod", "patch": "@@ -4,7 +4,7 @@ go 1.20\n \n require (\n \tgolang.org/x/crypto v0.0.0-20220722155217-630584e8d5aa\n-\tgolang.org/x/net v0.0.0-20220906165146-f3363e06e74c\n+\tgolang.org/x/net v0.0.0-20220920203100-d0c6ba3f52d9\n )\n \n require (", "additions": 1, "deletions": 1, ...
2022-09-20T23:15:49
electron/electron
326908cebb16bdca9de6022929db621457d139ce
9f94a0b2463f049d456336dfff29556cf0c7b8d9
Fix change of FileDescriptorWatcher API
[ { "path": "chromium_src/net/test/embedded_test_server/stream_listen_socket.cc", "patch": "@@ -57,6 +57,9 @@ const int StreamListenSocket::kSocketError = -1;\n StreamListenSocket::StreamListenSocket(SocketDescriptor s,\n StreamListenSocket::Delegate* del)\n : socket...
2017-04-13T09:11:25
facebook/react
3e34739cb9148c76f0a338ab694f8963d84b1c56
6ce193614c330010a16a7f58abc2807c49bb3d09
Fix onLoad and onError on images Fixes bug introduced in c62c2c5. Test Plan: Tested that the onLoad event was properly triggered on an image. Didn't test onError but I can only assume that it works equally well.
[ { "path": "src/browser/ui/dom/components/ReactDOMImg.js", "patch": "@@ -44,8 +44,8 @@ var ReactDOMImg = ReactCompositeComponent.createClass({\n },\n \n componentDidMount: function() {\n- this.trapBubbledEvent(EventConstants.topLevelTypes.topReset, 'load');\n- this.trapBubbledEvent(EventConstants.t...
2014-05-30T23:53:46
nodejs/node
dcc112b7f7e7543e57b279d95a5bbb24ef771652
5007611294bfcfe7af8648a69bd19d1b014c84bd
2020-05-26, Version 12.17.0 'Erbium' (LTS) Notable changes: * ECMAScript Modules - `--experimental-modules` flag removal * AsyncLocalStorage API (experimental) * REPL previews * REPL reverse-i-search * REPL substring-based search * Error monitoring * Monitoring `error` events * Monitoring uncaught exceptions * Fi...
[ { "path": "CHANGELOG.md", "patch": "@@ -56,7 +56,8 @@ release.\n <a href=\"doc/changelogs/CHANGELOG_V13.md#13.0.0\">13.0.0</a><br/>\n </td>\n <td valign=\"top\">\n-<b><a href=\"doc/changelogs/CHANGELOG_V12.md#12.16.3\">12.16.3</a></b><br/>\n+<b><a href=\"doc/changelogs/CHANGELOG_V12.md#12.17.0\">12....
2020-05-01T12:43:14
vercel/next.js
d5bc1f7f90f2cb2ad31d5c3ddaeaddf52ff466d1
156f7860e2fa69e7f20aaf45c7cc1d542c5a50b6
Fix dynamic usage errors logging unexpectedly (#59133) This ensures we don't spam build logs with dynamic usage errors or similar unexpectedly as they can be caught by this worker process listener but shouldn't be logged. Closes NEXT-1763
[ { "path": "packages/next/src/export/worker.ts", "patch": "@@ -34,6 +34,7 @@ import { getParams } from './helpers/get-params'\n import { createIncrementalCache } from './helpers/create-incremental-cache'\n import { isPostpone } from '../server/lib/router-utils/is-postpone'\n import { isMissingPostponeDataErr...
2023-11-30T22:41:55
electron/electron
481b04358e6f45cb4297ab965a6d7d1013827fae
8634f37dfce9a565a5063ae31d4e22361d366d46
Fix blink API changes
[ { "path": "atom/browser/api/atom_api_web_contents.cc", "patch": "@@ -950,7 +950,7 @@ void WebContents::NavigationEntryCommitted(\n \n int64_t WebContents::GetID() const {\n int64_t process_id = web_contents()->GetRenderProcessHost()->GetID();\n- int64_t routing_id = web_contents()->GetRoutingID();\n+ in...
2017-04-11T07:18:40
golang/go
68370187fafe9c355e489d6976c35cd908f37a00
334984a92a33cd11a12071c03374916162188e2f
math: show value of integer constants in comments Fixes #51282 Change-Id: I5b0d68165b727a427bd4a42663b2fa0070ced22f Reviewed-on: https://go-review.googlesource.com/c/go/+/343990 Run-TryBot: Robert Griesemer <gri@google.com> Auto-Submit: Robert Griesemer <gri@google.com> Reviewed-by: Cherry Mui <cherryyz@google.com> R...
[ { "path": "src/math/const.go", "patch": "@@ -39,19 +39,19 @@ const (\n const (\n \tintSize = 32 << (^uint(0) >> 63) // 32 or 64\n \n-\tMaxInt = 1<<(intSize-1) - 1\n-\tMinInt = -1 << (intSize - 1)\n-\tMaxInt8 = 1<<7 - 1\n-\tMinInt8 = -1 << 7\n-\tMaxInt16 = 1<<15 - 1\n-\tMinInt16 = -1 << 15\n-\tMa...
2021-08-21T09:50:25
facebook/react
0c312222e9ba61cb04b931de05374d9ba6092504
8d8dd4d336a4a6964f03f5a9dc753f1846430a28
Update todo example. fixes 'Create' that shouldn't happen Currently, an `onBlur` creates a new todo on `TodoTextInput`. This makes sense for existing items but not for new items. I.e consider the following: 1. cursor on new item ("What needs to be done?") 2. click 'x' on the first item. This results in two ac...
[ { "path": "examples/todomvc-flux/js/components/Header.react.js", "patch": "@@ -45,7 +45,10 @@ var Header = React.createClass({\n * @param {string} text\n */\n _onSave: function(text) {\n- TodoActions.create(text);\n+ if(text.trim()){\n+ TodoActions.create(text);\n+ }\n+ \n }\n \n ...
2014-05-29T12:45:42
nodejs/node
b21556d28b7be3921fa99089c61a7938811e25d1
5e4c025567c688f3e7bd1d253619edafafbb7fcf
build: fix inability to detect correct python command in configure The "which" utility is not guaranteed to be installed, and if it is, its behavior is not portable. Conversely, the "command -v" shell builtin is required to exist in all POSIX 2008 compliant shells, and is thus guaranteed to work everywhere. Examples...
[ { "path": "configure", "patch": "@@ -5,11 +5,11 @@\n # as is the fact that the ] goes on a new line.\n _=[ 'exec' '/bin/sh' '-c' '''\n test ${FORCE_PYTHON2} && exec python2 \"$0\" \"$@\" # workaround for gclient\n-which python3.8 >/dev/null && exec python3.8 \"$0\" \"$@\"\n-which python3.7 >/dev/null && ex...
2020-04-19T07:23:58
vercel/next.js
0320f0935c40fa6f62be66b638fb130af0177901
fa6b120303fa9f0807d79a75ca8952a1d2607bb2
fix(turbo-tasks-fs): support unicode segment for glob (vercel/turbo#6646)
[ { "path": "crates/turbo-tasks-fs/Cargo.toml", "patch": "@@ -46,6 +46,7 @@ tokio = { workspace = true }\n tracing = { workspace = true }\n turbo-tasks = { workspace = true }\n turbo-tasks-hash = { workspace = true }\n+unicode-segmentation = { workspace = true }\n \n [dev-dependencies]\n criterion = { workspa...
2023-11-30T20:14:45
electron/electron
803120dae6690fe31b9a56e24d8a28b15b50c221
6be10ffef290d13c195f0e3f65ab869fbe6eb74e
Update libcc to fix missing gen/cc headers
[ { "path": "script/lib/config.py", "patch": "@@ -9,7 +9,7 @@\n BASE_URL = os.getenv('LIBCHROMIUMCONTENT_MIRROR') or \\\n 'https://s3.amazonaws.com/github-janky-artifacts/libchromiumcontent'\n LIBCHROMIUMCONTENT_COMMIT = os.getenv('LIBCHROMIUMCONTENT_COMMIT') or \\\n- '8c3e532385811b5cea80e969c1beb1bf3...
2017-04-05T09:03:07
golang/go
c70fd4b30aba5db2df7b5f6b0833c62b909f50eb
9c916c79011f3af98b5670eb2ba55349ba904522
bytes, strings: add ASCII fast path to EqualFold This commit adds an ASCII fast path to bytes/strings EqualFold that roughly doubles performance when all characters are ASCII. It also changes strings.EqualFold to use `for range` for the first string since this is ~10% faster than using utf8.DecodeRuneInString for bot...
[ { "path": "src/bytes/bytes.go", "patch": "@@ -1134,6 +1134,36 @@ func ReplaceAll(s, old, new []byte) []byte {\n // are equal under simple Unicode case-folding, which is a more general\n // form of case-insensitivity.\n func EqualFold(s, t []byte) bool {\n+\t// ASCII fast path\n+\ti := 0\n+\tfor ; i < len(s)...
2022-08-24T18:23:28
facebook/react
3297909545d58207256ee9eb91e3f64ccb0271a9
50516585a4ab039e67d351011db11970d95ee50c
[docs] Fix grammar
[ { "path": "docs/docs/03-interactivity-and-dynamic-uis.md", "patch": "@@ -43,7 +43,7 @@ React.renderComponent(\n \n With React you simply pass your event handler as a camelCased prop similar to how you'd do it in normal HTML. React ensures that all events behave identically in IE8 and above by implementing a...
2014-05-29T06:30:45
nodejs/node
5e4c025567c688f3e7bd1d253619edafafbb7fcf
e30a65193792d76e204e4558a404b7e9d5a12f41
build: fix makefile script on windows On Windows there is a program "find.exe" located in C:\Windows\System32, which is usually in the PATH before MSYS version of that program (required for running makefile). The Windows version of the program uses different CLI syntax, which results in errors like "File not found ...
[ { "path": "Makefile", "patch": "@@ -17,6 +17,7 @@ GNUMAKEFLAGS += --no-print-directory\n GCOV ?= gcov\n PWD = $(CURDIR)\n BUILD_WITH ?= make\n+FIND ?= find\n \n ifdef JOBS\n \tPARALLEL_ARGS = -j $(JOBS)\n@@ -168,7 +169,7 @@ uninstall: ## Uninstalls node from $PREFIX (default=/usr/local).\n clean: ## Remove ...
2020-04-28T19:34:22
vercel/next.js
156f7860e2fa69e7f20aaf45c7cc1d542c5a50b6
778fb871314e840390496f4147483ba18d974d83
Turbopack: Align some "Module not found" errors with webpack (#58518) This: - Sends an hmr sync event so that errors that occur after the initial hmr connection are sent to the client - Aligns on `path/to/file.js:line:column` format across error overlay implementations in the cli and on the web - Adapts "Module not fo...
[ { "path": "packages/next/src/client/components/react-dev-overlay/internal/components/Terminal/EditorLink.tsx", "patch": "@@ -31,7 +31,7 @@ export function EditorLink({ file, isSourceFile, location }: EditorLinkProps) {\n title={'Click to open in your editor'}\n >\n {file}\n- {location ?...
2023-11-30T16:34:56
facebook/react
50516585a4ab039e67d351011db11970d95ee50c
6c7abd36ddebbe7b70057d4500f4d55176e7c0f9
Update findComponentRoot and processUpdates warnings for SVG I ran into a really difficult-to-debug issue with a React app with SVG elements. Christopher sat down with me for a while and we finally figured out that the browser was moving non-SVG elements out of a parent `<svg>` node which triggered the `processUpdates...
[ { "path": "src/browser/ui/ReactMount.js", "patch": "@@ -642,9 +642,9 @@ var ReactMount = {\n false,\n 'findComponentRoot(..., %s): Unable to find element. This probably ' +\n 'means the DOM was unexpectedly mutated (e.g., by the browser), ' +\n- 'usually due to forgetting a <tbody> wh...
2014-05-29T00:33:56
electron/electron
6be10ffef290d13c195f0e3f65ab869fbe6eb74e
50e3bfa764ca3116069cff45ab218e8e38b9e3eb
Fix more API changes due to name changes
[ { "path": "atom/browser/native_window_mac.mm", "patch": "@@ -1458,7 +1458,7 @@ static bool FromV8(v8::Isolate* isolate, v8::Handle<v8::Value> val,\n }\n \n void NativeWindowMac::OnInputEvent(const blink::WebInputEvent& event) {\n- switch (event.type) {\n+ switch (event.type()) {\n case blink::WebInput...
2017-04-05T09:02:06
golang/go
bcd44b61d3154b22ffce10302ea9c34ba639a98e
0bfa9f0435e03176b04ad202320be441d03ee25f
time: optimize Parse for []byte arguments When one has a []byte on hand, but desires to call the Parse function, the conversion from []byte to string would allocate. This occurs frequently through UnmarshalText and UnmarshalJSON. This changes it such that the input string never escapes from any of the Parse functions...
[ { "path": "src/time/format.go", "patch": "@@ -808,6 +808,20 @@ type ParseError struct {\n \tMessage string\n }\n \n+// newParseError creates a new ParseError.\n+// The provided value and valueElem are cloned to avoid escaping their values.\n+func newParseError(layout, value, layoutElem, valueElem, messag...
2022-09-08T21:57:44
nodejs/node
e24731cb70386899a746da59fcc2bb68df3545ff
2f00ca42bff04773bd787ec70ba83027f22442eb
util: fix inspection of class instance prototypes To achieve this, some internal custom inspect functions had to be changed. They relied upon the former behavior. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: https://github.com/nodejs/node/pull/33449 Fixes: https://github.com/nodejs/node/issues/334...
[ { "path": "lib/internal/encoding.js", "patch": "@@ -514,54 +514,53 @@ function makeTextDecoderJS() {\n }\n \n // Mix in some shared properties.\n-{\n- ObjectDefineProperties(\n- TextDecoder.prototype,\n- ObjectGetOwnPropertyDescriptors({\n- get encoding() {\n- validateDecoder(this);\n- ...
2020-05-17T17:07:04
facebook/react
2e3cf459ba225e7a0bd8489bb57bce7b6aea7d53
0ad8cfad1a3fd154d60274e4cb37c10ff1276a70
Fix tutorial to have exact translation of example Fixes #903.
[ { "path": "docs/docs/tutorial.md", "patch": "@@ -88,18 +88,17 @@ The first thing you'll notice is the XML-ish syntax in your JavaScript. We have\n \n ```javascript\n // tutorial1-raw.js\n-var CommentBox = React.createClass({\n+var CommentBox = React.createClass({displayName: 'CommentBox',\n render: functi...
2014-05-28T17:28:38
vercel/next.js
d37b5076297e39e11b81e9154ccb8fef3dafa56c
956636c86f508bb79cfc10c6a9bc40039de6366c
Fix next internal is missing in flight manifest (#59085)
[ { "path": "packages/next/src/build/webpack/loaders/next-app-loader.ts", "patch": "@@ -56,6 +56,8 @@ const PAGE_SEGMENT = 'page$'\n const PARALLEL_CHILDREN_SEGMENT = 'children$'\n \n const defaultNotFoundPath = 'next/dist/client/components/not-found-error'\n+const defaultGlobalErrorPath = 'next/dist/client/c...
2023-11-30T15:36:14
golang/go
0bfa9f0435e03176b04ad202320be441d03ee25f
1e96f42c2a80ca99c202409683ba5bd755bf3d85
spec: fix typo in a type parameter example Fixes #54973 Change-Id: Ibad9dd124617a1bbc23abd17cbd6e9e9928e3ed9 GitHub-Last-Rev: 1c6affb967ef925ec12420e31c6423a615f90acc GitHub-Pull-Request: golang/go#55021 Reviewed-on: https://go-review.googlesource.com/c/go/+/430316 Reviewed-by: Cherry Mui <cherryyz@google.com> Run-Tr...
[ { "path": "doc/go_spec.html", "patch": "@@ -4265,7 +4265,7 @@ <h3 id=\"Instantiations\">Instantiations</h3>\n </p>\n \n <pre>\n-func apply[S ~[]E, E any](s S, f(E) E) S { … }\n+func apply[S ~[]E, E any](s S, f func(E) E) S { … }\n \n f0 := apply[] // illegal: type argument list cannot be em...
2022-09-14T04:25:55
electron/electron
50e3bfa764ca3116069cff45ab218e8e38b9e3eb
9d1b88ed593f6568de523b0bca1126f7b4d8a1e9
Fix API changes of base::Value
[ { "path": "atom/browser/api/atom_api_web_contents.cc", "patch": "@@ -877,7 +877,7 @@ void WebContents::DevToolsOpened() {\n devtools_web_contents_.Reset(isolate(), handle.ToV8());\n \n // Set inspected tabID.\n- base::FundamentalValue tab_id(ID());\n+ base::Value tab_id(ID());\n managed_web_contents...
2017-04-05T08:34:53
nodejs/node
2f00ca42bff04773bd787ec70ba83027f22442eb
5632ff66cdfd770083a4a5223ca4348d05b1eb39
crypto: fix wrong error message When calling `crypto.sign()`, if the `key` parameter object is missing the `key` property, the error message is wrong. Before the fix: TypeError [ERR_INVALID_ARG_TYPE]: The "key" argument must be of type string or an instance of Buffer, TypedArray, DataView, or KeyObject. Received an i...
[ { "path": "lib/internal/crypto/keys.js", "patch": "@@ -268,10 +268,10 @@ function prepareAsymmetricKey(key, ctx) {\n // Either PEM or DER using PKCS#1 or SPKI.\n if (!isStringOrBuffer(data)) {\n throw new ERR_INVALID_ARG_TYPE(\n- 'key',\n+ 'key.key',\n ['string', 'Buffer'...
2020-05-20T12:13:29
rust-lang/rust
d682943396fdc0a8fcf907c570435d01a3035fe2
51eb5ed8f099cb8169ca48eb684ea98030988849
resolve: Do not show deprecated helper attributes in typo recommendations Remove one FIXME, addressing it does not reduce the hacky-ness much, and the logic is going to be removed anyway together with the `legacy_derive_helpers` deprecation lint.
[ { "path": "compiler/rustc_resolve/src/diagnostics.rs", "patch": "@@ -1041,28 +1041,7 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {\n }\n }\n Scope::DeriveHelpersCompat => {\n- let res = Res::NonMacroAttr(NonMacroAttrKind::DeriveHelperCompat);...
2025-08-08T18:26:50
vercel/next.js
d605ef610136b9bb62583b0d0f02c56f515188d8
d509c2d52894e23e89eaec136847a0a60cd26519
fix interception routes with rewrites (#59094) ### What? When using interception routes & rewrites, on first interception the router will properly handle the request. But when using the back button and attempting another interception, it won't work ### Why? Intercepting routes rely on the accuracy of `nextUrl` ...
[ { "path": "packages/next/src/client/components/router-reducer/reducers/restore-reducer.ts", "patch": "@@ -4,6 +4,7 @@ import type {\n ReducerState,\n RestoreAction,\n } from '../router-reducer-types'\n+import { extractPathFromFlightRouterState } from '../compute-changed-path'\n \n export function restor...
2023-11-30T07:57:42
golang/go
1e7e160d070443147ee38d4de530ce904637a4f3
4c414c7673af6b2aedee276d2e62cb2910eb19f3
mime/multipart: use %w when wrapping error in NextPart Use "%w" instead of "%v" as format verb for error value in the NextPart method. This way it will be possible to use common go error utilities from std library when parsing from custom io.Readers. This issue was discovered during attempts to use http.Request.Parse...
[ { "path": "src/mime/multipart/multipart.go", "patch": "@@ -360,7 +360,7 @@ func (r *Reader) nextPart(rawPart bool) (*Part, error) {\n \t\t\treturn nil, io.EOF\n \t\t}\n \t\tif err != nil {\n-\t\t\treturn nil, fmt.Errorf(\"multipart: NextPart: %v\", err)\n+\t\t\treturn nil, fmt.Errorf(\"multipart: NextPart: ...
2022-09-19T21:35:04
electron/electron
9d1b88ed593f6568de523b0bca1126f7b4d8a1e9
fc2d62d5cb77605d53de2dccaf29dc01b57fbaef
Fix API changes in OSR code
[ { "path": "atom/browser/api/frame_subscriber.cc", "patch": "@@ -32,8 +32,7 @@ bool FrameSubscriber::ShouldCaptureFrame(\n base::TimeTicks present_time,\n scoped_refptr<media::VideoFrame>* storage,\n DeliverFrameCallback* callback) {\n- const auto host = view_ ? view_->GetRenderWidgetHost() : nu...
2017-04-05T08:31:22
nodejs/node
c072124814ca45e2f51afe0d5e202b0df6db9b4b
458677f5ef2bd35da920246bb266502ea76bb66c
src: use MaybeLocal::FromMaybe to return exception This commit suggests using MaybeLocal::FromMaybe to return the exception string, passing in a default value (an empty Local<Value>) which will be used if the exception object is empty. PR-URL: https://github.com/nodejs/node/pull/33514 Reviewed-By: Anna Henningsen <an...
[ { "path": "src/api/environment.cc", "patch": "@@ -51,17 +51,11 @@ static MaybeLocal<Value> PrepareStackTraceCallback(Local<Context> context,\n Local<Array> trace) {\n Environment* env = Environment::GetCurrent(context);\n if (env == nullptr) {\n- MaybeLocal<Strin...
2020-05-22T12:25:36
rust-lang/rust
51eb5ed8f099cb8169ca48eb684ea98030988849
8e7795415acaa9471b5eeb2301915d6996d289ec
resolve: Do not call `resolve_macro_path` from late resolution `maybe_resolve_path` is less precise in corner cases, but it's only used for diagnostics and error recovery, so it's good enough.
[ { "path": "compiler/rustc_resolve/src/diagnostics.rs", "patch": "@@ -1047,7 +1047,7 @@ impl<'ra, 'tcx> Resolver<'ra, 'tcx> {\n let parent_scope = &ParentScope { derives: &[], ..*parent_scope };\n let Ok((Some(ext), _)) = this.reborrow().resolve_macro_p...
2025-08-08T16:54:27
vercel/next.js
fa6b120303fa9f0807d79a75ca8952a1d2607bb2
9ce1896285d7913e78bea8e6bf1d0f99b6ac5fa8
Revert "fix(turbo-tasks-fs): support unicode segment for glob" (vercel/turbo#6644)
[ { "path": "crates/turbo-tasks-fs/Cargo.toml", "patch": "@@ -46,7 +46,6 @@ tokio = { workspace = true }\n tracing = { workspace = true }\n turbo-tasks = { workspace = true }\n turbo-tasks-hash = { workspace = true }\n-unicode-segmentation = { workspace = true }\n \n [dev-dependencies]\n criterion = { workspa...
2023-11-29T20:30:31
golang/go
f1b7b2fc52947711b8e78f7078c9e0bda35320d3
2d741947d8931325576427b3699d1af20e7be7cf
runtime: make mSpanStateBox accessors nosplit get, at least, is called from typedmemclr which must not be interruptible. These were previously nosplit by accident before CL 424395 (the only call they had was an intrinsic, so they were leaf functions, so they had no prologue). After CL 424395 they contained a call (in ...
[ { "path": "src/runtime/mbarrier.go", "patch": "@@ -311,6 +311,8 @@ func reflect_typedslicecopy(elemType *_type, dst, src slice) int {\n // If the caller knows that typ has pointers, it can alternatively\n // call memclrHasPointers.\n //\n+// TODO: A \"go:nosplitrec\" annotation would be perfect for this.\n+...
2022-09-19T21:26:05
facebook/react
e096000bb5449dc3a2749ea8f7f10b2fc0d28080
c913c95908fbc3eb5ee61e2832f57cb5d4d03d99
Attach empty onclick listener to each node Fixes #1169. This is a more robust way of fixing what MobileSafariClickPlugin previously tried to. Now even if you don't want anything to do with touch events, click events still work properly. Test Plan: Added a click handler to an `<img />` element and triggered it in the...
[ { "path": "src/browser/eventPlugins/DefaultEventPluginOrder.js", "patch": "@@ -38,8 +38,7 @@ var DefaultEventPluginOrder = [\n keyOf({SelectEventPlugin: null}),\n keyOf({CompositionEventPlugin: null}),\n keyOf({BeforeInputEventPlugin: null}),\n- keyOf({AnalyticsEventPlugin: null}),\n- keyOf({MobileS...
2014-05-15T18:12:04
electron/electron
fc2d62d5cb77605d53de2dccaf29dc01b57fbaef
453cb2c0b40e63196d4eeb4c8ca119c985ee23b7
Fix API changes of Chrome58
[ { "path": "atom/app/atom_content_client.cc", "patch": "@@ -93,9 +93,9 @@ content::PepperPluginInfo CreateWidevineCdmInfo(const base::FilePath& path,\n std::vector<std::string> codecs;\n codecs.push_back(kCdmSupportedCodecVp8);\n codecs.push_back(kCdmSupportedCodecVp9);\n-#if defined(USE_PROPRIETARY_CO...
2017-04-04T04:50:44
nodejs/node
458677f5ef2bd35da920246bb266502ea76bb66c
8f10bb2da5bcf166fa1b414055f03352bbdb8126
errors: print original exception context When --enable-source-maps is set, the error context displayed above the stack trace now shows original source rather than transpiled. PR-URL: https://github.com/nodejs/node/pull/33491 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridge...
[ { "path": "lib/internal/bootstrap/pre_execution.js", "patch": "@@ -26,14 +26,6 @@ function prepareMainThreadExecution(expandArgv1 = false) {\n setupCoverageHooks(process.env.NODE_V8_COVERAGE);\n }\n \n- // If source-map support has been enabled, we substitute in a new\n- // prepareStackTrace metho...
2020-05-24T23:00:46
vercel/next.js
9ce1896285d7913e78bea8e6bf1d0f99b6ac5fa8
f1d9f8ac3f83468d2ba5633b9c89f380184bef2b
fix(turbo-tasks-fs): support unicode segment for glob (vercel/turbo#6631)
[ { "path": "crates/turbo-tasks-fs/Cargo.toml", "patch": "@@ -46,6 +46,7 @@ tokio = { workspace = true }\n tracing = { workspace = true }\n turbo-tasks = { workspace = true }\n turbo-tasks-hash = { workspace = true }\n+unicode-segmentation = { workspace = true }\n \n [dev-dependencies]\n criterion = { workspa...
2023-11-29T19:59:29
golang/go
2d741947d8931325576427b3699d1af20e7be7cf
d31f85009cb81604c23e3e471fc4f7d62b9089ff
flag: test IsBoolFlag when creating the usage message Although I can't think of any reason to do this, it is possible for a user-defined flag to implement IsBoolFlag but return "false". This is nuts because checking the interface is satisfied should obviously be sufficient, but the documentation kinda implies it's not...
[ { "path": "src/flag/flag.go", "patch": "@@ -550,9 +550,11 @@ func UnquoteUsage(flag *Flag) (name string, usage string) {\n \t}\n \t// No explicit name, so use type if we can find one.\n \tname = \"value\"\n-\tswitch flag.Value.(type) {\n+\tswitch fv := flag.Value.(type) {\n \tcase boolFlag:\n-\t\tname = \"\...
2022-09-18T12:05:00
rust-lang/rust
05c2d72abca8b1cc2b4310c67b7022ca6038bb92
306d4e39def563fe6be2fc4369af8af45ab5c4b8
fix: `match_ref_pats` FP on match scrutinee of never type
[ { "path": "clippy_lints/src/matches/match_ref_pats.rs", "patch": "@@ -17,6 +17,11 @@ where\n return;\n }\n \n+ // `!` cannot be deref-ed\n+ if cx.typeck_results().expr_ty(scrutinee).is_never() {\n+ return;\n+ }\n+\n let (first_sugg, msg, title);\n let ctxt = expr.span.ctx...
2025-08-13T13:59:49
nodejs/node
dd5f209213a2b75bb386b44c296a059fc10dfb02
6443ab9595de9e7f57144f063e42efb73e34d714
inspector: throw error when activating an already active inspector When the user tries to activate the inspector that is already active on a different port and host, we previously just silently reset the port and host stored in the Environment without actually doing anything for that to be effective. After this patch,...
[ { "path": "doc/api/errors.md", "patch": "@@ -1229,6 +1229,13 @@ time.\n The `--input-type` flag was used to attempt to execute a file. This flag can\n only be used with input via `--eval`, `--print` or `STDIN`.\n \n+<a id=\"ERR_INSPECTOR_ALREADY_ACTIVATED\"></a>\n+### `ERR_INSPECTOR_ALREADY_ACTIVATED`\n+\n+...
2020-04-23T04:58:24
facebook/react
f761f770e12a62f2c37c1f715e66f5c386de19d7
db4a90a9ef352abfd21edcb53d9178903082f021
Don't load todomvc-common/base.js Fixes #1603. It's unnecessary and makes a request to learn.json which doesn't exist.
[ { "path": "examples/todomvc-flux/index.html", "patch": "@@ -13,7 +13,6 @@\n \t\t\t<p>Created by <a href=\"http://facebook.com/bill.fisher.771\">Bill Fisher</a></p>\n \t\t\t<p>Part of <a href=\"http://todomvc.com\">TodoMVC</a></p>\n \t\t</footer>\n-\t\t<script src=\"todomvc-common/base.js\"></script>\n \t\t<...
2014-05-27T03:19:16
vercel/next.js
8395059d3326d9dca089e6f0309fdb016ca7ace2
77f8889b7ca6072f386d382d7ce65b57a5065ce2
verify action id before parsing body (#58977) ### What? When handling a server action, in the non-progressive enhanced case, React will attempt to parse the request body before verifying if a valid server action is received. This results in an "Error: Connection Closed" error being thrown, rather than ignoring the...
[ { "path": "packages/next/src/server/app-render/action-handler.ts", "patch": "@@ -238,6 +238,16 @@ function limitUntrustedHeaderValueForLogs(value: string) {\n return value.length > 100 ? value.slice(0, 100) + '...' : value\n }\n \n+type ServerModuleMap = Record<\n+ string,\n+ | {\n+ id: string\n+ ...
2023-11-29T19:55:00
golang/go
d31f85009cb81604c23e3e471fc4f7d62b9089ff
7234c90352e5ea7769c02808017fb20043ea8210
cmd/compile: skip emitting dictionaries with missing method expressions The nounified frontend currently tries to construct dictionaries that correspond to invalid instantiations (i.e., instantiations T[X] where X does not satisfy the constraints specified on T's type parameter). As a consequence, we may fail to find ...
[ { "path": "src/cmd/compile/internal/noder/stencil.go", "patch": "@@ -1789,6 +1789,7 @@ func (g *genInst) getSymForMethodCall(se *ir.SelectorExpr, subst *typecheck.Tsub\n // instantiations have been created.\n // Also handles writing method expression closures into the dictionaries.\n func (g *genInst) final...
2022-09-08T21:31:42
rust-lang/rust
861f9122c899a8ec52c62ecb0a1435226dd5fc1a
e52666380f6f03fb1211138171e0ef626ceb468d
Fix indent for convert_match_to_let_else Example --- ``` //- minicore: option fn f() { let x$0 = match Some(()) { Some(it) => it, None => {//comment println!("nope"); return }, }; } ``` **Old output**: ```rust fn f() { let Some(x) = Some(()) else {//comment...
[ { "path": "src/tools/rust-analyzer/crates/ide-assists/src/handlers/convert_match_to_let_else.rs", "patch": "@@ -1,7 +1,7 @@\n use ide_db::defs::{Definition, NameRefClass};\n use syntax::{\n AstNode, SyntaxNode,\n- ast::{self, HasName, Name, syntax_factory::SyntaxFactory},\n+ ast::{self, HasName, N...
2025-08-14T00:34:31
nodejs/node
6443ab9595de9e7f57144f063e42efb73e34d714
039cd00a9acfacd3a5a304be09bf17debd54aaaf
module: deprecate module.parent This feature does not work when a module is imported using ECMAScript modules specification, therefore it is deprecated. Fixes: https://github.com/nodejs/modules/issues/469 PR-URL: https://github.com/nodejs/node/pull/32217 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Bradley Far...
[ { "path": "doc/api/deprecations.md", "patch": "@@ -2712,6 +2712,39 @@ The `repl` module exports a `_builtinLibs` property that contains an array with\n native modules. It was incomplete so far and instead it's better to rely upon\n `require('module').builtinModules`.\n \n+<a id=\"DEP0143\"></a>\n+### DEP014...
2020-03-11T22:44:31
facebook/react
367c88e399d60dfa5a5611fcaa5769c18b7ca86e
e1457a14fdea8ae77148147dc8b4611142710cea
Apply component and mixins specs deterministically Fixes #1589.
[ { "path": "docs/docs/05-reusable-components.md", "patch": "@@ -187,5 +187,5 @@ React.renderComponent(\n );\n ```\n \n-A nice feature of mixins is that if a component is using multiple mixins and several mixins define the same lifecycle method (i.e. several mixins want to do some cleanup when the component i...
2014-05-25T22:29:29
vercel/next.js
77f8889b7ca6072f386d382d7ce65b57a5065ce2
e8c0273677bade4801ab6229a013f146e3e209f0
use 303 status code for redirects in fetch actions (#59017) ### What? A `redirect` that occurs during a fetch action will get a status code of 200, while the redirection logic is handled client-side. ### Why? In this scenario, the redirect is handled by the client router, so no `Location` is set on the action r...
[ { "path": "packages/next/src/server/app-render/action-handler.ts", "patch": "@@ -577,13 +577,15 @@ To configure the body size limit for Server Actions, see: https://nextjs.org/doc\n const redirectUrl = getURLFromRedirectError(err)\n const statusCode = getRedirectStatusCodeFromError(err)\n \n- ...
2023-11-29T19:45:06
golang/go
fd82718e06a7b8a32becb1751592854d49904075
ceffdc8545c3155b030de9e91d399dc34bd3c678
internal/bytealg: correct alignment checks for compare/memequal on riscv64 On riscv64 we need 8 byte alignment for 8 byte loads - the existing check was only ensuring 4 byte alignment, which potentially results in unaligned loads being performed. Unaligned loads incur a significant performance penality due to the resu...
[ { "path": "src/bytes/compare_test.go", "patch": "@@ -6,6 +6,7 @@ package bytes_test\n \n import (\n \t. \"bytes\"\n+\t\"fmt\"\n \t\"internal/testenv\"\n \t\"testing\"\n )\n@@ -213,22 +214,30 @@ func BenchmarkCompareBytesDifferentLength(b *testing.B) {\n \t}\n }\n \n-func BenchmarkCompareBytesBigUnaligned(b ...
2022-09-17T06:55:57
rust-lang/rust
23e8a1e1398f5c17f4c64fe740479c2df31c9fd0
b7e4b28c3be2ac96db9dcb6594aecb84355ecd44
Don't panic if unable to identify host in metrics
[ { "path": "src/tools/rust-analyzer/xtask/src/metrics.rs", "patch": "@@ -160,7 +160,7 @@ struct Host {\n \n impl Metrics {\n fn new(sh: &Shell) -> anyhow::Result<Metrics> {\n- let host = Host::new(sh)?;\n+ let host = Host::new(sh).unwrap_or_else(|_| Host::unknown());\n let timestamp...
2025-08-13T19:49:59
facebook/react
8a460ba2e83ce47fa0198865d4bdf50617306971
e1457a14fdea8ae77148147dc8b4611142710cea
Auto-bind before getDefaultProps Fixes #1595.
[ { "path": "src/core/ReactCompositeComponent.js", "patch": "@@ -724,14 +724,14 @@ var ReactCompositeComponentMixin = {\n );\n this._compositeLifeCycleState = CompositeLifeCycle.MOUNTING;\n \n- this.context = this._processContext(this._descriptor._context);\n- this._defaultProps = this.g...
2014-05-25T07:40:39
nodejs/node
49745cdef08e43d87123058798497bba49879c93
5d06a374ea0f8b8d75dc70ba8e765847818dd15b
process: delay throwing an error using `throwDeprecation` This makes sure all warnings that were triggered before a deprecation warning during the same tick are properly handled and logged. It also guarantees that users can not catch the error anymore. Fixes: https://github.com/nodejs/node/issues/17871 PR-URL: http...
[ { "path": "lib/internal/process/warning.js", "patch": "@@ -126,8 +126,13 @@ function emitWarning(warning, type, code, ctor) {\n if (warning.name === 'DeprecationWarning') {\n if (process.noDeprecation)\n return;\n- if (process.throwDeprecation)\n- throw warning;\n+ if (process.throwDe...
2020-03-17T01:17:10
electron/electron
f6bbcc6efa198e1215bc99fdb6919aa507adbeb6
eabe7b9dce0ff02b922d65bf08d40a8fc7cb3915
Fix typos
[ { "path": "docs/api/menu-item.md", "patch": "@@ -70,7 +70,7 @@ The `role` property can have following values:\n * `editMenu` - Whole default \"Edit\" menu (Undo, Copy, etc.)\n * `windowMenu` - Whole default \"Window\" menu (Minimize, Close, etc.)\n \n-The following additional roles are avaiable on macOS:\n+...
2017-04-26T16:06:10
vercel/next.js
6b651b0b12b4c1889ead0bf39cd391c884f37256
e17b368760eae1aaa99cea086490a29a3105afdf
add support for instrumentation (#59070) <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ##...
[ { "path": "packages/next-swc/crates/napi/src/next_api/endpoint.rs", "patch": "@@ -39,8 +39,6 @@ pub struct NapiWrittenEndpoint {\n pub r#type: String,\n pub entry_path: Option<String>,\n pub server_paths: Option<Vec<NapiServerPath>>,\n- pub files: Option<Vec<String>>,\n- pub global_var_nam...
2023-11-29T19:01:38
facebook/react
330fa30141014a0ddafbaae81a6236dd223e7324
e1457a14fdea8ae77148147dc8b4611142710cea
Fix typo in Flux TodoMVC Tutorial A sentence says "only handles one actionType" when the example code instead handles two.
[ { "path": "docs/docs/flux-todo-list.md", "patch": "@@ -245,7 +245,7 @@ module.exports = TodoStore;\n \n There are a few important things to note in the above code. To start, we are maintaining a private data structure called _todos. This object contains all the individual to-do items. Because this variable ...
2014-05-25T05:21:31
nodejs/node
32b641e528210560d9cb4b524acf844f74d0d266
10596b601e503512457131b3a09edadbb680d3ec
http: fixed socket.setEncoding fatal error Applied updates from previous pull-requests to disallow socket.setEncoding before a http connection is parsed. Wrapped `socket.setEncoding` to throw an error. This previously resulted in a fatal error. PR-URL: https://github.com/nodejs/node/pull/33405 Fixes: https://github.c...
[ { "path": "doc/api/errors.md", "patch": "@@ -943,6 +943,11 @@ An invalid HTTP header value was specified.\n \n Status code was outside the regular status code range (100-999).\n \n+<a id=\"ERR_HTTP_SOCKET_ENCODING\"></a>\n+### `ERR_HTTP_SOCKET_ENCODING`\n+\n+Changing the socket encoding is not allowed per [...
2020-05-14T17:29:16
facebook/react
e1457a14fdea8ae77148147dc8b4611142710cea
1e268c359152d04195b026a42dd703867bdec525
Run all tests, fix indentation
[ { "path": "docs/docs/flux-todo-list.md", "patch": "@@ -96,10 +96,10 @@ Dispatcher.prototype = merge(Dispatcher.prototype, {\n var resolves = [];\n var rejects = [];\n _promises = _callbacks.map(function(_, i) {\n- return new Promise(function(resolve, reject) {\n- resolves[i] = re...
2014-05-24T06:03:13
vercel/next.js
e17b368760eae1aaa99cea086490a29a3105afdf
cec374f98c8e6342b818b1465f5c93ede55dbe0e
misc: delete kodiak (#59082) We don't need the auto merging from kodiak since Github has one. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the ch...
[ { "path": ".github/.kodiak.toml", "patch": "@@ -1,19 +0,0 @@\n-# .kodiak.toml\n-version = 1\n-\n-[merge]\n-automerge_label = \"automerge\"\n-require_automerge_label = true\n-method = \"squash\"\n-delete_branch_on_merge = true\n-optimistic_updates = false\n-prioritize_ready_to_merge = true\n-notify_on_confli...
2023-11-29T18:38:33
golang/go
ceffdc8545c3155b030de9e91d399dc34bd3c678
29153be75763b7cbf9395d732f454336e3df0286
cmd/compile: implement slice-to-array conversions The conversion T(x) is implemented as *(*T)(x). Accordingly, runtime panic messages for (*T)(x) are made more general. Fixes #46505. Change-Id: I76317c0878b6a5908299506d392eed50d7ef6523 Reviewed-on: https://go-review.googlesource.com/c/go/+/430415 Reviewed-by: Cuong ...
[ { "path": "src/cmd/compile/internal/escape/expr.go", "patch": "@@ -126,6 +126,10 @@ func (e *escape) exprSkipInit(k hole, n ir.Node) {\n \tcase ir.OITAB, ir.OIDATA, ir.OSPTR:\n \t\tn := n.(*ir.UnaryExpr)\n \t\te.expr(k, n.X)\n+\tcase ir.OSLICE2ARR:\n+\t\t// Converting a slice to array is effectively a deref...
2022-09-12T20:01:57
rust-lang/rust
7b5d9efb7d0833e7d9b3ca8690ec2b8173ee499c
350d0ef0ec0493e6d21cfb265cb8211a0e74d766
Improve `--remap-path-prefix` documentation Co-Authored-By: Weihang Lo <me@weihanglo.tw> Co-Authored-By: Wesley Wiser <wwiser@gmail.com>
[ { "path": "src/doc/rustc/src/SUMMARY.md", "patch": "@@ -23,6 +23,7 @@\n - [Linker-plugin-based LTO](linker-plugin-lto.md)\n - [Checking Conditional Configurations](check-cfg.md)\n - [Cargo Specifics](check-cfg/cargo-specifics.md)\n+- [Remap source paths](remap-source-paths.md)\n - [Exploit Mitigations](...
2025-06-11T16:23:06
electron/electron
2c48300daa487fdfab0c9786e3aa2ffe467d89c5
246937a37209810779d43bd2c02c71174df29f28
Fix typos in comment
[ { "path": "lib/renderer/window-setup.js", "patch": "@@ -32,9 +32,9 @@ const resolveURL = function (url) {\n return a.href\n }\n \n-// Use this method to ensure value expected as string in the main process\n-// are convertible to string in the renderer process. This ensures exceptions\n-// converting value...
2017-04-26T16:09:42
nodejs/node
10596b601e503512457131b3a09edadbb680d3ec
7a2c67cf53da9cf5d7e508340fb353f6a1c25c37
worker: fix variable referencing in template string PR-URL: https://github.com/nodejs/node/pull/33467 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <ja...
[ { "path": "lib/internal/worker.js", "patch": "@@ -216,7 +216,7 @@ class Worker extends EventEmitter {\n this[kDispose]();\n if (customErr) {\n debug(`[${threadId}] failing with custom error ${customErr} \\\n- and with reason {customErrReason}`);\n+ and with reason ${customErrReas...
2020-05-19T05:35:29
facebook/react
f8d029187407bab8028bf8ac4d24f29937cdd6bd
de1f7831883e8c438ecaaf2918044ce73bd92383
Fix doc typo and remove underscore from local var
[ { "path": "docs/docs/flux-todo-list.md", "patch": "@@ -93,22 +93,22 @@ Dispatcher.prototype = merge(Dispatcher.prototype, {\n */\n dispatch: function(payload) {\n // First create array of promises for callbacks to reference.\n- var _resolves = [];\n- var _rejects = [];\n+ var resolves = []...
2014-05-23T19:34:40
vercel/next.js
9e33bf6ab929c81f694880460cce90156ecbfd6f
72388bc986f409d089a1f4ea0885e574558f189b
misc: disable automerge (#59077) Disabling the auto merging behaviour from kodiak. You can queue stuff up by adding an automerge label though. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sect...
[ { "path": ".github/.kodiak.toml", "patch": "@@ -2,8 +2,8 @@\n version = 1\n \n [merge]\n-automerge_label = \"ready to land\"\n-require_automerge_label = false\n+automerge_label = \"automerge\"\n+require_automerge_label = true\n method = \"squash\"\n delete_branch_on_merge = true\n optimistic_updates = false...
2023-11-29T17:19:00
rust-lang/rust
f978932903cac8cf508ef78b8133fafd9fe5a5b8
350d0ef0ec0493e6d21cfb265cb8211a0e74d766
fix(compiler/rustc_codegen_llvm): apply `target-cpu` attribute
[ { "path": "Cargo.lock", "patch": "@@ -3283,7 +3283,7 @@ dependencies = [\n \"regex\",\n \"serde_json\",\n \"similar\",\n- \"wasmparser 0.219.2\",\n+ \"wasmparser 0.236.0\",\n ]\n \n [[package]]", "additions": 1, "deletions": 1, "language": "Unknown" }, { "path": "compiler/rustc_codege...
2025-08-11T21:39:24
golang/go
29153be75763b7cbf9395d732f454336e3df0286
38cecb22903415b34991ce76efe725f47aaf21a3
go/internal/gcimporter: fix ureader.go handling of local defined types In unified IR, local defined types are promoted to a global defined type with a "vargen" suffix. These shouldn't actually be exposed to go/types users, because they're only relevant within function bodies, which go/types doesn't support importing. ...
[ { "path": "src/go/internal/gcimporter/gcimporter_test.go", "patch": "@@ -173,13 +173,14 @@ func TestImportTypeparamTests(t *testing.T) {\n \t\tt.Fatal(err)\n \t}\n \n-\tskip := map[string]string{\n-\t\t\"equal.go\": \"inconsistent embedded sorting\", // TODO(rfindley): investigate this.\n-\t\t\"nested....
2022-09-16T21:27:01
electron/electron
7e285711ca7d72a45bcec19039796354a9abbc6c
4e7e9d1752ec8e9578c5c5f23ff232b34e429d6d
Add spec for window.open toString errors
[ { "path": "spec/chromium-spec.js", "patch": "@@ -361,6 +361,16 @@ describe('chromium feature', function () {\n })\n b = window.open()\n })\n+\n+ it('throws an exception when the arguments cannot be converted to strings', function () {\n+ assert.throws(function () {\n+ window.o...
2017-04-25T20:16:07
nodejs/node
7a2c67cf53da9cf5d7e508340fb353f6a1c25c37
442610fa51bb7f09a7eb6a65447d4ce05b45df86
doc: correct tls.rootCertificates to match implementation Update tls.rootCertificates documentation to clarify that it returns the bundled Node.js root certificates rather than the root certificates used by tls.createSecureContext. Fixes: https://github.com/nodejs/node/issues/32074 Refs: https://github.com/nodejs/nod...
[ { "path": "doc/api/tls.md", "patch": "@@ -1791,8 +1791,10 @@ added: v12.3.0\n * {string[]}\n \n An immutable array of strings representing the root certificates (in PEM format)\n-used for verifying peer certificates. This is the default value of the `ca`\n-option to [`tls.createSecureContext()`][].\n+from t...
2020-05-08T14:37:50
facebook/react
e60a893d2fe9df1181ca76f98b7e93225d2a69d2
9ef6156d5cdb8006d193eceac2f6b4fae80e7dcd
Bump esprima-fb and jstransform versions Fixes #1584, fixes #1475.
[ { "path": "package.json", "patch": "@@ -34,8 +34,8 @@\n },\n \"dependencies\": {\n \"commoner\": \"^0.9.2\",\n- \"esprima-fb\": \"~3001.1.0-dev-harmony-fb\",\n- \"jstransform\": \"~4.0.1\"\n+ \"esprima-fb\": \"~4001.1.0-dev-harmony-fb\",\n+ \"jstransform\": \"~5.0.0\"\n },\n \"devDep...
2014-05-23T03:15:57
vercel/next.js
72388bc986f409d089a1f4ea0885e574558f189b
d6d41dc66d60b5a2bdd732deb2ac3f99bb959ee1
fix(test): don't use latest sharp (#59074)
[ { "path": "test/integration/image-optimizer/test/sharp.test.ts", "patch": "@@ -14,7 +14,7 @@ describe('with latest sharp', () => {\n packageManager: 'yarn@1.22.19',\n })\n )\n- await execa('yarn', ['add', 'sharp'], {\n+ await execa('yarn', ['add', 'sharp@^0.32.0'], {\n cwd: app...
2023-11-29T17:13:58
rust-lang/rust
bc0e43c0f2f76796066e4ec8335b44c00eefbc00
371b1747115d240696cef30657bd0ee99aab19d2
fix `borrow_as_ptr`: don't lint in proc-macros
[ { "path": "clippy_lints/src/casts/borrow_as_ptr.rs", "patch": "@@ -2,7 +2,7 @@ use clippy_utils::diagnostics::{span_lint_and_sugg, span_lint_and_then};\n use clippy_utils::msrvs::Msrv;\n use clippy_utils::source::{snippet_with_applicability, snippet_with_context};\n use clippy_utils::sugg::has_enclosing_par...
2025-08-13T09:10:44
golang/go
38cecb22903415b34991ce76efe725f47aaf21a3
d74bf73be052851e83fb59a40f47d49f4b890ca3
test: add regress test for issue 55101 This test case already works with GOEXPERIMENT=unified, and it never worked with Go 1.18 or Go 1.19. So this CL simply adds a regress test to make sure it continues working. Fixes #55101. Change-Id: I7e06bfdc136ce124f65cdcf02d20a1050b841d42 Reviewed-on: https://go-review.google...
[ { "path": "src/go/internal/gcimporter/gcimporter_test.go", "patch": "@@ -179,6 +179,7 @@ func TestImportTypeparamTests(t *testing.T) {\n \t\t\"issue50417.go\": \"inconsistent interface member sorting\",\n \t\t\"issue53419.go\": \"fails to compile\",\n \t\t\"issue53477.go\": \"fails to compile\",\n+\t\t\"iss...
2022-09-16T20:11:49
nodejs/node
442610fa51bb7f09a7eb6a65447d4ce05b45df86
9cd83c761f688079efeae931cb3462b9ba6d18e3
Revert "src: fix missing extra ca in tls.rootCertificates" A fix to tls.rootCertificates to have it correctly return the process' current root certificates resulted in non-deterministic behavior when Node.js is configured to use an OpenSSL system or file-based certificate store. The safest action is to revert the cha...
[ { "path": "src/node_crypto.cc", "patch": "@@ -1008,6 +1008,24 @@ static X509_STORE* NewRootCertStore() {\n }\n \n \n+void GetRootCertificates(const FunctionCallbackInfo<Value>& args) {\n+ Environment* env = Environment::GetCurrent(args);\n+ Local<Value> result[arraysize(root_certs)];\n+\n+ for (size_t i ...
2020-05-08T14:35:17
facebook/react
bf5dfc87dc2a422122b0addc43cabda4d3cf4c98
696e556eaef7c293ebba7ee81451332a1b2ff645
Error in extractEvents If the event is on the window object, topScroll, for instance, the topLevelTarget will not have getAttribute defined. Restore the previous `|| !topLevelTarget.attributes` check to avoid an error on every scroll.
[ { "path": "src/browser/eventPlugins/AnalyticsEventPluginFactory.js", "patch": "@@ -149,7 +149,7 @@ function extractEvents(\n topLevelTargetID,\n nativeEvent) {\n var currentEvent = topLevelTypesToAnalyticsEvent[topLevelType];\n- if (!currentEvent || !topLevelTarget) {\n+ if (!currentEvent || !to...
2014-05-19T20:17:14
vercel/next.js
f1d9f8ac3f83468d2ba5633b9c89f380184bef2b
118888565577de4b4d395dd929314c5114d4d7cb
fix stack trace of errors (vercel/turbo#6627) ### Description `downcast` is weird and not doing what you would expect... It picks an error from the chain of errors... ### Testing Instructions <!-- Give a quick description of steps to test your changes. --> Closes PACK-2053
[ { "path": "crates/turbo-tasks/src/util.rs", "patch": "@@ -24,11 +24,8 @@ pub struct SharedError {\n \n impl SharedError {\n pub fn new(err: Error) -> Self {\n- match err.downcast::<SharedError>() {\n- Ok(shared) => shared,\n- Err(plain) => Self {\n- inner: Arc...
2023-11-29T07:18:55
golang/go
e283473ebbebf4a80db166e7e852d03c5cff1a61
0053ec452db5bd973c7ac9f4faa5041884e460e8
cmd/compile: avoid using destination pointer base type in memmove optimization The type of the source and destination of a memmove call isn't always accurate. It will always be a pointer (or an unsafe.Pointer), but the base type might not be accurate. This comes about because multiple copies of a pointer with differen...
[ { "path": "src/cmd/compile/internal/ssa/gen/generic.rules", "patch": "@@ -2112,39 +2112,42 @@\n \n // Inline small or disjoint runtime.memmove calls with constant length.\n // See the comment in op Move in genericOps.go for discussion of the type.\n-\n+//\n+// Note that we've lost any knowledge of the type ...
2022-09-17T22:52:35
facebook/react
c9bac95034c58724ef4cc5d10ab69ddb65330e30
7094737782eb763f078e94fafcf44f932c1f0181
Fix nested UL spacing.
[ { "path": "docs/_css/react.scss", "patch": "@@ -224,7 +224,7 @@ h1, h2, h3, h4, h5, h6 {\n margin: 0;\n }\n ul ul {\n- margin-left: 20px;\n+ margin: 6px 0 0 20px;\n }\n li {\n line-height: 16px;", "additions": 1, "deletions": 1, "language": "Unknown" } ]
2014-05-21T19:26:01
nodejs/node
6af15ebf220e084fe285a95fa0925f7b2efe024e
b3f14df485d89ad7866573536fe07783e516a5ae
benchmark: fixing http_server_for_chunky_client.js PR-URL: https://github.com/nodejs/node/pull/33271 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
[ { "path": "benchmark/http/http_server_for_chunky_client.js", "patch": "@@ -10,7 +10,9 @@ process.env.PIPE_NAME = PIPE;\n \n tmpdir.refresh();\n \n-const server = http.createServer((req, res) => {\n+// For Node.js versions below v13.3.0 this benchmark will require\n+// the flag --max-http-header-size 64000 i...
2020-05-06T15:40:01
electron/electron
c2d4c93e12da6af51158bb31fd46f7f6ba261813
13e4582697e8df68c8271ac6c813e81ec20722a1
Don't run error event on Linux
[ { "path": "spec/api-auto-updater-spec.js", "patch": "@@ -67,6 +67,10 @@ if (!process.mas) {\n \n describe('error event', function () {\n it('serializes correctly over the remote module', function (done) {\n+ if (process.platform === 'linux') {\n+ return done()\n+ }\n+\n ...
2017-04-21T23:50:19
vercel/next.js
ca19ffb63b6a17e55828f601eb3677033e523e41
ef3c6490fe6eabcbf9a1bd51244f4d14473e1c64
Fixed stale fetch using when page regenerates (#58926) fixes: #58909 x-ref: #58321, #56472, #56231 Removed the Math.round of age since it can cause stale fetch data to be considered not stale if the age rounds downwards. (5.49 is rounded to 5) Note: This most likely also fixes some bugs with revalidateTag/re...
[ { "path": "packages/next/src/server/lib/incremental-cache/index.ts", "patch": "@@ -460,9 +460,7 @@ export class IncrementalCache implements IncrementalCacheType {\n }\n \n revalidate = revalidate || cacheData.value.revalidate\n- const age = Math.round(\n- (Date.now() - (cacheData.las...
2023-11-29T02:54:31