repo
stringclasses
15 values
fix_commit
stringlengths
40
40
buggy_commit
stringlengths
40
40
message
stringlengths
3
64.3k
files
listlengths
1
300
timestamp
timestamp[s]date
2013-03-13 20:45:00
2026-04-11 07:48:46
nodejs/node
e5e011d9bc71c7d651db47950a5af0e738f68784
5e41765f47a4dfb519047428026dff9be4f7e0a9
doc: add directions to mark a release line as lts Moves directions for LTS release from the Release repo to Node docs. Fixes: https://github.com/nodejs/Release/issues/530 PR-URL: https://github.com/nodejs/node/pull/31724 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Revie...
[ { "path": "doc/releases.md", "patch": "@@ -32,6 +32,7 @@ official release builds for Node.js, hosted on <https://nodejs.org/>.\n * [17. Cleanup](#17-cleanup)\n * [18. Announce](#18-announce)\n * [19. Celebrate](#19-celebrate)\n+* [LTS Releases](#lts-releases)\n * [Major Releases](#major-releases)\n \n...
2020-02-10T19:47:05
electron/electron
c65033a13b7ec349e10cf54f47a81f12997db052
67f33cdb60fa09e9a1373419df4ec8a5e7fe089b
Revert "incorrect position when restored from maximize-on-top-drag under Windows #7630" This reverts commit a2b3abbf47f2adc8f945f3e12ce6f756670d03ca.
[ { "path": "atom/browser/native_window_views.cc", "patch": "@@ -327,6 +327,7 @@ NativeWindowViews::NativeWindowViews(\n last_window_state_ = ui::SHOW_STATE_FULLSCREEN;\n else\n last_window_state_ = ui::SHOW_STATE_NORMAL;\n+ last_normal_bounds_ = GetBounds();\n #endif\n }\n ", "additions": 1, ...
2016-11-22T04:49:56
facebook/react
e379f8ec03c9b350937ef78331c0e1a0f5364838
dbdf1cc296de40786146da4bdedd8172c9f555d7
Fix all errors and warnings on homepage Also onChange instead of onInput in two places!
[ { "path": "docs/_js/examples/timer.js", "patch": "@@ -11,7 +11,10 @@ var Timer = React.createClass({\\n\\\n this.setState({secondsElapsed: this.state.secondsElapsed + 1});\\n\\\n },\\n\\\n componentDidMount: function() {\\n\\\n- setInterval(this.tick, 1000);\\n\\\n+ this.interval = setInterval...
2013-07-17T20:08:38
golang/go
53a4152d478d75ef4b71e428b9d69ed54144081f
177306f6305b35bf6993c2d74baa7fb60cd3f5d4
os/exec: clarify that Wait must be called Fixes #52580 Change-Id: Ib2dd8a793b9c6fcb083abb3f7c346f6279adefc9 Reviewed-on: https://go-review.googlesource.com/c/go/+/414056 Run-TryBot: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Alan Donovan <adonovan@google.com> Review...
[ { "path": "src/os/exec/exec.go", "patch": "@@ -462,8 +462,8 @@ func lookExtensions(path, dir string) (string, error) {\n //\n // If Start returns successfully, the c.Process field will be set.\n //\n-// The Wait method will return the exit code and release associated resources\n-// once the command exits.\n...
2022-06-24T21:34:28
vercel/next.js
e4d072f35d15c83a6c5516b6230b2f009765ba3d
711fa2133d3ba86c01673dac6df27821cef4aff4
Add support for skipTrailingSlashRedirect and skipMiddlewareUrlNormalize in Turbopack (#56147) This one only requires the environment variable to be set. Existing tests already cover this feature. With these changes `test/e2e/skip-trailing-slash-redirect` can run, didn't check if there are failing tests yet. <...
[ { "path": "packages/next-swc/crates/next-core/src/env.rs", "patch": "@@ -99,6 +99,37 @@ pub async fn env_for_js(\n },\n );\n \n+ map.insert(\n+ \"__NEXT_MANUAL_TRAILING_SLASH\".to_string(),\n+ if next_config.skip_trailing_slash_redirect.unwrap_or(false) {\n+ \"true\"....
2023-09-28T11:16:35
electron/electron
964c88a1891ab59eb5bbcc73c8e4a230b8bbe158
71f94c7a3ad1014a0c1fdca248046c4d61cb3988
Update open-url docs to mention NSPrincipalClass We got bit by a nasty bug today - if you change your app's info.plist `NSPrincipalClass` to something other to `AtomApplication` (We set it to NylasApplication via a bad find-replace), everything works except open-url is never fired. Add a small reference to the docs so...
[ { "path": "docs/api/app.md", "patch": "@@ -108,8 +108,9 @@ Returns:\n * `event` Event\n * `url` String\n \n-Emitted when the user wants to open a URL with the application. The URL scheme\n-must be registered to be opened by your application.\n+Emitted when the user wants to open a URL with the application. ...
2016-11-22T00:55:18
nodejs/node
5e41765f47a4dfb519047428026dff9be4f7e0a9
09b6894fe8b5eb8a0625effdc701d6da765078ab
doc: expand C++ README with information about exception handling Add more information about why it is advisable not to use `.FromJust()` etc. on Maybe(Local)s, and general information about termination exceptions. PR-URL: https://github.com/nodejs/node/pull/31720 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-...
[ { "path": "src/README.md", "patch": "@@ -424,6 +424,23 @@ This should only be performed if it is actually sure that the operation has\n not failed. A lot of Node.js’s source code does **not** follow this rule, and\n can be brought to crash through this.\n \n+In particular, it is often not safe to assume tha...
2020-02-10T18:26:38
facebook/react
dd14fdfdc57d9a0dd9eeb10d83daacce77a2aaa3
fc6a567e0e3756513fc3d34990ef7a4afd4316ae
todo fix
[ { "path": "docs/_js/examples/todo.js", "patch": "@@ -30,8 +30,8 @@ var TodoApp = React.createClass({\\n\\\n <div>\\n\\\n <h3>TODO</h3>\\n\\\n <TodoList items={this.state.items} />\\n\\\n- <form onSubmit={this.handleSubmit.bind(this)}>\\n\\\n- <input onKeyUp={this.onKey....
2013-07-17T20:28:04
rust-lang/rust
64276e688c464c4d02a9be6357ca0157167ea075
c7dd98c80913b9845f49997142e5bec3524bc343
chore: fix some minor issues in comments Signed-off-by: houpo-bob <houpocun@outlook.com>
[ { "path": "clippy_lints/src/infallible_try_from.rs", "patch": "@@ -13,7 +13,7 @@ declare_clippy_lint! {\n ///\n /// ### Why is this bad?\n ///\n- /// Infalliable conversions should be implemented via `From` with the blanket conversion.\n+ /// Infallible conversions should be implemented vi...
2025-07-30T07:49:56
golang/go
177306f6305b35bf6993c2d74baa7fb60cd3f5d4
f4755fc7333f524666f6ba3140cee0d180bce8b3
cmd/internal/notsha256: add purego tag as needed This permits building the package with gccgo, when using gccgo as a bootstrap compiler. Fixes #53662 Change-Id: Ic7ae9323ec5954e9306a32e1160e9aa1ed3aa202 Reviewed-on: https://go-review.googlesource.com/c/go/+/415935 TryBot-Result: Gopher Robot <gobot@golang.org> Run-T...
[ { "path": "src/cmd/internal/notsha256/sha256block_386.s", "patch": "@@ -2,6 +2,9 @@\n // Use of this source code is governed by a BSD-style\n // license that can be found in the LICENSE file.\n \n+//go:build !purego\n+// +build !purego\n+\n // SHA256 block routine. See sha256block.go for Go equivalent.\n //...
2022-07-03T20:34:47
electron/electron
62b39d58ca9000a817c64969429626f92abd8d89
71f94c7a3ad1014a0c1fdca248046c4d61cb3988
crash-reporter -> crashReporter
[ { "path": "docs/api/crash-reporter.md", "patch": "@@ -32,7 +32,7 @@ API before starting the crash reporter.\n \n ## Methods\n \n-The `crash-reporter` module has the following methods:\n+The `crashReporter` module has the following methods:\n \n ### `crashReporter.start(options)`\n \n@@ -70,7 +70,7 @@ Return...
2016-11-21T23:42:24
facebook/react
96bd63cc4bc36791aa6b7fc4559e5c5e9e00bab7
ec67076090941287bacb48fcaf43d88cf28518a8
Fix typo in blogpost I fixed this in the changelog, but missed this one.
[ { "path": "docs/_posts/2013-07-17-react-v0-4-0.md", "patch": "@@ -30,7 +30,7 @@ When you're ready, [go download it](/react/downloads.html)!\n \n * Support for comment nodes `<div>{/* this is a comment and won't be rendered */}</div>`\n * Children are now transformed directly into arguments instead of being ...
2013-07-17T20:23:18
nodejs/node
d63bcdd9cd81b10b6158f40d44bf6f37e5f54385
84b8857098b2a846855bb2420f3a1144ef68cce3
worker: properly handle env and NODE_OPTIONS in workers PR-URL: https://github.com/nodejs/node/pull/31711 Fixes: https://github.com/nodejs/node/issues/30627 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
[ { "path": "lib/internal/errors.js", "patch": "@@ -1358,8 +1358,8 @@ E('ERR_VM_MODULE_NOT_MODULE',\n 'Provided module is not an instance of Module', Error);\n E('ERR_VM_MODULE_STATUS', 'Module status %s', Error);\n E('ERR_WASI_ALREADY_STARTED', 'WASI instance has already started', Error);\n-E('ERR_WORKER_I...
2020-02-09T22:18:10
golang/go
4484c30f788835d8dda0afcefdb12e4b25b2c312
2007599dc83aff17d8261338e8d2ab1f2c518a9b
misc/cgo/test: make TestSetgidStress cheaper TestSetgidStress spawns 1000 threads, which can be expensive on some platforms or slow builders. Run with 50 threads in short mode instead. This makes the failure less reproducible even with buggy code. But one can manually stress test it (e.g. when a flaky failure appear ...
[ { "path": "misc/cgo/test/setgid2_linux.go", "patch": "@@ -20,7 +20,10 @@ import (\n )\n \n func testSetgidStress(t *testing.T) {\n-\tconst N = 1000\n+\tvar N = 1000\n+\tif testing.Short() {\n+\t\tN = 50\n+\t}\n \tch := make(chan int, N)\n \tfor i := 0; i < N; i++ {\n \t\tgo func() {", "additions": 4, ...
2022-07-01T16:56:39
vercel/next.js
711fa2133d3ba86c01673dac6df27821cef4aff4
3e32378c7373ae2b4df0afce7b6376501a0dd075
More test updates (#56146) Follow-up to #56089 <!-- Thanks for opening a PR! Your contribution is much appreciated.i To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contribu...
[ { "path": "test/integration/css-customization/test/index.test.js", "patch": "@@ -8,375 +8,383 @@ import escapeStringRegexp from 'escape-string-regexp'\n const fixturesDir = join(__dirname, '../..', 'css-fixtures')\n \n describe('CSS Customization', () => {\n- const appDir = join(fixturesDir, 'custom-config...
2023-09-28T11:11:11
facebook/react
b837bb7bdd2f4d66531766e0a660a9a10314f12e
c629a0c5ad1adc82e01a982e7116eae632fa8d65
[docs] fix typo "L" is not ":"
[ { "path": "docs/docs/03-interactivity-and-dynamic-uis.md", "patch": "@@ -86,4 +86,4 @@ A common pattern is to create several stateless components that just render data\n \n * **Computed data:** Don't worry about precomputing values based on state — it's easier to ensure that your UI is consistent if you do ...
2013-07-17T15:45:27
nodejs/node
1c11ea43883256b6bc9e64a28bbc22f88c5c2b38
8d8f7c6e17be62771b1f0b0f02d257fc435496c2
2020-02-11, Version 12.16.0 'Erbium' (LTS) Notable changes: New assert APIs The `assert` module now provides experimental `assert.match()` and `assert.doesNotMatch()` methods. They will validate that the first argument is a string and matches (or does not match) the provided regular expression This is an experiment...
[ { "path": "CHANGELOG.md", "patch": "@@ -41,7 +41,8 @@ release.\n <a href=\"doc/changelogs/CHANGELOG_V13.md#13.0.0\">13.0.0</a><br/>\n </td>\n <td valign=\"top\">\n-<b><a href=\"doc/changelogs/CHANGELOG_V12.md#12.15.0\">12.15.0</a></b><br/>\n+<b><a href=\"doc/changelogs/CHANGELOG_V12.md#12.16.0\">12....
2020-02-08T00:08:57
golang/go
2007599dc83aff17d8261338e8d2ab1f2c518a9b
d602380f58e2a2ab4b262c7d69b78ff634cba5e8
test: recognize new gofrontend error message The new gofrontend message matches other gofrontend error messages, so adjust the test to accept it. For #27938 For #51237 Change-Id: I29b536f83a0cf22b1dbdae9abc2f5f6cf21d522d Reviewed-on: https://go-review.googlesource.com/c/go/+/416014 Run-TryBot: Ian Lance Taylor <iant...
[ { "path": "test/fixedbugs/issue27938.go", "patch": "@@ -11,13 +11,13 @@\n package p\n \n type _ struct {\n-\tF sync.Mutex // ERROR \"undefined: sync|expected package\"\n+\tF sync.Mutex // ERROR \"undefined: sync|expected package|reference to undefined name\"\n }\n \n type _ struct {\n-\tsync.Mutex // ERROR ...
2022-07-04T20:16:46
vercel/next.js
3e32378c7373ae2b4df0afce7b6376501a0dd075
e9c264db5698eec83ced2f98d0299a36e7d88be1
misc: refactor node utils (#56096) This PR just splits apart a big file. Not a big size improvement but still worthwhile. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose t...
[ { "path": "packages/next/src/server/api-utils/node/api-resolver.ts", "patch": "@@ -1,19 +1,16 @@\n import type { IncomingMessage, ServerResponse } from 'http'\n-import type { NextApiRequest, NextApiResponse } from '../../shared/lib/utils'\n-import type { PageConfig, ResponseLimit, SizeLimit } from 'next/typ...
2023-09-28T09:07:34
facebook/react
156dffb961ab15f577e0a6aab1abc5efd68f9a9b
e5befc0a73daf1f587eaa7443a9786ddbf5d23ac
[docs] Fix broken links
[ { "path": "docs/docs/02-displaying-data.md", "patch": "@@ -84,8 +84,8 @@ We've found that the best solution for this problem is to generate markup direct\n \n **JSX lets you write JavaScript function calls with HTML syntax.** To generate a link in React using pure JavaScript you'd write: `React.DOM.a({href:...
2013-07-17T08:36:20
facebook/react
b343fcaba34949c6c5ef530305dd186aa1a1f02a
526099c92844660ad0fc85712d989670313cfce1
grammar error
[ { "path": "docs/docs/01-why-react.md", "patch": "@@ -23,7 +23,7 @@ React is all about building reusable components. In fact, with React the *only*\n \n ## Give It Five Minutes\n \n-React challenges a lot of conventional wisdom, and at first glance some of the ideas may seem crazy. [Give it five minutes](htt...
2013-07-17T04:15:49
golang/go
c1110910713766eb06d75ed48db3722d318a845e
5f305ae8e5796ea3821088863a6842117c58da72
cmd/go: make module@nonexistentversion failures reusable CL 411398 added the -reuse flag for reusing cached JSON output when the remote Git repository has not changed. One case that was not yet cached is a lookup of a nonexistent version. This CL adds caching of failed lookups of nonexistent versions, by saving a che...
[ { "path": "src/cmd/go/internal/modfetch/cache.go", "patch": "@@ -253,11 +253,12 @@ func (r *cachingRepo) Stat(rev string) (*RevInfo, error) {\n \t\treturn cachedInfo{info, err}\n \t}).(cachedInfo)\n \n-\tif c.err != nil {\n-\t\treturn nil, c.err\n+\tinfo := c.info\n+\tif info != nil {\n+\t\tcopy := *info\n+...
2022-07-01T20:10:19
vercel/next.js
e9c264db5698eec83ced2f98d0299a36e7d88be1
c2fd08063c804dcfc6e3f12cd454d7a73184504c
perf: externalise ws for bundled server (#56095) This PR makes `ws` an external. AFAIK we don't really need it on prod, so this saves around 40KB on the server. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow ...
[ { "path": "packages/next/webpack.config.js", "patch": "@@ -62,6 +62,7 @@ const sharedExternals = [\n 'next/dist/compiled/jsonwebtoken',\n 'next/dist/compiled/@opentelemetry/api',\n 'next/dist/compiled/@mswjs/interceptors/ClientRequest',\n+ 'next/dist/compiled/ws',\n ]\n \n const externalsMap = {", ...
2023-09-28T09:06:30
rust-lang/rust
e8db4aa4706a4fdfc9a2cbf32a3cbbd11a6d14d1
7b3bd5bc8c875fc4d02249531701041d0a813326
Fix min_ident_chars: add trait/impl awareness
[ { "path": "clippy_lints/src/min_ident_chars.rs", "patch": "@@ -4,10 +4,14 @@ use clippy_utils::is_from_proc_macro;\n use rustc_data_structures::fx::FxHashSet;\n use rustc_hir::def::{DefKind, Res};\n use rustc_hir::intravisit::{Visitor, walk_item, walk_trait_item};\n-use rustc_hir::{GenericParamKind, HirId, ...
2025-07-14T18:24:54
electron/electron
26137977cdc16645ea5a21ffe117d9607fce557c
cbffd598f9277fbd5aed762228997031f00e0789
Fix crash when return value pointer is null
[ { "path": "atom/browser/api/atom_api_system_preferences_mac.mm", "patch": "@@ -28,17 +28,17 @@\n \n } // namespace\n \n-void SystemPreferences::PostNotification(const std::string& name, \n+void SystemPreferences::PostNotification(const std::string& name,\n const base::DictionaryValue& user_info) {\n ...
2016-11-17T00:30:46
rust-lang/rust
fe08ba0bae44b870fdda45a98ac51f435ddfc044
ba7e63b63871a429533c189adbfb1d9a6337e000
Re-block SRoA on SIMD types Fixes 144621
[ { "path": "compiler/rustc_mir_transform/src/sroa.rs", "patch": "@@ -72,8 +72,12 @@ fn escaping_locals<'tcx>(\n return true;\n }\n if let ty::Adt(def, _args) = ty.kind()\n- && tcx.is_lang_item(def.did(), LangItem::DynMetadata)\n+ && (def.repr().simd() || tcx....
2025-07-30T03:41:34
facebook/react
9694a0f7eaf7c105c44e2b3beb1578986f36a143
04bfa545f7148dfdce5df5cf2e6d1f6ba31cbfab
Fix title casing and heading levels
[ { "path": "docs/_includes/nav_docs.html", "patch": "@@ -2,21 +2,21 @@\n <div class=\"nav-docs-section\">\n <h3>Quick start</h3>\n <ul>\n- <li><a href=\"/react/docs/getting-started.html\"{% if page.id == 'getting-started' %} class=\"active\"{% endif %}>Getting started</a></li>\n+ <li><a h...
2013-07-16T21:52:57
golang/go
84e091eef033255b4a3fdb515d677faa135714dc
ceda93ed673294f0ce5eb3a723d563091bff0a39
cmd/go: record origin metadata during module download This change adds an "Origin" JSON key to the output of go list -json -m and go mod download -json. The associated value is a JSON object with metadata about the source control system. For Git, that metadata is sufficient to evaluate whether the remote server has ch...
[ { "path": "src/cmd/go/internal/modcmd/download.go", "patch": "@@ -149,7 +149,7 @@ func runDownload(ctx context.Context, cmd *base.Command, args []string) {\n \n \tdownloadModule := func(m *moduleJSON) {\n \t\tvar err error\n-\t\tm.Info, err = modfetch.InfoFile(m.Path, m.Version)\n+\t\t_, m.Info, err = modfe...
2022-06-09T03:56:28
vercel/next.js
c2fd08063c804dcfc6e3f12cd454d7a73184504c
3b0ee4e5f8841a522e001e624819b3a970ae6beb
perf: replace zod with superstruct (#56083) This PR replaces the usage of Zod in the App Router in favour of a smaller validation library. We don't use much of zod's more advanced capabilities so it doesn't make sense to import all of it on the server at the moment. Also added some unit tests. This results in a ...
[ { "path": "packages/next/index.d.ts", "patch": "@@ -1,4 +1,5 @@\n /// <reference types=\"./types/global\" />\n+/// <reference types=\"./types/compiled\" />\n /// <reference path=\"./dist/styled-jsx/types/global.d.ts\" />\n /// <reference path=\"./amp.d.ts\" />\n /// <reference path=\"./app.d.ts\" />", "...
2023-09-28T09:05:36
nodejs/node
acfb78b5319bf44cdf368e3b2b9d7caca75d0dd6
5b0308cd823a511098dadf9ddd5a35e3a9dbb424
test: fix flaky test-fs-stat-bigint Change test limit for atime from 2ms to 5ms. Add comment explaining why the wiggle room is needed. Fixes: https://github.com/nodejs/node/issues/24593 PR-URL: https://github.com/nodejs/node/pull/30437 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Denys Otrishko <shi...
[ { "path": "test/parallel/test-fs-stat-bigint.js", "patch": "@@ -13,6 +13,10 @@ tmpdir.refresh();\n \n let testIndex = 0;\n \n+// It's possible that the file stats are updated between the two statSync()\n+// calls so allow for a small difference.\n+const allowableDelta = 5;\n+\n function getFilename() {\n ...
2019-11-12T16:10:22
golang/go
3cf79d96105d890d7097d274804644b2a2093df1
e822b1e26e20ef1c76672c0b77b0fd8a97a1fe84
runtime: pass correct string to exits on Plan 9 In CL 405901 the definition of exit in the Plan 9 go runtime was changed like so: - status = append(itoa(tmp[:len(tmp)-1], uint64(e)), 0) + sl := itoa(tmp[:len(tmp)-1], uint64(e)) + // Don't append, rely on the existing data ...
[ { "path": "src/runtime/os_plan9.go", "patch": "@@ -439,7 +439,7 @@ func exit(e int32) {\n \t\tvar tmp [32]byte\n \t\tsl := itoa(tmp[:len(tmp)-1], uint64(e))\n \t\t// Don't append, rely on the existing data being zero.\n-\t\tstatus = tmp[:len(sl)+1]\n+\t\tstatus = sl[:len(sl)+1]\n \t}\n \tgoexitsall(&status[...
2022-07-03T16:26:30
vercel/next.js
3b0ee4e5f8841a522e001e624819b3a970ae6beb
cd70065bad00cb9d3b0e7c9a94ee9241e3c5f5d8
perf: remove react dom legacy from app router (#56082) This PR includes changes to Next.js bundling in order to aliases references to the `react-dom/server` legacy build to a no-op in order to save KBs. We don't use any of the legacy methods so it's best to just shave it off. This should improve cold boots for both ed...
[ { "path": "packages/next/src/build/noop-react-dom-server-legacy.ts", "patch": "@@ -0,0 +1,10 @@\n+const ERROR_MESSAGE =\n+ 'Internal Error: do not use legacy react-dom/server APIs. If you encountered this error, please open an issue on the Next.js repo.'\n+\n+export function renderToString() {\n+ throw ne...
2023-09-28T09:03:32
electron/electron
eab5376c25ac8bb1234a56abbb3969f96aa8359b
d6e3360aeff6c50820a08af28f1097a0c25d6e3e
Fix typo
[ { "path": "docs/api/dialog.md", "patch": "@@ -31,7 +31,7 @@ The `dialog` module has the following methods:\n * `defaultPath` String (optional)\n * `buttonLabel` String (optional) - Custom label for the confirmation button, when\n left empty the default label will be used.\n- * `filters` [FileFilter...
2016-11-20T15:49:11
facebook/react
fd3d16d37986eef69dbaa1073b36b2e1c2bf22f1
dfd406fe4c947e6dd906b95ae1fa809ae95af203
Fix tests to silence some warnings due to autobinding
[ { "path": "src/core/__tests__/refs-test.js", "patch": "@@ -36,6 +36,9 @@ var ClickCounter = React.createClass({\n triggerReset: function() {\n this.setState({count: this.props.initialCount});\n },\n+ handleClick: function() {\n+ this.setState({count: this.state.count + 1});\n+ },\n render: fu...
2013-07-16T20:08:46
nodejs/node
4671d551cf9210434bdadf65ee5654606d24da70
aa0a01bd36101ab087f81a7e8caeca9d3ccc9beb
Revert "benchmark: add `test` and `all` options and improve errors" This reverts commit dac579516ca662e731ac502c15e75009a2b9a8c9. Refs: https://github.com/nodejs/node/pull/31396 PR-URL: https://github.com/nodejs/node/pull/31722 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Revie...
[ { "path": "benchmark/_cli.js", "patch": "@@ -6,24 +6,22 @@ const path = require('path');\n // Create an object of all benchmark scripts\n const benchmarks = {};\n fs.readdirSync(__dirname)\n- .filter((name) => {\n- return name !== 'fixtures' &&\n- fs.statSync(path.resolve(__dirname, name)).isD...
2020-02-10T19:03:46
golang/go
e822b1e26e20ef1c76672c0b77b0fd8a97a1fe84
4a2a3bca180509bc39fe99992e16b5e0a45e0e43
net/http: omit invalid header value from error message Updates #43631 Change-Id: I0fe3aafdf7ef889fed1a830128721393f8d020e6 GitHub-Last-Rev: c359542d741b17f4e2cb0d50982bf341246233b0 GitHub-Pull-Request: golang/go#48979 Reviewed-on: https://go-review.googlesource.com/c/go/+/355929 Reviewed-by: Dmitri Shuralyov <dmitshu...
[ { "path": "src/net/http/transport.go", "patch": "@@ -525,7 +525,8 @@ func (t *Transport) roundTrip(req *Request) (*Response, error) {\n \t\t\tfor _, v := range vv {\n \t\t\t\tif !httpguts.ValidHeaderFieldValue(v) {\n \t\t\t\t\treq.closeBody()\n-\t\t\t\t\treturn nil, fmt.Errorf(\"net/http: invalid header fie...
2021-10-14T22:01:49
electron/electron
61c31f8e21953c660939893910e13e16fb4858db
d6e3360aeff6c50820a08af28f1097a0c25d6e3e
:memo: zh_TW translation of tutorial/about.md [ci skip] 1. Translate tutorial/about.md 2. Fix some broken links 3. Untranslated links are keep in English
[ { "path": "docs-translations/zh-TW/tutorial/about.md", "patch": "@@ -0,0 +1,57 @@\n+# 關於 Electron\n+\n+[Electron](http://electron.atom.io) 是 GitHub 為了透過 HTML, CSS 和 JavaScript 開發跨平台桌面應用程式, 所使用的一個開放原始碼函式庫。為了達成這個目標,Electron 把 [Chromium](https://www.chromium.org/Home) 和 [Node.js](https://nodejs.org) 整合成單一的執行程式...
2016-11-20T14:01:43
facebook/react
301c571405d70ea07861591f712b561191c0e0a6
3376d279157400336d4c0f1387f48a36bf8d8c9b
Upgrade Commoner and Populist to force upgrade to graceful-fs v2.0.0. A silent upgrade from graceful-fs v1.2.2 to v1.2.3 (a dependency for both Commoner and Populist) broke the build process, even though tests were still passing. The 2.0.0 version fixes whatever was broken, though I won't pretend to know exactly what ...
[ { "path": "package.json", "patch": "@@ -36,15 +36,15 @@\n },\n \"dependencies\": {\n \"base62\": \"~0.1.1\",\n- \"commoner\": \"~0.8.3\",\n+ \"commoner\": \"~0.8.4\",\n \"esprima\": \"https://github.com/facebook/esprima/tarball/a3e0ea3979eb8d54d8bfade220c272903f928b1e\",\n \"recast\": ...
2013-07-16T19:42:17
nodejs/node
81af195b5d8ccaaaba024729e14aa520e8329740
84836df1503467e53e22bdc0723897acc5d756c4
test: add debugging output to test-net-listen-after-destroy-stdin The test failed in CI once with a timeout but there is insufficient information to further debug. Add additional debugging information. Refactored callbacks to be arrow functions, since that seems to be the direction we're moving. PR-URL: https://gith...
[ { "path": "test/parallel/test-net-listen-after-destroying-stdin.js", "patch": "@@ -8,15 +8,15 @@ const net = require('net');\n \n process.stdin.destroy();\n \n-const server = net.createServer(common.mustCall(function(socket) {\n- console.log('accepted');\n- socket.end();\n- server.close();\n+const server...
2020-02-08T16:30:41
vercel/next.js
cd70065bad00cb9d3b0e7c9a94ee9241e3c5f5d8
b689f84600a3fdf2aa8e241261b1b22ceec24579
Fixes performance problems due to TaskScopes (#55721) ### What? see https://github.com/vercel/turbo/pull/5992 ### Turobopack changes * https://github.com/vercel/turbo/pull/6009 <!-- OJ Kwon - ci(workflow): update test filter --> * https://github.com/vercel/turbo/pull/6026 <!-- Will Binns-Smith - Remove nex...
[ { "path": "Cargo.lock", "patch": "@@ -321,7 +321,7 @@ dependencies = [\n [[package]]\n name = \"auto-hash-map\"\n version = \"0.1.0\"\n-source = \"git+https://github.com/vercel/turbo.git?tag=turbopack-230922.3#ad585d32fed92986a4458fd47db2f50f1a3cba75\"\n+source = \"git+https://github.com/vercel/turbo.git?ta...
2023-09-28T07:40:21
golang/go
4a2a3bca180509bc39fe99992e16b5e0a45e0e43
9a4d5357f40c367fcad279184f245290ba0a8fb9
cmd/go, go/build: clarify build constraint docs Clarify that the //go:build line is an expression of constraints, not a constraint itself. Fixes #53308 Change-Id: Ib67243c6ee5cfe3b688c12b943b5e7496f686035 Reviewed-on: https://go-review.googlesource.com/c/go/+/411697 Reviewed-by: Rob Pike <r@golang.org> TryBot-Result...
[ { "path": "src/cmd/go/alldocs.go", "patch": "@@ -195,11 +195,10 @@\n //\t\tFor example, when building with a non-standard configuration,\n //\t\tuse -pkgdir to keep generated packages in a separate location.\n //\t-tags tag,list\n-//\t\ta comma-separated list of build tags to consider satisfied during the\n...
2022-06-10T22:58:22
facebook/react
03578e66b5d3f0a0a8d90c90f18bd8ab1e3bdc4c
71e24455a3556236d0dd8c90058d7d51770ad9d0
Fix rootElementsByReactRootID bookkeeping in ReactMount.js. It's not always possible to update `rootElementsByReactRootID` when the contents of the container are re-rendered; for instance, when we call `dangerouslyReplaceNodeWithMarkup` or `dangerouslySetInnerHTML`. Since this bookkeeping is just trying to warn about ...
[ { "path": "src/core/ReactID.js", "patch": "@@ -160,6 +160,7 @@ function purgeID(id) {\n \n exports.ATTR_NAME = ATTR_NAME;\n exports.getID = getID;\n+exports.rawGetID = internalGetID;\n exports.setID = setID;\n exports.getNode = getNode;\n exports.purgeID = purgeID;", "additions": 1, "deletions": 0, ...
2013-07-16T18:42:44
electron/electron
89e8ad49476c4806def2d84a091afb95f2019931
d6e3360aeff6c50820a08af28f1097a0c25d6e3e
Fix support for dragging urls in Mac
[ { "path": "atom/browser/ui/tray_icon_cocoa.mm", "patch": "@@ -297,7 +297,6 @@ - (void)draggingEnded:(id <NSDraggingInfo>)sender {\n \n if (NSPointInRect([sender draggingLocation], self.frame)) {\n trayIcon_->NotifyDrop();\n- [self handleDrop:sender];\n }\n }\n \n@@ -325,6 +324,7 @@ - (BOOL)prepar...
2016-11-20T05:18:24
nodejs/node
84836df1503467e53e22bdc0723897acc5d756c4
f938cbd77d487559d273a975bb43ecf8439f9146
test: improve assertion message in test-dns-any Improve error message from "The expression evaluated to a falsy value" to a message formatted dynamically that lists the record types found so that someone investigating can look at the code and determine which values are missing. This came up because the test failed in...
[ { "path": "test/internet/test-dns-any.js", "patch": "@@ -119,8 +119,8 @@ TEST(async function test_google(done) {\n function validateResult(res) {\n const types = processResult(res);\n assert.ok(\n- types.A && types.AAAA && types.MX &&\n- types.NS && types.TXT && types.SOA);\n+ types...
2020-02-08T16:14:14
golang/go
aad9382e590265efb5e5fa3591c30486dcf215e0
af725f42864c8fb56afcf3ba76d2df7d372534e4
go/doc/comment: support links in lists in comments The proposed (#51082) new go doc comment additions supports lists, links, and doc links, but does not support links and doc links inside lists, so implemnent this. Fixes #53610 Change-Id: I4fa17d204fc9efa8f3633133e4a49e56cf1aa9bc Reviewed-on: https://go-review.googl...
[ { "path": "src/go/doc/comment/parse.go", "patch": "@@ -326,6 +326,13 @@ func (p *Parser) Parse(text string) *Doc {\n \t\tswitch b := b.(type) {\n \t\tcase *Paragraph:\n \t\t\tb.Text = d.parseLinkedText(string(b.Text[0].(Plain)))\n+\t\tcase *List:\n+\t\t\tfor _, i := range b.Items {\n+\t\t\t\tfor _, c := ran...
2022-06-29T18:42:46
vercel/next.js
515f3e7e35ded9d09feb134f66035319782d2b83
e79523b5b7b8eb1083fd10329b01e7bb61b52b5a
Revert "Turbopack: add support for an asset prefix (and basePath in N… (vercel/turbo#6044) …ext.js) (vercel/turbo#6036)" This reverts commit e79523b5b7b8eb1083fd10329b01e7bb61b52b5a. It doesn't pass on next.js side
[ { "path": "crates/turbopack-build/src/chunking_context.rs", "patch": "@@ -1,4 +1,4 @@\n-use anyhow::{bail, Context, Result};\n+use anyhow::{bail, Result};\n use indexmap::IndexSet;\n use serde::{Deserialize, Serialize};\n use turbo_tasks::{\n@@ -51,11 +51,6 @@ pub struct BuildChunkingContextBuilder {\n }\n ...
2023-09-28T06:56:41
facebook/react
83a840656cecf00f299804bb538639dd2bb5f8e2
ed54fff2046fe6093078f625280725fcb19b9b33
Fix Markup Rendering in IE This fixes known browser bugs with rendering markup using `innerHTML` in IE ([[http://support.microsoft.com/kb/276228 | here is an example of one]]). This is a subset of what `HTML` (and jQuery) does, and we should eventually consider pulling it out into a separate module to reduce code dup...
[ { "path": "src/core/ReactNativeComponent.js", "patch": "@@ -69,7 +69,7 @@ function assertValidProps(props) {\n * @extends ReactMultiChild\n */\n function ReactNativeComponent(tag, omitClose) {\n- this._tagOpen = '<' + tag + ' ';\n+ this._tagOpen = '<' + tag;\n this._tagClose = omitClose ? '' : '</' + ...
2013-07-16T18:33:42
electron/electron
0aa1c3c6c3a64e6bdd03989f30bf07cda9da109e
489d8733068b9ee94f596998ae6b78143f0f86a9
Update dialog.md Fix syntax to support docs parser and MD.
[ { "path": "docs/api/dialog.md", "patch": "@@ -32,7 +32,7 @@ The `dialog` module has the following methods:\n * `buttonLabel` String (optional) - Custom label for the confirmation button, when\n left empty the default label will be used.\n * `filters` [FileFilter[]](structrs/file-filter.md) (optional...
2016-11-17T22:39:24
nodejs/node
f938cbd77d487559d273a975bb43ecf8439f9146
0ac04ecee20f00cf3daaf006496d461bb9fecbc2
src: do not unnecessarily re-assign uv handle data a555be2e45b283 re-assigned `async_.data` to indicate success or failure of the constructor. As the `HandleWrap` implementation uses that field to access the `HandleWrap` instance from the libuv handle, this introduced two issues: - It implicitly assumed that casting ...
[ { "path": "src/handle_wrap.cc", "patch": "@@ -115,6 +115,7 @@ HandleWrap::HandleWrap(Environment* env,\n \n \n void HandleWrap::OnClose(uv_handle_t* handle) {\n+ CHECK_NOT_NULL(handle->data);\n BaseObjectPtr<HandleWrap> wrap { static_cast<HandleWrap*>(handle->data) };\n wrap->Detach();\n ", "additi...
2020-02-08T15:57:02
golang/go
af725f42864c8fb56afcf3ba76d2df7d372534e4
993c387032fb569ca8fe1ff2b3c1822304c0ecca
os: fix a typo in path_windows.go I believe the path_windows.go file has a typo, which is fixed in this PR Change-Id: Ibf1a7189a6312dbb3b1e6b512beeb6d99da5b5bc GitHub-Last-Rev: cedac7eaa07d26667e6800c5ac96239d5ccf6ba8 GitHub-Pull-Request: golang/go#53629 Reviewed-on: https://go-review.googlesource.com/c/go/+/415434 A...
[ { "path": "src/os/path_windows.go", "patch": "@@ -11,7 +11,7 @@ const (\n \n // IsPathSeparator reports whether c is a directory separator character.\n func IsPathSeparator(c uint8) bool {\n-\t// NOTE: Windows accept / as path separator.\n+\t// NOTE: Windows accepts / as path separator.\n \treturn c == '\\\...
2022-06-30T15:59:30
facebook/react
46d05b1191d2035657ca3bd3dc24967b4706bd74
558e8ca312d4b2656bb894f721b8c66291aac1e3
Sync vendor modules from FB. Biggest win here is that we'll strip out the console.error from EventListener and we won't need to suggest people use a console polyfill with the minified build.
[ { "path": "src/vendor/core/$.js", "patch": "@@ -14,11 +14,16 @@\n * limitations under the License.\n *\n * @providesModule $\n+ * @typechecks\n */\n \n var ge = require('ge');\n+var ex = require('ex');\n \n /**\n+ * @param {string|DOMDocument|DOMElement|DOMTextNode} id\n+ * @return {DOMDocument|DOMEleme...
2013-07-16T04:04:43
vercel/next.js
8f3eb01193d2286d7ecfc167ff3ac2f17a57c215
293de45acfe18f0674b96fe5cbdd732d689db6c6
Update revalidatePath.mdx to fix confusing wording of arguments section. (#56099) This part of the documentation was confusing and did not match the below examples.
[ { "path": "docs/02-app/02-api-reference/04-functions/revalidatePath.mdx", "patch": "@@ -16,7 +16,7 @@ description: API Reference for the revalidatePath function.\n revalidatePath(path: string, type?: 'page' | 'layout'): void;\n ```\n \n-- `path`: A string representing the filesystem path associated with the...
2023-09-28T01:11:00
electron/electron
996ddba7159e0ea13ae48e5d2f6135ce55f0fd02
88809b0e0ba69f879ba1332520affb440fb1383b
Add rpc error for ELECTRON_BROWSER_MEMBER_GET
[ { "path": "lib/browser/rpc-server.js", "patch": "@@ -363,6 +363,11 @@ ipcMain.on('ELECTRON_BROWSER_MEMBER_SET', function (event, id, name, value) {\n ipcMain.on('ELECTRON_BROWSER_MEMBER_GET', function (event, id, name) {\n try {\n let obj = objectsRegistry.get(id)\n+\n+ if (obj == null) {\n+ t...
2016-11-17T20:23:00
nodejs/node
2b1c18f03d5531b63232346fe39bbac6adc13634
5100e84f4baaecb1c5c1e861d09f9091dc666d20
src: fix compile warnings in node_url.cc Since for all affected conversions there is a preceding type check, it’s safe to use `.FromJust()` instead. This fixes the following compile warnings: ../src/node_url.cc: In function ‘void node::url::{anonymous}::ToUSVString(const v8::FunctionCallbackInfo<v8::Value>&)’: ...
[ { "path": "src/node_url.cc", "patch": "@@ -1203,12 +1203,12 @@ url_data HarvestBase(Environment* env, Local<Object> base_obj) {\n Local<Value> flags =\n base_obj->Get(env->context(), env->flags_string()).ToLocalChecked();\n if (flags->IsInt32())\n- flags->Int32Value(context).To(&base.flags);\n+...
2020-02-07T23:01:12
rust-lang/rust
05da623016f7bfed812261f2793b4b589631a6b0
133798f9fb2887bcccf1098937540e280dd58465
Fix Ord, Eq and Hash implementation of panic::Location Faster equality compare Add tests Add missing files for tests
[ { "path": "library/core/src/panic/location.rs", "patch": "@@ -1,5 +1,7 @@\n+use crate::cmp::Ordering;\n use crate::ffi::CStr;\n use crate::fmt;\n+use crate::hash::{Hash, Hasher};\n use crate::marker::PhantomData;\n use crate::ptr::NonNull;\n \n@@ -32,7 +34,7 @@ use crate::ptr::NonNull;\n /// Files are compa...
2025-07-26T18:13:07
vercel/next.js
06705a4815e117b6b9be94588a2fcf894866b25a
341b67859da7302d115cd810485835668b47d5af
Chore/update with supabase demo deploy button (#52483) ### What? - added correct deploy button urls - uses new supabase integration - updated readme for local development, more clearer instructions - added opengraph image ### Why? - old supabase integration is buggy - readme is more clear for local deve...
[ { "path": "examples/with-supabase/README.md", "patch": "@@ -1,24 +1,91 @@\n-# Supabase Starter\n+<a href=\"https://demo-nextjs-with-supabase.vercel.app/\">\n+ <img alt=\"Next.js 13 and app template Router-ready Supabase starter kit.\" src=\"https://demo-nextjs-with-supabase.vercel.app/opengraph-image.png\"...
2023-09-28T00:36:17
nodejs/node
5100e84f4baaecb1c5c1e861d09f9091dc666d20
d0413ae8f92aa0591506ff115f21ec0ae2591e62
test: fix flaky test-fs-promises-file-handle-close Sometimes, the expected warnings were not emitted. To harden the test: - Instead of relying on a timeout that raced against the file being opened, wait until the file is opened and then schedule GC after that. - Explicitly keep the event loop alive for one turn t...
[ { "path": "test/parallel/test-fs-promises-file-handle-close.js", "patch": "@@ -27,13 +27,15 @@ async function doOpen() {\n return fh;\n }\n \n-// Perform the file open assignment within a block.\n-// When the block scope exits, the file handle will\n-// be eligible for garbage collection.\n-{\n- doOpen()...
2020-02-07T22:42:52
facebook/react
b763d7d029dd63fb32fdcb2e581712b0ef946263
2d61639f9089e58bf33b29264c6a09fdd1c91637
Use a separate grunt/config/jsx config file for tests. No longer injecting __MOCK__ as a global constant (it's just a config property now). Turns out the `grunt jsx:debug` task was never necessary for tests.
[ { "path": "Gruntfile.js", "patch": "@@ -56,7 +56,6 @@ module.exports = function(grunt) {\n grunt.registerTask('build:transformer', ['jsx:debug', 'browserify:transformer']);\n grunt.registerTask('build:min', ['jsx:release', 'browserify:min']);\n grunt.registerTask('build:test', [\n- 'jsx:debug',\n ...
2013-07-15T22:21:26
golang/go
993c387032fb569ca8fe1ff2b3c1822304c0ecca
4914e4e334b33cd823a770bd5860f525aad44c61
os: simplify deadline fluctuation tests This applies the net package CL 365334, CL 366176, CL 372215 to the os package. CL 365334: These tests were checking for fairly narrow timing windows, but were running in parallel and heavily dependent on timer and goroutine scheduling. This change eliminates unnec...
[ { "path": "src/net/timeout_test.go", "patch": "@@ -283,6 +283,7 @@ var readTimeoutTests = []struct {\n \t{50 * time.Millisecond, [2]error{nil, os.ErrDeadlineExceeded}},\n }\n \n+// There is a very similar copy of this in os/timeout_test.go.\n func TestReadTimeout(t *testing.T) {\n \thandler := func(ls *loca...
2022-06-29T20:11:33
facebook/react
c6c4657f83264525ee4f510c2417ae58a7e72a4e
f457394362d4d7514761ae2b70318024c5cbd2f6
Use populist v0.1.2 to bundle test modules instead of browserify. This will allow full support for mocking, dumpCache, and correct line numbers in error messages.
[ { "path": "Gruntfile.js", "patch": "@@ -4,6 +4,7 @@ var exec = require('child_process').exec;\n var jsxTask = require('./grunt/tasks/jsx');\n var browserifyTask = require('./grunt/tasks/browserify');\n var wrapupTask = require('./grunt/tasks/wrapup');\n+var populistTask = require('./grunt/tasks/populist');\...
2013-07-15T15:34:47
vercel/next.js
e79523b5b7b8eb1083fd10329b01e7bb61b52b5a
a86158d54162b8d4cb5f5a46990608eda68a0acb
Turbopack: add support for an asset prefix (and basePath in Next.js) (vercel/turbo#6036) This allows chunking contexts to specify an asset prefix where resources should be requested from, specifically by the client in the dom runtime backend. Test Plan: Use a `create-next-app` with corresponding Next.js PR and basePa...
[ { "path": "crates/turbopack-build/src/chunking_context.rs", "patch": "@@ -1,4 +1,4 @@\n-use anyhow::{bail, Result};\n+use anyhow::{bail, Context, Result};\n use indexmap::IndexSet;\n use serde::{Deserialize, Serialize};\n use turbo_tasks::{\n@@ -51,6 +51,11 @@ pub struct BuildChunkingContextBuilder {\n }\n ...
2023-09-27T23:16:47
nodejs/node
0649225be47647b63a029ba3b64eadc517b06d05
743c28104f3db504963409e8e91700e430131221
test: fix flaky test-trace-sigint-on-idle Previously, the test could fail on slow machines because the child process was still in the process of starting up after one second, and not yet idle. To resolve this: - Wait for a message from the child process indicating that it had started. - Wait some time after that, b...
[ { "path": "test/pseudo-tty/test-trace-sigint-on-idle.js", "patch": "@@ -1,6 +1,5 @@\n 'use strict';\n-\n-const { mustCall } = require('../common');\n+const { platformTimeout, mustCall } = require('../common');\n const childProcess = require('child_process');\n const assert = require('assert');\n \n@@ -14,9 ...
2020-02-05T14:57:47
electron/electron
aef898ad93b2e7a009c83a61171f139682707af5
c05ca68811e9913abc045eb91101af937d6aff0e
Set errno on RPC error
[ { "path": "lib/browser/rpc-server.js", "patch": "@@ -142,6 +142,7 @@ const exceptionToMeta = function (error) {\n const throwRPCError = function (message) {\n const error = new Error(message)\n error.code = 'EBADRPC'\n+ error.errno = 72\n throw error\n }\n ", "additions": 1, "deletions": 0, ...
2016-11-17T18:09:29
vercel/next.js
4cfb0acd7210ccda7a06f6e24c8e52f4fce33e6c
12c800e35cd19210a99997bc156c9af64a57cc74
Revert: "Generate prefetch RSC payload during build for SSR paths (#54403)" (#56059) Investigating problems this is causing where incorrect flight data is being generated (potentially not correctly bailing on non-static data) causing navigation issues. Reverts #54403
[ { "path": "packages/next/src/build/index.ts", "patch": "@@ -132,7 +132,6 @@ import { eventSwcPlugins } from '../telemetry/events/swc-plugins'\n import { normalizeAppPath } from '../shared/lib/router/utils/app-paths'\n import {\n ACTION,\n- NEXT_ROUTER_PREFETCH,\n RSC,\n RSC_CONTENT_TYPE_HEADER,\n R...
2023-09-27T21:38:49
rust-lang/rust
307fd41123bd9ce4ff9e4e9767f3f7771d91d789
7278554d82fa474a4e8b5c67afb009e11e41a841
tests: Test line number in debuginfo for diverging function calls
[ { "path": "tests/codegen-llvm/diverging-function-call-debuginfo.rs", "patch": "@@ -0,0 +1,38 @@\n+/// Make sure that line debuginfo is correct for diverging calls under certain\n+/// conditions. In particular we want to ensure that the line number is never\n+/// 0, but we check the absence of 0 by looking f...
2025-07-16T17:42:23
electron/electron
c05ca68811e9913abc045eb91101af937d6aff0e
1b5b29901c6588078e831625c0d5eddf5714ab4f
Throw custom error when remote object is missing from registry
[ { "path": "lib/browser/objects-registry.js", "patch": "@@ -41,7 +41,8 @@ class ObjectsRegistry {\n \n // Get an object according to its ID.\n get (id) {\n- return this.storage[id].object\n+ const pointer = this.storage[id]\n+ if (pointer != null) return pointer.object\n }\n \n // Dereferenc...
2016-11-17T17:55:13
nodejs/node
743c28104f3db504963409e8e91700e430131221
009a9c475b70d2c35a176ba20514034238024d53
test,dns: add coverage for dns exception Add test coverage for dns.promises.resolve() handling an exception from c-ares. Refs: https://coverage.nodejs.org/coverage-d213f21c72f77da6/lib/internal/dns/promises.js.html#L198 PR-URL: https://github.com/nodejs/node/pull/31678 Reviewed-By: James M Snell <jasnell@gmail.com> ...
[ { "path": "test/parallel/test-dns-resolve-promises.js", "patch": "@@ -0,0 +1,20 @@\n+// Flags: --expose-internals\n+'use strict';\n+require('../common');\n+const assert = require('assert');\n+const { internalBinding } = require('internal/test/binding');\n+const cares = internalBinding('cares_wrap');\n+const...
2020-02-07T15:54:01
vercel/next.js
72cc94013c2edb8f23b0c3655ddb6bfb8fd2468d
ad63effbc7c140de6c530e16e44bac13986cdfd1
Fix: Use `boolean` instead of `false` for experimental logging config (#56110) This PR changes the type for the config `experimental.logging.fullURL` from `false` to `boolean`, i tested it and this config can accept both true and false and will work as expected, it is just the types that are wrong.
[ { "path": "packages/next/src/server/config-shared.ts", "patch": "@@ -165,7 +165,7 @@ export interface ExperimentalConfig {\n deploymentId?: string\n logging?: {\n level?: 'verbose'\n- fullUrl?: false\n+ fullUrl?: boolean\n }\n appDocumentPreloading?: boolean\n strictNextHead?: boolean", ...
2023-09-27T20:42:53
electron/electron
489d8733068b9ee94f596998ae6b78143f0f86a9
3834f0c6a6909194184d1f2ffbe457ebfa5c3d76
Update dialog.md Fix 'properties' type in documentation (was missing `[]` notation due to lack of Markdown escaping).
[ { "path": "docs/api/dialog.md", "patch": "@@ -32,7 +32,7 @@ The `dialog` module has the following methods:\n * `buttonLabel` String (optional) - Custom label for the confirmation button, when\n left empty the default label will be used.\n * `filters` [FileFilter[]](structrs/file-filter.md) (optional...
2016-11-17T07:36:37
facebook/react
e9e89345778d9a1a0f4dcbe2f2ff2d97c0651562
2397e35cdd0cc89f84d6efbc560503fd114f227e
fix markup bugs
[ { "path": "docs/_includes/nav_docs.html", "patch": "@@ -2,8 +2,8 @@\n <div class=\"nav-docs-section\">\n <h3>Quick start</h3>\n <ul>\n- <li><a href=\"/react/docs/getting-started\"{% if page.id == 'getting-started' %} class=\"active\"{% endif %}>Getting started</a></li>\n- <li><a href=\"/...
2013-07-15T01:46:50
nodejs/node
a2d6f98e1a4b43bdd57fdfa253e3a13c6dcbe09c
17e3f3be763cb440bb315911f3e926044ddb128c
doc: fix typo Refs: https://github.com/nodejs/node/pull/31169 PR-URL: https://github.com/nodejs/node/pull/31675 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
[ { "path": "doc/api/deprecations.md", "patch": "@@ -529,7 +529,7 @@ changes:\n \n Type: End-of-Life\n \n-The `os.tmpDir()` API iws deprecated in Node.js 7.0.0 and has since been\n+The `os.tmpDir()` API was deprecated in Node.js 7.0.0 and has since been\n removed. Please use [`os.tmpdir()`][] instead.\n \n <a...
2020-02-07T15:21:55
golang/go
981d5947aff1551a1c0787664b77c4ac1e8f6c6a
84db00ffd1c0e11180fc433df1ef7521de37a49b
cmd/go: include module root in package index key The package index format includes the directory relative to the module root. The module root for a given directory can change even if the contents of the directory itself do not (by adding or removing a go.mod file in some parent directory). Thus, we need to invalidate...
[ { "path": "src/cmd/go/internal/modindex/read.go", "patch": "@@ -73,6 +73,10 @@ func moduleHash(modroot string, ismodcache bool) (cache.ActionID, error) {\n \t}\n \n \th := cache.NewHash(\"moduleIndex\")\n+\t// TODO(bcmills): Since modules in the index are checksummed, we could\n+\t// probably improve the ca...
2022-06-30T17:39:57
rust-lang/rust
91afcca7c5977fa325a683184ab196f4e2ea811e
00fd153d0d4e3e4956bdbaa8ba2c65e1d0bc1ba6
Fix rustc testsuite
[ { "path": "scripts/test_rustc_tests.sh", "patch": "@@ -62,6 +62,7 @@ rm -r tests/run-make/embed-source-dwarf # embedding sources in debuginfo\n rm -r tests/run-make/used-proc-macro # used(linker) isn't supported yet\n rm tests/ui/linking/no-gc-encapsulation-symbols.rs # same\n rm tests/ui/attributes/fn-alig...
2025-07-29T14:55:10
electron/electron
5639faf0697a8a55464eb6cbfcc6d605c09f01a2
090a5d9a619b047d165bdc388d67c05e049bfc3d
Also fix the Windows and Linux side of async openExternal
[ { "path": "atom/common/platform_util_linux.cc", "patch": "@@ -92,14 +92,7 @@ bool OpenExternal(const GURL& url, bool activate) {\n void OpenExternal(const GURL& url, bool activate,\n const OpenExternalCallback& callback) {\n // TODO(gabriel): Implement async open if callback is specified...
2016-11-17T03:13:07
facebook/react
33abe80b594f3ae85ea95815fbcd486fd085ad07
d7cf1c509b8c63b914ee69b4887eb6115893938a
scaling up fix
[ { "path": "docs/docs/refactor/04-scaling-up.md", "patch": "@@ -1,4 +1,4 @@\n-# Scaling Up: Using Multiple Components\n+# Scaling Up and Using Multiple Components\n \n So far, we've looked at how to write a single component to display data and handle user input. Next let's examine one of React's finest featu...
2013-07-15T01:00:17
vercel/next.js
c59de31a9bdb81ef422c5c5fb660ab311c036015
8372bd13e6fe5ccd231d3a30745481c845d321b1
Ensure unique name for app dir css tests (#56088) Ensures this and the other describe block in the codebase have unique names so that they're reported separately. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follo...
[ { "path": "test/e2e/app-dir/not-found/css-precedence/index.test.ts", "patch": "@@ -2,7 +2,7 @@ import { createNextDescribe } from 'e2e-utils'\n import { check } from 'next-test-utils'\n \n createNextDescribe(\n- 'app dir css',\n+ 'not-found app dir css',\n {\n files: __dirname,\n skipDeployment:...
2023-09-27T16:38:01
nodejs/node
1450ea7bf608a54640863e5ba23c6f0ce430e14f
357230f4b7174380467edfb0a65a00b65b0af66c
test: improve logged errors To indicate which lines are test lines and which from Node.js core, it's good to rely on `util.inspect()` while inspecting errors. The stack was accessed directly instead in multiple cases and logging that does not provide as much information as using `util.inspect()`. PR-URL: https://git...
[ { "path": "test/common/index.js", "patch": "@@ -139,19 +139,22 @@ if (process.env.NODE_TEST_WITH_ASYNC_HOOKS) {\n process._rawDebug();\n throw new Error(`same id added to destroy list twice (${id})`);\n }\n- destroyListList[id] = new Error().stack;\n+ destroyListList[id] = util.inspect...
2020-01-20T18:00:52
golang/go
e3cdc981c802350780a3eec109980acf28fc8746
2280d897d6e936b47565504227355ad9a509c916
[dev.unified] cmd/compile/internal/walk: fix typo in debug print We want to print `init` here. We called `ir.TakeInit(r)` earlier, so `r.Init()` always evaluates to nil at this point. Change-Id: I196fdcfbf5e63c80b7bff0cce1881c9e58302501 Reviewed-on: https://go-review.googlesource.com/c/go/+/415239 Auto-Submit: Matthe...
[ { "path": "src/cmd/compile/internal/walk/order.go", "patch": "@@ -987,7 +987,7 @@ func (o *orderState) stmt(n ir.Node) {\n \t\t\t\tdo(0, recv.X.Type().Elem())\n \t\t\t\tdo(1, types.Types[types.TBOOL])\n \t\t\t\tif len(init) != 0 {\n-\t\t\t\t\tir.DumpList(\"ninit\", r.Init())\n+\t\t\t\t\tir.DumpList(\"ninit\...
2022-06-30T00:22:15
rust-lang/rust
ab4024eb31bf341cb92e1acb1db78e6cab6c434a
d1a877aac268c6bd6cb66f8c7bc5152a080439a8
Update license exceptions for rustc-perf
[ { "path": "src/tools/tidy/src/deps.rs", "patch": "@@ -167,7 +167,7 @@ const EXCEPTIONS_RUSTC_PERF: ExceptionList = &[\n (\"brotli-decompressor\", \"BSD-3-Clause/MIT\"),\n (\"encoding_rs\", \"(Apache-2.0 OR MIT) AND BSD-3-Clause\"),\n (\"inferno\", \"CDDL-1.0\"),\n- (\"ring\", NON_STANDARD_LIC...
2025-07-29T14:41:10
facebook/react
d0c431a2a363057d9779ae12fa66d47189424e64
ab7ef4ed3b9a65b5eff2a6be0934ef3f3cab00f6
Fix comma
[ { "path": "docs/docs/refactor/02-displaying-data.md", "patch": "@@ -53,7 +53,7 @@ setInterval(function() {\n \n View the finished code in a web browser and type your name into the text field. Notice that React is only changing the time string in the UI -- any input you put in the text field remains, even th...
2013-07-15T00:15:28
electron/electron
5b260dbee3dce3b07d00a3fcf7bb262c5a6ab963
f0ca9dff810db29bffedb7536b8ab7584401912a
Fix win/linux compile (again)
[ { "path": "atom/common/platform_util_linux.cc", "patch": "@@ -93,6 +93,7 @@ void OpenExternal(const GURL& url, bool activate,\n const OpenExternalCallback& callback) {\n // TODO(gabriel): Implement async open if callback is specified\n bool opened = OpenExternal(url, activate);\n+ v8:...
2016-11-02T23:36:01
vercel/next.js
633719e8cfc99a2a7c1ad5758fb07bebce78e002
cbe8238ebd4ca337ebcf71ff90b890c2c3447a51
Skip Babel tests for Turbopack (#56091) Follow-up to #56089, skips the Babel tests. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) th...
[ { "path": "test/development/basic/next-dynamic.test.ts", "patch": "@@ -38,270 +38,298 @@ describe.each([\n basePath: string,\n testCase: 'swc' | 'babel' | 'document.getInitialProps'\n ) => {\n- let next: NextInstance\n+ ;(process.env.TURBOPACK && testCase === 'babel' ? describe.skip : descri...
2023-09-27T14:12:43
golang/go
31b8c23c5702f129aca9241bbb2132c90b1929cc
17083a2fdf4475c3f11a3e6a0ef8cb595a5fc4d6
cmd/compile: fix prove pass when upper condition is <= maxint When the terminating condition is <= X, we need to make sure that X+step doesn't overflow. Fixes #53600 Change-Id: I36e5384d05b4d7168e48db6094200fcae409bfe5 Reviewed-on: https://go-review.googlesource.com/c/go/+/415219 Reviewed-by: Than McIntosh <thanm@go...
[ { "path": "src/cmd/compile/internal/ssa/loopbce.go", "patch": "@@ -159,6 +159,13 @@ func findIndVar(f *Func) []indVar {\n \t\t\tstep = -step\n \t\t}\n \n+\t\tif flags&indVarMaxInc != 0 && max.Op == OpConst64 && max.AuxInt+step < max.AuxInt {\n+\t\t\t// For a <= comparison, we need to make sure that a value ...
2022-06-29T20:22:59
rust-lang/rust
d1a877aac268c6bd6cb66f8c7bc5152a080439a8
0b807fc1afafb52a97f596c3ba3d926aabe6a1ca
Improve tidy error on dependency license exceptions
[ { "path": "src/tools/tidy/src/deps.rs", "patch": "@@ -599,7 +599,7 @@ pub fn check(root: &Path, cargo: &Path, bless: bool, bad: &mut bool) {\n .other_options(vec![\"--locked\".to_owned()]);\n let metadata = t!(cmd.exec());\n \n- check_license_exceptions(&metadata, exceptions, bad)...
2025-07-29T14:36:48
nodejs/node
dac579516ca662e731ac502c15e75009a2b9a8c9
b70741ea438b4df01cca416949a22e9350b58258
benchmark: add `test` and `all` options and improve errors This adds a new `test` option. Using it automatically uses a single minimal option matrix to verify the benchmark works as expected. Using the new `all` option makes sure all test suites are run. On top of that the benchmarks will from now on report properly...
[ { "path": "benchmark/_cli.js", "patch": "@@ -6,22 +6,24 @@ const path = require('path');\n // Create an object of all benchmark scripts\n const benchmarks = {};\n fs.readdirSync(__dirname)\n- .filter((name) => fs.statSync(path.resolve(__dirname, name)).isDirectory())\n+ .filter((name) => {\n+ return na...
2020-01-16T14:57:30
facebook/react
204edb4a2703d6ba58c13ab0e8cd6fe160dad14b
3c742d50b6d9c996675f34a0cfc50a19d945effd
fix some links
[ { "path": "docs/docs/refactor/02-displaying-data.md", "patch": "@@ -71,8 +71,8 @@ We've found that the best solution for this problem is to generate markup direct\n \n **JSX lets you write JavaScript function calls with HTML syntax.** To generate, say, a link using pure JavaScript you'd write: `React.DOM.a(...
2013-07-15T00:00:55
electron/electron
f0ca9dff810db29bffedb7536b8ab7584401912a
9382d48708f1b7a3d09f38fe1d9bd16d7d922b99
Fix win/linux compile
[ { "path": "atom/common/platform_util_linux.cc", "patch": "@@ -95,9 +95,9 @@ void OpenExternal(const GURL& url, bool activate,\n bool opened = OpenExternal(url, activate);\n if (!opened) {\n callback.Run(v8::Exception::Error(\n- v8::String::NewFromUtf8(isolate, @\"Failed to open\")));\n+ v8...
2016-11-02T23:34:56
golang/go
6a7c64fde5407e83f12475b9a0a1e6315d246ba8
b2cc0fecc2ccd80e6d5d16542cc684f97b3a9c8a
debug/pe: add IMAGE_FILE_MACHINE_LOONGARCH{64,32} Related: https://github.com/MicrosoftDocs/win32/pull/1067 Change-Id: I946253f217a5c616ae4a19be44634000cba5020e Reviewed-on: https://go-review.googlesource.com/c/go/+/411616 Auto-Submit: Ian Lance Taylor <iant@google.com> Reviewed-by: Ian Lance Taylor <iant@google.com>...
[ { "path": "api/go1.19.txt", "patch": "@@ -126,6 +126,10 @@ pkg debug/pe, const IMAGE_COMDAT_SELECT_NODUPLICATES = 1 #51868\n pkg debug/pe, const IMAGE_COMDAT_SELECT_NODUPLICATES ideal-int #51868\n pkg debug/pe, const IMAGE_COMDAT_SELECT_SAME_SIZE = 3 #51868\n pkg debug/pe, const IMAGE_COMDAT_SELECT_SAME_SIZ...
2022-06-10T11:53:27
vercel/next.js
cbe8238ebd4ca337ebcf71ff90b890c2c3447a51
3eadfe925bb49e116f1b97d81a1d51fa0e33166d
Skip production tests for Turbopack (#56089) Follow-up to #56045. Found there was a group of tests for production called `server mode` instead of `production mode`, those are skipped too now. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possi...
[ { "path": "test/e2e/instrumentation-hook-src/instrumentation-hook-src.test.ts", "patch": "@@ -1,58 +1,65 @@\n import { createNextDescribe } from 'e2e-utils'\n import { check } from 'next-test-utils'\n-\n-createNextDescribe(\n- 'instrumentation-hook-src',\n- {\n- files: __dirname,\n- nextConfig: {\n-...
2023-09-27T13:19:42
facebook/react
eee3980749c13f8f80ed7cf839b325a2d56ffad4
cf83fbe397cd7a7a742f5661a9eda3c51416af84
Stringify `value` in ReactDOMInput / ChangeEventPlugin This fixes two bugs related to string-casting in React: # Setting `<input value={0} />` would use an empty `value` because `0` is falsey. # Using `onChange` and `setState` with non-strings could lead to an infinite loop. The latter is possible with controlled ...
[ { "path": "src/dom/components/ReactDOMInput.js", "patch": "@@ -62,7 +62,8 @@ var ReactDOMInput = ReactCompositeComponent.createClass({\n },\n \n getValue: function() {\n- return this.props.value != null ? this.props.value : this.state.value;\n+ // Cast `this.props.value` to a string so equality ch...
2013-07-12T22:40:18
nodejs/node
b862a0c6d69bac6e7deaf7c53802a5d3bc05099e
93c4c1a273736027439d087b0a52aa33df6a2b13
benchmark: check for and fix multiple end() PR-URL: https://github.com/nodejs/node/pull/31624 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
[ { "path": "benchmark/common.js", "patch": "@@ -33,6 +33,7 @@ function Benchmark(fn, configs, options) {\n this._time = [0, 0];\n // Used to make sure a benchmark only start a timer once\n this._started = false;\n+ this._ended = false;\n \n // this._run will use fork() to create a new process for ea...
2020-02-03T21:18:29
electron/electron
31123f908da20405c45dacf708e89fa6a669b9fb
99a5258999cabb2c8e65306d05c3355b43b9f644
Fix ternary
[ { "path": "atom/common/platform_util_mac.mm", "patch": "@@ -202,8 +202,7 @@ bool OpenExternal(const GURL& url, bool activate) {\n if (!ns_url) {\n return false;\n }\n- NSError *error = OpenURL(ns_url, activate);\n- return error ? false : true;\n+ return !OpenURL(ns_url, activate);\n }\n \n void O...
2016-11-02T23:22:20
golang/go
b2cc0fecc2ccd80e6d5d16542cc684f97b3a9c8a
64ef16e77795957d47e3889bca9483d6f3099bbf
net/http: preserve nil values in Header.Clone ReverseProxy makes a distinction between nil and zero-length header values. Avoid losing nil-ness when cloning a request. Thanks to Christian Mehlmauer for discovering this. Fixes #53423 Fixes CVE-2022-32148 Change-Id: Ice369cdb4712e2d62e25bb881b080847aa4801f5 Reviewed-...
[ { "path": "src/net/http/header.go", "patch": "@@ -103,6 +103,12 @@ func (h Header) Clone() Header {\n \tsv := make([]string, nv) // shared backing array for headers' values\n \th2 := make(Header, len(h))\n \tfor k, vv := range h {\n+\t\tif vv == nil {\n+\t\t\t// Preserve nil values. ReverseProxy distinguish...
2022-06-17T17:09:45
facebook/react
92dab0759c7479f075bbe998cc21ddb3af51f15b
5c6e59f53cd95dc00fd73908d89b5afe083fa90b
More autobind warnings and invariants This adds two new warnings and one new invariant: - Warn when using React.autoBind() that it is deprecated. - Throw when calling bind() on an autobound method with the wrong value of "this". Today we'll silently ignore the provided value, which is confusing. - Warn when calling b...
[ { "path": "src/core/ReactCompositeComponent.js", "patch": "@@ -809,11 +809,34 @@ var ReactCompositeComponentMixin = {\n */\n _bindAutoBindMethod: function(method) {\n var component = this;\n- return function() {\n+ var boundMethod = function() {\n return method.apply(component, argument...
2013-07-10T21:44:38
nodejs/node
d016b9d70897b7702e7862252d768ecdde89bc48
e559842188f541b884abff2ffad4d2d3e1b841a6
stream: finished callback for closed streams Previously finished(stream, cb) would not invoke the callback for streams that have already finished, ended or errored before being passed to finished(stream, cb). PR-URL: https://github.com/nodejs/node/pull/31509 Refs: https://github.com/nodejs/node/pull/31508 Reviewed-By...
[ { "path": "lib/_stream_readable.js", "patch": "@@ -148,6 +148,9 @@ function ReadableState(options, stream, isDuplex) {\n // Indicates whether the stream has errored.\n this.errored = false;\n \n+ // Indicates whether the stream has finished destroying.\n+ this.closed = false;\n+\n // Crypto is kind ...
2020-01-25T14:35:38
electron/electron
99a5258999cabb2c8e65306d05c3355b43b9f644
5e8059e0fae4138a823773a8a032c27cae772102
Callback uses (platform specific) error, with message
[ { "path": "atom/common/api/atom_api_shell.cc", "patch": "@@ -62,7 +62,8 @@ bool OpenExternal(\n platform_util::OpenExternalCallback callback;\n if (mate::Converter<platform_util::OpenExternalCallback>::FromV8(\n args->isolate(), peek, &callback)) {\n- return platform_util::OpenExternal(ur...
2016-11-02T23:20:26
golang/go
64ef16e77795957d47e3889bca9483d6f3099bbf
0750107074c39f7b846515de47c2857cbdb7e3d6
cmd/internal/obj/arm64: save LR and SP in one instruction for small frames When we create a thread with signals blocked. But glibc's pthread_sigmask doesn't really allow us to block SIGSETXID. So we may get a signal early on before the signal stack is set. If we get a signal on the current stack, it will clobber anyth...
[ { "path": "misc/cgo/test/cgo_linux_test.go", "patch": "@@ -15,6 +15,14 @@ func TestSetgid(t *testing.T) {\n \t}\n \ttestSetgid(t)\n }\n+\n+func TestSetgidStress(t *testing.T) {\n+\tif runtime.GOOS == \"android\" {\n+\t\tt.Skip(\"unsupported on Android\")\n+\t}\n+\ttestSetgidStress(t)\n+}\n+\n func Test1435(...
2022-06-15T19:09:24
vercel/next.js
3eadfe925bb49e116f1b97d81a1d51fa0e33166d
f2ad08e2c8a84c7480b461148ee04ab4d4a771d9
Skip experimental.nextScriptWorkers test for Turbopack (#56086) This option is not supported in Turbopack yet but it is not a priority as it's experimental. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the ...
[ { "path": "test/e2e/next-script/index.test.ts", "patch": "@@ -125,14 +125,16 @@ describe('beforeInteractive in document body', () => {\n }\n })\n })\n-\n-describe('experimental.nextScriptWorkers: false with no Partytown dependency', () => {\n- let next: NextInstance\n-\n- beforeAll(async () => {\n- ...
2023-09-27T11:58:11
facebook/react
067fe27699cf3754cdf4aaf067ff67fa4fdf04c5
8db2ba9130d8e1034ad60fb3cf429ecf02ce1df9
Fix Clowny Validation Code ಠ_ಠ
[ { "path": "src/core/ReactCompositeComponent.js", "patch": "@@ -582,7 +582,7 @@ var ReactCompositeComponentMixin = {\n * @protected\n */\n replaceState: function(completeState, callback) {\n- validateLifeCycleOnReplaceState.call(null, this);\n+ validateLifeCycleOnReplaceState(this);\n this....
2013-07-10T21:44:26
nodejs/node
e559842188f541b884abff2ffad4d2d3e1b841a6
9c753b3dc2b465496a94d7ccffc3c9438c3ce325
stream: make readable & writable computed This makes readable and writable automatically computed based on the stream state. Effectivly deprecating/discouraging manual management of this. Makes the properties more consistent and easier to reason about. Fixes: https://github.com/nodejs/node/issues/29377 PR-URL: ht...
[ { "path": "doc/api/stream.md", "patch": "@@ -495,7 +495,8 @@ added: v11.4.0\n \n * {boolean}\n \n-Is `true` if it is safe to call [`writable.write()`][stream-write].\n+Is `true` if it is safe to call [`writable.write()`][stream-write], which means\n+the stream has not been destroyed, errored or ended.\n \n ...
2020-01-05T17:41:31