url
string | repository_url
string | labels_url
string | comments_url
string | events_url
string | html_url
string | id
int64 | node_id
string | number
int64 | title
string | user
dict | labels
list | state
string | locked
bool | assignee
dict | assignees
list | milestone
null | comments
int64 | created_at
timestamp[s] | updated_at
timestamp[s] | closed_at
timestamp[s] | author_association
string | type
dict | active_lock_reason
string | draft
bool | pull_request
dict | body
string | closed_by
dict | reactions
dict | timeline_url
string | performed_via_github_app
null | state_reason
string | sub_issues_summary
dict | is_pull_request
bool |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/facebook/react-native/issues/49009
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/49009/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/49009/comments
|
https://api.github.com/repos/facebook/react-native/issues/49009/events
|
https://github.com/facebook/react-native/pull/49009
| 2,816,193,597
|
PR_kwDOAbrxp86JQTVy
| 49,009
|
Abstract away use of shadow nodes as native node references
|
{
"login": "rubennorte",
"id": 117921,
"node_id": "MDQ6VXNlcjExNzkyMQ==",
"avatar_url": "https://avatars.githubusercontent.com/u/117921?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rubennorte",
"html_url": "https://github.com/rubennorte",
"followers_url": "https://api.github.com/users/rubennorte/followers",
"following_url": "https://api.github.com/users/rubennorte/following{/other_user}",
"gists_url": "https://api.github.com/users/rubennorte/gists{/gist_id}",
"starred_url": "https://api.github.com/users/rubennorte/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rubennorte/subscriptions",
"organizations_url": "https://api.github.com/users/rubennorte/orgs",
"repos_url": "https://api.github.com/users/rubennorte/repos",
"events_url": "https://api.github.com/users/rubennorte/events{/privacy}",
"received_events_url": "https://api.github.com/users/rubennorte/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 3
| 2025-01-28T16:34:37
| 2025-01-29T17:44:56
| 2025-01-29T17:43:44
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/49009",
"html_url": "https://github.com/facebook/react-native/pull/49009",
"diff_url": "https://github.com/facebook/react-native/pull/49009.diff",
"patch_url": "https://github.com/facebook/react-native/pull/49009.patch",
"merged_at": null
}
|
Summary:
Changelog: [internal]
Native APIs so far have returned instance handles from React to reference nodes in the rendered UI tree, but now that we're adding support for the document API, this isn't sufficient to represent all types of nodes. Both for the document and for its `documentElement`, we don't have an instance handle from React that links to the node, but we're going to represent that differently.
This is a refactor so the existing methods use a mostly opaque `NativeNodeReference` type so we can implement it as a union of React instance handles and the future types we're going to introduce to support document.
Differential Revision: D67704855
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/49009/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/49009/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/49008
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/49008/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/49008/comments
|
https://api.github.com/repos/facebook/react-native/issues/49008/events
|
https://github.com/facebook/react-native/pull/49008
| 2,816,192,617
|
PR_kwDOAbrxp86JQTH5
| 49,008
|
Add basic benchmarks for rendering views
|
{
"login": "rubennorte",
"id": 117921,
"node_id": "MDQ6VXNlcjExNzkyMQ==",
"avatar_url": "https://avatars.githubusercontent.com/u/117921?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rubennorte",
"html_url": "https://github.com/rubennorte",
"followers_url": "https://api.github.com/users/rubennorte/followers",
"following_url": "https://api.github.com/users/rubennorte/following{/other_user}",
"gists_url": "https://api.github.com/users/rubennorte/gists{/gist_id}",
"starred_url": "https://api.github.com/users/rubennorte/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rubennorte/subscriptions",
"organizations_url": "https://api.github.com/users/rubennorte/orgs",
"repos_url": "https://api.github.com/users/rubennorte/repos",
"events_url": "https://api.github.com/users/rubennorte/events{/privacy}",
"received_events_url": "https://api.github.com/users/rubennorte/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 5
| 2025-01-28T16:34:11
| 2025-01-29T17:44:16
| 2025-01-29T17:43:43
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/49008",
"html_url": "https://github.com/facebook/react-native/pull/49008",
"diff_url": "https://github.com/facebook/react-native/pull/49008.diff",
"patch_url": "https://github.com/facebook/react-native/pull/49008.patch",
"merged_at": null
}
|
Summary:
Changelog: [internal]
We're modifying some core APIs in the RN render in following diffs, so this adds a simple benchmark as a safety mechanism to verify those don't regress performance significantly.
Differential Revision: D68772175
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/49008/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/49008/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/49007
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/49007/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/49007/comments
|
https://api.github.com/repos/facebook/react-native/issues/49007/events
|
https://github.com/facebook/react-native/pull/49007
| 2,816,180,226
|
PR_kwDOAbrxp86JQQX9
| 49,007
|
Explicitly check that Debugger domain is disabled before starting Tracing
|
{
"login": "hoxyq",
"id": 28902667,
"node_id": "MDQ6VXNlcjI4OTAyNjY3",
"avatar_url": "https://avatars.githubusercontent.com/u/28902667?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hoxyq",
"html_url": "https://github.com/hoxyq",
"followers_url": "https://api.github.com/users/hoxyq/followers",
"following_url": "https://api.github.com/users/hoxyq/following{/other_user}",
"gists_url": "https://api.github.com/users/hoxyq/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hoxyq/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hoxyq/subscriptions",
"organizations_url": "https://api.github.com/users/hoxyq/orgs",
"repos_url": "https://api.github.com/users/hoxyq/repos",
"events_url": "https://api.github.com/users/hoxyq/events{/privacy}",
"received_events_url": "https://api.github.com/users/hoxyq/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 2
| 2025-01-28T16:29:48
| 2025-01-29T12:04:54
| 2025-01-29T12:04:43
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/49007",
"html_url": "https://github.com/facebook/react-native/pull/49007",
"diff_url": "https://github.com/facebook/react-native/pull/49007.diff",
"patch_url": "https://github.com/facebook/react-native/pull/49007.patch",
"merged_at": null
}
|
Summary:
# Changelog: [Internal]
Before sending `Tracing.start`, CDT will also send `Debugger.disable`.
You don't want to hit your breakpoints when you are profiling an appplication, this is by design.
We won't just delegate this to Hermes to handle. We will explicitly check that this condition is satisfied on React Native side. This is done to avoid regression in case the implementation details will change on CDT side.
Later in D68414421, we will also check that samples JavaScript stack don't contain debugger frames. This is necessary to distinguish garbage collector frames from debugger frames, which share the same type in Hermes VM - "Suspend".
We need garbage collector frames. If debugger frame was found we would throw an error, because this is unexpected after Debugger domain was disabled.
Right now Hermes is not disabling local VM Debugger on `Debugger.disable` method - this is a known bug, which I am addressing in a stack from D68772900.
Differential Revision: D68776863
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/49007/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/49007/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/49006
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/49006/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/49006/comments
|
https://api.github.com/repos/facebook/react-native/issues/49006/events
|
https://github.com/facebook/react-native/pull/49006
| 2,816,054,710
|
PR_kwDOAbrxp86JP0ih
| 49,006
|
Add flow definitions for Alert and align them with TypeScript
|
{
"login": "j-piasecki",
"id": 21055725,
"node_id": "MDQ6VXNlcjIxMDU1NzI1",
"avatar_url": "https://avatars.githubusercontent.com/u/21055725?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/j-piasecki",
"html_url": "https://github.com/j-piasecki",
"followers_url": "https://api.github.com/users/j-piasecki/followers",
"following_url": "https://api.github.com/users/j-piasecki/following{/other_user}",
"gists_url": "https://api.github.com/users/j-piasecki/gists{/gist_id}",
"starred_url": "https://api.github.com/users/j-piasecki/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/j-piasecki/subscriptions",
"organizations_url": "https://api.github.com/users/j-piasecki/orgs",
"repos_url": "https://api.github.com/users/j-piasecki/repos",
"events_url": "https://api.github.com/users/j-piasecki/events{/privacy}",
"received_events_url": "https://api.github.com/users/j-piasecki/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1282006477,
"node_id": "MDU6TGFiZWwxMjgyMDA2NDc3",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Software%20Mansion",
"name": "p: Software Mansion",
"color": "0052cc",
"default": false,
"description": "Partner: Software Mansion"
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 7
| 2025-01-28T15:41:29
| 2025-01-29T13:57:23
| 2025-01-29T13:41:39
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/49006",
"html_url": "https://github.com/facebook/react-native/pull/49006",
"diff_url": "https://github.com/facebook/react-native/pull/49006.diff",
"patch_url": "https://github.com/facebook/react-native/pull/49006.patch",
"merged_at": null
}
|
Summary:
Changelog: [Internal]
Add flow definitions file for Alert and align it with TypeScript definitions.
Differential Revision: D68774525
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/49006/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/49006/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/49005
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/49005/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/49005/comments
|
https://api.github.com/repos/facebook/react-native/issues/49005/events
|
https://github.com/facebook/react-native/pull/49005
| 2,815,945,370
|
PR_kwDOAbrxp86JPcTr
| 49,005
|
Remove unused FallbackJSBundleLoader
|
{
"login": "cortinico",
"id": 3001957,
"node_id": "MDQ6VXNlcjMwMDE5NTc=",
"avatar_url": "https://avatars.githubusercontent.com/u/3001957?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cortinico",
"html_url": "https://github.com/cortinico",
"followers_url": "https://api.github.com/users/cortinico/followers",
"following_url": "https://api.github.com/users/cortinico/following{/other_user}",
"gists_url": "https://api.github.com/users/cortinico/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cortinico/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cortinico/subscriptions",
"organizations_url": "https://api.github.com/users/cortinico/orgs",
"repos_url": "https://api.github.com/users/cortinico/repos",
"events_url": "https://api.github.com/users/cortinico/events{/privacy}",
"received_events_url": "https://api.github.com/users/cortinico/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 3
| 2025-01-28T15:02:33
| 2025-01-29T11:55:56
| 2025-01-29T11:55:44
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/49005",
"html_url": "https://github.com/facebook/react-native/pull/49005",
"diff_url": "https://github.com/facebook/react-native/pull/49005.diff",
"patch_url": "https://github.com/facebook/react-native/pull/49005.patch",
"merged_at": null
}
|
Summary:
This is essentially dead code. Not used at all but publicly exposed.
I found no meaningful usages in OSS so this is safe to remove:
https://github.com/search?type=code&q=NOT+is%3Afork+NOT+org%3Afacebook+NOT+repo%3Areact-native-tvos%2Freact-native-tvos+NOT+repo%3Anuagoz%2Freact-native+NOT+repo%3A2lambda123%2Freact-native+NOT+repo%3Apvinis%2Freact-native---investigation+NOT+repo%3Abeanchips%2Ffacebookreactnative+NOT+repo%3AfabOnReact%2Freact-native-notes+NOT+user%3Ahuntie+com.facebook.react.bridge.FallbackJSBundleLoader
Changelog:
[Internal] [Changed] -
Differential Revision: D68773273
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/49005/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/49005/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/49004
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/49004/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/49004/comments
|
https://api.github.com/repos/facebook/react-native/issues/49004/events
|
https://github.com/facebook/react-native/pull/49004
| 2,815,912,354
|
PR_kwDOAbrxp86JPVBW
| 49,004
|
Convert CxxCallbackImpl to Kotlin
|
{
"login": "cortinico",
"id": 3001957,
"node_id": "MDQ6VXNlcjMwMDE5NTc=",
"avatar_url": "https://avatars.githubusercontent.com/u/3001957?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cortinico",
"html_url": "https://github.com/cortinico",
"followers_url": "https://api.github.com/users/cortinico/followers",
"following_url": "https://api.github.com/users/cortinico/following{/other_user}",
"gists_url": "https://api.github.com/users/cortinico/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cortinico/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cortinico/subscriptions",
"organizations_url": "https://api.github.com/users/cortinico/orgs",
"repos_url": "https://api.github.com/users/cortinico/repos",
"events_url": "https://api.github.com/users/cortinico/events{/privacy}",
"received_events_url": "https://api.github.com/users/cortinico/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 3
| 2025-01-28T14:51:27
| 2025-01-28T19:06:30
| 2025-01-28T19:06:21
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/49004",
"html_url": "https://github.com/facebook/react-native/pull/49004",
"diff_url": "https://github.com/facebook/react-native/pull/49004.diff",
"patch_url": "https://github.com/facebook/react-native/pull/49004.patch",
"merged_at": null
}
|
Summary:
This just converts yet another class to Kotlin.
Changelog:
[Internal] [Changed] -
Differential Revision: D68772336
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/49004/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/49004/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/49003
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/49003/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/49003/comments
|
https://api.github.com/repos/facebook/react-native/issues/49003/events
|
https://github.com/facebook/react-native/pull/49003
| 2,815,815,725
|
PR_kwDOAbrxp86JO_mx
| 49,003
|
Throw an error when calling root.render outside of a task
|
{
"login": "rubennorte",
"id": 117921,
"node_id": "MDQ6VXNlcjExNzkyMQ==",
"avatar_url": "https://avatars.githubusercontent.com/u/117921?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rubennorte",
"html_url": "https://github.com/rubennorte",
"followers_url": "https://api.github.com/users/rubennorte/followers",
"following_url": "https://api.github.com/users/rubennorte/following{/other_user}",
"gists_url": "https://api.github.com/users/rubennorte/gists{/gist_id}",
"starred_url": "https://api.github.com/users/rubennorte/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rubennorte/subscriptions",
"organizations_url": "https://api.github.com/users/rubennorte/orgs",
"repos_url": "https://api.github.com/users/rubennorte/repos",
"events_url": "https://api.github.com/users/rubennorte/events{/privacy}",
"received_events_url": "https://api.github.com/users/rubennorte/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 2
| 2025-01-28T14:18:51
| 2025-01-28T15:30:38
| 2025-01-28T15:30:25
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/49003",
"html_url": "https://github.com/facebook/react-native/pull/49003",
"diff_url": "https://github.com/facebook/react-native/pull/49003.diff",
"patch_url": "https://github.com/facebook/react-native/pull/49003.patch",
"merged_at": null
}
|
Summary:
Changelog: [internal]
I was adding a benchmark for rendering thousands of views and it was surprisingly fast, until I realized I wasn't wrapping the call to `root.render` in `runTask`, which means the benchmark wasn't really doing the rendering, only scheduling a microtask that was never executed.
This is a safety mechanism to prevent those mistakes.
Differential Revision: D68771170
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/49003/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/49003/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/49002
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/49002/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/49002/comments
|
https://api.github.com/repos/facebook/react-native/issues/49002/events
|
https://github.com/facebook/react-native/issues/49002
| 2,815,640,059
|
I_kwDOAbrxp86n00H7
| 49,002
|
side bar is not sticking in rtl on fixed position while working fine in English.
|
{
"login": "sheharyarusol",
"id": 183493051,
"node_id": "U_kgDOCu_huw",
"avatar_url": "https://avatars.githubusercontent.com/u/183493051?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sheharyarusol",
"html_url": "https://github.com/sheharyarusol",
"followers_url": "https://api.github.com/users/sheharyarusol/followers",
"following_url": "https://api.github.com/users/sheharyarusol/following{/other_user}",
"gists_url": "https://api.github.com/users/sheharyarusol/gists{/gist_id}",
"starred_url": "https://api.github.com/users/sheharyarusol/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sheharyarusol/subscriptions",
"organizations_url": "https://api.github.com/users/sheharyarusol/orgs",
"repos_url": "https://api.github.com/users/sheharyarusol/repos",
"events_url": "https://api.github.com/users/sheharyarusol/events{/privacy}",
"received_events_url": "https://api.github.com/users/sheharyarusol/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 1794376073,
"node_id": "MDU6TGFiZWwxNzk0Mzc2MDcz",
"url": "https://api.github.com/repos/facebook/react-native/labels/Needs:%20Repro",
"name": "Needs: Repro",
"color": "d4c5f9",
"default": false,
"description": "This issue could be improved with a clear list of steps to reproduce the issue."
},
{
"id": 1794380150,
"node_id": "MDU6TGFiZWwxNzk0MzgwMTUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/Newer%20Patch%20Available",
"name": "Newer Patch Available",
"color": "d4c5f9",
"default": false,
"description": ""
},
{
"id": 1877909121,
"node_id": "MDU6TGFiZWwxODc3OTA5MTIx",
"url": "https://api.github.com/repos/facebook/react-native/labels/Needs:%20Attention",
"name": "Needs: Attention",
"color": "f9c884",
"default": false,
"description": "Issues where the author has responded to feedback."
}
] |
open
| false
| null |
[] | null | 8
| 2025-01-28T13:13:44
| 2025-01-29T13:15:07
| null |
NONE
| null | null | null | null |
### Description
import React, { useState, useRef, useEffect } from 'react';
import PropTypes from 'prop-types';
import { Animated, Dimensions, Text, View, StyleSheet } from 'react-native';
import get from 'lodash.get';
import {I18nManager} from 'react-native'
// import { getFormattedCurrency } from '~/utils/units'
const ComparisonTableRow = (props) => {
const {
data = [],
comparing,
getBestBy,
fixed,
cellTextAlign,
headerCellContent,
headerCellStyle,
cellContent,
cellStyle,
rowStyle,
bestCellStyle,
bestCellTextStyle,
mergeCells,
isHighlightBest,
headerCellWidth,
cellWidth,
innerScrollX,
scrollY
} = props;
let bestValueIndices = [];
// Only sort them if user provide getBestBy order string/comparison function to sort the values
if (comparing && getBestBy) {
const valuesOriginal =
typeof comparing === 'function'
? comparing(data)
: data.map((item) => getComparingValue(item, comparing));
const valuesSorted = getSortedValues(valuesOriginal, getBestBy);
// if bestValueIndices is -1, either there is no best or getBestBy is null
bestValueIndices = getBestValueIndices(valuesOriginal, valuesSorted);
}
const isAllValuesEqual = bestValueIndices.length === data.length;
const mergedBestCellStyle = {
...styles.bestCell,
...bestCellStyle
};
const mergedBestCellTextStyle = {
...styles.bestCellText,
...bestCellTextStyle
};
function getComparingValue(item, comparing) {
return get(item, comparing);
}
function getSortedValues(valuesOriginal, getBestBy) {
let valuesSorted = [...valuesOriginal];
if (typeof getBestBy === 'function') {
valuesSorted.sort(getBestBy);
} else if (getBestBy === 'asc') {
valuesSorted.sort((a, b) => a - b);
} else if (getBestBy === 'desc') {
valuesSorted.sort((a, b) => b - a);
}
return valuesSorted;
}
function getBestValueIndices(valuesOriginal, valuesSorted) {
const [bestValue] = valuesSorted;
let bestValueIndices = [];
if (bestValue !== undefined) {
valuesOriginal.forEach((value, i) => {
if (value === bestValue) {
bestValueIndices.push(i);
}
});
} else {
bestValueIndices = [-1];
}
return bestValueIndices;
}
function renderHeaderCellContent() {
return (
<Animated.View
style={[
styles.headerCell,
{ width: headerCellWidth },
headerCellStyle,
innerScrollX && {
transform: [
{
translateX: innerScrollX.interpolate({
inputRange: [0, I18nManager.isRTL ? 10: 3000],
outputRange: [0, I18nManager.isRTL ? 10: 3000],
extrapolate: 'clamp'
})
}
]
}
]}
>
{/* {typeof headerCellContent === 'function' ? (
headerCellContent()
) : ( */}
<Text style={styles.headerCellText}>{headerCellContent}</Text>
{/* )} */}
</Animated.View>
);
}
function renderTemplateCellContent(cellContent, item) {
const comparingValue = getComparingValue(item, comparing);
if (comparing && !comparingValue) {
return '-';
}
return comparingValue;
}
function renderCustomCellContent(
cellContent,
index,
item,
isBest,
mergedBestCellTextStyle
) {
let customCellContent = cellContent({
item,
index,
isBest,
cellTextStyle: styles.cellText,
bestCellTextStyle: mergedBestCellTextStyle
});
if (React.isValidElement(customCellContent)) {
return customCellContent;
}
return (
<Text
style={[
styles.cellText,
cellTextAlign && { textAlign: cellTextAlign },
isBest && mergedBestCellTextStyle
]}
>
{renderTemplateCellContent(customCellContent, item)}
</Text>
);
}
return (
<Animated.View
style={[
styles.row,
rowStyle,
fixed &&
scrollY && {
...styles.fixedRow,
transform: [
{
translateY: scrollY.interpolate({
inputRange: [0, 10000],
outputRange: [0, 10000],
extrapolate: 'clamp'
})
}
]
}
]}
>
{headerCellContent !== undefined && renderHeaderCellContent()}
{mergeCells ? (
<Animated.View
style={[
styles.mergedCell,
{ width: Dimensions.get('window').width - headerCellWidth },
cellStyle,
innerScrollX && {
transform: [
{
translateX: innerScrollX.interpolate({
inputRange: [0, 1000],
outputRange: [0, 1000],
extrapolate: 'clamp'
})
}
]
}
]}
>
{cellContent && typeof cellContent === 'function'
? cellContent({ data })
: null}
</Animated.View>
) : (
data.map((item, index) => {
const isBest =
bestValueIndices.includes(index) &&
isHighlightBest &&
!isAllValuesEqual;
return (
<View
style={[
styles.cell,
cellStyle,
{ width: cellWidth },
isBest && mergedBestCellStyle
]}
key={index}
>
{typeof cellContent === 'function' ? (
renderCustomCellContent(
cellContent,
index,
item,
isBest,
mergedBestCellTextStyle
)
) : (
<Text
style={[
styles.cellText,
cellTextAlign && { textAlign: cellTextAlign },
isBest && mergedBestCellTextStyle
]}
>
{renderTemplateCellContent(cellContent, item)}
</Text>
)}
</View>
);
})
)}
</Animated.View>
);
};
const styles = StyleSheet.create({
row: {
borderTopWidth: 1,
borderColor: '#E5E5E5',
flexDirection: 'row'
},
fixedRow: {
position: 'relative',
zIndex: 100
},
headerCell: {
position: 'relative',
zIndex: 10,
backgroundColor: '#F9F9FB',
paddingVertical: 11,
paddingHorizontal: 12,
borderRightWidth: 1,
borderColor: '#E5E5E5'
},
cell: {
backgroundColor: '#FFF',
paddingVertical: 10,
paddingHorizontal: 14,
borderRightWidth: 1,
borderColor: '#E5E5E5'
},
mergedCell: {
justifyContent: 'center',
paddingVertical: 10,
paddingHorizontal: 12
},
headerCellText: {
fontSize: 20
},
cellText: {
fontSize: 20
},
bestCell: {
backgroundColor: 'rgba(255,236,170,0.2)'
},
bestCellText: {
color: '#F6571A',
fontWeight: 'bold'
}
});
ComparisonTableRow.propTypes = {
data: PropTypes.array,
comparing: PropTypes.oneOfType([PropTypes.string, PropTypes.func]),
getBestBy: PropTypes.oneOfType([
PropTypes.oneOf(['asc', 'desc']),
PropTypes.func
]),
headerCellContent: PropTypes.oneOfType([PropTypes.string, PropTypes.func]),
headerCellStyle: PropTypes.object,
cellContent: PropTypes.oneOfType([PropTypes.string, PropTypes.func]),
cellStyle: PropTypes.object,
rowStyle: PropTypes.object,
bestCellStyle: PropTypes.object,
bestCellTextStyle: PropTypes.object,
isHighlightBest: PropTypes.bool,
innerScrollX: PropTypes.object
};
ComparisonTableRow.defaultProps = {};
export default ComparisonTableRow;
code responsible for this:
<Animated.View
style={[
styles.headerCell,
{ width: headerCellWidth },
headerCellStyle,
innerScrollX && {
transform: [
{
translateX: innerScrollX.interpolate({
inputRange: [0, I18nManager.isRTL ? 10: 3000],
outputRange: [0, I18nManager.isRTL ? 10: 3000],
extrapolate: 'clamp'
})
}
]
}
]}
>
<Text style={styles.headerCellText}>{headerCellContent}</Text>
</Animated.View>
### Steps to reproduce
unable to reproduce
### React Native Version
0.76.5
### Affected Platforms
Runtime - Android, Runtime - iOS
### Output of `npx react-native info`
```text
System:
OS: macOS 14.6.1
CPU: (8) x64 Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz
Memory: 56.37 MB / 16.00 GB
Shell:
version: "5.9"
path: /bin/zsh
Binaries:
Node:
version: 22.12.0
path: ~/.nvm/versions/node/v22.12.0/bin/node
Yarn:
version: 1.22.22
path: /usr/local/bin/yarn
npm:
version: 10.9.0
path: ~/.nvm/versions/node/v22.12.0/bin/npm
Watchman:
version: 2024.12.02.00
path: /usr/local/bin/watchman
Managers:
CocoaPods:
version: 1.16.2
path: /usr/local/lib/ruby/gems/3.3.0/bin/pod
SDKs:
iOS SDK:
Platforms:
- DriverKit 24.2
- iOS 18.2
- macOS 15.2
- tvOS 18.2
- visionOS 2.2
- watchOS 11.2
Android SDK: Not Found
IDEs:
Android Studio: 2024.2 AI-242.23339.11.2421.12700392
Xcode:
version: 16.2/16C5032a
path: /usr/bin/xcodebuild
Languages:
Java:
version: 17.0.13
path: /usr/bin/javac
Ruby:
version: 3.3.6
path: /usr/local/opt/ruby/bin/ruby
npmPackages:
"@react-native-community/cli":
installed: 15.0.1
wanted: 15.0.1
react:
installed: 18.3.1
wanted: 18.3.1
react-native:
installed: 0.76.5
wanted: 0.76.5
react-native-macos: Not Found
npmGlobalPackages:
"*react-native*": Not Found
Android:
hermesEnabled: true
newArchEnabled: false
iOS:
hermesEnabled: true
newArchEnabled: false
```
### Stacktrace or Logs
```text
no lots
```
### Reproducer
no reproducer
### Screenshots and Videos
_No response_
| null |
{
"url": "https://api.github.com/repos/facebook/react-native/issues/49002/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/49002/timeline
| null | null |
{
"total": 0,
"completed": 0,
"percent_completed": 0
}
| false
|
https://api.github.com/repos/facebook/react-native/issues/49001
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/49001/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/49001/comments
|
https://api.github.com/repos/facebook/react-native/issues/49001/events
|
https://github.com/facebook/react-native/pull/49001
| 2,815,541,100
|
PR_kwDOAbrxp86JOCkW
| 49,001
|
don't inline sourceMapURL in Debugger.scriptParsed
|
{
"login": "vzaidman",
"id": 5188459,
"node_id": "MDQ6VXNlcjUxODg0NTk=",
"avatar_url": "https://avatars.githubusercontent.com/u/5188459?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/vzaidman",
"html_url": "https://github.com/vzaidman",
"followers_url": "https://api.github.com/users/vzaidman/followers",
"following_url": "https://api.github.com/users/vzaidman/following{/other_user}",
"gists_url": "https://api.github.com/users/vzaidman/gists{/gist_id}",
"starred_url": "https://api.github.com/users/vzaidman/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vzaidman/subscriptions",
"organizations_url": "https://api.github.com/users/vzaidman/orgs",
"repos_url": "https://api.github.com/users/vzaidman/repos",
"events_url": "https://api.github.com/users/vzaidman/events{/privacy}",
"received_events_url": "https://api.github.com/users/vzaidman/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 5
| 2025-01-28T12:37:11
| 2025-01-28T19:13:45
| 2025-01-28T19:13:34
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/49001",
"html_url": "https://github.com/facebook/react-native/pull/49001",
"diff_url": "https://github.com/facebook/react-native/pull/49001.diff",
"patch_url": "https://github.com/facebook/react-native/pull/49001.patch",
"merged_at": null
}
|
Summary:
In {D42973408}, `Debugger.scriptParsed` was tweaked to be intercepted in `inspector-proxy`, which:
1. Rewrote the `sourceMapURL` to be relative to debugger.
2. Attempted to fetch the contents of the source map from `sourceMapURL` after re-writing again to a server-relative URL, and if successful replaced `sourceMapURL` with a base64 data URL.
1 is still needed until we have `Network.loadNetworkResource`, but 2 was only needed for frontends that did not support http fetch, and is not needed with Fusebox.
Changelog: [General][Changed] `Debugger.scriptParsed` now includes the field `sourceMapURL` as a (rewritten) remote url as opposed to base64 data url
Reviewed By: robhogan
Differential Revision: D68708899
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/49001/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/49001/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/49000
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/49000/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/49000/comments
|
https://api.github.com/repos/facebook/react-native/issues/49000/events
|
https://github.com/facebook/react-native/pull/49000
| 2,815,458,860
|
PR_kwDOAbrxp86JNwQR
| 49,000
|
Minor Kotlin cleanup
|
{
"login": "cortinico",
"id": 3001957,
"node_id": "MDQ6VXNlcjMwMDE5NTc=",
"avatar_url": "https://avatars.githubusercontent.com/u/3001957?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cortinico",
"html_url": "https://github.com/cortinico",
"followers_url": "https://api.github.com/users/cortinico/followers",
"following_url": "https://api.github.com/users/cortinico/following{/other_user}",
"gists_url": "https://api.github.com/users/cortinico/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cortinico/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cortinico/subscriptions",
"organizations_url": "https://api.github.com/users/cortinico/orgs",
"repos_url": "https://api.github.com/users/cortinico/repos",
"events_url": "https://api.github.com/users/cortinico/events{/privacy}",
"received_events_url": "https://api.github.com/users/cortinico/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 3
| 2025-01-28T12:04:16
| 2025-01-28T19:47:04
| 2025-01-28T19:46:54
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/49000",
"html_url": "https://github.com/facebook/react-native/pull/49000",
"diff_url": "https://github.com/facebook/react-native/pull/49000.diff",
"patch_url": "https://github.com/facebook/react-native/pull/49000.patch",
"merged_at": null
}
|
Summary:
Just found those nits around while looking at the codebase.
This clears things out and should have no runtime impact.
Changelog:
[Internal] [Changed] -
Differential Revision: D68768384
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/49000/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/49000/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48999
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48999/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48999/comments
|
https://api.github.com/repos/facebook/react-native/issues/48999/events
|
https://github.com/facebook/react-native/pull/48999
| 2,815,282,401
|
PR_kwDOAbrxp86JNJQD
| 48,999
|
Add explicit type for Symbol.iterator in URLSearchParams
|
{
"login": "coado",
"id": 64146291,
"node_id": "MDQ6VXNlcjY0MTQ2Mjkx",
"avatar_url": "https://avatars.githubusercontent.com/u/64146291?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/coado",
"html_url": "https://github.com/coado",
"followers_url": "https://api.github.com/users/coado/followers",
"following_url": "https://api.github.com/users/coado/following{/other_user}",
"gists_url": "https://api.github.com/users/coado/gists{/gist_id}",
"starred_url": "https://api.github.com/users/coado/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/coado/subscriptions",
"organizations_url": "https://api.github.com/users/coado/orgs",
"repos_url": "https://api.github.com/users/coado/repos",
"events_url": "https://api.github.com/users/coado/events{/privacy}",
"received_events_url": "https://api.github.com/users/coado/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1282006477,
"node_id": "MDU6TGFiZWwxMjgyMDA2NDc3",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Software%20Mansion",
"name": "p: Software Mansion",
"color": "0052cc",
"default": false,
"description": "Partner: Software Mansion"
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 4
| 2025-01-28T10:52:29
| 2025-01-28T16:19:09
| 2025-01-28T16:18:59
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48999",
"html_url": "https://github.com/facebook/react-native/pull/48999",
"diff_url": "https://github.com/facebook/react-native/pull/48999.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48999.patch",
"merged_at": null
}
|
Summary:
Changelog:
[General][Changed] - Added explicit type for Symbol.iterator in URLSearchParams
Differential Revision: D68766996
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48999/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48999/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48998
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48998/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48998/comments
|
https://api.github.com/repos/facebook/react-native/issues/48998/events
|
https://github.com/facebook/react-native/pull/48998
| 2,815,257,502
|
PR_kwDOAbrxp86JNDwn
| 48,998
|
fix(react-native): pass the protocol from bundle URL to HMR client on Android
|
{
"login": "byCedric",
"id": 1203991,
"node_id": "MDQ6VXNlcjEyMDM5OTE=",
"avatar_url": "https://avatars.githubusercontent.com/u/1203991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/byCedric",
"html_url": "https://github.com/byCedric",
"followers_url": "https://api.github.com/users/byCedric/followers",
"following_url": "https://api.github.com/users/byCedric/following{/other_user}",
"gists_url": "https://api.github.com/users/byCedric/gists{/gist_id}",
"starred_url": "https://api.github.com/users/byCedric/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/byCedric/subscriptions",
"organizations_url": "https://api.github.com/users/byCedric/orgs",
"repos_url": "https://api.github.com/users/byCedric/repos",
"events_url": "https://api.github.com/users/byCedric/events{/privacy}",
"received_events_url": "https://api.github.com/users/byCedric/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208509940,
"node_id": "MDU6TGFiZWwxMjA4NTA5OTQw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Expo",
"name": "p: Expo",
"color": "0052cc",
"default": false,
"description": "Partner: Expo"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 3253537094,
"node_id": "MDU6TGFiZWwzMjUzNTM3MDk0",
"url": "https://api.github.com/repos/facebook/react-native/labels/Shared%20with%20Meta",
"name": "Shared with Meta",
"color": "BFD4F2",
"default": false,
"description": "Applied via automation to indicate that an Issue or Pull Request has been shared with the team."
}
] |
closed
| false
| null |
[] | null | 5
| 2025-01-28T10:41:43
| 2025-03-11T11:48:50
| 2025-01-28T15:30:24
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48998",
"html_url": "https://github.com/facebook/react-native/pull/48998",
"diff_url": "https://github.com/facebook/react-native/pull/48998.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48998.patch",
"merged_at": null
}
|
## Summary:
This is another attempt at fixing the Android HMR client for HTTPS proxied Metro instances. The previous one unintentionally [caused the following error](https://github.com/facebook/react-native/pull/48970#issuecomment-2617047184):
```
java.lang.AssertionError: Method overloading is unsupported: com.facebook.react.devsupport.HMRClient#setup
```
This PR removes the overloading, and only adds the `scheme` property as a parameter to the existing `.setup` method. Aligning with the exact behavior we have on iOS.
The alternative fix, which should NOT be backward breaking (if this is) - is to move this "infer the protocol from the bundle URL" to the JS side of the HMR client. Where we don't just always default to `http`, but instead default to `https IF port === 443, otherwise http`. It's a bit more hacky, but shouldn't cause any other issues. _**Ideally**_, we have the same working behavior on both Android and iOS without workarounds.
<details><summary>Alternative workaround</summary>
See [this change](https://github.com/facebook/react-native/compare/main...byCedric:react-native:patch-2).
<img width="1179" alt="image" src="https://github.com/user-attachments/assets/47c365bc-6df8-43e6-ad7d-5a667e350cd4" />
</details>
See full explanation on #48970
> We've noticed that the HMR on Android doesn't seem to be connecting when using a HTTPS-proxied Metro instance, where the proxy is hosted through Cloudflare. This is only an issue on Android - not iOS - and likely caused by the HMR Client not being set up properly on Android.
>
>- On Android, we run `.setup('android', <bundleEntryPath>, <proxiedMetroHost>, <proxiedMetroPort>, <hmrEnabled>)` in the [**react/devsupport/DevSupportManagerBase.java**](https://github.com/facebook/react-native/blob/53d94c3abe3fcd2168b512652bc0169956bffa39/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevSupportManagerBase.java#L689-L691) file.
>- On iOS, we run `[self.callableJSModules invokeModule:@"HMRClient" method:@"setup" withArgs:@[ RCTPlatformName, path, host, RCTNullIfNil(port), @(isHotLoadingEnabled), scheme ]];` in the [**React/CoreModules
/RCTDevSettings.mm**](https://github.com/facebook/react-native/blob/53d94c3abe3fcd2168b512652bc0169956bffa39/packages/react-native/React/CoreModules/RCTDevSettings.mm#L488-L491) file.
>
>Notice how Android does not pass in the scheme/protocol of the bundle URL, while iOS actually does? Unfortunately, because the default protocol (`http`) mismatches on Android when using HTTPS proxies, we actually try to connect the HMR client over `http` instead of `https` - while still using port 443 - which is rejected by Cloudflare's infrastructure even before we can redirect or mitigate this issue. And the rejection is valid, as we basically try to connect on `http://<host>:443` (the source URL is `https`, so the port is infered as `443`).
>
>This change adds scheme propagation to Android, exactly like we do on iOS for the HMR Client.
## Changelog:
[ANDROID] [FIXED] Pass the bundle URL protocol when setting up HMR client on Android
<!-- Help reviewers and the release process by writing your own changelog entry.
Pick one each for the category and type tags:
[ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message
For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->
## Test Plan:
See full explanation on #48970
> It's a little bit hard to test this out yourself, since you'd need a HTTPS-based proxy and reject HTTP connections for HTTPS/WSS Websocket requests.
>
>You can set this up through:
>- `bun create expo@latest ./test-app`
>- `cd ./test-app`
>- `touch .env`
>- Set `EXPO_PACKAGER_PROXY_URL=https://<proxied-metro-hostname>` in **.env**
>- Set `REACT_NATIVE_PACKAGER_HOSTNAME=<proxied-metro-hostname>` in **.env**
>- `bun run start`
>
>Setting both these envvars, the bundle URL in the manifest is set to `https://...` - which triggers this HMR issue on Android. You can validate the **.env** setup through:
>
>```bash
>curl "http://localhost:8081" -H "expo-platform: android" | jq .launchAsset.url
>```
>
>This should point the entry bundle URL towards the `EXPO_PACKAGER_PROXY_URL`.
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48998/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48998/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48997
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48997/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48997/comments
|
https://api.github.com/repos/facebook/react-native/issues/48997/events
|
https://github.com/facebook/react-native/pull/48997
| 2,815,249,331
|
PR_kwDOAbrxp86JNB9f
| 48,997
|
Update cli-server-api middleware imports
|
{
"login": "huntie",
"id": 2547783,
"node_id": "MDQ6VXNlcjI1NDc3ODM=",
"avatar_url": "https://avatars.githubusercontent.com/u/2547783?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huntie",
"html_url": "https://github.com/huntie",
"followers_url": "https://api.github.com/users/huntie/followers",
"following_url": "https://api.github.com/users/huntie/following{/other_user}",
"gists_url": "https://api.github.com/users/huntie/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huntie/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huntie/subscriptions",
"organizations_url": "https://api.github.com/users/huntie/orgs",
"repos_url": "https://api.github.com/users/huntie/repos",
"events_url": "https://api.github.com/users/huntie/events{/privacy}",
"received_events_url": "https://api.github.com/users/huntie/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 5
| 2025-01-28T10:37:55
| 2025-03-06T16:35:31
| 2025-01-28T15:22:38
|
MEMBER
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48997",
"html_url": "https://github.com/facebook/react-native/pull/48997",
"diff_url": "https://github.com/facebook/react-native/pull/48997.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48997.patch",
"merged_at": null
}
|
Summary:
Follows https://github.com/react-native-community/cli/pull/2584.
- Also add FIXME comment flagging potential core APIs gap without CLI.
Changelog: [Internal]
Differential Revision: D68766565
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48997/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48997/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48996
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48996/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48996/comments
|
https://api.github.com/repos/facebook/react-native/issues/48996/events
|
https://github.com/facebook/react-native/pull/48996
| 2,815,241,599
|
PR_kwDOAbrxp86JNAQp
| 48,996
|
Remove hanging reference to Remote Debugging endpoint on Android
|
{
"login": "huntie",
"id": 2547783,
"node_id": "MDQ6VXNlcjI1NDc3ODM=",
"avatar_url": "https://avatars.githubusercontent.com/u/2547783?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huntie",
"html_url": "https://github.com/huntie",
"followers_url": "https://api.github.com/users/huntie/followers",
"following_url": "https://api.github.com/users/huntie/following{/other_user}",
"gists_url": "https://api.github.com/users/huntie/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huntie/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huntie/subscriptions",
"organizations_url": "https://api.github.com/users/huntie/orgs",
"repos_url": "https://api.github.com/users/huntie/repos",
"events_url": "https://api.github.com/users/huntie/events{/privacy}",
"received_events_url": "https://api.github.com/users/huntie/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 3
| 2025-01-28T10:34:22
| 2025-01-30T09:43:56
| 2025-01-28T13:05:29
|
MEMBER
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48996",
"html_url": "https://github.com/facebook/react-native/pull/48996",
"diff_url": "https://github.com/facebook/react-native/pull/48996.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48996.patch",
"merged_at": null
}
|
Summary:
Follows https://github.com/react-native-community/discussions-and-proposals/discussions/872.
Changelog:
[Android][Removed] - Remove `DevSupportManagerFactory.launchJSDevtools` API
Differential Revision: D68766564
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48996/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48996/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48995
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48995/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48995/comments
|
https://api.github.com/repos/facebook/react-native/issues/48995/events
|
https://github.com/facebook/react-native/pull/48995
| 2,815,142,306
|
PR_kwDOAbrxp86JMqWL
| 48,995
|
Add extra parameter to define whether codegen is invoked by lib or app
|
{
"login": "cipolleschi",
"id": 11162307,
"node_id": "MDQ6VXNlcjExMTYyMzA3",
"avatar_url": "https://avatars.githubusercontent.com/u/11162307?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cipolleschi",
"html_url": "https://github.com/cipolleschi",
"followers_url": "https://api.github.com/users/cipolleschi/followers",
"following_url": "https://api.github.com/users/cipolleschi/following{/other_user}",
"gists_url": "https://api.github.com/users/cipolleschi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cipolleschi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cipolleschi/subscriptions",
"organizations_url": "https://api.github.com/users/cipolleschi/orgs",
"repos_url": "https://api.github.com/users/cipolleschi/repos",
"events_url": "https://api.github.com/users/cipolleschi/events{/privacy}",
"received_events_url": "https://api.github.com/users/cipolleschi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 4
| 2025-01-28T09:54:17
| 2025-03-18T16:02:34
| 2025-01-28T13:11:20
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48995",
"html_url": "https://github.com/facebook/react-native/pull/48995",
"diff_url": "https://github.com/facebook/react-native/pull/48995.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48995.patch",
"merged_at": null
}
|
Summary:
This change adds an extra parameter to the codegen script that allow our users to trigger codegen for Apps or for Libraries.
When running codegen for Apps, we have to generate some extra files that are not needed by the Libraries. This is causing issues to our library maintainers and this change will provide more flexibility in the DevX of libraries.
The default value is App, so if the new parameter is not passed, nothing will change in the current behavior.
## Changelog:
[iOS][Added] - Add the `source` parameter to generate-codegen-artifacts to avoid generating files not needed by libraries.
Differential Revision: D68765478
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48995/reactions",
"total_count": 2,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 2,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48995/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48994
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48994/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48994/comments
|
https://api.github.com/repos/facebook/react-native/issues/48994/events
|
https://github.com/facebook/react-native/pull/48994
| 2,815,039,025
|
PR_kwDOAbrxp86JMTvJ
| 48,994
|
FIX: Support inline images in Text with lineHeight
|
{
"login": "rodriguescarson",
"id": 6134699,
"node_id": "MDQ6VXNlcjYxMzQ2OTk=",
"avatar_url": "https://avatars.githubusercontent.com/u/6134699?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rodriguescarson",
"html_url": "https://github.com/rodriguescarson",
"followers_url": "https://api.github.com/users/rodriguescarson/followers",
"following_url": "https://api.github.com/users/rodriguescarson/following{/other_user}",
"gists_url": "https://api.github.com/users/rodriguescarson/gists{/gist_id}",
"starred_url": "https://api.github.com/users/rodriguescarson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rodriguescarson/subscriptions",
"organizations_url": "https://api.github.com/users/rodriguescarson/orgs",
"repos_url": "https://api.github.com/users/rodriguescarson/repos",
"events_url": "https://api.github.com/users/rodriguescarson/events{/privacy}",
"received_events_url": "https://api.github.com/users/rodriguescarson/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 3253537094,
"node_id": "MDU6TGFiZWwzMjUzNTM3MDk0",
"url": "https://api.github.com/repos/facebook/react-native/labels/Shared%20with%20Meta",
"name": "Shared with Meta",
"color": "BFD4F2",
"default": false,
"description": "Applied via automation to indicate that an Issue or Pull Request has been shared with the team."
}
] |
open
| false
| null |
[] | null | 0
| 2025-01-28T09:08:02
| 2025-02-13T15:25:55
| null |
NONE
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48994",
"html_url": "https://github.com/facebook/react-native/pull/48994",
"diff_url": "https://github.com/facebook/react-native/pull/48994.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48994.patch",
"merged_at": null
}
|
## Summary:
This pull request addresses the image overflow issue in React Native's <Text> component when `lineHeight` is specified. By modifying the native code for `RCTTextView.mm`, we have:
1. Added a method to embed images into attributed text.
2. Updated the `setTextStorage` method to handle images within `NSTextStorage`.
3. Adjusted the `drawRect:` method to ensure images are drawn correctly.
These changes ensure proper positioning and rendering of images, fixing the long-standing overflow issue.
## Changelog:
[IOS] [FIXED] - Resolved image overflow issue in <Text> component when `lineHeight` is specified by updating `RCTTextView.mm`.
## Test Plan:
1. Verified that images embedded within the <Text> component are properly positioned and do not overflow.
2. Tested with various line heights and image sizes to confirm consistent behavior.
3. Ran the React Native test suite to ensure no regressions in functionality.
Example test steps:
- Use a <Text> component containing both text and images.
- Apply different `lineHeight` values and observe rendering.
- Verify no overlap or misalignment issues occur.
| null |
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48994/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48994/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48993
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48993/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48993/comments
|
https://api.github.com/repos/facebook/react-native/issues/48993/events
|
https://github.com/facebook/react-native/pull/48993
| 2,814,845,492
|
PR_kwDOAbrxp86JLpXu
| 48,993
|
FIX: Memory leak in Animated API by managing parent-child references
|
{
"login": "rodriguescarson",
"id": 6134699,
"node_id": "MDQ6VXNlcjYxMzQ2OTk=",
"avatar_url": "https://avatars.githubusercontent.com/u/6134699?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rodriguescarson",
"html_url": "https://github.com/rodriguescarson",
"followers_url": "https://api.github.com/users/rodriguescarson/followers",
"following_url": "https://api.github.com/users/rodriguescarson/following{/other_user}",
"gists_url": "https://api.github.com/users/rodriguescarson/gists{/gist_id}",
"starred_url": "https://api.github.com/users/rodriguescarson/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rodriguescarson/subscriptions",
"organizations_url": "https://api.github.com/users/rodriguescarson/orgs",
"repos_url": "https://api.github.com/users/rodriguescarson/repos",
"events_url": "https://api.github.com/users/rodriguescarson/events{/privacy}",
"received_events_url": "https://api.github.com/users/rodriguescarson/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 3253537094,
"node_id": "MDU6TGFiZWwzMjUzNTM3MDk0",
"url": "https://api.github.com/repos/facebook/react-native/labels/Shared%20with%20Meta",
"name": "Shared with Meta",
"color": "BFD4F2",
"default": false,
"description": "Applied via automation to indicate that an Issue or Pull Request has been shared with the team."
}
] |
open
| false
| null |
[] | null | 3
| 2025-01-28T07:33:43
| 2025-02-13T15:25:55
| null |
NONE
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48993",
"html_url": "https://github.com/facebook/react-native/pull/48993",
"diff_url": "https://github.com/facebook/react-native/pull/48993.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48993.patch",
"merged_at": null
}
|
Summary:
This pull request addresses a memory leak issue in React Native's Animated API by ensuring proper cleanup of parent-child relationships between AnimatedNode instances. The existing implementation did not manage bidirectional references effectively, leading to potential memory retention and performance degradation.
The fix introduces public methods (addChild and removeChild) to provide a consistent API for managing child nodes and modifies the internal methods to maintain a bidirectional relationship between parent and child nodes. This ensures proper cleanup of references, allowing garbage collection to function as intended.
Changelog:
[GENERAL][FIXED] - Resolved memory leak in Animated API by managing parent-child references between AnimatedNode instances.
Test Plan:
Verified that child nodes are correctly added and removed using the new public methods addChild and removeChild.
Confirmed that parent nodes are properly added to and removed from the _parents array of child nodes.
Ran the existing Animated API tests to ensure no regressions in functionality.
Monitored memory usage in Chrome DevTools to verify that parent-child relationships are correctly cleared, preventing memory leaks.
Tested the changes in a sample React Native project with complex animations to ensure stability and performance.
This description provides a clear motivation, solution summary, and test validation steps for reviewers and maintainers.
| null |
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48993/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48993/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48992
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48992/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48992/comments
|
https://api.github.com/repos/facebook/react-native/issues/48992/events
|
https://github.com/facebook/react-native/pull/48992
| 2,814,532,074
|
PR_kwDOAbrxp86JKmvq
| 48,992
|
[Bug] fix wrong cocoapods script on new_architecture.rb
|
{
"login": "CHOIMINSEOK",
"id": 20822017,
"node_id": "MDQ6VXNlcjIwODIyMDE3",
"avatar_url": "https://avatars.githubusercontent.com/u/20822017?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/CHOIMINSEOK",
"html_url": "https://github.com/CHOIMINSEOK",
"followers_url": "https://api.github.com/users/CHOIMINSEOK/followers",
"following_url": "https://api.github.com/users/CHOIMINSEOK/following{/other_user}",
"gists_url": "https://api.github.com/users/CHOIMINSEOK/gists{/gist_id}",
"starred_url": "https://api.github.com/users/CHOIMINSEOK/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/CHOIMINSEOK/subscriptions",
"organizations_url": "https://api.github.com/users/CHOIMINSEOK/orgs",
"repos_url": "https://api.github.com/users/CHOIMINSEOK/repos",
"events_url": "https://api.github.com/users/CHOIMINSEOK/events{/privacy}",
"received_events_url": "https://api.github.com/users/CHOIMINSEOK/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 3253537094,
"node_id": "MDU6TGFiZWwzMjUzNTM3MDk0",
"url": "https://api.github.com/repos/facebook/react-native/labels/Shared%20with%20Meta",
"name": "Shared with Meta",
"color": "BFD4F2",
"default": false,
"description": "Applied via automation to indicate that an Issue or Pull Request has been shared with the team."
}
] |
closed
| false
| null |
[] | null | 3
| 2025-01-28T03:18:00
| 2025-01-28T12:57:37
| 2025-01-28T12:57:25
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48992",
"html_url": "https://github.com/facebook/react-native/pull/48992",
"diff_url": "https://github.com/facebook/react-native/pull/48992.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48992.patch",
"merged_at": null
}
|
## Summary:
It seems that the `new_architecture.rb` script has an incorrect dependency configuration. The decision to install either “hermes-engine” or “React-jsc” should depend on whether Hermes is enabled or not. However, in the current `new_architecture.rb` setup, the build script toggles between “hermes-engine” and “React-jsi”.
```
if ENV["USE_HERMES"] == nil || ENV["USE_HERMES"] == "1"
spec.dependency "hermes-engine"
else
spec.dependency "React-jsi" // <= this must be "React-jsc", not "React-jsi"
end
```
https://github.com/facebook/react-native/blob/701622506248022c3a2fcea1c0066bba6e80232a/packages/react-native/scripts/cocoapods/new_architecture.rb#L141
When you try to use reanimated in brownfield app, you can reproduce runtime exception by this.
Reproduce Repo: https://github.com/CHOIMINSEOK/FullScreenOverlayIssue
script patch for this issue : https://github.com/CHOIMINSEOK/FullScreenOverlayIssue/blob/main/rn-app/.yarn/patches/react-native-reanimated-npm-3.16.7-1e7cd6d376.patch
## Changelog:
[IOS] [FIXED] - fix wrong cocoapods script on new_architecture.rb
## Test Plan:
I have no idea how to test regression.
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48992/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48992/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48991
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48991/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48991/comments
|
https://api.github.com/repos/facebook/react-native/issues/48991/events
|
https://github.com/facebook/react-native/pull/48991
| 2,814,421,500
|
PR_kwDOAbrxp86JKPCc
| 48,991
|
Support parsing <shadow>
|
{
"login": "NickGerleman",
"id": 835219,
"node_id": "MDQ6VXNlcjgzNTIxOQ==",
"avatar_url": "https://avatars.githubusercontent.com/u/835219?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/NickGerleman",
"html_url": "https://github.com/NickGerleman",
"followers_url": "https://api.github.com/users/NickGerleman/followers",
"following_url": "https://api.github.com/users/NickGerleman/following{/other_user}",
"gists_url": "https://api.github.com/users/NickGerleman/gists{/gist_id}",
"starred_url": "https://api.github.com/users/NickGerleman/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/NickGerleman/subscriptions",
"organizations_url": "https://api.github.com/users/NickGerleman/orgs",
"repos_url": "https://api.github.com/users/NickGerleman/repos",
"events_url": "https://api.github.com/users/NickGerleman/events{/privacy}",
"received_events_url": "https://api.github.com/users/NickGerleman/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 10
| 2025-01-28T01:36:04
| 2025-02-04T20:20:53
| 2025-02-04T20:20:23
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48991",
"html_url": "https://github.com/facebook/react-native/pull/48991",
"diff_url": "https://github.com/facebook/react-native/pull/48991.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48991.patch",
"merged_at": null
}
|
Summary: This adds support for parsing the `<shadow>` data type. In combination with `CSSCommaSeparatedList`, we can now parse box shadow expressions.
Differential Revision: D68744811
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48991/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48991/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48990
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48990/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48990/comments
|
https://api.github.com/repos/facebook/react-native/issues/48990/events
|
https://github.com/facebook/react-native/pull/48990
| 2,814,421,481
|
PR_kwDOAbrxp86JKPCM
| 48,990
|
Fix missing handling of "inset" CSS Keyword
|
{
"login": "NickGerleman",
"id": 835219,
"node_id": "MDQ6VXNlcjgzNTIxOQ==",
"avatar_url": "https://avatars.githubusercontent.com/u/835219?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/NickGerleman",
"html_url": "https://github.com/NickGerleman",
"followers_url": "https://api.github.com/users/NickGerleman/followers",
"following_url": "https://api.github.com/users/NickGerleman/following{/other_user}",
"gists_url": "https://api.github.com/users/NickGerleman/gists{/gist_id}",
"starred_url": "https://api.github.com/users/NickGerleman/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/NickGerleman/subscriptions",
"organizations_url": "https://api.github.com/users/NickGerleman/orgs",
"repos_url": "https://api.github.com/users/NickGerleman/repos",
"events_url": "https://api.github.com/users/NickGerleman/events{/privacy}",
"received_events_url": "https://api.github.com/users/NickGerleman/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 9
| 2025-01-28T01:36:03
| 2025-02-04T20:20:47
| 2025-02-04T20:20:22
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48990",
"html_url": "https://github.com/facebook/react-native/pull/48990",
"diff_url": "https://github.com/facebook/react-native/pull/48990.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48990.patch",
"merged_at": null
}
|
Summary:
tsia
Changelog: [Internal]
Reviewed By: joevilches
Differential Revision: D68743950
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48990/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48990/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48989
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48989/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48989/comments
|
https://api.github.com/repos/facebook/react-native/issues/48989/events
|
https://github.com/facebook/react-native/pull/48989
| 2,814,421,466
|
PR_kwDOAbrxp86JKPB9
| 48,989
|
Add equality operators to CSS data types
|
{
"login": "NickGerleman",
"id": 835219,
"node_id": "MDQ6VXNlcjgzNTIxOQ==",
"avatar_url": "https://avatars.githubusercontent.com/u/835219?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/NickGerleman",
"html_url": "https://github.com/NickGerleman",
"followers_url": "https://api.github.com/users/NickGerleman/followers",
"following_url": "https://api.github.com/users/NickGerleman/following{/other_user}",
"gists_url": "https://api.github.com/users/NickGerleman/gists{/gist_id}",
"starred_url": "https://api.github.com/users/NickGerleman/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/NickGerleman/subscriptions",
"organizations_url": "https://api.github.com/users/NickGerleman/orgs",
"repos_url": "https://api.github.com/users/NickGerleman/repos",
"events_url": "https://api.github.com/users/NickGerleman/events{/privacy}",
"received_events_url": "https://api.github.com/users/NickGerleman/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 4
| 2025-01-28T01:36:02
| 2025-02-04T00:08:33
| 2025-02-04T00:08:21
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48989",
"html_url": "https://github.com/facebook/react-native/pull/48989",
"diff_url": "https://github.com/facebook/react-native/pull/48989.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48989.patch",
"merged_at": null
}
|
Summary:
tsia
Also added a quick helper to CSSColor used later.
Changelog: [Internal]
Reviewed By: joevilches
Differential Revision: D68741768
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48989/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48989/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48988
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48988/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48988/comments
|
https://api.github.com/repos/facebook/react-native/issues/48988/events
|
https://github.com/facebook/react-native/pull/48988
| 2,814,421,448
|
PR_kwDOAbrxp86JKPBs
| 48,988
|
Disallow invalid unitless lengths in box shadows
|
{
"login": "NickGerleman",
"id": 835219,
"node_id": "MDQ6VXNlcjgzNTIxOQ==",
"avatar_url": "https://avatars.githubusercontent.com/u/835219?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/NickGerleman",
"html_url": "https://github.com/NickGerleman",
"followers_url": "https://api.github.com/users/NickGerleman/followers",
"following_url": "https://api.github.com/users/NickGerleman/following{/other_user}",
"gists_url": "https://api.github.com/users/NickGerleman/gists{/gist_id}",
"starred_url": "https://api.github.com/users/NickGerleman/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/NickGerleman/subscriptions",
"organizations_url": "https://api.github.com/users/NickGerleman/orgs",
"repos_url": "https://api.github.com/users/NickGerleman/repos",
"events_url": "https://api.github.com/users/NickGerleman/events{/privacy}",
"received_events_url": "https://api.github.com/users/NickGerleman/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 2
| 2025-01-28T01:36:01
| 2025-01-29T06:51:51
| 2025-01-29T06:51:41
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48988",
"html_url": "https://github.com/facebook/react-native/pull/48988",
"diff_url": "https://github.com/facebook/react-native/pull/48988.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48988.patch",
"merged_at": null
}
|
Summary:
The only unitless `<length>` value allowed is `0`, so most of the examples in the `processBoxShadow` unit tests are parse errors on web 🫠. Lets update the tests, and disallow these invalid values.
Changelog:
[General][Breaking] - Disallow invalid unitless lengths in box shadows
Reviewed By: jorge-cab
Differential Revision: D68740553
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48988/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48988/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48987
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48987/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48987/comments
|
https://api.github.com/repos/facebook/react-native/issues/48987/events
|
https://github.com/facebook/react-native/pull/48987
| 2,814,421,427
|
PR_kwDOAbrxp86JKPBa
| 48,987
|
CSSCommaSeparatedValue
|
{
"login": "NickGerleman",
"id": 835219,
"node_id": "MDQ6VXNlcjgzNTIxOQ==",
"avatar_url": "https://avatars.githubusercontent.com/u/835219?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/NickGerleman",
"html_url": "https://github.com/NickGerleman",
"followers_url": "https://api.github.com/users/NickGerleman/followers",
"following_url": "https://api.github.com/users/NickGerleman/following{/other_user}",
"gists_url": "https://api.github.com/users/NickGerleman/gists{/gist_id}",
"starred_url": "https://api.github.com/users/NickGerleman/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/NickGerleman/subscriptions",
"organizations_url": "https://api.github.com/users/NickGerleman/orgs",
"repos_url": "https://api.github.com/users/NickGerleman/repos",
"events_url": "https://api.github.com/users/NickGerleman/events{/privacy}",
"received_events_url": "https://api.github.com/users/NickGerleman/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 8
| 2025-01-28T01:36:00
| 2025-02-04T20:20:41
| 2025-02-04T20:20:22
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48987",
"html_url": "https://github.com/facebook/react-native/pull/48987",
"diff_url": "https://github.com/facebook/react-native/pull/48987.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48987.patch",
"merged_at": null
}
|
Summary:
Adds a data type parser for a variable number of values of a given single data type (at least 1).
E.g. `CSSCommaSeparatedList<CSSShadow>` will represent the syntax of `<shadow>#` (ie the value produced by box-shadow).
Changelog: [internal]
Differential Revision: D68738165
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48987/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48987/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48986
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48986/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48986/comments
|
https://api.github.com/repos/facebook/react-native/issues/48986/events
|
https://github.com/facebook/react-native/pull/48986
| 2,814,421,419
|
PR_kwDOAbrxp86JKPBT
| 48,986
|
CSSDataTypeParser consume() function
|
{
"login": "NickGerleman",
"id": 835219,
"node_id": "MDQ6VXNlcjgzNTIxOQ==",
"avatar_url": "https://avatars.githubusercontent.com/u/835219?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/NickGerleman",
"html_url": "https://github.com/NickGerleman",
"followers_url": "https://api.github.com/users/NickGerleman/followers",
"following_url": "https://api.github.com/users/NickGerleman/following{/other_user}",
"gists_url": "https://api.github.com/users/NickGerleman/gists{/gist_id}",
"starred_url": "https://api.github.com/users/NickGerleman/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/NickGerleman/subscriptions",
"organizations_url": "https://api.github.com/users/NickGerleman/orgs",
"repos_url": "https://api.github.com/users/NickGerleman/repos",
"events_url": "https://api.github.com/users/NickGerleman/events{/privacy}",
"received_events_url": "https://api.github.com/users/NickGerleman/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 6
| 2025-01-28T01:35:59
| 2025-02-04T20:20:36
| 2025-02-04T20:20:21
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48986",
"html_url": "https://github.com/facebook/react-native/pull/48986",
"diff_url": "https://github.com/facebook/react-native/pull/48986.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48986.patch",
"merged_at": null
}
|
Summary:
This adds a new `consume()` function to data type parsers which passes a raw parser. This can be used for types which are compounds of other data types, where we may want to accept more than the first token.
This will be used for shadow parsing, but also fixes a hypothetical future bug with ratios. E.g. `calc(foo) / calc(bar)` may be a valid ratio, not starting with a token. We instead just want to try to parse a number data type from the stream.
The form of parsing a preserved token + rest is removed, with the assumption that anything parsing more than a single token should use compound parsing.
Differential Revision: D68735370
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48986/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48986/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48985
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48985/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48985/comments
|
https://api.github.com/repos/facebook/react-native/issues/48985/events
|
https://github.com/facebook/react-native/pull/48985
| 2,814,421,412
|
PR_kwDOAbrxp86JKPBN
| 48,985
|
Do not consume component value on visitor failure
|
{
"login": "NickGerleman",
"id": 835219,
"node_id": "MDQ6VXNlcjgzNTIxOQ==",
"avatar_url": "https://avatars.githubusercontent.com/u/835219?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/NickGerleman",
"html_url": "https://github.com/NickGerleman",
"followers_url": "https://api.github.com/users/NickGerleman/followers",
"following_url": "https://api.github.com/users/NickGerleman/following{/other_user}",
"gists_url": "https://api.github.com/users/NickGerleman/gists{/gist_id}",
"starred_url": "https://api.github.com/users/NickGerleman/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/NickGerleman/subscriptions",
"organizations_url": "https://api.github.com/users/NickGerleman/orgs",
"repos_url": "https://api.github.com/users/NickGerleman/repos",
"events_url": "https://api.github.com/users/NickGerleman/events{/privacy}",
"received_events_url": "https://api.github.com/users/NickGerleman/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 10
| 2025-01-28T01:35:58
| 2025-02-04T20:20:30
| 2025-02-04T20:20:21
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48985",
"html_url": "https://github.com/facebook/react-native/pull/48985",
"diff_url": "https://github.com/facebook/react-native/pull/48985.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48985.patch",
"merged_at": null
}
|
Summary:
This reverts some of the behavior I added in D68357624, since peeking a component value is non-obviously more expensive than manually copying the parser, and needing to peek will be a pain for flat lists of values (like for box-shadow).
Changelog: [internal]
Differential Revision: D68733518
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48985/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48985/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48984
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48984/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48984/comments
|
https://api.github.com/repos/facebook/react-native/issues/48984/events
|
https://github.com/facebook/react-native/pull/48984
| 2,814,421,391
|
PR_kwDOAbrxp86JKPA7
| 48,984
|
Fix some CSSRatio Behavior
|
{
"login": "NickGerleman",
"id": 835219,
"node_id": "MDQ6VXNlcjgzNTIxOQ==",
"avatar_url": "https://avatars.githubusercontent.com/u/835219?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/NickGerleman",
"html_url": "https://github.com/NickGerleman",
"followers_url": "https://api.github.com/users/NickGerleman/followers",
"following_url": "https://api.github.com/users/NickGerleman/following{/other_user}",
"gists_url": "https://api.github.com/users/NickGerleman/gists{/gist_id}",
"starred_url": "https://api.github.com/users/NickGerleman/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/NickGerleman/subscriptions",
"organizations_url": "https://api.github.com/users/NickGerleman/orgs",
"repos_url": "https://api.github.com/users/NickGerleman/repos",
"events_url": "https://api.github.com/users/NickGerleman/events{/privacy}",
"received_events_url": "https://api.github.com/users/NickGerleman/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 2
| 2025-01-28T01:35:56
| 2025-01-29T01:43:31
| 2025-01-29T01:43:21
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48984",
"html_url": "https://github.com/facebook/react-native/pull/48984",
"diff_url": "https://github.com/facebook/react-native/pull/48984.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48984.patch",
"merged_at": null
}
|
Summary:
Noticed this in conjunction with another change, that I misinterpreted the ratio spec a bit. Ratios with a part less than zero are parse errors, while degenerate ratios are not (Chrome and Firefox both treat like this).
Removing usage of visitorless `consumeComponentValue()` here in preparation for next diff.
Changelog: [Internal]
Reviewed By: lenaic
Differential Revision: D68733519
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48984/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48984/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48983
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48983/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48983/comments
|
https://api.github.com/repos/facebook/react-native/issues/48983/events
|
https://github.com/facebook/react-native/pull/48983
| 2,814,212,164
|
PR_kwDOAbrxp86JJhPR
| 48,983
|
Fix innerBoxShadows not getting border-radius applied
|
{
"login": "jorge-cab",
"id": 57368278,
"node_id": "MDQ6VXNlcjU3MzY4Mjc4",
"avatar_url": "https://avatars.githubusercontent.com/u/57368278?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jorge-cab",
"html_url": "https://github.com/jorge-cab",
"followers_url": "https://api.github.com/users/jorge-cab/followers",
"following_url": "https://api.github.com/users/jorge-cab/following{/other_user}",
"gists_url": "https://api.github.com/users/jorge-cab/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jorge-cab/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jorge-cab/subscriptions",
"organizations_url": "https://api.github.com/users/jorge-cab/orgs",
"repos_url": "https://api.github.com/users/jorge-cab/repos",
"events_url": "https://api.github.com/users/jorge-cab/events{/privacy}",
"received_events_url": "https://api.github.com/users/jorge-cab/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 3
| 2025-01-27T22:44:33
| 2025-01-28T00:07:28
| 2025-01-28T00:07:20
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48983",
"html_url": "https://github.com/facebook/react-native/pull/48983",
"diff_url": "https://github.com/facebook/react-native/pull/48983.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48983.patch",
"merged_at": null
}
|
Summary:
tsia
Changelog: [Internal]
Reviewed By: NickGerleman
Differential Revision: D68734160
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48983/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48983/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48982
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48982/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48982/comments
|
https://api.github.com/repos/facebook/react-native/issues/48982/events
|
https://github.com/facebook/react-native/pull/48982
| 2,814,024,792
|
PR_kwDOAbrxp86JI4I8
| 48,982
|
Fix elevation with border-radius set
|
{
"login": "jorge-cab",
"id": 57368278,
"node_id": "MDQ6VXNlcjU3MzY4Mjc4",
"avatar_url": "https://avatars.githubusercontent.com/u/57368278?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/jorge-cab",
"html_url": "https://github.com/jorge-cab",
"followers_url": "https://api.github.com/users/jorge-cab/followers",
"following_url": "https://api.github.com/users/jorge-cab/following{/other_user}",
"gists_url": "https://api.github.com/users/jorge-cab/gists{/gist_id}",
"starred_url": "https://api.github.com/users/jorge-cab/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jorge-cab/subscriptions",
"organizations_url": "https://api.github.com/users/jorge-cab/orgs",
"repos_url": "https://api.github.com/users/jorge-cab/repos",
"events_url": "https://api.github.com/users/jorge-cab/events{/privacy}",
"received_events_url": "https://api.github.com/users/jorge-cab/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 4
| 2025-01-27T20:46:36
| 2025-01-27T22:52:38
| 2025-01-27T22:52:32
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48982",
"html_url": "https://github.com/facebook/react-native/pull/48982",
"diff_url": "https://github.com/facebook/react-native/pull/48982.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48982.patch",
"merged_at": null
}
|
Summary: We were missing a conversion to px on the `getOutline()` function of `CompositeBackgroundDrawable` which led to incorrect elevation prop rendering
Reviewed By: NickGerleman
Differential Revision: D68724947
https://github.com/facebook/react-native/issues/48874
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48982/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48982/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48981
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48981/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48981/comments
|
https://api.github.com/repos/facebook/react-native/issues/48981/events
|
https://github.com/facebook/react-native/pull/48981
| 2,813,880,246
|
PR_kwDOAbrxp86JIYcQ
| 48,981
|
Add ReactBuildConfig.ENABLE_PERFETTO
|
{
"login": "tdn120",
"id": 32721554,
"node_id": "MDQ6VXNlcjMyNzIxNTU0",
"avatar_url": "https://avatars.githubusercontent.com/u/32721554?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tdn120",
"html_url": "https://github.com/tdn120",
"followers_url": "https://api.github.com/users/tdn120/followers",
"following_url": "https://api.github.com/users/tdn120/following{/other_user}",
"gists_url": "https://api.github.com/users/tdn120/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tdn120/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tdn120/subscriptions",
"organizations_url": "https://api.github.com/users/tdn120/orgs",
"repos_url": "https://api.github.com/users/tdn120/repos",
"events_url": "https://api.github.com/users/tdn120/events{/privacy}",
"received_events_url": "https://api.github.com/users/tdn120/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 6
| 2025-01-27T19:29:37
| 2025-01-31T18:08:15
| 2025-01-31T18:08:04
|
NONE
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48981",
"html_url": "https://github.com/facebook/react-native/pull/48981",
"diff_url": "https://github.com/facebook/react-native/pull/48981.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48981.patch",
"merged_at": null
}
|
Summary:
Add entry for this flag in ReactBuildConfig
Changelog: [Internal]
Differential Revision: D68725330
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48981/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48981/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48980
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48980/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48980/comments
|
https://api.github.com/repos/facebook/react-native/issues/48980/events
|
https://github.com/facebook/react-native/pull/48980
| 2,813,702,191
|
PR_kwDOAbrxp86JHxhJ
| 48,980
|
Remove expected ESLint error
|
{
"login": "rubennorte",
"id": 117921,
"node_id": "MDQ6VXNlcjExNzkyMQ==",
"avatar_url": "https://avatars.githubusercontent.com/u/117921?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rubennorte",
"html_url": "https://github.com/rubennorte",
"followers_url": "https://api.github.com/users/rubennorte/followers",
"following_url": "https://api.github.com/users/rubennorte/following{/other_user}",
"gists_url": "https://api.github.com/users/rubennorte/gists{/gist_id}",
"starred_url": "https://api.github.com/users/rubennorte/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rubennorte/subscriptions",
"organizations_url": "https://api.github.com/users/rubennorte/orgs",
"repos_url": "https://api.github.com/users/rubennorte/repos",
"events_url": "https://api.github.com/users/rubennorte/events{/privacy}",
"received_events_url": "https://api.github.com/users/rubennorte/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 4
| 2025-01-27T18:03:36
| 2025-01-28T11:36:20
| 2025-01-28T11:36:08
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48980",
"html_url": "https://github.com/facebook/react-native/pull/48980",
"diff_url": "https://github.com/facebook/react-native/pull/48980.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48980.patch",
"merged_at": null
}
|
Summary:
Changelog: [internal]
This will be properly removed soon, but disabling for now to avoid showing up in all PRs.
Differential Revision: D68719573
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48980/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48980/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48979
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48979/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48979/comments
|
https://api.github.com/repos/facebook/react-native/issues/48979/events
|
https://github.com/facebook/react-native/pull/48979
| 2,813,661,972
|
PR_kwDOAbrxp86JHouz
| 48,979
|
Update debugger-frontend from 7727db8...d126cc8
|
{
"login": "hoxyq",
"id": 28902667,
"node_id": "MDQ6VXNlcjI4OTAyNjY3",
"avatar_url": "https://avatars.githubusercontent.com/u/28902667?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hoxyq",
"html_url": "https://github.com/hoxyq",
"followers_url": "https://api.github.com/users/hoxyq/followers",
"following_url": "https://api.github.com/users/hoxyq/following{/other_user}",
"gists_url": "https://api.github.com/users/hoxyq/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hoxyq/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hoxyq/subscriptions",
"organizations_url": "https://api.github.com/users/hoxyq/orgs",
"repos_url": "https://api.github.com/users/hoxyq/repos",
"events_url": "https://api.github.com/users/hoxyq/events{/privacy}",
"received_events_url": "https://api.github.com/users/hoxyq/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 2
| 2025-01-27T17:44:17
| 2025-01-28T16:41:31
| 2025-01-28T16:41:18
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48979",
"html_url": "https://github.com/facebook/react-native/pull/48979",
"diff_url": "https://github.com/facebook/react-native/pull/48979.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48979.patch",
"merged_at": null
}
|
Summary:
Changelog: [Internal] - Update `react-native/debugger-frontend` from 7727db8...d126cc8
Resyncs `react-native/debugger-frontend` from GitHub - see `rn-chrome-devtools-frontend` [changelog](https://github.com/facebookexperimental/rn-chrome-devtools-frontend/compare/7727db85ac767cf41cce3e9ee54d27e97b2637f9...d126cc87f2b61e12e9579ddbfd4c0eb516bce881).
Differential Revision: D68717476
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48979/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48979/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48976
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48976/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48976/comments
|
https://api.github.com/repos/facebook/react-native/issues/48976/events
|
https://github.com/facebook/react-native/pull/48976
| 2,813,504,748
|
PR_kwDOAbrxp86JHF7r
| 48,976
|
Back out "Migrate Libraries/Utilities/*.js to use `export` syntax."
|
{
"login": "huntie",
"id": 2547783,
"node_id": "MDQ6VXNlcjI1NDc3ODM=",
"avatar_url": "https://avatars.githubusercontent.com/u/2547783?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huntie",
"html_url": "https://github.com/huntie",
"followers_url": "https://api.github.com/users/huntie/followers",
"following_url": "https://api.github.com/users/huntie/following{/other_user}",
"gists_url": "https://api.github.com/users/huntie/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huntie/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huntie/subscriptions",
"organizations_url": "https://api.github.com/users/huntie/orgs",
"repos_url": "https://api.github.com/users/huntie/repos",
"events_url": "https://api.github.com/users/huntie/events{/privacy}",
"received_events_url": "https://api.github.com/users/huntie/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 3
| 2025-01-27T16:39:54
| 2025-01-30T09:43:55
| 2025-01-27T19:23:22
|
MEMBER
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48976",
"html_url": "https://github.com/facebook/react-native/pull/48976",
"diff_url": "https://github.com/facebook/react-native/pull/48976.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48976.patch",
"merged_at": null
}
|
Summary: Changelog: [Internal] - Will reattempt
Differential Revision: D68713280
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48976/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48976/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48975
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48975/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48975/comments
|
https://api.github.com/repos/facebook/react-native/issues/48975/events
|
https://github.com/facebook/react-native/pull/48975
| 2,813,496,683
|
PR_kwDOAbrxp86JHEKr
| 48,975
|
Bump React Native monorepo packages
|
{
"login": "cipolleschi",
"id": 11162307,
"node_id": "MDQ6VXNlcjExMTYyMzA3",
"avatar_url": "https://avatars.githubusercontent.com/u/11162307?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cipolleschi",
"html_url": "https://github.com/cipolleschi",
"followers_url": "https://api.github.com/users/cipolleschi/followers",
"following_url": "https://api.github.com/users/cipolleschi/following{/other_user}",
"gists_url": "https://api.github.com/users/cipolleschi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cipolleschi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cipolleschi/subscriptions",
"organizations_url": "https://api.github.com/users/cipolleschi/orgs",
"repos_url": "https://api.github.com/users/cipolleschi/repos",
"events_url": "https://api.github.com/users/cipolleschi/events{/privacy}",
"received_events_url": "https://api.github.com/users/cipolleschi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 3
| 2025-01-27T16:36:25
| 2025-01-27T19:05:48
| 2025-01-27T19:05:37
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48975",
"html_url": "https://github.com/facebook/react-native/pull/48975",
"diff_url": "https://github.com/facebook/react-native/pull/48975.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48975.patch",
"merged_at": null
}
|
Summary:
After cutting 0.78-stable, we need to bump the monorepo packages to `0.79.0-main`
## Changelog:
[Internal] - Bump monorepo packages to `0.79.0-main`
Differential Revision: D68715005
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48975/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48975/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48974
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48974/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48974/comments
|
https://api.github.com/repos/facebook/react-native/issues/48974/events
|
https://github.com/facebook/react-native/pull/48974
| 2,813,484,153
|
PR_kwDOAbrxp86JHBaE
| 48,974
|
Add Changelog for 0.74.7
|
{
"login": "cortinico",
"id": 3001957,
"node_id": "MDQ6VXNlcjMwMDE5NTc=",
"avatar_url": "https://avatars.githubusercontent.com/u/3001957?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cortinico",
"html_url": "https://github.com/cortinico",
"followers_url": "https://api.github.com/users/cortinico/followers",
"following_url": "https://api.github.com/users/cortinico/following{/other_user}",
"gists_url": "https://api.github.com/users/cortinico/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cortinico/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cortinico/subscriptions",
"organizations_url": "https://api.github.com/users/cortinico/orgs",
"repos_url": "https://api.github.com/users/cortinico/repos",
"events_url": "https://api.github.com/users/cortinico/events{/privacy}",
"received_events_url": "https://api.github.com/users/cortinico/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
}
] |
closed
| false
| null |
[] | null | 3
| 2025-01-27T16:31:20
| 2025-01-27T17:41:08
| 2025-01-27T17:40:59
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48974",
"html_url": "https://github.com/facebook/react-native/pull/48974",
"diff_url": "https://github.com/facebook/react-native/pull/48974.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48974.patch",
"merged_at": null
}
|
## Summary:
Changelog for 0.74.7
## Changelog:
[Internal] [Changed] -
## Test Plan:
N/A
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48974/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48974/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48973
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48973/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48973/comments
|
https://api.github.com/repos/facebook/react-native/issues/48973/events
|
https://github.com/facebook/react-native/pull/48973
| 2,813,465,807
|
PR_kwDOAbrxp86JG9bI
| 48,973
|
disable failing Differentiator test
|
{
"login": "sammy-SC",
"id": 1733610,
"node_id": "MDQ6VXNlcjE3MzM2MTA=",
"avatar_url": "https://avatars.githubusercontent.com/u/1733610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sammy-SC",
"html_url": "https://github.com/sammy-SC",
"followers_url": "https://api.github.com/users/sammy-SC/followers",
"following_url": "https://api.github.com/users/sammy-SC/following{/other_user}",
"gists_url": "https://api.github.com/users/sammy-SC/gists{/gist_id}",
"starred_url": "https://api.github.com/users/sammy-SC/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sammy-SC/subscriptions",
"organizations_url": "https://api.github.com/users/sammy-SC/orgs",
"repos_url": "https://api.github.com/users/sammy-SC/repos",
"events_url": "https://api.github.com/users/sammy-SC/events{/privacy}",
"received_events_url": "https://api.github.com/users/sammy-SC/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 3
| 2025-01-27T16:23:45
| 2025-01-27T18:27:47
| 2025-01-27T18:27:37
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48973",
"html_url": "https://github.com/facebook/react-native/pull/48973",
"diff_url": "https://github.com/facebook/react-native/pull/48973.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48973.patch",
"merged_at": null
}
|
Summary:
changelog: [internal]
This test is broken, let's disable it until it is fixed.
Reviewed By: javache
Differential Revision: D68709385
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48973/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48973/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48972
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48972/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48972/comments
|
https://api.github.com/repos/facebook/react-native/issues/48972/events
|
https://github.com/facebook/react-native/pull/48972
| 2,813,400,388
|
PR_kwDOAbrxp86JGu8y
| 48,972
|
Align TextInput types with TypeScript
|
{
"login": "j-piasecki",
"id": 21055725,
"node_id": "MDQ6VXNlcjIxMDU1NzI1",
"avatar_url": "https://avatars.githubusercontent.com/u/21055725?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/j-piasecki",
"html_url": "https://github.com/j-piasecki",
"followers_url": "https://api.github.com/users/j-piasecki/followers",
"following_url": "https://api.github.com/users/j-piasecki/following{/other_user}",
"gists_url": "https://api.github.com/users/j-piasecki/gists{/gist_id}",
"starred_url": "https://api.github.com/users/j-piasecki/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/j-piasecki/subscriptions",
"organizations_url": "https://api.github.com/users/j-piasecki/orgs",
"repos_url": "https://api.github.com/users/j-piasecki/repos",
"events_url": "https://api.github.com/users/j-piasecki/events{/privacy}",
"received_events_url": "https://api.github.com/users/j-piasecki/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1282006477,
"node_id": "MDU6TGFiZWwxMjgyMDA2NDc3",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Software%20Mansion",
"name": "p: Software Mansion",
"color": "0052cc",
"default": false,
"description": "Partner: Software Mansion"
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 5
| 2025-01-27T15:56:50
| 2025-01-31T13:08:59
| 2025-01-31T12:58:47
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48972",
"html_url": "https://github.com/facebook/react-native/pull/48972",
"diff_url": "https://github.com/facebook/react-native/pull/48972.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48972.patch",
"merged_at": null
}
|
Summary:
Changelog: [Internal]
Align TextInput types with TypeScript definitions.
Differential Revision: D68713179
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48972/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48972/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48971
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48971/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48971/comments
|
https://api.github.com/repos/facebook/react-native/issues/48971/events
|
https://github.com/facebook/react-native/pull/48971
| 2,813,397,133
|
PR_kwDOAbrxp86JGuO7
| 48,971
|
Align TextInput event types with TypeScript
|
{
"login": "j-piasecki",
"id": 21055725,
"node_id": "MDQ6VXNlcjIxMDU1NzI1",
"avatar_url": "https://avatars.githubusercontent.com/u/21055725?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/j-piasecki",
"html_url": "https://github.com/j-piasecki",
"followers_url": "https://api.github.com/users/j-piasecki/followers",
"following_url": "https://api.github.com/users/j-piasecki/following{/other_user}",
"gists_url": "https://api.github.com/users/j-piasecki/gists{/gist_id}",
"starred_url": "https://api.github.com/users/j-piasecki/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/j-piasecki/subscriptions",
"organizations_url": "https://api.github.com/users/j-piasecki/orgs",
"repos_url": "https://api.github.com/users/j-piasecki/repos",
"events_url": "https://api.github.com/users/j-piasecki/events{/privacy}",
"received_events_url": "https://api.github.com/users/j-piasecki/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1282006477,
"node_id": "MDU6TGFiZWwxMjgyMDA2NDc3",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Software%20Mansion",
"name": "p: Software Mansion",
"color": "0052cc",
"default": false,
"description": "Partner: Software Mansion"
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 10
| 2025-01-27T15:55:33
| 2025-01-31T12:58:56
| 2025-01-31T12:58:46
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48971",
"html_url": "https://github.com/facebook/react-native/pull/48971",
"diff_url": "https://github.com/facebook/react-native/pull/48971.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48971.patch",
"merged_at": null
}
|
Summary:
Changelog: [Internal]
Mosltly align event types of TextInput components with TypeScript definitions.
Differential Revision: D68713180
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48971/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48971/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48970
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48970/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48970/comments
|
https://api.github.com/repos/facebook/react-native/issues/48970/events
|
https://github.com/facebook/react-native/pull/48970
| 2,813,032,060
|
PR_kwDOAbrxp86JFezE
| 48,970
|
fix(react-native): pass the protocol from bundle URL to HMR client on Android
|
{
"login": "byCedric",
"id": 1203991,
"node_id": "MDQ6VXNlcjEyMDM5OTE=",
"avatar_url": "https://avatars.githubusercontent.com/u/1203991?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/byCedric",
"html_url": "https://github.com/byCedric",
"followers_url": "https://api.github.com/users/byCedric/followers",
"following_url": "https://api.github.com/users/byCedric/following{/other_user}",
"gists_url": "https://api.github.com/users/byCedric/gists{/gist_id}",
"starred_url": "https://api.github.com/users/byCedric/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/byCedric/subscriptions",
"organizations_url": "https://api.github.com/users/byCedric/orgs",
"repos_url": "https://api.github.com/users/byCedric/repos",
"events_url": "https://api.github.com/users/byCedric/events{/privacy}",
"received_events_url": "https://api.github.com/users/byCedric/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208509940,
"node_id": "MDU6TGFiZWwxMjA4NTA5OTQw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Expo",
"name": "p: Expo",
"color": "0052cc",
"default": false,
"description": "Partner: Expo"
},
{
"id": 1215116864,
"node_id": "MDU6TGFiZWwxMjE1MTE2ODY0",
"url": "https://api.github.com/repos/facebook/react-native/labels/Reverted",
"name": "Reverted",
"color": "e11d21",
"default": false,
"description": ""
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 3253537094,
"node_id": "MDU6TGFiZWwzMjUzNTM3MDk0",
"url": "https://api.github.com/repos/facebook/react-native/labels/Shared%20with%20Meta",
"name": "Shared with Meta",
"color": "BFD4F2",
"default": false,
"description": "Applied via automation to indicate that an Issue or Pull Request has been shared with the team."
}
] |
closed
| false
| null |
[] | null | 5
| 2025-01-27T13:27:52
| 2025-01-28T12:07:31
| 2025-01-27T17:48:53
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48970",
"html_url": "https://github.com/facebook/react-native/pull/48970",
"diff_url": "https://github.com/facebook/react-native/pull/48970.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48970.patch",
"merged_at": null
}
|
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory. -->
## Summary:
We've noticed that the HMR on Android doesn't seem to be connecting when using a HTTPS-proxied Metro instance, where the proxy is hosted through Cloudflare. This is only an issue on Android - not iOS - and likely caused by the HMR Client not being set up properly on Android.
- On Android, we run `.setup('android', <bundleEntryPath>, <proxiedMetroHost>, <proxiedMetroPort>, <hmrEnabled>)` in the [**react/devsupport/DevSupportManagerBase.java**](https://github.com/facebook/react-native/blob/53d94c3abe3fcd2168b512652bc0169956bffa39/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevSupportManagerBase.java#L689-L691) file.
- On iOS, we run `[self.callableJSModules invokeModule:@"HMRClient" method:@"setup" withArgs:@[ RCTPlatformName, path, host, RCTNullIfNil(port), @(isHotLoadingEnabled), scheme ]];` in the [**React/CoreModules
/RCTDevSettings.mm**](https://github.com/facebook/react-native/blob/53d94c3abe3fcd2168b512652bc0169956bffa39/packages/react-native/React/CoreModules/RCTDevSettings.mm#L488-L491) file.
Notice how Android does not pass in the scheme/protocol of the bundle URL, while iOS actually does? Unfortunately, because the default protocol (`http`) mismatches on Android when using HTTPS proxies, we actually try to connect the HMR client over `http` instead of `https` - while still using port 443 - which is rejected by Cloudflare's infrastructure even before we can redirect or mitigate this issue. And the rejection is valid, as we basically try to connect on `http://<host>:443` (the source URL is `https`, so the port is infered as `443`).
This change adds scheme propagation to Android, exactly like we do on iOS for the HMR Client.
## Changelog:
[ANDROID] [FIXED] Pass the bundle URL protocol when setting up HMR client on Android
<!-- Help reviewers and the release process by writing your own changelog entry.
Pick one each for the category and type tags:
[ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message
For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->
## Test Plan:
It's a little bit hard to test this out yourself, since you'd need a HTTPS-based proxy and reject HTTP connections for HTTPS/WSS Websocket requests.
You can set this up through:
- `bun create expo@latest ./test-app`
- `cd ./test-app`
- `touch .env`
- Set `EXPO_PACKAGER_PROXY_URL=https://<proxied-metro-hostname>` in **.env**
- Set `REACT_NATIVE_PACKAGER_HOSTNAME=<proxied-metro-hostname>` in **.env**
- `bun run start`
Setting both these envvars, the bundle URL in the manifest is set to `https://...` - which triggers this HMR issue on Android. You can validate the **.env** setup through:
```bash
curl "http://localhost:8081" -H "expo-platform: android" | jq .launchAsset.url
```
This should point the entry bundle URL towards the `EXPO_PACKAGER_PROXY_URL`.
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48970/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48970/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48969
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48969/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48969/comments
|
https://api.github.com/repos/facebook/react-native/issues/48969/events
|
https://github.com/facebook/react-native/pull/48969
| 2,812,947,228
|
PR_kwDOAbrxp86JFMKN
| 48,969
|
Allow to opt-out certain modules from automatic type generation
|
{
"login": "j-piasecki",
"id": 21055725,
"node_id": "MDQ6VXNlcjIxMDU1NzI1",
"avatar_url": "https://avatars.githubusercontent.com/u/21055725?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/j-piasecki",
"html_url": "https://github.com/j-piasecki",
"followers_url": "https://api.github.com/users/j-piasecki/followers",
"following_url": "https://api.github.com/users/j-piasecki/following{/other_user}",
"gists_url": "https://api.github.com/users/j-piasecki/gists{/gist_id}",
"starred_url": "https://api.github.com/users/j-piasecki/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/j-piasecki/subscriptions",
"organizations_url": "https://api.github.com/users/j-piasecki/orgs",
"repos_url": "https://api.github.com/users/j-piasecki/repos",
"events_url": "https://api.github.com/users/j-piasecki/events{/privacy}",
"received_events_url": "https://api.github.com/users/j-piasecki/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1282006477,
"node_id": "MDU6TGFiZWwxMjgyMDA2NDc3",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Software%20Mansion",
"name": "p: Software Mansion",
"color": "0052cc",
"default": false,
"description": "Partner: Software Mansion"
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 2
| 2025-01-27T12:51:40
| 2025-05-08T07:54:18
| 2025-05-08T07:54:18
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48969",
"html_url": "https://github.com/facebook/react-native/pull/48969",
"diff_url": "https://github.com/facebook/react-native/pull/48969.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48969.patch",
"merged_at": null
}
|
Summary:
Changelog: [Internal]
Allow to opt-out certain modules from the type translation and use manually prepared types instead.
The override can contain either an array of files to use for a given glob, or another glob to match files that should be copied.
Differential Revision: D68707899
|
{
"login": "j-piasecki",
"id": 21055725,
"node_id": "MDQ6VXNlcjIxMDU1NzI1",
"avatar_url": "https://avatars.githubusercontent.com/u/21055725?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/j-piasecki",
"html_url": "https://github.com/j-piasecki",
"followers_url": "https://api.github.com/users/j-piasecki/followers",
"following_url": "https://api.github.com/users/j-piasecki/following{/other_user}",
"gists_url": "https://api.github.com/users/j-piasecki/gists{/gist_id}",
"starred_url": "https://api.github.com/users/j-piasecki/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/j-piasecki/subscriptions",
"organizations_url": "https://api.github.com/users/j-piasecki/orgs",
"repos_url": "https://api.github.com/users/j-piasecki/repos",
"events_url": "https://api.github.com/users/j-piasecki/events{/privacy}",
"received_events_url": "https://api.github.com/users/j-piasecki/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48969/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48969/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48968
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48968/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48968/comments
|
https://api.github.com/repos/facebook/react-native/issues/48968/events
|
https://github.com/facebook/react-native/pull/48968
| 2,812,895,159
|
PR_kwDOAbrxp86JFAnL
| 48,968
|
Remove unnecessary visiblity modifiers for internal classes
|
{
"login": "cortinico",
"id": 3001957,
"node_id": "MDQ6VXNlcjMwMDE5NTc=",
"avatar_url": "https://avatars.githubusercontent.com/u/3001957?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cortinico",
"html_url": "https://github.com/cortinico",
"followers_url": "https://api.github.com/users/cortinico/followers",
"following_url": "https://api.github.com/users/cortinico/following{/other_user}",
"gists_url": "https://api.github.com/users/cortinico/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cortinico/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cortinico/subscriptions",
"organizations_url": "https://api.github.com/users/cortinico/orgs",
"repos_url": "https://api.github.com/users/cortinico/repos",
"events_url": "https://api.github.com/users/cortinico/events{/privacy}",
"received_events_url": "https://api.github.com/users/cortinico/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 3
| 2025-01-27T12:29:06
| 2025-01-27T18:21:33
| 2025-01-27T18:21:22
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48968",
"html_url": "https://github.com/facebook/react-native/pull/48968",
"diff_url": "https://github.com/facebook/react-native/pull/48968.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48968.patch",
"merged_at": null
}
|
Summary:
I've noticed we have a lot of `public` and `protected` modifiers for classes that are actually `internal`.
Those are unnecessary as the class itself is `internal` and there is no way to extend the visibility of single fields.
Changelog:
[Internal] [Changed] -
Differential Revision: D68707255
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48968/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48968/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48967
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48967/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48967/comments
|
https://api.github.com/repos/facebook/react-native/issues/48967/events
|
https://github.com/facebook/react-native/pull/48967
| 2,812,749,838
|
PR_kwDOAbrxp86JEgf7
| 48,967
|
Call cocoapods passing the RCT_IGNORE_PODS_DEPRECATION flag
|
{
"login": "cipolleschi",
"id": 11162307,
"node_id": "MDQ6VXNlcjExMTYyMzA3",
"avatar_url": "https://avatars.githubusercontent.com/u/11162307?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cipolleschi",
"html_url": "https://github.com/cipolleschi",
"followers_url": "https://api.github.com/users/cipolleschi/followers",
"following_url": "https://api.github.com/users/cipolleschi/following{/other_user}",
"gists_url": "https://api.github.com/users/cipolleschi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cipolleschi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cipolleschi/subscriptions",
"organizations_url": "https://api.github.com/users/cipolleschi/orgs",
"repos_url": "https://api.github.com/users/cipolleschi/repos",
"events_url": "https://api.github.com/users/cipolleschi/events{/privacy}",
"received_events_url": "https://api.github.com/users/cipolleschi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 4
| 2025-01-27T11:23:18
| 2025-01-27T14:56:53
| 2025-01-27T14:56:26
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48967",
"html_url": "https://github.com/facebook/react-native/pull/48967",
"diff_url": "https://github.com/facebook/react-native/pull/48967.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48967.patch",
"merged_at": null
}
|
Summary:
This change updates the core-cli-utils package to call `pod install` by passing the `RCT_IGNORE_PODS_DEPRECATION` flag.
## Changelog:
[iOS][Changed] - Ignore deprecation warning when calling pod install through core-cli-utils
Differential Revision: D68704956
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48967/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48967/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48966
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48966/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48966/comments
|
https://api.github.com/repos/facebook/react-native/issues/48966/events
|
https://github.com/facebook/react-native/pull/48966
| 2,812,749,801
|
PR_kwDOAbrxp86JEgfY
| 48,966
|
Update Gemfile
|
{
"login": "cipolleschi",
"id": 11162307,
"node_id": "MDQ6VXNlcjExMTYyMzA3",
"avatar_url": "https://avatars.githubusercontent.com/u/11162307?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cipolleschi",
"html_url": "https://github.com/cipolleschi",
"followers_url": "https://api.github.com/users/cipolleschi/followers",
"following_url": "https://api.github.com/users/cipolleschi/following{/other_user}",
"gists_url": "https://api.github.com/users/cipolleschi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cipolleschi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cipolleschi/subscriptions",
"organizations_url": "https://api.github.com/users/cipolleschi/orgs",
"repos_url": "https://api.github.com/users/cipolleschi/repos",
"events_url": "https://api.github.com/users/cipolleschi/events{/privacy}",
"received_events_url": "https://api.github.com/users/cipolleschi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 4
| 2025-01-27T11:23:17
| 2025-01-27T14:56:41
| 2025-01-27T14:56:24
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48966",
"html_url": "https://github.com/facebook/react-native/pull/48966",
"diff_url": "https://github.com/facebook/react-native/pull/48966.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48966.patch",
"merged_at": null
}
|
Summary:
In our previous fix for concurrent-ruby, we have been a bit too strict. Version 1.3.4 is a valid and working version. The broken version is 1.3.5.
## Changelog:
[iOS][Changed] - Fix Gemfile versions
Differential Revision: D68706060
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48966/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48966/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48965
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48965/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48965/comments
|
https://api.github.com/repos/facebook/react-native/issues/48965/events
|
https://github.com/facebook/react-native/pull/48965
| 2,812,749,773
|
PR_kwDOAbrxp86JEge_
| 48,965
|
Move running codegen to core-cli-utils
|
{
"login": "cipolleschi",
"id": 11162307,
"node_id": "MDQ6VXNlcjExMTYyMzA3",
"avatar_url": "https://avatars.githubusercontent.com/u/11162307?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cipolleschi",
"html_url": "https://github.com/cipolleschi",
"followers_url": "https://api.github.com/users/cipolleschi/followers",
"following_url": "https://api.github.com/users/cipolleschi/following{/other_user}",
"gists_url": "https://api.github.com/users/cipolleschi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cipolleschi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cipolleschi/subscriptions",
"organizations_url": "https://api.github.com/users/cipolleschi/orgs",
"repos_url": "https://api.github.com/users/cipolleschi/repos",
"events_url": "https://api.github.com/users/cipolleschi/events{/privacy}",
"received_events_url": "https://api.github.com/users/cipolleschi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 4
| 2025-01-27T11:23:16
| 2025-01-27T14:56:47
| 2025-01-27T14:56:25
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48965",
"html_url": "https://github.com/facebook/react-native/pull/48965",
"diff_url": "https://github.com/facebook/react-native/pull/48965.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48965.patch",
"merged_at": null
}
|
Summary:
Running codegen should not be a Cocoapods responsibilities, but it should be something that runs before Cocoapods to ensure that the code is already in the right place.
This change moves the invocation of Codegen to the react-native's core-cli-utils so that frameworks can integrate better with it.
It should also make it easier to migrate away from Cocoapods.
## Changelog:
[iOS][Changed] - Invoke Codegen as part of the Core-cli-utils package
Differential Revision: D68706136
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48965/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48965/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48964
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48964/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48964/comments
|
https://api.github.com/repos/facebook/react-native/issues/48964/events
|
https://github.com/facebook/react-native/pull/48964
| 2,812,714,929
|
PR_kwDOAbrxp86JEY7o
| 48,964
|
Optimize data structure to store listeners in EventTarget
|
{
"login": "rubennorte",
"id": 117921,
"node_id": "MDQ6VXNlcjExNzkyMQ==",
"avatar_url": "https://avatars.githubusercontent.com/u/117921?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rubennorte",
"html_url": "https://github.com/rubennorte",
"followers_url": "https://api.github.com/users/rubennorte/followers",
"following_url": "https://api.github.com/users/rubennorte/following{/other_user}",
"gists_url": "https://api.github.com/users/rubennorte/gists{/gist_id}",
"starred_url": "https://api.github.com/users/rubennorte/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rubennorte/subscriptions",
"organizations_url": "https://api.github.com/users/rubennorte/orgs",
"repos_url": "https://api.github.com/users/rubennorte/repos",
"events_url": "https://api.github.com/users/rubennorte/events{/privacy}",
"received_events_url": "https://api.github.com/users/rubennorte/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 3
| 2025-01-27T11:07:37
| 2025-01-31T12:05:55
| 2025-01-31T12:04:44
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48964",
"html_url": "https://github.com/facebook/react-native/pull/48964",
"diff_url": "https://github.com/facebook/react-native/pull/48964.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48964.patch",
"merged_at": null
}
|
Changelog: [internal]
This replaces the data structure used to store listeners in `EventTarget`, from a map of arrays to a map of maps.
This essentially optimizes listener registration/deregistraton at the expense of event dispatching. Given that it'll be common to have many nodes registering to events that are never dispatched, this might be the right trade-off.
* Before:
| (index) | Task name | Latency average (ns) | Latency median (ns) | Throughput average (ops/s) | Throughput median (ops/s) | Samples |
| ------- | --------------------------------------------------------------------- | --------------------- | ---------------------- | -------------------------- | ------------------------- | ------- |
| 0 | 'dispatchEvent, no bubbling, no listeners' | '4624.68 ± 0.49%' | '4570.00' | '218089 ± 0.02%' | '218818' | 216232 |
| 1 | 'dispatchEvent, no bubbling, single listener' | '5771.34 ± 0.99%' | '5670.00' | '175389 ± 0.02%' | '176367' | 173270 |
| 2 | 'dispatchEvent, no bubbling, multiple listeners' | '48207.35 ± 1.18%' | '47290.00' | '20964 ± 0.04%' | '21146' | 20744 |
| 3 | 'dispatchEvent, bubbling, no listeners' | '185005.29 ± 0.16%' | '184060.00' | '5410 ± 0.05%' | '5433' | 5406 |
| 4 | 'dispatchEvent, bubbling, single listener per target' | '286630.57 ± 0.11%' | '285560.00' | '3491 ± 0.06%' | '3502' | 3489 |
| 5 | 'dispatchEvent, bubbling, multiple listeners per target' | '4435944.62 ± 0.27%' | '4425840.00 ± 30.00' | '226 ± 0.12%' | '226' | 1000 |
| 6 | 'addEventListener, one listener' | '1734.88 ± 0.57%' | '1670.00' | '594938 ± 0.01%' | '598802' | 576411 |
| 7 | 'addEventListener, one target, one type, multiple listeners' | '266031.11 ± 0.68%' | '261810.00' | '3781 ± 0.15%' | '3820' | 3759 |
| 8 | 'addEventListener, one target, multiple types, one listener per type' | '124768.56 ± 0.39%' | '121160.00' | '8112 ± 0.16%' | '8254' | 8015 |
| 9 | 'addEventListener, one target, multiple types, multiple listeners' | '27141326.31 ± 0.15%' | '27298945.00 ± 115.00' | '37 ± 0.15%' | '37' | 1000 |
| 10 | 'addEventListener, multiple targets, one type, one listener' | '142646.24 ± 0.49%' | '137460.00' | '7123 ± 0.19%' | '7275' | 7011 |
* After:
| (index) | Task name | Latency average (ns) | Latency median (ns) | Throughput average (ops/s) | Throughput median (ops/s) | Samples |
| ------- | --------------------------------------------------------------------- | --------------------- | --------------------- | -------------------------- | ------------------------- | ------- |
| 0 | 'dispatchEvent, no bubbling, no listeners' | '4518.27 ± 0.51%' | '4460.00' | '223269 ± 0.02%' | '224215' | 221324 |
| 1 | 'dispatchEvent, no bubbling, single listener' | '6563.10 ± 0.98%' | '6450.00' | '154311 ± 0.02%' | '155039' | 152367 |
| 2 | 'dispatchEvent, no bubbling, multiple listeners' | '65429.69 ± 0.25%' | '64840.00' | '15330 ± 0.05%' | '15423' | 15284 |
| 3 | 'dispatchEvent, bubbling, no listeners' | '181104.21 ± 0.13%' | '180300.00' | '5525 ± 0.05%' | '5546' | 5522 |
| 4 | 'dispatchEvent, bubbling, single listener per target' | '367231.05 ± 0.10%' | '366035.00 ± 5.00' | '2724 ± 0.07%' | '2732' | 2724 |
| 5 | 'dispatchEvent, bubbling, multiple listeners per target' | '6269141.58 ± 0.24%' | '6253275.00 ± 155.00' | '160 ± 0.11%' | '160' | 1000 |
| 6 | 'addEventListener, one listener' | '1665.23 ± 0.51%' | '1610.00' | '618122 ± 0.01%' | '621118' | 600517 |
| 7 | 'addEventListener, one target, one type, multiple listeners' | '97724.12 ± 1.34%' | '94640.00' | '10433 ± 0.14%' | '10566' | 10233 |
| 8 | 'addEventListener, one target, multiple types, one listener per type' | '116915.60 ± 0.54%' | '113380.00' | '8707 ± 0.17%' | '8820' | 8554 |
| 9 | 'addEventListener, one target, multiple types, multiple listeners' | '12276537.38 ± 0.42%' | '11924070.00 ± 10.00' | '82 ± 0.35%' | '84' | 1000 |
| 10 | 'addEventListener, multiple targets, one type, one listener' | '133307.67 ± 0.58%' | '128340.00' | '7666 ± 0.20%' | '7792' | 7502 |
Differential Revision: D68671944
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48964/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48964/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48963
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48963/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48963/comments
|
https://api.github.com/repos/facebook/react-native/issues/48963/events
|
https://github.com/facebook/react-native/pull/48963
| 2,812,708,310
|
PR_kwDOAbrxp86JEXew
| 48,963
|
Roll out 6.1.0 on fbsource
|
{
"login": "hoxyq",
"id": 28902667,
"node_id": "MDQ6VXNlcjI4OTAyNjY3",
"avatar_url": "https://avatars.githubusercontent.com/u/28902667?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hoxyq",
"html_url": "https://github.com/hoxyq",
"followers_url": "https://api.github.com/users/hoxyq/followers",
"following_url": "https://api.github.com/users/hoxyq/following{/other_user}",
"gists_url": "https://api.github.com/users/hoxyq/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hoxyq/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hoxyq/subscriptions",
"organizations_url": "https://api.github.com/users/hoxyq/orgs",
"repos_url": "https://api.github.com/users/hoxyq/repos",
"events_url": "https://api.github.com/users/hoxyq/events{/privacy}",
"received_events_url": "https://api.github.com/users/hoxyq/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 4
| 2025-01-27T11:04:42
| 2025-01-28T16:41:29
| 2025-01-28T16:41:17
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48963",
"html_url": "https://github.com/facebook/react-native/pull/48963",
"diff_url": "https://github.com/facebook/react-native/pull/48963.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48963.patch",
"merged_at": null
}
|
Summary:
# Changelog:
[General] [Changed] - upgrade React DevTools to 6.1.0.
allow-large-files
Differential Revision: D68705543
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48963/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48963/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48962
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48962/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48962/comments
|
https://api.github.com/repos/facebook/react-native/issues/48962/events
|
https://github.com/facebook/react-native/pull/48962
| 2,812,636,890
|
PR_kwDOAbrxp86JEHxL
| 48,962
|
Move all properties of EventTarget to symbols to avoid polluting the global scope
|
{
"login": "rubennorte",
"id": 117921,
"node_id": "MDQ6VXNlcjExNzkyMQ==",
"avatar_url": "https://avatars.githubusercontent.com/u/117921?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rubennorte",
"html_url": "https://github.com/rubennorte",
"followers_url": "https://api.github.com/users/rubennorte/followers",
"following_url": "https://api.github.com/users/rubennorte/following{/other_user}",
"gists_url": "https://api.github.com/users/rubennorte/gists{/gist_id}",
"starred_url": "https://api.github.com/users/rubennorte/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rubennorte/subscriptions",
"organizations_url": "https://api.github.com/users/rubennorte/orgs",
"repos_url": "https://api.github.com/users/rubennorte/repos",
"events_url": "https://api.github.com/users/rubennorte/events{/privacy}",
"received_events_url": "https://api.github.com/users/rubennorte/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 4
| 2025-01-27T10:32:06
| 2025-01-27T15:54:30
| 2025-01-27T15:53:47
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48962",
"html_url": "https://github.com/facebook/react-native/pull/48962",
"diff_url": "https://github.com/facebook/react-native/pull/48962.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48962.patch",
"merged_at": null
}
|
Summary:
Changelog: [internal]
We moved away from private fields for `EventTarget` for performance, in favor of normal fields prefixed with underscore, but this would pollute the global scope when we make it extend `EventTarget`.
This refactors the implementation to use symbols for all properties to avoid that problem, leaving only `addEventListener` and `removeEventListener` as regular properties in the prototype.
Differential Revision: D68672215
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48962/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48962/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48961
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48961/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48961/comments
|
https://api.github.com/repos/facebook/react-native/issues/48961/events
|
https://github.com/facebook/react-native/pull/48961
| 2,812,585,499
|
PR_kwDOAbrxp86JD8hh
| 48,961
|
Stop running Codegen on Pod install when a flag is passed
|
{
"login": "cipolleschi",
"id": 11162307,
"node_id": "MDQ6VXNlcjExMTYyMzA3",
"avatar_url": "https://avatars.githubusercontent.com/u/11162307?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cipolleschi",
"html_url": "https://github.com/cipolleschi",
"followers_url": "https://api.github.com/users/cipolleschi/followers",
"following_url": "https://api.github.com/users/cipolleschi/following{/other_user}",
"gists_url": "https://api.github.com/users/cipolleschi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cipolleschi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cipolleschi/subscriptions",
"organizations_url": "https://api.github.com/users/cipolleschi/orgs",
"repos_url": "https://api.github.com/users/cipolleschi/repos",
"events_url": "https://api.github.com/users/cipolleschi/events{/privacy}",
"received_events_url": "https://api.github.com/users/cipolleschi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 5
| 2025-01-27T10:09:18
| 2025-01-27T14:56:36
| 2025-01-27T14:56:23
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48961",
"html_url": "https://github.com/facebook/react-native/pull/48961",
"diff_url": "https://github.com/facebook/react-native/pull/48961.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48961.patch",
"merged_at": null
}
|
Summary:
One of Cocoapods responsibility is to run Codegen while creating the Xcode workspace. Moving away from Cocoapods, this is a step we need to move to a different place.
This change let us to disable running codegen at cocoapods time when we pass the `RCT_SKIP_CODEGEN=1` or when we pass the `RCT_IGNORE_PODS_DEPRECATION=1` flag calling pod install.
When calling `pod install` with `RCT_IGNORE_PODS_DEPRECATION` we are either:
* using one of the Scripts provided by Expo or by the Community CLI
*or*
* we are preparing the project using the legacy mode and, therefore, we want to keep running codegen.
## Changelog
[iOS][Changed] - Stop running codegen when running pod install
Differential Revision: D68704604
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48961/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48961/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48960
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48960/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48960/comments
|
https://api.github.com/repos/facebook/react-native/issues/48960/events
|
https://github.com/facebook/react-native/pull/48960
| 2,812,585,462
|
PR_kwDOAbrxp86JD8hA
| 48,960
|
Warn users when calling pod install
|
{
"login": "cipolleschi",
"id": 11162307,
"node_id": "MDQ6VXNlcjExMTYyMzA3",
"avatar_url": "https://avatars.githubusercontent.com/u/11162307?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cipolleschi",
"html_url": "https://github.com/cipolleschi",
"followers_url": "https://api.github.com/users/cipolleschi/followers",
"following_url": "https://api.github.com/users/cipolleschi/following{/other_user}",
"gists_url": "https://api.github.com/users/cipolleschi/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cipolleschi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cipolleschi/subscriptions",
"organizations_url": "https://api.github.com/users/cipolleschi/orgs",
"repos_url": "https://api.github.com/users/cipolleschi/repos",
"events_url": "https://api.github.com/users/cipolleschi/events{/privacy}",
"received_events_url": "https://api.github.com/users/cipolleschi/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 8
| 2025-01-27T10:09:17
| 2025-04-09T13:46:26
| 2025-01-27T14:56:22
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48960",
"html_url": "https://github.com/facebook/react-native/pull/48960",
"diff_url": "https://github.com/facebook/react-native/pull/48960.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48960.patch",
"merged_at": null
}
|
Summary:
We are moving away from Cocoapods toward alternative solution.
We are adding this deprecation message to help inform our users that this change is happening.
Part of the Cocoapods tasks will be moved to an alternative script that will be invoked by Expo and by the Community CLI. The warning message tells the users what to do as an alternative to `pod install`.
## Changelog:
[iOS][Deprecated] - deprecate calling `pod install` directly
Differential Revision: D68704127
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48960/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48960/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48959
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48959/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48959/comments
|
https://api.github.com/repos/facebook/react-native/issues/48959/events
|
https://github.com/facebook/react-native/issues/48959
| 2,812,323,261
|
I_kwDOAbrxp86noKW9
| 48,959
|
[iOS] Runtime not ready: Invariant Violation with NativeEventEmitter in React Native
|
{
"login": "rakshitbharat",
"id": 17176729,
"node_id": "MDQ6VXNlcjE3MTc2NzI5",
"avatar_url": "https://avatars.githubusercontent.com/u/17176729?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rakshitbharat",
"html_url": "https://github.com/rakshitbharat",
"followers_url": "https://api.github.com/users/rakshitbharat/followers",
"following_url": "https://api.github.com/users/rakshitbharat/following{/other_user}",
"gists_url": "https://api.github.com/users/rakshitbharat/gists{/gist_id}",
"starred_url": "https://api.github.com/users/rakshitbharat/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rakshitbharat/subscriptions",
"organizations_url": "https://api.github.com/users/rakshitbharat/orgs",
"repos_url": "https://api.github.com/users/rakshitbharat/repos",
"events_url": "https://api.github.com/users/rakshitbharat/events{/privacy}",
"received_events_url": "https://api.github.com/users/rakshitbharat/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 257497884,
"node_id": "MDU6TGFiZWwyNTc0OTc4ODQ=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Platform:%20iOS",
"name": "Platform: iOS",
"color": "1d76db",
"default": false,
"description": "iOS applications."
},
{
"id": 1794376073,
"node_id": "MDU6TGFiZWwxNzk0Mzc2MDcz",
"url": "https://api.github.com/repos/facebook/react-native/labels/Needs:%20Repro",
"name": "Needs: Repro",
"color": "d4c5f9",
"default": false,
"description": "This issue could be improved with a clear list of steps to reproduce the issue."
},
{
"id": 1877909121,
"node_id": "MDU6TGFiZWwxODc3OTA5MTIx",
"url": "https://api.github.com/repos/facebook/react-native/labels/Needs:%20Attention",
"name": "Needs: Attention",
"color": "f9c884",
"default": false,
"description": "Issues where the author has responded to feedback."
},
{
"id": 5191728962,
"node_id": "LA_kwDOAbrxp88AAAABNXN_Qg",
"url": "https://api.github.com/repos/facebook/react-native/labels/Needs:%20Version%20Info",
"name": "Needs: Version Info",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 10
| 2025-01-27T08:01:35
| 2025-01-28T21:19:15
| 2025-01-28T08:26:22
|
NONE
| null | null | null | null |
---
title: '[iOS] Runtime not ready: Invariant Violation with NativeEventEmitter in React Native'
labels: ['bug', 'ios', 'needs-triage']
---
## Description
We're encountering an `Invariant Violation` error when trying to create a `NativeEventEmitter` in our React Native iOS app. The error suggests that the runtime is not ready when attempting to create the event emitter. This issue appears to be iOS-specific and is related to the timing of native module initialization. The error doesn't occur on Android.
## Environment
- React Native Version: 0.77.0
- React Version: 18.3.1
- iOS Version: 18.2 (SDK)
- Device: iOS Simulator/Physical Device
- Development Environment: macOS 15.2
- Node Version: 20.18.1
- Xcode Version: 16.2/16C5032a
- CocoaPods Version: 1.16.2
- New Architecture: Enabled (newArchEnabled: true)
- Hermes: Disabled on iOS, Enabled on Android
## Steps to Reproduce
1. Start a React Native app on iOS
2. Try to create a NativeEventEmitter for any native module
3. The app crashes with the following error:
```
[runtime not ready]: Invariant Violation: `new NativeEventEmitter()` requires a non-null argument.
invariant
&platform=ios&dev=true&lazy=true&minify=false&inlineSourceMap=false&modulesOnly=false&runModule=true&app=com.automind.v4:4931:25
NativeEventEmitter
&platform=ios&dev=true&lazy=true&minify=false&inlineSourceMap=false&modulesOnly=false&runModule=true&app=com.automind.v4:37118:31
```
## Current Behavior
The app crashes on iOS with a runtime not ready error when trying to initialize any NativeEventEmitter. The error suggests that the JavaScript runtime is not ready when the event emitter is being created. This is particularly problematic with the New Architecture enabled.
## Expected Behavior
The NativeEventEmitter initialization should either:
1. Wait for the runtime to be ready before allowing event emitter creation
2. Handle the case where the runtime isn't ready yet gracefully
3. Provide a clear way to check if the runtime is ready before creating event emitters
## Attempted Solutions
We've tried several approaches to work around this issue:
1. Lazy initialization of the event emitter
2. Checking for module existence before creating the emitter
3. Adding error handling around emitter creation
4. Using Platform-specific code for iOS
5. Enabling/Disabling Hermes on iOS (currently disabled)
However, the issue persists, suggesting this might be a deeper issue with how the React Native runtime initializes on iOS, particularly with the New Architecture enabled.
## Code Example
Here's a minimal reproduction of the issue:
```javascript
import {NativeEventEmitter, NativeModules} from 'react-native';
// This line causes the error on iOS during app startup
const eventEmitter = new NativeEventEmitter(NativeModules.SomeModule);
```
Even with defensive programming:
```javascript
const getEmitter = () => {
if (!NativeModules.SomeModule) {
console.warn('Native module not available');
return null;
}
try {
return new NativeEventEmitter(NativeModules.SomeModule);
} catch (error) {
console.error('Failed to create event emitter:', error);
return null;
}
};
```
## Additional Context
- This issue only occurs on iOS
- The error happens during the initial load of the app
- Android works as expected with the same code
- The issue seems related to the timing of runtime initialization
- We're using the New Architecture in React Native (newArchEnabled: true)
- The issue persists regardless of Hermes being enabled or disabled on iOS
- All development tools and SDKs are up to date:
- Watchman: 2024.12.02.00
- CocoaPods: 1.16.2
- Node: 20.18.1
- npm: 10.8.2
## Questions
1. Is there a recommended way to handle runtime initialization timing on iOS with the New Architecture?
2. Should there be a way to check if the runtime is ready before creating an event emitter?
3. Is this a known issue with the New Architecture and iOS?
4. Are there any workarounds or best practices for handling event emitter creation during app startup with the New Architecture?
5. Could this be related to the Hermes configuration difference between iOS and Android?
## Relevant Information
- [React Native New Architecture Documentation](https://reactnative.dev/docs/new-architecture-intro)
- [NativeEventEmitter Documentation](https://reactnative.dev/docs/native-modules-ios#sending-events-to-javascript)
- [React Native 0.77.0 Release Notes](https://reactnative.dev/blog/2024/03/06/0.77-new-styling-features-android-16kb-page-support-swift-template)
|
{
"login": "rakshitbharat",
"id": 17176729,
"node_id": "MDQ6VXNlcjE3MTc2NzI5",
"avatar_url": "https://avatars.githubusercontent.com/u/17176729?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rakshitbharat",
"html_url": "https://github.com/rakshitbharat",
"followers_url": "https://api.github.com/users/rakshitbharat/followers",
"following_url": "https://api.github.com/users/rakshitbharat/following{/other_user}",
"gists_url": "https://api.github.com/users/rakshitbharat/gists{/gist_id}",
"starred_url": "https://api.github.com/users/rakshitbharat/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rakshitbharat/subscriptions",
"organizations_url": "https://api.github.com/users/rakshitbharat/orgs",
"repos_url": "https://api.github.com/users/rakshitbharat/repos",
"events_url": "https://api.github.com/users/rakshitbharat/events{/privacy}",
"received_events_url": "https://api.github.com/users/rakshitbharat/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48959/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48959/timeline
| null |
completed
|
{
"total": 0,
"completed": 0,
"percent_completed": 0
}
| false
|
https://api.github.com/repos/facebook/react-native/issues/48958
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48958/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48958/comments
|
https://api.github.com/repos/facebook/react-native/issues/48958/events
|
https://github.com/facebook/react-native/pull/48958
| 2,812,260,521
|
PR_kwDOAbrxp86JC2Qg
| 48,958
|
Add OkHttpClientProvider tests
|
{
"login": "mateoguzmana",
"id": 20783123,
"node_id": "MDQ6VXNlcjIwNzgzMTIz",
"avatar_url": "https://avatars.githubusercontent.com/u/20783123?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mateoguzmana",
"html_url": "https://github.com/mateoguzmana",
"followers_url": "https://api.github.com/users/mateoguzmana/followers",
"following_url": "https://api.github.com/users/mateoguzmana/following{/other_user}",
"gists_url": "https://api.github.com/users/mateoguzmana/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mateoguzmana/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mateoguzmana/subscriptions",
"organizations_url": "https://api.github.com/users/mateoguzmana/orgs",
"repos_url": "https://api.github.com/users/mateoguzmana/repos",
"events_url": "https://api.github.com/users/mateoguzmana/events{/privacy}",
"received_events_url": "https://api.github.com/users/mateoguzmana/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 3253537094,
"node_id": "MDU6TGFiZWwzMjUzNTM3MDk0",
"url": "https://api.github.com/repos/facebook/react-native/labels/Shared%20with%20Meta",
"name": "Shared with Meta",
"color": "BFD4F2",
"default": false,
"description": "Applied via automation to indicate that an Issue or Pull Request has been shared with the team."
}
] |
closed
| false
| null |
[] | null | 6
| 2025-01-27T07:21:50
| 2025-01-28T14:08:54
| 2025-01-28T14:08:43
|
COLLABORATOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48958",
"html_url": "https://github.com/facebook/react-native/pull/48958",
"diff_url": "https://github.com/facebook/react-native/pull/48958.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48958.patch",
"merged_at": null
}
|
## Summary:
Currently, the class OkHttpClientProvider is still in Java. Adding some tests before migrating it to Kotlin
## Changelog:
[INTERNAL] - Add OkHttpClientProvider tests
## Test Plan:
```bash
./gradlew :packages:react-native:ReactAndroid:test -Dtest.single=com.facebook.react.modules.network
```
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48958/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48958/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48957
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48957/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48957/comments
|
https://api.github.com/repos/facebook/react-native/issues/48957/events
|
https://github.com/facebook/react-native/issues/48957
| 2,812,203,362
|
I_kwDOAbrxp86nntFi
| 48,957
|
[0.76] Project with custom C++ code - Crashes with EarlyJsError: TurboModuleRegistry.getEnforcing(...): 'PlatformConstants' could not be found. Verify that a module by this name is registered in the native binary
|
{
"login": "usmanbajwa878",
"id": 47910818,
"node_id": "MDQ6VXNlcjQ3OTEwODE4",
"avatar_url": "https://avatars.githubusercontent.com/u/47910818?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/usmanbajwa878",
"html_url": "https://github.com/usmanbajwa878",
"followers_url": "https://api.github.com/users/usmanbajwa878/followers",
"following_url": "https://api.github.com/users/usmanbajwa878/following{/other_user}",
"gists_url": "https://api.github.com/users/usmanbajwa878/gists{/gist_id}",
"starred_url": "https://api.github.com/users/usmanbajwa878/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/usmanbajwa878/subscriptions",
"organizations_url": "https://api.github.com/users/usmanbajwa878/orgs",
"repos_url": "https://api.github.com/users/usmanbajwa878/repos",
"events_url": "https://api.github.com/users/usmanbajwa878/events{/privacy}",
"received_events_url": "https://api.github.com/users/usmanbajwa878/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 1261489149,
"node_id": "MDU6TGFiZWwxMjYxNDg5MTQ5",
"url": "https://api.github.com/repos/facebook/react-native/labels/Resolution:%20Duplicate",
"name": "Resolution: Duplicate",
"color": "ffffff",
"default": false,
"description": ""
},
{
"id": 1794148631,
"node_id": "MDU6TGFiZWwxNzk0MTQ4NjMx",
"url": "https://api.github.com/repos/facebook/react-native/labels/Needs:%20Author%20Feedback",
"name": "Needs: Author Feedback",
"color": "d4c5f9",
"default": false,
"description": ""
},
{
"id": 1794376073,
"node_id": "MDU6TGFiZWwxNzk0Mzc2MDcz",
"url": "https://api.github.com/repos/facebook/react-native/labels/Needs:%20Repro",
"name": "Needs: Repro",
"color": "d4c5f9",
"default": false,
"description": "This issue could be improved with a clear list of steps to reproduce the issue."
},
{
"id": 1794380150,
"node_id": "MDU6TGFiZWwxNzk0MzgwMTUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/Newer%20Patch%20Available",
"name": "Newer Patch Available",
"color": "d4c5f9",
"default": false,
"description": ""
},
{
"id": 3815166274,
"node_id": "LA_kwDOAbrxp87jZtFC",
"url": "https://api.github.com/repos/facebook/react-native/labels/Type:%20New%20Architecture",
"name": "Type: New Architecture",
"color": "f9d0c4",
"default": false,
"description": "Issues and PRs related to new architecture (Fabric/Turbo Modules)"
}
] |
closed
| false
| null |
[] | null | 4
| 2025-01-27T06:41:56
| 2025-01-27T11:27:32
| 2025-01-27T11:27:28
|
NONE
| null | null | null | null |
### Description
I am upgrading react native version from 0.72.6 to 0.76.5 in my project working fine with ios. however not for android.
the versions I am using for the kotlin is:
ndkVersion = "26.1.10909125"
kotlinVersion = "1.9.24"
### Steps to reproduce
npm install
android appis building as soon as app runs got this error
### React Native Version
0.76.5
### Affected Platforms
Runtime - Android
### Areas
TurboModule - The New Native Module System
### Output of `npx react-native info`
```text
System:
OS: macOS 14.3.1
CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
Memory: 3.04 GB / 32.00 GB
Shell:
version: "5.9"
path: /bin/zsh
Binaries:
Node:
version: 21.6.1
path: ~/.nvm/versions/node/v21.6.1/bin/node
Yarn:
version: 4.6.0
path: ~/.nvm/versions/node/v21.6.1/bin/yarn
npm:
version: 10.2.4
path: ~/.nvm/versions/node/v21.6.1/bin/npm
Watchman:
version: 2024.12.02.00
path: /usr/local/bin/watchman
Managers:
CocoaPods:
version: 1.16.2
path: /Users/usmanbajwa/.rvm/gems/ruby-2.7.8/bin/pod
SDKs:
iOS SDK:
Platforms:
- DriverKit 23.2
- iOS 17.2
- macOS 14.2
- tvOS 17.2
- visionOS 1.0
- watchOS 10.2
Android SDK: Not Found
IDEs:
Android Studio: 2024.2 AI-242.23339.11.2421.12700392
Xcode:
version: 15.2/15C500b
path: /usr/bin/xcodebuild
Languages:
Java:
version: 17.0.12
path: /usr/bin/javac
Ruby:
version: 2.7.8
path: /Users/usmanbajwa/.rvm/rubies/ruby-2.7.8/bin/ruby
npmPackages:
"@react-native-community/cli": Not Found
react: Not Found
react-native: Not Found
react-native-macos: Not Found
npmGlobalPackages:
"*react-native*": Not Found
Android:
hermesEnabled: true
newArchEnabled: true
iOS:
hermesEnabled: true
newArchEnabled: true
```
### Stacktrace or Logs
```text
Exception in native call from JS
com.facebook.react.common.JavascriptException: EarlyJsError: TurboModuleRegistry.getEnforcing(...): 'PlatformConstants' could not be found. Verify that a module by this name is registered in the native binary., stack:
invariant@1:112015
getEnforcing@1:119085
anonymous@1:118625
loadModuleImplementation@1:82146
guardedLoadModule@1:81670
metroRequire@1:81300
anonymous@1:117618
loadModuleImplementation@1:82146
guardedLoadModule@1:81670
metroRequire@1:81300
anonymous@1:117234
loadModuleImplementation@1:82146
guardedLoadModule@1:81670
metroRequire@1:81300
anonymous@1:123444
loadModuleImplementation@1:82146
guardedLoadModule@1:81670
metroRequire@1:81300
anonymous@1:122283
loadModuleImplementation@1:82146
guardedLoadModule@1:81670
metroRequire@1:81300
anonymous@1:320703
loadModuleImplementation@1:82146
guardedLoadModule@1:81670
metroRequire@1:81300
anonymous@1:319643
loadModuleImplementation@1:82146
guardedLoadModule@1:81670
metroRequire@1:81300
anonymous@1:318247
loadModuleImplementation@1:82146
guardedLoadModule@1:81670
metroRequire@1:81300
anonymous@1:317437
loadModuleImplementation@1:82146
guardedLoadModule@1:81670
metroRequire@1:81300
anonymous@1:317201
loadModuleImplementation@1:82146
guardedLoadModule@1:81670
metroRequire@1:81300
anonymous@1:315261
loadModuleImplementation@1:82146
guardedLoadModule@1:81670
metroRequire@1:81300
anonymous@1:307179
loadModuleImplementation@1:82146
guardedLoadModule@1:81670
metroRequire@1:81300
anonymous@1:208120
loadModuleImplementation@1:82146
guardedLoadModule@1:81627
metroRequire@1:81300
global@1:80817
at com.facebook.react.modules.core.ExceptionsManagerModule.reportException(ExceptionsManagerModule.kt:52)
```
### Reproducer
private_repo
### Screenshots and Videos
[](url)
|
{
"login": "cortinico",
"id": 3001957,
"node_id": "MDQ6VXNlcjMwMDE5NTc=",
"avatar_url": "https://avatars.githubusercontent.com/u/3001957?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cortinico",
"html_url": "https://github.com/cortinico",
"followers_url": "https://api.github.com/users/cortinico/followers",
"following_url": "https://api.github.com/users/cortinico/following{/other_user}",
"gists_url": "https://api.github.com/users/cortinico/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cortinico/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cortinico/subscriptions",
"organizations_url": "https://api.github.com/users/cortinico/orgs",
"repos_url": "https://api.github.com/users/cortinico/repos",
"events_url": "https://api.github.com/users/cortinico/events{/privacy}",
"received_events_url": "https://api.github.com/users/cortinico/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48957/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48957/timeline
| null |
completed
|
{
"total": 0,
"completed": 0,
"percent_completed": 0
}
| false
|
https://api.github.com/repos/facebook/react-native/issues/48956
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48956/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48956/comments
|
https://api.github.com/repos/facebook/react-native/issues/48956/events
|
https://github.com/facebook/react-native/issues/48956
| 2,812,177,948
|
I_kwDOAbrxp86nnm4c
| 48,956
|
React Native App crashes after changing the bundle location
|
{
"login": "techie-sdvyas",
"id": 86183476,
"node_id": "MDQ6VXNlcjg2MTgzNDc2",
"avatar_url": "https://avatars.githubusercontent.com/u/86183476?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/techie-sdvyas",
"html_url": "https://github.com/techie-sdvyas",
"followers_url": "https://api.github.com/users/techie-sdvyas/followers",
"following_url": "https://api.github.com/users/techie-sdvyas/following{/other_user}",
"gists_url": "https://api.github.com/users/techie-sdvyas/gists{/gist_id}",
"starred_url": "https://api.github.com/users/techie-sdvyas/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/techie-sdvyas/subscriptions",
"organizations_url": "https://api.github.com/users/techie-sdvyas/orgs",
"repos_url": "https://api.github.com/users/techie-sdvyas/repos",
"events_url": "https://api.github.com/users/techie-sdvyas/events{/privacy}",
"received_events_url": "https://api.github.com/users/techie-sdvyas/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 1794148631,
"node_id": "MDU6TGFiZWwxNzk0MTQ4NjMx",
"url": "https://api.github.com/repos/facebook/react-native/labels/Needs:%20Author%20Feedback",
"name": "Needs: Author Feedback",
"color": "d4c5f9",
"default": false,
"description": ""
},
{
"id": 1794376073,
"node_id": "MDU6TGFiZWwxNzk0Mzc2MDcz",
"url": "https://api.github.com/repos/facebook/react-native/labels/Needs:%20Repro",
"name": "Needs: Repro",
"color": "d4c5f9",
"default": false,
"description": "This issue could be improved with a clear list of steps to reproduce the issue."
},
{
"id": 5381829209,
"node_id": "LA_kwDOAbrxp88AAAABQMgyWQ",
"url": "https://api.github.com/repos/facebook/react-native/labels/%F0%9F%93%A6Bundler",
"name": "📦Bundler",
"color": "ededed",
"default": false,
"description": null
},
{
"id": 5727401455,
"node_id": "LA_kwDOAbrxp88AAAABVWE17w",
"url": "https://api.github.com/repos/facebook/react-native/labels/Type:%20Too%20Old%20Version",
"name": "Type: Too Old Version",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 4
| 2025-01-27T06:22:49
| 2025-05-09T06:51:39
| 2025-01-27T06:23:02
|
NONE
| null | null | null | null |
### Description
I have upgraded my React Native version from 0.66 to 0.72, by creating a new React Native template of 0.72 and merge code from the original project.
I have also changed the compile and target SDK to 34 from 33.
When I run app from Android Studio the app crashes immediately after launch.
I have also tried, bundle js code and then change the bundle location to the localhost where metro bundle server is running, but this also results in the app crash.
Note,
This is the first issue I am posting to Github, so Please guide me and correct my mistakes, Thanks.
### Steps to reproduce
Without js code bundle,
1. Install dependencies
2. Start metro bundler
3. Run app from Android Studio
With js code bundle,
1. Install dependencies
2. npx react-native bundle --platform android --dev true --entry-file index.js --bundle-output android/app/src/main/assets/index.android.bundle --assets-dest android/app/src/main/res
3. Start metro bundler
4. Run app from Android Studio
### React Native Version
0.72.0
### Affected Platforms
Runtime - Android
### Output of `npx react-native info`
```text
'''
System:
OS: Windows 11 10.0.22631
CPU: (8) x64 Intel(R) Core(TM) i5-8350U CPU @ 1.70GHz
Memory: 2.07 GB / 15.81 GB
Binaries:
Node:
version: 20.10.0
path: C:\Program Files\nodejs\node.EXE
Yarn: Not Found
npm:
version: 10.2.3
path: C:\Program Files\nodejs\npm.CMD
Watchman: Not Found
SDKs:
Android SDK:
API Levels:
- "28"
- "29"
- "30"
- "31"
- "33"
- "34"
Build Tools:
- 28.0.3
- 29.0.3
- 30.0.2
- 30.0.3
- 31.0.0
- 33.0.1
- 34.0.0
System Images:
- android-28 | Google APIs Intel x86_64 Atom
- android-34 | Google APIs Intel x86_64 Atom
Android NDK: Not Found
Windows SDK: Not Found
IDEs:
Android Studio: AI-241.18034.62.2411.12071903
Visual Studio: Not Found
Languages:
Java:
version: 11.0.22
path: /cygdrive/c/Program Files/Java/jdk-11/bin/javac
Ruby: Not Found
npmPackages:
"@react-native-community/cli": Not Found
react:
installed: 18.2.0
wanted: 18.2.0
react-native:
installed: 0.72.0
wanted: 0.72.0
react-native-windows: Not Found
npmGlobalPackages:
"*react-native*": Not Found
Android:
hermesEnabled: true
newArchEnabled: false
iOS:
hermesEnabled: Not found
newArchEnabled: Not found
'''
```
### Stacktrace or Logs
```text
Without js code bundle,
FATAL EXCEPTION: create_react_context
Process: com.mass_storage_mobile_app, PID: 14441
java.lang.RuntimeException: Unable to load script. Make sure you're either running Metro (run 'npx react-native start') or that your bundle 'index.android.bundle' is packaged correctly for release.
at com.facebook.react.bridge.CatalystInstanceImpl.jniLoadScriptFromAssets(Native Method)
at com.facebook.react.bridge.CatalystInstanceImpl.loadScriptFromAssets(CatalystInstanceImpl.java:239)
at com.facebook.react.bridge.JSBundleLoader$1.loadScript(JSBundleLoader.java:29)
at com.facebook.react.bridge.CatalystInstanceImpl.runJSBundle(CatalystInstanceImpl.java:268)
at com.facebook.react.ReactInstanceManager.createReactContext(ReactInstanceManager.java:1413)
at com.facebook.react.ReactInstanceManager.-$$Nest$mcreateReactContext(Unknown Source:0)
at com.facebook.react.ReactInstanceManager$5.run(ReactInstanceManager.java:1111)
at java.lang.Thread.run(Thread.java:1012)
-----------------------------------------------------------------------------------------------------------------------
With js code bundle,
FATAL EXCEPTION: main
Process: com.mass_storage_mobile_app, PID: 12271
java.lang.NullPointerException: Attempt to invoke interface method 'void com.facebook.react.devsupport.interfaces.DevLoadingViewManager.showMessage(java.lang.String)' on a null object reference
at com.facebook.react.devsupport.DevSupportManagerBase.showDevLoadingViewForUrl(DevSupportManagerBase.java:792)
at com.facebook.react.devsupport.DevSupportManagerBase.reloadJSFromServer(DevSupportManagerBase.java:984)
at com.facebook.react.devsupport.DevSupportManagerBase.reloadJSFromServer(DevSupportManagerBase.java:965)
at com.facebook.react.devsupport.BridgeDevSupportManager.handleReloadJS(BridgeDevSupportManager.java:242)
at com.facebook.react.devsupport.DevSupportManagerBase$10$1.onClick(DevSupportManagerBase.java:465)
at com.android.internal.app.AlertController$ButtonHandler.handleMessage(AlertController.java:192)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loopOnce(Looper.java:257)
at android.os.Looper.loop(Looper.java:368)
at android.app.ActivityThread.main(ActivityThread.java:8839)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:572)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1049)
```
### Reproducer
Unable to reproduce
### Screenshots and Videos
_No response_
|
{
"login": "react-native-bot",
"id": 32686087,
"node_id": "MDQ6VXNlcjMyNjg2MDg3",
"avatar_url": "https://avatars.githubusercontent.com/u/32686087?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/react-native-bot",
"html_url": "https://github.com/react-native-bot",
"followers_url": "https://api.github.com/users/react-native-bot/followers",
"following_url": "https://api.github.com/users/react-native-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/react-native-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/react-native-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/react-native-bot/subscriptions",
"organizations_url": "https://api.github.com/users/react-native-bot/orgs",
"repos_url": "https://api.github.com/users/react-native-bot/repos",
"events_url": "https://api.github.com/users/react-native-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/react-native-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48956/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48956/timeline
| null |
completed
|
{
"total": 0,
"completed": 0,
"percent_completed": 0
}
| false
|
https://api.github.com/repos/facebook/react-native/issues/48955
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48955/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48955/comments
|
https://api.github.com/repos/facebook/react-native/issues/48955/events
|
https://github.com/facebook/react-native/issues/48955
| 2,812,160,693
|
I_kwDOAbrxp86nniq1
| 48,955
|
[0.76] Project with custom C++ code - Crashes with EarlyJsError: TurboModuleRegistry.getEnforcing(...): 'PlatformConstants' could not be found. Verify that a module by this name is registered in the native binary
|
{
"login": "usmanbajwa878",
"id": 47910818,
"node_id": "MDQ6VXNlcjQ3OTEwODE4",
"avatar_url": "https://avatars.githubusercontent.com/u/47910818?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/usmanbajwa878",
"html_url": "https://github.com/usmanbajwa878",
"followers_url": "https://api.github.com/users/usmanbajwa878/followers",
"following_url": "https://api.github.com/users/usmanbajwa878/following{/other_user}",
"gists_url": "https://api.github.com/users/usmanbajwa878/gists{/gist_id}",
"starred_url": "https://api.github.com/users/usmanbajwa878/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/usmanbajwa878/subscriptions",
"organizations_url": "https://api.github.com/users/usmanbajwa878/orgs",
"repos_url": "https://api.github.com/users/usmanbajwa878/repos",
"events_url": "https://api.github.com/users/usmanbajwa878/events{/privacy}",
"received_events_url": "https://api.github.com/users/usmanbajwa878/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 1794148631,
"node_id": "MDU6TGFiZWwxNzk0MTQ4NjMx",
"url": "https://api.github.com/repos/facebook/react-native/labels/Needs:%20Author%20Feedback",
"name": "Needs: Author Feedback",
"color": "d4c5f9",
"default": false,
"description": ""
},
{
"id": 1794376073,
"node_id": "MDU6TGFiZWwxNzk0Mzc2MDcz",
"url": "https://api.github.com/repos/facebook/react-native/labels/Needs:%20Repro",
"name": "Needs: Repro",
"color": "d4c5f9",
"default": false,
"description": "This issue could be improved with a clear list of steps to reproduce the issue."
},
{
"id": 5727401455,
"node_id": "LA_kwDOAbrxp88AAAABVWE17w",
"url": "https://api.github.com/repos/facebook/react-native/labels/Type:%20Too%20Old%20Version",
"name": "Type: Too Old Version",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 3
| 2025-01-27T06:09:10
| 2025-01-27T06:10:20
| 2025-01-27T06:09:25
|
NONE
| null | null | null | null |
### Description
I am upgrading the react native from version 0.72.6 to 76.5 with the necessary changes build is succssful but on the app startup I got the issue with error screen.
I am using the kotlin version 1.9.24
### Steps to reproduce
npm install
build on android
### React Native Version
0.76.5
### Affected Platforms
Runtime - Android
### Output of `npx react-native info`
```text
System:
OS: macOS 14.3.1
CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
Memory: 3.04 GB / 32.00 GB
Shell:
version: "5.9"
path: /bin/zsh
Binaries:
Node:
version: 21.6.1
path: ~/.nvm/versions/node/v21.6.1/bin/node
Yarn:
version: 4.6.0
path: ~/.nvm/versions/node/v21.6.1/bin/yarn
npm:
version: 10.2.4
path: ~/.nvm/versions/node/v21.6.1/bin/npm
Watchman:
version: 2024.12.02.00
path: /usr/local/bin/watchman
Managers:
CocoaPods:
version: 1.16.2
path: /Users/usmanbajwa/.rvm/gems/ruby-2.7.8/bin/pod
SDKs:
iOS SDK:
Platforms:
- DriverKit 23.2
- iOS 17.2
- macOS 14.2
- tvOS 17.2
- visionOS 1.0
- watchOS 10.2
Android SDK: Not Found
IDEs:
Android Studio: 2024.2 AI-242.23339.11.2421.12700392
Xcode:
version: 15.2/15C500b
path: /usr/bin/xcodebuild
Languages:
Java:
version: 17.0.12
path: /usr/bin/javac
Ruby:
version: 2.7.8
path: /Users/usmanbajwa/.rvm/rubies/ruby-2.7.8/bin/ruby
npmPackages:
"@react-native-community/cli": Not Found
react: Not Found
react-native: Not Found
react-native-macos: Not Found
npmGlobalPackages:
"*react-native*": Not Found
Android:
hermesEnabled: true
newArchEnabled: true
iOS:
hermesEnabled: true
newArchEnabled: true
```
### Stacktrace or Logs
```text
Exception in native call from JS
com.facebook.react.common.JavascriptException: EarlyJsError: TurboModuleRegistry.getEnforcing(...): 'PlatformConstants' could not be found. Verify that a module by this name is registered in the native binary., stack:
invariant@1:112015
getEnforcing@1:119085
anonymous@1:118625
loadModuleImplementation@1:82146
guardedLoadModule@1:81670
metroRequire@1:81300
anonymous@1:117618
loadModuleImplementation@1:82146
guardedLoadModule@1:81670
metroRequire@1:81300
anonymous@1:117234
loadModuleImplementation@1:82146
guardedLoadModule@1:81670
metroRequire@1:81300
anonymous@1:123444
loadModuleImplementation@1:82146
guardedLoadModule@1:81670
metroRequire@1:81300
anonymous@1:122283
loadModuleImplementation@1:82146
guardedLoadModule@1:81670
metroRequire@1:81300
anonymous@1:320703
loadModuleImplementation@1:82146
guardedLoadModule@1:81670
metroRequire@1:81300
anonymous@1:319643
loadModuleImplementation@1:82146
guardedLoadModule@1:81670
metroRequire@1:81300
anonymous@1:318247
loadModuleImplementation@1:82146
guardedLoadModule@1:81670
metroRequire@1:81300
anonymous@1:317437
loadModuleImplementation@1:82146
guardedLoadModule@1:81670
metroRequire@1:81300
anonymous@1:317201
loadModuleImplementation@1:82146
guardedLoadModule@1:81670
metroRequire@1:81300
anonymous@1:315261
loadModuleImplementation@1:82146
guardedLoadModule@1:81670
metroRequire@1:81300
anonymous@1:307179
loadModuleImplementation@1:82146
guardedLoadModule@1:81670
metroRequire@1:81300
anonymous@1:208120
loadModuleImplementation@1:82146
guardedLoadModule@1:81627
metroRequire@1:81300
global@1:80817
at com.facebook.react.modules.core.ExceptionsManagerModule.reportException(ExceptionsManagerModule.kt:52)
```
### Reproducer
private_repo
### Screenshots and Videos
_No response_
|
{
"login": "react-native-bot",
"id": 32686087,
"node_id": "MDQ6VXNlcjMyNjg2MDg3",
"avatar_url": "https://avatars.githubusercontent.com/u/32686087?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/react-native-bot",
"html_url": "https://github.com/react-native-bot",
"followers_url": "https://api.github.com/users/react-native-bot/followers",
"following_url": "https://api.github.com/users/react-native-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/react-native-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/react-native-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/react-native-bot/subscriptions",
"organizations_url": "https://api.github.com/users/react-native-bot/orgs",
"repos_url": "https://api.github.com/users/react-native-bot/repos",
"events_url": "https://api.github.com/users/react-native-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/react-native-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48955/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48955/timeline
| null |
completed
|
{
"total": 0,
"completed": 0,
"percent_completed": 0
}
| false
|
https://api.github.com/repos/facebook/react-native/issues/48954
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48954/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48954/comments
|
https://api.github.com/repos/facebook/react-native/issues/48954/events
|
https://github.com/facebook/react-native/issues/48954
| 2,811,860,898
|
I_kwDOAbrxp86nmZei
| 48,954
|
RN Modal backdrop prop is not defined
|
{
"login": "kimkong88",
"id": 22599874,
"node_id": "MDQ6VXNlcjIyNTk5ODc0",
"avatar_url": "https://avatars.githubusercontent.com/u/22599874?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/kimkong88",
"html_url": "https://github.com/kimkong88",
"followers_url": "https://api.github.com/users/kimkong88/followers",
"following_url": "https://api.github.com/users/kimkong88/following{/other_user}",
"gists_url": "https://api.github.com/users/kimkong88/gists{/gist_id}",
"starred_url": "https://api.github.com/users/kimkong88/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kimkong88/subscriptions",
"organizations_url": "https://api.github.com/users/kimkong88/orgs",
"repos_url": "https://api.github.com/users/kimkong88/repos",
"events_url": "https://api.github.com/users/kimkong88/events{/privacy}",
"received_events_url": "https://api.github.com/users/kimkong88/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 1113219646,
"node_id": "MDU6TGFiZWwxMTEzMjE5NjQ2",
"url": "https://api.github.com/repos/facebook/react-native/labels/Component:%20Modal",
"name": "Component: Modal",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 1794148631,
"node_id": "MDU6TGFiZWwxNzk0MTQ4NjMx",
"url": "https://api.github.com/repos/facebook/react-native/labels/Needs:%20Author%20Feedback",
"name": "Needs: Author Feedback",
"color": "d4c5f9",
"default": false,
"description": ""
},
{
"id": 1794376073,
"node_id": "MDU6TGFiZWwxNzk0Mzc2MDcz",
"url": "https://api.github.com/repos/facebook/react-native/labels/Needs:%20Repro",
"name": "Needs: Repro",
"color": "d4c5f9",
"default": false,
"description": "This issue could be improved with a clear list of steps to reproduce the issue."
},
{
"id": 4139937040,
"node_id": "LA_kwDOAbrxp872wm0Q",
"url": "https://api.github.com/repos/facebook/react-native/labels/Resolution:%20Answered",
"name": "Resolution: Answered",
"color": "C2E0C6",
"default": false,
"description": "When the issue is resolved with a simple answer"
},
{
"id": 5191728962,
"node_id": "LA_kwDOAbrxp88AAAABNXN_Qg",
"url": "https://api.github.com/repos/facebook/react-native/labels/Needs:%20Version%20Info",
"name": "Needs: Version Info",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 6
| 2025-01-27T00:12:46
| 2025-01-27T16:53:54
| 2025-01-27T16:53:50
|
NONE
| null | null | null | null |
### Description
Using RN version 0.76.
https://reactnative.dev/docs/modal says we have backdropColor props
but backdropColor props don't exist in ModalBaseProps (or IOS/Android)
Is it accidentally omitted?
### Steps to reproduce
1. Use Modal from React Native.
2. Try to set backdropColor as specified in https://reactnative.dev/docs/modal
### React Native Version
0.76
### Affected Platforms
Build - Windows, Build - MacOS
### Output of `npx react-native info`
```text
N/A
```
### Stacktrace or Logs
```text
N/A
```
### Reproducer
N/A
### Screenshots and Videos
|
{
"login": "cortinico",
"id": 3001957,
"node_id": "MDQ6VXNlcjMwMDE5NTc=",
"avatar_url": "https://avatars.githubusercontent.com/u/3001957?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cortinico",
"html_url": "https://github.com/cortinico",
"followers_url": "https://api.github.com/users/cortinico/followers",
"following_url": "https://api.github.com/users/cortinico/following{/other_user}",
"gists_url": "https://api.github.com/users/cortinico/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cortinico/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cortinico/subscriptions",
"organizations_url": "https://api.github.com/users/cortinico/orgs",
"repos_url": "https://api.github.com/users/cortinico/repos",
"events_url": "https://api.github.com/users/cortinico/events{/privacy}",
"received_events_url": "https://api.github.com/users/cortinico/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48954/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48954/timeline
| null |
completed
|
{
"total": 0,
"completed": 0,
"percent_completed": 0
}
| false
|
https://api.github.com/repos/facebook/react-native/issues/48953
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48953/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48953/comments
|
https://api.github.com/repos/facebook/react-native/issues/48953/events
|
https://github.com/facebook/react-native/issues/48953
| 2,811,746,228
|
I_kwDOAbrxp86nl9e0
| 48,953
|
Classpath's can't be resolved on a new project
|
{
"login": "ssavran",
"id": 163865296,
"node_id": "U_kgDOCcRi0A",
"avatar_url": "https://avatars.githubusercontent.com/u/163865296?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/ssavran",
"html_url": "https://github.com/ssavran",
"followers_url": "https://api.github.com/users/ssavran/followers",
"following_url": "https://api.github.com/users/ssavran/following{/other_user}",
"gists_url": "https://api.github.com/users/ssavran/gists{/gist_id}",
"starred_url": "https://api.github.com/users/ssavran/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ssavran/subscriptions",
"organizations_url": "https://api.github.com/users/ssavran/orgs",
"repos_url": "https://api.github.com/users/ssavran/repos",
"events_url": "https://api.github.com/users/ssavran/events{/privacy}",
"received_events_url": "https://api.github.com/users/ssavran/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 1794376073,
"node_id": "MDU6TGFiZWwxNzk0Mzc2MDcz",
"url": "https://api.github.com/repos/facebook/react-native/labels/Needs:%20Repro",
"name": "Needs: Repro",
"color": "d4c5f9",
"default": false,
"description": "This issue could be improved with a clear list of steps to reproduce the issue."
},
{
"id": 1877909121,
"node_id": "MDU6TGFiZWwxODc3OTA5MTIx",
"url": "https://api.github.com/repos/facebook/react-native/labels/Needs:%20Attention",
"name": "Needs: Attention",
"color": "f9c884",
"default": false,
"description": "Issues where the author has responded to feedback."
},
{
"id": 4139937040,
"node_id": "LA_kwDOAbrxp872wm0Q",
"url": "https://api.github.com/repos/facebook/react-native/labels/Resolution:%20Answered",
"name": "Resolution: Answered",
"color": "C2E0C6",
"default": false,
"description": "When the issue is resolved with a simple answer"
},
{
"id": 5191728962,
"node_id": "LA_kwDOAbrxp88AAAABNXN_Qg",
"url": "https://api.github.com/repos/facebook/react-native/labels/Needs:%20Version%20Info",
"name": "Needs: Version Info",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 6
| 2025-01-26T19:27:49
| 2025-01-27T18:46:42
| 2025-01-27T18:46:38
|
NONE
| null | null | null | null |
### Description
When using classpath 'com.facebook.react:react-native-gradle-plugin' in build.gradle without a version, Gradle fails to resolve the dependency. Setting explicit versions (e.g., 8.1.1 for com.android.tools.build:gradle and $kotlinVersion for kotlin-gradle-plugin) resolves those dependencies, but setting the version matching the React Native version (e.g., 0.77.0 for react-native-gradle-plugin) still fails.
It's a new created project, and the only thing I added to the dependencies is the google-services:4.3.15 and don't understand why it can't be resolved...
### Steps to reproduce
That's the build.gradle I got with a new react-native project (v 0.77):
```
buildscript {
ext {
buildToolsVersion = "35.0.0"
minSdkVersion = 24
compileSdkVersion = 35
targetSdkVersion = 34
ndkVersion = "27.1.12297006"
kotlinVersion = "2.0.21"
}
repositories {
google()
mavenCentral()
}
dependencies {
classpath 'com.google.gms:google-services:4.3.15'
classpath("com.android.tools.build:gradle")
classpath("com.facebook.react:react-native-gradle-plugin")
classpath("org.jetbrains.kotlin:kotlin-gradle-plugin")
}
}
apply plugin: "com.facebook.react.rootproject"
```
These are my devDependencies at package.json:
```
"devDependencies": {
"@babel/core": "^7.25.2",
"@babel/preset-env": "^7.25.3",
"@babel/runtime": "^7.25.0",
"@react-native-community/cli": "15.0.1",
"@react-native-community/cli-platform-android": "15.0.1",
"@react-native-community/cli-platform-ios": "15.0.1",
"@react-native/babel-preset": "0.77.0",
"@react-native/eslint-config": "0.77.0",
"@react-native/metro-config": "0.77.0",
"@react-native/typescript-config": "0.77.0",
"@types/jest": "^29.5.13",
"@types/react": "^18.2.6",
"@types/react-test-renderer": "^18.0.0",
"eslint": "^8.19.0",
"jest": "^29.6.3",
"prettier": "2.8.8",
"react-test-renderer": "18.3.1",
"typescript": "5.0.4"
}
```
### React Native Version
0.77.0
### Affected Platforms
Runtime - Android
### Output of `npx react-native info`
```text
info Fetching system and libraries information...
System:
OS: macOS 15.2
CPU: (11) arm64 Apple M3 Pro
Memory: 200.33 MB / 36.00 GB
Shell:
version: "5.9"
path: /bin/zsh
Binaries:
Node:
version: 20.10.0
path: /usr/local/bin/node
Yarn:
version: 1.22.22
path: /usr/local/bin/yarn
npm:
version: 10.2.3
path: /usr/local/bin/npm
Watchman:
version: 2024.11.18.00
path: /opt/homebrew/bin/watchman
Managers:
CocoaPods:
version: 1.16.2
path: /opt/homebrew/bin/pod
SDKs:
iOS SDK:
Platforms:
- DriverKit 24.2
- iOS 18.2
- macOS 15.2
- tvOS 18.2
- visionOS 2.2
- watchOS 11.2
Android SDK: Not Found
IDEs:
Android Studio: 2023.1 AI-231.9392.1.2311.11330709
Xcode:
version: 16.2/16C5032a
path: /usr/bin/xcodebuild
Languages:
Java:
version: 17.0.10
path: /usr/bin/javac
Ruby:
version: 2.6.10
path: /usr/bin/ruby
npmPackages:
"@react-native-community/cli":
installed: 15.0.1
wanted: 15.0.1
react:
installed: 18.3.1
wanted: 18.3.1
react-native:
installed: 0.77.0
wanted: 0.77.0
react-native-macos: Not Found
npmGlobalPackages:
"*react-native*": Not Found
Android:
hermesEnabled: true
newArchEnabled: true
iOS:
hermesEnabled: true
newArchEnabled: true
```
### Stacktrace or Logs
```text
A problem occurred configuring root project 'AwesomeProject'.
> Could not resolve all artifacts for configuration ':classpath'.
> Could not find com.android.tools.build:gradle:.
Required by:
root project :
> Could not find com.facebook.react:react-native-gradle-plugin:.
Required by:
root project :
> Could not find org.jetbrains.kotlin:kotlin-gradle-plugin:.
Required by:
root project :
Possible solution:
- Declare repository providing the artifact, see the documentation at https://docs.gradle.org/current/userguide/declaring_repositories.html
```
### Reproducer
https://github.com/facebook/react-native
### Screenshots and Videos
_No response_
|
{
"login": "cortinico",
"id": 3001957,
"node_id": "MDQ6VXNlcjMwMDE5NTc=",
"avatar_url": "https://avatars.githubusercontent.com/u/3001957?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cortinico",
"html_url": "https://github.com/cortinico",
"followers_url": "https://api.github.com/users/cortinico/followers",
"following_url": "https://api.github.com/users/cortinico/following{/other_user}",
"gists_url": "https://api.github.com/users/cortinico/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cortinico/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cortinico/subscriptions",
"organizations_url": "https://api.github.com/users/cortinico/orgs",
"repos_url": "https://api.github.com/users/cortinico/repos",
"events_url": "https://api.github.com/users/cortinico/events{/privacy}",
"received_events_url": "https://api.github.com/users/cortinico/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48953/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48953/timeline
| null |
completed
|
{
"total": 0,
"completed": 0,
"percent_completed": 0
}
| false
|
https://api.github.com/repos/facebook/react-native/issues/48952
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48952/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48952/comments
|
https://api.github.com/repos/facebook/react-native/issues/48952/events
|
https://github.com/facebook/react-native/pull/48952
| 2,811,553,955
|
PR_kwDOAbrxp86JAh-4
| 48,952
|
[IOS][NewArch] fix TextInput `dataDetectorTypes`
|
{
"login": "VidocqH",
"id": 16725418,
"node_id": "MDQ6VXNlcjE2NzI1NDE4",
"avatar_url": "https://avatars.githubusercontent.com/u/16725418?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/VidocqH",
"html_url": "https://github.com/VidocqH",
"followers_url": "https://api.github.com/users/VidocqH/followers",
"following_url": "https://api.github.com/users/VidocqH/following{/other_user}",
"gists_url": "https://api.github.com/users/VidocqH/gists{/gist_id}",
"starred_url": "https://api.github.com/users/VidocqH/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/VidocqH/subscriptions",
"organizations_url": "https://api.github.com/users/VidocqH/orgs",
"repos_url": "https://api.github.com/users/VidocqH/repos",
"events_url": "https://api.github.com/users/VidocqH/events{/privacy}",
"received_events_url": "https://api.github.com/users/VidocqH/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 3253537094,
"node_id": "MDU6TGFiZWwzMjUzNTM3MDk0",
"url": "https://api.github.com/repos/facebook/react-native/labels/Shared%20with%20Meta",
"name": "Shared with Meta",
"color": "BFD4F2",
"default": false,
"description": "Applied via automation to indicate that an Issue or Pull Request has been shared with the team."
}
] |
closed
| false
| null |
[] | null | 3
| 2025-01-26T13:15:37
| 2025-01-28T13:49:04
| 2025-01-28T13:18:27
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48952",
"html_url": "https://github.com/facebook/react-native/pull/48952",
"diff_url": "https://github.com/facebook/react-native/pull/48952.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48952.patch",
"merged_at": null
}
|
## Summary:
Setting `dataDetectorTypes` has no effect. As I am new to the react native codebase, it seems like `dataDetectorTypes` has not implemented on new arch yet.
issue: #48951
## Changelog:
[IOS] [FIXED] - implement `dataDetectorTypes` in the same way as the old architecture
## Test Plan:
<img width="356" alt="image" src="https://github.com/user-attachments/assets/192a683c-f7b7-48ac-98cd-76866901f008" />
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48952/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48952/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48951
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48951/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48951/comments
|
https://api.github.com/repos/facebook/react-native/issues/48951/events
|
https://github.com/facebook/react-native/issues/48951
| 2,811,552,548
|
I_kwDOAbrxp86nlOMk
| 48,951
|
[IOS][New Arch] TextInput `dataDetectorTypes` has no effect
|
{
"login": "VidocqH",
"id": 16725418,
"node_id": "MDQ6VXNlcjE2NzI1NDE4",
"avatar_url": "https://avatars.githubusercontent.com/u/16725418?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/VidocqH",
"html_url": "https://github.com/VidocqH",
"followers_url": "https://api.github.com/users/VidocqH/followers",
"following_url": "https://api.github.com/users/VidocqH/following{/other_user}",
"gists_url": "https://api.github.com/users/VidocqH/gists{/gist_id}",
"starred_url": "https://api.github.com/users/VidocqH/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/VidocqH/subscriptions",
"organizations_url": "https://api.github.com/users/VidocqH/orgs",
"repos_url": "https://api.github.com/users/VidocqH/repos",
"events_url": "https://api.github.com/users/VidocqH/events{/privacy}",
"received_events_url": "https://api.github.com/users/VidocqH/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 257497884,
"node_id": "MDU6TGFiZWwyNTc0OTc4ODQ=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Platform:%20iOS",
"name": "Platform: iOS",
"color": "1d76db",
"default": false,
"description": "iOS applications."
},
{
"id": 542043367,
"node_id": "MDU6TGFiZWw1NDIwNDMzNjc=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Issue:%20Author%20Provided%20Repro",
"name": "Issue: Author Provided Repro",
"color": "0e8a16",
"default": false,
"description": "This issue can be reproduced in Snack or an attached project."
},
{
"id": 869668024,
"node_id": "MDU6TGFiZWw4Njk2NjgwMjQ=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Component:%20TextInput",
"name": "Component: TextInput",
"color": "fef2c0",
"default": false,
"description": "Related to the TextInput component."
},
{
"id": 872682019,
"node_id": "MDU6TGFiZWw4NzI2ODIwMTk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Resolution:%20Fixed",
"name": "Resolution: Fixed",
"color": "0e8a16",
"default": false,
"description": "A PR that fixes this issue has been merged."
},
{
"id": 3815166274,
"node_id": "LA_kwDOAbrxp87jZtFC",
"url": "https://api.github.com/repos/facebook/react-native/labels/Type:%20New%20Architecture",
"name": "Type: New Architecture",
"color": "f9d0c4",
"default": false,
"description": "Issues and PRs related to new architecture (Fabric/Turbo Modules)"
}
] |
closed
| false
| null |
[] | null | 0
| 2025-01-26T13:12:40
| 2025-01-28T14:19:32
| 2025-01-28T13:48:30
|
CONTRIBUTOR
| null | null | null | null |
### Description
Setting `dataDetectorTypes` for a not-editable multiline TextInput doesn't work
It works on old arch
### Steps to reproduce
1. Create new arch ios project
2. Add a TextInput with `multiine={false}`, `defaultValue='num: 88888888'`, `editable={false}` and `dataDetectorTypes='phoneNumber'`
### React Native Version
0.76.6
### Affected Platforms
Runtime - iOS
### Areas
Fabric - The New Renderer
### Output of `npx react-native info`
```text
System:
OS: macOS 15.1
CPU: (8) arm64 Apple M1
Memory: 124.48 MB / 16.00 GB
Shell:
version: "5.9"
path: /bin/zsh
Binaries:
Node:
version: 20.15.1
path: ~/.nvm/versions/node/v20.15.1/bin/node
Yarn:
version: 1.22.22
path: ~/.nvm/versions/node/v20.15.1/bin/yarn
npm:
version: 10.7.0
path: ~/.nvm/versions/node/v20.15.1/bin/npm
Watchman:
version: 2024.12.02.00
path: /opt/homebrew/bin/watchman
Managers:
CocoaPods:
version: 1.16.1
path: /opt/homebrew/bin/pod
SDKs:
iOS SDK:
Platforms:
- DriverKit 24.0
- iOS 18.0
- macOS 15.0
- tvOS 18.0
- visionOS 2.0
- watchOS 11.0
Android SDK:
API Levels:
- "34"
- "35"
Build Tools:
- 34.0.0
- 35.0.0
System Images:
- android-35 | Google Play ARM 64 v8a
Android NDK: Not Found
IDEs:
Android Studio: 2024.1 AI-241.15989.150.2411.11948838
Xcode:
version: 16.0/16A242d
path: /usr/bin/xcodebuild
Languages:
Java:
version: 17.0.13
path: /usr/bin/javac
Ruby:
version: 2.6.10
path: /usr/bin/ruby
npmPackages:
"@react-native-community/cli":
installed: 15.1.3
wanted: ^15.1.3
react:
installed: 18.3.1
wanted: 18.3.1
react-native:
installed: 0.76.6
wanted: 0.76.6
react-native-macos: Not Found
npmGlobalPackages:
"*react-native*": Not Found
Android:
hermesEnabled: true
newArchEnabled: true
iOS:
hermesEnabled: true
newArchEnabled: true
```
### Stacktrace or Logs
```text
Empty
```
### Reproducer
https://github.com/VidocqH/rn-textinput-dataDetectorTypes/blob/main/ReproducerApp/App.tsx
### Screenshots and Videos
_No response_
|
{
"login": "VidocqH",
"id": 16725418,
"node_id": "MDQ6VXNlcjE2NzI1NDE4",
"avatar_url": "https://avatars.githubusercontent.com/u/16725418?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/VidocqH",
"html_url": "https://github.com/VidocqH",
"followers_url": "https://api.github.com/users/VidocqH/followers",
"following_url": "https://api.github.com/users/VidocqH/following{/other_user}",
"gists_url": "https://api.github.com/users/VidocqH/gists{/gist_id}",
"starred_url": "https://api.github.com/users/VidocqH/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/VidocqH/subscriptions",
"organizations_url": "https://api.github.com/users/VidocqH/orgs",
"repos_url": "https://api.github.com/users/VidocqH/repos",
"events_url": "https://api.github.com/users/VidocqH/events{/privacy}",
"received_events_url": "https://api.github.com/users/VidocqH/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48951/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48951/timeline
| null |
completed
|
{
"total": 0,
"completed": 0,
"percent_completed": 0
}
| false
|
https://api.github.com/repos/facebook/react-native/issues/48950
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48950/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48950/comments
|
https://api.github.com/repos/facebook/react-native/issues/48950/events
|
https://github.com/facebook/react-native/issues/48950
| 2,811,544,632
|
I_kwDOAbrxp86nlMQ4
| 48,950
|
React Codegen Command PhaseScriptExecution failed with a nonzero exit code
|
{
"login": "MohammadHasanRN",
"id": 131749853,
"node_id": "U_kgDOB9pX3Q",
"avatar_url": "https://avatars.githubusercontent.com/u/131749853?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/MohammadHasanRN",
"html_url": "https://github.com/MohammadHasanRN",
"followers_url": "https://api.github.com/users/MohammadHasanRN/followers",
"following_url": "https://api.github.com/users/MohammadHasanRN/following{/other_user}",
"gists_url": "https://api.github.com/users/MohammadHasanRN/gists{/gist_id}",
"starred_url": "https://api.github.com/users/MohammadHasanRN/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/MohammadHasanRN/subscriptions",
"organizations_url": "https://api.github.com/users/MohammadHasanRN/orgs",
"repos_url": "https://api.github.com/users/MohammadHasanRN/repos",
"events_url": "https://api.github.com/users/MohammadHasanRN/events{/privacy}",
"received_events_url": "https://api.github.com/users/MohammadHasanRN/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 470324689,
"node_id": "MDU6TGFiZWw0NzAzMjQ2ODk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Resolution:%20For%20Stack%20Overflow",
"name": "Resolution: For Stack Overflow",
"color": "d4c5f9",
"default": false,
"description": "A question for Stack Overflow. Applying this label will cause issue to be closed."
},
{
"id": 1794376073,
"node_id": "MDU6TGFiZWwxNzk0Mzc2MDcz",
"url": "https://api.github.com/repos/facebook/react-native/labels/Needs:%20Repro",
"name": "Needs: Repro",
"color": "d4c5f9",
"default": false,
"description": "This issue could be improved with a clear list of steps to reproduce the issue."
},
{
"id": 1877909121,
"node_id": "MDU6TGFiZWwxODc3OTA5MTIx",
"url": "https://api.github.com/repos/facebook/react-native/labels/Needs:%20Attention",
"name": "Needs: Attention",
"color": "f9c884",
"default": false,
"description": "Issues where the author has responded to feedback."
}
] |
closed
| false
| null |
[] | null | 24
| 2025-01-26T12:55:41
| 2025-05-05T15:56:08
| 2025-01-27T18:48:41
|
NONE
| null | null | null | null |
### Description
"react": "18.3.1",
"react-native": "0.77.0",
"Node": "23.3.0"
I am trying to build IOS on new project, but getting error with react codegen
I didn't add a single line of code, pr any packages
### Steps to reproduce
1. Create React Native project "not expo"
2. open xcode and try to export a new build
### React Native Version
0.77.0
### Affected Platforms
Build - MacOS, Runtime - iOS
### Output of `npx react-native info`
```text
(node:66368) ExperimentalWarning: CommonJS module /opt/homebrew/lib/node_modules/npm/node_modules/debug/src/node.js is loading ES Module /opt/homebrew/lib/node_modules/npm/node_modules/supports-color/index.js using require().
Support for loading ES Module in require() is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
info Fetching system and libraries information...
System:
OS: macOS 15.1.1
CPU: (12) arm64 Apple M2 Max
Memory: 1.47 GB / 32.00 GB
Shell:
version: "5.9"
path: /bin/zsh
Binaries:
Node:
version: 23.3.0
path: /opt/homebrew/bin/node
Yarn:
version: 1.22.19
path: /opt/homebrew/bin/yarn
npm:
version: 10.9.0
path: /opt/homebrew/bin/npm
Watchman:
version: 2024.12.02.00
path: /opt/homebrew/bin/watchman
Managers:
CocoaPods:
version: 1.16.2
path: /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms:
- DriverKit 24.1
- iOS 18.1
- macOS 15.1
- tvOS 18.1
- visionOS 2.1
- watchOS 11.1
Android SDK: Not Found
IDEs:
Android Studio: 2022.1 AI-221.6008.13.2211.9619390
Xcode:
version: 16.1/16B40
path: /usr/bin/xcodebuild
Languages:
Java:
version: 17.0.13
path: /usr/bin/javac
Ruby:
version: 2.6.10
path: /usr/bin/ruby
npmPackages:
"@react-native-community/cli":
installed: 15.0.1
wanted: 15.0.1
react:
installed: 18.3.1
wanted: 18.3.1
react-native:
installed: 0.77.0
wanted: 0.77.0
react-native-macos: Not Found
npmGlobalPackages:
"*react-native*": Not Found
Android:
hermesEnabled: true
newArchEnabled: true
iOS:
hermesEnabled: true
newArchEnabled: true
```
### Stacktrace or Logs
```text
IOS building "React Codegen Command PhaseScriptExecution failed with a nonzero exit code"
```
### Reproducer
Not Available
### Screenshots and Videos
_No response_
|
{
"login": "react-native-bot",
"id": 32686087,
"node_id": "MDQ6VXNlcjMyNjg2MDg3",
"avatar_url": "https://avatars.githubusercontent.com/u/32686087?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/react-native-bot",
"html_url": "https://github.com/react-native-bot",
"followers_url": "https://api.github.com/users/react-native-bot/followers",
"following_url": "https://api.github.com/users/react-native-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/react-native-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/react-native-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/react-native-bot/subscriptions",
"organizations_url": "https://api.github.com/users/react-native-bot/orgs",
"repos_url": "https://api.github.com/users/react-native-bot/repos",
"events_url": "https://api.github.com/users/react-native-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/react-native-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48950/reactions",
"total_count": 2,
"+1": 2,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48950/timeline
| null |
completed
|
{
"total": 0,
"completed": 0,
"percent_completed": 0
}
| false
|
https://api.github.com/repos/facebook/react-native/issues/48949
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48949/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48949/comments
|
https://api.github.com/repos/facebook/react-native/issues/48949/events
|
https://github.com/facebook/react-native/issues/48949
| 2,811,464,578
|
I_kwDOAbrxp86nk4uC
| 48,949
|
AppState listener not called after app being in the background for 20 minutes (iOS)
|
{
"login": "martinnov92",
"id": 15011249,
"node_id": "MDQ6VXNlcjE1MDExMjQ5",
"avatar_url": "https://avatars.githubusercontent.com/u/15011249?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/martinnov92",
"html_url": "https://github.com/martinnov92",
"followers_url": "https://api.github.com/users/martinnov92/followers",
"following_url": "https://api.github.com/users/martinnov92/following{/other_user}",
"gists_url": "https://api.github.com/users/martinnov92/gists{/gist_id}",
"starred_url": "https://api.github.com/users/martinnov92/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/martinnov92/subscriptions",
"organizations_url": "https://api.github.com/users/martinnov92/orgs",
"repos_url": "https://api.github.com/users/martinnov92/repos",
"events_url": "https://api.github.com/users/martinnov92/events{/privacy}",
"received_events_url": "https://api.github.com/users/martinnov92/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 257497884,
"node_id": "MDU6TGFiZWwyNTc0OTc4ODQ=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Platform:%20iOS",
"name": "Platform: iOS",
"color": "1d76db",
"default": false,
"description": "iOS applications."
},
{
"id": 1113219694,
"node_id": "MDU6TGFiZWwxMTEzMjE5Njk0",
"url": "https://api.github.com/repos/facebook/react-native/labels/API:%20AppState",
"name": "API: AppState",
"color": "fef2c0",
"default": false,
"description": ""
},
{
"id": 1794148631,
"node_id": "MDU6TGFiZWwxNzk0MTQ4NjMx",
"url": "https://api.github.com/repos/facebook/react-native/labels/Needs:%20Author%20Feedback",
"name": "Needs: Author Feedback",
"color": "d4c5f9",
"default": false,
"description": ""
},
{
"id": 5021085328,
"node_id": "LA_kwDOAbrxp88AAAABK0eukA",
"url": "https://api.github.com/repos/facebook/react-native/labels/Type:%20Unsupported%20Version",
"name": "Type: Unsupported Version",
"color": "ffffff",
"default": false,
"description": "Issues reported to a version of React Native that is no longer supported"
}
] |
closed
| false
| null |
[] | null | 3
| 2025-01-26T11:05:28
| 2025-05-15T07:43:05
| 2025-01-26T13:56:12
|
NONE
| null | null | null | null |
### Description
Hello,
It seems there's an issue with the `AppState` listener on iOS. When the app goes to the background for an extended period and then returns, the `AppState` `change` event is not triggered. As a result, the UI becomes unresponsive — you can scroll, but buttons aren't clickable. If you stay on that screen for some time, the app eventually crashes.
### Steps to reproduce
```js
import React, {useRef, useState, useEffect} from 'react';
import {AppState, StyleSheet, Text} from 'react-native';
import {SafeAreaView, SafeAreaProvider} from 'react-native-safe-area-context';
const AppStateExample = () => {
const appState = useRef(AppState.currentState);
const [appStateVisible, setAppStateVisible] = useState(appState.current);
useEffect(() => {
const subscription = AppState.addEventListener('change', nextAppState => {
if (
appState.current.match(/inactive|background/) &&
nextAppState === 'active'
) {
console.log('App has come to the foreground!');
}
appState.current = nextAppState;
setAppStateVisible(appState.current);
console.log('AppState', appState.current);
});
return () => {
subscription.remove();
};
}, []);
return (
<SafeAreaProvider>
<SafeAreaView style={styles.container}>
<Text>Current state is: {appStateVisible}</Text>
<Button title="Button" onPress={() => {console.log('press')}} />
</SafeAreaView>
</SafeAreaProvider>
);
};
const styles = StyleSheet.create({
container: {
flex: 1,
justifyContent: 'center',
alignItems: 'center',
},
});
export default AppStateExample;
```
### React Native Version
0.73.7
### Affected Platforms
Runtime - iOS
### Output of `npx react-native info`
```text
System:
OS: macOS 15.2
CPU: (10) arm64 Apple M1 Pro
Memory: 694.63 MB / 16.00 GB
Shell:
version: "5.9"
path: /bin/zsh
Binaries:
Node:
version: 20.12.2
path: ~/.nvm/versions/node/v20.12.2/bin/node
Yarn:
version: 1.22.17
path: /opt/homebrew/bin/yarn
npm:
version: 10.5.0
path: ~/.nvm/versions/node/v20.12.2/bin/npm
Watchman:
version: 2024.12.02.00
path: /opt/homebrew/bin/watchman
Managers:
CocoaPods:
version: 1.16.2
path: /opt/homebrew/bin/pod
SDKs:
iOS SDK:
Platforms:
- DriverKit 24.2
- iOS 18.2
- macOS 15.2
- tvOS 18.2
- visionOS 2.2
- watchOS 11.2
Android SDK:
Android NDK: 21.4.7075529
IDEs:
Android Studio: 2024.1 AI-241.18034.62.2411.12071903
Xcode:
version: 16.2/16C5032a
path: /usr/bin/xcodebuild
Languages:
Java:
version: 17.0.13
path: /opt/homebrew/opt/openjdk@17/bin/javac
Ruby:
version: 3.3.6
path: /opt/homebrew/opt/ruby/bin/ruby
npmPackages:
"@react-native-community/cli": Not Found
react:
installed: 18.2.0
wanted: 18.2.0
react-native:
installed: 0.73.7
wanted: 0.73.7
react-native-macos: Not Found
npmGlobalPackages:
"*react-native*": Not Found
Android:
hermesEnabled: true
newArchEnabled: false
iOS:
hermesEnabled: true
newArchEnabled: false
```
### Stacktrace or Logs
```text
-
```
### Reproducer
https://snack.expo.dev/q9Jn9vh1ZTLruGLXjN7Du
### Screenshots and Videos
_No response_
|
{
"login": "martinnov92",
"id": 15011249,
"node_id": "MDQ6VXNlcjE1MDExMjQ5",
"avatar_url": "https://avatars.githubusercontent.com/u/15011249?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/martinnov92",
"html_url": "https://github.com/martinnov92",
"followers_url": "https://api.github.com/users/martinnov92/followers",
"following_url": "https://api.github.com/users/martinnov92/following{/other_user}",
"gists_url": "https://api.github.com/users/martinnov92/gists{/gist_id}",
"starred_url": "https://api.github.com/users/martinnov92/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/martinnov92/subscriptions",
"organizations_url": "https://api.github.com/users/martinnov92/orgs",
"repos_url": "https://api.github.com/users/martinnov92/repos",
"events_url": "https://api.github.com/users/martinnov92/events{/privacy}",
"received_events_url": "https://api.github.com/users/martinnov92/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48949/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48949/timeline
| null |
completed
|
{
"total": 0,
"completed": 0,
"percent_completed": 0
}
| false
|
https://api.github.com/repos/facebook/react-native/issues/48948
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48948/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48948/comments
|
https://api.github.com/repos/facebook/react-native/issues/48948/events
|
https://github.com/facebook/react-native/pull/48948
| 2,811,294,012
|
PR_kwDOAbrxp86I_r9T
| 48,948
|
[iOS] Clean up RCTBridgeDelegate to remove shouldBridgeUseCustomJSC method
|
{
"login": "zhongwuzw",
"id": 5061845,
"node_id": "MDQ6VXNlcjUwNjE4NDU=",
"avatar_url": "https://avatars.githubusercontent.com/u/5061845?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/zhongwuzw",
"html_url": "https://github.com/zhongwuzw",
"followers_url": "https://api.github.com/users/zhongwuzw/followers",
"following_url": "https://api.github.com/users/zhongwuzw/following{/other_user}",
"gists_url": "https://api.github.com/users/zhongwuzw/gists{/gist_id}",
"starred_url": "https://api.github.com/users/zhongwuzw/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zhongwuzw/subscriptions",
"organizations_url": "https://api.github.com/users/zhongwuzw/orgs",
"repos_url": "https://api.github.com/users/zhongwuzw/repos",
"events_url": "https://api.github.com/users/zhongwuzw/events{/privacy}",
"received_events_url": "https://api.github.com/users/zhongwuzw/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 3253537094,
"node_id": "MDU6TGFiZWwzMjUzNTM3MDk0",
"url": "https://api.github.com/repos/facebook/react-native/labels/Shared%20with%20Meta",
"name": "Shared with Meta",
"color": "BFD4F2",
"default": false,
"description": "Applied via automation to indicate that an Issue or Pull Request has been shared with the team."
}
] |
closed
| false
| null |
[] | null | 3
| 2025-01-26T03:18:33
| 2025-01-28T12:41:53
| 2025-01-28T12:41:42
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48948",
"html_url": "https://github.com/facebook/react-native/pull/48948",
"diff_url": "https://github.com/facebook/react-native/pull/48948.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48948.patch",
"merged_at": null
}
|
## Summary:
`shouldBridgeUseCustomJSC` comes from https://github.com/zhongwuzw/react-native/commit/cb3e575deb8a2be972298b12761ed9ee8f0ae63d, seems it's not working anymore. So we can clean up it .
## Changelog:
[IOS] [REMOVED] - Clean up RCTBridgeDelegate to remove shouldBridgeUseCustomJSC method
## Test Plan:
Everything should works.
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48948/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48948/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48947
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48947/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48947/comments
|
https://api.github.com/repos/facebook/react-native/issues/48947/events
|
https://github.com/facebook/react-native/pull/48947
| 2,811,280,786
|
PR_kwDOAbrxp86I_pW6
| 48,947
|
[iOS] Fabric: Fixes textinput not respond when maxLength > 5.5 quadrillion
|
{
"login": "zhongwuzw",
"id": 5061845,
"node_id": "MDQ6VXNlcjUwNjE4NDU=",
"avatar_url": "https://avatars.githubusercontent.com/u/5061845?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/zhongwuzw",
"html_url": "https://github.com/zhongwuzw",
"followers_url": "https://api.github.com/users/zhongwuzw/followers",
"following_url": "https://api.github.com/users/zhongwuzw/following{/other_user}",
"gists_url": "https://api.github.com/users/zhongwuzw/gists{/gist_id}",
"starred_url": "https://api.github.com/users/zhongwuzw/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zhongwuzw/subscriptions",
"organizations_url": "https://api.github.com/users/zhongwuzw/orgs",
"repos_url": "https://api.github.com/users/zhongwuzw/repos",
"events_url": "https://api.github.com/users/zhongwuzw/events{/privacy}",
"received_events_url": "https://api.github.com/users/zhongwuzw/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 3253537094,
"node_id": "MDU6TGFiZWwzMjUzNTM3MDk0",
"url": "https://api.github.com/repos/facebook/react-native/labels/Shared%20with%20Meta",
"name": "Shared with Meta",
"color": "BFD4F2",
"default": false,
"description": "Applied via automation to indicate that an Issue or Pull Request has been shared with the team."
}
] |
closed
| false
| null |
[] | null | 5
| 2025-01-26T02:33:32
| 2025-02-21T16:04:03
| 2025-02-21T16:04:03
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48947",
"html_url": "https://github.com/facebook/react-native/pull/48947",
"diff_url": "https://github.com/facebook/react-native/pull/48947.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48947.patch",
"merged_at": null
}
|
## Summary:
Fixes #48941 .
## Changelog:
[IOS] [FIXED] - Fabric: Fixes textinput not respond when maxLength > 5.5 quadrillion
## Test Plan:
Repro please see #48941.
|
{
"login": "cortinico",
"id": 3001957,
"node_id": "MDQ6VXNlcjMwMDE5NTc=",
"avatar_url": "https://avatars.githubusercontent.com/u/3001957?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cortinico",
"html_url": "https://github.com/cortinico",
"followers_url": "https://api.github.com/users/cortinico/followers",
"following_url": "https://api.github.com/users/cortinico/following{/other_user}",
"gists_url": "https://api.github.com/users/cortinico/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cortinico/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cortinico/subscriptions",
"organizations_url": "https://api.github.com/users/cortinico/orgs",
"repos_url": "https://api.github.com/users/cortinico/repos",
"events_url": "https://api.github.com/users/cortinico/events{/privacy}",
"received_events_url": "https://api.github.com/users/cortinico/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48947/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48947/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48946
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48946/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48946/comments
|
https://api.github.com/repos/facebook/react-native/issues/48946/events
|
https://github.com/facebook/react-native/pull/48946
| 2,811,271,144
|
PR_kwDOAbrxp86I_ndc
| 48,946
|
Use uint32_t for httpStatus
|
{
"login": "christophpurrer",
"id": 484044,
"node_id": "MDQ6VXNlcjQ4NDA0NA==",
"avatar_url": "https://avatars.githubusercontent.com/u/484044?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/christophpurrer",
"html_url": "https://github.com/christophpurrer",
"followers_url": "https://api.github.com/users/christophpurrer/followers",
"following_url": "https://api.github.com/users/christophpurrer/following{/other_user}",
"gists_url": "https://api.github.com/users/christophpurrer/gists{/gist_id}",
"starred_url": "https://api.github.com/users/christophpurrer/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/christophpurrer/subscriptions",
"organizations_url": "https://api.github.com/users/christophpurrer/orgs",
"repos_url": "https://api.github.com/users/christophpurrer/repos",
"events_url": "https://api.github.com/users/christophpurrer/events{/privacy}",
"received_events_url": "https://api.github.com/users/christophpurrer/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 6
| 2025-01-26T02:03:11
| 2025-01-27T19:55:11
| 2025-01-27T19:55:01
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48946",
"html_url": "https://github.com/facebook/react-native/pull/48946",
"diff_url": "https://github.com/facebook/react-native/pull/48946.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48946.patch",
"merged_at": null
}
|
Summary: [Changelog] [Internal] - [jsinspector-modern] Use uint32_t for httpStatus
Differential Revision: D68676415
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48946/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48946/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48945
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48945/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48945/comments
|
https://api.github.com/repos/facebook/react-native/issues/48945/events
|
https://github.com/facebook/react-native/pull/48945
| 2,811,255,391
|
PR_kwDOAbrxp86I_kiH
| 48,945
|
Migrate com.facebook.react.modules.network.OkHttpClientFactory to Kotlin
|
{
"login": "mateoguzmana",
"id": 20783123,
"node_id": "MDQ6VXNlcjIwNzgzMTIz",
"avatar_url": "https://avatars.githubusercontent.com/u/20783123?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mateoguzmana",
"html_url": "https://github.com/mateoguzmana",
"followers_url": "https://api.github.com/users/mateoguzmana/followers",
"following_url": "https://api.github.com/users/mateoguzmana/following{/other_user}",
"gists_url": "https://api.github.com/users/mateoguzmana/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mateoguzmana/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mateoguzmana/subscriptions",
"organizations_url": "https://api.github.com/users/mateoguzmana/orgs",
"repos_url": "https://api.github.com/users/mateoguzmana/repos",
"events_url": "https://api.github.com/users/mateoguzmana/events{/privacy}",
"received_events_url": "https://api.github.com/users/mateoguzmana/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 3253537094,
"node_id": "MDU6TGFiZWwzMjUzNTM3MDk0",
"url": "https://api.github.com/repos/facebook/react-native/labels/Shared%20with%20Meta",
"name": "Shared with Meta",
"color": "BFD4F2",
"default": false,
"description": "Applied via automation to indicate that an Issue or Pull Request has been shared with the team."
}
] |
closed
| false
| null |
[] | null | 3
| 2025-01-26T01:13:56
| 2025-01-27T12:52:38
| 2025-01-27T12:52:26
|
COLLABORATOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48945",
"html_url": "https://github.com/facebook/react-native/pull/48945",
"diff_url": "https://github.com/facebook/react-native/pull/48945.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48945.patch",
"merged_at": null
}
|
## Summary:
Migrate com.facebook.react.modules.network.OkHttpClientFactory to Kotlin
## Changelog:
[INTERNAL] - Migrate com.facebook.react.modules.network.OkHttpClientFactory to Kotlin
## Test Plan:
```bash
yarn test-android
yarn android
```
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48945/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48945/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48944
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48944/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48944/comments
|
https://api.github.com/repos/facebook/react-native/issues/48944/events
|
https://github.com/facebook/react-native/issues/48944
| 2,811,207,826
|
I_kwDOAbrxp86nj6CS
| 48,944
|
App freezes on startup after adding custom native module
|
{
"login": "iaceene",
"id": 106110604,
"node_id": "U_kgDOBlMejA",
"avatar_url": "https://avatars.githubusercontent.com/u/106110604?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/iaceene",
"html_url": "https://github.com/iaceene",
"followers_url": "https://api.github.com/users/iaceene/followers",
"following_url": "https://api.github.com/users/iaceene/following{/other_user}",
"gists_url": "https://api.github.com/users/iaceene/gists{/gist_id}",
"starred_url": "https://api.github.com/users/iaceene/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/iaceene/subscriptions",
"organizations_url": "https://api.github.com/users/iaceene/orgs",
"repos_url": "https://api.github.com/users/iaceene/repos",
"events_url": "https://api.github.com/users/iaceene/events{/privacy}",
"received_events_url": "https://api.github.com/users/iaceene/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 718241807,
"node_id": "MDU6TGFiZWw3MTgyNDE4MDc=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Stale",
"name": "Stale",
"color": "e99695",
"default": false,
"description": "There has been a lack of activity on this issue and it may be closed soon."
},
{
"id": 1794148631,
"node_id": "MDU6TGFiZWwxNzk0MTQ4NjMx",
"url": "https://api.github.com/repos/facebook/react-native/labels/Needs:%20Author%20Feedback",
"name": "Needs: Author Feedback",
"color": "d4c5f9",
"default": false,
"description": ""
},
{
"id": 1794376073,
"node_id": "MDU6TGFiZWwxNzk0Mzc2MDcz",
"url": "https://api.github.com/repos/facebook/react-native/labels/Needs:%20Repro",
"name": "Needs: Repro",
"color": "d4c5f9",
"default": false,
"description": "This issue could be improved with a clear list of steps to reproduce the issue."
}
] |
closed
| false
| null |
[] | null | 5
| 2025-01-25T22:43:25
| 2025-02-28T05:01:14
| 2025-02-28T05:01:12
|
NONE
| null | null | null | null |
### Description
After adding a custom native module to my React Native app, the app freezes on startup and never loads the main screen. I followed the documentation for creating a native module and linked it properly, but after that, the app simply hangs on the splash screen and does not proceed.
I’ve tried cleaning the build, resetting the cache, and running the app on different devices, but the issue persists.
Expected Behavior:
The app should start normally and load the main screen even after adding the custom native module.
Steps to Reproduce:
Create a custom native module following the official React Native documentation.
Link the native module (manually or via auto-linking).
Run the app on either an Android or iOS device using react-native run-android or react-native run-ios.
Observe the app freezing on the splash screen with no further progress.
Environment:
React Native version: (Not mentioned)
Node.js version: 16.x
npm or yarn version: npm 8.x
Operating System: macOS Big Sur
Device: iPhone 13 (iOS) / Samsung Galaxy S21 (Android)
Logs:
2025-01-25 12:34:56.789 MyApp[1234:56789] App launched
2025-01-25 12:34:57.001 MyApp[1234:56789] NativeModule: MyCustomModule initialization failed
2025-01-25 12:34:57.099 MyApp[1234:56789] App is freezing on splash screen, no further logs.
Additional Context:
I’m using a custom native module to interact with a third-party SDK.
The issue happens on both Android and iOS devices.
I’ve checked the Android logs, and the ReactContext for the module seems to be null at the time of initialization.
The app works fine when the custom module is removed.
Possible Solution (if applicable):
I’m unsure what the exact cause might be. Could this be an issue with how the native module is initialized or linked? Any ideas on how to debug further or a potential solution to this freezing problem would be greatly appreciated!
### Steps to reproduce
Create a new React Native project:
npx react-native init MyApp
Navigate to the project directory:
cd MyApp
Install a custom native module (e.g., a module to integrate with a third-party SDK):
npm install react-native-custom-sdk
Link the custom native module (if manual linking is required):
npx react-native link react-native-custom-sdk
Modify the Android native code (e.g., add required permissions or SDK initialization):
Open android/app/src/main/java/com/myapp/MainActivity.java
Add necessary import and initialization code for the custom SDK.
Update App.js to use the native module:
Import and call functions from the native module inside App.js.
Build and run the app on an Android device:
npx react-native run-android
Observe the crash: The app will freeze or crash on startup with a "NativeModule: null" error or similar issue.
Clear cache and rebuild (if applicable):
npx react-native start --reset-cache
Re-run the app:
npx react-native run-android
Confirm issue persists: The app should still freeze or fail to load correctly.
### React Native Version
0.77.0
### Affected Platforms
Runtime - iOS
### Output of `npx react-native info`
```text
React Native Environment Info:
System:
OS: macOS 12.5.1
CPU: (8) arm64 Apple M1
Memory: 16 GB
Shell: 5.8 - /bin/zsh
Binaries:
Node: 16.14.2 - /usr/local/bin/node
Yarn: 1.22.18 - /usr/local/bin/yarn
npm: 8.3.1 - /usr/local/bin/npm
Watchman: 2021.08.02.00 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 15.2, macOS 12.1, tvOS 15.2
Xcode: 13.2.1/13C100 - /usr/bin/xcodebuild
Android SDK:
API Levels: 30, 29, 28
Build Tools: 30.0.3, 29.0.3
Platform Tools: 31.0.3
Android NDK: 23.1.7779620
IDEs:
Xcode: 13.2.1 - /usr/bin/xcodebuild
Android Studio: 2021.1.1.25 - /Applications/Android Studio.app/Contents
Languages:
Java: 11.0.9.1 - /usr/bin/javac
Kotlin: 1.5.30 - /usr/local/bin/kotlinc
Python: 3.9.7 - /usr/bin/python3
npmPackages:
react: 18.0.0 - node_modules/react
react-native: 0.67.2 - node_modules/react-native
Expo:
SDK: N/A
Installed Android Emulators:
Pixel_3_API_30: Android 10 (API 30) - emulator
Pixel_4_API_31: Android 11 (API 31) - emulator
```
### Stacktrace or Logs
```text
2025-01-25 12:34:56.789 MyApp[1234:56789] App launched
2025-01-25 12:34:56.890 MyApp[1234:56789] React Native: Starting up...
2025-01-25 12:34:56.999 MyApp[1234:56789] NativeModule: CustomSDK initialization failed
2025-01-25 12:34:57.123 MyApp[1234:56789] Error: Attempt to invoke virtual method 'com.reactlibrary.CustomSDK.getReactApplicationContext()' on a null object reference
at com.myapp.MainActivity.onCreate(MainActivity.java:45)
at android.app.Activity.performCreate(Activity.java:8024)
at android.app.Activity.performCreate(Activity.java:8014)
at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1306)
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3543)
at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3717)
at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:85)
at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2126)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loop(Looper.java:246)
at android.app.ActivityThread.main(ActivityThread.java:8637)
at java.lang.reflect.Method.invoke(Method.java:0)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1034)
```
### Reproducer
https://github.com/iaceene/react-native-custom-sdk-issue
### Screenshots and Videos
_No response_
|
{
"login": "react-native-bot",
"id": 32686087,
"node_id": "MDQ6VXNlcjMyNjg2MDg3",
"avatar_url": "https://avatars.githubusercontent.com/u/32686087?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/react-native-bot",
"html_url": "https://github.com/react-native-bot",
"followers_url": "https://api.github.com/users/react-native-bot/followers",
"following_url": "https://api.github.com/users/react-native-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/react-native-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/react-native-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/react-native-bot/subscriptions",
"organizations_url": "https://api.github.com/users/react-native-bot/orgs",
"repos_url": "https://api.github.com/users/react-native-bot/repos",
"events_url": "https://api.github.com/users/react-native-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/react-native-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48944/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48944/timeline
| null |
not_planned
|
{
"total": 0,
"completed": 0,
"percent_completed": 0
}
| false
|
https://api.github.com/repos/facebook/react-native/issues/48943
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48943/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48943/comments
|
https://api.github.com/repos/facebook/react-native/issues/48943/events
|
https://github.com/facebook/react-native/pull/48943
| 2,811,200,108
|
PR_kwDOAbrxp86I_ZoF
| 48,943
|
introduce Fantom.flushAllNativeEvents
|
{
"login": "sammy-SC",
"id": 1733610,
"node_id": "MDQ6VXNlcjE3MzM2MTA=",
"avatar_url": "https://avatars.githubusercontent.com/u/1733610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sammy-SC",
"html_url": "https://github.com/sammy-SC",
"followers_url": "https://api.github.com/users/sammy-SC/followers",
"following_url": "https://api.github.com/users/sammy-SC/following{/other_user}",
"gists_url": "https://api.github.com/users/sammy-SC/gists{/gist_id}",
"starred_url": "https://api.github.com/users/sammy-SC/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sammy-SC/subscriptions",
"organizations_url": "https://api.github.com/users/sammy-SC/orgs",
"repos_url": "https://api.github.com/users/sammy-SC/repos",
"events_url": "https://api.github.com/users/sammy-SC/events{/privacy}",
"received_events_url": "https://api.github.com/users/sammy-SC/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 4
| 2025-01-25T22:17:17
| 2025-01-27T12:46:45
| 2025-01-27T12:46:34
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48943",
"html_url": "https://github.com/facebook/react-native/pull/48943",
"diff_url": "https://github.com/facebook/react-native/pull/48943.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48943.patch",
"merged_at": null
}
|
Summary:
changelog: [internal]
A new helper function on Fantom flushAllNativeEvents, which will flush all pending native events.
Differential Revision: D68566753
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48943/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48943/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48942
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48942/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48942/comments
|
https://api.github.com/repos/facebook/react-native/issues/48942/events
|
https://github.com/facebook/react-native/pull/48942
| 2,810,838,088
|
PR_kwDOAbrxp86I-Rtm
| 48,942
|
Support for custom JavaScript runtimes for the new architecture in Android
|
{
"login": "lukaszkurantdev",
"id": 36734207,
"node_id": "MDQ6VXNlcjM2NzM0MjA3",
"avatar_url": "https://avatars.githubusercontent.com/u/36734207?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/lukaszkurantdev",
"html_url": "https://github.com/lukaszkurantdev",
"followers_url": "https://api.github.com/users/lukaszkurantdev/followers",
"following_url": "https://api.github.com/users/lukaszkurantdev/following{/other_user}",
"gists_url": "https://api.github.com/users/lukaszkurantdev/gists{/gist_id}",
"starred_url": "https://api.github.com/users/lukaszkurantdev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lukaszkurantdev/subscriptions",
"organizations_url": "https://api.github.com/users/lukaszkurantdev/orgs",
"repos_url": "https://api.github.com/users/lukaszkurantdev/repos",
"events_url": "https://api.github.com/users/lukaszkurantdev/events{/privacy}",
"received_events_url": "https://api.github.com/users/lukaszkurantdev/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 3253537094,
"node_id": "MDU6TGFiZWwzMjUzNTM3MDk0",
"url": "https://api.github.com/repos/facebook/react-native/labels/Shared%20with%20Meta",
"name": "Shared with Meta",
"color": "BFD4F2",
"default": false,
"description": "Applied via automation to indicate that an Issue or Pull Request has been shared with the team."
}
] |
closed
| false
| null |
[] | null | 1
| 2025-01-25T08:01:18
| 2025-01-27T11:48:36
| 2025-01-27T11:48:36
|
NONE
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48942",
"html_url": "https://github.com/facebook/react-native/pull/48942",
"diff_url": "https://github.com/facebook/react-native/pull/48942.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48942.patch",
"merged_at": null
}
|
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory. -->
## Summary:
<!-- Explain the **motivation** for making this change. What existing problem does the pull request solve? -->
In the old architecture, we have the ability to easily change the JavaScript runtime on Android using the overridden `getJavaScriptExecutorFactory` function in the `ReactNativeHost` abstract class. This creates a new instance of the factory and an executor with assigned runtime. However, in the new architecture, engine selection occurs in the `DefaultReactHost` object and depends on the `isHermesEnabled` property of the `ReactNativeHost` class. This logic is limited to engine selection between Hermes and JSC and lacks the ability to easily override it (as is the case with iOS code).
This PR includes a modification of this mechanism so that the function responsible for selecting the Runtime is in the `DefaultReactNativeHost` object – this will allow it to be written from within the project's `MainApplication` class, e.g:
```kotlin
class MainApplication : Application(), ReactApplication {
override val reactNativeHost: ReactNativeHost =
object : DefaultReactNativeHost(this) {
//...
override fun getJSRuntimeFactory(): JSRuntimeFactory {
return CustomJSInstance() // e.g. V8Instance
}
}
```
Exactly as was the case with the old architecture and function:
```kotlin
override fun getJavaScriptExecutorFactory(): JavaScriptExecutorFactory {
return CustomJSExecutorFactory()
}
```
This is particularly important when using custom JS engines other than Hermes or JSC in a project, such as the V8 (https://github.com/Kudo/react-native-v8), or smaller engines tailored to selected devices or solutions.
## Changelog:
<!-- Help reviewers and the release process by writing your own changelog entry.
Pick one each for the category and type tags:
[ANDROID] [CHANGED] - Message
For more details, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->
[ANDROID] [CHANGED] - Moving the Javascript Runtime selection to the DefaultReactNativeHost object to allow selection of custom JS runtimes
## Test Plan:
<!-- Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes the user interface. -->
All tests were successfully completed.
|
{
"login": "cortinico",
"id": 3001957,
"node_id": "MDQ6VXNlcjMwMDE5NTc=",
"avatar_url": "https://avatars.githubusercontent.com/u/3001957?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cortinico",
"html_url": "https://github.com/cortinico",
"followers_url": "https://api.github.com/users/cortinico/followers",
"following_url": "https://api.github.com/users/cortinico/following{/other_user}",
"gists_url": "https://api.github.com/users/cortinico/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cortinico/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cortinico/subscriptions",
"organizations_url": "https://api.github.com/users/cortinico/orgs",
"repos_url": "https://api.github.com/users/cortinico/repos",
"events_url": "https://api.github.com/users/cortinico/events{/privacy}",
"received_events_url": "https://api.github.com/users/cortinico/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48942/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48942/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48941
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48941/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48941/comments
|
https://api.github.com/repos/facebook/react-native/issues/48941/events
|
https://github.com/facebook/react-native/issues/48941
| 2,810,605,670
|
I_kwDOAbrxp86nhnBm
| 48,941
|
On iOS, TextInput stops responding to user input when maxLength > 5.5 quadrillion
|
{
"login": "maxpowa",
"id": 1764978,
"node_id": "MDQ6VXNlcjE3NjQ5Nzg=",
"avatar_url": "https://avatars.githubusercontent.com/u/1764978?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/maxpowa",
"html_url": "https://github.com/maxpowa",
"followers_url": "https://api.github.com/users/maxpowa/followers",
"following_url": "https://api.github.com/users/maxpowa/following{/other_user}",
"gists_url": "https://api.github.com/users/maxpowa/gists{/gist_id}",
"starred_url": "https://api.github.com/users/maxpowa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/maxpowa/subscriptions",
"organizations_url": "https://api.github.com/users/maxpowa/orgs",
"repos_url": "https://api.github.com/users/maxpowa/repos",
"events_url": "https://api.github.com/users/maxpowa/events{/privacy}",
"received_events_url": "https://api.github.com/users/maxpowa/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 869668024,
"node_id": "MDU6TGFiZWw4Njk2NjgwMjQ=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Component:%20TextInput",
"name": "Component: TextInput",
"color": "fef2c0",
"default": false,
"description": "Related to the TextInput component."
},
{
"id": 4139937040,
"node_id": "LA_kwDOAbrxp872wm0Q",
"url": "https://api.github.com/repos/facebook/react-native/labels/Resolution:%20Answered",
"name": "Resolution: Answered",
"color": "C2E0C6",
"default": false,
"description": "When the issue is resolved with a simple answer"
}
] |
closed
| false
| null |
[] | null | 7
| 2025-01-24T23:50:42
| 2025-02-21T16:03:55
| 2025-02-21T16:03:50
|
NONE
| null | null | null | null |
### Description
In iOS, the TextInput component stops responding to user input if `maxLength` is greater than 5.50 quadrillion (5500000000000000). The exact number is somewhere between 5.49 and 5.5 quadrillion, but I'll leave that as an exercise for the reader.
### Steps to reproduce
1. Add TextInput component
2. Set `maxLength` prop, greater than 5500000000000000
3. Attempt to use TextInput field to enter text
### React Native Version
0.76.6
### Affected Platforms
Runtime - iOS
### Output of `npx react-native info`
```text
System:
OS: macOS 15.0.1
CPU: (12) arm64 Apple M2 Pro
Memory: 78.22 MB / 32.00 GB
Shell:
version: "5.9"
path: /bin/zsh
Binaries:
Node:
version: 22.12.0
path: ~/.local/share/mise/installs/node/22.12.0/bin/node
Yarn:
version: 4.6.0
path: ~/.local/share/mise/installs/node/22.12.0/bin/yarn
npm:
version: 10.9.0
path: ~/.local/share/mise/installs/node/22.12.0/bin/npm
Watchman: Not Found
Managers:
CocoaPods:
version: 1.16.2
path: ~/.local/share/mise/installs/ruby/3.3.6/bin/pod
SDKs:
iOS SDK:
Platforms:
- DriverKit 24.0
- iOS 18.0
- macOS 15.0
- tvOS 18.0
- visionOS 2.0
- watchOS 11.0
Android SDK: Not Found
IDEs:
Android Studio: 2024.2 AI-242.23339.11.2421.12700392
Xcode:
version: 16.0/16A242d
path: /usr/bin/xcodebuild
Languages:
Java:
version: 17.0.13
path: ~/.local/share/mise/installs/java/zulu-17.54.21/bin/javac
Ruby:
version: 3.3.6
path: ~/.local/share/mise/installs/ruby/3.3.6/bin/ruby
npmPackages:
"@react-native-community/cli":
installed: 16.0.2
wanted: ^16.0.0
react:
installed: 18.3.1
wanted: 18.3.1
react-native:
installed: 0.76.6
wanted: 0.76.6
react-native-macos: Not Found
npmGlobalPackages:
"*react-native*": Not Found
Android:
hermesEnabled: true
newArchEnabled: true
iOS:
hermesEnabled: true
newArchEnabled: true
```
### Stacktrace or Logs
```text
N/A
```
### Reproducer
https://snack.expo.dev/9RnT_dmqTwVK8of5iVUJ-
### Screenshots and Videos
_No response_
|
{
"login": "cortinico",
"id": 3001957,
"node_id": "MDQ6VXNlcjMwMDE5NTc=",
"avatar_url": "https://avatars.githubusercontent.com/u/3001957?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cortinico",
"html_url": "https://github.com/cortinico",
"followers_url": "https://api.github.com/users/cortinico/followers",
"following_url": "https://api.github.com/users/cortinico/following{/other_user}",
"gists_url": "https://api.github.com/users/cortinico/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cortinico/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cortinico/subscriptions",
"organizations_url": "https://api.github.com/users/cortinico/orgs",
"repos_url": "https://api.github.com/users/cortinico/repos",
"events_url": "https://api.github.com/users/cortinico/events{/privacy}",
"received_events_url": "https://api.github.com/users/cortinico/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48941/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48941/timeline
| null |
completed
|
{
"total": 0,
"completed": 0,
"percent_completed": 0
}
| false
|
https://api.github.com/repos/facebook/react-native/issues/48940
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48940/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48940/comments
|
https://api.github.com/repos/facebook/react-native/issues/48940/events
|
https://github.com/facebook/react-native/pull/48940
| 2,810,287,362
|
PR_kwDOAbrxp86I8abH
| 48,940
|
Fix durability of PerformanceObserver mark/measure example
|
{
"login": "rozele",
"id": 1106239,
"node_id": "MDQ6VXNlcjExMDYyMzk=",
"avatar_url": "https://avatars.githubusercontent.com/u/1106239?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rozele",
"html_url": "https://github.com/rozele",
"followers_url": "https://api.github.com/users/rozele/followers",
"following_url": "https://api.github.com/users/rozele/following{/other_user}",
"gists_url": "https://api.github.com/users/rozele/gists{/gist_id}",
"starred_url": "https://api.github.com/users/rozele/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rozele/subscriptions",
"organizations_url": "https://api.github.com/users/rozele/orgs",
"repos_url": "https://api.github.com/users/rozele/repos",
"events_url": "https://api.github.com/users/rozele/events{/privacy}",
"received_events_url": "https://api.github.com/users/rozele/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 3
| 2025-01-24T20:02:13
| 2025-01-28T15:12:30
| 2025-01-28T15:12:17
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48940",
"html_url": "https://github.com/facebook/react-native/pull/48940",
"diff_url": "https://github.com/facebook/react-native/pull/48940.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48940.patch",
"merged_at": null
}
|
Summary:
The PerformanceObserver (marks and measures) example clears it's output each time a new PerformanceObserver event fires, which makes it not particularly useful.
This change makes it so the output is only updated if a non-empty list of performance events is observed.
Differential Revision: D68634361
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48940/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48940/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48939
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48939/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48939/comments
|
https://api.github.com/repos/facebook/react-native/issues/48939/events
|
https://github.com/facebook/react-native/pull/48939
| 2,810,156,744
|
PR_kwDOAbrxp86I79mS
| 48,939
|
Lift dynamic prop merging to ConcreteComponentDescriptor
|
{
"login": "dmytrorykun",
"id": 14206200,
"node_id": "MDQ6VXNlcjE0MjA2MjAw",
"avatar_url": "https://avatars.githubusercontent.com/u/14206200?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dmytrorykun",
"html_url": "https://github.com/dmytrorykun",
"followers_url": "https://api.github.com/users/dmytrorykun/followers",
"following_url": "https://api.github.com/users/dmytrorykun/following{/other_user}",
"gists_url": "https://api.github.com/users/dmytrorykun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dmytrorykun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dmytrorykun/subscriptions",
"organizations_url": "https://api.github.com/users/dmytrorykun/orgs",
"repos_url": "https://api.github.com/users/dmytrorykun/repos",
"events_url": "https://api.github.com/users/dmytrorykun/events{/privacy}",
"received_events_url": "https://api.github.com/users/dmytrorykun/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 7
| 2025-01-24T18:42:12
| 2025-03-21T12:11:29
| 2025-03-21T12:11:28
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48939",
"html_url": "https://github.com/facebook/react-native/pull/48939",
"diff_url": "https://github.com/facebook/react-native/pull/48939.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48939.patch",
"merged_at": null
}
|
Summary:
The `enableAccumulatedUpdatesInRawPropsAndroid` experiment needs additional context for finer setup. Specifically it needs to be conditionally enabled based on a component name. This information is not accessible form the `Props` constructor.
This diff moves the experimental logic to `ConcreteComponentDescriptor`.
Changelog: [Internal]
Differential Revision: D68633985
|
{
"login": "javache",
"id": 5676,
"node_id": "MDQ6VXNlcjU2NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/5676?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/javache",
"html_url": "https://github.com/javache",
"followers_url": "https://api.github.com/users/javache/followers",
"following_url": "https://api.github.com/users/javache/following{/other_user}",
"gists_url": "https://api.github.com/users/javache/gists{/gist_id}",
"starred_url": "https://api.github.com/users/javache/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/javache/subscriptions",
"organizations_url": "https://api.github.com/users/javache/orgs",
"repos_url": "https://api.github.com/users/javache/repos",
"events_url": "https://api.github.com/users/javache/events{/privacy}",
"received_events_url": "https://api.github.com/users/javache/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48939/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48939/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48938
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48938/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48938/comments
|
https://api.github.com/repos/facebook/react-native/issues/48938/events
|
https://github.com/facebook/react-native/pull/48938
| 2,810,154,845
|
PR_kwDOAbrxp86I79K1
| 48,938
|
Remove some code duplication in ConcreteComponentDescriptor::cloneProps
|
{
"login": "dmytrorykun",
"id": 14206200,
"node_id": "MDQ6VXNlcjE0MjA2MjAw",
"avatar_url": "https://avatars.githubusercontent.com/u/14206200?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dmytrorykun",
"html_url": "https://github.com/dmytrorykun",
"followers_url": "https://api.github.com/users/dmytrorykun/followers",
"following_url": "https://api.github.com/users/dmytrorykun/following{/other_user}",
"gists_url": "https://api.github.com/users/dmytrorykun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dmytrorykun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dmytrorykun/subscriptions",
"organizations_url": "https://api.github.com/users/dmytrorykun/orgs",
"repos_url": "https://api.github.com/users/dmytrorykun/repos",
"events_url": "https://api.github.com/users/dmytrorykun/events{/privacy}",
"received_events_url": "https://api.github.com/users/dmytrorykun/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 4
| 2025-01-24T18:41:21
| 2025-01-28T00:26:46
| 2025-01-28T00:26:35
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48938",
"html_url": "https://github.com/facebook/react-native/pull/48938",
"diff_url": "https://github.com/facebook/react-native/pull/48938.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48938.patch",
"merged_at": null
}
|
Summary:
Simple cleanup. Move the instantiation of shadowNodeProps outside of the IF statement.
Changelog: [Internal]
Differential Revision: D68634269
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48938/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48938/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48937
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48937/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48937/comments
|
https://api.github.com/repos/facebook/react-native/issues/48937/events
|
https://github.com/facebook/react-native/pull/48937
| 2,810,152,527
|
PR_kwDOAbrxp86I78pO
| 48,937
|
Rename Props.rawProps to Props.dynamicProps
|
{
"login": "dmytrorykun",
"id": 14206200,
"node_id": "MDQ6VXNlcjE0MjA2MjAw",
"avatar_url": "https://avatars.githubusercontent.com/u/14206200?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dmytrorykun",
"html_url": "https://github.com/dmytrorykun",
"followers_url": "https://api.github.com/users/dmytrorykun/followers",
"following_url": "https://api.github.com/users/dmytrorykun/following{/other_user}",
"gists_url": "https://api.github.com/users/dmytrorykun/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dmytrorykun/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dmytrorykun/subscriptions",
"organizations_url": "https://api.github.com/users/dmytrorykun/orgs",
"repos_url": "https://api.github.com/users/dmytrorykun/repos",
"events_url": "https://api.github.com/users/dmytrorykun/events{/privacy}",
"received_events_url": "https://api.github.com/users/dmytrorykun/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 3
| 2025-01-24T18:40:23
| 2025-03-21T12:12:44
| 2025-03-21T12:12:43
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48937",
"html_url": "https://github.com/facebook/react-native/pull/48937",
"diff_url": "https://github.com/facebook/react-native/pull/48937.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48937.patch",
"merged_at": null
}
|
Summary:
This diff renames the `rawProps` member of the `Props` class to `dynamicProp`.
This is to avoid confusion with the `RawProps` type, since `rawProps` is `folly::dynamic`, not `RawProps`.
Changelog: [Android][Breaking] - Props.rawProps renamed to Props.dynamicProps.
Differential Revision: D68633868
|
{
"login": "javache",
"id": 5676,
"node_id": "MDQ6VXNlcjU2NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/5676?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/javache",
"html_url": "https://github.com/javache",
"followers_url": "https://api.github.com/users/javache/followers",
"following_url": "https://api.github.com/users/javache/following{/other_user}",
"gists_url": "https://api.github.com/users/javache/gists{/gist_id}",
"starred_url": "https://api.github.com/users/javache/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/javache/subscriptions",
"organizations_url": "https://api.github.com/users/javache/orgs",
"repos_url": "https://api.github.com/users/javache/repos",
"events_url": "https://api.github.com/users/javache/events{/privacy}",
"received_events_url": "https://api.github.com/users/javache/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48937/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48937/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48936
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48936/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48936/comments
|
https://api.github.com/repos/facebook/react-native/issues/48936/events
|
https://github.com/facebook/react-native/issues/48936
| 2,810,046,789
|
I_kwDOAbrxp86nfelF
| 48,936
|
[iOS] a problem with codegen?
|
{
"login": "birdofpreyru",
"id": 20144632,
"node_id": "MDQ6VXNlcjIwMTQ0NjMy",
"avatar_url": "https://avatars.githubusercontent.com/u/20144632?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/birdofpreyru",
"html_url": "https://github.com/birdofpreyru",
"followers_url": "https://api.github.com/users/birdofpreyru/followers",
"following_url": "https://api.github.com/users/birdofpreyru/following{/other_user}",
"gists_url": "https://api.github.com/users/birdofpreyru/gists{/gist_id}",
"starred_url": "https://api.github.com/users/birdofpreyru/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/birdofpreyru/subscriptions",
"organizations_url": "https://api.github.com/users/birdofpreyru/orgs",
"repos_url": "https://api.github.com/users/birdofpreyru/repos",
"events_url": "https://api.github.com/users/birdofpreyru/events{/privacy}",
"received_events_url": "https://api.github.com/users/birdofpreyru/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 257497884,
"node_id": "MDU6TGFiZWwyNTc0OTc4ODQ=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Platform:%20iOS",
"name": "Platform: iOS",
"color": "1d76db",
"default": false,
"description": "iOS applications."
},
{
"id": 856933610,
"node_id": "MDU6TGFiZWw4NTY5MzM2MTA=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Resolution:%20PR%20Submitted",
"name": "Resolution: PR Submitted",
"color": "0052cc",
"default": false,
"description": "A pull request with a fix has been provided."
},
{
"id": 3815166274,
"node_id": "LA_kwDOAbrxp87jZtFC",
"url": "https://api.github.com/repos/facebook/react-native/labels/Type:%20New%20Architecture",
"name": "Type: New Architecture",
"color": "f9d0c4",
"default": false,
"description": "Issues and PRs related to new architecture (Fabric/Turbo Modules)"
}
] |
open
| false
| null |
[] | null | 2
| 2025-01-24T17:56:08
| 2025-01-28T11:22:33
| null |
CONTRIBUTOR
| null | null | null | null |
### Description
Hey folks, will you please have a brief look at the issue I've created in `creact-react-native-library` repo: https://github.com/callstack/react-native-builder-bob/issues/755 (not sure whether that issue belongs there, or to the RN repo, as it seems to be caused by Codegen outputs).
Essentially, I am trying to upgrade my fork of `react-native-fs` to RN@0.77, on the way resetting the library scaffolding to the one generated by the latest version of the `create-react-native-library` generator. The upgraded code is here: https://github.com/birdofpreyru/react-native-fs/tree/dev-v2.31. I'm trying to build its Example App then, and it fails at the linking step, due to a clash between the same-named objects (like `RCTAppDependencyProvider`) present both in files generated by the codegen for the library itself, and for smth else.
I have confirmed that builds passes fine and the app works, if I just comment out the content of involved `.mm` files generated under `ios/generated` folder (relative to the repo's root); but I have no idea what is the root cause of the problem? Is it a bug inside the Codegen generating for the library some files it is not supposed to generate for it? Is it some mistake in my lib's configuration causing that Codegen behavior? Have I messed-up any other config in the project? Is it a problem with the project template used by `creact-react-native-library` (same problem happens with the new Turbo Module lib project generated by `create-react-native-library`, without any other modifications)?
I guess, it is very easy issue to narrow down for anybody who knows how exactly Codegen is supposed to behave here :) (thus, not for me 😅 )
### Steps to reproduce
N/A
### React Native Version
0.77.0
### Affected Platforms
Build - MacOS
### Areas
Codegen
### Output of `npx react-native info`
```text
N/A
```
### Stacktrace or Logs
```text
N/A
```
### Reproducer
N/A
### Screenshots and Videos
_No response_
| null |
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48936/reactions",
"total_count": 1,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48936/timeline
| null | null |
{
"total": 0,
"completed": 0,
"percent_completed": 0
}
| false
|
https://api.github.com/repos/facebook/react-native/issues/48935
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48935/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48935/comments
|
https://api.github.com/repos/facebook/react-native/issues/48935/events
|
https://github.com/facebook/react-native/pull/48935
| 2,810,039,467
|
PR_kwDOAbrxp86I7jGv
| 48,935
|
Update tests to support new didOpen delegate fn
|
{
"login": "EdmondChuiHW",
"id": 1967998,
"node_id": "MDQ6VXNlcjE5Njc5OTg=",
"avatar_url": "https://avatars.githubusercontent.com/u/1967998?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/EdmondChuiHW",
"html_url": "https://github.com/EdmondChuiHW",
"followers_url": "https://api.github.com/users/EdmondChuiHW/followers",
"following_url": "https://api.github.com/users/EdmondChuiHW/following{/other_user}",
"gists_url": "https://api.github.com/users/EdmondChuiHW/gists{/gist_id}",
"starred_url": "https://api.github.com/users/EdmondChuiHW/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/EdmondChuiHW/subscriptions",
"organizations_url": "https://api.github.com/users/EdmondChuiHW/orgs",
"repos_url": "https://api.github.com/users/EdmondChuiHW/repos",
"events_url": "https://api.github.com/users/EdmondChuiHW/events{/privacy}",
"received_events_url": "https://api.github.com/users/EdmondChuiHW/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
open
| false
| null |
[] | null | 2
| 2025-01-24T17:53:20
| 2025-02-13T15:25:55
| null |
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48935",
"html_url": "https://github.com/facebook/react-native/pull/48935",
"diff_url": "https://github.com/facebook/react-native/pull/48935.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48935.patch",
"merged_at": null
}
|
Summary:
Changelog: [General][Fixed] Update tests to support new `didOpen` delegate fn
Add support for the new `didOpen` delegate function in tests.
To follow up: the borked tear down sequence when these two tests are ran together (they pass when ran individually)
```
buck2 test @//fbobjc/mode/buck2/ios-tests fbsource//xplat/js/react-native-github/packages/react-native/ReactCommon/jsinspector-modern:testsAppleMac -- ReactInstanceIntegrationTest RuntimeTargetDebuggerSessionObserverTest
```
Differential Revision: D68632974
| null |
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48935/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48935/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48934
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48934/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48934/comments
|
https://api.github.com/repos/facebook/react-native/issues/48934/events
|
https://github.com/facebook/react-native/pull/48934
| 2,809,899,866
|
PR_kwDOAbrxp86I7D2U
| 48,934
|
Stable API - Refactor and remove unnecessary RuntimeConfig
|
{
"login": "cortinico",
"id": 3001957,
"node_id": "MDQ6VXNlcjMwMDE5NTc=",
"avatar_url": "https://avatars.githubusercontent.com/u/3001957?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cortinico",
"html_url": "https://github.com/cortinico",
"followers_url": "https://api.github.com/users/cortinico/followers",
"following_url": "https://api.github.com/users/cortinico/following{/other_user}",
"gists_url": "https://api.github.com/users/cortinico/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cortinico/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cortinico/subscriptions",
"organizations_url": "https://api.github.com/users/cortinico/orgs",
"repos_url": "https://api.github.com/users/cortinico/repos",
"events_url": "https://api.github.com/users/cortinico/events{/privacy}",
"received_events_url": "https://api.github.com/users/cortinico/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 2
| 2025-01-24T16:56:43
| 2025-01-28T13:05:43
| 2025-01-28T13:05:30
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48934",
"html_url": "https://github.com/facebook/react-native/pull/48934",
"diff_url": "https://github.com/facebook/react-native/pull/48934.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48934.patch",
"merged_at": null
}
|
Summary:
This class is publicly exposed but effectively unused at all (neither internally, nor externally).
I'm removing it as this should not affect anyone.
Changelog:
[Android] [Breaking] - Removed `RuntimeConfig` class for Hermes which was unused.
Differential Revision: D68631945
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48934/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48934/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48933
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48933/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48933/comments
|
https://api.github.com/repos/facebook/react-native/issues/48933/events
|
https://github.com/facebook/react-native/pull/48933
| 2,809,811,025
|
PR_kwDOAbrxp86I6wyB
| 48,933
|
Migrate files in Libraries/Interaction to use export syntax
|
{
"login": "iwoplaza",
"id": 7166752,
"node_id": "MDQ6VXNlcjcxNjY3NTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166752?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/iwoplaza",
"html_url": "https://github.com/iwoplaza",
"followers_url": "https://api.github.com/users/iwoplaza/followers",
"following_url": "https://api.github.com/users/iwoplaza/following{/other_user}",
"gists_url": "https://api.github.com/users/iwoplaza/gists{/gist_id}",
"starred_url": "https://api.github.com/users/iwoplaza/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/iwoplaza/subscriptions",
"organizations_url": "https://api.github.com/users/iwoplaza/orgs",
"repos_url": "https://api.github.com/users/iwoplaza/repos",
"events_url": "https://api.github.com/users/iwoplaza/events{/privacy}",
"received_events_url": "https://api.github.com/users/iwoplaza/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 3
| 2025-01-24T16:09:42
| 2025-01-27T14:42:47
| 2025-01-27T14:42:36
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48933",
"html_url": "https://github.com/facebook/react-native/pull/48933",
"diff_url": "https://github.com/facebook/react-native/pull/48933.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48933.patch",
"merged_at": null
}
|
Summary:
## Motivation
Modernising the react-native codebase to allow for ingestion by modern Flow tooling
## This diff
- Updates files in Libraries/Interaction to use `export` syntax
- Appends `.default` to requires of the changed files.
- Updates the public API snapshot (intented breaking change)
Changelog:
[General][Breaking] - Files inside `Libraries/Interaction` use `export` syntax, which requires the addition of `.default` when imported with the CJS `require` syntax.
Differential Revision: D68629953
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48933/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48933/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48932
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48932/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48932/comments
|
https://api.github.com/repos/facebook/react-native/issues/48932/events
|
https://github.com/facebook/react-native/pull/48932
| 2,809,810,647
|
PR_kwDOAbrxp86I6wsx
| 48,932
|
Nullsafe jcf/react/animated
|
{
"login": "tdn120",
"id": 32721554,
"node_id": "MDQ6VXNlcjMyNzIxNTU0",
"avatar_url": "https://avatars.githubusercontent.com/u/32721554?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/tdn120",
"html_url": "https://github.com/tdn120",
"followers_url": "https://api.github.com/users/tdn120/followers",
"following_url": "https://api.github.com/users/tdn120/following{/other_user}",
"gists_url": "https://api.github.com/users/tdn120/gists{/gist_id}",
"starred_url": "https://api.github.com/users/tdn120/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tdn120/subscriptions",
"organizations_url": "https://api.github.com/users/tdn120/orgs",
"repos_url": "https://api.github.com/users/tdn120/repos",
"events_url": "https://api.github.com/users/tdn120/events{/privacy}",
"received_events_url": "https://api.github.com/users/tdn120/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 4
| 2025-01-24T16:09:30
| 2025-01-27T15:25:27
| 2025-01-27T15:25:15
|
NONE
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48932",
"html_url": "https://github.com/facebook/react-native/pull/48932",
"diff_url": "https://github.com/facebook/react-native/pull/48932.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48932.patch",
"merged_at": null
}
|
Summary:
Results of running nullsafe script with `--patch=apply_fixmes`, `--patch=mark_nullsafe`, with minimal manual fixes to get all checks passing.
Changelog: [Internal]
Differential Revision: D68629827
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48932/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48932/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48931
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48931/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48931/comments
|
https://api.github.com/repos/facebook/react-native/issues/48931/events
|
https://github.com/facebook/react-native/pull/48931
| 2,809,768,563
|
PR_kwDOAbrxp86I6nnp
| 48,931
|
Migrate files in Libraries/Inspector to use export syntax
|
{
"login": "iwoplaza",
"id": 7166752,
"node_id": "MDQ6VXNlcjcxNjY3NTI=",
"avatar_url": "https://avatars.githubusercontent.com/u/7166752?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/iwoplaza",
"html_url": "https://github.com/iwoplaza",
"followers_url": "https://api.github.com/users/iwoplaza/followers",
"following_url": "https://api.github.com/users/iwoplaza/following{/other_user}",
"gists_url": "https://api.github.com/users/iwoplaza/gists{/gist_id}",
"starred_url": "https://api.github.com/users/iwoplaza/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/iwoplaza/subscriptions",
"organizations_url": "https://api.github.com/users/iwoplaza/orgs",
"repos_url": "https://api.github.com/users/iwoplaza/repos",
"events_url": "https://api.github.com/users/iwoplaza/events{/privacy}",
"received_events_url": "https://api.github.com/users/iwoplaza/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 4
| 2025-01-24T15:49:10
| 2025-01-28T14:17:07
| 2025-01-28T14:16:57
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48931",
"html_url": "https://github.com/facebook/react-native/pull/48931",
"diff_url": "https://github.com/facebook/react-native/pull/48931.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48931.patch",
"merged_at": null
}
|
Summary:
## Motivation
Modernising the react-native codebase to allow for ingestion by modern Flow tooling
## This diff
- Updates files in Libraries/Inspector to use `export` syntax
- Appends `.default` to requires of the changed files.
- Updates the public API snapshot (intented breaking change)
Changelog:
[General][Breaking] - Files inside `Libraries/Inspector` use `export` syntax, which requires the addition of `.default` when imported with the CJS `require` syntax.
Differential Revision: D68629285
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48931/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48931/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48930
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48930/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48930/comments
|
https://api.github.com/repos/facebook/react-native/issues/48930/events
|
https://github.com/facebook/react-native/pull/48930
| 2,809,710,890
|
PR_kwDOAbrxp86I6bHf
| 48,930
|
Set up test to validate refactor of XHR, FileReader and WebSocket classes to use the built-in EventTarget implementation
|
{
"login": "rubennorte",
"id": 117921,
"node_id": "MDQ6VXNlcjExNzkyMQ==",
"avatar_url": "https://avatars.githubusercontent.com/u/117921?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rubennorte",
"html_url": "https://github.com/rubennorte",
"followers_url": "https://api.github.com/users/rubennorte/followers",
"following_url": "https://api.github.com/users/rubennorte/following{/other_user}",
"gists_url": "https://api.github.com/users/rubennorte/gists{/gist_id}",
"starred_url": "https://api.github.com/users/rubennorte/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rubennorte/subscriptions",
"organizations_url": "https://api.github.com/users/rubennorte/orgs",
"repos_url": "https://api.github.com/users/rubennorte/repos",
"events_url": "https://api.github.com/users/rubennorte/events{/privacy}",
"received_events_url": "https://api.github.com/users/rubennorte/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 14
| 2025-01-24T15:21:51
| 2025-01-29T18:24:07
| 2025-01-29T18:10:34
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48930",
"html_url": "https://github.com/facebook/react-native/pull/48930",
"diff_url": "https://github.com/facebook/react-native/pull/48930.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48930.patch",
"merged_at": null
}
|
Summary:
Changelog: [internal]
This creates new versions of `XMLHttpRequest`, `FileReader` and `WebSocket` that extend the new built-in `EventTarget` implementation, instead of the implementation from the `event-target-shim` package.
It also sets up a test to choose between the 2 implementations at runtime to verify correctness and performance. This doesn't use the RN feature flags infra because we use this flag very early on startup, before we have a chance to set overrides. We could use a native feature flag instead but it'd slow down the rollout of the test.
Differential Revision: D68625226
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48930/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48930/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48929
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48929/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48929/comments
|
https://api.github.com/repos/facebook/react-native/issues/48929/events
|
https://github.com/facebook/react-native/pull/48929
| 2,809,557,964
|
PR_kwDOAbrxp86I55p0
| 48,929
|
fix ignoring of temp local project settings for RNTester
|
{
"login": "vzaidman",
"id": 5188459,
"node_id": "MDQ6VXNlcjUxODg0NTk=",
"avatar_url": "https://avatars.githubusercontent.com/u/5188459?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/vzaidman",
"html_url": "https://github.com/vzaidman",
"followers_url": "https://api.github.com/users/vzaidman/followers",
"following_url": "https://api.github.com/users/vzaidman/following{/other_user}",
"gists_url": "https://api.github.com/users/vzaidman/gists{/gist_id}",
"starred_url": "https://api.github.com/users/vzaidman/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vzaidman/subscriptions",
"organizations_url": "https://api.github.com/users/vzaidman/orgs",
"repos_url": "https://api.github.com/users/vzaidman/repos",
"events_url": "https://api.github.com/users/vzaidman/events{/privacy}",
"received_events_url": "https://api.github.com/users/vzaidman/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
open
| false
| null |
[] | null | 1
| 2025-01-24T14:11:52
| 2025-02-13T15:25:55
| null |
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48929",
"html_url": "https://github.com/facebook/react-native/pull/48929",
"diff_url": "https://github.com/facebook/react-native/pull/48929.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48929.patch",
"merged_at": null
}
|
Summary:
Creating a new project was creating the unignored folder `rntesterIOS.xcodeproj.local` that was not ignored and messing up the relevant files for source control.
Reviewed By: hoxyq
Differential Revision: D68625659
Changelog: [Internal]
| null |
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48929/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48929/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48928
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48928/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48928/comments
|
https://api.github.com/repos/facebook/react-native/issues/48928/events
|
https://github.com/facebook/react-native/pull/48928
| 2,809,530,051
|
PR_kwDOAbrxp86I5ztN
| 48,928
|
Refactor NetworkOverlay to use a symbol instead of a public property in XHR
|
{
"login": "rubennorte",
"id": 117921,
"node_id": "MDQ6VXNlcjExNzkyMQ==",
"avatar_url": "https://avatars.githubusercontent.com/u/117921?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rubennorte",
"html_url": "https://github.com/rubennorte",
"followers_url": "https://api.github.com/users/rubennorte/followers",
"following_url": "https://api.github.com/users/rubennorte/following{/other_user}",
"gists_url": "https://api.github.com/users/rubennorte/gists{/gist_id}",
"starred_url": "https://api.github.com/users/rubennorte/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rubennorte/subscriptions",
"organizations_url": "https://api.github.com/users/rubennorte/orgs",
"repos_url": "https://api.github.com/users/rubennorte/repos",
"events_url": "https://api.github.com/users/rubennorte/events{/privacy}",
"received_events_url": "https://api.github.com/users/rubennorte/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 12
| 2025-01-24T14:00:04
| 2025-01-29T18:10:42
| 2025-01-29T18:10:32
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48928",
"html_url": "https://github.com/facebook/react-native/pull/48928",
"diff_url": "https://github.com/facebook/react-native/pull/48928.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48928.patch",
"merged_at": null
}
|
Summary:
Changelog: [internal]
Just a minor change to reduce the number of Flow errors we will get when we refactor XHR soon.
Differential Revision: D68625224
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48928/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48928/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48927
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48927/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48927/comments
|
https://api.github.com/repos/facebook/react-native/issues/48927/events
|
https://github.com/facebook/react-native/pull/48927
| 2,809,498,200
|
PR_kwDOAbrxp86I5swM
| 48,927
|
remove explicit calls to root.destroy
|
{
"login": "sammy-SC",
"id": 1733610,
"node_id": "MDQ6VXNlcjE3MzM2MTA=",
"avatar_url": "https://avatars.githubusercontent.com/u/1733610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sammy-SC",
"html_url": "https://github.com/sammy-SC",
"followers_url": "https://api.github.com/users/sammy-SC/followers",
"following_url": "https://api.github.com/users/sammy-SC/following{/other_user}",
"gists_url": "https://api.github.com/users/sammy-SC/gists{/gist_id}",
"starred_url": "https://api.github.com/users/sammy-SC/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sammy-SC/subscriptions",
"organizations_url": "https://api.github.com/users/sammy-SC/orgs",
"repos_url": "https://api.github.com/users/sammy-SC/repos",
"events_url": "https://api.github.com/users/sammy-SC/events{/privacy}",
"received_events_url": "https://api.github.com/users/sammy-SC/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 3
| 2025-01-24T13:44:54
| 2025-01-24T15:07:38
| 2025-01-24T15:07:27
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48927",
"html_url": "https://github.com/facebook/react-native/pull/48927",
"diff_url": "https://github.com/facebook/react-native/pull/48927.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48927.patch",
"merged_at": null
}
|
Summary:
changelog: [internal]
Remove explicit calls to root.destroy() in favour of automated system that will call it and check for memory leaks.
Reviewed By: rubennorte
Differential Revision: D68624917
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48927/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48927/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48926
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48926/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48926/comments
|
https://api.github.com/repos/facebook/react-native/issues/48926/events
|
https://github.com/facebook/react-native/pull/48926
| 2,809,448,270
|
PR_kwDOAbrxp86I5hxr
| 48,926
|
Use custom tracks for measures
|
{
"login": "hoxyq",
"id": 28902667,
"node_id": "MDQ6VXNlcjI4OTAyNjY3",
"avatar_url": "https://avatars.githubusercontent.com/u/28902667?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hoxyq",
"html_url": "https://github.com/hoxyq",
"followers_url": "https://api.github.com/users/hoxyq/followers",
"following_url": "https://api.github.com/users/hoxyq/following{/other_user}",
"gists_url": "https://api.github.com/users/hoxyq/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hoxyq/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hoxyq/subscriptions",
"organizations_url": "https://api.github.com/users/hoxyq/orgs",
"repos_url": "https://api.github.com/users/hoxyq/repos",
"events_url": "https://api.github.com/users/hoxyq/events{/privacy}",
"received_events_url": "https://api.github.com/users/hoxyq/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 2
| 2025-01-24T13:21:27
| 2025-01-24T16:46:16
| 2025-01-24T16:46:01
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48926",
"html_url": "https://github.com/facebook/react-native/pull/48926",
"diff_url": "https://github.com/facebook/react-native/pull/48926.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48926.patch",
"merged_at": null
}
|
Summary:
# Changelog: [Internal]
Leverage [`devtools` field](https://developer.chrome.com/docs/devtools/performance/extension#devtools_object) inside [`detail` object](https://developer.mozilla.org/en-US/docs/Web/API/Performance/measure#detail) to make extension tracks work.
Right now we are only specifying track name, later we could use many more fields:
```
interface ExtensionTrackEntryPayload {
dataType?: "track-entry"; // Defaults to "track-entry"
color?: DevToolsColor; // Defaults to "primary"
track: string; // Required: Name of the custom track
trackGroup?: string; // Optional: Group for organizing tracks
properties?: [string, string][]; // Key-value pairs for detailed view
tooltipText?: string; // Short description for tooltip
}
```
In the next few diffs I will extend the spec of the local implementation for `performance.measure` and `performance.mark` to get this propagated correctly.
Differential Revision: D68624603
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48926/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48926/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48925
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48925/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48925/comments
|
https://api.github.com/repos/facebook/react-native/issues/48925/events
|
https://github.com/facebook/react-native/pull/48925
| 2,809,438,615
|
PR_kwDOAbrxp86I5fry
| 48,925
|
perf: fast _getFreeIndex
|
{
"login": "kewde",
"id": 13770485,
"node_id": "MDQ6VXNlcjEzNzcwNDg1",
"avatar_url": "https://avatars.githubusercontent.com/u/13770485?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/kewde",
"html_url": "https://github.com/kewde",
"followers_url": "https://api.github.com/users/kewde/followers",
"following_url": "https://api.github.com/users/kewde/following{/other_user}",
"gists_url": "https://api.github.com/users/kewde/gists{/gist_id}",
"starred_url": "https://api.github.com/users/kewde/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kewde/subscriptions",
"organizations_url": "https://api.github.com/users/kewde/orgs",
"repos_url": "https://api.github.com/users/kewde/repos",
"events_url": "https://api.github.com/users/kewde/events{/privacy}",
"received_events_url": "https://api.github.com/users/kewde/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 3253537094,
"node_id": "MDU6TGFiZWwzMjUzNTM3MDk0",
"url": "https://api.github.com/repos/facebook/react-native/labels/Shared%20with%20Meta",
"name": "Shared with Meta",
"color": "BFD4F2",
"default": false,
"description": "Applied via automation to indicate that an Issue or Pull Request has been shared with the team."
}
] |
closed
| false
| null |
[] | null | 8
| 2025-01-24T13:16:39
| 2025-02-10T11:47:41
| 2025-02-10T11:47:31
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48925",
"html_url": "https://github.com/facebook/react-native/pull/48925",
"diff_url": "https://github.com/facebook/react-native/pull/48925.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48925.patch",
"merged_at": null
}
|
## Summary:
The performance of `_getFreeIndex` is quite terrible since the `timersID` array can get quite large when you spawn a lot of promises or timers. We profiled our application for 28 seconds on RN 0.71.11 and noticed that the `indexOf` into this array was consuming almost a second.
The hermes version that we are using has a pretty slow `indexOf` compared to other engines, and the static hermes will improve it by 12x but for the time being, this is a perf issue. https://github.com/facebook/hermes/pull/1447
We avoid having to use `indexOf` by maintaining a list of the free ids.
**Before - Samsung Galaxy A52 for 28 seconds of profiling**
**After - Samsung Galaxy A52 for 28 seconds of profiling**
## Changelog:
[INTERNAL] [FIXED] - Improve performance of _getFreeIndex
## Test Plan:
- Tests pass, promises resolve and reject correctly, setTimeout works as expected
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48925/reactions",
"total_count": 5,
"+1": 5,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48925/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48924
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48924/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48924/comments
|
https://api.github.com/repos/facebook/react-native/issues/48924/events
|
https://github.com/facebook/react-native/pull/48924
| 2,809,414,575
|
PR_kwDOAbrxp86I5ahQ
| 48,924
|
unify Fantom calling convention to Fantom.foo
|
{
"login": "sammy-SC",
"id": 1733610,
"node_id": "MDQ6VXNlcjE3MzM2MTA=",
"avatar_url": "https://avatars.githubusercontent.com/u/1733610?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/sammy-SC",
"html_url": "https://github.com/sammy-SC",
"followers_url": "https://api.github.com/users/sammy-SC/followers",
"following_url": "https://api.github.com/users/sammy-SC/following{/other_user}",
"gists_url": "https://api.github.com/users/sammy-SC/gists{/gist_id}",
"starred_url": "https://api.github.com/users/sammy-SC/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sammy-SC/subscriptions",
"organizations_url": "https://api.github.com/users/sammy-SC/orgs",
"repos_url": "https://api.github.com/users/sammy-SC/repos",
"events_url": "https://api.github.com/users/sammy-SC/events{/privacy}",
"received_events_url": "https://api.github.com/users/sammy-SC/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 3
| 2025-01-24T13:04:32
| 2025-01-25T23:02:34
| 2025-01-25T23:02:24
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48924",
"html_url": "https://github.com/facebook/react-native/pull/48924",
"diff_url": "https://github.com/facebook/react-native/pull/48924.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48924.patch",
"merged_at": null
}
|
Summary:
changelog: [internal]
All other Fantom tests are using Fantom.foo style instead of `foo`. Let's unify codebase on this.
Differential Revision: D68552829
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48924/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48924/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48923
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48923/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48923/comments
|
https://api.github.com/repos/facebook/react-native/issues/48923/events
|
https://github.com/facebook/react-native/pull/48923
| 2,809,369,887
|
PR_kwDOAbrxp86I5Q-0
| 48,923
|
Migrate to Inspector trace
|
{
"login": "hoxyq",
"id": 28902667,
"node_id": "MDQ6VXNlcjI4OTAyNjY3",
"avatar_url": "https://avatars.githubusercontent.com/u/28902667?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hoxyq",
"html_url": "https://github.com/hoxyq",
"followers_url": "https://api.github.com/users/hoxyq/followers",
"following_url": "https://api.github.com/users/hoxyq/following{/other_user}",
"gists_url": "https://api.github.com/users/hoxyq/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hoxyq/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hoxyq/subscriptions",
"organizations_url": "https://api.github.com/users/hoxyq/orgs",
"repos_url": "https://api.github.com/users/hoxyq/repos",
"events_url": "https://api.github.com/users/hoxyq/events{/privacy}",
"received_events_url": "https://api.github.com/users/hoxyq/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 4
| 2025-01-24T12:42:14
| 2025-01-24T16:46:13
| 2025-01-24T16:46:00
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48923",
"html_url": "https://github.com/facebook/react-native/pull/48923",
"diff_url": "https://github.com/facebook/react-native/pull/48923.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48923.patch",
"merged_at": null
}
|
Summary:
# Changelog: [Internal]
Starting from this diff, React Native will emit inspector traces, the ones that will have the same UI as if it was recorded in a browser.
We are going to fake it by sending "TracingStartedInPage" event. For a corresponding logic on Chrome DevTools Frontend side, see [this](https://github.com/ChromeDevTools/devtools-frontend/blob/192673131cf3e6e0bcdb4a97bd0bd39c75f1b3c2/front_end/models/trace/handlers/MetaHandler.ts#L68-L80) as a starting point.
Because of this, custom tracks are now grouped under "Timings" track, although with a better color scheme:
- We no longer need the logic for placing tracks under arbitrary thread ids to have them grouped.
- The real support for extension tracks (custom tracks for Performance panel) will be added in the next diff.
Differential Revision: D68439734
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48923/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48923/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48922
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48922/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48922/comments
|
https://api.github.com/repos/facebook/react-native/issues/48922/events
|
https://github.com/facebook/react-native/pull/48922
| 2,809,340,208
|
PR_kwDOAbrxp86I5KTQ
| 48,922
|
Implement CustomEvent
|
{
"login": "rubennorte",
"id": 117921,
"node_id": "MDQ6VXNlcjExNzkyMQ==",
"avatar_url": "https://avatars.githubusercontent.com/u/117921?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rubennorte",
"html_url": "https://github.com/rubennorte",
"followers_url": "https://api.github.com/users/rubennorte/followers",
"following_url": "https://api.github.com/users/rubennorte/following{/other_user}",
"gists_url": "https://api.github.com/users/rubennorte/gists{/gist_id}",
"starred_url": "https://api.github.com/users/rubennorte/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rubennorte/subscriptions",
"organizations_url": "https://api.github.com/users/rubennorte/orgs",
"repos_url": "https://api.github.com/users/rubennorte/repos",
"events_url": "https://api.github.com/users/rubennorte/events{/privacy}",
"received_events_url": "https://api.github.com/users/rubennorte/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 8
| 2025-01-24T12:29:08
| 2025-01-27T15:54:42
| 2025-01-27T15:53:49
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48922",
"html_url": "https://github.com/facebook/react-native/pull/48922",
"diff_url": "https://github.com/facebook/react-native/pull/48922.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48922.patch",
"merged_at": null
}
|
Summary:
Changelog: [internal]
This is a basic subclass of Event that allows setting custom values (as opposed to `Event` that is meant to be used as a superclass).
Differential Revision: D67804060
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48922/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48922/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48921
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48921/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48921/comments
|
https://api.github.com/repos/facebook/react-native/issues/48921/events
|
https://github.com/facebook/react-native/issues/48921
| 2,809,328,154
|
I_kwDOAbrxp86ncvIa
| 48,921
|
[Text on Android]: setting selectable to true breaks the text truncation and lineHeight on Android
|
{
"login": "dariakoko",
"id": 36167539,
"node_id": "MDQ6VXNlcjM2MTY3NTM5",
"avatar_url": "https://avatars.githubusercontent.com/u/36167539?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/dariakoko",
"html_url": "https://github.com/dariakoko",
"followers_url": "https://api.github.com/users/dariakoko/followers",
"following_url": "https://api.github.com/users/dariakoko/following{/other_user}",
"gists_url": "https://api.github.com/users/dariakoko/gists{/gist_id}",
"starred_url": "https://api.github.com/users/dariakoko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dariakoko/subscriptions",
"organizations_url": "https://api.github.com/users/dariakoko/orgs",
"repos_url": "https://api.github.com/users/dariakoko/repos",
"events_url": "https://api.github.com/users/dariakoko/events{/privacy}",
"received_events_url": "https://api.github.com/users/dariakoko/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 870851515,
"node_id": "MDU6TGFiZWw4NzA4NTE1MTU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Platform:%20Android",
"name": "Platform: Android",
"color": "1d76db",
"default": false,
"description": "Android applications."
},
{
"id": 1794148347,
"node_id": "MDU6TGFiZWwxNzk0MTQ4MzQ3",
"url": "https://api.github.com/repos/facebook/react-native/labels/Needs:%20Triage%20:mag:",
"name": "Needs: Triage :mag:",
"color": "bfd4f2",
"default": false,
"description": ""
}
] |
open
| false
| null |
[] | null | 16
| 2025-01-24T12:24:31
| 2025-05-29T07:30:37
| null |
NONE
| null | null | null | null |
### Description
I use Text component that has to contain selectable text and should be truncated if it extends the width of the parent component.
On iOS everything works fine. On Android if I set `selectable={true}` truncation and line height of the text are breaking.
### Steps to reproduce
1. import Text component from react-native
2. render Text component, add `selectable={true}`, `numberOfLines={1}`
3. the text is cut off instead of being truncated, the line height is bigger than it should be, the top of the second line of text is visible
### React Native Version
0.75.4
### Affected Platforms
Runtime - Android
### Output of `npx react-native info`
```text
-
```
### Stacktrace or Logs
```text
-
```
### Reproducer
https://github.com/dariakoko/text-component-on-android
### Screenshots and Videos
<img width="338" alt="Image" src="https://github.com/user-attachments/assets/a1ae3cd8-4f1f-4a5a-99af-9f65e04d66e3" />
```
<View style={{width: 200}}>
<Text style={{color: 'green'}}>default: </Text>
<Text style={{backgroundColor: 'yellow'}}>
Some long very very very very very long text
</Text>
<Text>-------------</Text>
<Text style={{color: 'green'}}>not selectable: </Text>
<Text numberOfLines={1} style={{backgroundColor: 'yellow'}}>
Some long very very very very very long text
</Text>
<Text>-------------</Text>
<Text style={{color: 'red'}}>selectable (issue): </Text>
<Text
selectable={true}
numberOfLines={1}
style={{backgroundColor: 'yellow'}}>
Some long very very very very very long text
</Text>
<View style={{height: 20, backgroundColor: 'pink'}}></View>
</View>
```
| null |
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48921/reactions",
"total_count": 2,
"+1": 1,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 1
}
|
https://api.github.com/repos/facebook/react-native/issues/48921/timeline
| null | null |
{
"total": 0,
"completed": 0,
"percent_completed": 0
}
| false
|
https://api.github.com/repos/facebook/react-native/issues/48920
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48920/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48920/comments
|
https://api.github.com/repos/facebook/react-native/issues/48920/events
|
https://github.com/facebook/react-native/pull/48920
| 2,809,310,070
|
PR_kwDOAbrxp86I5Dhe
| 48,920
|
Create module to handle event handler attributes
|
{
"login": "rubennorte",
"id": 117921,
"node_id": "MDQ6VXNlcjExNzkyMQ==",
"avatar_url": "https://avatars.githubusercontent.com/u/117921?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rubennorte",
"html_url": "https://github.com/rubennorte",
"followers_url": "https://api.github.com/users/rubennorte/followers",
"following_url": "https://api.github.com/users/rubennorte/following{/other_user}",
"gists_url": "https://api.github.com/users/rubennorte/gists{/gist_id}",
"starred_url": "https://api.github.com/users/rubennorte/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rubennorte/subscriptions",
"organizations_url": "https://api.github.com/users/rubennorte/orgs",
"repos_url": "https://api.github.com/users/rubennorte/repos",
"events_url": "https://api.github.com/users/rubennorte/events{/privacy}",
"received_events_url": "https://api.github.com/users/rubennorte/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 6
| 2025-01-24T12:18:08
| 2025-01-27T15:54:37
| 2025-01-27T15:53:48
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48920",
"html_url": "https://github.com/facebook/react-native/pull/48920",
"diff_url": "https://github.com/facebook/react-native/pull/48920.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48920.patch",
"merged_at": null
}
|
Summary:
Changelog: [internal]
Implements a module with helpers to define event handler IDL attributes in classes extending `EventTarget`. E.g.:
```
import {getEventHandlerAttribute, setEventHandlerAttribute} from '../path/to/EventHandlerAttributes';
class EventTargetSubclass extends EventTarget {
get oncustomevent(): EventListener | null {
return getEventHandlerAttribute(this, 'customEvent');
}
set oncustomevent(listener: EventListener | null) {
setEventHandlerAttribute(this, 'customEvent', listener);
}
}
const eventTargetInstance = new EventTargetSubclass();
eventTargetInstance.oncustomevent = (event: Event) => {
console.log('custom event received');
};
eventTargetInstance.dispatchEvent(new Event('customEvent'));
// Logs 'custom event received' to the console.
eventTargetInstance.oncustomevent = null;
eventTargetInstance.dispatchEvent(new Event('customEvent'));
// Does not log anything to the console.
```
Differential Revision: D67839560
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48920/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48920/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48919
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48919/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48919/comments
|
https://api.github.com/repos/facebook/react-native/issues/48919/events
|
https://github.com/facebook/react-native/pull/48919
| 2,809,291,067
|
PR_kwDOAbrxp86I4_SF
| 48,919
|
Remove unused AndroidUnicodeUtils.
|
{
"login": "cortinico",
"id": 3001957,
"node_id": "MDQ6VXNlcjMwMDE5NTc=",
"avatar_url": "https://avatars.githubusercontent.com/u/3001957?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/cortinico",
"html_url": "https://github.com/cortinico",
"followers_url": "https://api.github.com/users/cortinico/followers",
"following_url": "https://api.github.com/users/cortinico/following{/other_user}",
"gists_url": "https://api.github.com/users/cortinico/gists{/gist_id}",
"starred_url": "https://api.github.com/users/cortinico/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cortinico/subscriptions",
"organizations_url": "https://api.github.com/users/cortinico/orgs",
"repos_url": "https://api.github.com/users/cortinico/repos",
"events_url": "https://api.github.com/users/cortinico/events{/privacy}",
"received_events_url": "https://api.github.com/users/cortinico/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 3
| 2025-01-24T12:08:47
| 2025-01-24T18:07:34
| 2025-01-24T18:07:26
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48919",
"html_url": "https://github.com/facebook/react-native/pull/48919",
"diff_url": "https://github.com/facebook/react-native/pull/48919.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48919.patch",
"merged_at": null
}
|
Summary:
I suspect this class is unused and we should not be building it.
The same `AndroidUnicodeUtils.java` is provided by facebook/hermes instead.
Changelog:
[Internal] [Changed] -
Differential Revision: D68623307
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48919/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48919/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48918
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48918/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48918/comments
|
https://api.github.com/repos/facebook/react-native/issues/48918/events
|
https://github.com/facebook/react-native/pull/48918
| 2,809,273,687
|
PR_kwDOAbrxp86I47iH
| 48,918
|
Make constants in Event more spec compliant
|
{
"login": "rubennorte",
"id": 117921,
"node_id": "MDQ6VXNlcjExNzkyMQ==",
"avatar_url": "https://avatars.githubusercontent.com/u/117921?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/rubennorte",
"html_url": "https://github.com/rubennorte",
"followers_url": "https://api.github.com/users/rubennorte/followers",
"following_url": "https://api.github.com/users/rubennorte/following{/other_user}",
"gists_url": "https://api.github.com/users/rubennorte/gists{/gist_id}",
"starred_url": "https://api.github.com/users/rubennorte/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rubennorte/subscriptions",
"organizations_url": "https://api.github.com/users/rubennorte/orgs",
"repos_url": "https://api.github.com/users/rubennorte/repos",
"events_url": "https://api.github.com/users/rubennorte/events{/privacy}",
"received_events_url": "https://api.github.com/users/rubennorte/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 6
| 2025-01-24T11:59:46
| 2025-01-27T15:54:24
| 2025-01-27T15:53:46
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48918",
"html_url": "https://github.com/facebook/react-native/pull/48918",
"diff_url": "https://github.com/facebook/react-native/pull/48918.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48918.patch",
"merged_at": null
}
|
Summary:
Changelog: [internal]
Makes the constants read-only and accessible through `Event.prototype` as well.
Differential Revision: D67830012
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48918/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48918/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48917
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48917/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48917/comments
|
https://api.github.com/repos/facebook/react-native/issues/48917/events
|
https://github.com/facebook/react-native/pull/48917
| 2,809,260,684
|
PR_kwDOAbrxp86I44q9
| 48,917
|
Cleanup initEagerTurboModulesOnNativeModulesQueueAndroid flag
|
{
"login": "javache",
"id": 5676,
"node_id": "MDQ6VXNlcjU2NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/5676?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/javache",
"html_url": "https://github.com/javache",
"followers_url": "https://api.github.com/users/javache/followers",
"following_url": "https://api.github.com/users/javache/following{/other_user}",
"gists_url": "https://api.github.com/users/javache/gists{/gist_id}",
"starred_url": "https://api.github.com/users/javache/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/javache/subscriptions",
"organizations_url": "https://api.github.com/users/javache/orgs",
"repos_url": "https://api.github.com/users/javache/repos",
"events_url": "https://api.github.com/users/javache/events{/privacy}",
"received_events_url": "https://api.github.com/users/javache/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 4
| 2025-01-24T11:53:35
| 2025-01-24T19:01:56
| 2025-01-24T19:01:43
|
MEMBER
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48917",
"html_url": "https://github.com/facebook/react-native/pull/48917",
"diff_url": "https://github.com/facebook/react-native/pull/48917.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48917.patch",
"merged_at": null
}
|
Summary:
Cleaning up this flag which has already been rolled out
Changelog: [Internal]
Differential Revision: D68622852
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48917/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48917/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48916
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48916/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48916/comments
|
https://api.github.com/repos/facebook/react-native/issues/48916/events
|
https://github.com/facebook/react-native/pull/48916
| 2,809,164,063
|
PR_kwDOAbrxp86I4jPH
| 48,916
|
Rollout completeReactInstanceCreationOnBgThreadOnAndroid and useImmediateExecutorInAndroidBridgeless
|
{
"login": "javache",
"id": 5676,
"node_id": "MDQ6VXNlcjU2NzY=",
"avatar_url": "https://avatars.githubusercontent.com/u/5676?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/javache",
"html_url": "https://github.com/javache",
"followers_url": "https://api.github.com/users/javache/followers",
"following_url": "https://api.github.com/users/javache/following{/other_user}",
"gists_url": "https://api.github.com/users/javache/gists{/gist_id}",
"starred_url": "https://api.github.com/users/javache/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/javache/subscriptions",
"organizations_url": "https://api.github.com/users/javache/orgs",
"repos_url": "https://api.github.com/users/javache/repos",
"events_url": "https://api.github.com/users/javache/events{/privacy}",
"received_events_url": "https://api.github.com/users/javache/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 4
| 2025-01-24T11:04:29
| 2025-01-24T19:01:52
| 2025-01-24T19:01:42
|
MEMBER
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48916",
"html_url": "https://github.com/facebook/react-native/pull/48916",
"diff_url": "https://github.com/facebook/react-native/pull/48916.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48916.patch",
"merged_at": null
}
|
Summary:
Cleaning up this feature flag since we no longer require this gating. This was already fulled rulled out as default.
Changelog: [Internal]
Differential Revision: D68621578
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48916/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48916/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48915
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48915/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48915/comments
|
https://api.github.com/repos/facebook/react-native/issues/48915/events
|
https://github.com/facebook/react-native/pull/48915
| 2,808,254,735
|
PR_kwDOAbrxp86I1cCg
| 48,915
|
Refactor `adjustSpannableFontToFit` to fix `adjustsFontSizeToFit` Text prop on Android
|
{
"login": "hrastnik",
"id": 3407234,
"node_id": "MDQ6VXNlcjM0MDcyMzQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/3407234?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hrastnik",
"html_url": "https://github.com/hrastnik",
"followers_url": "https://api.github.com/users/hrastnik/followers",
"following_url": "https://api.github.com/users/hrastnik/following{/other_user}",
"gists_url": "https://api.github.com/users/hrastnik/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hrastnik/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hrastnik/subscriptions",
"organizations_url": "https://api.github.com/users/hrastnik/orgs",
"repos_url": "https://api.github.com/users/hrastnik/repos",
"events_url": "https://api.github.com/users/hrastnik/events{/privacy}",
"received_events_url": "https://api.github.com/users/hrastnik/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 3253537094,
"node_id": "MDU6TGFiZWwzMjUzNTM3MDk0",
"url": "https://api.github.com/repos/facebook/react-native/labels/Shared%20with%20Meta",
"name": "Shared with Meta",
"color": "BFD4F2",
"default": false,
"description": "Applied via automation to indicate that an Issue or Pull Request has been shared with the team."
}
] |
open
| false
| null |
[] | null | 0
| 2025-01-24T00:57:40
| 2025-02-13T15:25:55
| null |
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48915",
"html_url": "https://github.com/facebook/react-native/pull/48915",
"diff_url": "https://github.com/facebook/react-native/pull/48915.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48915.patch",
"merged_at": null
}
|
## Summary:
The `adjustSpannableFontToFit` method had a miscalculation that caused incorrect font sizes to be applied to `Text` elements on Android when `adjustsFontSizeToFit` was set to `true`. Specifically, the applied font size incorrectly depended on the initial `fontSize` of the `Text` component rather than properly adjusting to fit the container.
In the screenshot below, the left side illustrates the issue. Three `Text` components display the same text:
`"This line must be the same size as the other ones with the same text."`
Each of these components has a `fontSize` value that would render the text larger than its container. With the `adjustsFontSizeToFit` prop enabled, the font size should adjust so the text fits within a single line.
However, due to the incorrect calculation, the font size depended on the initially applied `fontSize`, leading to inconsistent behavior.
The issue has been fixed, as shown on the right side of the screenshot. Now, the font size adjusts correctly to ensure the text fits the container, regardless of the initial `fontSize`.
In addition to resolving the issue, a binary search algorithm has been implemented to improve performance when determining the appropriate font size.
## Changelog:
[ANDROID] [FIXED] - Fixed `adjustsFontSizeToFit` on Android sometimes applying wrong fontSize
## Test Plan:
The screenshot above demonstrates the changes.
| null |
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48915/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48915/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48914
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48914/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48914/comments
|
https://api.github.com/repos/facebook/react-native/issues/48914/events
|
https://github.com/facebook/react-native/pull/48914
| 2,808,250,968
|
PR_kwDOAbrxp86I1bO3
| 48,914
|
Back out "Allow text links to be navigatable via keyboard by default"
|
{
"login": "joevilches",
"id": 17124862,
"node_id": "MDQ6VXNlcjE3MTI0ODYy",
"avatar_url": "https://avatars.githubusercontent.com/u/17124862?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/joevilches",
"html_url": "https://github.com/joevilches",
"followers_url": "https://api.github.com/users/joevilches/followers",
"following_url": "https://api.github.com/users/joevilches/following{/other_user}",
"gists_url": "https://api.github.com/users/joevilches/gists{/gist_id}",
"starred_url": "https://api.github.com/users/joevilches/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/joevilches/subscriptions",
"organizations_url": "https://api.github.com/users/joevilches/orgs",
"repos_url": "https://api.github.com/users/joevilches/repos",
"events_url": "https://api.github.com/users/joevilches/events{/privacy}",
"received_events_url": "https://api.github.com/users/joevilches/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
open
| false
| null |
[] | null | 1
| 2025-01-24T00:53:29
| 2025-02-13T15:25:55
| null |
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48914",
"html_url": "https://github.com/facebook/react-native/pull/48914",
"diff_url": "https://github.com/facebook/react-native/pull/48914.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48914.patch",
"merged_at": null
}
|
Summary: This was causing links to not ellipsize and be scrollable. Gonna revert while I see if I can workaround
Differential Revision: D68596950
| null |
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48914/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48914/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48913
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48913/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48913/comments
|
https://api.github.com/repos/facebook/react-native/issues/48913/events
|
https://github.com/facebook/react-native/pull/48913
| 2,808,208,417
|
PR_kwDOAbrxp86I1R-W
| 48,913
|
Support parsing hwb() functions
|
{
"login": "NickGerleman",
"id": 835219,
"node_id": "MDQ6VXNlcjgzNTIxOQ==",
"avatar_url": "https://avatars.githubusercontent.com/u/835219?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/NickGerleman",
"html_url": "https://github.com/NickGerleman",
"followers_url": "https://api.github.com/users/NickGerleman/followers",
"following_url": "https://api.github.com/users/NickGerleman/following{/other_user}",
"gists_url": "https://api.github.com/users/NickGerleman/gists{/gist_id}",
"starred_url": "https://api.github.com/users/NickGerleman/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/NickGerleman/subscriptions",
"organizations_url": "https://api.github.com/users/NickGerleman/orgs",
"repos_url": "https://api.github.com/users/NickGerleman/repos",
"events_url": "https://api.github.com/users/NickGerleman/events{/privacy}",
"received_events_url": "https://api.github.com/users/NickGerleman/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 3
| 2025-01-24T00:14:52
| 2025-01-27T20:11:24
| 2025-01-27T20:11:12
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48913",
"html_url": "https://github.com/facebook/react-native/pull/48913",
"diff_url": "https://github.com/facebook/react-native/pull/48913.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48913.patch",
"merged_at": null
}
|
Summary:
This brings us to parity with normalize-color, and is mostly similar to hsl, with the notable exception there is not a separate alpha variant, and only modern function syntax is supported. Again, I took the math from normalize-color, and sanity tested it against reference function provided by Color Spec.
I'm going to let that cap off color function support for now, and leave the rest as TODO.
Changelog: [Internal]
Differential Revision: D68594471
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48913/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48913/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48912
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48912/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48912/comments
|
https://api.github.com/repos/facebook/react-native/issues/48912/events
|
https://github.com/facebook/react-native/pull/48912
| 2,808,208,405
|
PR_kwDOAbrxp86I1R-K
| 48,912
|
Breaking: Remove incorrect hwb() syntax support from normalize-color
|
{
"login": "NickGerleman",
"id": 835219,
"node_id": "MDQ6VXNlcjgzNTIxOQ==",
"avatar_url": "https://avatars.githubusercontent.com/u/835219?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/NickGerleman",
"html_url": "https://github.com/NickGerleman",
"followers_url": "https://api.github.com/users/NickGerleman/followers",
"following_url": "https://api.github.com/users/NickGerleman/following{/other_user}",
"gists_url": "https://api.github.com/users/NickGerleman/gists{/gist_id}",
"starred_url": "https://api.github.com/users/NickGerleman/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/NickGerleman/subscriptions",
"organizations_url": "https://api.github.com/users/NickGerleman/orgs",
"repos_url": "https://api.github.com/users/NickGerleman/repos",
"events_url": "https://api.github.com/users/NickGerleman/events{/privacy}",
"received_events_url": "https://api.github.com/users/NickGerleman/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 4
| 2025-01-24T00:14:51
| 2025-01-27T20:11:22
| 2025-01-27T20:11:11
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48912",
"html_url": "https://github.com/facebook/react-native/pull/48912",
"diff_url": "https://github.com/facebook/react-native/pull/48912.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48912.patch",
"merged_at": null
}
|
Summary:
The implementation of `hwb()` color functions added in https://github.com/facebook/react-native/pull/34600 is pretty flawed.
`hwb()` color functions do not allow comma delimited values. So most of the examples in the unit test here will fail to parse on web. Like `hsl()`, these should also allow numeric non-hue components (instead of just %), and angle values for hue (instead of just numbers), and this is also missing support for alpha values, though these are less dangerous compared to allowing and encouraging incorrect delimiters.
https://www.w3.org/TR/css-color-4/#the-hwb-notation
These were added for web compat, and the examples fail to parse on web, so I'm opting to just remove this incorrect support before implementing this more correctly in the Fabric CSS parser in next diff. I did not attempt to fix the other issues I discovered with the PR implementation in the last couple diffs, around mixing and matching syntax allowed in legacy/modern, along with allowing inconsistent delimiters.
Changelog:
[General][Breaking] - Remove incorrect hwb() syntax support from normalize-color
Differential Revision: D68591172
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48912/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48912/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48911
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48911/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48911/comments
|
https://api.github.com/repos/facebook/react-native/issues/48911/events
|
https://github.com/facebook/react-native/issues/48911
| 2,807,980,659
|
I_kwDOAbrxp86nXmJz
| 48,911
|
Codegen and adding listeners
|
{
"login": "fgrs",
"id": 3940061,
"node_id": "MDQ6VXNlcjM5NDAwNjE=",
"avatar_url": "https://avatars.githubusercontent.com/u/3940061?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/fgrs",
"html_url": "https://github.com/fgrs",
"followers_url": "https://api.github.com/users/fgrs/followers",
"following_url": "https://api.github.com/users/fgrs/following{/other_user}",
"gists_url": "https://api.github.com/users/fgrs/gists{/gist_id}",
"starred_url": "https://api.github.com/users/fgrs/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/fgrs/subscriptions",
"organizations_url": "https://api.github.com/users/fgrs/orgs",
"repos_url": "https://api.github.com/users/fgrs/repos",
"events_url": "https://api.github.com/users/fgrs/events{/privacy}",
"received_events_url": "https://api.github.com/users/fgrs/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 470324689,
"node_id": "MDU6TGFiZWw0NzAzMjQ2ODk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Resolution:%20For%20Stack%20Overflow",
"name": "Resolution: For Stack Overflow",
"color": "d4c5f9",
"default": false,
"description": "A question for Stack Overflow. Applying this label will cause issue to be closed."
},
{
"id": 1794380150,
"node_id": "MDU6TGFiZWwxNzk0MzgwMTUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/Newer%20Patch%20Available",
"name": "Newer Patch Available",
"color": "d4c5f9",
"default": false,
"description": ""
}
] |
closed
| false
| null |
[] | null | 6
| 2025-01-23T21:44:06
| 2025-01-24T12:07:29
| 2025-01-24T12:07:28
|
NONE
| null | null | null | null |
### Description
I'm following this documentation [https://reactnative.dev/docs/turbo-native-modules-introduction#1-declare-typed-specification](https://reactnative.dev/docs/turbo-native-modules-introduction#1-declare-typed-specification) to extend my native module with onError listener. My first issue is when I try to add new function interface in the Spec file
```
addListener(eventName: string): void // Add an event listener
removeListeners(count: number): void // Remove event listeners
```
and update kotlin file with
```
fun removeListeners(count: Int) {
listenerCount -= count
}
```
the build fails due to 'count' being an Int.
My second issue is that I don't know how to subscribe to onError using New Architecture and the Spec file instead of importing NativeEventEmitter and NativeModules
I appreciate any help
### Steps to reproduce
yarn android
### React Native Version
0.76.3
### Affected Platforms
Runtime - Android
### Areas
TurboModule - The New Native Module System
### Output of `npx react-native info`
```text
System:
OS: macOS 15.1.1
CPU: (10) arm64 Apple M1 Pro
Memory: 104.56 MB / 16.00 GB
Shell:
version: "5.9"
path: /bin/zsh
Binaries:
Node:
version: 23.3.0
path: /opt/homebrew/bin/node
Yarn:
version: 1.22.21
path: /opt/homebrew/bin/yarn
npm:
version: 10.8.1
path: /usr/local/bin/npm
Watchman:
version: 2024.12.02.00
path: /opt/homebrew/bin/watchman
Managers:
CocoaPods:
version: 1.15.2
path: /opt/homebrew/bin/pod
SDKs:
iOS SDK:
Platforms:
- DriverKit 24.2
- iOS 18.2
- macOS 15.2
- tvOS 18.2
- visionOS 2.2
- watchOS 11.2
Android SDK: Not Found
IDEs:
Android Studio: 2022.3 AI-223.8836.35.2231.10811636
Xcode:
version: 16.2/16C5032a
path: /usr/bin/xcodebuild
Languages:
Java:
version: 18.0.1.1
path: /usr/bin/javac
Ruby:
version: 2.6.10
path: /usr/bin/ruby
npmPackages:
"@react-native-community/cli":
installed: 15.0.1
wanted: 15.0.1
react:
installed: 18.3.1
wanted: 18.3.1
react-native:
installed: 0.76.3
wanted: 0.76.3
react-native-macos: Not Found
npmGlobalPackages:
"*react-native*": Not Found
Android:
hermesEnabled: true
newArchEnabled: true
iOS:
hermesEnabled: true
newArchEnabled: true
```
### Stacktrace or Logs
```text
BUILD FAILED in 2s
error Failed to install the app. Command failed with exit code 1: ./gradlew app:installDebug -PreactNativeDevServerPort=8081
e: file:///.../NativeNfcManagerModule.kt:26:1 Class 'NativeNfcManagerModule' is not abstract and does not implement abstract base class member public abstract fun removeListeners(count: Double): Unit defined in com.nativenfcmanager.NativeNfcManagerSpec
e: file:///.../NativeNfcManagerModule.kt:60:7 'addListener' hides member of supertype 'NativeNfcManagerSpec' and needs 'override' modifier FAILURE: Build failed with an exception. * What went wrong:
Execution failed for task ':app:compileDebugKotlin'.
> A failure occurred while executing org.jetbrains.kotlin.compilerRunner.GradleCompilerRunnerWithWorkers$GradleKotlinCompilerWorkAction > Compilation error. See log for more details * Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.
> Get more help at https://help.gradle.org. BUILD FAILED in 2s.
info Run CLI with --verbose flag for more details.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
```
### Reproducer
sorry no link
### Screenshots and Videos
_No response_
|
{
"login": "react-native-bot",
"id": 32686087,
"node_id": "MDQ6VXNlcjMyNjg2MDg3",
"avatar_url": "https://avatars.githubusercontent.com/u/32686087?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/react-native-bot",
"html_url": "https://github.com/react-native-bot",
"followers_url": "https://api.github.com/users/react-native-bot/followers",
"following_url": "https://api.github.com/users/react-native-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/react-native-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/react-native-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/react-native-bot/subscriptions",
"organizations_url": "https://api.github.com/users/react-native-bot/orgs",
"repos_url": "https://api.github.com/users/react-native-bot/repos",
"events_url": "https://api.github.com/users/react-native-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/react-native-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48911/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48911/timeline
| null |
completed
|
{
"total": 0,
"completed": 0,
"percent_completed": 0
}
| false
|
https://api.github.com/repos/facebook/react-native/issues/48910
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48910/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48910/comments
|
https://api.github.com/repos/facebook/react-native/issues/48910/events
|
https://github.com/facebook/react-native/pull/48910
| 2,807,898,895
|
PR_kwDOAbrxp86I0M-f
| 48,910
|
Internalize ReactNativeFeatureFlags Accessor interfaces & Classes
|
{
"login": "mdvacca",
"id": 515103,
"node_id": "MDQ6VXNlcjUxNTEwMw==",
"avatar_url": "https://avatars.githubusercontent.com/u/515103?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mdvacca",
"html_url": "https://github.com/mdvacca",
"followers_url": "https://api.github.com/users/mdvacca/followers",
"following_url": "https://api.github.com/users/mdvacca/following{/other_user}",
"gists_url": "https://api.github.com/users/mdvacca/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mdvacca/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mdvacca/subscriptions",
"organizations_url": "https://api.github.com/users/mdvacca/orgs",
"repos_url": "https://api.github.com/users/mdvacca/repos",
"events_url": "https://api.github.com/users/mdvacca/events{/privacy}",
"received_events_url": "https://api.github.com/users/mdvacca/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 4
| 2025-01-23T21:02:51
| 2025-01-24T18:20:02
| 2025-01-24T18:19:51
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48910",
"html_url": "https://github.com/facebook/react-native/pull/48910",
"diff_url": "https://github.com/facebook/react-native/pull/48910.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48910.patch",
"merged_at": null
}
|
Summary:
Internalize ReactNativeFeatureFlags Accessor interfaces & Classes
changelog: [internal] internal
Differential Revision: D68579453
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48910/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48910/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48909
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48909/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48909/comments
|
https://api.github.com/repos/facebook/react-native/issues/48909/events
|
https://github.com/facebook/react-native/pull/48909
| 2,807,898,869
|
PR_kwDOAbrxp86I0M-H
| 48,909
|
Internalize ReactNativeFeatureFlags generated accessor classes
|
{
"login": "mdvacca",
"id": 515103,
"node_id": "MDQ6VXNlcjUxNTEwMw==",
"avatar_url": "https://avatars.githubusercontent.com/u/515103?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/mdvacca",
"html_url": "https://github.com/mdvacca",
"followers_url": "https://api.github.com/users/mdvacca/followers",
"following_url": "https://api.github.com/users/mdvacca/following{/other_user}",
"gists_url": "https://api.github.com/users/mdvacca/gists{/gist_id}",
"starred_url": "https://api.github.com/users/mdvacca/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mdvacca/subscriptions",
"organizations_url": "https://api.github.com/users/mdvacca/orgs",
"repos_url": "https://api.github.com/users/mdvacca/repos",
"events_url": "https://api.github.com/users/mdvacca/events{/privacy}",
"received_events_url": "https://api.github.com/users/mdvacca/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 982010329,
"node_id": "MDU6TGFiZWw5ODIwMTAzMjk=",
"url": "https://api.github.com/repos/facebook/react-native/labels/Merged",
"name": "Merged",
"color": "6f42c1",
"default": false,
"description": "This PR has been merged."
},
{
"id": 1208510250,
"node_id": "MDU6TGFiZWwxMjA4NTEwMjUw",
"url": "https://api.github.com/repos/facebook/react-native/labels/p:%20Facebook",
"name": "p: Facebook",
"color": "0052cc",
"default": false,
"description": "Partner: Facebook"
},
{
"id": 1215208045,
"node_id": "MDU6TGFiZWwxMjE1MjA4MDQ1",
"url": "https://api.github.com/repos/facebook/react-native/labels/Partner",
"name": "Partner",
"color": "0052cc",
"default": false,
"description": ""
},
{
"id": 1690952236,
"node_id": "MDU6TGFiZWwxNjkwOTUyMjM2",
"url": "https://api.github.com/repos/facebook/react-native/labels/fb-exported",
"name": "fb-exported",
"color": "ededed",
"default": false,
"description": null
}
] |
closed
| false
| null |
[] | null | 3
| 2025-01-23T21:02:50
| 2025-01-24T18:20:04
| 2025-01-24T18:19:52
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48909",
"html_url": "https://github.com/facebook/react-native/pull/48909",
"diff_url": "https://github.com/facebook/react-native/pull/48909.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48909.patch",
"merged_at": null
}
|
Summary:
Internalize ReactNativeFeatureFlags generated accessor classes
changelog: [internal] internal
Differential Revision: D68579670
|
{
"login": "facebook-github-bot",
"id": 6422482,
"node_id": "MDQ6VXNlcjY0MjI0ODI=",
"avatar_url": "https://avatars.githubusercontent.com/u/6422482?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/facebook-github-bot",
"html_url": "https://github.com/facebook-github-bot",
"followers_url": "https://api.github.com/users/facebook-github-bot/followers",
"following_url": "https://api.github.com/users/facebook-github-bot/following{/other_user}",
"gists_url": "https://api.github.com/users/facebook-github-bot/gists{/gist_id}",
"starred_url": "https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/facebook-github-bot/subscriptions",
"organizations_url": "https://api.github.com/users/facebook-github-bot/orgs",
"repos_url": "https://api.github.com/users/facebook-github-bot/repos",
"events_url": "https://api.github.com/users/facebook-github-bot/events{/privacy}",
"received_events_url": "https://api.github.com/users/facebook-github-bot/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48909/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48909/timeline
| null | null | null | true
|
https://api.github.com/repos/facebook/react-native/issues/48908
|
https://api.github.com/repos/facebook/react-native
|
https://api.github.com/repos/facebook/react-native/issues/48908/labels{/name}
|
https://api.github.com/repos/facebook/react-native/issues/48908/comments
|
https://api.github.com/repos/facebook/react-native/issues/48908/events
|
https://github.com/facebook/react-native/pull/48908
| 2,807,635,196
|
PR_kwDOAbrxp86IzS3M
| 48,908
|
Add Google Chrome flags when running devtool to force a separate Chrome instance
|
{
"login": "hrastnik",
"id": 3407234,
"node_id": "MDQ6VXNlcjM0MDcyMzQ=",
"avatar_url": "https://avatars.githubusercontent.com/u/3407234?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/hrastnik",
"html_url": "https://github.com/hrastnik",
"followers_url": "https://api.github.com/users/hrastnik/followers",
"following_url": "https://api.github.com/users/hrastnik/following{/other_user}",
"gists_url": "https://api.github.com/users/hrastnik/gists{/gist_id}",
"starred_url": "https://api.github.com/users/hrastnik/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hrastnik/subscriptions",
"organizations_url": "https://api.github.com/users/hrastnik/orgs",
"repos_url": "https://api.github.com/users/hrastnik/repos",
"events_url": "https://api.github.com/users/hrastnik/events{/privacy}",
"received_events_url": "https://api.github.com/users/hrastnik/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
[
{
"id": 196858975,
"node_id": "MDU6TGFiZWwxOTY4NTg5NzU=",
"url": "https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed",
"name": "CLA Signed",
"color": "ffffff",
"default": false,
"description": "This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed."
},
{
"id": 3253537094,
"node_id": "MDU6TGFiZWwzMjUzNTM3MDk0",
"url": "https://api.github.com/repos/facebook/react-native/labels/Shared%20with%20Meta",
"name": "Shared with Meta",
"color": "BFD4F2",
"default": false,
"description": "Applied via automation to indicate that an Issue or Pull Request has been shared with the team."
}
] |
closed
| false
| null |
[] | null | 2
| 2025-01-23T18:34:50
| 2025-01-24T14:05:22
| 2025-01-24T14:05:22
|
CONTRIBUTOR
| null | null | false
|
{
"url": "https://api.github.com/repos/facebook/react-native/pulls/48908",
"html_url": "https://github.com/facebook/react-native/pull/48908",
"diff_url": "https://github.com/facebook/react-native/pull/48908.diff",
"patch_url": "https://github.com/facebook/react-native/pull/48908.patch",
"merged_at": null
}
|
## Summary:
On macOS, pressing Cmd + Q typically closes an app. However, since the React Native dev tools run as a Chrome instance, using Cmd + Q to close the dev tools also closes all open Chrome windows. This can be problematic, as it leads to losing not just the dev tools, but any other active Chrome sessions as well, without the usual "Hold to Quit" prompt that standard Chrome windows provide.
This happened to me more than once, and I wanted to address this by ensuring that the dev tools run in a separate, independent Chrome instance. To achieve this, I added the --user-data-dir flag when launching the dev server. As a result, closing the dev tools no longer results in closing all Chrome windows, preserving other active sessions.
Additionally, this change makes the dev tools appear as a separate icon when using Cmd + Tab to switch between apps, making it easier to navigate between your development tools and other applications.
## Changelog:
[GENERAL] [CHANGED] - React Native DevTools now run as a separate chrome instance
## Test Plan:
Run the DevTools, and ensure nothing breaks.
|
{
"login": "huntie",
"id": 2547783,
"node_id": "MDQ6VXNlcjI1NDc3ODM=",
"avatar_url": "https://avatars.githubusercontent.com/u/2547783?v=4",
"gravatar_id": "",
"url": "https://api.github.com/users/huntie",
"html_url": "https://github.com/huntie",
"followers_url": "https://api.github.com/users/huntie/followers",
"following_url": "https://api.github.com/users/huntie/following{/other_user}",
"gists_url": "https://api.github.com/users/huntie/gists{/gist_id}",
"starred_url": "https://api.github.com/users/huntie/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/huntie/subscriptions",
"organizations_url": "https://api.github.com/users/huntie/orgs",
"repos_url": "https://api.github.com/users/huntie/repos",
"events_url": "https://api.github.com/users/huntie/events{/privacy}",
"received_events_url": "https://api.github.com/users/huntie/received_events",
"type": "User",
"user_view_type": "public",
"site_admin": false
}
|
{
"url": "https://api.github.com/repos/facebook/react-native/issues/48908/reactions",
"total_count": 0,
"+1": 0,
"-1": 0,
"laugh": 0,
"hooray": 0,
"confused": 0,
"heart": 0,
"rocket": 0,
"eyes": 0
}
|
https://api.github.com/repos/facebook/react-native/issues/48908/timeline
| null | null | null | true
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.