commit_hash stringlengths 40 40 | author stringlengths 1 57 | date timestamp[s]date 2010-07-26 04:45:09 2026-04-14 18:21:10 | message stringlengths 8 1.39M | diff stringlengths 68 51.2k | files_changed int64 1 136 | insertions int64 0 2.35k | deletions int64 0 1.9k |
|---|---|---|---|---|---|---|---|
02bff0f9b603d91ceaa5b5c69225c2159473a840 | Manish Goregaokar | 2017-01-11T20:25:46 | servo: Merge #13972 - ImageMaps: Implemented support for parsing coord attribute to a shape… (from shravan-achar:master); r=Manishearth,emilio,jdm
<!-- Please describe your changes on the following line: -->
Image Maps: (Part 1) Implemented support for parsing coord attribute to a shape object.
... | diff --git a/script/dom/htmlanchorelement.rs b/script/dom/htmlanchorelement.rs
index 52c355f2b..3731b9d46 100644
--- a/script/dom/htmlanchorelement.rs
+++ b/script/dom/htmlanchorelement.rs
@@ -576,7 +576,7 @@ fn is_current_browsing_context(target: DOMString) -> bool {
}
/// https://html.spec.whatwg.org/multipage/#f... | 4 | 339 | 2 |
f282d447277cacdcc25affb17fc03162fda300a6 | Ms2ger | 2017-01-11T19:31:15 | servo: Merge #14961 - Move DevicePixel to script_traits (from Ms2ger:DevicePixel); r=nox
Source-Repo: https://github.com/servo/servo
Source-Revision: 5d3847dddc9bb7907abfa5d38a7927d6c656fbc1 | diff --git a/compositing/compositor.rs b/compositing/compositor.rs
index d852ae728..ea0da5168 100644
--- a/compositing/compositor.rs
+++ b/compositing/compositor.rs
@@ -11,8 +11,7 @@ use euclid::Point2D;
use euclid::point::TypedPoint2D;
use euclid::scale_factor::ScaleFactor;
use euclid::size::TypedSize2D;
-use gfx_t... | 6 | 11 | 18 |
ba7da078d95a8fcf608988c6480ae5a391c8dfb2 | Charles Vandevoorde | 2017-01-11T18:34:04 | servo: Merge #14911 - Handle properly alternate stylesheet (from charlesvdv:alternate-stylesheet); r=cbrewster
<!-- Please describe your changes on the following line: -->
Alternate stylesheet are now fetched and then desactivated instead of ignoring them.
I don't know if tests are required to check if the stylesheet... | diff --git a/script/dom/htmllinkelement.rs b/script/dom/htmllinkelement.rs
index 24b4e7790..3466fa10d 100644
--- a/script/dom/htmllinkelement.rs
+++ b/script/dom/htmllinkelement.rs
@@ -99,6 +99,17 @@ impl HTMLLinkElement {
})
})
}
+
+ pub fn is_alternate(&self) -> bool {
+ let rel =... | 2 | 16 | 11 |
c45349b2f489a5aa605b1cba19cb4a6edc287fa0 | Anthony Ramine | 2017-01-11T17:37:23 | servo: Merge #14959 - Introduce PendingScript (from nox:pending-script); r=Ms2ger
Source-Repo: https://github.com/servo/servo
Source-Revision: d1bc1a4f1b66ab9f63fa37f649eaf79035e12f8e | diff --git a/script/dom/bindings/cell.rs b/script/dom/bindings/cell.rs
index fc26ca013..8e82de943 100644
--- a/script/dom/bindings/cell.rs
+++ b/script/dom/bindings/cell.rs
@@ -11,7 +11,7 @@ use style::thread_state;
///
/// This extends the API of `core::cell::RefCell` to allow unsafe access in
/// certain situation... | 5 | 178 | 94 |
65b25fb3dc9dca04cc8937789eeca5494d720d1d | Xidorn Quan | 2017-01-11T16:35:24 | servo: Merge #14956 - Extend supported geometry box value for geckolib (from upsuper:geometry-boxes); r=Manishearth
<!-- Please describe your changes on the following line: -->
r? @Manishearth
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` ... | diff --git a/style/properties/gecko.mako.rs b/style/properties/gecko.mako.rs
index 31d873400..4d3b1c999 100644
--- a/style/properties/gecko.mako.rs
+++ b/style/properties/gecko.mako.rs
@@ -1565,6 +1565,14 @@ fn static_assert() {
T::border_box => StyleGeometryBox::Border,
T::padding_box => Styl... | 4 | 24 | 4 |
b5d7715bb3d5df4b7592ef385ad66a88c645130a | Ms2ger | 2017-01-11T13:37:45 | servo: Merge #14929 - Update image (from servo:update-image); r=mbrubeck
Source-Repo: https://github.com/servo/servo
Source-Revision: 12c71c57d178ee5bfd383063ddebb4763006eaf4 | diff --git a/compositing/Cargo.toml b/compositing/Cargo.toml
index df1514714..6f7e8e04c 100644
--- a/compositing/Cargo.toml
+++ b/compositing/Cargo.toml
@@ -13,7 +13,7 @@ path = "lib.rs"
euclid = "0.10.1"
gfx_traits = {path = "../gfx_traits"}
gleam = "0.2.8"
-image = "0.10"
+image = "0.12"
ipc-channel = "0.5"
log ... | 4 | 4 | 4 |
6779b23266bdf79c9d82dce97be288cf276a027b | Anthony Ramine | 2017-01-10T17:38:07 | servo: Merge #14943 - Introduce ExternalScriptKind to simplify HTMLScriptElement::prepare (from nox:external-script-kind); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: c784bc69443ee6f4f3bd54474ac0e03a2bb92a6f | diff --git a/script/dom/htmlscriptelement.rs b/script/dom/htmlscriptelement.rs
index 9c2bcfd58..f2eb73123 100644
--- a/script/dom/htmlscriptelement.rs
+++ b/script/dom/htmlscriptelement.rs
@@ -40,6 +40,7 @@ use std::ascii::AsciiExt;
use std::cell::Cell;
use std::sync::{Arc, Mutex};
use style::str::{HTML_SPACE_CHARAC... | 1 | 74 | 66 |
fd1952bfc114bd0575669b9814c3e7e727f9a183 | Ms2ger | 2017-01-10T16:00:43 | servo: Merge #14942 - Fix some warnings (from servo:warnings); r=nox
Source-Repo: https://github.com/servo/servo
Source-Revision: b5b5533d675db5e015f0596568c369c6cfc6ebb9 | diff --git a/script/dom/urlhelper.rs b/script/dom/urlhelper.rs
index ec50b4edb..5037d7fb7 100644
--- a/script/dom/urlhelper.rs
+++ b/script/dom/urlhelper.rs
@@ -11,9 +11,6 @@ use url::quirks;
pub struct UrlHelper;
impl UrlHelper {
- pub fn SameOrigin(url_a: &ServoUrl, url_b: &ServoUrl) -> bool {
- url_a.o... | 2 | 1 | 4 |
b7e771b8433ce79d04bbb39954225e9430b5d745 | Ms2ger | 2017-01-10T15:02:23 | servo: Merge #14938 - Various cleanup around gfx_traits (from servo:gfx-traits); r=nox
Source-Repo: https://github.com/servo/servo
Source-Revision: f674a9db8b7164dae667875c5cf19b3aabb18ef2 | diff --git a/compositing/compositor.rs b/compositing/compositor.rs
index 1d67d9f4b..d852ae728 100644
--- a/compositing/compositor.rs
+++ b/compositing/compositor.rs
@@ -11,8 +11,8 @@ use euclid::Point2D;
use euclid::point::TypedPoint2D;
use euclid::scale_factor::ScaleFactor;
use euclid::size::TypedSize2D;
-use gfx_t... | 8 | 30 | 97 |
032ef8a4f16cedb3b5c9c5ca4286e37051f7c603 | Martin Robinson | 2017-01-10T12:48:31 | servo: Merge #14603 - Rework the way scroll roots are collected (from mrobinson:collect-scoll-roots); r=emilio
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data... | diff --git a/gfx/display_list/mod.rs b/gfx/display_list/mod.rs
index eeb78f9f9..1de082bdf 100644
--- a/gfx/display_list/mod.rs
+++ b/gfx/display_list/mod.rs
@@ -303,9 +303,6 @@ pub struct StackingContext {
/// The scroll policy of this layer.
pub scroll_policy: ScrollPolicy,
- /// Children of this Stacki... | 17 | 224 | 272 |
641740ff7164dc545bd0c5f44ce5170b58f19a0b | Anthony Ramine | 2017-01-10T11:51:47 | servo: Merge #14928 - Unify text insertion when parsing HTML and XML (from nox:insert); r=SimonSapin
Source-Repo: https://github.com/servo/servo
Source-Revision: f54dd0112bd9e51b21e9a5ee38bb2cfc0326e071 | diff --git a/script/dom/servoparser/html.rs b/script/dom/servoparser/html.rs
index 4a8f01d63..d4b53175b 100644
--- a/script/dom/servoparser/html.rs
+++ b/script/dom/servoparser/html.rs
@@ -19,7 +19,6 @@ use dom::htmlscriptelement::HTMLScriptElement;
use dom::htmltemplateelement::HTMLTemplateElement;
use dom::node::No... | 3 | 26 | 29 |
f3fe8e8bd3de7d3c1b1c33649dbbd0979a73ae21 | Xidorn Quan | 2017-01-10T04:10:32 | servo: Merge #14920 - Correctly handle unserializable shorthand (from upsuper:shorthand-variable); r=emilio
get_shorthand_appendable_value doesn't always return a serializable value. This change makes it handle that case correctly.
This change also updates step number in property_value_to_css to reflect the latest sp... | diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs
index 4a29ea7aa..822a0924e 100644
--- a/style/properties/declaration_block.rs
+++ b/style/properties/declaration_block.rs
@@ -86,21 +86,21 @@ impl PropertyDeclarationBlock {
pub fn property_value_to_css<W>(&self, property: &... | 1 | 14 | 12 |
08279dc39cb9ae497a564234df4f22a740ada34b | bd339 | 2017-01-10T02:36:38 | servo: Merge #14868 - Fix loss of response type information in Fetch API (from bd339:iss14068); r=jdm
<!-- Please describe your changes on the following line: -->
Avoids mapping response types that are distinct according to [the spec](https://fetch.spec.whatwg.org/#concept-response-type) to fewer response types. Also ... | diff --git a/net_traits/lib.rs b/net_traits/lib.rs
index e20d856a1..5ba5f61e3 100644
--- a/net_traits/lib.rs
+++ b/net_traits/lib.rs
@@ -172,8 +172,10 @@ pub trait FetchTaskTarget {
#[derive(Serialize, Deserialize)]
pub enum FilteredMetadata {
+ Basic(Metadata),
+ Cors(Metadata),
Opaque,
- Transparent... | 4 | 44 | 14 |
a9a7cf221c194ad60f579a73c96c785041cafa99 | Glenn Watson | 2017-01-09T19:56:40 | servo: Merge #14818 - Update WR (first phase of z-buffer optimizations / improvements) (from glennw:zb); r=pcwalton
Source-Repo: https://github.com/servo/servo
Source-Revision: 851d6230f3836dccdad932d553488c2420b4dbb3 | diff --git a/compositing/compositor.rs b/compositing/compositor.rs
index 2cd615150..1d67d9f4b 100644
--- a/compositing/compositor.rs
+++ b/compositing/compositor.rs
@@ -275,6 +275,7 @@ enum CompositeTarget {
struct RenderTargetInfo {
framebuffer_ids: Vec<gl::GLuint>,
+ renderbuffer_ids: Vec<gl::GLuint>,
... | 2 | 17 | 1 |
8404c21124c19c78fe9a6589ca46f2d01f389d6a | Ms2ger | 2017-01-09T17:29:46 | servo: Merge #14927 - Use the typed array APIs in ImageData (from servo:ImageData-data); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: 9482467addebf6469f86331b34aaf7aab72fa0eb | diff --git a/script/dom/imagedata.rs b/script/dom/imagedata.rs
index 877510c7d..4cc6f3fa2 100644
--- a/script/dom/imagedata.rs
+++ b/script/dom/imagedata.rs
@@ -10,11 +10,10 @@ use dom::bindings::reflector::{Reflector, reflect_dom_object};
use dom::globalscope::GlobalScope;
use euclid::size::Size2D;
use js::jsapi::{... | 1 | 11 | 20 |
3fb9c4bdc3553e9deae0dd0f7534cae5636651e5 | Frederick F. Kautz IV | 2017-01-09T15:35:28 | servo: Merge #14917 - Renaming default_features to default-features as per Cargo's Manifest Format (from fkautz:pr_out_renaming_default_features_to_default_features_as_per_cargo_s_manifest_format); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: 93ac10d9b1d34e85f9c1b4ba809b20ad6d9d0f90 | diff --git a/canvas/Cargo.toml b/canvas/Cargo.toml
index 4416e1cb0..141bf7264 100644
--- a/canvas/Cargo.toml
+++ b/canvas/Cargo.toml
@@ -24,5 +24,5 @@ servo_config = {path = "../config"}
[dependencies.webrender_traits]
git = "https://github.com/servo/webrender"
-default_features = false
+default-features = false
f... | 13 | 13 | 13 |
bc972bae0b36d4c464d4404b8a184de32f72988c | Martin Robinson | 2017-01-09T12:31:30 | servo: Merge #14926 - Move some methods from display_list_builder.rs (from mrobinson:move-display-list-builder-methods); r=emilio
These methods are not only used during display list construction, so
they are a better fit for the flow structs themselves. This does
not introduce any behavior change, but should make it e... | diff --git a/layout/block.rs b/layout/block.rs
index 5934a506e..bdb38742a 100644
--- a/layout/block.rs
+++ b/layout/block.rs
@@ -31,7 +31,7 @@ use app_units::{Au, MAX_AU};
use context::{LayoutContext, SharedLayoutContext};
use display_list_builder::{BorderPaintingMode, DisplayListBuildState, FragmentDisplayListBuildi... | 3 | 174 | 174 |
602eb6e754b348fa10b5bef135d833f7476148ff | Cameron McCormack | 2017-01-09T10:46:09 | servo: Merge #14922 - Don't inherit all properties for eagerly computed pseudos if there are no matching rules (from heycam:pseudo-inherit); r=emilio
<!-- Please describe your changes on the following line: -->
When we resolve style for an eagerly computed pseudo-element, such as an anonymous box, if there are no mat... | diff --git a/script_layout_interface/wrapper_traits.rs b/script_layout_interface/wrapper_traits.rs
index 0103b1850..6ee40a343 100644
--- a/script_layout_interface/wrapper_traits.rs
+++ b/script_layout_interface/wrapper_traits.rs
@@ -394,7 +394,7 @@ pub trait ThreadSafeLayoutElement: Clone + Copy + Sized + Debug +
... | 2 | 23 | 23 |
dd4160207d354ede24369f68832e6d620d486514 | Cameron McCormack | 2017-01-09T03:13:36 | servo: Merge #14909 - stylo: update bindings (from heycam:bindings-update-16); r=Manishearth
Bindings update for https://treeherder.mozilla.org/#/jobs?repo=stylo&revision=5a96506c9435a414d37308298f526d25ea402607.
r? @Manishearth
Source-Repo: https://github.com/servo/servo
Source-Revision: 6a9e2fd7fb2b985909efeb71ed0... | diff --git a/style/build_gecko.rs b/style/build_gecko.rs
index 2b75121f1..161a0e86f 100644
--- a/style/build_gecko.rs
+++ b/style/build_gecko.rs
@@ -244,7 +244,6 @@ mod bindings {
"NODE_.*",
"NS_FONT_.*",
"NS_STYLE_.*",
- "NS_CORNER_.*",
"NS_RADIUS_.*",
... | 6 | 314 | 294 |
58910d5970cc1de663d71aae9e8173df9bce3448 | Dowon Cha | 2017-01-08T16:57:52 | servo: Merge #14895 - Added Websocket to RequestMode enum (from dowoncha:request-websocket); r=jdm
Added Websocket to RequestMode enum
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not... | diff --git a/net/resource_thread.rs b/net/resource_thread.rs
index 698f992fc..925b5e19c 100644
--- a/net/resource_thread.rs
+++ b/net/resource_thread.rs
@@ -330,6 +330,7 @@ impl CoreResourceManager {
let ua = self.user_agent.clone();
let dc = self.devtools_chan.clone();
let filemanager = self... | 3 | 3 | 0 |
73a9b4e9287bf1439989c40551a39b69e4f62f37 | Nazım Can Altınova | 2017-01-08T14:24:02 | servo: Merge #14913 - Refactor box longhands (from canaltinova:box-longhands); r=Manishearth
<!-- Please describe your changes on the following line: -->
Converted some longhands into `vector_longhand` to reduce some repeated codes.
Also some of longhands with same `SpecifiedValue` and `computed_value::T` changed. Re-... | diff --git a/style/animation.rs b/style/animation.rs
index 63446b9b2..8ce3077f2 100644
--- a/style/animation.rs
+++ b/style/animation.rs
@@ -14,10 +14,10 @@ use keyframes::{KeyframesStep, KeyframesStepValue};
use properties::{self, CascadeFlags, ComputedValues, Importance};
use properties::animated_properties::{Anima... | 4 | 213 | 389 |
eac95c8c1ffecdf7d98da94e163545afa571059b | Nazım Can Altınova | 2017-01-08T00:50:27 | servo: Merge #14899 - Fix serialization of timing-function (from canaltinova:transition-timing); r=Manishearth
<!-- Please describe your changes on the following line: -->
`transition-timing-function` and `animation-timing-function` properties corrected to reflect [the spec](https://drafts.csswg.org/css-transitions/#s... | diff --git a/style/properties/longhand/box.mako.rs b/style/properties/longhand/box.mako.rs
index df82244fa..1fd2be224 100644
--- a/style/properties/longhand/box.mako.rs
+++ b/style/properties/longhand/box.mako.rs
@@ -495,60 +495,60 @@ ${helpers.single_keyword("overflow-x", "visible hidden scroll auto",
... | 2 | 208 | 85 |
9289cc2b3e9dc23771e94305f07773b004bb5f3a | Emilio Cobos Álvarez | 2017-01-07T23:28:15 | servo: Merge #14904 - Allow sharing non-common style affecting attribute selectors (from emilio:non-common-attrs); r=bholley
Something I just noticed while re-reading that code is that we prevent sharing among siblings with different non-common attributes, even though we already have the infra to match those selectors... | diff --git a/style/matching.rs b/style/matching.rs
index f8d019ea7..93dedbd21 100644
--- a/style/matching.rs
+++ b/style/matching.rs
@@ -30,6 +30,16 @@ use std::slice::IterMut;
use std::sync::Arc;
use stylist::ApplicableDeclarationBlock;
+/// Determines the amount of relations where we're going to share style.
+#[i... | 2 | 10 | 15 |
158ac7b5c65500084d98db56e863ac7895a90687 | Prudhvi Rampey | 2017-01-07T20:01:21 | servo: Merge #14891 - Cleaned up ripples due to MutJS to JS type change (from prampey:bluetooth-cleanup); r=jdm,emilio
<!-- Please describe your changes on the following line: -->
Changed all Mutable JS values to JS values in the following files and fixed any differences that might have been caused due to type change.... | diff --git a/script/dom/bluetooth.rs b/script/dom/bluetooth.rs
index dcbb398a4..ce4e15103 100644
--- a/script/dom/bluetooth.rs
+++ b/script/dom/bluetooth.rs
@@ -15,7 +15,7 @@ use dom::bindings::codegen::Bindings::EventHandlerBinding::EventHandlerNonNull;
use dom::bindings::codegen::UnionTypes::StringOrUnsignedLong;
u... | 6 | 38 | 38 |
bde1c3cd43bf0a36747700cd460b60cc9448056a | Anthony Ramine | 2017-01-07T18:57:36 | servo: Merge #14867 - Properly insert text in document when parsing (from nox:a-base-de-popopopop); r=metajack
Source-Repo: https://github.com/servo/servo
Source-Revision: f313e8baffe5a41d839c3e0de28e8cd6e7a4773a | diff --git a/script/Cargo.toml b/script/Cargo.toml
index 4be7dff4a..10ea03bc5 100644
--- a/script/Cargo.toml
+++ b/script/Cargo.toml
@@ -38,7 +38,7 @@ fnv = "1.0"
gfx_traits = {path = "../gfx_traits"}
heapsize = "0.3.6"
heapsize_derive = "0.1"
-html5ever = {version = "0.10.2", features = ["heap_size", "unstable"]}
+... | 6 | 70 | 16 |
a5afefd4a0d120f0918a6e14ffd8fed4d6349299 | Jure Podgoršek | 2017-01-07T17:40:46 | servo: Merge #14896 - Tidy assignments (from g1smo:tidy-assignments); r=jdm
<!-- Please describe your changes on the following line: -->
I've added a new tidy rule (no = in the beginning of line) + tests for it. Also cleaned up a few rust source files to accord with the new rule.
---
<!-- Thank you for contributing t... | diff --git a/layout/block.rs b/layout/block.rs
index f7370e00a..5934a506e 100644
--- a/layout/block.rs
+++ b/layout/block.rs
@@ -1283,8 +1283,8 @@ impl BlockFlow {
content_block_size,
available_block_size));
- candidate_block_size_iterator.c... | 3 | 6 | 6 |
e6e82a3fa1bf8afd236ee5a15763647552e5e3d4 | Simon Sapin | 2017-01-07T16:18:28 | servo: Merge #14889 - Upgrade to rustc 1.16.0-nightly (6f1ae663e 2017-01-06) (from servo:rustup); r=jdm
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
-... | diff --git a/bluetooth_traits/lib.rs b/bluetooth_traits/lib.rs
index e38c122f7..af2314817 100644
--- a/bluetooth_traits/lib.rs
+++ b/bluetooth_traits/lib.rs
@@ -2,8 +2,6 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
-#![featu... | 24 | 4 | 28 |
429461010a4102ec843a12070c577a0452cc2255 | Emilio Cobos Álvarez | 2017-01-07T13:03:41 | servo: Merge #14833 - style: Isolate the soon-to-be style-backend-specific code from the media_query module (from emilio:mq-refactor); r=heycam,bz
The idea here is having (for convenience) different `Expression` and `Device` representations for Gecko.
Both will be implemented in rust, but will use `nsMediaFeatures` a... | diff --git a/style/gecko/mod.rs b/style/gecko/mod.rs
index 0e49405d1..6166a64be 100644
--- a/style/gecko/mod.rs
+++ b/style/gecko/mod.rs
@@ -4,13 +4,18 @@
//! Gecko-specific style-system bits.
+pub mod conversions;
pub mod data;
+
+// TODO(emilio): Implement Gecko media query parsing and evaluation using
+// nsMe... | 7 | 323 | 195 |
7217e088c95fbca13b79f095599222b1ce59370f | Matt Brubeck | 2017-01-07T07:34:20 | servo: Merge #14874 - Update url, num_cpus, heapsize, webdriver (from mbrubeck:always-be-updating); r=Manishearth
Source-Repo: https://github.com/servo/servo
Source-Revision: 3b2a066088491743ddc6900c01ac59726d8927d8 | diff --git a/webdriver_server/Cargo.toml b/webdriver_server/Cargo.toml
index 0cc3b43f6..c20dc777e 100644
--- a/webdriver_server/Cargo.toml
+++ b/webdriver_server/Cargo.toml
@@ -26,4 +26,4 @@ servo_config = {path = "../config", features = ["servo"]}
servo_url = {path = "../url", features = ["servo"]}
url = {version = ... | 2 | 2 | 2 |
73b1f01fbd3b4d58c4010c2e96b8a33e7f3c1467 | Alan Jeffrey | 2017-01-06T11:53:35 | servo: Merge #14860 - Index the session past correctly when discarding (from asajeffrey:constellation-index-past-correctly-when-discarding); r=cbrewster
<!-- Please describe your changes on the following line: -->
Oops, indexed from the wrong end when discarding documents in #14312.
---
<!-- Thank you for contributi... | diff --git a/config/opts.rs b/config/opts.rs
index f4da06580..32195664f 100644
--- a/config/opts.rs
+++ b/config/opts.rs
@@ -521,7 +521,7 @@ pub fn default_opts() -> Opts {
userscripts: None,
user_stylesheets: Vec::new(),
output_file: None,
- max_session_history: 16,
+ max_sessi... | 2 | 5 | 4 |
42f25c3bf0226c26628bc256656405f9e62b577b | Xidorn Quan | 2017-01-06T10:35:42 | servo: Merge #14878 - stylo: Add :-moz-browser-frame pseudo-class (from upsuper:bug1329076); r=heycam
This is the servo part of [bug 1329076](https://bugzilla.mozilla.org/show_bug.cgi?id=1329076) which has been reviewed by @heycam.
Note that it adds some documents on top of the patches on MozReview.
r? @heycam
Sour... | diff --git a/style/build_gecko.rs b/style/build_gecko.rs
index 2eec1be1c..2b75121f1 100644
--- a/style/build_gecko.rs
+++ b/style/build_gecko.rs
@@ -254,6 +254,7 @@ mod bindings {
"mozilla::ServoStyleSheet",
"mozilla::ServoElementSnapshot.*",
"mozilla::ConsumeStyleBehavior",
+ ... | 6 | 247 | 3 |
3a780fe344151f8ce5485e224c57a375dd2209d7 | Xidorn Quan | 2017-01-06T08:09:32 | servo: Merge #14872 - stylo: Map more Gecko state bits to Servo state bits (from upsuper:bug1328806); r=bholley
This is the servo part of [bug 1328806](https://bugzilla.mozilla.org/show_bug.cgi?id=1328806) which has been reviewed by @bholley on Bugzilla.
r? @bholley
Source-Repo: https://github.com/servo/servo
Source... | diff --git a/style/element_state.rs b/style/element_state.rs
index 9ccd08334..3bfa55242 100644
--- a/style/element_state.rs
+++ b/style/element_state.rs
@@ -31,13 +31,13 @@ bitflags! {
const IN_CHECKED_STATE = 0x20,
#[doc = "https://html.spec.whatwg.org/multipage/#selector-indeterminate"]
con... | 3 | 7 | 7 |
e45f1dc1e10281cb5f3416dc9129205f61fb5774 | Josh Holmer | 2017-01-06T06:49:19 | servo: Merge #14871 - Use tinyfiledialogs from crates.io (from shssoichiro:14862-tinyfiledialogs-from-crates-io); r=jdm
Use the crates.io version of tinyfiledialogs instead of pulling directly from the git repository.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is co... | diff --git a/bluetooth/Cargo.toml b/bluetooth/Cargo.toml
index ca09b87a1..f90c4d2b7 100644
--- a/bluetooth/Cargo.toml
+++ b/bluetooth/Cargo.toml
@@ -18,4 +18,4 @@ servo_rand = {path = "../rand"}
uuid = {version = "0.3.1", features = ["v4"]}
[target.'cfg(target_os = "linux")'.dependencies]
-tinyfiledialogs = {git = ... | 3 | 3 | 3 |
9188198fc4a435ed6e1bed4aabcb974480d8490a | Ms2ger | 2017-01-05T22:00:50 | servo: Merge #14864 - Remove some unsound JSVal handling in JsTimerTask::invoke (from servo:timers); r=jdm
We were using Handles to *copies* of the traced values, rather than the
originals.
Source-Repo: https://github.com/servo/servo
Source-Revision: c3cf4386b04dd3609ada0824c32b0517f840d185 | diff --git a/script/timers.rs b/script/timers.rs
index b86bdc17a..881fe9b60 100644
--- a/script/timers.rs
+++ b/script/timers.rs
@@ -483,7 +483,6 @@ fn clamp_duration(nesting_level: u32, unclamped: MsDuration) -> MsDuration {
impl JsTimerTask {
// see https://html.spec.whatwg.org/multipage/#timer-initialisation... | 1 | 2 | 7 |
b517ccf82e6f6ce96aae3ec1579d8618494aeee4 | charlesvdv | 2017-01-05T20:09:01 | servo: Merge #14863 - Allow cli prefs to have numerical value (from charlesvdv:prefs); r=jdm
I'm not sure as I'm new with servo but shouldn't the new function ```parse_opt_prefs``` be in ```prefs.rs``` instead of ```opts.rs``` ?
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for cont... | diff --git a/config/opts.rs b/config/opts.rs
index ea1173c64..f4da06580 100644
--- a/config/opts.rs
+++ b/config/opts.rs
@@ -889,14 +889,7 @@ pub fn from_cmdline_args(args: &[String]) -> ArgumentParsingResult {
prefs::add_user_prefs();
for pref in opt_match.opt_strs("pref").iter() {
- let split: Vec<... | 1 | 15 | 8 |
0ed96384a5c84813856da1c522ce9beb61994635 | Alan Jeffrey | 2017-01-05T14:32:23 | servo: Merge #14351 - An in-memory RNG that shares its file descriptor (from asajeffrey:servo-rand-share-fds); r=emilio
<!-- Please describe your changes on the following line: -->
This PR implements an in-memory random number generator that only uses an OS RNG for (re)seeding. The OS RNG is shared, so there's only o... | diff --git a/bluetooth/Cargo.toml b/bluetooth/Cargo.toml
index b94363904..ca09b87a1 100644
--- a/bluetooth/Cargo.toml
+++ b/bluetooth/Cargo.toml
@@ -14,7 +14,7 @@ bitflags = "0.7"
bluetooth_traits = {path = "../bluetooth_traits"}
device = {git = "https://github.com/servo/devices", features = ["bluetooth-test"]}
ipc-... | 14 | 191 | 19 |
c17800cb524db6f1350c120975c055a15f66c3cf | Xidorn Quan | 2017-01-05T12:45:40 | servo: Merge #14857 - Add support for -moz-top-layer (from upsuper:moz-top-layer); r=emilio
<!-- Please describe your changes on the following line: -->
r? @Manishearth
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -... | diff --git a/style/properties/longhand/box.mako.rs b/style/properties/longhand/box.mako.rs
index a9942bb7f..df82244fa 100644
--- a/style/properties/longhand/box.mako.rs
+++ b/style/properties/longhand/box.mako.rs
@@ -94,9 +94,52 @@
</%helpers:longhand>
-${helpers.single_keyword("position", "static absolute relativ... | 1 | 47 | 7 |
de259ae8d20210b5a180ade3531d72a063c1bf4c | Hiroyuki Ikezoe | 2017-01-05T11:44:20 | servo: Merge #14851 - animation-iteration-count property is a number instead of integer (from hiikezoe:float-iteration-count-rebased); r=emilio
<!-- Please describe your changes on the following line: -->
This is a revised PR for #14732.
@emilio?
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]`... | diff --git a/style/animation.rs b/style/animation.rs
index 1545cac72..63446b9b2 100644
--- a/style/animation.rs
+++ b/style/animation.rs
@@ -32,7 +32,7 @@ pub enum KeyframesIterationState {
/// Infinite iterations, so no need to track a state.
Infinite,
/// Current and max iterations.
- Finite(u32, u3... | 2 | 9 | 8 |
7eddedab923dd55e803db2d6e43ee843d4501e87 | Alan Jeffrey | 2017-01-04T21:58:57 | servo: Merge #14312 - Implement discarding Document objects to reclaim space (from asajeffrey:script-discard-documents); r=cbrewster
<!-- Please describe your changes on the following line: -->
This PR implements document discarding. Active documents are kept alive strongly, but inactive documents are only kept alive... | diff --git a/config/opts.rs b/config/opts.rs
index a59cd56f0..ea1173c64 100644
--- a/config/opts.rs
+++ b/config/opts.rs
@@ -68,6 +68,9 @@ pub struct Opts {
pub output_file: Option<String>,
+ /// How much session history to keep in each tab.
+ pub max_session_history: usize,
+
/// Replace unpaires s... | 8 | 307 | 219 |
8be1ce71ef331355474da07f30a86b60678a5965 | Josh Matthews | 2017-01-04T20:19:00 | servo: Merge #14845 - Avoid restyling elements that aren't in a document (from jdm:restyle-ood); r=emilio
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #14480
- [X] There are tests for these changes
Source-Repo: https://github.com/servo/... | diff --git a/script/dom/document.rs b/script/dom/document.rs
index 83dc98071..d6d967db6 100644
--- a/script/dom/document.rs
+++ b/script/dom/document.rs
@@ -66,7 +66,7 @@ use dom::keyboardevent::KeyboardEvent;
use dom::location::Location;
use dom::messageevent::MessageEvent;
use dom::mouseevent::MouseEvent;
-use dom... | 2 | 9 | 3 |
d8f2af9930e0baa968a1e6d8a6bfe6ba168e2d43 | Emilio Cobos Álvarez | 2017-01-04T17:37:48 | servo: Merge #14844 - style: Simplify Debug impl for PropertyDeclaration reusing to_css (from emilio:to-css-simplification); r=SimonSapin
These two functions appear in the data from bug 1328497, and the second part of one is identical to the other.
I think the way to fix this is another one (either using static array... | diff --git a/style/properties/properties.mako.rs b/style/properties/properties.mako.rs
index 647a5e753..0a5eb2d30 100644
--- a/style/properties/properties.mako.rs
+++ b/style/properties/properties.mako.rs
@@ -842,17 +842,7 @@ impl fmt::Debug for PropertyDeclaration {
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::R... | 1 | 1 | 11 |
9c9911cf88089ee156610ec7ef76681e001fb0f9 | Josh Matthews | 2017-01-04T15:26:04 | servo: Merge #14841 - Track stylesheet load's document instead of using element's current document (from jdm:stylesheet_document); r=emilio
For cases where a stylesheet load finishes in a different document than it started, we need to be more careful about which document we report the completion to. In this case we ac... | diff --git a/script/stylesheet_loader.rs b/script/stylesheet_loader.rs
index 427593c85..28c5e86b6 100644
--- a/script/stylesheet_loader.rs
+++ b/script/stylesheet_loader.rs
@@ -6,6 +6,7 @@ use document_loader::LoadType;
use dom::bindings::inheritance::Castable;
use dom::bindings::refcounted::Trusted;
use dom::bindin... | 1 | 6 | 3 |
9aa857fbd800be2aa5ac8d8f72d141e792c4ee4f | Bobby Holley | 2017-01-04T03:20:59 | servo: Merge #14835 - Switch to crates.io for atomic_refcell (from bholley:external_atomic_refcell); r=Manishearth
r? @Manishearth
See #14828 for backstory.
Source-Repo: https://github.com/servo/servo
Source-Revision: 1e927ca88bf6622d5a87db75863f76976a1df56c | diff --git a/layout/Cargo.toml b/layout/Cargo.toml
index d3da21bf1..2d896fb5e 100644
--- a/layout/Cargo.toml
+++ b/layout/Cargo.toml
@@ -11,6 +11,7 @@ path = "lib.rs"
[dependencies]
app_units = "0.3"
+atomic_refcell = "0.1"
bitflags = "0.7"
canvas_traits = {path = "../canvas_traits"}
cssparser = {version = "0.7"... | 13 | 13 | 352 |
f9c376cdf9742568c754c09f72dc6434e7a2a8d6 | Bobby Holley | 2017-01-03T20:24:45 | servo: Merge #14828 - Reimplement AtomicRefCell with pure atomics (from bholley:faster_atomic_refcell); r=Manishearth
While reviewing @bzbarsky's patches in [1], I started typing out some lore about how mutable AtomicRefCell borrows are actually cheaper than immutable ones, so we should prefer them where possible. But... | diff --git a/style/atomic_refcell.rs b/style/atomic_refcell.rs
index ee6771bc5..fa6c76bfd 100644
--- a/style/atomic_refcell.rs
+++ b/style/atomic_refcell.rs
@@ -2,121 +2,345 @@
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
+//! ... | 2 | 299 | 76 |
a1a7687ef628b7a5c96a4b4bcb738ca0c9e299b6 | Matt McCoy | 2017-01-02T19:30:51 | servo: Merge #14784 - Updating http_network_or_cache_fetch to better match the fetch API spec (from mattnenterprise:fetch-api-updates); r=jdm,KiChjang
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete... | diff --git a/net/http_loader.rs b/net/http_loader.rs
index be73b5643..de066b824 100644
--- a/net/http_loader.rs
+++ b/net/http_loader.rs
@@ -579,6 +579,7 @@ pub fn http_fetch(request: Rc<Request>,
=> true,
_ => false
};
+
// Step 5
if response.is_none() {
// Substep 1
@@ -6... | 1 | 109 | 48 |
f79b6bf24d4bc007773349cd27d2683a7e61f337 | Florent FAYOLLE | 2017-01-02T18:35:04 | servo: Merge #14825 - Remove useless call to map() in constellation.rs (from fflorent:master); r=jdm
Remove a little bit useless call to map() in constellation.rs :)
Context: https://github.com/servo/servo/pull/14724/files#r94317893
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` whe... | diff --git a/constellation/constellation.rs b/constellation/constellation.rs
index ba14a9c82..87c555ac9 100644
--- a/constellation/constellation.rs
+++ b/constellation/constellation.rs
@@ -1735,12 +1735,10 @@ impl<Message, LTF, STF> Constellation<Message, LTF, STF>
let frame_id = frame_id.unwrap_or(self.root_f... | 1 | 1 | 3 |
80b171c4612b6ec3a3de7e5e69d9ad2a379b37ae | Simon Sapin | 2017-01-02T11:03:40 | servo: Merge #14689 - Update to rustc 1.16.0-nightly (4ecc85beb 2016-12-28) (from servo:rustup); r=Manishearth
<s>**This is not ready to land** since there is no corresponding Nightly build of Rust yet.</s> Update: we got a Nightly build on 2016-12-29: http://rusty-dash.com/nightlies
I made these changes to check tha... | diff --git a/plugins/lints/unrooted_must_root.rs b/plugins/lints/unrooted_must_root.rs
index 328b14359..380e239fe 100644
--- a/plugins/lints/unrooted_must_root.rs
+++ b/plugins/lints/unrooted_must_root.rs
@@ -123,7 +123,7 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for UnrootedPass {
cx: &LateContext<'a, ... | 2 | 13 | 7 |
c8e8c611418974b1c7e7126d29581258f5211b8f | Simon Sapin | 2017-01-02T10:08:01 | servo: Merge #14821 - More docs in style (from servo:docs-in-style); r=emilio
Follow up to #14802.
r? @emilio
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ... | diff --git a/style/bezier.rs b/style/bezier.rs
index 0d74bf5da..2bae08ac8 100644
--- a/style/bezier.rs
+++ b/style/bezier.rs
@@ -12,7 +12,7 @@ use euclid::point::Point2D;
const NEWTON_METHOD_ITERATIONS: u8 = 8;
-/// A Bézier curve.
+/// A unit cubic Bézier curve, used for timing functions in CSS transitions and an... | 2 | 9 | 3 |
05928616ef883ea4145ac80b0902a48cab655b14 | Xidorn Quan | 2017-01-01T06:33:47 | servo: Merge #14769 - Update helper functions of StyleComplexColor (from upsuper:complex-color-update); r=heycam
<!-- Please describe your changes on the following line: -->
The definition of `StyleComplexColor` in the Gecko side was updated in [bug 1063162](https://bugzilla.mozilla.org/show_bug.cgi?id=1063162). The h... | diff --git a/style/gecko_bindings/structs_debug.rs b/style/gecko_bindings/structs_debug.rs
index f2d52e592..322873f76 100644
--- a/style/gecko_bindings/structs_debug.rs
+++ b/style/gecko_bindings/structs_debug.rs
@@ -3042,6 +3042,7 @@ pub mod root {
pub struct StyleComplexColor {
pub mColor: root:... | 3 | 12 | 0 |
e6c7a2f228f1b63820dd6d9dcd35ef9d232f332d | Julien Levesy | 2017-01-01T05:28:41 | servo: Merge #14796 - replace match by if let statements if possible (from jlevesy:jl-match-to-if-let); r=Wafflespeanut
<!-- Please describe your changes on the following line: -->
Hi there,
This PR replaces `match` statements by `if let` when possible.
Thanks for reviewing
---
<!-- Thank you for contributing to Se... | diff --git a/compositing/compositor.rs b/compositing/compositor.rs
index 4f667bfbe..2cd615150 100644
--- a/compositing/compositor.rs
+++ b/compositing/compositor.rs
@@ -449,13 +449,11 @@ impl<Window: WindowMethods> IOCompositor<Window> {
while self.port.try_recv_compositor_msg().is_some() {}
// Tell... | 6 | 21 | 32 |
979560bc95a852bcbc41b179713a5d19490db6ca | Emilio Cobos Álvarez | 2016-12-31T23:34:51 | servo: Merge #14802 - Document more style modules (from emilio:no-missing-docs); r=Wafflespeanut
Source-Repo: https://github.com/servo/servo
Source-Revision: 2ebcad10f58151a1c531d80794a0211ba12cbeb0 | diff --git a/style/bezier.rs b/style/bezier.rs
index ba3d33a23..0d74bf5da 100644
--- a/style/bezier.rs
+++ b/style/bezier.rs
@@ -6,10 +6,13 @@
//!
//! This is based on `WebCore/platform/graphics/UnitBezier.h` in WebKit.
+#![deny(missing_docs)]
+
use euclid::point::Point2D;
const NEWTON_METHOD_ITERATIONS: u8 = 8... | 9 | 282 | 76 |
6662b07baaf332fed1d15a13a72e8e345fc2f24c | Eric Anholt | 2016-12-31T22:21:20 | servo: Merge #14809 - webgl: Validate enums for blendEquation (from anholt:webgl-blend-enums); r=emilio
Improves a conformance test that tried passing in desktop GL enums for
blending.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with app... | diff --git a/script/dom/webglrenderingcontext.rs b/script/dom/webglrenderingcontext.rs
index 81dfe8042..7ac39c13e 100644
--- a/script/dom/webglrenderingcontext.rs
+++ b/script/dom/webglrenderingcontext.rs
@@ -788,11 +788,19 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext {
// https://www.khronos.o... | 1 | 8 | 0 |
9d8eba0861027a3f2990ed9a9b642c5b319d8515 | Nazım Can Altınova | 2016-12-31T19:26:21 | servo: Merge #14757 - Fix `overflow` serialization with CSS-wide keywords (from canaltinova:overflow); r=Manishearth
<!-- Please describe your changes on the following line: -->
Overflow does not behave like a normal shorthand. CSS-wide keywords were handled in their `to_css_declared` method. So I had to bypass this c... | diff --git a/style/properties/declaration_block.rs b/style/properties/declaration_block.rs
index 0cf96724d..80ba5787d 100644
--- a/style/properties/declaration_block.rs
+++ b/style/properties/declaration_block.rs
@@ -111,7 +111,7 @@ impl PropertyDeclarationBlock {
// so we treat this as a normal-import... | 3 | 50 | 9 |
43268776b55959e22d32651f072b97ca40ba5153 | Matt Brubeck | 2016-12-31T05:56:00 | servo: Merge #14798 - Fix rowspan handling for rows that span to the end of the rowgroup (from mbrubeck:rowgroup); r=notriddle
This fixes `rowspan="0"` to behave as described in [the HTML spec](https://html.spec.whatwg.org/multipage/tables.html#attributes-common-to-td-and-th-elements):
> For this attribute, the value... | diff --git a/layout/table_row.rs b/layout/table_row.rs
index 45ac5fbdb..d4dddb1a4 100644
--- a/layout/table_row.rs
+++ b/layout/table_row.rs
@@ -752,6 +752,7 @@ pub fn propagate_column_inline_sizes_to_child(
// FIXME(pcwalton): This seems inefficient. Reference count it instead?
match child_flow.class() {
... | 1 | 6 | 1 |
893f259c27025ac19674df01cf3d174fad905a96 | Emilio Cobos Álvarez | 2016-12-31T03:12:55 | servo: Merge #14793 - stylo: Support at-import (from emilio:stylo-at-import); r=heycam,Manishearth
Reviewed upstream by @heycam and @Manishearth in:
https://bugzilla.mozilla.org/show_bug.cgi?id=1304792
Source-Repo: https://github.com/servo/servo
Source-Revision: 569e61e7ff6231ff62b8dc402c3e33b6072af6d8 | diff --git a/style/build_gecko.rs b/style/build_gecko.rs
index 708ed8c38..21f8b05db 100644
--- a/style/build_gecko.rs
+++ b/style/build_gecko.rs
@@ -251,6 +251,7 @@ mod bindings {
];
let whitelist = [
"RawGecko.*",
+ "mozilla::ServoStyleSheet",
"mozilla::ServoEleme... | 6 | 77 | 5 |
e126ac5d829eb4acd6cd329c552354ec25e8f529 | Raghav | 2016-12-30T18:33:40 | servo: Merge #14794 - Refactor HSTSList to use HashMap (from mrnayak:hsts-refactor); r=emilio
Refactored HSTSList to use HashMap, where the key of HashMap is the base domain. Every time when we check if a host is secure, we find the base domain of the host and get a vector of HSTS entries associated with the base doma... | diff --git a/net/hsts.rs b/net/hsts.rs
index 6b8665bd2..3807a4708 100644
--- a/net/hsts.rs
+++ b/net/hsts.rs
@@ -3,8 +3,10 @@
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
use net_traits::IncludeSubdomains;
+use net_traits::pub_domains::reg_suffix;
use rustc_serialize::json::decode;
use servo_con... | 1 | 45 | 29 |
8308d4bb8f7521971cb43fc28edbbc5f1bd4c219 | Emilio Cobos Álvarez | 2016-12-30T14:05:43 | servo: Merge #14739 - style: Cleanup and refactor how media types are represented (from servo:stylo-mq); r=Manishearth
This is necessary for the upcoming work in Stylo, given I plan to make MediaType
different for Servo and Gecko, and the Unknown variant doesn't fit in MediaType
to be fair, the device is never going t... | diff --git a/style/media_queries.rs b/style/media_queries.rs
index a450995c5..5762effb4 100644
--- a/style/media_queries.rs
+++ b/style/media_queries.rs
@@ -11,7 +11,8 @@ use app_units::Au;
use cssparser::{Delimiter, Parser, Token};
use euclid::size::{Size2D, TypedSize2D};
use serialize_comma_separated_list;
-use st... | 1 | 95 | 44 |
cf9b7fda05de736caefaf3cd083a66026652fcba | Ms2ger | 2016-12-30T11:04:12 | servo: Merge #14792 - Stop allowing unsafe code around thread_local (from servo:tl-unsafe); r=emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: 608511ddc3440bfa92b8cb001b5e9f10bc291150 | diff --git a/layout/context.rs b/layout/context.rs
index e2d1fa783..1cbee049f 100644
--- a/layout/context.rs
+++ b/layout/context.rs
@@ -4,9 +4,6 @@
//! Data needed by the layout thread.
-// for thread_local
-#![allow(unsafe_code)]
-
use fnv::FnvHasher;
use gfx::display_list::WebRenderImageInfo;
use gfx::font_c... | 2 | 0 | 6 |
0fc1df62a494503546fbcc211ac06a64833aa325 | Cameron McCormack | 2016-12-30T03:00:30 | servo: Merge #14776 - stylo: Don't persist styles on elements not in the document (from heycam:not-in-doc-persist); r=emilio
<!-- Please describe your changes on the following line: -->
This is the Servo half of https://bugzilla.mozilla.org/show_bug.cgi?id=1324983, which @emilio has already reviewed.
Source-Repo: ht... | diff --git a/script/layout_wrapper.rs b/script/layout_wrapper.rs
index e6c38aa1f..3e245ccdd 100644
--- a/script/layout_wrapper.rs
+++ b/script/layout_wrapper.rs
@@ -199,6 +199,10 @@ impl<'ln> TNode for ServoLayoutNode<'ln> {
self.node.parent_node_ref().map(|node| self.new_with_this_lifetime(&node))
... | 5 | 24 | 4 |
54ff7b4e619681491567624998a86b8625e213b6 | Xidorn Quan | 2016-12-29T12:49:16 | servo: Merge #14768 - Upgrade libbindgen to 0.1.5 (from upsuper:upgrade-bindgen); r=emilio
0.1.4 is known to be broken on Windows, and earlier version may not work properly in various platforms.
r? @emilio
Source-Repo: https://github.com/servo/servo
Source-Revision: ab623de2617c5a5414f4a0ac7cd66627214f82d5 | diff --git a/style/Cargo.toml b/style/Cargo.toml
index 3cc56f237..51a250b00 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -66,7 +66,7 @@ kernel32-sys = "0.2"
[build-dependencies]
lazy_static = "0.2"
-libbindgen = {version = "0.1.1", optional = true}
+libbindgen = {version = "0.1.5", optional = true}
phf_... | 1 | 1 | 1 |
1dbe7538487c9ce44f3b218a2f0fe5ebc665175d | Ms2ger | 2016-12-29T09:38:19 | servo: Merge #14647 - Support the 'current' global object (from servo:current-global); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: 885d152e92b20bdaeb0d0ad20affd269fc3b55d3 | diff --git a/script/dom/document.rs b/script/dom/document.rs
index 6f8f24353..79acb6909 100644
--- a/script/dom/document.rs
+++ b/script/dom/document.rs
@@ -1822,6 +1822,7 @@ impl Document {
pub fn new_inherited(window: &Window,
browsing_context: Option<&BrowsingContext>,
... | 10 | 51 | 23 |
d79f7ad36d95617d4784a4f800b7dcca2845ac52 | Raghav | 2016-12-29T08:35:09 | servo: Merge #14716 - Implement HSTS fetch step (from mrnayak:hsts); r=jdm
Implemented step nine of the main fetch. If current URL scheme is 'HTTP' and
current URL's host is domain and if current URL's host matched with Known
HSTS Host Domain Name Matching results in either a superdomain match with
an asserted include... | diff --git a/net/connector.rs b/net/connector.rs
index 3e4a8071f..8211e415f 100644
--- a/net/connector.rs
+++ b/net/connector.rs
@@ -27,11 +27,11 @@ const DEFAULT_CIPHERS: &'static str = concat!(
"AES128-SHA256:AES256-SHA256:AES128-SHA:AES256-SHA"
);
-pub fn create_http_connector() -> Arc<Pool<Connector>> {
+pu... | 4 | 15 | 7 |
c71ec3548a1f65eb31b6d31c7a1cc47312a7a2af | Xidorn Quan | 2016-12-29T05:19:26 | servo: Merge #14771 - Add support of text-combine-upright for stylo (from upsuper:text-combine-upright); r=Wafflespeanut
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with approp... | diff --git a/style/properties/longhand/inherited_text.mako.rs b/style/properties/longhand/inherited_text.mako.rs
index e6d474aca..21a769514 100644
--- a/style/properties/longhand/inherited_text.mako.rs
+++ b/style/properties/longhand/inherited_text.mako.rs
@@ -1058,3 +1058,11 @@ ${helpers.single_keyword("ruby-align", "... | 1 | 8 | 0 |
a5779e2df868c6d0b7f76857222f146e69393336 | Prudhvi Rampey | 2016-12-28T21:49:02 | servo: Merge #14762 - Error handled canvas closing (from prampey:error-handle); r=jdm
<!-- Please describe your changes on the following line: -->
Correctly handled error when Canvas doesn't close properly, with a descriptive warning.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` wh... | diff --git a/script/dom/canvasrenderingcontext2d.rs b/script/dom/canvasrenderingcontext2d.rs
index 32b65439f..80de3610e 100644
--- a/script/dom/canvasrenderingcontext2d.rs
+++ b/script/dom/canvasrenderingcontext2d.rs
@@ -1319,7 +1319,9 @@ impl CanvasRenderingContext2DMethods for CanvasRenderingContext2D {
impl Drop ... | 1 | 3 | 1 |
639cddf875b720cfddb67e85c9f28dd62c69c97a | Nick Price | 2016-12-28T18:46:53 | servo: Merge #14746 - Default is top-to-bottom if unset, not bottom-to-top (from DominoTree:fix-linear-gradient); r=emilio
<!-- Please describe your changes on the following line: -->
Reverse linear gradient direction if not explicitly specified to match expected default behavior
---
<!-- Thank you for contributing t... | diff --git a/style/values/computed/image.rs b/style/values/computed/image.rs
index 007cbdad9..5ddb28e1f 100644
--- a/style/values/computed/image.rs
+++ b/style/values/computed/image.rs
@@ -470,7 +470,7 @@ impl ToComputedValue for specified::AngleOrCorner {
fn to_computed_value(&self, _: &Context) -> AngleOrCorner ... | 1 | 1 | 1 |
40d06c2315d55e29449b6243a2878f84765cf0b8 | Sumant Manne | 2016-12-28T17:43:51 | servo: Merge #14718 - Rewrote websocket array buffer handling to typed array API (from dpyro:websocket-typed-arrays); r=jdm
<!-- Please describe your changes on the following line: -➜
Replaced existing code for handling `BinaryType::Arraybuffer` from `JS_NewArrayBuffer` to `Uint8Array::create`.
---
<!-- Thank you for... | diff --git a/script/dom/websocket.rs b/script/dom/websocket.rs
index b2057e7ef..8a25a4585 100644
--- a/script/dom/websocket.rs
+++ b/script/dom/websocket.rs
@@ -25,10 +25,9 @@ use dom::urlhelper::UrlHelper;
use hyper;
use hyper_serde::Serde;
use ipc_channel::ipc::{self, IpcReceiver, IpcSender};
-use js::jsapi::{JS_G... | 1 | 9 | 9 |
417e3cf8ac5e4ac73fcca15a4f9740b9fabf2ce2 | Xidorn Quan | 2016-12-28T12:51:53 | servo: Merge #14754 - Skip invoking bindgen if no header changes (from upsuper:skip-bindgen); r=emilio
This can avoid doing bindgen when build script is called for updating other files, e.g. properties.
This uses a global modified time, so there is a chance that some of the files which can be skipped but not skipped.... | diff --git a/style/build_gecko.rs b/style/build_gecko.rs
index 6ebfc8418..708ed8c38 100644
--- a/style/build_gecko.rs
+++ b/style/build_gecko.rs
@@ -4,10 +4,15 @@
mod common {
use std::env;
- use std::path::PathBuf;
+ use std::path::{Path, PathBuf};
+ use std::sync::Mutex;
+ use std::time::SystemTim... | 1 | 39 | 19 |
758589cf4d8f2771ed2d06f68fbf83cb9433575c | Hiroyuki Ikezoe | 2016-12-28T10:06:38 | servo: Merge #14747 - Interpolate colors with premultiplied alpha (from hiikezoe:color-interpolation2); r=emilio
We need to clamp each interpolated values because some cubic-bezier functions
produce values that are out of range [0, 1].
r? @emilio
<!-- Please describe your changes on the following line: -->
---
<!--... | diff --git a/style/properties/helpers/animated_properties.mako.rs b/style/properties/helpers/animated_properties.mako.rs
index 1e813ba78..642f25c7e 100644
--- a/style/properties/helpers/animated_properties.mako.rs
+++ b/style/properties/helpers/animated_properties.mako.rs
@@ -390,12 +390,23 @@ impl Interpolate for Back... | 1 | 17 | 6 |
ea86b73626aec166b2b02bc0207310fb6faad4f8 | Shing Lyu | 2016-12-28T08:33:31 | servo: Merge #14124 - Flexbox trace (from shinglyu:flexbox-trace); r=glennw
<!-- Please describe your changes on the following line: -->
This is a follow up for #13740, so r? @jdm
The first patch enables JSON serialization for flexbox flows, the second one fixed format incompatibilities for the layout viewer.
The 3r... | diff --git a/layout/flex.rs b/layout/flex.rs
index 7b8d69449..c40c6a1b4 100644
--- a/layout/flex.rs
+++ b/layout/flex.rs
@@ -35,7 +35,7 @@ use style::values::computed::{LengthOrPercentageOrAutoOrContent, LengthOrPercent
/// The size of an axis. May be a specified size, a min/max
/// constraint, or an unlimited size... | 4 | 9 | 7 |
a845ecd272784bbc9071f23fec249f63cf218a11 | Bobby Holley | 2016-12-28T03:55:01 | servo: Merge #14751 - style: Add a special, explicit path for lazy style resolution and use it for getComputedStyle (from heycam:transient); r=heycam
<!-- Please describe your changes on the following line: -->
This is the Servo-side part of @bholley's final patch of https://bugzilla.mozilla.org/show_bug.cgi?id=13246... | diff --git a/layout/query.rs b/layout/query.rs
index 0a44a9b1b..4b076942a 100644
--- a/layout/query.rs
+++ b/layout/query.rs
@@ -6,7 +6,7 @@
use app_units::Au;
use construct::ConstructionResult;
-use context::{ScopedThreadLocalLayoutContext, SharedLayoutContext};
+use context::SharedLayoutContext;
use euclid::poin... | 6 | 116 | 79 |
86b8a4ed3838b6f695ae2611d9f2e98f93ed28c5 | Matt McCoy | 2016-12-27T15:59:22 | servo: Merge #14741 - Reuse the http connector pool between fetches (from mattnenterprise:use-http-connection-pool); r=jdm
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appr... | diff --git a/net/http_loader.rs b/net/http_loader.rs
index 409148659..63e72db3f 100644
--- a/net/http_loader.rs
+++ b/net/http_loader.rs
@@ -72,6 +72,7 @@ pub struct HttpState {
pub cookie_jar: Arc<RwLock<CookieStorage>>,
pub auth_cache: Arc<RwLock<AuthCache>>,
pub blocked_content: Arc<Option<RuleList>>,... | 2 | 5 | 2 |
f57e7e1d9bfdfff56f9e308eab89ce15624683d0 | Roman Zaynetdinov | 2016-12-27T14:56:15 | servo: Merge #14727 - Use typed array in TextDecoder::Decode (from zaynetro:textdecoder-use-typedarray); r=jdm
<!-- Please describe your changes on the following line: -->
Use typed array API in TextDecoder::Decode
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is comp... | diff --git a/script/dom/textdecoder.rs b/script/dom/textdecoder.rs
index abb2f0c41..1c3ba6cf0 100644
--- a/script/dom/textdecoder.rs
+++ b/script/dom/textdecoder.rs
@@ -4,7 +4,6 @@
use dom::bindings::codegen::Bindings::TextDecoderBinding;
use dom::bindings::codegen::Bindings::TextDecoderBinding::TextDecoderMethods;... | 1 | 5 | 5 |
491a0f467f40317c5119b489f82c97b6bdb6abaa | deror1869107 | 2016-12-27T08:24:14 | servo: Merge #14744 - Move frame from constellation (from deror1869107:move_frame_from_constellation); r=Wafflespeanut
<!-- Please describe your changes on the following line: -->
Move frame from constellation
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete,... | diff --git a/constellation/constellation.rs b/constellation/constellation.rs
index 12a641c3c..ba14a9c82 100644
--- a/constellation/constellation.rs
+++ b/constellation/constellation.rs
@@ -75,6 +75,7 @@ use devtools_traits::{ChromeToDevtoolsControlMsg, DevtoolsControlMsg};
use euclid::scale_factor::ScaleFactor;
use e... | 3 | 194 | 182 |
1a9e311267615f7e1d303a048ba027b12344d31f | Nazım Can Altınova | 2016-12-27T05:48:52 | servo: Merge #14703 - Add gecko glue for perspective/transform properties (from canaltinova:perspective-transform); r=Wafflespeanut
<!-- Please describe your changes on the following line: -->
To be able to add glue for these properties, we needed to change their structs. They are moved from effects to box and added ... | diff --git a/layout/display_list_builder.rs b/layout/display_list_builder.rs
index be11ba66e..db632be4d 100644
--- a/layout/display_list_builder.rs
+++ b/layout/display_list_builder.rs
@@ -1567,9 +1567,9 @@ impl FragmentDisplayListBuilding for Fragment {
let overflow = base_flow.overflow.paint.translate(&-bord... | 8 | 282 | 226 |
8e91b6c59d327d92084b4716a610811a8b34a78e | deror1869107 | 2016-12-26T11:09:31 | servo: Merge #14736 - Move reg_host from the constellation to net_traits (from deror1869107:Move-reg_host-to-pub_domains); r=Ms2ger
<!-- Please describe your changes on the following line: -->
Move reg_host from the constellation to net_traits
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` b... | diff --git a/constellation/constellation.rs b/constellation/constellation.rs
index 8201b2338..12a641c3c 100644
--- a/constellation/constellation.rs
+++ b/constellation/constellation.rs
@@ -86,7 +86,7 @@ use msg::constellation_msg::{Key, KeyModifiers, KeyState};
use msg::constellation_msg::{PipelineNamespace, PipelineN... | 2 | 10 | 9 |
d81ff65c7b1fa71b5dea8e839208db77b5d83e2e | Ms2ger | 2016-12-26T09:43:39 | servo: Merge #14735 - Remove unused ConstellationMsg from net_traits (from servo:ConstellationMsg); r=KiChjang
Source-Repo: https://github.com/servo/servo
Source-Revision: ab788e72aa7d63452c4c5a759e8abc918d665c6a | diff --git a/net_traits/lib.rs b/net_traits/lib.rs
index 14bbe5b5d..eb8983f9d 100644
--- a/net_traits/lib.rs
+++ b/net_traits/lib.rs
@@ -42,7 +42,6 @@ use hyper::mime::{Attr, Mime};
use hyper_serde::Serde;
use ipc_channel::ipc::{self, IpcReceiver, IpcSender};
use ipc_channel::router::ROUTER;
-use msg::constellation_... | 1 | 0 | 7 |
28b3f9d50951e524d691bb1a5fa7dbc9235d0c55 | deror1869107 | 2016-12-26T07:37:15 | servo: Merge #14730 - Rewrite Crypto::GetRandomValues to use typed array API (from deror1869107:typed_array_API); r=emilio
<!-- Please describe your changes on the following line: -->
Rewrite Crypto::GetRandomValues to use typed array API
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]... | diff --git a/script/dom/crypto.rs b/script/dom/crypto.rs
index 4120456c7..57b561e8a 100644
--- a/script/dom/crypto.rs
+++ b/script/dom/crypto.rs
@@ -6,7 +6,6 @@ use core::nonzero::NonZero;
use dom::bindings::cell::DOMRefCell;
use dom::bindings::codegen::Bindings::CryptoBinding;
use dom::bindings::codegen::Bindings::... | 1 | 4 | 4 |
d89a57b03e4f3eacd0892f787d3436bd6de08d57 | Bobby Holley | 2016-12-26T02:13:30 | servo: Merge #14731 - stylo: Coordinate stylist flushing with gecko, and clean up pseudo-element resolution (from heycam:flushing_and_pseudos); r=heycam
Source-Repo: https://github.com/servo/servo
Source-Revision: 42ec8a89747ba1e25769fffae083f62fe9576987 | diff --git a/style/gecko_bindings/bindings.rs b/style/gecko_bindings/bindings.rs
index efc3b66b6..b9dc05014 100644
--- a/style/gecko_bindings/bindings.rs
+++ b/style/gecko_bindings/bindings.rs
@@ -991,16 +991,18 @@ extern "C" {
}
extern "C" {
pub fn Servo_StyleSet_AppendStyleSheet(set: RawServoStyleSetBorrowed,
... | 1 | 17 | 16 |
0c18816e80dd012090c722e44951a971a048c148 | Xidorn Quan | 2016-12-25T22:23:34 | servo: Merge #14640 - Store unset keyword as specified value (from upsuper:unset-storage); r=emilio
<!-- Please describe your changes on the following line: -->
`unset` keyword value should *not* be converted to something else during parsing. It is a specified-value time value, which should be preserved until computat... | diff --git a/style/custom_properties.rs b/style/custom_properties.rs
index f9d3c77b1..d8e8913c4 100644
--- a/style/custom_properties.rs
+++ b/style/custom_properties.rs
@@ -345,6 +345,7 @@ pub fn cascade<'a>(custom_properties: &mut Option<HashMap<&'a Name, BorrowedSpec
DeclaredValue::Initial => {
... | 5 | 35 | 17 |
3b2020098471a4434b7a167af6f36ec100f894c4 | Emilio Cobos Álvarez | 2016-12-25T19:04:21 | servo: Merge #14728 - Bunch of nitpicks (from emilio:nit); r=Wafflespeanut
I just noticed one while writing #14719, and then grepped and couldn't stop.
r? @nox
Source-Repo: https://github.com/servo/servo
Source-Revision: 7fc9047d22147cf419d2551350421e23105e6f0e | diff --git a/gfx/platform/macos/font_template.rs b/gfx/platform/macos/font_template.rs
index a98f60a95..cba1738b9 100644
--- a/gfx/platform/macos/font_template.rs
+++ b/gfx/platform/macos/font_template.rs
@@ -81,9 +81,8 @@ impl FontTemplateData {
/// operation (depending on the platform) which performs synchronous... | 10 | 51 | 88 |
4713dafa86f86bdf76a5d0150a341c9807231a6a | Roman Zaynetdinov | 2016-12-25T17:56:32 | servo: Merge #14726 - Remove azure(canvas) dependency from canvas_traits (from zaynetro:no-azure-in-canvas_traits); r=SimonSapin
<!-- Please describe your changes on the following line: -->
Remove azure (canvas crate) dependency from canvas_traits crate.
There might be some tests that are failing due to changed impl... | diff --git a/canvas/Cargo.toml b/canvas/Cargo.toml
index 682e19415..4416e1cb0 100644
--- a/canvas/Cargo.toml
+++ b/canvas/Cargo.toml
@@ -12,6 +12,7 @@ path = "lib.rs"
[dependencies]
azure = {git = "https://github.com/servo/rust-azure", features = ["plugins"]}
canvas_traits = {path = "../canvas_traits"}
+cssparser = ... | 5 | 162 | 144 |
02b72f0da9687440adce49fa45cbdd26816c881b | Roman Zaynetdinov | 2016-12-25T11:23:16 | servo: Merge #14724 - Remove FrameChange::document_ready (from zaynetro:remove-frame-change-document-ready); r=Ms2ger
<!-- Please describe your changes on the following line: -->
Remove unused `FrameChange::document_ready` field and remove unused boolean in `ConstellationMsg::GetPipeline`'s second argument.
---
<!--... | diff --git a/constellation/constellation.rs b/constellation/constellation.rs
index fa500a40b..8201b2338 100644
--- a/constellation/constellation.rs
+++ b/constellation/constellation.rs
@@ -412,10 +412,6 @@ struct FrameChange {
/// The pipeline for the document being loaded.
new_pipeline_id: PipelineId,
- ... | 3 | 5 | 14 |
a8d2e44a851edbe1903c8ac06458dfa521d95591 | Rohit Burra | 2016-12-25T08:48:09 | servo: Merge #14722 - Check for wss schemes in Cookie::appropriate_for_url (from iamrohit7:check-secure-schemes); r=jdm
* Also adds a new helper, `ServoUrl::is_secure_scheme`.
* Refactored `CookieStorage::push` and `CookieStorage::remove` to use the new helper.
<!-- Thank you for contributing to Servo! Please replace ... | diff --git a/net/cookie.rs b/net/cookie.rs
index b47246440..42a49a4ac 100644
--- a/net/cookie.rs
+++ b/net/cookie.rs
@@ -160,7 +160,7 @@ impl Cookie {
}
}
- if self.cookie.secure && url.scheme() != "https" {
+ if self.cookie.secure && !url.is_secure_scheme() {
return f... | 3 | 8 | 3 |
f63ce1e96a31fd9d9b239ebf0fb628782d586594 | Anthony Ramine | 2016-12-25T07:26:00 | servo: Merge #14710 - Mark DOM interfaces as repr(C) (from nox:repr-c); r=KiChjang
Source-Repo: https://github.com/servo/servo
Source-Revision: b5909f26cf4ca255d13bf31b3261e6c9df11a4a1 | diff --git a/plugins/jstraceable.rs b/plugins/jstraceable.rs
index f1e0ed496..233f90b3b 100644
--- a/plugins/jstraceable.rs
+++ b/plugins/jstraceable.rs
@@ -12,6 +12,7 @@ pub fn expand_dom_struct(cx: &mut ExtCtxt, sp: Span, _: &MetaItem, anno: Annotat
let mut item2 = (*item).clone();
item2.attrs.push(... | 1 | 1 | 0 |
7c09a571accf2987fbfc1c4be80237264973e84d | Alan Jeffrey | 2016-12-24T16:48:43 | servo: Merge #14707 - Pipeline documentation comments (from asajeffrey:constellation-pipeline-docs); r=ConnorGBrewster
<!-- Please describe your changes on the following line: -->
Rewrote the documentation comments for `pipeline.rs`.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` wh... | diff --git a/constellation/pipeline.rs b/constellation/pipeline.rs
index f5b7886cb..10aed3624 100644
--- a/constellation/pipeline.rs
+++ b/constellation/pipeline.rs
@@ -37,28 +37,56 @@ use std::sync::mpsc::Sender;
use style_traits::{PagePx, ViewportPx};
use webrender_traits;
-/// A uniquely-identifiable pipeline of... | 1 | 89 | 16 |
380b83d0dd568f244de00fd7cb9771a059d905f8 | Michael Howell | 2016-12-24T14:42:57 | servo: Merge #14699 - Fix an outdated comment (from notriddle:constructive_commentary); r=emilio
The structures have changed, as has the syntax of the Rust language.
Source-Repo: https://github.com/servo/servo
Source-Revision: f850918d8ef07426b55e8a7cdebbf43c56c65589 | diff --git a/layout/construct.rs b/layout/construct.rs
index 394b5d91f..660d4f648 100644
--- a/layout/construct.rs
+++ b/layout/construct.rs
@@ -141,17 +141,22 @@ pub struct InlineFragmentsConstructionResult {
/// The resulting `ConstructionItem` for the outer `span` will be:
///
/// ```ignore
-/// ConstructionI... | 1 | 15 | 10 |
543d03a13bca96c16e5a55af087e82d5dd49843d | Alan Jeffrey | 2016-12-24T13:46:40 | servo: Merge #14698 - Constellation documentation comments (from asajeffrey:constellation-docs); r=ConnorGBrewster
<!-- Please describe your changes on the following line: -->
Rewrote the documentation comments for `constellation.rs`.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` w... | diff --git a/constellation/constellation.rs b/constellation/constellation.rs
index 4b180073d..fa500a40b 100644
--- a/constellation/constellation.rs
+++ b/constellation/constellation.rs
@@ -4,10 +4,63 @@
//! The `Constellation`, Servo's Grand Central Station
//!
-//! The primary duty of a `Constellation` is to media... | 1 | 287 | 88 |
874bb6f512d34ed467a24b6ba54d30c44f7d469d | Nick Price | 2016-12-24T11:41:14 | servo: Merge #14623 - #14514 Implement port-based blocking (from DominoTree:master); r=emilio
<!-- Please describe your changes on the following line: -->
Add check for bad ports to http_fetch(), return NetworkError::Internal if bad port/schema combination is seen.
Test added
---
<!-- Thank you for contributing to S... | diff --git a/net/fetch/methods.rs b/net/fetch/methods.rs
index 9eedd748c..de41bfa20 100644
--- a/net/fetch/methods.rs
+++ b/net/fetch/methods.rs
@@ -143,6 +143,18 @@ pub fn main_fetch(request: Rc<Request>,
// Step 5
// TODO this step (CSP port/content blocking)
+ if let Some(port) = request.url().port() ... | 1 | 12 | 0 |
717e85231e1f0f7c6bd56d3df358692ffaa4ebbb | Glenn Watson | 2016-12-24T09:55:17 | servo: Merge #14668 - Update WR (windows font fixes, ridge/groove borders, scrolling improvements) (from glennw:update-wr-dwrote); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: e80965f17362f5428d0b77ab1511e087611281fe | diff --git a/servo/lib.rs b/servo/lib.rs
index c9cc02b7c..afb7f88b7 100644
--- a/servo/lib.rs
+++ b/servo/lib.rs
@@ -164,7 +164,6 @@ impl<Window> Browser<Window> where Window: WindowMethods + 'static {
device_pixel_ratio: device_pixel_ratio,
resource_override_path: Some(resource_path),... | 1 | 0 | 1 |
cfefa47f17b13cdafb9f3a991814b0ce06471707 | Keith Yeung | 2016-12-23T23:26:46 | servo: Merge #14491 - Add domain and path checks for secure cookies eviction (from KiChjang:cookie-checks); r=jdm
Fixes #14477.
Source-Repo: https://github.com/servo/servo
Source-Revision: b13afccb8a4e922f66c77a92914e6505c62ae483 | diff --git a/net/cookie.rs b/net/cookie.rs
index 768017ec6..b47246440 100644
--- a/net/cookie.rs
+++ b/net/cookie.rs
@@ -75,7 +75,7 @@ impl Cookie {
// Step 10
- if cookie.httponly && source != CookieSource::HTTP {
+ if cookie.httponly && source == CookieSource::NonHTTP {
return ... | 4 | 44 | 22 |
71c3d79fe9d35ecdb433f9fd01d1b2d4a1194814 | Manish Goregaokar | 2016-12-23T07:26:57 | servo: Merge #14684 - Regen bindings (from Manishearth:regen); r=bholley
Source-Repo: https://github.com/servo/servo
Source-Revision: dd2aa4195ab1ac853a5b80c6aa0a0d9c1fae055c | diff --git a/style/build_gecko.rs b/style/build_gecko.rs
index 4c903fb1e..7f9fe4251 100644
--- a/style/build_gecko.rs
+++ b/style/build_gecko.rs
@@ -338,7 +338,7 @@ mod bindings {
"mozilla::DefaultDelete",
];
let opaque_types = [
- "atomic___base", "std::atomic__My_base",
+ ... | 3 | 253 | 167 |
681c7dc4d511ad3700c91b0ca88f1c19b448897c | Josh Matthews | 2016-12-23T02:19:48 | servo: Merge #14679 - Warn when a timer event is processed for a discarded document (from jdm:nowarntimer); r=asajeffrey
Turn a panic into a warning for a situation that is easy to hit in web content.
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These ch... | diff --git a/script/script_thread.rs b/script/script_thread.rs
index c2d8deec6..538ce0b5f 100644
--- a/script/script_thread.rs
+++ b/script/script_thread.rs
@@ -1049,8 +1049,11 @@ impl ScriptThread {
TimerSource::FromWorker => panic!("Worker timeouts must not be sent to script thread"),
};
- ... | 1 | 5 | 2 |
97e0bf8b20cfd030e4a1a33c81b0ae69bb19c94b | Ms2ger | 2016-12-23T00:40:53 | servo: Merge #14632 - Use the API base URL in Fetch APIs (from servo:multi-global-fetch); r=jdm
Source-Repo: https://github.com/servo/servo
Source-Revision: 89cdcbc420d82aade20a2ee704fdea295dec437a | diff --git a/script/dom/request.rs b/script/dom/request.rs
index 74b61768a..8ca9104b9 100644
--- a/script/dom/request.rs
+++ b/script/dom/request.rs
@@ -92,8 +92,7 @@ impl Request {
let mut fallback_credentials: Option<NetTraitsRequestCredentials> = None;
// Step 4
- // TODO: `entry settings ... | 2 | 2 | 4 |
f882fe4db8bf320afb51b62e9d57b14b17e07074 | Simon Sapin | 2016-12-22T20:53:33 | servo: Merge #14671 - Remove the unused dependency of style to plugins (from servo:style-no-plugins); r=mbrubeck
<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate da... | diff --git a/style/Cargo.toml b/style/Cargo.toml
index 32f359fa4..3cc56f237 100644
--- a/style/Cargo.toml
+++ b/style/Cargo.toml
@@ -18,7 +18,7 @@ bindgen = ["libbindgen", "regex"]
servo = ["serde/unstable", "serde", "serde_derive", "heapsize_derive",
"style_traits/servo", "app_units/plugins", "servo_atoms",... | 2 | 1 | 4 |
3d34483b63158086229c84a578b9e7c88ee4fde7 | Bobby Holley | 2016-12-22T20:02:38 | servo: Merge #14662 - Hoist bloom filter into scoped TLS, and remove a bunch of complexity and unsafety from the style system (from bholley:bloom_tls); r=emilio
With this PR, the only remaining usage of UnsafeNode is the transition stuff, which is servo-only and probably going to be rewritten over the course of stylo.... | diff --git a/layout/traversal.rs b/layout/traversal.rs
index be4525cd1..b3672ecf3 100644
--- a/layout/traversal.rs
+++ b/layout/traversal.rs
@@ -9,7 +9,6 @@ use context::{LayoutContext, ScopedThreadLocalLayoutContext, SharedLayoutContext
use display_list_builder::DisplayListBuildState;
use flow::{self, PreorderFlowTr... | 12 | 121 | 229 |
2cc63deab1d2f209843a0de30f2b45f630bd202a | Emilio Cobos Álvarez | 2016-12-22T13:23:00 | servo: Merge #14669 - script: Remove unused function (from emilio:dirty-descendants-unused); r=Wafflespeanut
This is no longer used since one of @bholley's patches to the style system.
Source-Repo: https://github.com/servo/servo
Source-Revision: b843be49752c68926521a8b5f6b0405b1ff01e9b | diff --git a/script/dom/node.rs b/script/dom/node.rs
index 3e2de9bfa..6a2ccea83 100644
--- a/script/dom/node.rs
+++ b/script/dom/node.rs
@@ -426,10 +426,6 @@ impl Node {
self.get_flag(HAS_DIRTY_DESCENDANTS)
}
- pub fn set_has_dirty_descendants(&self, state: bool) {
- self.set_flag(HAS_DIRTY_DE... | 1 | 0 | 4 |
8edebc36f89eaf90e633d52a40a7a26766d188ff | Cameron McCormack | 2016-12-22T02:16:45 | servo: Merge #14667 - stylo: update bindings (from heycam:bindings-update-12); r=bholley
<!-- Please describe your changes on the following line: -->
Update bindings for https://treeherder.mozilla.org/#/jobs?repo=stylo&revision=3cefc3d84bae6c9ae9d591bb26d98a8f6fc51d47.
r? @bholley
Source-Repo: https://github.com/se... | diff --git a/style/gecko_bindings/bindings.rs b/style/gecko_bindings/bindings.rs
index bac6ff5f5..efc3b66b6 100644
--- a/style/gecko_bindings/bindings.rs
+++ b/style/gecko_bindings/bindings.rs
@@ -1010,6 +1010,10 @@ extern "C" {
reference:
... | 4 | 150 | 124 |
84a3bb5a574a2d6491b2dae36b90465fbda5de91 | Ms2ger | 2016-12-22T00:24:27 | servo: Merge #14633 - Update Rust to 1.15.0-nightly (71c06a56a 2016-12-18) (from servo:rustup); r=SimonSapin,nox
Source-Repo: https://github.com/servo/servo
Source-Revision: df667f16b07e78fef50767c0d6912a8c2318225d | diff --git a/gfx/Cargo.toml b/gfx/Cargo.toml
index 81bcb8126..79b6f8691 100644
--- a/gfx/Cargo.toml
+++ b/gfx/Cargo.toml
@@ -54,7 +54,7 @@ core-graphics = "0.4"
core-text = "2.0"
[target.'cfg(any(target_os = "linux", target_os = "android"))'.dependencies]
-freetype = {git = "https://github.com/servo/rust-freetype"}... | 6 | 22 | 17 |
e09e92633468ba0eaf4a2b60cf01d46cd19e1803 | Camille TJHOA | 2016-12-21T23:29:27 | servo: Merge #14663 - Stylo: implement -moz-orient (from ctjhoa:moz-orient); r=Manishearth
<!-- Please describe your changes on the following line: -->
https://developer.mozilla.org/en-US/docs/Web/CSS/-moz-orient
![2016-12-21-213132_1342x870_scrot](https://cloud.githubusercontent.com/assets/1716173/21405334/c6c49cb2-c... | diff --git a/style/properties/longhand/box.mako.rs b/style/properties/longhand/box.mako.rs
index dd51bb5b3..a47b7d590 100644
--- a/style/properties/longhand/box.mako.rs
+++ b/style/properties/longhand/box.mako.rs
@@ -1559,3 +1559,11 @@ ${helpers.predefined_type("-moz-binding", "UrlOrNone", "Either::Second(None_)",
... | 1 | 8 | 0 |
2713499706a049d9909531206248b820281dcad3 | Ms2ger | 2016-12-21T14:47:33 | servo: Merge #14658 - Separate the async bluetooth handling from networking code (from servo:bluetooth-net); r=jdm
They're not at all related, besides both being asynchronous. This change adds
a little extra code in response_async(), but makes this code more readable
and reduces the unnecessary indirection.
This chan... | diff --git a/bluetooth_traits/lib.rs b/bluetooth_traits/lib.rs
index ede1c8ecd..f7293b74b 100644
--- a/bluetooth_traits/lib.rs
+++ b/bluetooth_traits/lib.rs
@@ -108,7 +108,3 @@ pub enum BluetoothResponse {
EnableNotification(()),
WatchAdvertisements(()),
}
-
-pub trait BluetoothResponseListener {
- fn res... | 5 | 25 | 33 |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.