commit_hash
stringlengths
40
40
author
stringlengths
1
57
date
timestamp[s]date
2010-07-26 04:45:09
2026-04-14 18:21:10
message
stringlengths
8
1.39M
diff
stringlengths
68
51.2k
files_changed
int64
1
136
insertions
int64
0
2.35k
deletions
int64
0
1.9k
0a049a4597932e17eb35cc112d27e0461cbbab83
Matt Brubeck
2014-09-16T16:03:04
servo: Merge #3339 - Implement percentage heights for block flows. r=SimonSapin (from mbrubeck:percent-height) Source-Repo: https://github.com/servo/servo Source-Revision: 66a7de750c303b482572db2d71cf1f90a1c01828
diff --git a/layout/block.rs b/layout/block.rs index 26564e9f8..d3211d89c 100644 --- a/layout/block.rs +++ b/layout/block.rs @@ -513,6 +513,10 @@ pub struct BlockFlow { /// block formatting contexts. previous_float_inline_size: Option<Au>, + /// The block-size of the block container of this block, if it ...
1
24
4
a22351e408d50c92c5b379751be3d5e397aceeb1
Matt Brubeck
2014-09-16T15:16:29
servo: Merge #3352 - Move link rel=stylesheet fetching to layout task. r=jdm (from mbrubeck:link-style) Source-Repo: https://github.com/servo/servo Source-Revision: 0e2cdc5cca80e636bd904ea99e86f31a4ea9bcd2
diff --git a/compositing/pipeline.rs b/compositing/pipeline.rs index 8ccc0fe48..8dd8c1f0d 100644 --- a/compositing/pipeline.rs +++ b/compositing/pipeline.rs @@ -80,7 +80,7 @@ impl Pipeline { script_port, constellation_chan.clone(), ...
13
131
196
5a1b87c84b50bb8e69726a3c014db21bda5aab65
Glenn Watson
2014-09-16T14:16:35
servo: Merge #3357 - Handle src='' in an iframe element. Without this, infinitely creates iframes with the same url (from glennw:empty-iframe-src) Source-Repo: https://github.com/servo/servo Source-Revision: dd35ea223e90bbdda620a12963a24a968d9fbc62
diff --git a/script/dom/htmliframeelement.rs b/script/dom/htmliframeelement.rs index 7ca33cf86..c81914321 100644 --- a/script/dom/htmliframeelement.rs +++ b/script/dom/htmliframeelement.rs @@ -75,9 +75,14 @@ impl<'a> HTMLIFrameElementHelpers for JSRef<'a, HTMLIFrameElement> { fn get_url(&self) -> Option<Url> { ...
1
8
3
75edb98a8ed0106daadfcefd081cb56732a15645
Glenn Watson
2014-09-16T07:57:36
servo: Merge #3362 - Fix font flickering due to missed check in font cache (from glennw:fix-layout-fonts) Source-Repo: https://github.com/servo/servo Source-Revision: 7a5f15f13723a6c510ed05ad7875eb10b290dea2
diff --git a/gfx/font_context.rs b/gfx/font_context.rs index 04d7a17ef..9a97e0178 100644 --- a/gfx/font_context.rs +++ b/gfx/font_context.rs @@ -38,6 +38,11 @@ fn create_scaled_font(backend: BackendType, template: &Arc<FontTemplateData>, pt ScaledFont::new(backend, &cgfont, pt_size as AzFloat) } +struct LayoutF...
1
19
8
4fa9f8cabe56e3f18f0b0e5fc82a8531141d6a57
Josh Matthews
2014-09-16T01:37:29
servo: Merge #3347 - Make all iframes attached to a document default to about:blank (from jdm:blankiframe) Source-Repo: https://github.com/servo/servo Source-Revision: 8a02fe0fc6df5f5812a3de80d417fd6e68502ce3
diff --git a/script/dom/htmliframeelement.rs b/script/dom/htmliframeelement.rs index 6422e5a8f..7ca33cf86 100644 --- a/script/dom/htmliframeelement.rs +++ b/script/dom/htmliframeelement.rs @@ -82,29 +82,29 @@ impl<'a> HTMLIFrameElementHelpers for JSRef<'a, HTMLIFrameElement> { } fn process_the_iframe_attrib...
1
23
23
58a41c2d6ef8566662c5a834d79be2ffc4910739
Jack Moffitt
2014-09-15T23:03:54
servo: Merge #3299 - Handle iframe.src with a javascript: URL (from servo:iframe-javascript-urls) Source-Repo: https://github.com/servo/servo Source-Revision: d161d0ad47dbfbd5ff6e28d19008e0719f078eff
diff --git a/script/dom/window.rs b/script/dom/window.rs index 23b6c71e0..ce60f3cdb 100644 --- a/script/dom/window.rs +++ b/script/dom/window.rs @@ -29,14 +29,15 @@ use servo_net::image_cache_task::ImageCacheTask; use servo_util::str::{DOMString,HTML_SPACE_CHARACTERS}; use servo_util::task::{spawn_named}; -use js::...
3
148
56
2040dcc28a069b5383ca3e064ccfea404435bc99
Glenn Watson
2014-09-15T16:29:39
servo: Merge #3341 - Implement generated_containing_block_rect for TableFlow. Fixes #3337 (from glennw:table-cb) Source-Repo: https://github.com/servo/servo Source-Revision: 13ae369dec3f02b5f992f1c6c276cde646ef39e9
diff --git a/layout/table.rs b/layout/table.rs index 98569d68c..1708ceca2 100644 --- a/layout/table.rs +++ b/layout/table.rs @@ -18,6 +18,7 @@ use wrapper::ThreadSafeLayoutNode; use servo_util::geometry::Au; use servo_util::geometry; +use servo_util::logical_geometry::LogicalRect; use std::fmt; use style::compute...
1
5
0
44453ad00b22141163ab9747464f35bac5c8e487
Glenn Watson
2014-09-15T04:54:03
servo: Merge #3336 - Handle AttachLayout before ResizeMsg. Fixes #3333 for yahoo static suite (from glennw:resize-fail) Source-Repo: https://github.com/servo/servo Source-Revision: 00150b8c712ee2eaac7bc383f3b7e996ac3449fc
diff --git a/script/script_task.rs b/script/script_task.rs index e743b9a09..88e2f4241 100644 --- a/script/script_task.rs +++ b/script/script_task.rs @@ -419,6 +419,12 @@ impl ScriptTask { loop { match event { + // This has to be handled before the ResizeMsg below, + ...
1
7
2
b58403953dc321cba3ebb6c3155dc40c6d39f2cc
Josh Matthews
2014-09-15T00:45:24
servo: Merge #3331 - Propagate absolute descendants of inline block flows. Fixes #3326 (from jdm:ib-abs) Source-Repo: https://github.com/servo/servo Source-Revision: 2f12d5628f6a2a6b101c156baf66777b7ca5a4bb
diff --git a/layout/construct.rs b/layout/construct.rs index c88de5e8b..a1631a585 100644 --- a/layout/construct.rs +++ b/layout/construct.rs @@ -604,8 +604,8 @@ impl<'a, 'b> FlowConstructor<'a, 'b> { fn build_fragment_for_inline_block(&mut self, node: &ThreadSafeLayoutNode) -> ConstructionResult { let b...
1
3
3
34a7236a34f12f11a7c0684a6cc87c0572a194c2
Josh Matthews
2014-09-14T15:02:33
servo: Fix broken build after denying unused imports. Source-Repo: https://github.com/servo/servo Source-Revision: 0b0c2ef461094b5d43a97af5d39c78f22527f8a6
diff --git a/net/data_loader.rs b/net/data_loader.rs index 39b0cf628..4d52b8de3 100644 --- a/net/data_loader.rs +++ b/net/data_loader.rs @@ -2,8 +2,6 @@ * License, v. 2.0. If a copy of the MPL was not distributed with this * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ -use std::str; - use resourc...
1
0
2
7776ed8a48f707863ee6d6f1cf24c28a8ebf9410
Jack Moffitt
2014-09-14T13:56:58
servo: Merge #3327 - Reinstate errors for unused variables and imports (from metajack:cargo-profiles) Source-Repo: https://github.com/servo/servo Source-Revision: 6c179127a311d2c1dcd4441098a176faafe51f52
diff --git a/canvas/lib.rs b/canvas/lib.rs index 0dc2fb7e3..21f49dd7c 100644 --- a/canvas/lib.rs +++ b/canvas/lib.rs @@ -2,6 +2,8 @@ * License, v. 2.0. If a copy of the MPL was not distributed with this * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ +#![deny(unused_imports, unused_variable)] + ext...
15
28
8
3ef73b5a65716f2f030200d7a79cf1af82a8e8e7
Ms2ger
2014-09-14T13:53:57
servo: Merge #3328 - Remove obsolete FIXME comment (from Ms2ger:fixme-customevent) Source-Repo: https://github.com/servo/servo Source-Revision: 22df9943c191fd1fef257d4578c62f48d6ad992f
diff --git a/script/dom/document.rs b/script/dom/document.rs index f8f83183d..8f8f8e5c6 100644 --- a/script/dom/document.rs +++ b/script/dom/document.rs @@ -569,7 +569,6 @@ impl<'a> DocumentMethods for JSRef<'a, Document> { let window = self.window.root(); match interface.as_slice().to_ascii_lower()...
1
0
1
992e8336484dc23599067354ebd50b8bb0ea7b4a
Ms2ger
2014-09-14T13:50:34
servo: Merge #3329 - Call from_base64 on a vector slice rather than a string slice (fixes #2877) (from Ms2ger:2877-base64) Source-Repo: https://github.com/servo/servo Source-Revision: 23ec53042c8ad935180e9246b6f9d97006c3e2e8
diff --git a/net/data_loader.rs b/net/data_loader.rs index 43d59fcf3..39b0cf628 100644 --- a/net/data_loader.rs +++ b/net/data_loader.rs @@ -66,10 +66,7 @@ fn load(load_data: LoadData, start_chan: Sender<LoadResponse>) { // FIXME(#2909): It’s unclear what to do with non-alphabet characters, // but Aci...
1
1
4
0880dbba4f6b973ba54c1e9db4dd7da279f4eebf
Josh Matthews
2014-09-13T19:06:13
servo: Merge #3325 - Don't fail converting invalid UTF8 when fetching JS source. Fixes #3302 (from jdm:jsdecode) Source-Repo: https://github.com/servo/servo Source-Revision: 97e068b1c27b2b2aa48e38550e6adbdc42bba8c3
diff --git a/net/about_loader.rs b/net/about_loader.rs index af855d260..3c74a8dd8 100644 --- a/net/about_loader.rs +++ b/net/about_loader.rs @@ -28,7 +28,11 @@ pub fn factory(mut load_data: LoadData, start_chan: Sender<LoadResponse>) { // FIXME: Find a way to load this without relying on the `../src` direc...
2
10
2
7a64ba48c4a12089b0f1cebf282f0b4de1a0f439
Ms2ger
2014-09-13T19:02:40
servo: Merge #3323 - Stop messing with the case of the attribute name in AttributeHandlers::get_attribute; r=Manishearth (from Ms2ger:get_attribute) Source-Repo: https://github.com/servo/servo Source-Revision: f466d3144615bf28d4e609fdceba22cba74ae4ff
diff --git a/script/dom/element.rs b/script/dom/element.rs index 30b2601f0..2150e67f0 100644 --- a/script/dom/element.rs +++ b/script/dom/element.rs @@ -252,7 +252,10 @@ impl<'a> ElementHelpers for JSRef<'a, Element> { } pub trait AttributeHandlers { - fn get_attribute(&self, namespace: Namespace, name: &str) ->...
1
9
8
a256d86a0c0c6fa13f7a35d9db72c42b37e20cf3
Patrick Walton
2014-09-13T09:22:54
servo: Merge #3317 - build: Update submodules (from pcwalton:update-submodules) Source-Repo: https://github.com/servo/servo Source-Revision: 5a90f18b7ee9a73511920acfb1e8b04c8c36372e
diff --git a/util/Cargo.toml b/util/Cargo.toml index be6662b76..6f4824fd6 100644 --- a/util/Cargo.toml +++ b/util/Cargo.toml @@ -18,3 +18,4 @@ path = "../../support/rust-task_info" [dependencies.string_cache] git = "https://github.com/servo/string-cache" +
1
1
0
c7bf0de20bb6a97f12e18928378ca17c1853e043
Glenn Watson
2014-09-13T08:55:56
servo: Merge #3305 - Add support for tables that are floated (from glennw:float-table) Source-Repo: https://github.com/servo/servo Source-Revision: fb54c1eb08839f43a15df30cf241c21b03c4beeb
diff --git a/layout/construct.rs b/layout/construct.rs index d48612375..466a25423 100644 --- a/layout/construct.rs +++ b/layout/construct.rs @@ -684,7 +684,8 @@ impl<'a, 'b> FlowConstructor<'a, 'b> { /// Builds a flow for a node with `display: table`. This yields a `TableWrapperFlow` with possibly /// other...
1
18
4
5869e6436523bb4f24eb1d11db3ff4f6b2e4d511
Glenn Watson
2014-09-13T04:11:27
servo: Merge #3286 - Implement basic support for display: inline-block (from glennw:inline_block) Source-Repo: https://github.com/servo/servo Source-Revision: b64f27b2b69996508eed0a76acc7414a791b1a9e
diff --git a/layout/block.rs b/layout/block.rs index ba17b4179..4a5395b75 100644 --- a/layout/block.rs +++ b/layout/block.rs @@ -20,7 +20,7 @@ use floats::{ClearBoth, ClearLeft, ClearRight, FloatKind, Floats, PlacementInfo} use flow::{BaseFlow, BlockFlowClass, FlowClass, Flow, ImmutableFlowUtils}; use flow::{MutableF...
4
146
36
05c227231c06ecb809c43b793fac4a43c2fabfee
Patrick Walton
2014-09-12T21:10:44
servo: Merge #3293 - layout: Don't crash on floated generated content (from pcwalton:floated-generated-content-crash) Source-Repo: https://github.com/servo/servo Source-Revision: 20cde10e124df5c9aa9bd475bfb2b05493c114f6
diff --git a/layout/construct.rs b/layout/construct.rs index 0f832bacf..e30838acb 100644 --- a/layout/construct.rs +++ b/layout/construct.rs @@ -833,7 +833,9 @@ impl<'a, 'b> PostorderNodeMutTraversal for FlowConstructor<'a, 'b> { } // Inline items contribute inline fragment construction resu...
1
3
1
81b8e3d5e2183fdadfc93d3613956827f9dfe266
Glenn Watson
2014-09-12T19:51:00
servo: Merge #3298 - Reduce number of font instances and shaper structures created (from glennw:fix-font-cache) Source-Repo: https://github.com/servo/servo Source-Revision: 883fc2e404855440c0165be1b8c28ca692f01830
diff --git a/gfx/font_context.rs b/gfx/font_context.rs index 0a1ef69e0..04d7a17ef 100644 --- a/gfx/font_context.rs +++ b/gfx/font_context.rs @@ -14,7 +14,7 @@ use font::FontHandleMethods; use platform::font::FontHandle; use servo_util::cache::HashCache; -use std::rc::{Rc, Weak}; +use std::rc::Rc; use std::cell::Re...
1
9
11
324069d80d669efb97fafdbd1979103cdb9cd7d5
Bryan Bell
2014-09-12T18:34:58
servo: Merge #3197 - Better handling of iframes in the compositor tree (from mrobinson:iframes) Source-Repo: https://github.com/servo/servo Source-Revision: 443bcc4d30940113b9507aeafd19ff16a937b4c9
diff --git a/compositing/compositor.rs b/compositing/compositor.rs index 087e9b477..ea8bf4472 100644 --- a/compositing/compositor.rs +++ b/compositing/compositor.rs @@ -5,7 +5,7 @@ use compositor_data::{CompositorData, DoesntWantScrollEvents, WantsScrollEvents}; use compositor_task::{Msg, CompositorTask, Exit, Change...
8
174
105
89913f80c1d23132b9ee408b1e9d69c705444c61
Glenn Watson
2014-09-12T14:12:51
servo: Merge #3304 - Print debug message instead of fail when unable to load web font. Fixes #3301 (from glennw:allow-font-failure) Source-Repo: https://github.com/servo/servo Source-Revision: a2ab6f97991aa877a19ed24976694d451ac450cf
diff --git a/gfx/font_cache_task.rs b/gfx/font_cache_task.rs index 7d3541488..8307be837 100644 --- a/gfx/font_cache_task.rs +++ b/gfx/font_cache_task.rs @@ -128,7 +128,7 @@ impl FontCache { family.add_template(format!("{}", url).as_slice(), Some(bytes)); }, ...
1
1
1
06465fea0eca89c9461aef3ec7cbdf9a140da4de
Gilles Leblanc
2014-09-12T12:50:07
servo: Merge #3213 - Make use of the list of Atoms in the class attribute in selector matchin (from gilles-leblanc:issue-3111) Source-Repo: https://github.com/servo/servo Source-Revision: 97cabf204e2793fa54bcf58375af4ed8ee8c6ae4
diff --git a/layout/wrapper.rs b/layout/wrapper.rs index d052c2636..8f948a9a1 100644 --- a/layout/wrapper.rs +++ b/layout/wrapper.rs @@ -417,6 +417,12 @@ impl<'le> TElement for LayoutElement<'le> { self.element.node.get_enabled_state_for_layout() } } + + fn has_class(&self, name: &str) -> ...
5
34
5
bba7afc5cd2824ebc45ce5a5436364ca52c53361
Glenn Watson
2014-09-12T05:51:00
servo: Merge #3294 - Coalesce pending reflow messages so they don't queue up (from glennw:guardian-layout) Source-Repo: https://github.com/servo/servo Source-Revision: 091cd688a00daedf8d0aef8c797c827df125c6cf
diff --git a/script/page.rs b/script/page.rs index 1955d9c8c..e61c3cd1a 100644 --- a/script/page.rs +++ b/script/page.rs @@ -91,6 +91,9 @@ pub struct Page { // Child Pages. pub children: Traceable<RefCell<Vec<Rc<Page>>>>, + + /// Number of pending reflows that were sent while layout was active. + pub ...
2
17
2
712da719d6f6935452c3708bee6b7c00fc44c891
Glenn Watson
2014-09-12T01:31:24
servo: Merge #3283 - Partial fix for background images on wikipedia pages (from glennw:bg-image) Source-Repo: https://github.com/servo/servo Source-Revision: a18633b163ab81a726efee75309814868c15260f
diff --git a/layout/fragment.rs b/layout/fragment.rs index 191283603..32532003f 100644 --- a/layout/fragment.rs +++ b/layout/fragment.rs @@ -719,43 +719,77 @@ impl Fragment { let vertical_position = model::specified(background.background_position.vertical, boun...
1
59
25
ed27ab8bdbbadec7c78aecec471e4a45210cc416
Clark Gaebel
2014-09-11T22:00:13
servo: Merge #3254 - Block LayoutRPC until the first reflow (from cgaebel:issue-3232) Source-Repo: https://github.com/servo/servo Source-Revision: 8116ee1b349f8a620c04734aec632af6b64570e0
diff --git a/layout/layout_task.rs b/layout/layout_task.rs index c3c463408..62c678155 100644 --- a/layout/layout_task.rs +++ b/layout/layout_task.rs @@ -59,7 +59,7 @@ use std::mem; use std::ptr; use style::{AuthorOrigin, Stylesheet, Stylist}; use style::iter_font_face_rules; -use sync::{Arc, Mutex}; +use sync::{Arc,...
1
74
19
d3596e31b21f361dd1efae5c6c39431a11450674
Sean McArthur
2014-09-11T20:45:06
servo: Merge #3216 - Implements about:blank in an about_loader (from seanmonstar:about-blank) Source-Repo: https://github.com/servo/servo Source-Revision: 4e35b82770823b20e4188206fbe3ccc6514877b4
diff --git a/net/about_loader.rs b/net/about_loader.rs new file mode 100644 index 000000000..af855d260 --- /dev/null +++ b/net/about_loader.rs @@ -0,0 +1,41 @@ +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You ca...
6
81
72
9ebfface1e2fa1a9aa955e582f4c468212ab1888
Glenn Watson
2014-09-11T12:59:04
servo: Merge #3284 - Return error when unable to create a file path from url (from glennw:file-loader-fix) Source-Repo: https://github.com/servo/servo Source-Revision: 68dcc67d9809477927e2c47dd5bd77d5f450e052
diff --git a/net/file_loader.rs b/net/file_loader.rs index df775775b..73a1d81cc 100644 --- a/net/file_loader.rs +++ b/net/file_loader.rs @@ -35,16 +35,23 @@ pub fn factory() -> LoaderTask { assert!("file" == url.scheme.as_slice()); let progress_chan = start_sending(start_chan, Metadata::default(url.cl...
1
15
8
81fdc8b5a73e7253f9318908294d3fc2f2937dcc
Patrick Walton
2014-09-11T05:47:17
servo: Merge #3281 - net: Premultiply alpha in PNGs (from pcwalton:premultiply-alpha) Source-Repo: https://github.com/servo/servo Source-Revision: 1124430eeae73a6329926ad715cdf451be02c4d8
diff --git a/net/image/base.rs b/net/image/base.rs index deda4ee85..37f53f509 100644 --- a/net/image/base.rs +++ b/net/image/base.rs @@ -27,6 +27,20 @@ fn byte_swap(data: &mut [u8]) { } } +// TODO(pcwalton): Speed up with SIMD, or better yet, find some way to not do this. +fn byte_swap_and_premultiply(data: &mu...
1
17
2
74018fa2398ea39c279cb20190ddfb2b276d00f6
Jack Moffitt
2014-09-11T03:50:03
servo: Merge #3280 - Fix loading of file URLs with spaces (from metajack:path-with-spaces) Source-Repo: https://github.com/servo/servo Source-Revision: 3bd5ef3384610f6d666dedc9a5099f0c9d6d2cfc
diff --git a/net/file_loader.rs b/net/file_loader.rs index 43c3191c6..df775775b 100644 --- a/net/file_loader.rs +++ b/net/file_loader.rs @@ -35,7 +35,8 @@ pub fn factory() -> LoaderTask { assert!("file" == url.scheme.as_slice()); let progress_chan = start_sending(start_chan, Metadata::default(url.clon...
1
2
1
9bdace6fa2ab3944e60d4f9f5d94384c00b961b3
Tetsuharu OHZEKI
2014-09-10T21:10:57
servo: Merge #3274 - Move Attr::set_value and Attr::value out of the Attr impl (from saneyuki:attr) Source-Repo: https://github.com/servo/servo Source-Revision: 6bf8412f9acc522c5f937473d743d9e278d588b2
diff --git a/script/dom/attr.rs b/script/dom/attr.rs index 9f3fc9dc9..02945088b 100644 --- a/script/dom/attr.rs +++ b/script/dom/attr.rs @@ -110,39 +110,6 @@ impl Attr { let attr = Attr::new_inherited(local_name, value, name, namespace, prefix, owner); reflect_dom_object(box attr, &Window(*window), At...
9
57
40
41b1715dde599663603eb925ede4c06d8e8d7060
Manish Goregaokar
2014-09-10T13:09:38
servo: Merge #3258 - Add lint for type-checking transmutes; r=jack (from Manishearth:transmute_lint) Source-Repo: https://github.com/servo/servo Source-Revision: 7a974fa2319142279ffd068d6bac33b3308ccd90
diff --git a/macros/lib.rs b/macros/lib.rs index 20304ffe8..ec6b0ebed 100644 --- a/macros/lib.rs +++ b/macros/lib.rs @@ -6,9 +6,59 @@ //! Exports macros for use in other Servo crates. +extern crate syntax; + +#[phase(plugin, link)] +extern crate rustc; #[cfg(test)] extern crate sync; +use syntax::ast; +use syn...
1
50
0
fdec264da407408ce7cca692fbe4f4e0a328eeae
Glenn Watson
2014-09-10T09:18:43
servo: Merge #3272 - Fix layout of Create Account / Login when rendering Wikipedia (from glennw:wikipedia-layout) Source-Repo: https://github.com/servo/servo Source-Revision: db3217397b21cae9d1a9ab209b5718aa9c4d72aa
diff --git a/layout/block.rs b/layout/block.rs index b84e0da50..ba17b4179 100644 --- a/layout/block.rs +++ b/layout/block.rs @@ -1448,6 +1448,10 @@ impl Flow for BlockFlow { self.fragment.style().get_box().clear } + fn float_kind(&self) -> float::T { + self.fragment.style().get_box().float + ...
2
31
3
26de408bc2e161ac416ad381d418c63eb561898e
Glenn Watson
2014-09-10T00:39:27
servo: Merge #3256 - Improve quality of font rendering on Linux (and Android) (from glennw:font-fixes) Source-Repo: https://github.com/servo/servo Source-Revision: 6eeac023a939efe140b8bbdb0c32c437e7db5ffd
diff --git a/gfx/font_cache_task.rs b/gfx/font_cache_task.rs index 1b1ff6227..7d3541488 100644 --- a/gfx/font_cache_task.rs +++ b/gfx/font_cache_task.rs @@ -3,6 +3,7 @@ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ use platform::font_list::get_available_families; +use platform::font_list::get_syste...
4
65
29
b6670f8eed9fa2bc138b5089470707f794407ea7
Frank Denis
2023-09-19T16:51:33
Rename wasmtime-cli to wasmtime-crypto
diff --git a/Cargo.lock b/Cargo.lock index 95e4b9afb..536b1aab5 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -4033,56 +4033,6 @@ dependencies = [ "zstd", ] -[[package]] -name = "wasmtime-cli" -version = "12.0.2" -dependencies = [ - "anyhow", - "async-trait", - "bstr", - "clap", - "component-macro-test", - "componen...
3
52
52
f0c32245f09e51d7287a1faaba2c8d4df15607a3
Frank Denis
2023-08-12T13:17:14
Remove workspace from the example
diff --git a/wasmtime-crate-usage-example/Cargo.toml b/wasmtime-crate-usage-example/Cargo.toml index 6c0a5b8e0..ed7b3b306 100644 --- a/wasmtime-crate-usage-example/Cargo.toml +++ b/wasmtime-crate-usage-example/Cargo.toml @@ -8,3 +8,5 @@ anyhow = "1.0.44" wasmtime = "11.0.1" wasmtime-wasi = "11.0.1" wasi-crypto = { v...
1
2
0
de4ede08265e8e984a8fd34be5c0986e13b646b0
Trevor Elliott
2023-08-04T12:38:44
Add a bindgen test that exercises using error types from a different interface (#6802)
diff --git a/tests/all/component_model/bindgen/results.rs b/tests/all/component_model/bindgen/results.rs index dc1155866..6c0b3f8b6 100644 --- a/tests/all/component_model/bindgen/results.rs +++ b/tests/all/component_model/bindgen/results.rs @@ -710,6 +710,187 @@ mod variant_error { } } +mod multiple_interfaces_...
1
181
0
217de07e76b0aaec90b065eb875a92ab5f5823d8
Trevor Elliott
2023-08-03T20:11:30
Resolve trappable error types with fully qualified package paths (#6795) * Switch trappable_error_type to take a fully-qualified type path * Print trappable error types from other interfaces with their module path
diff --git a/Cargo.lock b/Cargo.lock index 25457ee41..944fe5182 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -4492,6 +4492,7 @@ version = "12.0.0" dependencies = [ "anyhow", "heck", + "indexmap 2.0.0", "wit-parser", ] diff --git a/crates/component-macro/src/bindgen.rs b/crates/component-macro/src/bindgen.rs in...
7
161
109
520015979139825df35f9b5a380f1c22632d8894
Alex Crichton
2023-08-02T15:56:06
Fix posix-signals-on-macos on aarch64-apple-darwin (#6793) Currently the `libc` crate has an incorrect definition of `ucontext_t` for this platform which is causing alignment issues when it's used. This fixes [this issue][1] and the `posix-signals-on-macos` feature on this platform. [1]: https://github.com/bytecodeal...
diff --git a/crates/runtime/src/traphandlers/unix.rs b/crates/runtime/src/traphandlers/unix.rs index 969041a56..4a7e2027b 100644 --- a/crates/runtime/src/traphandlers/unix.rs +++ b/crates/runtime/src/traphandlers/unix.rs @@ -173,6 +173,21 @@ unsafe extern "C" fn trap_handler( } } +// FIXME(rust-lang/libc#3312) ...
1
17
2
6eb58981d4bc4b80c32e9e159bfe3897f46a2400
Pat Hickey
2023-08-02T10:19:04
consistient WASI preview1 rights reporting (#6784) * wasi-tests path_open_preopen: hard-code minimum set of required rights * preview1 adapters: return exact same set of rights as wasi-common
diff --git a/crates/test-programs/wasi-tests/src/bin/path_open_preopen.rs b/crates/test-programs/wasi-tests/src/bin/path_open_preopen.rs index f1e7a3f7c..cb8e07490 100644 --- a/crates/test-programs/wasi-tests/src/bin/path_open_preopen.rs +++ b/crates/test-programs/wasi-tests/src/bin/path_open_preopen.rs @@ -20,6 +20,18...
3
180
34
a560d4019524014333b79fb8a7d090898a085199
Nick Fitzgerald
2023-08-01T20:27:56
Wasmtime: Introduce `{Module,Component}::resources_required` (#6789) Returns a summary of the resources required to instantiate this module or component. Potential uses of the returned information: * Determining whether your pooling allocator configuration supports instantiating this module. * Deciding how many o...
diff --git a/crates/wasmtime/src/component/component.rs b/crates/wasmtime/src/component/component.rs index 0d3af1916..45f4f007c 100644 --- a/crates/wasmtime/src/component/component.rs +++ b/crates/wasmtime/src/component/component.rs @@ -1,6 +1,6 @@ use crate::code::CodeObject; use crate::signatures::SignatureCollecti...
4
195
3
72b87183ffc57d834737e9ad6d4f1c1967e559a9
Rainy Sinclair
2023-08-01T15:49:39
Add core dump support to the runtime (#6513) * Add config method for whether or not to capture coredumps on trap * Add core dump support to the runtime This adds the machinery to capture a core dump when a trap occurs and attach it to the resulting anyhow::Error that gets bubbled up to the caller. I've created a Cor...
diff --git a/Cargo.lock b/Cargo.lock index 2f1339dce..b1d1dc632 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -3976,6 +3976,7 @@ dependencies = [ "target-lexicon", "tempfile", "wasi-cap-std-sync", + "wasm-encoder 0.31.1", "wasmparser 0.110.0", "wasmtime-cache", "wasmtime-component-macro", @@ -4361,6 +4362,7 @...
18
436
32
eb40e59ed38477df3649fcb8a334e33651284371
Nick Fitzgerald
2023-08-01T00:04:24
Wasmtime: Move `OnDemandInstanceAllocator` to its own module (#6790) Just code motion, no other changes.
diff --git a/crates/runtime/src/instance/allocator.rs b/crates/runtime/src/instance/allocator.rs index a7cbaeef7..da5419574 100644 --- a/crates/runtime/src/instance/allocator.rs +++ b/crates/runtime/src/instance/allocator.rs @@ -1,6 +1,6 @@ use crate::imports::Imports; -use crate::instance::{Instance, InstanceHandle, ...
2
132
122
c61899aea0f1322184313ff156528ec2610a41d5
Trevor Elliott
2023-07-31T22:26:52
wasi: Test the stdio streams implementation (#6764) * Add a helper for writing stdin tests * Test a use of preview2::stdio::Stdin on unix * Abstract the stdin test, and apply it to tokio::stdin and worker_thread_stdin * re-implement worker thread stdin with a watch * poll_oneoff_stdio should work on windows now *...
diff --git a/crates/test-programs/tests/wasi-preview2-components-sync.rs b/crates/test-programs/tests/wasi-preview2-components-sync.rs index 85e8cea10..37a03d2aa 100644 --- a/crates/test-programs/tests/wasi-preview2-components-sync.rs +++ b/crates/test-programs/tests/wasi-preview2-components-sync.rs @@ -245,7 +245,6 @@...
9
375
188
b84bf7ac7c1f360b635dc9cee93cfb74eac5ce32
Alex Crichton
2023-07-28T16:58:14
Don't generate same-named imports in fact modules (#6783) Ensure that all imports have unique module/name combos to ensure that the module can be instantiable in JS where separate functions need to be provided for each import.
diff --git a/crates/environ/src/fact.rs b/crates/environ/src/fact.rs index 4d35ee5ea..70437996c 100644 --- a/crates/environ/src/fact.rs +++ b/crates/environ/src/fact.rs @@ -262,7 +262,7 @@ impl<'a> Module<'a> { let memory = memory.as_ref().map(|memory| { self.import_memory( "memor...
1
7
2
7e66ed245702c44646b9286999a31dcd87653b35
bjorn3
2023-07-25T21:20:40
A bunch of cleanups for cranelift-codegen-meta (#6772) * Remove shared_defs args from all per-isa definitions They don't and shouldn't define any isa-independent things * Inline all define_settings functions * Merge verify_instruction_formats into shared::define() It isn't modified in between anyway now. * Enable...
diff --git a/cranelift/codegen/Cargo.toml b/cranelift/codegen/Cargo.toml index 20c6302c4..a0a78ba86 100644 --- a/cranelift/codegen/Cargo.toml +++ b/cranelift/codegen/Cargo.toml @@ -61,10 +61,6 @@ core = [] # context, and the `disassemble` method on `MachBufferFinalized`. disas = ["anyhow", "capstone"] -# This enabl...
11
83
125
7dfae4c38e4649a225abc2fa0796855c2fa6e351
guregu
2023-07-25T16:47:37
Ignore async_stack_size if async_support is disabled (#6771) Fixes an issue where max_wasm_stack was being validated against async_stack_size when async_support was disabled, discussed in #6762.
diff --git a/crates/wasmtime/src/config.rs b/crates/wasmtime/src/config.rs index b0d5bdc87..42e881375 100644 --- a/crates/wasmtime/src/config.rs +++ b/crates/wasmtime/src/config.rs @@ -1498,7 +1498,7 @@ impl Config { bail!("feature 'threads' requires 'bulk_memory' to be enabled"); } #[cfg...
2
11
1
729e26409ef5b1cf6dc3c0b17dfba6bfa20ecb8d
bjorn3
2023-07-25T14:48:37
A bunch of minor cleanups (#6767) * Remove DisplayFunctionAnnotations It used to exist for printing the debuginfo value ranges with the clif ir, but this no longer happens, so it is now useless. * Remove debug info collection from DummyEnvironment There are no remaining users of it * Remove ComparableSourceLoc It...
diff --git a/cranelift/codegen/src/ir/extfunc.rs b/cranelift/codegen/src/ir/extfunc.rs index e3822c6e4..2df0f890f 100644 --- a/cranelift/codegen/src/ir/extfunc.rs +++ b/cranelift/codegen/src/ir/extfunc.rs @@ -7,7 +7,6 @@ use crate::ir::{ExternalName, SigRef, Type}; use crate::isa::CallConv; -use crate::machinst::Re...
17
52
174
e81af419884931e7d43108b2e1ef89e7e4a5d969
Pat Hickey
2023-07-24T23:01:38
Fix flaky tests in preview2 streams (#6763) * preview2::pipe sink_write_stream test bugfix I didn't realize this test was racy, but it makes sense because the worker is consuming these writes in another thread. usually the foreground thread wins, but we observed the other case once in CI * fix wasi-preview2-componen...
diff --git a/crates/wasi/src/preview2/pipe.rs b/crates/wasi/src/preview2/pipe.rs index 02e2ca096..34eb8a34f 100644 --- a/crates/wasi/src/preview2/pipe.rs +++ b/crates/wasi/src/preview2/pipe.rs @@ -666,10 +666,13 @@ mod test { assert_eq!(len, chunk.len()); assert_eq!(state, StreamState::Open); - ...
2
6
3
2d701cd5e864fa4f8fdaf7c3976489eae7eddcf8
Nick Fitzgerald
2023-07-22T20:57:16
cranelift-wasm: Add support for translating Wasm tail calls to CLIF (#6760)
diff --git a/cranelift/filetests/src/test_wasm/env.rs b/cranelift/filetests/src/test_wasm/env.rs index c96fa2009..330ba204d 100644 --- a/cranelift/filetests/src/test_wasm/env.rs +++ b/cranelift/filetests/src/test_wasm/env.rs @@ -400,6 +400,27 @@ impl<'a> FuncEnvironment for FuncEnv<'a> { ) } + fn tra...
5
162
14
329a2baf0cd7aa2456996dba3c8c72f267c4d96d
MindSwipe
2023-07-19T20:57:57
Change the call to unwrap to except with an error message (#6745) * Change the call to unwrap to except with an error message * Update crates/c-api/src/linker.rs * Run rustfmt. --------- Co-authored-by: Peter Huene <peter@huene.dev>
diff --git a/crates/c-api/src/linker.rs b/crates/c-api/src/linker.rs index 31a5aeed4..05c274ef9 100644 --- a/crates/c-api/src/linker.rs +++ b/crates/c-api/src/linker.rs @@ -102,7 +102,11 @@ pub extern "C" fn wasmtime_linker_define_wasi( linker: &mut wasmtime_linker_t, ) -> Option<Box<wasmtime_error_t>> { han...
1
5
1
475d1ba5e9a5564a94d105c4fcb4c1ccf0f5c52d
Alex Crichton
2023-07-19T14:49:45
Cap the maximum basic block padding in Cranelift (#6736) * Cap the maximum basic block padding in Cranelift This commit is a fix for a fuzz failure that came in the other day where a module took more than 2GB of memory to compile, triggering the fuzzer to fail. Investigating locally it looks like the problem lies in ...
diff --git a/cranelift/codegen/src/machinst/vcode.rs b/cranelift/codegen/src/machinst/vcode.rs index a727ad537..81787ca36 100644 --- a/cranelift/codegen/src/machinst/vcode.rs +++ b/cranelift/codegen/src/machinst/vcode.rs @@ -827,10 +827,11 @@ impl<I: VCodeInst> VCode<I> { } let is_forward_edge_cfi_e...
2
38
10
fe69c0437602a59e718de04f1d40bebf0bf51662
Afonso Bordado
2023-07-19T14:14:09
fuzzgen: Enable `bitcast` instruction (#6747)
diff --git a/cranelift/fuzzgen/src/function_generator.rs b/cranelift/fuzzgen/src/function_generator.rs index dbc8d3d67..a6ae48e5f 100644 --- a/cranelift/fuzzgen/src/function_generator.rs +++ b/cranelift/fuzzgen/src/function_generator.rs @@ -8,8 +8,8 @@ use cranelift::codegen::ir::instructions::{InstructionFormat, Resol...
1
35
170
61a343bb33a0f582e75af7b7e0a4d7128b8ac533
Alex Crichton
2023-07-17T21:07:33
Reference a missing filename when parsing modules (#6738) Currently wasmtime's error message for `wasmtime nonexistent.wasm` doesn't actually refer to `nonexistent.wasm` anywhere, so this commit fills that in as contextual information on the returned error.
diff --git a/crates/wasmtime/src/module.rs b/crates/wasmtime/src/module.rs index 71c1237e7..fede47007 100644 --- a/crates/wasmtime/src/module.rs +++ b/crates/wasmtime/src/module.rs @@ -235,9 +235,11 @@ impl Module { #[cfg(any(feature = "cranelift", feature = "winch"))] #[cfg_attr(nightlydoc, doc(cfg(any(featu...
1
3
1
b8cc38bbe638ce4043cebf1aa720da05c9bc76a3
Alex Crichton
2023-07-14T21:24:51
Lock dependency on hyper to a single version (#6729) Currently Cargo's interpretation of prerelease version doesn't quite match semver's, meaning that hyper, which is taking semver's interpretation, has broken Wasmtime builds without lock files. The rc.4 version of hyper released is no longer compatible with our usage...
diff --git a/crates/wasi-http/Cargo.toml b/crates/wasi-http/Cargo.toml index f91f9b523..7e92f9966 100644 --- a/crates/wasi-http/Cargo.toml +++ b/crates/wasi-http/Cargo.toml @@ -10,7 +10,7 @@ description = "Experimental HTTP library for WebAssembly in Wasmtime" [dependencies] anyhow = { workspace = true } bytes = "1....
1
1
1
3dc47d1d611f76a75efb8f9d454989e997be7909
Javier Cabrera
2023-07-13T13:51:24
FIX: doc typos for gen_(store|load)_base_offset functions (#6718)
diff --git a/cranelift/codegen/src/machinst/abi.rs b/cranelift/codegen/src/machinst/abi.rs index 1697c700c..1ffbb7cbd 100644 --- a/cranelift/codegen/src/machinst/abi.rs +++ b/cranelift/codegen/src/machinst/abi.rs @@ -494,10 +494,10 @@ pub trait ABIMachineSpec { /// temporary as this one. fn get_stacklimit_r...
1
2
2
c34567cdddc483d6bdf6a7b04c43026174eef5bf
Alex Crichton
2023-07-07T20:08:44
Fix some warnings on nightly Rust (#6702) * Fix some warnings on nightly Rust * One is to avoid using `drop(&mut T)` * Another is to avoid using `()` in FFI functions since apparently that's not recommended. Working around this in the macro was pretty tricky, however. * Fix a typo * Review feedback
diff --git a/cranelift/filetests/src/function_runner.rs b/cranelift/filetests/src/function_runner.rs index dff1fda6c..5f034fc51 100644 --- a/cranelift/filetests/src/function_runner.rs +++ b/cranelift/filetests/src/function_runner.rs @@ -90,7 +90,7 @@ impl TestFileCompiler { /// [TestFileCompiler::with_host_isa]). ...
4
34
29
e4b88760480fba76a9e1a55e4e998186262bf89b
Nick Fitzgerald
2023-07-07T17:34:43
Fuzzing: Check that Wasm compilation is deterministic (#6704)
diff --git a/fuzz/fuzz_targets/compile.rs b/fuzz/fuzz_targets/compile.rs index 93ff23c1b..743ea9468 100644 --- a/fuzz/fuzz_targets/compile.rs +++ b/fuzz/fuzz_targets/compile.rs @@ -1,10 +1,12 @@ -//! Compile arbitrary bytes from the fuzzer as if they were Wasm. Also use -//! `wasm-mutate` to mutate the fuzz inputs. +//...
1
20
4
e3d7b8aa2156136a6befcbf4dcbf139a583a2b39
Marco Concetto Rudilosso
2023-07-07T14:24:01
allow perfmaps on any unix platform (#6701) * allow perfmaps on any unix platform * change it in cranelift as well
diff --git a/cranelift/jit/src/backend.rs b/cranelift/jit/src/backend.rs index 1bf34cc1f..b564b82b6 100644 --- a/cranelift/jit/src/backend.rs +++ b/cranelift/jit/src/backend.rs @@ -434,7 +434,7 @@ impl JITModule { // are profiling with perf and saving binaries to PERF_BUILDID_DIR // for post-profile a...
2
2
2
73405a457ca99d560ea201595cb37430afa8f45c
Alex Crichton
2023-07-06T17:37:25
Update calling conventions for wasm functions slightly (#6676) * Update calling conventions for wasm functions slightly This resolves two issues from recent changes in #6649: * First the s390x calling convention for wasm functions is changed back to `WasmtimeSystemV` from `Fast`. This was an accidental omission fr...
diff --git a/crates/cranelift/src/lib.rs b/crates/cranelift/src/lib.rs index cc6ae5358..87adcf182 100644 --- a/crates/cranelift/src/lib.rs +++ b/crates/cranelift/src/lib.rs @@ -7,7 +7,7 @@ use cranelift_codegen::ir; use cranelift_codegen::isa::{CallConv, TargetIsa}; use cranelift_entity::PrimaryMap; use cranelift_wa...
1
21
12
e6ef1ba4efa406a56968eeb971c5d118a8cb98f8
Alex Crichton
2023-07-06T16:27:32
Fix signatures registered with modules-in-components (#6694) * Fix signatures registered with modules-in-components This commit fixes a minor issue in `FunctionIndices::link_and_append_code` which previously ended up only filling out the `wasm_to_native_trampolines` field for the first module rather than all the modu...
diff --git a/crates/wasmtime/src/compiler.rs b/crates/wasmtime/src/compiler.rs index e9ec3cb36..1817de872 100644 --- a/crates/wasmtime/src/compiler.rs +++ b/crates/wasmtime/src/compiler.rs @@ -24,12 +24,11 @@ use crate::Engine; use anyhow::Result; -use std::collections::{btree_map, BTreeMap}; +use std::collections:...
2
48
17
6a868ef181b481076b01b0e59c05aa8f5fae1abb
Alex Crichton
2023-07-05T23:25:01
Store all instantiation arguments in a component (#6693) * Store all instantiation arguments in a component This commit updates how instantiation arguments are rooted within a component instance. Previously a list of import arguments was "unzipped" into a list of modules and a list of functions. This is becoming a bi...
diff --git a/crates/environ/src/component/dfg.rs b/crates/environ/src/component/dfg.rs index bd7ee9658..aa02d6b7d 100644 --- a/crates/environ/src/component/dfg.rs +++ b/crates/environ/src/component/dfg.rs @@ -303,7 +303,6 @@ impl ComponentDfg { let mut linearize = LinearizeDfg { dfg: &self, ...
5
56
87
624d68b6cebae6d19879fb1dae33a9d3e67fd18d
Joel Dice
2023-07-05T22:54:33
handle interface functions correctly in `component::Linker::func_new` (#6637) * handle interface functions correctly in `component::Linker::func_new` Many months ago, I implemented `func_new`, but only supporting top-level function imports. If you tried to link a host function under an imported interface, it would m...
diff --git a/crates/wasmtime/src/component/linker.rs b/crates/wasmtime/src/component/linker.rs index cf2bbb302..c97308fa0 100644 --- a/crates/wasmtime/src/component/linker.rs +++ b/crates/wasmtime/src/component/linker.rs @@ -4,9 +4,11 @@ use crate::component::matching::TypeChecker; use crate::component::{Component, Co...
2
149
13
75a66b5f2930b3250a904c1203b3b03bd54f9938
Alex Crichton
2023-07-05T22:45:41
Fix a typo in an `unsafe impl Send/Sync` (#6692) * Fix a typo in an `unsafe impl Send/Sync` This commit fixes a mistake in the `PrePatchedFuncRef` type where it has an `unsafe impl` to make it send/sync but the target of the impl was mistakenly `InstancePre<T>` Note that this doesn't actually have any impact on the ...
diff --git a/crates/wasmtime/src/instance.rs b/crates/wasmtime/src/instance.rs index 9350ffbd8..697e62a42 100644 --- a/crates/wasmtime/src/instance.rs +++ b/crates/wasmtime/src/instance.rs @@ -666,36 +666,11 @@ pub struct InstancePre<T> { /// instantiation time. /// /// This is an `Arc<[T]>` for the same...
3
10
36
c19c729214e2237902eb177609643cb6523b7f2b
Afonso Bordado
2023-07-01T17:02:45
cranelift: Remove unused code in filetests (#6678)
diff --git a/cranelift/filetests/src/runtest_environment.rs b/cranelift/filetests/src/runtest_environment.rs deleted file mode 100644 index 8a32e8161..000000000 --- a/cranelift/filetests/src/runtest_environment.rs +++ /dev/null @@ -1,36 +0,0 @@ -use anyhow::anyhow; -use cranelift_codegen::ir::{ArgumentPurpose, Function...
1
0
36
b741f7c79d72492d17ab8a29c8ffe4687715938e
Ryan Levick
2023-06-30T22:25:35
Add `WasiCtxBuilder` setters for the two clock types (#6669) * Add WasiCtxBuilder setters for the two clock types Signed-off-by: Ryan Levick <ryan.levick@fermyon.com> * Move two clocks to dedicated fields in WasiCtx * Rename clock traits to Host prefix convention Signed-off-by: Ryan Levick <ryan.levick@fermyon.com...
diff --git a/crates/test-programs/tests/command.rs b/crates/test-programs/tests/command.rs index f16f14405..3473a7c9d 100644 --- a/crates/test-programs/tests/command.rs +++ b/crates/test-programs/tests/command.rs @@ -9,11 +9,11 @@ use wasmtime::{ Config, Engine, Store, }; use wasmtime_wasi::preview2::{ - cloc...
9
47
41
a43d1dc68fc24e71f726ec858db90f1731e96a11
Afonso Bordado
2023-06-29T18:35:54
fuzzgen: Generate Tail Calls (#6641) * fuzzgen: Generate Tail Calls * fuzzgen: Use the ISA's pointer type when preparing indirect calls
diff --git a/cranelift/fuzzgen/src/function_generator.rs b/cranelift/fuzzgen/src/function_generator.rs index 1e5626ded..f4d0746e5 100644 --- a/cranelift/fuzzgen/src/function_generator.rs +++ b/cranelift/fuzzgen/src/function_generator.rs @@ -13,6 +13,7 @@ use cranelift::codegen::ir::{ }; use cranelift::codegen::isa::C...
4
127
42
cd93f17a838bd2fa153d19ec513949cd4a3ffe1a
Stephen Doyle
2023-06-29T15:13:50
wasmtime bench-api build error when using --feature wasi-crypto (#6670) (#6671) Fixing typo of wasmtime_wasi_nn -> wasmtime_wasi_crypto that was causing a build error when building the bench-api with the wasi-crypto feature enabled.
diff --git a/crates/bench-api/src/lib.rs b/crates/bench-api/src/lib.rs index 3d605a75f..a998bc22f 100644 --- a/crates/bench-api/src/lib.rs +++ b/crates/bench-api/src/lib.rs @@ -518,7 +518,7 @@ impl BenchState { #[cfg(feature = "wasi-nn")] wasi_nn: wasmtime_wasi_nn::WasiNnCtx::new()?, ...
1
1
1
119109190e70960bd9285bc9bf9bcd7487d99d6a
Nick Fitzgerald
2023-06-28T23:45:42
Cranelift: Refactor `return_call[_indirect]` lowering (#6666) Commons up some code paths and sets the stage for other architectures. This should have fewer calls back and forth between architecture specific and independent bits of code, which I have found hard to keep track of. Now, lowering tail calls is done in arch...
diff --git a/cranelift/codegen/src/isa/aarch64/abi.rs b/cranelift/codegen/src/isa/aarch64/abi.rs index b573cb670..9959409a2 100644 --- a/cranelift/codegen/src/isa/aarch64/abi.rs +++ b/cranelift/codegen/src/isa/aarch64/abi.rs @@ -1046,19 +1046,6 @@ impl ABIMachineSpec for AArch64MachineDeps { insts } - ...
7
147
244
8f8fbf8171e777d15bbf40c30871383ac4d9442e
Nick Fitzgerald
2023-06-28T19:16:01
Cranelift: CallSite constructors are infallible (#6665) So no reason to return a result.
diff --git a/cranelift/codegen/src/isa/x64/lower.rs b/cranelift/codegen/src/isa/x64/lower.rs index bebbaf6c7..9e74d2719 100644 --- a/cranelift/codegen/src/isa/x64/lower.rs +++ b/cranelift/codegen/src/isa/x64/lower.rs @@ -159,7 +159,7 @@ fn emit_vm_call( } let mut abi = - X64CallSite::from_libcall(ctx...
4
14
18
e04f766639c82b5347f86c58aaecef4fbc4b42bb
Afonso Bordado
2023-06-28T15:19:05
riscv64: Enable `memory_multi` testsuite (#6658)
diff --git a/build.rs b/build.rs index 3c506a4eb..cde74576a 100644 --- a/build.rs +++ b/build.rs @@ -224,7 +224,7 @@ fn ignore(testsuite: &str, testname: &str, strategy: &str) -> bool { } "riscv64" => { - if testname.contains("memory_multi") || testsuite.contains("relaxed_simd") { + ...
1
1
1
dd6adfdbb8160491530fba8ab9f6a5da6af97a5e
Nick Fitzgerald
2023-06-27T21:21:03
Cranelift: Log duration of timing passes (#6654) Might as well, have it right there. Weird seeing all these start/end logs without the duration itself, otherwise.
diff --git a/cranelift/codegen/src/timing.rs b/cranelift/codegen/src/timing.rs index 50a0b66ad..573b82c0c 100644 --- a/cranelift/codegen/src/timing.rs +++ b/cranelift/codegen/src/timing.rs @@ -238,7 +238,7 @@ impl Profiler for DefaultProfiler { impl Drop for DefaultTimingToken { fn drop(&mut self) { let ...
1
1
1
6fa62bd5fe81d1f29143c54dc73f5d285913b3b0
Nick Fitzgerald
2023-06-27T21:19:39
Cranelift: Use `crate::trace!` instead of `log::trace!` (#6653)
diff --git a/cranelift/codegen/src/isa/riscv64/inst/emit.rs b/cranelift/codegen/src/isa/riscv64/inst/emit.rs index bcbf85f7a..feadde261 100644 --- a/cranelift/codegen/src/isa/riscv64/inst/emit.rs +++ b/cranelift/codegen/src/isa/riscv64/inst/emit.rs @@ -1159,7 +1159,7 @@ impl MachInstEmit for Inst { } ...
3
3
3
9d0bf8b191d35792b85b68842dc282412f977a65
Pat Hickey
2023-06-27T21:17:58
preview2: refactor WasiCtxBuilder impl, and make WasiCtx fields private (#6652) * preview2: refactor WasiCtxBuilder impl, and make WasiCtx fields private The optional-fields WasiCtxBuilder was an intermediate stepping stone which has outlived its usefulness - there is now only one sensible default value for each fiel...
diff --git a/crates/test-programs/tests/command.rs b/crates/test-programs/tests/command.rs index 3f03dc3cd..f16f14405 100644 --- a/crates/test-programs/tests/command.rs +++ b/crates/test-programs/tests/command.rs @@ -13,7 +13,7 @@ use wasmtime_wasi::preview2::{ pipe::ReadPipe, wasi::command::add_to_linker, ...
4
88
103
537214fd7129da0e95e741f7526216034bb1ba45
Joel Dice
2023-06-27T18:12:26
[wit-bindgen] provide more control over type ownership (#6648) * [wit-bindgen] provide more control over type ownership This replaces the `duplicate_if_necessary` parameter to `wasmtime::component::bindgen` with a new `ownership` parameter which provides finer-grained control over whether and how generated types own ...
diff --git a/crates/component-macro/src/bindgen.rs b/crates/component-macro/src/bindgen.rs index e41e0fa2a..51241a848 100644 --- a/crates/component-macro/src/bindgen.rs +++ b/crates/component-macro/src/bindgen.rs @@ -4,7 +4,7 @@ use std::path::{Path, PathBuf}; use syn::parse::{Error, Parse, ParseStream, Result}; use ...
8
446
40
9633bfcc334b787d9e630058f5b50066652b9725
Alex Crichton
2023-06-27T17:16:25
Refactor compilation of component-related functions (#6647) * Refactor compilation of component-related functions Extract some common functionality out to helper functions to reduce the boilerplate involved in compiling component-related functions. This is in preparation for upcoming resource-related work which adds ...
diff --git a/crates/cranelift/src/compiler/component.rs b/crates/cranelift/src/compiler/component.rs index 76c3dfc7e..55c6018d0 100644 --- a/crates/cranelift/src/compiler/component.rs +++ b/crates/cranelift/src/compiler/component.rs @@ -12,6 +12,7 @@ use wasmtime_environ::component::{ }; use wasmtime_environ::{PtrSiz...
1
64
92
4c238801a6dd11f25a524aed24cc3ef36c76acb9
Nick Fitzgerald
2023-06-26T22:53:03
Cranelift: Provide better error messages when failing to parse `run` arguments (#6644)
diff --git a/cranelift/reader/src/parser.rs b/cranelift/reader/src/parser.rs index 2f4da551d..83be39a33 100644 --- a/cranelift/reader/src/parser.rs +++ b/cranelift/reader/src/parser.rs @@ -49,7 +49,11 @@ macro_rules! match_imm { let text = text.replace("_", ""); // Parse it in hexadeci...
1
5
1
2d34b4657aa5290948da9a07cb31764a12c12994
Alex Crichton
2023-06-23T13:38:18
aarch64: Fix `AuthenticatedRet` when stack bytes are popped (#6634) * aarch64: Fix `AuthenticatedRet` when stack bytes are popped This commit fixes an accidental issue with #6478 where when pointer authentication was enabled and stack bytes are being popped during a return this didn't work. In this situation an authe...
diff --git a/cranelift/codegen/src/isa/aarch64/inst/emit.rs b/cranelift/codegen/src/isa/aarch64/inst/emit.rs index 9ef996e4d..9fbed6a87 100644 --- a/cranelift/codegen/src/isa/aarch64/inst/emit.rs +++ b/cranelift/codegen/src/isa/aarch64/inst/emit.rs @@ -3153,6 +3153,21 @@ impl MachInstEmit for Inst { ...
2
16
1
48e140d71a68b869646c75d654c6dd7a200d7a10
Cameron Harris
2023-06-22T18:17:46
Issue-6592: ArgsAccumulator should match entry block params (#6613) * issue-6592: args accumulator match entry block params * Formatting * Formatting * added push_non_formal to aarch64 and x86 implementations of add_ret_area_ptr case in compute_arg_locs --------- Co-authored-by: Cameron <cameron@Camerons-MacBook-...
diff --git a/cranelift/codegen/src/isa/aarch64/abi.rs b/cranelift/codegen/src/isa/aarch64/abi.rs index 4a6dc9efd..5c786eced 100644 --- a/cranelift/codegen/src/isa/aarch64/abi.rs +++ b/cranelift/codegen/src/isa/aarch64/abi.rs @@ -336,14 +336,14 @@ impl ABIMachineSpec for AArch64MachineDeps { let extra_arg = if ...
3
13
4
2b3f56b20ade248420b06ae946f975c248fa8549
Nick Fitzgerald
2023-06-22T17:46:14
Cranelift: Add methods for adjust `EmitState` (#6621) Gives us a single place to `trace!` log state changes and prevents things from getting out of sync in the future.
diff --git a/cranelift/codegen/src/isa/x64/abi.rs b/cranelift/codegen/src/isa/x64/abi.rs index e994ca7c8..2e6bec675 100644 --- a/cranelift/codegen/src/isa/x64/abi.rs +++ b/cranelift/codegen/src/isa/x64/abi.rs @@ -759,11 +759,11 @@ impl ABIMachineSpec for X64ABIMachineSpec { } fn get_virtual_sp_offset_from_s...
5
99
93
76ec3df79aaf113b99728b2ae0943b0edf806738
Dan Gohman
2023-06-22T16:19:04
Add a `set_random` function to `WasiCtxBuilder`. (#6596) * Add a `set_random` function to `WasiCtxBuilder`. Add a `set_random` function to `WasiCtxBuilder`, allowing users that construct a default interface via `WasiCtxBuilder::default()` or `WasiCtx::builder()` to initialize the `random` state. Fixes #6576. * Rena...
diff --git a/crates/wasi/src/preview2/ctx.rs b/crates/wasi/src/preview2/ctx.rs index 511008b9c..ab397dc73 100644 --- a/crates/wasi/src/preview2/ctx.rs +++ b/crates/wasi/src/preview2/ctx.rs @@ -34,14 +34,14 @@ impl WasiCtxBuilder { let insecure_random_seed = cap_rand::thread_rng(cap_rand::ambient_a...
1
29
8
d24282c1fffa6773dca855919985a0a92fc1ee34
Sofia
2023-06-22T06:01:39
Update unionfind.rs (#6622) Corrected the comment from "path splitting" to "path halving" to align with the implementation.
diff --git a/cranelift/codegen/src/unionfind.rs b/cranelift/codegen/src/unionfind.rs index b6c534aa5..a51f305c2 100644 --- a/cranelift/codegen/src/unionfind.rs +++ b/cranelift/codegen/src/unionfind.rs @@ -48,7 +48,7 @@ impl<Idx: EntityRef + Hash + std::fmt::Display + Ord + ReservedValue> UnionFind< /// (and others...
1
1
1
4adae2d75a68685da9af8696b114ab98a045484f
Trevor Elliott
2023-06-21T16:17:59
Only expose the preview2 module if its feature is enabled (#6615)
diff --git a/crates/wasi/src/lib.rs b/crates/wasi/src/lib.rs index 0fb90a3dc..23dccca18 100644 --- a/crates/wasi/src/lib.rs +++ b/crates/wasi/src/lib.rs @@ -7,6 +7,7 @@ //! Individual snapshots are available through //! `wasmtime_wasi::snapshots::preview_{0, 1}::Wasi::new(&Store, Rc<RefCell<WasiCtx>>)`. +#[cfg(feat...
1
1
0
b7b84780603122c505f4f02f8c1d9cc13b4af240
Eduardo Sánchez Muñoz
2023-06-21T14:31:09
cranelift-codegen: add feature to explicitly enable the host ISA (#6551) It is needed because cargo features are additive. Given a situation where you have two dependencies: * One depends on cranelift aarch64 codegen, so it enables the `aarch64` feature. * The other depends on cranelift native codegen, so it does not...
diff --git a/cranelift/codegen/Cargo.toml b/cranelift/codegen/Cargo.toml index 9b2058042..1a9c3b9da 100644 --- a/cranelift/codegen/Cargo.toml +++ b/cranelift/codegen/Cargo.toml @@ -44,7 +44,7 @@ cranelift-codegen-meta = { path = "meta", version = "0.98.0" } cranelift-isle = { path = "../isle/isle", version = "=0.98.0"...
2
9
7
143a83888ffb5c3cf093ab8615edc4d9f4f4cb69
Alex Crichton
2023-06-21T14:06:52
Fix a flaky poll_oneoff test (#6577) This commit fixes a test that has failed on CI and seems flaky. This test asserts that stderr/stdout are writable and that a 200ms timeout does not elapse when calculating this. The implementation, on Windows at least, of `poll_oneoff` always reports stdout/stderr as "ready for wri...
diff --git a/crates/test-programs/wasi-tests/src/bin/poll_oneoff_stdio.rs b/crates/test-programs/wasi-tests/src/bin/poll_oneoff_stdio.rs index d3b39c95a..a66eb94ff 100644 --- a/crates/test-programs/wasi-tests/src/bin/poll_oneoff_stdio.rs +++ b/crates/test-programs/wasi-tests/src/bin/poll_oneoff_stdio.rs @@ -103,15 +103...
1
5
3
8693b829f707e36efbff4146a22d63211e894d21
Dan Gohman
2023-06-21T12:26:19
Fix inconsistent deadlines for monotonic clock timeouts (#6597) * Fix inconsistent deadlines for monotonic clock timeouts Rename `MonotonicClockSubscription`'s `deadline` field to `absolute_deadline` and change the code that computes the value to compute an absolute time rather than a relative time, so that it's inte...
diff --git a/crates/test-programs/tests/wasi-preview2-components.rs b/crates/test-programs/tests/wasi-preview2-components.rs index 2b65ffaf7..027ca510c 100644 --- a/crates/test-programs/tests/wasi-preview2-components.rs +++ b/crates/test-programs/tests/wasi-preview2-components.rs @@ -256,8 +256,8 @@ async fn poll_oneof...
4
17
12
696b536aba93a06d87a761fa4e442c5064703aea
Afonso Bordado
2023-06-14T16:26:13
fuzzgen: Generate Random Calling Convetions (#6579) * fuzzgen: Generate random calling convetions * fuzzgen: Disable Tail Calls * fuzzgen: Fix Typo * fuzzgen: Add issue numbers for tail calls Co-authored-by: Nick Fitzgerald <fitzgen@gmail.com> --------- Co-authored-by: Nick Fitzgerald <fitzgen@gmail.com>
diff --git a/cranelift/fuzzgen/src/cranelift_arbitrary.rs b/cranelift/fuzzgen/src/cranelift_arbitrary.rs index b15622687..f1ee590ec 100644 --- a/cranelift/fuzzgen/src/cranelift_arbitrary.rs +++ b/cranelift/fuzzgen/src/cranelift_arbitrary.rs @@ -12,7 +12,7 @@ use target_lexicon::Architecture; /// A trait for generating...
1
23
5
8bec98da28f718ebf9ded89e4fa8f1483a88674b
Alex Crichton
2023-06-13T21:45:50
Fix some beta warnings in the C API (#6578) This'll make the future upgrade to Rust 1.71 that much more smoother.
diff --git a/crates/c-api/src/func.rs b/crates/c-api/src/func.rs index 2e4713f62..31da871ae 100644 --- a/crates/c-api/src/func.rs +++ b/crates/c-api/src/func.rs @@ -106,7 +106,7 @@ pub unsafe extern "C" fn wasm_func_new_with_env( ) -> Box<wasm_func_t> { let finalizer = crate::ForeignData { data, finalizer }; ...
1
3
3
1d6044311d661895e87711686ceb055342d320ec
Afonso Bordado
2023-06-13T19:08:44
fuzzgen: Add `bb_padding_log2` option (#6575)
diff --git a/cranelift/fuzzgen/src/config.rs b/cranelift/fuzzgen/src/config.rs index 9e7a094a9..a444766ae 100644 --- a/cranelift/fuzzgen/src/config.rs +++ b/cranelift/fuzzgen/src/config.rs @@ -63,6 +63,10 @@ pub struct Config { /// them, but probably at a lower rate, so that overall execution time isn't /// i...
2
15
0
1cabece50b88e4016e885e226d670916eb27b286
Doug A
2023-06-11T05:27:59
Update mod.rs (#6559) update docs: prepend func call with `call_`
diff --git a/crates/wasmtime/src/component/mod.rs b/crates/wasmtime/src/component/mod.rs index f2066843e..fc8b84895 100644 --- a/crates/wasmtime/src/component/mod.rs +++ b/crates/wasmtime/src/component/mod.rs @@ -209,7 +209,7 @@ pub(crate) use self::store::ComponentStoreData; /// /// // Note that the `demo` metho...
1
1
1
c3f40209dd0ea642ea99f0405d7c263382946e10
Jamey Sharp
2023-06-09T17:45:17
cranelift: don't enable trace-log feature by default (#6549) In #5382 ("egraph support: rewrite to work in terms of CLIF data structures"), we added the `trace-log` feature to the set of default features for `cranelift-codegen`. I think this was an accident, probably added while debugging and overlooked when cleaning ...
diff --git a/cranelift/codegen/Cargo.toml b/cranelift/codegen/Cargo.toml index 10135a654..9b2058042 100644 --- a/cranelift/codegen/Cargo.toml +++ b/cranelift/codegen/Cargo.toml @@ -44,7 +44,7 @@ cranelift-codegen-meta = { path = "meta", version = "0.98.0" } cranelift-isle = { path = "../isle/isle", version = "=0.98.0"...
1
1
1
7229ba90483a597c6c0a420af43e5bf382eab260
Saúl Cabrera
2023-06-07T22:03:07
winch: Fix `CodeGenContext::pop_to_reg` (#6535) This commit fixes the implementation of `pop_to_reg`. In the previous implementation, whenever a specific register was requested as the destination register and a register-to-register moved happened the source register was never marked as free. This issue became more ev...
diff --git a/winch/codegen/src/codegen/context.rs b/winch/codegen/src/codegen/context.rs index b2b647ef7..c744bd463 100644 --- a/winch/codegen/src/codegen/context.rs +++ b/winch/codegen/src/codegen/context.rs @@ -65,6 +65,9 @@ impl<'a> CodeGenContext<'a> { /// it isn't already one; spilling if there are no registe...
1
7
0
5c42fb490db525a0e3b5380e4216166df88b1151
Saúl Cabrera
2023-06-06T20:40:23
cranelift: Expose `MachLabel` (#6529) This is the first of a series of patches to support control flow in Winch. This change exposes `MachLabel` from cranelift for it to be consumed by Winch's `MacroAssembler` and `Assembler`.
diff --git a/cranelift/codegen/src/lib.rs b/cranelift/codegen/src/lib.rs index 899270a9e..9230d472e 100644 --- a/cranelift/codegen/src/lib.rs +++ b/cranelift/codegen/src/lib.rs @@ -94,7 +94,7 @@ pub use crate::machinst::buffer::{ }; pub use crate::machinst::{ CompiledCode, Final, MachBuffer, MachBufferFinalized,...
1
1
1
81cd998350faa0bb830d1d41a15a9c857103c161
Nick Fitzgerald
2023-06-06T18:04:38
A couple small Winch cleanups (#6526) * Winch: remove tabs, use spaces * Winch: remove unnecessary mutable references
diff --git a/winch/codegen/src/codegen/context.rs b/winch/codegen/src/codegen/context.rs index ff667537e..b2b647ef7 100644 --- a/winch/codegen/src/codegen/context.rs +++ b/winch/codegen/src/codegen/context.rs @@ -136,7 +136,7 @@ impl<'a> CodeGenContext<'a> { } /// Prepares arguments for emitting an i32 bina...
2
33
40
cca572678109ea7c4c322dad90c4e60a6e3c7a3e
Afonso Bordado
2023-06-06T17:28:54
fuzzgen: Fix timeout in interpreter vs interpreter mode (#6520)
diff --git a/fuzz/fuzz_targets/cranelift-fuzzgen.rs b/fuzz/fuzz_targets/cranelift-fuzzgen.rs index fe85eb375..131a88810 100644 --- a/fuzz/fuzz_targets/cranelift-fuzzgen.rs +++ b/fuzz/fuzz_targets/cranelift-fuzzgen.rs @@ -133,10 +133,14 @@ enum RunResult { impl PartialEq for RunResult { fn eq(&self, other: &Self...
1
17
4
550a16f53986bda0c3c8f12e31b1887bcb427987
Alex Crichton
2023-06-02T20:56:45
Fix a soundness issue with the component model and async (#6509) * Force `execute_across_threads` to use multiple threads Currently this uses tokio's `spawn_blocking` but that will reuse threads in its thread pool. Instead spawn a thread and perform a single poll on that thread to force lots of fresh threads to be us...
diff --git a/crates/fiber/src/lib.rs b/crates/fiber/src/lib.rs index 3e159ee70..79d7bdaa6 100644 --- a/crates/fiber/src/lib.rs +++ b/crates/fiber/src/lib.rs @@ -2,6 +2,7 @@ use std::any::Any; use std::cell::Cell; use std::io; use std::marker::PhantomData; +use std::ops::Range; use std::panic::{self, AssertUnwindSaf...
10
474
74
ace1388f603e487f21a369385137c2e15cb61d6e
Jeffrey Charles
2023-06-02T19:36:55
Use two operands for Winch's masm cmp_with_set method (#6511)
diff --git a/winch/codegen/src/isa/aarch64/masm.rs b/winch/codegen/src/isa/aarch64/masm.rs index e8788fe71..f092378cd 100644 --- a/winch/codegen/src/isa/aarch64/masm.rs +++ b/winch/codegen/src/isa/aarch64/masm.rs @@ -204,14 +204,7 @@ impl Masm for MacroAssembler { Address::offset(reg, offset as i64) } -...
4
10
39
2b20db1ce72e7d711612bf92c8f23fba3711e7fe
Jeffrey Charles
2023-06-02T14:58:21
Refactor Winch x64 asm operand checks (#6506)
diff --git a/winch/codegen/src/isa/x64/asm.rs b/winch/codegen/src/isa/x64/asm.rs index a0b21d862..ee442ffba 100644 --- a/winch/codegen/src/isa/x64/asm.rs +++ b/winch/codegen/src/isa/x64/asm.rs @@ -166,10 +166,7 @@ impl Assembler { Address::Offset { base, offset: imm } => self.mov_mr(*base, *imm, *reg, ...
1
17
24
d1a76282908dd74d5a720584f2cff5fd346aaf6c
Nick Fitzgerald
2023-06-01T23:06:32
Cranelift: clean up `adjust_stack_and_nominal_sp` helper (#6497) Stop passing around sign booleans and just use the signed integer type we already have at hand.
diff --git a/cranelift/codegen/src/machinst/abi.rs b/cranelift/codegen/src/machinst/abi.rs index 47320d61b..3b176d467 100644 --- a/cranelift/codegen/src/machinst/abi.rs +++ b/cranelift/codegen/src/machinst/abi.rs @@ -2138,15 +2138,14 @@ impl<M: ABIMachineSpec> CallSite<M> { } } -fn adjust_stack_and_nominal_sp<M...
1
12
11
eb47240157c094cb8ead186ccb06c414b7a5d8cf
Alex Crichton
2023-06-01T16:22:24
Fix `execute_across_threads` in tests (#6494) This commit fixes the helper function `execute_across_threads` in tests to actually execute across threads. This function was refactored in #3975 and accidentally introduced a bug where the future provided was polled once and then dropped, cancelling it instead of executin...
diff --git a/tests/all/async_functions.rs b/tests/all/async_functions.rs index c7071a27a..a966d4677 100644 --- a/tests/all/async_functions.rs +++ b/tests/all/async_functions.rs @@ -412,12 +412,16 @@ async fn async_host_func_with_pooling_stacks() -> Result<()> { Ok(()) } -async fn execute_across_threads<F: Futur...
1
7
3